1 2012-06-30 Glenn Morris <rgm@gnu.org>
3 * epaths.in (PATH_SITELOADSEARCH): New.
4 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
5 This is rather than relying on --enable-locallisppath elements
6 having "site-lisp" in their names. (Bug#10208#25, 11658)
8 2012-06-30 Eli Zaretskii <eliz@gnu.org>
10 * w32proc.c (sys_select): Accept and ignore one more argument.
12 * w32.c (emacs_gnutls_pull): Call select with one more argument.
14 * sysselect.h [DOS_NT]: Don't include sys/select.h.
15 (pselect) [!MS_DOS]: Redirect to sys_select.
17 * sysdep.c: Don't include dos.h and dosfns.h.
19 * process.c (sys_select):
20 * msdos.c (sys_select): Accept one more argument and ignore it.
22 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
23 adapt data types and code to that.
26 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
27 which clashes with the gnulib function of the same name.
29 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
31 * font.c (font_style_to_value, font_style_symbolic)
32 (font_prop_validate_style): Add type checks for values in
35 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
37 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
40 2012-06-29 Eli Zaretskii <eliz@gnu.org>
42 * xdisp.c (try_window_id): Undo last change.
44 * w32.c (getwd): Adjust commentary about startup_dir.
45 (init_environment): Always call sys_access, even in non-MSVC
46 builds. Don't chdir to the directory of the Emacs executable.
47 This undoes code from 1997 which was justified by the need to
48 "avoid conflicts when removing and renaming directories". But its
49 downside was that every relative file name was being interpreted
50 relative to the directory of the Emacs executable, which can never
51 be TRT. In particular, it broke sys_access when called with
53 (sys_access): Map GetLastError to errno.
55 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
57 * window.h (struct window): Change type of 'fringes_outside_margins'
58 to bitfield. Fix comment. Adjust users accordingly.
59 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
61 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
64 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
66 * gnutls.c (emacs_gnutls_handshake):
67 Add QUIT to make the loop interruptible.
69 2012-06-29 Glenn Morris <rgm@gnu.org>
71 * charset.c (init_charset): Make lack of etc/charsets fatal.
73 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
75 * editfns.c (region_limit): Fix type mismatch.
77 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
79 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
80 undefined. Convert from xassert to eassert.
81 * nsmenu.m: Convert from xassert to eassert.
84 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
86 * editfns.c (region_limit): Clip to narrowing (bug#11770).
88 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
90 Avoid integer overflow on scroll-left and scroll-right.
91 * window.c (HSCROLL_MAX): New macro.
92 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
93 overflow when requested scroll falls outside ptrdiff_t range.
95 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
97 * window.h (struct window): Change type of 'hscroll',
98 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
99 'last_modified' and 'last_overlay_modified' to EMACS_INT.
100 Adjust users accordingly.
101 * xdisp.c (try_cursor_movement): Replace type check with eassert.
102 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
103 from EMACS_INT to ptrdiff_t.
104 (make_window): Omit redundant initialization.
106 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
108 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
110 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
112 * window.h (struct window): Change type of 'use_time' and
113 'sequence_number' from Lisp_Object to int.
114 * frame.c (make_frame): Adjust users accordingly.
115 * print.c (print_object): Likewise.
116 * window.c (select_window, Fwindow_use_time, make_parent_window)
117 (make_window): Likewise.
119 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
121 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
122 enabled with --enable-checking=[all,glyphs] configure option.
123 Fix GLYPH_DEBUG usage assuming that it may be undefined,
124 adjust comments accordingly.
125 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
126 undefined, adjust comments accordingly.
128 * scroll.c: Likewise.
129 * w32fns.c: Likewise.
130 * w32term.c: Likewise.
132 * xfaces.c: Likewise.
136 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
138 Generalize run-time debugging checks.
139 * dispextern.h (XASSERTS): Remove.
140 * fontset.c (xassert): Remove.
141 Convert from xassert to eassert.
142 * alloc.c: Convert from xassert to eassert.
144 * dispnew.c: Likewise.
146 * fringe.c: Likewise.
147 * ftfont.c: Likewise.
148 * gtkutil.c: Likewise.
150 * keyboard.c: Likewise.
152 * process.c: Likewise.
153 * scroll.c: Likewise.
156 * w32console.c: Likewise.
157 * w32fns.c: Likewise.
158 * w32term.c: Likewise.
159 * window.c: Likewise.
161 * xfaces.c: Likewise.
163 * xselect.c: Likewise.
166 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
168 * fns.c (maybe_resize_hash_table): Output message when growing the
171 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
173 * alloc.c (allocate_string_data): Remove dead code.
174 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
175 avoid GCC warning about unused macro.
177 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
179 * alloc.c (allocate_string): Omit intervals initialization.
180 * alloc.c (make_uninit_multibyte_string): Initialize intervals
181 as in make_pure_string and make_pure_c_string.
183 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
185 * alloc.c (allocate_string): Fix last change.
187 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
189 * alloc.c (allocate_string): Remove two redundant calls
190 to memset, add explicit initialization where appropriate.
192 2012-06-27 Glenn Morris <rgm@gnu.org>
194 * lisp.mk (lisp): Remove paths.elc.
196 2012-06-27 Chong Yidong <cyd@gnu.org>
198 * doc.c (Fsubstitute_command_keys): Fix punctuation.
200 2012-06-26 John Wiegley <johnw@newartisans.com>
202 * unexmacosx.c (copy_data_segment): Add two section names used
203 on Mac OS X Lion: __mod_init_func and __mod_term_func.
205 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
206 when building with Clang.
208 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
210 * eval.c (Fapply): Allow calling it with a single argument.
212 2012-06-26 Eli Zaretskii <eliz@gnu.org>
214 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
215 _stricmp and _strnicmp.
216 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
218 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
220 * alloc.c (allocate_window): Zero out non-Lisp part of newly
222 (allocate_process): Likewise for new process.
223 (allocate_terminal): Change to use offsetof.
224 (allocate_frame): Likewise.
225 * frame.c (make_frame): Omit redundant initialization.
226 * window.c (make_parent_window): Use memset.
227 (make_window): Omit redundant initialization.
228 * process.c (make_process): Omit redundant initialization.
229 * terminal.c (create_terminal): Likewise.
231 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
233 * term.c (delete_tty): Remove redundant call to memset.
235 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
237 * alloc.c: Remove build_string.
238 * lisp.h: Define build_string as static inline. This provides
239 a better opportunity to optimize away calls to strlen when the
240 function is called with compile-time constant argument.
241 * image.c (imagemagick_error): Convert to build_string.
242 * w32proc.c (sys_spawnve): Likewise.
243 * xterm.c (x_term_init): Likewise.
245 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
247 Use sprintf return value instead of invoking strlen on result.
248 In the old days this wasn't portable, since some sprintf
249 implementations returned char *. But they died out years ago and
250 Emacs already assumes sprintf returns int.
251 Similarly for float_to_string.
252 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
253 * ccl.c (ccl_driver):
254 * character.c (string_escape_byte8):
255 * data.c (Fnumber_to_string):
257 * print.c (print_object):
258 * xdisp.c (message_dolog):
259 * xfns.c (syms_of_xfns):
260 Use sprintf or float_to_string result to avoid need to call strlen.
261 * data.c (Fnumber_to_string):
262 Use make_unibyte_string, since the string must be ASCII.
263 * lisp.h, print.c (float_to_string): Now returns int length.
264 * term.c (produce_glyphless_glyph):
265 Use sprintf result rather than recomputing it.
267 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
268 * Makefile.in (ALL_CFLAGS):
269 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
270 * gmalloc.c, regex.c: Include <config.h> unconditionally.
272 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
274 * dispextern.h (xstrcasecmp): Define to library function
275 strcasecmp if available.
276 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
278 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
280 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
281 Avoid comma operator.
282 * menu.c (push_submenu_start, push_submenu_end)
283 (push_left_right_boundary, push_menu_pane): Likewise.
284 * msdos.c (dos_rawgetc): Likewise.
286 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
288 * xfns.c (xic_create_fontsetname): Remove redundant calls
291 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
293 * gtkutil.c (get_utf8_string): Remove redundant assignment.
294 sprintf already null-terminates its output.
296 * xfns.c (x_window): Remove redundant cast.
298 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
300 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
301 `const char *' to `char *' to avoid compiler warning.
303 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
305 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
306 instead of truncating it to 63 (admittedly a generous limit).
308 * process.c: Fix spelling and caps in comments.
310 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
312 * emacs.c (setpgrp): Remove definition, unused.
313 * sysdep.c (setpgrp): Remove definition, not used in this file.
315 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
317 * makefile.w32-in: Update dependencies.
319 2012-06-24 Eli Zaretskii <eliz@gnu.org>
321 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
322 (SYSTIME_H): Add nt/inc/sys/time.h.
324 * systime.h [WINDOWSNT]: Include sys/time.h.
326 * s/ms-w32.h (struct timespec): Definition moved from
327 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
329 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
331 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
332 * buffer.h (buffer_slot_type_mismatch):
333 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
334 * eval.c (unwind_to_catch):
335 * image.c (my_png_error, my_error_exit):
336 * keyboard.c (quit_throw_to_read_char, user_error)
337 (Fexit_recursive_edit, Fabort_recursive_edit):
338 * lisp.h (die, args_out_of_range, args_out_of_range_3)
339 (wrong_type_argument, buffer_overflow, __executable_start)
340 (memory_full, buffer_memory_full, string_overflow, Fthrow)
341 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
342 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
344 (child_setup) [!DOS_NT]:
345 * lread.c (end_of_file_error, invalid_syntax):
346 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
347 * puresize.h (pure_write_error):
348 * search.c (matcher_overflow):
349 * sound.c (sound_perror, alsa_sound_perror):
350 * sysdep.c, syssignal.h (croak):
351 * term.c (maybe_fatal, vfatal):
352 * textprop.c (text_read_only):
353 * undo.c (user_error):
354 * unexmacosx.c (unexec_error):
355 * xterm.c (x_ins_del_lines, x_delete_glyphs):
356 Use _Noreturn rather than NO_RETURN.
357 No need for separate decl merely because of _Noreturn.
358 * sound.c (sound_warning, parse_sound):
359 Remove unnecessary forward decls.
361 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
363 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
364 * lisp.h (WAIT_READING_MAX): New macro.
365 * dispnew.c (Fsleep_for, sit_for):
366 * keyboard.c (kbd_buffer_get_event):
367 * process.c (Faccept_process_output):
368 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
369 This improves on the previous patch, which introduced a bug
370 when time_t is unsigned and as wide as intmax_t.
371 See <http://bugs.gnu.org/9000#51>.
373 2012-06-23 Eli Zaretskii <eliz@gnu.org>
375 * dispnew.c (sit_for, Fsleep_for):
376 * keyboard.c (kbd_buffer_get_event):
377 * process.c (Faccept_process_output): Avoid compiler warnings when
378 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
380 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
382 * makefile.w32-in: Update dependencies.
384 * w32.c (ltime): Add return type and declare static.
385 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
387 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
389 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
390 Privately reported by Herbert J. Skuhra.
391 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
393 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
394 not make_lisp_timeval, when the argument is of type EMACS_TIME.
396 2012-06-23 Eli Zaretskii <eliz@gnu.org>
398 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
399 last argument of make_unibyte_string.
401 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
402 language ID in the event parameters.
404 * w32term.c (w32_read_socket): Put the new keyboard codepage into
405 event.code, not the obscure "character set ID".
407 2012-06-23 Chong Yidong <cyd@gnu.org>
409 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
411 2012-06-23 Eli Zaretskii <eliz@gnu.org>
413 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
414 * w32.c (fdutimens): New function.
416 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
418 * s/ms-w32.h (pselect): Redirect to sys_select.
420 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
422 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
423 in the logic of incrementing and decrementing the value of
424 use_relocatable_buffers.
426 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
428 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
429 Privately reported by Herbert J. Skuhra.
430 [__FreeBSD__]: Remove "*/" typo after "#include".
431 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
432 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
433 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
434 Don't assume EMACS_TIME and struct timeval are the same type.
436 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
438 Support higher-resolution time stamps (Bug#9000).
439 The time stamps are only nanosecond-resolution at the C level,
440 since that's the best that any real-world system supports now.
441 But they are picosecond-resolution at the Lisp level, as that's
442 easy, and leaves room for future OS improvements.
444 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
447 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
448 Don't get current time unless it's needed.
450 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
451 now provides it if it's absent.
452 (start_atimer): Port to higher-res time stamps.
453 Check for time stamp overflow. Don't get current time more
454 often than is needed.
456 * buffer.h (struct buffer): Buffer modtime now has high resolution.
457 Include systime.h, not time.h.
458 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
460 * dired.c: Include stat-time.h.
461 (Ffile-attributes): File times now have higher resolution.
463 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
464 (struct image): Timestamp now has higher resolution.
466 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
467 has at least microseconds now. All uses removed.
468 (update_frame, update_single_window, update_window, update_frame_1)
469 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
471 * editfns.c (time_overflow): Now extern.
472 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
473 (float-time, Fformat_time_string, Fcurrent_time_string)
474 (Fcurrent_time_zone): Accept and generate higher-resolution
476 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
477 (decode_time_components, lisp_seconds_argument): New functions.
478 (make_time): Now static.
479 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
480 Report an error if the time is invalid, rather than having the caller
483 * fileio.c: Include <stat-time.h>
484 (Fcopy_file): Copy higher-resolution time stamps.
485 Prefer to set the time stamp via a file descriptor if that works.
486 (Fset_file_times, Finsert_file_contents, Fwrite_region)
487 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
488 (Fvisited_file_modtime, Fset_visited_file_modtime):
489 Support higher-resolution time stamps.
491 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
493 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
495 * image.c (prepare_image_for_display, clear_image_cache)
496 (lookup_image): Port to higer-resolution time stamps.
498 * keyboard.c (start_polling, bind_polling_period):
499 Check for time stamp overflow.
500 (read_char, kbd_buffer_get_event, timer_start_idle)
501 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
502 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
503 Port to higher-resolution time stamps. Do not assume time_t is signed.
504 (decode_timer): New function. Timers are now vectors of length 9,
505 not 8, to accommodate the picosecond component.
506 (timer_check_2): Use it.
508 * nsterm.m (select_timeout, timeval_subtract): Remove.
509 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
510 as they're a bit more accurate and handle overflow better.
511 (ns_select): Change prototype to be compatible with pselect.
512 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
513 * nsterm.h (ns_select): Adjust prototype.
515 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
516 us-resolution time stamps.
517 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
519 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
521 * lisp.h (time_overflow): New decl.
522 (wait_reading_process_output): First arg is now intmax_t, not int,
523 to accommodate larger waits.
525 * process.h (struct Lisp_Process.read_output_delay):
526 Now counts nanoseconds, not microseconds.
527 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
529 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
530 (wait_reading_process_output):
531 Port to ns-resolution time stamps.
532 (Faccept_process_output, wait_reading_process_output):
533 Check for time stamp overflow. Do not assume time_t is signed.
534 (select_wrapper): Remove; we now use pselect.
535 (Fprocess_attributes): Now generates ns-resolution time stamps.
537 * sysdep.c: Include utimens.h. Don't include utime.h
538 or worry about struct utimbuf; gnulib does that for us now.
539 (gettimeofday): Remove; gnulib provides a substitute.
540 (make_timeval): New function.
541 (set_file_times): Now sets ns-resolution time stamps.
542 New arg FD; all uses changed.
543 (time_from_jiffies, ltime_from_jiffies, get_up_time)
544 (system_process_attributes):
545 Now returns ns-resolution time stamp. All uses changed.
546 Check for time stamp overflow.
548 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
549 provides a substitute now.
551 * systime.h: Include timespec.h rather than sys/time.h and time.h,
552 since it guarantees struct timespec.
553 (EMACS_TIME): Now struct timespec, so that we can support
554 ns-resolution time stamps.
555 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
556 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
557 (EMACS_USECS): Remove.
558 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
559 so multiply the arg by 1000 before storing it.
560 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
562 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
563 Port to ns-resolution time stamps.
564 (EMACS_TIME_NEG_P): Remove; replaced by....
565 (EMACS_TIME_SIGN): New macro.
566 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
567 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
568 (set_file_times, make_time, lisp_time_argument): Adjust signature.
569 (make_timeval, make_lisp_time, decode_time_components): New decls.
570 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
571 that it mishandled time_t overflow. You can't compare by subtracting!
572 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
573 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
575 * term.c: Include <sys/time.h>.
576 (timeval_to_Time): New function, for proper overflow wraparound.
577 (term_mouse_position, term_mouse_click): Use it.
579 * undo.c (record_first_change): Support higher-resolution time stamps
581 (Fprimitive_undo): Use them when restoring time stamps.
583 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
584 (w32_get_internal_run_time):
585 Port to higher-resolution Emacs time stamps.
586 (ltime): Now accepts single 64-bit integer, as that's more convenient
589 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
591 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
592 for compatibility with pselect. Support ns-resolution time stamps.
594 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
596 * xselect.c (wait_for_property_change, x_get_foreign_selection):
597 Check for time stamp overflow, and support ns-resolution time stamps.
599 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
600 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
601 (timeval_subtract): Remove; no longer needed.
602 (XTflash, XTring_bell, x_wait_for_event):
603 Port to ns-resolution time stamps. Don't assume time_t is signed.
605 2012-06-22 Chong Yidong <cyd@gnu.org>
607 * xdisp.c (x_consider_frame_title): Revert last change.
609 2012-06-22 Eli Zaretskii <eliz@gnu.org>
611 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
612 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
613 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
614 staticidx goes up to 1597 out of 1600 = 0x640.)
616 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
618 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
619 Otherwise, the umask might be mistakenly 0 while handling input signals.
621 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
623 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
625 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
627 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
628 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
629 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
630 access to `contents' member of Lisp_Vector objects with AREF and ASET
633 2012-06-19 Chong Yidong <cyd@gnu.org>
635 * frame.c (delete_frame): When selecting a frame on a different
636 text terminal, do not alter the terminal's top-frame.
638 * xdisp.c (format_mode_line_unwind_data): Record the target
639 frame's selected window and its terminal's top-frame.
640 (unwind_format_mode_line): Restore them.
641 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
643 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
644 since tty frames can be explicitly named.
645 (prepare_menu_bars): Likewise.
647 * term.c (Ftty_top_frame): New function.
649 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
651 Port byte-code-meter to modern targets.
652 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
653 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
654 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
655 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
656 (METER_1, METER_2): Simplify.
658 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
660 * data.c (Fdefalias): Return `symbol' (bug#11686).
662 2012-06-18 Martin Rudalics <rudalics@gmx.at>
664 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
665 gets killed during executing of this function (Bug#11665).
666 Try to always return Qt when the buffer has been actually killed.
667 (Vkill_buffer_query_functions): In doc-string say that functions
668 run by this hook should not change the current buffer.
670 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
672 Fix recently-introduced process.c problems found by static checking.
673 * process.c (write_queue_push, write_queue_pop, send_process):
674 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
675 (write_queue_pop): Fix pointer signedness problem.
676 (send_process): Remove unused local.
678 2012-06-17 Chong Yidong <cyd@gnu.org>
680 * xdisp.c (redisplay_internal): No need to redisplay terminal
681 frames that are not on top.
683 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
685 * process.c (make_process): Initialize write_queue.
686 (write_queue_push, write_queue_pop): New functions.
687 (send_process): Use them to maintain correct ordering of process
690 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
692 * lisp.h (eassert): Assume C89 or later.
693 This removes the need for CHECK.
694 (CHECK): Remove. Its comments about always evaluating its
695 argument were confusing, as 'eassert' typically does not evaluate
698 * coding.c (produce_chars): Use ptrdiff_t, not int.
700 * xterm.c (x_draw_underwave): Check for integer overflow.
701 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
703 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
705 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
706 referenced (Bug#11583).
708 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
710 Implement wave-style variant of underlining.
711 * dispextern.h (face_underline_type): New enum.
712 (face): Add field for underline type.
713 * nsterm.m (ns_draw_underwave): New function.
714 (ns_draw_text_decoration): Use it.
715 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
717 (x_draw_glyph_string): Use them.
718 * xfaces.c (Qline, Qwave): New Lisp objects.
719 (check_lface_attrs, merge_face_ref)
720 (Finternal_set_lisp_face_attribute, realize_x_face):
721 Handle wave-style underline face attributes.
722 * xterm.c (x_draw_underwave): New function.
723 (x_draw_glyph_string): Use it.
725 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
727 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
728 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
729 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
730 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
731 ($(BLD)/w32select.$(O)): Update dependencies.
733 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
735 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
736 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
737 * character.c (_fetch_multibyte_char_p): Remove.
738 * alloc.c: Include "character.h" before "buffer.h".
740 * buffer.c: Likewise.
741 * bytecode.c: Likewise.
742 * callint.c: Likewise.
743 * callproc.c: Likewise.
744 * casefiddle.c: Likewise.
745 * casetab.c: Likewise.
746 * category.c: Likewise.
748 * coding.c: Likewise.
749 * composite.c: Likewise.
751 * dispnew.c: Likewise.
753 * dosfns.c: Likewise.
754 * editfns.c: Likewise.
756 * fileio.c: Likewise.
757 * filelock.c: Likewise.
759 * fontset.c: Likewise.
760 * fringe.c: Likewise.
761 * indent.c: Likewise.
762 * insdel.c: Likewise.
763 * intervals.c: Likewise.
764 * keyboard.c: Likewise.
765 * keymap.c: Likewise.
767 * macros.c: Likewise.
768 * marker.c: Likewise.
769 * minibuf.c: Likewise.
771 * nsmenu.m: Likewise.
773 * process.c: Likewise.
775 * region-cache.c: Likewise.
776 * search.c: Likewise.
777 * syntax.c: Likewise.
779 * textprop.c: Likewise.
781 * unexsol.c: Likewise.
782 * w16select.c: Likewise.
783 * w32fns.c: Likewise.
784 * w32menu.c: Likewise.
785 * window.c: Likewise.
790 * xselect.c: Likewise.
792 2012-06-16 Eli Zaretskii <eliz@gnu.org>
794 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
795 If all the glyphs of the glyph row came from strings, and we have no
796 cursor positioning clues, put the cursor on the first glyph of the
798 (handle_face_prop): Use chunk-relative overlay string index when
799 indexing into it->string_overlays array. (Bug#11653)
800 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
801 the rightmost. (Bug#11720)
803 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
805 * category.h (CHAR_HAS_CATEGORY): Define as inline.
806 (CATEGORY_MEMBER): Enforce 1/0 value.
807 * category.c (_temp_category_set): Remove.
809 2012-06-16 Eli Zaretskii <eliz@gnu.org>
811 * window.c (Fdelete_other_windows_internal)
812 (Fdelete_window_internal): Don't access frame's mouse highlight
813 info of the initial frame. (Bug#11677)
815 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
817 * .gdbinit (xgetint): Fix recently-introduced paren typo.
818 Assume USE_2_TAGS_FOR_INTS.
819 (xreload): Adjust $tagmask width to match recent lisp.h change.
821 Simplify lisp.h in minor ways that should not affect code.
822 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
823 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
824 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
825 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
826 (INTTYPEBITS): New macro, for clarity.
827 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
828 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
829 Simplify now that USE_LSB_TAG is always defined.
830 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
831 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
833 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
835 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
837 2012-06-13 Glenn Morris <rgm@gnu.org>
839 * s/bsd-common.h (BSD4_3):
840 * s/usg5-4-common.h (USG5_4): No longer define; unused.
842 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
844 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
847 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
849 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
850 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
851 * alloc.c (widen_to_Lisp_Object): Remove.
852 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
853 * frame.c (delete_frame): Remove outdated comment.
854 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
856 (Fw32_unregister_hot_key): Likewise.
857 (Fw32_toggle_lock_key): Likewise.
858 * w32menu.c (add_menu_item): Likewise.
859 (w32_menu_display_help): Use XIL instead of checking
861 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
862 (init_heap): Likewise.
863 * w32term.c (w32_read_socket): Update comment.
865 2012-06-13 Glenn Morris <rgm@gnu.org>
867 * s/usg5-4-common.h, src/s/unixware.h:
868 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
870 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
872 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
874 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
875 * alloc.c (make_number) [!defined make_number]:
876 Remove, as lisp.h always defines this now.
877 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
878 (roundup_size): Verify that it is a power of 2.
879 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
880 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
881 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
882 -DUSE_LSB_TAG=0, to override the automatically-selected default.
883 USE_LSB_TAG now is always defined to be either 0 or 1.
885 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
886 code works fine either way, and efficiency is not a concern here,
887 as the union type is for debugging, not for production.
888 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
889 Use an inline function on all platforms when using the union type,
890 since this is simpler and 'static inline' can be used portably
892 (LISP_INITIALLY_ZERO): New macro.
893 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
894 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
896 2012-06-12 Glenn Morris <rgm@gnu.org>
898 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
900 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
902 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
903 Move BROKEN_SIGIO to configure.
905 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
906 Move NO_TERMIO to configure.
908 2012-06-12 Chong Yidong <cyd@gnu.org>
910 * image.c (imagemagick_load_image): Use MagickFlattenImage if
911 MagickMergeImageLayers is undefined. Use pixel pusher loop if
912 MagickExportImagePixels is undefined.
914 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
916 * image.c (imagemagick_load_image): Remove unused label.
918 2012-06-11 Glenn Morris <rgm@gnu.org>
920 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
921 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
922 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
923 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
925 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
927 * alloc.c (make_byte_code): New function.
928 (Fmake_byte_code): Use it. Don't purify here.
929 * lread.c (read1): Use it as well to avoid extra allocation.
931 2012-06-11 Chong Yidong <cyd@gnu.org>
933 * image.c (imagemagick_load_image): Implement transparency.
935 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
937 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
938 account for preceding backslashes. (Bug#11663)
940 2012-06-09 Chong Yidong <cyd@gnu.org>
942 * term.c: Support italics in capable terminals (Bug#9652).
943 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
944 (turn_on_face): Output using TS_enter_italic_mode if available.
945 Don't handle unused blinking and alt-charset cases.
946 (turn_off_face): Handle italic case; discard unused tty_blinking_p
947 and tty_alt_charset_p cases.
948 (tty_capable_p, init_tty): Support italics.
950 * termchar.h (struct tty_display_info): Add field for italics.
951 Remove unused blink field.
953 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
956 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
957 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
958 tty_alt_charset_p. Add tty_italic_p.
960 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
962 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
963 dbus_type_is_basic if available.
964 (xd_extract_signed, xd_extract_unsigned): Rename from
965 extract_signed and extract_unsigned, respectively. Adapt callers.
967 2012-06-09 Chong Yidong <cyd@gnu.org>
969 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
971 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
974 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
976 * xdisp.c (vmessage): Treat frame message as multibyte.
977 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
978 would generate the diagnostic "Making \302\247 buffer-local while
981 2012-06-08 Eli Zaretskii <eliz@gnu.org>
983 * dispnew.c (showing_window_margins_p): Undo last change, which
984 was done due to an inadvertent commit.
985 (adjust_frame_glyphs_for_frame_redisplay): Do call
986 showing_window_margins_p.
988 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
990 * eval.c (Fmake_var_non_special): New primitive.
991 (syms_of_eval): Defsubr it.
992 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
994 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
996 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
997 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
999 2012-06-08 Eli Zaretskii <eliz@gnu.org>
1001 * alloc.c (allocate_vectorlike): Fix last change.
1003 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1005 Block-based vector allocation of small vectors.
1006 * lisp.h (struct vectorlike_header): New field `nbytes',
1007 adjust comment accordingly.
1008 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1009 to denote vector blocks. Adjust users (live_vector_p,
1010 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1011 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1012 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1013 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1014 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1015 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1016 (roundup_size): New constant.
1017 (struct vector_block): New data type.
1018 (vector_blocks, vector_free_lists, zero_vector): New variables.
1019 (all_vectors): Rename to `large_vectors'.
1020 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1021 (sweep_vectors): New functions.
1022 (allocate_vectorlike): Return `zero_vector' as the only vector of
1023 0 items. Allocate new vector from block if vector size is less than
1024 or equal to VBLOCK_BYTES_MAX.
1025 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1026 (init_alloc_once): Add call to init_vectors.
1028 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1030 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1032 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1034 * doprnt.c (doprnt): Truncate multibyte char correctly.
1035 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1036 would mishandle a string argument "Xc" if X was a multibyte
1037 character of length 2: it would truncate after X's first byte
1038 rather than including all of X.
1040 2012-06-06 Chong Yidong <cyd@gnu.org>
1042 * buffer.c (word_wrap): Doc fix.
1044 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1046 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1048 2012-06-03 Glenn Morris <rgm@gnu.org>
1050 * xdisp.c (tool-bar-style): Doc fix.
1052 2012-06-03 Ulrich Müller <ulm@gentoo.org>
1054 * Makefile.in (PAXCTL): Define.
1055 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1056 binary via PaX flags if the paxctl utility is available.
1057 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1058 Restore PaX flags to their default. (Bug#11398)
1060 2012-06-03 Chong Yidong <cyd@gnu.org>
1062 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1065 2012-06-03 Chong Yidong <cyd@gnu.org>
1067 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1068 (note_mode_line_or_margin_highlight): If there is no help echo,
1069 use mode-line-default-help-echo. Handle the case where the mouse
1070 position is past the end of the mode line string.
1072 * buffer.c (buffer_local_value_1): New function, split from
1073 Fbuffer_local_value; can return Qunbound.
1074 (Fbuffer_local_value): Use it.
1075 (Vmode_line_format): Docstring tweaks.
1077 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1079 * sysdep.c (system_process_attributes): Improve comment.
1081 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1083 * keyboard.c: Export real-this-command to Elisp.
1084 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1085 and DEFVAR it. Update all users.
1087 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1089 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1091 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1092 Convert pctcpu and pctmem to Lisp float properly.
1093 Let the compiler fold better, as 100.0/0x8000 is exact.
1095 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1097 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1100 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1102 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1104 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1106 For a 'struct window', replace some Lisp_Object fields to
1107 bitfields where appropriate, remove unused fields.
1108 * window.h (struct window): Remove unused 'last_mark_x' and
1109 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1110 change it's type from Lisp_Object to bitfield.
1111 Change type of 'force_start', 'optional_new_start',
1112 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1113 fields from Lisp_Object to bitfield. Adjust users accordingly.
1115 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1117 Pacify gcc -Wdouble-precision when using Xaw.
1118 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1119 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1120 Use 'float' consistently, rather than 'float' in most places
1121 and 'double' in a couple of places.
1123 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1125 * xdisp.c (handle_stop): Detect whether we have overlay strings
1126 loaded by testing it->current.overlay_string_index to be
1127 non-negative, instead of checking whether n_overlay_strings is
1128 positive. (Bug#11587)
1130 2012-05-31 Chong Yidong <cyd@gnu.org>
1132 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1134 * doc.c (Fsubstitute_command_keys): Doc fix.
1136 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1138 * search.c (search_buffer): Remove calls to
1139 r_alloc_inhibit_buffer_relocation, as it is now called by
1140 maybe_unify_char, which was the cause of relocation of buffer text
1143 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1145 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1146 for the duration of call to load_charset, to avoid problems with
1147 callers of maybe_unify_char that access buffer text through C
1150 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1151 decrement the inhibition flag, instead of just setting or
1154 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1156 Remove obsolete '#define static' cruft.
1157 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1158 This #undef was "temporary" in 2000; it is no longer needed
1159 now that '#define static' has gone away.
1160 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1161 (gray_bitmap_bits): Remove; no longer needed.
1162 All uses replaced with definiens.
1163 * xterm.c: Include "bitmaps/gray.xbm".
1165 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1167 Clean up __executable_start, monstartup when --enable-profiling.
1168 The following changes affect the code only when profiling.
1169 * dispnew.c (__executable_start): Rename from safe_bcopy.
1170 Define only on platforms that need it.
1171 * emacs.c: Include <sys/gmon.h> when profiling.
1172 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1173 (__executable_start): Remove decl, since lisp.h does it now.
1174 (safe_bcopy): Remove decl; no longer has that name.
1175 (main): Coalesce #if into single bit of code, for simplicity.
1176 Cast pointers to uintptr_t, since standard libraries want integers
1178 * lisp.h (__executable_start): New decl.
1180 2012-05-31 Glenn Morris <rgm@gnu.org>
1182 * image.c (Fimagemagick_types): Doc fix.
1184 2012-05-30 Jim Meyering <meyering@redhat.com>
1186 * callproc.c (Fcall_process_region): Include directory component
1187 in mkstemp error message (Bug#11586).
1189 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1191 * alloc.c, lisp.h (make_pure_vector): Now static.
1193 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1195 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1196 Move to byte-run.el.
1197 (Fautoload): Do the hash-doc more carefully.
1198 * data.c (Fdefalias): Purify definition, except for keymaps.
1199 (Qdefun): Move from eval.c.
1200 * lisp.h (Qdefun): Remove.
1201 * lread.c (read1): Tiny simplification.
1203 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
1205 Do not create empty overlays with the evaporate property (Bug#9642).
1206 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1207 Bug#9642, but explicitly check that the buffer the overlay would
1208 be moved to is live and rearrange lines to make sure that errors
1209 will not put the overlay in an inconsistent state.
1210 (Fdelete_overlay): Cosmetics.
1212 2012-05-28 Eli Zaretskii <eliz@gnu.org>
1214 * w32term.c (my_bring_window_to_top): New function.
1215 (x_raise_frame): Use handle returned by DeferWindowPos, which
1216 could be different from the original one.
1217 Call my_bring_window_to_top instead of my_set_foreground_window.
1220 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1221 by calling BringWindowToTop.
1223 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1224 (WM_EMACS_END): Increase by one.
1226 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1228 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1229 This avoids undefined behavior that might cause the eassert
1230 to not catch an out-of-range value.
1232 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
1234 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1235 Update dependencies.
1237 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1239 * bidi.c (bidi_mirror_char): Fix last change.
1241 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1243 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1244 when referring to sectname field in printf format.
1246 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1248 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1249 Only r_alloc_inhibit_buffer_relocation needed to be added;
1250 the others were already declared.
1252 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1253 before checking whether it's out of range. Put the check inside
1255 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1257 2012-05-27 Ken Brown <kbrown@cornell.edu>
1259 * callproc.c (Fcall_process): Restore a line that was accidentally
1260 commented out in the 2011-02-13 change (bug#11547).
1262 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1264 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1265 defined on ralloc.c.
1267 * buffer.c [REL_ALLOC]: Remove prototypes of
1268 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1269 they are now on lisp.h.
1271 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1273 * search.c (search_buffer): Use it to inhibit relocation of buffer
1274 text while re_search_2 is doing its job, because re_search_2 is
1275 passed C pointers to buffer text. (Bug#11519)
1277 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1280 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1281 state after an additional call to move_it_in_display_line_to, keep
1282 the values of it->max_ascent and it->max_descent found for the
1284 (pos_visible_p): Revert the comparison against bottom_y to what it
1285 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1288 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1290 Fix coding-related core dumps with gcc -ftrapv.
1291 The code was computing A - B, where A and B are pointers, and B is
1292 random garbage. This can lead to core dumps on platforms that
1293 have special pointer registers, and it also leads to core dumps on
1294 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1295 A - B only when B is initialized properly.
1296 * coding.c (coding_set_source, coding_set_destination): Return void.
1297 (coding_change_source, coding_change_destinations): New functions,
1298 with the old behaviors of coding_set_source and coding_set_destination.
1299 All callers that need an offset changed to use these new functions.
1301 2012-05-26 Glenn Morris <rgm@gnu.org>
1303 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1305 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1307 Extend mouse support on W32 text-mode console.
1308 * xdisp.c (draw_row_with_mouse_face):
1309 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
1311 * w32console.c: Include window.h.
1312 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1314 (initialize_w32_display): Initialize mouse-highlight data.
1316 * w32inevt.c: Include termchar.h and window.h.
1317 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1318 moves, call note_mouse_highlight. If help_echo changed, call
1319 gen_help_event to produce help-echo message in the echo area.
1320 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1323 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1325 * lread.c (read1): Simplify slightly to avoid an overflow warning
1326 with GCC 4.7.0 on x86-64.
1328 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1330 * bidi.c (bidi_mirror_char): Revert last change: an int is
1331 definitely wide enough here.
1333 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
1335 Fix integer width and related bugs (Bug#9874).
1336 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
1337 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1338 (string_bytes, check_sblock, allocate_string_data):
1339 (compact_small_strings, Fmake_bool_vector, make_string)
1340 (make_unibyte_string, make_multibyte_string)
1341 (make_string_from_bytes, make_specified_string)
1342 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1343 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1345 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1346 (allocate_pseudovector):
1347 Use int, not EMACS_INT, where int is wide enough.
1348 (inhibit_garbage_collection, Fgarbage_collect):
1349 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1350 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1351 int might not be wide enough.
1352 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1353 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1354 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1355 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1356 (bidi_level_of_next_char, bidi_move_to_visually_next):
1357 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1358 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1359 (Fkill_buffer, Fset_buffer_major_mode)
1360 (advance_to_char_boundary, Fbuffer_swap_text)
1361 (Fset_buffer_multibyte, overlays_at, overlays_in)
1362 (overlay_touches_p, struct sortvec, record_overlay_string)
1363 (overlay_strings, recenter_overlay_lists)
1364 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1365 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1366 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1367 (Foverlay_recenter, last_overlay_modification_hooks_used)
1368 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1369 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1370 (validate_region): Omit unnecessary test for b <= e,
1371 since that's guaranteed by the previous test.
1372 (adjust_overlays_for_delete): Avoid pos + length overflow.
1373 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1374 (report_overlay_modification):
1375 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1376 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1377 Omit pointer cast, which isn't needed anyway, and doesn't work
1378 after the EMACS_INT -> ptrdiff_t change.
1379 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
1380 * buffer.h: Adjust decls to match defn changes elsewhere.
1381 (struct buffer_text, struct buffer):
1382 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1383 Use EMACS_INT, not int, where int might not be wide enough.
1384 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1385 not int, to avoid needless 32-bit limit on 64-bit hosts.
1386 (exec_byte_code): Use tighter memory-full test, one that checks
1387 for alloca overflow. Don't compute the address of the object just
1388 before an array, as that's not portable. Use EMACS_INT, not
1389 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
1390 * callint.c (Fcall_interactively):
1391 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1392 * callproc.c (call_process_kill, Fcall_process):
1393 Don't assume pid_t fits into an Emacs fixnum.
1394 (call_process_cleanup, Fcall_process, child_setup):
1395 Don't assume pid_t fits into int.
1396 (call_process_cleanup, Fcall_process, delete_temp_file)
1397 (Fcall_process_region):
1398 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1399 (Fcall_process): Simplify handling of volatile integers.
1400 Use int, not EMACS_INT, where int will do.
1401 * casefiddle.c (casify_object, casify_region, operate_on_word)
1402 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1403 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1404 (casify_object): Avoid integer overflow when overallocating buffer.
1405 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
1406 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
1407 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1408 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1409 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1410 integers are now checked earlier. All uses replaced with XINT.
1412 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1413 For CCL_MapSingle, check that content and value are in int range.
1414 (ccl_driver, Fregister_code_conversion_map):
1415 Check that Vcode_version_map_vector is a vector.
1416 (resolve_symbol_ccl_program): Check that vector header is in range.
1417 Always copy the vector, so that we can check its contents reliably
1418 now rather than having to recheck each instruction as it's being
1419 executed. Check that vector words fit in 'int'.
1420 (ccl_get_compiled_code, Fregister_ccl_program)
1421 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1422 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1423 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1424 contents are in range.
1425 (Fccl_execute_on_string): Check that status is in range.
1426 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1427 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1428 Accept and return EMACS_INT, not int, because callers can pass values
1430 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1431 (multibyte_chars_in_text, parse_str_as_multibyte)
1432 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1433 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1434 (string_escape_byte8, Fget_byte):
1435 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1436 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
1437 avoid mishandling large integers.
1438 * character.h: Adjust decls to match defn changes elsewhere.
1439 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1440 (Ffind_charset_region):
1441 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1442 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1443 (load_charset_map_from_vector, Fdefine_charset_internal):
1444 Don't assume fixnum fits in int.
1445 (load_charset_map_from_vector, Fmap_charset_chars):
1446 Remove now-unnecessary CHECK_NATNUMs.
1447 (Fdefine_charset_internal): Check ranges here, more carefully.
1448 Don't rely on undefined behavior with signed left shift overflow.
1449 Don't assume unsigned int fits into fixnum, or that fixnum fits
1450 into unsigned int. Don't require max_code to be a valid fixnum;
1451 that's not true for gb10830 4-byte on a 32-bit host. Allow
1452 invalid_code to be a cons, for the same reason. Require code_offset
1453 to be a character. Avoid int overflow if max_char is close
1455 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1456 this is intended anyway and avoids some undefined behavior.
1457 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1458 INDEX_TO_CODE_POINT, as that's what it expects.
1459 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
1460 * charset.h (DECODE_CHAR): Return int, not unsigned;
1461 this is what was intended anyway, and it avoids undefined behavior.
1462 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1463 integer-overflow issues.
1464 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1465 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1466 where the argument is EMACS_INT, and this behavior is not intended.
1467 * chartab.c (Fmake_char_table, Fset_char_table_range)
1468 (uniprop_get_decoder, uniprop_get_encoder):
1469 Don't assume fixnum fits in int.
1470 * cmds.c (move_point): New function, that does the gist of
1471 Fforward_char and Fbackward_char, but does so while checking
1472 for integer overflow more accurately.
1473 (Fforward_char, Fbackward_char): Use it.
1474 (Fforward_line, Fend_of_line, internal_self_insert)
1475 (internal_self_insert):
1476 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1477 Fix a FIXME, by checking for integer overflow when calculating
1478 target_clm and actual_clm.
1479 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
1480 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
1481 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1482 (coding_alloc_by_making_gap, alloc_destination)
1483 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1484 (encode_coding_utf_16, detect_coding_emacs_mule)
1485 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1486 (detect_coding_iso_2022, decode_coding_iso_2022)
1487 (encode_invocation_designation, encode_designation_at_bol)
1488 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1489 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1490 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1491 (encode_coding_ccl, encode_coding_raw_text)
1492 (detect_coding_charset, decode_coding_charset)
1493 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1494 (produce_composition, produce_charset, produce_annotation)
1495 (decode_coding, handle_composition_annotation)
1496 (handle_charset_annotation, consume_chars, decode_coding_gap)
1497 (decode_coding_object, encode_coding_object, detect_coding_system)
1498 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1499 (code_convert_region, code_convert_string)
1500 (Fdefine_coding_system_internal)
1501 (coding_set_source, coding_set_destination):
1502 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1503 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1504 (Fdefine_coding_system_internal):
1505 Don't assume fixnums fit in int.
1506 (decode_coding_gap, decode_coding_object, encode_coding_object)
1507 (Fread_coding_system, Fdetect_coding_region)
1508 (Funencodable_char_position, Fcheck_coding_systems_region)
1509 (get_translation, handle_composition_annotation, consume_chars):
1510 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1511 (consume_chars): Rewrite to not calculate an address outside buffer.
1512 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
1513 Don't access memory outside of the args array.
1514 (Fdefine_coding_system_internal): Check for charset-id overflow.
1515 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1516 result of ENCODE_CHAR.
1517 * coding.h: Adjust decls to match defn changes elsewhere.
1518 (struct coding_system):
1519 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1520 * composite.c (get_composition_id, find_composition)
1521 (run_composition_function, update_compositions)
1522 (compose_text, composition_gstring_put_cache)
1523 (composition_gstring_p, composition_gstring_width)
1524 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1525 (composition_compute_stop_pos, composition_reseat_it)
1526 (composition_update_it, struct position_record)
1527 (find_automatic_composition, composition_adjust_point)
1528 (Fcomposition_get_gstring, Ffind_composition_internal):
1529 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1530 (update_compositions):
1531 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1532 * composite.h: Adjust decls to match defn changes elsewhere.
1533 (struct composition):
1534 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1535 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1536 Do not attempt to compute the address of the object just before a
1537 buffer; this is not portable.
1539 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1540 (Faset): Use int, not EMACS_INT, where int is wide enough.
1541 (Fstring_to_number): Don't assume fixnums fit in int.
1542 (Frem): Don't assume arg is nonnegative.
1543 * dbusbind.c (xd_append_arg): Check for integers out of range.
1544 (Fdbus_call_method): Don't overflow the timeout int.
1545 (extract_signed, extract_unsigned): New functions.
1546 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1547 (xd_get_connection_references): Return ptrdiff_t, not int.
1549 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1550 (xd_read_message_1):
1551 Use int, not unsigned, where the dbus API uses int.
1552 (Fdbus_message_internal): Don't overflow mtype.
1553 (syms_of_dbusbind): Allocate right-sized buffer for integers.
1554 * dired.c (directory_files_internal, file_name_completion, scmp)
1555 (file_name_completion_stat):
1556 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1557 (file_name_completion): Don't overflow matchcount.
1558 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1559 * dispextern.h: Adjust decls to match defn changes elsewhere.
1560 (struct text_pos, struct glyph, struct bidi_saved_info)
1561 (struct bidi_string_data, struct bidi_it, struct composition_it)
1563 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1564 (struct display_pos, struct composition_it, struct it):
1565 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1566 * dispnew.c (increment_matrix_positions)
1567 (increment_row_positions, mode_line_string)
1568 (marginal_area_string):
1569 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1570 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
1571 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1572 (duration_to_sec_usec): New function, to check for overflow better.
1573 (Fsleep_for, sit_for): Use it.
1574 * doc.c (get_doc_string, store_function_docstring):
1575 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1576 (get_doc_string, Fsnarf_documentation):
1577 Use int, not EMACS_INT, where int is wide enough.
1579 Use SAFE_ALLOCA, not alloca.
1580 Check for overflow when converting EMACS_INT to off_t.
1581 * doprnt.c (doprnt):
1582 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1583 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1584 Don't assume uid_t fits into fixnum.
1585 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1586 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1587 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1588 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1589 (general_insert_function)
1590 (Finsert_char, make_buffer_string, make_buffer_string_both)
1591 (update_buffer_properties, Fbuffer_substring)
1592 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1593 (Fsubst_char_in_region, check_translation)
1594 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1595 (transpose_markers, Ftranspose_regions):
1596 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1597 (clip_to_bounds): Move to lisp.h as an inline function).
1598 (Fconstrain_to_field): Don't assume integers are nonnegative.
1599 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1600 (Fsubst_char_in_region, Fsave_restriction):
1601 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1602 (Femacs_pid): Don't assume pid_t fits into fixnum.
1603 (lo_time): Use int, not EMACS_INT, when int suffices.
1604 (lisp_time_argument): Check for usec out of range.
1605 (Fencode_time): Don't assume fixnum fits in int.
1606 (Fuser_login_name, Fuser_full_name): Signal an error
1607 if a uid argument is out of range, rather than relying on
1609 (Fformat_time_string): Remove now-unnecessary check.
1610 lisp_time_argument checks for out-of-range usec now.
1611 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
1612 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1613 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1614 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1615 (init_cmdargs, Fdump_emacs):
1616 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1617 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1618 the bottom (typically) 32 bits of the fixnum.
1619 * eval.c (specpdl_size, call_debugger):
1620 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1621 (when_entered_debugger, Fbacktrace_debug):
1622 Don't assume fixnum can fit in int.
1623 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1624 the object just before a buffer; this is not portable.
1625 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1626 (grow_specpdl, unbind_to):
1627 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1628 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1629 (grow_specpdl): Simplify allocation by using xpalloc.
1630 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
1631 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1632 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1633 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1634 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1636 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1637 (Fcopy_file, non_regular_nbytes, read_non_regular)
1638 (Finsert_file_contents):
1639 Use int, not EMACS_INT, where int is wide enough.
1640 (READ_BUF_SIZE): Verify that it fits in int.
1641 (Finsert_file_contents): Check that counts are in proper range,
1642 rather than assuming fixnums fit into ptrdiff_t etc.
1643 Don't assume fixnums fit into int.
1644 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
1645 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1646 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
1647 (string_char_to_byte, string_byte_to_char)
1648 (string_make_multibyte, string_to_multibyte)
1649 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1650 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1651 (substring_both, Fdelete, internal_equal, Ffillarray)
1652 (Fclear_string, mapcar1)
1653 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1654 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1655 (larger_vector, make_hash_table, maybe_resize_hash_table)
1656 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1657 (Fmaphash, secure_hash):
1658 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1659 (concat): Check for string index and length overflow.
1660 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1662 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1663 (larger_vector): New API (vec, incr_min, size_max) replaces old
1664 one (vec, new_size, init). This catches size overflow.
1665 INIT was removed because it was always Qnil.
1666 All callers changed.
1667 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1668 the upper bound on a hash table index size.
1669 (make_hash_table, maybe_resize_hash_table): Use it.
1670 (secure_hash): Computer start_byte and end_byte only after
1671 they're known to be in ptrdiff_t range.
1672 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1673 (Ffont_get_glyphs, Ffont_at):
1674 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1675 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1676 (Flist_fonts, Fopen_font):
1677 Don't assume fixnum can fit in int.
1678 (check_gstring): Don't assume index can fit in int.
1679 (font_match_p): Check that fixnum is a character, not a nonnegative
1680 fixnum, since the later code needs to stuff it into an int.
1681 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1682 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1683 conversion overflow issues.
1684 (Fopen_font): Check for integer out of range.
1685 (Ffont_get_glyphs): Don't assume index can fit in int.
1686 * font.h: Adjust decls to match defn changes elsewhere.
1687 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1689 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1690 printmax_t, where ptrdiff_t is wide enough.
1691 (Finternal_char_font):
1692 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1693 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1694 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1695 (Fset_frame_position, x_set_frame_parameters)
1696 (x_set_line_spacing, x_set_border_width)
1697 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1698 Check that fixnums are in proper range for system types.
1699 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1700 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1701 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1702 Use SAFE_ALLOCA_LISP, not alloca.
1703 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1704 intptr_t is wide enough.
1705 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1706 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1707 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1708 Check for fixnum out of range.
1709 * ftfont.c (ftfont_list): Don't assume index fits in int.
1710 Check that fixnums are in proper range for system types.
1711 (ftfont_shape_by_flt):
1712 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1713 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1714 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1715 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1716 Check that fixnums are in proper range for system types.
1717 * gnutls.h: Adjust decls to match defn changes elsewhere.
1718 * gtkutil.c (xg_dialog_run):
1719 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1720 (update_frame_tool_bar):
1721 Check that fixnums are in proper range for system types.
1722 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
1723 (lookup_image): Check that fixnums are in range for system types.
1724 * indent.c (last_known_column, last_known_column_point):
1725 (current_column_bol_cache):
1726 (skip_invisible, current_column, check_display_width):
1727 (check_display_width, scan_for_column, current_column_1)
1728 (Findent_to, Fcurrent_indentation, position_indentation)
1729 (indented_beyond_p, Fmove_to_column, compute_motion):
1730 (Fcompute_motion, Fvertical_motion):
1731 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1732 (last_known_column_modified): Use EMACS_INT, not int.
1733 (check_display_width):
1735 Check that fixnums and floats are in proper range for system types.
1736 (compute_motion): Don't assume index or fixnum fits in int.
1737 (compute_motion, Fcompute_motion):
1738 Use int, not EMACS_INT, when it is wide enough.
1739 (vmotion): Omit local var start_hpos that is always 0; that way
1740 we don't need to worry about overflow in expressions involving it.
1741 * indent.h: Adjust decls to match defn changes elsewhere.
1743 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1744 Use int, not EMACS_INT, where int is wide enough.
1745 Remove unused members ovstring_chars_done and tab_offset;
1747 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1748 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1749 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1750 (make_gap, copy_text, insert, insert_and_inherit)
1751 (insert_before_markers, insert_before_markers_and_inherit)
1752 (insert_1, count_combining_before, count_combining_after)
1753 (insert_1_both, insert_from_string)
1754 (insert_from_string_before_markers, insert_from_string_1)
1755 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1756 (adjust_after_replace, adjust_after_insert, replace_range)
1757 (replace_range_2, del_range, del_range_1, del_range_byte)
1758 (del_range_both, del_range_2, modify_region)
1759 (prepare_to_modify_buffer, signal_before_change)
1760 (signal_after_change, Fcombine_after_change_execute):
1761 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1762 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1763 (balance_an_interval, split_interval_right, split_interval_left)
1764 (find_interval, next_interval, update_interval)
1765 (adjust_intervals_for_insertion, delete_node, delete_interval)
1766 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1767 (static_offset_intervals, offset_intervals)
1768 (merge_interval_right, merge_interval_left, make_new_interval)
1769 (graft_intervals_into_buffer, temp_set_point_both)
1770 (temp_set_point, set_point, adjust_for_invis_intang)
1771 (set_point_both, move_if_not_intangible, get_property_and_range)
1772 (get_local_map, copy_intervals, copy_intervals_to_string)
1773 (compare_string_intervals, set_intervals_multibyte_1):
1774 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1775 * intervals.h: Adjust decls to match defn changes elsewhere.
1777 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1778 * keyboard.c (this_command_key_count, this_single_command_key_start)
1779 (before_command_key_count, before_command_echo_length, echo_now)
1780 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1781 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1782 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1783 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1784 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1785 (last_non_minibuf_size, last_point_position, echo_truncate)
1786 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1787 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1788 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1789 (stuff_buffered_input):
1790 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1791 (last_auto_save, command_loop_1, read_char):
1792 Use EMACS_INT, not int, to avoid integer overflow.
1793 (record_char): Avoid overflow in total_keys computation.
1794 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1795 * keyboard.h: Adjust decls to match defn changes elsewhere.
1796 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1797 (Fkey_description, Fdescribe_vector, Flookup_key):
1798 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1799 (click_position): New function, to check that positions are in range.
1800 (Fcurrent_active_maps):
1802 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1803 (Faccessible_keymaps, Fkey_description):
1804 (preferred_sequence_p):
1805 Don't assume fixnum can fit into int.
1806 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1807 Check for integer overflow in size calculations.
1808 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1809 avoid mishandling large integers.
1810 * lisp.h: Adjust decls to match defn changes elsewhere.
1811 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1812 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1813 (struct Lisp_Marker):
1814 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1815 (clip_to_bounds): Now an inline function, moved here from editfns.c.
1816 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1817 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1818 All callers changed.
1819 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1820 Assume the arg has valid form, since it always does.
1821 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1822 unsigned integer system type.
1823 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1824 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1825 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1826 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1827 (duration_to_sec_usec): New decl.
1828 * lread.c (read_from_string_index, read_from_string_index_byte)
1829 (read_from_string_limit, readchar, unreadchar, openp)
1830 (read_internal_start, read1, oblookup):
1831 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1832 (Fload, readevalloop, Feval_buffer, Feval_region):
1833 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1834 (openp): Check for out-of-range argument to 'access'.
1835 (read1): Use int, not EMACS_INT, where int is wide enough.
1836 Don't assume fixnum fits into int.
1837 Fix off-by-one error that can read outside a buffer.
1838 (read_filtered_event): Use duration_to_sec_usec
1839 to do proper overflow checking on durations.
1840 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1841 in size calculation.
1842 (Fexecute_kbd_macro):
1843 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1844 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1845 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1846 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1847 (set_marker_both, set_marker_restricted_both, marker_position)
1848 (marker_byte_position, Fbuffer_has_markers_at):
1849 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1850 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
1851 * menu.c (ensure_menu_items): Rename from grow_menu_items.
1852 It now merely ensures that the menu is large enough, without
1853 necessarily growing it, as this avoids some integer overflow issues.
1854 All callers changed.
1855 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1856 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1857 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1858 Use SAFE_ALLOCA_LISP, not alloca.
1859 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1860 to EMACS_INT. Check that fixnums are in proper range for system types.
1861 * minibuf.c (minibuf_prompt_width, string_to_object)
1862 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1863 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1864 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1865 (get_minibuffer, read_minibuf_unwind):
1866 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1867 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1868 this simplifies overflow checking. All callers changed.
1869 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1871 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1872 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1873 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1874 Check that fixnums are in proper range for system types.
1875 (Fx_create_frame, Fx_show_tip):
1876 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1877 * nsfont.m (ns_findfonts, nsfont_list_family):
1878 Don't assume fixnum fits in long.
1879 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1880 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1881 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1883 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
1884 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1885 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1886 (PRINTDECLARE, PRINTPREPARE):
1887 (strout, print_string):
1888 (print, print_preprocess, print_check_string_charset_prop)
1890 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1892 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1893 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1894 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
1895 (printchar, strout): Use xpalloc to catch size calculation overflow.
1896 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
1897 (print_error_message): Use SAFE_ALLOCA, not alloca.
1898 (print_object): Use int, not EMACS_INT, where int is wide enough.
1899 (print_depth, new_backquote_output, print_number_index):
1900 Use ptrdiff_t, not int, where int might not be wide enough.
1901 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1902 (Fset_process_window_size, Fformat_network_address)
1903 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
1905 Check that fixnums are in proper range for system types.
1906 (Fsignal_process): Simplify by avoiding a goto.
1907 Check for process-ids out of pid_t range rather than relying on
1909 (process_tick, update_tick): Use EMACS_INT, not int.
1910 (Fformat_network_address, read_process_output, send_process)
1911 (Fprocess_send_region, status_notify):
1912 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1913 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1914 (wait_reading_process_output, read_process_output, exec_sentinel):
1915 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1916 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1917 (Faccept_process_output): Use duration_to_sec_usec to do proper
1918 overflow checking on durations.
1919 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1920 Don't assume pid_t fits in int.
1921 * process.h (struct Lisp_Process): Members tick and update_tick
1922 are now of type EMACS_INT, not int.
1923 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1924 configured --with-wide-int.
1925 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1926 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1927 * search.c (looking_at_1, string_match_1):
1928 (fast_string_match, fast_c_string_match_ignore_case)
1929 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1930 (scan_newline, find_before_next_newline, search_command)
1931 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1932 (set_search_regs, wordify):
1935 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1936 (string_match_1, search_buffer, set_search_regs):
1938 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1939 (wordify): Check for overflow in size calculation.
1940 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1941 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1942 Check that fixnums are in proper range for system types.
1943 * sound.c (struct sound_device)
1944 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1945 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1946 (Fplay_sound_internal):
1947 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1948 * syntax.c (struct lisp_parse_state, find_start_modiff)
1949 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1950 (Fparse_partial_sexp):
1951 Don't assume fixnums can fit in int.
1952 (struct lisp_parse_state, find_start_pos, find_start_value)
1953 (find_start_value_byte, find_start_begv)
1954 (update_syntax_table, char_quoted, dec_bytepos)
1955 (find_defun_start, prev_char_comend_first, back_comment):
1956 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1957 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1958 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1959 (Finternal_describe_syntax_value): Check that match_lisp is a
1960 character, not an integer, since the code stuffs it into int.
1961 (scan_words, scan_sexps_forward):
1962 Check that fixnums are in proper range for system types.
1964 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1965 (scan_sexps_forward):
1966 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1967 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1968 * syntax.h: Adjust decls to match defn changes elsewhere.
1969 (struct gl_state_s):
1970 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1971 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1972 MOST_POSITIVE_FIXNUM.
1973 * sysdep.c (wait_for_termination_1, wait_for_termination)
1974 (interruptible_wait_for_termination, mkdir):
1975 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1976 (emacs_read, emacs_write):
1977 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1978 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1979 and double all fit in int.
1980 * term.c (set_tty_color_mode):
1981 Check that fixnums are in proper range for system types.
1982 * termhooks.h (struct input_event):
1983 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1984 * textprop.c (validate_interval_range, interval_of)
1985 (Fadd_text_properties, set_text_properties_1)
1986 (Fremove_text_properties, Fremove_list_of_text_properties)
1987 (Ftext_property_any, Ftext_property_not_all)
1988 (copy_text_properties, text_property_list, extend_property_ranges)
1989 (verify_interval_modification):
1990 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1991 (Fnext_single_char_property_change)
1992 (Fprevious_single_char_property_change):
1993 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1994 (copy_text_properties):
1995 Check for integer overflow in index calculation.
1996 * undo.c (last_boundary_position, record_point, record_insert)
1997 (record_delete, record_marker_adjustment, record_change)
1998 (record_property_change):
1999 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2000 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2001 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2002 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2003 (Fx_hide_tip, Fx_file_dialog):
2004 * w32menu.c (set_frame_menubar):
2005 Use ptrdiff_t, not int, for consistency with rest of code.
2006 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2007 (select_window, Fdelete_other_windows_internal)
2008 (window_scroll_pixel_based, window_scroll_line_based)
2009 (Frecenter, Fset_window_configuration):
2010 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2011 (Fset_window_hscroll, run_window_configuration_change_hook)
2012 (set_window_buffer, temp_output_buffer_show, scroll_command)
2013 (Fscroll_other_window, Frecenter):
2014 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2015 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2016 Don't assume fixnum fits in int.
2017 (Fset_window_scroll_bars):
2018 Check that fixnums are in proper range for system types.
2019 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2020 (string_pos, c_string_pos, number_of_chars, init_iterator)
2021 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2022 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2023 (compute_display_string_end, handle_face_prop)
2024 (face_before_or_after_it_pos, handle_invisible_prop)
2025 (handle_display_prop, handle_display_spec, handle_single_display_spec)
2026 (display_prop_intangible_p, string_buffer_position_lim)
2027 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2028 (get_overlay_strings_1, get_overlay_strings)
2029 (iterate_out_of_display_property, forward_to_next_line_start)
2030 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2031 (get_next_display_element, set_iterator_to_next)
2032 (get_visually_first_element, compute_stop_pos_backwards)
2033 (handle_stop_backwards, next_element_from_buffer)
2034 (move_it_in_display_line_to, move_it_in_display_line)
2035 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2036 (add_to_log, message_dolog, message_log_check_duplicate)
2037 (message2, message2_nolog, message3, message3_nolog
2038 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2039 (current_message_1, truncate_echo_area, truncate_message_1)
2040 (set_message, set_message_1, store_mode_line_noprop)
2041 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2042 (text_outside_line_unchanged_p, check_point_in_composition)
2043 (reconsider_clip_changes)
2044 (redisplay_internal, set_cursor_from_row, try_scrolling)
2045 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2046 (redisplay_window, find_last_unchanged_at_beg_row)
2047 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2048 (trailing_whitespace_p, find_row_edges, display_line)
2049 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2050 (display_mode_element, store_mode_line_string)
2051 (pint2str, pint2hrstr, decode_mode_spec)
2052 (display_count_lines, display_string, draw_glyphs)
2053 (x_produce_glyphs, x_insert_glyphs)
2054 (rows_from_pos_range, mouse_face_from_buffer_pos)
2055 (fast_find_string_pos, mouse_face_from_string_pos)
2056 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2057 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2058 (safe_call, init_from_display_pos, handle_fontified_prop)
2059 (handle_single_display_spec, load_overlay_strings)
2060 (with_echo_area_buffer, setup_echo_area_for_printing)
2061 (display_echo_area, echo_area_display)
2062 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2063 (update_tool_bar, hscroll_window_tree, redisplay_internal)
2064 (redisplay_window, dump_glyph_row, display_mode_line)
2065 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
2066 (handle_display_spec, display_prop_string_p):
2067 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2068 (handle_single_display_spec, build_desired_tool_bar_string)
2069 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2070 (get_specified_cursor_type):
2071 Check that fixnums are in proper range for system types.
2072 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2073 (Flookup_image_map):
2074 Don't assume fixnums fit in int.
2075 (compare_overlay_entries):
2076 Avoid mishandling comparisons due to subtraction overflow.
2077 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2078 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2079 (handle_tool_bar_click):
2080 Use int, not unsigned, since we prefer signed and the signedness
2081 doesn't matter here.
2082 (get_next_display_element, next_element_from_display_vector):
2083 Use int, not EMACS_INT, when int is wide enough.
2084 (start_hourglass): Use duration_to_sec_usec to do proper
2085 overflow checking on durations.
2086 * xfaces.c (Fbitmap_spec_p):
2087 Check that fixnums are in proper range for system types.
2088 (compare_fonts_by_sort_order):
2089 Avoid mishandling comparisons due to subtraction overflow.
2090 (Fx_family_fonts, realize_basic_faces):
2091 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2093 Don't assume fixnum fits in int.
2094 Use SAFE_ALLOCA_LISP, not alloca.
2095 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2096 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2097 (face_at_buffer_position, face_for_overlay_string)
2098 (face_at_string_position):
2099 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2100 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2101 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2103 Check that fixnums are in proper range for system types.
2104 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2105 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2106 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2107 (Fx_change_window_property): Don't assume fixnums fit in int.
2108 * xfont.c (xfont_chars_supported):
2109 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2110 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2111 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2112 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2113 * xml.c (parse_region):
2114 * xrdb.c (magic_file_p):
2115 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2116 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2117 (x_get_local_selection, x_reply_selection_request)
2118 (x_handle_selection_request, wait_for_property_change):
2119 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2120 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2121 short is wide enough.
2122 (x_send_client_event): Don't assume fixnum fits in int.
2123 * xterm.c (x_x_to_emacs_modifiers):
2124 Don't assume EMACS_INT overflows nicely into int.
2125 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2127 (handle_one_xevent): NATNUMP can eval its arg twice.
2128 (x_connection_closed):
2129 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2130 * xterm.h: Adjust decls to match defn changes elsewhere.
2131 (struct scroll_bar): Use struct vectorlike_header
2132 rather than rolling our own approximation.
2133 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2135 2012-05-25 Glenn Morris <rgm@gnu.org>
2137 * lisp.mk (lisp): Update for more files being compiled now.
2139 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2141 * lread.c: Remove `read_pure' which makes no difference.
2142 (read_pure): Remove var.
2143 (unreadpure): Remove function.
2144 (readevalloop): Don't call read_list with -1 flag.
2145 (read1, read_vector): Don't test read_pure any more.
2146 (read_list): Simplify.
2148 * fileio.c, character.h: Minor style tweaks.
2150 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2152 * window.h (clip_changed): Remove useless declaration.
2154 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
2156 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2157 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2159 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2162 This directory predates autoconf and is no longer needed nowadays.
2163 Move its few remaining bits of functionality to where they're needed.
2164 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2165 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2166 * m/template.h: Remove.
2167 * Makefile.in (M_FILE): Remove. All uses removed.
2168 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2169 * lisp.h (USE_LSB_TAG):
2170 * mem-limits.h (EXCEEDS_LISP_PTR):
2171 Use VAL_MAX, not VALBITS, in #if.
2172 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2173 (EMACS_UINT): Define unconditionally now.
2174 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2175 (BITS_PER_EMACS_INT): New constants, replacing
2176 what used to be in config.h, but not useful in #if.
2177 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2178 define them any more.
2179 (VAL_MAX): New macro.
2181 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2182 BITS_PER_EMACS_INT, in #if.
2183 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2184 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2185 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2186 * s/ms-w32.h (DATA_START):
2187 Move here from removed file m/intel386.h.
2188 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2189 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2191 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2193 Assume C89 or later.
2194 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2195 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2197 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2198 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2199 * textprop.c, tparam.c (NULL): Remove.
2200 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2201 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2202 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2203 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2204 * xterm.c (input_signal_count): Assume volatile works.
2206 2012-05-21 Ken Brown <kbrown@cornell.edu>
2208 * xgselect.c (xg_select): Fix first argument in call to 'select'
2211 2012-05-20 Ken Brown <kbrown@cornell.edu>
2213 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
2214 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
2216 2012-05-19 Ken Brown <kbrown@cornell.edu>
2218 * xfns.c (x_in_use): Remove `static' qualifier.
2219 * xterm.h (x_in_use): Declare.
2220 * xgselect.c: Include xterm.h.
2221 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2222 and `display_arg' (bug#9754).
2224 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2226 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2228 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2229 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2231 2012-05-18 Eli Zaretskii <eliz@gnu.org>
2233 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2235 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2236 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2238 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2239 reference to image_cache->refcount.
2240 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2242 2012-05-17 Juri Linkov <juri@jurta.org>
2244 * search.c (Fword_search_regexp, Fword_search_backward)
2245 (Fword_search_forward, Fword_search_backward_lax)
2246 (Fword_search_forward_lax): Move functions to isearch.el
2247 (bug#10145, bug#11381).
2249 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2251 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2253 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2255 * lread.c (init_obarray): Declare Qt and Qnil as special.
2257 2012-05-14 Glenn Morris <rgm@gnu.org>
2259 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
2260 Put "libexec" before "bin", for the sake of init_callproc_1.
2262 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2264 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2266 * unexaix.c: Port to more-recent AIX compilers.
2267 (report_error, report_error_1, make_hdr, copy_sym)
2268 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2269 Make arguments const char *, not char *, to avoid violations of C
2270 standard and to fix some AIX warnings reported by Gilles Pion.
2272 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2274 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2275 already have overlays loaded.
2276 (handle_single_display_spec): Before returning without displaying
2277 fringe bitmap, synchronize the bidi iterator with the main display
2278 iterator, by calling iterate_out_of_display_property.
2279 (iterate_out_of_display_property): Detect buffer iteration by
2280 testing that it->string is a Lisp string.
2281 (get_next_display_element): When the current object is exhausted,
2282 and there's something on it->stack, call set_iterator_to_next to
2283 proceed with what's on the stack, instead of returning zero.
2284 (set_iterator_to_next): If called at the end of a Lisp string,
2285 proceed to consider_string_end without incrementing string
2286 position. Don't increment display vector index past the end of
2287 the display vector. (Bug#11417)
2288 (pos_visible_p): Don't report a position visible when move_it_to
2289 stopped at the last line of window, which happens to be scanned
2290 backwards by the bidi iteration. (Bug#11464)
2292 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2294 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2295 and right-margin display specs even if the spec is invalid or we
2296 are on a TTY, and thus unable to display on the fringes.
2297 That's because the text with the property will not be displayed anyway,
2298 so we need to signal to the caller that this is a "replacing"
2299 display spec. This fixes display when the spec is invalid or we
2302 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2304 * unexaix.c (make_hdr): Fix typo in prototype.
2305 This bug broke the build on AIX. Problem reported by Gilles Pion.
2307 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
2309 * keyboard.c (kbd_buffer_get_event): Read special events also in
2310 batch mode. (Bug#11415)
2312 2012-05-12 Glenn Morris <rgm@gnu.org>
2314 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2316 2012-05-12 Eli Zaretskii <eliz@gnu.org>
2318 * lisp.mk (lisp): Add newcomment.elc.
2320 2012-05-12 Glenn Morris <rgm@gnu.org>
2322 * Makefile.in (MKDIR_P): New, set by configure.
2323 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2325 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2327 Remove unused function hourglass_started.
2328 * dispextern.h (hourglass_started):
2329 * w32fns.c (hourglass_started):
2330 * xdisp.c (hourglass_started): Remove.
2332 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
2334 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2335 Update dependencies.
2337 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2339 * xgselect.c (xg_select): Put maxfds+1 into a var.
2340 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2342 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2344 2012-05-10 Dave Abrahams <dave@boostpro.com>
2346 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2347 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2349 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
2351 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2352 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2353 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2354 Initialize xd_registered_buses.
2356 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2358 Untag more efficiently if USE_LSB_TAG.
2359 This is based on a proposal by YAMAMOTO Mitsuharu in
2360 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2361 For an admittedly artificial (nth 8000 longlist) benchmark on
2362 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2363 Emacs's overall text size by 1%.
2364 * lisp.h (XUNTAG): New macro.
2365 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2366 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2367 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2368 * eval.c (Fautoload):
2369 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2370 * frame.h (XFRAME): Use XUNTAG.
2372 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2373 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2374 Remove unportable assumptions about print widths of types like
2376 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2377 intptr_t when converting between pointer and integer, to avoid GCC
2378 warnings about wrong width.
2380 2012-05-09 Eli Zaretskii <eliz@gnu.org>
2382 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2383 stack for each reader_thread, instead of defaulting to 8MB
2384 determined by the linker. This avoids failures in creating
2385 subprocesses on Windows 7, see the discussion in this thread:
2386 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2388 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2390 Fix up display of the *Minibuf-0* buffer in the mini window.
2391 * keyboard.c (read_char): Don't clear the echo area if there's no
2393 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2394 contents of *Minibuf-0*) if there's no message displayed in its stead.
2396 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
2398 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2401 2012-05-06 Chong Yidong <cyd@gnu.org>
2403 * lisp.mk (lisp): Update.
2405 2012-05-05 Jim Meyering <meyering@redhat.com>
2407 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2409 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2411 * data.c (PUT_ERROR): New macro.
2412 (syms_of_data): Use it. Add new error type `user-error'.
2413 * undo.c (user_error): New function.
2414 (Fprimitive_undo): Use it.
2415 * print.c (print_error_message): Adjust print style for `user-error'.
2416 * keyboard.c (user_error): New function.
2417 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2419 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2421 Do not limit current-time-string to years 1000..9999.
2422 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2423 (Fcurrent_time_string): Support any year that is supported by the
2424 underlying localtime representation. Don't use asctime, as it
2425 has undefined behavior for years outside the range -999..9999.
2427 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2429 Fix race conditions involving setenv, gmtime, localtime, asctime.
2430 Without this fix, interrupts could mess up code that uses these
2431 nonreentrant functions, since setting TZ invalidates existing
2432 tm_zone or tzname values, and since most of these functions return
2433 pointers to static storage.
2434 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2435 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2436 Grow the critical sections to include not just invoking
2437 localtime/gmtime, but also accessing these functions' results
2438 including their tm_zone values if any, and any related TZ setting.
2439 (format_time_string): Last arg is now struct tm *, not struct tm **,
2440 so that the struct tm is saved in the critical section.
2441 All callers changed. Simplify allocation of initial buffer, partly
2442 motivated by the fact that memory allocation needs to be outside
2443 the critical section.
2445 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2447 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2448 with RESET_INTERVAL.
2450 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2451 Remove duplicated buffer name initialization.
2453 2012-05-02 Jim Meyering <jim@meyering.net>
2455 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2457 * xfns.c (x_window): Use xstrdup (Bug#11375).
2459 2012-05-02 Eli Zaretskii <eliz@gnu.org>
2461 * xdisp.c (pos_visible_p): If already at a newline from the
2462 display string before the 'while' loop, don't walk back the glyphs
2463 from it3.glyph_row. Solves assertion violation when the display
2464 string begins with a newline (egg.el). (Bug#11367)
2466 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2468 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2471 2012-05-01 Glenn Morris <rgm@gnu.org>
2473 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2474 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2475 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2476 All were removed before 23.1.
2478 * dispnew.c: Remove HAVE_LIBNCURSES test;
2479 it is always true on relevant platforms.
2481 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2482 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2484 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2486 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2488 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2489 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2492 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2494 Do not avoid creating empty evaporating overlays (Bug#9642).
2495 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2496 That is, do not delete an evaporating overlay if it becomes
2497 empty after its bounds are adjusted to fit within its buffer.
2498 This fix caused other problems, and I'm reverting it until we get
2499 to the bottom of them.
2501 2012-04-27 Chong Yidong <cyd@gnu.org>
2503 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2505 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2507 * xdisp.c (pos_visible_p): If the window start position is beyond
2508 ZV, start the display from buffer beginning. Prevents assertion
2509 violation in init_iterator when the minibuffer window is scrolled
2512 * window.c (window_scroll_pixel_based): Likewise.
2514 2012-04-27 Chong Yidong <cyd@gnu.org>
2516 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2518 2012-04-27 Glenn Morris <rgm@gnu.org>
2520 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2521 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2523 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2525 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2526 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
2528 2012-04-26 Eli Zaretskii <eliz@gnu.org>
2530 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2531 display element, check also the underlying string or buffer
2532 character. (Bug#11341)
2534 * w32menu.c: Include w32heap.h.
2535 (add_menu_item): If the call to AppendMenuW (via
2536 unicode_append_menu) fails, disable Unicode menus only if we are
2537 running on Windows 9X/Me.
2539 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2541 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2542 (xgetint): Add missing shift for LSB tags.
2544 2012-04-24 Martin Rudalics <rudalics@gmx.at>
2546 * keyboard.c (read_char): Don't wipe echo area for select window
2547 events: These might get delayed via `mouse-autoselect-window'
2550 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
2552 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2553 manipulation of :loaded-from data.
2555 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
2557 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2558 now a cons (bug#11311).
2560 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2562 Do not create empty overlays with the evaporate property (Bug#9642).
2563 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2564 if it becomes empty after its bounds are adjusted to fit within
2565 its buffer. Without this fix, in a nonempty buffer (let ((o
2566 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2567 yields an empty overlay that has the evaporate property, which is
2568 not supposed to happen.
2570 Fix minor GTK3 problems found by static checking.
2571 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2572 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2573 (struct _EmacsFixedClass, emacs_fixed_get_type):
2574 Move decls here from emacsgtkfixed.h, since they needn't be public.
2575 (emacs_fixed_get_type): Now static.
2576 (emacs_fixed_class_init): Omit unused local.
2577 (emacs_fixed_child_type): Remove; unused.
2578 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2579 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2580 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2581 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2582 (EMACS_FIXED_GET_CLASS): Remove; unused.
2583 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2585 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2586 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2588 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2590 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
2591 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
2592 (__malloc_size_t, __malloc_ptrdiff_t):
2593 Remove. All uses removed, replaced by the definiens if needed,
2594 since we can assume C89 or better now.
2595 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2596 (protect_malloc_state, align, get_contiguous_space)
2597 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2598 (malloc_atfork_handler_child, malloc_enable_thread)
2599 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2600 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2601 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2602 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2603 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2604 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2605 Define using prototypes, not old style.
2606 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2607 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2608 (align): Don't assume that signed integer overflow wraps around.
2609 Omit unused local var.
2610 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2611 (_free_internal_nolock, memalign, mallochook, reallochook):
2612 Omit no-longer-needed casts.
2613 (valloc): Use getpagesize, not __getpagesize.
2614 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2615 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2617 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2619 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
2621 Move functions from C to Lisp. Make non-blocking method calls
2622 the default. Implement further D-Bus standard interfaces.
2624 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2625 (QCdbus_request_name_allow_replacement)
2626 (QCdbus_request_name_replace_existing)
2627 (QCdbus_request_name_do_not_queue)
2628 (QCdbus_request_name_reply_primary_owner)
2629 (QCdbus_request_name_reply_in_queue)
2630 (QCdbus_request_name_reply_exists)
2631 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2632 (QCdbus_registered_serial, QCdbus_registered_method)
2633 (QCdbus_registered_signal): New Lisp objects.
2634 (XD_DEBUG_MESSAGE): Use sizeof.
2635 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2636 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2637 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2638 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2639 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2640 (xd_signature, xd_append_arg): Allow float for integer types.
2641 (xd_get_connection_references): New function.
2642 (xd_get_connection_address): Rename from xd_initialize.
2643 Return cached address.
2644 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2645 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2647 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
2648 Return number of refcounts.
2649 (Fdbus_get_unique_name): Make stronger parameter check.
2650 (Fdbus_message_internal): New defun.
2651 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2652 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2653 (Fdbus_send_signal, Fdbus_register_service)
2654 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2655 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2656 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2657 (Vdbus_compiled_version, Vdbus_runtime_version)
2658 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2659 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2660 (Vdbus_message_type_signal): New defvars.
2661 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2664 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2666 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2667 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2668 Do not assume ptrdiff_t is the same width as 'int'.
2670 * alloc.c: Handle unusual debugging option combinations.
2671 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2672 since the two debugging options are incompatible.
2673 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2675 (mem_init, mem_insert, mem_insert_fixup):
2676 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2677 (NEED_MEM_INSERT): Remove; no longer needed.
2679 2012-04-22 Leo Liu <sdl.web@gmail.com>
2681 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2683 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2685 * sysdep.c [__FreeBSD__]: Minor cleanups.
2686 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2687 Use Emacs indenting style more consistently. Avoid some casts.
2688 Use 'double' consistently rather than mixing 'float' and 'double'.
2690 2012-04-21 Eduard Wiebe <usenet@pusto.de>
2692 * sysdep.c (list_system_processes, system_process_attributes):
2693 Add implementation for FreeBSD (Bug#5243).
2695 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2697 * lisp.mk (lisp): Update.
2699 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2701 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2702 It is never used otherwise.
2704 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2706 * print.c (print_preprocess): Only check print_depth if print-circle
2708 (print_object): Check for cycles even when print-circle is nil and
2709 print-gensym is t, but only check print_depth if print-circle is nil.
2711 2012-04-20 Chong Yidong <cyd@gnu.org>
2713 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2714 set the status to "failed" and ensure that sentinel is run.
2716 2012-04-20 Glenn Morris <rgm@gnu.org>
2718 * process.c (Fset_process_inherit_coding_system_flag)
2719 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
2720 (Fmake_network_process, Fmake_serial_process): Doc fix.
2722 2012-04-20 Eli Zaretskii <eliz@gnu.org>
2724 * xdisp.c (string_buffer_position_lim): Limit starting position to
2726 (set_cursor_from_row): If called for a mode-line or header-line
2727 row, return zero immediately.
2728 (try_cursor_movement): If inside continuation line, don't back up
2729 farther than the first row after the header line, if any.
2730 Don't consider the header-line row as "partially visible", even if
2731 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2733 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2735 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2738 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
2739 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
2741 configure: new option --enable-gcc-warnings (Bug#11207)
2742 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2743 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2744 (ALL_CFLAGS): Use new macros rather than old.
2745 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2746 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2747 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2748 -Wunused-result, -Wunused-variable. This should go away once
2749 the Emacs and Gnulib regex code is merged.
2750 (xmalloc, xrealloc): Now static.
2752 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2754 * dired.c (Fsystem_groups): Remove unused local.
2756 2012-04-17 Glenn Morris <rgm@gnu.org>
2758 * dired.c (Fsystem_users): Doc fix.
2760 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2762 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2763 (syms_of_dired): Add them.
2765 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2767 Fix minor alloc.c problems found by static checking.
2768 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2769 New extern decls, to avoid calling undeclared functions.
2770 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2771 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2772 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2773 (NEED_MEM_INSERT): New macro.
2774 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
2775 Remove one incorrect comment and fix another.
2777 Fix minor ralloc.c problems found by static checking.
2778 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2779 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2780 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2781 (r_alloc_sbrk): Now static.
2783 Improve ralloc.c interface checking.
2784 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2785 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2786 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2787 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2788 [REL_ALLOC]: ... to here, to check interface.
2789 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2790 Remove decls. This fixes an "It stinks!".
2792 * alloc.c (which_symbols): Fix alignment issue / type clash.
2794 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2796 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2797 (struct Lisp_Misc_Any): Likewise.
2798 (struct Lisp_Free): Likewise.
2799 * alloc.c (union aligned_Lisp_Symbol): Define.
2800 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2801 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2802 (union aligned_Lisp_Misc): Define.
2803 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2804 aligned_Lisp_Misc instead of union Lisp_Misc.
2805 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
2807 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2809 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2810 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2811 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2812 * s/netbsd.h, s/sol2-6.h:
2813 Remove definition of GC_MARK_STACK, since the default now works.
2814 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2815 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2816 no longer the default.
2817 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2819 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2821 * lread.c (lisp_file_lexically_bound_p):
2822 Fix hang at ";-*-\n" (bug#11238).
2824 2012-04-14 Eli Zaretskii <eliz@gnu.org>
2826 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2827 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2829 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2831 * nsterm.m (constrainFrameRect): Always constrain when there is only
2832 one screen (Bug#10962).
2834 2012-04-13 Ken Brown <kbrown@cornell.edu>
2836 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2838 2012-04-13 Reuben Thomas <rrt@sc3d.org>
2840 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2842 2012-04-11 Daniel Colascione <dancol@dancol.org>
2844 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2845 against is gone. It's better to use vfork now so that when Cygwin
2846 gains a new, working vfork, we use it automatically (bug#10398).
2848 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2850 * window.c (save_window_save): Obey window-point-insertion-type.
2852 2012-04-11 Glenn Morris <rgm@gnu.org>
2854 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2856 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2858 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2860 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
2862 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2863 (force_quit_count): New var.
2864 (handle_interrupt): Use it.
2866 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
2868 * w32.c (w32_delayed_load): Record the full path of the library
2869 being loaded (bug#10424).
2871 2012-04-09 Glenn Morris <rgm@gnu.org>
2873 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2874 not just in the obarray, before snarfing them. (Bug#11036)
2876 * Makefile.in ($(leimdir)/leim-list.el):
2877 Pass EMACS rather than BUILT_EMACS.
2879 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2881 * process.c (make_process):
2882 * process.h: Add integer `gnutls_handshakes_tried' member to
2885 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2886 Add convenience `GNUTLS_LOG2i' macro.
2888 * gnutls.c (gnutls_log_function2i): Convenience log function.
2889 (emacs_gnutls_read): Use new log functions,
2890 `gnutls_handshakes_tried' process member, and
2891 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2892 attempts per process (connection).
2894 2012-04-09 Chong Yidong <cyd@gnu.org>
2896 * eval.c (Fuser_variable_p, user_variable_p_eh)
2897 (lisp_indirect_variable): Functions deleted.
2898 (Fdefvar): Caller changed.
2900 * callint.c (Finteractive, Fcall_interactively):
2901 * minibuf.c (Fread_variable): Callers changed.
2903 2012-04-09 Eli Zaretskii <eliz@gnu.org>
2905 * xdisp.c (set_cursor_from_row): If the display string appears in
2906 the buffer at position that is closer to point than the position
2907 after the display string, display the cursor on the first glyph of
2908 the display string. Fixes cursor display when a 'display' text
2909 property immediately follows invisible text. (Bug#11094)
2911 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2913 composite.c: use 'double' consistently
2914 * composite.c (get_composition_id): Use 'double' consistently
2915 instead of converting 'float' to 'double' and vice versa; this is
2916 easier to understand and avoids a GCC warning.
2918 2012-04-09 Glenn Morris <rgm@gnu.org>
2920 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2921 preparation for dumping it with emacs. (Bug#4789)
2922 (leimdir): New variable.
2923 ($(leimdir)/leim-list.el): New rule.
2924 (emacs$(EXEEXT)): Depend on leim-list.el.
2926 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2927 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2928 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2930 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2932 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2935 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
2937 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2938 Remove unused local variable.
2940 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2942 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2943 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2944 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2945 objects, as mark_maybe_pointer will catch them otherwise.
2946 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2947 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2949 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2951 Fix typo that broke non-Windows builds.
2952 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2954 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2956 Support building on MS-Windows with libxml2.
2958 * makefile.w32-in (OBJ2): Add xml.$(O).
2959 (GLOBAL_SOURCES): Add xml.c.
2960 ($(BLD)/xml.$(O)): New dependency list.
2962 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2963 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2964 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2965 [!WINDOWSNT]: New macros.
2966 (init_libxml2_functions, libxml2_loaded_p): New functions.
2967 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2968 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2969 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2970 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2972 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2973 Call init_libxml2_functions before calling libxml2 functions.
2974 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2976 * emacs.c: Don't include libxml/parser.h.
2977 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2978 xmlCleanupParser directly.
2980 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2982 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2984 * indent.c (Fvertical_motion): If there is a display string at
2985 point, use it.vpos to compute how many lines to backtrack after
2986 move_it_to point. (Bug#11133)
2988 2012-04-06 Eli Zaretskii <eliz@gnu.org>
2990 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2991 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2992 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2993 macros related to unification of CJK characters. For the details,
2994 see the discussion following the message here:
2995 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2997 2012-04-04 Chong Yidong <cyd@gnu.org>
2999 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3001 2012-04-01 Eli Zaretskii <eliz@gnu.org>
3003 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3004 instead of alloca. (Bug#11138)
3006 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3008 * w32menu.c (is_simple_dialog): Properly check lisp types.
3011 2012-03-31 Eli Zaretskii <eliz@gnu.org>
3013 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3014 position we get to after a call to move_it_to fails the
3015 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3016 only if we wind up in a string from display property. (Bug#11063)
3018 * window.c (Fdelete_other_windows_internal): Invalidate the row
3019 and column information about mouse highlight, so that redisplay
3020 restores it after reallocating the glyph matrices. (Bug#7464)
3022 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3023 string comes from a `display' text property, use the buffer
3024 position of that property as if we actually saw that position in
3026 (move_it_by_lines): Remove the assertion that
3027 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3028 violated when there's a before-string at the beginning of a line.
3031 2012-03-30 Eli Zaretskii <eliz@gnu.org>
3033 * xdisp.c (append_space_for_newline): If the default face was
3034 remapped, use the remapped face for the appended newline.
3035 (extend_face_to_end_of_line): Use the remapped default face for
3036 extending the face to the end of the line.
3037 (display_line): Call extend_face_to_end_of_line when the default
3038 face was remapped. (Bug#11068)
3040 2012-03-29 Eli Zaretskii <eliz@gnu.org>
3042 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3044 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3046 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3048 2012-03-27 Glenn Morris <rgm@gnu.org>
3050 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3053 2012-03-26 Kenichi Handa <handa@m17n.org>
3055 * dispextern.h (struct glyph): Fix previous change. Change the
3056 bit length of glyphless.ch to 25 (Bug#11082).
3058 2012-03-26 Chong Yidong <cyd@gnu.org>
3060 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3061 (command_loop_1): Use it; inhibit selection update for
3062 handle-select-window too (Bug#8996).
3064 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3066 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
3068 2012-03-25 Kenichi Handa <handa@m17n.org>
3070 * dispextern.h (struct glyph): Change the bit length of
3071 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3073 2012-03-24 Eli Zaretskii <eliz@gnu.org>
3075 * s/ms-w32.h (tzname): Include time.h before redirecting to
3076 _tzname. Fixes the MSVC build. (Bug#9960)
3078 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3080 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3083 * xterm.c (XTread_socket): Only modify handling_signal if
3084 !SYNC_INPUT. (Bug#11080)
3086 2012-03-23 Eli Zaretskii <eliz@gnu.org>
3088 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3089 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3090 when fetching a multibyte character consumes more bytes than
3091 CHAR_BYTES returns, due to unification of CJK characters in
3092 string_char. (Bug#11073)
3094 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3096 * process.c (wait_reading_process_output): Handle pty disconnect
3097 by refraining from sending oneself a SIGCHLD (bug#10933).
3099 2012-03-22 Chong Yidong <cyd@gnu.org>
3101 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3103 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
3104 Mark string as coming from a prefix property.
3105 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3106 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3108 2012-03-21 Chong Yidong <cyd@gnu.org>
3110 * xfaces.c (Vface_remapping_alist): Doc fix.
3112 2012-03-20 Eli Zaretskii <eliz@gnu.org>
3114 * w32proc.c (Fw32_set_console_codepage)
3115 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3118 2012-03-20 Chong Yidong <cyd@gnu.org>
3120 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3121 to reflect default non-nil value of redisplay-dont-pause.
3123 2012-03-19 Kenichi Handa <handa@m17n.org>
3125 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3126 it fit in a valid range (Bug#11003).
3128 2012-03-18 Eli Zaretskii <eliz@gnu.org>
3130 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3131 that is not from display property, accept the row as a "cursor
3132 row" if one of the string's character has a non-nil `cursor'
3133 property. Fixes cursor positioning when there are newlines in
3134 overlay strings, e.g. in icomplete.el. (Bug#11035)
3136 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3138 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3140 2012-03-12 Chong Yidong <cyd@gnu.org>
3142 * eval.c (inhibit_lisp_code): Rename from
3143 inhibit_window_configuration_change_hook; move from window.c.
3145 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3146 * window.c (run_window_configuration_change_hook)
3147 (syms_of_window): Callers changed.
3149 2012-03-11 Chong Yidong <cyd@gnu.org>
3151 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3153 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3155 2012-03-10 Chong Yidong <cyd@gnu.org>
3157 * frame.c (other_visible_frames): Don't assume the selected frame
3158 is visible (Bug#10955).
3160 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3162 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3164 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3166 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3167 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3170 2012-03-03 Glenn Morris <rgm@gnu.org>
3172 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
3174 2012-03-02 Eli Zaretskii <eliz@gnu.org>
3176 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3177 position past the first glyph_row that ends at ZV. (Bug#10902)
3178 (redisplay_window, next_element_from_string): Fix typos in
3180 (redisplay_window): Pass to move_it_vertically the margin in
3181 pixels, not in screen lines.
3183 2012-03-02 Glenn Morris <rgm@gnu.org>
3185 * buffer.c (buffer-list-update-hook): Doc fix.
3187 2012-02-29 Eli Zaretskii <eliz@gnu.org>
3189 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3190 push_it before setting up the iterator for the first overlay
3191 string, even if we have an empty string loaded.
3192 (next_overlay_string): If there's an empty string on the iterator
3193 stack, pop the stack. (Bug#10903)
3195 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3197 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3198 Suggested by Stefan Monnier in
3199 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3200 * alloc.c (widen_to_Lisp_Object): New static function.
3201 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3202 and widening them to Lisp_Objects. This would work even if
3203 USE_LSB_TAG is defined and wide integers are used, which might
3204 happen in a future version of Emacs.
3206 2012-02-25 Chong Yidong <cyd@gnu.org>
3208 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3211 * xselect.c (Fx_selection_exists_p): Doc fix.
3212 (x_clipboard_manager_save_all): Print an informative message
3213 before saving to clipboard manager.
3215 2012-02-24 Chong Yidong <cyd@gnu.org>
3217 * keyboard.c (process_special_events): Handle all X selection
3218 requests in kbd_buffer, not just the next one (Bug#8869).
3220 2012-02-23 Chong Yidong <cyd@gnu.org>
3222 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3223 call when setting menu-bar-lines and tool-bar-lines parameters.
3224 (unwind_create_frame_1): New helper function.
3226 * window.c (inhibit_window_configuration_change_hook): New var.
3227 (run_window_configuration_change_hook): Obey it.
3228 (syms_of_window): Initialize it.
3230 2012-02-22 Chong Yidong <cyd@gnu.org>
3232 * xterm.c (x_draw_image_relief): Add missing type check for
3233 Vtool_bar_button_margin (Bug#10743).
3235 2012-02-21 Chong Yidong <cyd@gnu.org>
3237 * fileio.c (Vfile_name_handler_alist): Doc fix.
3239 * buffer.c (Fget_file_buffer): Protect against invalid file
3240 handler return value.
3242 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3244 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3245 when computing $valmask.
3247 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3248 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3249 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3250 It's useless in that case, and it can cause problems on hosts
3251 that allocate halves of EMACS_INT values separately.
3252 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3253 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3254 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3255 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3256 it avoids undefined behavior on hosts where shifting right by more
3257 than the word width has undefined behavior.
3259 2012-02-19 Chong Yidong <cyd@gnu.org>
3261 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3262 (Funhandled_file_name_directory, Ffile_name_as_directory)
3263 (Fdirectory_file_name, Fexpand_file_name)
3264 (Fsubstitute_in_file_name): Protect against invalid file handler
3265 return values (Bug#10845).
3267 2012-02-18 Eli Zaretskii <eliz@gnu.org>
3269 * .gdbinit (pitx): Fix incorrect references to fields of the
3272 2012-02-17 Chong Yidong <cyd@gnu.org>
3274 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3276 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3278 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3279 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3281 2012-02-15 Chong Yidong <cyd@gnu.org>
3283 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3284 marked as special. Also, starting docstrings with * is obsolete.
3286 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3288 * gnutls.c (emacs_gnutls_write): Fix last change.
3290 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3292 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3295 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3297 * keymap.c (Fsingle_key_description): Handle char ranges.
3299 2012-02-12 Chong Yidong <cyd@gnu.org>
3301 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3302 as that creates a dangerous corner case.
3304 * window.c (Fdelete_window_internal): Invalidate the mouse
3305 highlight (Bug#9904).
3307 2012-02-12 Glenn Morris <rgm@gnu.org>
3309 * xselect.c (Fx_own_selection_internal)
3310 (Fx_get_selection_internal, Fx_disown_selection_internal)
3311 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3312 * nsselect.m (Fx_own_selection_internal)
3313 (Fx_disown_selection_internal, Fx_selection_exists_p)
3314 (Fx_selection_owner_p, Fx_get_selection_internal):
3315 Sync docs and argument specs with the xselect.c versions.
3317 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3319 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3321 2012-02-11 Eli Zaretskii <eliz@gnu.org>
3323 * w32select.c (Fx_selection_exists_p): Sync doc string and
3324 argument list with xselect.c. (Bug#10783)
3326 * w16select.c (Fx_selection_exists_p): Sync doc string and
3327 argument list with xselect.c. (Bug#10783)
3329 2012-02-10 Glenn Morris <rgm@gnu.org>
3331 * fns.c (Fsecure_hash): Doc fix.
3333 2012-02-09 Kenichi Handa <handa@m17n.org>
3335 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3337 2012-02-07 Chong Yidong <cyd@gnu.org>
3339 * buffer.c (Fbuffer_local_variables)
3340 (buffer_lisp_local_variables): Handle unbound vars correctly;
3341 don't let Qunbound leak into Lisp.
3343 2012-02-07 Glenn Morris <rgm@gnu.org>
3345 * image.c (Fimagemagick_types): Doc fix.
3347 * image.c (imagemagick-render-type): Change it from a lisp object
3348 to an integer. Move the doc here from the lisp manual.
3349 Treat all values not equal to 0 the same.
3351 2012-02-06 Chong Yidong <cyd@gnu.org>
3353 * doc.c (store_function_docstring): Avoid applying docstring of
3354 alias to base function (Bug#2603).
3356 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3358 * .gdbinit (pp1, pv1): Remove redundant defines.
3361 2012-02-04 Chong Yidong <cyd@gnu.org>
3363 * nsterm.m: Declare a global (Bug#10694).
3365 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3367 * w32.c (get_emacs_configuration_options):
3368 Include --enable-checking, if specified, in the return value.
3370 2012-02-04 Martin Rudalics <rudalics@gmx.at>
3372 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3373 after rounding frame sizes. (Bug#9723)
3375 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3377 * keyboard.c (adjust_point_for_property): Don't position point
3378 before BEGV. (Bug#10696)
3380 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3382 Handle overflow when computing char display width (Bug#9496).
3383 * character.c (char_width): Return EMACS_INT, not int.
3384 (char_width, c_string_width): Check for overflow when
3385 computing the width; this is possible now that individual
3386 characters can have unbounded width. Problem introduced
3387 by merge from Emacs 23 on 2012-01-19.
3389 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
3391 * dbusbind.c (Fdbus_register_method): Mention the return value
3392 :ignore in the docstring.
3394 2012-02-02 Glenn Morris <rgm@gnu.org>
3396 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3398 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3399 Unconditionally set to t. (Bug#10673)
3400 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3401 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3402 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3404 2012-02-02 Kenichi Handa <handa@m17n.org>
3406 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3407 0, do not call append_composite_glyph.
3409 2012-02-02 Kenichi Handa <handa@m17n.org>
3411 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3413 (x_produce_glyphs): If the component of a composition is a null
3414 string, set it->pixel_width to 1 to avoid zero-width glyph.
3416 2012-02-01 Eli Zaretskii <eliz@gnu.org>
3418 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3419 first 2 arguments are identical. This makes inserting large
3420 output from a subprocess an order of magnitude faster on
3421 MS-Windows, where all sbrk'ed memory is always contiguous.
3423 2012-01-31 Glenn Morris <rgm@gnu.org>
3425 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3426 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3427 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3429 2012-01-29 Glenn Morris <rgm@gnu.org>
3431 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3433 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3435 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3437 2012-01-28 Chong Yidong <cyd@gnu.org>
3439 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3441 2012-01-26 Chong Yidong <cyd@gnu.org>
3443 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3445 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3446 repeat counts (Bug#10507).
3448 2012-01-26 Glenn Morris <rgm@gnu.org>
3450 * lread.c (syms_of_lread): Doc fix.
3452 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3454 * coding.c (encode_designation_at_bol): Change return value to
3457 2012-01-25 Chong Yidong <cyd@gnu.org>
3459 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3461 2012-01-21 Chong Yidong <cyd@gnu.org>
3463 * floatfns.c (Fcopysign): Make the second argument non-optional,
3464 since nil is not allowed anyway.
3466 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3468 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3469 (send_process): Likewise.
3471 2012-01-19 Martin Rudalics <rudalics@gmx.at>
3473 * window.c (save_window_save, Fcurrent_window_configuration)
3474 (Vwindow_persistent_parameters): Do not use Qstate.
3475 Rewrite doc-strings.
3477 2012-01-19 Kenichi Handa <handa@m17n.org>
3479 * character.c (char_width): New function.
3480 (Fchar_width, c_string_width, lisp_string_width):
3481 Use char_width (Bug#9496).
3483 2012-01-16 Martin Rudalics <rudalics@gmx.at>
3485 * window.c (Vwindow_persistent_parameters): New variable.
3486 (Fset_window_configuration, save_window_save): Handle persistent
3489 2012-01-14 Eli Zaretskii <eliz@gnu.org>
3491 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3492 thrashing the stack of the thread. (Bug#9087)
3494 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3496 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3498 2012-01-11 Eli Zaretskii <eliz@gnu.org>
3500 * xdisp.c (rows_from_pos_range): Handle the case where the
3501 highlight ends on a newline. (Bug#10464)
3502 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3503 he end column for display of highlight that ends on a newline
3506 2012-01-11 Glenn Morris <rgm@gnu.org>
3508 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3509 from load-path also when installation-directory is nil. (Bug#10208)
3511 2012-01-10 Glenn Morris <rgm@gnu.org>
3513 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3515 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3516 Update template values to be closer to their typical values these days.
3518 2012-01-09 Eli Zaretskii <eliz@gnu.org>
3520 * xdisp.c (rows_from_pos_range): Accept additional argument
3521 DISP_STRING, and accept any glyph in a row whose object is that
3522 string as eligible for mouse highlight. Fixes mouse highlight of
3523 display strings from overlays. (Bug#10464)
3525 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
3527 emacs: fix an auto-save permissions race condition (Bug#10400)
3528 * fileio.c (auto_saving_dir_umask): New static var.
3529 (Fmake_directory_internal): Use it.
3530 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3531 creating the directory. The old code temporarily assigns
3532 too-generous permissions to the directory.
3533 (do_auto_save_eh): Clear it.
3534 (Fdo_auto_save): Catch all errors, not just file errors, so
3535 that the var is always cleared.
3537 2012-01-07 Eli Zaretskii <eliz@gnu.org>
3539 * search.c (scan_buffer): Pass character positions to
3540 know_region_cache, not byte positions. (Bug#6540)
3542 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
3544 * w32.c (sys_rename): Report EXDEV when rename of a directory
3545 fails because the target is on another logical disk. (Bug#10284)
3547 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3549 * xterm.c (x_embed_request_focus): New function.
3551 * xterm.h: Add prototype.
3553 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3555 2012-01-05 Glenn Morris <rgm@gnu.org>
3557 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3559 2012-01-01 Eli Zaretskii <eliz@gnu.org>
3561 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3562 Load gnutls_transport_set_lowat only if GnuTLS version is below
3564 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3565 GnuTLS versions below 2.11.1.
3567 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3569 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3570 to the doc string advising against its use for altering the way
3571 windows are scrolled.
3573 2011-12-28 Kenichi Handa <handa@m17n.org>
3575 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3576 coding-system ASCII compatible only when it does not produce BOM
3577 on encoding (Bug#10383).
3579 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3581 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3583 (create_and_show_popup_menu): Always use menu_position_func for
3586 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3588 * callint.c (Fcall_interactively): Don't truncate prompt string.
3590 2011-12-23 Eli Zaretskii <eliz@gnu.org>
3592 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3593 property that ends at ZV, so that the bidi iteration could be
3594 resumed from there (after widening). (Bug#10360)
3596 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3598 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3600 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3602 * nsterm.m (x_free_frame_resources):
3603 Release f->output_data.ns->miniimage.
3604 (ns_index_color): Fix indentation. Do not retain
3605 color_table->colors[i].
3607 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3610 * nsfns.m (x_set_background_color): Assign return value from
3611 ns_index_color to face-background instead of NSColor*.
3612 (ns_implicitly_set_icon_type): Fix indentation.
3613 Change assignment in for loop to comparison.
3615 * emacs.c (ns_pool): New variable.
3616 (main): Assign ns_pool.
3617 (Fkill_emacs): Call ns_release_autorelease_pool.
3619 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3620 autorelease fdesc, release fdAttrs and tdict.
3621 (ns_get_covering_families): Release charset.
3622 (ns_findfonts): Release NSFontDescriptor created with new.
3623 (ns_uni_to_glyphs): Fix indentation.
3624 (setString): Release attrStr before assigning new value.
3626 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3628 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3630 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3631 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3633 2011-12-18 David Reitter <reitter@cmu.edu>
3635 * nsterm.m (ns_term_init): Subscribe for notifications
3636 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3637 to method trackingNotification in EmacsMenu.
3639 * nsmenu.m (trackingMenu): New variable.
3640 (trackingNotification): New method (from Aquamacs).
3641 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3642 from Aquamacs (Bug#7030).
3644 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3646 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3647 (symbol_to_nsstring): Fix indentation.
3648 (ns_symbol_to_pb): New function.
3649 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3650 (Fns_rotate_cut_buffers_internal): Remove.
3651 (Fns_store_selection_internal): Rename from
3652 Fns_store_cut_buffer_internal.
3653 (ns_get_foreign_selection, Fx_own_selection_internal)
3654 (Fx_disown_selection_internal, Fx_selection_exists_p)
3655 (Fns_get_selection_internal, Fns_store_selection_internal):
3656 Use ns_symbol_to_pb and check if return value is nil.
3657 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3658 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
3659 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3660 renamed to Sns_store_selection_internal.
3661 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3662 and remove this function.
3663 (ns_handle_selection_clear): Remove, never used.
3664 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3667 2011-12-17 Ken Brown <kbrown@cornell.edu>
3669 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3670 GID is unknown (Bug#10257).
3672 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3674 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3675 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3676 which caused a build failure on GNU/Linux IA-64. This problem was
3677 introduced by my 2011-10-07 patch.
3679 2011-12-15 Juri Linkov <juri@jurta.org>
3681 * image.c (imagemagick_error): New function. (Bug#10112)
3682 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3683 Use `imagemagick_error' where ImageMagick functions return
3685 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3688 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3690 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3691 fill background (Bug#8992).
3693 2011-12-13 Martin Rudalics <rudalics@gmx.at>
3695 * window.c (Vwindow_combination_resize)
3696 (Vwindow_combination_limit): Use t instead of non-nil in
3698 (Vrecenter_redisplay): Add first sentence of doc-string on
3700 (Frecenter): Fix doc-string typo.
3702 2011-12-11 Kenichi Handa <handa@m17n.org>
3704 * coding.c (Funencodable_char_position): Pay attention to the
3705 buffer text relocation (Bug#9389).
3707 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3709 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3710 gtk_init (Bug#10100).
3712 2011-12-10 Eli Zaretskii <eliz@gnu.org>
3714 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3715 IT->string is nil. (Bug#10263)
3717 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3719 * nsterm.h (x_free_frame_resources): Declare.
3721 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3722 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3724 * nsterm.h (ns_get_defaults_value): Declare.
3726 * nsterm.m (ns_default): Call ns_get_defaults_value.
3728 2011-12-09 Eli Zaretskii <eliz@gnu.org>
3730 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3733 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3735 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3736 that where the value of an _OBJC_* symbol points to is in the .bss
3737 section (Bug#10240).
3739 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3741 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
3742 after the loop to call ccl_driver at least once (Bug#8619).
3744 2011-12-08 Kenichi Handa <handa@m17n.org>
3746 * ftfont.c (get_adstyle_property): Fix previous change
3749 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
3751 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3752 dirs from the default value of EMACSLOADPATH (bug#10208).
3754 2011-12-07 Glenn Morris <rgm@gnu.org>
3756 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3757 installation and source directories as well. (Bug#10208)
3759 2011-12-06 Chong Yidong <cyd@gnu.org>
3761 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3763 2011-12-06 Glenn Morris <rgm@gnu.org>
3765 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3766 as an error, not just -1. (Bug#10217)
3768 2011-12-05 Chong Yidong <cyd@gnu.org>
3770 * keyboard.c (process_special_events): New function.
3771 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3773 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3775 * coding.c (encode_designation_at_bol): Don't use uninitialized
3776 local variable (Bug#9318).
3778 2011-12-05 Kenichi Handa <handa@m17n.org>
3780 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3781 return Qnil (Bug#8046, Bug#10193).
3783 2011-12-05 Kenichi Handa <handa@m17n.org>
3785 * coding.c (encode_designation_at_bol): New args charbuf_end and
3786 dst. Return the number of produced bytes. Callers changed.
3787 (coding_set_source): Return how many bytes coding->source was
3789 (coding_set_destination): Return how many bytes
3790 coding->destination was relocated.
3791 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
3792 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
3794 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3796 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3797 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3800 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3802 The following changes are to fix Bug#9318.
3804 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
3805 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3806 (encode_coding_iso_2022, encode_coding_sjis)
3807 (encode_coding_big5, encode_coding_charset): Use the above macros.
3809 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
3811 * lisp.h (process_quit_flag): Fix external declaration.
3813 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3815 Don't macro-inline non-performance-critical code.
3816 * eval.c (process_quit_flag): New function.
3817 * lisp.h (QUIT): Use it.
3819 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3821 * nsfns.m (get_geometry_from_preferences): New function.
3822 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3824 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3826 * emacs.c (Qkill_emacs): Define.
3827 (syms_of_emacs): Initialize it.
3828 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3829 Qquit_flag to `kill-emacs' instead.
3830 (quit_throw_to_read_char): Add parameter `from_signal'.
3831 All callers changed. Call Fkill_emacs if requested and safe.
3832 * lisp.h (QUIT): Call Fkill_emacs if requested.
3834 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3836 * widget.c (update_wm_hints): Return if wmshell is null.
3837 (widget_update_wm_size_hints): New function.
3839 * widget.h (widget_update_wm_size_hints): Declare.
3841 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3842 widget_update_wm_size_hints (Bug#10104).
3844 2011-12-03 Eli Zaretskii <eliz@gnu.org>
3846 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3847 before a newline, prepare the bidi iterator for consuming the
3848 newline, and keep the current paragraph direction. (Bug#10183)
3849 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
3851 2011-12-02 Juri Linkov <juri@jurta.org>
3853 * search.c (Fword_search_regexp): New Lisp function created from
3854 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3855 (Fword_search_backward, Fword_search_forward)
3856 (Fword_search_backward_lax, Fword_search_forward_lax):
3857 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3858 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3860 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3862 * fileio.c (Finsert_file_contents): Move after-change-function call
3863 to before the "handled:" label, since all "goto handled" appear in
3864 cases where the *-change-functions have already been properly called
3867 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3869 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3870 waiting for input. (Bug#10169)
3872 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3874 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3875 verifies glyph row's hash code--we have just reallocated the
3876 glyphs, so their contents can be complete garbage. (Bug#10164)
3878 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
3880 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3882 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3884 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3885 attributes are tested _before_ calling verify_row_hash, to protect
3886 against GCC re-ordering of the tests. (Bug#10164)
3888 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3890 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3892 * xterm.c (handle_one_xevent): Only set async_visible and friends
3893 if net_wm_state_hidden_seen is non-zero (Bug#10002)
3894 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
3895 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3897 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3899 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3900 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3901 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3902 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3903 All uses changed to use GCPRO1 etc.
3904 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3905 Revert to old implementation (i.e., before 2011-03-11).
3907 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3909 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3910 of scroll runs so as to avoid assigning disabled bogus rows and
3911 unnecessary graphics copy operations.
3913 2011-11-27 Eli Zaretskii <eliz@gnu.org>
3915 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3916 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3917 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3918 (malloc, free, realloc, calloc): Redirect to e_* only when
3921 * lisp.h (GCTYPEBITS): Move before first use.
3922 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3923 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3924 this macro definition.
3926 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3929 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3931 * gtkutil.c (xg_create_frame_widgets):
3932 Call gtk_window_set_has_resize_grip (FALSE) if that function is
3933 present with Gtk+ 2.0.
3935 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3937 * fileio.c (Finsert_file_contents): Undo previous change; see
3938 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3940 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3942 Rename locals to avoid shadowing.
3943 * fileio.c (Finsert_file_contents):
3944 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3945 * process.c (wait_reading_process_output):
3946 Rename inner 'proc' to 'p' to avoid shadowing.
3947 Indent for consistency with usual Emacs style.
3949 2011-11-25 Eli Zaretskii <eliz@gnu.org>
3951 * xdisp.c (redisplay_window): If cursor row is not fully visible
3952 after recentering, and scroll-conservatively is set to a large
3953 number, scroll window by a few more lines to make the cursor fully
3954 visible and out of scroll-margin. (Bug#10105)
3955 (start_display): Don't move to the next line if the display should
3956 start at a newline that is part of a display vector or an overlay
3959 2011-11-24 Juri Linkov <juri@jurta.org>
3961 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3962 after the `MagickPingImage' call. (Bug#10112)
3964 2011-11-23 Chong Yidong <cyd@gnu.org>
3966 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3968 2011-11-23 Martin Rudalics <rudalics@gmx.at>
3970 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3971 making another buffer current. (Bug#10114)
3973 2011-11-23 Glenn Morris <rgm@gnu.org>
3975 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3977 2011-11-23 Chong Yidong <cyd@gnu.org>
3979 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3980 using it (Bug#5984).
3982 2011-11-22 Eli Zaretskii <eliz@gnu.org>
3984 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3985 and header-lines, as they don't have one computed for them.
3988 * .gdbinit (prow): Make displayed values more self-explaining.
3989 Add row's hash code.
3991 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3993 * process.c (wait_reading_process_output): Fix asynchrounous
3994 GnuTLS socket handling on some versions of the GnuTLS library.
3995 (wait_reading_process_output): Add comment and URL.
3997 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3999 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4001 2011-11-21 Chong Yidong <cyd@gnu.org>
4003 * window.c (Fnext_window, Fprevious_window): Doc fix.
4005 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4007 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4009 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
4011 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4013 2011-11-20 Martin Rudalics <rudalics@gmx.at>
4015 * window.c (Fset_window_combination_limit): Rename argument
4017 (Vwindow_combination_limit): Remove "status" from doc-string.
4019 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4021 * m/ibms390.h: Remove.
4022 * m/ibms390x.h: Don't include "ibms390.h".
4024 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4026 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4027 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4029 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
4031 * casetab.c (Fset_case_table):
4032 * charset.c (Fcharset_after): Fix typos.
4034 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
4036 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4037 Otherwise, valgrind does not work on some platforms.
4038 Problem reported by Andreas Schwab in
4039 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4040 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4041 is set, removing the need for VIRT_ADDRESS_VARIES.
4042 (PURE_P): Use a more-efficient implementation that needs just one
4043 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4044 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4045 to 4 (xorl, subq, cmpq, setbe).
4046 * alloc.c (pure): Always extern now, since that's the
4047 VIRT_ADDR_VARIES behavior.
4048 (PURE_POINTER_P): Use a single comparison, not two, for
4049 consistency with the new puresize.h.
4050 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4051 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4052 Remove VIRT_ADDR_VARIES no longer needed.
4054 2011-11-19 Eli Zaretskii <eliz@gnu.org>
4056 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4057 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4058 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4059 behave as if the cursor position were at the window margin.
4061 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4062 and the cursor position is out of bounds, behave as if the cursor
4063 position were at the window margin. (Bug#10075)
4065 2011-11-18 Chong Yidong <cyd@gnu.org>
4067 * window.c (Fwindow_combination_limit): Make first argument
4068 non-optional, since it is meaningless for live windows like the
4071 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4073 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4075 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4077 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4078 (graft_intervals_into_buffer): Simplify.
4080 2011-11-18 Eli Zaretskii <eliz@gnu.org>
4082 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4083 hash values of the two rows.
4084 (copy_row_except_pointers): Preserve the used[] arrays and the
4085 hash values of the two rows. (Bug#10035)
4086 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
4088 * xdisp.c (row_hash): New function, body extracted from
4089 compute_line_metrics.
4090 (compute_line_metrics): Call row_hash, instead of computing the
4093 * dispnew.c (verify_row_hash): Call row_hash for computing the
4094 hash code of a row, instead of duplicating code from xdisp.c.
4096 * dispextern.h (row_hash): Add prototype.
4098 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4100 * frame.c (delete_frame): Don't delete the terminal when the last
4101 X frame is closed if emacs is built with GTK toolkit.
4103 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
4105 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4107 2011-11-17 Martin Rudalics <rudalics@gmx.at>
4109 * window.c (Vwindow_splits): Rename to
4110 Vwindow_combination_resize. Suggested by Juri Linkov.
4111 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4114 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
4116 * nsfns.m (Fns_font_name):
4117 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
4119 2011-11-16 Martin Rudalics <rudalics@gmx.at>
4121 * window.h (window): Rename slot "nest" to "combination_limit".
4122 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4123 (Fset_window_nest): Rename to Fset_window_combination_limit.
4124 (Vwindow_nest): Rename to Vwindow_combination_limit.
4125 (recombine_windows, make_parent_window, make_window)
4126 (Fsplit_window_internal, saved_window)
4127 (Fset_window_configuration, save_window_save): Rename all
4128 occurrences of window_nest to window_combination_limit.
4130 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
4132 * image.c (imagemagick_load_image): Fix typo.
4134 2011-11-14 Eli Zaretskii <eliz@gnu.org>
4136 * xdisp.c (display_line): Move the call to
4137 highlight_trailing_whitespace before the call to
4138 compute_line_metrics, since the latter needs to see the final
4139 faces of all the glyphs to compute ROW's hash value.
4140 Fixes assertion violations in row_equal_p. (Bug#10035)
4142 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
4144 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4145 just return (bug#10044).
4147 2011-11-12 Eli Zaretskii <eliz@gnu.org>
4149 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4150 with user-defined heap size. Bump the default size of the temacs
4151 heap to 27MB, to avoid memory warning when running temacs.
4152 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4154 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4155 current_matrix and desired_matrix. (Bug#9990)
4156 (verify_row_hash) [XASSERTS]: New function.
4157 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4158 that the hash value of glyph rows is correct.
4160 2011-11-12 Martin Rudalics <rudalics@gmx.at>
4162 * window.h (window): Remove splits slot.
4163 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4164 (Fdelete_other_windows_internal, make_parent_window)
4165 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4166 (Fset_window_configuration, save_window_save): Don't deal with
4167 split status of windows.
4168 (saved_window): Remove splits slot.
4169 (Vwindow_splits): Rewrite doc-string.
4171 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4173 * xfns.c (unwind_create_frame):
4174 * nsfns.m (unwind_create_frame):
4175 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4176 Vframe_list (Bug#9999).
4178 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4180 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
4182 2011-11-11 Kenichi Handa <handa@m17n.org>
4184 * callproc.c (Fcall_process): Set the member dst_multibyte of
4187 2011-11-11 Johan Bockgård <bojohan@gnu.org>
4189 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4190 avoid a crash (bug#9496).
4192 2011-11-09 Chong Yidong <cyd@gnu.org>
4194 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4195 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4197 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4199 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4201 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4203 Avoid some portability problems by eschewing 'extern inline' functions.
4204 The trivial performance wins aren't worth the portability hassles; see
4205 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4207 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4208 (window_box_width, window_box_left, window_box_left_offset)
4209 (window_box_right, window_box_right_offset): Undo previous change,
4210 by removing the "extern"s.
4211 * intervals.c (adjust_intervals_for_insertion)
4212 (adjust_intervals_for_deletion): Undo previous change,
4213 making these static again.
4214 (offset_intervals, temp_set_point_both, temp_set_point)
4215 (copy_intervals_to_string): No longer inline.
4216 * xdisp.c (window_text_bottom_y, window_box_width)
4217 (window_box_height, window_box_left_offset)
4218 (window_box_right_offset, window_box_left, window_box_right)
4219 (window_box): No longer inline.
4221 2011-11-08 Chong Yidong <cyd@gnu.org>
4223 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
4224 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4225 Signal an error if not a live window.
4226 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4227 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4229 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
4231 * lisp.h (syms_of_abbrev): Remove declaration.
4232 Reported by CHENG Gao <chenggao@royau.me>.
4234 2011-11-07 Eli Zaretskii <eliz@gnu.org>
4236 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4237 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4238 of temacs in GUI mode.
4240 2011-11-07 Martin Rudalics <rudalics@gmx.at>
4242 * window.h: Declare delete_all_child_windows instead of
4243 delete_all_subwindows.
4244 * window.c (Fwindow_nest, Fset_window_nest)
4245 (Fset_window_new_total, Fset_window_new_normal)
4246 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4247 (delete_all_subwindows): Rename to delete_all_child_windows.
4248 (Fdelete_other_windows_internal, Fset_window_configuration):
4249 Call delete_all_child_windows instead of delete_all_subwindows.
4250 * frame.c (delete_frame): Call delete_all_child_windows instead
4251 of delete_all_subwindows.
4253 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4255 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4256 This is also needed for porting to any host where GC_MARK_STACK is
4257 not GC_MAKE_GCPROS_NOOPS.
4258 (which_symbols): Use it.
4260 2011-11-07 Kenichi Handa <handa@m17n.org>
4262 * coding.c (coding_set_destination): Check coding->src_pos only
4263 when coding->src_object is a buffer (bug#9910).
4265 * process.c (send_process): Set the member src_multibyte of coding
4266 to 0 (bug#9911) when sending a unibyte text.
4268 * callproc.c (Fcall_process): Set the member src_multibyte of
4269 process_coding to 0 (bug#9912).
4271 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4273 * xmenu.c (cleanup_widget_value_tree): New function.
4274 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4275 calling free_menubar_widget_value_tree directly (Bug#9830).
4277 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4279 Fix some portability problems with 'inline'.
4280 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4281 (window_box_width, window_box_left, window_box_left_offset)
4282 (window_box_right, window_box_right_offset): Declare extern.
4283 Otherwise, these inline functions do not conform to C99 and
4284 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4285 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4286 * intervals.c (adjust_intervals_for_insertion)
4287 (adjust_intervals_for_deletion): Now extern, because otherwise the
4288 extern inline functions 'offset_intervals' couldn't refer to it.
4289 (static_offset_intervals): Remove.
4290 (offset_intervals): Rewrite using the old contents of
4291 static_offset_intervals. The old version didn't conform to C99
4292 because an extern inline function contained a reference to an
4293 identifier with static linkage.
4295 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4297 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4300 2011-11-06 Eli Zaretskii <eliz@gnu.org>
4302 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4303 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4304 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4305 return Qleft_to_right.
4307 2011-11-06 Chong Yidong <cyd@gnu.org>
4309 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4310 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4311 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4312 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4313 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4314 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4315 (Fwindow_vscroll): Doc fix.
4316 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4317 argument, since it makes no sense to pass a live window and for
4318 consistency with window-child.
4320 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4322 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4325 2011-11-05 Jason Rumney <jasonr@gnu.org>
4327 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4328 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4330 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4331 bitwise arithmetic preventing use of unicode-sip and non-truetype
4334 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4336 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4339 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4340 initialization code to keep similarity to xfns.c after changes
4343 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4345 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4346 (unwind_create_frame): New function (Bug#9943).
4347 (Fx_create_frame): Restructure code to be more similar to the one in
4348 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4349 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4350 Move terminal->reference_count++ just before making the frame official
4353 * nsterm.m (x_free_frame_resources): New function.
4354 (x_destroy_window): Move code to x_free_frame_resources.
4356 * xfns.c (unwind_create_frame): Fix comment.
4357 (Fx_create_frame, x_create_tip_frame):
4358 Move terminal->reference_count++ just before making the frame
4359 official. Move initialization of image_cache_refcount and
4360 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4362 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4364 Support MSVC build with newer versions of Visual Studio.
4365 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4366 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4369 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4370 which are not supported by MSVC.
4371 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4372 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4374 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4376 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4378 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4380 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
4382 Support MSVC build with newer versions of Visual Studio.
4383 * w32.c: Don't include w32api.h for MSVC.
4384 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4386 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4387 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4388 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4389 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4391 (alloca) [_MSC_VER]: Define to _alloca.
4393 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4395 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4397 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4399 * xdisp.c (note_mouse_highlight): If either of
4400 previous/next-single-property-change returns nil, treat that as
4401 the beginning or the end of the buffer. (Bug#9955)
4403 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4405 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
4406 label is not null (Bug#9951).
4407 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4410 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4412 * window.c (Fwindow_body_size): Mention in the doc string that the
4413 return value is in frame's canonical units. (Bug#9949)
4415 2011-11-03 Eli Zaretskii <eliz@gnu.org>
4417 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4419 * w32fns.c (unwind_create_frame): If needed, free the glyph
4420 matrices of the partially constructed frame. (Bug#9943)
4421 * xfns.c (unwind_create_frame): Likewise.
4423 2011-11-01 Eli Zaretskii <eliz@gnu.org>
4425 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4426 Don't stop backward scan on the continuation glyph, even though
4427 its CHARPOS is positive.
4428 (mouse_face_from_buffer_pos, note_mouse_highlight):
4429 Rename cover_string to disp_string.
4431 2011-11-01 Martin Rudalics <rudalics@gmx.at>
4433 * window.c (temp_output_buffer_show): Don't use
4434 Vtemp_buffer_show_specifiers.
4435 (Vtemp_buffer_show_specifiers): Remove unused variable.
4437 2011-10-30 Eli Zaretskii <eliz@gnu.org>
4439 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4440 past the beginning of the current glyph matrix.
4442 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
4444 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4445 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4446 HAVE_GTK3 (Bug#9869).
4448 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4449 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4451 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4453 * xterm.c: Declare x_handle_net_wm_state to return int.
4454 (handle_one_xevent): Check if we are iconified but don't have
4455 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4456 (get_current_wm_state): Return non-zero if not hidden,
4457 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4458 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4459 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4460 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4462 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4464 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4465 so that this new function doesn't get optimized away by a
4466 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4468 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4470 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4472 2011-10-29 Eli Zaretskii <eliz@gnu.org>
4474 Fix the `xbytecode' command.
4475 * .gdbinit (xprintbytestr): New command.
4476 (xwhichsymbols): Rename from `which'; all callers changed.
4477 (xbytecode): Print the byte-code string as well.
4479 2011-10-29 Kim Storm <storm@cua.dk>
4481 * alloc.c (which_symbols): New function.
4483 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4485 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4488 2011-10-29 Glenn Morris <rgm@gnu.org>
4490 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4491 Not clear what it was for, and it causes various bugs. (Bug#9839)
4493 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4495 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4496 possible random value that matches one of those tested as
4497 condition to clear the mouse face.
4499 2011-10-28 Chong Yidong <cyd@gnu.org>
4501 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4503 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4505 * window.c (make_window): Initialize phys_cursor_on_p.
4507 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4509 * lisp.h (struct Lisp_Symbol): Update comments.
4511 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
4513 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4515 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4517 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4518 <oslsachem@gmail.com> for helping to debug this.
4520 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4521 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4522 (g_b_init_get_glyph_outline_w): New static variables.
4523 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4524 (GetGlyphOutlineW_Proc): New typedefs.
4525 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
4526 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4528 (w32font_open_internal, compute_metrics):
4529 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
4530 instead of calling the "wide" APIs directly.
4532 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4534 * w32.h (syms_of_w32font): Add prototype.
4536 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
4538 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4539 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4540 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4541 (Fmove_to_window_line): Doc fix.
4543 2011-10-27 Chong Yidong <cyd@gnu.org>
4545 * process.c (make_process): Set gnutls_state to NULL.
4547 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4548 non-NULL, regardless of GNUTLS_INITSTAGE.
4549 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4550 an error. Set process slots as soon as we allocate them.
4552 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4554 2011-10-27 Chong Yidong <cyd@gnu.org>
4556 * gnutls.c (emacs_gnutls_deinit): New function.
4557 Deallocate credentials structures as well as calling gnutls_deinit.
4558 (Fgnutls_deinit, Fgnutls_boot): Use it.
4560 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4561 (deactivate_process): Call emacs_gnutls_deinit.
4563 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
4565 * image.c (x_create_x_image_and_pixmap):
4566 * w32.c (sys_rename, w32_delayed_load):
4567 * w32font.c (fill_in_logfont):
4568 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4570 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
4572 * w32fns.c (w32_default_color_map): New function,
4573 extracted from Fw32_default_color_map.
4574 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
4576 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4578 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4580 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4582 * keyboard.c (test_undefined): New function (bug#9751).
4583 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4585 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4587 * sysdep.c (init_sys_modes): Fix the check for the controlling
4588 terminal (Bug#6649).
4590 2011-10-20 Eli Zaretskii <eliz@gnu.org>
4592 * dispextern.h (struct bidi_it): New member next_en_type.
4594 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4595 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4596 current character, check also for next_en_type being WEAK_EN.
4597 (bidi_resolve_weak): Don't enter the expensive loop if the current
4598 position is before next_en_pos. Record the bidi type of the first
4599 non-ET, non-BN character we find, in addition to its position.
4600 (bidi_level_of_next_char): Invalidate next_en_type when
4601 next_en_pos is over-stepped.
4603 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4605 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4606 * editfns.c: Rewrite current-time-zone so that it invokes
4607 the equivalent of (format-time-string "%Z") to get the time zone name.
4608 This fixes a bug when the time zone name contains characters that
4609 need converting from the system time locale to Emacs internal format.
4610 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4611 that patch fixed format-time-string to do the conversion, but
4612 I forgot to fix current-time-zone.
4613 (format_time_string): New function, containing most of
4614 what Fformat_time_string used to contain.
4615 (Fformat_time_string): Rewrite in terms of format_time_string.
4616 This doesn't change this function's behavior.
4617 (current-time-zone): Rewrite to use format_time_string.
4618 This fixes the bug reported by Michael Schierl in
4619 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4620 Jason Rumney's 2007-06-07 change worked around this bug, but
4622 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4624 2011-10-19 Eli Zaretskii <eliz@gnu.org>
4626 * xdisp.c (start_display): If the character at POS is displayed
4627 via a display vector, reset IT->current.dpvec_index to zero.
4628 (try_window_reusing_current_matrix): If a line ends in a display
4629 vector or the next line starts in a display vector, continue
4630 redrawing the window even though the character position of
4631 start_row was reached.
4634 2011-10-18 Chong Yidong <cyd@gnu.org>
4636 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4637 with nobreak-char-display too.
4639 2011-10-18 Eli Zaretskii <eliz@gnu.org>
4641 Fix part 3 of bug#9771.
4642 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4643 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4644 non-neutral characters if the current character is a paragraph
4645 separator (a.k.a. Newline). This avoids running the same
4646 expensive loop twice, once when we consume the preceding newline
4647 and the other time when the line actually needs to be displayed.
4648 Avoid the loop when we see neutrals on the base embedding level
4649 following a character whose directionality is the same as the
4650 paragraph's. This avoids running the expensive loop when a line
4651 ends in a long sequence of neutrals, like control characters.
4652 Add assertion against STRONG_AL type. Slightly rearrange code
4653 that determines the type of a neutral given the first non-neutral
4655 (bidi_level_of_next_char): Set next_en_pos to zero when
4656 invalidating its info.
4658 2011-10-17 Eli Zaretskii <eliz@gnu.org>
4660 * xdisp.c (push_display_prop): Determine whether to record string
4661 or buffer position by IT->string, not by IT->method. Allow
4662 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
4663 (move_it_vertically_backward): Don't look for character position
4664 immediately after the newline when in a continuation line.
4667 2011-10-15 Martin Rudalics <rudalics@gmx.at>
4669 * window.c (coordinates_in_window): Rewrite and delabelize
4670 vertical border check. (Bug#5357) (Bug#9618)
4672 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4674 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4675 errors in XSetWindowBorder (bug#9310).
4677 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4679 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4680 avoid crash when xmalloc overrun checking is enabled.
4682 2011-10-13 Eli Zaretskii <eliz@gnu.org>
4684 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4685 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4686 cursor motion with <left> and <right> arrow keys.
4688 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4689 some callers set that themselves.
4691 2011-10-12 Eli Zaretskii <eliz@gnu.org>
4693 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4694 display string and the previous row comes from the same string and
4695 is empty. (Bug#9739) (Bug#9738)
4697 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4699 * doc.c (get_doc_string): Encode file name (bug#9735).
4701 2011-10-12 Eli Zaretskii <eliz@gnu.org>
4703 * bidi.c (bidi_level_of_next_char):
4704 * xdisp.c (get_visually_first_element): Remove old incorrect
4705 comments regarding the Unicode Line Separator character.
4707 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4709 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4711 * alloc.c (Fgc_status): Do not access beyond zombies array
4712 boundary if nzombies > MAX_ZOMBIES.
4713 * alloc.c (dump_zombies): Add missing format specifier.
4715 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4717 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4718 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4720 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4721 Some packages use them to denote characters with modifiers.
4723 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4725 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4726 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4727 matching a pp-number. Rename parameter var to var1.
4729 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4731 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4733 2011-10-08 Glenn Morris <rgm@gnu.org>
4735 * callint.c (Fcall_interactively): Give a more explicit error for the
4736 'c' case with a non-character input. (Bug#8479)
4738 2011-10-08 Eli Zaretskii <eliz@gnu.org>
4740 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4742 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4743 lines that are hscrolled on the left.
4745 * dispnew.c (buffer_posn_from_coords): Account for a possible
4746 presence of header-line. (Bug#4426)
4748 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4750 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4751 Don't advertise functionality which we discourage or doesn't work.
4753 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4755 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4756 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4757 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4758 this makes Emacs dump core during garbage collection on rare
4759 occasions. sizeof is obviously inferior to offsetof here, so
4760 stick with offsetof.
4761 (GC_POINTER_ALIGNMENT): New macro.
4762 (mark_memory): Omit 3rd (offset) arg; caller changed.
4763 Don't assume EMACS_INT alignment is the same as pointer alignment.
4765 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4767 * keyboard.c (read_key_sequence_remapped): New var.
4768 (read_key_sequence): Compute remapping in the right buffer.
4769 (command_loop_1): Use read_key_sequence's remapping directly.
4771 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4773 * dired.c (file_name_completion): Don't expand file name.
4774 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4775 before checking file name handler.
4777 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4778 they've been requested explicitly (bug#9591).
4780 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
4782 * keymap.c (Fsingle_key_description): Use make_specified_string
4783 instead of build_string to build string from push_key_description.
4786 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4788 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4789 This fixes a Y2038 bug on 64-bit hosts.
4790 * buffer.c (reset_buffer):
4791 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4792 (Fclear_buffer_auto_save_failure):
4793 Use 0, not -1, to represent an unset failure time, since time_t
4794 might not be signed.
4796 Remove dependency on glibc malloc internals.
4797 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4798 Move back here from lisp.h, but with their new implementations.
4799 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4800 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4801 * charset.c (charset_table_init): New static var.
4802 (syms_of_charset): Use it instead of xmalloc. This removes a
4803 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4804 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4805 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4806 Move back to alloc.c.
4807 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4808 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4810 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4812 * nsterm.m (windowDidResize): Call x_set_window_size only when
4813 ns_in_resize is true. Otherwise set pixelwidth/height and
4814 call change_frame_size (Bug#9628).
4816 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4818 Port --enable-checking=all to Fedora 14 x86-64.
4819 * charset.c (syms_of_charset): Also account for glibc malloc's
4820 internal overhead when calculating the initial malloc maximum.
4822 Port --enable-checking=all to Fedora 14 x86.
4823 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4825 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4826 (overrun_check_realloc, overrun_check_free):
4827 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4828 That way, xmalloc returns a properly-aligned pointer even if
4829 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4830 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4831 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4832 into account when calculating the initial malloc maximum.
4833 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4834 Move here from alloc.c, so that charset.c can use it too.
4835 Properly align; the old code wasn't right for common 32-bit hosts
4836 when configured with --enable-checking=all.
4837 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4838 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4840 2011-09-29 Eli Zaretskii <eliz@gnu.org>
4842 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
4845 2011-09-28 Eli Zaretskii <eliz@gnu.org>
4847 * xdisp.c (compute_display_string_end): If there's no display
4848 string at CHARPOS, return -1.
4850 * bidi.c (bidi_fetch_char): When compute_display_string_end
4851 returns a negative value, treat the character as a normal
4852 character not covered by a display string. (Bug#9624)
4854 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
4856 * lread.c (Fread_from_string): Fix typo in docstring.
4858 2011-09-27 Eli Zaretskii <eliz@gnu.org>
4860 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4861 newline, reseat the iterator instead of bidi-iterating there one
4862 character at a time. (Bug#9610)
4863 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4864 TO_CHARPOS if the bidi iterator is at base embedding level.
4866 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4868 * lread.c (readevalloop): Use correct code for NBSP.
4869 (read1): Likewise. (Bug#9608)
4871 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
4873 * dbusbind.c (Fdbus_register_signal): When service is not
4874 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4876 2011-09-25 Glenn Morris <rgm@gnu.org>
4878 * buffer.c (truncate-lines): Doc fix.
4880 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
4882 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4883 (Fset_window_next_buffers): Doc fix.
4885 2011-09-24 Glenn Morris <rgm@gnu.org>
4887 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4889 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4891 Fix minor problems found by static checking.
4892 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
4893 * indent.c (Fvertical_motion): Fix == vs = typo.
4895 2011-09-24 Eli Zaretskii <eliz@gnu.org>
4897 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4898 Default value is now t. Doc fix.
4900 * indent.c (Fvertical_motion): Compute and apply the overshoot
4901 logic when moving up, not only when moving down. Fix the
4902 confusing name and values of the it_overshoot_expected variable;
4903 logic changes accordingly. (Bug#9254) (Bug#9549)
4905 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4906 CHARPOS is covered by a display string which includes newlines.
4907 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4908 is covered by a display string with embedded newlines.
4910 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
4912 * dbusbind.c (Fdbus_register_signal): Add match rule to
4913 Vdbus_registered_objects_table. (Bug#9581)
4914 (Fdbus_register_method, Vdbus_registered_objects_table):
4917 2011-09-24 Jim Meyering <meyering@redhat.com>
4919 do not ignore write error for any output size
4920 The previous change was incomplete.
4921 While it makes emacs --batch detect the vast majority of stdout
4922 write failures, errors were still ignored whenever the output size is
4923 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4924 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4925 && echo FAIL: ignored write error
4926 FAIL: ignored write error
4927 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4928 && echo FAIL: ignored write error
4929 FAIL: ignored write error
4930 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4932 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4934 * emacs.c (Fkill_emacs): In noninteractive mode exit
4935 non-successfully if a write error occurred on stdout. (Bug#9574)
4937 2011-09-21 Eli Zaretskii <eliz@gnu.org>
4939 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4942 * dispextern.h (struct it): Update the comment documenting what
4945 2011-09-20 Eli Zaretskii <eliz@gnu.org>
4947 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4948 a display string, extend search for cursor position to end of row.
4949 (find_row_edges): If the row ends in a newline from a display
4950 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4951 Handle the case of a display string with multiple newlines.
4952 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4953 non-empty line. Fixes confusing cursor motion with arrow keys at
4954 the beginning of a line that starts with whitespace.
4956 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4958 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4961 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
4963 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4966 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4968 * xdisp.c (display_line): Record maximum and minimum buffer
4969 positions even if no glyphs were produced (e.g., by a zero-width
4970 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4971 buffer positions that will be removed from the glyph row because
4973 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4974 column is beyond frame width: don't subtract 1 "pixel" when
4975 computing width of the stretch.
4976 (reseat_at_next_visible_line_start): Undo the change made on
4977 2011-09-17 that saved paragraph information and restored it after
4978 the call to `reseat'. (Bug#9545)
4980 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4982 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4983 and turn window cursor on if cleared (Bug#9415).
4985 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
4987 * search.c (boyer_moore): Take unibyte characters from pattern
4988 literally. (Bug#9458)
4990 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4992 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4994 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4996 Fix minor problem found by static checking.
4997 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4998 initialized, to pacify gcc -Wuninitialized.
5000 * fileio.c: Report proper errno when syscall falls.
5001 (Finsert_file_contents): Save and restore errno,
5002 so that report_file_error outputs the correct diagnostic.
5003 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5005 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5007 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5009 2011-09-17 Eli Zaretskii <eliz@gnu.org>
5011 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5012 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5014 2011-09-17 Eli Zaretskii <eliz@gnu.org>
5016 * xdisp.c (reseat_at_next_visible_line_start): Keep information
5017 about the current paragraph and restore it after the call to reseat.
5019 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5020 (bidi_find_paragraph_start): Search back for paragraph beginning
5021 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5022 (bidi_move_to_visually_next): Only trigger paragraph-related
5023 computations when the last character is a newline or at EOB, not
5024 just any NEUTRAL_B. (Bug#9470)
5026 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5027 truncated lines if point is covered by a display string. (Bug#9524)
5029 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5031 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5032 (cons_to_x_long): New function.
5033 (lisp_data_to_selection_data): Use it. Correct the test for
5034 short-versus-long data; it was negated. Break out of vector
5035 loop, for efficiency, when a long datum is discovered.
5037 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5039 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5041 2011-09-16 Eli Zaretskii <eliz@gnu.org>
5043 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5044 GCC PR/17406) by declaring this function with external scope.
5046 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5048 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5049 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5051 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5053 * editfns.c (Fformat): Correctly handle text properties on "%%".
5055 2011-09-15 Eli Zaretskii <eliz@gnu.org>
5057 * xterm.c (x_draw_composite_glyph_string_foreground):
5058 * w32term.c (x_draw_composite_glyph_string_foreground):
5059 * term.c (encode_terminal_code):
5060 * composite.c (composition_update_it, get_composition_id):
5061 * xdisp.c (get_next_display_element)
5062 (fill_composite_glyph_string): Add comments about special meaning
5063 of TAB characters in a composition.
5065 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5067 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
5068 This occurs when processing a multibyte format.
5069 Problem reported by Wolfgang Jenker.
5071 2011-09-15 Johan Bockgård <bojohan@gnu.org>
5073 * xdisp.c (try_cursor_movement): Only check for exact match if
5074 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5076 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5078 Remove unused external symbols.
5079 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5080 * xdisp.c (calc_pixel_width_or_height): Now static.
5081 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5082 * indent.c (check_display_width):
5083 * w32term.c: Fix comment to match code.
5084 * xterm.c, xterm.h (x_catching_errors): Remove.
5086 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5088 * xselect.c: Use signed conversions more consistently (Bug#9498).
5089 (selection_data_to_lisp_data): Assume incoming selection data are
5090 signed integers, not unsigned. This is to be consistent with
5091 outgoing selection data, which was modified to use signed integers
5092 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5093 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5094 expects long, not unsigned long.
5096 2011-09-14 Eli Zaretskii <eliz@gnu.org>
5098 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5099 computation of loop end. Reported by Johan Bockgård
5102 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
5104 * frame.c (Fother_visible_frames_p): Function deleted.
5106 2011-09-12 Eli Zaretskii <eliz@gnu.org>
5108 * indent.c (compute_motion): Process display vector front to back
5109 rather than the other way around. (Bug#2496)
5111 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5113 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5115 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
5117 * minibuf.c (Fread_from_minibuffer): Doc fix.
5119 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5121 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5122 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5124 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5126 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5127 value for non-existent files.
5129 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5131 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5132 set its "size" to -1. This will set the modtime_size field of
5133 the corresponding buffer to -1, which is what
5134 verify-visited-file-modtime expects for files that do not exist.
5137 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5139 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5141 * lisp.h: ... from here. push_key_description is no longer
5142 defined in keyboard.c, so its declaration should not be in
5143 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5144 logically belongs with push_key_description.
5146 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5148 * buffer.h: Include <sys/types.h> instead of <time.h>.
5149 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5150 Problem reported by Herbert J. Skuhra.
5152 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5154 * xml.c (parse_region): Make the parsing work for
5155 non-comment-starting XML files again (bug#9144).
5157 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5159 * image.c (gif_load): Fix calculation of bottom and right corner.
5162 2011-09-10 Eli Zaretskii <eliz@gnu.org>
5164 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5165 redisplay in small windows.
5167 2011-09-09 Eli Zaretskii <eliz@gnu.org>
5169 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5171 2011-09-08 Martin Rudalics <rudalics@gmx.at>
5173 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5174 Operate on live windows only.
5176 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
5178 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5180 2011-09-07 Eli Zaretskii <eliz@gnu.org>
5182 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5183 only under bidi iteration.
5185 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5187 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5189 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5191 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5192 Without this fix, the command to link temacs failed due to an
5193 undefined symbol __builtin_isnan. This is because
5194 /usr/include/iso/math_c99.h #defines isnan(x) to
5195 __builtin_isnan(x), but the bundled gcc, which identifies itself
5196 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5198 * floatfns.c (isnan): #undef, and then #define to a clone of
5200 (Fisnan): Always define, since it's always available now.
5201 (syms_of_floatfns): Always define isnan at the Lisp level.
5203 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5205 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5207 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5209 * fileio.c: Fix bugs with large file offsets (Bug#9428).
5210 The previous code assumed that file offsets (off_t values) fit in
5211 EMACS_INT variables, which is not true on typical 32-bit hosts.
5212 The code messed up by falsely reporting buffer overflow in cases
5213 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5214 when "big" contains more than 2**29 bytes, even though this
5215 inserts just one byte and does not overflow the buffer.
5216 (Finsert_file_contents): Store file offsets as off_t
5217 values, not as EMACS_INT values. Check for overflow when
5218 converting between EMACS_INT and off_t. When checking for
5219 buffer overflow or for overlap, take the offsets into account.
5220 Don't use EMACS_INT for small values where int suffices.
5221 When checking for overlap, fix a typo: ZV was used where
5222 ZV_BYTE was intended.
5223 (Fwrite_region): Don't assume off_t fits into 'long'.
5224 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5226 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
5228 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5230 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5232 sprintf-related integer and memory overflow issues (Bug#9412).
5234 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
5235 (esprintf, exprintf, evxprintf): New functions.
5236 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
5237 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
5238 (modify_event_symbol): Do not assume that the length of
5239 name_alist_or_stem is safe to alloca and fits in int.
5240 (Fexecute_extended_command): Likewise for function name and binding.
5241 (Frecursion_depth): Wrap around reliably on integer overflow.
5242 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5243 since some callers pass EMACS_INT values.
5244 (Fsingle_key_description): Don't crash if symbol name contains more
5245 than MAX_ALLOCA bytes.
5246 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5247 (get_minibuffer): Arg is now EMACS_INT, not int.
5248 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
5249 (esprintf, exprintf, evxprintf): New decls.
5250 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5252 * dbusbind.c (signature_cat): New function.
5253 (xd_signature, Fdbus_register_signal):
5254 Do not overrun buffer; instead, report string overflow.
5256 * dispnew.c (add_window_display_history): Don't overrun buffer.
5257 Truncate instead; this is OK since it's just a log.
5259 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5260 even if the time zone offset is outlandishly large.
5261 Don't mishandle offset == INT_MIN.
5263 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5264 when creating daemon; the previous buffer-overflow check was incorrect.
5266 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5267 which has the guts of the old verror function.
5269 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5270 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5272 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5273 (font_unparse_xlfd): Don't blindly alloca long strings.
5274 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
5275 fits in int, when using sprintf. Use single snprintf to count
5276 length of string rather than counting it via multiple sprintfs;
5277 that's simpler and more reliable.
5278 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5279 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5280 sprintf, in case result does not fit in int.
5282 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5283 (fontset_from_font): Print it.
5285 * frame.c (tty_frame_count): Now printmax_t, not int.
5286 (make_terminal_frame, set_term_frame_name): Print it.
5287 (x_report_frame_params): In X, window IDs are unsigned long,
5288 not signed long, so print them as unsigned.
5289 (validate_x_resource_name): Check for implausibly long names,
5290 and don't assume name length fits in 'int'.
5291 (x_get_resource_string): Don't blindly alloca invocation name;
5292 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5295 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5296 (xg_check_special_colors, xg_set_geometry):
5297 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5299 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5300 Use esprintf, not sprintf, in case result does not fit in int.
5302 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5303 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5304 it as a large positive number.
5305 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5306 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5308 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5309 in case result does not fit in int.
5311 * print.c (float_to_string): Detect width overflow more reliably.
5312 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5313 buffer overrun. Don't assume list length fits in 'int'. Treat
5314 print length of 0 as 0, not as infinity; to be consistent with other
5315 uses of print length in this function. Don't overflow print length
5316 index. Don't assume hash table size fits in 'long', or that
5317 vectorlike size fits in 'unsigned long'.
5319 * process.c (make_process): Use printmax_t, not int, to format
5320 process-name gensyms.
5322 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5324 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5325 to avoid potential buffer overrun.
5327 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5328 if X resource line is longer than 512 bytes.
5330 * xfns.c (x_window): Make sprintf buffer a bit bigger
5331 to avoid potential buffer overrun.
5333 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5335 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5337 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5339 Integer overflow fixes for scrolling, etc.
5340 Without these, Emacs silently mishandles large integers sometimes.
5341 For example, "C-u 4294967297 M-x recenter" was treated as if
5342 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5344 * xdisp.c (try_window_id): Check Emacs fixnum range before
5345 converting to 'int'.
5347 * window.c (window_scroll_line_based, Frecenter):
5348 Check that an Emacs fixnum is in range before assigning it to 'int'.
5349 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5350 values converted from Emacs fixnums.
5351 (Frecenter): Don't wrap around a line count if it is out of 'int'
5352 range; instead, treat it as an extreme value.
5353 (Fset_window_configuration, compare_window_configurations):
5354 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5356 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5357 that can exceed INT_MAX. Check that EMACS_INT value is in range
5358 before assigning it to the (possibly-narrower) index.
5359 (match_limit): Don't assume that a fixnum can fit in 'int'.
5361 * print.c (print_object): Use ptrdiff_t, not int, for index that can
5364 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
5365 (Fvertical_motion): Don't wrap around LINES values that don't fit
5366 in 'int'. Instead, treat them as extreme values. This is good
5367 enough for windows, which can't have more than INT_MAX lines anyway.
5369 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5371 * Require libxml/parser.h to avoid compilation warning.
5373 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5375 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5376 since this reportedly can destroy thread storage.
5378 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
5380 * syntax.c (find_defun_start): Update all cache variables if
5381 exiting early (Bug#9401).
5383 2011-08-30 Eli Zaretskii <eliz@gnu.org>
5385 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5387 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5388 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5389 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5391 * term.c (tty_append_glyph): New function.
5392 (produce_stretch_glyph): Static function and its prototype deleted.
5394 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5397 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5399 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5400 when checking :margin (Bug#9390).
5401 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
5402 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
5403 so that the name doesn't mislead. All uses changed.
5405 2011-08-28 Johan Bockgård <bojohan@gnu.org>
5407 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5410 2011-08-27 Eli Zaretskii <eliz@gnu.org>
5412 * xdisp.c (move_it_to): Don't bail out early when reaching
5413 position beyond to_charpos, if we are scanning backwards.
5414 (move_it_vertically_backward): When DY == 0, make sure we get to
5415 the first character in the line after the newline.
5417 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5419 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5420 (ccl_driver): Do not generate an out-of-range pointer.
5421 (Fccl_execute_on_string): Remove unnecessary check for
5422 integer overflow, noted by Stefan Monnier in
5423 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5424 Remove a FIXME that didn't need fixing.
5425 Simplify the newly-introduced buffer reallocation code.
5427 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
5429 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5431 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
5433 Integer and memory overflow issues (Bug#9196).
5435 * doc.c (get_doc_string): Rework so that
5436 get_doc_string_buffer_size is the actual buffer size, rather than
5437 being 1 less than the actual buffer size; this makes xpalloc more
5440 * image.c (x_allocate_bitmap_record, cache_image):
5441 * xselect.c (Fx_register_dnd_atom):
5442 Simplify previous changes by using xpalloc.
5444 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5445 since either will do and ptrdiff_t is convenient with xpalloc.
5447 * charset.c (charset_table_size)
5448 (struct charset_sort_data.priority): Now ptrdiff_t.
5449 (charset_compare): Don't overflow if priorities differ greatly.
5450 (Fsort_charsets): Don't assume list length fits in int.
5451 Check for size-calculation overflow when allocating sort data.
5452 (syms_of_charset): Allocate an initial charset table that is
5453 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5455 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5457 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5458 The actual value is always <= INT_MAX, and leaving it unsigned made
5459 overflow checking harder.
5461 * dispextern.h (struct glyph_matrix.rows_allocated)
5462 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5463 with xpalloc. The values are still always <= INT_MAX.
5465 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5467 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5468 (SAFE_NALLOCA): New macro.
5470 * region-cache.c (struct boundary.pos, find_cache_boundary)
5471 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5472 (set_cache_region, invalidate_region_cache)
5473 (revalidate_region_cache, know_region_cache, region_cache_forward)
5474 (region_cache_backward, pp_cache):
5475 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5476 so that ptrdiff_t * can be passed to xpalloc.
5477 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5478 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5479 (pp_cache): Don't assume cache_len fits in int.
5480 * region-cache.h: Adjust extern decls to match.
5482 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5483 EMACS_INT, since either will do, for xpalloc.
5485 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5486 (xnmalloc, xnrealloc, xpalloc): New functions.
5488 * bidi.c (bidi_shelve_header_size): New constant.
5489 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5490 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5492 * bidi.c (bidi_cache_shrink):
5493 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5495 Don't update size of array until after memory allocation succeeds,
5496 because xmalloc/xrealloc may not return.
5497 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5498 now that we have proper integer overflow checking.
5499 (record_overlay_string, overlay_strings): Catch overflows when
5500 calculating size of overlay_str_buf.
5502 * callproc.c (Fcall_process): Check for size overflow when
5503 calculating size of args2.
5504 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5505 Normally we prefer signed values, but sticking with ptrdiff_t would
5506 require adding more-complicated checks.
5508 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5509 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5510 Redo buffer-overflow calculations to avoid integer overflow.
5511 Add a FIXME comment where memory seems to be over-allocated.
5513 * character.c (Fstring): Check for size-calculation overflow.
5515 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5516 unnecessary integer overflow. Check for size overflow.
5517 (encode_coding_object): Don't update size until xmalloc succeeds.
5519 * composite.c (get_composition_id): Check for overflow in glyph
5520 length calculations.
5522 Integer and memory overflow fixes for display code.
5523 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5524 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5525 (scrolling_window): Check for overflow in size calculations.
5526 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5527 Don't assume glyph table len fits in int.
5528 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5529 (row_table_size): Now ptrdiff_t, not int.
5530 (scrolling_window): Avoid overflow in size calculations.
5531 Don't update size until allocation succeeds.
5532 * fns.c (concat): Check for overflow in size calculations.
5533 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5534 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5535 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5537 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5538 (get_doc_string): Check for size calculation overflow.
5539 Don't update size until allocation succeeds.
5540 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5541 EMACS_INT, where ptrdiff_t will do.
5542 (Fsubstitute_command_keys): Check for string overflow.
5544 * editfns.c (set_time_zone_rule): Don't assume environment length
5546 (message_length): Now ptrdiff_t, not int.
5547 (Fmessage_box): Don't update size until allocation succeeds.
5548 Don't assume message length fits in int.
5549 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5551 * emacs.c (main): Do not reallocate argv, since there is a null at
5552 the end that can be overwritten, and this way there's no need to
5553 worry about size-calculation overflow.
5554 (sort_args): Check for size-calculation overflow.
5556 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5558 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5560 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5561 (x_set_scroll_bar_width, x_figure_window_size):
5562 Check for integer overflow.
5563 (x_set_alpha): Do not assume XINT fits in int.
5565 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5566 This is for the members text_lines, text_cols, total_lines, total_cols,
5567 where the system imposes an 'int' limit.
5569 * fringe.c (Fdefine_fringe_bitmap):
5570 Don't update size until alloc works.
5572 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5573 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5575 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5576 Check for size-calculation overflow.
5577 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5578 do, as we prefer signed integers.
5579 (id_to_widget.max_size, id_to_widget.used)
5580 (xg_store_widget_in_map, xg_remove_widget_from_map)
5581 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5582 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5583 Use and return ptrdiff_t, not int.
5584 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5585 * gtkutil.h: Change prototypes to match the above.
5587 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5588 are duplicate now that they've been promoted to lisp.h.
5589 (x_allocate_bitmap_record, x_alloc_image_color)
5590 (make_image_cache, cache_image, xpm_load):
5591 Don't update size until alloc is done.
5592 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5594 Check for size calculation overflow.
5595 (ct_colors_allocated_max): New constant.
5596 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5599 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5600 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5601 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5602 Use ptrdiff_t, not int, to count maps.
5603 (read_char_minibuf_menu_prompt): Check for overflow in size
5604 calculations. Don't update size until allocation succeeds.
5605 Redo calculations to avoid overflow.
5606 * keyboard.h: Change prototypes to match the above.
5608 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5610 (current_minor_maps): Check for size calculation overflow.
5611 * keymap.h: Change prototypes to match the above.
5613 * lread.c (read1, init_obarray): Don't update size until alloc done.
5615 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5616 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5618 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5619 Now ptrdiff_t, not int.
5620 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5621 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5623 * process.c (Fnetwork_interface_list): Check for overflow
5624 in size calculation.
5626 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5628 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5629 overflow. Don't bother calling xmalloc when xrealloc will do.
5631 * search.c (Freplace_match): Check for size calculation overflow.
5632 (Fset_match_data): Don't assume list lengths fit in 'int'.
5634 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5635 for command line length. Do not attempt to address one before the
5636 beginning of an array, as that's not portable.
5638 * term.c (max_frame_lines): Remove; unused.
5639 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5641 (encode_terminal_code, calculate_costs): Check for size
5642 calculation overflow.
5643 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5644 table lengths and related sizes. Don't update size until alloc
5645 done. Redo calculations to avoid overflow.
5646 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5648 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5649 subtracting pointers.
5650 (gobble_line): Check for overflow more carefully. Don't update size
5653 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5654 Don't update size until alloc done.
5655 Redo size calculations to avoid overflow.
5656 Check for size calculation overflow.
5657 (main) [DEBUG]: Fix typo in invoking tparam1.
5659 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5660 Use ptrdiff_t, not int, for sizes.
5661 (store_mode_line_noprop_char): Don't update size until alloc done.
5663 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5664 Use ptrdiff_t, not int, for sizes.
5665 (Finternal_make_lisp_face, cache_face):
5666 Check for size calculation overflow.
5667 (cache_face): Treat size calculation overflows as if they were
5668 memory exhaustion (the usual treatment), rather than aborting.
5670 * xfns.c (x_encode_text, x_set_name_internal)
5671 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5672 sizes, since they can exceed INT_MAX in size. Check for size
5673 calculation overflow.
5675 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5676 (xg_select): Check for size calculation overflow.
5677 Don't update size until alloc done.
5679 * xrdb.c (get_environ_db): Don't assume path length fits in int,
5680 as sprintf is limited to int lengths.
5682 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5683 (X_LONG_MIN): New macros.
5684 Use them to make the following changes clearer.
5685 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5686 This change doesn't affect the value now, but it may help remind
5687 future maintainers not to raise the value too much later.
5688 (SELECTION_QUANTUM): Remove, replacing with ...
5689 (selection_quantum): ... new function, which avoids overflow.
5691 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5692 assumption that selection length fits in 'int'.
5693 (x_reply_selection_request, x_handle_selection_request)
5694 (x_get_window_property, receive_incremental_selection)
5695 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5696 (lisp_data_to_selection_data, clean_local_selection_data):
5697 Use ptrdiff_t, not int, to record length of selection.
5698 (x_reply_selection_request, x_get_window_property)
5699 (receive_incremental_selection, x_property_data_to_lisp):
5700 Redo calculations to avoid overflow.
5701 (x_reply_selection_request): When sending hint, ceiling it at
5702 X_LONG_MAX rather than relying on wraparound overflow to send
5704 (x_get_window_property, receive_incremental_selection)
5705 (lisp_data_to_selection_data, x_property_data_to_lisp):
5706 Check for size-calculation overflow.
5707 (x_get_window_property, receive_incremental_selection)
5708 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5709 Don't store size until memory allocation succeeds.
5710 (x_get_window_property): Plug memory leak on memory exhaustion.
5711 Don't double-block input; malloc is safe here. Don't assume 2**34
5712 - 4 fits in unsigned long. Add an xassert to check
5713 XGetWindowProperty overflow. Be more careful about overflow
5714 calculations, and distinguish size from memory overflow better.
5715 (receive_incremental_selection): When tracing, don't assume
5716 unsigned int is less than INT_MAX.
5717 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5718 harmful) conversions of unsigned short to int.
5719 (lisp_data_to_selection_data): Don't assume that integers
5720 in the range -65535 through -1 fit in an X unsigned short.
5721 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5722 result parameters unless successful. Rely on cons_to_unsigned
5723 to report problems with elements; the old code wasn't right anyway.
5724 (x_check_property_data): Check for int overflow; we cannot use
5725 a wider type due to X limits.
5726 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5728 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
5730 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5731 (x_term_init): Check for size calculation overflow.
5732 (x_color_cells): Don't store size until memory allocation succeeds.
5733 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
5734 Don't assume alloca size is less than MAX_ALLOCA.
5735 (x_term_init): Don't assume length fits in int (sprintf is limited
5738 Use ptrdiff_t for composition IDs.
5739 * character.c (lisp_string_width):
5740 * composite.c (composition_table_size, n_compositions)
5741 (get_composition_id, composition_gstring_from_id):
5742 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5743 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5744 * window.c (Frecenter):
5745 Use ptrdiff_t, not int, for composition IDs.
5746 * composite.c (get_composition_id): Check for integer overflow.
5747 * composite.h: Adjust prototypes to match the above changes.
5749 Use ptrdiff_t for hash table indexes.
5750 * category.c (hash_get_category_set):
5751 * ccl.c (ccl_driver):
5752 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5753 * coding.c (coding_system_charset_list, detect_coding_system):
5754 * coding.h (struct coding_system.id):
5755 * composite.c (get_composition_id, gstring_lookup_cache):
5756 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5757 * image.c (xpm_get_color_table_h):
5758 * lisp.h (hash_lookup, hash_put):
5759 * minibuf.c (Ftest_completion):
5760 Use ptrdiff_t for hash table indexes, not int (which is too
5761 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5762 32-bit --with-wide-int hosts).
5764 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5765 Add a FIXME comment about memory leaks.
5766 (syms_of_charset): Don't assume xmalloc returns.
5768 Don't assume that stated character widths fit in int.
5769 * character.c (Fchar_width, c_string_width, lisp_string_width):
5770 * character.h (CHAR_WIDTH):
5771 * indent.c (MULTIBYTE_BYTES_WIDTH):
5772 Use sanitize_char_width to avoid undefined and/or bad behavior
5773 with outlandish widths.
5774 * character.h (sanitize_tab_width): Rename from sanitize_width,
5775 now that we have two such functions. All uses changed.
5776 (sanitize_char_width): New inline function.
5778 Don't assume that tab-width fits in int.
5779 * character.h (sanitize_width): New inline function.
5780 (SANE_TAB_WIDTH): New macro.
5781 (ASCII_CHAR_WIDTH): Use it.
5782 * indent.c (sane_tab_width): Remove. All uses replaced by
5783 SANE_TAB_WIDTH (current_buffer).
5784 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5786 * fileio.c: Integer overflow issues with file modes.
5787 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5789 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5790 Remove unreachable code.
5791 (read_hex, load_charset_map_from_file): Check for integer overflow.
5793 * xterm.c: Don't go over XClientMessageEvent limit.
5794 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5795 (x_send_scroll_bar_event): Likewise. Check that the size does not
5796 exceed limits imposed by XClientMessageEvent, as well as the usual
5797 ptrdiff_t and size_t limits.
5799 * keyboard.c: Overflow, signedness and related fixes.
5800 (make_lispy_movement): Use same integer type in forward decl
5801 that is used in the definition.
5802 (read_key_sequence, keyremap_step):
5803 Change bufsize argument back to int, undoing my 2011-03-30 change.
5804 We prefer signed types, and int is wide enough here.
5805 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5806 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5807 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5808 length, not size_t. Use ptrdiff_t for index, not int.
5809 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5810 possibility of integer overflow.
5812 Overflow, signedness and related fixes for images.
5814 * dispextern.h (struct it.stack[0].u.image.image_id)
5815 (struct_it.image_id, struct image.id, struct image_cache.size)
5816 (struct image_cache.used, struct image_cache.ref_count):
5817 * gtkutil.c (update_frame_tool_bar):
5818 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5819 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5820 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5821 * nsmenu.m (update_frame_tool_bar):
5822 * xdisp.c (calc_pixel_width_or_height):
5823 * xfns.c (image_cache_refcount):
5824 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5825 on typical 64-bit hosts.
5827 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5828 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5829 Omit unnecessary casts to int.
5830 (parse_image_spec): Check that integers fall into 'int' range
5831 when the callers expect that.
5832 (image_ascent): Redo ascent calculation to avoid int overflow.
5833 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5834 (lookup_image): Remove unnecessary tests.
5835 (xbm_image_p): Locals are now of int, not EMACS_INT,
5836 since parse_image_check makes sure they fit into int.
5837 (png_load, gif_load, svg_load_image):
5838 Prefer int to unsigned where either will do.
5839 (tiff_handler): New function, combining the cores of the
5840 old tiff_error_handler and tiff_warning_handler.
5841 This function is rewritten to use vsnprintf and thereby avoid
5842 stack buffer overflows. It uses only the features of vsnprintf
5843 that are common to both POSIX and native Microsoft.
5844 (tiff_error_handler, tiff_warning_handler): Use it.
5845 (tiff_load, gif_load, imagemagick_load_image):
5846 Don't assume :index value fits in 'int'.
5847 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5848 (imagemagick_load_image): Check that crop parameters fit into
5849 the integer types that MagickCropImage accepts. Don't assume
5850 Vimagemagick_render_type has a nonnegative value. Don't assume
5851 size_t fits in 'long'.
5852 (gs_load): Use printmax_t to print the widest integers possible.
5853 Check for integer overflow when computing image height and width.
5855 2011-08-26 Eli Zaretskii <eliz@gnu.org>
5857 * xdisp.c (redisplay_window): Don't force window start if point
5858 will be invisible in the resulting window. (Bug#9324)
5860 2011-08-25 Eli Zaretskii <eliz@gnu.org>
5862 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5863 the display spec is of the form `(space ...)'.
5864 (handle_display_spec): Return the value returned by
5865 handle_single_display_spec, not just 1 or zero.
5866 (handle_single_display_spec): If the display spec is of the form
5867 `(space ...)', and specifies display in the text area, return 2
5869 (try_cursor_movement): Check for the need to scroll more
5870 accurately, and prefer exact match for point under bidi.
5871 Don't advance `row' beyond the last row of the window.
5873 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5874 into disp_prop; all users changed.
5876 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5877 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5878 for the text covered by the display property.
5880 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
5882 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5883 Change return value to nil.
5884 (Frecord_buffer): Delete unused function.
5886 2011-08-24 Eli Zaretskii <eliz@gnu.org>
5888 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5889 buffers, return left-to-right.
5890 (set_cursor_from_row): Consider candidate row a win if its glyph
5891 represents a newline and point is on that newline. Fixes cursor
5892 positioning on the newline at EOL of R2L text within L2R
5893 paragraph, and vice versa.
5894 (try_cursor_movement): Check continued rows, in addition to
5895 continuation rows. Fixes unwarranted scroll when point enters a
5896 continued line of R2L text within an L2R paragraph, or vice versa.
5897 (cursor_row_p): Consider the case of point being equal to
5898 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5899 from the end of a short line to the beginning of a continued line
5900 of R2L text within L2R paragraph.
5901 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5902 composed characters.
5904 * bidi.c (bidi_check_type): Use xassert.
5905 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5908 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5910 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5913 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
5915 * nsfont.m (ns_otf_to_script): Fix typo.
5917 2011-08-22 Kenichi Handa <handa@m17n.org>
5919 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5920 extra slot even if the purpose is char-code-property-table.
5922 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5924 * xdisp.c (redisplay_window): When computing centering_position,
5925 account for the height of the header line. (Bug#8874)
5927 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5928 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5929 candidate is selected by the mouse, and that candidate has a
5930 composed character under the mouse.
5932 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5933 coordinates reported by pos-visible-in-window-p for a composed
5934 character in column zero.
5936 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5938 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5940 2011-08-22 Eli Zaretskii <eliz@gnu.org>
5942 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5943 consider it a hit if to_charpos is anywhere in the range of the
5944 composed buffer positions.
5946 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
5948 * image.c (gif_load): Don't assume that each subimage has the same
5949 dimensions as the base image. Handle disposal method that is
5950 "undefined" by the gif spec (Bug#9335).
5952 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
5954 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
5955 (Fcondition_case): Document `debug' symbol in error handler.
5957 2011-08-19 Eli Zaretskii <eliz@gnu.org>
5959 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5960 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5961 from an Org mode buffer to a Speedbar frame.
5963 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5964 a composition, take its buffer position from IT->cmp_it.charpos.
5965 Fixes cursor positioning at the beginning of a line that begins
5966 with a composed character.
5968 2011-08-18 Eli Zaretskii <eliz@gnu.org>
5970 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5971 character bidirectional type, use STRONG_L instead. Fixes crashes
5972 in a buffer produced by `describe-categories'.
5974 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5975 members before the level stack, so they would be saved and
5976 restored when copying iterator state. Fixes incorrect reordering
5977 around TABs covered by display properties.
5979 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5981 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
5983 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
5985 * eval.c (internal_condition_case, internal_condition_case_1)
5986 (internal_condition_case_2, internal_condition_case_n):
5987 Remove unnecessary aborts (Bug#9081).
5989 2011-08-17 Eli Zaretskii <eliz@gnu.org>
5991 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5992 has no `load' handler, try opening the file locally. (Bug#9311)
5994 2011-08-16 Ken Brown <kbrown@cornell.edu>
5996 * gmalloc.c: Expand comment.
5998 2011-08-16 Eli Zaretskii <eliz@gnu.org>
6000 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6001 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6003 2011-08-16 Ken Brown <kbrown@cornell.edu>
6005 Fix memory allocation problems in Cygwin build (Bug#9273).
6007 * unexcw.c ( __malloc_initialized): Declare external variable.
6008 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6010 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6012 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6014 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6016 [CYGWIN] (special_realloc): New function.
6017 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6018 requests to realloc storage in the static heap.
6020 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6022 * bidi.c (bidi_initialize): Remove unused local.
6024 2011-08-15 Eli Zaretskii <eliz@gnu.org>
6027 * biditype.h: Remove file.
6028 * makefile.w32-in ($(BLD)/bidi.$(O)):
6029 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
6031 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6033 * chartab.c: Improve commentary for the uniprop_table API.
6035 * bidi.c (bidi_paragraph_init): Support zero value of
6036 bidi_ignore_explicit_marks_for_paragraph_level.
6037 (bidi_initialize): Use uniprop_table instead of including
6038 biditype.h and bidimirror.h.
6040 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6041 coordinates of the iterator when restoring from ppos_it.
6044 2011-08-14 Kenichi Handa <handa@m17n.org>
6046 * process.c (create_process): Call setup_process_coding_systems
6047 after the pid of the process is set to -1 (Bug#8162).
6049 2011-08-14 Eli Zaretskii <eliz@gnu.org>
6051 * xdisp.c (move_it_in_display_line_to): Don't invoke
6052 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6053 ppos_it. Fixes vertical cursor motion when line beginning is
6054 covered by an image. (Bug#9296)
6056 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6058 * nsterm.h (ns_run_ascript): Declare.
6059 (NSAPP_DATA2_RUNASSCRIPT): Define.
6061 * nsfns.m (as_script, as_result, as_status): New static variables.
6062 (ns_run_ascript): New function.
6063 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
6064 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6065 the event loop. Get status from as_status (Bug#7276).
6067 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6068 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6069 the event loop (Bug#7276).
6071 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6073 * gnutls.c (QCgnutls_bootprop_priority)
6074 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6075 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6076 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6077 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6078 (QCgnutls_bootprop_verify_hostname_error)
6079 (QCgnutls_bootprop_callbacks_verify): Rename from
6080 Qgnutls_bootprop_..., all uses changed.
6082 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6085 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6087 * xfaces.c (Qframe_set_background_mode): Now static.
6088 * dispextern.h (Qframe_set_background_mode): Remove decl.
6090 * process.c (Fnetwork_interface_info): Declare local only if needed.
6092 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6094 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6095 (Fnetwork_interface_list): Allocate in increments of bytes instead
6096 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6097 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6099 (struct ifflag_def): notrailers is smart on OSX.
6100 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6101 Get hardware address with getifaddrs if available.
6103 2011-08-12 Eli Zaretskii <eliz@gnu.org>
6105 * xdisp.c (iterate_out_of_display_property): xassert that
6106 IT->position is set to within IT->object's boundaries. Break from
6107 the loop as soon as EOB is reached; avoids infloops in redisplay
6108 when IT->position is set up wrongly due to some bug.
6109 Set IT->current to match the bidi iterator unconditionally.
6110 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6111 entry. Force push_it to save on the stack the current
6112 buffer/string position, to be restored by pop_it. Fix flags in
6113 the iterator structure wrt the object coming from a display
6114 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6115 properties. (Bug#9284)
6117 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
6119 * fontset.c (fontset_get_font_group): Add proper type checks.
6122 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6124 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6125 and LC_VERSION_MIN_MACOSX.
6126 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6127 (dump_it) [LC_FUNCTION_STARTS]: Use it.
6129 2011-08-08 Eli Zaretskii <eliz@gnu.org>
6131 * xdisp.c (forward_to_next_line_start): Allow to use the
6132 no-display-properties-and-no-overlays under bidi display.
6133 Set disp_pos in the bidi iterator to avoid searches for display
6134 properties and overlays.
6136 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
6138 * editfns.c (Fset_time_zone_rule): Document relationship with the
6141 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6142 the font entity extracted from the cache (Bug#8109).
6144 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
6146 * composite.c (autocmp_chars): Don't reset point. That is done by
6147 restore_point_unwind (Bug#5984).
6149 2011-08-07 Juri Linkov <juri@jurta.org>
6151 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6152 to show the arg `TIME' instead of `TIMEVAL'.
6154 2011-08-06 Eli Zaretskii <eliz@gnu.org>
6156 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6157 display property strides EOL and includes a newline, as in
6158 longlines-mode. (Bug#9254)
6159 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6160 word-wrap under bidirectional display. (Bug#9224)
6162 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6163 is non-zero, even if the data buffer is NULL. Fixes a crash in
6164 vertical-motion with longlines-mode. (Bug#9254)
6166 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6168 * bidi.c <bidi_cache_total_alloc>: Now static.
6169 (bidi_initialize): Initialize bidi_cache_total_alloc.
6171 * xdisp.c (display_line): Release buffer allocated for shelved bidi
6174 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6175 amount allocated this far in `bidi_cache_total_alloc'.
6176 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6177 non-zero, only free the data buffer without restoring the cache
6178 contents. All callers changed.
6180 * dispextern.h (bidi_unshelve_cache): Update prototype.
6182 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6183 (move_it_in_display_line, move_it_to)
6184 (move_it_vertically_backward, move_it_by_lines): Replace the call
6185 to xfree to an equivalent call to bidi_unshelve_cache.
6186 (move_it_in_display_line_to): Fix logic of returning
6187 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
6189 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6191 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6192 came from a string character with a `cursor' property. (Bug#9229)
6194 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6196 * Makefile.in (LIB_PTHREAD): New variable.
6197 (LIBES): Add LIB_PTHREAD (Bug#9216).
6199 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6200 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6202 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6204 * regex.c (re_iswctype): Remove some redundant boolean conversions.
6206 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6208 * xterm.c (x_find_topmost_parent): New function.
6209 (x_set_frame_alpha): Find topmost parent window with
6210 x_find_topmost_parent and set the property there also (bug#9181).
6211 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6213 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6215 * callproc.c (Fcall_process): Avoid vfork clobbering
6216 the local vars buffer, coding_systems, current_dir.
6218 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6220 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6222 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6224 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6225 so that it is not optimized away.
6227 * xdisp.c (compute_display_string_pos): Remove unused local.
6229 2011-08-02 Eli Zaretskii <eliz@gnu.org>
6231 Fix slow cursor motion and scrolling in large buffers with
6232 selective display, like Org Mode buffers. (Bug#9218)
6234 * dispextern.h (struct bidi_it): New member disp_prop_p.
6236 * xdisp.c: Remove one-slot cache of display string positions.
6237 (compute_display_string_pos): Accept an additional argument
6238 DISP_PROP_P; callers changed. Scan at most 5K characters forward
6239 for a display string or property. If found, set DISP_PROP_P
6242 * bidi.c (bidi_fetch_char): Accept an additional argument
6243 DISP_PROP_P, and pass it to compute_display_string_pos.
6244 Only handle text covered by a display string if DISP_PROP_P is returned
6245 non-zero. All callers of bidi_fetch_char changed.
6247 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6249 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6251 2010-12-03 Don March <don@ohspite.net>
6253 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6254 last character M-[char] is translated to ESC [char] (bug#7541).
6256 2011-08-02 Kenichi Handa <handa@m17n.org>
6258 * lisp.h (uniprop_table): Extern it.
6260 * chartab.c (uniprop_table): Make it non-static.
6262 2011-08-01 Eli Zaretskii <eliz@gnu.org>
6264 * xdisp.c (forward_to_next_line_start): Accept additional argument
6265 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6267 (reseat_at_next_visible_line_start): Use the bidi iterator state
6268 returned by forward_to_next_line_start to restore the state of
6269 it->bidi_it after backing up to previous newline. (Bug#9212)
6271 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6273 * regex.c (re_comp): Protoize.
6274 (re_exec): Fix return type.
6275 (regexec): Fix type of `ret'. (Bug#9203)
6277 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6279 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6280 This is needed if max-image-size is a floating-point number.
6282 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6284 * print.c (print_object): Print empty symbol as ##.
6286 * lread.c (read1): Read ## as empty symbol.
6288 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6290 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6291 setting frame foreground color (Bug#9175).
6292 (x_set_background_color): Likewise.
6294 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6295 contents (Bug#9176).
6296 (EmacsTooltip -init): Remove bezels and add shadows to
6299 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6300 or scroll bar (Bug#8470).
6302 * nsfont.m (nsfont_open): Remove assignment to voffset and
6303 unnecessary vars hshink, expand, hd, full_height, min_height.
6304 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6306 * nsterm.h (nsfont_info): Remove voffset field.
6308 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6310 Implement strike-through and overline on NextStep (Bug#8863).
6312 * nsfont.m (nsfont_open): Use underline position provided by font,
6313 instead of hard-coded value of 2.
6314 (nsfont_draw): Call ns_draw_text_decoration instead.
6316 * nsterm.h: Add declaration for ns_draw_text_decoration.
6318 * nsterm.m (ns_draw_text_decoration): New function for drawing
6319 underline, overline, and strike-through.
6320 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6321 ns_draw_text_decoration. Change treatment of cursor drawing to
6322 accommodate underlining, etc.
6324 2011-07-28 Eli Zaretskii <eliz@gnu.org>
6326 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6329 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6331 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6332 Without this fix, if a signal arrives just after memory fills up,
6333 'malloc' might be invoked reentrantly.
6335 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6336 In other words, assume that every image size is allowed, on non-X
6337 hosts. This assumption is probably wrong, but it lets Emacs compile.
6339 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6341 * regex.c (re_iswctype): Convert return values to boolean.
6343 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6345 * xdisp.c (compute_display_string_pos): Don't use cached display
6346 string position if the buffer had its restriction changed.
6349 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6351 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6353 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6355 Integer signedness and overflow and related fixes. (Bug#9079)
6357 * bidi.c: Integer size and overflow fixes.
6358 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6359 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6360 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6361 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6362 (bidi_find_other_level_edge):
6363 Use ptrdiff_t instead of EMACS_INT where either will do.
6364 This works better on 32-bit hosts configured --with-wide-int.
6365 (bidi_cache_ensure_space): Check for size-calculation overflow.
6366 Use % rather than repeated addition, for better worst-case speed.
6367 Don't set bidi_cache_size until after xrealloc returns, because it
6369 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
6370 (bidi_cache_ensure_space): Also check that the bidi cache size
6371 does not exceed that of the largest Lisp string or buffer. See Eli
6372 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
6374 * alloc.c (__malloc_size_t): Remove.
6375 All uses replaced by size_t. See Andreas Schwab's note
6376 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6378 * image.c: Improve checking for integer overflow.
6379 (check_image_size): Assume that f is nonnull, since
6380 it is always nonnull in practice. This is one less thing to
6381 worry about when checking for integer overflow later.
6382 (x_check_image_size): New function, which checks for integer
6383 overflow issues inside X.
6384 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6385 This removes the need for a memory_full check.
6386 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6387 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6388 (xbm_read_bitmap_data): Change locals back to 'int', since
6389 their values must fit in 'int'.
6390 (xpm_load_image, png_load, tiff_load):
6391 Invoke x_create_x_image_and_pixmap earlier,
6392 to avoid much needless work if the image is too large.
6393 (tiff_load): Treat overly large images as if
6394 x_create_x_image_and_pixmap failed, not as malloc failures.
6395 (gs_load): Use x_check_image_size.
6397 * gtkutil.c: Omit integer casts.
6398 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6399 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6401 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6403 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6404 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6405 would wrongly return t on a 64-bit host.
6407 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6408 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6409 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6410 and therefore cause GCC to emit a bogus diagnostic in some cases.
6412 * image.c: Integer signedness and overflow and related fixes.
6413 This is not an exhaustive set of fixes, but it's time to
6414 record what I've got.
6415 (lookup_pixel_color, check_image_size): Remove redundant decls.
6416 (check_image_size): Don't assume that arbitrary EMACS_INT values
6417 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6418 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6419 (tiff_load, imagemagick_load_image):
6420 Check for overflow in size calculations.
6421 (x_create_x_image_and_pixmap): Remove unnecessary test for
6422 xmalloc returning NULL; that can't happen.
6423 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6424 (xpm_color_bucket): Use better integer hashing function.
6425 (xpm_cache_color): Don't possibly over-allocate memory.
6426 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6427 (gif_memory_source):
6428 Use ptrdiff_t, not int or size_t, to record sizes.
6429 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6430 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6431 either works, as we prefer signed integers.
6432 (tiff_read_from_memory, tiff_write_from_memory):
6433 Return tsize_t, not size_t, since that's what the TIFF API wants.
6434 (tiff_read_from_memory): Don't fail simply because the read would
6435 go past EOF; instead, return a short read.
6436 (tiff_load): Omit no-longer-needed casts.
6437 (Fimagemagick_types): Don't assume size fits into 'int'.
6439 Improve hashing quality when configured --with-wide-int.
6440 * fns.c (hash_string): New function, taken from sxhash_string.
6441 Do not discard information about ASCII character case; this
6442 discarding is no longer needed.
6443 (sxhash-string): Use it. Change sig to match it. Caller changed.
6444 * lisp.h: Declare it.
6445 * lread.c (hash_string): Remove, since we now use fns.c's version.
6446 The fns.c version returns a wider integer if --with-wide-int is
6447 specified, so this should help the quality of the hashing a bit.
6449 * emacs.c: Integer overflow minor fix.
6450 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6451 Define only if GNU_LINUX.
6452 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6454 * dispnew.c: Integer signedness and overflow fixes.
6455 Remove unnecessary forward decls, that were a maintenance hassle.
6456 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6458 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6459 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6460 (prepare_desired_row, line_draw_cost):
6461 Use int, not unsigned, where either works.
6462 (save_current_matrix, restore_current_matrix):
6463 Use ptrdiff_t, not size_t, where either works.
6464 (init_display): Check for overflow more accurately, and without
6465 relying on undefined behavior.
6467 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6468 Remove, replacing with the new symbols in lisp.h. All uses changed.
6469 * fileio.c (make_temp_name):
6470 * filelock.c (lock_file_1, lock_file):
6471 * xdisp.c (message_dolog):
6472 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6473 Use pMd etc. instead.
6474 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6475 replacing the pWIDE etc. symbols removed from editfns.c.
6477 * keyboard.h (num_input_events): Now uintmax_t.
6478 This is (very slightly) less likely to mess up due to wraparound.
6481 * buffer.c: Integer signedness fixes.
6482 (alloc_buffer_text, enlarge_buffer_text):
6483 Use ptrdiff_t rather than size_t when either will do, as we prefer
6486 * alloc.c: Integer signedness and overflow fixes.
6487 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6488 (__malloc_size_t): Default to size_t, not to int.
6489 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6490 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6491 Prefer ptrdiff_t to size_t when either would do, as we prefer
6493 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6494 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6495 Now const. Initialize with values that are in range even if char
6497 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6498 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6499 These functions do the right thing with sizes > 2**32.
6500 (check_depth): Now ptrdiff_t, not int.
6501 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6502 Adjust to new way of storing sizes. Check for size overflow bugs
6504 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6505 slightly wrong anyway, as it missed one instance of
6506 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6507 (refill_memory_reserve): Omit needless cast to size_t.
6508 (mark_object_loop_halt): Mark as externally visible.
6510 * xselect.c: Integer signedness and overflow fixes.
6511 (Fx_register_dnd_atom, x_handle_dnd_message):
6512 Use ptrdiff_t, not size_t, since we prefer signed.
6513 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6514 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6515 x_dnd_atoms_size and x_dnd_atoms_length.
6517 * doprnt.c: Prefer signed to unsigned when either works.
6519 * doprnt.c (doprnt):
6521 * xdisp.c (vmessage):
6522 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6523 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6524 prefer signed arithmetic to avoid comparison confusion.
6525 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6526 but is a bit tricky.
6528 Assume freestanding C89 headers, string.h, stdlib.h.
6529 * data.c, doprnt.c, floatfns.c, print.c:
6530 Include float.h unconditionally.
6531 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6532 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6533 * regex.c: Likewise for stddef.h, string.h.
6534 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6535 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6536 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6537 (STDC_HEADERS): Remove obsolete defines.
6538 * sysdep.c: Include limits.h unconditionally.
6540 Assume support for memcmp, memcpy, memmove, memset.
6541 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6542 * regex.c (memcmp, memcpy):
6543 Remove; we assume C89 now.
6545 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6546 (__malloc_safe_bcopy): Remove; no longer needed.
6548 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6549 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6550 well either way, and we prefer signed to unsigned.
6552 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6554 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6555 closes the connection while we're reading (bug#9182).
6557 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
6559 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6560 are specified (Bug#9168).
6562 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6564 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6565 Found by GCC static checking and --with-wide-int on a 32-bit host.
6567 2011-07-25 Eli Zaretskii <eliz@gnu.org>
6569 * xdisp.c (compute_display_string_pos): Fix logic of caching
6570 previous display string position. Initialize cached_prev_pos to
6571 -1. Fixes slow-down at the beginning of a buffer.
6573 2011-07-24 Eli Zaretskii <eliz@gnu.org>
6575 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6576 for attrs[LFACE_FONTSET_INDEX].
6578 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6580 * xml.c (parse_region): Remove unused local
6581 that was recently introduced.
6583 2011-07-23 Eli Zaretskii <eliz@gnu.org>
6585 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6586 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6588 * xdisp.c (move_it_in_display_line_to): Record the best matching
6589 position for TO_CHARPOS while scanning the line, and restore it on
6590 exit if none of the characters scanned was an exact match.
6591 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
6592 when exact match is impossible due to invisible text, and the
6593 lines are truncated.
6595 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6597 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6600 2011-07-22 Eli Zaretskii <eliz@gnu.org>
6602 Fix a significant slow-down of cursor motion with C-n, C-p,
6603 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6604 auto-repeat under bidi redisplay in fontified buffers.
6605 * xdisp.c (compute_stop_pos_backwards): New function.
6606 (next_element_from_buffer): Call compute_stop_pos_backwards to
6607 find a suitable prev_stop when we find ourselves before
6609 (reseat): Don't look for prev_stop, as that could mean a very long
6611 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6612 <cached_disp_overlay_modiff>: Cache for last found display string
6614 (compute_display_string_pos): Return the cached position if asked
6615 about the same buffer in the same area of character positions, and
6616 the buffer wasn't changed since the time the display string
6617 position was cached.
6619 2011-07-22 Eli Zaretskii <eliz@gnu.org>
6621 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6622 is an integer, which is important for empty lines. (Bug#9149)
6624 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
6626 * frame.c (Fmodify_frame_parameters): In tty case, update the
6627 default face if necessary (Bug#4238).
6629 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
6631 * editfns.c (Fstring_to_char): No need to explain what a character
6632 is in the docstring (Bug#6576).
6634 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6636 * xml.c (parse_region): Make sure we always return a tree.
6638 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6640 * xml.c (parse_region): If a document contains only comments,
6643 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6645 * xml.c (make_dom): Return comments, too.
6647 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6650 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6651 and the surrounding thread.
6652 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6653 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6654 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6656 * s/openbsd.h (BROKEN_SIGIO): Define.
6657 * unexelf.c (unexec) [__OpenBSD__]:
6658 Don't update the .mdebug section of the Alpha COFF symbol table.
6660 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6662 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6665 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6667 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6668 This fixes some race conditions on the permissions of any newly
6671 * alloc.c (valid_pointer_p): Use pipe, not open.
6672 This fixes some permissions issues when debugging.
6674 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6675 If fchown fails to set both uid and gid, try to set just gid,
6676 as that is sometimes allowed. Adjust the file's mode to eliminate
6677 setuid or setgid bits that are inappropriate if fchown fails.
6679 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6681 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6682 to compare Lisp_Objects.
6683 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6684 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6685 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6687 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6689 * lread.c (read_integer): Unread even EOF character.
6690 (read1): Likewise. Properly record start position of symbol.
6692 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6693 symbol character follows.
6695 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6697 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6698 This works around a problem with the previous change to Fcopy_file.
6699 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6700 and without this change, GCC might complain about discarding
6701 fchown's return value.
6703 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
6705 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6707 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6709 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6711 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6713 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6714 it's used from the C level.
6716 * process.c: Use the same condition for POLL_FOR_INPUT in both
6717 keyboard.c and process.c (bug#1858).
6719 2011-07-09 Lawrence Mitchell <wence@gmx.li>
6721 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6722 (Fgnutls_boot): Use it.
6724 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6726 * doc.c (Fsubstitute_command_keys): Revert last change.
6728 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6730 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6731 quotes the next character, and doesn't affect other longer
6732 sequences (bug#8935).
6734 * lread.c (syms_of_lread): Clarify that is isn't only
6735 `eval-buffer' and `eval-defun' that's affected by
6736 `lexical-binding' (bug#8460).
6738 2011-07-15 Eli Zaretskii <eliz@gnu.org>
6740 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6741 bidi redisplay when a line includes both an image and is truncated.
6743 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6745 Fix minor problems found by static checking.
6746 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6747 (elsz): Now a signed constant, not a size_t var. We prefer signed
6748 types to unsigned, to avoid integer comparison confusion. Without
6749 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6750 "cannot optimize loop, the loop counter may overflow", a symptom
6752 * indent.c (Fvertical_motion): Mark locals as initialized.
6753 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6755 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6757 * search.c (Fre_search_backward): Mention `case-fold-search' in
6758 all the re_search_* functions (bug#8138).
6760 * keyboard.c (Fopen_dribble_file): Document when the file is
6763 2011-07-14 Eli Zaretskii <eliz@gnu.org>
6765 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6768 Support bidi reordering of display and overlay strings.
6769 * xdisp.c (compute_display_string_pos)
6770 (compute_display_string_end): Accept additional argument STRING.
6771 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6772 (reseat_to_string): Initialize bidi_it->string.s and
6773 bidi_it->string.schars.
6774 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
6775 NULL (avoids a crash in bidi_paragraph_init).
6776 Initialize itb.string.lstring.
6777 (init_iterator): Call bidi_init_it only of a valid
6778 buffer position was specified. Initialize paragraph_embedding to
6780 (reseat_to_string): Initialize the bidi iterator.
6781 (display_string): If we need to ignore text properties of
6782 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6783 original value of -1 will not work with bidi.)
6784 (compute_display_string_pos): First arg is now struct
6785 `text_pos *'; all callers changed. Support display properties on
6787 (compute_display_string_end): Support display properties on Lisp
6789 (init_iterator, reseat_1, reseat_to_string): Initialize the
6790 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6791 when iterating on a string not from display properties).
6792 (compute_display_string_pos, compute_display_string_end):
6793 Fix calculation of the object to scan. Fixes an error when using
6795 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
6796 base_level_stop; instead, set base_level_stop to BEGV.
6797 Fixes crashes in vertical-motion.
6798 (next_element_from_buffer): Improve commentary for when
6799 the iterator is before prev_stop.
6800 (init_iterator): Initialize bidi_p from the default value of
6801 bidi-display-reordering, not from buffer-local value. Use the
6802 buffer-local value only if initializing for buffer iteration.
6803 (handle_invisible_prop): Support invisible properties on strings
6804 that are being bidi-reordered.
6805 (set_iterator_to_next): Support bidi reordering of C strings and
6807 (next_element_from_string): Support bidi reordering of Lisp
6809 (handle_stop_backwards): Support Lisp strings as well.
6810 (display_string): Support display of R2L glyph rows.
6811 Use IT_STRING_CHARPOS when displaying from a Lisp string.
6812 (init_iterator): Don't initialize it->bidi_p for strings
6814 (reseat_to_string): Initialize it->bidi_p for strings here.
6815 (next_element_from_string, next_element_from_c_string)
6816 (next_element_from_buffer): Add xassert's for correspondence
6817 between IT's object being iterated and it->bidi_it.string
6819 (face_before_or_after_it_pos): Support bidi iteration.
6820 (next_element_from_c_string): Handle the case of the first string
6821 character that is not the first one in the visual order.
6822 (get_visually_first_element): New function, refactored from common
6823 parts of next_element_from_buffer, next_element_from_string, and
6824 next_element_from_c_string.
6825 (tool_bar_lines_needed, redisplay_tool_bar)
6826 (display_menu_bar): Force left-to-right direction. Add a FIXME
6827 comment for making that be controlled by a user option.
6828 (push_it, pop_it): Save and restore the state of the
6829 bidi iterator. Save and restore the bidi_p flag.
6830 (pop_it): Iterate out of display property for string iteration as
6832 (iterate_out_of_display_property): Support iteration over strings.
6833 (handle_single_display_spec): Set up it->bidi_it for iteration
6834 over a display string, and call bidi_init_it.
6835 (handle_single_display_spec, next_overlay_string)
6836 (get_overlay_strings_1, push_display_prop): Set up the bidi
6837 iterator for displaying display or overlay strings.
6838 (forward_to_next_line_start): Don't use the shortcut if
6840 (back_to_previous_visible_line_start): If handle_display_prop
6841 pushed the iterator stack, restore the internal state of the bidi
6842 iterator by calling bidi_pop_it same number of times.
6843 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6844 and we are bidi-iterating, don't decrement the iterator position;
6845 instead, set the first_elt flag in the bidi iterator, to produce
6847 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6848 (push_display_prop): xassert that we are iterating a buffer.
6849 (push_it, pop_it): Save and restore paragraph_embedding member.
6850 (handle_single_display_spec, next_overlay_string)
6851 (get_overlay_strings_1, reseat_1, reseat_to_string)
6852 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6853 correctly. Don't assume unibyte strings are not bidi-reordered.
6854 (compute_display_string_pos)
6855 (compute_display_string_end): Fix handling the case of C string.
6856 (push_it, pop_it): Save and restore from_disp_prop_p.
6857 (handle_single_display_spec, push_display_prop): Set the
6858 from_disp_prop_p flag.
6859 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6860 (pop_it): Call iterate_out_of_display_property only if we are
6861 popping after iteration over a string that came from a display
6862 property. Fix a typo in popping stretch info. Add an assertion
6863 for verifying that the iterator position is in sync with the bidi
6865 (handle_single_display_spec, get_overlay_strings_1)
6866 (push_display_prop): Fix initialization of paragraph direction for
6867 string when that of the parent object is not yet determined.
6868 (reseat_1): Call bidi_init_it to resync the bidi
6869 iterator with IT's position. (Bug#7616)
6870 (find_row_edges): If ROW->start.pos gives position
6871 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6872 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6873 Reset the from_disp_prop_p flag.
6874 (SAVE_IT, RESTORE_IT): New macros.
6875 (pos_visible_p, face_before_or_after_it_pos)
6876 (back_to_previous_visible_line_start)
6877 (move_it_in_display_line_to, move_it_in_display_line)
6878 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6879 (try_scrolling, redisplay_window, display_line): Use them when
6880 saving a temporary copy of the iterator and restoring it back.
6881 (back_to_previous_visible_line_start, reseat_1)
6882 (init_iterator): Empty the bidi cache "stack".
6883 (move_it_in_display_line_to): If iterator ended up at
6884 EOL, but we never saw any buffer positions smaller than
6885 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6886 motion in bidi-reordered lines.
6887 (move_it_in_display_line_to): Record prev_method and prev_pos
6888 immediately before the call to set_iterator_to_next. Fixes cursor
6889 motion in bidi-reordered lines with stretch glyphs and strings
6890 displayed in margins. (Bug#8133) (Bug#8867)
6891 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6893 (pos_visible_p): Support positions in bidi-reordered lines.
6894 Save and restore bidi cache.
6896 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6897 (bidi_paragraph_info): Delete unused struct.
6898 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6899 (bidi_cache_start): New variable.
6900 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6902 (bidi_cache_fetch_state, bidi_cache_search)
6903 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6904 (bidi_cache_find, bidi_peek_at_next_level)
6905 (bidi_level_of_next_char, bidi_find_other_level_edge)
6906 (bidi_move_to_visually_next): Compare cache index with
6907 bidi_cache_start rather than with zero.
6908 (bidi_fetch_char): Accept new argument STRING; all callers
6909 changed. Support iteration over a string. Support strings with
6910 display properties. Support unibyte strings. Fix the type of
6911 `len' according to what STRING_CHAR_AND_LENGTH expects.
6912 (bidi_paragraph_init, bidi_resolve_explicit_1)
6913 (bidi_resolve_explicit, bidi_resolve_weak)
6914 (bidi_level_of_next_char, bidi_move_to_visually_next):
6915 Support iteration over a string.
6916 (bidi_set_sor_type, bidi_resolve_explicit_1)
6917 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6918 can now be zero (for strings); special values 0 and -1 were
6919 changed to -1 and -2, respectively.
6920 (bidi_char_at_pos): New function.
6921 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6922 Call it instead of FETCH_MULTIBYTE_CHAR.
6923 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6924 initialized to valid values.
6925 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6927 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6928 the test for valid cached positions. Fix the logic for looking up
6929 the sentinel state in the cache. GCPRO the Lisp string we are
6931 (bidi_push_it, bidi_pop_it): New functions.
6932 (bidi_initialize): Initialize the bidi cache start stack pointer.
6933 (bidi_cache_ensure_space): New function, refactored from part of
6934 bidi_cache_iterator_state. Don't assume the required size is just
6935 one BIDI_CACHE_CHUNK away.
6936 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6937 (bidi_count_bytes, bidi_char_at_pos): New functions.
6938 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6939 always valid if bidi_cache_idx is valid.
6940 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6941 is valid if it's going to be used.
6942 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6943 (bidi_cache_fetch_state, bidi_cache_search)
6944 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6945 (bidi_cache_iterator_state, bidi_cache_find)
6946 (bidi_find_other_level_edge, bidi_cache_start_stack):
6947 All variables related to cache indices are now EMACS_INT.
6949 * dispextern.h (struct bidi_string_data): New structure.
6950 (struct bidi_it): New member `string'. Make flag members be 1-bit
6951 fields, and put them last in the struct.
6952 (compute_display_string_pos, compute_display_string_end):
6954 (bidi_push_it, bidi_pop_it): Add prototypes.
6955 (struct iterator_stack_entry): New members bidi_p,
6956 paragraph_embedding, and from_disp_prop_p.
6957 (struct it): Member bidi_p is now a bit field 1 bit wide.
6958 (bidi_shelve_cache, bidi_unshelve_cache):
6961 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6962 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6963 and vector-like objects.
6965 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6966 cache around display iteration.
6968 * window.c (Fwindow_end, window_scroll_pixel_based)
6969 (displayed_window_lines, Frecenter): Save and restore the bidi
6970 cache around display iteration.
6972 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6974 * editfns.c (Fdelete_region): Clarify the use of the named
6975 parameters (bug#6788).
6977 2011-07-14 Martin Rudalics <rudalics@gmx.at>
6979 * indent.c (Fvertical_motion): Set and restore w->pointm when
6980 saving and restoring the window's buffer (Bug#9006).
6982 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6984 * editfns.c (Fstring_to_char): Clarify just what is returned
6985 (bug#6576). Text by Eli Zaretskii.
6987 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
6989 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6991 2011-07-13 Eli Zaretskii <eliz@gnu.org>
6993 * buffer.c (mmap_find): Fix a typo.
6995 2011-07-13 Johan Bockgård <bojohan@gnu.org>
6997 Fix execution of x selection hooks.
6998 * xselect.c (Qx_lost_selection_functions)
6999 (Qx_sent_selection_functions): New vars.
7000 (syms_of_xselect): DEFSYM them.
7001 (x_handle_selection_request): Pass Qx_sent_selection_functions
7002 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7003 (x_handle_selection_clear,x_clear_frame_selections):
7004 Pass Qx_lost_selection_functions rather than
7005 Vx_lost_selection_functions to Frun_hook_with_args.
7007 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7009 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
7010 The old code sometimes used this field without initializing it.
7012 * alloc.c (gc_sweep): Don't read past end of array.
7013 In theory, the old code could also have corrupted Emacs internals,
7014 though it'd be very unlikely.
7016 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7018 * character.c (Fcharacterp): Don't advertise optional ignored
7019 argument. (Bug#4026)
7021 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7023 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7026 * window.c (Fset_window_start): Doc fix (bug#4199).
7027 (Fset_window_hscroll): Ditto.
7029 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7031 Fix minor new problems caught by GCC 4.6.1.
7032 * term.c (init_tty): Remove unused local.
7033 * xsettings.c (store_monospaced_changed): Define this function only
7034 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
7037 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
7039 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7041 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7043 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7044 are the mini-buffer and the echo area (bug#3320).
7046 * term.c (init_tty): Remove support for supdup, c10 and perq
7047 terminals, which are no longer supported (bug#1482).
7049 2011-07-10 Johan Bockgård <bojohan@gnu.org>
7051 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7053 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7055 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7056 for non-popups (Bug#3642).
7058 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7060 * alloc.c (reset_malloc_hooks): Protoize.
7061 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
7062 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7063 * cm.c (losecursor): Likewise.
7064 * data.c (fmod): Likewise.
7065 * dispnew.c (swap_glyphs_in_rows): Likewise.
7066 * emacs.c (memory_warning_signal): Likewise.
7067 * floatfns.c (float_error): Likewise.
7068 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7069 (otf_open, font_otf_capability, generate_otf_features)
7070 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7072 * image.c (pbm_read_file): Likewise.
7073 * indent.c (string_display_width): Likewise.
7074 * intervals.c (check_for_interval, search_for_interval)
7075 (inc_interval_count, count_intervals, root_interval)
7076 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7077 * lread.c (defalias): Likewise.
7078 * ralloc.c (r_alloc_check): Likewise.
7079 * regex.c (set_image_of_range_1, set_image_of_range)
7080 (regex_grow_registers): Likewise.
7081 * sysdep.c (strerror): Likewise.
7082 * termcap.c (valid_filename_p, tprint, main): Likewise.
7083 * tparam.c (main): Likewise.
7084 * unexhp9k800.c (run_time_remap, save_data_space)
7085 (update_file_ptrs, read_header, write_header, calculate_checksum)
7086 (copy_file, copy_rest, display_header): Likewise.
7087 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7089 * xdisp.c (check_it): Likewise.
7090 * xfaces.c (register_color, unregister_color, unregister_colors):
7092 * xfns.c (print_fontset_result): Likewise.
7093 * xrdb.c (member, fatal, main): Likewise.
7095 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7097 Fix minor problems found by static checking (Bug#9031).
7098 * chartab.c (char_table_set_range, map_sub_char_table):
7099 Remove unused locals.
7100 (uniprop_table): Now static.
7101 * composite.c (_work_char): Remove unused static var.
7103 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
7105 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7107 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7109 * gtkutil.c (qttip_cb): Remove code without function.
7111 2011-07-09 Eli Zaretskii <eliz@gnu.org>
7113 * w32.c (pthread_sigmask): New stub.
7115 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
7117 Use pthread_sigmask, not sigprocmask (Bug#9010).
7118 sigprocmask is portable only for single-threaded applications, and
7119 Emacs can be multi-threaded when it uses GTK.
7120 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7122 * callproc.c (Fcall_process):
7123 * process.c (create_process):
7124 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7125 Use pthread_sigmask, not sigprocmask.
7127 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7129 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7130 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7133 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7135 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7136 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7137 (xg_hide_tooltip): Fix comment.
7139 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7140 in registerServicesMenuSendTypes.
7141 (validRequestorForSendType): Don't check ns_return_types.
7143 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7146 2011-07-08 Jason Rumney <jasonr@gnu.org>
7148 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7149 SH_SHOW for hidden windows (Bug#5482).
7151 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7152 frame struct members of non-existent frames (Bug#6284).
7154 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7156 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7157 variable firstTime not needed on OSX >= 10.6.
7158 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7159 >= 10.5. Use setKnobProportion, setDoubleValue.
7161 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7162 (MAC_OS_X_VERSION_10_5): Define if not defined.
7163 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7164 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7165 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7167 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7168 cString and lossyCString on OSX >= 10.4
7170 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
7171 sizeToFit on OSX >= 10.2.
7173 * nsimage.m (allocInitFromFile): Don't use deprecated method
7174 bestRepresentationForDevice on OSX >= 10.6.
7176 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7179 * emacs.c: Declare unexec_init_emacs_zone.
7181 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7183 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7185 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7186 on svcsMenu (Bug#8842).
7188 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7190 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7192 * nsterm.m (QUTF8_STRING): Declare.
7193 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7194 (validRequestorForSendType): Return type is (id).
7195 Change indexOfObjectIdenticalTo to indexOfObject.
7196 Check if we have local selection before returning self (Bug#8842).
7197 (writeSelectionToPasteboard): Put local selection into paste board
7198 if we have a local selection (Bug#8842).
7199 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7201 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7202 (ns_get_local_selection): Declare.
7204 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7206 * keymap.c (describe_map_tree): Don't insert a double newline at
7207 the end of the buffer (bug#1169) and return whether we inserted
7210 * callint.c (Fcall_interactively): Change "reading args" to
7211 "providing args" to try to clarify what it does (bug#1010).
7213 2011-07-07 Kenichi Handa <handa@m17n.org>
7215 * composite.c (composition_compute_stop_pos): Ignore a static
7216 composition starting before CHARPOS (Bug#8915).
7218 * xdisp.c (handle_composition_prop): Likewise.
7220 2011-07-07 Eli Zaretskii <eliz@gnu.org>
7222 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7225 2011-07-07 Kenichi Handa <handa@m17n.org>
7227 * character.h (unicode_category_t): New enum type.
7229 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7230 (Qchar_code_property_table): New variable.
7231 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7232 (UNIPROP_COMPRESSED_FORM_P): New macros.
7233 (char_table_ascii): Uncompress the compressed values.
7234 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7235 Uncompress the compressed values.
7236 (sub_char_table_ref_and_range): Likewise.
7237 (char_table_ref_and_range): Uncompress the compressed values.
7238 (sub_char_table_set): New arg is_uniprop. Callers changed.
7239 Uncompress the compressed values.
7240 (sub_char_table_set_range): Args changed. Callers changed.
7241 (char_table_set_range): Adjuted for the above change.
7242 (map_sub_char_table): Delete args default_val and parent. Add arg
7243 top. Give decoded values to a Lisp function.
7244 (map_char_table): Adjust for the above change. Give decoded
7245 values to a Lisp function. Gcpro more variables.
7246 (uniprop_table_uncompress)
7247 (uniprop_decode_value_run_length): New functions.
7248 (uniprop_decoder, uniprop_decoder_count): New variables.
7249 (uniprop_get_decoder, uniprop_encode_value_character)
7250 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7252 (uniprop_encoder, uniprop_encoder_count): New variables.
7253 (uniprop_get_encoder, uniprop_table)
7254 (Funicode_property_table_internal, Fget_unicode_property_internal)
7255 (Fput_unicode_property_internal): New functions.
7256 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7257 Sunicode_property_table_internal, Sget_unicode_property_internal,
7258 and Sput_unicode_property_internal. Defvar_lisp
7259 char-code-property-alist.
7261 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
7262 Vunicode_category_table.
7264 * font.c (font_range): Adjust for the change of
7265 Vunicode_category_table.
7267 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7269 * m/iris4d.h: Remove file, move contents ...
7270 * s/irix6-5.h: ... here.
7272 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7274 Remove unportable assumption about struct layout (Bug#8884).
7275 * alloc.c (mark_buffer):
7276 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7277 (clone_per_buffer_values): Don't assume that
7278 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7279 This isn't true in general, and it's particularly not true
7280 if Emacs is configured with --with-wide-int.
7281 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7282 New macros, used in the buffer.c change.
7284 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7286 * xsettings.c: Use both GConf and GSettings if both are available.
7287 (store_config_changed_event): Add comment.
7288 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7289 (store_tool_bar_style_changed): New functions.
7290 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
7291 (struct xsettings): Move font inside HAVE_XFT.
7292 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
7293 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
7294 Move inside HAVE_XFT.
7295 (something_changed_gsettingsCB): Rename from something_changedCB.
7296 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7298 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
7299 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
7300 (something_changed_gconfCB): Rename from something_changedCB.
7301 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7302 (parse_settings): Move check for font inside HAVE_XFT.
7303 (read_settings, apply_xft_settings): Add comment.
7304 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7305 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7306 call store_font_name_changed.
7307 (xft_settings_event): Add comment.
7308 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7309 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7310 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7311 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7312 (xsettings_initialize): Call init_gsettings last.
7313 (xsettings_get_system_font, xsettings_get_system_normal_font):
7316 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7318 Random fixes. E.g., (random) never returned negative values.
7319 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7320 subseconds part to the entropy, as that's a bit more random.
7321 Prefer signed to unsigned, since the signedness doesn't matter and
7322 in general we prefer signed. When given a limit, use a
7323 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7324 latter isn't right if USE_2_TAGS_FOR_INTS.
7325 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7326 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7328 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7330 * textprop.c (text_property_stickiness):
7331 Obey Vtext_property_default_nonsticky.
7332 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7333 * w32fns.c (syms_of_w32fns):
7334 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7336 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7338 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7339 This is more efficient than Ffile_directory_p and avoids a minor race.
7341 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7343 * buffer.c (Foverlay_put): Say what the return value is
7346 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7347 is a directory before asking whether to use the file name
7349 (barf_or_query_if_file_exists): Make the "File is a directory"
7350 error be more correct.
7352 * fns.c (Frequire): Remove the mention of the .gz files, since
7353 that's installation-specific, but keep the mention of
7354 `get-load-suffixes'.
7356 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7358 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7359 Report string overflow if the output is too long.
7361 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
7363 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7364 (syms_of_gnutls): Remove duplicate DEFSYM for
7365 Qgnutls_bootprop_verify_hostname_error, an error for
7366 Qgnutls_bootprop_verify_error (which is no longer used).
7368 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7369 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7370 Also (re)move comments that are misplaced or no longer relevant.
7372 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7374 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7376 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
7378 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7379 and background color parameters if they have been changed.
7381 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7383 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7385 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7387 * xsettings.c (SYSTEM_FONT): Define only when used.
7388 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7390 * keymap.c (access_keymap_1): Now static.
7392 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
7394 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7395 leave any prefix arg for the up event (Bug#1586).
7397 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7399 * lread.c (syms_of_lread): Mention single symbols defined by
7400 `defvar' or `defconst' (bug#7154).
7402 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7403 (Frequire): Mention get-load-suffixes.
7405 2011-07-02 Martin Rudalics <rudalics@gmx.at>
7407 * window.h (window): Remove clone_number slot.
7408 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7410 (make_parent_window, make_window, saved_window)
7411 (Fset_window_configuration, save_window_save): Don't deal with
7413 * buffer.c (Qclone_number): Remove declaration.
7414 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7416 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7418 Add multiple inheritance to keymaps.
7419 * keymap.c (Fmake_composed_keymap): New function.
7420 (Fset_keymap_parent): Simplify.
7421 (fix_submap_inheritance): Remove.
7422 (access_keymap_1): New function extracted from access_keymap to handle
7423 embedded parents and handle lists of maps.
7424 (access_keymap): Use it.
7425 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7426 (Fcopy_keymap): Handle embedded parents.
7427 (Fcommand_remapping, define_as_prefix): Simplify.
7428 (Fkey_binding): Simplify.
7429 (syms_of_keymap): Move minibuffer-local-completion-map,
7430 minibuffer-local-filename-completion-map,
7431 minibuffer-local-must-match-map, and
7432 minibuffer-local-filename-must-match-map to Elisp.
7433 (syms_of_keymap): Defsubr make-composed-keymap.
7434 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7435 (parse_menu_item): Trivial simplification.
7437 2011-07-01 Glenn Morris <rgm@gnu.org>
7439 * Makefile.in (SETTINGS_LIBS): Fix typo.
7441 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7443 * coding.c (Fencode_coding_string): Record the last coding system
7444 used, as the function doc string says (bug#8738).
7446 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7448 * xsettings.c (store_monospaced_changed): Take new font as arg and
7449 check for change against current_mono_font.
7450 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7451 (emacs_settings_constructor, emacs_settings_get_property)
7452 (emacs_settings_set_property, emacs_settings_class_init)
7453 (emacs_settings_init, gsettings_obj): Remove.
7454 (something_changedCB): New function for HAVE_GSETTINGS.
7455 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7456 with value as argument.
7457 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7458 g_settings_new (Bug#8967). Do not create gsettings_obj.
7459 Remove calls to g_settings_bind. Connect something_changedCB to
7462 * xgselect.c: Add defined (HAVE_GSETTINGS).
7463 (xgselect_initialize): Ditto.
7465 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7466 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7469 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7471 * eval.c (struct backtrace): Simplify and port the data structure.
7472 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7473 signed bit field, as this assumption is not portable and it makes
7474 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7475 "char debug_on_exit : 1" as this is not portable either; instead,
7476 use the portable "unsigned int debug_on_exit : 1". Remove unused
7477 member evalargs. Remove obsolete comments about cc bombing out.
7479 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7481 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
7482 Let HAVE_GSETTINGS override HAVE_GCONF.
7483 (store_monospaced_changed): New function.
7484 (EMACS_SETTINGS): A new type derived from GObject to handle
7485 GSettings notifications.
7486 (emacs_settings_constructor, emacs_settings_get_property)
7487 (emacs_settings_set_property, emacs_settings_class_init):
7489 (gsettings_client, gsettings_obj): New variables.
7490 (GSETTINGS_SCHEMA): New define.
7491 (something_changedCB): Call store_monospaced_changed.
7492 (init_gsettings): New function.
7493 (xsettings_initialize): Call init_gsettings.
7494 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7497 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
7500 2011-06-29 Martin Rudalics <rudalics@gmx.at>
7502 * window.c (resize_root_window, grow_mini_window)
7503 (shrink_mini_window): Rename Qresize_root_window to
7504 Qwindow_resize_root_window and Qresize_root_window_vertically to
7505 Qwindow_resize_root_window_vertically.
7507 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7509 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7511 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
7513 * makefile.w32-in: Redesign dependencies so they reflect more
7514 clearly which files are directly included by each source file,
7515 and not through other includes.
7517 2011-06-27 Martin Rudalics <rudalics@gmx.at>
7519 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7520 (sort_overlays, overlay_strings): When an overlay's clone number
7521 matches the window's clone number process the overlay even if
7522 the overlay's window property doesn't match the current window.
7524 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7525 (Fwindow_hchild): Rename to Fwindow_left_child.
7526 (Fwindow_next): Rename to Fwindow_next_sibling.
7527 (Fwindow_prev): Rename to Fwindow_prev_sibling.
7528 (resize_window_check): Rename to window_resize_check.
7529 (resize_window_apply): Rename to window_resize_apply.
7530 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7531 (Fdelete_other_windows_internal, resize_frame_windows)
7532 (Fsplit_window_internal, Fdelete_window_internal)
7533 (grow_mini_window, shrink_mini_window)
7534 (Fresize_mini_window_internal): Fix callers accordingly.
7536 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7538 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7539 (emacs_fixed_set_min_size): Remove.
7540 (emacs_fixed_new): Take frame as argument.
7542 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7543 (_EmacsFixedPrivate): Remove minwidth/height.
7544 Add struct frame *f.
7545 (emacs_fixed_init): Initialize priv->f.
7546 (get_parent_class, emacs_fixed_set_min_size): Remove.
7547 (emacs_fixed_new): Set priv->f to argument.
7548 (emacs_fixed_get_preferred_width)
7549 (emacs_fixed_get_preferred_height): Use min_width/height from
7550 frames size_hint to set minimum and natural (Bug#8919).
7551 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7552 and use min_width/height from frames size_hint to set
7553 min_width/height (Bug#8919).
7555 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
7556 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7559 2011-06-26 Eli Zaretskii <eliz@gnu.org>
7561 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7562 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7565 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
7567 * process.c (wait_reading_process_output): Bypass select if
7568 waiting for a cell while ignoring keyboard input, and input is
7569 pending. Suggested by Jan Djärv (Bug#8869).
7571 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7573 Use gnulib's dup2 module instead of rolling our own.
7574 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7576 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7578 * dispnew.c (scrolling_window): Before scrolling, turn off a
7579 mouse-highlight in the window being scrolled.
7581 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
7583 Move DEFSYM to lisp.h and use everywhere.
7585 * character.h (DEFSYM): Move declaration...
7586 * lisp.h (DEFSYM): ...here.
7592 * w32select.c: Don't include character.h.
7594 * alloc.c (syms_of_alloc):
7595 * buffer.c (syms_of_buffer):
7596 * bytecode.c (syms_of_bytecode):
7597 * callint.c (syms_of_callint):
7598 * casefiddle.c (syms_of_casefiddle):
7599 * casetab.c (init_casetab_once):
7600 * category.c (init_category_once, syms_of_category):
7601 * ccl.c (syms_of_ccl):
7602 * cmds.c (syms_of_cmds):
7603 * composite.c (syms_of_composite):
7604 * dbusbind.c (syms_of_dbusbind):
7605 * dired.c (syms_of_dired):
7606 * dispnew.c (syms_of_display):
7607 * doc.c (syms_of_doc):
7608 * editfns.c (syms_of_editfns):
7609 * emacs.c (syms_of_emacs):
7610 * eval.c (syms_of_eval):
7611 * fileio.c (syms_of_fileio):
7612 * fns.c (syms_of_fns):
7613 * frame.c (syms_of_frame):
7614 * fringe.c (syms_of_fringe):
7615 * insdel.c (syms_of_insdel):
7616 * keymap.c (syms_of_keymap):
7617 * lread.c (init_obarray, syms_of_lread):
7618 * macros.c (syms_of_macros):
7619 * msdos.c (syms_of_msdos):
7620 * print.c (syms_of_print):
7621 * process.c (syms_of_process):
7622 * search.c (syms_of_search):
7623 * sound.c (syms_of_sound):
7624 * syntax.c (init_syntax_once, syms_of_syntax):
7625 * terminal.c (syms_of_terminal):
7626 * textprop.c (syms_of_textprop):
7627 * undo.c (syms_of_undo):
7628 * w32.c (globals_of_w32):
7629 * window.c (syms_of_window):
7630 * xdisp.c (syms_of_xdisp):
7631 * xfaces.c (syms_of_xfaces):
7632 * xfns.c (syms_of_xfns):
7633 * xmenu.c (syms_of_xmenu):
7634 * xsettings.c (syms_of_xsettings):
7635 * xterm.c (syms_of_xterm): Use DEFSYM.
7637 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7639 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
7641 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7643 Integer and buffer overflow fixes (Bug#8873).
7645 * print.c (printchar, strout): Check for string overflow.
7646 (PRINTPREPARE, printchar, strout):
7647 Don't set size unless allocation succeeds.
7649 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7650 for sizes. Check for string overflow more accurately.
7651 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7653 * macros.c: Integer and buffer overflow fixes.
7654 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7655 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7656 Use ptrdiff_t, not int, for sizes.
7657 Don't increment bufsize until after realloc succeeds.
7658 Check for size-calculation overflow.
7659 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7661 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7663 * lread.c: Integer overflow fixes.
7664 (read_integer): Radix is now EMACS_INT, not int,
7665 to improve quality of diagnostics for out-of-range radices.
7666 Calculate buffer size correctly for out-of-range radices.
7667 (read1): Check for integer overflow in radices, and in
7668 read-circle numbers.
7669 (read_escape): Avoid int overflow.
7670 (Fload, openp, read_buffer_size, read1)
7671 (substitute_object_recurse, read_vector, read_list, map_obarray):
7672 Use ptrdiff_t, not int, for sizes.
7673 (read1): Use EMACS_INT, not int, for sizes.
7674 Check for size overflow.
7676 * image.c (cache_image): Check for size arithmetic overflow.
7678 * lread.c: Integer overflow issues.
7679 (saved_doc_string_size, saved_doc_string_length)
7680 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7681 Now ptrdiff_t, not int.
7682 (read1): Don't assume doc string length fits in int. Check for
7683 out-of-range doc string lengths.
7684 (read_list): Don't assume file position fits in int.
7685 (read_escape): Check for hex character overflow.
7687 2011-06-22 Leo Liu <sdl.web@gmail.com>
7689 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7690 Move to minibuffer.el.
7692 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7694 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
7695 The following patches are for when GLYPH_DEBUG && !XASSERT.
7696 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7697 * dispnew.c (flush_stdout):
7698 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7699 Mark as externally visible.
7700 * dispnew.c (check_window_matrix_pointers): Now static.
7701 * dispnew.c (window_to_frame_vpos):
7702 * xfns.c (unwind_create_frame):
7703 * xterm.c (x_check_font): Remove unused local.
7704 * scroll.c (CHECK_BOUNDS):
7705 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7706 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7707 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7708 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7709 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7711 (debug_method_add): Use va_list and vsprintf rather than relying
7712 on undefined behavior with wrong number of arguments.
7713 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7714 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7715 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7716 since we're not interested in debugging glyphs with old libraries.
7717 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7718 GCC 4.6.0's static checking.
7720 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7722 Integer overflow and signedness fixes (Bug#8873).
7723 A few related buffer overrun fixes, too.
7725 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7727 * dispextern.h (struct face.stipple):
7728 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7729 (x_bitmap_mask, x_allocate_bitmap_record)
7730 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7731 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7732 (x_create_bitmap_from_xpm_data):
7733 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7734 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7736 * xfaces.c (load_pixmap):
7737 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7738 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7739 (.bitmaps_last, struct x_output.icon_bitmap):
7740 Use ptrdiff_t, not int, for bitmap indexes.
7741 (x_allocate_bitmap_record): Check for size overflow.
7742 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7744 Use ptrdiff_t, not int, for overlay counts.
7745 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7746 * editfns.c (overlays_around, get_pos_property):
7747 * textprop.c (get_char_property_and_overlay):
7748 * xdisp.c (next_overlay_change, note_mouse_highlight):
7749 * xfaces.c (face_at_buffer_position):
7750 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7751 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7752 (Fnext_overlay_change, Fprevious_overlay_change)
7753 (mouse_face_overlay_overlaps, Foverlays_in):
7754 Use ptrdiff_t, not int, for sizes.
7755 (overlays_at, overlays_in): Check for size-calculation overflow.
7757 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7759 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7760 (x_session_initialize): Do not assume string length fits in int.
7762 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7763 This is unlikely, but can occur if DPI is outlandish.
7765 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
7766 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7768 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7769 * xrdb.c (magic_file_p, search_magic_path):
7770 Omit last arg SUFFIX; it was always 0. All callers changed.
7771 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7773 * xfont.c (xfont_match): Avoid need for strlen.
7775 * xfns.c: Don't assume strlen fits in int.
7776 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7778 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7779 not unsigned long, as we prefer signed integers. All callers changed.
7780 Detect integer overflow in repeat count.
7781 (message_dolog): Don't assume print length fits in 39 bytes.
7782 (display_mode_element): Don't assume strlen fits in int.
7784 * termcap.c: Don't assume sizes fit in int and never overflow.
7785 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7786 (gobble_line): Check for size-calculation overflow.
7788 * minibuf.c (Fread_buffer):
7789 * lread.c (intern, intern_c_string):
7790 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7791 Don't assume string length fits in int.
7793 * keyboard.c (parse_tool_bar_item):
7794 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7796 * font.c: Don't assume string length fits in int.
7797 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7798 Use ptrdiff_t, not int.
7799 (font_intern_prop): Don't assume string length fits in int.
7800 Don't assume integer property fits in fixnum.
7801 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
7803 * filelock.c: Fix some buffer overrun and integer overflow issues.
7804 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
7805 Reformulate so as not to need the command string.
7806 Invoke gzip -cd rather than gunzip, as it's more portable.
7807 (lock_info_type, lock_file_1, lock_file):
7808 Don't assume pid_t and time_t fit in unsigned long.
7809 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7810 (current_lock_owner): Prefer signed type for sizes.
7811 Use memcpy, not strncpy, where memcpy is what is really wanted.
7812 Don't assume (via atoi) that time_t and pid_t fit in int.
7813 Check for time_t and/or pid_t out of range, e.g., via a network share.
7814 Don't alloca where an auto var works fine.
7816 * fileio.c: Fix some integer overflow issues.
7817 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7818 Don't assume string length fits in int.
7819 (directory_file_name): Don't assume string length fits in long.
7820 (make_temp_name): Don't assume pid fits in int, or that its print
7821 length is less than 20.
7823 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7825 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7827 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7829 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7830 We prefer signed integers, even for size calculations.
7832 * emacs.c: Don't assume string length fits in 'int'.
7833 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7834 (main): Don't invoke strlen when not needed.
7836 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7837 (XD_DEBUG_MESSAGE): Don't waste a byte.
7839 * callproc.c (getenv_internal_1, getenv_internal)
7841 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7843 * lread.c (invalid_syntax): Omit length argument.
7844 All uses changed. This doesn't fix a bug, but it simplifies the
7845 code away from its former Hollerith-constant appearance, and it's
7846 one less 'int' to worry about when looking at integer-overflow issues.
7847 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
7849 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7850 This didn't break anything, but it didn't help either.
7851 It's confusing to put a bogus integer in a place where the actual
7852 value does not matter.
7853 (LIST_END_P): Remove unused macro and its bogus comment.
7854 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
7856 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7857 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7859 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7860 We prefer signed types, and the value cannot exceed the EMACS_INT
7861 range anyway (because otherwise the length would not be representable).
7862 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7863 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7864 This avoids a GCC warning when WIDE_EMACS_INT.
7866 * indent.c (sane_tab_width): New function.
7867 (current_column, scan_for_column, Findent_to, position_indentation)
7868 (compute_motion): Use it. This is just for clarity.
7869 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
7871 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
7873 * lisp.h (lint_assume): New macro.
7874 * composite.c (composition_gstring_put_cache):
7875 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7877 * editfns.c, insdel.c:
7878 Omit unnecessary forward decls, to simplify future changes.
7880 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7882 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7884 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
7885 Use much-faster test for byte-length change.
7886 Don't assume string byte-length fits in 'int'.
7887 Check that character arg fits in 'int'.
7888 (mapcar1): Declare byte as byte, for clarity.
7890 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7892 * fns.c (concat): Catch string overflow earlier.
7893 Do not rely on integer wraparound.
7895 * dispextern.h (struct it.overlay_strings_charpos)
7896 (struct it.selective): Now EMACS_INT, not int.
7897 * xdisp.c (forward_to_next_line_start)
7898 (back_to_previous_visible_line_start)
7899 (reseat_at_next_visible_line_start, next_element_from_buffer):
7900 Don't arbitrarily truncate the value of 'selective' to int.
7902 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7904 * composite.c: Don't truncate sizes to 'int'.
7905 (composition_gstring_p, composition_reseat_it)
7906 (composition_adjust_point): Use EMACS_INT, not int.
7907 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7908 not EMACS_UINT, for indexes.
7910 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7912 * buffer.c: Include <verify.h>.
7913 (struct sortvec.priority, struct sortstr.priority):
7914 Now EMACS_INT, not int.
7915 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
7916 (struct sortstr.size, record_overlay_string)
7917 (struct sortstrlist.size, struct sortlist.used):
7918 Don't truncate size to int.
7919 (record_overlay_string): Check for size-calculation overflow.
7920 (init_buffer_once): Check at compile-time, not run-time.
7922 2011-06-22 Jim Meyering <meyering@redhat.com>
7924 Don't leak an XBM-image-sized buffer
7925 * image.c (xbm_load): Free the image buffer after using it.
7927 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7930 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7931 that Sun C diagnosed.
7932 * fns.c (secure_hash): Fix pointer signedness issue.
7933 * intervals.c (static_offset_intervals): New function.
7934 (offset_intervals): Use it.
7936 2011-06-21 Leo Liu <sdl.web@gmail.com>
7939 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7942 * fns.c (secure_hash): Rename from crypto_hash_function and change
7943 the first arg to accept symbols.
7944 (Fsecure_hash): New primitive.
7945 (syms_of_fns): New symbols.
7947 2011-06-20 Deniz Dogan <deniz@dogan.se>
7949 * process.c (Fset_process_buffer): Clarify return value in
7952 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
7954 * dispnew.c (add_window_display_history): Use BVAR.
7956 * xdisp.c (debug_method_add): Use BVAR.
7957 (check_window_end, dump_glyph_matrix, dump_glyph)
7958 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7960 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7963 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7964 check till after the cache is created in init_frame_faces.
7966 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7968 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7970 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7972 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7973 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7974 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7976 Improve buffer-overflow checking (Bug#8873).
7977 * fileio.c (Finsert_file_contents):
7978 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7979 Remove the old (too-loose) buffer overflow checks.
7980 They weren't needed, since make_gap checks for buffer overflow.
7981 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7982 The old code merely checked for Emacs fixnum overflow, and relied
7983 on undefined (wraparound) behavior. The new code avoids undefined
7984 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7986 * editfns.c (Finsert_char): Don't dump core with very negative counts.
7987 Tune. Don't use wider integers than needed. Don't use alloca.
7988 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
7990 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7992 * insdel.c, lisp.h (buffer_overflow): New function.
7993 (insert_from_buffer_1, replace_range, replace_range_2):
7994 * insdel.c (make_gap_larger):
7995 * editfns.c (Finsert_char):
7996 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7998 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8000 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8002 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
8004 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8005 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8007 * fileio.c: Don't assume EMACS_INT fits in off_t.
8008 (emacs_lseek): New static function.
8009 (Finsert_file_contents, Fwrite_region): Use it.
8010 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8012 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8014 * fns.c: Don't overflow int when computing a list length.
8015 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8016 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8017 truncation on 64-bit hosts. Check for QUIT every
8018 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8019 faster and is responsive enough.
8020 (Flength): Report an error instead of overflowing an integer.
8021 (Fsafe_length): Return a float if the value is not representable
8022 as a fixnum. This shouldn't happen except in contrived situations.
8023 (Fnthcdr, Fsort): Don't assume list length fits in int.
8024 (Fcopy_sequence): Don't assume vector length fits in int.
8026 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8027 (header_size, word_size): New constants.
8028 (allocate_vectorlike): Don't check size overflow here.
8029 (allocate_vector): Check it here instead, since this is the only
8030 caller of allocate_vectorlike that could cause overflow.
8031 Check that the new vector's length is representable as a fixnum.
8033 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8034 The previous code was bogus. For example, next_almost_prime (32)
8035 returned 39, which is undesirable as it is a multiple of 3; and
8036 next_almost_prime (24) returned 25, which is a multiple of 5 so
8037 why was the code bothering to check for multiples of 7?
8039 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8041 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8043 Variadic C functions now count arguments with ptrdiff_t.
8044 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8045 Back then I didn't know that the Emacs coding style prefers signed int.
8046 Also, in the meantime I found a few more instances where arguments
8047 were being counted with int, which may truncate counts on 64-bit
8048 machines, or EMACS_INT, which may be unnecessarily wide.
8049 * lisp.h (struct Lisp_Subr.function.aMANY)
8050 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8051 Arg counts are now ptrdiff_t, not size_t.
8052 All variadic functions and their callers changed accordingly.
8053 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8054 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8055 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8056 * callint.c (Fcall_interactively): Check arg count for overflow,
8057 to avoid potential buffer overrun. Use signed char, not 'int',
8058 for 'varies' array, so that we needn't bother to check its size
8059 calculation for overflow.
8060 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8061 * eval.c (apply_lambda):
8062 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8063 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8064 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8066 * callint.c (Fcall_interactively): Don't use index var as event count.
8068 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8069 * mem-limits.h (SIZE): Remove; no longer used.
8071 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
8073 Remove unnecessary casts.
8074 * xterm.c (x_term_init):
8075 * xfns.c (x_set_border_pixel):
8076 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8077 These aren't needed now that we assume ANSI C.
8079 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8080 It's more likely to cause problems (due to unsigned overflow)
8083 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8085 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8087 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8089 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8091 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8093 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8095 GLYPH_CODE_FACE returns EMACS_INT, not int.
8096 * dispextern.h (merge_faces):
8097 * xfaces.c (merge_faces):
8098 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8099 Don't assume EMACS_INT fits in int.
8101 * character.h (CHAR_VALID_P): Remove unused parameter.
8102 * fontset.c, lisp.h, xdisp.c: All uses changed.
8104 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8106 * fns.c (concat): Minor tuning based on overflow analysis.
8107 This doesn't fix any bugs. Use int to hold character, instead
8108 of constantly refetching from Emacs object. Use XFASTINT, not
8109 XINT, for value known to be a character. Don't bother comparing
8110 a single byte to 0400, as it's always less.
8112 * floatfns.c (Fexpt):
8113 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8115 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8118 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8120 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8121 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8122 incorrectly succeed when S was a string, because 4294967386 was
8123 truncated before it was used.
8125 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8126 Otherwise, an out-of-range integer could cause undefined behavior
8129 * composite.c: Use int, not EMACS_INT, for characters.
8130 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8131 EMACS_INT, for values that are known to be in character range.
8132 This doesn't fix any bugs but is the usual style inside Emacs and
8133 may generate better code on 32-bit machines.
8135 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8136 This is for reasons similar to the recent CHAR_STRING fix.
8137 * charset.c (Fencode_char): Check that character arg is actually
8138 a character. Pass an int to ENCODE_CHAR.
8139 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8140 wider than 'int', as a compile-time check to prevent future regressions
8143 * character.c (char_string): Remove unnecessary casts.
8145 Make sure a 64-bit char is never passed to CHAR_STRING.
8146 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8147 by silently ignoring the top 32 bits, allowing some values
8148 that were far too large to be valid characters.
8149 * character.h: Include <verify.h>.
8150 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8151 arguments are no wider than unsigned, as a compile-time check
8152 to prevent future regressions in this area.
8154 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
8155 (Fsubst_char_in_region):
8157 * xdisp.c (decode_mode_spec_coding):
8158 Adjust to CHAR_STRING's new requirement.
8159 * editfns.c (Finsert_char, Fsubst_char_in_region):
8160 * fns.c (concat): Check that character args are actually
8161 characters. Without this test, these functions did the wrong
8162 thing with wildly out-of-range values on 64-bit hosts.
8164 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8165 These casts should not be needed on 32-bit hosts, either.
8166 * keyboard.c (read_char):
8167 * lread.c (Fload): Remove casts to unsigned.
8169 * lisp.h (UNSIGNED_CMP): New macro.
8170 This fixes comparison bugs on 64-bit hosts.
8171 (ASCII_CHAR_P): Use it.
8172 * casefiddle.c (casify_object):
8173 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
8174 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8175 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8176 * dispextern.h (FACE_FROM_ID):
8177 * keyboard.c (read_char): Use UNSIGNED_CMP.
8179 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8180 not to EMACS_INT, to avoid GCC warning.
8182 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8184 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8185 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8186 isn't needed on 32-bit machines.
8188 * buffer.c (Fgenerate_new_buffer_name):
8189 Use EMACS_INT for count, not int.
8190 (advance_to_char_boundary): Return EMACS_INT, not int.
8192 * data.c (Qcompiled_function): Now static.
8194 * window.c (window_body_lines): Now static.
8196 * image.c (gif_load): Rename local to avoid shadowing.
8198 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8199 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8200 * alloc.c (make_save_value): Integer argument is now of type
8202 (mark_object): Use ptrdiff_t, not int.
8203 * lisp.h (pD): New macro.
8204 * print.c (print_object): Use it.
8206 * alloc.c: Use EMACS_INT, not int, to count objects.
8207 (total_conses, total_markers, total_symbols, total_vector_size)
8208 (total_free_conses, total_free_markers, total_free_symbols)
8209 (total_free_floats, total_floats, total_free_intervals)
8210 (total_intervals, total_strings, total_free_strings):
8211 Now EMACS_INT, not int. All uses changed.
8212 (Fgarbage_collect): Compute overall total using a double, so that
8213 integer overflow is less likely to be a problem. Check for overflow
8214 when converting back to an integer.
8215 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8216 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8217 These were 'int' variables that could overflow on 64-bit hosts;
8218 they were never used, so remove them instead of repairing them.
8219 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
8220 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8221 Previously, this ceilinged at INT_MAX, but that doesn't work on
8223 (allocate_pseudovector): Don't use EMACS_INT when int would do.
8225 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
8226 (allocate_vectorlike): Check for ptrdiff_t overflow.
8227 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8228 when a (possibly-narrower) signed value would do just as well.
8229 We prefer using signed arithmetic, to avoid comparison confusion.
8231 * alloc.c: Catch some string size overflows that we were missing.
8232 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8233 for convenience in STRING_BYTES_MAX.
8234 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8235 The definition here is exact; the one in lisp.h was approximate.
8236 (allocate_string_data): Check for string overflow. This catches
8237 some instances we weren't catching before. Also, it catches
8238 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8239 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8240 and ptrdiff_t and EMACS_INT are both 64 bits.
8242 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8243 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
8244 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
8246 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8248 * alloc.c (Fmake_string): Check for out-of-range init.
8250 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8252 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8254 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8256 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8257 xg_get_default_scrollbar_width.
8259 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8260 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8261 (style_changed_cb): Call update_theme_scrollbar_width and call
8262 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8263 all frames (Bug#8505).
8264 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8265 Call gtk_window_set_resizable if HAVE_GTK3.
8266 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8267 and height if HAVE_GTK3 (Bug#8505).
8268 (scroll_bar_width_for_theme): New variable.
8269 (update_theme_scrollbar_width): New function.
8270 (xg_get_default_scrollbar_width): Move code to
8271 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8272 (xg_initialize): Call update_theme_scrollbar_width.
8274 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8276 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8278 2011-06-12 Martin Rudalics <rudalics@gmx.at>
8280 * frame.c (make_frame): Call other_buffer_safely instead of
8283 * window.c (temp_output_buffer_show): Call display_buffer with
8284 second argument Vtemp_buffer_show_specifiers and reset latter
8285 immediately after the call.
8286 (Vtemp_buffer_show_specifiers): New variable.
8287 (auto_window_vscroll_p, next_screen_context_lines)
8288 (Vscroll_preserve_screen_position): Remove leading asterisks from
8291 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
8293 Fix minor problems found by GCC 4.6.0 static checking.
8294 * buffer.c (Qclone_number): Remove for now, as it's unused.
8295 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8296 (record_buffer): Remove unused local.
8297 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8298 (set_frame_buffer_list): Remove; unused.
8299 * frame.h (other_visible_frames): Remove decl.
8300 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8301 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8302 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8304 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8305 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8306 Define only if HAVE_GPM.
8307 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8308 (update_hints_inhibit): Remove; never set. All uses removed.
8309 * widgetprv.h (emacsFrameClassRec): Remove decl.
8310 * window.c (delete_deletable_window): Now returns void, since it
8311 wasn't returning anything.
8312 (compare_window_configurations): Remove unused locals.
8313 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8314 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
8315 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8316 the same widths as pointers. This follows up on the 2011-05-06 patch.
8317 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8318 * xterm.h: Likewise.
8319 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8321 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
8323 * makefile.w32-in: Update dependencies.
8324 (LISP_H): Add lib/intprops.h.
8326 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8328 * image.c (gif_load): Add animation frame delay to the metadata.
8329 (syms_of_image): Use DEFSYM. New symbol `delay'.
8331 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8333 * window.c (delete_deletable_window): Re-add.
8334 (Fset_window_configuration): Rewrite to handle dead buffers and
8335 consequently deletable windows.
8336 (window_tree, Fwindow_tree): Remove. Supply functionality in
8338 (compare_window_configurations): Simplify code.
8340 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8342 * image.c (imagemagick_load_image): Fix type mismatch.
8343 (Fimagemagick_types): Likewise.
8345 * window.h (replace_buffer_in_windows): Declare.
8347 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8349 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8350 Qclone_number. Remove external declaration of Qdelete_window.
8351 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8353 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8354 Run Qbuffer_list_update_hook if allowed.
8355 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8356 buffer list implementation.
8357 (other_buffer_safely): New function.
8358 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8359 calls to replace_buffer_in_windows and
8360 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8362 (record_buffer): Inhibit quitting and rewrite using quittable
8363 functions. Run Qbuffer_list_update_hook if allowed.
8364 (Frecord_buffer, Funrecord_buffer): New functions.
8365 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8366 Move switch-to-buffer to window.el.
8367 (bury-buffer): Move to window.el.
8368 (Vbuffer_list_update_hook): New variable.
8370 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8373 * window.h (resize_frame_windows): Move up in code.
8374 (Fwindow_frame): Remove EXFUN.
8375 (replace_buffer_in_all_windows): Remove prototype.
8376 (replace_buffer_in_windows_safely): Add prototype.
8378 * window.c: Declare Qdelete_window static again. Move down
8379 declaration of select_count.
8380 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8381 (Fother_window): Move to window.el.
8382 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8383 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8384 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8386 (replace_buffer_in_windows): Implement by calling
8387 Qreplace_buffer_in_windows.
8388 (replace_buffer_in_all_windows): Remove with some functionality
8389 moved into replace_buffer_in_windows_safely.
8390 (replace_buffer_in_windows_safely): New function.
8391 (select_window_norecord, select_frame_norecord): Move in front
8392 of run_window_configuration_change_hook. Remove now obsolete
8394 (Fset_window_buffer): Rewrite doc-string.
8395 Call Qrecord_window_buffer.
8396 (keys_of_window): Move binding for other-window to window.el.
8398 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8400 * dispextern.h (struct image): Replace data member, whose int_val
8401 and ptr_val fields were not used by anything, with a single
8404 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8405 (gif_clear_image, gif_load, imagemagick_load_image)
8406 (gs_clear_image, gs_load): Callers changed.
8408 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8410 * buffer.h: Include <time.h>, for time_t.
8411 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8413 Fix minor problems found by static checking.
8415 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8417 Make identifiers static if they are not used in other modules.
8418 * data.c (Qcompiled_function, Qframe, Qvector):
8419 * image.c (QimageMagick, Qsvg):
8420 * minibuf.c (Qmetadata):
8421 * window.c (resize_window_check, resize_root_window): Now static.
8422 * window.h (resize_window_check, resize_root_window): Remove decls.
8424 * window.c (window_deletion_count, delete_deletable_window):
8426 (window_body_lines): Now static.
8427 (Fdelete_other_windows_internal): Mark vars as initialized.
8428 Make sure 'resize_failed' is initialized.
8429 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8430 (resize_window_apply): Remove unused local.
8431 * window.h (delete_deletable_window): Remove decl.
8433 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
8434 (imagemagick_load_image): Fix pointer signedness problem by changing
8435 last arg from unsigned char * to char *. All uses changed.
8436 Also, fix a local for similar reasons.
8437 Remove unused locals. Remove locals to avoid shadowing.
8438 (fn_rsvg_handle_free): Remove; unused.
8439 (svg_load, svg_load_image): Fix pointer signedness problem.
8440 (imagemagick_load_image): Don't use garbage pointer image_wand.
8442 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8444 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
8446 * image.c (gif_load): Fix omitted cast error introduced by
8449 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8451 * window.h (resize_proportionally, orig_total_lines)
8452 (orig_top_line): Remove from window structure.
8453 (set_window_height, set_window_width, change_window_heights)
8454 (Fdelete_window): Remove prototypes.
8455 (resize_frame_windows): Remove duplicate declaration.
8457 2011-06-10 Eli Zaretskii <eliz@gnu.org>
8459 * window.h (resize_frame_windows, resize_window_check)
8460 (delete_deletable_window, resize_root_window)
8461 (resize_frame_windows): Declare prototypes.
8463 * window.c (resize_window_apply): Make definition be "static" to
8464 match the prototype.
8466 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8468 * window.c: Remove declarations of Qwindow_size_fixed,
8469 window_min_size_1, window_min_size_2, window_min_size,
8470 size_window, window_fixed_size_p, enlarge_window, delete_window.
8471 Remove static from declaration of Qdelete_window, it's
8472 temporarily needed by Fbury_buffer.
8473 (replace_window): Don't assign orig_top_line and
8475 (Fdelete_window, delete_window): Remove. Window deletion is
8476 handled by window.el.
8477 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8478 Replace Fdelete_window calls with calls to Qdelete_window.
8479 (Fdelete_other_windows): Remove. Deleting other windows is
8480 handled by window.el.
8481 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8482 handled in window.el.
8483 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8484 Window minimum sizes are handled in window.el.
8485 (shrink_windows, size_window, set_window_height)
8486 (set_window_width, change_window_heights, window_height)
8487 (window_width, CURBEG, CURSIZE, enlarge_window)
8488 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8489 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8490 handled in window.el.
8491 (make_dummy_parent): Rename to make_parent_window and give it a
8492 second argument horflag.
8493 (make_window): Don't set resize_proportionally any more.
8494 (Fsplit_window): Remove. Windows are split in window.el.
8495 (save_restore_action, save_restore_orig_size)
8496 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8497 Resize mini windows in window.el.
8498 (grow_mini_window, shrink_mini_window): Implement by calling
8499 Qresize_root_window_vertically, resize_window_check and
8500 resize_window_apply.
8501 (saved_window, Fset_window_configuration, save_window_save):
8502 Do not handle orig_top_line, orig_total_lines, and
8503 resize_proportionally.
8504 (window_min_height, window_min_width): Move to window.el.
8505 (keys_of_window): Move bindings for delete-other-windows,
8506 split-window, delete-window and enlarge-window to window.el.
8508 * buffer.c: Temporarily extern Qdelete_window.
8509 (Fbury_buffer): Temporarily call Qdelete_window instead of
8510 Fdelete_window (Fbury_buffer will move to window.el soon).
8512 * frame.c (set_menu_bar_lines_1): Remove code handling
8513 orig_top_line and orig_total_lines.
8515 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8516 set_window_height but set heights directly.
8517 (change_frame_size_1): Use resize_frame_windows.
8519 * xdisp.c (init_xdisp): Don't use set_window_height but set
8522 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8523 Use resize_frame_windows instead of change_window_heights and run
8524 run_window_configuration_change_hook.
8526 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8527 instead of change_window_heights and run
8528 run_window_configuration_change_hook.
8530 2011-06-09 Martin Rudalics <rudalics@gmx.at>
8532 * window.c (replace_window): Rename second argument REPLACEMENT to
8533 NEW. New third argument SETFLAG. Rewrite.
8534 (delete_window, make_dummy_parent): Call replace_window with
8536 (window_list_1): Move down in code.
8537 (run_window_configuration_change_hook): Move set_buffer part
8538 before select_frame_norecord part in order to unwind correctly.
8539 Rename count1 to count.
8540 (recombine_windows, delete_deletable_window, resize_root_window)
8541 (Fdelete_other_windows_internal)
8542 (Frun_window_configuration_change_hook, make_parent_window)
8543 (resize_window_check, resize_window_apply, Fresize_window_apply)
8544 (resize_frame_windows, Fsplit_window_internal)
8545 (Fdelete_window_internal, Fresize_mini_window_internal):
8547 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8549 2011-06-08 Martin Rudalics <rudalics@gmx.at>
8551 * window.h (window): Add some new members to window structure -
8552 normal_lines, normal_cols, new_total, new_normal, clone_number,
8553 splits, nest, prev_buffers, next_buffers.
8554 (WINDOW_TOTAL_SIZE): Move here from window.c.
8555 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
8557 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8559 (make_dummy_parent): Set new members of windows structure.
8560 (make_window): Move down in code. Handle new members of window
8562 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8563 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8564 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8565 (Fset_window_prev_buffers, Fwindow_next_buffers)
8566 (Fset_window_next_buffers, Fset_window_clone_number):
8568 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8569 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8571 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8572 Argument WINDOW can be now internal window too.
8573 (Fwindow_use_time): Move up in code.
8574 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8576 (Fset_window_configuration, saved_window)
8577 (Fcurrent_window_configuration, save_window_save): Handle new
8578 members of window structure.
8579 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8580 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8581 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8582 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8583 Qget_mru_window, Qresize_root_window,
8584 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8585 Qauto_buffer_name; staticpro them.
8587 2011-06-07 Martin Rudalics <rudalics@gmx.at>
8589 * window.c (Fwindow_total_size, Fwindow_left_column)
8590 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8591 (Fwindow_list_1): New functions.
8592 (window_box_text_cols): Replace with window_body_cols.
8593 (Fwindow_width, Fscroll_left, Fscroll_right):
8594 Use window_body_cols instead of window_box_text_cols.
8595 (delete_window, Fset_window_configuration):
8596 Call delete_all_subwindows with window as argument.
8597 (delete_all_subwindows): Take a window as argument and not a
8599 (window_loop): Remove handling of GET_LRU_WINDOW and
8601 (Fget_lru_window, Fget_largest_window): Move to window.el.
8603 * window.h: Extern window_body_cols instead of
8604 window_box_text_cols. delete_all_subwindows now takes a
8605 Lisp_Object as argument.
8607 * indent.c (compute_motion, Fcompute_motion):
8608 Use window_body_cols instead of window_box_text_cols.
8610 * frame.c (delete_frame): Call delete_all_subwindows with root
8613 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8615 * fns.c (Fputhash): Document return value.
8617 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
8619 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8621 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8623 Cons<->int and similar integer overflow fixes (Bug#8794).
8625 Check for overflow when converting integer to cons and back.
8626 * charset.c (Fdefine_charset_internal, Fdecode_char):
8627 Use cons_to_unsigned to catch overflow.
8628 (Fencode_char): Use INTEGER_TO_CONS.
8629 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8630 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8631 * data.c (long_to_cons, cons_to_long): Remove.
8632 (cons_to_unsigned, cons_to_signed): New functions.
8633 These signal an error for invalid or out-of-range values.
8634 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8635 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8636 * font.c (Ffont_variation_glyphs):
8637 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8638 * lisp.h: Include <intprops.h>.
8639 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8640 (cons_to_signed, cons_to_unsigned): New decls.
8641 (long_to_cons, cons_to_long): Remove decls.
8642 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8643 (Fprimitive_undo): Use CONS_TO_INTEGER.
8644 * xfns.c (Fx_window_property): Likewise.
8645 * xselect.c: Include <limits.h>.
8646 (x_own_selection, selection_data_to_lisp_data):
8647 Use INTEGER_TO_CONS.
8648 (x_handle_selection_request, x_handle_selection_clear)
8649 (x_get_foreign_selection, Fx_disown_selection_internal)
8650 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8651 (lisp_data_to_selection_data): Use cons_to_unsigned.
8652 (x_fill_property_data): Use cons_to_signed.
8653 Report values out of range.
8655 Check for buffer and string overflow more precisely.
8656 * buffer.h (BUF_BYTES_MAX): New macro.
8657 * lisp.h (STRING_BYTES_MAX): New macro.
8658 * alloc.c (Fmake_string):
8659 * character.c (string_escape_byte8):
8660 * coding.c (coding_alloc_by_realloc):
8661 * doprnt.c (doprnt):
8662 * editfns.c (Fformat):
8664 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8665 since they may not be the same number.
8666 * editfns.c (Finsert_char):
8667 * fileio.c (Finsert_file_contents):
8668 Likewise for BUF_BYTES_MAX.
8670 * image.c: Use ptrdiff_t, not int, for sizes.
8671 (slurp_file): Switch from int to ptrdiff_t.
8673 (slurp_file): Check that file size fits in both size_t (for
8674 malloc) and ptrdiff_t (for sanity and safety).
8676 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8677 if b->modtime has its maximal value.
8679 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8681 Don't assume time_t can fit into int.
8682 * buffer.h (struct buffer.modtime): Now time_t, not int.
8683 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8684 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8686 Minor fixes for signed vs unsigned integers.
8687 * character.h (MAYBE_UNIFY_CHAR):
8688 * charset.c (maybe_unify_char):
8689 * keyboard.c (read_char, reorder_modifiers):
8690 XINT -> XFASTINT, since the integer must be nonnegative.
8691 * ftfont.c (ftfont_spec_pattern):
8692 * keymap.c (access_keymap, silly_event_symbol_error):
8693 XUINT -> XFASTINT, since the integer must be nonnegative.
8694 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8695 since it makes no difference and we prefer signed.
8696 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8697 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8700 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8702 * window.h (Fwindow_frame): Declare.
8704 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8706 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8707 (SPARE_MEMORY): Always define.
8708 (LARGE_REQUEST): Remove.
8709 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8711 2011-06-06 Martin Rudalics <rudalics@gmx.at>
8713 * lisp.h: Move EXFUNS for Fframe_root_window,
8714 Fframe_first_window and Fset_frame_selected_window to window.h.
8716 * window.h: Move EXFUNS for Fframe_root_window,
8717 Fframe_first_window and Fset_frame_selected_window here from
8720 * frame.c (Fwindow_frame, Fframe_first_window)
8721 (Fframe_root_window, Fframe_selected_window)
8722 (Fset_frame_selected_window): Move to window.c.
8723 (Factive_minibuffer_window): Move to minibuf.c.
8724 (Fother_visible_frames_p): New function.
8726 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8728 * window.c (decode_window, decode_any_window): Move up in code.
8729 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8730 (inhibit_frame_unsplittable): Remove unused variable.
8731 (Fwindow_buffer): Move up and rewrite doc-string.
8732 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8733 (Fwindow_prev): New functions.
8734 (Fwindow_frame): Move here from frame.c. Accept any window as
8736 (Fframe_root_window, Fframe_first_window)
8737 (Fframe_selected_window): Move here from frame.c. Accept frame
8738 or arbitrary window as argument. Update doc-strings.
8739 (Fminibuffer_window): Move up in code.
8740 (Fwindow_minibuffer_p): Move up in code and simplify.
8741 (Fset_frame_selected_window): Move here from frame.c.
8743 (Fselected_window, select_window, Fselect_window): Move up in
8744 code. Minor doc-string fixes.
8746 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8748 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8749 Do not assume that spare memory exists; that assumption is valid
8750 only if SYSTEM_MALLOC.
8751 (LARGE_REQUEST): New macro, so that the issue of large requests
8752 is separated from the issue of spare memory.
8754 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8756 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8759 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8761 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8764 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8766 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8768 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8770 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8771 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8773 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
8775 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8777 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
8779 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8780 (x_clipboard_manager_save): Add return value.
8781 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8783 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8784 Obey Vx_select_enable_clipboard_manager. Catch errors in
8785 x_clipboard_manager_save (Bug#8779).
8786 (Vx_select_enable_clipboard_manager): New variable.
8787 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
8789 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8791 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8793 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8795 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8796 in the current matrix if keep_current_p is non-zero.
8798 2011-06-04 Eli Zaretskii <eliz@gnu.org>
8800 * bidi.c (bidi_level_of_next_char): Fix last change.
8802 2011-06-03 Eli Zaretskii <eliz@gnu.org>
8804 Support bidi reordering of text covered by display properties.
8806 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8807 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8808 (bidi_cache_search, bidi_cache_iterator_state)
8809 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
8810 (bidi_level_of_next_char, bidi_move_to_visually_next):
8811 Support character positions inside a run of characters covered by a
8813 (bidi_paragraph_init, bidi_resolve_explicit_1)
8814 (bidi_level_of_next_char): Call bidi_fetch_char and
8815 bidi_fetch_char_advance instead of FETCH_CHAR and
8817 (bidi_init_it): Initialize new members.
8818 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8820 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8821 instead of using explicit *_CHAR codes.
8822 (bidi_resolve_explicit, bidi_resolve_weak):
8823 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
8824 bidirectional text is supported only in multibyte buffers.
8825 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8826 it to initialize the frame_window_p member of struct bidi_it.
8827 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8828 (bidi_resolve_explicit, bidi_resolve_weak)
8829 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8830 bidi_it->nchars is non-positive.
8831 (bidi_level_of_next_char): Don't try to lookup the cache for the
8832 next/previous character if nothing is cached there yet, or if we
8833 were just reseat()'ed to a new position.
8835 * xdisp.c (set_cursor_from_row): Set start and stop points
8836 according to the row's direction when priming the loop that looks
8837 for the glyph on which to display cursor.
8838 (single_display_spec_intangible_p): Function deleted.
8839 (display_prop_intangible_p): Reimplement to call
8840 handle_display_spec instead of single_display_spec_intangible_p.
8841 Accept 3 additional arguments needed by handle_display_spec.
8842 This fixes incorrect cursor motion across display property with complex
8843 values: lists, `(when COND...)' forms, etc.
8844 (single_display_spec_string_p): Support property values that are
8845 lists with the argument STRING its top-level element.
8846 (display_prop_string_p): Fix the condition for processing a
8847 property that is a list to be consistent with handle_display_spec.
8848 (handle_display_spec): New function, refactored from the
8849 last portion of handle_display_prop.
8850 (compute_display_string_pos): Accept additional argument
8851 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8852 value of a `display' property is a "replacing spec".
8853 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8854 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8855 the display property, but just return a value indicating whether
8856 the display property will replace the characters it covers.
8857 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8858 frame_window_p members of struct bidi_it.
8859 (compute_display_string_pos, compute_display_string_end):
8861 (push_it): Accept second argument POSITION, where pop_it should
8862 jump to continue iteration.
8863 (reseat_1): Initialize bidi_it.disp_pos.
8865 * keyboard.c (adjust_point_for_property): Adjust the call to
8866 display_prop_intangible_p to its new signature.
8868 * dispextern.h (struct bidi_it): New member frame_window_p.
8869 (bidi_init_it): Update prototypes.
8870 (display_prop_intangible_p): Update prototype.
8871 (compute_display_string_pos, compute_display_string_end):
8873 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8876 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
8878 Malloc failure behavior now depends on size of allocation.
8879 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8880 * lisp.h: Change signatures accordingly.
8881 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8882 All callers changed. (Bug#8762)
8884 * gnutls.c: Use Emacs's memory allocators.
8885 Without this change, the gnutls library would invoke malloc etc.
8886 directly, which causes problems on non-SYNC_INPUT hosts, and which
8887 runs afoul of improving memory_full behavior. (Bug#8761)
8888 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8889 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8890 xfree instead of the default malloc, realloc, free.
8891 (Fgnutls_boot): No need to check for memory allocation failure,
8892 since xmalloc does that for us.
8894 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
8895 * category.c (hash_get_category_set):
8896 * ccl.c (ccl_driver):
8897 * charset.c (Fdefine_charset_internal):
8898 * charset.h (struct charset.hash_index):
8899 * composite.c (get_composition_id, gstring_lookup_cache)
8900 (composition_gstring_put_cache):
8901 * composite.h (struct composition.hash_index):
8902 * dispextern.h (struct image.hash):
8903 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8904 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8905 (hashfn_equal, hashfn_user_defined, make_hash_table)
8906 (maybe_resize_hash_table, hash_lookup, hash_put)
8907 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8908 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8909 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8910 * image.c (make_image, search_image_cache, lookup_image)
8911 (xpm_put_color_table_h):
8912 * lisp.h (struct Lisp_Hash_Table):
8913 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
8914 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
8915 for hashes and hash indexes, instead of 'unsigned' and 'int'.
8916 * alloc.c (allocate_vectorlike):
8917 Check for overflow in vector size calculations.
8918 * ccl.c (ccl_driver):
8919 Check for overflow when converting EMACS_INT to int.
8920 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8921 need to be updated by these changes.
8922 * fns.c (make_hash_table, maybe_resize_hash_table):
8923 Check for integer overflow with large hash tables.
8924 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8925 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8926 (SXHASH_REDUCE): New macro.
8927 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8928 Use it instead of discarding useful hash info with large hash values.
8929 (sxhash_float): New function.
8930 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8931 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
8932 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8933 Rewrite to use FIXNUM_BITS, as this simplifies things.
8934 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8935 Adjust signatures to match updated version of code.
8936 (consing_since_gc): Now EMACS_INT, since a single hash table can
8937 use more than INT_MAX bytes.
8939 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8941 Make it possible to build with GCC-4.6+ -O2 -flto.
8943 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8945 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8947 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8948 Call minibuffer-inactive-mode.
8950 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
8952 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8953 Update dependencies.
8955 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8957 * data.c (init_data): Remove code for UTS, this system is not
8960 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8962 Don't force ./temacs to start in terminal mode.
8964 * frame.c (make_initial_frame): Initialize faces in all cases, not
8965 only when CANNOT_DUMP is defined.
8966 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8968 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8970 * dispnew.c (add_window_display_history): Use const for the string
8971 pointer. Remove declaration, not needed.
8973 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8975 Use 'inline', not 'INLINE'.
8976 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
8977 * alloc.c, fontset.c (INLINE): Remove.
8978 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8979 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8980 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8981 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8982 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8984 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8986 Make it possible to run ./temacs.
8988 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8989 syms_of_callproc does the same thing. Remove test for
8990 "initialized", do it in the caller.
8991 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8993 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8995 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8996 (read_minibuf): Use get_minibuffer.
8997 (syms_of_minibuf): Use DEFSYM.
8998 (Qmetadata): New var.
8999 * data.c (Qbuffer): Don't make it static.
9000 (syms_of_data): Use DEFSYM.
9002 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9004 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9005 (CCL_CODE_MIN): New macro.
9007 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9009 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9011 * eval.c (Qdebug): Now static.
9012 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9013 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9014 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9016 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
9018 * image.c: Various fixes to ImageMagick code comments.
9019 (Fimagemagick_types): Doc fix.
9021 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9023 Minor fixes prompted by GCC 4.6.0 warnings.
9025 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9027 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9028 (x_clipboard_manager_save_all): Move extern decl to ...
9029 * xterm.h: ... here, so that it can be checked for consistency.
9031 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
9033 * xselect.c (x_clipboard_manager_save_frame)
9034 (x_clipboard_manager_save_all): New functions.
9035 (Fx_clipboard_manager_save): Lisp function deleted.
9037 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9038 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9040 * xterm.h: Update prototype.
9042 2011-05-28 William Xu <william.xwl@gmail.com>
9044 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9047 2011-05-28 Jim Meyering <meyering@redhat.com>
9049 Avoid a sign-extension bug in crypto_hash_function.
9050 * fns.c (to_uchar): Define.
9051 (crypto_hash_function): Use it to convert some newly-signed
9052 variables to unsigned, to avoid sign-extension bugs. For example,
9053 without this change, (md5 "truc") would evaluate to
9054 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9055 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
9056 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
9058 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9060 Integer overflow fixes.
9062 * dbusbind.c: Serial number integer overflow fixes.
9063 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
9064 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9065 to hold a serial number that is too large for a fixnum.
9066 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9067 Check for serial numbers out of range. Decode any serial number
9068 that was so large that it became a float. (Bug#8722)
9070 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9071 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9072 Use XFASTINT rather than XUINT when numbers are nonnegative.
9073 (xd_append_arg, Fdbus_method_return_internal):
9074 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9075 arguments, check that Lisp number is nonnegative, rather than
9076 silently wrapping negative numbers around. (Bug#8722)
9077 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
9080 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9082 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9084 ccl: Add integer overflow checks.
9085 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9086 (IN_INT_RANGE): New macros.
9087 (ccl_driver): Use them to check for integer overflow when
9088 decoding a CCL program. Many of the new checks are whether XINT (x)
9089 fits in int; it doesn't always, on 64-bit hosts. The new version
9090 doesn't catch all possible integer overflows, but it's an
9091 improvement. (Bug#8719)
9093 * alloc.c (make_event_array): Use XINT, not XUINT.
9094 There's no need for unsigned here.
9096 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9097 This follows up to the 2011-05-06 change that substituted uintptr_t
9098 for EMACS_INT. This case wasn't caught back then.
9100 Rework Fformat to avoid integer overflow issues.
9101 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9102 now (part of C89). Include <verify.h>.
9103 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9104 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9105 (Fformat): Avoid the prepass trying to compute sizes; it was only
9106 approximate and thus did not catch overflow reliably. Instead, walk
9107 through the format just once, formatting and computing sizes as we go,
9108 checking for integer overflow at every step, and allocating a larger
9109 buffer as needed. Keep track separately whether the format is
9110 multibyte. Keep only the most-recently calculated precision, rather
9111 than them all. Record whether each argument has been converted to
9112 string. Use EMACS_INT, not int, for byte and char and arg counts.
9113 Support field widths and precisions larger than INT_MAX. Avoid
9114 sprintf's undefined behavior with conversion specifications such as %#d
9115 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9116 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9117 formatting out-of-range floating point numbers with int
9120 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9122 * data.c: Avoid integer truncation in expressions involving floats.
9123 * data.c: Include <intprops.h>.
9124 (arith_driver): When there's an integer overflow in an expression
9125 involving floating point, convert the integers to floating point
9126 so that the resulting value does not suffer from catastrophic
9127 integer truncation. For example, on a 64-bit host (* 4
9128 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9129 Do not rely on undefined behavior after integer overflow.
9131 merge count_size_as_multibyte, parse_str_to_multibyte
9132 * character.c, character.h (count_size_as_multibyte):
9133 Rename from parse_str_to_multibyte; all uses changed.
9134 Check for integer overflow.
9135 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9136 since it's now a duplicate of the other. This is more of
9137 a character than a buffer op, so better that it's in character.c.
9138 * fns.c, print.c: Adjust to above changes.
9140 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9142 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9144 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9146 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9147 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9148 (x_clipboard_manager_save): Now static.
9149 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9151 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9152 (crypto_hash_function): Now static.
9153 Fix pointer signedness problems. Avoid unnecessary initializations.
9155 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
9157 * termhooks.h (Vselection_alist): Make it terminal-local.
9159 * terminal.c (create_terminal): Initialize it.
9161 * xselect.c: Support for clipboard managers.
9162 (Vselection_alist): Move to termhooks.h as terminal-local var.
9163 (LOCAL_SELECTION): New macro.
9164 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9165 (symbol_to_x_atom): Remove gratuitous arg.
9166 (x_handle_selection_request, lisp_data_to_selection_data)
9167 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
9168 (x_own_selection, x_get_local_selection, x_convert_selection):
9169 New arg, specifying work frame. Use terminal-local Vselection_alist.
9170 (some_frame_on_display): Delete unused function.
9171 (Fx_own_selection_internal, Fx_get_selection_internal)
9172 (Fx_disown_selection_internal, Fx_selection_owner_p)
9173 (Fx_selection_exists_p): New optional frame arg.
9174 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9175 (x_handle_selection_clear): Don't treat other terminals with the
9176 same keyboard specially. Use the terminal-local Vselection_alist.
9177 (x_clear_frame_selections): Use Frun_hook_with_args.
9179 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9181 * xterm.h: Add support for those atoms.
9183 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
9185 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9186 (converted_selections, conversion_fail_tag): New global variables.
9187 (x_selection_request_lisp_error): Free the above.
9188 (x_get_local_selection): Remove unnecessary code.
9189 (x_reply_selection_request): Args changed; handle arbitrary array
9190 of converted selections stored in converted_selections.
9191 Separate the XChangeProperty and SelectionNotify steps.
9192 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9193 (x_convert_selection): New function.
9194 (x_handle_selection_event): Simplify.
9195 (x_get_foreign_selection): Don't ignore incoming requests while
9196 waiting for an answer; this will fail when we implement
9197 SAVE_TARGETS, and seems unnecessary anyway.
9198 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9199 (Vx_sent_selection_functions): Doc fix.
9201 2011-05-26 Leo Liu <sdl.web@gmail.com>
9203 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9205 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9207 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9209 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9210 for fringe update if it has periodic bitmap.
9211 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
9212 and fringe_bitmap_periodic_p.
9214 * fringe.c (get_fringe_bitmap_data): New function.
9215 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9216 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9217 row. Mark glyph row for fringe update if periodicity changed.
9219 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9220 for fringe update unless it has periodic bitmap.
9222 2011-05-25 Kenichi Handa <handa@m17n.org>
9224 * xdisp.c (get_next_display_element): Set correct it->face_id for
9225 a static composition.
9227 2011-05-24 Leo Liu <sdl.web@gmail.com>
9230 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9232 * fns.c (crypto_hash_function, Fsha1): New function.
9233 (Fmd5): Use crypto_hash_function.
9234 (syms_of_fns): Add Ssha1.
9236 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9238 * gnutls.c: Remove unused macros.
9239 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9240 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9241 Remove macros that are defined and never used.
9242 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9244 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9246 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9247 (Fx_get_selection_internal): Minor cleanup.
9248 (Fx_own_selection_internal): Rename arguments for consistency with
9251 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9253 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9255 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9257 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9259 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9261 * dispnew.c (scrolling_window): Don't exclude the case that the
9262 last enabled row in the desired matrix touches the bottom boundary.
9264 2011-05-21 Glenn Morris <rgm@gnu.org>
9266 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
9267 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9268 and add some more files.
9270 2011-05-20 Eli Zaretskii <eliz@gnu.org>
9272 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9273 report_file_error introduced by the change from 2011-05-07.
9275 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9277 * systime.h (Time): Define only if emacs is defined.
9278 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9279 where the include path doesn't have X11/X.h by default. See
9280 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9282 2011-05-20 Kenichi Handa <handa@m17n.org>
9284 * composite.c (find_automatic_composition): Fix previous change.
9286 2011-05-20 Glenn Morris <rgm@gnu.org>
9288 * lisp.mk: New file, split from Makefile.in.
9289 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9290 (shortlisp): Remove.
9291 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9293 2011-05-19 Glenn Morris <rgm@gnu.org>
9295 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9296 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9297 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9298 (lisp): Set the order to that of loadup.el.
9299 (shortlisp): Make it a copy of $lisp.
9300 (SOME_MACHINE_LISP): Remove.
9301 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9302 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9304 2011-05-18 Kenichi Handa <handa@m17n.org>
9306 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9307 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9308 (find_automatic_composition): Mostly rewrite for efficiency.
9310 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
9312 * makefile.w32-in: Update dependencies.
9314 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9316 * menu.c: Include limits.h (fixes the MS-Windows build broken by
9317 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
9319 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
9321 Fix some integer overflow issues, such as string length overflow.
9323 * insdel.c (count_size_as_multibyte): Check for string overflow.
9325 * character.c (lisp_string_width): Check for string overflow.
9326 Use EMACS_INT, not int, for string indexes and lengths; in
9327 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9328 the resulting string length overflows an EMACS_INT; instead,
9329 report a string overflow if no precision given. When checking for
9330 precision exhaustion, use a check that cannot possibly have
9331 integer overflow. (Bug#8675)
9332 * character.h (lisp_string_width): Adjust to new signature.
9334 * alloc.c (string_overflow): New function.
9335 (Fmake_string): Use it. This doesn't change behavior, but saves
9336 a few bytes and will simplify future changes.
9337 * character.c (string_escape_byte8): Likewise.
9338 * lisp.h (string_overflow): New decl.
9340 Fixups, following up to the user-interface timestamp change.
9341 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9342 for UI timestamps, instead of unsigned long.
9343 * msdos.c (mouse_get_pos): Likewise.
9344 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
9345 * w32gui.h (Time): Define by including "systime.h" rather than by
9346 declaring it ourselves. (Bug#8664)
9348 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9349 * image.c (clear_image_cache): Likewise.
9351 * term.c (term_mouse_position): Don't assume time_t wraparound.
9353 Be more systematic about user-interface timestamps.
9354 Before, the code sometimes used 'Time', sometimes 'unsigned long',
9355 and sometimes 'EMACS_UINT', to represent these timestamps.
9356 This change causes it to use 'Time' uniformly, as that's what X uses.
9357 This makes the code easier to follow, and makes it easier to catch
9358 integer overflow bugs such as Bug#8664.
9359 * frame.c (Fmouse_position, Fmouse_pixel_position):
9360 Use Time, not unsigned long, for user-interface timestamps.
9361 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9362 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9363 * keyboard.h (last_event_timestamp): Likewise.
9364 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9365 * menu.h (xmenu_show): Likewise.
9366 * term.c (term_mouse_position): Likewise.
9367 * termhooks.h (struct input_event.timestamp): Likewise.
9368 (struct terminal.mouse_position_hook): Likewise.
9369 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9370 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9371 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9372 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9374 * menu.h, termhooks.h: Include "systime.h", for Time.
9376 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9377 Don't assume that the difference between two unsigned long values
9378 can fit into an integer. At this point, we know button_down_time
9379 <= event->timestamp, so the difference must be nonnegative, so
9380 there's no need to cast the result if double-click-time is
9381 nonnegative, as it should be; check that it's nonnegative, just in
9382 case. This bug is triggered when events are more than 2**31 ms
9383 apart (about 25 days). (Bug#8664)
9385 * xselect.c (last_event_timestamp): Remove duplicate decl.
9386 (x_own_selection): Remove needless cast to unsigned long.
9388 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9389 that always fit in int. Use a sentinel instead of a counter, to
9390 avoid a temp and to allay GCC's concerns about possible int overflow.
9391 * frame.h (struct frame): Use int for menu_bar_items_used
9392 instead of EMACS_INT, since it always fits in int.
9394 * menu.c (grow_menu_items): Check for int overflow.
9396 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9398 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9399 Before, the code was not consistent. These values cannot exceed
9400 2**31 - 1 so there's no need to make them unsigned.
9401 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9402 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9403 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9405 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9407 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9408 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9409 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9410 presumably because the widths might not match.
9412 * window.c (size_window): Avoid needless test at loop start.
9414 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9416 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9418 2011-05-12 Drew Adams <drew.adams@oracle.com>
9420 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9422 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9424 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9425 `width' to `bar_area_x' and `bar_area_width', respectively.
9426 (x_scroll_run): Take account of fringe background extension.
9428 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9429 Rename local vars `left' and `width' to `bar_area_x' and
9430 `bar_area_width', respectively.
9431 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9432 background extension.
9434 2011-05-10 Jim Meyering <meyering@redhat.com>
9436 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9438 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
9440 * image.c (Finit_image_library): Return t for built-in image types,
9441 like pbm and xbm. (Bug#8640)
9443 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9445 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9447 2011-05-07 Eli Zaretskii <eliz@gnu.org>
9449 * w32console.c (Fset_screen_color): Doc fix.
9450 (Fget_screen_color): New function.
9451 (syms_of_ntterm): Defsubr it.
9453 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9454 unlink the temporary file if Fcall_process didn't create it in the
9456 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9457 child process will be redirected to a file specified with `:file'.
9458 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9459 cue to call_process_cleanup not to close that handle.
9461 2011-05-07 Ben Key <bkey76@gmail.com>
9463 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9464 one of two shell specific rules, either bootstrap-temacs-CMD or
9465 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9466 to the previous implementation of the bootstrap-temacs rule.
9467 The bootstrap-temacs-CMD rule is similar to the previous
9468 implementation of the bootstrap-temacs rule except that it
9469 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9472 These changes, along with some changes to nt/configure.bat,
9473 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9474 earlier fix to add support for --cflags and --ldflags options
9475 that include quotes so that it works whether make uses cmd or
9478 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
9480 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9481 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9483 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9484 a string. Handle both cases.
9485 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9486 (Fdbus_register_method): Use Qinvalid_function.
9488 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
9490 * makefile.w32-in: Update dependencies.
9491 (LISP_H): Add inttypes.h and stdin.h.
9492 (PROCESS_H): Add unistd.h.
9494 2011-05-06 Eli Zaretskii <eliz@gnu.org>
9496 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9497 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9499 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
9501 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9503 * term.c (vfatal): Remove stray call to va_end.
9504 It's not needed and the C Standard doesn't allow it here anyway.
9506 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9507 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9509 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9512 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9514 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9516 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9518 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9520 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9522 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9523 * charset.c (Fdefine_charset_internal): Don't initialize
9524 charset.code_space[15]. The value was garbage, on hosts with
9525 32-bit int (Bug#8600).
9527 * lread.c (read_integer): Be more consistent with string-to-number.
9528 Use string_to_number to do the actual conversion; this avoids
9529 rounding errors and fixes some other screwups. Without this fix,
9530 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9531 (digit_to_number): Move earlier, for benefit of read_integer.
9532 Return -1 if the digit is out of range for the base, -2 if it is
9533 not a digit in any supported base. (Bug#8602)
9535 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9537 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9538 to match comment at start of function. This also removes a
9539 GCC warning about overflow in a 32+64-bit port.
9541 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9543 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9544 Reported by Stefan Monnier in
9545 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
9546 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9547 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
9549 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9550 (EMACS_UINTPTR): Likewise, with uintptr_t.
9552 * lisp.h: Prefer 64-bit EMACS_INT if available.
9553 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9554 on 32-bit hosts that have 64-bit int, so that they can access
9556 However, temporarily disable this change unless the temporary
9557 symbol WIDE_EMACS_INT is defined.
9559 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9561 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9562 This removes an assumption that EMACS_INT and long are the same
9563 width as pointers. The assumption is true for Emacs porting targets
9564 now, but we want to make other targets possible.
9565 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9566 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9567 In the rest of the code, change types of integers that hold casted
9568 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9569 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9570 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9571 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9572 No need to cast type when ORing.
9573 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9574 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9575 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9576 assume EMACS_INT is the same width as char *.
9577 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9578 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9579 Remove no-longer-needed casts.
9580 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9581 (xg_tool_bar_help_callback, xg_make_tool_item):
9582 Use EMACS_INTPTR to hold an integer
9583 that will be cast to void *; this can avoid a GCC warning
9584 if EMACS_INT is not the same width as void *.
9585 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9586 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9587 (current_message_1, set_message_1):
9588 Use a local to convert to proper width without a cast.
9589 * xmenu.c (dialog_selection_callback): Likewise.
9591 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9592 Also, don't assume VALBITS / RAND_BITS is less than 5,
9593 and don't rely on undefined behavior when shifting a 1 left into
9595 * lisp.h (get_random): Change signature to match.
9597 * lread.c (hash_string): Use size_t, not int, for hash computation.
9598 Normally we prefer signed values; but hashing is special, because
9599 it's better to use unsigned division on hash table sizes so that
9600 the remainder is nonnegative. Also, size_t is the natural width
9601 for hashing into memory. The previous code used 'int', which doesn't
9602 retain enough info to hash well into very large tables.
9603 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9605 * dbusbind.c: Don't possibly lose pointer info when converting.
9606 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9607 Use XPNTR rather than XHASH, so that the high-order bits of
9608 the pointer aren't lost when converting through void *.
9610 * eval.c (Fautoload): Don't double-shift a pointer.
9612 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9614 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
9616 * gnutls.c (DEF_GNUTLS_FN):
9617 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9619 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9621 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9624 2011-05-05 Eli Zaretskii <eliz@gnu.org>
9626 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9627 New version that can reserve upto 2GB of heap space.
9629 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
9631 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9633 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9635 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9636 `gnutls_certificate_set_x509_key_file'.
9638 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
9640 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9641 Update dependencies.
9643 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9645 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9646 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9647 Remove unused parameter `fildes'.
9648 * process.c (read_process_output, send_process): Don't pass it.
9650 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9652 Fix previous change: the library cache is defined in w32.c.
9653 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9654 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9656 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9658 Implement dynamic loading of GnuTLS on Windows.
9660 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9661 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9662 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9665 * gnutls.c (Qgnutls_dll): Define.
9666 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9667 (gnutls_*): Declare function pointers.
9668 (init_gnutls_functions): New function to initialize function pointers.
9669 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9670 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9671 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9672 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9673 (emacs_gnutls_write, emacs_gnutls_read)
9674 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9675 (Fgnutls_available_p): New function.
9676 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9677 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9678 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9680 * image.c: Include w32.h.
9681 (Vimage_type_cache): Delete.
9682 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9683 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9684 (w32_delayed_load): Move to w32.c.
9686 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9688 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9689 (w32_delayed_load): Move from image.c. When loading a library, record
9690 its filename in the :loaded-from property of the library id.
9691 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9692 Initialize and staticpro them.
9693 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9695 * process.c: Include lisp.h before w32.h, not after.
9696 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9697 instead of gnutls_record_check_pending.
9699 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9701 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9703 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9704 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9707 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9709 * xterm.c (x_set_frame_alpha): Do not set property on anything
9710 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9712 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
9714 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9716 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
9718 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9719 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9720 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9721 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9722 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9723 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9724 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9725 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9726 (Qgnutls_bootprop_callbacks_verify): Make static.
9728 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9730 * callproc.c: Indentation fixup.
9732 * sysdep.c (wait_for_termination_1): Make static.
9733 (wait_for_termination, interruptible_wait_for_termination):
9734 Move after wait_for_termination_1.
9736 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9738 * sysdep.c (interruptible_wait_for_termination): New function
9739 which is like wait_for_termination, but allows keyboard
9742 * callproc.c (Fcall_process): Add (:file "file") as an option for
9744 (Fcall_process_region): Ditto.
9746 2011-04-30 Eli Zaretskii <eliz@gnu.org>
9748 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9749 rather than `XVECTOR (FOO)->size'.
9751 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9752 inttypes.h, as a gnulib replacement is used if it not available in
9755 2011-04-21 Eli Zaretskii <eliz@gnu.org>
9757 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9758 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9759 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9761 * coding.c (coding_alloc_by_realloc): Error out if destination
9762 will grow beyond MOST_POSITIVE_FIXNUM.
9763 (decode_coding_emacs_mule): Abort if there isn't enough place in
9764 charbuf for the composition carryover bytes. Reserve an extra
9765 space for up to 2 characters produced in a loop.
9766 (decode_coding_iso_2022): Abort if there isn't enough place in
9767 charbuf for the composition carryover bytes.
9769 2011-04-21 Eli Zaretskii <eliz@gnu.org>
9771 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9772 aborting when %lld or %lll format is passed.
9773 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9774 %llo or %llx format is passed. (Bug#8545)
9776 * window.c (window_scroll_line_based): Use a marker instead of
9777 simple variables to record original value of point. (Bug#7952)
9779 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9780 produced by %s or %c overflows available buffer space. (Bug#8545)
9782 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9784 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
9785 (SIZE_MAX): Move defn after all includes, as they might #define it.
9787 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9789 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9791 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9793 * keyboard.c (Qdelayed_warnings_hook): Define.
9794 (command_loop_1): Run `delayed-warnings-hook'
9795 if Vdelayed_warnings_list is non-nil.
9796 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9797 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9799 2011-04-28 Eli Zaretskii <eliz@gnu.org>
9801 * doprnt.c (doprnt): Don't return value smaller than the buffer
9802 size if the message was truncated. (Bug#8545).
9804 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9806 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9807 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9809 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9811 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9813 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
9815 * makefile.w32-in: Update dependencies.
9817 2011-04-27 Eli Zaretskii <eliz@gnu.org>
9819 Improve `doprnt' and its usage. (Bug#8545)
9820 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9821 `format_end'. Remove support for %l as a conversion specifier.
9822 Don't use xrealloc. Improve diagnostics when the %l size modifier
9823 is used. Update the commentary.
9825 * eval.c (verror): Simplify calculation of size_t.
9827 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9830 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9832 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9835 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9837 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9838 This makes this file independent of the recent pseudovector change.
9840 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
9842 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9844 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
9845 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
9846 Remove unused local.
9847 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
9849 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
9850 GCC 4.6.0 optimizes based on type-based alias analysis.
9851 For example, if b is of type struct buffer * and v of type struct
9852 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9853 != &v->size, and therefore "v->size = 1; b->size = 2; return
9854 v->size;" must therefore return 1. This assumption is incorrect
9855 for Emacs, since it type-puns struct Lisp_Vector * with many other
9856 types. To fix this problem, this patch adds a new type struct
9857 vectorlike_header that documents the constraints on layout of vectors
9858 and pseudovectors, and helps optimizing compilers not get fooled
9859 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9860 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
9861 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9863 (XSETPVECTYPE): Rewrite in terms of new macro.
9864 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9865 This is a bit clearer, and further avoids the possibility of
9866 undesirable aliasing.
9867 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
9868 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
9869 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9870 since Lisp_Subr is a special case (no "next" field).
9871 (ASIZE): Now uses header.size rather than size.
9872 All previous uses of XVECTOR (foo)->size replaced to use this macro,
9873 to avoid the hassle of writing XVECTOR (foo)->header.size.
9874 (struct vectorlike_header): New type.
9875 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9876 object, to help avoid aliasing.
9877 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9878 (SUBRP): Likewise, since Lisp_Subr is a special case.
9879 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9880 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9881 (struct Lisp_Hash_Table): Combine first two members into a single
9882 struct vectorlike_header member. All uses of "size" and "next" members
9883 changed to be "header.size" and "header.next".
9884 * buffer.h (struct buffer): Likewise.
9885 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9886 * frame.h (struct frame): Likewise.
9887 * process.h (struct Lisp_Process): Likewise.
9888 * termhooks.h (struct terminal): Likewise.
9889 * window.c (struct save_window_data, struct saved_window): Likewise.
9890 * window.h (struct window): Likewise.
9891 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9892 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9893 * buffer.c (init_buffer_once): Likewise.
9894 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9896 * process.c (Fformat_network_address): Use local var for size,
9899 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9901 Make the Lisp reader and string-to-float more consistent (Bug#8525)
9902 * data.c (atof): Remove decl; no longer used or needed.
9903 (digit_to_number): Move to lread.c.
9904 (Fstring_to_number): Use new string_to_number function, to be
9905 consistent with how the Lisp reader treats infinities and NaNs.
9906 Do not assume that floating-point numbers represent EMACS_INT
9907 without losing information; this is not true on most 64-bit hosts.
9908 Avoid double-rounding errors, by insisting on integers when
9909 parsing non-base-10 numbers, as the documentation specifies.
9910 * lisp.h (string_to_number): New decl, replacing ...
9911 (isfloat_string): Remove.
9912 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
9913 (read1): Do not accept +. and -. as integers; this
9914 appears to have been a coding error. Similarly, do not accept
9915 strings like +-1e0 as floating point numbers. Do not report
9916 overflow for integer overflows unless the base is not 10 which
9917 means we have no simple and reliable way to continue.
9918 Break out the floating-point parsing into a new
9919 function string_to_number, so that Fstring_to_number parses
9920 floating point numbers consistently with the Lisp reader.
9921 (digit_to_number): Move here from data.c. Make it static inline.
9922 (E_CHAR, EXP_INT): Remove, replacing with ...
9923 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9924 (string_to_number): New function, replacing isfloat_string.
9925 This function checks for valid syntax and produces the resulting
9926 Lisp float number too. Rework it so that string-to-number
9927 no longer mishandles examples like "1.0e+". Use strtoumax,
9928 so that overflow for non-base-10 numbers is reported only when
9929 there's no portable and simple way to convert to floating point.
9931 * textprop.c (set_text_properties_1): Rewrite for clarity,
9932 and to avoid GCC warning about integer overflow.
9934 * intervals.h (struct interval): Use EMACS_INT for members
9935 where EMACS_UINT might cause problems. See
9936 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9937 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9938 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9940 (offset_intervals): Tell GCC not to worry about length overflow
9941 when negating a negative length.
9943 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9944 (overrun_check_free): Likewise.
9946 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9947 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9950 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9951 (gnutls_make_error): Rename local to avoid shadowing.
9952 (gnutls_emacs_global_deinit): ifdef out; not used.
9953 (Fgnutls_boot): Use const for pointer to readonly storage.
9954 Comment out unused local. Fix pointer signedness problems.
9956 * lread.c (openp): Don't stuff size_t into an 'int'.
9957 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9958 about possible signed overflow.
9960 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9961 (GDK_KEY_g): Don't define if already defined.
9962 (xg_prepare_tooltip): Avoid pointer signedness problem.
9963 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9965 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9966 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9968 * xfns.c (Fx_window_property): Simplify a bit,
9969 to make a bit faster and to avoid GCC 4.6.0 warning.
9970 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9972 * fns.c (internal_equal): Don't assume size_t fits in int.
9974 * alloc.c (compact_small_strings): Tighten assertion a little.
9976 Replace pEd with more-general pI, and fix some printf arg casts.
9977 * lisp.h (pI): New macro, generalizing old pEd macro to other
9978 conversion specifiers. For example, use "...%"pI"d..." rather
9979 than "...%"pEd"...".
9980 (pEd): Remove. All uses replaced with similar uses of pI.
9981 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
9982 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9983 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9984 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9985 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9986 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9987 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9989 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9990 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9991 * print.c (safe_debug_print, print_object): Likewise.
9992 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9994 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9995 avoiding the 0 flag, which is not portable.
9996 * process.c (Fmake_network_process): Use pI to avoid cast.
9997 * region-cache.c (pp_cache): Likewise.
9998 * xdisp.c (decode_mode_spec): Likewise.
9999 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10000 behavior on 64-bit hosts with printf arg.
10001 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
10002 (x_stop_queuing_selection_requests): Likewise.
10003 (x_get_window_property): Don't truncate byte count to an 'int'
10006 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10007 here, since it parses constructs like leading '-' and spaces,
10008 which are not wanted; and it overflows with large numbers.
10009 Instead, simply match F[0-9]+, which is what is wanted anyway.
10011 * alloc.c: Remove unportable assumptions about struct layout.
10012 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10013 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10014 (allocate_vectorlike, make_pure_vector): Use the new macros,
10015 plus offsetof, to remove unportable assumptions about struct layout.
10016 These assumptions hold on all porting targets that I know of, but
10017 they are not guaranteed, they're easy to remove, and removing them
10018 makes further changes easier.
10020 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10021 This doesn't fix a bug but makes the code clearer.
10022 (string_overrun_cookie): Now const. Use initializers that
10023 don't formally overflow signed char, to avoid warnings.
10024 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10025 can cause Emacs to crash when string overrun checking is enabled.
10026 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10027 multiple of sizeof (EMACS_INT); it need not be, if
10028 alignof(EMACS_INT) < sizeof (EMACS_INT).
10029 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
10031 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
10033 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10035 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10037 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
10038 supposed to be handshaking. (Bug#8556)
10039 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10041 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
10043 * lisp.h (Qdebug): List symbol.
10044 * eval.c (Qdebug): Restore global linkage.
10045 * keyboard.c (debug-on-event): New variable.
10046 (handle_user_signal): Break into debugger when debug-on-event
10047 matches the current signal symbol.
10049 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10051 * alloc.c (check_sblock, check_string_bytes)
10052 (check_string_free_list): Convert to standard C.
10054 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10056 * w32.c (emacs_gnutls_push): Fix typo.
10058 2011-04-25 Eli Zaretskii <eliz@gnu.org>
10060 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10061 "cast to pointer from integer of different size".
10063 Improve doprnt and its use in verror. (Bug#8545)
10064 * doprnt.c (doprnt): Document the set of format control sequences
10065 supported by the function. Use SAFE_ALLOCA instead of always
10068 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10069 is one byte too soon. Don't use xrealloc; instead xfree and
10072 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10074 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10077 * gnutls.c: Renamed global_initialized to
10078 gnutls_global_initialized. Added internals for the
10079 :verify-hostname-error, :verify-error, and :verify-flags
10080 parameters of `gnutls-boot' and documented those parameters in the
10081 docstring. Start callback support.
10082 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10083 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10084 on error. Return error code.
10085 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10086 (emacs_gnutls_read): Likewise.
10087 (Fgnutls_boot): Return handshake error code.
10088 (emacs_gnutls_handle_error): New function.
10089 (wsaerror_to_errno): Likewise.
10091 * w32.h (emacs_gnutls_pull): Add prototype.
10092 (emacs_gnutls_push): Likewise.
10094 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10095 (emacs_gnutls_push): Likewise.
10097 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10099 * process.c (wait_reading_process_output): Check if GnuTLS
10100 buffered some data internally if no FDs are set for TLS
10103 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10104 (LIBS): Link to USER_LIBS.
10105 ($(BLD)/gnutls.$(0)): New target.
10107 2011-04-24 Eli Zaretskii <eliz@gnu.org>
10109 * xdisp.c (handle_single_display_spec): Rename the
10110 display_replaced_before_p argument into display_replaced_p, to
10111 make it consistent with the commentary. Fix typos in the
10114 * textprop.c (syms_of_textprop): Remove dead code.
10115 (copy_text_properties): Delete obsolete commentary about an
10116 interface that was deleted long ago. Fix typos in the description
10119 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10120 to changes in oldXMenu/XMenu.h from 2011-04-16.
10121 <menu_help_message, prev_menu_help_message>: Constify.
10122 (IT_menu_make_room): menu->help_text is now `const char **';
10125 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10126 to changes in oldXMenu/XMenu.h from 2011-04-16.
10127 (struct XMenu): Declare `help_text' `const char **'.
10129 * xfaces.c <Qunspecified>: Make extern again.
10131 * syntax.c: Include sys/types.h before including regex.h, as
10134 * doc.c (get_doc_string): Improve the format passed to `error'.
10136 * doprnt.c (doprnt): Improve commentary.
10138 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10140 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10143 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10144 changes in globals.h immediately force recompilation.
10145 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10146 $(CURDIR)/s/ms-w32.h.
10147 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
10149 * character.c (Fchar_direction): Function deleted.
10150 (syms_of_character): Don't defsubr it.
10151 <char-direction-table>: Deleted.
10153 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10155 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10156 * doprnt.c: Include limits.h.
10157 (SIZE_MAX): New macro.
10158 (doprnt): Return a size_t value. 2nd arg is now size_t.
10159 Many local variables are now size_t instead of int or unsigned.
10160 Improve overflow protection. Support `l' modifier for integer
10161 conversions. Support %l conversion. Don't assume an EMACS_INT
10162 argument for integer conversions and for %c.
10164 * lisp.h (doprnt): Restore prototype.
10166 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10167 $(SRC)/character.h.
10169 * Makefile.in (base_obj): Add back doprnt.o.
10171 * deps.mk (doprnt.o): Add back prerequisites.
10172 (callint.o): Depend on character.h.
10174 * eval.c (internal_lisp_condition_case): Include the handler
10175 representation in the error message.
10176 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10177 when breaking from the loop.
10179 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10181 * callint.c (Fcall_interactively): When displaying error message
10182 about invalid control letter, pass the character's codepoint, not
10183 a pointer to its multibyte form. Improve display of the character
10184 in octal and display also its hex code.
10186 * character.c (char_string): Use %x to display the (unsigned)
10187 codepoint of an invalid character, to avoid displaying a bogus
10190 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10191 `error', not SYMBOL_NAME itself.
10193 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10194 character arguments to `error'.
10196 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10197 to `error' in error message about FINAL_CHAR argument. Make sure
10198 FINAL_CHAR is a character, and use %c when it is passed as
10199 argument to `error'.
10201 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10203 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10205 * w32.c: Include <time.h>.
10206 (sys_localtime): New function.
10208 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
10210 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10212 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
10214 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
10216 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10217 zombies (Bug#8467).
10219 2011-04-19 Eli Zaretskii <eliz@gnu.org>
10221 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10222 gl_state.e_property when gl_state.object is Qt.
10224 * insdel.c (make_gap_larger): Remove limitation of buffer size
10227 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
10229 * xdisp.c (lookup_glyphless_char_display)
10230 (produce_glyphless_glyph): Handle cons cell entry in
10231 glyphless-char-display.
10232 (Vglyphless_char_display): Document it.
10234 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10235 glyphless-char-display.
10237 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
10239 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10241 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10243 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10244 definition for no-X builds.
10246 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
10248 Static checks with GCC 4.6.0 and non-default toolkits.
10250 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10252 * process.c (keyboard_bit_set): Define only if SIGIO.
10253 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10254 (send_process): Repair possible setjmp clobbering.
10256 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10258 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10260 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10262 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10263 Define only if needed.
10265 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10266 by pacifying GCC about it. Maybe it's time to retire it?
10267 * xfaces.c (USG, __TIMEVAL__): Likewise.
10269 * dispextern.h (struct redisplay_interface): Rename param
10270 to avoid shadowing.
10271 * termhooks.h (struct terminal): Likewise.
10272 * xterm.c (xembed_send_message): Likewise.
10274 * insdel.c (make_gap_smaller): Define only if
10275 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10277 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10280 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10281 so that we aren't warned about unused symbols.
10283 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10285 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
10287 * xfns.c (x_real_positions): Mark locals as initialized.
10289 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10291 * xterm.c: Fix problems found by static analysis with other toolkits.
10292 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
10293 (x_dispatch_event): Declare static if USE_GTK, and
10294 define if USE_GTK || USE_X_TOOLKIT.
10295 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
10296 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
10297 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10298 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
10300 * xmenu.c (menu_help_callback): Pointer type fixes.
10301 Use const pointers when pointing at readonly data. Avoid pointer
10302 signedness clashes.
10303 (FALSE): Remove unused macro.
10304 (update_frame_menubar): Remove unused decl.
10306 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10308 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10309 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10310 (single_menu_item): Rename local to avoid shadowing.
10312 * keyboard.c (make_lispy_event): Remove unused local var.
10314 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10315 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10317 * bitmaps: Change bitmaps from unsigned char back to the X11
10318 compatible char. Avoid the old compiler warnings about
10319 out-of-range initializers by using, for example, '\xab' rather
10322 * xgselect.c (xgselect_initialize): Check vs interface
10323 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10325 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10327 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10328 to read-only memory.
10330 * fns.c (vector): Remove; this old hack is no longer needed.
10332 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
10334 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
10336 * xrdb.c (x_load_resources): Omit unused local.
10338 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
10339 (x_window): Rename locals to avoid shadowing.
10340 (USG): Use the kludged USG macro, to pacify gcc.
10342 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
10343 (x_term_init): Remove local to avoid shadowing.
10345 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
10347 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10348 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10350 2011-04-16 Eli Zaretskii <eliz@gnu.org>
10352 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10354 Fix regex.c, syntax.c and friends for buffers > 2GB.
10355 * syntax.h (struct gl_state_s): Declare character position members
10358 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10360 * textprop.c (verify_interval_modification, interval_of):
10361 Declare arguments EMACS_INT.
10363 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10366 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10368 * indent.c (Fvertical_motion): Local variable it_start is now
10371 * regex.c (re_match, re_match_2, re_match_2_internal)
10372 (bcmp_translate, regcomp, regexec, print_double_string)
10373 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10374 (re_compile_pattern, re_exec): Declare arguments and local
10375 variables `size_t' and `ssize_t' and return values `regoff_t', as
10377 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10378 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10379 <compile_stack_type>: `size' and `avail' are now `size_t'.
10381 * regex.h <regoff_t>: Use ssize_t, not int.
10382 (re_search, re_search_2, re_match, re_match_2): Arguments that
10383 specify buffer/string position and length are now ssize_t and
10384 size_t. Return type is regoff_t.
10386 2011-04-16 Ben Key <bkey76@gmail.com>
10388 * nsfont.m: Fixed bugs in ns_get_family and
10389 ns_descriptor_to_entity that were caused by using free to
10390 deallocate memory blocks that were allocated by xmalloc (via
10391 xstrdup). This caused Emacs to crash when compiled with
10392 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10393 --enable-checking=xmallocoverrun). xfree is now used to
10394 deallocate these memory blocks.
10396 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
10398 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10400 emacs_write: Accept and return EMACS_INT for sizes.
10401 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10403 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10404 Accept and return EMACS_INT.
10405 (emacs_gnutls_write): Return the number of bytes written on
10407 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
10408 (emacs_read, emacs_write): Remove check for negative size, as the
10409 Emacs source code has been audited now.
10410 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10411 (emacs_read, emacs_write): Use it.
10412 * process.c (send_process): Adjust to the new signatures of
10413 emacs_write and emacs_gnutls_write. Do not attempt to store
10414 a byte offset into an 'int'; it might overflow.
10415 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
10417 * sound.c: Don't assume sizes fit in 'int'.
10418 (struct sound_device.period_size, alsa_period_size):
10419 Return EMACS_INT, not int.
10420 (struct sound_device.write, vox_write, alsa_write):
10421 Accept EMACS_INT, not int.
10422 (wav_play, au_play): Use EMACS_INT to store sizes and to
10423 record read return values.
10425 2011-04-15 Ben Key <bkey76@gmail.com>
10427 * keyboard.c (Qundefined): Don't declare static since it is used
10429 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10430 static since they are used in nsfont.m.
10432 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10434 * process.c (Qprocessp): Don't declare static.
10435 * lisp.h (Qprocessp): Declare again.
10437 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
10439 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10441 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10443 Improve C-level modularity by making more things 'static'.
10445 Don't publish debugger-only interfaces to other modules.
10446 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10447 (verify_bytepos, count_markers): Move decls to the only modules
10449 * region-cache.h (pp_cache): Likewise.
10450 * window.h (check_all_windows): Likewise.
10451 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10453 * sysdep.c (croak): Now static, if
10454 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10455 * syssignal.h (croak): Declare only if not static.
10457 * alloc.c (refill_memory_reserve): Now static if
10458 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10459 * lisp.h (refill_memory_reserve): Declare only if not static.
10461 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10462 Define only if USE_LUCID.
10464 * xrdb.c (x_customization_string, x_rm_string): Now static.
10466 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10467 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10469 * xdisp.c (draw_row_with_mouse_face): Now static.
10470 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10472 * window.h (check_all_windows): Mark externally visible.
10474 * window.c (window_deletion_count): Now static.
10476 * undo.c: Make symbols static if they're not exported.
10477 (last_undo_buffer, last_boundary_position, pending_boundary):
10480 * textprop.c (interval_insert_behind_hooks): Now static.
10481 (interval_insert_in_front_hooks): Likewise.
10483 * term.c: Make symbols static if they're not exported.
10484 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10485 (max_frame_lines, tty_set_terminal_modes):
10486 (tty_reset_terminal_modes, tty_turn_off_highlight):
10487 (get_tty_terminal): Now static.
10488 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10489 * termhooks.h (term_mouse_moveto): Do not declare if
10490 HAVE_WINDOW_SYSTEM.
10491 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10492 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10494 * sysdep.c: Make symbols static if they're not exported.
10495 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10497 (sigprocmask_set, full_mask): Remove; unused.
10498 (wait_debugging): Mark as visible.
10499 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10500 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10502 * syntax.c (syntax_temp): Define only if !__GNUC__.
10504 * sound.c (current_sound_device, current_sound): Now static.
10506 * search.c (searchbufs, searchbuf_head): Now static.
10508 * scroll.c (scroll_cost): Remove; unused.
10509 * dispextern.h (scroll_cost): Remove decl.
10511 * region-cache.h (pp_cache): Mark as externally visible.
10513 * process.c: Make symbols static if they're not exported.
10514 (process_tick, update_tick, create_process, chan_process):
10515 (Vprocess_alist, proc_buffered_char, datagram_access):
10516 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10517 (deactivate_process): Mark defn as static, as well as decl.
10518 * lisp.h (create_process): Remove decl.
10519 * process.h (chan_process, Vprocess_alist): Remove decls.
10521 * print.c: Make symbols static if they're not exported.
10522 (print_depth, new_backquote_output, being_printed, print_buffer):
10523 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10524 (print_interval, print_number_index, initial_stderr_stream):
10526 * lisp.h (Fprinc): Remove decl.
10527 (debug_output_compilation_hack): Mark as externally visible.
10529 * sysdep.c (croak): Move decl from here to syssignal.h.
10530 * syssignal.h (croak): Put it here, so the API can be checked when
10531 'croak' is called from dissociate_if_controlling_tty.
10533 * minibuf.c: Make symbols static if they're not exported.
10534 (minibuf_save_list, choose_minibuf_frame): Now static.
10535 * lisp.h (choose_minibuf_frame): Remove decl.
10537 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10539 * lread.c: Make symbols static if they're not exported.
10540 (read_objects, initial_obarray, oblookup_last_bucket_number):
10542 (make_symbol): Remove; unused.
10543 * lisp.h (initial_obarray, make_symbol): Remove decls.
10545 * keyboard.c: Make symbols static if they're not exported.
10546 (single_kboard, recent_keys_index, total_keys, recent_keys):
10547 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10548 (this_single_command_key_start, echoing, last_auto_save):
10549 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10550 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10551 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10552 (Vlispy_mouse_stem, double_click_count):
10554 (force_auto_save_soon): Define only if SIGDANGER.
10555 (ignore_mouse_drag_p): Now static if
10556 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10557 (print_help): Remove; unused.
10558 (stop_character, last_timer_event): Mark as externally visible.
10559 * keyboard.h (ignore_mouse_drag_p): Declare only if
10560 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10561 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10562 * lisp.h (echoing): Remove decl.
10563 (force_auto_save_soon): Declare only if SIGDANGER.
10564 * xdisp.c (redisplay_window): Simplify code, to make it more
10565 obvious that ignore_mouse_drag_p is not accessed if !defined
10566 USE_GTK && !defined HAVE_NS.
10568 * intervals.c: Make symbols static if they're not exported.
10569 (merge_properties_sticky, merge_interval_right, delete_interval):
10571 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10573 * insdel.c: Make symbols static if they're not exported.
10574 However, leave prepare_to_modify_buffer alone. It's never
10575 called from outside this function, but that appears to be a bug.
10576 (combine_after_change_list, combine_after_change_buffer):
10577 (adjust_after_replace, signal_before_change): Now static.
10578 (adjust_after_replace_noundo): Remove; unused.
10579 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
10580 (signal_before_change): Remove decls.
10582 * indent.c (val_compute_motion, val_vmotion): Now static.
10584 * image.c: Make symbols static if they're not exported.
10585 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10587 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10588 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10590 * fringe.c (standard_bitmaps): Now static.
10591 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10593 * frame.c: Make symbols static if they're not exported.
10594 (x_report_frame_params, make_terminal_frame): Now static.
10595 (get_frame_param): Now static, unless HAVE_NS.
10596 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10597 (x_get_resource_string): Remove; not used.
10598 * frame.h (make_terminal_frame, x_report_frame_params):
10599 (x_get_resource_string); Remove decls.
10600 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10601 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10603 * font.c, fontset.c: Make symbols static if they're not exported.
10604 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10605 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10606 * font.c (font_close_object): Now static.
10607 * font.h (font_close_object): Remove.
10608 * fontset.c (FONTSET_OBJLIST): Remove.
10609 (free_realized_fontset) #if-0 the body, which does nothing.
10610 (face_suitable_for_char_p): #if-0, as it's never called.
10611 * fontset.h (face_suitable_for_char_p): Remove decl.
10612 * xfaces.c (face_at_string_position):
10613 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
10614 since 0 is always ASCII.
10616 * fns.c (weak_hash_tables): Now static.
10618 * fileio.c: Make symbols static if they're not exported.
10619 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10620 (Vwrite_region_annotation_buffers): Now static.
10622 * eval.c: Make symbols static if they're not exported.
10623 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10624 * lisp.h (backtrace_list): Remove decl.
10626 * emacs.c: Make symbols static if they're not exported.
10627 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10628 (fatal_error_code, fatal_error_signal_hook, standard_args):
10630 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10631 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10632 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10633 * lisp.h (fatal_error_signal_hook): Remove decl.
10634 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10636 * editfns.c: Move a (normally-unused) function to its only use.
10637 * editfns.c, lisp.h (get_operating_system_release): Remove.
10638 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10639 worth the hassle of breaking this out.
10641 * xterm.c: Make symbols static if they're not exported.
10642 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10643 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10644 (x_destroy_window, x_delete_display):
10646 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10647 (x_mouse_leave): Remove; unused.
10648 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10649 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10650 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10652 (x_mouse_leave): Declare only if WINDOWSNT.
10653 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10654 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10657 * ftxfont.c: Make symbols static if they're not exported.
10658 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10660 * font.h (ftxfont_driver): Likewise.
10662 * xfns.c: Make symbols static if they're not exported.
10663 (x_last_font_name, x_display_info_for_name):
10664 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10665 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10666 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10667 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10668 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10669 (last_show_tip_args): Now static.
10670 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10671 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10672 (x_screen_planes): Remove; unused.
10673 * dispextern.h (x_screen_planes): Remove decl.
10675 * dispnew.c: Make symbols static if they're not exported.
10676 * dispextern.h (redraw_garbaged_frames, scrolling):
10677 (increment_row_positions): Remove.
10678 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10679 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10681 (redraw_garbaged_frames): Remove; unused.
10683 * xfaces.c: Make symbols static if they're not exported.
10684 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10686 * xterm.h (defined_color): Remove decls.
10687 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10688 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10689 (menu_face_changed_default, defined_color, free_realized_face):
10690 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10691 (ascii_face_of_lisp_face): Remove; unused.
10693 * xdisp.c: Make symbols static if they're not exported.
10694 * dispextern.h (scratch_glyph_row, window_box_edges):
10695 (glyph_to_pixel_coords, set_cursor_from_row):
10696 (get_next_display_element, set_iterator_to_next):
10697 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10698 (show_mouse_face): Remove decls
10699 * frame.h (message_buf_print): Likewise.
10700 * lisp.h (pop_message, set_message, check_point_in_composition):
10702 * xterm.h (set_vertical_scroll_bar): Likewise.
10703 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10704 (message_buf_print, scratch_glyph_row, displayed_buffer):
10705 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10706 (get_next_display_element, show_mouse_face, window_box_edges):
10707 (frame_to_window_pixel_xy, check_point_in_composition):
10708 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10709 (glyph_to_pixel_coords): Remove; unused.
10711 * dired.c (file_name_completion): Now static.
10713 * dbusbind.c (xd_in_read_queued_messages): Now static.
10715 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10716 * data.c (circular_list_error): Remove.
10718 * commands.h (last_point_position, last_point_position_buffer):
10719 (last_point_position_window): Remove decls.
10720 * keyboard.c: Make these variables static.
10722 * coding.h (coding, code_convert_region, encode_coding_gap):
10724 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10725 (iso_code_class, detect_coding, code_convert_region): Now static.
10726 (encode_coding_gap): Remove; unused.
10728 * chartab.c (chartab_chars, chartab_bits): Now static.
10730 * charset.h (charset_iso_8859_1): Remove decl.
10731 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10734 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10735 * ccl.c (Vccl_program_table): Now static.
10736 (check_ccl_update): Remove; unused.
10738 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10739 * category.h: ... from here.
10740 * category.c (check_category_table, set_category_set): Now static.
10742 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10743 * lisp.h: Remove these decls.
10745 * buffer.c (buffer_count): Remove unused var.
10747 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10748 so that it's not optimized away.
10749 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10750 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10751 exported only to the debugger.
10753 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
10754 * atimer.h (run_all_atimers): Remove; not exported.
10756 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10757 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10758 was inaccessible from Lisp.
10759 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10760 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10762 alloc.c: Import and export fewer symbols, and remove unused items.
10763 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10765 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10766 it's not optimized away by whole-program optimization.
10767 (message_enable_multibyte, free_misc): Remove.
10768 (catchlist, handlerlist, mark_backtrace):
10769 Declare only if BYTE_MARK_STACK.
10770 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10771 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10772 (message_enable_multibyte): Remove decl.
10773 (free_misc, interval_free_list, float_block, float_block_index):
10774 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10775 (cons_free_list, last_marked_index):
10777 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10778 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10779 (mark_backtrace): Define only if BYTE_MARK_STACK.
10780 * xdisp.c (message_enable_multibyte): Now static.
10782 Declare Lisp_Object Q* variables to be 'static' if not exported.
10783 This makes it easier for human readers (and static analyzers)
10784 to see whether these variables are used from other modules.
10785 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10786 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10787 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10788 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10789 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10790 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10791 * xmenu.c, xselect.c:
10792 Declare Q* vars static if they are not used in other modules.
10793 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10794 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10795 Remove decls of unexported vars.
10796 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10798 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10800 Make Emacs functions such as Fatom 'static' by default.
10801 This makes it easier for human readers (and static analyzers)
10802 to see whether these functions can be called from other modules.
10803 DEFUN now defines a static function. To make the function external
10804 so that it can be used in other C modules, use the new macro DEFUE.
10805 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10806 (Finit_image_library):
10807 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10808 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10809 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10810 Remove decls, since these functions are now static.
10811 (Funintern, Fget_internal_run_time): New decls, since these functions
10812 were already external.
10814 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10815 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10816 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10817 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10818 * keyboard.c, keymap.c, lread.c:
10819 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10820 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10821 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10822 Mark functions with DEFUE instead of DEFUN,
10823 if they are used in other modules.
10824 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10825 decls for now-static functions.
10826 * buffer.h (Fdelete_overlay): Remove decl.
10827 * callproc.c (Fgetenv_internal): Mark as internal.
10828 * composite.c (Fremove_list_of_text_properties): Remove decl.
10829 (Fcomposition_get_gstring): New forward static decl.
10830 * composite.h (Fcomposite_get_gstring): Remove decl.
10831 * dired.c (Ffile_attributes): New forward static decl.
10832 * doc.c (Fdocumntation_property): New forward static decl.
10833 * eval.c (Ffetch_bytecode): New forward static decl.
10834 (Funintern): Remove extern decl; now in .h file where it belongs.
10835 * fileio.c (Fmake_symbolic_link): New forward static decl.
10836 * image.c (Finit_image_library): New forward static decl.
10837 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10838 * intervals.h (Fprevious_property_change):
10839 (Fremove_list_of_text_properties): Remove decls.
10840 * keyboard.c (Fthis_command_keys): Remove decl.
10841 (Fcommand_execute): New forward static decl.
10842 * keymap.c (Flookup_key): New forward static decl.
10843 (Fcopy_keymap): Now static.
10844 * keymap.h (Flookup_key): Remove decl.
10845 * process.c (Fget_process): New forward static decl.
10846 (Fprocess_datagram_address): Mark as internal.
10847 * syntax.c (Fsyntax_table_p): New forward static decl.
10848 (skip_chars): Remove duplicate decl.
10849 * textprop.c (Fprevious_property_change): New forward static decl.
10850 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10852 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10853 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10855 * editfns.c (Fformat): Remove unreachable code.
10857 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10859 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10862 2011-04-13 Eli Zaretskii <eliz@gnu.org>
10864 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10865 when at ZV. (Bug#8487)
10867 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10869 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10871 * keyboard.c (parse_tool_bar_item): Likewise.
10872 * sound.c (sound_cleanup, alsa_close): Likewise.
10873 * termcap.c (tgetent): Likewise.
10874 * xfns.c (x_default_font_parameter): Likewise.
10875 * xsettings.c (read_and_apply_settings): Likewise.
10877 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10878 (overrun_check_free): Protoize.
10880 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10882 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10883 since callers should never pass a negative size.
10884 Change the signature to match that of plain 'read' and 'write'; see
10885 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10886 * lisp.h: Update prototypes of emacs_write and emacs_read.
10888 2011-04-11 Eli Zaretskii <eliz@gnu.org>
10890 * xdisp.c (redisplay_window): Don't try to determine the character
10891 position of the scroll margin if the window start point w->startp
10892 is outside the buffer's accessible region. (Bug#8468)
10894 2011-04-10 Eli Zaretskii <eliz@gnu.org>
10896 Fix write-region and its subroutines for buffers > 2GB.
10897 * fileio.c (a_write, e_write): Modify declaration of arguments and
10898 local variables to support buffers larger than 2GB.
10899 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10901 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10902 argument, local variables, and return value.
10904 * lisp.h: Update prototypes of emacs_write and emacs_read.
10906 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10908 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
10910 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10912 Fix more problems found by GCC 4.6.0's static checks.
10914 * xdisp.c (vmessage): Use a better test for character truncation.
10916 * charset.c (load_charset_map): <, not <=, for optimization,
10917 and to avoid potential problems with integer overflow.
10918 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
10919 * casetab.c (set_identity, shuffle): Likewise.
10920 * editfns.c (Fformat): Likewise.
10921 * syntax.c (skip_chars): Likewise.
10923 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10924 This also lets GCC 4.6.0 generate slightly better loop code.
10926 * callint.c (Fcall_interactively): <, not <=, for optimization.
10927 (Fcall_interactively): Count the number of arguments produced,
10928 not the number of arguments given. This is simpler and lets GCC
10929 4.6.0 generate slightly better code.
10931 * ftfont.c: Distingish more carefully between FcChar8 and char.
10932 The previous code passed unsigned char * to a functions like
10933 strlen and xstrcasecmp that expect char *, which does not
10934 conform to the C standard.
10935 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10936 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10937 char * when the C standard requires it.
10939 * keyboard.c (read_char): Remove unused var.
10941 * eval.c: Port to Windows vsnprintf (Bug#8435).
10942 Include <limits.h>.
10943 (SIZE_MAX): Define if the headers do not.
10944 (verror): Do not give up if vsnprintf returns a negative count.
10945 Instead, grow the buffer. This ports to Windows vsnprintf, which
10946 does not conform to C99. Problem reported by Eli Zaretskii.
10947 Also, simplify the allocation scheme, by avoiding the need for
10948 calling realloc, and removing the ALLOCATED variable.
10950 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10952 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10953 But keep the doprint source code for now, as we might revamp it
10954 and use it again (Bug#8435).
10955 * lisp.h (doprnt): Remove.
10956 * Makefile.in (base_obj): Remove doprnt.o.
10957 * deps.mk (doprnt.o): Remove.
10959 error: Print 32- and 64-bit integers portably (Bug#8435).
10960 Without this change, on typical 64-bit hosts error ("...%d...", N)
10961 was used to print both 32- and 64-bit integers N, which relied on
10962 undefined behavior.
10963 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
10964 * lisp.h (error, verror): Mark as printf-like functions.
10965 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10966 Report overflow in size calculations when allocating printf buffer.
10967 Do not truncate output string at its first null byte.
10968 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10969 Truncate the output at a character boundary, since vsnprintf does not
10971 * charset.c (check_iso_charset_parameter): Convert internal
10972 character to string before calling 'error', since %c now has the
10974 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10975 overflow when computing char to be passed to 'error'. Do not
10976 pass Lisp_Object to 'error'; pass the integer instead.
10977 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10978 formatted with plain %d.
10980 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10982 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10984 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10986 * xterm.c (x_catch_errors): Remove duplicate declaration.
10988 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10990 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10992 2011-04-10 Jim Meyering <meyering@redhat.com>
10994 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10995 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10996 return ssize_t not "int", and use size_t as the buffer length.
10997 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10998 * gnutls.h: Update declarations.
10999 * process.c (read_process_output): Use ssize_t, to match.
11000 (send_process): Likewise.
11002 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
11004 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11006 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
11008 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11009 Use unsigned char, to match FcChar8 type definition.
11011 * xterm.c (handle_one_xevent):
11012 * xmenu.c (create_and_show_popup_menu):
11013 * xselect.c (x_decline_selection_request)
11014 (x_reply_selection_request): Avoid type-punned deref of X events.
11016 2011-04-09 Eli Zaretskii <eliz@gnu.org>
11018 Fix some uses of `int' instead of EMACS_INT.
11019 * search.c (string_match_1, fast_string_match)
11020 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11021 (scan_buffer, find_next_newline_no_quit)
11022 (find_before_next_newline, search_command, Freplace_match)
11023 (Fmatch_data): Make some `int' variables be EMACS_INT.
11025 * xdisp.c (display_count_lines): 3rd argument and return value now
11026 EMACS_INT. All callers changed.
11027 (pint2hrstr): Last argument is now EMACS_INT.
11029 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11030 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11031 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11032 (decode_coding_utf_16, decode_coding_emacs_mule)
11033 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11034 (decode_coding_ccl, decode_coding_charset)
11035 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11036 (decode_coding_iso_2022, decode_coding_emacs_mule)
11037 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11038 <char_offset, last_offset>: Declare EMACS_INT.
11039 (encode_coding_utf_8, encode_coding_utf_16)
11040 (encode_coding_emacs_mule, encode_invocation_designation)
11041 (encode_designation_at_bol, encode_coding_iso_2022)
11042 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11043 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11045 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11046 (encode_invocation_designation): Last argument P_NCHARS is now
11048 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11049 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11051 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11054 * ccl.c (Fccl_execute_on_string): Declare some variables
11057 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
11059 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11061 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11063 * process.c (Fformat_network_address): Doc fix.
11065 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11067 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
11069 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
11071 * keyboard.c (read_char): Call Lisp function help-form-show,
11072 instead of using internal_with_output_to_temp_buffer.
11073 (Qhelp_form_show): New var.
11074 (syms_of_keyboard): Use DEFSYM macro.
11076 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11078 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11080 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
11082 * process.c (Flist_processes): Remove to Lisp.
11083 (list_processes_1): Delete.
11085 2011-04-06 Eli Zaretskii <eliz@gnu.org>
11087 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11089 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11091 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
11093 Fix more problems found by GCC 4.6.0's static checks.
11095 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11097 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11099 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
11101 * xdisp.c (vmessage): Mark as a printf-like function.
11103 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11105 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11107 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11108 printf-like functions.
11109 (tiff_load): Add casts to remove these marks before passing them
11110 to system-supplied API.
11112 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11114 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11115 This avoids several warnings with gcc -Wstrict-overflow.
11116 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11117 directly, rather than having caller test rule sign. This avoids
11118 some unnecessary tests.
11119 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11120 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11121 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
11123 * xfont.c (xfont_text_extents): Remove var that was set but not used.
11124 (xfont_open): Avoid unnecessary tests.
11126 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11128 * composite.h, composite.c (composition_gstring_put_cache):
11129 Use EMACS_INT, not int, for length.
11131 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11132 breaking out part of COMPOSITION_DECODE_RULE.
11133 (COMPOSITION_DECODE_RULE): Use it.
11134 * composite.c (get_composition_id): Remove unused local vars,
11135 by using the new macro.
11137 * textprop.c (set_text_properties_1): Change while to do-while,
11138 since the condition is always true at first.
11140 * intervals.c (graft_intervals_into_buffer): Mark var as used.
11141 (interval_deletion_adjustment): Return unsigned value.
11144 * process.c (list_processes_1, create_pty, read_process_output):
11145 (exec_sentinel): Remove vars that were set but not used.
11146 (create_pty): Remove unnecessary "volatile"s.
11147 (Fnetwork_interface_info): Avoid possibility of int overflow.
11148 (read_process_output): Do adaptive read buffering even if carryover.
11149 (read_process_output): Simplify nbytes computation if buffered.
11151 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11153 * syntax.c (scan_words): Remove var that was set but not used.
11154 (update_syntax_table): Use unsigned instead of int.
11156 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
11157 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
11158 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
11160 * print.c (print_error_message): Avoid int overflow.
11162 * font.c (font_list_entities): Redo for clarity,
11163 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11165 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
11166 (font_score): Avoid potential overflow in diff calculation.
11168 * fns.c (substring_both): Remove var that is set but not used.
11169 (sxhash): Redo loop for clarity and to avoid wraparound warning.
11171 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11173 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11174 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11175 can always succeed if overflow has undefined behavior.
11177 * search.c (boyer_moore, wordify): Remove vars set but not used.
11178 (wordify): Omit three unnecessary tests.
11180 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11181 All callers changed. This avoids the need for an unused var.
11183 * casefiddle.c (casify_region): Remove var that is set but not used.
11185 * dired.c (file_name_completion): Remove var that is set but not used.
11187 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11189 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
11190 (Finsert_file_contents): Remove unnecessary code checking fd.
11192 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11193 Check for integer overflow on size calculations.
11195 * buffer.c (Fprevious_overlay_change): Remove var that is set
11198 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11199 Remove vars that are set but not used.
11200 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
11201 (timer_check_2): Mark vars as initialized.
11203 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11205 * image.c (lookup_image): Remove var that is set but not used.
11206 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
11208 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11209 that are set but not used.
11211 * xfns.c (make_invisible_cursor): Don't return garbage
11212 if XCreateBitmapFromData fails (Bug#8410).
11214 * xselect.c (x_get_local_selection, x_handle_property_notify):
11215 Remove vars that are set but not used.
11217 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
11218 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
11220 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11221 Remove var that is set but not used.
11222 (scroll_bar_windows_size): Now size_t, not int.
11223 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11224 Check for overflow.
11226 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11227 (map_tty_color) [!defined MSDOS]: Likewise.
11229 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11231 * coding.c: Remove vars that are set but not used.
11232 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11233 All callers changed.
11234 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11235 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11236 (decode_coding_charset): Remove vars that are set but not used.
11238 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11239 that is set but not used.
11241 * print.c (print_object): Remove var that is set but not used.
11243 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
11244 The gnulib version avoids calling malloc in the usual case,
11245 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11246 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11247 * filelock.c (current_lock_owner): Likewise.
11248 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11249 * sysdep.c: Include allocator.h, careadlinkat.h.
11250 (emacs_no_realloc_allocator): New static constant.
11251 (emacs_readlink): New function.
11252 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11253 ../lib/careadlinkat.h.
11255 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11257 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11258 first non-nil return value).
11260 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11262 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11263 if not defined (Bug#8403).
11265 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11267 * xdisp.c (display_count_lines): Remove parameter `start',
11268 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11269 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11270 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11271 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11272 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11273 and thereabouts. All callers changed.
11274 (get_per_char_metric): Remove parameter `f', unused since
11275 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11277 2011-04-02 Jim Meyering <meyering@redhat.com>
11279 do not dereference NULL upon failed strdup
11280 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11281 (ns_get_family): Likewise.
11283 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11285 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11287 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11289 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11292 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11294 Add lexical binding.
11296 * window.c (Ftemp_output_buffer_show): New fun.
11297 (Fsave_window_excursion):
11298 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11300 * lread.c (lisp_file_lexically_bound_p): New function.
11301 (Fload): Bind Qlexical_binding.
11302 (readevalloop): Remove `evalfun' arg.
11303 Bind Qinternal_interpreter_environment.
11304 (Feval_buffer): Bind Qlexical_binding.
11305 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11307 (syms_of_lread): Declare `lexical-binding'.
11309 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11311 * keyboard.c (eval_dyn): New fun.
11312 (menu_item_eval_property): Use it.
11314 * image.c (parse_image_spec): Use Ffunctionp.
11316 * fns.c (concat, mapcar1): Accept byte-code-functions.
11318 * eval.c (Fsetq): Handle lexical vars.
11319 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11320 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11321 (FletX, Flet): Obey lexical binding.
11322 (Fcommandp): Handle closures.
11323 (Feval): New `lexical' arg.
11324 (eval_sub): New function extracted from Feval. Use it almost
11325 everywhere where Feval was used. Look up vars in lexical env.
11327 (Ffunctionp): Move from subr.el.
11328 (Ffuncall): Handle closures.
11329 (apply_lambda): Remove `eval_flags'.
11330 (funcall_lambda): Handle closures and new byte-code-functions.
11331 (Fspecial_variable_p): New function.
11332 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11333 but without exporting it to Lisp.
11335 * doc.c (Fdocumentation, store_function_docstring):
11336 * data.c (Finteractive_form): Handle closures.
11338 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11341 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11343 (exec_byte_code): New function extracted from Fbyte_code to handle new
11344 calling convention for byte-code-functions. Add new byte-codes.
11346 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
11348 * alloc.c (Fmake_symbol): Init new `declared_special' field.
11350 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11352 * xdisp.c (redisplay_internal): Fix prototype.
11354 2011-03-31 Eli Zaretskii <eliz@gnu.org>
11356 * xdisp.c (SCROLL_LIMIT): New macro.
11357 (try_scrolling): Use it when setting scroll_limit.
11358 Limit scrolling to 100 screen lines.
11359 (redisplay_window): Even when falling back on "recentering",
11360 position point in the window according to scroll-conservatively,
11361 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11363 (try_scrolling): When point is above the window, allow searching
11364 as far as scroll_max, or one screenful, to compute vertical
11365 distance from PT to the scroll margin position. This prevents
11366 try_scrolling from unnecessarily failing when
11367 scroll-conservatively is set to a value slightly larger than the
11368 window height. Clean up the case of PT below the margin at bottom
11369 of window: scroll_max can no longer be INT_MAX. When aggressive
11370 scrolling is in use, don't let point enter the opposite scroll
11371 margin as result of the scroll.
11372 (syms_of_xdisp) <scroll-conservatively>: Document the
11373 threshold of 100 lines for never-recentering scrolling.
11375 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11377 * dispextern.h (move_it_by_lines):
11378 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11379 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11380 (message_log_check_duplicate): Remove parameters `prev_bol' and
11381 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11382 (redisplay_internal): Remove parameter `preserve_echo_area',
11383 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11385 * indent.c (Fvertical_motion):
11386 * window.c (window_scroll_pixel_based, Frecenter):
11387 Don't pass `need_y_p' to `move_it_by_lines'.
11389 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11391 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11392 steal a few bits to be more compact.
11393 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11394 Remove unneeded casts.
11396 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11398 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11400 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11401 binding" message (bug#7967).
11403 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11405 Fix more problems found by GCC 4.6.0's static checks.
11407 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11408 Remove unused local var.
11410 * editfns.c (Fmessage_box): Remove unused local var.
11412 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11413 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11414 Omit unused local vars.
11415 * window.c (shrink_windows): Omit unused local var.
11416 * menu.c (digest_single_submenu): Omit unused local var.
11417 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11418 Omit unused local var.
11420 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11421 Don't assume string length fits in int.
11422 (keyremap_step, read_key_sequence): Use size_t for sizes.
11423 (read_key_sequence): Don't check last_real_key_start redundantly.
11425 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11426 instead of alloca (Bug#8344).
11428 * eval.c (Fbacktrace): Don't assume nargs fits in int.
11429 (Fbacktrace_frame): Don't assume nframes fits in int.
11431 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11433 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11436 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11438 * cm.c (calccost): Turn while-do into do-while, for clarity.
11440 * keyboard.c (syms_of_keyboard): Use the same style as later
11441 in this function when indexing through an array. This also
11442 works around GCC bug 48267.
11444 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11446 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11448 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11449 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11451 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11452 This avoids undefined behavior on integer overflow, and is a bit
11453 more convenient anyway since it is compared to a size_t variable.
11455 Variadic C functions now count arguments with size_t, not int.
11456 This avoids an unnecessary limitation on 64-bit machines, which
11457 caused (substring ...) to crash on large vectors (Bug#8344).
11458 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11459 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
11460 All variadic functions and their callers changed accordingly.
11461 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11462 * data.c (arith_driver, float_arith_driver): Likewise.
11463 * editfns.c (general_insert_function): Likewise.
11464 * eval.c (struct backtrace.nargs, interactive_p)
11465 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11466 (funcall_lambda, mark_backtrace): Likewise.
11467 * fns.c (concat): Likewise.
11468 * frame.c (x_set_frame_parameters): Likewise.
11469 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11470 0 if not found, not -1. All callers changed.
11472 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11473 (stack_copy_size): Now size_t, not int.
11474 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11476 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11478 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11479 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11480 All callers changed.
11482 * lisp.h (multibyte_char_to_unibyte):
11483 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11484 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11485 * character.h (CHAR_TO_BYTE8):
11486 * cmds.c (internal_self_insert):
11487 * editfns.c (general_insert_function):
11488 * keymap.c (push_key_description):
11489 * search.c (Freplace_match):
11490 * xdisp.c (message_dolog, set_message_1): All callers changed.
11492 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11494 * keyboard.c (safe_run_hook_funcall): New function.
11495 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11496 don't set the hook to nil, but remove the offending function instead.
11497 (Qcommand_hook_internal): Remove, unused.
11498 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11499 Vcommand_hook_internal.
11501 * eval.c (enum run_hooks_condition): Remove.
11502 (funcall_nil, funcall_not): New functions.
11503 (run_hook_with_args): Call each function through a `funcall' argument.
11504 Remove `cond' argument, now redundant.
11505 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11506 (Frun_hook_with_args_until_failure): Adjust accordingly.
11507 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11509 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11511 * dispextern.h (string_buffer_position): Remove declaration.
11513 * print.c (strout): Remove parameter `multibyte', unused since
11514 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11516 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11517 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11518 All callers changed.
11520 * w32.c (_wsa_errlist): Use braces for struct initializers.
11522 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11523 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11524 All callers changed.
11525 (string_buffer_position): Likewise. Also, make static (it's never
11526 used outside xdisp.c).
11527 (cursor_row_p): Remove parameter `w', unused since
11528 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11529 (decode_mode_spec): Remove parameter `precision', introduced during
11530 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11531 All callers changed.
11533 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11535 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11537 2011-03-27 Anders Lindgren <andlind@gmail.com>
11539 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11540 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11541 (ns_update_auto_hide_menu_bar): New functions.
11542 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11543 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11544 ns_constrain_all_frames.
11545 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11546 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11548 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11550 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11552 2011-03-27 Glenn Morris <rgm@gnu.org>
11554 * syssignal.h: Replace RETSIGTYPE with void.
11555 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11556 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11557 Replace SIGTYPE with void everywhere.
11558 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11559 * s/template.h (SIGTYPE): Remove commented out definition.
11561 2011-03-26 Eli Zaretskii <eliz@gnu.org>
11563 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11564 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11566 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
11568 * w32.c (read_unc_volume): Use parameter `henum', instead of
11569 global variable `wget_enum_handle'.
11571 * keymap.c (describe_vector): Remove parameters `indices' and
11572 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11573 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11575 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11577 * keyboard.c (timer_check): Remove parameter `do_it_now',
11578 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11579 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11580 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11582 * keyboard.c (read_char):
11583 * w32menu.c (w32_menu_display_help):
11584 * xmenu.c (show_help_event, menu_help_callback):
11585 Adjust calls to `show_help_echo'.
11587 * gtkutil.c (xg_maybe_add_timer):
11588 * keyboard.c (readable_events):
11589 * process.c (wait_reading_process_output):
11590 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11592 * insdel.c (adjust_markers_gap_motion):
11593 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11594 (gap_left, gap_right): Don't call it.
11596 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
11598 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11599 incurred during fontification.
11601 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
11603 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11604 (DEFVAR_PER_BUFFER): Don't pass it.
11606 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11607 (scrolling_window): Don't pass it.
11609 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
11611 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11613 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11615 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11616 of variables specific to SELinux and computation of `encoded_absname'.
11618 * image.c (XPutPixel): Remove unused variable `height'.
11620 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11622 * unexw32.c (get_section_info): Remove unused variable `section'.
11624 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11625 (system_process_attributes): Remove unused variable `sess'.
11626 (sys_read): Remove unused variable `err'.
11628 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11629 (w32_wnd_proc): Remove unused variable `isdead'.
11630 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11631 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11632 (x_create_tip_frame): Remove unused variable `tem'.
11634 * w32inevt.c (w32_console_read_socket):
11635 Remove unused variable `no_events'.
11637 * w32term.c (x_draw_composite_glyph_string_foreground):
11638 Remove unused variable `width'.
11640 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
11642 * w32term.c (x_set_glyph_string_clipping):
11643 Don't pass uninitialized region to CombineRgn.
11645 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
11647 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11648 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11649 (Fx_close_connection): Remove unused variable `i'.
11651 * w32font.c (w32font_draw): Return number of glyphs.
11652 (w32font_open_internal): Remove unused variable `i'.
11653 (w32font_driver): Add missing initializer.
11655 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11656 (fill_in_menu): Remove unused variable `items_added'.
11658 * w32term.c (last_mouse_press_frame): Remove static global variable.
11659 (w32_clip_to_row): Remove unused variable `f'.
11660 (x_delete_terminal): Remove unused variable `i'.
11662 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11663 (NOTHING): Remove unused static global variable.
11664 (uniscribe_check_otf): Remove unused variable `table'.
11665 (uniscribe_font_driver): Add missing initializers.
11667 2011-03-23 Julien Danjou <julien@danjou.info>
11669 * term.c (Fsuspend_tty, Fresume_tty):
11670 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11671 * window.c (temp_output_buffer_show):
11672 * insdel.c (signal_before_change):
11673 * frame.c (Fhandle_switch_frame):
11674 * fileio.c (Fdo_auto_save):
11675 * emacs.c (Fkill_emacs):
11676 * editfns.c (save_excursion_restore):
11677 * cmds.c (internal_self_insert):
11678 * callint.c (Fcall_interactively):
11679 * buffer.c (Fkill_all_local_variables):
11680 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11682 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
11683 unconditionally since it does the check itself.
11685 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
11687 Fix more problems found by GCC 4.5.2's static checks.
11689 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11690 the first time through the loop, since we know p0 < p1 then.
11691 This also avoids a gcc -Wstrict-overflow warning.
11693 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11694 leading to a memory leak, possible in functions like
11695 load_charset_map_from_file that can allocate an unbounded number
11696 of objects (Bug#8318).
11698 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11699 that could (at least in theory) be that large.
11701 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11702 This is less likely to overflow, and avoids undefined behavior if
11703 overflow does occur. All callers changed. Use strtoul to scan
11704 for the unsigned long integer.
11705 (pint2hrstr): Simplify and tune code slightly.
11706 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
11708 * scroll.c (do_scrolling): Work around GCC bug 48228.
11709 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11711 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11712 This also avoids a warning with gcc -Wstrict-overflow.
11713 (validate_x_resource_name): Simplify count usage.
11714 This also avoids a warning with gcc -Wstrict-overflow.
11716 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11719 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
11721 * process.c (Fmake_network_process): Use socklen_t, not int,
11722 where POSIX says socklen_t is required in portable programs.
11723 This fixes a porting bug on hosts like 64-bit HP-UX, where
11724 socklen_t is wider than int (Bug#8277).
11725 (Fmake_network_process, server_accept_connection):
11726 (wait_reading_process_output, read_process_output):
11729 * process.c: Rename or move locals to avoid shadowing.
11730 (list_processes_1, Fmake_network_process):
11731 (read_process_output_error_handler, exec_sentinel_error_handler):
11732 Rename or move locals.
11733 (Fmake_network_process): Define label "retry_connect" only if needed.
11734 (Fnetwork_interface_info): Fix pointer signedness.
11735 (process_send_signal): Add cast to avoid pointer signedness problem.
11736 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
11737 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
11739 Make tparam.h and terminfo.c consistent.
11740 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11741 Include tparam.h instead, since it declares them.
11742 * cm.h (PC): Remove extern decl; tparam.h now does this.
11743 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11744 * terminfo.c: Include tparam.h, to check interfaces.
11745 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11746 (tparam): Adjust signature to match interface in tparam.h;
11747 this removes some undefined behavior. Check that outstring and len
11748 are zero, which they always are with Emacs.
11749 * tparam.h (PC, BC, UP): New extern decls.
11751 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
11752 (xftfont_open): Rename locals to avoid shadowing.
11754 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
11755 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11756 (OTF_TAG_SYM): Omit macro if not needed.
11757 (ftfont_list): Remove unused local.
11758 (get_adstyle_property, ftfont_pattern_entity):
11759 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11760 Rename locals to avoid shadowing.
11762 * xfont.c (xfont_list_family): Mark var as initialized.
11764 * xml.c (make_dom): Now static.
11766 * composite.c (composition_compute_stop_pos): Rename local to
11768 (composition_reseat_it): Remove unused locals.
11769 (find_automatic_composition, composition_adjust_point): Likewise.
11770 (composition_update_it): Mark var as initialized.
11771 (find_automatic_composition): Mark vars as initialized,
11772 with a FIXME (Bug#8290).
11774 character.h: Rename locals to avoid shadowing.
11775 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11776 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11777 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11778 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11779 to avoid shadowing.
11781 * textprop.c (property_change_between_p): Remove; unused.
11783 * intervals.c (interval_start_pos): Now static.
11785 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11787 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11788 Rename locals to avoid shadowing.
11790 * sound.c (wav_play, au_play, Fplay_sound_internal):
11791 Fix pointer signedness.
11792 (alsa_choose_format): Remove unused local var.
11793 (wav_play): Initialize a variable to 0, to prevent undefined
11794 behavior (Bug#8278).
11796 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11798 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11800 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11801 clobbering (Bug#8298).
11802 * sysdep.c (sys_subshell): Likewise.
11803 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
11805 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11806 This should get cleaned up, so that child_setup has the
11807 same signature on all platforms.
11809 * callproc.c (call_process_cleanup): Now static.
11810 (relocate_fd): Rename locals to avoid shadowing.
11812 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
11814 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11815 not to be necessary, and produces flickering.
11817 2011-03-20 Glenn Morris <rgm@gnu.org>
11819 * config.in: Remove file.
11821 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
11823 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11824 are now in src/globals.h.
11825 (syms_of_minibuf): Remove spurious & from previous change.
11827 2011-03-20 Leo Liu <sdl.web@gmail.com>
11829 * minibuf.c (completing-read-function): New variable.
11830 (completing-read-default): Rename from completing-read.
11831 (completing-read): Call completing-read-function.
11833 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11835 * xfaces.c (Fx_load_color_file):
11836 Read color file from absolute filename (bug#8250).
11838 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11840 * makefile.w32-in: Update dependencies.
11842 2011-03-17 Eli Zaretskii <eliz@gnu.org>
11844 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11846 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11848 Fix more problems found by GCC 4.5.2's static checks.
11850 * process.c (make_serial_process_unwind, send_process_trap):
11851 (sigchld_handler): Now static.
11853 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11854 That way, the code declares only the vars that it needs.
11855 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11856 * s/cygwin.h (PTY_ITERATION): Likewise.
11857 * s/darwin.h (PTY_ITERATION): Likewise.
11858 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11860 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11861 * process.c (allocate_pty): Don't declare stb unless it's needed.
11863 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
11864 (CONSTANTLIM): Remove; unused.
11865 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11866 Define only if needed.
11868 * unexelf.c (unexec): Name an expression,
11869 to avoid gcc -Wbad-function-cast warning.
11870 Use a different way to cause a compilation error if anyone uses
11871 n rather than nn, a way that does not involve shadowing.
11872 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
11874 * deps.mk (unexalpha.o): Remove; unused.
11876 New file unexec.h, the (simple) interface for unexec (Bug#8267).
11877 * unexec.h: New file.
11878 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11879 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11880 Depend on unexec.h.
11881 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11882 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11883 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
11884 Change as necessary to match prototype in unexec.h.
11886 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11888 (back_comment, skip_chars): Mark vars as initialized.
11890 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11891 Rename locals to avoid shadowing.
11893 * lread.c (read1): Rewrite so as not to use empty "else".
11894 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
11896 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11898 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11899 warning when compiling print.c.
11901 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11902 instead of using an uninitialized var.
11903 (font_sort_entities): Mark var as initialized.
11905 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11907 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11908 pointers to constants.
11909 (font_parse_fcname): Remove unused vars.
11910 (font_delete_unmatched): Now static.
11911 (font_get_spec): Remove; unused.
11912 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11913 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11914 Rename or move locals to avoid shadowing.
11916 * fns.c (require_nesting_list, require_unwind): Now static.
11917 (Ffillarray): Rename locals to avoid shadowing.
11919 * floatfns.c (domain_error2): Define only if needed.
11920 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
11922 * alloc.c (mark_backtrace): Move decl from here ...
11923 * lisp.h: ... to here, so that it can be checked.
11925 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
11926 (Fdefvar): Rewrite so as not to use empty "else".
11927 (lisp_indirect_variable): Name an expression,
11928 to avoid gcc -Wbad-function-cast warning.
11929 (Fdefvar): Rename locals to avoid shadowing.
11931 * callint.c (quotify_arg, quotify_args): Now static.
11932 (Fcall_interactively): Rename locals to avoid shadowing.
11933 Use const pointer when appropriate.
11935 * lisp.h (get_system_name, get_operating_system_release):
11936 Move decls here, to check interfaces.
11937 * process.c (get_operating_system_release): Move decl to lisp.h.
11938 * xrdb.c (get_system_name): Likewise.
11939 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11940 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11941 some of which prompt warnings from gcc -Wbad-function-cast.
11942 (Fformat_time_string, Fencode_time, Finsert_char):
11943 (Ftranslate_region_internal, Fformat):
11944 Rename or remove local vars to avoid shadowing.
11945 (Ftranslate_region_internal): Mark var as initialized.
11947 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11950 * lisp.h (eassert): Check that the argument compiles, even if
11951 ENABLE_CHECKING is not defined.
11953 * data.c (Findirect_variable): Name an expression, to avoid
11954 gcc -Wbad-function-cast warning.
11955 (default_value, arithcompare, arith_driver, arith_error): Now static.
11956 (store_symval_forwarding): Rename local to avoid shadowing.
11957 (Fmake_variable_buffer_local, Fmake_local_variable):
11958 Mark variables as initialized.
11959 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
11961 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
11962 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11963 Rename locals to avoid shadowing.
11964 (mark_stack): Move local variables into the #ifdef region where
11966 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11967 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11969 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11970 (GC_STRING_CHARS): Remove; not used.
11971 (Fmemory_limit): Cast sbrk's returned value to char *.
11973 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11974 avoids undefined behavior in theory.
11976 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11978 Use functions, not macros, for up- and down-casing (Bug#8254).
11979 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11980 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11981 to use the following functions instead of these macros.
11982 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11983 EMACS_INT, since callers assume the returned value fits in int.
11984 (upcase1): Likewise, for UPCASE_TABLE.
11985 (uppercasep, lowercasep, upcase): New static inline functions.
11986 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
11987 the race-condition problem in the old DOWNCASE.
11989 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11990 Rename locals to avoid shadowing.
11991 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
11992 (regex_compile, re_search_2, re_match_2_internal):
11993 Remove unused local vars.
11994 (FREE_VAR): Rewrite so as not to use empty "else",
11995 which gcc can warn about.
11996 (regex_compile, re_match_2_internal): Mark locals as initialized.
11997 (RETALLOC_IF): Define only if needed.
11998 (WORDCHAR_P): Likewise. This one is never needed, but is used
11999 only in a comment talking about a compiler bug, so put inside
12000 the #if 0 of that comment.
12001 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12002 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12005 * search.c (boyer_moore): Rename locals to avoid shadowing.
12006 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12007 (PREV_CHAR_BOUNDARY): Likewise.
12009 * search.c (simple_search): Remove unused var.
12011 * dired.c (compile_pattern): Move decl from here ...
12012 * lisp.h: ... to here, so that it can be checked.
12013 (struct re_registers): New forward decl.
12015 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12017 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12019 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12020 Rename locals to avoid shadowing.
12021 (Fvertical_motion): Mark locals as initialized.
12023 * casefiddle.c (casify_object, casify_region): Now static.
12024 (casify_region): Mark local as initialized.
12026 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12028 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12029 New macros, so that the caller can use some names other than
12030 gcpro1, gcpro2, etc.
12031 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12033 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12034 argument, for consistency with GCPRO2_VAR, etc: it is now the
12035 prefix of the variable, not the variable itself. All uses
12037 * dired.c (directory_files_internal, file_name_completion):
12038 Rename locals to avoid shadowing.
12040 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12041 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12042 dired.c's scmp function, had undefined behavior.
12043 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12044 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12045 * buffer.h: ... to here, because these macros use current_buffer,
12046 and the new implementation with inline functions needs to have
12047 current_buffer in scope now, rather than later when the macros
12049 (downcase, upcase1): New static inline functions.
12050 (DOWNCASE, UPCASE1): Reimplement using these functions.
12051 This avoids undefined behavior in expressions like
12052 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12053 from race conditions in accessing the global variables
12054 case_temp1 and case_temp2.
12055 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12056 * lisp.h (case_temp1, case_temp2): Remove their decls.
12057 * character.h (ASCII_CHAR_P): Move from here ...
12058 * lisp.h: ... to here, so that the inline functions mentioned
12059 above can use them.
12061 * dired.c (directory_files_internal_unwind): Now static.
12063 * fileio.c (file_name_as_directory, directory_file_name):
12064 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12066 (file_name_as_directory): Use const pointers when appropriate.
12067 (Fexpand_file_name): Likewise. In particular, newdir might
12068 point at constant storage, so make it a const pointer.
12069 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
12070 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12072 (Fset_file_times, Finsert_file_contents, auto_save_error):
12073 Rename locals to avoid shadowing.
12075 * minibuf.c (choose_minibuf_frame_1): Now static.
12076 (Ftry_completion, Fall_completions): Rename or remove locals
12077 to avoid shadowing.
12079 * marker.c (bytepos_to_charpos): Remove; unused.
12081 * lisp.h (verify_bytepos, count_markers): New decls,
12082 so that gcc does not warn that these functions aren't declared.
12084 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12085 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
12086 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
12087 (copy_text): Remove unused local var.
12089 * filelock.c (within_one_second): Now static.
12090 (lock_file_1): Rename local to avoid shadowing.
12092 * buffer.c (fix_overlays_before): Mark locals as initialized.
12093 (fix_start_end_in_overlays): Likewise. This function should be
12094 simplified by using pointers-to-pointers, but that's a different
12096 (switch_to_buffer_1): Now static.
12097 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12098 (report_overlay_modification): Rename locals to avoid shadowing.
12100 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
12101 Fix pointer signedness issue.
12102 (sys_subshell): Mark local as volatile if checking for lint,
12103 to suppress a gcc -Wclobbered warning that does not seem to be right.
12104 (MAXPATHLEN): Define only if needed.
12106 * process.c (serial_open, serial_configure): Move decls from here ...
12107 * systty.h: ... to here, so that they can be checked.
12109 * fns.c (get_random, seed_random): Move extern decls from here ...
12110 * lisp.h: ... to here, so that they can be checked.
12112 * sysdep.c (reset_io): Now static.
12113 (wait_for_termination_signal): Remove; unused.
12115 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12116 (copy_keymap_item, append_key, push_text_char_description):
12118 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
12119 (DENSE_TABLE_SIZE): Remove; unused.
12120 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12121 (describe_map_tree):
12122 Rename locals to avoid shadowing.
12124 * keyboard.c: Declare functions static if they are not used elsewhere.
12125 (echo_char, echo_dash, cmd_error, top_level_2):
12126 (poll_for_input, handle_async_input): Now static.
12127 (read_char, kbd_buffer_get_event, make_lispy_position):
12128 (make_lispy_event, make_lispy_movement, apply_modifiers):
12129 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12130 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12131 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
12132 (read_key_sequence, read_char): Mark locals as initialized.
12133 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
12135 * keyboard.h (make_ctrl_char): New decl.
12136 (mark_kboards): Move decl here ...
12137 * alloc.c (mark_kboards): ... from here.
12139 * lisp.h (force_auto_save_soon): New decl.
12141 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
12142 (DEFINE_DUMMY_FUNCTION): New macro.
12143 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12145 (main): Add casts to avoid warnings
12146 if GCC considers string literals to be constants.
12148 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12150 * dbusbind.c: Pointer signedness fixes.
12151 (xd_signature, xd_append_arg, xd_initialize):
12152 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12153 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12154 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12155 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12157 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12158 if GCC considers string literals to be constants.
12159 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
12161 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12163 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12164 (print_preprocess, print_object): New macro to fix last change.
12166 * print.c (print_preprocess): Don't forget font objects.
12168 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
12170 * emacs.c (USAGE3): Doc fixes.
12172 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12174 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12177 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
12179 * lisp.h (VWindow_system, Qfile_name_history):
12180 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12181 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12182 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12184 * w32select.c: Don't #include "keyboard.h".
12185 (run_protected): Add extern declaration for waiting_for_input.
12187 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12188 * w32console.c (detect_input_pending, read_input_pending)
12189 (encode_terminal_code):
12190 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12191 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12192 (w32_system_caret_y, Qfile_name_history):
12193 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12194 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12195 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12196 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12197 * w32proc.c (Qlocal, report_file_error):
12198 * w32term.c (Vwindow_system, updating_frame):
12199 * w32uniscribe.c (initialized, uniscribe_font_driver):
12200 Remove unneeded extern declarations.
12202 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
12204 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
12206 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
12208 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12209 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12210 These macros can no longer be used for assignment.
12212 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12213 Assign struct members directly, instead of using BUF_BEGV etc.
12214 (record_buffer_markers, fetch_buffer_markers): New functions for
12215 recording and fetching special buffer markers.
12216 (set_buffer_internal_1, set_buffer_temp): Use them.
12218 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12220 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12222 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12223 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12225 * xdisp.c (hscroll_window_tree):
12226 (reconsider_clip_changes): Use PT instead of BUF_PT.
12228 2011-03-13 Eli Zaretskii <eliz@gnu.org>
12230 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12231 $(EMACS_ROOT)/lib/intprops.h.
12233 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12235 Fix more problems found by GCC 4.5.2's static checks.
12237 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12238 to unsigned char * to avoid compiler diagnostic.
12239 (xg_free_frame_widgets): Make it clear that a local variable is
12240 needed only if USE_GTK_TOOLTIP.
12241 (gdk_window_get_screen): Make it clear that this macro is needed
12242 only if USE_GTK_TOOLTIP.
12243 (int_gtk_range_get_value): New function, which avoids a diagnostic
12244 from gcc -Wbad-function-cast.
12245 (xg_set_toolkit_scroll_bar_thumb): Use it.
12246 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12247 diagnostic from gcc -Wbad-function-cast.
12248 (get_utf8_string, xg_get_file_with_chooser):
12249 Rename locals to avoid shadowing.
12250 (create_dialog): Move locals to avoid shadowing.
12252 * xgselect.c (xg_select): Remove unused var.
12254 * image.c (four_corners_best): Mark locals as initialized.
12255 (gif_load): Initialize transparent_p to zero (Bug#8238).
12256 Mark another local as initialized.
12257 (my_png_error, my_error_exit): Mark with NO_RETURN.
12259 * image.c (clear_image_cache): Now static.
12260 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
12261 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
12262 (x_edge_detection): Remove unnecessary cast that
12263 gcc -Wbad-function-cast diagnoses.
12264 (gif_load): Fix pointer signedness.
12265 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12266 (jpeg_load, gif_load): Rename locals to avoid shadowing.
12268 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
12270 Improve quality of tests for time stamp overflow.
12271 For example, without this patch (encode-time 0 0 0 1 1
12272 1152921504606846976) returns the obviously-bogus value (-948597
12273 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12274 reports time overflow. See
12275 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
12276 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12277 * editfns.c: Include limits.h and intprops.h.
12278 (TIME_T_MIN, TIME_T_MAX): New macros.
12279 (time_overflow): Move earlier, to before first use.
12280 (hi_time, lo_time): New functions, for an accurate test for
12281 out-of-range times.
12282 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12283 (Fget_internal_run_time): Don't assume time_t fits in int.
12284 (make_time): Use list2 instead of Fcons twice.
12285 (Fdecode_time): More accurate test for out-of-range times.
12286 (check_tm_member): New function.
12287 (Fencode_time): Use it, to test for out-of-range times.
12288 (lisp_time_argument): Don't rely on undefined left-shift and
12289 right-shift behavior when checking for time stamp overflow.
12291 * editfns.c (time_overflow): New function, refactoring common code.
12292 (Fformat_time_string, Fdecode_time, Fencode_time):
12293 (Fcurrent_time_string): Use it.
12295 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12296 * dired.c (make_time): Move to ...
12297 * editfns.c (make_time): ... here.
12298 * systime.h: Note the move.
12300 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12302 * fringe.c (update_window_fringes): Remove unused variables.
12304 * unexmacosx.c (copy_data_segment): Also copy __got section.
12307 2011-03-12 Eli Zaretskii <eliz@gnu.org>
12309 * termcap.c [MSDOS]: Include "msdos.h".
12310 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12311 Constify `char *' arguments and their references according to
12312 prototypes in tparam.h.
12314 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
12316 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12317 Adapt all references accordingly.
12319 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12321 2011-03-11 Tom Tromey <tromey@redhat.com>
12323 * buffer.c (syms_of_buffer): Remove obsolete comment.
12325 2011-03-11 Eli Zaretskii <eliz@gnu.org>
12327 * termhooks.h (encode_terminal_code): Declare prototype.
12329 * msdos.c (encode_terminal_code): Don't declare prototype.
12331 * term.c (encode_terminal_code): Now external again, used by
12332 w32console.c and msdos.c.
12334 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12335 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
12337 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
12339 Fix some minor problems found by GCC 4.5.2's static checks.
12341 * fringe.c (update_window_fringes): Mark locals as initialized
12343 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
12345 * alloc.c (mark_fringe_data): Move decl from here ...
12346 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12347 to check its interface.
12348 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12350 * fontset.c (free_realized_fontset): Now static.
12351 (Fset_fontset_font): Rename local to avoid shadowing.
12352 (fontset_font): Mark local as initialized.
12353 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
12355 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12357 * xselect.c (x_disown_buffer_selections): Remove; not used.
12358 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
12359 (x_own_selection, Fx_disown_selection_internal): Rename locals
12360 to avoid shadowing.
12361 (x_handle_dnd_message): Remove local to avoid shadowing.
12363 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12364 so that the caller can use some name other than gcpro1.
12365 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
12366 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12367 (Fx_backspace_delete_keys_p):
12368 Use them to avoid shadowing, and rename vars to avoid shadowing.
12369 (x_decode_color, x_set_name, x_window): Now static.
12370 (Fx_create_frame): Add braces to silence GCC warning.
12371 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
12372 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12373 Remove unused locals.
12374 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12375 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12376 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12379 * xterm.h (x_mouse_leave): New decl.
12381 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12382 Remove unused functions.
12383 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12384 (x_calc_absolute_position): Now static.
12385 (XTread_socket): Don't define label "out" unless it's used.
12386 Don't declare local "event" unless it's used.
12387 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12388 unless they are used.
12389 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12390 (x_fatal_error_signal): Remove; not used.
12391 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12392 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12393 (x_error_catcher, x_connection_closed, x_error_handler):
12394 (x_error_quitter, xembed_send_message, x_iconify_frame):
12395 (my_log_handler): Rename locals to avoid shadowing.
12396 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
12397 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
12399 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12400 Rename or move locals to avoid shadowing.
12401 (tty_defined_color, merge_face_heights): Now static.
12402 (free_realized_faces_for_fontset): Remove; not used.
12403 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12404 does not deduce is never used uninitialized.
12405 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12406 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
12408 * terminal.c (store_terminal_param): Now static.
12410 * xmenu.c (menu_highlight_callback): Now static.
12411 (set_frame_menubar): Remove unused local.
12412 (xmenu_show): Rename parameter to avoid shadowing.
12413 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12414 since they might point to immutable storage.
12415 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12416 since it's unused otherwise.
12418 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
12419 Add a FIXME, since the code still doesn't look right. (Bug#8215)
12420 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12421 avoids a gcc -Wuninitialized diagnostic.
12422 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
12423 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12424 does not deduce are never used uninitialized.
12426 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12428 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
12429 * window.c (window_loop, size_window):
12430 (run_window_configuration_change_hook, enlarge_window): Likewise.
12432 * window.c (display_buffer): Now static.
12433 (size_window): Mark variables that gcc -Wuninitialized
12434 does not deduce are never used uninitialized.
12435 * window.h (check_all_windows): New decl, to forestall
12436 gcc -Wmissing-prototypes diagnostic.
12437 * dispextern.h (bidi_dump_cached_states): Likewise.
12439 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12441 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
12442 Include <limits.h>.
12443 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12444 and to avoid gcc -Wuninitialized warning.
12445 (load_charset_map): Mark variables that gcc -Wuninitialized
12446 does not deduce are never used uninitialized.
12447 (load_charset): Abort instead of using uninitialized var (Bug#8229).
12449 * coding.c (coding_set_source, coding_set_destination):
12450 Use "else { /* comment */ }" rather than "else /* comment */;"
12451 for clarity, and to avoid gcc -Wempty-body warning.
12452 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12453 a block, when the outer 'i' will do.
12454 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12455 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12456 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12457 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12458 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12459 Rename locals to avoid shadowing.
12460 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
12461 * coding.c (emacs_mule_char, encode_invocation_designation):
12462 Now static, since they're not used elsewhere.
12463 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
12464 (decode_coding_object, encode_coding_object, detect_coding_system):
12465 (decode_coding_emacs_mule): Mark variables that gcc
12466 -Wuninitialized does not deduce are never used uninitialized.
12467 (detect_coding_iso_2022): Initialize a local variable that might
12468 be used uninitialized. Leave a FIXME because it's not clear that
12469 this initialization is needed. (Bug#8211)
12470 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12471 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12472 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12473 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12474 Remove unused macros.
12476 * category.c (hash_get_category_set): Remove unused local var.
12477 (copy_category_table): Now static, since it's not used elsewhere.
12478 * character.c (string_count_byte8): Likewise.
12480 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12481 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12483 * chartab.c (copy_sub_char_table): Now static, since it's not used
12485 (sub_char_table_ref_and_range, char_table_ref_and_range):
12486 Rename locals to avoid shadowing.
12487 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
12489 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
12490 (BIDI_BOB): Remove unused macro.
12492 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12493 deduce are never used uninitialized.
12494 * term.c (encode_terminal_code): Likewise.
12496 * term.c (encode_terminal_code): Now static. Remove unused local.
12498 * tparam.h: New file.
12499 * term.c, tparam.h: Include it.
12500 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12501 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12502 Move these decls to tparam.h, and make them agree with what
12503 is actually in tparam.c. The previous trick of using incompatible
12504 decls in different modules does not conform to the C standard.
12505 All callers of tparam changed to use tparam's actual API.
12506 * tparam.c (tparam1, tparam, tgoto):
12507 Use const pointers where appropriate.
12509 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12510 * cm.h (struct cm): Likewise.
12511 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12512 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12513 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12514 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12515 (turn_on_face, init_tty): Likewise.
12516 * termchar.h (struct tty_display_info): Likewise.
12518 * term.c (term_mouse_position): Rename local to avoid shadowing.
12520 * alloc.c (mark_ttys): Move decl from here ...
12521 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12523 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12525 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12527 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
12529 * search.c (compile_pattern_1): Remove argument regp, unused since
12530 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12531 (compile_pattern): Don't pass it.
12533 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12535 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12536 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12538 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12540 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12542 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12543 gdk_window_get_screen, gdk_window_get_geometry,
12544 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12545 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12546 (xg_get_pixbuf_from_pixmap): New function.
12547 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12548 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12549 Call xg_get_pixbuf_from_pixmap instead of
12550 gdk_pixbuf_get_from_drawable.
12551 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12552 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12553 (xg_check_special_colors): Use GtkStyleContext and its functions
12555 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12556 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12557 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
12558 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12559 Call gtk_widget_get_preferred_size.
12560 (xg_frame_resized): gdk_window_get_geometry only takes 5
12562 (xg_win_to_widget, xg_event_is_for_menubar):
12563 Call gdk_x11_window_lookup_for_display.
12564 (xg_set_widget_bg): New function.
12565 (delete_cb): New function.
12566 (xg_create_frame_widgets): Connect delete-event to delete_cb.
12567 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
12568 (xg_set_background_color): Call xg_set_widget_bg.
12569 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12570 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12571 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12572 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12574 (update_frame_tool_bar): Call gtk_widget_hide.
12575 (xg_initialize): Use GDK_KEY_g.
12577 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12579 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12581 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12582 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12583 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12585 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
12587 * w32xfns.c (select_palette): Check success of RealizePalette against
12588 GDI_ERROR, not zero.
12590 See ChangeLog.11 for earlier changes.
12592 ;; Local Variables:
12596 Copyright (C) 2011-2012 Free Software Foundation, Inc.
12598 This file is part of GNU Emacs.
12600 GNU Emacs is free software: you can redistribute it and/or modify
12601 it under the terms of the GNU General Public License as published by
12602 the Free Software Foundation, either version 3 of the License, or
12603 (at your option) any later version.
12605 GNU Emacs is distributed in the hope that it will be useful,
12606 but WITHOUT ANY WARRANTY; without even the implied warranty of
12607 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12608 GNU General Public License for more details.
12610 You should have received a copy of the GNU General Public License
12611 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.