* macros.c: Integer and memory overflow fixes.
[bpt/emacs.git] / src / ChangeLog
1 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
2
3 * macros.c: Integer and memory overflow fixes.
4 (Fstart_kbd_macro): Don't update size until alloc done.
5 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6
7 * lread.c (read1, init_obarray): Don't update size until alloc done.
8
9 * keymap.c: Integer overflow fixes.
10 (cmm_size, current_minor_maps): Use ptrdiff_t, not int, to count maps.
11 (current_minor_maps): Check for size calculation overflow.
12 * keymap.h: Change prototypes to match the above.
13
14 * keyboard.c: Integer and memory overflow fixes.
15 (read_char, menu_bar_items, tool_bar_items, read_char_x_menu_prompt)
16 (read_char_minibuf_menu_width, read_char_minibuf_menu_prompt)
17 (follow_key, read_key_sequence): Use ptrdiff_t, not int, to count maps.
18 (read_char_minibuf_menu_prompt): Check for overflow in size
19 calculations. Don't update size until allocation succeeds. Redo
20 calculations to avoid overflow.
21 * keyboard.h: Change prototypes to match the above.
22
23 * image.c: Integer and memory overflow fixes.
24 (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these are duplicate
25 now that they've been promoted to lisp.h.
26 (x_allocate_bitmap_record, x_alloc_image_color)
27 (make_image_cache, cache_image, xpm_load):
28 Don't update size until alloc is done.
29 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
30 (x_detect_edges):
31 Check for size calculation overflow.
32 (ct_colors_allocated_max): New constant.
33 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
34 overflow.
35
36 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
37
38 * gtkutil.c: Integer overflow fixes.
39 (get_utf8_string, xg_store_widget_in_map):
40 Check for size-calculation overflow.
41 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
42 do, as we prefer signed integers.
43 (id_to_widget.max_size, id_to_widget.used)
44 (xg_store_widget_in_map, xg_remove_widget_from_map)
45 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
46 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
47 Use and return ptrdiff_t, not int.
48 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
49 * gtkutil.h: Change prototypes to match the above.
50
51 * ftfont.c: Check for size overflow.
52 (ftfont_get_open_type_spec, setup_otf_gstring, ftfont_shape_by_flt):
53 Check for integer overflow in size calculations.
54
55 * fringe.c (Fdefine_fringe_bitmap): Don't update size until alloc works.
56
57 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
58 This is for the members text_lines, text_cols, total_lines, total_cols,
59 where the system imposes an 'int' limit.
60
61 * frame.c: Integer overflow fixes.
62 (set_menu_bar_lines, x_set_frame_parameters, x_set_scroll_bar_width)
63 (x_figure_window_size): Check for integer overflow.
64 (x_set_alpha): Do not assume XINT fits in int.
65
66 * eval.c: Integer and memory overflow fixes.
67 (init_eval_once, grow_specpdl): Don't update size until alloc succeeds.
68 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
69
70 * emacs.c (main, sort_args): Check for size-calculation overflow.
71
72 * editfns.c: Integer and memory overflow fixes.
73 (set_time_zone_rule): Don't assume environment length fits in int.
74 (message_length): Now ptrdiff_t, not int.
75 (Fmessage_box): Don't update size until allocation succeeds.
76 Don't assume message length fits in int.
77 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
78
79 * doc.c: Integer and memory overflow fixes.
80 (get_doc_string_buffer_size): Now ptrdiff_t, not int.
81 (get_doc_string): Check for size calculation overflow.
82 Don't update size until allocation succeeds.
83 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
84 EMACS_INT, where ptrdiff_t will do.
85 (Fsubstitute_command_keys): Check for string overflow.
86
87 Integer and memory overflow fixes for display code.
88 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
89 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool, scrolling_window):
90 Check for overflow in size calculations.
91 (line_draw_cost, realloc_glyph_pool, add_row_entry):
92 Don't assume glyph table len fits in int.
93 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
94 (row_table_size): Now ptrdiff_t, not int.
95 (scrolling_window): Avoid overflow in size calculations.
96 Don't update size until allocation succeeds.
97 * fns.c (concat): Check for overflow in size calculations.
98 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
99 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
100 (NEXT_ALMOST_PRIME_LIMIT): New constant.
101
102 * composite.c: Integer overflow fixes.
103 (get_composition_id): Check for overflow in glyph length calculations.
104
105 * coding.c: Integer and memory overflow fixes.
106 (produce_chars): Redo buffer-overflow calculations to avoid
107 unnecessary integer overflow. Check for size overflow.
108 (encode_coding_object): Don't update size until xmalloc succeeds.
109
110 * character.c (Fstring): Check for size-calculation overflow.
111
112 * ccl.c: Integer and memory overflow fixes.
113 (Fccl_execute_on_string): Check for memory overflow.
114 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
115 Redo buffer-overflow calculations to avoid integer overflow.
116
117 * callproc.c (child_setup): Don't assume strlen fits in int.
118
119 * buffer.c: Memory overflow fixes.
120 (overlays_at, overlays_in, record_overlay_string, overlay_strings):
121 Don't update size of array until after memory allocation succeeds,
122 because xmalloc/xrealloc may not return.
123
124 * bidi.c: Integer overflow fix.
125 (bidi_shelve_header_size): New constant.
126 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
127 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
128
129 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
130
131 Use ptrdiff_t for composition IDs.
132 * character.c (lisp_string_width):
133 * composite.c (composition_table_size, n_compositions)
134 (get_composition_id, composition_gstring_from_id):
135 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
136 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
137 * window.c (Frecenter):
138 Use ptrdiff_t, not int, for composition IDs.
139 * composite.c (get_composition_id): Check for integer overflow.
140 * composite.h: Adjust prototypes to match the above changes.
141
142 Use ptrdiff_t for hash table indexes.
143 * category.c (hash_get_category_set):
144 * ccl.c (ccl_driver):
145 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
146 * coding.c (coding_system_charset_list, detect_coding_system):
147 * coding.h (struct coding_system.id):
148 * composite.c (get_composition_id, gstring_lookup_cache):
149 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
150 * image.c (xpm_get_color_table_h):
151 * lisp.h (hash_lookup, hash_put):
152 * minibuf.c (Ftest_completion):
153 Use ptrdiff_t for hash table indexes, not int (which is too
154 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
155 32-bit --with-wide-int hosts).
156
157 * charset.c (Fdefine_charset_internal): Check for integer overflow.
158 Add a FIXME comment about memory leaks.
159 (syms_of_charset): Don't assume xmalloc returns.
160
161 Don't assume that stated character widths fit in int.
162 * character.c (Fchar_width, c_string_width, lisp_string_width):
163 * character.h (CHAR_WIDTH):
164 * indent.c (MULTIBYTE_BYTES_WIDTH):
165 Use sanitize_char_width to avoid undefined and/or bad behavior
166 with outlandish widths.
167 * character.h (sanitize_tab_width): Renamed from sanitize_width,
168 now that we have two such functions. All uses changed.
169 (sanitize_char_width): New inline function.
170
171 Don't assume that tab-width fits in int.
172 * character.h (sanitize_width): New inline function.
173 (SANE_TAB_WIDTH): New macro.
174 (ASCII_CHAR_WIDTH): Use it.
175 * indent.c (sane_tab_width): Remove. All uses replaced by
176 SANE_TAB_WIDTH (current_buffer).
177 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
178
179 * fileio.c: Integer overflow issues with file modes.
180 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
181
182 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
183 Remove unreachable code.
184 (read_hex, load_charset_map_from_file): Check for integer overflow.
185
186 * xterm.c: don't go over XClientMessageEvent limit
187 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
188 (x_send_scroll_bar_event): Likewise. Check that the size does not
189 exceed limits imposed by XClientMessageEvent, as well as the usual
190 ptrdiff_t and size_t limits.
191
192 * keyboard.c: Overflow, signedness and related fixes.
193 (make_lispy_movement): Use same integer type in forward decl
194 that is used in the definition.
195 (read_key_sequence, keyremap_step):
196 Change bufsize argument back to int, undoing my 2011-03-30 change.
197 We prefer signed types, and int is wide enough here.
198 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
199 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
200 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
201 length, not size_t. Use ptrdiff_t for index, not int.
202 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
203 possibility of integer overflow.
204
205 Overflow, signedness and related fixes for images.
206
207 * dispextern.h (struct it.stack[0].u.image.image_id)
208 (struct_it.image_id, struct image.id, struct image_cache.size)
209 (struct image_cache.used, struct image_cache.ref_count):
210 * gtkutil.c (update_frame_tool_bar):
211 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
212 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
213 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
214 * nsmenu.m (update_frame_tool_bar):
215 * xdisp.c (calc_pixel_width_or_height):
216 * xfns.c (image_cache_refcount):
217 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
218 on typical 64-bit hosts.
219
220 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
221 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
222 Omit unnecessary casts to int.
223 (parse_image_spec): Check that integers fall into 'int' range
224 when the callers expect that.
225 (image_ascent): Redo ascent calculation to avoid int overflow.
226 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
227 (lookup_image): Remove unnecessary tests.
228 (xbm_image_p): Locals are now of int, not EMACS_INT,
229 since parse_image_check makes sure they fit into int.
230 (png_load, gif_load, svg_load_image):
231 Prefer int to unsigned where either will do.
232 (tiff_handler): New function, combining the cores of the
233 old tiff_error_handler and tiff_warning_handler. This
234 function is rewritten to use vsnprintf and thereby avoid
235 stack buffer overflows. It uses only the features of vsnprintf
236 that are common to both POSIX and native Microsoft.
237 (tiff_error_handler, tiff_warning_handler): Use it.
238 (tiff_load, gif_load, imagemagick_load_image):
239 Don't assume :index value fits in 'int'.
240 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
241 (imagemagick_load_image): Check that crop parameters fit into
242 the integer types that MagickCropImage accepts. Don't assume
243 Vimagemagick_render_type has a nonnegative value. Don't assume
244 size_t fits in 'long'.
245 (gs_load): Use printmax_t to print the widest integers possible.
246 Check for integer overflow when computing image height and width.
247
248 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
249
250 Integer signedness and overflow and related fixes. (Bug#9079)
251
252 * bidi.c: Integer size and overflow fixes.
253 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
254 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
255 (bidi_cache_find_level_change, bidi_cache_ensure_space)
256 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
257 (bidi_find_other_level_edge):
258 Use ptrdiff_t instead of EMACS_INT where either will do.
259 This works better on 32-bit hosts configured --with-wide-int.
260 (bidi_cache_ensure_space): Check for size-calculation overflow.
261 Use % rather than repeated addition, for better worst-case speed.
262 Don't set bidi_cache_size until after xrealloc returns, because it
263 might not return.
264 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
265 (bidi_cache_ensure_space): Also check that the bidi cache size
266 does not exceed that of the largest Lisp string or buffer. See Eli
267 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
268
269 * alloc.c (__malloc_size_t): Remove.
270 All uses replaced by size_t. See Andreas Schwab's note
271 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
272
273 * image.c: Improve checking for integer overflow.
274 (check_image_size): Assume that f is nonnull, since
275 it is always nonnull in practice. This is one less thing to
276 worry about when checking for integer overflow later.
277 (x_check_image_size): New function, which checks for integer
278 overflow issues inside X.
279 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
280 This removes the need for a memory_full check.
281 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
282 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
283 (xbm_read_bitmap_data): Change locals back to 'int', since
284 their values must fit in 'int'.
285 (xpm_load_image, png_load, tiff_load):
286 Invoke x_create_x_image_and_pixmap earlier,
287 to avoid much needless work if the image is too large.
288 (tiff_load): Treat overly large images as if
289 x_create_x_image_and_pixmap failed, not as malloc failures.
290 (gs_load): Use x_check_image_size.
291
292 * gtkutil.c: Omit integer casts.
293 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
294 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
295
296 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
297
298 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
299 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
300 would wrongly return t on a 64-bit host.
301
302 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
303 The plain *_OVERFLOW macros run afoul of GCC bug 49705
304 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
305 and therefore cause GCC to emit a bogus diagnostic in some cases.
306
307 * image.c: Integer signedness and overflow and related fixes.
308 This is not an exhaustive set of fixes, but it's time to
309 record what I've got.
310 (lookup_pixel_color, check_image_size): Remove redundant decls.
311 (check_image_size): Don't assume that arbitrary EMACS_INT values
312 fit in 'int', or that arbitrary 'double' values fit in 'int'.
313 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
314 (tiff_load, imagemagick_load_image):
315 Check for overflow in size calculations.
316 (x_create_x_image_and_pixmap): Remove unnecessary test for
317 xmalloc returning NULL; that can't happen.
318 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
319 (xpm_color_bucket): Use better integer hashing function.
320 (xpm_cache_color): Don't possibly over-allocate memory.
321 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
322 (gif_memory_source):
323 Use ptrdiff_t, not int or size_t, to record sizes.
324 (png_load): Don't assume values greater than 2**31 fit in 'int'.
325 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
326 either works, as we prefer signed integers.
327 (tiff_read_from_memory, tiff_write_from_memory):
328 Return tsize_t, not size_t, since that's what the TIFF API wants.
329 (tiff_read_from_memory): Don't fail simply because the read would
330 go past EOF; instead, return a short read.
331 (tiff_load): Omit no-longer-needed casts.
332 (Fimagemagick_types): Don't assume size fits into 'int'.
333
334 Improve hashing quality when configured --with-wide-int.
335 * fns.c (hash_string): New function, taken from sxhash_string.
336 Do not discard information about ASCII character case; this
337 discarding is no longer needed.
338 (sxhash-string): Use it. Change sig to match it. Caller changed.
339 * lisp.h: Declare it.
340 * lread.c (hash_string): Remove, since we now use fns.c's version.
341 The fns.c version returns a wider integer if --with-wide-int is
342 specified, so this should help the quality of the hashing a bit.
343
344 * emacs.c: Integer overflow minor fix.
345 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
346 Define only if GNU_LINUX.
347 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
348
349 * dispnew.c: Integer signedness and overflow fixes.
350 Remove unnecessary forward decls, that were a maintenance hassle.
351 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
352 All uses changed.
353 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
354 (scrolling_window): Use ptrdiff_t, not int, for byte count.
355 (prepare_desired_row, line_draw_cost):
356 Use int, not unsigned, where either works.
357 (save_current_matrix, restore_current_matrix):
358 Use ptrdiff_t, not size_t, where either works.
359 (init_display): Check for overflow more accurately, and without
360 relying on undefined behavior.
361
362 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
363 Remove, replacing with the new symbols in lisp.h. All uses changed.
364 * fileio.c (make_temp_name):
365 * filelock.c (lock_file_1, lock_file):
366 * xdisp.c (message_dolog):
367 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
368 Use pMd etc. instead.
369 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
370 replacing the pWIDE etc. symbols removed from editfns.c.
371
372 * keyboard.h (num_input_events): Now uintmax_t.
373 This is (very slightly) less likely to mess up due to wraparound.
374 All uses changed.
375
376 * buffer.c: Integer signedness fixes.
377 (alloc_buffer_text, enlarge_buffer_text):
378 Use ptrdiff_t rather than size_t when either will do, as we prefer
379 signed integers.
380
381 * alloc.c: Integer signedness and overflow fixes.
382 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
383 (__malloc_size_t): Default to size_t, not to int.
384 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
385 (Fgarbage_collect, mark_object_loop_halt, mark_object):
386 Prefer ptrdiff_t to size_t when either would do, as we prefer
387 signed integers.
388 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
389 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
390 Now const. Initialize with values that are in range even if char
391 is signed.
392 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
393 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
394 These functions do the right thing with sizes > 2**32.
395 (check_depth): Now ptrdiff_t, not int.
396 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
397 Adjust to new way of storing sizes. Check for size overflow bugs
398 in rest of code.
399 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
400 slightly wrong anyway, as it missed one instance of
401 XMALLOC_OVERRUN_CHECK_OVERHEAD.
402 (refill_memory_reserve): Omit needless cast to size_t.
403 (mark_object_loop_halt): Mark as externally visible.
404
405 * xselect.c: Integer signedness and overflow fixes.
406 (Fx_register_dnd_atom, x_handle_dnd_message):
407 Use ptrdiff_t, not size_t, since we prefer signed.
408 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
409 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
410 x_dnd_atoms_size and x_dnd_atoms_length.
411
412 * doprnt.c: Prefer signed to unsigned when either works.
413 * eval.c (verror):
414 * doprnt.c (doprnt):
415 * lisp.h (doprnt):
416 * xdisp.c (vmessage):
417 Use ptrdiff_t, not size_t, when using or implementing doprnt,
418 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
419 prefer signed arithmetic to avoid comparison confusion.
420 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
421 but is a bit tricky.
422
423 Assume freestanding C89 headers, string.h, stdlib.h.
424 * data.c, doprnt.c, floatfns.c, print.c:
425 Include float.h unconditionally.
426 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
427 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
428 * regex.c: Likewise for stddef.h, string.h.
429 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
430 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
431 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
432 (STDC_HEADERS): Remove obsolete defines.
433 * sysdep.c: Include limits.h unconditionally.
434
435 Assume support for memcmp, memcpy, memmove, memset.
436 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
437 * regex.c (memcmp, memcpy):
438 Remove; we assume C89 now.
439
440 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
441 (__malloc_safe_bcopy): Remove; no longer needed.
442
443 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
444 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
445 well either way, and we prefer signed to unsigned.
446
447 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
448
449 Port to OpenBSD.
450 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
451 and the surrounding thread.
452 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
453 rather than fgets, and retry after EINTR. Otherwise, 'emacs
454 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
455 timer goes off.
456 * s/openbsd.h (BROKEN_SIGIO): Define.
457 * unexelf.c (unexec) [__OpenBSD__]:
458 Don't update the .mdebug section of the Alpha COFF symbol table.
459
460 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
461
462 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
463 (bug#8460).
464
465 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
466
467 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
468 This fixes some race conditions on the permissions of any newly
469 created file.
470
471 * alloc.c (valid_pointer_p): Use pipe, not open.
472 This fixes some permissions issues when debugging.
473
474 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
475 If fchown fails to set both uid and gid, try to set just gid,
476 as that is sometimes allowed. Adjust the file's mode to eliminate
477 setuid or setgid bits that are inappropriate if fchown fails.
478
479 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
480
481 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
482 to compare Lisp_Objects.
483 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
484 global_gnutls_log_level, don't mistake it for a Lisp_Object.
485 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
486
487 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
488
489 * lread.c (read_integer): Unread even EOF character.
490 (read1): Likewise. Properly record start position of symbol.
491
492 * lread.c (read1): Read `#:' as empty uninterned symbol if no
493 symbol character follows.
494
495 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
496
497 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
498 This works around a problem with the previous change to Fcopy_file.
499 Recent glibc declares fchown with __attribute__((warn_unused_result)),
500 and without this change, GCC might complain about discarding
501 fchown's return value.
502
503 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
504
505 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
506
507 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
508
509 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
510
511 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
512
513 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
514 it's used from the C level.
515
516 * process.c: Use the same condition for POLL_FOR_INPUT in both
517 keyboard.c and process.c (bug#1858).
518
519 2011-07-09 Lawrence Mitchell <wence@gmx.li>
520
521 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
522 (Fgnutls_boot): Use it.
523
524 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
525
526 * doc.c (Fsubstitute_command_keys): Revert last change.
527
528 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
529
530 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
531 quotes the next character, and doesn't affect other longer
532 sequences (bug#8935).
533
534 * lread.c (syms_of_lread): Clarify that is isn't only
535 `eval-buffer' and `eval-defun' that's affected by
536 `lexical-binding' (bug#8460).
537
538 2011-07-15 Eli Zaretskii <eliz@gnu.org>
539
540 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
541 bidi redisplay when a line includes both an image and is
542 truncated.
543
544 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
545
546 Fix minor problems found by static checking.
547 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
548 (elsz): Now a signed constant, not a size_t var. We prefer signed
549 types to unsigned, to avoid integer comparison confusion. Without
550 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
551 "cannot optimize loop, the loop counter may overflow", a symptom
552 of the confusion.
553 * indent.c (Fvertical_motion): Mark locals as initialized.
554 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
555
556 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
557
558 * search.c (Fre_search_backward): Mention `case-fold-search' in
559 all the re_search_* functions (bug#8138).
560
561 * keyboard.c (Fopen_dribble_file): Document when the file is
562 closed (bug#8056).
563
564 2011-07-14 Eli Zaretskii <eliz@gnu.org>
565
566 * bidi.c (bidi_dump_cached_states): Fix format of displaying
567 bidi_cache_idx.
568
569 Support bidi reordering of display and overlay strings.
570 * xdisp.c (compute_display_string_pos)
571 (compute_display_string_end): Accept additional argument STRING.
572 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
573 (reseat_to_string): Initialize bidi_it->string.s and
574 bidi_it->string.schars.
575 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
576 NULL (avoids a crash in bidi_paragraph_init). Initialize
577 itb.string.lstring.
578 (init_iterator): Call bidi_init_it only of a valid
579 buffer position was specified. Initialize paragraph_embedding to
580 L2R.
581 (reseat_to_string): Initialize the bidi iterator.
582 (display_string): If we need to ignore text properties of
583 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
584 original value of -1 will not work with bidi.)
585 (compute_display_string_pos): First arg is now struct
586 `text_pos *'; all callers changed. Support display properties on
587 Lisp strings.
588 (compute_display_string_end): Support display properties on Lisp
589 strings.
590 (init_iterator, reseat_1, reseat_to_string): Initialize the
591 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
592 when iterating on a string not from display properties).
593 (compute_display_string_pos, compute_display_string_end): Fix
594 calculation of the object to scan. Fixes an error when using
595 arrow keys.
596 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
597 base_level_stop; instead, set base_level_stop to BEGV. Fixes
598 crashes in vertical-motion.
599 (next_element_from_buffer): Improve commentary for when
600 the iterator is before prev_stop.
601 (init_iterator): Initialize bidi_p from the default value of
602 bidi-display-reordering, not from buffer-local value. Use the
603 buffer-local value only if initializing for buffer iteration.
604 (handle_invisible_prop): Support invisible properties on strings
605 that are being bidi-reordered.
606 (set_iterator_to_next): Support bidi reordering of C strings and
607 Lisp strings.
608 (next_element_from_string): Support bidi reordering of Lisp
609 strings.
610 (handle_stop_backwards): Support Lisp strings as well.
611 (display_string): Support display of R2L glyph rows. Use
612 IT_STRING_CHARPOS when displaying from a Lisp string.
613 (init_iterator): Don't initialize it->bidi_p for strings
614 here.
615 (reseat_to_string): Initialize it->bidi_p for strings here.
616 (next_element_from_string, next_element_from_c_string)
617 (next_element_from_buffer): Add xassert's for correspondence
618 between IT's object being iterated and it->bidi_it.string
619 structure.
620 (face_before_or_after_it_pos): Support bidi iteration.
621 (next_element_from_c_string): Handle the case of the first string
622 character that is not the first one in the visual order.
623 (get_visually_first_element): New function, refactored from common
624 parts of next_element_from_buffer, next_element_from_string, and
625 next_element_from_c_string.
626 (tool_bar_lines_needed, redisplay_tool_bar)
627 (display_menu_bar): Force left-to-right direction. Add a FIXME
628 comment for making that be controlled by a user option.
629 (push_it, pop_it): Save and restore the state of the
630 bidi iterator. Save and restore the bidi_p flag.
631 (pop_it): Iterate out of display property for string iteration as
632 well.
633 (iterate_out_of_display_property): Support iteration over strings.
634 (handle_single_display_spec): Set up it->bidi_it for iteration
635 over a display string, and call bidi_init_it.
636 (handle_single_display_spec, next_overlay_string)
637 (get_overlay_strings_1, push_display_prop): Set up the bidi
638 iterator for displaying display or overlay strings.
639 (forward_to_next_line_start): Don't use the shortcut if
640 bidi-iterating.
641 (back_to_previous_visible_line_start): If handle_display_prop
642 pushed the iterator stack, restore the internal state of the bidi
643 iterator by calling bidi_pop_it same number of times.
644 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
645 and we are bidi-iterating, don't decrement the iterator position;
646 instead, set the first_elt flag in the bidi iterator, to produce
647 the same effect.
648 (reseat_1): Remove redundant setting of string_from_display_prop_p.
649 (push_display_prop): xassert that we are iterating a buffer.
650 (push_it, pop_it): Save and restore paragraph_embedding member.
651 (handle_single_display_spec, next_overlay_string)
652 (get_overlay_strings_1, reseat_1, reseat_to_string)
653 (push_display_prop): Set up the `unibyte' member of bidi_it.string
654 correctly. Don't assume unibyte strings are not bidi-reordered.
655 (compute_display_string_pos)
656 (compute_display_string_end): Fix handling the case of C string.
657 (push_it, pop_it): Save and restore from_disp_prop_p.
658 (handle_single_display_spec, push_display_prop): Set the
659 from_disp_prop_p flag.
660 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
661 (pop_it): Call iterate_out_of_display_property only if we are
662 popping after iteration over a string that came from a display
663 property. Fix a typo in popping stretch info. Add an assertion
664 for verifying that the iterator position is in sync with the bidi
665 iterator.
666 (handle_single_display_spec, get_overlay_strings_1)
667 (push_display_prop): Fix initialization of paragraph direction for
668 string when that of the parent object is not yet determined.
669 (reseat_1): Call bidi_init_it to resync the bidi
670 iterator with IT's position. (Bug#7616)
671 (find_row_edges): If ROW->start.pos gives position
672 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
673 (handle_stop, back_to_previous_visible_line_start, reseat_1):
674 Reset the from_disp_prop_p flag.
675 (SAVE_IT, RESTORE_IT): New macros.
676 (pos_visible_p, face_before_or_after_it_pos)
677 (back_to_previous_visible_line_start)
678 (move_it_in_display_line_to, move_it_in_display_line)
679 (move_it_to, move_it_vertically_backward, move_it_by_lines)
680 (try_scrolling, redisplay_window, display_line): Use them when
681 saving a temporary copy of the iterator and restoring it back.
682 (back_to_previous_visible_line_start, reseat_1)
683 (init_iterator): Empty the bidi cache "stack".
684 (move_it_in_display_line_to): If iterator ended up at
685 EOL, but we never saw any buffer positions smaller than
686 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
687 motion in bidi-reordered lines.
688 (move_it_in_display_line_to): Record prev_method and prev_pos
689 immediately before the call to set_iterator_to_next. Fixes cursor
690 motion in bidi-reordered lines with stretch glyphs and strings
691 displayed in margins. (Bug#8133) (Bug#8867)
692 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
693 TO_CHARPOS.
694 (pos_visible_p): Support positions in bidi-reordered lines. Save
695 and restore bidi cache.
696
697 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
698 (bidi_paragraph_info): Delete unused struct.
699 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
700 (bidi_cache_start): New variable.
701 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
702 to zero.
703 (bidi_cache_fetch_state, bidi_cache_search)
704 (bidi_cache_find_level_change, bidi_cache_iterator_state)
705 (bidi_cache_find, bidi_peek_at_next_level)
706 (bidi_level_of_next_char, bidi_find_other_level_edge)
707 (bidi_move_to_visually_next): Compare cache index with
708 bidi_cache_start rather than with zero.
709 (bidi_fetch_char): Accept new argument STRING; all callers
710 changed. Support iteration over a string. Support strings with
711 display properties. Support unibyte strings. Fix the type of
712 `len' according to what STRING_CHAR_AND_LENGTH expects.
713 (bidi_paragraph_init, bidi_resolve_explicit_1)
714 (bidi_resolve_explicit, bidi_resolve_weak)
715 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
716 iteration over a string.
717 (bidi_set_sor_type, bidi_resolve_explicit_1)
718 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
719 can now be zero (for strings); special values 0 and -1 were
720 changed to -1 and -2, respectively.
721 (bidi_char_at_pos): New function.
722 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
723 Call it instead of FETCH_MULTIBYTE_CHAR.
724 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
725 initialized to valid values.
726 (bidi_init_it): Don't initialize charpos and bytepos with invalid
727 values.
728 (bidi_level_of_next_char): Allow the sentinel "position" to pass
729 the test for valid cached positions. Fix the logic for looking up
730 the sentinel state in the cache. GCPRO the Lisp string we are
731 iterating.
732 (bidi_push_it, bidi_pop_it): New functions.
733 (bidi_initialize): Initialize the bidi cache start stack pointer.
734 (bidi_cache_ensure_space): New function, refactored from part of
735 bidi_cache_iterator_state. Don't assume the required size is just
736 one BIDI_CACHE_CHUNK away.
737 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
738 (bidi_count_bytes, bidi_char_at_pos): New functions.
739 (bidi_cache_search): Don't assume bidi_cache_last_idx is
740 always valid if bidi_cache_idx is valid.
741 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
742 is valid if it's going to be used.
743 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
744 (bidi_cache_fetch_state, bidi_cache_search)
745 (bidi_cache_find_level_change, bidi_cache_ensure_space)
746 (bidi_cache_iterator_state, bidi_cache_find)
747 (bidi_find_other_level_edge, bidi_cache_start_stack): All
748 variables related to cache indices are now EMACS_INT.
749
750 * dispextern.h (struct bidi_string_data): New structure.
751 (struct bidi_it): New member `string'. Make flag members be 1-bit
752 fields, and put them last in the struct.
753 (compute_display_string_pos, compute_display_string_end): Update
754 prototypes.
755 (bidi_push_it, bidi_pop_it): Add prototypes.
756 (struct iterator_stack_entry): New members bidi_p,
757 paragraph_embedding, and from_disp_prop_p.
758 (struct it): Member bidi_p is now a bit field 1 bit wide.
759 (bidi_shelve_cache, bidi_unshelve_cache): Declare
760 prototypes.
761
762 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
763 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
764 and vector-like objects.
765
766 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
767 cache around display iteration.
768
769 * window.c (Fwindow_end, window_scroll_pixel_based)
770 (displayed_window_lines, Frecenter): Save and restore the bidi
771 cache around display iteration.
772
773 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
774
775 * editfns.c (Fdelete_region): Clarify the use of the named
776 parameters (bug#6788).
777
778 2011-07-14 Martin Rudalics <rudalics@gmx.at>
779
780 * indent.c (Fvertical_motion): Set and restore w->pointm when
781 saving and restoring the window's buffer (Bug#9006).
782
783 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
784
785 * editfns.c (Fstring_to_char): Clarify just what is returned
786 (bug#6576). Text by Eli Zaretskii.
787
788 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
789
790 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
791
792 2011-07-13 Eli Zaretskii <eliz@gnu.org>
793
794 * buffer.c (mmap_find): Fix a typo.
795
796 2011-07-13 Johan Bockgård <bojohan@gnu.org>
797
798 Fix execution of x selection hooks.
799 * xselect.c (Qx_lost_selection_functions)
800 (Qx_sent_selection_functions): New vars.
801 (syms_of_xselect): DEFSYM them.
802 (x_handle_selection_request): Pass Qx_sent_selection_functions
803 rather than Vx_sent_selection_functions to Frun_hook_with_args.
804 (x_handle_selection_clear,x_clear_frame_selections):
805 Pass Qx_lost_selection_functions rather than
806 Vx_lost_selection_functions to Frun_hook_with_args.
807
808 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
809
810 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
811 The old code sometimes used this field without initializing it.
812
813 * alloc.c (gc_sweep): Don't read past end of array.
814 In theory, the old code could also have corrupted Emacs internals,
815 though it'd be very unlikely.
816
817 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
818
819 * character.c (Fcharacterp): Don't advertise optional ignored
820 argument. (Bug#4026)
821
822 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
823
824 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
825 key" (bug#4257).
826
827 * window.c (Fset_window_start): Doc fix (bug#4199).
828 (Fset_window_hscroll): Ditto.
829
830 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
831
832 Fix minor new problems caught by GCC 4.6.1.
833 * term.c (init_tty): Remove unused local.
834 * xsettings.c (store_monospaced_changed): Define this function only
835 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
836 not used otherwise.
837
838 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
839
840 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
841
842 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
843
844 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
845 are the mini-buffer and the echo area (bug#3320).
846
847 * term.c (init_tty): Remove support for supdup, c10 and perq
848 terminals, which are no longer supported (bug#1482).
849
850 2011-07-10 Johan Bockgård <bojohan@gnu.org>
851
852 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
853
854 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
855
856 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
857 for non-popups (Bug#3642).
858
859 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
860
861 * alloc.c (reset_malloc_hooks): Protoize.
862 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
863 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
864 * cm.c (losecursor): Likewise.
865 * data.c (fmod): Likewise.
866 * dispnew.c (swap_glyphs_in_rows): Likewise.
867 * emacs.c (memory_warning_signal): Likewise.
868 * floatfns.c (float_error): Likewise.
869 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
870 (otf_open, font_otf_capability, generate_otf_features)
871 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
872 Likewise.
873 * image.c (pbm_read_file): Likewise.
874 * indent.c (string_display_width): Likewise.
875 * intervals.c (check_for_interval, search_for_interval)
876 (inc_interval_count, count_intervals, root_interval)
877 (adjust_intervals_for_insertion, make_new_interval): Likewise.
878 * lread.c (defalias): Likewise.
879 * ralloc.c (r_alloc_check): Likewise.
880 * regex.c (set_image_of_range_1, set_image_of_range)
881 (regex_grow_registers): Likewise.
882 * sysdep.c (strerror): Likewise.
883 * termcap.c (valid_filename_p, tprint, main): Likewise.
884 * tparam.c (main): Likewise.
885 * unexhp9k800.c (run_time_remap, save_data_space)
886 (update_file_ptrs, read_header, write_header, calculate_checksum)
887 (copy_file, copy_rest, display_header): Likewise.
888 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
889 Likewise.
890 * xdisp.c (check_it): Likewise.
891 * xfaces.c (register_color, unregister_color, unregister_colors):
892 Likewise.
893 * xfns.c (print_fontset_result): Likewise.
894 * xrdb.c (member, fatal, main): Likewise.
895
896 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
897
898 Fix minor problems found by static checking (Bug#9031).
899 * chartab.c (char_table_set_range, map_sub_char_table):
900 Remove unused locals.
901 (uniprop_table): Now static.
902 * composite.c (_work_char): Remove unused static var.
903
904 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
905
906 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
907
908 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
909
910 * gtkutil.c (qttip_cb): Remove code without function.
911
912 2011-07-09 Eli Zaretskii <eliz@gnu.org>
913
914 * w32.c (pthread_sigmask): New stub.
915
916 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
917
918 Use pthread_sigmask, not sigprocmask (Bug#9010).
919 sigprocmask is portable only for single-threaded applications, and
920 Emacs can be multi-threaded when it uses GTK.
921 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
922 (LIBES): Use it.
923 * callproc.c (Fcall_process):
924 * process.c (create_process):
925 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
926 Use pthread_sigmask, not sigprocmask.
927
928 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
929
930 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
931 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
932 wrong (Bug#8591).
933
934 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
935
936 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
937 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
938 (xg_hide_tooltip): Fix comment.
939
940 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
941 in registerServicesMenuSendTypes.
942 (validRequestorForSendType): Don't check ns_return_types.
943
944 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
945 ns_return_type.
946
947 2011-07-08 Jason Rumney <jasonr@gnu.org>
948
949 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
950 frame struct members of non-existent frames (Bug#6284).
951
952 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
953
954 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
955 variable firstTime not needed on OSX >= 10.6.
956 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
957 >= 10.5. Use setKnobProportion, setDoubleValue.
958
959 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
960 (MAC_OS_X_VERSION_10_5): Define if not defined.
961 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
962 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
963 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
964
965 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
966 cString and lossyCString on OSX >= 10.4
967
968 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
969 sizeToFit on OSX >= 10.2.
970
971 * nsimage.m (allocInitFromFile): Don't use deprecated method
972 bestRepresentationForDevice on OSX >= 10.6.
973
974 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
975 to avoid warning.
976
977 * emacs.c: Declare unexec_init_emacs_zone.
978
979 * nsgui.h: Fix compiler warning about gnulib redefining verify.
980
981 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
982
983 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
984 on svcsMenu (Bug#8842).
985
986 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
987 ns_return_types.
988 (Fns_list_services): Just return Qnil on 10.6, code not working there.
989
990 * nsterm.m (QUTF8_STRING): Declare.
991 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
992 (validRequestorForSendType): Return type is (id).
993 Change indexOfObjectIdenticalTo to indexOfObject.
994 Check if we have local selection before returning self (Bug#8842).
995 (writeSelectionToPasteboard): Put local selection into paste board
996 if we have a local selection (Bug#8842).
997 (syms_of_nsterm): DEFSYM QUTF8_STRING.
998
999 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1000 (ns_get_local_selection): Declare.
1001
1002 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1003
1004 * keymap.c (describe_map_tree): Don't insert a double newline at
1005 the end of the buffer (bug#1169) and return whether we inserted
1006 something.
1007
1008 * callint.c (Fcall_interactively): Change "reading args" to
1009 "providing args" to try to clarify what it does (bug#1010).
1010
1011 2011-07-07 Kenichi Handa <handa@m17n.org>
1012
1013 * composite.c (composition_compute_stop_pos): Ignore a static
1014 composition starting before CHARPOS (Bug#8915).
1015
1016 * xdisp.c (handle_composition_prop): Likewise.
1017
1018 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1019
1020 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1021 (Bug#9015)
1022
1023 2011-07-07 Kenichi Handa <handa@m17n.org>
1024
1025 * character.h (unicode_category_t): New enum type.
1026
1027 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1028 (Qchar_code_property_table): New variable.
1029 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1030 (UNIPROP_COMPRESSED_FORM_P): New macros.
1031 (char_table_ascii): Uncompress the compressed values.
1032 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1033 Uncompress the compressed values.
1034 (sub_char_table_ref_and_range): Likewise.
1035 (char_table_ref_and_range): Uncompress the compressed values.
1036 (sub_char_table_set): New arg is_uniprop. Callers changed.
1037 Uncompress the compressed values.
1038 (sub_char_table_set_range): Args changed. Callers changed.
1039 (char_table_set_range): Adjuted for the above change.
1040 (map_sub_char_table): Delete args default_val and parent. Add arg
1041 top. Give decoded values to a Lisp function.
1042 (map_char_table): Adjusted for the above change. Give decoded
1043 values to a Lisp function. Gcpro more variables.
1044 (uniprop_table_uncompress)
1045 (uniprop_decode_value_run_length): New functions.
1046 (uniprop_decoder, uniprop_decoder_count): New variables.
1047 (uniprop_get_decoder, uniprop_encode_value_character)
1048 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1049 New functions.
1050 (uniprop_encoder, uniprop_encoder_count): New variables.
1051 (uniprop_get_encoder, uniprop_table)
1052 (Funicode_property_table_internal, Fget_unicode_property_internal)
1053 (Fput_unicode_property_internal): New functions.
1054 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1055 Sunicode_property_table_internal, Sget_unicode_property_internal,
1056 and Sput_unicode_property_internal. Defvar_lisp
1057 char-code-property-alist.
1058
1059 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
1060 Vunicode_category_table.
1061
1062 * font.c (font_range): Adjusted for the change of
1063 Vunicode_category_table.
1064
1065 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1066
1067 * m/iris4d.h: Remove file, move contents ...
1068 * s/irix6-5.h: ... here.
1069
1070 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1071
1072 Remove unportable assumption about struct layout (Bug#8884).
1073 * alloc.c (mark_buffer):
1074 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1075 (clone_per_buffer_values): Don't assume that
1076 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1077 This isn't true in general, and it's particularly not true
1078 if Emacs is configured with --with-wide-int.
1079 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1080 New macros, used in the buffer.c change.
1081
1082 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1083
1084 * xsettings.c: Use both GConf and GSettings if both are available.
1085 (store_config_changed_event): Add comment.
1086 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1087 (store_tool_bar_style_changed): New functions.
1088 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1089 (struct xsettings): Move font inside HAVE_XFT.
1090 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1091 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
1092 Move inside HAVE_XFT.
1093 (something_changed_gsettingsCB): Renamed from something_changedCB.
1094 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1095 also.
1096 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1097 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1098 (something_changed_gconfCB): Renamed from something_changedCB.
1099 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1100 (parse_settings): Move check for font inside HAVE_XFT.
1101 (read_settings, apply_xft_settings): Add comment.
1102 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1103 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1104 call store_font_name_changed.
1105 (xft_settings_event): Add comment.
1106 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1107 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1108 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1109 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1110 (xsettings_initialize): Call init_gsettings last.
1111 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
1112 comment.
1113
1114 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1115
1116 Random fixes. E.g., (random) never returned negative values.
1117 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1118 subseconds part to the entropy, as that's a bit more random.
1119 Prefer signed to unsigned, since the signedness doesn't matter and
1120 in general we prefer signed. When given a limit, use a
1121 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1122 latter isn't right if USE_2_TAGS_FOR_INTS.
1123 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1124 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1125
1126 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1127
1128 * textprop.c (text_property_stickiness):
1129 Obey Vtext_property_default_nonsticky.
1130 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1131 * w32fns.c (syms_of_w32fns):
1132 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1133
1134 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1135
1136 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1137 This is more efficient than Ffile_directory_p and avoids a minor race.
1138
1139 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1140
1141 * buffer.c (Foverlay_put): Say what the return value is
1142 (bug#7835).
1143
1144 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1145 is a directory before asking whether to use the file name
1146 (bug#7564).
1147 (barf_or_query_if_file_exists): Make the "File is a directory"
1148 error be more correct.
1149
1150 * fns.c (Frequire): Remove the mention of the .gz files, since
1151 that's installation-specific, but keep the mention of
1152 `get-load-suffixes'.
1153
1154 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1155
1156 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1157 Report string overflow if the output is too long.
1158
1159 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1160
1161 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1162 (syms_of_gnutls): Remove duplicate DEFSYM for
1163 Qgnutls_bootprop_verify_hostname_error, an error for
1164 Qgnutls_bootprop_verify_error (which is no longer used).
1165
1166 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1167 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1168 Also (re)move comments that are misplaced or no longer relevant.
1169
1170 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1171
1172 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1173
1174 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1175
1176 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1177 and background color parameters if they have been changed.
1178
1179 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1180
1181 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1182
1183 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1184
1185 * xsettings.c (SYSTEM_FONT): Define only when used.
1186 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1187
1188 * keymap.c (access_keymap_1): Now static.
1189
1190 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1191
1192 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1193 leave any prefix arg for the up event (Bug#1586).
1194
1195 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1196
1197 * lread.c (syms_of_lread): Mention single symbols defined by
1198 `defvar' or `defconst' (bug#7154).
1199
1200 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1201 (Frequire): Mention get-load-suffixes.
1202
1203 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1204
1205 * window.h (window): Remove clone_number slot.
1206 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1207 Remove.
1208 (make_parent_window, make_window, saved_window)
1209 (Fset_window_configuration, save_window_save): Don't deal with
1210 clone numbers.
1211 * buffer.c (Qclone_number): Remove declaration.
1212 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1213
1214 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1215
1216 Add multiple inheritance to keymaps.
1217 * keymap.c (Fmake_composed_keymap): New function.
1218 (Fset_keymap_parent): Simplify.
1219 (fix_submap_inheritance): Remove.
1220 (access_keymap_1): New function extracted from access_keymap to handle
1221 embedded parents and handle lists of maps.
1222 (access_keymap): Use it.
1223 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1224 (Fcopy_keymap): Handle embedded parents.
1225 (Fcommand_remapping, define_as_prefix): Simplify.
1226 (Fkey_binding): Simplify.
1227 (syms_of_keymap): Move minibuffer-local-completion-map,
1228 minibuffer-local-filename-completion-map,
1229 minibuffer-local-must-match-map, and
1230 minibuffer-local-filename-must-match-map to Elisp.
1231 (syms_of_keymap): Defsubr make-composed-keymap.
1232 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1233 (parse_menu_item): Trivial simplification.
1234
1235 2011-07-01 Glenn Morris <rgm@gnu.org>
1236
1237 * Makefile.in (SETTINGS_LIBS): Fix typo.
1238
1239 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1240
1241 * coding.c (Fencode_coding_string): Record the last coding system
1242 used, as the function doc string says (bug#8738).
1243
1244 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1245
1246 * xsettings.c (store_monospaced_changed): Take new font as arg and
1247 check for change against current_mono_font.
1248 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1249 (emacs_settings_constructor, emacs_settings_get_property)
1250 (emacs_settings_set_property, emacs_settings_class_init)
1251 (emacs_settings_init, gsettings_obj): Remove.
1252 (something_changedCB): New function for HAVE_GSETTINGS.
1253 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1254 with value as argument.
1255 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1256 g_settings_new (Bug#8967). Do not create gsettings_obj.
1257 Remove calls to g_settings_bind. Connect something_changedCB to
1258 "changed".
1259
1260 * xgselect.c: Add defined (HAVE_GSETTINGS).
1261 (xgselect_initialize): Ditto.
1262
1263 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1264 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1265 xg_select.
1266
1267 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1268
1269 * eval.c (struct backtrace): Simplify and port the data structure.
1270 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1271 signed bit field, as this assumption is not portable and it makes
1272 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1273 "char debug_on_exit : 1" as this is not portable either; instead,
1274 use the portable "unsigned int debug_on_exit : 1". Remove unused
1275 member evalargs. Remove obsolete comments about cc bombing out.
1276
1277 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1278
1279 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1280 Let HAVE_GSETTINGS override HAVE_GCONF.
1281 (store_monospaced_changed): New function.
1282 (EMACS_SETTINGS): A new type derived from GObject to handle
1283 GSettings notifications.
1284 (emacs_settings_constructor, emacs_settings_get_property)
1285 (emacs_settings_set_property, emacs_settings_class_init):
1286 New functions.
1287 (gsettings_client, gsettings_obj): New variables.
1288 (GSETTINGS_SCHEMA): New define.
1289 (something_changedCB): Call store_monospaced_changed.
1290 (init_gsettings): New function.
1291 (xsettings_initialize): Call init_gsettings.
1292 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1293 to NULL.
1294
1295 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
1296 GCONF_CFLAGS/LIBS.
1297
1298 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1299
1300 * window.c (resize_root_window, grow_mini_window)
1301 (shrink_mini_window): Rename Qresize_root_window to
1302 Qwindow_resize_root_window and Qresize_root_window_vertically to
1303 Qwindow_resize_root_window_vertically.
1304
1305 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1306
1307 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1308
1309 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1310
1311 * makefile.w32-in: Redesign dependencies so they reflect more
1312 clearly which files are directly included by each source file,
1313 and not through other includes.
1314
1315 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1316
1317 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1318 (sort_overlays, overlay_strings): When an overlay's clone number
1319 matches the window's clone number process the overlay even if
1320 the overlay's window property doesn't match the current window.
1321
1322 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1323 (Fwindow_hchild): Rename to Fwindow_left_child.
1324 (Fwindow_next): Rename to Fwindow_next_sibling.
1325 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1326 (resize_window_check): Rename to window_resize_check.
1327 (resize_window_apply): Rename to window_resize_apply.
1328 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1329 (Fdelete_other_windows_internal, resize_frame_windows)
1330 (Fsplit_window_internal, Fdelete_window_internal)
1331 (grow_mini_window, shrink_mini_window)
1332 (Fresize_mini_window_internal): Fix callers accordingly.
1333
1334 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1335
1336 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1337 (emacs_fixed_set_min_size): Remove.
1338 (emacs_fixed_new): Take frame as argument.
1339
1340 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1341 (_EmacsFixedPrivate): Remove minwidth/height.
1342 Add struct frame *f.
1343 (emacs_fixed_init): Initialize priv->f.
1344 (get_parent_class, emacs_fixed_set_min_size): Remove.
1345 (emacs_fixed_new): Set priv->f to argument.
1346 (emacs_fixed_get_preferred_width)
1347 (emacs_fixed_get_preferred_height): Use min_width/height from
1348 frames size_hint to set minimum and natural (Bug#8919).
1349 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1350 and use min_width/height from frames size_hint to set
1351 min_width/height (Bug#8919).
1352
1353 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1354 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1355 Fix indentation.
1356
1357 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1358
1359 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1360 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1361 called at ZV.
1362
1363 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1364
1365 * process.c (wait_reading_process_output): Bypass select if
1366 waiting for a cell while ignoring keyboard input, and input is
1367 pending. Suggested by Jan Djärv (Bug#8869).
1368
1369 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1370
1371 Use gnulib's dup2 module instead of rolling our own.
1372 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1373
1374 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1375
1376 * dispnew.c (scrolling_window): Before scrolling, turn off a
1377 mouse-highlight in the window being scrolled.
1378
1379 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1380
1381 Move DEFSYM to lisp.h and use everywhere.
1382
1383 * character.h (DEFSYM): Move declaration...
1384 * lisp.h (DEFSYM): ...here.
1385
1386 * gnutls.c:
1387 * minibuf.c:
1388 * w32menu.c:
1389 * w32proc.c:
1390 * w32select.c: Don't include character.h.
1391
1392 * alloc.c (syms_of_alloc):
1393 * buffer.c (syms_of_buffer):
1394 * bytecode.c (syms_of_bytecode):
1395 * callint.c (syms_of_callint):
1396 * casefiddle.c (syms_of_casefiddle):
1397 * casetab.c (init_casetab_once):
1398 * category.c (init_category_once, syms_of_category):
1399 * ccl.c (syms_of_ccl):
1400 * cmds.c (syms_of_cmds):
1401 * composite.c (syms_of_composite):
1402 * dbusbind.c (syms_of_dbusbind):
1403 * dired.c (syms_of_dired):
1404 * dispnew.c (syms_of_display):
1405 * doc.c (syms_of_doc):
1406 * editfns.c (syms_of_editfns):
1407 * emacs.c (syms_of_emacs):
1408 * eval.c (syms_of_eval):
1409 * fileio.c (syms_of_fileio):
1410 * fns.c (syms_of_fns):
1411 * frame.c (syms_of_frame):
1412 * fringe.c (syms_of_fringe):
1413 * insdel.c (syms_of_insdel):
1414 * keymap.c (syms_of_keymap):
1415 * lread.c (init_obarray, syms_of_lread):
1416 * macros.c (syms_of_macros):
1417 * msdos.c (syms_of_msdos):
1418 * print.c (syms_of_print):
1419 * process.c (syms_of_process):
1420 * search.c (syms_of_search):
1421 * sound.c (syms_of_sound):
1422 * syntax.c (init_syntax_once, syms_of_syntax):
1423 * terminal.c (syms_of_terminal):
1424 * textprop.c (syms_of_textprop):
1425 * undo.c (syms_of_undo):
1426 * w32.c (globals_of_w32):
1427 * window.c (syms_of_window):
1428 * xdisp.c (syms_of_xdisp):
1429 * xfaces.c (syms_of_xfaces):
1430 * xfns.c (syms_of_xfns):
1431 * xmenu.c (syms_of_xmenu):
1432 * xsettings.c (syms_of_xsettings):
1433 * xterm.c (syms_of_xterm): Use DEFSYM.
1434
1435 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1436
1437 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1438
1439 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1440
1441 Integer and buffer overflow fixes (Bug#8873).
1442
1443 * print.c (printchar, strout): Check for string overflow.
1444 (PRINTPREPARE, printchar, strout):
1445 Don't set size unless allocation succeeds.
1446
1447 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1448 for sizes. Check for string overflow more accurately.
1449 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1450
1451 * macros.c: Integer and buffer overflow fixes.
1452 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1453 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1454 Use ptrdiff_t, not int, for sizes.
1455 Don't increment bufsize until after realloc succeeds.
1456 Check for size-calculation overflow.
1457 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1458
1459 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1460
1461 * lread.c: Integer overflow fixes.
1462 (read_integer): Radix is now EMACS_INT, not int,
1463 to improve quality of diagnostics for out-of-range radices.
1464 Calculate buffer size correctly for out-of-range radices.
1465 (read1): Check for integer overflow in radices, and in
1466 read-circle numbers.
1467 (read_escape): Avoid int overflow.
1468 (Fload, openp, read_buffer_size, read1)
1469 (substitute_object_recurse, read_vector, read_list, map_obarray):
1470 Use ptrdiff_t, not int, for sizes.
1471 (read1): Use EMACS_INT, not int, for sizes.
1472 Check for size overflow.
1473
1474 * image.c (cache_image): Check for size arithmetic overflow.
1475
1476 * lread.c: Integer overflow issues.
1477 (saved_doc_string_size, saved_doc_string_length)
1478 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1479 Now ptrdiff_t, not int.
1480 (read1): Don't assume doc string length fits in int. Check for
1481 out-of-range doc string lengths.
1482 (read_list): Don't assume file position fits in int.
1483 (read_escape): Check for hex character overflow.
1484
1485 2011-06-22 Leo Liu <sdl.web@gmail.com>
1486
1487 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1488 Move to minibuffer.el.
1489
1490 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1491
1492 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1493 The following patches are for when GLYPH_DEBUG && !XASSERT.
1494 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1495 * dispnew.c (flush_stdout):
1496 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1497 Mark as externally visible.
1498 * dispnew.c (check_window_matrix_pointers): Now static.
1499 * dispnew.c (window_to_frame_vpos):
1500 * xfns.c (unwind_create_frame):
1501 * xterm.c (x_check_font): Remove unused local.
1502 * scroll.c (CHECK_BOUNDS):
1503 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1504 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1505 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1506 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1507 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1508 Now static.
1509 (debug_method_add): Use va_list and vsprintf rather than relying
1510 on undefined behavior with wrong number of arguments.
1511 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1512 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1513 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1514 since we're not interested in debugging glyphs with old libraries.
1515 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1516 GCC 4.6.0's static checking.
1517
1518 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1519
1520 Integer overflow and signedness fixes (Bug#8873).
1521 A few related buffer overrun fixes, too.
1522
1523 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1524
1525 * dispextern.h (struct face.stipple):
1526 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1527 (x_bitmap_mask, x_allocate_bitmap_record)
1528 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1529 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1530 (x_create_bitmap_from_xpm_data):
1531 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1532 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1533 (.bitmaps_last):
1534 * xfaces.c (load_pixmap):
1535 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1536 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1537 (.bitmaps_last, struct x_output.icon_bitmap):
1538 Use ptrdiff_t, not int, for bitmap indexes.
1539 (x_allocate_bitmap_record): Check for size overflow.
1540 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1541
1542 Use ptrdiff_t, not int, for overlay counts.
1543 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1544 * editfns.c (overlays_around, get_pos_property):
1545 * textprop.c (get_char_property_and_overlay):
1546 * xdisp.c (next_overlay_change, note_mouse_highlight):
1547 * xfaces.c (face_at_buffer_position):
1548 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1549 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1550 (Fnext_overlay_change, Fprevious_overlay_change)
1551 (mouse_face_overlay_overlaps, Foverlays_in):
1552 Use ptrdiff_t, not int, for sizes.
1553 (overlays_at, overlays_in): Check for size-calculation overflow.
1554
1555 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1556
1557 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1558 (x_session_initialize): Do not assume string length fits in int.
1559
1560 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1561 This is unlikely, but can occur if DPI is outlandish.
1562
1563 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1564 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1565
1566 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1567 * xrdb.c (magic_file_p, search_magic_path):
1568 Omit last arg SUFFIX; it was always 0. All callers changed.
1569 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1570
1571 * xfont.c (xfont_match): Avoid need for strlen.
1572
1573 * xfns.c: Don't assume strlen fits in int.
1574 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1575
1576 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1577 not unsigned long, as we prefer signed integers. All callers changed.
1578 Detect integer overflow in repeat count.
1579 (message_dolog): Don't assume print length fits in 39 bytes.
1580 (display_mode_element): Don't assume strlen fits in int.
1581
1582 * termcap.c: Don't assume sizes fit in int and never overflow.
1583 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1584 (gobble_line): Check for size-calculation overflow.
1585
1586 * minibuf.c (Fread_buffer):
1587 * lread.c (intern, intern_c_string):
1588 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1589 Don't assume string length fits in int.
1590
1591 * keyboard.c (parse_tool_bar_item):
1592 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1593
1594 * font.c: Don't assume string length fits in int.
1595 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1596 Use ptrdiff_t, not int.
1597 (font_intern_prop): Don't assume string length fits in int.
1598 Don't assume integer property fits in fixnum.
1599 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1600
1601 * filelock.c: Fix some buffer overrun and integer overflow issues.
1602 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1603 Reformulate so as not to need the command string.
1604 Invoke gzip -cd rather than gunzip, as it's more portable.
1605 (lock_info_type, lock_file_1, lock_file):
1606 Don't assume pid_t and time_t fit in unsigned long.
1607 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1608 (current_lock_owner): Prefer signed type for sizes.
1609 Use memcpy, not strncpy, where memcpy is what is really wanted.
1610 Don't assume (via atoi) that time_t and pid_t fit in int.
1611 Check for time_t and/or pid_t out of range, e.g., via a network share.
1612 Don't alloca where an auto var works fine.
1613
1614 * fileio.c: Fix some integer overflow issues.
1615 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1616 Don't assume string length fits in int.
1617 (directory_file_name): Don't assume string length fits in long.
1618 (make_temp_name): Don't assume pid fits in int, or that its print
1619 length is less than 20.
1620
1621 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1622
1623 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1624
1625 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1626
1627 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1628 We prefer signed integers, even for size calculations.
1629
1630 * emacs.c: Don't assume string length fits in 'int'.
1631 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1632 (main): Don't invoke strlen when not needed.
1633
1634 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1635 (XD_DEBUG_MESSAGE): Don't waste a byte.
1636
1637 * callproc.c (getenv_internal_1, getenv_internal)
1638 (Fgetenv_internal):
1639 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1640
1641 * lread.c (invalid_syntax): Omit length argument.
1642 All uses changed. This doesn't fix a bug, but it simplifies the
1643 code away from its former Hollerith-constant appearance, and it's
1644 one less 'int' to worry about when looking at integer-overflow issues.
1645 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1646
1647 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1648 This didn't break anything, but it didn't help either.
1649 It's confusing to put a bogus integer in a place where the actual
1650 value does not matter.
1651 (LIST_END_P): Remove unused macro and its bogus comment.
1652 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1653
1654 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1655 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1656 implementation.
1657 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1658 We prefer signed types, and the value cannot exceed the EMACS_INT
1659 range anyway (because otherwise the length would not be representable).
1660 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1661 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1662 This avoids a GCC warning when WIDE_EMACS_INT.
1663
1664 * indent.c (sane_tab_width): New function.
1665 (current_column, scan_for_column, Findent_to, position_indentation)
1666 (compute_motion): Use it. This is just for clarity.
1667 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1668
1669 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1670
1671 * lisp.h (lint_assume): New macro.
1672 * composite.c (composition_gstring_put_cache):
1673 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1674
1675 * editfns.c, insdel.c:
1676 Omit unnecessary forward decls, to simplify future changes.
1677
1678 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1679
1680 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1681
1682 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1683 Use much-faster test for byte-length change.
1684 Don't assume string byte-length fits in 'int'.
1685 Check that character arg fits in 'int'.
1686 (mapcar1): Declare byte as byte, for clarity.
1687
1688 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1689
1690 * fns.c (concat): Catch string overflow earlier.
1691 Do not rely on integer wraparound.
1692
1693 * dispextern.h (struct it.overlay_strings_charpos)
1694 (struct it.selective): Now EMACS_INT, not int.
1695 * xdisp.c (forward_to_next_line_start)
1696 (back_to_previous_visible_line_start)
1697 (reseat_at_next_visible_line_start, next_element_from_buffer):
1698 Don't arbitrarily truncate the value of 'selective' to int.
1699
1700 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1701
1702 * composite.c: Don't truncate sizes to 'int'.
1703 (composition_gstring_p, composition_reseat_it)
1704 (composition_adjust_point): Use EMACS_INT, not int.
1705 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1706 not EMACS_UINT, for indexes.
1707
1708 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1709
1710 * buffer.c: Include <verify.h>.
1711 (struct sortvec.priority, struct sortstr.priority):
1712 Now EMACS_INT, not int.
1713 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1714 (struct sortstr.size, record_overlay_string)
1715 (struct sortstrlist.size, struct sortlist.used):
1716 Don't truncate size to int.
1717 (record_overlay_string): Check for size-calculation overflow.
1718 (init_buffer_once): Check at compile-time, not run-time.
1719
1720 2011-06-22 Jim Meyering <meyering@redhat.com>
1721
1722 Don't leak an XBM-image-sized buffer
1723 * image.c (xbm_load): Free the image buffer after using it.
1724
1725 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1726
1727 Port to Sun C.
1728 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1729 that Sun C diagnosed.
1730 * fns.c (secure_hash): Fix pointer signedness issue.
1731 * intervals.c (static_offset_intervals): New function.
1732 (offset_intervals): Use it.
1733
1734 2011-06-21 Leo Liu <sdl.web@gmail.com>
1735
1736 * deps.mk (fns.o):
1737 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1738 sha512.h.
1739
1740 * fns.c (secure_hash): Rename from crypto_hash_function and change
1741 the first arg to accept symbols.
1742 (Fsecure_hash): New primitive.
1743 (syms_of_fns): New symbols.
1744
1745 2011-06-20 Deniz Dogan <deniz@dogan.se>
1746
1747 * process.c (Fset_process_buffer): Clarify return value in
1748 docstring.
1749
1750 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1751
1752 * dispnew.c (add_window_display_history): Use BVAR.
1753
1754 * xdisp.c (debug_method_add): Use BVAR.
1755 (check_window_end, dump_glyph_matrix, dump_glyph)
1756 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1757
1758 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1759 Likewise.
1760
1761 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1762 check till after the cache is created in init_frame_faces.
1763
1764 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1765
1766 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1767
1768 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1769
1770 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1771 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1772 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1773
1774 Improve buffer-overflow checking (Bug#8873).
1775 * fileio.c (Finsert_file_contents):
1776 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1777 Remove the old (too-loose) buffer overflow checks.
1778 They weren't needed, since make_gap checks for buffer overflow.
1779 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1780 The old code merely checked for Emacs fixnum overflow, and relied
1781 on undefined (wraparound) behavior. The new code avoids undefined
1782 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1783
1784 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1785 Tune. Don't use wider integers than needed. Don't use alloca.
1786 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1787
1788 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1789
1790 * insdel.c, lisp.h (buffer_overflow): New function.
1791 (insert_from_buffer_1, replace_range, replace_range_2):
1792 * insdel.c (make_gap_larger):
1793 * editfns.c (Finsert_char):
1794 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1795
1796 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1797
1798 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1799
1800 Integer overflow and signedness fixes (Bug#8873).
1801
1802 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1803 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1804
1805 * fileio.c: Don't assume EMACS_INT fits in off_t.
1806 (emacs_lseek): New static function.
1807 (Finsert_file_contents, Fwrite_region): Use it.
1808 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1809
1810 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1811
1812 * fns.c: Don't overflow int when computing a list length.
1813 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1814 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1815 truncation on 64-bit hosts. Check for QUIT every
1816 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1817 faster and is responsive enough.
1818 (Flength): Report an error instead of overflowing an integer.
1819 (Fsafe_length): Return a float if the value is not representable
1820 as a fixnum. This shouldn't happen except in contrived situations.
1821 (Fnthcdr, Fsort): Don't assume list length fits in int.
1822 (Fcopy_sequence): Don't assume vector length fits in int.
1823
1824 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1825 (header_size, word_size): New constants.
1826 (allocate_vectorlike): Don't check size overflow here.
1827 (allocate_vector): Check it here instead, since this is the only
1828 caller of allocate_vectorlike that could cause overflow.
1829 Check that the new vector's length is representable as a fixnum.
1830
1831 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1832 The previous code was bogus. For example, next_almost_prime (32)
1833 returned 39, which is undesirable as it is a multiple of 3; and
1834 next_almost_prime (24) returned 25, which is a multiple of 5 so
1835 why was the code bothering to check for multiples of 7?
1836
1837 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1838
1839 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1840
1841 Variadic C functions now count arguments with ptrdiff_t.
1842 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1843 Back then I didn't know that the Emacs coding style prefers signed int.
1844 Also, in the meantime I found a few more instances where arguments
1845 were being counted with int, which may truncate counts on 64-bit
1846 machines, or EMACS_INT, which may be unnecessarily wide.
1847 * lisp.h (struct Lisp_Subr.function.aMANY)
1848 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1849 Arg counts are now ptrdiff_t, not size_t.
1850 All variadic functions and their callers changed accordingly.
1851 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1852 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1853 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1854 * callint.c (Fcall_interactively): Check arg count for overflow,
1855 to avoid potential buffer overrun. Use signed char, not 'int',
1856 for 'varies' array, so that we needn't bother to check its size
1857 calculation for overflow.
1858 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1859 * eval.c (apply_lambda):
1860 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1861 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1862 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1863
1864 * callint.c (Fcall_interactively): Don't use index var as event count.
1865
1866 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1867 * mem-limits.h (SIZE): Remove; no longer used.
1868
1869 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1870
1871 Remove unnecessary casts.
1872 * xterm.c (x_term_init):
1873 * xfns.c (x_set_border_pixel):
1874 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1875 These aren't needed now that we assume ANSI C.
1876
1877 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1878 It's more likely to cause problems (due to unsigned overflow)
1879 than to cure them.
1880
1881 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1882
1883 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1884
1885 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1886
1887 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1888
1889 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1890
1891 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1892
1893 GLYPH_CODE_FACE returns EMACS_INT, not int.
1894 * dispextern.h (merge_faces):
1895 * xfaces.c (merge_faces):
1896 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1897 Don't assume EMACS_INT fits in int.
1898
1899 * character.h (CHAR_VALID_P): Remove unused parameter.
1900 * fontset.c, lisp.h, xdisp.c: All uses changed.
1901
1902 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1903
1904 * fns.c (concat): Minor tuning based on overflow analysis.
1905 This doesn't fix any bugs. Use int to hold character, instead
1906 of constantly refetching from Emacs object. Use XFASTINT, not
1907 XINT, for value known to be a character. Don't bother comparing
1908 a single byte to 0400, as it's always less.
1909
1910 * floatfns.c (Fexpt):
1911 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1912
1913 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1914 for characters.
1915
1916 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1917
1918 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1919 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1920 incorrectly succeed when S was a string, because 4294967386 was
1921 truncated before it was used.
1922
1923 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1924 Otherwise, an out-of-range integer could cause undefined behavior
1925 on a 64-bit host.
1926
1927 * composite.c: Use int, not EMACS_INT, for characters.
1928 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1929 EMACS_INT, for values that are known to be in character range.
1930 This doesn't fix any bugs but is the usual style inside Emacs and
1931 may generate better code on 32-bit machines.
1932
1933 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1934 This is for reasons similar to the recent CHAR_STRING fix.
1935 * charset.c (Fencode_char): Check that character arg is actually
1936 a character. Pass an int to ENCODE_CHAR.
1937 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1938 wider than 'int', as a compile-time check to prevent future regressions
1939 in this area.
1940
1941 * character.c (char_string): Remove unnecessary casts.
1942
1943 Make sure a 64-bit char is never passed to CHAR_STRING.
1944 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1945 by silently ignoring the top 32 bits, allowing some values
1946 that were far too large to be valid characters.
1947 * character.h: Include <verify.h>.
1948 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1949 arguments are no wider than unsigned, as a compile-time check
1950 to prevent future regressions in this area.
1951 * data.c (Faset):
1952 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1953 (Fsubst_char_in_region):
1954 * fns.c (concat):
1955 * xdisp.c (decode_mode_spec_coding):
1956 Adjust to CHAR_STRING's new requirement.
1957 * editfns.c (Finsert_char, Fsubst_char_in_region):
1958 * fns.c (concat): Check that character args are actually
1959 characters. Without this test, these functions did the wrong
1960 thing with wildly out-of-range values on 64-bit hosts.
1961
1962 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1963 These casts should not be needed on 32-bit hosts, either.
1964 * keyboard.c (read_char):
1965 * lread.c (Fload): Remove casts to unsigned.
1966
1967 * lisp.h (UNSIGNED_CMP): New macro.
1968 This fixes comparison bugs on 64-bit hosts.
1969 (ASCII_CHAR_P): Use it.
1970 * casefiddle.c (casify_object):
1971 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1972 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1973 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1974 * dispextern.h (FACE_FROM_ID):
1975 * keyboard.c (read_char): Use UNSIGNED_CMP.
1976
1977 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1978 not to EMACS_INT, to avoid GCC warning.
1979
1980 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1981
1982 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1983 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1984 isn't needed on 32-bit machines.
1985
1986 * buffer.c (Fgenerate_new_buffer_name):
1987 Use EMACS_INT for count, not int.
1988 (advance_to_char_boundary): Return EMACS_INT, not int.
1989
1990 * data.c (Qcompiled_function): Now static.
1991
1992 * window.c (window_body_lines): Now static.
1993
1994 * image.c (gif_load): Rename local to avoid shadowing.
1995
1996 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1997 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1998 * alloc.c (make_save_value): Integer argument is now of type
1999 ptrdiff_t, not int.
2000 (mark_object): Use ptrdiff_t, not int.
2001 * lisp.h (pD): New macro.
2002 * print.c (print_object): Use it.
2003
2004 * alloc.c: Use EMACS_INT, not int, to count objects.
2005 (total_conses, total_markers, total_symbols, total_vector_size)
2006 (total_free_conses, total_free_markers, total_free_symbols)
2007 (total_free_floats, total_floats, total_free_intervals)
2008 (total_intervals, total_strings, total_free_strings):
2009 Now EMACS_INT, not int. All uses changed.
2010 (Fgarbage_collect): Compute overall total using a double, so that
2011 integer overflow is less likely to be a problem. Check for overflow
2012 when converting back to an integer.
2013 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2014 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2015 These were 'int' variables that could overflow on 64-bit hosts;
2016 they were never used, so remove them instead of repairing them.
2017 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2018 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2019 Previously, this ceilinged at INT_MAX, but that doesn't work on
2020 64-bit machines.
2021 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2022
2023 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2024 (allocate_vectorlike): Check for ptrdiff_t overflow.
2025 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2026 when a (possibly-narrower) signed value would do just as well.
2027 We prefer using signed arithmetic, to avoid comparison confusion.
2028
2029 * alloc.c: Catch some string size overflows that we were missing.
2030 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2031 for convenience in STRING_BYTES_MAX.
2032 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2033 The definition here is exact; the one in lisp.h was approximate.
2034 (allocate_string_data): Check for string overflow. This catches
2035 some instances we weren't catching before. Also, it catches
2036 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2037 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2038 and ptrdiff_t and EMACS_INT are both 64 bits.
2039
2040 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2041 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2042 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
2043
2044 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2045
2046 * alloc.c (Fmake_string): Check for out-of-range init.
2047
2048 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2049
2050 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2051
2052 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2053
2054 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2055 xg_get_default_scrollbar_width.
2056
2057 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2058 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2059 (style_changed_cb): Call update_theme_scrollbar_width and call
2060 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2061 all frames (Bug#8505).
2062 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2063 Call gtk_window_set_resizable if HAVE_GTK3.
2064 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2065 and height if HAVE_GTK3 (Bug#8505).
2066 (scroll_bar_width_for_theme): New variable.
2067 (update_theme_scrollbar_width): New function.
2068 (xg_get_default_scrollbar_width): Move code to
2069 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2070 (xg_initialize): Call update_theme_scrollbar_width.
2071
2072 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2073
2074 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2075
2076 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2077
2078 * frame.c (make_frame): Call other_buffer_safely instead of
2079 other_buffer.
2080
2081 * window.c (temp_output_buffer_show): Call display_buffer with
2082 second argument Vtemp_buffer_show_specifiers and reset latter
2083 immediately after the call.
2084 (Vtemp_buffer_show_specifiers): New variable.
2085 (auto_window_vscroll_p, next_screen_context_lines)
2086 (Vscroll_preserve_screen_position): Remove leading asterisks from
2087 doc-strings.
2088
2089 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2090
2091 Fix minor problems found by GCC 4.6.0 static checking.
2092 * buffer.c (Qclone_number): Remove for now, as it's unused.
2093 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2094 (record_buffer): Remove unused local.
2095 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2096 (set_frame_buffer_list): Remove; unused.
2097 * frame.h (other_visible_frames): Remove decl.
2098 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2099 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2100 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2101 if HAVE_GPM.
2102 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2103 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2104 Define only if HAVE_GPM.
2105 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2106 (update_hints_inhibit): Remove; never set. All uses removed.
2107 * widgetprv.h (emacsFrameClassRec): Remove decl.
2108 * window.c (delete_deletable_window): Now returns void, since it
2109 wasn't returning anything.
2110 (compare_window_configurations): Remove unused locals.
2111 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2112 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2113 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2114 the same widths as pointers. This follows up on the 2011-05-06 patch.
2115 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2116 * xterm.h: Likewise.
2117 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2118
2119 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2120
2121 * makefile.w32-in: Update dependencies.
2122 (LISP_H): Add lib/intprops.h.
2123
2124 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2125
2126 * image.c (gif_load): Add animation frame delay to the metadata.
2127 (syms_of_image): Use DEFSYM. New symbol `delay'.
2128
2129 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2130
2131 * window.c (delete_deletable_window): Re-add.
2132 (Fset_window_configuration): Rewrite to handle dead buffers and
2133 consequently deletable windows.
2134 (window_tree, Fwindow_tree): Remove. Supply functionality in
2135 window.el.
2136 (compare_window_configurations): Simplify code.
2137
2138 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2139
2140 * image.c (imagemagick_load_image): Fix type mismatch.
2141 (Fimagemagick_types): Likewise.
2142
2143 * window.h (replace_buffer_in_windows): Declare.
2144
2145 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2146
2147 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2148 Qclone_number. Remove external declaration of Qdelete_window.
2149 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2150 code.
2151 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
2152 Qbuffer_list_update_hook if allowed.
2153 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2154 buffer list implementation.
2155 (other_buffer_safely): New function.
2156 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2157 calls to replace_buffer_in_windows and
2158 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2159 if allowed.
2160 (record_buffer): Inhibit quitting and rewrite using quittable
2161 functions. Run Qbuffer_list_update_hook if allowed.
2162 (Frecord_buffer, Funrecord_buffer): New functions.
2163 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
2164 switch-to-buffer to window.el.
2165 (bury-buffer): Move to window.el.
2166 (Vbuffer_list_update_hook): New variable.
2167
2168 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2169 section.
2170
2171 * window.h (resize_frame_windows): Move up in code.
2172 (Fwindow_frame): Remove EXFUN.
2173 (replace_buffer_in_all_windows): Remove prototype.
2174 (replace_buffer_in_windows_safely): Add prototype.
2175
2176 * window.c: Declare Qdelete_window static again. Move down
2177 declaration of select_count.
2178 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2179 (Fother_window): Move to window.el.
2180 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2181 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2182 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2183 window.el.
2184 (replace_buffer_in_windows): Implement by calling
2185 Qreplace_buffer_in_windows.
2186 (replace_buffer_in_all_windows): Remove with some functionality
2187 moved into replace_buffer_in_windows_safely.
2188 (replace_buffer_in_windows_safely): New function.
2189 (select_window_norecord, select_frame_norecord): Move in front
2190 of run_window_configuration_change_hook. Remove now obsolete
2191 declarations.
2192 (Fset_window_buffer): Rewrite doc-string. Call
2193 Qrecord_window_buffer.
2194 (keys_of_window): Move binding for other-window to window.el.
2195
2196 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2197
2198 * dispextern.h (struct image): Replace data member, whose int_val
2199 and ptr_val fields were not used by anything, with a single
2200 lisp_val object.
2201
2202 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2203 (gif_clear_image, gif_load, imagemagick_load_image)
2204 (gs_clear_image, gs_load): Callers changed.
2205
2206 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2207
2208 * buffer.h: Include <time.h>, for time_t.
2209 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2210
2211 Fix minor problems found by static checking.
2212
2213 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2214
2215 Make identifiers static if they are not used in other modules.
2216 * data.c (Qcompiled_function, Qframe, Qvector):
2217 * image.c (QimageMagick, Qsvg):
2218 * minibuf.c (Qmetadata):
2219 * window.c (resize_window_check, resize_root_window): Now static.
2220 * window.h (resize_window_check, resize_root_window): Remove decls.
2221
2222 * window.c (window_deletion_count, delete_deletable_window):
2223 Remove; unused.
2224 (window_body_lines): Now static.
2225 (Fdelete_other_windows_internal): Mark vars as initialized.
2226 Make sure 'resize_failed' is initialized.
2227 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2228 (resize_window_apply): Remove unused local.
2229 * window.h (delete_deletable_window): Remove decl.
2230
2231 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2232 (imagemagick_load_image): Fix pointer signedness problem by changing
2233 last arg from unsigned char * to char *. All uses changed.
2234 Also, fix a local for similar reasons.
2235 Remove unused locals. Remove locals to avoid shadowing.
2236 (fn_rsvg_handle_free): Remove; unused.
2237 (svg_load, svg_load_image): Fix pointer signedness problem.
2238 (imagemagick_load_image): Don't use garbage pointer image_wand.
2239
2240 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2241
2242 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2243
2244 * image.c (gif_load): Fix omitted cast error introduced by
2245 2011-06-06 change.
2246
2247 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2248
2249 * window.h (resize_proportionally, orig_total_lines)
2250 (orig_top_line): Remove from window structure.
2251 (set_window_height, set_window_width, change_window_heights)
2252 (Fdelete_window): Remove prototypes.
2253 (resize_frame_windows): Remove duplicate declaration.
2254
2255 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2256
2257 * window.h (resize_frame_windows, resize_window_check)
2258 (delete_deletable_window, resize_root_window)
2259 (resize_frame_windows): Declare prototypes.
2260
2261 * window.c (resize_window_apply): Make definition be "static" to
2262 match the prototype.
2263
2264 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2265
2266 * window.c: Remove declarations of Qwindow_size_fixed,
2267 window_min_size_1, window_min_size_2, window_min_size,
2268 size_window, window_fixed_size_p, enlarge_window, delete_window.
2269 Remove static from declaration of Qdelete_window, it's
2270 temporarily needed by Fbury_buffer.
2271 (replace_window): Don't assign orig_top_line and
2272 orig_total_lines.
2273 (Fdelete_window, delete_window): Remove. Window deletion is
2274 handled by window.el.
2275 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
2276 Fdelete_window calls with calls to Qdelete_window.
2277 (Fdelete_other_windows): Remove. Deleting other windows is
2278 handled by window.el.
2279 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2280 handled in window.el.
2281 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2282 Window minimum sizes are handled in window.el.
2283 (shrink_windows, size_window, set_window_height)
2284 (set_window_width, change_window_heights, window_height)
2285 (window_width, CURBEG, CURSIZE, enlarge_window)
2286 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2287 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2288 handled in window.el.
2289 (make_dummy_parent): Rename to make_parent_window and give it a
2290 second argument horflag.
2291 (make_window): Don't set resize_proportionally any more.
2292 (Fsplit_window): Remove. Windows are split in window.el.
2293 (save_restore_action, save_restore_orig_size)
2294 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2295 Resize mini windows in window.el.
2296 (grow_mini_window, shrink_mini_window): Implement by calling
2297 Qresize_root_window_vertically, resize_window_check and
2298 resize_window_apply.
2299 (saved_window, Fset_window_configuration, save_window_save): Do
2300 not handle orig_top_line, orig_total_lines, and
2301 resize_proportionally.
2302 (window_min_height, window_min_width): Move to window.el.
2303 (keys_of_window): Move bindings for delete-other-windows,
2304 split-window, delete-window and enlarge-window to window.el.
2305
2306 * buffer.c: Temporarily extern Qdelete_window.
2307 (Fbury_buffer): Temporarily call Qdelete_window instead of
2308 Fdelete_window (Fbury_buffer will move to window.el soon).
2309
2310 * frame.c (set_menu_bar_lines_1): Remove code handling
2311 orig_top_line and orig_total_lines.
2312
2313 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2314 set_window_height but set heights directly.
2315 (change_frame_size_1): Use resize_frame_windows.
2316
2317 * xdisp.c (init_xdisp): Don't use set_window_height but set
2318 heights directly.
2319
2320 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
2321 resize_frame_windows instead of change_window_heights and run
2322 run_window_configuration_change_hook.
2323
2324 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2325 instead of change_window_heights and run
2326 run_window_configuration_change_hook.
2327
2328 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2329
2330 * window.c (replace_window): Rename second argument REPLACEMENT to
2331 NEW. New third argument SETFLAG. Rewrite.
2332 (delete_window, make_dummy_parent): Call replace_window with
2333 third argument 1.
2334 (window_list_1): Move down in code.
2335 (run_window_configuration_change_hook): Move set_buffer part
2336 before select_frame_norecord part in order to unwind correctly.
2337 Rename count1 to count.
2338 (recombine_windows, delete_deletable_window, resize_root_window)
2339 (Fdelete_other_windows_internal)
2340 (Frun_window_configuration_change_hook, make_parent_window)
2341 (resize_window_check, resize_window_apply, Fresize_window_apply)
2342 (resize_frame_windows, Fsplit_window_internal)
2343 (Fdelete_window_internal, Fresize_mini_window_internal): New
2344 functions.
2345 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2346
2347 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2348
2349 * window.h (window): Add some new members to window structure -
2350 normal_lines, normal_cols, new_total, new_normal, clone_number,
2351 splits, nest, prev_buffers, next_buffers.
2352 (WINDOW_TOTAL_SIZE): Move here from window.c.
2353 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2354
2355 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2356 Remove.
2357 (make_dummy_parent): Set new members of windows structure.
2358 (make_window): Move down in code. Handle new members of window
2359 structure.
2360 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2361 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2362 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2363 (Fset_window_prev_buffers, Fwindow_next_buffers)
2364 (Fset_window_next_buffers, Fset_window_clone_number): New
2365 functions.
2366 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2367 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2368 Doc-string fixes.
2369 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2370 Argument WINDOW can be now internal window too.
2371 (Fwindow_use_time): Move up in code.
2372 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2373 Rewrite doc-string.
2374 (Fset_window_configuration, saved_window)
2375 (Fcurrent_window_configuration, save_window_save): Handle new
2376 members of window structure.
2377 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2378 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2379 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2380 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2381 Qget_mru_window, Qresize_root_window,
2382 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2383 Qauto_buffer_name; staticpro them.
2384
2385 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2386
2387 * window.c (Fwindow_total_size, Fwindow_left_column)
2388 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2389 (Fwindow_list_1): New functions.
2390 (window_box_text_cols): Replace with window_body_cols.
2391 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2392 window_body_cols instead of window_box_text_cols.
2393 (delete_window, Fset_window_configuration): Call
2394 delete_all_subwindows with window as argument.
2395 (delete_all_subwindows): Take a window as argument and not a
2396 structure. Rewrite.
2397 (window_loop): Remove handling of GET_LRU_WINDOW and
2398 GET_LARGEST_WINDOW.
2399 (Fget_lru_window, Fget_largest_window): Move to window.el.
2400
2401 * window.h: Extern window_body_cols instead of
2402 window_box_text_cols. delete_all_subwindows now takes a
2403 Lisp_Object as argument.
2404
2405 * indent.c (compute_motion, Fcompute_motion): Use
2406 window_body_cols instead of window_box_text_cols.
2407
2408 * frame.c (delete_frame): Call delete_all_subwindows with root
2409 window as argument.
2410
2411 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2412
2413 * fns.c (Fputhash): Document return value.
2414
2415 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2416
2417 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2418
2419 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2420
2421 Cons<->int and similar integer overflow fixes (Bug#8794).
2422
2423 Check for overflow when converting integer to cons and back.
2424 * charset.c (Fdefine_charset_internal, Fdecode_char):
2425 Use cons_to_unsigned to catch overflow.
2426 (Fencode_char): Use INTEGER_TO_CONS.
2427 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2428 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2429 * data.c (long_to_cons, cons_to_long): Remove.
2430 (cons_to_unsigned, cons_to_signed): New functions.
2431 These signal an error for invalid or out-of-range values.
2432 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2433 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2434 * font.c (Ffont_variation_glyphs):
2435 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2436 * lisp.h: Include <intprops.h>.
2437 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2438 (cons_to_signed, cons_to_unsigned): New decls.
2439 (long_to_cons, cons_to_long): Remove decls.
2440 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2441 (Fprimitive_undo): Use CONS_TO_INTEGER.
2442 * xfns.c (Fx_window_property): Likewise.
2443 * xselect.c: Include <limits.h>.
2444 (x_own_selection, selection_data_to_lisp_data):
2445 Use INTEGER_TO_CONS.
2446 (x_handle_selection_request, x_handle_selection_clear)
2447 (x_get_foreign_selection, Fx_disown_selection_internal)
2448 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2449 (lisp_data_to_selection_data): Use cons_to_unsigned.
2450 (x_fill_property_data): Use cons_to_signed.
2451 Report values out of range.
2452
2453 Check for buffer and string overflow more precisely.
2454 * buffer.h (BUF_BYTES_MAX): New macro.
2455 * lisp.h (STRING_BYTES_MAX): New macro.
2456 * alloc.c (Fmake_string):
2457 * character.c (string_escape_byte8):
2458 * coding.c (coding_alloc_by_realloc):
2459 * doprnt.c (doprnt):
2460 * editfns.c (Fformat):
2461 * eval.c (verror):
2462 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2463 since they may not be the same number.
2464 * editfns.c (Finsert_char):
2465 * fileio.c (Finsert_file_contents):
2466 Likewise for BUF_BYTES_MAX.
2467
2468 * image.c: Use ptrdiff_t, not int, for sizes.
2469 (slurp_file): Switch from int to ptrdiff_t.
2470 All uses changed.
2471 (slurp_file): Check that file size fits in both size_t (for
2472 malloc) and ptrdiff_t (for sanity and safety).
2473
2474 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2475 if b->modtime has its maximal value.
2476
2477 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2478
2479 Don't assume time_t can fit into int.
2480 * buffer.h (struct buffer.modtime): Now time_t, not int.
2481 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2482 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2483
2484 Minor fixes for signed vs unsigned integers.
2485 * character.h (MAYBE_UNIFY_CHAR):
2486 * charset.c (maybe_unify_char):
2487 * keyboard.c (read_char, reorder_modifiers):
2488 XINT -> XFASTINT, since the integer must be nonnegative.
2489 * ftfont.c (ftfont_spec_pattern):
2490 * keymap.c (access_keymap, silly_event_symbol_error):
2491 XUINT -> XFASTINT, since the integer must be nonnegative.
2492 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2493 since it makes no difference and we prefer signed.
2494 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2495 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2496 nonnegative.
2497
2498 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2499
2500 * window.h (Fwindow_frame): Declare.
2501
2502 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2503
2504 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2505 (SPARE_MEMORY): Always define.
2506 (LARGE_REQUEST): Remove.
2507 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2508
2509 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2510
2511 * lisp.h: Move EXFUNS for Fframe_root_window,
2512 Fframe_first_window and Fset_frame_selected_window to window.h.
2513
2514 * window.h: Move EXFUNS for Fframe_root_window,
2515 Fframe_first_window and Fset_frame_selected_window here from
2516 lisp.h.
2517
2518 * frame.c (Fwindow_frame, Fframe_first_window)
2519 (Fframe_root_window, Fframe_selected_window)
2520 (Fset_frame_selected_window): Move to window.c.
2521 (Factive_minibuffer_window): Move to minibuf.c.
2522 (Fother_visible_frames_p): New function.
2523
2524 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2525
2526 * window.c (decode_window, decode_any_window): Move up in code.
2527 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2528 (inhibit_frame_unsplittable): Remove unused variable.
2529 (Fwindow_buffer): Move up and rewrite doc-string.
2530 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2531 (Fwindow_prev): New functions.
2532 (Fwindow_frame): Move here from frame.c. Accept any window as
2533 argument.
2534 (Fframe_root_window, Fframe_first_window)
2535 (Fframe_selected_window): Move here from frame.c. Accept frame
2536 or arbitrary window as argument. Update doc-strings.
2537 (Fminibuffer_window): Move up in code.
2538 (Fwindow_minibuffer_p): Move up in code and simplify.
2539 (Fset_frame_selected_window): Move here from frame.c.
2540 Marginal rewrite.
2541 (Fselected_window, select_window, Fselect_window): Move up in
2542 code. Minor doc-string fixes.
2543
2544 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2545
2546 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2547 Do not assume that spare memory exists; that assumption is valid
2548 only if SYSTEM_MALLOC.
2549 (LARGE_REQUEST): New macro, so that the issue of large requests
2550 is separated from the issue of spare memory.
2551
2552 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2553
2554 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2555 format. (Bug#8806)
2556
2557 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2558
2559 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2560 before statements.
2561
2562 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2563
2564 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2565
2566 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2567
2568 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2569 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2570
2571 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2572
2573 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2574
2575 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2576
2577 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2578 (x_clipboard_manager_save): Add return value.
2579 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2580 New error handlers.
2581 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2582 Obey Vx_select_enable_clipboard_manager. Catch errors in
2583 x_clipboard_manager_save (Bug#8779).
2584 (Vx_select_enable_clipboard_manager): New variable.
2585 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2586
2587 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2588
2589 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2590
2591 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2592
2593 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2594 in the current matrix if keep_current_p is non-zero.
2595
2596 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2597
2598 * bidi.c (bidi_level_of_next_char): Fix last change.
2599
2600 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2601
2602 Support bidi reordering of text covered by display properties.
2603
2604 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2605 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2606 (bidi_cache_search, bidi_cache_iterator_state)
2607 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2608 (bidi_level_of_next_char, bidi_move_to_visually_next):
2609 Support character positions inside a run of characters covered by a
2610 display string.
2611 (bidi_paragraph_init, bidi_resolve_explicit_1)
2612 (bidi_level_of_next_char): Call bidi_fetch_char and
2613 bidi_fetch_char_advance instead of FETCH_CHAR and
2614 FETCH_CHAR_ADVANCE.
2615 (bidi_init_it): Initialize new members.
2616 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2617 definitions.
2618 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2619 instead of using explicit *_CHAR codes.
2620 (bidi_resolve_explicit, bidi_resolve_weak):
2621 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2622 bidirectional text is supported only in multibyte buffers.
2623 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2624 it to initialize the frame_window_p member of struct bidi_it.
2625 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2626 (bidi_resolve_explicit, bidi_resolve_weak)
2627 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2628 bidi_it->nchars is non-positive.
2629 (bidi_level_of_next_char): Don't try to lookup the cache for the
2630 next/previous character if nothing is cached there yet, or if we
2631 were just reseat()'ed to a new position.
2632
2633 * xdisp.c (set_cursor_from_row): Set start and stop points
2634 according to the row's direction when priming the loop that looks
2635 for the glyph on which to display cursor.
2636 (single_display_spec_intangible_p): Function deleted.
2637 (display_prop_intangible_p): Reimplement to call
2638 handle_display_spec instead of single_display_spec_intangible_p.
2639 Accept 3 additional arguments needed by handle_display_spec.
2640 This fixes incorrect cursor motion across display property with complex
2641 values: lists, `(when COND...)' forms, etc.
2642 (single_display_spec_string_p): Support property values that are
2643 lists with the argument STRING its top-level element.
2644 (display_prop_string_p): Fix the condition for processing a
2645 property that is a list to be consistent with handle_display_spec.
2646 (handle_display_spec): New function, refactored from the
2647 last portion of handle_display_prop.
2648 (compute_display_string_pos): Accept additional argument
2649 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2650 value of a `display' property is a "replacing spec".
2651 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2652 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2653 the display property, but just return a value indicating whether
2654 the display property will replace the characters it covers.
2655 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2656 frame_window_p members of struct bidi_it.
2657 (compute_display_string_pos, compute_display_string_end):
2658 New functions.
2659 (push_it): Accept second argument POSITION, where pop_it should
2660 jump to continue iteration.
2661 (reseat_1): Initialize bidi_it.disp_pos.
2662
2663 * keyboard.c (adjust_point_for_property): Adjust the call to
2664 display_prop_intangible_p to its new signature.
2665
2666 * dispextern.h (struct bidi_it): New member frame_window_p.
2667 (bidi_init_it): Update prototypes.
2668 (display_prop_intangible_p): Update prototype.
2669 (compute_display_string_pos, compute_display_string_end):
2670 Declare prototypes.
2671 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2672 EMACS_INT.
2673
2674 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2675
2676 Malloc failure behavior now depends on size of allocation.
2677 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2678 * lisp.h: Change signatures accordingly.
2679 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2680 All callers changed. (Bug#8762)
2681
2682 * gnutls.c: Use Emacs's memory allocators.
2683 Without this change, the gnutls library would invoke malloc etc.
2684 directly, which causes problems on non-SYNC_INPUT hosts, and which
2685 runs afoul of improving memory_full behavior. (Bug#8761)
2686 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2687 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2688 xfree instead of the default malloc, realloc, free.
2689 (Fgnutls_boot): No need to check for memory allocation failure,
2690 since xmalloc does that for us.
2691
2692 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2693 * category.c (hash_get_category_set):
2694 * ccl.c (ccl_driver):
2695 * charset.c (Fdefine_charset_internal):
2696 * charset.h (struct charset.hash_index):
2697 * composite.c (get_composition_id, gstring_lookup_cache)
2698 (composition_gstring_put_cache):
2699 * composite.h (struct composition.hash_index):
2700 * dispextern.h (struct image.hash):
2701 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2702 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2703 (hashfn_equal, hashfn_user_defined, make_hash_table)
2704 (maybe_resize_hash_table, hash_lookup, hash_put)
2705 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2706 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2707 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2708 * image.c (make_image, search_image_cache, lookup_image)
2709 (xpm_put_color_table_h):
2710 * lisp.h (struct Lisp_Hash_Table):
2711 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2712 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2713 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2714 * alloc.c (allocate_vectorlike):
2715 Check for overflow in vector size calculations.
2716 * ccl.c (ccl_driver):
2717 Check for overflow when converting EMACS_INT to int.
2718 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2719 need to be updated by these changes.
2720 * fns.c (make_hash_table, maybe_resize_hash_table):
2721 Check for integer overflow with large hash tables.
2722 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2723 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2724 (SXHASH_REDUCE): New macro.
2725 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2726 Use it instead of discarding useful hash info with large hash values.
2727 (sxhash_float): New function.
2728 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2729 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2730 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2731 Rewrite to use FIXNUM_BITS, as this simplifies things.
2732 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2733 Adjust signatures to match updated version of code.
2734 (consing_since_gc): Now EMACS_INT, since a single hash table can
2735 use more than INT_MAX bytes.
2736
2737 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2738
2739 Make it possible to build with GCC-4.6+ -O2 -flto.
2740
2741 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2742
2743 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2744
2745 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2746 Call minibuffer-inactive-mode.
2747
2748 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2749
2750 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2751 Update dependencies.
2752
2753 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2754
2755 * data.c (init_data): Remove code for UTS, this system is not
2756 supported anymore.
2757
2758 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2759
2760 Don't force ./temacs to start in terminal mode.
2761
2762 * frame.c (make_initial_frame): Initialize faces in all cases, not
2763 only when CANNOT_DUMP is defined.
2764 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2765
2766 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2767
2768 * dispnew.c (add_window_display_history): Use const for the string
2769 pointer. Remove declaration, not needed.
2770
2771 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2772
2773 Use 'inline', not 'INLINE'.
2774 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2775 * alloc.c, fontset.c (INLINE): Remove.
2776 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2777 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2778 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2779 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2780 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2781
2782 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2783
2784 Make it possible to run ./temacs.
2785
2786 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2787 syms_of_callproc does the same thing. Remove test for
2788 "initialized", do it in the caller.
2789 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2790
2791 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2792
2793 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2794 (read_minibuf): Use get_minibuffer.
2795 (syms_of_minibuf): Use DEFSYM.
2796 (Qmetadata): New var.
2797 * data.c (Qbuffer): Don't make it static.
2798 (syms_of_data): Use DEFSYM.
2799
2800 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2801
2802 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2803 (CCL_CODE_MIN): New macro.
2804
2805 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2806
2807 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2808
2809 * eval.c (Qdebug): Now static.
2810 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2811 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2812 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2813
2814 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2815
2816 * image.c: Various fixes to ImageMagick code comments.
2817 (Fimagemagick_types): Doc fix.
2818
2819 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2820
2821 Minor fixes prompted by GCC 4.6.0 warnings.
2822
2823 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2824
2825 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2826 (x_clipboard_manager_save_all): Move extern decl to ...
2827 * xterm.h: ... here, so that it can be checked for consistency.
2828
2829 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2830
2831 * xselect.c (x_clipboard_manager_save_frame)
2832 (x_clipboard_manager_save_all): New functions.
2833 (Fx_clipboard_manager_save): Lisp function deleted.
2834
2835 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2836 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2837
2838 * xterm.h: Update prototype.
2839
2840 2011-05-28 William Xu <william.xwl@gmail.com>
2841
2842 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2843 exiting (Bug#8239).
2844
2845 2011-05-28 Jim Meyering <meyering@redhat.com>
2846
2847 Avoid a sign-extension bug in crypto_hash_function.
2848 * fns.c (to_uchar): Define.
2849 (crypto_hash_function): Use it to convert some newly-signed
2850 variables to unsigned, to avoid sign-extension bugs. For example,
2851 without this change, (md5 "truc") would evaluate to
2852 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2853 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2854 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2855
2856 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2857
2858 Integer overflow fixes.
2859
2860 * dbusbind.c: Serial number integer overflow fixes.
2861 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2862 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2863 to hold a serial number that is too large for a fixnum.
2864 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2865 Check for serial numbers out of range. Decode any serial number
2866 that was so large that it became a float. (Bug#8722)
2867
2868 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2869 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2870 Use XFASTINT rather than XUINT when numbers are nonnegative.
2871 (xd_append_arg, Fdbus_method_return_internal):
2872 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2873 arguments, check that Lisp number is nonnegative, rather than
2874 silently wrapping negative numbers around. (Bug#8722)
2875 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2876 (Bug#8722)
2877
2878 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2879
2880 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2881
2882 ccl: add integer overflow checks
2883 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2884 (IN_INT_RANGE): New macros.
2885 (ccl_driver): Use them to check for integer overflow when
2886 decoding a CCL program. Many of the new checks are whether XINT (x)
2887 fits in int; it doesn't always, on 64-bit hosts. The new version
2888 doesn't catch all possible integer overflows, but it's an
2889 improvement. (Bug#8719)
2890
2891 * alloc.c (make_event_array): Use XINT, not XUINT.
2892 There's no need for unsigned here.
2893
2894 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2895 This follows up to the 2011-05-06 change that substituted uintptr_t
2896 for EMACS_INT. This case wasn't caught back then.
2897
2898 Rework Fformat to avoid integer overflow issues.
2899 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2900 now (part of C89). Include <verify.h>.
2901 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2902 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2903 (Fformat): Avoid the prepass trying to compute sizes; it was only
2904 approximate and thus did not catch overflow reliably. Instead, walk
2905 through the format just once, formatting and computing sizes as we go,
2906 checking for integer overflow at every step, and allocating a larger
2907 buffer as needed. Keep track separately whether the format is
2908 multibyte. Keep only the most-recently calculated precision, rather
2909 than them all. Record whether each argument has been converted to
2910 string. Use EMACS_INT, not int, for byte and char and arg counts.
2911 Support field widths and precisions larger than INT_MAX. Avoid
2912 sprintf's undefined behavior with conversion specifications such as %#d
2913 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2914 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2915 formatting out-of-range floating point numbers with int
2916 formats. (Bug#8668)
2917
2918 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2919
2920 * data.c: Avoid integer truncation in expressions involving floats.
2921 * data.c: Include <intprops.h>.
2922 (arith_driver): When there's an integer overflow in an expression
2923 involving floating point, convert the integers to floating point
2924 so that the resulting value does not suffer from catastrophic
2925 integer truncation. For example, on a 64-bit host (* 4
2926 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2927 Do not rely on undefined behavior after integer overflow.
2928
2929 merge count_size_as_multibyte, parse_str_to_multibyte
2930 * character.c, character.h (count_size_as_multibyte):
2931 Rename from parse_str_to_multibyte; all uses changed.
2932 Check for integer overflow.
2933 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2934 since it's now a duplicate of the other. This is more of
2935 a character than a buffer op, so better that it's in character.c.
2936 * fns.c, print.c: Adjust to above changes.
2937
2938 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2939
2940 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2941
2942 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2943
2944 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2945 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2946 (x_clipboard_manager_save): Now static.
2947 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2948
2949 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2950 (crypto_hash_function): Now static.
2951 Fix pointer signedness problems. Avoid unnecessary initializations.
2952
2953 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2954
2955 * termhooks.h (Vselection_alist): Make it terminal-local.
2956
2957 * terminal.c (create_terminal): Initialize it.
2958
2959 * xselect.c: Support for clipboard managers.
2960 (Vselection_alist): Move to termhooks.h as terminal-local var.
2961 (LOCAL_SELECTION): New macro.
2962 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2963 (symbol_to_x_atom): Remove gratuitous arg.
2964 (x_handle_selection_request, lisp_data_to_selection_data)
2965 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2966 (x_own_selection, x_get_local_selection, x_convert_selection):
2967 New arg, specifying work frame. Use terminal-local Vselection_alist.
2968 (some_frame_on_display): Delete unused function.
2969 (Fx_own_selection_internal, Fx_get_selection_internal)
2970 (Fx_disown_selection_internal, Fx_selection_owner_p)
2971 (Fx_selection_exists_p): New optional frame arg.
2972 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2973 (x_handle_selection_clear): Don't treat other terminals with the
2974 same keyboard specially. Use the terminal-local Vselection_alist.
2975 (x_clear_frame_selections): Use Frun_hook_with_args.
2976
2977 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2978
2979 * xterm.h: Add support for those atoms.
2980
2981 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2982
2983 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2984 (converted_selections, conversion_fail_tag): New global variables.
2985 (x_selection_request_lisp_error): Free the above.
2986 (x_get_local_selection): Remove unnecessary code.
2987 (x_reply_selection_request): Args changed; handle arbitrary array
2988 of converted selections stored in converted_selections.
2989 Separate the XChangeProperty and SelectionNotify steps.
2990 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2991 (x_convert_selection): New function.
2992 (x_handle_selection_event): Simplify.
2993 (x_get_foreign_selection): Don't ignore incoming requests while
2994 waiting for an answer; this will fail when we implement
2995 SAVE_TARGETS, and seems unnecessary anyway.
2996 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2997 (Vx_sent_selection_functions): Doc fix.
2998
2999 2011-05-26 Leo Liu <sdl.web@gmail.com>
3000
3001 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3002
3003 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3004
3005 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3006
3007 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3008 for fringe update if it has periodic bitmap.
3009 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3010 and fringe_bitmap_periodic_p.
3011
3012 * fringe.c (get_fringe_bitmap_data): New function.
3013 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3014 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3015 row. Mark glyph row for fringe update if periodicity changed.
3016
3017 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3018 for fringe update unless it has periodic bitmap.
3019
3020 2011-05-25 Kenichi Handa <handa@m17n.org>
3021
3022 * xdisp.c (get_next_display_element): Set correct it->face_id for
3023 a static composition.
3024
3025 2011-05-24 Leo Liu <sdl.web@gmail.com>
3026
3027 * deps.mk (fns.o):
3028 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3029
3030 * fns.c (crypto_hash_function, Fsha1): New function.
3031 (Fmd5): Use crypto_hash_function.
3032 (syms_of_fns): Add Ssha1.
3033
3034 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3035
3036 * gnutls.c: Remove unused macros.
3037 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3038 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3039 Remove macros that are defined and never used.
3040 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3041
3042 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3043
3044 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3045 (Fx_get_selection_internal): Minor cleanup.
3046 (Fx_own_selection_internal): Rename arguments for consistency with
3047 select.el.
3048
3049 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3050
3051 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3052
3053 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3054
3055 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3056
3057 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3058
3059 * dispnew.c (scrolling_window): Don't exclude the case that the
3060 last enabled row in the desired matrix touches the bottom boundary.
3061
3062 2011-05-21 Glenn Morris <rgm@gnu.org>
3063
3064 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3065 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3066 and add some more files.
3067
3068 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3069
3070 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3071 report_file_error introduced by the change from 2011-05-07.
3072
3073 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3074
3075 * systime.h (Time): Define only if emacs is defined.
3076 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3077 where the include path doesn't have X11/X.h by default. See
3078 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3079
3080 2011-05-20 Kenichi Handa <handa@m17n.org>
3081
3082 * composite.c (find_automatic_composition): Fix previous change.
3083
3084 2011-05-20 Glenn Morris <rgm@gnu.org>
3085
3086 * lisp.mk: New file, split from Makefile.in.
3087 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3088 (shortlisp): Remove.
3089 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3090
3091 2011-05-19 Glenn Morris <rgm@gnu.org>
3092
3093 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3094 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3095 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3096 (lisp): Set the order to that of loadup.el.
3097 (shortlisp): Make it a copy of $lisp.
3098 (SOME_MACHINE_LISP): Remove.
3099 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3100 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3101
3102 2011-05-18 Kenichi Handa <handa@m17n.org>
3103
3104 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3105 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3106 (find_automatic_composition): Mostly rewrite for efficiency.
3107
3108 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3109
3110 * makefile.w32-in: Update dependencies.
3111
3112 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3113
3114 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3115 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3116
3117 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3118
3119 Fix some integer overflow issues, such as string length overflow.
3120
3121 * insdel.c (count_size_as_multibyte): Check for string overflow.
3122
3123 * character.c (lisp_string_width): Check for string overflow.
3124 Use EMACS_INT, not int, for string indexes and lengths; in
3125 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3126 the resulting string length overflows an EMACS_INT; instead,
3127 report a string overflow if no precision given. When checking for
3128 precision exhaustion, use a check that cannot possibly have
3129 integer overflow. (Bug#8675)
3130 * character.h (lisp_string_width): Adjust to new signature.
3131
3132 * alloc.c (string_overflow): New function.
3133 (Fmake_string): Use it. This doesn't change behavior, but saves
3134 a few bytes and will simplify future changes.
3135 * character.c (string_escape_byte8): Likewise.
3136 * lisp.h (string_overflow): New decl.
3137
3138 Fixups, following up to the user-interface timestamp change.
3139 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3140 for UI timestamps, instead of unsigned long.
3141 * msdos.c (mouse_get_pos): Likewise.
3142 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3143 * w32gui.h (Time): Define by including "systime.h" rather than by
3144 declaring it ourselves. (Bug#8664)
3145
3146 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3147 * image.c (clear_image_cache): Likewise.
3148
3149 * term.c (term_mouse_position): Don't assume time_t wraparound.
3150
3151 Be more systematic about user-interface timestamps.
3152 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3153 and sometimes 'EMACS_UINT', to represent these timestamps.
3154 This change causes it to use 'Time' uniformly, as that's what X uses.
3155 This makes the code easier to follow, and makes it easier to catch
3156 integer overflow bugs such as Bug#8664.
3157 * frame.c (Fmouse_position, Fmouse_pixel_position):
3158 Use Time, not unsigned long, for user-interface timestamps.
3159 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3160 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3161 * keyboard.h (last_event_timestamp): Likewise.
3162 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3163 * menu.h (xmenu_show): Likewise.
3164 * term.c (term_mouse_position): Likewise.
3165 * termhooks.h (struct input_event.timestamp): Likewise.
3166 (struct terminal.mouse_position_hook): Likewise.
3167 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3168 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3169 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3170 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3171 what it was before.
3172 * menu.h, termhooks.h: Include "systime.h", for Time.
3173
3174 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3175 Don't assume that the difference between two unsigned long values
3176 can fit into an integer. At this point, we know button_down_time
3177 <= event->timestamp, so the difference must be nonnegative, so
3178 there's no need to cast the result if double-click-time is
3179 nonnegative, as it should be; check that it's nonnegative, just in
3180 case. This bug is triggered when events are more than 2**31 ms
3181 apart (about 25 days). (Bug#8664)
3182
3183 * xselect.c (last_event_timestamp): Remove duplicate decl.
3184 (x_own_selection): Remove needless cast to unsigned long.
3185
3186 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3187 that always fit in int. Use a sentinel instead of a counter, to
3188 avoid a temp and to allay GCC's concerns about possible int overflow.
3189 * frame.h (struct frame): Use int for menu_bar_items_used
3190 instead of EMACS_INT, since it always fits in int.
3191
3192 * menu.c (grow_menu_items): Check for int overflow.
3193
3194 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3195
3196 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3197 Before, the code was not consistent. These values cannot exceed
3198 2**31 - 1 so there's no need to make them unsigned.
3199 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3200 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3201 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3202 as modifiers.
3203 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3204
3205 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3206 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3207 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3208 presumably because the widths might not match.
3209
3210 * window.c (size_window): Avoid needless test at loop start.
3211
3212 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3213
3214 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3215
3216 2011-05-12 Drew Adams <drew.adams@oracle.com>
3217
3218 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3219
3220 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3221
3222 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3223 `width' to `bar_area_x' and `bar_area_width', respectively.
3224 (x_scroll_run): Take account of fringe background extension.
3225
3226 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3227 Rename local vars `left' and `width' to `bar_area_x' and
3228 `bar_area_width', respectively.
3229 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3230 background extension.
3231
3232 2011-05-10 Jim Meyering <meyering@redhat.com>
3233
3234 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3235
3236 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3237
3238 * image.c (Finit_image_library): Return t for built-in image types,
3239 like pbm and xbm. (Bug#8640)
3240
3241 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3242
3243 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3244
3245 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3246
3247 * w32console.c (Fset_screen_color): Doc fix.
3248 (Fget_screen_color): New function.
3249 (syms_of_ntterm): Defsubr it.
3250
3251 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3252 unlink the temporary file if Fcall_process didn't create it in the
3253 first place.
3254 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3255 child process will be redirected to a file specified with `:file'.
3256 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3257 cue to call_process_cleanup not to close that handle.
3258
3259 2011-05-07 Ben Key <bkey76@gmail.com>
3260
3261 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3262 one of two shell specific rules, either bootstrap-temacs-CMD or
3263 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3264 to the previous implementation of the bootstrap-temacs rule.
3265 The bootstrap-temacs-CMD rule is similar to the previous
3266 implementation of the bootstrap-temacs rule except that it
3267 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3268 variable.
3269
3270 These changes, along with some changes to nt/configure.bat,
3271 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3272 earlier fix to add support for --cflags and --ldflags options
3273 that include quotes so that it works whether make uses cmd or
3274 sh as the shell.
3275
3276 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3277
3278 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3279 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3280 is a constant.
3281 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3282 a string. Handle both cases.
3283 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3284 (Fdbus_register_method): Use Qinvalid_function.
3285
3286 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3287
3288 * makefile.w32-in: Update dependencies.
3289 (LISP_H): Add inttypes.h and stdin.h.
3290 (PROCESS_H): Add unistd.h.
3291
3292 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3293
3294 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3295 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3296
3297 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3298
3299 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3300
3301 * term.c (vfatal): Remove stray call to va_end.
3302 It's not needed and the C Standard doesn't allow it here anyway.
3303
3304 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3305 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3306
3307 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3308 bytes.
3309
3310 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3311
3312 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3313
3314 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3315
3316 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3317
3318 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3319
3320 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3321 * charset.c (Fdefine_charset_internal): Don't initialize
3322 charset.code_space[15]. The value was garbage, on hosts with
3323 32-bit int (Bug#8600).
3324
3325 * lread.c (read_integer): Be more consistent with string-to-number.
3326 Use string_to_number to do the actual conversion; this avoids
3327 rounding errors and fixes some other screwups. Without this fix,
3328 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3329 (digit_to_number): Move earlier, for benefit of read_integer.
3330 Return -1 if the digit is out of range for the base, -2 if it is
3331 not a digit in any supported base. (Bug#8602)
3332
3333 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3334
3335 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3336 to match comment at start of function. This also removes a
3337 GCC warning about overflow in a 32+64-bit port.
3338
3339 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3340
3341 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3342 Reported by Stefan Monnier in
3343 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3344 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3345 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3346
3347 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3348 (EMACS_UINTPTR): Likewise, with uintptr_t.
3349
3350 * lisp.h: Prefer 64-bit EMACS_INT if available.
3351 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3352 on 32-bit hosts that have 64-bit int, so that they can access
3353 large files.
3354 However, temporarily disable this change unless the temporary
3355 symbol WIDE_EMACS_INT is defined.
3356
3357 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3358
3359 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3360 This removes an assumption that EMACS_INT and long are the same
3361 width as pointers. The assumption is true for Emacs porting targets
3362 now, but we want to make other targets possible.
3363 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3364 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3365 In the rest of the code, change types of integers that hold casted
3366 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3367 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3368 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3369 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3370 No need to cast type when ORing.
3371 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3372 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3373 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3374 assume EMACS_INT is the same width as char *.
3375 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3376 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3377 Remove no-longer-needed casts.
3378 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3379 (xg_tool_bar_help_callback, xg_make_tool_item):
3380 Use EMACS_INTPTR to hold an integer
3381 that will be cast to void *; this can avoid a GCC warning
3382 if EMACS_INT is not the same width as void *.
3383 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3384 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3385 (current_message_1, set_message_1):
3386 Use a local to convert to proper width without a cast.
3387 * xmenu.c (dialog_selection_callback): Likewise.
3388
3389 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3390 Also, don't assume VALBITS / RAND_BITS is less than 5,
3391 and don't rely on undefined behavior when shifting a 1 left into
3392 the sign bit.
3393 * lisp.h (get_random): Change signature to match.
3394
3395 * lread.c (hash_string): Use size_t, not int, for hash computation.
3396 Normally we prefer signed values; but hashing is special, because
3397 it's better to use unsigned division on hash table sizes so that
3398 the remainder is nonnegative. Also, size_t is the natural width
3399 for hashing into memory. The previous code used 'int', which doesn't
3400 retain enough info to hash well into very large tables.
3401 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3402
3403 * dbusbind.c: Don't possibly lose pointer info when converting.
3404 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3405 Use XPNTR rather than XHASH, so that the high-order bits of
3406 the pointer aren't lost when converting through void *.
3407
3408 * eval.c (Fautoload): Don't double-shift a pointer.
3409
3410 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3411
3412 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3413
3414 * gnutls.c (DEF_GNUTLS_FN):
3415 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3416
3417 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3418
3419 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3420 marker. (Bug#8610)
3421
3422 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3423
3424 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3425 New version that can reserve upto 2GB of heap space.
3426
3427 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3428
3429 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3430
3431 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3432
3433 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3434 `gnutls_certificate_set_x509_key_file'.
3435
3436 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3437
3438 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3439 Update dependencies.
3440
3441 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3442
3443 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3444 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3445 Remove unused parameter `fildes'.
3446 * process.c (read_process_output, send_process): Don't pass it.
3447
3448 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3449
3450 Fix previous change: the library cache is defined in w32.c.
3451 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3452 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3453
3454 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3455
3456 Implement dynamic loading of GnuTLS on Windows.
3457
3458 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3459 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3460 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3461 Declare.
3462
3463 * gnutls.c (Qgnutls_dll): Define.
3464 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3465 (gnutls_*): Declare function pointers.
3466 (init_gnutls_functions): New function to initialize function pointers.
3467 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3468 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3469 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3470 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3471 (emacs_gnutls_write, emacs_gnutls_read)
3472 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3473 (Fgnutls_available_p): New function.
3474 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3475 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3476 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3477
3478 * image.c: Include w32.h.
3479 (Vimage_type_cache): Delete.
3480 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3481 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3482 (w32_delayed_load): Move to w32.c.
3483
3484 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3485
3486 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3487 (w32_delayed_load): Move from image.c. When loading a library, record
3488 its filename in the :loaded-from property of the library id.
3489 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3490 Initialize and staticpro them.
3491 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3492
3493 * process.c: Include lisp.h before w32.h, not after.
3494 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3495 instead of gnutls_record_check_pending.
3496
3497 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3498
3499 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3500
3501 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3502 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3503 as passed in.
3504
3505 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3506
3507 * xterm.c (x_set_frame_alpha): Do not set property on anything
3508 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3509
3510 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3511
3512 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3513
3514 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3515
3516 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3517 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3518 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3519 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3520 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3521 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3522 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3523 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3524 (Qgnutls_bootprop_callbacks_verify): Make static.
3525
3526 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3527
3528 * callproc.c: Indentation fixup.
3529
3530 * sysdep.c (wait_for_termination_1): Make static.
3531 (wait_for_termination, interruptible_wait_for_termination):
3532 Move after wait_for_termination_1.
3533
3534 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3535
3536 * sysdep.c (interruptible_wait_for_termination): New function
3537 which is like wait_for_termination, but allows keyboard
3538 interruptions.
3539
3540 * callproc.c (Fcall_process): Add (:file "file") as an option for
3541 the STDOUT buffer.
3542 (Fcall_process_region): Ditto.
3543
3544 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3545
3546 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3547 rather than `XVECTOR (FOO)->size'.
3548
3549 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3550 inttypes.h, as a gnulib replacement is used if it not available in
3551 system headers.
3552
3553 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3554
3555 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3556 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3557 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3558
3559 * coding.c (coding_alloc_by_realloc): Error out if destination
3560 will grow beyond MOST_POSITIVE_FIXNUM.
3561 (decode_coding_emacs_mule): Abort if there isn't enough place in
3562 charbuf for the composition carryover bytes. Reserve an extra
3563 space for up to 2 characters produced in a loop.
3564 (decode_coding_iso_2022): Abort if there isn't enough place in
3565 charbuf for the composition carryover bytes.
3566
3567 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3568
3569 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3570 aborting when %lld or %lll format is passed.
3571 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3572 %llo or %llx format is passed. (Bug#8545)
3573
3574 * window.c (window_scroll_line_based): Use a marker instead of
3575 simple variables to record original value of point. (Bug#7952)
3576
3577 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3578 produced by %s or %c overflows available buffer space. (Bug#8545)
3579
3580 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3581
3582 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3583 (SIZE_MAX): Move defn after all includes, as they might #define it.
3584
3585 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3586
3587 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3588
3589 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3590
3591 * keyboard.c (Qdelayed_warnings_hook): Define.
3592 (command_loop_1): Run `delayed-warnings-hook'
3593 if Vdelayed_warnings_list is non-nil.
3594 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3595 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3596
3597 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3598
3599 * doprnt.c (doprnt): Don't return value smaller than the buffer
3600 size if the message was truncated. (Bug#8545).
3601
3602 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3603
3604 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3605 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3606
3607 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3608
3609 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3610
3611 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3612
3613 * makefile.w32-in: Update dependencies.
3614
3615 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3616
3617 Improve `doprnt' and its usage. (Bug#8545)
3618 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3619 `format_end'. Remove support for %l as a conversion specifier.
3620 Don't use xrealloc. Improve diagnostics when the %l size modifier
3621 is used. Update the commentary.
3622
3623 * eval.c (verror): Simplify calculation of size_t.
3624
3625 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3626 messages.
3627
3628 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3629
3630 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3631 change.
3632
3633 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3634
3635 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3636 This makes this file independent of the recent pseudovector change.
3637
3638 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3639
3640 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3641
3642 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3643 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3644 Remove unused local.
3645 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3646
3647 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3648 GCC 4.6.0 optimizes based on type-based alias analysis.
3649 For example, if b is of type struct buffer * and v of type struct
3650 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3651 != &v->size, and therefore "v->size = 1; b->size = 2; return
3652 v->size;" must therefore return 1. This assumption is incorrect
3653 for Emacs, since it type-puns struct Lisp_Vector * with many other
3654 types. To fix this problem, this patch adds a new type struct
3655 vectorlike_header that documents the constraints on layout of vectors
3656 and pseudovectors, and helps optimizing compilers not get fooled
3657 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3658 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3659 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3660 the size member.
3661 (XSETPVECTYPE): Rewrite in terms of new macro.
3662 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3663 This is a bit clearer, and further avoids the possibility of
3664 undesirable aliasing.
3665 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3666 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3667 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3668 since Lisp_Subr is a special case (no "next" field).
3669 (ASIZE): Now uses header.size rather than size.
3670 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3671 to avoid the hassle of writing XVECTOR (foo)->header.size.
3672 (struct vectorlike_header): New type.
3673 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3674 object, to help avoid aliasing.
3675 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3676 (SUBRP): Likewise, since Lisp_Subr is a special case.
3677 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3678 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3679 (struct Lisp_Hash_Table): Combine first two members into a single
3680 struct vectorlike_header member. All uses of "size" and "next" members
3681 changed to be "header.size" and "header.next".
3682 * buffer.h (struct buffer): Likewise.
3683 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3684 * frame.h (struct frame): Likewise.
3685 * process.h (struct Lisp_Process): Likewise.
3686 * termhooks.h (struct terminal): Likewise.
3687 * window.c (struct save_window_data, struct saved_window): Likewise.
3688 * window.h (struct window): Likewise.
3689 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3690 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3691 * buffer.c (init_buffer_once): Likewise.
3692 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3693 special case.
3694 * process.c (Fformat_network_address): Use local var for size,
3695 for brevity.
3696
3697 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3698
3699 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3700 * data.c (atof): Remove decl; no longer used or needed.
3701 (digit_to_number): Move to lread.c.
3702 (Fstring_to_number): Use new string_to_number function, to be
3703 consistent with how the Lisp reader treats infinities and NaNs.
3704 Do not assume that floating-point numbers represent EMACS_INT
3705 without losing information; this is not true on most 64-bit hosts.
3706 Avoid double-rounding errors, by insisting on integers when
3707 parsing non-base-10 numbers, as the documentation specifies.
3708 * lisp.h (string_to_number): New decl, replacing ...
3709 (isfloat_string): Remove.
3710 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3711 (read1): Do not accept +. and -. as integers; this
3712 appears to have been a coding error. Similarly, do not accept
3713 strings like +-1e0 as floating point numbers. Do not report
3714 overflow for integer overflows unless the base is not 10 which
3715 means we have no simple and reliable way to continue.
3716 Break out the floating-point parsing into a new
3717 function string_to_number, so that Fstring_to_number parses
3718 floating point numbers consistently with the Lisp reader.
3719 (digit_to_number): Move here from data.c. Make it static inline.
3720 (E_CHAR, EXP_INT): Remove, replacing with ...
3721 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3722 (string_to_number): New function, replacing isfloat_string.
3723 This function checks for valid syntax and produces the resulting
3724 Lisp float number too. Rework it so that string-to-number
3725 no longer mishandles examples like "1.0e+". Use strtoumax,
3726 so that overflow for non-base-10 numbers is reported only when
3727 there's no portable and simple way to convert to floating point.
3728
3729 * textprop.c (set_text_properties_1): Rewrite for clarity,
3730 and to avoid GCC warning about integer overflow.
3731
3732 * intervals.h (struct interval): Use EMACS_INT for members
3733 where EMACS_UINT might cause problems. See
3734 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3735 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3736 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3737 All uses changed.
3738 (offset_intervals): Tell GCC not to worry about length overflow
3739 when negating a negative length.
3740
3741 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3742 (overrun_check_free): Likewise.
3743
3744 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3745 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3746 word size.
3747
3748 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3749 (gnutls_make_error): Rename local to avoid shadowing.
3750 (gnutls_emacs_global_deinit): ifdef out; not used.
3751 (Fgnutls_boot): Use const for pointer to readonly storage.
3752 Comment out unused local. Fix pointer signedness problems.
3753
3754 * lread.c (openp): Don't stuff size_t into an 'int'.
3755 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3756 about possible signed overflow.
3757
3758 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3759 (GDK_KEY_g): Don't define if already defined.
3760 (xg_prepare_tooltip): Avoid pointer signedness problem.
3761 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3762
3763 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3764 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3765
3766 * xfns.c (Fx_window_property): Simplify a bit,
3767 to make a bit faster and to avoid GCC 4.6.0 warning.
3768 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3769
3770 * fns.c (internal_equal): Don't assume size_t fits in int.
3771
3772 * alloc.c (compact_small_strings): Tighten assertion a little.
3773
3774 Replace pEd with more-general pI, and fix some printf arg casts.
3775 * lisp.h (pI): New macro, generalizing old pEd macro to other
3776 conversion specifiers. For example, use "...%"pI"d..." rather
3777 than "...%"pEd"...".
3778 (pEd): Remove. All uses replaced with similar uses of pI.
3779 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3780 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3781 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3782 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3783 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3784 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3785 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3786 64-bit hosts.
3787 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3788 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3789 * print.c (safe_debug_print, print_object): Likewise.
3790 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3791 to int.
3792 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3793 avoiding the 0 flag, which is not portable.
3794 * process.c (Fmake_network_process): Use pI to avoid cast.
3795 * region-cache.c (pp_cache): Likewise.
3796 * xdisp.c (decode_mode_spec): Likewise.
3797 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3798 behavior on 64-bit hosts with printf arg.
3799 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3800 (x_stop_queuing_selection_requests): Likewise.
3801 (x_get_window_property): Don't truncate byte count to an 'int'
3802 when tracing.
3803
3804 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3805 here, since it parses constructs like leading '-' and spaces,
3806 which are not wanted; and it overflows with large numbers.
3807 Instead, simply match F[0-9]+, which is what is wanted anyway.
3808
3809 * alloc.c: Remove unportable assumptions about struct layout.
3810 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3811 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3812 (allocate_vectorlike, make_pure_vector): Use the new macros,
3813 plus offsetof, to remove unportable assumptions about struct layout.
3814 These assumptions hold on all porting targets that I know of, but
3815 they are not guaranteed, they're easy to remove, and removing them
3816 makes further changes easier.
3817
3818 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3819 This doesn't fix a bug but makes the code clearer.
3820 (string_overrun_cookie): Now const. Use initializers that
3821 don't formally overflow signed char, to avoid warnings.
3822 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3823 can cause Emacs to crash when string overrun checking is enabled.
3824 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3825 multiple of sizeof (EMACS_INT); it need not be, if
3826 alignof(EMACS_INT) < sizeof (EMACS_INT).
3827 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3828
3829 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3830
3831 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3832
3833 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3834
3835 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3836 supposed to be handshaking. (Bug#8556)
3837 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3838
3839 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3840
3841 * lisp.h (Qdebug): List symbol.
3842 * eval.c (Qdebug): Restore global linkage.
3843 * keyboard.c (debug-on-event): New variable.
3844 (handle_user_signal): Break into debugger when debug-on-event
3845 matches the current signal symbol.
3846
3847 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3848
3849 * alloc.c (check_sblock, check_string_bytes)
3850 (check_string_free_list): Convert to standard C.
3851
3852 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3853
3854 * w32.c (emacs_gnutls_push): Fix typo.
3855
3856 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3857
3858 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3859 "cast to pointer from integer of different size".
3860
3861 Improve doprnt and its use in verror. (Bug#8545)
3862 * doprnt.c (doprnt): Document the set of format control sequences
3863 supported by the function. Use SAFE_ALLOCA instead of always
3864 using `alloca'.
3865
3866 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3867 is one byte too soon. Don't use xrealloc; instead xfree and
3868 xmalloc anew.
3869
3870 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3871
3872 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3873 callbacks stage.
3874
3875 * gnutls.c: Renamed global_initialized to
3876 gnutls_global_initialized. Added internals for the
3877 :verify-hostname-error, :verify-error, and :verify-flags
3878 parameters of `gnutls-boot' and documented those parameters in the
3879 docstring. Start callback support.
3880 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3881 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3882 on error. Return error code.
3883 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3884 (emacs_gnutls_read): Likewise.
3885 (Fgnutls_boot): Return handshake error code.
3886 (emacs_gnutls_handle_error): New function.
3887 (wsaerror_to_errno): Likewise.
3888
3889 * w32.h (emacs_gnutls_pull): Add prototype.
3890 (emacs_gnutls_push): Likewise.
3891
3892 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3893 (emacs_gnutls_push): Likewise.
3894
3895 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3896
3897 * process.c (wait_reading_process_output): Check if GnuTLS
3898 buffered some data internally if no FDs are set for TLS
3899 connections.
3900
3901 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3902 (LIBS): Link to USER_LIBS.
3903 ($(BLD)/gnutls.$(0)): New target.
3904
3905 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3906
3907 * xdisp.c (handle_single_display_spec): Rename the
3908 display_replaced_before_p argument into display_replaced_p, to
3909 make it consistent with the commentary. Fix typos in the
3910 commentary.
3911
3912 * textprop.c (syms_of_textprop): Remove dead code.
3913 (copy_text_properties): Delete obsolete commentary about an
3914 interface that was deleted long ago. Fix typos in the description
3915 of arguments.
3916
3917 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3918 to changes in oldXMenu/XMenu.h from 2011-04-16.
3919 <menu_help_message, prev_menu_help_message>: Constify.
3920 (IT_menu_make_room): menu->help_text is now `const char **';
3921 adjust.
3922
3923 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3924 to changes in oldXMenu/XMenu.h from 2011-04-16.
3925 (struct XMenu): Declare `help_text' `const char **'.
3926
3927 * xfaces.c <Qunspecified>: Make extern again.
3928
3929 * syntax.c: Include sys/types.h before including regex.h, as
3930 required by Posix.
3931
3932 * doc.c (get_doc_string): Improve the format passed to `error'.
3933
3934 * doprnt.c (doprnt): Improve commentary.
3935
3936 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3937
3938 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3939 them with etags.
3940
3941 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3942 changes in globals.h immediately force recompilation.
3943 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3944 $(CURDIR)/s/ms-w32.h.
3945 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3946
3947 * character.c (Fchar_direction): Function deleted.
3948 (syms_of_character): Don't defsubr it.
3949 <char-direction-table>: Deleted.
3950
3951 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3952
3953 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3954 * doprnt.c: Include limits.h.
3955 (SIZE_MAX): New macro.
3956 (doprnt): Return a size_t value. 2nd arg is now size_t.
3957 Many local variables are now size_t instead of int or unsigned.
3958 Improve overflow protection. Support `l' modifier for integer
3959 conversions. Support %l conversion. Don't assume an EMACS_INT
3960 argument for integer conversions and for %c.
3961
3962 * lisp.h (doprnt): Restore prototype.
3963
3964 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3965 $(SRC)/character.h.
3966
3967 * Makefile.in (base_obj): Add back doprnt.o.
3968
3969 * deps.mk (doprnt.o): Add back prerequisites.
3970 (callint.o): Depend on character.h.
3971
3972 * eval.c (internal_lisp_condition_case): Include the handler
3973 representation in the error message.
3974 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3975 when breaking from the loop.
3976
3977 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3978
3979 * callint.c (Fcall_interactively): When displaying error message
3980 about invalid control letter, pass the character's codepoint, not
3981 a pointer to its multibyte form. Improve display of the character
3982 in octal and display also its hex code.
3983
3984 * character.c (char_string): Use %x to display the (unsigned)
3985 codepoint of an invalid character, to avoid displaying a bogus
3986 negative value.
3987
3988 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3989 `error', not SYMBOL_NAME itself.
3990
3991 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3992 character arguments to `error'.
3993
3994 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3995 to `error' in error message about FINAL_CHAR argument. Make sure
3996 FINAL_CHAR is a character, and use %c when it is passed as
3997 argument to `error'.
3998
3999 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4000
4001 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4002
4003 * w32.c: Include <time.h>.
4004 (sys_localtime): New function.
4005
4006 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4007
4008 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4009
4010 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4011
4012 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4013
4014 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4015 zombies (Bug#8467).
4016
4017 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4018
4019 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4020 gl_state.e_property when gl_state.object is Qt.
4021
4022 * insdel.c (make_gap_larger): Remove limitation of buffer size
4023 to <= INT_MAX.
4024
4025 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4026
4027 * xdisp.c (lookup_glyphless_char_display)
4028 (produce_glyphless_glyph): Handle cons cell entry in
4029 glyphless-char-display.
4030 (Vglyphless_char_display): Document it.
4031
4032 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4033 glyphless-char-display.
4034
4035 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4036
4037 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4038
4039 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4040
4041 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4042 definition for no-X builds.
4043
4044 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4045
4046 Static checks with GCC 4.6.0 and non-default toolkits.
4047
4048 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4049
4050 * process.c (keyboard_bit_set): Define only if SIGIO.
4051 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4052 (send_process): Repair possible setjmp clobbering.
4053
4054 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4055
4056 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4057
4058 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4059
4060 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4061 Define only if needed.
4062
4063 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4064 by pacifying GCC about it. Maybe it's time to retire it?
4065 * xfaces.c (USG, __TIMEVAL__): Likewise.
4066
4067 * dispextern.h (struct redisplay_interface): Rename param
4068 to avoid shadowing.
4069 * termhooks.h (struct terminal): Likewise.
4070 * xterm.c (xembed_send_message): Likewise.
4071
4072 * insdel.c (make_gap_smaller): Define only if
4073 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4074
4075 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4076 it.
4077
4078 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4079 so that we aren't warned about unused symbols.
4080
4081 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4082
4083 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4084
4085 * xfns.c (x_real_positions): Mark locals as initialized.
4086
4087 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4088
4089 * xterm.c: Fix problems found by static analysis with other toolkits.
4090 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4091 (x_dispatch_event): Declare static if USE_GTK, and
4092 define if USE_GTK || USE_X_TOOLKIT.
4093 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4094 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4095 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4096 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4097
4098 * xmenu.c (menu_help_callback): Pointer type fixes.
4099 Use const pointers when pointing at readonly data. Avoid pointer
4100 signedness clashes.
4101 (FALSE): Remove unused macro.
4102 (update_frame_menubar): Remove unused decl.
4103
4104 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4105
4106 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4107 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4108 (single_menu_item): Rename local to avoid shadowing.
4109
4110 * keyboard.c (make_lispy_event): Remove unused local var.
4111
4112 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4113 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4114
4115 * bitmaps: Change bitmaps from unsigned char back to the X11
4116 compatible char. Avoid the old compiler warnings about
4117 out-of-range initializers by using, for example, '\xab' rather
4118 than 0xab.
4119
4120 * xgselect.c (xgselect_initialize): Check vs interface
4121 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4122
4123 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4124
4125 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4126 to read-only memory.
4127
4128 * fns.c (vector): Remove; this old hack is no longer needed.
4129
4130 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4131 Remove unused var.
4132 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4133
4134 * xrdb.c (x_load_resources): Omit unused local.
4135
4136 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4137 (x_window): Rename locals to avoid shadowing.
4138 (USG): Use the kludged USG macro, to pacify gcc.
4139
4140 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4141 (x_term_init): Remove local to avoid shadowing.
4142
4143 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4144
4145 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4146 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4147
4148 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4149
4150 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4151
4152 Fix regex.c, syntax.c and friends for buffers > 2GB.
4153 * syntax.h (struct gl_state_s): Declare character position members
4154 EMACS_INT.
4155
4156 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4157
4158 * textprop.c (verify_interval_modification, interval_of):
4159 Declare arguments EMACS_INT.
4160
4161 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4162 EMACS_INT.
4163
4164 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4165
4166 * indent.c (Fvertical_motion): Local variable it_start is now
4167 EMACS_INT.
4168
4169 * regex.c (re_match, re_match_2, re_match_2_internal)
4170 (bcmp_translate, regcomp, regexec, print_double_string)
4171 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4172 (re_compile_pattern, re_exec): Declare arguments and local
4173 variables `size_t' and `ssize_t' and return values `regoff_t', as
4174 appropriate.
4175 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4176 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4177 <compile_stack_type>: `size' and `avail' are now `size_t'.
4178
4179 * regex.h <regoff_t>: Use ssize_t, not int.
4180 (re_search, re_search_2, re_match, re_match_2): Arguments that
4181 specify buffer/string position and length are now ssize_t and
4182 size_t. Return type is regoff_t.
4183
4184 2011-04-16 Ben Key <bkey76@gmail.com>
4185
4186 * nsfont.m: Fixed bugs in ns_get_family and
4187 ns_descriptor_to_entity that were caused by using free to
4188 deallocate memory blocks that were allocated by xmalloc (via
4189 xstrdup). This caused Emacs to crash when compiled with
4190 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4191 --enable-checking=xmallocoverrun). xfree is now used to
4192 deallocate these memory blocks.
4193
4194 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4195
4196 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4197
4198 emacs_write: Accept and return EMACS_INT for sizes.
4199 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4200 et seq.
4201 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4202 Accept and return EMACS_INT.
4203 (emacs_gnutls_write): Return the number of bytes written on
4204 partial writes.
4205 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4206 (emacs_read, emacs_write): Remove check for negative size, as the
4207 Emacs source code has been audited now.
4208 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4209 (emacs_read, emacs_write): Use it.
4210 * process.c (send_process): Adjust to the new signatures of
4211 emacs_write and emacs_gnutls_write. Do not attempt to store
4212 a byte offset into an 'int'; it might overflow.
4213 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4214
4215 * sound.c: Don't assume sizes fit in 'int'.
4216 (struct sound_device.period_size, alsa_period_size):
4217 Return EMACS_INT, not int.
4218 (struct sound_device.write, vox_write, alsa_write):
4219 Accept EMACS_INT, not int.
4220 (wav_play, au_play): Use EMACS_INT to store sizes and to
4221 record read return values.
4222
4223 2011-04-15 Ben Key <bkey76@gmail.com>
4224
4225 * keyboard.c (Qundefined): Don't declare static since it is used
4226 in nsfns.m.
4227 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4228 static since they are used in nsfont.m.
4229
4230 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4231
4232 * process.c (Qprocessp): Don't declare static.
4233 * lisp.h (Qprocessp): Declare again.
4234
4235 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4236
4237 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4238
4239 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4240
4241 Improve C-level modularity by making more things 'static'.
4242
4243 Don't publish debugger-only interfaces to other modules.
4244 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4245 (verify_bytepos, count_markers): Move decls to the only modules
4246 that need them.
4247 * region-cache.h (pp_cache): Likewise.
4248 * window.h (check_all_windows): Likewise.
4249 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4250
4251 * sysdep.c (croak): Now static, if
4252 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4253 * syssignal.h (croak): Declare only if not static.
4254
4255 * alloc.c (refill_memory_reserve): Now static if
4256 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4257 * lisp.h (refill_memory_reserve): Declare only if not static.
4258
4259 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4260 Define only if USE_LUCID.
4261
4262 * xrdb.c (x_customization_string, x_rm_string): Now static.
4263
4264 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4265 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4266
4267 * xdisp.c (draw_row_with_mouse_face): Now static.
4268 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4269
4270 * window.h (check_all_windows): Mark externally visible.
4271
4272 * window.c (window_deletion_count): Now static.
4273
4274 * undo.c: Make symbols static if they're not exported.
4275 (last_undo_buffer, last_boundary_position, pending_boundary):
4276 Now static.
4277
4278 * textprop.c (interval_insert_behind_hooks): Now static.
4279 (interval_insert_in_front_hooks): Likewise.
4280
4281 * term.c: Make symbols static if they're not exported.
4282 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4283 (max_frame_lines, tty_set_terminal_modes):
4284 (tty_reset_terminal_modes, tty_turn_off_highlight):
4285 (get_tty_terminal): Now static.
4286 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4287 * termhooks.h (term_mouse_moveto): Do not declare if
4288 HAVE_WINDOW_SYSTEM.
4289 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4290 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4291
4292 * sysdep.c: Make symbols static if they're not exported.
4293 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4294 Now static.
4295 (sigprocmask_set, full_mask): Remove; unused.
4296 (wait_debugging): Mark as visible.
4297 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4298 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4299
4300 * syntax.c (syntax_temp): Define only if !__GNUC__.
4301
4302 * sound.c (current_sound_device, current_sound): Now static.
4303
4304 * search.c (searchbufs, searchbuf_head): Now static.
4305
4306 * scroll.c (scroll_cost): Remove; unused.
4307 * dispextern.h (scroll_cost): Remove decl.
4308
4309 * region-cache.h (pp_cache): Mark as externally visible.
4310
4311 * process.c: Make symbols static if they're not exported.
4312 (process_tick, update_tick, create_process, chan_process):
4313 (Vprocess_alist, proc_buffered_char, datagram_access):
4314 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4315 (deactivate_process): Mark defn as static, as well as decl.
4316 * lisp.h (create_process): Remove decl.
4317 * process.h (chan_process, Vprocess_alist): Remove decls.
4318
4319 * print.c: Make symbols static if they're not exported.
4320 (print_depth, new_backquote_output, being_printed, print_buffer):
4321 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4322 (print_interval, print_number_index, initial_stderr_stream):
4323 Now static.
4324 * lisp.h (Fprinc): Remove decl.
4325 (debug_output_compilation_hack): Mark as externally visible.
4326
4327 * sysdep.c (croak): Move decl from here to syssignal.h.
4328 * syssignal.h (croak): Put it here, so the API can be checked when
4329 'croak' is called from dissociate_if_controlling_tty.
4330
4331 * minibuf.c: Make symbols static if they're not exported.
4332 (minibuf_save_list, choose_minibuf_frame): Now static.
4333 * lisp.h (choose_minibuf_frame): Remove decl.
4334
4335 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4336
4337 * lread.c: Make symbols static if they're not exported.
4338 (read_objects, initial_obarray, oblookup_last_bucket_number):
4339 Now static.
4340 (make_symbol): Remove; unused.
4341 * lisp.h (initial_obarray, make_symbol): Remove decls.
4342
4343 * keyboard.c: Make symbols static if they're not exported.
4344 (single_kboard, recent_keys_index, total_keys, recent_keys):
4345 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4346 (this_single_command_key_start, echoing, last_auto_save):
4347 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4348 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4349 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4350 (Vlispy_mouse_stem, double_click_count):
4351 Now static.
4352 (force_auto_save_soon): Define only if SIGDANGER.
4353 (ignore_mouse_drag_p): Now static if
4354 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4355 (print_help): Remove; unused.
4356 (stop_character, last_timer_event): Mark as externally visible.
4357 * keyboard.h (ignore_mouse_drag_p): Declare only if
4358 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4359 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4360 * lisp.h (echoing): Remove decl.
4361 (force_auto_save_soon): Declare only if SIGDANGER.
4362 * xdisp.c (redisplay_window): Simplify code, to make it more
4363 obvious that ignore_mouse_drag_p is not accessed if !defined
4364 USE_GTK && !defined HAVE_NS.
4365
4366 * intervals.c: Make symbols static if they're not exported.
4367 (merge_properties_sticky, merge_interval_right, delete_interval):
4368 Now static.
4369 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4370
4371 * insdel.c: Make symbols static if they're not exported.
4372 However, leave prepare_to_modify_buffer alone. It's never
4373 called from outside this function, but that appears to be a bug.
4374 (combine_after_change_list, combine_after_change_buffer):
4375 (adjust_after_replace, signal_before_change): Now static.
4376 (adjust_after_replace_noundo): Remove; unused.
4377 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4378 (signal_before_change): Remove decls.
4379
4380 * indent.c (val_compute_motion, val_vmotion): Now static.
4381
4382 * image.c: Make symbols static if they're not exported.
4383 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4384 if USE_GTK.
4385 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4386 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4387
4388 * fringe.c (standard_bitmaps): Now static.
4389 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4390
4391 * frame.c: Make symbols static if they're not exported.
4392 (x_report_frame_params, make_terminal_frame): Now static.
4393 (get_frame_param): Now static, unless HAVE_NS.
4394 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4395 (x_get_resource_string): Remove; not used.
4396 * frame.h (make_terminal_frame, x_report_frame_params):
4397 (x_get_resource_string); Remove decls.
4398 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4399 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4400
4401 * font.c, fontset.c: Make symbols static if they're not exported.
4402 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4403 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4404 * font.c (font_close_object): Now static.
4405 * font.h (font_close_object): Remove.
4406 * fontset.c (FONTSET_OBJLIST): Remove.
4407 (free_realized_fontset) #if-0 the body, which does nothing.
4408 (face_suitable_for_char_p): #if-0, as it's never called.
4409 * fontset.h (face_suitable_for_char_p): Remove decl.
4410 * xfaces.c (face_at_string_position):
4411 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4412 since 0 is always ASCII.
4413
4414 * fns.c (weak_hash_tables): Now static.
4415
4416 * fileio.c: Make symbols static if they're not exported.
4417 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4418 (Vwrite_region_annotation_buffers): Now static.
4419
4420 * eval.c: Make symbols static if they're not exported.
4421 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4422 * lisp.h (backtrace_list): Remove decl.
4423
4424 * emacs.c: Make symbols static if they're not exported.
4425 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4426 (fatal_error_code, fatal_error_signal_hook, standard_args):
4427 Now static.
4428 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4429 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4430 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4431 * lisp.h (fatal_error_signal_hook): Remove decl.
4432 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4433
4434 * editfns.c: Move a (normally-unused) function to its only use.
4435 * editfns.c, lisp.h (get_operating_system_release): Remove.
4436 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4437 worth the hassle of breaking this out.
4438
4439 * xterm.c: Make symbols static if they're not exported.
4440 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4441 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4442 (x_destroy_window, x_delete_display):
4443 Now static.
4444 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4445 (x_mouse_leave): Remove; unused.
4446 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4447 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4448 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4449 Remove decls.
4450 (x_mouse_leave): Declare only if WINDOWSNT.
4451 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4452 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4453 USE_X_TOOLKIT.
4454
4455 * ftxfont.c: Make symbols static if they're not exported.
4456 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4457 HAVE_FREETYPE.
4458 * font.h (ftxfont_driver): Likewise.
4459
4460 * xfns.c: Make symbols static if they're not exported.
4461 (x_last_font_name, x_display_info_for_name):
4462 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4463 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4464 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4465 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4466 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4467 (last_show_tip_args): Now static.
4468 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4469 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4470 (x_screen_planes): Remove; unused.
4471 * dispextern.h (x_screen_planes): Remove decl.
4472
4473 * dispnew.c: Make symbols static if they're not exported.
4474 * dispextern.h (redraw_garbaged_frames, scrolling):
4475 (increment_row_positions): Remove.
4476 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4477 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4478 Now static.
4479 (redraw_garbaged_frames): Remove; unused.
4480
4481 * xfaces.c: Make symbols static if they're not exported.
4482 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4483 Remove decls.
4484 * xterm.h (defined_color): Remove decls.
4485 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4486 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4487 (menu_face_changed_default, defined_color, free_realized_face):
4488 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4489 (ascii_face_of_lisp_face): Remove; unused.
4490
4491 * xdisp.c: Make symbols static if they're not exported.
4492 * dispextern.h (scratch_glyph_row, window_box_edges):
4493 (glyph_to_pixel_coords, set_cursor_from_row):
4494 (get_next_display_element, set_iterator_to_next):
4495 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4496 (show_mouse_face): Remove decls
4497 * frame.h (message_buf_print): Likewise.
4498 * lisp.h (pop_message, set_message, check_point_in_composition):
4499 Likewise.
4500 * xterm.h (set_vertical_scroll_bar): Likewise.
4501 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4502 (message_buf_print, scratch_glyph_row, displayed_buffer):
4503 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4504 (get_next_display_element, show_mouse_face, window_box_edges):
4505 (frame_to_window_pixel_xy, check_point_in_composition):
4506 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4507 (glyph_to_pixel_coords): Remove; unused.
4508
4509 * dired.c (file_name_completion): Now static.
4510
4511 * dbusbind.c (xd_in_read_queued_messages): Now static.
4512
4513 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4514 * data.c (circular_list_error): Remove.
4515
4516 * commands.h (last_point_position, last_point_position_buffer):
4517 (last_point_position_window): Remove decls.
4518 * keyboard.c: Make these variables static.
4519
4520 * coding.h (coding, code_convert_region, encode_coding_gap):
4521 Remove decls.
4522 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4523 (iso_code_class, detect_coding, code_convert_region): Now static.
4524 (encode_coding_gap): Remove; unused.
4525
4526 * chartab.c (chartab_chars, chartab_bits): Now static.
4527
4528 * charset.h (charset_iso_8859_1): Remove decl.
4529 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4530 Now static.
4531
4532 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4533 * ccl.c (Vccl_program_table): Now static.
4534 (check_ccl_update): Remove; unused.
4535
4536 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4537 * category.h: ... from here.
4538 * category.c (check_category_table, set_category_set): Now static.
4539
4540 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4541 * lisp.h: Remove these decls.
4542
4543 * buffer.c (buffer_count): Remove unused var.
4544
4545 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4546 so that it's not optimized away.
4547 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4548 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4549 exported only to the debugger.
4550
4551 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4552 * atimer.h (run_all_atimers): Remove; not exported.
4553
4554 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4555 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4556 was inaccessible from Lisp.
4557 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4558 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4559
4560 alloc.c: Import and export fewer symbols, and remove unused items.
4561 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4562 is defined.
4563 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4564 it's not optimized away by whole-program optimization.
4565 (message_enable_multibyte, free_misc): Remove.
4566 (catchlist, handlerlist, mark_backtrace):
4567 Declare only if BYTE_MARK_STACK.
4568 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4569 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4570 (message_enable_multibyte): Remove decl.
4571 (free_misc, interval_free_list, float_block, float_block_index):
4572 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4573 (cons_free_list, last_marked_index):
4574 Now static.
4575 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4576 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4577 (mark_backtrace): Define only if BYTE_MARK_STACK.
4578 * xdisp.c (message_enable_multibyte): Now static.
4579
4580 Declare Lisp_Object Q* variables to be 'static' if not exported.
4581 This makes it easier for human readers (and static analyzers)
4582 to see whether these variables are used from other modules.
4583 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4584 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4585 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4586 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4587 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4588 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4589 * xmenu.c, xselect.c:
4590 Declare Q* vars static if they are not used in other modules.
4591 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4592 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4593 Remove decls of unexported vars.
4594 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4595
4596 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4597
4598 Make Emacs functions such as Fatom 'static' by default.
4599 This makes it easier for human readers (and static analyzers)
4600 to see whether these functions can be called from other modules.
4601 DEFUN now defines a static function. To make the function external
4602 so that it can be used in other C modules, use the new macro DEFUE.
4603 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4604 (Finit_image_library):
4605 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4606 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4607 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4608 Remove decls, since these functions are now static.
4609 (Funintern, Fget_internal_run_time): New decls, since these functions
4610 were already external.
4611
4612 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4613 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4614 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4615 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4616 * keyboard.c, keymap.c, lread.c:
4617 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4618 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4619 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4620 Mark functions with DEFUE instead of DEFUN,
4621 if they are used in other modules.
4622 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4623 decls for now-static functions.
4624 * buffer.h (Fdelete_overlay): Remove decl.
4625 * callproc.c (Fgetenv_internal): Mark as internal.
4626 * composite.c (Fremove_list_of_text_properties): Remove decl.
4627 (Fcomposition_get_gstring): New forward static decl.
4628 * composite.h (Fcomposite_get_gstring): Remove decl.
4629 * dired.c (Ffile_attributes): New forward static decl.
4630 * doc.c (Fdocumntation_property): New forward static decl.
4631 * eval.c (Ffetch_bytecode): New forward static decl.
4632 (Funintern): Remove extern decl; now in .h file where it belongs.
4633 * fileio.c (Fmake_symbolic_link): New forward static decl.
4634 * image.c (Finit_image_library): New forward static decl.
4635 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4636 * intervals.h (Fprevious_property_change):
4637 (Fremove_list_of_text_properties): Remove decls.
4638 * keyboard.c (Fthis_command_keys): Remove decl.
4639 (Fcommand_execute): New forward static decl.
4640 * keymap.c (Flookup_key): New forward static decl.
4641 (Fcopy_keymap): Now static.
4642 * keymap.h (Flookup_key): Remove decl.
4643 * process.c (Fget_process): New forward static decl.
4644 (Fprocess_datagram_address): Mark as internal.
4645 * syntax.c (Fsyntax_table_p): New forward static decl.
4646 (skip_chars): Remove duplicate decl.
4647 * textprop.c (Fprevious_property_change): New forward static decl.
4648 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4649 Now internal.
4650 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4651 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4652
4653 * editfns.c (Fformat): Remove unreachable code.
4654
4655 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4656
4657 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4658 change. (Bug#8496)
4659
4660 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4661
4662 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4663 when at ZV. (Bug#8487)
4664
4665 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4666
4667 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4668 (Bug#8437)
4669 * keyboard.c (parse_tool_bar_item): Likewise.
4670 * sound.c (sound_cleanup, alsa_close): Likewise.
4671 * termcap.c (tgetent): Likewise.
4672 * xfns.c (x_default_font_parameter): Likewise.
4673 * xsettings.c (read_and_apply_settings): Likewise.
4674
4675 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4676 (overrun_check_free): Protoize.
4677
4678 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4679
4680 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4681 since callers should never pass a negative size.
4682 Change the signature to match that of plain 'read' and 'write'; see
4683 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4684 * lisp.h: Update prototypes of emacs_write and emacs_read.
4685
4686 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4687
4688 * xdisp.c (redisplay_window): Don't try to determine the character
4689 position of the scroll margin if the window start point w->startp
4690 is outside the buffer's accessible region. (Bug#8468)
4691
4692 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4693
4694 Fix write-region and its subroutines for buffers > 2GB.
4695 * fileio.c (a_write, e_write): Modify declaration of arguments and
4696 local variables to support buffers larger than 2GB.
4697 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4698
4699 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4700 argument, local variables, and return value.
4701
4702 * lisp.h: Update prototypes of emacs_write and emacs_read.
4703
4704 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4705
4706 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4707
4708 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4709
4710 Fix more problems found by GCC 4.6.0's static checks.
4711
4712 * xdisp.c (vmessage): Use a better test for character truncation.
4713
4714 * charset.c (load_charset_map): <, not <=, for optimization,
4715 and to avoid potential problems with integer overflow.
4716 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4717 * casetab.c (set_identity, shuffle): Likewise.
4718 * editfns.c (Fformat): Likewise.
4719 * syntax.c (skip_chars): Likewise.
4720
4721 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4722 This also lets GCC 4.6.0 generate slightly better loop code.
4723
4724 * callint.c (Fcall_interactively): <, not <=, for optimization.
4725 (Fcall_interactively): Count the number of arguments produced,
4726 not the number of arguments given. This is simpler and lets GCC
4727 4.6.0 generate slightly better code.
4728
4729 * ftfont.c: Distingish more carefully between FcChar8 and char.
4730 The previous code passed unsigned char * to a functions like
4731 strlen and xstrcasecmp that expect char *, which does not
4732 conform to the C standard.
4733 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4734 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4735 char * when the C standard requires it.
4736
4737 * keyboard.c (read_char): Remove unused var.
4738
4739 * eval.c: Port to Windows vsnprintf (Bug#8435).
4740 Include <limits.h>.
4741 (SIZE_MAX): Define if the headers do not.
4742 (verror): Do not give up if vsnprintf returns a negative count.
4743 Instead, grow the buffer. This ports to Windows vsnprintf, which
4744 does not conform to C99. Problem reported by Eli Zaretskii.
4745 Also, simplify the allocation scheme, by avoiding the need for
4746 calling realloc, and removing the ALLOCATED variable.
4747
4748 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4749
4750 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4751 But keep the doprint source code for now, as we might revamp it
4752 and use it again (Bug#8435).
4753 * lisp.h (doprnt): Remove.
4754 * Makefile.in (base_obj): Remove doprnt.o.
4755 * deps.mk (doprnt.o): Remove.
4756
4757 error: Print 32- and 64-bit integers portably (Bug#8435).
4758 Without this change, on typical 64-bit hosts error ("...%d...", N)
4759 was used to print both 32- and 64-bit integers N, which relied on
4760 undefined behavior.
4761 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4762 New macro.
4763 * lisp.h (error, verror): Mark as printf-like functions.
4764 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4765 Report overflow in size calculations when allocating printf buffer.
4766 Do not truncate output string at its first null byte.
4767 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4768 Truncate the output at a character boundary, since vsnprintf does not
4769 do that.
4770 * charset.c (check_iso_charset_parameter): Convert internal
4771 character to string before calling 'error', since %c now has the
4772 printf meaning.
4773 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4774 overflow when computing char to be passed to 'error'. Do not
4775 pass Lisp_Object to 'error'; pass the integer instead.
4776 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4777 formatted with plain %d.
4778
4779 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4780
4781 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4782
4783 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4784
4785 * xterm.c (x_catch_errors): Remove duplicate declaration.
4786
4787 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4788
4789 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4790
4791 2011-04-10 Jim Meyering <meyering@redhat.com>
4792
4793 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4794 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4795 return ssize_t not "int", and use size_t as the buffer length.
4796 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4797 * gnutls.h: Update declarations.
4798 * process.c (read_process_output): Use ssize_t, to match.
4799 (send_process): Likewise.
4800
4801 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4802
4803 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4804
4805 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4806
4807 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4808 Use unsigned char, to match FcChar8 type definition.
4809
4810 * xterm.c (handle_one_xevent):
4811 * xmenu.c (create_and_show_popup_menu):
4812 * xselect.c (x_decline_selection_request)
4813 (x_reply_selection_request): Avoid type-punned deref of X events.
4814
4815 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4816
4817 Fix some uses of `int' instead of EMACS_INT.
4818 * search.c (string_match_1, fast_string_match)
4819 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4820 (scan_buffer, find_next_newline_no_quit)
4821 (find_before_next_newline, search_command, Freplace_match)
4822 (Fmatch_data): Make some `int' variables be EMACS_INT.
4823
4824 * xdisp.c (display_count_lines): 3rd argument and return value now
4825 EMACS_INT. All callers changed.
4826 (pint2hrstr): Last argument is now EMACS_INT.
4827
4828 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4829 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4830 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4831 (decode_coding_utf_16, decode_coding_emacs_mule)
4832 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4833 (decode_coding_ccl, decode_coding_charset)
4834 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4835 (decode_coding_iso_2022, decode_coding_emacs_mule)
4836 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4837 <char_offset, last_offset>: Declare EMACS_INT.
4838 (encode_coding_utf_8, encode_coding_utf_16)
4839 (encode_coding_emacs_mule, encode_invocation_designation)
4840 (encode_designation_at_bol, encode_coding_iso_2022)
4841 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4842 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4843 Declare EMACS_INT.
4844 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4845 (encode_invocation_designation): Last argument P_NCHARS is now
4846 EMACS_INT.
4847 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4848 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4849
4850 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4851 All users changed.
4852
4853 * ccl.c (Fccl_execute_on_string): Declare some variables
4854 EMACS_INT.
4855
4856 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4857
4858 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4859
4860 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4861
4862 * process.c (Fformat_network_address): Doc fix.
4863
4864 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4865
4866 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4867
4868 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4869
4870 * keyboard.c (read_char): Call Lisp function help-form-show,
4871 instead of using internal_with_output_to_temp_buffer.
4872 (Qhelp_form_show): New var.
4873 (syms_of_keyboard): Use DEFSYM macro.
4874
4875 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4876
4877 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4878
4879 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4880
4881 * process.c (Flist_processes): Remove to Lisp.
4882 (list_processes_1): Delete.
4883
4884 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4885
4886 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4887
4888 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4889
4890 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4891
4892 Fix more problems found by GCC 4.6.0's static checks.
4893
4894 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4895
4896 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4897
4898 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4899
4900 * xdisp.c (vmessage): Mark as a printf-like function.
4901
4902 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4903
4904 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4905
4906 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4907 printf-like functions.
4908 (tiff_load): Add casts to remove these marks before passing them
4909 to system-supplied API.
4910
4911 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4912
4913 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4914 This avoids several warnings with gcc -Wstrict-overflow.
4915 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4916 directly, rather than having caller test rule sign. This avoids
4917 some unnecessary tests.
4918 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4919 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4920 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4921
4922 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4923 (xfont_open): Avoid unnecessary tests.
4924
4925 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4926
4927 * composite.h, composite.c (composition_gstring_put_cache):
4928 Use EMACS_INT, not int, for length.
4929
4930 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4931 breaking out part of COMPOSITION_DECODE_RULE.
4932 (COMPOSITION_DECODE_RULE): Use it.
4933 * composite.c (get_composition_id): Remove unused local vars,
4934 by using the new macro.
4935
4936 * textprop.c (set_text_properties_1): Change while to do-while,
4937 since the condition is always true at first.
4938
4939 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4940 (interval_deletion_adjustment): Return unsigned value.
4941 All uses changed.
4942
4943 * process.c (list_processes_1, create_pty, read_process_output):
4944 (exec_sentinel): Remove vars that were set but not used.
4945 (create_pty): Remove unnecessary "volatile"s.
4946 (Fnetwork_interface_info): Avoid possibility of int overflow.
4947 (read_process_output): Do adaptive read buffering even if carryover.
4948 (read_process_output): Simplify nbytes computation if buffered.
4949
4950 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4951
4952 * syntax.c (scan_words): Remove var that was set but not used.
4953 (update_syntax_table): Use unsigned instead of int.
4954
4955 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4956 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4957 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4958
4959 * print.c (print_error_message): Avoid int overflow.
4960
4961 * font.c (font_list_entities): Redo for clarity,
4962 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4963
4964 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4965 (font_score): Avoid potential overflow in diff calculation.
4966
4967 * fns.c (substring_both): Remove var that is set but not used.
4968 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4969
4970 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4971
4972 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4973 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4974 can always succeed if overflow has undefined behavior.
4975
4976 * search.c (boyer_moore, wordify): Remove vars set but not used.
4977 (wordify): Omit three unnecessary tests.
4978
4979 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4980 All callers changed. This avoids the need for an unused var.
4981
4982 * casefiddle.c (casify_region): Remove var that is set but not used.
4983
4984 * dired.c (file_name_completion): Remove var that is set but not used.
4985
4986 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4987
4988 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4989 (Finsert_file_contents): Remove unnecessary code checking fd.
4990
4991 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4992 Check for integer overflow on size calculations.
4993
4994 * buffer.c (Fprevious_overlay_change): Remove var that is set
4995 but not used.
4996
4997 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4998 Remove vars that are set but not used.
4999 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5000 (timer_check_2): Mark vars as initialized.
5001
5002 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5003
5004 * image.c (lookup_image): Remove var that is set but not used.
5005 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5006
5007 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5008 that are set but not used.
5009
5010 * xfns.c (make_invisible_cursor): Don't return garbage
5011 if XCreateBitmapFromData fails (Bug#8410).
5012
5013 * xselect.c (x_get_local_selection, x_handle_property_notify):
5014 Remove vars that are set but not used.
5015
5016 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5017 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5018
5019 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5020 Remove var that is set but not used.
5021 (scroll_bar_windows_size): Now size_t, not int.
5022 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5023 Check for overflow.
5024
5025 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5026 (map_tty_color) [!defined MSDOS]: Likewise.
5027
5028 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5029
5030 * coding.c: Remove vars that are set but not used.
5031 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5032 All callers changed.
5033 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5034 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5035 (decode_coding_charset): Remove vars that are set but not used.
5036
5037 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5038 that is set but not used.
5039
5040 * print.c (print_object): Remove var that is set but not used.
5041
5042 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5043 The gnulib version avoids calling malloc in the usual case,
5044 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5045 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5046 * filelock.c (current_lock_owner): Likewise.
5047 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5048 * sysdep.c: Include allocator.h, careadlinkat.h.
5049 (emacs_no_realloc_allocator): New static constant.
5050 (emacs_readlink): New function.
5051 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5052 ../lib/careadlinkat.h.
5053
5054 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5055
5056 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5057 first non-nil return value).
5058
5059 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5060
5061 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5062 if not defined (Bug#8403).
5063
5064 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5065
5066 * xdisp.c (display_count_lines): Remove parameter `start',
5067 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5068 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5069 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5070 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5071 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5072 and thereabouts. All callers changed.
5073 (get_per_char_metric): Remove parameter `f', unused since
5074 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5075
5076 2011-04-02 Jim Meyering <meyering@redhat.com>
5077
5078 do not dereference NULL upon failed strdup
5079 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5080 (ns_get_family): Likewise.
5081
5082 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5083
5084 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5085
5086 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5087
5088 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5089 later (Bug#8403).
5090
5091 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5092
5093 Add lexical binding.
5094
5095 * window.c (Ftemp_output_buffer_show): New fun.
5096 (Fsave_window_excursion):
5097 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5098
5099 * lread.c (lisp_file_lexically_bound_p): New function.
5100 (Fload): Bind Qlexical_binding.
5101 (readevalloop): Remove `evalfun' arg.
5102 Bind Qinternal_interpreter_environment.
5103 (Feval_buffer): Bind Qlexical_binding.
5104 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5105 Mark as dynamic.
5106 (syms_of_lread): Declare `lexical-binding'.
5107
5108 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5109
5110 * keyboard.c (eval_dyn): New fun.
5111 (menu_item_eval_property): Use it.
5112
5113 * image.c (parse_image_spec): Use Ffunctionp.
5114
5115 * fns.c (concat, mapcar1): Accept byte-code-functions.
5116
5117 * eval.c (Fsetq): Handle lexical vars.
5118 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5119 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5120 (FletX, Flet): Obey lexical binding.
5121 (Fcommandp): Handle closures.
5122 (Feval): New `lexical' arg.
5123 (eval_sub): New function extracted from Feval. Use it almost
5124 everywhere where Feval was used. Look up vars in lexical env.
5125 Handle closures.
5126 (Ffunctionp): Move from subr.el.
5127 (Ffuncall): Handle closures.
5128 (apply_lambda): Remove `eval_flags'.
5129 (funcall_lambda): Handle closures and new byte-code-functions.
5130 (Fspecial_variable_p): New function.
5131 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5132 but without exporting it to Lisp.
5133
5134 * doc.c (Fdocumentation, store_function_docstring):
5135 * data.c (Finteractive_form): Handle closures.
5136
5137 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5138 interactive spec.
5139
5140 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5141 New byte-codes.
5142 (exec_byte_code): New function extracted from Fbyte_code to handle new
5143 calling convention for byte-code-functions. Add new byte-codes.
5144
5145 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5146
5147 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5148
5149 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5150
5151 * xdisp.c (redisplay_internal): Fix prototype.
5152
5153 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5154
5155 * xdisp.c (SCROLL_LIMIT): New macro.
5156 (try_scrolling): Use it when setting scroll_limit.
5157 Limit scrolling to 100 screen lines.
5158 (redisplay_window): Even when falling back on "recentering",
5159 position point in the window according to scroll-conservatively,
5160 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5161
5162 (try_scrolling): When point is above the window, allow searching
5163 as far as scroll_max, or one screenful, to compute vertical
5164 distance from PT to the scroll margin position. This prevents
5165 try_scrolling from unnecessarily failing when
5166 scroll-conservatively is set to a value slightly larger than the
5167 window height. Clean up the case of PT below the margin at bottom
5168 of window: scroll_max can no longer be INT_MAX. When aggressive
5169 scrolling is in use, don't let point enter the opposite scroll
5170 margin as result of the scroll.
5171 (syms_of_xdisp) <scroll-conservatively>: Document the
5172 threshold of 100 lines for never-recentering scrolling.
5173
5174 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5175
5176 * dispextern.h (move_it_by_lines):
5177 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5178 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5179 (message_log_check_duplicate): Remove parameters `prev_bol' and
5180 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5181 (redisplay_internal): Remove parameter `preserve_echo_area',
5182 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5183
5184 * indent.c (Fvertical_motion):
5185 * window.c (window_scroll_pixel_based, Frecenter):
5186 Don't pass `need_y_p' to `move_it_by_lines'.
5187
5188 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5189
5190 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5191 steal a few bits to be more compact.
5192 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5193 Remove unneeded casts.
5194
5195 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5196
5197 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5198
5199 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5200 binding" message (bug#7967).
5201
5202 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5203
5204 Fix more problems found by GCC 4.6.0's static checks.
5205
5206 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5207 Remove unused local var.
5208
5209 * editfns.c (Fmessage_box): Remove unused local var.
5210
5211 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5212 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5213 Omit unused local vars.
5214 * window.c (shrink_windows): Omit unused local var.
5215 * menu.c (digest_single_submenu): Omit unused local var.
5216 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5217 Omit unused local var.
5218
5219 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5220 Don't assume string length fits in int.
5221 (keyremap_step, read_key_sequence): Use size_t for sizes.
5222 (read_key_sequence): Don't check last_real_key_start redundantly.
5223
5224 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5225 instead of alloca (Bug#8344).
5226
5227 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5228 (Fbacktrace_frame): Don't assume nframes fits in int.
5229
5230 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5231
5232 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5233 concerns.
5234
5235 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5236
5237 * cm.c (calccost): Turn while-do into do-while, for clarity.
5238
5239 * keyboard.c (syms_of_keyboard): Use the same style as later
5240 in this function when indexing through an array. This also
5241 works around GCC bug 48267.
5242
5243 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5244
5245 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5246
5247 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5248 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5249
5250 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5251 This avoids undefined behavior on integer overflow, and is a bit
5252 more convenient anyway since it is compared to a size_t variable.
5253
5254 Variadic C functions now count arguments with size_t, not int.
5255 This avoids an unnecessary limitation on 64-bit machines, which
5256 caused (substring ...) to crash on large vectors (Bug#8344).
5257 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5258 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5259 All variadic functions and their callers changed accordingly.
5260 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5261 * data.c (arith_driver, float_arith_driver): Likewise.
5262 * editfns.c (general_insert_function): Likewise.
5263 * eval.c (struct backtrace.nargs, interactive_p)
5264 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5265 (funcall_lambda, mark_backtrace): Likewise.
5266 * fns.c (concat): Likewise.
5267 * frame.c (x_set_frame_parameters): Likewise.
5268 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5269 0 if not found, not -1. All callers changed.
5270
5271 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5272 (stack_copy_size): Now size_t, not int.
5273 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5274
5275 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5276
5277 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5278 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5279 All callers changed.
5280
5281 * lisp.h (multibyte_char_to_unibyte):
5282 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5283 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5284 * character.h (CHAR_TO_BYTE8):
5285 * cmds.c (internal_self_insert):
5286 * editfns.c (general_insert_function):
5287 * keymap.c (push_key_description):
5288 * search.c (Freplace_match):
5289 * xdisp.c (message_dolog, set_message_1): All callers changed.
5290
5291 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5292
5293 * keyboard.c (safe_run_hook_funcall): New function.
5294 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5295 don't set the hook to nil, but remove the offending function instead.
5296 (Qcommand_hook_internal): Remove, unused.
5297 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5298 Vcommand_hook_internal.
5299
5300 * eval.c (enum run_hooks_condition): Remove.
5301 (funcall_nil, funcall_not): New functions.
5302 (run_hook_with_args): Call each function through a `funcall' argument.
5303 Remove `cond' argument, now redundant.
5304 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5305 (Frun_hook_with_args_until_failure): Adjust accordingly.
5306 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5307
5308 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5309
5310 * dispextern.h (string_buffer_position): Remove declaration.
5311
5312 * print.c (strout): Remove parameter `multibyte', unused since
5313 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5314
5315 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5316 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5317 All callers changed.
5318
5319 * w32.c (_wsa_errlist): Use braces for struct initializers.
5320
5321 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5322 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5323 All callers changed.
5324 (string_buffer_position): Likewise. Also, make static (it's never
5325 used outside xdisp.c).
5326 (cursor_row_p): Remove parameter `w', unused since
5327 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5328 (decode_mode_spec): Remove parameter `precision', introduced during
5329 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5330 All callers changed.
5331
5332 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5333
5334 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5335
5336 2011-03-27 Anders Lindgren <andlind@gmail.com>
5337
5338 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5339 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5340 (ns_update_auto_hide_menu_bar): New functions.
5341 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5342 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5343 ns_constrain_all_frames.
5344 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5345 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5346
5347 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5348
5349 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5350
5351 2011-03-27 Glenn Morris <rgm@gnu.org>
5352
5353 * syssignal.h: Replace RETSIGTYPE with void.
5354 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5355 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5356 Replace SIGTYPE with void everywhere.
5357 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5358 * s/template.h (SIGTYPE): Remove commented out definition.
5359
5360 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5361
5362 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5363 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5364
5365 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5366
5367 * w32.c (read_unc_volume): Use parameter `henum', instead of
5368 global variable `wget_enum_handle'.
5369
5370 * keymap.c (describe_vector): Remove parameters `indices' and
5371 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5372 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5373
5374 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5375
5376 * keyboard.c (timer_check): Remove parameter `do_it_now',
5377 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5378 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5379 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5380
5381 * keyboard.c (read_char):
5382 * w32menu.c (w32_menu_display_help):
5383 * xmenu.c (show_help_event, menu_help_callback):
5384 Adjust calls to `show_help_echo'.
5385
5386 * gtkutil.c (xg_maybe_add_timer):
5387 * keyboard.c (readable_events):
5388 * process.c (wait_reading_process_output):
5389 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5390
5391 * insdel.c (adjust_markers_gap_motion):
5392 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5393 (gap_left, gap_right): Don't call it.
5394
5395 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5396
5397 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5398 incurred during fontification.
5399
5400 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5401
5402 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5403 (DEFVAR_PER_BUFFER): Don't pass it.
5404
5405 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5406 (scrolling_window): Don't pass it.
5407
5408 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5409
5410 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5411
5412 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5413 and `suffix'.
5414 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5415 of variables specific to SELinux and computation of `encoded_absname'.
5416
5417 * image.c (XPutPixel): Remove unused variable `height'.
5418
5419 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5420
5421 * unexw32.c (get_section_info): Remove unused variable `section'.
5422
5423 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5424 (system_process_attributes): Remove unused variable `sess'.
5425 (sys_read): Remove unused variable `err'.
5426
5427 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5428 (w32_wnd_proc): Remove unused variable `isdead'.
5429 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5430 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5431 (x_create_tip_frame): Remove unused variable `tem'.
5432
5433 * w32inevt.c (w32_console_read_socket):
5434 Remove unused variable `no_events'.
5435
5436 * w32term.c (x_draw_composite_glyph_string_foreground):
5437 Remove unused variable `width'.
5438
5439 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5440
5441 * w32term.c (x_set_glyph_string_clipping):
5442 Don't pass uninitialized region to CombineRgn.
5443
5444 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5445
5446 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5447 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5448 (Fx_close_connection): Remove unused variable `i'.
5449
5450 * w32font.c (w32font_draw): Return number of glyphs.
5451 (w32font_open_internal): Remove unused variable `i'.
5452 (w32font_driver): Add missing initializer.
5453
5454 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5455 (fill_in_menu): Remove unused variable `items_added'.
5456
5457 * w32term.c (last_mouse_press_frame): Remove static global variable.
5458 (w32_clip_to_row): Remove unused variable `f'.
5459 (x_delete_terminal): Remove unused variable `i'.
5460
5461 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5462 (NOTHING): Remove unused static global variable.
5463 (uniscribe_check_otf): Remove unused variable `table'.
5464 (uniscribe_font_driver): Add missing initializers.
5465
5466 2011-03-23 Julien Danjou <julien@danjou.info>
5467
5468 * term.c (Fsuspend_tty, Fresume_tty):
5469 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5470 * window.c (temp_output_buffer_show):
5471 * insdel.c (signal_before_change):
5472 * frame.c (Fhandle_switch_frame):
5473 * fileio.c (Fdo_auto_save):
5474 * emacs.c (Fkill_emacs):
5475 * editfns.c (save_excursion_restore):
5476 * cmds.c (internal_self_insert):
5477 * callint.c (Fcall_interactively):
5478 * buffer.c (Fkill_all_local_variables):
5479 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5480 Use Frun_hooks.
5481 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5482 unconditionnaly since it does the check itself.
5483
5484 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5485
5486 Fix more problems found by GCC 4.5.2's static checks.
5487
5488 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5489 the first time through the loop, since we know p0 < p1 then.
5490 This also avoids a gcc -Wstrict-overflow warning.
5491
5492 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5493 leading to a memory leak, possible in functions like
5494 load_charset_map_from_file that can allocate an unbounded number
5495 of objects (Bug#8318).
5496
5497 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5498 that could (at least in theory) be that large.
5499
5500 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5501 This is less likely to overflow, and avoids undefined behavior if
5502 overflow does occur. All callers changed. Use strtoul to scan
5503 for the unsigned long integer.
5504 (pint2hrstr): Simplify and tune code slightly.
5505 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5506
5507 * scroll.c (do_scrolling): Work around GCC bug 48228.
5508 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5509
5510 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5511 This also avoids a warning with gcc -Wstrict-overflow.
5512 (validate_x_resource_name): Simplify count usage.
5513 This also avoids a warning with gcc -Wstrict-overflow.
5514
5515 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5516 fail (Bug#8306).
5517
5518 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5519
5520 * process.c (Fmake_network_process): Use socklen_t, not int,
5521 where POSIX says socklen_t is required in portable programs.
5522 This fixes a porting bug on hosts like 64-bit HP-UX, where
5523 socklen_t is wider than int (Bug#8277).
5524 (Fmake_network_process, server_accept_connection):
5525 (wait_reading_process_output, read_process_output):
5526 Likewise.
5527
5528 * process.c: Rename or move locals to avoid shadowing.
5529 (list_processes_1, Fmake_network_process):
5530 (read_process_output_error_handler, exec_sentinel_error_handler):
5531 Rename or move locals.
5532 (Fmake_network_process): Define label "retry_connect" only if needed.
5533 (Fnetwork_interface_info): Fix pointer signedness.
5534 (process_send_signal): Add cast to avoid pointer signedness problem.
5535 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5536 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5537
5538 Make tparam.h and terminfo.c consistent.
5539 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5540 Include tparam.h instead, since it declares them.
5541 * cm.h (PC): Remove extern decl; tparam.h now does this.
5542 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5543 * terminfo.c: Include tparam.h, to check interfaces.
5544 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5545 (tparam): Adjust signature to match interface in tparam.h;
5546 this removes some undefined behavior. Check that outstring and len
5547 are zero, which they always are with Emacs.
5548 * tparam.h (PC, BC, UP): New extern decls.
5549
5550 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5551 (xftfont_open): Rename locals to avoid shadowing.
5552
5553 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5554 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5555 (OTF_TAG_SYM): Omit macro if not needed.
5556 (ftfont_list): Remove unused local.
5557 (get_adstyle_property, ftfont_pattern_entity):
5558 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5559 Rename locals to avoid shadowing.
5560
5561 * xfont.c (xfont_list_family): Mark var as initialized.
5562
5563 * xml.c (make_dom): Now static.
5564
5565 * composite.c (composition_compute_stop_pos): Rename local to
5566 avoid shadowing.
5567 (composition_reseat_it): Remove unused locals.
5568 (find_automatic_composition, composition_adjust_point): Likewise.
5569 (composition_update_it): Mark var as initialized.
5570 (find_automatic_composition): Mark vars as initialized,
5571 with a FIXME (Bug#8290).
5572
5573 character.h: Rename locals to avoid shadowing.
5574 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5575 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5576 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5577 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5578 to avoid shadowing.
5579
5580 * textprop.c (property_change_between_p): Remove; unused.
5581
5582 * intervals.c (interval_start_pos): Now static.
5583
5584 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5585
5586 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5587 Rename locals to avoid shadowing.
5588
5589 * sound.c (wav_play, au_play, Fplay_sound_internal):
5590 Fix pointer signedness.
5591 (alsa_choose_format): Remove unused local var.
5592 (wav_play): Initialize a variable to 0, to prevent undefined
5593 behavior (Bug#8278).
5594
5595 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5596
5597 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5598
5599 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5600 clobbering (Bug#8298).
5601 * sysdep.c (sys_subshell): Likewise.
5602 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5603
5604 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5605 This should get cleaned up, so that child_setup has the
5606 same signature on all platforms.
5607
5608 * callproc.c (call_process_cleanup): Now static.
5609 (relocate_fd): Rename locals to avoid shadowing.
5610
5611 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5612
5613 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5614 not to be necessary, and produces flickering.
5615
5616 2011-03-20 Glenn Morris <rgm@gnu.org>
5617
5618 * config.in: Remove file.
5619
5620 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5621
5622 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5623 are now in src/globals.h.
5624 (syms_of_minibuf): Remove spurious & from previous change.
5625
5626 2011-03-20 Leo <sdl.web@gmail.com>
5627
5628 * minibuf.c (completing-read-function): New variable.
5629 (completing-read-default): Rename from completing-read.
5630 (completing-read): Call completing-read-function.
5631
5632 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5633
5634 * xfaces.c (Fx_load_color_file):
5635 Read color file from absolute filename (bug#8250).
5636
5637 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5638
5639 * makefile.w32-in: Update dependencies.
5640
5641 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5642
5643 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5644
5645 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5646
5647 Fix more problems found by GCC 4.5.2's static checks.
5648
5649 * process.c (make_serial_process_unwind, send_process_trap):
5650 (sigchld_handler): Now static.
5651
5652 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5653 That way, the code declares only the vars that it needs.
5654 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5655 * s/cygwin.h (PTY_ITERATION): Likewise.
5656 * s/darwin.h (PTY_ITERATION): Likewise.
5657 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5658
5659 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5660 * process.c (allocate_pty): Don't declare stb unless it's needed.
5661
5662 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5663 (CONSTANTLIM): Remove; unused.
5664 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5665 Define only if needed.
5666
5667 * unexelf.c (unexec): Name an expression,
5668 to avoid gcc -Wbad-function-cast warning.
5669 Use a different way to cause a compilation error if anyone uses
5670 n rather than nn, a way that does not involve shadowing.
5671 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5672
5673 * deps.mk (unexalpha.o): Remove; unused.
5674
5675 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5676 * unexec.h: New file.
5677 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5678 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5679 Depend on unexec.h.
5680 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5681 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5682 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5683 Change as necessary to match prototype in unexec.h.
5684
5685 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5686 shadowing.
5687 (back_comment, skip_chars): Mark vars as initialized.
5688
5689 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5690 Rename locals to avoid shadowing.
5691
5692 * lread.c (read1): Rewrite so as not to use empty "else".
5693 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5694
5695 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5696
5697 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5698 warning when compiling print.c.
5699
5700 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5701 instead of using an uninitialized var.
5702 (font_sort_entities): Mark var as initialized.
5703
5704 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5705
5706 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5707 pointers to constants.
5708 (font_parse_fcname): Remove unused vars.
5709 (font_delete_unmatched): Now static.
5710 (font_get_spec): Remove; unused.
5711 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5712 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5713 Rename or move locals to avoid shadowing.
5714
5715 * fns.c (require_nesting_list, require_unwind): Now static.
5716 (Ffillarray): Rename locals to avoid shadowing.
5717
5718 * floatfns.c (domain_error2): Define only if needed.
5719 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5720
5721 * alloc.c (mark_backtrace): Move decl from here ...
5722 * lisp.h: ... to here, so that it can be checked.
5723
5724 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5725 (Fdefvar): Rewrite so as not to use empty "else".
5726 (lisp_indirect_variable): Name an expression,
5727 to avoid gcc -Wbad-function-cast warning.
5728 (Fdefvar): Rename locals to avoid shadowing.
5729
5730 * callint.c (quotify_arg, quotify_args): Now static.
5731 (Fcall_interactively): Rename locals to avoid shadowing.
5732 Use const pointer when appropriate.
5733
5734 * lisp.h (get_system_name, get_operating_system_release):
5735 Move decls here, to check interfaces.
5736 * process.c (get_operating_system_release): Move decl to lisp.h.
5737 * xrdb.c (get_system_name): Likewise.
5738 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5739 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5740 some of which prompt warnings from gcc -Wbad-function-cast.
5741 (Fformat_time_string, Fencode_time, Finsert_char):
5742 (Ftranslate_region_internal, Fformat):
5743 Rename or remove local vars to avoid shadowing.
5744 (Ftranslate_region_internal): Mark var as initialized.
5745
5746 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5747 avoid shadowing.
5748
5749 * lisp.h (eassert): Check that the argument compiles, even if
5750 ENABLE_CHECKING is not defined.
5751
5752 * data.c (Findirect_variable): Name an expression, to avoid
5753 gcc -Wbad-function-cast warning.
5754 (default_value, arithcompare, arith_driver, arith_error): Now static.
5755 (store_symval_forwarding): Rename local to avoid shadowing.
5756 (Fmake_variable_buffer_local, Fmake_local_variable):
5757 Mark variables as initialized.
5758 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5759
5760 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5761 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5762 Rename locals to avoid shadowing.
5763 (mark_stack): Move local variables into the #ifdef region where
5764 they're used.
5765 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5766 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5767 needed otherwise.
5768 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5769 (GC_STRING_CHARS): Remove; not used.
5770 (Fmemory_limit): Cast sbrk's returned value to char *.
5771
5772 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5773 avoids undefined behavior in theory.
5774
5775 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5776
5777 Use functions, not macros, for up- and down-casing (Bug#8254).
5778 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5779 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5780 to use the following functions instead of these macros.
5781 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5782 EMACS_INT, since callers assume the returned value fits in int.
5783 (upcase1): Likewise, for UPCASE_TABLE.
5784 (uppercasep, lowercasep, upcase): New static inline functions.
5785 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5786 the race-condition problem in the old DOWNCASE.
5787
5788 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5789 Rename locals to avoid shadowing.
5790 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5791 (regex_compile, re_search_2, re_match_2_internal):
5792 Remove unused local vars.
5793 (FREE_VAR): Rewrite so as not to use empty "else",
5794 which gcc can warn about.
5795 (regex_compile, re_match_2_internal): Mark locals as initialized.
5796 (RETALLOC_IF): Define only if needed.
5797 (WORDCHAR_P): Likewise. This one is never needed, but is used
5798 only in a comment talking about a compiler bug, so put inside
5799 the #if 0 of that comment.
5800 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5801 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5802 Remove; unused.
5803
5804 * search.c (boyer_moore): Rename locals to avoid shadowing.
5805 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5806 (PREV_CHAR_BOUNDARY): Likewise.
5807
5808 * search.c (simple_search): Remove unused var.
5809
5810 * dired.c (compile_pattern): Move decl from here ...
5811 * lisp.h: ... to here, so that it can be checked.
5812 (struct re_registers): New forward decl.
5813
5814 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5815
5816 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5817 All uses changed.
5818 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5819 Rename locals to avoid shadowing.
5820 (Fvertical_motion): Mark locals as initialized.
5821
5822 * casefiddle.c (casify_object, casify_region): Now static.
5823 (casify_region): Mark local as initialized.
5824
5825 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5826
5827 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5828 New macros, so that the caller can use some names other than
5829 gcpro1, gcpro2, etc.
5830 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5831 of the new macros.
5832 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5833 argument, for consistency with GCPRO2_VAR, etc: it is now the
5834 prefix of the variable, not the variable itself. All uses
5835 changed.
5836 * dired.c (directory_files_internal, file_name_completion):
5837 Rename locals to avoid shadowing.
5838
5839 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5840 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5841 dired.c's scmp function, had undefined behavior.
5842 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5843 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5844 * buffer.h: ... to here, because these macros use current_buffer,
5845 and the new implementation with inline functions needs to have
5846 current_buffer in scope now, rather than later when the macros
5847 are used.
5848 (downcase, upcase1): New static inline functions.
5849 (DOWNCASE, UPCASE1): Reimplement using these functions.
5850 This avoids undefined behavior in expressions like
5851 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5852 from race conditions in accessing the global variables
5853 case_temp1 and case_temp2.
5854 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5855 * lisp.h (case_temp1, case_temp2): Remove their decls.
5856 * character.h (ASCII_CHAR_P): Move from here ...
5857 * lisp.h: ... to here, so that the inline functions mentioned
5858 above can use them.
5859
5860 * dired.c (directory_files_internal_unwind): Now static.
5861
5862 * fileio.c (file_name_as_directory, directory_file_name):
5863 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5864 Now static.
5865 (file_name_as_directory): Use const pointers when appropriate.
5866 (Fexpand_file_name): Likewise. In particular, newdir might
5867 point at constant storage, so make it a const pointer.
5868 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5869 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5870 signedness issues.
5871 (Fset_file_times, Finsert_file_contents, auto_save_error):
5872 Rename locals to avoid shadowing.
5873
5874 * minibuf.c (choose_minibuf_frame_1): Now static.
5875 (Ftry_completion, Fall_completions): Rename or remove locals
5876 to avoid shadowing.
5877
5878 * marker.c (bytepos_to_charpos): Remove; unused.
5879
5880 * lisp.h (verify_bytepos, count_markers): New decls,
5881 so that gcc does not warn that these functions aren't declared.
5882
5883 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5884 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5885 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5886 (copy_text): Remove unused local var.
5887
5888 * filelock.c (within_one_second): Now static.
5889 (lock_file_1): Rename local to avoid shadowing.
5890
5891 * buffer.c (fix_overlays_before): Mark locals as initialized.
5892 (fix_start_end_in_overlays): Likewise. This function should be
5893 simplified by using pointers-to-pointers, but that's a different
5894 matter.
5895 (switch_to_buffer_1): Now static.
5896 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5897 (report_overlay_modification): Rename locals to avoid shadowing.
5898
5899 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5900 Fix pointer signedness issue.
5901 (sys_subshell): Mark local as volatile if checking for lint,
5902 to suppress a gcc -Wclobbered warning that does not seem to be right.
5903 (MAXPATHLEN): Define only if needed.
5904
5905 * process.c (serial_open, serial_configure): Move decls from here ...
5906 * systty.h: ... to here, so that they can be checked.
5907
5908 * fns.c (get_random, seed_random): Move extern decls from here ...
5909 * lisp.h: ... to here, so that they can be checked.
5910
5911 * sysdep.c (reset_io): Now static.
5912 (wait_for_termination_signal): Remove; unused.
5913
5914 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5915 (copy_keymap_item, append_key, push_text_char_description):
5916 Now static.
5917 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5918 (DENSE_TABLE_SIZE): Remove; unused.
5919 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5920 (describe_map_tree):
5921 Rename locals to avoid shadowing.
5922
5923 * keyboard.c: Declare functions static if they are not used elsewhere.
5924 (echo_char, echo_dash, cmd_error, top_level_2):
5925 (poll_for_input, handle_async_input): Now static.
5926 (read_char, kbd_buffer_get_event, make_lispy_position):
5927 (make_lispy_event, make_lispy_movement, apply_modifiers):
5928 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5929 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5930 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5931 (read_key_sequence, read_char): Mark locals as initialized.
5932 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5933
5934 * keyboard.h (make_ctrl_char): New decl.
5935 (mark_kboards): Move decl here ...
5936 * alloc.c (mark_kboards): ... from here.
5937
5938 * lisp.h (force_auto_save_soon): New decl.
5939
5940 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5941 (DEFINE_DUMMY_FUNCTION): New macro.
5942 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5943 Use it.
5944 (main): Add casts to avoid warnings
5945 if GCC considers string literals to be constants.
5946
5947 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5948
5949 * dbusbind.c: Pointer signedness fixes.
5950 (xd_signature, xd_append_arg, xd_initialize):
5951 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5952 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5953 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5954 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5955
5956 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5957 if GCC considers string literals to be constants.
5958 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5959
5960 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5961
5962 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5963 (print_preprocess, print_object): New macro to fix last change.
5964
5965 * print.c (print_preprocess): Don't forget font objects.
5966
5967 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5968
5969 * emacs.c (USAGE3): Doc fixes.
5970
5971 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5972
5973 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5974 structure.
5975
5976 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5977
5978 * lisp.h (VWindow_system, Qfile_name_history):
5979 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5980 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5981 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5982
5983 * w32select.c: Don't #include "keyboard.h".
5984 (run_protected): Add extern declaration for waiting_for_input.
5985
5986 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5987 * w32console.c (detect_input_pending, read_input_pending)
5988 (encode_terminal_code):
5989 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5990 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5991 (w32_system_caret_y, Qfile_name_history):
5992 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5993 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5994 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5995 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5996 * w32proc.c (Qlocal, report_file_error):
5997 * w32term.c (Vwindow_system, updating_frame):
5998 * w32uniscribe.c (initialized, uniscribe_font_driver):
5999 Remove unneeded extern declarations.
6000
6001 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6002
6003 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6004
6005 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6006
6007 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6008 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6009 These macros can no longer be used for assignment.
6010
6011 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6012 Assign struct members directly, instead of using BUF_BEGV etc.
6013 (record_buffer_markers, fetch_buffer_markers): New functions for
6014 recording and fetching special buffer markers.
6015 (set_buffer_internal_1, set_buffer_temp): Use them.
6016
6017 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6018
6019 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6020
6021 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6022 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6023
6024 * xdisp.c (hscroll_window_tree):
6025 (reconsider_clip_changes): Use PT instead of BUF_PT.
6026
6027 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6028
6029 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6030 $(EMACS_ROOT)/lib/intprops.h.
6031
6032 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6033
6034 Fix more problems found by GCC 4.5.2's static checks.
6035
6036 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6037 to unsigned char * to avoid compiler diagnostic.
6038 (xg_free_frame_widgets): Make it clear that a local variable is
6039 needed only if USE_GTK_TOOLTIP.
6040 (gdk_window_get_screen): Make it clear that this macro is needed
6041 only if USE_GTK_TOOLTIP.
6042 (int_gtk_range_get_value): New function, which avoids a diagnostic
6043 from gcc -Wbad-function-cast.
6044 (xg_set_toolkit_scroll_bar_thumb): Use it.
6045 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6046 diagnostic from gcc -Wbad-function-cast.
6047 (get_utf8_string, xg_get_file_with_chooser):
6048 Rename locals to avoid shadowing.
6049 (create_dialog): Move locals to avoid shadowing.
6050
6051 * xgselect.c (xg_select): Remove unused var.
6052
6053 * image.c (four_corners_best): Mark locals as initialized.
6054 (gif_load): Initialize transparent_p to zero (Bug#8238).
6055 Mark another local as initialized.
6056 (my_png_error, my_error_exit): Mark with NO_RETURN.
6057
6058 * image.c (clear_image_cache): Now static.
6059 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6060 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6061 (x_edge_detection): Remove unnecessary cast that
6062 gcc -Wbad-function-cast diagnoses.
6063 (gif_load): Fix pointer signedness.
6064 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6065 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6066
6067 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6068
6069 Improve quality of tests for time stamp overflow.
6070 For example, without this patch (encode-time 0 0 0 1 1
6071 1152921504606846976) returns the obviously-bogus value (-948597
6072 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6073 reports time overflow. See
6074 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6075 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6076 * editfns.c: Include limits.h and intprops.h.
6077 (TIME_T_MIN, TIME_T_MAX): New macros.
6078 (time_overflow): Move earlier, to before first use.
6079 (hi_time, lo_time): New functions, for an accurate test for
6080 out-of-range times.
6081 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6082 (Fget_internal_run_time): Don't assume time_t fits in int.
6083 (make_time): Use list2 instead of Fcons twice.
6084 (Fdecode_time): More accurate test for out-of-range times.
6085 (check_tm_member): New function.
6086 (Fencode_time): Use it, to test for out-of-range times.
6087 (lisp_time_argument): Don't rely on undefined left-shift and
6088 right-shift behavior when checking for time stamp overflow.
6089
6090 * editfns.c (time_overflow): New function, refactoring common code.
6091 (Fformat_time_string, Fdecode_time, Fencode_time):
6092 (Fcurrent_time_string): Use it.
6093
6094 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6095 * dired.c (make_time): Move to ...
6096 * editfns.c (make_time): ... here.
6097 * systime.h: Note the move.
6098
6099 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6100
6101 * fringe.c (update_window_fringes): Remove unused variables.
6102
6103 * unexmacosx.c (copy_data_segment): Also copy __got section.
6104 (Bug#8223)
6105
6106 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6107
6108 * termcap.c [MSDOS]: Include "msdos.h".
6109 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6110 Constify `char *' arguments and their references according to
6111 prototypes in tparam.h.
6112
6113 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6114
6115 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6116 Adapt all references accordingly.
6117
6118 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6119
6120 2011-03-11 Tom Tromey <tromey@redhat.com>
6121
6122 * buffer.c (syms_of_buffer): Remove obsolete comment.
6123
6124 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6125
6126 * termhooks.h (encode_terminal_code): Declare prototype.
6127
6128 * msdos.c (encode_terminal_code): Don't declare prototype.
6129
6130 * term.c (encode_terminal_code): Now external again, used by
6131 w32console.c and msdos.c.
6132
6133 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6134 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6135
6136 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6137
6138 Fix some minor problems found by GCC 4.5.2's static checks.
6139
6140 * fringe.c (update_window_fringes): Mark locals as initialized
6141 (Bug#8227).
6142 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6143
6144 * alloc.c (mark_fringe_data): Move decl from here ...
6145 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6146 to check its interface.
6147 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6148
6149 * fontset.c (free_realized_fontset): Now static.
6150 (Fset_fontset_font): Rename local to avoid shadowing.
6151 (fontset_font): Mark local as initialized.
6152 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6153
6154 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6155
6156 * xselect.c (x_disown_buffer_selections): Remove; not used.
6157 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6158 (x_own_selection, Fx_disown_selection_internal): Rename locals
6159 to avoid shadowing.
6160 (x_handle_dnd_message): Remove local to avoid shadowing.
6161
6162 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6163 so that the caller can use some name other than gcpro1.
6164 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6165 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6166 (Fx_backspace_delete_keys_p):
6167 Use them to avoid shadowing, and rename vars to avoid shadowing.
6168 (x_decode_color, x_set_name, x_window): Now static.
6169 (Fx_create_frame): Add braces to silence GCC warning.
6170 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6171 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6172 Remove unused locals.
6173 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6174 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6175 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6176 macros.
6177
6178 * xterm.h (x_mouse_leave): New decl.
6179
6180 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6181 Remove unused functions.
6182 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6183 (x_calc_absolute_position): Now static.
6184 (XTread_socket): Don't define label "out" unless it's used.
6185 Don't declare local "event" unless it's used.
6186 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6187 unless they are used.
6188 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6189 (x_fatal_error_signal): Remove; not used.
6190 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6191 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6192 (x_error_catcher, x_connection_closed, x_error_handler):
6193 (x_error_quitter, xembed_send_message, x_iconify_frame):
6194 (my_log_handler): Rename locals to avoid shadowing.
6195 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6196 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6197
6198 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6199 Rename or move locals to avoid shadowing.
6200 (tty_defined_color, merge_face_heights): Now static.
6201 (free_realized_faces_for_fontset): Remove; not used.
6202 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6203 does not deduce is never used uninitialized.
6204 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6205 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6206
6207 * terminal.c (store_terminal_param): Now static.
6208
6209 * xmenu.c (menu_highlight_callback): Now static.
6210 (set_frame_menubar): Remove unused local.
6211 (xmenu_show): Rename parameter to avoid shadowing.
6212 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6213 since they might point to immutable storage.
6214 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6215 since it's unused otherwise.
6216
6217 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6218 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6219 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6220 avoids a gcc -Wuninitialized diagnostic.
6221 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6222 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6223 does not deduce are never used uninitialized.
6224
6225 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6226
6227 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6228 * window.c (window_loop, size_window):
6229 (run_window_configuration_change_hook, enlarge_window): Likewise.
6230
6231 * window.c (display_buffer): Now static.
6232 (size_window): Mark variables that gcc -Wuninitialized
6233 does not deduce are never used uninitialized.
6234 * window.h (check_all_windows): New decl, to forestall
6235 gcc -Wmissing-prototypes diagnostic.
6236 * dispextern.h (bidi_dump_cached_states): Likewise.
6237
6238 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6239 shadowing.
6240 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6241 Include <limits.h>.
6242 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6243 and to avoid gcc -Wuninitialized warning.
6244 (load_charset_map): Mark variables that gcc -Wuninitialized
6245 does not deduce are never used uninitialized.
6246 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6247
6248 * coding.c (coding_set_source, coding_set_destination):
6249 Use "else { /* comment */ }" rather than "else /* comment */;"
6250 for clarity, and to avoid gcc -Wempty-body warning.
6251 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6252 a block, when the outer 'i' will do.
6253 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6254 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6255 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6256 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6257 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6258 Rename locals to avoid shadowing.
6259 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6260 * coding.c (emacs_mule_char, encode_invocation_designation):
6261 Now static, since they're not used elsewhere.
6262 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6263 (decode_coding_object, encode_coding_object, detect_coding_system):
6264 (decode_coding_emacs_mule): Mark variables that gcc
6265 -Wuninitialized does not deduce are never used uninitialized.
6266 (detect_coding_iso_2022): Initialize a local variable that might
6267 be used uninitialized. Leave a FIXME because it's not clear that
6268 this initialization is needed. (Bug#8211)
6269 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6270 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6271 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6272 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6273 Remove unused macros.
6274
6275 * category.c (hash_get_category_set): Remove unused local var.
6276 (copy_category_table): Now static, since it's not used elsewhere.
6277 * character.c (string_count_byte8): Likewise.
6278
6279 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6280 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6281
6282 * chartab.c (copy_sub_char_table): Now static, since it's not used
6283 elsewhere.
6284 (sub_char_table_ref_and_range, char_table_ref_and_range):
6285 Rename locals to avoid shadowing.
6286 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6287
6288 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6289 (BIDI_BOB): Remove unused macro.
6290
6291 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6292 deduce are never used uninitialized.
6293 * term.c (encode_terminal_code): Likewise.
6294
6295 * term.c (encode_terminal_code): Now static. Remove unused local.
6296
6297 * tparam.h: New file.
6298 * term.c, tparam.h: Include it.
6299 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6300 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6301 Move these decls to tparam.h, and make them agree with what
6302 is actually in tparam.c. The previous trick of using incompatible
6303 decls in different modules does not conform to the C standard.
6304 All callers of tparam changed to use tparam's actual API.
6305 * tparam.c (tparam1, tparam, tgoto):
6306 Use const pointers where appropriate.
6307
6308 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6309 * cm.h (struct cm): Likewise.
6310 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6311 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6312 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6313 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6314 (turn_on_face, init_tty): Likewise.
6315 * termchar.h (struct tty_display_info): Likewise.
6316
6317 * term.c (term_mouse_position): Rename local to avoid shadowing.
6318
6319 * alloc.c (mark_ttys): Move decl from here ...
6320 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6321
6322 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6323
6324 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6325
6326 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6327
6328 * search.c (compile_pattern_1): Remove argument regp, unused since
6329 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6330 (compile_pattern): Don't pass it.
6331
6332 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6333
6334 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6335 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6336 for ! HAVE_GTK3.
6337 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6338
6339 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6340
6341 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6342 gdk_window_get_screen, gdk_window_get_geometry,
6343 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6344 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6345 (xg_get_pixbuf_from_pixmap): New function.
6346 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6347 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6348 Call xg_get_pixbuf_from_pixmap instead of
6349 gdk_pixbuf_get_from_drawable.
6350 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6351 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6352 (xg_check_special_colors): Use GtkStyleContext and its functions
6353 for HAVE_GTK3.
6354 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6355 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6356 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6357 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6358 Call gtk_widget_get_preferred_size.
6359 (xg_frame_resized): gdk_window_get_geometry only takes 5
6360 parameters.
6361 (xg_win_to_widget, xg_event_is_for_menubar):
6362 Call gdk_x11_window_lookup_for_display.
6363 (xg_set_widget_bg): New function.
6364 (delete_cb): New function.
6365 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6366 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6367 (xg_set_background_color): Call xg_set_widget_bg.
6368 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6369 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6370 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6371 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6372 if ! HAVE_GTK3.
6373 (update_frame_tool_bar): Call gtk_widget_hide.
6374 (xg_initialize): Use GDK_KEY_g.
6375
6376 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6377 if ! HAVE_GTK3
6378 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6379
6380 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6381 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6382 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6383
6384 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6385
6386 * w32xfns.c (select_palette): Check success of RealizePalette against
6387 GDI_ERROR, not zero.
6388
6389 See ChangeLog.11 for earlier changes.
6390
6391 ;; Local Variables:
6392 ;; coding: utf-8
6393 ;; End:
6394
6395 Copyright (C) 2011 Free Software Foundation, Inc.
6396
6397 This file is part of GNU Emacs.
6398
6399 GNU Emacs is free software: you can redistribute it and/or modify
6400 it under the terms of the GNU General Public License as published by
6401 the Free Software Foundation, either version 3 of the License, or
6402 (at your option) any later version.
6403
6404 GNU Emacs is distributed in the hope that it will be useful,
6405 but WITHOUT ANY WARRANTY; without even the implied warranty of
6406 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6407 GNU General Public License for more details.
6408
6409 You should have received a copy of the GNU General Public License
6410 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.