1 2012-08-02 Paul Eggert <eggert@cs.ucla.edu>
3 * xfaces.c (face_at_buffer_position): Remove unused local.
5 Use C99-style 'extern inline' if available.
6 * buffer.h (BUFFER_INLINE):
7 * category.h (CATEGORY_INLINE):
8 * character.h (CHARACTER_INLINE):
9 * charset.h (CHARSET_INLINE):
10 * composite.h (COMPOSITE_INLINE):
11 * dispextern.h (DISPEXTERN_INLINE):
12 * lisp.h (LISP_INLINE):
13 * systime.h (SYSTIME_INLINE):
14 New macro, replacing 'static inline' in this header.
15 * buffer.h, category.h, character.h, charset.h, composite.h:
16 * dispextern.h, lisp.h, systime.h:
17 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
18 * alloc.c (LISP_INLINE):
19 * buffer.c (BUFFER_INLINE):
20 * category.c (CATEGORY_INLINE):
21 * character.c (CHARACTER_INLINE):
22 * charset.c (CHARSET_INLINE):
23 * composite.c (COMPOSITE_INLINE):
24 * dispnew.c (DISPEXTERN_INLINE):
25 * sysdep.c (SYSTIME_INLINE):
26 Define to EXTERN_INLINE, so that the corresponding functions
27 are compiled into code.
28 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
29 (INLINE_HEADER_END): New macros.
30 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
31 since it's used in non-static inline functions now.
33 2012-08-02 Glenn Morris <rgm@gnu.org>
35 * s/: Remove empty directory.
37 * s/ms-w32.h: Move to ../nt/inc.
38 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
39 Update for new ms-w32.h location.
41 2012-08-02 Paul Eggert <eggert@cs.ucla.edu>
44 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
46 2012-08-02 Glenn Morris <rgm@gnu.org>
48 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
49 hard-coding the path separator.
51 2012-08-01 Paul Eggert <eggert@cs.ucla.edu>
53 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
54 This how ASET and AREF are supposed to work, and makes
55 it easier to think about future improvements. See
56 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
57 * charset.h (set_charset_attr): New function.
58 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
59 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
60 (aref_addr): New function. All uses of &AREF(...) changed.
61 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
62 (set_hash_index): New functions. All lvalue-style uses of
63 HASH_KEY etc. changed.
64 * keyboard.c (set_prop): New function. All lvalue-style uses
67 2012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
69 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
70 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
71 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
72 * nsfns.m (ns_set_name_as_filename): Likewise.
73 * nsmenu.m (ns_update_menubar): Likewise.
74 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
76 2012-08-01 Eli Zaretskii <eliz@gnu.org>
78 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
79 Adapt to latest changes in field names of the corresponding Lisp
82 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
84 2012-08-01 Glenn Morris <rgm@gnu.org>
86 * s/msdos.h: Remove file.
87 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
88 * Makefile.in (S_FILE): Remove.
89 (config_h): Remove S_FILE.
91 2012-08-01 Juanma Barranquero <lekktu@gmail.com>
93 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
94 Remove; moved to nt/config.nt.
96 2012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
98 Use INTERNAL_FIELD for conses and overlays.
99 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
100 Remove obsolete comment.
102 (struct Lisp_Overlay): Use INTERNAL_FIELD.
103 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
105 2012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
107 Use INTERNAL_FIELD for symbols.
108 * lisp.h (SVAR): New macro. Adjust users.
109 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
110 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
112 2012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
114 Use INTERNAL_FIELD for processes.
115 * process.h (PVAR): New macro. Adjust style.
116 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
117 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
119 2012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
121 Use INTERNAL_FIELD for windows.
122 * window.h (WVAR): New macro.
123 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
124 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
125 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
126 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
127 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
128 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
130 2012-08-01 Paul Eggert <eggert@cs.ucla.edu>
132 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
134 2012-08-01 Glenn Morris <rgm@gnu.org>
136 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
137 Move to configure.ac.
139 2012-08-01 Juanma Barranquero <lekktu@gmail.com>
141 * makefile.w32-in (CONFIG_H): Update dependencies.
142 (CONF_POST_H): New macro.
144 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
146 2012-07-31 Glenn Morris <rgm@gnu.org>
148 * Makefile.in (S_FILE): No longer set by configure.
150 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
152 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
154 * process.h (NULL_DEVICE):
156 * editfns.c (USER_FULL_NAME): Let configure set them.
158 * s/README, s/template.h: Remove files.
160 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
162 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
163 Move to configure.ac.
165 2012-07-31 Eli Zaretskii <eliz@gnu.org>
167 * .gdbinit (xframe): Adapt to introduction of FVAR and the
168 resulting renaming of 'struct frame' members.
170 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
172 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
173 after introduction of FVAR.
175 2012-07-31 Jan Djärv <jan.h.d@swipnet.se>
177 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
179 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
180 instead of compositeToPoint.
181 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
183 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
185 2012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
187 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
188 * lisp.h (INTERNAL_FIELD): New macro.
189 * buffer.h (BUFFER_INTERNAL_FIELD): Removed.
190 (BVAR): Change to use INTERNAL_FIELD.
191 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
192 (KVAR): Change to use INTERNAL_FIELD.
193 * frame.h (FVAR): New macro.
194 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
195 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
196 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
197 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
198 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
200 2012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
202 Miscellaneous fixes for non-default X toolkits.
203 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
204 * xterm.c (x_frame_of_widget): Remove redundant prototype.
205 Move under #ifdef USE_LUCID.
206 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
207 definition and usage to avoid warnings.
209 2012-07-31 Jan Djärv <jan.h.d@swipnet.se>
211 * nsterm.m (openFiles): Fix previous checkin.
213 2012-07-31 Paul Eggert <eggert@cs.ucla.edu>
215 * indent.c (compute_motion): Remove unused local.
217 2012-07-31 Glenn Morris <rgm@gnu.org>
219 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
221 * conf_post.h [USG5_4]:
222 Move remaining contents of s/usg5-4-common.h here.
223 * s/usg5-4-common.h: Remove file.
225 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
226 * s/irix6-5.h: Remove file.
228 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
229 * s/darwin.h: Remove file.
231 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
232 * s/hpux10-20.h: Remove file, which is now empty.
234 2012-07-30 Glenn Morris <rgm@gnu.org>
236 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
237 * Makefile.in (config_h): Add conf_post.h.
238 * makefile.w32-in (CONFIG_H): Add conf_post.h.
240 2012-07-30 Jan Djärv <jan.h.d@swipnet.se>
242 * nsterm.m (ns_do_open_file): New variable.
243 (ns_term_init): Set ns_do_open_file to YES after run returns.
244 (openFile, openTempFile, openFileWithoutUI, openFiles): Open
245 files only if ns_do_open_file.
247 2012-07-30 Paul Eggert <eggert@cs.ucla.edu>
249 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
250 This no-op macro hasn't been needed for many years.
251 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
253 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
254 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
255 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
256 gdb_make_enums_visible.
257 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
258 (DIRECTORY_SEP): Now a constant, not a macro.
260 2012-07-30 Eli Zaretskii <eliz@gnu.org>
262 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
263 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
265 * w32term.c <w32_keyboard_codepage>: Renamed from
266 keyboard_codepage and now external. All users changed.
268 * w32term.h: Add declaration of w32_keyboard_codepage.
270 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
271 the codepage to translate keys to Unicode. If this argument is
272 -1, use the value returned by GetConsoleCP. All callers changed.
274 2012-07-30 Paul Eggert <eggert@cs.ucla.edu>
276 Update .PHONY listings in makefiles.
277 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
278 bootstrap-clean, distclean, maintainer-clean, versioclean,
281 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
282 This is a bit clearer. Fix some commentary typos.
284 2012-07-30 Glenn Morris <rgm@gnu.org>
286 * s/netbsd.h: Let configure include signal.h if needed.
287 Remove file, which is now empty.
289 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
290 Let configure set them.
291 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
292 No more need to undefine.
294 2012-07-30 Andreas Schwab <schwab@linux-m68k.org>
296 * keymap.c (Fkey_description): Don't remove 0x80 bit from
297 non-single-byte char when adding meta modifier. (Bug#12090)
299 2012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
301 Convert safe_call to use variable number of arguments.
302 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
303 (safe_call2): Fix comment.
304 * lisp.h (safe_call): Adjust prototype.
305 * coding.c (encode_coding_object): Change to use safe_call2.
306 * xfaces.c (merge_face_heights): Change to use safe_call1.
308 2012-07-30 Glenn Morris <rgm@gnu.org>
310 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
311 does that unconditionally. Remove file, which is now empty.
313 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
316 2012-07-30 Paul Eggert <eggert@cs.ucla.edu>
318 Export to GDB most of lisp.h's remaining object-like macros.
319 * lisp.h (min, max): Move earlier, because they're used earlier now.
320 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
321 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
322 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
323 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
324 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
325 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
326 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
327 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
328 Now constants, for GDB. They need not be macros.
329 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
330 Now constants, for GDB, as well as macros, for static initializers.
331 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
332 Move to after the definition of struct Lisp_Char_Table,
333 since the former now needs that type defined.
334 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
335 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
336 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
337 New enums, for gdb_make_enums_visible.
338 (GLYPH_MODE_LINE_FACE): Remove; unused.
339 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
340 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
341 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
342 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
343 enum maxargs, enum MAX_ALLOCA.
344 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
345 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
346 no longer needed, now that they are done in lisp.h.
348 2012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
350 Cleanup string bytes checking.
351 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
352 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
353 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
354 (check_sblock, compact_small_strings): Simplify.
356 2012-07-29 Paul Eggert <eggert@cs.ucla.edu>
358 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
359 These macros are confusing and no longer need to be defined, as
360 the enum values now suffice. All uses replaced with definiens.
361 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
363 2012-07-29 Juanma Barranquero <lekktu@gmail.com>
365 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
366 ($(BLD)/w32console.$(O)): Update dependencies.
368 2012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
370 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
371 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
373 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
375 2012-07-29 Jan Djärv <jan.h.d@swipnet.se>
377 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
378 setting sitelisp (Bug#12010).
380 2012-07-29 Eli Zaretskii <eliz@gnu.org>
382 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
384 * w32heap.c (cache_system_info):
385 * w32.c (sys_rename):
386 * w32proc.c (find_child_console, sys_kill): All users changed.
388 2012-07-29 Paul Eggert <eggert@cs.ucla.edu>
390 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
392 2012-07-29 Eli Zaretskii <eliz@gnu.org>
394 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
396 2012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
398 Cleanup statistics calculation in Fgarbage_collect.
399 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
400 zombies percentage calculation. Simplify elapsed time calculation.
402 2012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
404 Generalize marker debugging code under MARKER_DEBUG and use eassert.
405 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
406 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
407 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
408 (replace_range, replace_range_2, del_range_2): Change to eassert.
409 * marker.c (byte_char_debug_check): Adjust style.
411 2012-07-29 Paul Eggert <eggert@cs.ucla.edu>
413 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
414 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
415 long-ago-commented-out code that talks about "WIN32".
416 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
419 2012-07-28 Paul Eggert <eggert@cs.ucla.edu>
421 Use Gnulib stdalign module (Bug#9772, Bug#9960).
422 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
423 Simplify by using alignof.
424 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
425 * lisp.h: Include <stdalign.h>.
426 (GCALIGNMENT): New macro and constant.
427 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
428 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
429 (stdalign): New macro, if not already defined.
431 2012-07-28 Eli Zaretskii <eliz@gnu.org>
433 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
434 * w32inevt.c: Include w32inevt.h.
435 (w32_read_console_input): New inline function, calls either
436 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
437 w32_console_unicode_input.
438 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
439 (w32_kbd_patch_key, key_event): Use the codepage returned by
440 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
441 (key_event): use uChar.UnicodeChar only if
442 w32_console_unicode_input is non-zero.
444 * w32console.c: Include w32heap.h.
445 <w32_console_unicode_input>: New global variable.
446 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
447 family of Windows, zero otherwise.
449 * w32inevt.h: Declare w32_console_unicode_input.
451 * xdisp.c (init_iterator): Don't reference tip_frame in a build
452 --without-x. (Bug#11742)
454 2012-07-27 Paul Eggert <eggert@cs.ucla.edu>
456 Adjust GDB to reflect pvec_type changes (Bug#12036).
457 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
458 2012-07-04 changes to pseudovector representation. Problem
459 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
461 2012-07-27 Michael Albinus <michael.albinus@gmx.de>
463 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
465 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
467 2012-07-27 Eli Zaretskii <eliz@gnu.org>
469 * alloc.c (listn): Fix the order the arguments are consed onto the
472 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
473 enumeration constants, as PURE and HEAP are too general, and clash
474 with other headers and sources, such as gmalloc.c and the
475 MS-Windows system headers. All users changed.
477 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
479 Revert last save_excursion_save and save_excursion_restore changes.
480 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
481 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
483 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
485 Fix recently-introduced typos in Windows port.
486 Reported by Martin Rudalics <rudalics@gmx.at>.
487 * w32.c (init_environment): Replace comma with semicolon.
488 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
490 2012-07-27 Paul Eggert <eggert@cs.ucla.edu>
492 Improve GDB symbol export (Bug#12036).
493 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
494 arms of an 'if', not using conditional expressions; otherwise GDB
495 complains about the types in the unevaluated arm when the argument
496 is an integer literal.
497 (xgetint): Simplify expression.
498 * alloc.c (gdb_make_enums_visible): New constant. This ports to
499 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
500 Zaretskii in <http://bugs.gnu.org/12036#13>.
501 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
502 needed now that we have gdb_make_enums_visible.
503 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
504 (enum enum_USE_LSB_TAG):
505 New enum types, packaging up enums that need to be exported to GDB.
507 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
509 Utility function to make a list from specified amount of objects.
510 * lisp.h (enum constype): New datatype.
511 (listn): New prototype.
512 * alloc.c (listn): New function.
513 (Fmemory_use_count, syms_of_alloc): Use it.
514 * buffer.c (syms_of_buffer): Likewise.
515 * callint.c (syms_of_callint): Likewise.
516 * charset.c (define_charset_internal): Likewise.
517 * coding.c (syms_of_coding): Likewise.
518 * keymap.c (syms_of_keymap): Likewise.
519 * search.c (syms_of_search): Likewise.
520 * syntax.c (syms_of_syntax): Likewise.
521 * w32.c (init_environment): Likewise.
522 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
523 * xdisp.c (syms_of_xdisp): Likewise.
524 * xfns.c (syms_of_xfns): Likewise.
526 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
528 Fast save_excursion_save and save_excursion_restore.
529 * lisp.h (struct Lisp_Excursion): New data type.
530 (PVEC_EXCURSION): New pseudovector type.
531 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
532 to deal with it. Adjust comments.
533 (init_marker, attach_marker): New prototype.
534 (unchain_marker): Adjust prototype.
535 * marker.c (attach_marker): Change to global.
536 (init_marker): New function.
537 * alloc.c (Fmake_marker, build_marker): Use it.
538 (build_marker): More easserts.
539 (mark_object): Handle struct Lisp_Excursion.
540 * editfns.c (save_excursion_save, save_excursion_restore):
541 Reimplement to use struct Lisp_Excursion. Add comments.
543 2012-07-26 Paul Eggert <eggert@cs.ucla.edu>
545 Fix export of symbols to GDB (Bug#12036).
546 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
547 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
548 emacs.c, as this is a more-suitable home. Had this been done earlier
549 the fix for 12036 would have avoided some of the problems noted in
550 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
551 would have been more obvious.
552 * emacs.c: Do not include <verify.h>; no longer needed.
553 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
554 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
555 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
556 Remove; now done in lisp.h.
557 * lisp.h (PUBLISH_TO_GDB): New macro.
558 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
559 (DATA_SEG_BITS): Use it.
560 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
561 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
562 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
563 not be usable in #if. This simplifies things.
565 2012-07-26 Juanma Barranquero <lekktu@gmail.com>
567 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
569 2012-07-26 Paul Eggert <eggert@cs.ucla.edu>
571 Simplify export of symbols to GDB (Bug#12036).
572 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
573 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
574 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
575 Adjust to changes in lisp.h and emacs.c, by using
576 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
577 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
578 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
579 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
580 instead of gdb_valbits.
581 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
582 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
583 instead of gdb_array_mark_flag.
584 (xboolvector): Get size from $->size, not $->header.size.
585 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
586 (xreload, hook-run, hookpost-run): Remove.
587 * emacs.c: Include <verify.h>.
588 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
589 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
591 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
592 (gdb_USE_LSB_TAG): New enum constants.
593 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
594 Also define these as enum constants, so they're visible to GDB.
595 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
596 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
597 as constants, so they're visible to GDB.
598 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
599 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
600 Now enum constants, not macros, so they're visible to GDB.
601 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
602 more convenient now. All uses changed.
603 (VALMASK) [USE_LSB_TAG]: Also define in this case.
604 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
606 2012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
608 Explicitly free restriction data that are not needed anymore.
609 * editfns.c (save_restriction_restore): Free restriction data.
611 2012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
613 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
614 add argument, tune behavior, and adjust all callers.
616 2012-07-25 Paul Eggert <eggert@cs.ucla.edu>
618 Use typedef for EMACS_INT, EMACS_UINT.
619 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
620 than macros. This simplifies debugging in the usual case, since
621 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
622 and it allows expressions involving EMACS_INT casts.
623 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
625 2012-07-25 Jan Djärv <jan.h.d@swipnet.se>
627 * nsterm.m (ns_read_socket): Return early if there is a modal
630 2012-07-25 Martin Rudalics <rudalics@gmx.at>
632 * frame.c (Fredirect_frame_focus): In doc-string don't mention
633 that FOCUS-FRAME can be omitted.
635 2012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
637 Adjust buffer text indirection counters at the end of Fkill_buffer.
638 * buffer.c (Fkill_buffer): Adjust indirection counters when the
639 buffer is definitely dead. This should really fix an issue reported
640 by Christoph Scholtes again. (Bug#12007).
641 (init_buffer_once): Initialize indirection counters of
642 buffer_defaults and buffer_local_symbols (for sanity and safety).
644 2012-07-24 Eli Zaretskii <eliz@gnu.org>
646 * xdisp.c (init_iterator): Don't compute dimensions of truncation
647 and continuation glyphs on tooltip frames, leave them at zero.
648 Avoids continued lines in tooltips. (Bug#11832)
650 2012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
652 Simplify copy_overlay.
653 * buffer.c (copy_overlay): Simplify. Use build_marker.
654 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
656 2012-07-23 Eli Zaretskii <eliz@gnu.org>
658 * print.c (print_object): Don't crash when a frame's name is nil
659 or invalid. (Bug#12025)
661 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
662 it signals an error when a tooltip frame is being created.
664 2012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
666 Cleanup miscellaneous objects allocation and initialization.
667 * alloc.c (allocate_misc): Change to static. Add argument to
668 specify the subtype. Adjust comment and users.
669 (build_overlay): New function.
670 * buffer.c (copy_overlays, Fmake_overlay): Use it.
671 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
672 (allocate_misc): Remove prototype.
673 (build_overlay): Add prototype.
675 2012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
677 Swap buffer text indirection counters in Fbuffer_swap_text.
678 * buffer.c (Fbuffer_swap_text): Swap indirections too.
679 This avoids crash reported by Christoph Scholtes at
680 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
682 2012-07-22 Jan Djärv <jan.h.d@swipnet.se>
684 * nsmenu.m (Popdown_data): New struct.
685 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
687 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
688 (initWithContentRect): Make imgView and contentView non-static
689 and autorelease them. Also autorelease img and matrix (Bug#12005).
690 (dealloc): Remove (Bug#12005).
692 2012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
694 Adjust consing_since_gc when objects are explicitly freed.
695 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
696 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
697 (free_cons, free_misc): Subtract object size from consing_since_gc.
699 2012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
701 Simplify and cleanup markers positioning code.
702 * marker.c (attach_marker): More useful eassert.
703 (live_buffer, set_marker_internal): New function.
704 (Fset_marker, set_marker_restricted): Use set_marker_internal.
705 (set_marker_both, set_marker_restricted_both): Use live_buffer.
707 2012-07-22 Paul Eggert <eggert@cs.ucla.edu>
709 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
710 as it's limited by the amount of memory, not by INT_MAX.
712 2012-07-21 Eli Zaretskii <eliz@gnu.org>
714 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
715 in special-event-map. See the discussion at
716 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
719 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
720 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
721 Fabrice Popineau <fabrice.popineau@supelec.fr>.
723 2012-07-21 Jan Djärv <jan.h.d@swipnet.se>
725 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
726 (conversationIdentifier): Return value is NSInteger.
727 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
729 2012-07-21 Chong Yidong <cyd@gnu.org>
731 * window.c (decode_any_window): Signal an error if the window is
732 on a dead frame (Bug#11984).
734 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
736 Add indirection counting to speed up Fkill_buffer.
737 * buffer.h (struct buffer): New member.
738 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
739 (Fmake_indirect_buffer): Set indirection counter to -1, increment
740 base buffer indirection counter.
741 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
742 (Fkill_buffer): Adjust indirection counters as needed, don't walk
743 through buffer list if indirection counter is 0.
745 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
747 Extend the value returned by Fgarbage_collect with heap statistics.
748 * alloc.c (Qheap): New symbol.
749 (syms_of_alloc): DEFSYM it.
750 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
751 (Fmemory_free): Remove.
752 (syms_of_alloc): Don't defsubr it.
753 * buffer.c (Fcompact_buffer): Remove.
754 (syms_of_buffer): Don't defsubr it.
756 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
758 Make maybe_gc inline.
759 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
760 * lisp.h (consing_since_gc, gc_relative_threshold)
761 (memory_full_cons_threshold): Revert declaration.
762 (maybe_gc): Remove prototype, define as inline.
763 * alloc.c: Remove old commented-out code.
764 (consing_since_gc, gc_relative_threshold)
765 (memory_full_cons_threshold): Revert to global.
768 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
770 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
771 * lisp.h (build_unibyte_string): New function.
772 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
773 * sysdep.c, w32fns.c, xfns.c: Use it.
774 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
775 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
776 Adjust users accordingly.
777 * font.h (font_open_by_name): Adjust prototype.
779 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
781 Cleanup calls to Fgarbage_collect.
782 * lisp.h (maybe_gc): New prototype.
783 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
785 * alloc.c (maybe_gc): New function.
786 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
788 * bytecode.c (MAYBE_GC): Use maybe_gc.
789 * eval.c (eval_sub, Ffuncall): Likewise.
790 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
791 to avoid dependency from auto-save feature.
793 2012-07-19 Paul Eggert <eggert@cs.ucla.edu>
795 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
796 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
797 'for_each_per_buffer_object_at'.
798 All uses changed. It's better to use upper-case for macros that
799 cannot be implemented as functions, to give the reader a clue
800 that they're special.
802 2012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
804 * alloc.c (Fgarbage_collect): Tweak docstring.
806 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
808 Tweak the value returned from Fgarbage_collect again.
809 * alloc.c (Fgarbage_collect): New return value, as confirmed in
810 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
811 Adjust documentation.
812 (total_vector_bytes): Rename to total_vector_slots, adjust
814 (total_free_vector_bytes): Rename to total_free_vector_slots,
816 (Qstring_bytes, Qvector_slots): New symbols.
817 (syms_of_alloc): DEFSYM them.
819 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
821 Buffer compaction primitive which may be used from Lisp.
822 * buffer.c (compact_buffer, Fcompact_buffer): New function.
823 (syms_of_buffer): Register Fcompact_buffer.
824 * alloc.c (Fgarbage_collect): Use compact_buffer.
825 * buffer.h (compact_buffer): New prototype.
826 (struct buffer_text): New member.
828 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
830 New macro to iterate over all buffers, miscellaneous cleanups.
831 * lisp.h (all_buffers): Remove declaration.
832 * buffer.h (all_buffers): Add declaration, with comment.
833 (for_each_buffer): New macro.
834 * alloc.c (Fgarbage_collect, mark_object): Use it.
835 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
836 (init_buffer): Likewise.
837 * data.c (Fset_default): Likewise.
838 * coding.c (code_conversion_restore): Remove redundant check
840 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
842 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
844 Fix bug that created negative-length intervals.
845 * intervals.c (merge_interval_right, merge_interval_left):
846 Do not zero out this interval if it is absorbed by its children,
847 as this interval's total length doesn't change in that case. See
848 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
850 2012-07-18 Paul Eggert <eggert@cs.ucla.edu>
852 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
853 when invoking (make-bool-vector N t) and N is a positive
854 multiple of 8 -- the last 8 bits were mistakenly cleared.
856 Remove some struct layout assumptions in bool vectors.
857 * alloc.c (bool_header_size): New constant.
858 (header_size, word_size): Move earlier, as they're now used earlier.
859 Use 'word_size' in a few more places, where it's appropriate.
860 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
861 padding before the data member of a bool vector.
862 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
863 than doing the check by hand with an abort ().
865 2012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
867 * eval.c (Fdefvar): Don't check constants since we only set the var if
868 it's not yet defined anyway (bug#11904).
870 * lisp.h (last_undo_boundary): Declare new var.
871 * keyboard.c (command_loop_1): Set it.
872 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
873 were auto-added by the command loop (bug#11774).
875 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
877 * w32font.c (Qsymbol): Remove local definition.
878 (syms_of_w32font): Don't DEFSYM it.
880 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
882 Fix sweep_vectors to handle large bool vectors correctly.
883 * alloc.c (sweep_vectors): Account total_vector_bytes for
884 bool vectors larger than VBLOCK_BYTES_MAX.
886 2012-07-18 Chong Yidong <cyd@gnu.org>
888 * frame.c (x_set_frame_parameters): Revert bogus change introduced
889 in 2012-05-25 commit by Paul Eggert (Bug#11738).
891 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
893 Return more descriptive data from Fgarbage_collect.
894 Suggested by Stefan Monnier in
895 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
896 * alloc.c (bounded_number): New function.
897 (total_buffers, total_vectors): New variable.
898 (total_string_size): Rename to total_string_bytes, adjust users.
899 (total_vector_size): Rename to total_vector_bytes, adjust users.
900 (sweep_vectors): Account total_vectors and total_vector_bytes.
901 (Fgarbage_collect): New return value. Adjust documentation.
902 (gc_sweep): Account total_buffers.
903 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
904 (VECTOR_SIZE): Remove.
905 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
906 (Qinterval, Qmisc): New symbols.
907 (syms_of_data): Initialize them.
908 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
909 (Qcons, Qbuffer): New declarations.
911 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
913 * alloc.c (Fmemory_free): Account for memory-free's own storage.
914 Round up, not down. Improve doc.
916 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
918 Restore old code in allocate_string_data to avoid Faset breakage.
919 Reported by Julien Danjou <julien@danjou.info> in
920 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
921 * alloc.c (allocate_string_data): Restore old code with minor
922 adjustments, fix comment to explain this subtle issue.
924 2012-07-17 Eli Zaretskii <eliz@gnu.org>
926 Remove FILE_SYSTEM_CASE.
927 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
929 * fileio.c (FILE_SYSTEM_CASE): Don't define.
930 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
931 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
932 call-process-region passes it through expand-file-name.
934 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
936 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
938 Fix crash when creating indirect buffer (Bug#11917)
939 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
940 Don't handle unbound variables specially if non-zero.
941 (Fbuffer_local_variables): Pass zero.
942 (clone_per_buffer_values): Pass non-zero.
944 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
946 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
947 to make the loop interruptible.
949 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
951 * gnutls.c (emacs_gnutls_handshake): Only retry if
952 GNUTLS_E_INTERRUPTED.
954 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
956 Cleanup and convert miscellaneous checks to eassert.
957 * alloc.c (mark_interval): Fix comment, partially rephrase
958 old comment from intervals.h (see below).
959 * intervals.c (find_interval, adjust_intervals_for_insertion)
960 (delete_interval, adjust_intervals_for_deletion)
961 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
963 (adjust_intervals_for_insertion, make_new_interval):
964 Remove obsolete and unused code.
965 * intervals.h (struct interval): Remove obsolete comment.
966 * textprotp.c (erase_properties): Remove unused code.
967 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
968 (Fremove_list_of_text_properties): Convert to eassert.
970 2012-07-17 Chong Yidong <cyd@gnu.org>
972 * editfns.c (Finsert_char): Doc fix.
974 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
976 Fix previous change to make Fmemory_free always accurate.
977 * alloc.c (make_interval): Update total_free_intervals.
978 (make_float): Likewise for total_free_floats.
979 (free_cons, Fcons): Likewise for total_free_conses.
980 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
981 Likewise for total_free_vector_bytes.
982 (Fmake_symbol): Likewise for total_free_symbols.
983 (bytes_free): Remove.
985 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
987 Simple free memory accounting feature.
988 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
989 (sweep_vectors): Accumulate size of free vectors.
990 (Fgarbage_collect): Setup bytes_free.
991 (Fmemory_free): New function.
992 (syms_of_alloc): Register it.
994 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
996 Cleanup overlays checking.
997 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
998 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
999 eassert and OVERLAYP.
1000 (sort_overlays): Change to use OVERLAYP.
1002 2012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
1004 * editfns.c (Finsert_char): Make it interactive, and make the
1005 second arg optional. Copy interactive spec and docstring from
1008 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1010 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
1011 Unlike the other wrapped functions, fabs has an unspecified
1014 2012-07-16 Jan Djärv <jan.h.d@swipnet.se>
1016 * nsterm.m (keyDown): Interpret flags without left/right bits
1017 as the left key (Bug#11670).
1019 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1021 Remove empty and useless init functions.
1022 * lisp.h (init_character_once, init_fns, init_image)
1023 (init_filelock, init_sound): Remove prototype.
1024 * character.c (init_character_once): Remove.
1025 * filelock.c (init_filelock): Likewise.
1026 * fns.c (init_fns): Likewise.
1027 * image.c (init_image): Likewise.
1028 * sound.c (init_sound): Likewise.
1029 * emacs.c (main): Adjust accordingly.
1031 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1033 * gtkutil.h: Tiny cleanups.
1034 (use_old_gtk_file_dialog): Remove useless declaration.
1035 (xg_uses_old_file_dialog): Add suggested const attribute.
1037 2012-07-15 Eli Zaretskii <eliz@gnu.org>
1039 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
1040 (bidi_paragraph_init): Use it to limit search forward for a strong
1041 directional character in abnormally large paragraphs full of
1042 neutral or weak characters. (Bug#11943)
1044 2012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
1046 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
1047 the toolbar (Bug#9451).
1048 (xg_make_tool_item): Give the widget event box a transparent
1051 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1053 Cleanup basic allocation variables and functions.
1054 * alloc.c (ignore_warnings, init_intervals, init_float)
1055 (init_cons, init_symbol, init_marker): Remove.
1056 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
1057 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
1058 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
1059 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
1060 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
1061 (staticidx, init_alloc_once, init_strings, free_ablock):
1062 Remove redundant initialization.
1063 * fns.c (init_weak_hash_tables): Remove.
1064 * lisp.h (init_weak_hash_tables): Remove prototype.
1066 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1068 Use zero_vector where appropriate.
1069 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
1071 * lisp.h (zero_vector): New declaration.
1072 * font.c (null_vector): Remove.
1073 (syms_of_font): Remove initialization and staticpro.
1074 (font_list_entities, font_find_for_lface): Change to use zero_vector.
1075 * keymap.c (Faccessible_keymaps): Likewise.
1077 2012-07-15 Leo Liu <sdl.web@gmail.com>
1079 * fringe.c: Fix typo in comments.
1081 2012-07-14 Leo Liu <sdl.web@gmail.com>
1083 * fringe.c: Add a new bitmap exclamation-mark.
1085 2012-07-14 Eli Zaretskii <eliz@gnu.org>
1087 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
1089 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
1090 (HAVE_MENUS): Don't define, defined by editing config.in with
1092 (GMALLOC_INHIBIT_VALLOC): Don't define.
1093 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
1095 2012-07-14 Juanma Barranquero <lekktu@gmail.com>
1097 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
1099 2012-07-14 Glenn Morris <rgm@gnu.org>
1101 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
1102 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
1103 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
1105 2012-07-13 Glenn Morris <rgm@gnu.org>
1107 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
1109 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
1110 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
1112 2012-07-13 Jan Djärv <jan.h.d@swipnet.se>
1114 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
1115 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
1116 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
1117 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
1119 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
1120 as boolean expression.
1121 (x_set_window_size): Remove unused variable toolbar.
1122 (ns_get_color_default, ns_mod_to_lisp): Remove.
1123 (ns_mouse_position): Remove unused variables xchar and ychar.
1124 (ns_compute_glyph_string_overhangs): Remove unused variable face.
1125 (ns_set_vertical_scroll_bar): Remove unused variable count.
1126 (ns_delete_terminal): Remove unused variable i.
1127 (ns_term_init): Remove unused variables r, g and b.
1128 (mouseDown): Remove unused variable window.
1129 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
1130 (initFrameFromEmacs): Remove unused variable vbextra.
1131 (mouseEntered): Remove unused variables p and dpyinfo.
1132 (mouseExited): Remove unused variables p and r.
1133 (ns_define_frame_cursor, ns_clear_frame_area)
1134 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
1135 (menuDown): Assign [sender tag] to variable and cast the variable.
1137 * nsterm.h (menuDown): Add id as type to argument sender.
1138 (ns_display_info_for_name): Add Lisp_Object argument.
1139 (ns_term_init): Add Lisp_Object argument.
1140 (ns_map_event_to_object): Add void argument.
1141 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
1142 prototype with arguments and only declare if __OBJC__.
1143 (nxatoms_of_nsselect): Add void argument.
1144 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
1145 (ns_alloc_autorelease_pool): Add void argument.
1146 (ns_release_autorelease_pool): Add void* argument.
1147 (ns_get_defaults_value): Add const char* argument.
1149 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1150 (initFromContents): Use SSDATA where appropriate.
1151 (ns_update_menubar): Add braces to ambigous if-else.
1152 (initWithTitle): Put () around assignment in if statement.
1153 (ns_menu_show): Remove unused variables window and keymap.
1154 (update_frame_tool_bar): Remove unused variable selected_p.
1155 (initWithContentRect): Remove unused variable this_cmd_name.
1157 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1159 (setXBMColor): Remove unused variable len.
1160 (setPixmapData): Put () around assignment in loop statement.
1162 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1163 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1165 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1166 around assignment in loop statement.
1167 (nsfont_open): Remove unused variable i.
1168 (nsfont_open): Remove unused variable len.
1169 (nsfont_draw): Remove unused variable cs.
1171 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1172 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1173 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1174 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1175 (Fns_font_name, Fns_perform_service)
1176 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1177 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1178 (ns_set_name): Remove unused variable view.
1179 (x_set_menu_bar_lines): Remove unused variable olines.
1180 (x_set_tool_bar_lines): Remove unused variable root_window.
1181 (Fns_list_colors): Put () around assignment in while statement.
1182 (Fns_perform_service): Remove unused variable len.
1183 (Fns_display_usable_bounds): Remove unused variable top.
1184 (syms_of_nsfns): Remove unused variable i.
1186 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1189 2012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
1191 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1192 and free it with DestroyExceptionInfo (Bug#11558).
1194 2012-07-13 Juanma Barranquero <lekktu@gmail.com>
1196 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1197 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1198 Set here, not in nt/config.nt.
1200 2012-07-13 Eli Zaretskii <eliz@gnu.org>
1202 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1203 cursor overflow into the last glyph on display line when the right
1204 fringe is off. (Bug#11832)
1206 2012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1208 * xdisp.c (produce_special_glyphs): Now static.
1209 * dispextern.h (produce_special_glyphs): Remove decl.
1211 2012-07-13 Glenn Morris <rgm@gnu.org>
1213 * s/bsd-common.h, s/cygwin.h: Remove empty files.
1214 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1216 * s/usg5-4-common.h (USG, USG5):
1217 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1218 * s/sol2-6.h (SOLARIS2):
1219 * s/irix6-5.h (IRIX6_5):
1220 * s/hpux10-20.h (USG, USG5, HPUX):
1221 * s/gnu-linux.h (USG, GNU_LINUX):
1222 * s/freebsd.h (BSD_SYSTEM):
1223 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1224 * s/cygwin.h (CYGWIN):
1225 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1226 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1228 2012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
1230 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
1232 2012-07-13 Glenn Morris <rgm@gnu.org>
1234 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1236 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1238 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1239 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1241 2012-07-12 Glenn Morris <rgm@gnu.org>
1243 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
1245 * process.c (init_process_emacs): Rename from init_process.
1246 The old name is also the name of a Mach system call.
1247 * lisp.h, emacs.c: Update for this name change.
1248 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1251 2012-07-12 Eli Zaretskii <eliz@gnu.org>
1253 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1254 memmove call that removes glyphs covered by the left truncation
1255 glyph. Improve commentary.
1256 (display_line): Fix display of continuation glyphs on GUI frames
1257 when the right fringe is turned off and variable-size fonts are
1258 used in the window. Move the code that appends a stretch glyph to
1259 produce_special_glyphs, so that it could be used for truncation
1260 and continuation glyphs alike.
1261 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1262 glyph of a suitably computed width, to align the special glyphs at
1263 the window margin. Code moved from display_line. (Bug#11832)
1265 2012-07-12 Glenn Morris <rgm@gnu.org>
1267 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1269 * s/gnu-linux.h, s/hpux10-20.h:
1270 Do not unconditionally define HAVE_XRMSETDATABASE.
1272 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1274 2012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1276 Fix typos that broke OS X build.
1277 Reported by Randal L. Schwartz in
1278 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1279 * nsterm.m (ns_timeout): Add missing local decl.
1280 (ns_get_color): snprintf -> sprintf, to fix typo.
1282 2012-07-12 Glenn Morris <rgm@gnu.org>
1284 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1285 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1286 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1287 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1289 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1290 Move PTY_OPEN to configure.
1292 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1293 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1294 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1296 2012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1298 Use empty_unibyte_string where applicable.
1299 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1300 * lread.c (read1): Likewise.
1301 * xsettings.c (syms_of_xsettings): Likewise.
1303 2012-07-12 Glenn Morris <rgm@gnu.org>
1305 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1306 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
1307 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1308 * s/hpux10-20.h (RUN_TIME_REMAP):
1309 * s/bsd-common.h (TABDLY): Move to configure.
1311 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1313 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1315 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1316 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
1318 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
1320 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1321 * s/template.h: Move NARROWPROTO to configure.
1323 2012-07-11 Glenn Morris <rgm@gnu.org>
1325 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1326 unused since 2011-01-17 change to systty.h.
1328 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1329 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1330 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1332 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1334 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1336 2012-07-11 Glenn Morris <rgm@gnu.org>
1338 * s/darwin.h, s/gnu-linux.h, s/template.h:
1339 Move INTERRUPT_INPUT to configure.
1341 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1343 Minor adjustments to interning code.
1344 * lisp.h (intern, intern_c_string): Redefine as static inline
1345 wrappers for intern_1 and intern_c_string_1, respectively.
1346 (intern_1, intern_c_string_1): Rename prototypes.
1347 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1349 * font.c (font_intern_prop): Likewise. Adjust comment.
1350 * w32font.c (intern_font_name): Likewise.
1352 2012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1354 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1356 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1357 of Fcar/Fcdr if possible.
1358 * font.c (check_otf_features): Likewise.
1359 * fontset.c (Fnew_fontset): Likewise.
1360 * gnutls.c (Fgnutls_boot): Likewise.
1361 * minibuf.c (read_minibuf): Likewise.
1362 * msdos.c (IT_set_frame_parameters): Likewise.
1363 * xmenu.c (Fx_popup_dialog): Likewise.
1364 * w32menu.c (Fx_popup_dialog): Likewise.
1366 2012-07-11 Glenn Morris <rgm@gnu.org>
1368 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1369 since nothing has defined it on these platforms.
1371 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1372 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1374 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1375 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1376 Move CLASH_DETECTION to configure.
1378 * s/gnu.h: Remove file, which is now empty.
1380 * s/gnu.h, s/gnu-linux.h:
1381 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1383 2012-07-11 John Wiegley <johnw@newartisans.com>
1385 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1386 function attribute, so we only use it if it exists in the
1389 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1391 Avoid call to strlen in fast_c_string_match_ignore_case.
1392 * search.c (fast_c_string_match_ignore_case): Change to use
1393 length argument. Adjust users accordingly.
1394 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1396 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1398 Assume mkdir, rmdir.
1399 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1400 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1403 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1406 * s/hpux10-20.h (HAVE_PERROR): Remove.
1407 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1408 Remove dummy definition, as this problem was obsolete long ago.
1411 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1413 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1415 Avoid calls to strlen in font processing functions.
1416 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
1417 (font_open_by_name): Change to use length argument. Adjust
1419 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1421 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1422 Change to return ptrdiff_t.
1423 (xfont_list_pattern, xfont_match): Use length returned by
1424 xfont_decode_coding_xlfd.
1425 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1427 2012-07-11 Glenn Morris <rgm@gnu.org>
1429 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1430 Move DONT_REOPEN_PTY to configure.
1432 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1433 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1435 2012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1437 Remove "#define unix" that is no longer needed (Bug#11905).
1438 * s/aix4-2.h (unix): Remove; no longer needed.
1440 EMACS_TIME simplification (Bug#11875).
1441 This replaces macros (which typically do not work in GDB)
1442 with functions, typedefs and enums, making the code easier to debug.
1443 The functional style also makes code easier to read and maintain.
1444 * systime.h: Include <sys/time.h> on all hosts, not just if
1445 WINDOWSNT, since 'struct timeval' is needed in general.
1446 (EMACS_TIME): Now a typedef, not a macro.
1447 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1449 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1450 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1451 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1452 (EMACS_TIME_LE): Now functions, not macros.
1453 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1454 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1455 which are not functions. All uses rewritten to use:
1456 (make_emacs_time): New function.
1457 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1458 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1459 not functions. All uses rewritten to use the following, respectively:
1460 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1461 (add_emacs_time, sub_emacs_time): New functions.
1462 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
1463 * fileio.c (Fcopy_file):
1464 * xterm.c (XTflash): Get the current time closer to when it's used.
1465 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1467 * bytecode.c (targets): Suppress -Woverride-init warnings.
1469 Simplify by avoiding confusing use of strncpy etc.
1470 * doc.c (Fsnarf_documentation):
1471 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1472 * frame.c (Fmake_terminal_frame):
1473 * gtkutil.c (get_utf8_string):
1475 * nsmenu.m (ns_update_menubar):
1476 * regex.c (regerror):
1477 Prefer memcpy to strncpy and strncat when either will do.
1478 * fileio.c (Fsubstitute_in_file_name):
1479 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1480 (menu_separator_name_p):
1481 * nsmenu.m (ns_update_menubar):
1482 Prefer memcmp to strncmp when either will do.
1483 * nsterm.m: Include <ftoastr.h>.
1485 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1486 Prefer snprintf to strncpy.
1487 * nsterm.m (ns_term_init):
1488 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1489 * nsterm.m (ns_term_init):
1490 Avoid the need for strncpy, by using build_string or
1491 make_unibyte_string directly. Use dtoastr, not snprintf.
1492 * process.c (Fmake_network_process): Diagnose service names that
1493 are too long, rather than silently truncating them or creating
1494 non-null-terminated names.
1495 (Fnetwork_interface_info): Likewise, for interface names.
1496 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1497 Prefer sprintf to strncat.
1498 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1499 Prefer vsnprintf to vsprintf + strncpy.
1501 2012-07-10 Glenn Morris <rgm@gnu.org>
1503 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1504 Clarify fallback case.
1506 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1508 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1509 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1510 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
1511 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
1512 where argument type is known to be a Lisp_Cons.
1514 2012-07-10 Tom Tromey <tromey@redhat.com>
1516 * bytecode.c (BYTE_CODE_THREADED): New macro.
1517 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1518 (enum byte_code_op): New type.
1519 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1520 (exec_byte_code): Use them. Use token threading when applicable.
1522 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1524 Optimize pure C strings initialization.
1525 * lisp.h (make_pure_string): Fix prototype.
1526 (build_pure_c_string): New function, defined as static inline. This
1527 provides a better opportunity to optimize away calls to strlen when
1528 the function is called with compile-time constant argument.
1529 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1530 argument, adjust users accordingly. Use build_pure_c_string where
1532 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1533 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1534 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1536 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1538 Avoid calls to strlen in miscellaneous functions.
1539 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1540 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1541 * lread.c (openp): Likewise.
1543 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1545 Avoid calls to strlen in path processing functions.
1546 * fileio.c (file_name_as_directory): Add comment. Change to add
1547 srclen argument and return the length of result. Adjust users
1549 (directory_file_name): Fix comment. Change to add srclen argument,
1550 swap 1st and 2nd arguments to obey the common convention. Adjust
1552 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1554 2012-07-10 Glenn Morris <rgm@gnu.org>
1556 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1557 Move PENDING_OUTPUT_COUNT definition to configure.
1559 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1560 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1561 * s/gnu.h (DATA_START): Move definitions to configure.
1563 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1564 We include usg5-4-common.h, which defines them both.
1566 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1567 O_RDONLY already includes it).
1569 Stop ns builds setting the EMACSLOADPATH environment variable.
1570 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1571 Now it does not set EMACSLOADPATH, just returns the load-path string.
1572 * nsterm.h: Update accordingly.
1573 * lread.c [HAVE_NS]: Include nsterm.h.
1574 (init_lread) [HAVE_NS]: Use ns_load_path.
1575 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1577 2012-07-09 Glenn Morris <rgm@gnu.org>
1579 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1580 since the included bsd-common.h does so.
1582 Stop ns builds setting the EMACSPATH environment variable.
1583 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1584 (ns_init_paths): Do not set EMACSPATH.
1585 * nsterm.h (ns_exec_path): Add it.
1586 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1589 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1591 2012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1593 * process.c (wait_reading_process_output): 'waitchannels' was unset
1594 when read_kbd || !NILP (wait_for_cell); fix this.
1596 Add GCC-style 'const' attribute to functions that can use it.
1597 * character.h (char_resolve_modifier_mask):
1598 * keyboard.h (make_ctrl_char):
1599 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1600 (init_character_once, next_almost_prime, init_fns, init_image)
1601 (flush_pending_output, init_sound):
1602 * mem-limits.h (start_of_data):
1603 * menu.h (finish_menu_items):
1604 Add ATTRIBUTE_CONST.
1605 * emacs.c (DEFINE_DUMMY_FUNCTION):
1606 Declare the dummy function with ATTRIBUTE_CONST.
1607 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1608 Add decls with ATTRIBUTE_CONST.
1610 Minor improvements to make_formatted_string.
1611 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1612 where int is good enough, as vsprintf returns an int.
1613 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1615 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1617 Use make_formatted_string to avoid double length calculation.
1618 * lisp.h (make_formatted_string): New prototype.
1619 * alloc.c (make_formatted_string): New function.
1620 * buffer.c (Fgenerate_new_buffer_name): Use it.
1621 * dbus.c (syms_of_dbusbind): Likewise.
1622 * editfns.c (Fcurrent_time_zone): Likewise.
1623 * filelock.c (get_boot_time): Likewise.
1624 * frame.c (make_terminal_frame, set_term_frame_name)
1625 (x_report_frame_params): Likewise.
1626 * image.c (gs_load): Likewise.
1627 * minibuf.c (get_minibuffer): Likewise.
1628 * msdos.c (dos_set_window_size): Likewise.
1629 * process.c (make_process): Likewise.
1630 * xdisp.c (ensure_echo_area_buffers): Likewise.
1631 * xsettings.c (apply_xft_settings): Likewise.
1633 2012-07-09 Glenn Morris <rgm@gnu.org>
1635 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1636 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1637 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1638 * nsterm.h (ns_etc_directory): Add it.
1639 * callproc.c [HAVE_NS]: Include nsterm.h.
1640 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1642 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1644 Move marker debugging code under MARKER_DEBUG.
1645 * marker.c (MARKER_DEBUG): Move marker debugging code under
1646 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1647 for bootstrap with --enable-checking (~3x slowdown reported
1648 by Juanma Barranquero <lekktu@gmail.com>).
1649 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1651 2012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1653 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1654 See <http://bugs.gnu.org/11825#29>.
1656 2012-07-08 Eli Zaretskii <eliz@gnu.org>
1658 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1659 has no font, use the frame's font. (Bug#11813)
1660 (display_line): Add commentary about displaying truncation glyphs
1662 (produce_special_glyphs): Move here from term.c.
1664 * term.c (produce_special_glyphs): Move to xdisp.c.
1666 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1669 2012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1671 * xdisp.c (display_line): Avoid warning about implicit declaration
1674 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1676 * lisp.h: Remove empty conditional.
1678 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1680 * lread.c (load_path_check): Now static.
1682 Fix some minor --with-ns problems found by static checking.
1683 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1684 (x_set_font) [!HAVE_X_WINDOWS]:
1685 * image.c (xpm_load_image) [HAVE_NS]:
1686 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1687 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1688 Remove unused local.
1689 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1690 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1691 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1692 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1693 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1694 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1695 Fix pointer signedness problem.
1696 * xfaces.c (FRAME_X_FONT_TABLE):
1697 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1699 2012-07-07 Glenn Morris <rgm@gnu.org>
1701 * lread.c (load_path_check): New function, split from init_lread.
1702 (init_lread): Reorganize. Motivation:
1703 If EMACSLOADPATH is set, check/warn about that rather than the
1704 defaults, which we are not going to use. Hence we can remove
1705 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1706 Don't warn if site-lisp directories are missing.
1707 If not installed, start from a blank load-path, since
1708 PATH_LOADSEARCH refers to the eventual installation directories.
1710 2012-07-07 Eli Zaretskii <eliz@gnu.org>
1712 Support truncation and continuation glyphs on GUI frames, when
1713 fringes are disabled. (Bug#11832)
1714 * xdisp.c (init_iterator): Get dimensions of truncation and
1715 continuation glyphs even if on GUI frames. Adjust
1716 it->last_visible_x on GUI frames when the left or right fringes,
1717 or both, are absent.
1718 (start_display, move_it_in_display_line_to): Handle the case of a
1719 GUI frame without a fringe to display continuation or truncation
1721 (insert_left_trunc_glyphs): Support GUI frames: make sure
1722 truncation glyphs overwrite enough glyphs from the current line to
1723 have sufficient space in pixels.
1724 (display_line): Support truncation and continuation glyphs on GUI
1725 frames. If some spare pixels are left on the line after inserting
1726 the truncation glyphs, fill that space with a stretch glyph of a
1727 suitably computed width.
1729 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1730 produce_glyphs, to support GUI sessions.
1732 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1734 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1736 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1738 Do not require float-time's arg to fit in time_t (Bug#11825).
1739 This works better on hosts where time_t is unsigned, and where
1740 float-time is applied to the (negative) difference between two times.
1741 * editfns.c (decode_time_components): Last arg is now double *,
1742 not int *, and means to store all the result as a double, without
1743 worrying about whether the seconds part fits in time_t.
1744 All callers changed.
1745 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1746 All callers changed.
1747 (Ffloat_time): Do not fail merely because the specified time falls
1748 outside of time_t range.
1750 2012-07-07 Glenn Morris <rgm@gnu.org>
1752 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1753 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1754 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1756 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
1758 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1759 Update dependencies.
1761 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1763 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1765 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1766 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1767 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1768 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1769 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1770 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1772 * xfont.c (compare_font_names): Redo to omit the need for casts.
1774 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1776 * xfns.c (Fx_change_window_property): Doc fix.
1777 * w32fns.c (Fx_change_window_property): Doc fix.
1779 * w32fns.c (Fx_window_property): Accept the same arguments as the
1780 X Windows version. Doc fix.
1781 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1783 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
1784 Eli Zaretskii <eliz@gnu.org>
1786 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1787 Windows-specific code from nt/config.nt moved here.
1788 Obsolete settings removed.
1790 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1792 * process.c: Avoid unnecessary calls to gettime.
1793 (wait_reading_process_output): Don't get the time of day
1794 when gobbling data immediately and not waiting, as there's no need
1795 for it in that case. This removes a FIXME.
1797 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1799 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1800 is defined (Bug#11768).
1802 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1804 Fix marker debugging code.
1805 * marker.c (byte_char_debug_check): Do not perform the check
1806 if buffer is not multibyte.
1807 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1808 Call byte_char_debug_check with correct arguments.
1810 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1812 Compile marker debugging code only if ENABLE_CHECKING is defined.
1813 * marker.c (byte_char_debug_check, count_markers):
1814 Use only if ENABLE_CHECKING is defined.
1815 (byte_debug_flag): Remove.
1816 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1817 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1819 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1821 Avoid code repetition in marker-related functions.
1822 * marker.c (attach_marker): New function.
1823 (Fset_marker, set_marker_restricted, set_marker_both)
1824 (set_marker_restricted_both): Use it.
1825 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1826 Consistently rename charno to charpos.
1827 (marker_position): Add eassert.
1828 (marker_byte_position): Convert to eassert.
1830 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1832 Simplify list operations in unchain_overlay and unchain_marker.
1833 * buffer.c (unchain_overlay): Simplify. Add comment.
1834 * marker.c (unchain_marker): Simplify. Fix comments.
1836 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1838 Introduce fast path for the widely used marker operation.
1839 * alloc.c (build_marker): New function.
1840 * lisp.h (build_marker): New prototype.
1841 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1842 * composite.c (autocmp_chars): Likewise.
1843 * editfns.c (buildmark): Remove.
1844 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1845 (save_restriction_save): Use build_marker.
1846 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1847 * window.c (save_window_save): Likewise.
1849 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1851 Do not use Fdelete_overlay in delete_all_overlays
1852 to avoid redundant calls to unchain_overlay.
1853 * buffer.c (drop_overlay): New function.
1854 (delete_all_overlays, Fdelete_overlay): Use it.
1855 * minibuf.c (get_minibuffer): Fix comment.
1857 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1859 Port to OpenBSD 5.1 amd64.
1860 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1861 This is needed for OpenBSD, and should be harmless on all BSD systems.
1862 Also, include <sys/sysctl.h>, as it should be available on all
1863 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1864 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1865 use p_pid member, not kp_proc.pid.
1867 2012-07-06 Glenn Morris <rgm@gnu.org>
1869 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1871 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1873 More xmalloc and related cleanup.
1874 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1875 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1876 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1877 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1878 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1879 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1880 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1881 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1882 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1884 Omit needless casts involving void * pointers and allocation.
1885 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1886 as the former is more robust if P's type is changed.
1887 Prefer xzalloc to xmalloc + memset 0.
1888 Simplify malloc-or-realloc to realloc.
1889 Don't worry about xmalloc returning a null pointer.
1890 Prefer xstrdup to xmalloc + strcpy.
1891 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1893 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1894 alloca of a constant.
1896 2012-07-05 Eli Zaretskii <eliz@gnu.org>
1898 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1899 hscroll is larger than the line width. Fixes long and futile
1900 looping inside extend_face_to_end_of_line (on a TTY) producing
1901 glyphs that are not needed and thrown away.
1903 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1905 * marker.c (set_marker_restricted_both): Simplify by using
1908 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1910 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1912 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1914 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1915 not defined (Bug#11768).
1916 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1917 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1918 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1919 followed by gtk_box_set_homogeneous (Bug#11768).
1920 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
1921 (update_theme_scrollbar_width, xg_create_scroll_bar):
1922 Use gtk_scrollbar_new (Bug#11768).
1923 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1924 (is_box_type): New function (Bug#11768).
1925 (xg_tool_item_stale_p): Call is_box_type.
1926 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
1927 with default display (Bug#11768).
1929 2012-07-05 Eli Zaretskii <eliz@gnu.org>
1931 * xdisp.c (window_hscroll_limited): New function.
1932 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1933 coordinates when window's hscroll is set to insanely large
1936 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
1938 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1939 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1941 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1944 * lisp.h (xzalloc): New prototype. Omit needless casts.
1945 * alloc.c (xzalloc): New function. Omit needless casts.
1946 * charset.c: Omit needless casts. Convert all calls to
1947 xmalloc with following memset to xzalloc.
1948 * dispnew.c: Likewise.
1949 * fringe.c: Likewise.
1950 * image.c: Likewise.
1951 * sound.c: Likewise.
1953 * w32fns.c: Likewise.
1954 * w32font.c: Likewise.
1955 * w32term.c: Likewise.
1956 * xfaces.c: Likewise.
1958 * xterm.c: Likewise.
1959 * atimer.c: Omit needless casts.
1960 * buffer.c: Likewise.
1961 * callproc.c: Likewise.
1963 * coding.c: Likewise.
1964 * composite.c: Likewise.
1966 * doprnt.c: Likewise.
1967 * editfns.c: Likewise.
1968 * emacs.c: Likewise.
1970 * filelock.c: Likewise.
1972 * gtkutil.c: Likewise.
1973 * keyboard.c: Likewise.
1975 * lread.c: Likewise.
1976 * minibuf.c: Likewise.
1977 * msdos.c: Likewise.
1978 * print.c: Likewise.
1979 * process.c: Likewise.
1980 * region-cache.c: Likewise.
1981 * search.c: Likewise.
1982 * sysdep.c: Likewise.
1983 * termcap.c: Likewise.
1984 * terminal.c: Likewise.
1985 * tparam.c: Likewise.
1986 * w16select.c: Likewise.
1988 * w32reg.c: Likewise.
1989 * w32select.c: Likewise.
1990 * w32uniscribe.c: Likewise.
1991 * widget.c: Likewise.
1992 * xdisp.c: Likewise.
1993 * xmenu.c: Likewise.
1995 * xselect.c: Likewise.
1997 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1999 * fileio.c (time_error_value): Check the right error number.
2000 Problem reported by Troels Nielsen in
2001 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
2003 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2005 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
2006 This should be fixed in a better way; see Eli Zaretskii in
2007 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
2008 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
2010 * fileio.c (time_error_value): Rename from special_mtime.
2011 The old name's problems were noted by Eli Zaretskii in
2012 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
2014 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
2015 This variable's comment says Emacs needs at least one GDB-visible
2016 symbol of type enum pvec_type, to work around GDB problems.
2017 The symbol's value doesn't matter.
2019 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
2020 that causes compilation to fail on pre-C99 compilers.
2022 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
2024 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
2025 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
2027 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2029 * buffer.c (init_buffer_once): Fix initialization of
2030 headers for buffer_defaults and buffer_local_symbols.
2031 Reported by Juanma Barranquero <lekktu@gmail.com>.
2033 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2035 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
2036 * lisp.h (enum pvec_type): Use fewer bits.
2037 (PSEUDOVECTOR_SIZE_BITS): New constant.
2038 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
2039 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
2040 change in pvec_type.
2041 (PSEUDOVECTOR_TYPEP): New macro.
2042 (TYPED_PSEUDOVECTORP): Use it.
2043 * fns.c (internal_equal): Adapt code to extract pvectype.
2044 * emacs.c (gdb_pvec_type): Update type.
2045 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
2046 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
2047 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
2048 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
2049 (sweep_vectors): Use it. Use local var `total_bytes' instead of
2050 abusing vector->header.next.nbytes.
2051 (live_vector_p): Use PVEC_TYPE.
2052 (mark_object): Adapt code to extract pvectype. Use switch.
2054 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2056 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
2057 Tighten new eassert a bit.
2059 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2061 Fix compilation with --enable-gcc-warnings and -O1
2063 * doprnt.c (doprnt): Change type of tem to int, initialize
2064 to avoid compiler warning. Add eassert.
2065 * search.c (simple_search): Initialize match_byte to avoid
2066 compiler warning. Add eassert.
2068 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2070 Avoid weird behavior with large horizontal scrolls.
2071 Without this change, for example, large hscroll values would
2072 mess up Emacs's display on Fedora 15 x86, presumably due to
2073 overflows in int calculations in the display code.
2074 Also, if buffers had long lines, Emacs would freeze.
2075 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
2076 (set_window_hscroll): New function, containing the old guts of
2077 Fset_window_hscroll. Return the clipped value.
2078 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
2079 This avoids the need to check against PTRDIFF_MAX.
2081 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
2083 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2085 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
2087 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2089 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
2090 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
2091 since GCC 4.4.6 issues a bogus warning for them.
2093 Fix bugs in file timestamp newness comparisons.
2094 * fileio.c (Ffile_newer_than_file_p):
2095 * lread.c (Fload): Use full timestamp resolution of files,
2096 not just the 1-second resolution, so that files that are only
2097 slightly newer still count as newer.
2098 * fileio.c (Ffile_newer_than_file_p): Don't assume file
2099 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
2101 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
2103 * fileio.c: Improve handling of file time marker. (Bug#11852)
2104 (special_mtime): New function.
2105 (Finsert_file_contents, Fverify_visited_file_modtime):
2106 Use it to set special mtime values consistently.
2108 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
2110 * fileio.c (Finsert_file_contents): Properly handle st_mtime
2111 marker for non-existing file. (Bug#11852)
2113 2012-07-03 Glenn Morris <rgm@gnu.org>
2115 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
2116 and did not make it into globals.h).
2118 2012-07-03 Tom Tromey <tromey@redhat.com>
2120 * window.c (Fset_window_margins, Fset_window_fringes)
2121 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
2122 * textprop.c (Fprevious_property_change): No longer static.
2123 * syntax.c (Fsyntax_table_p): No longer static.
2124 * process.c (Fget_process, Fprocess_datagram_address): No longer
2126 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
2127 * keyboard.c (Fcommand_execute): No longer static.
2129 * insdel.c (Fcombine_after_change_execute): No longer static.
2130 * image.c (Finit_image_library): No longer static.
2131 * fileio.c (Fmake_symbolic_link): No longer static.
2132 * eval.c (Ffetch_bytecode): No longer static.
2133 * editfns.c (Fuser_full_name): No longer static.
2134 * doc.c (Fdocumentation_property, Fsnarf_documentation):
2136 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
2138 * dired.c (Ffile_attributes): No longer static.
2139 * composite.c (Fcomposition_get_gstring): No longer static.
2140 * callproc.c (Fgetenv_internal): No longer static.
2142 * ccl.h: Remove EXFUNs.
2143 * buffer.h: Remove EXFUNs.
2144 * dispextern.h: Remove EXFUNs.
2145 * intervals.h: Remove EXFUNs.
2146 * fontset.h: Remove EXFUN.
2147 * font.h: Remove EXFUNs.
2148 * dosfns.c (system_process_attributes): Remove EXFUN.
2149 * keymap.h: Remove EXFUNs.
2150 * lisp.h: Remove EXFUNs.
2151 * w32term.h: Remove EXFUNs.
2152 * window.h: Remove EXFUNs.
2153 * xsettings.h: Remove EXFUN.
2154 * xterm.h: Remove EXFUN.
2156 2012-07-03 Glenn Morris <rgm@gnu.org>
2158 * lisp.h (Frandom): Make it visible to C.
2159 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2160 buffer for invisible buffers. (Bug#1229)
2162 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2164 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2165 values which aren't power of 2.
2166 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
2167 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
2170 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2172 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2174 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2176 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2178 * alloc.c (allocate_vector_block): Remove redundant
2179 calls to mallopt if DOUG_LEA_MALLOC is defined.
2180 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2181 avoid calls to mallopt if zero_vector is returned.
2183 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2185 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2186 is enabled, avoid dereferencing NULL current_sblock if
2189 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2191 Cleanup basic buffer management.
2192 * buffer.h (struct buffer): Change layout to use generic vector
2193 marking code. Fix some comments. Change type of 'clip_changed'
2194 to bitfield. Remove unused #ifndef old.
2195 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2196 (GET_OVERLAYS_AT): Fix indentation.
2197 (for_each_per_buffer_object_at): New macro.
2198 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2199 (Fbuffer_local_variables): Use it.
2200 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2201 * alloc.c (allocate_buffer): Adjust to match new layout of
2202 struct buffer. Fix comment.
2203 (mark_overlay): New function.
2204 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2205 Lisp area of struct buffer.
2206 (mark_object): Use it. Adjust marking of misc objects
2207 and related comments.
2209 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2211 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2212 wrapper that is not needed because the wrapped code is a no-op (zero
2213 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2214 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2216 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2218 * alloc.c (mark_buffer): Simplify. Remove prototype.
2219 (mark_object): Add comment. Reorganize marking of vector-like
2220 objects. Use CHECK_LIVE for all vector-like objects except buffers
2221 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
2222 redundant calls to mark_vectorlike for bool vectors.
2224 2012-06-30 Glenn Morris <rgm@gnu.org>
2226 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2228 * epaths.in (PATH_SITELOADSEARCH): New.
2229 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2230 This is rather than relying on --enable-locallisppath elements
2231 having "site-lisp" in their names. (Bug#10208#25, 11658)
2233 2012-06-30 Eli Zaretskii <eliz@gnu.org>
2235 * w32proc.c (sys_select): Accept and ignore one more argument.
2237 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2239 * sysselect.h [DOS_NT]: Don't include sys/select.h.
2240 (pselect) [!MS_DOS]: Redirect to sys_select.
2242 * sysdep.c: Don't include dos.h and dosfns.h.
2244 * process.c (sys_select):
2245 * msdos.c (sys_select): Accept one more argument and ignore it.
2247 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2248 adapt data types and code to that.
2251 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2252 which clashes with the gnulib function of the same name.
2254 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2256 * font.c (font_style_to_value, font_style_symbolic)
2257 (font_prop_validate_style): Add type checks for values in
2260 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2262 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2265 2012-06-29 Eli Zaretskii <eliz@gnu.org>
2267 * xdisp.c (try_window_id): Undo last change.
2269 * w32.c (getwd): Adjust commentary about startup_dir.
2270 (init_environment): Always call sys_access, even in non-MSVC
2271 builds. Don't chdir to the directory of the Emacs executable.
2272 This undoes code from 1997 which was justified by the need to
2273 "avoid conflicts when removing and renaming directories". But its
2274 downside was that every relative file name was being interpreted
2275 relative to the directory of the Emacs executable, which can never
2276 be TRT. In particular, it broke sys_access when called with
2277 relative file names.
2278 (sys_access): Map GetLastError to errno.
2280 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2282 * window.h (struct window): Change type of 'fringes_outside_margins'
2283 to bitfield. Fix comment. Adjust users accordingly.
2284 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2286 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2289 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
2291 * gnutls.c (emacs_gnutls_handshake):
2292 Add QUIT to make the loop interruptible.
2294 2012-06-29 Glenn Morris <rgm@gnu.org>
2296 * charset.c (init_charset): Make lack of etc/charsets fatal.
2298 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2300 * editfns.c (region_limit): Fix type mismatch.
2302 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2304 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2305 undefined. Convert from xassert to eassert.
2306 * nsmenu.m: Convert from xassert to eassert.
2307 * nsterm.m: Likewise.
2309 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2311 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2313 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2315 Avoid integer overflow on scroll-left and scroll-right.
2316 * window.c (HSCROLL_MAX): New macro.
2317 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2318 overflow when requested scroll falls outside ptrdiff_t range.
2320 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2322 * window.h (struct window): Change type of 'hscroll',
2323 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2324 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2325 Adjust users accordingly.
2326 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2327 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2328 from EMACS_INT to ptrdiff_t.
2329 (make_window): Omit redundant initialization.
2331 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
2333 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2335 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2337 * window.h (struct window): Change type of 'use_time' and
2338 'sequence_number' from Lisp_Object to int.
2339 * frame.c (make_frame): Adjust users accordingly.
2340 * print.c (print_object): Likewise.
2341 * window.c (select_window, Fwindow_use_time, make_parent_window)
2342 (make_window): Likewise.
2344 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2346 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2347 enabled with --enable-checking=[all,glyphs] configure option.
2348 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2349 adjust comments accordingly.
2350 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2351 undefined, adjust comments accordingly.
2352 * image.c: Likewise.
2353 * scroll.c: Likewise.
2354 * w32fns.c: Likewise.
2355 * w32term.c: Likewise.
2356 * xdisp.c: Likewise.
2357 * xfaces.c: Likewise.
2359 * xterm.c: Likewise.
2361 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2363 Generalize run-time debugging checks.
2364 * dispextern.h (XASSERTS): Remove.
2365 * fontset.c (xassert): Remove.
2366 Convert from xassert to eassert.
2367 * alloc.c: Convert from xassert to eassert.
2369 * dispnew.c: Likewise.
2371 * fringe.c: Likewise.
2372 * ftfont.c: Likewise.
2373 * gtkutil.c: Likewise.
2374 * image.c: Likewise.
2375 * keyboard.c: Likewise.
2377 * process.c: Likewise.
2378 * scroll.c: Likewise.
2379 * sound.c: Likewise.
2381 * w32console.c: Likewise.
2382 * w32fns.c: Likewise.
2383 * w32term.c: Likewise.
2384 * window.c: Likewise.
2385 * xdisp.c: Likewise.
2386 * xfaces.c: Likewise.
2388 * xselect.c: Likewise.
2389 * xterm.c: Likewise.
2391 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2393 * fns.c (maybe_resize_hash_table): Output message when growing the
2396 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2398 * alloc.c (allocate_string_data): Remove dead code.
2399 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2400 avoid GCC warning about unused macro.
2402 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2404 * alloc.c (allocate_string): Omit intervals initialization.
2405 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2406 as in make_pure_string and make_pure_c_string.
2408 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2410 * alloc.c (allocate_string): Fix last change.
2412 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2414 * alloc.c (allocate_string): Remove two redundant calls
2415 to memset, add explicit initialization where appropriate.
2417 2012-06-27 Glenn Morris <rgm@gnu.org>
2419 * lisp.mk (lisp): Remove paths.elc.
2421 2012-06-27 Chong Yidong <cyd@gnu.org>
2423 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2425 2012-06-26 John Wiegley <johnw@newartisans.com>
2427 * unexmacosx.c (copy_data_segment): Add two section names used
2428 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2430 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2431 when building with Clang.
2433 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2435 * eval.c (Fapply): Allow calling it with a single argument.
2437 2012-06-26 Eli Zaretskii <eliz@gnu.org>
2439 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2440 _stricmp and _strnicmp.
2441 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2443 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2445 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2447 (allocate_process): Likewise for new process.
2448 (allocate_terminal): Change to use offsetof.
2449 (allocate_frame): Likewise.
2450 * frame.c (make_frame): Omit redundant initialization.
2451 * window.c (make_parent_window): Use memset.
2452 (make_window): Omit redundant initialization.
2453 * process.c (make_process): Omit redundant initialization.
2454 * terminal.c (create_terminal): Likewise.
2456 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2458 * term.c (delete_tty): Remove redundant call to memset.
2460 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2462 * alloc.c: Remove build_string.
2463 * lisp.h: Define build_string as static inline. This provides
2464 a better opportunity to optimize away calls to strlen when the
2465 function is called with compile-time constant argument.
2466 * image.c (imagemagick_error): Convert to build_string.
2467 * w32proc.c (sys_spawnve): Likewise.
2468 * xterm.c (x_term_init): Likewise.
2470 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2472 Use sprintf return value instead of invoking strlen on result.
2473 In the old days this wasn't portable, since some sprintf
2474 implementations returned char *. But they died out years ago and
2475 Emacs already assumes sprintf returns int.
2476 Similarly for float_to_string.
2477 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2478 * ccl.c (ccl_driver):
2479 * character.c (string_escape_byte8):
2480 * data.c (Fnumber_to_string):
2481 * doprnt.c (doprnt):
2482 * print.c (print_object):
2483 * xdisp.c (message_dolog):
2484 * xfns.c (syms_of_xfns):
2485 Use sprintf or float_to_string result to avoid need to call strlen.
2486 * data.c (Fnumber_to_string):
2487 Use make_unibyte_string, since the string must be ASCII.
2488 * lisp.h, print.c (float_to_string): Now returns int length.
2489 * term.c (produce_glyphless_glyph):
2490 Use sprintf result rather than recomputing it.
2492 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2493 * Makefile.in (ALL_CFLAGS):
2494 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2495 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2497 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2499 * dispextern.h (xstrcasecmp): Define to library function
2500 strcasecmp if available.
2501 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2503 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2505 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2506 Avoid comma operator.
2507 * menu.c (push_submenu_start, push_submenu_end)
2508 (push_left_right_boundary, push_menu_pane): Likewise.
2509 * msdos.c (dos_rawgetc): Likewise.
2511 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2513 * xfns.c (xic_create_fontsetname): Remove redundant calls
2516 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2518 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2519 sprintf already null-terminates its output.
2521 * xfns.c (x_window): Remove redundant cast.
2523 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2525 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2526 `const char *' to `char *' to avoid compiler warning.
2528 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2530 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2531 instead of truncating it to 63 (admittedly a generous limit).
2533 * process.c: Fix spelling and caps in comments.
2535 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2537 * emacs.c (setpgrp): Remove definition, unused.
2538 * sysdep.c (setpgrp): Remove definition, not used in this file.
2540 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
2542 * makefile.w32-in: Update dependencies.
2544 2012-06-24 Eli Zaretskii <eliz@gnu.org>
2546 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2547 (SYSTIME_H): Add nt/inc/sys/time.h.
2549 * systime.h [WINDOWSNT]: Include sys/time.h.
2551 * s/ms-w32.h (struct timespec): Definition moved from
2552 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2554 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2556 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2557 * buffer.h (buffer_slot_type_mismatch):
2558 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2559 * eval.c (unwind_to_catch):
2560 * image.c (my_png_error, my_error_exit):
2561 * keyboard.c (quit_throw_to_read_char, user_error)
2562 (Fexit_recursive_edit, Fabort_recursive_edit):
2563 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2564 (wrong_type_argument, buffer_overflow, __executable_start)
2565 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2566 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2567 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2569 (child_setup) [!DOS_NT]:
2570 * lread.c (end_of_file_error, invalid_syntax):
2571 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2572 * puresize.h (pure_write_error):
2573 * search.c (matcher_overflow):
2574 * sound.c (sound_perror, alsa_sound_perror):
2575 * sysdep.c, syssignal.h (croak):
2576 * term.c (maybe_fatal, vfatal):
2577 * textprop.c (text_read_only):
2578 * undo.c (user_error):
2579 * unexmacosx.c (unexec_error):
2580 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2581 Use _Noreturn rather than NO_RETURN.
2582 No need for separate decl merely because of _Noreturn.
2583 * sound.c (sound_warning, parse_sound):
2584 Remove unnecessary forward decls.
2586 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2588 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2589 * lisp.h (WAIT_READING_MAX): New macro.
2590 * dispnew.c (Fsleep_for, sit_for):
2591 * keyboard.c (kbd_buffer_get_event):
2592 * process.c (Faccept_process_output):
2593 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2594 This improves on the previous patch, which introduced a bug
2595 when time_t is unsigned and as wide as intmax_t.
2596 See <http://bugs.gnu.org/9000#51>.
2598 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2600 * dispnew.c (sit_for, Fsleep_for):
2601 * keyboard.c (kbd_buffer_get_event):
2602 * process.c (Faccept_process_output): Avoid compiler warnings when
2603 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2605 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
2607 * makefile.w32-in: Update dependencies.
2609 * w32.c (ltime): Add return type and declare static.
2610 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2612 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2614 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2615 Privately reported by Herbert J. Skuhra.
2616 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2618 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2619 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2621 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2623 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2624 last argument of make_unibyte_string.
2626 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2627 language ID in the event parameters.
2629 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2630 event.code, not the obscure "character set ID".
2632 2012-06-23 Chong Yidong <cyd@gnu.org>
2634 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2636 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2638 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2639 * w32.c (fdutimens): New function.
2641 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2643 * s/ms-w32.h (pselect): Redirect to sys_select.
2645 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2647 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2648 in the logic of incrementing and decrementing the value of
2649 use_relocatable_buffers.
2651 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2653 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2654 Privately reported by Herbert J. Skuhra.
2655 [__FreeBSD__]: Remove "*/" typo after "#include".
2656 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2657 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2658 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2659 Don't assume EMACS_TIME and struct timeval are the same type.
2661 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2663 Support higher-resolution time stamps (Bug#9000).
2664 The time stamps are only nanosecond-resolution at the C level,
2665 since that's the best that any real-world system supports now.
2666 But they are picosecond-resolution at the Lisp level, as that's
2667 easy, and leaves room for future OS improvements.
2669 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2672 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2673 Don't get current time unless it's needed.
2675 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2676 now provides it if it's absent.
2677 (start_atimer): Port to higher-res time stamps.
2678 Check for time stamp overflow. Don't get current time more
2679 often than is needed.
2681 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2682 Include systime.h, not time.h.
2683 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2685 * dired.c: Include stat-time.h.
2686 (Ffile-attributes): File times now have higher resolution.
2688 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2689 (struct image): Timestamp now has higher resolution.
2691 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2692 has at least microseconds now. All uses removed.
2693 (update_frame, update_single_window, update_window, update_frame_1)
2694 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2696 * editfns.c (time_overflow): Now extern.
2697 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2698 (float-time, Fformat_time_string, Fcurrent_time_string)
2699 (Fcurrent_time_zone): Accept and generate higher-resolution
2701 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2702 (decode_time_components, lisp_seconds_argument): New functions.
2703 (make_time): Now static.
2704 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2705 Report an error if the time is invalid, rather than having the caller
2708 * fileio.c: Include <stat-time.h>
2709 (Fcopy_file): Copy higher-resolution time stamps.
2710 Prefer to set the time stamp via a file descriptor if that works.
2711 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2712 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2713 (Fvisited_file_modtime, Fset_visited_file_modtime):
2714 Support higher-resolution time stamps.
2716 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2718 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2720 * image.c (prepare_image_for_display, clear_image_cache)
2721 (lookup_image): Port to higer-resolution time stamps.
2723 * keyboard.c (start_polling, bind_polling_period):
2724 Check for time stamp overflow.
2725 (read_char, kbd_buffer_get_event, timer_start_idle)
2726 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2727 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2728 Port to higher-resolution time stamps. Do not assume time_t is signed.
2729 (decode_timer): New function. Timers are now vectors of length 9,
2730 not 8, to accommodate the picosecond component.
2731 (timer_check_2): Use it.
2733 * nsterm.m (select_timeout, timeval_subtract): Remove.
2734 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2735 as they're a bit more accurate and handle overflow better.
2736 (ns_select): Change prototype to be compatible with pselect.
2737 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2738 * nsterm.h (ns_select): Adjust prototype.
2740 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2741 us-resolution time stamps.
2742 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2744 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2746 * lisp.h (time_overflow): New decl.
2747 (wait_reading_process_output): First arg is now intmax_t, not int,
2748 to accommodate larger waits.
2750 * process.h (struct Lisp_Process.read_output_delay):
2751 Now counts nanoseconds, not microseconds.
2752 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2754 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2755 (wait_reading_process_output):
2756 Port to ns-resolution time stamps.
2757 (Faccept_process_output, wait_reading_process_output):
2758 Check for time stamp overflow. Do not assume time_t is signed.
2759 (select_wrapper): Remove; we now use pselect.
2760 (Fprocess_attributes): Now generates ns-resolution time stamps.
2762 * sysdep.c: Include utimens.h. Don't include utime.h
2763 or worry about struct utimbuf; gnulib does that for us now.
2764 (gettimeofday): Remove; gnulib provides a substitute.
2765 (make_timeval): New function.
2766 (set_file_times): Now sets ns-resolution time stamps.
2767 New arg FD; all uses changed.
2768 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2769 (system_process_attributes):
2770 Now returns ns-resolution time stamp. All uses changed.
2771 Check for time stamp overflow.
2773 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2774 provides a substitute now.
2776 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2777 since it guarantees struct timespec.
2778 (EMACS_TIME): Now struct timespec, so that we can support
2779 ns-resolution time stamps.
2780 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2781 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2782 (EMACS_USECS): Remove.
2783 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2784 so multiply the arg by 1000 before storing it.
2785 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2787 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2788 Port to ns-resolution time stamps.
2789 (EMACS_TIME_NEG_P): Remove; replaced by....
2790 (EMACS_TIME_SIGN): New macro.
2791 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2792 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2793 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2794 (make_timeval, make_lisp_time, decode_time_components): New decls.
2795 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2796 that it mishandled time_t overflow. You can't compare by subtracting!
2797 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2798 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2800 * term.c: Include <sys/time.h>.
2801 (timeval_to_Time): New function, for proper overflow wraparound.
2802 (term_mouse_position, term_mouse_click): Use it.
2804 * undo.c (record_first_change): Support higher-resolution time stamps
2806 (Fprimitive_undo): Use them when restoring time stamps.
2808 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2809 (w32_get_internal_run_time):
2810 Port to higher-resolution Emacs time stamps.
2811 (ltime): Now accepts single 64-bit integer, as that's more convenient
2814 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2816 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2817 for compatibility with pselect. Support ns-resolution time stamps.
2819 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2821 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2822 Check for time stamp overflow, and support ns-resolution time stamps.
2824 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2825 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2826 (timeval_subtract): Remove; no longer needed.
2827 (XTflash, XTring_bell, x_wait_for_event):
2828 Port to ns-resolution time stamps. Don't assume time_t is signed.
2830 2012-06-22 Chong Yidong <cyd@gnu.org>
2832 * xdisp.c (x_consider_frame_title): Revert last change.
2834 2012-06-22 Eli Zaretskii <eliz@gnu.org>
2836 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2837 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2838 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2839 staticidx goes up to 1597 out of 1600 = 0x640.)
2841 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2843 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2844 Otherwise, the umask might be mistakenly 0 while handling input signals.
2846 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2848 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2850 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2852 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2853 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2854 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2855 access to `contents' member of Lisp_Vector objects with AREF and ASET
2858 2012-06-19 Chong Yidong <cyd@gnu.org>
2860 * frame.c (delete_frame): When selecting a frame on a different
2861 text terminal, do not alter the terminal's top-frame.
2863 * xdisp.c (format_mode_line_unwind_data): Record the target
2864 frame's selected window and its terminal's top-frame.
2865 (unwind_format_mode_line): Restore them.
2866 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2868 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2869 since tty frames can be explicitly named.
2870 (prepare_menu_bars): Likewise.
2872 * term.c (Ftty_top_frame): New function.
2874 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2876 Port byte-code-meter to modern targets.
2877 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2878 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
2879 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
2880 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2881 (METER_1, METER_2): Simplify.
2883 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2885 * data.c (Fdefalias): Return `symbol' (bug#11686).
2887 2012-06-18 Martin Rudalics <rudalics@gmx.at>
2889 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
2890 gets killed during executing of this function (Bug#11665).
2891 Try to always return Qt when the buffer has been actually killed.
2892 (Vkill_buffer_query_functions): In doc-string say that functions
2893 run by this hook should not change the current buffer.
2895 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2897 Fix recently-introduced process.c problems found by static checking.
2898 * process.c (write_queue_push, write_queue_pop, send_process):
2899 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2900 (write_queue_pop): Fix pointer signedness problem.
2901 (send_process): Remove unused local.
2903 2012-06-17 Chong Yidong <cyd@gnu.org>
2905 * xdisp.c (redisplay_internal): No need to redisplay terminal
2906 frames that are not on top.
2908 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
2910 * process.c (make_process): Initialize write_queue.
2911 (write_queue_push, write_queue_pop): New functions.
2912 (send_process): Use them to maintain correct ordering of process
2915 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2917 * lisp.h (eassert): Assume C89 or later.
2918 This removes the need for CHECK.
2919 (CHECK): Remove. Its comments about always evaluating its
2920 argument were confusing, as 'eassert' typically does not evaluate
2923 * coding.c (produce_chars): Use ptrdiff_t, not int.
2925 * xterm.c (x_draw_underwave): Check for integer overflow.
2926 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2928 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
2930 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2931 referenced (Bug#11583).
2933 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2935 Implement wave-style variant of underlining.
2936 * dispextern.h (face_underline_type): New enum.
2937 (face): Add field for underline type.
2938 * nsterm.m (ns_draw_underwave): New function.
2939 (ns_draw_text_decoration): Use it.
2940 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2942 (x_draw_glyph_string): Use them.
2943 * xfaces.c (Qline, Qwave): New Lisp objects.
2944 (check_lface_attrs, merge_face_ref)
2945 (Finternal_set_lisp_face_attribute, realize_x_face):
2946 Handle wave-style underline face attributes.
2947 * xterm.c (x_draw_underwave): New function.
2948 (x_draw_glyph_string): Use it.
2950 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
2952 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2953 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2954 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2955 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2956 ($(BLD)/w32select.$(O)): Update dependencies.
2958 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2960 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2961 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2962 * character.c (_fetch_multibyte_char_p): Remove.
2963 * alloc.c: Include "character.h" before "buffer.h".
2965 * buffer.c: Likewise.
2966 * bytecode.c: Likewise.
2967 * callint.c: Likewise.
2968 * callproc.c: Likewise.
2969 * casefiddle.c: Likewise.
2970 * casetab.c: Likewise.
2971 * category.c: Likewise.
2973 * coding.c: Likewise.
2974 * composite.c: Likewise.
2975 * dired.c: Likewise.
2976 * dispnew.c: Likewise.
2978 * dosfns.c: Likewise.
2979 * editfns.c: Likewise.
2980 * emacs.c: Likewise.
2981 * fileio.c: Likewise.
2982 * filelock.c: Likewise.
2984 * fontset.c: Likewise.
2985 * fringe.c: Likewise.
2986 * indent.c: Likewise.
2987 * insdel.c: Likewise.
2988 * intervals.c: Likewise.
2989 * keyboard.c: Likewise.
2990 * keymap.c: Likewise.
2991 * lread.c: Likewise.
2992 * macros.c: Likewise.
2993 * marker.c: Likewise.
2994 * minibuf.c: Likewise.
2995 * nsfns.m: Likewise.
2996 * nsmenu.m: Likewise.
2997 * print.c: Likewise.
2998 * process.c: Likewise.
2999 * regex.c: Likewise.
3000 * region-cache.c: Likewise.
3001 * search.c: Likewise.
3002 * syntax.c: Likewise.
3004 * textprop.c: Likewise.
3006 * unexsol.c: Likewise.
3007 * w16select.c: Likewise.
3008 * w32fns.c: Likewise.
3009 * w32menu.c: Likewise.
3010 * window.c: Likewise.
3011 * xdisp.c: Likewise.
3013 * xmenu.c: Likewise.
3015 * xselect.c: Likewise.
3017 2012-06-16 Eli Zaretskii <eliz@gnu.org>
3019 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
3020 If all the glyphs of the glyph row came from strings, and we have no
3021 cursor positioning clues, put the cursor on the first glyph of the
3023 (handle_face_prop): Use chunk-relative overlay string index when
3024 indexing into it->string_overlays array. (Bug#11653)
3025 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
3026 the rightmost. (Bug#11720)
3028 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3030 * category.h (CHAR_HAS_CATEGORY): Define as inline.
3031 (CATEGORY_MEMBER): Enforce 1/0 value.
3032 * category.c (_temp_category_set): Remove.
3034 2012-06-16 Eli Zaretskii <eliz@gnu.org>
3036 * window.c (Fdelete_other_windows_internal)
3037 (Fdelete_window_internal): Don't access frame's mouse highlight
3038 info of the initial frame. (Bug#11677)
3040 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
3042 * .gdbinit (xgetint): Fix recently-introduced paren typo.
3043 Assume USE_2_TAGS_FOR_INTS.
3044 (xreload): Adjust $tagmask width to match recent lisp.h change.
3046 Simplify lisp.h in minor ways that should not affect code.
3047 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
3048 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
3049 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
3050 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
3051 (INTTYPEBITS): New macro, for clarity.
3052 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
3053 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
3054 Simplify now that USE_LSB_TAG is always defined.
3055 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
3056 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
3058 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
3060 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
3062 2012-06-13 Glenn Morris <rgm@gnu.org>
3064 * s/bsd-common.h (BSD4_3):
3065 * s/usg5-4-common.h (USG5_4): No longer define; unused.
3067 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
3069 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
3072 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
3074 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
3075 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
3076 * alloc.c (widen_to_Lisp_Object): Remove.
3077 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
3078 * frame.c (delete_frame): Remove outdated comment.
3079 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
3080 USE_LISP_UNION_TYPE.
3081 (Fw32_unregister_hot_key): Likewise.
3082 (Fw32_toggle_lock_key): Likewise.
3083 * w32menu.c (add_menu_item): Likewise.
3084 (w32_menu_display_help): Use XIL instead of checking
3085 USE_LISP_UNION_TYPE.
3086 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
3087 (init_heap): Likewise.
3088 * w32term.c (w32_read_socket): Update comment.
3090 2012-06-13 Glenn Morris <rgm@gnu.org>
3092 * s/usg5-4-common.h, src/s/unixware.h:
3093 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
3095 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
3097 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
3099 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
3100 * alloc.c (make_number) [!defined make_number]:
3101 Remove, as lisp.h always defines this now.
3102 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
3103 (roundup_size): Verify that it is a power of 2.
3104 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
3105 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
3106 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
3107 -DUSE_LSB_TAG=0, to override the automatically-selected default.
3108 USE_LSB_TAG now is always defined to be either 0 or 1.
3110 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
3111 code works fine either way, and efficiency is not a concern here,
3112 as the union type is for debugging, not for production.
3113 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
3114 Use an inline function on all platforms when using the union type,
3115 since this is simpler and 'static inline' can be used portably
3117 (LISP_INITIALLY_ZERO): New macro.
3118 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
3119 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
3121 2012-06-12 Glenn Morris <rgm@gnu.org>
3123 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
3125 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
3127 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
3128 Move BROKEN_SIGIO to configure.
3130 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
3131 Move NO_TERMIO to configure.
3133 2012-06-12 Chong Yidong <cyd@gnu.org>
3135 * image.c (imagemagick_load_image): Use MagickFlattenImage if
3136 MagickMergeImageLayers is undefined. Use pixel pusher loop if
3137 MagickExportImagePixels is undefined.
3139 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3141 * image.c (imagemagick_load_image): Remove unused label.
3143 2012-06-11 Glenn Morris <rgm@gnu.org>
3145 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3146 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3147 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3148 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3150 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3152 * alloc.c (make_byte_code): New function.
3153 (Fmake_byte_code): Use it. Don't purify here.
3154 * lread.c (read1): Use it as well to avoid extra allocation.
3156 2012-06-11 Chong Yidong <cyd@gnu.org>
3158 * image.c (imagemagick_load_image): Implement transparency.
3160 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3162 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3163 account for preceding backslashes. (Bug#11663)
3165 2012-06-09 Chong Yidong <cyd@gnu.org>
3167 * term.c: Support italics in capable terminals (Bug#9652).
3168 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3169 (turn_on_face): Output using TS_enter_italic_mode if available.
3170 Don't handle unused blinking and alt-charset cases.
3171 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3172 and tty_alt_charset_p cases.
3173 (tty_capable_p, init_tty): Support italics.
3175 * termchar.h (struct tty_display_info): Add field for italics.
3176 Remove unused blink field.
3178 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3181 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3182 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3183 tty_alt_charset_p. Add tty_italic_p.
3185 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
3187 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3188 dbus_type_is_basic if available.
3189 (xd_extract_signed, xd_extract_unsigned): Rename from
3190 extract_signed and extract_unsigned, respectively. Adapt callers.
3192 2012-06-09 Chong Yidong <cyd@gnu.org>
3194 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3196 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3199 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3201 * xdisp.c (vmessage): Treat frame message as multibyte.
3202 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3203 would generate the diagnostic "Making \302\247 buffer-local while
3206 2012-06-08 Eli Zaretskii <eliz@gnu.org>
3208 * dispnew.c (showing_window_margins_p): Undo last change, which
3209 was done due to an inadvertent commit.
3210 (adjust_frame_glyphs_for_frame_redisplay): Do call
3211 showing_window_margins_p.
3213 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3215 * eval.c (Fmake_var_non_special): New primitive.
3216 (syms_of_eval): Defsubr it.
3217 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3219 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
3221 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3222 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3224 2012-06-08 Eli Zaretskii <eliz@gnu.org>
3226 * alloc.c (allocate_vectorlike): Fix last change.
3228 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3230 Block-based vector allocation of small vectors.
3231 * lisp.h (struct vectorlike_header): New field `nbytes',
3232 adjust comment accordingly.
3233 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3234 to denote vector blocks. Adjust users (live_vector_p,
3235 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3236 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3237 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3238 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3239 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3240 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3241 (roundup_size): New constant.
3242 (struct vector_block): New data type.
3243 (vector_blocks, vector_free_lists, zero_vector): New variables.
3244 (all_vectors): Rename to `large_vectors'.
3245 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3246 (sweep_vectors): New functions.
3247 (allocate_vectorlike): Return `zero_vector' as the only vector of
3248 0 items. Allocate new vector from block if vector size is less than
3249 or equal to VBLOCK_BYTES_MAX.
3250 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3251 (init_alloc_once): Add call to init_vectors.
3253 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3255 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3257 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3259 * doprnt.c (doprnt): Truncate multibyte char correctly.
3260 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3261 would mishandle a string argument "Xc" if X was a multibyte
3262 character of length 2: it would truncate after X's first byte
3263 rather than including all of X.
3265 2012-06-06 Chong Yidong <cyd@gnu.org>
3267 * buffer.c (word_wrap): Doc fix.
3269 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3271 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3273 2012-06-03 Glenn Morris <rgm@gnu.org>
3275 * xdisp.c (tool-bar-style): Doc fix.
3277 2012-06-03 Ulrich Müller <ulm@gentoo.org>
3279 * Makefile.in (PAXCTL): Define.
3280 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3281 binary via PaX flags if the paxctl utility is available.
3282 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3283 Restore PaX flags to their default. (Bug#11398)
3285 2012-06-03 Chong Yidong <cyd@gnu.org>
3287 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3290 2012-06-03 Chong Yidong <cyd@gnu.org>
3292 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3293 (note_mode_line_or_margin_highlight): If there is no help echo,
3294 use mode-line-default-help-echo. Handle the case where the mouse
3295 position is past the end of the mode line string.
3297 * buffer.c (buffer_local_value_1): New function, split from
3298 Fbuffer_local_value; can return Qunbound.
3299 (Fbuffer_local_value): Use it.
3300 (Vmode_line_format): Docstring tweaks.
3302 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3304 * sysdep.c (system_process_attributes): Improve comment.
3306 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3308 * keyboard.c: Export real-this-command to Elisp.
3309 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3310 and DEFVAR it. Update all users.
3312 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3314 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3316 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3317 Convert pctcpu and pctmem to Lisp float properly.
3318 Let the compiler fold better, as 100.0/0x8000 is exact.
3320 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3322 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3325 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3327 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3329 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3331 For a 'struct window', replace some Lisp_Object fields to
3332 bitfields where appropriate, remove unused fields.
3333 * window.h (struct window): Remove unused 'last_mark_x' and
3334 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3335 change it's type from Lisp_Object to bitfield.
3336 Change type of 'force_start', 'optional_new_start',
3337 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3338 fields from Lisp_Object to bitfield. Adjust users accordingly.
3340 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3342 Pacify gcc -Wdouble-precision when using Xaw.
3343 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3344 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3345 Use 'float' consistently, rather than 'float' in most places
3346 and 'double' in a couple of places.
3348 2012-05-31 Eli Zaretskii <eliz@gnu.org>
3350 * xdisp.c (handle_stop): Detect whether we have overlay strings
3351 loaded by testing it->current.overlay_string_index to be
3352 non-negative, instead of checking whether n_overlay_strings is
3353 positive. (Bug#11587)
3355 2012-05-31 Chong Yidong <cyd@gnu.org>
3357 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3359 * doc.c (Fsubstitute_command_keys): Doc fix.
3361 2012-05-31 Eli Zaretskii <eliz@gnu.org>
3363 * search.c (search_buffer): Remove calls to
3364 r_alloc_inhibit_buffer_relocation, as it is now called by
3365 maybe_unify_char, which was the cause of relocation of buffer text
3368 2012-05-31 Eli Zaretskii <eliz@gnu.org>
3370 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3371 for the duration of call to load_charset, to avoid problems with
3372 callers of maybe_unify_char that access buffer text through C
3375 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3376 decrement the inhibition flag, instead of just setting or
3379 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3381 Remove obsolete '#define static' cruft.
3382 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3383 This #undef was "temporary" in 2000; it is no longer needed
3384 now that '#define static' has gone away.
3385 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3386 (gray_bitmap_bits): Remove; no longer needed.
3387 All uses replaced with definiens.
3388 * xterm.c: Include "bitmaps/gray.xbm".
3390 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3392 Clean up __executable_start, monstartup when --enable-profiling.
3393 The following changes affect the code only when profiling.
3394 * dispnew.c (__executable_start): Rename from safe_bcopy.
3395 Define only on platforms that need it.
3396 * emacs.c: Include <sys/gmon.h> when profiling.
3397 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3398 (__executable_start): Remove decl, since lisp.h does it now.
3399 (safe_bcopy): Remove decl; no longer has that name.
3400 (main): Coalesce #if into single bit of code, for simplicity.
3401 Cast pointers to uintptr_t, since standard libraries want integers
3403 * lisp.h (__executable_start): New decl.
3405 2012-05-31 Glenn Morris <rgm@gnu.org>
3407 * image.c (Fimagemagick_types): Doc fix.
3409 2012-05-30 Jim Meyering <meyering@redhat.com>
3411 * callproc.c (Fcall_process_region): Include directory component
3412 in mkstemp error message (Bug#11586).
3414 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3416 * alloc.c, lisp.h (make_pure_vector): Now static.
3418 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3420 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3421 Move to byte-run.el.
3422 (Fautoload): Do the hash-doc more carefully.
3423 * data.c (Fdefalias): Purify definition, except for keymaps.
3424 (Qdefun): Move from eval.c.
3425 * lisp.h (Qdefun): Remove.
3426 * lread.c (read1): Tiny simplification.
3428 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
3430 Do not create empty overlays with the evaporate property (Bug#9642).
3431 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3432 Bug#9642, but explicitly check that the buffer the overlay would
3433 be moved to is live and rearrange lines to make sure that errors
3434 will not put the overlay in an inconsistent state.
3435 (Fdelete_overlay): Cosmetics.
3437 2012-05-28 Eli Zaretskii <eliz@gnu.org>
3439 * w32term.c (my_bring_window_to_top): New function.
3440 (x_raise_frame): Use handle returned by DeferWindowPos, which
3441 could be different from the original one.
3442 Call my_bring_window_to_top instead of my_set_foreground_window.
3445 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3446 by calling BringWindowToTop.
3448 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3449 (WM_EMACS_END): Increase by one.
3451 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3453 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3454 This avoids undefined behavior that might cause the eassert
3455 to not catch an out-of-range value.
3457 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
3459 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3460 Update dependencies.
3462 2012-05-27 Eli Zaretskii <eliz@gnu.org>
3464 * bidi.c (bidi_mirror_char): Fix last change.
3466 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3468 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3469 when referring to sectname field in printf format.
3471 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3473 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3474 Only r_alloc_inhibit_buffer_relocation needed to be added;
3475 the others were already declared.
3477 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3478 before checking whether it's out of range. Put the check inside
3480 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3482 2012-05-27 Ken Brown <kbrown@cornell.edu>
3484 * callproc.c (Fcall_process): Restore a line that was accidentally
3485 commented out in the 2011-02-13 change (bug#11547).
3487 2012-05-27 Eli Zaretskii <eliz@gnu.org>
3489 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3490 defined on ralloc.c.
3492 * buffer.c [REL_ALLOC]: Remove prototypes of
3493 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3494 they are now on lisp.h.
3496 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3498 * search.c (search_buffer): Use it to inhibit relocation of buffer
3499 text while re_search_2 is doing its job, because re_search_2 is
3500 passed C pointers to buffer text. (Bug#11519)
3502 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3505 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3506 state after an additional call to move_it_in_display_line_to, keep
3507 the values of it->max_ascent and it->max_descent found for the
3509 (pos_visible_p): Revert the comparison against bottom_y to what it
3510 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3513 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3515 Fix coding-related core dumps with gcc -ftrapv.
3516 The code was computing A - B, where A and B are pointers, and B is
3517 random garbage. This can lead to core dumps on platforms that
3518 have special pointer registers, and it also leads to core dumps on
3519 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3520 A - B only when B is initialized properly.
3521 * coding.c (coding_set_source, coding_set_destination): Return void.
3522 (coding_change_source, coding_change_destinations): New functions,
3523 with the old behaviors of coding_set_source and coding_set_destination.
3524 All callers that need an offset changed to use these new functions.
3526 2012-05-26 Glenn Morris <rgm@gnu.org>
3528 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3530 2012-05-26 Eli Zaretskii <eliz@gnu.org>
3532 Extend mouse support on W32 text-mode console.
3533 * xdisp.c (draw_row_with_mouse_face):
3534 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
3536 * w32console.c: Include window.h.
3537 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3539 (initialize_w32_display): Initialize mouse-highlight data.
3541 * w32inevt.c: Include termchar.h and window.h.
3542 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3543 moves, call note_mouse_highlight. If help_echo changed, call
3544 gen_help_event to produce help-echo message in the echo area.
3545 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3548 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3550 * lread.c (read1): Simplify slightly to avoid an overflow warning
3551 with GCC 4.7.0 on x86-64.
3553 2012-05-26 Eli Zaretskii <eliz@gnu.org>
3555 * bidi.c (bidi_mirror_char): Revert last change: an int is
3556 definitely wide enough here.
3558 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3560 Fix integer width and related bugs (Bug#9874).
3561 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
3562 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3563 (string_bytes, check_sblock, allocate_string_data):
3564 (compact_small_strings, Fmake_bool_vector, make_string)
3565 (make_unibyte_string, make_multibyte_string)
3566 (make_string_from_bytes, make_specified_string)
3567 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3568 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3570 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3571 (allocate_pseudovector):
3572 Use int, not EMACS_INT, where int is wide enough.
3573 (inhibit_garbage_collection, Fgarbage_collect):
3574 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3575 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3576 int might not be wide enough.
3577 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3578 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3579 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3580 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3581 (bidi_level_of_next_char, bidi_move_to_visually_next):
3582 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3583 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3584 (Fkill_buffer, Fset_buffer_major_mode)
3585 (advance_to_char_boundary, Fbuffer_swap_text)
3586 (Fset_buffer_multibyte, overlays_at, overlays_in)
3587 (overlay_touches_p, struct sortvec, record_overlay_string)
3588 (overlay_strings, recenter_overlay_lists)
3589 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3590 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3591 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3592 (Foverlay_recenter, last_overlay_modification_hooks_used)
3593 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3594 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3595 (validate_region): Omit unnecessary test for b <= e,
3596 since that's guaranteed by the previous test.
3597 (adjust_overlays_for_delete): Avoid pos + length overflow.
3598 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3599 (report_overlay_modification):
3600 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3601 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3602 Omit pointer cast, which isn't needed anyway, and doesn't work
3603 after the EMACS_INT -> ptrdiff_t change.
3604 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
3605 * buffer.h: Adjust decls to match defn changes elsewhere.
3606 (struct buffer_text, struct buffer):
3607 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3608 Use EMACS_INT, not int, where int might not be wide enough.
3609 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3610 not int, to avoid needless 32-bit limit on 64-bit hosts.
3611 (exec_byte_code): Use tighter memory-full test, one that checks
3612 for alloca overflow. Don't compute the address of the object just
3613 before an array, as that's not portable. Use EMACS_INT, not
3614 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
3615 * callint.c (Fcall_interactively):
3616 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3617 * callproc.c (call_process_kill, Fcall_process):
3618 Don't assume pid_t fits into an Emacs fixnum.
3619 (call_process_cleanup, Fcall_process, child_setup):
3620 Don't assume pid_t fits into int.
3621 (call_process_cleanup, Fcall_process, delete_temp_file)
3622 (Fcall_process_region):
3623 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3624 (Fcall_process): Simplify handling of volatile integers.
3625 Use int, not EMACS_INT, where int will do.
3626 * casefiddle.c (casify_object, casify_region, operate_on_word)
3627 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3628 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3629 (casify_object): Avoid integer overflow when overallocating buffer.
3630 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
3631 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
3632 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3633 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3634 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3635 integers are now checked earlier. All uses replaced with XINT.
3637 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3638 For CCL_MapSingle, check that content and value are in int range.
3639 (ccl_driver, Fregister_code_conversion_map):
3640 Check that Vcode_version_map_vector is a vector.
3641 (resolve_symbol_ccl_program): Check that vector header is in range.
3642 Always copy the vector, so that we can check its contents reliably
3643 now rather than having to recheck each instruction as it's being
3644 executed. Check that vector words fit in 'int'.
3645 (ccl_get_compiled_code, Fregister_ccl_program)
3646 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3647 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3648 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3649 contents are in range.
3650 (Fccl_execute_on_string): Check that status is in range.
3651 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3652 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3653 Accept and return EMACS_INT, not int, because callers can pass values
3655 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3656 (multibyte_chars_in_text, parse_str_as_multibyte)
3657 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3658 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3659 (string_escape_byte8, Fget_byte):
3660 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3661 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
3662 avoid mishandling large integers.
3663 * character.h: Adjust decls to match defn changes elsewhere.
3664 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3665 (Ffind_charset_region):
3666 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3667 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3668 (load_charset_map_from_vector, Fdefine_charset_internal):
3669 Don't assume fixnum fits in int.
3670 (load_charset_map_from_vector, Fmap_charset_chars):
3671 Remove now-unnecessary CHECK_NATNUMs.
3672 (Fdefine_charset_internal): Check ranges here, more carefully.
3673 Don't rely on undefined behavior with signed left shift overflow.
3674 Don't assume unsigned int fits into fixnum, or that fixnum fits
3675 into unsigned int. Don't require max_code to be a valid fixnum;
3676 that's not true for gb10830 4-byte on a 32-bit host. Allow
3677 invalid_code to be a cons, for the same reason. Require code_offset
3678 to be a character. Avoid int overflow if max_char is close
3680 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3681 this is intended anyway and avoids some undefined behavior.
3682 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3683 INDEX_TO_CODE_POINT, as that's what it expects.
3684 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
3685 * charset.h (DECODE_CHAR): Return int, not unsigned;
3686 this is what was intended anyway, and it avoids undefined behavior.
3687 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3688 integer-overflow issues.
3689 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3690 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3691 where the argument is EMACS_INT, and this behavior is not intended.
3692 * chartab.c (Fmake_char_table, Fset_char_table_range)
3693 (uniprop_get_decoder, uniprop_get_encoder):
3694 Don't assume fixnum fits in int.
3695 * cmds.c (move_point): New function, that does the gist of
3696 Fforward_char and Fbackward_char, but does so while checking
3697 for integer overflow more accurately.
3698 (Fforward_char, Fbackward_char): Use it.
3699 (Fforward_line, Fend_of_line, internal_self_insert)
3700 (internal_self_insert):
3701 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3702 Fix a FIXME, by checking for integer overflow when calculating
3703 target_clm and actual_clm.
3704 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
3705 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
3706 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3707 (coding_alloc_by_making_gap, alloc_destination)
3708 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3709 (encode_coding_utf_16, detect_coding_emacs_mule)
3710 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3711 (detect_coding_iso_2022, decode_coding_iso_2022)
3712 (encode_invocation_designation, encode_designation_at_bol)
3713 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3714 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3715 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3716 (encode_coding_ccl, encode_coding_raw_text)
3717 (detect_coding_charset, decode_coding_charset)
3718 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3719 (produce_composition, produce_charset, produce_annotation)
3720 (decode_coding, handle_composition_annotation)
3721 (handle_charset_annotation, consume_chars, decode_coding_gap)
3722 (decode_coding_object, encode_coding_object, detect_coding_system)
3723 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3724 (code_convert_region, code_convert_string)
3725 (Fdefine_coding_system_internal)
3726 (coding_set_source, coding_set_destination):
3727 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3728 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3729 (Fdefine_coding_system_internal):
3730 Don't assume fixnums fit in int.
3731 (decode_coding_gap, decode_coding_object, encode_coding_object)
3732 (Fread_coding_system, Fdetect_coding_region)
3733 (Funencodable_char_position, Fcheck_coding_systems_region)
3734 (get_translation, handle_composition_annotation, consume_chars):
3735 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3736 (consume_chars): Rewrite to not calculate an address outside buffer.
3737 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
3738 Don't access memory outside of the args array.
3739 (Fdefine_coding_system_internal): Check for charset-id overflow.
3740 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3741 result of ENCODE_CHAR.
3742 * coding.h: Adjust decls to match defn changes elsewhere.
3743 (struct coding_system):
3744 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3745 * composite.c (get_composition_id, find_composition)
3746 (run_composition_function, update_compositions)
3747 (compose_text, composition_gstring_put_cache)
3748 (composition_gstring_p, composition_gstring_width)
3749 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3750 (composition_compute_stop_pos, composition_reseat_it)
3751 (composition_update_it, struct position_record)
3752 (find_automatic_composition, composition_adjust_point)
3753 (Fcomposition_get_gstring, Ffind_composition_internal):
3754 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3755 (update_compositions):
3756 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3757 * composite.h: Adjust decls to match defn changes elsewhere.
3758 (struct composition):
3759 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3760 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3761 Do not attempt to compute the address of the object just before a
3762 buffer; this is not portable.
3764 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3765 (Faset): Use int, not EMACS_INT, where int is wide enough.
3766 (Fstring_to_number): Don't assume fixnums fit in int.
3767 (Frem): Don't assume arg is nonnegative.
3768 * dbusbind.c (xd_append_arg): Check for integers out of range.
3769 (Fdbus_call_method): Don't overflow the timeout int.
3770 (extract_signed, extract_unsigned): New functions.
3771 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3772 (xd_get_connection_references): Return ptrdiff_t, not int.
3774 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3775 (xd_read_message_1):
3776 Use int, not unsigned, where the dbus API uses int.
3777 (Fdbus_message_internal): Don't overflow mtype.
3778 (syms_of_dbusbind): Allocate right-sized buffer for integers.
3779 * dired.c (directory_files_internal, file_name_completion, scmp)
3780 (file_name_completion_stat):
3781 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3782 (file_name_completion): Don't overflow matchcount.
3783 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3784 * dispextern.h: Adjust decls to match defn changes elsewhere.
3785 (struct text_pos, struct glyph, struct bidi_saved_info)
3786 (struct bidi_string_data, struct bidi_it, struct composition_it)
3788 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3789 (struct display_pos, struct composition_it, struct it):
3790 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3791 * dispnew.c (increment_matrix_positions)
3792 (increment_row_positions, mode_line_string)
3793 (marginal_area_string):
3794 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3795 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
3796 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3797 (duration_to_sec_usec): New function, to check for overflow better.
3798 (Fsleep_for, sit_for): Use it.
3799 * doc.c (get_doc_string, store_function_docstring):
3800 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3801 (get_doc_string, Fsnarf_documentation):
3802 Use int, not EMACS_INT, where int is wide enough.
3804 Use SAFE_ALLOCA, not alloca.
3805 Check for overflow when converting EMACS_INT to off_t.
3806 * doprnt.c (doprnt):
3807 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3808 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3809 Don't assume uid_t fits into fixnum.
3810 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3811 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3812 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3813 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3814 (general_insert_function)
3815 (Finsert_char, make_buffer_string, make_buffer_string_both)
3816 (update_buffer_properties, Fbuffer_substring)
3817 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3818 (Fsubst_char_in_region, check_translation)
3819 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3820 (transpose_markers, Ftranspose_regions):
3821 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3822 (clip_to_bounds): Move to lisp.h as an inline function).
3823 (Fconstrain_to_field): Don't assume integers are nonnegative.
3824 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3825 (Fsubst_char_in_region, Fsave_restriction):
3826 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3827 (Femacs_pid): Don't assume pid_t fits into fixnum.
3828 (lo_time): Use int, not EMACS_INT, when int suffices.
3829 (lisp_time_argument): Check for usec out of range.
3830 (Fencode_time): Don't assume fixnum fits in int.
3831 (Fuser_login_name, Fuser_full_name): Signal an error
3832 if a uid argument is out of range, rather than relying on
3834 (Fformat_time_string): Remove now-unnecessary check.
3835 lisp_time_argument checks for out-of-range usec now.
3836 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
3837 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3838 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3839 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3840 (init_cmdargs, Fdump_emacs):
3841 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3842 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3843 the bottom (typically) 32 bits of the fixnum.
3844 * eval.c (specpdl_size, call_debugger):
3845 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3846 (when_entered_debugger, Fbacktrace_debug):
3847 Don't assume fixnum can fit in int.
3848 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3849 the object just before a buffer; this is not portable.
3850 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3851 (grow_specpdl, unbind_to):
3852 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3853 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3854 (grow_specpdl): Simplify allocation by using xpalloc.
3855 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
3856 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3857 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3858 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3859 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3861 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3862 (Fcopy_file, non_regular_nbytes, read_non_regular)
3863 (Finsert_file_contents):
3864 Use int, not EMACS_INT, where int is wide enough.
3865 (READ_BUF_SIZE): Verify that it fits in int.
3866 (Finsert_file_contents): Check that counts are in proper range,
3867 rather than assuming fixnums fit into ptrdiff_t etc.
3868 Don't assume fixnums fit into int.
3869 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
3870 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3871 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
3872 (string_char_to_byte, string_byte_to_char)
3873 (string_make_multibyte, string_to_multibyte)
3874 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3875 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3876 (substring_both, Fdelete, internal_equal, Ffillarray)
3877 (Fclear_string, mapcar1)
3878 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3879 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3880 (larger_vector, make_hash_table, maybe_resize_hash_table)
3881 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3882 (Fmaphash, secure_hash):
3883 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3884 (concat): Check for string index and length overflow.
3885 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3887 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3888 (larger_vector): New API (vec, incr_min, size_max) replaces old
3889 one (vec, new_size, init). This catches size overflow.
3890 INIT was removed because it was always Qnil.
3891 All callers changed.
3892 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3893 the upper bound on a hash table index size.
3894 (make_hash_table, maybe_resize_hash_table): Use it.
3895 (secure_hash): Computer start_byte and end_byte only after
3896 they're known to be in ptrdiff_t range.
3897 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3898 (Ffont_get_glyphs, Ffont_at):
3899 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3900 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3901 (Flist_fonts, Fopen_font):
3902 Don't assume fixnum can fit in int.
3903 (check_gstring): Don't assume index can fit in int.
3904 (font_match_p): Check that fixnum is a character, not a nonnegative
3905 fixnum, since the later code needs to stuff it into an int.
3906 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3907 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3908 conversion overflow issues.
3909 (Fopen_font): Check for integer out of range.
3910 (Ffont_get_glyphs): Don't assume index can fit in int.
3911 * font.h: Adjust decls to match defn changes elsewhere.
3912 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3914 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3915 printmax_t, where ptrdiff_t is wide enough.
3916 (Finternal_char_font):
3917 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3918 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3919 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3920 (Fset_frame_position, x_set_frame_parameters)
3921 (x_set_line_spacing, x_set_border_width)
3922 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3923 Check that fixnums are in proper range for system types.
3924 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3925 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3926 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3927 Use SAFE_ALLOCA_LISP, not alloca.
3928 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3929 intptr_t is wide enough.
3930 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3931 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3932 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3933 Check for fixnum out of range.
3934 * ftfont.c (ftfont_list): Don't assume index fits in int.
3935 Check that fixnums are in proper range for system types.
3936 (ftfont_shape_by_flt):
3937 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3938 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3939 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3940 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3941 Check that fixnums are in proper range for system types.
3942 * gnutls.h: Adjust decls to match defn changes elsewhere.
3943 * gtkutil.c (xg_dialog_run):
3944 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3945 (update_frame_tool_bar):
3946 Check that fixnums are in proper range for system types.
3947 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
3948 (lookup_image): Check that fixnums are in range for system types.
3949 * indent.c (last_known_column, last_known_column_point):
3950 (current_column_bol_cache):
3951 (skip_invisible, current_column, check_display_width):
3952 (check_display_width, scan_for_column, current_column_1)
3953 (Findent_to, Fcurrent_indentation, position_indentation)
3954 (indented_beyond_p, Fmove_to_column, compute_motion):
3955 (Fcompute_motion, Fvertical_motion):
3956 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3957 (last_known_column_modified): Use EMACS_INT, not int.
3958 (check_display_width):
3960 Check that fixnums and floats are in proper range for system types.
3961 (compute_motion): Don't assume index or fixnum fits in int.
3962 (compute_motion, Fcompute_motion):
3963 Use int, not EMACS_INT, when it is wide enough.
3964 (vmotion): Omit local var start_hpos that is always 0; that way
3965 we don't need to worry about overflow in expressions involving it.
3966 * indent.h: Adjust decls to match defn changes elsewhere.
3968 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3969 Use int, not EMACS_INT, where int is wide enough.
3970 Remove unused members ovstring_chars_done and tab_offset;
3972 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3973 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3974 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3975 (make_gap, copy_text, insert, insert_and_inherit)
3976 (insert_before_markers, insert_before_markers_and_inherit)
3977 (insert_1, count_combining_before, count_combining_after)
3978 (insert_1_both, insert_from_string)
3979 (insert_from_string_before_markers, insert_from_string_1)
3980 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3981 (adjust_after_replace, adjust_after_insert, replace_range)
3982 (replace_range_2, del_range, del_range_1, del_range_byte)
3983 (del_range_both, del_range_2, modify_region)
3984 (prepare_to_modify_buffer, signal_before_change)
3985 (signal_after_change, Fcombine_after_change_execute):
3986 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3987 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3988 (balance_an_interval, split_interval_right, split_interval_left)
3989 (find_interval, next_interval, update_interval)
3990 (adjust_intervals_for_insertion, delete_node, delete_interval)
3991 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3992 (static_offset_intervals, offset_intervals)
3993 (merge_interval_right, merge_interval_left, make_new_interval)
3994 (graft_intervals_into_buffer, temp_set_point_both)
3995 (temp_set_point, set_point, adjust_for_invis_intang)
3996 (set_point_both, move_if_not_intangible, get_property_and_range)
3997 (get_local_map, copy_intervals, copy_intervals_to_string)
3998 (compare_string_intervals, set_intervals_multibyte_1):
3999 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4000 * intervals.h: Adjust decls to match defn changes elsewhere.
4002 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4003 * keyboard.c (this_command_key_count, this_single_command_key_start)
4004 (before_command_key_count, before_command_echo_length, echo_now)
4005 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
4006 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
4007 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
4008 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
4009 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4010 (last_non_minibuf_size, last_point_position, echo_truncate)
4011 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
4012 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
4013 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
4014 (stuff_buffered_input):
4015 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4016 (last_auto_save, command_loop_1, read_char):
4017 Use EMACS_INT, not int, to avoid integer overflow.
4018 (record_char): Avoid overflow in total_keys computation.
4019 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
4020 * keyboard.h: Adjust decls to match defn changes elsewhere.
4021 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
4022 (Fkey_description, Fdescribe_vector, Flookup_key):
4023 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4024 (click_position): New function, to check that positions are in range.
4025 (Fcurrent_active_maps):
4027 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4028 (Faccessible_keymaps, Fkey_description):
4029 (preferred_sequence_p):
4030 Don't assume fixnum can fit into int.
4031 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
4032 Check for integer overflow in size calculations.
4033 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
4034 avoid mishandling large integers.
4035 * lisp.h: Adjust decls to match defn changes elsewhere.
4036 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
4037 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
4038 (struct Lisp_Marker):
4039 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4040 (clip_to_bounds): Now an inline function, moved here from editfns.c.
4041 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
4042 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
4043 All callers changed.
4044 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
4045 Assume the arg has valid form, since it always does.
4046 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
4047 unsigned integer system type.
4048 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
4049 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
4050 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4051 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
4052 (duration_to_sec_usec): New decl.
4053 * lread.c (read_from_string_index, read_from_string_index_byte)
4054 (read_from_string_limit, readchar, unreadchar, openp)
4055 (read_internal_start, read1, oblookup):
4056 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4057 (Fload, readevalloop, Feval_buffer, Feval_region):
4058 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4059 (openp): Check for out-of-range argument to 'access'.
4060 (read1): Use int, not EMACS_INT, where int is wide enough.
4061 Don't assume fixnum fits into int.
4062 Fix off-by-one error that can read outside a buffer.
4063 (read_filtered_event): Use duration_to_sec_usec
4064 to do proper overflow checking on durations.
4065 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
4066 in size calculation.
4067 (Fexecute_kbd_macro):
4068 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4069 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
4070 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
4071 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
4072 (set_marker_both, set_marker_restricted_both, marker_position)
4073 (marker_byte_position, Fbuffer_has_markers_at):
4074 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4075 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
4076 * menu.c (ensure_menu_items): Rename from grow_menu_items.
4077 It now merely ensures that the menu is large enough, without
4078 necessarily growing it, as this avoids some integer overflow issues.
4079 All callers changed.
4080 (keymap_panes, parse_single_submenu, Fx_popup_menu):
4081 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4082 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
4083 Use SAFE_ALLOCA_LISP, not alloca.
4084 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
4085 to EMACS_INT. Check that fixnums are in proper range for system types.
4086 * minibuf.c (minibuf_prompt_width, string_to_object)
4087 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
4088 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
4089 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4090 (get_minibuffer, read_minibuf_unwind):
4091 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4092 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
4093 this simplifies overflow checking. All callers changed.
4094 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
4096 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4097 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
4098 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
4099 Check that fixnums are in proper range for system types.
4100 (Fx_create_frame, Fx_show_tip):
4101 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4102 * nsfont.m (ns_findfonts, nsfont_list_family):
4103 Don't assume fixnum fits in long.
4104 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
4105 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4106 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
4108 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
4109 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4110 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
4111 (PRINTDECLARE, PRINTPREPARE):
4112 (strout, print_string):
4113 (print, print_preprocess, print_check_string_charset_prop)
4115 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4117 (temp_output_buffer_setup, Fprin1_to_string, print_object):
4118 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4119 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
4120 (printchar, strout): Use xpalloc to catch size calculation overflow.
4121 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
4122 (print_error_message): Use SAFE_ALLOCA, not alloca.
4123 (print_object): Use int, not EMACS_INT, where int is wide enough.
4124 (print_depth, new_backquote_output, print_number_index):
4125 Use ptrdiff_t, not int, where int might not be wide enough.
4126 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
4127 (Fset_process_window_size, Fformat_network_address)
4128 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
4130 Check that fixnums are in proper range for system types.
4131 (Fsignal_process): Simplify by avoiding a goto.
4132 Check for process-ids out of pid_t range rather than relying on
4134 (process_tick, update_tick): Use EMACS_INT, not int.
4135 (Fformat_network_address, read_process_output, send_process)
4136 (Fprocess_send_region, status_notify):
4137 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4138 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
4139 (wait_reading_process_output, read_process_output, exec_sentinel):
4140 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4141 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
4142 (Faccept_process_output): Use duration_to_sec_usec to do proper
4143 overflow checking on durations.
4144 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
4145 Don't assume pid_t fits in int.
4146 * process.h (struct Lisp_Process): Members tick and update_tick
4147 are now of type EMACS_INT, not int.
4148 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4149 configured --with-wide-int.
4150 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4151 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4152 * search.c (looking_at_1, string_match_1):
4153 (fast_string_match, fast_c_string_match_ignore_case)
4154 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4155 (scan_newline, find_before_next_newline, search_command)
4156 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4157 (set_search_regs, wordify):
4160 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4161 (string_match_1, search_buffer, set_search_regs):
4163 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4164 (wordify): Check for overflow in size calculation.
4165 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4166 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4167 Check that fixnums are in proper range for system types.
4168 * sound.c (struct sound_device)
4169 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4170 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4171 (Fplay_sound_internal):
4172 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4173 * syntax.c (struct lisp_parse_state, find_start_modiff)
4174 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4175 (Fparse_partial_sexp):
4176 Don't assume fixnums can fit in int.
4177 (struct lisp_parse_state, find_start_pos, find_start_value)
4178 (find_start_value_byte, find_start_begv)
4179 (update_syntax_table, char_quoted, dec_bytepos)
4180 (find_defun_start, prev_char_comend_first, back_comment):
4181 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4182 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4183 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4184 (Finternal_describe_syntax_value): Check that match_lisp is a
4185 character, not an integer, since the code stuffs it into int.
4186 (scan_words, scan_sexps_forward):
4187 Check that fixnums are in proper range for system types.
4189 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4190 (scan_sexps_forward):
4191 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4192 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4193 * syntax.h: Adjust decls to match defn changes elsewhere.
4194 (struct gl_state_s):
4195 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4196 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4197 MOST_POSITIVE_FIXNUM.
4198 * sysdep.c (wait_for_termination_1, wait_for_termination)
4199 (interruptible_wait_for_termination, mkdir):
4200 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4201 (emacs_read, emacs_write):
4202 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4203 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4204 and double all fit in int.
4205 * term.c (set_tty_color_mode):
4206 Check that fixnums are in proper range for system types.
4207 * termhooks.h (struct input_event):
4208 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4209 * textprop.c (validate_interval_range, interval_of)
4210 (Fadd_text_properties, set_text_properties_1)
4211 (Fremove_text_properties, Fremove_list_of_text_properties)
4212 (Ftext_property_any, Ftext_property_not_all)
4213 (copy_text_properties, text_property_list, extend_property_ranges)
4214 (verify_interval_modification):
4215 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4216 (Fnext_single_char_property_change)
4217 (Fprevious_single_char_property_change):
4218 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4219 (copy_text_properties):
4220 Check for integer overflow in index calculation.
4221 * undo.c (last_boundary_position, record_point, record_insert)
4222 (record_delete, record_marker_adjustment, record_change)
4223 (record_property_change):
4224 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4225 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4226 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4227 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4228 (Fx_hide_tip, Fx_file_dialog):
4229 * w32menu.c (set_frame_menubar):
4230 Use ptrdiff_t, not int, for consistency with rest of code.
4231 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4232 (select_window, Fdelete_other_windows_internal)
4233 (window_scroll_pixel_based, window_scroll_line_based)
4234 (Frecenter, Fset_window_configuration):
4235 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4236 (Fset_window_hscroll, run_window_configuration_change_hook)
4237 (set_window_buffer, temp_output_buffer_show, scroll_command)
4238 (Fscroll_other_window, Frecenter):
4239 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4240 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4241 Don't assume fixnum fits in int.
4242 (Fset_window_scroll_bars):
4243 Check that fixnums are in proper range for system types.
4244 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4245 (string_pos, c_string_pos, number_of_chars, init_iterator)
4246 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4247 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4248 (compute_display_string_end, handle_face_prop)
4249 (face_before_or_after_it_pos, handle_invisible_prop)
4250 (handle_display_prop, handle_display_spec, handle_single_display_spec)
4251 (display_prop_intangible_p, string_buffer_position_lim)
4252 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4253 (get_overlay_strings_1, get_overlay_strings)
4254 (iterate_out_of_display_property, forward_to_next_line_start)
4255 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4256 (get_next_display_element, set_iterator_to_next)
4257 (get_visually_first_element, compute_stop_pos_backwards)
4258 (handle_stop_backwards, next_element_from_buffer)
4259 (move_it_in_display_line_to, move_it_in_display_line)
4260 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4261 (add_to_log, message_dolog, message_log_check_duplicate)
4262 (message2, message2_nolog, message3, message3_nolog
4263 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4264 (current_message_1, truncate_echo_area, truncate_message_1)
4265 (set_message, set_message_1, store_mode_line_noprop)
4266 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4267 (text_outside_line_unchanged_p, check_point_in_composition)
4268 (reconsider_clip_changes)
4269 (redisplay_internal, set_cursor_from_row, try_scrolling)
4270 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4271 (redisplay_window, find_last_unchanged_at_beg_row)
4272 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4273 (trailing_whitespace_p, find_row_edges, display_line)
4274 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4275 (display_mode_element, store_mode_line_string)
4276 (pint2str, pint2hrstr, decode_mode_spec)
4277 (display_count_lines, display_string, draw_glyphs)
4278 (x_produce_glyphs, x_insert_glyphs)
4279 (rows_from_pos_range, mouse_face_from_buffer_pos)
4280 (fast_find_string_pos, mouse_face_from_string_pos)
4281 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4282 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4283 (safe_call, init_from_display_pos, handle_fontified_prop)
4284 (handle_single_display_spec, load_overlay_strings)
4285 (with_echo_area_buffer, setup_echo_area_for_printing)
4286 (display_echo_area, echo_area_display)
4287 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4288 (update_tool_bar, hscroll_window_tree, redisplay_internal)
4289 (redisplay_window, dump_glyph_row, display_mode_line)
4290 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
4291 (handle_display_spec, display_prop_string_p):
4292 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4293 (handle_single_display_spec, build_desired_tool_bar_string)
4294 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4295 (get_specified_cursor_type):
4296 Check that fixnums are in proper range for system types.
4297 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4298 (Flookup_image_map):
4299 Don't assume fixnums fit in int.
4300 (compare_overlay_entries):
4301 Avoid mishandling comparisons due to subtraction overflow.
4302 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4303 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4304 (handle_tool_bar_click):
4305 Use int, not unsigned, since we prefer signed and the signedness
4306 doesn't matter here.
4307 (get_next_display_element, next_element_from_display_vector):
4308 Use int, not EMACS_INT, when int is wide enough.
4309 (start_hourglass): Use duration_to_sec_usec to do proper
4310 overflow checking on durations.
4311 * xfaces.c (Fbitmap_spec_p):
4312 Check that fixnums are in proper range for system types.
4313 (compare_fonts_by_sort_order):
4314 Avoid mishandling comparisons due to subtraction overflow.
4315 (Fx_family_fonts, realize_basic_faces):
4316 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4318 Don't assume fixnum fits in int.
4319 Use SAFE_ALLOCA_LISP, not alloca.
4320 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4321 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4322 (face_at_buffer_position, face_for_overlay_string)
4323 (face_at_string_position):
4324 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4325 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4326 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4328 Check that fixnums are in proper range for system types.
4329 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4330 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4331 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4332 (Fx_change_window_property): Don't assume fixnums fit in int.
4333 * xfont.c (xfont_chars_supported):
4334 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4335 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4336 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4337 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4338 * xml.c (parse_region):
4339 * xrdb.c (magic_file_p):
4340 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4341 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4342 (x_get_local_selection, x_reply_selection_request)
4343 (x_handle_selection_request, wait_for_property_change):
4344 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4345 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4346 short is wide enough.
4347 (x_send_client_event): Don't assume fixnum fits in int.
4348 * xterm.c (x_x_to_emacs_modifiers):
4349 Don't assume EMACS_INT overflows nicely into int.
4350 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4352 (handle_one_xevent): NATNUMP can eval its arg twice.
4353 (x_connection_closed):
4354 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4355 * xterm.h: Adjust decls to match defn changes elsewhere.
4356 (struct scroll_bar): Use struct vectorlike_header
4357 rather than rolling our own approximation.
4358 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4360 2012-05-25 Glenn Morris <rgm@gnu.org>
4362 * lisp.mk (lisp): Update for more files being compiled now.
4364 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4366 * lread.c: Remove `read_pure' which makes no difference.
4367 (read_pure): Remove var.
4368 (unreadpure): Remove function.
4369 (readevalloop): Don't call read_list with -1 flag.
4370 (read1, read_vector): Don't test read_pure any more.
4371 (read_list): Simplify.
4373 * fileio.c, character.h: Minor style tweaks.
4375 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4377 * window.h (clip_changed): Remove useless declaration.
4379 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
4381 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4382 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4384 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4387 This directory predates autoconf and is no longer needed nowadays.
4388 Move its few remaining bits of functionality to where they're needed.
4389 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4390 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4391 * m/template.h: Remove.
4392 * Makefile.in (M_FILE): Remove. All uses removed.
4393 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4394 * lisp.h (USE_LSB_TAG):
4395 * mem-limits.h (EXCEEDS_LISP_PTR):
4396 Use VAL_MAX, not VALBITS, in #if.
4397 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4398 (EMACS_UINT): Define unconditionally now.
4399 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4400 (BITS_PER_EMACS_INT): New constants, replacing
4401 what used to be in config.h, but not useful in #if.
4402 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4403 define them any more.
4404 (VAL_MAX): New macro.
4406 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4407 BITS_PER_EMACS_INT, in #if.
4408 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4409 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4410 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4411 * s/ms-w32.h (DATA_START):
4412 Move here from removed file m/intel386.h.
4413 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4414 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4416 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4418 Assume C89 or later.
4419 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4420 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4422 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4423 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4424 * textprop.c, tparam.c (NULL): Remove.
4425 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4426 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4427 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4428 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4429 * xterm.c (input_signal_count): Assume volatile works.
4431 2012-05-21 Ken Brown <kbrown@cornell.edu>
4433 * xgselect.c (xg_select): Fix first argument in call to 'select'
4436 2012-05-20 Ken Brown <kbrown@cornell.edu>
4438 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
4439 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
4441 2012-05-19 Ken Brown <kbrown@cornell.edu>
4443 * xfns.c (x_in_use): Remove `static' qualifier.
4444 * xterm.h (x_in_use): Declare.
4445 * xgselect.c: Include xterm.h.
4446 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4447 and `display_arg' (bug#9754).
4449 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4451 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4453 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4454 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4456 2012-05-18 Eli Zaretskii <eliz@gnu.org>
4458 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4460 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
4461 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
4463 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4464 reference to image_cache->refcount.
4465 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4467 2012-05-17 Juri Linkov <juri@jurta.org>
4469 * search.c (Fword_search_regexp, Fword_search_backward)
4470 (Fword_search_forward, Fword_search_backward_lax)
4471 (Fword_search_forward_lax): Move functions to isearch.el
4472 (bug#10145, bug#11381).
4474 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4476 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4478 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4480 * lread.c (init_obarray): Declare Qt and Qnil as special.
4482 2012-05-14 Glenn Morris <rgm@gnu.org>
4484 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
4485 Put "libexec" before "bin", for the sake of init_callproc_1.
4487 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4489 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4491 * unexaix.c: Port to more-recent AIX compilers.
4492 (report_error, report_error_1, make_hdr, copy_sym)
4493 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4494 Make arguments const char *, not char *, to avoid violations of C
4495 standard and to fix some AIX warnings reported by Gilles Pion.
4497 2012-05-14 Eli Zaretskii <eliz@gnu.org>
4499 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4500 already have overlays loaded.
4501 (handle_single_display_spec): Before returning without displaying
4502 fringe bitmap, synchronize the bidi iterator with the main display
4503 iterator, by calling iterate_out_of_display_property.
4504 (iterate_out_of_display_property): Detect buffer iteration by
4505 testing that it->string is a Lisp string.
4506 (get_next_display_element): When the current object is exhausted,
4507 and there's something on it->stack, call set_iterator_to_next to
4508 proceed with what's on the stack, instead of returning zero.
4509 (set_iterator_to_next): If called at the end of a Lisp string,
4510 proceed to consider_string_end without incrementing string
4511 position. Don't increment display vector index past the end of
4512 the display vector. (Bug#11417)
4513 (pos_visible_p): Don't report a position visible when move_it_to
4514 stopped at the last line of window, which happens to be scanned
4515 backwards by the bidi iteration. (Bug#11464)
4517 2012-05-14 Eli Zaretskii <eliz@gnu.org>
4519 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4520 and right-margin display specs even if the spec is invalid or we
4521 are on a TTY, and thus unable to display on the fringes.
4522 That's because the text with the property will not be displayed anyway,
4523 so we need to signal to the caller that this is a "replacing"
4524 display spec. This fixes display when the spec is invalid or we
4527 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4529 * unexaix.c (make_hdr): Fix typo in prototype.
4530 This bug broke the build on AIX. Problem reported by Gilles Pion.
4532 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
4534 * keyboard.c (kbd_buffer_get_event): Read special events also in
4535 batch mode. (Bug#11415)
4537 2012-05-12 Glenn Morris <rgm@gnu.org>
4539 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4541 2012-05-12 Eli Zaretskii <eliz@gnu.org>
4543 * lisp.mk (lisp): Add newcomment.elc.
4545 2012-05-12 Glenn Morris <rgm@gnu.org>
4547 * Makefile.in (MKDIR_P): New, set by configure.
4548 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4550 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4552 Remove unused function hourglass_started.
4553 * dispextern.h (hourglass_started):
4554 * w32fns.c (hourglass_started):
4555 * xdisp.c (hourglass_started): Remove.
4557 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
4559 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4560 Update dependencies.
4562 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4564 * xgselect.c (xg_select): Put maxfds+1 into a var.
4565 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4567 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4569 2012-05-10 Dave Abrahams <dave@boostpro.com>
4571 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4572 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4574 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
4576 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4577 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4578 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4579 Initialize xd_registered_buses.
4581 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4583 Untag more efficiently if USE_LSB_TAG.
4584 This is based on a proposal by YAMAMOTO Mitsuharu in
4585 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4586 For an admittedly artificial (nth 8000 longlist) benchmark on
4587 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4588 Emacs's overall text size by 1%.
4589 * lisp.h (XUNTAG): New macro.
4590 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4591 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4592 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4593 * eval.c (Fautoload):
4594 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4595 * frame.h (XFRAME): Use XUNTAG.
4597 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4598 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4599 Remove unportable assumptions about print widths of types like
4601 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4602 intptr_t when converting between pointer and integer, to avoid GCC
4603 warnings about wrong width.
4605 2012-05-09 Eli Zaretskii <eliz@gnu.org>
4607 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4608 stack for each reader_thread, instead of defaulting to 8MB
4609 determined by the linker. This avoids failures in creating
4610 subprocesses on Windows 7, see the discussion in this thread:
4611 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4613 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4615 Fix up display of the *Minibuf-0* buffer in the mini window.
4616 * keyboard.c (read_char): Don't clear the echo area if there's no
4618 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
4619 contents of *Minibuf-0*) if there's no message displayed in its stead.
4621 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
4623 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4626 2012-05-06 Chong Yidong <cyd@gnu.org>
4628 * lisp.mk (lisp): Update.
4630 2012-05-05 Jim Meyering <meyering@redhat.com>
4632 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4634 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4636 * data.c (PUT_ERROR): New macro.
4637 (syms_of_data): Use it. Add new error type `user-error'.
4638 * undo.c (user_error): New function.
4639 (Fprimitive_undo): Use it.
4640 * print.c (print_error_message): Adjust print style for `user-error'.
4641 * keyboard.c (user_error): New function.
4642 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4644 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4646 Do not limit current-time-string to years 1000..9999.
4647 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4648 (Fcurrent_time_string): Support any year that is supported by the
4649 underlying localtime representation. Don't use asctime, as it
4650 has undefined behavior for years outside the range -999..9999.
4652 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4654 Fix race conditions involving setenv, gmtime, localtime, asctime.
4655 Without this fix, interrupts could mess up code that uses these
4656 nonreentrant functions, since setting TZ invalidates existing
4657 tm_zone or tzname values, and since most of these functions return
4658 pointers to static storage.
4659 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4660 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4661 Grow the critical sections to include not just invoking
4662 localtime/gmtime, but also accessing these functions' results
4663 including their tm_zone values if any, and any related TZ setting.
4664 (format_time_string): Last arg is now struct tm *, not struct tm **,
4665 so that the struct tm is saved in the critical section.
4666 All callers changed. Simplify allocation of initial buffer, partly
4667 motivated by the fact that memory allocation needs to be outside
4668 the critical section.
4670 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4672 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4673 with RESET_INTERVAL.
4675 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4676 Remove duplicated buffer name initialization.
4678 2012-05-02 Jim Meyering <jim@meyering.net>
4680 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4682 * xfns.c (x_window): Use xstrdup (Bug#11375).
4684 2012-05-02 Eli Zaretskii <eliz@gnu.org>
4686 * xdisp.c (pos_visible_p): If already at a newline from the
4687 display string before the 'while' loop, don't walk back the glyphs
4688 from it3.glyph_row. Solves assertion violation when the display
4689 string begins with a newline (egg.el). (Bug#11367)
4691 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4693 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4696 2012-05-01 Glenn Morris <rgm@gnu.org>
4698 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4699 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4700 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4701 All were removed before 23.1.
4703 * dispnew.c: Remove HAVE_LIBNCURSES test;
4704 it is always true on relevant platforms.
4706 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4707 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4709 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4711 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4713 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4714 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4717 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4719 Do not avoid creating empty evaporating overlays (Bug#9642).
4720 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4721 That is, do not delete an evaporating overlay if it becomes
4722 empty after its bounds are adjusted to fit within its buffer.
4723 This fix caused other problems, and I'm reverting it until we get
4724 to the bottom of them.
4726 2012-04-27 Chong Yidong <cyd@gnu.org>
4728 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4730 2012-04-27 Eli Zaretskii <eliz@gnu.org>
4732 * xdisp.c (pos_visible_p): If the window start position is beyond
4733 ZV, start the display from buffer beginning. Prevents assertion
4734 violation in init_iterator when the minibuffer window is scrolled
4737 * window.c (window_scroll_pixel_based): Likewise.
4739 2012-04-27 Chong Yidong <cyd@gnu.org>
4741 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4743 2012-04-27 Glenn Morris <rgm@gnu.org>
4745 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4746 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4748 2012-04-27 Eli Zaretskii <eliz@gnu.org>
4750 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4751 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
4753 2012-04-26 Eli Zaretskii <eliz@gnu.org>
4755 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4756 display element, check also the underlying string or buffer
4757 character. (Bug#11341)
4759 * w32menu.c: Include w32heap.h.
4760 (add_menu_item): If the call to AppendMenuW (via
4761 unicode_append_menu) fails, disable Unicode menus only if we are
4762 running on Windows 9X/Me.
4764 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4766 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4767 (xgetint): Add missing shift for LSB tags.
4769 2012-04-24 Martin Rudalics <rudalics@gmx.at>
4771 * keyboard.c (read_char): Don't wipe echo area for select window
4772 events: These might get delayed via `mouse-autoselect-window'
4775 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
4777 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4778 manipulation of :loaded-from data.
4780 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
4782 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4783 now a cons (bug#11311).
4785 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4787 Do not create empty overlays with the evaporate property (Bug#9642).
4788 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4789 if it becomes empty after its bounds are adjusted to fit within
4790 its buffer. Without this fix, in a nonempty buffer (let ((o
4791 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4792 yields an empty overlay that has the evaporate property, which is
4793 not supposed to happen.
4795 Fix minor GTK3 problems found by static checking.
4796 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4797 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4798 (struct _EmacsFixedClass, emacs_fixed_get_type):
4799 Move decls here from emacsgtkfixed.h, since they needn't be public.
4800 (emacs_fixed_get_type): Now static.
4801 (emacs_fixed_class_init): Omit unused local.
4802 (emacs_fixed_child_type): Remove; unused.
4803 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4804 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4805 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4806 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4807 (EMACS_FIXED_GET_CLASS): Remove; unused.
4808 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4810 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4811 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4813 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4815 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
4816 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
4817 (__malloc_size_t, __malloc_ptrdiff_t):
4818 Remove. All uses removed, replaced by the definiens if needed,
4819 since we can assume C89 or better now.
4820 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4821 (protect_malloc_state, align, get_contiguous_space)
4822 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4823 (malloc_atfork_handler_child, malloc_enable_thread)
4824 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4825 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4826 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4827 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4828 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4829 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4830 Define using prototypes, not old style.
4831 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4832 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4833 (align): Don't assume that signed integer overflow wraps around.
4834 Omit unused local var.
4835 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4836 (_free_internal_nolock, memalign, mallochook, reallochook):
4837 Omit no-longer-needed casts.
4838 (valloc): Use getpagesize, not __getpagesize.
4839 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4840 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4842 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4844 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
4846 Move functions from C to Lisp. Make non-blocking method calls
4847 the default. Implement further D-Bus standard interfaces.
4849 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4850 (QCdbus_request_name_allow_replacement)
4851 (QCdbus_request_name_replace_existing)
4852 (QCdbus_request_name_do_not_queue)
4853 (QCdbus_request_name_reply_primary_owner)
4854 (QCdbus_request_name_reply_in_queue)
4855 (QCdbus_request_name_reply_exists)
4856 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4857 (QCdbus_registered_serial, QCdbus_registered_method)
4858 (QCdbus_registered_signal): New Lisp objects.
4859 (XD_DEBUG_MESSAGE): Use sizeof.
4860 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4861 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4862 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4863 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4864 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4865 (xd_signature, xd_append_arg): Allow float for integer types.
4866 (xd_get_connection_references): New function.
4867 (xd_get_connection_address): Rename from xd_initialize.
4868 Return cached address.
4869 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4870 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4872 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
4873 Return number of refcounts.
4874 (Fdbus_get_unique_name): Make stronger parameter check.
4875 (Fdbus_message_internal): New defun.
4876 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4877 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4878 (Fdbus_send_signal, Fdbus_register_service)
4879 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4880 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4881 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4882 (Vdbus_compiled_version, Vdbus_runtime_version)
4883 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4884 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4885 (Vdbus_message_type_signal): New defvars.
4886 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4889 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4891 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4892 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4893 Do not assume ptrdiff_t is the same width as 'int'.
4895 * alloc.c: Handle unusual debugging option combinations.
4896 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4897 since the two debugging options are incompatible.
4898 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4900 (mem_init, mem_insert, mem_insert_fixup):
4901 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4902 (NEED_MEM_INSERT): Remove; no longer needed.
4904 2012-04-22 Leo Liu <sdl.web@gmail.com>
4906 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4908 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4910 * sysdep.c [__FreeBSD__]: Minor cleanups.
4911 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4912 Use Emacs indenting style more consistently. Avoid some casts.
4913 Use 'double' consistently rather than mixing 'float' and 'double'.
4915 2012-04-21 Eduard Wiebe <usenet@pusto.de>
4917 * sysdep.c (list_system_processes, system_process_attributes):
4918 Add implementation for FreeBSD (Bug#5243).
4920 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4922 * lisp.mk (lisp): Update.
4924 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4926 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4927 It is never used otherwise.
4929 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4931 * print.c (print_preprocess): Only check print_depth if print-circle
4933 (print_object): Check for cycles even when print-circle is nil and
4934 print-gensym is t, but only check print_depth if print-circle is nil.
4936 2012-04-20 Chong Yidong <cyd@gnu.org>
4938 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4939 set the status to "failed" and ensure that sentinel is run.
4941 2012-04-20 Glenn Morris <rgm@gnu.org>
4943 * process.c (Fset_process_inherit_coding_system_flag)
4944 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4945 (Fmake_network_process, Fmake_serial_process): Doc fix.
4947 2012-04-20 Eli Zaretskii <eliz@gnu.org>
4949 * xdisp.c (string_buffer_position_lim): Limit starting position to
4951 (set_cursor_from_row): If called for a mode-line or header-line
4952 row, return zero immediately.
4953 (try_cursor_movement): If inside continuation line, don't back up
4954 farther than the first row after the header line, if any.
4955 Don't consider the header-line row as "partially visible", even if
4956 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4958 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
4960 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4963 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
4964 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
4966 configure: new option --enable-gcc-warnings (Bug#11207)
4967 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4968 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4969 (ALL_CFLAGS): Use new macros rather than old.
4970 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4971 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4972 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4973 -Wunused-result, -Wunused-variable. This should go away once
4974 the Emacs and Gnulib regex code is merged.
4975 (xmalloc, xrealloc): Now static.
4977 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4979 * dired.c (Fsystem_groups): Remove unused local.
4981 2012-04-17 Glenn Morris <rgm@gnu.org>
4983 * dired.c (Fsystem_users): Doc fix.
4985 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4987 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4988 (syms_of_dired): Add them.
4990 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4992 Fix minor alloc.c problems found by static checking.
4993 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4994 New extern decls, to avoid calling undeclared functions.
4995 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4996 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4997 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4998 (NEED_MEM_INSERT): New macro.
4999 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
5000 Remove one incorrect comment and fix another.
5002 Fix minor ralloc.c problems found by static checking.
5003 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5004 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
5005 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
5006 (r_alloc_sbrk): Now static.
5008 Improve ralloc.c interface checking.
5009 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5010 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
5011 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
5012 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
5013 [REL_ALLOC]: ... to here, to check interface.
5014 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
5015 Remove decls. This fixes an "It stinks!".
5017 * alloc.c (which_symbols): Fix alignment issue / type clash.
5019 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
5021 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
5022 (struct Lisp_Misc_Any): Likewise.
5023 (struct Lisp_Free): Likewise.
5024 * alloc.c (union aligned_Lisp_Symbol): Define.
5025 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
5026 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
5027 (union aligned_Lisp_Misc): Define.
5028 (MARKER_BLOCK_SIZE, struct marker_block): Use union
5029 aligned_Lisp_Misc instead of union Lisp_Misc.
5030 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
5032 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
5034 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
5035 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
5036 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
5037 * s/netbsd.h, s/sol2-6.h:
5038 Remove definition of GC_MARK_STACK, since the default now works.
5039 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
5040 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
5041 no longer the default.
5042 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
5044 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
5046 * lread.c (lisp_file_lexically_bound_p):
5047 Fix hang at ";-*-\n" (bug#11238).
5049 2012-04-14 Eli Zaretskii <eliz@gnu.org>
5051 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
5052 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
5054 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
5056 * nsterm.m (constrainFrameRect): Always constrain when there is only
5057 one screen (Bug#10962).
5059 2012-04-13 Ken Brown <kbrown@cornell.edu>
5061 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
5063 2012-04-13 Reuben Thomas <rrt@sc3d.org>
5065 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
5067 2012-04-11 Daniel Colascione <dancol@dancol.org>
5069 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
5070 against is gone. It's better to use vfork now so that when Cygwin
5071 gains a new, working vfork, we use it automatically (bug#10398).
5073 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5075 * window.c (save_window_save): Obey window-point-insertion-type.
5077 2012-04-11 Glenn Morris <rgm@gnu.org>
5079 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
5081 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5083 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
5085 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
5087 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
5088 (force_quit_count): New var.
5089 (handle_interrupt): Use it.
5091 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
5093 * w32.c (w32_delayed_load): Record the full path of the library
5094 being loaded (bug#10424).
5096 2012-04-09 Glenn Morris <rgm@gnu.org>
5098 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
5099 not just in the obarray, before snarfing them. (Bug#11036)
5101 * Makefile.in ($(leimdir)/leim-list.el):
5102 Pass EMACS rather than BUILT_EMACS.
5104 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
5106 * process.c (make_process):
5107 * process.h: Add integer `gnutls_handshakes_tried' member to
5110 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
5111 Add convenience `GNUTLS_LOG2i' macro.
5113 * gnutls.c (gnutls_log_function2i): Convenience log function.
5114 (emacs_gnutls_read): Use new log functions,
5115 `gnutls_handshakes_tried' process member, and
5116 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
5117 attempts per process (connection).
5119 2012-04-09 Chong Yidong <cyd@gnu.org>
5121 * eval.c (Fuser_variable_p, user_variable_p_eh)
5122 (lisp_indirect_variable): Functions deleted.
5123 (Fdefvar): Caller changed.
5125 * callint.c (Finteractive, Fcall_interactively):
5126 * minibuf.c (Fread_variable): Callers changed.
5128 2012-04-09 Eli Zaretskii <eliz@gnu.org>
5130 * xdisp.c (set_cursor_from_row): If the display string appears in
5131 the buffer at position that is closer to point than the position
5132 after the display string, display the cursor on the first glyph of
5133 the display string. Fixes cursor display when a 'display' text
5134 property immediately follows invisible text. (Bug#11094)
5136 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
5138 composite.c: use 'double' consistently
5139 * composite.c (get_composition_id): Use 'double' consistently
5140 instead of converting 'float' to 'double' and vice versa; this is
5141 easier to understand and avoids a GCC warning.
5143 2012-04-09 Glenn Morris <rgm@gnu.org>
5145 * Makefile.in: Generate leim-list with bootstrap-emacs, in
5146 preparation for dumping it with emacs. (Bug#4789)
5147 (leimdir): New variable.
5148 ($(leimdir)/leim-list.el): New rule.
5149 (emacs$(EXEEXT)): Depend on leim-list.el.
5151 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5152 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5153 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5155 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5157 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5160 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
5162 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5163 Remove unused local variable.
5165 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5167 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5168 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5169 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5170 objects, as mark_maybe_pointer will catch them otherwise.
5171 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5172 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5174 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5176 Fix typo that broke non-Windows builds.
5177 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5179 2012-04-07 Eli Zaretskii <eliz@gnu.org>
5181 Support building on MS-Windows with libxml2.
5183 * makefile.w32-in (OBJ2): Add xml.$(O).
5184 (GLOBAL_SOURCES): Add xml.c.
5185 ($(BLD)/xml.$(O)): New dependency list.
5187 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5188 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5189 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5190 [!WINDOWSNT]: New macros.
5191 (init_libxml2_functions, libxml2_loaded_p): New functions.
5192 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5193 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5194 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5195 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5197 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5198 Call init_libxml2_functions before calling libxml2 functions.
5199 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5201 * emacs.c: Don't include libxml/parser.h.
5202 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5203 xmlCleanupParser directly.
5205 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5207 2012-04-07 Eli Zaretskii <eliz@gnu.org>
5209 * indent.c (Fvertical_motion): If there is a display string at
5210 point, use it.vpos to compute how many lines to backtrack after
5211 move_it_to point. (Bug#11133)
5213 2012-04-06 Eli Zaretskii <eliz@gnu.org>
5215 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5216 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5217 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5218 macros related to unification of CJK characters. For the details,
5219 see the discussion following the message here:
5220 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5222 2012-04-04 Chong Yidong <cyd@gnu.org>
5224 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5226 2012-04-01 Eli Zaretskii <eliz@gnu.org>
5228 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5229 instead of alloca. (Bug#11138)
5231 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5233 * w32menu.c (is_simple_dialog): Properly check lisp types.
5236 2012-03-31 Eli Zaretskii <eliz@gnu.org>
5238 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5239 position we get to after a call to move_it_to fails the
5240 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5241 only if we wind up in a string from display property. (Bug#11063)
5243 * window.c (Fdelete_other_windows_internal): Invalidate the row
5244 and column information about mouse highlight, so that redisplay
5245 restores it after reallocating the glyph matrices. (Bug#7464)
5247 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5248 string comes from a `display' text property, use the buffer
5249 position of that property as if we actually saw that position in
5251 (move_it_by_lines): Remove the assertion that
5252 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5253 violated when there's a before-string at the beginning of a line.
5256 2012-03-30 Eli Zaretskii <eliz@gnu.org>
5258 * xdisp.c (append_space_for_newline): If the default face was
5259 remapped, use the remapped face for the appended newline.
5260 (extend_face_to_end_of_line): Use the remapped default face for
5261 extending the face to the end of the line.
5262 (display_line): Call extend_face_to_end_of_line when the default
5263 face was remapped. (Bug#11068)
5265 2012-03-29 Eli Zaretskii <eliz@gnu.org>
5267 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5269 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5271 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5273 2012-03-27 Glenn Morris <rgm@gnu.org>
5275 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5278 2012-03-26 Kenichi Handa <handa@m17n.org>
5280 * dispextern.h (struct glyph): Fix previous change. Change the
5281 bit length of glyphless.ch to 25 (Bug#11082).
5283 2012-03-26 Chong Yidong <cyd@gnu.org>
5285 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5286 (command_loop_1): Use it; inhibit selection update for
5287 handle-select-window too (Bug#8996).
5289 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5291 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
5293 2012-03-25 Kenichi Handa <handa@m17n.org>
5295 * dispextern.h (struct glyph): Change the bit length of
5296 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5298 2012-03-24 Eli Zaretskii <eliz@gnu.org>
5300 * s/ms-w32.h (tzname): Include time.h before redirecting to
5301 _tzname. Fixes the MSVC build. (Bug#9960)
5303 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5305 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5308 * xterm.c (XTread_socket): Only modify handling_signal if
5309 !SYNC_INPUT. (Bug#11080)
5311 2012-03-23 Eli Zaretskii <eliz@gnu.org>
5313 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5314 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5315 when fetching a multibyte character consumes more bytes than
5316 CHAR_BYTES returns, due to unification of CJK characters in
5317 string_char. (Bug#11073)
5319 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5321 * process.c (wait_reading_process_output): Handle pty disconnect
5322 by refraining from sending oneself a SIGCHLD (bug#10933).
5324 2012-03-22 Chong Yidong <cyd@gnu.org>
5326 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5328 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
5329 Mark string as coming from a prefix property.
5330 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5331 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5333 2012-03-21 Chong Yidong <cyd@gnu.org>
5335 * xfaces.c (Vface_remapping_alist): Doc fix.
5337 2012-03-20 Eli Zaretskii <eliz@gnu.org>
5339 * w32proc.c (Fw32_set_console_codepage)
5340 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5343 2012-03-20 Chong Yidong <cyd@gnu.org>
5345 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5346 to reflect default non-nil value of redisplay-dont-pause.
5348 2012-03-19 Kenichi Handa <handa@m17n.org>
5350 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5351 it fit in a valid range (Bug#11003).
5353 2012-03-18 Eli Zaretskii <eliz@gnu.org>
5355 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5356 that is not from display property, accept the row as a "cursor
5357 row" if one of the string's character has a non-nil `cursor'
5358 property. Fixes cursor positioning when there are newlines in
5359 overlay strings, e.g. in icomplete.el. (Bug#11035)
5361 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5363 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5365 2012-03-12 Chong Yidong <cyd@gnu.org>
5367 * eval.c (inhibit_lisp_code): Rename from
5368 inhibit_window_configuration_change_hook; move from window.c.
5370 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5371 * window.c (run_window_configuration_change_hook)
5372 (syms_of_window): Callers changed.
5374 2012-03-11 Chong Yidong <cyd@gnu.org>
5376 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5378 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5380 2012-03-10 Chong Yidong <cyd@gnu.org>
5382 * frame.c (other_visible_frames): Don't assume the selected frame
5383 is visible (Bug#10955).
5385 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5387 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5389 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5391 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5392 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5395 2012-03-03 Glenn Morris <rgm@gnu.org>
5397 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
5399 2012-03-02 Eli Zaretskii <eliz@gnu.org>
5401 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5402 position past the first glyph_row that ends at ZV. (Bug#10902)
5403 (redisplay_window, next_element_from_string): Fix typos in
5405 (redisplay_window): Pass to move_it_vertically the margin in
5406 pixels, not in screen lines.
5408 2012-03-02 Glenn Morris <rgm@gnu.org>
5410 * buffer.c (buffer-list-update-hook): Doc fix.
5412 2012-02-29 Eli Zaretskii <eliz@gnu.org>
5414 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5415 push_it before setting up the iterator for the first overlay
5416 string, even if we have an empty string loaded.
5417 (next_overlay_string): If there's an empty string on the iterator
5418 stack, pop the stack. (Bug#10903)
5420 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5422 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5423 Suggested by Stefan Monnier in
5424 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5425 * alloc.c (widen_to_Lisp_Object): New static function.
5426 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5427 and widening them to Lisp_Objects. This would work even if
5428 USE_LSB_TAG is defined and wide integers are used, which might
5429 happen in a future version of Emacs.
5431 2012-02-25 Chong Yidong <cyd@gnu.org>
5433 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5436 * xselect.c (Fx_selection_exists_p): Doc fix.
5437 (x_clipboard_manager_save_all): Print an informative message
5438 before saving to clipboard manager.
5440 2012-02-24 Chong Yidong <cyd@gnu.org>
5442 * keyboard.c (process_special_events): Handle all X selection
5443 requests in kbd_buffer, not just the next one (Bug#8869).
5445 2012-02-23 Chong Yidong <cyd@gnu.org>
5447 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5448 call when setting menu-bar-lines and tool-bar-lines parameters.
5449 (unwind_create_frame_1): New helper function.
5451 * window.c (inhibit_window_configuration_change_hook): New var.
5452 (run_window_configuration_change_hook): Obey it.
5453 (syms_of_window): Initialize it.
5455 2012-02-22 Chong Yidong <cyd@gnu.org>
5457 * xterm.c (x_draw_image_relief): Add missing type check for
5458 Vtool_bar_button_margin (Bug#10743).
5460 2012-02-21 Chong Yidong <cyd@gnu.org>
5462 * fileio.c (Vfile_name_handler_alist): Doc fix.
5464 * buffer.c (Fget_file_buffer): Protect against invalid file
5465 handler return value.
5467 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5469 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5470 when computing $valmask.
5472 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5473 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5474 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5475 It's useless in that case, and it can cause problems on hosts
5476 that allocate halves of EMACS_INT values separately.
5477 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5478 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5479 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5480 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5481 it avoids undefined behavior on hosts where shifting right by more
5482 than the word width has undefined behavior.
5484 2012-02-19 Chong Yidong <cyd@gnu.org>
5486 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5487 (Funhandled_file_name_directory, Ffile_name_as_directory)
5488 (Fdirectory_file_name, Fexpand_file_name)
5489 (Fsubstitute_in_file_name): Protect against invalid file handler
5490 return values (Bug#10845).
5492 2012-02-18 Eli Zaretskii <eliz@gnu.org>
5494 * .gdbinit (pitx): Fix incorrect references to fields of the
5497 2012-02-17 Chong Yidong <cyd@gnu.org>
5499 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5501 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5503 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5504 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5506 2012-02-15 Chong Yidong <cyd@gnu.org>
5508 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5509 marked as special. Also, starting docstrings with * is obsolete.
5511 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5513 * gnutls.c (emacs_gnutls_write): Fix last change.
5515 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5517 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5520 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5522 * keymap.c (Fsingle_key_description): Handle char ranges.
5524 2012-02-12 Chong Yidong <cyd@gnu.org>
5526 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5527 as that creates a dangerous corner case.
5529 * window.c (Fdelete_window_internal): Invalidate the mouse
5530 highlight (Bug#9904).
5532 2012-02-12 Glenn Morris <rgm@gnu.org>
5534 * xselect.c (Fx_own_selection_internal)
5535 (Fx_get_selection_internal, Fx_disown_selection_internal)
5536 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5537 * nsselect.m (Fx_own_selection_internal)
5538 (Fx_disown_selection_internal, Fx_selection_exists_p)
5539 (Fx_selection_owner_p, Fx_get_selection_internal):
5540 Sync docs and argument specs with the xselect.c versions.
5542 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5544 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5546 2012-02-11 Eli Zaretskii <eliz@gnu.org>
5548 * w32select.c (Fx_selection_exists_p): Sync doc string and
5549 argument list with xselect.c. (Bug#10783)
5551 * w16select.c (Fx_selection_exists_p): Sync doc string and
5552 argument list with xselect.c. (Bug#10783)
5554 2012-02-10 Glenn Morris <rgm@gnu.org>
5556 * fns.c (Fsecure_hash): Doc fix.
5558 2012-02-09 Kenichi Handa <handa@m17n.org>
5560 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5562 2012-02-07 Chong Yidong <cyd@gnu.org>
5564 * buffer.c (Fbuffer_local_variables)
5565 (buffer_lisp_local_variables): Handle unbound vars correctly;
5566 don't let Qunbound leak into Lisp.
5568 2012-02-07 Glenn Morris <rgm@gnu.org>
5570 * image.c (Fimagemagick_types): Doc fix.
5572 * image.c (imagemagick-render-type): Change it from a lisp object
5573 to an integer. Move the doc here from the lisp manual.
5574 Treat all values not equal to 0 the same.
5576 2012-02-06 Chong Yidong <cyd@gnu.org>
5578 * doc.c (store_function_docstring): Avoid applying docstring of
5579 alias to base function (Bug#2603).
5581 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5583 * .gdbinit (pp1, pv1): Remove redundant defines.
5586 2012-02-04 Chong Yidong <cyd@gnu.org>
5588 * nsterm.m: Declare a global (Bug#10694).
5590 2012-02-04 Eli Zaretskii <eliz@gnu.org>
5592 * w32.c (get_emacs_configuration_options):
5593 Include --enable-checking, if specified, in the return value.
5595 2012-02-04 Martin Rudalics <rudalics@gmx.at>
5597 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5598 after rounding frame sizes. (Bug#9723)
5600 2012-02-04 Eli Zaretskii <eliz@gnu.org>
5602 * keyboard.c (adjust_point_for_property): Don't position point
5603 before BEGV. (Bug#10696)
5605 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5607 Handle overflow when computing char display width (Bug#9496).
5608 * character.c (char_width): Return EMACS_INT, not int.
5609 (char_width, c_string_width): Check for overflow when
5610 computing the width; this is possible now that individual
5611 characters can have unbounded width. Problem introduced
5612 by merge from Emacs 23 on 2012-01-19.
5614 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
5616 * dbusbind.c (Fdbus_register_method): Mention the return value
5617 :ignore in the docstring.
5619 2012-02-02 Glenn Morris <rgm@gnu.org>
5621 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5623 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5624 Unconditionally set to t. (Bug#10673)
5625 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5626 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5627 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5629 2012-02-02 Kenichi Handa <handa@m17n.org>
5631 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5632 0, do not call append_composite_glyph.
5634 2012-02-02 Kenichi Handa <handa@m17n.org>
5636 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5638 (x_produce_glyphs): If the component of a composition is a null
5639 string, set it->pixel_width to 1 to avoid zero-width glyph.
5641 2012-02-01 Eli Zaretskii <eliz@gnu.org>
5643 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5644 first 2 arguments are identical. This makes inserting large
5645 output from a subprocess an order of magnitude faster on
5646 MS-Windows, where all sbrk'ed memory is always contiguous.
5648 2012-01-31 Glenn Morris <rgm@gnu.org>
5650 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5651 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5652 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5654 2012-01-29 Glenn Morris <rgm@gnu.org>
5656 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5658 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5660 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5662 2012-01-28 Chong Yidong <cyd@gnu.org>
5664 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5666 2012-01-26 Chong Yidong <cyd@gnu.org>
5668 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5670 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5671 repeat counts (Bug#10507).
5673 2012-01-26 Glenn Morris <rgm@gnu.org>
5675 * lread.c (syms_of_lread): Doc fix.
5677 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5679 * coding.c (encode_designation_at_bol): Change return value to
5682 2012-01-25 Chong Yidong <cyd@gnu.org>
5684 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5686 2012-01-21 Chong Yidong <cyd@gnu.org>
5688 * floatfns.c (Fcopysign): Make the second argument non-optional,
5689 since nil is not allowed anyway.
5691 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5693 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5694 (send_process): Likewise.
5696 2012-01-19 Martin Rudalics <rudalics@gmx.at>
5698 * window.c (save_window_save, Fcurrent_window_configuration)
5699 (Vwindow_persistent_parameters): Do not use Qstate.
5700 Rewrite doc-strings.
5702 2012-01-19 Kenichi Handa <handa@m17n.org>
5704 * character.c (char_width): New function.
5705 (Fchar_width, c_string_width, lisp_string_width):
5706 Use char_width (Bug#9496).
5708 2012-01-16 Martin Rudalics <rudalics@gmx.at>
5710 * window.c (Vwindow_persistent_parameters): New variable.
5711 (Fset_window_configuration, save_window_save): Handle persistent
5714 2012-01-14 Eli Zaretskii <eliz@gnu.org>
5716 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5717 thrashing the stack of the thread. (Bug#9087)
5719 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5721 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5723 2012-01-11 Eli Zaretskii <eliz@gnu.org>
5725 * xdisp.c (rows_from_pos_range): Handle the case where the
5726 highlight ends on a newline. (Bug#10464)
5727 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5728 he end column for display of highlight that ends on a newline
5731 2012-01-11 Glenn Morris <rgm@gnu.org>
5733 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5734 from load-path also when installation-directory is nil. (Bug#10208)
5736 2012-01-10 Glenn Morris <rgm@gnu.org>
5738 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5740 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5741 Update template values to be closer to their typical values these days.
5743 2012-01-09 Eli Zaretskii <eliz@gnu.org>
5745 * xdisp.c (rows_from_pos_range): Accept additional argument
5746 DISP_STRING, and accept any glyph in a row whose object is that
5747 string as eligible for mouse highlight. Fixes mouse highlight of
5748 display strings from overlays. (Bug#10464)
5750 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
5752 emacs: fix an auto-save permissions race condition (Bug#10400)
5753 * fileio.c (auto_saving_dir_umask): New static var.
5754 (Fmake_directory_internal): Use it.
5755 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5756 creating the directory. The old code temporarily assigns
5757 too-generous permissions to the directory.
5758 (do_auto_save_eh): Clear it.
5759 (Fdo_auto_save): Catch all errors, not just file errors, so
5760 that the var is always cleared.
5762 2012-01-07 Eli Zaretskii <eliz@gnu.org>
5764 * search.c (scan_buffer): Pass character positions to
5765 know_region_cache, not byte positions. (Bug#6540)
5767 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
5769 * w32.c (sys_rename): Report EXDEV when rename of a directory
5770 fails because the target is on another logical disk. (Bug#10284)
5772 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5774 * xterm.c (x_embed_request_focus): New function.
5776 * xterm.h: Add prototype.
5778 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5780 2012-01-05 Glenn Morris <rgm@gnu.org>
5782 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5784 2012-01-01 Eli Zaretskii <eliz@gnu.org>
5786 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5787 Load gnutls_transport_set_lowat only if GnuTLS version is below
5789 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5790 GnuTLS versions below 2.11.1.
5792 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5794 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5795 to the doc string advising against its use for altering the way
5796 windows are scrolled.
5798 2011-12-28 Kenichi Handa <handa@m17n.org>
5800 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5801 coding-system ASCII compatible only when it does not produce BOM
5802 on encoding (Bug#10383).
5804 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5806 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5808 (create_and_show_popup_menu): Always use menu_position_func for
5811 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5813 * callint.c (Fcall_interactively): Don't truncate prompt string.
5815 2011-12-23 Eli Zaretskii <eliz@gnu.org>
5817 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5818 property that ends at ZV, so that the bidi iteration could be
5819 resumed from there (after widening). (Bug#10360)
5821 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5823 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5825 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5827 * nsterm.m (x_free_frame_resources):
5828 Release f->output_data.ns->miniimage.
5829 (ns_index_color): Fix indentation. Do not retain
5830 color_table->colors[i].
5832 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5835 * nsfns.m (x_set_background_color): Assign return value from
5836 ns_index_color to face-background instead of NSColor*.
5837 (ns_implicitly_set_icon_type): Fix indentation.
5838 Change assignment in for loop to comparison.
5840 * emacs.c (ns_pool): New variable.
5841 (main): Assign ns_pool.
5842 (Fkill_emacs): Call ns_release_autorelease_pool.
5844 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5845 autorelease fdesc, release fdAttrs and tdict.
5846 (ns_get_covering_families): Release charset.
5847 (ns_findfonts): Release NSFontDescriptor created with new.
5848 (ns_uni_to_glyphs): Fix indentation.
5849 (setString): Release attrStr before assigning new value.
5851 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5853 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5855 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5856 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5858 2011-12-18 David Reitter <reitter@cmu.edu>
5860 * nsterm.m (ns_term_init): Subscribe for notifications
5861 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5862 to method trackingNotification in EmacsMenu.
5864 * nsmenu.m (trackingMenu): New variable.
5865 (trackingNotification): New method (from Aquamacs).
5866 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
5867 from Aquamacs (Bug#7030).
5869 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5871 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5872 (symbol_to_nsstring): Fix indentation.
5873 (ns_symbol_to_pb): New function.
5874 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5875 (Fns_rotate_cut_buffers_internal): Remove.
5876 (Fns_store_selection_internal): Rename from
5877 Fns_store_cut_buffer_internal.
5878 (ns_get_foreign_selection, Fx_own_selection_internal)
5879 (Fx_disown_selection_internal, Fx_selection_exists_p)
5880 (Fns_get_selection_internal, Fns_store_selection_internal):
5881 Use ns_symbol_to_pb and check if return value is nil.
5882 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5883 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
5884 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5885 renamed to Sns_store_selection_internal.
5886 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5887 and remove this function.
5888 (ns_handle_selection_clear): Remove, never used.
5889 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5892 2011-12-17 Ken Brown <kbrown@cornell.edu>
5894 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5895 GID is unknown (Bug#10257).
5897 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5899 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5900 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5901 which caused a build failure on GNU/Linux IA-64. This problem was
5902 introduced by my 2011-10-07 patch.
5904 2011-12-15 Juri Linkov <juri@jurta.org>
5906 * image.c (imagemagick_error): New function. (Bug#10112)
5907 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5908 Use `imagemagick_error' where ImageMagick functions return
5910 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5913 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5915 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5916 fill background (Bug#8992).
5918 2011-12-13 Martin Rudalics <rudalics@gmx.at>
5920 * window.c (Vwindow_combination_resize)
5921 (Vwindow_combination_limit): Use t instead of non-nil in
5923 (Vrecenter_redisplay): Add first sentence of doc-string on
5925 (Frecenter): Fix doc-string typo.
5927 2011-12-11 Kenichi Handa <handa@m17n.org>
5929 * coding.c (Funencodable_char_position): Pay attention to the
5930 buffer text relocation (Bug#9389).
5932 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5934 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5935 gtk_init (Bug#10100).
5937 2011-12-10 Eli Zaretskii <eliz@gnu.org>
5939 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5940 IT->string is nil. (Bug#10263)
5942 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5944 * nsterm.h (x_free_frame_resources): Declare.
5946 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5947 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5949 * nsterm.h (ns_get_defaults_value): Declare.
5951 * nsterm.m (ns_default): Call ns_get_defaults_value.
5953 2011-12-09 Eli Zaretskii <eliz@gnu.org>
5955 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5958 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5960 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5961 that where the value of an _OBJC_* symbol points to is in the .bss
5962 section (Bug#10240).
5964 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5966 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
5967 after the loop to call ccl_driver at least once (Bug#8619).
5969 2011-12-08 Kenichi Handa <handa@m17n.org>
5971 * ftfont.c (get_adstyle_property): Fix previous change
5974 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
5976 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5977 dirs from the default value of EMACSLOADPATH (bug#10208).
5979 2011-12-07 Glenn Morris <rgm@gnu.org>
5981 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5982 installation and source directories as well. (Bug#10208)
5984 2011-12-06 Chong Yidong <cyd@gnu.org>
5986 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5988 2011-12-06 Glenn Morris <rgm@gnu.org>
5990 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5991 as an error, not just -1. (Bug#10217)
5993 2011-12-05 Chong Yidong <cyd@gnu.org>
5995 * keyboard.c (process_special_events): New function.
5996 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5998 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
6000 * coding.c (encode_designation_at_bol): Don't use uninitialized
6001 local variable (Bug#9318).
6003 2011-12-05 Kenichi Handa <handa@m17n.org>
6005 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
6006 return Qnil (Bug#8046, Bug#10193).
6008 2011-12-05 Kenichi Handa <handa@m17n.org>
6010 * coding.c (encode_designation_at_bol): New args charbuf_end and
6011 dst. Return the number of produced bytes. Callers changed.
6012 (coding_set_source): Return how many bytes coding->source was
6014 (coding_set_destination): Return how many bytes
6015 coding->destination was relocated.
6016 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
6017 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
6019 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6021 * coding.c (CODING_CHAR_CHARSET_P): New macro.
6022 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
6025 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
6027 The following changes are to fix Bug#9318.
6029 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
6030 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
6031 (encode_coding_iso_2022, encode_coding_sjis)
6032 (encode_coding_big5, encode_coding_charset): Use the above macros.
6034 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
6036 * lisp.h (process_quit_flag): Fix external declaration.
6038 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
6040 Don't macro-inline non-performance-critical code.
6041 * eval.c (process_quit_flag): New function.
6042 * lisp.h (QUIT): Use it.
6044 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
6046 * nsfns.m (get_geometry_from_preferences): New function.
6047 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
6049 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
6051 * emacs.c (Qkill_emacs): Define.
6052 (syms_of_emacs): Initialize it.
6053 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
6054 Qquit_flag to `kill-emacs' instead.
6055 (quit_throw_to_read_char): Add parameter `from_signal'.
6056 All callers changed. Call Fkill_emacs if requested and safe.
6057 * lisp.h (QUIT): Call Fkill_emacs if requested.
6059 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
6061 * widget.c (update_wm_hints): Return if wmshell is null.
6062 (widget_update_wm_size_hints): New function.
6064 * widget.h (widget_update_wm_size_hints): Declare.
6066 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
6067 widget_update_wm_size_hints (Bug#10104).
6069 2011-12-03 Eli Zaretskii <eliz@gnu.org>
6071 * xdisp.c (handle_invisible_prop): If the invisible text ends just
6072 before a newline, prepare the bidi iterator for consuming the
6073 newline, and keep the current paragraph direction. (Bug#10183)
6074 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
6076 2011-12-02 Juri Linkov <juri@jurta.org>
6078 * search.c (Fword_search_regexp): New Lisp function created from
6079 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
6080 (Fword_search_backward, Fword_search_forward)
6081 (Fword_search_backward_lax, Fword_search_forward_lax):
6082 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
6083 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
6085 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
6087 * fileio.c (Finsert_file_contents): Move after-change-function call
6088 to before the "handled:" label, since all "goto handled" appear in
6089 cases where the *-change-functions have already been properly called
6092 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
6094 * keyboard.c (interrupt_signal): Don't call kill-emacs when
6095 waiting for input. (Bug#10169)
6097 2011-11-30 Eli Zaretskii <eliz@gnu.org>
6099 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
6100 verifies glyph row's hash code--we have just reallocated the
6101 glyphs, so their contents can be complete garbage. (Bug#10164)
6103 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
6105 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
6107 2011-11-30 Eli Zaretskii <eliz@gnu.org>
6109 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
6110 attributes are tested _before_ calling verify_row_hash, to protect
6111 against GCC re-ordering of the tests. (Bug#10164)
6113 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
6115 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
6117 * xterm.c (handle_one_xevent): Only set async_visible and friends
6118 if net_wm_state_hidden_seen is non-zero (Bug#10002)
6119 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
6120 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
6122 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
6124 Remove GCPRO-related macros that exist only to avoid shadowing locals.
6125 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
6126 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
6127 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6128 All uses changed to use GCPRO1 etc.
6129 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
6130 Revert to old implementation (i.e., before 2011-03-11).
6132 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6134 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
6135 of scroll runs so as to avoid assigning disabled bogus rows and
6136 unnecessary graphics copy operations.
6138 2011-11-27 Eli Zaretskii <eliz@gnu.org>
6140 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
6141 (snprintf) [_MSC_VER]: Redirect to _snprintf.
6142 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6143 (malloc, free, realloc, calloc): Redirect to e_* only when
6146 * lisp.h (GCTYPEBITS): Move before first use.
6147 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6148 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6149 this macro definition.
6151 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6154 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6156 * gtkutil.c (xg_create_frame_widgets):
6157 Call gtk_window_set_has_resize_grip (FALSE) if that function is
6158 present with Gtk+ 2.0.
6160 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6162 * fileio.c (Finsert_file_contents): Undo previous change; see
6163 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6165 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6167 Rename locals to avoid shadowing.
6168 * fileio.c (Finsert_file_contents):
6169 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6170 * process.c (wait_reading_process_output):
6171 Rename inner 'proc' to 'p' to avoid shadowing.
6172 Indent for consistency with usual Emacs style.
6174 2011-11-25 Eli Zaretskii <eliz@gnu.org>
6176 * xdisp.c (redisplay_window): If cursor row is not fully visible
6177 after recentering, and scroll-conservatively is set to a large
6178 number, scroll window by a few more lines to make the cursor fully
6179 visible and out of scroll-margin. (Bug#10105)
6180 (start_display): Don't move to the next line if the display should
6181 start at a newline that is part of a display vector or an overlay
6184 2011-11-24 Juri Linkov <juri@jurta.org>
6186 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6187 after the `MagickPingImage' call. (Bug#10112)
6189 2011-11-23 Chong Yidong <cyd@gnu.org>
6191 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6193 2011-11-23 Martin Rudalics <rudalics@gmx.at>
6195 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6196 making another buffer current. (Bug#10114)
6198 2011-11-23 Glenn Morris <rgm@gnu.org>
6200 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6202 2011-11-23 Chong Yidong <cyd@gnu.org>
6204 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6205 using it (Bug#5984).
6207 2011-11-22 Eli Zaretskii <eliz@gnu.org>
6209 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6210 and header-lines, as they don't have one computed for them.
6213 * .gdbinit (prow): Make displayed values more self-explaining.
6214 Add row's hash code.
6216 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6218 * process.c (wait_reading_process_output): Fix asynchrounous
6219 GnuTLS socket handling on some versions of the GnuTLS library.
6220 (wait_reading_process_output): Add comment and URL.
6222 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6224 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6226 2011-11-21 Chong Yidong <cyd@gnu.org>
6228 * window.c (Fnext_window, Fprevious_window): Doc fix.
6230 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6232 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6234 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
6236 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6238 2011-11-20 Martin Rudalics <rudalics@gmx.at>
6240 * window.c (Fset_window_combination_limit): Rename argument
6242 (Vwindow_combination_limit): Remove "status" from doc-string.
6244 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6246 * m/ibms390.h: Remove.
6247 * m/ibms390x.h: Don't include "ibms390.h".
6249 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6251 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6252 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6254 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
6256 * casetab.c (Fset_case_table):
6257 * charset.c (Fcharset_after): Fix typos.
6259 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6261 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6262 Otherwise, valgrind does not work on some platforms.
6263 Problem reported by Andreas Schwab in
6264 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6265 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6266 is set, removing the need for VIRT_ADDRESS_VARIES.
6267 (PURE_P): Use a more-efficient implementation that needs just one
6268 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6269 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6270 to 4 (xorl, subq, cmpq, setbe).
6271 * alloc.c (pure): Always extern now, since that's the
6272 VIRT_ADDR_VARIES behavior.
6273 (PURE_POINTER_P): Use a single comparison, not two, for
6274 consistency with the new puresize.h.
6275 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6276 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6277 Remove VIRT_ADDR_VARIES no longer needed.
6279 2011-11-19 Eli Zaretskii <eliz@gnu.org>
6281 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6282 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6283 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6284 behave as if the cursor position were at the window margin.
6286 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6287 and the cursor position is out of bounds, behave as if the cursor
6288 position were at the window margin. (Bug#10075)
6290 2011-11-18 Chong Yidong <cyd@gnu.org>
6292 * window.c (Fwindow_combination_limit): Make first argument
6293 non-optional, since it is meaningless for live windows like the
6296 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6298 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6300 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6302 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6303 (graft_intervals_into_buffer): Simplify.
6305 2011-11-18 Eli Zaretskii <eliz@gnu.org>
6307 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6308 hash values of the two rows.
6309 (copy_row_except_pointers): Preserve the used[] arrays and the
6310 hash values of the two rows. (Bug#10035)
6311 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
6313 * xdisp.c (row_hash): New function, body extracted from
6314 compute_line_metrics.
6315 (compute_line_metrics): Call row_hash, instead of computing the
6318 * dispnew.c (verify_row_hash): Call row_hash for computing the
6319 hash code of a row, instead of duplicating code from xdisp.c.
6321 * dispextern.h (row_hash): Add prototype.
6323 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6325 * frame.c (delete_frame): Don't delete the terminal when the last
6326 X frame is closed if emacs is built with GTK toolkit.
6328 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
6330 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6332 2011-11-17 Martin Rudalics <rudalics@gmx.at>
6334 * window.c (Vwindow_splits): Rename to
6335 Vwindow_combination_resize. Suggested by Juri Linkov.
6336 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6339 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
6341 * nsfns.m (Fns_font_name):
6342 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
6344 2011-11-16 Martin Rudalics <rudalics@gmx.at>
6346 * window.h (window): Rename slot "nest" to "combination_limit".
6347 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6348 (Fset_window_nest): Rename to Fset_window_combination_limit.
6349 (Vwindow_nest): Rename to Vwindow_combination_limit.
6350 (recombine_windows, make_parent_window, make_window)
6351 (Fsplit_window_internal, saved_window)
6352 (Fset_window_configuration, save_window_save): Rename all
6353 occurrences of window_nest to window_combination_limit.
6355 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
6357 * image.c (imagemagick_load_image): Fix typo.
6359 2011-11-14 Eli Zaretskii <eliz@gnu.org>
6361 * xdisp.c (display_line): Move the call to
6362 highlight_trailing_whitespace before the call to
6363 compute_line_metrics, since the latter needs to see the final
6364 faces of all the glyphs to compute ROW's hash value.
6365 Fixes assertion violations in row_equal_p. (Bug#10035)
6367 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
6369 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6370 just return (bug#10044).
6372 2011-11-12 Eli Zaretskii <eliz@gnu.org>
6374 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6375 with user-defined heap size. Bump the default size of the temacs
6376 heap to 27MB, to avoid memory warning when running temacs.
6377 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6379 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6380 current_matrix and desired_matrix. (Bug#9990)
6381 (verify_row_hash) [XASSERTS]: New function.
6382 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6383 that the hash value of glyph rows is correct.
6385 2011-11-12 Martin Rudalics <rudalics@gmx.at>
6387 * window.h (window): Remove splits slot.
6388 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6389 (Fdelete_other_windows_internal, make_parent_window)
6390 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6391 (Fset_window_configuration, save_window_save): Don't deal with
6392 split status of windows.
6393 (saved_window): Remove splits slot.
6394 (Vwindow_splits): Rewrite doc-string.
6396 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6398 * xfns.c (unwind_create_frame):
6399 * nsfns.m (unwind_create_frame):
6400 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6401 Vframe_list (Bug#9999).
6403 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6405 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
6407 2011-11-11 Kenichi Handa <handa@m17n.org>
6409 * callproc.c (Fcall_process): Set the member dst_multibyte of
6412 2011-11-11 Johan Bockgård <bojohan@gnu.org>
6414 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6415 avoid a crash (bug#9496).
6417 2011-11-09 Chong Yidong <cyd@gnu.org>
6419 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6420 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6422 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6424 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6426 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6428 Avoid some portability problems by eschewing 'extern inline' functions.
6429 The trivial performance wins aren't worth the portability hassles; see
6430 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6432 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6433 (window_box_width, window_box_left, window_box_left_offset)
6434 (window_box_right, window_box_right_offset): Undo previous change,
6435 by removing the "extern"s.
6436 * intervals.c (adjust_intervals_for_insertion)
6437 (adjust_intervals_for_deletion): Undo previous change,
6438 making these static again.
6439 (offset_intervals, temp_set_point_both, temp_set_point)
6440 (copy_intervals_to_string): No longer inline.
6441 * xdisp.c (window_text_bottom_y, window_box_width)
6442 (window_box_height, window_box_left_offset)
6443 (window_box_right_offset, window_box_left, window_box_right)
6444 (window_box): No longer inline.
6446 2011-11-08 Chong Yidong <cyd@gnu.org>
6448 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6449 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6450 Signal an error if not a live window.
6451 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6452 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6454 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
6456 * lisp.h (syms_of_abbrev): Remove declaration.
6457 Reported by CHENG Gao <chenggao@royau.me>.
6459 2011-11-07 Eli Zaretskii <eliz@gnu.org>
6461 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6462 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6463 of temacs in GUI mode.
6465 2011-11-07 Martin Rudalics <rudalics@gmx.at>
6467 * window.h: Declare delete_all_child_windows instead of
6468 delete_all_subwindows.
6469 * window.c (Fwindow_nest, Fset_window_nest)
6470 (Fset_window_new_total, Fset_window_new_normal)
6471 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6472 (delete_all_subwindows): Rename to delete_all_child_windows.
6473 (Fdelete_other_windows_internal, Fset_window_configuration):
6474 Call delete_all_child_windows instead of delete_all_subwindows.
6475 * frame.c (delete_frame): Call delete_all_child_windows instead
6476 of delete_all_subwindows.
6478 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6480 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6481 This is also needed for porting to any host where GC_MARK_STACK is
6482 not GC_MAKE_GCPROS_NOOPS.
6483 (which_symbols): Use it.
6485 2011-11-07 Kenichi Handa <handa@m17n.org>
6487 * coding.c (coding_set_destination): Check coding->src_pos only
6488 when coding->src_object is a buffer (bug#9910).
6490 * process.c (send_process): Set the member src_multibyte of coding
6491 to 0 (bug#9911) when sending a unibyte text.
6493 * callproc.c (Fcall_process): Set the member src_multibyte of
6494 process_coding to 0 (bug#9912).
6496 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6498 * xmenu.c (cleanup_widget_value_tree): New function.
6499 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6500 calling free_menubar_widget_value_tree directly (Bug#9830).
6502 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6504 Fix some portability problems with 'inline'.
6505 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6506 (window_box_width, window_box_left, window_box_left_offset)
6507 (window_box_right, window_box_right_offset): Declare extern.
6508 Otherwise, these inline functions do not conform to C99 and
6509 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6510 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6511 * intervals.c (adjust_intervals_for_insertion)
6512 (adjust_intervals_for_deletion): Now extern, because otherwise the
6513 extern inline functions 'offset_intervals' couldn't refer to it.
6514 (static_offset_intervals): Remove.
6515 (offset_intervals): Rewrite using the old contents of
6516 static_offset_intervals. The old version didn't conform to C99
6517 because an extern inline function contained a reference to an
6518 identifier with static linkage.
6520 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6522 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6525 2011-11-06 Eli Zaretskii <eliz@gnu.org>
6527 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6528 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6529 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6530 return Qleft_to_right.
6532 2011-11-06 Chong Yidong <cyd@gnu.org>
6534 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6535 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6536 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6537 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6538 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6539 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6540 (Fwindow_vscroll): Doc fix.
6541 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6542 argument, since it makes no sense to pass a live window and for
6543 consistency with window-child.
6545 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6547 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6550 2011-11-05 Jason Rumney <jasonr@gnu.org>
6552 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6553 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6555 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6556 bitwise arithmetic preventing use of unicode-sip and non-truetype
6559 2011-11-05 Eli Zaretskii <eliz@gnu.org>
6561 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6564 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6565 initialization code to keep similarity to xfns.c after changes
6568 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6570 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6571 (unwind_create_frame): New function (Bug#9943).
6572 (Fx_create_frame): Restructure code to be more similar to the one in
6573 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6574 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6575 Move terminal->reference_count++ just before making the frame official
6578 * nsterm.m (x_free_frame_resources): New function.
6579 (x_destroy_window): Move code to x_free_frame_resources.
6581 * xfns.c (unwind_create_frame): Fix comment.
6582 (Fx_create_frame, x_create_tip_frame):
6583 Move terminal->reference_count++ just before making the frame
6584 official. Move initialization of image_cache_refcount and
6585 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6587 2011-11-05 Eli Zaretskii <eliz@gnu.org>
6589 Support MSVC build with newer versions of Visual Studio.
6590 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6591 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6594 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6595 which are not supported by MSVC.
6596 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6597 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6599 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6601 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6603 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6605 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
6607 Support MSVC build with newer versions of Visual Studio.
6608 * w32.c: Don't include w32api.h for MSVC.
6609 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6611 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6612 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6613 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6614 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6616 (alloca) [_MSC_VER]: Define to _alloca.
6618 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6620 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6622 2011-11-04 Eli Zaretskii <eliz@gnu.org>
6624 * xdisp.c (note_mouse_highlight): If either of
6625 previous/next-single-property-change returns nil, treat that as
6626 the beginning or the end of the buffer. (Bug#9955)
6628 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6630 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
6631 label is not null (Bug#9951).
6632 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6635 2011-11-04 Eli Zaretskii <eliz@gnu.org>
6637 * window.c (Fwindow_body_size): Mention in the doc string that the
6638 return value is in frame's canonical units. (Bug#9949)
6640 2011-11-03 Eli Zaretskii <eliz@gnu.org>
6642 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6644 * w32fns.c (unwind_create_frame): If needed, free the glyph
6645 matrices of the partially constructed frame. (Bug#9943)
6646 * xfns.c (unwind_create_frame): Likewise.
6648 2011-11-01 Eli Zaretskii <eliz@gnu.org>
6650 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6651 Don't stop backward scan on the continuation glyph, even though
6652 its CHARPOS is positive.
6653 (mouse_face_from_buffer_pos, note_mouse_highlight):
6654 Rename cover_string to disp_string.
6656 2011-11-01 Martin Rudalics <rudalics@gmx.at>
6658 * window.c (temp_output_buffer_show): Don't use
6659 Vtemp_buffer_show_specifiers.
6660 (Vtemp_buffer_show_specifiers): Remove unused variable.
6662 2011-10-30 Eli Zaretskii <eliz@gnu.org>
6664 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6665 past the beginning of the current glyph matrix.
6667 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6669 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6670 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6671 HAVE_GTK3 (Bug#9869).
6673 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6674 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6676 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6678 * xterm.c: Declare x_handle_net_wm_state to return int.
6679 (handle_one_xevent): Check if we are iconified but don't have
6680 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6681 (get_current_wm_state): Return non-zero if not hidden,
6682 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6683 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6684 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6685 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6687 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6689 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6690 so that this new function doesn't get optimized away by a
6691 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6693 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6695 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6697 2011-10-29 Eli Zaretskii <eliz@gnu.org>
6699 Fix the `xbytecode' command.
6700 * .gdbinit (xprintbytestr): New command.
6701 (xwhichsymbols): Rename from `which'; all callers changed.
6702 (xbytecode): Print the byte-code string as well.
6704 2011-10-29 Kim Storm <storm@cua.dk>
6706 * alloc.c (which_symbols): New function.
6708 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6710 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6713 2011-10-29 Glenn Morris <rgm@gnu.org>
6715 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6716 Not clear what it was for, and it causes various bugs. (Bug#9839)
6718 2011-10-28 Eli Zaretskii <eliz@gnu.org>
6720 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6721 possible random value that matches one of those tested as
6722 condition to clear the mouse face.
6724 2011-10-28 Chong Yidong <cyd@gnu.org>
6726 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6728 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6730 * window.c (make_window): Initialize phys_cursor_on_p.
6732 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6734 * lisp.h (struct Lisp_Symbol): Update comments.
6736 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
6738 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6740 2011-10-28 Eli Zaretskii <eliz@gnu.org>
6742 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6743 <oslsachem@gmail.com> for helping to debug this.
6745 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6746 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6747 (g_b_init_get_glyph_outline_w): New static variables.
6748 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6749 (GetGlyphOutlineW_Proc): New typedefs.
6750 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
6751 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6753 (w32font_open_internal, compute_metrics):
6754 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
6755 instead of calling the "wide" APIs directly.
6757 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6759 * w32.h (syms_of_w32font): Add prototype.
6761 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
6763 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6764 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6765 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6766 (Fmove_to_window_line): Doc fix.
6768 2011-10-27 Chong Yidong <cyd@gnu.org>
6770 * process.c (make_process): Set gnutls_state to NULL.
6772 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6773 non-NULL, regardless of GNUTLS_INITSTAGE.
6774 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6775 an error. Set process slots as soon as we allocate them.
6777 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6779 2011-10-27 Chong Yidong <cyd@gnu.org>
6781 * gnutls.c (emacs_gnutls_deinit): New function.
6782 Deallocate credentials structures as well as calling gnutls_deinit.
6783 (Fgnutls_deinit, Fgnutls_boot): Use it.
6785 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6786 (deactivate_process): Call emacs_gnutls_deinit.
6788 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
6790 * image.c (x_create_x_image_and_pixmap):
6791 * w32.c (sys_rename, w32_delayed_load):
6792 * w32font.c (fill_in_logfont):
6793 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6795 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
6797 * w32fns.c (w32_default_color_map): New function,
6798 extracted from Fw32_default_color_map.
6799 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
6801 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6803 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6805 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6807 * keyboard.c (test_undefined): New function (bug#9751).
6808 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6810 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6812 * sysdep.c (init_sys_modes): Fix the check for the controlling
6813 terminal (Bug#6649).
6815 2011-10-20 Eli Zaretskii <eliz@gnu.org>
6817 * dispextern.h (struct bidi_it): New member next_en_type.
6819 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6820 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6821 current character, check also for next_en_type being WEAK_EN.
6822 (bidi_resolve_weak): Don't enter the expensive loop if the current
6823 position is before next_en_pos. Record the bidi type of the first
6824 non-ET, non-BN character we find, in addition to its position.
6825 (bidi_level_of_next_char): Invalidate next_en_type when
6826 next_en_pos is over-stepped.
6828 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6830 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6831 * editfns.c: Rewrite current-time-zone so that it invokes
6832 the equivalent of (format-time-string "%Z") to get the time zone name.
6833 This fixes a bug when the time zone name contains characters that
6834 need converting from the system time locale to Emacs internal format.
6835 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6836 that patch fixed format-time-string to do the conversion, but
6837 I forgot to fix current-time-zone.
6838 (format_time_string): New function, containing most of
6839 what Fformat_time_string used to contain.
6840 (Fformat_time_string): Rewrite in terms of format_time_string.
6841 This doesn't change this function's behavior.
6842 (current-time-zone): Rewrite to use format_time_string.
6843 This fixes the bug reported by Michael Schierl in
6844 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6845 Jason Rumney's 2007-06-07 change worked around this bug, but
6847 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6849 2011-10-19 Eli Zaretskii <eliz@gnu.org>
6851 * xdisp.c (start_display): If the character at POS is displayed
6852 via a display vector, reset IT->current.dpvec_index to zero.
6853 (try_window_reusing_current_matrix): If a line ends in a display
6854 vector or the next line starts in a display vector, continue
6855 redrawing the window even though the character position of
6856 start_row was reached.
6859 2011-10-18 Chong Yidong <cyd@gnu.org>
6861 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6862 with nobreak-char-display too.
6864 2011-10-18 Eli Zaretskii <eliz@gnu.org>
6866 Fix part 3 of bug#9771.
6867 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6868 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6869 non-neutral characters if the current character is a paragraph
6870 separator (a.k.a. Newline). This avoids running the same
6871 expensive loop twice, once when we consume the preceding newline
6872 and the other time when the line actually needs to be displayed.
6873 Avoid the loop when we see neutrals on the base embedding level
6874 following a character whose directionality is the same as the
6875 paragraph's. This avoids running the expensive loop when a line
6876 ends in a long sequence of neutrals, like control characters.
6877 Add assertion against STRONG_AL type. Slightly rearrange code
6878 that determines the type of a neutral given the first non-neutral
6880 (bidi_level_of_next_char): Set next_en_pos to zero when
6881 invalidating its info.
6883 2011-10-17 Eli Zaretskii <eliz@gnu.org>
6885 * xdisp.c (push_display_prop): Determine whether to record string
6886 or buffer position by IT->string, not by IT->method. Allow
6887 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
6888 (move_it_vertically_backward): Don't look for character position
6889 immediately after the newline when in a continuation line.
6892 2011-10-15 Martin Rudalics <rudalics@gmx.at>
6894 * window.c (coordinates_in_window): Rewrite and delabelize
6895 vertical border check. (Bug#5357) (Bug#9618)
6897 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6899 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6900 errors in XSetWindowBorder (bug#9310).
6902 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6904 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6905 avoid crash when xmalloc overrun checking is enabled.
6907 2011-10-13 Eli Zaretskii <eliz@gnu.org>
6909 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6910 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6911 cursor motion with <left> and <right> arrow keys.
6913 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6914 some callers set that themselves.
6916 2011-10-12 Eli Zaretskii <eliz@gnu.org>
6918 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6919 display string and the previous row comes from the same string and
6920 is empty. (Bug#9739) (Bug#9738)
6922 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6924 * doc.c (get_doc_string): Encode file name (bug#9735).
6926 2011-10-12 Eli Zaretskii <eliz@gnu.org>
6928 * bidi.c (bidi_level_of_next_char):
6929 * xdisp.c (get_visually_first_element): Remove old incorrect
6930 comments regarding the Unicode Line Separator character.
6932 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6934 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6936 * alloc.c (Fgc_status): Do not access beyond zombies array
6937 boundary if nzombies > MAX_ZOMBIES.
6938 * alloc.c (dump_zombies): Add missing format specifier.
6940 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6942 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6943 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6945 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6946 Some packages use them to denote characters with modifiers.
6948 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6950 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6951 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6952 matching a pp-number. Rename parameter var to var1.
6954 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6956 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6958 2011-10-08 Glenn Morris <rgm@gnu.org>
6960 * callint.c (Fcall_interactively): Give a more explicit error for the
6961 'c' case with a non-character input. (Bug#8479)
6963 2011-10-08 Eli Zaretskii <eliz@gnu.org>
6965 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6967 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6968 lines that are hscrolled on the left.
6970 * dispnew.c (buffer_posn_from_coords): Account for a possible
6971 presence of header-line. (Bug#4426)
6973 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6975 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6976 Don't advertise functionality which we discourage or doesn't work.
6978 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6980 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6981 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6982 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6983 this makes Emacs dump core during garbage collection on rare
6984 occasions. sizeof is obviously inferior to offsetof here, so
6985 stick with offsetof.
6986 (GC_POINTER_ALIGNMENT): New macro.
6987 (mark_memory): Omit 3rd (offset) arg; caller changed.
6988 Don't assume EMACS_INT alignment is the same as pointer alignment.
6990 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6992 * keyboard.c (read_key_sequence_remapped): New var.
6993 (read_key_sequence): Compute remapping in the right buffer.
6994 (command_loop_1): Use read_key_sequence's remapping directly.
6996 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6998 * dired.c (file_name_completion): Don't expand file name.
6999 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
7000 before checking file name handler.
7002 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
7003 they've been requested explicitly (bug#9591).
7005 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
7007 * keymap.c (Fsingle_key_description): Use make_specified_string
7008 instead of build_string to build string from push_key_description.
7011 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7013 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
7014 This fixes a Y2038 bug on 64-bit hosts.
7015 * buffer.c (reset_buffer):
7016 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
7017 (Fclear_buffer_auto_save_failure):
7018 Use 0, not -1, to represent an unset failure time, since time_t
7019 might not be signed.
7021 Remove dependency on glibc malloc internals.
7022 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7023 Move back here from lisp.h, but with their new implementations.
7024 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7025 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
7026 * charset.c (charset_table_init): New static var.
7027 (syms_of_charset): Use it instead of xmalloc. This removes a
7028 dependency on glibc malloc internals. See Eli Zaretskii's comment in
7029 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
7030 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7031 Move back to alloc.c.
7032 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7033 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
7035 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
7037 * nsterm.m (windowDidResize): Call x_set_window_size only when
7038 ns_in_resize is true. Otherwise set pixelwidth/height and
7039 call change_frame_size (Bug#9628).
7041 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7043 Port --enable-checking=all to Fedora 14 x86-64.
7044 * charset.c (syms_of_charset): Also account for glibc malloc's
7045 internal overhead when calculating the initial malloc maximum.
7047 Port --enable-checking=all to Fedora 14 x86.
7048 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7050 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
7051 (overrun_check_realloc, overrun_check_free):
7052 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
7053 That way, xmalloc returns a properly-aligned pointer even if
7054 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
7055 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
7056 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
7057 into account when calculating the initial malloc maximum.
7058 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7059 Move here from alloc.c, so that charset.c can use it too.
7060 Properly align; the old code wasn't right for common 32-bit hosts
7061 when configured with --enable-checking=all.
7062 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7063 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
7065 2011-09-29 Eli Zaretskii <eliz@gnu.org>
7067 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
7070 2011-09-28 Eli Zaretskii <eliz@gnu.org>
7072 * xdisp.c (compute_display_string_end): If there's no display
7073 string at CHARPOS, return -1.
7075 * bidi.c (bidi_fetch_char): When compute_display_string_end
7076 returns a negative value, treat the character as a normal
7077 character not covered by a display string. (Bug#9624)
7079 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
7081 * lread.c (Fread_from_string): Fix typo in docstring.
7083 2011-09-27 Eli Zaretskii <eliz@gnu.org>
7085 * xdisp.c (handle_invisible_prop): If invisible text ends on a
7086 newline, reseat the iterator instead of bidi-iterating there one
7087 character at a time. (Bug#9610)
7088 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
7089 TO_CHARPOS if the bidi iterator is at base embedding level.
7091 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
7093 * lread.c (readevalloop): Use correct code for NBSP.
7094 (read1): Likewise. (Bug#9608)
7096 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
7098 * dbusbind.c (Fdbus_register_signal): When service is not
7099 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
7101 2011-09-25 Glenn Morris <rgm@gnu.org>
7103 * buffer.c (truncate-lines): Doc fix.
7105 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
7107 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
7108 (Fset_window_next_buffers): Doc fix.
7110 2011-09-24 Glenn Morris <rgm@gnu.org>
7112 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
7114 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
7116 Fix minor problems found by static checking.
7117 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
7118 * indent.c (Fvertical_motion): Fix == vs = typo.
7120 2011-09-24 Eli Zaretskii <eliz@gnu.org>
7122 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
7123 Default value is now t. Doc fix.
7125 * indent.c (Fvertical_motion): Compute and apply the overshoot
7126 logic when moving up, not only when moving down. Fix the
7127 confusing name and values of the it_overshoot_expected variable;
7128 logic changes accordingly. (Bug#9254) (Bug#9549)
7130 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
7131 CHARPOS is covered by a display string which includes newlines.
7132 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
7133 is covered by a display string with embedded newlines.
7135 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
7137 * dbusbind.c (Fdbus_register_signal): Add match rule to
7138 Vdbus_registered_objects_table. (Bug#9581)
7139 (Fdbus_register_method, Vdbus_registered_objects_table):
7142 2011-09-24 Jim Meyering <meyering@redhat.com>
7144 do not ignore write error for any output size
7145 The previous change was incomplete.
7146 While it makes emacs --batch detect the vast majority of stdout
7147 write failures, errors were still ignored whenever the output size is
7148 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7149 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7150 && echo FAIL: ignored write error
7151 FAIL: ignored write error
7152 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7153 && echo FAIL: ignored write error
7154 FAIL: ignored write error
7155 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7157 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7159 * emacs.c (Fkill_emacs): In noninteractive mode exit
7160 non-successfully if a write error occurred on stdout. (Bug#9574)
7162 2011-09-21 Eli Zaretskii <eliz@gnu.org>
7164 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7167 * dispextern.h (struct it): Update the comment documenting what
7170 2011-09-20 Eli Zaretskii <eliz@gnu.org>
7172 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7173 a display string, extend search for cursor position to end of row.
7174 (find_row_edges): If the row ends in a newline from a display
7175 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7176 Handle the case of a display string with multiple newlines.
7177 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7178 non-empty line. Fixes confusing cursor motion with arrow keys at
7179 the beginning of a line that starts with whitespace.
7181 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7183 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7186 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
7188 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7191 2011-09-18 Eli Zaretskii <eliz@gnu.org>
7193 * xdisp.c (display_line): Record maximum and minimum buffer
7194 positions even if no glyphs were produced (e.g., by a zero-width
7195 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7196 buffer positions that will be removed from the glyph row because
7198 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7199 column is beyond frame width: don't subtract 1 "pixel" when
7200 computing width of the stretch.
7201 (reseat_at_next_visible_line_start): Undo the change made on
7202 2011-09-17 that saved paragraph information and restored it after
7203 the call to `reseat'. (Bug#9545)
7205 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7207 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7208 and turn window cursor on if cleared (Bug#9415).
7210 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
7212 * search.c (boyer_moore): Take unibyte characters from pattern
7213 literally. (Bug#9458)
7215 2011-09-18 Eli Zaretskii <eliz@gnu.org>
7217 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7219 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7221 Fix minor problem found by static checking.
7222 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7223 initialized, to pacify gcc -Wuninitialized.
7225 * fileio.c: Report proper errno when syscall falls.
7226 (Finsert_file_contents): Save and restore errno,
7227 so that report_file_error outputs the correct diagnostic.
7228 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7230 2011-09-18 Eli Zaretskii <eliz@gnu.org>
7232 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7234 2011-09-17 Eli Zaretskii <eliz@gnu.org>
7236 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7237 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7239 2011-09-17 Eli Zaretskii <eliz@gnu.org>
7241 * xdisp.c (reseat_at_next_visible_line_start): Keep information
7242 about the current paragraph and restore it after the call to reseat.
7244 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7245 (bidi_find_paragraph_start): Search back for paragraph beginning
7246 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7247 (bidi_move_to_visually_next): Only trigger paragraph-related
7248 computations when the last character is a newline or at EOB, not
7249 just any NEUTRAL_B. (Bug#9470)
7251 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7252 truncated lines if point is covered by a display string. (Bug#9524)
7254 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7256 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7257 (cons_to_x_long): New function.
7258 (lisp_data_to_selection_data): Use it. Correct the test for
7259 short-versus-long data; it was negated. Break out of vector
7260 loop, for efficiency, when a long datum is discovered.
7262 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7264 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7266 2011-09-16 Eli Zaretskii <eliz@gnu.org>
7268 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7269 GCC PR/17406) by declaring this function with external scope.
7271 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7273 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7274 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7276 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7278 * editfns.c (Fformat): Correctly handle text properties on "%%".
7280 2011-09-15 Eli Zaretskii <eliz@gnu.org>
7282 * xterm.c (x_draw_composite_glyph_string_foreground):
7283 * w32term.c (x_draw_composite_glyph_string_foreground):
7284 * term.c (encode_terminal_code):
7285 * composite.c (composition_update_it, get_composition_id):
7286 * xdisp.c (get_next_display_element)
7287 (fill_composite_glyph_string): Add comments about special meaning
7288 of TAB characters in a composition.
7290 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7292 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
7293 This occurs when processing a multibyte format.
7294 Problem reported by Wolfgang Jenker.
7296 2011-09-15 Johan Bockgård <bojohan@gnu.org>
7298 * xdisp.c (try_cursor_movement): Only check for exact match if
7299 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7301 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7303 Remove unused external symbols.
7304 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7305 * xdisp.c (calc_pixel_width_or_height): Now static.
7306 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7307 * indent.c (check_display_width):
7308 * w32term.c: Fix comment to match code.
7309 * xterm.c, xterm.h (x_catching_errors): Remove.
7311 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7313 * xselect.c: Use signed conversions more consistently (Bug#9498).
7314 (selection_data_to_lisp_data): Assume incoming selection data are
7315 signed integers, not unsigned. This is to be consistent with
7316 outgoing selection data, which was modified to use signed integers
7317 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7318 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7319 expects long, not unsigned long.
7321 2011-09-14 Eli Zaretskii <eliz@gnu.org>
7323 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7324 computation of loop end. Reported by Johan Bockgård
7327 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
7329 * frame.c (Fother_visible_frames_p): Function deleted.
7331 2011-09-12 Eli Zaretskii <eliz@gnu.org>
7333 * indent.c (compute_motion): Process display vector front to back
7334 rather than the other way around. (Bug#2496)
7336 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7338 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7340 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
7342 * minibuf.c (Fread_from_minibuffer): Doc fix.
7344 2011-09-11 Eli Zaretskii <eliz@gnu.org>
7346 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7347 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7349 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7351 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7352 value for non-existent files.
7354 2011-09-11 Eli Zaretskii <eliz@gnu.org>
7356 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7357 set its "size" to -1. This will set the modtime_size field of
7358 the corresponding buffer to -1, which is what
7359 verify-visited-file-modtime expects for files that do not exist.
7362 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7364 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7366 * lisp.h: ... from here. push_key_description is no longer
7367 defined in keyboard.c, so its declaration should not be in
7368 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7369 logically belongs with push_key_description.
7371 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7373 * buffer.h: Include <sys/types.h> instead of <time.h>.
7374 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7375 Problem reported by Herbert J. Skuhra.
7377 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7379 * xml.c (parse_region): Make the parsing work for
7380 non-comment-starting XML files again (bug#9144).
7382 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7384 * image.c (gif_load): Fix calculation of bottom and right corner.
7387 2011-09-10 Eli Zaretskii <eliz@gnu.org>
7389 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7390 redisplay in small windows.
7392 2011-09-09 Eli Zaretskii <eliz@gnu.org>
7394 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7396 2011-09-08 Martin Rudalics <rudalics@gmx.at>
7398 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7399 Operate on live windows only.
7401 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
7403 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7405 2011-09-07 Eli Zaretskii <eliz@gnu.org>
7407 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7408 only under bidi iteration.
7410 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7412 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7414 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7416 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7417 Without this fix, the command to link temacs failed due to an
7418 undefined symbol __builtin_isnan. This is because
7419 /usr/include/iso/math_c99.h #defines isnan(x) to
7420 __builtin_isnan(x), but the bundled gcc, which identifies itself
7421 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7423 * floatfns.c (isnan): #undef, and then #define to a clone of
7425 (Fisnan): Always define, since it's always available now.
7426 (syms_of_floatfns): Always define isnan at the Lisp level.
7428 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7430 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7432 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7434 * fileio.c: Fix bugs with large file offsets (Bug#9428).
7435 The previous code assumed that file offsets (off_t values) fit in
7436 EMACS_INT variables, which is not true on typical 32-bit hosts.
7437 The code messed up by falsely reporting buffer overflow in cases
7438 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7439 when "big" contains more than 2**29 bytes, even though this
7440 inserts just one byte and does not overflow the buffer.
7441 (Finsert_file_contents): Store file offsets as off_t
7442 values, not as EMACS_INT values. Check for overflow when
7443 converting between EMACS_INT and off_t. When checking for
7444 buffer overflow or for overlap, take the offsets into account.
7445 Don't use EMACS_INT for small values where int suffices.
7446 When checking for overlap, fix a typo: ZV was used where
7447 ZV_BYTE was intended.
7448 (Fwrite_region): Don't assume off_t fits into 'long'.
7449 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7451 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
7453 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7455 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7457 sprintf-related integer and memory overflow issues (Bug#9412).
7459 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
7460 (esprintf, exprintf, evxprintf): New functions.
7461 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
7462 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
7463 (modify_event_symbol): Do not assume that the length of
7464 name_alist_or_stem is safe to alloca and fits in int.
7465 (Fexecute_extended_command): Likewise for function name and binding.
7466 (Frecursion_depth): Wrap around reliably on integer overflow.
7467 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7468 since some callers pass EMACS_INT values.
7469 (Fsingle_key_description): Don't crash if symbol name contains more
7470 than MAX_ALLOCA bytes.
7471 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7472 (get_minibuffer): Arg is now EMACS_INT, not int.
7473 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
7474 (esprintf, exprintf, evxprintf): New decls.
7475 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7477 * dbusbind.c (signature_cat): New function.
7478 (xd_signature, Fdbus_register_signal):
7479 Do not overrun buffer; instead, report string overflow.
7481 * dispnew.c (add_window_display_history): Don't overrun buffer.
7482 Truncate instead; this is OK since it's just a log.
7484 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7485 even if the time zone offset is outlandishly large.
7486 Don't mishandle offset == INT_MIN.
7488 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7489 when creating daemon; the previous buffer-overflow check was incorrect.
7491 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7492 which has the guts of the old verror function.
7494 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7495 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7497 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7498 (font_unparse_xlfd): Don't blindly alloca long strings.
7499 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
7500 fits in int, when using sprintf. Use single snprintf to count
7501 length of string rather than counting it via multiple sprintfs;
7502 that's simpler and more reliable.
7503 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7504 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7505 sprintf, in case result does not fit in int.
7507 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7508 (fontset_from_font): Print it.
7510 * frame.c (tty_frame_count): Now printmax_t, not int.
7511 (make_terminal_frame, set_term_frame_name): Print it.
7512 (x_report_frame_params): In X, window IDs are unsigned long,
7513 not signed long, so print them as unsigned.
7514 (validate_x_resource_name): Check for implausibly long names,
7515 and don't assume name length fits in 'int'.
7516 (x_get_resource_string): Don't blindly alloca invocation name;
7517 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7520 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7521 (xg_check_special_colors, xg_set_geometry):
7522 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7524 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7525 Use esprintf, not sprintf, in case result does not fit in int.
7527 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7528 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7529 it as a large positive number.
7530 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7531 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7533 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7534 in case result does not fit in int.
7536 * print.c (float_to_string): Detect width overflow more reliably.
7537 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7538 buffer overrun. Don't assume list length fits in 'int'. Treat
7539 print length of 0 as 0, not as infinity; to be consistent with other
7540 uses of print length in this function. Don't overflow print length
7541 index. Don't assume hash table size fits in 'long', or that
7542 vectorlike size fits in 'unsigned long'.
7544 * process.c (make_process): Use printmax_t, not int, to format
7545 process-name gensyms.
7547 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7549 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7550 to avoid potential buffer overrun.
7552 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7553 if X resource line is longer than 512 bytes.
7555 * xfns.c (x_window): Make sprintf buffer a bit bigger
7556 to avoid potential buffer overrun.
7558 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7560 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7562 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7564 Integer overflow fixes for scrolling, etc.
7565 Without these, Emacs silently mishandles large integers sometimes.
7566 For example, "C-u 4294967297 M-x recenter" was treated as if
7567 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7569 * xdisp.c (try_window_id): Check Emacs fixnum range before
7570 converting to 'int'.
7572 * window.c (window_scroll_line_based, Frecenter):
7573 Check that an Emacs fixnum is in range before assigning it to 'int'.
7574 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7575 values converted from Emacs fixnums.
7576 (Frecenter): Don't wrap around a line count if it is out of 'int'
7577 range; instead, treat it as an extreme value.
7578 (Fset_window_configuration, compare_window_configurations):
7579 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7581 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7582 that can exceed INT_MAX. Check that EMACS_INT value is in range
7583 before assigning it to the (possibly-narrower) index.
7584 (match_limit): Don't assume that a fixnum can fit in 'int'.
7586 * print.c (print_object): Use ptrdiff_t, not int, for index that can
7589 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
7590 (Fvertical_motion): Don't wrap around LINES values that don't fit
7591 in 'int'. Instead, treat them as extreme values. This is good
7592 enough for windows, which can't have more than INT_MAX lines anyway.
7594 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7596 * Require libxml/parser.h to avoid compilation warning.
7598 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7600 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7601 since this reportedly can destroy thread storage.
7603 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
7605 * syntax.c (find_defun_start): Update all cache variables if
7606 exiting early (Bug#9401).
7608 2011-08-30 Eli Zaretskii <eliz@gnu.org>
7610 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7612 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7613 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7614 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7616 * term.c (tty_append_glyph): New function.
7617 (produce_stretch_glyph): Static function and its prototype deleted.
7619 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7622 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7624 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7625 when checking :margin (Bug#9390).
7626 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
7627 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
7628 so that the name doesn't mislead. All uses changed.
7630 2011-08-28 Johan Bockgård <bojohan@gnu.org>
7632 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7635 2011-08-27 Eli Zaretskii <eliz@gnu.org>
7637 * xdisp.c (move_it_to): Don't bail out early when reaching
7638 position beyond to_charpos, if we are scanning backwards.
7639 (move_it_vertically_backward): When DY == 0, make sure we get to
7640 the first character in the line after the newline.
7642 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7644 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7645 (ccl_driver): Do not generate an out-of-range pointer.
7646 (Fccl_execute_on_string): Remove unnecessary check for
7647 integer overflow, noted by Stefan Monnier in
7648 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7649 Remove a FIXME that didn't need fixing.
7650 Simplify the newly-introduced buffer reallocation code.
7652 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
7654 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7656 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
7658 Integer and memory overflow issues (Bug#9196).
7660 * doc.c (get_doc_string): Rework so that
7661 get_doc_string_buffer_size is the actual buffer size, rather than
7662 being 1 less than the actual buffer size; this makes xpalloc more
7665 * image.c (x_allocate_bitmap_record, cache_image):
7666 * xselect.c (Fx_register_dnd_atom):
7667 Simplify previous changes by using xpalloc.
7669 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7670 since either will do and ptrdiff_t is convenient with xpalloc.
7672 * charset.c (charset_table_size)
7673 (struct charset_sort_data.priority): Now ptrdiff_t.
7674 (charset_compare): Don't overflow if priorities differ greatly.
7675 (Fsort_charsets): Don't assume list length fits in int.
7676 Check for size-calculation overflow when allocating sort data.
7677 (syms_of_charset): Allocate an initial charset table that is
7678 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7680 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7682 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7683 The actual value is always <= INT_MAX, and leaving it unsigned made
7684 overflow checking harder.
7686 * dispextern.h (struct glyph_matrix.rows_allocated)
7687 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7688 with xpalloc. The values are still always <= INT_MAX.
7690 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7692 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7693 (SAFE_NALLOCA): New macro.
7695 * region-cache.c (struct boundary.pos, find_cache_boundary)
7696 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7697 (set_cache_region, invalidate_region_cache)
7698 (revalidate_region_cache, know_region_cache, region_cache_forward)
7699 (region_cache_backward, pp_cache):
7700 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7701 so that ptrdiff_t * can be passed to xpalloc.
7702 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7703 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7704 (pp_cache): Don't assume cache_len fits in int.
7705 * region-cache.h: Adjust extern decls to match.
7707 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7708 EMACS_INT, since either will do, for xpalloc.
7710 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7711 (xnmalloc, xnrealloc, xpalloc): New functions.
7713 * bidi.c (bidi_shelve_header_size): New constant.
7714 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7715 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7717 * bidi.c (bidi_cache_shrink):
7718 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7720 Don't update size of array until after memory allocation succeeds,
7721 because xmalloc/xrealloc may not return.
7722 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7723 now that we have proper integer overflow checking.
7724 (record_overlay_string, overlay_strings): Catch overflows when
7725 calculating size of overlay_str_buf.
7727 * callproc.c (Fcall_process): Check for size overflow when
7728 calculating size of args2.
7729 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7730 Normally we prefer signed values, but sticking with ptrdiff_t would
7731 require adding more-complicated checks.
7733 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7734 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7735 Redo buffer-overflow calculations to avoid integer overflow.
7736 Add a FIXME comment where memory seems to be over-allocated.
7738 * character.c (Fstring): Check for size-calculation overflow.
7740 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7741 unnecessary integer overflow. Check for size overflow.
7742 (encode_coding_object): Don't update size until xmalloc succeeds.
7744 * composite.c (get_composition_id): Check for overflow in glyph
7745 length calculations.
7747 Integer and memory overflow fixes for display code.
7748 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7749 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7750 (scrolling_window): Check for overflow in size calculations.
7751 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7752 Don't assume glyph table len fits in int.
7753 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7754 (row_table_size): Now ptrdiff_t, not int.
7755 (scrolling_window): Avoid overflow in size calculations.
7756 Don't update size until allocation succeeds.
7757 * fns.c (concat): Check for overflow in size calculations.
7758 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7759 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7760 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7762 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7763 (get_doc_string): Check for size calculation overflow.
7764 Don't update size until allocation succeeds.
7765 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7766 EMACS_INT, where ptrdiff_t will do.
7767 (Fsubstitute_command_keys): Check for string overflow.
7769 * editfns.c (set_time_zone_rule): Don't assume environment length
7771 (message_length): Now ptrdiff_t, not int.
7772 (Fmessage_box): Don't update size until allocation succeeds.
7773 Don't assume message length fits in int.
7774 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7776 * emacs.c (main): Do not reallocate argv, since there is a null at
7777 the end that can be overwritten, and this way there's no need to
7778 worry about size-calculation overflow.
7779 (sort_args): Check for size-calculation overflow.
7781 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7783 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7785 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7786 (x_set_scroll_bar_width, x_figure_window_size):
7787 Check for integer overflow.
7788 (x_set_alpha): Do not assume XINT fits in int.
7790 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7791 This is for the members text_lines, text_cols, total_lines, total_cols,
7792 where the system imposes an 'int' limit.
7794 * fringe.c (Fdefine_fringe_bitmap):
7795 Don't update size until alloc works.
7797 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7798 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7800 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7801 Check for size-calculation overflow.
7802 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7803 do, as we prefer signed integers.
7804 (id_to_widget.max_size, id_to_widget.used)
7805 (xg_store_widget_in_map, xg_remove_widget_from_map)
7806 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7807 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7808 Use and return ptrdiff_t, not int.
7809 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7810 * gtkutil.h: Change prototypes to match the above.
7812 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7813 are duplicate now that they've been promoted to lisp.h.
7814 (x_allocate_bitmap_record, x_alloc_image_color)
7815 (make_image_cache, cache_image, xpm_load):
7816 Don't update size until alloc is done.
7817 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7819 Check for size calculation overflow.
7820 (ct_colors_allocated_max): New constant.
7821 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7824 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7825 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7826 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7827 Use ptrdiff_t, not int, to count maps.
7828 (read_char_minibuf_menu_prompt): Check for overflow in size
7829 calculations. Don't update size until allocation succeeds.
7830 Redo calculations to avoid overflow.
7831 * keyboard.h: Change prototypes to match the above.
7833 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7835 (current_minor_maps): Check for size calculation overflow.
7836 * keymap.h: Change prototypes to match the above.
7838 * lread.c (read1, init_obarray): Don't update size until alloc done.
7840 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7841 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7843 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7844 Now ptrdiff_t, not int.
7845 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7846 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7848 * process.c (Fnetwork_interface_list): Check for overflow
7849 in size calculation.
7851 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7853 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7854 overflow. Don't bother calling xmalloc when xrealloc will do.
7856 * search.c (Freplace_match): Check for size calculation overflow.
7857 (Fset_match_data): Don't assume list lengths fit in 'int'.
7859 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7860 for command line length. Do not attempt to address one before the
7861 beginning of an array, as that's not portable.
7863 * term.c (max_frame_lines): Remove; unused.
7864 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7866 (encode_terminal_code, calculate_costs): Check for size
7867 calculation overflow.
7868 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7869 table lengths and related sizes. Don't update size until alloc
7870 done. Redo calculations to avoid overflow.
7871 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7873 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7874 subtracting pointers.
7875 (gobble_line): Check for overflow more carefully. Don't update size
7878 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7879 Don't update size until alloc done.
7880 Redo size calculations to avoid overflow.
7881 Check for size calculation overflow.
7882 (main) [DEBUG]: Fix typo in invoking tparam1.
7884 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7885 Use ptrdiff_t, not int, for sizes.
7886 (store_mode_line_noprop_char): Don't update size until alloc done.
7888 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7889 Use ptrdiff_t, not int, for sizes.
7890 (Finternal_make_lisp_face, cache_face):
7891 Check for size calculation overflow.
7892 (cache_face): Treat size calculation overflows as if they were
7893 memory exhaustion (the usual treatment), rather than aborting.
7895 * xfns.c (x_encode_text, x_set_name_internal)
7896 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7897 sizes, since they can exceed INT_MAX in size. Check for size
7898 calculation overflow.
7900 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7901 (xg_select): Check for size calculation overflow.
7902 Don't update size until alloc done.
7904 * xrdb.c (get_environ_db): Don't assume path length fits in int,
7905 as sprintf is limited to int lengths.
7907 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7908 (X_LONG_MIN): New macros.
7909 Use them to make the following changes clearer.
7910 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7911 This change doesn't affect the value now, but it may help remind
7912 future maintainers not to raise the value too much later.
7913 (SELECTION_QUANTUM): Remove, replacing with ...
7914 (selection_quantum): ... new function, which avoids overflow.
7916 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7917 assumption that selection length fits in 'int'.
7918 (x_reply_selection_request, x_handle_selection_request)
7919 (x_get_window_property, receive_incremental_selection)
7920 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7921 (lisp_data_to_selection_data, clean_local_selection_data):
7922 Use ptrdiff_t, not int, to record length of selection.
7923 (x_reply_selection_request, x_get_window_property)
7924 (receive_incremental_selection, x_property_data_to_lisp):
7925 Redo calculations to avoid overflow.
7926 (x_reply_selection_request): When sending hint, ceiling it at
7927 X_LONG_MAX rather than relying on wraparound overflow to send
7929 (x_get_window_property, receive_incremental_selection)
7930 (lisp_data_to_selection_data, x_property_data_to_lisp):
7931 Check for size-calculation overflow.
7932 (x_get_window_property, receive_incremental_selection)
7933 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7934 Don't store size until memory allocation succeeds.
7935 (x_get_window_property): Plug memory leak on memory exhaustion.
7936 Don't double-block input; malloc is safe here. Don't assume 2**34
7937 - 4 fits in unsigned long. Add an xassert to check
7938 XGetWindowProperty overflow. Be more careful about overflow
7939 calculations, and distinguish size from memory overflow better.
7940 (receive_incremental_selection): When tracing, don't assume
7941 unsigned int is less than INT_MAX.
7942 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7943 harmful) conversions of unsigned short to int.
7944 (lisp_data_to_selection_data): Don't assume that integers
7945 in the range -65535 through -1 fit in an X unsigned short.
7946 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7947 result parameters unless successful. Rely on cons_to_unsigned
7948 to report problems with elements; the old code wasn't right anyway.
7949 (x_check_property_data): Check for int overflow; we cannot use
7950 a wider type due to X limits.
7951 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7953 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
7955 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7956 (x_term_init): Check for size calculation overflow.
7957 (x_color_cells): Don't store size until memory allocation succeeds.
7958 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
7959 Don't assume alloca size is less than MAX_ALLOCA.
7960 (x_term_init): Don't assume length fits in int (sprintf is limited
7963 Use ptrdiff_t for composition IDs.
7964 * character.c (lisp_string_width):
7965 * composite.c (composition_table_size, n_compositions)
7966 (get_composition_id, composition_gstring_from_id):
7967 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7968 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7969 * window.c (Frecenter):
7970 Use ptrdiff_t, not int, for composition IDs.
7971 * composite.c (get_composition_id): Check for integer overflow.
7972 * composite.h: Adjust prototypes to match the above changes.
7974 Use ptrdiff_t for hash table indexes.
7975 * category.c (hash_get_category_set):
7976 * ccl.c (ccl_driver):
7977 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7978 * coding.c (coding_system_charset_list, detect_coding_system):
7979 * coding.h (struct coding_system.id):
7980 * composite.c (get_composition_id, gstring_lookup_cache):
7981 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7982 * image.c (xpm_get_color_table_h):
7983 * lisp.h (hash_lookup, hash_put):
7984 * minibuf.c (Ftest_completion):
7985 Use ptrdiff_t for hash table indexes, not int (which is too
7986 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7987 32-bit --with-wide-int hosts).
7989 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7990 Add a FIXME comment about memory leaks.
7991 (syms_of_charset): Don't assume xmalloc returns.
7993 Don't assume that stated character widths fit in int.
7994 * character.c (Fchar_width, c_string_width, lisp_string_width):
7995 * character.h (CHAR_WIDTH):
7996 * indent.c (MULTIBYTE_BYTES_WIDTH):
7997 Use sanitize_char_width to avoid undefined and/or bad behavior
7998 with outlandish widths.
7999 * character.h (sanitize_tab_width): Rename from sanitize_width,
8000 now that we have two such functions. All uses changed.
8001 (sanitize_char_width): New inline function.
8003 Don't assume that tab-width fits in int.
8004 * character.h (sanitize_width): New inline function.
8005 (SANE_TAB_WIDTH): New macro.
8006 (ASCII_CHAR_WIDTH): Use it.
8007 * indent.c (sane_tab_width): Remove. All uses replaced by
8008 SANE_TAB_WIDTH (current_buffer).
8009 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
8011 * fileio.c: Integer overflow issues with file modes.
8012 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
8014 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
8015 Remove unreachable code.
8016 (read_hex, load_charset_map_from_file): Check for integer overflow.
8018 * xterm.c: Don't go over XClientMessageEvent limit.
8019 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
8020 (x_send_scroll_bar_event): Likewise. Check that the size does not
8021 exceed limits imposed by XClientMessageEvent, as well as the usual
8022 ptrdiff_t and size_t limits.
8024 * keyboard.c: Overflow, signedness and related fixes.
8025 (make_lispy_movement): Use same integer type in forward decl
8026 that is used in the definition.
8027 (read_key_sequence, keyremap_step):
8028 Change bufsize argument back to int, undoing my 2011-03-30 change.
8029 We prefer signed types, and int is wide enough here.
8030 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
8031 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
8032 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
8033 length, not size_t. Use ptrdiff_t for index, not int.
8034 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
8035 possibility of integer overflow.
8037 Overflow, signedness and related fixes for images.
8039 * dispextern.h (struct it.stack[0].u.image.image_id)
8040 (struct_it.image_id, struct image.id, struct image_cache.size)
8041 (struct image_cache.used, struct image_cache.ref_count):
8042 * gtkutil.c (update_frame_tool_bar):
8043 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
8044 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
8045 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
8046 * nsmenu.m (update_frame_tool_bar):
8047 * xdisp.c (calc_pixel_width_or_height):
8048 * xfns.c (image_cache_refcount):
8049 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
8050 on typical 64-bit hosts.
8052 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8053 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
8054 Omit unnecessary casts to int.
8055 (parse_image_spec): Check that integers fall into 'int' range
8056 when the callers expect that.
8057 (image_ascent): Redo ascent calculation to avoid int overflow.
8058 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
8059 (lookup_image): Remove unnecessary tests.
8060 (xbm_image_p): Locals are now of int, not EMACS_INT,
8061 since parse_image_check makes sure they fit into int.
8062 (png_load, gif_load, svg_load_image):
8063 Prefer int to unsigned where either will do.
8064 (tiff_handler): New function, combining the cores of the
8065 old tiff_error_handler and tiff_warning_handler.
8066 This function is rewritten to use vsnprintf and thereby avoid
8067 stack buffer overflows. It uses only the features of vsnprintf
8068 that are common to both POSIX and native Microsoft.
8069 (tiff_error_handler, tiff_warning_handler): Use it.
8070 (tiff_load, gif_load, imagemagick_load_image):
8071 Don't assume :index value fits in 'int'.
8072 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
8073 (imagemagick_load_image): Check that crop parameters fit into
8074 the integer types that MagickCropImage accepts. Don't assume
8075 Vimagemagick_render_type has a nonnegative value. Don't assume
8076 size_t fits in 'long'.
8077 (gs_load): Use printmax_t to print the widest integers possible.
8078 Check for integer overflow when computing image height and width.
8080 2011-08-26 Eli Zaretskii <eliz@gnu.org>
8082 * xdisp.c (redisplay_window): Don't force window start if point
8083 will be invisible in the resulting window. (Bug#9324)
8085 2011-08-25 Eli Zaretskii <eliz@gnu.org>
8087 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
8088 the display spec is of the form `(space ...)'.
8089 (handle_display_spec): Return the value returned by
8090 handle_single_display_spec, not just 1 or zero.
8091 (handle_single_display_spec): If the display spec is of the form
8092 `(space ...)', and specifies display in the text area, return 2
8094 (try_cursor_movement): Check for the need to scroll more
8095 accurately, and prefer exact match for point under bidi.
8096 Don't advance `row' beyond the last row of the window.
8098 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
8099 into disp_prop; all users changed.
8101 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
8102 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
8103 for the text covered by the display property.
8105 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
8107 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
8108 Change return value to nil.
8109 (Frecord_buffer): Delete unused function.
8111 2011-08-24 Eli Zaretskii <eliz@gnu.org>
8113 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
8114 buffers, return left-to-right.
8115 (set_cursor_from_row): Consider candidate row a win if its glyph
8116 represents a newline and point is on that newline. Fixes cursor
8117 positioning on the newline at EOL of R2L text within L2R
8118 paragraph, and vice versa.
8119 (try_cursor_movement): Check continued rows, in addition to
8120 continuation rows. Fixes unwarranted scroll when point enters a
8121 continued line of R2L text within an L2R paragraph, or vice versa.
8122 (cursor_row_p): Consider the case of point being equal to
8123 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
8124 from the end of a short line to the beginning of a continued line
8125 of R2L text within L2R paragraph.
8126 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
8127 composed characters.
8129 * bidi.c (bidi_check_type): Use xassert.
8130 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
8133 2011-08-23 Eli Zaretskii <eliz@gnu.org>
8135 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
8138 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
8140 * nsfont.m (ns_otf_to_script): Fix typo.
8142 2011-08-22 Kenichi Handa <handa@m17n.org>
8144 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8145 extra slot even if the purpose is char-code-property-table.
8147 2011-08-23 Eli Zaretskii <eliz@gnu.org>
8149 * xdisp.c (redisplay_window): When computing centering_position,
8150 account for the height of the header line. (Bug#8874)
8152 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8153 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8154 candidate is selected by the mouse, and that candidate has a
8155 composed character under the mouse.
8157 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8158 coordinates reported by pos-visible-in-window-p for a composed
8159 character in column zero.
8161 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8163 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8165 2011-08-22 Eli Zaretskii <eliz@gnu.org>
8167 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8168 consider it a hit if to_charpos is anywhere in the range of the
8169 composed buffer positions.
8171 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
8173 * image.c (gif_load): Don't assume that each subimage has the same
8174 dimensions as the base image. Handle disposal method that is
8175 "undefined" by the gif spec (Bug#9335).
8177 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
8179 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
8180 (Fcondition_case): Document `debug' symbol in error handler.
8182 2011-08-19 Eli Zaretskii <eliz@gnu.org>
8184 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8185 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8186 from an Org mode buffer to a Speedbar frame.
8188 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8189 a composition, take its buffer position from IT->cmp_it.charpos.
8190 Fixes cursor positioning at the beginning of a line that begins
8191 with a composed character.
8193 2011-08-18 Eli Zaretskii <eliz@gnu.org>
8195 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8196 character bidirectional type, use STRONG_L instead. Fixes crashes
8197 in a buffer produced by `describe-categories'.
8199 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8200 members before the level stack, so they would be saved and
8201 restored when copying iterator state. Fixes incorrect reordering
8202 around TABs covered by display properties.
8204 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8206 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
8208 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
8210 * eval.c (internal_condition_case, internal_condition_case_1)
8211 (internal_condition_case_2, internal_condition_case_n):
8212 Remove unnecessary aborts (Bug#9081).
8214 2011-08-17 Eli Zaretskii <eliz@gnu.org>
8216 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8217 has no `load' handler, try opening the file locally. (Bug#9311)
8219 2011-08-16 Ken Brown <kbrown@cornell.edu>
8221 * gmalloc.c: Expand comment.
8223 2011-08-16 Eli Zaretskii <eliz@gnu.org>
8225 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8226 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8228 2011-08-16 Ken Brown <kbrown@cornell.edu>
8230 Fix memory allocation problems in Cygwin build (Bug#9273).
8232 * unexcw.c ( __malloc_initialized): Declare external variable.
8233 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8235 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8237 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8239 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8241 [CYGWIN] (special_realloc): New function.
8242 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8243 requests to realloc storage in the static heap.
8245 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8247 * bidi.c (bidi_initialize): Remove unused local.
8249 2011-08-15 Eli Zaretskii <eliz@gnu.org>
8252 * biditype.h: Remove file.
8253 * makefile.w32-in ($(BLD)/bidi.$(O)):
8254 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
8256 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8258 * chartab.c: Improve commentary for the uniprop_table API.
8260 * bidi.c (bidi_paragraph_init): Support zero value of
8261 bidi_ignore_explicit_marks_for_paragraph_level.
8262 (bidi_initialize): Use uniprop_table instead of including
8263 biditype.h and bidimirror.h.
8265 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8266 coordinates of the iterator when restoring from ppos_it.
8269 2011-08-14 Kenichi Handa <handa@m17n.org>
8271 * process.c (create_process): Call setup_process_coding_systems
8272 after the pid of the process is set to -1 (Bug#8162).
8274 2011-08-14 Eli Zaretskii <eliz@gnu.org>
8276 * xdisp.c (move_it_in_display_line_to): Don't invoke
8277 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8278 ppos_it. Fixes vertical cursor motion when line beginning is
8279 covered by an image. (Bug#9296)
8281 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8283 * nsterm.h (ns_run_ascript): Declare.
8284 (NSAPP_DATA2_RUNASSCRIPT): Define.
8286 * nsfns.m (as_script, as_result, as_status): New static variables.
8287 (ns_run_ascript): New function.
8288 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
8289 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8290 the event loop. Get status from as_status (Bug#7276).
8292 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8293 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8294 the event loop (Bug#7276).
8296 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8298 * gnutls.c (QCgnutls_bootprop_priority)
8299 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8300 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8301 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8302 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8303 (QCgnutls_bootprop_verify_hostname_error)
8304 (QCgnutls_bootprop_callbacks_verify): Rename from
8305 Qgnutls_bootprop_..., all uses changed.
8307 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8310 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8312 * xfaces.c (Qframe_set_background_mode): Now static.
8313 * dispextern.h (Qframe_set_background_mode): Remove decl.
8315 * process.c (Fnetwork_interface_info): Declare local only if needed.
8317 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8319 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8320 (Fnetwork_interface_list): Allocate in increments of bytes instead
8321 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8322 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8324 (struct ifflag_def): notrailers is smart on OSX.
8325 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8326 Get hardware address with getifaddrs if available.
8328 2011-08-12 Eli Zaretskii <eliz@gnu.org>
8330 * xdisp.c (iterate_out_of_display_property): xassert that
8331 IT->position is set to within IT->object's boundaries. Break from
8332 the loop as soon as EOB is reached; avoids infloops in redisplay
8333 when IT->position is set up wrongly due to some bug.
8334 Set IT->current to match the bidi iterator unconditionally.
8335 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8336 entry. Force push_it to save on the stack the current
8337 buffer/string position, to be restored by pop_it. Fix flags in
8338 the iterator structure wrt the object coming from a display
8339 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8340 properties. (Bug#9284)
8342 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
8344 * fontset.c (fontset_get_font_group): Add proper type checks.
8347 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8349 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8350 and LC_VERSION_MIN_MACOSX.
8351 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8352 (dump_it) [LC_FUNCTION_STARTS]: Use it.
8354 2011-08-08 Eli Zaretskii <eliz@gnu.org>
8356 * xdisp.c (forward_to_next_line_start): Allow to use the
8357 no-display-properties-and-no-overlays under bidi display.
8358 Set disp_pos in the bidi iterator to avoid searches for display
8359 properties and overlays.
8361 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
8363 * editfns.c (Fset_time_zone_rule): Document relationship with the
8366 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8367 the font entity extracted from the cache (Bug#8109).
8369 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
8371 * composite.c (autocmp_chars): Don't reset point. That is done by
8372 restore_point_unwind (Bug#5984).
8374 2011-08-07 Juri Linkov <juri@jurta.org>
8376 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8377 to show the arg `TIME' instead of `TIMEVAL'.
8379 2011-08-06 Eli Zaretskii <eliz@gnu.org>
8381 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8382 display property strides EOL and includes a newline, as in
8383 longlines-mode. (Bug#9254)
8384 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8385 word-wrap under bidirectional display. (Bug#9224)
8387 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8388 is non-zero, even if the data buffer is NULL. Fixes a crash in
8389 vertical-motion with longlines-mode. (Bug#9254)
8391 2011-08-05 Eli Zaretskii <eliz@gnu.org>
8393 * bidi.c <bidi_cache_total_alloc>: Now static.
8394 (bidi_initialize): Initialize bidi_cache_total_alloc.
8396 * xdisp.c (display_line): Release buffer allocated for shelved bidi
8399 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8400 amount allocated this far in `bidi_cache_total_alloc'.
8401 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8402 non-zero, only free the data buffer without restoring the cache
8403 contents. All callers changed.
8405 * dispextern.h (bidi_unshelve_cache): Update prototype.
8407 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8408 (move_it_in_display_line, move_it_to)
8409 (move_it_vertically_backward, move_it_by_lines): Replace the call
8410 to xfree to an equivalent call to bidi_unshelve_cache.
8411 (move_it_in_display_line_to): Fix logic of returning
8412 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
8414 2011-08-05 Eli Zaretskii <eliz@gnu.org>
8416 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8417 came from a string character with a `cursor' property. (Bug#9229)
8419 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8421 * Makefile.in (LIB_PTHREAD): New variable.
8422 (LIBES): Add LIB_PTHREAD (Bug#9216).
8424 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8425 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8427 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8429 * regex.c (re_iswctype): Remove some redundant boolean conversions.
8431 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8433 * xterm.c (x_find_topmost_parent): New function.
8434 (x_set_frame_alpha): Find topmost parent window with
8435 x_find_topmost_parent and set the property there also (bug#9181).
8436 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8438 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8440 * callproc.c (Fcall_process): Avoid vfork clobbering
8441 the local vars buffer, coding_systems, current_dir.
8443 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8445 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8447 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8449 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8450 so that it is not optimized away.
8452 * xdisp.c (compute_display_string_pos): Remove unused local.
8454 2011-08-02 Eli Zaretskii <eliz@gnu.org>
8456 Fix slow cursor motion and scrolling in large buffers with
8457 selective display, like Org Mode buffers. (Bug#9218)
8459 * dispextern.h (struct bidi_it): New member disp_prop_p.
8461 * xdisp.c: Remove one-slot cache of display string positions.
8462 (compute_display_string_pos): Accept an additional argument
8463 DISP_PROP_P; callers changed. Scan at most 5K characters forward
8464 for a display string or property. If found, set DISP_PROP_P
8467 * bidi.c (bidi_fetch_char): Accept an additional argument
8468 DISP_PROP_P, and pass it to compute_display_string_pos.
8469 Only handle text covered by a display string if DISP_PROP_P is returned
8470 non-zero. All callers of bidi_fetch_char changed.
8472 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8474 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8476 2010-12-03 Don March <don@ohspite.net>
8478 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8479 last character M-[char] is translated to ESC [char] (bug#7541).
8481 2011-08-02 Kenichi Handa <handa@m17n.org>
8483 * lisp.h (uniprop_table): Extern it.
8485 * chartab.c (uniprop_table): Make it non-static.
8487 2011-08-01 Eli Zaretskii <eliz@gnu.org>
8489 * xdisp.c (forward_to_next_line_start): Accept additional argument
8490 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8492 (reseat_at_next_visible_line_start): Use the bidi iterator state
8493 returned by forward_to_next_line_start to restore the state of
8494 it->bidi_it after backing up to previous newline. (Bug#9212)
8496 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8498 * regex.c (re_comp): Protoize.
8499 (re_exec): Fix return type.
8500 (regexec): Fix type of `ret'. (Bug#9203)
8502 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8504 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8505 This is needed if max-image-size is a floating-point number.
8507 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8509 * print.c (print_object): Print empty symbol as ##.
8511 * lread.c (read1): Read ## as empty symbol.
8513 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8515 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8516 setting frame foreground color (Bug#9175).
8517 (x_set_background_color): Likewise.
8519 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8520 contents (Bug#9176).
8521 (EmacsTooltip -init): Remove bezels and add shadows to
8524 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8525 or scroll bar (Bug#8470).
8527 * nsfont.m (nsfont_open): Remove assignment to voffset and
8528 unnecessary vars hshink, expand, hd, full_height, min_height.
8529 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8531 * nsterm.h (nsfont_info): Remove voffset field.
8533 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8535 Implement strike-through and overline on NextStep (Bug#8863).
8537 * nsfont.m (nsfont_open): Use underline position provided by font,
8538 instead of hard-coded value of 2.
8539 (nsfont_draw): Call ns_draw_text_decoration instead.
8541 * nsterm.h: Add declaration for ns_draw_text_decoration.
8543 * nsterm.m (ns_draw_text_decoration): New function for drawing
8544 underline, overline, and strike-through.
8545 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8546 ns_draw_text_decoration. Change treatment of cursor drawing to
8547 accommodate underlining, etc.
8549 2011-07-28 Eli Zaretskii <eliz@gnu.org>
8551 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8554 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8556 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8557 Without this fix, if a signal arrives just after memory fills up,
8558 'malloc' might be invoked reentrantly.
8560 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8561 In other words, assume that every image size is allowed, on non-X
8562 hosts. This assumption is probably wrong, but it lets Emacs compile.
8564 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8566 * regex.c (re_iswctype): Convert return values to boolean.
8568 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8570 * xdisp.c (compute_display_string_pos): Don't use cached display
8571 string position if the buffer had its restriction changed.
8574 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8576 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8578 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8580 Integer signedness and overflow and related fixes. (Bug#9079)
8582 * bidi.c: Integer size and overflow fixes.
8583 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8584 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8585 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8586 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8587 (bidi_find_other_level_edge):
8588 Use ptrdiff_t instead of EMACS_INT where either will do.
8589 This works better on 32-bit hosts configured --with-wide-int.
8590 (bidi_cache_ensure_space): Check for size-calculation overflow.
8591 Use % rather than repeated addition, for better worst-case speed.
8592 Don't set bidi_cache_size until after xrealloc returns, because it
8594 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
8595 (bidi_cache_ensure_space): Also check that the bidi cache size
8596 does not exceed that of the largest Lisp string or buffer. See Eli
8597 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
8599 * alloc.c (__malloc_size_t): Remove.
8600 All uses replaced by size_t. See Andreas Schwab's note
8601 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8603 * image.c: Improve checking for integer overflow.
8604 (check_image_size): Assume that f is nonnull, since
8605 it is always nonnull in practice. This is one less thing to
8606 worry about when checking for integer overflow later.
8607 (x_check_image_size): New function, which checks for integer
8608 overflow issues inside X.
8609 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8610 This removes the need for a memory_full check.
8611 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8612 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8613 (xbm_read_bitmap_data): Change locals back to 'int', since
8614 their values must fit in 'int'.
8615 (xpm_load_image, png_load, tiff_load):
8616 Invoke x_create_x_image_and_pixmap earlier,
8617 to avoid much needless work if the image is too large.
8618 (tiff_load): Treat overly large images as if
8619 x_create_x_image_and_pixmap failed, not as malloc failures.
8620 (gs_load): Use x_check_image_size.
8622 * gtkutil.c: Omit integer casts.
8623 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8624 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8626 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8628 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8629 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8630 would wrongly return t on a 64-bit host.
8632 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8633 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8634 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8635 and therefore cause GCC to emit a bogus diagnostic in some cases.
8637 * image.c: Integer signedness and overflow and related fixes.
8638 This is not an exhaustive set of fixes, but it's time to
8639 record what I've got.
8640 (lookup_pixel_color, check_image_size): Remove redundant decls.
8641 (check_image_size): Don't assume that arbitrary EMACS_INT values
8642 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8643 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8644 (tiff_load, imagemagick_load_image):
8645 Check for overflow in size calculations.
8646 (x_create_x_image_and_pixmap): Remove unnecessary test for
8647 xmalloc returning NULL; that can't happen.
8648 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8649 (xpm_color_bucket): Use better integer hashing function.
8650 (xpm_cache_color): Don't possibly over-allocate memory.
8651 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8652 (gif_memory_source):
8653 Use ptrdiff_t, not int or size_t, to record sizes.
8654 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8655 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8656 either works, as we prefer signed integers.
8657 (tiff_read_from_memory, tiff_write_from_memory):
8658 Return tsize_t, not size_t, since that's what the TIFF API wants.
8659 (tiff_read_from_memory): Don't fail simply because the read would
8660 go past EOF; instead, return a short read.
8661 (tiff_load): Omit no-longer-needed casts.
8662 (Fimagemagick_types): Don't assume size fits into 'int'.
8664 Improve hashing quality when configured --with-wide-int.
8665 * fns.c (hash_string): New function, taken from sxhash_string.
8666 Do not discard information about ASCII character case; this
8667 discarding is no longer needed.
8668 (sxhash-string): Use it. Change sig to match it. Caller changed.
8669 * lisp.h: Declare it.
8670 * lread.c (hash_string): Remove, since we now use fns.c's version.
8671 The fns.c version returns a wider integer if --with-wide-int is
8672 specified, so this should help the quality of the hashing a bit.
8674 * emacs.c: Integer overflow minor fix.
8675 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8676 Define only if GNU_LINUX.
8677 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8679 * dispnew.c: Integer signedness and overflow fixes.
8680 Remove unnecessary forward decls, that were a maintenance hassle.
8681 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8683 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8684 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8685 (prepare_desired_row, line_draw_cost):
8686 Use int, not unsigned, where either works.
8687 (save_current_matrix, restore_current_matrix):
8688 Use ptrdiff_t, not size_t, where either works.
8689 (init_display): Check for overflow more accurately, and without
8690 relying on undefined behavior.
8692 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8693 Remove, replacing with the new symbols in lisp.h. All uses changed.
8694 * fileio.c (make_temp_name):
8695 * filelock.c (lock_file_1, lock_file):
8696 * xdisp.c (message_dolog):
8697 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8698 Use pMd etc. instead.
8699 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8700 replacing the pWIDE etc. symbols removed from editfns.c.
8702 * keyboard.h (num_input_events): Now uintmax_t.
8703 This is (very slightly) less likely to mess up due to wraparound.
8706 * buffer.c: Integer signedness fixes.
8707 (alloc_buffer_text, enlarge_buffer_text):
8708 Use ptrdiff_t rather than size_t when either will do, as we prefer
8711 * alloc.c: Integer signedness and overflow fixes.
8712 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8713 (__malloc_size_t): Default to size_t, not to int.
8714 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8715 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8716 Prefer ptrdiff_t to size_t when either would do, as we prefer
8718 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8719 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8720 Now const. Initialize with values that are in range even if char
8722 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8723 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8724 These functions do the right thing with sizes > 2**32.
8725 (check_depth): Now ptrdiff_t, not int.
8726 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8727 Adjust to new way of storing sizes. Check for size overflow bugs
8729 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8730 slightly wrong anyway, as it missed one instance of
8731 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8732 (refill_memory_reserve): Omit needless cast to size_t.
8733 (mark_object_loop_halt): Mark as externally visible.
8735 * xselect.c: Integer signedness and overflow fixes.
8736 (Fx_register_dnd_atom, x_handle_dnd_message):
8737 Use ptrdiff_t, not size_t, since we prefer signed.
8738 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8739 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8740 x_dnd_atoms_size and x_dnd_atoms_length.
8742 * doprnt.c: Prefer signed to unsigned when either works.
8744 * doprnt.c (doprnt):
8746 * xdisp.c (vmessage):
8747 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8748 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8749 prefer signed arithmetic to avoid comparison confusion.
8750 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8751 but is a bit tricky.
8753 Assume freestanding C89 headers, string.h, stdlib.h.
8754 * data.c, doprnt.c, floatfns.c, print.c:
8755 Include float.h unconditionally.
8756 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8757 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8758 * regex.c: Likewise for stddef.h, string.h.
8759 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8760 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8761 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8762 (STDC_HEADERS): Remove obsolete defines.
8763 * sysdep.c: Include limits.h unconditionally.
8765 Assume support for memcmp, memcpy, memmove, memset.
8766 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8767 * regex.c (memcmp, memcpy):
8768 Remove; we assume C89 now.
8770 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8771 (__malloc_safe_bcopy): Remove; no longer needed.
8773 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
8774 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8775 well either way, and we prefer signed to unsigned.
8777 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8779 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8780 closes the connection while we're reading (bug#9182).
8782 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
8784 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8785 are specified (Bug#9168).
8787 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8789 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8790 Found by GCC static checking and --with-wide-int on a 32-bit host.
8792 2011-07-25 Eli Zaretskii <eliz@gnu.org>
8794 * xdisp.c (compute_display_string_pos): Fix logic of caching
8795 previous display string position. Initialize cached_prev_pos to
8796 -1. Fixes slow-down at the beginning of a buffer.
8798 2011-07-24 Eli Zaretskii <eliz@gnu.org>
8800 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8801 for attrs[LFACE_FONTSET_INDEX].
8803 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8805 * xml.c (parse_region): Remove unused local
8806 that was recently introduced.
8808 2011-07-23 Eli Zaretskii <eliz@gnu.org>
8810 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8811 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8813 * xdisp.c (move_it_in_display_line_to): Record the best matching
8814 position for TO_CHARPOS while scanning the line, and restore it on
8815 exit if none of the characters scanned was an exact match.
8816 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
8817 when exact match is impossible due to invisible text, and the
8818 lines are truncated.
8820 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8822 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8825 2011-07-22 Eli Zaretskii <eliz@gnu.org>
8827 Fix a significant slow-down of cursor motion with C-n, C-p,
8828 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8829 auto-repeat under bidi redisplay in fontified buffers.
8830 * xdisp.c (compute_stop_pos_backwards): New function.
8831 (next_element_from_buffer): Call compute_stop_pos_backwards to
8832 find a suitable prev_stop when we find ourselves before
8834 (reseat): Don't look for prev_stop, as that could mean a very long
8836 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8837 <cached_disp_overlay_modiff>: Cache for last found display string
8839 (compute_display_string_pos): Return the cached position if asked
8840 about the same buffer in the same area of character positions, and
8841 the buffer wasn't changed since the time the display string
8842 position was cached.
8844 2011-07-22 Eli Zaretskii <eliz@gnu.org>
8846 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8847 is an integer, which is important for empty lines. (Bug#9149)
8849 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
8851 * frame.c (Fmodify_frame_parameters): In tty case, update the
8852 default face if necessary (Bug#4238).
8854 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
8856 * editfns.c (Fstring_to_char): No need to explain what a character
8857 is in the docstring (Bug#6576).
8859 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8861 * xml.c (parse_region): Make sure we always return a tree.
8863 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8865 * xml.c (parse_region): If a document contains only comments,
8868 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8870 * xml.c (make_dom): Return comments, too.
8872 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8875 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8876 and the surrounding thread.
8877 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8878 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8879 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8881 * s/openbsd.h (BROKEN_SIGIO): Define.
8882 * unexelf.c (unexec) [__OpenBSD__]:
8883 Don't update the .mdebug section of the Alpha COFF symbol table.
8885 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8887 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8890 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8892 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8893 This fixes some race conditions on the permissions of any newly
8896 * alloc.c (valid_pointer_p): Use pipe, not open.
8897 This fixes some permissions issues when debugging.
8899 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8900 If fchown fails to set both uid and gid, try to set just gid,
8901 as that is sometimes allowed. Adjust the file's mode to eliminate
8902 setuid or setgid bits that are inappropriate if fchown fails.
8904 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8906 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8907 to compare Lisp_Objects.
8908 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8909 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8910 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8912 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8914 * lread.c (read_integer): Unread even EOF character.
8915 (read1): Likewise. Properly record start position of symbol.
8917 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8918 symbol character follows.
8920 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8922 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8923 This works around a problem with the previous change to Fcopy_file.
8924 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8925 and without this change, GCC might complain about discarding
8926 fchown's return value.
8928 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
8930 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8932 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8934 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8936 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8938 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8939 it's used from the C level.
8941 * process.c: Use the same condition for POLL_FOR_INPUT in both
8942 keyboard.c and process.c (bug#1858).
8944 2011-07-09 Lawrence Mitchell <wence@gmx.li>
8946 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8947 (Fgnutls_boot): Use it.
8949 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8951 * doc.c (Fsubstitute_command_keys): Revert last change.
8953 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8955 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8956 quotes the next character, and doesn't affect other longer
8957 sequences (bug#8935).
8959 * lread.c (syms_of_lread): Clarify that is isn't only
8960 `eval-buffer' and `eval-defun' that's affected by
8961 `lexical-binding' (bug#8460).
8963 2011-07-15 Eli Zaretskii <eliz@gnu.org>
8965 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
8966 bidi redisplay when a line includes both an image and is truncated.
8968 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8970 Fix minor problems found by static checking.
8971 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8972 (elsz): Now a signed constant, not a size_t var. We prefer signed
8973 types to unsigned, to avoid integer comparison confusion. Without
8974 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8975 "cannot optimize loop, the loop counter may overflow", a symptom
8977 * indent.c (Fvertical_motion): Mark locals as initialized.
8978 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8980 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8982 * search.c (Fre_search_backward): Mention `case-fold-search' in
8983 all the re_search_* functions (bug#8138).
8985 * keyboard.c (Fopen_dribble_file): Document when the file is
8988 2011-07-14 Eli Zaretskii <eliz@gnu.org>
8990 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8993 Support bidi reordering of display and overlay strings.
8994 * xdisp.c (compute_display_string_pos)
8995 (compute_display_string_end): Accept additional argument STRING.
8996 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8997 (reseat_to_string): Initialize bidi_it->string.s and
8998 bidi_it->string.schars.
8999 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
9000 NULL (avoids a crash in bidi_paragraph_init).
9001 Initialize itb.string.lstring.
9002 (init_iterator): Call bidi_init_it only of a valid
9003 buffer position was specified. Initialize paragraph_embedding to
9005 (reseat_to_string): Initialize the bidi iterator.
9006 (display_string): If we need to ignore text properties of
9007 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
9008 original value of -1 will not work with bidi.)
9009 (compute_display_string_pos): First arg is now struct
9010 `text_pos *'; all callers changed. Support display properties on
9012 (compute_display_string_end): Support display properties on Lisp
9014 (init_iterator, reseat_1, reseat_to_string): Initialize the
9015 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
9016 when iterating on a string not from display properties).
9017 (compute_display_string_pos, compute_display_string_end):
9018 Fix calculation of the object to scan. Fixes an error when using
9020 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
9021 base_level_stop; instead, set base_level_stop to BEGV.
9022 Fixes crashes in vertical-motion.
9023 (next_element_from_buffer): Improve commentary for when
9024 the iterator is before prev_stop.
9025 (init_iterator): Initialize bidi_p from the default value of
9026 bidi-display-reordering, not from buffer-local value. Use the
9027 buffer-local value only if initializing for buffer iteration.
9028 (handle_invisible_prop): Support invisible properties on strings
9029 that are being bidi-reordered.
9030 (set_iterator_to_next): Support bidi reordering of C strings and
9032 (next_element_from_string): Support bidi reordering of Lisp
9034 (handle_stop_backwards): Support Lisp strings as well.
9035 (display_string): Support display of R2L glyph rows.
9036 Use IT_STRING_CHARPOS when displaying from a Lisp string.
9037 (init_iterator): Don't initialize it->bidi_p for strings
9039 (reseat_to_string): Initialize it->bidi_p for strings here.
9040 (next_element_from_string, next_element_from_c_string)
9041 (next_element_from_buffer): Add xassert's for correspondence
9042 between IT's object being iterated and it->bidi_it.string
9044 (face_before_or_after_it_pos): Support bidi iteration.
9045 (next_element_from_c_string): Handle the case of the first string
9046 character that is not the first one in the visual order.
9047 (get_visually_first_element): New function, refactored from common
9048 parts of next_element_from_buffer, next_element_from_string, and
9049 next_element_from_c_string.
9050 (tool_bar_lines_needed, redisplay_tool_bar)
9051 (display_menu_bar): Force left-to-right direction. Add a FIXME
9052 comment for making that be controlled by a user option.
9053 (push_it, pop_it): Save and restore the state of the
9054 bidi iterator. Save and restore the bidi_p flag.
9055 (pop_it): Iterate out of display property for string iteration as
9057 (iterate_out_of_display_property): Support iteration over strings.
9058 (handle_single_display_spec): Set up it->bidi_it for iteration
9059 over a display string, and call bidi_init_it.
9060 (handle_single_display_spec, next_overlay_string)
9061 (get_overlay_strings_1, push_display_prop): Set up the bidi
9062 iterator for displaying display or overlay strings.
9063 (forward_to_next_line_start): Don't use the shortcut if
9065 (back_to_previous_visible_line_start): If handle_display_prop
9066 pushed the iterator stack, restore the internal state of the bidi
9067 iterator by calling bidi_pop_it same number of times.
9068 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
9069 and we are bidi-iterating, don't decrement the iterator position;
9070 instead, set the first_elt flag in the bidi iterator, to produce
9072 (reseat_1): Remove redundant setting of string_from_display_prop_p.
9073 (push_display_prop): xassert that we are iterating a buffer.
9074 (push_it, pop_it): Save and restore paragraph_embedding member.
9075 (handle_single_display_spec, next_overlay_string)
9076 (get_overlay_strings_1, reseat_1, reseat_to_string)
9077 (push_display_prop): Set up the `unibyte' member of bidi_it.string
9078 correctly. Don't assume unibyte strings are not bidi-reordered.
9079 (compute_display_string_pos)
9080 (compute_display_string_end): Fix handling the case of C string.
9081 (push_it, pop_it): Save and restore from_disp_prop_p.
9082 (handle_single_display_spec, push_display_prop): Set the
9083 from_disp_prop_p flag.
9084 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
9085 (pop_it): Call iterate_out_of_display_property only if we are
9086 popping after iteration over a string that came from a display
9087 property. Fix a typo in popping stretch info. Add an assertion
9088 for verifying that the iterator position is in sync with the bidi
9090 (handle_single_display_spec, get_overlay_strings_1)
9091 (push_display_prop): Fix initialization of paragraph direction for
9092 string when that of the parent object is not yet determined.
9093 (reseat_1): Call bidi_init_it to resync the bidi
9094 iterator with IT's position. (Bug#7616)
9095 (find_row_edges): If ROW->start.pos gives position
9096 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
9097 (handle_stop, back_to_previous_visible_line_start, reseat_1):
9098 Reset the from_disp_prop_p flag.
9099 (SAVE_IT, RESTORE_IT): New macros.
9100 (pos_visible_p, face_before_or_after_it_pos)
9101 (back_to_previous_visible_line_start)
9102 (move_it_in_display_line_to, move_it_in_display_line)
9103 (move_it_to, move_it_vertically_backward, move_it_by_lines)
9104 (try_scrolling, redisplay_window, display_line): Use them when
9105 saving a temporary copy of the iterator and restoring it back.
9106 (back_to_previous_visible_line_start, reseat_1)
9107 (init_iterator): Empty the bidi cache "stack".
9108 (move_it_in_display_line_to): If iterator ended up at
9109 EOL, but we never saw any buffer positions smaller than
9110 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
9111 motion in bidi-reordered lines.
9112 (move_it_in_display_line_to): Record prev_method and prev_pos
9113 immediately before the call to set_iterator_to_next. Fixes cursor
9114 motion in bidi-reordered lines with stretch glyphs and strings
9115 displayed in margins. (Bug#8133) (Bug#8867)
9116 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
9118 (pos_visible_p): Support positions in bidi-reordered lines.
9119 Save and restore bidi cache.
9121 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
9122 (bidi_paragraph_info): Delete unused struct.
9123 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
9124 (bidi_cache_start): New variable.
9125 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
9127 (bidi_cache_fetch_state, bidi_cache_search)
9128 (bidi_cache_find_level_change, bidi_cache_iterator_state)
9129 (bidi_cache_find, bidi_peek_at_next_level)
9130 (bidi_level_of_next_char, bidi_find_other_level_edge)
9131 (bidi_move_to_visually_next): Compare cache index with
9132 bidi_cache_start rather than with zero.
9133 (bidi_fetch_char): Accept new argument STRING; all callers
9134 changed. Support iteration over a string. Support strings with
9135 display properties. Support unibyte strings. Fix the type of
9136 `len' according to what STRING_CHAR_AND_LENGTH expects.
9137 (bidi_paragraph_init, bidi_resolve_explicit_1)
9138 (bidi_resolve_explicit, bidi_resolve_weak)
9139 (bidi_level_of_next_char, bidi_move_to_visually_next):
9140 Support iteration over a string.
9141 (bidi_set_sor_type, bidi_resolve_explicit_1)
9142 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
9143 can now be zero (for strings); special values 0 and -1 were
9144 changed to -1 and -2, respectively.
9145 (bidi_char_at_pos): New function.
9146 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9147 Call it instead of FETCH_MULTIBYTE_CHAR.
9148 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9149 initialized to valid values.
9150 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9152 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9153 the test for valid cached positions. Fix the logic for looking up
9154 the sentinel state in the cache. GCPRO the Lisp string we are
9156 (bidi_push_it, bidi_pop_it): New functions.
9157 (bidi_initialize): Initialize the bidi cache start stack pointer.
9158 (bidi_cache_ensure_space): New function, refactored from part of
9159 bidi_cache_iterator_state. Don't assume the required size is just
9160 one BIDI_CACHE_CHUNK away.
9161 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9162 (bidi_count_bytes, bidi_char_at_pos): New functions.
9163 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9164 always valid if bidi_cache_idx is valid.
9165 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9166 is valid if it's going to be used.
9167 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9168 (bidi_cache_fetch_state, bidi_cache_search)
9169 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9170 (bidi_cache_iterator_state, bidi_cache_find)
9171 (bidi_find_other_level_edge, bidi_cache_start_stack):
9172 All variables related to cache indices are now EMACS_INT.
9174 * dispextern.h (struct bidi_string_data): New structure.
9175 (struct bidi_it): New member `string'. Make flag members be 1-bit
9176 fields, and put them last in the struct.
9177 (compute_display_string_pos, compute_display_string_end):
9179 (bidi_push_it, bidi_pop_it): Add prototypes.
9180 (struct iterator_stack_entry): New members bidi_p,
9181 paragraph_embedding, and from_disp_prop_p.
9182 (struct it): Member bidi_p is now a bit field 1 bit wide.
9183 (bidi_shelve_cache, bidi_unshelve_cache):
9186 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9187 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9188 and vector-like objects.
9190 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9191 cache around display iteration.
9193 * window.c (Fwindow_end, window_scroll_pixel_based)
9194 (displayed_window_lines, Frecenter): Save and restore the bidi
9195 cache around display iteration.
9197 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9199 * editfns.c (Fdelete_region): Clarify the use of the named
9200 parameters (bug#6788).
9202 2011-07-14 Martin Rudalics <rudalics@gmx.at>
9204 * indent.c (Fvertical_motion): Set and restore w->pointm when
9205 saving and restoring the window's buffer (Bug#9006).
9207 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9209 * editfns.c (Fstring_to_char): Clarify just what is returned
9210 (bug#6576). Text by Eli Zaretskii.
9212 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
9214 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9216 2011-07-13 Eli Zaretskii <eliz@gnu.org>
9218 * buffer.c (mmap_find): Fix a typo.
9220 2011-07-13 Johan Bockgård <bojohan@gnu.org>
9222 Fix execution of x selection hooks.
9223 * xselect.c (Qx_lost_selection_functions)
9224 (Qx_sent_selection_functions): New vars.
9225 (syms_of_xselect): DEFSYM them.
9226 (x_handle_selection_request): Pass Qx_sent_selection_functions
9227 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9228 (x_handle_selection_clear,x_clear_frame_selections):
9229 Pass Qx_lost_selection_functions rather than
9230 Vx_lost_selection_functions to Frun_hook_with_args.
9232 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9234 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
9235 The old code sometimes used this field without initializing it.
9237 * alloc.c (gc_sweep): Don't read past end of array.
9238 In theory, the old code could also have corrupted Emacs internals,
9239 though it'd be very unlikely.
9241 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9243 * character.c (Fcharacterp): Don't advertise optional ignored
9244 argument. (Bug#4026)
9246 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9248 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9251 * window.c (Fset_window_start): Doc fix (bug#4199).
9252 (Fset_window_hscroll): Ditto.
9254 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9256 Fix minor new problems caught by GCC 4.6.1.
9257 * term.c (init_tty): Remove unused local.
9258 * xsettings.c (store_monospaced_changed): Define this function only
9259 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
9262 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
9264 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9266 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9268 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9269 are the mini-buffer and the echo area (bug#3320).
9271 * term.c (init_tty): Remove support for supdup, c10 and perq
9272 terminals, which are no longer supported (bug#1482).
9274 2011-07-10 Johan Bockgård <bojohan@gnu.org>
9276 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9278 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9280 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9281 for non-popups (Bug#3642).
9283 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9285 * alloc.c (reset_malloc_hooks): Protoize.
9286 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
9287 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9288 * cm.c (losecursor): Likewise.
9289 * data.c (fmod): Likewise.
9290 * dispnew.c (swap_glyphs_in_rows): Likewise.
9291 * emacs.c (memory_warning_signal): Likewise.
9292 * floatfns.c (float_error): Likewise.
9293 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9294 (otf_open, font_otf_capability, generate_otf_features)
9295 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9297 * image.c (pbm_read_file): Likewise.
9298 * indent.c (string_display_width): Likewise.
9299 * intervals.c (check_for_interval, search_for_interval)
9300 (inc_interval_count, count_intervals, root_interval)
9301 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9302 * lread.c (defalias): Likewise.
9303 * ralloc.c (r_alloc_check): Likewise.
9304 * regex.c (set_image_of_range_1, set_image_of_range)
9305 (regex_grow_registers): Likewise.
9306 * sysdep.c (strerror): Likewise.
9307 * termcap.c (valid_filename_p, tprint, main): Likewise.
9308 * tparam.c (main): Likewise.
9309 * unexhp9k800.c (run_time_remap, save_data_space)
9310 (update_file_ptrs, read_header, write_header, calculate_checksum)
9311 (copy_file, copy_rest, display_header): Likewise.
9312 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9314 * xdisp.c (check_it): Likewise.
9315 * xfaces.c (register_color, unregister_color, unregister_colors):
9317 * xfns.c (print_fontset_result): Likewise.
9318 * xrdb.c (member, fatal, main): Likewise.
9320 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9322 Fix minor problems found by static checking (Bug#9031).
9323 * chartab.c (char_table_set_range, map_sub_char_table):
9324 Remove unused locals.
9325 (uniprop_table): Now static.
9326 * composite.c (_work_char): Remove unused static var.
9328 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
9330 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9332 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9334 * gtkutil.c (qttip_cb): Remove code without function.
9336 2011-07-09 Eli Zaretskii <eliz@gnu.org>
9338 * w32.c (pthread_sigmask): New stub.
9340 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
9342 Use pthread_sigmask, not sigprocmask (Bug#9010).
9343 sigprocmask is portable only for single-threaded applications, and
9344 Emacs can be multi-threaded when it uses GTK.
9345 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9347 * callproc.c (Fcall_process):
9348 * process.c (create_process):
9349 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9350 Use pthread_sigmask, not sigprocmask.
9352 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9354 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9355 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9358 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9360 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9361 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9362 (xg_hide_tooltip): Fix comment.
9364 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9365 in registerServicesMenuSendTypes.
9366 (validRequestorForSendType): Don't check ns_return_types.
9368 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9371 2011-07-08 Jason Rumney <jasonr@gnu.org>
9373 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9374 SH_SHOW for hidden windows (Bug#5482).
9376 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9377 frame struct members of non-existent frames (Bug#6284).
9379 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9381 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9382 variable firstTime not needed on OSX >= 10.6.
9383 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9384 >= 10.5. Use setKnobProportion, setDoubleValue.
9386 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9387 (MAC_OS_X_VERSION_10_5): Define if not defined.
9388 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9389 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9390 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9392 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
9393 cString and lossyCString on OSX >= 10.4.
9395 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
9396 sizeToFit on OSX >= 10.2.
9398 * nsimage.m (allocInitFromFile): Don't use deprecated method
9399 bestRepresentationForDevice on OSX >= 10.6.
9401 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9404 * emacs.c: Declare unexec_init_emacs_zone.
9406 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9408 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9410 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9411 on svcsMenu (Bug#8842).
9413 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9415 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9417 * nsterm.m (QUTF8_STRING): Declare.
9418 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9419 (validRequestorForSendType): Return type is (id).
9420 Change indexOfObjectIdenticalTo to indexOfObject.
9421 Check if we have local selection before returning self (Bug#8842).
9422 (writeSelectionToPasteboard): Put local selection into paste board
9423 if we have a local selection (Bug#8842).
9424 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9426 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9427 (ns_get_local_selection): Declare.
9429 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9431 * keymap.c (describe_map_tree): Don't insert a double newline at
9432 the end of the buffer (bug#1169) and return whether we inserted
9435 * callint.c (Fcall_interactively): Change "reading args" to
9436 "providing args" to try to clarify what it does (bug#1010).
9438 2011-07-07 Kenichi Handa <handa@m17n.org>
9440 * composite.c (composition_compute_stop_pos): Ignore a static
9441 composition starting before CHARPOS (Bug#8915).
9443 * xdisp.c (handle_composition_prop): Likewise.
9445 2011-07-07 Eli Zaretskii <eliz@gnu.org>
9447 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9450 2011-07-07 Kenichi Handa <handa@m17n.org>
9452 * character.h (unicode_category_t): New enum type.
9454 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9455 (Qchar_code_property_table): New variable.
9456 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9457 (UNIPROP_COMPRESSED_FORM_P): New macros.
9458 (char_table_ascii): Uncompress the compressed values.
9459 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9460 Uncompress the compressed values.
9461 (sub_char_table_ref_and_range): Likewise.
9462 (char_table_ref_and_range): Uncompress the compressed values.
9463 (sub_char_table_set): New arg is_uniprop. Callers changed.
9464 Uncompress the compressed values.
9465 (sub_char_table_set_range): Args changed. Callers changed.
9466 (char_table_set_range): Adjuted for the above change.
9467 (map_sub_char_table): Delete args default_val and parent. Add arg
9468 top. Give decoded values to a Lisp function.
9469 (map_char_table): Adjust for the above change. Give decoded
9470 values to a Lisp function. Gcpro more variables.
9471 (uniprop_table_uncompress)
9472 (uniprop_decode_value_run_length): New functions.
9473 (uniprop_decoder, uniprop_decoder_count): New variables.
9474 (uniprop_get_decoder, uniprop_encode_value_character)
9475 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9477 (uniprop_encoder, uniprop_encoder_count): New variables.
9478 (uniprop_get_encoder, uniprop_table)
9479 (Funicode_property_table_internal, Fget_unicode_property_internal)
9480 (Fput_unicode_property_internal): New functions.
9481 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9482 Sunicode_property_table_internal, Sget_unicode_property_internal,
9483 and Sput_unicode_property_internal. Defvar_lisp
9484 char-code-property-alist.
9486 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
9487 Vunicode_category_table.
9489 * font.c (font_range): Adjust for the change of
9490 Vunicode_category_table.
9492 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9494 * m/iris4d.h: Remove file, move contents ...
9495 * s/irix6-5.h: ... here.
9497 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9499 Remove unportable assumption about struct layout (Bug#8884).
9500 * alloc.c (mark_buffer):
9501 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9502 (clone_per_buffer_values): Don't assume that
9503 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9504 This isn't true in general, and it's particularly not true
9505 if Emacs is configured with --with-wide-int.
9506 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9507 New macros, used in the buffer.c change.
9509 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9511 * xsettings.c: Use both GConf and GSettings if both are available.
9512 (store_config_changed_event): Add comment.
9513 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9514 (store_tool_bar_style_changed): New functions.
9515 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
9516 (struct xsettings): Move font inside HAVE_XFT.
9517 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
9518 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
9519 Move inside HAVE_XFT.
9520 (something_changed_gsettingsCB): Rename from something_changedCB.
9521 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9523 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
9524 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
9525 (something_changed_gconfCB): Rename from something_changedCB.
9526 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9527 (parse_settings): Move check for font inside HAVE_XFT.
9528 (read_settings, apply_xft_settings): Add comment.
9529 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9530 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9531 call store_font_name_changed.
9532 (xft_settings_event): Add comment.
9533 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9534 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9535 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9536 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9537 (xsettings_initialize): Call init_gsettings last.
9538 (xsettings_get_system_font, xsettings_get_system_normal_font):
9541 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9543 Random fixes. E.g., (random) never returned negative values.
9544 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9545 subseconds part to the entropy, as that's a bit more random.
9546 Prefer signed to unsigned, since the signedness doesn't matter and
9547 in general we prefer signed. When given a limit, use a
9548 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9549 latter isn't right if USE_2_TAGS_FOR_INTS.
9550 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9551 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9553 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9555 * textprop.c (text_property_stickiness):
9556 Obey Vtext_property_default_nonsticky.
9557 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9558 * w32fns.c (syms_of_w32fns):
9559 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9561 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9563 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9564 This is more efficient than Ffile_directory_p and avoids a minor race.
9566 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9568 * buffer.c (Foverlay_put): Say what the return value is
9571 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9572 is a directory before asking whether to use the file name
9574 (barf_or_query_if_file_exists): Make the "File is a directory"
9575 error be more correct.
9577 * fns.c (Frequire): Remove the mention of the .gz files, since
9578 that's installation-specific, but keep the mention of
9579 `get-load-suffixes'.
9581 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9583 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9584 Report string overflow if the output is too long.
9586 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
9588 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9589 (syms_of_gnutls): Remove duplicate DEFSYM for
9590 Qgnutls_bootprop_verify_hostname_error, an error for
9591 Qgnutls_bootprop_verify_error (which is no longer used).
9593 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9594 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9595 Also (re)move comments that are misplaced or no longer relevant.
9597 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9599 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9601 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
9603 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9604 and background color parameters if they have been changed.
9606 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9608 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9610 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9612 * xsettings.c (SYSTEM_FONT): Define only when used.
9613 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9615 * keymap.c (access_keymap_1): Now static.
9617 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
9619 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9620 leave any prefix arg for the up event (Bug#1586).
9622 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9624 * lread.c (syms_of_lread): Mention single symbols defined by
9625 `defvar' or `defconst' (bug#7154).
9627 * fns.c (Frequire): Mention .el.gz files (bug#7314).
9628 (Frequire): Mention get-load-suffixes.
9630 2011-07-02 Martin Rudalics <rudalics@gmx.at>
9632 * window.h (window): Remove clone_number slot.
9633 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9635 (make_parent_window, make_window, saved_window)
9636 (Fset_window_configuration, save_window_save): Don't deal with
9638 * buffer.c (Qclone_number): Remove declaration.
9639 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9641 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9643 Add multiple inheritance to keymaps.
9644 * keymap.c (Fmake_composed_keymap): New function.
9645 (Fset_keymap_parent): Simplify.
9646 (fix_submap_inheritance): Remove.
9647 (access_keymap_1): New function extracted from access_keymap to handle
9648 embedded parents and handle lists of maps.
9649 (access_keymap): Use it.
9650 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9651 (Fcopy_keymap): Handle embedded parents.
9652 (Fcommand_remapping, define_as_prefix): Simplify.
9653 (Fkey_binding): Simplify.
9654 (syms_of_keymap): Move minibuffer-local-completion-map,
9655 minibuffer-local-filename-completion-map,
9656 minibuffer-local-must-match-map, and
9657 minibuffer-local-filename-must-match-map to Elisp.
9658 (syms_of_keymap): Defsubr make-composed-keymap.
9659 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9660 (parse_menu_item): Trivial simplification.
9662 2011-07-01 Glenn Morris <rgm@gnu.org>
9664 * Makefile.in (SETTINGS_LIBS): Fix typo.
9666 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9668 * coding.c (Fencode_coding_string): Record the last coding system
9669 used, as the function doc string says (bug#8738).
9671 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9673 * xsettings.c (store_monospaced_changed): Take new font as arg and
9674 check for change against current_mono_font.
9675 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9676 (emacs_settings_constructor, emacs_settings_get_property)
9677 (emacs_settings_set_property, emacs_settings_class_init)
9678 (emacs_settings_init, gsettings_obj): Remove.
9679 (something_changedCB): New function for HAVE_GSETTINGS.
9680 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9681 with value as argument.
9682 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9683 g_settings_new (Bug#8967). Do not create gsettings_obj.
9684 Remove calls to g_settings_bind. Connect something_changedCB to
9687 * xgselect.c: Add defined (HAVE_GSETTINGS).
9688 (xgselect_initialize): Ditto.
9690 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9691 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9694 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9696 * eval.c (struct backtrace): Simplify and port the data structure.
9697 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9698 signed bit field, as this assumption is not portable and it makes
9699 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9700 "char debug_on_exit : 1" as this is not portable either; instead,
9701 use the portable "unsigned int debug_on_exit : 1". Remove unused
9702 member evalargs. Remove obsolete comments about cc bombing out.
9704 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9706 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9707 Let HAVE_GSETTINGS override HAVE_GCONF.
9708 (store_monospaced_changed): New function.
9709 (EMACS_SETTINGS): A new type derived from GObject to handle
9710 GSettings notifications.
9711 (emacs_settings_constructor, emacs_settings_get_property)
9712 (emacs_settings_set_property, emacs_settings_class_init):
9714 (gsettings_client, gsettings_obj): New variables.
9715 (GSETTINGS_SCHEMA): New define.
9716 (something_changedCB): Call store_monospaced_changed.
9717 (init_gsettings): New function.
9718 (xsettings_initialize): Call init_gsettings.
9719 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9722 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9725 2011-06-29 Martin Rudalics <rudalics@gmx.at>
9727 * window.c (resize_root_window, grow_mini_window)
9728 (shrink_mini_window): Rename Qresize_root_window to
9729 Qwindow_resize_root_window and Qresize_root_window_vertically to
9730 Qwindow_resize_root_window_vertically.
9732 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9734 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9736 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
9738 * makefile.w32-in: Redesign dependencies so they reflect more
9739 clearly which files are directly included by each source file,
9740 and not through other includes.
9742 2011-06-27 Martin Rudalics <rudalics@gmx.at>
9744 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9745 (sort_overlays, overlay_strings): When an overlay's clone number
9746 matches the window's clone number process the overlay even if
9747 the overlay's window property doesn't match the current window.
9749 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9750 (Fwindow_hchild): Rename to Fwindow_left_child.
9751 (Fwindow_next): Rename to Fwindow_next_sibling.
9752 (Fwindow_prev): Rename to Fwindow_prev_sibling.
9753 (resize_window_check): Rename to window_resize_check.
9754 (resize_window_apply): Rename to window_resize_apply.
9755 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9756 (Fdelete_other_windows_internal, resize_frame_windows)
9757 (Fsplit_window_internal, Fdelete_window_internal)
9758 (grow_mini_window, shrink_mini_window)
9759 (Fresize_mini_window_internal): Fix callers accordingly.
9761 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9763 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9764 (emacs_fixed_set_min_size): Remove.
9765 (emacs_fixed_new): Take frame as argument.
9767 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9768 (_EmacsFixedPrivate): Remove minwidth/height.
9769 Add struct frame *f.
9770 (emacs_fixed_init): Initialize priv->f.
9771 (get_parent_class, emacs_fixed_set_min_size): Remove.
9772 (emacs_fixed_new): Set priv->f to argument.
9773 (emacs_fixed_get_preferred_width)
9774 (emacs_fixed_get_preferred_height): Use min_width/height from
9775 frames size_hint to set minimum and natural (Bug#8919).
9776 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9777 and use min_width/height from frames size_hint to set
9778 min_width/height (Bug#8919).
9780 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9781 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9784 2011-06-26 Eli Zaretskii <eliz@gnu.org>
9786 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9787 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9790 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
9792 * process.c (wait_reading_process_output): Bypass select if
9793 waiting for a cell while ignoring keyboard input, and input is
9794 pending. Suggested by Jan Djärv (Bug#8869).
9796 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9798 Use gnulib's dup2 module instead of rolling our own.
9799 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9801 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9803 * dispnew.c (scrolling_window): Before scrolling, turn off a
9804 mouse-highlight in the window being scrolled.
9806 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
9808 Move DEFSYM to lisp.h and use everywhere.
9810 * character.h (DEFSYM): Move declaration...
9811 * lisp.h (DEFSYM): ...here.
9817 * w32select.c: Don't include character.h.
9819 * alloc.c (syms_of_alloc):
9820 * buffer.c (syms_of_buffer):
9821 * bytecode.c (syms_of_bytecode):
9822 * callint.c (syms_of_callint):
9823 * casefiddle.c (syms_of_casefiddle):
9824 * casetab.c (init_casetab_once):
9825 * category.c (init_category_once, syms_of_category):
9826 * ccl.c (syms_of_ccl):
9827 * cmds.c (syms_of_cmds):
9828 * composite.c (syms_of_composite):
9829 * dbusbind.c (syms_of_dbusbind):
9830 * dired.c (syms_of_dired):
9831 * dispnew.c (syms_of_display):
9832 * doc.c (syms_of_doc):
9833 * editfns.c (syms_of_editfns):
9834 * emacs.c (syms_of_emacs):
9835 * eval.c (syms_of_eval):
9836 * fileio.c (syms_of_fileio):
9837 * fns.c (syms_of_fns):
9838 * frame.c (syms_of_frame):
9839 * fringe.c (syms_of_fringe):
9840 * insdel.c (syms_of_insdel):
9841 * keymap.c (syms_of_keymap):
9842 * lread.c (init_obarray, syms_of_lread):
9843 * macros.c (syms_of_macros):
9844 * msdos.c (syms_of_msdos):
9845 * print.c (syms_of_print):
9846 * process.c (syms_of_process):
9847 * search.c (syms_of_search):
9848 * sound.c (syms_of_sound):
9849 * syntax.c (init_syntax_once, syms_of_syntax):
9850 * terminal.c (syms_of_terminal):
9851 * textprop.c (syms_of_textprop):
9852 * undo.c (syms_of_undo):
9853 * w32.c (globals_of_w32):
9854 * window.c (syms_of_window):
9855 * xdisp.c (syms_of_xdisp):
9856 * xfaces.c (syms_of_xfaces):
9857 * xfns.c (syms_of_xfns):
9858 * xmenu.c (syms_of_xmenu):
9859 * xsettings.c (syms_of_xsettings):
9860 * xterm.c (syms_of_xterm): Use DEFSYM.
9862 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9864 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
9866 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9868 Integer and buffer overflow fixes (Bug#8873).
9870 * print.c (printchar, strout): Check for string overflow.
9871 (PRINTPREPARE, printchar, strout):
9872 Don't set size unless allocation succeeds.
9874 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9875 for sizes. Check for string overflow more accurately.
9876 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9878 * macros.c: Integer and buffer overflow fixes.
9879 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9880 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9881 Use ptrdiff_t, not int, for sizes.
9882 Don't increment bufsize until after realloc succeeds.
9883 Check for size-calculation overflow.
9884 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9886 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9888 * lread.c: Integer overflow fixes.
9889 (read_integer): Radix is now EMACS_INT, not int,
9890 to improve quality of diagnostics for out-of-range radices.
9891 Calculate buffer size correctly for out-of-range radices.
9892 (read1): Check for integer overflow in radices, and in
9893 read-circle numbers.
9894 (read_escape): Avoid int overflow.
9895 (Fload, openp, read_buffer_size, read1)
9896 (substitute_object_recurse, read_vector, read_list, map_obarray):
9897 Use ptrdiff_t, not int, for sizes.
9898 (read1): Use EMACS_INT, not int, for sizes.
9899 Check for size overflow.
9901 * image.c (cache_image): Check for size arithmetic overflow.
9903 * lread.c: Integer overflow issues.
9904 (saved_doc_string_size, saved_doc_string_length)
9905 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9906 Now ptrdiff_t, not int.
9907 (read1): Don't assume doc string length fits in int. Check for
9908 out-of-range doc string lengths.
9909 (read_list): Don't assume file position fits in int.
9910 (read_escape): Check for hex character overflow.
9912 2011-06-22 Leo Liu <sdl.web@gmail.com>
9914 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9915 Move to minibuffer.el.
9917 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9919 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
9920 The following patches are for when GLYPH_DEBUG && !XASSERT.
9921 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9922 * dispnew.c (flush_stdout):
9923 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9924 Mark as externally visible.
9925 * dispnew.c (check_window_matrix_pointers): Now static.
9926 * dispnew.c (window_to_frame_vpos):
9927 * xfns.c (unwind_create_frame):
9928 * xterm.c (x_check_font): Remove unused local.
9929 * scroll.c (CHECK_BOUNDS):
9930 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9931 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9932 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9933 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9934 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9936 (debug_method_add): Use va_list and vsprintf rather than relying
9937 on undefined behavior with wrong number of arguments.
9938 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9939 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9940 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9941 since we're not interested in debugging glyphs with old libraries.
9942 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9943 GCC 4.6.0's static checking.
9945 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9947 Integer overflow and signedness fixes (Bug#8873).
9948 A few related buffer overrun fixes, too.
9950 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9952 * dispextern.h (struct face.stipple):
9953 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9954 (x_bitmap_mask, x_allocate_bitmap_record)
9955 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9956 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9957 (x_create_bitmap_from_xpm_data):
9958 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9959 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9961 * xfaces.c (load_pixmap):
9962 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9963 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9964 (.bitmaps_last, struct x_output.icon_bitmap):
9965 Use ptrdiff_t, not int, for bitmap indexes.
9966 (x_allocate_bitmap_record): Check for size overflow.
9967 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9969 Use ptrdiff_t, not int, for overlay counts.
9970 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9971 * editfns.c (overlays_around, get_pos_property):
9972 * textprop.c (get_char_property_and_overlay):
9973 * xdisp.c (next_overlay_change, note_mouse_highlight):
9974 * xfaces.c (face_at_buffer_position):
9975 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9976 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9977 (Fnext_overlay_change, Fprevious_overlay_change)
9978 (mouse_face_overlay_overlaps, Foverlays_in):
9979 Use ptrdiff_t, not int, for sizes.
9980 (overlays_at, overlays_in): Check for size-calculation overflow.
9982 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9984 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9985 (x_session_initialize): Do not assume string length fits in int.
9987 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9988 This is unlikely, but can occur if DPI is outlandish.
9990 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
9991 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9993 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9994 * xrdb.c (magic_file_p, search_magic_path):
9995 Omit last arg SUFFIX; it was always 0. All callers changed.
9996 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9998 * xfont.c (xfont_match): Avoid need for strlen.
10000 * xfns.c: Don't assume strlen fits in int.
10001 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
10003 * xdisp.c (message_log_check_duplicate): Return intmax_t,
10004 not unsigned long, as we prefer signed integers. All callers changed.
10005 Detect integer overflow in repeat count.
10006 (message_dolog): Don't assume print length fits in 39 bytes.
10007 (display_mode_element): Don't assume strlen fits in int.
10009 * termcap.c: Don't assume sizes fit in int and never overflow.
10010 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
10011 (gobble_line): Check for size-calculation overflow.
10013 * minibuf.c (Fread_buffer):
10014 * lread.c (intern, intern_c_string):
10015 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
10016 Don't assume string length fits in int.
10018 * keyboard.c (parse_tool_bar_item):
10019 * gtkutil.c (style_changed_cb): Avoid need for strlen.
10021 * font.c: Don't assume string length fits in int.
10022 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
10023 Use ptrdiff_t, not int.
10024 (font_intern_prop): Don't assume string length fits in int.
10025 Don't assume integer property fits in fixnum.
10026 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
10028 * filelock.c: Fix some buffer overrun and integer overflow issues.
10029 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
10030 Reformulate so as not to need the command string.
10031 Invoke gzip -cd rather than gunzip, as it's more portable.
10032 (lock_info_type, lock_file_1, lock_file):
10033 Don't assume pid_t and time_t fit in unsigned long.
10034 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
10035 (current_lock_owner): Prefer signed type for sizes.
10036 Use memcpy, not strncpy, where memcpy is what is really wanted.
10037 Don't assume (via atoi) that time_t and pid_t fit in int.
10038 Check for time_t and/or pid_t out of range, e.g., via a network share.
10039 Don't alloca where an auto var works fine.
10041 * fileio.c: Fix some integer overflow issues.
10042 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
10043 Don't assume string length fits in int.
10044 (directory_file_name): Don't assume string length fits in long.
10045 (make_temp_name): Don't assume pid fits in int, or that its print
10046 length is less than 20.
10048 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
10050 * coding.c (make_subsidiaries): Don't assume string length fits in int.
10052 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
10054 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
10055 We prefer signed integers, even for size calculations.
10057 * emacs.c: Don't assume string length fits in 'int'.
10058 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
10059 (main): Don't invoke strlen when not needed.
10061 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
10062 (XD_DEBUG_MESSAGE): Don't waste a byte.
10064 * callproc.c (getenv_internal_1, getenv_internal)
10065 (Fgetenv_internal):
10066 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
10068 * lread.c (invalid_syntax): Omit length argument.
10069 All uses changed. This doesn't fix a bug, but it simplifies the
10070 code away from its former Hollerith-constant appearance, and it's
10071 one less 'int' to worry about when looking at integer-overflow issues.
10072 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
10074 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
10075 This didn't break anything, but it didn't help either.
10076 It's confusing to put a bogus integer in a place where the actual
10077 value does not matter.
10078 (LIST_END_P): Remove unused macro and its bogus comment.
10079 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
10081 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
10082 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
10084 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
10085 We prefer signed types, and the value cannot exceed the EMACS_INT
10086 range anyway (because otherwise the length would not be representable).
10087 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
10088 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
10089 This avoids a GCC warning when WIDE_EMACS_INT.
10091 * indent.c (sane_tab_width): New function.
10092 (current_column, scan_for_column, Findent_to, position_indentation)
10093 (compute_motion): Use it. This is just for clarity.
10094 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
10096 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
10098 * lisp.h (lint_assume): New macro.
10099 * composite.c (composition_gstring_put_cache):
10100 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
10102 * editfns.c, insdel.c:
10103 Omit unnecessary forward decls, to simplify future changes.
10105 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
10107 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
10109 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
10110 Use much-faster test for byte-length change.
10111 Don't assume string byte-length fits in 'int'.
10112 Check that character arg fits in 'int'.
10113 (mapcar1): Declare byte as byte, for clarity.
10115 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
10117 * fns.c (concat): Catch string overflow earlier.
10118 Do not rely on integer wraparound.
10120 * dispextern.h (struct it.overlay_strings_charpos)
10121 (struct it.selective): Now EMACS_INT, not int.
10122 * xdisp.c (forward_to_next_line_start)
10123 (back_to_previous_visible_line_start)
10124 (reseat_at_next_visible_line_start, next_element_from_buffer):
10125 Don't arbitrarily truncate the value of 'selective' to int.
10127 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
10129 * composite.c: Don't truncate sizes to 'int'.
10130 (composition_gstring_p, composition_reseat_it)
10131 (composition_adjust_point): Use EMACS_INT, not int.
10132 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
10133 not EMACS_UINT, for indexes.
10135 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
10137 * buffer.c: Include <verify.h>.
10138 (struct sortvec.priority, struct sortstr.priority):
10139 Now EMACS_INT, not int.
10140 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
10141 (struct sortstr.size, record_overlay_string)
10142 (struct sortstrlist.size, struct sortlist.used):
10143 Don't truncate size to int.
10144 (record_overlay_string): Check for size-calculation overflow.
10145 (init_buffer_once): Check at compile-time, not run-time.
10147 2011-06-22 Jim Meyering <meyering@redhat.com>
10149 Don't leak an XBM-image-sized buffer
10150 * image.c (xbm_load): Free the image buffer after using it.
10152 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10155 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10156 that Sun C diagnosed.
10157 * fns.c (secure_hash): Fix pointer signedness issue.
10158 * intervals.c (static_offset_intervals): New function.
10159 (offset_intervals): Use it.
10161 2011-06-21 Leo Liu <sdl.web@gmail.com>
10164 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10167 * fns.c (secure_hash): Rename from crypto_hash_function and change
10168 the first arg to accept symbols.
10169 (Fsecure_hash): New primitive.
10170 (syms_of_fns): New symbols.
10172 2011-06-20 Deniz Dogan <deniz@dogan.se>
10174 * process.c (Fset_process_buffer): Clarify return value in
10177 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
10179 * dispnew.c (add_window_display_history): Use BVAR.
10181 * xdisp.c (debug_method_add): Use BVAR.
10182 (check_window_end, dump_glyph_matrix, dump_glyph)
10183 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10185 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10188 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10189 check till after the cache is created in init_frame_faces.
10191 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10193 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10195 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10197 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10198 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10199 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10201 Improve buffer-overflow checking (Bug#8873).
10202 * fileio.c (Finsert_file_contents):
10203 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10204 Remove the old (too-loose) buffer overflow checks.
10205 They weren't needed, since make_gap checks for buffer overflow.
10206 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10207 The old code merely checked for Emacs fixnum overflow, and relied
10208 on undefined (wraparound) behavior. The new code avoids undefined
10209 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10211 * editfns.c (Finsert_char): Don't dump core with very negative counts.
10212 Tune. Don't use wider integers than needed. Don't use alloca.
10213 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
10215 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10217 * insdel.c, lisp.h (buffer_overflow): New function.
10218 (insert_from_buffer_1, replace_range, replace_range_2):
10219 * insdel.c (make_gap_larger):
10220 * editfns.c (Finsert_char):
10221 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10223 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10225 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10227 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
10229 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10230 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10232 * fileio.c: Don't assume EMACS_INT fits in off_t.
10233 (emacs_lseek): New static function.
10234 (Finsert_file_contents, Fwrite_region): Use it.
10235 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10237 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10239 * fns.c: Don't overflow int when computing a list length.
10240 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10241 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10242 truncation on 64-bit hosts. Check for QUIT every
10243 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10244 faster and is responsive enough.
10245 (Flength): Report an error instead of overflowing an integer.
10246 (Fsafe_length): Return a float if the value is not representable
10247 as a fixnum. This shouldn't happen except in contrived situations.
10248 (Fnthcdr, Fsort): Don't assume list length fits in int.
10249 (Fcopy_sequence): Don't assume vector length fits in int.
10251 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10252 (header_size, word_size): New constants.
10253 (allocate_vectorlike): Don't check size overflow here.
10254 (allocate_vector): Check it here instead, since this is the only
10255 caller of allocate_vectorlike that could cause overflow.
10256 Check that the new vector's length is representable as a fixnum.
10258 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10259 The previous code was bogus. For example, next_almost_prime (32)
10260 returned 39, which is undesirable as it is a multiple of 3; and
10261 next_almost_prime (24) returned 25, which is a multiple of 5 so
10262 why was the code bothering to check for multiples of 7?
10264 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10266 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10268 Variadic C functions now count arguments with ptrdiff_t.
10269 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10270 Back then I didn't know that the Emacs coding style prefers signed int.
10271 Also, in the meantime I found a few more instances where arguments
10272 were being counted with int, which may truncate counts on 64-bit
10273 machines, or EMACS_INT, which may be unnecessarily wide.
10274 * lisp.h (struct Lisp_Subr.function.aMANY)
10275 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10276 Arg counts are now ptrdiff_t, not size_t.
10277 All variadic functions and their callers changed accordingly.
10278 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10279 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10280 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10281 * callint.c (Fcall_interactively): Check arg count for overflow,
10282 to avoid potential buffer overrun. Use signed char, not 'int',
10283 for 'varies' array, so that we needn't bother to check its size
10284 calculation for overflow.
10285 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10286 * eval.c (apply_lambda):
10287 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10288 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10289 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10291 * callint.c (Fcall_interactively): Don't use index var as event count.
10293 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10294 * mem-limits.h (SIZE): Remove; no longer used.
10296 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
10298 Remove unnecessary casts.
10299 * xterm.c (x_term_init):
10300 * xfns.c (x_set_border_pixel):
10301 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10302 These aren't needed now that we assume ANSI C.
10304 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10305 It's more likely to cause problems (due to unsigned overflow)
10308 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10310 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10312 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10314 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10316 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10318 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10320 GLYPH_CODE_FACE returns EMACS_INT, not int.
10321 * dispextern.h (merge_faces):
10322 * xfaces.c (merge_faces):
10323 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10324 Don't assume EMACS_INT fits in int.
10326 * character.h (CHAR_VALID_P): Remove unused parameter.
10327 * fontset.c, lisp.h, xdisp.c: All uses changed.
10329 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10331 * fns.c (concat): Minor tuning based on overflow analysis.
10332 This doesn't fix any bugs. Use int to hold character, instead
10333 of constantly refetching from Emacs object. Use XFASTINT, not
10334 XINT, for value known to be a character. Don't bother comparing
10335 a single byte to 0400, as it's always less.
10337 * floatfns.c (Fexpt):
10338 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10340 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10343 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10345 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10346 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10347 incorrectly succeed when S was a string, because 4294967386 was
10348 truncated before it was used.
10350 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10351 Otherwise, an out-of-range integer could cause undefined behavior
10354 * composite.c: Use int, not EMACS_INT, for characters.
10355 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10356 EMACS_INT, for values that are known to be in character range.
10357 This doesn't fix any bugs but is the usual style inside Emacs and
10358 may generate better code on 32-bit machines.
10360 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10361 This is for reasons similar to the recent CHAR_STRING fix.
10362 * charset.c (Fencode_char): Check that character arg is actually
10363 a character. Pass an int to ENCODE_CHAR.
10364 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10365 wider than 'int', as a compile-time check to prevent future regressions
10368 * character.c (char_string): Remove unnecessary casts.
10370 Make sure a 64-bit char is never passed to CHAR_STRING.
10371 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10372 by silently ignoring the top 32 bits, allowing some values
10373 that were far too large to be valid characters.
10374 * character.h: Include <verify.h>.
10375 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10376 arguments are no wider than unsigned, as a compile-time check
10377 to prevent future regressions in this area.
10379 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
10380 (Fsubst_char_in_region):
10382 * xdisp.c (decode_mode_spec_coding):
10383 Adjust to CHAR_STRING's new requirement.
10384 * editfns.c (Finsert_char, Fsubst_char_in_region):
10385 * fns.c (concat): Check that character args are actually
10386 characters. Without this test, these functions did the wrong
10387 thing with wildly out-of-range values on 64-bit hosts.
10389 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10390 These casts should not be needed on 32-bit hosts, either.
10391 * keyboard.c (read_char):
10392 * lread.c (Fload): Remove casts to unsigned.
10394 * lisp.h (UNSIGNED_CMP): New macro.
10395 This fixes comparison bugs on 64-bit hosts.
10396 (ASCII_CHAR_P): Use it.
10397 * casefiddle.c (casify_object):
10398 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
10399 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10400 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10401 * dispextern.h (FACE_FROM_ID):
10402 * keyboard.c (read_char): Use UNSIGNED_CMP.
10404 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10405 not to EMACS_INT, to avoid GCC warning.
10407 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10409 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10410 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10411 isn't needed on 32-bit machines.
10413 * buffer.c (Fgenerate_new_buffer_name):
10414 Use EMACS_INT for count, not int.
10415 (advance_to_char_boundary): Return EMACS_INT, not int.
10417 * data.c (Qcompiled_function): Now static.
10419 * window.c (window_body_lines): Now static.
10421 * image.c (gif_load): Rename local to avoid shadowing.
10423 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10424 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10425 * alloc.c (make_save_value): Integer argument is now of type
10426 ptrdiff_t, not int.
10427 (mark_object): Use ptrdiff_t, not int.
10428 * lisp.h (pD): New macro.
10429 * print.c (print_object): Use it.
10431 * alloc.c: Use EMACS_INT, not int, to count objects.
10432 (total_conses, total_markers, total_symbols, total_vector_size)
10433 (total_free_conses, total_free_markers, total_free_symbols)
10434 (total_free_floats, total_floats, total_free_intervals)
10435 (total_intervals, total_strings, total_free_strings):
10436 Now EMACS_INT, not int. All uses changed.
10437 (Fgarbage_collect): Compute overall total using a double, so that
10438 integer overflow is less likely to be a problem. Check for overflow
10439 when converting back to an integer.
10440 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10441 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10442 These were 'int' variables that could overflow on 64-bit hosts;
10443 they were never used, so remove them instead of repairing them.
10444 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
10445 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10446 Previously, this ceilinged at INT_MAX, but that doesn't work on
10448 (allocate_pseudovector): Don't use EMACS_INT when int would do.
10450 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
10451 (allocate_vectorlike): Check for ptrdiff_t overflow.
10452 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10453 when a (possibly-narrower) signed value would do just as well.
10454 We prefer using signed arithmetic, to avoid comparison confusion.
10456 * alloc.c: Catch some string size overflows that we were missing.
10457 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10458 for convenience in STRING_BYTES_MAX.
10459 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10460 The definition here is exact; the one in lisp.h was approximate.
10461 (allocate_string_data): Check for string overflow. This catches
10462 some instances we weren't catching before. Also, it catches
10463 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10464 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10465 and ptrdiff_t and EMACS_INT are both 64 bits.
10467 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10468 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
10469 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
10471 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10473 * alloc.c (Fmake_string): Check for out-of-range init.
10475 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10477 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10479 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10481 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10482 xg_get_default_scrollbar_width.
10484 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10485 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10486 (style_changed_cb): Call update_theme_scrollbar_width and call
10487 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10488 all frames (Bug#8505).
10489 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10490 Call gtk_window_set_resizable if HAVE_GTK3.
10491 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10492 and height if HAVE_GTK3 (Bug#8505).
10493 (scroll_bar_width_for_theme): New variable.
10494 (update_theme_scrollbar_width): New function.
10495 (xg_get_default_scrollbar_width): Move code to
10496 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10497 (xg_initialize): Call update_theme_scrollbar_width.
10499 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10501 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10503 2011-06-12 Martin Rudalics <rudalics@gmx.at>
10505 * frame.c (make_frame): Call other_buffer_safely instead of
10508 * window.c (temp_output_buffer_show): Call display_buffer with
10509 second argument Vtemp_buffer_show_specifiers and reset latter
10510 immediately after the call.
10511 (Vtemp_buffer_show_specifiers): New variable.
10512 (auto_window_vscroll_p, next_screen_context_lines)
10513 (Vscroll_preserve_screen_position): Remove leading asterisks from
10516 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
10518 Fix minor problems found by GCC 4.6.0 static checking.
10519 * buffer.c (Qclone_number): Remove for now, as it's unused.
10520 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10521 (record_buffer): Remove unused local.
10522 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10523 (set_frame_buffer_list): Remove; unused.
10524 * frame.h (other_visible_frames): Remove decl.
10525 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10526 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10527 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10529 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10530 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10531 Define only if HAVE_GPM.
10532 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10533 (update_hints_inhibit): Remove; never set. All uses removed.
10534 * widgetprv.h (emacsFrameClassRec): Remove decl.
10535 * window.c (delete_deletable_window): Now returns void, since it
10536 wasn't returning anything.
10537 (compare_window_configurations): Remove unused locals.
10538 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10539 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
10540 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10541 the same widths as pointers. This follows up on the 2011-05-06 patch.
10542 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10543 * xterm.h: Likewise.
10544 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10546 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
10548 * makefile.w32-in: Update dependencies.
10549 (LISP_H): Add lib/intprops.h.
10551 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
10553 * image.c (gif_load): Add animation frame delay to the metadata.
10554 (syms_of_image): Use DEFSYM. New symbol `delay'.
10556 2011-06-11 Martin Rudalics <rudalics@gmx.at>
10558 * window.c (delete_deletable_window): Re-add.
10559 (Fset_window_configuration): Rewrite to handle dead buffers and
10560 consequently deletable windows.
10561 (window_tree, Fwindow_tree): Remove. Supply functionality in
10563 (compare_window_configurations): Simplify code.
10565 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10567 * image.c (imagemagick_load_image): Fix type mismatch.
10568 (Fimagemagick_types): Likewise.
10570 * window.h (replace_buffer_in_windows): Declare.
10572 2011-06-11 Martin Rudalics <rudalics@gmx.at>
10574 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10575 Qclone_number. Remove external declaration of Qdelete_window.
10576 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10578 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10579 Run Qbuffer_list_update_hook if allowed.
10580 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10581 buffer list implementation.
10582 (other_buffer_safely): New function.
10583 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10584 calls to replace_buffer_in_windows and
10585 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10587 (record_buffer): Inhibit quitting and rewrite using quittable
10588 functions. Run Qbuffer_list_update_hook if allowed.
10589 (Frecord_buffer, Funrecord_buffer): New functions.
10590 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10591 Move switch-to-buffer to window.el.
10592 (bury-buffer): Move to window.el.
10593 (Vbuffer_list_update_hook): New variable.
10595 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10598 * window.h (resize_frame_windows): Move up in code.
10599 (Fwindow_frame): Remove EXFUN.
10600 (replace_buffer_in_all_windows): Remove prototype.
10601 (replace_buffer_in_windows_safely): Add prototype.
10603 * window.c: Declare Qdelete_window static again. Move down
10604 declaration of select_count.
10605 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10606 (Fother_window): Move to window.el.
10607 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10608 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10609 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10611 (replace_buffer_in_windows): Implement by calling
10612 Qreplace_buffer_in_windows.
10613 (replace_buffer_in_all_windows): Remove with some functionality
10614 moved into replace_buffer_in_windows_safely.
10615 (replace_buffer_in_windows_safely): New function.
10616 (select_window_norecord, select_frame_norecord): Move in front
10617 of run_window_configuration_change_hook. Remove now obsolete
10619 (Fset_window_buffer): Rewrite doc-string.
10620 Call Qrecord_window_buffer.
10621 (keys_of_window): Move binding for other-window to window.el.
10623 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
10625 * dispextern.h (struct image): Replace data member, whose int_val
10626 and ptr_val fields were not used by anything, with a single
10629 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10630 (gif_clear_image, gif_load, imagemagick_load_image)
10631 (gs_clear_image, gs_load): Callers changed.
10633 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10635 * buffer.h: Include <time.h>, for time_t.
10636 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10638 Fix minor problems found by static checking.
10640 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10642 Make identifiers static if they are not used in other modules.
10643 * data.c (Qcompiled_function, Qframe, Qvector):
10644 * image.c (QimageMagick, Qsvg):
10645 * minibuf.c (Qmetadata):
10646 * window.c (resize_window_check, resize_root_window): Now static.
10647 * window.h (resize_window_check, resize_root_window): Remove decls.
10649 * window.c (window_deletion_count, delete_deletable_window):
10651 (window_body_lines): Now static.
10652 (Fdelete_other_windows_internal): Mark vars as initialized.
10653 Make sure 'resize_failed' is initialized.
10654 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10655 (resize_window_apply): Remove unused local.
10656 * window.h (delete_deletable_window): Remove decl.
10658 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
10659 (imagemagick_load_image): Fix pointer signedness problem by changing
10660 last arg from unsigned char * to char *. All uses changed.
10661 Also, fix a local for similar reasons.
10662 Remove unused locals. Remove locals to avoid shadowing.
10663 (fn_rsvg_handle_free): Remove; unused.
10664 (svg_load, svg_load_image): Fix pointer signedness problem.
10665 (imagemagick_load_image): Don't use garbage pointer image_wand.
10667 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10669 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
10671 * image.c (gif_load): Fix omitted cast error introduced by
10674 2011-06-10 Martin Rudalics <rudalics@gmx.at>
10676 * window.h (resize_proportionally, orig_total_lines)
10677 (orig_top_line): Remove from window structure.
10678 (set_window_height, set_window_width, change_window_heights)
10679 (Fdelete_window): Remove prototypes.
10680 (resize_frame_windows): Remove duplicate declaration.
10682 2011-06-10 Eli Zaretskii <eliz@gnu.org>
10684 * window.h (resize_frame_windows, resize_window_check)
10685 (delete_deletable_window, resize_root_window)
10686 (resize_frame_windows): Declare prototypes.
10688 * window.c (resize_window_apply): Make definition be "static" to
10689 match the prototype.
10691 2011-06-10 Martin Rudalics <rudalics@gmx.at>
10693 * window.c: Remove declarations of Qwindow_size_fixed,
10694 window_min_size_1, window_min_size_2, window_min_size,
10695 size_window, window_fixed_size_p, enlarge_window, delete_window.
10696 Remove static from declaration of Qdelete_window, it's
10697 temporarily needed by Fbury_buffer.
10698 (replace_window): Don't assign orig_top_line and
10700 (Fdelete_window, delete_window): Remove. Window deletion is
10701 handled by window.el.
10702 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10703 Replace Fdelete_window calls with calls to Qdelete_window.
10704 (Fdelete_other_windows): Remove. Deleting other windows is
10705 handled by window.el.
10706 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10707 handled in window.el.
10708 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10709 Window minimum sizes are handled in window.el.
10710 (shrink_windows, size_window, set_window_height)
10711 (set_window_width, change_window_heights, window_height)
10712 (window_width, CURBEG, CURSIZE, enlarge_window)
10713 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10714 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10715 handled in window.el.
10716 (make_dummy_parent): Rename to make_parent_window and give it a
10717 second argument horflag.
10718 (make_window): Don't set resize_proportionally any more.
10719 (Fsplit_window): Remove. Windows are split in window.el.
10720 (save_restore_action, save_restore_orig_size)
10721 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10722 Resize mini windows in window.el.
10723 (grow_mini_window, shrink_mini_window): Implement by calling
10724 Qresize_root_window_vertically, resize_window_check and
10725 resize_window_apply.
10726 (saved_window, Fset_window_configuration, save_window_save):
10727 Do not handle orig_top_line, orig_total_lines, and
10728 resize_proportionally.
10729 (window_min_height, window_min_width): Move to window.el.
10730 (keys_of_window): Move bindings for delete-other-windows,
10731 split-window, delete-window and enlarge-window to window.el.
10733 * buffer.c: Temporarily extern Qdelete_window.
10734 (Fbury_buffer): Temporarily call Qdelete_window instead of
10735 Fdelete_window (Fbury_buffer will move to window.el soon).
10737 * frame.c (set_menu_bar_lines_1): Remove code handling
10738 orig_top_line and orig_total_lines.
10740 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10741 set_window_height but set heights directly.
10742 (change_frame_size_1): Use resize_frame_windows.
10744 * xdisp.c (init_xdisp): Don't use set_window_height but set
10747 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10748 Use resize_frame_windows instead of change_window_heights and run
10749 run_window_configuration_change_hook.
10751 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10752 instead of change_window_heights and run
10753 run_window_configuration_change_hook.
10755 2011-06-09 Martin Rudalics <rudalics@gmx.at>
10757 * window.c (replace_window): Rename second argument REPLACEMENT to
10758 NEW. New third argument SETFLAG. Rewrite.
10759 (delete_window, make_dummy_parent): Call replace_window with
10761 (window_list_1): Move down in code.
10762 (run_window_configuration_change_hook): Move set_buffer part
10763 before select_frame_norecord part in order to unwind correctly.
10764 Rename count1 to count.
10765 (recombine_windows, delete_deletable_window, resize_root_window)
10766 (Fdelete_other_windows_internal)
10767 (Frun_window_configuration_change_hook, make_parent_window)
10768 (resize_window_check, resize_window_apply, Fresize_window_apply)
10769 (resize_frame_windows, Fsplit_window_internal)
10770 (Fdelete_window_internal, Fresize_mini_window_internal):
10772 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10774 2011-06-08 Martin Rudalics <rudalics@gmx.at>
10776 * window.h (window): Add some new members to window structure -
10777 normal_lines, normal_cols, new_total, new_normal, clone_number,
10778 splits, nest, prev_buffers, next_buffers.
10779 (WINDOW_TOTAL_SIZE): Move here from window.c.
10780 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
10782 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10784 (make_dummy_parent): Set new members of windows structure.
10785 (make_window): Move down in code. Handle new members of window
10787 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10788 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10789 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10790 (Fset_window_prev_buffers, Fwindow_next_buffers)
10791 (Fset_window_next_buffers, Fset_window_clone_number):
10793 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10794 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10796 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10797 Argument WINDOW can be now internal window too.
10798 (Fwindow_use_time): Move up in code.
10799 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10800 Rewrite doc-string.
10801 (Fset_window_configuration, saved_window)
10802 (Fcurrent_window_configuration, save_window_save): Handle new
10803 members of window structure.
10804 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10805 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10806 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10807 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10808 Qget_mru_window, Qresize_root_window,
10809 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10810 Qauto_buffer_name; staticpro them.
10812 2011-06-07 Martin Rudalics <rudalics@gmx.at>
10814 * window.c (Fwindow_total_size, Fwindow_left_column)
10815 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10816 (Fwindow_list_1): New functions.
10817 (window_box_text_cols): Replace with window_body_cols.
10818 (Fwindow_width, Fscroll_left, Fscroll_right):
10819 Use window_body_cols instead of window_box_text_cols.
10820 (delete_window, Fset_window_configuration):
10821 Call delete_all_subwindows with window as argument.
10822 (delete_all_subwindows): Take a window as argument and not a
10823 structure. Rewrite.
10824 (window_loop): Remove handling of GET_LRU_WINDOW and
10825 GET_LARGEST_WINDOW.
10826 (Fget_lru_window, Fget_largest_window): Move to window.el.
10828 * window.h: Extern window_body_cols instead of
10829 window_box_text_cols. delete_all_subwindows now takes a
10830 Lisp_Object as argument.
10832 * indent.c (compute_motion, Fcompute_motion):
10833 Use window_body_cols instead of window_box_text_cols.
10835 * frame.c (delete_frame): Call delete_all_subwindows with root
10836 window as argument.
10838 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10840 * fns.c (Fputhash): Document return value.
10842 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
10844 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10846 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10848 Cons<->int and similar integer overflow fixes (Bug#8794).
10850 Check for overflow when converting integer to cons and back.
10851 * charset.c (Fdefine_charset_internal, Fdecode_char):
10852 Use cons_to_unsigned to catch overflow.
10853 (Fencode_char): Use INTEGER_TO_CONS.
10854 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10855 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10856 * data.c (long_to_cons, cons_to_long): Remove.
10857 (cons_to_unsigned, cons_to_signed): New functions.
10858 These signal an error for invalid or out-of-range values.
10859 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10860 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10861 * font.c (Ffont_variation_glyphs):
10862 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10863 * lisp.h: Include <intprops.h>.
10864 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10865 (cons_to_signed, cons_to_unsigned): New decls.
10866 (long_to_cons, cons_to_long): Remove decls.
10867 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10868 (Fprimitive_undo): Use CONS_TO_INTEGER.
10869 * xfns.c (Fx_window_property): Likewise.
10870 * xselect.c: Include <limits.h>.
10871 (x_own_selection, selection_data_to_lisp_data):
10872 Use INTEGER_TO_CONS.
10873 (x_handle_selection_request, x_handle_selection_clear)
10874 (x_get_foreign_selection, Fx_disown_selection_internal)
10875 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10876 (lisp_data_to_selection_data): Use cons_to_unsigned.
10877 (x_fill_property_data): Use cons_to_signed.
10878 Report values out of range.
10880 Check for buffer and string overflow more precisely.
10881 * buffer.h (BUF_BYTES_MAX): New macro.
10882 * lisp.h (STRING_BYTES_MAX): New macro.
10883 * alloc.c (Fmake_string):
10884 * character.c (string_escape_byte8):
10885 * coding.c (coding_alloc_by_realloc):
10886 * doprnt.c (doprnt):
10887 * editfns.c (Fformat):
10889 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10890 since they may not be the same number.
10891 * editfns.c (Finsert_char):
10892 * fileio.c (Finsert_file_contents):
10893 Likewise for BUF_BYTES_MAX.
10895 * image.c: Use ptrdiff_t, not int, for sizes.
10896 (slurp_file): Switch from int to ptrdiff_t.
10898 (slurp_file): Check that file size fits in both size_t (for
10899 malloc) and ptrdiff_t (for sanity and safety).
10901 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10902 if b->modtime has its maximal value.
10904 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10906 Don't assume time_t can fit into int.
10907 * buffer.h (struct buffer.modtime): Now time_t, not int.
10908 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10909 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10911 Minor fixes for signed vs unsigned integers.
10912 * character.h (MAYBE_UNIFY_CHAR):
10913 * charset.c (maybe_unify_char):
10914 * keyboard.c (read_char, reorder_modifiers):
10915 XINT -> XFASTINT, since the integer must be nonnegative.
10916 * ftfont.c (ftfont_spec_pattern):
10917 * keymap.c (access_keymap, silly_event_symbol_error):
10918 XUINT -> XFASTINT, since the integer must be nonnegative.
10919 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10920 since it makes no difference and we prefer signed.
10921 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10922 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10925 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10927 * window.h (Fwindow_frame): Declare.
10929 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10931 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10932 (SPARE_MEMORY): Always define.
10933 (LARGE_REQUEST): Remove.
10934 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10936 2011-06-06 Martin Rudalics <rudalics@gmx.at>
10938 * lisp.h: Move EXFUNS for Fframe_root_window,
10939 Fframe_first_window and Fset_frame_selected_window to window.h.
10941 * window.h: Move EXFUNS for Fframe_root_window,
10942 Fframe_first_window and Fset_frame_selected_window here from
10945 * frame.c (Fwindow_frame, Fframe_first_window)
10946 (Fframe_root_window, Fframe_selected_window)
10947 (Fset_frame_selected_window): Move to window.c.
10948 (Factive_minibuffer_window): Move to minibuf.c.
10949 (Fother_visible_frames_p): New function.
10951 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10953 * window.c (decode_window, decode_any_window): Move up in code.
10954 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10955 (inhibit_frame_unsplittable): Remove unused variable.
10956 (Fwindow_buffer): Move up and rewrite doc-string.
10957 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10958 (Fwindow_prev): New functions.
10959 (Fwindow_frame): Move here from frame.c. Accept any window as
10961 (Fframe_root_window, Fframe_first_window)
10962 (Fframe_selected_window): Move here from frame.c. Accept frame
10963 or arbitrary window as argument. Update doc-strings.
10964 (Fminibuffer_window): Move up in code.
10965 (Fwindow_minibuffer_p): Move up in code and simplify.
10966 (Fset_frame_selected_window): Move here from frame.c.
10968 (Fselected_window, select_window, Fselect_window): Move up in
10969 code. Minor doc-string fixes.
10971 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10973 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10974 Do not assume that spare memory exists; that assumption is valid
10975 only if SYSTEM_MALLOC.
10976 (LARGE_REQUEST): New macro, so that the issue of large requests
10977 is separated from the issue of spare memory.
10979 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10981 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10984 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10986 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10989 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10991 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10993 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10995 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10996 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10998 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
11000 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
11002 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
11004 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
11005 (x_clipboard_manager_save): Add return value.
11006 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
11007 New error handlers.
11008 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
11009 Obey Vx_select_enable_clipboard_manager. Catch errors in
11010 x_clipboard_manager_save (Bug#8779).
11011 (Vx_select_enable_clipboard_manager): New variable.
11012 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
11014 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
11016 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
11018 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11020 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
11021 in the current matrix if keep_current_p is non-zero.
11023 2011-06-04 Eli Zaretskii <eliz@gnu.org>
11025 * bidi.c (bidi_level_of_next_char): Fix last change.
11027 2011-06-03 Eli Zaretskii <eliz@gnu.org>
11029 Support bidi reordering of text covered by display properties.
11031 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
11032 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
11033 (bidi_cache_search, bidi_cache_iterator_state)
11034 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
11035 (bidi_level_of_next_char, bidi_move_to_visually_next):
11036 Support character positions inside a run of characters covered by a
11038 (bidi_paragraph_init, bidi_resolve_explicit_1)
11039 (bidi_level_of_next_char): Call bidi_fetch_char and
11040 bidi_fetch_char_advance instead of FETCH_CHAR and
11041 FETCH_CHAR_ADVANCE.
11042 (bidi_init_it): Initialize new members.
11043 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
11045 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
11046 instead of using explicit *_CHAR codes.
11047 (bidi_resolve_explicit, bidi_resolve_weak):
11048 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
11049 bidirectional text is supported only in multibyte buffers.
11050 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
11051 it to initialize the frame_window_p member of struct bidi_it.
11052 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
11053 (bidi_resolve_explicit, bidi_resolve_weak)
11054 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
11055 bidi_it->nchars is non-positive.
11056 (bidi_level_of_next_char): Don't try to lookup the cache for the
11057 next/previous character if nothing is cached there yet, or if we
11058 were just reseat()'ed to a new position.
11060 * xdisp.c (set_cursor_from_row): Set start and stop points
11061 according to the row's direction when priming the loop that looks
11062 for the glyph on which to display cursor.
11063 (single_display_spec_intangible_p): Function deleted.
11064 (display_prop_intangible_p): Reimplement to call
11065 handle_display_spec instead of single_display_spec_intangible_p.
11066 Accept 3 additional arguments needed by handle_display_spec.
11067 This fixes incorrect cursor motion across display property with complex
11068 values: lists, `(when COND...)' forms, etc.
11069 (single_display_spec_string_p): Support property values that are
11070 lists with the argument STRING its top-level element.
11071 (display_prop_string_p): Fix the condition for processing a
11072 property that is a list to be consistent with handle_display_spec.
11073 (handle_display_spec): New function, refactored from the
11074 last portion of handle_display_prop.
11075 (compute_display_string_pos): Accept additional argument
11076 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
11077 value of a `display' property is a "replacing spec".
11078 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
11079 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
11080 the display property, but just return a value indicating whether
11081 the display property will replace the characters it covers.
11082 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
11083 frame_window_p members of struct bidi_it.
11084 (compute_display_string_pos, compute_display_string_end):
11086 (push_it): Accept second argument POSITION, where pop_it should
11087 jump to continue iteration.
11088 (reseat_1): Initialize bidi_it.disp_pos.
11090 * keyboard.c (adjust_point_for_property): Adjust the call to
11091 display_prop_intangible_p to its new signature.
11093 * dispextern.h (struct bidi_it): New member frame_window_p.
11094 (bidi_init_it): Update prototypes.
11095 (display_prop_intangible_p): Update prototype.
11096 (compute_display_string_pos, compute_display_string_end):
11097 Declare prototypes.
11098 (struct bidi_it): New members nchars and disp_pos. ch_len is now
11101 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
11103 Malloc failure behavior now depends on size of allocation.
11104 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
11105 * lisp.h: Change signatures accordingly.
11106 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
11107 All callers changed. (Bug#8762)
11109 * gnutls.c: Use Emacs's memory allocators.
11110 Without this change, the gnutls library would invoke malloc etc.
11111 directly, which causes problems on non-SYNC_INPUT hosts, and which
11112 runs afoul of improving memory_full behavior. (Bug#8761)
11113 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
11114 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
11115 xfree instead of the default malloc, realloc, free.
11116 (Fgnutls_boot): No need to check for memory allocation failure,
11117 since xmalloc does that for us.
11119 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
11120 * category.c (hash_get_category_set):
11121 * ccl.c (ccl_driver):
11122 * charset.c (Fdefine_charset_internal):
11123 * charset.h (struct charset.hash_index):
11124 * composite.c (get_composition_id, gstring_lookup_cache)
11125 (composition_gstring_put_cache):
11126 * composite.h (struct composition.hash_index):
11127 * dispextern.h (struct image.hash):
11128 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
11129 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
11130 (hashfn_equal, hashfn_user_defined, make_hash_table)
11131 (maybe_resize_hash_table, hash_lookup, hash_put)
11132 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
11133 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
11134 (Fsxhash, Fgethash, Fputhash, Fmaphash):
11135 * image.c (make_image, search_image_cache, lookup_image)
11136 (xpm_put_color_table_h):
11137 * lisp.h (struct Lisp_Hash_Table):
11138 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
11139 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
11140 for hashes and hash indexes, instead of 'unsigned' and 'int'.
11141 * alloc.c (allocate_vectorlike):
11142 Check for overflow in vector size calculations.
11143 * ccl.c (ccl_driver):
11144 Check for overflow when converting EMACS_INT to int.
11145 * fns.c, image.c: Remove unnecessary static decls that would otherwise
11146 need to be updated by these changes.
11147 * fns.c (make_hash_table, maybe_resize_hash_table):
11148 Check for integer overflow with large hash tables.
11149 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11150 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11151 (SXHASH_REDUCE): New macro.
11152 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11153 Use it instead of discarding useful hash info with large hash values.
11154 (sxhash_float): New function.
11155 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11156 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
11157 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11158 Rewrite to use FIXNUM_BITS, as this simplifies things.
11159 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11160 Adjust signatures to match updated version of code.
11161 (consing_since_gc): Now EMACS_INT, since a single hash table can
11162 use more than INT_MAX bytes.
11164 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11166 Make it possible to build with GCC-4.6+ -O2 -flto.
11168 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11170 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11172 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11173 Call minibuffer-inactive-mode.
11175 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
11177 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11178 Update dependencies.
11180 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11182 * data.c (init_data): Remove code for UTS, this system is not
11185 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11187 Don't force ./temacs to start in terminal mode.
11189 * frame.c (make_initial_frame): Initialize faces in all cases, not
11190 only when CANNOT_DUMP is defined.
11191 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11193 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11195 * dispnew.c (add_window_display_history): Use const for the string
11196 pointer. Remove declaration, not needed.
11198 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11200 Use 'inline', not 'INLINE'.
11201 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
11202 * alloc.c, fontset.c (INLINE): Remove.
11203 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11204 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11205 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11206 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11207 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11209 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11211 Make it possible to run ./temacs.
11213 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11214 syms_of_callproc does the same thing. Remove test for
11215 "initialized", do it in the caller.
11216 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11218 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11220 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11221 (read_minibuf): Use get_minibuffer.
11222 (syms_of_minibuf): Use DEFSYM.
11223 (Qmetadata): New var.
11224 * data.c (Qbuffer): Don't make it static.
11225 (syms_of_data): Use DEFSYM.
11227 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11229 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11230 (CCL_CODE_MIN): New macro.
11232 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11234 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11236 * eval.c (Qdebug): Now static.
11237 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11238 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11239 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11241 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
11243 * image.c: Various fixes to ImageMagick code comments.
11244 (Fimagemagick_types): Doc fix.
11246 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11248 Minor fixes prompted by GCC 4.6.0 warnings.
11250 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11252 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11253 (x_clipboard_manager_save_all): Move extern decl to ...
11254 * xterm.h: ... here, so that it can be checked for consistency.
11256 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
11258 * xselect.c (x_clipboard_manager_save_frame)
11259 (x_clipboard_manager_save_all): New functions.
11260 (Fx_clipboard_manager_save): Lisp function deleted.
11262 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11263 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11265 * xterm.h: Update prototype.
11267 2011-05-28 William Xu <william.xwl@gmail.com>
11269 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11270 exiting (Bug#8239).
11272 2011-05-28 Jim Meyering <meyering@redhat.com>
11274 Avoid a sign-extension bug in crypto_hash_function.
11275 * fns.c (to_uchar): Define.
11276 (crypto_hash_function): Use it to convert some newly-signed
11277 variables to unsigned, to avoid sign-extension bugs. For example,
11278 without this change, (md5 "truc") would evaluate to
11279 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11280 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
11281 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
11283 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11285 Integer overflow fixes.
11287 * dbusbind.c: Serial number integer overflow fixes.
11288 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
11289 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11290 to hold a serial number that is too large for a fixnum.
11291 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11292 Check for serial numbers out of range. Decode any serial number
11293 that was so large that it became a float. (Bug#8722)
11295 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11296 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11297 Use XFASTINT rather than XUINT when numbers are nonnegative.
11298 (xd_append_arg, Fdbus_method_return_internal):
11299 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11300 arguments, check that Lisp number is nonnegative, rather than
11301 silently wrapping negative numbers around. (Bug#8722)
11302 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
11305 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11307 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11309 ccl: Add integer overflow checks.
11310 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11311 (IN_INT_RANGE): New macros.
11312 (ccl_driver): Use them to check for integer overflow when
11313 decoding a CCL program. Many of the new checks are whether XINT (x)
11314 fits in int; it doesn't always, on 64-bit hosts. The new version
11315 doesn't catch all possible integer overflows, but it's an
11316 improvement. (Bug#8719)
11318 * alloc.c (make_event_array): Use XINT, not XUINT.
11319 There's no need for unsigned here.
11321 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11322 This follows up to the 2011-05-06 change that substituted uintptr_t
11323 for EMACS_INT. This case wasn't caught back then.
11325 Rework Fformat to avoid integer overflow issues.
11326 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11327 now (part of C89). Include <verify.h>.
11328 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11329 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11330 (Fformat): Avoid the prepass trying to compute sizes; it was only
11331 approximate and thus did not catch overflow reliably. Instead, walk
11332 through the format just once, formatting and computing sizes as we go,
11333 checking for integer overflow at every step, and allocating a larger
11334 buffer as needed. Keep track separately whether the format is
11335 multibyte. Keep only the most-recently calculated precision, rather
11336 than them all. Record whether each argument has been converted to
11337 string. Use EMACS_INT, not int, for byte and char and arg counts.
11338 Support field widths and precisions larger than INT_MAX. Avoid
11339 sprintf's undefined behavior with conversion specifications such as %#d
11340 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11341 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11342 formatting out-of-range floating point numbers with int
11343 formats. (Bug#8668)
11345 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11347 * data.c: Avoid integer truncation in expressions involving floats.
11348 * data.c: Include <intprops.h>.
11349 (arith_driver): When there's an integer overflow in an expression
11350 involving floating point, convert the integers to floating point
11351 so that the resulting value does not suffer from catastrophic
11352 integer truncation. For example, on a 64-bit host (* 4
11353 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11354 Do not rely on undefined behavior after integer overflow.
11356 merge count_size_as_multibyte, parse_str_to_multibyte
11357 * character.c, character.h (count_size_as_multibyte):
11358 Rename from parse_str_to_multibyte; all uses changed.
11359 Check for integer overflow.
11360 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11361 since it's now a duplicate of the other. This is more of
11362 a character than a buffer op, so better that it's in character.c.
11363 * fns.c, print.c: Adjust to above changes.
11365 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11367 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11369 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11371 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11372 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11373 (x_clipboard_manager_save): Now static.
11374 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11376 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11377 (crypto_hash_function): Now static.
11378 Fix pointer signedness problems. Avoid unnecessary initializations.
11380 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
11382 * termhooks.h (Vselection_alist): Make it terminal-local.
11384 * terminal.c (create_terminal): Initialize it.
11386 * xselect.c: Support for clipboard managers.
11387 (Vselection_alist): Move to termhooks.h as terminal-local var.
11388 (LOCAL_SELECTION): New macro.
11389 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11390 (symbol_to_x_atom): Remove gratuitous arg.
11391 (x_handle_selection_request, lisp_data_to_selection_data)
11392 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
11393 (x_own_selection, x_get_local_selection, x_convert_selection):
11394 New arg, specifying work frame. Use terminal-local Vselection_alist.
11395 (some_frame_on_display): Delete unused function.
11396 (Fx_own_selection_internal, Fx_get_selection_internal)
11397 (Fx_disown_selection_internal, Fx_selection_owner_p)
11398 (Fx_selection_exists_p): New optional frame arg.
11399 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11400 (x_handle_selection_clear): Don't treat other terminals with the
11401 same keyboard specially. Use the terminal-local Vselection_alist.
11402 (x_clear_frame_selections): Use Frun_hook_with_args.
11404 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11406 * xterm.h: Add support for those atoms.
11408 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
11410 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11411 (converted_selections, conversion_fail_tag): New global variables.
11412 (x_selection_request_lisp_error): Free the above.
11413 (x_get_local_selection): Remove unnecessary code.
11414 (x_reply_selection_request): Args changed; handle arbitrary array
11415 of converted selections stored in converted_selections.
11416 Separate the XChangeProperty and SelectionNotify steps.
11417 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11418 (x_convert_selection): New function.
11419 (x_handle_selection_event): Simplify.
11420 (x_get_foreign_selection): Don't ignore incoming requests while
11421 waiting for an answer; this will fail when we implement
11422 SAVE_TARGETS, and seems unnecessary anyway.
11423 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11424 (Vx_sent_selection_functions): Doc fix.
11426 2011-05-26 Leo Liu <sdl.web@gmail.com>
11428 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11430 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11432 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11434 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11435 for fringe update if it has periodic bitmap.
11436 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
11437 and fringe_bitmap_periodic_p.
11439 * fringe.c (get_fringe_bitmap_data): New function.
11440 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11441 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11442 row. Mark glyph row for fringe update if periodicity changed.
11444 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11445 for fringe update unless it has periodic bitmap.
11447 2011-05-25 Kenichi Handa <handa@m17n.org>
11449 * xdisp.c (get_next_display_element): Set correct it->face_id for
11450 a static composition.
11452 2011-05-24 Leo Liu <sdl.web@gmail.com>
11455 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11457 * fns.c (crypto_hash_function, Fsha1): New function.
11458 (Fmd5): Use crypto_hash_function.
11459 (syms_of_fns): Add Ssha1.
11461 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11463 * gnutls.c: Remove unused macros.
11464 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11465 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11466 Remove macros that are defined and never used.
11467 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11469 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
11471 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11472 (Fx_get_selection_internal): Minor cleanup.
11473 (Fx_own_selection_internal): Rename arguments for consistency with
11476 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11478 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11480 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
11482 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11484 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11486 * dispnew.c (scrolling_window): Don't exclude the case that the
11487 last enabled row in the desired matrix touches the bottom boundary.
11489 2011-05-21 Glenn Morris <rgm@gnu.org>
11491 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
11492 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11493 and add some more files.
11495 2011-05-20 Eli Zaretskii <eliz@gnu.org>
11497 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11498 report_file_error introduced by the change from 2011-05-07.
11500 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11502 * systime.h (Time): Define only if emacs is defined.
11503 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11504 where the include path doesn't have X11/X.h by default. See
11505 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11507 2011-05-20 Kenichi Handa <handa@m17n.org>
11509 * composite.c (find_automatic_composition): Fix previous change.
11511 2011-05-20 Glenn Morris <rgm@gnu.org>
11513 * lisp.mk: New file, split from Makefile.in.
11514 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11515 (shortlisp): Remove.
11516 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11518 2011-05-19 Glenn Morris <rgm@gnu.org>
11520 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11521 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11522 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11523 (lisp): Set the order to that of loadup.el.
11524 (shortlisp): Make it a copy of $lisp.
11525 (SOME_MACHINE_LISP): Remove.
11526 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11527 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11529 2011-05-18 Kenichi Handa <handa@m17n.org>
11531 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11532 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11533 (find_automatic_composition): Mostly rewrite for efficiency.
11535 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
11537 * makefile.w32-in: Update dependencies.
11539 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11541 * menu.c: Include limits.h (fixes the MS-Windows build broken by
11542 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
11544 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
11546 Fix some integer overflow issues, such as string length overflow.
11548 * insdel.c (count_size_as_multibyte): Check for string overflow.
11550 * character.c (lisp_string_width): Check for string overflow.
11551 Use EMACS_INT, not int, for string indexes and lengths; in
11552 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11553 the resulting string length overflows an EMACS_INT; instead,
11554 report a string overflow if no precision given. When checking for
11555 precision exhaustion, use a check that cannot possibly have
11556 integer overflow. (Bug#8675)
11557 * character.h (lisp_string_width): Adjust to new signature.
11559 * alloc.c (string_overflow): New function.
11560 (Fmake_string): Use it. This doesn't change behavior, but saves
11561 a few bytes and will simplify future changes.
11562 * character.c (string_escape_byte8): Likewise.
11563 * lisp.h (string_overflow): New decl.
11565 Fixups, following up to the user-interface timestamp change.
11566 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11567 for UI timestamps, instead of unsigned long.
11568 * msdos.c (mouse_get_pos): Likewise.
11569 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
11570 * w32gui.h (Time): Define by including "systime.h" rather than by
11571 declaring it ourselves. (Bug#8664)
11573 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11574 * image.c (clear_image_cache): Likewise.
11576 * term.c (term_mouse_position): Don't assume time_t wraparound.
11578 Be more systematic about user-interface timestamps.
11579 Before, the code sometimes used 'Time', sometimes 'unsigned long',
11580 and sometimes 'EMACS_UINT', to represent these timestamps.
11581 This change causes it to use 'Time' uniformly, as that's what X uses.
11582 This makes the code easier to follow, and makes it easier to catch
11583 integer overflow bugs such as Bug#8664.
11584 * frame.c (Fmouse_position, Fmouse_pixel_position):
11585 Use Time, not unsigned long, for user-interface timestamps.
11586 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11587 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11588 * keyboard.h (last_event_timestamp): Likewise.
11589 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11590 * menu.h (xmenu_show): Likewise.
11591 * term.c (term_mouse_position): Likewise.
11592 * termhooks.h (struct input_event.timestamp): Likewise.
11593 (struct terminal.mouse_position_hook): Likewise.
11594 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11595 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11596 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11597 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11598 what it was before.
11599 * menu.h, termhooks.h: Include "systime.h", for Time.
11601 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11602 Don't assume that the difference between two unsigned long values
11603 can fit into an integer. At this point, we know button_down_time
11604 <= event->timestamp, so the difference must be nonnegative, so
11605 there's no need to cast the result if double-click-time is
11606 nonnegative, as it should be; check that it's nonnegative, just in
11607 case. This bug is triggered when events are more than 2**31 ms
11608 apart (about 25 days). (Bug#8664)
11610 * xselect.c (last_event_timestamp): Remove duplicate decl.
11611 (x_own_selection): Remove needless cast to unsigned long.
11613 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11614 that always fit in int. Use a sentinel instead of a counter, to
11615 avoid a temp and to allay GCC's concerns about possible int overflow.
11616 * frame.h (struct frame): Use int for menu_bar_items_used
11617 instead of EMACS_INT, since it always fits in int.
11619 * menu.c (grow_menu_items): Check for int overflow.
11621 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11623 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11624 Before, the code was not consistent. These values cannot exceed
11625 2**31 - 1 so there's no need to make them unsigned.
11626 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11627 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11628 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11630 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11632 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11633 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11634 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11635 presumably because the widths might not match.
11637 * window.c (size_window): Avoid needless test at loop start.
11639 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11641 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11643 2011-05-12 Drew Adams <drew.adams@oracle.com>
11645 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11647 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11649 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11650 `width' to `bar_area_x' and `bar_area_width', respectively.
11651 (x_scroll_run): Take account of fringe background extension.
11653 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11654 Rename local vars `left' and `width' to `bar_area_x' and
11655 `bar_area_width', respectively.
11656 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11657 background extension.
11659 2011-05-10 Jim Meyering <meyering@redhat.com>
11661 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11663 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
11665 * image.c (Finit_image_library): Return t for built-in image types,
11666 like pbm and xbm. (Bug#8640)
11668 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11670 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11672 2011-05-07 Eli Zaretskii <eliz@gnu.org>
11674 * w32console.c (Fset_screen_color): Doc fix.
11675 (Fget_screen_color): New function.
11676 (syms_of_ntterm): Defsubr it.
11678 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11679 unlink the temporary file if Fcall_process didn't create it in the
11681 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11682 child process will be redirected to a file specified with `:file'.
11683 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11684 cue to call_process_cleanup not to close that handle.
11686 2011-05-07 Ben Key <bkey76@gmail.com>
11688 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11689 one of two shell specific rules, either bootstrap-temacs-CMD or
11690 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11691 to the previous implementation of the bootstrap-temacs rule.
11692 The bootstrap-temacs-CMD rule is similar to the previous
11693 implementation of the bootstrap-temacs rule except that it
11694 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11697 These changes, along with some changes to nt/configure.bat,
11698 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11699 earlier fix to add support for --cflags and --ldflags options
11700 that include quotes so that it works whether make uses cmd or
11703 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
11705 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11706 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11708 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11709 a string. Handle both cases.
11710 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11711 (Fdbus_register_method): Use Qinvalid_function.
11713 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
11715 * makefile.w32-in: Update dependencies.
11716 (LISP_H): Add inttypes.h and stdin.h.
11717 (PROCESS_H): Add unistd.h.
11719 2011-05-06 Eli Zaretskii <eliz@gnu.org>
11721 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11722 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11724 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
11726 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11728 * term.c (vfatal): Remove stray call to va_end.
11729 It's not needed and the C Standard doesn't allow it here anyway.
11731 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11732 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11734 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11737 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11739 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11741 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11743 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11745 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11747 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11748 * charset.c (Fdefine_charset_internal): Don't initialize
11749 charset.code_space[15]. The value was garbage, on hosts with
11750 32-bit int (Bug#8600).
11752 * lread.c (read_integer): Be more consistent with string-to-number.
11753 Use string_to_number to do the actual conversion; this avoids
11754 rounding errors and fixes some other screwups. Without this fix,
11755 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11756 (digit_to_number): Move earlier, for benefit of read_integer.
11757 Return -1 if the digit is out of range for the base, -2 if it is
11758 not a digit in any supported base. (Bug#8602)
11760 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11762 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11763 to match comment at start of function. This also removes a
11764 GCC warning about overflow in a 32+64-bit port.
11766 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11768 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11769 Reported by Stefan Monnier in
11770 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
11771 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11772 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
11774 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11775 (EMACS_UINTPTR): Likewise, with uintptr_t.
11777 * lisp.h: Prefer 64-bit EMACS_INT if available.
11778 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11779 on 32-bit hosts that have 64-bit int, so that they can access
11781 However, temporarily disable this change unless the temporary
11782 symbol WIDE_EMACS_INT is defined.
11784 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11786 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11787 This removes an assumption that EMACS_INT and long are the same
11788 width as pointers. The assumption is true for Emacs porting targets
11789 now, but we want to make other targets possible.
11790 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11791 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11792 In the rest of the code, change types of integers that hold casted
11793 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11794 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11795 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11796 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11797 No need to cast type when ORing.
11798 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11799 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11800 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11801 assume EMACS_INT is the same width as char *.
11802 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11803 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11804 Remove no-longer-needed casts.
11805 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11806 (xg_tool_bar_help_callback, xg_make_tool_item):
11807 Use EMACS_INTPTR to hold an integer
11808 that will be cast to void *; this can avoid a GCC warning
11809 if EMACS_INT is not the same width as void *.
11810 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11811 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11812 (current_message_1, set_message_1):
11813 Use a local to convert to proper width without a cast.
11814 * xmenu.c (dialog_selection_callback): Likewise.
11816 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11817 Also, don't assume VALBITS / RAND_BITS is less than 5,
11818 and don't rely on undefined behavior when shifting a 1 left into
11820 * lisp.h (get_random): Change signature to match.
11822 * lread.c (hash_string): Use size_t, not int, for hash computation.
11823 Normally we prefer signed values; but hashing is special, because
11824 it's better to use unsigned division on hash table sizes so that
11825 the remainder is nonnegative. Also, size_t is the natural width
11826 for hashing into memory. The previous code used 'int', which doesn't
11827 retain enough info to hash well into very large tables.
11828 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11830 * dbusbind.c: Don't possibly lose pointer info when converting.
11831 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11832 Use XPNTR rather than XHASH, so that the high-order bits of
11833 the pointer aren't lost when converting through void *.
11835 * eval.c (Fautoload): Don't double-shift a pointer.
11837 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11839 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
11841 * gnutls.c (DEF_GNUTLS_FN):
11842 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11844 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11846 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11849 2011-05-05 Eli Zaretskii <eliz@gnu.org>
11851 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11852 New version that can reserve upto 2GB of heap space.
11854 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
11856 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11858 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11860 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11861 `gnutls_certificate_set_x509_key_file'.
11863 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
11865 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11866 Update dependencies.
11868 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11870 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11871 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11872 Remove unused parameter `fildes'.
11873 * process.c (read_process_output, send_process): Don't pass it.
11875 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11877 Fix previous change: the library cache is defined in w32.c.
11878 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11879 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11881 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11883 Implement dynamic loading of GnuTLS on Windows.
11885 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11886 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11887 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11890 * gnutls.c (Qgnutls_dll): Define.
11891 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11892 (gnutls_*): Declare function pointers.
11893 (init_gnutls_functions): New function to initialize function pointers.
11894 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11895 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11896 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11897 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11898 (emacs_gnutls_write, emacs_gnutls_read)
11899 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11900 (Fgnutls_available_p): New function.
11901 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11902 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11903 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11905 * image.c: Include w32.h.
11906 (Vimage_type_cache): Delete.
11907 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11908 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11909 (w32_delayed_load): Move to w32.c.
11911 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11913 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11914 (w32_delayed_load): Move from image.c. When loading a library, record
11915 its filename in the :loaded-from property of the library id.
11916 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11917 Initialize and staticpro them.
11918 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11920 * process.c: Include lisp.h before w32.h, not after.
11921 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11922 instead of gnutls_record_check_pending.
11924 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11926 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11928 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11929 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11932 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11934 * xterm.c (x_set_frame_alpha): Do not set property on anything
11935 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11937 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
11939 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11941 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
11943 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11944 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11945 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11946 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11947 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11948 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11949 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11950 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11951 (Qgnutls_bootprop_callbacks_verify): Make static.
11953 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11955 * callproc.c: Indentation fixup.
11957 * sysdep.c (wait_for_termination_1): Make static.
11958 (wait_for_termination, interruptible_wait_for_termination):
11959 Move after wait_for_termination_1.
11961 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11963 * sysdep.c (interruptible_wait_for_termination): New function
11964 which is like wait_for_termination, but allows keyboard
11967 * callproc.c (Fcall_process): Add (:file "file") as an option for
11969 (Fcall_process_region): Ditto.
11971 2011-04-30 Eli Zaretskii <eliz@gnu.org>
11973 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11974 rather than `XVECTOR (FOO)->size'.
11976 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11977 inttypes.h, as a gnulib replacement is used if it not available in
11980 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11982 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11983 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11984 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11986 * coding.c (coding_alloc_by_realloc): Error out if destination
11987 will grow beyond MOST_POSITIVE_FIXNUM.
11988 (decode_coding_emacs_mule): Abort if there isn't enough place in
11989 charbuf for the composition carryover bytes. Reserve an extra
11990 space for up to 2 characters produced in a loop.
11991 (decode_coding_iso_2022): Abort if there isn't enough place in
11992 charbuf for the composition carryover bytes.
11994 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11996 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11997 aborting when %lld or %lll format is passed.
11998 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11999 %llo or %llx format is passed. (Bug#8545)
12001 * window.c (window_scroll_line_based): Use a marker instead of
12002 simple variables to record original value of point. (Bug#7952)
12004 * doprnt.c (doprnt): Fix the case where a multibyte sequence
12005 produced by %s or %c overflows available buffer space. (Bug#8545)
12007 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
12009 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
12010 (SIZE_MAX): Move defn after all includes, as they might #define it.
12012 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
12014 * w32.c (init_environment): Warn about defaulting HOME to C:\.
12016 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
12018 * keyboard.c (Qdelayed_warnings_hook): Define.
12019 (command_loop_1): Run `delayed-warnings-hook'
12020 if Vdelayed_warnings_list is non-nil.
12021 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
12022 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
12024 2011-04-28 Eli Zaretskii <eliz@gnu.org>
12026 * doprnt.c (doprnt): Don't return value smaller than the buffer
12027 size if the message was truncated. (Bug#8545).
12029 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
12031 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
12032 (Fx_window_property): #if-0 the whole functions, not just the bodies.
12034 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12036 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
12038 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
12040 * makefile.w32-in: Update dependencies.
12042 2011-04-27 Eli Zaretskii <eliz@gnu.org>
12044 Improve `doprnt' and its usage. (Bug#8545)
12045 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
12046 `format_end'. Remove support for %l as a conversion specifier.
12047 Don't use xrealloc. Improve diagnostics when the %l size modifier
12048 is used. Update the commentary.
12050 * eval.c (verror): Simplify calculation of size_t.
12052 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
12055 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
12057 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
12060 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12062 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
12063 This makes this file independent of the recent pseudovector change.
12065 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
12067 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
12069 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
12070 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
12071 Remove unused local.
12072 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
12074 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
12075 GCC 4.6.0 optimizes based on type-based alias analysis.
12076 For example, if b is of type struct buffer * and v of type struct
12077 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
12078 != &v->size, and therefore "v->size = 1; b->size = 2; return
12079 v->size;" must therefore return 1. This assumption is incorrect
12080 for Emacs, since it type-puns struct Lisp_Vector * with many other
12081 types. To fix this problem, this patch adds a new type struct
12082 vectorlike_header that documents the constraints on layout of vectors
12083 and pseudovectors, and helps optimizing compilers not get fooled
12084 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
12085 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
12086 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
12088 (XSETPVECTYPE): Rewrite in terms of new macro.
12089 (XSETPVECTYPESIZE): New macro, specifying both type and size.
12090 This is a bit clearer, and further avoids the possibility of
12091 undesirable aliasing.
12092 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
12093 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
12094 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
12095 since Lisp_Subr is a special case (no "next" field).
12096 (ASIZE): Now uses header.size rather than size.
12097 All previous uses of XVECTOR (foo)->size replaced to use this macro,
12098 to avoid the hassle of writing XVECTOR (foo)->header.size.
12099 (struct vectorlike_header): New type.
12100 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
12101 object, to help avoid aliasing.
12102 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
12103 (SUBRP): Likewise, since Lisp_Subr is a special case.
12104 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
12105 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
12106 (struct Lisp_Hash_Table): Combine first two members into a single
12107 struct vectorlike_header member. All uses of "size" and "next" members
12108 changed to be "header.size" and "header.next".
12109 * buffer.h (struct buffer): Likewise.
12110 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
12111 * frame.h (struct frame): Likewise.
12112 * process.h (struct Lisp_Process): Likewise.
12113 * termhooks.h (struct terminal): Likewise.
12114 * window.c (struct save_window_data, struct saved_window): Likewise.
12115 * window.h (struct window): Likewise.
12116 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
12117 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
12118 * buffer.c (init_buffer_once): Likewise.
12119 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
12121 * process.c (Fformat_network_address): Use local var for size,
12124 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
12126 Make the Lisp reader and string-to-float more consistent (Bug#8525)
12127 * data.c (atof): Remove decl; no longer used or needed.
12128 (digit_to_number): Move to lread.c.
12129 (Fstring_to_number): Use new string_to_number function, to be
12130 consistent with how the Lisp reader treats infinities and NaNs.
12131 Do not assume that floating-point numbers represent EMACS_INT
12132 without losing information; this is not true on most 64-bit hosts.
12133 Avoid double-rounding errors, by insisting on integers when
12134 parsing non-base-10 numbers, as the documentation specifies.
12135 * lisp.h (string_to_number): New decl, replacing ...
12136 (isfloat_string): Remove.
12137 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
12138 (read1): Do not accept +. and -. as integers; this
12139 appears to have been a coding error. Similarly, do not accept
12140 strings like +-1e0 as floating point numbers. Do not report
12141 overflow for integer overflows unless the base is not 10 which
12142 means we have no simple and reliable way to continue.
12143 Break out the floating-point parsing into a new
12144 function string_to_number, so that Fstring_to_number parses
12145 floating point numbers consistently with the Lisp reader.
12146 (digit_to_number): Move here from data.c. Make it static inline.
12147 (E_CHAR, EXP_INT): Remove, replacing with ...
12148 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12149 (string_to_number): New function, replacing isfloat_string.
12150 This function checks for valid syntax and produces the resulting
12151 Lisp float number too. Rework it so that string-to-number
12152 no longer mishandles examples like "1.0e+". Use strtoumax,
12153 so that overflow for non-base-10 numbers is reported only when
12154 there's no portable and simple way to convert to floating point.
12156 * textprop.c (set_text_properties_1): Rewrite for clarity,
12157 and to avoid GCC warning about integer overflow.
12159 * intervals.h (struct interval): Use EMACS_INT for members
12160 where EMACS_UINT might cause problems. See
12161 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12162 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12163 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12165 (offset_intervals): Tell GCC not to worry about length overflow
12166 when negating a negative length.
12168 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12169 (overrun_check_free): Likewise.
12171 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12172 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12175 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12176 (gnutls_make_error): Rename local to avoid shadowing.
12177 (gnutls_emacs_global_deinit): ifdef out; not used.
12178 (Fgnutls_boot): Use const for pointer to readonly storage.
12179 Comment out unused local. Fix pointer signedness problems.
12181 * lread.c (openp): Don't stuff size_t into an 'int'.
12182 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12183 about possible signed overflow.
12185 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12186 (GDK_KEY_g): Don't define if already defined.
12187 (xg_prepare_tooltip): Avoid pointer signedness problem.
12188 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12190 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12191 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12193 * xfns.c (Fx_window_property): Simplify a bit,
12194 to make a bit faster and to avoid GCC 4.6.0 warning.
12195 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12197 * fns.c (internal_equal): Don't assume size_t fits in int.
12199 * alloc.c (compact_small_strings): Tighten assertion a little.
12201 Replace pEd with more-general pI, and fix some printf arg casts.
12202 * lisp.h (pI): New macro, generalizing old pEd macro to other
12203 conversion specifiers. For example, use "...%"pI"d..." rather
12204 than "...%"pEd"...".
12205 (pEd): Remove. All uses replaced with similar uses of pI.
12206 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
12207 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12208 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12209 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12210 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12211 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12212 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12214 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12215 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12216 * print.c (safe_debug_print, print_object): Likewise.
12217 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12219 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12220 avoiding the 0 flag, which is not portable.
12221 * process.c (Fmake_network_process): Use pI to avoid cast.
12222 * region-cache.c (pp_cache): Likewise.
12223 * xdisp.c (decode_mode_spec): Likewise.
12224 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12225 behavior on 64-bit hosts with printf arg.
12226 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
12227 (x_stop_queuing_selection_requests): Likewise.
12228 (x_get_window_property): Don't truncate byte count to an 'int'
12231 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12232 here, since it parses constructs like leading '-' and spaces,
12233 which are not wanted; and it overflows with large numbers.
12234 Instead, simply match F[0-9]+, which is what is wanted anyway.
12236 * alloc.c: Remove unportable assumptions about struct layout.
12237 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12238 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12239 (allocate_vectorlike, make_pure_vector): Use the new macros,
12240 plus offsetof, to remove unportable assumptions about struct layout.
12241 These assumptions hold on all porting targets that I know of, but
12242 they are not guaranteed, they're easy to remove, and removing them
12243 makes further changes easier.
12245 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12246 This doesn't fix a bug but makes the code clearer.
12247 (string_overrun_cookie): Now const. Use initializers that
12248 don't formally overflow signed char, to avoid warnings.
12249 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12250 can cause Emacs to crash when string overrun checking is enabled.
12251 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12252 multiple of sizeof (EMACS_INT); it need not be, if
12253 alignof(EMACS_INT) < sizeof (EMACS_INT).
12254 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
12256 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
12258 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12260 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12262 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
12263 supposed to be handshaking. (Bug#8556)
12264 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12266 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
12268 * lisp.h (Qdebug): List symbol.
12269 * eval.c (Qdebug): Restore global linkage.
12270 * keyboard.c (debug-on-event): New variable.
12271 (handle_user_signal): Break into debugger when debug-on-event
12272 matches the current signal symbol.
12274 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12276 * alloc.c (check_sblock, check_string_bytes)
12277 (check_string_free_list): Convert to standard C.
12279 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12281 * w32.c (emacs_gnutls_push): Fix typo.
12283 2011-04-25 Eli Zaretskii <eliz@gnu.org>
12285 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12286 "cast to pointer from integer of different size".
12288 Improve doprnt and its use in verror. (Bug#8545)
12289 * doprnt.c (doprnt): Document the set of format control sequences
12290 supported by the function. Use SAFE_ALLOCA instead of always
12293 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12294 is one byte too soon. Don't use xrealloc; instead xfree and
12297 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12299 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12302 * gnutls.c: Renamed global_initialized to
12303 gnutls_global_initialized. Added internals for the
12304 :verify-hostname-error, :verify-error, and :verify-flags
12305 parameters of `gnutls-boot' and documented those parameters in the
12306 docstring. Start callback support.
12307 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12308 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12309 on error. Return error code.
12310 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12311 (emacs_gnutls_read): Likewise.
12312 (Fgnutls_boot): Return handshake error code.
12313 (emacs_gnutls_handle_error): New function.
12314 (wsaerror_to_errno): Likewise.
12316 * w32.h (emacs_gnutls_pull): Add prototype.
12317 (emacs_gnutls_push): Likewise.
12319 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12320 (emacs_gnutls_push): Likewise.
12322 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12324 * process.c (wait_reading_process_output): Check if GnuTLS
12325 buffered some data internally if no FDs are set for TLS
12328 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12329 (LIBS): Link to USER_LIBS.
12330 ($(BLD)/gnutls.$(0)): New target.
12332 2011-04-24 Eli Zaretskii <eliz@gnu.org>
12334 * xdisp.c (handle_single_display_spec): Rename the
12335 display_replaced_before_p argument into display_replaced_p, to
12336 make it consistent with the commentary. Fix typos in the
12339 * textprop.c (syms_of_textprop): Remove dead code.
12340 (copy_text_properties): Delete obsolete commentary about an
12341 interface that was deleted long ago. Fix typos in the description
12344 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12345 to changes in oldXMenu/XMenu.h from 2011-04-16.
12346 <menu_help_message, prev_menu_help_message>: Constify.
12347 (IT_menu_make_room): menu->help_text is now `const char **';
12350 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12351 to changes in oldXMenu/XMenu.h from 2011-04-16.
12352 (struct XMenu): Declare `help_text' `const char **'.
12354 * xfaces.c <Qunspecified>: Make extern again.
12356 * syntax.c: Include sys/types.h before including regex.h, as
12359 * doc.c (get_doc_string): Improve the format passed to `error'.
12361 * doprnt.c (doprnt): Improve commentary.
12363 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12365 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12368 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12369 changes in globals.h immediately force recompilation.
12370 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12371 $(CURDIR)/s/ms-w32.h.
12372 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
12374 * character.c (Fchar_direction): Function deleted.
12375 (syms_of_character): Don't defsubr it.
12376 <char-direction-table>: Deleted.
12378 2011-04-23 Eli Zaretskii <eliz@gnu.org>
12380 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12381 * doprnt.c: Include limits.h.
12382 (SIZE_MAX): New macro.
12383 (doprnt): Return a size_t value. 2nd arg is now size_t.
12384 Many local variables are now size_t instead of int or unsigned.
12385 Improve overflow protection. Support `l' modifier for integer
12386 conversions. Support %l conversion. Don't assume an EMACS_INT
12387 argument for integer conversions and for %c.
12389 * lisp.h (doprnt): Restore prototype.
12391 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12392 $(SRC)/character.h.
12394 * Makefile.in (base_obj): Add back doprnt.o.
12396 * deps.mk (doprnt.o): Add back prerequisites.
12397 (callint.o): Depend on character.h.
12399 * eval.c (internal_lisp_condition_case): Include the handler
12400 representation in the error message.
12401 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12402 when breaking from the loop.
12404 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12406 * callint.c (Fcall_interactively): When displaying error message
12407 about invalid control letter, pass the character's codepoint, not
12408 a pointer to its multibyte form. Improve display of the character
12409 in octal and display also its hex code.
12411 * character.c (char_string): Use %x to display the (unsigned)
12412 codepoint of an invalid character, to avoid displaying a bogus
12415 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12416 `error', not SYMBOL_NAME itself.
12418 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12419 character arguments to `error'.
12421 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12422 to `error' in error message about FINAL_CHAR argument. Make sure
12423 FINAL_CHAR is a character, and use %c when it is passed as
12424 argument to `error'.
12426 2011-04-23 Eli Zaretskii <eliz@gnu.org>
12428 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12430 * w32.c: Include <time.h>.
12431 (sys_localtime): New function.
12433 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
12435 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12437 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
12439 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
12441 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12442 zombies (Bug#8467).
12444 2011-04-19 Eli Zaretskii <eliz@gnu.org>
12446 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12447 gl_state.e_property when gl_state.object is Qt.
12449 * insdel.c (make_gap_larger): Remove limitation of buffer size
12452 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
12454 * xdisp.c (lookup_glyphless_char_display)
12455 (produce_glyphless_glyph): Handle cons cell entry in
12456 glyphless-char-display.
12457 (Vglyphless_char_display): Document it.
12459 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12460 glyphless-char-display.
12462 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
12464 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12466 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12468 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12469 definition for no-X builds.
12471 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
12473 Static checks with GCC 4.6.0 and non-default toolkits.
12475 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12477 * process.c (keyboard_bit_set): Define only if SIGIO.
12478 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12479 (send_process): Repair possible setjmp clobbering.
12481 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12483 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12485 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12487 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12488 Define only if needed.
12490 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12491 by pacifying GCC about it. Maybe it's time to retire it?
12492 * xfaces.c (USG, __TIMEVAL__): Likewise.
12494 * dispextern.h (struct redisplay_interface): Rename param
12495 to avoid shadowing.
12496 * termhooks.h (struct terminal): Likewise.
12497 * xterm.c (xembed_send_message): Likewise.
12499 * insdel.c (make_gap_smaller): Define only if
12500 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12502 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12505 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12506 so that we aren't warned about unused symbols.
12508 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12510 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
12512 * xfns.c (x_real_positions): Mark locals as initialized.
12514 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12516 * xterm.c: Fix problems found by static analysis with other toolkits.
12517 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
12518 (x_dispatch_event): Declare static if USE_GTK, and
12519 define if USE_GTK || USE_X_TOOLKIT.
12520 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
12521 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
12522 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12523 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
12525 * xmenu.c (menu_help_callback): Pointer type fixes.
12526 Use const pointers when pointing at readonly data. Avoid pointer
12527 signedness clashes.
12528 (FALSE): Remove unused macro.
12529 (update_frame_menubar): Remove unused decl.
12531 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12533 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12534 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12535 (single_menu_item): Rename local to avoid shadowing.
12537 * keyboard.c (make_lispy_event): Remove unused local var.
12539 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12540 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12542 * bitmaps: Change bitmaps from unsigned char back to the X11
12543 compatible char. Avoid the old compiler warnings about
12544 out-of-range initializers by using, for example, '\xab' rather
12547 * xgselect.c (xgselect_initialize): Check vs interface
12548 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12550 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12552 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12553 to read-only memory.
12555 * fns.c (vector): Remove; this old hack is no longer needed.
12557 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
12559 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
12561 * xrdb.c (x_load_resources): Omit unused local.
12563 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
12564 (x_window): Rename locals to avoid shadowing.
12565 (USG): Use the kludged USG macro, to pacify gcc.
12567 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
12568 (x_term_init): Remove local to avoid shadowing.
12570 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
12572 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12573 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12575 2011-04-16 Eli Zaretskii <eliz@gnu.org>
12577 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12579 Fix regex.c, syntax.c and friends for buffers > 2GB.
12580 * syntax.h (struct gl_state_s): Declare character position members
12583 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12585 * textprop.c (verify_interval_modification, interval_of):
12586 Declare arguments EMACS_INT.
12588 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12591 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12593 * indent.c (Fvertical_motion): Local variable it_start is now
12596 * regex.c (re_match, re_match_2, re_match_2_internal)
12597 (bcmp_translate, regcomp, regexec, print_double_string)
12598 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12599 (re_compile_pattern, re_exec): Declare arguments and local
12600 variables `size_t' and `ssize_t' and return values `regoff_t', as
12602 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12603 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12604 <compile_stack_type>: `size' and `avail' are now `size_t'.
12606 * regex.h <regoff_t>: Use ssize_t, not int.
12607 (re_search, re_search_2, re_match, re_match_2): Arguments that
12608 specify buffer/string position and length are now ssize_t and
12609 size_t. Return type is regoff_t.
12611 2011-04-16 Ben Key <bkey76@gmail.com>
12613 * nsfont.m: Fixed bugs in ns_get_family and
12614 ns_descriptor_to_entity that were caused by using free to
12615 deallocate memory blocks that were allocated by xmalloc (via
12616 xstrdup). This caused Emacs to crash when compiled with
12617 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12618 --enable-checking=xmallocoverrun). xfree is now used to
12619 deallocate these memory blocks.
12621 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
12623 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12625 emacs_write: Accept and return EMACS_INT for sizes.
12626 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12628 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12629 Accept and return EMACS_INT.
12630 (emacs_gnutls_write): Return the number of bytes written on
12632 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
12633 (emacs_read, emacs_write): Remove check for negative size, as the
12634 Emacs source code has been audited now.
12635 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12636 (emacs_read, emacs_write): Use it.
12637 * process.c (send_process): Adjust to the new signatures of
12638 emacs_write and emacs_gnutls_write. Do not attempt to store
12639 a byte offset into an 'int'; it might overflow.
12640 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
12642 * sound.c: Don't assume sizes fit in 'int'.
12643 (struct sound_device.period_size, alsa_period_size):
12644 Return EMACS_INT, not int.
12645 (struct sound_device.write, vox_write, alsa_write):
12646 Accept EMACS_INT, not int.
12647 (wav_play, au_play): Use EMACS_INT to store sizes and to
12648 record read return values.
12650 2011-04-15 Ben Key <bkey76@gmail.com>
12652 * keyboard.c (Qundefined): Don't declare static since it is used
12654 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12655 static since they are used in nsfont.m.
12657 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12659 * process.c (Qprocessp): Don't declare static.
12660 * lisp.h (Qprocessp): Declare again.
12662 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
12664 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12666 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12668 Improve C-level modularity by making more things 'static'.
12670 Don't publish debugger-only interfaces to other modules.
12671 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12672 (verify_bytepos, count_markers): Move decls to the only modules
12674 * region-cache.h (pp_cache): Likewise.
12675 * window.h (check_all_windows): Likewise.
12676 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12678 * sysdep.c (croak): Now static, if
12679 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12680 * syssignal.h (croak): Declare only if not static.
12682 * alloc.c (refill_memory_reserve): Now static if
12683 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12684 * lisp.h (refill_memory_reserve): Declare only if not static.
12686 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12687 Define only if USE_LUCID.
12689 * xrdb.c (x_customization_string, x_rm_string): Now static.
12691 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12692 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12694 * xdisp.c (draw_row_with_mouse_face): Now static.
12695 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12697 * window.h (check_all_windows): Mark externally visible.
12699 * window.c (window_deletion_count): Now static.
12701 * undo.c: Make symbols static if they're not exported.
12702 (last_undo_buffer, last_boundary_position, pending_boundary):
12705 * textprop.c (interval_insert_behind_hooks): Now static.
12706 (interval_insert_in_front_hooks): Likewise.
12708 * term.c: Make symbols static if they're not exported.
12709 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12710 (max_frame_lines, tty_set_terminal_modes):
12711 (tty_reset_terminal_modes, tty_turn_off_highlight):
12712 (get_tty_terminal): Now static.
12713 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12714 * termhooks.h (term_mouse_moveto): Do not declare if
12715 HAVE_WINDOW_SYSTEM.
12716 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12717 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12719 * sysdep.c: Make symbols static if they're not exported.
12720 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12722 (sigprocmask_set, full_mask): Remove; unused.
12723 (wait_debugging): Mark as visible.
12724 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12725 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12727 * syntax.c (syntax_temp): Define only if !__GNUC__.
12729 * sound.c (current_sound_device, current_sound): Now static.
12731 * search.c (searchbufs, searchbuf_head): Now static.
12733 * scroll.c (scroll_cost): Remove; unused.
12734 * dispextern.h (scroll_cost): Remove decl.
12736 * region-cache.h (pp_cache): Mark as externally visible.
12738 * process.c: Make symbols static if they're not exported.
12739 (process_tick, update_tick, create_process, chan_process):
12740 (Vprocess_alist, proc_buffered_char, datagram_access):
12741 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12742 (deactivate_process): Mark defn as static, as well as decl.
12743 * lisp.h (create_process): Remove decl.
12744 * process.h (chan_process, Vprocess_alist): Remove decls.
12746 * print.c: Make symbols static if they're not exported.
12747 (print_depth, new_backquote_output, being_printed, print_buffer):
12748 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12749 (print_interval, print_number_index, initial_stderr_stream):
12751 * lisp.h (Fprinc): Remove decl.
12752 (debug_output_compilation_hack): Mark as externally visible.
12754 * sysdep.c (croak): Move decl from here to syssignal.h.
12755 * syssignal.h (croak): Put it here, so the API can be checked when
12756 'croak' is called from dissociate_if_controlling_tty.
12758 * minibuf.c: Make symbols static if they're not exported.
12759 (minibuf_save_list, choose_minibuf_frame): Now static.
12760 * lisp.h (choose_minibuf_frame): Remove decl.
12762 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12764 * lread.c: Make symbols static if they're not exported.
12765 (read_objects, initial_obarray, oblookup_last_bucket_number):
12767 (make_symbol): Remove; unused.
12768 * lisp.h (initial_obarray, make_symbol): Remove decls.
12770 * keyboard.c: Make symbols static if they're not exported.
12771 (single_kboard, recent_keys_index, total_keys, recent_keys):
12772 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12773 (this_single_command_key_start, echoing, last_auto_save):
12774 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12775 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12776 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12777 (Vlispy_mouse_stem, double_click_count):
12779 (force_auto_save_soon): Define only if SIGDANGER.
12780 (ignore_mouse_drag_p): Now static if
12781 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12782 (print_help): Remove; unused.
12783 (stop_character, last_timer_event): Mark as externally visible.
12784 * keyboard.h (ignore_mouse_drag_p): Declare only if
12785 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12786 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12787 * lisp.h (echoing): Remove decl.
12788 (force_auto_save_soon): Declare only if SIGDANGER.
12789 * xdisp.c (redisplay_window): Simplify code, to make it more
12790 obvious that ignore_mouse_drag_p is not accessed if !defined
12791 USE_GTK && !defined HAVE_NS.
12793 * intervals.c: Make symbols static if they're not exported.
12794 (merge_properties_sticky, merge_interval_right, delete_interval):
12796 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12798 * insdel.c: Make symbols static if they're not exported.
12799 However, leave prepare_to_modify_buffer alone. It's never
12800 called from outside this function, but that appears to be a bug.
12801 (combine_after_change_list, combine_after_change_buffer):
12802 (adjust_after_replace, signal_before_change): Now static.
12803 (adjust_after_replace_noundo): Remove; unused.
12804 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
12805 (signal_before_change): Remove decls.
12807 * indent.c (val_compute_motion, val_vmotion): Now static.
12809 * image.c: Make symbols static if they're not exported.
12810 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12812 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12813 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12815 * fringe.c (standard_bitmaps): Now static.
12816 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12818 * frame.c: Make symbols static if they're not exported.
12819 (x_report_frame_params, make_terminal_frame): Now static.
12820 (get_frame_param): Now static, unless HAVE_NS.
12821 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12822 (x_get_resource_string): Remove; not used.
12823 * frame.h (make_terminal_frame, x_report_frame_params):
12824 (x_get_resource_string); Remove decls.
12825 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12826 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12828 * font.c, fontset.c: Make symbols static if they're not exported.
12829 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12830 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12831 * font.c (font_close_object): Now static.
12832 * font.h (font_close_object): Remove.
12833 * fontset.c (FONTSET_OBJLIST): Remove.
12834 (free_realized_fontset) #if-0 the body, which does nothing.
12835 (face_suitable_for_char_p): #if-0, as it's never called.
12836 * fontset.h (face_suitable_for_char_p): Remove decl.
12837 * xfaces.c (face_at_string_position):
12838 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
12839 since 0 is always ASCII.
12841 * fns.c (weak_hash_tables): Now static.
12843 * fileio.c: Make symbols static if they're not exported.
12844 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12845 (Vwrite_region_annotation_buffers): Now static.
12847 * eval.c: Make symbols static if they're not exported.
12848 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12849 * lisp.h (backtrace_list): Remove decl.
12851 * emacs.c: Make symbols static if they're not exported.
12852 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12853 (fatal_error_code, fatal_error_signal_hook, standard_args):
12855 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12856 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12857 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12858 * lisp.h (fatal_error_signal_hook): Remove decl.
12859 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12861 * editfns.c: Move a (normally-unused) function to its only use.
12862 * editfns.c, lisp.h (get_operating_system_release): Remove.
12863 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12864 worth the hassle of breaking this out.
12866 * xterm.c: Make symbols static if they're not exported.
12867 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12868 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12869 (x_destroy_window, x_delete_display):
12871 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12872 (x_mouse_leave): Remove; unused.
12873 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12874 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12875 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12877 (x_mouse_leave): Declare only if WINDOWSNT.
12878 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12879 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12882 * ftxfont.c: Make symbols static if they're not exported.
12883 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12885 * font.h (ftxfont_driver): Likewise.
12887 * xfns.c: Make symbols static if they're not exported.
12888 (x_last_font_name, x_display_info_for_name):
12889 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12890 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12891 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12892 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12893 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12894 (last_show_tip_args): Now static.
12895 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12896 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12897 (x_screen_planes): Remove; unused.
12898 * dispextern.h (x_screen_planes): Remove decl.
12900 * dispnew.c: Make symbols static if they're not exported.
12901 * dispextern.h (redraw_garbaged_frames, scrolling):
12902 (increment_row_positions): Remove.
12903 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12904 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12906 (redraw_garbaged_frames): Remove; unused.
12908 * xfaces.c: Make symbols static if they're not exported.
12909 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12911 * xterm.h (defined_color): Remove decls.
12912 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12913 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12914 (menu_face_changed_default, defined_color, free_realized_face):
12915 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12916 (ascii_face_of_lisp_face): Remove; unused.
12918 * xdisp.c: Make symbols static if they're not exported.
12919 * dispextern.h (scratch_glyph_row, window_box_edges):
12920 (glyph_to_pixel_coords, set_cursor_from_row):
12921 (get_next_display_element, set_iterator_to_next):
12922 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12923 (show_mouse_face): Remove decls
12924 * frame.h (message_buf_print): Likewise.
12925 * lisp.h (pop_message, set_message, check_point_in_composition):
12927 * xterm.h (set_vertical_scroll_bar): Likewise.
12928 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12929 (message_buf_print, scratch_glyph_row, displayed_buffer):
12930 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12931 (get_next_display_element, show_mouse_face, window_box_edges):
12932 (frame_to_window_pixel_xy, check_point_in_composition):
12933 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12934 (glyph_to_pixel_coords): Remove; unused.
12936 * dired.c (file_name_completion): Now static.
12938 * dbusbind.c (xd_in_read_queued_messages): Now static.
12940 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12941 * data.c (circular_list_error): Remove.
12943 * commands.h (last_point_position, last_point_position_buffer):
12944 (last_point_position_window): Remove decls.
12945 * keyboard.c: Make these variables static.
12947 * coding.h (coding, code_convert_region, encode_coding_gap):
12949 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12950 (iso_code_class, detect_coding, code_convert_region): Now static.
12951 (encode_coding_gap): Remove; unused.
12953 * chartab.c (chartab_chars, chartab_bits): Now static.
12955 * charset.h (charset_iso_8859_1): Remove decl.
12956 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12959 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12960 * ccl.c (Vccl_program_table): Now static.
12961 (check_ccl_update): Remove; unused.
12963 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12964 * category.h: ... from here.
12965 * category.c (check_category_table, set_category_set): Now static.
12967 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12968 * lisp.h: Remove these decls.
12970 * buffer.c (buffer_count): Remove unused var.
12972 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12973 so that it's not optimized away.
12974 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12975 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12976 exported only to the debugger.
12978 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
12979 * atimer.h (run_all_atimers): Remove; not exported.
12981 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12982 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12983 was inaccessible from Lisp.
12984 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12985 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12987 alloc.c: Import and export fewer symbols, and remove unused items.
12988 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12990 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12991 it's not optimized away by whole-program optimization.
12992 (message_enable_multibyte, free_misc): Remove.
12993 (catchlist, handlerlist, mark_backtrace):
12994 Declare only if BYTE_MARK_STACK.
12995 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12996 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12997 (message_enable_multibyte): Remove decl.
12998 (free_misc, interval_free_list, float_block, float_block_index):
12999 (n_float_blocks, float_free_list, cons_block, cons_block_index):
13000 (cons_free_list, last_marked_index):
13002 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
13003 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
13004 (mark_backtrace): Define only if BYTE_MARK_STACK.
13005 * xdisp.c (message_enable_multibyte): Now static.
13007 Declare Lisp_Object Q* variables to be 'static' if not exported.
13008 This makes it easier for human readers (and static analyzers)
13009 to see whether these variables are used from other modules.
13010 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
13011 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
13012 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
13013 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
13014 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
13015 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
13016 * xmenu.c, xselect.c:
13017 Declare Q* vars static if they are not used in other modules.
13018 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
13019 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
13020 Remove decls of unexported vars.
13021 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
13023 * lisp.h (DEFINE_FUNC): Make sname 'static'.
13025 Make Emacs functions such as Fatom 'static' by default.
13026 This makes it easier for human readers (and static analyzers)
13027 to see whether these functions can be called from other modules.
13028 DEFUN now defines a static function. To make the function external
13029 so that it can be used in other C modules, use the new macro DEFUE.
13030 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
13031 (Finit_image_library):
13032 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
13033 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
13034 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
13035 Remove decls, since these functions are now static.
13036 (Funintern, Fget_internal_run_time): New decls, since these functions
13037 were already external.
13039 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
13040 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
13041 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
13042 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
13043 * keyboard.c, keymap.c, lread.c:
13044 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
13045 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
13046 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
13047 Mark functions with DEFUE instead of DEFUN,
13048 if they are used in other modules.
13049 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
13050 decls for now-static functions.
13051 * buffer.h (Fdelete_overlay): Remove decl.
13052 * callproc.c (Fgetenv_internal): Mark as internal.
13053 * composite.c (Fremove_list_of_text_properties): Remove decl.
13054 (Fcomposition_get_gstring): New forward static decl.
13055 * composite.h (Fcomposite_get_gstring): Remove decl.
13056 * dired.c (Ffile_attributes): New forward static decl.
13057 * doc.c (Fdocumntation_property): New forward static decl.
13058 * eval.c (Ffetch_bytecode): New forward static decl.
13059 (Funintern): Remove extern decl; now in .h file where it belongs.
13060 * fileio.c (Fmake_symbolic_link): New forward static decl.
13061 * image.c (Finit_image_library): New forward static decl.
13062 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
13063 * intervals.h (Fprevious_property_change):
13064 (Fremove_list_of_text_properties): Remove decls.
13065 * keyboard.c (Fthis_command_keys): Remove decl.
13066 (Fcommand_execute): New forward static decl.
13067 * keymap.c (Flookup_key): New forward static decl.
13068 (Fcopy_keymap): Now static.
13069 * keymap.h (Flookup_key): Remove decl.
13070 * process.c (Fget_process): New forward static decl.
13071 (Fprocess_datagram_address): Mark as internal.
13072 * syntax.c (Fsyntax_table_p): New forward static decl.
13073 (skip_chars): Remove duplicate decl.
13074 * textprop.c (Fprevious_property_change): New forward static decl.
13075 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
13077 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
13078 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
13080 * editfns.c (Fformat): Remove unreachable code.
13082 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
13084 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
13087 2011-04-13 Eli Zaretskii <eliz@gnu.org>
13089 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
13090 when at ZV. (Bug#8487)
13092 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
13094 * charset.c (Fclear_charset_maps): Use xfree instead of free.
13096 * keyboard.c (parse_tool_bar_item): Likewise.
13097 * sound.c (sound_cleanup, alsa_close): Likewise.
13098 * termcap.c (tgetent): Likewise.
13099 * xfns.c (x_default_font_parameter): Likewise.
13100 * xsettings.c (read_and_apply_settings): Likewise.
13102 * alloc.c (overrun_check_malloc, overrun_check_realloc)
13103 (overrun_check_free): Protoize.
13105 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
13107 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
13108 since callers should never pass a negative size.
13109 Change the signature to match that of plain 'read' and 'write'; see
13110 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
13111 * lisp.h: Update prototypes of emacs_write and emacs_read.
13113 2011-04-11 Eli Zaretskii <eliz@gnu.org>
13115 * xdisp.c (redisplay_window): Don't try to determine the character
13116 position of the scroll margin if the window start point w->startp
13117 is outside the buffer's accessible region. (Bug#8468)
13119 2011-04-10 Eli Zaretskii <eliz@gnu.org>
13121 Fix write-region and its subroutines for buffers > 2GB.
13122 * fileio.c (a_write, e_write): Modify declaration of arguments and
13123 local variables to support buffers larger than 2GB.
13124 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
13126 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
13127 argument, local variables, and return value.
13129 * lisp.h: Update prototypes of emacs_write and emacs_read.
13131 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
13133 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
13135 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
13137 Fix more problems found by GCC 4.6.0's static checks.
13139 * xdisp.c (vmessage): Use a better test for character truncation.
13141 * charset.c (load_charset_map): <, not <=, for optimization,
13142 and to avoid potential problems with integer overflow.
13143 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
13144 * casetab.c (set_identity, shuffle): Likewise.
13145 * editfns.c (Fformat): Likewise.
13146 * syntax.c (skip_chars): Likewise.
13148 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13149 This also lets GCC 4.6.0 generate slightly better loop code.
13151 * callint.c (Fcall_interactively): <, not <=, for optimization.
13152 (Fcall_interactively): Count the number of arguments produced,
13153 not the number of arguments given. This is simpler and lets GCC
13154 4.6.0 generate slightly better code.
13156 * ftfont.c: Distingish more carefully between FcChar8 and char.
13157 The previous code passed unsigned char * to a functions like
13158 strlen and xstrcasecmp that expect char *, which does not
13159 conform to the C standard.
13160 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13161 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13162 char * when the C standard requires it.
13164 * keyboard.c (read_char): Remove unused var.
13166 * eval.c: Port to Windows vsnprintf (Bug#8435).
13167 Include <limits.h>.
13168 (SIZE_MAX): Define if the headers do not.
13169 (verror): Do not give up if vsnprintf returns a negative count.
13170 Instead, grow the buffer. This ports to Windows vsnprintf, which
13171 does not conform to C99. Problem reported by Eli Zaretskii.
13172 Also, simplify the allocation scheme, by avoiding the need for
13173 calling realloc, and removing the ALLOCATED variable.
13175 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13177 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13178 But keep the doprint source code for now, as we might revamp it
13179 and use it again (Bug#8435).
13180 * lisp.h (doprnt): Remove.
13181 * Makefile.in (base_obj): Remove doprnt.o.
13182 * deps.mk (doprnt.o): Remove.
13184 error: Print 32- and 64-bit integers portably (Bug#8435).
13185 Without this change, on typical 64-bit hosts error ("...%d...", N)
13186 was used to print both 32- and 64-bit integers N, which relied on
13187 undefined behavior.
13188 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
13189 * lisp.h (error, verror): Mark as printf-like functions.
13190 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13191 Report overflow in size calculations when allocating printf buffer.
13192 Do not truncate output string at its first null byte.
13193 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13194 Truncate the output at a character boundary, since vsnprintf does not
13196 * charset.c (check_iso_charset_parameter): Convert internal
13197 character to string before calling 'error', since %c now has the
13199 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13200 overflow when computing char to be passed to 'error'. Do not
13201 pass Lisp_Object to 'error'; pass the integer instead.
13202 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13203 formatted with plain %d.
13205 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13207 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13209 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13211 * xterm.c (x_catch_errors): Remove duplicate declaration.
13213 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13215 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13217 2011-04-10 Jim Meyering <meyering@redhat.com>
13219 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13220 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13221 return ssize_t not "int", and use size_t as the buffer length.
13222 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13223 * gnutls.h: Update declarations.
13224 * process.c (read_process_output): Use ssize_t, to match.
13225 (send_process): Likewise.
13227 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
13229 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13231 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
13233 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13234 Use unsigned char, to match FcChar8 type definition.
13236 * xterm.c (handle_one_xevent):
13237 * xmenu.c (create_and_show_popup_menu):
13238 * xselect.c (x_decline_selection_request)
13239 (x_reply_selection_request): Avoid type-punned deref of X events.
13241 2011-04-09 Eli Zaretskii <eliz@gnu.org>
13243 Fix some uses of `int' instead of EMACS_INT.
13244 * search.c (string_match_1, fast_string_match)
13245 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13246 (scan_buffer, find_next_newline_no_quit)
13247 (find_before_next_newline, search_command, Freplace_match)
13248 (Fmatch_data): Make some `int' variables be EMACS_INT.
13250 * xdisp.c (display_count_lines): 3rd argument and return value now
13251 EMACS_INT. All callers changed.
13252 (pint2hrstr): Last argument is now EMACS_INT.
13254 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13255 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13256 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13257 (decode_coding_utf_16, decode_coding_emacs_mule)
13258 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13259 (decode_coding_ccl, decode_coding_charset)
13260 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13261 (decode_coding_iso_2022, decode_coding_emacs_mule)
13262 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13263 <char_offset, last_offset>: Declare EMACS_INT.
13264 (encode_coding_utf_8, encode_coding_utf_16)
13265 (encode_coding_emacs_mule, encode_invocation_designation)
13266 (encode_designation_at_bol, encode_coding_iso_2022)
13267 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13268 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13270 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13271 (encode_invocation_designation): Last argument P_NCHARS is now
13273 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13274 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13276 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13279 * ccl.c (Fccl_execute_on_string): Declare some variables
13282 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
13284 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13286 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13288 * process.c (Fformat_network_address): Doc fix.
13290 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13292 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
13294 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
13296 * keyboard.c (read_char): Call Lisp function help-form-show,
13297 instead of using internal_with_output_to_temp_buffer.
13298 (Qhelp_form_show): New var.
13299 (syms_of_keyboard): Use DEFSYM macro.
13301 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13303 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13305 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
13307 * process.c (Flist_processes): Remove to Lisp.
13308 (list_processes_1): Delete.
13310 2011-04-06 Eli Zaretskii <eliz@gnu.org>
13312 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13314 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13316 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
13318 Fix more problems found by GCC 4.6.0's static checks.
13320 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13322 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13324 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
13326 * xdisp.c (vmessage): Mark as a printf-like function.
13328 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13330 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13332 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13333 printf-like functions.
13334 (tiff_load): Add casts to remove these marks before passing them
13335 to system-supplied API.
13337 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13339 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13340 This avoids several warnings with gcc -Wstrict-overflow.
13341 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13342 directly, rather than having caller test rule sign. This avoids
13343 some unnecessary tests.
13344 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13345 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13346 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
13348 * xfont.c (xfont_text_extents): Remove var that was set but not used.
13349 (xfont_open): Avoid unnecessary tests.
13351 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13353 * composite.h, composite.c (composition_gstring_put_cache):
13354 Use EMACS_INT, not int, for length.
13356 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13357 breaking out part of COMPOSITION_DECODE_RULE.
13358 (COMPOSITION_DECODE_RULE): Use it.
13359 * composite.c (get_composition_id): Remove unused local vars,
13360 by using the new macro.
13362 * textprop.c (set_text_properties_1): Change while to do-while,
13363 since the condition is always true at first.
13365 * intervals.c (graft_intervals_into_buffer): Mark var as used.
13366 (interval_deletion_adjustment): Return unsigned value.
13369 * process.c (list_processes_1, create_pty, read_process_output):
13370 (exec_sentinel): Remove vars that were set but not used.
13371 (create_pty): Remove unnecessary "volatile"s.
13372 (Fnetwork_interface_info): Avoid possibility of int overflow.
13373 (read_process_output): Do adaptive read buffering even if carryover.
13374 (read_process_output): Simplify nbytes computation if buffered.
13376 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13378 * syntax.c (scan_words): Remove var that was set but not used.
13379 (update_syntax_table): Use unsigned instead of int.
13381 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
13382 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
13383 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
13385 * print.c (print_error_message): Avoid int overflow.
13387 * font.c (font_list_entities): Redo for clarity,
13388 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13390 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
13391 (font_score): Avoid potential overflow in diff calculation.
13393 * fns.c (substring_both): Remove var that is set but not used.
13394 (sxhash): Redo loop for clarity and to avoid wraparound warning.
13396 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13398 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13399 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13400 can always succeed if overflow has undefined behavior.
13402 * search.c (boyer_moore, wordify): Remove vars set but not used.
13403 (wordify): Omit three unnecessary tests.
13405 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13406 All callers changed. This avoids the need for an unused var.
13408 * casefiddle.c (casify_region): Remove var that is set but not used.
13410 * dired.c (file_name_completion): Remove var that is set but not used.
13412 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13414 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
13415 (Finsert_file_contents): Remove unnecessary code checking fd.
13417 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13418 Check for integer overflow on size calculations.
13420 * buffer.c (Fprevious_overlay_change): Remove var that is set
13423 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13424 Remove vars that are set but not used.
13425 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
13426 (timer_check_2): Mark vars as initialized.
13428 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13430 * image.c (lookup_image): Remove var that is set but not used.
13431 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
13433 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13434 that are set but not used.
13436 * xfns.c (make_invisible_cursor): Don't return garbage
13437 if XCreateBitmapFromData fails (Bug#8410).
13439 * xselect.c (x_get_local_selection, x_handle_property_notify):
13440 Remove vars that are set but not used.
13442 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
13443 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
13445 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13446 Remove var that is set but not used.
13447 (scroll_bar_windows_size): Now size_t, not int.
13448 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13449 Check for overflow.
13451 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13452 (map_tty_color) [!defined MSDOS]: Likewise.
13454 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13456 * coding.c: Remove vars that are set but not used.
13457 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13458 All callers changed.
13459 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13460 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13461 (decode_coding_charset): Remove vars that are set but not used.
13463 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13464 that is set but not used.
13466 * print.c (print_object): Remove var that is set but not used.
13468 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
13469 The gnulib version avoids calling malloc in the usual case,
13470 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13471 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13472 * filelock.c (current_lock_owner): Likewise.
13473 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13474 * sysdep.c: Include allocator.h, careadlinkat.h.
13475 (emacs_no_realloc_allocator): New static constant.
13476 (emacs_readlink): New function.
13477 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13478 ../lib/careadlinkat.h.
13480 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13482 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13483 first non-nil return value).
13485 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13487 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13488 if not defined (Bug#8403).
13490 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
13492 * xdisp.c (display_count_lines): Remove parameter `start',
13493 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13494 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13495 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13496 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13497 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13498 and thereabouts. All callers changed.
13499 (get_per_char_metric): Remove parameter `f', unused since
13500 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13502 2011-04-02 Jim Meyering <meyering@redhat.com>
13504 do not dereference NULL upon failed strdup
13505 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13506 (ns_get_family): Likewise.
13508 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
13510 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13512 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13514 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13517 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13519 Add lexical binding.
13521 * window.c (Ftemp_output_buffer_show): New fun.
13522 (Fsave_window_excursion):
13523 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13525 * lread.c (lisp_file_lexically_bound_p): New function.
13526 (Fload): Bind Qlexical_binding.
13527 (readevalloop): Remove `evalfun' arg.
13528 Bind Qinternal_interpreter_environment.
13529 (Feval_buffer): Bind Qlexical_binding.
13530 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13532 (syms_of_lread): Declare `lexical-binding'.
13534 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13536 * keyboard.c (eval_dyn): New fun.
13537 (menu_item_eval_property): Use it.
13539 * image.c (parse_image_spec): Use Ffunctionp.
13541 * fns.c (concat, mapcar1): Accept byte-code-functions.
13543 * eval.c (Fsetq): Handle lexical vars.
13544 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13545 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13546 (FletX, Flet): Obey lexical binding.
13547 (Fcommandp): Handle closures.
13548 (Feval): New `lexical' arg.
13549 (eval_sub): New function extracted from Feval. Use it almost
13550 everywhere where Feval was used. Look up vars in lexical env.
13552 (Ffunctionp): Move from subr.el.
13553 (Ffuncall): Handle closures.
13554 (apply_lambda): Remove `eval_flags'.
13555 (funcall_lambda): Handle closures and new byte-code-functions.
13556 (Fspecial_variable_p): New function.
13557 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13558 but without exporting it to Lisp.
13560 * doc.c (Fdocumentation, store_function_docstring):
13561 * data.c (Finteractive_form): Handle closures.
13563 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13566 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13568 (exec_byte_code): New function extracted from Fbyte_code to handle new
13569 calling convention for byte-code-functions. Add new byte-codes.
13571 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
13573 * alloc.c (Fmake_symbol): Init new `declared_special' field.
13575 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
13577 * xdisp.c (redisplay_internal): Fix prototype.
13579 2011-03-31 Eli Zaretskii <eliz@gnu.org>
13581 * xdisp.c (SCROLL_LIMIT): New macro.
13582 (try_scrolling): Use it when setting scroll_limit.
13583 Limit scrolling to 100 screen lines.
13584 (redisplay_window): Even when falling back on "recentering",
13585 position point in the window according to scroll-conservatively,
13586 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13588 (try_scrolling): When point is above the window, allow searching
13589 as far as scroll_max, or one screenful, to compute vertical
13590 distance from PT to the scroll margin position. This prevents
13591 try_scrolling from unnecessarily failing when
13592 scroll-conservatively is set to a value slightly larger than the
13593 window height. Clean up the case of PT below the margin at bottom
13594 of window: scroll_max can no longer be INT_MAX. When aggressive
13595 scrolling is in use, don't let point enter the opposite scroll
13596 margin as result of the scroll.
13597 (syms_of_xdisp) <scroll-conservatively>: Document the
13598 threshold of 100 lines for never-recentering scrolling.
13600 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
13602 * dispextern.h (move_it_by_lines):
13603 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13604 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13605 (message_log_check_duplicate): Remove parameters `prev_bol' and
13606 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13607 (redisplay_internal): Remove parameter `preserve_echo_area',
13608 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13610 * indent.c (Fvertical_motion):
13611 * window.c (window_scroll_pixel_based, Frecenter):
13612 Don't pass `need_y_p' to `move_it_by_lines'.
13614 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13616 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13617 steal a few bits to be more compact.
13618 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13619 Remove unneeded casts.
13621 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13623 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13625 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13626 binding" message (bug#7967).
13628 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13630 Fix more problems found by GCC 4.6.0's static checks.
13632 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13633 Remove unused local var.
13635 * editfns.c (Fmessage_box): Remove unused local var.
13637 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13638 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13639 Omit unused local vars.
13640 * window.c (shrink_windows): Omit unused local var.
13641 * menu.c (digest_single_submenu): Omit unused local var.
13642 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13643 Omit unused local var.
13645 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13646 Don't assume string length fits in int.
13647 (keyremap_step, read_key_sequence): Use size_t for sizes.
13648 (read_key_sequence): Don't check last_real_key_start redundantly.
13650 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13651 instead of alloca (Bug#8344).
13653 * eval.c (Fbacktrace): Don't assume nargs fits in int.
13654 (Fbacktrace_frame): Don't assume nframes fits in int.
13656 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13658 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13661 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13663 * cm.c (calccost): Turn while-do into do-while, for clarity.
13665 * keyboard.c (syms_of_keyboard): Use the same style as later
13666 in this function when indexing through an array. This also
13667 works around GCC bug 48267.
13669 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13671 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13673 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13674 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13676 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13677 This avoids undefined behavior on integer overflow, and is a bit
13678 more convenient anyway since it is compared to a size_t variable.
13680 Variadic C functions now count arguments with size_t, not int.
13681 This avoids an unnecessary limitation on 64-bit machines, which
13682 caused (substring ...) to crash on large vectors (Bug#8344).
13683 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13684 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
13685 All variadic functions and their callers changed accordingly.
13686 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13687 * data.c (arith_driver, float_arith_driver): Likewise.
13688 * editfns.c (general_insert_function): Likewise.
13689 * eval.c (struct backtrace.nargs, interactive_p)
13690 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13691 (funcall_lambda, mark_backtrace): Likewise.
13692 * fns.c (concat): Likewise.
13693 * frame.c (x_set_frame_parameters): Likewise.
13694 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13695 0 if not found, not -1. All callers changed.
13697 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13698 (stack_copy_size): Now size_t, not int.
13699 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13701 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
13703 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13704 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13705 All callers changed.
13707 * lisp.h (multibyte_char_to_unibyte):
13708 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13709 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13710 * character.h (CHAR_TO_BYTE8):
13711 * cmds.c (internal_self_insert):
13712 * editfns.c (general_insert_function):
13713 * keymap.c (push_key_description):
13714 * search.c (Freplace_match):
13715 * xdisp.c (message_dolog, set_message_1): All callers changed.
13717 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13719 * keyboard.c (safe_run_hook_funcall): New function.
13720 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13721 don't set the hook to nil, but remove the offending function instead.
13722 (Qcommand_hook_internal): Remove, unused.
13723 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13724 Vcommand_hook_internal.
13726 * eval.c (enum run_hooks_condition): Remove.
13727 (funcall_nil, funcall_not): New functions.
13728 (run_hook_with_args): Call each function through a `funcall' argument.
13729 Remove `cond' argument, now redundant.
13730 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13731 (Frun_hook_with_args_until_failure): Adjust accordingly.
13732 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13734 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
13736 * dispextern.h (string_buffer_position): Remove declaration.
13738 * print.c (strout): Remove parameter `multibyte', unused since
13739 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13741 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13742 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13743 All callers changed.
13745 * w32.c (_wsa_errlist): Use braces for struct initializers.
13747 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13748 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13749 All callers changed.
13750 (string_buffer_position): Likewise. Also, make static (it's never
13751 used outside xdisp.c).
13752 (cursor_row_p): Remove parameter `w', unused since
13753 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13754 (decode_mode_spec): Remove parameter `precision', introduced during
13755 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13756 All callers changed.
13758 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13760 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13762 2011-03-27 Anders Lindgren <andlind@gmail.com>
13764 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13765 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13766 (ns_update_auto_hide_menu_bar): New functions.
13767 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13768 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13769 ns_constrain_all_frames.
13770 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13771 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13773 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13775 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13777 2011-03-27 Glenn Morris <rgm@gnu.org>
13779 * syssignal.h: Replace RETSIGTYPE with void.
13780 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13781 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13782 Replace SIGTYPE with void everywhere.
13783 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13784 * s/template.h (SIGTYPE): Remove commented out definition.
13786 2011-03-26 Eli Zaretskii <eliz@gnu.org>
13788 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13789 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13791 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
13793 * w32.c (read_unc_volume): Use parameter `henum', instead of
13794 global variable `wget_enum_handle'.
13796 * keymap.c (describe_vector): Remove parameters `indices' and
13797 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13798 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13800 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13802 * keyboard.c (timer_check): Remove parameter `do_it_now',
13803 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13804 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13805 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13807 * keyboard.c (read_char):
13808 * w32menu.c (w32_menu_display_help):
13809 * xmenu.c (show_help_event, menu_help_callback):
13810 Adjust calls to `show_help_echo'.
13812 * gtkutil.c (xg_maybe_add_timer):
13813 * keyboard.c (readable_events):
13814 * process.c (wait_reading_process_output):
13815 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13817 * insdel.c (adjust_markers_gap_motion):
13818 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13819 (gap_left, gap_right): Don't call it.
13821 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
13823 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13824 incurred during fontification.
13826 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
13828 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13829 (DEFVAR_PER_BUFFER): Don't pass it.
13831 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13832 (scrolling_window): Don't pass it.
13834 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
13836 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13838 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13840 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13841 of variables specific to SELinux and computation of `encoded_absname'.
13843 * image.c (XPutPixel): Remove unused variable `height'.
13845 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13847 * unexw32.c (get_section_info): Remove unused variable `section'.
13849 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13850 (system_process_attributes): Remove unused variable `sess'.
13851 (sys_read): Remove unused variable `err'.
13853 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13854 (w32_wnd_proc): Remove unused variable `isdead'.
13855 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13856 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13857 (x_create_tip_frame): Remove unused variable `tem'.
13859 * w32inevt.c (w32_console_read_socket):
13860 Remove unused variable `no_events'.
13862 * w32term.c (x_draw_composite_glyph_string_foreground):
13863 Remove unused variable `width'.
13865 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
13867 * w32term.c (x_set_glyph_string_clipping):
13868 Don't pass uninitialized region to CombineRgn.
13870 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
13872 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13873 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13874 (Fx_close_connection): Remove unused variable `i'.
13876 * w32font.c (w32font_draw): Return number of glyphs.
13877 (w32font_open_internal): Remove unused variable `i'.
13878 (w32font_driver): Add missing initializer.
13880 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13881 (fill_in_menu): Remove unused variable `items_added'.
13883 * w32term.c (last_mouse_press_frame): Remove static global variable.
13884 (w32_clip_to_row): Remove unused variable `f'.
13885 (x_delete_terminal): Remove unused variable `i'.
13887 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13888 (NOTHING): Remove unused static global variable.
13889 (uniscribe_check_otf): Remove unused variable `table'.
13890 (uniscribe_font_driver): Add missing initializers.
13892 2011-03-23 Julien Danjou <julien@danjou.info>
13894 * term.c (Fsuspend_tty, Fresume_tty):
13895 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13896 * window.c (temp_output_buffer_show):
13897 * insdel.c (signal_before_change):
13898 * frame.c (Fhandle_switch_frame):
13899 * fileio.c (Fdo_auto_save):
13900 * emacs.c (Fkill_emacs):
13901 * editfns.c (save_excursion_restore):
13902 * cmds.c (internal_self_insert):
13903 * callint.c (Fcall_interactively):
13904 * buffer.c (Fkill_all_local_variables):
13905 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13907 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
13908 unconditionally since it does the check itself.
13910 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
13912 Fix more problems found by GCC 4.5.2's static checks.
13914 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13915 the first time through the loop, since we know p0 < p1 then.
13916 This also avoids a gcc -Wstrict-overflow warning.
13918 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13919 leading to a memory leak, possible in functions like
13920 load_charset_map_from_file that can allocate an unbounded number
13921 of objects (Bug#8318).
13923 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13924 that could (at least in theory) be that large.
13926 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13927 This is less likely to overflow, and avoids undefined behavior if
13928 overflow does occur. All callers changed. Use strtoul to scan
13929 for the unsigned long integer.
13930 (pint2hrstr): Simplify and tune code slightly.
13931 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
13933 * scroll.c (do_scrolling): Work around GCC bug 48228.
13934 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13936 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13937 This also avoids a warning with gcc -Wstrict-overflow.
13938 (validate_x_resource_name): Simplify count usage.
13939 This also avoids a warning with gcc -Wstrict-overflow.
13941 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13944 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
13946 * process.c (Fmake_network_process): Use socklen_t, not int,
13947 where POSIX says socklen_t is required in portable programs.
13948 This fixes a porting bug on hosts like 64-bit HP-UX, where
13949 socklen_t is wider than int (Bug#8277).
13950 (Fmake_network_process, server_accept_connection):
13951 (wait_reading_process_output, read_process_output):
13954 * process.c: Rename or move locals to avoid shadowing.
13955 (list_processes_1, Fmake_network_process):
13956 (read_process_output_error_handler, exec_sentinel_error_handler):
13957 Rename or move locals.
13958 (Fmake_network_process): Define label "retry_connect" only if needed.
13959 (Fnetwork_interface_info): Fix pointer signedness.
13960 (process_send_signal): Add cast to avoid pointer signedness problem.
13961 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
13962 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
13964 Make tparam.h and terminfo.c consistent.
13965 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13966 Include tparam.h instead, since it declares them.
13967 * cm.h (PC): Remove extern decl; tparam.h now does this.
13968 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13969 * terminfo.c: Include tparam.h, to check interfaces.
13970 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13971 (tparam): Adjust signature to match interface in tparam.h;
13972 this removes some undefined behavior. Check that outstring and len
13973 are zero, which they always are with Emacs.
13974 * tparam.h (PC, BC, UP): New extern decls.
13976 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
13977 (xftfont_open): Rename locals to avoid shadowing.
13979 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
13980 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13981 (OTF_TAG_SYM): Omit macro if not needed.
13982 (ftfont_list): Remove unused local.
13983 (get_adstyle_property, ftfont_pattern_entity):
13984 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13985 Rename locals to avoid shadowing.
13987 * xfont.c (xfont_list_family): Mark var as initialized.
13989 * xml.c (make_dom): Now static.
13991 * composite.c (composition_compute_stop_pos): Rename local to
13993 (composition_reseat_it): Remove unused locals.
13994 (find_automatic_composition, composition_adjust_point): Likewise.
13995 (composition_update_it): Mark var as initialized.
13996 (find_automatic_composition): Mark vars as initialized,
13997 with a FIXME (Bug#8290).
13999 character.h: Rename locals to avoid shadowing.
14000 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
14001 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
14002 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
14003 (BUF_DEC_POS): Be more systematic about renaming local temporaries
14004 to avoid shadowing.
14006 * textprop.c (property_change_between_p): Remove; unused.
14008 * intervals.c (interval_start_pos): Now static.
14010 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
14012 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
14013 Rename locals to avoid shadowing.
14015 * sound.c (wav_play, au_play, Fplay_sound_internal):
14016 Fix pointer signedness.
14017 (alsa_choose_format): Remove unused local var.
14018 (wav_play): Initialize a variable to 0, to prevent undefined
14019 behavior (Bug#8278).
14021 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
14023 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
14025 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
14026 clobbering (Bug#8298).
14027 * sysdep.c (sys_subshell): Likewise.
14028 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
14030 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
14031 This should get cleaned up, so that child_setup has the
14032 same signature on all platforms.
14034 * callproc.c (call_process_cleanup): Now static.
14035 (relocate_fd): Rename locals to avoid shadowing.
14037 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
14039 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
14040 not to be necessary, and produces flickering.
14042 2011-03-20 Glenn Morris <rgm@gnu.org>
14044 * config.in: Remove file.
14046 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
14048 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
14049 are now in src/globals.h.
14050 (syms_of_minibuf): Remove spurious & from previous change.
14052 2011-03-20 Leo Liu <sdl.web@gmail.com>
14054 * minibuf.c (completing-read-function): New variable.
14055 (completing-read-default): Rename from completing-read.
14056 (completing-read): Call completing-read-function.
14058 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
14060 * xfaces.c (Fx_load_color_file):
14061 Read color file from absolute filename (bug#8250).
14063 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
14065 * makefile.w32-in: Update dependencies.
14067 2011-03-17 Eli Zaretskii <eliz@gnu.org>
14069 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
14071 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
14073 Fix more problems found by GCC 4.5.2's static checks.
14075 * process.c (make_serial_process_unwind, send_process_trap):
14076 (sigchld_handler): Now static.
14078 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
14079 That way, the code declares only the vars that it needs.
14080 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
14081 * s/cygwin.h (PTY_ITERATION): Likewise.
14082 * s/darwin.h (PTY_ITERATION): Likewise.
14083 * s/gnu-linux.h (PTY_ITERATION): Likewise.
14085 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
14086 * process.c (allocate_pty): Don't declare stb unless it's needed.
14088 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
14089 (CONSTANTLIM): Remove; unused.
14090 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
14091 Define only if needed.
14093 * unexelf.c (unexec): Name an expression,
14094 to avoid gcc -Wbad-function-cast warning.
14095 Use a different way to cause a compilation error if anyone uses
14096 n rather than nn, a way that does not involve shadowing.
14097 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
14099 * deps.mk (unexalpha.o): Remove; unused.
14101 New file unexec.h, the (simple) interface for unexec (Bug#8267).
14102 * unexec.h: New file.
14103 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
14104 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
14105 Depend on unexec.h.
14106 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
14107 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
14108 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
14109 Change as necessary to match prototype in unexec.h.
14111 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
14113 (back_comment, skip_chars): Mark vars as initialized.
14115 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
14116 Rename locals to avoid shadowing.
14118 * lread.c (read1): Rewrite so as not to use empty "else".
14119 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
14121 * print.c (Fredirect_debugging_output): Fix pointer signedess.
14123 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
14124 warning when compiling print.c.
14126 * font.c (font_unparse_fcname): Abort in an "impossible" situation
14127 instead of using an uninitialized var.
14128 (font_sort_entities): Mark var as initialized.
14130 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
14132 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
14133 pointers to constants.
14134 (font_parse_fcname): Remove unused vars.
14135 (font_delete_unmatched): Now static.
14136 (font_get_spec): Remove; unused.
14137 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
14138 (font_update_drivers, Ffont_get_glyphs, font_add_log):
14139 Rename or move locals to avoid shadowing.
14141 * fns.c (require_nesting_list, require_unwind): Now static.
14142 (Ffillarray): Rename locals to avoid shadowing.
14144 * floatfns.c (domain_error2): Define only if needed.
14145 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
14147 * alloc.c (mark_backtrace): Move decl from here ...
14148 * lisp.h: ... to here, so that it can be checked.
14150 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
14151 (Fdefvar): Rewrite so as not to use empty "else".
14152 (lisp_indirect_variable): Name an expression,
14153 to avoid gcc -Wbad-function-cast warning.
14154 (Fdefvar): Rename locals to avoid shadowing.
14156 * callint.c (quotify_arg, quotify_args): Now static.
14157 (Fcall_interactively): Rename locals to avoid shadowing.
14158 Use const pointer when appropriate.
14160 * lisp.h (get_system_name, get_operating_system_release):
14161 Move decls here, to check interfaces.
14162 * process.c (get_operating_system_release): Move decl to lisp.h.
14163 * xrdb.c (get_system_name): Likewise.
14164 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14165 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14166 some of which prompt warnings from gcc -Wbad-function-cast.
14167 (Fformat_time_string, Fencode_time, Finsert_char):
14168 (Ftranslate_region_internal, Fformat):
14169 Rename or remove local vars to avoid shadowing.
14170 (Ftranslate_region_internal): Mark var as initialized.
14172 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14175 * lisp.h (eassert): Check that the argument compiles, even if
14176 ENABLE_CHECKING is not defined.
14178 * data.c (Findirect_variable): Name an expression, to avoid
14179 gcc -Wbad-function-cast warning.
14180 (default_value, arithcompare, arith_driver, arith_error): Now static.
14181 (store_symval_forwarding): Rename local to avoid shadowing.
14182 (Fmake_variable_buffer_local, Fmake_local_variable):
14183 Mark variables as initialized.
14184 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
14186 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
14187 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14188 Rename locals to avoid shadowing.
14189 (mark_stack): Move local variables into the #ifdef region where
14191 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14192 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14194 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14195 (GC_STRING_CHARS): Remove; not used.
14196 (Fmemory_limit): Cast sbrk's returned value to char *.
14198 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14199 avoids undefined behavior in theory.
14201 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14203 Use functions, not macros, for up- and down-casing (Bug#8254).
14204 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14205 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14206 to use the following functions instead of these macros.
14207 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14208 EMACS_INT, since callers assume the returned value fits in int.
14209 (upcase1): Likewise, for UPCASE_TABLE.
14210 (uppercasep, lowercasep, upcase): New static inline functions.
14211 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
14212 the race-condition problem in the old DOWNCASE.
14214 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14215 Rename locals to avoid shadowing.
14216 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
14217 (regex_compile, re_search_2, re_match_2_internal):
14218 Remove unused local vars.
14219 (FREE_VAR): Rewrite so as not to use empty "else",
14220 which gcc can warn about.
14221 (regex_compile, re_match_2_internal): Mark locals as initialized.
14222 (RETALLOC_IF): Define only if needed.
14223 (WORDCHAR_P): Likewise. This one is never needed, but is used
14224 only in a comment talking about a compiler bug, so put inside
14225 the #if 0 of that comment.
14226 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14227 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14230 * search.c (boyer_moore): Rename locals to avoid shadowing.
14231 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14232 (PREV_CHAR_BOUNDARY): Likewise.
14234 * search.c (simple_search): Remove unused var.
14236 * dired.c (compile_pattern): Move decl from here ...
14237 * lisp.h: ... to here, so that it can be checked.
14238 (struct re_registers): New forward decl.
14240 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14242 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14244 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14245 Rename locals to avoid shadowing.
14246 (Fvertical_motion): Mark locals as initialized.
14248 * casefiddle.c (casify_object, casify_region): Now static.
14249 (casify_region): Mark local as initialized.
14251 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14253 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14254 New macros, so that the caller can use some names other than
14255 gcpro1, gcpro2, etc.
14256 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14258 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14259 argument, for consistency with GCPRO2_VAR, etc: it is now the
14260 prefix of the variable, not the variable itself. All uses
14262 * dired.c (directory_files_internal, file_name_completion):
14263 Rename locals to avoid shadowing.
14265 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14266 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14267 dired.c's scmp function, had undefined behavior.
14268 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14269 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14270 * buffer.h: ... to here, because these macros use current_buffer,
14271 and the new implementation with inline functions needs to have
14272 current_buffer in scope now, rather than later when the macros
14274 (downcase, upcase1): New static inline functions.
14275 (DOWNCASE, UPCASE1): Reimplement using these functions.
14276 This avoids undefined behavior in expressions like
14277 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14278 from race conditions in accessing the global variables
14279 case_temp1 and case_temp2.
14280 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14281 * lisp.h (case_temp1, case_temp2): Remove their decls.
14282 * character.h (ASCII_CHAR_P): Move from here ...
14283 * lisp.h: ... to here, so that the inline functions mentioned
14284 above can use them.
14286 * dired.c (directory_files_internal_unwind): Now static.
14288 * fileio.c (file_name_as_directory, directory_file_name):
14289 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14291 (file_name_as_directory): Use const pointers when appropriate.
14292 (Fexpand_file_name): Likewise. In particular, newdir might
14293 point at constant storage, so make it a const pointer.
14294 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
14295 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14297 (Fset_file_times, Finsert_file_contents, auto_save_error):
14298 Rename locals to avoid shadowing.
14300 * minibuf.c (choose_minibuf_frame_1): Now static.
14301 (Ftry_completion, Fall_completions): Rename or remove locals
14302 to avoid shadowing.
14304 * marker.c (bytepos_to_charpos): Remove; unused.
14306 * lisp.h (verify_bytepos, count_markers): New decls,
14307 so that gcc does not warn that these functions aren't declared.
14309 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14310 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
14311 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
14312 (copy_text): Remove unused local var.
14314 * filelock.c (within_one_second): Now static.
14315 (lock_file_1): Rename local to avoid shadowing.
14317 * buffer.c (fix_overlays_before): Mark locals as initialized.
14318 (fix_start_end_in_overlays): Likewise. This function should be
14319 simplified by using pointers-to-pointers, but that's a different
14321 (switch_to_buffer_1): Now static.
14322 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14323 (report_overlay_modification): Rename locals to avoid shadowing.
14325 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
14326 Fix pointer signedness issue.
14327 (sys_subshell): Mark local as volatile if checking for lint,
14328 to suppress a gcc -Wclobbered warning that does not seem to be right.
14329 (MAXPATHLEN): Define only if needed.
14331 * process.c (serial_open, serial_configure): Move decls from here ...
14332 * systty.h: ... to here, so that they can be checked.
14334 * fns.c (get_random, seed_random): Move extern decls from here ...
14335 * lisp.h: ... to here, so that they can be checked.
14337 * sysdep.c (reset_io): Now static.
14338 (wait_for_termination_signal): Remove; unused.
14340 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14341 (copy_keymap_item, append_key, push_text_char_description):
14343 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
14344 (DENSE_TABLE_SIZE): Remove; unused.
14345 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14346 (describe_map_tree):
14347 Rename locals to avoid shadowing.
14349 * keyboard.c: Declare functions static if they are not used elsewhere.
14350 (echo_char, echo_dash, cmd_error, top_level_2):
14351 (poll_for_input, handle_async_input): Now static.
14352 (read_char, kbd_buffer_get_event, make_lispy_position):
14353 (make_lispy_event, make_lispy_movement, apply_modifiers):
14354 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14355 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14356 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
14357 (read_key_sequence, read_char): Mark locals as initialized.
14358 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
14360 * keyboard.h (make_ctrl_char): New decl.
14361 (mark_kboards): Move decl here ...
14362 * alloc.c (mark_kboards): ... from here.
14364 * lisp.h (force_auto_save_soon): New decl.
14366 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
14367 (DEFINE_DUMMY_FUNCTION): New macro.
14368 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14370 (main): Add casts to avoid warnings
14371 if GCC considers string literals to be constants.
14373 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14375 * dbusbind.c: Pointer signedness fixes.
14376 (xd_signature, xd_append_arg, xd_initialize):
14377 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14378 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14379 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14380 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14382 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14383 if GCC considers string literals to be constants.
14384 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
14386 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14388 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14389 (print_preprocess, print_object): New macro to fix last change.
14391 * print.c (print_preprocess): Don't forget font objects.
14393 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
14395 * emacs.c (USAGE3): Doc fixes.
14397 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14399 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14402 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
14404 * lisp.h (VWindow_system, Qfile_name_history):
14405 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14406 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14407 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14409 * w32select.c: Don't #include "keyboard.h".
14410 (run_protected): Add extern declaration for waiting_for_input.
14412 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14413 * w32console.c (detect_input_pending, read_input_pending)
14414 (encode_terminal_code):
14415 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14416 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14417 (w32_system_caret_y, Qfile_name_history):
14418 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14419 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14420 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14421 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14422 * w32proc.c (Qlocal, report_file_error):
14423 * w32term.c (Vwindow_system, updating_frame):
14424 * w32uniscribe.c (initialized, uniscribe_font_driver):
14425 Remove unneeded extern declarations.
14427 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
14429 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
14431 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
14433 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14434 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14435 These macros can no longer be used for assignment.
14437 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14438 Assign struct members directly, instead of using BUF_BEGV etc.
14439 (record_buffer_markers, fetch_buffer_markers): New functions for
14440 recording and fetching special buffer markers.
14441 (set_buffer_internal_1, set_buffer_temp): Use them.
14443 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14445 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14447 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14448 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14450 * xdisp.c (hscroll_window_tree):
14451 (reconsider_clip_changes): Use PT instead of BUF_PT.
14453 2011-03-13 Eli Zaretskii <eliz@gnu.org>
14455 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14456 $(EMACS_ROOT)/lib/intprops.h.
14458 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14460 Fix more problems found by GCC 4.5.2's static checks.
14462 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14463 to unsigned char * to avoid compiler diagnostic.
14464 (xg_free_frame_widgets): Make it clear that a local variable is
14465 needed only if USE_GTK_TOOLTIP.
14466 (gdk_window_get_screen): Make it clear that this macro is needed
14467 only if USE_GTK_TOOLTIP.
14468 (int_gtk_range_get_value): New function, which avoids a diagnostic
14469 from gcc -Wbad-function-cast.
14470 (xg_set_toolkit_scroll_bar_thumb): Use it.
14471 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14472 diagnostic from gcc -Wbad-function-cast.
14473 (get_utf8_string, xg_get_file_with_chooser):
14474 Rename locals to avoid shadowing.
14475 (create_dialog): Move locals to avoid shadowing.
14477 * xgselect.c (xg_select): Remove unused var.
14479 * image.c (four_corners_best): Mark locals as initialized.
14480 (gif_load): Initialize transparent_p to zero (Bug#8238).
14481 Mark another local as initialized.
14482 (my_png_error, my_error_exit): Mark with NO_RETURN.
14484 * image.c (clear_image_cache): Now static.
14485 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
14486 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
14487 (x_edge_detection): Remove unnecessary cast that
14488 gcc -Wbad-function-cast diagnoses.
14489 (gif_load): Fix pointer signedness.
14490 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14491 (jpeg_load, gif_load): Rename locals to avoid shadowing.
14493 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
14495 Improve quality of tests for time stamp overflow.
14496 For example, without this patch (encode-time 0 0 0 1 1
14497 1152921504606846976) returns the obviously-bogus value (-948597
14498 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14499 reports time overflow. See
14500 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
14501 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14502 * editfns.c: Include limits.h and intprops.h.
14503 (TIME_T_MIN, TIME_T_MAX): New macros.
14504 (time_overflow): Move earlier, to before first use.
14505 (hi_time, lo_time): New functions, for an accurate test for
14506 out-of-range times.
14507 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14508 (Fget_internal_run_time): Don't assume time_t fits in int.
14509 (make_time): Use list2 instead of Fcons twice.
14510 (Fdecode_time): More accurate test for out-of-range times.
14511 (check_tm_member): New function.
14512 (Fencode_time): Use it, to test for out-of-range times.
14513 (lisp_time_argument): Don't rely on undefined left-shift and
14514 right-shift behavior when checking for time stamp overflow.
14516 * editfns.c (time_overflow): New function, refactoring common code.
14517 (Fformat_time_string, Fdecode_time, Fencode_time):
14518 (Fcurrent_time_string): Use it.
14520 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14521 * dired.c (make_time): Move to ...
14522 * editfns.c (make_time): ... here.
14523 * systime.h: Note the move.
14525 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14527 * fringe.c (update_window_fringes): Remove unused variables.
14529 * unexmacosx.c (copy_data_segment): Also copy __got section.
14532 2011-03-12 Eli Zaretskii <eliz@gnu.org>
14534 * termcap.c [MSDOS]: Include "msdos.h".
14535 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14536 Constify `char *' arguments and their references according to
14537 prototypes in tparam.h.
14539 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
14541 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14542 Adapt all references accordingly.
14544 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14546 2011-03-11 Tom Tromey <tromey@redhat.com>
14548 * buffer.c (syms_of_buffer): Remove obsolete comment.
14550 2011-03-11 Eli Zaretskii <eliz@gnu.org>
14552 * termhooks.h (encode_terminal_code): Declare prototype.
14554 * msdos.c (encode_terminal_code): Don't declare prototype.
14556 * term.c (encode_terminal_code): Now external again, used by
14557 w32console.c and msdos.c.
14559 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14560 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
14562 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
14564 Fix some minor problems found by GCC 4.5.2's static checks.
14566 * fringe.c (update_window_fringes): Mark locals as initialized
14568 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
14570 * alloc.c (mark_fringe_data): Move decl from here ...
14571 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14572 to check its interface.
14573 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14575 * fontset.c (free_realized_fontset): Now static.
14576 (Fset_fontset_font): Rename local to avoid shadowing.
14577 (fontset_font): Mark local as initialized.
14578 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
14580 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14582 * xselect.c (x_disown_buffer_selections): Remove; not used.
14583 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
14584 (x_own_selection, Fx_disown_selection_internal): Rename locals
14585 to avoid shadowing.
14586 (x_handle_dnd_message): Remove local to avoid shadowing.
14588 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14589 so that the caller can use some name other than gcpro1.
14590 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
14591 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14592 (Fx_backspace_delete_keys_p):
14593 Use them to avoid shadowing, and rename vars to avoid shadowing.
14594 (x_decode_color, x_set_name, x_window): Now static.
14595 (Fx_create_frame): Add braces to silence GCC warning.
14596 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
14597 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14598 Remove unused locals.
14599 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14600 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14601 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14604 * xterm.h (x_mouse_leave): New decl.
14606 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14607 Remove unused functions.
14608 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14609 (x_calc_absolute_position): Now static.
14610 (XTread_socket): Don't define label "out" unless it's used.
14611 Don't declare local "event" unless it's used.
14612 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14613 unless they are used.
14614 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14615 (x_fatal_error_signal): Remove; not used.
14616 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14617 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14618 (x_error_catcher, x_connection_closed, x_error_handler):
14619 (x_error_quitter, xembed_send_message, x_iconify_frame):
14620 (my_log_handler): Rename locals to avoid shadowing.
14621 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
14622 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
14624 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14625 Rename or move locals to avoid shadowing.
14626 (tty_defined_color, merge_face_heights): Now static.
14627 (free_realized_faces_for_fontset): Remove; not used.
14628 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14629 does not deduce is never used uninitialized.
14630 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14631 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
14633 * terminal.c (store_terminal_param): Now static.
14635 * xmenu.c (menu_highlight_callback): Now static.
14636 (set_frame_menubar): Remove unused local.
14637 (xmenu_show): Rename parameter to avoid shadowing.
14638 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14639 since they might point to immutable storage.
14640 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14641 since it's unused otherwise.
14643 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
14644 Add a FIXME, since the code still doesn't look right. (Bug#8215)
14645 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14646 avoids a gcc -Wuninitialized diagnostic.
14647 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
14648 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14649 does not deduce are never used uninitialized.
14651 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14653 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
14654 * window.c (window_loop, size_window):
14655 (run_window_configuration_change_hook, enlarge_window): Likewise.
14657 * window.c (display_buffer): Now static.
14658 (size_window): Mark variables that gcc -Wuninitialized
14659 does not deduce are never used uninitialized.
14660 * window.h (check_all_windows): New decl, to forestall
14661 gcc -Wmissing-prototypes diagnostic.
14662 * dispextern.h (bidi_dump_cached_states): Likewise.
14664 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14666 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
14667 Include <limits.h>.
14668 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14669 and to avoid gcc -Wuninitialized warning.
14670 (load_charset_map): Mark variables that gcc -Wuninitialized
14671 does not deduce are never used uninitialized.
14672 (load_charset): Abort instead of using uninitialized var (Bug#8229).
14674 * coding.c (coding_set_source, coding_set_destination):
14675 Use "else { /* comment */ }" rather than "else /* comment */;"
14676 for clarity, and to avoid gcc -Wempty-body warning.
14677 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14678 a block, when the outer 'i' will do.
14679 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14680 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14681 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14682 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14683 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14684 Rename locals to avoid shadowing.
14685 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
14686 * coding.c (emacs_mule_char, encode_invocation_designation):
14687 Now static, since they're not used elsewhere.
14688 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
14689 (decode_coding_object, encode_coding_object, detect_coding_system):
14690 (decode_coding_emacs_mule): Mark variables that gcc
14691 -Wuninitialized does not deduce are never used uninitialized.
14692 (detect_coding_iso_2022): Initialize a local variable that might
14693 be used uninitialized. Leave a FIXME because it's not clear that
14694 this initialization is needed. (Bug#8211)
14695 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14696 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14697 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14698 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14699 Remove unused macros.
14701 * category.c (hash_get_category_set): Remove unused local var.
14702 (copy_category_table): Now static, since it's not used elsewhere.
14703 * character.c (string_count_byte8): Likewise.
14705 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14706 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14708 * chartab.c (copy_sub_char_table): Now static, since it's not used
14710 (sub_char_table_ref_and_range, char_table_ref_and_range):
14711 Rename locals to avoid shadowing.
14712 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
14714 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
14715 (BIDI_BOB): Remove unused macro.
14717 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14718 deduce are never used uninitialized.
14719 * term.c (encode_terminal_code): Likewise.
14721 * term.c (encode_terminal_code): Now static. Remove unused local.
14723 * tparam.h: New file.
14724 * term.c, tparam.h: Include it.
14725 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14726 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14727 Move these decls to tparam.h, and make them agree with what
14728 is actually in tparam.c. The previous trick of using incompatible
14729 decls in different modules does not conform to the C standard.
14730 All callers of tparam changed to use tparam's actual API.
14731 * tparam.c (tparam1, tparam, tgoto):
14732 Use const pointers where appropriate.
14734 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14735 * cm.h (struct cm): Likewise.
14736 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14737 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14738 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14739 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14740 (turn_on_face, init_tty): Likewise.
14741 * termchar.h (struct tty_display_info): Likewise.
14743 * term.c (term_mouse_position): Rename local to avoid shadowing.
14745 * alloc.c (mark_ttys): Move decl from here ...
14746 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14748 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14750 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14752 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
14754 * search.c (compile_pattern_1): Remove argument regp, unused since
14755 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14756 (compile_pattern): Don't pass it.
14758 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14760 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14761 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14763 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14765 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14767 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14768 gdk_window_get_screen, gdk_window_get_geometry,
14769 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14770 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14771 (xg_get_pixbuf_from_pixmap): New function.
14772 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14773 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14774 Call xg_get_pixbuf_from_pixmap instead of
14775 gdk_pixbuf_get_from_drawable.
14776 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14777 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14778 (xg_check_special_colors): Use GtkStyleContext and its functions
14780 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14781 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14782 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
14783 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14784 Call gtk_widget_get_preferred_size.
14785 (xg_frame_resized): gdk_window_get_geometry only takes 5
14787 (xg_win_to_widget, xg_event_is_for_menubar):
14788 Call gdk_x11_window_lookup_for_display.
14789 (xg_set_widget_bg): New function.
14790 (delete_cb): New function.
14791 (xg_create_frame_widgets): Connect delete-event to delete_cb.
14792 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
14793 (xg_set_background_color): Call xg_set_widget_bg.
14794 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14795 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14796 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14797 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14799 (update_frame_tool_bar): Call gtk_widget_hide.
14800 (xg_initialize): Use GDK_KEY_g.
14802 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14804 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14806 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14807 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14808 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14810 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
14812 * w32xfns.c (select_palette): Check success of RealizePalette against
14813 GDI_ERROR, not zero.
14815 See ChangeLog.11 for earlier changes.
14817 ;; Local Variables:
14821 Copyright (C) 2011-2012 Free Software Foundation, Inc.
14823 This file is part of GNU Emacs.
14825 GNU Emacs is free software: you can redistribute it and/or modify
14826 it under the terms of the GNU General Public License as published by
14827 the Free Software Foundation, either version 3 of the License, or
14828 (at your option) any later version.
14830 GNU Emacs is distributed in the hope that it will be useful,
14831 but WITHOUT ANY WARRANTY; without even the implied warranty of
14832 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14833 GNU General Public License for more details.
14835 You should have received a copy of the GNU General Public License
14836 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.