Fix previous change for Bug#6988.
[bpt/emacs.git] / src / ChangeLog
1 2012-02-02 Kenichi Handa <handa@m17n.org>
2
3 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4 0, do not call append_composite_glyph.
5
6 2012-02-02 Kenichi Handa <handa@m17n.org>
7
8 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
9 NULL (Bug#6988).
10 (x_produce_glyphs): If the component of a composition is a null
11 string, set it->pixel_width to 1 to avoid zero-width glyph.
12
13 2012-02-01 Eli Zaretskii <eliz@gnu.org>
14
15 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
16 first 2 arguments are identical. This makes inserting large
17 output from a subprocess an order of magnitude faster on
18 MS-Windows, where all sbrk'ed memory is always contiguous.
19
20 2012-01-31 Glenn Morris <rgm@gnu.org>
21
22 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
23 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
24 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
25
26 2012-01-29 Glenn Morris <rgm@gnu.org>
27
28 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
29
30 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
31
32 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
33
34 2012-01-28 Chong Yidong <cyd@gnu.org>
35
36 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
37
38 2012-01-26 Chong Yidong <cyd@gnu.org>
39
40 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
41
42 * search.c (Fsearch_forward, Fsearch_backward): Document negative
43 repeat counts (Bug#10507).
44
45 2012-01-26 Glenn Morris <rgm@gnu.org>
46
47 * lread.c (syms_of_lread): Doc fix.
48
49 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
50
51 * coding.c (encode_designation_at_bol): Change return value to
52 EMACS_INT.
53
54 2012-01-25 Chong Yidong <cyd@gnu.org>
55
56 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
57
58 2012-01-21 Chong Yidong <cyd@gnu.org>
59
60 * floatfns.c (Fcopysign): Make the second argument non-optional,
61 since nil is not allowed anyway.
62
63 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
64
65 * process.c (read_process_output): Use p instead of XPROCESS (proc).
66 (send_process): Likewise.
67
68 2012-01-19 Martin Rudalics <rudalics@gmx.at>
69
70 * window.c (save_window_save, Fcurrent_window_configuration)
71 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
72 doc-strings.
73
74 2012-01-19 Kenichi Handa <handa@m17n.org>
75
76 * character.c (char_width): New function.
77 (Fchar_width, c_string_width, lisp_string_width):
78 Use char_width (Bug#9496).
79
80 2012-01-16 Martin Rudalics <rudalics@gmx.at>
81
82 * window.c (Vwindow_persistent_parameters): New variable.
83 (Fset_window_configuration, save_window_save): Handle persistent
84 window parameters.
85
86 2012-01-14 Eli Zaretskii <eliz@gnu.org>
87
88 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
89 thrashing the stack of the thread. (Bug#9087)
90
91 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
92
93 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
94
95 2012-01-11 Eli Zaretskii <eliz@gnu.org>
96
97 * xdisp.c (rows_from_pos_range): Handle the case where the
98 highlight ends on a newline. (Bug#10464)
99 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
100 he end column for display of highlight that ends on a newline
101 before a R2L line.
102
103 2012-01-11 Glenn Morris <rgm@gnu.org>
104
105 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
106 from load-path also when installation-directory is nil. (Bug#10208)
107
108 2012-01-10 Glenn Morris <rgm@gnu.org>
109
110 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
111
112 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
113 Update template values to be closer to their typical values these days.
114
115 2012-01-09 Eli Zaretskii <eliz@gnu.org>
116
117 * xdisp.c (rows_from_pos_range): Accept additional argument
118 DISP_STRING, and accept any glyph in a row whose object is that
119 string as eligible for mouse highlight. Fixes mouse highlight of
120 display strings from overlays. (Bug#10464)
121
122 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
123
124 emacs: fix an auto-save permissions race condition (Bug#10400)
125 * fileio.c (auto_saving_dir_umask): New static var.
126 (Fmake_directory_internal): Use it.
127 (do_auto_save_make_dir): Set it, instead of invoking chmod after
128 creating the directory. The old code temporarily assigns
129 too-generous permissions to the directory.
130 (do_auto_save_eh): Clear it.
131 (Fdo_auto_save): Catch all errors, not just file errors, so
132 that the var is always cleared.
133
134 2012-01-07 Eli Zaretskii <eliz@gnu.org>
135
136 * search.c (scan_buffer): Pass character positions to
137 know_region_cache, not byte positions. (Bug#6540)
138
139 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
140
141 * w32.c (sys_rename): Report EXDEV when rename of a directory
142 fails because the target is on another logical disk. (Bug#10284)
143
144 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
145
146 * xterm.c (x_embed_request_focus): New function.
147
148 * xterm.h: Add prototype.
149
150 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
151
152 2012-01-05 Glenn Morris <rgm@gnu.org>
153
154 * emacs.c (emacs_copyright): Update short copyright year to 2012.
155
156 2012-01-01 Eli Zaretskii <eliz@gnu.org>
157
158 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
159 Load gnutls_transport_set_lowat only if GnuTLS version is below
160 2.11.1.
161 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
162 GnuTLS versions below 2.11.1.
163
164 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
165
166 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
167 to the doc string advising against its use for altering the way
168 windows are scrolled.
169
170 2011-12-28 Kenichi Handa <handa@m17n.org>
171
172 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
173 coding-system ASCII compatible only when it does not produce BOM
174 on encoding (Bug#10383).
175
176 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
177
178 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
179 can scroll.
180 (create_and_show_popup_menu): Always use menu_position_func for
181 Gtk3 (Bug#10361).
182
183 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
184
185 * callint.c (Fcall_interactively): Don't truncate prompt string.
186
187 2011-12-23 Eli Zaretskii <eliz@gnu.org>
188
189 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
190 property that ends at ZV, so that the bidi iteration could be
191 resumed from there (after widening). (Bug#10360)
192
193 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
194
195 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
196
197 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
198
199 * nsterm.m (x_free_frame_resources):
200 Release f->output_data.ns->miniimage.
201 (ns_index_color): Fix indentation. Do not retain
202 color_table->colors[i].
203
204 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
205 before returning.
206
207 * nsfns.m (x_set_background_color): Assign return value from
208 ns_index_color to face-background instead of NSColor*.
209 (ns_implicitly_set_icon_type): Fix indentation.
210 Change assignment in for loop to comparison.
211
212 * emacs.c (ns_pool): New variable.
213 (main): Assign ns_pool.
214 (Fkill_emacs): Call ns_release_autorelease_pool.
215
216 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
217 autorelease fdesc, release fdAttrs and tdict.
218 (ns_get_covering_families): Release charset.
219 (ns_findfonts): Release NSFontDescriptor created with new.
220 (ns_uni_to_glyphs): Fix indentation.
221 (setString): Release attrStr before assigning new value.
222
223 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
224
225 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
226 and NS_IMPL_COCOA.
227 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
228 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
229
230 2011-12-18 David Reitter <reitter@cmu.edu>
231
232 * nsterm.m (ns_term_init): Subscribe for notifications
233 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
234 to method trackingNotification in EmacsMenu.
235
236 * nsmenu.m (trackingMenu): New variable.
237 (trackingNotification): New method (from Aquamacs).
238 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
239 from Aquamacs (Bug#7030).
240
241 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
242
243 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
244 (symbol_to_nsstring): Fix indentation.
245 (ns_symbol_to_pb): New function.
246 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
247 (Fns_rotate_cut_buffers_internal): Removed.
248 (Fns_store_selection_internal): Renamed from
249 Fns_store_cut_buffer_internal.
250 (ns_get_foreign_selection, Fx_own_selection_internal)
251 (Fx_disown_selection_internal, Fx_selection_exists_p)
252 (Fns_get_selection_internal, Fns_store_selection_internal):
253 Use ns_symbol_to_pb and check if return value is nil.
254 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
255 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
256 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
257 renamed to Sns_store_selection_internal.
258 (ns_handle_selection_request): Move code to Fx_own_selection_internal
259 and remove this function.
260 (ns_handle_selection_clear): Remove, never used.
261 (Fx_own_selection_internal): Move code from ns_handle_selection_request
262 here.
263
264 2011-12-17 Ken Brown <kbrown@cornell.edu>
265
266 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
267 GID is unknown (Bug#10257).
268
269 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
270
271 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
272 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
273 which caused a build failure on GNU/Linux IA-64. This problem was
274 introduced by my 2011-10-07 patch.
275
276 2011-12-15 Juri Linkov <juri@jurta.org>
277
278 * image.c (imagemagick_error): New function. (Bug#10112)
279 (imagemagick_load_image): Comment out `MagickSetResolution' call.
280 Use `imagemagick_error' where ImageMagick functions return
281 `MagickFalse'.
282 (Fimagemagick_types): Add `Fnreverse' to return the list in the
283 proper order.
284
285 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
286
287 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
288 fill background (Bug#8992).
289
290 2011-12-13 Martin Rudalics <rudalics@gmx.at>
291
292 * window.c (Vwindow_combination_resize)
293 (Vwindow_combination_limit): Use t instead of non-nil in
294 doc-strings.
295 (Vrecenter_redisplay): Add first sentence of doc-string on
296 separate line.
297 (Frecenter): Fix doc-string typo.
298
299 2011-12-11 Kenichi Handa <handa@m17n.org>
300
301 * coding.c (Funencodable_char_position): Pay attention to the
302 buffer text relocation (Bug#9389).
303
304 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
305
306 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
307 gtk_init (Bug#10100).
308
309 2011-12-10 Eli Zaretskii <eliz@gnu.org>
310
311 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
312 IT->string is nil. (Bug#10263)
313
314 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
315
316 * nsterm.h (x_free_frame_resources): Declare.
317
318 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
319 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
320
321 * nsterm.h (ns_get_defaults_value): Declare.
322
323 * nsterm.m (ns_default): Call ns_get_defaults_value.
324
325 2011-12-09 Eli Zaretskii <eliz@gnu.org>
326
327 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
328 (Bug#10170)
329
330 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
331
332 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
333 that where the value of an _OBJC_* symbol points to is in the .bss
334 section (Bug#10240).
335
336 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
337
338 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
339 after the loop to call ccl_driver at least once (Bug#8619).
340
341 2011-12-08 Kenichi Handa <handa@m17n.org>
342
343 * ftfont.c (get_adstyle_property): Fix previous change
344 (Bug#10233).
345
346 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
347
348 * w32.c (init_environment): If no_site_lisp, remove site-lisp
349 dirs from the default value of EMACSLOADPATH (bug#10208).
350
351 2011-12-07 Glenn Morris <rgm@gnu.org>
352
353 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
354 installation and source directories as well. (Bug#10208)
355
356 2011-12-06 Chong Yidong <cyd@gnu.org>
357
358 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
359
360 2011-12-06 Glenn Morris <rgm@gnu.org>
361
362 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
363 as an error, not just -1. (Bug#10217)
364
365 2011-12-05 Chong Yidong <cyd@gnu.org>
366
367 * keyboard.c (process_special_events): New function.
368 (swallow_events, Finput_pending_p): Use it (Bug#10195).
369
370 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
371
372 * coding.c (encode_designation_at_bol): Don't use uninitialized
373 local variable (Bug#9318).
374
375 2011-12-05 Kenichi Handa <handa@m17n.org>
376
377 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
378 return Qnil (Bug#8046, Bug#10193).
379
380 2011-12-05 Kenichi Handa <handa@m17n.org>
381
382 * coding.c (encode_designation_at_bol): New args charbuf_end and
383 dst. Return the number of produced bytes. Callers changed.
384 (coding_set_source): Return how many bytes coding->source was
385 relocated.
386 (coding_set_destination): Return how many bytes
387 coding->destination was relocated.
388 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
389 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
390
391 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
392
393 * coding.c (CODING_CHAR_CHARSET_P): New macro.
394 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
395 macro (Bug#9318).
396
397 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
398
399 The following changes are to fix Bug#9318.
400
401 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
402 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
403 (encode_coding_iso_2022, encode_coding_sjis)
404 (encode_coding_big5, encode_coding_charset): Use the above macros.
405
406 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
407
408 * lisp.h (process_quit_flag): Fix external declaration.
409
410 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
411
412 Don't macro-inline non-performance-critical code.
413 * eval.c (process_quit_flag): New function.
414 * lisp.h (QUIT): Use it.
415
416 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
417
418 * nsfns.m (get_geometry_from_preferences): New function.
419 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
420
421 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
422
423 * emacs.c (Qkill_emacs): Define.
424 (syms_of_emacs): Initialize it.
425 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
426 Qquit_flag to `kill-emacs' instead.
427 (quit_throw_to_read_char): Add parameter `from_signal'.
428 All callers changed. Call Fkill_emacs if requested and safe.
429 * lisp.h (QUIT): Call Fkill_emacs if requested.
430
431 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
432
433 * widget.c (update_wm_hints): Return if wmshell is null.
434 (widget_update_wm_size_hints): New function.
435
436 * widget.h (widget_update_wm_size_hints): Declare.
437
438 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
439 widget_update_wm_size_hints (Bug#10104).
440
441 2011-12-03 Eli Zaretskii <eliz@gnu.org>
442
443 * xdisp.c (handle_invisible_prop): If the invisible text ends just
444 before a newline, prepare the bidi iterator for consuming the
445 newline, and keep the current paragraph direction. (Bug#10183)
446 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
447
448 2011-12-02 Juri Linkov <juri@jurta.org>
449
450 * search.c (Fword_search_regexp): New Lisp function created from
451 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
452 (Fword_search_backward, Fword_search_forward)
453 (Fword_search_backward_lax, Fword_search_forward_lax):
454 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
455 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
456
457 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
458
459 * fileio.c (Finsert_file_contents): Move after-change-function call
460 to before the "handled:" label, since all "goto handled" appear in
461 cases where the *-change-functions have already been properly called
462 (bug#10117).
463
464 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
465
466 * keyboard.c (interrupt_signal): Don't call kill-emacs when
467 waiting for input. (Bug#10169)
468
469 2011-11-30 Eli Zaretskii <eliz@gnu.org>
470
471 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
472 verifies glyph row's hash code--we have just reallocated the
473 glyphs, so their contents can be complete garbage. (Bug#10164)
474
475 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
476
477 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
478
479 2011-11-30 Eli Zaretskii <eliz@gnu.org>
480
481 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
482 attributes are tested _before_ calling verify_row_hash, to protect
483 against GCC re-ordering of the tests. (Bug#10164)
484
485 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
486
487 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
488
489 * xterm.c (handle_one_xevent): Only set async_visible and friends
490 if net_wm_state_hidden_seen is non-zero (Bug#10002)
491 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
492 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
493
494 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
495
496 Remove GCPRO-related macros that exist only to avoid shadowing locals.
497 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
498 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
499 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
500 All uses changed to use GCPRO1 etc.
501 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
502 Revert to old implementation (i.e., before 2011-03-11).
503
504 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
505
506 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
507 of scroll runs so as to avoid assigning disabled bogus rows and
508 unnecessary graphics copy operations.
509
510 2011-11-27 Eli Zaretskii <eliz@gnu.org>
511
512 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
513 (snprintf) [_MSC_VER]: Redirect to _snprintf.
514 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
515 (malloc, free, realloc, calloc): Redirect to e_* only when
516 compiling Emacs.
517
518 * lisp.h (GCTYPEBITS): Move before first use.
519 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
520 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
521 this macro definition.
522
523 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
524 _MSC_VER.
525
526 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
527
528 * gtkutil.c (xg_create_frame_widgets):
529 Call gtk_window_set_has_resize_grip (FALSE) if that function is
530 present with Gtk+ 2.0.
531
532 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
533
534 * fileio.c (Finsert_file_contents): Undo previous change; see
535 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
536
537 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
538
539 Rename locals to avoid shadowing.
540 * fileio.c (Finsert_file_contents):
541 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
542 * process.c (wait_reading_process_output):
543 Rename inner 'proc' to 'p' to avoid shadowing.
544 Indent for consistency with usual Emacs style.
545
546 2011-11-25 Eli Zaretskii <eliz@gnu.org>
547
548 * xdisp.c (redisplay_window): If cursor row is not fully visible
549 after recentering, and scroll-conservatively is set to a large
550 number, scroll window by a few more lines to make the cursor fully
551 visible and out of scroll-margin. (Bug#10105)
552 (start_display): Don't move to the next line if the display should
553 start at a newline that is part of a display vector or an overlay
554 string. (Bug#10119)
555
556 2011-11-24 Juri Linkov <juri@jurta.org>
557
558 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
559 after the `MagickPingImage' call. (Bug#10112)
560
561 2011-11-23 Chong Yidong <cyd@gnu.org>
562
563 * window.c (Fcoordinates_in_window_p): Accept only live windows.
564
565 2011-11-23 Martin Rudalics <rudalics@gmx.at>
566
567 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
568 making another buffer current. (Bug#10114)
569
570 2011-11-23 Glenn Morris <rgm@gnu.org>
571
572 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
573
574 2011-11-23 Chong Yidong <cyd@gnu.org>
575
576 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
577 using it (Bug#5984).
578
579 2011-11-22 Eli Zaretskii <eliz@gnu.org>
580
581 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
582 and header-lines, as they don't have one computed for them.
583 (Bug#10098)
584
585 * .gdbinit (prow): Make displayed values more self-explaining.
586 Add row's hash code.
587
588 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
589
590 * process.c (wait_reading_process_output): Fix asynchrounous
591 GnuTLS socket handling on some versions of the GnuTLS library.
592 (wait_reading_process_output): Add comment and URL.
593
594 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
595
596 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
597
598 2011-11-21 Chong Yidong <cyd@gnu.org>
599
600 * window.c (Fnext_window, Fprevious_window): Doc fix.
601
602 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
603
604 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
605
606 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
607
608 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
609
610 2011-11-20 Martin Rudalics <rudalics@gmx.at>
611
612 * window.c (Fset_window_combination_limit): Rename argument
613 STATUS to LIMIT.
614 (Vwindow_combination_limit): Remove "status" from doc-string.
615
616 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
617
618 * m/ibms390.h: Remove.
619 * m/ibms390x.h: Don't include "ibms390.h".
620
621 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
622
623 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
624 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
625
626 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
627
628 * casetab.c (Fset_case_table):
629 * charset.c (Fcharset_after): Fix typos.
630
631 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
632
633 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
634 Otherwise, valgrind does not work on some platforms.
635 Problem reported by Andreas Schwab in
636 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
637 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
638 is set, removing the need for VIRT_ADDRESS_VARIES.
639 (PURE_P): Use a more-efficient implementation that needs just one
640 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
641 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
642 to 4 (xorl, subq, cmpq, setbe).
643 * alloc.c (pure): Always extern now, since that's the
644 VIRT_ADDR_VARIES behavior.
645 (PURE_POINTER_P): Use a single comparison, not two, for
646 consistency with the new puresize.h.
647 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
648 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
649 Remove VIRT_ADDR_VARIES no longer needed.
650
651 2011-11-19 Eli Zaretskii <eliz@gnu.org>
652
653 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
654 (erase_phys_cursor, update_window_cursor, show_mouse_face)
655 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
656 behave as if the cursor position were at the window margin.
657
658 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
659 and the cursor position is out of bounds, behave as if the cursor
660 position were at the window margin. (Bug#10075)
661
662 2011-11-18 Chong Yidong <cyd@gnu.org>
663
664 * window.c (Fwindow_combination_limit): Make first argument
665 non-optional, since it is meaningless for live windows like the
666 selected window.
667
668 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
669
670 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
671
672 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
673
674 * intervals.c: Fix grafting over the whole buffer (bug#10071).
675 (graft_intervals_into_buffer): Simplify.
676
677 2011-11-18 Eli Zaretskii <eliz@gnu.org>
678
679 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
680 hash values of the two rows.
681 (copy_row_except_pointers): Preserve the used[] arrays and the
682 hash values of the two rows. (Bug#10035)
683 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
684
685 * xdisp.c (row_hash): New function, body extracted from
686 compute_line_metrics.
687 (compute_line_metrics): Call row_hash, instead of computing the
688 hash code inline.
689
690 * dispnew.c (verify_row_hash): Call row_hash for computing the
691 hash code of a row, instead of duplicating code from xdisp.c.
692
693 * dispextern.h (row_hash): Add prototype.
694
695 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
696
697 * frame.c (delete_frame): Don't delete the terminal when the last
698 X frame is closed if emacs is built with GTK toolkit.
699
700 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
701
702 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
703
704 2011-11-17 Martin Rudalics <rudalics@gmx.at>
705
706 * window.c (Vwindow_splits): Rename to
707 Vwindow_combination_resize. Suggested by Juri Linkov.
708 (Fsplit_window_internal): Use Vwindow_combination_resize instead
709 of Vwindow_splits.
710
711 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
712
713 * nsfns.m (Fns_font_name):
714 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
715
716 2011-11-16 Martin Rudalics <rudalics@gmx.at>
717
718 * window.h (window): Rename slot "nest" to "combination_limit".
719 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
720 (Fset_window_nest): Rename to Fset_window_combination_limit.
721 (Vwindow_nest): Rename to Vwindow_combination_limit.
722 (recombine_windows, make_parent_window, make_window)
723 (Fsplit_window_internal, saved_window)
724 (Fset_window_configuration, save_window_save): Rename all
725 occurrences of window_nest to window_combination_limit.
726
727 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
728
729 * image.c (imagemagick_load_image): Fix typo.
730
731 2011-11-14 Eli Zaretskii <eliz@gnu.org>
732
733 * xdisp.c (display_line): Move the call to
734 highlight_trailing_whitespace before the call to
735 compute_line_metrics, since the latter needs to see the final
736 faces of all the glyphs to compute ROW's hash value.
737 Fixes assertion violations in row_equal_p. (Bug#10035)
738
739 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
740
741 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
742 just return (bug#10044).
743
744 2011-11-12 Eli Zaretskii <eliz@gnu.org>
745
746 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
747 with user-defined heap size. Bump the default size of the temacs
748 heap to 27MB, to avoid memory warning when running temacs.
749 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
750
751 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
752 current_matrix and desired_matrix. (Bug#9990)
753 (verify_row_hash) [XASSERTS]: New function.
754 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
755 that the hash value of glyph rows is correct.
756
757 2011-11-12 Martin Rudalics <rudalics@gmx.at>
758
759 * window.h (window): Remove splits slot.
760 * window.c (Fwindow_splits, Fset_window_splits): Remove.
761 (Fdelete_other_windows_internal, make_parent_window)
762 (make_window, Fsplit_window_internal, Fdelete_window_internal)
763 (Fset_window_configuration, save_window_save): Don't deal with
764 split status of windows.
765 (saved_window): Remove splits slot.
766 (Vwindow_splits): Rewrite doc-string.
767
768 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
769
770 * xfns.c (unwind_create_frame):
771 * nsfns.m (unwind_create_frame):
772 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
773 Vframe_list (Bug#9999).
774
775 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
776
777 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
778
779 2011-11-11 Kenichi Handa <handa@m17n.org>
780
781 * callproc.c (Fcall_process): Set the member dst_multibyte of
782 process_coding.
783
784 2011-11-11 Johan Bockgård <bojohan@gnu.org>
785
786 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
787 avoid a crash (bug#9496).
788
789 2011-11-09 Chong Yidong <cyd@gnu.org>
790
791 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
792 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
793
794 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
795
796 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
797
798 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
799
800 Avoid some portability problems by eschewing 'extern inline' functions.
801 The trivial performance wins aren't worth the portability hassles; see
802 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
803 et seq.
804 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
805 (window_box_width, window_box_left, window_box_left_offset)
806 (window_box_right, window_box_right_offset): Undo previous change,
807 by removing the "extern"s.
808 * intervals.c (adjust_intervals_for_insertion)
809 (adjust_intervals_for_deletion): Undo previous change,
810 making these static again.
811 (offset_intervals, temp_set_point_both, temp_set_point)
812 (copy_intervals_to_string): No longer inline.
813 * xdisp.c (window_text_bottom_y, window_box_width)
814 (window_box_height, window_box_left_offset)
815 (window_box_right_offset, window_box_left, window_box_right)
816 (window_box): No longer inline.
817
818 2011-11-08 Chong Yidong <cyd@gnu.org>
819
820 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
821 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
822 Signal an error if not a live window.
823 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
824 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
825
826 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
827
828 * lisp.h (syms_of_abbrev): Remove declaration.
829 Reported by CHENG Gao <chenggao@royau.me>.
830
831 2011-11-07 Eli Zaretskii <eliz@gnu.org>
832
833 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
834 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
835 of temacs in GUI mode.
836
837 2011-11-07 Martin Rudalics <rudalics@gmx.at>
838
839 * window.h: Declare delete_all_child_windows instead of
840 delete_all_subwindows.
841 * window.c (Fwindow_nest, Fset_window_nest)
842 (Fset_window_new_total, Fset_window_new_normal)
843 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
844 (delete_all_subwindows): Rename to delete_all_child_windows.
845 (Fdelete_other_windows_internal, Fset_window_configuration):
846 Call delete_all_child_windows instead of delete_all_subwindows.
847 * frame.c (delete_frame): Call delete_all_child_windows instead
848 of delete_all_subwindows.
849
850 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
851
852 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
853 This is also needed for porting to any host where GC_MARK_STACK is
854 not GC_MAKE_GCPROS_NOOPS.
855 (which_symbols): Use it.
856
857 2011-11-07 Kenichi Handa <handa@m17n.org>
858
859 * coding.c (coding_set_destination): Check coding->src_pos only
860 when coding->src_object is a buffer (bug#9910).
861
862 * process.c (send_process): Set the member src_multibyte of coding
863 to 0 (bug#9911) when sending a unibyte text.
864
865 * callproc.c (Fcall_process): Set the member src_multibyte of
866 process_coding to 0 (bug#9912).
867
868 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
869
870 * xmenu.c (cleanup_widget_value_tree): New function.
871 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
872 calling free_menubar_widget_value_tree directly (Bug#9830).
873
874 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
875
876 Fix some portability problems with 'inline'.
877 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
878 (window_box_width, window_box_left, window_box_left_offset)
879 (window_box_right, window_box_right_offset): Declare extern.
880 Otherwise, these inline functions do not conform to C99 and
881 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
882 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
883 * intervals.c (adjust_intervals_for_insertion)
884 (adjust_intervals_for_deletion): Now extern, because otherwise the
885 extern inline functions 'offset_intervals' couldn't refer to it.
886 (static_offset_intervals): Remove.
887 (offset_intervals): Rewrite using the old contents of
888 static_offset_intervals. The old version didn't conform to C99
889 because an extern inline function contained a reference to an
890 identifier with static linkage.
891
892 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
893
894 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
895 GC.
896
897 2011-11-06 Eli Zaretskii <eliz@gnu.org>
898
899 * xdisp.c (init_iterator, reseat_to_string): Don't set the
900 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
901 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
902 return Qleft_to_right.
903
904 2011-11-06 Chong Yidong <cyd@gnu.org>
905
906 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
907 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
908 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
909 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
910 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
911 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
912 (Fwindow_vscroll): Doc fix.
913 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
914 argument, since it makes no sense to pass a live window and for
915 consistency with window-child.
916
917 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
918
919 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
920 support MSVC.
921
922 2011-11-05 Jason Rumney <jasonr@gnu.org>
923
924 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
925 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
926 fonts (Bug#6029).
927 (add_font_entity_to_list): Fix logic errors in mixed boolean and
928 bitwise arithmetic preventing use of unicode-sip and non-truetype
929 opentype fonts.
930
931 2011-11-05 Eli Zaretskii <eliz@gnu.org>
932
933 * s/ms-w32.h (fstat, stat, utime): Move redirections to
934 "emacs"-only part.
935
936 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
937 initialization code to keep similarity to xfns.c after changes
938 from 2011-11-05.
939
940 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
941
942 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
943 (unwind_create_frame): New function (Bug#9943).
944 (Fx_create_frame): Restructure code to be more similar to the one in
945 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
946 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
947 Move terminal->reference_count++ just before making the frame official
948 (Bug#9943).
949
950 * nsterm.m (x_free_frame_resources): New function.
951 (x_destroy_window): Move code to x_free_frame_resources.
952
953 * xfns.c (unwind_create_frame): Fix comment.
954 (Fx_create_frame, x_create_tip_frame):
955 Move terminal->reference_count++ just before making the frame
956 official. Move initialization of image_cache_refcount and
957 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
958
959 2011-11-05 Eli Zaretskii <eliz@gnu.org>
960
961 Support MSVC build with newer versions of Visual Studio.
962 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
963 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
964 nt/gmake.defs.
965
966 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
967 which are not supported by MSVC.
968 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
969 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
970 bitfields.
971 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
972 types in bitfields.
973 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
974
975 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
976
977 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
978
979 Support MSVC build with newer versions of Visual Studio.
980 * w32.c: Don't include w32api.h for MSVC.
981 (init_environment) [_MSC_VER]: Call sys_access, not _access.
982
983 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
984 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
985 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
986 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
987 e_* cousins.
988 (alloca) [_MSC_VER]: Define to _alloca.
989
990 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
991
992 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
993
994 2011-11-04 Eli Zaretskii <eliz@gnu.org>
995
996 * xdisp.c (note_mouse_highlight): If either of
997 previous/next-single-property-change returns nil, treat that as
998 the beginning or the end of the buffer. (Bug#9955)
999
1000 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1001
1002 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1003 label is not null (Bug#9951).
1004 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1005 may be NULL.
1006
1007 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1008
1009 * window.c (Fwindow_body_size): Mention in the doc string that the
1010 return value is in frame's canonical units. (Bug#9949)
1011
1012 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1013
1014 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1015
1016 * w32fns.c (unwind_create_frame): If needed, free the glyph
1017 matrices of the partially constructed frame. (Bug#9943)
1018 * xfns.c (unwind_create_frame): Likewise.
1019
1020 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1021
1022 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1023 Don't stop backward scan on the continuation glyph, even though
1024 its CHARPOS is positive.
1025 (mouse_face_from_buffer_pos, note_mouse_highlight):
1026 Rename cover_string to disp_string.
1027
1028 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1029
1030 * window.c (temp_output_buffer_show): Don't use
1031 Vtemp_buffer_show_specifiers.
1032 (Vtemp_buffer_show_specifiers): Remove unused variable.
1033
1034 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1035
1036 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1037 past the beginning of the current glyph matrix.
1038
1039 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1040
1041 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1042 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1043 HAVE_GTK3 (Bug#9869).
1044
1045 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1046 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1047
1048 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1049
1050 * xterm.c: Declare x_handle_net_wm_state to return int.
1051 (handle_one_xevent): Check if we are iconified but don't have
1052 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1053 (get_current_wm_state): Return non-zero if not hidden,
1054 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1055 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1056 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1057 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1058
1059 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1060
1061 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1062 so that this new function doesn't get optimized away by a
1063 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1064
1065 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1066
1067 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1068
1069 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1070
1071 Fix the `xbytecode' command.
1072 * .gdbinit (xprintbytestr): New command.
1073 (xwhichsymbols): Rename from `which'; all callers changed.
1074 (xbytecode): Print the byte-code string as well.
1075
1076 2011-10-29 Kim Storm <storm@cua.dk>
1077
1078 * alloc.c (which_symbols): New function.
1079
1080 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1081
1082 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1083 line. (Bug#9903)
1084
1085 2011-10-29 Glenn Morris <rgm@gnu.org>
1086
1087 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1088 Not clear what it was for, and it causes various bugs. (Bug#9839)
1089
1090 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1091
1092 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1093 possible random value that matches one of those tested as
1094 condition to clear the mouse face.
1095
1096 2011-10-28 Chong Yidong <cyd@gnu.org>
1097
1098 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1099
1100 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1101
1102 * window.c (make_window): Initialize phys_cursor_on_p.
1103
1104 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1105
1106 * lisp.h (struct Lisp_Symbol): Update comments.
1107
1108 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1109
1110 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1111
1112 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1113
1114 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1115 <oslsachem@gmail.com> for helping to debug this.
1116
1117 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1118 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1119 (g_b_init_get_glyph_outline_w): New static variables.
1120 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1121 (GetGlyphOutlineW_Proc): New typedefs.
1122 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1123 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1124 New functions.
1125 (w32font_open_internal, compute_metrics):
1126 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1127 instead of calling the "wide" APIs directly.
1128
1129 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1130
1131 * w32.h (syms_of_w32font): Add prototype.
1132
1133 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1134
1135 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1136 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1137 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1138 (Fmove_to_window_line): Doc fix.
1139
1140 2011-10-27 Chong Yidong <cyd@gnu.org>
1141
1142 * process.c (make_process): Set gnutls_state to NULL.
1143
1144 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1145 non-NULL, regardless of GNUTLS_INITSTAGE.
1146 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1147 an error. Set process slots as soon as we allocate them.
1148
1149 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1150
1151 2011-10-27 Chong Yidong <cyd@gnu.org>
1152
1153 * gnutls.c (emacs_gnutls_deinit): New function.
1154 Deallocate credentials structures as well as calling gnutls_deinit.
1155 (Fgnutls_deinit, Fgnutls_boot): Use it.
1156
1157 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1158 (deactivate_process): Call emacs_gnutls_deinit.
1159
1160 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1161
1162 * image.c (x_create_x_image_and_pixmap):
1163 * w32.c (sys_rename, w32_delayed_load):
1164 * w32font.c (fill_in_logfont):
1165 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1166
1167 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1168
1169 * w32fns.c (w32_default_color_map): New function,
1170 extracted from Fw32_default_color_map.
1171 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1172
1173 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1174
1175 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1176
1177 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1178
1179 * keyboard.c (test_undefined): New function (bug#9751).
1180 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1181
1182 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1183
1184 * sysdep.c (init_sys_modes): Fix the check for the controlling
1185 terminal (Bug#6649).
1186
1187 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1188
1189 * dispextern.h (struct bidi_it): New member next_en_type.
1190
1191 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1192 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1193 current character, check also for next_en_type being WEAK_EN.
1194 (bidi_resolve_weak): Don't enter the expensive loop if the current
1195 position is before next_en_pos. Record the bidi type of the first
1196 non-ET, non-BN character we find, in addition to its position.
1197 (bidi_level_of_next_char): Invalidate next_en_type when
1198 next_en_pos is over-stepped.
1199
1200 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1201
1202 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1203 * editfns.c: Rewrite current-time-zone so that it invokes
1204 the equivalent of (format-time-string "%Z") to get the time zone name.
1205 This fixes a bug when the time zone name contains characters that
1206 need converting from the system time locale to Emacs internal format.
1207 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1208 that patch fixed format-time-string to do the conversion, but
1209 I forgot to fix current-time-zone.
1210 (format_time_string): New function, containing most of
1211 what Fformat_time_string used to contain.
1212 (Fformat_time_string): Rewrite in terms of format_time_string.
1213 This doesn't change this function's behavior.
1214 (current-time-zone): Rewrite to use format_time_string.
1215 This fixes the bug reported by Michael Schierl in
1216 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1217 Jason Rumney's 2007-06-07 change worked around this bug, but
1218 didn't fix it.
1219 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1220
1221 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1222
1223 * xdisp.c (start_display): If the character at POS is displayed
1224 via a display vector, reset IT->current.dpvec_index to zero.
1225 (try_window_reusing_current_matrix): If a line ends in a display
1226 vector or the next line starts in a display vector, continue
1227 redrawing the window even though the character position of
1228 start_row was reached.
1229 (Bug#9771, part 2)
1230
1231 2011-10-18 Chong Yidong <cyd@gnu.org>
1232
1233 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1234 with nobreak-char-display too.
1235
1236 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1237
1238 Fix part 3 of bug#9771.
1239 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1240 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1241 non-neutral characters if the current character is a paragraph
1242 separator (a.k.a. Newline). This avoids running the same
1243 expensive loop twice, once when we consume the preceding newline
1244 and the other time when the line actually needs to be displayed.
1245 Avoid the loop when we see neutrals on the base embedding level
1246 following a character whose directionality is the same as the
1247 paragraph's. This avoids running the expensive loop when a line
1248 ends in a long sequence of neutrals, like control characters.
1249 Add assertion against STRONG_AL type. Slightly rearrange code
1250 that determines the type of a neutral given the first non-neutral
1251 that follows it.
1252 (bidi_level_of_next_char): Set next_en_pos to zero when
1253 invalidating its info.
1254
1255 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1256
1257 * xdisp.c (push_display_prop): Determine whether to record string
1258 or buffer position by IT->string, not by IT->method. Allow
1259 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1260 (move_it_vertically_backward): Don't look for character position
1261 immediately after the newline when in a continuation line.
1262 (Bug#9771, part 1)
1263
1264 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1265
1266 * window.c (coordinates_in_window): Rewrite and delabelize
1267 vertical border check. (Bug#5357) (Bug#9618)
1268
1269 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1270
1271 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1272 errors in XSetWindowBorder (bug#9310).
1273
1274 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1275
1276 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1277 avoid crash when xmalloc overrun checking is enabled.
1278
1279 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1280
1281 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1282 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1283 cursor motion with <left> and <right> arrow keys.
1284
1285 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1286 some callers set that themselves.
1287
1288 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1289
1290 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1291 display string and the previous row comes from the same string and
1292 is empty. (Bug#9739) (Bug#9738)
1293
1294 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1295
1296 * doc.c (get_doc_string): Encode file name (bug#9735).
1297
1298 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1299
1300 * bidi.c (bidi_level_of_next_char):
1301 * xdisp.c (get_visually_first_element): Remove old incorrect
1302 comments regarding the Unicode Line Separator character.
1303
1304 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1305
1306 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1307
1308 * alloc.c (Fgc_status): Do not access beyond zombies array
1309 boundary if nzombies > MAX_ZOMBIES.
1310 * alloc.c (dump_zombies): Add missing format specifier.
1311
1312 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1313
1314 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1315 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1316
1317 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1318 Some packages use them to denote characters with modifiers.
1319
1320 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1321
1322 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1323 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1324 matching a pp-number. Rename parameter var to var1.
1325
1326 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1327
1328 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1329
1330 2011-10-08 Glenn Morris <rgm@gnu.org>
1331
1332 * callint.c (Fcall_interactively): Give a more explicit error for the
1333 'c' case with a non-character input. (Bug#8479)
1334
1335 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1336
1337 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1338 lines.
1339 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1340 lines that are hscrolled on the left.
1341
1342 * dispnew.c (buffer_posn_from_coords): Account for a possible
1343 presence of header-line. (Bug#4426)
1344
1345 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1346
1347 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1348 Don't advertise functionality which we discourage or doesn't work.
1349
1350 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1351
1352 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1353 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1354 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1355 this makes Emacs dump core during garbage collection on rare
1356 occasions. sizeof is obviously inferior to offsetof here, so
1357 stick with offsetof.
1358 (GC_POINTER_ALIGNMENT): New macro.
1359 (mark_memory): Omit 3rd (offset) arg; caller changed.
1360 Don't assume EMACS_INT alignment is the same as pointer alignment.
1361
1362 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1363
1364 * keyboard.c (read_key_sequence_remapped): New var.
1365 (read_key_sequence): Compute remapping in the right buffer.
1366 (command_loop_1): Use read_key_sequence's remapping directly.
1367
1368 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1369
1370 * dired.c (file_name_completion): Don't expand file name.
1371 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1372 before checking file name handler.
1373
1374 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1375 they've been requested explicitly (bug#9591).
1376
1377 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1378
1379 * keymap.c (Fsingle_key_description): Use make_specified_string
1380 instead of build_string to build string from push_key_description.
1381 (Bug#5193)
1382
1383 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1384
1385 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1386 This fixes a Y2038 bug on 64-bit hosts.
1387 * buffer.c (reset_buffer):
1388 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1389 (Fclear_buffer_auto_save_failure):
1390 Use 0, not -1, to represent an unset failure time, since time_t
1391 might not be signed.
1392
1393 Remove dependency on glibc malloc internals.
1394 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1395 Move back here from lisp.h, but with their new implementations.
1396 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1397 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1398 * charset.c (charset_table_init): New static var.
1399 (syms_of_charset): Use it instead of xmalloc. This removes a
1400 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1401 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1402 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1403 Move back to alloc.c.
1404 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1405 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1406
1407 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1408
1409 * nsterm.m (windowDidResize): Call x_set_window_size only when
1410 ns_in_resize is true. Otherwise set pixelwidth/height and
1411 call change_frame_size (Bug#9628).
1412
1413 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1414
1415 Port --enable-checking=all to Fedora 14 x86-64.
1416 * charset.c (syms_of_charset): Also account for glibc malloc's
1417 internal overhead when calculating the initial malloc maximum.
1418
1419 Port --enable-checking=all to Fedora 14 x86.
1420 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1421 Move to lisp.h.
1422 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1423 (overrun_check_realloc, overrun_check_free):
1424 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1425 That way, xmalloc returns a properly-aligned pointer even if
1426 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1427 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1428 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1429 into account when calculating the initial malloc maximum.
1430 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1431 Move here from alloc.c, so that charset.c can use it too.
1432 Properly align; the old code wasn't right for common 32-bit hosts
1433 when configured with --enable-checking=all.
1434 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1435 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1436
1437 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1438
1439 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1440 use EDOM.
1441
1442 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1443
1444 * xdisp.c (compute_display_string_end): If there's no display
1445 string at CHARPOS, return -1.
1446
1447 * bidi.c (bidi_fetch_char): When compute_display_string_end
1448 returns a negative value, treat the character as a normal
1449 character not covered by a display string. (Bug#9624)
1450
1451 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1452
1453 * lread.c (Fread_from_string): Fix typo in docstring.
1454
1455 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1456
1457 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1458 newline, reseat the iterator instead of bidi-iterating there one
1459 character at a time. (Bug#9610)
1460 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1461 TO_CHARPOS if the bidi iterator is at base embedding level.
1462
1463 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1464
1465 * lread.c (readevalloop): Use correct code for NBSP.
1466 (read1): Likewise. (Bug#9608)
1467
1468 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1469
1470 * dbusbind.c (Fdbus_register_signal): When service is not
1471 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1472
1473 2011-09-25 Glenn Morris <rgm@gnu.org>
1474
1475 * buffer.c (truncate-lines): Doc fix.
1476
1477 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1478
1479 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1480 (Fset_window_next_buffers): Doc fix.
1481
1482 2011-09-24 Glenn Morris <rgm@gnu.org>
1483
1484 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1485
1486 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1487
1488 Fix minor problems found by static checking.
1489 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1490 * indent.c (Fvertical_motion): Fix == vs = typo.
1491
1492 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1493
1494 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1495 Default value is now t. Doc fix.
1496
1497 * indent.c (Fvertical_motion): Compute and apply the overshoot
1498 logic when moving up, not only when moving down. Fix the
1499 confusing name and values of the it_overshoot_expected variable;
1500 logic changes accordingly. (Bug#9254) (Bug#9549)
1501
1502 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1503 CHARPOS is covered by a display string which includes newlines.
1504 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1505 is covered by a display string with embedded newlines.
1506
1507 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1508
1509 * dbusbind.c (Fdbus_register_signal): Add match rule to
1510 Vdbus_registered_objects_table. (Bug#9581)
1511 (Fdbus_register_method, Vdbus_registered_objects_table):
1512 Fix docstring.
1513
1514 2011-09-24 Jim Meyering <meyering@redhat.com>
1515
1516 do not ignore write error for any output size
1517 The previous change was incomplete.
1518 While it makes emacs --batch detect the vast majority of stdout
1519 write failures, errors were still ignored whenever the output size is
1520 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1521 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1522 && echo FAIL: ignored write error
1523 FAIL: ignored write error
1524 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1525 && echo FAIL: ignored write error
1526 FAIL: ignored write error
1527 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1528
1529 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1530
1531 * emacs.c (Fkill_emacs): In noninteractive mode exit
1532 non-successfully if a write error occurred on stdout. (Bug#9574)
1533
1534 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1535
1536 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1537 the xassert test.
1538
1539 * dispextern.h (struct it): Update the comment documenting what
1540 can it->OBJECT be.
1541
1542 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1543
1544 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1545 a display string, extend search for cursor position to end of row.
1546 (find_row_edges): If the row ends in a newline from a display
1547 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1548 Handle the case of a display string with multiple newlines.
1549 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1550 non-empty line. Fixes confusing cursor motion with arrow keys at
1551 the beginning of a line that starts with whitespace.
1552
1553 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1554
1555 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1556 (bug#9493).
1557
1558 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1559
1560 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1561 boolean (Bug#9154).
1562
1563 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1564
1565 * xdisp.c (display_line): Record maximum and minimum buffer
1566 positions even if no glyphs were produced (e.g., by a zero-width
1567 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1568 buffer positions that will be removed from the glyph row because
1569 they don't fit.
1570 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1571 column is beyond frame width: don't subtract 1 "pixel" when
1572 computing width of the stretch.
1573 (reseat_at_next_visible_line_start): Undo the change made on
1574 2011-09-17 that saved paragraph information and restored it after
1575 the call to `reseat'. (Bug#9545)
1576
1577 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1578
1579 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1580 and turn window cursor on if cleared (Bug#9415).
1581
1582 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1583
1584 * search.c (boyer_moore): Take unibyte characters from pattern
1585 literally. (Bug#9458)
1586
1587 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1588
1589 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1590
1591 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1592
1593 Fix minor problem found by static checking.
1594 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1595 initialized, to pacify gcc -Wuninitialized.
1596
1597 * fileio.c: Report proper errno when syscall falls.
1598 (Finsert_file_contents): Save and restore errno,
1599 so that report_file_error outputs the correct diagnostic.
1600 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1601
1602 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1603
1604 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1605
1606 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1607
1608 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1609 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1610
1611 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1612
1613 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1614 about the current paragraph and restore it after the call to reseat.
1615
1616 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1617 (bidi_find_paragraph_start): Search back for paragraph beginning
1618 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1619 (bidi_move_to_visually_next): Only trigger paragraph-related
1620 computations when the last character is a newline or at EOB, not
1621 just any NEUTRAL_B. (Bug#9470)
1622
1623 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1624 truncated lines if point is covered by a display string. (Bug#9524)
1625
1626 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1627
1628 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1629 (cons_to_x_long): New function.
1630 (lisp_data_to_selection_data): Use it. Correct the test for
1631 short-versus-long data; it was negated. Break out of vector
1632 loop, for efficiency, when a long datum is discovered.
1633
1634 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1635
1636 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1637
1638 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1639
1640 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1641 GCC PR/17406) by declaring this function with external scope.
1642
1643 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1644
1645 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1646 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1647
1648 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1649
1650 * editfns.c (Fformat): Correctly handle text properties on "%%".
1651
1652 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1653
1654 * xterm.c (x_draw_composite_glyph_string_foreground):
1655 * w32term.c (x_draw_composite_glyph_string_foreground):
1656 * term.c (encode_terminal_code):
1657 * composite.c (composition_update_it, get_composition_id):
1658 * xdisp.c (get_next_display_element)
1659 (fill_composite_glyph_string): Add comments about special meaning
1660 of TAB characters in a composition.
1661
1662 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1663
1664 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1665 This occurs when processing a multibyte format.
1666 Problem reported by Wolfgang Jenker.
1667
1668 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1669
1670 * xdisp.c (try_cursor_movement): Only check for exact match if
1671 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1672
1673 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1674
1675 Remove unused external symbols.
1676 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1677 * xdisp.c (calc_pixel_width_or_height): Now static.
1678 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1679 * indent.c (check_display_width):
1680 * w32term.c: Fix comment to match code.
1681 * xterm.c, xterm.h (x_catching_errors): Remove.
1682
1683 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1684
1685 * xselect.c: Use signed conversions more consistently (Bug#9498).
1686 (selection_data_to_lisp_data): Assume incoming selection data are
1687 signed integers, not unsigned. This is to be consistent with
1688 outgoing selection data, which was modified to use signed integers
1689 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1690 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1691 expects long, not unsigned long.
1692
1693 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1694
1695 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1696 computation of loop end. Reported by Johan Bockgård
1697 <bojohan@gnu.org>.
1698
1699 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1700
1701 * frame.c (Fother_visible_frames_p): Function deleted.
1702
1703 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1704
1705 * indent.c (compute_motion): Process display vector front to back
1706 rather than the other way around. (Bug#2496)
1707
1708 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1709
1710 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1711
1712 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1713
1714 * minibuf.c (Fread_from_minibuffer): Doc fix.
1715
1716 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1717
1718 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1719 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1720
1721 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1722
1723 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1724 value for non-existent files.
1725
1726 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1727
1728 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1729 set its "size" to -1. This will set the modtime_size field of
1730 the corresponding buffer to -1, which is what
1731 verify-visited-file-modtime expects for files that do not exist.
1732 (Bug#9139)
1733
1734 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1735
1736 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1737 here ...
1738 * lisp.h: ... from here. push_key_description is no longer
1739 defined in keyboard.c, so its declaration should not be in
1740 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1741 logically belongs with push_key_description.
1742
1743 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1744
1745 * buffer.h: Include <sys/types.h> instead of <time.h>.
1746 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1747 Problem reported by Herbert J. Skuhra.
1748
1749 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1750
1751 * xml.c (parse_region): Make the parsing work for
1752 non-comment-starting XML files again (bug#9144).
1753
1754 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1755
1756 * image.c (gif_load): Fix calculation of bottom and right corner.
1757 (Bug#9468)
1758
1759 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1760
1761 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1762 redisplay in small windows.
1763
1764 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1765
1766 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1767
1768 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1769
1770 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1771 Operate on live windows only.
1772
1773 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1774
1775 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1776
1777 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1778
1779 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1780 only under bidi iteration.
1781
1782 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1783
1784 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1785
1786 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1787
1788 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1789 Without this fix, the command to link temacs failed due to an
1790 undefined symbol __builtin_isnan. This is because
1791 /usr/include/iso/math_c99.h #defines isnan(x) to
1792 __builtin_isnan(x), but the bundled gcc, which identifies itself
1793 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1794 a __builtin_isnan.
1795 * floatfns.c (isnan): #undef, and then #define to a clone of
1796 what's in data.c.
1797 (Fisnan): Always define, since it's always available now.
1798 (syms_of_floatfns): Always define isnan at the Lisp level.
1799
1800 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1801
1802 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1803
1804 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1805
1806 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1807 The previous code assumed that file offsets (off_t values) fit in
1808 EMACS_INT variables, which is not true on typical 32-bit hosts.
1809 The code messed up by falsely reporting buffer overflow in cases
1810 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1811 when "big" contains more than 2**29 bytes, even though this
1812 inserts just one byte and does not overflow the buffer.
1813 (Finsert_file_contents): Store file offsets as off_t
1814 values, not as EMACS_INT values. Check for overflow when
1815 converting between EMACS_INT and off_t. When checking for
1816 buffer overflow or for overlap, take the offsets into account.
1817 Don't use EMACS_INT for small values where int suffices.
1818 When checking for overlap, fix a typo: ZV was used where
1819 ZV_BYTE was intended.
1820 (Fwrite_region): Don't assume off_t fits into 'long'.
1821 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1822
1823 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1824
1825 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1826
1827 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1828
1829 sprintf-related integer and memory overflow issues (Bug#9412).
1830
1831 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1832 (esprintf, exprintf, evxprintf): New functions.
1833 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1834 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1835 (modify_event_symbol): Do not assume that the length of
1836 name_alist_or_stem is safe to alloca and fits in int.
1837 (Fexecute_extended_command): Likewise for function name and binding.
1838 (Frecursion_depth): Wrap around reliably on integer overflow.
1839 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1840 since some callers pass EMACS_INT values.
1841 (Fsingle_key_description): Don't crash if symbol name contains more
1842 than MAX_ALLOCA bytes.
1843 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1844 (get_minibuffer): Arg is now EMACS_INT, not int.
1845 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1846 (esprintf, exprintf, evxprintf): New decls.
1847 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1848
1849 * dbusbind.c (signature_cat): New function.
1850 (xd_signature, Fdbus_register_signal):
1851 Do not overrun buffer; instead, report string overflow.
1852
1853 * dispnew.c (add_window_display_history): Don't overrun buffer.
1854 Truncate instead; this is OK since it's just a log.
1855
1856 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1857 even if the time zone offset is outlandishly large.
1858 Don't mishandle offset == INT_MIN.
1859
1860 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1861 when creating daemon; the previous buffer-overflow check was incorrect.
1862
1863 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1864 which has the guts of the old verror function.
1865
1866 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1867 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1868
1869 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1870 (font_unparse_xlfd): Don't blindly alloca long strings.
1871 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1872 fits in int, when using sprintf. Use single snprintf to count
1873 length of string rather than counting it via multiple sprintfs;
1874 that's simpler and more reliable.
1875 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1876 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1877 sprintf, in case result does not fit in int.
1878
1879 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1880 (fontset_from_font): Print it.
1881
1882 * frame.c (tty_frame_count): Now printmax_t, not int.
1883 (make_terminal_frame, set_term_frame_name): Print it.
1884 (x_report_frame_params): In X, window IDs are unsigned long,
1885 not signed long, so print them as unsigned.
1886 (validate_x_resource_name): Check for implausibly long names,
1887 and don't assume name length fits in 'int'.
1888 (x_get_resource_string): Don't blindly alloca invocation name;
1889 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1890 not fit in int.
1891
1892 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1893 (xg_check_special_colors, xg_set_geometry):
1894 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1895
1896 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1897 Use esprintf, not sprintf, in case result does not fit in int.
1898
1899 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1900 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1901 it as a large positive number.
1902 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1903 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1904
1905 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1906 in case result does not fit in int.
1907
1908 * print.c (float_to_string): Detect width overflow more reliably.
1909 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1910 buffer overrun. Don't assume list length fits in 'int'. Treat
1911 print length of 0 as 0, not as infinity; to be consistent with other
1912 uses of print length in this function. Don't overflow print length
1913 index. Don't assume hash table size fits in 'long', or that
1914 vectorlike size fits in 'unsigned long'.
1915
1916 * process.c (make_process): Use printmax_t, not int, to format
1917 process-name gensyms.
1918
1919 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1920
1921 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1922 to avoid potential buffer overrun.
1923
1924 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1925 if X resource line is longer than 512 bytes.
1926
1927 * xfns.c (x_window): Make sprintf buffer a bit bigger
1928 to avoid potential buffer overrun.
1929
1930 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1931
1932 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1933
1934 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1935
1936 Integer overflow fixes for scrolling, etc.
1937 Without these, Emacs silently mishandles large integers sometimes.
1938 For example, "C-u 4294967297 M-x recenter" was treated as if
1939 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1940
1941 * xdisp.c (try_window_id): Check Emacs fixnum range before
1942 converting to 'int'.
1943
1944 * window.c (window_scroll_line_based, Frecenter):
1945 Check that an Emacs fixnum is in range before assigning it to 'int'.
1946 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1947 values converted from Emacs fixnums.
1948 (Frecenter): Don't wrap around a line count if it is out of 'int'
1949 range; instead, treat it as an extreme value.
1950 (Fset_window_configuration, compare_window_configurations):
1951 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1952
1953 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1954 that can exceed INT_MAX. Check that EMACS_INT value is in range
1955 before assigning it to the (possibly-narrower) index.
1956 (match_limit): Don't assume that a fixnum can fit in 'int'.
1957
1958 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1959 exceed INT_MAX.
1960
1961 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1962 (Fvertical_motion): Don't wrap around LINES values that don't fit
1963 in 'int'. Instead, treat them as extreme values. This is good
1964 enough for windows, which can't have more than INT_MAX lines anyway.
1965
1966 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1967
1968 * Require libxml/parser.h to avoid compilation warning.
1969
1970 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1971
1972 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1973 since this reportedly can destroy thread storage.
1974
1975 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1976
1977 * syntax.c (find_defun_start): Update all cache variables if
1978 exiting early (Bug#9401).
1979
1980 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1981
1982 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1983
1984 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1985 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1986 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1987
1988 * term.c (tty_append_glyph): New function.
1989 (produce_stretch_glyph): Static function and its prototype deleted.
1990
1991 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1992 Add prototypes.
1993
1994 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1995
1996 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1997 when checking :margin (Bug#9390).
1998 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1999 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2000 so that the name doesn't mislead. All uses changed.
2001
2002 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2003
2004 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2005 set_tty_hooks.
2006
2007 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2008
2009 * xdisp.c (move_it_to): Don't bail out early when reaching
2010 position beyond to_charpos, if we are scanning backwards.
2011 (move_it_vertically_backward): When DY == 0, make sure we get to
2012 the first character in the line after the newline.
2013
2014 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2015
2016 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2017 (ccl_driver): Do not generate an out-of-range pointer.
2018 (Fccl_execute_on_string): Remove unnecessary check for
2019 integer overflow, noted by Stefan Monnier in
2020 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2021 Remove a FIXME that didn't need fixing.
2022 Simplify the newly-introduced buffer reallocation code.
2023
2024 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2025
2026 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2027
2028 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2029
2030 Integer and memory overflow issues (Bug#9196).
2031
2032 * doc.c (get_doc_string): Rework so that
2033 get_doc_string_buffer_size is the actual buffer size, rather than
2034 being 1 less than the actual buffer size; this makes xpalloc more
2035 convenient.
2036
2037 * image.c (x_allocate_bitmap_record, cache_image):
2038 * xselect.c (Fx_register_dnd_atom):
2039 Simplify previous changes by using xpalloc.
2040
2041 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2042 since either will do and ptrdiff_t is convenient with xpalloc.
2043
2044 * charset.c (charset_table_size)
2045 (struct charset_sort_data.priority): Now ptrdiff_t.
2046 (charset_compare): Don't overflow if priorities differ greatly.
2047 (Fsort_charsets): Don't assume list length fits in int.
2048 Check for size-calculation overflow when allocating sort data.
2049 (syms_of_charset): Allocate an initial charset table that is
2050 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2051
2052 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2053
2054 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2055 The actual value is always <= INT_MAX, and leaving it unsigned made
2056 overflow checking harder.
2057
2058 * dispextern.h (struct glyph_matrix.rows_allocated)
2059 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2060 with xpalloc. The values are still always <= INT_MAX.
2061
2062 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2063
2064 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2065 (SAFE_NALLOCA): New macro.
2066
2067 * region-cache.c (struct boundary.pos, find_cache_boundary)
2068 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2069 (set_cache_region, invalidate_region_cache)
2070 (revalidate_region_cache, know_region_cache, region_cache_forward)
2071 (region_cache_backward, pp_cache):
2072 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2073 so that ptrdiff_t * can be passed to xpalloc.
2074 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2075 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2076 (pp_cache): Don't assume cache_len fits in int.
2077 * region-cache.h: Adjust extern decls to match.
2078
2079 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2080 EMACS_INT, since either will do, for xpalloc.
2081
2082 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2083 (xnmalloc, xnrealloc, xpalloc): New functions.
2084
2085 * bidi.c (bidi_shelve_header_size): New constant.
2086 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2087 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2088
2089 * bidi.c (bidi_cache_shrink):
2090 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2091 (overlay_strings):
2092 Don't update size of array until after memory allocation succeeds,
2093 because xmalloc/xrealloc may not return.
2094 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2095 now that we have proper integer overflow checking.
2096 (record_overlay_string, overlay_strings): Catch overflows when
2097 calculating size of overlay_str_buf.
2098
2099 * callproc.c (Fcall_process): Check for size overflow when
2100 calculating size of args2.
2101 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2102 Normally we prefer signed values, but sticking with ptrdiff_t would
2103 require adding more-complicated checks.
2104
2105 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2106 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2107 Redo buffer-overflow calculations to avoid integer overflow.
2108 Add a FIXME comment where memory seems to be over-allocated.
2109
2110 * character.c (Fstring): Check for size-calculation overflow.
2111
2112 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2113 unnecessary integer overflow. Check for size overflow.
2114 (encode_coding_object): Don't update size until xmalloc succeeds.
2115
2116 * composite.c (get_composition_id): Check for overflow in glyph
2117 length calculations.
2118
2119 Integer and memory overflow fixes for display code.
2120 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2121 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2122 (scrolling_window): Check for overflow in size calculations.
2123 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2124 Don't assume glyph table len fits in int.
2125 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2126 (row_table_size): Now ptrdiff_t, not int.
2127 (scrolling_window): Avoid overflow in size calculations.
2128 Don't update size until allocation succeeds.
2129 * fns.c (concat): Check for overflow in size calculations.
2130 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2131 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2132 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2133
2134 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2135 (get_doc_string): Check for size calculation overflow.
2136 Don't update size until allocation succeeds.
2137 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2138 EMACS_INT, where ptrdiff_t will do.
2139 (Fsubstitute_command_keys): Check for string overflow.
2140
2141 * editfns.c (set_time_zone_rule): Don't assume environment length
2142 fits in int.
2143 (message_length): Now ptrdiff_t, not int.
2144 (Fmessage_box): Don't update size until allocation succeeds.
2145 Don't assume message length fits in int.
2146 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2147
2148 * emacs.c (main): Do not reallocate argv, since there is a null at
2149 the end that can be overwritten, and this way there's no need to
2150 worry about size-calculation overflow.
2151 (sort_args): Check for size-calculation overflow.
2152
2153 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2154 alloc succeeds.
2155 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2156
2157 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2158 (x_set_scroll_bar_width, x_figure_window_size):
2159 Check for integer overflow.
2160 (x_set_alpha): Do not assume XINT fits in int.
2161
2162 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2163 This is for the members text_lines, text_cols, total_lines, total_cols,
2164 where the system imposes an 'int' limit.
2165
2166 * fringe.c (Fdefine_fringe_bitmap):
2167 Don't update size until alloc works.
2168
2169 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2170 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2171
2172 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2173 Check for size-calculation overflow.
2174 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2175 do, as we prefer signed integers.
2176 (id_to_widget.max_size, id_to_widget.used)
2177 (xg_store_widget_in_map, xg_remove_widget_from_map)
2178 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2179 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2180 Use and return ptrdiff_t, not int.
2181 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2182 * gtkutil.h: Change prototypes to match the above.
2183
2184 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2185 are duplicate now that they've been promoted to lisp.h.
2186 (x_allocate_bitmap_record, x_alloc_image_color)
2187 (make_image_cache, cache_image, xpm_load):
2188 Don't update size until alloc is done.
2189 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2190 (x_detect_edges):
2191 Check for size calculation overflow.
2192 (ct_colors_allocated_max): New constant.
2193 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2194 overflow.
2195
2196 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2197 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2198 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2199 Use ptrdiff_t, not int, to count maps.
2200 (read_char_minibuf_menu_prompt): Check for overflow in size
2201 calculations. Don't update size until allocation succeeds.
2202 Redo calculations to avoid overflow.
2203 * keyboard.h: Change prototypes to match the above.
2204
2205 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2206 to count maps.
2207 (current_minor_maps): Check for size calculation overflow.
2208 * keymap.h: Change prototypes to match the above.
2209
2210 * lread.c (read1, init_obarray): Don't update size until alloc done.
2211
2212 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2213 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2214
2215 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2216 Now ptrdiff_t, not int.
2217 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2218 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2219
2220 * process.c (Fnetwork_interface_list): Check for overflow
2221 in size calculation.
2222
2223 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2224
2225 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2226 overflow. Don't bother calling xmalloc when xrealloc will do.
2227
2228 * search.c (Freplace_match): Check for size calculation overflow.
2229 (Fset_match_data): Don't assume list lengths fit in 'int'.
2230
2231 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2232 for command line length. Do not attempt to address one before the
2233 beginning of an array, as that's not portable.
2234
2235 * term.c (max_frame_lines): Remove; unused.
2236 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2237 not int.
2238 (encode_terminal_code, calculate_costs): Check for size
2239 calculation overflow.
2240 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2241 table lengths and related sizes. Don't update size until alloc
2242 done. Redo calculations to avoid overflow.
2243 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2244
2245 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2246 subtracting pointers.
2247 (gobble_line): Check for overflow more carefully. Don't update size
2248 until alloc done.
2249
2250 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2251 Don't update size until alloc done.
2252 Redo size calculations to avoid overflow.
2253 Check for size calculation overflow.
2254 (main) [DEBUG]: Fix typo in invoking tparam1.
2255
2256 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2257 Use ptrdiff_t, not int, for sizes.
2258 (store_mode_line_noprop_char): Don't update size until alloc done.
2259
2260 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2261 Use ptrdiff_t, not int, for sizes.
2262 (Finternal_make_lisp_face, cache_face):
2263 Check for size calculation overflow.
2264 (cache_face): Treat size calculation overflows as if they were
2265 memory exhaustion (the usual treatment), rather than aborting.
2266
2267 * xfns.c (x_encode_text, x_set_name_internal)
2268 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2269 sizes, since they can exceed INT_MAX in size. Check for size
2270 calculation overflow.
2271
2272 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2273 (xg_select): Check for size calculation overflow.
2274 Don't update size until alloc done.
2275
2276 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2277 as sprintf is limited to int lengths.
2278
2279 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2280 (X_LONG_MIN): New macros.
2281 Use them to make the following changes clearer.
2282 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2283 This change doesn't affect the value now, but it may help remind
2284 future maintainers not to raise the value too much later.
2285 (SELECTION_QUANTUM): Remove, replacing with ...
2286 (selection_quantum): ... new function, which avoids overflow.
2287 All uses changed.
2288 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2289 assumption that selection length fits in 'int'.
2290 (x_reply_selection_request, x_handle_selection_request)
2291 (x_get_window_property, receive_incremental_selection)
2292 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2293 (lisp_data_to_selection_data, clean_local_selection_data):
2294 Use ptrdiff_t, not int, to record length of selection.
2295 (x_reply_selection_request, x_get_window_property)
2296 (receive_incremental_selection, x_property_data_to_lisp):
2297 Redo calculations to avoid overflow.
2298 (x_reply_selection_request): When sending hint, ceiling it at
2299 X_LONG_MAX rather than relying on wraparound overflow to send
2300 something.
2301 (x_get_window_property, receive_incremental_selection)
2302 (lisp_data_to_selection_data, x_property_data_to_lisp):
2303 Check for size-calculation overflow.
2304 (x_get_window_property, receive_incremental_selection)
2305 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2306 Don't store size until memory allocation succeeds.
2307 (x_get_window_property): Plug memory leak on memory exhaustion.
2308 Don't double-block input; malloc is safe here. Don't assume 2**34
2309 - 4 fits in unsigned long. Add an xassert to check
2310 XGetWindowProperty overflow. Be more careful about overflow
2311 calculations, and distinguish size from memory overflow better.
2312 (receive_incremental_selection): When tracing, don't assume
2313 unsigned int is less than INT_MAX.
2314 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2315 harmful) conversions of unsigned short to int.
2316 (lisp_data_to_selection_data): Don't assume that integers
2317 in the range -65535 through -1 fit in an X unsigned short.
2318 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2319 result parameters unless successful. Rely on cons_to_unsigned
2320 to report problems with elements; the old code wasn't right anyway.
2321 (x_check_property_data): Check for int overflow; we cannot use
2322 a wider type due to X limits.
2323 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2324
2325 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2326
2327 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2328 (x_term_init): Check for size calculation overflow.
2329 (x_color_cells): Don't store size until memory allocation succeeds.
2330 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2331 Don't assume alloca size is less than MAX_ALLOCA.
2332 (x_term_init): Don't assume length fits in int (sprintf is limited
2333 to int size).
2334
2335 Use ptrdiff_t for composition IDs.
2336 * character.c (lisp_string_width):
2337 * composite.c (composition_table_size, n_compositions)
2338 (get_composition_id, composition_gstring_from_id):
2339 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2340 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2341 * window.c (Frecenter):
2342 Use ptrdiff_t, not int, for composition IDs.
2343 * composite.c (get_composition_id): Check for integer overflow.
2344 * composite.h: Adjust prototypes to match the above changes.
2345
2346 Use ptrdiff_t for hash table indexes.
2347 * category.c (hash_get_category_set):
2348 * ccl.c (ccl_driver):
2349 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2350 * coding.c (coding_system_charset_list, detect_coding_system):
2351 * coding.h (struct coding_system.id):
2352 * composite.c (get_composition_id, gstring_lookup_cache):
2353 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2354 * image.c (xpm_get_color_table_h):
2355 * lisp.h (hash_lookup, hash_put):
2356 * minibuf.c (Ftest_completion):
2357 Use ptrdiff_t for hash table indexes, not int (which is too
2358 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2359 32-bit --with-wide-int hosts).
2360
2361 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2362 Add a FIXME comment about memory leaks.
2363 (syms_of_charset): Don't assume xmalloc returns.
2364
2365 Don't assume that stated character widths fit in int.
2366 * character.c (Fchar_width, c_string_width, lisp_string_width):
2367 * character.h (CHAR_WIDTH):
2368 * indent.c (MULTIBYTE_BYTES_WIDTH):
2369 Use sanitize_char_width to avoid undefined and/or bad behavior
2370 with outlandish widths.
2371 * character.h (sanitize_tab_width): Rename from sanitize_width,
2372 now that we have two such functions. All uses changed.
2373 (sanitize_char_width): New inline function.
2374
2375 Don't assume that tab-width fits in int.
2376 * character.h (sanitize_width): New inline function.
2377 (SANE_TAB_WIDTH): New macro.
2378 (ASCII_CHAR_WIDTH): Use it.
2379 * indent.c (sane_tab_width): Remove. All uses replaced by
2380 SANE_TAB_WIDTH (current_buffer).
2381 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2382
2383 * fileio.c: Integer overflow issues with file modes.
2384 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2385
2386 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2387 Remove unreachable code.
2388 (read_hex, load_charset_map_from_file): Check for integer overflow.
2389
2390 * xterm.c: Don't go over XClientMessageEvent limit.
2391 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2392 (x_send_scroll_bar_event): Likewise. Check that the size does not
2393 exceed limits imposed by XClientMessageEvent, as well as the usual
2394 ptrdiff_t and size_t limits.
2395
2396 * keyboard.c: Overflow, signedness and related fixes.
2397 (make_lispy_movement): Use same integer type in forward decl
2398 that is used in the definition.
2399 (read_key_sequence, keyremap_step):
2400 Change bufsize argument back to int, undoing my 2011-03-30 change.
2401 We prefer signed types, and int is wide enough here.
2402 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2403 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2404 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2405 length, not size_t. Use ptrdiff_t for index, not int.
2406 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2407 possibility of integer overflow.
2408
2409 Overflow, signedness and related fixes for images.
2410
2411 * dispextern.h (struct it.stack[0].u.image.image_id)
2412 (struct_it.image_id, struct image.id, struct image_cache.size)
2413 (struct image_cache.used, struct image_cache.ref_count):
2414 * gtkutil.c (update_frame_tool_bar):
2415 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2416 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2417 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2418 * nsmenu.m (update_frame_tool_bar):
2419 * xdisp.c (calc_pixel_width_or_height):
2420 * xfns.c (image_cache_refcount):
2421 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2422 on typical 64-bit hosts.
2423
2424 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2425 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2426 Omit unnecessary casts to int.
2427 (parse_image_spec): Check that integers fall into 'int' range
2428 when the callers expect that.
2429 (image_ascent): Redo ascent calculation to avoid int overflow.
2430 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2431 (lookup_image): Remove unnecessary tests.
2432 (xbm_image_p): Locals are now of int, not EMACS_INT,
2433 since parse_image_check makes sure they fit into int.
2434 (png_load, gif_load, svg_load_image):
2435 Prefer int to unsigned where either will do.
2436 (tiff_handler): New function, combining the cores of the
2437 old tiff_error_handler and tiff_warning_handler.
2438 This function is rewritten to use vsnprintf and thereby avoid
2439 stack buffer overflows. It uses only the features of vsnprintf
2440 that are common to both POSIX and native Microsoft.
2441 (tiff_error_handler, tiff_warning_handler): Use it.
2442 (tiff_load, gif_load, imagemagick_load_image):
2443 Don't assume :index value fits in 'int'.
2444 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2445 (imagemagick_load_image): Check that crop parameters fit into
2446 the integer types that MagickCropImage accepts. Don't assume
2447 Vimagemagick_render_type has a nonnegative value. Don't assume
2448 size_t fits in 'long'.
2449 (gs_load): Use printmax_t to print the widest integers possible.
2450 Check for integer overflow when computing image height and width.
2451
2452 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2453
2454 * xdisp.c (redisplay_window): Don't force window start if point
2455 will be invisible in the resulting window. (Bug#9324)
2456
2457 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2458
2459 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2460 the display spec is of the form `(space ...)'.
2461 (handle_display_spec): Return the value returned by
2462 handle_single_display_spec, not just 1 or zero.
2463 (handle_single_display_spec): If the display spec is of the form
2464 `(space ...)', and specifies display in the text area, return 2
2465 rather than 1.
2466 (try_cursor_movement): Check for the need to scroll more
2467 accurately, and prefer exact match for point under bidi.
2468 Don't advance `row' beyond the last row of the window.
2469
2470 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2471 into disp_prop; all users changed.
2472
2473 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2474 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2475 for the text covered by the display property.
2476
2477 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2478
2479 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2480 Change return value to nil.
2481 (Frecord_buffer): Delete unused function.
2482
2483 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2484
2485 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2486 buffers, return left-to-right.
2487 (set_cursor_from_row): Consider candidate row a win if its glyph
2488 represents a newline and point is on that newline. Fixes cursor
2489 positioning on the newline at EOL of R2L text within L2R
2490 paragraph, and vice versa.
2491 (try_cursor_movement): Check continued rows, in addition to
2492 continuation rows. Fixes unwarranted scroll when point enters a
2493 continued line of R2L text within an L2R paragraph, or vice versa.
2494 (cursor_row_p): Consider the case of point being equal to
2495 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2496 from the end of a short line to the beginning of a continued line
2497 of R2L text within L2R paragraph.
2498 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2499 composed characters.
2500
2501 * bidi.c (bidi_check_type): Use xassert.
2502 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2503 members.
2504
2505 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2506
2507 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2508 a character.
2509
2510 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2511
2512 * nsfont.m (ns_otf_to_script): Fix typo.
2513
2514 2011-08-22 Kenichi Handa <handa@m17n.org>
2515
2516 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2517 extra slot even if the purpose is char-code-property-table.
2518
2519 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2520
2521 * xdisp.c (redisplay_window): When computing centering_position,
2522 account for the height of the header line. (Bug#8874)
2523
2524 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2525 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2526 candidate is selected by the mouse, and that candidate has a
2527 composed character under the mouse.
2528
2529 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2530 coordinates reported by pos-visible-in-window-p for a composed
2531 character in column zero.
2532
2533 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2534
2535 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2536
2537 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2538
2539 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2540 consider it a hit if to_charpos is anywhere in the range of the
2541 composed buffer positions.
2542
2543 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2544
2545 * image.c (gif_load): Don't assume that each subimage has the same
2546 dimensions as the base image. Handle disposal method that is
2547 "undefined" by the gif spec (Bug#9335).
2548
2549 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2550
2551 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2552 (Fcondition_case): Document `debug' symbol in error handler.
2553
2554 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2555
2556 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2557 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2558 from an Org mode buffer to a Speedbar frame.
2559
2560 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2561 a composition, take its buffer position from IT->cmp_it.charpos.
2562 Fixes cursor positioning at the beginning of a line that begins
2563 with a composed character.
2564
2565 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2566
2567 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2568 character bidirectional type, use STRONG_L instead. Fixes crashes
2569 in a buffer produced by `describe-categories'.
2570
2571 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2572 members before the level stack, so they would be saved and
2573 restored when copying iterator state. Fixes incorrect reordering
2574 around TABs covered by display properties.
2575
2576 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2577
2578 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2579
2580 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2581
2582 * eval.c (internal_condition_case, internal_condition_case_1)
2583 (internal_condition_case_2, internal_condition_case_n):
2584 Remove unnecessary aborts (Bug#9081).
2585
2586 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2587
2588 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2589 has no `load' handler, try opening the file locally. (Bug#9311)
2590
2591 2011-08-16 Ken Brown <kbrown@cornell.edu>
2592
2593 * gmalloc.c: Expand comment.
2594
2595 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2596
2597 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2598 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2599
2600 2011-08-16 Ken Brown <kbrown@cornell.edu>
2601
2602 Fix memory allocation problems in Cygwin build (Bug#9273).
2603
2604 * unexcw.c ( __malloc_initialized): Declare external variable.
2605 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2606
2607 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2608 New variables.
2609 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2610 dumped emacs.
2611 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2612 in the static heap.
2613 [CYGWIN] (special_realloc): New function.
2614 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2615 requests to realloc storage in the static heap.
2616
2617 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2618
2619 * bidi.c (bidi_initialize): Remove unused local.
2620
2621 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2622
2623 * bidimirror.h:
2624 * biditype.h: Remove file.
2625 * makefile.w32-in ($(BLD)/bidi.$(O)):
2626 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2627
2628 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2629
2630 * chartab.c: Improve commentary for the uniprop_table API.
2631
2632 * bidi.c (bidi_paragraph_init): Support zero value of
2633 bidi_ignore_explicit_marks_for_paragraph_level.
2634 (bidi_initialize): Use uniprop_table instead of including
2635 biditype.h and bidimirror.h.
2636
2637 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2638 coordinates of the iterator when restoring from ppos_it.
2639 (Bug#9296)
2640
2641 2011-08-14 Kenichi Handa <handa@m17n.org>
2642
2643 * process.c (create_process): Call setup_process_coding_systems
2644 after the pid of the process is set to -1 (Bug#8162).
2645
2646 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2647
2648 * xdisp.c (move_it_in_display_line_to): Don't invoke
2649 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2650 ppos_it. Fixes vertical cursor motion when line beginning is
2651 covered by an image. (Bug#9296)
2652
2653 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2654
2655 * nsterm.h (ns_run_ascript): Declare.
2656 (NSAPP_DATA2_RUNASSCRIPT): Define.
2657
2658 * nsfns.m (as_script, as_result, as_status): New static variables.
2659 (ns_run_ascript): New function.
2660 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2661 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2662 the event loop. Get status from as_status (Bug#7276).
2663
2664 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2665 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2666 the event loop (Bug#7276).
2667
2668 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2669
2670 * gnutls.c (QCgnutls_bootprop_priority)
2671 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2672 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2673 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2674 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2675 (QCgnutls_bootprop_verify_hostname_error)
2676 (QCgnutls_bootprop_callbacks_verify): Rename from
2677 Qgnutls_bootprop_..., all uses changed.
2678
2679 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2680 uses changed.
2681
2682 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2683
2684 * xfaces.c (Qframe_set_background_mode): Now static.
2685 * dispextern.h (Qframe_set_background_mode): Remove decl.
2686
2687 * process.c (Fnetwork_interface_info): Declare local only if needed.
2688
2689 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2690
2691 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2692 (Fnetwork_interface_list): Allocate in increments of bytes instead
2693 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2694 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2695 sockaddr.
2696 (struct ifflag_def): notrailers is smart on OSX.
2697 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2698 Get hardware address with getifaddrs if available.
2699
2700 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2701
2702 * xdisp.c (iterate_out_of_display_property): xassert that
2703 IT->position is set to within IT->object's boundaries. Break from
2704 the loop as soon as EOB is reached; avoids infloops in redisplay
2705 when IT->position is set up wrongly due to some bug.
2706 Set IT->current to match the bidi iterator unconditionally.
2707 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2708 entry. Force push_it to save on the stack the current
2709 buffer/string position, to be restored by pop_it. Fix flags in
2710 the iterator structure wrt the object coming from a display
2711 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2712 properties. (Bug#9284)
2713
2714 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2715
2716 * fontset.c (fontset_get_font_group): Add proper type checks.
2717 (Bug#9172)
2718
2719 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2720
2721 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2722 and LC_VERSION_MIN_MACOSX.
2723 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2724 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2725
2726 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2727
2728 * xdisp.c (forward_to_next_line_start): Allow to use the
2729 no-display-properties-and-no-overlays under bidi display.
2730 Set disp_pos in the bidi iterator to avoid searches for display
2731 properties and overlays.
2732
2733 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2734
2735 * editfns.c (Fset_time_zone_rule): Document relationship with the
2736 setenv function.
2737
2738 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2739 the font entity extracted from the cache (Bug#8109).
2740
2741 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2742
2743 * composite.c (autocmp_chars): Don't reset point. That is done by
2744 restore_point_unwind (Bug#5984).
2745
2746 2011-08-07 Juri Linkov <juri@jurta.org>
2747
2748 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2749 to show the arg `TIME' instead of `TIMEVAL'.
2750
2751 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2752
2753 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2754 display property strides EOL and includes a newline, as in
2755 longlines-mode. (Bug#9254)
2756 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2757 word-wrap under bidirectional display. (Bug#9224)
2758
2759 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2760 is non-zero, even if the data buffer is NULL. Fixes a crash in
2761 vertical-motion with longlines-mode. (Bug#9254)
2762
2763 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2764
2765 * bidi.c <bidi_cache_total_alloc>: Now static.
2766 (bidi_initialize): Initialize bidi_cache_total_alloc.
2767
2768 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2769 cache. (Bug#9221)
2770
2771 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2772 amount allocated this far in `bidi_cache_total_alloc'.
2773 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2774 non-zero, only free the data buffer without restoring the cache
2775 contents. All callers changed.
2776
2777 * dispextern.h (bidi_unshelve_cache): Update prototype.
2778
2779 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2780 (move_it_in_display_line, move_it_to)
2781 (move_it_vertically_backward, move_it_by_lines): Replace the call
2782 to xfree to an equivalent call to bidi_unshelve_cache.
2783 (move_it_in_display_line_to): Fix logic of returning
2784 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2785
2786 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2787
2788 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2789 came from a string character with a `cursor' property. (Bug#9229)
2790
2791 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2792
2793 * Makefile.in (LIB_PTHREAD): New variable.
2794 (LIBES): Add LIB_PTHREAD (Bug#9216).
2795
2796 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2797 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2798
2799 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2800
2801 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2802
2803 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2804
2805 * xterm.c (x_find_topmost_parent): New function.
2806 (x_set_frame_alpha): Find topmost parent window with
2807 x_find_topmost_parent and set the property there also (bug#9181).
2808 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2809
2810 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2811
2812 * callproc.c (Fcall_process): Avoid vfork clobbering
2813 the local vars buffer, coding_systems, current_dir.
2814
2815 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2816
2817 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2818
2819 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2820
2821 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2822 so that it is not optimized away.
2823
2824 * xdisp.c (compute_display_string_pos): Remove unused local.
2825
2826 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2827
2828 Fix slow cursor motion and scrolling in large buffers with
2829 selective display, like Org Mode buffers. (Bug#9218)
2830
2831 * dispextern.h (struct bidi_it): New member disp_prop_p.
2832
2833 * xdisp.c: Remove one-slot cache of display string positions.
2834 (compute_display_string_pos): Accept an additional argument
2835 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2836 for a display string or property. If found, set DISP_PROP_P
2837 non-zero.
2838
2839 * bidi.c (bidi_fetch_char): Accept an additional argument
2840 DISP_PROP_P, and pass it to compute_display_string_pos.
2841 Only handle text covered by a display string if DISP_PROP_P is returned
2842 non-zero. All callers of bidi_fetch_char changed.
2843
2844 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2845
2846 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2847
2848 2010-12-03 Don March <don@ohspite.net>
2849
2850 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2851 last character M-[char] is translated to ESC [char] (bug#7541).
2852
2853 2011-08-02 Kenichi Handa <handa@m17n.org>
2854
2855 * lisp.h (uniprop_table): Extern it.
2856
2857 * chartab.c (uniprop_table): Make it non-static.
2858
2859 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2860
2861 * xdisp.c (forward_to_next_line_start): Accept additional argument
2862 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2863 on the newline.
2864 (reseat_at_next_visible_line_start): Use the bidi iterator state
2865 returned by forward_to_next_line_start to restore the state of
2866 it->bidi_it after backing up to previous newline. (Bug#9212)
2867
2868 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2869
2870 * regex.c (re_comp): Protoize.
2871 (re_exec): Fix return type.
2872 (regexec): Fix type of `ret'. (Bug#9203)
2873
2874 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2875
2876 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2877 This is needed if max-image-size is a floating-point number.
2878
2879 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2880
2881 * print.c (print_object): Print empty symbol as ##.
2882
2883 * lread.c (read1): Read ## as empty symbol.
2884
2885 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2886
2887 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2888 setting frame foreground color (Bug#9175).
2889 (x_set_background_color): Likewise.
2890
2891 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2892 contents (Bug#9176).
2893 (EmacsTooltip -init): Remove bezels and add shadows to
2894 tooltip windows.
2895
2896 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2897 or scroll bar (Bug#8470).
2898
2899 * nsfont.m (nsfont_open): Remove assignment to voffset and
2900 unnecessary vars hshink, expand, hd, full_height, min_height.
2901 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2902
2903 * nsterm.h (nsfont_info): Remove voffset field.
2904
2905 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2906
2907 Implement strike-through and overline on NextStep (Bug#8863).
2908
2909 * nsfont.m (nsfont_open): Use underline position provided by font,
2910 instead of hard-coded value of 2.
2911 (nsfont_draw): Call ns_draw_text_decoration instead.
2912
2913 * nsterm.h: Add declaration for ns_draw_text_decoration.
2914
2915 * nsterm.m (ns_draw_text_decoration): New function for drawing
2916 underline, overline, and strike-through.
2917 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2918 ns_draw_text_decoration. Change treatment of cursor drawing to
2919 accommodate underlining, etc.
2920
2921 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2922
2923 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2924 default.
2925
2926 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2927
2928 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2929 Without this fix, if a signal arrives just after memory fills up,
2930 'malloc' might be invoked reentrantly.
2931
2932 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2933 In other words, assume that every image size is allowed, on non-X
2934 hosts. This assumption is probably wrong, but it lets Emacs compile.
2935
2936 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2937
2938 * regex.c (re_iswctype): Convert return values to boolean.
2939
2940 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2941
2942 * xdisp.c (compute_display_string_pos): Don't use cached display
2943 string position if the buffer had its restriction changed.
2944 (Bug#9184)
2945
2946 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2947
2948 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2949
2950 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2951
2952 Integer signedness and overflow and related fixes. (Bug#9079)
2953
2954 * bidi.c: Integer size and overflow fixes.
2955 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2956 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2957 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2958 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2959 (bidi_find_other_level_edge):
2960 Use ptrdiff_t instead of EMACS_INT where either will do.
2961 This works better on 32-bit hosts configured --with-wide-int.
2962 (bidi_cache_ensure_space): Check for size-calculation overflow.
2963 Use % rather than repeated addition, for better worst-case speed.
2964 Don't set bidi_cache_size until after xrealloc returns, because it
2965 might not return.
2966 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2967 (bidi_cache_ensure_space): Also check that the bidi cache size
2968 does not exceed that of the largest Lisp string or buffer. See Eli
2969 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2970
2971 * alloc.c (__malloc_size_t): Remove.
2972 All uses replaced by size_t. See Andreas Schwab's note
2973 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2974
2975 * image.c: Improve checking for integer overflow.
2976 (check_image_size): Assume that f is nonnull, since
2977 it is always nonnull in practice. This is one less thing to
2978 worry about when checking for integer overflow later.
2979 (x_check_image_size): New function, which checks for integer
2980 overflow issues inside X.
2981 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2982 This removes the need for a memory_full check.
2983 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2984 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2985 (xbm_read_bitmap_data): Change locals back to 'int', since
2986 their values must fit in 'int'.
2987 (xpm_load_image, png_load, tiff_load):
2988 Invoke x_create_x_image_and_pixmap earlier,
2989 to avoid much needless work if the image is too large.
2990 (tiff_load): Treat overly large images as if
2991 x_create_x_image_and_pixmap failed, not as malloc failures.
2992 (gs_load): Use x_check_image_size.
2993
2994 * gtkutil.c: Omit integer casts.
2995 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2996 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2997
2998 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2999
3000 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3001 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3002 would wrongly return t on a 64-bit host.
3003
3004 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3005 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3006 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3007 and therefore cause GCC to emit a bogus diagnostic in some cases.
3008
3009 * image.c: Integer signedness and overflow and related fixes.
3010 This is not an exhaustive set of fixes, but it's time to
3011 record what I've got.
3012 (lookup_pixel_color, check_image_size): Remove redundant decls.
3013 (check_image_size): Don't assume that arbitrary EMACS_INT values
3014 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3015 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3016 (tiff_load, imagemagick_load_image):
3017 Check for overflow in size calculations.
3018 (x_create_x_image_and_pixmap): Remove unnecessary test for
3019 xmalloc returning NULL; that can't happen.
3020 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3021 (xpm_color_bucket): Use better integer hashing function.
3022 (xpm_cache_color): Don't possibly over-allocate memory.
3023 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3024 (gif_memory_source):
3025 Use ptrdiff_t, not int or size_t, to record sizes.
3026 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3027 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3028 either works, as we prefer signed integers.
3029 (tiff_read_from_memory, tiff_write_from_memory):
3030 Return tsize_t, not size_t, since that's what the TIFF API wants.
3031 (tiff_read_from_memory): Don't fail simply because the read would
3032 go past EOF; instead, return a short read.
3033 (tiff_load): Omit no-longer-needed casts.
3034 (Fimagemagick_types): Don't assume size fits into 'int'.
3035
3036 Improve hashing quality when configured --with-wide-int.
3037 * fns.c (hash_string): New function, taken from sxhash_string.
3038 Do not discard information about ASCII character case; this
3039 discarding is no longer needed.
3040 (sxhash-string): Use it. Change sig to match it. Caller changed.
3041 * lisp.h: Declare it.
3042 * lread.c (hash_string): Remove, since we now use fns.c's version.
3043 The fns.c version returns a wider integer if --with-wide-int is
3044 specified, so this should help the quality of the hashing a bit.
3045
3046 * emacs.c: Integer overflow minor fix.
3047 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3048 Define only if GNU_LINUX.
3049 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3050
3051 * dispnew.c: Integer signedness and overflow fixes.
3052 Remove unnecessary forward decls, that were a maintenance hassle.
3053 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3054 All uses changed.
3055 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3056 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3057 (prepare_desired_row, line_draw_cost):
3058 Use int, not unsigned, where either works.
3059 (save_current_matrix, restore_current_matrix):
3060 Use ptrdiff_t, not size_t, where either works.
3061 (init_display): Check for overflow more accurately, and without
3062 relying on undefined behavior.
3063
3064 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3065 Remove, replacing with the new symbols in lisp.h. All uses changed.
3066 * fileio.c (make_temp_name):
3067 * filelock.c (lock_file_1, lock_file):
3068 * xdisp.c (message_dolog):
3069 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3070 Use pMd etc. instead.
3071 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3072 replacing the pWIDE etc. symbols removed from editfns.c.
3073
3074 * keyboard.h (num_input_events): Now uintmax_t.
3075 This is (very slightly) less likely to mess up due to wraparound.
3076 All uses changed.
3077
3078 * buffer.c: Integer signedness fixes.
3079 (alloc_buffer_text, enlarge_buffer_text):
3080 Use ptrdiff_t rather than size_t when either will do, as we prefer
3081 signed integers.
3082
3083 * alloc.c: Integer signedness and overflow fixes.
3084 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3085 (__malloc_size_t): Default to size_t, not to int.
3086 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3087 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3088 Prefer ptrdiff_t to size_t when either would do, as we prefer
3089 signed integers.
3090 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3091 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3092 Now const. Initialize with values that are in range even if char
3093 is signed.
3094 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3095 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3096 These functions do the right thing with sizes > 2**32.
3097 (check_depth): Now ptrdiff_t, not int.
3098 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3099 Adjust to new way of storing sizes. Check for size overflow bugs
3100 in rest of code.
3101 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3102 slightly wrong anyway, as it missed one instance of
3103 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3104 (refill_memory_reserve): Omit needless cast to size_t.
3105 (mark_object_loop_halt): Mark as externally visible.
3106
3107 * xselect.c: Integer signedness and overflow fixes.
3108 (Fx_register_dnd_atom, x_handle_dnd_message):
3109 Use ptrdiff_t, not size_t, since we prefer signed.
3110 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3111 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3112 x_dnd_atoms_size and x_dnd_atoms_length.
3113
3114 * doprnt.c: Prefer signed to unsigned when either works.
3115 * eval.c (verror):
3116 * doprnt.c (doprnt):
3117 * lisp.h (doprnt):
3118 * xdisp.c (vmessage):
3119 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3120 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3121 prefer signed arithmetic to avoid comparison confusion.
3122 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3123 but is a bit tricky.
3124
3125 Assume freestanding C89 headers, string.h, stdlib.h.
3126 * data.c, doprnt.c, floatfns.c, print.c:
3127 Include float.h unconditionally.
3128 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3129 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3130 * regex.c: Likewise for stddef.h, string.h.
3131 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3132 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3133 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3134 (STDC_HEADERS): Remove obsolete defines.
3135 * sysdep.c: Include limits.h unconditionally.
3136
3137 Assume support for memcmp, memcpy, memmove, memset.
3138 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3139 * regex.c (memcmp, memcpy):
3140 Remove; we assume C89 now.
3141
3142 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3143 (__malloc_safe_bcopy): Remove; no longer needed.
3144
3145 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3146 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3147 well either way, and we prefer signed to unsigned.
3148
3149 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3150
3151 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3152 closes the connection while we're reading (bug#9182).
3153
3154 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3155
3156 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3157 are specified (Bug#9168).
3158
3159 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3160
3161 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3162 Found by GCC static checking and --with-wide-int on a 32-bit host.
3163
3164 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3165
3166 * xdisp.c (compute_display_string_pos): Fix logic of caching
3167 previous display string position. Initialize cached_prev_pos to
3168 -1. Fixes slow-down at the beginning of a buffer.
3169
3170 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3171
3172 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3173 for attrs[LFACE_FONTSET_INDEX].
3174
3175 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3176
3177 * xml.c (parse_region): Remove unused local
3178 that was recently introduced.
3179
3180 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3181
3182 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3183 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3184
3185 * xdisp.c (move_it_in_display_line_to): Record the best matching
3186 position for TO_CHARPOS while scanning the line, and restore it on
3187 exit if none of the characters scanned was an exact match.
3188 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3189 when exact match is impossible due to invisible text, and the
3190 lines are truncated.
3191
3192 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3193
3194 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3195 for OSX >= 10.7.
3196
3197 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3198
3199 Fix a significant slow-down of cursor motion with C-n, C-p,
3200 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3201 auto-repeat under bidi redisplay in fontified buffers.
3202 * xdisp.c (compute_stop_pos_backwards): New function.
3203 (next_element_from_buffer): Call compute_stop_pos_backwards to
3204 find a suitable prev_stop when we find ourselves before
3205 base_level_stop.
3206 (reseat): Don't look for prev_stop, as that could mean a very long
3207 run.
3208 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3209 <cached_disp_overlay_modiff>: Cache for last found display string
3210 position.
3211 (compute_display_string_pos): Return the cached position if asked
3212 about the same buffer in the same area of character positions, and
3213 the buffer wasn't changed since the time the display string
3214 position was cached.
3215
3216 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3217
3218 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3219 is an integer, which is important for empty lines. (Bug#9149)
3220
3221 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3222
3223 * frame.c (Fmodify_frame_parameters): In tty case, update the
3224 default face if necessary (Bug#4238).
3225
3226 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3227
3228 * editfns.c (Fstring_to_char): No need to explain what a character
3229 is in the docstring (Bug#6576).
3230
3231 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3232
3233 * xml.c (parse_region): Make sure we always return a tree.
3234
3235 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3236
3237 * xml.c (parse_region): If a document contains only comments,
3238 return that, too.
3239
3240 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3241
3242 * xml.c (make_dom): Return comments, too.
3243
3244 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3245
3246 Port to OpenBSD.
3247 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3248 and the surrounding thread.
3249 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3250 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3251 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3252 timer goes off.
3253 * s/openbsd.h (BROKEN_SIGIO): Define.
3254 * unexelf.c (unexec) [__OpenBSD__]:
3255 Don't update the .mdebug section of the Alpha COFF symbol table.
3256
3257 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3258
3259 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3260 (bug#8460).
3261
3262 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3263
3264 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3265 This fixes some race conditions on the permissions of any newly
3266 created file.
3267
3268 * alloc.c (valid_pointer_p): Use pipe, not open.
3269 This fixes some permissions issues when debugging.
3270
3271 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3272 If fchown fails to set both uid and gid, try to set just gid,
3273 as that is sometimes allowed. Adjust the file's mode to eliminate
3274 setuid or setgid bits that are inappropriate if fchown fails.
3275
3276 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3277
3278 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3279 to compare Lisp_Objects.
3280 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3281 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3282 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3283
3284 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3285
3286 * lread.c (read_integer): Unread even EOF character.
3287 (read1): Likewise. Properly record start position of symbol.
3288
3289 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3290 symbol character follows.
3291
3292 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3293
3294 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3295 This works around a problem with the previous change to Fcopy_file.
3296 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3297 and without this change, GCC might complain about discarding
3298 fchown's return value.
3299
3300 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3301
3302 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3303
3304 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3305
3306 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3307
3308 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3309
3310 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3311 it's used from the C level.
3312
3313 * process.c: Use the same condition for POLL_FOR_INPUT in both
3314 keyboard.c and process.c (bug#1858).
3315
3316 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3317
3318 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3319 (Fgnutls_boot): Use it.
3320
3321 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3322
3323 * doc.c (Fsubstitute_command_keys): Revert last change.
3324
3325 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3326
3327 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3328 quotes the next character, and doesn't affect other longer
3329 sequences (bug#8935).
3330
3331 * lread.c (syms_of_lread): Clarify that is isn't only
3332 `eval-buffer' and `eval-defun' that's affected by
3333 `lexical-binding' (bug#8460).
3334
3335 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3336
3337 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3338 bidi redisplay when a line includes both an image and is truncated.
3339
3340 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3341
3342 Fix minor problems found by static checking.
3343 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3344 (elsz): Now a signed constant, not a size_t var. We prefer signed
3345 types to unsigned, to avoid integer comparison confusion. Without
3346 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3347 "cannot optimize loop, the loop counter may overflow", a symptom
3348 of the confusion.
3349 * indent.c (Fvertical_motion): Mark locals as initialized.
3350 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3351
3352 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3353
3354 * search.c (Fre_search_backward): Mention `case-fold-search' in
3355 all the re_search_* functions (bug#8138).
3356
3357 * keyboard.c (Fopen_dribble_file): Document when the file is
3358 closed (bug#8056).
3359
3360 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3361
3362 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3363 bidi_cache_idx.
3364
3365 Support bidi reordering of display and overlay strings.
3366 * xdisp.c (compute_display_string_pos)
3367 (compute_display_string_end): Accept additional argument STRING.
3368 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3369 (reseat_to_string): Initialize bidi_it->string.s and
3370 bidi_it->string.schars.
3371 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3372 NULL (avoids a crash in bidi_paragraph_init).
3373 Initialize itb.string.lstring.
3374 (init_iterator): Call bidi_init_it only of a valid
3375 buffer position was specified. Initialize paragraph_embedding to
3376 L2R.
3377 (reseat_to_string): Initialize the bidi iterator.
3378 (display_string): If we need to ignore text properties of
3379 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3380 original value of -1 will not work with bidi.)
3381 (compute_display_string_pos): First arg is now struct
3382 `text_pos *'; all callers changed. Support display properties on
3383 Lisp strings.
3384 (compute_display_string_end): Support display properties on Lisp
3385 strings.
3386 (init_iterator, reseat_1, reseat_to_string): Initialize the
3387 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3388 when iterating on a string not from display properties).
3389 (compute_display_string_pos, compute_display_string_end):
3390 Fix calculation of the object to scan. Fixes an error when using
3391 arrow keys.
3392 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3393 base_level_stop; instead, set base_level_stop to BEGV.
3394 Fixes crashes in vertical-motion.
3395 (next_element_from_buffer): Improve commentary for when
3396 the iterator is before prev_stop.
3397 (init_iterator): Initialize bidi_p from the default value of
3398 bidi-display-reordering, not from buffer-local value. Use the
3399 buffer-local value only if initializing for buffer iteration.
3400 (handle_invisible_prop): Support invisible properties on strings
3401 that are being bidi-reordered.
3402 (set_iterator_to_next): Support bidi reordering of C strings and
3403 Lisp strings.
3404 (next_element_from_string): Support bidi reordering of Lisp
3405 strings.
3406 (handle_stop_backwards): Support Lisp strings as well.
3407 (display_string): Support display of R2L glyph rows.
3408 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3409 (init_iterator): Don't initialize it->bidi_p for strings
3410 here.
3411 (reseat_to_string): Initialize it->bidi_p for strings here.
3412 (next_element_from_string, next_element_from_c_string)
3413 (next_element_from_buffer): Add xassert's for correspondence
3414 between IT's object being iterated and it->bidi_it.string
3415 structure.
3416 (face_before_or_after_it_pos): Support bidi iteration.
3417 (next_element_from_c_string): Handle the case of the first string
3418 character that is not the first one in the visual order.
3419 (get_visually_first_element): New function, refactored from common
3420 parts of next_element_from_buffer, next_element_from_string, and
3421 next_element_from_c_string.
3422 (tool_bar_lines_needed, redisplay_tool_bar)
3423 (display_menu_bar): Force left-to-right direction. Add a FIXME
3424 comment for making that be controlled by a user option.
3425 (push_it, pop_it): Save and restore the state of the
3426 bidi iterator. Save and restore the bidi_p flag.
3427 (pop_it): Iterate out of display property for string iteration as
3428 well.
3429 (iterate_out_of_display_property): Support iteration over strings.
3430 (handle_single_display_spec): Set up it->bidi_it for iteration
3431 over a display string, and call bidi_init_it.
3432 (handle_single_display_spec, next_overlay_string)
3433 (get_overlay_strings_1, push_display_prop): Set up the bidi
3434 iterator for displaying display or overlay strings.
3435 (forward_to_next_line_start): Don't use the shortcut if
3436 bidi-iterating.
3437 (back_to_previous_visible_line_start): If handle_display_prop
3438 pushed the iterator stack, restore the internal state of the bidi
3439 iterator by calling bidi_pop_it same number of times.
3440 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3441 and we are bidi-iterating, don't decrement the iterator position;
3442 instead, set the first_elt flag in the bidi iterator, to produce
3443 the same effect.
3444 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3445 (push_display_prop): xassert that we are iterating a buffer.
3446 (push_it, pop_it): Save and restore paragraph_embedding member.
3447 (handle_single_display_spec, next_overlay_string)
3448 (get_overlay_strings_1, reseat_1, reseat_to_string)
3449 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3450 correctly. Don't assume unibyte strings are not bidi-reordered.
3451 (compute_display_string_pos)
3452 (compute_display_string_end): Fix handling the case of C string.
3453 (push_it, pop_it): Save and restore from_disp_prop_p.
3454 (handle_single_display_spec, push_display_prop): Set the
3455 from_disp_prop_p flag.
3456 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3457 (pop_it): Call iterate_out_of_display_property only if we are
3458 popping after iteration over a string that came from a display
3459 property. Fix a typo in popping stretch info. Add an assertion
3460 for verifying that the iterator position is in sync with the bidi
3461 iterator.
3462 (handle_single_display_spec, get_overlay_strings_1)
3463 (push_display_prop): Fix initialization of paragraph direction for
3464 string when that of the parent object is not yet determined.
3465 (reseat_1): Call bidi_init_it to resync the bidi
3466 iterator with IT's position. (Bug#7616)
3467 (find_row_edges): If ROW->start.pos gives position
3468 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3469 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3470 Reset the from_disp_prop_p flag.
3471 (SAVE_IT, RESTORE_IT): New macros.
3472 (pos_visible_p, face_before_or_after_it_pos)
3473 (back_to_previous_visible_line_start)
3474 (move_it_in_display_line_to, move_it_in_display_line)
3475 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3476 (try_scrolling, redisplay_window, display_line): Use them when
3477 saving a temporary copy of the iterator and restoring it back.
3478 (back_to_previous_visible_line_start, reseat_1)
3479 (init_iterator): Empty the bidi cache "stack".
3480 (move_it_in_display_line_to): If iterator ended up at
3481 EOL, but we never saw any buffer positions smaller than
3482 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3483 motion in bidi-reordered lines.
3484 (move_it_in_display_line_to): Record prev_method and prev_pos
3485 immediately before the call to set_iterator_to_next. Fixes cursor
3486 motion in bidi-reordered lines with stretch glyphs and strings
3487 displayed in margins. (Bug#8133) (Bug#8867)
3488 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3489 TO_CHARPOS.
3490 (pos_visible_p): Support positions in bidi-reordered lines.
3491 Save and restore bidi cache.
3492
3493 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3494 (bidi_paragraph_info): Delete unused struct.
3495 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3496 (bidi_cache_start): New variable.
3497 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3498 to zero.
3499 (bidi_cache_fetch_state, bidi_cache_search)
3500 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3501 (bidi_cache_find, bidi_peek_at_next_level)
3502 (bidi_level_of_next_char, bidi_find_other_level_edge)
3503 (bidi_move_to_visually_next): Compare cache index with
3504 bidi_cache_start rather than with zero.
3505 (bidi_fetch_char): Accept new argument STRING; all callers
3506 changed. Support iteration over a string. Support strings with
3507 display properties. Support unibyte strings. Fix the type of
3508 `len' according to what STRING_CHAR_AND_LENGTH expects.
3509 (bidi_paragraph_init, bidi_resolve_explicit_1)
3510 (bidi_resolve_explicit, bidi_resolve_weak)
3511 (bidi_level_of_next_char, bidi_move_to_visually_next):
3512 Support iteration over a string.
3513 (bidi_set_sor_type, bidi_resolve_explicit_1)
3514 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3515 can now be zero (for strings); special values 0 and -1 were
3516 changed to -1 and -2, respectively.
3517 (bidi_char_at_pos): New function.
3518 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3519 Call it instead of FETCH_MULTIBYTE_CHAR.
3520 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3521 initialized to valid values.
3522 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3523 values.
3524 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3525 the test for valid cached positions. Fix the logic for looking up
3526 the sentinel state in the cache. GCPRO the Lisp string we are
3527 iterating.
3528 (bidi_push_it, bidi_pop_it): New functions.
3529 (bidi_initialize): Initialize the bidi cache start stack pointer.
3530 (bidi_cache_ensure_space): New function, refactored from part of
3531 bidi_cache_iterator_state. Don't assume the required size is just
3532 one BIDI_CACHE_CHUNK away.
3533 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3534 (bidi_count_bytes, bidi_char_at_pos): New functions.
3535 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3536 always valid if bidi_cache_idx is valid.
3537 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3538 is valid if it's going to be used.
3539 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3540 (bidi_cache_fetch_state, bidi_cache_search)
3541 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3542 (bidi_cache_iterator_state, bidi_cache_find)
3543 (bidi_find_other_level_edge, bidi_cache_start_stack):
3544 All variables related to cache indices are now EMACS_INT.
3545
3546 * dispextern.h (struct bidi_string_data): New structure.
3547 (struct bidi_it): New member `string'. Make flag members be 1-bit
3548 fields, and put them last in the struct.
3549 (compute_display_string_pos, compute_display_string_end):
3550 Update prototypes.
3551 (bidi_push_it, bidi_pop_it): Add prototypes.
3552 (struct iterator_stack_entry): New members bidi_p,
3553 paragraph_embedding, and from_disp_prop_p.
3554 (struct it): Member bidi_p is now a bit field 1 bit wide.
3555 (bidi_shelve_cache, bidi_unshelve_cache):
3556 Declare prototypes.
3557
3558 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3559 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3560 and vector-like objects.
3561
3562 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3563 cache around display iteration.
3564
3565 * window.c (Fwindow_end, window_scroll_pixel_based)
3566 (displayed_window_lines, Frecenter): Save and restore the bidi
3567 cache around display iteration.
3568
3569 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3570
3571 * editfns.c (Fdelete_region): Clarify the use of the named
3572 parameters (bug#6788).
3573
3574 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3575
3576 * indent.c (Fvertical_motion): Set and restore w->pointm when
3577 saving and restoring the window's buffer (Bug#9006).
3578
3579 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3580
3581 * editfns.c (Fstring_to_char): Clarify just what is returned
3582 (bug#6576). Text by Eli Zaretskii.
3583
3584 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3585
3586 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3587
3588 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3589
3590 * buffer.c (mmap_find): Fix a typo.
3591
3592 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3593
3594 Fix execution of x selection hooks.
3595 * xselect.c (Qx_lost_selection_functions)
3596 (Qx_sent_selection_functions): New vars.
3597 (syms_of_xselect): DEFSYM them.
3598 (x_handle_selection_request): Pass Qx_sent_selection_functions
3599 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3600 (x_handle_selection_clear,x_clear_frame_selections):
3601 Pass Qx_lost_selection_functions rather than
3602 Vx_lost_selection_functions to Frun_hook_with_args.
3603
3604 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3605
3606 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3607 The old code sometimes used this field without initializing it.
3608
3609 * alloc.c (gc_sweep): Don't read past end of array.
3610 In theory, the old code could also have corrupted Emacs internals,
3611 though it'd be very unlikely.
3612
3613 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3614
3615 * character.c (Fcharacterp): Don't advertise optional ignored
3616 argument. (Bug#4026)
3617
3618 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3619
3620 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3621 key" (bug#4257).
3622
3623 * window.c (Fset_window_start): Doc fix (bug#4199).
3624 (Fset_window_hscroll): Ditto.
3625
3626 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3627
3628 Fix minor new problems caught by GCC 4.6.1.
3629 * term.c (init_tty): Remove unused local.
3630 * xsettings.c (store_monospaced_changed): Define this function only
3631 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3632 not used otherwise.
3633
3634 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3635
3636 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3637
3638 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3639
3640 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3641 are the mini-buffer and the echo area (bug#3320).
3642
3643 * term.c (init_tty): Remove support for supdup, c10 and perq
3644 terminals, which are no longer supported (bug#1482).
3645
3646 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3647
3648 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3649
3650 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3651
3652 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3653 for non-popups (Bug#3642).
3654
3655 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3656
3657 * alloc.c (reset_malloc_hooks): Protoize.
3658 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3659 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3660 * cm.c (losecursor): Likewise.
3661 * data.c (fmod): Likewise.
3662 * dispnew.c (swap_glyphs_in_rows): Likewise.
3663 * emacs.c (memory_warning_signal): Likewise.
3664 * floatfns.c (float_error): Likewise.
3665 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3666 (otf_open, font_otf_capability, generate_otf_features)
3667 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3668 Likewise.
3669 * image.c (pbm_read_file): Likewise.
3670 * indent.c (string_display_width): Likewise.
3671 * intervals.c (check_for_interval, search_for_interval)
3672 (inc_interval_count, count_intervals, root_interval)
3673 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3674 * lread.c (defalias): Likewise.
3675 * ralloc.c (r_alloc_check): Likewise.
3676 * regex.c (set_image_of_range_1, set_image_of_range)
3677 (regex_grow_registers): Likewise.
3678 * sysdep.c (strerror): Likewise.
3679 * termcap.c (valid_filename_p, tprint, main): Likewise.
3680 * tparam.c (main): Likewise.
3681 * unexhp9k800.c (run_time_remap, save_data_space)
3682 (update_file_ptrs, read_header, write_header, calculate_checksum)
3683 (copy_file, copy_rest, display_header): Likewise.
3684 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3685 Likewise.
3686 * xdisp.c (check_it): Likewise.
3687 * xfaces.c (register_color, unregister_color, unregister_colors):
3688 Likewise.
3689 * xfns.c (print_fontset_result): Likewise.
3690 * xrdb.c (member, fatal, main): Likewise.
3691
3692 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3693
3694 Fix minor problems found by static checking (Bug#9031).
3695 * chartab.c (char_table_set_range, map_sub_char_table):
3696 Remove unused locals.
3697 (uniprop_table): Now static.
3698 * composite.c (_work_char): Remove unused static var.
3699
3700 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3701
3702 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3703
3704 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3705
3706 * gtkutil.c (qttip_cb): Remove code without function.
3707
3708 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3709
3710 * w32.c (pthread_sigmask): New stub.
3711
3712 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3713
3714 Use pthread_sigmask, not sigprocmask (Bug#9010).
3715 sigprocmask is portable only for single-threaded applications, and
3716 Emacs can be multi-threaded when it uses GTK.
3717 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3718 (LIBES): Use it.
3719 * callproc.c (Fcall_process):
3720 * process.c (create_process):
3721 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3722 Use pthread_sigmask, not sigprocmask.
3723
3724 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3725
3726 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3727 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3728 wrong (Bug#8591).
3729
3730 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3731
3732 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3733 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3734 (xg_hide_tooltip): Fix comment.
3735
3736 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3737 in registerServicesMenuSendTypes.
3738 (validRequestorForSendType): Don't check ns_return_types.
3739
3740 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3741 ns_return_type.
3742
3743 2011-07-08 Jason Rumney <jasonr@gnu.org>
3744
3745 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3746 SH_SHOW for hidden windows (Bug#5482).
3747
3748 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3749 frame struct members of non-existent frames (Bug#6284).
3750
3751 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3752
3753 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3754 variable firstTime not needed on OSX >= 10.6.
3755 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3756 >= 10.5. Use setKnobProportion, setDoubleValue.
3757
3758 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3759 (MAC_OS_X_VERSION_10_5): Define if not defined.
3760 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3761 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3762 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3763
3764 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3765 cString and lossyCString on OSX >= 10.4
3766
3767 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3768 sizeToFit on OSX >= 10.2.
3769
3770 * nsimage.m (allocInitFromFile): Don't use deprecated method
3771 bestRepresentationForDevice on OSX >= 10.6.
3772
3773 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3774 to avoid warning.
3775
3776 * emacs.c: Declare unexec_init_emacs_zone.
3777
3778 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3779
3780 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3781
3782 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3783 on svcsMenu (Bug#8842).
3784
3785 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3786 ns_return_types.
3787 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3788
3789 * nsterm.m (QUTF8_STRING): Declare.
3790 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3791 (validRequestorForSendType): Return type is (id).
3792 Change indexOfObjectIdenticalTo to indexOfObject.
3793 Check if we have local selection before returning self (Bug#8842).
3794 (writeSelectionToPasteboard): Put local selection into paste board
3795 if we have a local selection (Bug#8842).
3796 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3797
3798 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3799 (ns_get_local_selection): Declare.
3800
3801 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3802
3803 * keymap.c (describe_map_tree): Don't insert a double newline at
3804 the end of the buffer (bug#1169) and return whether we inserted
3805 something.
3806
3807 * callint.c (Fcall_interactively): Change "reading args" to
3808 "providing args" to try to clarify what it does (bug#1010).
3809
3810 2011-07-07 Kenichi Handa <handa@m17n.org>
3811
3812 * composite.c (composition_compute_stop_pos): Ignore a static
3813 composition starting before CHARPOS (Bug#8915).
3814
3815 * xdisp.c (handle_composition_prop): Likewise.
3816
3817 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3818
3819 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3820 (Bug#9015)
3821
3822 2011-07-07 Kenichi Handa <handa@m17n.org>
3823
3824 * character.h (unicode_category_t): New enum type.
3825
3826 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3827 (Qchar_code_property_table): New variable.
3828 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3829 (UNIPROP_COMPRESSED_FORM_P): New macros.
3830 (char_table_ascii): Uncompress the compressed values.
3831 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3832 Uncompress the compressed values.
3833 (sub_char_table_ref_and_range): Likewise.
3834 (char_table_ref_and_range): Uncompress the compressed values.
3835 (sub_char_table_set): New arg is_uniprop. Callers changed.
3836 Uncompress the compressed values.
3837 (sub_char_table_set_range): Args changed. Callers changed.
3838 (char_table_set_range): Adjuted for the above change.
3839 (map_sub_char_table): Delete args default_val and parent. Add arg
3840 top. Give decoded values to a Lisp function.
3841 (map_char_table): Adjust for the above change. Give decoded
3842 values to a Lisp function. Gcpro more variables.
3843 (uniprop_table_uncompress)
3844 (uniprop_decode_value_run_length): New functions.
3845 (uniprop_decoder, uniprop_decoder_count): New variables.
3846 (uniprop_get_decoder, uniprop_encode_value_character)
3847 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3848 New functions.
3849 (uniprop_encoder, uniprop_encoder_count): New variables.
3850 (uniprop_get_encoder, uniprop_table)
3851 (Funicode_property_table_internal, Fget_unicode_property_internal)
3852 (Fput_unicode_property_internal): New functions.
3853 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3854 Sunicode_property_table_internal, Sget_unicode_property_internal,
3855 and Sput_unicode_property_internal. Defvar_lisp
3856 char-code-property-alist.
3857
3858 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3859 Vunicode_category_table.
3860
3861 * font.c (font_range): Adjust for the change of
3862 Vunicode_category_table.
3863
3864 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3865
3866 * m/iris4d.h: Remove file, move contents ...
3867 * s/irix6-5.h: ... here.
3868
3869 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3870
3871 Remove unportable assumption about struct layout (Bug#8884).
3872 * alloc.c (mark_buffer):
3873 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3874 (clone_per_buffer_values): Don't assume that
3875 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3876 This isn't true in general, and it's particularly not true
3877 if Emacs is configured with --with-wide-int.
3878 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3879 New macros, used in the buffer.c change.
3880
3881 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3882
3883 * xsettings.c: Use both GConf and GSettings if both are available.
3884 (store_config_changed_event): Add comment.
3885 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3886 (store_tool_bar_style_changed): New functions.
3887 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3888 (struct xsettings): Move font inside HAVE_XFT.
3889 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3890 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3891 Move inside HAVE_XFT.
3892 (something_changed_gsettingsCB): Rename from something_changedCB.
3893 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3894 also.
3895 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3896 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3897 (something_changed_gconfCB): Rename from something_changedCB.
3898 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3899 (parse_settings): Move check for font inside HAVE_XFT.
3900 (read_settings, apply_xft_settings): Add comment.
3901 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3902 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3903 call store_font_name_changed.
3904 (xft_settings_event): Add comment.
3905 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3906 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3907 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3908 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3909 (xsettings_initialize): Call init_gsettings last.
3910 (xsettings_get_system_font, xsettings_get_system_normal_font):
3911 Add comment.
3912
3913 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3914
3915 Random fixes. E.g., (random) never returned negative values.
3916 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3917 subseconds part to the entropy, as that's a bit more random.
3918 Prefer signed to unsigned, since the signedness doesn't matter and
3919 in general we prefer signed. When given a limit, use a
3920 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3921 latter isn't right if USE_2_TAGS_FOR_INTS.
3922 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3923 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3924
3925 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3926
3927 * textprop.c (text_property_stickiness):
3928 Obey Vtext_property_default_nonsticky.
3929 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3930 * w32fns.c (syms_of_w32fns):
3931 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3932
3933 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3934
3935 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3936 This is more efficient than Ffile_directory_p and avoids a minor race.
3937
3938 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3939
3940 * buffer.c (Foverlay_put): Say what the return value is
3941 (bug#7835).
3942
3943 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3944 is a directory before asking whether to use the file name
3945 (bug#7564).
3946 (barf_or_query_if_file_exists): Make the "File is a directory"
3947 error be more correct.
3948
3949 * fns.c (Frequire): Remove the mention of the .gz files, since
3950 that's installation-specific, but keep the mention of
3951 `get-load-suffixes'.
3952
3953 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3954
3955 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3956 Report string overflow if the output is too long.
3957
3958 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3959
3960 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3961 (syms_of_gnutls): Remove duplicate DEFSYM for
3962 Qgnutls_bootprop_verify_hostname_error, an error for
3963 Qgnutls_bootprop_verify_error (which is no longer used).
3964
3965 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3966 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3967 Also (re)move comments that are misplaced or no longer relevant.
3968
3969 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3970
3971 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3972
3973 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3974
3975 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3976 and background color parameters if they have been changed.
3977
3978 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3979
3980 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3981
3982 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3983
3984 * xsettings.c (SYSTEM_FONT): Define only when used.
3985 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3986
3987 * keymap.c (access_keymap_1): Now static.
3988
3989 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3990
3991 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3992 leave any prefix arg for the up event (Bug#1586).
3993
3994 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3995
3996 * lread.c (syms_of_lread): Mention single symbols defined by
3997 `defvar' or `defconst' (bug#7154).
3998
3999 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4000 (Frequire): Mention get-load-suffixes.
4001
4002 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4003
4004 * window.h (window): Remove clone_number slot.
4005 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4006 Remove.
4007 (make_parent_window, make_window, saved_window)
4008 (Fset_window_configuration, save_window_save): Don't deal with
4009 clone numbers.
4010 * buffer.c (Qclone_number): Remove declaration.
4011 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4012
4013 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4014
4015 Add multiple inheritance to keymaps.
4016 * keymap.c (Fmake_composed_keymap): New function.
4017 (Fset_keymap_parent): Simplify.
4018 (fix_submap_inheritance): Remove.
4019 (access_keymap_1): New function extracted from access_keymap to handle
4020 embedded parents and handle lists of maps.
4021 (access_keymap): Use it.
4022 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4023 (Fcopy_keymap): Handle embedded parents.
4024 (Fcommand_remapping, define_as_prefix): Simplify.
4025 (Fkey_binding): Simplify.
4026 (syms_of_keymap): Move minibuffer-local-completion-map,
4027 minibuffer-local-filename-completion-map,
4028 minibuffer-local-must-match-map, and
4029 minibuffer-local-filename-must-match-map to Elisp.
4030 (syms_of_keymap): Defsubr make-composed-keymap.
4031 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4032 (parse_menu_item): Trivial simplification.
4033
4034 2011-07-01 Glenn Morris <rgm@gnu.org>
4035
4036 * Makefile.in (SETTINGS_LIBS): Fix typo.
4037
4038 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4039
4040 * coding.c (Fencode_coding_string): Record the last coding system
4041 used, as the function doc string says (bug#8738).
4042
4043 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4044
4045 * xsettings.c (store_monospaced_changed): Take new font as arg and
4046 check for change against current_mono_font.
4047 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4048 (emacs_settings_constructor, emacs_settings_get_property)
4049 (emacs_settings_set_property, emacs_settings_class_init)
4050 (emacs_settings_init, gsettings_obj): Remove.
4051 (something_changedCB): New function for HAVE_GSETTINGS.
4052 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4053 with value as argument.
4054 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4055 g_settings_new (Bug#8967). Do not create gsettings_obj.
4056 Remove calls to g_settings_bind. Connect something_changedCB to
4057 "changed".
4058
4059 * xgselect.c: Add defined (HAVE_GSETTINGS).
4060 (xgselect_initialize): Ditto.
4061
4062 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4063 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4064 xg_select.
4065
4066 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4067
4068 * eval.c (struct backtrace): Simplify and port the data structure.
4069 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4070 signed bit field, as this assumption is not portable and it makes
4071 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4072 "char debug_on_exit : 1" as this is not portable either; instead,
4073 use the portable "unsigned int debug_on_exit : 1". Remove unused
4074 member evalargs. Remove obsolete comments about cc bombing out.
4075
4076 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4077
4078 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4079 Let HAVE_GSETTINGS override HAVE_GCONF.
4080 (store_monospaced_changed): New function.
4081 (EMACS_SETTINGS): A new type derived from GObject to handle
4082 GSettings notifications.
4083 (emacs_settings_constructor, emacs_settings_get_property)
4084 (emacs_settings_set_property, emacs_settings_class_init):
4085 New functions.
4086 (gsettings_client, gsettings_obj): New variables.
4087 (GSETTINGS_SCHEMA): New define.
4088 (something_changedCB): Call store_monospaced_changed.
4089 (init_gsettings): New function.
4090 (xsettings_initialize): Call init_gsettings.
4091 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4092 to NULL.
4093
4094 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4095 GCONF_CFLAGS/LIBS.
4096
4097 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4098
4099 * window.c (resize_root_window, grow_mini_window)
4100 (shrink_mini_window): Rename Qresize_root_window to
4101 Qwindow_resize_root_window and Qresize_root_window_vertically to
4102 Qwindow_resize_root_window_vertically.
4103
4104 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4105
4106 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4107
4108 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4109
4110 * makefile.w32-in: Redesign dependencies so they reflect more
4111 clearly which files are directly included by each source file,
4112 and not through other includes.
4113
4114 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4115
4116 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4117 (sort_overlays, overlay_strings): When an overlay's clone number
4118 matches the window's clone number process the overlay even if
4119 the overlay's window property doesn't match the current window.
4120
4121 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4122 (Fwindow_hchild): Rename to Fwindow_left_child.
4123 (Fwindow_next): Rename to Fwindow_next_sibling.
4124 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4125 (resize_window_check): Rename to window_resize_check.
4126 (resize_window_apply): Rename to window_resize_apply.
4127 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4128 (Fdelete_other_windows_internal, resize_frame_windows)
4129 (Fsplit_window_internal, Fdelete_window_internal)
4130 (grow_mini_window, shrink_mini_window)
4131 (Fresize_mini_window_internal): Fix callers accordingly.
4132
4133 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4134
4135 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4136 (emacs_fixed_set_min_size): Remove.
4137 (emacs_fixed_new): Take frame as argument.
4138
4139 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4140 (_EmacsFixedPrivate): Remove minwidth/height.
4141 Add struct frame *f.
4142 (emacs_fixed_init): Initialize priv->f.
4143 (get_parent_class, emacs_fixed_set_min_size): Remove.
4144 (emacs_fixed_new): Set priv->f to argument.
4145 (emacs_fixed_get_preferred_width)
4146 (emacs_fixed_get_preferred_height): Use min_width/height from
4147 frames size_hint to set minimum and natural (Bug#8919).
4148 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4149 and use min_width/height from frames size_hint to set
4150 min_width/height (Bug#8919).
4151
4152 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4153 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4154 Fix indentation.
4155
4156 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4157
4158 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4159 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4160 called at ZV.
4161
4162 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4163
4164 * process.c (wait_reading_process_output): Bypass select if
4165 waiting for a cell while ignoring keyboard input, and input is
4166 pending. Suggested by Jan Djärv (Bug#8869).
4167
4168 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4169
4170 Use gnulib's dup2 module instead of rolling our own.
4171 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4172
4173 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4174
4175 * dispnew.c (scrolling_window): Before scrolling, turn off a
4176 mouse-highlight in the window being scrolled.
4177
4178 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4179
4180 Move DEFSYM to lisp.h and use everywhere.
4181
4182 * character.h (DEFSYM): Move declaration...
4183 * lisp.h (DEFSYM): ...here.
4184
4185 * gnutls.c:
4186 * minibuf.c:
4187 * w32menu.c:
4188 * w32proc.c:
4189 * w32select.c: Don't include character.h.
4190
4191 * alloc.c (syms_of_alloc):
4192 * buffer.c (syms_of_buffer):
4193 * bytecode.c (syms_of_bytecode):
4194 * callint.c (syms_of_callint):
4195 * casefiddle.c (syms_of_casefiddle):
4196 * casetab.c (init_casetab_once):
4197 * category.c (init_category_once, syms_of_category):
4198 * ccl.c (syms_of_ccl):
4199 * cmds.c (syms_of_cmds):
4200 * composite.c (syms_of_composite):
4201 * dbusbind.c (syms_of_dbusbind):
4202 * dired.c (syms_of_dired):
4203 * dispnew.c (syms_of_display):
4204 * doc.c (syms_of_doc):
4205 * editfns.c (syms_of_editfns):
4206 * emacs.c (syms_of_emacs):
4207 * eval.c (syms_of_eval):
4208 * fileio.c (syms_of_fileio):
4209 * fns.c (syms_of_fns):
4210 * frame.c (syms_of_frame):
4211 * fringe.c (syms_of_fringe):
4212 * insdel.c (syms_of_insdel):
4213 * keymap.c (syms_of_keymap):
4214 * lread.c (init_obarray, syms_of_lread):
4215 * macros.c (syms_of_macros):
4216 * msdos.c (syms_of_msdos):
4217 * print.c (syms_of_print):
4218 * process.c (syms_of_process):
4219 * search.c (syms_of_search):
4220 * sound.c (syms_of_sound):
4221 * syntax.c (init_syntax_once, syms_of_syntax):
4222 * terminal.c (syms_of_terminal):
4223 * textprop.c (syms_of_textprop):
4224 * undo.c (syms_of_undo):
4225 * w32.c (globals_of_w32):
4226 * window.c (syms_of_window):
4227 * xdisp.c (syms_of_xdisp):
4228 * xfaces.c (syms_of_xfaces):
4229 * xfns.c (syms_of_xfns):
4230 * xmenu.c (syms_of_xmenu):
4231 * xsettings.c (syms_of_xsettings):
4232 * xterm.c (syms_of_xterm): Use DEFSYM.
4233
4234 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4235
4236 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4237
4238 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4239
4240 Integer and buffer overflow fixes (Bug#8873).
4241
4242 * print.c (printchar, strout): Check for string overflow.
4243 (PRINTPREPARE, printchar, strout):
4244 Don't set size unless allocation succeeds.
4245
4246 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4247 for sizes. Check for string overflow more accurately.
4248 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4249
4250 * macros.c: Integer and buffer overflow fixes.
4251 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4252 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4253 Use ptrdiff_t, not int, for sizes.
4254 Don't increment bufsize until after realloc succeeds.
4255 Check for size-calculation overflow.
4256 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4257
4258 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4259
4260 * lread.c: Integer overflow fixes.
4261 (read_integer): Radix is now EMACS_INT, not int,
4262 to improve quality of diagnostics for out-of-range radices.
4263 Calculate buffer size correctly for out-of-range radices.
4264 (read1): Check for integer overflow in radices, and in
4265 read-circle numbers.
4266 (read_escape): Avoid int overflow.
4267 (Fload, openp, read_buffer_size, read1)
4268 (substitute_object_recurse, read_vector, read_list, map_obarray):
4269 Use ptrdiff_t, not int, for sizes.
4270 (read1): Use EMACS_INT, not int, for sizes.
4271 Check for size overflow.
4272
4273 * image.c (cache_image): Check for size arithmetic overflow.
4274
4275 * lread.c: Integer overflow issues.
4276 (saved_doc_string_size, saved_doc_string_length)
4277 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4278 Now ptrdiff_t, not int.
4279 (read1): Don't assume doc string length fits in int. Check for
4280 out-of-range doc string lengths.
4281 (read_list): Don't assume file position fits in int.
4282 (read_escape): Check for hex character overflow.
4283
4284 2011-06-22 Leo Liu <sdl.web@gmail.com>
4285
4286 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4287 Move to minibuffer.el.
4288
4289 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4290
4291 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4292 The following patches are for when GLYPH_DEBUG && !XASSERT.
4293 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4294 * dispnew.c (flush_stdout):
4295 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4296 Mark as externally visible.
4297 * dispnew.c (check_window_matrix_pointers): Now static.
4298 * dispnew.c (window_to_frame_vpos):
4299 * xfns.c (unwind_create_frame):
4300 * xterm.c (x_check_font): Remove unused local.
4301 * scroll.c (CHECK_BOUNDS):
4302 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4303 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4304 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4305 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4306 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4307 Now static.
4308 (debug_method_add): Use va_list and vsprintf rather than relying
4309 on undefined behavior with wrong number of arguments.
4310 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4311 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4312 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4313 since we're not interested in debugging glyphs with old libraries.
4314 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4315 GCC 4.6.0's static checking.
4316
4317 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4318
4319 Integer overflow and signedness fixes (Bug#8873).
4320 A few related buffer overrun fixes, too.
4321
4322 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4323
4324 * dispextern.h (struct face.stipple):
4325 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4326 (x_bitmap_mask, x_allocate_bitmap_record)
4327 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4328 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4329 (x_create_bitmap_from_xpm_data):
4330 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4331 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4332 (.bitmaps_last):
4333 * xfaces.c (load_pixmap):
4334 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4335 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4336 (.bitmaps_last, struct x_output.icon_bitmap):
4337 Use ptrdiff_t, not int, for bitmap indexes.
4338 (x_allocate_bitmap_record): Check for size overflow.
4339 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4340
4341 Use ptrdiff_t, not int, for overlay counts.
4342 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4343 * editfns.c (overlays_around, get_pos_property):
4344 * textprop.c (get_char_property_and_overlay):
4345 * xdisp.c (next_overlay_change, note_mouse_highlight):
4346 * xfaces.c (face_at_buffer_position):
4347 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4348 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4349 (Fnext_overlay_change, Fprevious_overlay_change)
4350 (mouse_face_overlay_overlaps, Foverlays_in):
4351 Use ptrdiff_t, not int, for sizes.
4352 (overlays_at, overlays_in): Check for size-calculation overflow.
4353
4354 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4355
4356 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4357 (x_session_initialize): Do not assume string length fits in int.
4358
4359 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4360 This is unlikely, but can occur if DPI is outlandish.
4361
4362 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4363 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4364
4365 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4366 * xrdb.c (magic_file_p, search_magic_path):
4367 Omit last arg SUFFIX; it was always 0. All callers changed.
4368 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4369
4370 * xfont.c (xfont_match): Avoid need for strlen.
4371
4372 * xfns.c: Don't assume strlen fits in int.
4373 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4374
4375 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4376 not unsigned long, as we prefer signed integers. All callers changed.
4377 Detect integer overflow in repeat count.
4378 (message_dolog): Don't assume print length fits in 39 bytes.
4379 (display_mode_element): Don't assume strlen fits in int.
4380
4381 * termcap.c: Don't assume sizes fit in int and never overflow.
4382 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4383 (gobble_line): Check for size-calculation overflow.
4384
4385 * minibuf.c (Fread_buffer):
4386 * lread.c (intern, intern_c_string):
4387 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4388 Don't assume string length fits in int.
4389
4390 * keyboard.c (parse_tool_bar_item):
4391 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4392
4393 * font.c: Don't assume string length fits in int.
4394 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4395 Use ptrdiff_t, not int.
4396 (font_intern_prop): Don't assume string length fits in int.
4397 Don't assume integer property fits in fixnum.
4398 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4399
4400 * filelock.c: Fix some buffer overrun and integer overflow issues.
4401 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4402 Reformulate so as not to need the command string.
4403 Invoke gzip -cd rather than gunzip, as it's more portable.
4404 (lock_info_type, lock_file_1, lock_file):
4405 Don't assume pid_t and time_t fit in unsigned long.
4406 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4407 (current_lock_owner): Prefer signed type for sizes.
4408 Use memcpy, not strncpy, where memcpy is what is really wanted.
4409 Don't assume (via atoi) that time_t and pid_t fit in int.
4410 Check for time_t and/or pid_t out of range, e.g., via a network share.
4411 Don't alloca where an auto var works fine.
4412
4413 * fileio.c: Fix some integer overflow issues.
4414 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4415 Don't assume string length fits in int.
4416 (directory_file_name): Don't assume string length fits in long.
4417 (make_temp_name): Don't assume pid fits in int, or that its print
4418 length is less than 20.
4419
4420 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4421
4422 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4423
4424 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4425
4426 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4427 We prefer signed integers, even for size calculations.
4428
4429 * emacs.c: Don't assume string length fits in 'int'.
4430 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4431 (main): Don't invoke strlen when not needed.
4432
4433 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4434 (XD_DEBUG_MESSAGE): Don't waste a byte.
4435
4436 * callproc.c (getenv_internal_1, getenv_internal)
4437 (Fgetenv_internal):
4438 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4439
4440 * lread.c (invalid_syntax): Omit length argument.
4441 All uses changed. This doesn't fix a bug, but it simplifies the
4442 code away from its former Hollerith-constant appearance, and it's
4443 one less 'int' to worry about when looking at integer-overflow issues.
4444 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4445
4446 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4447 This didn't break anything, but it didn't help either.
4448 It's confusing to put a bogus integer in a place where the actual
4449 value does not matter.
4450 (LIST_END_P): Remove unused macro and its bogus comment.
4451 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4452
4453 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4454 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4455 implementation.
4456 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4457 We prefer signed types, and the value cannot exceed the EMACS_INT
4458 range anyway (because otherwise the length would not be representable).
4459 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4460 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4461 This avoids a GCC warning when WIDE_EMACS_INT.
4462
4463 * indent.c (sane_tab_width): New function.
4464 (current_column, scan_for_column, Findent_to, position_indentation)
4465 (compute_motion): Use it. This is just for clarity.
4466 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4467
4468 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4469
4470 * lisp.h (lint_assume): New macro.
4471 * composite.c (composition_gstring_put_cache):
4472 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4473
4474 * editfns.c, insdel.c:
4475 Omit unnecessary forward decls, to simplify future changes.
4476
4477 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4478
4479 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4480
4481 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4482 Use much-faster test for byte-length change.
4483 Don't assume string byte-length fits in 'int'.
4484 Check that character arg fits in 'int'.
4485 (mapcar1): Declare byte as byte, for clarity.
4486
4487 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4488
4489 * fns.c (concat): Catch string overflow earlier.
4490 Do not rely on integer wraparound.
4491
4492 * dispextern.h (struct it.overlay_strings_charpos)
4493 (struct it.selective): Now EMACS_INT, not int.
4494 * xdisp.c (forward_to_next_line_start)
4495 (back_to_previous_visible_line_start)
4496 (reseat_at_next_visible_line_start, next_element_from_buffer):
4497 Don't arbitrarily truncate the value of 'selective' to int.
4498
4499 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4500
4501 * composite.c: Don't truncate sizes to 'int'.
4502 (composition_gstring_p, composition_reseat_it)
4503 (composition_adjust_point): Use EMACS_INT, not int.
4504 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4505 not EMACS_UINT, for indexes.
4506
4507 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4508
4509 * buffer.c: Include <verify.h>.
4510 (struct sortvec.priority, struct sortstr.priority):
4511 Now EMACS_INT, not int.
4512 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4513 (struct sortstr.size, record_overlay_string)
4514 (struct sortstrlist.size, struct sortlist.used):
4515 Don't truncate size to int.
4516 (record_overlay_string): Check for size-calculation overflow.
4517 (init_buffer_once): Check at compile-time, not run-time.
4518
4519 2011-06-22 Jim Meyering <meyering@redhat.com>
4520
4521 Don't leak an XBM-image-sized buffer
4522 * image.c (xbm_load): Free the image buffer after using it.
4523
4524 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4525
4526 Port to Sun C.
4527 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4528 that Sun C diagnosed.
4529 * fns.c (secure_hash): Fix pointer signedness issue.
4530 * intervals.c (static_offset_intervals): New function.
4531 (offset_intervals): Use it.
4532
4533 2011-06-21 Leo Liu <sdl.web@gmail.com>
4534
4535 * deps.mk (fns.o):
4536 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4537 sha512.h.
4538
4539 * fns.c (secure_hash): Rename from crypto_hash_function and change
4540 the first arg to accept symbols.
4541 (Fsecure_hash): New primitive.
4542 (syms_of_fns): New symbols.
4543
4544 2011-06-20 Deniz Dogan <deniz@dogan.se>
4545
4546 * process.c (Fset_process_buffer): Clarify return value in
4547 docstring.
4548
4549 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4550
4551 * dispnew.c (add_window_display_history): Use BVAR.
4552
4553 * xdisp.c (debug_method_add): Use BVAR.
4554 (check_window_end, dump_glyph_matrix, dump_glyph)
4555 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4556
4557 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4558 Likewise.
4559
4560 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4561 check till after the cache is created in init_frame_faces.
4562
4563 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4564
4565 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4566
4567 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4568
4569 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4570 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4571 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4572
4573 Improve buffer-overflow checking (Bug#8873).
4574 * fileio.c (Finsert_file_contents):
4575 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4576 Remove the old (too-loose) buffer overflow checks.
4577 They weren't needed, since make_gap checks for buffer overflow.
4578 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4579 The old code merely checked for Emacs fixnum overflow, and relied
4580 on undefined (wraparound) behavior. The new code avoids undefined
4581 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4582
4583 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4584 Tune. Don't use wider integers than needed. Don't use alloca.
4585 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4586
4587 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4588
4589 * insdel.c, lisp.h (buffer_overflow): New function.
4590 (insert_from_buffer_1, replace_range, replace_range_2):
4591 * insdel.c (make_gap_larger):
4592 * editfns.c (Finsert_char):
4593 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4594
4595 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4596
4597 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4598
4599 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4600
4601 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4602 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4603
4604 * fileio.c: Don't assume EMACS_INT fits in off_t.
4605 (emacs_lseek): New static function.
4606 (Finsert_file_contents, Fwrite_region): Use it.
4607 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4608
4609 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4610
4611 * fns.c: Don't overflow int when computing a list length.
4612 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4613 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4614 truncation on 64-bit hosts. Check for QUIT every
4615 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4616 faster and is responsive enough.
4617 (Flength): Report an error instead of overflowing an integer.
4618 (Fsafe_length): Return a float if the value is not representable
4619 as a fixnum. This shouldn't happen except in contrived situations.
4620 (Fnthcdr, Fsort): Don't assume list length fits in int.
4621 (Fcopy_sequence): Don't assume vector length fits in int.
4622
4623 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4624 (header_size, word_size): New constants.
4625 (allocate_vectorlike): Don't check size overflow here.
4626 (allocate_vector): Check it here instead, since this is the only
4627 caller of allocate_vectorlike that could cause overflow.
4628 Check that the new vector's length is representable as a fixnum.
4629
4630 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4631 The previous code was bogus. For example, next_almost_prime (32)
4632 returned 39, which is undesirable as it is a multiple of 3; and
4633 next_almost_prime (24) returned 25, which is a multiple of 5 so
4634 why was the code bothering to check for multiples of 7?
4635
4636 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4637
4638 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4639
4640 Variadic C functions now count arguments with ptrdiff_t.
4641 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4642 Back then I didn't know that the Emacs coding style prefers signed int.
4643 Also, in the meantime I found a few more instances where arguments
4644 were being counted with int, which may truncate counts on 64-bit
4645 machines, or EMACS_INT, which may be unnecessarily wide.
4646 * lisp.h (struct Lisp_Subr.function.aMANY)
4647 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4648 Arg counts are now ptrdiff_t, not size_t.
4649 All variadic functions and their callers changed accordingly.
4650 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4651 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4652 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4653 * callint.c (Fcall_interactively): Check arg count for overflow,
4654 to avoid potential buffer overrun. Use signed char, not 'int',
4655 for 'varies' array, so that we needn't bother to check its size
4656 calculation for overflow.
4657 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4658 * eval.c (apply_lambda):
4659 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4660 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4661 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4662
4663 * callint.c (Fcall_interactively): Don't use index var as event count.
4664
4665 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4666 * mem-limits.h (SIZE): Remove; no longer used.
4667
4668 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4669
4670 Remove unnecessary casts.
4671 * xterm.c (x_term_init):
4672 * xfns.c (x_set_border_pixel):
4673 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4674 These aren't needed now that we assume ANSI C.
4675
4676 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4677 It's more likely to cause problems (due to unsigned overflow)
4678 than to cure them.
4679
4680 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4681
4682 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4683
4684 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4685
4686 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4687
4688 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4689
4690 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4691
4692 GLYPH_CODE_FACE returns EMACS_INT, not int.
4693 * dispextern.h (merge_faces):
4694 * xfaces.c (merge_faces):
4695 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4696 Don't assume EMACS_INT fits in int.
4697
4698 * character.h (CHAR_VALID_P): Remove unused parameter.
4699 * fontset.c, lisp.h, xdisp.c: All uses changed.
4700
4701 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4702
4703 * fns.c (concat): Minor tuning based on overflow analysis.
4704 This doesn't fix any bugs. Use int to hold character, instead
4705 of constantly refetching from Emacs object. Use XFASTINT, not
4706 XINT, for value known to be a character. Don't bother comparing
4707 a single byte to 0400, as it's always less.
4708
4709 * floatfns.c (Fexpt):
4710 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4711
4712 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4713 for characters.
4714
4715 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4716
4717 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4718 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4719 incorrectly succeed when S was a string, because 4294967386 was
4720 truncated before it was used.
4721
4722 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4723 Otherwise, an out-of-range integer could cause undefined behavior
4724 on a 64-bit host.
4725
4726 * composite.c: Use int, not EMACS_INT, for characters.
4727 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4728 EMACS_INT, for values that are known to be in character range.
4729 This doesn't fix any bugs but is the usual style inside Emacs and
4730 may generate better code on 32-bit machines.
4731
4732 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4733 This is for reasons similar to the recent CHAR_STRING fix.
4734 * charset.c (Fencode_char): Check that character arg is actually
4735 a character. Pass an int to ENCODE_CHAR.
4736 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4737 wider than 'int', as a compile-time check to prevent future regressions
4738 in this area.
4739
4740 * character.c (char_string): Remove unnecessary casts.
4741
4742 Make sure a 64-bit char is never passed to CHAR_STRING.
4743 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4744 by silently ignoring the top 32 bits, allowing some values
4745 that were far too large to be valid characters.
4746 * character.h: Include <verify.h>.
4747 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4748 arguments are no wider than unsigned, as a compile-time check
4749 to prevent future regressions in this area.
4750 * data.c (Faset):
4751 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4752 (Fsubst_char_in_region):
4753 * fns.c (concat):
4754 * xdisp.c (decode_mode_spec_coding):
4755 Adjust to CHAR_STRING's new requirement.
4756 * editfns.c (Finsert_char, Fsubst_char_in_region):
4757 * fns.c (concat): Check that character args are actually
4758 characters. Without this test, these functions did the wrong
4759 thing with wildly out-of-range values on 64-bit hosts.
4760
4761 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4762 These casts should not be needed on 32-bit hosts, either.
4763 * keyboard.c (read_char):
4764 * lread.c (Fload): Remove casts to unsigned.
4765
4766 * lisp.h (UNSIGNED_CMP): New macro.
4767 This fixes comparison bugs on 64-bit hosts.
4768 (ASCII_CHAR_P): Use it.
4769 * casefiddle.c (casify_object):
4770 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4771 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4772 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4773 * dispextern.h (FACE_FROM_ID):
4774 * keyboard.c (read_char): Use UNSIGNED_CMP.
4775
4776 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4777 not to EMACS_INT, to avoid GCC warning.
4778
4779 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4780
4781 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4782 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4783 isn't needed on 32-bit machines.
4784
4785 * buffer.c (Fgenerate_new_buffer_name):
4786 Use EMACS_INT for count, not int.
4787 (advance_to_char_boundary): Return EMACS_INT, not int.
4788
4789 * data.c (Qcompiled_function): Now static.
4790
4791 * window.c (window_body_lines): Now static.
4792
4793 * image.c (gif_load): Rename local to avoid shadowing.
4794
4795 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4796 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4797 * alloc.c (make_save_value): Integer argument is now of type
4798 ptrdiff_t, not int.
4799 (mark_object): Use ptrdiff_t, not int.
4800 * lisp.h (pD): New macro.
4801 * print.c (print_object): Use it.
4802
4803 * alloc.c: Use EMACS_INT, not int, to count objects.
4804 (total_conses, total_markers, total_symbols, total_vector_size)
4805 (total_free_conses, total_free_markers, total_free_symbols)
4806 (total_free_floats, total_floats, total_free_intervals)
4807 (total_intervals, total_strings, total_free_strings):
4808 Now EMACS_INT, not int. All uses changed.
4809 (Fgarbage_collect): Compute overall total using a double, so that
4810 integer overflow is less likely to be a problem. Check for overflow
4811 when converting back to an integer.
4812 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4813 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4814 These were 'int' variables that could overflow on 64-bit hosts;
4815 they were never used, so remove them instead of repairing them.
4816 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4817 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4818 Previously, this ceilinged at INT_MAX, but that doesn't work on
4819 64-bit machines.
4820 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4821
4822 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4823 (allocate_vectorlike): Check for ptrdiff_t overflow.
4824 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4825 when a (possibly-narrower) signed value would do just as well.
4826 We prefer using signed arithmetic, to avoid comparison confusion.
4827
4828 * alloc.c: Catch some string size overflows that we were missing.
4829 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4830 for convenience in STRING_BYTES_MAX.
4831 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4832 The definition here is exact; the one in lisp.h was approximate.
4833 (allocate_string_data): Check for string overflow. This catches
4834 some instances we weren't catching before. Also, it catches
4835 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4836 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4837 and ptrdiff_t and EMACS_INT are both 64 bits.
4838
4839 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4840 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4841 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4842
4843 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4844
4845 * alloc.c (Fmake_string): Check for out-of-range init.
4846
4847 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4848
4849 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4850
4851 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4852
4853 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4854 xg_get_default_scrollbar_width.
4855
4856 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4857 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4858 (style_changed_cb): Call update_theme_scrollbar_width and call
4859 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4860 all frames (Bug#8505).
4861 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4862 Call gtk_window_set_resizable if HAVE_GTK3.
4863 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4864 and height if HAVE_GTK3 (Bug#8505).
4865 (scroll_bar_width_for_theme): New variable.
4866 (update_theme_scrollbar_width): New function.
4867 (xg_get_default_scrollbar_width): Move code to
4868 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4869 (xg_initialize): Call update_theme_scrollbar_width.
4870
4871 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4872
4873 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4874
4875 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4876
4877 * frame.c (make_frame): Call other_buffer_safely instead of
4878 other_buffer.
4879
4880 * window.c (temp_output_buffer_show): Call display_buffer with
4881 second argument Vtemp_buffer_show_specifiers and reset latter
4882 immediately after the call.
4883 (Vtemp_buffer_show_specifiers): New variable.
4884 (auto_window_vscroll_p, next_screen_context_lines)
4885 (Vscroll_preserve_screen_position): Remove leading asterisks from
4886 doc-strings.
4887
4888 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4889
4890 Fix minor problems found by GCC 4.6.0 static checking.
4891 * buffer.c (Qclone_number): Remove for now, as it's unused.
4892 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4893 (record_buffer): Remove unused local.
4894 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4895 (set_frame_buffer_list): Remove; unused.
4896 * frame.h (other_visible_frames): Remove decl.
4897 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4898 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4899 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4900 if HAVE_GPM.
4901 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4902 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4903 Define only if HAVE_GPM.
4904 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4905 (update_hints_inhibit): Remove; never set. All uses removed.
4906 * widgetprv.h (emacsFrameClassRec): Remove decl.
4907 * window.c (delete_deletable_window): Now returns void, since it
4908 wasn't returning anything.
4909 (compare_window_configurations): Remove unused locals.
4910 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4911 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4912 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4913 the same widths as pointers. This follows up on the 2011-05-06 patch.
4914 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4915 * xterm.h: Likewise.
4916 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4917
4918 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4919
4920 * makefile.w32-in: Update dependencies.
4921 (LISP_H): Add lib/intprops.h.
4922
4923 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4924
4925 * image.c (gif_load): Add animation frame delay to the metadata.
4926 (syms_of_image): Use DEFSYM. New symbol `delay'.
4927
4928 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4929
4930 * window.c (delete_deletable_window): Re-add.
4931 (Fset_window_configuration): Rewrite to handle dead buffers and
4932 consequently deletable windows.
4933 (window_tree, Fwindow_tree): Remove. Supply functionality in
4934 window.el.
4935 (compare_window_configurations): Simplify code.
4936
4937 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4938
4939 * image.c (imagemagick_load_image): Fix type mismatch.
4940 (Fimagemagick_types): Likewise.
4941
4942 * window.h (replace_buffer_in_windows): Declare.
4943
4944 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4945
4946 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4947 Qclone_number. Remove external declaration of Qdelete_window.
4948 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4949 code.
4950 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4951 Run Qbuffer_list_update_hook if allowed.
4952 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4953 buffer list implementation.
4954 (other_buffer_safely): New function.
4955 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4956 calls to replace_buffer_in_windows and
4957 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4958 if allowed.
4959 (record_buffer): Inhibit quitting and rewrite using quittable
4960 functions. Run Qbuffer_list_update_hook if allowed.
4961 (Frecord_buffer, Funrecord_buffer): New functions.
4962 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4963 Move switch-to-buffer to window.el.
4964 (bury-buffer): Move to window.el.
4965 (Vbuffer_list_update_hook): New variable.
4966
4967 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4968 section.
4969
4970 * window.h (resize_frame_windows): Move up in code.
4971 (Fwindow_frame): Remove EXFUN.
4972 (replace_buffer_in_all_windows): Remove prototype.
4973 (replace_buffer_in_windows_safely): Add prototype.
4974
4975 * window.c: Declare Qdelete_window static again. Move down
4976 declaration of select_count.
4977 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4978 (Fother_window): Move to window.el.
4979 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4980 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4981 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4982 window.el.
4983 (replace_buffer_in_windows): Implement by calling
4984 Qreplace_buffer_in_windows.
4985 (replace_buffer_in_all_windows): Remove with some functionality
4986 moved into replace_buffer_in_windows_safely.
4987 (replace_buffer_in_windows_safely): New function.
4988 (select_window_norecord, select_frame_norecord): Move in front
4989 of run_window_configuration_change_hook. Remove now obsolete
4990 declarations.
4991 (Fset_window_buffer): Rewrite doc-string.
4992 Call Qrecord_window_buffer.
4993 (keys_of_window): Move binding for other-window to window.el.
4994
4995 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4996
4997 * dispextern.h (struct image): Replace data member, whose int_val
4998 and ptr_val fields were not used by anything, with a single
4999 lisp_val object.
5000
5001 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5002 (gif_clear_image, gif_load, imagemagick_load_image)
5003 (gs_clear_image, gs_load): Callers changed.
5004
5005 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5006
5007 * buffer.h: Include <time.h>, for time_t.
5008 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5009
5010 Fix minor problems found by static checking.
5011
5012 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5013
5014 Make identifiers static if they are not used in other modules.
5015 * data.c (Qcompiled_function, Qframe, Qvector):
5016 * image.c (QimageMagick, Qsvg):
5017 * minibuf.c (Qmetadata):
5018 * window.c (resize_window_check, resize_root_window): Now static.
5019 * window.h (resize_window_check, resize_root_window): Remove decls.
5020
5021 * window.c (window_deletion_count, delete_deletable_window):
5022 Remove; unused.
5023 (window_body_lines): Now static.
5024 (Fdelete_other_windows_internal): Mark vars as initialized.
5025 Make sure 'resize_failed' is initialized.
5026 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5027 (resize_window_apply): Remove unused local.
5028 * window.h (delete_deletable_window): Remove decl.
5029
5030 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5031 (imagemagick_load_image): Fix pointer signedness problem by changing
5032 last arg from unsigned char * to char *. All uses changed.
5033 Also, fix a local for similar reasons.
5034 Remove unused locals. Remove locals to avoid shadowing.
5035 (fn_rsvg_handle_free): Remove; unused.
5036 (svg_load, svg_load_image): Fix pointer signedness problem.
5037 (imagemagick_load_image): Don't use garbage pointer image_wand.
5038
5039 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5040
5041 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5042
5043 * image.c (gif_load): Fix omitted cast error introduced by
5044 2011-06-06 change.
5045
5046 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5047
5048 * window.h (resize_proportionally, orig_total_lines)
5049 (orig_top_line): Remove from window structure.
5050 (set_window_height, set_window_width, change_window_heights)
5051 (Fdelete_window): Remove prototypes.
5052 (resize_frame_windows): Remove duplicate declaration.
5053
5054 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5055
5056 * window.h (resize_frame_windows, resize_window_check)
5057 (delete_deletable_window, resize_root_window)
5058 (resize_frame_windows): Declare prototypes.
5059
5060 * window.c (resize_window_apply): Make definition be "static" to
5061 match the prototype.
5062
5063 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5064
5065 * window.c: Remove declarations of Qwindow_size_fixed,
5066 window_min_size_1, window_min_size_2, window_min_size,
5067 size_window, window_fixed_size_p, enlarge_window, delete_window.
5068 Remove static from declaration of Qdelete_window, it's
5069 temporarily needed by Fbury_buffer.
5070 (replace_window): Don't assign orig_top_line and
5071 orig_total_lines.
5072 (Fdelete_window, delete_window): Remove. Window deletion is
5073 handled by window.el.
5074 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5075 Replace Fdelete_window calls with calls to Qdelete_window.
5076 (Fdelete_other_windows): Remove. Deleting other windows is
5077 handled by window.el.
5078 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5079 handled in window.el.
5080 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5081 Window minimum sizes are handled in window.el.
5082 (shrink_windows, size_window, set_window_height)
5083 (set_window_width, change_window_heights, window_height)
5084 (window_width, CURBEG, CURSIZE, enlarge_window)
5085 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5086 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5087 handled in window.el.
5088 (make_dummy_parent): Rename to make_parent_window and give it a
5089 second argument horflag.
5090 (make_window): Don't set resize_proportionally any more.
5091 (Fsplit_window): Remove. Windows are split in window.el.
5092 (save_restore_action, save_restore_orig_size)
5093 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5094 Resize mini windows in window.el.
5095 (grow_mini_window, shrink_mini_window): Implement by calling
5096 Qresize_root_window_vertically, resize_window_check and
5097 resize_window_apply.
5098 (saved_window, Fset_window_configuration, save_window_save):
5099 Do not handle orig_top_line, orig_total_lines, and
5100 resize_proportionally.
5101 (window_min_height, window_min_width): Move to window.el.
5102 (keys_of_window): Move bindings for delete-other-windows,
5103 split-window, delete-window and enlarge-window to window.el.
5104
5105 * buffer.c: Temporarily extern Qdelete_window.
5106 (Fbury_buffer): Temporarily call Qdelete_window instead of
5107 Fdelete_window (Fbury_buffer will move to window.el soon).
5108
5109 * frame.c (set_menu_bar_lines_1): Remove code handling
5110 orig_top_line and orig_total_lines.
5111
5112 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5113 set_window_height but set heights directly.
5114 (change_frame_size_1): Use resize_frame_windows.
5115
5116 * xdisp.c (init_xdisp): Don't use set_window_height but set
5117 heights directly.
5118
5119 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5120 Use resize_frame_windows instead of change_window_heights and run
5121 run_window_configuration_change_hook.
5122
5123 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5124 instead of change_window_heights and run
5125 run_window_configuration_change_hook.
5126
5127 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5128
5129 * window.c (replace_window): Rename second argument REPLACEMENT to
5130 NEW. New third argument SETFLAG. Rewrite.
5131 (delete_window, make_dummy_parent): Call replace_window with
5132 third argument 1.
5133 (window_list_1): Move down in code.
5134 (run_window_configuration_change_hook): Move set_buffer part
5135 before select_frame_norecord part in order to unwind correctly.
5136 Rename count1 to count.
5137 (recombine_windows, delete_deletable_window, resize_root_window)
5138 (Fdelete_other_windows_internal)
5139 (Frun_window_configuration_change_hook, make_parent_window)
5140 (resize_window_check, resize_window_apply, Fresize_window_apply)
5141 (resize_frame_windows, Fsplit_window_internal)
5142 (Fdelete_window_internal, Fresize_mini_window_internal):
5143 New functions.
5144 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5145
5146 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5147
5148 * window.h (window): Add some new members to window structure -
5149 normal_lines, normal_cols, new_total, new_normal, clone_number,
5150 splits, nest, prev_buffers, next_buffers.
5151 (WINDOW_TOTAL_SIZE): Move here from window.c.
5152 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5153
5154 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5155 Remove.
5156 (make_dummy_parent): Set new members of windows structure.
5157 (make_window): Move down in code. Handle new members of window
5158 structure.
5159 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5160 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5161 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5162 (Fset_window_prev_buffers, Fwindow_next_buffers)
5163 (Fset_window_next_buffers, Fset_window_clone_number):
5164 New functions.
5165 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5166 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5167 Doc-string fixes.
5168 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5169 Argument WINDOW can be now internal window too.
5170 (Fwindow_use_time): Move up in code.
5171 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5172 Rewrite doc-string.
5173 (Fset_window_configuration, saved_window)
5174 (Fcurrent_window_configuration, save_window_save): Handle new
5175 members of window structure.
5176 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5177 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5178 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5179 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5180 Qget_mru_window, Qresize_root_window,
5181 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5182 Qauto_buffer_name; staticpro them.
5183
5184 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5185
5186 * window.c (Fwindow_total_size, Fwindow_left_column)
5187 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5188 (Fwindow_list_1): New functions.
5189 (window_box_text_cols): Replace with window_body_cols.
5190 (Fwindow_width, Fscroll_left, Fscroll_right):
5191 Use window_body_cols instead of window_box_text_cols.
5192 (delete_window, Fset_window_configuration):
5193 Call delete_all_subwindows with window as argument.
5194 (delete_all_subwindows): Take a window as argument and not a
5195 structure. Rewrite.
5196 (window_loop): Remove handling of GET_LRU_WINDOW and
5197 GET_LARGEST_WINDOW.
5198 (Fget_lru_window, Fget_largest_window): Move to window.el.
5199
5200 * window.h: Extern window_body_cols instead of
5201 window_box_text_cols. delete_all_subwindows now takes a
5202 Lisp_Object as argument.
5203
5204 * indent.c (compute_motion, Fcompute_motion):
5205 Use window_body_cols instead of window_box_text_cols.
5206
5207 * frame.c (delete_frame): Call delete_all_subwindows with root
5208 window as argument.
5209
5210 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5211
5212 * fns.c (Fputhash): Document return value.
5213
5214 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5215
5216 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5217
5218 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5219
5220 Cons<->int and similar integer overflow fixes (Bug#8794).
5221
5222 Check for overflow when converting integer to cons and back.
5223 * charset.c (Fdefine_charset_internal, Fdecode_char):
5224 Use cons_to_unsigned to catch overflow.
5225 (Fencode_char): Use INTEGER_TO_CONS.
5226 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5227 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5228 * data.c (long_to_cons, cons_to_long): Remove.
5229 (cons_to_unsigned, cons_to_signed): New functions.
5230 These signal an error for invalid or out-of-range values.
5231 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5232 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5233 * font.c (Ffont_variation_glyphs):
5234 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5235 * lisp.h: Include <intprops.h>.
5236 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5237 (cons_to_signed, cons_to_unsigned): New decls.
5238 (long_to_cons, cons_to_long): Remove decls.
5239 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5240 (Fprimitive_undo): Use CONS_TO_INTEGER.
5241 * xfns.c (Fx_window_property): Likewise.
5242 * xselect.c: Include <limits.h>.
5243 (x_own_selection, selection_data_to_lisp_data):
5244 Use INTEGER_TO_CONS.
5245 (x_handle_selection_request, x_handle_selection_clear)
5246 (x_get_foreign_selection, Fx_disown_selection_internal)
5247 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5248 (lisp_data_to_selection_data): Use cons_to_unsigned.
5249 (x_fill_property_data): Use cons_to_signed.
5250 Report values out of range.
5251
5252 Check for buffer and string overflow more precisely.
5253 * buffer.h (BUF_BYTES_MAX): New macro.
5254 * lisp.h (STRING_BYTES_MAX): New macro.
5255 * alloc.c (Fmake_string):
5256 * character.c (string_escape_byte8):
5257 * coding.c (coding_alloc_by_realloc):
5258 * doprnt.c (doprnt):
5259 * editfns.c (Fformat):
5260 * eval.c (verror):
5261 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5262 since they may not be the same number.
5263 * editfns.c (Finsert_char):
5264 * fileio.c (Finsert_file_contents):
5265 Likewise for BUF_BYTES_MAX.
5266
5267 * image.c: Use ptrdiff_t, not int, for sizes.
5268 (slurp_file): Switch from int to ptrdiff_t.
5269 All uses changed.
5270 (slurp_file): Check that file size fits in both size_t (for
5271 malloc) and ptrdiff_t (for sanity and safety).
5272
5273 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5274 if b->modtime has its maximal value.
5275
5276 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5277
5278 Don't assume time_t can fit into int.
5279 * buffer.h (struct buffer.modtime): Now time_t, not int.
5280 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5281 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5282
5283 Minor fixes for signed vs unsigned integers.
5284 * character.h (MAYBE_UNIFY_CHAR):
5285 * charset.c (maybe_unify_char):
5286 * keyboard.c (read_char, reorder_modifiers):
5287 XINT -> XFASTINT, since the integer must be nonnegative.
5288 * ftfont.c (ftfont_spec_pattern):
5289 * keymap.c (access_keymap, silly_event_symbol_error):
5290 XUINT -> XFASTINT, since the integer must be nonnegative.
5291 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5292 since it makes no difference and we prefer signed.
5293 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5294 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5295 nonnegative.
5296
5297 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5298
5299 * window.h (Fwindow_frame): Declare.
5300
5301 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5302
5303 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5304 (SPARE_MEMORY): Always define.
5305 (LARGE_REQUEST): Remove.
5306 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5307
5308 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5309
5310 * lisp.h: Move EXFUNS for Fframe_root_window,
5311 Fframe_first_window and Fset_frame_selected_window to window.h.
5312
5313 * window.h: Move EXFUNS for Fframe_root_window,
5314 Fframe_first_window and Fset_frame_selected_window here from
5315 lisp.h.
5316
5317 * frame.c (Fwindow_frame, Fframe_first_window)
5318 (Fframe_root_window, Fframe_selected_window)
5319 (Fset_frame_selected_window): Move to window.c.
5320 (Factive_minibuffer_window): Move to minibuf.c.
5321 (Fother_visible_frames_p): New function.
5322
5323 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5324
5325 * window.c (decode_window, decode_any_window): Move up in code.
5326 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5327 (inhibit_frame_unsplittable): Remove unused variable.
5328 (Fwindow_buffer): Move up and rewrite doc-string.
5329 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5330 (Fwindow_prev): New functions.
5331 (Fwindow_frame): Move here from frame.c. Accept any window as
5332 argument.
5333 (Fframe_root_window, Fframe_first_window)
5334 (Fframe_selected_window): Move here from frame.c. Accept frame
5335 or arbitrary window as argument. Update doc-strings.
5336 (Fminibuffer_window): Move up in code.
5337 (Fwindow_minibuffer_p): Move up in code and simplify.
5338 (Fset_frame_selected_window): Move here from frame.c.
5339 Marginal rewrite.
5340 (Fselected_window, select_window, Fselect_window): Move up in
5341 code. Minor doc-string fixes.
5342
5343 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5344
5345 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5346 Do not assume that spare memory exists; that assumption is valid
5347 only if SYSTEM_MALLOC.
5348 (LARGE_REQUEST): New macro, so that the issue of large requests
5349 is separated from the issue of spare memory.
5350
5351 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5352
5353 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5354 format. (Bug#8806)
5355
5356 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5357
5358 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5359 before statements.
5360
5361 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5362
5363 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5364
5365 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5366
5367 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5368 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5369
5370 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5371
5372 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5373
5374 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5375
5376 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5377 (x_clipboard_manager_save): Add return value.
5378 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5379 New error handlers.
5380 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5381 Obey Vx_select_enable_clipboard_manager. Catch errors in
5382 x_clipboard_manager_save (Bug#8779).
5383 (Vx_select_enable_clipboard_manager): New variable.
5384 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5385
5386 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5387
5388 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5389
5390 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5391
5392 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5393 in the current matrix if keep_current_p is non-zero.
5394
5395 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5396
5397 * bidi.c (bidi_level_of_next_char): Fix last change.
5398
5399 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5400
5401 Support bidi reordering of text covered by display properties.
5402
5403 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5404 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5405 (bidi_cache_search, bidi_cache_iterator_state)
5406 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5407 (bidi_level_of_next_char, bidi_move_to_visually_next):
5408 Support character positions inside a run of characters covered by a
5409 display string.
5410 (bidi_paragraph_init, bidi_resolve_explicit_1)
5411 (bidi_level_of_next_char): Call bidi_fetch_char and
5412 bidi_fetch_char_advance instead of FETCH_CHAR and
5413 FETCH_CHAR_ADVANCE.
5414 (bidi_init_it): Initialize new members.
5415 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5416 definitions.
5417 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5418 instead of using explicit *_CHAR codes.
5419 (bidi_resolve_explicit, bidi_resolve_weak):
5420 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5421 bidirectional text is supported only in multibyte buffers.
5422 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5423 it to initialize the frame_window_p member of struct bidi_it.
5424 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5425 (bidi_resolve_explicit, bidi_resolve_weak)
5426 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5427 bidi_it->nchars is non-positive.
5428 (bidi_level_of_next_char): Don't try to lookup the cache for the
5429 next/previous character if nothing is cached there yet, or if we
5430 were just reseat()'ed to a new position.
5431
5432 * xdisp.c (set_cursor_from_row): Set start and stop points
5433 according to the row's direction when priming the loop that looks
5434 for the glyph on which to display cursor.
5435 (single_display_spec_intangible_p): Function deleted.
5436 (display_prop_intangible_p): Reimplement to call
5437 handle_display_spec instead of single_display_spec_intangible_p.
5438 Accept 3 additional arguments needed by handle_display_spec.
5439 This fixes incorrect cursor motion across display property with complex
5440 values: lists, `(when COND...)' forms, etc.
5441 (single_display_spec_string_p): Support property values that are
5442 lists with the argument STRING its top-level element.
5443 (display_prop_string_p): Fix the condition for processing a
5444 property that is a list to be consistent with handle_display_spec.
5445 (handle_display_spec): New function, refactored from the
5446 last portion of handle_display_prop.
5447 (compute_display_string_pos): Accept additional argument
5448 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5449 value of a `display' property is a "replacing spec".
5450 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5451 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5452 the display property, but just return a value indicating whether
5453 the display property will replace the characters it covers.
5454 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5455 frame_window_p members of struct bidi_it.
5456 (compute_display_string_pos, compute_display_string_end):
5457 New functions.
5458 (push_it): Accept second argument POSITION, where pop_it should
5459 jump to continue iteration.
5460 (reseat_1): Initialize bidi_it.disp_pos.
5461
5462 * keyboard.c (adjust_point_for_property): Adjust the call to
5463 display_prop_intangible_p to its new signature.
5464
5465 * dispextern.h (struct bidi_it): New member frame_window_p.
5466 (bidi_init_it): Update prototypes.
5467 (display_prop_intangible_p): Update prototype.
5468 (compute_display_string_pos, compute_display_string_end):
5469 Declare prototypes.
5470 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5471 EMACS_INT.
5472
5473 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5474
5475 Malloc failure behavior now depends on size of allocation.
5476 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5477 * lisp.h: Change signatures accordingly.
5478 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5479 All callers changed. (Bug#8762)
5480
5481 * gnutls.c: Use Emacs's memory allocators.
5482 Without this change, the gnutls library would invoke malloc etc.
5483 directly, which causes problems on non-SYNC_INPUT hosts, and which
5484 runs afoul of improving memory_full behavior. (Bug#8761)
5485 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5486 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5487 xfree instead of the default malloc, realloc, free.
5488 (Fgnutls_boot): No need to check for memory allocation failure,
5489 since xmalloc does that for us.
5490
5491 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5492 * category.c (hash_get_category_set):
5493 * ccl.c (ccl_driver):
5494 * charset.c (Fdefine_charset_internal):
5495 * charset.h (struct charset.hash_index):
5496 * composite.c (get_composition_id, gstring_lookup_cache)
5497 (composition_gstring_put_cache):
5498 * composite.h (struct composition.hash_index):
5499 * dispextern.h (struct image.hash):
5500 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5501 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5502 (hashfn_equal, hashfn_user_defined, make_hash_table)
5503 (maybe_resize_hash_table, hash_lookup, hash_put)
5504 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5505 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5506 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5507 * image.c (make_image, search_image_cache, lookup_image)
5508 (xpm_put_color_table_h):
5509 * lisp.h (struct Lisp_Hash_Table):
5510 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5511 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5512 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5513 * alloc.c (allocate_vectorlike):
5514 Check for overflow in vector size calculations.
5515 * ccl.c (ccl_driver):
5516 Check for overflow when converting EMACS_INT to int.
5517 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5518 need to be updated by these changes.
5519 * fns.c (make_hash_table, maybe_resize_hash_table):
5520 Check for integer overflow with large hash tables.
5521 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5522 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5523 (SXHASH_REDUCE): New macro.
5524 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5525 Use it instead of discarding useful hash info with large hash values.
5526 (sxhash_float): New function.
5527 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5528 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5529 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5530 Rewrite to use FIXNUM_BITS, as this simplifies things.
5531 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5532 Adjust signatures to match updated version of code.
5533 (consing_since_gc): Now EMACS_INT, since a single hash table can
5534 use more than INT_MAX bytes.
5535
5536 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5537
5538 Make it possible to build with GCC-4.6+ -O2 -flto.
5539
5540 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5541
5542 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5543
5544 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5545 Call minibuffer-inactive-mode.
5546
5547 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5548
5549 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5550 Update dependencies.
5551
5552 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5553
5554 * data.c (init_data): Remove code for UTS, this system is not
5555 supported anymore.
5556
5557 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5558
5559 Don't force ./temacs to start in terminal mode.
5560
5561 * frame.c (make_initial_frame): Initialize faces in all cases, not
5562 only when CANNOT_DUMP is defined.
5563 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5564
5565 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5566
5567 * dispnew.c (add_window_display_history): Use const for the string
5568 pointer. Remove declaration, not needed.
5569
5570 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5571
5572 Use 'inline', not 'INLINE'.
5573 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5574 * alloc.c, fontset.c (INLINE): Remove.
5575 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5576 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5577 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5578 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5579 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5580
5581 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5582
5583 Make it possible to run ./temacs.
5584
5585 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5586 syms_of_callproc does the same thing. Remove test for
5587 "initialized", do it in the caller.
5588 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5589
5590 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5591
5592 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5593 (read_minibuf): Use get_minibuffer.
5594 (syms_of_minibuf): Use DEFSYM.
5595 (Qmetadata): New var.
5596 * data.c (Qbuffer): Don't make it static.
5597 (syms_of_data): Use DEFSYM.
5598
5599 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5600
5601 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5602 (CCL_CODE_MIN): New macro.
5603
5604 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5605
5606 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5607
5608 * eval.c (Qdebug): Now static.
5609 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5610 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5611 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5612
5613 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5614
5615 * image.c: Various fixes to ImageMagick code comments.
5616 (Fimagemagick_types): Doc fix.
5617
5618 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5619
5620 Minor fixes prompted by GCC 4.6.0 warnings.
5621
5622 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5623
5624 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5625 (x_clipboard_manager_save_all): Move extern decl to ...
5626 * xterm.h: ... here, so that it can be checked for consistency.
5627
5628 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5629
5630 * xselect.c (x_clipboard_manager_save_frame)
5631 (x_clipboard_manager_save_all): New functions.
5632 (Fx_clipboard_manager_save): Lisp function deleted.
5633
5634 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5635 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5636
5637 * xterm.h: Update prototype.
5638
5639 2011-05-28 William Xu <william.xwl@gmail.com>
5640
5641 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5642 exiting (Bug#8239).
5643
5644 2011-05-28 Jim Meyering <meyering@redhat.com>
5645
5646 Avoid a sign-extension bug in crypto_hash_function.
5647 * fns.c (to_uchar): Define.
5648 (crypto_hash_function): Use it to convert some newly-signed
5649 variables to unsigned, to avoid sign-extension bugs. For example,
5650 without this change, (md5 "truc") would evaluate to
5651 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5652 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5653 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5654
5655 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5656
5657 Integer overflow fixes.
5658
5659 * dbusbind.c: Serial number integer overflow fixes.
5660 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5661 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5662 to hold a serial number that is too large for a fixnum.
5663 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5664 Check for serial numbers out of range. Decode any serial number
5665 that was so large that it became a float. (Bug#8722)
5666
5667 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5668 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5669 Use XFASTINT rather than XUINT when numbers are nonnegative.
5670 (xd_append_arg, Fdbus_method_return_internal):
5671 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5672 arguments, check that Lisp number is nonnegative, rather than
5673 silently wrapping negative numbers around. (Bug#8722)
5674 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5675 (Bug#8722)
5676
5677 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5678
5679 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5680
5681 ccl: Add integer overflow checks.
5682 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5683 (IN_INT_RANGE): New macros.
5684 (ccl_driver): Use them to check for integer overflow when
5685 decoding a CCL program. Many of the new checks are whether XINT (x)
5686 fits in int; it doesn't always, on 64-bit hosts. The new version
5687 doesn't catch all possible integer overflows, but it's an
5688 improvement. (Bug#8719)
5689
5690 * alloc.c (make_event_array): Use XINT, not XUINT.
5691 There's no need for unsigned here.
5692
5693 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5694 This follows up to the 2011-05-06 change that substituted uintptr_t
5695 for EMACS_INT. This case wasn't caught back then.
5696
5697 Rework Fformat to avoid integer overflow issues.
5698 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5699 now (part of C89). Include <verify.h>.
5700 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5701 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5702 (Fformat): Avoid the prepass trying to compute sizes; it was only
5703 approximate and thus did not catch overflow reliably. Instead, walk
5704 through the format just once, formatting and computing sizes as we go,
5705 checking for integer overflow at every step, and allocating a larger
5706 buffer as needed. Keep track separately whether the format is
5707 multibyte. Keep only the most-recently calculated precision, rather
5708 than them all. Record whether each argument has been converted to
5709 string. Use EMACS_INT, not int, for byte and char and arg counts.
5710 Support field widths and precisions larger than INT_MAX. Avoid
5711 sprintf's undefined behavior with conversion specifications such as %#d
5712 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5713 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5714 formatting out-of-range floating point numbers with int
5715 formats. (Bug#8668)
5716
5717 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5718
5719 * data.c: Avoid integer truncation in expressions involving floats.
5720 * data.c: Include <intprops.h>.
5721 (arith_driver): When there's an integer overflow in an expression
5722 involving floating point, convert the integers to floating point
5723 so that the resulting value does not suffer from catastrophic
5724 integer truncation. For example, on a 64-bit host (* 4
5725 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5726 Do not rely on undefined behavior after integer overflow.
5727
5728 merge count_size_as_multibyte, parse_str_to_multibyte
5729 * character.c, character.h (count_size_as_multibyte):
5730 Rename from parse_str_to_multibyte; all uses changed.
5731 Check for integer overflow.
5732 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5733 since it's now a duplicate of the other. This is more of
5734 a character than a buffer op, so better that it's in character.c.
5735 * fns.c, print.c: Adjust to above changes.
5736
5737 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5738
5739 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5740
5741 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5742
5743 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5744 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5745 (x_clipboard_manager_save): Now static.
5746 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5747
5748 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5749 (crypto_hash_function): Now static.
5750 Fix pointer signedness problems. Avoid unnecessary initializations.
5751
5752 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5753
5754 * termhooks.h (Vselection_alist): Make it terminal-local.
5755
5756 * terminal.c (create_terminal): Initialize it.
5757
5758 * xselect.c: Support for clipboard managers.
5759 (Vselection_alist): Move to termhooks.h as terminal-local var.
5760 (LOCAL_SELECTION): New macro.
5761 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5762 (symbol_to_x_atom): Remove gratuitous arg.
5763 (x_handle_selection_request, lisp_data_to_selection_data)
5764 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5765 (x_own_selection, x_get_local_selection, x_convert_selection):
5766 New arg, specifying work frame. Use terminal-local Vselection_alist.
5767 (some_frame_on_display): Delete unused function.
5768 (Fx_own_selection_internal, Fx_get_selection_internal)
5769 (Fx_disown_selection_internal, Fx_selection_owner_p)
5770 (Fx_selection_exists_p): New optional frame arg.
5771 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5772 (x_handle_selection_clear): Don't treat other terminals with the
5773 same keyboard specially. Use the terminal-local Vselection_alist.
5774 (x_clear_frame_selections): Use Frun_hook_with_args.
5775
5776 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5777
5778 * xterm.h: Add support for those atoms.
5779
5780 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5781
5782 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5783 (converted_selections, conversion_fail_tag): New global variables.
5784 (x_selection_request_lisp_error): Free the above.
5785 (x_get_local_selection): Remove unnecessary code.
5786 (x_reply_selection_request): Args changed; handle arbitrary array
5787 of converted selections stored in converted_selections.
5788 Separate the XChangeProperty and SelectionNotify steps.
5789 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5790 (x_convert_selection): New function.
5791 (x_handle_selection_event): Simplify.
5792 (x_get_foreign_selection): Don't ignore incoming requests while
5793 waiting for an answer; this will fail when we implement
5794 SAVE_TARGETS, and seems unnecessary anyway.
5795 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5796 (Vx_sent_selection_functions): Doc fix.
5797
5798 2011-05-26 Leo Liu <sdl.web@gmail.com>
5799
5800 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5801
5802 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5803
5804 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5805
5806 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5807 for fringe update if it has periodic bitmap.
5808 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5809 and fringe_bitmap_periodic_p.
5810
5811 * fringe.c (get_fringe_bitmap_data): New function.
5812 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5813 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5814 row. Mark glyph row for fringe update if periodicity changed.
5815
5816 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5817 for fringe update unless it has periodic bitmap.
5818
5819 2011-05-25 Kenichi Handa <handa@m17n.org>
5820
5821 * xdisp.c (get_next_display_element): Set correct it->face_id for
5822 a static composition.
5823
5824 2011-05-24 Leo Liu <sdl.web@gmail.com>
5825
5826 * deps.mk (fns.o):
5827 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5828
5829 * fns.c (crypto_hash_function, Fsha1): New function.
5830 (Fmd5): Use crypto_hash_function.
5831 (syms_of_fns): Add Ssha1.
5832
5833 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5834
5835 * gnutls.c: Remove unused macros.
5836 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5837 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5838 Remove macros that are defined and never used.
5839 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5840
5841 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5842
5843 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5844 (Fx_get_selection_internal): Minor cleanup.
5845 (Fx_own_selection_internal): Rename arguments for consistency with
5846 select.el.
5847
5848 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5849
5850 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5851
5852 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5853
5854 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5855
5856 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5857
5858 * dispnew.c (scrolling_window): Don't exclude the case that the
5859 last enabled row in the desired matrix touches the bottom boundary.
5860
5861 2011-05-21 Glenn Morris <rgm@gnu.org>
5862
5863 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5864 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5865 and add some more files.
5866
5867 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5868
5869 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5870 report_file_error introduced by the change from 2011-05-07.
5871
5872 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5873
5874 * systime.h (Time): Define only if emacs is defined.
5875 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5876 where the include path doesn't have X11/X.h by default. See
5877 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5878
5879 2011-05-20 Kenichi Handa <handa@m17n.org>
5880
5881 * composite.c (find_automatic_composition): Fix previous change.
5882
5883 2011-05-20 Glenn Morris <rgm@gnu.org>
5884
5885 * lisp.mk: New file, split from Makefile.in.
5886 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5887 (shortlisp): Remove.
5888 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5889
5890 2011-05-19 Glenn Morris <rgm@gnu.org>
5891
5892 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5893 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5894 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5895 (lisp): Set the order to that of loadup.el.
5896 (shortlisp): Make it a copy of $lisp.
5897 (SOME_MACHINE_LISP): Remove.
5898 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5899 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5900
5901 2011-05-18 Kenichi Handa <handa@m17n.org>
5902
5903 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5904 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5905 (find_automatic_composition): Mostly rewrite for efficiency.
5906
5907 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5908
5909 * makefile.w32-in: Update dependencies.
5910
5911 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5912
5913 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5914 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5915
5916 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5917
5918 Fix some integer overflow issues, such as string length overflow.
5919
5920 * insdel.c (count_size_as_multibyte): Check for string overflow.
5921
5922 * character.c (lisp_string_width): Check for string overflow.
5923 Use EMACS_INT, not int, for string indexes and lengths; in
5924 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5925 the resulting string length overflows an EMACS_INT; instead,
5926 report a string overflow if no precision given. When checking for
5927 precision exhaustion, use a check that cannot possibly have
5928 integer overflow. (Bug#8675)
5929 * character.h (lisp_string_width): Adjust to new signature.
5930
5931 * alloc.c (string_overflow): New function.
5932 (Fmake_string): Use it. This doesn't change behavior, but saves
5933 a few bytes and will simplify future changes.
5934 * character.c (string_escape_byte8): Likewise.
5935 * lisp.h (string_overflow): New decl.
5936
5937 Fixups, following up to the user-interface timestamp change.
5938 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5939 for UI timestamps, instead of unsigned long.
5940 * msdos.c (mouse_get_pos): Likewise.
5941 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5942 * w32gui.h (Time): Define by including "systime.h" rather than by
5943 declaring it ourselves. (Bug#8664)
5944
5945 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5946 * image.c (clear_image_cache): Likewise.
5947
5948 * term.c (term_mouse_position): Don't assume time_t wraparound.
5949
5950 Be more systematic about user-interface timestamps.
5951 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5952 and sometimes 'EMACS_UINT', to represent these timestamps.
5953 This change causes it to use 'Time' uniformly, as that's what X uses.
5954 This makes the code easier to follow, and makes it easier to catch
5955 integer overflow bugs such as Bug#8664.
5956 * frame.c (Fmouse_position, Fmouse_pixel_position):
5957 Use Time, not unsigned long, for user-interface timestamps.
5958 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5959 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5960 * keyboard.h (last_event_timestamp): Likewise.
5961 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5962 * menu.h (xmenu_show): Likewise.
5963 * term.c (term_mouse_position): Likewise.
5964 * termhooks.h (struct input_event.timestamp): Likewise.
5965 (struct terminal.mouse_position_hook): Likewise.
5966 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5967 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5968 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5969 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5970 what it was before.
5971 * menu.h, termhooks.h: Include "systime.h", for Time.
5972
5973 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5974 Don't assume that the difference between two unsigned long values
5975 can fit into an integer. At this point, we know button_down_time
5976 <= event->timestamp, so the difference must be nonnegative, so
5977 there's no need to cast the result if double-click-time is
5978 nonnegative, as it should be; check that it's nonnegative, just in
5979 case. This bug is triggered when events are more than 2**31 ms
5980 apart (about 25 days). (Bug#8664)
5981
5982 * xselect.c (last_event_timestamp): Remove duplicate decl.
5983 (x_own_selection): Remove needless cast to unsigned long.
5984
5985 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5986 that always fit in int. Use a sentinel instead of a counter, to
5987 avoid a temp and to allay GCC's concerns about possible int overflow.
5988 * frame.h (struct frame): Use int for menu_bar_items_used
5989 instead of EMACS_INT, since it always fits in int.
5990
5991 * menu.c (grow_menu_items): Check for int overflow.
5992
5993 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5994
5995 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5996 Before, the code was not consistent. These values cannot exceed
5997 2**31 - 1 so there's no need to make them unsigned.
5998 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5999 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6000 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6001 as modifiers.
6002 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6003
6004 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6005 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6006 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6007 presumably because the widths might not match.
6008
6009 * window.c (size_window): Avoid needless test at loop start.
6010
6011 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6012
6013 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6014
6015 2011-05-12 Drew Adams <drew.adams@oracle.com>
6016
6017 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6018
6019 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6020
6021 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6022 `width' to `bar_area_x' and `bar_area_width', respectively.
6023 (x_scroll_run): Take account of fringe background extension.
6024
6025 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6026 Rename local vars `left' and `width' to `bar_area_x' and
6027 `bar_area_width', respectively.
6028 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6029 background extension.
6030
6031 2011-05-10 Jim Meyering <meyering@redhat.com>
6032
6033 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6034
6035 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6036
6037 * image.c (Finit_image_library): Return t for built-in image types,
6038 like pbm and xbm. (Bug#8640)
6039
6040 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6041
6042 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6043
6044 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6045
6046 * w32console.c (Fset_screen_color): Doc fix.
6047 (Fget_screen_color): New function.
6048 (syms_of_ntterm): Defsubr it.
6049
6050 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6051 unlink the temporary file if Fcall_process didn't create it in the
6052 first place.
6053 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6054 child process will be redirected to a file specified with `:file'.
6055 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6056 cue to call_process_cleanup not to close that handle.
6057
6058 2011-05-07 Ben Key <bkey76@gmail.com>
6059
6060 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6061 one of two shell specific rules, either bootstrap-temacs-CMD or
6062 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6063 to the previous implementation of the bootstrap-temacs rule.
6064 The bootstrap-temacs-CMD rule is similar to the previous
6065 implementation of the bootstrap-temacs rule except that it
6066 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6067 variable.
6068
6069 These changes, along with some changes to nt/configure.bat,
6070 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6071 earlier fix to add support for --cflags and --ldflags options
6072 that include quotes so that it works whether make uses cmd or
6073 sh as the shell.
6074
6075 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6076
6077 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6078 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6079 is a constant.
6080 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6081 a string. Handle both cases.
6082 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6083 (Fdbus_register_method): Use Qinvalid_function.
6084
6085 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6086
6087 * makefile.w32-in: Update dependencies.
6088 (LISP_H): Add inttypes.h and stdin.h.
6089 (PROCESS_H): Add unistd.h.
6090
6091 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6092
6093 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6094 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6095
6096 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6097
6098 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6099
6100 * term.c (vfatal): Remove stray call to va_end.
6101 It's not needed and the C Standard doesn't allow it here anyway.
6102
6103 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6104 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6105
6106 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6107 bytes.
6108
6109 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6110
6111 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6112
6113 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6114
6115 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6116
6117 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6118
6119 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6120 * charset.c (Fdefine_charset_internal): Don't initialize
6121 charset.code_space[15]. The value was garbage, on hosts with
6122 32-bit int (Bug#8600).
6123
6124 * lread.c (read_integer): Be more consistent with string-to-number.
6125 Use string_to_number to do the actual conversion; this avoids
6126 rounding errors and fixes some other screwups. Without this fix,
6127 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6128 (digit_to_number): Move earlier, for benefit of read_integer.
6129 Return -1 if the digit is out of range for the base, -2 if it is
6130 not a digit in any supported base. (Bug#8602)
6131
6132 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6133
6134 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6135 to match comment at start of function. This also removes a
6136 GCC warning about overflow in a 32+64-bit port.
6137
6138 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6139
6140 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6141 Reported by Stefan Monnier in
6142 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6143 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6144 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6145
6146 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6147 (EMACS_UINTPTR): Likewise, with uintptr_t.
6148
6149 * lisp.h: Prefer 64-bit EMACS_INT if available.
6150 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6151 on 32-bit hosts that have 64-bit int, so that they can access
6152 large files.
6153 However, temporarily disable this change unless the temporary
6154 symbol WIDE_EMACS_INT is defined.
6155
6156 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6157
6158 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6159 This removes an assumption that EMACS_INT and long are the same
6160 width as pointers. The assumption is true for Emacs porting targets
6161 now, but we want to make other targets possible.
6162 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6163 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6164 In the rest of the code, change types of integers that hold casted
6165 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6166 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6167 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6168 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6169 No need to cast type when ORing.
6170 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6171 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6172 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6173 assume EMACS_INT is the same width as char *.
6174 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6175 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6176 Remove no-longer-needed casts.
6177 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6178 (xg_tool_bar_help_callback, xg_make_tool_item):
6179 Use EMACS_INTPTR to hold an integer
6180 that will be cast to void *; this can avoid a GCC warning
6181 if EMACS_INT is not the same width as void *.
6182 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6183 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6184 (current_message_1, set_message_1):
6185 Use a local to convert to proper width without a cast.
6186 * xmenu.c (dialog_selection_callback): Likewise.
6187
6188 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6189 Also, don't assume VALBITS / RAND_BITS is less than 5,
6190 and don't rely on undefined behavior when shifting a 1 left into
6191 the sign bit.
6192 * lisp.h (get_random): Change signature to match.
6193
6194 * lread.c (hash_string): Use size_t, not int, for hash computation.
6195 Normally we prefer signed values; but hashing is special, because
6196 it's better to use unsigned division on hash table sizes so that
6197 the remainder is nonnegative. Also, size_t is the natural width
6198 for hashing into memory. The previous code used 'int', which doesn't
6199 retain enough info to hash well into very large tables.
6200 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6201
6202 * dbusbind.c: Don't possibly lose pointer info when converting.
6203 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6204 Use XPNTR rather than XHASH, so that the high-order bits of
6205 the pointer aren't lost when converting through void *.
6206
6207 * eval.c (Fautoload): Don't double-shift a pointer.
6208
6209 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6210
6211 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6212
6213 * gnutls.c (DEF_GNUTLS_FN):
6214 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6215
6216 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6217
6218 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6219 marker. (Bug#8610)
6220
6221 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6222
6223 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6224 New version that can reserve upto 2GB of heap space.
6225
6226 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6227
6228 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6229
6230 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6231
6232 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6233 `gnutls_certificate_set_x509_key_file'.
6234
6235 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6236
6237 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6238 Update dependencies.
6239
6240 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6241
6242 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6243 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6244 Remove unused parameter `fildes'.
6245 * process.c (read_process_output, send_process): Don't pass it.
6246
6247 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6248
6249 Fix previous change: the library cache is defined in w32.c.
6250 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6251 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6252
6253 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6254
6255 Implement dynamic loading of GnuTLS on Windows.
6256
6257 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6258 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6259 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6260 Declare.
6261
6262 * gnutls.c (Qgnutls_dll): Define.
6263 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6264 (gnutls_*): Declare function pointers.
6265 (init_gnutls_functions): New function to initialize function pointers.
6266 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6267 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6268 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6269 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6270 (emacs_gnutls_write, emacs_gnutls_read)
6271 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6272 (Fgnutls_available_p): New function.
6273 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6274 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6275 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6276
6277 * image.c: Include w32.h.
6278 (Vimage_type_cache): Delete.
6279 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6280 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6281 (w32_delayed_load): Move to w32.c.
6282
6283 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6284
6285 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6286 (w32_delayed_load): Move from image.c. When loading a library, record
6287 its filename in the :loaded-from property of the library id.
6288 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6289 Initialize and staticpro them.
6290 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6291
6292 * process.c: Include lisp.h before w32.h, not after.
6293 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6294 instead of gnutls_record_check_pending.
6295
6296 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6297
6298 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6299
6300 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6301 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6302 as passed in.
6303
6304 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6305
6306 * xterm.c (x_set_frame_alpha): Do not set property on anything
6307 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6308
6309 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6310
6311 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6312
6313 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6314
6315 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6316 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6317 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6318 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6319 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6320 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6321 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6322 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6323 (Qgnutls_bootprop_callbacks_verify): Make static.
6324
6325 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6326
6327 * callproc.c: Indentation fixup.
6328
6329 * sysdep.c (wait_for_termination_1): Make static.
6330 (wait_for_termination, interruptible_wait_for_termination):
6331 Move after wait_for_termination_1.
6332
6333 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6334
6335 * sysdep.c (interruptible_wait_for_termination): New function
6336 which is like wait_for_termination, but allows keyboard
6337 interruptions.
6338
6339 * callproc.c (Fcall_process): Add (:file "file") as an option for
6340 the STDOUT buffer.
6341 (Fcall_process_region): Ditto.
6342
6343 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6344
6345 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6346 rather than `XVECTOR (FOO)->size'.
6347
6348 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6349 inttypes.h, as a gnulib replacement is used if it not available in
6350 system headers.
6351
6352 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6353
6354 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6355 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6356 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6357
6358 * coding.c (coding_alloc_by_realloc): Error out if destination
6359 will grow beyond MOST_POSITIVE_FIXNUM.
6360 (decode_coding_emacs_mule): Abort if there isn't enough place in
6361 charbuf for the composition carryover bytes. Reserve an extra
6362 space for up to 2 characters produced in a loop.
6363 (decode_coding_iso_2022): Abort if there isn't enough place in
6364 charbuf for the composition carryover bytes.
6365
6366 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6367
6368 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6369 aborting when %lld or %lll format is passed.
6370 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6371 %llo or %llx format is passed. (Bug#8545)
6372
6373 * window.c (window_scroll_line_based): Use a marker instead of
6374 simple variables to record original value of point. (Bug#7952)
6375
6376 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6377 produced by %s or %c overflows available buffer space. (Bug#8545)
6378
6379 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6380
6381 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6382 (SIZE_MAX): Move defn after all includes, as they might #define it.
6383
6384 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6385
6386 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6387
6388 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6389
6390 * keyboard.c (Qdelayed_warnings_hook): Define.
6391 (command_loop_1): Run `delayed-warnings-hook'
6392 if Vdelayed_warnings_list is non-nil.
6393 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6394 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6395
6396 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6397
6398 * doprnt.c (doprnt): Don't return value smaller than the buffer
6399 size if the message was truncated. (Bug#8545).
6400
6401 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6402
6403 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6404 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6405
6406 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6407
6408 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6409
6410 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6411
6412 * makefile.w32-in: Update dependencies.
6413
6414 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6415
6416 Improve `doprnt' and its usage. (Bug#8545)
6417 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6418 `format_end'. Remove support for %l as a conversion specifier.
6419 Don't use xrealloc. Improve diagnostics when the %l size modifier
6420 is used. Update the commentary.
6421
6422 * eval.c (verror): Simplify calculation of size_t.
6423
6424 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6425 messages.
6426
6427 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6428
6429 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6430 change.
6431
6432 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6433
6434 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6435 This makes this file independent of the recent pseudovector change.
6436
6437 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6438
6439 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6440
6441 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6442 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6443 Remove unused local.
6444 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6445
6446 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6447 GCC 4.6.0 optimizes based on type-based alias analysis.
6448 For example, if b is of type struct buffer * and v of type struct
6449 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6450 != &v->size, and therefore "v->size = 1; b->size = 2; return
6451 v->size;" must therefore return 1. This assumption is incorrect
6452 for Emacs, since it type-puns struct Lisp_Vector * with many other
6453 types. To fix this problem, this patch adds a new type struct
6454 vectorlike_header that documents the constraints on layout of vectors
6455 and pseudovectors, and helps optimizing compilers not get fooled
6456 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6457 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6458 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6459 the size member.
6460 (XSETPVECTYPE): Rewrite in terms of new macro.
6461 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6462 This is a bit clearer, and further avoids the possibility of
6463 undesirable aliasing.
6464 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6465 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6466 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6467 since Lisp_Subr is a special case (no "next" field).
6468 (ASIZE): Now uses header.size rather than size.
6469 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6470 to avoid the hassle of writing XVECTOR (foo)->header.size.
6471 (struct vectorlike_header): New type.
6472 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6473 object, to help avoid aliasing.
6474 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6475 (SUBRP): Likewise, since Lisp_Subr is a special case.
6476 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6477 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6478 (struct Lisp_Hash_Table): Combine first two members into a single
6479 struct vectorlike_header member. All uses of "size" and "next" members
6480 changed to be "header.size" and "header.next".
6481 * buffer.h (struct buffer): Likewise.
6482 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6483 * frame.h (struct frame): Likewise.
6484 * process.h (struct Lisp_Process): Likewise.
6485 * termhooks.h (struct terminal): Likewise.
6486 * window.c (struct save_window_data, struct saved_window): Likewise.
6487 * window.h (struct window): Likewise.
6488 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6489 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6490 * buffer.c (init_buffer_once): Likewise.
6491 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6492 special case.
6493 * process.c (Fformat_network_address): Use local var for size,
6494 for brevity.
6495
6496 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6497
6498 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6499 * data.c (atof): Remove decl; no longer used or needed.
6500 (digit_to_number): Move to lread.c.
6501 (Fstring_to_number): Use new string_to_number function, to be
6502 consistent with how the Lisp reader treats infinities and NaNs.
6503 Do not assume that floating-point numbers represent EMACS_INT
6504 without losing information; this is not true on most 64-bit hosts.
6505 Avoid double-rounding errors, by insisting on integers when
6506 parsing non-base-10 numbers, as the documentation specifies.
6507 * lisp.h (string_to_number): New decl, replacing ...
6508 (isfloat_string): Remove.
6509 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6510 (read1): Do not accept +. and -. as integers; this
6511 appears to have been a coding error. Similarly, do not accept
6512 strings like +-1e0 as floating point numbers. Do not report
6513 overflow for integer overflows unless the base is not 10 which
6514 means we have no simple and reliable way to continue.
6515 Break out the floating-point parsing into a new
6516 function string_to_number, so that Fstring_to_number parses
6517 floating point numbers consistently with the Lisp reader.
6518 (digit_to_number): Move here from data.c. Make it static inline.
6519 (E_CHAR, EXP_INT): Remove, replacing with ...
6520 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6521 (string_to_number): New function, replacing isfloat_string.
6522 This function checks for valid syntax and produces the resulting
6523 Lisp float number too. Rework it so that string-to-number
6524 no longer mishandles examples like "1.0e+". Use strtoumax,
6525 so that overflow for non-base-10 numbers is reported only when
6526 there's no portable and simple way to convert to floating point.
6527
6528 * textprop.c (set_text_properties_1): Rewrite for clarity,
6529 and to avoid GCC warning about integer overflow.
6530
6531 * intervals.h (struct interval): Use EMACS_INT for members
6532 where EMACS_UINT might cause problems. See
6533 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6534 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6535 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6536 All uses changed.
6537 (offset_intervals): Tell GCC not to worry about length overflow
6538 when negating a negative length.
6539
6540 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6541 (overrun_check_free): Likewise.
6542
6543 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6544 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6545 word size.
6546
6547 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6548 (gnutls_make_error): Rename local to avoid shadowing.
6549 (gnutls_emacs_global_deinit): ifdef out; not used.
6550 (Fgnutls_boot): Use const for pointer to readonly storage.
6551 Comment out unused local. Fix pointer signedness problems.
6552
6553 * lread.c (openp): Don't stuff size_t into an 'int'.
6554 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6555 about possible signed overflow.
6556
6557 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6558 (GDK_KEY_g): Don't define if already defined.
6559 (xg_prepare_tooltip): Avoid pointer signedness problem.
6560 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6561
6562 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6563 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6564
6565 * xfns.c (Fx_window_property): Simplify a bit,
6566 to make a bit faster and to avoid GCC 4.6.0 warning.
6567 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6568
6569 * fns.c (internal_equal): Don't assume size_t fits in int.
6570
6571 * alloc.c (compact_small_strings): Tighten assertion a little.
6572
6573 Replace pEd with more-general pI, and fix some printf arg casts.
6574 * lisp.h (pI): New macro, generalizing old pEd macro to other
6575 conversion specifiers. For example, use "...%"pI"d..." rather
6576 than "...%"pEd"...".
6577 (pEd): Remove. All uses replaced with similar uses of pI.
6578 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6579 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6580 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6581 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6582 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6583 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6584 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6585 64-bit hosts.
6586 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6587 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6588 * print.c (safe_debug_print, print_object): Likewise.
6589 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6590 to int.
6591 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6592 avoiding the 0 flag, which is not portable.
6593 * process.c (Fmake_network_process): Use pI to avoid cast.
6594 * region-cache.c (pp_cache): Likewise.
6595 * xdisp.c (decode_mode_spec): Likewise.
6596 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6597 behavior on 64-bit hosts with printf arg.
6598 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6599 (x_stop_queuing_selection_requests): Likewise.
6600 (x_get_window_property): Don't truncate byte count to an 'int'
6601 when tracing.
6602
6603 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6604 here, since it parses constructs like leading '-' and spaces,
6605 which are not wanted; and it overflows with large numbers.
6606 Instead, simply match F[0-9]+, which is what is wanted anyway.
6607
6608 * alloc.c: Remove unportable assumptions about struct layout.
6609 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6610 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6611 (allocate_vectorlike, make_pure_vector): Use the new macros,
6612 plus offsetof, to remove unportable assumptions about struct layout.
6613 These assumptions hold on all porting targets that I know of, but
6614 they are not guaranteed, they're easy to remove, and removing them
6615 makes further changes easier.
6616
6617 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6618 This doesn't fix a bug but makes the code clearer.
6619 (string_overrun_cookie): Now const. Use initializers that
6620 don't formally overflow signed char, to avoid warnings.
6621 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6622 can cause Emacs to crash when string overrun checking is enabled.
6623 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6624 multiple of sizeof (EMACS_INT); it need not be, if
6625 alignof(EMACS_INT) < sizeof (EMACS_INT).
6626 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6627
6628 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6629
6630 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6631
6632 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6633
6634 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6635 supposed to be handshaking. (Bug#8556)
6636 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6637
6638 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6639
6640 * lisp.h (Qdebug): List symbol.
6641 * eval.c (Qdebug): Restore global linkage.
6642 * keyboard.c (debug-on-event): New variable.
6643 (handle_user_signal): Break into debugger when debug-on-event
6644 matches the current signal symbol.
6645
6646 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6647
6648 * alloc.c (check_sblock, check_string_bytes)
6649 (check_string_free_list): Convert to standard C.
6650
6651 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6652
6653 * w32.c (emacs_gnutls_push): Fix typo.
6654
6655 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6656
6657 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6658 "cast to pointer from integer of different size".
6659
6660 Improve doprnt and its use in verror. (Bug#8545)
6661 * doprnt.c (doprnt): Document the set of format control sequences
6662 supported by the function. Use SAFE_ALLOCA instead of always
6663 using `alloca'.
6664
6665 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6666 is one byte too soon. Don't use xrealloc; instead xfree and
6667 xmalloc anew.
6668
6669 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6670
6671 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6672 callbacks stage.
6673
6674 * gnutls.c: Renamed global_initialized to
6675 gnutls_global_initialized. Added internals for the
6676 :verify-hostname-error, :verify-error, and :verify-flags
6677 parameters of `gnutls-boot' and documented those parameters in the
6678 docstring. Start callback support.
6679 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6680 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6681 on error. Return error code.
6682 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6683 (emacs_gnutls_read): Likewise.
6684 (Fgnutls_boot): Return handshake error code.
6685 (emacs_gnutls_handle_error): New function.
6686 (wsaerror_to_errno): Likewise.
6687
6688 * w32.h (emacs_gnutls_pull): Add prototype.
6689 (emacs_gnutls_push): Likewise.
6690
6691 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6692 (emacs_gnutls_push): Likewise.
6693
6694 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6695
6696 * process.c (wait_reading_process_output): Check if GnuTLS
6697 buffered some data internally if no FDs are set for TLS
6698 connections.
6699
6700 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6701 (LIBS): Link to USER_LIBS.
6702 ($(BLD)/gnutls.$(0)): New target.
6703
6704 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6705
6706 * xdisp.c (handle_single_display_spec): Rename the
6707 display_replaced_before_p argument into display_replaced_p, to
6708 make it consistent with the commentary. Fix typos in the
6709 commentary.
6710
6711 * textprop.c (syms_of_textprop): Remove dead code.
6712 (copy_text_properties): Delete obsolete commentary about an
6713 interface that was deleted long ago. Fix typos in the description
6714 of arguments.
6715
6716 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6717 to changes in oldXMenu/XMenu.h from 2011-04-16.
6718 <menu_help_message, prev_menu_help_message>: Constify.
6719 (IT_menu_make_room): menu->help_text is now `const char **';
6720 adjust.
6721
6722 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6723 to changes in oldXMenu/XMenu.h from 2011-04-16.
6724 (struct XMenu): Declare `help_text' `const char **'.
6725
6726 * xfaces.c <Qunspecified>: Make extern again.
6727
6728 * syntax.c: Include sys/types.h before including regex.h, as
6729 required by Posix.
6730
6731 * doc.c (get_doc_string): Improve the format passed to `error'.
6732
6733 * doprnt.c (doprnt): Improve commentary.
6734
6735 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6736
6737 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6738 them with etags.
6739
6740 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6741 changes in globals.h immediately force recompilation.
6742 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6743 $(CURDIR)/s/ms-w32.h.
6744 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6745
6746 * character.c (Fchar_direction): Function deleted.
6747 (syms_of_character): Don't defsubr it.
6748 <char-direction-table>: Deleted.
6749
6750 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6751
6752 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6753 * doprnt.c: Include limits.h.
6754 (SIZE_MAX): New macro.
6755 (doprnt): Return a size_t value. 2nd arg is now size_t.
6756 Many local variables are now size_t instead of int or unsigned.
6757 Improve overflow protection. Support `l' modifier for integer
6758 conversions. Support %l conversion. Don't assume an EMACS_INT
6759 argument for integer conversions and for %c.
6760
6761 * lisp.h (doprnt): Restore prototype.
6762
6763 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6764 $(SRC)/character.h.
6765
6766 * Makefile.in (base_obj): Add back doprnt.o.
6767
6768 * deps.mk (doprnt.o): Add back prerequisites.
6769 (callint.o): Depend on character.h.
6770
6771 * eval.c (internal_lisp_condition_case): Include the handler
6772 representation in the error message.
6773 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6774 when breaking from the loop.
6775
6776 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6777
6778 * callint.c (Fcall_interactively): When displaying error message
6779 about invalid control letter, pass the character's codepoint, not
6780 a pointer to its multibyte form. Improve display of the character
6781 in octal and display also its hex code.
6782
6783 * character.c (char_string): Use %x to display the (unsigned)
6784 codepoint of an invalid character, to avoid displaying a bogus
6785 negative value.
6786
6787 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6788 `error', not SYMBOL_NAME itself.
6789
6790 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6791 character arguments to `error'.
6792
6793 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6794 to `error' in error message about FINAL_CHAR argument. Make sure
6795 FINAL_CHAR is a character, and use %c when it is passed as
6796 argument to `error'.
6797
6798 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6799
6800 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6801
6802 * w32.c: Include <time.h>.
6803 (sys_localtime): New function.
6804
6805 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6806
6807 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6808
6809 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6810
6811 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6812
6813 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6814 zombies (Bug#8467).
6815
6816 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6817
6818 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6819 gl_state.e_property when gl_state.object is Qt.
6820
6821 * insdel.c (make_gap_larger): Remove limitation of buffer size
6822 to <= INT_MAX.
6823
6824 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6825
6826 * xdisp.c (lookup_glyphless_char_display)
6827 (produce_glyphless_glyph): Handle cons cell entry in
6828 glyphless-char-display.
6829 (Vglyphless_char_display): Document it.
6830
6831 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6832 glyphless-char-display.
6833
6834 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6835
6836 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6837
6838 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6839
6840 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6841 definition for no-X builds.
6842
6843 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6844
6845 Static checks with GCC 4.6.0 and non-default toolkits.
6846
6847 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6848
6849 * process.c (keyboard_bit_set): Define only if SIGIO.
6850 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6851 (send_process): Repair possible setjmp clobbering.
6852
6853 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6854
6855 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6856
6857 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6858
6859 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6860 Define only if needed.
6861
6862 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6863 by pacifying GCC about it. Maybe it's time to retire it?
6864 * xfaces.c (USG, __TIMEVAL__): Likewise.
6865
6866 * dispextern.h (struct redisplay_interface): Rename param
6867 to avoid shadowing.
6868 * termhooks.h (struct terminal): Likewise.
6869 * xterm.c (xembed_send_message): Likewise.
6870
6871 * insdel.c (make_gap_smaller): Define only if
6872 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6873
6874 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6875 it.
6876
6877 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6878 so that we aren't warned about unused symbols.
6879
6880 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6881
6882 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6883
6884 * xfns.c (x_real_positions): Mark locals as initialized.
6885
6886 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6887
6888 * xterm.c: Fix problems found by static analysis with other toolkits.
6889 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6890 (x_dispatch_event): Declare static if USE_GTK, and
6891 define if USE_GTK || USE_X_TOOLKIT.
6892 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6893 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6894 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6895 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6896
6897 * xmenu.c (menu_help_callback): Pointer type fixes.
6898 Use const pointers when pointing at readonly data. Avoid pointer
6899 signedness clashes.
6900 (FALSE): Remove unused macro.
6901 (update_frame_menubar): Remove unused decl.
6902
6903 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6904
6905 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6906 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6907 (single_menu_item): Rename local to avoid shadowing.
6908
6909 * keyboard.c (make_lispy_event): Remove unused local var.
6910
6911 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6912 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6913
6914 * bitmaps: Change bitmaps from unsigned char back to the X11
6915 compatible char. Avoid the old compiler warnings about
6916 out-of-range initializers by using, for example, '\xab' rather
6917 than 0xab.
6918
6919 * xgselect.c (xgselect_initialize): Check vs interface
6920 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6921
6922 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6923
6924 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6925 to read-only memory.
6926
6927 * fns.c (vector): Remove; this old hack is no longer needed.
6928
6929 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6930 Remove unused var.
6931 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6932
6933 * xrdb.c (x_load_resources): Omit unused local.
6934
6935 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6936 (x_window): Rename locals to avoid shadowing.
6937 (USG): Use the kludged USG macro, to pacify gcc.
6938
6939 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6940 (x_term_init): Remove local to avoid shadowing.
6941
6942 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6943
6944 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6945 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6946
6947 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6948
6949 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6950
6951 Fix regex.c, syntax.c and friends for buffers > 2GB.
6952 * syntax.h (struct gl_state_s): Declare character position members
6953 EMACS_INT.
6954
6955 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6956
6957 * textprop.c (verify_interval_modification, interval_of):
6958 Declare arguments EMACS_INT.
6959
6960 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6961 EMACS_INT.
6962
6963 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6964
6965 * indent.c (Fvertical_motion): Local variable it_start is now
6966 EMACS_INT.
6967
6968 * regex.c (re_match, re_match_2, re_match_2_internal)
6969 (bcmp_translate, regcomp, regexec, print_double_string)
6970 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6971 (re_compile_pattern, re_exec): Declare arguments and local
6972 variables `size_t' and `ssize_t' and return values `regoff_t', as
6973 appropriate.
6974 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6975 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6976 <compile_stack_type>: `size' and `avail' are now `size_t'.
6977
6978 * regex.h <regoff_t>: Use ssize_t, not int.
6979 (re_search, re_search_2, re_match, re_match_2): Arguments that
6980 specify buffer/string position and length are now ssize_t and
6981 size_t. Return type is regoff_t.
6982
6983 2011-04-16 Ben Key <bkey76@gmail.com>
6984
6985 * nsfont.m: Fixed bugs in ns_get_family and
6986 ns_descriptor_to_entity that were caused by using free to
6987 deallocate memory blocks that were allocated by xmalloc (via
6988 xstrdup). This caused Emacs to crash when compiled with
6989 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6990 --enable-checking=xmallocoverrun). xfree is now used to
6991 deallocate these memory blocks.
6992
6993 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6994
6995 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6996
6997 emacs_write: Accept and return EMACS_INT for sizes.
6998 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6999 et seq.
7000 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7001 Accept and return EMACS_INT.
7002 (emacs_gnutls_write): Return the number of bytes written on
7003 partial writes.
7004 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7005 (emacs_read, emacs_write): Remove check for negative size, as the
7006 Emacs source code has been audited now.
7007 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7008 (emacs_read, emacs_write): Use it.
7009 * process.c (send_process): Adjust to the new signatures of
7010 emacs_write and emacs_gnutls_write. Do not attempt to store
7011 a byte offset into an 'int'; it might overflow.
7012 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7013
7014 * sound.c: Don't assume sizes fit in 'int'.
7015 (struct sound_device.period_size, alsa_period_size):
7016 Return EMACS_INT, not int.
7017 (struct sound_device.write, vox_write, alsa_write):
7018 Accept EMACS_INT, not int.
7019 (wav_play, au_play): Use EMACS_INT to store sizes and to
7020 record read return values.
7021
7022 2011-04-15 Ben Key <bkey76@gmail.com>
7023
7024 * keyboard.c (Qundefined): Don't declare static since it is used
7025 in nsfns.m.
7026 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7027 static since they are used in nsfont.m.
7028
7029 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7030
7031 * process.c (Qprocessp): Don't declare static.
7032 * lisp.h (Qprocessp): Declare again.
7033
7034 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7035
7036 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7037
7038 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7039
7040 Improve C-level modularity by making more things 'static'.
7041
7042 Don't publish debugger-only interfaces to other modules.
7043 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7044 (verify_bytepos, count_markers): Move decls to the only modules
7045 that need them.
7046 * region-cache.h (pp_cache): Likewise.
7047 * window.h (check_all_windows): Likewise.
7048 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7049
7050 * sysdep.c (croak): Now static, if
7051 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7052 * syssignal.h (croak): Declare only if not static.
7053
7054 * alloc.c (refill_memory_reserve): Now static if
7055 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7056 * lisp.h (refill_memory_reserve): Declare only if not static.
7057
7058 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7059 Define only if USE_LUCID.
7060
7061 * xrdb.c (x_customization_string, x_rm_string): Now static.
7062
7063 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7064 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7065
7066 * xdisp.c (draw_row_with_mouse_face): Now static.
7067 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7068
7069 * window.h (check_all_windows): Mark externally visible.
7070
7071 * window.c (window_deletion_count): Now static.
7072
7073 * undo.c: Make symbols static if they're not exported.
7074 (last_undo_buffer, last_boundary_position, pending_boundary):
7075 Now static.
7076
7077 * textprop.c (interval_insert_behind_hooks): Now static.
7078 (interval_insert_in_front_hooks): Likewise.
7079
7080 * term.c: Make symbols static if they're not exported.
7081 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7082 (max_frame_lines, tty_set_terminal_modes):
7083 (tty_reset_terminal_modes, tty_turn_off_highlight):
7084 (get_tty_terminal): Now static.
7085 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7086 * termhooks.h (term_mouse_moveto): Do not declare if
7087 HAVE_WINDOW_SYSTEM.
7088 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7089 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7090
7091 * sysdep.c: Make symbols static if they're not exported.
7092 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7093 Now static.
7094 (sigprocmask_set, full_mask): Remove; unused.
7095 (wait_debugging): Mark as visible.
7096 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7097 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7098
7099 * syntax.c (syntax_temp): Define only if !__GNUC__.
7100
7101 * sound.c (current_sound_device, current_sound): Now static.
7102
7103 * search.c (searchbufs, searchbuf_head): Now static.
7104
7105 * scroll.c (scroll_cost): Remove; unused.
7106 * dispextern.h (scroll_cost): Remove decl.
7107
7108 * region-cache.h (pp_cache): Mark as externally visible.
7109
7110 * process.c: Make symbols static if they're not exported.
7111 (process_tick, update_tick, create_process, chan_process):
7112 (Vprocess_alist, proc_buffered_char, datagram_access):
7113 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7114 (deactivate_process): Mark defn as static, as well as decl.
7115 * lisp.h (create_process): Remove decl.
7116 * process.h (chan_process, Vprocess_alist): Remove decls.
7117
7118 * print.c: Make symbols static if they're not exported.
7119 (print_depth, new_backquote_output, being_printed, print_buffer):
7120 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7121 (print_interval, print_number_index, initial_stderr_stream):
7122 Now static.
7123 * lisp.h (Fprinc): Remove decl.
7124 (debug_output_compilation_hack): Mark as externally visible.
7125
7126 * sysdep.c (croak): Move decl from here to syssignal.h.
7127 * syssignal.h (croak): Put it here, so the API can be checked when
7128 'croak' is called from dissociate_if_controlling_tty.
7129
7130 * minibuf.c: Make symbols static if they're not exported.
7131 (minibuf_save_list, choose_minibuf_frame): Now static.
7132 * lisp.h (choose_minibuf_frame): Remove decl.
7133
7134 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7135
7136 * lread.c: Make symbols static if they're not exported.
7137 (read_objects, initial_obarray, oblookup_last_bucket_number):
7138 Now static.
7139 (make_symbol): Remove; unused.
7140 * lisp.h (initial_obarray, make_symbol): Remove decls.
7141
7142 * keyboard.c: Make symbols static if they're not exported.
7143 (single_kboard, recent_keys_index, total_keys, recent_keys):
7144 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7145 (this_single_command_key_start, echoing, last_auto_save):
7146 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7147 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7148 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7149 (Vlispy_mouse_stem, double_click_count):
7150 Now static.
7151 (force_auto_save_soon): Define only if SIGDANGER.
7152 (ignore_mouse_drag_p): Now static if
7153 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7154 (print_help): Remove; unused.
7155 (stop_character, last_timer_event): Mark as externally visible.
7156 * keyboard.h (ignore_mouse_drag_p): Declare only if
7157 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7158 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7159 * lisp.h (echoing): Remove decl.
7160 (force_auto_save_soon): Declare only if SIGDANGER.
7161 * xdisp.c (redisplay_window): Simplify code, to make it more
7162 obvious that ignore_mouse_drag_p is not accessed if !defined
7163 USE_GTK && !defined HAVE_NS.
7164
7165 * intervals.c: Make symbols static if they're not exported.
7166 (merge_properties_sticky, merge_interval_right, delete_interval):
7167 Now static.
7168 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7169
7170 * insdel.c: Make symbols static if they're not exported.
7171 However, leave prepare_to_modify_buffer alone. It's never
7172 called from outside this function, but that appears to be a bug.
7173 (combine_after_change_list, combine_after_change_buffer):
7174 (adjust_after_replace, signal_before_change): Now static.
7175 (adjust_after_replace_noundo): Remove; unused.
7176 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7177 (signal_before_change): Remove decls.
7178
7179 * indent.c (val_compute_motion, val_vmotion): Now static.
7180
7181 * image.c: Make symbols static if they're not exported.
7182 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7183 if USE_GTK.
7184 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7185 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7186
7187 * fringe.c (standard_bitmaps): Now static.
7188 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7189
7190 * frame.c: Make symbols static if they're not exported.
7191 (x_report_frame_params, make_terminal_frame): Now static.
7192 (get_frame_param): Now static, unless HAVE_NS.
7193 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7194 (x_get_resource_string): Remove; not used.
7195 * frame.h (make_terminal_frame, x_report_frame_params):
7196 (x_get_resource_string); Remove decls.
7197 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7198 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7199
7200 * font.c, fontset.c: Make symbols static if they're not exported.
7201 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7202 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7203 * font.c (font_close_object): Now static.
7204 * font.h (font_close_object): Remove.
7205 * fontset.c (FONTSET_OBJLIST): Remove.
7206 (free_realized_fontset) #if-0 the body, which does nothing.
7207 (face_suitable_for_char_p): #if-0, as it's never called.
7208 * fontset.h (face_suitable_for_char_p): Remove decl.
7209 * xfaces.c (face_at_string_position):
7210 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7211 since 0 is always ASCII.
7212
7213 * fns.c (weak_hash_tables): Now static.
7214
7215 * fileio.c: Make symbols static if they're not exported.
7216 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7217 (Vwrite_region_annotation_buffers): Now static.
7218
7219 * eval.c: Make symbols static if they're not exported.
7220 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7221 * lisp.h (backtrace_list): Remove decl.
7222
7223 * emacs.c: Make symbols static if they're not exported.
7224 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7225 (fatal_error_code, fatal_error_signal_hook, standard_args):
7226 Now static.
7227 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7228 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7229 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7230 * lisp.h (fatal_error_signal_hook): Remove decl.
7231 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7232
7233 * editfns.c: Move a (normally-unused) function to its only use.
7234 * editfns.c, lisp.h (get_operating_system_release): Remove.
7235 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7236 worth the hassle of breaking this out.
7237
7238 * xterm.c: Make symbols static if they're not exported.
7239 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7240 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7241 (x_destroy_window, x_delete_display):
7242 Now static.
7243 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7244 (x_mouse_leave): Remove; unused.
7245 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7246 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7247 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7248 Remove decls.
7249 (x_mouse_leave): Declare only if WINDOWSNT.
7250 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7251 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7252 USE_X_TOOLKIT.
7253
7254 * ftxfont.c: Make symbols static if they're not exported.
7255 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7256 HAVE_FREETYPE.
7257 * font.h (ftxfont_driver): Likewise.
7258
7259 * xfns.c: Make symbols static if they're not exported.
7260 (x_last_font_name, x_display_info_for_name):
7261 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7262 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7263 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7264 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7265 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7266 (last_show_tip_args): Now static.
7267 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7268 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7269 (x_screen_planes): Remove; unused.
7270 * dispextern.h (x_screen_planes): Remove decl.
7271
7272 * dispnew.c: Make symbols static if they're not exported.
7273 * dispextern.h (redraw_garbaged_frames, scrolling):
7274 (increment_row_positions): Remove.
7275 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7276 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7277 Now static.
7278 (redraw_garbaged_frames): Remove; unused.
7279
7280 * xfaces.c: Make symbols static if they're not exported.
7281 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7282 Remove decls.
7283 * xterm.h (defined_color): Remove decls.
7284 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7285 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7286 (menu_face_changed_default, defined_color, free_realized_face):
7287 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7288 (ascii_face_of_lisp_face): Remove; unused.
7289
7290 * xdisp.c: Make symbols static if they're not exported.
7291 * dispextern.h (scratch_glyph_row, window_box_edges):
7292 (glyph_to_pixel_coords, set_cursor_from_row):
7293 (get_next_display_element, set_iterator_to_next):
7294 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7295 (show_mouse_face): Remove decls
7296 * frame.h (message_buf_print): Likewise.
7297 * lisp.h (pop_message, set_message, check_point_in_composition):
7298 Likewise.
7299 * xterm.h (set_vertical_scroll_bar): Likewise.
7300 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7301 (message_buf_print, scratch_glyph_row, displayed_buffer):
7302 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7303 (get_next_display_element, show_mouse_face, window_box_edges):
7304 (frame_to_window_pixel_xy, check_point_in_composition):
7305 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7306 (glyph_to_pixel_coords): Remove; unused.
7307
7308 * dired.c (file_name_completion): Now static.
7309
7310 * dbusbind.c (xd_in_read_queued_messages): Now static.
7311
7312 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7313 * data.c (circular_list_error): Remove.
7314
7315 * commands.h (last_point_position, last_point_position_buffer):
7316 (last_point_position_window): Remove decls.
7317 * keyboard.c: Make these variables static.
7318
7319 * coding.h (coding, code_convert_region, encode_coding_gap):
7320 Remove decls.
7321 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7322 (iso_code_class, detect_coding, code_convert_region): Now static.
7323 (encode_coding_gap): Remove; unused.
7324
7325 * chartab.c (chartab_chars, chartab_bits): Now static.
7326
7327 * charset.h (charset_iso_8859_1): Remove decl.
7328 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7329 Now static.
7330
7331 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7332 * ccl.c (Vccl_program_table): Now static.
7333 (check_ccl_update): Remove; unused.
7334
7335 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7336 * category.h: ... from here.
7337 * category.c (check_category_table, set_category_set): Now static.
7338
7339 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7340 * lisp.h: Remove these decls.
7341
7342 * buffer.c (buffer_count): Remove unused var.
7343
7344 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7345 so that it's not optimized away.
7346 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7347 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7348 exported only to the debugger.
7349
7350 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7351 * atimer.h (run_all_atimers): Remove; not exported.
7352
7353 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7354 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7355 was inaccessible from Lisp.
7356 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7357 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7358
7359 alloc.c: Import and export fewer symbols, and remove unused items.
7360 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7361 is defined.
7362 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7363 it's not optimized away by whole-program optimization.
7364 (message_enable_multibyte, free_misc): Remove.
7365 (catchlist, handlerlist, mark_backtrace):
7366 Declare only if BYTE_MARK_STACK.
7367 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7368 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7369 (message_enable_multibyte): Remove decl.
7370 (free_misc, interval_free_list, float_block, float_block_index):
7371 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7372 (cons_free_list, last_marked_index):
7373 Now static.
7374 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7375 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7376 (mark_backtrace): Define only if BYTE_MARK_STACK.
7377 * xdisp.c (message_enable_multibyte): Now static.
7378
7379 Declare Lisp_Object Q* variables to be 'static' if not exported.
7380 This makes it easier for human readers (and static analyzers)
7381 to see whether these variables are used from other modules.
7382 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7383 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7384 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7385 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7386 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7387 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7388 * xmenu.c, xselect.c:
7389 Declare Q* vars static if they are not used in other modules.
7390 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7391 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7392 Remove decls of unexported vars.
7393 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7394
7395 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7396
7397 Make Emacs functions such as Fatom 'static' by default.
7398 This makes it easier for human readers (and static analyzers)
7399 to see whether these functions can be called from other modules.
7400 DEFUN now defines a static function. To make the function external
7401 so that it can be used in other C modules, use the new macro DEFUE.
7402 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7403 (Finit_image_library):
7404 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7405 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7406 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7407 Remove decls, since these functions are now static.
7408 (Funintern, Fget_internal_run_time): New decls, since these functions
7409 were already external.
7410
7411 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7412 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7413 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7414 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7415 * keyboard.c, keymap.c, lread.c:
7416 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7417 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7418 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7419 Mark functions with DEFUE instead of DEFUN,
7420 if they are used in other modules.
7421 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7422 decls for now-static functions.
7423 * buffer.h (Fdelete_overlay): Remove decl.
7424 * callproc.c (Fgetenv_internal): Mark as internal.
7425 * composite.c (Fremove_list_of_text_properties): Remove decl.
7426 (Fcomposition_get_gstring): New forward static decl.
7427 * composite.h (Fcomposite_get_gstring): Remove decl.
7428 * dired.c (Ffile_attributes): New forward static decl.
7429 * doc.c (Fdocumntation_property): New forward static decl.
7430 * eval.c (Ffetch_bytecode): New forward static decl.
7431 (Funintern): Remove extern decl; now in .h file where it belongs.
7432 * fileio.c (Fmake_symbolic_link): New forward static decl.
7433 * image.c (Finit_image_library): New forward static decl.
7434 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7435 * intervals.h (Fprevious_property_change):
7436 (Fremove_list_of_text_properties): Remove decls.
7437 * keyboard.c (Fthis_command_keys): Remove decl.
7438 (Fcommand_execute): New forward static decl.
7439 * keymap.c (Flookup_key): New forward static decl.
7440 (Fcopy_keymap): Now static.
7441 * keymap.h (Flookup_key): Remove decl.
7442 * process.c (Fget_process): New forward static decl.
7443 (Fprocess_datagram_address): Mark as internal.
7444 * syntax.c (Fsyntax_table_p): New forward static decl.
7445 (skip_chars): Remove duplicate decl.
7446 * textprop.c (Fprevious_property_change): New forward static decl.
7447 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7448 Now internal.
7449 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7450 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7451
7452 * editfns.c (Fformat): Remove unreachable code.
7453
7454 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7455
7456 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7457 change. (Bug#8496)
7458
7459 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7460
7461 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7462 when at ZV. (Bug#8487)
7463
7464 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7465
7466 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7467 (Bug#8437)
7468 * keyboard.c (parse_tool_bar_item): Likewise.
7469 * sound.c (sound_cleanup, alsa_close): Likewise.
7470 * termcap.c (tgetent): Likewise.
7471 * xfns.c (x_default_font_parameter): Likewise.
7472 * xsettings.c (read_and_apply_settings): Likewise.
7473
7474 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7475 (overrun_check_free): Protoize.
7476
7477 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7478
7479 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7480 since callers should never pass a negative size.
7481 Change the signature to match that of plain 'read' and 'write'; see
7482 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7483 * lisp.h: Update prototypes of emacs_write and emacs_read.
7484
7485 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7486
7487 * xdisp.c (redisplay_window): Don't try to determine the character
7488 position of the scroll margin if the window start point w->startp
7489 is outside the buffer's accessible region. (Bug#8468)
7490
7491 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7492
7493 Fix write-region and its subroutines for buffers > 2GB.
7494 * fileio.c (a_write, e_write): Modify declaration of arguments and
7495 local variables to support buffers larger than 2GB.
7496 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7497
7498 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7499 argument, local variables, and return value.
7500
7501 * lisp.h: Update prototypes of emacs_write and emacs_read.
7502
7503 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7504
7505 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7506
7507 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7508
7509 Fix more problems found by GCC 4.6.0's static checks.
7510
7511 * xdisp.c (vmessage): Use a better test for character truncation.
7512
7513 * charset.c (load_charset_map): <, not <=, for optimization,
7514 and to avoid potential problems with integer overflow.
7515 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7516 * casetab.c (set_identity, shuffle): Likewise.
7517 * editfns.c (Fformat): Likewise.
7518 * syntax.c (skip_chars): Likewise.
7519
7520 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7521 This also lets GCC 4.6.0 generate slightly better loop code.
7522
7523 * callint.c (Fcall_interactively): <, not <=, for optimization.
7524 (Fcall_interactively): Count the number of arguments produced,
7525 not the number of arguments given. This is simpler and lets GCC
7526 4.6.0 generate slightly better code.
7527
7528 * ftfont.c: Distingish more carefully between FcChar8 and char.
7529 The previous code passed unsigned char * to a functions like
7530 strlen and xstrcasecmp that expect char *, which does not
7531 conform to the C standard.
7532 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7533 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7534 char * when the C standard requires it.
7535
7536 * keyboard.c (read_char): Remove unused var.
7537
7538 * eval.c: Port to Windows vsnprintf (Bug#8435).
7539 Include <limits.h>.
7540 (SIZE_MAX): Define if the headers do not.
7541 (verror): Do not give up if vsnprintf returns a negative count.
7542 Instead, grow the buffer. This ports to Windows vsnprintf, which
7543 does not conform to C99. Problem reported by Eli Zaretskii.
7544 Also, simplify the allocation scheme, by avoiding the need for
7545 calling realloc, and removing the ALLOCATED variable.
7546
7547 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7548
7549 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7550 But keep the doprint source code for now, as we might revamp it
7551 and use it again (Bug#8435).
7552 * lisp.h (doprnt): Remove.
7553 * Makefile.in (base_obj): Remove doprnt.o.
7554 * deps.mk (doprnt.o): Remove.
7555
7556 error: Print 32- and 64-bit integers portably (Bug#8435).
7557 Without this change, on typical 64-bit hosts error ("...%d...", N)
7558 was used to print both 32- and 64-bit integers N, which relied on
7559 undefined behavior.
7560 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7561 New macro.
7562 * lisp.h (error, verror): Mark as printf-like functions.
7563 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7564 Report overflow in size calculations when allocating printf buffer.
7565 Do not truncate output string at its first null byte.
7566 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7567 Truncate the output at a character boundary, since vsnprintf does not
7568 do that.
7569 * charset.c (check_iso_charset_parameter): Convert internal
7570 character to string before calling 'error', since %c now has the
7571 printf meaning.
7572 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7573 overflow when computing char to be passed to 'error'. Do not
7574 pass Lisp_Object to 'error'; pass the integer instead.
7575 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7576 formatted with plain %d.
7577
7578 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7579
7580 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7581
7582 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7583
7584 * xterm.c (x_catch_errors): Remove duplicate declaration.
7585
7586 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7587
7588 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7589
7590 2011-04-10 Jim Meyering <meyering@redhat.com>
7591
7592 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7593 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7594 return ssize_t not "int", and use size_t as the buffer length.
7595 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7596 * gnutls.h: Update declarations.
7597 * process.c (read_process_output): Use ssize_t, to match.
7598 (send_process): Likewise.
7599
7600 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7601
7602 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7603
7604 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7605
7606 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7607 Use unsigned char, to match FcChar8 type definition.
7608
7609 * xterm.c (handle_one_xevent):
7610 * xmenu.c (create_and_show_popup_menu):
7611 * xselect.c (x_decline_selection_request)
7612 (x_reply_selection_request): Avoid type-punned deref of X events.
7613
7614 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7615
7616 Fix some uses of `int' instead of EMACS_INT.
7617 * search.c (string_match_1, fast_string_match)
7618 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7619 (scan_buffer, find_next_newline_no_quit)
7620 (find_before_next_newline, search_command, Freplace_match)
7621 (Fmatch_data): Make some `int' variables be EMACS_INT.
7622
7623 * xdisp.c (display_count_lines): 3rd argument and return value now
7624 EMACS_INT. All callers changed.
7625 (pint2hrstr): Last argument is now EMACS_INT.
7626
7627 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7628 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7629 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7630 (decode_coding_utf_16, decode_coding_emacs_mule)
7631 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7632 (decode_coding_ccl, decode_coding_charset)
7633 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7634 (decode_coding_iso_2022, decode_coding_emacs_mule)
7635 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7636 <char_offset, last_offset>: Declare EMACS_INT.
7637 (encode_coding_utf_8, encode_coding_utf_16)
7638 (encode_coding_emacs_mule, encode_invocation_designation)
7639 (encode_designation_at_bol, encode_coding_iso_2022)
7640 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7641 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7642 Declare EMACS_INT.
7643 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7644 (encode_invocation_designation): Last argument P_NCHARS is now
7645 EMACS_INT.
7646 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7647 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7648
7649 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7650 All users changed.
7651
7652 * ccl.c (Fccl_execute_on_string): Declare some variables
7653 EMACS_INT.
7654
7655 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7656
7657 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7658
7659 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7660
7661 * process.c (Fformat_network_address): Doc fix.
7662
7663 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7664
7665 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7666
7667 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7668
7669 * keyboard.c (read_char): Call Lisp function help-form-show,
7670 instead of using internal_with_output_to_temp_buffer.
7671 (Qhelp_form_show): New var.
7672 (syms_of_keyboard): Use DEFSYM macro.
7673
7674 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7675
7676 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7677
7678 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7679
7680 * process.c (Flist_processes): Remove to Lisp.
7681 (list_processes_1): Delete.
7682
7683 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7684
7685 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7686
7687 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7688
7689 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7690
7691 Fix more problems found by GCC 4.6.0's static checks.
7692
7693 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7694
7695 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7696
7697 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7698
7699 * xdisp.c (vmessage): Mark as a printf-like function.
7700
7701 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7702
7703 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7704
7705 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7706 printf-like functions.
7707 (tiff_load): Add casts to remove these marks before passing them
7708 to system-supplied API.
7709
7710 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7711
7712 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7713 This avoids several warnings with gcc -Wstrict-overflow.
7714 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7715 directly, rather than having caller test rule sign. This avoids
7716 some unnecessary tests.
7717 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7718 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7719 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7720
7721 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7722 (xfont_open): Avoid unnecessary tests.
7723
7724 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7725
7726 * composite.h, composite.c (composition_gstring_put_cache):
7727 Use EMACS_INT, not int, for length.
7728
7729 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7730 breaking out part of COMPOSITION_DECODE_RULE.
7731 (COMPOSITION_DECODE_RULE): Use it.
7732 * composite.c (get_composition_id): Remove unused local vars,
7733 by using the new macro.
7734
7735 * textprop.c (set_text_properties_1): Change while to do-while,
7736 since the condition is always true at first.
7737
7738 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7739 (interval_deletion_adjustment): Return unsigned value.
7740 All uses changed.
7741
7742 * process.c (list_processes_1, create_pty, read_process_output):
7743 (exec_sentinel): Remove vars that were set but not used.
7744 (create_pty): Remove unnecessary "volatile"s.
7745 (Fnetwork_interface_info): Avoid possibility of int overflow.
7746 (read_process_output): Do adaptive read buffering even if carryover.
7747 (read_process_output): Simplify nbytes computation if buffered.
7748
7749 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7750
7751 * syntax.c (scan_words): Remove var that was set but not used.
7752 (update_syntax_table): Use unsigned instead of int.
7753
7754 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7755 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7756 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7757
7758 * print.c (print_error_message): Avoid int overflow.
7759
7760 * font.c (font_list_entities): Redo for clarity,
7761 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7762
7763 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7764 (font_score): Avoid potential overflow in diff calculation.
7765
7766 * fns.c (substring_both): Remove var that is set but not used.
7767 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7768
7769 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7770
7771 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7772 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7773 can always succeed if overflow has undefined behavior.
7774
7775 * search.c (boyer_moore, wordify): Remove vars set but not used.
7776 (wordify): Omit three unnecessary tests.
7777
7778 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7779 All callers changed. This avoids the need for an unused var.
7780
7781 * casefiddle.c (casify_region): Remove var that is set but not used.
7782
7783 * dired.c (file_name_completion): Remove var that is set but not used.
7784
7785 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7786
7787 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7788 (Finsert_file_contents): Remove unnecessary code checking fd.
7789
7790 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7791 Check for integer overflow on size calculations.
7792
7793 * buffer.c (Fprevious_overlay_change): Remove var that is set
7794 but not used.
7795
7796 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7797 Remove vars that are set but not used.
7798 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7799 (timer_check_2): Mark vars as initialized.
7800
7801 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7802
7803 * image.c (lookup_image): Remove var that is set but not used.
7804 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7805
7806 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7807 that are set but not used.
7808
7809 * xfns.c (make_invisible_cursor): Don't return garbage
7810 if XCreateBitmapFromData fails (Bug#8410).
7811
7812 * xselect.c (x_get_local_selection, x_handle_property_notify):
7813 Remove vars that are set but not used.
7814
7815 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7816 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7817
7818 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7819 Remove var that is set but not used.
7820 (scroll_bar_windows_size): Now size_t, not int.
7821 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7822 Check for overflow.
7823
7824 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7825 (map_tty_color) [!defined MSDOS]: Likewise.
7826
7827 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7828
7829 * coding.c: Remove vars that are set but not used.
7830 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7831 All callers changed.
7832 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7833 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7834 (decode_coding_charset): Remove vars that are set but not used.
7835
7836 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7837 that is set but not used.
7838
7839 * print.c (print_object): Remove var that is set but not used.
7840
7841 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7842 The gnulib version avoids calling malloc in the usual case,
7843 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7844 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7845 * filelock.c (current_lock_owner): Likewise.
7846 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7847 * sysdep.c: Include allocator.h, careadlinkat.h.
7848 (emacs_no_realloc_allocator): New static constant.
7849 (emacs_readlink): New function.
7850 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7851 ../lib/careadlinkat.h.
7852
7853 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7854
7855 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7856 first non-nil return value).
7857
7858 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7859
7860 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7861 if not defined (Bug#8403).
7862
7863 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7864
7865 * xdisp.c (display_count_lines): Remove parameter `start',
7866 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7867 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7868 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7869 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7870 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7871 and thereabouts. All callers changed.
7872 (get_per_char_metric): Remove parameter `f', unused since
7873 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7874
7875 2011-04-02 Jim Meyering <meyering@redhat.com>
7876
7877 do not dereference NULL upon failed strdup
7878 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7879 (ns_get_family): Likewise.
7880
7881 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7882
7883 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7884
7885 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7886
7887 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7888 later (Bug#8403).
7889
7890 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7891
7892 Add lexical binding.
7893
7894 * window.c (Ftemp_output_buffer_show): New fun.
7895 (Fsave_window_excursion):
7896 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7897
7898 * lread.c (lisp_file_lexically_bound_p): New function.
7899 (Fload): Bind Qlexical_binding.
7900 (readevalloop): Remove `evalfun' arg.
7901 Bind Qinternal_interpreter_environment.
7902 (Feval_buffer): Bind Qlexical_binding.
7903 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7904 Mark as dynamic.
7905 (syms_of_lread): Declare `lexical-binding'.
7906
7907 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7908
7909 * keyboard.c (eval_dyn): New fun.
7910 (menu_item_eval_property): Use it.
7911
7912 * image.c (parse_image_spec): Use Ffunctionp.
7913
7914 * fns.c (concat, mapcar1): Accept byte-code-functions.
7915
7916 * eval.c (Fsetq): Handle lexical vars.
7917 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7918 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7919 (FletX, Flet): Obey lexical binding.
7920 (Fcommandp): Handle closures.
7921 (Feval): New `lexical' arg.
7922 (eval_sub): New function extracted from Feval. Use it almost
7923 everywhere where Feval was used. Look up vars in lexical env.
7924 Handle closures.
7925 (Ffunctionp): Move from subr.el.
7926 (Ffuncall): Handle closures.
7927 (apply_lambda): Remove `eval_flags'.
7928 (funcall_lambda): Handle closures and new byte-code-functions.
7929 (Fspecial_variable_p): New function.
7930 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7931 but without exporting it to Lisp.
7932
7933 * doc.c (Fdocumentation, store_function_docstring):
7934 * data.c (Finteractive_form): Handle closures.
7935
7936 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7937 interactive spec.
7938
7939 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7940 New byte-codes.
7941 (exec_byte_code): New function extracted from Fbyte_code to handle new
7942 calling convention for byte-code-functions. Add new byte-codes.
7943
7944 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7945
7946 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7947
7948 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7949
7950 * xdisp.c (redisplay_internal): Fix prototype.
7951
7952 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7953
7954 * xdisp.c (SCROLL_LIMIT): New macro.
7955 (try_scrolling): Use it when setting scroll_limit.
7956 Limit scrolling to 100 screen lines.
7957 (redisplay_window): Even when falling back on "recentering",
7958 position point in the window according to scroll-conservatively,
7959 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7960
7961 (try_scrolling): When point is above the window, allow searching
7962 as far as scroll_max, or one screenful, to compute vertical
7963 distance from PT to the scroll margin position. This prevents
7964 try_scrolling from unnecessarily failing when
7965 scroll-conservatively is set to a value slightly larger than the
7966 window height. Clean up the case of PT below the margin at bottom
7967 of window: scroll_max can no longer be INT_MAX. When aggressive
7968 scrolling is in use, don't let point enter the opposite scroll
7969 margin as result of the scroll.
7970 (syms_of_xdisp) <scroll-conservatively>: Document the
7971 threshold of 100 lines for never-recentering scrolling.
7972
7973 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7974
7975 * dispextern.h (move_it_by_lines):
7976 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7977 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7978 (message_log_check_duplicate): Remove parameters `prev_bol' and
7979 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7980 (redisplay_internal): Remove parameter `preserve_echo_area',
7981 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7982
7983 * indent.c (Fvertical_motion):
7984 * window.c (window_scroll_pixel_based, Frecenter):
7985 Don't pass `need_y_p' to `move_it_by_lines'.
7986
7987 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7988
7989 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7990 steal a few bits to be more compact.
7991 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7992 Remove unneeded casts.
7993
7994 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7995
7996 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7997
7998 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7999 binding" message (bug#7967).
8000
8001 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8002
8003 Fix more problems found by GCC 4.6.0's static checks.
8004
8005 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8006 Remove unused local var.
8007
8008 * editfns.c (Fmessage_box): Remove unused local var.
8009
8010 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8011 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8012 Omit unused local vars.
8013 * window.c (shrink_windows): Omit unused local var.
8014 * menu.c (digest_single_submenu): Omit unused local var.
8015 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8016 Omit unused local var.
8017
8018 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8019 Don't assume string length fits in int.
8020 (keyremap_step, read_key_sequence): Use size_t for sizes.
8021 (read_key_sequence): Don't check last_real_key_start redundantly.
8022
8023 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8024 instead of alloca (Bug#8344).
8025
8026 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8027 (Fbacktrace_frame): Don't assume nframes fits in int.
8028
8029 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8030
8031 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8032 concerns.
8033
8034 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8035
8036 * cm.c (calccost): Turn while-do into do-while, for clarity.
8037
8038 * keyboard.c (syms_of_keyboard): Use the same style as later
8039 in this function when indexing through an array. This also
8040 works around GCC bug 48267.
8041
8042 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8043
8044 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8045
8046 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8047 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8048
8049 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8050 This avoids undefined behavior on integer overflow, and is a bit
8051 more convenient anyway since it is compared to a size_t variable.
8052
8053 Variadic C functions now count arguments with size_t, not int.
8054 This avoids an unnecessary limitation on 64-bit machines, which
8055 caused (substring ...) to crash on large vectors (Bug#8344).
8056 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8057 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8058 All variadic functions and their callers changed accordingly.
8059 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8060 * data.c (arith_driver, float_arith_driver): Likewise.
8061 * editfns.c (general_insert_function): Likewise.
8062 * eval.c (struct backtrace.nargs, interactive_p)
8063 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8064 (funcall_lambda, mark_backtrace): Likewise.
8065 * fns.c (concat): Likewise.
8066 * frame.c (x_set_frame_parameters): Likewise.
8067 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8068 0 if not found, not -1. All callers changed.
8069
8070 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8071 (stack_copy_size): Now size_t, not int.
8072 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8073
8074 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8075
8076 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8077 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8078 All callers changed.
8079
8080 * lisp.h (multibyte_char_to_unibyte):
8081 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8082 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8083 * character.h (CHAR_TO_BYTE8):
8084 * cmds.c (internal_self_insert):
8085 * editfns.c (general_insert_function):
8086 * keymap.c (push_key_description):
8087 * search.c (Freplace_match):
8088 * xdisp.c (message_dolog, set_message_1): All callers changed.
8089
8090 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8091
8092 * keyboard.c (safe_run_hook_funcall): New function.
8093 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8094 don't set the hook to nil, but remove the offending function instead.
8095 (Qcommand_hook_internal): Remove, unused.
8096 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8097 Vcommand_hook_internal.
8098
8099 * eval.c (enum run_hooks_condition): Remove.
8100 (funcall_nil, funcall_not): New functions.
8101 (run_hook_with_args): Call each function through a `funcall' argument.
8102 Remove `cond' argument, now redundant.
8103 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8104 (Frun_hook_with_args_until_failure): Adjust accordingly.
8105 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8106
8107 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8108
8109 * dispextern.h (string_buffer_position): Remove declaration.
8110
8111 * print.c (strout): Remove parameter `multibyte', unused since
8112 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8113
8114 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8115 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8116 All callers changed.
8117
8118 * w32.c (_wsa_errlist): Use braces for struct initializers.
8119
8120 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8121 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8122 All callers changed.
8123 (string_buffer_position): Likewise. Also, make static (it's never
8124 used outside xdisp.c).
8125 (cursor_row_p): Remove parameter `w', unused since
8126 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8127 (decode_mode_spec): Remove parameter `precision', introduced during
8128 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8129 All callers changed.
8130
8131 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8132
8133 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8134
8135 2011-03-27 Anders Lindgren <andlind@gmail.com>
8136
8137 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8138 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8139 (ns_update_auto_hide_menu_bar): New functions.
8140 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8141 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8142 ns_constrain_all_frames.
8143 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8144 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8145
8146 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8147
8148 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8149
8150 2011-03-27 Glenn Morris <rgm@gnu.org>
8151
8152 * syssignal.h: Replace RETSIGTYPE with void.
8153 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8154 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8155 Replace SIGTYPE with void everywhere.
8156 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8157 * s/template.h (SIGTYPE): Remove commented out definition.
8158
8159 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8160
8161 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8162 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8163
8164 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8165
8166 * w32.c (read_unc_volume): Use parameter `henum', instead of
8167 global variable `wget_enum_handle'.
8168
8169 * keymap.c (describe_vector): Remove parameters `indices' and
8170 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8171 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8172
8173 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8174
8175 * keyboard.c (timer_check): Remove parameter `do_it_now',
8176 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8177 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8178 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8179
8180 * keyboard.c (read_char):
8181 * w32menu.c (w32_menu_display_help):
8182 * xmenu.c (show_help_event, menu_help_callback):
8183 Adjust calls to `show_help_echo'.
8184
8185 * gtkutil.c (xg_maybe_add_timer):
8186 * keyboard.c (readable_events):
8187 * process.c (wait_reading_process_output):
8188 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8189
8190 * insdel.c (adjust_markers_gap_motion):
8191 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8192 (gap_left, gap_right): Don't call it.
8193
8194 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8195
8196 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8197 incurred during fontification.
8198
8199 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8200
8201 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8202 (DEFVAR_PER_BUFFER): Don't pass it.
8203
8204 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8205 (scrolling_window): Don't pass it.
8206
8207 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8208
8209 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8210
8211 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8212 and `suffix'.
8213 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8214 of variables specific to SELinux and computation of `encoded_absname'.
8215
8216 * image.c (XPutPixel): Remove unused variable `height'.
8217
8218 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8219
8220 * unexw32.c (get_section_info): Remove unused variable `section'.
8221
8222 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8223 (system_process_attributes): Remove unused variable `sess'.
8224 (sys_read): Remove unused variable `err'.
8225
8226 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8227 (w32_wnd_proc): Remove unused variable `isdead'.
8228 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8229 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8230 (x_create_tip_frame): Remove unused variable `tem'.
8231
8232 * w32inevt.c (w32_console_read_socket):
8233 Remove unused variable `no_events'.
8234
8235 * w32term.c (x_draw_composite_glyph_string_foreground):
8236 Remove unused variable `width'.
8237
8238 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8239
8240 * w32term.c (x_set_glyph_string_clipping):
8241 Don't pass uninitialized region to CombineRgn.
8242
8243 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8244
8245 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8246 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8247 (Fx_close_connection): Remove unused variable `i'.
8248
8249 * w32font.c (w32font_draw): Return number of glyphs.
8250 (w32font_open_internal): Remove unused variable `i'.
8251 (w32font_driver): Add missing initializer.
8252
8253 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8254 (fill_in_menu): Remove unused variable `items_added'.
8255
8256 * w32term.c (last_mouse_press_frame): Remove static global variable.
8257 (w32_clip_to_row): Remove unused variable `f'.
8258 (x_delete_terminal): Remove unused variable `i'.
8259
8260 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8261 (NOTHING): Remove unused static global variable.
8262 (uniscribe_check_otf): Remove unused variable `table'.
8263 (uniscribe_font_driver): Add missing initializers.
8264
8265 2011-03-23 Julien Danjou <julien@danjou.info>
8266
8267 * term.c (Fsuspend_tty, Fresume_tty):
8268 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8269 * window.c (temp_output_buffer_show):
8270 * insdel.c (signal_before_change):
8271 * frame.c (Fhandle_switch_frame):
8272 * fileio.c (Fdo_auto_save):
8273 * emacs.c (Fkill_emacs):
8274 * editfns.c (save_excursion_restore):
8275 * cmds.c (internal_self_insert):
8276 * callint.c (Fcall_interactively):
8277 * buffer.c (Fkill_all_local_variables):
8278 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8279 Use Frun_hooks.
8280 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8281 unconditionally since it does the check itself.
8282
8283 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8284
8285 Fix more problems found by GCC 4.5.2's static checks.
8286
8287 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8288 the first time through the loop, since we know p0 < p1 then.
8289 This also avoids a gcc -Wstrict-overflow warning.
8290
8291 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8292 leading to a memory leak, possible in functions like
8293 load_charset_map_from_file that can allocate an unbounded number
8294 of objects (Bug#8318).
8295
8296 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8297 that could (at least in theory) be that large.
8298
8299 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8300 This is less likely to overflow, and avoids undefined behavior if
8301 overflow does occur. All callers changed. Use strtoul to scan
8302 for the unsigned long integer.
8303 (pint2hrstr): Simplify and tune code slightly.
8304 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8305
8306 * scroll.c (do_scrolling): Work around GCC bug 48228.
8307 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8308
8309 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8310 This also avoids a warning with gcc -Wstrict-overflow.
8311 (validate_x_resource_name): Simplify count usage.
8312 This also avoids a warning with gcc -Wstrict-overflow.
8313
8314 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8315 fail (Bug#8306).
8316
8317 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8318
8319 * process.c (Fmake_network_process): Use socklen_t, not int,
8320 where POSIX says socklen_t is required in portable programs.
8321 This fixes a porting bug on hosts like 64-bit HP-UX, where
8322 socklen_t is wider than int (Bug#8277).
8323 (Fmake_network_process, server_accept_connection):
8324 (wait_reading_process_output, read_process_output):
8325 Likewise.
8326
8327 * process.c: Rename or move locals to avoid shadowing.
8328 (list_processes_1, Fmake_network_process):
8329 (read_process_output_error_handler, exec_sentinel_error_handler):
8330 Rename or move locals.
8331 (Fmake_network_process): Define label "retry_connect" only if needed.
8332 (Fnetwork_interface_info): Fix pointer signedness.
8333 (process_send_signal): Add cast to avoid pointer signedness problem.
8334 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8335 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8336
8337 Make tparam.h and terminfo.c consistent.
8338 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8339 Include tparam.h instead, since it declares them.
8340 * cm.h (PC): Remove extern decl; tparam.h now does this.
8341 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8342 * terminfo.c: Include tparam.h, to check interfaces.
8343 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8344 (tparam): Adjust signature to match interface in tparam.h;
8345 this removes some undefined behavior. Check that outstring and len
8346 are zero, which they always are with Emacs.
8347 * tparam.h (PC, BC, UP): New extern decls.
8348
8349 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8350 (xftfont_open): Rename locals to avoid shadowing.
8351
8352 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8353 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8354 (OTF_TAG_SYM): Omit macro if not needed.
8355 (ftfont_list): Remove unused local.
8356 (get_adstyle_property, ftfont_pattern_entity):
8357 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8358 Rename locals to avoid shadowing.
8359
8360 * xfont.c (xfont_list_family): Mark var as initialized.
8361
8362 * xml.c (make_dom): Now static.
8363
8364 * composite.c (composition_compute_stop_pos): Rename local to
8365 avoid shadowing.
8366 (composition_reseat_it): Remove unused locals.
8367 (find_automatic_composition, composition_adjust_point): Likewise.
8368 (composition_update_it): Mark var as initialized.
8369 (find_automatic_composition): Mark vars as initialized,
8370 with a FIXME (Bug#8290).
8371
8372 character.h: Rename locals to avoid shadowing.
8373 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8374 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8375 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8376 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8377 to avoid shadowing.
8378
8379 * textprop.c (property_change_between_p): Remove; unused.
8380
8381 * intervals.c (interval_start_pos): Now static.
8382
8383 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8384
8385 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8386 Rename locals to avoid shadowing.
8387
8388 * sound.c (wav_play, au_play, Fplay_sound_internal):
8389 Fix pointer signedness.
8390 (alsa_choose_format): Remove unused local var.
8391 (wav_play): Initialize a variable to 0, to prevent undefined
8392 behavior (Bug#8278).
8393
8394 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8395
8396 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8397
8398 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8399 clobbering (Bug#8298).
8400 * sysdep.c (sys_subshell): Likewise.
8401 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8402
8403 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8404 This should get cleaned up, so that child_setup has the
8405 same signature on all platforms.
8406
8407 * callproc.c (call_process_cleanup): Now static.
8408 (relocate_fd): Rename locals to avoid shadowing.
8409
8410 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8411
8412 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8413 not to be necessary, and produces flickering.
8414
8415 2011-03-20 Glenn Morris <rgm@gnu.org>
8416
8417 * config.in: Remove file.
8418
8419 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8420
8421 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8422 are now in src/globals.h.
8423 (syms_of_minibuf): Remove spurious & from previous change.
8424
8425 2011-03-20 Leo Liu <sdl.web@gmail.com>
8426
8427 * minibuf.c (completing-read-function): New variable.
8428 (completing-read-default): Rename from completing-read.
8429 (completing-read): Call completing-read-function.
8430
8431 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8432
8433 * xfaces.c (Fx_load_color_file):
8434 Read color file from absolute filename (bug#8250).
8435
8436 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8437
8438 * makefile.w32-in: Update dependencies.
8439
8440 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8441
8442 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8443
8444 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8445
8446 Fix more problems found by GCC 4.5.2's static checks.
8447
8448 * process.c (make_serial_process_unwind, send_process_trap):
8449 (sigchld_handler): Now static.
8450
8451 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8452 That way, the code declares only the vars that it needs.
8453 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8454 * s/cygwin.h (PTY_ITERATION): Likewise.
8455 * s/darwin.h (PTY_ITERATION): Likewise.
8456 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8457
8458 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8459 * process.c (allocate_pty): Don't declare stb unless it's needed.
8460
8461 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8462 (CONSTANTLIM): Remove; unused.
8463 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8464 Define only if needed.
8465
8466 * unexelf.c (unexec): Name an expression,
8467 to avoid gcc -Wbad-function-cast warning.
8468 Use a different way to cause a compilation error if anyone uses
8469 n rather than nn, a way that does not involve shadowing.
8470 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8471
8472 * deps.mk (unexalpha.o): Remove; unused.
8473
8474 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8475 * unexec.h: New file.
8476 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8477 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8478 Depend on unexec.h.
8479 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8480 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8481 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8482 Change as necessary to match prototype in unexec.h.
8483
8484 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8485 shadowing.
8486 (back_comment, skip_chars): Mark vars as initialized.
8487
8488 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8489 Rename locals to avoid shadowing.
8490
8491 * lread.c (read1): Rewrite so as not to use empty "else".
8492 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8493
8494 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8495
8496 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8497 warning when compiling print.c.
8498
8499 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8500 instead of using an uninitialized var.
8501 (font_sort_entities): Mark var as initialized.
8502
8503 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8504
8505 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8506 pointers to constants.
8507 (font_parse_fcname): Remove unused vars.
8508 (font_delete_unmatched): Now static.
8509 (font_get_spec): Remove; unused.
8510 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8511 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8512 Rename or move locals to avoid shadowing.
8513
8514 * fns.c (require_nesting_list, require_unwind): Now static.
8515 (Ffillarray): Rename locals to avoid shadowing.
8516
8517 * floatfns.c (domain_error2): Define only if needed.
8518 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8519
8520 * alloc.c (mark_backtrace): Move decl from here ...
8521 * lisp.h: ... to here, so that it can be checked.
8522
8523 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8524 (Fdefvar): Rewrite so as not to use empty "else".
8525 (lisp_indirect_variable): Name an expression,
8526 to avoid gcc -Wbad-function-cast warning.
8527 (Fdefvar): Rename locals to avoid shadowing.
8528
8529 * callint.c (quotify_arg, quotify_args): Now static.
8530 (Fcall_interactively): Rename locals to avoid shadowing.
8531 Use const pointer when appropriate.
8532
8533 * lisp.h (get_system_name, get_operating_system_release):
8534 Move decls here, to check interfaces.
8535 * process.c (get_operating_system_release): Move decl to lisp.h.
8536 * xrdb.c (get_system_name): Likewise.
8537 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8538 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8539 some of which prompt warnings from gcc -Wbad-function-cast.
8540 (Fformat_time_string, Fencode_time, Finsert_char):
8541 (Ftranslate_region_internal, Fformat):
8542 Rename or remove local vars to avoid shadowing.
8543 (Ftranslate_region_internal): Mark var as initialized.
8544
8545 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8546 avoid shadowing.
8547
8548 * lisp.h (eassert): Check that the argument compiles, even if
8549 ENABLE_CHECKING is not defined.
8550
8551 * data.c (Findirect_variable): Name an expression, to avoid
8552 gcc -Wbad-function-cast warning.
8553 (default_value, arithcompare, arith_driver, arith_error): Now static.
8554 (store_symval_forwarding): Rename local to avoid shadowing.
8555 (Fmake_variable_buffer_local, Fmake_local_variable):
8556 Mark variables as initialized.
8557 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8558
8559 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8560 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8561 Rename locals to avoid shadowing.
8562 (mark_stack): Move local variables into the #ifdef region where
8563 they're used.
8564 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8565 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8566 needed otherwise.
8567 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8568 (GC_STRING_CHARS): Remove; not used.
8569 (Fmemory_limit): Cast sbrk's returned value to char *.
8570
8571 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8572 avoids undefined behavior in theory.
8573
8574 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8575
8576 Use functions, not macros, for up- and down-casing (Bug#8254).
8577 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8578 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8579 to use the following functions instead of these macros.
8580 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8581 EMACS_INT, since callers assume the returned value fits in int.
8582 (upcase1): Likewise, for UPCASE_TABLE.
8583 (uppercasep, lowercasep, upcase): New static inline functions.
8584 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8585 the race-condition problem in the old DOWNCASE.
8586
8587 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8588 Rename locals to avoid shadowing.
8589 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8590 (regex_compile, re_search_2, re_match_2_internal):
8591 Remove unused local vars.
8592 (FREE_VAR): Rewrite so as not to use empty "else",
8593 which gcc can warn about.
8594 (regex_compile, re_match_2_internal): Mark locals as initialized.
8595 (RETALLOC_IF): Define only if needed.
8596 (WORDCHAR_P): Likewise. This one is never needed, but is used
8597 only in a comment talking about a compiler bug, so put inside
8598 the #if 0 of that comment.
8599 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8600 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8601 Remove; unused.
8602
8603 * search.c (boyer_moore): Rename locals to avoid shadowing.
8604 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8605 (PREV_CHAR_BOUNDARY): Likewise.
8606
8607 * search.c (simple_search): Remove unused var.
8608
8609 * dired.c (compile_pattern): Move decl from here ...
8610 * lisp.h: ... to here, so that it can be checked.
8611 (struct re_registers): New forward decl.
8612
8613 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8614
8615 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8616 All uses changed.
8617 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8618 Rename locals to avoid shadowing.
8619 (Fvertical_motion): Mark locals as initialized.
8620
8621 * casefiddle.c (casify_object, casify_region): Now static.
8622 (casify_region): Mark local as initialized.
8623
8624 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8625
8626 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8627 New macros, so that the caller can use some names other than
8628 gcpro1, gcpro2, etc.
8629 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8630 of the new macros.
8631 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8632 argument, for consistency with GCPRO2_VAR, etc: it is now the
8633 prefix of the variable, not the variable itself. All uses
8634 changed.
8635 * dired.c (directory_files_internal, file_name_completion):
8636 Rename locals to avoid shadowing.
8637
8638 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8639 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8640 dired.c's scmp function, had undefined behavior.
8641 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8642 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8643 * buffer.h: ... to here, because these macros use current_buffer,
8644 and the new implementation with inline functions needs to have
8645 current_buffer in scope now, rather than later when the macros
8646 are used.
8647 (downcase, upcase1): New static inline functions.
8648 (DOWNCASE, UPCASE1): Reimplement using these functions.
8649 This avoids undefined behavior in expressions like
8650 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8651 from race conditions in accessing the global variables
8652 case_temp1 and case_temp2.
8653 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8654 * lisp.h (case_temp1, case_temp2): Remove their decls.
8655 * character.h (ASCII_CHAR_P): Move from here ...
8656 * lisp.h: ... to here, so that the inline functions mentioned
8657 above can use them.
8658
8659 * dired.c (directory_files_internal_unwind): Now static.
8660
8661 * fileio.c (file_name_as_directory, directory_file_name):
8662 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8663 Now static.
8664 (file_name_as_directory): Use const pointers when appropriate.
8665 (Fexpand_file_name): Likewise. In particular, newdir might
8666 point at constant storage, so make it a const pointer.
8667 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8668 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8669 signedness issues.
8670 (Fset_file_times, Finsert_file_contents, auto_save_error):
8671 Rename locals to avoid shadowing.
8672
8673 * minibuf.c (choose_minibuf_frame_1): Now static.
8674 (Ftry_completion, Fall_completions): Rename or remove locals
8675 to avoid shadowing.
8676
8677 * marker.c (bytepos_to_charpos): Remove; unused.
8678
8679 * lisp.h (verify_bytepos, count_markers): New decls,
8680 so that gcc does not warn that these functions aren't declared.
8681
8682 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8683 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8684 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8685 (copy_text): Remove unused local var.
8686
8687 * filelock.c (within_one_second): Now static.
8688 (lock_file_1): Rename local to avoid shadowing.
8689
8690 * buffer.c (fix_overlays_before): Mark locals as initialized.
8691 (fix_start_end_in_overlays): Likewise. This function should be
8692 simplified by using pointers-to-pointers, but that's a different
8693 matter.
8694 (switch_to_buffer_1): Now static.
8695 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8696 (report_overlay_modification): Rename locals to avoid shadowing.
8697
8698 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8699 Fix pointer signedness issue.
8700 (sys_subshell): Mark local as volatile if checking for lint,
8701 to suppress a gcc -Wclobbered warning that does not seem to be right.
8702 (MAXPATHLEN): Define only if needed.
8703
8704 * process.c (serial_open, serial_configure): Move decls from here ...
8705 * systty.h: ... to here, so that they can be checked.
8706
8707 * fns.c (get_random, seed_random): Move extern decls from here ...
8708 * lisp.h: ... to here, so that they can be checked.
8709
8710 * sysdep.c (reset_io): Now static.
8711 (wait_for_termination_signal): Remove; unused.
8712
8713 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8714 (copy_keymap_item, append_key, push_text_char_description):
8715 Now static.
8716 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8717 (DENSE_TABLE_SIZE): Remove; unused.
8718 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8719 (describe_map_tree):
8720 Rename locals to avoid shadowing.
8721
8722 * keyboard.c: Declare functions static if they are not used elsewhere.
8723 (echo_char, echo_dash, cmd_error, top_level_2):
8724 (poll_for_input, handle_async_input): Now static.
8725 (read_char, kbd_buffer_get_event, make_lispy_position):
8726 (make_lispy_event, make_lispy_movement, apply_modifiers):
8727 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8728 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8729 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8730 (read_key_sequence, read_char): Mark locals as initialized.
8731 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8732
8733 * keyboard.h (make_ctrl_char): New decl.
8734 (mark_kboards): Move decl here ...
8735 * alloc.c (mark_kboards): ... from here.
8736
8737 * lisp.h (force_auto_save_soon): New decl.
8738
8739 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8740 (DEFINE_DUMMY_FUNCTION): New macro.
8741 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8742 Use it.
8743 (main): Add casts to avoid warnings
8744 if GCC considers string literals to be constants.
8745
8746 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8747
8748 * dbusbind.c: Pointer signedness fixes.
8749 (xd_signature, xd_append_arg, xd_initialize):
8750 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8751 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8752 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8753 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8754
8755 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8756 if GCC considers string literals to be constants.
8757 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8758
8759 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8760
8761 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8762 (print_preprocess, print_object): New macro to fix last change.
8763
8764 * print.c (print_preprocess): Don't forget font objects.
8765
8766 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8767
8768 * emacs.c (USAGE3): Doc fixes.
8769
8770 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8771
8772 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8773 structure.
8774
8775 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8776
8777 * lisp.h (VWindow_system, Qfile_name_history):
8778 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8779 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8780 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8781
8782 * w32select.c: Don't #include "keyboard.h".
8783 (run_protected): Add extern declaration for waiting_for_input.
8784
8785 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8786 * w32console.c (detect_input_pending, read_input_pending)
8787 (encode_terminal_code):
8788 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8789 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8790 (w32_system_caret_y, Qfile_name_history):
8791 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8792 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8793 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8794 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8795 * w32proc.c (Qlocal, report_file_error):
8796 * w32term.c (Vwindow_system, updating_frame):
8797 * w32uniscribe.c (initialized, uniscribe_font_driver):
8798 Remove unneeded extern declarations.
8799
8800 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8801
8802 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8803
8804 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8805
8806 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8807 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8808 These macros can no longer be used for assignment.
8809
8810 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8811 Assign struct members directly, instead of using BUF_BEGV etc.
8812 (record_buffer_markers, fetch_buffer_markers): New functions for
8813 recording and fetching special buffer markers.
8814 (set_buffer_internal_1, set_buffer_temp): Use them.
8815
8816 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8817
8818 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8819
8820 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8821 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8822
8823 * xdisp.c (hscroll_window_tree):
8824 (reconsider_clip_changes): Use PT instead of BUF_PT.
8825
8826 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8827
8828 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8829 $(EMACS_ROOT)/lib/intprops.h.
8830
8831 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8832
8833 Fix more problems found by GCC 4.5.2's static checks.
8834
8835 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8836 to unsigned char * to avoid compiler diagnostic.
8837 (xg_free_frame_widgets): Make it clear that a local variable is
8838 needed only if USE_GTK_TOOLTIP.
8839 (gdk_window_get_screen): Make it clear that this macro is needed
8840 only if USE_GTK_TOOLTIP.
8841 (int_gtk_range_get_value): New function, which avoids a diagnostic
8842 from gcc -Wbad-function-cast.
8843 (xg_set_toolkit_scroll_bar_thumb): Use it.
8844 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8845 diagnostic from gcc -Wbad-function-cast.
8846 (get_utf8_string, xg_get_file_with_chooser):
8847 Rename locals to avoid shadowing.
8848 (create_dialog): Move locals to avoid shadowing.
8849
8850 * xgselect.c (xg_select): Remove unused var.
8851
8852 * image.c (four_corners_best): Mark locals as initialized.
8853 (gif_load): Initialize transparent_p to zero (Bug#8238).
8854 Mark another local as initialized.
8855 (my_png_error, my_error_exit): Mark with NO_RETURN.
8856
8857 * image.c (clear_image_cache): Now static.
8858 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8859 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8860 (x_edge_detection): Remove unnecessary cast that
8861 gcc -Wbad-function-cast diagnoses.
8862 (gif_load): Fix pointer signedness.
8863 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8864 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8865
8866 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8867
8868 Improve quality of tests for time stamp overflow.
8869 For example, without this patch (encode-time 0 0 0 1 1
8870 1152921504606846976) returns the obviously-bogus value (-948597
8871 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8872 reports time overflow. See
8873 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8874 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8875 * editfns.c: Include limits.h and intprops.h.
8876 (TIME_T_MIN, TIME_T_MAX): New macros.
8877 (time_overflow): Move earlier, to before first use.
8878 (hi_time, lo_time): New functions, for an accurate test for
8879 out-of-range times.
8880 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8881 (Fget_internal_run_time): Don't assume time_t fits in int.
8882 (make_time): Use list2 instead of Fcons twice.
8883 (Fdecode_time): More accurate test for out-of-range times.
8884 (check_tm_member): New function.
8885 (Fencode_time): Use it, to test for out-of-range times.
8886 (lisp_time_argument): Don't rely on undefined left-shift and
8887 right-shift behavior when checking for time stamp overflow.
8888
8889 * editfns.c (time_overflow): New function, refactoring common code.
8890 (Fformat_time_string, Fdecode_time, Fencode_time):
8891 (Fcurrent_time_string): Use it.
8892
8893 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8894 * dired.c (make_time): Move to ...
8895 * editfns.c (make_time): ... here.
8896 * systime.h: Note the move.
8897
8898 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8899
8900 * fringe.c (update_window_fringes): Remove unused variables.
8901
8902 * unexmacosx.c (copy_data_segment): Also copy __got section.
8903 (Bug#8223)
8904
8905 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8906
8907 * termcap.c [MSDOS]: Include "msdos.h".
8908 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8909 Constify `char *' arguments and their references according to
8910 prototypes in tparam.h.
8911
8912 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8913
8914 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8915 Adapt all references accordingly.
8916
8917 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8918
8919 2011-03-11 Tom Tromey <tromey@redhat.com>
8920
8921 * buffer.c (syms_of_buffer): Remove obsolete comment.
8922
8923 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8924
8925 * termhooks.h (encode_terminal_code): Declare prototype.
8926
8927 * msdos.c (encode_terminal_code): Don't declare prototype.
8928
8929 * term.c (encode_terminal_code): Now external again, used by
8930 w32console.c and msdos.c.
8931
8932 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8933 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8934
8935 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8936
8937 Fix some minor problems found by GCC 4.5.2's static checks.
8938
8939 * fringe.c (update_window_fringes): Mark locals as initialized
8940 (Bug#8227).
8941 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8942
8943 * alloc.c (mark_fringe_data): Move decl from here ...
8944 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8945 to check its interface.
8946 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8947
8948 * fontset.c (free_realized_fontset): Now static.
8949 (Fset_fontset_font): Rename local to avoid shadowing.
8950 (fontset_font): Mark local as initialized.
8951 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8952
8953 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8954
8955 * xselect.c (x_disown_buffer_selections): Remove; not used.
8956 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8957 (x_own_selection, Fx_disown_selection_internal): Rename locals
8958 to avoid shadowing.
8959 (x_handle_dnd_message): Remove local to avoid shadowing.
8960
8961 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8962 so that the caller can use some name other than gcpro1.
8963 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8964 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8965 (Fx_backspace_delete_keys_p):
8966 Use them to avoid shadowing, and rename vars to avoid shadowing.
8967 (x_decode_color, x_set_name, x_window): Now static.
8968 (Fx_create_frame): Add braces to silence GCC warning.
8969 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8970 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8971 Remove unused locals.
8972 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8973 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8974 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8975 macros.
8976
8977 * xterm.h (x_mouse_leave): New decl.
8978
8979 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8980 Remove unused functions.
8981 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8982 (x_calc_absolute_position): Now static.
8983 (XTread_socket): Don't define label "out" unless it's used.
8984 Don't declare local "event" unless it's used.
8985 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8986 unless they are used.
8987 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8988 (x_fatal_error_signal): Remove; not used.
8989 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8990 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8991 (x_error_catcher, x_connection_closed, x_error_handler):
8992 (x_error_quitter, xembed_send_message, x_iconify_frame):
8993 (my_log_handler): Rename locals to avoid shadowing.
8994 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8995 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8996
8997 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8998 Rename or move locals to avoid shadowing.
8999 (tty_defined_color, merge_face_heights): Now static.
9000 (free_realized_faces_for_fontset): Remove; not used.
9001 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9002 does not deduce is never used uninitialized.
9003 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9004 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9005
9006 * terminal.c (store_terminal_param): Now static.
9007
9008 * xmenu.c (menu_highlight_callback): Now static.
9009 (set_frame_menubar): Remove unused local.
9010 (xmenu_show): Rename parameter to avoid shadowing.
9011 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9012 since they might point to immutable storage.
9013 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9014 since it's unused otherwise.
9015
9016 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9017 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9018 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9019 avoids a gcc -Wuninitialized diagnostic.
9020 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9021 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9022 does not deduce are never used uninitialized.
9023
9024 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9025
9026 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9027 * window.c (window_loop, size_window):
9028 (run_window_configuration_change_hook, enlarge_window): Likewise.
9029
9030 * window.c (display_buffer): Now static.
9031 (size_window): Mark variables that gcc -Wuninitialized
9032 does not deduce are never used uninitialized.
9033 * window.h (check_all_windows): New decl, to forestall
9034 gcc -Wmissing-prototypes diagnostic.
9035 * dispextern.h (bidi_dump_cached_states): Likewise.
9036
9037 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9038 shadowing.
9039 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9040 Include <limits.h>.
9041 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9042 and to avoid gcc -Wuninitialized warning.
9043 (load_charset_map): Mark variables that gcc -Wuninitialized
9044 does not deduce are never used uninitialized.
9045 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9046
9047 * coding.c (coding_set_source, coding_set_destination):
9048 Use "else { /* comment */ }" rather than "else /* comment */;"
9049 for clarity, and to avoid gcc -Wempty-body warning.
9050 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9051 a block, when the outer 'i' will do.
9052 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9053 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9054 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9055 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9056 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9057 Rename locals to avoid shadowing.
9058 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9059 * coding.c (emacs_mule_char, encode_invocation_designation):
9060 Now static, since they're not used elsewhere.
9061 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9062 (decode_coding_object, encode_coding_object, detect_coding_system):
9063 (decode_coding_emacs_mule): Mark variables that gcc
9064 -Wuninitialized does not deduce are never used uninitialized.
9065 (detect_coding_iso_2022): Initialize a local variable that might
9066 be used uninitialized. Leave a FIXME because it's not clear that
9067 this initialization is needed. (Bug#8211)
9068 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9069 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9070 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9071 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9072 Remove unused macros.
9073
9074 * category.c (hash_get_category_set): Remove unused local var.
9075 (copy_category_table): Now static, since it's not used elsewhere.
9076 * character.c (string_count_byte8): Likewise.
9077
9078 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9079 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9080
9081 * chartab.c (copy_sub_char_table): Now static, since it's not used
9082 elsewhere.
9083 (sub_char_table_ref_and_range, char_table_ref_and_range):
9084 Rename locals to avoid shadowing.
9085 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9086
9087 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9088 (BIDI_BOB): Remove unused macro.
9089
9090 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9091 deduce are never used uninitialized.
9092 * term.c (encode_terminal_code): Likewise.
9093
9094 * term.c (encode_terminal_code): Now static. Remove unused local.
9095
9096 * tparam.h: New file.
9097 * term.c, tparam.h: Include it.
9098 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9099 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9100 Move these decls to tparam.h, and make them agree with what
9101 is actually in tparam.c. The previous trick of using incompatible
9102 decls in different modules does not conform to the C standard.
9103 All callers of tparam changed to use tparam's actual API.
9104 * tparam.c (tparam1, tparam, tgoto):
9105 Use const pointers where appropriate.
9106
9107 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9108 * cm.h (struct cm): Likewise.
9109 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9110 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9111 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9112 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9113 (turn_on_face, init_tty): Likewise.
9114 * termchar.h (struct tty_display_info): Likewise.
9115
9116 * term.c (term_mouse_position): Rename local to avoid shadowing.
9117
9118 * alloc.c (mark_ttys): Move decl from here ...
9119 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9120
9121 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9122
9123 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9124
9125 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9126
9127 * search.c (compile_pattern_1): Remove argument regp, unused since
9128 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9129 (compile_pattern): Don't pass it.
9130
9131 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9132
9133 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9134 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9135 for ! HAVE_GTK3.
9136 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9137
9138 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9139
9140 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9141 gdk_window_get_screen, gdk_window_get_geometry,
9142 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9143 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9144 (xg_get_pixbuf_from_pixmap): New function.
9145 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9146 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9147 Call xg_get_pixbuf_from_pixmap instead of
9148 gdk_pixbuf_get_from_drawable.
9149 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9150 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9151 (xg_check_special_colors): Use GtkStyleContext and its functions
9152 for HAVE_GTK3.
9153 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9154 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9155 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9156 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9157 Call gtk_widget_get_preferred_size.
9158 (xg_frame_resized): gdk_window_get_geometry only takes 5
9159 parameters.
9160 (xg_win_to_widget, xg_event_is_for_menubar):
9161 Call gdk_x11_window_lookup_for_display.
9162 (xg_set_widget_bg): New function.
9163 (delete_cb): New function.
9164 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9165 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9166 (xg_set_background_color): Call xg_set_widget_bg.
9167 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9168 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9169 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9170 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9171 if ! HAVE_GTK3.
9172 (update_frame_tool_bar): Call gtk_widget_hide.
9173 (xg_initialize): Use GDK_KEY_g.
9174
9175 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9176 if ! HAVE_GTK3
9177 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9178
9179 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9180 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9181 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9182
9183 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9184
9185 * w32xfns.c (select_palette): Check success of RealizePalette against
9186 GDI_ERROR, not zero.
9187
9188 See ChangeLog.11 for earlier changes.
9189
9190 ;; Local Variables:
9191 ;; coding: utf-8
9192 ;; End:
9193
9194 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9195
9196 This file is part of GNU Emacs.
9197
9198 GNU Emacs is free software: you can redistribute it and/or modify
9199 it under the terms of the GNU General Public License as published by
9200 the Free Software Foundation, either version 3 of the License, or
9201 (at your option) any later version.
9202
9203 GNU Emacs is distributed in the hope that it will be useful,
9204 but WITHOUT ANY WARRANTY; without even the implied warranty of
9205 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9206 GNU General Public License for more details.
9207
9208 You should have received a copy of the GNU General Public License
9209 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.