1 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
3 sprintf-related integer and memory overflow issues.
5 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
6 (esprintf, esnprintf, exprintf, evxprintf): New functions.
7 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
8 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
9 (modify_event_symbol): Do not assume that the length of
10 name_alist_or_stem is safe to alloca and fits in int.
11 (Fexecute_extended_command): Likewise for function name and binding.
12 (Frecursion_depth): Wrap around reliably on integer overflow.
13 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
14 since some callers pass EMACS_INT values.
15 (Fsingle_key_description): Don't crash if symbol name contains more
16 than MAX_ALLOCA bytes.
17 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
18 (get_minibuffer): Arg is now EMACS_INT, not int.
19 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
20 (esprintf, esnprintf, exprintf, evxprintf): New decls.
21 * window.h (command_loop_level, minibuf_level): Reflect API changes.
23 * dbusbind.c (xd_signature, Fdbus_register_signal):
24 Do not overrun buffer; instead, report string overflow.
26 * dispnew.c (add_window_display_history): Don't overrun buffer.
27 Truncate instead; this is OK since it's just a log.
29 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
30 even if the time zone offset is outlandishly large.
31 Don't mishandle offset == INT_MIN.
33 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
34 when creating daemon; the previous buffer-overflow check was incorrect.
36 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
37 which has the guts of the old verror function.
39 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
40 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
42 * font.c (font_unparse_xlfd): Don't blindly alloca long strings.
43 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
44 fits in int, when using sprintf. Use single snprintf to count
45 length of string rather than counting it via multiple sprintfs;
46 that's simpler and more reliable.
47 (APPEND_SPRINTF): New macro.
48 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
49 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
50 sprintf, in case result does not fit in int.
52 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
53 (fontset_from_font): Print it.
55 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
57 Integer and memory overflow issues (Bug#9196).
59 * doc.c (get_doc_string): Rework so that
60 get_doc_string_buffer_size is the actual buffer size, rather than
61 being 1 less than the actual buffer size; this makes xpalloc more
64 * image.c (x_allocate_bitmap_record, cache_image):
65 * xselect.c (Fx_register_dnd_atom):
66 Simplify previous changes by using xpalloc.
68 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
69 since either will do and ptrdiff_t is convenient with xpalloc.
71 * charset.c (charset_table_size)
72 (struct charset_sort_data.priority): Now ptrdiff_t.
73 (charset_compare): Don't overflow if priorities differ greatly.
74 (Fsort_charsets): Don't assume list length fits in int.
75 Check for size-calculation overflow when allocating sort data.
76 (syms_of_charset): Allocate an initial charset table that is
77 just under 64 KiB, to avoid problems with glibc malloc and mmap.
79 * cmds.c (internal_self_insert): Check for size-calculation overflow.
81 * composite.h (struct composition.glyph_len): Now int, not unsigned.
82 The actual value is always <= INT_MAX, and leaving it unsigned made
83 overflow checking harder.
85 * dispextern.h (struct glyph_matrix.rows_allocated)
86 (struct face_cache.size): Now ptrdiff_t, for convenience in use
87 with xpalloc. The values are still always <= INT_MAX.
89 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
91 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
92 (SAFE_NALLOCA): New macro.
94 * region-cache.c (struct boundary.pos, find_cache_boundary)
95 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
96 (set_cache_region, invalidate_region_cache)
97 (revalidate_region_cache, know_region_cache, region_cache_forward)
98 (region_cache_backward, pp_cache):
99 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
100 so that ptrdiff_t * can be passed to xpalloc.
101 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
102 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
103 (pp_cache): Don't assume cache_len fits in int.
104 * region-cache.h: Adjust extern decls to match.
106 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
107 EMACS_INT, since either will do, for xpalloc.
109 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
110 (xnmalloc, xnrealloc, xpalloc): New functions.
112 * bidi.c (bidi_shelve_header_size): New constant.
113 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
114 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
116 * bidi.c (bidi_cache_shrink):
117 * buffer.c (overlays_at, overlays_in, record_overlay_string)
119 Don't update size of array until after memory allocation succeeds,
120 because xmalloc/xrealloc may not return.
121 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
122 now that we have proper integer overflow checking.
123 (record_overlay_string, overlay_strings): Catch overflows when
124 calculating size of overlay_str_buf.
126 * callproc.c (Fcall_process): Check for size overflow when
127 calculating size of args2.
128 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
129 Normally we prefer signed values, but sticking with ptrdiff_t would
130 require adding more-complicated checks.
132 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
133 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
134 Redo buffer-overflow calculations to avoid integer overflow.
135 Add a FIXME comment where memory seems to be over-allocated.
137 * character.c (Fstring): Check for size-calculation overflow.
139 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
140 unnecessary integer overflow. Check for size overflow.
141 (encode_coding_object): Don't update size until xmalloc succeeds.
143 * composite.c (get_composition_id): Check for overflow in glyph
146 Integer and memory overflow fixes for display code.
147 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
148 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
149 (scrolling_window): Check for overflow in size calculations.
150 (line_draw_cost, realloc_glyph_pool, add_row_entry):
151 Don't assume glyph table len fits in int.
152 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
153 (row_table_size): Now ptrdiff_t, not int.
154 (scrolling_window): Avoid overflow in size calculations.
155 Don't update size until allocation succeeds.
156 * fns.c (concat): Check for overflow in size calculations.
157 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
158 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
159 (NEXT_ALMOST_PRIME_LIMIT): New constant.
161 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
162 (get_doc_string): Check for size calculation overflow.
163 Don't update size until allocation succeeds.
164 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
165 EMACS_INT, where ptrdiff_t will do.
166 (Fsubstitute_command_keys): Check for string overflow.
168 * editfns.c (set_time_zone_rule): Don't assume environment length
170 (message_length): Now ptrdiff_t, not int.
171 (Fmessage_box): Don't update size until allocation succeeds.
172 Don't assume message length fits in int.
173 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
175 * emacs.c (main): Do not reallocate argv, since there is a null at
176 the end that can be overwritten, and this way there's no need to
177 worry about size-calculation overflow.
178 (sort_args): Check for size-calculation overflow.
180 * eval.c (init_eval_once, grow_specpdl): Don't update size until
182 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
184 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
185 (x_set_scroll_bar_width, x_figure_window_size):
186 Check for integer overflow.
187 (x_set_alpha): Do not assume XINT fits in int.
189 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
190 This is for the members text_lines, text_cols, total_lines, total_cols,
191 where the system imposes an 'int' limit.
193 * fringe.c (Fdefine_fringe_bitmap):
194 Don't update size until alloc works.
196 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
197 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
199 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
200 Check for size-calculation overflow.
201 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
202 do, as we prefer signed integers.
203 (id_to_widget.max_size, id_to_widget.used)
204 (xg_store_widget_in_map, xg_remove_widget_from_map)
205 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
206 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
207 Use and return ptrdiff_t, not int.
208 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
209 * gtkutil.h: Change prototypes to match the above.
211 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
212 are duplicate now that they've been promoted to lisp.h.
213 (x_allocate_bitmap_record, x_alloc_image_color)
214 (make_image_cache, cache_image, xpm_load):
215 Don't update size until alloc is done.
216 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
218 Check for size calculation overflow.
219 (ct_colors_allocated_max): New constant.
220 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
223 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
224 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
225 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
226 Use ptrdiff_t, not int, to count maps.
227 (read_char_minibuf_menu_prompt): Check for overflow in size
228 calculations. Don't update size until allocation succeeds. Redo
229 calculations to avoid overflow.
230 * keyboard.h: Change prototypes to match the above.
232 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
234 (current_minor_maps): Check for size calculation overflow.
235 * keymap.h: Change prototypes to match the above.
237 * lread.c (read1, init_obarray): Don't update size until alloc done.
239 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
240 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
242 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
243 Now ptrdiff_t, not int.
244 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
245 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
247 * process.c (Fnetwork_interface_list): Check for overflow
250 * region-cache.c (move_cache_gap): Check for size calculation overflow.
252 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
253 overflow. Don't bother calling xmalloc when xrealloc will do.
255 * search.c (Freplace_match): Check for size calculation overflow.
256 (Fset_match_data): Don't assume list lengths fit in 'int'.
258 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
259 for command line length. Do not attempt to address one before the
260 beginning of an array, as that's not portable.
262 * term.c (max_frame_lines): Remove; unused.
263 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
265 (encode_terminal_code, calculate_costs): Check for size
266 calculation overflow.
267 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
268 table lengths and related sizes. Don't update size until alloc
269 done. Redo calculations to avoid overflow.
270 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
272 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
273 subtracting pointers.
274 (gobble_line): Check for overflow more carefully. Don't update size
277 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
278 Don't update size until alloc done.
279 Redo size calculations to avoid overflow.
280 Check for size calculation overflow.
281 (main) [DEBUG]: Fix typo in invoking tparam1.
283 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
284 Use ptrdiff_t, not int, for sizes.
285 (store_mode_line_noprop_char): Don't update size until alloc done.
287 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
288 Use ptrdiff_t, not int, for sizes.
289 (Finternal_make_lisp_face, cache_face):
290 Check for size calculation overflow.
291 (cache_face): Treat size calculation overflows as if they were
292 memory exhaustion (the usual treatment), rather than aborting.
294 * xfns.c (x_encode_text, x_set_name_internal)
295 (Fx_change_window_property): Use ptrdiff_t, not int, to count
296 sizes, since they can exceed INT_MAX in size. Check for size
297 calculation overflow.
299 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
300 (xg_select): Check for size calculation overflow.
301 Don't update size until alloc done.
303 * xrdb.c (get_environ_db): Don't assume path length fits in int,
304 as sprintf is limited to int lengths.
306 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
307 (X_LONG_MIN): New macros.
308 Use them to make the following changes clearer.
309 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
310 This change doesn't affect the value now, but it may help remind
311 future maintainers not to raise the value too much later.
312 (SELECTION_QUANTUM): Remove, replacing with ...
313 (selection_quantum): ... new function, which avoids overflow.
315 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
316 assumption that selection length fits in 'int'.
317 (x_reply_selection_request, x_handle_selection_request)
318 (x_get_window_property, receive_incremental_selection)
319 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
320 (lisp_data_to_selection_data, clean_local_selection_data):
321 Use ptrdiff_t, not int, to record length of selection.
322 (x_reply_selection_request, x_get_window_property)
323 (receive_incremental_selection, x_property_data_to_lisp):
324 Redo calculations to avoid overflow.
325 (x_reply_selection_request): When sending hint, ceiling it at
326 X_LONG_MAX rather than relying on wraparound overflow to send
328 (x_get_window_property, receive_incremental_selection)
329 (lisp_data_to_selection_data, x_property_data_to_lisp):
330 Check for size-calculation overflow.
331 (x_get_window_property, receive_incremental_selection)
332 (lisp_data_to_selection_data, Fx_register_dnd_atom):
333 Don't store size until memory allocation succeeds.
334 (x_get_window_property): Plug memory leak on memory exhaustion.
335 Don't double-block input; malloc is safe here. Don't assume 2**34
336 - 4 fits in unsigned long. Add an xassert to check
337 XGetWindowProperty overflow. Be more careful about overflow
338 calculations, and distinguish size from memory overflow better.
339 (receive_incremental_selection): When tracing, don't assume
340 unsigned int is less than INT_MAX.
341 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
342 harmful) conversions of unsigned short to int.
343 (lisp_data_to_selection_data): Don't assume that integers
344 in the range -65535 through -1 fit in an X unsigned short.
345 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
346 result parameters unless successful. Rely on cons_to_unsigned
347 to report problems with elements; the old code wasn't right anyway.
348 (x_check_property_data): Check for int overflow; we cannot use
349 a wider type due to X limits.
350 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
352 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
354 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
355 (x_term_init): Check for size calculation overflow.
356 (x_color_cells): Don't store size until memory allocation succeeds.
357 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
358 Don't assume alloca size is less than MAX_ALLOCA.
359 (x_term_init): Don't assume length fits in int (sprintf is limited
362 Use ptrdiff_t for composition IDs.
363 * character.c (lisp_string_width):
364 * composite.c (composition_table_size, n_compositions)
365 (get_composition_id, composition_gstring_from_id):
366 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
367 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
368 * window.c (Frecenter):
369 Use ptrdiff_t, not int, for composition IDs.
370 * composite.c (get_composition_id): Check for integer overflow.
371 * composite.h: Adjust prototypes to match the above changes.
373 Use ptrdiff_t for hash table indexes.
374 * category.c (hash_get_category_set):
375 * ccl.c (ccl_driver):
376 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
377 * coding.c (coding_system_charset_list, detect_coding_system):
378 * coding.h (struct coding_system.id):
379 * composite.c (get_composition_id, gstring_lookup_cache):
380 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
381 * image.c (xpm_get_color_table_h):
382 * lisp.h (hash_lookup, hash_put):
383 * minibuf.c (Ftest_completion):
384 Use ptrdiff_t for hash table indexes, not int (which is too
385 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
386 32-bit --with-wide-int hosts).
388 * charset.c (Fdefine_charset_internal): Check for integer overflow.
389 Add a FIXME comment about memory leaks.
390 (syms_of_charset): Don't assume xmalloc returns.
392 Don't assume that stated character widths fit in int.
393 * character.c (Fchar_width, c_string_width, lisp_string_width):
394 * character.h (CHAR_WIDTH):
395 * indent.c (MULTIBYTE_BYTES_WIDTH):
396 Use sanitize_char_width to avoid undefined and/or bad behavior
397 with outlandish widths.
398 * character.h (sanitize_tab_width): Renamed from sanitize_width,
399 now that we have two such functions. All uses changed.
400 (sanitize_char_width): New inline function.
402 Don't assume that tab-width fits in int.
403 * character.h (sanitize_width): New inline function.
404 (SANE_TAB_WIDTH): New macro.
405 (ASCII_CHAR_WIDTH): Use it.
406 * indent.c (sane_tab_width): Remove. All uses replaced by
407 SANE_TAB_WIDTH (current_buffer).
408 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
410 * fileio.c: Integer overflow issues with file modes.
411 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
413 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
414 Remove unreachable code.
415 (read_hex, load_charset_map_from_file): Check for integer overflow.
417 * xterm.c: don't go over XClientMessageEvent limit
418 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
419 (x_send_scroll_bar_event): Likewise. Check that the size does not
420 exceed limits imposed by XClientMessageEvent, as well as the usual
421 ptrdiff_t and size_t limits.
423 * keyboard.c: Overflow, signedness and related fixes.
424 (make_lispy_movement): Use same integer type in forward decl
425 that is used in the definition.
426 (read_key_sequence, keyremap_step):
427 Change bufsize argument back to int, undoing my 2011-03-30 change.
428 We prefer signed types, and int is wide enough here.
429 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
430 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
431 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
432 length, not size_t. Use ptrdiff_t for index, not int.
433 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
434 possibility of integer overflow.
436 Overflow, signedness and related fixes for images.
438 * dispextern.h (struct it.stack[0].u.image.image_id)
439 (struct_it.image_id, struct image.id, struct image_cache.size)
440 (struct image_cache.used, struct image_cache.ref_count):
441 * gtkutil.c (update_frame_tool_bar):
442 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
443 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
444 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
445 * nsmenu.m (update_frame_tool_bar):
446 * xdisp.c (calc_pixel_width_or_height):
447 * xfns.c (image_cache_refcount):
448 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
449 on typical 64-bit hosts.
451 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
452 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
453 Omit unnecessary casts to int.
454 (parse_image_spec): Check that integers fall into 'int' range
455 when the callers expect that.
456 (image_ascent): Redo ascent calculation to avoid int overflow.
457 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
458 (lookup_image): Remove unnecessary tests.
459 (xbm_image_p): Locals are now of int, not EMACS_INT,
460 since parse_image_check makes sure they fit into int.
461 (png_load, gif_load, svg_load_image):
462 Prefer int to unsigned where either will do.
463 (tiff_handler): New function, combining the cores of the
464 old tiff_error_handler and tiff_warning_handler. This
465 function is rewritten to use vsnprintf and thereby avoid
466 stack buffer overflows. It uses only the features of vsnprintf
467 that are common to both POSIX and native Microsoft.
468 (tiff_error_handler, tiff_warning_handler): Use it.
469 (tiff_load, gif_load, imagemagick_load_image):
470 Don't assume :index value fits in 'int'.
471 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
472 (imagemagick_load_image): Check that crop parameters fit into
473 the integer types that MagickCropImage accepts. Don't assume
474 Vimagemagick_render_type has a nonnegative value. Don't assume
475 size_t fits in 'long'.
476 (gs_load): Use printmax_t to print the widest integers possible.
477 Check for integer overflow when computing image height and width.
479 2011-08-26 Eli Zaretskii <eliz@gnu.org>
481 * xdisp.c (redisplay_window): Don't force window start if point
482 will be invisible in the resulting window. (Bug#9324)
484 2011-08-25 Eli Zaretskii <eliz@gnu.org>
486 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
487 the display spec is of the form `(space ...)'.
488 (handle_display_spec): Return the value returned by
489 handle_single_display_spec, not just 1 or zero.
490 (handle_single_display_spec): If the display spec is of the form
491 `(space ...)', and specifies display in the text area, return 2
493 (try_cursor_movement): Check for the need to scroll more
494 accurately, and prefer exact match for point under bidi. Don't
495 advance `row' beyond the last row of the window.
497 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
498 into disp_prop; all users changed.
500 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
501 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
502 for the text covered by the display property.
504 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
506 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
507 Change return value to nil.
508 (Frecord_buffer): Delete unused function.
510 2011-08-24 Eli Zaretskii <eliz@gnu.org>
512 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
513 buffers, return left-to-right.
514 (set_cursor_from_row): Consider candidate row a win if its glyph
515 represents a newline and point is on that newline. Fixes cursor
516 positioning on the newline at EOL of R2L text within L2R
517 paragraph, and vice versa.
518 (try_cursor_movement): Check continued rows, in addition to
519 continuation rows. Fixes unwarranted scroll when point enters a
520 continued line of R2L text within an L2R paragraph, or vice versa.
521 (cursor_row_p): Consider the case of point being equal to
522 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
523 from the end of a short line to the beginning of a continued line
524 of R2L text within L2R paragraph.
525 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
528 * bidi.c (bidi_check_type): Use xassert.
529 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
532 2011-08-23 Eli Zaretskii <eliz@gnu.org>
534 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
537 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
539 * nsfont.m (ns_otf_to_script): Fix typo.
541 2011-08-22 Kenichi Handa <handa@m17n.org>
543 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
544 extra slot even if the purpose is char-code-property-table.
546 2011-08-23 Eli Zaretskii <eliz@gnu.org>
548 * xdisp.c (redisplay_window): When computing centering_position,
549 account for the height of the header line. (Bug#8874)
551 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
552 instead of CHAR_TO_BYTE. Fixes a crash when a completion
553 candidate is selected by the mouse, and that candidate has a
554 composed character under the mouse.
556 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
557 coordinates reported by pos-visible-in-window-p for a composed
558 character in column zero.
560 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
562 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
564 2011-08-22 Eli Zaretskii <eliz@gnu.org>
566 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
567 consider it a hit if to_charpos is anywhere in the range of the
568 composed buffer positions.
570 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
572 * image.c (gif_load): Don't assume that each subimage has the same
573 dimensions as the base image. Handle disposal method that is
574 "undefined" by the gif spec (Bug#9335).
576 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
578 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
579 (Fcondition_case): Document `debug' symbol in error handler.
581 2011-08-19 Eli Zaretskii <eliz@gnu.org>
583 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
584 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
585 from an Org mode buffer to a Speedbar frame.
587 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
588 a composition, take its buffer position from IT->cmp_it.charpos.
589 Fixes cursor positioning at the beginning of a line that begins
590 with a composed character.
592 2011-08-18 Eli Zaretskii <eliz@gnu.org>
594 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
595 character bidirectional type, use STRONG_L instead. Fixes crashes
596 in a buffer produced by `describe-categories'.
598 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
599 members before the level stack, so they would be saved and
600 restored when copying iterator state. Fixes incorrect reordering
601 around TABs covered by display properties.
603 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
605 * process.c (Fnetwork_interface_list): Correctly determine buffer
608 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
610 * eval.c (internal_condition_case, internal_condition_case_1)
611 (internal_condition_case_2, internal_condition_case_n):
612 Remove unnecessary aborts (Bug#9081).
614 2011-08-17 Eli Zaretskii <eliz@gnu.org>
616 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
617 has no `load' handler, try opening the file locally. (Bug#9311)
619 2011-08-16 Ken Brown <kbrown@cornell.edu>
621 * gmalloc.c: Expand comment.
623 2011-08-16 Eli Zaretskii <eliz@gnu.org>
625 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
626 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
628 2011-08-16 Ken Brown <kbrown@cornell.edu>
630 Fix memory allocation problems in Cygwin build (Bug#9273).
632 * unexcw.c ( __malloc_initialized): Declare external variable.
633 (fixup_executable): Force the dumped emacs to reinitialize malloc.
635 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
637 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
639 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
641 [CYGWIN] (special_realloc): New function.
642 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
643 requests to realloc storage in the static heap.
645 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
647 * bidi.c (bidi_initialize): Remove unused local.
649 2011-08-15 Eli Zaretskii <eliz@gnu.org>
651 * biditype.h: File removed.
653 * bidimirror.h: File removed.
655 * deps.mk (bidi.o): Remove biditype.h and
658 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
661 * dispextern.h: Fix a typo in the comment to bidi_type_t.
663 * chartab.c: Improve commentary for the uniprop_table API.
665 * bidi.c (bidi_paragraph_init): Support zero value of
666 bidi_ignore_explicit_marks_for_paragraph_level.
667 (bidi_initialize): Use uniprop_table instead of including
668 biditype.h and bidimirror.h.
670 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
671 coordinates of the iterator when restoring from ppos_it.
674 2011-08-14 Kenichi Handa <handa@m17n.org>
676 * process.c (create_process): Call setup_process_coding_systems
677 after the pid of the process is set to -1 (Bug#8162).
679 2011-08-14 Eli Zaretskii <eliz@gnu.org>
681 * xdisp.c (move_it_in_display_line_to): Don't invoke
682 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
683 ppos_it. Fixes vertical cursor motion when line beginning is
684 covered by an image. (Bug#9296)
686 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
688 * nsterm.h (ns_run_ascript): Declare.
689 (NSAPP_DATA2_RUNASSCRIPT): Define.
691 * nsfns.m (as_script, as_result, as_status): New static variables.
692 (ns_run_ascript): New function.
693 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
694 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
695 the event loop. Get status from as_status (Bug#7276).
697 * nsterm.m (sendEvent): If event is NSApplicationDefined and
698 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
699 the event loop (Bug#7276).
701 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
703 * gnutls.c (QCgnutls_bootprop_priority)
704 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
705 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
706 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
707 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
708 (QCgnutls_bootprop_verify_hostname_error)
709 (QCgnutls_bootprop_callbacks_verify): Rename from
710 Qgnutls_bootprop_..., all uses changed.
712 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
715 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
717 * xfaces.c (Qframe_set_background_mode): Now static.
718 * dispextern.h (Qframe_set_background_mode): Remove decl.
720 * process.c (Fnetwork_interface_info): Declare local only if needed.
722 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
724 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
725 (Fnetwork_interface_list): Allocate in increments of bytes instead
726 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
727 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
729 (struct ifflag_def): notrailers is smart on OSX.
730 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
731 Get hardware address with getifaddrs if available.
733 2011-08-12 Eli Zaretskii <eliz@gnu.org>
735 * xdisp.c (iterate_out_of_display_property): xassert that
736 IT->position is set to within IT->object's boundaries. Break from
737 the loop as soon as EOB is reached; avoids infloops in redisplay
738 when IT->position is set up wrongly due to some bug.
739 Set IT->current to match the bidi iterator unconditionally.
740 (push_display_prop): Allow GET_FROM_STRING as IT->method on
741 entry. Force push_it to save on the stack the current
742 buffer/string position, to be restored by pop_it. Fix flags in
743 the iterator structure wrt the object coming from a display
744 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
745 properties. (Bug#9284)
747 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
749 * fontset.c (fontset_get_font_group): Add proper type checks.
752 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
754 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
755 and LC_VERSION_MIN_MACOSX.
756 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
757 (dump_it) [LC_FUNCTION_STARTS]: Use it.
759 2011-08-08 Eli Zaretskii <eliz@gnu.org>
761 * xdisp.c (forward_to_next_line_start): Allow to use the
762 no-display-properties-and-no-overlays under bidi display.
763 Set disp_pos in the bidi iterator to avoid searches for display
764 properties and overlays.
766 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
768 * editfns.c (Fset_time_zone_rule): Document relationship with the
771 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
772 the font entity extracted from the cache (Bug#8109).
774 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
776 * composite.c (autocmp_chars): Don't reset point. That is done by
777 restore_point_unwind (Bug#5984).
779 2011-08-07 Juri Linkov <juri@jurta.org>
781 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
782 to show the arg `TIME' instead of `TIMEVAL'.
784 2011-08-06 Eli Zaretskii <eliz@gnu.org>
786 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
787 display property strides EOL and includes a newline, as in
788 longlines-mode. (Bug#9254)
789 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
790 word-wrap under bidirectional display. (Bug#9224)
792 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
793 is non-zero, even if the data buffer is NULL. Fixes a crash in
794 vertical-motion with longlines-mode. (Bug#9254)
796 2011-08-05 Eli Zaretskii <eliz@gnu.org>
798 * bidi.c <bidi_cache_total_alloc>: Now static.
799 (bidi_initialize): Initialize bidi_cache_total_alloc.
801 * xdisp.c (display_line): Release buffer allocated for shelved bidi
804 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
805 amount allocated this far in `bidi_cache_total_alloc'.
806 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
807 non-zero, only free the data buffer without restoring the cache
808 contents. All callers changed.
810 * dispextern.h (bidi_unshelve_cache): Update prototype.
812 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
813 (move_it_in_display_line, move_it_to)
814 (move_it_vertically_backward, move_it_by_lines): Replace the call
815 to xfree to an equivalent call to bidi_unshelve_cache.
816 (move_it_in_display_line_to): Fix logic of returning
817 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
819 2011-08-05 Eli Zaretskii <eliz@gnu.org>
821 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
822 came from a string character with a `cursor' property. (Bug#9229)
824 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
826 * Makefile.in (LIB_PTHREAD): New variable.
827 (LIBES): Add LIB_PTHREAD (Bug#9216).
829 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
830 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
832 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
834 * regex.c (re_iswctype): Remove some redundant boolean
837 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
839 * xterm.c (x_find_topmost_parent): New function.
840 (x_set_frame_alpha): Find topmost parent window with
841 x_find_topmost_parent and set the property there also (bug#9181).
842 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
844 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
846 * callproc.c (Fcall_process): Avoid vfork clobbering
847 the local vars buffer, coding_systems, current_dir.
849 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
851 * keymap.c (Fmake_composed_keymap): Move to subr.el.
853 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
855 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
856 so that it is not optimized away.
858 * xdisp.c (compute_display_string_pos): Remove unused local.
860 2011-08-02 Eli Zaretskii <eliz@gnu.org>
862 Fix slow cursor motion and scrolling in large buffers with
863 selective display, like Org Mode buffers. (Bug#9218)
865 * dispextern.h (struct bidi_it): New member disp_prop_p.
867 * xdisp.c: Remove one-slot cache of display string positions.
868 (compute_display_string_pos): Accept an additional argument
869 DISP_PROP_P; callers changed. Scan at most 5K characters forward
870 for a display string or property. If found, set DISP_PROP_P
873 * bidi.c (bidi_fetch_char): Accept an additional argument
874 DISP_PROP_P, and pass it to compute_display_string_pos.
875 Only handle text covered by a display string if DISP_PROP_P is returned
876 non-zero. All callers of bidi_fetch_char changed.
878 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
880 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
882 2010-12-03 Don March <don@ohspite.net>
884 * keymap.c (Fdefine_key): Fix non-prefix key error message when
885 last character M-[char] is translated to ESC [char] (bug#7541).
887 2011-08-02 Kenichi Handa <handa@m17n.org>
889 * lisp.h (uniprop_table): Extern it.
891 * chartab.c (uniprop_table): Make it non-static.
893 2011-08-01 Eli Zaretskii <eliz@gnu.org>
895 * xdisp.c (forward_to_next_line_start): Accept additional argument
896 BIDI_IT_PREV, and store into it the state of the bidi iterator had
898 (reseat_at_next_visible_line_start): Use the bidi iterator state
899 returned by forward_to_next_line_start to restore the state of
900 it->bidi_it after backing up to previous newline. (Bug#9212)
902 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
904 * regex.c (re_comp): Protoize.
905 (re_exec): Fix return type.
906 (regexec): Fix type of `ret'. (Bug#9203)
908 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
910 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
911 This is needed if max-image-size is a floating-point number.
913 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
915 * print.c (print_object): Print empty symbol as ##.
917 * lread.c (read1): Read ## as empty symbol.
919 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
921 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
922 setting frame foreground color (Bug#9175).
923 (x_set_background_color): Likewise.
925 * nsmenu.m (-setText): Size tooltip dimensions precisely to
927 (EmacsTooltip -init): Remove bezels and add shadows to
930 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
931 or scroll bar (Bug#8470).
933 * nsfont.m (nsfont_open): Remove assignment to voffset and
934 unnecessary vars hshink, expand, hd, full_height, min_height.
935 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
937 * nsterm.h (nsfont_info): Remove voffset field.
939 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
941 Implement strike-through and overline on NextStep (Bug#8863).
943 * nsfont.m (nsfont_open): Use underline position provided by font,
944 instead of hard-coded value of 2.
945 (nsfont_draw): Call ns_draw_text_decoration instead.
947 * nsterm.h: Add declaration for ns_draw_text_decoration.
949 * nsterm.m (ns_draw_text_decoration): New function for drawing
950 underline, overline, and strike-through.
951 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
952 ns_draw_text_decoration. Change treatment of cursor drawing to
953 accomodate underlining, etc.
955 2011-07-28 Eli Zaretskii <eliz@gnu.org>
957 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
960 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
962 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
963 Without this fix, if a signal arrives just after memory fills up,
964 'malloc' might be invoked reentrantly.
966 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
967 In other words, assume that every image size is allowed, on non-X
968 hosts. This assumption is probably wrong, but it lets Emacs compile.
970 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
972 * regex.c (re_iswctype): Convert return values to boolean.
974 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
976 * xdisp.c (compute_display_string_pos): Don't use cached display
977 string position if the buffer had its restriction changed.
980 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
982 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
984 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
986 Integer signedness and overflow and related fixes. (Bug#9079)
988 * bidi.c: Integer size and overflow fixes.
989 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
990 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
991 (bidi_cache_find_level_change, bidi_cache_ensure_space)
992 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
993 (bidi_find_other_level_edge):
994 Use ptrdiff_t instead of EMACS_INT where either will do.
995 This works better on 32-bit hosts configured --with-wide-int.
996 (bidi_cache_ensure_space): Check for size-calculation overflow.
997 Use % rather than repeated addition, for better worst-case speed.
998 Don't set bidi_cache_size until after xrealloc returns, because it
1000 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1001 (bidi_cache_ensure_space): Also check that the bidi cache size
1002 does not exceed that of the largest Lisp string or buffer. See Eli
1003 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1005 * alloc.c (__malloc_size_t): Remove.
1006 All uses replaced by size_t. See Andreas Schwab's note
1007 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1009 * image.c: Improve checking for integer overflow.
1010 (check_image_size): Assume that f is nonnull, since
1011 it is always nonnull in practice. This is one less thing to
1012 worry about when checking for integer overflow later.
1013 (x_check_image_size): New function, which checks for integer
1014 overflow issues inside X.
1015 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1016 This removes the need for a memory_full check.
1017 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1018 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1019 (xbm_read_bitmap_data): Change locals back to 'int', since
1020 their values must fit in 'int'.
1021 (xpm_load_image, png_load, tiff_load):
1022 Invoke x_create_x_image_and_pixmap earlier,
1023 to avoid much needless work if the image is too large.
1024 (tiff_load): Treat overly large images as if
1025 x_create_x_image_and_pixmap failed, not as malloc failures.
1026 (gs_load): Use x_check_image_size.
1028 * gtkutil.c: Omit integer casts.
1029 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1030 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1032 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1034 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1035 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1036 would wrongly return t on a 64-bit host.
1038 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1039 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1040 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1041 and therefore cause GCC to emit a bogus diagnostic in some cases.
1043 * image.c: Integer signedness and overflow and related fixes.
1044 This is not an exhaustive set of fixes, but it's time to
1045 record what I've got.
1046 (lookup_pixel_color, check_image_size): Remove redundant decls.
1047 (check_image_size): Don't assume that arbitrary EMACS_INT values
1048 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1049 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1050 (tiff_load, imagemagick_load_image):
1051 Check for overflow in size calculations.
1052 (x_create_x_image_and_pixmap): Remove unnecessary test for
1053 xmalloc returning NULL; that can't happen.
1054 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1055 (xpm_color_bucket): Use better integer hashing function.
1056 (xpm_cache_color): Don't possibly over-allocate memory.
1057 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1058 (gif_memory_source):
1059 Use ptrdiff_t, not int or size_t, to record sizes.
1060 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1061 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1062 either works, as we prefer signed integers.
1063 (tiff_read_from_memory, tiff_write_from_memory):
1064 Return tsize_t, not size_t, since that's what the TIFF API wants.
1065 (tiff_read_from_memory): Don't fail simply because the read would
1066 go past EOF; instead, return a short read.
1067 (tiff_load): Omit no-longer-needed casts.
1068 (Fimagemagick_types): Don't assume size fits into 'int'.
1070 Improve hashing quality when configured --with-wide-int.
1071 * fns.c (hash_string): New function, taken from sxhash_string.
1072 Do not discard information about ASCII character case; this
1073 discarding is no longer needed.
1074 (sxhash-string): Use it. Change sig to match it. Caller changed.
1075 * lisp.h: Declare it.
1076 * lread.c (hash_string): Remove, since we now use fns.c's version.
1077 The fns.c version returns a wider integer if --with-wide-int is
1078 specified, so this should help the quality of the hashing a bit.
1080 * emacs.c: Integer overflow minor fix.
1081 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1082 Define only if GNU_LINUX.
1083 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1085 * dispnew.c: Integer signedness and overflow fixes.
1086 Remove unnecessary forward decls, that were a maintenance hassle.
1087 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1089 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1090 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1091 (prepare_desired_row, line_draw_cost):
1092 Use int, not unsigned, where either works.
1093 (save_current_matrix, restore_current_matrix):
1094 Use ptrdiff_t, not size_t, where either works.
1095 (init_display): Check for overflow more accurately, and without
1096 relying on undefined behavior.
1098 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1099 Remove, replacing with the new symbols in lisp.h. All uses changed.
1100 * fileio.c (make_temp_name):
1101 * filelock.c (lock_file_1, lock_file):
1102 * xdisp.c (message_dolog):
1103 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1104 Use pMd etc. instead.
1105 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1106 replacing the pWIDE etc. symbols removed from editfns.c.
1108 * keyboard.h (num_input_events): Now uintmax_t.
1109 This is (very slightly) less likely to mess up due to wraparound.
1112 * buffer.c: Integer signedness fixes.
1113 (alloc_buffer_text, enlarge_buffer_text):
1114 Use ptrdiff_t rather than size_t when either will do, as we prefer
1117 * alloc.c: Integer signedness and overflow fixes.
1118 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1119 (__malloc_size_t): Default to size_t, not to int.
1120 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1121 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1122 Prefer ptrdiff_t to size_t when either would do, as we prefer
1124 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1125 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1126 Now const. Initialize with values that are in range even if char
1128 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1129 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1130 These functions do the right thing with sizes > 2**32.
1131 (check_depth): Now ptrdiff_t, not int.
1132 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1133 Adjust to new way of storing sizes. Check for size overflow bugs
1135 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1136 slightly wrong anyway, as it missed one instance of
1137 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1138 (refill_memory_reserve): Omit needless cast to size_t.
1139 (mark_object_loop_halt): Mark as externally visible.
1141 * xselect.c: Integer signedness and overflow fixes.
1142 (Fx_register_dnd_atom, x_handle_dnd_message):
1143 Use ptrdiff_t, not size_t, since we prefer signed.
1144 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1145 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1146 x_dnd_atoms_size and x_dnd_atoms_length.
1148 * doprnt.c: Prefer signed to unsigned when either works.
1150 * doprnt.c (doprnt):
1152 * xdisp.c (vmessage):
1153 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1154 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1155 prefer signed arithmetic to avoid comparison confusion.
1156 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1157 but is a bit tricky.
1159 Assume freestanding C89 headers, string.h, stdlib.h.
1160 * data.c, doprnt.c, floatfns.c, print.c:
1161 Include float.h unconditionally.
1162 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1163 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1164 * regex.c: Likewise for stddef.h, string.h.
1165 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1166 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1167 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1168 (STDC_HEADERS): Remove obsolete defines.
1169 * sysdep.c: Include limits.h unconditionally.
1171 Assume support for memcmp, memcpy, memmove, memset.
1172 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1173 * regex.c (memcmp, memcpy):
1174 Remove; we assume C89 now.
1176 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1177 (__malloc_safe_bcopy): Remove; no longer needed.
1179 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1180 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1181 well either way, and we prefer signed to unsigned.
1183 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1185 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1186 closes the connection while we're reading (bug#9182).
1188 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1190 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1191 are specified (Bug#9168).
1193 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1195 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1196 Found by GCC static checking and --with-wide-int on a 32-bit host.
1198 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1200 * xdisp.c (compute_display_string_pos): Fix logic of caching
1201 previous display string position. Initialize cached_prev_pos to
1202 -1. Fixes slow-down at the beginning of a buffer.
1204 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1206 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1207 for attrs[LFACE_FONTSET_INDEX].
1209 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1211 * xml.c (parse_region): Remove unused local
1212 that was recently introduced.
1214 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1216 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1217 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1219 * xdisp.c (move_it_in_display_line_to): Record the best matching
1220 position for TO_CHARPOS while scanning the line, and restore it on
1221 exit if none of the characters scanned was an exact match.
1222 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1223 when exact match is impossible due to invisible text, and the
1224 lines are truncated.
1226 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1228 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1231 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1233 Fix a significant slow-down of cursor motion with C-n, C-p,
1234 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1235 auto-repeat under bidi redisplay in fontified buffers.
1236 * xdisp.c (compute_stop_pos_backwards): New function.
1237 (next_element_from_buffer): Call compute_stop_pos_backwards to
1238 find a suitable prev_stop when we find ourselves before
1240 (reseat): Don't look for prev_stop, as that could mean a very long
1242 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1243 <cached_disp_overlay_modiff>: Cache for last found display string
1245 (compute_display_string_pos): Return the cached position if asked
1246 about the same buffer in the same area of character positions, and
1247 the buffer wasn't changed since the time the display string
1248 position was cached.
1250 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1252 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1253 is an integer, which is important for empty lines. (Bug#9149)
1255 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1257 * frame.c (Fmodify_frame_parameters): In tty case, update the
1258 default face if necessary (Bug#4238).
1260 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1262 * editfns.c (Fstring_to_char): No need to explain what a character
1263 is in the docstring (Bug#6576).
1265 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1267 * xml.c (parse_region): Make sure we always return a tree.
1269 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1271 * xml.c (parse_region): If a document contains only comments,
1274 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1276 * xml.c (make_dom): Return comments, too.
1278 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1281 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1282 and the surrounding thread.
1283 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1284 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1285 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1287 * s/openbsd.h (BROKEN_SIGIO): Define.
1288 * unexelf.c (unexec) [__OpenBSD__]:
1289 Don't update the .mdebug section of the Alpha COFF symbol table.
1291 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1293 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1296 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1298 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1299 This fixes some race conditions on the permissions of any newly
1302 * alloc.c (valid_pointer_p): Use pipe, not open.
1303 This fixes some permissions issues when debugging.
1305 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1306 If fchown fails to set both uid and gid, try to set just gid,
1307 as that is sometimes allowed. Adjust the file's mode to eliminate
1308 setuid or setgid bits that are inappropriate if fchown fails.
1310 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1312 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1313 to compare Lisp_Objects.
1314 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1315 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1316 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1318 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1320 * lread.c (read_integer): Unread even EOF character.
1321 (read1): Likewise. Properly record start position of symbol.
1323 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1324 symbol character follows.
1326 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1328 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1329 This works around a problem with the previous change to Fcopy_file.
1330 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1331 and without this change, GCC might complain about discarding
1332 fchown's return value.
1334 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1336 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1338 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1340 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1342 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1344 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1345 it's used from the C level.
1347 * process.c: Use the same condition for POLL_FOR_INPUT in both
1348 keyboard.c and process.c (bug#1858).
1350 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1352 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1353 (Fgnutls_boot): Use it.
1355 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1357 * doc.c (Fsubstitute_command_keys): Revert last change.
1359 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1361 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1362 quotes the next character, and doesn't affect other longer
1363 sequences (bug#8935).
1365 * lread.c (syms_of_lread): Clarify that is isn't only
1366 `eval-buffer' and `eval-defun' that's affected by
1367 `lexical-binding' (bug#8460).
1369 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1371 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1372 bidi redisplay when a line includes both an image and is
1375 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1377 Fix minor problems found by static checking.
1378 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1379 (elsz): Now a signed constant, not a size_t var. We prefer signed
1380 types to unsigned, to avoid integer comparison confusion. Without
1381 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1382 "cannot optimize loop, the loop counter may overflow", a symptom
1384 * indent.c (Fvertical_motion): Mark locals as initialized.
1385 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1387 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1389 * search.c (Fre_search_backward): Mention `case-fold-search' in
1390 all the re_search_* functions (bug#8138).
1392 * keyboard.c (Fopen_dribble_file): Document when the file is
1395 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1397 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1400 Support bidi reordering of display and overlay strings.
1401 * xdisp.c (compute_display_string_pos)
1402 (compute_display_string_end): Accept additional argument STRING.
1403 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1404 (reseat_to_string): Initialize bidi_it->string.s and
1405 bidi_it->string.schars.
1406 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1407 NULL (avoids a crash in bidi_paragraph_init).
1408 Initialize itb.string.lstring.
1409 (init_iterator): Call bidi_init_it only of a valid
1410 buffer position was specified. Initialize paragraph_embedding to
1412 (reseat_to_string): Initialize the bidi iterator.
1413 (display_string): If we need to ignore text properties of
1414 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1415 original value of -1 will not work with bidi.)
1416 (compute_display_string_pos): First arg is now struct
1417 `text_pos *'; all callers changed. Support display properties on
1419 (compute_display_string_end): Support display properties on Lisp
1421 (init_iterator, reseat_1, reseat_to_string): Initialize the
1422 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1423 when iterating on a string not from display properties).
1424 (compute_display_string_pos, compute_display_string_end):
1425 Fix calculation of the object to scan. Fixes an error when using
1427 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1428 base_level_stop; instead, set base_level_stop to BEGV.
1429 Fixes crashes in vertical-motion.
1430 (next_element_from_buffer): Improve commentary for when
1431 the iterator is before prev_stop.
1432 (init_iterator): Initialize bidi_p from the default value of
1433 bidi-display-reordering, not from buffer-local value. Use the
1434 buffer-local value only if initializing for buffer iteration.
1435 (handle_invisible_prop): Support invisible properties on strings
1436 that are being bidi-reordered.
1437 (set_iterator_to_next): Support bidi reordering of C strings and
1439 (next_element_from_string): Support bidi reordering of Lisp
1441 (handle_stop_backwards): Support Lisp strings as well.
1442 (display_string): Support display of R2L glyph rows.
1443 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1444 (init_iterator): Don't initialize it->bidi_p for strings
1446 (reseat_to_string): Initialize it->bidi_p for strings here.
1447 (next_element_from_string, next_element_from_c_string)
1448 (next_element_from_buffer): Add xassert's for correspondence
1449 between IT's object being iterated and it->bidi_it.string
1451 (face_before_or_after_it_pos): Support bidi iteration.
1452 (next_element_from_c_string): Handle the case of the first string
1453 character that is not the first one in the visual order.
1454 (get_visually_first_element): New function, refactored from common
1455 parts of next_element_from_buffer, next_element_from_string, and
1456 next_element_from_c_string.
1457 (tool_bar_lines_needed, redisplay_tool_bar)
1458 (display_menu_bar): Force left-to-right direction. Add a FIXME
1459 comment for making that be controlled by a user option.
1460 (push_it, pop_it): Save and restore the state of the
1461 bidi iterator. Save and restore the bidi_p flag.
1462 (pop_it): Iterate out of display property for string iteration as
1464 (iterate_out_of_display_property): Support iteration over strings.
1465 (handle_single_display_spec): Set up it->bidi_it for iteration
1466 over a display string, and call bidi_init_it.
1467 (handle_single_display_spec, next_overlay_string)
1468 (get_overlay_strings_1, push_display_prop): Set up the bidi
1469 iterator for displaying display or overlay strings.
1470 (forward_to_next_line_start): Don't use the shortcut if
1472 (back_to_previous_visible_line_start): If handle_display_prop
1473 pushed the iterator stack, restore the internal state of the bidi
1474 iterator by calling bidi_pop_it same number of times.
1475 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1476 and we are bidi-iterating, don't decrement the iterator position;
1477 instead, set the first_elt flag in the bidi iterator, to produce
1479 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1480 (push_display_prop): xassert that we are iterating a buffer.
1481 (push_it, pop_it): Save and restore paragraph_embedding member.
1482 (handle_single_display_spec, next_overlay_string)
1483 (get_overlay_strings_1, reseat_1, reseat_to_string)
1484 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1485 correctly. Don't assume unibyte strings are not bidi-reordered.
1486 (compute_display_string_pos)
1487 (compute_display_string_end): Fix handling the case of C string.
1488 (push_it, pop_it): Save and restore from_disp_prop_p.
1489 (handle_single_display_spec, push_display_prop): Set the
1490 from_disp_prop_p flag.
1491 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1492 (pop_it): Call iterate_out_of_display_property only if we are
1493 popping after iteration over a string that came from a display
1494 property. Fix a typo in popping stretch info. Add an assertion
1495 for verifying that the iterator position is in sync with the bidi
1497 (handle_single_display_spec, get_overlay_strings_1)
1498 (push_display_prop): Fix initialization of paragraph direction for
1499 string when that of the parent object is not yet determined.
1500 (reseat_1): Call bidi_init_it to resync the bidi
1501 iterator with IT's position. (Bug#7616)
1502 (find_row_edges): If ROW->start.pos gives position
1503 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1504 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1505 Reset the from_disp_prop_p flag.
1506 (SAVE_IT, RESTORE_IT): New macros.
1507 (pos_visible_p, face_before_or_after_it_pos)
1508 (back_to_previous_visible_line_start)
1509 (move_it_in_display_line_to, move_it_in_display_line)
1510 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1511 (try_scrolling, redisplay_window, display_line): Use them when
1512 saving a temporary copy of the iterator and restoring it back.
1513 (back_to_previous_visible_line_start, reseat_1)
1514 (init_iterator): Empty the bidi cache "stack".
1515 (move_it_in_display_line_to): If iterator ended up at
1516 EOL, but we never saw any buffer positions smaller than
1517 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1518 motion in bidi-reordered lines.
1519 (move_it_in_display_line_to): Record prev_method and prev_pos
1520 immediately before the call to set_iterator_to_next. Fixes cursor
1521 motion in bidi-reordered lines with stretch glyphs and strings
1522 displayed in margins. (Bug#8133) (Bug#8867)
1523 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1525 (pos_visible_p): Support positions in bidi-reordered lines.
1526 Save and restore bidi cache.
1528 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1529 (bidi_paragraph_info): Delete unused struct.
1530 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1531 (bidi_cache_start): New variable.
1532 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1534 (bidi_cache_fetch_state, bidi_cache_search)
1535 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1536 (bidi_cache_find, bidi_peek_at_next_level)
1537 (bidi_level_of_next_char, bidi_find_other_level_edge)
1538 (bidi_move_to_visually_next): Compare cache index with
1539 bidi_cache_start rather than with zero.
1540 (bidi_fetch_char): Accept new argument STRING; all callers
1541 changed. Support iteration over a string. Support strings with
1542 display properties. Support unibyte strings. Fix the type of
1543 `len' according to what STRING_CHAR_AND_LENGTH expects.
1544 (bidi_paragraph_init, bidi_resolve_explicit_1)
1545 (bidi_resolve_explicit, bidi_resolve_weak)
1546 (bidi_level_of_next_char, bidi_move_to_visually_next):
1547 Support iteration over a string.
1548 (bidi_set_sor_type, bidi_resolve_explicit_1)
1549 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1550 can now be zero (for strings); special values 0 and -1 were
1551 changed to -1 and -2, respectively.
1552 (bidi_char_at_pos): New function.
1553 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1554 Call it instead of FETCH_MULTIBYTE_CHAR.
1555 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1556 initialized to valid values.
1557 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1559 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1560 the test for valid cached positions. Fix the logic for looking up
1561 the sentinel state in the cache. GCPRO the Lisp string we are
1563 (bidi_push_it, bidi_pop_it): New functions.
1564 (bidi_initialize): Initialize the bidi cache start stack pointer.
1565 (bidi_cache_ensure_space): New function, refactored from part of
1566 bidi_cache_iterator_state. Don't assume the required size is just
1567 one BIDI_CACHE_CHUNK away.
1568 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1569 (bidi_count_bytes, bidi_char_at_pos): New functions.
1570 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1571 always valid if bidi_cache_idx is valid.
1572 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1573 is valid if it's going to be used.
1574 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1575 (bidi_cache_fetch_state, bidi_cache_search)
1576 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1577 (bidi_cache_iterator_state, bidi_cache_find)
1578 (bidi_find_other_level_edge, bidi_cache_start_stack):
1579 All variables related to cache indices are now EMACS_INT.
1581 * dispextern.h (struct bidi_string_data): New structure.
1582 (struct bidi_it): New member `string'. Make flag members be 1-bit
1583 fields, and put them last in the struct.
1584 (compute_display_string_pos, compute_display_string_end):
1586 (bidi_push_it, bidi_pop_it): Add prototypes.
1587 (struct iterator_stack_entry): New members bidi_p,
1588 paragraph_embedding, and from_disp_prop_p.
1589 (struct it): Member bidi_p is now a bit field 1 bit wide.
1590 (bidi_shelve_cache, bidi_unshelve_cache):
1593 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1594 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1595 and vector-like objects.
1597 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1598 cache around display iteration.
1600 * window.c (Fwindow_end, window_scroll_pixel_based)
1601 (displayed_window_lines, Frecenter): Save and restore the bidi
1602 cache around display iteration.
1604 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1606 * editfns.c (Fdelete_region): Clarify the use of the named
1607 parameters (bug#6788).
1609 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1611 * indent.c (Fvertical_motion): Set and restore w->pointm when
1612 saving and restoring the window's buffer (Bug#9006).
1614 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1616 * editfns.c (Fstring_to_char): Clarify just what is returned
1617 (bug#6576). Text by Eli Zaretskii.
1619 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1621 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1623 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1625 * buffer.c (mmap_find): Fix a typo.
1627 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1629 Fix execution of x selection hooks.
1630 * xselect.c (Qx_lost_selection_functions)
1631 (Qx_sent_selection_functions): New vars.
1632 (syms_of_xselect): DEFSYM them.
1633 (x_handle_selection_request): Pass Qx_sent_selection_functions
1634 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1635 (x_handle_selection_clear,x_clear_frame_selections):
1636 Pass Qx_lost_selection_functions rather than
1637 Vx_lost_selection_functions to Frun_hook_with_args.
1639 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1641 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1642 The old code sometimes used this field without initializing it.
1644 * alloc.c (gc_sweep): Don't read past end of array.
1645 In theory, the old code could also have corrupted Emacs internals,
1646 though it'd be very unlikely.
1648 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1650 * character.c (Fcharacterp): Don't advertise optional ignored
1651 argument. (Bug#4026)
1653 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1655 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1658 * window.c (Fset_window_start): Doc fix (bug#4199).
1659 (Fset_window_hscroll): Ditto.
1661 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1663 Fix minor new problems caught by GCC 4.6.1.
1664 * term.c (init_tty): Remove unused local.
1665 * xsettings.c (store_monospaced_changed): Define this function only
1666 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1669 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1671 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1673 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1675 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1676 are the mini-buffer and the echo area (bug#3320).
1678 * term.c (init_tty): Remove support for supdup, c10 and perq
1679 terminals, which are no longer supported (bug#1482).
1681 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1683 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1685 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1687 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1688 for non-popups (Bug#3642).
1690 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1692 * alloc.c (reset_malloc_hooks): Protoize.
1693 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1694 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1695 * cm.c (losecursor): Likewise.
1696 * data.c (fmod): Likewise.
1697 * dispnew.c (swap_glyphs_in_rows): Likewise.
1698 * emacs.c (memory_warning_signal): Likewise.
1699 * floatfns.c (float_error): Likewise.
1700 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1701 (otf_open, font_otf_capability, generate_otf_features)
1702 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1704 * image.c (pbm_read_file): Likewise.
1705 * indent.c (string_display_width): Likewise.
1706 * intervals.c (check_for_interval, search_for_interval)
1707 (inc_interval_count, count_intervals, root_interval)
1708 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1709 * lread.c (defalias): Likewise.
1710 * ralloc.c (r_alloc_check): Likewise.
1711 * regex.c (set_image_of_range_1, set_image_of_range)
1712 (regex_grow_registers): Likewise.
1713 * sysdep.c (strerror): Likewise.
1714 * termcap.c (valid_filename_p, tprint, main): Likewise.
1715 * tparam.c (main): Likewise.
1716 * unexhp9k800.c (run_time_remap, save_data_space)
1717 (update_file_ptrs, read_header, write_header, calculate_checksum)
1718 (copy_file, copy_rest, display_header): Likewise.
1719 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1721 * xdisp.c (check_it): Likewise.
1722 * xfaces.c (register_color, unregister_color, unregister_colors):
1724 * xfns.c (print_fontset_result): Likewise.
1725 * xrdb.c (member, fatal, main): Likewise.
1727 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1729 Fix minor problems found by static checking (Bug#9031).
1730 * chartab.c (char_table_set_range, map_sub_char_table):
1731 Remove unused locals.
1732 (uniprop_table): Now static.
1733 * composite.c (_work_char): Remove unused static var.
1735 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1737 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1739 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1741 * gtkutil.c (qttip_cb): Remove code without function.
1743 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1745 * w32.c (pthread_sigmask): New stub.
1747 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1749 Use pthread_sigmask, not sigprocmask (Bug#9010).
1750 sigprocmask is portable only for single-threaded applications, and
1751 Emacs can be multi-threaded when it uses GTK.
1752 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1754 * callproc.c (Fcall_process):
1755 * process.c (create_process):
1756 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1757 Use pthread_sigmask, not sigprocmask.
1759 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1761 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1762 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1765 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1767 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1768 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1769 (xg_hide_tooltip): Fix comment.
1771 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1772 in registerServicesMenuSendTypes.
1773 (validRequestorForSendType): Don't check ns_return_types.
1775 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1778 2011-07-08 Jason Rumney <jasonr@gnu.org>
1780 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1781 frame struct members of non-existent frames (Bug#6284).
1783 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1785 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1786 variable firstTime not needed on OSX >= 10.6.
1787 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1788 >= 10.5. Use setKnobProportion, setDoubleValue.
1790 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1791 (MAC_OS_X_VERSION_10_5): Define if not defined.
1792 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1793 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1794 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1796 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1797 cString and lossyCString on OSX >= 10.4
1799 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1800 sizeToFit on OSX >= 10.2.
1802 * nsimage.m (allocInitFromFile): Don't use deprecated method
1803 bestRepresentationForDevice on OSX >= 10.6.
1805 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1808 * emacs.c: Declare unexec_init_emacs_zone.
1810 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1812 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1814 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1815 on svcsMenu (Bug#8842).
1817 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1819 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1821 * nsterm.m (QUTF8_STRING): Declare.
1822 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1823 (validRequestorForSendType): Return type is (id).
1824 Change indexOfObjectIdenticalTo to indexOfObject.
1825 Check if we have local selection before returning self (Bug#8842).
1826 (writeSelectionToPasteboard): Put local selection into paste board
1827 if we have a local selection (Bug#8842).
1828 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1830 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1831 (ns_get_local_selection): Declare.
1833 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1835 * keymap.c (describe_map_tree): Don't insert a double newline at
1836 the end of the buffer (bug#1169) and return whether we inserted
1839 * callint.c (Fcall_interactively): Change "reading args" to
1840 "providing args" to try to clarify what it does (bug#1010).
1842 2011-07-07 Kenichi Handa <handa@m17n.org>
1844 * composite.c (composition_compute_stop_pos): Ignore a static
1845 composition starting before CHARPOS (Bug#8915).
1847 * xdisp.c (handle_composition_prop): Likewise.
1849 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1851 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1854 2011-07-07 Kenichi Handa <handa@m17n.org>
1856 * character.h (unicode_category_t): New enum type.
1858 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1859 (Qchar_code_property_table): New variable.
1860 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1861 (UNIPROP_COMPRESSED_FORM_P): New macros.
1862 (char_table_ascii): Uncompress the compressed values.
1863 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1864 Uncompress the compressed values.
1865 (sub_char_table_ref_and_range): Likewise.
1866 (char_table_ref_and_range): Uncompress the compressed values.
1867 (sub_char_table_set): New arg is_uniprop. Callers changed.
1868 Uncompress the compressed values.
1869 (sub_char_table_set_range): Args changed. Callers changed.
1870 (char_table_set_range): Adjuted for the above change.
1871 (map_sub_char_table): Delete args default_val and parent. Add arg
1872 top. Give decoded values to a Lisp function.
1873 (map_char_table): Adjust for the above change. Give decoded
1874 values to a Lisp function. Gcpro more variables.
1875 (uniprop_table_uncompress)
1876 (uniprop_decode_value_run_length): New functions.
1877 (uniprop_decoder, uniprop_decoder_count): New variables.
1878 (uniprop_get_decoder, uniprop_encode_value_character)
1879 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1881 (uniprop_encoder, uniprop_encoder_count): New variables.
1882 (uniprop_get_encoder, uniprop_table)
1883 (Funicode_property_table_internal, Fget_unicode_property_internal)
1884 (Fput_unicode_property_internal): New functions.
1885 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1886 Sunicode_property_table_internal, Sget_unicode_property_internal,
1887 and Sput_unicode_property_internal. Defvar_lisp
1888 char-code-property-alist.
1890 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
1891 Vunicode_category_table.
1893 * font.c (font_range): Adjust for the change of
1894 Vunicode_category_table.
1896 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1898 * m/iris4d.h: Remove file, move contents ...
1899 * s/irix6-5.h: ... here.
1901 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1903 Remove unportable assumption about struct layout (Bug#8884).
1904 * alloc.c (mark_buffer):
1905 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1906 (clone_per_buffer_values): Don't assume that
1907 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1908 This isn't true in general, and it's particularly not true
1909 if Emacs is configured with --with-wide-int.
1910 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1911 New macros, used in the buffer.c change.
1913 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1915 * xsettings.c: Use both GConf and GSettings if both are available.
1916 (store_config_changed_event): Add comment.
1917 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1918 (store_tool_bar_style_changed): New functions.
1919 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1920 (struct xsettings): Move font inside HAVE_XFT.
1921 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1922 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
1923 Move inside HAVE_XFT.
1924 (something_changed_gsettingsCB): Rename from something_changedCB.
1925 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1927 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1928 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1929 (something_changed_gconfCB): Rename from something_changedCB.
1930 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1931 (parse_settings): Move check for font inside HAVE_XFT.
1932 (read_settings, apply_xft_settings): Add comment.
1933 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1934 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1935 call store_font_name_changed.
1936 (xft_settings_event): Add comment.
1937 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1938 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1939 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1940 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1941 (xsettings_initialize): Call init_gsettings last.
1942 (xsettings_get_system_font, xsettings_get_system_normal_font):
1945 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1947 Random fixes. E.g., (random) never returned negative values.
1948 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1949 subseconds part to the entropy, as that's a bit more random.
1950 Prefer signed to unsigned, since the signedness doesn't matter and
1951 in general we prefer signed. When given a limit, use a
1952 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1953 latter isn't right if USE_2_TAGS_FOR_INTS.
1954 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1955 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1957 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1959 * textprop.c (text_property_stickiness):
1960 Obey Vtext_property_default_nonsticky.
1961 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1962 * w32fns.c (syms_of_w32fns):
1963 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1965 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1967 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1968 This is more efficient than Ffile_directory_p and avoids a minor race.
1970 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1972 * buffer.c (Foverlay_put): Say what the return value is
1975 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1976 is a directory before asking whether to use the file name
1978 (barf_or_query_if_file_exists): Make the "File is a directory"
1979 error be more correct.
1981 * fns.c (Frequire): Remove the mention of the .gz files, since
1982 that's installation-specific, but keep the mention of
1983 `get-load-suffixes'.
1985 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1987 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1988 Report string overflow if the output is too long.
1990 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1992 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1993 (syms_of_gnutls): Remove duplicate DEFSYM for
1994 Qgnutls_bootprop_verify_hostname_error, an error for
1995 Qgnutls_bootprop_verify_error (which is no longer used).
1997 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1998 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1999 Also (re)move comments that are misplaced or no longer relevant.
2001 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2003 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2005 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2007 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2008 and background color parameters if they have been changed.
2010 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2012 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2014 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2016 * xsettings.c (SYSTEM_FONT): Define only when used.
2017 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2019 * keymap.c (access_keymap_1): Now static.
2021 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2023 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2024 leave any prefix arg for the up event (Bug#1586).
2026 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2028 * lread.c (syms_of_lread): Mention single symbols defined by
2029 `defvar' or `defconst' (bug#7154).
2031 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2032 (Frequire): Mention get-load-suffixes.
2034 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2036 * window.h (window): Remove clone_number slot.
2037 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2039 (make_parent_window, make_window, saved_window)
2040 (Fset_window_configuration, save_window_save): Don't deal with
2042 * buffer.c (Qclone_number): Remove declaration.
2043 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2045 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2047 Add multiple inheritance to keymaps.
2048 * keymap.c (Fmake_composed_keymap): New function.
2049 (Fset_keymap_parent): Simplify.
2050 (fix_submap_inheritance): Remove.
2051 (access_keymap_1): New function extracted from access_keymap to handle
2052 embedded parents and handle lists of maps.
2053 (access_keymap): Use it.
2054 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2055 (Fcopy_keymap): Handle embedded parents.
2056 (Fcommand_remapping, define_as_prefix): Simplify.
2057 (Fkey_binding): Simplify.
2058 (syms_of_keymap): Move minibuffer-local-completion-map,
2059 minibuffer-local-filename-completion-map,
2060 minibuffer-local-must-match-map, and
2061 minibuffer-local-filename-must-match-map to Elisp.
2062 (syms_of_keymap): Defsubr make-composed-keymap.
2063 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2064 (parse_menu_item): Trivial simplification.
2066 2011-07-01 Glenn Morris <rgm@gnu.org>
2068 * Makefile.in (SETTINGS_LIBS): Fix typo.
2070 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2072 * coding.c (Fencode_coding_string): Record the last coding system
2073 used, as the function doc string says (bug#8738).
2075 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2077 * xsettings.c (store_monospaced_changed): Take new font as arg and
2078 check for change against current_mono_font.
2079 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2080 (emacs_settings_constructor, emacs_settings_get_property)
2081 (emacs_settings_set_property, emacs_settings_class_init)
2082 (emacs_settings_init, gsettings_obj): Remove.
2083 (something_changedCB): New function for HAVE_GSETTINGS.
2084 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2085 with value as argument.
2086 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2087 g_settings_new (Bug#8967). Do not create gsettings_obj.
2088 Remove calls to g_settings_bind. Connect something_changedCB to
2091 * xgselect.c: Add defined (HAVE_GSETTINGS).
2092 (xgselect_initialize): Ditto.
2094 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2095 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2098 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2100 * eval.c (struct backtrace): Simplify and port the data structure.
2101 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2102 signed bit field, as this assumption is not portable and it makes
2103 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2104 "char debug_on_exit : 1" as this is not portable either; instead,
2105 use the portable "unsigned int debug_on_exit : 1". Remove unused
2106 member evalargs. Remove obsolete comments about cc bombing out.
2108 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2110 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2111 Let HAVE_GSETTINGS override HAVE_GCONF.
2112 (store_monospaced_changed): New function.
2113 (EMACS_SETTINGS): A new type derived from GObject to handle
2114 GSettings notifications.
2115 (emacs_settings_constructor, emacs_settings_get_property)
2116 (emacs_settings_set_property, emacs_settings_class_init):
2118 (gsettings_client, gsettings_obj): New variables.
2119 (GSETTINGS_SCHEMA): New define.
2120 (something_changedCB): Call store_monospaced_changed.
2121 (init_gsettings): New function.
2122 (xsettings_initialize): Call init_gsettings.
2123 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2126 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2129 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2131 * window.c (resize_root_window, grow_mini_window)
2132 (shrink_mini_window): Rename Qresize_root_window to
2133 Qwindow_resize_root_window and Qresize_root_window_vertically to
2134 Qwindow_resize_root_window_vertically.
2136 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2138 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2140 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2142 * makefile.w32-in: Redesign dependencies so they reflect more
2143 clearly which files are directly included by each source file,
2144 and not through other includes.
2146 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2148 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2149 (sort_overlays, overlay_strings): When an overlay's clone number
2150 matches the window's clone number process the overlay even if
2151 the overlay's window property doesn't match the current window.
2153 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2154 (Fwindow_hchild): Rename to Fwindow_left_child.
2155 (Fwindow_next): Rename to Fwindow_next_sibling.
2156 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2157 (resize_window_check): Rename to window_resize_check.
2158 (resize_window_apply): Rename to window_resize_apply.
2159 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2160 (Fdelete_other_windows_internal, resize_frame_windows)
2161 (Fsplit_window_internal, Fdelete_window_internal)
2162 (grow_mini_window, shrink_mini_window)
2163 (Fresize_mini_window_internal): Fix callers accordingly.
2165 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2167 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2168 (emacs_fixed_set_min_size): Remove.
2169 (emacs_fixed_new): Take frame as argument.
2171 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2172 (_EmacsFixedPrivate): Remove minwidth/height.
2173 Add struct frame *f.
2174 (emacs_fixed_init): Initialize priv->f.
2175 (get_parent_class, emacs_fixed_set_min_size): Remove.
2176 (emacs_fixed_new): Set priv->f to argument.
2177 (emacs_fixed_get_preferred_width)
2178 (emacs_fixed_get_preferred_height): Use min_width/height from
2179 frames size_hint to set minimum and natural (Bug#8919).
2180 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2181 and use min_width/height from frames size_hint to set
2182 min_width/height (Bug#8919).
2184 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2185 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2188 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2190 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2191 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2194 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2196 * process.c (wait_reading_process_output): Bypass select if
2197 waiting for a cell while ignoring keyboard input, and input is
2198 pending. Suggested by Jan Djärv (Bug#8869).
2200 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2202 Use gnulib's dup2 module instead of rolling our own.
2203 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2205 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2207 * dispnew.c (scrolling_window): Before scrolling, turn off a
2208 mouse-highlight in the window being scrolled.
2210 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2212 Move DEFSYM to lisp.h and use everywhere.
2214 * character.h (DEFSYM): Move declaration...
2215 * lisp.h (DEFSYM): ...here.
2221 * w32select.c: Don't include character.h.
2223 * alloc.c (syms_of_alloc):
2224 * buffer.c (syms_of_buffer):
2225 * bytecode.c (syms_of_bytecode):
2226 * callint.c (syms_of_callint):
2227 * casefiddle.c (syms_of_casefiddle):
2228 * casetab.c (init_casetab_once):
2229 * category.c (init_category_once, syms_of_category):
2230 * ccl.c (syms_of_ccl):
2231 * cmds.c (syms_of_cmds):
2232 * composite.c (syms_of_composite):
2233 * dbusbind.c (syms_of_dbusbind):
2234 * dired.c (syms_of_dired):
2235 * dispnew.c (syms_of_display):
2236 * doc.c (syms_of_doc):
2237 * editfns.c (syms_of_editfns):
2238 * emacs.c (syms_of_emacs):
2239 * eval.c (syms_of_eval):
2240 * fileio.c (syms_of_fileio):
2241 * fns.c (syms_of_fns):
2242 * frame.c (syms_of_frame):
2243 * fringe.c (syms_of_fringe):
2244 * insdel.c (syms_of_insdel):
2245 * keymap.c (syms_of_keymap):
2246 * lread.c (init_obarray, syms_of_lread):
2247 * macros.c (syms_of_macros):
2248 * msdos.c (syms_of_msdos):
2249 * print.c (syms_of_print):
2250 * process.c (syms_of_process):
2251 * search.c (syms_of_search):
2252 * sound.c (syms_of_sound):
2253 * syntax.c (init_syntax_once, syms_of_syntax):
2254 * terminal.c (syms_of_terminal):
2255 * textprop.c (syms_of_textprop):
2256 * undo.c (syms_of_undo):
2257 * w32.c (globals_of_w32):
2258 * window.c (syms_of_window):
2259 * xdisp.c (syms_of_xdisp):
2260 * xfaces.c (syms_of_xfaces):
2261 * xfns.c (syms_of_xfns):
2262 * xmenu.c (syms_of_xmenu):
2263 * xsettings.c (syms_of_xsettings):
2264 * xterm.c (syms_of_xterm): Use DEFSYM.
2266 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2268 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2270 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2272 Integer and buffer overflow fixes (Bug#8873).
2274 * print.c (printchar, strout): Check for string overflow.
2275 (PRINTPREPARE, printchar, strout):
2276 Don't set size unless allocation succeeds.
2278 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2279 for sizes. Check for string overflow more accurately.
2280 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2282 * macros.c: Integer and buffer overflow fixes.
2283 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2284 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2285 Use ptrdiff_t, not int, for sizes.
2286 Don't increment bufsize until after realloc succeeds.
2287 Check for size-calculation overflow.
2288 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2290 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2292 * lread.c: Integer overflow fixes.
2293 (read_integer): Radix is now EMACS_INT, not int,
2294 to improve quality of diagnostics for out-of-range radices.
2295 Calculate buffer size correctly for out-of-range radices.
2296 (read1): Check for integer overflow in radices, and in
2297 read-circle numbers.
2298 (read_escape): Avoid int overflow.
2299 (Fload, openp, read_buffer_size, read1)
2300 (substitute_object_recurse, read_vector, read_list, map_obarray):
2301 Use ptrdiff_t, not int, for sizes.
2302 (read1): Use EMACS_INT, not int, for sizes.
2303 Check for size overflow.
2305 * image.c (cache_image): Check for size arithmetic overflow.
2307 * lread.c: Integer overflow issues.
2308 (saved_doc_string_size, saved_doc_string_length)
2309 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2310 Now ptrdiff_t, not int.
2311 (read1): Don't assume doc string length fits in int. Check for
2312 out-of-range doc string lengths.
2313 (read_list): Don't assume file position fits in int.
2314 (read_escape): Check for hex character overflow.
2316 2011-06-22 Leo Liu <sdl.web@gmail.com>
2318 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2319 Move to minibuffer.el.
2321 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2323 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2324 The following patches are for when GLYPH_DEBUG && !XASSERT.
2325 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2326 * dispnew.c (flush_stdout):
2327 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2328 Mark as externally visible.
2329 * dispnew.c (check_window_matrix_pointers): Now static.
2330 * dispnew.c (window_to_frame_vpos):
2331 * xfns.c (unwind_create_frame):
2332 * xterm.c (x_check_font): Remove unused local.
2333 * scroll.c (CHECK_BOUNDS):
2334 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2335 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2336 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2337 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2338 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2340 (debug_method_add): Use va_list and vsprintf rather than relying
2341 on undefined behavior with wrong number of arguments.
2342 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2343 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2344 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2345 since we're not interested in debugging glyphs with old libraries.
2346 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2347 GCC 4.6.0's static checking.
2349 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2351 Integer overflow and signedness fixes (Bug#8873).
2352 A few related buffer overrun fixes, too.
2354 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2356 * dispextern.h (struct face.stipple):
2357 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2358 (x_bitmap_mask, x_allocate_bitmap_record)
2359 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2360 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2361 (x_create_bitmap_from_xpm_data):
2362 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2363 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2365 * xfaces.c (load_pixmap):
2366 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2367 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2368 (.bitmaps_last, struct x_output.icon_bitmap):
2369 Use ptrdiff_t, not int, for bitmap indexes.
2370 (x_allocate_bitmap_record): Check for size overflow.
2371 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2373 Use ptrdiff_t, not int, for overlay counts.
2374 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2375 * editfns.c (overlays_around, get_pos_property):
2376 * textprop.c (get_char_property_and_overlay):
2377 * xdisp.c (next_overlay_change, note_mouse_highlight):
2378 * xfaces.c (face_at_buffer_position):
2379 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2380 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2381 (Fnext_overlay_change, Fprevious_overlay_change)
2382 (mouse_face_overlay_overlaps, Foverlays_in):
2383 Use ptrdiff_t, not int, for sizes.
2384 (overlays_at, overlays_in): Check for size-calculation overflow.
2386 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2388 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2389 (x_session_initialize): Do not assume string length fits in int.
2391 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2392 This is unlikely, but can occur if DPI is outlandish.
2394 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2395 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2397 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2398 * xrdb.c (magic_file_p, search_magic_path):
2399 Omit last arg SUFFIX; it was always 0. All callers changed.
2400 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2402 * xfont.c (xfont_match): Avoid need for strlen.
2404 * xfns.c: Don't assume strlen fits in int.
2405 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2407 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2408 not unsigned long, as we prefer signed integers. All callers changed.
2409 Detect integer overflow in repeat count.
2410 (message_dolog): Don't assume print length fits in 39 bytes.
2411 (display_mode_element): Don't assume strlen fits in int.
2413 * termcap.c: Don't assume sizes fit in int and never overflow.
2414 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2415 (gobble_line): Check for size-calculation overflow.
2417 * minibuf.c (Fread_buffer):
2418 * lread.c (intern, intern_c_string):
2419 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2420 Don't assume string length fits in int.
2422 * keyboard.c (parse_tool_bar_item):
2423 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2425 * font.c: Don't assume string length fits in int.
2426 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2427 Use ptrdiff_t, not int.
2428 (font_intern_prop): Don't assume string length fits in int.
2429 Don't assume integer property fits in fixnum.
2430 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2432 * filelock.c: Fix some buffer overrun and integer overflow issues.
2433 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2434 Reformulate so as not to need the command string.
2435 Invoke gzip -cd rather than gunzip, as it's more portable.
2436 (lock_info_type, lock_file_1, lock_file):
2437 Don't assume pid_t and time_t fit in unsigned long.
2438 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2439 (current_lock_owner): Prefer signed type for sizes.
2440 Use memcpy, not strncpy, where memcpy is what is really wanted.
2441 Don't assume (via atoi) that time_t and pid_t fit in int.
2442 Check for time_t and/or pid_t out of range, e.g., via a network share.
2443 Don't alloca where an auto var works fine.
2445 * fileio.c: Fix some integer overflow issues.
2446 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2447 Don't assume string length fits in int.
2448 (directory_file_name): Don't assume string length fits in long.
2449 (make_temp_name): Don't assume pid fits in int, or that its print
2450 length is less than 20.
2452 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2454 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2456 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2458 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2459 We prefer signed integers, even for size calculations.
2461 * emacs.c: Don't assume string length fits in 'int'.
2462 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2463 (main): Don't invoke strlen when not needed.
2465 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2466 (XD_DEBUG_MESSAGE): Don't waste a byte.
2468 * callproc.c (getenv_internal_1, getenv_internal)
2470 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2472 * lread.c (invalid_syntax): Omit length argument.
2473 All uses changed. This doesn't fix a bug, but it simplifies the
2474 code away from its former Hollerith-constant appearance, and it's
2475 one less 'int' to worry about when looking at integer-overflow issues.
2476 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2478 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2479 This didn't break anything, but it didn't help either.
2480 It's confusing to put a bogus integer in a place where the actual
2481 value does not matter.
2482 (LIST_END_P): Remove unused macro and its bogus comment.
2483 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2485 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2486 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2488 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2489 We prefer signed types, and the value cannot exceed the EMACS_INT
2490 range anyway (because otherwise the length would not be representable).
2491 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2492 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2493 This avoids a GCC warning when WIDE_EMACS_INT.
2495 * indent.c (sane_tab_width): New function.
2496 (current_column, scan_for_column, Findent_to, position_indentation)
2497 (compute_motion): Use it. This is just for clarity.
2498 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2500 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2502 * lisp.h (lint_assume): New macro.
2503 * composite.c (composition_gstring_put_cache):
2504 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2506 * editfns.c, insdel.c:
2507 Omit unnecessary forward decls, to simplify future changes.
2509 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2511 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2513 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2514 Use much-faster test for byte-length change.
2515 Don't assume string byte-length fits in 'int'.
2516 Check that character arg fits in 'int'.
2517 (mapcar1): Declare byte as byte, for clarity.
2519 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2521 * fns.c (concat): Catch string overflow earlier.
2522 Do not rely on integer wraparound.
2524 * dispextern.h (struct it.overlay_strings_charpos)
2525 (struct it.selective): Now EMACS_INT, not int.
2526 * xdisp.c (forward_to_next_line_start)
2527 (back_to_previous_visible_line_start)
2528 (reseat_at_next_visible_line_start, next_element_from_buffer):
2529 Don't arbitrarily truncate the value of 'selective' to int.
2531 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2533 * composite.c: Don't truncate sizes to 'int'.
2534 (composition_gstring_p, composition_reseat_it)
2535 (composition_adjust_point): Use EMACS_INT, not int.
2536 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2537 not EMACS_UINT, for indexes.
2539 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2541 * buffer.c: Include <verify.h>.
2542 (struct sortvec.priority, struct sortstr.priority):
2543 Now EMACS_INT, not int.
2544 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2545 (struct sortstr.size, record_overlay_string)
2546 (struct sortstrlist.size, struct sortlist.used):
2547 Don't truncate size to int.
2548 (record_overlay_string): Check for size-calculation overflow.
2549 (init_buffer_once): Check at compile-time, not run-time.
2551 2011-06-22 Jim Meyering <meyering@redhat.com>
2553 Don't leak an XBM-image-sized buffer
2554 * image.c (xbm_load): Free the image buffer after using it.
2556 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2559 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2560 that Sun C diagnosed.
2561 * fns.c (secure_hash): Fix pointer signedness issue.
2562 * intervals.c (static_offset_intervals): New function.
2563 (offset_intervals): Use it.
2565 2011-06-21 Leo Liu <sdl.web@gmail.com>
2568 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2571 * fns.c (secure_hash): Rename from crypto_hash_function and change
2572 the first arg to accept symbols.
2573 (Fsecure_hash): New primitive.
2574 (syms_of_fns): New symbols.
2576 2011-06-20 Deniz Dogan <deniz@dogan.se>
2578 * process.c (Fset_process_buffer): Clarify return value in
2581 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2583 * dispnew.c (add_window_display_history): Use BVAR.
2585 * xdisp.c (debug_method_add): Use BVAR.
2586 (check_window_end, dump_glyph_matrix, dump_glyph)
2587 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2589 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2592 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2593 check till after the cache is created in init_frame_faces.
2595 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2597 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2599 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2601 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2602 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2603 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2605 Improve buffer-overflow checking (Bug#8873).
2606 * fileio.c (Finsert_file_contents):
2607 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2608 Remove the old (too-loose) buffer overflow checks.
2609 They weren't needed, since make_gap checks for buffer overflow.
2610 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2611 The old code merely checked for Emacs fixnum overflow, and relied
2612 on undefined (wraparound) behavior. The new code avoids undefined
2613 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2615 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2616 Tune. Don't use wider integers than needed. Don't use alloca.
2617 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2619 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2621 * insdel.c, lisp.h (buffer_overflow): New function.
2622 (insert_from_buffer_1, replace_range, replace_range_2):
2623 * insdel.c (make_gap_larger):
2624 * editfns.c (Finsert_char):
2625 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2627 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2629 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2631 Integer overflow and signedness fixes (Bug#8873).
2633 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2634 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2636 * fileio.c: Don't assume EMACS_INT fits in off_t.
2637 (emacs_lseek): New static function.
2638 (Finsert_file_contents, Fwrite_region): Use it.
2639 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2641 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2643 * fns.c: Don't overflow int when computing a list length.
2644 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2645 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2646 truncation on 64-bit hosts. Check for QUIT every
2647 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2648 faster and is responsive enough.
2649 (Flength): Report an error instead of overflowing an integer.
2650 (Fsafe_length): Return a float if the value is not representable
2651 as a fixnum. This shouldn't happen except in contrived situations.
2652 (Fnthcdr, Fsort): Don't assume list length fits in int.
2653 (Fcopy_sequence): Don't assume vector length fits in int.
2655 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2656 (header_size, word_size): New constants.
2657 (allocate_vectorlike): Don't check size overflow here.
2658 (allocate_vector): Check it here instead, since this is the only
2659 caller of allocate_vectorlike that could cause overflow.
2660 Check that the new vector's length is representable as a fixnum.
2662 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2663 The previous code was bogus. For example, next_almost_prime (32)
2664 returned 39, which is undesirable as it is a multiple of 3; and
2665 next_almost_prime (24) returned 25, which is a multiple of 5 so
2666 why was the code bothering to check for multiples of 7?
2668 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2670 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2672 Variadic C functions now count arguments with ptrdiff_t.
2673 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2674 Back then I didn't know that the Emacs coding style prefers signed int.
2675 Also, in the meantime I found a few more instances where arguments
2676 were being counted with int, which may truncate counts on 64-bit
2677 machines, or EMACS_INT, which may be unnecessarily wide.
2678 * lisp.h (struct Lisp_Subr.function.aMANY)
2679 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2680 Arg counts are now ptrdiff_t, not size_t.
2681 All variadic functions and their callers changed accordingly.
2682 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2683 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2684 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2685 * callint.c (Fcall_interactively): Check arg count for overflow,
2686 to avoid potential buffer overrun. Use signed char, not 'int',
2687 for 'varies' array, so that we needn't bother to check its size
2688 calculation for overflow.
2689 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2690 * eval.c (apply_lambda):
2691 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2692 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2693 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2695 * callint.c (Fcall_interactively): Don't use index var as event count.
2697 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2698 * mem-limits.h (SIZE): Remove; no longer used.
2700 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2702 Remove unnecessary casts.
2703 * xterm.c (x_term_init):
2704 * xfns.c (x_set_border_pixel):
2705 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2706 These aren't needed now that we assume ANSI C.
2708 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2709 It's more likely to cause problems (due to unsigned overflow)
2712 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2714 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2716 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2718 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2720 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2722 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2724 GLYPH_CODE_FACE returns EMACS_INT, not int.
2725 * dispextern.h (merge_faces):
2726 * xfaces.c (merge_faces):
2727 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2728 Don't assume EMACS_INT fits in int.
2730 * character.h (CHAR_VALID_P): Remove unused parameter.
2731 * fontset.c, lisp.h, xdisp.c: All uses changed.
2733 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2735 * fns.c (concat): Minor tuning based on overflow analysis.
2736 This doesn't fix any bugs. Use int to hold character, instead
2737 of constantly refetching from Emacs object. Use XFASTINT, not
2738 XINT, for value known to be a character. Don't bother comparing
2739 a single byte to 0400, as it's always less.
2741 * floatfns.c (Fexpt):
2742 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2744 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2747 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2749 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2750 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2751 incorrectly succeed when S was a string, because 4294967386 was
2752 truncated before it was used.
2754 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2755 Otherwise, an out-of-range integer could cause undefined behavior
2758 * composite.c: Use int, not EMACS_INT, for characters.
2759 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2760 EMACS_INT, for values that are known to be in character range.
2761 This doesn't fix any bugs but is the usual style inside Emacs and
2762 may generate better code on 32-bit machines.
2764 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2765 This is for reasons similar to the recent CHAR_STRING fix.
2766 * charset.c (Fencode_char): Check that character arg is actually
2767 a character. Pass an int to ENCODE_CHAR.
2768 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2769 wider than 'int', as a compile-time check to prevent future regressions
2772 * character.c (char_string): Remove unnecessary casts.
2774 Make sure a 64-bit char is never passed to CHAR_STRING.
2775 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2776 by silently ignoring the top 32 bits, allowing some values
2777 that were far too large to be valid characters.
2778 * character.h: Include <verify.h>.
2779 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2780 arguments are no wider than unsigned, as a compile-time check
2781 to prevent future regressions in this area.
2783 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2784 (Fsubst_char_in_region):
2786 * xdisp.c (decode_mode_spec_coding):
2787 Adjust to CHAR_STRING's new requirement.
2788 * editfns.c (Finsert_char, Fsubst_char_in_region):
2789 * fns.c (concat): Check that character args are actually
2790 characters. Without this test, these functions did the wrong
2791 thing with wildly out-of-range values on 64-bit hosts.
2793 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2794 These casts should not be needed on 32-bit hosts, either.
2795 * keyboard.c (read_char):
2796 * lread.c (Fload): Remove casts to unsigned.
2798 * lisp.h (UNSIGNED_CMP): New macro.
2799 This fixes comparison bugs on 64-bit hosts.
2800 (ASCII_CHAR_P): Use it.
2801 * casefiddle.c (casify_object):
2802 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2803 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2804 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2805 * dispextern.h (FACE_FROM_ID):
2806 * keyboard.c (read_char): Use UNSIGNED_CMP.
2808 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2809 not to EMACS_INT, to avoid GCC warning.
2811 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2813 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2814 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2815 isn't needed on 32-bit machines.
2817 * buffer.c (Fgenerate_new_buffer_name):
2818 Use EMACS_INT for count, not int.
2819 (advance_to_char_boundary): Return EMACS_INT, not int.
2821 * data.c (Qcompiled_function): Now static.
2823 * window.c (window_body_lines): Now static.
2825 * image.c (gif_load): Rename local to avoid shadowing.
2827 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2828 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2829 * alloc.c (make_save_value): Integer argument is now of type
2831 (mark_object): Use ptrdiff_t, not int.
2832 * lisp.h (pD): New macro.
2833 * print.c (print_object): Use it.
2835 * alloc.c: Use EMACS_INT, not int, to count objects.
2836 (total_conses, total_markers, total_symbols, total_vector_size)
2837 (total_free_conses, total_free_markers, total_free_symbols)
2838 (total_free_floats, total_floats, total_free_intervals)
2839 (total_intervals, total_strings, total_free_strings):
2840 Now EMACS_INT, not int. All uses changed.
2841 (Fgarbage_collect): Compute overall total using a double, so that
2842 integer overflow is less likely to be a problem. Check for overflow
2843 when converting back to an integer.
2844 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2845 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2846 These were 'int' variables that could overflow on 64-bit hosts;
2847 they were never used, so remove them instead of repairing them.
2848 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2849 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2850 Previously, this ceilinged at INT_MAX, but that doesn't work on
2852 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2854 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2855 (allocate_vectorlike): Check for ptrdiff_t overflow.
2856 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2857 when a (possibly-narrower) signed value would do just as well.
2858 We prefer using signed arithmetic, to avoid comparison confusion.
2860 * alloc.c: Catch some string size overflows that we were missing.
2861 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2862 for convenience in STRING_BYTES_MAX.
2863 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2864 The definition here is exact; the one in lisp.h was approximate.
2865 (allocate_string_data): Check for string overflow. This catches
2866 some instances we weren't catching before. Also, it catches
2867 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2868 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2869 and ptrdiff_t and EMACS_INT are both 64 bits.
2871 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2872 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2873 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
2875 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2877 * alloc.c (Fmake_string): Check for out-of-range init.
2879 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2881 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2883 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2885 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2886 xg_get_default_scrollbar_width.
2888 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2889 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2890 (style_changed_cb): Call update_theme_scrollbar_width and call
2891 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2892 all frames (Bug#8505).
2893 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2894 Call gtk_window_set_resizable if HAVE_GTK3.
2895 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2896 and height if HAVE_GTK3 (Bug#8505).
2897 (scroll_bar_width_for_theme): New variable.
2898 (update_theme_scrollbar_width): New function.
2899 (xg_get_default_scrollbar_width): Move code to
2900 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2901 (xg_initialize): Call update_theme_scrollbar_width.
2903 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2905 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2907 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2909 * frame.c (make_frame): Call other_buffer_safely instead of
2912 * window.c (temp_output_buffer_show): Call display_buffer with
2913 second argument Vtemp_buffer_show_specifiers and reset latter
2914 immediately after the call.
2915 (Vtemp_buffer_show_specifiers): New variable.
2916 (auto_window_vscroll_p, next_screen_context_lines)
2917 (Vscroll_preserve_screen_position): Remove leading asterisks from
2920 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2922 Fix minor problems found by GCC 4.6.0 static checking.
2923 * buffer.c (Qclone_number): Remove for now, as it's unused.
2924 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2925 (record_buffer): Remove unused local.
2926 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2927 (set_frame_buffer_list): Remove; unused.
2928 * frame.h (other_visible_frames): Remove decl.
2929 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2930 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2931 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2933 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2934 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2935 Define only if HAVE_GPM.
2936 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2937 (update_hints_inhibit): Remove; never set. All uses removed.
2938 * widgetprv.h (emacsFrameClassRec): Remove decl.
2939 * window.c (delete_deletable_window): Now returns void, since it
2940 wasn't returning anything.
2941 (compare_window_configurations): Remove unused locals.
2942 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2943 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2944 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2945 the same widths as pointers. This follows up on the 2011-05-06 patch.
2946 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2947 * xterm.h: Likewise.
2948 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2950 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2952 * makefile.w32-in: Update dependencies.
2953 (LISP_H): Add lib/intprops.h.
2955 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2957 * image.c (gif_load): Add animation frame delay to the metadata.
2958 (syms_of_image): Use DEFSYM. New symbol `delay'.
2960 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2962 * window.c (delete_deletable_window): Re-add.
2963 (Fset_window_configuration): Rewrite to handle dead buffers and
2964 consequently deletable windows.
2965 (window_tree, Fwindow_tree): Remove. Supply functionality in
2967 (compare_window_configurations): Simplify code.
2969 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2971 * image.c (imagemagick_load_image): Fix type mismatch.
2972 (Fimagemagick_types): Likewise.
2974 * window.h (replace_buffer_in_windows): Declare.
2976 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2978 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2979 Qclone_number. Remove external declaration of Qdelete_window.
2980 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2982 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2983 Run Qbuffer_list_update_hook if allowed.
2984 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2985 buffer list implementation.
2986 (other_buffer_safely): New function.
2987 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2988 calls to replace_buffer_in_windows and
2989 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2991 (record_buffer): Inhibit quitting and rewrite using quittable
2992 functions. Run Qbuffer_list_update_hook if allowed.
2993 (Frecord_buffer, Funrecord_buffer): New functions.
2994 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2995 Move switch-to-buffer to window.el.
2996 (bury-buffer): Move to window.el.
2997 (Vbuffer_list_update_hook): New variable.
2999 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3002 * window.h (resize_frame_windows): Move up in code.
3003 (Fwindow_frame): Remove EXFUN.
3004 (replace_buffer_in_all_windows): Remove prototype.
3005 (replace_buffer_in_windows_safely): Add prototype.
3007 * window.c: Declare Qdelete_window static again. Move down
3008 declaration of select_count.
3009 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3010 (Fother_window): Move to window.el.
3011 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3012 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3013 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3015 (replace_buffer_in_windows): Implement by calling
3016 Qreplace_buffer_in_windows.
3017 (replace_buffer_in_all_windows): Remove with some functionality
3018 moved into replace_buffer_in_windows_safely.
3019 (replace_buffer_in_windows_safely): New function.
3020 (select_window_norecord, select_frame_norecord): Move in front
3021 of run_window_configuration_change_hook. Remove now obsolete
3023 (Fset_window_buffer): Rewrite doc-string.
3024 Call Qrecord_window_buffer.
3025 (keys_of_window): Move binding for other-window to window.el.
3027 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3029 * dispextern.h (struct image): Replace data member, whose int_val
3030 and ptr_val fields were not used by anything, with a single
3033 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3034 (gif_clear_image, gif_load, imagemagick_load_image)
3035 (gs_clear_image, gs_load): Callers changed.
3037 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3039 * buffer.h: Include <time.h>, for time_t.
3040 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3042 Fix minor problems found by static checking.
3044 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3046 Make identifiers static if they are not used in other modules.
3047 * data.c (Qcompiled_function, Qframe, Qvector):
3048 * image.c (QimageMagick, Qsvg):
3049 * minibuf.c (Qmetadata):
3050 * window.c (resize_window_check, resize_root_window): Now static.
3051 * window.h (resize_window_check, resize_root_window): Remove decls.
3053 * window.c (window_deletion_count, delete_deletable_window):
3055 (window_body_lines): Now static.
3056 (Fdelete_other_windows_internal): Mark vars as initialized.
3057 Make sure 'resize_failed' is initialized.
3058 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3059 (resize_window_apply): Remove unused local.
3060 * window.h (delete_deletable_window): Remove decl.
3062 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3063 (imagemagick_load_image): Fix pointer signedness problem by changing
3064 last arg from unsigned char * to char *. All uses changed.
3065 Also, fix a local for similar reasons.
3066 Remove unused locals. Remove locals to avoid shadowing.
3067 (fn_rsvg_handle_free): Remove; unused.
3068 (svg_load, svg_load_image): Fix pointer signedness problem.
3069 (imagemagick_load_image): Don't use garbage pointer image_wand.
3071 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3073 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3075 * image.c (gif_load): Fix omitted cast error introduced by
3078 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3080 * window.h (resize_proportionally, orig_total_lines)
3081 (orig_top_line): Remove from window structure.
3082 (set_window_height, set_window_width, change_window_heights)
3083 (Fdelete_window): Remove prototypes.
3084 (resize_frame_windows): Remove duplicate declaration.
3086 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3088 * window.h (resize_frame_windows, resize_window_check)
3089 (delete_deletable_window, resize_root_window)
3090 (resize_frame_windows): Declare prototypes.
3092 * window.c (resize_window_apply): Make definition be "static" to
3093 match the prototype.
3095 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3097 * window.c: Remove declarations of Qwindow_size_fixed,
3098 window_min_size_1, window_min_size_2, window_min_size,
3099 size_window, window_fixed_size_p, enlarge_window, delete_window.
3100 Remove static from declaration of Qdelete_window, it's
3101 temporarily needed by Fbury_buffer.
3102 (replace_window): Don't assign orig_top_line and
3104 (Fdelete_window, delete_window): Remove. Window deletion is
3105 handled by window.el.
3106 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3107 Replace Fdelete_window calls with calls to Qdelete_window.
3108 (Fdelete_other_windows): Remove. Deleting other windows is
3109 handled by window.el.
3110 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3111 handled in window.el.
3112 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3113 Window minimum sizes are handled in window.el.
3114 (shrink_windows, size_window, set_window_height)
3115 (set_window_width, change_window_heights, window_height)
3116 (window_width, CURBEG, CURSIZE, enlarge_window)
3117 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3118 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3119 handled in window.el.
3120 (make_dummy_parent): Rename to make_parent_window and give it a
3121 second argument horflag.
3122 (make_window): Don't set resize_proportionally any more.
3123 (Fsplit_window): Remove. Windows are split in window.el.
3124 (save_restore_action, save_restore_orig_size)
3125 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3126 Resize mini windows in window.el.
3127 (grow_mini_window, shrink_mini_window): Implement by calling
3128 Qresize_root_window_vertically, resize_window_check and
3129 resize_window_apply.
3130 (saved_window, Fset_window_configuration, save_window_save):
3131 Do not handle orig_top_line, orig_total_lines, and
3132 resize_proportionally.
3133 (window_min_height, window_min_width): Move to window.el.
3134 (keys_of_window): Move bindings for delete-other-windows,
3135 split-window, delete-window and enlarge-window to window.el.
3137 * buffer.c: Temporarily extern Qdelete_window.
3138 (Fbury_buffer): Temporarily call Qdelete_window instead of
3139 Fdelete_window (Fbury_buffer will move to window.el soon).
3141 * frame.c (set_menu_bar_lines_1): Remove code handling
3142 orig_top_line and orig_total_lines.
3144 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3145 set_window_height but set heights directly.
3146 (change_frame_size_1): Use resize_frame_windows.
3148 * xdisp.c (init_xdisp): Don't use set_window_height but set
3151 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3152 Use resize_frame_windows instead of change_window_heights and run
3153 run_window_configuration_change_hook.
3155 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3156 instead of change_window_heights and run
3157 run_window_configuration_change_hook.
3159 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3161 * window.c (replace_window): Rename second argument REPLACEMENT to
3162 NEW. New third argument SETFLAG. Rewrite.
3163 (delete_window, make_dummy_parent): Call replace_window with
3165 (window_list_1): Move down in code.
3166 (run_window_configuration_change_hook): Move set_buffer part
3167 before select_frame_norecord part in order to unwind correctly.
3168 Rename count1 to count.
3169 (recombine_windows, delete_deletable_window, resize_root_window)
3170 (Fdelete_other_windows_internal)
3171 (Frun_window_configuration_change_hook, make_parent_window)
3172 (resize_window_check, resize_window_apply, Fresize_window_apply)
3173 (resize_frame_windows, Fsplit_window_internal)
3174 (Fdelete_window_internal, Fresize_mini_window_internal):
3176 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3178 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3180 * window.h (window): Add some new members to window structure -
3181 normal_lines, normal_cols, new_total, new_normal, clone_number,
3182 splits, nest, prev_buffers, next_buffers.
3183 (WINDOW_TOTAL_SIZE): Move here from window.c.
3184 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3186 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3188 (make_dummy_parent): Set new members of windows structure.
3189 (make_window): Move down in code. Handle new members of window
3191 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3192 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3193 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3194 (Fset_window_prev_buffers, Fwindow_next_buffers)
3195 (Fset_window_next_buffers, Fset_window_clone_number):
3197 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3198 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3200 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3201 Argument WINDOW can be now internal window too.
3202 (Fwindow_use_time): Move up in code.
3203 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3205 (Fset_window_configuration, saved_window)
3206 (Fcurrent_window_configuration, save_window_save): Handle new
3207 members of window structure.
3208 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3209 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3210 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3211 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3212 Qget_mru_window, Qresize_root_window,
3213 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3214 Qauto_buffer_name; staticpro them.
3216 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3218 * window.c (Fwindow_total_size, Fwindow_left_column)
3219 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3220 (Fwindow_list_1): New functions.
3221 (window_box_text_cols): Replace with window_body_cols.
3222 (Fwindow_width, Fscroll_left, Fscroll_right):
3223 Use window_body_cols instead of window_box_text_cols.
3224 (delete_window, Fset_window_configuration):
3225 Call delete_all_subwindows with window as argument.
3226 (delete_all_subwindows): Take a window as argument and not a
3228 (window_loop): Remove handling of GET_LRU_WINDOW and
3230 (Fget_lru_window, Fget_largest_window): Move to window.el.
3232 * window.h: Extern window_body_cols instead of
3233 window_box_text_cols. delete_all_subwindows now takes a
3234 Lisp_Object as argument.
3236 * indent.c (compute_motion, Fcompute_motion):
3237 Use window_body_cols instead of window_box_text_cols.
3239 * frame.c (delete_frame): Call delete_all_subwindows with root
3242 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3244 * fns.c (Fputhash): Document return value.
3246 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3248 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3250 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3252 Cons<->int and similar integer overflow fixes (Bug#8794).
3254 Check for overflow when converting integer to cons and back.
3255 * charset.c (Fdefine_charset_internal, Fdecode_char):
3256 Use cons_to_unsigned to catch overflow.
3257 (Fencode_char): Use INTEGER_TO_CONS.
3258 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3259 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3260 * data.c (long_to_cons, cons_to_long): Remove.
3261 (cons_to_unsigned, cons_to_signed): New functions.
3262 These signal an error for invalid or out-of-range values.
3263 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3264 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3265 * font.c (Ffont_variation_glyphs):
3266 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3267 * lisp.h: Include <intprops.h>.
3268 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3269 (cons_to_signed, cons_to_unsigned): New decls.
3270 (long_to_cons, cons_to_long): Remove decls.
3271 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3272 (Fprimitive_undo): Use CONS_TO_INTEGER.
3273 * xfns.c (Fx_window_property): Likewise.
3274 * xselect.c: Include <limits.h>.
3275 (x_own_selection, selection_data_to_lisp_data):
3276 Use INTEGER_TO_CONS.
3277 (x_handle_selection_request, x_handle_selection_clear)
3278 (x_get_foreign_selection, Fx_disown_selection_internal)
3279 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3280 (lisp_data_to_selection_data): Use cons_to_unsigned.
3281 (x_fill_property_data): Use cons_to_signed.
3282 Report values out of range.
3284 Check for buffer and string overflow more precisely.
3285 * buffer.h (BUF_BYTES_MAX): New macro.
3286 * lisp.h (STRING_BYTES_MAX): New macro.
3287 * alloc.c (Fmake_string):
3288 * character.c (string_escape_byte8):
3289 * coding.c (coding_alloc_by_realloc):
3290 * doprnt.c (doprnt):
3291 * editfns.c (Fformat):
3293 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3294 since they may not be the same number.
3295 * editfns.c (Finsert_char):
3296 * fileio.c (Finsert_file_contents):
3297 Likewise for BUF_BYTES_MAX.
3299 * image.c: Use ptrdiff_t, not int, for sizes.
3300 (slurp_file): Switch from int to ptrdiff_t.
3302 (slurp_file): Check that file size fits in both size_t (for
3303 malloc) and ptrdiff_t (for sanity and safety).
3305 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3306 if b->modtime has its maximal value.
3308 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3310 Don't assume time_t can fit into int.
3311 * buffer.h (struct buffer.modtime): Now time_t, not int.
3312 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3313 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3315 Minor fixes for signed vs unsigned integers.
3316 * character.h (MAYBE_UNIFY_CHAR):
3317 * charset.c (maybe_unify_char):
3318 * keyboard.c (read_char, reorder_modifiers):
3319 XINT -> XFASTINT, since the integer must be nonnegative.
3320 * ftfont.c (ftfont_spec_pattern):
3321 * keymap.c (access_keymap, silly_event_symbol_error):
3322 XUINT -> XFASTINT, since the integer must be nonnegative.
3323 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3324 since it makes no difference and we prefer signed.
3325 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3326 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3329 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3331 * window.h (Fwindow_frame): Declare.
3333 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3335 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3336 (SPARE_MEMORY): Always define.
3337 (LARGE_REQUEST): Remove.
3338 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3340 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3342 * lisp.h: Move EXFUNS for Fframe_root_window,
3343 Fframe_first_window and Fset_frame_selected_window to window.h.
3345 * window.h: Move EXFUNS for Fframe_root_window,
3346 Fframe_first_window and Fset_frame_selected_window here from
3349 * frame.c (Fwindow_frame, Fframe_first_window)
3350 (Fframe_root_window, Fframe_selected_window)
3351 (Fset_frame_selected_window): Move to window.c.
3352 (Factive_minibuffer_window): Move to minibuf.c.
3353 (Fother_visible_frames_p): New function.
3355 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3357 * window.c (decode_window, decode_any_window): Move up in code.
3358 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3359 (inhibit_frame_unsplittable): Remove unused variable.
3360 (Fwindow_buffer): Move up and rewrite doc-string.
3361 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3362 (Fwindow_prev): New functions.
3363 (Fwindow_frame): Move here from frame.c. Accept any window as
3365 (Fframe_root_window, Fframe_first_window)
3366 (Fframe_selected_window): Move here from frame.c. Accept frame
3367 or arbitrary window as argument. Update doc-strings.
3368 (Fminibuffer_window): Move up in code.
3369 (Fwindow_minibuffer_p): Move up in code and simplify.
3370 (Fset_frame_selected_window): Move here from frame.c.
3372 (Fselected_window, select_window, Fselect_window): Move up in
3373 code. Minor doc-string fixes.
3375 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3377 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3378 Do not assume that spare memory exists; that assumption is valid
3379 only if SYSTEM_MALLOC.
3380 (LARGE_REQUEST): New macro, so that the issue of large requests
3381 is separated from the issue of spare memory.
3383 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3385 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3388 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3390 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3393 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3395 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3397 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3399 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3400 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3402 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3404 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3406 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3408 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3409 (x_clipboard_manager_save): Add return value.
3410 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3412 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3413 Obey Vx_select_enable_clipboard_manager. Catch errors in
3414 x_clipboard_manager_save (Bug#8779).
3415 (Vx_select_enable_clipboard_manager): New variable.
3416 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3418 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3420 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3422 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3424 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3425 in the current matrix if keep_current_p is non-zero.
3427 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3429 * bidi.c (bidi_level_of_next_char): Fix last change.
3431 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3433 Support bidi reordering of text covered by display properties.
3435 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3436 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3437 (bidi_cache_search, bidi_cache_iterator_state)
3438 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3439 (bidi_level_of_next_char, bidi_move_to_visually_next):
3440 Support character positions inside a run of characters covered by a
3442 (bidi_paragraph_init, bidi_resolve_explicit_1)
3443 (bidi_level_of_next_char): Call bidi_fetch_char and
3444 bidi_fetch_char_advance instead of FETCH_CHAR and
3446 (bidi_init_it): Initialize new members.
3447 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3449 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3450 instead of using explicit *_CHAR codes.
3451 (bidi_resolve_explicit, bidi_resolve_weak):
3452 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3453 bidirectional text is supported only in multibyte buffers.
3454 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3455 it to initialize the frame_window_p member of struct bidi_it.
3456 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3457 (bidi_resolve_explicit, bidi_resolve_weak)
3458 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3459 bidi_it->nchars is non-positive.
3460 (bidi_level_of_next_char): Don't try to lookup the cache for the
3461 next/previous character if nothing is cached there yet, or if we
3462 were just reseat()'ed to a new position.
3464 * xdisp.c (set_cursor_from_row): Set start and stop points
3465 according to the row's direction when priming the loop that looks
3466 for the glyph on which to display cursor.
3467 (single_display_spec_intangible_p): Function deleted.
3468 (display_prop_intangible_p): Reimplement to call
3469 handle_display_spec instead of single_display_spec_intangible_p.
3470 Accept 3 additional arguments needed by handle_display_spec.
3471 This fixes incorrect cursor motion across display property with complex
3472 values: lists, `(when COND...)' forms, etc.
3473 (single_display_spec_string_p): Support property values that are
3474 lists with the argument STRING its top-level element.
3475 (display_prop_string_p): Fix the condition for processing a
3476 property that is a list to be consistent with handle_display_spec.
3477 (handle_display_spec): New function, refactored from the
3478 last portion of handle_display_prop.
3479 (compute_display_string_pos): Accept additional argument
3480 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3481 value of a `display' property is a "replacing spec".
3482 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3483 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3484 the display property, but just return a value indicating whether
3485 the display property will replace the characters it covers.
3486 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3487 frame_window_p members of struct bidi_it.
3488 (compute_display_string_pos, compute_display_string_end):
3490 (push_it): Accept second argument POSITION, where pop_it should
3491 jump to continue iteration.
3492 (reseat_1): Initialize bidi_it.disp_pos.
3494 * keyboard.c (adjust_point_for_property): Adjust the call to
3495 display_prop_intangible_p to its new signature.
3497 * dispextern.h (struct bidi_it): New member frame_window_p.
3498 (bidi_init_it): Update prototypes.
3499 (display_prop_intangible_p): Update prototype.
3500 (compute_display_string_pos, compute_display_string_end):
3502 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3505 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3507 Malloc failure behavior now depends on size of allocation.
3508 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3509 * lisp.h: Change signatures accordingly.
3510 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3511 All callers changed. (Bug#8762)
3513 * gnutls.c: Use Emacs's memory allocators.
3514 Without this change, the gnutls library would invoke malloc etc.
3515 directly, which causes problems on non-SYNC_INPUT hosts, and which
3516 runs afoul of improving memory_full behavior. (Bug#8761)
3517 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3518 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3519 xfree instead of the default malloc, realloc, free.
3520 (Fgnutls_boot): No need to check for memory allocation failure,
3521 since xmalloc does that for us.
3523 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3524 * category.c (hash_get_category_set):
3525 * ccl.c (ccl_driver):
3526 * charset.c (Fdefine_charset_internal):
3527 * charset.h (struct charset.hash_index):
3528 * composite.c (get_composition_id, gstring_lookup_cache)
3529 (composition_gstring_put_cache):
3530 * composite.h (struct composition.hash_index):
3531 * dispextern.h (struct image.hash):
3532 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3533 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3534 (hashfn_equal, hashfn_user_defined, make_hash_table)
3535 (maybe_resize_hash_table, hash_lookup, hash_put)
3536 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3537 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3538 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3539 * image.c (make_image, search_image_cache, lookup_image)
3540 (xpm_put_color_table_h):
3541 * lisp.h (struct Lisp_Hash_Table):
3542 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3543 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3544 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3545 * alloc.c (allocate_vectorlike):
3546 Check for overflow in vector size calculations.
3547 * ccl.c (ccl_driver):
3548 Check for overflow when converting EMACS_INT to int.
3549 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3550 need to be updated by these changes.
3551 * fns.c (make_hash_table, maybe_resize_hash_table):
3552 Check for integer overflow with large hash tables.
3553 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3554 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3555 (SXHASH_REDUCE): New macro.
3556 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3557 Use it instead of discarding useful hash info with large hash values.
3558 (sxhash_float): New function.
3559 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3560 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3561 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3562 Rewrite to use FIXNUM_BITS, as this simplifies things.
3563 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3564 Adjust signatures to match updated version of code.
3565 (consing_since_gc): Now EMACS_INT, since a single hash table can
3566 use more than INT_MAX bytes.
3568 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3570 Make it possible to build with GCC-4.6+ -O2 -flto.
3572 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3574 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3576 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3577 Call minibuffer-inactive-mode.
3579 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3581 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3582 Update dependencies.
3584 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3586 * data.c (init_data): Remove code for UTS, this system is not
3589 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3591 Don't force ./temacs to start in terminal mode.
3593 * frame.c (make_initial_frame): Initialize faces in all cases, not
3594 only when CANNOT_DUMP is defined.
3595 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3597 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3599 * dispnew.c (add_window_display_history): Use const for the string
3600 pointer. Remove declaration, not needed.
3602 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3604 Use 'inline', not 'INLINE'.
3605 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3606 * alloc.c, fontset.c (INLINE): Remove.
3607 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3608 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3609 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3610 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3611 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3613 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3615 Make it possible to run ./temacs.
3617 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3618 syms_of_callproc does the same thing. Remove test for
3619 "initialized", do it in the caller.
3620 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3622 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3624 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3625 (read_minibuf): Use get_minibuffer.
3626 (syms_of_minibuf): Use DEFSYM.
3627 (Qmetadata): New var.
3628 * data.c (Qbuffer): Don't make it static.
3629 (syms_of_data): Use DEFSYM.
3631 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3633 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3634 (CCL_CODE_MIN): New macro.
3636 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3638 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3640 * eval.c (Qdebug): Now static.
3641 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3642 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3643 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3645 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3647 * image.c: Various fixes to ImageMagick code comments.
3648 (Fimagemagick_types): Doc fix.
3650 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3652 Minor fixes prompted by GCC 4.6.0 warnings.
3654 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3656 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3657 (x_clipboard_manager_save_all): Move extern decl to ...
3658 * xterm.h: ... here, so that it can be checked for consistency.
3660 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3662 * xselect.c (x_clipboard_manager_save_frame)
3663 (x_clipboard_manager_save_all): New functions.
3664 (Fx_clipboard_manager_save): Lisp function deleted.
3666 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3667 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3669 * xterm.h: Update prototype.
3671 2011-05-28 William Xu <william.xwl@gmail.com>
3673 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3676 2011-05-28 Jim Meyering <meyering@redhat.com>
3678 Avoid a sign-extension bug in crypto_hash_function.
3679 * fns.c (to_uchar): Define.
3680 (crypto_hash_function): Use it to convert some newly-signed
3681 variables to unsigned, to avoid sign-extension bugs. For example,
3682 without this change, (md5 "truc") would evaluate to
3683 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3684 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3685 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3687 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3689 Integer overflow fixes.
3691 * dbusbind.c: Serial number integer overflow fixes.
3692 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3693 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3694 to hold a serial number that is too large for a fixnum.
3695 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3696 Check for serial numbers out of range. Decode any serial number
3697 that was so large that it became a float. (Bug#8722)
3699 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3700 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3701 Use XFASTINT rather than XUINT when numbers are nonnegative.
3702 (xd_append_arg, Fdbus_method_return_internal):
3703 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3704 arguments, check that Lisp number is nonnegative, rather than
3705 silently wrapping negative numbers around. (Bug#8722)
3706 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3709 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3711 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3713 ccl: add integer overflow checks
3714 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3715 (IN_INT_RANGE): New macros.
3716 (ccl_driver): Use them to check for integer overflow when
3717 decoding a CCL program. Many of the new checks are whether XINT (x)
3718 fits in int; it doesn't always, on 64-bit hosts. The new version
3719 doesn't catch all possible integer overflows, but it's an
3720 improvement. (Bug#8719)
3722 * alloc.c (make_event_array): Use XINT, not XUINT.
3723 There's no need for unsigned here.
3725 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3726 This follows up to the 2011-05-06 change that substituted uintptr_t
3727 for EMACS_INT. This case wasn't caught back then.
3729 Rework Fformat to avoid integer overflow issues.
3730 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3731 now (part of C89). Include <verify.h>.
3732 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3733 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3734 (Fformat): Avoid the prepass trying to compute sizes; it was only
3735 approximate and thus did not catch overflow reliably. Instead, walk
3736 through the format just once, formatting and computing sizes as we go,
3737 checking for integer overflow at every step, and allocating a larger
3738 buffer as needed. Keep track separately whether the format is
3739 multibyte. Keep only the most-recently calculated precision, rather
3740 than them all. Record whether each argument has been converted to
3741 string. Use EMACS_INT, not int, for byte and char and arg counts.
3742 Support field widths and precisions larger than INT_MAX. Avoid
3743 sprintf's undefined behavior with conversion specifications such as %#d
3744 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3745 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3746 formatting out-of-range floating point numbers with int
3749 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3751 * data.c: Avoid integer truncation in expressions involving floats.
3752 * data.c: Include <intprops.h>.
3753 (arith_driver): When there's an integer overflow in an expression
3754 involving floating point, convert the integers to floating point
3755 so that the resulting value does not suffer from catastrophic
3756 integer truncation. For example, on a 64-bit host (* 4
3757 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3758 Do not rely on undefined behavior after integer overflow.
3760 merge count_size_as_multibyte, parse_str_to_multibyte
3761 * character.c, character.h (count_size_as_multibyte):
3762 Rename from parse_str_to_multibyte; all uses changed.
3763 Check for integer overflow.
3764 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3765 since it's now a duplicate of the other. This is more of
3766 a character than a buffer op, so better that it's in character.c.
3767 * fns.c, print.c: Adjust to above changes.
3769 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3771 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3773 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3775 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3776 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3777 (x_clipboard_manager_save): Now static.
3778 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3780 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3781 (crypto_hash_function): Now static.
3782 Fix pointer signedness problems. Avoid unnecessary initializations.
3784 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3786 * termhooks.h (Vselection_alist): Make it terminal-local.
3788 * terminal.c (create_terminal): Initialize it.
3790 * xselect.c: Support for clipboard managers.
3791 (Vselection_alist): Move to termhooks.h as terminal-local var.
3792 (LOCAL_SELECTION): New macro.
3793 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3794 (symbol_to_x_atom): Remove gratuitous arg.
3795 (x_handle_selection_request, lisp_data_to_selection_data)
3796 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3797 (x_own_selection, x_get_local_selection, x_convert_selection):
3798 New arg, specifying work frame. Use terminal-local Vselection_alist.
3799 (some_frame_on_display): Delete unused function.
3800 (Fx_own_selection_internal, Fx_get_selection_internal)
3801 (Fx_disown_selection_internal, Fx_selection_owner_p)
3802 (Fx_selection_exists_p): New optional frame arg.
3803 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3804 (x_handle_selection_clear): Don't treat other terminals with the
3805 same keyboard specially. Use the terminal-local Vselection_alist.
3806 (x_clear_frame_selections): Use Frun_hook_with_args.
3808 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3810 * xterm.h: Add support for those atoms.
3812 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3814 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3815 (converted_selections, conversion_fail_tag): New global variables.
3816 (x_selection_request_lisp_error): Free the above.
3817 (x_get_local_selection): Remove unnecessary code.
3818 (x_reply_selection_request): Args changed; handle arbitrary array
3819 of converted selections stored in converted_selections.
3820 Separate the XChangeProperty and SelectionNotify steps.
3821 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3822 (x_convert_selection): New function.
3823 (x_handle_selection_event): Simplify.
3824 (x_get_foreign_selection): Don't ignore incoming requests while
3825 waiting for an answer; this will fail when we implement
3826 SAVE_TARGETS, and seems unnecessary anyway.
3827 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3828 (Vx_sent_selection_functions): Doc fix.
3830 2011-05-26 Leo Liu <sdl.web@gmail.com>
3832 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3834 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3836 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3838 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3839 for fringe update if it has periodic bitmap.
3840 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3841 and fringe_bitmap_periodic_p.
3843 * fringe.c (get_fringe_bitmap_data): New function.
3844 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3845 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3846 row. Mark glyph row for fringe update if periodicity changed.
3848 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3849 for fringe update unless it has periodic bitmap.
3851 2011-05-25 Kenichi Handa <handa@m17n.org>
3853 * xdisp.c (get_next_display_element): Set correct it->face_id for
3854 a static composition.
3856 2011-05-24 Leo Liu <sdl.web@gmail.com>
3859 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3861 * fns.c (crypto_hash_function, Fsha1): New function.
3862 (Fmd5): Use crypto_hash_function.
3863 (syms_of_fns): Add Ssha1.
3865 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3867 * gnutls.c: Remove unused macros.
3868 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3869 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3870 Remove macros that are defined and never used.
3871 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3873 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3875 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3876 (Fx_get_selection_internal): Minor cleanup.
3877 (Fx_own_selection_internal): Rename arguments for consistency with
3880 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3882 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3884 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3886 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3888 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3890 * dispnew.c (scrolling_window): Don't exclude the case that the
3891 last enabled row in the desired matrix touches the bottom boundary.
3893 2011-05-21 Glenn Morris <rgm@gnu.org>
3895 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3896 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3897 and add some more files.
3899 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3901 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3902 report_file_error introduced by the change from 2011-05-07.
3904 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3906 * systime.h (Time): Define only if emacs is defined.
3907 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3908 where the include path doesn't have X11/X.h by default. See
3909 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3911 2011-05-20 Kenichi Handa <handa@m17n.org>
3913 * composite.c (find_automatic_composition): Fix previous change.
3915 2011-05-20 Glenn Morris <rgm@gnu.org>
3917 * lisp.mk: New file, split from Makefile.in.
3918 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3919 (shortlisp): Remove.
3920 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3922 2011-05-19 Glenn Morris <rgm@gnu.org>
3924 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3925 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3926 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3927 (lisp): Set the order to that of loadup.el.
3928 (shortlisp): Make it a copy of $lisp.
3929 (SOME_MACHINE_LISP): Remove.
3930 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3931 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3933 2011-05-18 Kenichi Handa <handa@m17n.org>
3935 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3936 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3937 (find_automatic_composition): Mostly rewrite for efficiency.
3939 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3941 * makefile.w32-in: Update dependencies.
3943 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3945 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3946 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3948 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3950 Fix some integer overflow issues, such as string length overflow.
3952 * insdel.c (count_size_as_multibyte): Check for string overflow.
3954 * character.c (lisp_string_width): Check for string overflow.
3955 Use EMACS_INT, not int, for string indexes and lengths; in
3956 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3957 the resulting string length overflows an EMACS_INT; instead,
3958 report a string overflow if no precision given. When checking for
3959 precision exhaustion, use a check that cannot possibly have
3960 integer overflow. (Bug#8675)
3961 * character.h (lisp_string_width): Adjust to new signature.
3963 * alloc.c (string_overflow): New function.
3964 (Fmake_string): Use it. This doesn't change behavior, but saves
3965 a few bytes and will simplify future changes.
3966 * character.c (string_escape_byte8): Likewise.
3967 * lisp.h (string_overflow): New decl.
3969 Fixups, following up to the user-interface timestamp change.
3970 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3971 for UI timestamps, instead of unsigned long.
3972 * msdos.c (mouse_get_pos): Likewise.
3973 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3974 * w32gui.h (Time): Define by including "systime.h" rather than by
3975 declaring it ourselves. (Bug#8664)
3977 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3978 * image.c (clear_image_cache): Likewise.
3980 * term.c (term_mouse_position): Don't assume time_t wraparound.
3982 Be more systematic about user-interface timestamps.
3983 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3984 and sometimes 'EMACS_UINT', to represent these timestamps.
3985 This change causes it to use 'Time' uniformly, as that's what X uses.
3986 This makes the code easier to follow, and makes it easier to catch
3987 integer overflow bugs such as Bug#8664.
3988 * frame.c (Fmouse_position, Fmouse_pixel_position):
3989 Use Time, not unsigned long, for user-interface timestamps.
3990 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3991 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3992 * keyboard.h (last_event_timestamp): Likewise.
3993 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3994 * menu.h (xmenu_show): Likewise.
3995 * term.c (term_mouse_position): Likewise.
3996 * termhooks.h (struct input_event.timestamp): Likewise.
3997 (struct terminal.mouse_position_hook): Likewise.
3998 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3999 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4000 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4001 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4003 * menu.h, termhooks.h: Include "systime.h", for Time.
4005 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4006 Don't assume that the difference between two unsigned long values
4007 can fit into an integer. At this point, we know button_down_time
4008 <= event->timestamp, so the difference must be nonnegative, so
4009 there's no need to cast the result if double-click-time is
4010 nonnegative, as it should be; check that it's nonnegative, just in
4011 case. This bug is triggered when events are more than 2**31 ms
4012 apart (about 25 days). (Bug#8664)
4014 * xselect.c (last_event_timestamp): Remove duplicate decl.
4015 (x_own_selection): Remove needless cast to unsigned long.
4017 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4018 that always fit in int. Use a sentinel instead of a counter, to
4019 avoid a temp and to allay GCC's concerns about possible int overflow.
4020 * frame.h (struct frame): Use int for menu_bar_items_used
4021 instead of EMACS_INT, since it always fits in int.
4023 * menu.c (grow_menu_items): Check for int overflow.
4025 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4027 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4028 Before, the code was not consistent. These values cannot exceed
4029 2**31 - 1 so there's no need to make them unsigned.
4030 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4031 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4032 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4034 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4036 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4037 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4038 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4039 presumably because the widths might not match.
4041 * window.c (size_window): Avoid needless test at loop start.
4043 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4045 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4047 2011-05-12 Drew Adams <drew.adams@oracle.com>
4049 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4051 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4053 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4054 `width' to `bar_area_x' and `bar_area_width', respectively.
4055 (x_scroll_run): Take account of fringe background extension.
4057 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4058 Rename local vars `left' and `width' to `bar_area_x' and
4059 `bar_area_width', respectively.
4060 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4061 background extension.
4063 2011-05-10 Jim Meyering <meyering@redhat.com>
4065 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4067 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4069 * image.c (Finit_image_library): Return t for built-in image types,
4070 like pbm and xbm. (Bug#8640)
4072 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4074 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4076 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4078 * w32console.c (Fset_screen_color): Doc fix.
4079 (Fget_screen_color): New function.
4080 (syms_of_ntterm): Defsubr it.
4082 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4083 unlink the temporary file if Fcall_process didn't create it in the
4085 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4086 child process will be redirected to a file specified with `:file'.
4087 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4088 cue to call_process_cleanup not to close that handle.
4090 2011-05-07 Ben Key <bkey76@gmail.com>
4092 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4093 one of two shell specific rules, either bootstrap-temacs-CMD or
4094 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4095 to the previous implementation of the bootstrap-temacs rule.
4096 The bootstrap-temacs-CMD rule is similar to the previous
4097 implementation of the bootstrap-temacs rule except that it
4098 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4101 These changes, along with some changes to nt/configure.bat,
4102 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4103 earlier fix to add support for --cflags and --ldflags options
4104 that include quotes so that it works whether make uses cmd or
4107 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4109 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4110 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4112 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4113 a string. Handle both cases.
4114 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4115 (Fdbus_register_method): Use Qinvalid_function.
4117 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4119 * makefile.w32-in: Update dependencies.
4120 (LISP_H): Add inttypes.h and stdin.h.
4121 (PROCESS_H): Add unistd.h.
4123 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4125 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4126 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4128 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4130 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4132 * term.c (vfatal): Remove stray call to va_end.
4133 It's not needed and the C Standard doesn't allow it here anyway.
4135 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4136 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4138 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4141 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4143 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4145 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4147 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4149 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4151 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4152 * charset.c (Fdefine_charset_internal): Don't initialize
4153 charset.code_space[15]. The value was garbage, on hosts with
4154 32-bit int (Bug#8600).
4156 * lread.c (read_integer): Be more consistent with string-to-number.
4157 Use string_to_number to do the actual conversion; this avoids
4158 rounding errors and fixes some other screwups. Without this fix,
4159 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4160 (digit_to_number): Move earlier, for benefit of read_integer.
4161 Return -1 if the digit is out of range for the base, -2 if it is
4162 not a digit in any supported base. (Bug#8602)
4164 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4166 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4167 to match comment at start of function. This also removes a
4168 GCC warning about overflow in a 32+64-bit port.
4170 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4172 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4173 Reported by Stefan Monnier in
4174 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4175 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4176 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4178 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4179 (EMACS_UINTPTR): Likewise, with uintptr_t.
4181 * lisp.h: Prefer 64-bit EMACS_INT if available.
4182 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4183 on 32-bit hosts that have 64-bit int, so that they can access
4185 However, temporarily disable this change unless the temporary
4186 symbol WIDE_EMACS_INT is defined.
4188 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4190 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4191 This removes an assumption that EMACS_INT and long are the same
4192 width as pointers. The assumption is true for Emacs porting targets
4193 now, but we want to make other targets possible.
4194 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4195 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4196 In the rest of the code, change types of integers that hold casted
4197 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4198 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4199 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4200 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4201 No need to cast type when ORing.
4202 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4203 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4204 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4205 assume EMACS_INT is the same width as char *.
4206 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4207 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4208 Remove no-longer-needed casts.
4209 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4210 (xg_tool_bar_help_callback, xg_make_tool_item):
4211 Use EMACS_INTPTR to hold an integer
4212 that will be cast to void *; this can avoid a GCC warning
4213 if EMACS_INT is not the same width as void *.
4214 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4215 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4216 (current_message_1, set_message_1):
4217 Use a local to convert to proper width without a cast.
4218 * xmenu.c (dialog_selection_callback): Likewise.
4220 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4221 Also, don't assume VALBITS / RAND_BITS is less than 5,
4222 and don't rely on undefined behavior when shifting a 1 left into
4224 * lisp.h (get_random): Change signature to match.
4226 * lread.c (hash_string): Use size_t, not int, for hash computation.
4227 Normally we prefer signed values; but hashing is special, because
4228 it's better to use unsigned division on hash table sizes so that
4229 the remainder is nonnegative. Also, size_t is the natural width
4230 for hashing into memory. The previous code used 'int', which doesn't
4231 retain enough info to hash well into very large tables.
4232 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4234 * dbusbind.c: Don't possibly lose pointer info when converting.
4235 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4236 Use XPNTR rather than XHASH, so that the high-order bits of
4237 the pointer aren't lost when converting through void *.
4239 * eval.c (Fautoload): Don't double-shift a pointer.
4241 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4243 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4245 * gnutls.c (DEF_GNUTLS_FN):
4246 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4248 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4250 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4253 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4255 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4256 New version that can reserve upto 2GB of heap space.
4258 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4260 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4262 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4264 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4265 `gnutls_certificate_set_x509_key_file'.
4267 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4269 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4270 Update dependencies.
4272 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4274 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4275 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4276 Remove unused parameter `fildes'.
4277 * process.c (read_process_output, send_process): Don't pass it.
4279 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4281 Fix previous change: the library cache is defined in w32.c.
4282 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4283 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4285 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4287 Implement dynamic loading of GnuTLS on Windows.
4289 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4290 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4291 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4294 * gnutls.c (Qgnutls_dll): Define.
4295 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4296 (gnutls_*): Declare function pointers.
4297 (init_gnutls_functions): New function to initialize function pointers.
4298 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4299 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4300 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4301 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4302 (emacs_gnutls_write, emacs_gnutls_read)
4303 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4304 (Fgnutls_available_p): New function.
4305 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4306 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4307 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4309 * image.c: Include w32.h.
4310 (Vimage_type_cache): Delete.
4311 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4312 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4313 (w32_delayed_load): Move to w32.c.
4315 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4317 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4318 (w32_delayed_load): Move from image.c. When loading a library, record
4319 its filename in the :loaded-from property of the library id.
4320 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4321 Initialize and staticpro them.
4322 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4324 * process.c: Include lisp.h before w32.h, not after.
4325 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4326 instead of gnutls_record_check_pending.
4328 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4330 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4332 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4333 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4336 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4338 * xterm.c (x_set_frame_alpha): Do not set property on anything
4339 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4341 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4343 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4345 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4347 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4348 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4349 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4350 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4351 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4352 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4353 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4354 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4355 (Qgnutls_bootprop_callbacks_verify): Make static.
4357 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4359 * callproc.c: Indentation fixup.
4361 * sysdep.c (wait_for_termination_1): Make static.
4362 (wait_for_termination, interruptible_wait_for_termination):
4363 Move after wait_for_termination_1.
4365 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4367 * sysdep.c (interruptible_wait_for_termination): New function
4368 which is like wait_for_termination, but allows keyboard
4371 * callproc.c (Fcall_process): Add (:file "file") as an option for
4373 (Fcall_process_region): Ditto.
4375 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4377 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4378 rather than `XVECTOR (FOO)->size'.
4380 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4381 inttypes.h, as a gnulib replacement is used if it not available in
4384 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4386 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4387 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4388 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4390 * coding.c (coding_alloc_by_realloc): Error out if destination
4391 will grow beyond MOST_POSITIVE_FIXNUM.
4392 (decode_coding_emacs_mule): Abort if there isn't enough place in
4393 charbuf for the composition carryover bytes. Reserve an extra
4394 space for up to 2 characters produced in a loop.
4395 (decode_coding_iso_2022): Abort if there isn't enough place in
4396 charbuf for the composition carryover bytes.
4398 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4400 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4401 aborting when %lld or %lll format is passed.
4402 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4403 %llo or %llx format is passed. (Bug#8545)
4405 * window.c (window_scroll_line_based): Use a marker instead of
4406 simple variables to record original value of point. (Bug#7952)
4408 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4409 produced by %s or %c overflows available buffer space. (Bug#8545)
4411 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4413 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4414 (SIZE_MAX): Move defn after all includes, as they might #define it.
4416 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4418 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4420 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4422 * keyboard.c (Qdelayed_warnings_hook): Define.
4423 (command_loop_1): Run `delayed-warnings-hook'
4424 if Vdelayed_warnings_list is non-nil.
4425 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4426 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4428 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4430 * doprnt.c (doprnt): Don't return value smaller than the buffer
4431 size if the message was truncated. (Bug#8545).
4433 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4435 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4436 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4438 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4440 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4442 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4444 * makefile.w32-in: Update dependencies.
4446 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4448 Improve `doprnt' and its usage. (Bug#8545)
4449 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4450 `format_end'. Remove support for %l as a conversion specifier.
4451 Don't use xrealloc. Improve diagnostics when the %l size modifier
4452 is used. Update the commentary.
4454 * eval.c (verror): Simplify calculation of size_t.
4456 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4459 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4461 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4464 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4466 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4467 This makes this file independent of the recent pseudovector change.
4469 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4471 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4473 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4474 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4475 Remove unused local.
4476 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4478 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4479 GCC 4.6.0 optimizes based on type-based alias analysis.
4480 For example, if b is of type struct buffer * and v of type struct
4481 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4482 != &v->size, and therefore "v->size = 1; b->size = 2; return
4483 v->size;" must therefore return 1. This assumption is incorrect
4484 for Emacs, since it type-puns struct Lisp_Vector * with many other
4485 types. To fix this problem, this patch adds a new type struct
4486 vectorlike_header that documents the constraints on layout of vectors
4487 and pseudovectors, and helps optimizing compilers not get fooled
4488 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4489 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4490 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4492 (XSETPVECTYPE): Rewrite in terms of new macro.
4493 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4494 This is a bit clearer, and further avoids the possibility of
4495 undesirable aliasing.
4496 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4497 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4498 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4499 since Lisp_Subr is a special case (no "next" field).
4500 (ASIZE): Now uses header.size rather than size.
4501 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4502 to avoid the hassle of writing XVECTOR (foo)->header.size.
4503 (struct vectorlike_header): New type.
4504 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4505 object, to help avoid aliasing.
4506 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4507 (SUBRP): Likewise, since Lisp_Subr is a special case.
4508 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4509 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4510 (struct Lisp_Hash_Table): Combine first two members into a single
4511 struct vectorlike_header member. All uses of "size" and "next" members
4512 changed to be "header.size" and "header.next".
4513 * buffer.h (struct buffer): Likewise.
4514 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4515 * frame.h (struct frame): Likewise.
4516 * process.h (struct Lisp_Process): Likewise.
4517 * termhooks.h (struct terminal): Likewise.
4518 * window.c (struct save_window_data, struct saved_window): Likewise.
4519 * window.h (struct window): Likewise.
4520 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4521 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4522 * buffer.c (init_buffer_once): Likewise.
4523 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4525 * process.c (Fformat_network_address): Use local var for size,
4528 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4530 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4531 * data.c (atof): Remove decl; no longer used or needed.
4532 (digit_to_number): Move to lread.c.
4533 (Fstring_to_number): Use new string_to_number function, to be
4534 consistent with how the Lisp reader treats infinities and NaNs.
4535 Do not assume that floating-point numbers represent EMACS_INT
4536 without losing information; this is not true on most 64-bit hosts.
4537 Avoid double-rounding errors, by insisting on integers when
4538 parsing non-base-10 numbers, as the documentation specifies.
4539 * lisp.h (string_to_number): New decl, replacing ...
4540 (isfloat_string): Remove.
4541 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4542 (read1): Do not accept +. and -. as integers; this
4543 appears to have been a coding error. Similarly, do not accept
4544 strings like +-1e0 as floating point numbers. Do not report
4545 overflow for integer overflows unless the base is not 10 which
4546 means we have no simple and reliable way to continue.
4547 Break out the floating-point parsing into a new
4548 function string_to_number, so that Fstring_to_number parses
4549 floating point numbers consistently with the Lisp reader.
4550 (digit_to_number): Move here from data.c. Make it static inline.
4551 (E_CHAR, EXP_INT): Remove, replacing with ...
4552 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4553 (string_to_number): New function, replacing isfloat_string.
4554 This function checks for valid syntax and produces the resulting
4555 Lisp float number too. Rework it so that string-to-number
4556 no longer mishandles examples like "1.0e+". Use strtoumax,
4557 so that overflow for non-base-10 numbers is reported only when
4558 there's no portable and simple way to convert to floating point.
4560 * textprop.c (set_text_properties_1): Rewrite for clarity,
4561 and to avoid GCC warning about integer overflow.
4563 * intervals.h (struct interval): Use EMACS_INT for members
4564 where EMACS_UINT might cause problems. See
4565 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4566 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4567 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4569 (offset_intervals): Tell GCC not to worry about length overflow
4570 when negating a negative length.
4572 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4573 (overrun_check_free): Likewise.
4575 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4576 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4579 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4580 (gnutls_make_error): Rename local to avoid shadowing.
4581 (gnutls_emacs_global_deinit): ifdef out; not used.
4582 (Fgnutls_boot): Use const for pointer to readonly storage.
4583 Comment out unused local. Fix pointer signedness problems.
4585 * lread.c (openp): Don't stuff size_t into an 'int'.
4586 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4587 about possible signed overflow.
4589 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4590 (GDK_KEY_g): Don't define if already defined.
4591 (xg_prepare_tooltip): Avoid pointer signedness problem.
4592 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4594 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4595 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4597 * xfns.c (Fx_window_property): Simplify a bit,
4598 to make a bit faster and to avoid GCC 4.6.0 warning.
4599 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4601 * fns.c (internal_equal): Don't assume size_t fits in int.
4603 * alloc.c (compact_small_strings): Tighten assertion a little.
4605 Replace pEd with more-general pI, and fix some printf arg casts.
4606 * lisp.h (pI): New macro, generalizing old pEd macro to other
4607 conversion specifiers. For example, use "...%"pI"d..." rather
4608 than "...%"pEd"...".
4609 (pEd): Remove. All uses replaced with similar uses of pI.
4610 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4611 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4612 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4613 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4614 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4615 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4616 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4618 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4619 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4620 * print.c (safe_debug_print, print_object): Likewise.
4621 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4623 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4624 avoiding the 0 flag, which is not portable.
4625 * process.c (Fmake_network_process): Use pI to avoid cast.
4626 * region-cache.c (pp_cache): Likewise.
4627 * xdisp.c (decode_mode_spec): Likewise.
4628 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4629 behavior on 64-bit hosts with printf arg.
4630 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4631 (x_stop_queuing_selection_requests): Likewise.
4632 (x_get_window_property): Don't truncate byte count to an 'int'
4635 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4636 here, since it parses constructs like leading '-' and spaces,
4637 which are not wanted; and it overflows with large numbers.
4638 Instead, simply match F[0-9]+, which is what is wanted anyway.
4640 * alloc.c: Remove unportable assumptions about struct layout.
4641 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4642 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4643 (allocate_vectorlike, make_pure_vector): Use the new macros,
4644 plus offsetof, to remove unportable assumptions about struct layout.
4645 These assumptions hold on all porting targets that I know of, but
4646 they are not guaranteed, they're easy to remove, and removing them
4647 makes further changes easier.
4649 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4650 This doesn't fix a bug but makes the code clearer.
4651 (string_overrun_cookie): Now const. Use initializers that
4652 don't formally overflow signed char, to avoid warnings.
4653 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4654 can cause Emacs to crash when string overrun checking is enabled.
4655 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4656 multiple of sizeof (EMACS_INT); it need not be, if
4657 alignof(EMACS_INT) < sizeof (EMACS_INT).
4658 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4660 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4662 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4664 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4666 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4667 supposed to be handshaking. (Bug#8556)
4668 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4670 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4672 * lisp.h (Qdebug): List symbol.
4673 * eval.c (Qdebug): Restore global linkage.
4674 * keyboard.c (debug-on-event): New variable.
4675 (handle_user_signal): Break into debugger when debug-on-event
4676 matches the current signal symbol.
4678 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4680 * alloc.c (check_sblock, check_string_bytes)
4681 (check_string_free_list): Convert to standard C.
4683 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4685 * w32.c (emacs_gnutls_push): Fix typo.
4687 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4689 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4690 "cast to pointer from integer of different size".
4692 Improve doprnt and its use in verror. (Bug#8545)
4693 * doprnt.c (doprnt): Document the set of format control sequences
4694 supported by the function. Use SAFE_ALLOCA instead of always
4697 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4698 is one byte too soon. Don't use xrealloc; instead xfree and
4701 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4703 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4706 * gnutls.c: Renamed global_initialized to
4707 gnutls_global_initialized. Added internals for the
4708 :verify-hostname-error, :verify-error, and :verify-flags
4709 parameters of `gnutls-boot' and documented those parameters in the
4710 docstring. Start callback support.
4711 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4712 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4713 on error. Return error code.
4714 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4715 (emacs_gnutls_read): Likewise.
4716 (Fgnutls_boot): Return handshake error code.
4717 (emacs_gnutls_handle_error): New function.
4718 (wsaerror_to_errno): Likewise.
4720 * w32.h (emacs_gnutls_pull): Add prototype.
4721 (emacs_gnutls_push): Likewise.
4723 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4724 (emacs_gnutls_push): Likewise.
4726 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4728 * process.c (wait_reading_process_output): Check if GnuTLS
4729 buffered some data internally if no FDs are set for TLS
4732 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4733 (LIBS): Link to USER_LIBS.
4734 ($(BLD)/gnutls.$(0)): New target.
4736 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4738 * xdisp.c (handle_single_display_spec): Rename the
4739 display_replaced_before_p argument into display_replaced_p, to
4740 make it consistent with the commentary. Fix typos in the
4743 * textprop.c (syms_of_textprop): Remove dead code.
4744 (copy_text_properties): Delete obsolete commentary about an
4745 interface that was deleted long ago. Fix typos in the description
4748 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4749 to changes in oldXMenu/XMenu.h from 2011-04-16.
4750 <menu_help_message, prev_menu_help_message>: Constify.
4751 (IT_menu_make_room): menu->help_text is now `const char **';
4754 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4755 to changes in oldXMenu/XMenu.h from 2011-04-16.
4756 (struct XMenu): Declare `help_text' `const char **'.
4758 * xfaces.c <Qunspecified>: Make extern again.
4760 * syntax.c: Include sys/types.h before including regex.h, as
4763 * doc.c (get_doc_string): Improve the format passed to `error'.
4765 * doprnt.c (doprnt): Improve commentary.
4767 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4769 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4772 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4773 changes in globals.h immediately force recompilation.
4774 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4775 $(CURDIR)/s/ms-w32.h.
4776 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4778 * character.c (Fchar_direction): Function deleted.
4779 (syms_of_character): Don't defsubr it.
4780 <char-direction-table>: Deleted.
4782 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4784 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4785 * doprnt.c: Include limits.h.
4786 (SIZE_MAX): New macro.
4787 (doprnt): Return a size_t value. 2nd arg is now size_t.
4788 Many local variables are now size_t instead of int or unsigned.
4789 Improve overflow protection. Support `l' modifier for integer
4790 conversions. Support %l conversion. Don't assume an EMACS_INT
4791 argument for integer conversions and for %c.
4793 * lisp.h (doprnt): Restore prototype.
4795 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4798 * Makefile.in (base_obj): Add back doprnt.o.
4800 * deps.mk (doprnt.o): Add back prerequisites.
4801 (callint.o): Depend on character.h.
4803 * eval.c (internal_lisp_condition_case): Include the handler
4804 representation in the error message.
4805 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4806 when breaking from the loop.
4808 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4810 * callint.c (Fcall_interactively): When displaying error message
4811 about invalid control letter, pass the character's codepoint, not
4812 a pointer to its multibyte form. Improve display of the character
4813 in octal and display also its hex code.
4815 * character.c (char_string): Use %x to display the (unsigned)
4816 codepoint of an invalid character, to avoid displaying a bogus
4819 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4820 `error', not SYMBOL_NAME itself.
4822 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4823 character arguments to `error'.
4825 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4826 to `error' in error message about FINAL_CHAR argument. Make sure
4827 FINAL_CHAR is a character, and use %c when it is passed as
4828 argument to `error'.
4830 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4832 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4834 * w32.c: Include <time.h>.
4835 (sys_localtime): New function.
4837 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4839 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4841 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4843 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4845 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4848 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4850 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4851 gl_state.e_property when gl_state.object is Qt.
4853 * insdel.c (make_gap_larger): Remove limitation of buffer size
4856 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4858 * xdisp.c (lookup_glyphless_char_display)
4859 (produce_glyphless_glyph): Handle cons cell entry in
4860 glyphless-char-display.
4861 (Vglyphless_char_display): Document it.
4863 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4864 glyphless-char-display.
4866 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4868 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4870 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4872 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4873 definition for no-X builds.
4875 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4877 Static checks with GCC 4.6.0 and non-default toolkits.
4879 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4881 * process.c (keyboard_bit_set): Define only if SIGIO.
4882 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4883 (send_process): Repair possible setjmp clobbering.
4885 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4887 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4889 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4891 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4892 Define only if needed.
4894 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4895 by pacifying GCC about it. Maybe it's time to retire it?
4896 * xfaces.c (USG, __TIMEVAL__): Likewise.
4898 * dispextern.h (struct redisplay_interface): Rename param
4900 * termhooks.h (struct terminal): Likewise.
4901 * xterm.c (xembed_send_message): Likewise.
4903 * insdel.c (make_gap_smaller): Define only if
4904 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4906 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4909 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4910 so that we aren't warned about unused symbols.
4912 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4914 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4916 * xfns.c (x_real_positions): Mark locals as initialized.
4918 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4920 * xterm.c: Fix problems found by static analysis with other toolkits.
4921 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4922 (x_dispatch_event): Declare static if USE_GTK, and
4923 define if USE_GTK || USE_X_TOOLKIT.
4924 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4925 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4926 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4927 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4929 * xmenu.c (menu_help_callback): Pointer type fixes.
4930 Use const pointers when pointing at readonly data. Avoid pointer
4932 (FALSE): Remove unused macro.
4933 (update_frame_menubar): Remove unused decl.
4935 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4937 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4938 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4939 (single_menu_item): Rename local to avoid shadowing.
4941 * keyboard.c (make_lispy_event): Remove unused local var.
4943 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4944 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4946 * bitmaps: Change bitmaps from unsigned char back to the X11
4947 compatible char. Avoid the old compiler warnings about
4948 out-of-range initializers by using, for example, '\xab' rather
4951 * xgselect.c (xgselect_initialize): Check vs interface
4952 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4954 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4956 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4957 to read-only memory.
4959 * fns.c (vector): Remove; this old hack is no longer needed.
4961 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4963 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4965 * xrdb.c (x_load_resources): Omit unused local.
4967 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4968 (x_window): Rename locals to avoid shadowing.
4969 (USG): Use the kludged USG macro, to pacify gcc.
4971 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4972 (x_term_init): Remove local to avoid shadowing.
4974 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4976 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4977 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4979 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4981 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4983 Fix regex.c, syntax.c and friends for buffers > 2GB.
4984 * syntax.h (struct gl_state_s): Declare character position members
4987 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4989 * textprop.c (verify_interval_modification, interval_of):
4990 Declare arguments EMACS_INT.
4992 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4995 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4997 * indent.c (Fvertical_motion): Local variable it_start is now
5000 * regex.c (re_match, re_match_2, re_match_2_internal)
5001 (bcmp_translate, regcomp, regexec, print_double_string)
5002 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5003 (re_compile_pattern, re_exec): Declare arguments and local
5004 variables `size_t' and `ssize_t' and return values `regoff_t', as
5006 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5007 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5008 <compile_stack_type>: `size' and `avail' are now `size_t'.
5010 * regex.h <regoff_t>: Use ssize_t, not int.
5011 (re_search, re_search_2, re_match, re_match_2): Arguments that
5012 specify buffer/string position and length are now ssize_t and
5013 size_t. Return type is regoff_t.
5015 2011-04-16 Ben Key <bkey76@gmail.com>
5017 * nsfont.m: Fixed bugs in ns_get_family and
5018 ns_descriptor_to_entity that were caused by using free to
5019 deallocate memory blocks that were allocated by xmalloc (via
5020 xstrdup). This caused Emacs to crash when compiled with
5021 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5022 --enable-checking=xmallocoverrun). xfree is now used to
5023 deallocate these memory blocks.
5025 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5027 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5029 emacs_write: Accept and return EMACS_INT for sizes.
5030 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5032 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5033 Accept and return EMACS_INT.
5034 (emacs_gnutls_write): Return the number of bytes written on
5036 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5037 (emacs_read, emacs_write): Remove check for negative size, as the
5038 Emacs source code has been audited now.
5039 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5040 (emacs_read, emacs_write): Use it.
5041 * process.c (send_process): Adjust to the new signatures of
5042 emacs_write and emacs_gnutls_write. Do not attempt to store
5043 a byte offset into an 'int'; it might overflow.
5044 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5046 * sound.c: Don't assume sizes fit in 'int'.
5047 (struct sound_device.period_size, alsa_period_size):
5048 Return EMACS_INT, not int.
5049 (struct sound_device.write, vox_write, alsa_write):
5050 Accept EMACS_INT, not int.
5051 (wav_play, au_play): Use EMACS_INT to store sizes and to
5052 record read return values.
5054 2011-04-15 Ben Key <bkey76@gmail.com>
5056 * keyboard.c (Qundefined): Don't declare static since it is used
5058 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5059 static since they are used in nsfont.m.
5061 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5063 * process.c (Qprocessp): Don't declare static.
5064 * lisp.h (Qprocessp): Declare again.
5066 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5068 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5070 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5072 Improve C-level modularity by making more things 'static'.
5074 Don't publish debugger-only interfaces to other modules.
5075 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5076 (verify_bytepos, count_markers): Move decls to the only modules
5078 * region-cache.h (pp_cache): Likewise.
5079 * window.h (check_all_windows): Likewise.
5080 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5082 * sysdep.c (croak): Now static, if
5083 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5084 * syssignal.h (croak): Declare only if not static.
5086 * alloc.c (refill_memory_reserve): Now static if
5087 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5088 * lisp.h (refill_memory_reserve): Declare only if not static.
5090 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5091 Define only if USE_LUCID.
5093 * xrdb.c (x_customization_string, x_rm_string): Now static.
5095 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5096 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5098 * xdisp.c (draw_row_with_mouse_face): Now static.
5099 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5101 * window.h (check_all_windows): Mark externally visible.
5103 * window.c (window_deletion_count): Now static.
5105 * undo.c: Make symbols static if they're not exported.
5106 (last_undo_buffer, last_boundary_position, pending_boundary):
5109 * textprop.c (interval_insert_behind_hooks): Now static.
5110 (interval_insert_in_front_hooks): Likewise.
5112 * term.c: Make symbols static if they're not exported.
5113 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5114 (max_frame_lines, tty_set_terminal_modes):
5115 (tty_reset_terminal_modes, tty_turn_off_highlight):
5116 (get_tty_terminal): Now static.
5117 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5118 * termhooks.h (term_mouse_moveto): Do not declare if
5120 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5121 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5123 * sysdep.c: Make symbols static if they're not exported.
5124 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5126 (sigprocmask_set, full_mask): Remove; unused.
5127 (wait_debugging): Mark as visible.
5128 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5129 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5131 * syntax.c (syntax_temp): Define only if !__GNUC__.
5133 * sound.c (current_sound_device, current_sound): Now static.
5135 * search.c (searchbufs, searchbuf_head): Now static.
5137 * scroll.c (scroll_cost): Remove; unused.
5138 * dispextern.h (scroll_cost): Remove decl.
5140 * region-cache.h (pp_cache): Mark as externally visible.
5142 * process.c: Make symbols static if they're not exported.
5143 (process_tick, update_tick, create_process, chan_process):
5144 (Vprocess_alist, proc_buffered_char, datagram_access):
5145 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5146 (deactivate_process): Mark defn as static, as well as decl.
5147 * lisp.h (create_process): Remove decl.
5148 * process.h (chan_process, Vprocess_alist): Remove decls.
5150 * print.c: Make symbols static if they're not exported.
5151 (print_depth, new_backquote_output, being_printed, print_buffer):
5152 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5153 (print_interval, print_number_index, initial_stderr_stream):
5155 * lisp.h (Fprinc): Remove decl.
5156 (debug_output_compilation_hack): Mark as externally visible.
5158 * sysdep.c (croak): Move decl from here to syssignal.h.
5159 * syssignal.h (croak): Put it here, so the API can be checked when
5160 'croak' is called from dissociate_if_controlling_tty.
5162 * minibuf.c: Make symbols static if they're not exported.
5163 (minibuf_save_list, choose_minibuf_frame): Now static.
5164 * lisp.h (choose_minibuf_frame): Remove decl.
5166 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5168 * lread.c: Make symbols static if they're not exported.
5169 (read_objects, initial_obarray, oblookup_last_bucket_number):
5171 (make_symbol): Remove; unused.
5172 * lisp.h (initial_obarray, make_symbol): Remove decls.
5174 * keyboard.c: Make symbols static if they're not exported.
5175 (single_kboard, recent_keys_index, total_keys, recent_keys):
5176 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5177 (this_single_command_key_start, echoing, last_auto_save):
5178 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5179 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5180 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5181 (Vlispy_mouse_stem, double_click_count):
5183 (force_auto_save_soon): Define only if SIGDANGER.
5184 (ignore_mouse_drag_p): Now static if
5185 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5186 (print_help): Remove; unused.
5187 (stop_character, last_timer_event): Mark as externally visible.
5188 * keyboard.h (ignore_mouse_drag_p): Declare only if
5189 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5190 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5191 * lisp.h (echoing): Remove decl.
5192 (force_auto_save_soon): Declare only if SIGDANGER.
5193 * xdisp.c (redisplay_window): Simplify code, to make it more
5194 obvious that ignore_mouse_drag_p is not accessed if !defined
5195 USE_GTK && !defined HAVE_NS.
5197 * intervals.c: Make symbols static if they're not exported.
5198 (merge_properties_sticky, merge_interval_right, delete_interval):
5200 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5202 * insdel.c: Make symbols static if they're not exported.
5203 However, leave prepare_to_modify_buffer alone. It's never
5204 called from outside this function, but that appears to be a bug.
5205 (combine_after_change_list, combine_after_change_buffer):
5206 (adjust_after_replace, signal_before_change): Now static.
5207 (adjust_after_replace_noundo): Remove; unused.
5208 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5209 (signal_before_change): Remove decls.
5211 * indent.c (val_compute_motion, val_vmotion): Now static.
5213 * image.c: Make symbols static if they're not exported.
5214 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5216 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5217 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5219 * fringe.c (standard_bitmaps): Now static.
5220 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5222 * frame.c: Make symbols static if they're not exported.
5223 (x_report_frame_params, make_terminal_frame): Now static.
5224 (get_frame_param): Now static, unless HAVE_NS.
5225 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5226 (x_get_resource_string): Remove; not used.
5227 * frame.h (make_terminal_frame, x_report_frame_params):
5228 (x_get_resource_string); Remove decls.
5229 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5230 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5232 * font.c, fontset.c: Make symbols static if they're not exported.
5233 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5234 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5235 * font.c (font_close_object): Now static.
5236 * font.h (font_close_object): Remove.
5237 * fontset.c (FONTSET_OBJLIST): Remove.
5238 (free_realized_fontset) #if-0 the body, which does nothing.
5239 (face_suitable_for_char_p): #if-0, as it's never called.
5240 * fontset.h (face_suitable_for_char_p): Remove decl.
5241 * xfaces.c (face_at_string_position):
5242 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5243 since 0 is always ASCII.
5245 * fns.c (weak_hash_tables): Now static.
5247 * fileio.c: Make symbols static if they're not exported.
5248 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5249 (Vwrite_region_annotation_buffers): Now static.
5251 * eval.c: Make symbols static if they're not exported.
5252 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5253 * lisp.h (backtrace_list): Remove decl.
5255 * emacs.c: Make symbols static if they're not exported.
5256 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5257 (fatal_error_code, fatal_error_signal_hook, standard_args):
5259 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5260 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5261 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5262 * lisp.h (fatal_error_signal_hook): Remove decl.
5263 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5265 * editfns.c: Move a (normally-unused) function to its only use.
5266 * editfns.c, lisp.h (get_operating_system_release): Remove.
5267 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5268 worth the hassle of breaking this out.
5270 * xterm.c: Make symbols static if they're not exported.
5271 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5272 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5273 (x_destroy_window, x_delete_display):
5275 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5276 (x_mouse_leave): Remove; unused.
5277 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5278 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5279 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5281 (x_mouse_leave): Declare only if WINDOWSNT.
5282 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5283 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5286 * ftxfont.c: Make symbols static if they're not exported.
5287 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5289 * font.h (ftxfont_driver): Likewise.
5291 * xfns.c: Make symbols static if they're not exported.
5292 (x_last_font_name, x_display_info_for_name):
5293 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5294 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5295 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5296 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5297 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5298 (last_show_tip_args): Now static.
5299 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5300 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5301 (x_screen_planes): Remove; unused.
5302 * dispextern.h (x_screen_planes): Remove decl.
5304 * dispnew.c: Make symbols static if they're not exported.
5305 * dispextern.h (redraw_garbaged_frames, scrolling):
5306 (increment_row_positions): Remove.
5307 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5308 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5310 (redraw_garbaged_frames): Remove; unused.
5312 * xfaces.c: Make symbols static if they're not exported.
5313 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5315 * xterm.h (defined_color): Remove decls.
5316 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5317 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5318 (menu_face_changed_default, defined_color, free_realized_face):
5319 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5320 (ascii_face_of_lisp_face): Remove; unused.
5322 * xdisp.c: Make symbols static if they're not exported.
5323 * dispextern.h (scratch_glyph_row, window_box_edges):
5324 (glyph_to_pixel_coords, set_cursor_from_row):
5325 (get_next_display_element, set_iterator_to_next):
5326 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5327 (show_mouse_face): Remove decls
5328 * frame.h (message_buf_print): Likewise.
5329 * lisp.h (pop_message, set_message, check_point_in_composition):
5331 * xterm.h (set_vertical_scroll_bar): Likewise.
5332 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5333 (message_buf_print, scratch_glyph_row, displayed_buffer):
5334 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5335 (get_next_display_element, show_mouse_face, window_box_edges):
5336 (frame_to_window_pixel_xy, check_point_in_composition):
5337 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5338 (glyph_to_pixel_coords): Remove; unused.
5340 * dired.c (file_name_completion): Now static.
5342 * dbusbind.c (xd_in_read_queued_messages): Now static.
5344 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5345 * data.c (circular_list_error): Remove.
5347 * commands.h (last_point_position, last_point_position_buffer):
5348 (last_point_position_window): Remove decls.
5349 * keyboard.c: Make these variables static.
5351 * coding.h (coding, code_convert_region, encode_coding_gap):
5353 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5354 (iso_code_class, detect_coding, code_convert_region): Now static.
5355 (encode_coding_gap): Remove; unused.
5357 * chartab.c (chartab_chars, chartab_bits): Now static.
5359 * charset.h (charset_iso_8859_1): Remove decl.
5360 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5363 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5364 * ccl.c (Vccl_program_table): Now static.
5365 (check_ccl_update): Remove; unused.
5367 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5368 * category.h: ... from here.
5369 * category.c (check_category_table, set_category_set): Now static.
5371 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5372 * lisp.h: Remove these decls.
5374 * buffer.c (buffer_count): Remove unused var.
5376 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5377 so that it's not optimized away.
5378 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5379 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5380 exported only to the debugger.
5382 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5383 * atimer.h (run_all_atimers): Remove; not exported.
5385 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5386 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5387 was inaccessible from Lisp.
5388 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5389 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5391 alloc.c: Import and export fewer symbols, and remove unused items.
5392 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5394 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5395 it's not optimized away by whole-program optimization.
5396 (message_enable_multibyte, free_misc): Remove.
5397 (catchlist, handlerlist, mark_backtrace):
5398 Declare only if BYTE_MARK_STACK.
5399 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5400 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5401 (message_enable_multibyte): Remove decl.
5402 (free_misc, interval_free_list, float_block, float_block_index):
5403 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5404 (cons_free_list, last_marked_index):
5406 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5407 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5408 (mark_backtrace): Define only if BYTE_MARK_STACK.
5409 * xdisp.c (message_enable_multibyte): Now static.
5411 Declare Lisp_Object Q* variables to be 'static' if not exported.
5412 This makes it easier for human readers (and static analyzers)
5413 to see whether these variables are used from other modules.
5414 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5415 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5416 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5417 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5418 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5419 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5420 * xmenu.c, xselect.c:
5421 Declare Q* vars static if they are not used in other modules.
5422 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5423 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5424 Remove decls of unexported vars.
5425 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5427 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5429 Make Emacs functions such as Fatom 'static' by default.
5430 This makes it easier for human readers (and static analyzers)
5431 to see whether these functions can be called from other modules.
5432 DEFUN now defines a static function. To make the function external
5433 so that it can be used in other C modules, use the new macro DEFUE.
5434 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5435 (Finit_image_library):
5436 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5437 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5438 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5439 Remove decls, since these functions are now static.
5440 (Funintern, Fget_internal_run_time): New decls, since these functions
5441 were already external.
5443 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5444 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5445 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5446 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5447 * keyboard.c, keymap.c, lread.c:
5448 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5449 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5450 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5451 Mark functions with DEFUE instead of DEFUN,
5452 if they are used in other modules.
5453 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5454 decls for now-static functions.
5455 * buffer.h (Fdelete_overlay): Remove decl.
5456 * callproc.c (Fgetenv_internal): Mark as internal.
5457 * composite.c (Fremove_list_of_text_properties): Remove decl.
5458 (Fcomposition_get_gstring): New forward static decl.
5459 * composite.h (Fcomposite_get_gstring): Remove decl.
5460 * dired.c (Ffile_attributes): New forward static decl.
5461 * doc.c (Fdocumntation_property): New forward static decl.
5462 * eval.c (Ffetch_bytecode): New forward static decl.
5463 (Funintern): Remove extern decl; now in .h file where it belongs.
5464 * fileio.c (Fmake_symbolic_link): New forward static decl.
5465 * image.c (Finit_image_library): New forward static decl.
5466 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5467 * intervals.h (Fprevious_property_change):
5468 (Fremove_list_of_text_properties): Remove decls.
5469 * keyboard.c (Fthis_command_keys): Remove decl.
5470 (Fcommand_execute): New forward static decl.
5471 * keymap.c (Flookup_key): New forward static decl.
5472 (Fcopy_keymap): Now static.
5473 * keymap.h (Flookup_key): Remove decl.
5474 * process.c (Fget_process): New forward static decl.
5475 (Fprocess_datagram_address): Mark as internal.
5476 * syntax.c (Fsyntax_table_p): New forward static decl.
5477 (skip_chars): Remove duplicate decl.
5478 * textprop.c (Fprevious_property_change): New forward static decl.
5479 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5481 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5482 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5484 * editfns.c (Fformat): Remove unreachable code.
5486 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5488 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5491 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5493 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5494 when at ZV. (Bug#8487)
5496 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5498 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5500 * keyboard.c (parse_tool_bar_item): Likewise.
5501 * sound.c (sound_cleanup, alsa_close): Likewise.
5502 * termcap.c (tgetent): Likewise.
5503 * xfns.c (x_default_font_parameter): Likewise.
5504 * xsettings.c (read_and_apply_settings): Likewise.
5506 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5507 (overrun_check_free): Protoize.
5509 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5511 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5512 since callers should never pass a negative size.
5513 Change the signature to match that of plain 'read' and 'write'; see
5514 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5515 * lisp.h: Update prototypes of emacs_write and emacs_read.
5517 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5519 * xdisp.c (redisplay_window): Don't try to determine the character
5520 position of the scroll margin if the window start point w->startp
5521 is outside the buffer's accessible region. (Bug#8468)
5523 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5525 Fix write-region and its subroutines for buffers > 2GB.
5526 * fileio.c (a_write, e_write): Modify declaration of arguments and
5527 local variables to support buffers larger than 2GB.
5528 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5530 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5531 argument, local variables, and return value.
5533 * lisp.h: Update prototypes of emacs_write and emacs_read.
5535 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5537 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5539 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5541 Fix more problems found by GCC 4.6.0's static checks.
5543 * xdisp.c (vmessage): Use a better test for character truncation.
5545 * charset.c (load_charset_map): <, not <=, for optimization,
5546 and to avoid potential problems with integer overflow.
5547 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5548 * casetab.c (set_identity, shuffle): Likewise.
5549 * editfns.c (Fformat): Likewise.
5550 * syntax.c (skip_chars): Likewise.
5552 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5553 This also lets GCC 4.6.0 generate slightly better loop code.
5555 * callint.c (Fcall_interactively): <, not <=, for optimization.
5556 (Fcall_interactively): Count the number of arguments produced,
5557 not the number of arguments given. This is simpler and lets GCC
5558 4.6.0 generate slightly better code.
5560 * ftfont.c: Distingish more carefully between FcChar8 and char.
5561 The previous code passed unsigned char * to a functions like
5562 strlen and xstrcasecmp that expect char *, which does not
5563 conform to the C standard.
5564 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5565 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5566 char * when the C standard requires it.
5568 * keyboard.c (read_char): Remove unused var.
5570 * eval.c: Port to Windows vsnprintf (Bug#8435).
5572 (SIZE_MAX): Define if the headers do not.
5573 (verror): Do not give up if vsnprintf returns a negative count.
5574 Instead, grow the buffer. This ports to Windows vsnprintf, which
5575 does not conform to C99. Problem reported by Eli Zaretskii.
5576 Also, simplify the allocation scheme, by avoiding the need for
5577 calling realloc, and removing the ALLOCATED variable.
5579 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5581 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5582 But keep the doprint source code for now, as we might revamp it
5583 and use it again (Bug#8435).
5584 * lisp.h (doprnt): Remove.
5585 * Makefile.in (base_obj): Remove doprnt.o.
5586 * deps.mk (doprnt.o): Remove.
5588 error: Print 32- and 64-bit integers portably (Bug#8435).
5589 Without this change, on typical 64-bit hosts error ("...%d...", N)
5590 was used to print both 32- and 64-bit integers N, which relied on
5592 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5594 * lisp.h (error, verror): Mark as printf-like functions.
5595 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5596 Report overflow in size calculations when allocating printf buffer.
5597 Do not truncate output string at its first null byte.
5598 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5599 Truncate the output at a character boundary, since vsnprintf does not
5601 * charset.c (check_iso_charset_parameter): Convert internal
5602 character to string before calling 'error', since %c now has the
5604 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5605 overflow when computing char to be passed to 'error'. Do not
5606 pass Lisp_Object to 'error'; pass the integer instead.
5607 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5608 formatted with plain %d.
5610 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5612 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5614 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5616 * xterm.c (x_catch_errors): Remove duplicate declaration.
5618 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5620 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5622 2011-04-10 Jim Meyering <meyering@redhat.com>
5624 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5625 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5626 return ssize_t not "int", and use size_t as the buffer length.
5627 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5628 * gnutls.h: Update declarations.
5629 * process.c (read_process_output): Use ssize_t, to match.
5630 (send_process): Likewise.
5632 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5634 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5636 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5638 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5639 Use unsigned char, to match FcChar8 type definition.
5641 * xterm.c (handle_one_xevent):
5642 * xmenu.c (create_and_show_popup_menu):
5643 * xselect.c (x_decline_selection_request)
5644 (x_reply_selection_request): Avoid type-punned deref of X events.
5646 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5648 Fix some uses of `int' instead of EMACS_INT.
5649 * search.c (string_match_1, fast_string_match)
5650 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5651 (scan_buffer, find_next_newline_no_quit)
5652 (find_before_next_newline, search_command, Freplace_match)
5653 (Fmatch_data): Make some `int' variables be EMACS_INT.
5655 * xdisp.c (display_count_lines): 3rd argument and return value now
5656 EMACS_INT. All callers changed.
5657 (pint2hrstr): Last argument is now EMACS_INT.
5659 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5660 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5661 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5662 (decode_coding_utf_16, decode_coding_emacs_mule)
5663 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5664 (decode_coding_ccl, decode_coding_charset)
5665 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5666 (decode_coding_iso_2022, decode_coding_emacs_mule)
5667 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5668 <char_offset, last_offset>: Declare EMACS_INT.
5669 (encode_coding_utf_8, encode_coding_utf_16)
5670 (encode_coding_emacs_mule, encode_invocation_designation)
5671 (encode_designation_at_bol, encode_coding_iso_2022)
5672 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5673 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5675 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5676 (encode_invocation_designation): Last argument P_NCHARS is now
5678 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5679 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5681 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5684 * ccl.c (Fccl_execute_on_string): Declare some variables
5687 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5689 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5691 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5693 * process.c (Fformat_network_address): Doc fix.
5695 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5697 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5699 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5701 * keyboard.c (read_char): Call Lisp function help-form-show,
5702 instead of using internal_with_output_to_temp_buffer.
5703 (Qhelp_form_show): New var.
5704 (syms_of_keyboard): Use DEFSYM macro.
5706 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5708 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5710 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5712 * process.c (Flist_processes): Remove to Lisp.
5713 (list_processes_1): Delete.
5715 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5717 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5719 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5721 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5723 Fix more problems found by GCC 4.6.0's static checks.
5725 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5727 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5729 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5731 * xdisp.c (vmessage): Mark as a printf-like function.
5733 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5735 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5737 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5738 printf-like functions.
5739 (tiff_load): Add casts to remove these marks before passing them
5740 to system-supplied API.
5742 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5744 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5745 This avoids several warnings with gcc -Wstrict-overflow.
5746 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5747 directly, rather than having caller test rule sign. This avoids
5748 some unnecessary tests.
5749 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5750 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5751 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5753 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5754 (xfont_open): Avoid unnecessary tests.
5756 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5758 * composite.h, composite.c (composition_gstring_put_cache):
5759 Use EMACS_INT, not int, for length.
5761 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5762 breaking out part of COMPOSITION_DECODE_RULE.
5763 (COMPOSITION_DECODE_RULE): Use it.
5764 * composite.c (get_composition_id): Remove unused local vars,
5765 by using the new macro.
5767 * textprop.c (set_text_properties_1): Change while to do-while,
5768 since the condition is always true at first.
5770 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5771 (interval_deletion_adjustment): Return unsigned value.
5774 * process.c (list_processes_1, create_pty, read_process_output):
5775 (exec_sentinel): Remove vars that were set but not used.
5776 (create_pty): Remove unnecessary "volatile"s.
5777 (Fnetwork_interface_info): Avoid possibility of int overflow.
5778 (read_process_output): Do adaptive read buffering even if carryover.
5779 (read_process_output): Simplify nbytes computation if buffered.
5781 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5783 * syntax.c (scan_words): Remove var that was set but not used.
5784 (update_syntax_table): Use unsigned instead of int.
5786 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5787 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5788 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5790 * print.c (print_error_message): Avoid int overflow.
5792 * font.c (font_list_entities): Redo for clarity,
5793 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5795 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5796 (font_score): Avoid potential overflow in diff calculation.
5798 * fns.c (substring_both): Remove var that is set but not used.
5799 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5801 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5803 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5804 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5805 can always succeed if overflow has undefined behavior.
5807 * search.c (boyer_moore, wordify): Remove vars set but not used.
5808 (wordify): Omit three unnecessary tests.
5810 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5811 All callers changed. This avoids the need for an unused var.
5813 * casefiddle.c (casify_region): Remove var that is set but not used.
5815 * dired.c (file_name_completion): Remove var that is set but not used.
5817 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5819 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5820 (Finsert_file_contents): Remove unnecessary code checking fd.
5822 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5823 Check for integer overflow on size calculations.
5825 * buffer.c (Fprevious_overlay_change): Remove var that is set
5828 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5829 Remove vars that are set but not used.
5830 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5831 (timer_check_2): Mark vars as initialized.
5833 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5835 * image.c (lookup_image): Remove var that is set but not used.
5836 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5838 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5839 that are set but not used.
5841 * xfns.c (make_invisible_cursor): Don't return garbage
5842 if XCreateBitmapFromData fails (Bug#8410).
5844 * xselect.c (x_get_local_selection, x_handle_property_notify):
5845 Remove vars that are set but not used.
5847 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5848 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5850 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5851 Remove var that is set but not used.
5852 (scroll_bar_windows_size): Now size_t, not int.
5853 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5856 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5857 (map_tty_color) [!defined MSDOS]: Likewise.
5859 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5861 * coding.c: Remove vars that are set but not used.
5862 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5863 All callers changed.
5864 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5865 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5866 (decode_coding_charset): Remove vars that are set but not used.
5868 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5869 that is set but not used.
5871 * print.c (print_object): Remove var that is set but not used.
5873 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5874 The gnulib version avoids calling malloc in the usual case,
5875 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5876 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5877 * filelock.c (current_lock_owner): Likewise.
5878 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5879 * sysdep.c: Include allocator.h, careadlinkat.h.
5880 (emacs_no_realloc_allocator): New static constant.
5881 (emacs_readlink): New function.
5882 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5883 ../lib/careadlinkat.h.
5885 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5887 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5888 first non-nil return value).
5890 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5892 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5893 if not defined (Bug#8403).
5895 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5897 * xdisp.c (display_count_lines): Remove parameter `start',
5898 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5899 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5900 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5901 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5902 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5903 and thereabouts. All callers changed.
5904 (get_per_char_metric): Remove parameter `f', unused since
5905 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5907 2011-04-02 Jim Meyering <meyering@redhat.com>
5909 do not dereference NULL upon failed strdup
5910 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5911 (ns_get_family): Likewise.
5913 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5915 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5917 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5919 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5922 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5924 Add lexical binding.
5926 * window.c (Ftemp_output_buffer_show): New fun.
5927 (Fsave_window_excursion):
5928 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5930 * lread.c (lisp_file_lexically_bound_p): New function.
5931 (Fload): Bind Qlexical_binding.
5932 (readevalloop): Remove `evalfun' arg.
5933 Bind Qinternal_interpreter_environment.
5934 (Feval_buffer): Bind Qlexical_binding.
5935 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5937 (syms_of_lread): Declare `lexical-binding'.
5939 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5941 * keyboard.c (eval_dyn): New fun.
5942 (menu_item_eval_property): Use it.
5944 * image.c (parse_image_spec): Use Ffunctionp.
5946 * fns.c (concat, mapcar1): Accept byte-code-functions.
5948 * eval.c (Fsetq): Handle lexical vars.
5949 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5950 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5951 (FletX, Flet): Obey lexical binding.
5952 (Fcommandp): Handle closures.
5953 (Feval): New `lexical' arg.
5954 (eval_sub): New function extracted from Feval. Use it almost
5955 everywhere where Feval was used. Look up vars in lexical env.
5957 (Ffunctionp): Move from subr.el.
5958 (Ffuncall): Handle closures.
5959 (apply_lambda): Remove `eval_flags'.
5960 (funcall_lambda): Handle closures and new byte-code-functions.
5961 (Fspecial_variable_p): New function.
5962 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5963 but without exporting it to Lisp.
5965 * doc.c (Fdocumentation, store_function_docstring):
5966 * data.c (Finteractive_form): Handle closures.
5968 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5971 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5973 (exec_byte_code): New function extracted from Fbyte_code to handle new
5974 calling convention for byte-code-functions. Add new byte-codes.
5976 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5978 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5980 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5982 * xdisp.c (redisplay_internal): Fix prototype.
5984 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5986 * xdisp.c (SCROLL_LIMIT): New macro.
5987 (try_scrolling): Use it when setting scroll_limit.
5988 Limit scrolling to 100 screen lines.
5989 (redisplay_window): Even when falling back on "recentering",
5990 position point in the window according to scroll-conservatively,
5991 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5993 (try_scrolling): When point is above the window, allow searching
5994 as far as scroll_max, or one screenful, to compute vertical
5995 distance from PT to the scroll margin position. This prevents
5996 try_scrolling from unnecessarily failing when
5997 scroll-conservatively is set to a value slightly larger than the
5998 window height. Clean up the case of PT below the margin at bottom
5999 of window: scroll_max can no longer be INT_MAX. When aggressive
6000 scrolling is in use, don't let point enter the opposite scroll
6001 margin as result of the scroll.
6002 (syms_of_xdisp) <scroll-conservatively>: Document the
6003 threshold of 100 lines for never-recentering scrolling.
6005 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6007 * dispextern.h (move_it_by_lines):
6008 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6009 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6010 (message_log_check_duplicate): Remove parameters `prev_bol' and
6011 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6012 (redisplay_internal): Remove parameter `preserve_echo_area',
6013 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6015 * indent.c (Fvertical_motion):
6016 * window.c (window_scroll_pixel_based, Frecenter):
6017 Don't pass `need_y_p' to `move_it_by_lines'.
6019 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6021 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6022 steal a few bits to be more compact.
6023 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6024 Remove unneeded casts.
6026 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6028 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6030 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6031 binding" message (bug#7967).
6033 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6035 Fix more problems found by GCC 4.6.0's static checks.
6037 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6038 Remove unused local var.
6040 * editfns.c (Fmessage_box): Remove unused local var.
6042 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6043 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6044 Omit unused local vars.
6045 * window.c (shrink_windows): Omit unused local var.
6046 * menu.c (digest_single_submenu): Omit unused local var.
6047 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6048 Omit unused local var.
6050 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6051 Don't assume string length fits in int.
6052 (keyremap_step, read_key_sequence): Use size_t for sizes.
6053 (read_key_sequence): Don't check last_real_key_start redundantly.
6055 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6056 instead of alloca (Bug#8344).
6058 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6059 (Fbacktrace_frame): Don't assume nframes fits in int.
6061 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6063 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6066 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6068 * cm.c (calccost): Turn while-do into do-while, for clarity.
6070 * keyboard.c (syms_of_keyboard): Use the same style as later
6071 in this function when indexing through an array. This also
6072 works around GCC bug 48267.
6074 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6076 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6078 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6079 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6081 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6082 This avoids undefined behavior on integer overflow, and is a bit
6083 more convenient anyway since it is compared to a size_t variable.
6085 Variadic C functions now count arguments with size_t, not int.
6086 This avoids an unnecessary limitation on 64-bit machines, which
6087 caused (substring ...) to crash on large vectors (Bug#8344).
6088 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6089 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6090 All variadic functions and their callers changed accordingly.
6091 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6092 * data.c (arith_driver, float_arith_driver): Likewise.
6093 * editfns.c (general_insert_function): Likewise.
6094 * eval.c (struct backtrace.nargs, interactive_p)
6095 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6096 (funcall_lambda, mark_backtrace): Likewise.
6097 * fns.c (concat): Likewise.
6098 * frame.c (x_set_frame_parameters): Likewise.
6099 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6100 0 if not found, not -1. All callers changed.
6102 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6103 (stack_copy_size): Now size_t, not int.
6104 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6106 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6108 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6109 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6110 All callers changed.
6112 * lisp.h (multibyte_char_to_unibyte):
6113 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6114 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6115 * character.h (CHAR_TO_BYTE8):
6116 * cmds.c (internal_self_insert):
6117 * editfns.c (general_insert_function):
6118 * keymap.c (push_key_description):
6119 * search.c (Freplace_match):
6120 * xdisp.c (message_dolog, set_message_1): All callers changed.
6122 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6124 * keyboard.c (safe_run_hook_funcall): New function.
6125 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6126 don't set the hook to nil, but remove the offending function instead.
6127 (Qcommand_hook_internal): Remove, unused.
6128 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6129 Vcommand_hook_internal.
6131 * eval.c (enum run_hooks_condition): Remove.
6132 (funcall_nil, funcall_not): New functions.
6133 (run_hook_with_args): Call each function through a `funcall' argument.
6134 Remove `cond' argument, now redundant.
6135 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6136 (Frun_hook_with_args_until_failure): Adjust accordingly.
6137 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6139 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6141 * dispextern.h (string_buffer_position): Remove declaration.
6143 * print.c (strout): Remove parameter `multibyte', unused since
6144 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6146 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6147 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6148 All callers changed.
6150 * w32.c (_wsa_errlist): Use braces for struct initializers.
6152 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6153 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6154 All callers changed.
6155 (string_buffer_position): Likewise. Also, make static (it's never
6156 used outside xdisp.c).
6157 (cursor_row_p): Remove parameter `w', unused since
6158 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6159 (decode_mode_spec): Remove parameter `precision', introduced during
6160 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6161 All callers changed.
6163 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6165 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6167 2011-03-27 Anders Lindgren <andlind@gmail.com>
6169 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6170 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6171 (ns_update_auto_hide_menu_bar): New functions.
6172 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6173 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6174 ns_constrain_all_frames.
6175 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6176 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6178 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6180 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6182 2011-03-27 Glenn Morris <rgm@gnu.org>
6184 * syssignal.h: Replace RETSIGTYPE with void.
6185 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6186 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6187 Replace SIGTYPE with void everywhere.
6188 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6189 * s/template.h (SIGTYPE): Remove commented out definition.
6191 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6193 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6194 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6196 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6198 * w32.c (read_unc_volume): Use parameter `henum', instead of
6199 global variable `wget_enum_handle'.
6201 * keymap.c (describe_vector): Remove parameters `indices' and
6202 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6203 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6205 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6207 * keyboard.c (timer_check): Remove parameter `do_it_now',
6208 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6209 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6210 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6212 * keyboard.c (read_char):
6213 * w32menu.c (w32_menu_display_help):
6214 * xmenu.c (show_help_event, menu_help_callback):
6215 Adjust calls to `show_help_echo'.
6217 * gtkutil.c (xg_maybe_add_timer):
6218 * keyboard.c (readable_events):
6219 * process.c (wait_reading_process_output):
6220 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6222 * insdel.c (adjust_markers_gap_motion):
6223 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6224 (gap_left, gap_right): Don't call it.
6226 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6228 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6229 incurred during fontification.
6231 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6233 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6234 (DEFVAR_PER_BUFFER): Don't pass it.
6236 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6237 (scrolling_window): Don't pass it.
6239 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6241 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6243 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6245 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6246 of variables specific to SELinux and computation of `encoded_absname'.
6248 * image.c (XPutPixel): Remove unused variable `height'.
6250 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6252 * unexw32.c (get_section_info): Remove unused variable `section'.
6254 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6255 (system_process_attributes): Remove unused variable `sess'.
6256 (sys_read): Remove unused variable `err'.
6258 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6259 (w32_wnd_proc): Remove unused variable `isdead'.
6260 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6261 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6262 (x_create_tip_frame): Remove unused variable `tem'.
6264 * w32inevt.c (w32_console_read_socket):
6265 Remove unused variable `no_events'.
6267 * w32term.c (x_draw_composite_glyph_string_foreground):
6268 Remove unused variable `width'.
6270 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6272 * w32term.c (x_set_glyph_string_clipping):
6273 Don't pass uninitialized region to CombineRgn.
6275 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6277 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6278 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6279 (Fx_close_connection): Remove unused variable `i'.
6281 * w32font.c (w32font_draw): Return number of glyphs.
6282 (w32font_open_internal): Remove unused variable `i'.
6283 (w32font_driver): Add missing initializer.
6285 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6286 (fill_in_menu): Remove unused variable `items_added'.
6288 * w32term.c (last_mouse_press_frame): Remove static global variable.
6289 (w32_clip_to_row): Remove unused variable `f'.
6290 (x_delete_terminal): Remove unused variable `i'.
6292 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6293 (NOTHING): Remove unused static global variable.
6294 (uniscribe_check_otf): Remove unused variable `table'.
6295 (uniscribe_font_driver): Add missing initializers.
6297 2011-03-23 Julien Danjou <julien@danjou.info>
6299 * term.c (Fsuspend_tty, Fresume_tty):
6300 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6301 * window.c (temp_output_buffer_show):
6302 * insdel.c (signal_before_change):
6303 * frame.c (Fhandle_switch_frame):
6304 * fileio.c (Fdo_auto_save):
6305 * emacs.c (Fkill_emacs):
6306 * editfns.c (save_excursion_restore):
6307 * cmds.c (internal_self_insert):
6308 * callint.c (Fcall_interactively):
6309 * buffer.c (Fkill_all_local_variables):
6310 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6312 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6313 unconditionnaly since it does the check itself.
6315 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6317 Fix more problems found by GCC 4.5.2's static checks.
6319 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6320 the first time through the loop, since we know p0 < p1 then.
6321 This also avoids a gcc -Wstrict-overflow warning.
6323 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6324 leading to a memory leak, possible in functions like
6325 load_charset_map_from_file that can allocate an unbounded number
6326 of objects (Bug#8318).
6328 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6329 that could (at least in theory) be that large.
6331 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6332 This is less likely to overflow, and avoids undefined behavior if
6333 overflow does occur. All callers changed. Use strtoul to scan
6334 for the unsigned long integer.
6335 (pint2hrstr): Simplify and tune code slightly.
6336 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6338 * scroll.c (do_scrolling): Work around GCC bug 48228.
6339 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6341 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6342 This also avoids a warning with gcc -Wstrict-overflow.
6343 (validate_x_resource_name): Simplify count usage.
6344 This also avoids a warning with gcc -Wstrict-overflow.
6346 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6349 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6351 * process.c (Fmake_network_process): Use socklen_t, not int,
6352 where POSIX says socklen_t is required in portable programs.
6353 This fixes a porting bug on hosts like 64-bit HP-UX, where
6354 socklen_t is wider than int (Bug#8277).
6355 (Fmake_network_process, server_accept_connection):
6356 (wait_reading_process_output, read_process_output):
6359 * process.c: Rename or move locals to avoid shadowing.
6360 (list_processes_1, Fmake_network_process):
6361 (read_process_output_error_handler, exec_sentinel_error_handler):
6362 Rename or move locals.
6363 (Fmake_network_process): Define label "retry_connect" only if needed.
6364 (Fnetwork_interface_info): Fix pointer signedness.
6365 (process_send_signal): Add cast to avoid pointer signedness problem.
6366 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6367 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6369 Make tparam.h and terminfo.c consistent.
6370 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6371 Include tparam.h instead, since it declares them.
6372 * cm.h (PC): Remove extern decl; tparam.h now does this.
6373 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6374 * terminfo.c: Include tparam.h, to check interfaces.
6375 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6376 (tparam): Adjust signature to match interface in tparam.h;
6377 this removes some undefined behavior. Check that outstring and len
6378 are zero, which they always are with Emacs.
6379 * tparam.h (PC, BC, UP): New extern decls.
6381 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6382 (xftfont_open): Rename locals to avoid shadowing.
6384 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6385 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6386 (OTF_TAG_SYM): Omit macro if not needed.
6387 (ftfont_list): Remove unused local.
6388 (get_adstyle_property, ftfont_pattern_entity):
6389 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6390 Rename locals to avoid shadowing.
6392 * xfont.c (xfont_list_family): Mark var as initialized.
6394 * xml.c (make_dom): Now static.
6396 * composite.c (composition_compute_stop_pos): Rename local to
6398 (composition_reseat_it): Remove unused locals.
6399 (find_automatic_composition, composition_adjust_point): Likewise.
6400 (composition_update_it): Mark var as initialized.
6401 (find_automatic_composition): Mark vars as initialized,
6402 with a FIXME (Bug#8290).
6404 character.h: Rename locals to avoid shadowing.
6405 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6406 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6407 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6408 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6411 * textprop.c (property_change_between_p): Remove; unused.
6413 * intervals.c (interval_start_pos): Now static.
6415 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6417 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6418 Rename locals to avoid shadowing.
6420 * sound.c (wav_play, au_play, Fplay_sound_internal):
6421 Fix pointer signedness.
6422 (alsa_choose_format): Remove unused local var.
6423 (wav_play): Initialize a variable to 0, to prevent undefined
6424 behavior (Bug#8278).
6426 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6428 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6430 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6431 clobbering (Bug#8298).
6432 * sysdep.c (sys_subshell): Likewise.
6433 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6435 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6436 This should get cleaned up, so that child_setup has the
6437 same signature on all platforms.
6439 * callproc.c (call_process_cleanup): Now static.
6440 (relocate_fd): Rename locals to avoid shadowing.
6442 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6444 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6445 not to be necessary, and produces flickering.
6447 2011-03-20 Glenn Morris <rgm@gnu.org>
6449 * config.in: Remove file.
6451 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6453 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6454 are now in src/globals.h.
6455 (syms_of_minibuf): Remove spurious & from previous change.
6457 2011-03-20 Leo <sdl.web@gmail.com>
6459 * minibuf.c (completing-read-function): New variable.
6460 (completing-read-default): Rename from completing-read.
6461 (completing-read): Call completing-read-function.
6463 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6465 * xfaces.c (Fx_load_color_file):
6466 Read color file from absolute filename (bug#8250).
6468 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6470 * makefile.w32-in: Update dependencies.
6472 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6474 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6476 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6478 Fix more problems found by GCC 4.5.2's static checks.
6480 * process.c (make_serial_process_unwind, send_process_trap):
6481 (sigchld_handler): Now static.
6483 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6484 That way, the code declares only the vars that it needs.
6485 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6486 * s/cygwin.h (PTY_ITERATION): Likewise.
6487 * s/darwin.h (PTY_ITERATION): Likewise.
6488 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6490 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6491 * process.c (allocate_pty): Don't declare stb unless it's needed.
6493 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6494 (CONSTANTLIM): Remove; unused.
6495 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6496 Define only if needed.
6498 * unexelf.c (unexec): Name an expression,
6499 to avoid gcc -Wbad-function-cast warning.
6500 Use a different way to cause a compilation error if anyone uses
6501 n rather than nn, a way that does not involve shadowing.
6502 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6504 * deps.mk (unexalpha.o): Remove; unused.
6506 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6507 * unexec.h: New file.
6508 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6509 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6511 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6512 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6513 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6514 Change as necessary to match prototype in unexec.h.
6516 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6518 (back_comment, skip_chars): Mark vars as initialized.
6520 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6521 Rename locals to avoid shadowing.
6523 * lread.c (read1): Rewrite so as not to use empty "else".
6524 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6526 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6528 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6529 warning when compiling print.c.
6531 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6532 instead of using an uninitialized var.
6533 (font_sort_entities): Mark var as initialized.
6535 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6537 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6538 pointers to constants.
6539 (font_parse_fcname): Remove unused vars.
6540 (font_delete_unmatched): Now static.
6541 (font_get_spec): Remove; unused.
6542 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6543 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6544 Rename or move locals to avoid shadowing.
6546 * fns.c (require_nesting_list, require_unwind): Now static.
6547 (Ffillarray): Rename locals to avoid shadowing.
6549 * floatfns.c (domain_error2): Define only if needed.
6550 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6552 * alloc.c (mark_backtrace): Move decl from here ...
6553 * lisp.h: ... to here, so that it can be checked.
6555 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6556 (Fdefvar): Rewrite so as not to use empty "else".
6557 (lisp_indirect_variable): Name an expression,
6558 to avoid gcc -Wbad-function-cast warning.
6559 (Fdefvar): Rename locals to avoid shadowing.
6561 * callint.c (quotify_arg, quotify_args): Now static.
6562 (Fcall_interactively): Rename locals to avoid shadowing.
6563 Use const pointer when appropriate.
6565 * lisp.h (get_system_name, get_operating_system_release):
6566 Move decls here, to check interfaces.
6567 * process.c (get_operating_system_release): Move decl to lisp.h.
6568 * xrdb.c (get_system_name): Likewise.
6569 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6570 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6571 some of which prompt warnings from gcc -Wbad-function-cast.
6572 (Fformat_time_string, Fencode_time, Finsert_char):
6573 (Ftranslate_region_internal, Fformat):
6574 Rename or remove local vars to avoid shadowing.
6575 (Ftranslate_region_internal): Mark var as initialized.
6577 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6580 * lisp.h (eassert): Check that the argument compiles, even if
6581 ENABLE_CHECKING is not defined.
6583 * data.c (Findirect_variable): Name an expression, to avoid
6584 gcc -Wbad-function-cast warning.
6585 (default_value, arithcompare, arith_driver, arith_error): Now static.
6586 (store_symval_forwarding): Rename local to avoid shadowing.
6587 (Fmake_variable_buffer_local, Fmake_local_variable):
6588 Mark variables as initialized.
6589 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6591 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6592 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6593 Rename locals to avoid shadowing.
6594 (mark_stack): Move local variables into the #ifdef region where
6596 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6597 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6599 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6600 (GC_STRING_CHARS): Remove; not used.
6601 (Fmemory_limit): Cast sbrk's returned value to char *.
6603 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6604 avoids undefined behavior in theory.
6606 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6608 Use functions, not macros, for up- and down-casing (Bug#8254).
6609 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6610 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6611 to use the following functions instead of these macros.
6612 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6613 EMACS_INT, since callers assume the returned value fits in int.
6614 (upcase1): Likewise, for UPCASE_TABLE.
6615 (uppercasep, lowercasep, upcase): New static inline functions.
6616 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6617 the race-condition problem in the old DOWNCASE.
6619 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6620 Rename locals to avoid shadowing.
6621 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6622 (regex_compile, re_search_2, re_match_2_internal):
6623 Remove unused local vars.
6624 (FREE_VAR): Rewrite so as not to use empty "else",
6625 which gcc can warn about.
6626 (regex_compile, re_match_2_internal): Mark locals as initialized.
6627 (RETALLOC_IF): Define only if needed.
6628 (WORDCHAR_P): Likewise. This one is never needed, but is used
6629 only in a comment talking about a compiler bug, so put inside
6630 the #if 0 of that comment.
6631 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6632 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6635 * search.c (boyer_moore): Rename locals to avoid shadowing.
6636 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6637 (PREV_CHAR_BOUNDARY): Likewise.
6639 * search.c (simple_search): Remove unused var.
6641 * dired.c (compile_pattern): Move decl from here ...
6642 * lisp.h: ... to here, so that it can be checked.
6643 (struct re_registers): New forward decl.
6645 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6647 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6649 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6650 Rename locals to avoid shadowing.
6651 (Fvertical_motion): Mark locals as initialized.
6653 * casefiddle.c (casify_object, casify_region): Now static.
6654 (casify_region): Mark local as initialized.
6656 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6658 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6659 New macros, so that the caller can use some names other than
6660 gcpro1, gcpro2, etc.
6661 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6663 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6664 argument, for consistency with GCPRO2_VAR, etc: it is now the
6665 prefix of the variable, not the variable itself. All uses
6667 * dired.c (directory_files_internal, file_name_completion):
6668 Rename locals to avoid shadowing.
6670 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6671 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6672 dired.c's scmp function, had undefined behavior.
6673 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6674 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6675 * buffer.h: ... to here, because these macros use current_buffer,
6676 and the new implementation with inline functions needs to have
6677 current_buffer in scope now, rather than later when the macros
6679 (downcase, upcase1): New static inline functions.
6680 (DOWNCASE, UPCASE1): Reimplement using these functions.
6681 This avoids undefined behavior in expressions like
6682 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6683 from race conditions in accessing the global variables
6684 case_temp1 and case_temp2.
6685 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6686 * lisp.h (case_temp1, case_temp2): Remove their decls.
6687 * character.h (ASCII_CHAR_P): Move from here ...
6688 * lisp.h: ... to here, so that the inline functions mentioned
6691 * dired.c (directory_files_internal_unwind): Now static.
6693 * fileio.c (file_name_as_directory, directory_file_name):
6694 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6696 (file_name_as_directory): Use const pointers when appropriate.
6697 (Fexpand_file_name): Likewise. In particular, newdir might
6698 point at constant storage, so make it a const pointer.
6699 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6700 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6702 (Fset_file_times, Finsert_file_contents, auto_save_error):
6703 Rename locals to avoid shadowing.
6705 * minibuf.c (choose_minibuf_frame_1): Now static.
6706 (Ftry_completion, Fall_completions): Rename or remove locals
6709 * marker.c (bytepos_to_charpos): Remove; unused.
6711 * lisp.h (verify_bytepos, count_markers): New decls,
6712 so that gcc does not warn that these functions aren't declared.
6714 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6715 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6716 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6717 (copy_text): Remove unused local var.
6719 * filelock.c (within_one_second): Now static.
6720 (lock_file_1): Rename local to avoid shadowing.
6722 * buffer.c (fix_overlays_before): Mark locals as initialized.
6723 (fix_start_end_in_overlays): Likewise. This function should be
6724 simplified by using pointers-to-pointers, but that's a different
6726 (switch_to_buffer_1): Now static.
6727 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6728 (report_overlay_modification): Rename locals to avoid shadowing.
6730 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6731 Fix pointer signedness issue.
6732 (sys_subshell): Mark local as volatile if checking for lint,
6733 to suppress a gcc -Wclobbered warning that does not seem to be right.
6734 (MAXPATHLEN): Define only if needed.
6736 * process.c (serial_open, serial_configure): Move decls from here ...
6737 * systty.h: ... to here, so that they can be checked.
6739 * fns.c (get_random, seed_random): Move extern decls from here ...
6740 * lisp.h: ... to here, so that they can be checked.
6742 * sysdep.c (reset_io): Now static.
6743 (wait_for_termination_signal): Remove; unused.
6745 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6746 (copy_keymap_item, append_key, push_text_char_description):
6748 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6749 (DENSE_TABLE_SIZE): Remove; unused.
6750 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6751 (describe_map_tree):
6752 Rename locals to avoid shadowing.
6754 * keyboard.c: Declare functions static if they are not used elsewhere.
6755 (echo_char, echo_dash, cmd_error, top_level_2):
6756 (poll_for_input, handle_async_input): Now static.
6757 (read_char, kbd_buffer_get_event, make_lispy_position):
6758 (make_lispy_event, make_lispy_movement, apply_modifiers):
6759 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6760 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6761 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6762 (read_key_sequence, read_char): Mark locals as initialized.
6763 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6765 * keyboard.h (make_ctrl_char): New decl.
6766 (mark_kboards): Move decl here ...
6767 * alloc.c (mark_kboards): ... from here.
6769 * lisp.h (force_auto_save_soon): New decl.
6771 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6772 (DEFINE_DUMMY_FUNCTION): New macro.
6773 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6775 (main): Add casts to avoid warnings
6776 if GCC considers string literals to be constants.
6778 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6780 * dbusbind.c: Pointer signedness fixes.
6781 (xd_signature, xd_append_arg, xd_initialize):
6782 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6783 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6784 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6785 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6787 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6788 if GCC considers string literals to be constants.
6789 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6791 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6793 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6794 (print_preprocess, print_object): New macro to fix last change.
6796 * print.c (print_preprocess): Don't forget font objects.
6798 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6800 * emacs.c (USAGE3): Doc fixes.
6802 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6804 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6807 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6809 * lisp.h (VWindow_system, Qfile_name_history):
6810 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6811 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6812 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6814 * w32select.c: Don't #include "keyboard.h".
6815 (run_protected): Add extern declaration for waiting_for_input.
6817 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6818 * w32console.c (detect_input_pending, read_input_pending)
6819 (encode_terminal_code):
6820 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6821 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6822 (w32_system_caret_y, Qfile_name_history):
6823 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6824 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6825 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6826 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6827 * w32proc.c (Qlocal, report_file_error):
6828 * w32term.c (Vwindow_system, updating_frame):
6829 * w32uniscribe.c (initialized, uniscribe_font_driver):
6830 Remove unneeded extern declarations.
6832 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6834 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6836 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6838 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6839 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6840 These macros can no longer be used for assignment.
6842 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6843 Assign struct members directly, instead of using BUF_BEGV etc.
6844 (record_buffer_markers, fetch_buffer_markers): New functions for
6845 recording and fetching special buffer markers.
6846 (set_buffer_internal_1, set_buffer_temp): Use them.
6848 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6850 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6852 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6853 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6855 * xdisp.c (hscroll_window_tree):
6856 (reconsider_clip_changes): Use PT instead of BUF_PT.
6858 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6860 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6861 $(EMACS_ROOT)/lib/intprops.h.
6863 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6865 Fix more problems found by GCC 4.5.2's static checks.
6867 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6868 to unsigned char * to avoid compiler diagnostic.
6869 (xg_free_frame_widgets): Make it clear that a local variable is
6870 needed only if USE_GTK_TOOLTIP.
6871 (gdk_window_get_screen): Make it clear that this macro is needed
6872 only if USE_GTK_TOOLTIP.
6873 (int_gtk_range_get_value): New function, which avoids a diagnostic
6874 from gcc -Wbad-function-cast.
6875 (xg_set_toolkit_scroll_bar_thumb): Use it.
6876 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6877 diagnostic from gcc -Wbad-function-cast.
6878 (get_utf8_string, xg_get_file_with_chooser):
6879 Rename locals to avoid shadowing.
6880 (create_dialog): Move locals to avoid shadowing.
6882 * xgselect.c (xg_select): Remove unused var.
6884 * image.c (four_corners_best): Mark locals as initialized.
6885 (gif_load): Initialize transparent_p to zero (Bug#8238).
6886 Mark another local as initialized.
6887 (my_png_error, my_error_exit): Mark with NO_RETURN.
6889 * image.c (clear_image_cache): Now static.
6890 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6891 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6892 (x_edge_detection): Remove unnecessary cast that
6893 gcc -Wbad-function-cast diagnoses.
6894 (gif_load): Fix pointer signedness.
6895 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6896 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6898 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6900 Improve quality of tests for time stamp overflow.
6901 For example, without this patch (encode-time 0 0 0 1 1
6902 1152921504606846976) returns the obviously-bogus value (-948597
6903 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6904 reports time overflow. See
6905 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6906 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6907 * editfns.c: Include limits.h and intprops.h.
6908 (TIME_T_MIN, TIME_T_MAX): New macros.
6909 (time_overflow): Move earlier, to before first use.
6910 (hi_time, lo_time): New functions, for an accurate test for
6912 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6913 (Fget_internal_run_time): Don't assume time_t fits in int.
6914 (make_time): Use list2 instead of Fcons twice.
6915 (Fdecode_time): More accurate test for out-of-range times.
6916 (check_tm_member): New function.
6917 (Fencode_time): Use it, to test for out-of-range times.
6918 (lisp_time_argument): Don't rely on undefined left-shift and
6919 right-shift behavior when checking for time stamp overflow.
6921 * editfns.c (time_overflow): New function, refactoring common code.
6922 (Fformat_time_string, Fdecode_time, Fencode_time):
6923 (Fcurrent_time_string): Use it.
6925 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6926 * dired.c (make_time): Move to ...
6927 * editfns.c (make_time): ... here.
6928 * systime.h: Note the move.
6930 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6932 * fringe.c (update_window_fringes): Remove unused variables.
6934 * unexmacosx.c (copy_data_segment): Also copy __got section.
6937 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6939 * termcap.c [MSDOS]: Include "msdos.h".
6940 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6941 Constify `char *' arguments and their references according to
6942 prototypes in tparam.h.
6944 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6946 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6947 Adapt all references accordingly.
6949 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6951 2011-03-11 Tom Tromey <tromey@redhat.com>
6953 * buffer.c (syms_of_buffer): Remove obsolete comment.
6955 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6957 * termhooks.h (encode_terminal_code): Declare prototype.
6959 * msdos.c (encode_terminal_code): Don't declare prototype.
6961 * term.c (encode_terminal_code): Now external again, used by
6962 w32console.c and msdos.c.
6964 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6965 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6967 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6969 Fix some minor problems found by GCC 4.5.2's static checks.
6971 * fringe.c (update_window_fringes): Mark locals as initialized
6973 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6975 * alloc.c (mark_fringe_data): Move decl from here ...
6976 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6977 to check its interface.
6978 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6980 * fontset.c (free_realized_fontset): Now static.
6981 (Fset_fontset_font): Rename local to avoid shadowing.
6982 (fontset_font): Mark local as initialized.
6983 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6985 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6987 * xselect.c (x_disown_buffer_selections): Remove; not used.
6988 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6989 (x_own_selection, Fx_disown_selection_internal): Rename locals
6991 (x_handle_dnd_message): Remove local to avoid shadowing.
6993 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6994 so that the caller can use some name other than gcpro1.
6995 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6996 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6997 (Fx_backspace_delete_keys_p):
6998 Use them to avoid shadowing, and rename vars to avoid shadowing.
6999 (x_decode_color, x_set_name, x_window): Now static.
7000 (Fx_create_frame): Add braces to silence GCC warning.
7001 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7002 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7003 Remove unused locals.
7004 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7005 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7006 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7009 * xterm.h (x_mouse_leave): New decl.
7011 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7012 Remove unused functions.
7013 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7014 (x_calc_absolute_position): Now static.
7015 (XTread_socket): Don't define label "out" unless it's used.
7016 Don't declare local "event" unless it's used.
7017 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7018 unless they are used.
7019 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7020 (x_fatal_error_signal): Remove; not used.
7021 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7022 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7023 (x_error_catcher, x_connection_closed, x_error_handler):
7024 (x_error_quitter, xembed_send_message, x_iconify_frame):
7025 (my_log_handler): Rename locals to avoid shadowing.
7026 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7027 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7029 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7030 Rename or move locals to avoid shadowing.
7031 (tty_defined_color, merge_face_heights): Now static.
7032 (free_realized_faces_for_fontset): Remove; not used.
7033 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7034 does not deduce is never used uninitialized.
7035 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7036 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7038 * terminal.c (store_terminal_param): Now static.
7040 * xmenu.c (menu_highlight_callback): Now static.
7041 (set_frame_menubar): Remove unused local.
7042 (xmenu_show): Rename parameter to avoid shadowing.
7043 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7044 since they might point to immutable storage.
7045 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7046 since it's unused otherwise.
7048 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7049 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7050 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7051 avoids a gcc -Wuninitialized diagnostic.
7052 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7053 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7054 does not deduce are never used uninitialized.
7056 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7058 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7059 * window.c (window_loop, size_window):
7060 (run_window_configuration_change_hook, enlarge_window): Likewise.
7062 * window.c (display_buffer): Now static.
7063 (size_window): Mark variables that gcc -Wuninitialized
7064 does not deduce are never used uninitialized.
7065 * window.h (check_all_windows): New decl, to forestall
7066 gcc -Wmissing-prototypes diagnostic.
7067 * dispextern.h (bidi_dump_cached_states): Likewise.
7069 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7071 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7073 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7074 and to avoid gcc -Wuninitialized warning.
7075 (load_charset_map): Mark variables that gcc -Wuninitialized
7076 does not deduce are never used uninitialized.
7077 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7079 * coding.c (coding_set_source, coding_set_destination):
7080 Use "else { /* comment */ }" rather than "else /* comment */;"
7081 for clarity, and to avoid gcc -Wempty-body warning.
7082 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7083 a block, when the outer 'i' will do.
7084 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7085 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7086 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7087 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7088 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7089 Rename locals to avoid shadowing.
7090 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7091 * coding.c (emacs_mule_char, encode_invocation_designation):
7092 Now static, since they're not used elsewhere.
7093 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7094 (decode_coding_object, encode_coding_object, detect_coding_system):
7095 (decode_coding_emacs_mule): Mark variables that gcc
7096 -Wuninitialized does not deduce are never used uninitialized.
7097 (detect_coding_iso_2022): Initialize a local variable that might
7098 be used uninitialized. Leave a FIXME because it's not clear that
7099 this initialization is needed. (Bug#8211)
7100 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7101 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7102 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7103 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7104 Remove unused macros.
7106 * category.c (hash_get_category_set): Remove unused local var.
7107 (copy_category_table): Now static, since it's not used elsewhere.
7108 * character.c (string_count_byte8): Likewise.
7110 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7111 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7113 * chartab.c (copy_sub_char_table): Now static, since it's not used
7115 (sub_char_table_ref_and_range, char_table_ref_and_range):
7116 Rename locals to avoid shadowing.
7117 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7119 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7120 (BIDI_BOB): Remove unused macro.
7122 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7123 deduce are never used uninitialized.
7124 * term.c (encode_terminal_code): Likewise.
7126 * term.c (encode_terminal_code): Now static. Remove unused local.
7128 * tparam.h: New file.
7129 * term.c, tparam.h: Include it.
7130 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7131 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7132 Move these decls to tparam.h, and make them agree with what
7133 is actually in tparam.c. The previous trick of using incompatible
7134 decls in different modules does not conform to the C standard.
7135 All callers of tparam changed to use tparam's actual API.
7136 * tparam.c (tparam1, tparam, tgoto):
7137 Use const pointers where appropriate.
7139 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7140 * cm.h (struct cm): Likewise.
7141 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7142 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7143 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7144 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7145 (turn_on_face, init_tty): Likewise.
7146 * termchar.h (struct tty_display_info): Likewise.
7148 * term.c (term_mouse_position): Rename local to avoid shadowing.
7150 * alloc.c (mark_ttys): Move decl from here ...
7151 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7153 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7155 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7157 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7159 * search.c (compile_pattern_1): Remove argument regp, unused since
7160 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7161 (compile_pattern): Don't pass it.
7163 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7165 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7166 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7168 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7170 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7172 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7173 gdk_window_get_screen, gdk_window_get_geometry,
7174 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7175 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7176 (xg_get_pixbuf_from_pixmap): New function.
7177 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7178 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7179 Call xg_get_pixbuf_from_pixmap instead of
7180 gdk_pixbuf_get_from_drawable.
7181 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7182 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7183 (xg_check_special_colors): Use GtkStyleContext and its functions
7185 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7186 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7187 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7188 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7189 Call gtk_widget_get_preferred_size.
7190 (xg_frame_resized): gdk_window_get_geometry only takes 5
7192 (xg_win_to_widget, xg_event_is_for_menubar):
7193 Call gdk_x11_window_lookup_for_display.
7194 (xg_set_widget_bg): New function.
7195 (delete_cb): New function.
7196 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7197 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7198 (xg_set_background_color): Call xg_set_widget_bg.
7199 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7200 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7201 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7202 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7204 (update_frame_tool_bar): Call gtk_widget_hide.
7205 (xg_initialize): Use GDK_KEY_g.
7207 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7209 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7211 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7212 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7213 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7215 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7217 * w32xfns.c (select_palette): Check success of RealizePalette against
7218 GDI_ERROR, not zero.
7220 See ChangeLog.11 for earlier changes.
7226 Copyright (C) 2011 Free Software Foundation, Inc.
7228 This file is part of GNU Emacs.
7230 GNU Emacs is free software: you can redistribute it and/or modify
7231 it under the terms of the GNU General Public License as published by
7232 the Free Software Foundation, either version 3 of the License, or
7233 (at your option) any later version.
7235 GNU Emacs is distributed in the hope that it will be useful,
7236 but WITHOUT ANY WARRANTY; without even the implied warranty of
7237 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7238 GNU General Public License for more details.
7240 You should have received a copy of the GNU General Public License
7241 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.