1 2012-07-21 Jan Djärv <jan.h.d@swipnet.se>
3 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
5 2012-07-21 Chong Yidong <cyd@gnu.org>
7 * window.c (decode_any_window): Signal an error if the window is
8 on a dead frame (Bug#11984).
10 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
12 Add indirection counting to speed up Fkill_buffer.
13 * buffer.h (struct buffer): New member.
14 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
15 (Fmake_indirect_buffer): Set indirection counter to -1, increment
16 base buffer indirection counter.
17 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
18 (Fkill_buffer): Adjust indirection counters as needed, don't walk
19 through buffer list if indirection counter is 0.
21 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
23 Extend the value returned by Fgarbage_collect with heap statistics.
24 * alloc.c (Qheap): New symbol.
25 (syms_of_alloc): DEFSYM it.
26 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
27 (Fmemory_free): Remove.
28 (syms_of_alloc): Don't defsubr it.
29 * buffer.c (Fcompact_buffer): Remove.
30 (syms_of_buffer): Don't defsubr it.
32 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
35 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
36 * lisp.h (consing_since_gc, gc_relative_threshold)
37 (memory_full_cons_threshold): Revert declaration.
38 (maybe_gc): Remove prototype, define as inline.
39 * alloc.c: Remove old commented-out code.
40 (consing_since_gc, gc_relative_threshold)
41 (memory_full_cons_threshold): Revert to global.
44 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
46 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
47 * lisp.h (build_unibyte_string): New function.
48 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
49 * sysdep.c, w32fns.c, xfns.c: Use it.
50 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
51 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
52 Adjust users accordingly.
53 * font.h (font_open_by_name): Adjust prototype.
55 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
57 Cleanup calls to Fgarbage_collect.
58 * lisp.h (maybe_gc): New prototype.
59 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
61 * alloc.c (maybe_gc): New function.
62 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
64 * bytecode.c (MAYBE_GC): Use maybe_gc.
65 * eval.c (eval_sub, Ffuncall): Likewise.
66 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
67 to avoid dependency from auto-save feature.
69 2012-07-19 Paul Eggert <eggert@cs.ucla.edu>
71 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
72 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
73 'for_each_per_buffer_object_at'.
74 All uses changed. It's better to use upper-case for macros that
75 cannot be implemented as functions, to give the reader a clue
78 2012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
80 * alloc.c (Fgarbage_collect): Tweak docstring.
82 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
84 Tweak the value returned from Fgarbage_collect again.
85 * alloc.c (Fgarbage_collect): New return value, as confirmed in
86 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
88 (total_vector_bytes): Rename to total_vector_slots, adjust
90 (total_free_vector_bytes): Rename to total_free_vector_slots,
92 (Qstring_bytes, Qvector_slots): New symbols.
93 (syms_of_alloc): DEFSYM them.
95 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
97 Buffer compaction primitive which may be used from Lisp.
98 * buffer.c (compact_buffer, Fcompact_buffer): New function.
99 (syms_of_buffer): Register Fcompact_buffer.
100 * alloc.c (Fgarbage_collect): Use compact_buffer.
101 * buffer.h (compact_buffer): New prototype.
102 (struct buffer_text): New member.
104 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
106 New macro to iterate over all buffers, miscellaneous cleanups.
107 * lisp.h (all_buffers): Remove declaration.
108 * buffer.h (all_buffers): Add declaration, with comment.
109 (for_each_buffer): New macro.
110 * alloc.c (Fgarbage_collect, mark_object): Use it.
111 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
112 (init_buffer): Likewise.
113 * data.c (Fset_default): Likewise.
114 * coding.c (code_conversion_restore): Remove redundant check
116 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
118 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
120 Fix bug that created negative-length intervals.
121 * intervals.c (merge_interval_right, merge_interval_left):
122 Do not zero out this interval if it is absorbed by its children,
123 as this interval's total length doesn't change in that case. See
124 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
126 2012-07-18 Paul Eggert <eggert@cs.ucla.edu>
128 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
129 when invoking (make-bool-vector N t) and N is a positive
130 multiple of 8 -- the last 8 bits were mistakenly cleared.
132 Remove some struct layout assumptions in bool vectors.
133 * alloc.c (bool_header_size): New constant.
134 (header_size, word_size): Move earlier, as they're now used earlier.
135 Use 'word_size' in a few more places, where it's appropriate.
136 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
137 padding before the data member of a bool vector.
138 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
139 than doing the check by hand with an abort ().
141 2012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
143 * eval.c (Fdefvar): Don't check constants since we only set the var if
144 it's not yet defined anyway (bug#11904).
146 * lisp.h (last_undo_boundary): Declare new var.
147 * keyboard.c (command_loop_1): Set it.
148 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
149 were auto-added by the command loop (bug#11774).
151 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
153 * w32font.c (Qsymbol): Remove local definition.
154 (syms_of_w32font): Don't DEFSYM it.
156 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
158 Fix sweep_vectors to handle large bool vectors correctly.
159 * alloc.c (sweep_vectors): Account total_vector_bytes for
160 bool vectors larger than VBLOCK_BYTES_MAX.
162 2012-07-18 Chong Yidong <cyd@gnu.org>
164 * frame.c (x_set_frame_parameters): Revert bogus change introduced
165 in 2012-05-25 commit by Paul Eggert (Bug#11738).
167 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
169 Return more descriptive data from Fgarbage_collect.
170 Suggested by Stefan Monnier in
171 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
172 * alloc.c (bounded_number): New function.
173 (total_buffers, total_vectors): New variable.
174 (total_string_size): Rename to total_string_bytes, adjust users.
175 (total_vector_size): Rename to total_vector_bytes, adjust users.
176 (sweep_vectors): Account total_vectors and total_vector_bytes.
177 (Fgarbage_collect): New return value. Adjust documentation.
178 (gc_sweep): Account total_buffers.
179 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
180 (VECTOR_SIZE): Remove.
181 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
182 (Qinterval, Qmisc): New symbols.
183 (syms_of_data): Initialize them.
184 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
185 (Qcons, Qbuffer): New declarations.
187 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
189 * alloc.c (Fmemory_free): Account for memory-free's own storage.
190 Round up, not down. Improve doc.
192 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
194 Restore old code in allocate_string_data to avoid Faset breakage.
195 Reported by Julien Danjou <julien@danjou.info> in
196 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
197 * alloc.c (allocate_string_data): Restore old code with minor
198 adjustments, fix comment to explain this subtle issue.
200 2012-07-17 Eli Zaretskii <eliz@gnu.org>
202 Remove FILE_SYSTEM_CASE.
203 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
205 * fileio.c (FILE_SYSTEM_CASE): Don't define.
206 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
207 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
208 call-process-region passes it through expand-file-name.
210 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
212 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
214 Fix crash when creating indirect buffer (Bug#11917)
215 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
216 Don't handle unbound variables specially if non-zero.
217 (Fbuffer_local_variables): Pass zero.
218 (clone_per_buffer_values): Pass non-zero.
220 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
222 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
223 to make the loop interruptible.
225 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
227 * gnutls.c (emacs_gnutls_handshake): Only retry if
228 GNUTLS_E_INTERRUPTED.
230 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
232 Cleanup and convert miscellaneous checks to eassert.
233 * alloc.c (mark_interval): Fix comment, partially rephrase
234 old comment from intervals.h (see below).
235 * intervals.c (find_interval, adjust_intervals_for_insertion)
236 (delete_interval, adjust_intervals_for_deletion)
237 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
239 (adjust_intervals_for_insertion, make_new_interval):
240 Remove obsolete and unused code.
241 * intervals.h (struct interval): Remove obsolete comment.
242 * textprotp.c (erase_properties): Remove unused code.
243 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
244 (Fremove_list_of_text_properties): Convert to eassert.
246 2012-07-17 Chong Yidong <cyd@gnu.org>
248 * editfns.c (Finsert_char): Doc fix.
250 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
252 Fix previous change to make Fmemory_free always accurate.
253 * alloc.c (make_interval): Update total_free_intervals.
254 (make_float): Likewise for total_free_floats.
255 (free_cons, Fcons): Likewise for total_free_conses.
256 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
257 Likewise for total_free_vector_bytes.
258 (Fmake_symbol): Likewise for total_free_symbols.
259 (bytes_free): Remove.
261 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
263 Simple free memory accounting feature.
264 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
265 (sweep_vectors): Accumulate size of free vectors.
266 (Fgarbage_collect): Setup bytes_free.
267 (Fmemory_free): New function.
268 (syms_of_alloc): Register it.
270 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
272 Cleanup overlays checking.
273 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
274 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
275 eassert and OVERLAYP.
276 (sort_overlays): Change to use OVERLAYP.
278 2012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
280 * editfns.c (Finsert_char): Make it interactive, and make the
281 second arg optional. Copy interactive spec and docstring from
284 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
286 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
287 Unlike the other wrapped functions, fabs has an unspecified
290 2012-07-16 Jan Djärv <jan.h.d@swipnet.se>
292 * nsterm.m (keyDown): Interpret flags without left/right bits
293 as the left key (Bug#11670).
295 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
297 Remove empty and useless init functions.
298 * lisp.h (init_character_once, init_fns, init_image)
299 (init_filelock, init_sound): Remove prototype.
300 * character.c (init_character_once): Remove.
301 * filelock.c (init_filelock): Likewise.
302 * fns.c (init_fns): Likewise.
303 * image.c (init_image): Likewise.
304 * sound.c (init_sound): Likewise.
305 * emacs.c (main): Adjust accordingly.
307 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
309 * gtkutil.h: Tiny cleanups.
310 (use_old_gtk_file_dialog): Remove useless declaration.
311 (xg_uses_old_file_dialog): Add suggested const attribute.
313 2012-07-15 Eli Zaretskii <eliz@gnu.org>
315 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
316 (bidi_paragraph_init): Use it to limit search forward for a strong
317 directional character in abnormally large paragraphs full of
318 neutral or weak characters. (Bug#11943)
320 2012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
322 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
323 the toolbar (Bug#9451).
324 (xg_make_tool_item): Give the widget event box a transparent
327 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
329 Cleanup basic allocation variables and functions.
330 * alloc.c (ignore_warnings, init_intervals, init_float)
331 (init_cons, init_symbol, init_marker): Remove.
332 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
333 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
334 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
335 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
336 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
337 (staticidx, init_alloc_once, init_strings, free_ablock):
338 Remove redundant initialization.
339 * fns.c (init_weak_hash_tables): Remove.
340 * lisp.h (init_weak_hash_tables): Remove prototype.
342 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
344 Use zero_vector where appropriate.
345 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
347 * lisp.h (zero_vector): New declaration.
348 * font.c (null_vector): Remove.
349 (syms_of_font): Remove initialization and staticpro.
350 (font_list_entities, font_find_for_lface): Change to use zero_vector.
351 * keymap.c (Faccessible_keymaps): Likewise.
353 2012-07-15 Leo Liu <sdl.web@gmail.com>
355 * fringe.c: Fix typo in comments.
357 2012-07-14 Leo Liu <sdl.web@gmail.com>
359 * fringe.c: Add a new bitmap exclamation-mark.
361 2012-07-14 Eli Zaretskii <eliz@gnu.org>
363 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
365 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
366 (HAVE_MENUS): Don't define, defined by editing config.in with
368 (GMALLOC_INHIBIT_VALLOC): Don't define.
369 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
371 2012-07-14 Juanma Barranquero <lekktu@gmail.com>
373 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
375 2012-07-14 Glenn Morris <rgm@gnu.org>
377 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
378 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
379 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
381 2012-07-13 Glenn Morris <rgm@gnu.org>
383 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
385 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
386 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
388 2012-07-13 Jan Djärv <jan.h.d@swipnet.se>
390 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
391 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
392 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
393 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
395 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
396 as boolean expression.
397 (x_set_window_size): Remove unused variable toolbar.
398 (ns_get_color_default, ns_mod_to_lisp): Remove.
399 (ns_mouse_position): Remove unused variables xchar and ychar.
400 (ns_compute_glyph_string_overhangs): Remove unused variable face.
401 (ns_set_vertical_scroll_bar): Remove unused variable count.
402 (ns_delete_terminal): Remove unused variable i.
403 (ns_term_init): Remove unused variables r, g and b.
404 (mouseDown): Remove unused variable window.
405 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
406 (initFrameFromEmacs): Remove unused variable vbextra.
407 (mouseEntered): Remove unused variables p and dpyinfo.
408 (mouseExited): Remove unused variables p and r.
409 (ns_define_frame_cursor, ns_clear_frame_area)
410 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
411 (menuDown): Assign [sender tag] to variable and cast the variable.
413 * nsterm.h (menuDown): Add id as type to argument sender.
414 (ns_display_info_for_name): Add Lisp_Object argument.
415 (ns_term_init): Add Lisp_Object argument.
416 (ns_map_event_to_object): Add void argument.
417 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
418 prototype with arguments and only declare if __OBJC__.
419 (nxatoms_of_nsselect): Add void argument.
420 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
421 (ns_alloc_autorelease_pool): Add void argument.
422 (ns_release_autorelease_pool): Add void* argument.
423 (ns_get_defaults_value): Add const char* argument.
425 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
426 (initFromContents): Use SSDATA where appropriate.
427 (ns_update_menubar): Add braces to ambigous if-else.
428 (initWithTitle): Put () around assignment in if statement.
429 (ns_menu_show): Remove unused variables window and keymap.
430 (update_frame_tool_bar): Remove unused variable selected_p.
431 (initWithContentRect): Remove unused variable this_cmd_name.
433 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
435 (setXBMColor): Remove unused variable len.
436 (setPixmapData): Put () around assignment in loop statement.
438 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
439 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
441 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
442 around assignment in loop statement.
443 (nsfont_open): Remove unused variable i.
444 (nsfont_open): Remove unused variable len.
445 (nsfont_draw): Remove unused variable cs.
447 * nsfns.m (x_set_icon_name, ns_set_name_internal)
448 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
449 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
450 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
451 (Fns_font_name, Fns_perform_service)
452 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
453 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
454 (ns_set_name): Remove unused variable view.
455 (x_set_menu_bar_lines): Remove unused variable olines.
456 (x_set_tool_bar_lines): Remove unused variable root_window.
457 (Fns_list_colors): Put () around assignment in while statement.
458 (Fns_perform_service): Remove unused variable len.
459 (Fns_display_usable_bounds): Remove unused variable top.
460 (syms_of_nsfns): Remove unused variable i.
462 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
465 2012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
467 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
468 and free it with DestroyExceptionInfo (Bug#11558).
470 2012-07-13 Juanma Barranquero <lekktu@gmail.com>
472 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
473 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
474 Set here, not in nt/config.nt.
476 2012-07-13 Eli Zaretskii <eliz@gnu.org>
478 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
479 cursor overflow into the last glyph on display line when the right
480 fringe is off. (Bug#11832)
482 2012-07-13 Paul Eggert <eggert@cs.ucla.edu>
484 * xdisp.c (produce_special_glyphs): Now static.
485 * dispextern.h (produce_special_glyphs): Remove decl.
487 2012-07-13 Glenn Morris <rgm@gnu.org>
489 * s/bsd-common, s/cygwin.h: Remove empty files.
490 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
492 * s/usg5-4-common.h (USG, USG5):
493 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
494 * s/sol2-6.h (SOLARIS2):
495 * s/irix6-5.h (IRIX6_5):
496 * s/hpux10-20.h (USG, USG5, HPUX):
497 * s/gnu-linux.h (USG, GNU_LINUX):
498 * s/freebsd.h (BSD_SYSTEM):
499 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
500 * s/cygwin.h (CYGWIN):
501 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
502 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
504 2012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
506 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
508 2012-07-13 Glenn Morris <rgm@gnu.org>
510 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
512 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
514 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
515 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
517 2012-07-12 Glenn Morris <rgm@gnu.org>
519 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
521 * process.c (init_process_emacs): Rename from init_process.
522 The old name is also the name of a Mach system call.
523 * lisp.h, emacs.c: Update for this name change.
524 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
527 2012-07-12 Eli Zaretskii <eliz@gnu.org>
529 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
530 memmove call that removes glyphs covered by the left truncation
531 glyph. Improve commentary.
532 (display_line): Fix display of continuation glyphs on GUI frames
533 when the right fringe is turned off and variable-size fonts are
534 used in the window. Move the code that appends a stretch glyph to
535 produce_special_glyphs, so that it could be used for truncation
536 and continuation glyphs alike.
537 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
538 glyph of a suitably computed width, to align the special glyphs at
539 the window margin. Code moved from display_line. (Bug#11832)
541 2012-07-12 Glenn Morris <rgm@gnu.org>
543 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
545 * s/gnu-linux.h, s/hpux10-20.h:
546 Do not unconditionally define HAVE_XRMSETDATABASE.
548 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
550 2012-07-12 Paul Eggert <eggert@cs.ucla.edu>
552 Fix typos that broke OS X build.
553 Reported by Randal L. Schwartz in
554 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
555 * nsterm.m (ns_timeout): Add missing local decl.
556 (ns_get_color): snprintf -> sprintf, to fix typo.
558 2012-07-12 Glenn Morris <rgm@gnu.org>
560 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
561 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
562 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
563 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
565 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
566 Move PTY_OPEN to configure.
568 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
569 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
570 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
572 2012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
574 Use empty_unibyte_string where applicable.
575 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
576 * lread.c (read1): Likewise.
577 * xsettings.c (syms_of_xsettings): Likewise.
579 2012-07-12 Glenn Morris <rgm@gnu.org>
581 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
582 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
583 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
584 * s/hpux10-20.h (RUN_TIME_REMAP):
585 * s/bsd-common.h (TABDLY): Move to configure.
587 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
589 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
591 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
592 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
594 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
596 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
597 * s/template.h: Move NARROWPROTO to configure.
599 2012-07-11 Glenn Morris <rgm@gnu.org>
601 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
602 unused since 2011-01-17 change to systty.h.
604 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
605 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
606 Move HAVE_PTYS and HAVE_SOCKETS to configure.
608 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
610 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
612 2012-07-11 Glenn Morris <rgm@gnu.org>
614 * s/darwin.h, s/gnu-linux.h, s/template.h:
615 Move INTERRUPT_INPUT to configure.
617 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
619 Minor adjustments to interning code.
620 * lisp.h (intern, intern_c_string): Redefine as static inline
621 wrappers for intern_1 and intern_c_string_1, respectively.
622 (intern_1, intern_c_string_1): Rename prototypes.
623 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
625 * font.c (font_intern_prop): Likewise. Adjust comment.
626 * w32font.c (intern_font_name): Likewise.
628 2012-07-11 Andreas Schwab <schwab@linux-m68k.org>
630 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
632 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
633 of Fcar/Fcdr if possible.
634 * font.c (check_otf_features): Likewise.
635 * fontset.c (Fnew_fontset): Likewise.
636 * gnutls.c (Fgnutls_boot): Likewise.
637 * minibuf.c (read_minibuf): Likewise.
638 * msdos.c (IT_set_frame_parameters): Likewise.
639 * xmenu.c (Fx_popup_dialog): Likewise.
640 * w32menu.c (Fx_popup_dialog): Likewise.
642 2012-07-11 Glenn Morris <rgm@gnu.org>
644 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
645 since nothing has defined it on these platforms.
647 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
648 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
650 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
651 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
652 Move CLASH_DETECTION to configure.
654 * s/gnu.h: Remove file, which is now empty.
656 * s/gnu.h, s/gnu-linux.h:
657 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
659 2012-07-11 John Wiegley <johnw@newartisans.com>
661 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
662 function attribute, so we only use it if it exists in the
665 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
667 Avoid call to strlen in fast_c_string_match_ignore_case.
668 * search.c (fast_c_string_match_ignore_case): Change to use
669 length argument. Adjust users accordingly.
670 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
672 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
675 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
676 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
679 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
682 * s/hpux10-20.h (HAVE_PERROR): Remove.
683 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
684 Remove dummy definition, as this problem was obsolete long ago.
687 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
689 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
691 Avoid calls to strlen in font processing functions.
692 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
693 (font_open_by_name): Change to use length argument. Adjust
695 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
697 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
698 Change to return ptrdiff_t.
699 (xfont_list_pattern, xfont_match): Use length returned by
700 xfont_decode_coding_xlfd.
701 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
703 2012-07-11 Glenn Morris <rgm@gnu.org>
705 * s/darwin.h, s/freebsd.h, s/netbsd.h:
706 Move DONT_REOPEN_PTY to configure.
708 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
709 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
711 2012-07-10 Paul Eggert <eggert@cs.ucla.edu>
713 Remove "#define unix" that is no longer needed (Bug#11905).
714 * s/aix4-2.h (unix): Remove; no longer needed.
716 EMACS_TIME simplification (Bug#11875).
717 This replaces macros (which typically do not work in GDB)
718 with functions, typedefs and enums, making the code easier to debug.
719 The functional style also makes code easier to read and maintain.
720 * systime.h: Include <sys/time.h> on all hosts, not just if
721 WINDOWSNT, since 'struct timeval' is needed in general.
722 (EMACS_TIME): Now a typedef, not a macro.
723 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
725 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
726 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
727 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
728 (EMACS_TIME_LE): Now functions, not macros.
729 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
730 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
731 which are not functions. All uses rewritten to use:
732 (make_emacs_time): New function.
733 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
734 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
735 not functions. All uses rewritten to use the following, respectively:
736 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
737 (add_emacs_time, sub_emacs_time): New functions.
738 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
739 * fileio.c (Fcopy_file):
740 * xterm.c (XTflash): Get the current time closer to when it's used.
741 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
743 * bytecode.c (targets): Suppress -Woverride-init warnings.
745 Simplify by avoiding confusing use of strncpy etc.
746 * doc.c (Fsnarf_documentation):
747 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
748 * frame.c (Fmake_terminal_frame):
749 * gtkutil.c (get_utf8_string):
751 * nsmenu.m (ns_update_menubar):
752 * regex.c (regerror):
753 Prefer memcpy to strncpy and strncat when either will do.
754 * fileio.c (Fsubstitute_in_file_name):
755 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
756 (menu_separator_name_p):
757 * nsmenu.m (ns_update_menubar):
758 Prefer memcmp to strncmp when either will do.
759 * nsterm.m: Include <ftoastr.h>.
761 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
762 Prefer snprintf to strncpy.
763 * nsterm.m (ns_term_init):
764 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
765 * nsterm.m (ns_term_init):
766 Avoid the need for strncpy, by using build_string or
767 make_unibyte_string directly. Use dtoastr, not snprintf.
768 * process.c (Fmake_network_process): Diagnose service names that
769 are too long, rather than silently truncating them or creating
770 non-null-terminated names.
771 (Fnetwork_interface_info): Likewise, for interface names.
772 * sysdep.c (system_process_attributes) [GNU_LINUX]:
773 Prefer sprintf to strncat.
774 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
775 Prefer vsnprintf to vsprintf + strncpy.
777 2012-07-10 Glenn Morris <rgm@gnu.org>
779 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
780 Clarify fallback case.
782 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
784 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
785 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
786 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
787 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
788 where argument type is known to be a Lisp_Cons.
790 2012-07-10 Tom Tromey <tromey@redhat.com>
792 * bytecode.c (BYTE_CODE_THREADED): New macro.
793 (BYTE_CODES): New macro. Replaces all old byte-code defines.
794 (enum byte_code_op): New type.
795 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
796 (exec_byte_code): Use them. Use token threading when applicable.
798 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
800 Optimize pure C strings initialization.
801 * lisp.h (make_pure_string): Fix prototype.
802 (build_pure_c_string): New function, defined as static inline. This
803 provides a better opportunity to optimize away calls to strlen when
804 the function is called with compile-time constant argument.
805 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
806 argument, adjust users accordingly. Use build_pure_c_string where
808 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
809 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
810 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
812 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
814 Avoid calls to strlen in miscellaneous functions.
815 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
816 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
817 * lread.c (openp): Likewise.
819 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
821 Avoid calls to strlen in path processing functions.
822 * fileio.c (file_name_as_directory): Add comment. Change to add
823 srclen argument and return the length of result. Adjust users
825 (directory_file_name): Fix comment. Change to add srclen argument,
826 swap 1st and 2nd arguments to obey the common convention. Adjust
828 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
830 2012-07-10 Glenn Morris <rgm@gnu.org>
832 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
833 Move PENDING_OUTPUT_COUNT definition to configure.
835 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
836 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
837 * s/gnu.h (DATA_START): Move definitions to configure.
839 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
840 We include usg5-4-common.h, which defines them both.
842 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
843 O_RDONLY already includes it).
845 Stop ns builds setting the EMACSLOADPATH environment variable.
846 * nsterm.m (ns_load_path): Rename from ns_init_paths.
847 Now it does not set EMACSLOADPATH, just returns the load-path string.
848 * nsterm.h: Update accordingly.
849 * lread.c [HAVE_NS]: Include nsterm.h.
850 (init_lread) [HAVE_NS]: Use ns_load_path.
851 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
853 2012-07-09 Glenn Morris <rgm@gnu.org>
855 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
856 since the included bsd-common.h does so.
858 Stop ns builds setting the EMACSPATH environment variable.
859 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
860 (ns_init_paths): Do not set EMACSPATH.
861 * nsterm.h (ns_exec_path): Add it.
862 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
865 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
867 2012-07-09 Paul Eggert <eggert@cs.ucla.edu>
869 * process.c (wait_reading_process_output): 'waitchannels' was unset
870 when read_kbd || !NILP (wait_for_cell); fix this.
872 Add GCC-style 'const' attribute to functions that can use it.
873 * character.h (char_resolve_modifier_mask):
874 * keyboard.h (make_ctrl_char):
875 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
876 (init_character_once, next_almost_prime, init_fns, init_image)
877 (flush_pending_output, init_sound):
878 * mem-limits.h (start_of_data):
879 * menu.h (finish_menu_items):
881 * emacs.c (DEFINE_DUMMY_FUNCTION):
882 Declare the dummy function with ATTRIBUTE_CONST.
883 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
884 Add decls with ATTRIBUTE_CONST.
886 Minor improvements to make_formatted_string.
887 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
888 where int is good enough, as vsprintf returns an int.
889 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
891 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
893 Use make_formatted_string to avoid double length calculation.
894 * lisp.h (make_formatted_string): New prototype.
895 * alloc.c (make_formatted_string): New function.
896 * buffer.c (Fgenerate_new_buffer_name): Use it.
897 * dbus.c (syms_of_dbusbind): Likewise.
898 * editfns.c (Fcurrent_time_zone): Likewise.
899 * filelock.c (get_boot_time): Likewise.
900 * frame.c (make_terminal_frame, set_term_frame_name)
901 (x_report_frame_params): Likewise.
902 * image.c (gs_load): Likewise.
903 * minibuf.c (get_minibuffer): Likewise.
904 * msdos.c (dos_set_window_size): Likewise.
905 * process.c (make_process): Likewise.
906 * xdisp.c (ensure_echo_area_buffers): Likewise.
907 * xsettings.c (apply_xft_settings): Likewise.
909 2012-07-09 Glenn Morris <rgm@gnu.org>
911 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
912 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
913 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
914 * nsterm.h (ns_etc_directory): Add it.
915 * callproc.c [HAVE_NS]: Include nsterm.h.
916 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
918 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
920 Move marker debugging code under MARKER_DEBUG.
921 * marker.c (MARKER_DEBUG): Move marker debugging code under
922 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
923 for bootstrap with --enable-checking (~3x slowdown reported
924 by Juanma Barranquero <lekktu@gmail.com>).
925 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
927 2012-07-08 Paul Eggert <eggert@cs.ucla.edu>
929 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
930 See <http://bugs.gnu.org/11825#29>.
932 2012-07-08 Eli Zaretskii <eliz@gnu.org>
934 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
935 has no font, use the frame's font. (Bug#11813)
936 (display_line): Add commentary about displaying truncation glyphs
938 (produce_special_glyphs): Move here from term.c.
940 * term.c (produce_special_glyphs): Move to xdisp.c.
942 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
945 2012-07-07 Andreas Schwab <schwab@linux-m68k.org>
947 * xdisp.c (display_line): Avoid warning about implicit declaration
950 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
952 * lisp.h: Remove empty conditional.
954 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
956 * lread.c (load_path_check): Now static.
958 Fix some minor --with-ns problems found by static checking.
959 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
960 (x_set_font) [!HAVE_X_WINDOWS]:
961 * image.c (xpm_load_image) [HAVE_NS]:
962 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
963 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
965 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
966 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
967 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
968 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
969 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
970 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
971 Fix pointer signedness problem.
972 * xfaces.c (FRAME_X_FONT_TABLE):
973 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
975 2012-07-07 Glenn Morris <rgm@gnu.org>
977 * lread.c (load_path_check): New function, split from init_lread.
978 (init_lread): Reorganize. Motivation:
979 If EMACSLOADPATH is set, check/warn about that rather than the
980 defaults, which we are not going to use. Hence we can remove
981 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
982 Don't warn if site-lisp directories are missing.
983 If not installed, start from a blank load-path, since
984 PATH_LOADSEARCH refers to the eventual installation directories.
986 2012-07-07 Eli Zaretskii <eliz@gnu.org>
988 Support truncation and continuation glyphs on GUI frames, when
989 fringes are disabled. (Bug#11832)
990 * xdisp.c (init_iterator): Get dimensions of truncation and
991 continuation glyphs even if on GUI frames. Adjust
992 it->last_visible_x on GUI frames when the left or right fringes,
994 (start_display, move_it_in_display_line_to): Handle the case of a
995 GUI frame without a fringe to display continuation or truncation
997 (insert_left_trunc_glyphs): Support GUI frames: make sure
998 truncation glyphs overwrite enough glyphs from the current line to
999 have sufficient space in pixels.
1000 (display_line): Support truncation and continuation glyphs on GUI
1001 frames. If some spare pixels are left on the line after inserting
1002 the truncation glyphs, fill that space with a stretch glyph of a
1003 suitably computed width.
1005 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1006 produce_glyphs, to support GUI sessions.
1008 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1010 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1012 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1014 Do not require float-time's arg to fit in time_t (Bug#11825).
1015 This works better on hosts where time_t is unsigned, and where
1016 float-time is applied to the (negative) difference between two times.
1017 * editfns.c (decode_time_components): Last arg is now double *,
1018 not int *, and means to store all the result as a double, without
1019 worrying about whether the seconds part fits in time_t.
1020 All callers changed.
1021 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1022 All callers changed.
1023 (Ffloat_time): Do not fail merely because the specified time falls
1024 outside of time_t range.
1026 2012-07-07 Glenn Morris <rgm@gnu.org>
1028 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1029 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1030 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1032 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
1034 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1035 Update dependencies.
1037 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1039 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1041 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1042 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1043 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1044 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1045 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1046 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1048 * xfont.c (compare_font_names): Redo to omit the need for casts.
1050 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1052 * xfns.c (Fx_change_window_property): Doc fix.
1053 * w32fns.c (Fx_change_window_property): Doc fix.
1055 * w32fns.c (Fx_window_property): Accept the same arguments as the
1056 X Windows version. Doc fix.
1057 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1059 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
1060 Eli Zaretskii <eliz@gnu.org>
1062 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1063 Windows-specific code from nt/config.nt moved here.
1064 Obsolete settings removed.
1066 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1068 * process.c: Avoid unnecessary calls to gettime.
1069 (wait_reading_process_output): Don't get the time of day
1070 when gobbling data immediately and not waiting, as there's no need
1071 for it in that case. This removes a FIXME.
1073 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1075 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1076 is defined (Bug#11768).
1078 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1080 Fix marker debugging code.
1081 * marker.c (byte_char_debug_check): Do not perform the check
1082 if buffer is not multibyte.
1083 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1084 Call byte_char_debug_check with correct arguments.
1086 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1088 Compile marker debugging code only if ENABLE_CHECKING is defined.
1089 * marker.c (byte_char_debug_check, count_markers):
1090 Use only if ENABLE_CHECKING is defined.
1091 (byte_debug_flag): Remove.
1092 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1093 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1095 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1097 Avoid code repetition in marker-related functions.
1098 * marker.c (attach_marker): New function.
1099 (Fset_marker, set_marker_restricted, set_marker_both)
1100 (set_marker_restricted_both): Use it.
1101 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1102 Consistently rename charno to charpos.
1103 (marker_position): Add eassert.
1104 (marker_byte_position): Convert to eassert.
1106 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1108 Simplify list operations in unchain_overlay and unchain_marker.
1109 * buffer.c (unchain_overlay): Simplify. Add comment.
1110 * marker.c (unchain_marker): Simplify. Fix comments.
1112 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1114 Introduce fast path for the widely used marker operation.
1115 * alloc.c (build_marker): New function.
1116 * lisp.h (build_marker): New prototype.
1117 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1118 * composite.c (autocmp_chars): Likewise.
1119 * editfns.c (buildmark): Remove.
1120 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1121 (save_restriction_save): Use build_marker.
1122 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1123 * window.c (save_window_save): Likewise.
1125 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1127 Do not use Fdelete_overlay in delete_all_overlays
1128 to avoid redundant calls to unchain_overlay.
1129 * buffer.c (drop_overlay): New function.
1130 (delete_all_overlays, Fdelete_overlay): Use it.
1131 * minibuf.c (get_minibuffer): Fix comment.
1133 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1135 Port to OpenBSD 5.1 amd64.
1136 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1137 This is needed for OpenBSD, and should be harmless on all BSD systems.
1138 Also, include <sys/sysctl.h>, as it should be available on all
1139 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1140 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1141 use p_pid member, not kp_proc.pid.
1143 2012-07-06 Glenn Morris <rgm@gnu.org>
1145 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1147 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1149 More xmalloc and related cleanup.
1150 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1151 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1152 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1153 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1154 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1155 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1156 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1157 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1158 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1160 Omit needless casts involving void * pointers and allocation.
1161 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1162 as the former is more robust if P's type is changed.
1163 Prefer xzalloc to xmalloc + memset 0.
1164 Simplify malloc-or-realloc to realloc.
1165 Don't worry about xmalloc returning a null pointer.
1166 Prefer xstrdup to xmalloc + strcpy.
1167 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1169 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1170 alloca of a constant.
1172 2012-07-05 Eli Zaretskii <eliz@gnu.org>
1174 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1175 hscroll is larger than the line width. Fixes long and futile
1176 looping inside extend_face_to_end_of_line (on a TTY) producing
1177 glyphs that are not needed and thrown away.
1179 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1181 * marker.c (set_marker_restricted_both): Simplify by using
1184 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1186 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1188 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1190 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1191 not defined (Bug#11768).
1192 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1193 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1194 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1195 followed by gtk_box_set_homogeneous (Bug#11768).
1196 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
1197 (update_theme_scrollbar_width, xg_create_scroll_bar):
1198 Use gtk_scrollbar_new (Bug#11768).
1199 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1200 (is_box_type): New function (Bug#11768).
1201 (xg_tool_item_stale_p): Call is_box_type.
1202 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
1203 with default display (Bug#11768).
1205 2012-07-05 Eli Zaretskii <eliz@gnu.org>
1207 * xdisp.c (window_hscroll_limited): New function.
1208 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1209 coordinates when window's hscroll is set to insanely large
1212 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
1214 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1215 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1217 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1220 * lisp.h (xzalloc): New prototype. Omit needless casts.
1221 * alloc.c (xzalloc): New function. Omit needless casts.
1222 * charset.c: Omit needless casts. Convert all calls to
1223 xmalloc with following memset to xzalloc.
1224 * dispnew.c: Likewise.
1225 * fringe.c: Likewise.
1226 * image.c: Likewise.
1227 * sound.c: Likewise.
1229 * w32fns.c: Likewise.
1230 * w32font.c: Likewise.
1231 * w32term.c: Likewise.
1232 * xfaces.c: Likewise.
1234 * xterm.c: Likewise.
1235 * atimer.c: Omit needless casts.
1236 * buffer.c: Likewise.
1237 * callproc.c: Likewise.
1239 * coding.c: Likewise.
1240 * composite.c: Likewise.
1242 * doprnt.c: Likewise.
1243 * editfns.c: Likewise.
1244 * emacs.c: Likewise.
1246 * filelock.c: Likewise.
1248 * gtkutil.c: Likewise.
1249 * keyboard.c: Likewise.
1251 * lread.c: Likewise.
1252 * minibuf.c: Likewise.
1253 * msdos.c: Likewise.
1254 * print.c: Likewise.
1255 * process.c: Likewise.
1256 * region-cache.c: Likewise.
1257 * search.c: Likewise.
1258 * sysdep.c: Likewise.
1259 * termcap.c: Likewise.
1260 * terminal.c: Likewise.
1261 * tparam.c: Likewise.
1262 * w16select.c: Likewise.
1264 * w32reg.c: Likewise.
1265 * w32select.c: Likewise.
1266 * w32uniscribe.c: Likewise.
1267 * widget.c: Likewise.
1268 * xdisp.c: Likewise.
1269 * xmenu.c: Likewise.
1271 * xselect.c: Likewise.
1273 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1275 * fileio.c (time_error_value): Check the right error number.
1276 Problem reported by Troels Nielsen in
1277 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1279 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1281 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1282 This should be fixed in a better way; see Eli Zaretskii in
1283 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1284 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1286 * fileio.c (time_error_value): Rename from special_mtime.
1287 The old name's problems were noted by Eli Zaretskii in
1288 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1290 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1291 This variable's comment says Emacs needs at least one GDB-visible
1292 symbol of type enum pvec_type, to work around GDB problems.
1293 The symbol's value doesn't matter.
1295 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1296 that causes compilation to fail on pre-C99 compilers.
1298 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
1300 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1301 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1303 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1305 * buffer.c (init_buffer_once): Fix initialization of
1306 headers for buffer_defaults and buffer_local_symbols.
1307 Reported by Juanma Barranquero <lekktu@gmail.com>.
1309 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1311 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1312 * lisp.h (enum pvec_type): Use fewer bits.
1313 (PSEUDOVECTOR_SIZE_BITS): New constant.
1314 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1315 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1316 change in pvec_type.
1317 (PSEUDOVECTOR_TYPEP): New macro.
1318 (TYPED_PSEUDOVECTORP): Use it.
1319 * fns.c (internal_equal): Adapt code to extract pvectype.
1320 * emacs.c (gdb_pvec_type): Update type.
1321 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1322 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1323 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1324 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1325 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1326 abusing vector->header.next.nbytes.
1327 (live_vector_p): Use PVEC_TYPE.
1328 (mark_object): Adapt code to extract pvectype. Use switch.
1330 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1332 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1333 Tighten new eassert a bit.
1335 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1337 Fix compilation with --enable-gcc-warnings and -O1
1339 * doprnt.c (doprnt): Change type of tem to int, initialize
1340 to avoid compiler warning. Add eassert.
1341 * search.c (simple_search): Initialize match_byte to avoid
1342 compiler warning. Add eassert.
1344 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1346 Avoid weird behavior with large horizontal scrolls.
1347 Without this change, for example, large hscroll values would
1348 mess up Emacs's display on Fedora 15 x86, presumably due to
1349 overflows in int calculations in the display code.
1350 Also, if buffers had long lines, Emacs would freeze.
1351 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1352 (set_window_hscroll): New function, containing the old guts of
1353 Fset_window_hscroll. Return the clipped value.
1354 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1355 This avoids the need to check against PTRDIFF_MAX.
1357 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1359 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1361 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1363 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1365 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1366 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1367 since GCC 4.4.6 issues a bogus warning for them.
1369 Fix bugs in file timestamp newness comparisons.
1370 * fileio.c (Ffile_newer_than_file_p):
1371 * lread.c (Fload): Use full timestamp resolution of files,
1372 not just the 1-second resolution, so that files that are only
1373 slightly newer still count as newer.
1374 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1375 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1377 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1379 * fileio.c: Improve handling of file time marker. (Bug#11852)
1380 (special_mtime): New function.
1381 (Finsert_file_contents, Fverify_visited_file_modtime):
1382 Use it to set special mtime values consistently.
1384 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1386 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1387 marker for non-existing file. (Bug#11852)
1389 2012-07-03 Glenn Morris <rgm@gnu.org>
1391 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1392 and did not make it into globals.h).
1394 2012-07-03 Tom Tromey <tromey@redhat.com>
1396 * window.c (Fset_window_margins, Fset_window_fringes)
1397 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1398 * textprop.c (Fprevious_property_change): No longer static.
1399 * syntax.c (Fsyntax_table_p): No longer static.
1400 * process.c (Fget_process, Fprocess_datagram_address): No longer
1402 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1403 * keyboard.c (Fcommand_execute): No longer static.
1405 * insdel.c (Fcombine_after_change_execute): No longer static.
1406 * image.c (Finit_image_library): No longer static.
1407 * fileio.c (Fmake_symbolic_link): No longer static.
1408 * eval.c (Ffetch_bytecode): No longer static.
1409 * editfns.c (Fuser_full_name): No longer static.
1410 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1412 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1414 * dired.c (Ffile_attributes): No longer static.
1415 * composite.c (Fcomposition_get_gstring): No longer static.
1416 * callproc.c (Fgetenv_internal): No longer static.
1418 * ccl.h: Remove EXFUNs.
1419 * buffer.h: Remove EXFUNs.
1420 * dispextern.h: Remove EXFUNs.
1421 * intervals.h: Remove EXFUNs.
1422 * fontset.h: Remove EXFUN.
1423 * font.h: Remove EXFUNs.
1424 * dosfns.c (system_process_attributes): Remove EXFUN.
1425 * keymap.h: Remove EXFUNs.
1426 * lisp.h: Remove EXFUNs.
1427 * w32term.h: Remove EXFUNs.
1428 * window.h: Remove EXFUNs.
1429 * xsettings.h: Remove EXFUN.
1430 * xterm.h: Remove EXFUN.
1432 2012-07-03 Glenn Morris <rgm@gnu.org>
1434 * lisp.h (Frandom): Make it visible to C.
1435 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1436 buffer for invisible buffers. (Bug#1229)
1438 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1440 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1441 values which aren't power of 2.
1442 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1443 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1446 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1448 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1450 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1452 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1454 * alloc.c (allocate_vector_block): Remove redundant
1455 calls to mallopt if DOUG_LEA_MALLOC is defined.
1456 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1457 avoid calls to mallopt if zero_vector is returned.
1459 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1461 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1462 is enabled, avoid dereferencing NULL current_sblock if
1465 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1467 Cleanup basic buffer management.
1468 * buffer.h (struct buffer): Change layout to use generic vector
1469 marking code. Fix some comments. Change type of 'clip_changed'
1470 to bitfield. Remove unused #ifndef old.
1471 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1472 (GET_OVERLAYS_AT): Fix indentation.
1473 (for_each_per_buffer_object_at): New macro.
1474 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1475 (Fbuffer_local_variables): Use it.
1476 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1477 * alloc.c (allocate_buffer): Adjust to match new layout of
1478 struct buffer. Fix comment.
1479 (mark_overlay): New function.
1480 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1481 Lisp area of struct buffer.
1482 (mark_object): Use it. Adjust marking of misc objects
1483 and related comments.
1485 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1487 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1488 wrapper that is not needed because the wrapped code is a no-op (zero
1489 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1490 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1492 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1494 * alloc.c (mark_buffer): Simplify. Remove prototype.
1495 (mark_object): Add comment. Reorganize marking of vector-like
1496 objects. Use CHECK_LIVE for all vector-like objects except buffers
1497 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1498 redundant calls to mark_vectorlike for bool vectors.
1500 2012-06-30 Glenn Morris <rgm@gnu.org>
1502 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1504 * epaths.in (PATH_SITELOADSEARCH): New.
1505 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1506 This is rather than relying on --enable-locallisppath elements
1507 having "site-lisp" in their names. (Bug#10208#25, 11658)
1509 2012-06-30 Eli Zaretskii <eliz@gnu.org>
1511 * w32proc.c (sys_select): Accept and ignore one more argument.
1513 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1515 * sysselect.h [DOS_NT]: Don't include sys/select.h.
1516 (pselect) [!MS_DOS]: Redirect to sys_select.
1518 * sysdep.c: Don't include dos.h and dosfns.h.
1520 * process.c (sys_select):
1521 * msdos.c (sys_select): Accept one more argument and ignore it.
1523 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1524 adapt data types and code to that.
1527 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1528 which clashes with the gnulib function of the same name.
1530 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1532 * font.c (font_style_to_value, font_style_symbolic)
1533 (font_prop_validate_style): Add type checks for values in
1536 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1538 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1541 2012-06-29 Eli Zaretskii <eliz@gnu.org>
1543 * xdisp.c (try_window_id): Undo last change.
1545 * w32.c (getwd): Adjust commentary about startup_dir.
1546 (init_environment): Always call sys_access, even in non-MSVC
1547 builds. Don't chdir to the directory of the Emacs executable.
1548 This undoes code from 1997 which was justified by the need to
1549 "avoid conflicts when removing and renaming directories". But its
1550 downside was that every relative file name was being interpreted
1551 relative to the directory of the Emacs executable, which can never
1552 be TRT. In particular, it broke sys_access when called with
1553 relative file names.
1554 (sys_access): Map GetLastError to errno.
1556 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1558 * window.h (struct window): Change type of 'fringes_outside_margins'
1559 to bitfield. Fix comment. Adjust users accordingly.
1560 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
1562 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1565 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
1567 * gnutls.c (emacs_gnutls_handshake):
1568 Add QUIT to make the loop interruptible.
1570 2012-06-29 Glenn Morris <rgm@gnu.org>
1572 * charset.c (init_charset): Make lack of etc/charsets fatal.
1574 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1576 * editfns.c (region_limit): Fix type mismatch.
1578 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1580 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1581 undefined. Convert from xassert to eassert.
1582 * nsmenu.m: Convert from xassert to eassert.
1583 * nsterm.m: Likewise.
1585 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1587 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1589 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1591 Avoid integer overflow on scroll-left and scroll-right.
1592 * window.c (HSCROLL_MAX): New macro.
1593 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1594 overflow when requested scroll falls outside ptrdiff_t range.
1596 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1598 * window.h (struct window): Change type of 'hscroll',
1599 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1600 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1601 Adjust users accordingly.
1602 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1603 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1604 from EMACS_INT to ptrdiff_t.
1605 (make_window): Omit redundant initialization.
1607 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
1609 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1611 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1613 * window.h (struct window): Change type of 'use_time' and
1614 'sequence_number' from Lisp_Object to int.
1615 * frame.c (make_frame): Adjust users accordingly.
1616 * print.c (print_object): Likewise.
1617 * window.c (select_window, Fwindow_use_time, make_parent_window)
1618 (make_window): Likewise.
1620 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1622 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1623 enabled with --enable-checking=[all,glyphs] configure option.
1624 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1625 adjust comments accordingly.
1626 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1627 undefined, adjust comments accordingly.
1628 * image.c: Likewise.
1629 * scroll.c: Likewise.
1630 * w32fns.c: Likewise.
1631 * w32term.c: Likewise.
1632 * xdisp.c: Likewise.
1633 * xfaces.c: Likewise.
1635 * xterm.c: Likewise.
1637 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1639 Generalize run-time debugging checks.
1640 * dispextern.h (XASSERTS): Remove.
1641 * fontset.c (xassert): Remove.
1642 Convert from xassert to eassert.
1643 * alloc.c: Convert from xassert to eassert.
1645 * dispnew.c: Likewise.
1647 * fringe.c: Likewise.
1648 * ftfont.c: Likewise.
1649 * gtkutil.c: Likewise.
1650 * image.c: Likewise.
1651 * keyboard.c: Likewise.
1653 * process.c: Likewise.
1654 * scroll.c: Likewise.
1655 * sound.c: Likewise.
1657 * w32console.c: Likewise.
1658 * w32fns.c: Likewise.
1659 * w32term.c: Likewise.
1660 * window.c: Likewise.
1661 * xdisp.c: Likewise.
1662 * xfaces.c: Likewise.
1664 * xselect.c: Likewise.
1665 * xterm.c: Likewise.
1667 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1669 * fns.c (maybe_resize_hash_table): Output message when growing the
1672 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1674 * alloc.c (allocate_string_data): Remove dead code.
1675 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1676 avoid GCC warning about unused macro.
1678 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1680 * alloc.c (allocate_string): Omit intervals initialization.
1681 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1682 as in make_pure_string and make_pure_c_string.
1684 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1686 * alloc.c (allocate_string): Fix last change.
1688 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1690 * alloc.c (allocate_string): Remove two redundant calls
1691 to memset, add explicit initialization where appropriate.
1693 2012-06-27 Glenn Morris <rgm@gnu.org>
1695 * lisp.mk (lisp): Remove paths.elc.
1697 2012-06-27 Chong Yidong <cyd@gnu.org>
1699 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1701 2012-06-26 John Wiegley <johnw@newartisans.com>
1703 * unexmacosx.c (copy_data_segment): Add two section names used
1704 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1706 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1707 when building with Clang.
1709 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1711 * eval.c (Fapply): Allow calling it with a single argument.
1713 2012-06-26 Eli Zaretskii <eliz@gnu.org>
1715 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1716 _stricmp and _strnicmp.
1717 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1719 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1721 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1723 (allocate_process): Likewise for new process.
1724 (allocate_terminal): Change to use offsetof.
1725 (allocate_frame): Likewise.
1726 * frame.c (make_frame): Omit redundant initialization.
1727 * window.c (make_parent_window): Use memset.
1728 (make_window): Omit redundant initialization.
1729 * process.c (make_process): Omit redundant initialization.
1730 * terminal.c (create_terminal): Likewise.
1732 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1734 * term.c (delete_tty): Remove redundant call to memset.
1736 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1738 * alloc.c: Remove build_string.
1739 * lisp.h: Define build_string as static inline. This provides
1740 a better opportunity to optimize away calls to strlen when the
1741 function is called with compile-time constant argument.
1742 * image.c (imagemagick_error): Convert to build_string.
1743 * w32proc.c (sys_spawnve): Likewise.
1744 * xterm.c (x_term_init): Likewise.
1746 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1748 Use sprintf return value instead of invoking strlen on result.
1749 In the old days this wasn't portable, since some sprintf
1750 implementations returned char *. But they died out years ago and
1751 Emacs already assumes sprintf returns int.
1752 Similarly for float_to_string.
1753 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1754 * ccl.c (ccl_driver):
1755 * character.c (string_escape_byte8):
1756 * data.c (Fnumber_to_string):
1757 * doprnt.c (doprnt):
1758 * print.c (print_object):
1759 * xdisp.c (message_dolog):
1760 * xfns.c (syms_of_xfns):
1761 Use sprintf or float_to_string result to avoid need to call strlen.
1762 * data.c (Fnumber_to_string):
1763 Use make_unibyte_string, since the string must be ASCII.
1764 * lisp.h, print.c (float_to_string): Now returns int length.
1765 * term.c (produce_glyphless_glyph):
1766 Use sprintf result rather than recomputing it.
1768 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1769 * Makefile.in (ALL_CFLAGS):
1770 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1771 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1773 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1775 * dispextern.h (xstrcasecmp): Define to library function
1776 strcasecmp if available.
1777 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1779 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1781 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1782 Avoid comma operator.
1783 * menu.c (push_submenu_start, push_submenu_end)
1784 (push_left_right_boundary, push_menu_pane): Likewise.
1785 * msdos.c (dos_rawgetc): Likewise.
1787 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1789 * xfns.c (xic_create_fontsetname): Remove redundant calls
1792 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1794 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1795 sprintf already null-terminates its output.
1797 * xfns.c (x_window): Remove redundant cast.
1799 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1801 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1802 `const char *' to `char *' to avoid compiler warning.
1804 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1806 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1807 instead of truncating it to 63 (admittedly a generous limit).
1809 * process.c: Fix spelling and caps in comments.
1811 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1813 * emacs.c (setpgrp): Remove definition, unused.
1814 * sysdep.c (setpgrp): Remove definition, not used in this file.
1816 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
1818 * makefile.w32-in: Update dependencies.
1820 2012-06-24 Eli Zaretskii <eliz@gnu.org>
1822 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1823 (SYSTIME_H): Add nt/inc/sys/time.h.
1825 * systime.h [WINDOWSNT]: Include sys/time.h.
1827 * s/ms-w32.h (struct timespec): Definition moved from
1828 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1830 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1832 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1833 * buffer.h (buffer_slot_type_mismatch):
1834 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1835 * eval.c (unwind_to_catch):
1836 * image.c (my_png_error, my_error_exit):
1837 * keyboard.c (quit_throw_to_read_char, user_error)
1838 (Fexit_recursive_edit, Fabort_recursive_edit):
1839 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1840 (wrong_type_argument, buffer_overflow, __executable_start)
1841 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1842 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1843 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1845 (child_setup) [!DOS_NT]:
1846 * lread.c (end_of_file_error, invalid_syntax):
1847 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1848 * puresize.h (pure_write_error):
1849 * search.c (matcher_overflow):
1850 * sound.c (sound_perror, alsa_sound_perror):
1851 * sysdep.c, syssignal.h (croak):
1852 * term.c (maybe_fatal, vfatal):
1853 * textprop.c (text_read_only):
1854 * undo.c (user_error):
1855 * unexmacosx.c (unexec_error):
1856 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1857 Use _Noreturn rather than NO_RETURN.
1858 No need for separate decl merely because of _Noreturn.
1859 * sound.c (sound_warning, parse_sound):
1860 Remove unnecessary forward decls.
1862 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1864 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1865 * lisp.h (WAIT_READING_MAX): New macro.
1866 * dispnew.c (Fsleep_for, sit_for):
1867 * keyboard.c (kbd_buffer_get_event):
1868 * process.c (Faccept_process_output):
1869 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1870 This improves on the previous patch, which introduced a bug
1871 when time_t is unsigned and as wide as intmax_t.
1872 See <http://bugs.gnu.org/9000#51>.
1874 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1876 * dispnew.c (sit_for, Fsleep_for):
1877 * keyboard.c (kbd_buffer_get_event):
1878 * process.c (Faccept_process_output): Avoid compiler warnings when
1879 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1881 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
1883 * makefile.w32-in: Update dependencies.
1885 * w32.c (ltime): Add return type and declare static.
1886 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1888 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1890 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1891 Privately reported by Herbert J. Skuhra.
1892 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1894 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1895 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1897 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1899 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1900 last argument of make_unibyte_string.
1902 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1903 language ID in the event parameters.
1905 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1906 event.code, not the obscure "character set ID".
1908 2012-06-23 Chong Yidong <cyd@gnu.org>
1910 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1912 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1914 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1915 * w32.c (fdutimens): New function.
1917 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1919 * s/ms-w32.h (pselect): Redirect to sys_select.
1921 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1923 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1924 in the logic of incrementing and decrementing the value of
1925 use_relocatable_buffers.
1927 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1929 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1930 Privately reported by Herbert J. Skuhra.
1931 [__FreeBSD__]: Remove "*/" typo after "#include".
1932 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1933 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1934 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1935 Don't assume EMACS_TIME and struct timeval are the same type.
1937 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1939 Support higher-resolution time stamps (Bug#9000).
1940 The time stamps are only nanosecond-resolution at the C level,
1941 since that's the best that any real-world system supports now.
1942 But they are picosecond-resolution at the Lisp level, as that's
1943 easy, and leaves room for future OS improvements.
1945 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1948 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1949 Don't get current time unless it's needed.
1951 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1952 now provides it if it's absent.
1953 (start_atimer): Port to higher-res time stamps.
1954 Check for time stamp overflow. Don't get current time more
1955 often than is needed.
1957 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1958 Include systime.h, not time.h.
1959 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1961 * dired.c: Include stat-time.h.
1962 (Ffile-attributes): File times now have higher resolution.
1964 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1965 (struct image): Timestamp now has higher resolution.
1967 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1968 has at least microseconds now. All uses removed.
1969 (update_frame, update_single_window, update_window, update_frame_1)
1970 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1972 * editfns.c (time_overflow): Now extern.
1973 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1974 (float-time, Fformat_time_string, Fcurrent_time_string)
1975 (Fcurrent_time_zone): Accept and generate higher-resolution
1977 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1978 (decode_time_components, lisp_seconds_argument): New functions.
1979 (make_time): Now static.
1980 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1981 Report an error if the time is invalid, rather than having the caller
1984 * fileio.c: Include <stat-time.h>
1985 (Fcopy_file): Copy higher-resolution time stamps.
1986 Prefer to set the time stamp via a file descriptor if that works.
1987 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1988 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1989 (Fvisited_file_modtime, Fset_visited_file_modtime):
1990 Support higher-resolution time stamps.
1992 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1994 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1996 * image.c (prepare_image_for_display, clear_image_cache)
1997 (lookup_image): Port to higer-resolution time stamps.
1999 * keyboard.c (start_polling, bind_polling_period):
2000 Check for time stamp overflow.
2001 (read_char, kbd_buffer_get_event, timer_start_idle)
2002 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2003 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2004 Port to higher-resolution time stamps. Do not assume time_t is signed.
2005 (decode_timer): New function. Timers are now vectors of length 9,
2006 not 8, to accommodate the picosecond component.
2007 (timer_check_2): Use it.
2009 * nsterm.m (select_timeout, timeval_subtract): Remove.
2010 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2011 as they're a bit more accurate and handle overflow better.
2012 (ns_select): Change prototype to be compatible with pselect.
2013 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2014 * nsterm.h (ns_select): Adjust prototype.
2016 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2017 us-resolution time stamps.
2018 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2020 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2022 * lisp.h (time_overflow): New decl.
2023 (wait_reading_process_output): First arg is now intmax_t, not int,
2024 to accommodate larger waits.
2026 * process.h (struct Lisp_Process.read_output_delay):
2027 Now counts nanoseconds, not microseconds.
2028 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2030 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2031 (wait_reading_process_output):
2032 Port to ns-resolution time stamps.
2033 (Faccept_process_output, wait_reading_process_output):
2034 Check for time stamp overflow. Do not assume time_t is signed.
2035 (select_wrapper): Remove; we now use pselect.
2036 (Fprocess_attributes): Now generates ns-resolution time stamps.
2038 * sysdep.c: Include utimens.h. Don't include utime.h
2039 or worry about struct utimbuf; gnulib does that for us now.
2040 (gettimeofday): Remove; gnulib provides a substitute.
2041 (make_timeval): New function.
2042 (set_file_times): Now sets ns-resolution time stamps.
2043 New arg FD; all uses changed.
2044 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2045 (system_process_attributes):
2046 Now returns ns-resolution time stamp. All uses changed.
2047 Check for time stamp overflow.
2049 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2050 provides a substitute now.
2052 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2053 since it guarantees struct timespec.
2054 (EMACS_TIME): Now struct timespec, so that we can support
2055 ns-resolution time stamps.
2056 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2057 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2058 (EMACS_USECS): Remove.
2059 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2060 so multiply the arg by 1000 before storing it.
2061 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2063 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2064 Port to ns-resolution time stamps.
2065 (EMACS_TIME_NEG_P): Remove; replaced by....
2066 (EMACS_TIME_SIGN): New macro.
2067 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2068 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2069 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2070 (make_timeval, make_lisp_time, decode_time_components): New decls.
2071 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2072 that it mishandled time_t overflow. You can't compare by subtracting!
2073 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2074 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2076 * term.c: Include <sys/time.h>.
2077 (timeval_to_Time): New function, for proper overflow wraparound.
2078 (term_mouse_position, term_mouse_click): Use it.
2080 * undo.c (record_first_change): Support higher-resolution time stamps
2082 (Fprimitive_undo): Use them when restoring time stamps.
2084 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2085 (w32_get_internal_run_time):
2086 Port to higher-resolution Emacs time stamps.
2087 (ltime): Now accepts single 64-bit integer, as that's more convenient
2090 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2092 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2093 for compatibility with pselect. Support ns-resolution time stamps.
2095 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2097 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2098 Check for time stamp overflow, and support ns-resolution time stamps.
2100 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2101 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2102 (timeval_subtract): Remove; no longer needed.
2103 (XTflash, XTring_bell, x_wait_for_event):
2104 Port to ns-resolution time stamps. Don't assume time_t is signed.
2106 2012-06-22 Chong Yidong <cyd@gnu.org>
2108 * xdisp.c (x_consider_frame_title): Revert last change.
2110 2012-06-22 Eli Zaretskii <eliz@gnu.org>
2112 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2113 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2114 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2115 staticidx goes up to 1597 out of 1600 = 0x640.)
2117 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2119 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2120 Otherwise, the umask might be mistakenly 0 while handling input signals.
2122 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2124 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2126 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2128 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2129 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2130 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2131 access to `contents' member of Lisp_Vector objects with AREF and ASET
2134 2012-06-19 Chong Yidong <cyd@gnu.org>
2136 * frame.c (delete_frame): When selecting a frame on a different
2137 text terminal, do not alter the terminal's top-frame.
2139 * xdisp.c (format_mode_line_unwind_data): Record the target
2140 frame's selected window and its terminal's top-frame.
2141 (unwind_format_mode_line): Restore them.
2142 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2144 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2145 since tty frames can be explicitly named.
2146 (prepare_menu_bars): Likewise.
2148 * term.c (Ftty_top_frame): New function.
2150 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2152 Port byte-code-meter to modern targets.
2153 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2154 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
2155 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
2156 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2157 (METER_1, METER_2): Simplify.
2159 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2161 * data.c (Fdefalias): Return `symbol' (bug#11686).
2163 2012-06-18 Martin Rudalics <rudalics@gmx.at>
2165 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
2166 gets killed during executing of this function (Bug#11665).
2167 Try to always return Qt when the buffer has been actually killed.
2168 (Vkill_buffer_query_functions): In doc-string say that functions
2169 run by this hook should not change the current buffer.
2171 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2173 Fix recently-introduced process.c problems found by static checking.
2174 * process.c (write_queue_push, write_queue_pop, send_process):
2175 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2176 (write_queue_pop): Fix pointer signedness problem.
2177 (send_process): Remove unused local.
2179 2012-06-17 Chong Yidong <cyd@gnu.org>
2181 * xdisp.c (redisplay_internal): No need to redisplay terminal
2182 frames that are not on top.
2184 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
2186 * process.c (make_process): Initialize write_queue.
2187 (write_queue_push, write_queue_pop): New functions.
2188 (send_process): Use them to maintain correct ordering of process
2191 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2193 * lisp.h (eassert): Assume C89 or later.
2194 This removes the need for CHECK.
2195 (CHECK): Remove. Its comments about always evaluating its
2196 argument were confusing, as 'eassert' typically does not evaluate
2199 * coding.c (produce_chars): Use ptrdiff_t, not int.
2201 * xterm.c (x_draw_underwave): Check for integer overflow.
2202 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2204 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
2206 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2207 referenced (Bug#11583).
2209 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2211 Implement wave-style variant of underlining.
2212 * dispextern.h (face_underline_type): New enum.
2213 (face): Add field for underline type.
2214 * nsterm.m (ns_draw_underwave): New function.
2215 (ns_draw_text_decoration): Use it.
2216 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2218 (x_draw_glyph_string): Use them.
2219 * xfaces.c (Qline, Qwave): New Lisp objects.
2220 (check_lface_attrs, merge_face_ref)
2221 (Finternal_set_lisp_face_attribute, realize_x_face):
2222 Handle wave-style underline face attributes.
2223 * xterm.c (x_draw_underwave): New function.
2224 (x_draw_glyph_string): Use it.
2226 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
2228 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2229 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2230 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2231 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2232 ($(BLD)/w32select.$(O)): Update dependencies.
2234 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2236 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2237 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2238 * character.c (_fetch_multibyte_char_p): Remove.
2239 * alloc.c: Include "character.h" before "buffer.h".
2241 * buffer.c: Likewise.
2242 * bytecode.c: Likewise.
2243 * callint.c: Likewise.
2244 * callproc.c: Likewise.
2245 * casefiddle.c: Likewise.
2246 * casetab.c: Likewise.
2247 * category.c: Likewise.
2249 * coding.c: Likewise.
2250 * composite.c: Likewise.
2251 * dired.c: Likewise.
2252 * dispnew.c: Likewise.
2254 * dosfns.c: Likewise.
2255 * editfns.c: Likewise.
2256 * emacs.c: Likewise.
2257 * fileio.c: Likewise.
2258 * filelock.c: Likewise.
2260 * fontset.c: Likewise.
2261 * fringe.c: Likewise.
2262 * indent.c: Likewise.
2263 * insdel.c: Likewise.
2264 * intervals.c: Likewise.
2265 * keyboard.c: Likewise.
2266 * keymap.c: Likewise.
2267 * lread.c: Likewise.
2268 * macros.c: Likewise.
2269 * marker.c: Likewise.
2270 * minibuf.c: Likewise.
2271 * nsfns.m: Likewise.
2272 * nsmenu.m: Likewise.
2273 * print.c: Likewise.
2274 * process.c: Likewise.
2275 * regex.c: Likewise.
2276 * region-cache.c: Likewise.
2277 * search.c: Likewise.
2278 * syntax.c: Likewise.
2280 * textprop.c: Likewise.
2282 * unexsol.c: Likewise.
2283 * w16select.c: Likewise.
2284 * w32fns.c: Likewise.
2285 * w32menu.c: Likewise.
2286 * window.c: Likewise.
2287 * xdisp.c: Likewise.
2289 * xmenu.c: Likewise.
2291 * xselect.c: Likewise.
2293 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2295 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2296 If all the glyphs of the glyph row came from strings, and we have no
2297 cursor positioning clues, put the cursor on the first glyph of the
2299 (handle_face_prop): Use chunk-relative overlay string index when
2300 indexing into it->string_overlays array. (Bug#11653)
2301 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2302 the rightmost. (Bug#11720)
2304 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2306 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2307 (CATEGORY_MEMBER): Enforce 1/0 value.
2308 * category.c (_temp_category_set): Remove.
2310 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2312 * window.c (Fdelete_other_windows_internal)
2313 (Fdelete_window_internal): Don't access frame's mouse highlight
2314 info of the initial frame. (Bug#11677)
2316 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2318 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2319 Assume USE_2_TAGS_FOR_INTS.
2320 (xreload): Adjust $tagmask width to match recent lisp.h change.
2322 Simplify lisp.h in minor ways that should not affect code.
2323 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2324 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2325 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2326 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2327 (INTTYPEBITS): New macro, for clarity.
2328 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
2329 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2330 Simplify now that USE_LSB_TAG is always defined.
2331 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2332 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2334 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
2336 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2338 2012-06-13 Glenn Morris <rgm@gnu.org>
2340 * s/bsd-common.h (BSD4_3):
2341 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2343 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2345 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2348 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2350 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
2351 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
2352 * alloc.c (widen_to_Lisp_Object): Remove.
2353 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2354 * frame.c (delete_frame): Remove outdated comment.
2355 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2356 USE_LISP_UNION_TYPE.
2357 (Fw32_unregister_hot_key): Likewise.
2358 (Fw32_toggle_lock_key): Likewise.
2359 * w32menu.c (add_menu_item): Likewise.
2360 (w32_menu_display_help): Use XIL instead of checking
2361 USE_LISP_UNION_TYPE.
2362 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2363 (init_heap): Likewise.
2364 * w32term.c (w32_read_socket): Update comment.
2366 2012-06-13 Glenn Morris <rgm@gnu.org>
2368 * s/usg5-4-common.h, src/s/unixware.h:
2369 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2371 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2373 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2375 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2376 * alloc.c (make_number) [!defined make_number]:
2377 Remove, as lisp.h always defines this now.
2378 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2379 (roundup_size): Verify that it is a power of 2.
2380 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2381 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2382 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2383 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2384 USE_LSB_TAG now is always defined to be either 0 or 1.
2386 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2387 code works fine either way, and efficiency is not a concern here,
2388 as the union type is for debugging, not for production.
2389 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2390 Use an inline function on all platforms when using the union type,
2391 since this is simpler and 'static inline' can be used portably
2393 (LISP_INITIALLY_ZERO): New macro.
2394 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2395 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2397 2012-06-12 Glenn Morris <rgm@gnu.org>
2399 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2401 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
2403 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2404 Move BROKEN_SIGIO to configure.
2406 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2407 Move NO_TERMIO to configure.
2409 2012-06-12 Chong Yidong <cyd@gnu.org>
2411 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2412 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2413 MagickExportImagePixels is undefined.
2415 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2417 * image.c (imagemagick_load_image): Remove unused label.
2419 2012-06-11 Glenn Morris <rgm@gnu.org>
2421 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2422 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2423 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2424 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2426 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2428 * alloc.c (make_byte_code): New function.
2429 (Fmake_byte_code): Use it. Don't purify here.
2430 * lread.c (read1): Use it as well to avoid extra allocation.
2432 2012-06-11 Chong Yidong <cyd@gnu.org>
2434 * image.c (imagemagick_load_image): Implement transparency.
2436 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2438 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2439 account for preceding backslashes. (Bug#11663)
2441 2012-06-09 Chong Yidong <cyd@gnu.org>
2443 * term.c: Support italics in capable terminals (Bug#9652).
2444 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2445 (turn_on_face): Output using TS_enter_italic_mode if available.
2446 Don't handle unused blinking and alt-charset cases.
2447 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2448 and tty_alt_charset_p cases.
2449 (tty_capable_p, init_tty): Support italics.
2451 * termchar.h (struct tty_display_info): Add field for italics.
2452 Remove unused blink field.
2454 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2457 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2458 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2459 tty_alt_charset_p. Add tty_italic_p.
2461 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
2463 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2464 dbus_type_is_basic if available.
2465 (xd_extract_signed, xd_extract_unsigned): Rename from
2466 extract_signed and extract_unsigned, respectively. Adapt callers.
2468 2012-06-09 Chong Yidong <cyd@gnu.org>
2470 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2472 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2475 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2477 * xdisp.c (vmessage): Treat frame message as multibyte.
2478 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2479 would generate the diagnostic "Making \302\247 buffer-local while
2482 2012-06-08 Eli Zaretskii <eliz@gnu.org>
2484 * dispnew.c (showing_window_margins_p): Undo last change, which
2485 was done due to an inadvertent commit.
2486 (adjust_frame_glyphs_for_frame_redisplay): Do call
2487 showing_window_margins_p.
2489 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2491 * eval.c (Fmake_var_non_special): New primitive.
2492 (syms_of_eval): Defsubr it.
2493 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2495 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
2497 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2498 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2500 2012-06-08 Eli Zaretskii <eliz@gnu.org>
2502 * alloc.c (allocate_vectorlike): Fix last change.
2504 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2506 Block-based vector allocation of small vectors.
2507 * lisp.h (struct vectorlike_header): New field `nbytes',
2508 adjust comment accordingly.
2509 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2510 to denote vector blocks. Adjust users (live_vector_p,
2511 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2512 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2513 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2514 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2515 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2516 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2517 (roundup_size): New constant.
2518 (struct vector_block): New data type.
2519 (vector_blocks, vector_free_lists, zero_vector): New variables.
2520 (all_vectors): Rename to `large_vectors'.
2521 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2522 (sweep_vectors): New functions.
2523 (allocate_vectorlike): Return `zero_vector' as the only vector of
2524 0 items. Allocate new vector from block if vector size is less than
2525 or equal to VBLOCK_BYTES_MAX.
2526 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2527 (init_alloc_once): Add call to init_vectors.
2529 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2531 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2533 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2535 * doprnt.c (doprnt): Truncate multibyte char correctly.
2536 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2537 would mishandle a string argument "Xc" if X was a multibyte
2538 character of length 2: it would truncate after X's first byte
2539 rather than including all of X.
2541 2012-06-06 Chong Yidong <cyd@gnu.org>
2543 * buffer.c (word_wrap): Doc fix.
2545 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2547 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2549 2012-06-03 Glenn Morris <rgm@gnu.org>
2551 * xdisp.c (tool-bar-style): Doc fix.
2553 2012-06-03 Ulrich Müller <ulm@gentoo.org>
2555 * Makefile.in (PAXCTL): Define.
2556 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2557 binary via PaX flags if the paxctl utility is available.
2558 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2559 Restore PaX flags to their default. (Bug#11398)
2561 2012-06-03 Chong Yidong <cyd@gnu.org>
2563 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2566 2012-06-03 Chong Yidong <cyd@gnu.org>
2568 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2569 (note_mode_line_or_margin_highlight): If there is no help echo,
2570 use mode-line-default-help-echo. Handle the case where the mouse
2571 position is past the end of the mode line string.
2573 * buffer.c (buffer_local_value_1): New function, split from
2574 Fbuffer_local_value; can return Qunbound.
2575 (Fbuffer_local_value): Use it.
2576 (Vmode_line_format): Docstring tweaks.
2578 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2580 * sysdep.c (system_process_attributes): Improve comment.
2582 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2584 * keyboard.c: Export real-this-command to Elisp.
2585 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2586 and DEFVAR it. Update all users.
2588 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2590 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2592 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2593 Convert pctcpu and pctmem to Lisp float properly.
2594 Let the compiler fold better, as 100.0/0x8000 is exact.
2596 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2598 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2601 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2603 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2605 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2607 For a 'struct window', replace some Lisp_Object fields to
2608 bitfields where appropriate, remove unused fields.
2609 * window.h (struct window): Remove unused 'last_mark_x' and
2610 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2611 change it's type from Lisp_Object to bitfield.
2612 Change type of 'force_start', 'optional_new_start',
2613 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2614 fields from Lisp_Object to bitfield. Adjust users accordingly.
2616 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2618 Pacify gcc -Wdouble-precision when using Xaw.
2619 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2620 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2621 Use 'float' consistently, rather than 'float' in most places
2622 and 'double' in a couple of places.
2624 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2626 * xdisp.c (handle_stop): Detect whether we have overlay strings
2627 loaded by testing it->current.overlay_string_index to be
2628 non-negative, instead of checking whether n_overlay_strings is
2629 positive. (Bug#11587)
2631 2012-05-31 Chong Yidong <cyd@gnu.org>
2633 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2635 * doc.c (Fsubstitute_command_keys): Doc fix.
2637 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2639 * search.c (search_buffer): Remove calls to
2640 r_alloc_inhibit_buffer_relocation, as it is now called by
2641 maybe_unify_char, which was the cause of relocation of buffer text
2644 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2646 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2647 for the duration of call to load_charset, to avoid problems with
2648 callers of maybe_unify_char that access buffer text through C
2651 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2652 decrement the inhibition flag, instead of just setting or
2655 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2657 Remove obsolete '#define static' cruft.
2658 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2659 This #undef was "temporary" in 2000; it is no longer needed
2660 now that '#define static' has gone away.
2661 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2662 (gray_bitmap_bits): Remove; no longer needed.
2663 All uses replaced with definiens.
2664 * xterm.c: Include "bitmaps/gray.xbm".
2666 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2668 Clean up __executable_start, monstartup when --enable-profiling.
2669 The following changes affect the code only when profiling.
2670 * dispnew.c (__executable_start): Rename from safe_bcopy.
2671 Define only on platforms that need it.
2672 * emacs.c: Include <sys/gmon.h> when profiling.
2673 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2674 (__executable_start): Remove decl, since lisp.h does it now.
2675 (safe_bcopy): Remove decl; no longer has that name.
2676 (main): Coalesce #if into single bit of code, for simplicity.
2677 Cast pointers to uintptr_t, since standard libraries want integers
2679 * lisp.h (__executable_start): New decl.
2681 2012-05-31 Glenn Morris <rgm@gnu.org>
2683 * image.c (Fimagemagick_types): Doc fix.
2685 2012-05-30 Jim Meyering <meyering@redhat.com>
2687 * callproc.c (Fcall_process_region): Include directory component
2688 in mkstemp error message (Bug#11586).
2690 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2692 * alloc.c, lisp.h (make_pure_vector): Now static.
2694 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2696 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2697 Move to byte-run.el.
2698 (Fautoload): Do the hash-doc more carefully.
2699 * data.c (Fdefalias): Purify definition, except for keymaps.
2700 (Qdefun): Move from eval.c.
2701 * lisp.h (Qdefun): Remove.
2702 * lread.c (read1): Tiny simplification.
2704 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
2706 Do not create empty overlays with the evaporate property (Bug#9642).
2707 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2708 Bug#9642, but explicitly check that the buffer the overlay would
2709 be moved to is live and rearrange lines to make sure that errors
2710 will not put the overlay in an inconsistent state.
2711 (Fdelete_overlay): Cosmetics.
2713 2012-05-28 Eli Zaretskii <eliz@gnu.org>
2715 * w32term.c (my_bring_window_to_top): New function.
2716 (x_raise_frame): Use handle returned by DeferWindowPos, which
2717 could be different from the original one.
2718 Call my_bring_window_to_top instead of my_set_foreground_window.
2721 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2722 by calling BringWindowToTop.
2724 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2725 (WM_EMACS_END): Increase by one.
2727 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2729 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2730 This avoids undefined behavior that might cause the eassert
2731 to not catch an out-of-range value.
2733 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
2735 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2736 Update dependencies.
2738 2012-05-27 Eli Zaretskii <eliz@gnu.org>
2740 * bidi.c (bidi_mirror_char): Fix last change.
2742 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2744 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2745 when referring to sectname field in printf format.
2747 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2749 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2750 Only r_alloc_inhibit_buffer_relocation needed to be added;
2751 the others were already declared.
2753 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2754 before checking whether it's out of range. Put the check inside
2756 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2758 2012-05-27 Ken Brown <kbrown@cornell.edu>
2760 * callproc.c (Fcall_process): Restore a line that was accidentally
2761 commented out in the 2011-02-13 change (bug#11547).
2763 2012-05-27 Eli Zaretskii <eliz@gnu.org>
2765 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2766 defined on ralloc.c.
2768 * buffer.c [REL_ALLOC]: Remove prototypes of
2769 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2770 they are now on lisp.h.
2772 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2774 * search.c (search_buffer): Use it to inhibit relocation of buffer
2775 text while re_search_2 is doing its job, because re_search_2 is
2776 passed C pointers to buffer text. (Bug#11519)
2778 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2781 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2782 state after an additional call to move_it_in_display_line_to, keep
2783 the values of it->max_ascent and it->max_descent found for the
2785 (pos_visible_p): Revert the comparison against bottom_y to what it
2786 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2789 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2791 Fix coding-related core dumps with gcc -ftrapv.
2792 The code was computing A - B, where A and B are pointers, and B is
2793 random garbage. This can lead to core dumps on platforms that
2794 have special pointer registers, and it also leads to core dumps on
2795 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2796 A - B only when B is initialized properly.
2797 * coding.c (coding_set_source, coding_set_destination): Return void.
2798 (coding_change_source, coding_change_destinations): New functions,
2799 with the old behaviors of coding_set_source and coding_set_destination.
2800 All callers that need an offset changed to use these new functions.
2802 2012-05-26 Glenn Morris <rgm@gnu.org>
2804 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2806 2012-05-26 Eli Zaretskii <eliz@gnu.org>
2808 Extend mouse support on W32 text-mode console.
2809 * xdisp.c (draw_row_with_mouse_face):
2810 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
2812 * w32console.c: Include window.h.
2813 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2815 (initialize_w32_display): Initialize mouse-highlight data.
2817 * w32inevt.c: Include termchar.h and window.h.
2818 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2819 moves, call note_mouse_highlight. If help_echo changed, call
2820 gen_help_event to produce help-echo message in the echo area.
2821 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2824 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2826 * lread.c (read1): Simplify slightly to avoid an overflow warning
2827 with GCC 4.7.0 on x86-64.
2829 2012-05-26 Eli Zaretskii <eliz@gnu.org>
2831 * bidi.c (bidi_mirror_char): Revert last change: an int is
2832 definitely wide enough here.
2834 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
2836 Fix integer width and related bugs (Bug#9874).
2837 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
2838 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2839 (string_bytes, check_sblock, allocate_string_data):
2840 (compact_small_strings, Fmake_bool_vector, make_string)
2841 (make_unibyte_string, make_multibyte_string)
2842 (make_string_from_bytes, make_specified_string)
2843 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2844 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2846 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2847 (allocate_pseudovector):
2848 Use int, not EMACS_INT, where int is wide enough.
2849 (inhibit_garbage_collection, Fgarbage_collect):
2850 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2851 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2852 int might not be wide enough.
2853 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2854 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2855 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2856 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2857 (bidi_level_of_next_char, bidi_move_to_visually_next):
2858 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2859 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2860 (Fkill_buffer, Fset_buffer_major_mode)
2861 (advance_to_char_boundary, Fbuffer_swap_text)
2862 (Fset_buffer_multibyte, overlays_at, overlays_in)
2863 (overlay_touches_p, struct sortvec, record_overlay_string)
2864 (overlay_strings, recenter_overlay_lists)
2865 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2866 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2867 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2868 (Foverlay_recenter, last_overlay_modification_hooks_used)
2869 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2870 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2871 (validate_region): Omit unnecessary test for b <= e,
2872 since that's guaranteed by the previous test.
2873 (adjust_overlays_for_delete): Avoid pos + length overflow.
2874 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2875 (report_overlay_modification):
2876 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2877 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2878 Omit pointer cast, which isn't needed anyway, and doesn't work
2879 after the EMACS_INT -> ptrdiff_t change.
2880 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
2881 * buffer.h: Adjust decls to match defn changes elsewhere.
2882 (struct buffer_text, struct buffer):
2883 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2884 Use EMACS_INT, not int, where int might not be wide enough.
2885 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2886 not int, to avoid needless 32-bit limit on 64-bit hosts.
2887 (exec_byte_code): Use tighter memory-full test, one that checks
2888 for alloca overflow. Don't compute the address of the object just
2889 before an array, as that's not portable. Use EMACS_INT, not
2890 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
2891 * callint.c (Fcall_interactively):
2892 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2893 * callproc.c (call_process_kill, Fcall_process):
2894 Don't assume pid_t fits into an Emacs fixnum.
2895 (call_process_cleanup, Fcall_process, child_setup):
2896 Don't assume pid_t fits into int.
2897 (call_process_cleanup, Fcall_process, delete_temp_file)
2898 (Fcall_process_region):
2899 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2900 (Fcall_process): Simplify handling of volatile integers.
2901 Use int, not EMACS_INT, where int will do.
2902 * casefiddle.c (casify_object, casify_region, operate_on_word)
2903 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2904 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2905 (casify_object): Avoid integer overflow when overallocating buffer.
2906 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
2907 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
2908 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2909 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2910 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2911 integers are now checked earlier. All uses replaced with XINT.
2913 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2914 For CCL_MapSingle, check that content and value are in int range.
2915 (ccl_driver, Fregister_code_conversion_map):
2916 Check that Vcode_version_map_vector is a vector.
2917 (resolve_symbol_ccl_program): Check that vector header is in range.
2918 Always copy the vector, so that we can check its contents reliably
2919 now rather than having to recheck each instruction as it's being
2920 executed. Check that vector words fit in 'int'.
2921 (ccl_get_compiled_code, Fregister_ccl_program)
2922 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2923 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2924 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2925 contents are in range.
2926 (Fccl_execute_on_string): Check that status is in range.
2927 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2928 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2929 Accept and return EMACS_INT, not int, because callers can pass values
2931 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2932 (multibyte_chars_in_text, parse_str_as_multibyte)
2933 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2934 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2935 (string_escape_byte8, Fget_byte):
2936 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2937 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
2938 avoid mishandling large integers.
2939 * character.h: Adjust decls to match defn changes elsewhere.
2940 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2941 (Ffind_charset_region):
2942 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2943 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2944 (load_charset_map_from_vector, Fdefine_charset_internal):
2945 Don't assume fixnum fits in int.
2946 (load_charset_map_from_vector, Fmap_charset_chars):
2947 Remove now-unnecessary CHECK_NATNUMs.
2948 (Fdefine_charset_internal): Check ranges here, more carefully.
2949 Don't rely on undefined behavior with signed left shift overflow.
2950 Don't assume unsigned int fits into fixnum, or that fixnum fits
2951 into unsigned int. Don't require max_code to be a valid fixnum;
2952 that's not true for gb10830 4-byte on a 32-bit host. Allow
2953 invalid_code to be a cons, for the same reason. Require code_offset
2954 to be a character. Avoid int overflow if max_char is close
2956 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2957 this is intended anyway and avoids some undefined behavior.
2958 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2959 INDEX_TO_CODE_POINT, as that's what it expects.
2960 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
2961 * charset.h (DECODE_CHAR): Return int, not unsigned;
2962 this is what was intended anyway, and it avoids undefined behavior.
2963 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2964 integer-overflow issues.
2965 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2966 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2967 where the argument is EMACS_INT, and this behavior is not intended.
2968 * chartab.c (Fmake_char_table, Fset_char_table_range)
2969 (uniprop_get_decoder, uniprop_get_encoder):
2970 Don't assume fixnum fits in int.
2971 * cmds.c (move_point): New function, that does the gist of
2972 Fforward_char and Fbackward_char, but does so while checking
2973 for integer overflow more accurately.
2974 (Fforward_char, Fbackward_char): Use it.
2975 (Fforward_line, Fend_of_line, internal_self_insert)
2976 (internal_self_insert):
2977 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2978 Fix a FIXME, by checking for integer overflow when calculating
2979 target_clm and actual_clm.
2980 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
2981 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
2982 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2983 (coding_alloc_by_making_gap, alloc_destination)
2984 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2985 (encode_coding_utf_16, detect_coding_emacs_mule)
2986 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2987 (detect_coding_iso_2022, decode_coding_iso_2022)
2988 (encode_invocation_designation, encode_designation_at_bol)
2989 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2990 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2991 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2992 (encode_coding_ccl, encode_coding_raw_text)
2993 (detect_coding_charset, decode_coding_charset)
2994 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2995 (produce_composition, produce_charset, produce_annotation)
2996 (decode_coding, handle_composition_annotation)
2997 (handle_charset_annotation, consume_chars, decode_coding_gap)
2998 (decode_coding_object, encode_coding_object, detect_coding_system)
2999 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3000 (code_convert_region, code_convert_string)
3001 (Fdefine_coding_system_internal)
3002 (coding_set_source, coding_set_destination):
3003 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3004 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3005 (Fdefine_coding_system_internal):
3006 Don't assume fixnums fit in int.
3007 (decode_coding_gap, decode_coding_object, encode_coding_object)
3008 (Fread_coding_system, Fdetect_coding_region)
3009 (Funencodable_char_position, Fcheck_coding_systems_region)
3010 (get_translation, handle_composition_annotation, consume_chars):
3011 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3012 (consume_chars): Rewrite to not calculate an address outside buffer.
3013 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
3014 Don't access memory outside of the args array.
3015 (Fdefine_coding_system_internal): Check for charset-id overflow.
3016 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3017 result of ENCODE_CHAR.
3018 * coding.h: Adjust decls to match defn changes elsewhere.
3019 (struct coding_system):
3020 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3021 * composite.c (get_composition_id, find_composition)
3022 (run_composition_function, update_compositions)
3023 (compose_text, composition_gstring_put_cache)
3024 (composition_gstring_p, composition_gstring_width)
3025 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3026 (composition_compute_stop_pos, composition_reseat_it)
3027 (composition_update_it, struct position_record)
3028 (find_automatic_composition, composition_adjust_point)
3029 (Fcomposition_get_gstring, Ffind_composition_internal):
3030 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3031 (update_compositions):
3032 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3033 * composite.h: Adjust decls to match defn changes elsewhere.
3034 (struct composition):
3035 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3036 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3037 Do not attempt to compute the address of the object just before a
3038 buffer; this is not portable.
3040 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3041 (Faset): Use int, not EMACS_INT, where int is wide enough.
3042 (Fstring_to_number): Don't assume fixnums fit in int.
3043 (Frem): Don't assume arg is nonnegative.
3044 * dbusbind.c (xd_append_arg): Check for integers out of range.
3045 (Fdbus_call_method): Don't overflow the timeout int.
3046 (extract_signed, extract_unsigned): New functions.
3047 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3048 (xd_get_connection_references): Return ptrdiff_t, not int.
3050 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3051 (xd_read_message_1):
3052 Use int, not unsigned, where the dbus API uses int.
3053 (Fdbus_message_internal): Don't overflow mtype.
3054 (syms_of_dbusbind): Allocate right-sized buffer for integers.
3055 * dired.c (directory_files_internal, file_name_completion, scmp)
3056 (file_name_completion_stat):
3057 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3058 (file_name_completion): Don't overflow matchcount.
3059 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3060 * dispextern.h: Adjust decls to match defn changes elsewhere.
3061 (struct text_pos, struct glyph, struct bidi_saved_info)
3062 (struct bidi_string_data, struct bidi_it, struct composition_it)
3064 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3065 (struct display_pos, struct composition_it, struct it):
3066 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3067 * dispnew.c (increment_matrix_positions)
3068 (increment_row_positions, mode_line_string)
3069 (marginal_area_string):
3070 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3071 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
3072 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3073 (duration_to_sec_usec): New function, to check for overflow better.
3074 (Fsleep_for, sit_for): Use it.
3075 * doc.c (get_doc_string, store_function_docstring):
3076 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3077 (get_doc_string, Fsnarf_documentation):
3078 Use int, not EMACS_INT, where int is wide enough.
3080 Use SAFE_ALLOCA, not alloca.
3081 Check for overflow when converting EMACS_INT to off_t.
3082 * doprnt.c (doprnt):
3083 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3084 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3085 Don't assume uid_t fits into fixnum.
3086 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3087 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3088 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3089 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3090 (general_insert_function)
3091 (Finsert_char, make_buffer_string, make_buffer_string_both)
3092 (update_buffer_properties, Fbuffer_substring)
3093 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3094 (Fsubst_char_in_region, check_translation)
3095 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3096 (transpose_markers, Ftranspose_regions):
3097 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3098 (clip_to_bounds): Move to lisp.h as an inline function).
3099 (Fconstrain_to_field): Don't assume integers are nonnegative.
3100 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3101 (Fsubst_char_in_region, Fsave_restriction):
3102 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3103 (Femacs_pid): Don't assume pid_t fits into fixnum.
3104 (lo_time): Use int, not EMACS_INT, when int suffices.
3105 (lisp_time_argument): Check for usec out of range.
3106 (Fencode_time): Don't assume fixnum fits in int.
3107 (Fuser_login_name, Fuser_full_name): Signal an error
3108 if a uid argument is out of range, rather than relying on
3110 (Fformat_time_string): Remove now-unnecessary check.
3111 lisp_time_argument checks for out-of-range usec now.
3112 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
3113 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3114 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3115 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3116 (init_cmdargs, Fdump_emacs):
3117 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3118 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3119 the bottom (typically) 32 bits of the fixnum.
3120 * eval.c (specpdl_size, call_debugger):
3121 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3122 (when_entered_debugger, Fbacktrace_debug):
3123 Don't assume fixnum can fit in int.
3124 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3125 the object just before a buffer; this is not portable.
3126 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3127 (grow_specpdl, unbind_to):
3128 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3129 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3130 (grow_specpdl): Simplify allocation by using xpalloc.
3131 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
3132 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3133 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3134 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3135 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3137 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3138 (Fcopy_file, non_regular_nbytes, read_non_regular)
3139 (Finsert_file_contents):
3140 Use int, not EMACS_INT, where int is wide enough.
3141 (READ_BUF_SIZE): Verify that it fits in int.
3142 (Finsert_file_contents): Check that counts are in proper range,
3143 rather than assuming fixnums fit into ptrdiff_t etc.
3144 Don't assume fixnums fit into int.
3145 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
3146 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3147 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
3148 (string_char_to_byte, string_byte_to_char)
3149 (string_make_multibyte, string_to_multibyte)
3150 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3151 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3152 (substring_both, Fdelete, internal_equal, Ffillarray)
3153 (Fclear_string, mapcar1)
3154 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3155 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3156 (larger_vector, make_hash_table, maybe_resize_hash_table)
3157 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3158 (Fmaphash, secure_hash):
3159 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3160 (concat): Check for string index and length overflow.
3161 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3163 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3164 (larger_vector): New API (vec, incr_min, size_max) replaces old
3165 one (vec, new_size, init). This catches size overflow.
3166 INIT was removed because it was always Qnil.
3167 All callers changed.
3168 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3169 the upper bound on a hash table index size.
3170 (make_hash_table, maybe_resize_hash_table): Use it.
3171 (secure_hash): Computer start_byte and end_byte only after
3172 they're known to be in ptrdiff_t range.
3173 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3174 (Ffont_get_glyphs, Ffont_at):
3175 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3176 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3177 (Flist_fonts, Fopen_font):
3178 Don't assume fixnum can fit in int.
3179 (check_gstring): Don't assume index can fit in int.
3180 (font_match_p): Check that fixnum is a character, not a nonnegative
3181 fixnum, since the later code needs to stuff it into an int.
3182 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3183 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3184 conversion overflow issues.
3185 (Fopen_font): Check for integer out of range.
3186 (Ffont_get_glyphs): Don't assume index can fit in int.
3187 * font.h: Adjust decls to match defn changes elsewhere.
3188 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3190 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3191 printmax_t, where ptrdiff_t is wide enough.
3192 (Finternal_char_font):
3193 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3194 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3195 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3196 (Fset_frame_position, x_set_frame_parameters)
3197 (x_set_line_spacing, x_set_border_width)
3198 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3199 Check that fixnums are in proper range for system types.
3200 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3201 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3202 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3203 Use SAFE_ALLOCA_LISP, not alloca.
3204 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3205 intptr_t is wide enough.
3206 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3207 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3208 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3209 Check for fixnum out of range.
3210 * ftfont.c (ftfont_list): Don't assume index fits in int.
3211 Check that fixnums are in proper range for system types.
3212 (ftfont_shape_by_flt):
3213 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3214 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3215 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3216 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3217 Check that fixnums are in proper range for system types.
3218 * gnutls.h: Adjust decls to match defn changes elsewhere.
3219 * gtkutil.c (xg_dialog_run):
3220 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3221 (update_frame_tool_bar):
3222 Check that fixnums are in proper range for system types.
3223 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
3224 (lookup_image): Check that fixnums are in range for system types.
3225 * indent.c (last_known_column, last_known_column_point):
3226 (current_column_bol_cache):
3227 (skip_invisible, current_column, check_display_width):
3228 (check_display_width, scan_for_column, current_column_1)
3229 (Findent_to, Fcurrent_indentation, position_indentation)
3230 (indented_beyond_p, Fmove_to_column, compute_motion):
3231 (Fcompute_motion, Fvertical_motion):
3232 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3233 (last_known_column_modified): Use EMACS_INT, not int.
3234 (check_display_width):
3236 Check that fixnums and floats are in proper range for system types.
3237 (compute_motion): Don't assume index or fixnum fits in int.
3238 (compute_motion, Fcompute_motion):
3239 Use int, not EMACS_INT, when it is wide enough.
3240 (vmotion): Omit local var start_hpos that is always 0; that way
3241 we don't need to worry about overflow in expressions involving it.
3242 * indent.h: Adjust decls to match defn changes elsewhere.
3244 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3245 Use int, not EMACS_INT, where int is wide enough.
3246 Remove unused members ovstring_chars_done and tab_offset;
3248 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3249 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3250 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3251 (make_gap, copy_text, insert, insert_and_inherit)
3252 (insert_before_markers, insert_before_markers_and_inherit)
3253 (insert_1, count_combining_before, count_combining_after)
3254 (insert_1_both, insert_from_string)
3255 (insert_from_string_before_markers, insert_from_string_1)
3256 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3257 (adjust_after_replace, adjust_after_insert, replace_range)
3258 (replace_range_2, del_range, del_range_1, del_range_byte)
3259 (del_range_both, del_range_2, modify_region)
3260 (prepare_to_modify_buffer, signal_before_change)
3261 (signal_after_change, Fcombine_after_change_execute):
3262 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3263 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3264 (balance_an_interval, split_interval_right, split_interval_left)
3265 (find_interval, next_interval, update_interval)
3266 (adjust_intervals_for_insertion, delete_node, delete_interval)
3267 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3268 (static_offset_intervals, offset_intervals)
3269 (merge_interval_right, merge_interval_left, make_new_interval)
3270 (graft_intervals_into_buffer, temp_set_point_both)
3271 (temp_set_point, set_point, adjust_for_invis_intang)
3272 (set_point_both, move_if_not_intangible, get_property_and_range)
3273 (get_local_map, copy_intervals, copy_intervals_to_string)
3274 (compare_string_intervals, set_intervals_multibyte_1):
3275 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3276 * intervals.h: Adjust decls to match defn changes elsewhere.
3278 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3279 * keyboard.c (this_command_key_count, this_single_command_key_start)
3280 (before_command_key_count, before_command_echo_length, echo_now)
3281 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3282 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3283 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3284 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3285 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3286 (last_non_minibuf_size, last_point_position, echo_truncate)
3287 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3288 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3289 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3290 (stuff_buffered_input):
3291 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3292 (last_auto_save, command_loop_1, read_char):
3293 Use EMACS_INT, not int, to avoid integer overflow.
3294 (record_char): Avoid overflow in total_keys computation.
3295 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3296 * keyboard.h: Adjust decls to match defn changes elsewhere.
3297 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3298 (Fkey_description, Fdescribe_vector, Flookup_key):
3299 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3300 (click_position): New function, to check that positions are in range.
3301 (Fcurrent_active_maps):
3303 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3304 (Faccessible_keymaps, Fkey_description):
3305 (preferred_sequence_p):
3306 Don't assume fixnum can fit into int.
3307 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3308 Check for integer overflow in size calculations.
3309 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3310 avoid mishandling large integers.
3311 * lisp.h: Adjust decls to match defn changes elsewhere.
3312 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3313 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3314 (struct Lisp_Marker):
3315 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3316 (clip_to_bounds): Now an inline function, moved here from editfns.c.
3317 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3318 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3319 All callers changed.
3320 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3321 Assume the arg has valid form, since it always does.
3322 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3323 unsigned integer system type.
3324 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3325 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3326 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3327 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3328 (duration_to_sec_usec): New decl.
3329 * lread.c (read_from_string_index, read_from_string_index_byte)
3330 (read_from_string_limit, readchar, unreadchar, openp)
3331 (read_internal_start, read1, oblookup):
3332 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3333 (Fload, readevalloop, Feval_buffer, Feval_region):
3334 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3335 (openp): Check for out-of-range argument to 'access'.
3336 (read1): Use int, not EMACS_INT, where int is wide enough.
3337 Don't assume fixnum fits into int.
3338 Fix off-by-one error that can read outside a buffer.
3339 (read_filtered_event): Use duration_to_sec_usec
3340 to do proper overflow checking on durations.
3341 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3342 in size calculation.
3343 (Fexecute_kbd_macro):
3344 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3345 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3346 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3347 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3348 (set_marker_both, set_marker_restricted_both, marker_position)
3349 (marker_byte_position, Fbuffer_has_markers_at):
3350 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3351 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
3352 * menu.c (ensure_menu_items): Rename from grow_menu_items.
3353 It now merely ensures that the menu is large enough, without
3354 necessarily growing it, as this avoids some integer overflow issues.
3355 All callers changed.
3356 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3357 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3358 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3359 Use SAFE_ALLOCA_LISP, not alloca.
3360 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3361 to EMACS_INT. Check that fixnums are in proper range for system types.
3362 * minibuf.c (minibuf_prompt_width, string_to_object)
3363 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3364 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3365 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3366 (get_minibuffer, read_minibuf_unwind):
3367 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3368 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3369 this simplifies overflow checking. All callers changed.
3370 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3372 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3373 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3374 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3375 Check that fixnums are in proper range for system types.
3376 (Fx_create_frame, Fx_show_tip):
3377 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3378 * nsfont.m (ns_findfonts, nsfont_list_family):
3379 Don't assume fixnum fits in long.
3380 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3381 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3382 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3384 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
3385 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3386 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3387 (PRINTDECLARE, PRINTPREPARE):
3388 (strout, print_string):
3389 (print, print_preprocess, print_check_string_charset_prop)
3391 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3393 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3394 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3395 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
3396 (printchar, strout): Use xpalloc to catch size calculation overflow.
3397 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
3398 (print_error_message): Use SAFE_ALLOCA, not alloca.
3399 (print_object): Use int, not EMACS_INT, where int is wide enough.
3400 (print_depth, new_backquote_output, print_number_index):
3401 Use ptrdiff_t, not int, where int might not be wide enough.
3402 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3403 (Fset_process_window_size, Fformat_network_address)
3404 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
3406 Check that fixnums are in proper range for system types.
3407 (Fsignal_process): Simplify by avoiding a goto.
3408 Check for process-ids out of pid_t range rather than relying on
3410 (process_tick, update_tick): Use EMACS_INT, not int.
3411 (Fformat_network_address, read_process_output, send_process)
3412 (Fprocess_send_region, status_notify):
3413 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3414 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3415 (wait_reading_process_output, read_process_output, exec_sentinel):
3416 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3417 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3418 (Faccept_process_output): Use duration_to_sec_usec to do proper
3419 overflow checking on durations.
3420 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3421 Don't assume pid_t fits in int.
3422 * process.h (struct Lisp_Process): Members tick and update_tick
3423 are now of type EMACS_INT, not int.
3424 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3425 configured --with-wide-int.
3426 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3427 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3428 * search.c (looking_at_1, string_match_1):
3429 (fast_string_match, fast_c_string_match_ignore_case)
3430 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3431 (scan_newline, find_before_next_newline, search_command)
3432 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3433 (set_search_regs, wordify):
3436 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3437 (string_match_1, search_buffer, set_search_regs):
3439 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3440 (wordify): Check for overflow in size calculation.
3441 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3442 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3443 Check that fixnums are in proper range for system types.
3444 * sound.c (struct sound_device)
3445 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3446 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3447 (Fplay_sound_internal):
3448 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3449 * syntax.c (struct lisp_parse_state, find_start_modiff)
3450 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3451 (Fparse_partial_sexp):
3452 Don't assume fixnums can fit in int.
3453 (struct lisp_parse_state, find_start_pos, find_start_value)
3454 (find_start_value_byte, find_start_begv)
3455 (update_syntax_table, char_quoted, dec_bytepos)
3456 (find_defun_start, prev_char_comend_first, back_comment):
3457 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3458 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3459 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3460 (Finternal_describe_syntax_value): Check that match_lisp is a
3461 character, not an integer, since the code stuffs it into int.
3462 (scan_words, scan_sexps_forward):
3463 Check that fixnums are in proper range for system types.
3465 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3466 (scan_sexps_forward):
3467 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3468 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3469 * syntax.h: Adjust decls to match defn changes elsewhere.
3470 (struct gl_state_s):
3471 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3472 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3473 MOST_POSITIVE_FIXNUM.
3474 * sysdep.c (wait_for_termination_1, wait_for_termination)
3475 (interruptible_wait_for_termination, mkdir):
3476 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3477 (emacs_read, emacs_write):
3478 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3479 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3480 and double all fit in int.
3481 * term.c (set_tty_color_mode):
3482 Check that fixnums are in proper range for system types.
3483 * termhooks.h (struct input_event):
3484 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3485 * textprop.c (validate_interval_range, interval_of)
3486 (Fadd_text_properties, set_text_properties_1)
3487 (Fremove_text_properties, Fremove_list_of_text_properties)
3488 (Ftext_property_any, Ftext_property_not_all)
3489 (copy_text_properties, text_property_list, extend_property_ranges)
3490 (verify_interval_modification):
3491 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3492 (Fnext_single_char_property_change)
3493 (Fprevious_single_char_property_change):
3494 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3495 (copy_text_properties):
3496 Check for integer overflow in index calculation.
3497 * undo.c (last_boundary_position, record_point, record_insert)
3498 (record_delete, record_marker_adjustment, record_change)
3499 (record_property_change):
3500 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3501 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3502 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3503 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3504 (Fx_hide_tip, Fx_file_dialog):
3505 * w32menu.c (set_frame_menubar):
3506 Use ptrdiff_t, not int, for consistency with rest of code.
3507 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3508 (select_window, Fdelete_other_windows_internal)
3509 (window_scroll_pixel_based, window_scroll_line_based)
3510 (Frecenter, Fset_window_configuration):
3511 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3512 (Fset_window_hscroll, run_window_configuration_change_hook)
3513 (set_window_buffer, temp_output_buffer_show, scroll_command)
3514 (Fscroll_other_window, Frecenter):
3515 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3516 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3517 Don't assume fixnum fits in int.
3518 (Fset_window_scroll_bars):
3519 Check that fixnums are in proper range for system types.
3520 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3521 (string_pos, c_string_pos, number_of_chars, init_iterator)
3522 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3523 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3524 (compute_display_string_end, handle_face_prop)
3525 (face_before_or_after_it_pos, handle_invisible_prop)
3526 (handle_display_prop, handle_display_spec, handle_single_display_spec)
3527 (display_prop_intangible_p, string_buffer_position_lim)
3528 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3529 (get_overlay_strings_1, get_overlay_strings)
3530 (iterate_out_of_display_property, forward_to_next_line_start)
3531 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3532 (get_next_display_element, set_iterator_to_next)
3533 (get_visually_first_element, compute_stop_pos_backwards)
3534 (handle_stop_backwards, next_element_from_buffer)
3535 (move_it_in_display_line_to, move_it_in_display_line)
3536 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3537 (add_to_log, message_dolog, message_log_check_duplicate)
3538 (message2, message2_nolog, message3, message3_nolog
3539 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3540 (current_message_1, truncate_echo_area, truncate_message_1)
3541 (set_message, set_message_1, store_mode_line_noprop)
3542 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3543 (text_outside_line_unchanged_p, check_point_in_composition)
3544 (reconsider_clip_changes)
3545 (redisplay_internal, set_cursor_from_row, try_scrolling)
3546 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3547 (redisplay_window, find_last_unchanged_at_beg_row)
3548 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3549 (trailing_whitespace_p, find_row_edges, display_line)
3550 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3551 (display_mode_element, store_mode_line_string)
3552 (pint2str, pint2hrstr, decode_mode_spec)
3553 (display_count_lines, display_string, draw_glyphs)
3554 (x_produce_glyphs, x_insert_glyphs)
3555 (rows_from_pos_range, mouse_face_from_buffer_pos)
3556 (fast_find_string_pos, mouse_face_from_string_pos)
3557 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3558 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3559 (safe_call, init_from_display_pos, handle_fontified_prop)
3560 (handle_single_display_spec, load_overlay_strings)
3561 (with_echo_area_buffer, setup_echo_area_for_printing)
3562 (display_echo_area, echo_area_display)
3563 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3564 (update_tool_bar, hscroll_window_tree, redisplay_internal)
3565 (redisplay_window, dump_glyph_row, display_mode_line)
3566 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
3567 (handle_display_spec, display_prop_string_p):
3568 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3569 (handle_single_display_spec, build_desired_tool_bar_string)
3570 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3571 (get_specified_cursor_type):
3572 Check that fixnums are in proper range for system types.
3573 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3574 (Flookup_image_map):
3575 Don't assume fixnums fit in int.
3576 (compare_overlay_entries):
3577 Avoid mishandling comparisons due to subtraction overflow.
3578 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3579 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3580 (handle_tool_bar_click):
3581 Use int, not unsigned, since we prefer signed and the signedness
3582 doesn't matter here.
3583 (get_next_display_element, next_element_from_display_vector):
3584 Use int, not EMACS_INT, when int is wide enough.
3585 (start_hourglass): Use duration_to_sec_usec to do proper
3586 overflow checking on durations.
3587 * xfaces.c (Fbitmap_spec_p):
3588 Check that fixnums are in proper range for system types.
3589 (compare_fonts_by_sort_order):
3590 Avoid mishandling comparisons due to subtraction overflow.
3591 (Fx_family_fonts, realize_basic_faces):
3592 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3594 Don't assume fixnum fits in int.
3595 Use SAFE_ALLOCA_LISP, not alloca.
3596 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3597 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3598 (face_at_buffer_position, face_for_overlay_string)
3599 (face_at_string_position):
3600 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3601 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3602 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3604 Check that fixnums are in proper range for system types.
3605 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3606 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3607 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3608 (Fx_change_window_property): Don't assume fixnums fit in int.
3609 * xfont.c (xfont_chars_supported):
3610 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3611 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3612 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3613 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3614 * xml.c (parse_region):
3615 * xrdb.c (magic_file_p):
3616 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3617 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3618 (x_get_local_selection, x_reply_selection_request)
3619 (x_handle_selection_request, wait_for_property_change):
3620 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3621 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3622 short is wide enough.
3623 (x_send_client_event): Don't assume fixnum fits in int.
3624 * xterm.c (x_x_to_emacs_modifiers):
3625 Don't assume EMACS_INT overflows nicely into int.
3626 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3628 (handle_one_xevent): NATNUMP can eval its arg twice.
3629 (x_connection_closed):
3630 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3631 * xterm.h: Adjust decls to match defn changes elsewhere.
3632 (struct scroll_bar): Use struct vectorlike_header
3633 rather than rolling our own approximation.
3634 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3636 2012-05-25 Glenn Morris <rgm@gnu.org>
3638 * lisp.mk (lisp): Update for more files being compiled now.
3640 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3642 * lread.c: Remove `read_pure' which makes no difference.
3643 (read_pure): Remove var.
3644 (unreadpure): Remove function.
3645 (readevalloop): Don't call read_list with -1 flag.
3646 (read1, read_vector): Don't test read_pure any more.
3647 (read_list): Simplify.
3649 * fileio.c, character.h: Minor style tweaks.
3651 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3653 * window.h (clip_changed): Remove useless declaration.
3655 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
3657 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3658 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3660 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3663 This directory predates autoconf and is no longer needed nowadays.
3664 Move its few remaining bits of functionality to where they're needed.
3665 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3666 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3667 * m/template.h: Remove.
3668 * Makefile.in (M_FILE): Remove. All uses removed.
3669 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3670 * lisp.h (USE_LSB_TAG):
3671 * mem-limits.h (EXCEEDS_LISP_PTR):
3672 Use VAL_MAX, not VALBITS, in #if.
3673 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3674 (EMACS_UINT): Define unconditionally now.
3675 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3676 (BITS_PER_EMACS_INT): New constants, replacing
3677 what used to be in config.h, but not useful in #if.
3678 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3679 define them any more.
3680 (VAL_MAX): New macro.
3682 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3683 BITS_PER_EMACS_INT, in #if.
3684 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3685 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3686 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3687 * s/ms-w32.h (DATA_START):
3688 Move here from removed file m/intel386.h.
3689 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3690 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3692 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3694 Assume C89 or later.
3695 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3696 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3698 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3699 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3700 * textprop.c, tparam.c (NULL): Remove.
3701 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3702 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3703 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3704 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3705 * xterm.c (input_signal_count): Assume volatile works.
3707 2012-05-21 Ken Brown <kbrown@cornell.edu>
3709 * xgselect.c (xg_select): Fix first argument in call to 'select'
3712 2012-05-20 Ken Brown <kbrown@cornell.edu>
3714 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
3715 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
3717 2012-05-19 Ken Brown <kbrown@cornell.edu>
3719 * xfns.c (x_in_use): Remove `static' qualifier.
3720 * xterm.h (x_in_use): Declare.
3721 * xgselect.c: Include xterm.h.
3722 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3723 and `display_arg' (bug#9754).
3725 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3727 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3729 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3730 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3732 2012-05-18 Eli Zaretskii <eliz@gnu.org>
3734 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3736 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
3737 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
3739 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3740 reference to image_cache->refcount.
3741 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3743 2012-05-17 Juri Linkov <juri@jurta.org>
3745 * search.c (Fword_search_regexp, Fword_search_backward)
3746 (Fword_search_forward, Fword_search_backward_lax)
3747 (Fword_search_forward_lax): Move functions to isearch.el
3748 (bug#10145, bug#11381).
3750 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3752 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3754 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3756 * lread.c (init_obarray): Declare Qt and Qnil as special.
3758 2012-05-14 Glenn Morris <rgm@gnu.org>
3760 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
3761 Put "libexec" before "bin", for the sake of init_callproc_1.
3763 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3765 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3767 * unexaix.c: Port to more-recent AIX compilers.
3768 (report_error, report_error_1, make_hdr, copy_sym)
3769 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3770 Make arguments const char *, not char *, to avoid violations of C
3771 standard and to fix some AIX warnings reported by Gilles Pion.
3773 2012-05-14 Eli Zaretskii <eliz@gnu.org>
3775 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3776 already have overlays loaded.
3777 (handle_single_display_spec): Before returning without displaying
3778 fringe bitmap, synchronize the bidi iterator with the main display
3779 iterator, by calling iterate_out_of_display_property.
3780 (iterate_out_of_display_property): Detect buffer iteration by
3781 testing that it->string is a Lisp string.
3782 (get_next_display_element): When the current object is exhausted,
3783 and there's something on it->stack, call set_iterator_to_next to
3784 proceed with what's on the stack, instead of returning zero.
3785 (set_iterator_to_next): If called at the end of a Lisp string,
3786 proceed to consider_string_end without incrementing string
3787 position. Don't increment display vector index past the end of
3788 the display vector. (Bug#11417)
3789 (pos_visible_p): Don't report a position visible when move_it_to
3790 stopped at the last line of window, which happens to be scanned
3791 backwards by the bidi iteration. (Bug#11464)
3793 2012-05-14 Eli Zaretskii <eliz@gnu.org>
3795 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3796 and right-margin display specs even if the spec is invalid or we
3797 are on a TTY, and thus unable to display on the fringes.
3798 That's because the text with the property will not be displayed anyway,
3799 so we need to signal to the caller that this is a "replacing"
3800 display spec. This fixes display when the spec is invalid or we
3803 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3805 * unexaix.c (make_hdr): Fix typo in prototype.
3806 This bug broke the build on AIX. Problem reported by Gilles Pion.
3808 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
3810 * keyboard.c (kbd_buffer_get_event): Read special events also in
3811 batch mode. (Bug#11415)
3813 2012-05-12 Glenn Morris <rgm@gnu.org>
3815 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3817 2012-05-12 Eli Zaretskii <eliz@gnu.org>
3819 * lisp.mk (lisp): Add newcomment.elc.
3821 2012-05-12 Glenn Morris <rgm@gnu.org>
3823 * Makefile.in (MKDIR_P): New, set by configure.
3824 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3826 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3828 Remove unused function hourglass_started.
3829 * dispextern.h (hourglass_started):
3830 * w32fns.c (hourglass_started):
3831 * xdisp.c (hourglass_started): Remove.
3833 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
3835 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3836 Update dependencies.
3838 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3840 * xgselect.c (xg_select): Put maxfds+1 into a var.
3841 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3843 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3845 2012-05-10 Dave Abrahams <dave@boostpro.com>
3847 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3848 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3850 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
3852 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3853 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3854 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3855 Initialize xd_registered_buses.
3857 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3859 Untag more efficiently if USE_LSB_TAG.
3860 This is based on a proposal by YAMAMOTO Mitsuharu in
3861 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3862 For an admittedly artificial (nth 8000 longlist) benchmark on
3863 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3864 Emacs's overall text size by 1%.
3865 * lisp.h (XUNTAG): New macro.
3866 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3867 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3868 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3869 * eval.c (Fautoload):
3870 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3871 * frame.h (XFRAME): Use XUNTAG.
3873 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3874 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3875 Remove unportable assumptions about print widths of types like
3877 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3878 intptr_t when converting between pointer and integer, to avoid GCC
3879 warnings about wrong width.
3881 2012-05-09 Eli Zaretskii <eliz@gnu.org>
3883 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3884 stack for each reader_thread, instead of defaulting to 8MB
3885 determined by the linker. This avoids failures in creating
3886 subprocesses on Windows 7, see the discussion in this thread:
3887 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3889 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3891 Fix up display of the *Minibuf-0* buffer in the mini window.
3892 * keyboard.c (read_char): Don't clear the echo area if there's no
3894 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
3895 contents of *Minibuf-0*) if there's no message displayed in its stead.
3897 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
3899 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3902 2012-05-06 Chong Yidong <cyd@gnu.org>
3904 * lisp.mk (lisp): Update.
3906 2012-05-05 Jim Meyering <meyering@redhat.com>
3908 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3910 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3912 * data.c (PUT_ERROR): New macro.
3913 (syms_of_data): Use it. Add new error type `user-error'.
3914 * undo.c (user_error): New function.
3915 (Fprimitive_undo): Use it.
3916 * print.c (print_error_message): Adjust print style for `user-error'.
3917 * keyboard.c (user_error): New function.
3918 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3920 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3922 Do not limit current-time-string to years 1000..9999.
3923 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3924 (Fcurrent_time_string): Support any year that is supported by the
3925 underlying localtime representation. Don't use asctime, as it
3926 has undefined behavior for years outside the range -999..9999.
3928 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3930 Fix race conditions involving setenv, gmtime, localtime, asctime.
3931 Without this fix, interrupts could mess up code that uses these
3932 nonreentrant functions, since setting TZ invalidates existing
3933 tm_zone or tzname values, and since most of these functions return
3934 pointers to static storage.
3935 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3936 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3937 Grow the critical sections to include not just invoking
3938 localtime/gmtime, but also accessing these functions' results
3939 including their tm_zone values if any, and any related TZ setting.
3940 (format_time_string): Last arg is now struct tm *, not struct tm **,
3941 so that the struct tm is saved in the critical section.
3942 All callers changed. Simplify allocation of initial buffer, partly
3943 motivated by the fact that memory allocation needs to be outside
3944 the critical section.
3946 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3948 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3949 with RESET_INTERVAL.
3951 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3952 Remove duplicated buffer name initialization.
3954 2012-05-02 Jim Meyering <jim@meyering.net>
3956 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3958 * xfns.c (x_window): Use xstrdup (Bug#11375).
3960 2012-05-02 Eli Zaretskii <eliz@gnu.org>
3962 * xdisp.c (pos_visible_p): If already at a newline from the
3963 display string before the 'while' loop, don't walk back the glyphs
3964 from it3.glyph_row. Solves assertion violation when the display
3965 string begins with a newline (egg.el). (Bug#11367)
3967 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3969 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3972 2012-05-01 Glenn Morris <rgm@gnu.org>
3974 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3975 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3976 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3977 All were removed before 23.1.
3979 * dispnew.c: Remove HAVE_LIBNCURSES test;
3980 it is always true on relevant platforms.
3982 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3983 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3985 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3987 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3989 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3990 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3993 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3995 Do not avoid creating empty evaporating overlays (Bug#9642).
3996 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3997 That is, do not delete an evaporating overlay if it becomes
3998 empty after its bounds are adjusted to fit within its buffer.
3999 This fix caused other problems, and I'm reverting it until we get
4000 to the bottom of them.
4002 2012-04-27 Chong Yidong <cyd@gnu.org>
4004 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4006 2012-04-27 Eli Zaretskii <eliz@gnu.org>
4008 * xdisp.c (pos_visible_p): If the window start position is beyond
4009 ZV, start the display from buffer beginning. Prevents assertion
4010 violation in init_iterator when the minibuffer window is scrolled
4013 * window.c (window_scroll_pixel_based): Likewise.
4015 2012-04-27 Chong Yidong <cyd@gnu.org>
4017 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4019 2012-04-27 Glenn Morris <rgm@gnu.org>
4021 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4022 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4024 2012-04-27 Eli Zaretskii <eliz@gnu.org>
4026 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4027 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
4029 2012-04-26 Eli Zaretskii <eliz@gnu.org>
4031 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4032 display element, check also the underlying string or buffer
4033 character. (Bug#11341)
4035 * w32menu.c: Include w32heap.h.
4036 (add_menu_item): If the call to AppendMenuW (via
4037 unicode_append_menu) fails, disable Unicode menus only if we are
4038 running on Windows 9X/Me.
4040 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4042 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4043 (xgetint): Add missing shift for LSB tags.
4045 2012-04-24 Martin Rudalics <rudalics@gmx.at>
4047 * keyboard.c (read_char): Don't wipe echo area for select window
4048 events: These might get delayed via `mouse-autoselect-window'
4051 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
4053 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4054 manipulation of :loaded-from data.
4056 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
4058 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4059 now a cons (bug#11311).
4061 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4063 Do not create empty overlays with the evaporate property (Bug#9642).
4064 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4065 if it becomes empty after its bounds are adjusted to fit within
4066 its buffer. Without this fix, in a nonempty buffer (let ((o
4067 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4068 yields an empty overlay that has the evaporate property, which is
4069 not supposed to happen.
4071 Fix minor GTK3 problems found by static checking.
4072 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4073 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4074 (struct _EmacsFixedClass, emacs_fixed_get_type):
4075 Move decls here from emacsgtkfixed.h, since they needn't be public.
4076 (emacs_fixed_get_type): Now static.
4077 (emacs_fixed_class_init): Omit unused local.
4078 (emacs_fixed_child_type): Remove; unused.
4079 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4080 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4081 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4082 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4083 (EMACS_FIXED_GET_CLASS): Remove; unused.
4084 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4086 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4087 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4089 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4091 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
4092 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
4093 (__malloc_size_t, __malloc_ptrdiff_t):
4094 Remove. All uses removed, replaced by the definiens if needed,
4095 since we can assume C89 or better now.
4096 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4097 (protect_malloc_state, align, get_contiguous_space)
4098 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4099 (malloc_atfork_handler_child, malloc_enable_thread)
4100 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4101 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4102 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4103 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4104 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4105 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4106 Define using prototypes, not old style.
4107 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4108 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4109 (align): Don't assume that signed integer overflow wraps around.
4110 Omit unused local var.
4111 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4112 (_free_internal_nolock, memalign, mallochook, reallochook):
4113 Omit no-longer-needed casts.
4114 (valloc): Use getpagesize, not __getpagesize.
4115 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4116 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4118 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4120 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
4122 Move functions from C to Lisp. Make non-blocking method calls
4123 the default. Implement further D-Bus standard interfaces.
4125 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4126 (QCdbus_request_name_allow_replacement)
4127 (QCdbus_request_name_replace_existing)
4128 (QCdbus_request_name_do_not_queue)
4129 (QCdbus_request_name_reply_primary_owner)
4130 (QCdbus_request_name_reply_in_queue)
4131 (QCdbus_request_name_reply_exists)
4132 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4133 (QCdbus_registered_serial, QCdbus_registered_method)
4134 (QCdbus_registered_signal): New Lisp objects.
4135 (XD_DEBUG_MESSAGE): Use sizeof.
4136 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4137 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4138 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4139 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4140 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4141 (xd_signature, xd_append_arg): Allow float for integer types.
4142 (xd_get_connection_references): New function.
4143 (xd_get_connection_address): Rename from xd_initialize.
4144 Return cached address.
4145 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4146 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4148 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
4149 Return number of refcounts.
4150 (Fdbus_get_unique_name): Make stronger parameter check.
4151 (Fdbus_message_internal): New defun.
4152 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4153 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4154 (Fdbus_send_signal, Fdbus_register_service)
4155 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4156 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4157 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4158 (Vdbus_compiled_version, Vdbus_runtime_version)
4159 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4160 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4161 (Vdbus_message_type_signal): New defvars.
4162 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4165 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4167 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4168 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4169 Do not assume ptrdiff_t is the same width as 'int'.
4171 * alloc.c: Handle unusual debugging option combinations.
4172 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4173 since the two debugging options are incompatible.
4174 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4176 (mem_init, mem_insert, mem_insert_fixup):
4177 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4178 (NEED_MEM_INSERT): Remove; no longer needed.
4180 2012-04-22 Leo Liu <sdl.web@gmail.com>
4182 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4184 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4186 * sysdep.c [__FreeBSD__]: Minor cleanups.
4187 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4188 Use Emacs indenting style more consistently. Avoid some casts.
4189 Use 'double' consistently rather than mixing 'float' and 'double'.
4191 2012-04-21 Eduard Wiebe <usenet@pusto.de>
4193 * sysdep.c (list_system_processes, system_process_attributes):
4194 Add implementation for FreeBSD (Bug#5243).
4196 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4198 * lisp.mk (lisp): Update.
4200 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4202 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4203 It is never used otherwise.
4205 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4207 * print.c (print_preprocess): Only check print_depth if print-circle
4209 (print_object): Check for cycles even when print-circle is nil and
4210 print-gensym is t, but only check print_depth if print-circle is nil.
4212 2012-04-20 Chong Yidong <cyd@gnu.org>
4214 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4215 set the status to "failed" and ensure that sentinel is run.
4217 2012-04-20 Glenn Morris <rgm@gnu.org>
4219 * process.c (Fset_process_inherit_coding_system_flag)
4220 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4221 (Fmake_network_process, Fmake_serial_process): Doc fix.
4223 2012-04-20 Eli Zaretskii <eliz@gnu.org>
4225 * xdisp.c (string_buffer_position_lim): Limit starting position to
4227 (set_cursor_from_row): If called for a mode-line or header-line
4228 row, return zero immediately.
4229 (try_cursor_movement): If inside continuation line, don't back up
4230 farther than the first row after the header line, if any.
4231 Don't consider the header-line row as "partially visible", even if
4232 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4234 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
4236 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4239 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
4240 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
4242 configure: new option --enable-gcc-warnings (Bug#11207)
4243 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4244 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4245 (ALL_CFLAGS): Use new macros rather than old.
4246 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4247 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4248 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4249 -Wunused-result, -Wunused-variable. This should go away once
4250 the Emacs and Gnulib regex code is merged.
4251 (xmalloc, xrealloc): Now static.
4253 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4255 * dired.c (Fsystem_groups): Remove unused local.
4257 2012-04-17 Glenn Morris <rgm@gnu.org>
4259 * dired.c (Fsystem_users): Doc fix.
4261 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4263 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4264 (syms_of_dired): Add them.
4266 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4268 Fix minor alloc.c problems found by static checking.
4269 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4270 New extern decls, to avoid calling undeclared functions.
4271 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4272 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4273 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4274 (NEED_MEM_INSERT): New macro.
4275 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4276 Remove one incorrect comment and fix another.
4278 Fix minor ralloc.c problems found by static checking.
4279 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4280 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4281 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4282 (r_alloc_sbrk): Now static.
4284 Improve ralloc.c interface checking.
4285 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4286 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4287 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4288 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4289 [REL_ALLOC]: ... to here, to check interface.
4290 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4291 Remove decls. This fixes an "It stinks!".
4293 * alloc.c (which_symbols): Fix alignment issue / type clash.
4295 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4297 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4298 (struct Lisp_Misc_Any): Likewise.
4299 (struct Lisp_Free): Likewise.
4300 * alloc.c (union aligned_Lisp_Symbol): Define.
4301 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4302 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4303 (union aligned_Lisp_Misc): Define.
4304 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4305 aligned_Lisp_Misc instead of union Lisp_Misc.
4306 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
4308 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4310 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4311 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4312 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4313 * s/netbsd.h, s/sol2-6.h:
4314 Remove definition of GC_MARK_STACK, since the default now works.
4315 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4316 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4317 no longer the default.
4318 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4320 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
4322 * lread.c (lisp_file_lexically_bound_p):
4323 Fix hang at ";-*-\n" (bug#11238).
4325 2012-04-14 Eli Zaretskii <eliz@gnu.org>
4327 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4328 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4330 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4332 * nsterm.m (constrainFrameRect): Always constrain when there is only
4333 one screen (Bug#10962).
4335 2012-04-13 Ken Brown <kbrown@cornell.edu>
4337 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4339 2012-04-13 Reuben Thomas <rrt@sc3d.org>
4341 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4343 2012-04-11 Daniel Colascione <dancol@dancol.org>
4345 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4346 against is gone. It's better to use vfork now so that when Cygwin
4347 gains a new, working vfork, we use it automatically (bug#10398).
4349 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4351 * window.c (save_window_save): Obey window-point-insertion-type.
4353 2012-04-11 Glenn Morris <rgm@gnu.org>
4355 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4357 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4359 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4361 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
4363 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4364 (force_quit_count): New var.
4365 (handle_interrupt): Use it.
4367 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
4369 * w32.c (w32_delayed_load): Record the full path of the library
4370 being loaded (bug#10424).
4372 2012-04-09 Glenn Morris <rgm@gnu.org>
4374 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4375 not just in the obarray, before snarfing them. (Bug#11036)
4377 * Makefile.in ($(leimdir)/leim-list.el):
4378 Pass EMACS rather than BUILT_EMACS.
4380 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4382 * process.c (make_process):
4383 * process.h: Add integer `gnutls_handshakes_tried' member to
4386 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4387 Add convenience `GNUTLS_LOG2i' macro.
4389 * gnutls.c (gnutls_log_function2i): Convenience log function.
4390 (emacs_gnutls_read): Use new log functions,
4391 `gnutls_handshakes_tried' process member, and
4392 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4393 attempts per process (connection).
4395 2012-04-09 Chong Yidong <cyd@gnu.org>
4397 * eval.c (Fuser_variable_p, user_variable_p_eh)
4398 (lisp_indirect_variable): Functions deleted.
4399 (Fdefvar): Caller changed.
4401 * callint.c (Finteractive, Fcall_interactively):
4402 * minibuf.c (Fread_variable): Callers changed.
4404 2012-04-09 Eli Zaretskii <eliz@gnu.org>
4406 * xdisp.c (set_cursor_from_row): If the display string appears in
4407 the buffer at position that is closer to point than the position
4408 after the display string, display the cursor on the first glyph of
4409 the display string. Fixes cursor display when a 'display' text
4410 property immediately follows invisible text. (Bug#11094)
4412 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4414 composite.c: use 'double' consistently
4415 * composite.c (get_composition_id): Use 'double' consistently
4416 instead of converting 'float' to 'double' and vice versa; this is
4417 easier to understand and avoids a GCC warning.
4419 2012-04-09 Glenn Morris <rgm@gnu.org>
4421 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4422 preparation for dumping it with emacs. (Bug#4789)
4423 (leimdir): New variable.
4424 ($(leimdir)/leim-list.el): New rule.
4425 (emacs$(EXEEXT)): Depend on leim-list.el.
4427 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4428 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4429 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4431 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4433 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4436 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
4438 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4439 Remove unused local variable.
4441 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4443 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4444 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4445 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4446 objects, as mark_maybe_pointer will catch them otherwise.
4447 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4448 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4450 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4452 Fix typo that broke non-Windows builds.
4453 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4455 2012-04-07 Eli Zaretskii <eliz@gnu.org>
4457 Support building on MS-Windows with libxml2.
4459 * makefile.w32-in (OBJ2): Add xml.$(O).
4460 (GLOBAL_SOURCES): Add xml.c.
4461 ($(BLD)/xml.$(O)): New dependency list.
4463 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4464 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4465 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4466 [!WINDOWSNT]: New macros.
4467 (init_libxml2_functions, libxml2_loaded_p): New functions.
4468 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4469 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4470 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4471 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4473 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4474 Call init_libxml2_functions before calling libxml2 functions.
4475 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4477 * emacs.c: Don't include libxml/parser.h.
4478 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4479 xmlCleanupParser directly.
4481 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4483 2012-04-07 Eli Zaretskii <eliz@gnu.org>
4485 * indent.c (Fvertical_motion): If there is a display string at
4486 point, use it.vpos to compute how many lines to backtrack after
4487 move_it_to point. (Bug#11133)
4489 2012-04-06 Eli Zaretskii <eliz@gnu.org>
4491 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4492 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4493 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4494 macros related to unification of CJK characters. For the details,
4495 see the discussion following the message here:
4496 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4498 2012-04-04 Chong Yidong <cyd@gnu.org>
4500 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4502 2012-04-01 Eli Zaretskii <eliz@gnu.org>
4504 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4505 instead of alloca. (Bug#11138)
4507 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4509 * w32menu.c (is_simple_dialog): Properly check lisp types.
4512 2012-03-31 Eli Zaretskii <eliz@gnu.org>
4514 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4515 position we get to after a call to move_it_to fails the
4516 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4517 only if we wind up in a string from display property. (Bug#11063)
4519 * window.c (Fdelete_other_windows_internal): Invalidate the row
4520 and column information about mouse highlight, so that redisplay
4521 restores it after reallocating the glyph matrices. (Bug#7464)
4523 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4524 string comes from a `display' text property, use the buffer
4525 position of that property as if we actually saw that position in
4527 (move_it_by_lines): Remove the assertion that
4528 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4529 violated when there's a before-string at the beginning of a line.
4532 2012-03-30 Eli Zaretskii <eliz@gnu.org>
4534 * xdisp.c (append_space_for_newline): If the default face was
4535 remapped, use the remapped face for the appended newline.
4536 (extend_face_to_end_of_line): Use the remapped default face for
4537 extending the face to the end of the line.
4538 (display_line): Call extend_face_to_end_of_line when the default
4539 face was remapped. (Bug#11068)
4541 2012-03-29 Eli Zaretskii <eliz@gnu.org>
4543 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4545 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4547 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4549 2012-03-27 Glenn Morris <rgm@gnu.org>
4551 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4554 2012-03-26 Kenichi Handa <handa@m17n.org>
4556 * dispextern.h (struct glyph): Fix previous change. Change the
4557 bit length of glyphless.ch to 25 (Bug#11082).
4559 2012-03-26 Chong Yidong <cyd@gnu.org>
4561 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4562 (command_loop_1): Use it; inhibit selection update for
4563 handle-select-window too (Bug#8996).
4565 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4567 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
4569 2012-03-25 Kenichi Handa <handa@m17n.org>
4571 * dispextern.h (struct glyph): Change the bit length of
4572 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4574 2012-03-24 Eli Zaretskii <eliz@gnu.org>
4576 * s/ms-w32.h (tzname): Include time.h before redirecting to
4577 _tzname. Fixes the MSVC build. (Bug#9960)
4579 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4581 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4584 * xterm.c (XTread_socket): Only modify handling_signal if
4585 !SYNC_INPUT. (Bug#11080)
4587 2012-03-23 Eli Zaretskii <eliz@gnu.org>
4589 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4590 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4591 when fetching a multibyte character consumes more bytes than
4592 CHAR_BYTES returns, due to unification of CJK characters in
4593 string_char. (Bug#11073)
4595 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4597 * process.c (wait_reading_process_output): Handle pty disconnect
4598 by refraining from sending oneself a SIGCHLD (bug#10933).
4600 2012-03-22 Chong Yidong <cyd@gnu.org>
4602 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4604 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
4605 Mark string as coming from a prefix property.
4606 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4607 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4609 2012-03-21 Chong Yidong <cyd@gnu.org>
4611 * xfaces.c (Vface_remapping_alist): Doc fix.
4613 2012-03-20 Eli Zaretskii <eliz@gnu.org>
4615 * w32proc.c (Fw32_set_console_codepage)
4616 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4619 2012-03-20 Chong Yidong <cyd@gnu.org>
4621 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4622 to reflect default non-nil value of redisplay-dont-pause.
4624 2012-03-19 Kenichi Handa <handa@m17n.org>
4626 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4627 it fit in a valid range (Bug#11003).
4629 2012-03-18 Eli Zaretskii <eliz@gnu.org>
4631 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4632 that is not from display property, accept the row as a "cursor
4633 row" if one of the string's character has a non-nil `cursor'
4634 property. Fixes cursor positioning when there are newlines in
4635 overlay strings, e.g. in icomplete.el. (Bug#11035)
4637 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4639 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4641 2012-03-12 Chong Yidong <cyd@gnu.org>
4643 * eval.c (inhibit_lisp_code): Rename from
4644 inhibit_window_configuration_change_hook; move from window.c.
4646 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4647 * window.c (run_window_configuration_change_hook)
4648 (syms_of_window): Callers changed.
4650 2012-03-11 Chong Yidong <cyd@gnu.org>
4652 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4654 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4656 2012-03-10 Chong Yidong <cyd@gnu.org>
4658 * frame.c (other_visible_frames): Don't assume the selected frame
4659 is visible (Bug#10955).
4661 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4663 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4665 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4667 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4668 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4671 2012-03-03 Glenn Morris <rgm@gnu.org>
4673 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
4675 2012-03-02 Eli Zaretskii <eliz@gnu.org>
4677 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4678 position past the first glyph_row that ends at ZV. (Bug#10902)
4679 (redisplay_window, next_element_from_string): Fix typos in
4681 (redisplay_window): Pass to move_it_vertically the margin in
4682 pixels, not in screen lines.
4684 2012-03-02 Glenn Morris <rgm@gnu.org>
4686 * buffer.c (buffer-list-update-hook): Doc fix.
4688 2012-02-29 Eli Zaretskii <eliz@gnu.org>
4690 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4691 push_it before setting up the iterator for the first overlay
4692 string, even if we have an empty string loaded.
4693 (next_overlay_string): If there's an empty string on the iterator
4694 stack, pop the stack. (Bug#10903)
4696 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4698 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4699 Suggested by Stefan Monnier in
4700 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4701 * alloc.c (widen_to_Lisp_Object): New static function.
4702 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4703 and widening them to Lisp_Objects. This would work even if
4704 USE_LSB_TAG is defined and wide integers are used, which might
4705 happen in a future version of Emacs.
4707 2012-02-25 Chong Yidong <cyd@gnu.org>
4709 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4712 * xselect.c (Fx_selection_exists_p): Doc fix.
4713 (x_clipboard_manager_save_all): Print an informative message
4714 before saving to clipboard manager.
4716 2012-02-24 Chong Yidong <cyd@gnu.org>
4718 * keyboard.c (process_special_events): Handle all X selection
4719 requests in kbd_buffer, not just the next one (Bug#8869).
4721 2012-02-23 Chong Yidong <cyd@gnu.org>
4723 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4724 call when setting menu-bar-lines and tool-bar-lines parameters.
4725 (unwind_create_frame_1): New helper function.
4727 * window.c (inhibit_window_configuration_change_hook): New var.
4728 (run_window_configuration_change_hook): Obey it.
4729 (syms_of_window): Initialize it.
4731 2012-02-22 Chong Yidong <cyd@gnu.org>
4733 * xterm.c (x_draw_image_relief): Add missing type check for
4734 Vtool_bar_button_margin (Bug#10743).
4736 2012-02-21 Chong Yidong <cyd@gnu.org>
4738 * fileio.c (Vfile_name_handler_alist): Doc fix.
4740 * buffer.c (Fget_file_buffer): Protect against invalid file
4741 handler return value.
4743 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4745 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4746 when computing $valmask.
4748 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4749 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4750 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4751 It's useless in that case, and it can cause problems on hosts
4752 that allocate halves of EMACS_INT values separately.
4753 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4754 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4755 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4756 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4757 it avoids undefined behavior on hosts where shifting right by more
4758 than the word width has undefined behavior.
4760 2012-02-19 Chong Yidong <cyd@gnu.org>
4762 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4763 (Funhandled_file_name_directory, Ffile_name_as_directory)
4764 (Fdirectory_file_name, Fexpand_file_name)
4765 (Fsubstitute_in_file_name): Protect against invalid file handler
4766 return values (Bug#10845).
4768 2012-02-18 Eli Zaretskii <eliz@gnu.org>
4770 * .gdbinit (pitx): Fix incorrect references to fields of the
4773 2012-02-17 Chong Yidong <cyd@gnu.org>
4775 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4777 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4779 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4780 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4782 2012-02-15 Chong Yidong <cyd@gnu.org>
4784 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4785 marked as special. Also, starting docstrings with * is obsolete.
4787 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4789 * gnutls.c (emacs_gnutls_write): Fix last change.
4791 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4793 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4796 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4798 * keymap.c (Fsingle_key_description): Handle char ranges.
4800 2012-02-12 Chong Yidong <cyd@gnu.org>
4802 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4803 as that creates a dangerous corner case.
4805 * window.c (Fdelete_window_internal): Invalidate the mouse
4806 highlight (Bug#9904).
4808 2012-02-12 Glenn Morris <rgm@gnu.org>
4810 * xselect.c (Fx_own_selection_internal)
4811 (Fx_get_selection_internal, Fx_disown_selection_internal)
4812 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4813 * nsselect.m (Fx_own_selection_internal)
4814 (Fx_disown_selection_internal, Fx_selection_exists_p)
4815 (Fx_selection_owner_p, Fx_get_selection_internal):
4816 Sync docs and argument specs with the xselect.c versions.
4818 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4820 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4822 2012-02-11 Eli Zaretskii <eliz@gnu.org>
4824 * w32select.c (Fx_selection_exists_p): Sync doc string and
4825 argument list with xselect.c. (Bug#10783)
4827 * w16select.c (Fx_selection_exists_p): Sync doc string and
4828 argument list with xselect.c. (Bug#10783)
4830 2012-02-10 Glenn Morris <rgm@gnu.org>
4832 * fns.c (Fsecure_hash): Doc fix.
4834 2012-02-09 Kenichi Handa <handa@m17n.org>
4836 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4838 2012-02-07 Chong Yidong <cyd@gnu.org>
4840 * buffer.c (Fbuffer_local_variables)
4841 (buffer_lisp_local_variables): Handle unbound vars correctly;
4842 don't let Qunbound leak into Lisp.
4844 2012-02-07 Glenn Morris <rgm@gnu.org>
4846 * image.c (Fimagemagick_types): Doc fix.
4848 * image.c (imagemagick-render-type): Change it from a lisp object
4849 to an integer. Move the doc here from the lisp manual.
4850 Treat all values not equal to 0 the same.
4852 2012-02-06 Chong Yidong <cyd@gnu.org>
4854 * doc.c (store_function_docstring): Avoid applying docstring of
4855 alias to base function (Bug#2603).
4857 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4859 * .gdbinit (pp1, pv1): Remove redundant defines.
4862 2012-02-04 Chong Yidong <cyd@gnu.org>
4864 * nsterm.m: Declare a global (Bug#10694).
4866 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4868 * w32.c (get_emacs_configuration_options):
4869 Include --enable-checking, if specified, in the return value.
4871 2012-02-04 Martin Rudalics <rudalics@gmx.at>
4873 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4874 after rounding frame sizes. (Bug#9723)
4876 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4878 * keyboard.c (adjust_point_for_property): Don't position point
4879 before BEGV. (Bug#10696)
4881 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4883 Handle overflow when computing char display width (Bug#9496).
4884 * character.c (char_width): Return EMACS_INT, not int.
4885 (char_width, c_string_width): Check for overflow when
4886 computing the width; this is possible now that individual
4887 characters can have unbounded width. Problem introduced
4888 by merge from Emacs 23 on 2012-01-19.
4890 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
4892 * dbusbind.c (Fdbus_register_method): Mention the return value
4893 :ignore in the docstring.
4895 2012-02-02 Glenn Morris <rgm@gnu.org>
4897 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4899 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4900 Unconditionally set to t. (Bug#10673)
4901 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4902 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4903 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4905 2012-02-02 Kenichi Handa <handa@m17n.org>
4907 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4908 0, do not call append_composite_glyph.
4910 2012-02-02 Kenichi Handa <handa@m17n.org>
4912 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4914 (x_produce_glyphs): If the component of a composition is a null
4915 string, set it->pixel_width to 1 to avoid zero-width glyph.
4917 2012-02-01 Eli Zaretskii <eliz@gnu.org>
4919 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4920 first 2 arguments are identical. This makes inserting large
4921 output from a subprocess an order of magnitude faster on
4922 MS-Windows, where all sbrk'ed memory is always contiguous.
4924 2012-01-31 Glenn Morris <rgm@gnu.org>
4926 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4927 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4928 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4930 2012-01-29 Glenn Morris <rgm@gnu.org>
4932 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4934 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4936 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4938 2012-01-28 Chong Yidong <cyd@gnu.org>
4940 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4942 2012-01-26 Chong Yidong <cyd@gnu.org>
4944 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4946 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4947 repeat counts (Bug#10507).
4949 2012-01-26 Glenn Morris <rgm@gnu.org>
4951 * lread.c (syms_of_lread): Doc fix.
4953 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4955 * coding.c (encode_designation_at_bol): Change return value to
4958 2012-01-25 Chong Yidong <cyd@gnu.org>
4960 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4962 2012-01-21 Chong Yidong <cyd@gnu.org>
4964 * floatfns.c (Fcopysign): Make the second argument non-optional,
4965 since nil is not allowed anyway.
4967 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4969 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4970 (send_process): Likewise.
4972 2012-01-19 Martin Rudalics <rudalics@gmx.at>
4974 * window.c (save_window_save, Fcurrent_window_configuration)
4975 (Vwindow_persistent_parameters): Do not use Qstate.
4976 Rewrite doc-strings.
4978 2012-01-19 Kenichi Handa <handa@m17n.org>
4980 * character.c (char_width): New function.
4981 (Fchar_width, c_string_width, lisp_string_width):
4982 Use char_width (Bug#9496).
4984 2012-01-16 Martin Rudalics <rudalics@gmx.at>
4986 * window.c (Vwindow_persistent_parameters): New variable.
4987 (Fset_window_configuration, save_window_save): Handle persistent
4990 2012-01-14 Eli Zaretskii <eliz@gnu.org>
4992 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4993 thrashing the stack of the thread. (Bug#9087)
4995 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4997 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4999 2012-01-11 Eli Zaretskii <eliz@gnu.org>
5001 * xdisp.c (rows_from_pos_range): Handle the case where the
5002 highlight ends on a newline. (Bug#10464)
5003 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5004 he end column for display of highlight that ends on a newline
5007 2012-01-11 Glenn Morris <rgm@gnu.org>
5009 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5010 from load-path also when installation-directory is nil. (Bug#10208)
5012 2012-01-10 Glenn Morris <rgm@gnu.org>
5014 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5016 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5017 Update template values to be closer to their typical values these days.
5019 2012-01-09 Eli Zaretskii <eliz@gnu.org>
5021 * xdisp.c (rows_from_pos_range): Accept additional argument
5022 DISP_STRING, and accept any glyph in a row whose object is that
5023 string as eligible for mouse highlight. Fixes mouse highlight of
5024 display strings from overlays. (Bug#10464)
5026 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
5028 emacs: fix an auto-save permissions race condition (Bug#10400)
5029 * fileio.c (auto_saving_dir_umask): New static var.
5030 (Fmake_directory_internal): Use it.
5031 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5032 creating the directory. The old code temporarily assigns
5033 too-generous permissions to the directory.
5034 (do_auto_save_eh): Clear it.
5035 (Fdo_auto_save): Catch all errors, not just file errors, so
5036 that the var is always cleared.
5038 2012-01-07 Eli Zaretskii <eliz@gnu.org>
5040 * search.c (scan_buffer): Pass character positions to
5041 know_region_cache, not byte positions. (Bug#6540)
5043 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
5045 * w32.c (sys_rename): Report EXDEV when rename of a directory
5046 fails because the target is on another logical disk. (Bug#10284)
5048 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5050 * xterm.c (x_embed_request_focus): New function.
5052 * xterm.h: Add prototype.
5054 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5056 2012-01-05 Glenn Morris <rgm@gnu.org>
5058 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5060 2012-01-01 Eli Zaretskii <eliz@gnu.org>
5062 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5063 Load gnutls_transport_set_lowat only if GnuTLS version is below
5065 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5066 GnuTLS versions below 2.11.1.
5068 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5070 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5071 to the doc string advising against its use for altering the way
5072 windows are scrolled.
5074 2011-12-28 Kenichi Handa <handa@m17n.org>
5076 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5077 coding-system ASCII compatible only when it does not produce BOM
5078 on encoding (Bug#10383).
5080 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5082 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5084 (create_and_show_popup_menu): Always use menu_position_func for
5087 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5089 * callint.c (Fcall_interactively): Don't truncate prompt string.
5091 2011-12-23 Eli Zaretskii <eliz@gnu.org>
5093 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5094 property that ends at ZV, so that the bidi iteration could be
5095 resumed from there (after widening). (Bug#10360)
5097 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5099 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5101 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5103 * nsterm.m (x_free_frame_resources):
5104 Release f->output_data.ns->miniimage.
5105 (ns_index_color): Fix indentation. Do not retain
5106 color_table->colors[i].
5108 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5111 * nsfns.m (x_set_background_color): Assign return value from
5112 ns_index_color to face-background instead of NSColor*.
5113 (ns_implicitly_set_icon_type): Fix indentation.
5114 Change assignment in for loop to comparison.
5116 * emacs.c (ns_pool): New variable.
5117 (main): Assign ns_pool.
5118 (Fkill_emacs): Call ns_release_autorelease_pool.
5120 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5121 autorelease fdesc, release fdAttrs and tdict.
5122 (ns_get_covering_families): Release charset.
5123 (ns_findfonts): Release NSFontDescriptor created with new.
5124 (ns_uni_to_glyphs): Fix indentation.
5125 (setString): Release attrStr before assigning new value.
5127 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5129 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5131 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5132 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5134 2011-12-18 David Reitter <reitter@cmu.edu>
5136 * nsterm.m (ns_term_init): Subscribe for notifications
5137 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5138 to method trackingNotification in EmacsMenu.
5140 * nsmenu.m (trackingMenu): New variable.
5141 (trackingNotification): New method (from Aquamacs).
5142 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
5143 from Aquamacs (Bug#7030).
5145 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5147 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5148 (symbol_to_nsstring): Fix indentation.
5149 (ns_symbol_to_pb): New function.
5150 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5151 (Fns_rotate_cut_buffers_internal): Remove.
5152 (Fns_store_selection_internal): Rename from
5153 Fns_store_cut_buffer_internal.
5154 (ns_get_foreign_selection, Fx_own_selection_internal)
5155 (Fx_disown_selection_internal, Fx_selection_exists_p)
5156 (Fns_get_selection_internal, Fns_store_selection_internal):
5157 Use ns_symbol_to_pb and check if return value is nil.
5158 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5159 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
5160 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5161 renamed to Sns_store_selection_internal.
5162 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5163 and remove this function.
5164 (ns_handle_selection_clear): Remove, never used.
5165 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5168 2011-12-17 Ken Brown <kbrown@cornell.edu>
5170 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5171 GID is unknown (Bug#10257).
5173 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5175 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5176 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5177 which caused a build failure on GNU/Linux IA-64. This problem was
5178 introduced by my 2011-10-07 patch.
5180 2011-12-15 Juri Linkov <juri@jurta.org>
5182 * image.c (imagemagick_error): New function. (Bug#10112)
5183 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5184 Use `imagemagick_error' where ImageMagick functions return
5186 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5189 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5191 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5192 fill background (Bug#8992).
5194 2011-12-13 Martin Rudalics <rudalics@gmx.at>
5196 * window.c (Vwindow_combination_resize)
5197 (Vwindow_combination_limit): Use t instead of non-nil in
5199 (Vrecenter_redisplay): Add first sentence of doc-string on
5201 (Frecenter): Fix doc-string typo.
5203 2011-12-11 Kenichi Handa <handa@m17n.org>
5205 * coding.c (Funencodable_char_position): Pay attention to the
5206 buffer text relocation (Bug#9389).
5208 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5210 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5211 gtk_init (Bug#10100).
5213 2011-12-10 Eli Zaretskii <eliz@gnu.org>
5215 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5216 IT->string is nil. (Bug#10263)
5218 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5220 * nsterm.h (x_free_frame_resources): Declare.
5222 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5223 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5225 * nsterm.h (ns_get_defaults_value): Declare.
5227 * nsterm.m (ns_default): Call ns_get_defaults_value.
5229 2011-12-09 Eli Zaretskii <eliz@gnu.org>
5231 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5234 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5236 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5237 that where the value of an _OBJC_* symbol points to is in the .bss
5238 section (Bug#10240).
5240 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5242 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
5243 after the loop to call ccl_driver at least once (Bug#8619).
5245 2011-12-08 Kenichi Handa <handa@m17n.org>
5247 * ftfont.c (get_adstyle_property): Fix previous change
5250 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
5252 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5253 dirs from the default value of EMACSLOADPATH (bug#10208).
5255 2011-12-07 Glenn Morris <rgm@gnu.org>
5257 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5258 installation and source directories as well. (Bug#10208)
5260 2011-12-06 Chong Yidong <cyd@gnu.org>
5262 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5264 2011-12-06 Glenn Morris <rgm@gnu.org>
5266 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5267 as an error, not just -1. (Bug#10217)
5269 2011-12-05 Chong Yidong <cyd@gnu.org>
5271 * keyboard.c (process_special_events): New function.
5272 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5274 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5276 * coding.c (encode_designation_at_bol): Don't use uninitialized
5277 local variable (Bug#9318).
5279 2011-12-05 Kenichi Handa <handa@m17n.org>
5281 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5282 return Qnil (Bug#8046, Bug#10193).
5284 2011-12-05 Kenichi Handa <handa@m17n.org>
5286 * coding.c (encode_designation_at_bol): New args charbuf_end and
5287 dst. Return the number of produced bytes. Callers changed.
5288 (coding_set_source): Return how many bytes coding->source was
5290 (coding_set_destination): Return how many bytes
5291 coding->destination was relocated.
5292 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
5293 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5295 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5297 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5298 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5301 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5303 The following changes are to fix Bug#9318.
5305 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5306 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5307 (encode_coding_iso_2022, encode_coding_sjis)
5308 (encode_coding_big5, encode_coding_charset): Use the above macros.
5310 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
5312 * lisp.h (process_quit_flag): Fix external declaration.
5314 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5316 Don't macro-inline non-performance-critical code.
5317 * eval.c (process_quit_flag): New function.
5318 * lisp.h (QUIT): Use it.
5320 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5322 * nsfns.m (get_geometry_from_preferences): New function.
5323 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5325 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5327 * emacs.c (Qkill_emacs): Define.
5328 (syms_of_emacs): Initialize it.
5329 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5330 Qquit_flag to `kill-emacs' instead.
5331 (quit_throw_to_read_char): Add parameter `from_signal'.
5332 All callers changed. Call Fkill_emacs if requested and safe.
5333 * lisp.h (QUIT): Call Fkill_emacs if requested.
5335 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5337 * widget.c (update_wm_hints): Return if wmshell is null.
5338 (widget_update_wm_size_hints): New function.
5340 * widget.h (widget_update_wm_size_hints): Declare.
5342 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5343 widget_update_wm_size_hints (Bug#10104).
5345 2011-12-03 Eli Zaretskii <eliz@gnu.org>
5347 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5348 before a newline, prepare the bidi iterator for consuming the
5349 newline, and keep the current paragraph direction. (Bug#10183)
5350 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
5352 2011-12-02 Juri Linkov <juri@jurta.org>
5354 * search.c (Fword_search_regexp): New Lisp function created from
5355 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5356 (Fword_search_backward, Fword_search_forward)
5357 (Fword_search_backward_lax, Fword_search_forward_lax):
5358 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5359 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5361 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5363 * fileio.c (Finsert_file_contents): Move after-change-function call
5364 to before the "handled:" label, since all "goto handled" appear in
5365 cases where the *-change-functions have already been properly called
5368 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5370 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5371 waiting for input. (Bug#10169)
5373 2011-11-30 Eli Zaretskii <eliz@gnu.org>
5375 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5376 verifies glyph row's hash code--we have just reallocated the
5377 glyphs, so their contents can be complete garbage. (Bug#10164)
5379 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
5381 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5383 2011-11-30 Eli Zaretskii <eliz@gnu.org>
5385 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5386 attributes are tested _before_ calling verify_row_hash, to protect
5387 against GCC re-ordering of the tests. (Bug#10164)
5389 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5391 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5393 * xterm.c (handle_one_xevent): Only set async_visible and friends
5394 if net_wm_state_hidden_seen is non-zero (Bug#10002)
5395 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
5396 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5398 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5400 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5401 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5402 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5403 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5404 All uses changed to use GCPRO1 etc.
5405 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5406 Revert to old implementation (i.e., before 2011-03-11).
5408 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5410 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5411 of scroll runs so as to avoid assigning disabled bogus rows and
5412 unnecessary graphics copy operations.
5414 2011-11-27 Eli Zaretskii <eliz@gnu.org>
5416 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5417 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5418 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5419 (malloc, free, realloc, calloc): Redirect to e_* only when
5422 * lisp.h (GCTYPEBITS): Move before first use.
5423 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5424 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5425 this macro definition.
5427 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5430 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5432 * gtkutil.c (xg_create_frame_widgets):
5433 Call gtk_window_set_has_resize_grip (FALSE) if that function is
5434 present with Gtk+ 2.0.
5436 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5438 * fileio.c (Finsert_file_contents): Undo previous change; see
5439 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5441 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5443 Rename locals to avoid shadowing.
5444 * fileio.c (Finsert_file_contents):
5445 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5446 * process.c (wait_reading_process_output):
5447 Rename inner 'proc' to 'p' to avoid shadowing.
5448 Indent for consistency with usual Emacs style.
5450 2011-11-25 Eli Zaretskii <eliz@gnu.org>
5452 * xdisp.c (redisplay_window): If cursor row is not fully visible
5453 after recentering, and scroll-conservatively is set to a large
5454 number, scroll window by a few more lines to make the cursor fully
5455 visible and out of scroll-margin. (Bug#10105)
5456 (start_display): Don't move to the next line if the display should
5457 start at a newline that is part of a display vector or an overlay
5460 2011-11-24 Juri Linkov <juri@jurta.org>
5462 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5463 after the `MagickPingImage' call. (Bug#10112)
5465 2011-11-23 Chong Yidong <cyd@gnu.org>
5467 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5469 2011-11-23 Martin Rudalics <rudalics@gmx.at>
5471 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5472 making another buffer current. (Bug#10114)
5474 2011-11-23 Glenn Morris <rgm@gnu.org>
5476 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5478 2011-11-23 Chong Yidong <cyd@gnu.org>
5480 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5481 using it (Bug#5984).
5483 2011-11-22 Eli Zaretskii <eliz@gnu.org>
5485 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5486 and header-lines, as they don't have one computed for them.
5489 * .gdbinit (prow): Make displayed values more self-explaining.
5490 Add row's hash code.
5492 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5494 * process.c (wait_reading_process_output): Fix asynchrounous
5495 GnuTLS socket handling on some versions of the GnuTLS library.
5496 (wait_reading_process_output): Add comment and URL.
5498 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5500 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5502 2011-11-21 Chong Yidong <cyd@gnu.org>
5504 * window.c (Fnext_window, Fprevious_window): Doc fix.
5506 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5508 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5510 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
5512 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5514 2011-11-20 Martin Rudalics <rudalics@gmx.at>
5516 * window.c (Fset_window_combination_limit): Rename argument
5518 (Vwindow_combination_limit): Remove "status" from doc-string.
5520 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5522 * m/ibms390.h: Remove.
5523 * m/ibms390x.h: Don't include "ibms390.h".
5525 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5527 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5528 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5530 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
5532 * casetab.c (Fset_case_table):
5533 * charset.c (Fcharset_after): Fix typos.
5535 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
5537 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5538 Otherwise, valgrind does not work on some platforms.
5539 Problem reported by Andreas Schwab in
5540 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5541 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5542 is set, removing the need for VIRT_ADDRESS_VARIES.
5543 (PURE_P): Use a more-efficient implementation that needs just one
5544 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5545 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5546 to 4 (xorl, subq, cmpq, setbe).
5547 * alloc.c (pure): Always extern now, since that's the
5548 VIRT_ADDR_VARIES behavior.
5549 (PURE_POINTER_P): Use a single comparison, not two, for
5550 consistency with the new puresize.h.
5551 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5552 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5553 Remove VIRT_ADDR_VARIES no longer needed.
5555 2011-11-19 Eli Zaretskii <eliz@gnu.org>
5557 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5558 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5559 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5560 behave as if the cursor position were at the window margin.
5562 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5563 and the cursor position is out of bounds, behave as if the cursor
5564 position were at the window margin. (Bug#10075)
5566 2011-11-18 Chong Yidong <cyd@gnu.org>
5568 * window.c (Fwindow_combination_limit): Make first argument
5569 non-optional, since it is meaningless for live windows like the
5572 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5574 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5576 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5578 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5579 (graft_intervals_into_buffer): Simplify.
5581 2011-11-18 Eli Zaretskii <eliz@gnu.org>
5583 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5584 hash values of the two rows.
5585 (copy_row_except_pointers): Preserve the used[] arrays and the
5586 hash values of the two rows. (Bug#10035)
5587 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
5589 * xdisp.c (row_hash): New function, body extracted from
5590 compute_line_metrics.
5591 (compute_line_metrics): Call row_hash, instead of computing the
5594 * dispnew.c (verify_row_hash): Call row_hash for computing the
5595 hash code of a row, instead of duplicating code from xdisp.c.
5597 * dispextern.h (row_hash): Add prototype.
5599 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5601 * frame.c (delete_frame): Don't delete the terminal when the last
5602 X frame is closed if emacs is built with GTK toolkit.
5604 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
5606 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5608 2011-11-17 Martin Rudalics <rudalics@gmx.at>
5610 * window.c (Vwindow_splits): Rename to
5611 Vwindow_combination_resize. Suggested by Juri Linkov.
5612 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5615 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
5617 * nsfns.m (Fns_font_name):
5618 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
5620 2011-11-16 Martin Rudalics <rudalics@gmx.at>
5622 * window.h (window): Rename slot "nest" to "combination_limit".
5623 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5624 (Fset_window_nest): Rename to Fset_window_combination_limit.
5625 (Vwindow_nest): Rename to Vwindow_combination_limit.
5626 (recombine_windows, make_parent_window, make_window)
5627 (Fsplit_window_internal, saved_window)
5628 (Fset_window_configuration, save_window_save): Rename all
5629 occurrences of window_nest to window_combination_limit.
5631 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
5633 * image.c (imagemagick_load_image): Fix typo.
5635 2011-11-14 Eli Zaretskii <eliz@gnu.org>
5637 * xdisp.c (display_line): Move the call to
5638 highlight_trailing_whitespace before the call to
5639 compute_line_metrics, since the latter needs to see the final
5640 faces of all the glyphs to compute ROW's hash value.
5641 Fixes assertion violations in row_equal_p. (Bug#10035)
5643 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
5645 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5646 just return (bug#10044).
5648 2011-11-12 Eli Zaretskii <eliz@gnu.org>
5650 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5651 with user-defined heap size. Bump the default size of the temacs
5652 heap to 27MB, to avoid memory warning when running temacs.
5653 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5655 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5656 current_matrix and desired_matrix. (Bug#9990)
5657 (verify_row_hash) [XASSERTS]: New function.
5658 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5659 that the hash value of glyph rows is correct.
5661 2011-11-12 Martin Rudalics <rudalics@gmx.at>
5663 * window.h (window): Remove splits slot.
5664 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5665 (Fdelete_other_windows_internal, make_parent_window)
5666 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5667 (Fset_window_configuration, save_window_save): Don't deal with
5668 split status of windows.
5669 (saved_window): Remove splits slot.
5670 (Vwindow_splits): Rewrite doc-string.
5672 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5674 * xfns.c (unwind_create_frame):
5675 * nsfns.m (unwind_create_frame):
5676 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5677 Vframe_list (Bug#9999).
5679 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5681 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
5683 2011-11-11 Kenichi Handa <handa@m17n.org>
5685 * callproc.c (Fcall_process): Set the member dst_multibyte of
5688 2011-11-11 Johan Bockgård <bojohan@gnu.org>
5690 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5691 avoid a crash (bug#9496).
5693 2011-11-09 Chong Yidong <cyd@gnu.org>
5695 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5696 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5698 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5700 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5702 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5704 Avoid some portability problems by eschewing 'extern inline' functions.
5705 The trivial performance wins aren't worth the portability hassles; see
5706 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5708 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5709 (window_box_width, window_box_left, window_box_left_offset)
5710 (window_box_right, window_box_right_offset): Undo previous change,
5711 by removing the "extern"s.
5712 * intervals.c (adjust_intervals_for_insertion)
5713 (adjust_intervals_for_deletion): Undo previous change,
5714 making these static again.
5715 (offset_intervals, temp_set_point_both, temp_set_point)
5716 (copy_intervals_to_string): No longer inline.
5717 * xdisp.c (window_text_bottom_y, window_box_width)
5718 (window_box_height, window_box_left_offset)
5719 (window_box_right_offset, window_box_left, window_box_right)
5720 (window_box): No longer inline.
5722 2011-11-08 Chong Yidong <cyd@gnu.org>
5724 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
5725 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5726 Signal an error if not a live window.
5727 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5728 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5730 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
5732 * lisp.h (syms_of_abbrev): Remove declaration.
5733 Reported by CHENG Gao <chenggao@royau.me>.
5735 2011-11-07 Eli Zaretskii <eliz@gnu.org>
5737 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5738 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5739 of temacs in GUI mode.
5741 2011-11-07 Martin Rudalics <rudalics@gmx.at>
5743 * window.h: Declare delete_all_child_windows instead of
5744 delete_all_subwindows.
5745 * window.c (Fwindow_nest, Fset_window_nest)
5746 (Fset_window_new_total, Fset_window_new_normal)
5747 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5748 (delete_all_subwindows): Rename to delete_all_child_windows.
5749 (Fdelete_other_windows_internal, Fset_window_configuration):
5750 Call delete_all_child_windows instead of delete_all_subwindows.
5751 * frame.c (delete_frame): Call delete_all_child_windows instead
5752 of delete_all_subwindows.
5754 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5756 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5757 This is also needed for porting to any host where GC_MARK_STACK is
5758 not GC_MAKE_GCPROS_NOOPS.
5759 (which_symbols): Use it.
5761 2011-11-07 Kenichi Handa <handa@m17n.org>
5763 * coding.c (coding_set_destination): Check coding->src_pos only
5764 when coding->src_object is a buffer (bug#9910).
5766 * process.c (send_process): Set the member src_multibyte of coding
5767 to 0 (bug#9911) when sending a unibyte text.
5769 * callproc.c (Fcall_process): Set the member src_multibyte of
5770 process_coding to 0 (bug#9912).
5772 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5774 * xmenu.c (cleanup_widget_value_tree): New function.
5775 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5776 calling free_menubar_widget_value_tree directly (Bug#9830).
5778 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5780 Fix some portability problems with 'inline'.
5781 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5782 (window_box_width, window_box_left, window_box_left_offset)
5783 (window_box_right, window_box_right_offset): Declare extern.
5784 Otherwise, these inline functions do not conform to C99 and
5785 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5786 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5787 * intervals.c (adjust_intervals_for_insertion)
5788 (adjust_intervals_for_deletion): Now extern, because otherwise the
5789 extern inline functions 'offset_intervals' couldn't refer to it.
5790 (static_offset_intervals): Remove.
5791 (offset_intervals): Rewrite using the old contents of
5792 static_offset_intervals. The old version didn't conform to C99
5793 because an extern inline function contained a reference to an
5794 identifier with static linkage.
5796 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5798 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5801 2011-11-06 Eli Zaretskii <eliz@gnu.org>
5803 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5804 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5805 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5806 return Qleft_to_right.
5808 2011-11-06 Chong Yidong <cyd@gnu.org>
5810 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5811 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5812 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5813 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5814 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5815 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5816 (Fwindow_vscroll): Doc fix.
5817 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5818 argument, since it makes no sense to pass a live window and for
5819 consistency with window-child.
5821 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5823 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5826 2011-11-05 Jason Rumney <jasonr@gnu.org>
5828 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5829 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5831 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5832 bitwise arithmetic preventing use of unicode-sip and non-truetype
5835 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5837 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5840 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5841 initialization code to keep similarity to xfns.c after changes
5844 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5846 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5847 (unwind_create_frame): New function (Bug#9943).
5848 (Fx_create_frame): Restructure code to be more similar to the one in
5849 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5850 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5851 Move terminal->reference_count++ just before making the frame official
5854 * nsterm.m (x_free_frame_resources): New function.
5855 (x_destroy_window): Move code to x_free_frame_resources.
5857 * xfns.c (unwind_create_frame): Fix comment.
5858 (Fx_create_frame, x_create_tip_frame):
5859 Move terminal->reference_count++ just before making the frame
5860 official. Move initialization of image_cache_refcount and
5861 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5863 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5865 Support MSVC build with newer versions of Visual Studio.
5866 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5867 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5870 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5871 which are not supported by MSVC.
5872 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5873 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5875 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5877 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5879 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5881 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
5883 Support MSVC build with newer versions of Visual Studio.
5884 * w32.c: Don't include w32api.h for MSVC.
5885 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5887 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5888 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5889 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5890 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5892 (alloca) [_MSC_VER]: Define to _alloca.
5894 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5896 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5898 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5900 * xdisp.c (note_mouse_highlight): If either of
5901 previous/next-single-property-change returns nil, treat that as
5902 the beginning or the end of the buffer. (Bug#9955)
5904 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5906 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
5907 label is not null (Bug#9951).
5908 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5911 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5913 * window.c (Fwindow_body_size): Mention in the doc string that the
5914 return value is in frame's canonical units. (Bug#9949)
5916 2011-11-03 Eli Zaretskii <eliz@gnu.org>
5918 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5920 * w32fns.c (unwind_create_frame): If needed, free the glyph
5921 matrices of the partially constructed frame. (Bug#9943)
5922 * xfns.c (unwind_create_frame): Likewise.
5924 2011-11-01 Eli Zaretskii <eliz@gnu.org>
5926 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5927 Don't stop backward scan on the continuation glyph, even though
5928 its CHARPOS is positive.
5929 (mouse_face_from_buffer_pos, note_mouse_highlight):
5930 Rename cover_string to disp_string.
5932 2011-11-01 Martin Rudalics <rudalics@gmx.at>
5934 * window.c (temp_output_buffer_show): Don't use
5935 Vtemp_buffer_show_specifiers.
5936 (Vtemp_buffer_show_specifiers): Remove unused variable.
5938 2011-10-30 Eli Zaretskii <eliz@gnu.org>
5940 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5941 past the beginning of the current glyph matrix.
5943 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
5945 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5946 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5947 HAVE_GTK3 (Bug#9869).
5949 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5950 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5952 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5954 * xterm.c: Declare x_handle_net_wm_state to return int.
5955 (handle_one_xevent): Check if we are iconified but don't have
5956 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5957 (get_current_wm_state): Return non-zero if not hidden,
5958 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5959 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5960 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5961 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5963 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5965 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5966 so that this new function doesn't get optimized away by a
5967 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5969 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5971 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5973 2011-10-29 Eli Zaretskii <eliz@gnu.org>
5975 Fix the `xbytecode' command.
5976 * .gdbinit (xprintbytestr): New command.
5977 (xwhichsymbols): Rename from `which'; all callers changed.
5978 (xbytecode): Print the byte-code string as well.
5980 2011-10-29 Kim Storm <storm@cua.dk>
5982 * alloc.c (which_symbols): New function.
5984 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5986 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5989 2011-10-29 Glenn Morris <rgm@gnu.org>
5991 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5992 Not clear what it was for, and it causes various bugs. (Bug#9839)
5994 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5996 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5997 possible random value that matches one of those tested as
5998 condition to clear the mouse face.
6000 2011-10-28 Chong Yidong <cyd@gnu.org>
6002 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6004 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6006 * window.c (make_window): Initialize phys_cursor_on_p.
6008 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6010 * lisp.h (struct Lisp_Symbol): Update comments.
6012 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
6014 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6016 2011-10-28 Eli Zaretskii <eliz@gnu.org>
6018 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6019 <oslsachem@gmail.com> for helping to debug this.
6021 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6022 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6023 (g_b_init_get_glyph_outline_w): New static variables.
6024 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6025 (GetGlyphOutlineW_Proc): New typedefs.
6026 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
6027 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6029 (w32font_open_internal, compute_metrics):
6030 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
6031 instead of calling the "wide" APIs directly.
6033 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6035 * w32.h (syms_of_w32font): Add prototype.
6037 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
6039 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6040 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6041 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6042 (Fmove_to_window_line): Doc fix.
6044 2011-10-27 Chong Yidong <cyd@gnu.org>
6046 * process.c (make_process): Set gnutls_state to NULL.
6048 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6049 non-NULL, regardless of GNUTLS_INITSTAGE.
6050 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6051 an error. Set process slots as soon as we allocate them.
6053 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6055 2011-10-27 Chong Yidong <cyd@gnu.org>
6057 * gnutls.c (emacs_gnutls_deinit): New function.
6058 Deallocate credentials structures as well as calling gnutls_deinit.
6059 (Fgnutls_deinit, Fgnutls_boot): Use it.
6061 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6062 (deactivate_process): Call emacs_gnutls_deinit.
6064 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
6066 * image.c (x_create_x_image_and_pixmap):
6067 * w32.c (sys_rename, w32_delayed_load):
6068 * w32font.c (fill_in_logfont):
6069 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6071 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
6073 * w32fns.c (w32_default_color_map): New function,
6074 extracted from Fw32_default_color_map.
6075 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
6077 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6079 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6081 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6083 * keyboard.c (test_undefined): New function (bug#9751).
6084 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6086 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6088 * sysdep.c (init_sys_modes): Fix the check for the controlling
6089 terminal (Bug#6649).
6091 2011-10-20 Eli Zaretskii <eliz@gnu.org>
6093 * dispextern.h (struct bidi_it): New member next_en_type.
6095 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6096 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6097 current character, check also for next_en_type being WEAK_EN.
6098 (bidi_resolve_weak): Don't enter the expensive loop if the current
6099 position is before next_en_pos. Record the bidi type of the first
6100 non-ET, non-BN character we find, in addition to its position.
6101 (bidi_level_of_next_char): Invalidate next_en_type when
6102 next_en_pos is over-stepped.
6104 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6106 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6107 * editfns.c: Rewrite current-time-zone so that it invokes
6108 the equivalent of (format-time-string "%Z") to get the time zone name.
6109 This fixes a bug when the time zone name contains characters that
6110 need converting from the system time locale to Emacs internal format.
6111 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6112 that patch fixed format-time-string to do the conversion, but
6113 I forgot to fix current-time-zone.
6114 (format_time_string): New function, containing most of
6115 what Fformat_time_string used to contain.
6116 (Fformat_time_string): Rewrite in terms of format_time_string.
6117 This doesn't change this function's behavior.
6118 (current-time-zone): Rewrite to use format_time_string.
6119 This fixes the bug reported by Michael Schierl in
6120 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6121 Jason Rumney's 2007-06-07 change worked around this bug, but
6123 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6125 2011-10-19 Eli Zaretskii <eliz@gnu.org>
6127 * xdisp.c (start_display): If the character at POS is displayed
6128 via a display vector, reset IT->current.dpvec_index to zero.
6129 (try_window_reusing_current_matrix): If a line ends in a display
6130 vector or the next line starts in a display vector, continue
6131 redrawing the window even though the character position of
6132 start_row was reached.
6135 2011-10-18 Chong Yidong <cyd@gnu.org>
6137 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6138 with nobreak-char-display too.
6140 2011-10-18 Eli Zaretskii <eliz@gnu.org>
6142 Fix part 3 of bug#9771.
6143 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6144 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6145 non-neutral characters if the current character is a paragraph
6146 separator (a.k.a. Newline). This avoids running the same
6147 expensive loop twice, once when we consume the preceding newline
6148 and the other time when the line actually needs to be displayed.
6149 Avoid the loop when we see neutrals on the base embedding level
6150 following a character whose directionality is the same as the
6151 paragraph's. This avoids running the expensive loop when a line
6152 ends in a long sequence of neutrals, like control characters.
6153 Add assertion against STRONG_AL type. Slightly rearrange code
6154 that determines the type of a neutral given the first non-neutral
6156 (bidi_level_of_next_char): Set next_en_pos to zero when
6157 invalidating its info.
6159 2011-10-17 Eli Zaretskii <eliz@gnu.org>
6161 * xdisp.c (push_display_prop): Determine whether to record string
6162 or buffer position by IT->string, not by IT->method. Allow
6163 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
6164 (move_it_vertically_backward): Don't look for character position
6165 immediately after the newline when in a continuation line.
6168 2011-10-15 Martin Rudalics <rudalics@gmx.at>
6170 * window.c (coordinates_in_window): Rewrite and delabelize
6171 vertical border check. (Bug#5357) (Bug#9618)
6173 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6175 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6176 errors in XSetWindowBorder (bug#9310).
6178 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6180 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6181 avoid crash when xmalloc overrun checking is enabled.
6183 2011-10-13 Eli Zaretskii <eliz@gnu.org>
6185 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6186 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6187 cursor motion with <left> and <right> arrow keys.
6189 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6190 some callers set that themselves.
6192 2011-10-12 Eli Zaretskii <eliz@gnu.org>
6194 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6195 display string and the previous row comes from the same string and
6196 is empty. (Bug#9739) (Bug#9738)
6198 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6200 * doc.c (get_doc_string): Encode file name (bug#9735).
6202 2011-10-12 Eli Zaretskii <eliz@gnu.org>
6204 * bidi.c (bidi_level_of_next_char):
6205 * xdisp.c (get_visually_first_element): Remove old incorrect
6206 comments regarding the Unicode Line Separator character.
6208 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6210 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6212 * alloc.c (Fgc_status): Do not access beyond zombies array
6213 boundary if nzombies > MAX_ZOMBIES.
6214 * alloc.c (dump_zombies): Add missing format specifier.
6216 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6218 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6219 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6221 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6222 Some packages use them to denote characters with modifiers.
6224 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6226 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6227 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6228 matching a pp-number. Rename parameter var to var1.
6230 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6232 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6234 2011-10-08 Glenn Morris <rgm@gnu.org>
6236 * callint.c (Fcall_interactively): Give a more explicit error for the
6237 'c' case with a non-character input. (Bug#8479)
6239 2011-10-08 Eli Zaretskii <eliz@gnu.org>
6241 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6243 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6244 lines that are hscrolled on the left.
6246 * dispnew.c (buffer_posn_from_coords): Account for a possible
6247 presence of header-line. (Bug#4426)
6249 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6251 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6252 Don't advertise functionality which we discourage or doesn't work.
6254 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6256 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6257 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6258 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6259 this makes Emacs dump core during garbage collection on rare
6260 occasions. sizeof is obviously inferior to offsetof here, so
6261 stick with offsetof.
6262 (GC_POINTER_ALIGNMENT): New macro.
6263 (mark_memory): Omit 3rd (offset) arg; caller changed.
6264 Don't assume EMACS_INT alignment is the same as pointer alignment.
6266 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6268 * keyboard.c (read_key_sequence_remapped): New var.
6269 (read_key_sequence): Compute remapping in the right buffer.
6270 (command_loop_1): Use read_key_sequence's remapping directly.
6272 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6274 * dired.c (file_name_completion): Don't expand file name.
6275 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6276 before checking file name handler.
6278 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6279 they've been requested explicitly (bug#9591).
6281 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
6283 * keymap.c (Fsingle_key_description): Use make_specified_string
6284 instead of build_string to build string from push_key_description.
6287 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6289 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6290 This fixes a Y2038 bug on 64-bit hosts.
6291 * buffer.c (reset_buffer):
6292 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6293 (Fclear_buffer_auto_save_failure):
6294 Use 0, not -1, to represent an unset failure time, since time_t
6295 might not be signed.
6297 Remove dependency on glibc malloc internals.
6298 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6299 Move back here from lisp.h, but with their new implementations.
6300 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6301 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6302 * charset.c (charset_table_init): New static var.
6303 (syms_of_charset): Use it instead of xmalloc. This removes a
6304 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6305 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6306 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6307 Move back to alloc.c.
6308 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6309 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6311 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6313 * nsterm.m (windowDidResize): Call x_set_window_size only when
6314 ns_in_resize is true. Otherwise set pixelwidth/height and
6315 call change_frame_size (Bug#9628).
6317 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6319 Port --enable-checking=all to Fedora 14 x86-64.
6320 * charset.c (syms_of_charset): Also account for glibc malloc's
6321 internal overhead when calculating the initial malloc maximum.
6323 Port --enable-checking=all to Fedora 14 x86.
6324 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6326 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6327 (overrun_check_realloc, overrun_check_free):
6328 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6329 That way, xmalloc returns a properly-aligned pointer even if
6330 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6331 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6332 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6333 into account when calculating the initial malloc maximum.
6334 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6335 Move here from alloc.c, so that charset.c can use it too.
6336 Properly align; the old code wasn't right for common 32-bit hosts
6337 when configured with --enable-checking=all.
6338 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6339 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6341 2011-09-29 Eli Zaretskii <eliz@gnu.org>
6343 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
6346 2011-09-28 Eli Zaretskii <eliz@gnu.org>
6348 * xdisp.c (compute_display_string_end): If there's no display
6349 string at CHARPOS, return -1.
6351 * bidi.c (bidi_fetch_char): When compute_display_string_end
6352 returns a negative value, treat the character as a normal
6353 character not covered by a display string. (Bug#9624)
6355 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
6357 * lread.c (Fread_from_string): Fix typo in docstring.
6359 2011-09-27 Eli Zaretskii <eliz@gnu.org>
6361 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6362 newline, reseat the iterator instead of bidi-iterating there one
6363 character at a time. (Bug#9610)
6364 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6365 TO_CHARPOS if the bidi iterator is at base embedding level.
6367 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6369 * lread.c (readevalloop): Use correct code for NBSP.
6370 (read1): Likewise. (Bug#9608)
6372 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
6374 * dbusbind.c (Fdbus_register_signal): When service is not
6375 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6377 2011-09-25 Glenn Morris <rgm@gnu.org>
6379 * buffer.c (truncate-lines): Doc fix.
6381 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
6383 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6384 (Fset_window_next_buffers): Doc fix.
6386 2011-09-24 Glenn Morris <rgm@gnu.org>
6388 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6390 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6392 Fix minor problems found by static checking.
6393 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
6394 * indent.c (Fvertical_motion): Fix == vs = typo.
6396 2011-09-24 Eli Zaretskii <eliz@gnu.org>
6398 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6399 Default value is now t. Doc fix.
6401 * indent.c (Fvertical_motion): Compute and apply the overshoot
6402 logic when moving up, not only when moving down. Fix the
6403 confusing name and values of the it_overshoot_expected variable;
6404 logic changes accordingly. (Bug#9254) (Bug#9549)
6406 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6407 CHARPOS is covered by a display string which includes newlines.
6408 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6409 is covered by a display string with embedded newlines.
6411 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
6413 * dbusbind.c (Fdbus_register_signal): Add match rule to
6414 Vdbus_registered_objects_table. (Bug#9581)
6415 (Fdbus_register_method, Vdbus_registered_objects_table):
6418 2011-09-24 Jim Meyering <meyering@redhat.com>
6420 do not ignore write error for any output size
6421 The previous change was incomplete.
6422 While it makes emacs --batch detect the vast majority of stdout
6423 write failures, errors were still ignored whenever the output size is
6424 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6425 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6426 && echo FAIL: ignored write error
6427 FAIL: ignored write error
6428 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6429 && echo FAIL: ignored write error
6430 FAIL: ignored write error
6431 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6433 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6435 * emacs.c (Fkill_emacs): In noninteractive mode exit
6436 non-successfully if a write error occurred on stdout. (Bug#9574)
6438 2011-09-21 Eli Zaretskii <eliz@gnu.org>
6440 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6443 * dispextern.h (struct it): Update the comment documenting what
6446 2011-09-20 Eli Zaretskii <eliz@gnu.org>
6448 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6449 a display string, extend search for cursor position to end of row.
6450 (find_row_edges): If the row ends in a newline from a display
6451 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6452 Handle the case of a display string with multiple newlines.
6453 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6454 non-empty line. Fixes confusing cursor motion with arrow keys at
6455 the beginning of a line that starts with whitespace.
6457 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6459 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6462 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
6464 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6467 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6469 * xdisp.c (display_line): Record maximum and minimum buffer
6470 positions even if no glyphs were produced (e.g., by a zero-width
6471 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6472 buffer positions that will be removed from the glyph row because
6474 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6475 column is beyond frame width: don't subtract 1 "pixel" when
6476 computing width of the stretch.
6477 (reseat_at_next_visible_line_start): Undo the change made on
6478 2011-09-17 that saved paragraph information and restored it after
6479 the call to `reseat'. (Bug#9545)
6481 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6483 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6484 and turn window cursor on if cleared (Bug#9415).
6486 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
6488 * search.c (boyer_moore): Take unibyte characters from pattern
6489 literally. (Bug#9458)
6491 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6493 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6495 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6497 Fix minor problem found by static checking.
6498 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6499 initialized, to pacify gcc -Wuninitialized.
6501 * fileio.c: Report proper errno when syscall falls.
6502 (Finsert_file_contents): Save and restore errno,
6503 so that report_file_error outputs the correct diagnostic.
6504 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6506 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6508 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6510 2011-09-17 Eli Zaretskii <eliz@gnu.org>
6512 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6513 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6515 2011-09-17 Eli Zaretskii <eliz@gnu.org>
6517 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6518 about the current paragraph and restore it after the call to reseat.
6520 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6521 (bidi_find_paragraph_start): Search back for paragraph beginning
6522 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6523 (bidi_move_to_visually_next): Only trigger paragraph-related
6524 computations when the last character is a newline or at EOB, not
6525 just any NEUTRAL_B. (Bug#9470)
6527 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6528 truncated lines if point is covered by a display string. (Bug#9524)
6530 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6532 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6533 (cons_to_x_long): New function.
6534 (lisp_data_to_selection_data): Use it. Correct the test for
6535 short-versus-long data; it was negated. Break out of vector
6536 loop, for efficiency, when a long datum is discovered.
6538 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6540 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6542 2011-09-16 Eli Zaretskii <eliz@gnu.org>
6544 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6545 GCC PR/17406) by declaring this function with external scope.
6547 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6549 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6550 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6552 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6554 * editfns.c (Fformat): Correctly handle text properties on "%%".
6556 2011-09-15 Eli Zaretskii <eliz@gnu.org>
6558 * xterm.c (x_draw_composite_glyph_string_foreground):
6559 * w32term.c (x_draw_composite_glyph_string_foreground):
6560 * term.c (encode_terminal_code):
6561 * composite.c (composition_update_it, get_composition_id):
6562 * xdisp.c (get_next_display_element)
6563 (fill_composite_glyph_string): Add comments about special meaning
6564 of TAB characters in a composition.
6566 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6568 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
6569 This occurs when processing a multibyte format.
6570 Problem reported by Wolfgang Jenker.
6572 2011-09-15 Johan Bockgård <bojohan@gnu.org>
6574 * xdisp.c (try_cursor_movement): Only check for exact match if
6575 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6577 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6579 Remove unused external symbols.
6580 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6581 * xdisp.c (calc_pixel_width_or_height): Now static.
6582 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6583 * indent.c (check_display_width):
6584 * w32term.c: Fix comment to match code.
6585 * xterm.c, xterm.h (x_catching_errors): Remove.
6587 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6589 * xselect.c: Use signed conversions more consistently (Bug#9498).
6590 (selection_data_to_lisp_data): Assume incoming selection data are
6591 signed integers, not unsigned. This is to be consistent with
6592 outgoing selection data, which was modified to use signed integers
6593 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6594 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6595 expects long, not unsigned long.
6597 2011-09-14 Eli Zaretskii <eliz@gnu.org>
6599 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6600 computation of loop end. Reported by Johan Bockgård
6603 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
6605 * frame.c (Fother_visible_frames_p): Function deleted.
6607 2011-09-12 Eli Zaretskii <eliz@gnu.org>
6609 * indent.c (compute_motion): Process display vector front to back
6610 rather than the other way around. (Bug#2496)
6612 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6614 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6616 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
6618 * minibuf.c (Fread_from_minibuffer): Doc fix.
6620 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6622 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6623 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6625 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6627 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6628 value for non-existent files.
6630 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6632 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6633 set its "size" to -1. This will set the modtime_size field of
6634 the corresponding buffer to -1, which is what
6635 verify-visited-file-modtime expects for files that do not exist.
6638 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6640 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6642 * lisp.h: ... from here. push_key_description is no longer
6643 defined in keyboard.c, so its declaration should not be in
6644 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6645 logically belongs with push_key_description.
6647 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6649 * buffer.h: Include <sys/types.h> instead of <time.h>.
6650 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6651 Problem reported by Herbert J. Skuhra.
6653 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6655 * xml.c (parse_region): Make the parsing work for
6656 non-comment-starting XML files again (bug#9144).
6658 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6660 * image.c (gif_load): Fix calculation of bottom and right corner.
6663 2011-09-10 Eli Zaretskii <eliz@gnu.org>
6665 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6666 redisplay in small windows.
6668 2011-09-09 Eli Zaretskii <eliz@gnu.org>
6670 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6672 2011-09-08 Martin Rudalics <rudalics@gmx.at>
6674 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6675 Operate on live windows only.
6677 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
6679 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6681 2011-09-07 Eli Zaretskii <eliz@gnu.org>
6683 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6684 only under bidi iteration.
6686 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6688 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6690 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6692 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6693 Without this fix, the command to link temacs failed due to an
6694 undefined symbol __builtin_isnan. This is because
6695 /usr/include/iso/math_c99.h #defines isnan(x) to
6696 __builtin_isnan(x), but the bundled gcc, which identifies itself
6697 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6699 * floatfns.c (isnan): #undef, and then #define to a clone of
6701 (Fisnan): Always define, since it's always available now.
6702 (syms_of_floatfns): Always define isnan at the Lisp level.
6704 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6706 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6708 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6710 * fileio.c: Fix bugs with large file offsets (Bug#9428).
6711 The previous code assumed that file offsets (off_t values) fit in
6712 EMACS_INT variables, which is not true on typical 32-bit hosts.
6713 The code messed up by falsely reporting buffer overflow in cases
6714 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6715 when "big" contains more than 2**29 bytes, even though this
6716 inserts just one byte and does not overflow the buffer.
6717 (Finsert_file_contents): Store file offsets as off_t
6718 values, not as EMACS_INT values. Check for overflow when
6719 converting between EMACS_INT and off_t. When checking for
6720 buffer overflow or for overlap, take the offsets into account.
6721 Don't use EMACS_INT for small values where int suffices.
6722 When checking for overlap, fix a typo: ZV was used where
6723 ZV_BYTE was intended.
6724 (Fwrite_region): Don't assume off_t fits into 'long'.
6725 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6727 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
6729 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6731 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6733 sprintf-related integer and memory overflow issues (Bug#9412).
6735 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
6736 (esprintf, exprintf, evxprintf): New functions.
6737 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6738 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
6739 (modify_event_symbol): Do not assume that the length of
6740 name_alist_or_stem is safe to alloca and fits in int.
6741 (Fexecute_extended_command): Likewise for function name and binding.
6742 (Frecursion_depth): Wrap around reliably on integer overflow.
6743 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6744 since some callers pass EMACS_INT values.
6745 (Fsingle_key_description): Don't crash if symbol name contains more
6746 than MAX_ALLOCA bytes.
6747 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6748 (get_minibuffer): Arg is now EMACS_INT, not int.
6749 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
6750 (esprintf, exprintf, evxprintf): New decls.
6751 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6753 * dbusbind.c (signature_cat): New function.
6754 (xd_signature, Fdbus_register_signal):
6755 Do not overrun buffer; instead, report string overflow.
6757 * dispnew.c (add_window_display_history): Don't overrun buffer.
6758 Truncate instead; this is OK since it's just a log.
6760 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6761 even if the time zone offset is outlandishly large.
6762 Don't mishandle offset == INT_MIN.
6764 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6765 when creating daemon; the previous buffer-overflow check was incorrect.
6767 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6768 which has the guts of the old verror function.
6770 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6771 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6773 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6774 (font_unparse_xlfd): Don't blindly alloca long strings.
6775 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
6776 fits in int, when using sprintf. Use single snprintf to count
6777 length of string rather than counting it via multiple sprintfs;
6778 that's simpler and more reliable.
6779 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6780 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6781 sprintf, in case result does not fit in int.
6783 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6784 (fontset_from_font): Print it.
6786 * frame.c (tty_frame_count): Now printmax_t, not int.
6787 (make_terminal_frame, set_term_frame_name): Print it.
6788 (x_report_frame_params): In X, window IDs are unsigned long,
6789 not signed long, so print them as unsigned.
6790 (validate_x_resource_name): Check for implausibly long names,
6791 and don't assume name length fits in 'int'.
6792 (x_get_resource_string): Don't blindly alloca invocation name;
6793 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6796 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6797 (xg_check_special_colors, xg_set_geometry):
6798 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6800 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6801 Use esprintf, not sprintf, in case result does not fit in int.
6803 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6804 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6805 it as a large positive number.
6806 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6807 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6809 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6810 in case result does not fit in int.
6812 * print.c (float_to_string): Detect width overflow more reliably.
6813 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6814 buffer overrun. Don't assume list length fits in 'int'. Treat
6815 print length of 0 as 0, not as infinity; to be consistent with other
6816 uses of print length in this function. Don't overflow print length
6817 index. Don't assume hash table size fits in 'long', or that
6818 vectorlike size fits in 'unsigned long'.
6820 * process.c (make_process): Use printmax_t, not int, to format
6821 process-name gensyms.
6823 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6825 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6826 to avoid potential buffer overrun.
6828 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6829 if X resource line is longer than 512 bytes.
6831 * xfns.c (x_window): Make sprintf buffer a bit bigger
6832 to avoid potential buffer overrun.
6834 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6836 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6838 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6840 Integer overflow fixes for scrolling, etc.
6841 Without these, Emacs silently mishandles large integers sometimes.
6842 For example, "C-u 4294967297 M-x recenter" was treated as if
6843 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6845 * xdisp.c (try_window_id): Check Emacs fixnum range before
6846 converting to 'int'.
6848 * window.c (window_scroll_line_based, Frecenter):
6849 Check that an Emacs fixnum is in range before assigning it to 'int'.
6850 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6851 values converted from Emacs fixnums.
6852 (Frecenter): Don't wrap around a line count if it is out of 'int'
6853 range; instead, treat it as an extreme value.
6854 (Fset_window_configuration, compare_window_configurations):
6855 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6857 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6858 that can exceed INT_MAX. Check that EMACS_INT value is in range
6859 before assigning it to the (possibly-narrower) index.
6860 (match_limit): Don't assume that a fixnum can fit in 'int'.
6862 * print.c (print_object): Use ptrdiff_t, not int, for index that can
6865 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
6866 (Fvertical_motion): Don't wrap around LINES values that don't fit
6867 in 'int'. Instead, treat them as extreme values. This is good
6868 enough for windows, which can't have more than INT_MAX lines anyway.
6870 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6872 * Require libxml/parser.h to avoid compilation warning.
6874 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6876 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6877 since this reportedly can destroy thread storage.
6879 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
6881 * syntax.c (find_defun_start): Update all cache variables if
6882 exiting early (Bug#9401).
6884 2011-08-30 Eli Zaretskii <eliz@gnu.org>
6886 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6888 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6889 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6890 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6892 * term.c (tty_append_glyph): New function.
6893 (produce_stretch_glyph): Static function and its prototype deleted.
6895 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6898 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6900 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6901 when checking :margin (Bug#9390).
6902 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
6903 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
6904 so that the name doesn't mislead. All uses changed.
6906 2011-08-28 Johan Bockgård <bojohan@gnu.org>
6908 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6911 2011-08-27 Eli Zaretskii <eliz@gnu.org>
6913 * xdisp.c (move_it_to): Don't bail out early when reaching
6914 position beyond to_charpos, if we are scanning backwards.
6915 (move_it_vertically_backward): When DY == 0, make sure we get to
6916 the first character in the line after the newline.
6918 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6920 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6921 (ccl_driver): Do not generate an out-of-range pointer.
6922 (Fccl_execute_on_string): Remove unnecessary check for
6923 integer overflow, noted by Stefan Monnier in
6924 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6925 Remove a FIXME that didn't need fixing.
6926 Simplify the newly-introduced buffer reallocation code.
6928 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
6930 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6932 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
6934 Integer and memory overflow issues (Bug#9196).
6936 * doc.c (get_doc_string): Rework so that
6937 get_doc_string_buffer_size is the actual buffer size, rather than
6938 being 1 less than the actual buffer size; this makes xpalloc more
6941 * image.c (x_allocate_bitmap_record, cache_image):
6942 * xselect.c (Fx_register_dnd_atom):
6943 Simplify previous changes by using xpalloc.
6945 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6946 since either will do and ptrdiff_t is convenient with xpalloc.
6948 * charset.c (charset_table_size)
6949 (struct charset_sort_data.priority): Now ptrdiff_t.
6950 (charset_compare): Don't overflow if priorities differ greatly.
6951 (Fsort_charsets): Don't assume list length fits in int.
6952 Check for size-calculation overflow when allocating sort data.
6953 (syms_of_charset): Allocate an initial charset table that is
6954 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6956 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6958 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6959 The actual value is always <= INT_MAX, and leaving it unsigned made
6960 overflow checking harder.
6962 * dispextern.h (struct glyph_matrix.rows_allocated)
6963 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6964 with xpalloc. The values are still always <= INT_MAX.
6966 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6968 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6969 (SAFE_NALLOCA): New macro.
6971 * region-cache.c (struct boundary.pos, find_cache_boundary)
6972 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6973 (set_cache_region, invalidate_region_cache)
6974 (revalidate_region_cache, know_region_cache, region_cache_forward)
6975 (region_cache_backward, pp_cache):
6976 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6977 so that ptrdiff_t * can be passed to xpalloc.
6978 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6979 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6980 (pp_cache): Don't assume cache_len fits in int.
6981 * region-cache.h: Adjust extern decls to match.
6983 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6984 EMACS_INT, since either will do, for xpalloc.
6986 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6987 (xnmalloc, xnrealloc, xpalloc): New functions.
6989 * bidi.c (bidi_shelve_header_size): New constant.
6990 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6991 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6993 * bidi.c (bidi_cache_shrink):
6994 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6996 Don't update size of array until after memory allocation succeeds,
6997 because xmalloc/xrealloc may not return.
6998 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6999 now that we have proper integer overflow checking.
7000 (record_overlay_string, overlay_strings): Catch overflows when
7001 calculating size of overlay_str_buf.
7003 * callproc.c (Fcall_process): Check for size overflow when
7004 calculating size of args2.
7005 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7006 Normally we prefer signed values, but sticking with ptrdiff_t would
7007 require adding more-complicated checks.
7009 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7010 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7011 Redo buffer-overflow calculations to avoid integer overflow.
7012 Add a FIXME comment where memory seems to be over-allocated.
7014 * character.c (Fstring): Check for size-calculation overflow.
7016 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7017 unnecessary integer overflow. Check for size overflow.
7018 (encode_coding_object): Don't update size until xmalloc succeeds.
7020 * composite.c (get_composition_id): Check for overflow in glyph
7021 length calculations.
7023 Integer and memory overflow fixes for display code.
7024 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7025 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7026 (scrolling_window): Check for overflow in size calculations.
7027 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7028 Don't assume glyph table len fits in int.
7029 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7030 (row_table_size): Now ptrdiff_t, not int.
7031 (scrolling_window): Avoid overflow in size calculations.
7032 Don't update size until allocation succeeds.
7033 * fns.c (concat): Check for overflow in size calculations.
7034 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7035 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7036 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7038 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7039 (get_doc_string): Check for size calculation overflow.
7040 Don't update size until allocation succeeds.
7041 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7042 EMACS_INT, where ptrdiff_t will do.
7043 (Fsubstitute_command_keys): Check for string overflow.
7045 * editfns.c (set_time_zone_rule): Don't assume environment length
7047 (message_length): Now ptrdiff_t, not int.
7048 (Fmessage_box): Don't update size until allocation succeeds.
7049 Don't assume message length fits in int.
7050 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7052 * emacs.c (main): Do not reallocate argv, since there is a null at
7053 the end that can be overwritten, and this way there's no need to
7054 worry about size-calculation overflow.
7055 (sort_args): Check for size-calculation overflow.
7057 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7059 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7061 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7062 (x_set_scroll_bar_width, x_figure_window_size):
7063 Check for integer overflow.
7064 (x_set_alpha): Do not assume XINT fits in int.
7066 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7067 This is for the members text_lines, text_cols, total_lines, total_cols,
7068 where the system imposes an 'int' limit.
7070 * fringe.c (Fdefine_fringe_bitmap):
7071 Don't update size until alloc works.
7073 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7074 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7076 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7077 Check for size-calculation overflow.
7078 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7079 do, as we prefer signed integers.
7080 (id_to_widget.max_size, id_to_widget.used)
7081 (xg_store_widget_in_map, xg_remove_widget_from_map)
7082 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7083 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7084 Use and return ptrdiff_t, not int.
7085 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7086 * gtkutil.h: Change prototypes to match the above.
7088 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7089 are duplicate now that they've been promoted to lisp.h.
7090 (x_allocate_bitmap_record, x_alloc_image_color)
7091 (make_image_cache, cache_image, xpm_load):
7092 Don't update size until alloc is done.
7093 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7095 Check for size calculation overflow.
7096 (ct_colors_allocated_max): New constant.
7097 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7100 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7101 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7102 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7103 Use ptrdiff_t, not int, to count maps.
7104 (read_char_minibuf_menu_prompt): Check for overflow in size
7105 calculations. Don't update size until allocation succeeds.
7106 Redo calculations to avoid overflow.
7107 * keyboard.h: Change prototypes to match the above.
7109 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7111 (current_minor_maps): Check for size calculation overflow.
7112 * keymap.h: Change prototypes to match the above.
7114 * lread.c (read1, init_obarray): Don't update size until alloc done.
7116 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7117 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7119 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7120 Now ptrdiff_t, not int.
7121 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7122 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7124 * process.c (Fnetwork_interface_list): Check for overflow
7125 in size calculation.
7127 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7129 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7130 overflow. Don't bother calling xmalloc when xrealloc will do.
7132 * search.c (Freplace_match): Check for size calculation overflow.
7133 (Fset_match_data): Don't assume list lengths fit in 'int'.
7135 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7136 for command line length. Do not attempt to address one before the
7137 beginning of an array, as that's not portable.
7139 * term.c (max_frame_lines): Remove; unused.
7140 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7142 (encode_terminal_code, calculate_costs): Check for size
7143 calculation overflow.
7144 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7145 table lengths and related sizes. Don't update size until alloc
7146 done. Redo calculations to avoid overflow.
7147 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7149 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7150 subtracting pointers.
7151 (gobble_line): Check for overflow more carefully. Don't update size
7154 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7155 Don't update size until alloc done.
7156 Redo size calculations to avoid overflow.
7157 Check for size calculation overflow.
7158 (main) [DEBUG]: Fix typo in invoking tparam1.
7160 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7161 Use ptrdiff_t, not int, for sizes.
7162 (store_mode_line_noprop_char): Don't update size until alloc done.
7164 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7165 Use ptrdiff_t, not int, for sizes.
7166 (Finternal_make_lisp_face, cache_face):
7167 Check for size calculation overflow.
7168 (cache_face): Treat size calculation overflows as if they were
7169 memory exhaustion (the usual treatment), rather than aborting.
7171 * xfns.c (x_encode_text, x_set_name_internal)
7172 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7173 sizes, since they can exceed INT_MAX in size. Check for size
7174 calculation overflow.
7176 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7177 (xg_select): Check for size calculation overflow.
7178 Don't update size until alloc done.
7180 * xrdb.c (get_environ_db): Don't assume path length fits in int,
7181 as sprintf is limited to int lengths.
7183 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7184 (X_LONG_MIN): New macros.
7185 Use them to make the following changes clearer.
7186 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7187 This change doesn't affect the value now, but it may help remind
7188 future maintainers not to raise the value too much later.
7189 (SELECTION_QUANTUM): Remove, replacing with ...
7190 (selection_quantum): ... new function, which avoids overflow.
7192 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7193 assumption that selection length fits in 'int'.
7194 (x_reply_selection_request, x_handle_selection_request)
7195 (x_get_window_property, receive_incremental_selection)
7196 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7197 (lisp_data_to_selection_data, clean_local_selection_data):
7198 Use ptrdiff_t, not int, to record length of selection.
7199 (x_reply_selection_request, x_get_window_property)
7200 (receive_incremental_selection, x_property_data_to_lisp):
7201 Redo calculations to avoid overflow.
7202 (x_reply_selection_request): When sending hint, ceiling it at
7203 X_LONG_MAX rather than relying on wraparound overflow to send
7205 (x_get_window_property, receive_incremental_selection)
7206 (lisp_data_to_selection_data, x_property_data_to_lisp):
7207 Check for size-calculation overflow.
7208 (x_get_window_property, receive_incremental_selection)
7209 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7210 Don't store size until memory allocation succeeds.
7211 (x_get_window_property): Plug memory leak on memory exhaustion.
7212 Don't double-block input; malloc is safe here. Don't assume 2**34
7213 - 4 fits in unsigned long. Add an xassert to check
7214 XGetWindowProperty overflow. Be more careful about overflow
7215 calculations, and distinguish size from memory overflow better.
7216 (receive_incremental_selection): When tracing, don't assume
7217 unsigned int is less than INT_MAX.
7218 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7219 harmful) conversions of unsigned short to int.
7220 (lisp_data_to_selection_data): Don't assume that integers
7221 in the range -65535 through -1 fit in an X unsigned short.
7222 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7223 result parameters unless successful. Rely on cons_to_unsigned
7224 to report problems with elements; the old code wasn't right anyway.
7225 (x_check_property_data): Check for int overflow; we cannot use
7226 a wider type due to X limits.
7227 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7229 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
7231 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7232 (x_term_init): Check for size calculation overflow.
7233 (x_color_cells): Don't store size until memory allocation succeeds.
7234 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
7235 Don't assume alloca size is less than MAX_ALLOCA.
7236 (x_term_init): Don't assume length fits in int (sprintf is limited
7239 Use ptrdiff_t for composition IDs.
7240 * character.c (lisp_string_width):
7241 * composite.c (composition_table_size, n_compositions)
7242 (get_composition_id, composition_gstring_from_id):
7243 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7244 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7245 * window.c (Frecenter):
7246 Use ptrdiff_t, not int, for composition IDs.
7247 * composite.c (get_composition_id): Check for integer overflow.
7248 * composite.h: Adjust prototypes to match the above changes.
7250 Use ptrdiff_t for hash table indexes.
7251 * category.c (hash_get_category_set):
7252 * ccl.c (ccl_driver):
7253 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7254 * coding.c (coding_system_charset_list, detect_coding_system):
7255 * coding.h (struct coding_system.id):
7256 * composite.c (get_composition_id, gstring_lookup_cache):
7257 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7258 * image.c (xpm_get_color_table_h):
7259 * lisp.h (hash_lookup, hash_put):
7260 * minibuf.c (Ftest_completion):
7261 Use ptrdiff_t for hash table indexes, not int (which is too
7262 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7263 32-bit --with-wide-int hosts).
7265 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7266 Add a FIXME comment about memory leaks.
7267 (syms_of_charset): Don't assume xmalloc returns.
7269 Don't assume that stated character widths fit in int.
7270 * character.c (Fchar_width, c_string_width, lisp_string_width):
7271 * character.h (CHAR_WIDTH):
7272 * indent.c (MULTIBYTE_BYTES_WIDTH):
7273 Use sanitize_char_width to avoid undefined and/or bad behavior
7274 with outlandish widths.
7275 * character.h (sanitize_tab_width): Rename from sanitize_width,
7276 now that we have two such functions. All uses changed.
7277 (sanitize_char_width): New inline function.
7279 Don't assume that tab-width fits in int.
7280 * character.h (sanitize_width): New inline function.
7281 (SANE_TAB_WIDTH): New macro.
7282 (ASCII_CHAR_WIDTH): Use it.
7283 * indent.c (sane_tab_width): Remove. All uses replaced by
7284 SANE_TAB_WIDTH (current_buffer).
7285 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7287 * fileio.c: Integer overflow issues with file modes.
7288 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7290 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7291 Remove unreachable code.
7292 (read_hex, load_charset_map_from_file): Check for integer overflow.
7294 * xterm.c: Don't go over XClientMessageEvent limit.
7295 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7296 (x_send_scroll_bar_event): Likewise. Check that the size does not
7297 exceed limits imposed by XClientMessageEvent, as well as the usual
7298 ptrdiff_t and size_t limits.
7300 * keyboard.c: Overflow, signedness and related fixes.
7301 (make_lispy_movement): Use same integer type in forward decl
7302 that is used in the definition.
7303 (read_key_sequence, keyremap_step):
7304 Change bufsize argument back to int, undoing my 2011-03-30 change.
7305 We prefer signed types, and int is wide enough here.
7306 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7307 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7308 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7309 length, not size_t. Use ptrdiff_t for index, not int.
7310 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7311 possibility of integer overflow.
7313 Overflow, signedness and related fixes for images.
7315 * dispextern.h (struct it.stack[0].u.image.image_id)
7316 (struct_it.image_id, struct image.id, struct image_cache.size)
7317 (struct image_cache.used, struct image_cache.ref_count):
7318 * gtkutil.c (update_frame_tool_bar):
7319 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7320 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7321 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7322 * nsmenu.m (update_frame_tool_bar):
7323 * xdisp.c (calc_pixel_width_or_height):
7324 * xfns.c (image_cache_refcount):
7325 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7326 on typical 64-bit hosts.
7328 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7329 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7330 Omit unnecessary casts to int.
7331 (parse_image_spec): Check that integers fall into 'int' range
7332 when the callers expect that.
7333 (image_ascent): Redo ascent calculation to avoid int overflow.
7334 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7335 (lookup_image): Remove unnecessary tests.
7336 (xbm_image_p): Locals are now of int, not EMACS_INT,
7337 since parse_image_check makes sure they fit into int.
7338 (png_load, gif_load, svg_load_image):
7339 Prefer int to unsigned where either will do.
7340 (tiff_handler): New function, combining the cores of the
7341 old tiff_error_handler and tiff_warning_handler.
7342 This function is rewritten to use vsnprintf and thereby avoid
7343 stack buffer overflows. It uses only the features of vsnprintf
7344 that are common to both POSIX and native Microsoft.
7345 (tiff_error_handler, tiff_warning_handler): Use it.
7346 (tiff_load, gif_load, imagemagick_load_image):
7347 Don't assume :index value fits in 'int'.
7348 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7349 (imagemagick_load_image): Check that crop parameters fit into
7350 the integer types that MagickCropImage accepts. Don't assume
7351 Vimagemagick_render_type has a nonnegative value. Don't assume
7352 size_t fits in 'long'.
7353 (gs_load): Use printmax_t to print the widest integers possible.
7354 Check for integer overflow when computing image height and width.
7356 2011-08-26 Eli Zaretskii <eliz@gnu.org>
7358 * xdisp.c (redisplay_window): Don't force window start if point
7359 will be invisible in the resulting window. (Bug#9324)
7361 2011-08-25 Eli Zaretskii <eliz@gnu.org>
7363 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7364 the display spec is of the form `(space ...)'.
7365 (handle_display_spec): Return the value returned by
7366 handle_single_display_spec, not just 1 or zero.
7367 (handle_single_display_spec): If the display spec is of the form
7368 `(space ...)', and specifies display in the text area, return 2
7370 (try_cursor_movement): Check for the need to scroll more
7371 accurately, and prefer exact match for point under bidi.
7372 Don't advance `row' beyond the last row of the window.
7374 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7375 into disp_prop; all users changed.
7377 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7378 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7379 for the text covered by the display property.
7381 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
7383 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7384 Change return value to nil.
7385 (Frecord_buffer): Delete unused function.
7387 2011-08-24 Eli Zaretskii <eliz@gnu.org>
7389 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7390 buffers, return left-to-right.
7391 (set_cursor_from_row): Consider candidate row a win if its glyph
7392 represents a newline and point is on that newline. Fixes cursor
7393 positioning on the newline at EOL of R2L text within L2R
7394 paragraph, and vice versa.
7395 (try_cursor_movement): Check continued rows, in addition to
7396 continuation rows. Fixes unwarranted scroll when point enters a
7397 continued line of R2L text within an L2R paragraph, or vice versa.
7398 (cursor_row_p): Consider the case of point being equal to
7399 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7400 from the end of a short line to the beginning of a continued line
7401 of R2L text within L2R paragraph.
7402 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7403 composed characters.
7405 * bidi.c (bidi_check_type): Use xassert.
7406 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7409 2011-08-23 Eli Zaretskii <eliz@gnu.org>
7411 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7414 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
7416 * nsfont.m (ns_otf_to_script): Fix typo.
7418 2011-08-22 Kenichi Handa <handa@m17n.org>
7420 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7421 extra slot even if the purpose is char-code-property-table.
7423 2011-08-23 Eli Zaretskii <eliz@gnu.org>
7425 * xdisp.c (redisplay_window): When computing centering_position,
7426 account for the height of the header line. (Bug#8874)
7428 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7429 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7430 candidate is selected by the mouse, and that candidate has a
7431 composed character under the mouse.
7433 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7434 coordinates reported by pos-visible-in-window-p for a composed
7435 character in column zero.
7437 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7439 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7441 2011-08-22 Eli Zaretskii <eliz@gnu.org>
7443 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7444 consider it a hit if to_charpos is anywhere in the range of the
7445 composed buffer positions.
7447 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
7449 * image.c (gif_load): Don't assume that each subimage has the same
7450 dimensions as the base image. Handle disposal method that is
7451 "undefined" by the gif spec (Bug#9335).
7453 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
7455 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
7456 (Fcondition_case): Document `debug' symbol in error handler.
7458 2011-08-19 Eli Zaretskii <eliz@gnu.org>
7460 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7461 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7462 from an Org mode buffer to a Speedbar frame.
7464 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7465 a composition, take its buffer position from IT->cmp_it.charpos.
7466 Fixes cursor positioning at the beginning of a line that begins
7467 with a composed character.
7469 2011-08-18 Eli Zaretskii <eliz@gnu.org>
7471 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7472 character bidirectional type, use STRONG_L instead. Fixes crashes
7473 in a buffer produced by `describe-categories'.
7475 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7476 members before the level stack, so they would be saved and
7477 restored when copying iterator state. Fixes incorrect reordering
7478 around TABs covered by display properties.
7480 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7482 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
7484 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
7486 * eval.c (internal_condition_case, internal_condition_case_1)
7487 (internal_condition_case_2, internal_condition_case_n):
7488 Remove unnecessary aborts (Bug#9081).
7490 2011-08-17 Eli Zaretskii <eliz@gnu.org>
7492 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7493 has no `load' handler, try opening the file locally. (Bug#9311)
7495 2011-08-16 Ken Brown <kbrown@cornell.edu>
7497 * gmalloc.c: Expand comment.
7499 2011-08-16 Eli Zaretskii <eliz@gnu.org>
7501 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7502 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7504 2011-08-16 Ken Brown <kbrown@cornell.edu>
7506 Fix memory allocation problems in Cygwin build (Bug#9273).
7508 * unexcw.c ( __malloc_initialized): Declare external variable.
7509 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7511 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7513 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7515 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7517 [CYGWIN] (special_realloc): New function.
7518 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7519 requests to realloc storage in the static heap.
7521 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7523 * bidi.c (bidi_initialize): Remove unused local.
7525 2011-08-15 Eli Zaretskii <eliz@gnu.org>
7528 * biditype.h: Remove file.
7529 * makefile.w32-in ($(BLD)/bidi.$(O)):
7530 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
7532 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7534 * chartab.c: Improve commentary for the uniprop_table API.
7536 * bidi.c (bidi_paragraph_init): Support zero value of
7537 bidi_ignore_explicit_marks_for_paragraph_level.
7538 (bidi_initialize): Use uniprop_table instead of including
7539 biditype.h and bidimirror.h.
7541 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7542 coordinates of the iterator when restoring from ppos_it.
7545 2011-08-14 Kenichi Handa <handa@m17n.org>
7547 * process.c (create_process): Call setup_process_coding_systems
7548 after the pid of the process is set to -1 (Bug#8162).
7550 2011-08-14 Eli Zaretskii <eliz@gnu.org>
7552 * xdisp.c (move_it_in_display_line_to): Don't invoke
7553 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7554 ppos_it. Fixes vertical cursor motion when line beginning is
7555 covered by an image. (Bug#9296)
7557 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7559 * nsterm.h (ns_run_ascript): Declare.
7560 (NSAPP_DATA2_RUNASSCRIPT): Define.
7562 * nsfns.m (as_script, as_result, as_status): New static variables.
7563 (ns_run_ascript): New function.
7564 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
7565 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7566 the event loop. Get status from as_status (Bug#7276).
7568 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7569 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7570 the event loop (Bug#7276).
7572 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7574 * gnutls.c (QCgnutls_bootprop_priority)
7575 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7576 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7577 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7578 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7579 (QCgnutls_bootprop_verify_hostname_error)
7580 (QCgnutls_bootprop_callbacks_verify): Rename from
7581 Qgnutls_bootprop_..., all uses changed.
7583 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7586 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7588 * xfaces.c (Qframe_set_background_mode): Now static.
7589 * dispextern.h (Qframe_set_background_mode): Remove decl.
7591 * process.c (Fnetwork_interface_info): Declare local only if needed.
7593 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7595 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7596 (Fnetwork_interface_list): Allocate in increments of bytes instead
7597 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7598 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7600 (struct ifflag_def): notrailers is smart on OSX.
7601 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7602 Get hardware address with getifaddrs if available.
7604 2011-08-12 Eli Zaretskii <eliz@gnu.org>
7606 * xdisp.c (iterate_out_of_display_property): xassert that
7607 IT->position is set to within IT->object's boundaries. Break from
7608 the loop as soon as EOB is reached; avoids infloops in redisplay
7609 when IT->position is set up wrongly due to some bug.
7610 Set IT->current to match the bidi iterator unconditionally.
7611 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7612 entry. Force push_it to save on the stack the current
7613 buffer/string position, to be restored by pop_it. Fix flags in
7614 the iterator structure wrt the object coming from a display
7615 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7616 properties. (Bug#9284)
7618 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
7620 * fontset.c (fontset_get_font_group): Add proper type checks.
7623 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7625 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7626 and LC_VERSION_MIN_MACOSX.
7627 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7628 (dump_it) [LC_FUNCTION_STARTS]: Use it.
7630 2011-08-08 Eli Zaretskii <eliz@gnu.org>
7632 * xdisp.c (forward_to_next_line_start): Allow to use the
7633 no-display-properties-and-no-overlays under bidi display.
7634 Set disp_pos in the bidi iterator to avoid searches for display
7635 properties and overlays.
7637 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
7639 * editfns.c (Fset_time_zone_rule): Document relationship with the
7642 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7643 the font entity extracted from the cache (Bug#8109).
7645 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
7647 * composite.c (autocmp_chars): Don't reset point. That is done by
7648 restore_point_unwind (Bug#5984).
7650 2011-08-07 Juri Linkov <juri@jurta.org>
7652 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7653 to show the arg `TIME' instead of `TIMEVAL'.
7655 2011-08-06 Eli Zaretskii <eliz@gnu.org>
7657 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7658 display property strides EOL and includes a newline, as in
7659 longlines-mode. (Bug#9254)
7660 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7661 word-wrap under bidirectional display. (Bug#9224)
7663 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7664 is non-zero, even if the data buffer is NULL. Fixes a crash in
7665 vertical-motion with longlines-mode. (Bug#9254)
7667 2011-08-05 Eli Zaretskii <eliz@gnu.org>
7669 * bidi.c <bidi_cache_total_alloc>: Now static.
7670 (bidi_initialize): Initialize bidi_cache_total_alloc.
7672 * xdisp.c (display_line): Release buffer allocated for shelved bidi
7675 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7676 amount allocated this far in `bidi_cache_total_alloc'.
7677 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7678 non-zero, only free the data buffer without restoring the cache
7679 contents. All callers changed.
7681 * dispextern.h (bidi_unshelve_cache): Update prototype.
7683 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7684 (move_it_in_display_line, move_it_to)
7685 (move_it_vertically_backward, move_it_by_lines): Replace the call
7686 to xfree to an equivalent call to bidi_unshelve_cache.
7687 (move_it_in_display_line_to): Fix logic of returning
7688 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
7690 2011-08-05 Eli Zaretskii <eliz@gnu.org>
7692 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7693 came from a string character with a `cursor' property. (Bug#9229)
7695 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7697 * Makefile.in (LIB_PTHREAD): New variable.
7698 (LIBES): Add LIB_PTHREAD (Bug#9216).
7700 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7701 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7703 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7705 * regex.c (re_iswctype): Remove some redundant boolean conversions.
7707 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7709 * xterm.c (x_find_topmost_parent): New function.
7710 (x_set_frame_alpha): Find topmost parent window with
7711 x_find_topmost_parent and set the property there also (bug#9181).
7712 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7714 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7716 * callproc.c (Fcall_process): Avoid vfork clobbering
7717 the local vars buffer, coding_systems, current_dir.
7719 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7721 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7723 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7725 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7726 so that it is not optimized away.
7728 * xdisp.c (compute_display_string_pos): Remove unused local.
7730 2011-08-02 Eli Zaretskii <eliz@gnu.org>
7732 Fix slow cursor motion and scrolling in large buffers with
7733 selective display, like Org Mode buffers. (Bug#9218)
7735 * dispextern.h (struct bidi_it): New member disp_prop_p.
7737 * xdisp.c: Remove one-slot cache of display string positions.
7738 (compute_display_string_pos): Accept an additional argument
7739 DISP_PROP_P; callers changed. Scan at most 5K characters forward
7740 for a display string or property. If found, set DISP_PROP_P
7743 * bidi.c (bidi_fetch_char): Accept an additional argument
7744 DISP_PROP_P, and pass it to compute_display_string_pos.
7745 Only handle text covered by a display string if DISP_PROP_P is returned
7746 non-zero. All callers of bidi_fetch_char changed.
7748 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7750 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7752 2010-12-03 Don March <don@ohspite.net>
7754 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7755 last character M-[char] is translated to ESC [char] (bug#7541).
7757 2011-08-02 Kenichi Handa <handa@m17n.org>
7759 * lisp.h (uniprop_table): Extern it.
7761 * chartab.c (uniprop_table): Make it non-static.
7763 2011-08-01 Eli Zaretskii <eliz@gnu.org>
7765 * xdisp.c (forward_to_next_line_start): Accept additional argument
7766 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7768 (reseat_at_next_visible_line_start): Use the bidi iterator state
7769 returned by forward_to_next_line_start to restore the state of
7770 it->bidi_it after backing up to previous newline. (Bug#9212)
7772 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7774 * regex.c (re_comp): Protoize.
7775 (re_exec): Fix return type.
7776 (regexec): Fix type of `ret'. (Bug#9203)
7778 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7780 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7781 This is needed if max-image-size is a floating-point number.
7783 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7785 * print.c (print_object): Print empty symbol as ##.
7787 * lread.c (read1): Read ## as empty symbol.
7789 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7791 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7792 setting frame foreground color (Bug#9175).
7793 (x_set_background_color): Likewise.
7795 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7796 contents (Bug#9176).
7797 (EmacsTooltip -init): Remove bezels and add shadows to
7800 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7801 or scroll bar (Bug#8470).
7803 * nsfont.m (nsfont_open): Remove assignment to voffset and
7804 unnecessary vars hshink, expand, hd, full_height, min_height.
7805 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7807 * nsterm.h (nsfont_info): Remove voffset field.
7809 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7811 Implement strike-through and overline on NextStep (Bug#8863).
7813 * nsfont.m (nsfont_open): Use underline position provided by font,
7814 instead of hard-coded value of 2.
7815 (nsfont_draw): Call ns_draw_text_decoration instead.
7817 * nsterm.h: Add declaration for ns_draw_text_decoration.
7819 * nsterm.m (ns_draw_text_decoration): New function for drawing
7820 underline, overline, and strike-through.
7821 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7822 ns_draw_text_decoration. Change treatment of cursor drawing to
7823 accommodate underlining, etc.
7825 2011-07-28 Eli Zaretskii <eliz@gnu.org>
7827 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7830 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7832 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7833 Without this fix, if a signal arrives just after memory fills up,
7834 'malloc' might be invoked reentrantly.
7836 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7837 In other words, assume that every image size is allowed, on non-X
7838 hosts. This assumption is probably wrong, but it lets Emacs compile.
7840 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7842 * regex.c (re_iswctype): Convert return values to boolean.
7844 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7846 * xdisp.c (compute_display_string_pos): Don't use cached display
7847 string position if the buffer had its restriction changed.
7850 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7852 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7854 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7856 Integer signedness and overflow and related fixes. (Bug#9079)
7858 * bidi.c: Integer size and overflow fixes.
7859 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7860 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7861 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7862 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7863 (bidi_find_other_level_edge):
7864 Use ptrdiff_t instead of EMACS_INT where either will do.
7865 This works better on 32-bit hosts configured --with-wide-int.
7866 (bidi_cache_ensure_space): Check for size-calculation overflow.
7867 Use % rather than repeated addition, for better worst-case speed.
7868 Don't set bidi_cache_size until after xrealloc returns, because it
7870 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
7871 (bidi_cache_ensure_space): Also check that the bidi cache size
7872 does not exceed that of the largest Lisp string or buffer. See Eli
7873 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
7875 * alloc.c (__malloc_size_t): Remove.
7876 All uses replaced by size_t. See Andreas Schwab's note
7877 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7879 * image.c: Improve checking for integer overflow.
7880 (check_image_size): Assume that f is nonnull, since
7881 it is always nonnull in practice. This is one less thing to
7882 worry about when checking for integer overflow later.
7883 (x_check_image_size): New function, which checks for integer
7884 overflow issues inside X.
7885 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7886 This removes the need for a memory_full check.
7887 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7888 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7889 (xbm_read_bitmap_data): Change locals back to 'int', since
7890 their values must fit in 'int'.
7891 (xpm_load_image, png_load, tiff_load):
7892 Invoke x_create_x_image_and_pixmap earlier,
7893 to avoid much needless work if the image is too large.
7894 (tiff_load): Treat overly large images as if
7895 x_create_x_image_and_pixmap failed, not as malloc failures.
7896 (gs_load): Use x_check_image_size.
7898 * gtkutil.c: Omit integer casts.
7899 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7900 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7902 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7904 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7905 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7906 would wrongly return t on a 64-bit host.
7908 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7909 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7910 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7911 and therefore cause GCC to emit a bogus diagnostic in some cases.
7913 * image.c: Integer signedness and overflow and related fixes.
7914 This is not an exhaustive set of fixes, but it's time to
7915 record what I've got.
7916 (lookup_pixel_color, check_image_size): Remove redundant decls.
7917 (check_image_size): Don't assume that arbitrary EMACS_INT values
7918 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7919 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7920 (tiff_load, imagemagick_load_image):
7921 Check for overflow in size calculations.
7922 (x_create_x_image_and_pixmap): Remove unnecessary test for
7923 xmalloc returning NULL; that can't happen.
7924 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7925 (xpm_color_bucket): Use better integer hashing function.
7926 (xpm_cache_color): Don't possibly over-allocate memory.
7927 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7928 (gif_memory_source):
7929 Use ptrdiff_t, not int or size_t, to record sizes.
7930 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7931 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7932 either works, as we prefer signed integers.
7933 (tiff_read_from_memory, tiff_write_from_memory):
7934 Return tsize_t, not size_t, since that's what the TIFF API wants.
7935 (tiff_read_from_memory): Don't fail simply because the read would
7936 go past EOF; instead, return a short read.
7937 (tiff_load): Omit no-longer-needed casts.
7938 (Fimagemagick_types): Don't assume size fits into 'int'.
7940 Improve hashing quality when configured --with-wide-int.
7941 * fns.c (hash_string): New function, taken from sxhash_string.
7942 Do not discard information about ASCII character case; this
7943 discarding is no longer needed.
7944 (sxhash-string): Use it. Change sig to match it. Caller changed.
7945 * lisp.h: Declare it.
7946 * lread.c (hash_string): Remove, since we now use fns.c's version.
7947 The fns.c version returns a wider integer if --with-wide-int is
7948 specified, so this should help the quality of the hashing a bit.
7950 * emacs.c: Integer overflow minor fix.
7951 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7952 Define only if GNU_LINUX.
7953 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7955 * dispnew.c: Integer signedness and overflow fixes.
7956 Remove unnecessary forward decls, that were a maintenance hassle.
7957 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7959 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7960 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7961 (prepare_desired_row, line_draw_cost):
7962 Use int, not unsigned, where either works.
7963 (save_current_matrix, restore_current_matrix):
7964 Use ptrdiff_t, not size_t, where either works.
7965 (init_display): Check for overflow more accurately, and without
7966 relying on undefined behavior.
7968 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7969 Remove, replacing with the new symbols in lisp.h. All uses changed.
7970 * fileio.c (make_temp_name):
7971 * filelock.c (lock_file_1, lock_file):
7972 * xdisp.c (message_dolog):
7973 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7974 Use pMd etc. instead.
7975 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7976 replacing the pWIDE etc. symbols removed from editfns.c.
7978 * keyboard.h (num_input_events): Now uintmax_t.
7979 This is (very slightly) less likely to mess up due to wraparound.
7982 * buffer.c: Integer signedness fixes.
7983 (alloc_buffer_text, enlarge_buffer_text):
7984 Use ptrdiff_t rather than size_t when either will do, as we prefer
7987 * alloc.c: Integer signedness and overflow fixes.
7988 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7989 (__malloc_size_t): Default to size_t, not to int.
7990 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7991 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7992 Prefer ptrdiff_t to size_t when either would do, as we prefer
7994 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7995 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7996 Now const. Initialize with values that are in range even if char
7998 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7999 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8000 These functions do the right thing with sizes > 2**32.
8001 (check_depth): Now ptrdiff_t, not int.
8002 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8003 Adjust to new way of storing sizes. Check for size overflow bugs
8005 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8006 slightly wrong anyway, as it missed one instance of
8007 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8008 (refill_memory_reserve): Omit needless cast to size_t.
8009 (mark_object_loop_halt): Mark as externally visible.
8011 * xselect.c: Integer signedness and overflow fixes.
8012 (Fx_register_dnd_atom, x_handle_dnd_message):
8013 Use ptrdiff_t, not size_t, since we prefer signed.
8014 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8015 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8016 x_dnd_atoms_size and x_dnd_atoms_length.
8018 * doprnt.c: Prefer signed to unsigned when either works.
8020 * doprnt.c (doprnt):
8022 * xdisp.c (vmessage):
8023 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8024 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8025 prefer signed arithmetic to avoid comparison confusion.
8026 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8027 but is a bit tricky.
8029 Assume freestanding C89 headers, string.h, stdlib.h.
8030 * data.c, doprnt.c, floatfns.c, print.c:
8031 Include float.h unconditionally.
8032 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8033 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8034 * regex.c: Likewise for stddef.h, string.h.
8035 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8036 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8037 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8038 (STDC_HEADERS): Remove obsolete defines.
8039 * sysdep.c: Include limits.h unconditionally.
8041 Assume support for memcmp, memcpy, memmove, memset.
8042 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8043 * regex.c (memcmp, memcpy):
8044 Remove; we assume C89 now.
8046 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8047 (__malloc_safe_bcopy): Remove; no longer needed.
8049 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
8050 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8051 well either way, and we prefer signed to unsigned.
8053 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8055 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8056 closes the connection while we're reading (bug#9182).
8058 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
8060 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8061 are specified (Bug#9168).
8063 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8065 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8066 Found by GCC static checking and --with-wide-int on a 32-bit host.
8068 2011-07-25 Eli Zaretskii <eliz@gnu.org>
8070 * xdisp.c (compute_display_string_pos): Fix logic of caching
8071 previous display string position. Initialize cached_prev_pos to
8072 -1. Fixes slow-down at the beginning of a buffer.
8074 2011-07-24 Eli Zaretskii <eliz@gnu.org>
8076 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8077 for attrs[LFACE_FONTSET_INDEX].
8079 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8081 * xml.c (parse_region): Remove unused local
8082 that was recently introduced.
8084 2011-07-23 Eli Zaretskii <eliz@gnu.org>
8086 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8087 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8089 * xdisp.c (move_it_in_display_line_to): Record the best matching
8090 position for TO_CHARPOS while scanning the line, and restore it on
8091 exit if none of the characters scanned was an exact match.
8092 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
8093 when exact match is impossible due to invisible text, and the
8094 lines are truncated.
8096 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8098 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8101 2011-07-22 Eli Zaretskii <eliz@gnu.org>
8103 Fix a significant slow-down of cursor motion with C-n, C-p,
8104 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8105 auto-repeat under bidi redisplay in fontified buffers.
8106 * xdisp.c (compute_stop_pos_backwards): New function.
8107 (next_element_from_buffer): Call compute_stop_pos_backwards to
8108 find a suitable prev_stop when we find ourselves before
8110 (reseat): Don't look for prev_stop, as that could mean a very long
8112 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8113 <cached_disp_overlay_modiff>: Cache for last found display string
8115 (compute_display_string_pos): Return the cached position if asked
8116 about the same buffer in the same area of character positions, and
8117 the buffer wasn't changed since the time the display string
8118 position was cached.
8120 2011-07-22 Eli Zaretskii <eliz@gnu.org>
8122 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8123 is an integer, which is important for empty lines. (Bug#9149)
8125 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
8127 * frame.c (Fmodify_frame_parameters): In tty case, update the
8128 default face if necessary (Bug#4238).
8130 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
8132 * editfns.c (Fstring_to_char): No need to explain what a character
8133 is in the docstring (Bug#6576).
8135 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8137 * xml.c (parse_region): Make sure we always return a tree.
8139 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8141 * xml.c (parse_region): If a document contains only comments,
8144 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8146 * xml.c (make_dom): Return comments, too.
8148 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8151 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8152 and the surrounding thread.
8153 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8154 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8155 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8157 * s/openbsd.h (BROKEN_SIGIO): Define.
8158 * unexelf.c (unexec) [__OpenBSD__]:
8159 Don't update the .mdebug section of the Alpha COFF symbol table.
8161 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8163 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8166 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8168 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8169 This fixes some race conditions on the permissions of any newly
8172 * alloc.c (valid_pointer_p): Use pipe, not open.
8173 This fixes some permissions issues when debugging.
8175 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8176 If fchown fails to set both uid and gid, try to set just gid,
8177 as that is sometimes allowed. Adjust the file's mode to eliminate
8178 setuid or setgid bits that are inappropriate if fchown fails.
8180 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8182 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8183 to compare Lisp_Objects.
8184 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8185 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8186 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8188 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8190 * lread.c (read_integer): Unread even EOF character.
8191 (read1): Likewise. Properly record start position of symbol.
8193 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8194 symbol character follows.
8196 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8198 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8199 This works around a problem with the previous change to Fcopy_file.
8200 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8201 and without this change, GCC might complain about discarding
8202 fchown's return value.
8204 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
8206 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8208 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8210 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8212 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8214 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8215 it's used from the C level.
8217 * process.c: Use the same condition for POLL_FOR_INPUT in both
8218 keyboard.c and process.c (bug#1858).
8220 2011-07-09 Lawrence Mitchell <wence@gmx.li>
8222 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8223 (Fgnutls_boot): Use it.
8225 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8227 * doc.c (Fsubstitute_command_keys): Revert last change.
8229 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8231 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8232 quotes the next character, and doesn't affect other longer
8233 sequences (bug#8935).
8235 * lread.c (syms_of_lread): Clarify that is isn't only
8236 `eval-buffer' and `eval-defun' that's affected by
8237 `lexical-binding' (bug#8460).
8239 2011-07-15 Eli Zaretskii <eliz@gnu.org>
8241 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
8242 bidi redisplay when a line includes both an image and is truncated.
8244 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8246 Fix minor problems found by static checking.
8247 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8248 (elsz): Now a signed constant, not a size_t var. We prefer signed
8249 types to unsigned, to avoid integer comparison confusion. Without
8250 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8251 "cannot optimize loop, the loop counter may overflow", a symptom
8253 * indent.c (Fvertical_motion): Mark locals as initialized.
8254 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8256 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8258 * search.c (Fre_search_backward): Mention `case-fold-search' in
8259 all the re_search_* functions (bug#8138).
8261 * keyboard.c (Fopen_dribble_file): Document when the file is
8264 2011-07-14 Eli Zaretskii <eliz@gnu.org>
8266 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8269 Support bidi reordering of display and overlay strings.
8270 * xdisp.c (compute_display_string_pos)
8271 (compute_display_string_end): Accept additional argument STRING.
8272 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8273 (reseat_to_string): Initialize bidi_it->string.s and
8274 bidi_it->string.schars.
8275 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
8276 NULL (avoids a crash in bidi_paragraph_init).
8277 Initialize itb.string.lstring.
8278 (init_iterator): Call bidi_init_it only of a valid
8279 buffer position was specified. Initialize paragraph_embedding to
8281 (reseat_to_string): Initialize the bidi iterator.
8282 (display_string): If we need to ignore text properties of
8283 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8284 original value of -1 will not work with bidi.)
8285 (compute_display_string_pos): First arg is now struct
8286 `text_pos *'; all callers changed. Support display properties on
8288 (compute_display_string_end): Support display properties on Lisp
8290 (init_iterator, reseat_1, reseat_to_string): Initialize the
8291 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8292 when iterating on a string not from display properties).
8293 (compute_display_string_pos, compute_display_string_end):
8294 Fix calculation of the object to scan. Fixes an error when using
8296 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
8297 base_level_stop; instead, set base_level_stop to BEGV.
8298 Fixes crashes in vertical-motion.
8299 (next_element_from_buffer): Improve commentary for when
8300 the iterator is before prev_stop.
8301 (init_iterator): Initialize bidi_p from the default value of
8302 bidi-display-reordering, not from buffer-local value. Use the
8303 buffer-local value only if initializing for buffer iteration.
8304 (handle_invisible_prop): Support invisible properties on strings
8305 that are being bidi-reordered.
8306 (set_iterator_to_next): Support bidi reordering of C strings and
8308 (next_element_from_string): Support bidi reordering of Lisp
8310 (handle_stop_backwards): Support Lisp strings as well.
8311 (display_string): Support display of R2L glyph rows.
8312 Use IT_STRING_CHARPOS when displaying from a Lisp string.
8313 (init_iterator): Don't initialize it->bidi_p for strings
8315 (reseat_to_string): Initialize it->bidi_p for strings here.
8316 (next_element_from_string, next_element_from_c_string)
8317 (next_element_from_buffer): Add xassert's for correspondence
8318 between IT's object being iterated and it->bidi_it.string
8320 (face_before_or_after_it_pos): Support bidi iteration.
8321 (next_element_from_c_string): Handle the case of the first string
8322 character that is not the first one in the visual order.
8323 (get_visually_first_element): New function, refactored from common
8324 parts of next_element_from_buffer, next_element_from_string, and
8325 next_element_from_c_string.
8326 (tool_bar_lines_needed, redisplay_tool_bar)
8327 (display_menu_bar): Force left-to-right direction. Add a FIXME
8328 comment for making that be controlled by a user option.
8329 (push_it, pop_it): Save and restore the state of the
8330 bidi iterator. Save and restore the bidi_p flag.
8331 (pop_it): Iterate out of display property for string iteration as
8333 (iterate_out_of_display_property): Support iteration over strings.
8334 (handle_single_display_spec): Set up it->bidi_it for iteration
8335 over a display string, and call bidi_init_it.
8336 (handle_single_display_spec, next_overlay_string)
8337 (get_overlay_strings_1, push_display_prop): Set up the bidi
8338 iterator for displaying display or overlay strings.
8339 (forward_to_next_line_start): Don't use the shortcut if
8341 (back_to_previous_visible_line_start): If handle_display_prop
8342 pushed the iterator stack, restore the internal state of the bidi
8343 iterator by calling bidi_pop_it same number of times.
8344 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8345 and we are bidi-iterating, don't decrement the iterator position;
8346 instead, set the first_elt flag in the bidi iterator, to produce
8348 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8349 (push_display_prop): xassert that we are iterating a buffer.
8350 (push_it, pop_it): Save and restore paragraph_embedding member.
8351 (handle_single_display_spec, next_overlay_string)
8352 (get_overlay_strings_1, reseat_1, reseat_to_string)
8353 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8354 correctly. Don't assume unibyte strings are not bidi-reordered.
8355 (compute_display_string_pos)
8356 (compute_display_string_end): Fix handling the case of C string.
8357 (push_it, pop_it): Save and restore from_disp_prop_p.
8358 (handle_single_display_spec, push_display_prop): Set the
8359 from_disp_prop_p flag.
8360 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8361 (pop_it): Call iterate_out_of_display_property only if we are
8362 popping after iteration over a string that came from a display
8363 property. Fix a typo in popping stretch info. Add an assertion
8364 for verifying that the iterator position is in sync with the bidi
8366 (handle_single_display_spec, get_overlay_strings_1)
8367 (push_display_prop): Fix initialization of paragraph direction for
8368 string when that of the parent object is not yet determined.
8369 (reseat_1): Call bidi_init_it to resync the bidi
8370 iterator with IT's position. (Bug#7616)
8371 (find_row_edges): If ROW->start.pos gives position
8372 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8373 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8374 Reset the from_disp_prop_p flag.
8375 (SAVE_IT, RESTORE_IT): New macros.
8376 (pos_visible_p, face_before_or_after_it_pos)
8377 (back_to_previous_visible_line_start)
8378 (move_it_in_display_line_to, move_it_in_display_line)
8379 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8380 (try_scrolling, redisplay_window, display_line): Use them when
8381 saving a temporary copy of the iterator and restoring it back.
8382 (back_to_previous_visible_line_start, reseat_1)
8383 (init_iterator): Empty the bidi cache "stack".
8384 (move_it_in_display_line_to): If iterator ended up at
8385 EOL, but we never saw any buffer positions smaller than
8386 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8387 motion in bidi-reordered lines.
8388 (move_it_in_display_line_to): Record prev_method and prev_pos
8389 immediately before the call to set_iterator_to_next. Fixes cursor
8390 motion in bidi-reordered lines with stretch glyphs and strings
8391 displayed in margins. (Bug#8133) (Bug#8867)
8392 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8394 (pos_visible_p): Support positions in bidi-reordered lines.
8395 Save and restore bidi cache.
8397 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8398 (bidi_paragraph_info): Delete unused struct.
8399 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8400 (bidi_cache_start): New variable.
8401 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8403 (bidi_cache_fetch_state, bidi_cache_search)
8404 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8405 (bidi_cache_find, bidi_peek_at_next_level)
8406 (bidi_level_of_next_char, bidi_find_other_level_edge)
8407 (bidi_move_to_visually_next): Compare cache index with
8408 bidi_cache_start rather than with zero.
8409 (bidi_fetch_char): Accept new argument STRING; all callers
8410 changed. Support iteration over a string. Support strings with
8411 display properties. Support unibyte strings. Fix the type of
8412 `len' according to what STRING_CHAR_AND_LENGTH expects.
8413 (bidi_paragraph_init, bidi_resolve_explicit_1)
8414 (bidi_resolve_explicit, bidi_resolve_weak)
8415 (bidi_level_of_next_char, bidi_move_to_visually_next):
8416 Support iteration over a string.
8417 (bidi_set_sor_type, bidi_resolve_explicit_1)
8418 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8419 can now be zero (for strings); special values 0 and -1 were
8420 changed to -1 and -2, respectively.
8421 (bidi_char_at_pos): New function.
8422 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8423 Call it instead of FETCH_MULTIBYTE_CHAR.
8424 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8425 initialized to valid values.
8426 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8428 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8429 the test for valid cached positions. Fix the logic for looking up
8430 the sentinel state in the cache. GCPRO the Lisp string we are
8432 (bidi_push_it, bidi_pop_it): New functions.
8433 (bidi_initialize): Initialize the bidi cache start stack pointer.
8434 (bidi_cache_ensure_space): New function, refactored from part of
8435 bidi_cache_iterator_state. Don't assume the required size is just
8436 one BIDI_CACHE_CHUNK away.
8437 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8438 (bidi_count_bytes, bidi_char_at_pos): New functions.
8439 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8440 always valid if bidi_cache_idx is valid.
8441 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8442 is valid if it's going to be used.
8443 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8444 (bidi_cache_fetch_state, bidi_cache_search)
8445 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8446 (bidi_cache_iterator_state, bidi_cache_find)
8447 (bidi_find_other_level_edge, bidi_cache_start_stack):
8448 All variables related to cache indices are now EMACS_INT.
8450 * dispextern.h (struct bidi_string_data): New structure.
8451 (struct bidi_it): New member `string'. Make flag members be 1-bit
8452 fields, and put them last in the struct.
8453 (compute_display_string_pos, compute_display_string_end):
8455 (bidi_push_it, bidi_pop_it): Add prototypes.
8456 (struct iterator_stack_entry): New members bidi_p,
8457 paragraph_embedding, and from_disp_prop_p.
8458 (struct it): Member bidi_p is now a bit field 1 bit wide.
8459 (bidi_shelve_cache, bidi_unshelve_cache):
8462 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8463 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8464 and vector-like objects.
8466 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8467 cache around display iteration.
8469 * window.c (Fwindow_end, window_scroll_pixel_based)
8470 (displayed_window_lines, Frecenter): Save and restore the bidi
8471 cache around display iteration.
8473 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8475 * editfns.c (Fdelete_region): Clarify the use of the named
8476 parameters (bug#6788).
8478 2011-07-14 Martin Rudalics <rudalics@gmx.at>
8480 * indent.c (Fvertical_motion): Set and restore w->pointm when
8481 saving and restoring the window's buffer (Bug#9006).
8483 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8485 * editfns.c (Fstring_to_char): Clarify just what is returned
8486 (bug#6576). Text by Eli Zaretskii.
8488 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
8490 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8492 2011-07-13 Eli Zaretskii <eliz@gnu.org>
8494 * buffer.c (mmap_find): Fix a typo.
8496 2011-07-13 Johan Bockgård <bojohan@gnu.org>
8498 Fix execution of x selection hooks.
8499 * xselect.c (Qx_lost_selection_functions)
8500 (Qx_sent_selection_functions): New vars.
8501 (syms_of_xselect): DEFSYM them.
8502 (x_handle_selection_request): Pass Qx_sent_selection_functions
8503 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8504 (x_handle_selection_clear,x_clear_frame_selections):
8505 Pass Qx_lost_selection_functions rather than
8506 Vx_lost_selection_functions to Frun_hook_with_args.
8508 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8510 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
8511 The old code sometimes used this field without initializing it.
8513 * alloc.c (gc_sweep): Don't read past end of array.
8514 In theory, the old code could also have corrupted Emacs internals,
8515 though it'd be very unlikely.
8517 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8519 * character.c (Fcharacterp): Don't advertise optional ignored
8520 argument. (Bug#4026)
8522 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8524 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8527 * window.c (Fset_window_start): Doc fix (bug#4199).
8528 (Fset_window_hscroll): Ditto.
8530 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8532 Fix minor new problems caught by GCC 4.6.1.
8533 * term.c (init_tty): Remove unused local.
8534 * xsettings.c (store_monospaced_changed): Define this function only
8535 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
8538 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
8540 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8542 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8544 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8545 are the mini-buffer and the echo area (bug#3320).
8547 * term.c (init_tty): Remove support for supdup, c10 and perq
8548 terminals, which are no longer supported (bug#1482).
8550 2011-07-10 Johan Bockgård <bojohan@gnu.org>
8552 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8554 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8556 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8557 for non-popups (Bug#3642).
8559 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8561 * alloc.c (reset_malloc_hooks): Protoize.
8562 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
8563 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8564 * cm.c (losecursor): Likewise.
8565 * data.c (fmod): Likewise.
8566 * dispnew.c (swap_glyphs_in_rows): Likewise.
8567 * emacs.c (memory_warning_signal): Likewise.
8568 * floatfns.c (float_error): Likewise.
8569 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8570 (otf_open, font_otf_capability, generate_otf_features)
8571 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8573 * image.c (pbm_read_file): Likewise.
8574 * indent.c (string_display_width): Likewise.
8575 * intervals.c (check_for_interval, search_for_interval)
8576 (inc_interval_count, count_intervals, root_interval)
8577 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8578 * lread.c (defalias): Likewise.
8579 * ralloc.c (r_alloc_check): Likewise.
8580 * regex.c (set_image_of_range_1, set_image_of_range)
8581 (regex_grow_registers): Likewise.
8582 * sysdep.c (strerror): Likewise.
8583 * termcap.c (valid_filename_p, tprint, main): Likewise.
8584 * tparam.c (main): Likewise.
8585 * unexhp9k800.c (run_time_remap, save_data_space)
8586 (update_file_ptrs, read_header, write_header, calculate_checksum)
8587 (copy_file, copy_rest, display_header): Likewise.
8588 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8590 * xdisp.c (check_it): Likewise.
8591 * xfaces.c (register_color, unregister_color, unregister_colors):
8593 * xfns.c (print_fontset_result): Likewise.
8594 * xrdb.c (member, fatal, main): Likewise.
8596 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8598 Fix minor problems found by static checking (Bug#9031).
8599 * chartab.c (char_table_set_range, map_sub_char_table):
8600 Remove unused locals.
8601 (uniprop_table): Now static.
8602 * composite.c (_work_char): Remove unused static var.
8604 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
8606 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8608 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8610 * gtkutil.c (qttip_cb): Remove code without function.
8612 2011-07-09 Eli Zaretskii <eliz@gnu.org>
8614 * w32.c (pthread_sigmask): New stub.
8616 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
8618 Use pthread_sigmask, not sigprocmask (Bug#9010).
8619 sigprocmask is portable only for single-threaded applications, and
8620 Emacs can be multi-threaded when it uses GTK.
8621 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8623 * callproc.c (Fcall_process):
8624 * process.c (create_process):
8625 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8626 Use pthread_sigmask, not sigprocmask.
8628 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8630 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8631 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8634 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8636 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8637 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8638 (xg_hide_tooltip): Fix comment.
8640 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8641 in registerServicesMenuSendTypes.
8642 (validRequestorForSendType): Don't check ns_return_types.
8644 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8647 2011-07-08 Jason Rumney <jasonr@gnu.org>
8649 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8650 SH_SHOW for hidden windows (Bug#5482).
8652 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8653 frame struct members of non-existent frames (Bug#6284).
8655 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8657 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8658 variable firstTime not needed on OSX >= 10.6.
8659 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8660 >= 10.5. Use setKnobProportion, setDoubleValue.
8662 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8663 (MAC_OS_X_VERSION_10_5): Define if not defined.
8664 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8665 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8666 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8668 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
8669 cString and lossyCString on OSX >= 10.4.
8671 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
8672 sizeToFit on OSX >= 10.2.
8674 * nsimage.m (allocInitFromFile): Don't use deprecated method
8675 bestRepresentationForDevice on OSX >= 10.6.
8677 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8680 * emacs.c: Declare unexec_init_emacs_zone.
8682 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8684 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8686 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8687 on svcsMenu (Bug#8842).
8689 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8691 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8693 * nsterm.m (QUTF8_STRING): Declare.
8694 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8695 (validRequestorForSendType): Return type is (id).
8696 Change indexOfObjectIdenticalTo to indexOfObject.
8697 Check if we have local selection before returning self (Bug#8842).
8698 (writeSelectionToPasteboard): Put local selection into paste board
8699 if we have a local selection (Bug#8842).
8700 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8702 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8703 (ns_get_local_selection): Declare.
8705 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8707 * keymap.c (describe_map_tree): Don't insert a double newline at
8708 the end of the buffer (bug#1169) and return whether we inserted
8711 * callint.c (Fcall_interactively): Change "reading args" to
8712 "providing args" to try to clarify what it does (bug#1010).
8714 2011-07-07 Kenichi Handa <handa@m17n.org>
8716 * composite.c (composition_compute_stop_pos): Ignore a static
8717 composition starting before CHARPOS (Bug#8915).
8719 * xdisp.c (handle_composition_prop): Likewise.
8721 2011-07-07 Eli Zaretskii <eliz@gnu.org>
8723 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8726 2011-07-07 Kenichi Handa <handa@m17n.org>
8728 * character.h (unicode_category_t): New enum type.
8730 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8731 (Qchar_code_property_table): New variable.
8732 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8733 (UNIPROP_COMPRESSED_FORM_P): New macros.
8734 (char_table_ascii): Uncompress the compressed values.
8735 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8736 Uncompress the compressed values.
8737 (sub_char_table_ref_and_range): Likewise.
8738 (char_table_ref_and_range): Uncompress the compressed values.
8739 (sub_char_table_set): New arg is_uniprop. Callers changed.
8740 Uncompress the compressed values.
8741 (sub_char_table_set_range): Args changed. Callers changed.
8742 (char_table_set_range): Adjuted for the above change.
8743 (map_sub_char_table): Delete args default_val and parent. Add arg
8744 top. Give decoded values to a Lisp function.
8745 (map_char_table): Adjust for the above change. Give decoded
8746 values to a Lisp function. Gcpro more variables.
8747 (uniprop_table_uncompress)
8748 (uniprop_decode_value_run_length): New functions.
8749 (uniprop_decoder, uniprop_decoder_count): New variables.
8750 (uniprop_get_decoder, uniprop_encode_value_character)
8751 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8753 (uniprop_encoder, uniprop_encoder_count): New variables.
8754 (uniprop_get_encoder, uniprop_table)
8755 (Funicode_property_table_internal, Fget_unicode_property_internal)
8756 (Fput_unicode_property_internal): New functions.
8757 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8758 Sunicode_property_table_internal, Sget_unicode_property_internal,
8759 and Sput_unicode_property_internal. Defvar_lisp
8760 char-code-property-alist.
8762 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
8763 Vunicode_category_table.
8765 * font.c (font_range): Adjust for the change of
8766 Vunicode_category_table.
8768 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8770 * m/iris4d.h: Remove file, move contents ...
8771 * s/irix6-5.h: ... here.
8773 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8775 Remove unportable assumption about struct layout (Bug#8884).
8776 * alloc.c (mark_buffer):
8777 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8778 (clone_per_buffer_values): Don't assume that
8779 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8780 This isn't true in general, and it's particularly not true
8781 if Emacs is configured with --with-wide-int.
8782 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8783 New macros, used in the buffer.c change.
8785 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8787 * xsettings.c: Use both GConf and GSettings if both are available.
8788 (store_config_changed_event): Add comment.
8789 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8790 (store_tool_bar_style_changed): New functions.
8791 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
8792 (struct xsettings): Move font inside HAVE_XFT.
8793 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
8794 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
8795 Move inside HAVE_XFT.
8796 (something_changed_gsettingsCB): Rename from something_changedCB.
8797 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8799 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
8800 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
8801 (something_changed_gconfCB): Rename from something_changedCB.
8802 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8803 (parse_settings): Move check for font inside HAVE_XFT.
8804 (read_settings, apply_xft_settings): Add comment.
8805 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8806 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8807 call store_font_name_changed.
8808 (xft_settings_event): Add comment.
8809 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8810 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8811 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8812 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8813 (xsettings_initialize): Call init_gsettings last.
8814 (xsettings_get_system_font, xsettings_get_system_normal_font):
8817 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8819 Random fixes. E.g., (random) never returned negative values.
8820 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8821 subseconds part to the entropy, as that's a bit more random.
8822 Prefer signed to unsigned, since the signedness doesn't matter and
8823 in general we prefer signed. When given a limit, use a
8824 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8825 latter isn't right if USE_2_TAGS_FOR_INTS.
8826 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8827 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8829 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8831 * textprop.c (text_property_stickiness):
8832 Obey Vtext_property_default_nonsticky.
8833 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8834 * w32fns.c (syms_of_w32fns):
8835 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8837 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8839 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8840 This is more efficient than Ffile_directory_p and avoids a minor race.
8842 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8844 * buffer.c (Foverlay_put): Say what the return value is
8847 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8848 is a directory before asking whether to use the file name
8850 (barf_or_query_if_file_exists): Make the "File is a directory"
8851 error be more correct.
8853 * fns.c (Frequire): Remove the mention of the .gz files, since
8854 that's installation-specific, but keep the mention of
8855 `get-load-suffixes'.
8857 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8859 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8860 Report string overflow if the output is too long.
8862 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
8864 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8865 (syms_of_gnutls): Remove duplicate DEFSYM for
8866 Qgnutls_bootprop_verify_hostname_error, an error for
8867 Qgnutls_bootprop_verify_error (which is no longer used).
8869 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8870 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8871 Also (re)move comments that are misplaced or no longer relevant.
8873 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8875 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8877 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
8879 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8880 and background color parameters if they have been changed.
8882 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8884 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8886 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8888 * xsettings.c (SYSTEM_FONT): Define only when used.
8889 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8891 * keymap.c (access_keymap_1): Now static.
8893 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
8895 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8896 leave any prefix arg for the up event (Bug#1586).
8898 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8900 * lread.c (syms_of_lread): Mention single symbols defined by
8901 `defvar' or `defconst' (bug#7154).
8903 * fns.c (Frequire): Mention .el.gz files (bug#7314).
8904 (Frequire): Mention get-load-suffixes.
8906 2011-07-02 Martin Rudalics <rudalics@gmx.at>
8908 * window.h (window): Remove clone_number slot.
8909 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8911 (make_parent_window, make_window, saved_window)
8912 (Fset_window_configuration, save_window_save): Don't deal with
8914 * buffer.c (Qclone_number): Remove declaration.
8915 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8917 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8919 Add multiple inheritance to keymaps.
8920 * keymap.c (Fmake_composed_keymap): New function.
8921 (Fset_keymap_parent): Simplify.
8922 (fix_submap_inheritance): Remove.
8923 (access_keymap_1): New function extracted from access_keymap to handle
8924 embedded parents and handle lists of maps.
8925 (access_keymap): Use it.
8926 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8927 (Fcopy_keymap): Handle embedded parents.
8928 (Fcommand_remapping, define_as_prefix): Simplify.
8929 (Fkey_binding): Simplify.
8930 (syms_of_keymap): Move minibuffer-local-completion-map,
8931 minibuffer-local-filename-completion-map,
8932 minibuffer-local-must-match-map, and
8933 minibuffer-local-filename-must-match-map to Elisp.
8934 (syms_of_keymap): Defsubr make-composed-keymap.
8935 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8936 (parse_menu_item): Trivial simplification.
8938 2011-07-01 Glenn Morris <rgm@gnu.org>
8940 * Makefile.in (SETTINGS_LIBS): Fix typo.
8942 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8944 * coding.c (Fencode_coding_string): Record the last coding system
8945 used, as the function doc string says (bug#8738).
8947 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8949 * xsettings.c (store_monospaced_changed): Take new font as arg and
8950 check for change against current_mono_font.
8951 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8952 (emacs_settings_constructor, emacs_settings_get_property)
8953 (emacs_settings_set_property, emacs_settings_class_init)
8954 (emacs_settings_init, gsettings_obj): Remove.
8955 (something_changedCB): New function for HAVE_GSETTINGS.
8956 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8957 with value as argument.
8958 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8959 g_settings_new (Bug#8967). Do not create gsettings_obj.
8960 Remove calls to g_settings_bind. Connect something_changedCB to
8963 * xgselect.c: Add defined (HAVE_GSETTINGS).
8964 (xgselect_initialize): Ditto.
8966 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8967 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8970 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8972 * eval.c (struct backtrace): Simplify and port the data structure.
8973 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8974 signed bit field, as this assumption is not portable and it makes
8975 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8976 "char debug_on_exit : 1" as this is not portable either; instead,
8977 use the portable "unsigned int debug_on_exit : 1". Remove unused
8978 member evalargs. Remove obsolete comments about cc bombing out.
8980 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8982 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
8983 Let HAVE_GSETTINGS override HAVE_GCONF.
8984 (store_monospaced_changed): New function.
8985 (EMACS_SETTINGS): A new type derived from GObject to handle
8986 GSettings notifications.
8987 (emacs_settings_constructor, emacs_settings_get_property)
8988 (emacs_settings_set_property, emacs_settings_class_init):
8990 (gsettings_client, gsettings_obj): New variables.
8991 (GSETTINGS_SCHEMA): New define.
8992 (something_changedCB): Call store_monospaced_changed.
8993 (init_gsettings): New function.
8994 (xsettings_initialize): Call init_gsettings.
8995 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8998 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9001 2011-06-29 Martin Rudalics <rudalics@gmx.at>
9003 * window.c (resize_root_window, grow_mini_window)
9004 (shrink_mini_window): Rename Qresize_root_window to
9005 Qwindow_resize_root_window and Qresize_root_window_vertically to
9006 Qwindow_resize_root_window_vertically.
9008 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9010 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9012 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
9014 * makefile.w32-in: Redesign dependencies so they reflect more
9015 clearly which files are directly included by each source file,
9016 and not through other includes.
9018 2011-06-27 Martin Rudalics <rudalics@gmx.at>
9020 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9021 (sort_overlays, overlay_strings): When an overlay's clone number
9022 matches the window's clone number process the overlay even if
9023 the overlay's window property doesn't match the current window.
9025 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9026 (Fwindow_hchild): Rename to Fwindow_left_child.
9027 (Fwindow_next): Rename to Fwindow_next_sibling.
9028 (Fwindow_prev): Rename to Fwindow_prev_sibling.
9029 (resize_window_check): Rename to window_resize_check.
9030 (resize_window_apply): Rename to window_resize_apply.
9031 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9032 (Fdelete_other_windows_internal, resize_frame_windows)
9033 (Fsplit_window_internal, Fdelete_window_internal)
9034 (grow_mini_window, shrink_mini_window)
9035 (Fresize_mini_window_internal): Fix callers accordingly.
9037 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9039 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9040 (emacs_fixed_set_min_size): Remove.
9041 (emacs_fixed_new): Take frame as argument.
9043 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9044 (_EmacsFixedPrivate): Remove minwidth/height.
9045 Add struct frame *f.
9046 (emacs_fixed_init): Initialize priv->f.
9047 (get_parent_class, emacs_fixed_set_min_size): Remove.
9048 (emacs_fixed_new): Set priv->f to argument.
9049 (emacs_fixed_get_preferred_width)
9050 (emacs_fixed_get_preferred_height): Use min_width/height from
9051 frames size_hint to set minimum and natural (Bug#8919).
9052 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9053 and use min_width/height from frames size_hint to set
9054 min_width/height (Bug#8919).
9056 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9057 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9060 2011-06-26 Eli Zaretskii <eliz@gnu.org>
9062 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9063 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9066 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
9068 * process.c (wait_reading_process_output): Bypass select if
9069 waiting for a cell while ignoring keyboard input, and input is
9070 pending. Suggested by Jan Djärv (Bug#8869).
9072 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9074 Use gnulib's dup2 module instead of rolling our own.
9075 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9077 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9079 * dispnew.c (scrolling_window): Before scrolling, turn off a
9080 mouse-highlight in the window being scrolled.
9082 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
9084 Move DEFSYM to lisp.h and use everywhere.
9086 * character.h (DEFSYM): Move declaration...
9087 * lisp.h (DEFSYM): ...here.
9093 * w32select.c: Don't include character.h.
9095 * alloc.c (syms_of_alloc):
9096 * buffer.c (syms_of_buffer):
9097 * bytecode.c (syms_of_bytecode):
9098 * callint.c (syms_of_callint):
9099 * casefiddle.c (syms_of_casefiddle):
9100 * casetab.c (init_casetab_once):
9101 * category.c (init_category_once, syms_of_category):
9102 * ccl.c (syms_of_ccl):
9103 * cmds.c (syms_of_cmds):
9104 * composite.c (syms_of_composite):
9105 * dbusbind.c (syms_of_dbusbind):
9106 * dired.c (syms_of_dired):
9107 * dispnew.c (syms_of_display):
9108 * doc.c (syms_of_doc):
9109 * editfns.c (syms_of_editfns):
9110 * emacs.c (syms_of_emacs):
9111 * eval.c (syms_of_eval):
9112 * fileio.c (syms_of_fileio):
9113 * fns.c (syms_of_fns):
9114 * frame.c (syms_of_frame):
9115 * fringe.c (syms_of_fringe):
9116 * insdel.c (syms_of_insdel):
9117 * keymap.c (syms_of_keymap):
9118 * lread.c (init_obarray, syms_of_lread):
9119 * macros.c (syms_of_macros):
9120 * msdos.c (syms_of_msdos):
9121 * print.c (syms_of_print):
9122 * process.c (syms_of_process):
9123 * search.c (syms_of_search):
9124 * sound.c (syms_of_sound):
9125 * syntax.c (init_syntax_once, syms_of_syntax):
9126 * terminal.c (syms_of_terminal):
9127 * textprop.c (syms_of_textprop):
9128 * undo.c (syms_of_undo):
9129 * w32.c (globals_of_w32):
9130 * window.c (syms_of_window):
9131 * xdisp.c (syms_of_xdisp):
9132 * xfaces.c (syms_of_xfaces):
9133 * xfns.c (syms_of_xfns):
9134 * xmenu.c (syms_of_xmenu):
9135 * xsettings.c (syms_of_xsettings):
9136 * xterm.c (syms_of_xterm): Use DEFSYM.
9138 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9140 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
9142 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9144 Integer and buffer overflow fixes (Bug#8873).
9146 * print.c (printchar, strout): Check for string overflow.
9147 (PRINTPREPARE, printchar, strout):
9148 Don't set size unless allocation succeeds.
9150 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9151 for sizes. Check for string overflow more accurately.
9152 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9154 * macros.c: Integer and buffer overflow fixes.
9155 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9156 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9157 Use ptrdiff_t, not int, for sizes.
9158 Don't increment bufsize until after realloc succeeds.
9159 Check for size-calculation overflow.
9160 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9162 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9164 * lread.c: Integer overflow fixes.
9165 (read_integer): Radix is now EMACS_INT, not int,
9166 to improve quality of diagnostics for out-of-range radices.
9167 Calculate buffer size correctly for out-of-range radices.
9168 (read1): Check for integer overflow in radices, and in
9169 read-circle numbers.
9170 (read_escape): Avoid int overflow.
9171 (Fload, openp, read_buffer_size, read1)
9172 (substitute_object_recurse, read_vector, read_list, map_obarray):
9173 Use ptrdiff_t, not int, for sizes.
9174 (read1): Use EMACS_INT, not int, for sizes.
9175 Check for size overflow.
9177 * image.c (cache_image): Check for size arithmetic overflow.
9179 * lread.c: Integer overflow issues.
9180 (saved_doc_string_size, saved_doc_string_length)
9181 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9182 Now ptrdiff_t, not int.
9183 (read1): Don't assume doc string length fits in int. Check for
9184 out-of-range doc string lengths.
9185 (read_list): Don't assume file position fits in int.
9186 (read_escape): Check for hex character overflow.
9188 2011-06-22 Leo Liu <sdl.web@gmail.com>
9190 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9191 Move to minibuffer.el.
9193 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9195 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
9196 The following patches are for when GLYPH_DEBUG && !XASSERT.
9197 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9198 * dispnew.c (flush_stdout):
9199 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9200 Mark as externally visible.
9201 * dispnew.c (check_window_matrix_pointers): Now static.
9202 * dispnew.c (window_to_frame_vpos):
9203 * xfns.c (unwind_create_frame):
9204 * xterm.c (x_check_font): Remove unused local.
9205 * scroll.c (CHECK_BOUNDS):
9206 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9207 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9208 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9209 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9210 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9212 (debug_method_add): Use va_list and vsprintf rather than relying
9213 on undefined behavior with wrong number of arguments.
9214 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9215 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9216 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9217 since we're not interested in debugging glyphs with old libraries.
9218 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9219 GCC 4.6.0's static checking.
9221 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9223 Integer overflow and signedness fixes (Bug#8873).
9224 A few related buffer overrun fixes, too.
9226 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9228 * dispextern.h (struct face.stipple):
9229 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9230 (x_bitmap_mask, x_allocate_bitmap_record)
9231 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9232 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9233 (x_create_bitmap_from_xpm_data):
9234 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9235 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9237 * xfaces.c (load_pixmap):
9238 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9239 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9240 (.bitmaps_last, struct x_output.icon_bitmap):
9241 Use ptrdiff_t, not int, for bitmap indexes.
9242 (x_allocate_bitmap_record): Check for size overflow.
9243 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9245 Use ptrdiff_t, not int, for overlay counts.
9246 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9247 * editfns.c (overlays_around, get_pos_property):
9248 * textprop.c (get_char_property_and_overlay):
9249 * xdisp.c (next_overlay_change, note_mouse_highlight):
9250 * xfaces.c (face_at_buffer_position):
9251 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9252 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9253 (Fnext_overlay_change, Fprevious_overlay_change)
9254 (mouse_face_overlay_overlaps, Foverlays_in):
9255 Use ptrdiff_t, not int, for sizes.
9256 (overlays_at, overlays_in): Check for size-calculation overflow.
9258 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9260 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9261 (x_session_initialize): Do not assume string length fits in int.
9263 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9264 This is unlikely, but can occur if DPI is outlandish.
9266 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
9267 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9269 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9270 * xrdb.c (magic_file_p, search_magic_path):
9271 Omit last arg SUFFIX; it was always 0. All callers changed.
9272 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9274 * xfont.c (xfont_match): Avoid need for strlen.
9276 * xfns.c: Don't assume strlen fits in int.
9277 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9279 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9280 not unsigned long, as we prefer signed integers. All callers changed.
9281 Detect integer overflow in repeat count.
9282 (message_dolog): Don't assume print length fits in 39 bytes.
9283 (display_mode_element): Don't assume strlen fits in int.
9285 * termcap.c: Don't assume sizes fit in int and never overflow.
9286 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9287 (gobble_line): Check for size-calculation overflow.
9289 * minibuf.c (Fread_buffer):
9290 * lread.c (intern, intern_c_string):
9291 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9292 Don't assume string length fits in int.
9294 * keyboard.c (parse_tool_bar_item):
9295 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9297 * font.c: Don't assume string length fits in int.
9298 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9299 Use ptrdiff_t, not int.
9300 (font_intern_prop): Don't assume string length fits in int.
9301 Don't assume integer property fits in fixnum.
9302 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
9304 * filelock.c: Fix some buffer overrun and integer overflow issues.
9305 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
9306 Reformulate so as not to need the command string.
9307 Invoke gzip -cd rather than gunzip, as it's more portable.
9308 (lock_info_type, lock_file_1, lock_file):
9309 Don't assume pid_t and time_t fit in unsigned long.
9310 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9311 (current_lock_owner): Prefer signed type for sizes.
9312 Use memcpy, not strncpy, where memcpy is what is really wanted.
9313 Don't assume (via atoi) that time_t and pid_t fit in int.
9314 Check for time_t and/or pid_t out of range, e.g., via a network share.
9315 Don't alloca where an auto var works fine.
9317 * fileio.c: Fix some integer overflow issues.
9318 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9319 Don't assume string length fits in int.
9320 (directory_file_name): Don't assume string length fits in long.
9321 (make_temp_name): Don't assume pid fits in int, or that its print
9322 length is less than 20.
9324 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9326 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9328 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9330 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9331 We prefer signed integers, even for size calculations.
9333 * emacs.c: Don't assume string length fits in 'int'.
9334 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9335 (main): Don't invoke strlen when not needed.
9337 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9338 (XD_DEBUG_MESSAGE): Don't waste a byte.
9340 * callproc.c (getenv_internal_1, getenv_internal)
9342 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9344 * lread.c (invalid_syntax): Omit length argument.
9345 All uses changed. This doesn't fix a bug, but it simplifies the
9346 code away from its former Hollerith-constant appearance, and it's
9347 one less 'int' to worry about when looking at integer-overflow issues.
9348 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
9350 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9351 This didn't break anything, but it didn't help either.
9352 It's confusing to put a bogus integer in a place where the actual
9353 value does not matter.
9354 (LIST_END_P): Remove unused macro and its bogus comment.
9355 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
9357 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9358 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9360 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9361 We prefer signed types, and the value cannot exceed the EMACS_INT
9362 range anyway (because otherwise the length would not be representable).
9363 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9364 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9365 This avoids a GCC warning when WIDE_EMACS_INT.
9367 * indent.c (sane_tab_width): New function.
9368 (current_column, scan_for_column, Findent_to, position_indentation)
9369 (compute_motion): Use it. This is just for clarity.
9370 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
9372 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
9374 * lisp.h (lint_assume): New macro.
9375 * composite.c (composition_gstring_put_cache):
9376 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9378 * editfns.c, insdel.c:
9379 Omit unnecessary forward decls, to simplify future changes.
9381 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9383 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9385 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
9386 Use much-faster test for byte-length change.
9387 Don't assume string byte-length fits in 'int'.
9388 Check that character arg fits in 'int'.
9389 (mapcar1): Declare byte as byte, for clarity.
9391 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9393 * fns.c (concat): Catch string overflow earlier.
9394 Do not rely on integer wraparound.
9396 * dispextern.h (struct it.overlay_strings_charpos)
9397 (struct it.selective): Now EMACS_INT, not int.
9398 * xdisp.c (forward_to_next_line_start)
9399 (back_to_previous_visible_line_start)
9400 (reseat_at_next_visible_line_start, next_element_from_buffer):
9401 Don't arbitrarily truncate the value of 'selective' to int.
9403 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9405 * composite.c: Don't truncate sizes to 'int'.
9406 (composition_gstring_p, composition_reseat_it)
9407 (composition_adjust_point): Use EMACS_INT, not int.
9408 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9409 not EMACS_UINT, for indexes.
9411 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9413 * buffer.c: Include <verify.h>.
9414 (struct sortvec.priority, struct sortstr.priority):
9415 Now EMACS_INT, not int.
9416 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
9417 (struct sortstr.size, record_overlay_string)
9418 (struct sortstrlist.size, struct sortlist.used):
9419 Don't truncate size to int.
9420 (record_overlay_string): Check for size-calculation overflow.
9421 (init_buffer_once): Check at compile-time, not run-time.
9423 2011-06-22 Jim Meyering <meyering@redhat.com>
9425 Don't leak an XBM-image-sized buffer
9426 * image.c (xbm_load): Free the image buffer after using it.
9428 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9431 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9432 that Sun C diagnosed.
9433 * fns.c (secure_hash): Fix pointer signedness issue.
9434 * intervals.c (static_offset_intervals): New function.
9435 (offset_intervals): Use it.
9437 2011-06-21 Leo Liu <sdl.web@gmail.com>
9440 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9443 * fns.c (secure_hash): Rename from crypto_hash_function and change
9444 the first arg to accept symbols.
9445 (Fsecure_hash): New primitive.
9446 (syms_of_fns): New symbols.
9448 2011-06-20 Deniz Dogan <deniz@dogan.se>
9450 * process.c (Fset_process_buffer): Clarify return value in
9453 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
9455 * dispnew.c (add_window_display_history): Use BVAR.
9457 * xdisp.c (debug_method_add): Use BVAR.
9458 (check_window_end, dump_glyph_matrix, dump_glyph)
9459 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9461 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9464 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9465 check till after the cache is created in init_frame_faces.
9467 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9469 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9471 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9473 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9474 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9475 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9477 Improve buffer-overflow checking (Bug#8873).
9478 * fileio.c (Finsert_file_contents):
9479 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9480 Remove the old (too-loose) buffer overflow checks.
9481 They weren't needed, since make_gap checks for buffer overflow.
9482 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9483 The old code merely checked for Emacs fixnum overflow, and relied
9484 on undefined (wraparound) behavior. The new code avoids undefined
9485 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9487 * editfns.c (Finsert_char): Don't dump core with very negative counts.
9488 Tune. Don't use wider integers than needed. Don't use alloca.
9489 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
9491 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9493 * insdel.c, lisp.h (buffer_overflow): New function.
9494 (insert_from_buffer_1, replace_range, replace_range_2):
9495 * insdel.c (make_gap_larger):
9496 * editfns.c (Finsert_char):
9497 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9499 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9501 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9503 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
9505 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9506 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9508 * fileio.c: Don't assume EMACS_INT fits in off_t.
9509 (emacs_lseek): New static function.
9510 (Finsert_file_contents, Fwrite_region): Use it.
9511 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9513 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9515 * fns.c: Don't overflow int when computing a list length.
9516 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9517 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9518 truncation on 64-bit hosts. Check for QUIT every
9519 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9520 faster and is responsive enough.
9521 (Flength): Report an error instead of overflowing an integer.
9522 (Fsafe_length): Return a float if the value is not representable
9523 as a fixnum. This shouldn't happen except in contrived situations.
9524 (Fnthcdr, Fsort): Don't assume list length fits in int.
9525 (Fcopy_sequence): Don't assume vector length fits in int.
9527 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9528 (header_size, word_size): New constants.
9529 (allocate_vectorlike): Don't check size overflow here.
9530 (allocate_vector): Check it here instead, since this is the only
9531 caller of allocate_vectorlike that could cause overflow.
9532 Check that the new vector's length is representable as a fixnum.
9534 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9535 The previous code was bogus. For example, next_almost_prime (32)
9536 returned 39, which is undesirable as it is a multiple of 3; and
9537 next_almost_prime (24) returned 25, which is a multiple of 5 so
9538 why was the code bothering to check for multiples of 7?
9540 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9542 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9544 Variadic C functions now count arguments with ptrdiff_t.
9545 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9546 Back then I didn't know that the Emacs coding style prefers signed int.
9547 Also, in the meantime I found a few more instances where arguments
9548 were being counted with int, which may truncate counts on 64-bit
9549 machines, or EMACS_INT, which may be unnecessarily wide.
9550 * lisp.h (struct Lisp_Subr.function.aMANY)
9551 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9552 Arg counts are now ptrdiff_t, not size_t.
9553 All variadic functions and their callers changed accordingly.
9554 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9555 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9556 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9557 * callint.c (Fcall_interactively): Check arg count for overflow,
9558 to avoid potential buffer overrun. Use signed char, not 'int',
9559 for 'varies' array, so that we needn't bother to check its size
9560 calculation for overflow.
9561 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9562 * eval.c (apply_lambda):
9563 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9564 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9565 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9567 * callint.c (Fcall_interactively): Don't use index var as event count.
9569 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9570 * mem-limits.h (SIZE): Remove; no longer used.
9572 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
9574 Remove unnecessary casts.
9575 * xterm.c (x_term_init):
9576 * xfns.c (x_set_border_pixel):
9577 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9578 These aren't needed now that we assume ANSI C.
9580 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9581 It's more likely to cause problems (due to unsigned overflow)
9584 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9586 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9588 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9590 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9592 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9594 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9596 GLYPH_CODE_FACE returns EMACS_INT, not int.
9597 * dispextern.h (merge_faces):
9598 * xfaces.c (merge_faces):
9599 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9600 Don't assume EMACS_INT fits in int.
9602 * character.h (CHAR_VALID_P): Remove unused parameter.
9603 * fontset.c, lisp.h, xdisp.c: All uses changed.
9605 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9607 * fns.c (concat): Minor tuning based on overflow analysis.
9608 This doesn't fix any bugs. Use int to hold character, instead
9609 of constantly refetching from Emacs object. Use XFASTINT, not
9610 XINT, for value known to be a character. Don't bother comparing
9611 a single byte to 0400, as it's always less.
9613 * floatfns.c (Fexpt):
9614 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9616 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9619 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9621 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9622 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9623 incorrectly succeed when S was a string, because 4294967386 was
9624 truncated before it was used.
9626 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9627 Otherwise, an out-of-range integer could cause undefined behavior
9630 * composite.c: Use int, not EMACS_INT, for characters.
9631 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9632 EMACS_INT, for values that are known to be in character range.
9633 This doesn't fix any bugs but is the usual style inside Emacs and
9634 may generate better code on 32-bit machines.
9636 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9637 This is for reasons similar to the recent CHAR_STRING fix.
9638 * charset.c (Fencode_char): Check that character arg is actually
9639 a character. Pass an int to ENCODE_CHAR.
9640 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9641 wider than 'int', as a compile-time check to prevent future regressions
9644 * character.c (char_string): Remove unnecessary casts.
9646 Make sure a 64-bit char is never passed to CHAR_STRING.
9647 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9648 by silently ignoring the top 32 bits, allowing some values
9649 that were far too large to be valid characters.
9650 * character.h: Include <verify.h>.
9651 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9652 arguments are no wider than unsigned, as a compile-time check
9653 to prevent future regressions in this area.
9655 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
9656 (Fsubst_char_in_region):
9658 * xdisp.c (decode_mode_spec_coding):
9659 Adjust to CHAR_STRING's new requirement.
9660 * editfns.c (Finsert_char, Fsubst_char_in_region):
9661 * fns.c (concat): Check that character args are actually
9662 characters. Without this test, these functions did the wrong
9663 thing with wildly out-of-range values on 64-bit hosts.
9665 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9666 These casts should not be needed on 32-bit hosts, either.
9667 * keyboard.c (read_char):
9668 * lread.c (Fload): Remove casts to unsigned.
9670 * lisp.h (UNSIGNED_CMP): New macro.
9671 This fixes comparison bugs on 64-bit hosts.
9672 (ASCII_CHAR_P): Use it.
9673 * casefiddle.c (casify_object):
9674 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
9675 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9676 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9677 * dispextern.h (FACE_FROM_ID):
9678 * keyboard.c (read_char): Use UNSIGNED_CMP.
9680 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9681 not to EMACS_INT, to avoid GCC warning.
9683 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9685 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9686 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9687 isn't needed on 32-bit machines.
9689 * buffer.c (Fgenerate_new_buffer_name):
9690 Use EMACS_INT for count, not int.
9691 (advance_to_char_boundary): Return EMACS_INT, not int.
9693 * data.c (Qcompiled_function): Now static.
9695 * window.c (window_body_lines): Now static.
9697 * image.c (gif_load): Rename local to avoid shadowing.
9699 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9700 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9701 * alloc.c (make_save_value): Integer argument is now of type
9703 (mark_object): Use ptrdiff_t, not int.
9704 * lisp.h (pD): New macro.
9705 * print.c (print_object): Use it.
9707 * alloc.c: Use EMACS_INT, not int, to count objects.
9708 (total_conses, total_markers, total_symbols, total_vector_size)
9709 (total_free_conses, total_free_markers, total_free_symbols)
9710 (total_free_floats, total_floats, total_free_intervals)
9711 (total_intervals, total_strings, total_free_strings):
9712 Now EMACS_INT, not int. All uses changed.
9713 (Fgarbage_collect): Compute overall total using a double, so that
9714 integer overflow is less likely to be a problem. Check for overflow
9715 when converting back to an integer.
9716 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9717 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9718 These were 'int' variables that could overflow on 64-bit hosts;
9719 they were never used, so remove them instead of repairing them.
9720 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
9721 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9722 Previously, this ceilinged at INT_MAX, but that doesn't work on
9724 (allocate_pseudovector): Don't use EMACS_INT when int would do.
9726 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
9727 (allocate_vectorlike): Check for ptrdiff_t overflow.
9728 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9729 when a (possibly-narrower) signed value would do just as well.
9730 We prefer using signed arithmetic, to avoid comparison confusion.
9732 * alloc.c: Catch some string size overflows that we were missing.
9733 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9734 for convenience in STRING_BYTES_MAX.
9735 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9736 The definition here is exact; the one in lisp.h was approximate.
9737 (allocate_string_data): Check for string overflow. This catches
9738 some instances we weren't catching before. Also, it catches
9739 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9740 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9741 and ptrdiff_t and EMACS_INT are both 64 bits.
9743 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9744 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
9745 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
9747 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9749 * alloc.c (Fmake_string): Check for out-of-range init.
9751 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9753 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9755 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9757 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9758 xg_get_default_scrollbar_width.
9760 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9761 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9762 (style_changed_cb): Call update_theme_scrollbar_width and call
9763 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9764 all frames (Bug#8505).
9765 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9766 Call gtk_window_set_resizable if HAVE_GTK3.
9767 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9768 and height if HAVE_GTK3 (Bug#8505).
9769 (scroll_bar_width_for_theme): New variable.
9770 (update_theme_scrollbar_width): New function.
9771 (xg_get_default_scrollbar_width): Move code to
9772 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9773 (xg_initialize): Call update_theme_scrollbar_width.
9775 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9777 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9779 2011-06-12 Martin Rudalics <rudalics@gmx.at>
9781 * frame.c (make_frame): Call other_buffer_safely instead of
9784 * window.c (temp_output_buffer_show): Call display_buffer with
9785 second argument Vtemp_buffer_show_specifiers and reset latter
9786 immediately after the call.
9787 (Vtemp_buffer_show_specifiers): New variable.
9788 (auto_window_vscroll_p, next_screen_context_lines)
9789 (Vscroll_preserve_screen_position): Remove leading asterisks from
9792 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
9794 Fix minor problems found by GCC 4.6.0 static checking.
9795 * buffer.c (Qclone_number): Remove for now, as it's unused.
9796 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9797 (record_buffer): Remove unused local.
9798 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9799 (set_frame_buffer_list): Remove; unused.
9800 * frame.h (other_visible_frames): Remove decl.
9801 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9802 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9803 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9805 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9806 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9807 Define only if HAVE_GPM.
9808 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9809 (update_hints_inhibit): Remove; never set. All uses removed.
9810 * widgetprv.h (emacsFrameClassRec): Remove decl.
9811 * window.c (delete_deletable_window): Now returns void, since it
9812 wasn't returning anything.
9813 (compare_window_configurations): Remove unused locals.
9814 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9815 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
9816 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9817 the same widths as pointers. This follows up on the 2011-05-06 patch.
9818 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9819 * xterm.h: Likewise.
9820 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9822 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
9824 * makefile.w32-in: Update dependencies.
9825 (LISP_H): Add lib/intprops.h.
9827 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9829 * image.c (gif_load): Add animation frame delay to the metadata.
9830 (syms_of_image): Use DEFSYM. New symbol `delay'.
9832 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9834 * window.c (delete_deletable_window): Re-add.
9835 (Fset_window_configuration): Rewrite to handle dead buffers and
9836 consequently deletable windows.
9837 (window_tree, Fwindow_tree): Remove. Supply functionality in
9839 (compare_window_configurations): Simplify code.
9841 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9843 * image.c (imagemagick_load_image): Fix type mismatch.
9844 (Fimagemagick_types): Likewise.
9846 * window.h (replace_buffer_in_windows): Declare.
9848 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9850 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9851 Qclone_number. Remove external declaration of Qdelete_window.
9852 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9854 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9855 Run Qbuffer_list_update_hook if allowed.
9856 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9857 buffer list implementation.
9858 (other_buffer_safely): New function.
9859 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9860 calls to replace_buffer_in_windows and
9861 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9863 (record_buffer): Inhibit quitting and rewrite using quittable
9864 functions. Run Qbuffer_list_update_hook if allowed.
9865 (Frecord_buffer, Funrecord_buffer): New functions.
9866 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9867 Move switch-to-buffer to window.el.
9868 (bury-buffer): Move to window.el.
9869 (Vbuffer_list_update_hook): New variable.
9871 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9874 * window.h (resize_frame_windows): Move up in code.
9875 (Fwindow_frame): Remove EXFUN.
9876 (replace_buffer_in_all_windows): Remove prototype.
9877 (replace_buffer_in_windows_safely): Add prototype.
9879 * window.c: Declare Qdelete_window static again. Move down
9880 declaration of select_count.
9881 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9882 (Fother_window): Move to window.el.
9883 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9884 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9885 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9887 (replace_buffer_in_windows): Implement by calling
9888 Qreplace_buffer_in_windows.
9889 (replace_buffer_in_all_windows): Remove with some functionality
9890 moved into replace_buffer_in_windows_safely.
9891 (replace_buffer_in_windows_safely): New function.
9892 (select_window_norecord, select_frame_norecord): Move in front
9893 of run_window_configuration_change_hook. Remove now obsolete
9895 (Fset_window_buffer): Rewrite doc-string.
9896 Call Qrecord_window_buffer.
9897 (keys_of_window): Move binding for other-window to window.el.
9899 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9901 * dispextern.h (struct image): Replace data member, whose int_val
9902 and ptr_val fields were not used by anything, with a single
9905 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9906 (gif_clear_image, gif_load, imagemagick_load_image)
9907 (gs_clear_image, gs_load): Callers changed.
9909 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9911 * buffer.h: Include <time.h>, for time_t.
9912 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9914 Fix minor problems found by static checking.
9916 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9918 Make identifiers static if they are not used in other modules.
9919 * data.c (Qcompiled_function, Qframe, Qvector):
9920 * image.c (QimageMagick, Qsvg):
9921 * minibuf.c (Qmetadata):
9922 * window.c (resize_window_check, resize_root_window): Now static.
9923 * window.h (resize_window_check, resize_root_window): Remove decls.
9925 * window.c (window_deletion_count, delete_deletable_window):
9927 (window_body_lines): Now static.
9928 (Fdelete_other_windows_internal): Mark vars as initialized.
9929 Make sure 'resize_failed' is initialized.
9930 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9931 (resize_window_apply): Remove unused local.
9932 * window.h (delete_deletable_window): Remove decl.
9934 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
9935 (imagemagick_load_image): Fix pointer signedness problem by changing
9936 last arg from unsigned char * to char *. All uses changed.
9937 Also, fix a local for similar reasons.
9938 Remove unused locals. Remove locals to avoid shadowing.
9939 (fn_rsvg_handle_free): Remove; unused.
9940 (svg_load, svg_load_image): Fix pointer signedness problem.
9941 (imagemagick_load_image): Don't use garbage pointer image_wand.
9943 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9945 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
9947 * image.c (gif_load): Fix omitted cast error introduced by
9950 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9952 * window.h (resize_proportionally, orig_total_lines)
9953 (orig_top_line): Remove from window structure.
9954 (set_window_height, set_window_width, change_window_heights)
9955 (Fdelete_window): Remove prototypes.
9956 (resize_frame_windows): Remove duplicate declaration.
9958 2011-06-10 Eli Zaretskii <eliz@gnu.org>
9960 * window.h (resize_frame_windows, resize_window_check)
9961 (delete_deletable_window, resize_root_window)
9962 (resize_frame_windows): Declare prototypes.
9964 * window.c (resize_window_apply): Make definition be "static" to
9965 match the prototype.
9967 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9969 * window.c: Remove declarations of Qwindow_size_fixed,
9970 window_min_size_1, window_min_size_2, window_min_size,
9971 size_window, window_fixed_size_p, enlarge_window, delete_window.
9972 Remove static from declaration of Qdelete_window, it's
9973 temporarily needed by Fbury_buffer.
9974 (replace_window): Don't assign orig_top_line and
9976 (Fdelete_window, delete_window): Remove. Window deletion is
9977 handled by window.el.
9978 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9979 Replace Fdelete_window calls with calls to Qdelete_window.
9980 (Fdelete_other_windows): Remove. Deleting other windows is
9981 handled by window.el.
9982 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9983 handled in window.el.
9984 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9985 Window minimum sizes are handled in window.el.
9986 (shrink_windows, size_window, set_window_height)
9987 (set_window_width, change_window_heights, window_height)
9988 (window_width, CURBEG, CURSIZE, enlarge_window)
9989 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9990 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9991 handled in window.el.
9992 (make_dummy_parent): Rename to make_parent_window and give it a
9993 second argument horflag.
9994 (make_window): Don't set resize_proportionally any more.
9995 (Fsplit_window): Remove. Windows are split in window.el.
9996 (save_restore_action, save_restore_orig_size)
9997 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9998 Resize mini windows in window.el.
9999 (grow_mini_window, shrink_mini_window): Implement by calling
10000 Qresize_root_window_vertically, resize_window_check and
10001 resize_window_apply.
10002 (saved_window, Fset_window_configuration, save_window_save):
10003 Do not handle orig_top_line, orig_total_lines, and
10004 resize_proportionally.
10005 (window_min_height, window_min_width): Move to window.el.
10006 (keys_of_window): Move bindings for delete-other-windows,
10007 split-window, delete-window and enlarge-window to window.el.
10009 * buffer.c: Temporarily extern Qdelete_window.
10010 (Fbury_buffer): Temporarily call Qdelete_window instead of
10011 Fdelete_window (Fbury_buffer will move to window.el soon).
10013 * frame.c (set_menu_bar_lines_1): Remove code handling
10014 orig_top_line and orig_total_lines.
10016 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10017 set_window_height but set heights directly.
10018 (change_frame_size_1): Use resize_frame_windows.
10020 * xdisp.c (init_xdisp): Don't use set_window_height but set
10023 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10024 Use resize_frame_windows instead of change_window_heights and run
10025 run_window_configuration_change_hook.
10027 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10028 instead of change_window_heights and run
10029 run_window_configuration_change_hook.
10031 2011-06-09 Martin Rudalics <rudalics@gmx.at>
10033 * window.c (replace_window): Rename second argument REPLACEMENT to
10034 NEW. New third argument SETFLAG. Rewrite.
10035 (delete_window, make_dummy_parent): Call replace_window with
10037 (window_list_1): Move down in code.
10038 (run_window_configuration_change_hook): Move set_buffer part
10039 before select_frame_norecord part in order to unwind correctly.
10040 Rename count1 to count.
10041 (recombine_windows, delete_deletable_window, resize_root_window)
10042 (Fdelete_other_windows_internal)
10043 (Frun_window_configuration_change_hook, make_parent_window)
10044 (resize_window_check, resize_window_apply, Fresize_window_apply)
10045 (resize_frame_windows, Fsplit_window_internal)
10046 (Fdelete_window_internal, Fresize_mini_window_internal):
10048 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10050 2011-06-08 Martin Rudalics <rudalics@gmx.at>
10052 * window.h (window): Add some new members to window structure -
10053 normal_lines, normal_cols, new_total, new_normal, clone_number,
10054 splits, nest, prev_buffers, next_buffers.
10055 (WINDOW_TOTAL_SIZE): Move here from window.c.
10056 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
10058 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10060 (make_dummy_parent): Set new members of windows structure.
10061 (make_window): Move down in code. Handle new members of window
10063 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10064 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10065 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10066 (Fset_window_prev_buffers, Fwindow_next_buffers)
10067 (Fset_window_next_buffers, Fset_window_clone_number):
10069 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10070 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10072 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10073 Argument WINDOW can be now internal window too.
10074 (Fwindow_use_time): Move up in code.
10075 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10076 Rewrite doc-string.
10077 (Fset_window_configuration, saved_window)
10078 (Fcurrent_window_configuration, save_window_save): Handle new
10079 members of window structure.
10080 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10081 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10082 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10083 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10084 Qget_mru_window, Qresize_root_window,
10085 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10086 Qauto_buffer_name; staticpro them.
10088 2011-06-07 Martin Rudalics <rudalics@gmx.at>
10090 * window.c (Fwindow_total_size, Fwindow_left_column)
10091 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10092 (Fwindow_list_1): New functions.
10093 (window_box_text_cols): Replace with window_body_cols.
10094 (Fwindow_width, Fscroll_left, Fscroll_right):
10095 Use window_body_cols instead of window_box_text_cols.
10096 (delete_window, Fset_window_configuration):
10097 Call delete_all_subwindows with window as argument.
10098 (delete_all_subwindows): Take a window as argument and not a
10099 structure. Rewrite.
10100 (window_loop): Remove handling of GET_LRU_WINDOW and
10101 GET_LARGEST_WINDOW.
10102 (Fget_lru_window, Fget_largest_window): Move to window.el.
10104 * window.h: Extern window_body_cols instead of
10105 window_box_text_cols. delete_all_subwindows now takes a
10106 Lisp_Object as argument.
10108 * indent.c (compute_motion, Fcompute_motion):
10109 Use window_body_cols instead of window_box_text_cols.
10111 * frame.c (delete_frame): Call delete_all_subwindows with root
10112 window as argument.
10114 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10116 * fns.c (Fputhash): Document return value.
10118 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
10120 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10122 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10124 Cons<->int and similar integer overflow fixes (Bug#8794).
10126 Check for overflow when converting integer to cons and back.
10127 * charset.c (Fdefine_charset_internal, Fdecode_char):
10128 Use cons_to_unsigned to catch overflow.
10129 (Fencode_char): Use INTEGER_TO_CONS.
10130 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10131 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10132 * data.c (long_to_cons, cons_to_long): Remove.
10133 (cons_to_unsigned, cons_to_signed): New functions.
10134 These signal an error for invalid or out-of-range values.
10135 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10136 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10137 * font.c (Ffont_variation_glyphs):
10138 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10139 * lisp.h: Include <intprops.h>.
10140 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10141 (cons_to_signed, cons_to_unsigned): New decls.
10142 (long_to_cons, cons_to_long): Remove decls.
10143 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10144 (Fprimitive_undo): Use CONS_TO_INTEGER.
10145 * xfns.c (Fx_window_property): Likewise.
10146 * xselect.c: Include <limits.h>.
10147 (x_own_selection, selection_data_to_lisp_data):
10148 Use INTEGER_TO_CONS.
10149 (x_handle_selection_request, x_handle_selection_clear)
10150 (x_get_foreign_selection, Fx_disown_selection_internal)
10151 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10152 (lisp_data_to_selection_data): Use cons_to_unsigned.
10153 (x_fill_property_data): Use cons_to_signed.
10154 Report values out of range.
10156 Check for buffer and string overflow more precisely.
10157 * buffer.h (BUF_BYTES_MAX): New macro.
10158 * lisp.h (STRING_BYTES_MAX): New macro.
10159 * alloc.c (Fmake_string):
10160 * character.c (string_escape_byte8):
10161 * coding.c (coding_alloc_by_realloc):
10162 * doprnt.c (doprnt):
10163 * editfns.c (Fformat):
10165 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10166 since they may not be the same number.
10167 * editfns.c (Finsert_char):
10168 * fileio.c (Finsert_file_contents):
10169 Likewise for BUF_BYTES_MAX.
10171 * image.c: Use ptrdiff_t, not int, for sizes.
10172 (slurp_file): Switch from int to ptrdiff_t.
10174 (slurp_file): Check that file size fits in both size_t (for
10175 malloc) and ptrdiff_t (for sanity and safety).
10177 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10178 if b->modtime has its maximal value.
10180 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10182 Don't assume time_t can fit into int.
10183 * buffer.h (struct buffer.modtime): Now time_t, not int.
10184 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10185 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10187 Minor fixes for signed vs unsigned integers.
10188 * character.h (MAYBE_UNIFY_CHAR):
10189 * charset.c (maybe_unify_char):
10190 * keyboard.c (read_char, reorder_modifiers):
10191 XINT -> XFASTINT, since the integer must be nonnegative.
10192 * ftfont.c (ftfont_spec_pattern):
10193 * keymap.c (access_keymap, silly_event_symbol_error):
10194 XUINT -> XFASTINT, since the integer must be nonnegative.
10195 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10196 since it makes no difference and we prefer signed.
10197 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10198 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10201 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10203 * window.h (Fwindow_frame): Declare.
10205 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10207 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10208 (SPARE_MEMORY): Always define.
10209 (LARGE_REQUEST): Remove.
10210 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10212 2011-06-06 Martin Rudalics <rudalics@gmx.at>
10214 * lisp.h: Move EXFUNS for Fframe_root_window,
10215 Fframe_first_window and Fset_frame_selected_window to window.h.
10217 * window.h: Move EXFUNS for Fframe_root_window,
10218 Fframe_first_window and Fset_frame_selected_window here from
10221 * frame.c (Fwindow_frame, Fframe_first_window)
10222 (Fframe_root_window, Fframe_selected_window)
10223 (Fset_frame_selected_window): Move to window.c.
10224 (Factive_minibuffer_window): Move to minibuf.c.
10225 (Fother_visible_frames_p): New function.
10227 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10229 * window.c (decode_window, decode_any_window): Move up in code.
10230 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10231 (inhibit_frame_unsplittable): Remove unused variable.
10232 (Fwindow_buffer): Move up and rewrite doc-string.
10233 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10234 (Fwindow_prev): New functions.
10235 (Fwindow_frame): Move here from frame.c. Accept any window as
10237 (Fframe_root_window, Fframe_first_window)
10238 (Fframe_selected_window): Move here from frame.c. Accept frame
10239 or arbitrary window as argument. Update doc-strings.
10240 (Fminibuffer_window): Move up in code.
10241 (Fwindow_minibuffer_p): Move up in code and simplify.
10242 (Fset_frame_selected_window): Move here from frame.c.
10244 (Fselected_window, select_window, Fselect_window): Move up in
10245 code. Minor doc-string fixes.
10247 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10249 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10250 Do not assume that spare memory exists; that assumption is valid
10251 only if SYSTEM_MALLOC.
10252 (LARGE_REQUEST): New macro, so that the issue of large requests
10253 is separated from the issue of spare memory.
10255 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10257 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10260 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10262 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10265 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10267 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10269 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10271 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10272 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10274 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
10276 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10278 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
10280 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10281 (x_clipboard_manager_save): Add return value.
10282 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10283 New error handlers.
10284 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10285 Obey Vx_select_enable_clipboard_manager. Catch errors in
10286 x_clipboard_manager_save (Bug#8779).
10287 (Vx_select_enable_clipboard_manager): New variable.
10288 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
10290 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
10292 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10294 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10296 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10297 in the current matrix if keep_current_p is non-zero.
10299 2011-06-04 Eli Zaretskii <eliz@gnu.org>
10301 * bidi.c (bidi_level_of_next_char): Fix last change.
10303 2011-06-03 Eli Zaretskii <eliz@gnu.org>
10305 Support bidi reordering of text covered by display properties.
10307 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10308 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10309 (bidi_cache_search, bidi_cache_iterator_state)
10310 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
10311 (bidi_level_of_next_char, bidi_move_to_visually_next):
10312 Support character positions inside a run of characters covered by a
10314 (bidi_paragraph_init, bidi_resolve_explicit_1)
10315 (bidi_level_of_next_char): Call bidi_fetch_char and
10316 bidi_fetch_char_advance instead of FETCH_CHAR and
10317 FETCH_CHAR_ADVANCE.
10318 (bidi_init_it): Initialize new members.
10319 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10321 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10322 instead of using explicit *_CHAR codes.
10323 (bidi_resolve_explicit, bidi_resolve_weak):
10324 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
10325 bidirectional text is supported only in multibyte buffers.
10326 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10327 it to initialize the frame_window_p member of struct bidi_it.
10328 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10329 (bidi_resolve_explicit, bidi_resolve_weak)
10330 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10331 bidi_it->nchars is non-positive.
10332 (bidi_level_of_next_char): Don't try to lookup the cache for the
10333 next/previous character if nothing is cached there yet, or if we
10334 were just reseat()'ed to a new position.
10336 * xdisp.c (set_cursor_from_row): Set start and stop points
10337 according to the row's direction when priming the loop that looks
10338 for the glyph on which to display cursor.
10339 (single_display_spec_intangible_p): Function deleted.
10340 (display_prop_intangible_p): Reimplement to call
10341 handle_display_spec instead of single_display_spec_intangible_p.
10342 Accept 3 additional arguments needed by handle_display_spec.
10343 This fixes incorrect cursor motion across display property with complex
10344 values: lists, `(when COND...)' forms, etc.
10345 (single_display_spec_string_p): Support property values that are
10346 lists with the argument STRING its top-level element.
10347 (display_prop_string_p): Fix the condition for processing a
10348 property that is a list to be consistent with handle_display_spec.
10349 (handle_display_spec): New function, refactored from the
10350 last portion of handle_display_prop.
10351 (compute_display_string_pos): Accept additional argument
10352 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10353 value of a `display' property is a "replacing spec".
10354 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10355 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10356 the display property, but just return a value indicating whether
10357 the display property will replace the characters it covers.
10358 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10359 frame_window_p members of struct bidi_it.
10360 (compute_display_string_pos, compute_display_string_end):
10362 (push_it): Accept second argument POSITION, where pop_it should
10363 jump to continue iteration.
10364 (reseat_1): Initialize bidi_it.disp_pos.
10366 * keyboard.c (adjust_point_for_property): Adjust the call to
10367 display_prop_intangible_p to its new signature.
10369 * dispextern.h (struct bidi_it): New member frame_window_p.
10370 (bidi_init_it): Update prototypes.
10371 (display_prop_intangible_p): Update prototype.
10372 (compute_display_string_pos, compute_display_string_end):
10373 Declare prototypes.
10374 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10377 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
10379 Malloc failure behavior now depends on size of allocation.
10380 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10381 * lisp.h: Change signatures accordingly.
10382 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10383 All callers changed. (Bug#8762)
10385 * gnutls.c: Use Emacs's memory allocators.
10386 Without this change, the gnutls library would invoke malloc etc.
10387 directly, which causes problems on non-SYNC_INPUT hosts, and which
10388 runs afoul of improving memory_full behavior. (Bug#8761)
10389 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10390 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10391 xfree instead of the default malloc, realloc, free.
10392 (Fgnutls_boot): No need to check for memory allocation failure,
10393 since xmalloc does that for us.
10395 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
10396 * category.c (hash_get_category_set):
10397 * ccl.c (ccl_driver):
10398 * charset.c (Fdefine_charset_internal):
10399 * charset.h (struct charset.hash_index):
10400 * composite.c (get_composition_id, gstring_lookup_cache)
10401 (composition_gstring_put_cache):
10402 * composite.h (struct composition.hash_index):
10403 * dispextern.h (struct image.hash):
10404 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10405 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10406 (hashfn_equal, hashfn_user_defined, make_hash_table)
10407 (maybe_resize_hash_table, hash_lookup, hash_put)
10408 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10409 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10410 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10411 * image.c (make_image, search_image_cache, lookup_image)
10412 (xpm_put_color_table_h):
10413 * lisp.h (struct Lisp_Hash_Table):
10414 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
10415 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
10416 for hashes and hash indexes, instead of 'unsigned' and 'int'.
10417 * alloc.c (allocate_vectorlike):
10418 Check for overflow in vector size calculations.
10419 * ccl.c (ccl_driver):
10420 Check for overflow when converting EMACS_INT to int.
10421 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10422 need to be updated by these changes.
10423 * fns.c (make_hash_table, maybe_resize_hash_table):
10424 Check for integer overflow with large hash tables.
10425 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10426 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10427 (SXHASH_REDUCE): New macro.
10428 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10429 Use it instead of discarding useful hash info with large hash values.
10430 (sxhash_float): New function.
10431 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10432 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
10433 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10434 Rewrite to use FIXNUM_BITS, as this simplifies things.
10435 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10436 Adjust signatures to match updated version of code.
10437 (consing_since_gc): Now EMACS_INT, since a single hash table can
10438 use more than INT_MAX bytes.
10440 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10442 Make it possible to build with GCC-4.6+ -O2 -flto.
10444 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10446 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10448 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10449 Call minibuffer-inactive-mode.
10451 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
10453 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10454 Update dependencies.
10456 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10458 * data.c (init_data): Remove code for UTS, this system is not
10461 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10463 Don't force ./temacs to start in terminal mode.
10465 * frame.c (make_initial_frame): Initialize faces in all cases, not
10466 only when CANNOT_DUMP is defined.
10467 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10469 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10471 * dispnew.c (add_window_display_history): Use const for the string
10472 pointer. Remove declaration, not needed.
10474 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10476 Use 'inline', not 'INLINE'.
10477 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
10478 * alloc.c, fontset.c (INLINE): Remove.
10479 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10480 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10481 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10482 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10483 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10485 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10487 Make it possible to run ./temacs.
10489 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10490 syms_of_callproc does the same thing. Remove test for
10491 "initialized", do it in the caller.
10492 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10494 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10496 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10497 (read_minibuf): Use get_minibuffer.
10498 (syms_of_minibuf): Use DEFSYM.
10499 (Qmetadata): New var.
10500 * data.c (Qbuffer): Don't make it static.
10501 (syms_of_data): Use DEFSYM.
10503 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10505 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10506 (CCL_CODE_MIN): New macro.
10508 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10510 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10512 * eval.c (Qdebug): Now static.
10513 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10514 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10515 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10517 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
10519 * image.c: Various fixes to ImageMagick code comments.
10520 (Fimagemagick_types): Doc fix.
10522 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10524 Minor fixes prompted by GCC 4.6.0 warnings.
10526 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10528 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10529 (x_clipboard_manager_save_all): Move extern decl to ...
10530 * xterm.h: ... here, so that it can be checked for consistency.
10532 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
10534 * xselect.c (x_clipboard_manager_save_frame)
10535 (x_clipboard_manager_save_all): New functions.
10536 (Fx_clipboard_manager_save): Lisp function deleted.
10538 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10539 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10541 * xterm.h: Update prototype.
10543 2011-05-28 William Xu <william.xwl@gmail.com>
10545 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10546 exiting (Bug#8239).
10548 2011-05-28 Jim Meyering <meyering@redhat.com>
10550 Avoid a sign-extension bug in crypto_hash_function.
10551 * fns.c (to_uchar): Define.
10552 (crypto_hash_function): Use it to convert some newly-signed
10553 variables to unsigned, to avoid sign-extension bugs. For example,
10554 without this change, (md5 "truc") would evaluate to
10555 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10556 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
10557 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
10559 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10561 Integer overflow fixes.
10563 * dbusbind.c: Serial number integer overflow fixes.
10564 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
10565 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10566 to hold a serial number that is too large for a fixnum.
10567 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10568 Check for serial numbers out of range. Decode any serial number
10569 that was so large that it became a float. (Bug#8722)
10571 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10572 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10573 Use XFASTINT rather than XUINT when numbers are nonnegative.
10574 (xd_append_arg, Fdbus_method_return_internal):
10575 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10576 arguments, check that Lisp number is nonnegative, rather than
10577 silently wrapping negative numbers around. (Bug#8722)
10578 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
10581 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10583 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10585 ccl: Add integer overflow checks.
10586 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10587 (IN_INT_RANGE): New macros.
10588 (ccl_driver): Use them to check for integer overflow when
10589 decoding a CCL program. Many of the new checks are whether XINT (x)
10590 fits in int; it doesn't always, on 64-bit hosts. The new version
10591 doesn't catch all possible integer overflows, but it's an
10592 improvement. (Bug#8719)
10594 * alloc.c (make_event_array): Use XINT, not XUINT.
10595 There's no need for unsigned here.
10597 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10598 This follows up to the 2011-05-06 change that substituted uintptr_t
10599 for EMACS_INT. This case wasn't caught back then.
10601 Rework Fformat to avoid integer overflow issues.
10602 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10603 now (part of C89). Include <verify.h>.
10604 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10605 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10606 (Fformat): Avoid the prepass trying to compute sizes; it was only
10607 approximate and thus did not catch overflow reliably. Instead, walk
10608 through the format just once, formatting and computing sizes as we go,
10609 checking for integer overflow at every step, and allocating a larger
10610 buffer as needed. Keep track separately whether the format is
10611 multibyte. Keep only the most-recently calculated precision, rather
10612 than them all. Record whether each argument has been converted to
10613 string. Use EMACS_INT, not int, for byte and char and arg counts.
10614 Support field widths and precisions larger than INT_MAX. Avoid
10615 sprintf's undefined behavior with conversion specifications such as %#d
10616 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10617 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10618 formatting out-of-range floating point numbers with int
10619 formats. (Bug#8668)
10621 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10623 * data.c: Avoid integer truncation in expressions involving floats.
10624 * data.c: Include <intprops.h>.
10625 (arith_driver): When there's an integer overflow in an expression
10626 involving floating point, convert the integers to floating point
10627 so that the resulting value does not suffer from catastrophic
10628 integer truncation. For example, on a 64-bit host (* 4
10629 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10630 Do not rely on undefined behavior after integer overflow.
10632 merge count_size_as_multibyte, parse_str_to_multibyte
10633 * character.c, character.h (count_size_as_multibyte):
10634 Rename from parse_str_to_multibyte; all uses changed.
10635 Check for integer overflow.
10636 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10637 since it's now a duplicate of the other. This is more of
10638 a character than a buffer op, so better that it's in character.c.
10639 * fns.c, print.c: Adjust to above changes.
10641 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10643 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10645 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10647 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10648 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10649 (x_clipboard_manager_save): Now static.
10650 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10652 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10653 (crypto_hash_function): Now static.
10654 Fix pointer signedness problems. Avoid unnecessary initializations.
10656 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
10658 * termhooks.h (Vselection_alist): Make it terminal-local.
10660 * terminal.c (create_terminal): Initialize it.
10662 * xselect.c: Support for clipboard managers.
10663 (Vselection_alist): Move to termhooks.h as terminal-local var.
10664 (LOCAL_SELECTION): New macro.
10665 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10666 (symbol_to_x_atom): Remove gratuitous arg.
10667 (x_handle_selection_request, lisp_data_to_selection_data)
10668 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
10669 (x_own_selection, x_get_local_selection, x_convert_selection):
10670 New arg, specifying work frame. Use terminal-local Vselection_alist.
10671 (some_frame_on_display): Delete unused function.
10672 (Fx_own_selection_internal, Fx_get_selection_internal)
10673 (Fx_disown_selection_internal, Fx_selection_owner_p)
10674 (Fx_selection_exists_p): New optional frame arg.
10675 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10676 (x_handle_selection_clear): Don't treat other terminals with the
10677 same keyboard specially. Use the terminal-local Vselection_alist.
10678 (x_clear_frame_selections): Use Frun_hook_with_args.
10680 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10682 * xterm.h: Add support for those atoms.
10684 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
10686 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10687 (converted_selections, conversion_fail_tag): New global variables.
10688 (x_selection_request_lisp_error): Free the above.
10689 (x_get_local_selection): Remove unnecessary code.
10690 (x_reply_selection_request): Args changed; handle arbitrary array
10691 of converted selections stored in converted_selections.
10692 Separate the XChangeProperty and SelectionNotify steps.
10693 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10694 (x_convert_selection): New function.
10695 (x_handle_selection_event): Simplify.
10696 (x_get_foreign_selection): Don't ignore incoming requests while
10697 waiting for an answer; this will fail when we implement
10698 SAVE_TARGETS, and seems unnecessary anyway.
10699 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10700 (Vx_sent_selection_functions): Doc fix.
10702 2011-05-26 Leo Liu <sdl.web@gmail.com>
10704 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10706 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10708 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10710 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10711 for fringe update if it has periodic bitmap.
10712 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
10713 and fringe_bitmap_periodic_p.
10715 * fringe.c (get_fringe_bitmap_data): New function.
10716 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10717 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10718 row. Mark glyph row for fringe update if periodicity changed.
10720 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10721 for fringe update unless it has periodic bitmap.
10723 2011-05-25 Kenichi Handa <handa@m17n.org>
10725 * xdisp.c (get_next_display_element): Set correct it->face_id for
10726 a static composition.
10728 2011-05-24 Leo Liu <sdl.web@gmail.com>
10731 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10733 * fns.c (crypto_hash_function, Fsha1): New function.
10734 (Fmd5): Use crypto_hash_function.
10735 (syms_of_fns): Add Ssha1.
10737 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10739 * gnutls.c: Remove unused macros.
10740 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10741 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10742 Remove macros that are defined and never used.
10743 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10745 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
10747 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10748 (Fx_get_selection_internal): Minor cleanup.
10749 (Fx_own_selection_internal): Rename arguments for consistency with
10752 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10754 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10756 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
10758 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10760 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10762 * dispnew.c (scrolling_window): Don't exclude the case that the
10763 last enabled row in the desired matrix touches the bottom boundary.
10765 2011-05-21 Glenn Morris <rgm@gnu.org>
10767 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
10768 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10769 and add some more files.
10771 2011-05-20 Eli Zaretskii <eliz@gnu.org>
10773 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10774 report_file_error introduced by the change from 2011-05-07.
10776 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10778 * systime.h (Time): Define only if emacs is defined.
10779 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10780 where the include path doesn't have X11/X.h by default. See
10781 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10783 2011-05-20 Kenichi Handa <handa@m17n.org>
10785 * composite.c (find_automatic_composition): Fix previous change.
10787 2011-05-20 Glenn Morris <rgm@gnu.org>
10789 * lisp.mk: New file, split from Makefile.in.
10790 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10791 (shortlisp): Remove.
10792 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10794 2011-05-19 Glenn Morris <rgm@gnu.org>
10796 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10797 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10798 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10799 (lisp): Set the order to that of loadup.el.
10800 (shortlisp): Make it a copy of $lisp.
10801 (SOME_MACHINE_LISP): Remove.
10802 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10803 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10805 2011-05-18 Kenichi Handa <handa@m17n.org>
10807 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10808 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10809 (find_automatic_composition): Mostly rewrite for efficiency.
10811 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
10813 * makefile.w32-in: Update dependencies.
10815 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10817 * menu.c: Include limits.h (fixes the MS-Windows build broken by
10818 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
10820 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
10822 Fix some integer overflow issues, such as string length overflow.
10824 * insdel.c (count_size_as_multibyte): Check for string overflow.
10826 * character.c (lisp_string_width): Check for string overflow.
10827 Use EMACS_INT, not int, for string indexes and lengths; in
10828 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10829 the resulting string length overflows an EMACS_INT; instead,
10830 report a string overflow if no precision given. When checking for
10831 precision exhaustion, use a check that cannot possibly have
10832 integer overflow. (Bug#8675)
10833 * character.h (lisp_string_width): Adjust to new signature.
10835 * alloc.c (string_overflow): New function.
10836 (Fmake_string): Use it. This doesn't change behavior, but saves
10837 a few bytes and will simplify future changes.
10838 * character.c (string_escape_byte8): Likewise.
10839 * lisp.h (string_overflow): New decl.
10841 Fixups, following up to the user-interface timestamp change.
10842 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10843 for UI timestamps, instead of unsigned long.
10844 * msdos.c (mouse_get_pos): Likewise.
10845 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
10846 * w32gui.h (Time): Define by including "systime.h" rather than by
10847 declaring it ourselves. (Bug#8664)
10849 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10850 * image.c (clear_image_cache): Likewise.
10852 * term.c (term_mouse_position): Don't assume time_t wraparound.
10854 Be more systematic about user-interface timestamps.
10855 Before, the code sometimes used 'Time', sometimes 'unsigned long',
10856 and sometimes 'EMACS_UINT', to represent these timestamps.
10857 This change causes it to use 'Time' uniformly, as that's what X uses.
10858 This makes the code easier to follow, and makes it easier to catch
10859 integer overflow bugs such as Bug#8664.
10860 * frame.c (Fmouse_position, Fmouse_pixel_position):
10861 Use Time, not unsigned long, for user-interface timestamps.
10862 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10863 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10864 * keyboard.h (last_event_timestamp): Likewise.
10865 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10866 * menu.h (xmenu_show): Likewise.
10867 * term.c (term_mouse_position): Likewise.
10868 * termhooks.h (struct input_event.timestamp): Likewise.
10869 (struct terminal.mouse_position_hook): Likewise.
10870 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10871 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10872 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10873 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10874 what it was before.
10875 * menu.h, termhooks.h: Include "systime.h", for Time.
10877 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10878 Don't assume that the difference between two unsigned long values
10879 can fit into an integer. At this point, we know button_down_time
10880 <= event->timestamp, so the difference must be nonnegative, so
10881 there's no need to cast the result if double-click-time is
10882 nonnegative, as it should be; check that it's nonnegative, just in
10883 case. This bug is triggered when events are more than 2**31 ms
10884 apart (about 25 days). (Bug#8664)
10886 * xselect.c (last_event_timestamp): Remove duplicate decl.
10887 (x_own_selection): Remove needless cast to unsigned long.
10889 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10890 that always fit in int. Use a sentinel instead of a counter, to
10891 avoid a temp and to allay GCC's concerns about possible int overflow.
10892 * frame.h (struct frame): Use int for menu_bar_items_used
10893 instead of EMACS_INT, since it always fits in int.
10895 * menu.c (grow_menu_items): Check for int overflow.
10897 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10899 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10900 Before, the code was not consistent. These values cannot exceed
10901 2**31 - 1 so there's no need to make them unsigned.
10902 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10903 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10904 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10906 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10908 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10909 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10910 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10911 presumably because the widths might not match.
10913 * window.c (size_window): Avoid needless test at loop start.
10915 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10917 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10919 2011-05-12 Drew Adams <drew.adams@oracle.com>
10921 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10923 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10925 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10926 `width' to `bar_area_x' and `bar_area_width', respectively.
10927 (x_scroll_run): Take account of fringe background extension.
10929 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10930 Rename local vars `left' and `width' to `bar_area_x' and
10931 `bar_area_width', respectively.
10932 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10933 background extension.
10935 2011-05-10 Jim Meyering <meyering@redhat.com>
10937 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10939 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
10941 * image.c (Finit_image_library): Return t for built-in image types,
10942 like pbm and xbm. (Bug#8640)
10944 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10946 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10948 2011-05-07 Eli Zaretskii <eliz@gnu.org>
10950 * w32console.c (Fset_screen_color): Doc fix.
10951 (Fget_screen_color): New function.
10952 (syms_of_ntterm): Defsubr it.
10954 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10955 unlink the temporary file if Fcall_process didn't create it in the
10957 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10958 child process will be redirected to a file specified with `:file'.
10959 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10960 cue to call_process_cleanup not to close that handle.
10962 2011-05-07 Ben Key <bkey76@gmail.com>
10964 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10965 one of two shell specific rules, either bootstrap-temacs-CMD or
10966 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10967 to the previous implementation of the bootstrap-temacs rule.
10968 The bootstrap-temacs-CMD rule is similar to the previous
10969 implementation of the bootstrap-temacs rule except that it
10970 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10973 These changes, along with some changes to nt/configure.bat,
10974 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10975 earlier fix to add support for --cflags and --ldflags options
10976 that include quotes so that it works whether make uses cmd or
10979 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
10981 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10982 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10984 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10985 a string. Handle both cases.
10986 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10987 (Fdbus_register_method): Use Qinvalid_function.
10989 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10991 * makefile.w32-in: Update dependencies.
10992 (LISP_H): Add inttypes.h and stdin.h.
10993 (PROCESS_H): Add unistd.h.
10995 2011-05-06 Eli Zaretskii <eliz@gnu.org>
10997 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10998 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11000 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
11002 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11004 * term.c (vfatal): Remove stray call to va_end.
11005 It's not needed and the C Standard doesn't allow it here anyway.
11007 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11008 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11010 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11013 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11015 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11017 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11019 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11021 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11023 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11024 * charset.c (Fdefine_charset_internal): Don't initialize
11025 charset.code_space[15]. The value was garbage, on hosts with
11026 32-bit int (Bug#8600).
11028 * lread.c (read_integer): Be more consistent with string-to-number.
11029 Use string_to_number to do the actual conversion; this avoids
11030 rounding errors and fixes some other screwups. Without this fix,
11031 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11032 (digit_to_number): Move earlier, for benefit of read_integer.
11033 Return -1 if the digit is out of range for the base, -2 if it is
11034 not a digit in any supported base. (Bug#8602)
11036 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11038 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11039 to match comment at start of function. This also removes a
11040 GCC warning about overflow in a 32+64-bit port.
11042 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11044 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11045 Reported by Stefan Monnier in
11046 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
11047 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11048 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
11050 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11051 (EMACS_UINTPTR): Likewise, with uintptr_t.
11053 * lisp.h: Prefer 64-bit EMACS_INT if available.
11054 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11055 on 32-bit hosts that have 64-bit int, so that they can access
11057 However, temporarily disable this change unless the temporary
11058 symbol WIDE_EMACS_INT is defined.
11060 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11062 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11063 This removes an assumption that EMACS_INT and long are the same
11064 width as pointers. The assumption is true for Emacs porting targets
11065 now, but we want to make other targets possible.
11066 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11067 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11068 In the rest of the code, change types of integers that hold casted
11069 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11070 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11071 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11072 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11073 No need to cast type when ORing.
11074 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11075 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11076 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11077 assume EMACS_INT is the same width as char *.
11078 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11079 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11080 Remove no-longer-needed casts.
11081 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11082 (xg_tool_bar_help_callback, xg_make_tool_item):
11083 Use EMACS_INTPTR to hold an integer
11084 that will be cast to void *; this can avoid a GCC warning
11085 if EMACS_INT is not the same width as void *.
11086 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11087 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11088 (current_message_1, set_message_1):
11089 Use a local to convert to proper width without a cast.
11090 * xmenu.c (dialog_selection_callback): Likewise.
11092 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11093 Also, don't assume VALBITS / RAND_BITS is less than 5,
11094 and don't rely on undefined behavior when shifting a 1 left into
11096 * lisp.h (get_random): Change signature to match.
11098 * lread.c (hash_string): Use size_t, not int, for hash computation.
11099 Normally we prefer signed values; but hashing is special, because
11100 it's better to use unsigned division on hash table sizes so that
11101 the remainder is nonnegative. Also, size_t is the natural width
11102 for hashing into memory. The previous code used 'int', which doesn't
11103 retain enough info to hash well into very large tables.
11104 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11106 * dbusbind.c: Don't possibly lose pointer info when converting.
11107 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11108 Use XPNTR rather than XHASH, so that the high-order bits of
11109 the pointer aren't lost when converting through void *.
11111 * eval.c (Fautoload): Don't double-shift a pointer.
11113 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11115 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
11117 * gnutls.c (DEF_GNUTLS_FN):
11118 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11120 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11122 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11125 2011-05-05 Eli Zaretskii <eliz@gnu.org>
11127 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11128 New version that can reserve upto 2GB of heap space.
11130 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
11132 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11134 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11136 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11137 `gnutls_certificate_set_x509_key_file'.
11139 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
11141 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11142 Update dependencies.
11144 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11146 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11147 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11148 Remove unused parameter `fildes'.
11149 * process.c (read_process_output, send_process): Don't pass it.
11151 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11153 Fix previous change: the library cache is defined in w32.c.
11154 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11155 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11157 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11159 Implement dynamic loading of GnuTLS on Windows.
11161 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11162 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11163 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11166 * gnutls.c (Qgnutls_dll): Define.
11167 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11168 (gnutls_*): Declare function pointers.
11169 (init_gnutls_functions): New function to initialize function pointers.
11170 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11171 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11172 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11173 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11174 (emacs_gnutls_write, emacs_gnutls_read)
11175 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11176 (Fgnutls_available_p): New function.
11177 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11178 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11179 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11181 * image.c: Include w32.h.
11182 (Vimage_type_cache): Delete.
11183 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11184 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11185 (w32_delayed_load): Move to w32.c.
11187 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11189 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11190 (w32_delayed_load): Move from image.c. When loading a library, record
11191 its filename in the :loaded-from property of the library id.
11192 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11193 Initialize and staticpro them.
11194 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11196 * process.c: Include lisp.h before w32.h, not after.
11197 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11198 instead of gnutls_record_check_pending.
11200 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11202 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11204 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11205 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11208 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11210 * xterm.c (x_set_frame_alpha): Do not set property on anything
11211 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11213 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
11215 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11217 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
11219 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11220 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11221 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11222 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11223 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11224 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11225 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11226 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11227 (Qgnutls_bootprop_callbacks_verify): Make static.
11229 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11231 * callproc.c: Indentation fixup.
11233 * sysdep.c (wait_for_termination_1): Make static.
11234 (wait_for_termination, interruptible_wait_for_termination):
11235 Move after wait_for_termination_1.
11237 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11239 * sysdep.c (interruptible_wait_for_termination): New function
11240 which is like wait_for_termination, but allows keyboard
11243 * callproc.c (Fcall_process): Add (:file "file") as an option for
11245 (Fcall_process_region): Ditto.
11247 2011-04-30 Eli Zaretskii <eliz@gnu.org>
11249 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11250 rather than `XVECTOR (FOO)->size'.
11252 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11253 inttypes.h, as a gnulib replacement is used if it not available in
11256 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11258 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11259 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11260 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11262 * coding.c (coding_alloc_by_realloc): Error out if destination
11263 will grow beyond MOST_POSITIVE_FIXNUM.
11264 (decode_coding_emacs_mule): Abort if there isn't enough place in
11265 charbuf for the composition carryover bytes. Reserve an extra
11266 space for up to 2 characters produced in a loop.
11267 (decode_coding_iso_2022): Abort if there isn't enough place in
11268 charbuf for the composition carryover bytes.
11270 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11272 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11273 aborting when %lld or %lll format is passed.
11274 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11275 %llo or %llx format is passed. (Bug#8545)
11277 * window.c (window_scroll_line_based): Use a marker instead of
11278 simple variables to record original value of point. (Bug#7952)
11280 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11281 produced by %s or %c overflows available buffer space. (Bug#8545)
11283 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11285 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
11286 (SIZE_MAX): Move defn after all includes, as they might #define it.
11288 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11290 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11292 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11294 * keyboard.c (Qdelayed_warnings_hook): Define.
11295 (command_loop_1): Run `delayed-warnings-hook'
11296 if Vdelayed_warnings_list is non-nil.
11297 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11298 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11300 2011-04-28 Eli Zaretskii <eliz@gnu.org>
11302 * doprnt.c (doprnt): Don't return value smaller than the buffer
11303 size if the message was truncated. (Bug#8545).
11305 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11307 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11308 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11310 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11312 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11314 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
11316 * makefile.w32-in: Update dependencies.
11318 2011-04-27 Eli Zaretskii <eliz@gnu.org>
11320 Improve `doprnt' and its usage. (Bug#8545)
11321 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11322 `format_end'. Remove support for %l as a conversion specifier.
11323 Don't use xrealloc. Improve diagnostics when the %l size modifier
11324 is used. Update the commentary.
11326 * eval.c (verror): Simplify calculation of size_t.
11328 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11331 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11333 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11336 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11338 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11339 This makes this file independent of the recent pseudovector change.
11341 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
11343 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11345 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
11346 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
11347 Remove unused local.
11348 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
11350 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
11351 GCC 4.6.0 optimizes based on type-based alias analysis.
11352 For example, if b is of type struct buffer * and v of type struct
11353 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11354 != &v->size, and therefore "v->size = 1; b->size = 2; return
11355 v->size;" must therefore return 1. This assumption is incorrect
11356 for Emacs, since it type-puns struct Lisp_Vector * with many other
11357 types. To fix this problem, this patch adds a new type struct
11358 vectorlike_header that documents the constraints on layout of vectors
11359 and pseudovectors, and helps optimizing compilers not get fooled
11360 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11361 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
11362 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11364 (XSETPVECTYPE): Rewrite in terms of new macro.
11365 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11366 This is a bit clearer, and further avoids the possibility of
11367 undesirable aliasing.
11368 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
11369 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
11370 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11371 since Lisp_Subr is a special case (no "next" field).
11372 (ASIZE): Now uses header.size rather than size.
11373 All previous uses of XVECTOR (foo)->size replaced to use this macro,
11374 to avoid the hassle of writing XVECTOR (foo)->header.size.
11375 (struct vectorlike_header): New type.
11376 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11377 object, to help avoid aliasing.
11378 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11379 (SUBRP): Likewise, since Lisp_Subr is a special case.
11380 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11381 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11382 (struct Lisp_Hash_Table): Combine first two members into a single
11383 struct vectorlike_header member. All uses of "size" and "next" members
11384 changed to be "header.size" and "header.next".
11385 * buffer.h (struct buffer): Likewise.
11386 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11387 * frame.h (struct frame): Likewise.
11388 * process.h (struct Lisp_Process): Likewise.
11389 * termhooks.h (struct terminal): Likewise.
11390 * window.c (struct save_window_data, struct saved_window): Likewise.
11391 * window.h (struct window): Likewise.
11392 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11393 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11394 * buffer.c (init_buffer_once): Likewise.
11395 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11397 * process.c (Fformat_network_address): Use local var for size,
11400 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11402 Make the Lisp reader and string-to-float more consistent (Bug#8525)
11403 * data.c (atof): Remove decl; no longer used or needed.
11404 (digit_to_number): Move to lread.c.
11405 (Fstring_to_number): Use new string_to_number function, to be
11406 consistent with how the Lisp reader treats infinities and NaNs.
11407 Do not assume that floating-point numbers represent EMACS_INT
11408 without losing information; this is not true on most 64-bit hosts.
11409 Avoid double-rounding errors, by insisting on integers when
11410 parsing non-base-10 numbers, as the documentation specifies.
11411 * lisp.h (string_to_number): New decl, replacing ...
11412 (isfloat_string): Remove.
11413 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
11414 (read1): Do not accept +. and -. as integers; this
11415 appears to have been a coding error. Similarly, do not accept
11416 strings like +-1e0 as floating point numbers. Do not report
11417 overflow for integer overflows unless the base is not 10 which
11418 means we have no simple and reliable way to continue.
11419 Break out the floating-point parsing into a new
11420 function string_to_number, so that Fstring_to_number parses
11421 floating point numbers consistently with the Lisp reader.
11422 (digit_to_number): Move here from data.c. Make it static inline.
11423 (E_CHAR, EXP_INT): Remove, replacing with ...
11424 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11425 (string_to_number): New function, replacing isfloat_string.
11426 This function checks for valid syntax and produces the resulting
11427 Lisp float number too. Rework it so that string-to-number
11428 no longer mishandles examples like "1.0e+". Use strtoumax,
11429 so that overflow for non-base-10 numbers is reported only when
11430 there's no portable and simple way to convert to floating point.
11432 * textprop.c (set_text_properties_1): Rewrite for clarity,
11433 and to avoid GCC warning about integer overflow.
11435 * intervals.h (struct interval): Use EMACS_INT for members
11436 where EMACS_UINT might cause problems. See
11437 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11438 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11439 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11441 (offset_intervals): Tell GCC not to worry about length overflow
11442 when negating a negative length.
11444 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11445 (overrun_check_free): Likewise.
11447 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11448 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11451 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11452 (gnutls_make_error): Rename local to avoid shadowing.
11453 (gnutls_emacs_global_deinit): ifdef out; not used.
11454 (Fgnutls_boot): Use const for pointer to readonly storage.
11455 Comment out unused local. Fix pointer signedness problems.
11457 * lread.c (openp): Don't stuff size_t into an 'int'.
11458 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11459 about possible signed overflow.
11461 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11462 (GDK_KEY_g): Don't define if already defined.
11463 (xg_prepare_tooltip): Avoid pointer signedness problem.
11464 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11466 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11467 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11469 * xfns.c (Fx_window_property): Simplify a bit,
11470 to make a bit faster and to avoid GCC 4.6.0 warning.
11471 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11473 * fns.c (internal_equal): Don't assume size_t fits in int.
11475 * alloc.c (compact_small_strings): Tighten assertion a little.
11477 Replace pEd with more-general pI, and fix some printf arg casts.
11478 * lisp.h (pI): New macro, generalizing old pEd macro to other
11479 conversion specifiers. For example, use "...%"pI"d..." rather
11480 than "...%"pEd"...".
11481 (pEd): Remove. All uses replaced with similar uses of pI.
11482 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
11483 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11484 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11485 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11486 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11487 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11488 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11490 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11491 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11492 * print.c (safe_debug_print, print_object): Likewise.
11493 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11495 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11496 avoiding the 0 flag, which is not portable.
11497 * process.c (Fmake_network_process): Use pI to avoid cast.
11498 * region-cache.c (pp_cache): Likewise.
11499 * xdisp.c (decode_mode_spec): Likewise.
11500 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11501 behavior on 64-bit hosts with printf arg.
11502 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
11503 (x_stop_queuing_selection_requests): Likewise.
11504 (x_get_window_property): Don't truncate byte count to an 'int'
11507 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11508 here, since it parses constructs like leading '-' and spaces,
11509 which are not wanted; and it overflows with large numbers.
11510 Instead, simply match F[0-9]+, which is what is wanted anyway.
11512 * alloc.c: Remove unportable assumptions about struct layout.
11513 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11514 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11515 (allocate_vectorlike, make_pure_vector): Use the new macros,
11516 plus offsetof, to remove unportable assumptions about struct layout.
11517 These assumptions hold on all porting targets that I know of, but
11518 they are not guaranteed, they're easy to remove, and removing them
11519 makes further changes easier.
11521 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11522 This doesn't fix a bug but makes the code clearer.
11523 (string_overrun_cookie): Now const. Use initializers that
11524 don't formally overflow signed char, to avoid warnings.
11525 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11526 can cause Emacs to crash when string overrun checking is enabled.
11527 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11528 multiple of sizeof (EMACS_INT); it need not be, if
11529 alignof(EMACS_INT) < sizeof (EMACS_INT).
11530 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
11532 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
11534 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11536 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11538 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
11539 supposed to be handshaking. (Bug#8556)
11540 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11542 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
11544 * lisp.h (Qdebug): List symbol.
11545 * eval.c (Qdebug): Restore global linkage.
11546 * keyboard.c (debug-on-event): New variable.
11547 (handle_user_signal): Break into debugger when debug-on-event
11548 matches the current signal symbol.
11550 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11552 * alloc.c (check_sblock, check_string_bytes)
11553 (check_string_free_list): Convert to standard C.
11555 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11557 * w32.c (emacs_gnutls_push): Fix typo.
11559 2011-04-25 Eli Zaretskii <eliz@gnu.org>
11561 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11562 "cast to pointer from integer of different size".
11564 Improve doprnt and its use in verror. (Bug#8545)
11565 * doprnt.c (doprnt): Document the set of format control sequences
11566 supported by the function. Use SAFE_ALLOCA instead of always
11569 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11570 is one byte too soon. Don't use xrealloc; instead xfree and
11573 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11575 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11578 * gnutls.c: Renamed global_initialized to
11579 gnutls_global_initialized. Added internals for the
11580 :verify-hostname-error, :verify-error, and :verify-flags
11581 parameters of `gnutls-boot' and documented those parameters in the
11582 docstring. Start callback support.
11583 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11584 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11585 on error. Return error code.
11586 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11587 (emacs_gnutls_read): Likewise.
11588 (Fgnutls_boot): Return handshake error code.
11589 (emacs_gnutls_handle_error): New function.
11590 (wsaerror_to_errno): Likewise.
11592 * w32.h (emacs_gnutls_pull): Add prototype.
11593 (emacs_gnutls_push): Likewise.
11595 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11596 (emacs_gnutls_push): Likewise.
11598 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11600 * process.c (wait_reading_process_output): Check if GnuTLS
11601 buffered some data internally if no FDs are set for TLS
11604 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11605 (LIBS): Link to USER_LIBS.
11606 ($(BLD)/gnutls.$(0)): New target.
11608 2011-04-24 Eli Zaretskii <eliz@gnu.org>
11610 * xdisp.c (handle_single_display_spec): Rename the
11611 display_replaced_before_p argument into display_replaced_p, to
11612 make it consistent with the commentary. Fix typos in the
11615 * textprop.c (syms_of_textprop): Remove dead code.
11616 (copy_text_properties): Delete obsolete commentary about an
11617 interface that was deleted long ago. Fix typos in the description
11620 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11621 to changes in oldXMenu/XMenu.h from 2011-04-16.
11622 <menu_help_message, prev_menu_help_message>: Constify.
11623 (IT_menu_make_room): menu->help_text is now `const char **';
11626 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11627 to changes in oldXMenu/XMenu.h from 2011-04-16.
11628 (struct XMenu): Declare `help_text' `const char **'.
11630 * xfaces.c <Qunspecified>: Make extern again.
11632 * syntax.c: Include sys/types.h before including regex.h, as
11635 * doc.c (get_doc_string): Improve the format passed to `error'.
11637 * doprnt.c (doprnt): Improve commentary.
11639 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11641 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11644 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11645 changes in globals.h immediately force recompilation.
11646 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11647 $(CURDIR)/s/ms-w32.h.
11648 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
11650 * character.c (Fchar_direction): Function deleted.
11651 (syms_of_character): Don't defsubr it.
11652 <char-direction-table>: Deleted.
11654 2011-04-23 Eli Zaretskii <eliz@gnu.org>
11656 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11657 * doprnt.c: Include limits.h.
11658 (SIZE_MAX): New macro.
11659 (doprnt): Return a size_t value. 2nd arg is now size_t.
11660 Many local variables are now size_t instead of int or unsigned.
11661 Improve overflow protection. Support `l' modifier for integer
11662 conversions. Support %l conversion. Don't assume an EMACS_INT
11663 argument for integer conversions and for %c.
11665 * lisp.h (doprnt): Restore prototype.
11667 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11668 $(SRC)/character.h.
11670 * Makefile.in (base_obj): Add back doprnt.o.
11672 * deps.mk (doprnt.o): Add back prerequisites.
11673 (callint.o): Depend on character.h.
11675 * eval.c (internal_lisp_condition_case): Include the handler
11676 representation in the error message.
11677 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11678 when breaking from the loop.
11680 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11682 * callint.c (Fcall_interactively): When displaying error message
11683 about invalid control letter, pass the character's codepoint, not
11684 a pointer to its multibyte form. Improve display of the character
11685 in octal and display also its hex code.
11687 * character.c (char_string): Use %x to display the (unsigned)
11688 codepoint of an invalid character, to avoid displaying a bogus
11691 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11692 `error', not SYMBOL_NAME itself.
11694 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11695 character arguments to `error'.
11697 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11698 to `error' in error message about FINAL_CHAR argument. Make sure
11699 FINAL_CHAR is a character, and use %c when it is passed as
11700 argument to `error'.
11702 2011-04-23 Eli Zaretskii <eliz@gnu.org>
11704 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11706 * w32.c: Include <time.h>.
11707 (sys_localtime): New function.
11709 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
11711 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11713 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
11715 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
11717 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11718 zombies (Bug#8467).
11720 2011-04-19 Eli Zaretskii <eliz@gnu.org>
11722 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11723 gl_state.e_property when gl_state.object is Qt.
11725 * insdel.c (make_gap_larger): Remove limitation of buffer size
11728 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
11730 * xdisp.c (lookup_glyphless_char_display)
11731 (produce_glyphless_glyph): Handle cons cell entry in
11732 glyphless-char-display.
11733 (Vglyphless_char_display): Document it.
11735 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11736 glyphless-char-display.
11738 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
11740 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11742 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11744 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11745 definition for no-X builds.
11747 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
11749 Static checks with GCC 4.6.0 and non-default toolkits.
11751 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11753 * process.c (keyboard_bit_set): Define only if SIGIO.
11754 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11755 (send_process): Repair possible setjmp clobbering.
11757 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11759 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11761 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11763 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11764 Define only if needed.
11766 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11767 by pacifying GCC about it. Maybe it's time to retire it?
11768 * xfaces.c (USG, __TIMEVAL__): Likewise.
11770 * dispextern.h (struct redisplay_interface): Rename param
11771 to avoid shadowing.
11772 * termhooks.h (struct terminal): Likewise.
11773 * xterm.c (xembed_send_message): Likewise.
11775 * insdel.c (make_gap_smaller): Define only if
11776 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11778 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11781 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11782 so that we aren't warned about unused symbols.
11784 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11786 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
11788 * xfns.c (x_real_positions): Mark locals as initialized.
11790 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11792 * xterm.c: Fix problems found by static analysis with other toolkits.
11793 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
11794 (x_dispatch_event): Declare static if USE_GTK, and
11795 define if USE_GTK || USE_X_TOOLKIT.
11796 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
11797 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
11798 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11799 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
11801 * xmenu.c (menu_help_callback): Pointer type fixes.
11802 Use const pointers when pointing at readonly data. Avoid pointer
11803 signedness clashes.
11804 (FALSE): Remove unused macro.
11805 (update_frame_menubar): Remove unused decl.
11807 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11809 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11810 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11811 (single_menu_item): Rename local to avoid shadowing.
11813 * keyboard.c (make_lispy_event): Remove unused local var.
11815 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11816 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11818 * bitmaps: Change bitmaps from unsigned char back to the X11
11819 compatible char. Avoid the old compiler warnings about
11820 out-of-range initializers by using, for example, '\xab' rather
11823 * xgselect.c (xgselect_initialize): Check vs interface
11824 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11826 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11828 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11829 to read-only memory.
11831 * fns.c (vector): Remove; this old hack is no longer needed.
11833 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
11835 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
11837 * xrdb.c (x_load_resources): Omit unused local.
11839 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
11840 (x_window): Rename locals to avoid shadowing.
11841 (USG): Use the kludged USG macro, to pacify gcc.
11843 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
11844 (x_term_init): Remove local to avoid shadowing.
11846 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
11848 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11849 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11851 2011-04-16 Eli Zaretskii <eliz@gnu.org>
11853 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11855 Fix regex.c, syntax.c and friends for buffers > 2GB.
11856 * syntax.h (struct gl_state_s): Declare character position members
11859 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11861 * textprop.c (verify_interval_modification, interval_of):
11862 Declare arguments EMACS_INT.
11864 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11867 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11869 * indent.c (Fvertical_motion): Local variable it_start is now
11872 * regex.c (re_match, re_match_2, re_match_2_internal)
11873 (bcmp_translate, regcomp, regexec, print_double_string)
11874 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11875 (re_compile_pattern, re_exec): Declare arguments and local
11876 variables `size_t' and `ssize_t' and return values `regoff_t', as
11878 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11879 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11880 <compile_stack_type>: `size' and `avail' are now `size_t'.
11882 * regex.h <regoff_t>: Use ssize_t, not int.
11883 (re_search, re_search_2, re_match, re_match_2): Arguments that
11884 specify buffer/string position and length are now ssize_t and
11885 size_t. Return type is regoff_t.
11887 2011-04-16 Ben Key <bkey76@gmail.com>
11889 * nsfont.m: Fixed bugs in ns_get_family and
11890 ns_descriptor_to_entity that were caused by using free to
11891 deallocate memory blocks that were allocated by xmalloc (via
11892 xstrdup). This caused Emacs to crash when compiled with
11893 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11894 --enable-checking=xmallocoverrun). xfree is now used to
11895 deallocate these memory blocks.
11897 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
11899 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11901 emacs_write: Accept and return EMACS_INT for sizes.
11902 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11904 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11905 Accept and return EMACS_INT.
11906 (emacs_gnutls_write): Return the number of bytes written on
11908 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
11909 (emacs_read, emacs_write): Remove check for negative size, as the
11910 Emacs source code has been audited now.
11911 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11912 (emacs_read, emacs_write): Use it.
11913 * process.c (send_process): Adjust to the new signatures of
11914 emacs_write and emacs_gnutls_write. Do not attempt to store
11915 a byte offset into an 'int'; it might overflow.
11916 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
11918 * sound.c: Don't assume sizes fit in 'int'.
11919 (struct sound_device.period_size, alsa_period_size):
11920 Return EMACS_INT, not int.
11921 (struct sound_device.write, vox_write, alsa_write):
11922 Accept EMACS_INT, not int.
11923 (wav_play, au_play): Use EMACS_INT to store sizes and to
11924 record read return values.
11926 2011-04-15 Ben Key <bkey76@gmail.com>
11928 * keyboard.c (Qundefined): Don't declare static since it is used
11930 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11931 static since they are used in nsfont.m.
11933 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11935 * process.c (Qprocessp): Don't declare static.
11936 * lisp.h (Qprocessp): Declare again.
11938 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
11940 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11942 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11944 Improve C-level modularity by making more things 'static'.
11946 Don't publish debugger-only interfaces to other modules.
11947 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11948 (verify_bytepos, count_markers): Move decls to the only modules
11950 * region-cache.h (pp_cache): Likewise.
11951 * window.h (check_all_windows): Likewise.
11952 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11954 * sysdep.c (croak): Now static, if
11955 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11956 * syssignal.h (croak): Declare only if not static.
11958 * alloc.c (refill_memory_reserve): Now static if
11959 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11960 * lisp.h (refill_memory_reserve): Declare only if not static.
11962 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11963 Define only if USE_LUCID.
11965 * xrdb.c (x_customization_string, x_rm_string): Now static.
11967 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11968 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11970 * xdisp.c (draw_row_with_mouse_face): Now static.
11971 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11973 * window.h (check_all_windows): Mark externally visible.
11975 * window.c (window_deletion_count): Now static.
11977 * undo.c: Make symbols static if they're not exported.
11978 (last_undo_buffer, last_boundary_position, pending_boundary):
11981 * textprop.c (interval_insert_behind_hooks): Now static.
11982 (interval_insert_in_front_hooks): Likewise.
11984 * term.c: Make symbols static if they're not exported.
11985 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11986 (max_frame_lines, tty_set_terminal_modes):
11987 (tty_reset_terminal_modes, tty_turn_off_highlight):
11988 (get_tty_terminal): Now static.
11989 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11990 * termhooks.h (term_mouse_moveto): Do not declare if
11991 HAVE_WINDOW_SYSTEM.
11992 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11993 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11995 * sysdep.c: Make symbols static if they're not exported.
11996 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11998 (sigprocmask_set, full_mask): Remove; unused.
11999 (wait_debugging): Mark as visible.
12000 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12001 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12003 * syntax.c (syntax_temp): Define only if !__GNUC__.
12005 * sound.c (current_sound_device, current_sound): Now static.
12007 * search.c (searchbufs, searchbuf_head): Now static.
12009 * scroll.c (scroll_cost): Remove; unused.
12010 * dispextern.h (scroll_cost): Remove decl.
12012 * region-cache.h (pp_cache): Mark as externally visible.
12014 * process.c: Make symbols static if they're not exported.
12015 (process_tick, update_tick, create_process, chan_process):
12016 (Vprocess_alist, proc_buffered_char, datagram_access):
12017 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12018 (deactivate_process): Mark defn as static, as well as decl.
12019 * lisp.h (create_process): Remove decl.
12020 * process.h (chan_process, Vprocess_alist): Remove decls.
12022 * print.c: Make symbols static if they're not exported.
12023 (print_depth, new_backquote_output, being_printed, print_buffer):
12024 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12025 (print_interval, print_number_index, initial_stderr_stream):
12027 * lisp.h (Fprinc): Remove decl.
12028 (debug_output_compilation_hack): Mark as externally visible.
12030 * sysdep.c (croak): Move decl from here to syssignal.h.
12031 * syssignal.h (croak): Put it here, so the API can be checked when
12032 'croak' is called from dissociate_if_controlling_tty.
12034 * minibuf.c: Make symbols static if they're not exported.
12035 (minibuf_save_list, choose_minibuf_frame): Now static.
12036 * lisp.h (choose_minibuf_frame): Remove decl.
12038 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12040 * lread.c: Make symbols static if they're not exported.
12041 (read_objects, initial_obarray, oblookup_last_bucket_number):
12043 (make_symbol): Remove; unused.
12044 * lisp.h (initial_obarray, make_symbol): Remove decls.
12046 * keyboard.c: Make symbols static if they're not exported.
12047 (single_kboard, recent_keys_index, total_keys, recent_keys):
12048 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12049 (this_single_command_key_start, echoing, last_auto_save):
12050 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12051 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12052 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12053 (Vlispy_mouse_stem, double_click_count):
12055 (force_auto_save_soon): Define only if SIGDANGER.
12056 (ignore_mouse_drag_p): Now static if
12057 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12058 (print_help): Remove; unused.
12059 (stop_character, last_timer_event): Mark as externally visible.
12060 * keyboard.h (ignore_mouse_drag_p): Declare only if
12061 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12062 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12063 * lisp.h (echoing): Remove decl.
12064 (force_auto_save_soon): Declare only if SIGDANGER.
12065 * xdisp.c (redisplay_window): Simplify code, to make it more
12066 obvious that ignore_mouse_drag_p is not accessed if !defined
12067 USE_GTK && !defined HAVE_NS.
12069 * intervals.c: Make symbols static if they're not exported.
12070 (merge_properties_sticky, merge_interval_right, delete_interval):
12072 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12074 * insdel.c: Make symbols static if they're not exported.
12075 However, leave prepare_to_modify_buffer alone. It's never
12076 called from outside this function, but that appears to be a bug.
12077 (combine_after_change_list, combine_after_change_buffer):
12078 (adjust_after_replace, signal_before_change): Now static.
12079 (adjust_after_replace_noundo): Remove; unused.
12080 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
12081 (signal_before_change): Remove decls.
12083 * indent.c (val_compute_motion, val_vmotion): Now static.
12085 * image.c: Make symbols static if they're not exported.
12086 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12088 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12089 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12091 * fringe.c (standard_bitmaps): Now static.
12092 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12094 * frame.c: Make symbols static if they're not exported.
12095 (x_report_frame_params, make_terminal_frame): Now static.
12096 (get_frame_param): Now static, unless HAVE_NS.
12097 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12098 (x_get_resource_string): Remove; not used.
12099 * frame.h (make_terminal_frame, x_report_frame_params):
12100 (x_get_resource_string); Remove decls.
12101 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12102 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12104 * font.c, fontset.c: Make symbols static if they're not exported.
12105 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12106 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12107 * font.c (font_close_object): Now static.
12108 * font.h (font_close_object): Remove.
12109 * fontset.c (FONTSET_OBJLIST): Remove.
12110 (free_realized_fontset) #if-0 the body, which does nothing.
12111 (face_suitable_for_char_p): #if-0, as it's never called.
12112 * fontset.h (face_suitable_for_char_p): Remove decl.
12113 * xfaces.c (face_at_string_position):
12114 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
12115 since 0 is always ASCII.
12117 * fns.c (weak_hash_tables): Now static.
12119 * fileio.c: Make symbols static if they're not exported.
12120 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12121 (Vwrite_region_annotation_buffers): Now static.
12123 * eval.c: Make symbols static if they're not exported.
12124 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12125 * lisp.h (backtrace_list): Remove decl.
12127 * emacs.c: Make symbols static if they're not exported.
12128 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12129 (fatal_error_code, fatal_error_signal_hook, standard_args):
12131 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12132 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12133 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12134 * lisp.h (fatal_error_signal_hook): Remove decl.
12135 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12137 * editfns.c: Move a (normally-unused) function to its only use.
12138 * editfns.c, lisp.h (get_operating_system_release): Remove.
12139 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12140 worth the hassle of breaking this out.
12142 * xterm.c: Make symbols static if they're not exported.
12143 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12144 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12145 (x_destroy_window, x_delete_display):
12147 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12148 (x_mouse_leave): Remove; unused.
12149 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12150 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12151 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12153 (x_mouse_leave): Declare only if WINDOWSNT.
12154 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12155 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12158 * ftxfont.c: Make symbols static if they're not exported.
12159 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12161 * font.h (ftxfont_driver): Likewise.
12163 * xfns.c: Make symbols static if they're not exported.
12164 (x_last_font_name, x_display_info_for_name):
12165 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12166 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12167 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12168 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12169 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12170 (last_show_tip_args): Now static.
12171 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12172 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12173 (x_screen_planes): Remove; unused.
12174 * dispextern.h (x_screen_planes): Remove decl.
12176 * dispnew.c: Make symbols static if they're not exported.
12177 * dispextern.h (redraw_garbaged_frames, scrolling):
12178 (increment_row_positions): Remove.
12179 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12180 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12182 (redraw_garbaged_frames): Remove; unused.
12184 * xfaces.c: Make symbols static if they're not exported.
12185 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12187 * xterm.h (defined_color): Remove decls.
12188 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12189 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12190 (menu_face_changed_default, defined_color, free_realized_face):
12191 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12192 (ascii_face_of_lisp_face): Remove; unused.
12194 * xdisp.c: Make symbols static if they're not exported.
12195 * dispextern.h (scratch_glyph_row, window_box_edges):
12196 (glyph_to_pixel_coords, set_cursor_from_row):
12197 (get_next_display_element, set_iterator_to_next):
12198 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12199 (show_mouse_face): Remove decls
12200 * frame.h (message_buf_print): Likewise.
12201 * lisp.h (pop_message, set_message, check_point_in_composition):
12203 * xterm.h (set_vertical_scroll_bar): Likewise.
12204 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12205 (message_buf_print, scratch_glyph_row, displayed_buffer):
12206 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12207 (get_next_display_element, show_mouse_face, window_box_edges):
12208 (frame_to_window_pixel_xy, check_point_in_composition):
12209 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12210 (glyph_to_pixel_coords): Remove; unused.
12212 * dired.c (file_name_completion): Now static.
12214 * dbusbind.c (xd_in_read_queued_messages): Now static.
12216 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12217 * data.c (circular_list_error): Remove.
12219 * commands.h (last_point_position, last_point_position_buffer):
12220 (last_point_position_window): Remove decls.
12221 * keyboard.c: Make these variables static.
12223 * coding.h (coding, code_convert_region, encode_coding_gap):
12225 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12226 (iso_code_class, detect_coding, code_convert_region): Now static.
12227 (encode_coding_gap): Remove; unused.
12229 * chartab.c (chartab_chars, chartab_bits): Now static.
12231 * charset.h (charset_iso_8859_1): Remove decl.
12232 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12235 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12236 * ccl.c (Vccl_program_table): Now static.
12237 (check_ccl_update): Remove; unused.
12239 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12240 * category.h: ... from here.
12241 * category.c (check_category_table, set_category_set): Now static.
12243 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12244 * lisp.h: Remove these decls.
12246 * buffer.c (buffer_count): Remove unused var.
12248 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12249 so that it's not optimized away.
12250 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12251 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12252 exported only to the debugger.
12254 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
12255 * atimer.h (run_all_atimers): Remove; not exported.
12257 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12258 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12259 was inaccessible from Lisp.
12260 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12261 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12263 alloc.c: Import and export fewer symbols, and remove unused items.
12264 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12266 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12267 it's not optimized away by whole-program optimization.
12268 (message_enable_multibyte, free_misc): Remove.
12269 (catchlist, handlerlist, mark_backtrace):
12270 Declare only if BYTE_MARK_STACK.
12271 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12272 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12273 (message_enable_multibyte): Remove decl.
12274 (free_misc, interval_free_list, float_block, float_block_index):
12275 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12276 (cons_free_list, last_marked_index):
12278 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12279 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12280 (mark_backtrace): Define only if BYTE_MARK_STACK.
12281 * xdisp.c (message_enable_multibyte): Now static.
12283 Declare Lisp_Object Q* variables to be 'static' if not exported.
12284 This makes it easier for human readers (and static analyzers)
12285 to see whether these variables are used from other modules.
12286 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12287 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12288 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12289 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12290 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12291 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12292 * xmenu.c, xselect.c:
12293 Declare Q* vars static if they are not used in other modules.
12294 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12295 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12296 Remove decls of unexported vars.
12297 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12299 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12301 Make Emacs functions such as Fatom 'static' by default.
12302 This makes it easier for human readers (and static analyzers)
12303 to see whether these functions can be called from other modules.
12304 DEFUN now defines a static function. To make the function external
12305 so that it can be used in other C modules, use the new macro DEFUE.
12306 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12307 (Finit_image_library):
12308 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12309 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12310 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12311 Remove decls, since these functions are now static.
12312 (Funintern, Fget_internal_run_time): New decls, since these functions
12313 were already external.
12315 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12316 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12317 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12318 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12319 * keyboard.c, keymap.c, lread.c:
12320 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12321 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12322 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12323 Mark functions with DEFUE instead of DEFUN,
12324 if they are used in other modules.
12325 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12326 decls for now-static functions.
12327 * buffer.h (Fdelete_overlay): Remove decl.
12328 * callproc.c (Fgetenv_internal): Mark as internal.
12329 * composite.c (Fremove_list_of_text_properties): Remove decl.
12330 (Fcomposition_get_gstring): New forward static decl.
12331 * composite.h (Fcomposite_get_gstring): Remove decl.
12332 * dired.c (Ffile_attributes): New forward static decl.
12333 * doc.c (Fdocumntation_property): New forward static decl.
12334 * eval.c (Ffetch_bytecode): New forward static decl.
12335 (Funintern): Remove extern decl; now in .h file where it belongs.
12336 * fileio.c (Fmake_symbolic_link): New forward static decl.
12337 * image.c (Finit_image_library): New forward static decl.
12338 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12339 * intervals.h (Fprevious_property_change):
12340 (Fremove_list_of_text_properties): Remove decls.
12341 * keyboard.c (Fthis_command_keys): Remove decl.
12342 (Fcommand_execute): New forward static decl.
12343 * keymap.c (Flookup_key): New forward static decl.
12344 (Fcopy_keymap): Now static.
12345 * keymap.h (Flookup_key): Remove decl.
12346 * process.c (Fget_process): New forward static decl.
12347 (Fprocess_datagram_address): Mark as internal.
12348 * syntax.c (Fsyntax_table_p): New forward static decl.
12349 (skip_chars): Remove duplicate decl.
12350 * textprop.c (Fprevious_property_change): New forward static decl.
12351 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12353 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12354 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12356 * editfns.c (Fformat): Remove unreachable code.
12358 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12360 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12363 2011-04-13 Eli Zaretskii <eliz@gnu.org>
12365 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12366 when at ZV. (Bug#8487)
12368 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12370 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12372 * keyboard.c (parse_tool_bar_item): Likewise.
12373 * sound.c (sound_cleanup, alsa_close): Likewise.
12374 * termcap.c (tgetent): Likewise.
12375 * xfns.c (x_default_font_parameter): Likewise.
12376 * xsettings.c (read_and_apply_settings): Likewise.
12378 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12379 (overrun_check_free): Protoize.
12381 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12383 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12384 since callers should never pass a negative size.
12385 Change the signature to match that of plain 'read' and 'write'; see
12386 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12387 * lisp.h: Update prototypes of emacs_write and emacs_read.
12389 2011-04-11 Eli Zaretskii <eliz@gnu.org>
12391 * xdisp.c (redisplay_window): Don't try to determine the character
12392 position of the scroll margin if the window start point w->startp
12393 is outside the buffer's accessible region. (Bug#8468)
12395 2011-04-10 Eli Zaretskii <eliz@gnu.org>
12397 Fix write-region and its subroutines for buffers > 2GB.
12398 * fileio.c (a_write, e_write): Modify declaration of arguments and
12399 local variables to support buffers larger than 2GB.
12400 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12402 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12403 argument, local variables, and return value.
12405 * lisp.h: Update prototypes of emacs_write and emacs_read.
12407 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12409 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
12411 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12413 Fix more problems found by GCC 4.6.0's static checks.
12415 * xdisp.c (vmessage): Use a better test for character truncation.
12417 * charset.c (load_charset_map): <, not <=, for optimization,
12418 and to avoid potential problems with integer overflow.
12419 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
12420 * casetab.c (set_identity, shuffle): Likewise.
12421 * editfns.c (Fformat): Likewise.
12422 * syntax.c (skip_chars): Likewise.
12424 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12425 This also lets GCC 4.6.0 generate slightly better loop code.
12427 * callint.c (Fcall_interactively): <, not <=, for optimization.
12428 (Fcall_interactively): Count the number of arguments produced,
12429 not the number of arguments given. This is simpler and lets GCC
12430 4.6.0 generate slightly better code.
12432 * ftfont.c: Distingish more carefully between FcChar8 and char.
12433 The previous code passed unsigned char * to a functions like
12434 strlen and xstrcasecmp that expect char *, which does not
12435 conform to the C standard.
12436 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12437 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12438 char * when the C standard requires it.
12440 * keyboard.c (read_char): Remove unused var.
12442 * eval.c: Port to Windows vsnprintf (Bug#8435).
12443 Include <limits.h>.
12444 (SIZE_MAX): Define if the headers do not.
12445 (verror): Do not give up if vsnprintf returns a negative count.
12446 Instead, grow the buffer. This ports to Windows vsnprintf, which
12447 does not conform to C99. Problem reported by Eli Zaretskii.
12448 Also, simplify the allocation scheme, by avoiding the need for
12449 calling realloc, and removing the ALLOCATED variable.
12451 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12453 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12454 But keep the doprint source code for now, as we might revamp it
12455 and use it again (Bug#8435).
12456 * lisp.h (doprnt): Remove.
12457 * Makefile.in (base_obj): Remove doprnt.o.
12458 * deps.mk (doprnt.o): Remove.
12460 error: Print 32- and 64-bit integers portably (Bug#8435).
12461 Without this change, on typical 64-bit hosts error ("...%d...", N)
12462 was used to print both 32- and 64-bit integers N, which relied on
12463 undefined behavior.
12464 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
12465 * lisp.h (error, verror): Mark as printf-like functions.
12466 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12467 Report overflow in size calculations when allocating printf buffer.
12468 Do not truncate output string at its first null byte.
12469 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12470 Truncate the output at a character boundary, since vsnprintf does not
12472 * charset.c (check_iso_charset_parameter): Convert internal
12473 character to string before calling 'error', since %c now has the
12475 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12476 overflow when computing char to be passed to 'error'. Do not
12477 pass Lisp_Object to 'error'; pass the integer instead.
12478 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12479 formatted with plain %d.
12481 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12483 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12485 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12487 * xterm.c (x_catch_errors): Remove duplicate declaration.
12489 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12491 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12493 2011-04-10 Jim Meyering <meyering@redhat.com>
12495 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12496 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12497 return ssize_t not "int", and use size_t as the buffer length.
12498 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12499 * gnutls.h: Update declarations.
12500 * process.c (read_process_output): Use ssize_t, to match.
12501 (send_process): Likewise.
12503 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
12505 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12507 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
12509 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12510 Use unsigned char, to match FcChar8 type definition.
12512 * xterm.c (handle_one_xevent):
12513 * xmenu.c (create_and_show_popup_menu):
12514 * xselect.c (x_decline_selection_request)
12515 (x_reply_selection_request): Avoid type-punned deref of X events.
12517 2011-04-09 Eli Zaretskii <eliz@gnu.org>
12519 Fix some uses of `int' instead of EMACS_INT.
12520 * search.c (string_match_1, fast_string_match)
12521 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12522 (scan_buffer, find_next_newline_no_quit)
12523 (find_before_next_newline, search_command, Freplace_match)
12524 (Fmatch_data): Make some `int' variables be EMACS_INT.
12526 * xdisp.c (display_count_lines): 3rd argument and return value now
12527 EMACS_INT. All callers changed.
12528 (pint2hrstr): Last argument is now EMACS_INT.
12530 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12531 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12532 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12533 (decode_coding_utf_16, decode_coding_emacs_mule)
12534 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12535 (decode_coding_ccl, decode_coding_charset)
12536 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12537 (decode_coding_iso_2022, decode_coding_emacs_mule)
12538 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12539 <char_offset, last_offset>: Declare EMACS_INT.
12540 (encode_coding_utf_8, encode_coding_utf_16)
12541 (encode_coding_emacs_mule, encode_invocation_designation)
12542 (encode_designation_at_bol, encode_coding_iso_2022)
12543 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12544 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12546 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12547 (encode_invocation_designation): Last argument P_NCHARS is now
12549 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12550 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12552 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12555 * ccl.c (Fccl_execute_on_string): Declare some variables
12558 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
12560 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12562 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12564 * process.c (Fformat_network_address): Doc fix.
12566 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12568 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
12570 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
12572 * keyboard.c (read_char): Call Lisp function help-form-show,
12573 instead of using internal_with_output_to_temp_buffer.
12574 (Qhelp_form_show): New var.
12575 (syms_of_keyboard): Use DEFSYM macro.
12577 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12579 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12581 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
12583 * process.c (Flist_processes): Remove to Lisp.
12584 (list_processes_1): Delete.
12586 2011-04-06 Eli Zaretskii <eliz@gnu.org>
12588 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12590 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12592 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
12594 Fix more problems found by GCC 4.6.0's static checks.
12596 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12598 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12600 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
12602 * xdisp.c (vmessage): Mark as a printf-like function.
12604 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12606 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12608 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12609 printf-like functions.
12610 (tiff_load): Add casts to remove these marks before passing them
12611 to system-supplied API.
12613 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12615 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12616 This avoids several warnings with gcc -Wstrict-overflow.
12617 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12618 directly, rather than having caller test rule sign. This avoids
12619 some unnecessary tests.
12620 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12621 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12622 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
12624 * xfont.c (xfont_text_extents): Remove var that was set but not used.
12625 (xfont_open): Avoid unnecessary tests.
12627 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12629 * composite.h, composite.c (composition_gstring_put_cache):
12630 Use EMACS_INT, not int, for length.
12632 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12633 breaking out part of COMPOSITION_DECODE_RULE.
12634 (COMPOSITION_DECODE_RULE): Use it.
12635 * composite.c (get_composition_id): Remove unused local vars,
12636 by using the new macro.
12638 * textprop.c (set_text_properties_1): Change while to do-while,
12639 since the condition is always true at first.
12641 * intervals.c (graft_intervals_into_buffer): Mark var as used.
12642 (interval_deletion_adjustment): Return unsigned value.
12645 * process.c (list_processes_1, create_pty, read_process_output):
12646 (exec_sentinel): Remove vars that were set but not used.
12647 (create_pty): Remove unnecessary "volatile"s.
12648 (Fnetwork_interface_info): Avoid possibility of int overflow.
12649 (read_process_output): Do adaptive read buffering even if carryover.
12650 (read_process_output): Simplify nbytes computation if buffered.
12652 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12654 * syntax.c (scan_words): Remove var that was set but not used.
12655 (update_syntax_table): Use unsigned instead of int.
12657 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
12658 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
12659 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
12661 * print.c (print_error_message): Avoid int overflow.
12663 * font.c (font_list_entities): Redo for clarity,
12664 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12666 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
12667 (font_score): Avoid potential overflow in diff calculation.
12669 * fns.c (substring_both): Remove var that is set but not used.
12670 (sxhash): Redo loop for clarity and to avoid wraparound warning.
12672 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12674 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12675 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12676 can always succeed if overflow has undefined behavior.
12678 * search.c (boyer_moore, wordify): Remove vars set but not used.
12679 (wordify): Omit three unnecessary tests.
12681 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12682 All callers changed. This avoids the need for an unused var.
12684 * casefiddle.c (casify_region): Remove var that is set but not used.
12686 * dired.c (file_name_completion): Remove var that is set but not used.
12688 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12690 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
12691 (Finsert_file_contents): Remove unnecessary code checking fd.
12693 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12694 Check for integer overflow on size calculations.
12696 * buffer.c (Fprevious_overlay_change): Remove var that is set
12699 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12700 Remove vars that are set but not used.
12701 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
12702 (timer_check_2): Mark vars as initialized.
12704 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12706 * image.c (lookup_image): Remove var that is set but not used.
12707 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
12709 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12710 that are set but not used.
12712 * xfns.c (make_invisible_cursor): Don't return garbage
12713 if XCreateBitmapFromData fails (Bug#8410).
12715 * xselect.c (x_get_local_selection, x_handle_property_notify):
12716 Remove vars that are set but not used.
12718 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
12719 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
12721 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12722 Remove var that is set but not used.
12723 (scroll_bar_windows_size): Now size_t, not int.
12724 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12725 Check for overflow.
12727 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12728 (map_tty_color) [!defined MSDOS]: Likewise.
12730 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12732 * coding.c: Remove vars that are set but not used.
12733 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12734 All callers changed.
12735 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12736 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12737 (decode_coding_charset): Remove vars that are set but not used.
12739 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12740 that is set but not used.
12742 * print.c (print_object): Remove var that is set but not used.
12744 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
12745 The gnulib version avoids calling malloc in the usual case,
12746 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12747 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12748 * filelock.c (current_lock_owner): Likewise.
12749 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12750 * sysdep.c: Include allocator.h, careadlinkat.h.
12751 (emacs_no_realloc_allocator): New static constant.
12752 (emacs_readlink): New function.
12753 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12754 ../lib/careadlinkat.h.
12756 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12758 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12759 first non-nil return value).
12761 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12763 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12764 if not defined (Bug#8403).
12766 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
12768 * xdisp.c (display_count_lines): Remove parameter `start',
12769 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12770 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12771 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12772 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12773 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12774 and thereabouts. All callers changed.
12775 (get_per_char_metric): Remove parameter `f', unused since
12776 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12778 2011-04-02 Jim Meyering <meyering@redhat.com>
12780 do not dereference NULL upon failed strdup
12781 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12782 (ns_get_family): Likewise.
12784 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
12786 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12788 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12790 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12793 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12795 Add lexical binding.
12797 * window.c (Ftemp_output_buffer_show): New fun.
12798 (Fsave_window_excursion):
12799 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12801 * lread.c (lisp_file_lexically_bound_p): New function.
12802 (Fload): Bind Qlexical_binding.
12803 (readevalloop): Remove `evalfun' arg.
12804 Bind Qinternal_interpreter_environment.
12805 (Feval_buffer): Bind Qlexical_binding.
12806 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12808 (syms_of_lread): Declare `lexical-binding'.
12810 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12812 * keyboard.c (eval_dyn): New fun.
12813 (menu_item_eval_property): Use it.
12815 * image.c (parse_image_spec): Use Ffunctionp.
12817 * fns.c (concat, mapcar1): Accept byte-code-functions.
12819 * eval.c (Fsetq): Handle lexical vars.
12820 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12821 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12822 (FletX, Flet): Obey lexical binding.
12823 (Fcommandp): Handle closures.
12824 (Feval): New `lexical' arg.
12825 (eval_sub): New function extracted from Feval. Use it almost
12826 everywhere where Feval was used. Look up vars in lexical env.
12828 (Ffunctionp): Move from subr.el.
12829 (Ffuncall): Handle closures.
12830 (apply_lambda): Remove `eval_flags'.
12831 (funcall_lambda): Handle closures and new byte-code-functions.
12832 (Fspecial_variable_p): New function.
12833 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12834 but without exporting it to Lisp.
12836 * doc.c (Fdocumentation, store_function_docstring):
12837 * data.c (Finteractive_form): Handle closures.
12839 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12842 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12844 (exec_byte_code): New function extracted from Fbyte_code to handle new
12845 calling convention for byte-code-functions. Add new byte-codes.
12847 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
12849 * alloc.c (Fmake_symbol): Init new `declared_special' field.
12851 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12853 * xdisp.c (redisplay_internal): Fix prototype.
12855 2011-03-31 Eli Zaretskii <eliz@gnu.org>
12857 * xdisp.c (SCROLL_LIMIT): New macro.
12858 (try_scrolling): Use it when setting scroll_limit.
12859 Limit scrolling to 100 screen lines.
12860 (redisplay_window): Even when falling back on "recentering",
12861 position point in the window according to scroll-conservatively,
12862 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12864 (try_scrolling): When point is above the window, allow searching
12865 as far as scroll_max, or one screenful, to compute vertical
12866 distance from PT to the scroll margin position. This prevents
12867 try_scrolling from unnecessarily failing when
12868 scroll-conservatively is set to a value slightly larger than the
12869 window height. Clean up the case of PT below the margin at bottom
12870 of window: scroll_max can no longer be INT_MAX. When aggressive
12871 scrolling is in use, don't let point enter the opposite scroll
12872 margin as result of the scroll.
12873 (syms_of_xdisp) <scroll-conservatively>: Document the
12874 threshold of 100 lines for never-recentering scrolling.
12876 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12878 * dispextern.h (move_it_by_lines):
12879 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12880 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12881 (message_log_check_duplicate): Remove parameters `prev_bol' and
12882 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12883 (redisplay_internal): Remove parameter `preserve_echo_area',
12884 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12886 * indent.c (Fvertical_motion):
12887 * window.c (window_scroll_pixel_based, Frecenter):
12888 Don't pass `need_y_p' to `move_it_by_lines'.
12890 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12892 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12893 steal a few bits to be more compact.
12894 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12895 Remove unneeded casts.
12897 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12899 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12901 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12902 binding" message (bug#7967).
12904 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12906 Fix more problems found by GCC 4.6.0's static checks.
12908 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12909 Remove unused local var.
12911 * editfns.c (Fmessage_box): Remove unused local var.
12913 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12914 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12915 Omit unused local vars.
12916 * window.c (shrink_windows): Omit unused local var.
12917 * menu.c (digest_single_submenu): Omit unused local var.
12918 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12919 Omit unused local var.
12921 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12922 Don't assume string length fits in int.
12923 (keyremap_step, read_key_sequence): Use size_t for sizes.
12924 (read_key_sequence): Don't check last_real_key_start redundantly.
12926 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12927 instead of alloca (Bug#8344).
12929 * eval.c (Fbacktrace): Don't assume nargs fits in int.
12930 (Fbacktrace_frame): Don't assume nframes fits in int.
12932 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12934 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12937 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12939 * cm.c (calccost): Turn while-do into do-while, for clarity.
12941 * keyboard.c (syms_of_keyboard): Use the same style as later
12942 in this function when indexing through an array. This also
12943 works around GCC bug 48267.
12945 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12947 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12949 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12950 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12952 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12953 This avoids undefined behavior on integer overflow, and is a bit
12954 more convenient anyway since it is compared to a size_t variable.
12956 Variadic C functions now count arguments with size_t, not int.
12957 This avoids an unnecessary limitation on 64-bit machines, which
12958 caused (substring ...) to crash on large vectors (Bug#8344).
12959 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12960 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
12961 All variadic functions and their callers changed accordingly.
12962 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12963 * data.c (arith_driver, float_arith_driver): Likewise.
12964 * editfns.c (general_insert_function): Likewise.
12965 * eval.c (struct backtrace.nargs, interactive_p)
12966 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12967 (funcall_lambda, mark_backtrace): Likewise.
12968 * fns.c (concat): Likewise.
12969 * frame.c (x_set_frame_parameters): Likewise.
12970 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12971 0 if not found, not -1. All callers changed.
12973 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12974 (stack_copy_size): Now size_t, not int.
12975 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12977 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12979 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12980 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12981 All callers changed.
12983 * lisp.h (multibyte_char_to_unibyte):
12984 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12985 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12986 * character.h (CHAR_TO_BYTE8):
12987 * cmds.c (internal_self_insert):
12988 * editfns.c (general_insert_function):
12989 * keymap.c (push_key_description):
12990 * search.c (Freplace_match):
12991 * xdisp.c (message_dolog, set_message_1): All callers changed.
12993 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12995 * keyboard.c (safe_run_hook_funcall): New function.
12996 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12997 don't set the hook to nil, but remove the offending function instead.
12998 (Qcommand_hook_internal): Remove, unused.
12999 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13000 Vcommand_hook_internal.
13002 * eval.c (enum run_hooks_condition): Remove.
13003 (funcall_nil, funcall_not): New functions.
13004 (run_hook_with_args): Call each function through a `funcall' argument.
13005 Remove `cond' argument, now redundant.
13006 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13007 (Frun_hook_with_args_until_failure): Adjust accordingly.
13008 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13010 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
13012 * dispextern.h (string_buffer_position): Remove declaration.
13014 * print.c (strout): Remove parameter `multibyte', unused since
13015 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13017 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13018 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13019 All callers changed.
13021 * w32.c (_wsa_errlist): Use braces for struct initializers.
13023 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13024 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13025 All callers changed.
13026 (string_buffer_position): Likewise. Also, make static (it's never
13027 used outside xdisp.c).
13028 (cursor_row_p): Remove parameter `w', unused since
13029 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13030 (decode_mode_spec): Remove parameter `precision', introduced during
13031 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13032 All callers changed.
13034 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13036 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13038 2011-03-27 Anders Lindgren <andlind@gmail.com>
13040 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13041 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13042 (ns_update_auto_hide_menu_bar): New functions.
13043 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13044 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13045 ns_constrain_all_frames.
13046 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13047 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13049 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13051 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13053 2011-03-27 Glenn Morris <rgm@gnu.org>
13055 * syssignal.h: Replace RETSIGTYPE with void.
13056 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13057 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13058 Replace SIGTYPE with void everywhere.
13059 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13060 * s/template.h (SIGTYPE): Remove commented out definition.
13062 2011-03-26 Eli Zaretskii <eliz@gnu.org>
13064 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13065 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13067 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
13069 * w32.c (read_unc_volume): Use parameter `henum', instead of
13070 global variable `wget_enum_handle'.
13072 * keymap.c (describe_vector): Remove parameters `indices' and
13073 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13074 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13076 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13078 * keyboard.c (timer_check): Remove parameter `do_it_now',
13079 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13080 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13081 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13083 * keyboard.c (read_char):
13084 * w32menu.c (w32_menu_display_help):
13085 * xmenu.c (show_help_event, menu_help_callback):
13086 Adjust calls to `show_help_echo'.
13088 * gtkutil.c (xg_maybe_add_timer):
13089 * keyboard.c (readable_events):
13090 * process.c (wait_reading_process_output):
13091 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13093 * insdel.c (adjust_markers_gap_motion):
13094 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13095 (gap_left, gap_right): Don't call it.
13097 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
13099 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13100 incurred during fontification.
13102 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
13104 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13105 (DEFVAR_PER_BUFFER): Don't pass it.
13107 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13108 (scrolling_window): Don't pass it.
13110 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
13112 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13114 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13116 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13117 of variables specific to SELinux and computation of `encoded_absname'.
13119 * image.c (XPutPixel): Remove unused variable `height'.
13121 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13123 * unexw32.c (get_section_info): Remove unused variable `section'.
13125 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13126 (system_process_attributes): Remove unused variable `sess'.
13127 (sys_read): Remove unused variable `err'.
13129 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13130 (w32_wnd_proc): Remove unused variable `isdead'.
13131 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13132 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13133 (x_create_tip_frame): Remove unused variable `tem'.
13135 * w32inevt.c (w32_console_read_socket):
13136 Remove unused variable `no_events'.
13138 * w32term.c (x_draw_composite_glyph_string_foreground):
13139 Remove unused variable `width'.
13141 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
13143 * w32term.c (x_set_glyph_string_clipping):
13144 Don't pass uninitialized region to CombineRgn.
13146 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
13148 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13149 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13150 (Fx_close_connection): Remove unused variable `i'.
13152 * w32font.c (w32font_draw): Return number of glyphs.
13153 (w32font_open_internal): Remove unused variable `i'.
13154 (w32font_driver): Add missing initializer.
13156 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13157 (fill_in_menu): Remove unused variable `items_added'.
13159 * w32term.c (last_mouse_press_frame): Remove static global variable.
13160 (w32_clip_to_row): Remove unused variable `f'.
13161 (x_delete_terminal): Remove unused variable `i'.
13163 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13164 (NOTHING): Remove unused static global variable.
13165 (uniscribe_check_otf): Remove unused variable `table'.
13166 (uniscribe_font_driver): Add missing initializers.
13168 2011-03-23 Julien Danjou <julien@danjou.info>
13170 * term.c (Fsuspend_tty, Fresume_tty):
13171 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13172 * window.c (temp_output_buffer_show):
13173 * insdel.c (signal_before_change):
13174 * frame.c (Fhandle_switch_frame):
13175 * fileio.c (Fdo_auto_save):
13176 * emacs.c (Fkill_emacs):
13177 * editfns.c (save_excursion_restore):
13178 * cmds.c (internal_self_insert):
13179 * callint.c (Fcall_interactively):
13180 * buffer.c (Fkill_all_local_variables):
13181 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13183 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
13184 unconditionally since it does the check itself.
13186 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
13188 Fix more problems found by GCC 4.5.2's static checks.
13190 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13191 the first time through the loop, since we know p0 < p1 then.
13192 This also avoids a gcc -Wstrict-overflow warning.
13194 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13195 leading to a memory leak, possible in functions like
13196 load_charset_map_from_file that can allocate an unbounded number
13197 of objects (Bug#8318).
13199 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13200 that could (at least in theory) be that large.
13202 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13203 This is less likely to overflow, and avoids undefined behavior if
13204 overflow does occur. All callers changed. Use strtoul to scan
13205 for the unsigned long integer.
13206 (pint2hrstr): Simplify and tune code slightly.
13207 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
13209 * scroll.c (do_scrolling): Work around GCC bug 48228.
13210 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13212 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13213 This also avoids a warning with gcc -Wstrict-overflow.
13214 (validate_x_resource_name): Simplify count usage.
13215 This also avoids a warning with gcc -Wstrict-overflow.
13217 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13220 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
13222 * process.c (Fmake_network_process): Use socklen_t, not int,
13223 where POSIX says socklen_t is required in portable programs.
13224 This fixes a porting bug on hosts like 64-bit HP-UX, where
13225 socklen_t is wider than int (Bug#8277).
13226 (Fmake_network_process, server_accept_connection):
13227 (wait_reading_process_output, read_process_output):
13230 * process.c: Rename or move locals to avoid shadowing.
13231 (list_processes_1, Fmake_network_process):
13232 (read_process_output_error_handler, exec_sentinel_error_handler):
13233 Rename or move locals.
13234 (Fmake_network_process): Define label "retry_connect" only if needed.
13235 (Fnetwork_interface_info): Fix pointer signedness.
13236 (process_send_signal): Add cast to avoid pointer signedness problem.
13237 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
13238 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
13240 Make tparam.h and terminfo.c consistent.
13241 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13242 Include tparam.h instead, since it declares them.
13243 * cm.h (PC): Remove extern decl; tparam.h now does this.
13244 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13245 * terminfo.c: Include tparam.h, to check interfaces.
13246 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13247 (tparam): Adjust signature to match interface in tparam.h;
13248 this removes some undefined behavior. Check that outstring and len
13249 are zero, which they always are with Emacs.
13250 * tparam.h (PC, BC, UP): New extern decls.
13252 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
13253 (xftfont_open): Rename locals to avoid shadowing.
13255 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
13256 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13257 (OTF_TAG_SYM): Omit macro if not needed.
13258 (ftfont_list): Remove unused local.
13259 (get_adstyle_property, ftfont_pattern_entity):
13260 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13261 Rename locals to avoid shadowing.
13263 * xfont.c (xfont_list_family): Mark var as initialized.
13265 * xml.c (make_dom): Now static.
13267 * composite.c (composition_compute_stop_pos): Rename local to
13269 (composition_reseat_it): Remove unused locals.
13270 (find_automatic_composition, composition_adjust_point): Likewise.
13271 (composition_update_it): Mark var as initialized.
13272 (find_automatic_composition): Mark vars as initialized,
13273 with a FIXME (Bug#8290).
13275 character.h: Rename locals to avoid shadowing.
13276 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13277 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13278 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13279 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13280 to avoid shadowing.
13282 * textprop.c (property_change_between_p): Remove; unused.
13284 * intervals.c (interval_start_pos): Now static.
13286 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13288 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13289 Rename locals to avoid shadowing.
13291 * sound.c (wav_play, au_play, Fplay_sound_internal):
13292 Fix pointer signedness.
13293 (alsa_choose_format): Remove unused local var.
13294 (wav_play): Initialize a variable to 0, to prevent undefined
13295 behavior (Bug#8278).
13297 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13299 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13301 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13302 clobbering (Bug#8298).
13303 * sysdep.c (sys_subshell): Likewise.
13304 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
13306 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13307 This should get cleaned up, so that child_setup has the
13308 same signature on all platforms.
13310 * callproc.c (call_process_cleanup): Now static.
13311 (relocate_fd): Rename locals to avoid shadowing.
13313 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
13315 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13316 not to be necessary, and produces flickering.
13318 2011-03-20 Glenn Morris <rgm@gnu.org>
13320 * config.in: Remove file.
13322 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
13324 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13325 are now in src/globals.h.
13326 (syms_of_minibuf): Remove spurious & from previous change.
13328 2011-03-20 Leo Liu <sdl.web@gmail.com>
13330 * minibuf.c (completing-read-function): New variable.
13331 (completing-read-default): Rename from completing-read.
13332 (completing-read): Call completing-read-function.
13334 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
13336 * xfaces.c (Fx_load_color_file):
13337 Read color file from absolute filename (bug#8250).
13339 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
13341 * makefile.w32-in: Update dependencies.
13343 2011-03-17 Eli Zaretskii <eliz@gnu.org>
13345 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13347 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13349 Fix more problems found by GCC 4.5.2's static checks.
13351 * process.c (make_serial_process_unwind, send_process_trap):
13352 (sigchld_handler): Now static.
13354 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13355 That way, the code declares only the vars that it needs.
13356 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13357 * s/cygwin.h (PTY_ITERATION): Likewise.
13358 * s/darwin.h (PTY_ITERATION): Likewise.
13359 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13361 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13362 * process.c (allocate_pty): Don't declare stb unless it's needed.
13364 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
13365 (CONSTANTLIM): Remove; unused.
13366 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13367 Define only if needed.
13369 * unexelf.c (unexec): Name an expression,
13370 to avoid gcc -Wbad-function-cast warning.
13371 Use a different way to cause a compilation error if anyone uses
13372 n rather than nn, a way that does not involve shadowing.
13373 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
13375 * deps.mk (unexalpha.o): Remove; unused.
13377 New file unexec.h, the (simple) interface for unexec (Bug#8267).
13378 * unexec.h: New file.
13379 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13380 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13381 Depend on unexec.h.
13382 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13383 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13384 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
13385 Change as necessary to match prototype in unexec.h.
13387 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13389 (back_comment, skip_chars): Mark vars as initialized.
13391 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13392 Rename locals to avoid shadowing.
13394 * lread.c (read1): Rewrite so as not to use empty "else".
13395 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
13397 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13399 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13400 warning when compiling print.c.
13402 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13403 instead of using an uninitialized var.
13404 (font_sort_entities): Mark var as initialized.
13406 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13408 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13409 pointers to constants.
13410 (font_parse_fcname): Remove unused vars.
13411 (font_delete_unmatched): Now static.
13412 (font_get_spec): Remove; unused.
13413 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13414 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13415 Rename or move locals to avoid shadowing.
13417 * fns.c (require_nesting_list, require_unwind): Now static.
13418 (Ffillarray): Rename locals to avoid shadowing.
13420 * floatfns.c (domain_error2): Define only if needed.
13421 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
13423 * alloc.c (mark_backtrace): Move decl from here ...
13424 * lisp.h: ... to here, so that it can be checked.
13426 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
13427 (Fdefvar): Rewrite so as not to use empty "else".
13428 (lisp_indirect_variable): Name an expression,
13429 to avoid gcc -Wbad-function-cast warning.
13430 (Fdefvar): Rename locals to avoid shadowing.
13432 * callint.c (quotify_arg, quotify_args): Now static.
13433 (Fcall_interactively): Rename locals to avoid shadowing.
13434 Use const pointer when appropriate.
13436 * lisp.h (get_system_name, get_operating_system_release):
13437 Move decls here, to check interfaces.
13438 * process.c (get_operating_system_release): Move decl to lisp.h.
13439 * xrdb.c (get_system_name): Likewise.
13440 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13441 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13442 some of which prompt warnings from gcc -Wbad-function-cast.
13443 (Fformat_time_string, Fencode_time, Finsert_char):
13444 (Ftranslate_region_internal, Fformat):
13445 Rename or remove local vars to avoid shadowing.
13446 (Ftranslate_region_internal): Mark var as initialized.
13448 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13451 * lisp.h (eassert): Check that the argument compiles, even if
13452 ENABLE_CHECKING is not defined.
13454 * data.c (Findirect_variable): Name an expression, to avoid
13455 gcc -Wbad-function-cast warning.
13456 (default_value, arithcompare, arith_driver, arith_error): Now static.
13457 (store_symval_forwarding): Rename local to avoid shadowing.
13458 (Fmake_variable_buffer_local, Fmake_local_variable):
13459 Mark variables as initialized.
13460 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
13462 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
13463 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13464 Rename locals to avoid shadowing.
13465 (mark_stack): Move local variables into the #ifdef region where
13467 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13468 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13470 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13471 (GC_STRING_CHARS): Remove; not used.
13472 (Fmemory_limit): Cast sbrk's returned value to char *.
13474 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13475 avoids undefined behavior in theory.
13477 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13479 Use functions, not macros, for up- and down-casing (Bug#8254).
13480 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13481 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13482 to use the following functions instead of these macros.
13483 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13484 EMACS_INT, since callers assume the returned value fits in int.
13485 (upcase1): Likewise, for UPCASE_TABLE.
13486 (uppercasep, lowercasep, upcase): New static inline functions.
13487 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
13488 the race-condition problem in the old DOWNCASE.
13490 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13491 Rename locals to avoid shadowing.
13492 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
13493 (regex_compile, re_search_2, re_match_2_internal):
13494 Remove unused local vars.
13495 (FREE_VAR): Rewrite so as not to use empty "else",
13496 which gcc can warn about.
13497 (regex_compile, re_match_2_internal): Mark locals as initialized.
13498 (RETALLOC_IF): Define only if needed.
13499 (WORDCHAR_P): Likewise. This one is never needed, but is used
13500 only in a comment talking about a compiler bug, so put inside
13501 the #if 0 of that comment.
13502 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13503 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13506 * search.c (boyer_moore): Rename locals to avoid shadowing.
13507 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13508 (PREV_CHAR_BOUNDARY): Likewise.
13510 * search.c (simple_search): Remove unused var.
13512 * dired.c (compile_pattern): Move decl from here ...
13513 * lisp.h: ... to here, so that it can be checked.
13514 (struct re_registers): New forward decl.
13516 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13518 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13520 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13521 Rename locals to avoid shadowing.
13522 (Fvertical_motion): Mark locals as initialized.
13524 * casefiddle.c (casify_object, casify_region): Now static.
13525 (casify_region): Mark local as initialized.
13527 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13529 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13530 New macros, so that the caller can use some names other than
13531 gcpro1, gcpro2, etc.
13532 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13534 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13535 argument, for consistency with GCPRO2_VAR, etc: it is now the
13536 prefix of the variable, not the variable itself. All uses
13538 * dired.c (directory_files_internal, file_name_completion):
13539 Rename locals to avoid shadowing.
13541 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13542 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13543 dired.c's scmp function, had undefined behavior.
13544 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13545 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13546 * buffer.h: ... to here, because these macros use current_buffer,
13547 and the new implementation with inline functions needs to have
13548 current_buffer in scope now, rather than later when the macros
13550 (downcase, upcase1): New static inline functions.
13551 (DOWNCASE, UPCASE1): Reimplement using these functions.
13552 This avoids undefined behavior in expressions like
13553 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13554 from race conditions in accessing the global variables
13555 case_temp1 and case_temp2.
13556 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13557 * lisp.h (case_temp1, case_temp2): Remove their decls.
13558 * character.h (ASCII_CHAR_P): Move from here ...
13559 * lisp.h: ... to here, so that the inline functions mentioned
13560 above can use them.
13562 * dired.c (directory_files_internal_unwind): Now static.
13564 * fileio.c (file_name_as_directory, directory_file_name):
13565 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13567 (file_name_as_directory): Use const pointers when appropriate.
13568 (Fexpand_file_name): Likewise. In particular, newdir might
13569 point at constant storage, so make it a const pointer.
13570 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
13571 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13573 (Fset_file_times, Finsert_file_contents, auto_save_error):
13574 Rename locals to avoid shadowing.
13576 * minibuf.c (choose_minibuf_frame_1): Now static.
13577 (Ftry_completion, Fall_completions): Rename or remove locals
13578 to avoid shadowing.
13580 * marker.c (bytepos_to_charpos): Remove; unused.
13582 * lisp.h (verify_bytepos, count_markers): New decls,
13583 so that gcc does not warn that these functions aren't declared.
13585 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13586 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
13587 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
13588 (copy_text): Remove unused local var.
13590 * filelock.c (within_one_second): Now static.
13591 (lock_file_1): Rename local to avoid shadowing.
13593 * buffer.c (fix_overlays_before): Mark locals as initialized.
13594 (fix_start_end_in_overlays): Likewise. This function should be
13595 simplified by using pointers-to-pointers, but that's a different
13597 (switch_to_buffer_1): Now static.
13598 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13599 (report_overlay_modification): Rename locals to avoid shadowing.
13601 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
13602 Fix pointer signedness issue.
13603 (sys_subshell): Mark local as volatile if checking for lint,
13604 to suppress a gcc -Wclobbered warning that does not seem to be right.
13605 (MAXPATHLEN): Define only if needed.
13607 * process.c (serial_open, serial_configure): Move decls from here ...
13608 * systty.h: ... to here, so that they can be checked.
13610 * fns.c (get_random, seed_random): Move extern decls from here ...
13611 * lisp.h: ... to here, so that they can be checked.
13613 * sysdep.c (reset_io): Now static.
13614 (wait_for_termination_signal): Remove; unused.
13616 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13617 (copy_keymap_item, append_key, push_text_char_description):
13619 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
13620 (DENSE_TABLE_SIZE): Remove; unused.
13621 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13622 (describe_map_tree):
13623 Rename locals to avoid shadowing.
13625 * keyboard.c: Declare functions static if they are not used elsewhere.
13626 (echo_char, echo_dash, cmd_error, top_level_2):
13627 (poll_for_input, handle_async_input): Now static.
13628 (read_char, kbd_buffer_get_event, make_lispy_position):
13629 (make_lispy_event, make_lispy_movement, apply_modifiers):
13630 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13631 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13632 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
13633 (read_key_sequence, read_char): Mark locals as initialized.
13634 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
13636 * keyboard.h (make_ctrl_char): New decl.
13637 (mark_kboards): Move decl here ...
13638 * alloc.c (mark_kboards): ... from here.
13640 * lisp.h (force_auto_save_soon): New decl.
13642 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
13643 (DEFINE_DUMMY_FUNCTION): New macro.
13644 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13646 (main): Add casts to avoid warnings
13647 if GCC considers string literals to be constants.
13649 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13651 * dbusbind.c: Pointer signedness fixes.
13652 (xd_signature, xd_append_arg, xd_initialize):
13653 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13654 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13655 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13656 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13658 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13659 if GCC considers string literals to be constants.
13660 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
13662 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13664 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13665 (print_preprocess, print_object): New macro to fix last change.
13667 * print.c (print_preprocess): Don't forget font objects.
13669 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
13671 * emacs.c (USAGE3): Doc fixes.
13673 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13675 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13678 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
13680 * lisp.h (VWindow_system, Qfile_name_history):
13681 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13682 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13683 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13685 * w32select.c: Don't #include "keyboard.h".
13686 (run_protected): Add extern declaration for waiting_for_input.
13688 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13689 * w32console.c (detect_input_pending, read_input_pending)
13690 (encode_terminal_code):
13691 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13692 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13693 (w32_system_caret_y, Qfile_name_history):
13694 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13695 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13696 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13697 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13698 * w32proc.c (Qlocal, report_file_error):
13699 * w32term.c (Vwindow_system, updating_frame):
13700 * w32uniscribe.c (initialized, uniscribe_font_driver):
13701 Remove unneeded extern declarations.
13703 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
13705 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
13707 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
13709 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13710 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13711 These macros can no longer be used for assignment.
13713 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13714 Assign struct members directly, instead of using BUF_BEGV etc.
13715 (record_buffer_markers, fetch_buffer_markers): New functions for
13716 recording and fetching special buffer markers.
13717 (set_buffer_internal_1, set_buffer_temp): Use them.
13719 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13721 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13723 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13724 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13726 * xdisp.c (hscroll_window_tree):
13727 (reconsider_clip_changes): Use PT instead of BUF_PT.
13729 2011-03-13 Eli Zaretskii <eliz@gnu.org>
13731 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13732 $(EMACS_ROOT)/lib/intprops.h.
13734 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13736 Fix more problems found by GCC 4.5.2's static checks.
13738 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13739 to unsigned char * to avoid compiler diagnostic.
13740 (xg_free_frame_widgets): Make it clear that a local variable is
13741 needed only if USE_GTK_TOOLTIP.
13742 (gdk_window_get_screen): Make it clear that this macro is needed
13743 only if USE_GTK_TOOLTIP.
13744 (int_gtk_range_get_value): New function, which avoids a diagnostic
13745 from gcc -Wbad-function-cast.
13746 (xg_set_toolkit_scroll_bar_thumb): Use it.
13747 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13748 diagnostic from gcc -Wbad-function-cast.
13749 (get_utf8_string, xg_get_file_with_chooser):
13750 Rename locals to avoid shadowing.
13751 (create_dialog): Move locals to avoid shadowing.
13753 * xgselect.c (xg_select): Remove unused var.
13755 * image.c (four_corners_best): Mark locals as initialized.
13756 (gif_load): Initialize transparent_p to zero (Bug#8238).
13757 Mark another local as initialized.
13758 (my_png_error, my_error_exit): Mark with NO_RETURN.
13760 * image.c (clear_image_cache): Now static.
13761 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
13762 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
13763 (x_edge_detection): Remove unnecessary cast that
13764 gcc -Wbad-function-cast diagnoses.
13765 (gif_load): Fix pointer signedness.
13766 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13767 (jpeg_load, gif_load): Rename locals to avoid shadowing.
13769 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
13771 Improve quality of tests for time stamp overflow.
13772 For example, without this patch (encode-time 0 0 0 1 1
13773 1152921504606846976) returns the obviously-bogus value (-948597
13774 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13775 reports time overflow. See
13776 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
13777 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13778 * editfns.c: Include limits.h and intprops.h.
13779 (TIME_T_MIN, TIME_T_MAX): New macros.
13780 (time_overflow): Move earlier, to before first use.
13781 (hi_time, lo_time): New functions, for an accurate test for
13782 out-of-range times.
13783 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13784 (Fget_internal_run_time): Don't assume time_t fits in int.
13785 (make_time): Use list2 instead of Fcons twice.
13786 (Fdecode_time): More accurate test for out-of-range times.
13787 (check_tm_member): New function.
13788 (Fencode_time): Use it, to test for out-of-range times.
13789 (lisp_time_argument): Don't rely on undefined left-shift and
13790 right-shift behavior when checking for time stamp overflow.
13792 * editfns.c (time_overflow): New function, refactoring common code.
13793 (Fformat_time_string, Fdecode_time, Fencode_time):
13794 (Fcurrent_time_string): Use it.
13796 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13797 * dired.c (make_time): Move to ...
13798 * editfns.c (make_time): ... here.
13799 * systime.h: Note the move.
13801 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
13803 * fringe.c (update_window_fringes): Remove unused variables.
13805 * unexmacosx.c (copy_data_segment): Also copy __got section.
13808 2011-03-12 Eli Zaretskii <eliz@gnu.org>
13810 * termcap.c [MSDOS]: Include "msdos.h".
13811 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13812 Constify `char *' arguments and their references according to
13813 prototypes in tparam.h.
13815 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
13817 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13818 Adapt all references accordingly.
13820 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13822 2011-03-11 Tom Tromey <tromey@redhat.com>
13824 * buffer.c (syms_of_buffer): Remove obsolete comment.
13826 2011-03-11 Eli Zaretskii <eliz@gnu.org>
13828 * termhooks.h (encode_terminal_code): Declare prototype.
13830 * msdos.c (encode_terminal_code): Don't declare prototype.
13832 * term.c (encode_terminal_code): Now external again, used by
13833 w32console.c and msdos.c.
13835 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13836 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
13838 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
13840 Fix some minor problems found by GCC 4.5.2's static checks.
13842 * fringe.c (update_window_fringes): Mark locals as initialized
13844 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
13846 * alloc.c (mark_fringe_data): Move decl from here ...
13847 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13848 to check its interface.
13849 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13851 * fontset.c (free_realized_fontset): Now static.
13852 (Fset_fontset_font): Rename local to avoid shadowing.
13853 (fontset_font): Mark local as initialized.
13854 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
13856 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13858 * xselect.c (x_disown_buffer_selections): Remove; not used.
13859 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
13860 (x_own_selection, Fx_disown_selection_internal): Rename locals
13861 to avoid shadowing.
13862 (x_handle_dnd_message): Remove local to avoid shadowing.
13864 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13865 so that the caller can use some name other than gcpro1.
13866 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
13867 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13868 (Fx_backspace_delete_keys_p):
13869 Use them to avoid shadowing, and rename vars to avoid shadowing.
13870 (x_decode_color, x_set_name, x_window): Now static.
13871 (Fx_create_frame): Add braces to silence GCC warning.
13872 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
13873 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13874 Remove unused locals.
13875 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13876 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13877 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13880 * xterm.h (x_mouse_leave): New decl.
13882 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13883 Remove unused functions.
13884 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13885 (x_calc_absolute_position): Now static.
13886 (XTread_socket): Don't define label "out" unless it's used.
13887 Don't declare local "event" unless it's used.
13888 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13889 unless they are used.
13890 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13891 (x_fatal_error_signal): Remove; not used.
13892 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13893 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13894 (x_error_catcher, x_connection_closed, x_error_handler):
13895 (x_error_quitter, xembed_send_message, x_iconify_frame):
13896 (my_log_handler): Rename locals to avoid shadowing.
13897 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
13898 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
13900 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13901 Rename or move locals to avoid shadowing.
13902 (tty_defined_color, merge_face_heights): Now static.
13903 (free_realized_faces_for_fontset): Remove; not used.
13904 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13905 does not deduce is never used uninitialized.
13906 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13907 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
13909 * terminal.c (store_terminal_param): Now static.
13911 * xmenu.c (menu_highlight_callback): Now static.
13912 (set_frame_menubar): Remove unused local.
13913 (xmenu_show): Rename parameter to avoid shadowing.
13914 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13915 since they might point to immutable storage.
13916 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13917 since it's unused otherwise.
13919 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
13920 Add a FIXME, since the code still doesn't look right. (Bug#8215)
13921 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13922 avoids a gcc -Wuninitialized diagnostic.
13923 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
13924 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13925 does not deduce are never used uninitialized.
13927 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13929 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
13930 * window.c (window_loop, size_window):
13931 (run_window_configuration_change_hook, enlarge_window): Likewise.
13933 * window.c (display_buffer): Now static.
13934 (size_window): Mark variables that gcc -Wuninitialized
13935 does not deduce are never used uninitialized.
13936 * window.h (check_all_windows): New decl, to forestall
13937 gcc -Wmissing-prototypes diagnostic.
13938 * dispextern.h (bidi_dump_cached_states): Likewise.
13940 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13942 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
13943 Include <limits.h>.
13944 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13945 and to avoid gcc -Wuninitialized warning.
13946 (load_charset_map): Mark variables that gcc -Wuninitialized
13947 does not deduce are never used uninitialized.
13948 (load_charset): Abort instead of using uninitialized var (Bug#8229).
13950 * coding.c (coding_set_source, coding_set_destination):
13951 Use "else { /* comment */ }" rather than "else /* comment */;"
13952 for clarity, and to avoid gcc -Wempty-body warning.
13953 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13954 a block, when the outer 'i' will do.
13955 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13956 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13957 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13958 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13959 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13960 Rename locals to avoid shadowing.
13961 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
13962 * coding.c (emacs_mule_char, encode_invocation_designation):
13963 Now static, since they're not used elsewhere.
13964 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
13965 (decode_coding_object, encode_coding_object, detect_coding_system):
13966 (decode_coding_emacs_mule): Mark variables that gcc
13967 -Wuninitialized does not deduce are never used uninitialized.
13968 (detect_coding_iso_2022): Initialize a local variable that might
13969 be used uninitialized. Leave a FIXME because it's not clear that
13970 this initialization is needed. (Bug#8211)
13971 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13972 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13973 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13974 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13975 Remove unused macros.
13977 * category.c (hash_get_category_set): Remove unused local var.
13978 (copy_category_table): Now static, since it's not used elsewhere.
13979 * character.c (string_count_byte8): Likewise.
13981 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13982 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13984 * chartab.c (copy_sub_char_table): Now static, since it's not used
13986 (sub_char_table_ref_and_range, char_table_ref_and_range):
13987 Rename locals to avoid shadowing.
13988 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
13990 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
13991 (BIDI_BOB): Remove unused macro.
13993 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13994 deduce are never used uninitialized.
13995 * term.c (encode_terminal_code): Likewise.
13997 * term.c (encode_terminal_code): Now static. Remove unused local.
13999 * tparam.h: New file.
14000 * term.c, tparam.h: Include it.
14001 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14002 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14003 Move these decls to tparam.h, and make them agree with what
14004 is actually in tparam.c. The previous trick of using incompatible
14005 decls in different modules does not conform to the C standard.
14006 All callers of tparam changed to use tparam's actual API.
14007 * tparam.c (tparam1, tparam, tgoto):
14008 Use const pointers where appropriate.
14010 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14011 * cm.h (struct cm): Likewise.
14012 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14013 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14014 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14015 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14016 (turn_on_face, init_tty): Likewise.
14017 * termchar.h (struct tty_display_info): Likewise.
14019 * term.c (term_mouse_position): Rename local to avoid shadowing.
14021 * alloc.c (mark_ttys): Move decl from here ...
14022 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14024 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14026 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14028 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
14030 * search.c (compile_pattern_1): Remove argument regp, unused since
14031 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14032 (compile_pattern): Don't pass it.
14034 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14036 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14037 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14039 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14041 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14043 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14044 gdk_window_get_screen, gdk_window_get_geometry,
14045 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14046 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14047 (xg_get_pixbuf_from_pixmap): New function.
14048 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14049 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14050 Call xg_get_pixbuf_from_pixmap instead of
14051 gdk_pixbuf_get_from_drawable.
14052 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14053 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14054 (xg_check_special_colors): Use GtkStyleContext and its functions
14056 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14057 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14058 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
14059 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14060 Call gtk_widget_get_preferred_size.
14061 (xg_frame_resized): gdk_window_get_geometry only takes 5
14063 (xg_win_to_widget, xg_event_is_for_menubar):
14064 Call gdk_x11_window_lookup_for_display.
14065 (xg_set_widget_bg): New function.
14066 (delete_cb): New function.
14067 (xg_create_frame_widgets): Connect delete-event to delete_cb.
14068 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
14069 (xg_set_background_color): Call xg_set_widget_bg.
14070 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14071 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14072 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14073 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14075 (update_frame_tool_bar): Call gtk_widget_hide.
14076 (xg_initialize): Use GDK_KEY_g.
14078 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14080 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14082 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14083 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14084 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14086 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
14088 * w32xfns.c (select_palette): Check success of RealizePalette against
14089 GDI_ERROR, not zero.
14091 See ChangeLog.11 for earlier changes.
14093 ;; Local Variables:
14097 Copyright (C) 2011-2012 Free Software Foundation, Inc.
14099 This file is part of GNU Emacs.
14101 GNU Emacs is free software: you can redistribute it and/or modify
14102 it under the terms of the GNU General Public License as published by
14103 the Free Software Foundation, either version 3 of the License, or
14104 (at your option) any later version.
14106 GNU Emacs is distributed in the hope that it will be useful,
14107 but WITHOUT ANY WARRANTY; without even the implied warranty of
14108 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14109 GNU General Public License for more details.
14111 You should have received a copy of the GNU General Public License
14112 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.