1 2011-04-19 Paul Eggert <eggert@cs.ucla.edu>
3 Replace pEd with more-general pI, and fix some printf arg casts.
4 * lisp.h (pI): New macro, generalizing old pEd macro to other
5 conversion specifiers. For example, use "...%"pI"d..." rather
7 (pEd): Remove. All uses replaced with similar uses of pI.
8 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
9 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
13 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
14 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
16 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
17 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
18 * print.c (safe_debug_print, print_object): Likewise.
19 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
21 Use pI instead of if-then-else-abort. Use %p to avoid casts.
22 * process.c (Fmake_network_process): Use pI to avoid cast.
23 * region-cache.c (pp_cache): Likewise.
24 * xdisp.c (decode_mode_spec): Likewise.
25 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
26 behavior on 64-bit hosts with printf arg.
27 * xselect.c (x_queue_event): Use %p to avoid casts.
28 (x_stop_queuing_selection_requests): Likewise.
29 (x_get_window_property): Don't truncate byte count to an 'int'
32 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
33 here, since it parses constructs like leading '-' and spaces,
34 which are not wanted; and it overflows with large numbers.
35 Instead, simply match F[0-9]+, which is what is wanted anyway.
37 * alloc.c: Remove unportable assumptions about struct layout.
38 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
39 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
40 (allocate_vectorlike, make_pure_vector): Use the new macros,
41 plus offsetof, to remove unportable assumptions about struct layout.
42 These assumptions hold on all porting targets that I know of, but
43 they are not guaranteed, they're easy to remove, and removing them
44 makes further changes easier.
46 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
47 This doesn't fix a bug but makes the code clearer.
48 (string_overrun_cookie): Now const. Use initializers that
49 don't formally overflow signed char, to avoid warnings.
50 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
51 can cause Emacs to crash when string overrun checking is enabled.
52 (allocate_buffer): Don't assume sizeof (struct buffer) is a
53 multiple of sizeof (EMACS_INT); it need not be, if
54 alignof(EMACS_INT) < sizeof (EMACS_INT).
55 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
57 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
59 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
61 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
63 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
64 definition for no-X builds.
66 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
68 Static checks with GCC 4.6.0 and non-default toolkits.
70 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
72 * process.c (keyboard_bit_set): Define only if SIGIO.
73 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
74 (send_process): Repair possible setjmp clobbering.
76 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
78 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
80 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
82 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
83 Define only if needed.
85 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
86 by pacifying GCC about it. Maybe it's time to retire it?
87 * xfaces.c (USG, __TIMEVAL__): Likewise.
89 * dispextern.h (struct redisplay_interface): Rename param
91 * termhooks.h (struct terminal): Likewise.
92 * xterm.c (xembed_send_message): Likewise.
94 * insdel.c (make_gap_smaller): Define only if
95 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
97 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
100 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
101 so that we aren't warned about unused symbols.
103 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
105 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
107 * xfns.c (x_real_positions): Mark locals as initialized.
109 * xmenu.c (xmenu_show): Don't use uninitialized vars.
111 * xterm.c: Fix problems found by static analysis with other toolkits.
112 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
113 (x_dispatch_event): Declare static if USE_GTK, and
114 define if USE_GTK || USE_X_TOOLKIT.
115 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
116 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
117 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only if
118 defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
120 * xmenu.c (menu_help_callback): Pointer type fixes.
121 Use const pointers when pointing at readonly data. Avoid pointer
123 (FALSE): Remove unused macro.
124 (update_frame_menubar): Remove unused decl.
126 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
128 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
129 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
130 (single_menu_item): Rename local to avoid shadowing.
132 * keyboard.c (make_lispy_event): Remove unused local var.
134 * frame.c, frame.h (x_get_resource_string): Bring this back, but
135 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
137 * bitmaps: Change bitmaps from unsigned char back to the X11
138 compatible char. Avoid the old compiler warnings about
139 out-of-range initializers by using, for example, '\xab' rather
142 * xgselect.c (xgselect_initialize): Check vs interface
143 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
145 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
147 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
150 * fns.c (vector): Remove; this old hack is no longer needed.
152 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
154 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
156 * xrdb.c (x_load_resources): Omit unused local.
158 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
159 (x_window): Rename locals to avoid shadowing.
160 (USG): Use the kludged USG macro, to pacify gcc.
162 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
163 (x_term_init): Remove local to avoid shadowing.
165 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
167 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
168 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
170 2011-04-16 Eli Zaretskii <eliz@gnu.org>
172 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
174 Fix regex.c, syntax.c and friends for buffers > 2GB.
175 * syntax.h (struct gl_state_s): Declare character position members
178 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
180 * textprop.c (verify_interval_modification, interval_of): Declare
183 * intervals.c (adjust_intervals_for_insertion): Declare arguments
186 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
188 * indent.c (Fvertical_motion): Local variable it_start is now
191 * regex.c (re_match, re_match_2, re_match_2_internal)
192 (bcmp_translate, regcomp, regexec, print_double_string)
193 (group_in_compile_stack, re_search, re_search_2, regex_compile)
194 (re_compile_pattern, re_exec): Declare arguments and local
195 variables `size_t' and `ssize_t' and return values `regoff_t', as
197 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
198 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
199 <compile_stack_type>: `size' and `avail' are now `size_t'.
201 * regex.h <regoff_t>: Use ssize_t, not int.
202 (re_search, re_search_2, re_match, re_match_2): Arguments that
203 specify buffer/string position and length are now ssize_t and
204 size_t. Return type is regoff_t.
206 2011-04-16 Ben Key <bkey76@gmail.com>
208 * nsfont.m: Fixed bugs in ns_get_family and
209 ns_descriptor_to_entity that were caused by using free to
210 deallocate memory blocks that were allocated by xmalloc (via
211 xstrdup). This caused Emacs to crash when compiled with
212 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
213 --enable-checking=xmallocoverrun). xfree is now used to
214 deallocate these memory blocks.
216 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
218 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
220 emacs_write: Accept and return EMACS_INT for sizes.
221 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
223 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
224 Accept and return EMACS_INT.
225 (emacs_gnutls_write): Return the number of bytes written on
227 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
228 (emacs_read, emacs_write): Remove check for negative size, as the
229 Emacs source code has been audited now.
230 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
231 (emacs_read, emacs_write): Use it.
232 * process.c (send_process): Adjust to the new signatures of
233 emacs_write and emacs_gnutls_write. Do not attempt to store
234 a byte offset into an 'int'; it might overflow.
235 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
237 * sound.c: Don't assume sizes fit in 'int'.
238 (struct sound_device.period_size, alsa_period_size):
239 Return EMACS_INT, not int.
240 (struct sound_device.write, vox_write, alsa_write):
241 Accept EMACS_INT, not int.
242 (wav_play, au_play): Use EMACS_INT to store sizes and to
243 record read return values.
245 2011-04-15 Ben Key <bkey76@gmail.com>
247 * keyboard.c (Qundefined): Don't declare static since it is used
249 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
250 static since they are used in nsfont.m.
252 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
254 * process.c (Qprocessp): Don't declare static.
255 * lisp.h (Qprocessp): Declare again.
257 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
259 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
261 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
263 Improve C-level modularity by making more things 'static'.
265 Don't publish debugger-only interfaces to other modules.
266 * lisp.h (safe_debug_print, debug_output_compilation_hack):
267 (verify_bytepos, count_markers): Move decls to the only modules
269 * region-cache.h (pp_cache): Likewise.
270 * window.h (check_all_windows): Likewise.
271 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
273 * sysdep.c (croak): Now static, if
274 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
275 * syssignal.h (croak): Declare only if not static.
277 * alloc.c (refill_memory_reserve): Now static if
278 !defined REL_ALLOC || defined SYSTEM_MALLOC.
279 * lisp.h (refill_memory_reserve): Declare only if not static.
281 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
282 Define only if USE_LUCID.
284 * xrdb.c (x_customization_string, x_rm_string): Now static.
286 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
287 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
289 * xdisp.c (draw_row_with_mouse_face): Now static.
290 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
292 * window.h (check_all_windows): Mark externally visible.
294 * window.c (window_deletion_count): Now static.
296 * undo.c: Make symbols static if they're not exported.
297 (last_undo_buffer, last_boundary_position, pending_boundary):
300 * textprop.c (interval_insert_behind_hooks): Now static.
301 (interval_insert_in_front_hooks): Likewise.
303 * term.c: Make symbols static if they're not exported.
304 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
305 (max_frame_lines, tty_set_terminal_modes):
306 (tty_reset_terminal_modes, tty_turn_off_highlight):
307 (get_tty_terminal): Now static.
308 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
309 * termhooks.h (term_mouse_moveto): Do not declare if
311 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
312 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
314 * sysdep.c: Make symbols static if they're not exported.
315 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
317 (sigprocmask_set, full_mask): Remove; unused.
318 (wait_debugging): Mark as visible.
319 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
320 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
322 * syntax.c (syntax_temp): Define only if !__GNUC__.
324 * sound.c (current_sound_device, current_sound): Now static.
326 * search.c (searchbufs, searchbuf_head): Now static.
328 * scroll.c (scroll_cost): Remove; unused.
329 * dispextern.h (scroll_cost): Remove decl.
331 * region-cache.h (pp_cache): Mark as externally visible.
333 * process.c: Make symbols static if they're not exported.
334 (process_tick, update_tick, create_process, chan_process):
335 (Vprocess_alist, proc_buffered_char, datagram_access):
336 (fd_callback_data, send_process_frame, process_sent_to): Now static.
337 (deactivate_process): Mark defn as static, as well as decl.
338 * lisp.h (create_process): Remove decl.
339 * process.h (chan_process, Vprocess_alist): Remove decls.
341 * print.c: Make symbols static if they're not exported.
342 (print_depth, new_backquote_output, being_printed, print_buffer):
343 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
344 (print_interval, print_number_index, initial_stderr_stream):
346 * lisp.h (Fprinc): Remove decl.
347 (debug_output_compilation_hack): Mark as externally visible.
349 * sysdep.c (croak): Move decl from here to syssignal.h.
350 * syssignal.h (croak): Put it here, so the API can be checked when
351 'croak' is called from dissociate_if_controlling_tty.
353 * minibuf.c: Make symbols static if they're not exported.
354 (minibuf_save_list, choose_minibuf_frame): Now static.
355 * lisp.h (choose_minibuf_frame): Remove decl.
357 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
359 * lread.c: Make symbols static if they're not exported.
360 (read_objects, initial_obarray, oblookup_last_bucket_number):
362 (make_symbol): Remove; unused.
363 * lisp.h (initial_obarray, make_symbol): Remove decls.
365 * keyboard.c: Make symbols static if they're not exported.
366 (single_kboard, recent_keys_index, total_keys, recent_keys):
367 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
368 (this_single_command_key_start, echoing, last_auto_save):
369 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
370 (command_loop, echo_now, keyboard_init_hook, help_char_p):
371 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
372 (Vlispy_mouse_stem, double_click_count):
374 (force_auto_save_soon): Define only if SIGDANGER.
375 (ignore_mouse_drag_p): Now static if
376 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
377 (print_help): Remove; unused.
378 (stop_character, last_timer_event): Mark as externally visible.
379 * keyboard.h (ignore_mouse_drag_p): Declare only if
380 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
381 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
382 * lisp.h (echoing): Remove decl.
383 (force_auto_save_soon): Declare only if SIGDANGER.
384 * xdisp.c (redisplay_window): Simplify code, to make it more
385 obvious that ignore_mouse_drag_p is not accessed if !defined
386 USE_GTK && !defined HAVE_NS.
388 * intervals.c: Make symbols static if they're not exported.
389 (merge_properties_sticky, merge_interval_right, delete_interval):
391 * intervals.h (merge_interval_right, delete_interval): Remove decls.
393 * insdel.c: Make symbols static if they're not exported.
394 However, leave prepare_to_modify_buffer alone. It's never
395 called from outside this function, but that appears to be a bug.
396 (combine_after_change_list, combine_after_change_buffer):
397 (adjust_after_replace, signal_before_change): Now static.
398 (adjust_after_replace_noundo): Remove; unused.
399 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
400 (signal_before_change): Remove decls.
402 * indent.c (val_compute_motion, val_vmotion): Now static.
404 * image.c: Make symbols static if they're not exported.
405 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
407 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
408 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
410 * fringe.c (standard_bitmaps): Now static.
411 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
413 * frame.c: Make symbols static if they're not exported.
414 (x_report_frame_params, make_terminal_frame): Now static.
415 (get_frame_param): Now static, unless HAVE_NS.
416 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
417 (x_get_resource_string): Remove; not used.
418 * frame.h (make_terminal_frame, x_report_frame_params):
419 (x_get_resource_string); Remove decls.
420 (x_fullscreen_adjust): Declare only if WINDOWSNT.
421 * lisp.h (get_frame_param): Declare only if HAVE_NS.
423 * font.c, fontset.c: Make symbols static if they're not exported.
424 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
425 (FACE_SUITABLE_FOR_CHAR_P): Use it.
426 * font.c (font_close_object): Now static.
427 * font.h (font_close_object): Remove.
428 * fontset.c (FONTSET_OBJLIST): Remove.
429 (free_realized_fontset) #if-0 the body, which does nothing.
430 (face_suitable_for_char_p): #if-0, as it's never called.
431 * fontset.h (face_suitable_for_char_p): Remove decl.
432 * xfaces.c (face_at_string_position): Use
433 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
434 since 0 is always ASCII.
436 * fns.c (weak_hash_tables): Now static.
438 * fileio.c: Make symbols static if they're not exported.
439 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
440 (Vwrite_region_annotation_buffers): Now static.
442 * eval.c: Make symbols static if they're not exported.
443 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
444 * lisp.h (backtrace_list): Remove decl.
446 * emacs.c: Make symbols static if they're not exported.
447 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
448 (fatal_error_code, fatal_error_signal_hook, standard_args):
450 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
451 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
452 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
453 * lisp.h (fatal_error_signal_hook): Remove decl.
454 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
456 * editfns.c: Move a (normally-unused) function to its only use.
457 * editfns.c, lisp.h (get_operating_system_release): Remove.
458 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
459 worth the hassle of breaking this out.
461 * xterm.c: Make symbols static if they're not exported.
462 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
463 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
464 (x_destroy_window, x_delete_display):
466 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
467 (x_mouse_leave): Remove; unused.
468 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
469 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
470 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
472 (x_mouse_leave): Declare only if WINDOWSNT.
473 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
474 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
477 * ftxfont.c: Make symbols static if they're not exported.
478 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
480 * font.h (ftxfont_driver): Likewise.
482 * xfns.c: Make symbols static if they're not exported.
483 (x_last_font_name, x_display_info_for_name):
484 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
485 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
486 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
487 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
488 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
489 (last_show_tip_args): Now static.
490 (xic_defaut_fontset, xic_create_fontsetname): Define only if
491 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
492 (x_screen_planes): Remove; unused.
493 * dispextern.h (x_screen_planes): Remove decl.
495 * dispnew.c: Make symbols static if they're not exported.
496 * dispextern.h (redraw_garbaged_frames, scrolling):
497 (increment_row_positions): Remove.
498 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
499 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
501 (redraw_garbaged_frames): Remove; unused.
503 * xfaces.c: Make symbols static if they're not exported.
504 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
506 * xterm.h (defined_color): Remove decls.
507 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
508 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
509 (menu_face_changed_default, defined_color, free_realized_face):
510 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
511 (ascii_face_of_lisp_face): Remove; unused.
513 * xdisp.c: Make symbols static if they're not exported.
514 * dispextern.h (scratch_glyph_row, window_box_edges):
515 (glyph_to_pixel_coords, set_cursor_from_row):
516 (get_next_display_element, set_iterator_to_next):
517 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
518 (show_mouse_face): Remove decls
519 * frame.h (message_buf_print): Likewise.
520 * lisp.h (pop_message, set_message, check_point_in_composition):
522 * xterm.h (set_vertical_scroll_bar): Likewise.
523 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
524 (message_buf_print, scratch_glyph_row, displayed_buffer):
525 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
526 (get_next_display_element, show_mouse_face, window_box_edges):
527 (frame_to_window_pixel_xy, check_point_in_composition):
528 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
529 (glyph_to_pixel_coords): Remove; unused.
531 * dired.c (file_name_completion): Now static.
533 * dbusbind.c (xd_in_read_queued_messages): Now static.
535 * lisp.h (circular_list_error, FOREACH): Remove; unused.
536 * data.c (circular_list_error): Remove.
538 * commands.h (last_point_position, last_point_position_buffer):
539 (last_point_position_window): Remove decls.
540 * keyboard.c: Make these variables static.
542 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
544 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
545 (iso_code_class, detect_coding, code_convert_region): Now static.
546 (encode_coding_gap): Remove; unused.
548 * chartab.c (chartab_chars, chartab_bits): Now static.
550 * charset.h (charset_iso_8859_1): Remove decl.
551 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
554 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
555 * ccl.c (Vccl_program_table): Now static.
556 (check_ccl_update): Remove; unused.
558 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
559 * category.h: ... from here.
560 * category.c (check_category_table, set_category_set): Now static.
562 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
563 * lisp.h: Remove these decls.
565 * buffer.c (buffer_count): Remove unused var.
567 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
568 so that it's not optimized away.
569 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
570 * dispextern.h (bidi_dump_cached_states): Remove, since it's
571 exported only to the debugger.
573 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
574 * atimer.h (run_all_atimers): Removed; not exported.
576 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
577 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
578 was inaccessible from Lisp.
579 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
580 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
582 alloc.c: Import and export fewer symbols, and remove unused items.
583 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
585 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
586 it's not optimized away by whole-program optimization.
587 (message_enable_multibyte, free_misc): Remove.
588 (catchlist, handlerlist, mark_backtrace):
589 Declare only if BYTE_MARK_STACK.
590 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
591 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
592 (message_enable_multibyte): Remove decl.
593 (free_misc, interval_free_list, float_block, float_block_index):
594 (n_float_blocks, float_free_list, cons_block, cons_block_index):
595 (cons_free_list, last_marked_index):
597 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
598 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
599 (mark_backtrace): Define only if BYTE_MARK_STACK.
600 * xdisp.c (message_enable_multibyte): Now static.
602 Declare Lisp_Object Q* variables to be 'static' if not exported.
603 This makes it easier for human readers (and static analyzers)
604 to see whether these variables are used from other modules.
605 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
606 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
607 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
608 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
609 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
610 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
611 * xmenu.c, xselect.c:
612 Declare Q* vars static if they are not used in other modules.
613 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
614 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
615 Remove decls of unexported vars.
616 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
618 * lisp.h (DEFINE_FUNC): Make sname 'static'.
620 Make Emacs functions such as Fatom 'static' by default.
621 This makes it easier for human readers (and static analyzers)
622 to see whether these functions can be called from other modules.
623 DEFUN now defines a static function. To make the function external
624 so that it can be used in other C modules, use the new macro DEFUE.
625 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
626 (Finit_image_library):
627 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
628 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
629 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
630 Remove decls, since these functions are now static.
631 (Funintern, Fget_internal_run_time): New decls, since these functions
632 were already external.
634 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
635 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
636 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
637 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
638 * keyboard.c, keymap.c, lread.c:
639 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
640 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
641 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
642 Mark functions with DEFUE instead of DEFUN,
643 if they are used in other modules.
644 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
645 decls for now-static functions.
646 * buffer.h (Fdelete_overlay): Remove decl.
647 * callproc.c (Fgetenv_internal): Mark as internal.
648 * composite.c (Fremove_list_of_text_properties): Remove decl.
649 (Fcomposition_get_gstring): New forward static decl.
650 * composite.h (Fcomposite_get_gstring): Remove decl.
651 * dired.c (Ffile_attributes): New forward static decl.
652 * doc.c (Fdocumntation_property): New forward static decl.
653 * eval.c (Ffetch_bytecode): New forward static decl.
654 (Funintern): Remove extern decl; now in .h file where it belongs.
655 * fileio.c (Fmake_symbolic_link): New forward static decl.
656 * image.c (Finit_image_library): New forward static decl.
657 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
658 * intervals.h (Fprevious_property_change):
659 (Fremove_list_of_text_properties): Remove decls.
660 * keyboard.c (Fthis_command_keys): Remove decl.
661 (Fcommand_execute): New forward static decl.
662 * keymap.c (Flookup_key): New forward static decl.
663 (Fcopy_keymap): Now static.
664 * keymap.h (Flookup_key): Remove decl.
665 * process.c (Fget_process): New forward static decl.
666 (Fprocess_datagram_address): Mark as internal.
667 * syntax.c (Fsyntax_table_p): New forward static decl.
668 (skip_chars): Remove duplicate decl.
669 * textprop.c (Fprevious_property_change): New forward static decl.
670 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
672 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
673 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
675 * editfns.c (Fformat): Remove unreachable code.
677 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
679 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
682 2011-04-13 Eli Zaretskii <eliz@gnu.org>
684 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
685 when at ZV. (Bug#8487)
687 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
689 * charset.c (Fclear_charset_maps): Use xfree instead of free.
691 * keyboard.c (parse_tool_bar_item): Likewise.
692 * sound.c (sound_cleanup, alsa_close): Likewise.
693 * termcap.c (tgetent): Likewise.
694 * xfns.c (x_default_font_parameter): Likewise.
695 * xsettings.c (read_and_apply_settings): Likewise.
697 * alloc.c (overrun_check_malloc, overrun_check_realloc)
698 (overrun_check_free): Protoize.
700 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
702 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
703 since callers should never pass a negative size.
704 Change the signature to match that of plain 'read' and 'write'; see
705 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
706 * lisp.h: Update prototypes of emacs_write and emacs_read.
708 2011-04-11 Eli Zaretskii <eliz@gnu.org>
710 * xdisp.c (redisplay_window): Don't try to determine the character
711 position of the scroll margin if the window start point w->startp
712 is outside the buffer's accessible region. (Bug#8468)
714 2011-04-10 Eli Zaretskii <eliz@gnu.org>
716 Fix write-region and its subroutines for buffers > 2GB.
717 * fileio.c (a_write, e_write): Modify declaration of arguments and
718 local variables to support buffers larger than 2GB.
719 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
721 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
722 argument, local variables, and return value.
724 * lisp.h: Update prototypes of emacs_write and emacs_read.
726 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
728 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
730 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
732 Fix more problems found by GCC 4.6.0's static checks.
734 * xdisp.c (vmessage): Use a better test for character truncation.
736 * charset.c (load_charset_map): <, not <=, for optimization,
737 and to avoid potential problems with integer overflow.
738 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
739 * casetab.c (set_identity, shuffle): Likewise.
740 * editfns.c (Fformat): Likewise.
741 * syntax.c (skip_chars): Likewise.
743 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
744 This also lets GCC 4.6.0 generate slightly better loop code.
746 * callint.c (Fcall_interactively): <, not <=, for optimization.
747 (Fcall_interactively): Count the number of arguments produced,
748 not the number of arguments given. This is simpler and lets GCC
749 4.6.0 generate slightly better code.
751 * ftfont.c: Distingish more carefully between FcChar8 and char.
752 The previous code passed unsigned char * to a functions like
753 strlen and xstrcasecmp that expect char *, which does not
754 conform to the C standard.
755 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
756 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
757 char * when the C standard requires it.
759 * keyboard.c (read_char): Remove unused var.
761 * eval.c: Port to Windows vsnprintf (Bug#8435).
763 (SIZE_MAX): Define if the headers do not.
764 (verror): Do not give up if vsnprintf returns a negative count.
765 Instead, grow the buffer. This ports to Windows vsnprintf, which
766 does not conform to C99. Problem reported by Eli Zaretskii.
767 Also, simplify the allocation scheme, by avoiding the need for
768 calling realloc, and removing the ALLOCATED variable.
770 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
772 Remove invocations of doprnt, as Emacs now uses vsnprintf.
773 But keep the doprint source code for now, as we might revamp it
774 and use it again (Bug#8435).
775 * lisp.h (doprnt): Remove.
776 * Makefile.in (base_obj): Remove doprnt.o.
777 * deps.mk (doprnt.o): Remove.
779 error: Print 32- and 64-bit integers portably (Bug#8435).
780 Without this change, on typical 64-bit hosts error ("...%d...", N)
781 was used to print both 32- and 64-bit integers N, which relied on
783 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
785 * lisp.h (error, verror): Mark as printf-like functions.
786 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
787 Report overflow in size calculations when allocating printf buffer.
788 Do not truncate output string at its first null byte.
789 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
790 Truncate the output at a character boundary, since vsnprintf does not
792 * charset.c (check_iso_charset_parameter): Convert internal
793 character to string before calling 'error', since %c now has the
795 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
796 overflow when computing char to be passed to 'error'. Do not
797 pass Lisp_Object to 'error'; pass the integer instead.
798 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
799 formatted with plain %d.
801 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
803 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
805 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
807 * xterm.c (x_catch_errors): Remove duplicate declaration.
809 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
811 * xdisp.c, lisp.h (message_nolog): Remove; unused.
813 2011-04-10 Jim Meyering <meyering@redhat.com>
815 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
816 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
817 return ssize_t not "int", and use size_t as the buffer length.
818 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
819 * gnutls.h: Update declarations.
820 * process.c (read_process_output): Use ssize_t, to match.
821 (send_process): Likewise.
823 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
825 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
827 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
829 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
830 unsigned char, to match FcChar8 type definition.
832 * xterm.c (handle_one_xevent):
833 * xmenu.c (create_and_show_popup_menu):
834 * xselect.c (x_decline_selection_request)
835 (x_reply_selection_request): Avoid type-punned deref of X events.
837 2011-04-09 Eli Zaretskii <eliz@gnu.org>
839 Fix some uses of `int' instead of EMACS_INT.
840 * search.c (string_match_1, fast_string_match)
841 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
842 (scan_buffer, find_next_newline_no_quit)
843 (find_before_next_newline, search_command, Freplace_match)
844 (Fmatch_data): Make some `int' variables be EMACS_INT.
846 * xdisp.c (display_count_lines): 3rd argument and return value now
847 EMACS_INT. All callers changed.
848 (pint2hrstr): Last argument is now EMACS_INT.
850 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
851 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
852 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
853 (decode_coding_utf_16, decode_coding_emacs_mule)
854 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
855 (decode_coding_ccl, decode_coding_charset)
856 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
857 (decode_coding_iso_2022, decode_coding_emacs_mule)
858 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
859 <char_offset, last_offset>: Declare EMACS_INT.
860 (encode_coding_utf_8, encode_coding_utf_16)
861 (encode_coding_emacs_mule, encode_invocation_designation)
862 (encode_designation_at_bol, encode_coding_iso_2022)
863 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
864 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
866 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
867 (encode_invocation_designation): Last argument P_NCHARS is now
869 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
870 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
872 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
875 * ccl.c (Fccl_execute_on_string): Declare some variables
878 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
880 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
882 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
884 * process.c (Fformat_network_address): Doc fix.
886 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
888 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
890 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
892 * keyboard.c (read_char): Call Lisp function help-form-show,
893 instead of using internal_with_output_to_temp_buffer.
894 (Qhelp_form_show): New var.
895 (syms_of_keyboard): Use DEFSYM macro.
897 * print.c (internal_with_output_to_temp_buffer): Function deleted.
899 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
901 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
903 * process.c (Flist_processes): Removed to Lisp.
904 (list_processes_1): Deleted.
906 2011-04-06 Eli Zaretskii <eliz@gnu.org>
908 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
910 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
912 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
914 Fix more problems found by GCC 4.6.0's static checks.
916 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
918 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
920 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
922 * xdisp.c (vmessage): Mark as a printf-like function.
924 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
926 * sound.c (sound_warning): Don't crash if arg contains a printf format.
928 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
929 printf-like functions.
930 (tiff_load): Add casts to remove these marks before passing them
931 to system-supplied API.
933 * eval.c (Fsignal): Remove excess argument to 'fatal'.
935 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
936 This avoids several warnings with gcc -Wstrict-overflow.
937 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
938 directly, rather than having caller test rule sign. This avoids
939 some unnecessary tests.
940 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
941 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
942 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
944 * xfont.c (xfont_text_extents): Remove var that was set but not used.
945 (xfont_open): Avoid unnecessary tests.
947 * composite.c (composition_gstring_put_cache): Use unsigned integer.
949 * composite.h, composite.c (composition_gstring_put_cache):
950 Use EMACS_INT, not int, for length.
952 * composite.h (COMPOSITION_DECODE_REFS): New macro,
953 breaking out part of COMPOSITION_DECODE_RULE.
954 (COMPOSITION_DECODE_RULE): Use it.
955 * composite.c (get_composition_id): Remove unused local vars,
956 by using the new macro.
958 * textprop.c (set_text_properties_1): Change while to do-while,
959 since the condition is always true at first.
961 * intervals.c (graft_intervals_into_buffer): Mark var as used.
962 (interval_deletion_adjustment): Return unsigned value.
965 * process.c (list_processes_1, create_pty, read_process_output):
966 (exec_sentinel): Remove vars that were set but not used.
967 (create_pty): Remove unnecessary "volatile"s.
968 (Fnetwork_interface_info): Avoid possibility of int overflow.
969 (read_process_output): Do adaptive read buffering even if carryover.
970 (read_process_output): Simplify nbytes computation if buffered.
972 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
974 * syntax.c (scan_words): Remove var that was set but not used.
975 (update_syntax_table): Use unsigned instead of int.
977 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
978 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
979 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
981 * print.c (print_error_message): Avoid int overflow.
983 * font.c (font_list_entities): Redo for clarity,
984 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
986 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
987 (font_score): Avoid potential overflow in diff calculation.
989 * fns.c (substring_both): Remove var that is set but not used.
990 (sxhash): Redo loop for clarity and to avoid wraparound warning.
992 * eval.c (funcall_lambda): Rename local to avoid shadowing.
994 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
995 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
996 can always succeed if overflow has undefined behavior.
998 * search.c (boyer_moore, wordify): Remove vars set but not used.
999 (wordify): Omit three unnecessary tests.
1001 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1002 All callers changed. This avoids the need for an unused var.
1004 * casefiddle.c (casify_region): Remove var that is set but not used.
1006 * dired.c (file_name_completion): Remove var that is set but not used.
1008 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1010 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
1011 (Finsert_file_contents): Remove unnecessary code checking fd.
1013 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1014 Check for integer overflow on size calculations.
1016 * buffer.c (Fprevious_overlay_change): Remove var that is set
1019 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1020 Remove vars that are set but not used.
1021 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
1022 (timer_check_2): Mark vars as initialized.
1024 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1026 * image.c (lookup_image): Remove var that is set but not used.
1027 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
1029 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1030 that are set but not used.
1032 * xfns.c (make_invisible_cursor): Don't return garbage
1033 if XCreateBitmapFromData fails (Bug#8410).
1035 * xselect.c (x_get_local_selection, x_handle_property_notify):
1036 Remove vars that are set but not used.
1038 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
1039 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
1041 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1042 Remove var that is set but not used.
1043 (scroll_bar_windows_size): Now size_t, not int.
1044 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1047 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1048 (map_tty_color) [!defined MSDOS]: Likewise.
1050 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1052 * coding.c: Remove vars that are set but not used.
1053 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1054 All callers changed.
1055 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1056 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1057 (decode_coding_charset): Remove vars that are set but not used.
1059 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1060 that is set but not used.
1062 * print.c (print_object): Remove var that is set but not used.
1064 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
1065 The gnulib version avoids calling malloc in the usual case,
1066 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1067 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1068 * filelock.c (current_lock_owner): Likewise.
1069 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1070 * sysdep.c: Include allocator.h, careadlinkat.h.
1071 (emacs_no_realloc_allocator): New static constant.
1072 (emacs_readlink): New function.
1073 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1074 ../lib/careadlinkat.h.
1076 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1078 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1079 first non-nil return value).
1081 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1083 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1084 if not defined (Bug#8403).
1086 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1088 * xdisp.c (display_count_lines): Remove parameter `start',
1089 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1090 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1091 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1092 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1093 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1094 and thereabouts. All callers changed.
1095 (get_per_char_metric): Remove parameter `f', unused since
1096 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1098 2011-04-02 Jim Meyering <meyering@redhat.com>
1100 do not dereference NULL upon failed strdup
1101 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1102 (ns_get_family): Likewise.
1104 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1106 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1108 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1110 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1113 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1115 Add lexical binding.
1117 * window.c (Ftemp_output_buffer_show): New fun.
1118 (Fsave_window_excursion):
1119 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1121 * lread.c (lisp_file_lexically_bound_p): New function.
1122 (Fload): Bind Qlexical_binding.
1123 (readevalloop): Remove `evalfun' arg.
1124 Bind Qinternal_interpreter_environment.
1125 (Feval_buffer): Bind Qlexical_binding.
1126 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1128 (syms_of_lread): Declare `lexical-binding'.
1130 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1132 * keyboard.c (eval_dyn): New fun.
1133 (menu_item_eval_property): Use it.
1135 * image.c (parse_image_spec): Use Ffunctionp.
1137 * fns.c (concat, mapcar1): Accept byte-code-functions.
1139 * eval.c (Fsetq): Handle lexical vars.
1140 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1141 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1142 (FletX, Flet): Obey lexical binding.
1143 (Fcommandp): Handle closures.
1144 (Feval): New `lexical' arg.
1145 (eval_sub): New function extracted from Feval. Use it almost
1146 everywhere where Feval was used. Look up vars in lexical env.
1148 (Ffunctionp): Move from subr.el.
1149 (Ffuncall): Handle closures.
1150 (apply_lambda): Remove `eval_flags'.
1151 (funcall_lambda): Handle closures and new byte-code-functions.
1152 (Fspecial_variable_p): New function.
1153 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1154 but without exporting it to Lisp.
1156 * doc.c (Fdocumentation, store_function_docstring):
1157 * data.c (Finteractive_form): Handle closures.
1159 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1162 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1164 (exec_byte_code): New function extracted from Fbyte_code to handle new
1165 calling convention for byte-code-functions. Add new byte-codes.
1167 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
1169 * alloc.c (Fmake_symbol): Init new `declared_special' field.
1171 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1173 * xdisp.c (redisplay_internal): Fix prototype.
1175 2011-03-31 Eli Zaretskii <eliz@gnu.org>
1177 * xdisp.c (SCROLL_LIMIT): New macro.
1178 (try_scrolling): Use it when setting scroll_limit. Limit
1179 scrolling to 100 screen lines.
1180 (redisplay_window): Even when falling back on "recentering",
1181 position point in the window according to scroll-conservatively,
1182 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1184 (try_scrolling): When point is above the window, allow searching
1185 as far as scroll_max, or one screenful, to compute vertical
1186 distance from PT to the scroll margin position. This prevents
1187 try_scrolling from unnecessarily failing when
1188 scroll-conservatively is set to a value slightly larger than the
1189 window height. Clean up the case of PT below the margin at bottom
1190 of window: scroll_max can no longer be INT_MAX. When aggressive
1191 scrolling is in use, don't let point enter the opposite scroll
1192 margin as result of the scroll.
1193 (syms_of_xdisp) <scroll-conservatively>: Document the
1194 threshold of 100 lines for never-recentering scrolling.
1196 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1198 * dispextern.h (move_it_by_lines):
1199 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1200 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1201 (message_log_check_duplicate): Remove parameters `prev_bol' and
1202 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1203 (redisplay_internal): Remove parameter `preserve_echo_area',
1204 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1206 * indent.c (Fvertical_motion):
1207 * window.c (window_scroll_pixel_based, Frecenter):
1208 Don't pass `need_y_p' to `move_it_by_lines'.
1210 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1212 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1213 steal a few bits to be more compact.
1214 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1215 Remove unneeded casts.
1217 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1219 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1221 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1222 binding" message (bug#7967).
1224 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1226 Fix more problems found by GCC 4.6.0's static checks.
1228 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1229 Remove unused local var.
1231 * editfns.c (Fmessage_box): Remove unused local var.
1233 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1234 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1235 Omit unused local vars.
1236 * window.c (shrink_windows): Omit unused local var.
1237 * menu.c (digest_single_submenu): Omit unused local var.
1238 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1239 Omit unused local var.
1241 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1242 Don't assume string length fits in int.
1243 (keyremap_step, read_key_sequence): Use size_t for sizes.
1244 (read_key_sequence): Don't check last_real_key_start redundantly.
1246 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1247 instead of alloca (Bug#8344).
1249 * eval.c (Fbacktrace): Don't assume nargs fits in int.
1250 (Fbacktrace_frame): Don't assume nframes fits in int.
1252 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1254 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1257 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1259 * cm.c (calccost): Turn while-do into do-while, for clarity.
1261 * keyboard.c (syms_of_keyboard): Use the same style as later
1262 in this function when indexing through an array. This also
1263 works around GCC bug 48267.
1265 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1267 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1269 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1270 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1272 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1273 This avoids undefined behavior on integer overflow, and is a bit
1274 more convenient anyway since it is compared to a size_t variable.
1276 Variadic C functions now count arguments with size_t, not int.
1277 This avoids an unnecessary limitation on 64-bit machines, which
1278 caused (substring ...) to crash on large vectors (Bug#8344).
1279 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1280 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
1281 All variadic functions and their callers changed accordingly.
1282 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1283 * data.c (arith_driver, float_arith_driver): Likewise.
1284 * editfns.c (general_insert_function): Likewise.
1285 * eval.c (struct backtrace.nargs, interactive_p)
1286 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1287 (funcall_lambda, mark_backtrace): Likewise.
1288 * fns.c (concat): Likewise.
1289 * frame.c (x_set_frame_parameters): Likewise.
1290 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1291 0 if not found, not -1. All callers changed.
1293 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1294 (stack_copy_size): Now size_t, not int.
1295 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1297 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1299 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1300 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1301 All callers changed.
1303 * lisp.h (multibyte_char_to_unibyte):
1304 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1305 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1306 * character.h (CHAR_TO_BYTE8):
1307 * cmds.c (internal_self_insert):
1308 * editfns.c (general_insert_function):
1309 * keymap.c (push_key_description):
1310 * search.c (Freplace_match):
1311 * xdisp.c (message_dolog, set_message_1): All callers changed.
1313 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1315 * keyboard.c (safe_run_hook_funcall): New function.
1316 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1317 don't set the hook to nil, but remove the offending function instead.
1318 (Qcommand_hook_internal): Remove, unused.
1319 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1320 Vcommand_hook_internal.
1322 * eval.c (enum run_hooks_condition): Remove.
1323 (funcall_nil, funcall_not): New functions.
1324 (run_hook_with_args): Call each function through a `funcall' argument.
1325 Remove `cond' argument, now redundant.
1326 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1327 (Frun_hook_with_args_until_failure): Adjust accordingly.
1328 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1330 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1332 * dispextern.h (string_buffer_position): Remove declaration.
1334 * print.c (strout): Remove parameter `multibyte', unused since
1335 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1337 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1338 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1339 All callers changed.
1341 * w32.c (_wsa_errlist): Use braces for struct initializers.
1343 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1344 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1345 All callers changed.
1346 (string_buffer_position): Likewise. Also, make static (it's never
1347 used outside xdisp.c).
1348 (cursor_row_p): Remove parameter `w', unused since
1349 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1350 (decode_mode_spec): Remove parameter `precision', introduced during
1351 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1352 All callers changed.
1354 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1356 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1358 2011-03-27 Anders Lindgren <andlind@gmail.com>
1360 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1361 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1362 (ns_update_auto_hide_menu_bar): New functions.
1363 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1364 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1365 ns_constrain_all_frames.
1366 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1367 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1369 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1371 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1373 2011-03-27 Glenn Morris <rgm@gnu.org>
1375 * syssignal.h: Replace RETSIGTYPE with void.
1376 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1377 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1378 Replace SIGTYPE with void everywhere.
1379 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1380 * s/template.h (SIGTYPE): Remove commented out definition.
1382 2011-03-26 Eli Zaretskii <eliz@gnu.org>
1384 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1385 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1387 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
1389 * w32.c (read_unc_volume): Use parameter `henum', instead of
1390 global variable `wget_enum_handle'.
1392 * keymap.c (describe_vector): Remove parameters `indices' and
1393 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1394 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1396 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1398 * keyboard.c (timer_check): Remove parameter `do_it_now',
1399 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1400 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1401 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1403 * keyboard.c (read_char):
1404 * w32menu.c (w32_menu_display_help):
1405 * xmenu.c (show_help_event, menu_help_callback):
1406 Adjust calls to `show_help_echo'.
1408 * gtkutil.c (xg_maybe_add_timer):
1409 * keyboard.c (readable_events):
1410 * process.c (wait_reading_process_output):
1411 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1413 * insdel.c (adjust_markers_gap_motion):
1414 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1415 (gap_left, gap_right): Don't call it.
1417 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
1419 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1420 incurred during fontification.
1422 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1424 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1425 (DEFVAR_PER_BUFFER): Don't pass it.
1427 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1428 (scrolling_window): Don't pass it.
1430 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1432 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1434 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1436 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1437 of variables specific to SELinux and computation of `encoded_absname'.
1439 * image.c (XPutPixel): Remove unused variable `height'.
1441 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1443 * unexw32.c (get_section_info): Remove unused variable `section'.
1445 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1446 (system_process_attributes): Remove unused variable `sess'.
1447 (sys_read): Remove unused variable `err'.
1449 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1450 (w32_wnd_proc): Remove unused variable `isdead'.
1451 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1452 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1453 (x_create_tip_frame): Remove unused variable `tem'.
1455 * w32inevt.c (w32_console_read_socket):
1456 Remove unused variable `no_events'.
1458 * w32term.c (x_draw_composite_glyph_string_foreground):
1459 Remove unused variable `width'.
1461 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
1463 * w32term.c (x_set_glyph_string_clipping):
1464 Don't pass uninitialized region to CombineRgn.
1466 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
1468 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1469 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1470 (Fx_close_connection): Remove unused variable `i'.
1472 * w32font.c (w32font_draw): Return number of glyphs.
1473 (w32font_open_internal): Remove unused variable `i'.
1474 (w32font_driver): Add missing initializer.
1476 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1477 (fill_in_menu): Remove unused variable `items_added'.
1479 * w32term.c (last_mouse_press_frame): Remove static global variable.
1480 (w32_clip_to_row): Remove unused variable `f'.
1481 (x_delete_terminal): Remove unused variable `i'.
1483 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1484 (NOTHING): Remove unused static global variable.
1485 (uniscribe_check_otf): Remove unused variable `table'.
1486 (uniscribe_font_driver): Add missing initializers.
1488 2011-03-23 Julien Danjou <julien@danjou.info>
1490 * term.c (Fsuspend_tty, Fresume_tty):
1491 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1492 * window.c (temp_output_buffer_show):
1493 * insdel.c (signal_before_change):
1494 * frame.c (Fhandle_switch_frame):
1495 * fileio.c (Fdo_auto_save):
1496 * emacs.c (Fkill_emacs):
1497 * editfns.c (save_excursion_restore):
1498 * cmds.c (internal_self_insert):
1499 * callint.c (Fcall_interactively):
1500 * buffer.c (Fkill_all_local_variables):
1501 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1503 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
1504 unconditionnaly since it does the check itself.
1506 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
1508 Fix more problems found by GCC 4.5.2's static checks.
1510 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1511 the first time through the loop, since we know p0 < p1 then.
1512 This also avoids a gcc -Wstrict-overflow warning.
1514 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1515 leading to a memory leak, possible in functions like
1516 load_charset_map_from_file that can allocate an unbounded number
1517 of objects (Bug#8318).
1519 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1520 that could (at least in theory) be that large.
1522 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1523 This is less likely to overflow, and avoids undefined behavior if
1524 overflow does occur. All callers changed. Use strtoul to scan
1525 for the unsigned long integer.
1526 (pint2hrstr): Simplify and tune code slightly.
1527 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
1529 * scroll.c (do_scrolling): Work around GCC bug 48228.
1530 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1532 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1533 This also avoids a warning with gcc -Wstrict-overflow.
1534 (validate_x_resource_name): Simplify count usage.
1535 This also avoids a warning with gcc -Wstrict-overflow.
1537 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1540 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
1542 * process.c (Fmake_network_process): Use socklen_t, not int,
1543 where POSIX says socklen_t is required in portable programs.
1544 This fixes a porting bug on hosts like 64-bit HP-UX, where
1545 socklen_t is wider than int (Bug#8277).
1546 (Fmake_network_process, server_accept_connection):
1547 (wait_reading_process_output, read_process_output):
1550 * process.c: Rename or move locals to avoid shadowing.
1551 (list_processes_1, Fmake_network_process):
1552 (read_process_output_error_handler, exec_sentinel_error_handler):
1553 Rename or move locals.
1554 (Fmake_network_process): Define label "retry_connect" only if needed.
1555 (Fnetwork_interface_info): Fix pointer signedness.
1556 (process_send_signal): Add cast to avoid pointer signedness problem.
1557 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
1558 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
1560 Make tparam.h and terminfo.c consistent.
1561 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1562 Include tparam.h instead, since it declares them.
1563 * cm.h (PC): Remove extern decl; tparam.h now does this.
1564 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1565 * terminfo.c: Include tparam.h, to check interfaces.
1566 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1567 (tparam): Adjust signature to match interface in tparam.h;
1568 this removes some undefined behavior. Check that outstring and len
1569 are zero, which they always are with Emacs.
1570 * tparam.h (PC, BC, UP): New extern decls.
1572 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
1573 (xftfont_open): Rename locals to avoid shadowing.
1575 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
1576 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1577 (OTF_TAG_SYM): Omit macro if not needed.
1578 (ftfont_list): Remove unused local.
1579 (get_adstyle_property, ftfont_pattern_entity):
1580 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1581 Rename locals to avoid shadowing.
1583 * xfont.c (xfont_list_family): Mark var as initialized.
1585 * xml.c (make_dom): Now static.
1587 * composite.c (composition_compute_stop_pos): Rename local to
1589 (composition_reseat_it): Remove unused locals.
1590 (find_automatic_composition, composition_adjust_point): Likewise.
1591 (composition_update_it): Mark var as initialized.
1592 (find_automatic_composition): Mark vars as initialized,
1593 with a FIXME (Bug#8290).
1595 character.h: Rename locals to avoid shadowing.
1596 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1597 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1598 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1599 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1602 * textprop.c (property_change_between_p): Remove; unused.
1604 * intervals.c (interval_start_pos): Now static.
1606 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1608 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1609 Rename locals to avoid shadowing.
1611 * sound.c (wav_play, au_play, Fplay_sound_internal):
1612 Fix pointer signedness.
1613 (alsa_choose_format): Remove unused local var.
1614 (wav_play): Initialize a variable to 0, to prevent undefined
1615 behavior (Bug#8278).
1617 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1619 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1621 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1622 clobbering (Bug#8298).
1623 * sysdep.c (sys_subshell): Likewise.
1624 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
1626 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1627 This should get cleaned up, so that child_setup has the
1628 same signature on all platforms.
1630 * callproc.c (call_process_cleanup): Now static.
1631 (relocate_fd): Rename locals to avoid shadowing.
1633 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
1635 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1636 not to be necessary, and produces flickering.
1638 2011-03-20 Glenn Morris <rgm@gnu.org>
1640 * config.in: Remove file.
1642 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
1644 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1645 are now in src/globals.h.
1646 (syms_of_minibuf): Remove spurious & from previous change.
1648 2011-03-20 Leo <sdl.web@gmail.com>
1650 * minibuf.c (completing-read-function): New variable.
1651 (completing-read-default): Rename from completing-read.
1652 (completing-read): Call completing-read-function.
1654 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
1656 * xfaces.c (Fx_load_color_file):
1657 Read color file from absolute filename (bug#8250).
1659 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
1661 * makefile.w32-in: Update dependencies.
1663 2011-03-17 Eli Zaretskii <eliz@gnu.org>
1665 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1667 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1669 Fix more problems found by GCC 4.5.2's static checks.
1671 * process.c (make_serial_process_unwind, send_process_trap):
1672 (sigchld_handler): Now static.
1674 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1675 That way, the code declares only the vars that it needs.
1676 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1677 * s/cygwin.h (PTY_ITERATION): Likewise.
1678 * s/darwin.h (PTY_ITERATION): Likewise.
1679 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1681 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1682 * process.c (allocate_pty): Don't declare stb unless it's needed.
1684 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
1685 (CONSTANTLIM): Remove; unused.
1686 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1687 Define only if needed.
1689 * unexelf.c (unexec): Name an expression,
1690 to avoid gcc -Wbad-function-cast warning.
1691 Use a different way to cause a compilation error if anyone uses
1692 n rather than nn, a way that does not involve shadowing.
1693 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
1695 * deps.mk (unexalpha.o): Remove; unused.
1697 New file unexec.h, the (simple) interface for unexec (Bug#8267).
1698 * unexec.h: New file.
1699 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1700 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1702 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1703 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1704 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
1705 Change as necessary to match prototype in unexec.h.
1707 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1709 (back_comment, skip_chars): Mark vars as initialized.
1711 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1712 Rename locals to avoid shadowing.
1714 * lread.c (read1): Rewrite so as not to use empty "else".
1715 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
1717 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1719 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1720 warning when compiling print.c.
1722 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1723 instead of using an uninitialized var.
1724 (font_sort_entities): Mark var as initialized.
1726 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1728 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1729 pointers to constants.
1730 (font_parse_fcname): Remove unused vars.
1731 (font_delete_unmatched): Now static.
1732 (font_get_spec): Remove; unused.
1733 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1734 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1735 Rename or move locals to avoid shadowing.
1737 * fns.c (require_nesting_list, require_unwind): Now static.
1738 (Ffillarray): Rename locals to avoid shadowing.
1740 * floatfns.c (domain_error2): Define only if needed.
1741 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1743 * alloc.c (mark_backtrace): Move decl from here ...
1744 * lisp.h: ... to here, so that it can be checked.
1746 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
1747 (Fdefvar): Rewrite so as not to use empty "else".
1748 (lisp_indirect_variable): Name an expression,
1749 to avoid gcc -Wbad-function-cast warning.
1750 (Fdefvar): Rename locals to avoid shadowing.
1752 * callint.c (quotify_arg, quotify_args): Now static.
1753 (Fcall_interactively): Rename locals to avoid shadowing.
1754 Use const pointer when appropriate.
1756 * lisp.h (get_system_name, get_operating_system_release):
1757 Move decls here, to check interfaces.
1758 * process.c (get_operating_system_release): Move decl to lisp.h.
1759 * xrdb.c (get_system_name): Likewise.
1760 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1761 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1762 some of which prompt warnings from gcc -Wbad-function-cast.
1763 (Fformat_time_string, Fencode_time, Finsert_char):
1764 (Ftranslate_region_internal, Fformat):
1765 Rename or remove local vars to avoid shadowing.
1766 (Ftranslate_region_internal): Mark var as initialized.
1768 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1771 * lisp.h (eassert): Check that the argument compiles, even if
1772 ENABLE_CHECKING is not defined.
1774 * data.c (Findirect_variable): Name an expression, to avoid
1775 gcc -Wbad-function-cast warning.
1776 (default_value, arithcompare, arith_driver, arith_error): Now static.
1777 (store_symval_forwarding): Rename local to avoid shadowing.
1778 (Fmake_variable_buffer_local, Fmake_local_variable):
1779 Mark variables as initialized.
1780 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
1782 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
1783 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1784 Rename locals to avoid shadowing.
1785 (mark_stack): Move local variables into the #ifdef region where
1787 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1788 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1790 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1791 (GC_STRING_CHARS): Remove; not used.
1792 (Fmemory_limit): Cast sbrk's returned value to char *.
1794 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1795 avoids undefined behavior in theory.
1797 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1799 Use functions, not macros, for up- and down-casing (Bug#8254).
1800 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1801 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1802 to use the following functions instead of these macros.
1803 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1804 EMACS_INT, since callers assume the returned value fits in int.
1805 (upcase1): Likewise, for UPCASE_TABLE.
1806 (uppercasep, lowercasep, upcase): New static inline functions.
1807 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
1808 the race-condition problem in the old DOWNCASE.
1810 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1811 Rename locals to avoid shadowing.
1812 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
1813 (regex_compile, re_search_2, re_match_2_internal):
1814 Remove unused local vars.
1815 (FREE_VAR): Rewrite so as not to use empty "else",
1816 which gcc can warn about.
1817 (regex_compile, re_match_2_internal): Mark locals as initialized.
1818 (RETALLOC_IF): Define only if needed.
1819 (WORDCHAR_P): Likewise. This one is never needed, but is used
1820 only in a comment talking about a compiler bug, so put inside
1821 the #if 0 of that comment.
1822 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1823 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1826 * search.c (boyer_moore): Rename locals to avoid shadowing.
1827 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1828 (PREV_CHAR_BOUNDARY): Likewise.
1830 * search.c (simple_search): Remove unused var.
1832 * dired.c (compile_pattern): Move decl from here ...
1833 * lisp.h: ... to here, so that it can be checked.
1834 (struct re_registers): New forward decl.
1836 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1838 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1840 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1841 Rename locals to avoid shadowing.
1842 (Fvertical_motion): Mark locals as initialized.
1844 * casefiddle.c (casify_object, casify_region): Now static.
1845 (casify_region): Mark local as initialized.
1847 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1849 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1850 New macros, so that the caller can use some names other than
1851 gcpro1, gcpro2, etc.
1852 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1854 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1855 argument, for consistency with GCPRO2_VAR, etc: it is now the
1856 prefix of the variable, not the variable itself. All uses
1858 * dired.c (directory_files_internal, file_name_completion):
1859 Rename locals to avoid shadowing.
1861 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1862 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1863 dired.c's scmp function, had undefined behavior.
1864 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1865 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1866 * buffer.h: ... to here, because these macros use current_buffer,
1867 and the new implementation with inline functions needs to have
1868 current_buffer in scope now, rather than later when the macros
1870 (downcase, upcase1): New static inline functions.
1871 (DOWNCASE, UPCASE1): Reimplement using these functions.
1872 This avoids undefined behavior in expressions like
1873 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1874 from race conditions in accessing the global variables
1875 case_temp1 and case_temp2.
1876 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1877 * lisp.h (case_temp1, case_temp2): Remove their decls.
1878 * character.h (ASCII_CHAR_P): Move from here ...
1879 * lisp.h: ... to here, so that the inline functions mentioned
1882 * dired.c (directory_files_internal_unwind): Now static.
1884 * fileio.c (file_name_as_directory, directory_file_name):
1885 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1887 (file_name_as_directory): Use const pointers when appropriate.
1888 (Fexpand_file_name): Likewise. In particular, newdir might
1889 point at constant storage, so make it a const pointer.
1890 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
1891 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1893 (Fset_file_times, Finsert_file_contents, auto_save_error):
1894 Rename locals to avoid shadowing.
1896 * minibuf.c (choose_minibuf_frame_1): Now static.
1897 (Ftry_completion, Fall_completions): Rename or remove locals
1900 * marker.c (bytepos_to_charpos): Remove; unused.
1902 * lisp.h (verify_bytepos, count_markers): New decls,
1903 so that gcc does not warn that these functions aren't declared.
1905 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1906 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
1907 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
1908 (copy_text): Remove unused local var.
1910 * filelock.c (within_one_second): Now static.
1911 (lock_file_1): Rename local to avoid shadowing.
1913 * buffer.c (fix_overlays_before): Mark locals as initialized.
1914 (fix_start_end_in_overlays): Likewise. This function should be
1915 simplified by using pointers-to-pointers, but that's a different
1917 (switch_to_buffer_1): Now static.
1918 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1919 (report_overlay_modification): Rename locals to avoid shadowing.
1921 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
1922 Fix pointer signedness issue.
1923 (sys_subshell): Mark local as volatile if checking for lint,
1924 to suppress a gcc -Wclobbered warning that does not seem to be right.
1925 (MAXPATHLEN): Define only if needed.
1927 * process.c (serial_open, serial_configure): Move decls from here ...
1928 * systty.h: ... to here, so that they can be checked.
1930 * fns.c (get_random, seed_random): Move extern decls from here ...
1931 * lisp.h: ... to here, so that they can be checked.
1933 * sysdep.c (reset_io): Now static.
1934 (wait_for_termination_signal): Remove; unused.
1936 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1937 (copy_keymap_item, append_key, push_text_char_description):
1939 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
1940 (DENSE_TABLE_SIZE): Remove; unused.
1941 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1942 (describe_map_tree):
1943 Rename locals to avoid shadowing.
1945 * keyboard.c: Declare functions static if they are not used elsewhere.
1946 (echo_char, echo_dash, cmd_error, top_level_2):
1947 (poll_for_input, handle_async_input): Now static.
1948 (read_char, kbd_buffer_get_event, make_lispy_position):
1949 (make_lispy_event, make_lispy_movement, apply_modifiers):
1950 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1951 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1952 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
1953 (read_key_sequence, read_char): Mark locals as initialized.
1954 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
1956 * keyboard.h (make_ctrl_char): New decl.
1957 (mark_kboards): Move decl here ...
1958 * alloc.c (mark_kboards): ... from here.
1960 * lisp.h (force_auto_save_soon): New decl.
1962 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
1963 (DEFINE_DUMMY_FUNCTION): New macro.
1964 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1966 (main): Add casts to avoid warnings
1967 if GCC considers string literals to be constants.
1969 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1971 * dbusbind.c: Pointer signedness fixes.
1972 (xd_signature, xd_append_arg, xd_initialize):
1973 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1974 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1975 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1976 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1978 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1979 if GCC considers string literals to be constants.
1980 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
1982 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1984 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1985 (print_preprocess, print_object): New macro to fix last change.
1987 * print.c (print_preprocess): Don't forget font objects.
1989 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
1991 * emacs.c (USAGE3): Doc fixes.
1993 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1995 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1998 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
2000 * lisp.h (VWindow_system, Qfile_name_history):
2001 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2002 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2003 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2005 * w32select.c: Don't #include "keyboard.h".
2006 (run_protected): Add extern declaration for waiting_for_input.
2008 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2009 * w32console.c (detect_input_pending, read_input_pending)
2010 (encode_terminal_code):
2011 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2012 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2013 (w32_system_caret_y, Qfile_name_history):
2014 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2015 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2016 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2017 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2018 * w32proc.c (Qlocal, report_file_error):
2019 * w32term.c (Vwindow_system, updating_frame):
2020 * w32uniscribe.c (initialized, uniscribe_font_driver):
2021 Remove unneeded extern declarations.
2023 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
2025 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2027 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
2029 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2030 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2031 These macros can no longer be used for assignment.
2033 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2034 Assign struct members directly, instead of using BUF_BEGV etc.
2035 (record_buffer_markers, fetch_buffer_markers): New functions for
2036 recording and fetching special buffer markers.
2037 (set_buffer_internal_1, set_buffer_temp): Use them.
2039 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2041 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2043 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2044 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2046 * xdisp.c (hscroll_window_tree):
2047 (reconsider_clip_changes): Use PT instead of BUF_PT.
2049 2011-03-13 Eli Zaretskii <eliz@gnu.org>
2051 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2052 $(EMACS_ROOT)/lib/intprops.h.
2054 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2056 Fix more problems found by GCC 4.5.2's static checks.
2058 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2059 to unsigned char * to avoid compiler diagnostic.
2060 (xg_free_frame_widgets): Make it clear that a local variable is
2061 needed only if USE_GTK_TOOLTIP.
2062 (gdk_window_get_screen): Make it clear that this macro is needed
2063 only if USE_GTK_TOOLTIP.
2064 (int_gtk_range_get_value): New function, which avoids a diagnostic
2065 from gcc -Wbad-function-cast.
2066 (xg_set_toolkit_scroll_bar_thumb): Use it.
2067 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2068 diagnostic from gcc -Wbad-function-cast.
2069 (get_utf8_string, xg_get_file_with_chooser):
2070 Rename locals to avoid shadowing.
2071 (create_dialog): Move locals to avoid shadowing.
2073 * xgselect.c (xg_select): Remove unused var.
2075 * image.c (four_corners_best): Mark locals as initialized.
2076 (gif_load): Initialize transparent_p to zero (Bug#8238).
2077 Mark another local as initialized.
2078 (my_png_error, my_error_exit): Mark with NO_RETURN.
2080 * image.c (clear_image_cache): Now static.
2081 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
2082 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
2083 (x_edge_detection): Remove unnecessary cast that
2084 gcc -Wbad-function-cast diagnoses.
2085 (gif_load): Fix pointer signedness.
2086 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2087 (jpeg_load, gif_load): Rename locals to avoid shadowing.
2089 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
2091 Improve quality of tests for time stamp overflow.
2092 For example, without this patch (encode-time 0 0 0 1 1
2093 1152921504606846976) returns the obviously-bogus value (-948597
2094 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2095 reports time overflow. See
2096 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
2097 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2098 * editfns.c: Include limits.h and intprops.h.
2099 (TIME_T_MIN, TIME_T_MAX): New macros.
2100 (time_overflow): Move earlier, to before first use.
2101 (hi_time, lo_time): New functions, for an accurate test for
2103 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2104 (Fget_internal_run_time): Don't assume time_t fits in int.
2105 (make_time): Use list2 instead of Fcons twice.
2106 (Fdecode_time): More accurate test for out-of-range times.
2107 (check_tm_member): New function.
2108 (Fencode_time): Use it, to test for out-of-range times.
2109 (lisp_time_argument): Don't rely on undefined left-shift and
2110 right-shift behavior when checking for time stamp overflow.
2112 * editfns.c (time_overflow): New function, refactoring common code.
2113 (Fformat_time_string, Fdecode_time, Fencode_time):
2114 (Fcurrent_time_string): Use it.
2116 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2117 * dired.c (make_time): Move to ...
2118 * editfns.c (make_time): ... here.
2119 * systime.h: Note the move.
2121 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2123 * fringe.c (update_window_fringes): Remove unused variables.
2125 * unexmacosx.c (copy_data_segment): Also copy __got section.
2128 2011-03-12 Eli Zaretskii <eliz@gnu.org>
2130 * termcap.c [MSDOS]: Include "msdos.h".
2131 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2132 Constify `char *' arguments and their references according to
2133 prototypes in tparam.h.
2135 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
2137 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2138 Adapt all references accordingly.
2140 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2142 2011-03-11 Tom Tromey <tromey@redhat.com>
2144 * buffer.c (syms_of_buffer): Remove obsolete comment.
2146 2011-03-11 Eli Zaretskii <eliz@gnu.org>
2148 * termhooks.h (encode_terminal_code): Declare prototype.
2150 * msdos.c (encode_terminal_code): Don't declare prototype.
2152 * term.c (encode_terminal_code): Now external again, used by
2153 w32console.c and msdos.c.
2155 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2156 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
2158 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
2160 Fix some minor problems found by GCC 4.5.2's static checks.
2162 * fringe.c (update_window_fringes): Mark locals as initialized
2164 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
2166 * alloc.c (mark_fringe_data): Move decl from here ...
2167 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2168 to check its interface.
2169 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2171 * fontset.c (free_realized_fontset): Now static.
2172 (Fset_fontset_font): Rename local to avoid shadowing.
2173 (fontset_font): Mark local as initialized.
2174 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
2176 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2178 * xselect.c (x_disown_buffer_selections): Remove; not used.
2179 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
2180 (x_own_selection, Fx_disown_selection_internal): Rename locals
2182 (x_handle_dnd_message): Remove local to avoid shadowing.
2184 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2185 so that the caller can use some name other than gcpro1.
2186 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
2187 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2188 (Fx_backspace_delete_keys_p):
2189 Use them to avoid shadowing, and rename vars to avoid shadowing.
2190 (x_decode_color, x_set_name, x_window): Now static.
2191 (Fx_create_frame): Add braces to silence GCC warning.
2192 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
2193 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2194 Remove unused locals.
2195 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2196 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2197 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2200 * xterm.h (x_mouse_leave): New decl.
2202 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2203 Remove unused functions.
2204 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2205 (x_calc_absolute_position): Now static.
2206 (XTread_socket): Don't define label "out" unless it's used.
2207 Don't declare local "event" unless it's used.
2208 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2209 unless they are used.
2210 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2211 (x_fatal_error_signal): Remove; not used.
2212 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2213 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2214 (x_error_catcher, x_connection_closed, x_error_handler):
2215 (x_error_quitter, xembed_send_message, x_iconify_frame):
2216 (my_log_handler): Rename locals to avoid shadowing.
2217 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2218 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
2220 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2221 Rename or move locals to avoid shadowing.
2222 (tty_defined_color, merge_face_heights): Now static.
2223 (free_realized_faces_for_fontset): Remove; not used.
2224 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2225 does not deduce is never used uninitialized.
2226 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2227 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
2229 * terminal.c (store_terminal_param): Now static.
2231 * xmenu.c (menu_highlight_callback): Now static.
2232 (set_frame_menubar): Remove unused local.
2233 (xmenu_show): Rename parameter to avoid shadowing.
2234 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2235 since they might point to immutable storage.
2236 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2237 since it's unused otherwise.
2239 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
2240 Add a FIXME, since the code still doesn't look right. (Bug#8215)
2241 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2242 avoids a gcc -Wuninitialized diagnostic.
2243 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
2244 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2245 does not deduce are never used uninitialized.
2247 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2249 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
2250 * window.c (window_loop, size_window):
2251 (run_window_configuration_change_hook, enlarge_window): Likewise.
2253 * window.c (display_buffer): Now static.
2254 (size_window): Mark variables that gcc -Wuninitialized
2255 does not deduce are never used uninitialized.
2256 * window.h (check_all_windows): New decl, to forestall
2257 gcc -Wmissing-prototypes diagnostic.
2258 * dispextern.h (bidi_dump_cached_states): Likewise.
2260 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2262 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
2264 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2265 and to avoid gcc -Wuninitialized warning.
2266 (load_charset_map): Mark variables that gcc -Wuninitialized
2267 does not deduce are never used uninitialized.
2268 (load_charset): Abort instead of using uninitialized var (Bug#8229).
2270 * coding.c (coding_set_source, coding_set_destination):
2271 Use "else { /* comment */ }" rather than "else /* comment */;"
2272 for clarity, and to avoid gcc -Wempty-body warning.
2273 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2274 a block, when the outer 'i' will do.
2275 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2276 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2277 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2278 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2279 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2280 Rename locals to avoid shadowing.
2281 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
2282 * coding.c (emacs_mule_char, encode_invocation_designation):
2283 Now static, since they're not used elsewhere.
2284 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
2285 (decode_coding_object, encode_coding_object, detect_coding_system):
2286 (decode_coding_emacs_mule): Mark variables that gcc
2287 -Wuninitialized does not deduce are never used uninitialized.
2288 (detect_coding_iso_2022): Initialize a local variable that might
2289 be used uninitialized. Leave a FIXME because it's not clear that
2290 this initialization is needed. (Bug#8211)
2291 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2292 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2293 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2294 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2295 Remove unused macros.
2297 * category.c (hash_get_category_set): Remove unused local var.
2298 (copy_category_table): Now static, since it's not used elsewhere.
2299 * character.c (string_count_byte8): Likewise.
2301 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2302 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2304 * chartab.c (copy_sub_char_table): Now static, since it's not used
2306 (sub_char_table_ref_and_range, char_table_ref_and_range):
2307 Rename locals to avoid shadowing.
2308 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
2310 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
2311 (BIDI_BOB): Remove unused macro.
2313 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2314 deduce are never used uninitialized.
2315 * term.c (encode_terminal_code): Likewise.
2317 * term.c (encode_terminal_code): Now static. Remove unused local.
2319 * tparam.h: New file.
2320 * term.c, tparam.h: Include it.
2321 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2322 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2323 Move these decls to tparam.h, and make them agree with what
2324 is actually in tparam.c. The previous trick of using incompatible
2325 decls in different modules does not conform to the C standard.
2326 All callers of tparam changed to use tparam's actual API.
2327 * tparam.c (tparam1, tparam, tgoto):
2328 Use const pointers where appropriate.
2330 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2331 * cm.h (struct cm): Likewise.
2332 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2333 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2334 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2335 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2336 (turn_on_face, init_tty): Likewise.
2337 * termchar.h (struct tty_display_info): Likewise.
2339 * term.c (term_mouse_position): Rename local to avoid shadowing.
2341 * alloc.c (mark_ttys): Move decl from here ...
2342 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2344 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2346 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2348 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
2350 * search.c (compile_pattern_1): Remove argument regp, unused since
2351 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2352 (compile_pattern): Don't pass it.
2354 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2356 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2357 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2359 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2361 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2363 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2364 gdk_window_get_screen, gdk_window_get_geometry,
2365 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2366 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2367 (xg_get_pixbuf_from_pixmap): New function.
2368 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2369 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2370 Call xg_get_pixbuf_from_pixmap instead of
2371 gdk_pixbuf_get_from_drawable.
2372 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2373 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2374 (xg_check_special_colors): Use GtkStyleContext and its functions
2376 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2377 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2378 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
2379 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2380 Call gtk_widget_get_preferred_size.
2381 (xg_frame_resized): gdk_window_get_geometry only takes 5
2383 (xg_win_to_widget, xg_event_is_for_menubar):
2384 Call gdk_x11_window_lookup_for_display.
2385 (xg_set_widget_bg): New function.
2386 (delete_cb): New function.
2387 (xg_create_frame_widgets): connect delete-event to delete_cb.
2388 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2389 (xg_set_background_color): Call xg_set_widget_bg.
2390 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2391 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2392 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2393 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2395 (update_frame_tool_bar): Call gtk_widget_hide.
2396 (xg_initialize): Use GDK_KEY_g.
2398 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2400 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2402 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2403 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2404 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2406 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
2408 * w32xfns.c (select_palette): Check success of RealizePalette against
2409 GDI_ERROR, not zero.
2411 See ChangeLog.11 for earlier changes.
2417 Copyright (C) 2011 Free Software Foundation, Inc.
2419 This file is part of GNU Emacs.
2421 GNU Emacs is free software: you can redistribute it and/or modify
2422 it under the terms of the GNU General Public License as published by
2423 the Free Software Foundation, either version 3 of the License, or
2424 (at your option) any later version.
2426 GNU Emacs is distributed in the hope that it will be useful,
2427 but WITHOUT ANY WARRANTY; without even the implied warranty of
2428 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2429 GNU General Public License for more details.
2431 You should have received a copy of the GNU General Public License
2432 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.