* xgselect.c (xg_select): Check for size calculation overflow.
[bpt/emacs.git] / src / ChangeLog
1 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
2
3 * xgselect.c (xg_select): Check for size calculation overflow.
4 Don't update size until alloc done.
5
6 * xfns.c: Integer and memory overflow fixes.
7 (x_encode_text, x_set_name_internal, Fx_change_window_property):
8 Use ptrdiff_t, not int, to count sizes, since they can exceed
9 INT_MAX in size. Check for size calculation overflow.
10
11 * xfaces.c: Integer and memory overflow fixes.
12 (Finternal_make_lisp_face): Use ptrdiff_t, not int, for sizes.
13 Check for size calculation overflow.
14 (cache_face): Do not overflow in size calculation.
15
16 * xdisp.c: Integer and memory overflow fixes.
17 (store_mode_line_noprop_char, x_consider_frame_title):
18 Use ptrdiff_t, not int, for sizes.
19 (store_mode_line_noprop_char): Don't update size until alloc done.
20
21 * tparam.c: Integer and memory overflow fixes.
22 (tparam1): Use ptrdiff_t, not int, for sizes.
23 Don't update size until alloc done.
24 Redo size calculations to avoid overflow.
25 Check for size calculation overflow.
26
27 * termcap.c: Integer and memory overflow issues.
28 (tgetent): Use ptrdiff_t, not int, to record results of
29 subtracting pointers.
30 (gobble_line): Check for overflow more carefully. Don't update size
31 until alloc done.
32
33 * term.c: Integer and memory overflow issues.
34 (max_frame_lines): Remove; unused.
35 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
36 not int.
37 (encode_terminal_code, calculate_costs): Check for size
38 calculation overflow.
39 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
40 table lengths and related sizes. Don't update size until alloc
41 done. Redo calculations to avoid overflow.
42 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
43
44 * sysdep.c: Integer and memory overflow issues.
45 (system_process_attributes): Use ptrdiff_t, not int, for command
46 line length. Do not attempt to address one before the beginning
47 of an array, as that's not portable.
48
49 * search.c: Integer and memory overflow fixes.
50 (Freplace_match): Check for size calculation overflow.
51 (Fset_match_data): Don't assume list lengths fit in 'int'.
52
53 * scroll.c: Integer and memory overflow fixes.
54 (do_line_insertion_deletion_costs): Check for size calculation overflow.
55 Don't bother calling xmalloc when xrealloc will do.
56
57 * region-cache.c (move_cache_gap): Check for size calculation overflow.
58
59 * process.c (Fnetwork_interface_list): Check for overflow
60 in size calculation.
61
62 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
63 Now ptrdiff_t, not int.
64 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
65 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
66
67 * minibuf.c (read_minibuf_noninteractive): Don't leak memory
68 on memory overflow.
69
70 * macros.c: Integer and memory overflow fixes.
71 (Fstart_kbd_macro): Don't update size until alloc done.
72 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
73
74 * lread.c (read1, init_obarray): Don't update size until alloc done.
75
76 * keymap.c: Integer overflow fixes.
77 (cmm_size, current_minor_maps): Use ptrdiff_t, not int, to count maps.
78 (current_minor_maps): Check for size calculation overflow.
79 * keymap.h: Change prototypes to match the above.
80
81 * keyboard.c: Integer and memory overflow fixes.
82 (read_char, menu_bar_items, tool_bar_items, read_char_x_menu_prompt)
83 (read_char_minibuf_menu_width, read_char_minibuf_menu_prompt)
84 (follow_key, read_key_sequence): Use ptrdiff_t, not int, to count maps.
85 (read_char_minibuf_menu_prompt): Check for overflow in size
86 calculations. Don't update size until allocation succeeds. Redo
87 calculations to avoid overflow.
88 * keyboard.h: Change prototypes to match the above.
89
90 * image.c: Integer and memory overflow fixes.
91 (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these are duplicate
92 now that they've been promoted to lisp.h.
93 (x_allocate_bitmap_record, x_alloc_image_color)
94 (make_image_cache, cache_image, xpm_load):
95 Don't update size until alloc is done.
96 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
97 (x_detect_edges):
98 Check for size calculation overflow.
99 (ct_colors_allocated_max): New constant.
100 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
101 overflow.
102
103 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
104
105 * gtkutil.c: Integer overflow fixes.
106 (get_utf8_string, xg_store_widget_in_map):
107 Check for size-calculation overflow.
108 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
109 do, as we prefer signed integers.
110 (id_to_widget.max_size, id_to_widget.used)
111 (xg_store_widget_in_map, xg_remove_widget_from_map)
112 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
113 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
114 Use and return ptrdiff_t, not int.
115 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
116 * gtkutil.h: Change prototypes to match the above.
117
118 * ftfont.c: Check for size overflow.
119 (ftfont_get_open_type_spec, setup_otf_gstring, ftfont_shape_by_flt):
120 Check for integer overflow in size calculations.
121
122 * fringe.c (Fdefine_fringe_bitmap): Don't update size until alloc works.
123
124 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
125 This is for the members text_lines, text_cols, total_lines, total_cols,
126 where the system imposes an 'int' limit.
127
128 * frame.c: Integer overflow fixes.
129 (set_menu_bar_lines, x_set_frame_parameters, x_set_scroll_bar_width)
130 (x_figure_window_size): Check for integer overflow.
131 (x_set_alpha): Do not assume XINT fits in int.
132
133 * eval.c: Integer and memory overflow fixes.
134 (init_eval_once, grow_specpdl): Don't update size until alloc succeeds.
135 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
136
137 * emacs.c (main, sort_args): Check for size-calculation overflow.
138
139 * editfns.c: Integer and memory overflow fixes.
140 (set_time_zone_rule): Don't assume environment length fits in int.
141 (message_length): Now ptrdiff_t, not int.
142 (Fmessage_box): Don't update size until allocation succeeds.
143 Don't assume message length fits in int.
144 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
145
146 * doc.c: Integer and memory overflow fixes.
147 (get_doc_string_buffer_size): Now ptrdiff_t, not int.
148 (get_doc_string): Check for size calculation overflow.
149 Don't update size until allocation succeeds.
150 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
151 EMACS_INT, where ptrdiff_t will do.
152 (Fsubstitute_command_keys): Check for string overflow.
153
154 Integer and memory overflow fixes for display code.
155 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
156 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool, scrolling_window):
157 Check for overflow in size calculations.
158 (line_draw_cost, realloc_glyph_pool, add_row_entry):
159 Don't assume glyph table len fits in int.
160 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
161 (row_table_size): Now ptrdiff_t, not int.
162 (scrolling_window): Avoid overflow in size calculations.
163 Don't update size until allocation succeeds.
164 * fns.c (concat): Check for overflow in size calculations.
165 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
166 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
167 (NEXT_ALMOST_PRIME_LIMIT): New constant.
168
169 * composite.c: Integer overflow fixes.
170 (get_composition_id): Check for overflow in glyph length calculations.
171
172 * coding.c: Integer and memory overflow fixes.
173 (produce_chars): Redo buffer-overflow calculations to avoid
174 unnecessary integer overflow. Check for size overflow.
175 (encode_coding_object): Don't update size until xmalloc succeeds.
176
177 * character.c (Fstring): Check for size-calculation overflow.
178
179 * ccl.c: Integer and memory overflow fixes.
180 (Fccl_execute_on_string): Check for memory overflow.
181 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
182 Redo buffer-overflow calculations to avoid integer overflow.
183
184 * callproc.c (child_setup): Don't assume strlen fits in int.
185
186 * buffer.c: Memory overflow fixes.
187 (overlays_at, overlays_in, record_overlay_string, overlay_strings):
188 Don't update size of array until after memory allocation succeeds,
189 because xmalloc/xrealloc may not return.
190
191 * bidi.c: Integer overflow fix.
192 (bidi_shelve_header_size): New constant.
193 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
194 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
195
196 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
197
198 Use ptrdiff_t for composition IDs.
199 * character.c (lisp_string_width):
200 * composite.c (composition_table_size, n_compositions)
201 (get_composition_id, composition_gstring_from_id):
202 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
203 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
204 * window.c (Frecenter):
205 Use ptrdiff_t, not int, for composition IDs.
206 * composite.c (get_composition_id): Check for integer overflow.
207 * composite.h: Adjust prototypes to match the above changes.
208
209 Use ptrdiff_t for hash table indexes.
210 * category.c (hash_get_category_set):
211 * ccl.c (ccl_driver):
212 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
213 * coding.c (coding_system_charset_list, detect_coding_system):
214 * coding.h (struct coding_system.id):
215 * composite.c (get_composition_id, gstring_lookup_cache):
216 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
217 * image.c (xpm_get_color_table_h):
218 * lisp.h (hash_lookup, hash_put):
219 * minibuf.c (Ftest_completion):
220 Use ptrdiff_t for hash table indexes, not int (which is too
221 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
222 32-bit --with-wide-int hosts).
223
224 * charset.c (Fdefine_charset_internal): Check for integer overflow.
225 Add a FIXME comment about memory leaks.
226 (syms_of_charset): Don't assume xmalloc returns.
227
228 Don't assume that stated character widths fit in int.
229 * character.c (Fchar_width, c_string_width, lisp_string_width):
230 * character.h (CHAR_WIDTH):
231 * indent.c (MULTIBYTE_BYTES_WIDTH):
232 Use sanitize_char_width to avoid undefined and/or bad behavior
233 with outlandish widths.
234 * character.h (sanitize_tab_width): Renamed from sanitize_width,
235 now that we have two such functions. All uses changed.
236 (sanitize_char_width): New inline function.
237
238 Don't assume that tab-width fits in int.
239 * character.h (sanitize_width): New inline function.
240 (SANE_TAB_WIDTH): New macro.
241 (ASCII_CHAR_WIDTH): Use it.
242 * indent.c (sane_tab_width): Remove. All uses replaced by
243 SANE_TAB_WIDTH (current_buffer).
244 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
245
246 * fileio.c: Integer overflow issues with file modes.
247 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
248
249 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
250 Remove unreachable code.
251 (read_hex, load_charset_map_from_file): Check for integer overflow.
252
253 * xterm.c: don't go over XClientMessageEvent limit
254 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
255 (x_send_scroll_bar_event): Likewise. Check that the size does not
256 exceed limits imposed by XClientMessageEvent, as well as the usual
257 ptrdiff_t and size_t limits.
258
259 * keyboard.c: Overflow, signedness and related fixes.
260 (make_lispy_movement): Use same integer type in forward decl
261 that is used in the definition.
262 (read_key_sequence, keyremap_step):
263 Change bufsize argument back to int, undoing my 2011-03-30 change.
264 We prefer signed types, and int is wide enough here.
265 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
266 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
267 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
268 length, not size_t. Use ptrdiff_t for index, not int.
269 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
270 possibility of integer overflow.
271
272 Overflow, signedness and related fixes for images.
273
274 * dispextern.h (struct it.stack[0].u.image.image_id)
275 (struct_it.image_id, struct image.id, struct image_cache.size)
276 (struct image_cache.used, struct image_cache.ref_count):
277 * gtkutil.c (update_frame_tool_bar):
278 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
279 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
280 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
281 * nsmenu.m (update_frame_tool_bar):
282 * xdisp.c (calc_pixel_width_or_height):
283 * xfns.c (image_cache_refcount):
284 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
285 on typical 64-bit hosts.
286
287 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
288 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
289 Omit unnecessary casts to int.
290 (parse_image_spec): Check that integers fall into 'int' range
291 when the callers expect that.
292 (image_ascent): Redo ascent calculation to avoid int overflow.
293 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
294 (lookup_image): Remove unnecessary tests.
295 (xbm_image_p): Locals are now of int, not EMACS_INT,
296 since parse_image_check makes sure they fit into int.
297 (png_load, gif_load, svg_load_image):
298 Prefer int to unsigned where either will do.
299 (tiff_handler): New function, combining the cores of the
300 old tiff_error_handler and tiff_warning_handler. This
301 function is rewritten to use vsnprintf and thereby avoid
302 stack buffer overflows. It uses only the features of vsnprintf
303 that are common to both POSIX and native Microsoft.
304 (tiff_error_handler, tiff_warning_handler): Use it.
305 (tiff_load, gif_load, imagemagick_load_image):
306 Don't assume :index value fits in 'int'.
307 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
308 (imagemagick_load_image): Check that crop parameters fit into
309 the integer types that MagickCropImage accepts. Don't assume
310 Vimagemagick_render_type has a nonnegative value. Don't assume
311 size_t fits in 'long'.
312 (gs_load): Use printmax_t to print the widest integers possible.
313 Check for integer overflow when computing image height and width.
314
315 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
316
317 Integer signedness and overflow and related fixes. (Bug#9079)
318
319 * bidi.c: Integer size and overflow fixes.
320 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
321 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
322 (bidi_cache_find_level_change, bidi_cache_ensure_space)
323 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
324 (bidi_find_other_level_edge):
325 Use ptrdiff_t instead of EMACS_INT where either will do.
326 This works better on 32-bit hosts configured --with-wide-int.
327 (bidi_cache_ensure_space): Check for size-calculation overflow.
328 Use % rather than repeated addition, for better worst-case speed.
329 Don't set bidi_cache_size until after xrealloc returns, because it
330 might not return.
331 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
332 (bidi_cache_ensure_space): Also check that the bidi cache size
333 does not exceed that of the largest Lisp string or buffer. See Eli
334 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
335
336 * alloc.c (__malloc_size_t): Remove.
337 All uses replaced by size_t. See Andreas Schwab's note
338 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
339
340 * image.c: Improve checking for integer overflow.
341 (check_image_size): Assume that f is nonnull, since
342 it is always nonnull in practice. This is one less thing to
343 worry about when checking for integer overflow later.
344 (x_check_image_size): New function, which checks for integer
345 overflow issues inside X.
346 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
347 This removes the need for a memory_full check.
348 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
349 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
350 (xbm_read_bitmap_data): Change locals back to 'int', since
351 their values must fit in 'int'.
352 (xpm_load_image, png_load, tiff_load):
353 Invoke x_create_x_image_and_pixmap earlier,
354 to avoid much needless work if the image is too large.
355 (tiff_load): Treat overly large images as if
356 x_create_x_image_and_pixmap failed, not as malloc failures.
357 (gs_load): Use x_check_image_size.
358
359 * gtkutil.c: Omit integer casts.
360 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
361 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
362
363 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
364
365 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
366 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
367 would wrongly return t on a 64-bit host.
368
369 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
370 The plain *_OVERFLOW macros run afoul of GCC bug 49705
371 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
372 and therefore cause GCC to emit a bogus diagnostic in some cases.
373
374 * image.c: Integer signedness and overflow and related fixes.
375 This is not an exhaustive set of fixes, but it's time to
376 record what I've got.
377 (lookup_pixel_color, check_image_size): Remove redundant decls.
378 (check_image_size): Don't assume that arbitrary EMACS_INT values
379 fit in 'int', or that arbitrary 'double' values fit in 'int'.
380 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
381 (tiff_load, imagemagick_load_image):
382 Check for overflow in size calculations.
383 (x_create_x_image_and_pixmap): Remove unnecessary test for
384 xmalloc returning NULL; that can't happen.
385 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
386 (xpm_color_bucket): Use better integer hashing function.
387 (xpm_cache_color): Don't possibly over-allocate memory.
388 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
389 (gif_memory_source):
390 Use ptrdiff_t, not int or size_t, to record sizes.
391 (png_load): Don't assume values greater than 2**31 fit in 'int'.
392 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
393 either works, as we prefer signed integers.
394 (tiff_read_from_memory, tiff_write_from_memory):
395 Return tsize_t, not size_t, since that's what the TIFF API wants.
396 (tiff_read_from_memory): Don't fail simply because the read would
397 go past EOF; instead, return a short read.
398 (tiff_load): Omit no-longer-needed casts.
399 (Fimagemagick_types): Don't assume size fits into 'int'.
400
401 Improve hashing quality when configured --with-wide-int.
402 * fns.c (hash_string): New function, taken from sxhash_string.
403 Do not discard information about ASCII character case; this
404 discarding is no longer needed.
405 (sxhash-string): Use it. Change sig to match it. Caller changed.
406 * lisp.h: Declare it.
407 * lread.c (hash_string): Remove, since we now use fns.c's version.
408 The fns.c version returns a wider integer if --with-wide-int is
409 specified, so this should help the quality of the hashing a bit.
410
411 * emacs.c: Integer overflow minor fix.
412 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
413 Define only if GNU_LINUX.
414 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
415
416 * dispnew.c: Integer signedness and overflow fixes.
417 Remove unnecessary forward decls, that were a maintenance hassle.
418 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
419 All uses changed.
420 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
421 (scrolling_window): Use ptrdiff_t, not int, for byte count.
422 (prepare_desired_row, line_draw_cost):
423 Use int, not unsigned, where either works.
424 (save_current_matrix, restore_current_matrix):
425 Use ptrdiff_t, not size_t, where either works.
426 (init_display): Check for overflow more accurately, and without
427 relying on undefined behavior.
428
429 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
430 Remove, replacing with the new symbols in lisp.h. All uses changed.
431 * fileio.c (make_temp_name):
432 * filelock.c (lock_file_1, lock_file):
433 * xdisp.c (message_dolog):
434 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
435 Use pMd etc. instead.
436 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
437 replacing the pWIDE etc. symbols removed from editfns.c.
438
439 * keyboard.h (num_input_events): Now uintmax_t.
440 This is (very slightly) less likely to mess up due to wraparound.
441 All uses changed.
442
443 * buffer.c: Integer signedness fixes.
444 (alloc_buffer_text, enlarge_buffer_text):
445 Use ptrdiff_t rather than size_t when either will do, as we prefer
446 signed integers.
447
448 * alloc.c: Integer signedness and overflow fixes.
449 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
450 (__malloc_size_t): Default to size_t, not to int.
451 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
452 (Fgarbage_collect, mark_object_loop_halt, mark_object):
453 Prefer ptrdiff_t to size_t when either would do, as we prefer
454 signed integers.
455 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
456 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
457 Now const. Initialize with values that are in range even if char
458 is signed.
459 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
460 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
461 These functions do the right thing with sizes > 2**32.
462 (check_depth): Now ptrdiff_t, not int.
463 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
464 Adjust to new way of storing sizes. Check for size overflow bugs
465 in rest of code.
466 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
467 slightly wrong anyway, as it missed one instance of
468 XMALLOC_OVERRUN_CHECK_OVERHEAD.
469 (refill_memory_reserve): Omit needless cast to size_t.
470 (mark_object_loop_halt): Mark as externally visible.
471
472 * xselect.c: Integer signedness and overflow fixes.
473 (Fx_register_dnd_atom, x_handle_dnd_message):
474 Use ptrdiff_t, not size_t, since we prefer signed.
475 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
476 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
477 x_dnd_atoms_size and x_dnd_atoms_length.
478
479 * doprnt.c: Prefer signed to unsigned when either works.
480 * eval.c (verror):
481 * doprnt.c (doprnt):
482 * lisp.h (doprnt):
483 * xdisp.c (vmessage):
484 Use ptrdiff_t, not size_t, when using or implementing doprnt,
485 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
486 prefer signed arithmetic to avoid comparison confusion.
487 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
488 but is a bit tricky.
489
490 Assume freestanding C89 headers, string.h, stdlib.h.
491 * data.c, doprnt.c, floatfns.c, print.c:
492 Include float.h unconditionally.
493 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
494 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
495 * regex.c: Likewise for stddef.h, string.h.
496 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
497 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
498 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
499 (STDC_HEADERS): Remove obsolete defines.
500 * sysdep.c: Include limits.h unconditionally.
501
502 Assume support for memcmp, memcpy, memmove, memset.
503 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
504 * regex.c (memcmp, memcpy):
505 Remove; we assume C89 now.
506
507 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
508 (__malloc_safe_bcopy): Remove; no longer needed.
509
510 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
511 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
512 well either way, and we prefer signed to unsigned.
513
514 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
515
516 Port to OpenBSD.
517 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
518 and the surrounding thread.
519 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
520 rather than fgets, and retry after EINTR. Otherwise, 'emacs
521 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
522 timer goes off.
523 * s/openbsd.h (BROKEN_SIGIO): Define.
524 * unexelf.c (unexec) [__OpenBSD__]:
525 Don't update the .mdebug section of the Alpha COFF symbol table.
526
527 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
528
529 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
530 (bug#8460).
531
532 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
533
534 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
535 This fixes some race conditions on the permissions of any newly
536 created file.
537
538 * alloc.c (valid_pointer_p): Use pipe, not open.
539 This fixes some permissions issues when debugging.
540
541 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
542 If fchown fails to set both uid and gid, try to set just gid,
543 as that is sometimes allowed. Adjust the file's mode to eliminate
544 setuid or setgid bits that are inappropriate if fchown fails.
545
546 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
547
548 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
549 to compare Lisp_Objects.
550 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
551 global_gnutls_log_level, don't mistake it for a Lisp_Object.
552 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
553
554 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
555
556 * lread.c (read_integer): Unread even EOF character.
557 (read1): Likewise. Properly record start position of symbol.
558
559 * lread.c (read1): Read `#:' as empty uninterned symbol if no
560 symbol character follows.
561
562 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
563
564 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
565 This works around a problem with the previous change to Fcopy_file.
566 Recent glibc declares fchown with __attribute__((warn_unused_result)),
567 and without this change, GCC might complain about discarding
568 fchown's return value.
569
570 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
571
572 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
573
574 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
575
576 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
577
578 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
579
580 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
581 it's used from the C level.
582
583 * process.c: Use the same condition for POLL_FOR_INPUT in both
584 keyboard.c and process.c (bug#1858).
585
586 2011-07-09 Lawrence Mitchell <wence@gmx.li>
587
588 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
589 (Fgnutls_boot): Use it.
590
591 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
592
593 * doc.c (Fsubstitute_command_keys): Revert last change.
594
595 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
596
597 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
598 quotes the next character, and doesn't affect other longer
599 sequences (bug#8935).
600
601 * lread.c (syms_of_lread): Clarify that is isn't only
602 `eval-buffer' and `eval-defun' that's affected by
603 `lexical-binding' (bug#8460).
604
605 2011-07-15 Eli Zaretskii <eliz@gnu.org>
606
607 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
608 bidi redisplay when a line includes both an image and is
609 truncated.
610
611 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
612
613 Fix minor problems found by static checking.
614 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
615 (elsz): Now a signed constant, not a size_t var. We prefer signed
616 types to unsigned, to avoid integer comparison confusion. Without
617 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
618 "cannot optimize loop, the loop counter may overflow", a symptom
619 of the confusion.
620 * indent.c (Fvertical_motion): Mark locals as initialized.
621 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
622
623 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
624
625 * search.c (Fre_search_backward): Mention `case-fold-search' in
626 all the re_search_* functions (bug#8138).
627
628 * keyboard.c (Fopen_dribble_file): Document when the file is
629 closed (bug#8056).
630
631 2011-07-14 Eli Zaretskii <eliz@gnu.org>
632
633 * bidi.c (bidi_dump_cached_states): Fix format of displaying
634 bidi_cache_idx.
635
636 Support bidi reordering of display and overlay strings.
637 * xdisp.c (compute_display_string_pos)
638 (compute_display_string_end): Accept additional argument STRING.
639 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
640 (reseat_to_string): Initialize bidi_it->string.s and
641 bidi_it->string.schars.
642 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
643 NULL (avoids a crash in bidi_paragraph_init). Initialize
644 itb.string.lstring.
645 (init_iterator): Call bidi_init_it only of a valid
646 buffer position was specified. Initialize paragraph_embedding to
647 L2R.
648 (reseat_to_string): Initialize the bidi iterator.
649 (display_string): If we need to ignore text properties of
650 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
651 original value of -1 will not work with bidi.)
652 (compute_display_string_pos): First arg is now struct
653 `text_pos *'; all callers changed. Support display properties on
654 Lisp strings.
655 (compute_display_string_end): Support display properties on Lisp
656 strings.
657 (init_iterator, reseat_1, reseat_to_string): Initialize the
658 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
659 when iterating on a string not from display properties).
660 (compute_display_string_pos, compute_display_string_end): Fix
661 calculation of the object to scan. Fixes an error when using
662 arrow keys.
663 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
664 base_level_stop; instead, set base_level_stop to BEGV. Fixes
665 crashes in vertical-motion.
666 (next_element_from_buffer): Improve commentary for when
667 the iterator is before prev_stop.
668 (init_iterator): Initialize bidi_p from the default value of
669 bidi-display-reordering, not from buffer-local value. Use the
670 buffer-local value only if initializing for buffer iteration.
671 (handle_invisible_prop): Support invisible properties on strings
672 that are being bidi-reordered.
673 (set_iterator_to_next): Support bidi reordering of C strings and
674 Lisp strings.
675 (next_element_from_string): Support bidi reordering of Lisp
676 strings.
677 (handle_stop_backwards): Support Lisp strings as well.
678 (display_string): Support display of R2L glyph rows. Use
679 IT_STRING_CHARPOS when displaying from a Lisp string.
680 (init_iterator): Don't initialize it->bidi_p for strings
681 here.
682 (reseat_to_string): Initialize it->bidi_p for strings here.
683 (next_element_from_string, next_element_from_c_string)
684 (next_element_from_buffer): Add xassert's for correspondence
685 between IT's object being iterated and it->bidi_it.string
686 structure.
687 (face_before_or_after_it_pos): Support bidi iteration.
688 (next_element_from_c_string): Handle the case of the first string
689 character that is not the first one in the visual order.
690 (get_visually_first_element): New function, refactored from common
691 parts of next_element_from_buffer, next_element_from_string, and
692 next_element_from_c_string.
693 (tool_bar_lines_needed, redisplay_tool_bar)
694 (display_menu_bar): Force left-to-right direction. Add a FIXME
695 comment for making that be controlled by a user option.
696 (push_it, pop_it): Save and restore the state of the
697 bidi iterator. Save and restore the bidi_p flag.
698 (pop_it): Iterate out of display property for string iteration as
699 well.
700 (iterate_out_of_display_property): Support iteration over strings.
701 (handle_single_display_spec): Set up it->bidi_it for iteration
702 over a display string, and call bidi_init_it.
703 (handle_single_display_spec, next_overlay_string)
704 (get_overlay_strings_1, push_display_prop): Set up the bidi
705 iterator for displaying display or overlay strings.
706 (forward_to_next_line_start): Don't use the shortcut if
707 bidi-iterating.
708 (back_to_previous_visible_line_start): If handle_display_prop
709 pushed the iterator stack, restore the internal state of the bidi
710 iterator by calling bidi_pop_it same number of times.
711 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
712 and we are bidi-iterating, don't decrement the iterator position;
713 instead, set the first_elt flag in the bidi iterator, to produce
714 the same effect.
715 (reseat_1): Remove redundant setting of string_from_display_prop_p.
716 (push_display_prop): xassert that we are iterating a buffer.
717 (push_it, pop_it): Save and restore paragraph_embedding member.
718 (handle_single_display_spec, next_overlay_string)
719 (get_overlay_strings_1, reseat_1, reseat_to_string)
720 (push_display_prop): Set up the `unibyte' member of bidi_it.string
721 correctly. Don't assume unibyte strings are not bidi-reordered.
722 (compute_display_string_pos)
723 (compute_display_string_end): Fix handling the case of C string.
724 (push_it, pop_it): Save and restore from_disp_prop_p.
725 (handle_single_display_spec, push_display_prop): Set the
726 from_disp_prop_p flag.
727 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
728 (pop_it): Call iterate_out_of_display_property only if we are
729 popping after iteration over a string that came from a display
730 property. Fix a typo in popping stretch info. Add an assertion
731 for verifying that the iterator position is in sync with the bidi
732 iterator.
733 (handle_single_display_spec, get_overlay_strings_1)
734 (push_display_prop): Fix initialization of paragraph direction for
735 string when that of the parent object is not yet determined.
736 (reseat_1): Call bidi_init_it to resync the bidi
737 iterator with IT's position. (Bug#7616)
738 (find_row_edges): If ROW->start.pos gives position
739 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
740 (handle_stop, back_to_previous_visible_line_start, reseat_1):
741 Reset the from_disp_prop_p flag.
742 (SAVE_IT, RESTORE_IT): New macros.
743 (pos_visible_p, face_before_or_after_it_pos)
744 (back_to_previous_visible_line_start)
745 (move_it_in_display_line_to, move_it_in_display_line)
746 (move_it_to, move_it_vertically_backward, move_it_by_lines)
747 (try_scrolling, redisplay_window, display_line): Use them when
748 saving a temporary copy of the iterator and restoring it back.
749 (back_to_previous_visible_line_start, reseat_1)
750 (init_iterator): Empty the bidi cache "stack".
751 (move_it_in_display_line_to): If iterator ended up at
752 EOL, but we never saw any buffer positions smaller than
753 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
754 motion in bidi-reordered lines.
755 (move_it_in_display_line_to): Record prev_method and prev_pos
756 immediately before the call to set_iterator_to_next. Fixes cursor
757 motion in bidi-reordered lines with stretch glyphs and strings
758 displayed in margins. (Bug#8133) (Bug#8867)
759 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
760 TO_CHARPOS.
761 (pos_visible_p): Support positions in bidi-reordered lines. Save
762 and restore bidi cache.
763
764 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
765 (bidi_paragraph_info): Delete unused struct.
766 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
767 (bidi_cache_start): New variable.
768 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
769 to zero.
770 (bidi_cache_fetch_state, bidi_cache_search)
771 (bidi_cache_find_level_change, bidi_cache_iterator_state)
772 (bidi_cache_find, bidi_peek_at_next_level)
773 (bidi_level_of_next_char, bidi_find_other_level_edge)
774 (bidi_move_to_visually_next): Compare cache index with
775 bidi_cache_start rather than with zero.
776 (bidi_fetch_char): Accept new argument STRING; all callers
777 changed. Support iteration over a string. Support strings with
778 display properties. Support unibyte strings. Fix the type of
779 `len' according to what STRING_CHAR_AND_LENGTH expects.
780 (bidi_paragraph_init, bidi_resolve_explicit_1)
781 (bidi_resolve_explicit, bidi_resolve_weak)
782 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
783 iteration over a string.
784 (bidi_set_sor_type, bidi_resolve_explicit_1)
785 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
786 can now be zero (for strings); special values 0 and -1 were
787 changed to -1 and -2, respectively.
788 (bidi_char_at_pos): New function.
789 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
790 Call it instead of FETCH_MULTIBYTE_CHAR.
791 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
792 initialized to valid values.
793 (bidi_init_it): Don't initialize charpos and bytepos with invalid
794 values.
795 (bidi_level_of_next_char): Allow the sentinel "position" to pass
796 the test for valid cached positions. Fix the logic for looking up
797 the sentinel state in the cache. GCPRO the Lisp string we are
798 iterating.
799 (bidi_push_it, bidi_pop_it): New functions.
800 (bidi_initialize): Initialize the bidi cache start stack pointer.
801 (bidi_cache_ensure_space): New function, refactored from part of
802 bidi_cache_iterator_state. Don't assume the required size is just
803 one BIDI_CACHE_CHUNK away.
804 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
805 (bidi_count_bytes, bidi_char_at_pos): New functions.
806 (bidi_cache_search): Don't assume bidi_cache_last_idx is
807 always valid if bidi_cache_idx is valid.
808 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
809 is valid if it's going to be used.
810 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
811 (bidi_cache_fetch_state, bidi_cache_search)
812 (bidi_cache_find_level_change, bidi_cache_ensure_space)
813 (bidi_cache_iterator_state, bidi_cache_find)
814 (bidi_find_other_level_edge, bidi_cache_start_stack): All
815 variables related to cache indices are now EMACS_INT.
816
817 * dispextern.h (struct bidi_string_data): New structure.
818 (struct bidi_it): New member `string'. Make flag members be 1-bit
819 fields, and put them last in the struct.
820 (compute_display_string_pos, compute_display_string_end): Update
821 prototypes.
822 (bidi_push_it, bidi_pop_it): Add prototypes.
823 (struct iterator_stack_entry): New members bidi_p,
824 paragraph_embedding, and from_disp_prop_p.
825 (struct it): Member bidi_p is now a bit field 1 bit wide.
826 (bidi_shelve_cache, bidi_unshelve_cache): Declare
827 prototypes.
828
829 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
830 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
831 and vector-like objects.
832
833 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
834 cache around display iteration.
835
836 * window.c (Fwindow_end, window_scroll_pixel_based)
837 (displayed_window_lines, Frecenter): Save and restore the bidi
838 cache around display iteration.
839
840 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
841
842 * editfns.c (Fdelete_region): Clarify the use of the named
843 parameters (bug#6788).
844
845 2011-07-14 Martin Rudalics <rudalics@gmx.at>
846
847 * indent.c (Fvertical_motion): Set and restore w->pointm when
848 saving and restoring the window's buffer (Bug#9006).
849
850 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
851
852 * editfns.c (Fstring_to_char): Clarify just what is returned
853 (bug#6576). Text by Eli Zaretskii.
854
855 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
856
857 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
858
859 2011-07-13 Eli Zaretskii <eliz@gnu.org>
860
861 * buffer.c (mmap_find): Fix a typo.
862
863 2011-07-13 Johan Bockgård <bojohan@gnu.org>
864
865 Fix execution of x selection hooks.
866 * xselect.c (Qx_lost_selection_functions)
867 (Qx_sent_selection_functions): New vars.
868 (syms_of_xselect): DEFSYM them.
869 (x_handle_selection_request): Pass Qx_sent_selection_functions
870 rather than Vx_sent_selection_functions to Frun_hook_with_args.
871 (x_handle_selection_clear,x_clear_frame_selections):
872 Pass Qx_lost_selection_functions rather than
873 Vx_lost_selection_functions to Frun_hook_with_args.
874
875 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
876
877 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
878 The old code sometimes used this field without initializing it.
879
880 * alloc.c (gc_sweep): Don't read past end of array.
881 In theory, the old code could also have corrupted Emacs internals,
882 though it'd be very unlikely.
883
884 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
885
886 * character.c (Fcharacterp): Don't advertise optional ignored
887 argument. (Bug#4026)
888
889 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
890
891 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
892 key" (bug#4257).
893
894 * window.c (Fset_window_start): Doc fix (bug#4199).
895 (Fset_window_hscroll): Ditto.
896
897 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
898
899 Fix minor new problems caught by GCC 4.6.1.
900 * term.c (init_tty): Remove unused local.
901 * xsettings.c (store_monospaced_changed): Define this function only
902 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
903 not used otherwise.
904
905 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
906
907 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
908
909 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
910
911 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
912 are the mini-buffer and the echo area (bug#3320).
913
914 * term.c (init_tty): Remove support for supdup, c10 and perq
915 terminals, which are no longer supported (bug#1482).
916
917 2011-07-10 Johan Bockgård <bojohan@gnu.org>
918
919 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
920
921 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
922
923 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
924 for non-popups (Bug#3642).
925
926 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
927
928 * alloc.c (reset_malloc_hooks): Protoize.
929 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
930 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
931 * cm.c (losecursor): Likewise.
932 * data.c (fmod): Likewise.
933 * dispnew.c (swap_glyphs_in_rows): Likewise.
934 * emacs.c (memory_warning_signal): Likewise.
935 * floatfns.c (float_error): Likewise.
936 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
937 (otf_open, font_otf_capability, generate_otf_features)
938 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
939 Likewise.
940 * image.c (pbm_read_file): Likewise.
941 * indent.c (string_display_width): Likewise.
942 * intervals.c (check_for_interval, search_for_interval)
943 (inc_interval_count, count_intervals, root_interval)
944 (adjust_intervals_for_insertion, make_new_interval): Likewise.
945 * lread.c (defalias): Likewise.
946 * ralloc.c (r_alloc_check): Likewise.
947 * regex.c (set_image_of_range_1, set_image_of_range)
948 (regex_grow_registers): Likewise.
949 * sysdep.c (strerror): Likewise.
950 * termcap.c (valid_filename_p, tprint, main): Likewise.
951 * tparam.c (main): Likewise.
952 * unexhp9k800.c (run_time_remap, save_data_space)
953 (update_file_ptrs, read_header, write_header, calculate_checksum)
954 (copy_file, copy_rest, display_header): Likewise.
955 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
956 Likewise.
957 * xdisp.c (check_it): Likewise.
958 * xfaces.c (register_color, unregister_color, unregister_colors):
959 Likewise.
960 * xfns.c (print_fontset_result): Likewise.
961 * xrdb.c (member, fatal, main): Likewise.
962
963 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
964
965 Fix minor problems found by static checking (Bug#9031).
966 * chartab.c (char_table_set_range, map_sub_char_table):
967 Remove unused locals.
968 (uniprop_table): Now static.
969 * composite.c (_work_char): Remove unused static var.
970
971 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
972
973 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
974
975 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
976
977 * gtkutil.c (qttip_cb): Remove code without function.
978
979 2011-07-09 Eli Zaretskii <eliz@gnu.org>
980
981 * w32.c (pthread_sigmask): New stub.
982
983 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
984
985 Use pthread_sigmask, not sigprocmask (Bug#9010).
986 sigprocmask is portable only for single-threaded applications, and
987 Emacs can be multi-threaded when it uses GTK.
988 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
989 (LIBES): Use it.
990 * callproc.c (Fcall_process):
991 * process.c (create_process):
992 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
993 Use pthread_sigmask, not sigprocmask.
994
995 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
996
997 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
998 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
999 wrong (Bug#8591).
1000
1001 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1002
1003 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1004 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1005 (xg_hide_tooltip): Fix comment.
1006
1007 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1008 in registerServicesMenuSendTypes.
1009 (validRequestorForSendType): Don't check ns_return_types.
1010
1011 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1012 ns_return_type.
1013
1014 2011-07-08 Jason Rumney <jasonr@gnu.org>
1015
1016 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1017 frame struct members of non-existent frames (Bug#6284).
1018
1019 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1020
1021 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1022 variable firstTime not needed on OSX >= 10.6.
1023 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1024 >= 10.5. Use setKnobProportion, setDoubleValue.
1025
1026 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1027 (MAC_OS_X_VERSION_10_5): Define if not defined.
1028 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1029 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1030 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1031
1032 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1033 cString and lossyCString on OSX >= 10.4
1034
1035 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1036 sizeToFit on OSX >= 10.2.
1037
1038 * nsimage.m (allocInitFromFile): Don't use deprecated method
1039 bestRepresentationForDevice on OSX >= 10.6.
1040
1041 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1042 to avoid warning.
1043
1044 * emacs.c: Declare unexec_init_emacs_zone.
1045
1046 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1047
1048 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1049
1050 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1051 on svcsMenu (Bug#8842).
1052
1053 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1054 ns_return_types.
1055 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1056
1057 * nsterm.m (QUTF8_STRING): Declare.
1058 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1059 (validRequestorForSendType): Return type is (id).
1060 Change indexOfObjectIdenticalTo to indexOfObject.
1061 Check if we have local selection before returning self (Bug#8842).
1062 (writeSelectionToPasteboard): Put local selection into paste board
1063 if we have a local selection (Bug#8842).
1064 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1065
1066 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1067 (ns_get_local_selection): Declare.
1068
1069 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1070
1071 * keymap.c (describe_map_tree): Don't insert a double newline at
1072 the end of the buffer (bug#1169) and return whether we inserted
1073 something.
1074
1075 * callint.c (Fcall_interactively): Change "reading args" to
1076 "providing args" to try to clarify what it does (bug#1010).
1077
1078 2011-07-07 Kenichi Handa <handa@m17n.org>
1079
1080 * composite.c (composition_compute_stop_pos): Ignore a static
1081 composition starting before CHARPOS (Bug#8915).
1082
1083 * xdisp.c (handle_composition_prop): Likewise.
1084
1085 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1086
1087 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1088 (Bug#9015)
1089
1090 2011-07-07 Kenichi Handa <handa@m17n.org>
1091
1092 * character.h (unicode_category_t): New enum type.
1093
1094 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1095 (Qchar_code_property_table): New variable.
1096 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1097 (UNIPROP_COMPRESSED_FORM_P): New macros.
1098 (char_table_ascii): Uncompress the compressed values.
1099 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1100 Uncompress the compressed values.
1101 (sub_char_table_ref_and_range): Likewise.
1102 (char_table_ref_and_range): Uncompress the compressed values.
1103 (sub_char_table_set): New arg is_uniprop. Callers changed.
1104 Uncompress the compressed values.
1105 (sub_char_table_set_range): Args changed. Callers changed.
1106 (char_table_set_range): Adjuted for the above change.
1107 (map_sub_char_table): Delete args default_val and parent. Add arg
1108 top. Give decoded values to a Lisp function.
1109 (map_char_table): Adjusted for the above change. Give decoded
1110 values to a Lisp function. Gcpro more variables.
1111 (uniprop_table_uncompress)
1112 (uniprop_decode_value_run_length): New functions.
1113 (uniprop_decoder, uniprop_decoder_count): New variables.
1114 (uniprop_get_decoder, uniprop_encode_value_character)
1115 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1116 New functions.
1117 (uniprop_encoder, uniprop_encoder_count): New variables.
1118 (uniprop_get_encoder, uniprop_table)
1119 (Funicode_property_table_internal, Fget_unicode_property_internal)
1120 (Fput_unicode_property_internal): New functions.
1121 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1122 Sunicode_property_table_internal, Sget_unicode_property_internal,
1123 and Sput_unicode_property_internal. Defvar_lisp
1124 char-code-property-alist.
1125
1126 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
1127 Vunicode_category_table.
1128
1129 * font.c (font_range): Adjusted for the change of
1130 Vunicode_category_table.
1131
1132 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1133
1134 * m/iris4d.h: Remove file, move contents ...
1135 * s/irix6-5.h: ... here.
1136
1137 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1138
1139 Remove unportable assumption about struct layout (Bug#8884).
1140 * alloc.c (mark_buffer):
1141 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1142 (clone_per_buffer_values): Don't assume that
1143 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1144 This isn't true in general, and it's particularly not true
1145 if Emacs is configured with --with-wide-int.
1146 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1147 New macros, used in the buffer.c change.
1148
1149 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1150
1151 * xsettings.c: Use both GConf and GSettings if both are available.
1152 (store_config_changed_event): Add comment.
1153 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1154 (store_tool_bar_style_changed): New functions.
1155 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1156 (struct xsettings): Move font inside HAVE_XFT.
1157 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1158 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
1159 Move inside HAVE_XFT.
1160 (something_changed_gsettingsCB): Renamed from something_changedCB.
1161 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1162 also.
1163 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1164 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1165 (something_changed_gconfCB): Renamed from something_changedCB.
1166 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1167 (parse_settings): Move check for font inside HAVE_XFT.
1168 (read_settings, apply_xft_settings): Add comment.
1169 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1170 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1171 call store_font_name_changed.
1172 (xft_settings_event): Add comment.
1173 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1174 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1175 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1176 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1177 (xsettings_initialize): Call init_gsettings last.
1178 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
1179 comment.
1180
1181 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1182
1183 Random fixes. E.g., (random) never returned negative values.
1184 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1185 subseconds part to the entropy, as that's a bit more random.
1186 Prefer signed to unsigned, since the signedness doesn't matter and
1187 in general we prefer signed. When given a limit, use a
1188 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1189 latter isn't right if USE_2_TAGS_FOR_INTS.
1190 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1191 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1192
1193 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1194
1195 * textprop.c (text_property_stickiness):
1196 Obey Vtext_property_default_nonsticky.
1197 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1198 * w32fns.c (syms_of_w32fns):
1199 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1200
1201 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1202
1203 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1204 This is more efficient than Ffile_directory_p and avoids a minor race.
1205
1206 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1207
1208 * buffer.c (Foverlay_put): Say what the return value is
1209 (bug#7835).
1210
1211 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1212 is a directory before asking whether to use the file name
1213 (bug#7564).
1214 (barf_or_query_if_file_exists): Make the "File is a directory"
1215 error be more correct.
1216
1217 * fns.c (Frequire): Remove the mention of the .gz files, since
1218 that's installation-specific, but keep the mention of
1219 `get-load-suffixes'.
1220
1221 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1222
1223 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1224 Report string overflow if the output is too long.
1225
1226 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1227
1228 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1229 (syms_of_gnutls): Remove duplicate DEFSYM for
1230 Qgnutls_bootprop_verify_hostname_error, an error for
1231 Qgnutls_bootprop_verify_error (which is no longer used).
1232
1233 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1234 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1235 Also (re)move comments that are misplaced or no longer relevant.
1236
1237 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1238
1239 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1240
1241 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1242
1243 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1244 and background color parameters if they have been changed.
1245
1246 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1247
1248 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1249
1250 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1251
1252 * xsettings.c (SYSTEM_FONT): Define only when used.
1253 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1254
1255 * keymap.c (access_keymap_1): Now static.
1256
1257 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1258
1259 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1260 leave any prefix arg for the up event (Bug#1586).
1261
1262 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1263
1264 * lread.c (syms_of_lread): Mention single symbols defined by
1265 `defvar' or `defconst' (bug#7154).
1266
1267 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1268 (Frequire): Mention get-load-suffixes.
1269
1270 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1271
1272 * window.h (window): Remove clone_number slot.
1273 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1274 Remove.
1275 (make_parent_window, make_window, saved_window)
1276 (Fset_window_configuration, save_window_save): Don't deal with
1277 clone numbers.
1278 * buffer.c (Qclone_number): Remove declaration.
1279 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1280
1281 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1282
1283 Add multiple inheritance to keymaps.
1284 * keymap.c (Fmake_composed_keymap): New function.
1285 (Fset_keymap_parent): Simplify.
1286 (fix_submap_inheritance): Remove.
1287 (access_keymap_1): New function extracted from access_keymap to handle
1288 embedded parents and handle lists of maps.
1289 (access_keymap): Use it.
1290 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1291 (Fcopy_keymap): Handle embedded parents.
1292 (Fcommand_remapping, define_as_prefix): Simplify.
1293 (Fkey_binding): Simplify.
1294 (syms_of_keymap): Move minibuffer-local-completion-map,
1295 minibuffer-local-filename-completion-map,
1296 minibuffer-local-must-match-map, and
1297 minibuffer-local-filename-must-match-map to Elisp.
1298 (syms_of_keymap): Defsubr make-composed-keymap.
1299 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1300 (parse_menu_item): Trivial simplification.
1301
1302 2011-07-01 Glenn Morris <rgm@gnu.org>
1303
1304 * Makefile.in (SETTINGS_LIBS): Fix typo.
1305
1306 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1307
1308 * coding.c (Fencode_coding_string): Record the last coding system
1309 used, as the function doc string says (bug#8738).
1310
1311 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1312
1313 * xsettings.c (store_monospaced_changed): Take new font as arg and
1314 check for change against current_mono_font.
1315 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1316 (emacs_settings_constructor, emacs_settings_get_property)
1317 (emacs_settings_set_property, emacs_settings_class_init)
1318 (emacs_settings_init, gsettings_obj): Remove.
1319 (something_changedCB): New function for HAVE_GSETTINGS.
1320 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1321 with value as argument.
1322 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1323 g_settings_new (Bug#8967). Do not create gsettings_obj.
1324 Remove calls to g_settings_bind. Connect something_changedCB to
1325 "changed".
1326
1327 * xgselect.c: Add defined (HAVE_GSETTINGS).
1328 (xgselect_initialize): Ditto.
1329
1330 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1331 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1332 xg_select.
1333
1334 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1335
1336 * eval.c (struct backtrace): Simplify and port the data structure.
1337 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1338 signed bit field, as this assumption is not portable and it makes
1339 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1340 "char debug_on_exit : 1" as this is not portable either; instead,
1341 use the portable "unsigned int debug_on_exit : 1". Remove unused
1342 member evalargs. Remove obsolete comments about cc bombing out.
1343
1344 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1345
1346 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1347 Let HAVE_GSETTINGS override HAVE_GCONF.
1348 (store_monospaced_changed): New function.
1349 (EMACS_SETTINGS): A new type derived from GObject to handle
1350 GSettings notifications.
1351 (emacs_settings_constructor, emacs_settings_get_property)
1352 (emacs_settings_set_property, emacs_settings_class_init):
1353 New functions.
1354 (gsettings_client, gsettings_obj): New variables.
1355 (GSETTINGS_SCHEMA): New define.
1356 (something_changedCB): Call store_monospaced_changed.
1357 (init_gsettings): New function.
1358 (xsettings_initialize): Call init_gsettings.
1359 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1360 to NULL.
1361
1362 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
1363 GCONF_CFLAGS/LIBS.
1364
1365 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1366
1367 * window.c (resize_root_window, grow_mini_window)
1368 (shrink_mini_window): Rename Qresize_root_window to
1369 Qwindow_resize_root_window and Qresize_root_window_vertically to
1370 Qwindow_resize_root_window_vertically.
1371
1372 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1373
1374 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1375
1376 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1377
1378 * makefile.w32-in: Redesign dependencies so they reflect more
1379 clearly which files are directly included by each source file,
1380 and not through other includes.
1381
1382 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1383
1384 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1385 (sort_overlays, overlay_strings): When an overlay's clone number
1386 matches the window's clone number process the overlay even if
1387 the overlay's window property doesn't match the current window.
1388
1389 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1390 (Fwindow_hchild): Rename to Fwindow_left_child.
1391 (Fwindow_next): Rename to Fwindow_next_sibling.
1392 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1393 (resize_window_check): Rename to window_resize_check.
1394 (resize_window_apply): Rename to window_resize_apply.
1395 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1396 (Fdelete_other_windows_internal, resize_frame_windows)
1397 (Fsplit_window_internal, Fdelete_window_internal)
1398 (grow_mini_window, shrink_mini_window)
1399 (Fresize_mini_window_internal): Fix callers accordingly.
1400
1401 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1402
1403 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1404 (emacs_fixed_set_min_size): Remove.
1405 (emacs_fixed_new): Take frame as argument.
1406
1407 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1408 (_EmacsFixedPrivate): Remove minwidth/height.
1409 Add struct frame *f.
1410 (emacs_fixed_init): Initialize priv->f.
1411 (get_parent_class, emacs_fixed_set_min_size): Remove.
1412 (emacs_fixed_new): Set priv->f to argument.
1413 (emacs_fixed_get_preferred_width)
1414 (emacs_fixed_get_preferred_height): Use min_width/height from
1415 frames size_hint to set minimum and natural (Bug#8919).
1416 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1417 and use min_width/height from frames size_hint to set
1418 min_width/height (Bug#8919).
1419
1420 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1421 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1422 Fix indentation.
1423
1424 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1425
1426 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1427 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1428 called at ZV.
1429
1430 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1431
1432 * process.c (wait_reading_process_output): Bypass select if
1433 waiting for a cell while ignoring keyboard input, and input is
1434 pending. Suggested by Jan Djärv (Bug#8869).
1435
1436 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1437
1438 Use gnulib's dup2 module instead of rolling our own.
1439 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1440
1441 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1442
1443 * dispnew.c (scrolling_window): Before scrolling, turn off a
1444 mouse-highlight in the window being scrolled.
1445
1446 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1447
1448 Move DEFSYM to lisp.h and use everywhere.
1449
1450 * character.h (DEFSYM): Move declaration...
1451 * lisp.h (DEFSYM): ...here.
1452
1453 * gnutls.c:
1454 * minibuf.c:
1455 * w32menu.c:
1456 * w32proc.c:
1457 * w32select.c: Don't include character.h.
1458
1459 * alloc.c (syms_of_alloc):
1460 * buffer.c (syms_of_buffer):
1461 * bytecode.c (syms_of_bytecode):
1462 * callint.c (syms_of_callint):
1463 * casefiddle.c (syms_of_casefiddle):
1464 * casetab.c (init_casetab_once):
1465 * category.c (init_category_once, syms_of_category):
1466 * ccl.c (syms_of_ccl):
1467 * cmds.c (syms_of_cmds):
1468 * composite.c (syms_of_composite):
1469 * dbusbind.c (syms_of_dbusbind):
1470 * dired.c (syms_of_dired):
1471 * dispnew.c (syms_of_display):
1472 * doc.c (syms_of_doc):
1473 * editfns.c (syms_of_editfns):
1474 * emacs.c (syms_of_emacs):
1475 * eval.c (syms_of_eval):
1476 * fileio.c (syms_of_fileio):
1477 * fns.c (syms_of_fns):
1478 * frame.c (syms_of_frame):
1479 * fringe.c (syms_of_fringe):
1480 * insdel.c (syms_of_insdel):
1481 * keymap.c (syms_of_keymap):
1482 * lread.c (init_obarray, syms_of_lread):
1483 * macros.c (syms_of_macros):
1484 * msdos.c (syms_of_msdos):
1485 * print.c (syms_of_print):
1486 * process.c (syms_of_process):
1487 * search.c (syms_of_search):
1488 * sound.c (syms_of_sound):
1489 * syntax.c (init_syntax_once, syms_of_syntax):
1490 * terminal.c (syms_of_terminal):
1491 * textprop.c (syms_of_textprop):
1492 * undo.c (syms_of_undo):
1493 * w32.c (globals_of_w32):
1494 * window.c (syms_of_window):
1495 * xdisp.c (syms_of_xdisp):
1496 * xfaces.c (syms_of_xfaces):
1497 * xfns.c (syms_of_xfns):
1498 * xmenu.c (syms_of_xmenu):
1499 * xsettings.c (syms_of_xsettings):
1500 * xterm.c (syms_of_xterm): Use DEFSYM.
1501
1502 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1503
1504 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1505
1506 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1507
1508 Integer and buffer overflow fixes (Bug#8873).
1509
1510 * print.c (printchar, strout): Check for string overflow.
1511 (PRINTPREPARE, printchar, strout):
1512 Don't set size unless allocation succeeds.
1513
1514 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1515 for sizes. Check for string overflow more accurately.
1516 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1517
1518 * macros.c: Integer and buffer overflow fixes.
1519 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1520 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1521 Use ptrdiff_t, not int, for sizes.
1522 Don't increment bufsize until after realloc succeeds.
1523 Check for size-calculation overflow.
1524 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1525
1526 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1527
1528 * lread.c: Integer overflow fixes.
1529 (read_integer): Radix is now EMACS_INT, not int,
1530 to improve quality of diagnostics for out-of-range radices.
1531 Calculate buffer size correctly for out-of-range radices.
1532 (read1): Check for integer overflow in radices, and in
1533 read-circle numbers.
1534 (read_escape): Avoid int overflow.
1535 (Fload, openp, read_buffer_size, read1)
1536 (substitute_object_recurse, read_vector, read_list, map_obarray):
1537 Use ptrdiff_t, not int, for sizes.
1538 (read1): Use EMACS_INT, not int, for sizes.
1539 Check for size overflow.
1540
1541 * image.c (cache_image): Check for size arithmetic overflow.
1542
1543 * lread.c: Integer overflow issues.
1544 (saved_doc_string_size, saved_doc_string_length)
1545 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1546 Now ptrdiff_t, not int.
1547 (read1): Don't assume doc string length fits in int. Check for
1548 out-of-range doc string lengths.
1549 (read_list): Don't assume file position fits in int.
1550 (read_escape): Check for hex character overflow.
1551
1552 2011-06-22 Leo Liu <sdl.web@gmail.com>
1553
1554 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1555 Move to minibuffer.el.
1556
1557 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1558
1559 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1560 The following patches are for when GLYPH_DEBUG && !XASSERT.
1561 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1562 * dispnew.c (flush_stdout):
1563 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1564 Mark as externally visible.
1565 * dispnew.c (check_window_matrix_pointers): Now static.
1566 * dispnew.c (window_to_frame_vpos):
1567 * xfns.c (unwind_create_frame):
1568 * xterm.c (x_check_font): Remove unused local.
1569 * scroll.c (CHECK_BOUNDS):
1570 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1571 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1572 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1573 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1574 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1575 Now static.
1576 (debug_method_add): Use va_list and vsprintf rather than relying
1577 on undefined behavior with wrong number of arguments.
1578 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1579 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1580 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1581 since we're not interested in debugging glyphs with old libraries.
1582 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1583 GCC 4.6.0's static checking.
1584
1585 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1586
1587 Integer overflow and signedness fixes (Bug#8873).
1588 A few related buffer overrun fixes, too.
1589
1590 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1591
1592 * dispextern.h (struct face.stipple):
1593 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1594 (x_bitmap_mask, x_allocate_bitmap_record)
1595 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1596 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1597 (x_create_bitmap_from_xpm_data):
1598 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1599 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1600 (.bitmaps_last):
1601 * xfaces.c (load_pixmap):
1602 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1603 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1604 (.bitmaps_last, struct x_output.icon_bitmap):
1605 Use ptrdiff_t, not int, for bitmap indexes.
1606 (x_allocate_bitmap_record): Check for size overflow.
1607 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1608
1609 Use ptrdiff_t, not int, for overlay counts.
1610 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1611 * editfns.c (overlays_around, get_pos_property):
1612 * textprop.c (get_char_property_and_overlay):
1613 * xdisp.c (next_overlay_change, note_mouse_highlight):
1614 * xfaces.c (face_at_buffer_position):
1615 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1616 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1617 (Fnext_overlay_change, Fprevious_overlay_change)
1618 (mouse_face_overlay_overlaps, Foverlays_in):
1619 Use ptrdiff_t, not int, for sizes.
1620 (overlays_at, overlays_in): Check for size-calculation overflow.
1621
1622 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1623
1624 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1625 (x_session_initialize): Do not assume string length fits in int.
1626
1627 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1628 This is unlikely, but can occur if DPI is outlandish.
1629
1630 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1631 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1632
1633 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1634 * xrdb.c (magic_file_p, search_magic_path):
1635 Omit last arg SUFFIX; it was always 0. All callers changed.
1636 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1637
1638 * xfont.c (xfont_match): Avoid need for strlen.
1639
1640 * xfns.c: Don't assume strlen fits in int.
1641 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1642
1643 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1644 not unsigned long, as we prefer signed integers. All callers changed.
1645 Detect integer overflow in repeat count.
1646 (message_dolog): Don't assume print length fits in 39 bytes.
1647 (display_mode_element): Don't assume strlen fits in int.
1648
1649 * termcap.c: Don't assume sizes fit in int and never overflow.
1650 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1651 (gobble_line): Check for size-calculation overflow.
1652
1653 * minibuf.c (Fread_buffer):
1654 * lread.c (intern, intern_c_string):
1655 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1656 Don't assume string length fits in int.
1657
1658 * keyboard.c (parse_tool_bar_item):
1659 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1660
1661 * font.c: Don't assume string length fits in int.
1662 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1663 Use ptrdiff_t, not int.
1664 (font_intern_prop): Don't assume string length fits in int.
1665 Don't assume integer property fits in fixnum.
1666 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1667
1668 * filelock.c: Fix some buffer overrun and integer overflow issues.
1669 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1670 Reformulate so as not to need the command string.
1671 Invoke gzip -cd rather than gunzip, as it's more portable.
1672 (lock_info_type, lock_file_1, lock_file):
1673 Don't assume pid_t and time_t fit in unsigned long.
1674 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1675 (current_lock_owner): Prefer signed type for sizes.
1676 Use memcpy, not strncpy, where memcpy is what is really wanted.
1677 Don't assume (via atoi) that time_t and pid_t fit in int.
1678 Check for time_t and/or pid_t out of range, e.g., via a network share.
1679 Don't alloca where an auto var works fine.
1680
1681 * fileio.c: Fix some integer overflow issues.
1682 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1683 Don't assume string length fits in int.
1684 (directory_file_name): Don't assume string length fits in long.
1685 (make_temp_name): Don't assume pid fits in int, or that its print
1686 length is less than 20.
1687
1688 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1689
1690 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1691
1692 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1693
1694 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1695 We prefer signed integers, even for size calculations.
1696
1697 * emacs.c: Don't assume string length fits in 'int'.
1698 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1699 (main): Don't invoke strlen when not needed.
1700
1701 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1702 (XD_DEBUG_MESSAGE): Don't waste a byte.
1703
1704 * callproc.c (getenv_internal_1, getenv_internal)
1705 (Fgetenv_internal):
1706 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1707
1708 * lread.c (invalid_syntax): Omit length argument.
1709 All uses changed. This doesn't fix a bug, but it simplifies the
1710 code away from its former Hollerith-constant appearance, and it's
1711 one less 'int' to worry about when looking at integer-overflow issues.
1712 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1713
1714 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1715 This didn't break anything, but it didn't help either.
1716 It's confusing to put a bogus integer in a place where the actual
1717 value does not matter.
1718 (LIST_END_P): Remove unused macro and its bogus comment.
1719 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1720
1721 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1722 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1723 implementation.
1724 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1725 We prefer signed types, and the value cannot exceed the EMACS_INT
1726 range anyway (because otherwise the length would not be representable).
1727 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1728 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1729 This avoids a GCC warning when WIDE_EMACS_INT.
1730
1731 * indent.c (sane_tab_width): New function.
1732 (current_column, scan_for_column, Findent_to, position_indentation)
1733 (compute_motion): Use it. This is just for clarity.
1734 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1735
1736 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1737
1738 * lisp.h (lint_assume): New macro.
1739 * composite.c (composition_gstring_put_cache):
1740 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1741
1742 * editfns.c, insdel.c:
1743 Omit unnecessary forward decls, to simplify future changes.
1744
1745 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1746
1747 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1748
1749 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1750 Use much-faster test for byte-length change.
1751 Don't assume string byte-length fits in 'int'.
1752 Check that character arg fits in 'int'.
1753 (mapcar1): Declare byte as byte, for clarity.
1754
1755 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1756
1757 * fns.c (concat): Catch string overflow earlier.
1758 Do not rely on integer wraparound.
1759
1760 * dispextern.h (struct it.overlay_strings_charpos)
1761 (struct it.selective): Now EMACS_INT, not int.
1762 * xdisp.c (forward_to_next_line_start)
1763 (back_to_previous_visible_line_start)
1764 (reseat_at_next_visible_line_start, next_element_from_buffer):
1765 Don't arbitrarily truncate the value of 'selective' to int.
1766
1767 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1768
1769 * composite.c: Don't truncate sizes to 'int'.
1770 (composition_gstring_p, composition_reseat_it)
1771 (composition_adjust_point): Use EMACS_INT, not int.
1772 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1773 not EMACS_UINT, for indexes.
1774
1775 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1776
1777 * buffer.c: Include <verify.h>.
1778 (struct sortvec.priority, struct sortstr.priority):
1779 Now EMACS_INT, not int.
1780 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1781 (struct sortstr.size, record_overlay_string)
1782 (struct sortstrlist.size, struct sortlist.used):
1783 Don't truncate size to int.
1784 (record_overlay_string): Check for size-calculation overflow.
1785 (init_buffer_once): Check at compile-time, not run-time.
1786
1787 2011-06-22 Jim Meyering <meyering@redhat.com>
1788
1789 Don't leak an XBM-image-sized buffer
1790 * image.c (xbm_load): Free the image buffer after using it.
1791
1792 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1793
1794 Port to Sun C.
1795 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1796 that Sun C diagnosed.
1797 * fns.c (secure_hash): Fix pointer signedness issue.
1798 * intervals.c (static_offset_intervals): New function.
1799 (offset_intervals): Use it.
1800
1801 2011-06-21 Leo Liu <sdl.web@gmail.com>
1802
1803 * deps.mk (fns.o):
1804 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1805 sha512.h.
1806
1807 * fns.c (secure_hash): Rename from crypto_hash_function and change
1808 the first arg to accept symbols.
1809 (Fsecure_hash): New primitive.
1810 (syms_of_fns): New symbols.
1811
1812 2011-06-20 Deniz Dogan <deniz@dogan.se>
1813
1814 * process.c (Fset_process_buffer): Clarify return value in
1815 docstring.
1816
1817 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1818
1819 * dispnew.c (add_window_display_history): Use BVAR.
1820
1821 * xdisp.c (debug_method_add): Use BVAR.
1822 (check_window_end, dump_glyph_matrix, dump_glyph)
1823 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1824
1825 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1826 Likewise.
1827
1828 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1829 check till after the cache is created in init_frame_faces.
1830
1831 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1832
1833 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1834
1835 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1836
1837 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1838 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1839 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1840
1841 Improve buffer-overflow checking (Bug#8873).
1842 * fileio.c (Finsert_file_contents):
1843 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1844 Remove the old (too-loose) buffer overflow checks.
1845 They weren't needed, since make_gap checks for buffer overflow.
1846 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1847 The old code merely checked for Emacs fixnum overflow, and relied
1848 on undefined (wraparound) behavior. The new code avoids undefined
1849 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1850
1851 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1852 Tune. Don't use wider integers than needed. Don't use alloca.
1853 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1854
1855 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1856
1857 * insdel.c, lisp.h (buffer_overflow): New function.
1858 (insert_from_buffer_1, replace_range, replace_range_2):
1859 * insdel.c (make_gap_larger):
1860 * editfns.c (Finsert_char):
1861 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1862
1863 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1864
1865 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1866
1867 Integer overflow and signedness fixes (Bug#8873).
1868
1869 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1870 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1871
1872 * fileio.c: Don't assume EMACS_INT fits in off_t.
1873 (emacs_lseek): New static function.
1874 (Finsert_file_contents, Fwrite_region): Use it.
1875 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1876
1877 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1878
1879 * fns.c: Don't overflow int when computing a list length.
1880 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1881 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1882 truncation on 64-bit hosts. Check for QUIT every
1883 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1884 faster and is responsive enough.
1885 (Flength): Report an error instead of overflowing an integer.
1886 (Fsafe_length): Return a float if the value is not representable
1887 as a fixnum. This shouldn't happen except in contrived situations.
1888 (Fnthcdr, Fsort): Don't assume list length fits in int.
1889 (Fcopy_sequence): Don't assume vector length fits in int.
1890
1891 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1892 (header_size, word_size): New constants.
1893 (allocate_vectorlike): Don't check size overflow here.
1894 (allocate_vector): Check it here instead, since this is the only
1895 caller of allocate_vectorlike that could cause overflow.
1896 Check that the new vector's length is representable as a fixnum.
1897
1898 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1899 The previous code was bogus. For example, next_almost_prime (32)
1900 returned 39, which is undesirable as it is a multiple of 3; and
1901 next_almost_prime (24) returned 25, which is a multiple of 5 so
1902 why was the code bothering to check for multiples of 7?
1903
1904 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1905
1906 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1907
1908 Variadic C functions now count arguments with ptrdiff_t.
1909 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1910 Back then I didn't know that the Emacs coding style prefers signed int.
1911 Also, in the meantime I found a few more instances where arguments
1912 were being counted with int, which may truncate counts on 64-bit
1913 machines, or EMACS_INT, which may be unnecessarily wide.
1914 * lisp.h (struct Lisp_Subr.function.aMANY)
1915 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1916 Arg counts are now ptrdiff_t, not size_t.
1917 All variadic functions and their callers changed accordingly.
1918 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1919 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1920 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1921 * callint.c (Fcall_interactively): Check arg count for overflow,
1922 to avoid potential buffer overrun. Use signed char, not 'int',
1923 for 'varies' array, so that we needn't bother to check its size
1924 calculation for overflow.
1925 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1926 * eval.c (apply_lambda):
1927 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1928 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1929 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1930
1931 * callint.c (Fcall_interactively): Don't use index var as event count.
1932
1933 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1934 * mem-limits.h (SIZE): Remove; no longer used.
1935
1936 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1937
1938 Remove unnecessary casts.
1939 * xterm.c (x_term_init):
1940 * xfns.c (x_set_border_pixel):
1941 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1942 These aren't needed now that we assume ANSI C.
1943
1944 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1945 It's more likely to cause problems (due to unsigned overflow)
1946 than to cure them.
1947
1948 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1949
1950 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1951
1952 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1953
1954 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1955
1956 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1957
1958 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1959
1960 GLYPH_CODE_FACE returns EMACS_INT, not int.
1961 * dispextern.h (merge_faces):
1962 * xfaces.c (merge_faces):
1963 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1964 Don't assume EMACS_INT fits in int.
1965
1966 * character.h (CHAR_VALID_P): Remove unused parameter.
1967 * fontset.c, lisp.h, xdisp.c: All uses changed.
1968
1969 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1970
1971 * fns.c (concat): Minor tuning based on overflow analysis.
1972 This doesn't fix any bugs. Use int to hold character, instead
1973 of constantly refetching from Emacs object. Use XFASTINT, not
1974 XINT, for value known to be a character. Don't bother comparing
1975 a single byte to 0400, as it's always less.
1976
1977 * floatfns.c (Fexpt):
1978 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1979
1980 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1981 for characters.
1982
1983 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1984
1985 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1986 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1987 incorrectly succeed when S was a string, because 4294967386 was
1988 truncated before it was used.
1989
1990 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1991 Otherwise, an out-of-range integer could cause undefined behavior
1992 on a 64-bit host.
1993
1994 * composite.c: Use int, not EMACS_INT, for characters.
1995 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1996 EMACS_INT, for values that are known to be in character range.
1997 This doesn't fix any bugs but is the usual style inside Emacs and
1998 may generate better code on 32-bit machines.
1999
2000 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2001 This is for reasons similar to the recent CHAR_STRING fix.
2002 * charset.c (Fencode_char): Check that character arg is actually
2003 a character. Pass an int to ENCODE_CHAR.
2004 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2005 wider than 'int', as a compile-time check to prevent future regressions
2006 in this area.
2007
2008 * character.c (char_string): Remove unnecessary casts.
2009
2010 Make sure a 64-bit char is never passed to CHAR_STRING.
2011 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2012 by silently ignoring the top 32 bits, allowing some values
2013 that were far too large to be valid characters.
2014 * character.h: Include <verify.h>.
2015 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2016 arguments are no wider than unsigned, as a compile-time check
2017 to prevent future regressions in this area.
2018 * data.c (Faset):
2019 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2020 (Fsubst_char_in_region):
2021 * fns.c (concat):
2022 * xdisp.c (decode_mode_spec_coding):
2023 Adjust to CHAR_STRING's new requirement.
2024 * editfns.c (Finsert_char, Fsubst_char_in_region):
2025 * fns.c (concat): Check that character args are actually
2026 characters. Without this test, these functions did the wrong
2027 thing with wildly out-of-range values on 64-bit hosts.
2028
2029 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2030 These casts should not be needed on 32-bit hosts, either.
2031 * keyboard.c (read_char):
2032 * lread.c (Fload): Remove casts to unsigned.
2033
2034 * lisp.h (UNSIGNED_CMP): New macro.
2035 This fixes comparison bugs on 64-bit hosts.
2036 (ASCII_CHAR_P): Use it.
2037 * casefiddle.c (casify_object):
2038 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2039 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2040 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2041 * dispextern.h (FACE_FROM_ID):
2042 * keyboard.c (read_char): Use UNSIGNED_CMP.
2043
2044 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2045 not to EMACS_INT, to avoid GCC warning.
2046
2047 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2048
2049 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2050 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2051 isn't needed on 32-bit machines.
2052
2053 * buffer.c (Fgenerate_new_buffer_name):
2054 Use EMACS_INT for count, not int.
2055 (advance_to_char_boundary): Return EMACS_INT, not int.
2056
2057 * data.c (Qcompiled_function): Now static.
2058
2059 * window.c (window_body_lines): Now static.
2060
2061 * image.c (gif_load): Rename local to avoid shadowing.
2062
2063 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2064 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2065 * alloc.c (make_save_value): Integer argument is now of type
2066 ptrdiff_t, not int.
2067 (mark_object): Use ptrdiff_t, not int.
2068 * lisp.h (pD): New macro.
2069 * print.c (print_object): Use it.
2070
2071 * alloc.c: Use EMACS_INT, not int, to count objects.
2072 (total_conses, total_markers, total_symbols, total_vector_size)
2073 (total_free_conses, total_free_markers, total_free_symbols)
2074 (total_free_floats, total_floats, total_free_intervals)
2075 (total_intervals, total_strings, total_free_strings):
2076 Now EMACS_INT, not int. All uses changed.
2077 (Fgarbage_collect): Compute overall total using a double, so that
2078 integer overflow is less likely to be a problem. Check for overflow
2079 when converting back to an integer.
2080 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2081 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2082 These were 'int' variables that could overflow on 64-bit hosts;
2083 they were never used, so remove them instead of repairing them.
2084 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2085 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2086 Previously, this ceilinged at INT_MAX, but that doesn't work on
2087 64-bit machines.
2088 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2089
2090 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2091 (allocate_vectorlike): Check for ptrdiff_t overflow.
2092 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2093 when a (possibly-narrower) signed value would do just as well.
2094 We prefer using signed arithmetic, to avoid comparison confusion.
2095
2096 * alloc.c: Catch some string size overflows that we were missing.
2097 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2098 for convenience in STRING_BYTES_MAX.
2099 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2100 The definition here is exact; the one in lisp.h was approximate.
2101 (allocate_string_data): Check for string overflow. This catches
2102 some instances we weren't catching before. Also, it catches
2103 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2104 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2105 and ptrdiff_t and EMACS_INT are both 64 bits.
2106
2107 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2108 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2109 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
2110
2111 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2112
2113 * alloc.c (Fmake_string): Check for out-of-range init.
2114
2115 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2116
2117 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2118
2119 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2120
2121 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2122 xg_get_default_scrollbar_width.
2123
2124 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2125 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2126 (style_changed_cb): Call update_theme_scrollbar_width and call
2127 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2128 all frames (Bug#8505).
2129 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2130 Call gtk_window_set_resizable if HAVE_GTK3.
2131 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2132 and height if HAVE_GTK3 (Bug#8505).
2133 (scroll_bar_width_for_theme): New variable.
2134 (update_theme_scrollbar_width): New function.
2135 (xg_get_default_scrollbar_width): Move code to
2136 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2137 (xg_initialize): Call update_theme_scrollbar_width.
2138
2139 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2140
2141 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2142
2143 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2144
2145 * frame.c (make_frame): Call other_buffer_safely instead of
2146 other_buffer.
2147
2148 * window.c (temp_output_buffer_show): Call display_buffer with
2149 second argument Vtemp_buffer_show_specifiers and reset latter
2150 immediately after the call.
2151 (Vtemp_buffer_show_specifiers): New variable.
2152 (auto_window_vscroll_p, next_screen_context_lines)
2153 (Vscroll_preserve_screen_position): Remove leading asterisks from
2154 doc-strings.
2155
2156 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2157
2158 Fix minor problems found by GCC 4.6.0 static checking.
2159 * buffer.c (Qclone_number): Remove for now, as it's unused.
2160 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2161 (record_buffer): Remove unused local.
2162 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2163 (set_frame_buffer_list): Remove; unused.
2164 * frame.h (other_visible_frames): Remove decl.
2165 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2166 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2167 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2168 if HAVE_GPM.
2169 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2170 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2171 Define only if HAVE_GPM.
2172 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2173 (update_hints_inhibit): Remove; never set. All uses removed.
2174 * widgetprv.h (emacsFrameClassRec): Remove decl.
2175 * window.c (delete_deletable_window): Now returns void, since it
2176 wasn't returning anything.
2177 (compare_window_configurations): Remove unused locals.
2178 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2179 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2180 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2181 the same widths as pointers. This follows up on the 2011-05-06 patch.
2182 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2183 * xterm.h: Likewise.
2184 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2185
2186 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2187
2188 * makefile.w32-in: Update dependencies.
2189 (LISP_H): Add lib/intprops.h.
2190
2191 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2192
2193 * image.c (gif_load): Add animation frame delay to the metadata.
2194 (syms_of_image): Use DEFSYM. New symbol `delay'.
2195
2196 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2197
2198 * window.c (delete_deletable_window): Re-add.
2199 (Fset_window_configuration): Rewrite to handle dead buffers and
2200 consequently deletable windows.
2201 (window_tree, Fwindow_tree): Remove. Supply functionality in
2202 window.el.
2203 (compare_window_configurations): Simplify code.
2204
2205 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2206
2207 * image.c (imagemagick_load_image): Fix type mismatch.
2208 (Fimagemagick_types): Likewise.
2209
2210 * window.h (replace_buffer_in_windows): Declare.
2211
2212 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2213
2214 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2215 Qclone_number. Remove external declaration of Qdelete_window.
2216 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2217 code.
2218 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
2219 Qbuffer_list_update_hook if allowed.
2220 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2221 buffer list implementation.
2222 (other_buffer_safely): New function.
2223 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2224 calls to replace_buffer_in_windows and
2225 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2226 if allowed.
2227 (record_buffer): Inhibit quitting and rewrite using quittable
2228 functions. Run Qbuffer_list_update_hook if allowed.
2229 (Frecord_buffer, Funrecord_buffer): New functions.
2230 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
2231 switch-to-buffer to window.el.
2232 (bury-buffer): Move to window.el.
2233 (Vbuffer_list_update_hook): New variable.
2234
2235 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2236 section.
2237
2238 * window.h (resize_frame_windows): Move up in code.
2239 (Fwindow_frame): Remove EXFUN.
2240 (replace_buffer_in_all_windows): Remove prototype.
2241 (replace_buffer_in_windows_safely): Add prototype.
2242
2243 * window.c: Declare Qdelete_window static again. Move down
2244 declaration of select_count.
2245 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2246 (Fother_window): Move to window.el.
2247 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2248 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2249 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2250 window.el.
2251 (replace_buffer_in_windows): Implement by calling
2252 Qreplace_buffer_in_windows.
2253 (replace_buffer_in_all_windows): Remove with some functionality
2254 moved into replace_buffer_in_windows_safely.
2255 (replace_buffer_in_windows_safely): New function.
2256 (select_window_norecord, select_frame_norecord): Move in front
2257 of run_window_configuration_change_hook. Remove now obsolete
2258 declarations.
2259 (Fset_window_buffer): Rewrite doc-string. Call
2260 Qrecord_window_buffer.
2261 (keys_of_window): Move binding for other-window to window.el.
2262
2263 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2264
2265 * dispextern.h (struct image): Replace data member, whose int_val
2266 and ptr_val fields were not used by anything, with a single
2267 lisp_val object.
2268
2269 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2270 (gif_clear_image, gif_load, imagemagick_load_image)
2271 (gs_clear_image, gs_load): Callers changed.
2272
2273 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2274
2275 * buffer.h: Include <time.h>, for time_t.
2276 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2277
2278 Fix minor problems found by static checking.
2279
2280 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2281
2282 Make identifiers static if they are not used in other modules.
2283 * data.c (Qcompiled_function, Qframe, Qvector):
2284 * image.c (QimageMagick, Qsvg):
2285 * minibuf.c (Qmetadata):
2286 * window.c (resize_window_check, resize_root_window): Now static.
2287 * window.h (resize_window_check, resize_root_window): Remove decls.
2288
2289 * window.c (window_deletion_count, delete_deletable_window):
2290 Remove; unused.
2291 (window_body_lines): Now static.
2292 (Fdelete_other_windows_internal): Mark vars as initialized.
2293 Make sure 'resize_failed' is initialized.
2294 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2295 (resize_window_apply): Remove unused local.
2296 * window.h (delete_deletable_window): Remove decl.
2297
2298 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2299 (imagemagick_load_image): Fix pointer signedness problem by changing
2300 last arg from unsigned char * to char *. All uses changed.
2301 Also, fix a local for similar reasons.
2302 Remove unused locals. Remove locals to avoid shadowing.
2303 (fn_rsvg_handle_free): Remove; unused.
2304 (svg_load, svg_load_image): Fix pointer signedness problem.
2305 (imagemagick_load_image): Don't use garbage pointer image_wand.
2306
2307 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2308
2309 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2310
2311 * image.c (gif_load): Fix omitted cast error introduced by
2312 2011-06-06 change.
2313
2314 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2315
2316 * window.h (resize_proportionally, orig_total_lines)
2317 (orig_top_line): Remove from window structure.
2318 (set_window_height, set_window_width, change_window_heights)
2319 (Fdelete_window): Remove prototypes.
2320 (resize_frame_windows): Remove duplicate declaration.
2321
2322 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2323
2324 * window.h (resize_frame_windows, resize_window_check)
2325 (delete_deletable_window, resize_root_window)
2326 (resize_frame_windows): Declare prototypes.
2327
2328 * window.c (resize_window_apply): Make definition be "static" to
2329 match the prototype.
2330
2331 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2332
2333 * window.c: Remove declarations of Qwindow_size_fixed,
2334 window_min_size_1, window_min_size_2, window_min_size,
2335 size_window, window_fixed_size_p, enlarge_window, delete_window.
2336 Remove static from declaration of Qdelete_window, it's
2337 temporarily needed by Fbury_buffer.
2338 (replace_window): Don't assign orig_top_line and
2339 orig_total_lines.
2340 (Fdelete_window, delete_window): Remove. Window deletion is
2341 handled by window.el.
2342 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
2343 Fdelete_window calls with calls to Qdelete_window.
2344 (Fdelete_other_windows): Remove. Deleting other windows is
2345 handled by window.el.
2346 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2347 handled in window.el.
2348 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2349 Window minimum sizes are handled in window.el.
2350 (shrink_windows, size_window, set_window_height)
2351 (set_window_width, change_window_heights, window_height)
2352 (window_width, CURBEG, CURSIZE, enlarge_window)
2353 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2354 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2355 handled in window.el.
2356 (make_dummy_parent): Rename to make_parent_window and give it a
2357 second argument horflag.
2358 (make_window): Don't set resize_proportionally any more.
2359 (Fsplit_window): Remove. Windows are split in window.el.
2360 (save_restore_action, save_restore_orig_size)
2361 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2362 Resize mini windows in window.el.
2363 (grow_mini_window, shrink_mini_window): Implement by calling
2364 Qresize_root_window_vertically, resize_window_check and
2365 resize_window_apply.
2366 (saved_window, Fset_window_configuration, save_window_save): Do
2367 not handle orig_top_line, orig_total_lines, and
2368 resize_proportionally.
2369 (window_min_height, window_min_width): Move to window.el.
2370 (keys_of_window): Move bindings for delete-other-windows,
2371 split-window, delete-window and enlarge-window to window.el.
2372
2373 * buffer.c: Temporarily extern Qdelete_window.
2374 (Fbury_buffer): Temporarily call Qdelete_window instead of
2375 Fdelete_window (Fbury_buffer will move to window.el soon).
2376
2377 * frame.c (set_menu_bar_lines_1): Remove code handling
2378 orig_top_line and orig_total_lines.
2379
2380 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2381 set_window_height but set heights directly.
2382 (change_frame_size_1): Use resize_frame_windows.
2383
2384 * xdisp.c (init_xdisp): Don't use set_window_height but set
2385 heights directly.
2386
2387 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
2388 resize_frame_windows instead of change_window_heights and run
2389 run_window_configuration_change_hook.
2390
2391 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2392 instead of change_window_heights and run
2393 run_window_configuration_change_hook.
2394
2395 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2396
2397 * window.c (replace_window): Rename second argument REPLACEMENT to
2398 NEW. New third argument SETFLAG. Rewrite.
2399 (delete_window, make_dummy_parent): Call replace_window with
2400 third argument 1.
2401 (window_list_1): Move down in code.
2402 (run_window_configuration_change_hook): Move set_buffer part
2403 before select_frame_norecord part in order to unwind correctly.
2404 Rename count1 to count.
2405 (recombine_windows, delete_deletable_window, resize_root_window)
2406 (Fdelete_other_windows_internal)
2407 (Frun_window_configuration_change_hook, make_parent_window)
2408 (resize_window_check, resize_window_apply, Fresize_window_apply)
2409 (resize_frame_windows, Fsplit_window_internal)
2410 (Fdelete_window_internal, Fresize_mini_window_internal): New
2411 functions.
2412 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2413
2414 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2415
2416 * window.h (window): Add some new members to window structure -
2417 normal_lines, normal_cols, new_total, new_normal, clone_number,
2418 splits, nest, prev_buffers, next_buffers.
2419 (WINDOW_TOTAL_SIZE): Move here from window.c.
2420 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2421
2422 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2423 Remove.
2424 (make_dummy_parent): Set new members of windows structure.
2425 (make_window): Move down in code. Handle new members of window
2426 structure.
2427 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2428 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2429 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2430 (Fset_window_prev_buffers, Fwindow_next_buffers)
2431 (Fset_window_next_buffers, Fset_window_clone_number): New
2432 functions.
2433 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2434 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2435 Doc-string fixes.
2436 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2437 Argument WINDOW can be now internal window too.
2438 (Fwindow_use_time): Move up in code.
2439 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2440 Rewrite doc-string.
2441 (Fset_window_configuration, saved_window)
2442 (Fcurrent_window_configuration, save_window_save): Handle new
2443 members of window structure.
2444 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2445 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2446 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2447 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2448 Qget_mru_window, Qresize_root_window,
2449 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2450 Qauto_buffer_name; staticpro them.
2451
2452 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2453
2454 * window.c (Fwindow_total_size, Fwindow_left_column)
2455 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2456 (Fwindow_list_1): New functions.
2457 (window_box_text_cols): Replace with window_body_cols.
2458 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2459 window_body_cols instead of window_box_text_cols.
2460 (delete_window, Fset_window_configuration): Call
2461 delete_all_subwindows with window as argument.
2462 (delete_all_subwindows): Take a window as argument and not a
2463 structure. Rewrite.
2464 (window_loop): Remove handling of GET_LRU_WINDOW and
2465 GET_LARGEST_WINDOW.
2466 (Fget_lru_window, Fget_largest_window): Move to window.el.
2467
2468 * window.h: Extern window_body_cols instead of
2469 window_box_text_cols. delete_all_subwindows now takes a
2470 Lisp_Object as argument.
2471
2472 * indent.c (compute_motion, Fcompute_motion): Use
2473 window_body_cols instead of window_box_text_cols.
2474
2475 * frame.c (delete_frame): Call delete_all_subwindows with root
2476 window as argument.
2477
2478 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2479
2480 * fns.c (Fputhash): Document return value.
2481
2482 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2483
2484 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2485
2486 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2487
2488 Cons<->int and similar integer overflow fixes (Bug#8794).
2489
2490 Check for overflow when converting integer to cons and back.
2491 * charset.c (Fdefine_charset_internal, Fdecode_char):
2492 Use cons_to_unsigned to catch overflow.
2493 (Fencode_char): Use INTEGER_TO_CONS.
2494 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2495 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2496 * data.c (long_to_cons, cons_to_long): Remove.
2497 (cons_to_unsigned, cons_to_signed): New functions.
2498 These signal an error for invalid or out-of-range values.
2499 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2500 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2501 * font.c (Ffont_variation_glyphs):
2502 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2503 * lisp.h: Include <intprops.h>.
2504 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2505 (cons_to_signed, cons_to_unsigned): New decls.
2506 (long_to_cons, cons_to_long): Remove decls.
2507 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2508 (Fprimitive_undo): Use CONS_TO_INTEGER.
2509 * xfns.c (Fx_window_property): Likewise.
2510 * xselect.c: Include <limits.h>.
2511 (x_own_selection, selection_data_to_lisp_data):
2512 Use INTEGER_TO_CONS.
2513 (x_handle_selection_request, x_handle_selection_clear)
2514 (x_get_foreign_selection, Fx_disown_selection_internal)
2515 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2516 (lisp_data_to_selection_data): Use cons_to_unsigned.
2517 (x_fill_property_data): Use cons_to_signed.
2518 Report values out of range.
2519
2520 Check for buffer and string overflow more precisely.
2521 * buffer.h (BUF_BYTES_MAX): New macro.
2522 * lisp.h (STRING_BYTES_MAX): New macro.
2523 * alloc.c (Fmake_string):
2524 * character.c (string_escape_byte8):
2525 * coding.c (coding_alloc_by_realloc):
2526 * doprnt.c (doprnt):
2527 * editfns.c (Fformat):
2528 * eval.c (verror):
2529 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2530 since they may not be the same number.
2531 * editfns.c (Finsert_char):
2532 * fileio.c (Finsert_file_contents):
2533 Likewise for BUF_BYTES_MAX.
2534
2535 * image.c: Use ptrdiff_t, not int, for sizes.
2536 (slurp_file): Switch from int to ptrdiff_t.
2537 All uses changed.
2538 (slurp_file): Check that file size fits in both size_t (for
2539 malloc) and ptrdiff_t (for sanity and safety).
2540
2541 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2542 if b->modtime has its maximal value.
2543
2544 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2545
2546 Don't assume time_t can fit into int.
2547 * buffer.h (struct buffer.modtime): Now time_t, not int.
2548 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2549 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2550
2551 Minor fixes for signed vs unsigned integers.
2552 * character.h (MAYBE_UNIFY_CHAR):
2553 * charset.c (maybe_unify_char):
2554 * keyboard.c (read_char, reorder_modifiers):
2555 XINT -> XFASTINT, since the integer must be nonnegative.
2556 * ftfont.c (ftfont_spec_pattern):
2557 * keymap.c (access_keymap, silly_event_symbol_error):
2558 XUINT -> XFASTINT, since the integer must be nonnegative.
2559 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2560 since it makes no difference and we prefer signed.
2561 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2562 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2563 nonnegative.
2564
2565 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2566
2567 * window.h (Fwindow_frame): Declare.
2568
2569 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2570
2571 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2572 (SPARE_MEMORY): Always define.
2573 (LARGE_REQUEST): Remove.
2574 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2575
2576 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2577
2578 * lisp.h: Move EXFUNS for Fframe_root_window,
2579 Fframe_first_window and Fset_frame_selected_window to window.h.
2580
2581 * window.h: Move EXFUNS for Fframe_root_window,
2582 Fframe_first_window and Fset_frame_selected_window here from
2583 lisp.h.
2584
2585 * frame.c (Fwindow_frame, Fframe_first_window)
2586 (Fframe_root_window, Fframe_selected_window)
2587 (Fset_frame_selected_window): Move to window.c.
2588 (Factive_minibuffer_window): Move to minibuf.c.
2589 (Fother_visible_frames_p): New function.
2590
2591 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2592
2593 * window.c (decode_window, decode_any_window): Move up in code.
2594 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2595 (inhibit_frame_unsplittable): Remove unused variable.
2596 (Fwindow_buffer): Move up and rewrite doc-string.
2597 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2598 (Fwindow_prev): New functions.
2599 (Fwindow_frame): Move here from frame.c. Accept any window as
2600 argument.
2601 (Fframe_root_window, Fframe_first_window)
2602 (Fframe_selected_window): Move here from frame.c. Accept frame
2603 or arbitrary window as argument. Update doc-strings.
2604 (Fminibuffer_window): Move up in code.
2605 (Fwindow_minibuffer_p): Move up in code and simplify.
2606 (Fset_frame_selected_window): Move here from frame.c.
2607 Marginal rewrite.
2608 (Fselected_window, select_window, Fselect_window): Move up in
2609 code. Minor doc-string fixes.
2610
2611 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2612
2613 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2614 Do not assume that spare memory exists; that assumption is valid
2615 only if SYSTEM_MALLOC.
2616 (LARGE_REQUEST): New macro, so that the issue of large requests
2617 is separated from the issue of spare memory.
2618
2619 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2620
2621 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2622 format. (Bug#8806)
2623
2624 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2625
2626 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2627 before statements.
2628
2629 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2630
2631 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2632
2633 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2634
2635 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2636 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2637
2638 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2639
2640 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2641
2642 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2643
2644 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2645 (x_clipboard_manager_save): Add return value.
2646 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2647 New error handlers.
2648 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2649 Obey Vx_select_enable_clipboard_manager. Catch errors in
2650 x_clipboard_manager_save (Bug#8779).
2651 (Vx_select_enable_clipboard_manager): New variable.
2652 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2653
2654 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2655
2656 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2657
2658 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2659
2660 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2661 in the current matrix if keep_current_p is non-zero.
2662
2663 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2664
2665 * bidi.c (bidi_level_of_next_char): Fix last change.
2666
2667 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2668
2669 Support bidi reordering of text covered by display properties.
2670
2671 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2672 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2673 (bidi_cache_search, bidi_cache_iterator_state)
2674 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2675 (bidi_level_of_next_char, bidi_move_to_visually_next):
2676 Support character positions inside a run of characters covered by a
2677 display string.
2678 (bidi_paragraph_init, bidi_resolve_explicit_1)
2679 (bidi_level_of_next_char): Call bidi_fetch_char and
2680 bidi_fetch_char_advance instead of FETCH_CHAR and
2681 FETCH_CHAR_ADVANCE.
2682 (bidi_init_it): Initialize new members.
2683 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2684 definitions.
2685 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2686 instead of using explicit *_CHAR codes.
2687 (bidi_resolve_explicit, bidi_resolve_weak):
2688 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2689 bidirectional text is supported only in multibyte buffers.
2690 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2691 it to initialize the frame_window_p member of struct bidi_it.
2692 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2693 (bidi_resolve_explicit, bidi_resolve_weak)
2694 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2695 bidi_it->nchars is non-positive.
2696 (bidi_level_of_next_char): Don't try to lookup the cache for the
2697 next/previous character if nothing is cached there yet, or if we
2698 were just reseat()'ed to a new position.
2699
2700 * xdisp.c (set_cursor_from_row): Set start and stop points
2701 according to the row's direction when priming the loop that looks
2702 for the glyph on which to display cursor.
2703 (single_display_spec_intangible_p): Function deleted.
2704 (display_prop_intangible_p): Reimplement to call
2705 handle_display_spec instead of single_display_spec_intangible_p.
2706 Accept 3 additional arguments needed by handle_display_spec.
2707 This fixes incorrect cursor motion across display property with complex
2708 values: lists, `(when COND...)' forms, etc.
2709 (single_display_spec_string_p): Support property values that are
2710 lists with the argument STRING its top-level element.
2711 (display_prop_string_p): Fix the condition for processing a
2712 property that is a list to be consistent with handle_display_spec.
2713 (handle_display_spec): New function, refactored from the
2714 last portion of handle_display_prop.
2715 (compute_display_string_pos): Accept additional argument
2716 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2717 value of a `display' property is a "replacing spec".
2718 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2719 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2720 the display property, but just return a value indicating whether
2721 the display property will replace the characters it covers.
2722 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2723 frame_window_p members of struct bidi_it.
2724 (compute_display_string_pos, compute_display_string_end):
2725 New functions.
2726 (push_it): Accept second argument POSITION, where pop_it should
2727 jump to continue iteration.
2728 (reseat_1): Initialize bidi_it.disp_pos.
2729
2730 * keyboard.c (adjust_point_for_property): Adjust the call to
2731 display_prop_intangible_p to its new signature.
2732
2733 * dispextern.h (struct bidi_it): New member frame_window_p.
2734 (bidi_init_it): Update prototypes.
2735 (display_prop_intangible_p): Update prototype.
2736 (compute_display_string_pos, compute_display_string_end):
2737 Declare prototypes.
2738 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2739 EMACS_INT.
2740
2741 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2742
2743 Malloc failure behavior now depends on size of allocation.
2744 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2745 * lisp.h: Change signatures accordingly.
2746 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2747 All callers changed. (Bug#8762)
2748
2749 * gnutls.c: Use Emacs's memory allocators.
2750 Without this change, the gnutls library would invoke malloc etc.
2751 directly, which causes problems on non-SYNC_INPUT hosts, and which
2752 runs afoul of improving memory_full behavior. (Bug#8761)
2753 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2754 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2755 xfree instead of the default malloc, realloc, free.
2756 (Fgnutls_boot): No need to check for memory allocation failure,
2757 since xmalloc does that for us.
2758
2759 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2760 * category.c (hash_get_category_set):
2761 * ccl.c (ccl_driver):
2762 * charset.c (Fdefine_charset_internal):
2763 * charset.h (struct charset.hash_index):
2764 * composite.c (get_composition_id, gstring_lookup_cache)
2765 (composition_gstring_put_cache):
2766 * composite.h (struct composition.hash_index):
2767 * dispextern.h (struct image.hash):
2768 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2769 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2770 (hashfn_equal, hashfn_user_defined, make_hash_table)
2771 (maybe_resize_hash_table, hash_lookup, hash_put)
2772 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2773 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2774 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2775 * image.c (make_image, search_image_cache, lookup_image)
2776 (xpm_put_color_table_h):
2777 * lisp.h (struct Lisp_Hash_Table):
2778 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2779 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2780 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2781 * alloc.c (allocate_vectorlike):
2782 Check for overflow in vector size calculations.
2783 * ccl.c (ccl_driver):
2784 Check for overflow when converting EMACS_INT to int.
2785 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2786 need to be updated by these changes.
2787 * fns.c (make_hash_table, maybe_resize_hash_table):
2788 Check for integer overflow with large hash tables.
2789 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2790 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2791 (SXHASH_REDUCE): New macro.
2792 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2793 Use it instead of discarding useful hash info with large hash values.
2794 (sxhash_float): New function.
2795 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2796 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2797 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2798 Rewrite to use FIXNUM_BITS, as this simplifies things.
2799 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2800 Adjust signatures to match updated version of code.
2801 (consing_since_gc): Now EMACS_INT, since a single hash table can
2802 use more than INT_MAX bytes.
2803
2804 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2805
2806 Make it possible to build with GCC-4.6+ -O2 -flto.
2807
2808 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2809
2810 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2811
2812 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2813 Call minibuffer-inactive-mode.
2814
2815 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2816
2817 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2818 Update dependencies.
2819
2820 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2821
2822 * data.c (init_data): Remove code for UTS, this system is not
2823 supported anymore.
2824
2825 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2826
2827 Don't force ./temacs to start in terminal mode.
2828
2829 * frame.c (make_initial_frame): Initialize faces in all cases, not
2830 only when CANNOT_DUMP is defined.
2831 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2832
2833 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2834
2835 * dispnew.c (add_window_display_history): Use const for the string
2836 pointer. Remove declaration, not needed.
2837
2838 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2839
2840 Use 'inline', not 'INLINE'.
2841 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2842 * alloc.c, fontset.c (INLINE): Remove.
2843 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2844 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2845 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2846 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2847 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2848
2849 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2850
2851 Make it possible to run ./temacs.
2852
2853 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2854 syms_of_callproc does the same thing. Remove test for
2855 "initialized", do it in the caller.
2856 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2857
2858 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2859
2860 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2861 (read_minibuf): Use get_minibuffer.
2862 (syms_of_minibuf): Use DEFSYM.
2863 (Qmetadata): New var.
2864 * data.c (Qbuffer): Don't make it static.
2865 (syms_of_data): Use DEFSYM.
2866
2867 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2868
2869 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2870 (CCL_CODE_MIN): New macro.
2871
2872 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2873
2874 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2875
2876 * eval.c (Qdebug): Now static.
2877 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2878 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2879 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2880
2881 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2882
2883 * image.c: Various fixes to ImageMagick code comments.
2884 (Fimagemagick_types): Doc fix.
2885
2886 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2887
2888 Minor fixes prompted by GCC 4.6.0 warnings.
2889
2890 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2891
2892 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2893 (x_clipboard_manager_save_all): Move extern decl to ...
2894 * xterm.h: ... here, so that it can be checked for consistency.
2895
2896 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2897
2898 * xselect.c (x_clipboard_manager_save_frame)
2899 (x_clipboard_manager_save_all): New functions.
2900 (Fx_clipboard_manager_save): Lisp function deleted.
2901
2902 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2903 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2904
2905 * xterm.h: Update prototype.
2906
2907 2011-05-28 William Xu <william.xwl@gmail.com>
2908
2909 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2910 exiting (Bug#8239).
2911
2912 2011-05-28 Jim Meyering <meyering@redhat.com>
2913
2914 Avoid a sign-extension bug in crypto_hash_function.
2915 * fns.c (to_uchar): Define.
2916 (crypto_hash_function): Use it to convert some newly-signed
2917 variables to unsigned, to avoid sign-extension bugs. For example,
2918 without this change, (md5 "truc") would evaluate to
2919 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2920 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2921 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2922
2923 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2924
2925 Integer overflow fixes.
2926
2927 * dbusbind.c: Serial number integer overflow fixes.
2928 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2929 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2930 to hold a serial number that is too large for a fixnum.
2931 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2932 Check for serial numbers out of range. Decode any serial number
2933 that was so large that it became a float. (Bug#8722)
2934
2935 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2936 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2937 Use XFASTINT rather than XUINT when numbers are nonnegative.
2938 (xd_append_arg, Fdbus_method_return_internal):
2939 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2940 arguments, check that Lisp number is nonnegative, rather than
2941 silently wrapping negative numbers around. (Bug#8722)
2942 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2943 (Bug#8722)
2944
2945 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2946
2947 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2948
2949 ccl: add integer overflow checks
2950 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2951 (IN_INT_RANGE): New macros.
2952 (ccl_driver): Use them to check for integer overflow when
2953 decoding a CCL program. Many of the new checks are whether XINT (x)
2954 fits in int; it doesn't always, on 64-bit hosts. The new version
2955 doesn't catch all possible integer overflows, but it's an
2956 improvement. (Bug#8719)
2957
2958 * alloc.c (make_event_array): Use XINT, not XUINT.
2959 There's no need for unsigned here.
2960
2961 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2962 This follows up to the 2011-05-06 change that substituted uintptr_t
2963 for EMACS_INT. This case wasn't caught back then.
2964
2965 Rework Fformat to avoid integer overflow issues.
2966 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2967 now (part of C89). Include <verify.h>.
2968 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2969 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2970 (Fformat): Avoid the prepass trying to compute sizes; it was only
2971 approximate and thus did not catch overflow reliably. Instead, walk
2972 through the format just once, formatting and computing sizes as we go,
2973 checking for integer overflow at every step, and allocating a larger
2974 buffer as needed. Keep track separately whether the format is
2975 multibyte. Keep only the most-recently calculated precision, rather
2976 than them all. Record whether each argument has been converted to
2977 string. Use EMACS_INT, not int, for byte and char and arg counts.
2978 Support field widths and precisions larger than INT_MAX. Avoid
2979 sprintf's undefined behavior with conversion specifications such as %#d
2980 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2981 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2982 formatting out-of-range floating point numbers with int
2983 formats. (Bug#8668)
2984
2985 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2986
2987 * data.c: Avoid integer truncation in expressions involving floats.
2988 * data.c: Include <intprops.h>.
2989 (arith_driver): When there's an integer overflow in an expression
2990 involving floating point, convert the integers to floating point
2991 so that the resulting value does not suffer from catastrophic
2992 integer truncation. For example, on a 64-bit host (* 4
2993 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2994 Do not rely on undefined behavior after integer overflow.
2995
2996 merge count_size_as_multibyte, parse_str_to_multibyte
2997 * character.c, character.h (count_size_as_multibyte):
2998 Rename from parse_str_to_multibyte; all uses changed.
2999 Check for integer overflow.
3000 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3001 since it's now a duplicate of the other. This is more of
3002 a character than a buffer op, so better that it's in character.c.
3003 * fns.c, print.c: Adjust to above changes.
3004
3005 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3006
3007 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3008
3009 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3010
3011 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3012 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3013 (x_clipboard_manager_save): Now static.
3014 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3015
3016 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3017 (crypto_hash_function): Now static.
3018 Fix pointer signedness problems. Avoid unnecessary initializations.
3019
3020 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3021
3022 * termhooks.h (Vselection_alist): Make it terminal-local.
3023
3024 * terminal.c (create_terminal): Initialize it.
3025
3026 * xselect.c: Support for clipboard managers.
3027 (Vselection_alist): Move to termhooks.h as terminal-local var.
3028 (LOCAL_SELECTION): New macro.
3029 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3030 (symbol_to_x_atom): Remove gratuitous arg.
3031 (x_handle_selection_request, lisp_data_to_selection_data)
3032 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3033 (x_own_selection, x_get_local_selection, x_convert_selection):
3034 New arg, specifying work frame. Use terminal-local Vselection_alist.
3035 (some_frame_on_display): Delete unused function.
3036 (Fx_own_selection_internal, Fx_get_selection_internal)
3037 (Fx_disown_selection_internal, Fx_selection_owner_p)
3038 (Fx_selection_exists_p): New optional frame arg.
3039 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3040 (x_handle_selection_clear): Don't treat other terminals with the
3041 same keyboard specially. Use the terminal-local Vselection_alist.
3042 (x_clear_frame_selections): Use Frun_hook_with_args.
3043
3044 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3045
3046 * xterm.h: Add support for those atoms.
3047
3048 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3049
3050 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3051 (converted_selections, conversion_fail_tag): New global variables.
3052 (x_selection_request_lisp_error): Free the above.
3053 (x_get_local_selection): Remove unnecessary code.
3054 (x_reply_selection_request): Args changed; handle arbitrary array
3055 of converted selections stored in converted_selections.
3056 Separate the XChangeProperty and SelectionNotify steps.
3057 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3058 (x_convert_selection): New function.
3059 (x_handle_selection_event): Simplify.
3060 (x_get_foreign_selection): Don't ignore incoming requests while
3061 waiting for an answer; this will fail when we implement
3062 SAVE_TARGETS, and seems unnecessary anyway.
3063 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3064 (Vx_sent_selection_functions): Doc fix.
3065
3066 2011-05-26 Leo Liu <sdl.web@gmail.com>
3067
3068 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3069
3070 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3071
3072 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3073
3074 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3075 for fringe update if it has periodic bitmap.
3076 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3077 and fringe_bitmap_periodic_p.
3078
3079 * fringe.c (get_fringe_bitmap_data): New function.
3080 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3081 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3082 row. Mark glyph row for fringe update if periodicity changed.
3083
3084 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3085 for fringe update unless it has periodic bitmap.
3086
3087 2011-05-25 Kenichi Handa <handa@m17n.org>
3088
3089 * xdisp.c (get_next_display_element): Set correct it->face_id for
3090 a static composition.
3091
3092 2011-05-24 Leo Liu <sdl.web@gmail.com>
3093
3094 * deps.mk (fns.o):
3095 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3096
3097 * fns.c (crypto_hash_function, Fsha1): New function.
3098 (Fmd5): Use crypto_hash_function.
3099 (syms_of_fns): Add Ssha1.
3100
3101 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3102
3103 * gnutls.c: Remove unused macros.
3104 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3105 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3106 Remove macros that are defined and never used.
3107 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3108
3109 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3110
3111 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3112 (Fx_get_selection_internal): Minor cleanup.
3113 (Fx_own_selection_internal): Rename arguments for consistency with
3114 select.el.
3115
3116 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3117
3118 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3119
3120 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3121
3122 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3123
3124 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3125
3126 * dispnew.c (scrolling_window): Don't exclude the case that the
3127 last enabled row in the desired matrix touches the bottom boundary.
3128
3129 2011-05-21 Glenn Morris <rgm@gnu.org>
3130
3131 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3132 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3133 and add some more files.
3134
3135 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3136
3137 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3138 report_file_error introduced by the change from 2011-05-07.
3139
3140 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3141
3142 * systime.h (Time): Define only if emacs is defined.
3143 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3144 where the include path doesn't have X11/X.h by default. See
3145 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3146
3147 2011-05-20 Kenichi Handa <handa@m17n.org>
3148
3149 * composite.c (find_automatic_composition): Fix previous change.
3150
3151 2011-05-20 Glenn Morris <rgm@gnu.org>
3152
3153 * lisp.mk: New file, split from Makefile.in.
3154 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3155 (shortlisp): Remove.
3156 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3157
3158 2011-05-19 Glenn Morris <rgm@gnu.org>
3159
3160 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3161 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3162 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3163 (lisp): Set the order to that of loadup.el.
3164 (shortlisp): Make it a copy of $lisp.
3165 (SOME_MACHINE_LISP): Remove.
3166 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3167 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3168
3169 2011-05-18 Kenichi Handa <handa@m17n.org>
3170
3171 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3172 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3173 (find_automatic_composition): Mostly rewrite for efficiency.
3174
3175 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3176
3177 * makefile.w32-in: Update dependencies.
3178
3179 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3180
3181 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3182 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3183
3184 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3185
3186 Fix some integer overflow issues, such as string length overflow.
3187
3188 * insdel.c (count_size_as_multibyte): Check for string overflow.
3189
3190 * character.c (lisp_string_width): Check for string overflow.
3191 Use EMACS_INT, not int, for string indexes and lengths; in
3192 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3193 the resulting string length overflows an EMACS_INT; instead,
3194 report a string overflow if no precision given. When checking for
3195 precision exhaustion, use a check that cannot possibly have
3196 integer overflow. (Bug#8675)
3197 * character.h (lisp_string_width): Adjust to new signature.
3198
3199 * alloc.c (string_overflow): New function.
3200 (Fmake_string): Use it. This doesn't change behavior, but saves
3201 a few bytes and will simplify future changes.
3202 * character.c (string_escape_byte8): Likewise.
3203 * lisp.h (string_overflow): New decl.
3204
3205 Fixups, following up to the user-interface timestamp change.
3206 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3207 for UI timestamps, instead of unsigned long.
3208 * msdos.c (mouse_get_pos): Likewise.
3209 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3210 * w32gui.h (Time): Define by including "systime.h" rather than by
3211 declaring it ourselves. (Bug#8664)
3212
3213 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3214 * image.c (clear_image_cache): Likewise.
3215
3216 * term.c (term_mouse_position): Don't assume time_t wraparound.
3217
3218 Be more systematic about user-interface timestamps.
3219 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3220 and sometimes 'EMACS_UINT', to represent these timestamps.
3221 This change causes it to use 'Time' uniformly, as that's what X uses.
3222 This makes the code easier to follow, and makes it easier to catch
3223 integer overflow bugs such as Bug#8664.
3224 * frame.c (Fmouse_position, Fmouse_pixel_position):
3225 Use Time, not unsigned long, for user-interface timestamps.
3226 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3227 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3228 * keyboard.h (last_event_timestamp): Likewise.
3229 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3230 * menu.h (xmenu_show): Likewise.
3231 * term.c (term_mouse_position): Likewise.
3232 * termhooks.h (struct input_event.timestamp): Likewise.
3233 (struct terminal.mouse_position_hook): Likewise.
3234 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3235 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3236 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3237 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3238 what it was before.
3239 * menu.h, termhooks.h: Include "systime.h", for Time.
3240
3241 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3242 Don't assume that the difference between two unsigned long values
3243 can fit into an integer. At this point, we know button_down_time
3244 <= event->timestamp, so the difference must be nonnegative, so
3245 there's no need to cast the result if double-click-time is
3246 nonnegative, as it should be; check that it's nonnegative, just in
3247 case. This bug is triggered when events are more than 2**31 ms
3248 apart (about 25 days). (Bug#8664)
3249
3250 * xselect.c (last_event_timestamp): Remove duplicate decl.
3251 (x_own_selection): Remove needless cast to unsigned long.
3252
3253 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3254 that always fit in int. Use a sentinel instead of a counter, to
3255 avoid a temp and to allay GCC's concerns about possible int overflow.
3256 * frame.h (struct frame): Use int for menu_bar_items_used
3257 instead of EMACS_INT, since it always fits in int.
3258
3259 * menu.c (grow_menu_items): Check for int overflow.
3260
3261 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3262
3263 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3264 Before, the code was not consistent. These values cannot exceed
3265 2**31 - 1 so there's no need to make them unsigned.
3266 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3267 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3268 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3269 as modifiers.
3270 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3271
3272 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3273 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3274 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3275 presumably because the widths might not match.
3276
3277 * window.c (size_window): Avoid needless test at loop start.
3278
3279 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3280
3281 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3282
3283 2011-05-12 Drew Adams <drew.adams@oracle.com>
3284
3285 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3286
3287 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3288
3289 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3290 `width' to `bar_area_x' and `bar_area_width', respectively.
3291 (x_scroll_run): Take account of fringe background extension.
3292
3293 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3294 Rename local vars `left' and `width' to `bar_area_x' and
3295 `bar_area_width', respectively.
3296 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3297 background extension.
3298
3299 2011-05-10 Jim Meyering <meyering@redhat.com>
3300
3301 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3302
3303 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3304
3305 * image.c (Finit_image_library): Return t for built-in image types,
3306 like pbm and xbm. (Bug#8640)
3307
3308 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3309
3310 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3311
3312 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3313
3314 * w32console.c (Fset_screen_color): Doc fix.
3315 (Fget_screen_color): New function.
3316 (syms_of_ntterm): Defsubr it.
3317
3318 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3319 unlink the temporary file if Fcall_process didn't create it in the
3320 first place.
3321 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3322 child process will be redirected to a file specified with `:file'.
3323 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3324 cue to call_process_cleanup not to close that handle.
3325
3326 2011-05-07 Ben Key <bkey76@gmail.com>
3327
3328 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3329 one of two shell specific rules, either bootstrap-temacs-CMD or
3330 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3331 to the previous implementation of the bootstrap-temacs rule.
3332 The bootstrap-temacs-CMD rule is similar to the previous
3333 implementation of the bootstrap-temacs rule except that it
3334 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3335 variable.
3336
3337 These changes, along with some changes to nt/configure.bat,
3338 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3339 earlier fix to add support for --cflags and --ldflags options
3340 that include quotes so that it works whether make uses cmd or
3341 sh as the shell.
3342
3343 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3344
3345 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3346 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3347 is a constant.
3348 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3349 a string. Handle both cases.
3350 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3351 (Fdbus_register_method): Use Qinvalid_function.
3352
3353 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3354
3355 * makefile.w32-in: Update dependencies.
3356 (LISP_H): Add inttypes.h and stdin.h.
3357 (PROCESS_H): Add unistd.h.
3358
3359 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3360
3361 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3362 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3363
3364 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3365
3366 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3367
3368 * term.c (vfatal): Remove stray call to va_end.
3369 It's not needed and the C Standard doesn't allow it here anyway.
3370
3371 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3372 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3373
3374 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3375 bytes.
3376
3377 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3378
3379 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3380
3381 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3382
3383 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3384
3385 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3386
3387 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3388 * charset.c (Fdefine_charset_internal): Don't initialize
3389 charset.code_space[15]. The value was garbage, on hosts with
3390 32-bit int (Bug#8600).
3391
3392 * lread.c (read_integer): Be more consistent with string-to-number.
3393 Use string_to_number to do the actual conversion; this avoids
3394 rounding errors and fixes some other screwups. Without this fix,
3395 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3396 (digit_to_number): Move earlier, for benefit of read_integer.
3397 Return -1 if the digit is out of range for the base, -2 if it is
3398 not a digit in any supported base. (Bug#8602)
3399
3400 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3401
3402 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3403 to match comment at start of function. This also removes a
3404 GCC warning about overflow in a 32+64-bit port.
3405
3406 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3407
3408 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3409 Reported by Stefan Monnier in
3410 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3411 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3412 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3413
3414 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3415 (EMACS_UINTPTR): Likewise, with uintptr_t.
3416
3417 * lisp.h: Prefer 64-bit EMACS_INT if available.
3418 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3419 on 32-bit hosts that have 64-bit int, so that they can access
3420 large files.
3421 However, temporarily disable this change unless the temporary
3422 symbol WIDE_EMACS_INT is defined.
3423
3424 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3425
3426 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3427 This removes an assumption that EMACS_INT and long are the same
3428 width as pointers. The assumption is true for Emacs porting targets
3429 now, but we want to make other targets possible.
3430 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3431 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3432 In the rest of the code, change types of integers that hold casted
3433 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3434 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3435 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3436 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3437 No need to cast type when ORing.
3438 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3439 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3440 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3441 assume EMACS_INT is the same width as char *.
3442 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3443 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3444 Remove no-longer-needed casts.
3445 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3446 (xg_tool_bar_help_callback, xg_make_tool_item):
3447 Use EMACS_INTPTR to hold an integer
3448 that will be cast to void *; this can avoid a GCC warning
3449 if EMACS_INT is not the same width as void *.
3450 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3451 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3452 (current_message_1, set_message_1):
3453 Use a local to convert to proper width without a cast.
3454 * xmenu.c (dialog_selection_callback): Likewise.
3455
3456 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3457 Also, don't assume VALBITS / RAND_BITS is less than 5,
3458 and don't rely on undefined behavior when shifting a 1 left into
3459 the sign bit.
3460 * lisp.h (get_random): Change signature to match.
3461
3462 * lread.c (hash_string): Use size_t, not int, for hash computation.
3463 Normally we prefer signed values; but hashing is special, because
3464 it's better to use unsigned division on hash table sizes so that
3465 the remainder is nonnegative. Also, size_t is the natural width
3466 for hashing into memory. The previous code used 'int', which doesn't
3467 retain enough info to hash well into very large tables.
3468 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3469
3470 * dbusbind.c: Don't possibly lose pointer info when converting.
3471 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3472 Use XPNTR rather than XHASH, so that the high-order bits of
3473 the pointer aren't lost when converting through void *.
3474
3475 * eval.c (Fautoload): Don't double-shift a pointer.
3476
3477 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3478
3479 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3480
3481 * gnutls.c (DEF_GNUTLS_FN):
3482 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3483
3484 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3485
3486 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3487 marker. (Bug#8610)
3488
3489 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3490
3491 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3492 New version that can reserve upto 2GB of heap space.
3493
3494 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3495
3496 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3497
3498 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3499
3500 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3501 `gnutls_certificate_set_x509_key_file'.
3502
3503 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3504
3505 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3506 Update dependencies.
3507
3508 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3509
3510 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3511 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3512 Remove unused parameter `fildes'.
3513 * process.c (read_process_output, send_process): Don't pass it.
3514
3515 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3516
3517 Fix previous change: the library cache is defined in w32.c.
3518 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3519 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3520
3521 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3522
3523 Implement dynamic loading of GnuTLS on Windows.
3524
3525 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3526 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3527 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3528 Declare.
3529
3530 * gnutls.c (Qgnutls_dll): Define.
3531 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3532 (gnutls_*): Declare function pointers.
3533 (init_gnutls_functions): New function to initialize function pointers.
3534 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3535 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3536 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3537 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3538 (emacs_gnutls_write, emacs_gnutls_read)
3539 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3540 (Fgnutls_available_p): New function.
3541 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3542 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3543 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3544
3545 * image.c: Include w32.h.
3546 (Vimage_type_cache): Delete.
3547 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3548 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3549 (w32_delayed_load): Move to w32.c.
3550
3551 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3552
3553 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3554 (w32_delayed_load): Move from image.c. When loading a library, record
3555 its filename in the :loaded-from property of the library id.
3556 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3557 Initialize and staticpro them.
3558 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3559
3560 * process.c: Include lisp.h before w32.h, not after.
3561 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3562 instead of gnutls_record_check_pending.
3563
3564 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3565
3566 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3567
3568 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3569 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3570 as passed in.
3571
3572 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3573
3574 * xterm.c (x_set_frame_alpha): Do not set property on anything
3575 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3576
3577 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3578
3579 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3580
3581 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3582
3583 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3584 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3585 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3586 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3587 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3588 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3589 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3590 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3591 (Qgnutls_bootprop_callbacks_verify): Make static.
3592
3593 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3594
3595 * callproc.c: Indentation fixup.
3596
3597 * sysdep.c (wait_for_termination_1): Make static.
3598 (wait_for_termination, interruptible_wait_for_termination):
3599 Move after wait_for_termination_1.
3600
3601 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3602
3603 * sysdep.c (interruptible_wait_for_termination): New function
3604 which is like wait_for_termination, but allows keyboard
3605 interruptions.
3606
3607 * callproc.c (Fcall_process): Add (:file "file") as an option for
3608 the STDOUT buffer.
3609 (Fcall_process_region): Ditto.
3610
3611 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3612
3613 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3614 rather than `XVECTOR (FOO)->size'.
3615
3616 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3617 inttypes.h, as a gnulib replacement is used if it not available in
3618 system headers.
3619
3620 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3621
3622 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3623 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3624 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3625
3626 * coding.c (coding_alloc_by_realloc): Error out if destination
3627 will grow beyond MOST_POSITIVE_FIXNUM.
3628 (decode_coding_emacs_mule): Abort if there isn't enough place in
3629 charbuf for the composition carryover bytes. Reserve an extra
3630 space for up to 2 characters produced in a loop.
3631 (decode_coding_iso_2022): Abort if there isn't enough place in
3632 charbuf for the composition carryover bytes.
3633
3634 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3635
3636 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3637 aborting when %lld or %lll format is passed.
3638 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3639 %llo or %llx format is passed. (Bug#8545)
3640
3641 * window.c (window_scroll_line_based): Use a marker instead of
3642 simple variables to record original value of point. (Bug#7952)
3643
3644 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3645 produced by %s or %c overflows available buffer space. (Bug#8545)
3646
3647 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3648
3649 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3650 (SIZE_MAX): Move defn after all includes, as they might #define it.
3651
3652 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3653
3654 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3655
3656 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3657
3658 * keyboard.c (Qdelayed_warnings_hook): Define.
3659 (command_loop_1): Run `delayed-warnings-hook'
3660 if Vdelayed_warnings_list is non-nil.
3661 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3662 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3663
3664 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3665
3666 * doprnt.c (doprnt): Don't return value smaller than the buffer
3667 size if the message was truncated. (Bug#8545).
3668
3669 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3670
3671 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3672 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3673
3674 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3675
3676 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3677
3678 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3679
3680 * makefile.w32-in: Update dependencies.
3681
3682 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3683
3684 Improve `doprnt' and its usage. (Bug#8545)
3685 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3686 `format_end'. Remove support for %l as a conversion specifier.
3687 Don't use xrealloc. Improve diagnostics when the %l size modifier
3688 is used. Update the commentary.
3689
3690 * eval.c (verror): Simplify calculation of size_t.
3691
3692 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3693 messages.
3694
3695 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3696
3697 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3698 change.
3699
3700 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3701
3702 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3703 This makes this file independent of the recent pseudovector change.
3704
3705 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3706
3707 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3708
3709 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3710 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3711 Remove unused local.
3712 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3713
3714 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3715 GCC 4.6.0 optimizes based on type-based alias analysis.
3716 For example, if b is of type struct buffer * and v of type struct
3717 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3718 != &v->size, and therefore "v->size = 1; b->size = 2; return
3719 v->size;" must therefore return 1. This assumption is incorrect
3720 for Emacs, since it type-puns struct Lisp_Vector * with many other
3721 types. To fix this problem, this patch adds a new type struct
3722 vectorlike_header that documents the constraints on layout of vectors
3723 and pseudovectors, and helps optimizing compilers not get fooled
3724 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3725 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3726 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3727 the size member.
3728 (XSETPVECTYPE): Rewrite in terms of new macro.
3729 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3730 This is a bit clearer, and further avoids the possibility of
3731 undesirable aliasing.
3732 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3733 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3734 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3735 since Lisp_Subr is a special case (no "next" field).
3736 (ASIZE): Now uses header.size rather than size.
3737 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3738 to avoid the hassle of writing XVECTOR (foo)->header.size.
3739 (struct vectorlike_header): New type.
3740 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3741 object, to help avoid aliasing.
3742 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3743 (SUBRP): Likewise, since Lisp_Subr is a special case.
3744 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3745 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3746 (struct Lisp_Hash_Table): Combine first two members into a single
3747 struct vectorlike_header member. All uses of "size" and "next" members
3748 changed to be "header.size" and "header.next".
3749 * buffer.h (struct buffer): Likewise.
3750 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3751 * frame.h (struct frame): Likewise.
3752 * process.h (struct Lisp_Process): Likewise.
3753 * termhooks.h (struct terminal): Likewise.
3754 * window.c (struct save_window_data, struct saved_window): Likewise.
3755 * window.h (struct window): Likewise.
3756 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3757 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3758 * buffer.c (init_buffer_once): Likewise.
3759 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3760 special case.
3761 * process.c (Fformat_network_address): Use local var for size,
3762 for brevity.
3763
3764 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3765
3766 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3767 * data.c (atof): Remove decl; no longer used or needed.
3768 (digit_to_number): Move to lread.c.
3769 (Fstring_to_number): Use new string_to_number function, to be
3770 consistent with how the Lisp reader treats infinities and NaNs.
3771 Do not assume that floating-point numbers represent EMACS_INT
3772 without losing information; this is not true on most 64-bit hosts.
3773 Avoid double-rounding errors, by insisting on integers when
3774 parsing non-base-10 numbers, as the documentation specifies.
3775 * lisp.h (string_to_number): New decl, replacing ...
3776 (isfloat_string): Remove.
3777 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3778 (read1): Do not accept +. and -. as integers; this
3779 appears to have been a coding error. Similarly, do not accept
3780 strings like +-1e0 as floating point numbers. Do not report
3781 overflow for integer overflows unless the base is not 10 which
3782 means we have no simple and reliable way to continue.
3783 Break out the floating-point parsing into a new
3784 function string_to_number, so that Fstring_to_number parses
3785 floating point numbers consistently with the Lisp reader.
3786 (digit_to_number): Move here from data.c. Make it static inline.
3787 (E_CHAR, EXP_INT): Remove, replacing with ...
3788 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3789 (string_to_number): New function, replacing isfloat_string.
3790 This function checks for valid syntax and produces the resulting
3791 Lisp float number too. Rework it so that string-to-number
3792 no longer mishandles examples like "1.0e+". Use strtoumax,
3793 so that overflow for non-base-10 numbers is reported only when
3794 there's no portable and simple way to convert to floating point.
3795
3796 * textprop.c (set_text_properties_1): Rewrite for clarity,
3797 and to avoid GCC warning about integer overflow.
3798
3799 * intervals.h (struct interval): Use EMACS_INT for members
3800 where EMACS_UINT might cause problems. See
3801 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3802 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3803 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3804 All uses changed.
3805 (offset_intervals): Tell GCC not to worry about length overflow
3806 when negating a negative length.
3807
3808 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3809 (overrun_check_free): Likewise.
3810
3811 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3812 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3813 word size.
3814
3815 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3816 (gnutls_make_error): Rename local to avoid shadowing.
3817 (gnutls_emacs_global_deinit): ifdef out; not used.
3818 (Fgnutls_boot): Use const for pointer to readonly storage.
3819 Comment out unused local. Fix pointer signedness problems.
3820
3821 * lread.c (openp): Don't stuff size_t into an 'int'.
3822 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3823 about possible signed overflow.
3824
3825 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3826 (GDK_KEY_g): Don't define if already defined.
3827 (xg_prepare_tooltip): Avoid pointer signedness problem.
3828 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3829
3830 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3831 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3832
3833 * xfns.c (Fx_window_property): Simplify a bit,
3834 to make a bit faster and to avoid GCC 4.6.0 warning.
3835 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3836
3837 * fns.c (internal_equal): Don't assume size_t fits in int.
3838
3839 * alloc.c (compact_small_strings): Tighten assertion a little.
3840
3841 Replace pEd with more-general pI, and fix some printf arg casts.
3842 * lisp.h (pI): New macro, generalizing old pEd macro to other
3843 conversion specifiers. For example, use "...%"pI"d..." rather
3844 than "...%"pEd"...".
3845 (pEd): Remove. All uses replaced with similar uses of pI.
3846 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3847 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3848 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3849 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3850 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3851 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3852 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3853 64-bit hosts.
3854 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3855 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3856 * print.c (safe_debug_print, print_object): Likewise.
3857 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3858 to int.
3859 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3860 avoiding the 0 flag, which is not portable.
3861 * process.c (Fmake_network_process): Use pI to avoid cast.
3862 * region-cache.c (pp_cache): Likewise.
3863 * xdisp.c (decode_mode_spec): Likewise.
3864 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3865 behavior on 64-bit hosts with printf arg.
3866 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3867 (x_stop_queuing_selection_requests): Likewise.
3868 (x_get_window_property): Don't truncate byte count to an 'int'
3869 when tracing.
3870
3871 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3872 here, since it parses constructs like leading '-' and spaces,
3873 which are not wanted; and it overflows with large numbers.
3874 Instead, simply match F[0-9]+, which is what is wanted anyway.
3875
3876 * alloc.c: Remove unportable assumptions about struct layout.
3877 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3878 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3879 (allocate_vectorlike, make_pure_vector): Use the new macros,
3880 plus offsetof, to remove unportable assumptions about struct layout.
3881 These assumptions hold on all porting targets that I know of, but
3882 they are not guaranteed, they're easy to remove, and removing them
3883 makes further changes easier.
3884
3885 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3886 This doesn't fix a bug but makes the code clearer.
3887 (string_overrun_cookie): Now const. Use initializers that
3888 don't formally overflow signed char, to avoid warnings.
3889 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3890 can cause Emacs to crash when string overrun checking is enabled.
3891 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3892 multiple of sizeof (EMACS_INT); it need not be, if
3893 alignof(EMACS_INT) < sizeof (EMACS_INT).
3894 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3895
3896 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3897
3898 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3899
3900 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3901
3902 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3903 supposed to be handshaking. (Bug#8556)
3904 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3905
3906 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3907
3908 * lisp.h (Qdebug): List symbol.
3909 * eval.c (Qdebug): Restore global linkage.
3910 * keyboard.c (debug-on-event): New variable.
3911 (handle_user_signal): Break into debugger when debug-on-event
3912 matches the current signal symbol.
3913
3914 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3915
3916 * alloc.c (check_sblock, check_string_bytes)
3917 (check_string_free_list): Convert to standard C.
3918
3919 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3920
3921 * w32.c (emacs_gnutls_push): Fix typo.
3922
3923 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3924
3925 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3926 "cast to pointer from integer of different size".
3927
3928 Improve doprnt and its use in verror. (Bug#8545)
3929 * doprnt.c (doprnt): Document the set of format control sequences
3930 supported by the function. Use SAFE_ALLOCA instead of always
3931 using `alloca'.
3932
3933 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3934 is one byte too soon. Don't use xrealloc; instead xfree and
3935 xmalloc anew.
3936
3937 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3938
3939 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3940 callbacks stage.
3941
3942 * gnutls.c: Renamed global_initialized to
3943 gnutls_global_initialized. Added internals for the
3944 :verify-hostname-error, :verify-error, and :verify-flags
3945 parameters of `gnutls-boot' and documented those parameters in the
3946 docstring. Start callback support.
3947 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3948 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3949 on error. Return error code.
3950 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3951 (emacs_gnutls_read): Likewise.
3952 (Fgnutls_boot): Return handshake error code.
3953 (emacs_gnutls_handle_error): New function.
3954 (wsaerror_to_errno): Likewise.
3955
3956 * w32.h (emacs_gnutls_pull): Add prototype.
3957 (emacs_gnutls_push): Likewise.
3958
3959 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3960 (emacs_gnutls_push): Likewise.
3961
3962 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3963
3964 * process.c (wait_reading_process_output): Check if GnuTLS
3965 buffered some data internally if no FDs are set for TLS
3966 connections.
3967
3968 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3969 (LIBS): Link to USER_LIBS.
3970 ($(BLD)/gnutls.$(0)): New target.
3971
3972 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3973
3974 * xdisp.c (handle_single_display_spec): Rename the
3975 display_replaced_before_p argument into display_replaced_p, to
3976 make it consistent with the commentary. Fix typos in the
3977 commentary.
3978
3979 * textprop.c (syms_of_textprop): Remove dead code.
3980 (copy_text_properties): Delete obsolete commentary about an
3981 interface that was deleted long ago. Fix typos in the description
3982 of arguments.
3983
3984 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3985 to changes in oldXMenu/XMenu.h from 2011-04-16.
3986 <menu_help_message, prev_menu_help_message>: Constify.
3987 (IT_menu_make_room): menu->help_text is now `const char **';
3988 adjust.
3989
3990 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3991 to changes in oldXMenu/XMenu.h from 2011-04-16.
3992 (struct XMenu): Declare `help_text' `const char **'.
3993
3994 * xfaces.c <Qunspecified>: Make extern again.
3995
3996 * syntax.c: Include sys/types.h before including regex.h, as
3997 required by Posix.
3998
3999 * doc.c (get_doc_string): Improve the format passed to `error'.
4000
4001 * doprnt.c (doprnt): Improve commentary.
4002
4003 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4004
4005 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4006 them with etags.
4007
4008 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4009 changes in globals.h immediately force recompilation.
4010 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4011 $(CURDIR)/s/ms-w32.h.
4012 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4013
4014 * character.c (Fchar_direction): Function deleted.
4015 (syms_of_character): Don't defsubr it.
4016 <char-direction-table>: Deleted.
4017
4018 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4019
4020 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4021 * doprnt.c: Include limits.h.
4022 (SIZE_MAX): New macro.
4023 (doprnt): Return a size_t value. 2nd arg is now size_t.
4024 Many local variables are now size_t instead of int or unsigned.
4025 Improve overflow protection. Support `l' modifier for integer
4026 conversions. Support %l conversion. Don't assume an EMACS_INT
4027 argument for integer conversions and for %c.
4028
4029 * lisp.h (doprnt): Restore prototype.
4030
4031 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4032 $(SRC)/character.h.
4033
4034 * Makefile.in (base_obj): Add back doprnt.o.
4035
4036 * deps.mk (doprnt.o): Add back prerequisites.
4037 (callint.o): Depend on character.h.
4038
4039 * eval.c (internal_lisp_condition_case): Include the handler
4040 representation in the error message.
4041 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4042 when breaking from the loop.
4043
4044 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4045
4046 * callint.c (Fcall_interactively): When displaying error message
4047 about invalid control letter, pass the character's codepoint, not
4048 a pointer to its multibyte form. Improve display of the character
4049 in octal and display also its hex code.
4050
4051 * character.c (char_string): Use %x to display the (unsigned)
4052 codepoint of an invalid character, to avoid displaying a bogus
4053 negative value.
4054
4055 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4056 `error', not SYMBOL_NAME itself.
4057
4058 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4059 character arguments to `error'.
4060
4061 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4062 to `error' in error message about FINAL_CHAR argument. Make sure
4063 FINAL_CHAR is a character, and use %c when it is passed as
4064 argument to `error'.
4065
4066 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4067
4068 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4069
4070 * w32.c: Include <time.h>.
4071 (sys_localtime): New function.
4072
4073 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4074
4075 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4076
4077 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4078
4079 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4080
4081 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4082 zombies (Bug#8467).
4083
4084 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4085
4086 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4087 gl_state.e_property when gl_state.object is Qt.
4088
4089 * insdel.c (make_gap_larger): Remove limitation of buffer size
4090 to <= INT_MAX.
4091
4092 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4093
4094 * xdisp.c (lookup_glyphless_char_display)
4095 (produce_glyphless_glyph): Handle cons cell entry in
4096 glyphless-char-display.
4097 (Vglyphless_char_display): Document it.
4098
4099 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4100 glyphless-char-display.
4101
4102 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4103
4104 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4105
4106 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4107
4108 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4109 definition for no-X builds.
4110
4111 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4112
4113 Static checks with GCC 4.6.0 and non-default toolkits.
4114
4115 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4116
4117 * process.c (keyboard_bit_set): Define only if SIGIO.
4118 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4119 (send_process): Repair possible setjmp clobbering.
4120
4121 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4122
4123 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4124
4125 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4126
4127 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4128 Define only if needed.
4129
4130 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4131 by pacifying GCC about it. Maybe it's time to retire it?
4132 * xfaces.c (USG, __TIMEVAL__): Likewise.
4133
4134 * dispextern.h (struct redisplay_interface): Rename param
4135 to avoid shadowing.
4136 * termhooks.h (struct terminal): Likewise.
4137 * xterm.c (xembed_send_message): Likewise.
4138
4139 * insdel.c (make_gap_smaller): Define only if
4140 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4141
4142 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4143 it.
4144
4145 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4146 so that we aren't warned about unused symbols.
4147
4148 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4149
4150 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4151
4152 * xfns.c (x_real_positions): Mark locals as initialized.
4153
4154 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4155
4156 * xterm.c: Fix problems found by static analysis with other toolkits.
4157 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4158 (x_dispatch_event): Declare static if USE_GTK, and
4159 define if USE_GTK || USE_X_TOOLKIT.
4160 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4161 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4162 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4163 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4164
4165 * xmenu.c (menu_help_callback): Pointer type fixes.
4166 Use const pointers when pointing at readonly data. Avoid pointer
4167 signedness clashes.
4168 (FALSE): Remove unused macro.
4169 (update_frame_menubar): Remove unused decl.
4170
4171 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4172
4173 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4174 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4175 (single_menu_item): Rename local to avoid shadowing.
4176
4177 * keyboard.c (make_lispy_event): Remove unused local var.
4178
4179 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4180 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4181
4182 * bitmaps: Change bitmaps from unsigned char back to the X11
4183 compatible char. Avoid the old compiler warnings about
4184 out-of-range initializers by using, for example, '\xab' rather
4185 than 0xab.
4186
4187 * xgselect.c (xgselect_initialize): Check vs interface
4188 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4189
4190 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4191
4192 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4193 to read-only memory.
4194
4195 * fns.c (vector): Remove; this old hack is no longer needed.
4196
4197 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4198 Remove unused var.
4199 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4200
4201 * xrdb.c (x_load_resources): Omit unused local.
4202
4203 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4204 (x_window): Rename locals to avoid shadowing.
4205 (USG): Use the kludged USG macro, to pacify gcc.
4206
4207 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4208 (x_term_init): Remove local to avoid shadowing.
4209
4210 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4211
4212 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4213 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4214
4215 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4216
4217 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4218
4219 Fix regex.c, syntax.c and friends for buffers > 2GB.
4220 * syntax.h (struct gl_state_s): Declare character position members
4221 EMACS_INT.
4222
4223 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4224
4225 * textprop.c (verify_interval_modification, interval_of):
4226 Declare arguments EMACS_INT.
4227
4228 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4229 EMACS_INT.
4230
4231 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4232
4233 * indent.c (Fvertical_motion): Local variable it_start is now
4234 EMACS_INT.
4235
4236 * regex.c (re_match, re_match_2, re_match_2_internal)
4237 (bcmp_translate, regcomp, regexec, print_double_string)
4238 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4239 (re_compile_pattern, re_exec): Declare arguments and local
4240 variables `size_t' and `ssize_t' and return values `regoff_t', as
4241 appropriate.
4242 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4243 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4244 <compile_stack_type>: `size' and `avail' are now `size_t'.
4245
4246 * regex.h <regoff_t>: Use ssize_t, not int.
4247 (re_search, re_search_2, re_match, re_match_2): Arguments that
4248 specify buffer/string position and length are now ssize_t and
4249 size_t. Return type is regoff_t.
4250
4251 2011-04-16 Ben Key <bkey76@gmail.com>
4252
4253 * nsfont.m: Fixed bugs in ns_get_family and
4254 ns_descriptor_to_entity that were caused by using free to
4255 deallocate memory blocks that were allocated by xmalloc (via
4256 xstrdup). This caused Emacs to crash when compiled with
4257 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4258 --enable-checking=xmallocoverrun). xfree is now used to
4259 deallocate these memory blocks.
4260
4261 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4262
4263 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4264
4265 emacs_write: Accept and return EMACS_INT for sizes.
4266 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4267 et seq.
4268 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4269 Accept and return EMACS_INT.
4270 (emacs_gnutls_write): Return the number of bytes written on
4271 partial writes.
4272 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4273 (emacs_read, emacs_write): Remove check for negative size, as the
4274 Emacs source code has been audited now.
4275 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4276 (emacs_read, emacs_write): Use it.
4277 * process.c (send_process): Adjust to the new signatures of
4278 emacs_write and emacs_gnutls_write. Do not attempt to store
4279 a byte offset into an 'int'; it might overflow.
4280 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4281
4282 * sound.c: Don't assume sizes fit in 'int'.
4283 (struct sound_device.period_size, alsa_period_size):
4284 Return EMACS_INT, not int.
4285 (struct sound_device.write, vox_write, alsa_write):
4286 Accept EMACS_INT, not int.
4287 (wav_play, au_play): Use EMACS_INT to store sizes and to
4288 record read return values.
4289
4290 2011-04-15 Ben Key <bkey76@gmail.com>
4291
4292 * keyboard.c (Qundefined): Don't declare static since it is used
4293 in nsfns.m.
4294 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4295 static since they are used in nsfont.m.
4296
4297 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4298
4299 * process.c (Qprocessp): Don't declare static.
4300 * lisp.h (Qprocessp): Declare again.
4301
4302 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4303
4304 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4305
4306 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4307
4308 Improve C-level modularity by making more things 'static'.
4309
4310 Don't publish debugger-only interfaces to other modules.
4311 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4312 (verify_bytepos, count_markers): Move decls to the only modules
4313 that need them.
4314 * region-cache.h (pp_cache): Likewise.
4315 * window.h (check_all_windows): Likewise.
4316 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4317
4318 * sysdep.c (croak): Now static, if
4319 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4320 * syssignal.h (croak): Declare only if not static.
4321
4322 * alloc.c (refill_memory_reserve): Now static if
4323 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4324 * lisp.h (refill_memory_reserve): Declare only if not static.
4325
4326 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4327 Define only if USE_LUCID.
4328
4329 * xrdb.c (x_customization_string, x_rm_string): Now static.
4330
4331 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4332 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4333
4334 * xdisp.c (draw_row_with_mouse_face): Now static.
4335 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4336
4337 * window.h (check_all_windows): Mark externally visible.
4338
4339 * window.c (window_deletion_count): Now static.
4340
4341 * undo.c: Make symbols static if they're not exported.
4342 (last_undo_buffer, last_boundary_position, pending_boundary):
4343 Now static.
4344
4345 * textprop.c (interval_insert_behind_hooks): Now static.
4346 (interval_insert_in_front_hooks): Likewise.
4347
4348 * term.c: Make symbols static if they're not exported.
4349 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4350 (max_frame_lines, tty_set_terminal_modes):
4351 (tty_reset_terminal_modes, tty_turn_off_highlight):
4352 (get_tty_terminal): Now static.
4353 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4354 * termhooks.h (term_mouse_moveto): Do not declare if
4355 HAVE_WINDOW_SYSTEM.
4356 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4357 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4358
4359 * sysdep.c: Make symbols static if they're not exported.
4360 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4361 Now static.
4362 (sigprocmask_set, full_mask): Remove; unused.
4363 (wait_debugging): Mark as visible.
4364 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4365 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4366
4367 * syntax.c (syntax_temp): Define only if !__GNUC__.
4368
4369 * sound.c (current_sound_device, current_sound): Now static.
4370
4371 * search.c (searchbufs, searchbuf_head): Now static.
4372
4373 * scroll.c (scroll_cost): Remove; unused.
4374 * dispextern.h (scroll_cost): Remove decl.
4375
4376 * region-cache.h (pp_cache): Mark as externally visible.
4377
4378 * process.c: Make symbols static if they're not exported.
4379 (process_tick, update_tick, create_process, chan_process):
4380 (Vprocess_alist, proc_buffered_char, datagram_access):
4381 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4382 (deactivate_process): Mark defn as static, as well as decl.
4383 * lisp.h (create_process): Remove decl.
4384 * process.h (chan_process, Vprocess_alist): Remove decls.
4385
4386 * print.c: Make symbols static if they're not exported.
4387 (print_depth, new_backquote_output, being_printed, print_buffer):
4388 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4389 (print_interval, print_number_index, initial_stderr_stream):
4390 Now static.
4391 * lisp.h (Fprinc): Remove decl.
4392 (debug_output_compilation_hack): Mark as externally visible.
4393
4394 * sysdep.c (croak): Move decl from here to syssignal.h.
4395 * syssignal.h (croak): Put it here, so the API can be checked when
4396 'croak' is called from dissociate_if_controlling_tty.
4397
4398 * minibuf.c: Make symbols static if they're not exported.
4399 (minibuf_save_list, choose_minibuf_frame): Now static.
4400 * lisp.h (choose_minibuf_frame): Remove decl.
4401
4402 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4403
4404 * lread.c: Make symbols static if they're not exported.
4405 (read_objects, initial_obarray, oblookup_last_bucket_number):
4406 Now static.
4407 (make_symbol): Remove; unused.
4408 * lisp.h (initial_obarray, make_symbol): Remove decls.
4409
4410 * keyboard.c: Make symbols static if they're not exported.
4411 (single_kboard, recent_keys_index, total_keys, recent_keys):
4412 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4413 (this_single_command_key_start, echoing, last_auto_save):
4414 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4415 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4416 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4417 (Vlispy_mouse_stem, double_click_count):
4418 Now static.
4419 (force_auto_save_soon): Define only if SIGDANGER.
4420 (ignore_mouse_drag_p): Now static if
4421 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4422 (print_help): Remove; unused.
4423 (stop_character, last_timer_event): Mark as externally visible.
4424 * keyboard.h (ignore_mouse_drag_p): Declare only if
4425 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4426 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4427 * lisp.h (echoing): Remove decl.
4428 (force_auto_save_soon): Declare only if SIGDANGER.
4429 * xdisp.c (redisplay_window): Simplify code, to make it more
4430 obvious that ignore_mouse_drag_p is not accessed if !defined
4431 USE_GTK && !defined HAVE_NS.
4432
4433 * intervals.c: Make symbols static if they're not exported.
4434 (merge_properties_sticky, merge_interval_right, delete_interval):
4435 Now static.
4436 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4437
4438 * insdel.c: Make symbols static if they're not exported.
4439 However, leave prepare_to_modify_buffer alone. It's never
4440 called from outside this function, but that appears to be a bug.
4441 (combine_after_change_list, combine_after_change_buffer):
4442 (adjust_after_replace, signal_before_change): Now static.
4443 (adjust_after_replace_noundo): Remove; unused.
4444 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4445 (signal_before_change): Remove decls.
4446
4447 * indent.c (val_compute_motion, val_vmotion): Now static.
4448
4449 * image.c: Make symbols static if they're not exported.
4450 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4451 if USE_GTK.
4452 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4453 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4454
4455 * fringe.c (standard_bitmaps): Now static.
4456 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4457
4458 * frame.c: Make symbols static if they're not exported.
4459 (x_report_frame_params, make_terminal_frame): Now static.
4460 (get_frame_param): Now static, unless HAVE_NS.
4461 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4462 (x_get_resource_string): Remove; not used.
4463 * frame.h (make_terminal_frame, x_report_frame_params):
4464 (x_get_resource_string); Remove decls.
4465 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4466 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4467
4468 * font.c, fontset.c: Make symbols static if they're not exported.
4469 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4470 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4471 * font.c (font_close_object): Now static.
4472 * font.h (font_close_object): Remove.
4473 * fontset.c (FONTSET_OBJLIST): Remove.
4474 (free_realized_fontset) #if-0 the body, which does nothing.
4475 (face_suitable_for_char_p): #if-0, as it's never called.
4476 * fontset.h (face_suitable_for_char_p): Remove decl.
4477 * xfaces.c (face_at_string_position):
4478 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4479 since 0 is always ASCII.
4480
4481 * fns.c (weak_hash_tables): Now static.
4482
4483 * fileio.c: Make symbols static if they're not exported.
4484 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4485 (Vwrite_region_annotation_buffers): Now static.
4486
4487 * eval.c: Make symbols static if they're not exported.
4488 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4489 * lisp.h (backtrace_list): Remove decl.
4490
4491 * emacs.c: Make symbols static if they're not exported.
4492 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4493 (fatal_error_code, fatal_error_signal_hook, standard_args):
4494 Now static.
4495 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4496 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4497 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4498 * lisp.h (fatal_error_signal_hook): Remove decl.
4499 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4500
4501 * editfns.c: Move a (normally-unused) function to its only use.
4502 * editfns.c, lisp.h (get_operating_system_release): Remove.
4503 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4504 worth the hassle of breaking this out.
4505
4506 * xterm.c: Make symbols static if they're not exported.
4507 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4508 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4509 (x_destroy_window, x_delete_display):
4510 Now static.
4511 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4512 (x_mouse_leave): Remove; unused.
4513 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4514 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4515 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4516 Remove decls.
4517 (x_mouse_leave): Declare only if WINDOWSNT.
4518 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4519 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4520 USE_X_TOOLKIT.
4521
4522 * ftxfont.c: Make symbols static if they're not exported.
4523 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4524 HAVE_FREETYPE.
4525 * font.h (ftxfont_driver): Likewise.
4526
4527 * xfns.c: Make symbols static if they're not exported.
4528 (x_last_font_name, x_display_info_for_name):
4529 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4530 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4531 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4532 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4533 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4534 (last_show_tip_args): Now static.
4535 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4536 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4537 (x_screen_planes): Remove; unused.
4538 * dispextern.h (x_screen_planes): Remove decl.
4539
4540 * dispnew.c: Make symbols static if they're not exported.
4541 * dispextern.h (redraw_garbaged_frames, scrolling):
4542 (increment_row_positions): Remove.
4543 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4544 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4545 Now static.
4546 (redraw_garbaged_frames): Remove; unused.
4547
4548 * xfaces.c: Make symbols static if they're not exported.
4549 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4550 Remove decls.
4551 * xterm.h (defined_color): Remove decls.
4552 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4553 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4554 (menu_face_changed_default, defined_color, free_realized_face):
4555 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4556 (ascii_face_of_lisp_face): Remove; unused.
4557
4558 * xdisp.c: Make symbols static if they're not exported.
4559 * dispextern.h (scratch_glyph_row, window_box_edges):
4560 (glyph_to_pixel_coords, set_cursor_from_row):
4561 (get_next_display_element, set_iterator_to_next):
4562 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4563 (show_mouse_face): Remove decls
4564 * frame.h (message_buf_print): Likewise.
4565 * lisp.h (pop_message, set_message, check_point_in_composition):
4566 Likewise.
4567 * xterm.h (set_vertical_scroll_bar): Likewise.
4568 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4569 (message_buf_print, scratch_glyph_row, displayed_buffer):
4570 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4571 (get_next_display_element, show_mouse_face, window_box_edges):
4572 (frame_to_window_pixel_xy, check_point_in_composition):
4573 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4574 (glyph_to_pixel_coords): Remove; unused.
4575
4576 * dired.c (file_name_completion): Now static.
4577
4578 * dbusbind.c (xd_in_read_queued_messages): Now static.
4579
4580 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4581 * data.c (circular_list_error): Remove.
4582
4583 * commands.h (last_point_position, last_point_position_buffer):
4584 (last_point_position_window): Remove decls.
4585 * keyboard.c: Make these variables static.
4586
4587 * coding.h (coding, code_convert_region, encode_coding_gap):
4588 Remove decls.
4589 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4590 (iso_code_class, detect_coding, code_convert_region): Now static.
4591 (encode_coding_gap): Remove; unused.
4592
4593 * chartab.c (chartab_chars, chartab_bits): Now static.
4594
4595 * charset.h (charset_iso_8859_1): Remove decl.
4596 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4597 Now static.
4598
4599 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4600 * ccl.c (Vccl_program_table): Now static.
4601 (check_ccl_update): Remove; unused.
4602
4603 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4604 * category.h: ... from here.
4605 * category.c (check_category_table, set_category_set): Now static.
4606
4607 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4608 * lisp.h: Remove these decls.
4609
4610 * buffer.c (buffer_count): Remove unused var.
4611
4612 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4613 so that it's not optimized away.
4614 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4615 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4616 exported only to the debugger.
4617
4618 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4619 * atimer.h (run_all_atimers): Remove; not exported.
4620
4621 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4622 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4623 was inaccessible from Lisp.
4624 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4625 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4626
4627 alloc.c: Import and export fewer symbols, and remove unused items.
4628 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4629 is defined.
4630 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4631 it's not optimized away by whole-program optimization.
4632 (message_enable_multibyte, free_misc): Remove.
4633 (catchlist, handlerlist, mark_backtrace):
4634 Declare only if BYTE_MARK_STACK.
4635 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4636 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4637 (message_enable_multibyte): Remove decl.
4638 (free_misc, interval_free_list, float_block, float_block_index):
4639 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4640 (cons_free_list, last_marked_index):
4641 Now static.
4642 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4643 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4644 (mark_backtrace): Define only if BYTE_MARK_STACK.
4645 * xdisp.c (message_enable_multibyte): Now static.
4646
4647 Declare Lisp_Object Q* variables to be 'static' if not exported.
4648 This makes it easier for human readers (and static analyzers)
4649 to see whether these variables are used from other modules.
4650 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4651 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4652 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4653 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4654 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4655 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4656 * xmenu.c, xselect.c:
4657 Declare Q* vars static if they are not used in other modules.
4658 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4659 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4660 Remove decls of unexported vars.
4661 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4662
4663 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4664
4665 Make Emacs functions such as Fatom 'static' by default.
4666 This makes it easier for human readers (and static analyzers)
4667 to see whether these functions can be called from other modules.
4668 DEFUN now defines a static function. To make the function external
4669 so that it can be used in other C modules, use the new macro DEFUE.
4670 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4671 (Finit_image_library):
4672 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4673 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4674 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4675 Remove decls, since these functions are now static.
4676 (Funintern, Fget_internal_run_time): New decls, since these functions
4677 were already external.
4678
4679 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4680 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4681 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4682 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4683 * keyboard.c, keymap.c, lread.c:
4684 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4685 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4686 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4687 Mark functions with DEFUE instead of DEFUN,
4688 if they are used in other modules.
4689 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4690 decls for now-static functions.
4691 * buffer.h (Fdelete_overlay): Remove decl.
4692 * callproc.c (Fgetenv_internal): Mark as internal.
4693 * composite.c (Fremove_list_of_text_properties): Remove decl.
4694 (Fcomposition_get_gstring): New forward static decl.
4695 * composite.h (Fcomposite_get_gstring): Remove decl.
4696 * dired.c (Ffile_attributes): New forward static decl.
4697 * doc.c (Fdocumntation_property): New forward static decl.
4698 * eval.c (Ffetch_bytecode): New forward static decl.
4699 (Funintern): Remove extern decl; now in .h file where it belongs.
4700 * fileio.c (Fmake_symbolic_link): New forward static decl.
4701 * image.c (Finit_image_library): New forward static decl.
4702 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4703 * intervals.h (Fprevious_property_change):
4704 (Fremove_list_of_text_properties): Remove decls.
4705 * keyboard.c (Fthis_command_keys): Remove decl.
4706 (Fcommand_execute): New forward static decl.
4707 * keymap.c (Flookup_key): New forward static decl.
4708 (Fcopy_keymap): Now static.
4709 * keymap.h (Flookup_key): Remove decl.
4710 * process.c (Fget_process): New forward static decl.
4711 (Fprocess_datagram_address): Mark as internal.
4712 * syntax.c (Fsyntax_table_p): New forward static decl.
4713 (skip_chars): Remove duplicate decl.
4714 * textprop.c (Fprevious_property_change): New forward static decl.
4715 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4716 Now internal.
4717 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4718 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4719
4720 * editfns.c (Fformat): Remove unreachable code.
4721
4722 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4723
4724 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4725 change. (Bug#8496)
4726
4727 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4728
4729 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4730 when at ZV. (Bug#8487)
4731
4732 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4733
4734 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4735 (Bug#8437)
4736 * keyboard.c (parse_tool_bar_item): Likewise.
4737 * sound.c (sound_cleanup, alsa_close): Likewise.
4738 * termcap.c (tgetent): Likewise.
4739 * xfns.c (x_default_font_parameter): Likewise.
4740 * xsettings.c (read_and_apply_settings): Likewise.
4741
4742 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4743 (overrun_check_free): Protoize.
4744
4745 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4746
4747 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4748 since callers should never pass a negative size.
4749 Change the signature to match that of plain 'read' and 'write'; see
4750 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4751 * lisp.h: Update prototypes of emacs_write and emacs_read.
4752
4753 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4754
4755 * xdisp.c (redisplay_window): Don't try to determine the character
4756 position of the scroll margin if the window start point w->startp
4757 is outside the buffer's accessible region. (Bug#8468)
4758
4759 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4760
4761 Fix write-region and its subroutines for buffers > 2GB.
4762 * fileio.c (a_write, e_write): Modify declaration of arguments and
4763 local variables to support buffers larger than 2GB.
4764 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4765
4766 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4767 argument, local variables, and return value.
4768
4769 * lisp.h: Update prototypes of emacs_write and emacs_read.
4770
4771 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4772
4773 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4774
4775 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4776
4777 Fix more problems found by GCC 4.6.0's static checks.
4778
4779 * xdisp.c (vmessage): Use a better test for character truncation.
4780
4781 * charset.c (load_charset_map): <, not <=, for optimization,
4782 and to avoid potential problems with integer overflow.
4783 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4784 * casetab.c (set_identity, shuffle): Likewise.
4785 * editfns.c (Fformat): Likewise.
4786 * syntax.c (skip_chars): Likewise.
4787
4788 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4789 This also lets GCC 4.6.0 generate slightly better loop code.
4790
4791 * callint.c (Fcall_interactively): <, not <=, for optimization.
4792 (Fcall_interactively): Count the number of arguments produced,
4793 not the number of arguments given. This is simpler and lets GCC
4794 4.6.0 generate slightly better code.
4795
4796 * ftfont.c: Distingish more carefully between FcChar8 and char.
4797 The previous code passed unsigned char * to a functions like
4798 strlen and xstrcasecmp that expect char *, which does not
4799 conform to the C standard.
4800 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4801 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4802 char * when the C standard requires it.
4803
4804 * keyboard.c (read_char): Remove unused var.
4805
4806 * eval.c: Port to Windows vsnprintf (Bug#8435).
4807 Include <limits.h>.
4808 (SIZE_MAX): Define if the headers do not.
4809 (verror): Do not give up if vsnprintf returns a negative count.
4810 Instead, grow the buffer. This ports to Windows vsnprintf, which
4811 does not conform to C99. Problem reported by Eli Zaretskii.
4812 Also, simplify the allocation scheme, by avoiding the need for
4813 calling realloc, and removing the ALLOCATED variable.
4814
4815 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4816
4817 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4818 But keep the doprint source code for now, as we might revamp it
4819 and use it again (Bug#8435).
4820 * lisp.h (doprnt): Remove.
4821 * Makefile.in (base_obj): Remove doprnt.o.
4822 * deps.mk (doprnt.o): Remove.
4823
4824 error: Print 32- and 64-bit integers portably (Bug#8435).
4825 Without this change, on typical 64-bit hosts error ("...%d...", N)
4826 was used to print both 32- and 64-bit integers N, which relied on
4827 undefined behavior.
4828 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4829 New macro.
4830 * lisp.h (error, verror): Mark as printf-like functions.
4831 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4832 Report overflow in size calculations when allocating printf buffer.
4833 Do not truncate output string at its first null byte.
4834 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4835 Truncate the output at a character boundary, since vsnprintf does not
4836 do that.
4837 * charset.c (check_iso_charset_parameter): Convert internal
4838 character to string before calling 'error', since %c now has the
4839 printf meaning.
4840 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4841 overflow when computing char to be passed to 'error'. Do not
4842 pass Lisp_Object to 'error'; pass the integer instead.
4843 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4844 formatted with plain %d.
4845
4846 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4847
4848 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4849
4850 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4851
4852 * xterm.c (x_catch_errors): Remove duplicate declaration.
4853
4854 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4855
4856 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4857
4858 2011-04-10 Jim Meyering <meyering@redhat.com>
4859
4860 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4861 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4862 return ssize_t not "int", and use size_t as the buffer length.
4863 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4864 * gnutls.h: Update declarations.
4865 * process.c (read_process_output): Use ssize_t, to match.
4866 (send_process): Likewise.
4867
4868 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4869
4870 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4871
4872 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4873
4874 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4875 Use unsigned char, to match FcChar8 type definition.
4876
4877 * xterm.c (handle_one_xevent):
4878 * xmenu.c (create_and_show_popup_menu):
4879 * xselect.c (x_decline_selection_request)
4880 (x_reply_selection_request): Avoid type-punned deref of X events.
4881
4882 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4883
4884 Fix some uses of `int' instead of EMACS_INT.
4885 * search.c (string_match_1, fast_string_match)
4886 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4887 (scan_buffer, find_next_newline_no_quit)
4888 (find_before_next_newline, search_command, Freplace_match)
4889 (Fmatch_data): Make some `int' variables be EMACS_INT.
4890
4891 * xdisp.c (display_count_lines): 3rd argument and return value now
4892 EMACS_INT. All callers changed.
4893 (pint2hrstr): Last argument is now EMACS_INT.
4894
4895 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4896 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4897 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4898 (decode_coding_utf_16, decode_coding_emacs_mule)
4899 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4900 (decode_coding_ccl, decode_coding_charset)
4901 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4902 (decode_coding_iso_2022, decode_coding_emacs_mule)
4903 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4904 <char_offset, last_offset>: Declare EMACS_INT.
4905 (encode_coding_utf_8, encode_coding_utf_16)
4906 (encode_coding_emacs_mule, encode_invocation_designation)
4907 (encode_designation_at_bol, encode_coding_iso_2022)
4908 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4909 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4910 Declare EMACS_INT.
4911 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4912 (encode_invocation_designation): Last argument P_NCHARS is now
4913 EMACS_INT.
4914 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4915 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4916
4917 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4918 All users changed.
4919
4920 * ccl.c (Fccl_execute_on_string): Declare some variables
4921 EMACS_INT.
4922
4923 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4924
4925 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4926
4927 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4928
4929 * process.c (Fformat_network_address): Doc fix.
4930
4931 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4932
4933 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4934
4935 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4936
4937 * keyboard.c (read_char): Call Lisp function help-form-show,
4938 instead of using internal_with_output_to_temp_buffer.
4939 (Qhelp_form_show): New var.
4940 (syms_of_keyboard): Use DEFSYM macro.
4941
4942 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4943
4944 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4945
4946 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4947
4948 * process.c (Flist_processes): Remove to Lisp.
4949 (list_processes_1): Delete.
4950
4951 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4952
4953 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4954
4955 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4956
4957 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4958
4959 Fix more problems found by GCC 4.6.0's static checks.
4960
4961 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4962
4963 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4964
4965 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4966
4967 * xdisp.c (vmessage): Mark as a printf-like function.
4968
4969 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4970
4971 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4972
4973 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4974 printf-like functions.
4975 (tiff_load): Add casts to remove these marks before passing them
4976 to system-supplied API.
4977
4978 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4979
4980 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4981 This avoids several warnings with gcc -Wstrict-overflow.
4982 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4983 directly, rather than having caller test rule sign. This avoids
4984 some unnecessary tests.
4985 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4986 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4987 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4988
4989 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4990 (xfont_open): Avoid unnecessary tests.
4991
4992 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4993
4994 * composite.h, composite.c (composition_gstring_put_cache):
4995 Use EMACS_INT, not int, for length.
4996
4997 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4998 breaking out part of COMPOSITION_DECODE_RULE.
4999 (COMPOSITION_DECODE_RULE): Use it.
5000 * composite.c (get_composition_id): Remove unused local vars,
5001 by using the new macro.
5002
5003 * textprop.c (set_text_properties_1): Change while to do-while,
5004 since the condition is always true at first.
5005
5006 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5007 (interval_deletion_adjustment): Return unsigned value.
5008 All uses changed.
5009
5010 * process.c (list_processes_1, create_pty, read_process_output):
5011 (exec_sentinel): Remove vars that were set but not used.
5012 (create_pty): Remove unnecessary "volatile"s.
5013 (Fnetwork_interface_info): Avoid possibility of int overflow.
5014 (read_process_output): Do adaptive read buffering even if carryover.
5015 (read_process_output): Simplify nbytes computation if buffered.
5016
5017 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5018
5019 * syntax.c (scan_words): Remove var that was set but not used.
5020 (update_syntax_table): Use unsigned instead of int.
5021
5022 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5023 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5024 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5025
5026 * print.c (print_error_message): Avoid int overflow.
5027
5028 * font.c (font_list_entities): Redo for clarity,
5029 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5030
5031 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5032 (font_score): Avoid potential overflow in diff calculation.
5033
5034 * fns.c (substring_both): Remove var that is set but not used.
5035 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5036
5037 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5038
5039 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5040 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5041 can always succeed if overflow has undefined behavior.
5042
5043 * search.c (boyer_moore, wordify): Remove vars set but not used.
5044 (wordify): Omit three unnecessary tests.
5045
5046 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5047 All callers changed. This avoids the need for an unused var.
5048
5049 * casefiddle.c (casify_region): Remove var that is set but not used.
5050
5051 * dired.c (file_name_completion): Remove var that is set but not used.
5052
5053 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5054
5055 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5056 (Finsert_file_contents): Remove unnecessary code checking fd.
5057
5058 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5059 Check for integer overflow on size calculations.
5060
5061 * buffer.c (Fprevious_overlay_change): Remove var that is set
5062 but not used.
5063
5064 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5065 Remove vars that are set but not used.
5066 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5067 (timer_check_2): Mark vars as initialized.
5068
5069 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5070
5071 * image.c (lookup_image): Remove var that is set but not used.
5072 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5073
5074 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5075 that are set but not used.
5076
5077 * xfns.c (make_invisible_cursor): Don't return garbage
5078 if XCreateBitmapFromData fails (Bug#8410).
5079
5080 * xselect.c (x_get_local_selection, x_handle_property_notify):
5081 Remove vars that are set but not used.
5082
5083 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5084 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5085
5086 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5087 Remove var that is set but not used.
5088 (scroll_bar_windows_size): Now size_t, not int.
5089 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5090 Check for overflow.
5091
5092 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5093 (map_tty_color) [!defined MSDOS]: Likewise.
5094
5095 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5096
5097 * coding.c: Remove vars that are set but not used.
5098 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5099 All callers changed.
5100 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5101 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5102 (decode_coding_charset): Remove vars that are set but not used.
5103
5104 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5105 that is set but not used.
5106
5107 * print.c (print_object): Remove var that is set but not used.
5108
5109 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5110 The gnulib version avoids calling malloc in the usual case,
5111 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5112 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5113 * filelock.c (current_lock_owner): Likewise.
5114 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5115 * sysdep.c: Include allocator.h, careadlinkat.h.
5116 (emacs_no_realloc_allocator): New static constant.
5117 (emacs_readlink): New function.
5118 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5119 ../lib/careadlinkat.h.
5120
5121 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5122
5123 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5124 first non-nil return value).
5125
5126 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5127
5128 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5129 if not defined (Bug#8403).
5130
5131 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5132
5133 * xdisp.c (display_count_lines): Remove parameter `start',
5134 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5135 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5136 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5137 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5138 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5139 and thereabouts. All callers changed.
5140 (get_per_char_metric): Remove parameter `f', unused since
5141 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5142
5143 2011-04-02 Jim Meyering <meyering@redhat.com>
5144
5145 do not dereference NULL upon failed strdup
5146 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5147 (ns_get_family): Likewise.
5148
5149 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5150
5151 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5152
5153 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5154
5155 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5156 later (Bug#8403).
5157
5158 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5159
5160 Add lexical binding.
5161
5162 * window.c (Ftemp_output_buffer_show): New fun.
5163 (Fsave_window_excursion):
5164 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5165
5166 * lread.c (lisp_file_lexically_bound_p): New function.
5167 (Fload): Bind Qlexical_binding.
5168 (readevalloop): Remove `evalfun' arg.
5169 Bind Qinternal_interpreter_environment.
5170 (Feval_buffer): Bind Qlexical_binding.
5171 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5172 Mark as dynamic.
5173 (syms_of_lread): Declare `lexical-binding'.
5174
5175 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5176
5177 * keyboard.c (eval_dyn): New fun.
5178 (menu_item_eval_property): Use it.
5179
5180 * image.c (parse_image_spec): Use Ffunctionp.
5181
5182 * fns.c (concat, mapcar1): Accept byte-code-functions.
5183
5184 * eval.c (Fsetq): Handle lexical vars.
5185 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5186 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5187 (FletX, Flet): Obey lexical binding.
5188 (Fcommandp): Handle closures.
5189 (Feval): New `lexical' arg.
5190 (eval_sub): New function extracted from Feval. Use it almost
5191 everywhere where Feval was used. Look up vars in lexical env.
5192 Handle closures.
5193 (Ffunctionp): Move from subr.el.
5194 (Ffuncall): Handle closures.
5195 (apply_lambda): Remove `eval_flags'.
5196 (funcall_lambda): Handle closures and new byte-code-functions.
5197 (Fspecial_variable_p): New function.
5198 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5199 but without exporting it to Lisp.
5200
5201 * doc.c (Fdocumentation, store_function_docstring):
5202 * data.c (Finteractive_form): Handle closures.
5203
5204 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5205 interactive spec.
5206
5207 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5208 New byte-codes.
5209 (exec_byte_code): New function extracted from Fbyte_code to handle new
5210 calling convention for byte-code-functions. Add new byte-codes.
5211
5212 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5213
5214 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5215
5216 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5217
5218 * xdisp.c (redisplay_internal): Fix prototype.
5219
5220 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5221
5222 * xdisp.c (SCROLL_LIMIT): New macro.
5223 (try_scrolling): Use it when setting scroll_limit.
5224 Limit scrolling to 100 screen lines.
5225 (redisplay_window): Even when falling back on "recentering",
5226 position point in the window according to scroll-conservatively,
5227 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5228
5229 (try_scrolling): When point is above the window, allow searching
5230 as far as scroll_max, or one screenful, to compute vertical
5231 distance from PT to the scroll margin position. This prevents
5232 try_scrolling from unnecessarily failing when
5233 scroll-conservatively is set to a value slightly larger than the
5234 window height. Clean up the case of PT below the margin at bottom
5235 of window: scroll_max can no longer be INT_MAX. When aggressive
5236 scrolling is in use, don't let point enter the opposite scroll
5237 margin as result of the scroll.
5238 (syms_of_xdisp) <scroll-conservatively>: Document the
5239 threshold of 100 lines for never-recentering scrolling.
5240
5241 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5242
5243 * dispextern.h (move_it_by_lines):
5244 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5245 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5246 (message_log_check_duplicate): Remove parameters `prev_bol' and
5247 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5248 (redisplay_internal): Remove parameter `preserve_echo_area',
5249 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5250
5251 * indent.c (Fvertical_motion):
5252 * window.c (window_scroll_pixel_based, Frecenter):
5253 Don't pass `need_y_p' to `move_it_by_lines'.
5254
5255 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5256
5257 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5258 steal a few bits to be more compact.
5259 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5260 Remove unneeded casts.
5261
5262 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5263
5264 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5265
5266 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5267 binding" message (bug#7967).
5268
5269 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5270
5271 Fix more problems found by GCC 4.6.0's static checks.
5272
5273 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5274 Remove unused local var.
5275
5276 * editfns.c (Fmessage_box): Remove unused local var.
5277
5278 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5279 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5280 Omit unused local vars.
5281 * window.c (shrink_windows): Omit unused local var.
5282 * menu.c (digest_single_submenu): Omit unused local var.
5283 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5284 Omit unused local var.
5285
5286 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5287 Don't assume string length fits in int.
5288 (keyremap_step, read_key_sequence): Use size_t for sizes.
5289 (read_key_sequence): Don't check last_real_key_start redundantly.
5290
5291 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5292 instead of alloca (Bug#8344).
5293
5294 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5295 (Fbacktrace_frame): Don't assume nframes fits in int.
5296
5297 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5298
5299 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5300 concerns.
5301
5302 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5303
5304 * cm.c (calccost): Turn while-do into do-while, for clarity.
5305
5306 * keyboard.c (syms_of_keyboard): Use the same style as later
5307 in this function when indexing through an array. This also
5308 works around GCC bug 48267.
5309
5310 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5311
5312 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5313
5314 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5315 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5316
5317 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5318 This avoids undefined behavior on integer overflow, and is a bit
5319 more convenient anyway since it is compared to a size_t variable.
5320
5321 Variadic C functions now count arguments with size_t, not int.
5322 This avoids an unnecessary limitation on 64-bit machines, which
5323 caused (substring ...) to crash on large vectors (Bug#8344).
5324 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5325 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5326 All variadic functions and their callers changed accordingly.
5327 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5328 * data.c (arith_driver, float_arith_driver): Likewise.
5329 * editfns.c (general_insert_function): Likewise.
5330 * eval.c (struct backtrace.nargs, interactive_p)
5331 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5332 (funcall_lambda, mark_backtrace): Likewise.
5333 * fns.c (concat): Likewise.
5334 * frame.c (x_set_frame_parameters): Likewise.
5335 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5336 0 if not found, not -1. All callers changed.
5337
5338 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5339 (stack_copy_size): Now size_t, not int.
5340 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5341
5342 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5343
5344 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5345 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5346 All callers changed.
5347
5348 * lisp.h (multibyte_char_to_unibyte):
5349 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5350 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5351 * character.h (CHAR_TO_BYTE8):
5352 * cmds.c (internal_self_insert):
5353 * editfns.c (general_insert_function):
5354 * keymap.c (push_key_description):
5355 * search.c (Freplace_match):
5356 * xdisp.c (message_dolog, set_message_1): All callers changed.
5357
5358 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5359
5360 * keyboard.c (safe_run_hook_funcall): New function.
5361 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5362 don't set the hook to nil, but remove the offending function instead.
5363 (Qcommand_hook_internal): Remove, unused.
5364 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5365 Vcommand_hook_internal.
5366
5367 * eval.c (enum run_hooks_condition): Remove.
5368 (funcall_nil, funcall_not): New functions.
5369 (run_hook_with_args): Call each function through a `funcall' argument.
5370 Remove `cond' argument, now redundant.
5371 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5372 (Frun_hook_with_args_until_failure): Adjust accordingly.
5373 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5374
5375 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5376
5377 * dispextern.h (string_buffer_position): Remove declaration.
5378
5379 * print.c (strout): Remove parameter `multibyte', unused since
5380 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5381
5382 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5383 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5384 All callers changed.
5385
5386 * w32.c (_wsa_errlist): Use braces for struct initializers.
5387
5388 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5389 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5390 All callers changed.
5391 (string_buffer_position): Likewise. Also, make static (it's never
5392 used outside xdisp.c).
5393 (cursor_row_p): Remove parameter `w', unused since
5394 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5395 (decode_mode_spec): Remove parameter `precision', introduced during
5396 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5397 All callers changed.
5398
5399 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5400
5401 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5402
5403 2011-03-27 Anders Lindgren <andlind@gmail.com>
5404
5405 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5406 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5407 (ns_update_auto_hide_menu_bar): New functions.
5408 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5409 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5410 ns_constrain_all_frames.
5411 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5412 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5413
5414 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5415
5416 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5417
5418 2011-03-27 Glenn Morris <rgm@gnu.org>
5419
5420 * syssignal.h: Replace RETSIGTYPE with void.
5421 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5422 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5423 Replace SIGTYPE with void everywhere.
5424 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5425 * s/template.h (SIGTYPE): Remove commented out definition.
5426
5427 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5428
5429 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5430 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5431
5432 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5433
5434 * w32.c (read_unc_volume): Use parameter `henum', instead of
5435 global variable `wget_enum_handle'.
5436
5437 * keymap.c (describe_vector): Remove parameters `indices' and
5438 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5439 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5440
5441 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5442
5443 * keyboard.c (timer_check): Remove parameter `do_it_now',
5444 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5445 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5446 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5447
5448 * keyboard.c (read_char):
5449 * w32menu.c (w32_menu_display_help):
5450 * xmenu.c (show_help_event, menu_help_callback):
5451 Adjust calls to `show_help_echo'.
5452
5453 * gtkutil.c (xg_maybe_add_timer):
5454 * keyboard.c (readable_events):
5455 * process.c (wait_reading_process_output):
5456 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5457
5458 * insdel.c (adjust_markers_gap_motion):
5459 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5460 (gap_left, gap_right): Don't call it.
5461
5462 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5463
5464 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5465 incurred during fontification.
5466
5467 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5468
5469 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5470 (DEFVAR_PER_BUFFER): Don't pass it.
5471
5472 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5473 (scrolling_window): Don't pass it.
5474
5475 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5476
5477 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5478
5479 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5480 and `suffix'.
5481 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5482 of variables specific to SELinux and computation of `encoded_absname'.
5483
5484 * image.c (XPutPixel): Remove unused variable `height'.
5485
5486 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5487
5488 * unexw32.c (get_section_info): Remove unused variable `section'.
5489
5490 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5491 (system_process_attributes): Remove unused variable `sess'.
5492 (sys_read): Remove unused variable `err'.
5493
5494 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5495 (w32_wnd_proc): Remove unused variable `isdead'.
5496 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5497 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5498 (x_create_tip_frame): Remove unused variable `tem'.
5499
5500 * w32inevt.c (w32_console_read_socket):
5501 Remove unused variable `no_events'.
5502
5503 * w32term.c (x_draw_composite_glyph_string_foreground):
5504 Remove unused variable `width'.
5505
5506 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5507
5508 * w32term.c (x_set_glyph_string_clipping):
5509 Don't pass uninitialized region to CombineRgn.
5510
5511 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5512
5513 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5514 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5515 (Fx_close_connection): Remove unused variable `i'.
5516
5517 * w32font.c (w32font_draw): Return number of glyphs.
5518 (w32font_open_internal): Remove unused variable `i'.
5519 (w32font_driver): Add missing initializer.
5520
5521 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5522 (fill_in_menu): Remove unused variable `items_added'.
5523
5524 * w32term.c (last_mouse_press_frame): Remove static global variable.
5525 (w32_clip_to_row): Remove unused variable `f'.
5526 (x_delete_terminal): Remove unused variable `i'.
5527
5528 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5529 (NOTHING): Remove unused static global variable.
5530 (uniscribe_check_otf): Remove unused variable `table'.
5531 (uniscribe_font_driver): Add missing initializers.
5532
5533 2011-03-23 Julien Danjou <julien@danjou.info>
5534
5535 * term.c (Fsuspend_tty, Fresume_tty):
5536 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5537 * window.c (temp_output_buffer_show):
5538 * insdel.c (signal_before_change):
5539 * frame.c (Fhandle_switch_frame):
5540 * fileio.c (Fdo_auto_save):
5541 * emacs.c (Fkill_emacs):
5542 * editfns.c (save_excursion_restore):
5543 * cmds.c (internal_self_insert):
5544 * callint.c (Fcall_interactively):
5545 * buffer.c (Fkill_all_local_variables):
5546 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5547 Use Frun_hooks.
5548 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5549 unconditionnaly since it does the check itself.
5550
5551 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5552
5553 Fix more problems found by GCC 4.5.2's static checks.
5554
5555 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5556 the first time through the loop, since we know p0 < p1 then.
5557 This also avoids a gcc -Wstrict-overflow warning.
5558
5559 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5560 leading to a memory leak, possible in functions like
5561 load_charset_map_from_file that can allocate an unbounded number
5562 of objects (Bug#8318).
5563
5564 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5565 that could (at least in theory) be that large.
5566
5567 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5568 This is less likely to overflow, and avoids undefined behavior if
5569 overflow does occur. All callers changed. Use strtoul to scan
5570 for the unsigned long integer.
5571 (pint2hrstr): Simplify and tune code slightly.
5572 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5573
5574 * scroll.c (do_scrolling): Work around GCC bug 48228.
5575 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5576
5577 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5578 This also avoids a warning with gcc -Wstrict-overflow.
5579 (validate_x_resource_name): Simplify count usage.
5580 This also avoids a warning with gcc -Wstrict-overflow.
5581
5582 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5583 fail (Bug#8306).
5584
5585 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5586
5587 * process.c (Fmake_network_process): Use socklen_t, not int,
5588 where POSIX says socklen_t is required in portable programs.
5589 This fixes a porting bug on hosts like 64-bit HP-UX, where
5590 socklen_t is wider than int (Bug#8277).
5591 (Fmake_network_process, server_accept_connection):
5592 (wait_reading_process_output, read_process_output):
5593 Likewise.
5594
5595 * process.c: Rename or move locals to avoid shadowing.
5596 (list_processes_1, Fmake_network_process):
5597 (read_process_output_error_handler, exec_sentinel_error_handler):
5598 Rename or move locals.
5599 (Fmake_network_process): Define label "retry_connect" only if needed.
5600 (Fnetwork_interface_info): Fix pointer signedness.
5601 (process_send_signal): Add cast to avoid pointer signedness problem.
5602 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5603 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5604
5605 Make tparam.h and terminfo.c consistent.
5606 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5607 Include tparam.h instead, since it declares them.
5608 * cm.h (PC): Remove extern decl; tparam.h now does this.
5609 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5610 * terminfo.c: Include tparam.h, to check interfaces.
5611 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5612 (tparam): Adjust signature to match interface in tparam.h;
5613 this removes some undefined behavior. Check that outstring and len
5614 are zero, which they always are with Emacs.
5615 * tparam.h (PC, BC, UP): New extern decls.
5616
5617 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5618 (xftfont_open): Rename locals to avoid shadowing.
5619
5620 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5621 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5622 (OTF_TAG_SYM): Omit macro if not needed.
5623 (ftfont_list): Remove unused local.
5624 (get_adstyle_property, ftfont_pattern_entity):
5625 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5626 Rename locals to avoid shadowing.
5627
5628 * xfont.c (xfont_list_family): Mark var as initialized.
5629
5630 * xml.c (make_dom): Now static.
5631
5632 * composite.c (composition_compute_stop_pos): Rename local to
5633 avoid shadowing.
5634 (composition_reseat_it): Remove unused locals.
5635 (find_automatic_composition, composition_adjust_point): Likewise.
5636 (composition_update_it): Mark var as initialized.
5637 (find_automatic_composition): Mark vars as initialized,
5638 with a FIXME (Bug#8290).
5639
5640 character.h: Rename locals to avoid shadowing.
5641 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5642 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5643 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5644 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5645 to avoid shadowing.
5646
5647 * textprop.c (property_change_between_p): Remove; unused.
5648
5649 * intervals.c (interval_start_pos): Now static.
5650
5651 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5652
5653 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5654 Rename locals to avoid shadowing.
5655
5656 * sound.c (wav_play, au_play, Fplay_sound_internal):
5657 Fix pointer signedness.
5658 (alsa_choose_format): Remove unused local var.
5659 (wav_play): Initialize a variable to 0, to prevent undefined
5660 behavior (Bug#8278).
5661
5662 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5663
5664 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5665
5666 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5667 clobbering (Bug#8298).
5668 * sysdep.c (sys_subshell): Likewise.
5669 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5670
5671 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5672 This should get cleaned up, so that child_setup has the
5673 same signature on all platforms.
5674
5675 * callproc.c (call_process_cleanup): Now static.
5676 (relocate_fd): Rename locals to avoid shadowing.
5677
5678 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5679
5680 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5681 not to be necessary, and produces flickering.
5682
5683 2011-03-20 Glenn Morris <rgm@gnu.org>
5684
5685 * config.in: Remove file.
5686
5687 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5688
5689 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5690 are now in src/globals.h.
5691 (syms_of_minibuf): Remove spurious & from previous change.
5692
5693 2011-03-20 Leo <sdl.web@gmail.com>
5694
5695 * minibuf.c (completing-read-function): New variable.
5696 (completing-read-default): Rename from completing-read.
5697 (completing-read): Call completing-read-function.
5698
5699 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5700
5701 * xfaces.c (Fx_load_color_file):
5702 Read color file from absolute filename (bug#8250).
5703
5704 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5705
5706 * makefile.w32-in: Update dependencies.
5707
5708 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5709
5710 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5711
5712 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5713
5714 Fix more problems found by GCC 4.5.2's static checks.
5715
5716 * process.c (make_serial_process_unwind, send_process_trap):
5717 (sigchld_handler): Now static.
5718
5719 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5720 That way, the code declares only the vars that it needs.
5721 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5722 * s/cygwin.h (PTY_ITERATION): Likewise.
5723 * s/darwin.h (PTY_ITERATION): Likewise.
5724 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5725
5726 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5727 * process.c (allocate_pty): Don't declare stb unless it's needed.
5728
5729 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5730 (CONSTANTLIM): Remove; unused.
5731 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5732 Define only if needed.
5733
5734 * unexelf.c (unexec): Name an expression,
5735 to avoid gcc -Wbad-function-cast warning.
5736 Use a different way to cause a compilation error if anyone uses
5737 n rather than nn, a way that does not involve shadowing.
5738 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5739
5740 * deps.mk (unexalpha.o): Remove; unused.
5741
5742 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5743 * unexec.h: New file.
5744 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5745 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5746 Depend on unexec.h.
5747 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5748 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5749 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5750 Change as necessary to match prototype in unexec.h.
5751
5752 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5753 shadowing.
5754 (back_comment, skip_chars): Mark vars as initialized.
5755
5756 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5757 Rename locals to avoid shadowing.
5758
5759 * lread.c (read1): Rewrite so as not to use empty "else".
5760 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5761
5762 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5763
5764 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5765 warning when compiling print.c.
5766
5767 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5768 instead of using an uninitialized var.
5769 (font_sort_entities): Mark var as initialized.
5770
5771 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5772
5773 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5774 pointers to constants.
5775 (font_parse_fcname): Remove unused vars.
5776 (font_delete_unmatched): Now static.
5777 (font_get_spec): Remove; unused.
5778 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5779 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5780 Rename or move locals to avoid shadowing.
5781
5782 * fns.c (require_nesting_list, require_unwind): Now static.
5783 (Ffillarray): Rename locals to avoid shadowing.
5784
5785 * floatfns.c (domain_error2): Define only if needed.
5786 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5787
5788 * alloc.c (mark_backtrace): Move decl from here ...
5789 * lisp.h: ... to here, so that it can be checked.
5790
5791 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5792 (Fdefvar): Rewrite so as not to use empty "else".
5793 (lisp_indirect_variable): Name an expression,
5794 to avoid gcc -Wbad-function-cast warning.
5795 (Fdefvar): Rename locals to avoid shadowing.
5796
5797 * callint.c (quotify_arg, quotify_args): Now static.
5798 (Fcall_interactively): Rename locals to avoid shadowing.
5799 Use const pointer when appropriate.
5800
5801 * lisp.h (get_system_name, get_operating_system_release):
5802 Move decls here, to check interfaces.
5803 * process.c (get_operating_system_release): Move decl to lisp.h.
5804 * xrdb.c (get_system_name): Likewise.
5805 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5806 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5807 some of which prompt warnings from gcc -Wbad-function-cast.
5808 (Fformat_time_string, Fencode_time, Finsert_char):
5809 (Ftranslate_region_internal, Fformat):
5810 Rename or remove local vars to avoid shadowing.
5811 (Ftranslate_region_internal): Mark var as initialized.
5812
5813 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5814 avoid shadowing.
5815
5816 * lisp.h (eassert): Check that the argument compiles, even if
5817 ENABLE_CHECKING is not defined.
5818
5819 * data.c (Findirect_variable): Name an expression, to avoid
5820 gcc -Wbad-function-cast warning.
5821 (default_value, arithcompare, arith_driver, arith_error): Now static.
5822 (store_symval_forwarding): Rename local to avoid shadowing.
5823 (Fmake_variable_buffer_local, Fmake_local_variable):
5824 Mark variables as initialized.
5825 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5826
5827 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5828 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5829 Rename locals to avoid shadowing.
5830 (mark_stack): Move local variables into the #ifdef region where
5831 they're used.
5832 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5833 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5834 needed otherwise.
5835 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5836 (GC_STRING_CHARS): Remove; not used.
5837 (Fmemory_limit): Cast sbrk's returned value to char *.
5838
5839 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5840 avoids undefined behavior in theory.
5841
5842 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5843
5844 Use functions, not macros, for up- and down-casing (Bug#8254).
5845 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5846 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5847 to use the following functions instead of these macros.
5848 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5849 EMACS_INT, since callers assume the returned value fits in int.
5850 (upcase1): Likewise, for UPCASE_TABLE.
5851 (uppercasep, lowercasep, upcase): New static inline functions.
5852 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5853 the race-condition problem in the old DOWNCASE.
5854
5855 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5856 Rename locals to avoid shadowing.
5857 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5858 (regex_compile, re_search_2, re_match_2_internal):
5859 Remove unused local vars.
5860 (FREE_VAR): Rewrite so as not to use empty "else",
5861 which gcc can warn about.
5862 (regex_compile, re_match_2_internal): Mark locals as initialized.
5863 (RETALLOC_IF): Define only if needed.
5864 (WORDCHAR_P): Likewise. This one is never needed, but is used
5865 only in a comment talking about a compiler bug, so put inside
5866 the #if 0 of that comment.
5867 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5868 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5869 Remove; unused.
5870
5871 * search.c (boyer_moore): Rename locals to avoid shadowing.
5872 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5873 (PREV_CHAR_BOUNDARY): Likewise.
5874
5875 * search.c (simple_search): Remove unused var.
5876
5877 * dired.c (compile_pattern): Move decl from here ...
5878 * lisp.h: ... to here, so that it can be checked.
5879 (struct re_registers): New forward decl.
5880
5881 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5882
5883 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5884 All uses changed.
5885 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5886 Rename locals to avoid shadowing.
5887 (Fvertical_motion): Mark locals as initialized.
5888
5889 * casefiddle.c (casify_object, casify_region): Now static.
5890 (casify_region): Mark local as initialized.
5891
5892 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5893
5894 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5895 New macros, so that the caller can use some names other than
5896 gcpro1, gcpro2, etc.
5897 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5898 of the new macros.
5899 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5900 argument, for consistency with GCPRO2_VAR, etc: it is now the
5901 prefix of the variable, not the variable itself. All uses
5902 changed.
5903 * dired.c (directory_files_internal, file_name_completion):
5904 Rename locals to avoid shadowing.
5905
5906 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5907 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5908 dired.c's scmp function, had undefined behavior.
5909 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5910 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5911 * buffer.h: ... to here, because these macros use current_buffer,
5912 and the new implementation with inline functions needs to have
5913 current_buffer in scope now, rather than later when the macros
5914 are used.
5915 (downcase, upcase1): New static inline functions.
5916 (DOWNCASE, UPCASE1): Reimplement using these functions.
5917 This avoids undefined behavior in expressions like
5918 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5919 from race conditions in accessing the global variables
5920 case_temp1 and case_temp2.
5921 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5922 * lisp.h (case_temp1, case_temp2): Remove their decls.
5923 * character.h (ASCII_CHAR_P): Move from here ...
5924 * lisp.h: ... to here, so that the inline functions mentioned
5925 above can use them.
5926
5927 * dired.c (directory_files_internal_unwind): Now static.
5928
5929 * fileio.c (file_name_as_directory, directory_file_name):
5930 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5931 Now static.
5932 (file_name_as_directory): Use const pointers when appropriate.
5933 (Fexpand_file_name): Likewise. In particular, newdir might
5934 point at constant storage, so make it a const pointer.
5935 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5936 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5937 signedness issues.
5938 (Fset_file_times, Finsert_file_contents, auto_save_error):
5939 Rename locals to avoid shadowing.
5940
5941 * minibuf.c (choose_minibuf_frame_1): Now static.
5942 (Ftry_completion, Fall_completions): Rename or remove locals
5943 to avoid shadowing.
5944
5945 * marker.c (bytepos_to_charpos): Remove; unused.
5946
5947 * lisp.h (verify_bytepos, count_markers): New decls,
5948 so that gcc does not warn that these functions aren't declared.
5949
5950 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5951 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5952 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5953 (copy_text): Remove unused local var.
5954
5955 * filelock.c (within_one_second): Now static.
5956 (lock_file_1): Rename local to avoid shadowing.
5957
5958 * buffer.c (fix_overlays_before): Mark locals as initialized.
5959 (fix_start_end_in_overlays): Likewise. This function should be
5960 simplified by using pointers-to-pointers, but that's a different
5961 matter.
5962 (switch_to_buffer_1): Now static.
5963 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5964 (report_overlay_modification): Rename locals to avoid shadowing.
5965
5966 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5967 Fix pointer signedness issue.
5968 (sys_subshell): Mark local as volatile if checking for lint,
5969 to suppress a gcc -Wclobbered warning that does not seem to be right.
5970 (MAXPATHLEN): Define only if needed.
5971
5972 * process.c (serial_open, serial_configure): Move decls from here ...
5973 * systty.h: ... to here, so that they can be checked.
5974
5975 * fns.c (get_random, seed_random): Move extern decls from here ...
5976 * lisp.h: ... to here, so that they can be checked.
5977
5978 * sysdep.c (reset_io): Now static.
5979 (wait_for_termination_signal): Remove; unused.
5980
5981 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5982 (copy_keymap_item, append_key, push_text_char_description):
5983 Now static.
5984 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5985 (DENSE_TABLE_SIZE): Remove; unused.
5986 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5987 (describe_map_tree):
5988 Rename locals to avoid shadowing.
5989
5990 * keyboard.c: Declare functions static if they are not used elsewhere.
5991 (echo_char, echo_dash, cmd_error, top_level_2):
5992 (poll_for_input, handle_async_input): Now static.
5993 (read_char, kbd_buffer_get_event, make_lispy_position):
5994 (make_lispy_event, make_lispy_movement, apply_modifiers):
5995 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5996 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5997 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5998 (read_key_sequence, read_char): Mark locals as initialized.
5999 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6000
6001 * keyboard.h (make_ctrl_char): New decl.
6002 (mark_kboards): Move decl here ...
6003 * alloc.c (mark_kboards): ... from here.
6004
6005 * lisp.h (force_auto_save_soon): New decl.
6006
6007 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6008 (DEFINE_DUMMY_FUNCTION): New macro.
6009 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6010 Use it.
6011 (main): Add casts to avoid warnings
6012 if GCC considers string literals to be constants.
6013
6014 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6015
6016 * dbusbind.c: Pointer signedness fixes.
6017 (xd_signature, xd_append_arg, xd_initialize):
6018 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6019 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6020 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6021 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6022
6023 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6024 if GCC considers string literals to be constants.
6025 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6026
6027 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6028
6029 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6030 (print_preprocess, print_object): New macro to fix last change.
6031
6032 * print.c (print_preprocess): Don't forget font objects.
6033
6034 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6035
6036 * emacs.c (USAGE3): Doc fixes.
6037
6038 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6039
6040 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6041 structure.
6042
6043 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6044
6045 * lisp.h (VWindow_system, Qfile_name_history):
6046 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6047 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6048 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6049
6050 * w32select.c: Don't #include "keyboard.h".
6051 (run_protected): Add extern declaration for waiting_for_input.
6052
6053 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6054 * w32console.c (detect_input_pending, read_input_pending)
6055 (encode_terminal_code):
6056 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6057 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6058 (w32_system_caret_y, Qfile_name_history):
6059 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6060 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6061 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6062 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6063 * w32proc.c (Qlocal, report_file_error):
6064 * w32term.c (Vwindow_system, updating_frame):
6065 * w32uniscribe.c (initialized, uniscribe_font_driver):
6066 Remove unneeded extern declarations.
6067
6068 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6069
6070 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6071
6072 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6073
6074 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6075 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6076 These macros can no longer be used for assignment.
6077
6078 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6079 Assign struct members directly, instead of using BUF_BEGV etc.
6080 (record_buffer_markers, fetch_buffer_markers): New functions for
6081 recording and fetching special buffer markers.
6082 (set_buffer_internal_1, set_buffer_temp): Use them.
6083
6084 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6085
6086 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6087
6088 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6089 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6090
6091 * xdisp.c (hscroll_window_tree):
6092 (reconsider_clip_changes): Use PT instead of BUF_PT.
6093
6094 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6095
6096 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6097 $(EMACS_ROOT)/lib/intprops.h.
6098
6099 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6100
6101 Fix more problems found by GCC 4.5.2's static checks.
6102
6103 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6104 to unsigned char * to avoid compiler diagnostic.
6105 (xg_free_frame_widgets): Make it clear that a local variable is
6106 needed only if USE_GTK_TOOLTIP.
6107 (gdk_window_get_screen): Make it clear that this macro is needed
6108 only if USE_GTK_TOOLTIP.
6109 (int_gtk_range_get_value): New function, which avoids a diagnostic
6110 from gcc -Wbad-function-cast.
6111 (xg_set_toolkit_scroll_bar_thumb): Use it.
6112 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6113 diagnostic from gcc -Wbad-function-cast.
6114 (get_utf8_string, xg_get_file_with_chooser):
6115 Rename locals to avoid shadowing.
6116 (create_dialog): Move locals to avoid shadowing.
6117
6118 * xgselect.c (xg_select): Remove unused var.
6119
6120 * image.c (four_corners_best): Mark locals as initialized.
6121 (gif_load): Initialize transparent_p to zero (Bug#8238).
6122 Mark another local as initialized.
6123 (my_png_error, my_error_exit): Mark with NO_RETURN.
6124
6125 * image.c (clear_image_cache): Now static.
6126 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6127 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6128 (x_edge_detection): Remove unnecessary cast that
6129 gcc -Wbad-function-cast diagnoses.
6130 (gif_load): Fix pointer signedness.
6131 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6132 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6133
6134 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6135
6136 Improve quality of tests for time stamp overflow.
6137 For example, without this patch (encode-time 0 0 0 1 1
6138 1152921504606846976) returns the obviously-bogus value (-948597
6139 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6140 reports time overflow. See
6141 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6142 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6143 * editfns.c: Include limits.h and intprops.h.
6144 (TIME_T_MIN, TIME_T_MAX): New macros.
6145 (time_overflow): Move earlier, to before first use.
6146 (hi_time, lo_time): New functions, for an accurate test for
6147 out-of-range times.
6148 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6149 (Fget_internal_run_time): Don't assume time_t fits in int.
6150 (make_time): Use list2 instead of Fcons twice.
6151 (Fdecode_time): More accurate test for out-of-range times.
6152 (check_tm_member): New function.
6153 (Fencode_time): Use it, to test for out-of-range times.
6154 (lisp_time_argument): Don't rely on undefined left-shift and
6155 right-shift behavior when checking for time stamp overflow.
6156
6157 * editfns.c (time_overflow): New function, refactoring common code.
6158 (Fformat_time_string, Fdecode_time, Fencode_time):
6159 (Fcurrent_time_string): Use it.
6160
6161 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6162 * dired.c (make_time): Move to ...
6163 * editfns.c (make_time): ... here.
6164 * systime.h: Note the move.
6165
6166 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6167
6168 * fringe.c (update_window_fringes): Remove unused variables.
6169
6170 * unexmacosx.c (copy_data_segment): Also copy __got section.
6171 (Bug#8223)
6172
6173 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6174
6175 * termcap.c [MSDOS]: Include "msdos.h".
6176 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6177 Constify `char *' arguments and their references according to
6178 prototypes in tparam.h.
6179
6180 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6181
6182 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6183 Adapt all references accordingly.
6184
6185 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6186
6187 2011-03-11 Tom Tromey <tromey@redhat.com>
6188
6189 * buffer.c (syms_of_buffer): Remove obsolete comment.
6190
6191 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6192
6193 * termhooks.h (encode_terminal_code): Declare prototype.
6194
6195 * msdos.c (encode_terminal_code): Don't declare prototype.
6196
6197 * term.c (encode_terminal_code): Now external again, used by
6198 w32console.c and msdos.c.
6199
6200 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6201 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6202
6203 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6204
6205 Fix some minor problems found by GCC 4.5.2's static checks.
6206
6207 * fringe.c (update_window_fringes): Mark locals as initialized
6208 (Bug#8227).
6209 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6210
6211 * alloc.c (mark_fringe_data): Move decl from here ...
6212 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6213 to check its interface.
6214 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6215
6216 * fontset.c (free_realized_fontset): Now static.
6217 (Fset_fontset_font): Rename local to avoid shadowing.
6218 (fontset_font): Mark local as initialized.
6219 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6220
6221 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6222
6223 * xselect.c (x_disown_buffer_selections): Remove; not used.
6224 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6225 (x_own_selection, Fx_disown_selection_internal): Rename locals
6226 to avoid shadowing.
6227 (x_handle_dnd_message): Remove local to avoid shadowing.
6228
6229 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6230 so that the caller can use some name other than gcpro1.
6231 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6232 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6233 (Fx_backspace_delete_keys_p):
6234 Use them to avoid shadowing, and rename vars to avoid shadowing.
6235 (x_decode_color, x_set_name, x_window): Now static.
6236 (Fx_create_frame): Add braces to silence GCC warning.
6237 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6238 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6239 Remove unused locals.
6240 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6241 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6242 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6243 macros.
6244
6245 * xterm.h (x_mouse_leave): New decl.
6246
6247 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6248 Remove unused functions.
6249 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6250 (x_calc_absolute_position): Now static.
6251 (XTread_socket): Don't define label "out" unless it's used.
6252 Don't declare local "event" unless it's used.
6253 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6254 unless they are used.
6255 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6256 (x_fatal_error_signal): Remove; not used.
6257 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6258 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6259 (x_error_catcher, x_connection_closed, x_error_handler):
6260 (x_error_quitter, xembed_send_message, x_iconify_frame):
6261 (my_log_handler): Rename locals to avoid shadowing.
6262 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6263 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6264
6265 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6266 Rename or move locals to avoid shadowing.
6267 (tty_defined_color, merge_face_heights): Now static.
6268 (free_realized_faces_for_fontset): Remove; not used.
6269 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6270 does not deduce is never used uninitialized.
6271 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6272 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6273
6274 * terminal.c (store_terminal_param): Now static.
6275
6276 * xmenu.c (menu_highlight_callback): Now static.
6277 (set_frame_menubar): Remove unused local.
6278 (xmenu_show): Rename parameter to avoid shadowing.
6279 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6280 since they might point to immutable storage.
6281 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6282 since it's unused otherwise.
6283
6284 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6285 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6286 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6287 avoids a gcc -Wuninitialized diagnostic.
6288 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6289 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6290 does not deduce are never used uninitialized.
6291
6292 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6293
6294 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6295 * window.c (window_loop, size_window):
6296 (run_window_configuration_change_hook, enlarge_window): Likewise.
6297
6298 * window.c (display_buffer): Now static.
6299 (size_window): Mark variables that gcc -Wuninitialized
6300 does not deduce are never used uninitialized.
6301 * window.h (check_all_windows): New decl, to forestall
6302 gcc -Wmissing-prototypes diagnostic.
6303 * dispextern.h (bidi_dump_cached_states): Likewise.
6304
6305 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6306 shadowing.
6307 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6308 Include <limits.h>.
6309 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6310 and to avoid gcc -Wuninitialized warning.
6311 (load_charset_map): Mark variables that gcc -Wuninitialized
6312 does not deduce are never used uninitialized.
6313 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6314
6315 * coding.c (coding_set_source, coding_set_destination):
6316 Use "else { /* comment */ }" rather than "else /* comment */;"
6317 for clarity, and to avoid gcc -Wempty-body warning.
6318 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6319 a block, when the outer 'i' will do.
6320 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6321 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6322 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6323 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6324 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6325 Rename locals to avoid shadowing.
6326 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6327 * coding.c (emacs_mule_char, encode_invocation_designation):
6328 Now static, since they're not used elsewhere.
6329 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6330 (decode_coding_object, encode_coding_object, detect_coding_system):
6331 (decode_coding_emacs_mule): Mark variables that gcc
6332 -Wuninitialized does not deduce are never used uninitialized.
6333 (detect_coding_iso_2022): Initialize a local variable that might
6334 be used uninitialized. Leave a FIXME because it's not clear that
6335 this initialization is needed. (Bug#8211)
6336 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6337 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6338 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6339 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6340 Remove unused macros.
6341
6342 * category.c (hash_get_category_set): Remove unused local var.
6343 (copy_category_table): Now static, since it's not used elsewhere.
6344 * character.c (string_count_byte8): Likewise.
6345
6346 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6347 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6348
6349 * chartab.c (copy_sub_char_table): Now static, since it's not used
6350 elsewhere.
6351 (sub_char_table_ref_and_range, char_table_ref_and_range):
6352 Rename locals to avoid shadowing.
6353 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6354
6355 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6356 (BIDI_BOB): Remove unused macro.
6357
6358 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6359 deduce are never used uninitialized.
6360 * term.c (encode_terminal_code): Likewise.
6361
6362 * term.c (encode_terminal_code): Now static. Remove unused local.
6363
6364 * tparam.h: New file.
6365 * term.c, tparam.h: Include it.
6366 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6367 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6368 Move these decls to tparam.h, and make them agree with what
6369 is actually in tparam.c. The previous trick of using incompatible
6370 decls in different modules does not conform to the C standard.
6371 All callers of tparam changed to use tparam's actual API.
6372 * tparam.c (tparam1, tparam, tgoto):
6373 Use const pointers where appropriate.
6374
6375 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6376 * cm.h (struct cm): Likewise.
6377 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6378 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6379 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6380 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6381 (turn_on_face, init_tty): Likewise.
6382 * termchar.h (struct tty_display_info): Likewise.
6383
6384 * term.c (term_mouse_position): Rename local to avoid shadowing.
6385
6386 * alloc.c (mark_ttys): Move decl from here ...
6387 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6388
6389 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6390
6391 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6392
6393 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6394
6395 * search.c (compile_pattern_1): Remove argument regp, unused since
6396 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6397 (compile_pattern): Don't pass it.
6398
6399 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6400
6401 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6402 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6403 for ! HAVE_GTK3.
6404 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6405
6406 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6407
6408 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6409 gdk_window_get_screen, gdk_window_get_geometry,
6410 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6411 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6412 (xg_get_pixbuf_from_pixmap): New function.
6413 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6414 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6415 Call xg_get_pixbuf_from_pixmap instead of
6416 gdk_pixbuf_get_from_drawable.
6417 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6418 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6419 (xg_check_special_colors): Use GtkStyleContext and its functions
6420 for HAVE_GTK3.
6421 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6422 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6423 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6424 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6425 Call gtk_widget_get_preferred_size.
6426 (xg_frame_resized): gdk_window_get_geometry only takes 5
6427 parameters.
6428 (xg_win_to_widget, xg_event_is_for_menubar):
6429 Call gdk_x11_window_lookup_for_display.
6430 (xg_set_widget_bg): New function.
6431 (delete_cb): New function.
6432 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6433 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6434 (xg_set_background_color): Call xg_set_widget_bg.
6435 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6436 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6437 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6438 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6439 if ! HAVE_GTK3.
6440 (update_frame_tool_bar): Call gtk_widget_hide.
6441 (xg_initialize): Use GDK_KEY_g.
6442
6443 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6444 if ! HAVE_GTK3
6445 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6446
6447 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6448 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6449 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6450
6451 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6452
6453 * w32xfns.c (select_palette): Check success of RealizePalette against
6454 GDI_ERROR, not zero.
6455
6456 See ChangeLog.11 for earlier changes.
6457
6458 ;; Local Variables:
6459 ;; coding: utf-8
6460 ;; End:
6461
6462 Copyright (C) 2011 Free Software Foundation, Inc.
6463
6464 This file is part of GNU Emacs.
6465
6466 GNU Emacs is free software: you can redistribute it and/or modify
6467 it under the terms of the GNU General Public License as published by
6468 the Free Software Foundation, either version 3 of the License, or
6469 (at your option) any later version.
6470
6471 GNU Emacs is distributed in the hope that it will be useful,
6472 but WITHOUT ANY WARRANTY; without even the implied warranty of
6473 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6474 GNU General Public License for more details.
6475
6476 You should have received a copy of the GNU General Public License
6477 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.