1 2012-07-27 Paul Eggert <eggert@cs.ucla.edu>
3 Adjust GDB to reflect pvec_type changes (Bug#12036).
4 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
5 2012-07-04 changes to pseudovector representation. Problem
6 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
8 2012-07-27 Michael Albinus <michael.albinus@gmx.de>
10 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
12 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
14 2012-07-27 Eli Zaretskii <eliz@gnu.org>
16 * alloc.c (listn): Fix the order the arguments are consed onto the
19 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
20 enumeration constants, as PURE and HEAP are too general, and clash
21 with other headers and sources, such as gmalloc.c and the
22 MS-Windows system headers. All users changed.
24 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
26 Revert last save_excursion_save and save_excursion_restore changes.
27 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
28 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
30 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
32 Fix recently-introduced typos in Windows port.
33 Reported by Martin Rudalics <rudalics@gmx.at>.
34 * w32.c (init_environment): Replace comma with semicolon.
35 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
37 2012-07-27 Paul Eggert <eggert@cs.ucla.edu>
39 Improve GDB symbol export (Bug#12036).
40 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
41 arms of an 'if', not using conditional expressions; otherwise GDB
42 complains about the types in the unevaluated arm when the argument
43 is an integer literal.
44 (xgetint): Simplify expression.
45 * alloc.c (gdb_make_enums_visible): New constant. This ports to
46 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
47 Zaretskii in <http://bugs.gnu.org/12036#13>.
48 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
49 needed now that we have gdb_make_enums_visible.
50 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
51 (enum enum_USE_LSB_TAG):
52 New enum types, packaging up enums that need to be exported to GDB.
54 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
56 Utility function to make a list from specified amount of objects.
57 * lisp.h (enum constype): New datatype.
58 (listn): New prototype.
59 * alloc.c (listn): New function.
60 (Fmemory_use_count, syms_of_alloc): Use it.
61 * buffer.c (syms_of_buffer): Likewise.
62 * callint.c (syms_of_callint): Likewise.
63 * charset.c (define_charset_internal): Likewise.
64 * coding.c (syms_of_coding): Likewise.
65 * keymap.c (syms_of_keymap): Likewise.
66 * search.c (syms_of_search): Likewise.
67 * syntax.c (syms_of_syntax): Likewise.
68 * w32.c (init_environment): Likewise.
69 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
70 * xdisp.c (syms_of_xdisp): Likewise.
71 * xfns.c (syms_of_xfns): Likewise.
73 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
75 Fast save_excursion_save and save_excursion_restore.
76 * lisp.h (struct Lisp_Excursion): New data type.
77 (PVEC_EXCURSION): New pseudovector type.
78 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
79 to deal with it. Adjust comments.
80 (init_marker, attach_marker): New prototype.
81 (unchain_marker): Adjust prototype.
82 * marker.c (attach_marker): Change to global.
83 (init_marker): New function.
84 * alloc.c (Fmake_marker, build_marker): Use it.
85 (build_marker): More easserts.
86 (mark_object): Handle struct Lisp_Excursion.
87 * editfns.c (save_excursion_save, save_excursion_restore):
88 Reimplement to use struct Lisp_Excursion. Add comments.
90 2012-07-26 Paul Eggert <eggert@cs.ucla.edu>
92 Fix export of symbols to GDB (Bug#12036).
93 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
94 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
95 emacs.c, as this is a more-suitable home. Had this been done earlier
96 the fix for 12036 would have avoided some of the problems noted in
97 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
98 would have been more obvious.
99 * emacs.c: Do not include <verify.h>; no longer needed.
100 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
101 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
102 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
103 Remove; now done in lisp.h.
104 * lisp.h (PUBLISH_TO_GDB): New macro.
105 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
106 (DATA_SEG_BITS): Use it.
107 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
108 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
109 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
110 not be usable in #if. This simplifies things.
112 2012-07-26 Juanma Barranquero <lekktu@gmail.com>
114 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
116 2012-07-26 Paul Eggert <eggert@cs.ucla.edu>
118 Simplify export of symbols to GDB (Bug#12036).
119 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
120 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
121 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
122 Adjust to changes in lisp.h and emacs.c, by using
123 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
124 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
125 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
126 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
127 instead of gdb_valbits.
128 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
129 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
130 instead of gdb_array_mark_flag.
131 (xboolvector): Get size from $->size, not $->header.size.
132 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
133 (xreload, hook-run, hookpost-run): Remove.
134 * emacs.c: Include <verify.h>.
135 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
136 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
138 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
139 (gdb_USE_LSB_TAG): New enum constants.
140 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
141 Also define these as enum constants, so they're visible to GDB.
142 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
143 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
144 as constants, so they're visible to GDB.
145 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
146 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
147 Now enum constants, not macros, so they're visible to GDB.
148 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
149 more convenient now. All uses changed.
150 (VALMASK) [USE_LSB_TAG]: Also define in this case.
151 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
153 2012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
155 Explicitly free restriction data that are not needed anymore.
156 * editfns.c (save_restriction_restore): Free restriction data.
158 2012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
160 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
161 add argument, tune behavior, and adjust all callers.
163 2012-07-25 Paul Eggert <eggert@cs.ucla.edu>
165 Use typedef for EMACS_INT, EMACS_UINT.
166 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
167 than macros. This simplifies debugging in the usual case, since
168 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
169 and it allows expressions involving EMACS_INT casts.
170 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
172 2012-07-25 Jan Djärv <jan.h.d@swipnet.se>
174 * nsterm.m (ns_read_socket): Return early if there is a modal
177 2012-07-25 Martin Rudalics <rudalics@gmx.at>
179 * frame.c (Fredirect_frame_focus): In doc-string don't mention
180 that FOCUS-FRAME can be omitted.
182 2012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
184 Adjust buffer text indirection counters at the end of Fkill_buffer.
185 * buffer.c (Fkill_buffer): Adjust indirection counters when the
186 buffer is definitely dead. This should really fix an issue reported
187 by Christoph Scholtes again. (Bug#12007).
188 (init_buffer_once): Initialize indirection counters of
189 buffer_defaults and buffer_local_symbols (for sanity and safety).
191 2012-07-24 Eli Zaretskii <eliz@gnu.org>
193 * xdisp.c (init_iterator): Don't compute dimensions of truncation
194 and continuation glyphs on tooltip frames, leave them at zero.
195 Avoids continued lines in tooltips. (Bug#11832)
197 2012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
199 Simplify copy_overlay.
200 * buffer.c (copy_overlay): Simplify. Use build_marker.
201 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
203 2012-07-23 Eli Zaretskii <eliz@gnu.org>
205 * print.c (print_object): Don't crash when a frame's name is nil
206 or invalid. (Bug#12025)
208 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
209 it signals an error when a tooltip frame is being created.
211 2012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
213 Cleanup miscellaneous objects allocation and initialization.
214 * alloc.c (allocate_misc): Change to static. Add argument to
215 specify the subtype. Adjust comment and users.
216 (build_overlay): New function.
217 * buffer.c (copy_overlays, Fmake_overlay): Use it.
218 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
219 (allocate_misc): Remove prototype.
220 (build_overlay): Add prototype.
222 2012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
224 Swap buffer text indirection counters in Fbuffer_swap_text.
225 * buffer.c (Fbuffer_swap_text): Swap indirections too.
226 This avoids crash reported by Christoph Scholtes at
227 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
229 2012-07-22 Jan Djärv <jan.h.d@swipnet.se>
231 * nsmenu.m (Popdown_data): New struct.
232 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
234 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
235 (initWithContentRect): Make imgView and contentView non-static
236 and autorelease them. Also autorelease img and matrix (Bug#12005).
237 (dealloc): Remove (Bug#12005).
239 2012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
241 Adjust consing_since_gc when objects are explicitly freed.
242 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
243 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
244 (free_cons, free_misc): Subtract object size from consing_since_gc.
246 2012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
248 Simplify and cleanup markers positioning code.
249 * marker.c (attach_marker): More useful eassert.
250 (live_buffer, set_marker_internal): New function.
251 (Fset_marker, set_marker_restricted): Use set_marker_internal.
252 (set_marker_both, set_marker_restricted_both): Use live_buffer.
254 2012-07-22 Paul Eggert <eggert@cs.ucla.edu>
256 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
257 as it's limited by the amount of memory, not by INT_MAX.
259 2012-07-21 Eli Zaretskii <eliz@gnu.org>
261 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
262 in special-event-map. See the discussion at
263 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
266 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
267 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
268 Fabrice Popineau <fabrice.popineau@supelec.fr>.
270 2012-07-21 Jan Djärv <jan.h.d@swipnet.se>
272 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
273 (conversationIdentifier): Return value is NSInteger.
274 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
276 2012-07-21 Chong Yidong <cyd@gnu.org>
278 * window.c (decode_any_window): Signal an error if the window is
279 on a dead frame (Bug#11984).
281 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
283 Add indirection counting to speed up Fkill_buffer.
284 * buffer.h (struct buffer): New member.
285 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
286 (Fmake_indirect_buffer): Set indirection counter to -1, increment
287 base buffer indirection counter.
288 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
289 (Fkill_buffer): Adjust indirection counters as needed, don't walk
290 through buffer list if indirection counter is 0.
292 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
294 Extend the value returned by Fgarbage_collect with heap statistics.
295 * alloc.c (Qheap): New symbol.
296 (syms_of_alloc): DEFSYM it.
297 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
298 (Fmemory_free): Remove.
299 (syms_of_alloc): Don't defsubr it.
300 * buffer.c (Fcompact_buffer): Remove.
301 (syms_of_buffer): Don't defsubr it.
303 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
305 Make maybe_gc inline.
306 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
307 * lisp.h (consing_since_gc, gc_relative_threshold)
308 (memory_full_cons_threshold): Revert declaration.
309 (maybe_gc): Remove prototype, define as inline.
310 * alloc.c: Remove old commented-out code.
311 (consing_since_gc, gc_relative_threshold)
312 (memory_full_cons_threshold): Revert to global.
315 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
317 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
318 * lisp.h (build_unibyte_string): New function.
319 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
320 * sysdep.c, w32fns.c, xfns.c: Use it.
321 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
322 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
323 Adjust users accordingly.
324 * font.h (font_open_by_name): Adjust prototype.
326 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
328 Cleanup calls to Fgarbage_collect.
329 * lisp.h (maybe_gc): New prototype.
330 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
332 * alloc.c (maybe_gc): New function.
333 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
335 * bytecode.c (MAYBE_GC): Use maybe_gc.
336 * eval.c (eval_sub, Ffuncall): Likewise.
337 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
338 to avoid dependency from auto-save feature.
340 2012-07-19 Paul Eggert <eggert@cs.ucla.edu>
342 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
343 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
344 'for_each_per_buffer_object_at'.
345 All uses changed. It's better to use upper-case for macros that
346 cannot be implemented as functions, to give the reader a clue
347 that they're special.
349 2012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
351 * alloc.c (Fgarbage_collect): Tweak docstring.
353 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
355 Tweak the value returned from Fgarbage_collect again.
356 * alloc.c (Fgarbage_collect): New return value, as confirmed in
357 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
358 Adjust documentation.
359 (total_vector_bytes): Rename to total_vector_slots, adjust
361 (total_free_vector_bytes): Rename to total_free_vector_slots,
363 (Qstring_bytes, Qvector_slots): New symbols.
364 (syms_of_alloc): DEFSYM them.
366 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
368 Buffer compaction primitive which may be used from Lisp.
369 * buffer.c (compact_buffer, Fcompact_buffer): New function.
370 (syms_of_buffer): Register Fcompact_buffer.
371 * alloc.c (Fgarbage_collect): Use compact_buffer.
372 * buffer.h (compact_buffer): New prototype.
373 (struct buffer_text): New member.
375 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
377 New macro to iterate over all buffers, miscellaneous cleanups.
378 * lisp.h (all_buffers): Remove declaration.
379 * buffer.h (all_buffers): Add declaration, with comment.
380 (for_each_buffer): New macro.
381 * alloc.c (Fgarbage_collect, mark_object): Use it.
382 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
383 (init_buffer): Likewise.
384 * data.c (Fset_default): Likewise.
385 * coding.c (code_conversion_restore): Remove redundant check
387 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
389 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
391 Fix bug that created negative-length intervals.
392 * intervals.c (merge_interval_right, merge_interval_left):
393 Do not zero out this interval if it is absorbed by its children,
394 as this interval's total length doesn't change in that case. See
395 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
397 2012-07-18 Paul Eggert <eggert@cs.ucla.edu>
399 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
400 when invoking (make-bool-vector N t) and N is a positive
401 multiple of 8 -- the last 8 bits were mistakenly cleared.
403 Remove some struct layout assumptions in bool vectors.
404 * alloc.c (bool_header_size): New constant.
405 (header_size, word_size): Move earlier, as they're now used earlier.
406 Use 'word_size' in a few more places, where it's appropriate.
407 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
408 padding before the data member of a bool vector.
409 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
410 than doing the check by hand with an abort ().
412 2012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
414 * eval.c (Fdefvar): Don't check constants since we only set the var if
415 it's not yet defined anyway (bug#11904).
417 * lisp.h (last_undo_boundary): Declare new var.
418 * keyboard.c (command_loop_1): Set it.
419 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
420 were auto-added by the command loop (bug#11774).
422 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
424 * w32font.c (Qsymbol): Remove local definition.
425 (syms_of_w32font): Don't DEFSYM it.
427 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
429 Fix sweep_vectors to handle large bool vectors correctly.
430 * alloc.c (sweep_vectors): Account total_vector_bytes for
431 bool vectors larger than VBLOCK_BYTES_MAX.
433 2012-07-18 Chong Yidong <cyd@gnu.org>
435 * frame.c (x_set_frame_parameters): Revert bogus change introduced
436 in 2012-05-25 commit by Paul Eggert (Bug#11738).
438 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
440 Return more descriptive data from Fgarbage_collect.
441 Suggested by Stefan Monnier in
442 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
443 * alloc.c (bounded_number): New function.
444 (total_buffers, total_vectors): New variable.
445 (total_string_size): Rename to total_string_bytes, adjust users.
446 (total_vector_size): Rename to total_vector_bytes, adjust users.
447 (sweep_vectors): Account total_vectors and total_vector_bytes.
448 (Fgarbage_collect): New return value. Adjust documentation.
449 (gc_sweep): Account total_buffers.
450 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
451 (VECTOR_SIZE): Remove.
452 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
453 (Qinterval, Qmisc): New symbols.
454 (syms_of_data): Initialize them.
455 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
456 (Qcons, Qbuffer): New declarations.
458 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
460 * alloc.c (Fmemory_free): Account for memory-free's own storage.
461 Round up, not down. Improve doc.
463 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
465 Restore old code in allocate_string_data to avoid Faset breakage.
466 Reported by Julien Danjou <julien@danjou.info> in
467 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
468 * alloc.c (allocate_string_data): Restore old code with minor
469 adjustments, fix comment to explain this subtle issue.
471 2012-07-17 Eli Zaretskii <eliz@gnu.org>
473 Remove FILE_SYSTEM_CASE.
474 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
476 * fileio.c (FILE_SYSTEM_CASE): Don't define.
477 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
478 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
479 call-process-region passes it through expand-file-name.
481 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
483 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
485 Fix crash when creating indirect buffer (Bug#11917)
486 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
487 Don't handle unbound variables specially if non-zero.
488 (Fbuffer_local_variables): Pass zero.
489 (clone_per_buffer_values): Pass non-zero.
491 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
493 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
494 to make the loop interruptible.
496 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
498 * gnutls.c (emacs_gnutls_handshake): Only retry if
499 GNUTLS_E_INTERRUPTED.
501 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
503 Cleanup and convert miscellaneous checks to eassert.
504 * alloc.c (mark_interval): Fix comment, partially rephrase
505 old comment from intervals.h (see below).
506 * intervals.c (find_interval, adjust_intervals_for_insertion)
507 (delete_interval, adjust_intervals_for_deletion)
508 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
510 (adjust_intervals_for_insertion, make_new_interval):
511 Remove obsolete and unused code.
512 * intervals.h (struct interval): Remove obsolete comment.
513 * textprotp.c (erase_properties): Remove unused code.
514 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
515 (Fremove_list_of_text_properties): Convert to eassert.
517 2012-07-17 Chong Yidong <cyd@gnu.org>
519 * editfns.c (Finsert_char): Doc fix.
521 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
523 Fix previous change to make Fmemory_free always accurate.
524 * alloc.c (make_interval): Update total_free_intervals.
525 (make_float): Likewise for total_free_floats.
526 (free_cons, Fcons): Likewise for total_free_conses.
527 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
528 Likewise for total_free_vector_bytes.
529 (Fmake_symbol): Likewise for total_free_symbols.
530 (bytes_free): Remove.
532 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
534 Simple free memory accounting feature.
535 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
536 (sweep_vectors): Accumulate size of free vectors.
537 (Fgarbage_collect): Setup bytes_free.
538 (Fmemory_free): New function.
539 (syms_of_alloc): Register it.
541 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
543 Cleanup overlays checking.
544 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
545 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
546 eassert and OVERLAYP.
547 (sort_overlays): Change to use OVERLAYP.
549 2012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
551 * editfns.c (Finsert_char): Make it interactive, and make the
552 second arg optional. Copy interactive spec and docstring from
555 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
557 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
558 Unlike the other wrapped functions, fabs has an unspecified
561 2012-07-16 Jan Djärv <jan.h.d@swipnet.se>
563 * nsterm.m (keyDown): Interpret flags without left/right bits
564 as the left key (Bug#11670).
566 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
568 Remove empty and useless init functions.
569 * lisp.h (init_character_once, init_fns, init_image)
570 (init_filelock, init_sound): Remove prototype.
571 * character.c (init_character_once): Remove.
572 * filelock.c (init_filelock): Likewise.
573 * fns.c (init_fns): Likewise.
574 * image.c (init_image): Likewise.
575 * sound.c (init_sound): Likewise.
576 * emacs.c (main): Adjust accordingly.
578 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
580 * gtkutil.h: Tiny cleanups.
581 (use_old_gtk_file_dialog): Remove useless declaration.
582 (xg_uses_old_file_dialog): Add suggested const attribute.
584 2012-07-15 Eli Zaretskii <eliz@gnu.org>
586 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
587 (bidi_paragraph_init): Use it to limit search forward for a strong
588 directional character in abnormally large paragraphs full of
589 neutral or weak characters. (Bug#11943)
591 2012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
593 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
594 the toolbar (Bug#9451).
595 (xg_make_tool_item): Give the widget event box a transparent
598 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
600 Cleanup basic allocation variables and functions.
601 * alloc.c (ignore_warnings, init_intervals, init_float)
602 (init_cons, init_symbol, init_marker): Remove.
603 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
604 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
605 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
606 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
607 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
608 (staticidx, init_alloc_once, init_strings, free_ablock):
609 Remove redundant initialization.
610 * fns.c (init_weak_hash_tables): Remove.
611 * lisp.h (init_weak_hash_tables): Remove prototype.
613 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
615 Use zero_vector where appropriate.
616 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
618 * lisp.h (zero_vector): New declaration.
619 * font.c (null_vector): Remove.
620 (syms_of_font): Remove initialization and staticpro.
621 (font_list_entities, font_find_for_lface): Change to use zero_vector.
622 * keymap.c (Faccessible_keymaps): Likewise.
624 2012-07-15 Leo Liu <sdl.web@gmail.com>
626 * fringe.c: Fix typo in comments.
628 2012-07-14 Leo Liu <sdl.web@gmail.com>
630 * fringe.c: Add a new bitmap exclamation-mark.
632 2012-07-14 Eli Zaretskii <eliz@gnu.org>
634 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
636 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
637 (HAVE_MENUS): Don't define, defined by editing config.in with
639 (GMALLOC_INHIBIT_VALLOC): Don't define.
640 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
642 2012-07-14 Juanma Barranquero <lekktu@gmail.com>
644 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
646 2012-07-14 Glenn Morris <rgm@gnu.org>
648 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
649 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
650 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
652 2012-07-13 Glenn Morris <rgm@gnu.org>
654 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
656 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
657 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
659 2012-07-13 Jan Djärv <jan.h.d@swipnet.se>
661 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
662 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
663 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
664 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
666 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
667 as boolean expression.
668 (x_set_window_size): Remove unused variable toolbar.
669 (ns_get_color_default, ns_mod_to_lisp): Remove.
670 (ns_mouse_position): Remove unused variables xchar and ychar.
671 (ns_compute_glyph_string_overhangs): Remove unused variable face.
672 (ns_set_vertical_scroll_bar): Remove unused variable count.
673 (ns_delete_terminal): Remove unused variable i.
674 (ns_term_init): Remove unused variables r, g and b.
675 (mouseDown): Remove unused variable window.
676 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
677 (initFrameFromEmacs): Remove unused variable vbextra.
678 (mouseEntered): Remove unused variables p and dpyinfo.
679 (mouseExited): Remove unused variables p and r.
680 (ns_define_frame_cursor, ns_clear_frame_area)
681 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
682 (menuDown): Assign [sender tag] to variable and cast the variable.
684 * nsterm.h (menuDown): Add id as type to argument sender.
685 (ns_display_info_for_name): Add Lisp_Object argument.
686 (ns_term_init): Add Lisp_Object argument.
687 (ns_map_event_to_object): Add void argument.
688 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
689 prototype with arguments and only declare if __OBJC__.
690 (nxatoms_of_nsselect): Add void argument.
691 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
692 (ns_alloc_autorelease_pool): Add void argument.
693 (ns_release_autorelease_pool): Add void* argument.
694 (ns_get_defaults_value): Add const char* argument.
696 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
697 (initFromContents): Use SSDATA where appropriate.
698 (ns_update_menubar): Add braces to ambigous if-else.
699 (initWithTitle): Put () around assignment in if statement.
700 (ns_menu_show): Remove unused variables window and keymap.
701 (update_frame_tool_bar): Remove unused variable selected_p.
702 (initWithContentRect): Remove unused variable this_cmd_name.
704 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
706 (setXBMColor): Remove unused variable len.
707 (setPixmapData): Put () around assignment in loop statement.
709 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
710 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
712 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
713 around assignment in loop statement.
714 (nsfont_open): Remove unused variable i.
715 (nsfont_open): Remove unused variable len.
716 (nsfont_draw): Remove unused variable cs.
718 * nsfns.m (x_set_icon_name, ns_set_name_internal)
719 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
720 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
721 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
722 (Fns_font_name, Fns_perform_service)
723 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
724 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
725 (ns_set_name): Remove unused variable view.
726 (x_set_menu_bar_lines): Remove unused variable olines.
727 (x_set_tool_bar_lines): Remove unused variable root_window.
728 (Fns_list_colors): Put () around assignment in while statement.
729 (Fns_perform_service): Remove unused variable len.
730 (Fns_display_usable_bounds): Remove unused variable top.
731 (syms_of_nsfns): Remove unused variable i.
733 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
736 2012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
738 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
739 and free it with DestroyExceptionInfo (Bug#11558).
741 2012-07-13 Juanma Barranquero <lekktu@gmail.com>
743 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
744 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
745 Set here, not in nt/config.nt.
747 2012-07-13 Eli Zaretskii <eliz@gnu.org>
749 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
750 cursor overflow into the last glyph on display line when the right
751 fringe is off. (Bug#11832)
753 2012-07-13 Paul Eggert <eggert@cs.ucla.edu>
755 * xdisp.c (produce_special_glyphs): Now static.
756 * dispextern.h (produce_special_glyphs): Remove decl.
758 2012-07-13 Glenn Morris <rgm@gnu.org>
760 * s/bsd-common, s/cygwin.h: Remove empty files.
761 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
763 * s/usg5-4-common.h (USG, USG5):
764 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
765 * s/sol2-6.h (SOLARIS2):
766 * s/irix6-5.h (IRIX6_5):
767 * s/hpux10-20.h (USG, USG5, HPUX):
768 * s/gnu-linux.h (USG, GNU_LINUX):
769 * s/freebsd.h (BSD_SYSTEM):
770 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
771 * s/cygwin.h (CYGWIN):
772 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
773 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
775 2012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
777 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
779 2012-07-13 Glenn Morris <rgm@gnu.org>
781 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
783 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
785 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
786 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
788 2012-07-12 Glenn Morris <rgm@gnu.org>
790 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
792 * process.c (init_process_emacs): Rename from init_process.
793 The old name is also the name of a Mach system call.
794 * lisp.h, emacs.c: Update for this name change.
795 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
798 2012-07-12 Eli Zaretskii <eliz@gnu.org>
800 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
801 memmove call that removes glyphs covered by the left truncation
802 glyph. Improve commentary.
803 (display_line): Fix display of continuation glyphs on GUI frames
804 when the right fringe is turned off and variable-size fonts are
805 used in the window. Move the code that appends a stretch glyph to
806 produce_special_glyphs, so that it could be used for truncation
807 and continuation glyphs alike.
808 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
809 glyph of a suitably computed width, to align the special glyphs at
810 the window margin. Code moved from display_line. (Bug#11832)
812 2012-07-12 Glenn Morris <rgm@gnu.org>
814 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
816 * s/gnu-linux.h, s/hpux10-20.h:
817 Do not unconditionally define HAVE_XRMSETDATABASE.
819 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
821 2012-07-12 Paul Eggert <eggert@cs.ucla.edu>
823 Fix typos that broke OS X build.
824 Reported by Randal L. Schwartz in
825 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
826 * nsterm.m (ns_timeout): Add missing local decl.
827 (ns_get_color): snprintf -> sprintf, to fix typo.
829 2012-07-12 Glenn Morris <rgm@gnu.org>
831 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
832 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
833 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
834 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
836 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
837 Move PTY_OPEN to configure.
839 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
840 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
841 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
843 2012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
845 Use empty_unibyte_string where applicable.
846 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
847 * lread.c (read1): Likewise.
848 * xsettings.c (syms_of_xsettings): Likewise.
850 2012-07-12 Glenn Morris <rgm@gnu.org>
852 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
853 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
854 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
855 * s/hpux10-20.h (RUN_TIME_REMAP):
856 * s/bsd-common.h (TABDLY): Move to configure.
858 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
860 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
862 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
863 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
865 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
867 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
868 * s/template.h: Move NARROWPROTO to configure.
870 2012-07-11 Glenn Morris <rgm@gnu.org>
872 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
873 unused since 2011-01-17 change to systty.h.
875 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
876 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
877 Move HAVE_PTYS and HAVE_SOCKETS to configure.
879 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
881 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
883 2012-07-11 Glenn Morris <rgm@gnu.org>
885 * s/darwin.h, s/gnu-linux.h, s/template.h:
886 Move INTERRUPT_INPUT to configure.
888 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
890 Minor adjustments to interning code.
891 * lisp.h (intern, intern_c_string): Redefine as static inline
892 wrappers for intern_1 and intern_c_string_1, respectively.
893 (intern_1, intern_c_string_1): Rename prototypes.
894 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
896 * font.c (font_intern_prop): Likewise. Adjust comment.
897 * w32font.c (intern_font_name): Likewise.
899 2012-07-11 Andreas Schwab <schwab@linux-m68k.org>
901 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
903 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
904 of Fcar/Fcdr if possible.
905 * font.c (check_otf_features): Likewise.
906 * fontset.c (Fnew_fontset): Likewise.
907 * gnutls.c (Fgnutls_boot): Likewise.
908 * minibuf.c (read_minibuf): Likewise.
909 * msdos.c (IT_set_frame_parameters): Likewise.
910 * xmenu.c (Fx_popup_dialog): Likewise.
911 * w32menu.c (Fx_popup_dialog): Likewise.
913 2012-07-11 Glenn Morris <rgm@gnu.org>
915 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
916 since nothing has defined it on these platforms.
918 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
919 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
921 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
922 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
923 Move CLASH_DETECTION to configure.
925 * s/gnu.h: Remove file, which is now empty.
927 * s/gnu.h, s/gnu-linux.h:
928 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
930 2012-07-11 John Wiegley <johnw@newartisans.com>
932 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
933 function attribute, so we only use it if it exists in the
936 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
938 Avoid call to strlen in fast_c_string_match_ignore_case.
939 * search.c (fast_c_string_match_ignore_case): Change to use
940 length argument. Adjust users accordingly.
941 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
943 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
946 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
947 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
950 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
953 * s/hpux10-20.h (HAVE_PERROR): Remove.
954 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
955 Remove dummy definition, as this problem was obsolete long ago.
958 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
960 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
962 Avoid calls to strlen in font processing functions.
963 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
964 (font_open_by_name): Change to use length argument. Adjust
966 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
968 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
969 Change to return ptrdiff_t.
970 (xfont_list_pattern, xfont_match): Use length returned by
971 xfont_decode_coding_xlfd.
972 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
974 2012-07-11 Glenn Morris <rgm@gnu.org>
976 * s/darwin.h, s/freebsd.h, s/netbsd.h:
977 Move DONT_REOPEN_PTY to configure.
979 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
980 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
982 2012-07-10 Paul Eggert <eggert@cs.ucla.edu>
984 Remove "#define unix" that is no longer needed (Bug#11905).
985 * s/aix4-2.h (unix): Remove; no longer needed.
987 EMACS_TIME simplification (Bug#11875).
988 This replaces macros (which typically do not work in GDB)
989 with functions, typedefs and enums, making the code easier to debug.
990 The functional style also makes code easier to read and maintain.
991 * systime.h: Include <sys/time.h> on all hosts, not just if
992 WINDOWSNT, since 'struct timeval' is needed in general.
993 (EMACS_TIME): Now a typedef, not a macro.
994 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
996 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
997 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
998 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
999 (EMACS_TIME_LE): Now functions, not macros.
1000 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1001 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1002 which are not functions. All uses rewritten to use:
1003 (make_emacs_time): New function.
1004 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1005 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1006 not functions. All uses rewritten to use the following, respectively:
1007 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1008 (add_emacs_time, sub_emacs_time): New functions.
1009 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
1010 * fileio.c (Fcopy_file):
1011 * xterm.c (XTflash): Get the current time closer to when it's used.
1012 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1014 * bytecode.c (targets): Suppress -Woverride-init warnings.
1016 Simplify by avoiding confusing use of strncpy etc.
1017 * doc.c (Fsnarf_documentation):
1018 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1019 * frame.c (Fmake_terminal_frame):
1020 * gtkutil.c (get_utf8_string):
1022 * nsmenu.m (ns_update_menubar):
1023 * regex.c (regerror):
1024 Prefer memcpy to strncpy and strncat when either will do.
1025 * fileio.c (Fsubstitute_in_file_name):
1026 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1027 (menu_separator_name_p):
1028 * nsmenu.m (ns_update_menubar):
1029 Prefer memcmp to strncmp when either will do.
1030 * nsterm.m: Include <ftoastr.h>.
1032 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1033 Prefer snprintf to strncpy.
1034 * nsterm.m (ns_term_init):
1035 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1036 * nsterm.m (ns_term_init):
1037 Avoid the need for strncpy, by using build_string or
1038 make_unibyte_string directly. Use dtoastr, not snprintf.
1039 * process.c (Fmake_network_process): Diagnose service names that
1040 are too long, rather than silently truncating them or creating
1041 non-null-terminated names.
1042 (Fnetwork_interface_info): Likewise, for interface names.
1043 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1044 Prefer sprintf to strncat.
1045 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1046 Prefer vsnprintf to vsprintf + strncpy.
1048 2012-07-10 Glenn Morris <rgm@gnu.org>
1050 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1051 Clarify fallback case.
1053 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1055 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1056 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1057 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
1058 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
1059 where argument type is known to be a Lisp_Cons.
1061 2012-07-10 Tom Tromey <tromey@redhat.com>
1063 * bytecode.c (BYTE_CODE_THREADED): New macro.
1064 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1065 (enum byte_code_op): New type.
1066 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1067 (exec_byte_code): Use them. Use token threading when applicable.
1069 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1071 Optimize pure C strings initialization.
1072 * lisp.h (make_pure_string): Fix prototype.
1073 (build_pure_c_string): New function, defined as static inline. This
1074 provides a better opportunity to optimize away calls to strlen when
1075 the function is called with compile-time constant argument.
1076 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1077 argument, adjust users accordingly. Use build_pure_c_string where
1079 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1080 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1081 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1083 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1085 Avoid calls to strlen in miscellaneous functions.
1086 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1087 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1088 * lread.c (openp): Likewise.
1090 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1092 Avoid calls to strlen in path processing functions.
1093 * fileio.c (file_name_as_directory): Add comment. Change to add
1094 srclen argument and return the length of result. Adjust users
1096 (directory_file_name): Fix comment. Change to add srclen argument,
1097 swap 1st and 2nd arguments to obey the common convention. Adjust
1099 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1101 2012-07-10 Glenn Morris <rgm@gnu.org>
1103 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1104 Move PENDING_OUTPUT_COUNT definition to configure.
1106 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1107 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1108 * s/gnu.h (DATA_START): Move definitions to configure.
1110 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1111 We include usg5-4-common.h, which defines them both.
1113 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1114 O_RDONLY already includes it).
1116 Stop ns builds setting the EMACSLOADPATH environment variable.
1117 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1118 Now it does not set EMACSLOADPATH, just returns the load-path string.
1119 * nsterm.h: Update accordingly.
1120 * lread.c [HAVE_NS]: Include nsterm.h.
1121 (init_lread) [HAVE_NS]: Use ns_load_path.
1122 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1124 2012-07-09 Glenn Morris <rgm@gnu.org>
1126 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1127 since the included bsd-common.h does so.
1129 Stop ns builds setting the EMACSPATH environment variable.
1130 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1131 (ns_init_paths): Do not set EMACSPATH.
1132 * nsterm.h (ns_exec_path): Add it.
1133 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1136 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1138 2012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1140 * process.c (wait_reading_process_output): 'waitchannels' was unset
1141 when read_kbd || !NILP (wait_for_cell); fix this.
1143 Add GCC-style 'const' attribute to functions that can use it.
1144 * character.h (char_resolve_modifier_mask):
1145 * keyboard.h (make_ctrl_char):
1146 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1147 (init_character_once, next_almost_prime, init_fns, init_image)
1148 (flush_pending_output, init_sound):
1149 * mem-limits.h (start_of_data):
1150 * menu.h (finish_menu_items):
1151 Add ATTRIBUTE_CONST.
1152 * emacs.c (DEFINE_DUMMY_FUNCTION):
1153 Declare the dummy function with ATTRIBUTE_CONST.
1154 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1155 Add decls with ATTRIBUTE_CONST.
1157 Minor improvements to make_formatted_string.
1158 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1159 where int is good enough, as vsprintf returns an int.
1160 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1162 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1164 Use make_formatted_string to avoid double length calculation.
1165 * lisp.h (make_formatted_string): New prototype.
1166 * alloc.c (make_formatted_string): New function.
1167 * buffer.c (Fgenerate_new_buffer_name): Use it.
1168 * dbus.c (syms_of_dbusbind): Likewise.
1169 * editfns.c (Fcurrent_time_zone): Likewise.
1170 * filelock.c (get_boot_time): Likewise.
1171 * frame.c (make_terminal_frame, set_term_frame_name)
1172 (x_report_frame_params): Likewise.
1173 * image.c (gs_load): Likewise.
1174 * minibuf.c (get_minibuffer): Likewise.
1175 * msdos.c (dos_set_window_size): Likewise.
1176 * process.c (make_process): Likewise.
1177 * xdisp.c (ensure_echo_area_buffers): Likewise.
1178 * xsettings.c (apply_xft_settings): Likewise.
1180 2012-07-09 Glenn Morris <rgm@gnu.org>
1182 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1183 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1184 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1185 * nsterm.h (ns_etc_directory): Add it.
1186 * callproc.c [HAVE_NS]: Include nsterm.h.
1187 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1189 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1191 Move marker debugging code under MARKER_DEBUG.
1192 * marker.c (MARKER_DEBUG): Move marker debugging code under
1193 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1194 for bootstrap with --enable-checking (~3x slowdown reported
1195 by Juanma Barranquero <lekktu@gmail.com>).
1196 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1198 2012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1200 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1201 See <http://bugs.gnu.org/11825#29>.
1203 2012-07-08 Eli Zaretskii <eliz@gnu.org>
1205 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1206 has no font, use the frame's font. (Bug#11813)
1207 (display_line): Add commentary about displaying truncation glyphs
1209 (produce_special_glyphs): Move here from term.c.
1211 * term.c (produce_special_glyphs): Move to xdisp.c.
1213 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1216 2012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1218 * xdisp.c (display_line): Avoid warning about implicit declaration
1221 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1223 * lisp.h: Remove empty conditional.
1225 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1227 * lread.c (load_path_check): Now static.
1229 Fix some minor --with-ns problems found by static checking.
1230 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1231 (x_set_font) [!HAVE_X_WINDOWS]:
1232 * image.c (xpm_load_image) [HAVE_NS]:
1233 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1234 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1235 Remove unused local.
1236 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1237 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1238 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1239 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1240 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1241 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1242 Fix pointer signedness problem.
1243 * xfaces.c (FRAME_X_FONT_TABLE):
1244 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1246 2012-07-07 Glenn Morris <rgm@gnu.org>
1248 * lread.c (load_path_check): New function, split from init_lread.
1249 (init_lread): Reorganize. Motivation:
1250 If EMACSLOADPATH is set, check/warn about that rather than the
1251 defaults, which we are not going to use. Hence we can remove
1252 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1253 Don't warn if site-lisp directories are missing.
1254 If not installed, start from a blank load-path, since
1255 PATH_LOADSEARCH refers to the eventual installation directories.
1257 2012-07-07 Eli Zaretskii <eliz@gnu.org>
1259 Support truncation and continuation glyphs on GUI frames, when
1260 fringes are disabled. (Bug#11832)
1261 * xdisp.c (init_iterator): Get dimensions of truncation and
1262 continuation glyphs even if on GUI frames. Adjust
1263 it->last_visible_x on GUI frames when the left or right fringes,
1264 or both, are absent.
1265 (start_display, move_it_in_display_line_to): Handle the case of a
1266 GUI frame without a fringe to display continuation or truncation
1268 (insert_left_trunc_glyphs): Support GUI frames: make sure
1269 truncation glyphs overwrite enough glyphs from the current line to
1270 have sufficient space in pixels.
1271 (display_line): Support truncation and continuation glyphs on GUI
1272 frames. If some spare pixels are left on the line after inserting
1273 the truncation glyphs, fill that space with a stretch glyph of a
1274 suitably computed width.
1276 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1277 produce_glyphs, to support GUI sessions.
1279 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1281 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1283 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1285 Do not require float-time's arg to fit in time_t (Bug#11825).
1286 This works better on hosts where time_t is unsigned, and where
1287 float-time is applied to the (negative) difference between two times.
1288 * editfns.c (decode_time_components): Last arg is now double *,
1289 not int *, and means to store all the result as a double, without
1290 worrying about whether the seconds part fits in time_t.
1291 All callers changed.
1292 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1293 All callers changed.
1294 (Ffloat_time): Do not fail merely because the specified time falls
1295 outside of time_t range.
1297 2012-07-07 Glenn Morris <rgm@gnu.org>
1299 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1300 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1301 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1303 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
1305 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1306 Update dependencies.
1308 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1310 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1312 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1313 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1314 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1315 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1316 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1317 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1319 * xfont.c (compare_font_names): Redo to omit the need for casts.
1321 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1323 * xfns.c (Fx_change_window_property): Doc fix.
1324 * w32fns.c (Fx_change_window_property): Doc fix.
1326 * w32fns.c (Fx_window_property): Accept the same arguments as the
1327 X Windows version. Doc fix.
1328 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1330 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
1331 Eli Zaretskii <eliz@gnu.org>
1333 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1334 Windows-specific code from nt/config.nt moved here.
1335 Obsolete settings removed.
1337 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1339 * process.c: Avoid unnecessary calls to gettime.
1340 (wait_reading_process_output): Don't get the time of day
1341 when gobbling data immediately and not waiting, as there's no need
1342 for it in that case. This removes a FIXME.
1344 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1346 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1347 is defined (Bug#11768).
1349 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1351 Fix marker debugging code.
1352 * marker.c (byte_char_debug_check): Do not perform the check
1353 if buffer is not multibyte.
1354 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1355 Call byte_char_debug_check with correct arguments.
1357 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1359 Compile marker debugging code only if ENABLE_CHECKING is defined.
1360 * marker.c (byte_char_debug_check, count_markers):
1361 Use only if ENABLE_CHECKING is defined.
1362 (byte_debug_flag): Remove.
1363 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1364 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1366 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1368 Avoid code repetition in marker-related functions.
1369 * marker.c (attach_marker): New function.
1370 (Fset_marker, set_marker_restricted, set_marker_both)
1371 (set_marker_restricted_both): Use it.
1372 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1373 Consistently rename charno to charpos.
1374 (marker_position): Add eassert.
1375 (marker_byte_position): Convert to eassert.
1377 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1379 Simplify list operations in unchain_overlay and unchain_marker.
1380 * buffer.c (unchain_overlay): Simplify. Add comment.
1381 * marker.c (unchain_marker): Simplify. Fix comments.
1383 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1385 Introduce fast path for the widely used marker operation.
1386 * alloc.c (build_marker): New function.
1387 * lisp.h (build_marker): New prototype.
1388 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1389 * composite.c (autocmp_chars): Likewise.
1390 * editfns.c (buildmark): Remove.
1391 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1392 (save_restriction_save): Use build_marker.
1393 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1394 * window.c (save_window_save): Likewise.
1396 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1398 Do not use Fdelete_overlay in delete_all_overlays
1399 to avoid redundant calls to unchain_overlay.
1400 * buffer.c (drop_overlay): New function.
1401 (delete_all_overlays, Fdelete_overlay): Use it.
1402 * minibuf.c (get_minibuffer): Fix comment.
1404 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1406 Port to OpenBSD 5.1 amd64.
1407 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1408 This is needed for OpenBSD, and should be harmless on all BSD systems.
1409 Also, include <sys/sysctl.h>, as it should be available on all
1410 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1411 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1412 use p_pid member, not kp_proc.pid.
1414 2012-07-06 Glenn Morris <rgm@gnu.org>
1416 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1418 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1420 More xmalloc and related cleanup.
1421 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1422 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1423 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1424 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1425 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1426 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1427 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1428 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1429 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1431 Omit needless casts involving void * pointers and allocation.
1432 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1433 as the former is more robust if P's type is changed.
1434 Prefer xzalloc to xmalloc + memset 0.
1435 Simplify malloc-or-realloc to realloc.
1436 Don't worry about xmalloc returning a null pointer.
1437 Prefer xstrdup to xmalloc + strcpy.
1438 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1440 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1441 alloca of a constant.
1443 2012-07-05 Eli Zaretskii <eliz@gnu.org>
1445 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1446 hscroll is larger than the line width. Fixes long and futile
1447 looping inside extend_face_to_end_of_line (on a TTY) producing
1448 glyphs that are not needed and thrown away.
1450 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1452 * marker.c (set_marker_restricted_both): Simplify by using
1455 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1457 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1459 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1461 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1462 not defined (Bug#11768).
1463 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1464 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1465 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1466 followed by gtk_box_set_homogeneous (Bug#11768).
1467 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
1468 (update_theme_scrollbar_width, xg_create_scroll_bar):
1469 Use gtk_scrollbar_new (Bug#11768).
1470 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1471 (is_box_type): New function (Bug#11768).
1472 (xg_tool_item_stale_p): Call is_box_type.
1473 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
1474 with default display (Bug#11768).
1476 2012-07-05 Eli Zaretskii <eliz@gnu.org>
1478 * xdisp.c (window_hscroll_limited): New function.
1479 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1480 coordinates when window's hscroll is set to insanely large
1483 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
1485 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1486 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1488 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1491 * lisp.h (xzalloc): New prototype. Omit needless casts.
1492 * alloc.c (xzalloc): New function. Omit needless casts.
1493 * charset.c: Omit needless casts. Convert all calls to
1494 xmalloc with following memset to xzalloc.
1495 * dispnew.c: Likewise.
1496 * fringe.c: Likewise.
1497 * image.c: Likewise.
1498 * sound.c: Likewise.
1500 * w32fns.c: Likewise.
1501 * w32font.c: Likewise.
1502 * w32term.c: Likewise.
1503 * xfaces.c: Likewise.
1505 * xterm.c: Likewise.
1506 * atimer.c: Omit needless casts.
1507 * buffer.c: Likewise.
1508 * callproc.c: Likewise.
1510 * coding.c: Likewise.
1511 * composite.c: Likewise.
1513 * doprnt.c: Likewise.
1514 * editfns.c: Likewise.
1515 * emacs.c: Likewise.
1517 * filelock.c: Likewise.
1519 * gtkutil.c: Likewise.
1520 * keyboard.c: Likewise.
1522 * lread.c: Likewise.
1523 * minibuf.c: Likewise.
1524 * msdos.c: Likewise.
1525 * print.c: Likewise.
1526 * process.c: Likewise.
1527 * region-cache.c: Likewise.
1528 * search.c: Likewise.
1529 * sysdep.c: Likewise.
1530 * termcap.c: Likewise.
1531 * terminal.c: Likewise.
1532 * tparam.c: Likewise.
1533 * w16select.c: Likewise.
1535 * w32reg.c: Likewise.
1536 * w32select.c: Likewise.
1537 * w32uniscribe.c: Likewise.
1538 * widget.c: Likewise.
1539 * xdisp.c: Likewise.
1540 * xmenu.c: Likewise.
1542 * xselect.c: Likewise.
1544 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1546 * fileio.c (time_error_value): Check the right error number.
1547 Problem reported by Troels Nielsen in
1548 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1550 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1552 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1553 This should be fixed in a better way; see Eli Zaretskii in
1554 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1555 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1557 * fileio.c (time_error_value): Rename from special_mtime.
1558 The old name's problems were noted by Eli Zaretskii in
1559 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1561 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1562 This variable's comment says Emacs needs at least one GDB-visible
1563 symbol of type enum pvec_type, to work around GDB problems.
1564 The symbol's value doesn't matter.
1566 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1567 that causes compilation to fail on pre-C99 compilers.
1569 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
1571 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1572 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1574 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1576 * buffer.c (init_buffer_once): Fix initialization of
1577 headers for buffer_defaults and buffer_local_symbols.
1578 Reported by Juanma Barranquero <lekktu@gmail.com>.
1580 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1582 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1583 * lisp.h (enum pvec_type): Use fewer bits.
1584 (PSEUDOVECTOR_SIZE_BITS): New constant.
1585 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1586 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1587 change in pvec_type.
1588 (PSEUDOVECTOR_TYPEP): New macro.
1589 (TYPED_PSEUDOVECTORP): Use it.
1590 * fns.c (internal_equal): Adapt code to extract pvectype.
1591 * emacs.c (gdb_pvec_type): Update type.
1592 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1593 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1594 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1595 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1596 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1597 abusing vector->header.next.nbytes.
1598 (live_vector_p): Use PVEC_TYPE.
1599 (mark_object): Adapt code to extract pvectype. Use switch.
1601 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1603 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1604 Tighten new eassert a bit.
1606 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1608 Fix compilation with --enable-gcc-warnings and -O1
1610 * doprnt.c (doprnt): Change type of tem to int, initialize
1611 to avoid compiler warning. Add eassert.
1612 * search.c (simple_search): Initialize match_byte to avoid
1613 compiler warning. Add eassert.
1615 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1617 Avoid weird behavior with large horizontal scrolls.
1618 Without this change, for example, large hscroll values would
1619 mess up Emacs's display on Fedora 15 x86, presumably due to
1620 overflows in int calculations in the display code.
1621 Also, if buffers had long lines, Emacs would freeze.
1622 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1623 (set_window_hscroll): New function, containing the old guts of
1624 Fset_window_hscroll. Return the clipped value.
1625 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1626 This avoids the need to check against PTRDIFF_MAX.
1628 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1630 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1632 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1634 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1636 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1637 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1638 since GCC 4.4.6 issues a bogus warning for them.
1640 Fix bugs in file timestamp newness comparisons.
1641 * fileio.c (Ffile_newer_than_file_p):
1642 * lread.c (Fload): Use full timestamp resolution of files,
1643 not just the 1-second resolution, so that files that are only
1644 slightly newer still count as newer.
1645 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1646 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1648 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1650 * fileio.c: Improve handling of file time marker. (Bug#11852)
1651 (special_mtime): New function.
1652 (Finsert_file_contents, Fverify_visited_file_modtime):
1653 Use it to set special mtime values consistently.
1655 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1657 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1658 marker for non-existing file. (Bug#11852)
1660 2012-07-03 Glenn Morris <rgm@gnu.org>
1662 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1663 and did not make it into globals.h).
1665 2012-07-03 Tom Tromey <tromey@redhat.com>
1667 * window.c (Fset_window_margins, Fset_window_fringes)
1668 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1669 * textprop.c (Fprevious_property_change): No longer static.
1670 * syntax.c (Fsyntax_table_p): No longer static.
1671 * process.c (Fget_process, Fprocess_datagram_address): No longer
1673 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1674 * keyboard.c (Fcommand_execute): No longer static.
1676 * insdel.c (Fcombine_after_change_execute): No longer static.
1677 * image.c (Finit_image_library): No longer static.
1678 * fileio.c (Fmake_symbolic_link): No longer static.
1679 * eval.c (Ffetch_bytecode): No longer static.
1680 * editfns.c (Fuser_full_name): No longer static.
1681 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1683 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1685 * dired.c (Ffile_attributes): No longer static.
1686 * composite.c (Fcomposition_get_gstring): No longer static.
1687 * callproc.c (Fgetenv_internal): No longer static.
1689 * ccl.h: Remove EXFUNs.
1690 * buffer.h: Remove EXFUNs.
1691 * dispextern.h: Remove EXFUNs.
1692 * intervals.h: Remove EXFUNs.
1693 * fontset.h: Remove EXFUN.
1694 * font.h: Remove EXFUNs.
1695 * dosfns.c (system_process_attributes): Remove EXFUN.
1696 * keymap.h: Remove EXFUNs.
1697 * lisp.h: Remove EXFUNs.
1698 * w32term.h: Remove EXFUNs.
1699 * window.h: Remove EXFUNs.
1700 * xsettings.h: Remove EXFUN.
1701 * xterm.h: Remove EXFUN.
1703 2012-07-03 Glenn Morris <rgm@gnu.org>
1705 * lisp.h (Frandom): Make it visible to C.
1706 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1707 buffer for invisible buffers. (Bug#1229)
1709 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1711 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1712 values which aren't power of 2.
1713 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1714 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1717 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1719 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1721 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1723 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1725 * alloc.c (allocate_vector_block): Remove redundant
1726 calls to mallopt if DOUG_LEA_MALLOC is defined.
1727 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1728 avoid calls to mallopt if zero_vector is returned.
1730 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1732 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1733 is enabled, avoid dereferencing NULL current_sblock if
1736 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1738 Cleanup basic buffer management.
1739 * buffer.h (struct buffer): Change layout to use generic vector
1740 marking code. Fix some comments. Change type of 'clip_changed'
1741 to bitfield. Remove unused #ifndef old.
1742 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1743 (GET_OVERLAYS_AT): Fix indentation.
1744 (for_each_per_buffer_object_at): New macro.
1745 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1746 (Fbuffer_local_variables): Use it.
1747 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1748 * alloc.c (allocate_buffer): Adjust to match new layout of
1749 struct buffer. Fix comment.
1750 (mark_overlay): New function.
1751 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1752 Lisp area of struct buffer.
1753 (mark_object): Use it. Adjust marking of misc objects
1754 and related comments.
1756 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1758 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1759 wrapper that is not needed because the wrapped code is a no-op (zero
1760 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1761 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1763 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1765 * alloc.c (mark_buffer): Simplify. Remove prototype.
1766 (mark_object): Add comment. Reorganize marking of vector-like
1767 objects. Use CHECK_LIVE for all vector-like objects except buffers
1768 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1769 redundant calls to mark_vectorlike for bool vectors.
1771 2012-06-30 Glenn Morris <rgm@gnu.org>
1773 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1775 * epaths.in (PATH_SITELOADSEARCH): New.
1776 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1777 This is rather than relying on --enable-locallisppath elements
1778 having "site-lisp" in their names. (Bug#10208#25, 11658)
1780 2012-06-30 Eli Zaretskii <eliz@gnu.org>
1782 * w32proc.c (sys_select): Accept and ignore one more argument.
1784 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1786 * sysselect.h [DOS_NT]: Don't include sys/select.h.
1787 (pselect) [!MS_DOS]: Redirect to sys_select.
1789 * sysdep.c: Don't include dos.h and dosfns.h.
1791 * process.c (sys_select):
1792 * msdos.c (sys_select): Accept one more argument and ignore it.
1794 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1795 adapt data types and code to that.
1798 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1799 which clashes with the gnulib function of the same name.
1801 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1803 * font.c (font_style_to_value, font_style_symbolic)
1804 (font_prop_validate_style): Add type checks for values in
1807 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1809 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1812 2012-06-29 Eli Zaretskii <eliz@gnu.org>
1814 * xdisp.c (try_window_id): Undo last change.
1816 * w32.c (getwd): Adjust commentary about startup_dir.
1817 (init_environment): Always call sys_access, even in non-MSVC
1818 builds. Don't chdir to the directory of the Emacs executable.
1819 This undoes code from 1997 which was justified by the need to
1820 "avoid conflicts when removing and renaming directories". But its
1821 downside was that every relative file name was being interpreted
1822 relative to the directory of the Emacs executable, which can never
1823 be TRT. In particular, it broke sys_access when called with
1824 relative file names.
1825 (sys_access): Map GetLastError to errno.
1827 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1829 * window.h (struct window): Change type of 'fringes_outside_margins'
1830 to bitfield. Fix comment. Adjust users accordingly.
1831 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
1833 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1836 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
1838 * gnutls.c (emacs_gnutls_handshake):
1839 Add QUIT to make the loop interruptible.
1841 2012-06-29 Glenn Morris <rgm@gnu.org>
1843 * charset.c (init_charset): Make lack of etc/charsets fatal.
1845 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1847 * editfns.c (region_limit): Fix type mismatch.
1849 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1851 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1852 undefined. Convert from xassert to eassert.
1853 * nsmenu.m: Convert from xassert to eassert.
1854 * nsterm.m: Likewise.
1856 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1858 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1860 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1862 Avoid integer overflow on scroll-left and scroll-right.
1863 * window.c (HSCROLL_MAX): New macro.
1864 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1865 overflow when requested scroll falls outside ptrdiff_t range.
1867 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1869 * window.h (struct window): Change type of 'hscroll',
1870 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1871 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1872 Adjust users accordingly.
1873 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1874 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1875 from EMACS_INT to ptrdiff_t.
1876 (make_window): Omit redundant initialization.
1878 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
1880 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1882 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1884 * window.h (struct window): Change type of 'use_time' and
1885 'sequence_number' from Lisp_Object to int.
1886 * frame.c (make_frame): Adjust users accordingly.
1887 * print.c (print_object): Likewise.
1888 * window.c (select_window, Fwindow_use_time, make_parent_window)
1889 (make_window): Likewise.
1891 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1893 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1894 enabled with --enable-checking=[all,glyphs] configure option.
1895 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1896 adjust comments accordingly.
1897 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1898 undefined, adjust comments accordingly.
1899 * image.c: Likewise.
1900 * scroll.c: Likewise.
1901 * w32fns.c: Likewise.
1902 * w32term.c: Likewise.
1903 * xdisp.c: Likewise.
1904 * xfaces.c: Likewise.
1906 * xterm.c: Likewise.
1908 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1910 Generalize run-time debugging checks.
1911 * dispextern.h (XASSERTS): Remove.
1912 * fontset.c (xassert): Remove.
1913 Convert from xassert to eassert.
1914 * alloc.c: Convert from xassert to eassert.
1916 * dispnew.c: Likewise.
1918 * fringe.c: Likewise.
1919 * ftfont.c: Likewise.
1920 * gtkutil.c: Likewise.
1921 * image.c: Likewise.
1922 * keyboard.c: Likewise.
1924 * process.c: Likewise.
1925 * scroll.c: Likewise.
1926 * sound.c: Likewise.
1928 * w32console.c: Likewise.
1929 * w32fns.c: Likewise.
1930 * w32term.c: Likewise.
1931 * window.c: Likewise.
1932 * xdisp.c: Likewise.
1933 * xfaces.c: Likewise.
1935 * xselect.c: Likewise.
1936 * xterm.c: Likewise.
1938 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1940 * fns.c (maybe_resize_hash_table): Output message when growing the
1943 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1945 * alloc.c (allocate_string_data): Remove dead code.
1946 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1947 avoid GCC warning about unused macro.
1949 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1951 * alloc.c (allocate_string): Omit intervals initialization.
1952 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1953 as in make_pure_string and make_pure_c_string.
1955 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1957 * alloc.c (allocate_string): Fix last change.
1959 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1961 * alloc.c (allocate_string): Remove two redundant calls
1962 to memset, add explicit initialization where appropriate.
1964 2012-06-27 Glenn Morris <rgm@gnu.org>
1966 * lisp.mk (lisp): Remove paths.elc.
1968 2012-06-27 Chong Yidong <cyd@gnu.org>
1970 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1972 2012-06-26 John Wiegley <johnw@newartisans.com>
1974 * unexmacosx.c (copy_data_segment): Add two section names used
1975 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1977 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1978 when building with Clang.
1980 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1982 * eval.c (Fapply): Allow calling it with a single argument.
1984 2012-06-26 Eli Zaretskii <eliz@gnu.org>
1986 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1987 _stricmp and _strnicmp.
1988 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1990 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1992 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1994 (allocate_process): Likewise for new process.
1995 (allocate_terminal): Change to use offsetof.
1996 (allocate_frame): Likewise.
1997 * frame.c (make_frame): Omit redundant initialization.
1998 * window.c (make_parent_window): Use memset.
1999 (make_window): Omit redundant initialization.
2000 * process.c (make_process): Omit redundant initialization.
2001 * terminal.c (create_terminal): Likewise.
2003 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2005 * term.c (delete_tty): Remove redundant call to memset.
2007 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2009 * alloc.c: Remove build_string.
2010 * lisp.h: Define build_string as static inline. This provides
2011 a better opportunity to optimize away calls to strlen when the
2012 function is called with compile-time constant argument.
2013 * image.c (imagemagick_error): Convert to build_string.
2014 * w32proc.c (sys_spawnve): Likewise.
2015 * xterm.c (x_term_init): Likewise.
2017 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2019 Use sprintf return value instead of invoking strlen on result.
2020 In the old days this wasn't portable, since some sprintf
2021 implementations returned char *. But they died out years ago and
2022 Emacs already assumes sprintf returns int.
2023 Similarly for float_to_string.
2024 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2025 * ccl.c (ccl_driver):
2026 * character.c (string_escape_byte8):
2027 * data.c (Fnumber_to_string):
2028 * doprnt.c (doprnt):
2029 * print.c (print_object):
2030 * xdisp.c (message_dolog):
2031 * xfns.c (syms_of_xfns):
2032 Use sprintf or float_to_string result to avoid need to call strlen.
2033 * data.c (Fnumber_to_string):
2034 Use make_unibyte_string, since the string must be ASCII.
2035 * lisp.h, print.c (float_to_string): Now returns int length.
2036 * term.c (produce_glyphless_glyph):
2037 Use sprintf result rather than recomputing it.
2039 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2040 * Makefile.in (ALL_CFLAGS):
2041 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2042 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2044 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2046 * dispextern.h (xstrcasecmp): Define to library function
2047 strcasecmp if available.
2048 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2050 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2052 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2053 Avoid comma operator.
2054 * menu.c (push_submenu_start, push_submenu_end)
2055 (push_left_right_boundary, push_menu_pane): Likewise.
2056 * msdos.c (dos_rawgetc): Likewise.
2058 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2060 * xfns.c (xic_create_fontsetname): Remove redundant calls
2063 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2065 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2066 sprintf already null-terminates its output.
2068 * xfns.c (x_window): Remove redundant cast.
2070 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2072 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2073 `const char *' to `char *' to avoid compiler warning.
2075 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2077 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2078 instead of truncating it to 63 (admittedly a generous limit).
2080 * process.c: Fix spelling and caps in comments.
2082 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2084 * emacs.c (setpgrp): Remove definition, unused.
2085 * sysdep.c (setpgrp): Remove definition, not used in this file.
2087 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
2089 * makefile.w32-in: Update dependencies.
2091 2012-06-24 Eli Zaretskii <eliz@gnu.org>
2093 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2094 (SYSTIME_H): Add nt/inc/sys/time.h.
2096 * systime.h [WINDOWSNT]: Include sys/time.h.
2098 * s/ms-w32.h (struct timespec): Definition moved from
2099 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2101 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2103 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2104 * buffer.h (buffer_slot_type_mismatch):
2105 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2106 * eval.c (unwind_to_catch):
2107 * image.c (my_png_error, my_error_exit):
2108 * keyboard.c (quit_throw_to_read_char, user_error)
2109 (Fexit_recursive_edit, Fabort_recursive_edit):
2110 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2111 (wrong_type_argument, buffer_overflow, __executable_start)
2112 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2113 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2114 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2116 (child_setup) [!DOS_NT]:
2117 * lread.c (end_of_file_error, invalid_syntax):
2118 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2119 * puresize.h (pure_write_error):
2120 * search.c (matcher_overflow):
2121 * sound.c (sound_perror, alsa_sound_perror):
2122 * sysdep.c, syssignal.h (croak):
2123 * term.c (maybe_fatal, vfatal):
2124 * textprop.c (text_read_only):
2125 * undo.c (user_error):
2126 * unexmacosx.c (unexec_error):
2127 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2128 Use _Noreturn rather than NO_RETURN.
2129 No need for separate decl merely because of _Noreturn.
2130 * sound.c (sound_warning, parse_sound):
2131 Remove unnecessary forward decls.
2133 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2135 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2136 * lisp.h (WAIT_READING_MAX): New macro.
2137 * dispnew.c (Fsleep_for, sit_for):
2138 * keyboard.c (kbd_buffer_get_event):
2139 * process.c (Faccept_process_output):
2140 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2141 This improves on the previous patch, which introduced a bug
2142 when time_t is unsigned and as wide as intmax_t.
2143 See <http://bugs.gnu.org/9000#51>.
2145 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2147 * dispnew.c (sit_for, Fsleep_for):
2148 * keyboard.c (kbd_buffer_get_event):
2149 * process.c (Faccept_process_output): Avoid compiler warnings when
2150 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2152 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
2154 * makefile.w32-in: Update dependencies.
2156 * w32.c (ltime): Add return type and declare static.
2157 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2159 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2161 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2162 Privately reported by Herbert J. Skuhra.
2163 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2165 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2166 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2168 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2170 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2171 last argument of make_unibyte_string.
2173 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2174 language ID in the event parameters.
2176 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2177 event.code, not the obscure "character set ID".
2179 2012-06-23 Chong Yidong <cyd@gnu.org>
2181 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2183 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2185 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2186 * w32.c (fdutimens): New function.
2188 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2190 * s/ms-w32.h (pselect): Redirect to sys_select.
2192 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2194 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2195 in the logic of incrementing and decrementing the value of
2196 use_relocatable_buffers.
2198 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2200 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2201 Privately reported by Herbert J. Skuhra.
2202 [__FreeBSD__]: Remove "*/" typo after "#include".
2203 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2204 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2205 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2206 Don't assume EMACS_TIME and struct timeval are the same type.
2208 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2210 Support higher-resolution time stamps (Bug#9000).
2211 The time stamps are only nanosecond-resolution at the C level,
2212 since that's the best that any real-world system supports now.
2213 But they are picosecond-resolution at the Lisp level, as that's
2214 easy, and leaves room for future OS improvements.
2216 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2219 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2220 Don't get current time unless it's needed.
2222 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2223 now provides it if it's absent.
2224 (start_atimer): Port to higher-res time stamps.
2225 Check for time stamp overflow. Don't get current time more
2226 often than is needed.
2228 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2229 Include systime.h, not time.h.
2230 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2232 * dired.c: Include stat-time.h.
2233 (Ffile-attributes): File times now have higher resolution.
2235 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2236 (struct image): Timestamp now has higher resolution.
2238 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2239 has at least microseconds now. All uses removed.
2240 (update_frame, update_single_window, update_window, update_frame_1)
2241 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2243 * editfns.c (time_overflow): Now extern.
2244 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2245 (float-time, Fformat_time_string, Fcurrent_time_string)
2246 (Fcurrent_time_zone): Accept and generate higher-resolution
2248 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2249 (decode_time_components, lisp_seconds_argument): New functions.
2250 (make_time): Now static.
2251 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2252 Report an error if the time is invalid, rather than having the caller
2255 * fileio.c: Include <stat-time.h>
2256 (Fcopy_file): Copy higher-resolution time stamps.
2257 Prefer to set the time stamp via a file descriptor if that works.
2258 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2259 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2260 (Fvisited_file_modtime, Fset_visited_file_modtime):
2261 Support higher-resolution time stamps.
2263 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2265 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2267 * image.c (prepare_image_for_display, clear_image_cache)
2268 (lookup_image): Port to higer-resolution time stamps.
2270 * keyboard.c (start_polling, bind_polling_period):
2271 Check for time stamp overflow.
2272 (read_char, kbd_buffer_get_event, timer_start_idle)
2273 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2274 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2275 Port to higher-resolution time stamps. Do not assume time_t is signed.
2276 (decode_timer): New function. Timers are now vectors of length 9,
2277 not 8, to accommodate the picosecond component.
2278 (timer_check_2): Use it.
2280 * nsterm.m (select_timeout, timeval_subtract): Remove.
2281 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2282 as they're a bit more accurate and handle overflow better.
2283 (ns_select): Change prototype to be compatible with pselect.
2284 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2285 * nsterm.h (ns_select): Adjust prototype.
2287 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2288 us-resolution time stamps.
2289 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2291 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2293 * lisp.h (time_overflow): New decl.
2294 (wait_reading_process_output): First arg is now intmax_t, not int,
2295 to accommodate larger waits.
2297 * process.h (struct Lisp_Process.read_output_delay):
2298 Now counts nanoseconds, not microseconds.
2299 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2301 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2302 (wait_reading_process_output):
2303 Port to ns-resolution time stamps.
2304 (Faccept_process_output, wait_reading_process_output):
2305 Check for time stamp overflow. Do not assume time_t is signed.
2306 (select_wrapper): Remove; we now use pselect.
2307 (Fprocess_attributes): Now generates ns-resolution time stamps.
2309 * sysdep.c: Include utimens.h. Don't include utime.h
2310 or worry about struct utimbuf; gnulib does that for us now.
2311 (gettimeofday): Remove; gnulib provides a substitute.
2312 (make_timeval): New function.
2313 (set_file_times): Now sets ns-resolution time stamps.
2314 New arg FD; all uses changed.
2315 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2316 (system_process_attributes):
2317 Now returns ns-resolution time stamp. All uses changed.
2318 Check for time stamp overflow.
2320 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2321 provides a substitute now.
2323 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2324 since it guarantees struct timespec.
2325 (EMACS_TIME): Now struct timespec, so that we can support
2326 ns-resolution time stamps.
2327 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2328 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2329 (EMACS_USECS): Remove.
2330 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2331 so multiply the arg by 1000 before storing it.
2332 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2334 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2335 Port to ns-resolution time stamps.
2336 (EMACS_TIME_NEG_P): Remove; replaced by....
2337 (EMACS_TIME_SIGN): New macro.
2338 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2339 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2340 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2341 (make_timeval, make_lisp_time, decode_time_components): New decls.
2342 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2343 that it mishandled time_t overflow. You can't compare by subtracting!
2344 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2345 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2347 * term.c: Include <sys/time.h>.
2348 (timeval_to_Time): New function, for proper overflow wraparound.
2349 (term_mouse_position, term_mouse_click): Use it.
2351 * undo.c (record_first_change): Support higher-resolution time stamps
2353 (Fprimitive_undo): Use them when restoring time stamps.
2355 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2356 (w32_get_internal_run_time):
2357 Port to higher-resolution Emacs time stamps.
2358 (ltime): Now accepts single 64-bit integer, as that's more convenient
2361 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2363 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2364 for compatibility with pselect. Support ns-resolution time stamps.
2366 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2368 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2369 Check for time stamp overflow, and support ns-resolution time stamps.
2371 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2372 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2373 (timeval_subtract): Remove; no longer needed.
2374 (XTflash, XTring_bell, x_wait_for_event):
2375 Port to ns-resolution time stamps. Don't assume time_t is signed.
2377 2012-06-22 Chong Yidong <cyd@gnu.org>
2379 * xdisp.c (x_consider_frame_title): Revert last change.
2381 2012-06-22 Eli Zaretskii <eliz@gnu.org>
2383 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2384 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2385 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2386 staticidx goes up to 1597 out of 1600 = 0x640.)
2388 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2390 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2391 Otherwise, the umask might be mistakenly 0 while handling input signals.
2393 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2395 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2397 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2399 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2400 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2401 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2402 access to `contents' member of Lisp_Vector objects with AREF and ASET
2405 2012-06-19 Chong Yidong <cyd@gnu.org>
2407 * frame.c (delete_frame): When selecting a frame on a different
2408 text terminal, do not alter the terminal's top-frame.
2410 * xdisp.c (format_mode_line_unwind_data): Record the target
2411 frame's selected window and its terminal's top-frame.
2412 (unwind_format_mode_line): Restore them.
2413 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2415 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2416 since tty frames can be explicitly named.
2417 (prepare_menu_bars): Likewise.
2419 * term.c (Ftty_top_frame): New function.
2421 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2423 Port byte-code-meter to modern targets.
2424 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2425 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
2426 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
2427 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2428 (METER_1, METER_2): Simplify.
2430 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2432 * data.c (Fdefalias): Return `symbol' (bug#11686).
2434 2012-06-18 Martin Rudalics <rudalics@gmx.at>
2436 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
2437 gets killed during executing of this function (Bug#11665).
2438 Try to always return Qt when the buffer has been actually killed.
2439 (Vkill_buffer_query_functions): In doc-string say that functions
2440 run by this hook should not change the current buffer.
2442 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2444 Fix recently-introduced process.c problems found by static checking.
2445 * process.c (write_queue_push, write_queue_pop, send_process):
2446 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2447 (write_queue_pop): Fix pointer signedness problem.
2448 (send_process): Remove unused local.
2450 2012-06-17 Chong Yidong <cyd@gnu.org>
2452 * xdisp.c (redisplay_internal): No need to redisplay terminal
2453 frames that are not on top.
2455 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
2457 * process.c (make_process): Initialize write_queue.
2458 (write_queue_push, write_queue_pop): New functions.
2459 (send_process): Use them to maintain correct ordering of process
2462 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2464 * lisp.h (eassert): Assume C89 or later.
2465 This removes the need for CHECK.
2466 (CHECK): Remove. Its comments about always evaluating its
2467 argument were confusing, as 'eassert' typically does not evaluate
2470 * coding.c (produce_chars): Use ptrdiff_t, not int.
2472 * xterm.c (x_draw_underwave): Check for integer overflow.
2473 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2475 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
2477 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2478 referenced (Bug#11583).
2480 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2482 Implement wave-style variant of underlining.
2483 * dispextern.h (face_underline_type): New enum.
2484 (face): Add field for underline type.
2485 * nsterm.m (ns_draw_underwave): New function.
2486 (ns_draw_text_decoration): Use it.
2487 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2489 (x_draw_glyph_string): Use them.
2490 * xfaces.c (Qline, Qwave): New Lisp objects.
2491 (check_lface_attrs, merge_face_ref)
2492 (Finternal_set_lisp_face_attribute, realize_x_face):
2493 Handle wave-style underline face attributes.
2494 * xterm.c (x_draw_underwave): New function.
2495 (x_draw_glyph_string): Use it.
2497 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
2499 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2500 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2501 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2502 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2503 ($(BLD)/w32select.$(O)): Update dependencies.
2505 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2507 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2508 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2509 * character.c (_fetch_multibyte_char_p): Remove.
2510 * alloc.c: Include "character.h" before "buffer.h".
2512 * buffer.c: Likewise.
2513 * bytecode.c: Likewise.
2514 * callint.c: Likewise.
2515 * callproc.c: Likewise.
2516 * casefiddle.c: Likewise.
2517 * casetab.c: Likewise.
2518 * category.c: Likewise.
2520 * coding.c: Likewise.
2521 * composite.c: Likewise.
2522 * dired.c: Likewise.
2523 * dispnew.c: Likewise.
2525 * dosfns.c: Likewise.
2526 * editfns.c: Likewise.
2527 * emacs.c: Likewise.
2528 * fileio.c: Likewise.
2529 * filelock.c: Likewise.
2531 * fontset.c: Likewise.
2532 * fringe.c: Likewise.
2533 * indent.c: Likewise.
2534 * insdel.c: Likewise.
2535 * intervals.c: Likewise.
2536 * keyboard.c: Likewise.
2537 * keymap.c: Likewise.
2538 * lread.c: Likewise.
2539 * macros.c: Likewise.
2540 * marker.c: Likewise.
2541 * minibuf.c: Likewise.
2542 * nsfns.m: Likewise.
2543 * nsmenu.m: Likewise.
2544 * print.c: Likewise.
2545 * process.c: Likewise.
2546 * regex.c: Likewise.
2547 * region-cache.c: Likewise.
2548 * search.c: Likewise.
2549 * syntax.c: Likewise.
2551 * textprop.c: Likewise.
2553 * unexsol.c: Likewise.
2554 * w16select.c: Likewise.
2555 * w32fns.c: Likewise.
2556 * w32menu.c: Likewise.
2557 * window.c: Likewise.
2558 * xdisp.c: Likewise.
2560 * xmenu.c: Likewise.
2562 * xselect.c: Likewise.
2564 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2566 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2567 If all the glyphs of the glyph row came from strings, and we have no
2568 cursor positioning clues, put the cursor on the first glyph of the
2570 (handle_face_prop): Use chunk-relative overlay string index when
2571 indexing into it->string_overlays array. (Bug#11653)
2572 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2573 the rightmost. (Bug#11720)
2575 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2577 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2578 (CATEGORY_MEMBER): Enforce 1/0 value.
2579 * category.c (_temp_category_set): Remove.
2581 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2583 * window.c (Fdelete_other_windows_internal)
2584 (Fdelete_window_internal): Don't access frame's mouse highlight
2585 info of the initial frame. (Bug#11677)
2587 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2589 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2590 Assume USE_2_TAGS_FOR_INTS.
2591 (xreload): Adjust $tagmask width to match recent lisp.h change.
2593 Simplify lisp.h in minor ways that should not affect code.
2594 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2595 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2596 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2597 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2598 (INTTYPEBITS): New macro, for clarity.
2599 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
2600 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2601 Simplify now that USE_LSB_TAG is always defined.
2602 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2603 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2605 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
2607 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2609 2012-06-13 Glenn Morris <rgm@gnu.org>
2611 * s/bsd-common.h (BSD4_3):
2612 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2614 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2616 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2619 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2621 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
2622 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
2623 * alloc.c (widen_to_Lisp_Object): Remove.
2624 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2625 * frame.c (delete_frame): Remove outdated comment.
2626 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2627 USE_LISP_UNION_TYPE.
2628 (Fw32_unregister_hot_key): Likewise.
2629 (Fw32_toggle_lock_key): Likewise.
2630 * w32menu.c (add_menu_item): Likewise.
2631 (w32_menu_display_help): Use XIL instead of checking
2632 USE_LISP_UNION_TYPE.
2633 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2634 (init_heap): Likewise.
2635 * w32term.c (w32_read_socket): Update comment.
2637 2012-06-13 Glenn Morris <rgm@gnu.org>
2639 * s/usg5-4-common.h, src/s/unixware.h:
2640 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2642 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2644 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2646 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2647 * alloc.c (make_number) [!defined make_number]:
2648 Remove, as lisp.h always defines this now.
2649 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2650 (roundup_size): Verify that it is a power of 2.
2651 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2652 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2653 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2654 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2655 USE_LSB_TAG now is always defined to be either 0 or 1.
2657 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2658 code works fine either way, and efficiency is not a concern here,
2659 as the union type is for debugging, not for production.
2660 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2661 Use an inline function on all platforms when using the union type,
2662 since this is simpler and 'static inline' can be used portably
2664 (LISP_INITIALLY_ZERO): New macro.
2665 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2666 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2668 2012-06-12 Glenn Morris <rgm@gnu.org>
2670 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2672 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
2674 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2675 Move BROKEN_SIGIO to configure.
2677 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2678 Move NO_TERMIO to configure.
2680 2012-06-12 Chong Yidong <cyd@gnu.org>
2682 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2683 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2684 MagickExportImagePixels is undefined.
2686 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2688 * image.c (imagemagick_load_image): Remove unused label.
2690 2012-06-11 Glenn Morris <rgm@gnu.org>
2692 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2693 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2694 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2695 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2697 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2699 * alloc.c (make_byte_code): New function.
2700 (Fmake_byte_code): Use it. Don't purify here.
2701 * lread.c (read1): Use it as well to avoid extra allocation.
2703 2012-06-11 Chong Yidong <cyd@gnu.org>
2705 * image.c (imagemagick_load_image): Implement transparency.
2707 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2709 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2710 account for preceding backslashes. (Bug#11663)
2712 2012-06-09 Chong Yidong <cyd@gnu.org>
2714 * term.c: Support italics in capable terminals (Bug#9652).
2715 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2716 (turn_on_face): Output using TS_enter_italic_mode if available.
2717 Don't handle unused blinking and alt-charset cases.
2718 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2719 and tty_alt_charset_p cases.
2720 (tty_capable_p, init_tty): Support italics.
2722 * termchar.h (struct tty_display_info): Add field for italics.
2723 Remove unused blink field.
2725 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2728 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2729 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2730 tty_alt_charset_p. Add tty_italic_p.
2732 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
2734 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2735 dbus_type_is_basic if available.
2736 (xd_extract_signed, xd_extract_unsigned): Rename from
2737 extract_signed and extract_unsigned, respectively. Adapt callers.
2739 2012-06-09 Chong Yidong <cyd@gnu.org>
2741 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2743 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2746 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2748 * xdisp.c (vmessage): Treat frame message as multibyte.
2749 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2750 would generate the diagnostic "Making \302\247 buffer-local while
2753 2012-06-08 Eli Zaretskii <eliz@gnu.org>
2755 * dispnew.c (showing_window_margins_p): Undo last change, which
2756 was done due to an inadvertent commit.
2757 (adjust_frame_glyphs_for_frame_redisplay): Do call
2758 showing_window_margins_p.
2760 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2762 * eval.c (Fmake_var_non_special): New primitive.
2763 (syms_of_eval): Defsubr it.
2764 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2766 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
2768 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2769 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2771 2012-06-08 Eli Zaretskii <eliz@gnu.org>
2773 * alloc.c (allocate_vectorlike): Fix last change.
2775 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2777 Block-based vector allocation of small vectors.
2778 * lisp.h (struct vectorlike_header): New field `nbytes',
2779 adjust comment accordingly.
2780 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2781 to denote vector blocks. Adjust users (live_vector_p,
2782 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2783 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2784 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2785 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2786 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2787 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2788 (roundup_size): New constant.
2789 (struct vector_block): New data type.
2790 (vector_blocks, vector_free_lists, zero_vector): New variables.
2791 (all_vectors): Rename to `large_vectors'.
2792 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2793 (sweep_vectors): New functions.
2794 (allocate_vectorlike): Return `zero_vector' as the only vector of
2795 0 items. Allocate new vector from block if vector size is less than
2796 or equal to VBLOCK_BYTES_MAX.
2797 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2798 (init_alloc_once): Add call to init_vectors.
2800 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2802 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2804 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2806 * doprnt.c (doprnt): Truncate multibyte char correctly.
2807 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2808 would mishandle a string argument "Xc" if X was a multibyte
2809 character of length 2: it would truncate after X's first byte
2810 rather than including all of X.
2812 2012-06-06 Chong Yidong <cyd@gnu.org>
2814 * buffer.c (word_wrap): Doc fix.
2816 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2818 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2820 2012-06-03 Glenn Morris <rgm@gnu.org>
2822 * xdisp.c (tool-bar-style): Doc fix.
2824 2012-06-03 Ulrich Müller <ulm@gentoo.org>
2826 * Makefile.in (PAXCTL): Define.
2827 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2828 binary via PaX flags if the paxctl utility is available.
2829 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2830 Restore PaX flags to their default. (Bug#11398)
2832 2012-06-03 Chong Yidong <cyd@gnu.org>
2834 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2837 2012-06-03 Chong Yidong <cyd@gnu.org>
2839 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2840 (note_mode_line_or_margin_highlight): If there is no help echo,
2841 use mode-line-default-help-echo. Handle the case where the mouse
2842 position is past the end of the mode line string.
2844 * buffer.c (buffer_local_value_1): New function, split from
2845 Fbuffer_local_value; can return Qunbound.
2846 (Fbuffer_local_value): Use it.
2847 (Vmode_line_format): Docstring tweaks.
2849 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2851 * sysdep.c (system_process_attributes): Improve comment.
2853 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2855 * keyboard.c: Export real-this-command to Elisp.
2856 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2857 and DEFVAR it. Update all users.
2859 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2861 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2863 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2864 Convert pctcpu and pctmem to Lisp float properly.
2865 Let the compiler fold better, as 100.0/0x8000 is exact.
2867 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2869 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2872 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2874 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2876 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2878 For a 'struct window', replace some Lisp_Object fields to
2879 bitfields where appropriate, remove unused fields.
2880 * window.h (struct window): Remove unused 'last_mark_x' and
2881 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2882 change it's type from Lisp_Object to bitfield.
2883 Change type of 'force_start', 'optional_new_start',
2884 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2885 fields from Lisp_Object to bitfield. Adjust users accordingly.
2887 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2889 Pacify gcc -Wdouble-precision when using Xaw.
2890 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2891 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2892 Use 'float' consistently, rather than 'float' in most places
2893 and 'double' in a couple of places.
2895 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2897 * xdisp.c (handle_stop): Detect whether we have overlay strings
2898 loaded by testing it->current.overlay_string_index to be
2899 non-negative, instead of checking whether n_overlay_strings is
2900 positive. (Bug#11587)
2902 2012-05-31 Chong Yidong <cyd@gnu.org>
2904 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2906 * doc.c (Fsubstitute_command_keys): Doc fix.
2908 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2910 * search.c (search_buffer): Remove calls to
2911 r_alloc_inhibit_buffer_relocation, as it is now called by
2912 maybe_unify_char, which was the cause of relocation of buffer text
2915 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2917 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2918 for the duration of call to load_charset, to avoid problems with
2919 callers of maybe_unify_char that access buffer text through C
2922 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2923 decrement the inhibition flag, instead of just setting or
2926 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2928 Remove obsolete '#define static' cruft.
2929 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2930 This #undef was "temporary" in 2000; it is no longer needed
2931 now that '#define static' has gone away.
2932 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2933 (gray_bitmap_bits): Remove; no longer needed.
2934 All uses replaced with definiens.
2935 * xterm.c: Include "bitmaps/gray.xbm".
2937 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2939 Clean up __executable_start, monstartup when --enable-profiling.
2940 The following changes affect the code only when profiling.
2941 * dispnew.c (__executable_start): Rename from safe_bcopy.
2942 Define only on platforms that need it.
2943 * emacs.c: Include <sys/gmon.h> when profiling.
2944 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2945 (__executable_start): Remove decl, since lisp.h does it now.
2946 (safe_bcopy): Remove decl; no longer has that name.
2947 (main): Coalesce #if into single bit of code, for simplicity.
2948 Cast pointers to uintptr_t, since standard libraries want integers
2950 * lisp.h (__executable_start): New decl.
2952 2012-05-31 Glenn Morris <rgm@gnu.org>
2954 * image.c (Fimagemagick_types): Doc fix.
2956 2012-05-30 Jim Meyering <meyering@redhat.com>
2958 * callproc.c (Fcall_process_region): Include directory component
2959 in mkstemp error message (Bug#11586).
2961 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2963 * alloc.c, lisp.h (make_pure_vector): Now static.
2965 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2967 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2968 Move to byte-run.el.
2969 (Fautoload): Do the hash-doc more carefully.
2970 * data.c (Fdefalias): Purify definition, except for keymaps.
2971 (Qdefun): Move from eval.c.
2972 * lisp.h (Qdefun): Remove.
2973 * lread.c (read1): Tiny simplification.
2975 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
2977 Do not create empty overlays with the evaporate property (Bug#9642).
2978 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2979 Bug#9642, but explicitly check that the buffer the overlay would
2980 be moved to is live and rearrange lines to make sure that errors
2981 will not put the overlay in an inconsistent state.
2982 (Fdelete_overlay): Cosmetics.
2984 2012-05-28 Eli Zaretskii <eliz@gnu.org>
2986 * w32term.c (my_bring_window_to_top): New function.
2987 (x_raise_frame): Use handle returned by DeferWindowPos, which
2988 could be different from the original one.
2989 Call my_bring_window_to_top instead of my_set_foreground_window.
2992 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2993 by calling BringWindowToTop.
2995 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2996 (WM_EMACS_END): Increase by one.
2998 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3000 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3001 This avoids undefined behavior that might cause the eassert
3002 to not catch an out-of-range value.
3004 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
3006 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3007 Update dependencies.
3009 2012-05-27 Eli Zaretskii <eliz@gnu.org>
3011 * bidi.c (bidi_mirror_char): Fix last change.
3013 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3015 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3016 when referring to sectname field in printf format.
3018 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3020 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3021 Only r_alloc_inhibit_buffer_relocation needed to be added;
3022 the others were already declared.
3024 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3025 before checking whether it's out of range. Put the check inside
3027 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3029 2012-05-27 Ken Brown <kbrown@cornell.edu>
3031 * callproc.c (Fcall_process): Restore a line that was accidentally
3032 commented out in the 2011-02-13 change (bug#11547).
3034 2012-05-27 Eli Zaretskii <eliz@gnu.org>
3036 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3037 defined on ralloc.c.
3039 * buffer.c [REL_ALLOC]: Remove prototypes of
3040 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3041 they are now on lisp.h.
3043 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3045 * search.c (search_buffer): Use it to inhibit relocation of buffer
3046 text while re_search_2 is doing its job, because re_search_2 is
3047 passed C pointers to buffer text. (Bug#11519)
3049 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3052 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3053 state after an additional call to move_it_in_display_line_to, keep
3054 the values of it->max_ascent and it->max_descent found for the
3056 (pos_visible_p): Revert the comparison against bottom_y to what it
3057 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3060 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3062 Fix coding-related core dumps with gcc -ftrapv.
3063 The code was computing A - B, where A and B are pointers, and B is
3064 random garbage. This can lead to core dumps on platforms that
3065 have special pointer registers, and it also leads to core dumps on
3066 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3067 A - B only when B is initialized properly.
3068 * coding.c (coding_set_source, coding_set_destination): Return void.
3069 (coding_change_source, coding_change_destinations): New functions,
3070 with the old behaviors of coding_set_source and coding_set_destination.
3071 All callers that need an offset changed to use these new functions.
3073 2012-05-26 Glenn Morris <rgm@gnu.org>
3075 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3077 2012-05-26 Eli Zaretskii <eliz@gnu.org>
3079 Extend mouse support on W32 text-mode console.
3080 * xdisp.c (draw_row_with_mouse_face):
3081 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
3083 * w32console.c: Include window.h.
3084 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3086 (initialize_w32_display): Initialize mouse-highlight data.
3088 * w32inevt.c: Include termchar.h and window.h.
3089 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3090 moves, call note_mouse_highlight. If help_echo changed, call
3091 gen_help_event to produce help-echo message in the echo area.
3092 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3095 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3097 * lread.c (read1): Simplify slightly to avoid an overflow warning
3098 with GCC 4.7.0 on x86-64.
3100 2012-05-26 Eli Zaretskii <eliz@gnu.org>
3102 * bidi.c (bidi_mirror_char): Revert last change: an int is
3103 definitely wide enough here.
3105 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3107 Fix integer width and related bugs (Bug#9874).
3108 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
3109 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3110 (string_bytes, check_sblock, allocate_string_data):
3111 (compact_small_strings, Fmake_bool_vector, make_string)
3112 (make_unibyte_string, make_multibyte_string)
3113 (make_string_from_bytes, make_specified_string)
3114 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3115 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3117 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3118 (allocate_pseudovector):
3119 Use int, not EMACS_INT, where int is wide enough.
3120 (inhibit_garbage_collection, Fgarbage_collect):
3121 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3122 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3123 int might not be wide enough.
3124 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3125 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3126 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3127 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3128 (bidi_level_of_next_char, bidi_move_to_visually_next):
3129 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3130 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3131 (Fkill_buffer, Fset_buffer_major_mode)
3132 (advance_to_char_boundary, Fbuffer_swap_text)
3133 (Fset_buffer_multibyte, overlays_at, overlays_in)
3134 (overlay_touches_p, struct sortvec, record_overlay_string)
3135 (overlay_strings, recenter_overlay_lists)
3136 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3137 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3138 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3139 (Foverlay_recenter, last_overlay_modification_hooks_used)
3140 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3141 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3142 (validate_region): Omit unnecessary test for b <= e,
3143 since that's guaranteed by the previous test.
3144 (adjust_overlays_for_delete): Avoid pos + length overflow.
3145 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3146 (report_overlay_modification):
3147 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3148 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3149 Omit pointer cast, which isn't needed anyway, and doesn't work
3150 after the EMACS_INT -> ptrdiff_t change.
3151 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
3152 * buffer.h: Adjust decls to match defn changes elsewhere.
3153 (struct buffer_text, struct buffer):
3154 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3155 Use EMACS_INT, not int, where int might not be wide enough.
3156 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3157 not int, to avoid needless 32-bit limit on 64-bit hosts.
3158 (exec_byte_code): Use tighter memory-full test, one that checks
3159 for alloca overflow. Don't compute the address of the object just
3160 before an array, as that's not portable. Use EMACS_INT, not
3161 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
3162 * callint.c (Fcall_interactively):
3163 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3164 * callproc.c (call_process_kill, Fcall_process):
3165 Don't assume pid_t fits into an Emacs fixnum.
3166 (call_process_cleanup, Fcall_process, child_setup):
3167 Don't assume pid_t fits into int.
3168 (call_process_cleanup, Fcall_process, delete_temp_file)
3169 (Fcall_process_region):
3170 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3171 (Fcall_process): Simplify handling of volatile integers.
3172 Use int, not EMACS_INT, where int will do.
3173 * casefiddle.c (casify_object, casify_region, operate_on_word)
3174 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3175 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3176 (casify_object): Avoid integer overflow when overallocating buffer.
3177 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
3178 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
3179 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3180 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3181 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3182 integers are now checked earlier. All uses replaced with XINT.
3184 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3185 For CCL_MapSingle, check that content and value are in int range.
3186 (ccl_driver, Fregister_code_conversion_map):
3187 Check that Vcode_version_map_vector is a vector.
3188 (resolve_symbol_ccl_program): Check that vector header is in range.
3189 Always copy the vector, so that we can check its contents reliably
3190 now rather than having to recheck each instruction as it's being
3191 executed. Check that vector words fit in 'int'.
3192 (ccl_get_compiled_code, Fregister_ccl_program)
3193 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3194 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3195 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3196 contents are in range.
3197 (Fccl_execute_on_string): Check that status is in range.
3198 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3199 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3200 Accept and return EMACS_INT, not int, because callers can pass values
3202 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3203 (multibyte_chars_in_text, parse_str_as_multibyte)
3204 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3205 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3206 (string_escape_byte8, Fget_byte):
3207 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3208 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
3209 avoid mishandling large integers.
3210 * character.h: Adjust decls to match defn changes elsewhere.
3211 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3212 (Ffind_charset_region):
3213 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3214 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3215 (load_charset_map_from_vector, Fdefine_charset_internal):
3216 Don't assume fixnum fits in int.
3217 (load_charset_map_from_vector, Fmap_charset_chars):
3218 Remove now-unnecessary CHECK_NATNUMs.
3219 (Fdefine_charset_internal): Check ranges here, more carefully.
3220 Don't rely on undefined behavior with signed left shift overflow.
3221 Don't assume unsigned int fits into fixnum, or that fixnum fits
3222 into unsigned int. Don't require max_code to be a valid fixnum;
3223 that's not true for gb10830 4-byte on a 32-bit host. Allow
3224 invalid_code to be a cons, for the same reason. Require code_offset
3225 to be a character. Avoid int overflow if max_char is close
3227 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3228 this is intended anyway and avoids some undefined behavior.
3229 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3230 INDEX_TO_CODE_POINT, as that's what it expects.
3231 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
3232 * charset.h (DECODE_CHAR): Return int, not unsigned;
3233 this is what was intended anyway, and it avoids undefined behavior.
3234 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3235 integer-overflow issues.
3236 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3237 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3238 where the argument is EMACS_INT, and this behavior is not intended.
3239 * chartab.c (Fmake_char_table, Fset_char_table_range)
3240 (uniprop_get_decoder, uniprop_get_encoder):
3241 Don't assume fixnum fits in int.
3242 * cmds.c (move_point): New function, that does the gist of
3243 Fforward_char and Fbackward_char, but does so while checking
3244 for integer overflow more accurately.
3245 (Fforward_char, Fbackward_char): Use it.
3246 (Fforward_line, Fend_of_line, internal_self_insert)
3247 (internal_self_insert):
3248 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3249 Fix a FIXME, by checking for integer overflow when calculating
3250 target_clm and actual_clm.
3251 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
3252 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
3253 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3254 (coding_alloc_by_making_gap, alloc_destination)
3255 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3256 (encode_coding_utf_16, detect_coding_emacs_mule)
3257 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3258 (detect_coding_iso_2022, decode_coding_iso_2022)
3259 (encode_invocation_designation, encode_designation_at_bol)
3260 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3261 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3262 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3263 (encode_coding_ccl, encode_coding_raw_text)
3264 (detect_coding_charset, decode_coding_charset)
3265 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3266 (produce_composition, produce_charset, produce_annotation)
3267 (decode_coding, handle_composition_annotation)
3268 (handle_charset_annotation, consume_chars, decode_coding_gap)
3269 (decode_coding_object, encode_coding_object, detect_coding_system)
3270 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3271 (code_convert_region, code_convert_string)
3272 (Fdefine_coding_system_internal)
3273 (coding_set_source, coding_set_destination):
3274 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3275 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3276 (Fdefine_coding_system_internal):
3277 Don't assume fixnums fit in int.
3278 (decode_coding_gap, decode_coding_object, encode_coding_object)
3279 (Fread_coding_system, Fdetect_coding_region)
3280 (Funencodable_char_position, Fcheck_coding_systems_region)
3281 (get_translation, handle_composition_annotation, consume_chars):
3282 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3283 (consume_chars): Rewrite to not calculate an address outside buffer.
3284 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
3285 Don't access memory outside of the args array.
3286 (Fdefine_coding_system_internal): Check for charset-id overflow.
3287 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3288 result of ENCODE_CHAR.
3289 * coding.h: Adjust decls to match defn changes elsewhere.
3290 (struct coding_system):
3291 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3292 * composite.c (get_composition_id, find_composition)
3293 (run_composition_function, update_compositions)
3294 (compose_text, composition_gstring_put_cache)
3295 (composition_gstring_p, composition_gstring_width)
3296 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3297 (composition_compute_stop_pos, composition_reseat_it)
3298 (composition_update_it, struct position_record)
3299 (find_automatic_composition, composition_adjust_point)
3300 (Fcomposition_get_gstring, Ffind_composition_internal):
3301 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3302 (update_compositions):
3303 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3304 * composite.h: Adjust decls to match defn changes elsewhere.
3305 (struct composition):
3306 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3307 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3308 Do not attempt to compute the address of the object just before a
3309 buffer; this is not portable.
3311 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3312 (Faset): Use int, not EMACS_INT, where int is wide enough.
3313 (Fstring_to_number): Don't assume fixnums fit in int.
3314 (Frem): Don't assume arg is nonnegative.
3315 * dbusbind.c (xd_append_arg): Check for integers out of range.
3316 (Fdbus_call_method): Don't overflow the timeout int.
3317 (extract_signed, extract_unsigned): New functions.
3318 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3319 (xd_get_connection_references): Return ptrdiff_t, not int.
3321 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3322 (xd_read_message_1):
3323 Use int, not unsigned, where the dbus API uses int.
3324 (Fdbus_message_internal): Don't overflow mtype.
3325 (syms_of_dbusbind): Allocate right-sized buffer for integers.
3326 * dired.c (directory_files_internal, file_name_completion, scmp)
3327 (file_name_completion_stat):
3328 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3329 (file_name_completion): Don't overflow matchcount.
3330 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3331 * dispextern.h: Adjust decls to match defn changes elsewhere.
3332 (struct text_pos, struct glyph, struct bidi_saved_info)
3333 (struct bidi_string_data, struct bidi_it, struct composition_it)
3335 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3336 (struct display_pos, struct composition_it, struct it):
3337 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3338 * dispnew.c (increment_matrix_positions)
3339 (increment_row_positions, mode_line_string)
3340 (marginal_area_string):
3341 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3342 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
3343 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3344 (duration_to_sec_usec): New function, to check for overflow better.
3345 (Fsleep_for, sit_for): Use it.
3346 * doc.c (get_doc_string, store_function_docstring):
3347 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3348 (get_doc_string, Fsnarf_documentation):
3349 Use int, not EMACS_INT, where int is wide enough.
3351 Use SAFE_ALLOCA, not alloca.
3352 Check for overflow when converting EMACS_INT to off_t.
3353 * doprnt.c (doprnt):
3354 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3355 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3356 Don't assume uid_t fits into fixnum.
3357 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3358 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3359 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3360 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3361 (general_insert_function)
3362 (Finsert_char, make_buffer_string, make_buffer_string_both)
3363 (update_buffer_properties, Fbuffer_substring)
3364 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3365 (Fsubst_char_in_region, check_translation)
3366 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3367 (transpose_markers, Ftranspose_regions):
3368 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3369 (clip_to_bounds): Move to lisp.h as an inline function).
3370 (Fconstrain_to_field): Don't assume integers are nonnegative.
3371 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3372 (Fsubst_char_in_region, Fsave_restriction):
3373 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3374 (Femacs_pid): Don't assume pid_t fits into fixnum.
3375 (lo_time): Use int, not EMACS_INT, when int suffices.
3376 (lisp_time_argument): Check for usec out of range.
3377 (Fencode_time): Don't assume fixnum fits in int.
3378 (Fuser_login_name, Fuser_full_name): Signal an error
3379 if a uid argument is out of range, rather than relying on
3381 (Fformat_time_string): Remove now-unnecessary check.
3382 lisp_time_argument checks for out-of-range usec now.
3383 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
3384 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3385 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3386 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3387 (init_cmdargs, Fdump_emacs):
3388 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3389 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3390 the bottom (typically) 32 bits of the fixnum.
3391 * eval.c (specpdl_size, call_debugger):
3392 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3393 (when_entered_debugger, Fbacktrace_debug):
3394 Don't assume fixnum can fit in int.
3395 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3396 the object just before a buffer; this is not portable.
3397 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3398 (grow_specpdl, unbind_to):
3399 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3400 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3401 (grow_specpdl): Simplify allocation by using xpalloc.
3402 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
3403 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3404 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3405 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3406 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3408 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3409 (Fcopy_file, non_regular_nbytes, read_non_regular)
3410 (Finsert_file_contents):
3411 Use int, not EMACS_INT, where int is wide enough.
3412 (READ_BUF_SIZE): Verify that it fits in int.
3413 (Finsert_file_contents): Check that counts are in proper range,
3414 rather than assuming fixnums fit into ptrdiff_t etc.
3415 Don't assume fixnums fit into int.
3416 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
3417 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3418 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
3419 (string_char_to_byte, string_byte_to_char)
3420 (string_make_multibyte, string_to_multibyte)
3421 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3422 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3423 (substring_both, Fdelete, internal_equal, Ffillarray)
3424 (Fclear_string, mapcar1)
3425 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3426 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3427 (larger_vector, make_hash_table, maybe_resize_hash_table)
3428 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3429 (Fmaphash, secure_hash):
3430 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3431 (concat): Check for string index and length overflow.
3432 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3434 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3435 (larger_vector): New API (vec, incr_min, size_max) replaces old
3436 one (vec, new_size, init). This catches size overflow.
3437 INIT was removed because it was always Qnil.
3438 All callers changed.
3439 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3440 the upper bound on a hash table index size.
3441 (make_hash_table, maybe_resize_hash_table): Use it.
3442 (secure_hash): Computer start_byte and end_byte only after
3443 they're known to be in ptrdiff_t range.
3444 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3445 (Ffont_get_glyphs, Ffont_at):
3446 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3447 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3448 (Flist_fonts, Fopen_font):
3449 Don't assume fixnum can fit in int.
3450 (check_gstring): Don't assume index can fit in int.
3451 (font_match_p): Check that fixnum is a character, not a nonnegative
3452 fixnum, since the later code needs to stuff it into an int.
3453 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3454 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3455 conversion overflow issues.
3456 (Fopen_font): Check for integer out of range.
3457 (Ffont_get_glyphs): Don't assume index can fit in int.
3458 * font.h: Adjust decls to match defn changes elsewhere.
3459 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3461 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3462 printmax_t, where ptrdiff_t is wide enough.
3463 (Finternal_char_font):
3464 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3465 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3466 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3467 (Fset_frame_position, x_set_frame_parameters)
3468 (x_set_line_spacing, x_set_border_width)
3469 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3470 Check that fixnums are in proper range for system types.
3471 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3472 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3473 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3474 Use SAFE_ALLOCA_LISP, not alloca.
3475 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3476 intptr_t is wide enough.
3477 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3478 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3479 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3480 Check for fixnum out of range.
3481 * ftfont.c (ftfont_list): Don't assume index fits in int.
3482 Check that fixnums are in proper range for system types.
3483 (ftfont_shape_by_flt):
3484 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3485 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3486 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3487 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3488 Check that fixnums are in proper range for system types.
3489 * gnutls.h: Adjust decls to match defn changes elsewhere.
3490 * gtkutil.c (xg_dialog_run):
3491 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3492 (update_frame_tool_bar):
3493 Check that fixnums are in proper range for system types.
3494 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
3495 (lookup_image): Check that fixnums are in range for system types.
3496 * indent.c (last_known_column, last_known_column_point):
3497 (current_column_bol_cache):
3498 (skip_invisible, current_column, check_display_width):
3499 (check_display_width, scan_for_column, current_column_1)
3500 (Findent_to, Fcurrent_indentation, position_indentation)
3501 (indented_beyond_p, Fmove_to_column, compute_motion):
3502 (Fcompute_motion, Fvertical_motion):
3503 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3504 (last_known_column_modified): Use EMACS_INT, not int.
3505 (check_display_width):
3507 Check that fixnums and floats are in proper range for system types.
3508 (compute_motion): Don't assume index or fixnum fits in int.
3509 (compute_motion, Fcompute_motion):
3510 Use int, not EMACS_INT, when it is wide enough.
3511 (vmotion): Omit local var start_hpos that is always 0; that way
3512 we don't need to worry about overflow in expressions involving it.
3513 * indent.h: Adjust decls to match defn changes elsewhere.
3515 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3516 Use int, not EMACS_INT, where int is wide enough.
3517 Remove unused members ovstring_chars_done and tab_offset;
3519 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3520 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3521 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3522 (make_gap, copy_text, insert, insert_and_inherit)
3523 (insert_before_markers, insert_before_markers_and_inherit)
3524 (insert_1, count_combining_before, count_combining_after)
3525 (insert_1_both, insert_from_string)
3526 (insert_from_string_before_markers, insert_from_string_1)
3527 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3528 (adjust_after_replace, adjust_after_insert, replace_range)
3529 (replace_range_2, del_range, del_range_1, del_range_byte)
3530 (del_range_both, del_range_2, modify_region)
3531 (prepare_to_modify_buffer, signal_before_change)
3532 (signal_after_change, Fcombine_after_change_execute):
3533 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3534 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3535 (balance_an_interval, split_interval_right, split_interval_left)
3536 (find_interval, next_interval, update_interval)
3537 (adjust_intervals_for_insertion, delete_node, delete_interval)
3538 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3539 (static_offset_intervals, offset_intervals)
3540 (merge_interval_right, merge_interval_left, make_new_interval)
3541 (graft_intervals_into_buffer, temp_set_point_both)
3542 (temp_set_point, set_point, adjust_for_invis_intang)
3543 (set_point_both, move_if_not_intangible, get_property_and_range)
3544 (get_local_map, copy_intervals, copy_intervals_to_string)
3545 (compare_string_intervals, set_intervals_multibyte_1):
3546 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3547 * intervals.h: Adjust decls to match defn changes elsewhere.
3549 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3550 * keyboard.c (this_command_key_count, this_single_command_key_start)
3551 (before_command_key_count, before_command_echo_length, echo_now)
3552 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3553 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3554 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3555 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3556 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3557 (last_non_minibuf_size, last_point_position, echo_truncate)
3558 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3559 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3560 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3561 (stuff_buffered_input):
3562 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3563 (last_auto_save, command_loop_1, read_char):
3564 Use EMACS_INT, not int, to avoid integer overflow.
3565 (record_char): Avoid overflow in total_keys computation.
3566 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3567 * keyboard.h: Adjust decls to match defn changes elsewhere.
3568 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3569 (Fkey_description, Fdescribe_vector, Flookup_key):
3570 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3571 (click_position): New function, to check that positions are in range.
3572 (Fcurrent_active_maps):
3574 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3575 (Faccessible_keymaps, Fkey_description):
3576 (preferred_sequence_p):
3577 Don't assume fixnum can fit into int.
3578 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3579 Check for integer overflow in size calculations.
3580 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3581 avoid mishandling large integers.
3582 * lisp.h: Adjust decls to match defn changes elsewhere.
3583 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3584 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3585 (struct Lisp_Marker):
3586 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3587 (clip_to_bounds): Now an inline function, moved here from editfns.c.
3588 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3589 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3590 All callers changed.
3591 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3592 Assume the arg has valid form, since it always does.
3593 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3594 unsigned integer system type.
3595 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3596 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3597 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3598 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3599 (duration_to_sec_usec): New decl.
3600 * lread.c (read_from_string_index, read_from_string_index_byte)
3601 (read_from_string_limit, readchar, unreadchar, openp)
3602 (read_internal_start, read1, oblookup):
3603 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3604 (Fload, readevalloop, Feval_buffer, Feval_region):
3605 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3606 (openp): Check for out-of-range argument to 'access'.
3607 (read1): Use int, not EMACS_INT, where int is wide enough.
3608 Don't assume fixnum fits into int.
3609 Fix off-by-one error that can read outside a buffer.
3610 (read_filtered_event): Use duration_to_sec_usec
3611 to do proper overflow checking on durations.
3612 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3613 in size calculation.
3614 (Fexecute_kbd_macro):
3615 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3616 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3617 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3618 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3619 (set_marker_both, set_marker_restricted_both, marker_position)
3620 (marker_byte_position, Fbuffer_has_markers_at):
3621 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3622 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
3623 * menu.c (ensure_menu_items): Rename from grow_menu_items.
3624 It now merely ensures that the menu is large enough, without
3625 necessarily growing it, as this avoids some integer overflow issues.
3626 All callers changed.
3627 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3628 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3629 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3630 Use SAFE_ALLOCA_LISP, not alloca.
3631 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3632 to EMACS_INT. Check that fixnums are in proper range for system types.
3633 * minibuf.c (minibuf_prompt_width, string_to_object)
3634 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3635 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3636 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3637 (get_minibuffer, read_minibuf_unwind):
3638 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3639 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3640 this simplifies overflow checking. All callers changed.
3641 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3643 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3644 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3645 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3646 Check that fixnums are in proper range for system types.
3647 (Fx_create_frame, Fx_show_tip):
3648 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3649 * nsfont.m (ns_findfonts, nsfont_list_family):
3650 Don't assume fixnum fits in long.
3651 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3652 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3653 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3655 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
3656 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3657 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3658 (PRINTDECLARE, PRINTPREPARE):
3659 (strout, print_string):
3660 (print, print_preprocess, print_check_string_charset_prop)
3662 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3664 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3665 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3666 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
3667 (printchar, strout): Use xpalloc to catch size calculation overflow.
3668 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
3669 (print_error_message): Use SAFE_ALLOCA, not alloca.
3670 (print_object): Use int, not EMACS_INT, where int is wide enough.
3671 (print_depth, new_backquote_output, print_number_index):
3672 Use ptrdiff_t, not int, where int might not be wide enough.
3673 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3674 (Fset_process_window_size, Fformat_network_address)
3675 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
3677 Check that fixnums are in proper range for system types.
3678 (Fsignal_process): Simplify by avoiding a goto.
3679 Check for process-ids out of pid_t range rather than relying on
3681 (process_tick, update_tick): Use EMACS_INT, not int.
3682 (Fformat_network_address, read_process_output, send_process)
3683 (Fprocess_send_region, status_notify):
3684 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3685 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3686 (wait_reading_process_output, read_process_output, exec_sentinel):
3687 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3688 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3689 (Faccept_process_output): Use duration_to_sec_usec to do proper
3690 overflow checking on durations.
3691 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3692 Don't assume pid_t fits in int.
3693 * process.h (struct Lisp_Process): Members tick and update_tick
3694 are now of type EMACS_INT, not int.
3695 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3696 configured --with-wide-int.
3697 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3698 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3699 * search.c (looking_at_1, string_match_1):
3700 (fast_string_match, fast_c_string_match_ignore_case)
3701 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3702 (scan_newline, find_before_next_newline, search_command)
3703 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3704 (set_search_regs, wordify):
3707 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3708 (string_match_1, search_buffer, set_search_regs):
3710 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3711 (wordify): Check for overflow in size calculation.
3712 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3713 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3714 Check that fixnums are in proper range for system types.
3715 * sound.c (struct sound_device)
3716 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3717 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3718 (Fplay_sound_internal):
3719 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3720 * syntax.c (struct lisp_parse_state, find_start_modiff)
3721 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3722 (Fparse_partial_sexp):
3723 Don't assume fixnums can fit in int.
3724 (struct lisp_parse_state, find_start_pos, find_start_value)
3725 (find_start_value_byte, find_start_begv)
3726 (update_syntax_table, char_quoted, dec_bytepos)
3727 (find_defun_start, prev_char_comend_first, back_comment):
3728 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3729 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3730 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3731 (Finternal_describe_syntax_value): Check that match_lisp is a
3732 character, not an integer, since the code stuffs it into int.
3733 (scan_words, scan_sexps_forward):
3734 Check that fixnums are in proper range for system types.
3736 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3737 (scan_sexps_forward):
3738 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3739 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3740 * syntax.h: Adjust decls to match defn changes elsewhere.
3741 (struct gl_state_s):
3742 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3743 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3744 MOST_POSITIVE_FIXNUM.
3745 * sysdep.c (wait_for_termination_1, wait_for_termination)
3746 (interruptible_wait_for_termination, mkdir):
3747 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3748 (emacs_read, emacs_write):
3749 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3750 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3751 and double all fit in int.
3752 * term.c (set_tty_color_mode):
3753 Check that fixnums are in proper range for system types.
3754 * termhooks.h (struct input_event):
3755 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3756 * textprop.c (validate_interval_range, interval_of)
3757 (Fadd_text_properties, set_text_properties_1)
3758 (Fremove_text_properties, Fremove_list_of_text_properties)
3759 (Ftext_property_any, Ftext_property_not_all)
3760 (copy_text_properties, text_property_list, extend_property_ranges)
3761 (verify_interval_modification):
3762 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3763 (Fnext_single_char_property_change)
3764 (Fprevious_single_char_property_change):
3765 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3766 (copy_text_properties):
3767 Check for integer overflow in index calculation.
3768 * undo.c (last_boundary_position, record_point, record_insert)
3769 (record_delete, record_marker_adjustment, record_change)
3770 (record_property_change):
3771 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3772 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3773 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3774 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3775 (Fx_hide_tip, Fx_file_dialog):
3776 * w32menu.c (set_frame_menubar):
3777 Use ptrdiff_t, not int, for consistency with rest of code.
3778 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3779 (select_window, Fdelete_other_windows_internal)
3780 (window_scroll_pixel_based, window_scroll_line_based)
3781 (Frecenter, Fset_window_configuration):
3782 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3783 (Fset_window_hscroll, run_window_configuration_change_hook)
3784 (set_window_buffer, temp_output_buffer_show, scroll_command)
3785 (Fscroll_other_window, Frecenter):
3786 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3787 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3788 Don't assume fixnum fits in int.
3789 (Fset_window_scroll_bars):
3790 Check that fixnums are in proper range for system types.
3791 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3792 (string_pos, c_string_pos, number_of_chars, init_iterator)
3793 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3794 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3795 (compute_display_string_end, handle_face_prop)
3796 (face_before_or_after_it_pos, handle_invisible_prop)
3797 (handle_display_prop, handle_display_spec, handle_single_display_spec)
3798 (display_prop_intangible_p, string_buffer_position_lim)
3799 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3800 (get_overlay_strings_1, get_overlay_strings)
3801 (iterate_out_of_display_property, forward_to_next_line_start)
3802 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3803 (get_next_display_element, set_iterator_to_next)
3804 (get_visually_first_element, compute_stop_pos_backwards)
3805 (handle_stop_backwards, next_element_from_buffer)
3806 (move_it_in_display_line_to, move_it_in_display_line)
3807 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3808 (add_to_log, message_dolog, message_log_check_duplicate)
3809 (message2, message2_nolog, message3, message3_nolog
3810 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3811 (current_message_1, truncate_echo_area, truncate_message_1)
3812 (set_message, set_message_1, store_mode_line_noprop)
3813 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3814 (text_outside_line_unchanged_p, check_point_in_composition)
3815 (reconsider_clip_changes)
3816 (redisplay_internal, set_cursor_from_row, try_scrolling)
3817 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3818 (redisplay_window, find_last_unchanged_at_beg_row)
3819 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3820 (trailing_whitespace_p, find_row_edges, display_line)
3821 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3822 (display_mode_element, store_mode_line_string)
3823 (pint2str, pint2hrstr, decode_mode_spec)
3824 (display_count_lines, display_string, draw_glyphs)
3825 (x_produce_glyphs, x_insert_glyphs)
3826 (rows_from_pos_range, mouse_face_from_buffer_pos)
3827 (fast_find_string_pos, mouse_face_from_string_pos)
3828 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3829 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3830 (safe_call, init_from_display_pos, handle_fontified_prop)
3831 (handle_single_display_spec, load_overlay_strings)
3832 (with_echo_area_buffer, setup_echo_area_for_printing)
3833 (display_echo_area, echo_area_display)
3834 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3835 (update_tool_bar, hscroll_window_tree, redisplay_internal)
3836 (redisplay_window, dump_glyph_row, display_mode_line)
3837 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
3838 (handle_display_spec, display_prop_string_p):
3839 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3840 (handle_single_display_spec, build_desired_tool_bar_string)
3841 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3842 (get_specified_cursor_type):
3843 Check that fixnums are in proper range for system types.
3844 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3845 (Flookup_image_map):
3846 Don't assume fixnums fit in int.
3847 (compare_overlay_entries):
3848 Avoid mishandling comparisons due to subtraction overflow.
3849 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3850 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3851 (handle_tool_bar_click):
3852 Use int, not unsigned, since we prefer signed and the signedness
3853 doesn't matter here.
3854 (get_next_display_element, next_element_from_display_vector):
3855 Use int, not EMACS_INT, when int is wide enough.
3856 (start_hourglass): Use duration_to_sec_usec to do proper
3857 overflow checking on durations.
3858 * xfaces.c (Fbitmap_spec_p):
3859 Check that fixnums are in proper range for system types.
3860 (compare_fonts_by_sort_order):
3861 Avoid mishandling comparisons due to subtraction overflow.
3862 (Fx_family_fonts, realize_basic_faces):
3863 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3865 Don't assume fixnum fits in int.
3866 Use SAFE_ALLOCA_LISP, not alloca.
3867 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3868 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3869 (face_at_buffer_position, face_for_overlay_string)
3870 (face_at_string_position):
3871 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3872 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3873 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3875 Check that fixnums are in proper range for system types.
3876 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3877 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3878 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3879 (Fx_change_window_property): Don't assume fixnums fit in int.
3880 * xfont.c (xfont_chars_supported):
3881 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3882 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3883 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3884 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3885 * xml.c (parse_region):
3886 * xrdb.c (magic_file_p):
3887 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3888 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3889 (x_get_local_selection, x_reply_selection_request)
3890 (x_handle_selection_request, wait_for_property_change):
3891 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3892 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3893 short is wide enough.
3894 (x_send_client_event): Don't assume fixnum fits in int.
3895 * xterm.c (x_x_to_emacs_modifiers):
3896 Don't assume EMACS_INT overflows nicely into int.
3897 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3899 (handle_one_xevent): NATNUMP can eval its arg twice.
3900 (x_connection_closed):
3901 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3902 * xterm.h: Adjust decls to match defn changes elsewhere.
3903 (struct scroll_bar): Use struct vectorlike_header
3904 rather than rolling our own approximation.
3905 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3907 2012-05-25 Glenn Morris <rgm@gnu.org>
3909 * lisp.mk (lisp): Update for more files being compiled now.
3911 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3913 * lread.c: Remove `read_pure' which makes no difference.
3914 (read_pure): Remove var.
3915 (unreadpure): Remove function.
3916 (readevalloop): Don't call read_list with -1 flag.
3917 (read1, read_vector): Don't test read_pure any more.
3918 (read_list): Simplify.
3920 * fileio.c, character.h: Minor style tweaks.
3922 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3924 * window.h (clip_changed): Remove useless declaration.
3926 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
3928 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3929 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3931 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3934 This directory predates autoconf and is no longer needed nowadays.
3935 Move its few remaining bits of functionality to where they're needed.
3936 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3937 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3938 * m/template.h: Remove.
3939 * Makefile.in (M_FILE): Remove. All uses removed.
3940 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3941 * lisp.h (USE_LSB_TAG):
3942 * mem-limits.h (EXCEEDS_LISP_PTR):
3943 Use VAL_MAX, not VALBITS, in #if.
3944 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3945 (EMACS_UINT): Define unconditionally now.
3946 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3947 (BITS_PER_EMACS_INT): New constants, replacing
3948 what used to be in config.h, but not useful in #if.
3949 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3950 define them any more.
3951 (VAL_MAX): New macro.
3953 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3954 BITS_PER_EMACS_INT, in #if.
3955 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3956 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3957 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3958 * s/ms-w32.h (DATA_START):
3959 Move here from removed file m/intel386.h.
3960 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3961 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3963 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3965 Assume C89 or later.
3966 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3967 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3969 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3970 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3971 * textprop.c, tparam.c (NULL): Remove.
3972 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3973 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3974 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3975 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3976 * xterm.c (input_signal_count): Assume volatile works.
3978 2012-05-21 Ken Brown <kbrown@cornell.edu>
3980 * xgselect.c (xg_select): Fix first argument in call to 'select'
3983 2012-05-20 Ken Brown <kbrown@cornell.edu>
3985 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
3986 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
3988 2012-05-19 Ken Brown <kbrown@cornell.edu>
3990 * xfns.c (x_in_use): Remove `static' qualifier.
3991 * xterm.h (x_in_use): Declare.
3992 * xgselect.c: Include xterm.h.
3993 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3994 and `display_arg' (bug#9754).
3996 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3998 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4000 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4001 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4003 2012-05-18 Eli Zaretskii <eliz@gnu.org>
4005 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4007 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
4008 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
4010 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4011 reference to image_cache->refcount.
4012 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4014 2012-05-17 Juri Linkov <juri@jurta.org>
4016 * search.c (Fword_search_regexp, Fword_search_backward)
4017 (Fword_search_forward, Fword_search_backward_lax)
4018 (Fword_search_forward_lax): Move functions to isearch.el
4019 (bug#10145, bug#11381).
4021 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4023 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4025 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4027 * lread.c (init_obarray): Declare Qt and Qnil as special.
4029 2012-05-14 Glenn Morris <rgm@gnu.org>
4031 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
4032 Put "libexec" before "bin", for the sake of init_callproc_1.
4034 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4036 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4038 * unexaix.c: Port to more-recent AIX compilers.
4039 (report_error, report_error_1, make_hdr, copy_sym)
4040 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4041 Make arguments const char *, not char *, to avoid violations of C
4042 standard and to fix some AIX warnings reported by Gilles Pion.
4044 2012-05-14 Eli Zaretskii <eliz@gnu.org>
4046 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4047 already have overlays loaded.
4048 (handle_single_display_spec): Before returning without displaying
4049 fringe bitmap, synchronize the bidi iterator with the main display
4050 iterator, by calling iterate_out_of_display_property.
4051 (iterate_out_of_display_property): Detect buffer iteration by
4052 testing that it->string is a Lisp string.
4053 (get_next_display_element): When the current object is exhausted,
4054 and there's something on it->stack, call set_iterator_to_next to
4055 proceed with what's on the stack, instead of returning zero.
4056 (set_iterator_to_next): If called at the end of a Lisp string,
4057 proceed to consider_string_end without incrementing string
4058 position. Don't increment display vector index past the end of
4059 the display vector. (Bug#11417)
4060 (pos_visible_p): Don't report a position visible when move_it_to
4061 stopped at the last line of window, which happens to be scanned
4062 backwards by the bidi iteration. (Bug#11464)
4064 2012-05-14 Eli Zaretskii <eliz@gnu.org>
4066 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4067 and right-margin display specs even if the spec is invalid or we
4068 are on a TTY, and thus unable to display on the fringes.
4069 That's because the text with the property will not be displayed anyway,
4070 so we need to signal to the caller that this is a "replacing"
4071 display spec. This fixes display when the spec is invalid or we
4074 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4076 * unexaix.c (make_hdr): Fix typo in prototype.
4077 This bug broke the build on AIX. Problem reported by Gilles Pion.
4079 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
4081 * keyboard.c (kbd_buffer_get_event): Read special events also in
4082 batch mode. (Bug#11415)
4084 2012-05-12 Glenn Morris <rgm@gnu.org>
4086 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4088 2012-05-12 Eli Zaretskii <eliz@gnu.org>
4090 * lisp.mk (lisp): Add newcomment.elc.
4092 2012-05-12 Glenn Morris <rgm@gnu.org>
4094 * Makefile.in (MKDIR_P): New, set by configure.
4095 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4097 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4099 Remove unused function hourglass_started.
4100 * dispextern.h (hourglass_started):
4101 * w32fns.c (hourglass_started):
4102 * xdisp.c (hourglass_started): Remove.
4104 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
4106 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4107 Update dependencies.
4109 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4111 * xgselect.c (xg_select): Put maxfds+1 into a var.
4112 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4114 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4116 2012-05-10 Dave Abrahams <dave@boostpro.com>
4118 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4119 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4121 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
4123 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4124 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4125 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4126 Initialize xd_registered_buses.
4128 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4130 Untag more efficiently if USE_LSB_TAG.
4131 This is based on a proposal by YAMAMOTO Mitsuharu in
4132 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4133 For an admittedly artificial (nth 8000 longlist) benchmark on
4134 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4135 Emacs's overall text size by 1%.
4136 * lisp.h (XUNTAG): New macro.
4137 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4138 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4139 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4140 * eval.c (Fautoload):
4141 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4142 * frame.h (XFRAME): Use XUNTAG.
4144 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4145 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4146 Remove unportable assumptions about print widths of types like
4148 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4149 intptr_t when converting between pointer and integer, to avoid GCC
4150 warnings about wrong width.
4152 2012-05-09 Eli Zaretskii <eliz@gnu.org>
4154 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4155 stack for each reader_thread, instead of defaulting to 8MB
4156 determined by the linker. This avoids failures in creating
4157 subprocesses on Windows 7, see the discussion in this thread:
4158 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4160 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4162 Fix up display of the *Minibuf-0* buffer in the mini window.
4163 * keyboard.c (read_char): Don't clear the echo area if there's no
4165 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
4166 contents of *Minibuf-0*) if there's no message displayed in its stead.
4168 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
4170 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4173 2012-05-06 Chong Yidong <cyd@gnu.org>
4175 * lisp.mk (lisp): Update.
4177 2012-05-05 Jim Meyering <meyering@redhat.com>
4179 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4181 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4183 * data.c (PUT_ERROR): New macro.
4184 (syms_of_data): Use it. Add new error type `user-error'.
4185 * undo.c (user_error): New function.
4186 (Fprimitive_undo): Use it.
4187 * print.c (print_error_message): Adjust print style for `user-error'.
4188 * keyboard.c (user_error): New function.
4189 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4191 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4193 Do not limit current-time-string to years 1000..9999.
4194 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4195 (Fcurrent_time_string): Support any year that is supported by the
4196 underlying localtime representation. Don't use asctime, as it
4197 has undefined behavior for years outside the range -999..9999.
4199 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4201 Fix race conditions involving setenv, gmtime, localtime, asctime.
4202 Without this fix, interrupts could mess up code that uses these
4203 nonreentrant functions, since setting TZ invalidates existing
4204 tm_zone or tzname values, and since most of these functions return
4205 pointers to static storage.
4206 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4207 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4208 Grow the critical sections to include not just invoking
4209 localtime/gmtime, but also accessing these functions' results
4210 including their tm_zone values if any, and any related TZ setting.
4211 (format_time_string): Last arg is now struct tm *, not struct tm **,
4212 so that the struct tm is saved in the critical section.
4213 All callers changed. Simplify allocation of initial buffer, partly
4214 motivated by the fact that memory allocation needs to be outside
4215 the critical section.
4217 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4219 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4220 with RESET_INTERVAL.
4222 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4223 Remove duplicated buffer name initialization.
4225 2012-05-02 Jim Meyering <jim@meyering.net>
4227 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4229 * xfns.c (x_window): Use xstrdup (Bug#11375).
4231 2012-05-02 Eli Zaretskii <eliz@gnu.org>
4233 * xdisp.c (pos_visible_p): If already at a newline from the
4234 display string before the 'while' loop, don't walk back the glyphs
4235 from it3.glyph_row. Solves assertion violation when the display
4236 string begins with a newline (egg.el). (Bug#11367)
4238 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4240 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4243 2012-05-01 Glenn Morris <rgm@gnu.org>
4245 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4246 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4247 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4248 All were removed before 23.1.
4250 * dispnew.c: Remove HAVE_LIBNCURSES test;
4251 it is always true on relevant platforms.
4253 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4254 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4256 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4258 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4260 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4261 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4264 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4266 Do not avoid creating empty evaporating overlays (Bug#9642).
4267 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4268 That is, do not delete an evaporating overlay if it becomes
4269 empty after its bounds are adjusted to fit within its buffer.
4270 This fix caused other problems, and I'm reverting it until we get
4271 to the bottom of them.
4273 2012-04-27 Chong Yidong <cyd@gnu.org>
4275 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4277 2012-04-27 Eli Zaretskii <eliz@gnu.org>
4279 * xdisp.c (pos_visible_p): If the window start position is beyond
4280 ZV, start the display from buffer beginning. Prevents assertion
4281 violation in init_iterator when the minibuffer window is scrolled
4284 * window.c (window_scroll_pixel_based): Likewise.
4286 2012-04-27 Chong Yidong <cyd@gnu.org>
4288 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4290 2012-04-27 Glenn Morris <rgm@gnu.org>
4292 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4293 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4295 2012-04-27 Eli Zaretskii <eliz@gnu.org>
4297 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4298 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
4300 2012-04-26 Eli Zaretskii <eliz@gnu.org>
4302 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4303 display element, check also the underlying string or buffer
4304 character. (Bug#11341)
4306 * w32menu.c: Include w32heap.h.
4307 (add_menu_item): If the call to AppendMenuW (via
4308 unicode_append_menu) fails, disable Unicode menus only if we are
4309 running on Windows 9X/Me.
4311 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4313 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4314 (xgetint): Add missing shift for LSB tags.
4316 2012-04-24 Martin Rudalics <rudalics@gmx.at>
4318 * keyboard.c (read_char): Don't wipe echo area for select window
4319 events: These might get delayed via `mouse-autoselect-window'
4322 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
4324 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4325 manipulation of :loaded-from data.
4327 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
4329 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4330 now a cons (bug#11311).
4332 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4334 Do not create empty overlays with the evaporate property (Bug#9642).
4335 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4336 if it becomes empty after its bounds are adjusted to fit within
4337 its buffer. Without this fix, in a nonempty buffer (let ((o
4338 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4339 yields an empty overlay that has the evaporate property, which is
4340 not supposed to happen.
4342 Fix minor GTK3 problems found by static checking.
4343 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4344 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4345 (struct _EmacsFixedClass, emacs_fixed_get_type):
4346 Move decls here from emacsgtkfixed.h, since they needn't be public.
4347 (emacs_fixed_get_type): Now static.
4348 (emacs_fixed_class_init): Omit unused local.
4349 (emacs_fixed_child_type): Remove; unused.
4350 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4351 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4352 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4353 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4354 (EMACS_FIXED_GET_CLASS): Remove; unused.
4355 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4357 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4358 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4360 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4362 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
4363 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
4364 (__malloc_size_t, __malloc_ptrdiff_t):
4365 Remove. All uses removed, replaced by the definiens if needed,
4366 since we can assume C89 or better now.
4367 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4368 (protect_malloc_state, align, get_contiguous_space)
4369 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4370 (malloc_atfork_handler_child, malloc_enable_thread)
4371 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4372 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4373 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4374 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4375 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4376 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4377 Define using prototypes, not old style.
4378 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4379 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4380 (align): Don't assume that signed integer overflow wraps around.
4381 Omit unused local var.
4382 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4383 (_free_internal_nolock, memalign, mallochook, reallochook):
4384 Omit no-longer-needed casts.
4385 (valloc): Use getpagesize, not __getpagesize.
4386 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4387 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4389 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4391 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
4393 Move functions from C to Lisp. Make non-blocking method calls
4394 the default. Implement further D-Bus standard interfaces.
4396 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4397 (QCdbus_request_name_allow_replacement)
4398 (QCdbus_request_name_replace_existing)
4399 (QCdbus_request_name_do_not_queue)
4400 (QCdbus_request_name_reply_primary_owner)
4401 (QCdbus_request_name_reply_in_queue)
4402 (QCdbus_request_name_reply_exists)
4403 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4404 (QCdbus_registered_serial, QCdbus_registered_method)
4405 (QCdbus_registered_signal): New Lisp objects.
4406 (XD_DEBUG_MESSAGE): Use sizeof.
4407 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4408 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4409 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4410 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4411 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4412 (xd_signature, xd_append_arg): Allow float for integer types.
4413 (xd_get_connection_references): New function.
4414 (xd_get_connection_address): Rename from xd_initialize.
4415 Return cached address.
4416 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4417 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4419 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
4420 Return number of refcounts.
4421 (Fdbus_get_unique_name): Make stronger parameter check.
4422 (Fdbus_message_internal): New defun.
4423 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4424 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4425 (Fdbus_send_signal, Fdbus_register_service)
4426 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4427 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4428 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4429 (Vdbus_compiled_version, Vdbus_runtime_version)
4430 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4431 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4432 (Vdbus_message_type_signal): New defvars.
4433 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4436 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4438 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4439 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4440 Do not assume ptrdiff_t is the same width as 'int'.
4442 * alloc.c: Handle unusual debugging option combinations.
4443 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4444 since the two debugging options are incompatible.
4445 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4447 (mem_init, mem_insert, mem_insert_fixup):
4448 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4449 (NEED_MEM_INSERT): Remove; no longer needed.
4451 2012-04-22 Leo Liu <sdl.web@gmail.com>
4453 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4455 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4457 * sysdep.c [__FreeBSD__]: Minor cleanups.
4458 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4459 Use Emacs indenting style more consistently. Avoid some casts.
4460 Use 'double' consistently rather than mixing 'float' and 'double'.
4462 2012-04-21 Eduard Wiebe <usenet@pusto.de>
4464 * sysdep.c (list_system_processes, system_process_attributes):
4465 Add implementation for FreeBSD (Bug#5243).
4467 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4469 * lisp.mk (lisp): Update.
4471 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4473 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4474 It is never used otherwise.
4476 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4478 * print.c (print_preprocess): Only check print_depth if print-circle
4480 (print_object): Check for cycles even when print-circle is nil and
4481 print-gensym is t, but only check print_depth if print-circle is nil.
4483 2012-04-20 Chong Yidong <cyd@gnu.org>
4485 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4486 set the status to "failed" and ensure that sentinel is run.
4488 2012-04-20 Glenn Morris <rgm@gnu.org>
4490 * process.c (Fset_process_inherit_coding_system_flag)
4491 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4492 (Fmake_network_process, Fmake_serial_process): Doc fix.
4494 2012-04-20 Eli Zaretskii <eliz@gnu.org>
4496 * xdisp.c (string_buffer_position_lim): Limit starting position to
4498 (set_cursor_from_row): If called for a mode-line or header-line
4499 row, return zero immediately.
4500 (try_cursor_movement): If inside continuation line, don't back up
4501 farther than the first row after the header line, if any.
4502 Don't consider the header-line row as "partially visible", even if
4503 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4505 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
4507 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4510 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
4511 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
4513 configure: new option --enable-gcc-warnings (Bug#11207)
4514 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4515 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4516 (ALL_CFLAGS): Use new macros rather than old.
4517 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4518 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4519 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4520 -Wunused-result, -Wunused-variable. This should go away once
4521 the Emacs and Gnulib regex code is merged.
4522 (xmalloc, xrealloc): Now static.
4524 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4526 * dired.c (Fsystem_groups): Remove unused local.
4528 2012-04-17 Glenn Morris <rgm@gnu.org>
4530 * dired.c (Fsystem_users): Doc fix.
4532 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4534 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4535 (syms_of_dired): Add them.
4537 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4539 Fix minor alloc.c problems found by static checking.
4540 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4541 New extern decls, to avoid calling undeclared functions.
4542 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4543 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4544 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4545 (NEED_MEM_INSERT): New macro.
4546 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4547 Remove one incorrect comment and fix another.
4549 Fix minor ralloc.c problems found by static checking.
4550 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4551 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4552 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4553 (r_alloc_sbrk): Now static.
4555 Improve ralloc.c interface checking.
4556 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4557 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4558 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4559 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4560 [REL_ALLOC]: ... to here, to check interface.
4561 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4562 Remove decls. This fixes an "It stinks!".
4564 * alloc.c (which_symbols): Fix alignment issue / type clash.
4566 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4568 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4569 (struct Lisp_Misc_Any): Likewise.
4570 (struct Lisp_Free): Likewise.
4571 * alloc.c (union aligned_Lisp_Symbol): Define.
4572 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4573 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4574 (union aligned_Lisp_Misc): Define.
4575 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4576 aligned_Lisp_Misc instead of union Lisp_Misc.
4577 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
4579 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4581 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4582 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4583 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4584 * s/netbsd.h, s/sol2-6.h:
4585 Remove definition of GC_MARK_STACK, since the default now works.
4586 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4587 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4588 no longer the default.
4589 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4591 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
4593 * lread.c (lisp_file_lexically_bound_p):
4594 Fix hang at ";-*-\n" (bug#11238).
4596 2012-04-14 Eli Zaretskii <eliz@gnu.org>
4598 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4599 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4601 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4603 * nsterm.m (constrainFrameRect): Always constrain when there is only
4604 one screen (Bug#10962).
4606 2012-04-13 Ken Brown <kbrown@cornell.edu>
4608 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4610 2012-04-13 Reuben Thomas <rrt@sc3d.org>
4612 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4614 2012-04-11 Daniel Colascione <dancol@dancol.org>
4616 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4617 against is gone. It's better to use vfork now so that when Cygwin
4618 gains a new, working vfork, we use it automatically (bug#10398).
4620 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4622 * window.c (save_window_save): Obey window-point-insertion-type.
4624 2012-04-11 Glenn Morris <rgm@gnu.org>
4626 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4628 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4630 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4632 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
4634 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4635 (force_quit_count): New var.
4636 (handle_interrupt): Use it.
4638 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
4640 * w32.c (w32_delayed_load): Record the full path of the library
4641 being loaded (bug#10424).
4643 2012-04-09 Glenn Morris <rgm@gnu.org>
4645 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4646 not just in the obarray, before snarfing them. (Bug#11036)
4648 * Makefile.in ($(leimdir)/leim-list.el):
4649 Pass EMACS rather than BUILT_EMACS.
4651 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4653 * process.c (make_process):
4654 * process.h: Add integer `gnutls_handshakes_tried' member to
4657 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4658 Add convenience `GNUTLS_LOG2i' macro.
4660 * gnutls.c (gnutls_log_function2i): Convenience log function.
4661 (emacs_gnutls_read): Use new log functions,
4662 `gnutls_handshakes_tried' process member, and
4663 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4664 attempts per process (connection).
4666 2012-04-09 Chong Yidong <cyd@gnu.org>
4668 * eval.c (Fuser_variable_p, user_variable_p_eh)
4669 (lisp_indirect_variable): Functions deleted.
4670 (Fdefvar): Caller changed.
4672 * callint.c (Finteractive, Fcall_interactively):
4673 * minibuf.c (Fread_variable): Callers changed.
4675 2012-04-09 Eli Zaretskii <eliz@gnu.org>
4677 * xdisp.c (set_cursor_from_row): If the display string appears in
4678 the buffer at position that is closer to point than the position
4679 after the display string, display the cursor on the first glyph of
4680 the display string. Fixes cursor display when a 'display' text
4681 property immediately follows invisible text. (Bug#11094)
4683 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4685 composite.c: use 'double' consistently
4686 * composite.c (get_composition_id): Use 'double' consistently
4687 instead of converting 'float' to 'double' and vice versa; this is
4688 easier to understand and avoids a GCC warning.
4690 2012-04-09 Glenn Morris <rgm@gnu.org>
4692 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4693 preparation for dumping it with emacs. (Bug#4789)
4694 (leimdir): New variable.
4695 ($(leimdir)/leim-list.el): New rule.
4696 (emacs$(EXEEXT)): Depend on leim-list.el.
4698 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4699 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4700 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4702 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4704 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4707 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
4709 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4710 Remove unused local variable.
4712 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4714 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4715 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4716 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4717 objects, as mark_maybe_pointer will catch them otherwise.
4718 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4719 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4721 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4723 Fix typo that broke non-Windows builds.
4724 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4726 2012-04-07 Eli Zaretskii <eliz@gnu.org>
4728 Support building on MS-Windows with libxml2.
4730 * makefile.w32-in (OBJ2): Add xml.$(O).
4731 (GLOBAL_SOURCES): Add xml.c.
4732 ($(BLD)/xml.$(O)): New dependency list.
4734 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4735 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4736 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4737 [!WINDOWSNT]: New macros.
4738 (init_libxml2_functions, libxml2_loaded_p): New functions.
4739 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4740 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4741 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4742 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4744 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4745 Call init_libxml2_functions before calling libxml2 functions.
4746 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4748 * emacs.c: Don't include libxml/parser.h.
4749 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4750 xmlCleanupParser directly.
4752 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4754 2012-04-07 Eli Zaretskii <eliz@gnu.org>
4756 * indent.c (Fvertical_motion): If there is a display string at
4757 point, use it.vpos to compute how many lines to backtrack after
4758 move_it_to point. (Bug#11133)
4760 2012-04-06 Eli Zaretskii <eliz@gnu.org>
4762 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4763 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4764 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4765 macros related to unification of CJK characters. For the details,
4766 see the discussion following the message here:
4767 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4769 2012-04-04 Chong Yidong <cyd@gnu.org>
4771 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4773 2012-04-01 Eli Zaretskii <eliz@gnu.org>
4775 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4776 instead of alloca. (Bug#11138)
4778 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4780 * w32menu.c (is_simple_dialog): Properly check lisp types.
4783 2012-03-31 Eli Zaretskii <eliz@gnu.org>
4785 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4786 position we get to after a call to move_it_to fails the
4787 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4788 only if we wind up in a string from display property. (Bug#11063)
4790 * window.c (Fdelete_other_windows_internal): Invalidate the row
4791 and column information about mouse highlight, so that redisplay
4792 restores it after reallocating the glyph matrices. (Bug#7464)
4794 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4795 string comes from a `display' text property, use the buffer
4796 position of that property as if we actually saw that position in
4798 (move_it_by_lines): Remove the assertion that
4799 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4800 violated when there's a before-string at the beginning of a line.
4803 2012-03-30 Eli Zaretskii <eliz@gnu.org>
4805 * xdisp.c (append_space_for_newline): If the default face was
4806 remapped, use the remapped face for the appended newline.
4807 (extend_face_to_end_of_line): Use the remapped default face for
4808 extending the face to the end of the line.
4809 (display_line): Call extend_face_to_end_of_line when the default
4810 face was remapped. (Bug#11068)
4812 2012-03-29 Eli Zaretskii <eliz@gnu.org>
4814 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4816 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4818 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4820 2012-03-27 Glenn Morris <rgm@gnu.org>
4822 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4825 2012-03-26 Kenichi Handa <handa@m17n.org>
4827 * dispextern.h (struct glyph): Fix previous change. Change the
4828 bit length of glyphless.ch to 25 (Bug#11082).
4830 2012-03-26 Chong Yidong <cyd@gnu.org>
4832 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4833 (command_loop_1): Use it; inhibit selection update for
4834 handle-select-window too (Bug#8996).
4836 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4838 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
4840 2012-03-25 Kenichi Handa <handa@m17n.org>
4842 * dispextern.h (struct glyph): Change the bit length of
4843 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4845 2012-03-24 Eli Zaretskii <eliz@gnu.org>
4847 * s/ms-w32.h (tzname): Include time.h before redirecting to
4848 _tzname. Fixes the MSVC build. (Bug#9960)
4850 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4852 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4855 * xterm.c (XTread_socket): Only modify handling_signal if
4856 !SYNC_INPUT. (Bug#11080)
4858 2012-03-23 Eli Zaretskii <eliz@gnu.org>
4860 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4861 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4862 when fetching a multibyte character consumes more bytes than
4863 CHAR_BYTES returns, due to unification of CJK characters in
4864 string_char. (Bug#11073)
4866 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4868 * process.c (wait_reading_process_output): Handle pty disconnect
4869 by refraining from sending oneself a SIGCHLD (bug#10933).
4871 2012-03-22 Chong Yidong <cyd@gnu.org>
4873 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4875 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
4876 Mark string as coming from a prefix property.
4877 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4878 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4880 2012-03-21 Chong Yidong <cyd@gnu.org>
4882 * xfaces.c (Vface_remapping_alist): Doc fix.
4884 2012-03-20 Eli Zaretskii <eliz@gnu.org>
4886 * w32proc.c (Fw32_set_console_codepage)
4887 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4890 2012-03-20 Chong Yidong <cyd@gnu.org>
4892 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4893 to reflect default non-nil value of redisplay-dont-pause.
4895 2012-03-19 Kenichi Handa <handa@m17n.org>
4897 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4898 it fit in a valid range (Bug#11003).
4900 2012-03-18 Eli Zaretskii <eliz@gnu.org>
4902 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4903 that is not from display property, accept the row as a "cursor
4904 row" if one of the string's character has a non-nil `cursor'
4905 property. Fixes cursor positioning when there are newlines in
4906 overlay strings, e.g. in icomplete.el. (Bug#11035)
4908 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4910 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4912 2012-03-12 Chong Yidong <cyd@gnu.org>
4914 * eval.c (inhibit_lisp_code): Rename from
4915 inhibit_window_configuration_change_hook; move from window.c.
4917 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4918 * window.c (run_window_configuration_change_hook)
4919 (syms_of_window): Callers changed.
4921 2012-03-11 Chong Yidong <cyd@gnu.org>
4923 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4925 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4927 2012-03-10 Chong Yidong <cyd@gnu.org>
4929 * frame.c (other_visible_frames): Don't assume the selected frame
4930 is visible (Bug#10955).
4932 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4934 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4936 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4938 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4939 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4942 2012-03-03 Glenn Morris <rgm@gnu.org>
4944 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
4946 2012-03-02 Eli Zaretskii <eliz@gnu.org>
4948 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4949 position past the first glyph_row that ends at ZV. (Bug#10902)
4950 (redisplay_window, next_element_from_string): Fix typos in
4952 (redisplay_window): Pass to move_it_vertically the margin in
4953 pixels, not in screen lines.
4955 2012-03-02 Glenn Morris <rgm@gnu.org>
4957 * buffer.c (buffer-list-update-hook): Doc fix.
4959 2012-02-29 Eli Zaretskii <eliz@gnu.org>
4961 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4962 push_it before setting up the iterator for the first overlay
4963 string, even if we have an empty string loaded.
4964 (next_overlay_string): If there's an empty string on the iterator
4965 stack, pop the stack. (Bug#10903)
4967 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4969 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4970 Suggested by Stefan Monnier in
4971 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4972 * alloc.c (widen_to_Lisp_Object): New static function.
4973 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4974 and widening them to Lisp_Objects. This would work even if
4975 USE_LSB_TAG is defined and wide integers are used, which might
4976 happen in a future version of Emacs.
4978 2012-02-25 Chong Yidong <cyd@gnu.org>
4980 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4983 * xselect.c (Fx_selection_exists_p): Doc fix.
4984 (x_clipboard_manager_save_all): Print an informative message
4985 before saving to clipboard manager.
4987 2012-02-24 Chong Yidong <cyd@gnu.org>
4989 * keyboard.c (process_special_events): Handle all X selection
4990 requests in kbd_buffer, not just the next one (Bug#8869).
4992 2012-02-23 Chong Yidong <cyd@gnu.org>
4994 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4995 call when setting menu-bar-lines and tool-bar-lines parameters.
4996 (unwind_create_frame_1): New helper function.
4998 * window.c (inhibit_window_configuration_change_hook): New var.
4999 (run_window_configuration_change_hook): Obey it.
5000 (syms_of_window): Initialize it.
5002 2012-02-22 Chong Yidong <cyd@gnu.org>
5004 * xterm.c (x_draw_image_relief): Add missing type check for
5005 Vtool_bar_button_margin (Bug#10743).
5007 2012-02-21 Chong Yidong <cyd@gnu.org>
5009 * fileio.c (Vfile_name_handler_alist): Doc fix.
5011 * buffer.c (Fget_file_buffer): Protect against invalid file
5012 handler return value.
5014 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5016 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5017 when computing $valmask.
5019 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5020 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5021 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5022 It's useless in that case, and it can cause problems on hosts
5023 that allocate halves of EMACS_INT values separately.
5024 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5025 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5026 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5027 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5028 it avoids undefined behavior on hosts where shifting right by more
5029 than the word width has undefined behavior.
5031 2012-02-19 Chong Yidong <cyd@gnu.org>
5033 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5034 (Funhandled_file_name_directory, Ffile_name_as_directory)
5035 (Fdirectory_file_name, Fexpand_file_name)
5036 (Fsubstitute_in_file_name): Protect against invalid file handler
5037 return values (Bug#10845).
5039 2012-02-18 Eli Zaretskii <eliz@gnu.org>
5041 * .gdbinit (pitx): Fix incorrect references to fields of the
5044 2012-02-17 Chong Yidong <cyd@gnu.org>
5046 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5048 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5050 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5051 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5053 2012-02-15 Chong Yidong <cyd@gnu.org>
5055 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5056 marked as special. Also, starting docstrings with * is obsolete.
5058 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5060 * gnutls.c (emacs_gnutls_write): Fix last change.
5062 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5064 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5067 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5069 * keymap.c (Fsingle_key_description): Handle char ranges.
5071 2012-02-12 Chong Yidong <cyd@gnu.org>
5073 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5074 as that creates a dangerous corner case.
5076 * window.c (Fdelete_window_internal): Invalidate the mouse
5077 highlight (Bug#9904).
5079 2012-02-12 Glenn Morris <rgm@gnu.org>
5081 * xselect.c (Fx_own_selection_internal)
5082 (Fx_get_selection_internal, Fx_disown_selection_internal)
5083 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5084 * nsselect.m (Fx_own_selection_internal)
5085 (Fx_disown_selection_internal, Fx_selection_exists_p)
5086 (Fx_selection_owner_p, Fx_get_selection_internal):
5087 Sync docs and argument specs with the xselect.c versions.
5089 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5091 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5093 2012-02-11 Eli Zaretskii <eliz@gnu.org>
5095 * w32select.c (Fx_selection_exists_p): Sync doc string and
5096 argument list with xselect.c. (Bug#10783)
5098 * w16select.c (Fx_selection_exists_p): Sync doc string and
5099 argument list with xselect.c. (Bug#10783)
5101 2012-02-10 Glenn Morris <rgm@gnu.org>
5103 * fns.c (Fsecure_hash): Doc fix.
5105 2012-02-09 Kenichi Handa <handa@m17n.org>
5107 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5109 2012-02-07 Chong Yidong <cyd@gnu.org>
5111 * buffer.c (Fbuffer_local_variables)
5112 (buffer_lisp_local_variables): Handle unbound vars correctly;
5113 don't let Qunbound leak into Lisp.
5115 2012-02-07 Glenn Morris <rgm@gnu.org>
5117 * image.c (Fimagemagick_types): Doc fix.
5119 * image.c (imagemagick-render-type): Change it from a lisp object
5120 to an integer. Move the doc here from the lisp manual.
5121 Treat all values not equal to 0 the same.
5123 2012-02-06 Chong Yidong <cyd@gnu.org>
5125 * doc.c (store_function_docstring): Avoid applying docstring of
5126 alias to base function (Bug#2603).
5128 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5130 * .gdbinit (pp1, pv1): Remove redundant defines.
5133 2012-02-04 Chong Yidong <cyd@gnu.org>
5135 * nsterm.m: Declare a global (Bug#10694).
5137 2012-02-04 Eli Zaretskii <eliz@gnu.org>
5139 * w32.c (get_emacs_configuration_options):
5140 Include --enable-checking, if specified, in the return value.
5142 2012-02-04 Martin Rudalics <rudalics@gmx.at>
5144 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5145 after rounding frame sizes. (Bug#9723)
5147 2012-02-04 Eli Zaretskii <eliz@gnu.org>
5149 * keyboard.c (adjust_point_for_property): Don't position point
5150 before BEGV. (Bug#10696)
5152 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5154 Handle overflow when computing char display width (Bug#9496).
5155 * character.c (char_width): Return EMACS_INT, not int.
5156 (char_width, c_string_width): Check for overflow when
5157 computing the width; this is possible now that individual
5158 characters can have unbounded width. Problem introduced
5159 by merge from Emacs 23 on 2012-01-19.
5161 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
5163 * dbusbind.c (Fdbus_register_method): Mention the return value
5164 :ignore in the docstring.
5166 2012-02-02 Glenn Morris <rgm@gnu.org>
5168 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5170 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5171 Unconditionally set to t. (Bug#10673)
5172 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5173 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5174 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5176 2012-02-02 Kenichi Handa <handa@m17n.org>
5178 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5179 0, do not call append_composite_glyph.
5181 2012-02-02 Kenichi Handa <handa@m17n.org>
5183 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5185 (x_produce_glyphs): If the component of a composition is a null
5186 string, set it->pixel_width to 1 to avoid zero-width glyph.
5188 2012-02-01 Eli Zaretskii <eliz@gnu.org>
5190 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5191 first 2 arguments are identical. This makes inserting large
5192 output from a subprocess an order of magnitude faster on
5193 MS-Windows, where all sbrk'ed memory is always contiguous.
5195 2012-01-31 Glenn Morris <rgm@gnu.org>
5197 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5198 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5199 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5201 2012-01-29 Glenn Morris <rgm@gnu.org>
5203 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5205 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5207 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5209 2012-01-28 Chong Yidong <cyd@gnu.org>
5211 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5213 2012-01-26 Chong Yidong <cyd@gnu.org>
5215 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5217 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5218 repeat counts (Bug#10507).
5220 2012-01-26 Glenn Morris <rgm@gnu.org>
5222 * lread.c (syms_of_lread): Doc fix.
5224 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5226 * coding.c (encode_designation_at_bol): Change return value to
5229 2012-01-25 Chong Yidong <cyd@gnu.org>
5231 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5233 2012-01-21 Chong Yidong <cyd@gnu.org>
5235 * floatfns.c (Fcopysign): Make the second argument non-optional,
5236 since nil is not allowed anyway.
5238 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5240 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5241 (send_process): Likewise.
5243 2012-01-19 Martin Rudalics <rudalics@gmx.at>
5245 * window.c (save_window_save, Fcurrent_window_configuration)
5246 (Vwindow_persistent_parameters): Do not use Qstate.
5247 Rewrite doc-strings.
5249 2012-01-19 Kenichi Handa <handa@m17n.org>
5251 * character.c (char_width): New function.
5252 (Fchar_width, c_string_width, lisp_string_width):
5253 Use char_width (Bug#9496).
5255 2012-01-16 Martin Rudalics <rudalics@gmx.at>
5257 * window.c (Vwindow_persistent_parameters): New variable.
5258 (Fset_window_configuration, save_window_save): Handle persistent
5261 2012-01-14 Eli Zaretskii <eliz@gnu.org>
5263 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5264 thrashing the stack of the thread. (Bug#9087)
5266 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5268 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5270 2012-01-11 Eli Zaretskii <eliz@gnu.org>
5272 * xdisp.c (rows_from_pos_range): Handle the case where the
5273 highlight ends on a newline. (Bug#10464)
5274 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5275 he end column for display of highlight that ends on a newline
5278 2012-01-11 Glenn Morris <rgm@gnu.org>
5280 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5281 from load-path also when installation-directory is nil. (Bug#10208)
5283 2012-01-10 Glenn Morris <rgm@gnu.org>
5285 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5287 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5288 Update template values to be closer to their typical values these days.
5290 2012-01-09 Eli Zaretskii <eliz@gnu.org>
5292 * xdisp.c (rows_from_pos_range): Accept additional argument
5293 DISP_STRING, and accept any glyph in a row whose object is that
5294 string as eligible for mouse highlight. Fixes mouse highlight of
5295 display strings from overlays. (Bug#10464)
5297 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
5299 emacs: fix an auto-save permissions race condition (Bug#10400)
5300 * fileio.c (auto_saving_dir_umask): New static var.
5301 (Fmake_directory_internal): Use it.
5302 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5303 creating the directory. The old code temporarily assigns
5304 too-generous permissions to the directory.
5305 (do_auto_save_eh): Clear it.
5306 (Fdo_auto_save): Catch all errors, not just file errors, so
5307 that the var is always cleared.
5309 2012-01-07 Eli Zaretskii <eliz@gnu.org>
5311 * search.c (scan_buffer): Pass character positions to
5312 know_region_cache, not byte positions. (Bug#6540)
5314 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
5316 * w32.c (sys_rename): Report EXDEV when rename of a directory
5317 fails because the target is on another logical disk. (Bug#10284)
5319 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5321 * xterm.c (x_embed_request_focus): New function.
5323 * xterm.h: Add prototype.
5325 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5327 2012-01-05 Glenn Morris <rgm@gnu.org>
5329 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5331 2012-01-01 Eli Zaretskii <eliz@gnu.org>
5333 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5334 Load gnutls_transport_set_lowat only if GnuTLS version is below
5336 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5337 GnuTLS versions below 2.11.1.
5339 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5341 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5342 to the doc string advising against its use for altering the way
5343 windows are scrolled.
5345 2011-12-28 Kenichi Handa <handa@m17n.org>
5347 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5348 coding-system ASCII compatible only when it does not produce BOM
5349 on encoding (Bug#10383).
5351 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5353 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5355 (create_and_show_popup_menu): Always use menu_position_func for
5358 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5360 * callint.c (Fcall_interactively): Don't truncate prompt string.
5362 2011-12-23 Eli Zaretskii <eliz@gnu.org>
5364 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5365 property that ends at ZV, so that the bidi iteration could be
5366 resumed from there (after widening). (Bug#10360)
5368 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5370 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5372 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5374 * nsterm.m (x_free_frame_resources):
5375 Release f->output_data.ns->miniimage.
5376 (ns_index_color): Fix indentation. Do not retain
5377 color_table->colors[i].
5379 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5382 * nsfns.m (x_set_background_color): Assign return value from
5383 ns_index_color to face-background instead of NSColor*.
5384 (ns_implicitly_set_icon_type): Fix indentation.
5385 Change assignment in for loop to comparison.
5387 * emacs.c (ns_pool): New variable.
5388 (main): Assign ns_pool.
5389 (Fkill_emacs): Call ns_release_autorelease_pool.
5391 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5392 autorelease fdesc, release fdAttrs and tdict.
5393 (ns_get_covering_families): Release charset.
5394 (ns_findfonts): Release NSFontDescriptor created with new.
5395 (ns_uni_to_glyphs): Fix indentation.
5396 (setString): Release attrStr before assigning new value.
5398 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5400 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5402 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5403 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5405 2011-12-18 David Reitter <reitter@cmu.edu>
5407 * nsterm.m (ns_term_init): Subscribe for notifications
5408 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5409 to method trackingNotification in EmacsMenu.
5411 * nsmenu.m (trackingMenu): New variable.
5412 (trackingNotification): New method (from Aquamacs).
5413 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
5414 from Aquamacs (Bug#7030).
5416 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5418 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5419 (symbol_to_nsstring): Fix indentation.
5420 (ns_symbol_to_pb): New function.
5421 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5422 (Fns_rotate_cut_buffers_internal): Remove.
5423 (Fns_store_selection_internal): Rename from
5424 Fns_store_cut_buffer_internal.
5425 (ns_get_foreign_selection, Fx_own_selection_internal)
5426 (Fx_disown_selection_internal, Fx_selection_exists_p)
5427 (Fns_get_selection_internal, Fns_store_selection_internal):
5428 Use ns_symbol_to_pb and check if return value is nil.
5429 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5430 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
5431 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5432 renamed to Sns_store_selection_internal.
5433 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5434 and remove this function.
5435 (ns_handle_selection_clear): Remove, never used.
5436 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5439 2011-12-17 Ken Brown <kbrown@cornell.edu>
5441 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5442 GID is unknown (Bug#10257).
5444 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5446 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5447 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5448 which caused a build failure on GNU/Linux IA-64. This problem was
5449 introduced by my 2011-10-07 patch.
5451 2011-12-15 Juri Linkov <juri@jurta.org>
5453 * image.c (imagemagick_error): New function. (Bug#10112)
5454 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5455 Use `imagemagick_error' where ImageMagick functions return
5457 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5460 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5462 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5463 fill background (Bug#8992).
5465 2011-12-13 Martin Rudalics <rudalics@gmx.at>
5467 * window.c (Vwindow_combination_resize)
5468 (Vwindow_combination_limit): Use t instead of non-nil in
5470 (Vrecenter_redisplay): Add first sentence of doc-string on
5472 (Frecenter): Fix doc-string typo.
5474 2011-12-11 Kenichi Handa <handa@m17n.org>
5476 * coding.c (Funencodable_char_position): Pay attention to the
5477 buffer text relocation (Bug#9389).
5479 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5481 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5482 gtk_init (Bug#10100).
5484 2011-12-10 Eli Zaretskii <eliz@gnu.org>
5486 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5487 IT->string is nil. (Bug#10263)
5489 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5491 * nsterm.h (x_free_frame_resources): Declare.
5493 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5494 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5496 * nsterm.h (ns_get_defaults_value): Declare.
5498 * nsterm.m (ns_default): Call ns_get_defaults_value.
5500 2011-12-09 Eli Zaretskii <eliz@gnu.org>
5502 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5505 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5507 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5508 that where the value of an _OBJC_* symbol points to is in the .bss
5509 section (Bug#10240).
5511 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5513 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
5514 after the loop to call ccl_driver at least once (Bug#8619).
5516 2011-12-08 Kenichi Handa <handa@m17n.org>
5518 * ftfont.c (get_adstyle_property): Fix previous change
5521 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
5523 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5524 dirs from the default value of EMACSLOADPATH (bug#10208).
5526 2011-12-07 Glenn Morris <rgm@gnu.org>
5528 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5529 installation and source directories as well. (Bug#10208)
5531 2011-12-06 Chong Yidong <cyd@gnu.org>
5533 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5535 2011-12-06 Glenn Morris <rgm@gnu.org>
5537 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5538 as an error, not just -1. (Bug#10217)
5540 2011-12-05 Chong Yidong <cyd@gnu.org>
5542 * keyboard.c (process_special_events): New function.
5543 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5545 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5547 * coding.c (encode_designation_at_bol): Don't use uninitialized
5548 local variable (Bug#9318).
5550 2011-12-05 Kenichi Handa <handa@m17n.org>
5552 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5553 return Qnil (Bug#8046, Bug#10193).
5555 2011-12-05 Kenichi Handa <handa@m17n.org>
5557 * coding.c (encode_designation_at_bol): New args charbuf_end and
5558 dst. Return the number of produced bytes. Callers changed.
5559 (coding_set_source): Return how many bytes coding->source was
5561 (coding_set_destination): Return how many bytes
5562 coding->destination was relocated.
5563 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
5564 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5566 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5568 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5569 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5572 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5574 The following changes are to fix Bug#9318.
5576 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5577 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5578 (encode_coding_iso_2022, encode_coding_sjis)
5579 (encode_coding_big5, encode_coding_charset): Use the above macros.
5581 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
5583 * lisp.h (process_quit_flag): Fix external declaration.
5585 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5587 Don't macro-inline non-performance-critical code.
5588 * eval.c (process_quit_flag): New function.
5589 * lisp.h (QUIT): Use it.
5591 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5593 * nsfns.m (get_geometry_from_preferences): New function.
5594 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5596 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5598 * emacs.c (Qkill_emacs): Define.
5599 (syms_of_emacs): Initialize it.
5600 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5601 Qquit_flag to `kill-emacs' instead.
5602 (quit_throw_to_read_char): Add parameter `from_signal'.
5603 All callers changed. Call Fkill_emacs if requested and safe.
5604 * lisp.h (QUIT): Call Fkill_emacs if requested.
5606 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5608 * widget.c (update_wm_hints): Return if wmshell is null.
5609 (widget_update_wm_size_hints): New function.
5611 * widget.h (widget_update_wm_size_hints): Declare.
5613 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5614 widget_update_wm_size_hints (Bug#10104).
5616 2011-12-03 Eli Zaretskii <eliz@gnu.org>
5618 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5619 before a newline, prepare the bidi iterator for consuming the
5620 newline, and keep the current paragraph direction. (Bug#10183)
5621 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
5623 2011-12-02 Juri Linkov <juri@jurta.org>
5625 * search.c (Fword_search_regexp): New Lisp function created from
5626 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5627 (Fword_search_backward, Fword_search_forward)
5628 (Fword_search_backward_lax, Fword_search_forward_lax):
5629 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5630 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5632 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5634 * fileio.c (Finsert_file_contents): Move after-change-function call
5635 to before the "handled:" label, since all "goto handled" appear in
5636 cases where the *-change-functions have already been properly called
5639 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5641 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5642 waiting for input. (Bug#10169)
5644 2011-11-30 Eli Zaretskii <eliz@gnu.org>
5646 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5647 verifies glyph row's hash code--we have just reallocated the
5648 glyphs, so their contents can be complete garbage. (Bug#10164)
5650 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
5652 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5654 2011-11-30 Eli Zaretskii <eliz@gnu.org>
5656 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5657 attributes are tested _before_ calling verify_row_hash, to protect
5658 against GCC re-ordering of the tests. (Bug#10164)
5660 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5662 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5664 * xterm.c (handle_one_xevent): Only set async_visible and friends
5665 if net_wm_state_hidden_seen is non-zero (Bug#10002)
5666 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
5667 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5669 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5671 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5672 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5673 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5674 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5675 All uses changed to use GCPRO1 etc.
5676 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5677 Revert to old implementation (i.e., before 2011-03-11).
5679 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5681 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5682 of scroll runs so as to avoid assigning disabled bogus rows and
5683 unnecessary graphics copy operations.
5685 2011-11-27 Eli Zaretskii <eliz@gnu.org>
5687 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5688 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5689 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5690 (malloc, free, realloc, calloc): Redirect to e_* only when
5693 * lisp.h (GCTYPEBITS): Move before first use.
5694 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5695 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5696 this macro definition.
5698 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5701 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5703 * gtkutil.c (xg_create_frame_widgets):
5704 Call gtk_window_set_has_resize_grip (FALSE) if that function is
5705 present with Gtk+ 2.0.
5707 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5709 * fileio.c (Finsert_file_contents): Undo previous change; see
5710 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5712 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5714 Rename locals to avoid shadowing.
5715 * fileio.c (Finsert_file_contents):
5716 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5717 * process.c (wait_reading_process_output):
5718 Rename inner 'proc' to 'p' to avoid shadowing.
5719 Indent for consistency with usual Emacs style.
5721 2011-11-25 Eli Zaretskii <eliz@gnu.org>
5723 * xdisp.c (redisplay_window): If cursor row is not fully visible
5724 after recentering, and scroll-conservatively is set to a large
5725 number, scroll window by a few more lines to make the cursor fully
5726 visible and out of scroll-margin. (Bug#10105)
5727 (start_display): Don't move to the next line if the display should
5728 start at a newline that is part of a display vector or an overlay
5731 2011-11-24 Juri Linkov <juri@jurta.org>
5733 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5734 after the `MagickPingImage' call. (Bug#10112)
5736 2011-11-23 Chong Yidong <cyd@gnu.org>
5738 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5740 2011-11-23 Martin Rudalics <rudalics@gmx.at>
5742 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5743 making another buffer current. (Bug#10114)
5745 2011-11-23 Glenn Morris <rgm@gnu.org>
5747 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5749 2011-11-23 Chong Yidong <cyd@gnu.org>
5751 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5752 using it (Bug#5984).
5754 2011-11-22 Eli Zaretskii <eliz@gnu.org>
5756 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5757 and header-lines, as they don't have one computed for them.
5760 * .gdbinit (prow): Make displayed values more self-explaining.
5761 Add row's hash code.
5763 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5765 * process.c (wait_reading_process_output): Fix asynchrounous
5766 GnuTLS socket handling on some versions of the GnuTLS library.
5767 (wait_reading_process_output): Add comment and URL.
5769 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5771 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5773 2011-11-21 Chong Yidong <cyd@gnu.org>
5775 * window.c (Fnext_window, Fprevious_window): Doc fix.
5777 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5779 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5781 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
5783 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5785 2011-11-20 Martin Rudalics <rudalics@gmx.at>
5787 * window.c (Fset_window_combination_limit): Rename argument
5789 (Vwindow_combination_limit): Remove "status" from doc-string.
5791 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5793 * m/ibms390.h: Remove.
5794 * m/ibms390x.h: Don't include "ibms390.h".
5796 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5798 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5799 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5801 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
5803 * casetab.c (Fset_case_table):
5804 * charset.c (Fcharset_after): Fix typos.
5806 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
5808 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5809 Otherwise, valgrind does not work on some platforms.
5810 Problem reported by Andreas Schwab in
5811 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5812 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5813 is set, removing the need for VIRT_ADDRESS_VARIES.
5814 (PURE_P): Use a more-efficient implementation that needs just one
5815 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5816 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5817 to 4 (xorl, subq, cmpq, setbe).
5818 * alloc.c (pure): Always extern now, since that's the
5819 VIRT_ADDR_VARIES behavior.
5820 (PURE_POINTER_P): Use a single comparison, not two, for
5821 consistency with the new puresize.h.
5822 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5823 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5824 Remove VIRT_ADDR_VARIES no longer needed.
5826 2011-11-19 Eli Zaretskii <eliz@gnu.org>
5828 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5829 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5830 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5831 behave as if the cursor position were at the window margin.
5833 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5834 and the cursor position is out of bounds, behave as if the cursor
5835 position were at the window margin. (Bug#10075)
5837 2011-11-18 Chong Yidong <cyd@gnu.org>
5839 * window.c (Fwindow_combination_limit): Make first argument
5840 non-optional, since it is meaningless for live windows like the
5843 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5845 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5847 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5849 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5850 (graft_intervals_into_buffer): Simplify.
5852 2011-11-18 Eli Zaretskii <eliz@gnu.org>
5854 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5855 hash values of the two rows.
5856 (copy_row_except_pointers): Preserve the used[] arrays and the
5857 hash values of the two rows. (Bug#10035)
5858 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
5860 * xdisp.c (row_hash): New function, body extracted from
5861 compute_line_metrics.
5862 (compute_line_metrics): Call row_hash, instead of computing the
5865 * dispnew.c (verify_row_hash): Call row_hash for computing the
5866 hash code of a row, instead of duplicating code from xdisp.c.
5868 * dispextern.h (row_hash): Add prototype.
5870 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5872 * frame.c (delete_frame): Don't delete the terminal when the last
5873 X frame is closed if emacs is built with GTK toolkit.
5875 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
5877 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5879 2011-11-17 Martin Rudalics <rudalics@gmx.at>
5881 * window.c (Vwindow_splits): Rename to
5882 Vwindow_combination_resize. Suggested by Juri Linkov.
5883 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5886 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
5888 * nsfns.m (Fns_font_name):
5889 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
5891 2011-11-16 Martin Rudalics <rudalics@gmx.at>
5893 * window.h (window): Rename slot "nest" to "combination_limit".
5894 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5895 (Fset_window_nest): Rename to Fset_window_combination_limit.
5896 (Vwindow_nest): Rename to Vwindow_combination_limit.
5897 (recombine_windows, make_parent_window, make_window)
5898 (Fsplit_window_internal, saved_window)
5899 (Fset_window_configuration, save_window_save): Rename all
5900 occurrences of window_nest to window_combination_limit.
5902 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
5904 * image.c (imagemagick_load_image): Fix typo.
5906 2011-11-14 Eli Zaretskii <eliz@gnu.org>
5908 * xdisp.c (display_line): Move the call to
5909 highlight_trailing_whitespace before the call to
5910 compute_line_metrics, since the latter needs to see the final
5911 faces of all the glyphs to compute ROW's hash value.
5912 Fixes assertion violations in row_equal_p. (Bug#10035)
5914 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
5916 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5917 just return (bug#10044).
5919 2011-11-12 Eli Zaretskii <eliz@gnu.org>
5921 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5922 with user-defined heap size. Bump the default size of the temacs
5923 heap to 27MB, to avoid memory warning when running temacs.
5924 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5926 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5927 current_matrix and desired_matrix. (Bug#9990)
5928 (verify_row_hash) [XASSERTS]: New function.
5929 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5930 that the hash value of glyph rows is correct.
5932 2011-11-12 Martin Rudalics <rudalics@gmx.at>
5934 * window.h (window): Remove splits slot.
5935 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5936 (Fdelete_other_windows_internal, make_parent_window)
5937 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5938 (Fset_window_configuration, save_window_save): Don't deal with
5939 split status of windows.
5940 (saved_window): Remove splits slot.
5941 (Vwindow_splits): Rewrite doc-string.
5943 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5945 * xfns.c (unwind_create_frame):
5946 * nsfns.m (unwind_create_frame):
5947 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5948 Vframe_list (Bug#9999).
5950 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5952 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
5954 2011-11-11 Kenichi Handa <handa@m17n.org>
5956 * callproc.c (Fcall_process): Set the member dst_multibyte of
5959 2011-11-11 Johan Bockgård <bojohan@gnu.org>
5961 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5962 avoid a crash (bug#9496).
5964 2011-11-09 Chong Yidong <cyd@gnu.org>
5966 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5967 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5969 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5971 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5973 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5975 Avoid some portability problems by eschewing 'extern inline' functions.
5976 The trivial performance wins aren't worth the portability hassles; see
5977 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5979 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5980 (window_box_width, window_box_left, window_box_left_offset)
5981 (window_box_right, window_box_right_offset): Undo previous change,
5982 by removing the "extern"s.
5983 * intervals.c (adjust_intervals_for_insertion)
5984 (adjust_intervals_for_deletion): Undo previous change,
5985 making these static again.
5986 (offset_intervals, temp_set_point_both, temp_set_point)
5987 (copy_intervals_to_string): No longer inline.
5988 * xdisp.c (window_text_bottom_y, window_box_width)
5989 (window_box_height, window_box_left_offset)
5990 (window_box_right_offset, window_box_left, window_box_right)
5991 (window_box): No longer inline.
5993 2011-11-08 Chong Yidong <cyd@gnu.org>
5995 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
5996 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5997 Signal an error if not a live window.
5998 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5999 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6001 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
6003 * lisp.h (syms_of_abbrev): Remove declaration.
6004 Reported by CHENG Gao <chenggao@royau.me>.
6006 2011-11-07 Eli Zaretskii <eliz@gnu.org>
6008 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6009 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6010 of temacs in GUI mode.
6012 2011-11-07 Martin Rudalics <rudalics@gmx.at>
6014 * window.h: Declare delete_all_child_windows instead of
6015 delete_all_subwindows.
6016 * window.c (Fwindow_nest, Fset_window_nest)
6017 (Fset_window_new_total, Fset_window_new_normal)
6018 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6019 (delete_all_subwindows): Rename to delete_all_child_windows.
6020 (Fdelete_other_windows_internal, Fset_window_configuration):
6021 Call delete_all_child_windows instead of delete_all_subwindows.
6022 * frame.c (delete_frame): Call delete_all_child_windows instead
6023 of delete_all_subwindows.
6025 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6027 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6028 This is also needed for porting to any host where GC_MARK_STACK is
6029 not GC_MAKE_GCPROS_NOOPS.
6030 (which_symbols): Use it.
6032 2011-11-07 Kenichi Handa <handa@m17n.org>
6034 * coding.c (coding_set_destination): Check coding->src_pos only
6035 when coding->src_object is a buffer (bug#9910).
6037 * process.c (send_process): Set the member src_multibyte of coding
6038 to 0 (bug#9911) when sending a unibyte text.
6040 * callproc.c (Fcall_process): Set the member src_multibyte of
6041 process_coding to 0 (bug#9912).
6043 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6045 * xmenu.c (cleanup_widget_value_tree): New function.
6046 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6047 calling free_menubar_widget_value_tree directly (Bug#9830).
6049 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6051 Fix some portability problems with 'inline'.
6052 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6053 (window_box_width, window_box_left, window_box_left_offset)
6054 (window_box_right, window_box_right_offset): Declare extern.
6055 Otherwise, these inline functions do not conform to C99 and
6056 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6057 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6058 * intervals.c (adjust_intervals_for_insertion)
6059 (adjust_intervals_for_deletion): Now extern, because otherwise the
6060 extern inline functions 'offset_intervals' couldn't refer to it.
6061 (static_offset_intervals): Remove.
6062 (offset_intervals): Rewrite using the old contents of
6063 static_offset_intervals. The old version didn't conform to C99
6064 because an extern inline function contained a reference to an
6065 identifier with static linkage.
6067 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6069 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6072 2011-11-06 Eli Zaretskii <eliz@gnu.org>
6074 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6075 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6076 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6077 return Qleft_to_right.
6079 2011-11-06 Chong Yidong <cyd@gnu.org>
6081 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6082 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6083 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6084 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6085 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6086 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6087 (Fwindow_vscroll): Doc fix.
6088 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6089 argument, since it makes no sense to pass a live window and for
6090 consistency with window-child.
6092 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6094 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6097 2011-11-05 Jason Rumney <jasonr@gnu.org>
6099 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6100 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6102 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6103 bitwise arithmetic preventing use of unicode-sip and non-truetype
6106 2011-11-05 Eli Zaretskii <eliz@gnu.org>
6108 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6111 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6112 initialization code to keep similarity to xfns.c after changes
6115 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6117 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6118 (unwind_create_frame): New function (Bug#9943).
6119 (Fx_create_frame): Restructure code to be more similar to the one in
6120 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6121 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6122 Move terminal->reference_count++ just before making the frame official
6125 * nsterm.m (x_free_frame_resources): New function.
6126 (x_destroy_window): Move code to x_free_frame_resources.
6128 * xfns.c (unwind_create_frame): Fix comment.
6129 (Fx_create_frame, x_create_tip_frame):
6130 Move terminal->reference_count++ just before making the frame
6131 official. Move initialization of image_cache_refcount and
6132 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6134 2011-11-05 Eli Zaretskii <eliz@gnu.org>
6136 Support MSVC build with newer versions of Visual Studio.
6137 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6138 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6141 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6142 which are not supported by MSVC.
6143 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6144 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6146 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6148 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6150 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6152 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
6154 Support MSVC build with newer versions of Visual Studio.
6155 * w32.c: Don't include w32api.h for MSVC.
6156 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6158 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6159 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6160 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6161 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6163 (alloca) [_MSC_VER]: Define to _alloca.
6165 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6167 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6169 2011-11-04 Eli Zaretskii <eliz@gnu.org>
6171 * xdisp.c (note_mouse_highlight): If either of
6172 previous/next-single-property-change returns nil, treat that as
6173 the beginning or the end of the buffer. (Bug#9955)
6175 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6177 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
6178 label is not null (Bug#9951).
6179 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6182 2011-11-04 Eli Zaretskii <eliz@gnu.org>
6184 * window.c (Fwindow_body_size): Mention in the doc string that the
6185 return value is in frame's canonical units. (Bug#9949)
6187 2011-11-03 Eli Zaretskii <eliz@gnu.org>
6189 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6191 * w32fns.c (unwind_create_frame): If needed, free the glyph
6192 matrices of the partially constructed frame. (Bug#9943)
6193 * xfns.c (unwind_create_frame): Likewise.
6195 2011-11-01 Eli Zaretskii <eliz@gnu.org>
6197 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6198 Don't stop backward scan on the continuation glyph, even though
6199 its CHARPOS is positive.
6200 (mouse_face_from_buffer_pos, note_mouse_highlight):
6201 Rename cover_string to disp_string.
6203 2011-11-01 Martin Rudalics <rudalics@gmx.at>
6205 * window.c (temp_output_buffer_show): Don't use
6206 Vtemp_buffer_show_specifiers.
6207 (Vtemp_buffer_show_specifiers): Remove unused variable.
6209 2011-10-30 Eli Zaretskii <eliz@gnu.org>
6211 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6212 past the beginning of the current glyph matrix.
6214 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6216 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6217 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6218 HAVE_GTK3 (Bug#9869).
6220 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6221 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6223 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6225 * xterm.c: Declare x_handle_net_wm_state to return int.
6226 (handle_one_xevent): Check if we are iconified but don't have
6227 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6228 (get_current_wm_state): Return non-zero if not hidden,
6229 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6230 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6231 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6232 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6234 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6236 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6237 so that this new function doesn't get optimized away by a
6238 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6240 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6242 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6244 2011-10-29 Eli Zaretskii <eliz@gnu.org>
6246 Fix the `xbytecode' command.
6247 * .gdbinit (xprintbytestr): New command.
6248 (xwhichsymbols): Rename from `which'; all callers changed.
6249 (xbytecode): Print the byte-code string as well.
6251 2011-10-29 Kim Storm <storm@cua.dk>
6253 * alloc.c (which_symbols): New function.
6255 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6257 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6260 2011-10-29 Glenn Morris <rgm@gnu.org>
6262 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6263 Not clear what it was for, and it causes various bugs. (Bug#9839)
6265 2011-10-28 Eli Zaretskii <eliz@gnu.org>
6267 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6268 possible random value that matches one of those tested as
6269 condition to clear the mouse face.
6271 2011-10-28 Chong Yidong <cyd@gnu.org>
6273 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6275 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6277 * window.c (make_window): Initialize phys_cursor_on_p.
6279 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6281 * lisp.h (struct Lisp_Symbol): Update comments.
6283 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
6285 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6287 2011-10-28 Eli Zaretskii <eliz@gnu.org>
6289 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6290 <oslsachem@gmail.com> for helping to debug this.
6292 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6293 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6294 (g_b_init_get_glyph_outline_w): New static variables.
6295 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6296 (GetGlyphOutlineW_Proc): New typedefs.
6297 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
6298 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6300 (w32font_open_internal, compute_metrics):
6301 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
6302 instead of calling the "wide" APIs directly.
6304 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6306 * w32.h (syms_of_w32font): Add prototype.
6308 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
6310 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6311 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6312 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6313 (Fmove_to_window_line): Doc fix.
6315 2011-10-27 Chong Yidong <cyd@gnu.org>
6317 * process.c (make_process): Set gnutls_state to NULL.
6319 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6320 non-NULL, regardless of GNUTLS_INITSTAGE.
6321 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6322 an error. Set process slots as soon as we allocate them.
6324 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6326 2011-10-27 Chong Yidong <cyd@gnu.org>
6328 * gnutls.c (emacs_gnutls_deinit): New function.
6329 Deallocate credentials structures as well as calling gnutls_deinit.
6330 (Fgnutls_deinit, Fgnutls_boot): Use it.
6332 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6333 (deactivate_process): Call emacs_gnutls_deinit.
6335 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
6337 * image.c (x_create_x_image_and_pixmap):
6338 * w32.c (sys_rename, w32_delayed_load):
6339 * w32font.c (fill_in_logfont):
6340 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6342 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
6344 * w32fns.c (w32_default_color_map): New function,
6345 extracted from Fw32_default_color_map.
6346 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
6348 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6350 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6352 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6354 * keyboard.c (test_undefined): New function (bug#9751).
6355 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6357 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6359 * sysdep.c (init_sys_modes): Fix the check for the controlling
6360 terminal (Bug#6649).
6362 2011-10-20 Eli Zaretskii <eliz@gnu.org>
6364 * dispextern.h (struct bidi_it): New member next_en_type.
6366 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6367 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6368 current character, check also for next_en_type being WEAK_EN.
6369 (bidi_resolve_weak): Don't enter the expensive loop if the current
6370 position is before next_en_pos. Record the bidi type of the first
6371 non-ET, non-BN character we find, in addition to its position.
6372 (bidi_level_of_next_char): Invalidate next_en_type when
6373 next_en_pos is over-stepped.
6375 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6377 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6378 * editfns.c: Rewrite current-time-zone so that it invokes
6379 the equivalent of (format-time-string "%Z") to get the time zone name.
6380 This fixes a bug when the time zone name contains characters that
6381 need converting from the system time locale to Emacs internal format.
6382 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6383 that patch fixed format-time-string to do the conversion, but
6384 I forgot to fix current-time-zone.
6385 (format_time_string): New function, containing most of
6386 what Fformat_time_string used to contain.
6387 (Fformat_time_string): Rewrite in terms of format_time_string.
6388 This doesn't change this function's behavior.
6389 (current-time-zone): Rewrite to use format_time_string.
6390 This fixes the bug reported by Michael Schierl in
6391 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6392 Jason Rumney's 2007-06-07 change worked around this bug, but
6394 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6396 2011-10-19 Eli Zaretskii <eliz@gnu.org>
6398 * xdisp.c (start_display): If the character at POS is displayed
6399 via a display vector, reset IT->current.dpvec_index to zero.
6400 (try_window_reusing_current_matrix): If a line ends in a display
6401 vector or the next line starts in a display vector, continue
6402 redrawing the window even though the character position of
6403 start_row was reached.
6406 2011-10-18 Chong Yidong <cyd@gnu.org>
6408 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6409 with nobreak-char-display too.
6411 2011-10-18 Eli Zaretskii <eliz@gnu.org>
6413 Fix part 3 of bug#9771.
6414 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6415 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6416 non-neutral characters if the current character is a paragraph
6417 separator (a.k.a. Newline). This avoids running the same
6418 expensive loop twice, once when we consume the preceding newline
6419 and the other time when the line actually needs to be displayed.
6420 Avoid the loop when we see neutrals on the base embedding level
6421 following a character whose directionality is the same as the
6422 paragraph's. This avoids running the expensive loop when a line
6423 ends in a long sequence of neutrals, like control characters.
6424 Add assertion against STRONG_AL type. Slightly rearrange code
6425 that determines the type of a neutral given the first non-neutral
6427 (bidi_level_of_next_char): Set next_en_pos to zero when
6428 invalidating its info.
6430 2011-10-17 Eli Zaretskii <eliz@gnu.org>
6432 * xdisp.c (push_display_prop): Determine whether to record string
6433 or buffer position by IT->string, not by IT->method. Allow
6434 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
6435 (move_it_vertically_backward): Don't look for character position
6436 immediately after the newline when in a continuation line.
6439 2011-10-15 Martin Rudalics <rudalics@gmx.at>
6441 * window.c (coordinates_in_window): Rewrite and delabelize
6442 vertical border check. (Bug#5357) (Bug#9618)
6444 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6446 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6447 errors in XSetWindowBorder (bug#9310).
6449 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6451 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6452 avoid crash when xmalloc overrun checking is enabled.
6454 2011-10-13 Eli Zaretskii <eliz@gnu.org>
6456 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6457 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6458 cursor motion with <left> and <right> arrow keys.
6460 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6461 some callers set that themselves.
6463 2011-10-12 Eli Zaretskii <eliz@gnu.org>
6465 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6466 display string and the previous row comes from the same string and
6467 is empty. (Bug#9739) (Bug#9738)
6469 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6471 * doc.c (get_doc_string): Encode file name (bug#9735).
6473 2011-10-12 Eli Zaretskii <eliz@gnu.org>
6475 * bidi.c (bidi_level_of_next_char):
6476 * xdisp.c (get_visually_first_element): Remove old incorrect
6477 comments regarding the Unicode Line Separator character.
6479 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6481 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6483 * alloc.c (Fgc_status): Do not access beyond zombies array
6484 boundary if nzombies > MAX_ZOMBIES.
6485 * alloc.c (dump_zombies): Add missing format specifier.
6487 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6489 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6490 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6492 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6493 Some packages use them to denote characters with modifiers.
6495 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6497 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6498 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6499 matching a pp-number. Rename parameter var to var1.
6501 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6503 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6505 2011-10-08 Glenn Morris <rgm@gnu.org>
6507 * callint.c (Fcall_interactively): Give a more explicit error for the
6508 'c' case with a non-character input. (Bug#8479)
6510 2011-10-08 Eli Zaretskii <eliz@gnu.org>
6512 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6514 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6515 lines that are hscrolled on the left.
6517 * dispnew.c (buffer_posn_from_coords): Account for a possible
6518 presence of header-line. (Bug#4426)
6520 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6522 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6523 Don't advertise functionality which we discourage or doesn't work.
6525 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6527 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6528 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6529 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6530 this makes Emacs dump core during garbage collection on rare
6531 occasions. sizeof is obviously inferior to offsetof here, so
6532 stick with offsetof.
6533 (GC_POINTER_ALIGNMENT): New macro.
6534 (mark_memory): Omit 3rd (offset) arg; caller changed.
6535 Don't assume EMACS_INT alignment is the same as pointer alignment.
6537 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6539 * keyboard.c (read_key_sequence_remapped): New var.
6540 (read_key_sequence): Compute remapping in the right buffer.
6541 (command_loop_1): Use read_key_sequence's remapping directly.
6543 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6545 * dired.c (file_name_completion): Don't expand file name.
6546 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6547 before checking file name handler.
6549 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6550 they've been requested explicitly (bug#9591).
6552 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
6554 * keymap.c (Fsingle_key_description): Use make_specified_string
6555 instead of build_string to build string from push_key_description.
6558 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6560 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6561 This fixes a Y2038 bug on 64-bit hosts.
6562 * buffer.c (reset_buffer):
6563 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6564 (Fclear_buffer_auto_save_failure):
6565 Use 0, not -1, to represent an unset failure time, since time_t
6566 might not be signed.
6568 Remove dependency on glibc malloc internals.
6569 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6570 Move back here from lisp.h, but with their new implementations.
6571 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6572 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6573 * charset.c (charset_table_init): New static var.
6574 (syms_of_charset): Use it instead of xmalloc. This removes a
6575 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6576 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6577 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6578 Move back to alloc.c.
6579 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6580 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6582 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6584 * nsterm.m (windowDidResize): Call x_set_window_size only when
6585 ns_in_resize is true. Otherwise set pixelwidth/height and
6586 call change_frame_size (Bug#9628).
6588 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6590 Port --enable-checking=all to Fedora 14 x86-64.
6591 * charset.c (syms_of_charset): Also account for glibc malloc's
6592 internal overhead when calculating the initial malloc maximum.
6594 Port --enable-checking=all to Fedora 14 x86.
6595 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6597 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6598 (overrun_check_realloc, overrun_check_free):
6599 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6600 That way, xmalloc returns a properly-aligned pointer even if
6601 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6602 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6603 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6604 into account when calculating the initial malloc maximum.
6605 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6606 Move here from alloc.c, so that charset.c can use it too.
6607 Properly align; the old code wasn't right for common 32-bit hosts
6608 when configured with --enable-checking=all.
6609 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6610 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6612 2011-09-29 Eli Zaretskii <eliz@gnu.org>
6614 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
6617 2011-09-28 Eli Zaretskii <eliz@gnu.org>
6619 * xdisp.c (compute_display_string_end): If there's no display
6620 string at CHARPOS, return -1.
6622 * bidi.c (bidi_fetch_char): When compute_display_string_end
6623 returns a negative value, treat the character as a normal
6624 character not covered by a display string. (Bug#9624)
6626 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
6628 * lread.c (Fread_from_string): Fix typo in docstring.
6630 2011-09-27 Eli Zaretskii <eliz@gnu.org>
6632 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6633 newline, reseat the iterator instead of bidi-iterating there one
6634 character at a time. (Bug#9610)
6635 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6636 TO_CHARPOS if the bidi iterator is at base embedding level.
6638 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6640 * lread.c (readevalloop): Use correct code for NBSP.
6641 (read1): Likewise. (Bug#9608)
6643 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
6645 * dbusbind.c (Fdbus_register_signal): When service is not
6646 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6648 2011-09-25 Glenn Morris <rgm@gnu.org>
6650 * buffer.c (truncate-lines): Doc fix.
6652 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
6654 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6655 (Fset_window_next_buffers): Doc fix.
6657 2011-09-24 Glenn Morris <rgm@gnu.org>
6659 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6661 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6663 Fix minor problems found by static checking.
6664 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
6665 * indent.c (Fvertical_motion): Fix == vs = typo.
6667 2011-09-24 Eli Zaretskii <eliz@gnu.org>
6669 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6670 Default value is now t. Doc fix.
6672 * indent.c (Fvertical_motion): Compute and apply the overshoot
6673 logic when moving up, not only when moving down. Fix the
6674 confusing name and values of the it_overshoot_expected variable;
6675 logic changes accordingly. (Bug#9254) (Bug#9549)
6677 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6678 CHARPOS is covered by a display string which includes newlines.
6679 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6680 is covered by a display string with embedded newlines.
6682 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
6684 * dbusbind.c (Fdbus_register_signal): Add match rule to
6685 Vdbus_registered_objects_table. (Bug#9581)
6686 (Fdbus_register_method, Vdbus_registered_objects_table):
6689 2011-09-24 Jim Meyering <meyering@redhat.com>
6691 do not ignore write error for any output size
6692 The previous change was incomplete.
6693 While it makes emacs --batch detect the vast majority of stdout
6694 write failures, errors were still ignored whenever the output size is
6695 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6696 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6697 && echo FAIL: ignored write error
6698 FAIL: ignored write error
6699 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6700 && echo FAIL: ignored write error
6701 FAIL: ignored write error
6702 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6704 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6706 * emacs.c (Fkill_emacs): In noninteractive mode exit
6707 non-successfully if a write error occurred on stdout. (Bug#9574)
6709 2011-09-21 Eli Zaretskii <eliz@gnu.org>
6711 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6714 * dispextern.h (struct it): Update the comment documenting what
6717 2011-09-20 Eli Zaretskii <eliz@gnu.org>
6719 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6720 a display string, extend search for cursor position to end of row.
6721 (find_row_edges): If the row ends in a newline from a display
6722 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6723 Handle the case of a display string with multiple newlines.
6724 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6725 non-empty line. Fixes confusing cursor motion with arrow keys at
6726 the beginning of a line that starts with whitespace.
6728 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6730 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6733 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
6735 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6738 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6740 * xdisp.c (display_line): Record maximum and minimum buffer
6741 positions even if no glyphs were produced (e.g., by a zero-width
6742 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6743 buffer positions that will be removed from the glyph row because
6745 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6746 column is beyond frame width: don't subtract 1 "pixel" when
6747 computing width of the stretch.
6748 (reseat_at_next_visible_line_start): Undo the change made on
6749 2011-09-17 that saved paragraph information and restored it after
6750 the call to `reseat'. (Bug#9545)
6752 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6754 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6755 and turn window cursor on if cleared (Bug#9415).
6757 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
6759 * search.c (boyer_moore): Take unibyte characters from pattern
6760 literally. (Bug#9458)
6762 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6764 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6766 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6768 Fix minor problem found by static checking.
6769 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6770 initialized, to pacify gcc -Wuninitialized.
6772 * fileio.c: Report proper errno when syscall falls.
6773 (Finsert_file_contents): Save and restore errno,
6774 so that report_file_error outputs the correct diagnostic.
6775 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6777 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6779 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6781 2011-09-17 Eli Zaretskii <eliz@gnu.org>
6783 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6784 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6786 2011-09-17 Eli Zaretskii <eliz@gnu.org>
6788 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6789 about the current paragraph and restore it after the call to reseat.
6791 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6792 (bidi_find_paragraph_start): Search back for paragraph beginning
6793 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6794 (bidi_move_to_visually_next): Only trigger paragraph-related
6795 computations when the last character is a newline or at EOB, not
6796 just any NEUTRAL_B. (Bug#9470)
6798 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6799 truncated lines if point is covered by a display string. (Bug#9524)
6801 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6803 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6804 (cons_to_x_long): New function.
6805 (lisp_data_to_selection_data): Use it. Correct the test for
6806 short-versus-long data; it was negated. Break out of vector
6807 loop, for efficiency, when a long datum is discovered.
6809 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6811 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6813 2011-09-16 Eli Zaretskii <eliz@gnu.org>
6815 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6816 GCC PR/17406) by declaring this function with external scope.
6818 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6820 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6821 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6823 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6825 * editfns.c (Fformat): Correctly handle text properties on "%%".
6827 2011-09-15 Eli Zaretskii <eliz@gnu.org>
6829 * xterm.c (x_draw_composite_glyph_string_foreground):
6830 * w32term.c (x_draw_composite_glyph_string_foreground):
6831 * term.c (encode_terminal_code):
6832 * composite.c (composition_update_it, get_composition_id):
6833 * xdisp.c (get_next_display_element)
6834 (fill_composite_glyph_string): Add comments about special meaning
6835 of TAB characters in a composition.
6837 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6839 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
6840 This occurs when processing a multibyte format.
6841 Problem reported by Wolfgang Jenker.
6843 2011-09-15 Johan Bockgård <bojohan@gnu.org>
6845 * xdisp.c (try_cursor_movement): Only check for exact match if
6846 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6848 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6850 Remove unused external symbols.
6851 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6852 * xdisp.c (calc_pixel_width_or_height): Now static.
6853 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6854 * indent.c (check_display_width):
6855 * w32term.c: Fix comment to match code.
6856 * xterm.c, xterm.h (x_catching_errors): Remove.
6858 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6860 * xselect.c: Use signed conversions more consistently (Bug#9498).
6861 (selection_data_to_lisp_data): Assume incoming selection data are
6862 signed integers, not unsigned. This is to be consistent with
6863 outgoing selection data, which was modified to use signed integers
6864 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6865 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6866 expects long, not unsigned long.
6868 2011-09-14 Eli Zaretskii <eliz@gnu.org>
6870 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6871 computation of loop end. Reported by Johan Bockgård
6874 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
6876 * frame.c (Fother_visible_frames_p): Function deleted.
6878 2011-09-12 Eli Zaretskii <eliz@gnu.org>
6880 * indent.c (compute_motion): Process display vector front to back
6881 rather than the other way around. (Bug#2496)
6883 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6885 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6887 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
6889 * minibuf.c (Fread_from_minibuffer): Doc fix.
6891 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6893 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6894 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6896 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6898 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6899 value for non-existent files.
6901 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6903 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6904 set its "size" to -1. This will set the modtime_size field of
6905 the corresponding buffer to -1, which is what
6906 verify-visited-file-modtime expects for files that do not exist.
6909 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6911 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6913 * lisp.h: ... from here. push_key_description is no longer
6914 defined in keyboard.c, so its declaration should not be in
6915 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6916 logically belongs with push_key_description.
6918 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6920 * buffer.h: Include <sys/types.h> instead of <time.h>.
6921 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6922 Problem reported by Herbert J. Skuhra.
6924 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6926 * xml.c (parse_region): Make the parsing work for
6927 non-comment-starting XML files again (bug#9144).
6929 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6931 * image.c (gif_load): Fix calculation of bottom and right corner.
6934 2011-09-10 Eli Zaretskii <eliz@gnu.org>
6936 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6937 redisplay in small windows.
6939 2011-09-09 Eli Zaretskii <eliz@gnu.org>
6941 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6943 2011-09-08 Martin Rudalics <rudalics@gmx.at>
6945 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6946 Operate on live windows only.
6948 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
6950 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6952 2011-09-07 Eli Zaretskii <eliz@gnu.org>
6954 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6955 only under bidi iteration.
6957 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6959 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6961 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6963 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6964 Without this fix, the command to link temacs failed due to an
6965 undefined symbol __builtin_isnan. This is because
6966 /usr/include/iso/math_c99.h #defines isnan(x) to
6967 __builtin_isnan(x), but the bundled gcc, which identifies itself
6968 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6970 * floatfns.c (isnan): #undef, and then #define to a clone of
6972 (Fisnan): Always define, since it's always available now.
6973 (syms_of_floatfns): Always define isnan at the Lisp level.
6975 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6977 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6979 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6981 * fileio.c: Fix bugs with large file offsets (Bug#9428).
6982 The previous code assumed that file offsets (off_t values) fit in
6983 EMACS_INT variables, which is not true on typical 32-bit hosts.
6984 The code messed up by falsely reporting buffer overflow in cases
6985 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6986 when "big" contains more than 2**29 bytes, even though this
6987 inserts just one byte and does not overflow the buffer.
6988 (Finsert_file_contents): Store file offsets as off_t
6989 values, not as EMACS_INT values. Check for overflow when
6990 converting between EMACS_INT and off_t. When checking for
6991 buffer overflow or for overlap, take the offsets into account.
6992 Don't use EMACS_INT for small values where int suffices.
6993 When checking for overlap, fix a typo: ZV was used where
6994 ZV_BYTE was intended.
6995 (Fwrite_region): Don't assume off_t fits into 'long'.
6996 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6998 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
7000 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7002 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7004 sprintf-related integer and memory overflow issues (Bug#9412).
7006 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
7007 (esprintf, exprintf, evxprintf): New functions.
7008 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
7009 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
7010 (modify_event_symbol): Do not assume that the length of
7011 name_alist_or_stem is safe to alloca and fits in int.
7012 (Fexecute_extended_command): Likewise for function name and binding.
7013 (Frecursion_depth): Wrap around reliably on integer overflow.
7014 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7015 since some callers pass EMACS_INT values.
7016 (Fsingle_key_description): Don't crash if symbol name contains more
7017 than MAX_ALLOCA bytes.
7018 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7019 (get_minibuffer): Arg is now EMACS_INT, not int.
7020 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
7021 (esprintf, exprintf, evxprintf): New decls.
7022 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7024 * dbusbind.c (signature_cat): New function.
7025 (xd_signature, Fdbus_register_signal):
7026 Do not overrun buffer; instead, report string overflow.
7028 * dispnew.c (add_window_display_history): Don't overrun buffer.
7029 Truncate instead; this is OK since it's just a log.
7031 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7032 even if the time zone offset is outlandishly large.
7033 Don't mishandle offset == INT_MIN.
7035 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7036 when creating daemon; the previous buffer-overflow check was incorrect.
7038 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7039 which has the guts of the old verror function.
7041 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7042 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7044 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7045 (font_unparse_xlfd): Don't blindly alloca long strings.
7046 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
7047 fits in int, when using sprintf. Use single snprintf to count
7048 length of string rather than counting it via multiple sprintfs;
7049 that's simpler and more reliable.
7050 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7051 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7052 sprintf, in case result does not fit in int.
7054 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7055 (fontset_from_font): Print it.
7057 * frame.c (tty_frame_count): Now printmax_t, not int.
7058 (make_terminal_frame, set_term_frame_name): Print it.
7059 (x_report_frame_params): In X, window IDs are unsigned long,
7060 not signed long, so print them as unsigned.
7061 (validate_x_resource_name): Check for implausibly long names,
7062 and don't assume name length fits in 'int'.
7063 (x_get_resource_string): Don't blindly alloca invocation name;
7064 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7067 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7068 (xg_check_special_colors, xg_set_geometry):
7069 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7071 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7072 Use esprintf, not sprintf, in case result does not fit in int.
7074 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7075 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7076 it as a large positive number.
7077 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7078 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7080 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7081 in case result does not fit in int.
7083 * print.c (float_to_string): Detect width overflow more reliably.
7084 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7085 buffer overrun. Don't assume list length fits in 'int'. Treat
7086 print length of 0 as 0, not as infinity; to be consistent with other
7087 uses of print length in this function. Don't overflow print length
7088 index. Don't assume hash table size fits in 'long', or that
7089 vectorlike size fits in 'unsigned long'.
7091 * process.c (make_process): Use printmax_t, not int, to format
7092 process-name gensyms.
7094 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7096 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7097 to avoid potential buffer overrun.
7099 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7100 if X resource line is longer than 512 bytes.
7102 * xfns.c (x_window): Make sprintf buffer a bit bigger
7103 to avoid potential buffer overrun.
7105 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7107 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7109 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7111 Integer overflow fixes for scrolling, etc.
7112 Without these, Emacs silently mishandles large integers sometimes.
7113 For example, "C-u 4294967297 M-x recenter" was treated as if
7114 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7116 * xdisp.c (try_window_id): Check Emacs fixnum range before
7117 converting to 'int'.
7119 * window.c (window_scroll_line_based, Frecenter):
7120 Check that an Emacs fixnum is in range before assigning it to 'int'.
7121 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7122 values converted from Emacs fixnums.
7123 (Frecenter): Don't wrap around a line count if it is out of 'int'
7124 range; instead, treat it as an extreme value.
7125 (Fset_window_configuration, compare_window_configurations):
7126 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7128 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7129 that can exceed INT_MAX. Check that EMACS_INT value is in range
7130 before assigning it to the (possibly-narrower) index.
7131 (match_limit): Don't assume that a fixnum can fit in 'int'.
7133 * print.c (print_object): Use ptrdiff_t, not int, for index that can
7136 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
7137 (Fvertical_motion): Don't wrap around LINES values that don't fit
7138 in 'int'. Instead, treat them as extreme values. This is good
7139 enough for windows, which can't have more than INT_MAX lines anyway.
7141 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7143 * Require libxml/parser.h to avoid compilation warning.
7145 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7147 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7148 since this reportedly can destroy thread storage.
7150 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
7152 * syntax.c (find_defun_start): Update all cache variables if
7153 exiting early (Bug#9401).
7155 2011-08-30 Eli Zaretskii <eliz@gnu.org>
7157 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7159 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7160 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7161 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7163 * term.c (tty_append_glyph): New function.
7164 (produce_stretch_glyph): Static function and its prototype deleted.
7166 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7169 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7171 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7172 when checking :margin (Bug#9390).
7173 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
7174 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
7175 so that the name doesn't mislead. All uses changed.
7177 2011-08-28 Johan Bockgård <bojohan@gnu.org>
7179 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7182 2011-08-27 Eli Zaretskii <eliz@gnu.org>
7184 * xdisp.c (move_it_to): Don't bail out early when reaching
7185 position beyond to_charpos, if we are scanning backwards.
7186 (move_it_vertically_backward): When DY == 0, make sure we get to
7187 the first character in the line after the newline.
7189 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7191 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7192 (ccl_driver): Do not generate an out-of-range pointer.
7193 (Fccl_execute_on_string): Remove unnecessary check for
7194 integer overflow, noted by Stefan Monnier in
7195 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7196 Remove a FIXME that didn't need fixing.
7197 Simplify the newly-introduced buffer reallocation code.
7199 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
7201 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7203 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
7205 Integer and memory overflow issues (Bug#9196).
7207 * doc.c (get_doc_string): Rework so that
7208 get_doc_string_buffer_size is the actual buffer size, rather than
7209 being 1 less than the actual buffer size; this makes xpalloc more
7212 * image.c (x_allocate_bitmap_record, cache_image):
7213 * xselect.c (Fx_register_dnd_atom):
7214 Simplify previous changes by using xpalloc.
7216 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7217 since either will do and ptrdiff_t is convenient with xpalloc.
7219 * charset.c (charset_table_size)
7220 (struct charset_sort_data.priority): Now ptrdiff_t.
7221 (charset_compare): Don't overflow if priorities differ greatly.
7222 (Fsort_charsets): Don't assume list length fits in int.
7223 Check for size-calculation overflow when allocating sort data.
7224 (syms_of_charset): Allocate an initial charset table that is
7225 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7227 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7229 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7230 The actual value is always <= INT_MAX, and leaving it unsigned made
7231 overflow checking harder.
7233 * dispextern.h (struct glyph_matrix.rows_allocated)
7234 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7235 with xpalloc. The values are still always <= INT_MAX.
7237 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7239 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7240 (SAFE_NALLOCA): New macro.
7242 * region-cache.c (struct boundary.pos, find_cache_boundary)
7243 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7244 (set_cache_region, invalidate_region_cache)
7245 (revalidate_region_cache, know_region_cache, region_cache_forward)
7246 (region_cache_backward, pp_cache):
7247 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7248 so that ptrdiff_t * can be passed to xpalloc.
7249 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7250 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7251 (pp_cache): Don't assume cache_len fits in int.
7252 * region-cache.h: Adjust extern decls to match.
7254 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7255 EMACS_INT, since either will do, for xpalloc.
7257 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7258 (xnmalloc, xnrealloc, xpalloc): New functions.
7260 * bidi.c (bidi_shelve_header_size): New constant.
7261 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7262 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7264 * bidi.c (bidi_cache_shrink):
7265 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7267 Don't update size of array until after memory allocation succeeds,
7268 because xmalloc/xrealloc may not return.
7269 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7270 now that we have proper integer overflow checking.
7271 (record_overlay_string, overlay_strings): Catch overflows when
7272 calculating size of overlay_str_buf.
7274 * callproc.c (Fcall_process): Check for size overflow when
7275 calculating size of args2.
7276 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7277 Normally we prefer signed values, but sticking with ptrdiff_t would
7278 require adding more-complicated checks.
7280 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7281 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7282 Redo buffer-overflow calculations to avoid integer overflow.
7283 Add a FIXME comment where memory seems to be over-allocated.
7285 * character.c (Fstring): Check for size-calculation overflow.
7287 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7288 unnecessary integer overflow. Check for size overflow.
7289 (encode_coding_object): Don't update size until xmalloc succeeds.
7291 * composite.c (get_composition_id): Check for overflow in glyph
7292 length calculations.
7294 Integer and memory overflow fixes for display code.
7295 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7296 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7297 (scrolling_window): Check for overflow in size calculations.
7298 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7299 Don't assume glyph table len fits in int.
7300 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7301 (row_table_size): Now ptrdiff_t, not int.
7302 (scrolling_window): Avoid overflow in size calculations.
7303 Don't update size until allocation succeeds.
7304 * fns.c (concat): Check for overflow in size calculations.
7305 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7306 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7307 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7309 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7310 (get_doc_string): Check for size calculation overflow.
7311 Don't update size until allocation succeeds.
7312 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7313 EMACS_INT, where ptrdiff_t will do.
7314 (Fsubstitute_command_keys): Check for string overflow.
7316 * editfns.c (set_time_zone_rule): Don't assume environment length
7318 (message_length): Now ptrdiff_t, not int.
7319 (Fmessage_box): Don't update size until allocation succeeds.
7320 Don't assume message length fits in int.
7321 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7323 * emacs.c (main): Do not reallocate argv, since there is a null at
7324 the end that can be overwritten, and this way there's no need to
7325 worry about size-calculation overflow.
7326 (sort_args): Check for size-calculation overflow.
7328 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7330 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7332 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7333 (x_set_scroll_bar_width, x_figure_window_size):
7334 Check for integer overflow.
7335 (x_set_alpha): Do not assume XINT fits in int.
7337 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7338 This is for the members text_lines, text_cols, total_lines, total_cols,
7339 where the system imposes an 'int' limit.
7341 * fringe.c (Fdefine_fringe_bitmap):
7342 Don't update size until alloc works.
7344 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7345 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7347 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7348 Check for size-calculation overflow.
7349 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7350 do, as we prefer signed integers.
7351 (id_to_widget.max_size, id_to_widget.used)
7352 (xg_store_widget_in_map, xg_remove_widget_from_map)
7353 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7354 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7355 Use and return ptrdiff_t, not int.
7356 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7357 * gtkutil.h: Change prototypes to match the above.
7359 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7360 are duplicate now that they've been promoted to lisp.h.
7361 (x_allocate_bitmap_record, x_alloc_image_color)
7362 (make_image_cache, cache_image, xpm_load):
7363 Don't update size until alloc is done.
7364 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7366 Check for size calculation overflow.
7367 (ct_colors_allocated_max): New constant.
7368 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7371 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7372 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7373 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7374 Use ptrdiff_t, not int, to count maps.
7375 (read_char_minibuf_menu_prompt): Check for overflow in size
7376 calculations. Don't update size until allocation succeeds.
7377 Redo calculations to avoid overflow.
7378 * keyboard.h: Change prototypes to match the above.
7380 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7382 (current_minor_maps): Check for size calculation overflow.
7383 * keymap.h: Change prototypes to match the above.
7385 * lread.c (read1, init_obarray): Don't update size until alloc done.
7387 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7388 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7390 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7391 Now ptrdiff_t, not int.
7392 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7393 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7395 * process.c (Fnetwork_interface_list): Check for overflow
7396 in size calculation.
7398 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7400 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7401 overflow. Don't bother calling xmalloc when xrealloc will do.
7403 * search.c (Freplace_match): Check for size calculation overflow.
7404 (Fset_match_data): Don't assume list lengths fit in 'int'.
7406 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7407 for command line length. Do not attempt to address one before the
7408 beginning of an array, as that's not portable.
7410 * term.c (max_frame_lines): Remove; unused.
7411 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7413 (encode_terminal_code, calculate_costs): Check for size
7414 calculation overflow.
7415 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7416 table lengths and related sizes. Don't update size until alloc
7417 done. Redo calculations to avoid overflow.
7418 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7420 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7421 subtracting pointers.
7422 (gobble_line): Check for overflow more carefully. Don't update size
7425 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7426 Don't update size until alloc done.
7427 Redo size calculations to avoid overflow.
7428 Check for size calculation overflow.
7429 (main) [DEBUG]: Fix typo in invoking tparam1.
7431 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7432 Use ptrdiff_t, not int, for sizes.
7433 (store_mode_line_noprop_char): Don't update size until alloc done.
7435 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7436 Use ptrdiff_t, not int, for sizes.
7437 (Finternal_make_lisp_face, cache_face):
7438 Check for size calculation overflow.
7439 (cache_face): Treat size calculation overflows as if they were
7440 memory exhaustion (the usual treatment), rather than aborting.
7442 * xfns.c (x_encode_text, x_set_name_internal)
7443 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7444 sizes, since they can exceed INT_MAX in size. Check for size
7445 calculation overflow.
7447 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7448 (xg_select): Check for size calculation overflow.
7449 Don't update size until alloc done.
7451 * xrdb.c (get_environ_db): Don't assume path length fits in int,
7452 as sprintf is limited to int lengths.
7454 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7455 (X_LONG_MIN): New macros.
7456 Use them to make the following changes clearer.
7457 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7458 This change doesn't affect the value now, but it may help remind
7459 future maintainers not to raise the value too much later.
7460 (SELECTION_QUANTUM): Remove, replacing with ...
7461 (selection_quantum): ... new function, which avoids overflow.
7463 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7464 assumption that selection length fits in 'int'.
7465 (x_reply_selection_request, x_handle_selection_request)
7466 (x_get_window_property, receive_incremental_selection)
7467 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7468 (lisp_data_to_selection_data, clean_local_selection_data):
7469 Use ptrdiff_t, not int, to record length of selection.
7470 (x_reply_selection_request, x_get_window_property)
7471 (receive_incremental_selection, x_property_data_to_lisp):
7472 Redo calculations to avoid overflow.
7473 (x_reply_selection_request): When sending hint, ceiling it at
7474 X_LONG_MAX rather than relying on wraparound overflow to send
7476 (x_get_window_property, receive_incremental_selection)
7477 (lisp_data_to_selection_data, x_property_data_to_lisp):
7478 Check for size-calculation overflow.
7479 (x_get_window_property, receive_incremental_selection)
7480 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7481 Don't store size until memory allocation succeeds.
7482 (x_get_window_property): Plug memory leak on memory exhaustion.
7483 Don't double-block input; malloc is safe here. Don't assume 2**34
7484 - 4 fits in unsigned long. Add an xassert to check
7485 XGetWindowProperty overflow. Be more careful about overflow
7486 calculations, and distinguish size from memory overflow better.
7487 (receive_incremental_selection): When tracing, don't assume
7488 unsigned int is less than INT_MAX.
7489 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7490 harmful) conversions of unsigned short to int.
7491 (lisp_data_to_selection_data): Don't assume that integers
7492 in the range -65535 through -1 fit in an X unsigned short.
7493 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7494 result parameters unless successful. Rely on cons_to_unsigned
7495 to report problems with elements; the old code wasn't right anyway.
7496 (x_check_property_data): Check for int overflow; we cannot use
7497 a wider type due to X limits.
7498 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7500 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
7502 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7503 (x_term_init): Check for size calculation overflow.
7504 (x_color_cells): Don't store size until memory allocation succeeds.
7505 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
7506 Don't assume alloca size is less than MAX_ALLOCA.
7507 (x_term_init): Don't assume length fits in int (sprintf is limited
7510 Use ptrdiff_t for composition IDs.
7511 * character.c (lisp_string_width):
7512 * composite.c (composition_table_size, n_compositions)
7513 (get_composition_id, composition_gstring_from_id):
7514 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7515 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7516 * window.c (Frecenter):
7517 Use ptrdiff_t, not int, for composition IDs.
7518 * composite.c (get_composition_id): Check for integer overflow.
7519 * composite.h: Adjust prototypes to match the above changes.
7521 Use ptrdiff_t for hash table indexes.
7522 * category.c (hash_get_category_set):
7523 * ccl.c (ccl_driver):
7524 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7525 * coding.c (coding_system_charset_list, detect_coding_system):
7526 * coding.h (struct coding_system.id):
7527 * composite.c (get_composition_id, gstring_lookup_cache):
7528 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7529 * image.c (xpm_get_color_table_h):
7530 * lisp.h (hash_lookup, hash_put):
7531 * minibuf.c (Ftest_completion):
7532 Use ptrdiff_t for hash table indexes, not int (which is too
7533 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7534 32-bit --with-wide-int hosts).
7536 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7537 Add a FIXME comment about memory leaks.
7538 (syms_of_charset): Don't assume xmalloc returns.
7540 Don't assume that stated character widths fit in int.
7541 * character.c (Fchar_width, c_string_width, lisp_string_width):
7542 * character.h (CHAR_WIDTH):
7543 * indent.c (MULTIBYTE_BYTES_WIDTH):
7544 Use sanitize_char_width to avoid undefined and/or bad behavior
7545 with outlandish widths.
7546 * character.h (sanitize_tab_width): Rename from sanitize_width,
7547 now that we have two such functions. All uses changed.
7548 (sanitize_char_width): New inline function.
7550 Don't assume that tab-width fits in int.
7551 * character.h (sanitize_width): New inline function.
7552 (SANE_TAB_WIDTH): New macro.
7553 (ASCII_CHAR_WIDTH): Use it.
7554 * indent.c (sane_tab_width): Remove. All uses replaced by
7555 SANE_TAB_WIDTH (current_buffer).
7556 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7558 * fileio.c: Integer overflow issues with file modes.
7559 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7561 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7562 Remove unreachable code.
7563 (read_hex, load_charset_map_from_file): Check for integer overflow.
7565 * xterm.c: Don't go over XClientMessageEvent limit.
7566 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7567 (x_send_scroll_bar_event): Likewise. Check that the size does not
7568 exceed limits imposed by XClientMessageEvent, as well as the usual
7569 ptrdiff_t and size_t limits.
7571 * keyboard.c: Overflow, signedness and related fixes.
7572 (make_lispy_movement): Use same integer type in forward decl
7573 that is used in the definition.
7574 (read_key_sequence, keyremap_step):
7575 Change bufsize argument back to int, undoing my 2011-03-30 change.
7576 We prefer signed types, and int is wide enough here.
7577 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7578 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7579 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7580 length, not size_t. Use ptrdiff_t for index, not int.
7581 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7582 possibility of integer overflow.
7584 Overflow, signedness and related fixes for images.
7586 * dispextern.h (struct it.stack[0].u.image.image_id)
7587 (struct_it.image_id, struct image.id, struct image_cache.size)
7588 (struct image_cache.used, struct image_cache.ref_count):
7589 * gtkutil.c (update_frame_tool_bar):
7590 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7591 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7592 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7593 * nsmenu.m (update_frame_tool_bar):
7594 * xdisp.c (calc_pixel_width_or_height):
7595 * xfns.c (image_cache_refcount):
7596 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7597 on typical 64-bit hosts.
7599 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7600 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7601 Omit unnecessary casts to int.
7602 (parse_image_spec): Check that integers fall into 'int' range
7603 when the callers expect that.
7604 (image_ascent): Redo ascent calculation to avoid int overflow.
7605 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7606 (lookup_image): Remove unnecessary tests.
7607 (xbm_image_p): Locals are now of int, not EMACS_INT,
7608 since parse_image_check makes sure they fit into int.
7609 (png_load, gif_load, svg_load_image):
7610 Prefer int to unsigned where either will do.
7611 (tiff_handler): New function, combining the cores of the
7612 old tiff_error_handler and tiff_warning_handler.
7613 This function is rewritten to use vsnprintf and thereby avoid
7614 stack buffer overflows. It uses only the features of vsnprintf
7615 that are common to both POSIX and native Microsoft.
7616 (tiff_error_handler, tiff_warning_handler): Use it.
7617 (tiff_load, gif_load, imagemagick_load_image):
7618 Don't assume :index value fits in 'int'.
7619 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7620 (imagemagick_load_image): Check that crop parameters fit into
7621 the integer types that MagickCropImage accepts. Don't assume
7622 Vimagemagick_render_type has a nonnegative value. Don't assume
7623 size_t fits in 'long'.
7624 (gs_load): Use printmax_t to print the widest integers possible.
7625 Check for integer overflow when computing image height and width.
7627 2011-08-26 Eli Zaretskii <eliz@gnu.org>
7629 * xdisp.c (redisplay_window): Don't force window start if point
7630 will be invisible in the resulting window. (Bug#9324)
7632 2011-08-25 Eli Zaretskii <eliz@gnu.org>
7634 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7635 the display spec is of the form `(space ...)'.
7636 (handle_display_spec): Return the value returned by
7637 handle_single_display_spec, not just 1 or zero.
7638 (handle_single_display_spec): If the display spec is of the form
7639 `(space ...)', and specifies display in the text area, return 2
7641 (try_cursor_movement): Check for the need to scroll more
7642 accurately, and prefer exact match for point under bidi.
7643 Don't advance `row' beyond the last row of the window.
7645 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7646 into disp_prop; all users changed.
7648 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7649 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7650 for the text covered by the display property.
7652 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
7654 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7655 Change return value to nil.
7656 (Frecord_buffer): Delete unused function.
7658 2011-08-24 Eli Zaretskii <eliz@gnu.org>
7660 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7661 buffers, return left-to-right.
7662 (set_cursor_from_row): Consider candidate row a win if its glyph
7663 represents a newline and point is on that newline. Fixes cursor
7664 positioning on the newline at EOL of R2L text within L2R
7665 paragraph, and vice versa.
7666 (try_cursor_movement): Check continued rows, in addition to
7667 continuation rows. Fixes unwarranted scroll when point enters a
7668 continued line of R2L text within an L2R paragraph, or vice versa.
7669 (cursor_row_p): Consider the case of point being equal to
7670 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7671 from the end of a short line to the beginning of a continued line
7672 of R2L text within L2R paragraph.
7673 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7674 composed characters.
7676 * bidi.c (bidi_check_type): Use xassert.
7677 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7680 2011-08-23 Eli Zaretskii <eliz@gnu.org>
7682 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7685 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
7687 * nsfont.m (ns_otf_to_script): Fix typo.
7689 2011-08-22 Kenichi Handa <handa@m17n.org>
7691 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7692 extra slot even if the purpose is char-code-property-table.
7694 2011-08-23 Eli Zaretskii <eliz@gnu.org>
7696 * xdisp.c (redisplay_window): When computing centering_position,
7697 account for the height of the header line. (Bug#8874)
7699 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7700 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7701 candidate is selected by the mouse, and that candidate has a
7702 composed character under the mouse.
7704 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7705 coordinates reported by pos-visible-in-window-p for a composed
7706 character in column zero.
7708 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7710 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7712 2011-08-22 Eli Zaretskii <eliz@gnu.org>
7714 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7715 consider it a hit if to_charpos is anywhere in the range of the
7716 composed buffer positions.
7718 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
7720 * image.c (gif_load): Don't assume that each subimage has the same
7721 dimensions as the base image. Handle disposal method that is
7722 "undefined" by the gif spec (Bug#9335).
7724 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
7726 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
7727 (Fcondition_case): Document `debug' symbol in error handler.
7729 2011-08-19 Eli Zaretskii <eliz@gnu.org>
7731 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7732 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7733 from an Org mode buffer to a Speedbar frame.
7735 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7736 a composition, take its buffer position from IT->cmp_it.charpos.
7737 Fixes cursor positioning at the beginning of a line that begins
7738 with a composed character.
7740 2011-08-18 Eli Zaretskii <eliz@gnu.org>
7742 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7743 character bidirectional type, use STRONG_L instead. Fixes crashes
7744 in a buffer produced by `describe-categories'.
7746 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7747 members before the level stack, so they would be saved and
7748 restored when copying iterator state. Fixes incorrect reordering
7749 around TABs covered by display properties.
7751 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7753 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
7755 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
7757 * eval.c (internal_condition_case, internal_condition_case_1)
7758 (internal_condition_case_2, internal_condition_case_n):
7759 Remove unnecessary aborts (Bug#9081).
7761 2011-08-17 Eli Zaretskii <eliz@gnu.org>
7763 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7764 has no `load' handler, try opening the file locally. (Bug#9311)
7766 2011-08-16 Ken Brown <kbrown@cornell.edu>
7768 * gmalloc.c: Expand comment.
7770 2011-08-16 Eli Zaretskii <eliz@gnu.org>
7772 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7773 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7775 2011-08-16 Ken Brown <kbrown@cornell.edu>
7777 Fix memory allocation problems in Cygwin build (Bug#9273).
7779 * unexcw.c ( __malloc_initialized): Declare external variable.
7780 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7782 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7784 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7786 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7788 [CYGWIN] (special_realloc): New function.
7789 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7790 requests to realloc storage in the static heap.
7792 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7794 * bidi.c (bidi_initialize): Remove unused local.
7796 2011-08-15 Eli Zaretskii <eliz@gnu.org>
7799 * biditype.h: Remove file.
7800 * makefile.w32-in ($(BLD)/bidi.$(O)):
7801 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
7803 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7805 * chartab.c: Improve commentary for the uniprop_table API.
7807 * bidi.c (bidi_paragraph_init): Support zero value of
7808 bidi_ignore_explicit_marks_for_paragraph_level.
7809 (bidi_initialize): Use uniprop_table instead of including
7810 biditype.h and bidimirror.h.
7812 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7813 coordinates of the iterator when restoring from ppos_it.
7816 2011-08-14 Kenichi Handa <handa@m17n.org>
7818 * process.c (create_process): Call setup_process_coding_systems
7819 after the pid of the process is set to -1 (Bug#8162).
7821 2011-08-14 Eli Zaretskii <eliz@gnu.org>
7823 * xdisp.c (move_it_in_display_line_to): Don't invoke
7824 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7825 ppos_it. Fixes vertical cursor motion when line beginning is
7826 covered by an image. (Bug#9296)
7828 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7830 * nsterm.h (ns_run_ascript): Declare.
7831 (NSAPP_DATA2_RUNASSCRIPT): Define.
7833 * nsfns.m (as_script, as_result, as_status): New static variables.
7834 (ns_run_ascript): New function.
7835 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
7836 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7837 the event loop. Get status from as_status (Bug#7276).
7839 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7840 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7841 the event loop (Bug#7276).
7843 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7845 * gnutls.c (QCgnutls_bootprop_priority)
7846 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7847 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7848 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7849 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7850 (QCgnutls_bootprop_verify_hostname_error)
7851 (QCgnutls_bootprop_callbacks_verify): Rename from
7852 Qgnutls_bootprop_..., all uses changed.
7854 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7857 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7859 * xfaces.c (Qframe_set_background_mode): Now static.
7860 * dispextern.h (Qframe_set_background_mode): Remove decl.
7862 * process.c (Fnetwork_interface_info): Declare local only if needed.
7864 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7866 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7867 (Fnetwork_interface_list): Allocate in increments of bytes instead
7868 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7869 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7871 (struct ifflag_def): notrailers is smart on OSX.
7872 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7873 Get hardware address with getifaddrs if available.
7875 2011-08-12 Eli Zaretskii <eliz@gnu.org>
7877 * xdisp.c (iterate_out_of_display_property): xassert that
7878 IT->position is set to within IT->object's boundaries. Break from
7879 the loop as soon as EOB is reached; avoids infloops in redisplay
7880 when IT->position is set up wrongly due to some bug.
7881 Set IT->current to match the bidi iterator unconditionally.
7882 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7883 entry. Force push_it to save on the stack the current
7884 buffer/string position, to be restored by pop_it. Fix flags in
7885 the iterator structure wrt the object coming from a display
7886 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7887 properties. (Bug#9284)
7889 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
7891 * fontset.c (fontset_get_font_group): Add proper type checks.
7894 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7896 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7897 and LC_VERSION_MIN_MACOSX.
7898 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7899 (dump_it) [LC_FUNCTION_STARTS]: Use it.
7901 2011-08-08 Eli Zaretskii <eliz@gnu.org>
7903 * xdisp.c (forward_to_next_line_start): Allow to use the
7904 no-display-properties-and-no-overlays under bidi display.
7905 Set disp_pos in the bidi iterator to avoid searches for display
7906 properties and overlays.
7908 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
7910 * editfns.c (Fset_time_zone_rule): Document relationship with the
7913 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7914 the font entity extracted from the cache (Bug#8109).
7916 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
7918 * composite.c (autocmp_chars): Don't reset point. That is done by
7919 restore_point_unwind (Bug#5984).
7921 2011-08-07 Juri Linkov <juri@jurta.org>
7923 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7924 to show the arg `TIME' instead of `TIMEVAL'.
7926 2011-08-06 Eli Zaretskii <eliz@gnu.org>
7928 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7929 display property strides EOL and includes a newline, as in
7930 longlines-mode. (Bug#9254)
7931 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7932 word-wrap under bidirectional display. (Bug#9224)
7934 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7935 is non-zero, even if the data buffer is NULL. Fixes a crash in
7936 vertical-motion with longlines-mode. (Bug#9254)
7938 2011-08-05 Eli Zaretskii <eliz@gnu.org>
7940 * bidi.c <bidi_cache_total_alloc>: Now static.
7941 (bidi_initialize): Initialize bidi_cache_total_alloc.
7943 * xdisp.c (display_line): Release buffer allocated for shelved bidi
7946 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7947 amount allocated this far in `bidi_cache_total_alloc'.
7948 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7949 non-zero, only free the data buffer without restoring the cache
7950 contents. All callers changed.
7952 * dispextern.h (bidi_unshelve_cache): Update prototype.
7954 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7955 (move_it_in_display_line, move_it_to)
7956 (move_it_vertically_backward, move_it_by_lines): Replace the call
7957 to xfree to an equivalent call to bidi_unshelve_cache.
7958 (move_it_in_display_line_to): Fix logic of returning
7959 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
7961 2011-08-05 Eli Zaretskii <eliz@gnu.org>
7963 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7964 came from a string character with a `cursor' property. (Bug#9229)
7966 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7968 * Makefile.in (LIB_PTHREAD): New variable.
7969 (LIBES): Add LIB_PTHREAD (Bug#9216).
7971 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7972 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7974 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7976 * regex.c (re_iswctype): Remove some redundant boolean conversions.
7978 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7980 * xterm.c (x_find_topmost_parent): New function.
7981 (x_set_frame_alpha): Find topmost parent window with
7982 x_find_topmost_parent and set the property there also (bug#9181).
7983 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7985 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7987 * callproc.c (Fcall_process): Avoid vfork clobbering
7988 the local vars buffer, coding_systems, current_dir.
7990 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7992 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7994 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7996 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7997 so that it is not optimized away.
7999 * xdisp.c (compute_display_string_pos): Remove unused local.
8001 2011-08-02 Eli Zaretskii <eliz@gnu.org>
8003 Fix slow cursor motion and scrolling in large buffers with
8004 selective display, like Org Mode buffers. (Bug#9218)
8006 * dispextern.h (struct bidi_it): New member disp_prop_p.
8008 * xdisp.c: Remove one-slot cache of display string positions.
8009 (compute_display_string_pos): Accept an additional argument
8010 DISP_PROP_P; callers changed. Scan at most 5K characters forward
8011 for a display string or property. If found, set DISP_PROP_P
8014 * bidi.c (bidi_fetch_char): Accept an additional argument
8015 DISP_PROP_P, and pass it to compute_display_string_pos.
8016 Only handle text covered by a display string if DISP_PROP_P is returned
8017 non-zero. All callers of bidi_fetch_char changed.
8019 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8021 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8023 2010-12-03 Don March <don@ohspite.net>
8025 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8026 last character M-[char] is translated to ESC [char] (bug#7541).
8028 2011-08-02 Kenichi Handa <handa@m17n.org>
8030 * lisp.h (uniprop_table): Extern it.
8032 * chartab.c (uniprop_table): Make it non-static.
8034 2011-08-01 Eli Zaretskii <eliz@gnu.org>
8036 * xdisp.c (forward_to_next_line_start): Accept additional argument
8037 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8039 (reseat_at_next_visible_line_start): Use the bidi iterator state
8040 returned by forward_to_next_line_start to restore the state of
8041 it->bidi_it after backing up to previous newline. (Bug#9212)
8043 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8045 * regex.c (re_comp): Protoize.
8046 (re_exec): Fix return type.
8047 (regexec): Fix type of `ret'. (Bug#9203)
8049 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8051 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8052 This is needed if max-image-size is a floating-point number.
8054 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8056 * print.c (print_object): Print empty symbol as ##.
8058 * lread.c (read1): Read ## as empty symbol.
8060 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8062 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8063 setting frame foreground color (Bug#9175).
8064 (x_set_background_color): Likewise.
8066 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8067 contents (Bug#9176).
8068 (EmacsTooltip -init): Remove bezels and add shadows to
8071 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8072 or scroll bar (Bug#8470).
8074 * nsfont.m (nsfont_open): Remove assignment to voffset and
8075 unnecessary vars hshink, expand, hd, full_height, min_height.
8076 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8078 * nsterm.h (nsfont_info): Remove voffset field.
8080 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8082 Implement strike-through and overline on NextStep (Bug#8863).
8084 * nsfont.m (nsfont_open): Use underline position provided by font,
8085 instead of hard-coded value of 2.
8086 (nsfont_draw): Call ns_draw_text_decoration instead.
8088 * nsterm.h: Add declaration for ns_draw_text_decoration.
8090 * nsterm.m (ns_draw_text_decoration): New function for drawing
8091 underline, overline, and strike-through.
8092 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8093 ns_draw_text_decoration. Change treatment of cursor drawing to
8094 accommodate underlining, etc.
8096 2011-07-28 Eli Zaretskii <eliz@gnu.org>
8098 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8101 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8103 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8104 Without this fix, if a signal arrives just after memory fills up,
8105 'malloc' might be invoked reentrantly.
8107 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8108 In other words, assume that every image size is allowed, on non-X
8109 hosts. This assumption is probably wrong, but it lets Emacs compile.
8111 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8113 * regex.c (re_iswctype): Convert return values to boolean.
8115 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8117 * xdisp.c (compute_display_string_pos): Don't use cached display
8118 string position if the buffer had its restriction changed.
8121 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8123 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8125 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8127 Integer signedness and overflow and related fixes. (Bug#9079)
8129 * bidi.c: Integer size and overflow fixes.
8130 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8131 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8132 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8133 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8134 (bidi_find_other_level_edge):
8135 Use ptrdiff_t instead of EMACS_INT where either will do.
8136 This works better on 32-bit hosts configured --with-wide-int.
8137 (bidi_cache_ensure_space): Check for size-calculation overflow.
8138 Use % rather than repeated addition, for better worst-case speed.
8139 Don't set bidi_cache_size until after xrealloc returns, because it
8141 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
8142 (bidi_cache_ensure_space): Also check that the bidi cache size
8143 does not exceed that of the largest Lisp string or buffer. See Eli
8144 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
8146 * alloc.c (__malloc_size_t): Remove.
8147 All uses replaced by size_t. See Andreas Schwab's note
8148 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8150 * image.c: Improve checking for integer overflow.
8151 (check_image_size): Assume that f is nonnull, since
8152 it is always nonnull in practice. This is one less thing to
8153 worry about when checking for integer overflow later.
8154 (x_check_image_size): New function, which checks for integer
8155 overflow issues inside X.
8156 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8157 This removes the need for a memory_full check.
8158 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8159 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8160 (xbm_read_bitmap_data): Change locals back to 'int', since
8161 their values must fit in 'int'.
8162 (xpm_load_image, png_load, tiff_load):
8163 Invoke x_create_x_image_and_pixmap earlier,
8164 to avoid much needless work if the image is too large.
8165 (tiff_load): Treat overly large images as if
8166 x_create_x_image_and_pixmap failed, not as malloc failures.
8167 (gs_load): Use x_check_image_size.
8169 * gtkutil.c: Omit integer casts.
8170 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8171 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8173 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8175 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8176 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8177 would wrongly return t on a 64-bit host.
8179 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8180 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8181 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8182 and therefore cause GCC to emit a bogus diagnostic in some cases.
8184 * image.c: Integer signedness and overflow and related fixes.
8185 This is not an exhaustive set of fixes, but it's time to
8186 record what I've got.
8187 (lookup_pixel_color, check_image_size): Remove redundant decls.
8188 (check_image_size): Don't assume that arbitrary EMACS_INT values
8189 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8190 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8191 (tiff_load, imagemagick_load_image):
8192 Check for overflow in size calculations.
8193 (x_create_x_image_and_pixmap): Remove unnecessary test for
8194 xmalloc returning NULL; that can't happen.
8195 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8196 (xpm_color_bucket): Use better integer hashing function.
8197 (xpm_cache_color): Don't possibly over-allocate memory.
8198 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8199 (gif_memory_source):
8200 Use ptrdiff_t, not int or size_t, to record sizes.
8201 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8202 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8203 either works, as we prefer signed integers.
8204 (tiff_read_from_memory, tiff_write_from_memory):
8205 Return tsize_t, not size_t, since that's what the TIFF API wants.
8206 (tiff_read_from_memory): Don't fail simply because the read would
8207 go past EOF; instead, return a short read.
8208 (tiff_load): Omit no-longer-needed casts.
8209 (Fimagemagick_types): Don't assume size fits into 'int'.
8211 Improve hashing quality when configured --with-wide-int.
8212 * fns.c (hash_string): New function, taken from sxhash_string.
8213 Do not discard information about ASCII character case; this
8214 discarding is no longer needed.
8215 (sxhash-string): Use it. Change sig to match it. Caller changed.
8216 * lisp.h: Declare it.
8217 * lread.c (hash_string): Remove, since we now use fns.c's version.
8218 The fns.c version returns a wider integer if --with-wide-int is
8219 specified, so this should help the quality of the hashing a bit.
8221 * emacs.c: Integer overflow minor fix.
8222 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8223 Define only if GNU_LINUX.
8224 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8226 * dispnew.c: Integer signedness and overflow fixes.
8227 Remove unnecessary forward decls, that were a maintenance hassle.
8228 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8230 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8231 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8232 (prepare_desired_row, line_draw_cost):
8233 Use int, not unsigned, where either works.
8234 (save_current_matrix, restore_current_matrix):
8235 Use ptrdiff_t, not size_t, where either works.
8236 (init_display): Check for overflow more accurately, and without
8237 relying on undefined behavior.
8239 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8240 Remove, replacing with the new symbols in lisp.h. All uses changed.
8241 * fileio.c (make_temp_name):
8242 * filelock.c (lock_file_1, lock_file):
8243 * xdisp.c (message_dolog):
8244 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8245 Use pMd etc. instead.
8246 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8247 replacing the pWIDE etc. symbols removed from editfns.c.
8249 * keyboard.h (num_input_events): Now uintmax_t.
8250 This is (very slightly) less likely to mess up due to wraparound.
8253 * buffer.c: Integer signedness fixes.
8254 (alloc_buffer_text, enlarge_buffer_text):
8255 Use ptrdiff_t rather than size_t when either will do, as we prefer
8258 * alloc.c: Integer signedness and overflow fixes.
8259 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8260 (__malloc_size_t): Default to size_t, not to int.
8261 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8262 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8263 Prefer ptrdiff_t to size_t when either would do, as we prefer
8265 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8266 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8267 Now const. Initialize with values that are in range even if char
8269 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8270 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8271 These functions do the right thing with sizes > 2**32.
8272 (check_depth): Now ptrdiff_t, not int.
8273 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8274 Adjust to new way of storing sizes. Check for size overflow bugs
8276 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8277 slightly wrong anyway, as it missed one instance of
8278 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8279 (refill_memory_reserve): Omit needless cast to size_t.
8280 (mark_object_loop_halt): Mark as externally visible.
8282 * xselect.c: Integer signedness and overflow fixes.
8283 (Fx_register_dnd_atom, x_handle_dnd_message):
8284 Use ptrdiff_t, not size_t, since we prefer signed.
8285 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8286 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8287 x_dnd_atoms_size and x_dnd_atoms_length.
8289 * doprnt.c: Prefer signed to unsigned when either works.
8291 * doprnt.c (doprnt):
8293 * xdisp.c (vmessage):
8294 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8295 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8296 prefer signed arithmetic to avoid comparison confusion.
8297 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8298 but is a bit tricky.
8300 Assume freestanding C89 headers, string.h, stdlib.h.
8301 * data.c, doprnt.c, floatfns.c, print.c:
8302 Include float.h unconditionally.
8303 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8304 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8305 * regex.c: Likewise for stddef.h, string.h.
8306 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8307 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8308 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8309 (STDC_HEADERS): Remove obsolete defines.
8310 * sysdep.c: Include limits.h unconditionally.
8312 Assume support for memcmp, memcpy, memmove, memset.
8313 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8314 * regex.c (memcmp, memcpy):
8315 Remove; we assume C89 now.
8317 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8318 (__malloc_safe_bcopy): Remove; no longer needed.
8320 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
8321 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8322 well either way, and we prefer signed to unsigned.
8324 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8326 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8327 closes the connection while we're reading (bug#9182).
8329 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
8331 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8332 are specified (Bug#9168).
8334 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8336 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8337 Found by GCC static checking and --with-wide-int on a 32-bit host.
8339 2011-07-25 Eli Zaretskii <eliz@gnu.org>
8341 * xdisp.c (compute_display_string_pos): Fix logic of caching
8342 previous display string position. Initialize cached_prev_pos to
8343 -1. Fixes slow-down at the beginning of a buffer.
8345 2011-07-24 Eli Zaretskii <eliz@gnu.org>
8347 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8348 for attrs[LFACE_FONTSET_INDEX].
8350 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8352 * xml.c (parse_region): Remove unused local
8353 that was recently introduced.
8355 2011-07-23 Eli Zaretskii <eliz@gnu.org>
8357 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8358 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8360 * xdisp.c (move_it_in_display_line_to): Record the best matching
8361 position for TO_CHARPOS while scanning the line, and restore it on
8362 exit if none of the characters scanned was an exact match.
8363 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
8364 when exact match is impossible due to invisible text, and the
8365 lines are truncated.
8367 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8369 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8372 2011-07-22 Eli Zaretskii <eliz@gnu.org>
8374 Fix a significant slow-down of cursor motion with C-n, C-p,
8375 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8376 auto-repeat under bidi redisplay in fontified buffers.
8377 * xdisp.c (compute_stop_pos_backwards): New function.
8378 (next_element_from_buffer): Call compute_stop_pos_backwards to
8379 find a suitable prev_stop when we find ourselves before
8381 (reseat): Don't look for prev_stop, as that could mean a very long
8383 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8384 <cached_disp_overlay_modiff>: Cache for last found display string
8386 (compute_display_string_pos): Return the cached position if asked
8387 about the same buffer in the same area of character positions, and
8388 the buffer wasn't changed since the time the display string
8389 position was cached.
8391 2011-07-22 Eli Zaretskii <eliz@gnu.org>
8393 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8394 is an integer, which is important for empty lines. (Bug#9149)
8396 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
8398 * frame.c (Fmodify_frame_parameters): In tty case, update the
8399 default face if necessary (Bug#4238).
8401 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
8403 * editfns.c (Fstring_to_char): No need to explain what a character
8404 is in the docstring (Bug#6576).
8406 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8408 * xml.c (parse_region): Make sure we always return a tree.
8410 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8412 * xml.c (parse_region): If a document contains only comments,
8415 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8417 * xml.c (make_dom): Return comments, too.
8419 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8422 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8423 and the surrounding thread.
8424 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8425 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8426 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8428 * s/openbsd.h (BROKEN_SIGIO): Define.
8429 * unexelf.c (unexec) [__OpenBSD__]:
8430 Don't update the .mdebug section of the Alpha COFF symbol table.
8432 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8434 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8437 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8439 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8440 This fixes some race conditions on the permissions of any newly
8443 * alloc.c (valid_pointer_p): Use pipe, not open.
8444 This fixes some permissions issues when debugging.
8446 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8447 If fchown fails to set both uid and gid, try to set just gid,
8448 as that is sometimes allowed. Adjust the file's mode to eliminate
8449 setuid or setgid bits that are inappropriate if fchown fails.
8451 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8453 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8454 to compare Lisp_Objects.
8455 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8456 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8457 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8459 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8461 * lread.c (read_integer): Unread even EOF character.
8462 (read1): Likewise. Properly record start position of symbol.
8464 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8465 symbol character follows.
8467 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8469 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8470 This works around a problem with the previous change to Fcopy_file.
8471 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8472 and without this change, GCC might complain about discarding
8473 fchown's return value.
8475 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
8477 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8479 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8481 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8483 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8485 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8486 it's used from the C level.
8488 * process.c: Use the same condition for POLL_FOR_INPUT in both
8489 keyboard.c and process.c (bug#1858).
8491 2011-07-09 Lawrence Mitchell <wence@gmx.li>
8493 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8494 (Fgnutls_boot): Use it.
8496 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8498 * doc.c (Fsubstitute_command_keys): Revert last change.
8500 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8502 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8503 quotes the next character, and doesn't affect other longer
8504 sequences (bug#8935).
8506 * lread.c (syms_of_lread): Clarify that is isn't only
8507 `eval-buffer' and `eval-defun' that's affected by
8508 `lexical-binding' (bug#8460).
8510 2011-07-15 Eli Zaretskii <eliz@gnu.org>
8512 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
8513 bidi redisplay when a line includes both an image and is truncated.
8515 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8517 Fix minor problems found by static checking.
8518 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8519 (elsz): Now a signed constant, not a size_t var. We prefer signed
8520 types to unsigned, to avoid integer comparison confusion. Without
8521 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8522 "cannot optimize loop, the loop counter may overflow", a symptom
8524 * indent.c (Fvertical_motion): Mark locals as initialized.
8525 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8527 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8529 * search.c (Fre_search_backward): Mention `case-fold-search' in
8530 all the re_search_* functions (bug#8138).
8532 * keyboard.c (Fopen_dribble_file): Document when the file is
8535 2011-07-14 Eli Zaretskii <eliz@gnu.org>
8537 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8540 Support bidi reordering of display and overlay strings.
8541 * xdisp.c (compute_display_string_pos)
8542 (compute_display_string_end): Accept additional argument STRING.
8543 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8544 (reseat_to_string): Initialize bidi_it->string.s and
8545 bidi_it->string.schars.
8546 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
8547 NULL (avoids a crash in bidi_paragraph_init).
8548 Initialize itb.string.lstring.
8549 (init_iterator): Call bidi_init_it only of a valid
8550 buffer position was specified. Initialize paragraph_embedding to
8552 (reseat_to_string): Initialize the bidi iterator.
8553 (display_string): If we need to ignore text properties of
8554 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8555 original value of -1 will not work with bidi.)
8556 (compute_display_string_pos): First arg is now struct
8557 `text_pos *'; all callers changed. Support display properties on
8559 (compute_display_string_end): Support display properties on Lisp
8561 (init_iterator, reseat_1, reseat_to_string): Initialize the
8562 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8563 when iterating on a string not from display properties).
8564 (compute_display_string_pos, compute_display_string_end):
8565 Fix calculation of the object to scan. Fixes an error when using
8567 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
8568 base_level_stop; instead, set base_level_stop to BEGV.
8569 Fixes crashes in vertical-motion.
8570 (next_element_from_buffer): Improve commentary for when
8571 the iterator is before prev_stop.
8572 (init_iterator): Initialize bidi_p from the default value of
8573 bidi-display-reordering, not from buffer-local value. Use the
8574 buffer-local value only if initializing for buffer iteration.
8575 (handle_invisible_prop): Support invisible properties on strings
8576 that are being bidi-reordered.
8577 (set_iterator_to_next): Support bidi reordering of C strings and
8579 (next_element_from_string): Support bidi reordering of Lisp
8581 (handle_stop_backwards): Support Lisp strings as well.
8582 (display_string): Support display of R2L glyph rows.
8583 Use IT_STRING_CHARPOS when displaying from a Lisp string.
8584 (init_iterator): Don't initialize it->bidi_p for strings
8586 (reseat_to_string): Initialize it->bidi_p for strings here.
8587 (next_element_from_string, next_element_from_c_string)
8588 (next_element_from_buffer): Add xassert's for correspondence
8589 between IT's object being iterated and it->bidi_it.string
8591 (face_before_or_after_it_pos): Support bidi iteration.
8592 (next_element_from_c_string): Handle the case of the first string
8593 character that is not the first one in the visual order.
8594 (get_visually_first_element): New function, refactored from common
8595 parts of next_element_from_buffer, next_element_from_string, and
8596 next_element_from_c_string.
8597 (tool_bar_lines_needed, redisplay_tool_bar)
8598 (display_menu_bar): Force left-to-right direction. Add a FIXME
8599 comment for making that be controlled by a user option.
8600 (push_it, pop_it): Save and restore the state of the
8601 bidi iterator. Save and restore the bidi_p flag.
8602 (pop_it): Iterate out of display property for string iteration as
8604 (iterate_out_of_display_property): Support iteration over strings.
8605 (handle_single_display_spec): Set up it->bidi_it for iteration
8606 over a display string, and call bidi_init_it.
8607 (handle_single_display_spec, next_overlay_string)
8608 (get_overlay_strings_1, push_display_prop): Set up the bidi
8609 iterator for displaying display or overlay strings.
8610 (forward_to_next_line_start): Don't use the shortcut if
8612 (back_to_previous_visible_line_start): If handle_display_prop
8613 pushed the iterator stack, restore the internal state of the bidi
8614 iterator by calling bidi_pop_it same number of times.
8615 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8616 and we are bidi-iterating, don't decrement the iterator position;
8617 instead, set the first_elt flag in the bidi iterator, to produce
8619 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8620 (push_display_prop): xassert that we are iterating a buffer.
8621 (push_it, pop_it): Save and restore paragraph_embedding member.
8622 (handle_single_display_spec, next_overlay_string)
8623 (get_overlay_strings_1, reseat_1, reseat_to_string)
8624 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8625 correctly. Don't assume unibyte strings are not bidi-reordered.
8626 (compute_display_string_pos)
8627 (compute_display_string_end): Fix handling the case of C string.
8628 (push_it, pop_it): Save and restore from_disp_prop_p.
8629 (handle_single_display_spec, push_display_prop): Set the
8630 from_disp_prop_p flag.
8631 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8632 (pop_it): Call iterate_out_of_display_property only if we are
8633 popping after iteration over a string that came from a display
8634 property. Fix a typo in popping stretch info. Add an assertion
8635 for verifying that the iterator position is in sync with the bidi
8637 (handle_single_display_spec, get_overlay_strings_1)
8638 (push_display_prop): Fix initialization of paragraph direction for
8639 string when that of the parent object is not yet determined.
8640 (reseat_1): Call bidi_init_it to resync the bidi
8641 iterator with IT's position. (Bug#7616)
8642 (find_row_edges): If ROW->start.pos gives position
8643 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8644 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8645 Reset the from_disp_prop_p flag.
8646 (SAVE_IT, RESTORE_IT): New macros.
8647 (pos_visible_p, face_before_or_after_it_pos)
8648 (back_to_previous_visible_line_start)
8649 (move_it_in_display_line_to, move_it_in_display_line)
8650 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8651 (try_scrolling, redisplay_window, display_line): Use them when
8652 saving a temporary copy of the iterator and restoring it back.
8653 (back_to_previous_visible_line_start, reseat_1)
8654 (init_iterator): Empty the bidi cache "stack".
8655 (move_it_in_display_line_to): If iterator ended up at
8656 EOL, but we never saw any buffer positions smaller than
8657 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8658 motion in bidi-reordered lines.
8659 (move_it_in_display_line_to): Record prev_method and prev_pos
8660 immediately before the call to set_iterator_to_next. Fixes cursor
8661 motion in bidi-reordered lines with stretch glyphs and strings
8662 displayed in margins. (Bug#8133) (Bug#8867)
8663 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8665 (pos_visible_p): Support positions in bidi-reordered lines.
8666 Save and restore bidi cache.
8668 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8669 (bidi_paragraph_info): Delete unused struct.
8670 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8671 (bidi_cache_start): New variable.
8672 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8674 (bidi_cache_fetch_state, bidi_cache_search)
8675 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8676 (bidi_cache_find, bidi_peek_at_next_level)
8677 (bidi_level_of_next_char, bidi_find_other_level_edge)
8678 (bidi_move_to_visually_next): Compare cache index with
8679 bidi_cache_start rather than with zero.
8680 (bidi_fetch_char): Accept new argument STRING; all callers
8681 changed. Support iteration over a string. Support strings with
8682 display properties. Support unibyte strings. Fix the type of
8683 `len' according to what STRING_CHAR_AND_LENGTH expects.
8684 (bidi_paragraph_init, bidi_resolve_explicit_1)
8685 (bidi_resolve_explicit, bidi_resolve_weak)
8686 (bidi_level_of_next_char, bidi_move_to_visually_next):
8687 Support iteration over a string.
8688 (bidi_set_sor_type, bidi_resolve_explicit_1)
8689 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8690 can now be zero (for strings); special values 0 and -1 were
8691 changed to -1 and -2, respectively.
8692 (bidi_char_at_pos): New function.
8693 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8694 Call it instead of FETCH_MULTIBYTE_CHAR.
8695 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8696 initialized to valid values.
8697 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8699 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8700 the test for valid cached positions. Fix the logic for looking up
8701 the sentinel state in the cache. GCPRO the Lisp string we are
8703 (bidi_push_it, bidi_pop_it): New functions.
8704 (bidi_initialize): Initialize the bidi cache start stack pointer.
8705 (bidi_cache_ensure_space): New function, refactored from part of
8706 bidi_cache_iterator_state. Don't assume the required size is just
8707 one BIDI_CACHE_CHUNK away.
8708 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8709 (bidi_count_bytes, bidi_char_at_pos): New functions.
8710 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8711 always valid if bidi_cache_idx is valid.
8712 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8713 is valid if it's going to be used.
8714 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8715 (bidi_cache_fetch_state, bidi_cache_search)
8716 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8717 (bidi_cache_iterator_state, bidi_cache_find)
8718 (bidi_find_other_level_edge, bidi_cache_start_stack):
8719 All variables related to cache indices are now EMACS_INT.
8721 * dispextern.h (struct bidi_string_data): New structure.
8722 (struct bidi_it): New member `string'. Make flag members be 1-bit
8723 fields, and put them last in the struct.
8724 (compute_display_string_pos, compute_display_string_end):
8726 (bidi_push_it, bidi_pop_it): Add prototypes.
8727 (struct iterator_stack_entry): New members bidi_p,
8728 paragraph_embedding, and from_disp_prop_p.
8729 (struct it): Member bidi_p is now a bit field 1 bit wide.
8730 (bidi_shelve_cache, bidi_unshelve_cache):
8733 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8734 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8735 and vector-like objects.
8737 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8738 cache around display iteration.
8740 * window.c (Fwindow_end, window_scroll_pixel_based)
8741 (displayed_window_lines, Frecenter): Save and restore the bidi
8742 cache around display iteration.
8744 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8746 * editfns.c (Fdelete_region): Clarify the use of the named
8747 parameters (bug#6788).
8749 2011-07-14 Martin Rudalics <rudalics@gmx.at>
8751 * indent.c (Fvertical_motion): Set and restore w->pointm when
8752 saving and restoring the window's buffer (Bug#9006).
8754 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8756 * editfns.c (Fstring_to_char): Clarify just what is returned
8757 (bug#6576). Text by Eli Zaretskii.
8759 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
8761 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8763 2011-07-13 Eli Zaretskii <eliz@gnu.org>
8765 * buffer.c (mmap_find): Fix a typo.
8767 2011-07-13 Johan Bockgård <bojohan@gnu.org>
8769 Fix execution of x selection hooks.
8770 * xselect.c (Qx_lost_selection_functions)
8771 (Qx_sent_selection_functions): New vars.
8772 (syms_of_xselect): DEFSYM them.
8773 (x_handle_selection_request): Pass Qx_sent_selection_functions
8774 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8775 (x_handle_selection_clear,x_clear_frame_selections):
8776 Pass Qx_lost_selection_functions rather than
8777 Vx_lost_selection_functions to Frun_hook_with_args.
8779 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8781 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
8782 The old code sometimes used this field without initializing it.
8784 * alloc.c (gc_sweep): Don't read past end of array.
8785 In theory, the old code could also have corrupted Emacs internals,
8786 though it'd be very unlikely.
8788 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8790 * character.c (Fcharacterp): Don't advertise optional ignored
8791 argument. (Bug#4026)
8793 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8795 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8798 * window.c (Fset_window_start): Doc fix (bug#4199).
8799 (Fset_window_hscroll): Ditto.
8801 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8803 Fix minor new problems caught by GCC 4.6.1.
8804 * term.c (init_tty): Remove unused local.
8805 * xsettings.c (store_monospaced_changed): Define this function only
8806 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
8809 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
8811 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8813 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8815 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8816 are the mini-buffer and the echo area (bug#3320).
8818 * term.c (init_tty): Remove support for supdup, c10 and perq
8819 terminals, which are no longer supported (bug#1482).
8821 2011-07-10 Johan Bockgård <bojohan@gnu.org>
8823 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8825 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8827 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8828 for non-popups (Bug#3642).
8830 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8832 * alloc.c (reset_malloc_hooks): Protoize.
8833 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
8834 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8835 * cm.c (losecursor): Likewise.
8836 * data.c (fmod): Likewise.
8837 * dispnew.c (swap_glyphs_in_rows): Likewise.
8838 * emacs.c (memory_warning_signal): Likewise.
8839 * floatfns.c (float_error): Likewise.
8840 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8841 (otf_open, font_otf_capability, generate_otf_features)
8842 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8844 * image.c (pbm_read_file): Likewise.
8845 * indent.c (string_display_width): Likewise.
8846 * intervals.c (check_for_interval, search_for_interval)
8847 (inc_interval_count, count_intervals, root_interval)
8848 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8849 * lread.c (defalias): Likewise.
8850 * ralloc.c (r_alloc_check): Likewise.
8851 * regex.c (set_image_of_range_1, set_image_of_range)
8852 (regex_grow_registers): Likewise.
8853 * sysdep.c (strerror): Likewise.
8854 * termcap.c (valid_filename_p, tprint, main): Likewise.
8855 * tparam.c (main): Likewise.
8856 * unexhp9k800.c (run_time_remap, save_data_space)
8857 (update_file_ptrs, read_header, write_header, calculate_checksum)
8858 (copy_file, copy_rest, display_header): Likewise.
8859 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8861 * xdisp.c (check_it): Likewise.
8862 * xfaces.c (register_color, unregister_color, unregister_colors):
8864 * xfns.c (print_fontset_result): Likewise.
8865 * xrdb.c (member, fatal, main): Likewise.
8867 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8869 Fix minor problems found by static checking (Bug#9031).
8870 * chartab.c (char_table_set_range, map_sub_char_table):
8871 Remove unused locals.
8872 (uniprop_table): Now static.
8873 * composite.c (_work_char): Remove unused static var.
8875 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
8877 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8879 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8881 * gtkutil.c (qttip_cb): Remove code without function.
8883 2011-07-09 Eli Zaretskii <eliz@gnu.org>
8885 * w32.c (pthread_sigmask): New stub.
8887 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
8889 Use pthread_sigmask, not sigprocmask (Bug#9010).
8890 sigprocmask is portable only for single-threaded applications, and
8891 Emacs can be multi-threaded when it uses GTK.
8892 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8894 * callproc.c (Fcall_process):
8895 * process.c (create_process):
8896 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8897 Use pthread_sigmask, not sigprocmask.
8899 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8901 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8902 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8905 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8907 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8908 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8909 (xg_hide_tooltip): Fix comment.
8911 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8912 in registerServicesMenuSendTypes.
8913 (validRequestorForSendType): Don't check ns_return_types.
8915 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8918 2011-07-08 Jason Rumney <jasonr@gnu.org>
8920 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8921 SH_SHOW for hidden windows (Bug#5482).
8923 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8924 frame struct members of non-existent frames (Bug#6284).
8926 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8928 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8929 variable firstTime not needed on OSX >= 10.6.
8930 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8931 >= 10.5. Use setKnobProportion, setDoubleValue.
8933 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8934 (MAC_OS_X_VERSION_10_5): Define if not defined.
8935 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8936 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8937 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8939 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
8940 cString and lossyCString on OSX >= 10.4.
8942 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
8943 sizeToFit on OSX >= 10.2.
8945 * nsimage.m (allocInitFromFile): Don't use deprecated method
8946 bestRepresentationForDevice on OSX >= 10.6.
8948 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8951 * emacs.c: Declare unexec_init_emacs_zone.
8953 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8955 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8957 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8958 on svcsMenu (Bug#8842).
8960 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8962 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8964 * nsterm.m (QUTF8_STRING): Declare.
8965 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8966 (validRequestorForSendType): Return type is (id).
8967 Change indexOfObjectIdenticalTo to indexOfObject.
8968 Check if we have local selection before returning self (Bug#8842).
8969 (writeSelectionToPasteboard): Put local selection into paste board
8970 if we have a local selection (Bug#8842).
8971 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8973 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8974 (ns_get_local_selection): Declare.
8976 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8978 * keymap.c (describe_map_tree): Don't insert a double newline at
8979 the end of the buffer (bug#1169) and return whether we inserted
8982 * callint.c (Fcall_interactively): Change "reading args" to
8983 "providing args" to try to clarify what it does (bug#1010).
8985 2011-07-07 Kenichi Handa <handa@m17n.org>
8987 * composite.c (composition_compute_stop_pos): Ignore a static
8988 composition starting before CHARPOS (Bug#8915).
8990 * xdisp.c (handle_composition_prop): Likewise.
8992 2011-07-07 Eli Zaretskii <eliz@gnu.org>
8994 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8997 2011-07-07 Kenichi Handa <handa@m17n.org>
8999 * character.h (unicode_category_t): New enum type.
9001 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9002 (Qchar_code_property_table): New variable.
9003 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9004 (UNIPROP_COMPRESSED_FORM_P): New macros.
9005 (char_table_ascii): Uncompress the compressed values.
9006 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9007 Uncompress the compressed values.
9008 (sub_char_table_ref_and_range): Likewise.
9009 (char_table_ref_and_range): Uncompress the compressed values.
9010 (sub_char_table_set): New arg is_uniprop. Callers changed.
9011 Uncompress the compressed values.
9012 (sub_char_table_set_range): Args changed. Callers changed.
9013 (char_table_set_range): Adjuted for the above change.
9014 (map_sub_char_table): Delete args default_val and parent. Add arg
9015 top. Give decoded values to a Lisp function.
9016 (map_char_table): Adjust for the above change. Give decoded
9017 values to a Lisp function. Gcpro more variables.
9018 (uniprop_table_uncompress)
9019 (uniprop_decode_value_run_length): New functions.
9020 (uniprop_decoder, uniprop_decoder_count): New variables.
9021 (uniprop_get_decoder, uniprop_encode_value_character)
9022 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9024 (uniprop_encoder, uniprop_encoder_count): New variables.
9025 (uniprop_get_encoder, uniprop_table)
9026 (Funicode_property_table_internal, Fget_unicode_property_internal)
9027 (Fput_unicode_property_internal): New functions.
9028 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9029 Sunicode_property_table_internal, Sget_unicode_property_internal,
9030 and Sput_unicode_property_internal. Defvar_lisp
9031 char-code-property-alist.
9033 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
9034 Vunicode_category_table.
9036 * font.c (font_range): Adjust for the change of
9037 Vunicode_category_table.
9039 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9041 * m/iris4d.h: Remove file, move contents ...
9042 * s/irix6-5.h: ... here.
9044 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9046 Remove unportable assumption about struct layout (Bug#8884).
9047 * alloc.c (mark_buffer):
9048 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9049 (clone_per_buffer_values): Don't assume that
9050 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9051 This isn't true in general, and it's particularly not true
9052 if Emacs is configured with --with-wide-int.
9053 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9054 New macros, used in the buffer.c change.
9056 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9058 * xsettings.c: Use both GConf and GSettings if both are available.
9059 (store_config_changed_event): Add comment.
9060 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9061 (store_tool_bar_style_changed): New functions.
9062 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
9063 (struct xsettings): Move font inside HAVE_XFT.
9064 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
9065 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
9066 Move inside HAVE_XFT.
9067 (something_changed_gsettingsCB): Rename from something_changedCB.
9068 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9070 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
9071 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
9072 (something_changed_gconfCB): Rename from something_changedCB.
9073 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9074 (parse_settings): Move check for font inside HAVE_XFT.
9075 (read_settings, apply_xft_settings): Add comment.
9076 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9077 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9078 call store_font_name_changed.
9079 (xft_settings_event): Add comment.
9080 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9081 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9082 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9083 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9084 (xsettings_initialize): Call init_gsettings last.
9085 (xsettings_get_system_font, xsettings_get_system_normal_font):
9088 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9090 Random fixes. E.g., (random) never returned negative values.
9091 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9092 subseconds part to the entropy, as that's a bit more random.
9093 Prefer signed to unsigned, since the signedness doesn't matter and
9094 in general we prefer signed. When given a limit, use a
9095 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9096 latter isn't right if USE_2_TAGS_FOR_INTS.
9097 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9098 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9100 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9102 * textprop.c (text_property_stickiness):
9103 Obey Vtext_property_default_nonsticky.
9104 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9105 * w32fns.c (syms_of_w32fns):
9106 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9108 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9110 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9111 This is more efficient than Ffile_directory_p and avoids a minor race.
9113 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9115 * buffer.c (Foverlay_put): Say what the return value is
9118 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9119 is a directory before asking whether to use the file name
9121 (barf_or_query_if_file_exists): Make the "File is a directory"
9122 error be more correct.
9124 * fns.c (Frequire): Remove the mention of the .gz files, since
9125 that's installation-specific, but keep the mention of
9126 `get-load-suffixes'.
9128 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9130 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9131 Report string overflow if the output is too long.
9133 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
9135 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9136 (syms_of_gnutls): Remove duplicate DEFSYM for
9137 Qgnutls_bootprop_verify_hostname_error, an error for
9138 Qgnutls_bootprop_verify_error (which is no longer used).
9140 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9141 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9142 Also (re)move comments that are misplaced or no longer relevant.
9144 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9146 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9148 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
9150 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9151 and background color parameters if they have been changed.
9153 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9155 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9157 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9159 * xsettings.c (SYSTEM_FONT): Define only when used.
9160 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9162 * keymap.c (access_keymap_1): Now static.
9164 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
9166 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9167 leave any prefix arg for the up event (Bug#1586).
9169 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9171 * lread.c (syms_of_lread): Mention single symbols defined by
9172 `defvar' or `defconst' (bug#7154).
9174 * fns.c (Frequire): Mention .el.gz files (bug#7314).
9175 (Frequire): Mention get-load-suffixes.
9177 2011-07-02 Martin Rudalics <rudalics@gmx.at>
9179 * window.h (window): Remove clone_number slot.
9180 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9182 (make_parent_window, make_window, saved_window)
9183 (Fset_window_configuration, save_window_save): Don't deal with
9185 * buffer.c (Qclone_number): Remove declaration.
9186 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9188 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9190 Add multiple inheritance to keymaps.
9191 * keymap.c (Fmake_composed_keymap): New function.
9192 (Fset_keymap_parent): Simplify.
9193 (fix_submap_inheritance): Remove.
9194 (access_keymap_1): New function extracted from access_keymap to handle
9195 embedded parents and handle lists of maps.
9196 (access_keymap): Use it.
9197 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9198 (Fcopy_keymap): Handle embedded parents.
9199 (Fcommand_remapping, define_as_prefix): Simplify.
9200 (Fkey_binding): Simplify.
9201 (syms_of_keymap): Move minibuffer-local-completion-map,
9202 minibuffer-local-filename-completion-map,
9203 minibuffer-local-must-match-map, and
9204 minibuffer-local-filename-must-match-map to Elisp.
9205 (syms_of_keymap): Defsubr make-composed-keymap.
9206 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9207 (parse_menu_item): Trivial simplification.
9209 2011-07-01 Glenn Morris <rgm@gnu.org>
9211 * Makefile.in (SETTINGS_LIBS): Fix typo.
9213 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9215 * coding.c (Fencode_coding_string): Record the last coding system
9216 used, as the function doc string says (bug#8738).
9218 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9220 * xsettings.c (store_monospaced_changed): Take new font as arg and
9221 check for change against current_mono_font.
9222 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9223 (emacs_settings_constructor, emacs_settings_get_property)
9224 (emacs_settings_set_property, emacs_settings_class_init)
9225 (emacs_settings_init, gsettings_obj): Remove.
9226 (something_changedCB): New function for HAVE_GSETTINGS.
9227 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9228 with value as argument.
9229 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9230 g_settings_new (Bug#8967). Do not create gsettings_obj.
9231 Remove calls to g_settings_bind. Connect something_changedCB to
9234 * xgselect.c: Add defined (HAVE_GSETTINGS).
9235 (xgselect_initialize): Ditto.
9237 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9238 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9241 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9243 * eval.c (struct backtrace): Simplify and port the data structure.
9244 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9245 signed bit field, as this assumption is not portable and it makes
9246 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9247 "char debug_on_exit : 1" as this is not portable either; instead,
9248 use the portable "unsigned int debug_on_exit : 1". Remove unused
9249 member evalargs. Remove obsolete comments about cc bombing out.
9251 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9253 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9254 Let HAVE_GSETTINGS override HAVE_GCONF.
9255 (store_monospaced_changed): New function.
9256 (EMACS_SETTINGS): A new type derived from GObject to handle
9257 GSettings notifications.
9258 (emacs_settings_constructor, emacs_settings_get_property)
9259 (emacs_settings_set_property, emacs_settings_class_init):
9261 (gsettings_client, gsettings_obj): New variables.
9262 (GSETTINGS_SCHEMA): New define.
9263 (something_changedCB): Call store_monospaced_changed.
9264 (init_gsettings): New function.
9265 (xsettings_initialize): Call init_gsettings.
9266 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9269 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9272 2011-06-29 Martin Rudalics <rudalics@gmx.at>
9274 * window.c (resize_root_window, grow_mini_window)
9275 (shrink_mini_window): Rename Qresize_root_window to
9276 Qwindow_resize_root_window and Qresize_root_window_vertically to
9277 Qwindow_resize_root_window_vertically.
9279 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9281 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9283 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
9285 * makefile.w32-in: Redesign dependencies so they reflect more
9286 clearly which files are directly included by each source file,
9287 and not through other includes.
9289 2011-06-27 Martin Rudalics <rudalics@gmx.at>
9291 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9292 (sort_overlays, overlay_strings): When an overlay's clone number
9293 matches the window's clone number process the overlay even if
9294 the overlay's window property doesn't match the current window.
9296 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9297 (Fwindow_hchild): Rename to Fwindow_left_child.
9298 (Fwindow_next): Rename to Fwindow_next_sibling.
9299 (Fwindow_prev): Rename to Fwindow_prev_sibling.
9300 (resize_window_check): Rename to window_resize_check.
9301 (resize_window_apply): Rename to window_resize_apply.
9302 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9303 (Fdelete_other_windows_internal, resize_frame_windows)
9304 (Fsplit_window_internal, Fdelete_window_internal)
9305 (grow_mini_window, shrink_mini_window)
9306 (Fresize_mini_window_internal): Fix callers accordingly.
9308 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9310 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9311 (emacs_fixed_set_min_size): Remove.
9312 (emacs_fixed_new): Take frame as argument.
9314 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9315 (_EmacsFixedPrivate): Remove minwidth/height.
9316 Add struct frame *f.
9317 (emacs_fixed_init): Initialize priv->f.
9318 (get_parent_class, emacs_fixed_set_min_size): Remove.
9319 (emacs_fixed_new): Set priv->f to argument.
9320 (emacs_fixed_get_preferred_width)
9321 (emacs_fixed_get_preferred_height): Use min_width/height from
9322 frames size_hint to set minimum and natural (Bug#8919).
9323 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9324 and use min_width/height from frames size_hint to set
9325 min_width/height (Bug#8919).
9327 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9328 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9331 2011-06-26 Eli Zaretskii <eliz@gnu.org>
9333 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9334 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9337 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
9339 * process.c (wait_reading_process_output): Bypass select if
9340 waiting for a cell while ignoring keyboard input, and input is
9341 pending. Suggested by Jan Djärv (Bug#8869).
9343 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9345 Use gnulib's dup2 module instead of rolling our own.
9346 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9348 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9350 * dispnew.c (scrolling_window): Before scrolling, turn off a
9351 mouse-highlight in the window being scrolled.
9353 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
9355 Move DEFSYM to lisp.h and use everywhere.
9357 * character.h (DEFSYM): Move declaration...
9358 * lisp.h (DEFSYM): ...here.
9364 * w32select.c: Don't include character.h.
9366 * alloc.c (syms_of_alloc):
9367 * buffer.c (syms_of_buffer):
9368 * bytecode.c (syms_of_bytecode):
9369 * callint.c (syms_of_callint):
9370 * casefiddle.c (syms_of_casefiddle):
9371 * casetab.c (init_casetab_once):
9372 * category.c (init_category_once, syms_of_category):
9373 * ccl.c (syms_of_ccl):
9374 * cmds.c (syms_of_cmds):
9375 * composite.c (syms_of_composite):
9376 * dbusbind.c (syms_of_dbusbind):
9377 * dired.c (syms_of_dired):
9378 * dispnew.c (syms_of_display):
9379 * doc.c (syms_of_doc):
9380 * editfns.c (syms_of_editfns):
9381 * emacs.c (syms_of_emacs):
9382 * eval.c (syms_of_eval):
9383 * fileio.c (syms_of_fileio):
9384 * fns.c (syms_of_fns):
9385 * frame.c (syms_of_frame):
9386 * fringe.c (syms_of_fringe):
9387 * insdel.c (syms_of_insdel):
9388 * keymap.c (syms_of_keymap):
9389 * lread.c (init_obarray, syms_of_lread):
9390 * macros.c (syms_of_macros):
9391 * msdos.c (syms_of_msdos):
9392 * print.c (syms_of_print):
9393 * process.c (syms_of_process):
9394 * search.c (syms_of_search):
9395 * sound.c (syms_of_sound):
9396 * syntax.c (init_syntax_once, syms_of_syntax):
9397 * terminal.c (syms_of_terminal):
9398 * textprop.c (syms_of_textprop):
9399 * undo.c (syms_of_undo):
9400 * w32.c (globals_of_w32):
9401 * window.c (syms_of_window):
9402 * xdisp.c (syms_of_xdisp):
9403 * xfaces.c (syms_of_xfaces):
9404 * xfns.c (syms_of_xfns):
9405 * xmenu.c (syms_of_xmenu):
9406 * xsettings.c (syms_of_xsettings):
9407 * xterm.c (syms_of_xterm): Use DEFSYM.
9409 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9411 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
9413 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9415 Integer and buffer overflow fixes (Bug#8873).
9417 * print.c (printchar, strout): Check for string overflow.
9418 (PRINTPREPARE, printchar, strout):
9419 Don't set size unless allocation succeeds.
9421 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9422 for sizes. Check for string overflow more accurately.
9423 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9425 * macros.c: Integer and buffer overflow fixes.
9426 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9427 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9428 Use ptrdiff_t, not int, for sizes.
9429 Don't increment bufsize until after realloc succeeds.
9430 Check for size-calculation overflow.
9431 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9433 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9435 * lread.c: Integer overflow fixes.
9436 (read_integer): Radix is now EMACS_INT, not int,
9437 to improve quality of diagnostics for out-of-range radices.
9438 Calculate buffer size correctly for out-of-range radices.
9439 (read1): Check for integer overflow in radices, and in
9440 read-circle numbers.
9441 (read_escape): Avoid int overflow.
9442 (Fload, openp, read_buffer_size, read1)
9443 (substitute_object_recurse, read_vector, read_list, map_obarray):
9444 Use ptrdiff_t, not int, for sizes.
9445 (read1): Use EMACS_INT, not int, for sizes.
9446 Check for size overflow.
9448 * image.c (cache_image): Check for size arithmetic overflow.
9450 * lread.c: Integer overflow issues.
9451 (saved_doc_string_size, saved_doc_string_length)
9452 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9453 Now ptrdiff_t, not int.
9454 (read1): Don't assume doc string length fits in int. Check for
9455 out-of-range doc string lengths.
9456 (read_list): Don't assume file position fits in int.
9457 (read_escape): Check for hex character overflow.
9459 2011-06-22 Leo Liu <sdl.web@gmail.com>
9461 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9462 Move to minibuffer.el.
9464 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9466 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
9467 The following patches are for when GLYPH_DEBUG && !XASSERT.
9468 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9469 * dispnew.c (flush_stdout):
9470 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9471 Mark as externally visible.
9472 * dispnew.c (check_window_matrix_pointers): Now static.
9473 * dispnew.c (window_to_frame_vpos):
9474 * xfns.c (unwind_create_frame):
9475 * xterm.c (x_check_font): Remove unused local.
9476 * scroll.c (CHECK_BOUNDS):
9477 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9478 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9479 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9480 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9481 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9483 (debug_method_add): Use va_list and vsprintf rather than relying
9484 on undefined behavior with wrong number of arguments.
9485 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9486 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9487 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9488 since we're not interested in debugging glyphs with old libraries.
9489 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9490 GCC 4.6.0's static checking.
9492 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9494 Integer overflow and signedness fixes (Bug#8873).
9495 A few related buffer overrun fixes, too.
9497 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9499 * dispextern.h (struct face.stipple):
9500 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9501 (x_bitmap_mask, x_allocate_bitmap_record)
9502 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9503 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9504 (x_create_bitmap_from_xpm_data):
9505 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9506 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9508 * xfaces.c (load_pixmap):
9509 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9510 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9511 (.bitmaps_last, struct x_output.icon_bitmap):
9512 Use ptrdiff_t, not int, for bitmap indexes.
9513 (x_allocate_bitmap_record): Check for size overflow.
9514 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9516 Use ptrdiff_t, not int, for overlay counts.
9517 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9518 * editfns.c (overlays_around, get_pos_property):
9519 * textprop.c (get_char_property_and_overlay):
9520 * xdisp.c (next_overlay_change, note_mouse_highlight):
9521 * xfaces.c (face_at_buffer_position):
9522 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9523 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9524 (Fnext_overlay_change, Fprevious_overlay_change)
9525 (mouse_face_overlay_overlaps, Foverlays_in):
9526 Use ptrdiff_t, not int, for sizes.
9527 (overlays_at, overlays_in): Check for size-calculation overflow.
9529 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9531 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9532 (x_session_initialize): Do not assume string length fits in int.
9534 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9535 This is unlikely, but can occur if DPI is outlandish.
9537 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
9538 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9540 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9541 * xrdb.c (magic_file_p, search_magic_path):
9542 Omit last arg SUFFIX; it was always 0. All callers changed.
9543 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9545 * xfont.c (xfont_match): Avoid need for strlen.
9547 * xfns.c: Don't assume strlen fits in int.
9548 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9550 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9551 not unsigned long, as we prefer signed integers. All callers changed.
9552 Detect integer overflow in repeat count.
9553 (message_dolog): Don't assume print length fits in 39 bytes.
9554 (display_mode_element): Don't assume strlen fits in int.
9556 * termcap.c: Don't assume sizes fit in int and never overflow.
9557 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9558 (gobble_line): Check for size-calculation overflow.
9560 * minibuf.c (Fread_buffer):
9561 * lread.c (intern, intern_c_string):
9562 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9563 Don't assume string length fits in int.
9565 * keyboard.c (parse_tool_bar_item):
9566 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9568 * font.c: Don't assume string length fits in int.
9569 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9570 Use ptrdiff_t, not int.
9571 (font_intern_prop): Don't assume string length fits in int.
9572 Don't assume integer property fits in fixnum.
9573 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
9575 * filelock.c: Fix some buffer overrun and integer overflow issues.
9576 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
9577 Reformulate so as not to need the command string.
9578 Invoke gzip -cd rather than gunzip, as it's more portable.
9579 (lock_info_type, lock_file_1, lock_file):
9580 Don't assume pid_t and time_t fit in unsigned long.
9581 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9582 (current_lock_owner): Prefer signed type for sizes.
9583 Use memcpy, not strncpy, where memcpy is what is really wanted.
9584 Don't assume (via atoi) that time_t and pid_t fit in int.
9585 Check for time_t and/or pid_t out of range, e.g., via a network share.
9586 Don't alloca where an auto var works fine.
9588 * fileio.c: Fix some integer overflow issues.
9589 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9590 Don't assume string length fits in int.
9591 (directory_file_name): Don't assume string length fits in long.
9592 (make_temp_name): Don't assume pid fits in int, or that its print
9593 length is less than 20.
9595 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9597 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9599 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9601 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9602 We prefer signed integers, even for size calculations.
9604 * emacs.c: Don't assume string length fits in 'int'.
9605 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9606 (main): Don't invoke strlen when not needed.
9608 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9609 (XD_DEBUG_MESSAGE): Don't waste a byte.
9611 * callproc.c (getenv_internal_1, getenv_internal)
9613 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9615 * lread.c (invalid_syntax): Omit length argument.
9616 All uses changed. This doesn't fix a bug, but it simplifies the
9617 code away from its former Hollerith-constant appearance, and it's
9618 one less 'int' to worry about when looking at integer-overflow issues.
9619 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
9621 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9622 This didn't break anything, but it didn't help either.
9623 It's confusing to put a bogus integer in a place where the actual
9624 value does not matter.
9625 (LIST_END_P): Remove unused macro and its bogus comment.
9626 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
9628 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9629 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9631 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9632 We prefer signed types, and the value cannot exceed the EMACS_INT
9633 range anyway (because otherwise the length would not be representable).
9634 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9635 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9636 This avoids a GCC warning when WIDE_EMACS_INT.
9638 * indent.c (sane_tab_width): New function.
9639 (current_column, scan_for_column, Findent_to, position_indentation)
9640 (compute_motion): Use it. This is just for clarity.
9641 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
9643 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
9645 * lisp.h (lint_assume): New macro.
9646 * composite.c (composition_gstring_put_cache):
9647 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9649 * editfns.c, insdel.c:
9650 Omit unnecessary forward decls, to simplify future changes.
9652 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9654 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9656 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
9657 Use much-faster test for byte-length change.
9658 Don't assume string byte-length fits in 'int'.
9659 Check that character arg fits in 'int'.
9660 (mapcar1): Declare byte as byte, for clarity.
9662 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9664 * fns.c (concat): Catch string overflow earlier.
9665 Do not rely on integer wraparound.
9667 * dispextern.h (struct it.overlay_strings_charpos)
9668 (struct it.selective): Now EMACS_INT, not int.
9669 * xdisp.c (forward_to_next_line_start)
9670 (back_to_previous_visible_line_start)
9671 (reseat_at_next_visible_line_start, next_element_from_buffer):
9672 Don't arbitrarily truncate the value of 'selective' to int.
9674 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9676 * composite.c: Don't truncate sizes to 'int'.
9677 (composition_gstring_p, composition_reseat_it)
9678 (composition_adjust_point): Use EMACS_INT, not int.
9679 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9680 not EMACS_UINT, for indexes.
9682 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9684 * buffer.c: Include <verify.h>.
9685 (struct sortvec.priority, struct sortstr.priority):
9686 Now EMACS_INT, not int.
9687 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
9688 (struct sortstr.size, record_overlay_string)
9689 (struct sortstrlist.size, struct sortlist.used):
9690 Don't truncate size to int.
9691 (record_overlay_string): Check for size-calculation overflow.
9692 (init_buffer_once): Check at compile-time, not run-time.
9694 2011-06-22 Jim Meyering <meyering@redhat.com>
9696 Don't leak an XBM-image-sized buffer
9697 * image.c (xbm_load): Free the image buffer after using it.
9699 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9702 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9703 that Sun C diagnosed.
9704 * fns.c (secure_hash): Fix pointer signedness issue.
9705 * intervals.c (static_offset_intervals): New function.
9706 (offset_intervals): Use it.
9708 2011-06-21 Leo Liu <sdl.web@gmail.com>
9711 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9714 * fns.c (secure_hash): Rename from crypto_hash_function and change
9715 the first arg to accept symbols.
9716 (Fsecure_hash): New primitive.
9717 (syms_of_fns): New symbols.
9719 2011-06-20 Deniz Dogan <deniz@dogan.se>
9721 * process.c (Fset_process_buffer): Clarify return value in
9724 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
9726 * dispnew.c (add_window_display_history): Use BVAR.
9728 * xdisp.c (debug_method_add): Use BVAR.
9729 (check_window_end, dump_glyph_matrix, dump_glyph)
9730 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9732 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9735 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9736 check till after the cache is created in init_frame_faces.
9738 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9740 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9742 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9744 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9745 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9746 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9748 Improve buffer-overflow checking (Bug#8873).
9749 * fileio.c (Finsert_file_contents):
9750 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9751 Remove the old (too-loose) buffer overflow checks.
9752 They weren't needed, since make_gap checks for buffer overflow.
9753 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9754 The old code merely checked for Emacs fixnum overflow, and relied
9755 on undefined (wraparound) behavior. The new code avoids undefined
9756 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9758 * editfns.c (Finsert_char): Don't dump core with very negative counts.
9759 Tune. Don't use wider integers than needed. Don't use alloca.
9760 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
9762 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9764 * insdel.c, lisp.h (buffer_overflow): New function.
9765 (insert_from_buffer_1, replace_range, replace_range_2):
9766 * insdel.c (make_gap_larger):
9767 * editfns.c (Finsert_char):
9768 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9770 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9772 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9774 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
9776 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9777 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9779 * fileio.c: Don't assume EMACS_INT fits in off_t.
9780 (emacs_lseek): New static function.
9781 (Finsert_file_contents, Fwrite_region): Use it.
9782 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9784 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9786 * fns.c: Don't overflow int when computing a list length.
9787 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9788 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9789 truncation on 64-bit hosts. Check for QUIT every
9790 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9791 faster and is responsive enough.
9792 (Flength): Report an error instead of overflowing an integer.
9793 (Fsafe_length): Return a float if the value is not representable
9794 as a fixnum. This shouldn't happen except in contrived situations.
9795 (Fnthcdr, Fsort): Don't assume list length fits in int.
9796 (Fcopy_sequence): Don't assume vector length fits in int.
9798 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9799 (header_size, word_size): New constants.
9800 (allocate_vectorlike): Don't check size overflow here.
9801 (allocate_vector): Check it here instead, since this is the only
9802 caller of allocate_vectorlike that could cause overflow.
9803 Check that the new vector's length is representable as a fixnum.
9805 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9806 The previous code was bogus. For example, next_almost_prime (32)
9807 returned 39, which is undesirable as it is a multiple of 3; and
9808 next_almost_prime (24) returned 25, which is a multiple of 5 so
9809 why was the code bothering to check for multiples of 7?
9811 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9813 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9815 Variadic C functions now count arguments with ptrdiff_t.
9816 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9817 Back then I didn't know that the Emacs coding style prefers signed int.
9818 Also, in the meantime I found a few more instances where arguments
9819 were being counted with int, which may truncate counts on 64-bit
9820 machines, or EMACS_INT, which may be unnecessarily wide.
9821 * lisp.h (struct Lisp_Subr.function.aMANY)
9822 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9823 Arg counts are now ptrdiff_t, not size_t.
9824 All variadic functions and their callers changed accordingly.
9825 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9826 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9827 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9828 * callint.c (Fcall_interactively): Check arg count for overflow,
9829 to avoid potential buffer overrun. Use signed char, not 'int',
9830 for 'varies' array, so that we needn't bother to check its size
9831 calculation for overflow.
9832 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9833 * eval.c (apply_lambda):
9834 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9835 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9836 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9838 * callint.c (Fcall_interactively): Don't use index var as event count.
9840 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9841 * mem-limits.h (SIZE): Remove; no longer used.
9843 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
9845 Remove unnecessary casts.
9846 * xterm.c (x_term_init):
9847 * xfns.c (x_set_border_pixel):
9848 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9849 These aren't needed now that we assume ANSI C.
9851 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9852 It's more likely to cause problems (due to unsigned overflow)
9855 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9857 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9859 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9861 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9863 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9865 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9867 GLYPH_CODE_FACE returns EMACS_INT, not int.
9868 * dispextern.h (merge_faces):
9869 * xfaces.c (merge_faces):
9870 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9871 Don't assume EMACS_INT fits in int.
9873 * character.h (CHAR_VALID_P): Remove unused parameter.
9874 * fontset.c, lisp.h, xdisp.c: All uses changed.
9876 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9878 * fns.c (concat): Minor tuning based on overflow analysis.
9879 This doesn't fix any bugs. Use int to hold character, instead
9880 of constantly refetching from Emacs object. Use XFASTINT, not
9881 XINT, for value known to be a character. Don't bother comparing
9882 a single byte to 0400, as it's always less.
9884 * floatfns.c (Fexpt):
9885 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9887 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9890 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9892 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9893 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9894 incorrectly succeed when S was a string, because 4294967386 was
9895 truncated before it was used.
9897 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9898 Otherwise, an out-of-range integer could cause undefined behavior
9901 * composite.c: Use int, not EMACS_INT, for characters.
9902 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9903 EMACS_INT, for values that are known to be in character range.
9904 This doesn't fix any bugs but is the usual style inside Emacs and
9905 may generate better code on 32-bit machines.
9907 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9908 This is for reasons similar to the recent CHAR_STRING fix.
9909 * charset.c (Fencode_char): Check that character arg is actually
9910 a character. Pass an int to ENCODE_CHAR.
9911 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9912 wider than 'int', as a compile-time check to prevent future regressions
9915 * character.c (char_string): Remove unnecessary casts.
9917 Make sure a 64-bit char is never passed to CHAR_STRING.
9918 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9919 by silently ignoring the top 32 bits, allowing some values
9920 that were far too large to be valid characters.
9921 * character.h: Include <verify.h>.
9922 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9923 arguments are no wider than unsigned, as a compile-time check
9924 to prevent future regressions in this area.
9926 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
9927 (Fsubst_char_in_region):
9929 * xdisp.c (decode_mode_spec_coding):
9930 Adjust to CHAR_STRING's new requirement.
9931 * editfns.c (Finsert_char, Fsubst_char_in_region):
9932 * fns.c (concat): Check that character args are actually
9933 characters. Without this test, these functions did the wrong
9934 thing with wildly out-of-range values on 64-bit hosts.
9936 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9937 These casts should not be needed on 32-bit hosts, either.
9938 * keyboard.c (read_char):
9939 * lread.c (Fload): Remove casts to unsigned.
9941 * lisp.h (UNSIGNED_CMP): New macro.
9942 This fixes comparison bugs on 64-bit hosts.
9943 (ASCII_CHAR_P): Use it.
9944 * casefiddle.c (casify_object):
9945 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
9946 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9947 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9948 * dispextern.h (FACE_FROM_ID):
9949 * keyboard.c (read_char): Use UNSIGNED_CMP.
9951 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9952 not to EMACS_INT, to avoid GCC warning.
9954 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9956 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9957 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9958 isn't needed on 32-bit machines.
9960 * buffer.c (Fgenerate_new_buffer_name):
9961 Use EMACS_INT for count, not int.
9962 (advance_to_char_boundary): Return EMACS_INT, not int.
9964 * data.c (Qcompiled_function): Now static.
9966 * window.c (window_body_lines): Now static.
9968 * image.c (gif_load): Rename local to avoid shadowing.
9970 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9971 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9972 * alloc.c (make_save_value): Integer argument is now of type
9974 (mark_object): Use ptrdiff_t, not int.
9975 * lisp.h (pD): New macro.
9976 * print.c (print_object): Use it.
9978 * alloc.c: Use EMACS_INT, not int, to count objects.
9979 (total_conses, total_markers, total_symbols, total_vector_size)
9980 (total_free_conses, total_free_markers, total_free_symbols)
9981 (total_free_floats, total_floats, total_free_intervals)
9982 (total_intervals, total_strings, total_free_strings):
9983 Now EMACS_INT, not int. All uses changed.
9984 (Fgarbage_collect): Compute overall total using a double, so that
9985 integer overflow is less likely to be a problem. Check for overflow
9986 when converting back to an integer.
9987 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9988 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9989 These were 'int' variables that could overflow on 64-bit hosts;
9990 they were never used, so remove them instead of repairing them.
9991 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
9992 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9993 Previously, this ceilinged at INT_MAX, but that doesn't work on
9995 (allocate_pseudovector): Don't use EMACS_INT when int would do.
9997 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
9998 (allocate_vectorlike): Check for ptrdiff_t overflow.
9999 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10000 when a (possibly-narrower) signed value would do just as well.
10001 We prefer using signed arithmetic, to avoid comparison confusion.
10003 * alloc.c: Catch some string size overflows that we were missing.
10004 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10005 for convenience in STRING_BYTES_MAX.
10006 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10007 The definition here is exact; the one in lisp.h was approximate.
10008 (allocate_string_data): Check for string overflow. This catches
10009 some instances we weren't catching before. Also, it catches
10010 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10011 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10012 and ptrdiff_t and EMACS_INT are both 64 bits.
10014 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10015 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
10016 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
10018 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10020 * alloc.c (Fmake_string): Check for out-of-range init.
10022 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10024 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10026 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10028 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10029 xg_get_default_scrollbar_width.
10031 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10032 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10033 (style_changed_cb): Call update_theme_scrollbar_width and call
10034 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10035 all frames (Bug#8505).
10036 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10037 Call gtk_window_set_resizable if HAVE_GTK3.
10038 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10039 and height if HAVE_GTK3 (Bug#8505).
10040 (scroll_bar_width_for_theme): New variable.
10041 (update_theme_scrollbar_width): New function.
10042 (xg_get_default_scrollbar_width): Move code to
10043 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10044 (xg_initialize): Call update_theme_scrollbar_width.
10046 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10048 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10050 2011-06-12 Martin Rudalics <rudalics@gmx.at>
10052 * frame.c (make_frame): Call other_buffer_safely instead of
10055 * window.c (temp_output_buffer_show): Call display_buffer with
10056 second argument Vtemp_buffer_show_specifiers and reset latter
10057 immediately after the call.
10058 (Vtemp_buffer_show_specifiers): New variable.
10059 (auto_window_vscroll_p, next_screen_context_lines)
10060 (Vscroll_preserve_screen_position): Remove leading asterisks from
10063 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
10065 Fix minor problems found by GCC 4.6.0 static checking.
10066 * buffer.c (Qclone_number): Remove for now, as it's unused.
10067 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10068 (record_buffer): Remove unused local.
10069 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10070 (set_frame_buffer_list): Remove; unused.
10071 * frame.h (other_visible_frames): Remove decl.
10072 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10073 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10074 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10076 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10077 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10078 Define only if HAVE_GPM.
10079 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10080 (update_hints_inhibit): Remove; never set. All uses removed.
10081 * widgetprv.h (emacsFrameClassRec): Remove decl.
10082 * window.c (delete_deletable_window): Now returns void, since it
10083 wasn't returning anything.
10084 (compare_window_configurations): Remove unused locals.
10085 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10086 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
10087 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10088 the same widths as pointers. This follows up on the 2011-05-06 patch.
10089 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10090 * xterm.h: Likewise.
10091 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10093 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
10095 * makefile.w32-in: Update dependencies.
10096 (LISP_H): Add lib/intprops.h.
10098 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
10100 * image.c (gif_load): Add animation frame delay to the metadata.
10101 (syms_of_image): Use DEFSYM. New symbol `delay'.
10103 2011-06-11 Martin Rudalics <rudalics@gmx.at>
10105 * window.c (delete_deletable_window): Re-add.
10106 (Fset_window_configuration): Rewrite to handle dead buffers and
10107 consequently deletable windows.
10108 (window_tree, Fwindow_tree): Remove. Supply functionality in
10110 (compare_window_configurations): Simplify code.
10112 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10114 * image.c (imagemagick_load_image): Fix type mismatch.
10115 (Fimagemagick_types): Likewise.
10117 * window.h (replace_buffer_in_windows): Declare.
10119 2011-06-11 Martin Rudalics <rudalics@gmx.at>
10121 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10122 Qclone_number. Remove external declaration of Qdelete_window.
10123 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10125 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10126 Run Qbuffer_list_update_hook if allowed.
10127 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10128 buffer list implementation.
10129 (other_buffer_safely): New function.
10130 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10131 calls to replace_buffer_in_windows and
10132 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10134 (record_buffer): Inhibit quitting and rewrite using quittable
10135 functions. Run Qbuffer_list_update_hook if allowed.
10136 (Frecord_buffer, Funrecord_buffer): New functions.
10137 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10138 Move switch-to-buffer to window.el.
10139 (bury-buffer): Move to window.el.
10140 (Vbuffer_list_update_hook): New variable.
10142 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10145 * window.h (resize_frame_windows): Move up in code.
10146 (Fwindow_frame): Remove EXFUN.
10147 (replace_buffer_in_all_windows): Remove prototype.
10148 (replace_buffer_in_windows_safely): Add prototype.
10150 * window.c: Declare Qdelete_window static again. Move down
10151 declaration of select_count.
10152 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10153 (Fother_window): Move to window.el.
10154 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10155 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10156 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10158 (replace_buffer_in_windows): Implement by calling
10159 Qreplace_buffer_in_windows.
10160 (replace_buffer_in_all_windows): Remove with some functionality
10161 moved into replace_buffer_in_windows_safely.
10162 (replace_buffer_in_windows_safely): New function.
10163 (select_window_norecord, select_frame_norecord): Move in front
10164 of run_window_configuration_change_hook. Remove now obsolete
10166 (Fset_window_buffer): Rewrite doc-string.
10167 Call Qrecord_window_buffer.
10168 (keys_of_window): Move binding for other-window to window.el.
10170 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
10172 * dispextern.h (struct image): Replace data member, whose int_val
10173 and ptr_val fields were not used by anything, with a single
10176 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10177 (gif_clear_image, gif_load, imagemagick_load_image)
10178 (gs_clear_image, gs_load): Callers changed.
10180 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10182 * buffer.h: Include <time.h>, for time_t.
10183 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10185 Fix minor problems found by static checking.
10187 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10189 Make identifiers static if they are not used in other modules.
10190 * data.c (Qcompiled_function, Qframe, Qvector):
10191 * image.c (QimageMagick, Qsvg):
10192 * minibuf.c (Qmetadata):
10193 * window.c (resize_window_check, resize_root_window): Now static.
10194 * window.h (resize_window_check, resize_root_window): Remove decls.
10196 * window.c (window_deletion_count, delete_deletable_window):
10198 (window_body_lines): Now static.
10199 (Fdelete_other_windows_internal): Mark vars as initialized.
10200 Make sure 'resize_failed' is initialized.
10201 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10202 (resize_window_apply): Remove unused local.
10203 * window.h (delete_deletable_window): Remove decl.
10205 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
10206 (imagemagick_load_image): Fix pointer signedness problem by changing
10207 last arg from unsigned char * to char *. All uses changed.
10208 Also, fix a local for similar reasons.
10209 Remove unused locals. Remove locals to avoid shadowing.
10210 (fn_rsvg_handle_free): Remove; unused.
10211 (svg_load, svg_load_image): Fix pointer signedness problem.
10212 (imagemagick_load_image): Don't use garbage pointer image_wand.
10214 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10216 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
10218 * image.c (gif_load): Fix omitted cast error introduced by
10221 2011-06-10 Martin Rudalics <rudalics@gmx.at>
10223 * window.h (resize_proportionally, orig_total_lines)
10224 (orig_top_line): Remove from window structure.
10225 (set_window_height, set_window_width, change_window_heights)
10226 (Fdelete_window): Remove prototypes.
10227 (resize_frame_windows): Remove duplicate declaration.
10229 2011-06-10 Eli Zaretskii <eliz@gnu.org>
10231 * window.h (resize_frame_windows, resize_window_check)
10232 (delete_deletable_window, resize_root_window)
10233 (resize_frame_windows): Declare prototypes.
10235 * window.c (resize_window_apply): Make definition be "static" to
10236 match the prototype.
10238 2011-06-10 Martin Rudalics <rudalics@gmx.at>
10240 * window.c: Remove declarations of Qwindow_size_fixed,
10241 window_min_size_1, window_min_size_2, window_min_size,
10242 size_window, window_fixed_size_p, enlarge_window, delete_window.
10243 Remove static from declaration of Qdelete_window, it's
10244 temporarily needed by Fbury_buffer.
10245 (replace_window): Don't assign orig_top_line and
10247 (Fdelete_window, delete_window): Remove. Window deletion is
10248 handled by window.el.
10249 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10250 Replace Fdelete_window calls with calls to Qdelete_window.
10251 (Fdelete_other_windows): Remove. Deleting other windows is
10252 handled by window.el.
10253 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10254 handled in window.el.
10255 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10256 Window minimum sizes are handled in window.el.
10257 (shrink_windows, size_window, set_window_height)
10258 (set_window_width, change_window_heights, window_height)
10259 (window_width, CURBEG, CURSIZE, enlarge_window)
10260 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10261 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10262 handled in window.el.
10263 (make_dummy_parent): Rename to make_parent_window and give it a
10264 second argument horflag.
10265 (make_window): Don't set resize_proportionally any more.
10266 (Fsplit_window): Remove. Windows are split in window.el.
10267 (save_restore_action, save_restore_orig_size)
10268 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10269 Resize mini windows in window.el.
10270 (grow_mini_window, shrink_mini_window): Implement by calling
10271 Qresize_root_window_vertically, resize_window_check and
10272 resize_window_apply.
10273 (saved_window, Fset_window_configuration, save_window_save):
10274 Do not handle orig_top_line, orig_total_lines, and
10275 resize_proportionally.
10276 (window_min_height, window_min_width): Move to window.el.
10277 (keys_of_window): Move bindings for delete-other-windows,
10278 split-window, delete-window and enlarge-window to window.el.
10280 * buffer.c: Temporarily extern Qdelete_window.
10281 (Fbury_buffer): Temporarily call Qdelete_window instead of
10282 Fdelete_window (Fbury_buffer will move to window.el soon).
10284 * frame.c (set_menu_bar_lines_1): Remove code handling
10285 orig_top_line and orig_total_lines.
10287 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10288 set_window_height but set heights directly.
10289 (change_frame_size_1): Use resize_frame_windows.
10291 * xdisp.c (init_xdisp): Don't use set_window_height but set
10294 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10295 Use resize_frame_windows instead of change_window_heights and run
10296 run_window_configuration_change_hook.
10298 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10299 instead of change_window_heights and run
10300 run_window_configuration_change_hook.
10302 2011-06-09 Martin Rudalics <rudalics@gmx.at>
10304 * window.c (replace_window): Rename second argument REPLACEMENT to
10305 NEW. New third argument SETFLAG. Rewrite.
10306 (delete_window, make_dummy_parent): Call replace_window with
10308 (window_list_1): Move down in code.
10309 (run_window_configuration_change_hook): Move set_buffer part
10310 before select_frame_norecord part in order to unwind correctly.
10311 Rename count1 to count.
10312 (recombine_windows, delete_deletable_window, resize_root_window)
10313 (Fdelete_other_windows_internal)
10314 (Frun_window_configuration_change_hook, make_parent_window)
10315 (resize_window_check, resize_window_apply, Fresize_window_apply)
10316 (resize_frame_windows, Fsplit_window_internal)
10317 (Fdelete_window_internal, Fresize_mini_window_internal):
10319 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10321 2011-06-08 Martin Rudalics <rudalics@gmx.at>
10323 * window.h (window): Add some new members to window structure -
10324 normal_lines, normal_cols, new_total, new_normal, clone_number,
10325 splits, nest, prev_buffers, next_buffers.
10326 (WINDOW_TOTAL_SIZE): Move here from window.c.
10327 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
10329 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10331 (make_dummy_parent): Set new members of windows structure.
10332 (make_window): Move down in code. Handle new members of window
10334 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10335 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10336 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10337 (Fset_window_prev_buffers, Fwindow_next_buffers)
10338 (Fset_window_next_buffers, Fset_window_clone_number):
10340 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10341 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10343 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10344 Argument WINDOW can be now internal window too.
10345 (Fwindow_use_time): Move up in code.
10346 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10347 Rewrite doc-string.
10348 (Fset_window_configuration, saved_window)
10349 (Fcurrent_window_configuration, save_window_save): Handle new
10350 members of window structure.
10351 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10352 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10353 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10354 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10355 Qget_mru_window, Qresize_root_window,
10356 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10357 Qauto_buffer_name; staticpro them.
10359 2011-06-07 Martin Rudalics <rudalics@gmx.at>
10361 * window.c (Fwindow_total_size, Fwindow_left_column)
10362 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10363 (Fwindow_list_1): New functions.
10364 (window_box_text_cols): Replace with window_body_cols.
10365 (Fwindow_width, Fscroll_left, Fscroll_right):
10366 Use window_body_cols instead of window_box_text_cols.
10367 (delete_window, Fset_window_configuration):
10368 Call delete_all_subwindows with window as argument.
10369 (delete_all_subwindows): Take a window as argument and not a
10370 structure. Rewrite.
10371 (window_loop): Remove handling of GET_LRU_WINDOW and
10372 GET_LARGEST_WINDOW.
10373 (Fget_lru_window, Fget_largest_window): Move to window.el.
10375 * window.h: Extern window_body_cols instead of
10376 window_box_text_cols. delete_all_subwindows now takes a
10377 Lisp_Object as argument.
10379 * indent.c (compute_motion, Fcompute_motion):
10380 Use window_body_cols instead of window_box_text_cols.
10382 * frame.c (delete_frame): Call delete_all_subwindows with root
10383 window as argument.
10385 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10387 * fns.c (Fputhash): Document return value.
10389 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
10391 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10393 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10395 Cons<->int and similar integer overflow fixes (Bug#8794).
10397 Check for overflow when converting integer to cons and back.
10398 * charset.c (Fdefine_charset_internal, Fdecode_char):
10399 Use cons_to_unsigned to catch overflow.
10400 (Fencode_char): Use INTEGER_TO_CONS.
10401 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10402 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10403 * data.c (long_to_cons, cons_to_long): Remove.
10404 (cons_to_unsigned, cons_to_signed): New functions.
10405 These signal an error for invalid or out-of-range values.
10406 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10407 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10408 * font.c (Ffont_variation_glyphs):
10409 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10410 * lisp.h: Include <intprops.h>.
10411 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10412 (cons_to_signed, cons_to_unsigned): New decls.
10413 (long_to_cons, cons_to_long): Remove decls.
10414 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10415 (Fprimitive_undo): Use CONS_TO_INTEGER.
10416 * xfns.c (Fx_window_property): Likewise.
10417 * xselect.c: Include <limits.h>.
10418 (x_own_selection, selection_data_to_lisp_data):
10419 Use INTEGER_TO_CONS.
10420 (x_handle_selection_request, x_handle_selection_clear)
10421 (x_get_foreign_selection, Fx_disown_selection_internal)
10422 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10423 (lisp_data_to_selection_data): Use cons_to_unsigned.
10424 (x_fill_property_data): Use cons_to_signed.
10425 Report values out of range.
10427 Check for buffer and string overflow more precisely.
10428 * buffer.h (BUF_BYTES_MAX): New macro.
10429 * lisp.h (STRING_BYTES_MAX): New macro.
10430 * alloc.c (Fmake_string):
10431 * character.c (string_escape_byte8):
10432 * coding.c (coding_alloc_by_realloc):
10433 * doprnt.c (doprnt):
10434 * editfns.c (Fformat):
10436 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10437 since they may not be the same number.
10438 * editfns.c (Finsert_char):
10439 * fileio.c (Finsert_file_contents):
10440 Likewise for BUF_BYTES_MAX.
10442 * image.c: Use ptrdiff_t, not int, for sizes.
10443 (slurp_file): Switch from int to ptrdiff_t.
10445 (slurp_file): Check that file size fits in both size_t (for
10446 malloc) and ptrdiff_t (for sanity and safety).
10448 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10449 if b->modtime has its maximal value.
10451 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10453 Don't assume time_t can fit into int.
10454 * buffer.h (struct buffer.modtime): Now time_t, not int.
10455 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10456 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10458 Minor fixes for signed vs unsigned integers.
10459 * character.h (MAYBE_UNIFY_CHAR):
10460 * charset.c (maybe_unify_char):
10461 * keyboard.c (read_char, reorder_modifiers):
10462 XINT -> XFASTINT, since the integer must be nonnegative.
10463 * ftfont.c (ftfont_spec_pattern):
10464 * keymap.c (access_keymap, silly_event_symbol_error):
10465 XUINT -> XFASTINT, since the integer must be nonnegative.
10466 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10467 since it makes no difference and we prefer signed.
10468 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10469 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10472 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10474 * window.h (Fwindow_frame): Declare.
10476 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10478 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10479 (SPARE_MEMORY): Always define.
10480 (LARGE_REQUEST): Remove.
10481 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10483 2011-06-06 Martin Rudalics <rudalics@gmx.at>
10485 * lisp.h: Move EXFUNS for Fframe_root_window,
10486 Fframe_first_window and Fset_frame_selected_window to window.h.
10488 * window.h: Move EXFUNS for Fframe_root_window,
10489 Fframe_first_window and Fset_frame_selected_window here from
10492 * frame.c (Fwindow_frame, Fframe_first_window)
10493 (Fframe_root_window, Fframe_selected_window)
10494 (Fset_frame_selected_window): Move to window.c.
10495 (Factive_minibuffer_window): Move to minibuf.c.
10496 (Fother_visible_frames_p): New function.
10498 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10500 * window.c (decode_window, decode_any_window): Move up in code.
10501 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10502 (inhibit_frame_unsplittable): Remove unused variable.
10503 (Fwindow_buffer): Move up and rewrite doc-string.
10504 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10505 (Fwindow_prev): New functions.
10506 (Fwindow_frame): Move here from frame.c. Accept any window as
10508 (Fframe_root_window, Fframe_first_window)
10509 (Fframe_selected_window): Move here from frame.c. Accept frame
10510 or arbitrary window as argument. Update doc-strings.
10511 (Fminibuffer_window): Move up in code.
10512 (Fwindow_minibuffer_p): Move up in code and simplify.
10513 (Fset_frame_selected_window): Move here from frame.c.
10515 (Fselected_window, select_window, Fselect_window): Move up in
10516 code. Minor doc-string fixes.
10518 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10520 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10521 Do not assume that spare memory exists; that assumption is valid
10522 only if SYSTEM_MALLOC.
10523 (LARGE_REQUEST): New macro, so that the issue of large requests
10524 is separated from the issue of spare memory.
10526 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10528 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10531 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10533 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10536 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10538 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10540 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10542 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10543 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10545 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
10547 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10549 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
10551 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10552 (x_clipboard_manager_save): Add return value.
10553 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10554 New error handlers.
10555 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10556 Obey Vx_select_enable_clipboard_manager. Catch errors in
10557 x_clipboard_manager_save (Bug#8779).
10558 (Vx_select_enable_clipboard_manager): New variable.
10559 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
10561 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
10563 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10565 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10567 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10568 in the current matrix if keep_current_p is non-zero.
10570 2011-06-04 Eli Zaretskii <eliz@gnu.org>
10572 * bidi.c (bidi_level_of_next_char): Fix last change.
10574 2011-06-03 Eli Zaretskii <eliz@gnu.org>
10576 Support bidi reordering of text covered by display properties.
10578 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10579 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10580 (bidi_cache_search, bidi_cache_iterator_state)
10581 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
10582 (bidi_level_of_next_char, bidi_move_to_visually_next):
10583 Support character positions inside a run of characters covered by a
10585 (bidi_paragraph_init, bidi_resolve_explicit_1)
10586 (bidi_level_of_next_char): Call bidi_fetch_char and
10587 bidi_fetch_char_advance instead of FETCH_CHAR and
10588 FETCH_CHAR_ADVANCE.
10589 (bidi_init_it): Initialize new members.
10590 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10592 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10593 instead of using explicit *_CHAR codes.
10594 (bidi_resolve_explicit, bidi_resolve_weak):
10595 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
10596 bidirectional text is supported only in multibyte buffers.
10597 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10598 it to initialize the frame_window_p member of struct bidi_it.
10599 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10600 (bidi_resolve_explicit, bidi_resolve_weak)
10601 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10602 bidi_it->nchars is non-positive.
10603 (bidi_level_of_next_char): Don't try to lookup the cache for the
10604 next/previous character if nothing is cached there yet, or if we
10605 were just reseat()'ed to a new position.
10607 * xdisp.c (set_cursor_from_row): Set start and stop points
10608 according to the row's direction when priming the loop that looks
10609 for the glyph on which to display cursor.
10610 (single_display_spec_intangible_p): Function deleted.
10611 (display_prop_intangible_p): Reimplement to call
10612 handle_display_spec instead of single_display_spec_intangible_p.
10613 Accept 3 additional arguments needed by handle_display_spec.
10614 This fixes incorrect cursor motion across display property with complex
10615 values: lists, `(when COND...)' forms, etc.
10616 (single_display_spec_string_p): Support property values that are
10617 lists with the argument STRING its top-level element.
10618 (display_prop_string_p): Fix the condition for processing a
10619 property that is a list to be consistent with handle_display_spec.
10620 (handle_display_spec): New function, refactored from the
10621 last portion of handle_display_prop.
10622 (compute_display_string_pos): Accept additional argument
10623 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10624 value of a `display' property is a "replacing spec".
10625 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10626 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10627 the display property, but just return a value indicating whether
10628 the display property will replace the characters it covers.
10629 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10630 frame_window_p members of struct bidi_it.
10631 (compute_display_string_pos, compute_display_string_end):
10633 (push_it): Accept second argument POSITION, where pop_it should
10634 jump to continue iteration.
10635 (reseat_1): Initialize bidi_it.disp_pos.
10637 * keyboard.c (adjust_point_for_property): Adjust the call to
10638 display_prop_intangible_p to its new signature.
10640 * dispextern.h (struct bidi_it): New member frame_window_p.
10641 (bidi_init_it): Update prototypes.
10642 (display_prop_intangible_p): Update prototype.
10643 (compute_display_string_pos, compute_display_string_end):
10644 Declare prototypes.
10645 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10648 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
10650 Malloc failure behavior now depends on size of allocation.
10651 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10652 * lisp.h: Change signatures accordingly.
10653 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10654 All callers changed. (Bug#8762)
10656 * gnutls.c: Use Emacs's memory allocators.
10657 Without this change, the gnutls library would invoke malloc etc.
10658 directly, which causes problems on non-SYNC_INPUT hosts, and which
10659 runs afoul of improving memory_full behavior. (Bug#8761)
10660 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10661 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10662 xfree instead of the default malloc, realloc, free.
10663 (Fgnutls_boot): No need to check for memory allocation failure,
10664 since xmalloc does that for us.
10666 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
10667 * category.c (hash_get_category_set):
10668 * ccl.c (ccl_driver):
10669 * charset.c (Fdefine_charset_internal):
10670 * charset.h (struct charset.hash_index):
10671 * composite.c (get_composition_id, gstring_lookup_cache)
10672 (composition_gstring_put_cache):
10673 * composite.h (struct composition.hash_index):
10674 * dispextern.h (struct image.hash):
10675 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10676 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10677 (hashfn_equal, hashfn_user_defined, make_hash_table)
10678 (maybe_resize_hash_table, hash_lookup, hash_put)
10679 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10680 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10681 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10682 * image.c (make_image, search_image_cache, lookup_image)
10683 (xpm_put_color_table_h):
10684 * lisp.h (struct Lisp_Hash_Table):
10685 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
10686 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
10687 for hashes and hash indexes, instead of 'unsigned' and 'int'.
10688 * alloc.c (allocate_vectorlike):
10689 Check for overflow in vector size calculations.
10690 * ccl.c (ccl_driver):
10691 Check for overflow when converting EMACS_INT to int.
10692 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10693 need to be updated by these changes.
10694 * fns.c (make_hash_table, maybe_resize_hash_table):
10695 Check for integer overflow with large hash tables.
10696 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10697 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10698 (SXHASH_REDUCE): New macro.
10699 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10700 Use it instead of discarding useful hash info with large hash values.
10701 (sxhash_float): New function.
10702 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10703 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
10704 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10705 Rewrite to use FIXNUM_BITS, as this simplifies things.
10706 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10707 Adjust signatures to match updated version of code.
10708 (consing_since_gc): Now EMACS_INT, since a single hash table can
10709 use more than INT_MAX bytes.
10711 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10713 Make it possible to build with GCC-4.6+ -O2 -flto.
10715 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10717 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10719 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10720 Call minibuffer-inactive-mode.
10722 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
10724 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10725 Update dependencies.
10727 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10729 * data.c (init_data): Remove code for UTS, this system is not
10732 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10734 Don't force ./temacs to start in terminal mode.
10736 * frame.c (make_initial_frame): Initialize faces in all cases, not
10737 only when CANNOT_DUMP is defined.
10738 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10740 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10742 * dispnew.c (add_window_display_history): Use const for the string
10743 pointer. Remove declaration, not needed.
10745 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10747 Use 'inline', not 'INLINE'.
10748 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
10749 * alloc.c, fontset.c (INLINE): Remove.
10750 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10751 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10752 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10753 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10754 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10756 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10758 Make it possible to run ./temacs.
10760 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10761 syms_of_callproc does the same thing. Remove test for
10762 "initialized", do it in the caller.
10763 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10765 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10767 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10768 (read_minibuf): Use get_minibuffer.
10769 (syms_of_minibuf): Use DEFSYM.
10770 (Qmetadata): New var.
10771 * data.c (Qbuffer): Don't make it static.
10772 (syms_of_data): Use DEFSYM.
10774 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10776 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10777 (CCL_CODE_MIN): New macro.
10779 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10781 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10783 * eval.c (Qdebug): Now static.
10784 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10785 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10786 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10788 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
10790 * image.c: Various fixes to ImageMagick code comments.
10791 (Fimagemagick_types): Doc fix.
10793 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10795 Minor fixes prompted by GCC 4.6.0 warnings.
10797 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10799 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10800 (x_clipboard_manager_save_all): Move extern decl to ...
10801 * xterm.h: ... here, so that it can be checked for consistency.
10803 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
10805 * xselect.c (x_clipboard_manager_save_frame)
10806 (x_clipboard_manager_save_all): New functions.
10807 (Fx_clipboard_manager_save): Lisp function deleted.
10809 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10810 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10812 * xterm.h: Update prototype.
10814 2011-05-28 William Xu <william.xwl@gmail.com>
10816 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10817 exiting (Bug#8239).
10819 2011-05-28 Jim Meyering <meyering@redhat.com>
10821 Avoid a sign-extension bug in crypto_hash_function.
10822 * fns.c (to_uchar): Define.
10823 (crypto_hash_function): Use it to convert some newly-signed
10824 variables to unsigned, to avoid sign-extension bugs. For example,
10825 without this change, (md5 "truc") would evaluate to
10826 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10827 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
10828 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
10830 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10832 Integer overflow fixes.
10834 * dbusbind.c: Serial number integer overflow fixes.
10835 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
10836 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10837 to hold a serial number that is too large for a fixnum.
10838 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10839 Check for serial numbers out of range. Decode any serial number
10840 that was so large that it became a float. (Bug#8722)
10842 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10843 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10844 Use XFASTINT rather than XUINT when numbers are nonnegative.
10845 (xd_append_arg, Fdbus_method_return_internal):
10846 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10847 arguments, check that Lisp number is nonnegative, rather than
10848 silently wrapping negative numbers around. (Bug#8722)
10849 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
10852 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10854 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10856 ccl: Add integer overflow checks.
10857 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10858 (IN_INT_RANGE): New macros.
10859 (ccl_driver): Use them to check for integer overflow when
10860 decoding a CCL program. Many of the new checks are whether XINT (x)
10861 fits in int; it doesn't always, on 64-bit hosts. The new version
10862 doesn't catch all possible integer overflows, but it's an
10863 improvement. (Bug#8719)
10865 * alloc.c (make_event_array): Use XINT, not XUINT.
10866 There's no need for unsigned here.
10868 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10869 This follows up to the 2011-05-06 change that substituted uintptr_t
10870 for EMACS_INT. This case wasn't caught back then.
10872 Rework Fformat to avoid integer overflow issues.
10873 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10874 now (part of C89). Include <verify.h>.
10875 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10876 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10877 (Fformat): Avoid the prepass trying to compute sizes; it was only
10878 approximate and thus did not catch overflow reliably. Instead, walk
10879 through the format just once, formatting and computing sizes as we go,
10880 checking for integer overflow at every step, and allocating a larger
10881 buffer as needed. Keep track separately whether the format is
10882 multibyte. Keep only the most-recently calculated precision, rather
10883 than them all. Record whether each argument has been converted to
10884 string. Use EMACS_INT, not int, for byte and char and arg counts.
10885 Support field widths and precisions larger than INT_MAX. Avoid
10886 sprintf's undefined behavior with conversion specifications such as %#d
10887 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10888 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10889 formatting out-of-range floating point numbers with int
10890 formats. (Bug#8668)
10892 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10894 * data.c: Avoid integer truncation in expressions involving floats.
10895 * data.c: Include <intprops.h>.
10896 (arith_driver): When there's an integer overflow in an expression
10897 involving floating point, convert the integers to floating point
10898 so that the resulting value does not suffer from catastrophic
10899 integer truncation. For example, on a 64-bit host (* 4
10900 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10901 Do not rely on undefined behavior after integer overflow.
10903 merge count_size_as_multibyte, parse_str_to_multibyte
10904 * character.c, character.h (count_size_as_multibyte):
10905 Rename from parse_str_to_multibyte; all uses changed.
10906 Check for integer overflow.
10907 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10908 since it's now a duplicate of the other. This is more of
10909 a character than a buffer op, so better that it's in character.c.
10910 * fns.c, print.c: Adjust to above changes.
10912 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10914 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10916 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10918 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10919 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10920 (x_clipboard_manager_save): Now static.
10921 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10923 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10924 (crypto_hash_function): Now static.
10925 Fix pointer signedness problems. Avoid unnecessary initializations.
10927 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
10929 * termhooks.h (Vselection_alist): Make it terminal-local.
10931 * terminal.c (create_terminal): Initialize it.
10933 * xselect.c: Support for clipboard managers.
10934 (Vselection_alist): Move to termhooks.h as terminal-local var.
10935 (LOCAL_SELECTION): New macro.
10936 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10937 (symbol_to_x_atom): Remove gratuitous arg.
10938 (x_handle_selection_request, lisp_data_to_selection_data)
10939 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
10940 (x_own_selection, x_get_local_selection, x_convert_selection):
10941 New arg, specifying work frame. Use terminal-local Vselection_alist.
10942 (some_frame_on_display): Delete unused function.
10943 (Fx_own_selection_internal, Fx_get_selection_internal)
10944 (Fx_disown_selection_internal, Fx_selection_owner_p)
10945 (Fx_selection_exists_p): New optional frame arg.
10946 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10947 (x_handle_selection_clear): Don't treat other terminals with the
10948 same keyboard specially. Use the terminal-local Vselection_alist.
10949 (x_clear_frame_selections): Use Frun_hook_with_args.
10951 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10953 * xterm.h: Add support for those atoms.
10955 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
10957 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10958 (converted_selections, conversion_fail_tag): New global variables.
10959 (x_selection_request_lisp_error): Free the above.
10960 (x_get_local_selection): Remove unnecessary code.
10961 (x_reply_selection_request): Args changed; handle arbitrary array
10962 of converted selections stored in converted_selections.
10963 Separate the XChangeProperty and SelectionNotify steps.
10964 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10965 (x_convert_selection): New function.
10966 (x_handle_selection_event): Simplify.
10967 (x_get_foreign_selection): Don't ignore incoming requests while
10968 waiting for an answer; this will fail when we implement
10969 SAVE_TARGETS, and seems unnecessary anyway.
10970 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10971 (Vx_sent_selection_functions): Doc fix.
10973 2011-05-26 Leo Liu <sdl.web@gmail.com>
10975 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10977 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10979 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10981 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10982 for fringe update if it has periodic bitmap.
10983 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
10984 and fringe_bitmap_periodic_p.
10986 * fringe.c (get_fringe_bitmap_data): New function.
10987 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10988 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10989 row. Mark glyph row for fringe update if periodicity changed.
10991 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10992 for fringe update unless it has periodic bitmap.
10994 2011-05-25 Kenichi Handa <handa@m17n.org>
10996 * xdisp.c (get_next_display_element): Set correct it->face_id for
10997 a static composition.
10999 2011-05-24 Leo Liu <sdl.web@gmail.com>
11002 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11004 * fns.c (crypto_hash_function, Fsha1): New function.
11005 (Fmd5): Use crypto_hash_function.
11006 (syms_of_fns): Add Ssha1.
11008 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11010 * gnutls.c: Remove unused macros.
11011 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11012 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11013 Remove macros that are defined and never used.
11014 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11016 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
11018 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11019 (Fx_get_selection_internal): Minor cleanup.
11020 (Fx_own_selection_internal): Rename arguments for consistency with
11023 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11025 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11027 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
11029 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11031 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11033 * dispnew.c (scrolling_window): Don't exclude the case that the
11034 last enabled row in the desired matrix touches the bottom boundary.
11036 2011-05-21 Glenn Morris <rgm@gnu.org>
11038 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
11039 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11040 and add some more files.
11042 2011-05-20 Eli Zaretskii <eliz@gnu.org>
11044 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11045 report_file_error introduced by the change from 2011-05-07.
11047 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11049 * systime.h (Time): Define only if emacs is defined.
11050 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11051 where the include path doesn't have X11/X.h by default. See
11052 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11054 2011-05-20 Kenichi Handa <handa@m17n.org>
11056 * composite.c (find_automatic_composition): Fix previous change.
11058 2011-05-20 Glenn Morris <rgm@gnu.org>
11060 * lisp.mk: New file, split from Makefile.in.
11061 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11062 (shortlisp): Remove.
11063 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11065 2011-05-19 Glenn Morris <rgm@gnu.org>
11067 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11068 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11069 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11070 (lisp): Set the order to that of loadup.el.
11071 (shortlisp): Make it a copy of $lisp.
11072 (SOME_MACHINE_LISP): Remove.
11073 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11074 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11076 2011-05-18 Kenichi Handa <handa@m17n.org>
11078 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11079 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11080 (find_automatic_composition): Mostly rewrite for efficiency.
11082 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
11084 * makefile.w32-in: Update dependencies.
11086 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11088 * menu.c: Include limits.h (fixes the MS-Windows build broken by
11089 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
11091 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
11093 Fix some integer overflow issues, such as string length overflow.
11095 * insdel.c (count_size_as_multibyte): Check for string overflow.
11097 * character.c (lisp_string_width): Check for string overflow.
11098 Use EMACS_INT, not int, for string indexes and lengths; in
11099 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11100 the resulting string length overflows an EMACS_INT; instead,
11101 report a string overflow if no precision given. When checking for
11102 precision exhaustion, use a check that cannot possibly have
11103 integer overflow. (Bug#8675)
11104 * character.h (lisp_string_width): Adjust to new signature.
11106 * alloc.c (string_overflow): New function.
11107 (Fmake_string): Use it. This doesn't change behavior, but saves
11108 a few bytes and will simplify future changes.
11109 * character.c (string_escape_byte8): Likewise.
11110 * lisp.h (string_overflow): New decl.
11112 Fixups, following up to the user-interface timestamp change.
11113 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11114 for UI timestamps, instead of unsigned long.
11115 * msdos.c (mouse_get_pos): Likewise.
11116 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
11117 * w32gui.h (Time): Define by including "systime.h" rather than by
11118 declaring it ourselves. (Bug#8664)
11120 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11121 * image.c (clear_image_cache): Likewise.
11123 * term.c (term_mouse_position): Don't assume time_t wraparound.
11125 Be more systematic about user-interface timestamps.
11126 Before, the code sometimes used 'Time', sometimes 'unsigned long',
11127 and sometimes 'EMACS_UINT', to represent these timestamps.
11128 This change causes it to use 'Time' uniformly, as that's what X uses.
11129 This makes the code easier to follow, and makes it easier to catch
11130 integer overflow bugs such as Bug#8664.
11131 * frame.c (Fmouse_position, Fmouse_pixel_position):
11132 Use Time, not unsigned long, for user-interface timestamps.
11133 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11134 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11135 * keyboard.h (last_event_timestamp): Likewise.
11136 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11137 * menu.h (xmenu_show): Likewise.
11138 * term.c (term_mouse_position): Likewise.
11139 * termhooks.h (struct input_event.timestamp): Likewise.
11140 (struct terminal.mouse_position_hook): Likewise.
11141 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11142 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11143 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11144 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11145 what it was before.
11146 * menu.h, termhooks.h: Include "systime.h", for Time.
11148 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11149 Don't assume that the difference between two unsigned long values
11150 can fit into an integer. At this point, we know button_down_time
11151 <= event->timestamp, so the difference must be nonnegative, so
11152 there's no need to cast the result if double-click-time is
11153 nonnegative, as it should be; check that it's nonnegative, just in
11154 case. This bug is triggered when events are more than 2**31 ms
11155 apart (about 25 days). (Bug#8664)
11157 * xselect.c (last_event_timestamp): Remove duplicate decl.
11158 (x_own_selection): Remove needless cast to unsigned long.
11160 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11161 that always fit in int. Use a sentinel instead of a counter, to
11162 avoid a temp and to allay GCC's concerns about possible int overflow.
11163 * frame.h (struct frame): Use int for menu_bar_items_used
11164 instead of EMACS_INT, since it always fits in int.
11166 * menu.c (grow_menu_items): Check for int overflow.
11168 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11170 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11171 Before, the code was not consistent. These values cannot exceed
11172 2**31 - 1 so there's no need to make them unsigned.
11173 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11174 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11175 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11177 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11179 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11180 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11181 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11182 presumably because the widths might not match.
11184 * window.c (size_window): Avoid needless test at loop start.
11186 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11188 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11190 2011-05-12 Drew Adams <drew.adams@oracle.com>
11192 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11194 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11196 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11197 `width' to `bar_area_x' and `bar_area_width', respectively.
11198 (x_scroll_run): Take account of fringe background extension.
11200 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11201 Rename local vars `left' and `width' to `bar_area_x' and
11202 `bar_area_width', respectively.
11203 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11204 background extension.
11206 2011-05-10 Jim Meyering <meyering@redhat.com>
11208 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11210 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
11212 * image.c (Finit_image_library): Return t for built-in image types,
11213 like pbm and xbm. (Bug#8640)
11215 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11217 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11219 2011-05-07 Eli Zaretskii <eliz@gnu.org>
11221 * w32console.c (Fset_screen_color): Doc fix.
11222 (Fget_screen_color): New function.
11223 (syms_of_ntterm): Defsubr it.
11225 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11226 unlink the temporary file if Fcall_process didn't create it in the
11228 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11229 child process will be redirected to a file specified with `:file'.
11230 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11231 cue to call_process_cleanup not to close that handle.
11233 2011-05-07 Ben Key <bkey76@gmail.com>
11235 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11236 one of two shell specific rules, either bootstrap-temacs-CMD or
11237 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11238 to the previous implementation of the bootstrap-temacs rule.
11239 The bootstrap-temacs-CMD rule is similar to the previous
11240 implementation of the bootstrap-temacs rule except that it
11241 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11244 These changes, along with some changes to nt/configure.bat,
11245 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11246 earlier fix to add support for --cflags and --ldflags options
11247 that include quotes so that it works whether make uses cmd or
11250 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
11252 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11253 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11255 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11256 a string. Handle both cases.
11257 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11258 (Fdbus_register_method): Use Qinvalid_function.
11260 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
11262 * makefile.w32-in: Update dependencies.
11263 (LISP_H): Add inttypes.h and stdin.h.
11264 (PROCESS_H): Add unistd.h.
11266 2011-05-06 Eli Zaretskii <eliz@gnu.org>
11268 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11269 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11271 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
11273 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11275 * term.c (vfatal): Remove stray call to va_end.
11276 It's not needed and the C Standard doesn't allow it here anyway.
11278 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11279 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11281 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11284 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11286 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11288 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11290 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11292 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11294 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11295 * charset.c (Fdefine_charset_internal): Don't initialize
11296 charset.code_space[15]. The value was garbage, on hosts with
11297 32-bit int (Bug#8600).
11299 * lread.c (read_integer): Be more consistent with string-to-number.
11300 Use string_to_number to do the actual conversion; this avoids
11301 rounding errors and fixes some other screwups. Without this fix,
11302 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11303 (digit_to_number): Move earlier, for benefit of read_integer.
11304 Return -1 if the digit is out of range for the base, -2 if it is
11305 not a digit in any supported base. (Bug#8602)
11307 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11309 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11310 to match comment at start of function. This also removes a
11311 GCC warning about overflow in a 32+64-bit port.
11313 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11315 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11316 Reported by Stefan Monnier in
11317 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
11318 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11319 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
11321 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11322 (EMACS_UINTPTR): Likewise, with uintptr_t.
11324 * lisp.h: Prefer 64-bit EMACS_INT if available.
11325 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11326 on 32-bit hosts that have 64-bit int, so that they can access
11328 However, temporarily disable this change unless the temporary
11329 symbol WIDE_EMACS_INT is defined.
11331 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11333 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11334 This removes an assumption that EMACS_INT and long are the same
11335 width as pointers. The assumption is true for Emacs porting targets
11336 now, but we want to make other targets possible.
11337 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11338 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11339 In the rest of the code, change types of integers that hold casted
11340 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11341 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11342 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11343 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11344 No need to cast type when ORing.
11345 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11346 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11347 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11348 assume EMACS_INT is the same width as char *.
11349 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11350 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11351 Remove no-longer-needed casts.
11352 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11353 (xg_tool_bar_help_callback, xg_make_tool_item):
11354 Use EMACS_INTPTR to hold an integer
11355 that will be cast to void *; this can avoid a GCC warning
11356 if EMACS_INT is not the same width as void *.
11357 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11358 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11359 (current_message_1, set_message_1):
11360 Use a local to convert to proper width without a cast.
11361 * xmenu.c (dialog_selection_callback): Likewise.
11363 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11364 Also, don't assume VALBITS / RAND_BITS is less than 5,
11365 and don't rely on undefined behavior when shifting a 1 left into
11367 * lisp.h (get_random): Change signature to match.
11369 * lread.c (hash_string): Use size_t, not int, for hash computation.
11370 Normally we prefer signed values; but hashing is special, because
11371 it's better to use unsigned division on hash table sizes so that
11372 the remainder is nonnegative. Also, size_t is the natural width
11373 for hashing into memory. The previous code used 'int', which doesn't
11374 retain enough info to hash well into very large tables.
11375 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11377 * dbusbind.c: Don't possibly lose pointer info when converting.
11378 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11379 Use XPNTR rather than XHASH, so that the high-order bits of
11380 the pointer aren't lost when converting through void *.
11382 * eval.c (Fautoload): Don't double-shift a pointer.
11384 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11386 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
11388 * gnutls.c (DEF_GNUTLS_FN):
11389 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11391 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11393 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11396 2011-05-05 Eli Zaretskii <eliz@gnu.org>
11398 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11399 New version that can reserve upto 2GB of heap space.
11401 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
11403 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11405 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11407 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11408 `gnutls_certificate_set_x509_key_file'.
11410 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
11412 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11413 Update dependencies.
11415 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11417 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11418 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11419 Remove unused parameter `fildes'.
11420 * process.c (read_process_output, send_process): Don't pass it.
11422 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11424 Fix previous change: the library cache is defined in w32.c.
11425 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11426 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11428 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11430 Implement dynamic loading of GnuTLS on Windows.
11432 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11433 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11434 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11437 * gnutls.c (Qgnutls_dll): Define.
11438 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11439 (gnutls_*): Declare function pointers.
11440 (init_gnutls_functions): New function to initialize function pointers.
11441 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11442 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11443 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11444 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11445 (emacs_gnutls_write, emacs_gnutls_read)
11446 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11447 (Fgnutls_available_p): New function.
11448 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11449 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11450 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11452 * image.c: Include w32.h.
11453 (Vimage_type_cache): Delete.
11454 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11455 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11456 (w32_delayed_load): Move to w32.c.
11458 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11460 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11461 (w32_delayed_load): Move from image.c. When loading a library, record
11462 its filename in the :loaded-from property of the library id.
11463 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11464 Initialize and staticpro them.
11465 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11467 * process.c: Include lisp.h before w32.h, not after.
11468 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11469 instead of gnutls_record_check_pending.
11471 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11473 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11475 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11476 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11479 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11481 * xterm.c (x_set_frame_alpha): Do not set property on anything
11482 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11484 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
11486 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11488 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
11490 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11491 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11492 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11493 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11494 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11495 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11496 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11497 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11498 (Qgnutls_bootprop_callbacks_verify): Make static.
11500 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11502 * callproc.c: Indentation fixup.
11504 * sysdep.c (wait_for_termination_1): Make static.
11505 (wait_for_termination, interruptible_wait_for_termination):
11506 Move after wait_for_termination_1.
11508 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11510 * sysdep.c (interruptible_wait_for_termination): New function
11511 which is like wait_for_termination, but allows keyboard
11514 * callproc.c (Fcall_process): Add (:file "file") as an option for
11516 (Fcall_process_region): Ditto.
11518 2011-04-30 Eli Zaretskii <eliz@gnu.org>
11520 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11521 rather than `XVECTOR (FOO)->size'.
11523 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11524 inttypes.h, as a gnulib replacement is used if it not available in
11527 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11529 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11530 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11531 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11533 * coding.c (coding_alloc_by_realloc): Error out if destination
11534 will grow beyond MOST_POSITIVE_FIXNUM.
11535 (decode_coding_emacs_mule): Abort if there isn't enough place in
11536 charbuf for the composition carryover bytes. Reserve an extra
11537 space for up to 2 characters produced in a loop.
11538 (decode_coding_iso_2022): Abort if there isn't enough place in
11539 charbuf for the composition carryover bytes.
11541 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11543 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11544 aborting when %lld or %lll format is passed.
11545 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11546 %llo or %llx format is passed. (Bug#8545)
11548 * window.c (window_scroll_line_based): Use a marker instead of
11549 simple variables to record original value of point. (Bug#7952)
11551 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11552 produced by %s or %c overflows available buffer space. (Bug#8545)
11554 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11556 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
11557 (SIZE_MAX): Move defn after all includes, as they might #define it.
11559 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11561 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11563 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11565 * keyboard.c (Qdelayed_warnings_hook): Define.
11566 (command_loop_1): Run `delayed-warnings-hook'
11567 if Vdelayed_warnings_list is non-nil.
11568 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11569 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11571 2011-04-28 Eli Zaretskii <eliz@gnu.org>
11573 * doprnt.c (doprnt): Don't return value smaller than the buffer
11574 size if the message was truncated. (Bug#8545).
11576 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11578 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11579 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11581 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11583 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11585 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
11587 * makefile.w32-in: Update dependencies.
11589 2011-04-27 Eli Zaretskii <eliz@gnu.org>
11591 Improve `doprnt' and its usage. (Bug#8545)
11592 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11593 `format_end'. Remove support for %l as a conversion specifier.
11594 Don't use xrealloc. Improve diagnostics when the %l size modifier
11595 is used. Update the commentary.
11597 * eval.c (verror): Simplify calculation of size_t.
11599 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11602 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11604 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11607 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11609 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11610 This makes this file independent of the recent pseudovector change.
11612 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
11614 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11616 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
11617 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
11618 Remove unused local.
11619 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
11621 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
11622 GCC 4.6.0 optimizes based on type-based alias analysis.
11623 For example, if b is of type struct buffer * and v of type struct
11624 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11625 != &v->size, and therefore "v->size = 1; b->size = 2; return
11626 v->size;" must therefore return 1. This assumption is incorrect
11627 for Emacs, since it type-puns struct Lisp_Vector * with many other
11628 types. To fix this problem, this patch adds a new type struct
11629 vectorlike_header that documents the constraints on layout of vectors
11630 and pseudovectors, and helps optimizing compilers not get fooled
11631 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11632 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
11633 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11635 (XSETPVECTYPE): Rewrite in terms of new macro.
11636 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11637 This is a bit clearer, and further avoids the possibility of
11638 undesirable aliasing.
11639 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
11640 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
11641 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11642 since Lisp_Subr is a special case (no "next" field).
11643 (ASIZE): Now uses header.size rather than size.
11644 All previous uses of XVECTOR (foo)->size replaced to use this macro,
11645 to avoid the hassle of writing XVECTOR (foo)->header.size.
11646 (struct vectorlike_header): New type.
11647 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11648 object, to help avoid aliasing.
11649 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11650 (SUBRP): Likewise, since Lisp_Subr is a special case.
11651 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11652 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11653 (struct Lisp_Hash_Table): Combine first two members into a single
11654 struct vectorlike_header member. All uses of "size" and "next" members
11655 changed to be "header.size" and "header.next".
11656 * buffer.h (struct buffer): Likewise.
11657 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11658 * frame.h (struct frame): Likewise.
11659 * process.h (struct Lisp_Process): Likewise.
11660 * termhooks.h (struct terminal): Likewise.
11661 * window.c (struct save_window_data, struct saved_window): Likewise.
11662 * window.h (struct window): Likewise.
11663 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11664 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11665 * buffer.c (init_buffer_once): Likewise.
11666 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11668 * process.c (Fformat_network_address): Use local var for size,
11671 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11673 Make the Lisp reader and string-to-float more consistent (Bug#8525)
11674 * data.c (atof): Remove decl; no longer used or needed.
11675 (digit_to_number): Move to lread.c.
11676 (Fstring_to_number): Use new string_to_number function, to be
11677 consistent with how the Lisp reader treats infinities and NaNs.
11678 Do not assume that floating-point numbers represent EMACS_INT
11679 without losing information; this is not true on most 64-bit hosts.
11680 Avoid double-rounding errors, by insisting on integers when
11681 parsing non-base-10 numbers, as the documentation specifies.
11682 * lisp.h (string_to_number): New decl, replacing ...
11683 (isfloat_string): Remove.
11684 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
11685 (read1): Do not accept +. and -. as integers; this
11686 appears to have been a coding error. Similarly, do not accept
11687 strings like +-1e0 as floating point numbers. Do not report
11688 overflow for integer overflows unless the base is not 10 which
11689 means we have no simple and reliable way to continue.
11690 Break out the floating-point parsing into a new
11691 function string_to_number, so that Fstring_to_number parses
11692 floating point numbers consistently with the Lisp reader.
11693 (digit_to_number): Move here from data.c. Make it static inline.
11694 (E_CHAR, EXP_INT): Remove, replacing with ...
11695 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11696 (string_to_number): New function, replacing isfloat_string.
11697 This function checks for valid syntax and produces the resulting
11698 Lisp float number too. Rework it so that string-to-number
11699 no longer mishandles examples like "1.0e+". Use strtoumax,
11700 so that overflow for non-base-10 numbers is reported only when
11701 there's no portable and simple way to convert to floating point.
11703 * textprop.c (set_text_properties_1): Rewrite for clarity,
11704 and to avoid GCC warning about integer overflow.
11706 * intervals.h (struct interval): Use EMACS_INT for members
11707 where EMACS_UINT might cause problems. See
11708 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11709 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11710 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11712 (offset_intervals): Tell GCC not to worry about length overflow
11713 when negating a negative length.
11715 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11716 (overrun_check_free): Likewise.
11718 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11719 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11722 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11723 (gnutls_make_error): Rename local to avoid shadowing.
11724 (gnutls_emacs_global_deinit): ifdef out; not used.
11725 (Fgnutls_boot): Use const for pointer to readonly storage.
11726 Comment out unused local. Fix pointer signedness problems.
11728 * lread.c (openp): Don't stuff size_t into an 'int'.
11729 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11730 about possible signed overflow.
11732 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11733 (GDK_KEY_g): Don't define if already defined.
11734 (xg_prepare_tooltip): Avoid pointer signedness problem.
11735 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11737 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11738 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11740 * xfns.c (Fx_window_property): Simplify a bit,
11741 to make a bit faster and to avoid GCC 4.6.0 warning.
11742 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11744 * fns.c (internal_equal): Don't assume size_t fits in int.
11746 * alloc.c (compact_small_strings): Tighten assertion a little.
11748 Replace pEd with more-general pI, and fix some printf arg casts.
11749 * lisp.h (pI): New macro, generalizing old pEd macro to other
11750 conversion specifiers. For example, use "...%"pI"d..." rather
11751 than "...%"pEd"...".
11752 (pEd): Remove. All uses replaced with similar uses of pI.
11753 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
11754 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11755 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11756 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11757 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11758 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11759 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11761 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11762 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11763 * print.c (safe_debug_print, print_object): Likewise.
11764 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11766 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11767 avoiding the 0 flag, which is not portable.
11768 * process.c (Fmake_network_process): Use pI to avoid cast.
11769 * region-cache.c (pp_cache): Likewise.
11770 * xdisp.c (decode_mode_spec): Likewise.
11771 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11772 behavior on 64-bit hosts with printf arg.
11773 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
11774 (x_stop_queuing_selection_requests): Likewise.
11775 (x_get_window_property): Don't truncate byte count to an 'int'
11778 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11779 here, since it parses constructs like leading '-' and spaces,
11780 which are not wanted; and it overflows with large numbers.
11781 Instead, simply match F[0-9]+, which is what is wanted anyway.
11783 * alloc.c: Remove unportable assumptions about struct layout.
11784 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11785 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11786 (allocate_vectorlike, make_pure_vector): Use the new macros,
11787 plus offsetof, to remove unportable assumptions about struct layout.
11788 These assumptions hold on all porting targets that I know of, but
11789 they are not guaranteed, they're easy to remove, and removing them
11790 makes further changes easier.
11792 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11793 This doesn't fix a bug but makes the code clearer.
11794 (string_overrun_cookie): Now const. Use initializers that
11795 don't formally overflow signed char, to avoid warnings.
11796 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11797 can cause Emacs to crash when string overrun checking is enabled.
11798 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11799 multiple of sizeof (EMACS_INT); it need not be, if
11800 alignof(EMACS_INT) < sizeof (EMACS_INT).
11801 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
11803 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
11805 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11807 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11809 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
11810 supposed to be handshaking. (Bug#8556)
11811 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11813 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
11815 * lisp.h (Qdebug): List symbol.
11816 * eval.c (Qdebug): Restore global linkage.
11817 * keyboard.c (debug-on-event): New variable.
11818 (handle_user_signal): Break into debugger when debug-on-event
11819 matches the current signal symbol.
11821 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11823 * alloc.c (check_sblock, check_string_bytes)
11824 (check_string_free_list): Convert to standard C.
11826 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11828 * w32.c (emacs_gnutls_push): Fix typo.
11830 2011-04-25 Eli Zaretskii <eliz@gnu.org>
11832 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11833 "cast to pointer from integer of different size".
11835 Improve doprnt and its use in verror. (Bug#8545)
11836 * doprnt.c (doprnt): Document the set of format control sequences
11837 supported by the function. Use SAFE_ALLOCA instead of always
11840 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11841 is one byte too soon. Don't use xrealloc; instead xfree and
11844 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11846 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11849 * gnutls.c: Renamed global_initialized to
11850 gnutls_global_initialized. Added internals for the
11851 :verify-hostname-error, :verify-error, and :verify-flags
11852 parameters of `gnutls-boot' and documented those parameters in the
11853 docstring. Start callback support.
11854 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11855 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11856 on error. Return error code.
11857 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11858 (emacs_gnutls_read): Likewise.
11859 (Fgnutls_boot): Return handshake error code.
11860 (emacs_gnutls_handle_error): New function.
11861 (wsaerror_to_errno): Likewise.
11863 * w32.h (emacs_gnutls_pull): Add prototype.
11864 (emacs_gnutls_push): Likewise.
11866 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11867 (emacs_gnutls_push): Likewise.
11869 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11871 * process.c (wait_reading_process_output): Check if GnuTLS
11872 buffered some data internally if no FDs are set for TLS
11875 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11876 (LIBS): Link to USER_LIBS.
11877 ($(BLD)/gnutls.$(0)): New target.
11879 2011-04-24 Eli Zaretskii <eliz@gnu.org>
11881 * xdisp.c (handle_single_display_spec): Rename the
11882 display_replaced_before_p argument into display_replaced_p, to
11883 make it consistent with the commentary. Fix typos in the
11886 * textprop.c (syms_of_textprop): Remove dead code.
11887 (copy_text_properties): Delete obsolete commentary about an
11888 interface that was deleted long ago. Fix typos in the description
11891 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11892 to changes in oldXMenu/XMenu.h from 2011-04-16.
11893 <menu_help_message, prev_menu_help_message>: Constify.
11894 (IT_menu_make_room): menu->help_text is now `const char **';
11897 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11898 to changes in oldXMenu/XMenu.h from 2011-04-16.
11899 (struct XMenu): Declare `help_text' `const char **'.
11901 * xfaces.c <Qunspecified>: Make extern again.
11903 * syntax.c: Include sys/types.h before including regex.h, as
11906 * doc.c (get_doc_string): Improve the format passed to `error'.
11908 * doprnt.c (doprnt): Improve commentary.
11910 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11912 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11915 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11916 changes in globals.h immediately force recompilation.
11917 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11918 $(CURDIR)/s/ms-w32.h.
11919 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
11921 * character.c (Fchar_direction): Function deleted.
11922 (syms_of_character): Don't defsubr it.
11923 <char-direction-table>: Deleted.
11925 2011-04-23 Eli Zaretskii <eliz@gnu.org>
11927 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11928 * doprnt.c: Include limits.h.
11929 (SIZE_MAX): New macro.
11930 (doprnt): Return a size_t value. 2nd arg is now size_t.
11931 Many local variables are now size_t instead of int or unsigned.
11932 Improve overflow protection. Support `l' modifier for integer
11933 conversions. Support %l conversion. Don't assume an EMACS_INT
11934 argument for integer conversions and for %c.
11936 * lisp.h (doprnt): Restore prototype.
11938 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11939 $(SRC)/character.h.
11941 * Makefile.in (base_obj): Add back doprnt.o.
11943 * deps.mk (doprnt.o): Add back prerequisites.
11944 (callint.o): Depend on character.h.
11946 * eval.c (internal_lisp_condition_case): Include the handler
11947 representation in the error message.
11948 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11949 when breaking from the loop.
11951 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11953 * callint.c (Fcall_interactively): When displaying error message
11954 about invalid control letter, pass the character's codepoint, not
11955 a pointer to its multibyte form. Improve display of the character
11956 in octal and display also its hex code.
11958 * character.c (char_string): Use %x to display the (unsigned)
11959 codepoint of an invalid character, to avoid displaying a bogus
11962 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11963 `error', not SYMBOL_NAME itself.
11965 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11966 character arguments to `error'.
11968 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11969 to `error' in error message about FINAL_CHAR argument. Make sure
11970 FINAL_CHAR is a character, and use %c when it is passed as
11971 argument to `error'.
11973 2011-04-23 Eli Zaretskii <eliz@gnu.org>
11975 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11977 * w32.c: Include <time.h>.
11978 (sys_localtime): New function.
11980 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
11982 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11984 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
11986 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
11988 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11989 zombies (Bug#8467).
11991 2011-04-19 Eli Zaretskii <eliz@gnu.org>
11993 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11994 gl_state.e_property when gl_state.object is Qt.
11996 * insdel.c (make_gap_larger): Remove limitation of buffer size
11999 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
12001 * xdisp.c (lookup_glyphless_char_display)
12002 (produce_glyphless_glyph): Handle cons cell entry in
12003 glyphless-char-display.
12004 (Vglyphless_char_display): Document it.
12006 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12007 glyphless-char-display.
12009 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
12011 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12013 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12015 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12016 definition for no-X builds.
12018 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
12020 Static checks with GCC 4.6.0 and non-default toolkits.
12022 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12024 * process.c (keyboard_bit_set): Define only if SIGIO.
12025 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12026 (send_process): Repair possible setjmp clobbering.
12028 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12030 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12032 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12034 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12035 Define only if needed.
12037 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12038 by pacifying GCC about it. Maybe it's time to retire it?
12039 * xfaces.c (USG, __TIMEVAL__): Likewise.
12041 * dispextern.h (struct redisplay_interface): Rename param
12042 to avoid shadowing.
12043 * termhooks.h (struct terminal): Likewise.
12044 * xterm.c (xembed_send_message): Likewise.
12046 * insdel.c (make_gap_smaller): Define only if
12047 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12049 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12052 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12053 so that we aren't warned about unused symbols.
12055 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12057 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
12059 * xfns.c (x_real_positions): Mark locals as initialized.
12061 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12063 * xterm.c: Fix problems found by static analysis with other toolkits.
12064 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
12065 (x_dispatch_event): Declare static if USE_GTK, and
12066 define if USE_GTK || USE_X_TOOLKIT.
12067 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
12068 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
12069 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12070 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
12072 * xmenu.c (menu_help_callback): Pointer type fixes.
12073 Use const pointers when pointing at readonly data. Avoid pointer
12074 signedness clashes.
12075 (FALSE): Remove unused macro.
12076 (update_frame_menubar): Remove unused decl.
12078 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12080 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12081 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12082 (single_menu_item): Rename local to avoid shadowing.
12084 * keyboard.c (make_lispy_event): Remove unused local var.
12086 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12087 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12089 * bitmaps: Change bitmaps from unsigned char back to the X11
12090 compatible char. Avoid the old compiler warnings about
12091 out-of-range initializers by using, for example, '\xab' rather
12094 * xgselect.c (xgselect_initialize): Check vs interface
12095 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12097 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12099 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12100 to read-only memory.
12102 * fns.c (vector): Remove; this old hack is no longer needed.
12104 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
12106 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
12108 * xrdb.c (x_load_resources): Omit unused local.
12110 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
12111 (x_window): Rename locals to avoid shadowing.
12112 (USG): Use the kludged USG macro, to pacify gcc.
12114 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
12115 (x_term_init): Remove local to avoid shadowing.
12117 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
12119 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12120 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12122 2011-04-16 Eli Zaretskii <eliz@gnu.org>
12124 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12126 Fix regex.c, syntax.c and friends for buffers > 2GB.
12127 * syntax.h (struct gl_state_s): Declare character position members
12130 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12132 * textprop.c (verify_interval_modification, interval_of):
12133 Declare arguments EMACS_INT.
12135 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12138 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12140 * indent.c (Fvertical_motion): Local variable it_start is now
12143 * regex.c (re_match, re_match_2, re_match_2_internal)
12144 (bcmp_translate, regcomp, regexec, print_double_string)
12145 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12146 (re_compile_pattern, re_exec): Declare arguments and local
12147 variables `size_t' and `ssize_t' and return values `regoff_t', as
12149 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12150 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12151 <compile_stack_type>: `size' and `avail' are now `size_t'.
12153 * regex.h <regoff_t>: Use ssize_t, not int.
12154 (re_search, re_search_2, re_match, re_match_2): Arguments that
12155 specify buffer/string position and length are now ssize_t and
12156 size_t. Return type is regoff_t.
12158 2011-04-16 Ben Key <bkey76@gmail.com>
12160 * nsfont.m: Fixed bugs in ns_get_family and
12161 ns_descriptor_to_entity that were caused by using free to
12162 deallocate memory blocks that were allocated by xmalloc (via
12163 xstrdup). This caused Emacs to crash when compiled with
12164 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12165 --enable-checking=xmallocoverrun). xfree is now used to
12166 deallocate these memory blocks.
12168 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
12170 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12172 emacs_write: Accept and return EMACS_INT for sizes.
12173 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12175 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12176 Accept and return EMACS_INT.
12177 (emacs_gnutls_write): Return the number of bytes written on
12179 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
12180 (emacs_read, emacs_write): Remove check for negative size, as the
12181 Emacs source code has been audited now.
12182 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12183 (emacs_read, emacs_write): Use it.
12184 * process.c (send_process): Adjust to the new signatures of
12185 emacs_write and emacs_gnutls_write. Do not attempt to store
12186 a byte offset into an 'int'; it might overflow.
12187 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
12189 * sound.c: Don't assume sizes fit in 'int'.
12190 (struct sound_device.period_size, alsa_period_size):
12191 Return EMACS_INT, not int.
12192 (struct sound_device.write, vox_write, alsa_write):
12193 Accept EMACS_INT, not int.
12194 (wav_play, au_play): Use EMACS_INT to store sizes and to
12195 record read return values.
12197 2011-04-15 Ben Key <bkey76@gmail.com>
12199 * keyboard.c (Qundefined): Don't declare static since it is used
12201 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12202 static since they are used in nsfont.m.
12204 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12206 * process.c (Qprocessp): Don't declare static.
12207 * lisp.h (Qprocessp): Declare again.
12209 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
12211 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12213 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12215 Improve C-level modularity by making more things 'static'.
12217 Don't publish debugger-only interfaces to other modules.
12218 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12219 (verify_bytepos, count_markers): Move decls to the only modules
12221 * region-cache.h (pp_cache): Likewise.
12222 * window.h (check_all_windows): Likewise.
12223 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12225 * sysdep.c (croak): Now static, if
12226 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12227 * syssignal.h (croak): Declare only if not static.
12229 * alloc.c (refill_memory_reserve): Now static if
12230 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12231 * lisp.h (refill_memory_reserve): Declare only if not static.
12233 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12234 Define only if USE_LUCID.
12236 * xrdb.c (x_customization_string, x_rm_string): Now static.
12238 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12239 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12241 * xdisp.c (draw_row_with_mouse_face): Now static.
12242 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12244 * window.h (check_all_windows): Mark externally visible.
12246 * window.c (window_deletion_count): Now static.
12248 * undo.c: Make symbols static if they're not exported.
12249 (last_undo_buffer, last_boundary_position, pending_boundary):
12252 * textprop.c (interval_insert_behind_hooks): Now static.
12253 (interval_insert_in_front_hooks): Likewise.
12255 * term.c: Make symbols static if they're not exported.
12256 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12257 (max_frame_lines, tty_set_terminal_modes):
12258 (tty_reset_terminal_modes, tty_turn_off_highlight):
12259 (get_tty_terminal): Now static.
12260 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12261 * termhooks.h (term_mouse_moveto): Do not declare if
12262 HAVE_WINDOW_SYSTEM.
12263 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12264 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12266 * sysdep.c: Make symbols static if they're not exported.
12267 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12269 (sigprocmask_set, full_mask): Remove; unused.
12270 (wait_debugging): Mark as visible.
12271 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12272 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12274 * syntax.c (syntax_temp): Define only if !__GNUC__.
12276 * sound.c (current_sound_device, current_sound): Now static.
12278 * search.c (searchbufs, searchbuf_head): Now static.
12280 * scroll.c (scroll_cost): Remove; unused.
12281 * dispextern.h (scroll_cost): Remove decl.
12283 * region-cache.h (pp_cache): Mark as externally visible.
12285 * process.c: Make symbols static if they're not exported.
12286 (process_tick, update_tick, create_process, chan_process):
12287 (Vprocess_alist, proc_buffered_char, datagram_access):
12288 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12289 (deactivate_process): Mark defn as static, as well as decl.
12290 * lisp.h (create_process): Remove decl.
12291 * process.h (chan_process, Vprocess_alist): Remove decls.
12293 * print.c: Make symbols static if they're not exported.
12294 (print_depth, new_backquote_output, being_printed, print_buffer):
12295 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12296 (print_interval, print_number_index, initial_stderr_stream):
12298 * lisp.h (Fprinc): Remove decl.
12299 (debug_output_compilation_hack): Mark as externally visible.
12301 * sysdep.c (croak): Move decl from here to syssignal.h.
12302 * syssignal.h (croak): Put it here, so the API can be checked when
12303 'croak' is called from dissociate_if_controlling_tty.
12305 * minibuf.c: Make symbols static if they're not exported.
12306 (minibuf_save_list, choose_minibuf_frame): Now static.
12307 * lisp.h (choose_minibuf_frame): Remove decl.
12309 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12311 * lread.c: Make symbols static if they're not exported.
12312 (read_objects, initial_obarray, oblookup_last_bucket_number):
12314 (make_symbol): Remove; unused.
12315 * lisp.h (initial_obarray, make_symbol): Remove decls.
12317 * keyboard.c: Make symbols static if they're not exported.
12318 (single_kboard, recent_keys_index, total_keys, recent_keys):
12319 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12320 (this_single_command_key_start, echoing, last_auto_save):
12321 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12322 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12323 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12324 (Vlispy_mouse_stem, double_click_count):
12326 (force_auto_save_soon): Define only if SIGDANGER.
12327 (ignore_mouse_drag_p): Now static if
12328 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12329 (print_help): Remove; unused.
12330 (stop_character, last_timer_event): Mark as externally visible.
12331 * keyboard.h (ignore_mouse_drag_p): Declare only if
12332 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12333 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12334 * lisp.h (echoing): Remove decl.
12335 (force_auto_save_soon): Declare only if SIGDANGER.
12336 * xdisp.c (redisplay_window): Simplify code, to make it more
12337 obvious that ignore_mouse_drag_p is not accessed if !defined
12338 USE_GTK && !defined HAVE_NS.
12340 * intervals.c: Make symbols static if they're not exported.
12341 (merge_properties_sticky, merge_interval_right, delete_interval):
12343 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12345 * insdel.c: Make symbols static if they're not exported.
12346 However, leave prepare_to_modify_buffer alone. It's never
12347 called from outside this function, but that appears to be a bug.
12348 (combine_after_change_list, combine_after_change_buffer):
12349 (adjust_after_replace, signal_before_change): Now static.
12350 (adjust_after_replace_noundo): Remove; unused.
12351 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
12352 (signal_before_change): Remove decls.
12354 * indent.c (val_compute_motion, val_vmotion): Now static.
12356 * image.c: Make symbols static if they're not exported.
12357 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12359 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12360 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12362 * fringe.c (standard_bitmaps): Now static.
12363 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12365 * frame.c: Make symbols static if they're not exported.
12366 (x_report_frame_params, make_terminal_frame): Now static.
12367 (get_frame_param): Now static, unless HAVE_NS.
12368 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12369 (x_get_resource_string): Remove; not used.
12370 * frame.h (make_terminal_frame, x_report_frame_params):
12371 (x_get_resource_string); Remove decls.
12372 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12373 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12375 * font.c, fontset.c: Make symbols static if they're not exported.
12376 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12377 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12378 * font.c (font_close_object): Now static.
12379 * font.h (font_close_object): Remove.
12380 * fontset.c (FONTSET_OBJLIST): Remove.
12381 (free_realized_fontset) #if-0 the body, which does nothing.
12382 (face_suitable_for_char_p): #if-0, as it's never called.
12383 * fontset.h (face_suitable_for_char_p): Remove decl.
12384 * xfaces.c (face_at_string_position):
12385 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
12386 since 0 is always ASCII.
12388 * fns.c (weak_hash_tables): Now static.
12390 * fileio.c: Make symbols static if they're not exported.
12391 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12392 (Vwrite_region_annotation_buffers): Now static.
12394 * eval.c: Make symbols static if they're not exported.
12395 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12396 * lisp.h (backtrace_list): Remove decl.
12398 * emacs.c: Make symbols static if they're not exported.
12399 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12400 (fatal_error_code, fatal_error_signal_hook, standard_args):
12402 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12403 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12404 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12405 * lisp.h (fatal_error_signal_hook): Remove decl.
12406 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12408 * editfns.c: Move a (normally-unused) function to its only use.
12409 * editfns.c, lisp.h (get_operating_system_release): Remove.
12410 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12411 worth the hassle of breaking this out.
12413 * xterm.c: Make symbols static if they're not exported.
12414 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12415 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12416 (x_destroy_window, x_delete_display):
12418 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12419 (x_mouse_leave): Remove; unused.
12420 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12421 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12422 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12424 (x_mouse_leave): Declare only if WINDOWSNT.
12425 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12426 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12429 * ftxfont.c: Make symbols static if they're not exported.
12430 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12432 * font.h (ftxfont_driver): Likewise.
12434 * xfns.c: Make symbols static if they're not exported.
12435 (x_last_font_name, x_display_info_for_name):
12436 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12437 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12438 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12439 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12440 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12441 (last_show_tip_args): Now static.
12442 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12443 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12444 (x_screen_planes): Remove; unused.
12445 * dispextern.h (x_screen_planes): Remove decl.
12447 * dispnew.c: Make symbols static if they're not exported.
12448 * dispextern.h (redraw_garbaged_frames, scrolling):
12449 (increment_row_positions): Remove.
12450 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12451 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12453 (redraw_garbaged_frames): Remove; unused.
12455 * xfaces.c: Make symbols static if they're not exported.
12456 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12458 * xterm.h (defined_color): Remove decls.
12459 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12460 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12461 (menu_face_changed_default, defined_color, free_realized_face):
12462 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12463 (ascii_face_of_lisp_face): Remove; unused.
12465 * xdisp.c: Make symbols static if they're not exported.
12466 * dispextern.h (scratch_glyph_row, window_box_edges):
12467 (glyph_to_pixel_coords, set_cursor_from_row):
12468 (get_next_display_element, set_iterator_to_next):
12469 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12470 (show_mouse_face): Remove decls
12471 * frame.h (message_buf_print): Likewise.
12472 * lisp.h (pop_message, set_message, check_point_in_composition):
12474 * xterm.h (set_vertical_scroll_bar): Likewise.
12475 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12476 (message_buf_print, scratch_glyph_row, displayed_buffer):
12477 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12478 (get_next_display_element, show_mouse_face, window_box_edges):
12479 (frame_to_window_pixel_xy, check_point_in_composition):
12480 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12481 (glyph_to_pixel_coords): Remove; unused.
12483 * dired.c (file_name_completion): Now static.
12485 * dbusbind.c (xd_in_read_queued_messages): Now static.
12487 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12488 * data.c (circular_list_error): Remove.
12490 * commands.h (last_point_position, last_point_position_buffer):
12491 (last_point_position_window): Remove decls.
12492 * keyboard.c: Make these variables static.
12494 * coding.h (coding, code_convert_region, encode_coding_gap):
12496 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12497 (iso_code_class, detect_coding, code_convert_region): Now static.
12498 (encode_coding_gap): Remove; unused.
12500 * chartab.c (chartab_chars, chartab_bits): Now static.
12502 * charset.h (charset_iso_8859_1): Remove decl.
12503 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12506 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12507 * ccl.c (Vccl_program_table): Now static.
12508 (check_ccl_update): Remove; unused.
12510 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12511 * category.h: ... from here.
12512 * category.c (check_category_table, set_category_set): Now static.
12514 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12515 * lisp.h: Remove these decls.
12517 * buffer.c (buffer_count): Remove unused var.
12519 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12520 so that it's not optimized away.
12521 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12522 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12523 exported only to the debugger.
12525 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
12526 * atimer.h (run_all_atimers): Remove; not exported.
12528 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12529 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12530 was inaccessible from Lisp.
12531 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12532 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12534 alloc.c: Import and export fewer symbols, and remove unused items.
12535 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12537 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12538 it's not optimized away by whole-program optimization.
12539 (message_enable_multibyte, free_misc): Remove.
12540 (catchlist, handlerlist, mark_backtrace):
12541 Declare only if BYTE_MARK_STACK.
12542 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12543 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12544 (message_enable_multibyte): Remove decl.
12545 (free_misc, interval_free_list, float_block, float_block_index):
12546 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12547 (cons_free_list, last_marked_index):
12549 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12550 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12551 (mark_backtrace): Define only if BYTE_MARK_STACK.
12552 * xdisp.c (message_enable_multibyte): Now static.
12554 Declare Lisp_Object Q* variables to be 'static' if not exported.
12555 This makes it easier for human readers (and static analyzers)
12556 to see whether these variables are used from other modules.
12557 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12558 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12559 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12560 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12561 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12562 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12563 * xmenu.c, xselect.c:
12564 Declare Q* vars static if they are not used in other modules.
12565 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12566 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12567 Remove decls of unexported vars.
12568 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12570 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12572 Make Emacs functions such as Fatom 'static' by default.
12573 This makes it easier for human readers (and static analyzers)
12574 to see whether these functions can be called from other modules.
12575 DEFUN now defines a static function. To make the function external
12576 so that it can be used in other C modules, use the new macro DEFUE.
12577 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12578 (Finit_image_library):
12579 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12580 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12581 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12582 Remove decls, since these functions are now static.
12583 (Funintern, Fget_internal_run_time): New decls, since these functions
12584 were already external.
12586 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12587 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12588 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12589 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12590 * keyboard.c, keymap.c, lread.c:
12591 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12592 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12593 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12594 Mark functions with DEFUE instead of DEFUN,
12595 if they are used in other modules.
12596 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12597 decls for now-static functions.
12598 * buffer.h (Fdelete_overlay): Remove decl.
12599 * callproc.c (Fgetenv_internal): Mark as internal.
12600 * composite.c (Fremove_list_of_text_properties): Remove decl.
12601 (Fcomposition_get_gstring): New forward static decl.
12602 * composite.h (Fcomposite_get_gstring): Remove decl.
12603 * dired.c (Ffile_attributes): New forward static decl.
12604 * doc.c (Fdocumntation_property): New forward static decl.
12605 * eval.c (Ffetch_bytecode): New forward static decl.
12606 (Funintern): Remove extern decl; now in .h file where it belongs.
12607 * fileio.c (Fmake_symbolic_link): New forward static decl.
12608 * image.c (Finit_image_library): New forward static decl.
12609 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12610 * intervals.h (Fprevious_property_change):
12611 (Fremove_list_of_text_properties): Remove decls.
12612 * keyboard.c (Fthis_command_keys): Remove decl.
12613 (Fcommand_execute): New forward static decl.
12614 * keymap.c (Flookup_key): New forward static decl.
12615 (Fcopy_keymap): Now static.
12616 * keymap.h (Flookup_key): Remove decl.
12617 * process.c (Fget_process): New forward static decl.
12618 (Fprocess_datagram_address): Mark as internal.
12619 * syntax.c (Fsyntax_table_p): New forward static decl.
12620 (skip_chars): Remove duplicate decl.
12621 * textprop.c (Fprevious_property_change): New forward static decl.
12622 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12624 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12625 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12627 * editfns.c (Fformat): Remove unreachable code.
12629 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12631 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12634 2011-04-13 Eli Zaretskii <eliz@gnu.org>
12636 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12637 when at ZV. (Bug#8487)
12639 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12641 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12643 * keyboard.c (parse_tool_bar_item): Likewise.
12644 * sound.c (sound_cleanup, alsa_close): Likewise.
12645 * termcap.c (tgetent): Likewise.
12646 * xfns.c (x_default_font_parameter): Likewise.
12647 * xsettings.c (read_and_apply_settings): Likewise.
12649 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12650 (overrun_check_free): Protoize.
12652 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12654 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12655 since callers should never pass a negative size.
12656 Change the signature to match that of plain 'read' and 'write'; see
12657 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12658 * lisp.h: Update prototypes of emacs_write and emacs_read.
12660 2011-04-11 Eli Zaretskii <eliz@gnu.org>
12662 * xdisp.c (redisplay_window): Don't try to determine the character
12663 position of the scroll margin if the window start point w->startp
12664 is outside the buffer's accessible region. (Bug#8468)
12666 2011-04-10 Eli Zaretskii <eliz@gnu.org>
12668 Fix write-region and its subroutines for buffers > 2GB.
12669 * fileio.c (a_write, e_write): Modify declaration of arguments and
12670 local variables to support buffers larger than 2GB.
12671 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12673 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12674 argument, local variables, and return value.
12676 * lisp.h: Update prototypes of emacs_write and emacs_read.
12678 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12680 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
12682 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12684 Fix more problems found by GCC 4.6.0's static checks.
12686 * xdisp.c (vmessage): Use a better test for character truncation.
12688 * charset.c (load_charset_map): <, not <=, for optimization,
12689 and to avoid potential problems with integer overflow.
12690 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
12691 * casetab.c (set_identity, shuffle): Likewise.
12692 * editfns.c (Fformat): Likewise.
12693 * syntax.c (skip_chars): Likewise.
12695 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12696 This also lets GCC 4.6.0 generate slightly better loop code.
12698 * callint.c (Fcall_interactively): <, not <=, for optimization.
12699 (Fcall_interactively): Count the number of arguments produced,
12700 not the number of arguments given. This is simpler and lets GCC
12701 4.6.0 generate slightly better code.
12703 * ftfont.c: Distingish more carefully between FcChar8 and char.
12704 The previous code passed unsigned char * to a functions like
12705 strlen and xstrcasecmp that expect char *, which does not
12706 conform to the C standard.
12707 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12708 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12709 char * when the C standard requires it.
12711 * keyboard.c (read_char): Remove unused var.
12713 * eval.c: Port to Windows vsnprintf (Bug#8435).
12714 Include <limits.h>.
12715 (SIZE_MAX): Define if the headers do not.
12716 (verror): Do not give up if vsnprintf returns a negative count.
12717 Instead, grow the buffer. This ports to Windows vsnprintf, which
12718 does not conform to C99. Problem reported by Eli Zaretskii.
12719 Also, simplify the allocation scheme, by avoiding the need for
12720 calling realloc, and removing the ALLOCATED variable.
12722 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12724 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12725 But keep the doprint source code for now, as we might revamp it
12726 and use it again (Bug#8435).
12727 * lisp.h (doprnt): Remove.
12728 * Makefile.in (base_obj): Remove doprnt.o.
12729 * deps.mk (doprnt.o): Remove.
12731 error: Print 32- and 64-bit integers portably (Bug#8435).
12732 Without this change, on typical 64-bit hosts error ("...%d...", N)
12733 was used to print both 32- and 64-bit integers N, which relied on
12734 undefined behavior.
12735 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
12736 * lisp.h (error, verror): Mark as printf-like functions.
12737 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12738 Report overflow in size calculations when allocating printf buffer.
12739 Do not truncate output string at its first null byte.
12740 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12741 Truncate the output at a character boundary, since vsnprintf does not
12743 * charset.c (check_iso_charset_parameter): Convert internal
12744 character to string before calling 'error', since %c now has the
12746 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12747 overflow when computing char to be passed to 'error'. Do not
12748 pass Lisp_Object to 'error'; pass the integer instead.
12749 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12750 formatted with plain %d.
12752 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12754 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12756 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12758 * xterm.c (x_catch_errors): Remove duplicate declaration.
12760 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12762 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12764 2011-04-10 Jim Meyering <meyering@redhat.com>
12766 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12767 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12768 return ssize_t not "int", and use size_t as the buffer length.
12769 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12770 * gnutls.h: Update declarations.
12771 * process.c (read_process_output): Use ssize_t, to match.
12772 (send_process): Likewise.
12774 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
12776 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12778 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
12780 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12781 Use unsigned char, to match FcChar8 type definition.
12783 * xterm.c (handle_one_xevent):
12784 * xmenu.c (create_and_show_popup_menu):
12785 * xselect.c (x_decline_selection_request)
12786 (x_reply_selection_request): Avoid type-punned deref of X events.
12788 2011-04-09 Eli Zaretskii <eliz@gnu.org>
12790 Fix some uses of `int' instead of EMACS_INT.
12791 * search.c (string_match_1, fast_string_match)
12792 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12793 (scan_buffer, find_next_newline_no_quit)
12794 (find_before_next_newline, search_command, Freplace_match)
12795 (Fmatch_data): Make some `int' variables be EMACS_INT.
12797 * xdisp.c (display_count_lines): 3rd argument and return value now
12798 EMACS_INT. All callers changed.
12799 (pint2hrstr): Last argument is now EMACS_INT.
12801 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12802 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12803 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12804 (decode_coding_utf_16, decode_coding_emacs_mule)
12805 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12806 (decode_coding_ccl, decode_coding_charset)
12807 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12808 (decode_coding_iso_2022, decode_coding_emacs_mule)
12809 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12810 <char_offset, last_offset>: Declare EMACS_INT.
12811 (encode_coding_utf_8, encode_coding_utf_16)
12812 (encode_coding_emacs_mule, encode_invocation_designation)
12813 (encode_designation_at_bol, encode_coding_iso_2022)
12814 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12815 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12817 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12818 (encode_invocation_designation): Last argument P_NCHARS is now
12820 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12821 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12823 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12826 * ccl.c (Fccl_execute_on_string): Declare some variables
12829 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
12831 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12833 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12835 * process.c (Fformat_network_address): Doc fix.
12837 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12839 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
12841 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
12843 * keyboard.c (read_char): Call Lisp function help-form-show,
12844 instead of using internal_with_output_to_temp_buffer.
12845 (Qhelp_form_show): New var.
12846 (syms_of_keyboard): Use DEFSYM macro.
12848 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12850 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12852 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
12854 * process.c (Flist_processes): Remove to Lisp.
12855 (list_processes_1): Delete.
12857 2011-04-06 Eli Zaretskii <eliz@gnu.org>
12859 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12861 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12863 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
12865 Fix more problems found by GCC 4.6.0's static checks.
12867 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12869 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12871 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
12873 * xdisp.c (vmessage): Mark as a printf-like function.
12875 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12877 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12879 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12880 printf-like functions.
12881 (tiff_load): Add casts to remove these marks before passing them
12882 to system-supplied API.
12884 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12886 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12887 This avoids several warnings with gcc -Wstrict-overflow.
12888 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12889 directly, rather than having caller test rule sign. This avoids
12890 some unnecessary tests.
12891 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12892 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12893 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
12895 * xfont.c (xfont_text_extents): Remove var that was set but not used.
12896 (xfont_open): Avoid unnecessary tests.
12898 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12900 * composite.h, composite.c (composition_gstring_put_cache):
12901 Use EMACS_INT, not int, for length.
12903 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12904 breaking out part of COMPOSITION_DECODE_RULE.
12905 (COMPOSITION_DECODE_RULE): Use it.
12906 * composite.c (get_composition_id): Remove unused local vars,
12907 by using the new macro.
12909 * textprop.c (set_text_properties_1): Change while to do-while,
12910 since the condition is always true at first.
12912 * intervals.c (graft_intervals_into_buffer): Mark var as used.
12913 (interval_deletion_adjustment): Return unsigned value.
12916 * process.c (list_processes_1, create_pty, read_process_output):
12917 (exec_sentinel): Remove vars that were set but not used.
12918 (create_pty): Remove unnecessary "volatile"s.
12919 (Fnetwork_interface_info): Avoid possibility of int overflow.
12920 (read_process_output): Do adaptive read buffering even if carryover.
12921 (read_process_output): Simplify nbytes computation if buffered.
12923 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12925 * syntax.c (scan_words): Remove var that was set but not used.
12926 (update_syntax_table): Use unsigned instead of int.
12928 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
12929 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
12930 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
12932 * print.c (print_error_message): Avoid int overflow.
12934 * font.c (font_list_entities): Redo for clarity,
12935 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12937 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
12938 (font_score): Avoid potential overflow in diff calculation.
12940 * fns.c (substring_both): Remove var that is set but not used.
12941 (sxhash): Redo loop for clarity and to avoid wraparound warning.
12943 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12945 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12946 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12947 can always succeed if overflow has undefined behavior.
12949 * search.c (boyer_moore, wordify): Remove vars set but not used.
12950 (wordify): Omit three unnecessary tests.
12952 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12953 All callers changed. This avoids the need for an unused var.
12955 * casefiddle.c (casify_region): Remove var that is set but not used.
12957 * dired.c (file_name_completion): Remove var that is set but not used.
12959 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12961 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
12962 (Finsert_file_contents): Remove unnecessary code checking fd.
12964 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12965 Check for integer overflow on size calculations.
12967 * buffer.c (Fprevious_overlay_change): Remove var that is set
12970 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12971 Remove vars that are set but not used.
12972 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
12973 (timer_check_2): Mark vars as initialized.
12975 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12977 * image.c (lookup_image): Remove var that is set but not used.
12978 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
12980 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12981 that are set but not used.
12983 * xfns.c (make_invisible_cursor): Don't return garbage
12984 if XCreateBitmapFromData fails (Bug#8410).
12986 * xselect.c (x_get_local_selection, x_handle_property_notify):
12987 Remove vars that are set but not used.
12989 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
12990 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
12992 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12993 Remove var that is set but not used.
12994 (scroll_bar_windows_size): Now size_t, not int.
12995 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12996 Check for overflow.
12998 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12999 (map_tty_color) [!defined MSDOS]: Likewise.
13001 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13003 * coding.c: Remove vars that are set but not used.
13004 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13005 All callers changed.
13006 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13007 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13008 (decode_coding_charset): Remove vars that are set but not used.
13010 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13011 that is set but not used.
13013 * print.c (print_object): Remove var that is set but not used.
13015 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
13016 The gnulib version avoids calling malloc in the usual case,
13017 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13018 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13019 * filelock.c (current_lock_owner): Likewise.
13020 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13021 * sysdep.c: Include allocator.h, careadlinkat.h.
13022 (emacs_no_realloc_allocator): New static constant.
13023 (emacs_readlink): New function.
13024 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13025 ../lib/careadlinkat.h.
13027 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13029 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13030 first non-nil return value).
13032 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13034 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13035 if not defined (Bug#8403).
13037 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
13039 * xdisp.c (display_count_lines): Remove parameter `start',
13040 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13041 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13042 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13043 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13044 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13045 and thereabouts. All callers changed.
13046 (get_per_char_metric): Remove parameter `f', unused since
13047 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13049 2011-04-02 Jim Meyering <meyering@redhat.com>
13051 do not dereference NULL upon failed strdup
13052 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13053 (ns_get_family): Likewise.
13055 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
13057 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13059 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13061 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13064 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13066 Add lexical binding.
13068 * window.c (Ftemp_output_buffer_show): New fun.
13069 (Fsave_window_excursion):
13070 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13072 * lread.c (lisp_file_lexically_bound_p): New function.
13073 (Fload): Bind Qlexical_binding.
13074 (readevalloop): Remove `evalfun' arg.
13075 Bind Qinternal_interpreter_environment.
13076 (Feval_buffer): Bind Qlexical_binding.
13077 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13079 (syms_of_lread): Declare `lexical-binding'.
13081 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13083 * keyboard.c (eval_dyn): New fun.
13084 (menu_item_eval_property): Use it.
13086 * image.c (parse_image_spec): Use Ffunctionp.
13088 * fns.c (concat, mapcar1): Accept byte-code-functions.
13090 * eval.c (Fsetq): Handle lexical vars.
13091 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13092 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13093 (FletX, Flet): Obey lexical binding.
13094 (Fcommandp): Handle closures.
13095 (Feval): New `lexical' arg.
13096 (eval_sub): New function extracted from Feval. Use it almost
13097 everywhere where Feval was used. Look up vars in lexical env.
13099 (Ffunctionp): Move from subr.el.
13100 (Ffuncall): Handle closures.
13101 (apply_lambda): Remove `eval_flags'.
13102 (funcall_lambda): Handle closures and new byte-code-functions.
13103 (Fspecial_variable_p): New function.
13104 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13105 but without exporting it to Lisp.
13107 * doc.c (Fdocumentation, store_function_docstring):
13108 * data.c (Finteractive_form): Handle closures.
13110 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13113 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13115 (exec_byte_code): New function extracted from Fbyte_code to handle new
13116 calling convention for byte-code-functions. Add new byte-codes.
13118 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
13120 * alloc.c (Fmake_symbol): Init new `declared_special' field.
13122 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
13124 * xdisp.c (redisplay_internal): Fix prototype.
13126 2011-03-31 Eli Zaretskii <eliz@gnu.org>
13128 * xdisp.c (SCROLL_LIMIT): New macro.
13129 (try_scrolling): Use it when setting scroll_limit.
13130 Limit scrolling to 100 screen lines.
13131 (redisplay_window): Even when falling back on "recentering",
13132 position point in the window according to scroll-conservatively,
13133 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13135 (try_scrolling): When point is above the window, allow searching
13136 as far as scroll_max, or one screenful, to compute vertical
13137 distance from PT to the scroll margin position. This prevents
13138 try_scrolling from unnecessarily failing when
13139 scroll-conservatively is set to a value slightly larger than the
13140 window height. Clean up the case of PT below the margin at bottom
13141 of window: scroll_max can no longer be INT_MAX. When aggressive
13142 scrolling is in use, don't let point enter the opposite scroll
13143 margin as result of the scroll.
13144 (syms_of_xdisp) <scroll-conservatively>: Document the
13145 threshold of 100 lines for never-recentering scrolling.
13147 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
13149 * dispextern.h (move_it_by_lines):
13150 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13151 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13152 (message_log_check_duplicate): Remove parameters `prev_bol' and
13153 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13154 (redisplay_internal): Remove parameter `preserve_echo_area',
13155 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13157 * indent.c (Fvertical_motion):
13158 * window.c (window_scroll_pixel_based, Frecenter):
13159 Don't pass `need_y_p' to `move_it_by_lines'.
13161 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13163 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13164 steal a few bits to be more compact.
13165 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13166 Remove unneeded casts.
13168 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13170 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13172 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13173 binding" message (bug#7967).
13175 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13177 Fix more problems found by GCC 4.6.0's static checks.
13179 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13180 Remove unused local var.
13182 * editfns.c (Fmessage_box): Remove unused local var.
13184 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13185 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13186 Omit unused local vars.
13187 * window.c (shrink_windows): Omit unused local var.
13188 * menu.c (digest_single_submenu): Omit unused local var.
13189 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13190 Omit unused local var.
13192 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13193 Don't assume string length fits in int.
13194 (keyremap_step, read_key_sequence): Use size_t for sizes.
13195 (read_key_sequence): Don't check last_real_key_start redundantly.
13197 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13198 instead of alloca (Bug#8344).
13200 * eval.c (Fbacktrace): Don't assume nargs fits in int.
13201 (Fbacktrace_frame): Don't assume nframes fits in int.
13203 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13205 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13208 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13210 * cm.c (calccost): Turn while-do into do-while, for clarity.
13212 * keyboard.c (syms_of_keyboard): Use the same style as later
13213 in this function when indexing through an array. This also
13214 works around GCC bug 48267.
13216 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13218 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13220 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13221 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13223 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13224 This avoids undefined behavior on integer overflow, and is a bit
13225 more convenient anyway since it is compared to a size_t variable.
13227 Variadic C functions now count arguments with size_t, not int.
13228 This avoids an unnecessary limitation on 64-bit machines, which
13229 caused (substring ...) to crash on large vectors (Bug#8344).
13230 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13231 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
13232 All variadic functions and their callers changed accordingly.
13233 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13234 * data.c (arith_driver, float_arith_driver): Likewise.
13235 * editfns.c (general_insert_function): Likewise.
13236 * eval.c (struct backtrace.nargs, interactive_p)
13237 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13238 (funcall_lambda, mark_backtrace): Likewise.
13239 * fns.c (concat): Likewise.
13240 * frame.c (x_set_frame_parameters): Likewise.
13241 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13242 0 if not found, not -1. All callers changed.
13244 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13245 (stack_copy_size): Now size_t, not int.
13246 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13248 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
13250 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13251 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13252 All callers changed.
13254 * lisp.h (multibyte_char_to_unibyte):
13255 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13256 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13257 * character.h (CHAR_TO_BYTE8):
13258 * cmds.c (internal_self_insert):
13259 * editfns.c (general_insert_function):
13260 * keymap.c (push_key_description):
13261 * search.c (Freplace_match):
13262 * xdisp.c (message_dolog, set_message_1): All callers changed.
13264 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13266 * keyboard.c (safe_run_hook_funcall): New function.
13267 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13268 don't set the hook to nil, but remove the offending function instead.
13269 (Qcommand_hook_internal): Remove, unused.
13270 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13271 Vcommand_hook_internal.
13273 * eval.c (enum run_hooks_condition): Remove.
13274 (funcall_nil, funcall_not): New functions.
13275 (run_hook_with_args): Call each function through a `funcall' argument.
13276 Remove `cond' argument, now redundant.
13277 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13278 (Frun_hook_with_args_until_failure): Adjust accordingly.
13279 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13281 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
13283 * dispextern.h (string_buffer_position): Remove declaration.
13285 * print.c (strout): Remove parameter `multibyte', unused since
13286 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13288 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13289 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13290 All callers changed.
13292 * w32.c (_wsa_errlist): Use braces for struct initializers.
13294 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13295 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13296 All callers changed.
13297 (string_buffer_position): Likewise. Also, make static (it's never
13298 used outside xdisp.c).
13299 (cursor_row_p): Remove parameter `w', unused since
13300 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13301 (decode_mode_spec): Remove parameter `precision', introduced during
13302 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13303 All callers changed.
13305 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13307 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13309 2011-03-27 Anders Lindgren <andlind@gmail.com>
13311 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13312 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13313 (ns_update_auto_hide_menu_bar): New functions.
13314 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13315 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13316 ns_constrain_all_frames.
13317 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13318 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13320 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13322 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13324 2011-03-27 Glenn Morris <rgm@gnu.org>
13326 * syssignal.h: Replace RETSIGTYPE with void.
13327 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13328 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13329 Replace SIGTYPE with void everywhere.
13330 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13331 * s/template.h (SIGTYPE): Remove commented out definition.
13333 2011-03-26 Eli Zaretskii <eliz@gnu.org>
13335 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13336 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13338 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
13340 * w32.c (read_unc_volume): Use parameter `henum', instead of
13341 global variable `wget_enum_handle'.
13343 * keymap.c (describe_vector): Remove parameters `indices' and
13344 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13345 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13347 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13349 * keyboard.c (timer_check): Remove parameter `do_it_now',
13350 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13351 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13352 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13354 * keyboard.c (read_char):
13355 * w32menu.c (w32_menu_display_help):
13356 * xmenu.c (show_help_event, menu_help_callback):
13357 Adjust calls to `show_help_echo'.
13359 * gtkutil.c (xg_maybe_add_timer):
13360 * keyboard.c (readable_events):
13361 * process.c (wait_reading_process_output):
13362 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13364 * insdel.c (adjust_markers_gap_motion):
13365 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13366 (gap_left, gap_right): Don't call it.
13368 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
13370 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13371 incurred during fontification.
13373 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
13375 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13376 (DEFVAR_PER_BUFFER): Don't pass it.
13378 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13379 (scrolling_window): Don't pass it.
13381 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
13383 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13385 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13387 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13388 of variables specific to SELinux and computation of `encoded_absname'.
13390 * image.c (XPutPixel): Remove unused variable `height'.
13392 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13394 * unexw32.c (get_section_info): Remove unused variable `section'.
13396 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13397 (system_process_attributes): Remove unused variable `sess'.
13398 (sys_read): Remove unused variable `err'.
13400 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13401 (w32_wnd_proc): Remove unused variable `isdead'.
13402 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13403 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13404 (x_create_tip_frame): Remove unused variable `tem'.
13406 * w32inevt.c (w32_console_read_socket):
13407 Remove unused variable `no_events'.
13409 * w32term.c (x_draw_composite_glyph_string_foreground):
13410 Remove unused variable `width'.
13412 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
13414 * w32term.c (x_set_glyph_string_clipping):
13415 Don't pass uninitialized region to CombineRgn.
13417 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
13419 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13420 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13421 (Fx_close_connection): Remove unused variable `i'.
13423 * w32font.c (w32font_draw): Return number of glyphs.
13424 (w32font_open_internal): Remove unused variable `i'.
13425 (w32font_driver): Add missing initializer.
13427 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13428 (fill_in_menu): Remove unused variable `items_added'.
13430 * w32term.c (last_mouse_press_frame): Remove static global variable.
13431 (w32_clip_to_row): Remove unused variable `f'.
13432 (x_delete_terminal): Remove unused variable `i'.
13434 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13435 (NOTHING): Remove unused static global variable.
13436 (uniscribe_check_otf): Remove unused variable `table'.
13437 (uniscribe_font_driver): Add missing initializers.
13439 2011-03-23 Julien Danjou <julien@danjou.info>
13441 * term.c (Fsuspend_tty, Fresume_tty):
13442 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13443 * window.c (temp_output_buffer_show):
13444 * insdel.c (signal_before_change):
13445 * frame.c (Fhandle_switch_frame):
13446 * fileio.c (Fdo_auto_save):
13447 * emacs.c (Fkill_emacs):
13448 * editfns.c (save_excursion_restore):
13449 * cmds.c (internal_self_insert):
13450 * callint.c (Fcall_interactively):
13451 * buffer.c (Fkill_all_local_variables):
13452 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13454 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
13455 unconditionally since it does the check itself.
13457 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
13459 Fix more problems found by GCC 4.5.2's static checks.
13461 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13462 the first time through the loop, since we know p0 < p1 then.
13463 This also avoids a gcc -Wstrict-overflow warning.
13465 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13466 leading to a memory leak, possible in functions like
13467 load_charset_map_from_file that can allocate an unbounded number
13468 of objects (Bug#8318).
13470 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13471 that could (at least in theory) be that large.
13473 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13474 This is less likely to overflow, and avoids undefined behavior if
13475 overflow does occur. All callers changed. Use strtoul to scan
13476 for the unsigned long integer.
13477 (pint2hrstr): Simplify and tune code slightly.
13478 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
13480 * scroll.c (do_scrolling): Work around GCC bug 48228.
13481 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13483 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13484 This also avoids a warning with gcc -Wstrict-overflow.
13485 (validate_x_resource_name): Simplify count usage.
13486 This also avoids a warning with gcc -Wstrict-overflow.
13488 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13491 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
13493 * process.c (Fmake_network_process): Use socklen_t, not int,
13494 where POSIX says socklen_t is required in portable programs.
13495 This fixes a porting bug on hosts like 64-bit HP-UX, where
13496 socklen_t is wider than int (Bug#8277).
13497 (Fmake_network_process, server_accept_connection):
13498 (wait_reading_process_output, read_process_output):
13501 * process.c: Rename or move locals to avoid shadowing.
13502 (list_processes_1, Fmake_network_process):
13503 (read_process_output_error_handler, exec_sentinel_error_handler):
13504 Rename or move locals.
13505 (Fmake_network_process): Define label "retry_connect" only if needed.
13506 (Fnetwork_interface_info): Fix pointer signedness.
13507 (process_send_signal): Add cast to avoid pointer signedness problem.
13508 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
13509 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
13511 Make tparam.h and terminfo.c consistent.
13512 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13513 Include tparam.h instead, since it declares them.
13514 * cm.h (PC): Remove extern decl; tparam.h now does this.
13515 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13516 * terminfo.c: Include tparam.h, to check interfaces.
13517 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13518 (tparam): Adjust signature to match interface in tparam.h;
13519 this removes some undefined behavior. Check that outstring and len
13520 are zero, which they always are with Emacs.
13521 * tparam.h (PC, BC, UP): New extern decls.
13523 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
13524 (xftfont_open): Rename locals to avoid shadowing.
13526 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
13527 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13528 (OTF_TAG_SYM): Omit macro if not needed.
13529 (ftfont_list): Remove unused local.
13530 (get_adstyle_property, ftfont_pattern_entity):
13531 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13532 Rename locals to avoid shadowing.
13534 * xfont.c (xfont_list_family): Mark var as initialized.
13536 * xml.c (make_dom): Now static.
13538 * composite.c (composition_compute_stop_pos): Rename local to
13540 (composition_reseat_it): Remove unused locals.
13541 (find_automatic_composition, composition_adjust_point): Likewise.
13542 (composition_update_it): Mark var as initialized.
13543 (find_automatic_composition): Mark vars as initialized,
13544 with a FIXME (Bug#8290).
13546 character.h: Rename locals to avoid shadowing.
13547 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13548 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13549 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13550 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13551 to avoid shadowing.
13553 * textprop.c (property_change_between_p): Remove; unused.
13555 * intervals.c (interval_start_pos): Now static.
13557 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13559 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13560 Rename locals to avoid shadowing.
13562 * sound.c (wav_play, au_play, Fplay_sound_internal):
13563 Fix pointer signedness.
13564 (alsa_choose_format): Remove unused local var.
13565 (wav_play): Initialize a variable to 0, to prevent undefined
13566 behavior (Bug#8278).
13568 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13570 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13572 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13573 clobbering (Bug#8298).
13574 * sysdep.c (sys_subshell): Likewise.
13575 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
13577 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13578 This should get cleaned up, so that child_setup has the
13579 same signature on all platforms.
13581 * callproc.c (call_process_cleanup): Now static.
13582 (relocate_fd): Rename locals to avoid shadowing.
13584 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
13586 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13587 not to be necessary, and produces flickering.
13589 2011-03-20 Glenn Morris <rgm@gnu.org>
13591 * config.in: Remove file.
13593 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
13595 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13596 are now in src/globals.h.
13597 (syms_of_minibuf): Remove spurious & from previous change.
13599 2011-03-20 Leo Liu <sdl.web@gmail.com>
13601 * minibuf.c (completing-read-function): New variable.
13602 (completing-read-default): Rename from completing-read.
13603 (completing-read): Call completing-read-function.
13605 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
13607 * xfaces.c (Fx_load_color_file):
13608 Read color file from absolute filename (bug#8250).
13610 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
13612 * makefile.w32-in: Update dependencies.
13614 2011-03-17 Eli Zaretskii <eliz@gnu.org>
13616 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13618 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13620 Fix more problems found by GCC 4.5.2's static checks.
13622 * process.c (make_serial_process_unwind, send_process_trap):
13623 (sigchld_handler): Now static.
13625 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13626 That way, the code declares only the vars that it needs.
13627 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13628 * s/cygwin.h (PTY_ITERATION): Likewise.
13629 * s/darwin.h (PTY_ITERATION): Likewise.
13630 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13632 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13633 * process.c (allocate_pty): Don't declare stb unless it's needed.
13635 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
13636 (CONSTANTLIM): Remove; unused.
13637 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13638 Define only if needed.
13640 * unexelf.c (unexec): Name an expression,
13641 to avoid gcc -Wbad-function-cast warning.
13642 Use a different way to cause a compilation error if anyone uses
13643 n rather than nn, a way that does not involve shadowing.
13644 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
13646 * deps.mk (unexalpha.o): Remove; unused.
13648 New file unexec.h, the (simple) interface for unexec (Bug#8267).
13649 * unexec.h: New file.
13650 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13651 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13652 Depend on unexec.h.
13653 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13654 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13655 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
13656 Change as necessary to match prototype in unexec.h.
13658 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13660 (back_comment, skip_chars): Mark vars as initialized.
13662 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13663 Rename locals to avoid shadowing.
13665 * lread.c (read1): Rewrite so as not to use empty "else".
13666 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
13668 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13670 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13671 warning when compiling print.c.
13673 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13674 instead of using an uninitialized var.
13675 (font_sort_entities): Mark var as initialized.
13677 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13679 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13680 pointers to constants.
13681 (font_parse_fcname): Remove unused vars.
13682 (font_delete_unmatched): Now static.
13683 (font_get_spec): Remove; unused.
13684 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13685 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13686 Rename or move locals to avoid shadowing.
13688 * fns.c (require_nesting_list, require_unwind): Now static.
13689 (Ffillarray): Rename locals to avoid shadowing.
13691 * floatfns.c (domain_error2): Define only if needed.
13692 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
13694 * alloc.c (mark_backtrace): Move decl from here ...
13695 * lisp.h: ... to here, so that it can be checked.
13697 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
13698 (Fdefvar): Rewrite so as not to use empty "else".
13699 (lisp_indirect_variable): Name an expression,
13700 to avoid gcc -Wbad-function-cast warning.
13701 (Fdefvar): Rename locals to avoid shadowing.
13703 * callint.c (quotify_arg, quotify_args): Now static.
13704 (Fcall_interactively): Rename locals to avoid shadowing.
13705 Use const pointer when appropriate.
13707 * lisp.h (get_system_name, get_operating_system_release):
13708 Move decls here, to check interfaces.
13709 * process.c (get_operating_system_release): Move decl to lisp.h.
13710 * xrdb.c (get_system_name): Likewise.
13711 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13712 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13713 some of which prompt warnings from gcc -Wbad-function-cast.
13714 (Fformat_time_string, Fencode_time, Finsert_char):
13715 (Ftranslate_region_internal, Fformat):
13716 Rename or remove local vars to avoid shadowing.
13717 (Ftranslate_region_internal): Mark var as initialized.
13719 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13722 * lisp.h (eassert): Check that the argument compiles, even if
13723 ENABLE_CHECKING is not defined.
13725 * data.c (Findirect_variable): Name an expression, to avoid
13726 gcc -Wbad-function-cast warning.
13727 (default_value, arithcompare, arith_driver, arith_error): Now static.
13728 (store_symval_forwarding): Rename local to avoid shadowing.
13729 (Fmake_variable_buffer_local, Fmake_local_variable):
13730 Mark variables as initialized.
13731 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
13733 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
13734 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13735 Rename locals to avoid shadowing.
13736 (mark_stack): Move local variables into the #ifdef region where
13738 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13739 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13741 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13742 (GC_STRING_CHARS): Remove; not used.
13743 (Fmemory_limit): Cast sbrk's returned value to char *.
13745 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13746 avoids undefined behavior in theory.
13748 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13750 Use functions, not macros, for up- and down-casing (Bug#8254).
13751 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13752 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13753 to use the following functions instead of these macros.
13754 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13755 EMACS_INT, since callers assume the returned value fits in int.
13756 (upcase1): Likewise, for UPCASE_TABLE.
13757 (uppercasep, lowercasep, upcase): New static inline functions.
13758 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
13759 the race-condition problem in the old DOWNCASE.
13761 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13762 Rename locals to avoid shadowing.
13763 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
13764 (regex_compile, re_search_2, re_match_2_internal):
13765 Remove unused local vars.
13766 (FREE_VAR): Rewrite so as not to use empty "else",
13767 which gcc can warn about.
13768 (regex_compile, re_match_2_internal): Mark locals as initialized.
13769 (RETALLOC_IF): Define only if needed.
13770 (WORDCHAR_P): Likewise. This one is never needed, but is used
13771 only in a comment talking about a compiler bug, so put inside
13772 the #if 0 of that comment.
13773 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13774 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13777 * search.c (boyer_moore): Rename locals to avoid shadowing.
13778 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13779 (PREV_CHAR_BOUNDARY): Likewise.
13781 * search.c (simple_search): Remove unused var.
13783 * dired.c (compile_pattern): Move decl from here ...
13784 * lisp.h: ... to here, so that it can be checked.
13785 (struct re_registers): New forward decl.
13787 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13789 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13791 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13792 Rename locals to avoid shadowing.
13793 (Fvertical_motion): Mark locals as initialized.
13795 * casefiddle.c (casify_object, casify_region): Now static.
13796 (casify_region): Mark local as initialized.
13798 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13800 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13801 New macros, so that the caller can use some names other than
13802 gcpro1, gcpro2, etc.
13803 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13805 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13806 argument, for consistency with GCPRO2_VAR, etc: it is now the
13807 prefix of the variable, not the variable itself. All uses
13809 * dired.c (directory_files_internal, file_name_completion):
13810 Rename locals to avoid shadowing.
13812 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13813 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13814 dired.c's scmp function, had undefined behavior.
13815 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13816 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13817 * buffer.h: ... to here, because these macros use current_buffer,
13818 and the new implementation with inline functions needs to have
13819 current_buffer in scope now, rather than later when the macros
13821 (downcase, upcase1): New static inline functions.
13822 (DOWNCASE, UPCASE1): Reimplement using these functions.
13823 This avoids undefined behavior in expressions like
13824 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13825 from race conditions in accessing the global variables
13826 case_temp1 and case_temp2.
13827 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13828 * lisp.h (case_temp1, case_temp2): Remove their decls.
13829 * character.h (ASCII_CHAR_P): Move from here ...
13830 * lisp.h: ... to here, so that the inline functions mentioned
13831 above can use them.
13833 * dired.c (directory_files_internal_unwind): Now static.
13835 * fileio.c (file_name_as_directory, directory_file_name):
13836 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13838 (file_name_as_directory): Use const pointers when appropriate.
13839 (Fexpand_file_name): Likewise. In particular, newdir might
13840 point at constant storage, so make it a const pointer.
13841 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
13842 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13844 (Fset_file_times, Finsert_file_contents, auto_save_error):
13845 Rename locals to avoid shadowing.
13847 * minibuf.c (choose_minibuf_frame_1): Now static.
13848 (Ftry_completion, Fall_completions): Rename or remove locals
13849 to avoid shadowing.
13851 * marker.c (bytepos_to_charpos): Remove; unused.
13853 * lisp.h (verify_bytepos, count_markers): New decls,
13854 so that gcc does not warn that these functions aren't declared.
13856 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13857 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
13858 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
13859 (copy_text): Remove unused local var.
13861 * filelock.c (within_one_second): Now static.
13862 (lock_file_1): Rename local to avoid shadowing.
13864 * buffer.c (fix_overlays_before): Mark locals as initialized.
13865 (fix_start_end_in_overlays): Likewise. This function should be
13866 simplified by using pointers-to-pointers, but that's a different
13868 (switch_to_buffer_1): Now static.
13869 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13870 (report_overlay_modification): Rename locals to avoid shadowing.
13872 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
13873 Fix pointer signedness issue.
13874 (sys_subshell): Mark local as volatile if checking for lint,
13875 to suppress a gcc -Wclobbered warning that does not seem to be right.
13876 (MAXPATHLEN): Define only if needed.
13878 * process.c (serial_open, serial_configure): Move decls from here ...
13879 * systty.h: ... to here, so that they can be checked.
13881 * fns.c (get_random, seed_random): Move extern decls from here ...
13882 * lisp.h: ... to here, so that they can be checked.
13884 * sysdep.c (reset_io): Now static.
13885 (wait_for_termination_signal): Remove; unused.
13887 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13888 (copy_keymap_item, append_key, push_text_char_description):
13890 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
13891 (DENSE_TABLE_SIZE): Remove; unused.
13892 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13893 (describe_map_tree):
13894 Rename locals to avoid shadowing.
13896 * keyboard.c: Declare functions static if they are not used elsewhere.
13897 (echo_char, echo_dash, cmd_error, top_level_2):
13898 (poll_for_input, handle_async_input): Now static.
13899 (read_char, kbd_buffer_get_event, make_lispy_position):
13900 (make_lispy_event, make_lispy_movement, apply_modifiers):
13901 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13902 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13903 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
13904 (read_key_sequence, read_char): Mark locals as initialized.
13905 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
13907 * keyboard.h (make_ctrl_char): New decl.
13908 (mark_kboards): Move decl here ...
13909 * alloc.c (mark_kboards): ... from here.
13911 * lisp.h (force_auto_save_soon): New decl.
13913 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
13914 (DEFINE_DUMMY_FUNCTION): New macro.
13915 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13917 (main): Add casts to avoid warnings
13918 if GCC considers string literals to be constants.
13920 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13922 * dbusbind.c: Pointer signedness fixes.
13923 (xd_signature, xd_append_arg, xd_initialize):
13924 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13925 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13926 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13927 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13929 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13930 if GCC considers string literals to be constants.
13931 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
13933 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13935 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13936 (print_preprocess, print_object): New macro to fix last change.
13938 * print.c (print_preprocess): Don't forget font objects.
13940 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
13942 * emacs.c (USAGE3): Doc fixes.
13944 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13946 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13949 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
13951 * lisp.h (VWindow_system, Qfile_name_history):
13952 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13953 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13954 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13956 * w32select.c: Don't #include "keyboard.h".
13957 (run_protected): Add extern declaration for waiting_for_input.
13959 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13960 * w32console.c (detect_input_pending, read_input_pending)
13961 (encode_terminal_code):
13962 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13963 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13964 (w32_system_caret_y, Qfile_name_history):
13965 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13966 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13967 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13968 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13969 * w32proc.c (Qlocal, report_file_error):
13970 * w32term.c (Vwindow_system, updating_frame):
13971 * w32uniscribe.c (initialized, uniscribe_font_driver):
13972 Remove unneeded extern declarations.
13974 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
13976 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
13978 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
13980 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13981 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13982 These macros can no longer be used for assignment.
13984 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13985 Assign struct members directly, instead of using BUF_BEGV etc.
13986 (record_buffer_markers, fetch_buffer_markers): New functions for
13987 recording and fetching special buffer markers.
13988 (set_buffer_internal_1, set_buffer_temp): Use them.
13990 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13992 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13994 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13995 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13997 * xdisp.c (hscroll_window_tree):
13998 (reconsider_clip_changes): Use PT instead of BUF_PT.
14000 2011-03-13 Eli Zaretskii <eliz@gnu.org>
14002 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14003 $(EMACS_ROOT)/lib/intprops.h.
14005 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14007 Fix more problems found by GCC 4.5.2's static checks.
14009 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14010 to unsigned char * to avoid compiler diagnostic.
14011 (xg_free_frame_widgets): Make it clear that a local variable is
14012 needed only if USE_GTK_TOOLTIP.
14013 (gdk_window_get_screen): Make it clear that this macro is needed
14014 only if USE_GTK_TOOLTIP.
14015 (int_gtk_range_get_value): New function, which avoids a diagnostic
14016 from gcc -Wbad-function-cast.
14017 (xg_set_toolkit_scroll_bar_thumb): Use it.
14018 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14019 diagnostic from gcc -Wbad-function-cast.
14020 (get_utf8_string, xg_get_file_with_chooser):
14021 Rename locals to avoid shadowing.
14022 (create_dialog): Move locals to avoid shadowing.
14024 * xgselect.c (xg_select): Remove unused var.
14026 * image.c (four_corners_best): Mark locals as initialized.
14027 (gif_load): Initialize transparent_p to zero (Bug#8238).
14028 Mark another local as initialized.
14029 (my_png_error, my_error_exit): Mark with NO_RETURN.
14031 * image.c (clear_image_cache): Now static.
14032 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
14033 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
14034 (x_edge_detection): Remove unnecessary cast that
14035 gcc -Wbad-function-cast diagnoses.
14036 (gif_load): Fix pointer signedness.
14037 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14038 (jpeg_load, gif_load): Rename locals to avoid shadowing.
14040 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
14042 Improve quality of tests for time stamp overflow.
14043 For example, without this patch (encode-time 0 0 0 1 1
14044 1152921504606846976) returns the obviously-bogus value (-948597
14045 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14046 reports time overflow. See
14047 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
14048 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14049 * editfns.c: Include limits.h and intprops.h.
14050 (TIME_T_MIN, TIME_T_MAX): New macros.
14051 (time_overflow): Move earlier, to before first use.
14052 (hi_time, lo_time): New functions, for an accurate test for
14053 out-of-range times.
14054 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14055 (Fget_internal_run_time): Don't assume time_t fits in int.
14056 (make_time): Use list2 instead of Fcons twice.
14057 (Fdecode_time): More accurate test for out-of-range times.
14058 (check_tm_member): New function.
14059 (Fencode_time): Use it, to test for out-of-range times.
14060 (lisp_time_argument): Don't rely on undefined left-shift and
14061 right-shift behavior when checking for time stamp overflow.
14063 * editfns.c (time_overflow): New function, refactoring common code.
14064 (Fformat_time_string, Fdecode_time, Fencode_time):
14065 (Fcurrent_time_string): Use it.
14067 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14068 * dired.c (make_time): Move to ...
14069 * editfns.c (make_time): ... here.
14070 * systime.h: Note the move.
14072 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14074 * fringe.c (update_window_fringes): Remove unused variables.
14076 * unexmacosx.c (copy_data_segment): Also copy __got section.
14079 2011-03-12 Eli Zaretskii <eliz@gnu.org>
14081 * termcap.c [MSDOS]: Include "msdos.h".
14082 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14083 Constify `char *' arguments and their references according to
14084 prototypes in tparam.h.
14086 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
14088 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14089 Adapt all references accordingly.
14091 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14093 2011-03-11 Tom Tromey <tromey@redhat.com>
14095 * buffer.c (syms_of_buffer): Remove obsolete comment.
14097 2011-03-11 Eli Zaretskii <eliz@gnu.org>
14099 * termhooks.h (encode_terminal_code): Declare prototype.
14101 * msdos.c (encode_terminal_code): Don't declare prototype.
14103 * term.c (encode_terminal_code): Now external again, used by
14104 w32console.c and msdos.c.
14106 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14107 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
14109 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
14111 Fix some minor problems found by GCC 4.5.2's static checks.
14113 * fringe.c (update_window_fringes): Mark locals as initialized
14115 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
14117 * alloc.c (mark_fringe_data): Move decl from here ...
14118 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14119 to check its interface.
14120 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14122 * fontset.c (free_realized_fontset): Now static.
14123 (Fset_fontset_font): Rename local to avoid shadowing.
14124 (fontset_font): Mark local as initialized.
14125 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
14127 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14129 * xselect.c (x_disown_buffer_selections): Remove; not used.
14130 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
14131 (x_own_selection, Fx_disown_selection_internal): Rename locals
14132 to avoid shadowing.
14133 (x_handle_dnd_message): Remove local to avoid shadowing.
14135 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14136 so that the caller can use some name other than gcpro1.
14137 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
14138 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14139 (Fx_backspace_delete_keys_p):
14140 Use them to avoid shadowing, and rename vars to avoid shadowing.
14141 (x_decode_color, x_set_name, x_window): Now static.
14142 (Fx_create_frame): Add braces to silence GCC warning.
14143 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
14144 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14145 Remove unused locals.
14146 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14147 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14148 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14151 * xterm.h (x_mouse_leave): New decl.
14153 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14154 Remove unused functions.
14155 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14156 (x_calc_absolute_position): Now static.
14157 (XTread_socket): Don't define label "out" unless it's used.
14158 Don't declare local "event" unless it's used.
14159 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14160 unless they are used.
14161 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14162 (x_fatal_error_signal): Remove; not used.
14163 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14164 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14165 (x_error_catcher, x_connection_closed, x_error_handler):
14166 (x_error_quitter, xembed_send_message, x_iconify_frame):
14167 (my_log_handler): Rename locals to avoid shadowing.
14168 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
14169 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
14171 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14172 Rename or move locals to avoid shadowing.
14173 (tty_defined_color, merge_face_heights): Now static.
14174 (free_realized_faces_for_fontset): Remove; not used.
14175 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14176 does not deduce is never used uninitialized.
14177 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14178 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
14180 * terminal.c (store_terminal_param): Now static.
14182 * xmenu.c (menu_highlight_callback): Now static.
14183 (set_frame_menubar): Remove unused local.
14184 (xmenu_show): Rename parameter to avoid shadowing.
14185 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14186 since they might point to immutable storage.
14187 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14188 since it's unused otherwise.
14190 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
14191 Add a FIXME, since the code still doesn't look right. (Bug#8215)
14192 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14193 avoids a gcc -Wuninitialized diagnostic.
14194 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
14195 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14196 does not deduce are never used uninitialized.
14198 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14200 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
14201 * window.c (window_loop, size_window):
14202 (run_window_configuration_change_hook, enlarge_window): Likewise.
14204 * window.c (display_buffer): Now static.
14205 (size_window): Mark variables that gcc -Wuninitialized
14206 does not deduce are never used uninitialized.
14207 * window.h (check_all_windows): New decl, to forestall
14208 gcc -Wmissing-prototypes diagnostic.
14209 * dispextern.h (bidi_dump_cached_states): Likewise.
14211 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14213 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
14214 Include <limits.h>.
14215 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14216 and to avoid gcc -Wuninitialized warning.
14217 (load_charset_map): Mark variables that gcc -Wuninitialized
14218 does not deduce are never used uninitialized.
14219 (load_charset): Abort instead of using uninitialized var (Bug#8229).
14221 * coding.c (coding_set_source, coding_set_destination):
14222 Use "else { /* comment */ }" rather than "else /* comment */;"
14223 for clarity, and to avoid gcc -Wempty-body warning.
14224 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14225 a block, when the outer 'i' will do.
14226 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14227 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14228 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14229 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14230 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14231 Rename locals to avoid shadowing.
14232 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
14233 * coding.c (emacs_mule_char, encode_invocation_designation):
14234 Now static, since they're not used elsewhere.
14235 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
14236 (decode_coding_object, encode_coding_object, detect_coding_system):
14237 (decode_coding_emacs_mule): Mark variables that gcc
14238 -Wuninitialized does not deduce are never used uninitialized.
14239 (detect_coding_iso_2022): Initialize a local variable that might
14240 be used uninitialized. Leave a FIXME because it's not clear that
14241 this initialization is needed. (Bug#8211)
14242 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14243 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14244 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14245 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14246 Remove unused macros.
14248 * category.c (hash_get_category_set): Remove unused local var.
14249 (copy_category_table): Now static, since it's not used elsewhere.
14250 * character.c (string_count_byte8): Likewise.
14252 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14253 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14255 * chartab.c (copy_sub_char_table): Now static, since it's not used
14257 (sub_char_table_ref_and_range, char_table_ref_and_range):
14258 Rename locals to avoid shadowing.
14259 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
14261 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
14262 (BIDI_BOB): Remove unused macro.
14264 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14265 deduce are never used uninitialized.
14266 * term.c (encode_terminal_code): Likewise.
14268 * term.c (encode_terminal_code): Now static. Remove unused local.
14270 * tparam.h: New file.
14271 * term.c, tparam.h: Include it.
14272 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14273 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14274 Move these decls to tparam.h, and make them agree with what
14275 is actually in tparam.c. The previous trick of using incompatible
14276 decls in different modules does not conform to the C standard.
14277 All callers of tparam changed to use tparam's actual API.
14278 * tparam.c (tparam1, tparam, tgoto):
14279 Use const pointers where appropriate.
14281 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14282 * cm.h (struct cm): Likewise.
14283 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14284 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14285 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14286 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14287 (turn_on_face, init_tty): Likewise.
14288 * termchar.h (struct tty_display_info): Likewise.
14290 * term.c (term_mouse_position): Rename local to avoid shadowing.
14292 * alloc.c (mark_ttys): Move decl from here ...
14293 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14295 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14297 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14299 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
14301 * search.c (compile_pattern_1): Remove argument regp, unused since
14302 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14303 (compile_pattern): Don't pass it.
14305 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14307 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14308 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14310 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14312 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14314 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14315 gdk_window_get_screen, gdk_window_get_geometry,
14316 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14317 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14318 (xg_get_pixbuf_from_pixmap): New function.
14319 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14320 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14321 Call xg_get_pixbuf_from_pixmap instead of
14322 gdk_pixbuf_get_from_drawable.
14323 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14324 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14325 (xg_check_special_colors): Use GtkStyleContext and its functions
14327 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14328 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14329 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
14330 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14331 Call gtk_widget_get_preferred_size.
14332 (xg_frame_resized): gdk_window_get_geometry only takes 5
14334 (xg_win_to_widget, xg_event_is_for_menubar):
14335 Call gdk_x11_window_lookup_for_display.
14336 (xg_set_widget_bg): New function.
14337 (delete_cb): New function.
14338 (xg_create_frame_widgets): Connect delete-event to delete_cb.
14339 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
14340 (xg_set_background_color): Call xg_set_widget_bg.
14341 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14342 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14343 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14344 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14346 (update_frame_tool_bar): Call gtk_widget_hide.
14347 (xg_initialize): Use GDK_KEY_g.
14349 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14351 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14353 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14354 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14355 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14357 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
14359 * w32xfns.c (select_palette): Check success of RealizePalette against
14360 GDI_ERROR, not zero.
14362 See ChangeLog.11 for earlier changes.
14364 ;; Local Variables:
14368 Copyright (C) 2011-2012 Free Software Foundation, Inc.
14370 This file is part of GNU Emacs.
14372 GNU Emacs is free software: you can redistribute it and/or modify
14373 it under the terms of the GNU General Public License as published by
14374 the Free Software Foundation, either version 3 of the License, or
14375 (at your option) any later version.
14377 GNU Emacs is distributed in the hope that it will be useful,
14378 but WITHOUT ANY WARRANTY; without even the implied warranty of
14379 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14380 GNU General Public License for more details.
14382 You should have received a copy of the GNU General Public License
14383 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.