Fix resize and change of scroll bar width for Gtk3.
[bpt/emacs.git] / src / ChangeLog
1 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2
3 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4 xg_get_default_scrollbar_width.
5
6 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8 (style_changed_cb): Call update_theme_scrollbar_width and call
9 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10 all frames (Bug#8505).
11 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
12 Call gtk_window_set_resizable if HAVE_GTK3.
13 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
14 and height if HAVE_GTK3 (Bug#8505).
15 (scroll_bar_width_for_theme): New variable.
16 (update_theme_scrollbar_width): New function.
17 (xg_get_default_scrollbar_width): Move code to
18 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
19 (xg_initialize): Call update_theme_scrollbar_width.
20
21 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
22
23 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
24
25 2011-06-12 Martin Rudalics <rudalics@gmx.at>
26
27 * frame.c (make_frame): Call other_buffer_safely instead of
28 other_buffer.
29
30 * window.c (temp_output_buffer_show): Call display_buffer with
31 second argument Vtemp_buffer_show_specifiers and reset latter
32 immediately after the call.
33 (Vtemp_buffer_show_specifiers): New variable.
34 (auto_window_vscroll_p, next_screen_context_lines)
35 (Vscroll_preserve_screen_position): Remove leading asterisks from
36 doc-strings.
37
38 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
39
40 Fix minor problems found by GCC 4.6.0 static checking.
41 * buffer.c (Qclone_number): Remove for now, as it's unused.
42 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
43 (record_buffer): Remove unused local.
44 * frame.c (other_visible_frames, frame_buffer_list): Now static.
45 (set_frame_buffer_list): Remove; unused.
46 * frame.h (other_visible_frames): Remove decl.
47 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
48 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
49 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
50 if HAVE_GPM.
51 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
52 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
53 Define only if HAVE_GPM.
54 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
55 (update_hints_inhibit): Remove; never set. All uses removed.
56 * widgetprv.h (emacsFrameClassRec): Remove decl.
57 * window.c (delete_deletable_window): Now returns void, since it
58 wasn't returning anything.
59 (compare_window_configurations): Remove unused locals.
60 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
61 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
62 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
63 the same widths as pointers. This follows up on the 2011-05-06 patch.
64 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
65 * xterm.h: Likewise.
66 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
67
68 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
69
70 * makefile.w32-in: Update dependencies.
71 (LISP_H): Add lib/intprops.h.
72
73 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
74
75 * image.c (gif_load): Add animation frame delay to the metadata.
76 (syms_of_image): Use DEFSYM. New symbol `delay'.
77
78 2011-06-11 Martin Rudalics <rudalics@gmx.at>
79
80 * window.c (delete_deletable_window): Re-add.
81 (Fset_window_configuration): Rewrite to handle dead buffers and
82 consequently deletable windows.
83 (window_tree, Fwindow_tree): Remove. Supply functionality in
84 window.el.
85 (compare_window_configurations): Simplify code.
86
87 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
88
89 * image.c (imagemagick_load_image): Fix type mismatch.
90 (Fimagemagick_types): Likewise.
91
92 * window.h (replace_buffer_in_windows): Declare.
93
94 2011-06-11 Martin Rudalics <rudalics@gmx.at>
95
96 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
97 Qclone_number. Remove external declaration of Qdelete_window.
98 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
99 code.
100 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
101 Qbuffer_list_update_hook if allowed.
102 (Fother_buffer): Rewrite doc-string. Major rewrite for new
103 buffer list implementation.
104 (other_buffer_safely): New function.
105 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
106 calls to replace_buffer_in_windows and
107 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
108 if allowed.
109 (record_buffer): Inhibit quitting and rewrite using quittable
110 functions. Run Qbuffer_list_update_hook if allowed.
111 (Frecord_buffer, Funrecord_buffer): New functions.
112 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
113 switch-to-buffer to window.el.
114 (bury-buffer): Move to window.el.
115 (Vbuffer_list_update_hook): New variable.
116
117 * lisp.h (other_buffer_safely): Add prototype in buffer.c
118 section.
119
120 * window.h (resize_frame_windows): Move up in code.
121 (Fwindow_frame): Remove EXFUN.
122 (replace_buffer_in_all_windows): Remove prototype.
123 (replace_buffer_in_windows_safely): Add prototype.
124
125 * window.c: Declare Qdelete_window static again. Move down
126 declaration of select_count.
127 (Fnext_window, Fprevious_window): Rewrite doc-strings.
128 (Fother_window): Move to window.el.
129 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
130 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
131 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
132 window.el.
133 (replace_buffer_in_windows): Implement by calling
134 Qreplace_buffer_in_windows.
135 (replace_buffer_in_all_windows): Remove with some functionality
136 moved into replace_buffer_in_windows_safely.
137 (replace_buffer_in_windows_safely): New function.
138 (select_window_norecord, select_frame_norecord): Move in front
139 of run_window_configuration_change_hook. Remove now obsolete
140 declarations.
141 (Fset_window_buffer): Rewrite doc-string. Call
142 Qrecord_window_buffer.
143 (keys_of_window): Move binding for other-window to window.el.
144
145 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
146
147 * dispextern.h (struct image): Replace data member, whose int_val
148 and ptr_val fields were not used by anything, with a single
149 lisp_val object.
150
151 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
152 (gif_clear_image, gif_load, imagemagick_load_image)
153 (gs_clear_image, gs_load): Callers changed.
154
155 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
156
157 * buffer.h: Include <time.h>, for time_t.
158 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
159
160 Fix minor problems found by static checking.
161
162 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
163
164 Make identifiers static if they are not used in other modules.
165 * data.c (Qcompiled_function, Qframe, Qvector):
166 * image.c (QimageMagick, Qsvg):
167 * minibuf.c (Qmetadata):
168 * window.c (resize_window_check, resize_root_window): Now static.
169 * window.h (resize_window_check, resize_root_window): Remove decls.
170
171 * window.c (window_deletion_count, delete_deletable_window):
172 Remove; unused.
173 (window_body_lines): Now static.
174 (Fdelete_other_windows_internal): Mark vars as initialized.
175 Make sure 'resize_failed' is initialized.
176 (run_window_configuration_change_hook): Rename local to avoid shadowing.
177 (resize_window_apply): Remove unused local.
178 * window.h (delete_deletable_window): Remove decl.
179
180 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
181 (imagemagick_load_image): Fix pointer signedness problem by changing
182 last arg from unsigned char * to char *. All uses changed.
183 Also, fix a local for similar reasons.
184 Remove unused locals. Remove locals to avoid shadowing.
185 (fn_rsvg_handle_free): Remove; unused.
186 (svg_load, svg_load_image): Fix pointer signedness problem.
187 (imagemagick_load_image): Don't use garbage pointer image_wand.
188
189 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
190
191 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
192
193 * image.c (gif_load): Fix omitted cast error introduced by
194 2011-06-06 change.
195
196 2011-06-10 Martin Rudalics <rudalics@gmx.at>
197
198 * window.h (resize_proportionally, orig_total_lines)
199 (orig_top_line): Remove from window structure.
200 (set_window_height, set_window_width, change_window_heights)
201 (Fdelete_window): Remove prototypes.
202 (resize_frame_windows): Remove duplicate declaration.
203
204 2011-06-10 Eli Zaretskii <eliz@gnu.org>
205
206 * window.h (resize_frame_windows, resize_window_check)
207 (delete_deletable_window, resize_root_window)
208 (resize_frame_windows): Declare prototypes.
209
210 * window.c (resize_window_apply): Make definition be "static" to
211 match the prototype.
212
213 2011-06-10 Martin Rudalics <rudalics@gmx.at>
214
215 * window.c: Remove declarations of Qwindow_size_fixed,
216 window_min_size_1, window_min_size_2, window_min_size,
217 size_window, window_fixed_size_p, enlarge_window, delete_window.
218 Remove static from declaration of Qdelete_window, it's
219 temporarily needed by Fbury_buffer.
220 (replace_window): Don't assign orig_top_line and
221 orig_total_lines.
222 (Fdelete_window, delete_window): Remove. Window deletion is
223 handled by window.el.
224 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
225 Fdelete_window calls with calls to Qdelete_window.
226 (Fdelete_other_windows): Remove. Deleting other windows is
227 handled by window.el.
228 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
229 handled in window.el.
230 (window_min_size_2, window_min_size_1, window_min_size): Remove.
231 Window minimum sizes are handled in window.el.
232 (shrink_windows, size_window, set_window_height)
233 (set_window_width, change_window_heights, window_height)
234 (window_width, CURBEG, CURSIZE, enlarge_window)
235 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
236 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
237 handled in window.el.
238 (make_dummy_parent): Rename to make_parent_window and give it a
239 second argument horflag.
240 (make_window): Don't set resize_proportionally any more.
241 (Fsplit_window): Remove. Windows are split in window.el.
242 (save_restore_action, save_restore_orig_size)
243 (shrink_window_lowest_first, save_restore_orig_size): Remove.
244 Resize mini windows in window.el.
245 (grow_mini_window, shrink_mini_window): Implement by calling
246 Qresize_root_window_vertically, resize_window_check and
247 resize_window_apply.
248 (saved_window, Fset_window_configuration, save_window_save): Do
249 not handle orig_top_line, orig_total_lines, and
250 resize_proportionally.
251 (window_min_height, window_min_width): Move to window.el.
252 (keys_of_window): Move bindings for delete-other-windows,
253 split-window, delete-window and enlarge-window to window.el.
254
255 * buffer.c: Temporarily extern Qdelete_window.
256 (Fbury_buffer): Temporarily call Qdelete_window instead of
257 Fdelete_window (Fbury_buffer will move to window.el soon).
258
259 * frame.c (set_menu_bar_lines_1): Remove code handling
260 orig_top_line and orig_total_lines.
261
262 * dispnew.c (adjust_frame_glyphs_initially): Don't use
263 set_window_height but set heights directly.
264 (change_frame_size_1): Use resize_frame_windows.
265
266 * xdisp.c (init_xdisp): Don't use set_window_height but set
267 heights directly.
268
269 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
270 resize_frame_windows instead of change_window_heights and run
271 run_window_configuration_change_hook.
272
273 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
274 instead of change_window_heights and run
275 run_window_configuration_change_hook.
276
277 2011-06-09 Martin Rudalics <rudalics@gmx.at>
278
279 * window.c (replace_window): Rename second argument REPLACEMENT to
280 NEW. New third argument SETFLAG. Rewrite.
281 (delete_window, make_dummy_parent): Call replace_window with
282 third argument 1.
283 (window_list_1): Move down in code.
284 (run_window_configuration_change_hook): Move set_buffer part
285 before select_frame_norecord part in order to unwind correctly.
286 Rename count1 to count.
287 (recombine_windows, delete_deletable_window, resize_root_window)
288 (Fdelete_other_windows_internal)
289 (Frun_window_configuration_change_hook, make_parent_window)
290 (resize_window_check, resize_window_apply, Fresize_window_apply)
291 (resize_frame_windows, Fsplit_window_internal)
292 (Fdelete_window_internal, Fresize_mini_window_internal): New
293 functions.
294 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
295
296 2011-06-08 Martin Rudalics <rudalics@gmx.at>
297
298 * window.h (window): Add some new members to window structure -
299 normal_lines, normal_cols, new_total, new_normal, clone_number,
300 splits, nest, prev_buffers, next_buffers.
301 (WINDOW_TOTAL_SIZE): Move here from window.c.
302 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
303
304 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
305 Remove.
306 (make_dummy_parent): Set new members of windows structure.
307 (make_window): Move down in code. Handle new members of window
308 structure.
309 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
310 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
311 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
312 (Fset_window_prev_buffers, Fwindow_next_buffers)
313 (Fset_window_next_buffers, Fset_window_clone_number): New
314 functions.
315 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
316 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
317 Doc-string fixes.
318 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
319 Argument WINDOW can be now internal window too.
320 (Fwindow_use_time): Move up in code.
321 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
322 Rewrite doc-string.
323 (Fset_window_configuration, saved_window)
324 (Fcurrent_window_configuration, save_window_save): Handle new
325 members of window structure.
326 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
327 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
328 (syms_of_window): New Lisp objects Qrecord_window_buffer,
329 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
330 Qget_mru_window, Qresize_root_window,
331 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
332 Qauto_buffer_name; staticpro them.
333
334 2011-06-07 Martin Rudalics <rudalics@gmx.at>
335
336 * window.c (Fwindow_total_size, Fwindow_left_column)
337 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
338 (Fwindow_list_1): New functions.
339 (window_box_text_cols): Replace with window_body_cols.
340 (Fwindow_width, Fscroll_left, Fscroll_right): Use
341 window_body_cols instead of window_box_text_cols.
342 (delete_window, Fset_window_configuration): Call
343 delete_all_subwindows with window as argument.
344 (delete_all_subwindows): Take a window as argument and not a
345 structure. Rewrite.
346 (window_loop): Remove handling of GET_LRU_WINDOW and
347 GET_LARGEST_WINDOW.
348 (Fget_lru_window, Fget_largest_window): Move to window.el.
349
350 * window.h: Extern window_body_cols instead of
351 window_box_text_cols. delete_all_subwindows now takes a
352 Lisp_Object as argument.
353
354 * indent.c (compute_motion, Fcompute_motion): Use
355 window_body_cols instead of window_box_text_cols.
356
357 * frame.c (delete_frame): Call delete_all_subwindows with root
358 window as argument.
359
360 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
361
362 * fns.c (Fputhash): Document return value.
363
364 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
365
366 * image.c (gif_load): Implement gif89a spec "no disposal" method.
367
368 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
369
370 Cons<->int and similar integer overflow fixes (Bug#8794).
371
372 Check for overflow when converting integer to cons and back.
373 * charset.c (Fdefine_charset_internal, Fdecode_char):
374 Use cons_to_unsigned to catch overflow.
375 (Fencode_char): Use INTEGER_TO_CONS.
376 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
377 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
378 * data.c (long_to_cons, cons_to_long): Remove.
379 (cons_to_unsigned, cons_to_signed): New functions.
380 These signal an error for invalid or out-of-range values.
381 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
382 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
383 * font.c (Ffont_variation_glyphs):
384 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
385 * lisp.h: Include <intprops.h>.
386 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
387 (cons_to_signed, cons_to_unsigned): New decls.
388 (long_to_cons, cons_to_long): Remove decls.
389 * undo.c (record_first_change): Use INTEGER_TO_CONS.
390 (Fprimitive_undo): Use CONS_TO_INTEGER.
391 * xfns.c (Fx_window_property): Likewise.
392 * xselect.c: Include <limits.h>.
393 (x_own_selection, selection_data_to_lisp_data):
394 Use INTEGER_TO_CONS.
395 (x_handle_selection_request, x_handle_selection_clear)
396 (x_get_foreign_selection, Fx_disown_selection_internal)
397 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
398 (lisp_data_to_selection_data): Use cons_to_unsigned.
399 (x_fill_property_data): Use cons_to_signed.
400 Report values out of range.
401
402 Check for buffer and string overflow more precisely.
403 * buffer.h (BUF_BYTES_MAX): New macro.
404 * lisp.h (STRING_BYTES_MAX): New macro.
405 * alloc.c (Fmake_string):
406 * character.c (string_escape_byte8):
407 * coding.c (coding_alloc_by_realloc):
408 * doprnt.c (doprnt):
409 * editfns.c (Fformat):
410 * eval.c (verror):
411 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
412 since they may not be the same number.
413 * editfns.c (Finsert_char):
414 * fileio.c (Finsert_file_contents):
415 Likewise for BUF_BYTES_MAX.
416
417 * image.c: Use ptrdiff_t, not int, for sizes.
418 (slurp_file): Switch from int to ptrdiff_t.
419 All uses changed.
420 (slurp_file): Check that file size fits in both size_t (for
421 malloc) and ptrdiff_t (for sanity and safety).
422
423 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
424 if b->modtime has its maximal value.
425
426 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
427
428 Don't assume time_t can fit into int.
429 * buffer.h (struct buffer.modtime): Now time_t, not int.
430 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
431 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
432
433 Minor fixes for signed vs unsigned integers.
434 * character.h (MAYBE_UNIFY_CHAR):
435 * charset.c (maybe_unify_char):
436 * keyboard.c (read_char, reorder_modifiers):
437 XINT -> XFASTINT, since the integer must be nonnegative.
438 * ftfont.c (ftfont_spec_pattern):
439 * keymap.c (access_keymap, silly_event_symbol_error):
440 XUINT -> XFASTINT, since the integer must be nonnegative.
441 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
442 since it makes no difference and we prefer signed.
443 * keyboard.c (record_char): Use XUINT when all the neighbors do.
444 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
445 nonnegative.
446
447 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
448
449 * window.h (Fwindow_frame): Declare.
450
451 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
452
453 * alloc.c: Simplify handling of large-request failures (Bug#8800).
454 (SPARE_MEMORY): Always define.
455 (LARGE_REQUEST): Remove.
456 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
457
458 2011-06-06 Martin Rudalics <rudalics@gmx.at>
459
460 * lisp.h: Move EXFUNS for Fframe_root_window,
461 Fframe_first_window and Fset_frame_selected_window to window.h.
462
463 * window.h: Move EXFUNS for Fframe_root_window,
464 Fframe_first_window and Fset_frame_selected_window here from
465 lisp.h.
466
467 * frame.c (Fwindow_frame, Fframe_first_window)
468 (Fframe_root_window, Fframe_selected_window)
469 (Fset_frame_selected_window): Move to window.c.
470 (Factive_minibuffer_window): Move to minibuf.c.
471 (Fother_visible_frames_p): New function.
472
473 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
474
475 * window.c (decode_window, decode_any_window): Move up in code.
476 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
477 (inhibit_frame_unsplittable): Remove unused variable.
478 (Fwindow_buffer): Move up and rewrite doc-string.
479 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
480 (Fwindow_prev): New functions.
481 (Fwindow_frame): Move here from frame.c. Accept any window as
482 argument.
483 (Fframe_root_window, Fframe_first_window)
484 (Fframe_selected_window): Move here from frame.c. Accept frame
485 or arbitrary window as argument. Update doc-strings.
486 (Fminibuffer_window): Move up in code.
487 (Fwindow_minibuffer_p): Move up in code and simplify.
488 (Fset_frame_selected_window): Move here from frame.c.
489 Marginal rewrite.
490 (Fselected_window, select_window, Fselect_window): Move up in
491 code. Minor doc-string fixes.
492
493 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
494
495 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
496 Do not assume that spare memory exists; that assumption is valid
497 only if SYSTEM_MALLOC.
498 (LARGE_REQUEST): New macro, so that the issue of large requests
499 is separated from the issue of spare memory.
500
501 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
502
503 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
504 format. (Bug#8806)
505
506 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
507
508 * xfns.c (x_set_scroll_bar_default_width): Move declarations
509 before statements.
510
511 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
512
513 * gtkutil.c (xg_get_default_scrollbar_width): New function.
514
515 * gtkutil.h: Declare xg_get_default_scrollbar_width.
516
517 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
518 min width by calling x_set_scroll_bar_default_width (Bug#8505).
519
520 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
521
522 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
523
524 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
525
526 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
527 (x_clipboard_manager_save): Add return value.
528 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
529 New error handlers.
530 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
531 Obey Vx_select_enable_clipboard_manager. Catch errors in
532 x_clipboard_manager_save (Bug#8779).
533 (Vx_select_enable_clipboard_manager): New variable.
534 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
535
536 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
537
538 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
539
540 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
541
542 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
543 in the current matrix if keep_current_p is non-zero.
544
545 2011-06-04 Eli Zaretskii <eliz@gnu.org>
546
547 * bidi.c (bidi_level_of_next_char): Fix last change.
548
549 2011-06-03 Eli Zaretskii <eliz@gnu.org>
550
551 Support bidi reordering of text covered by display properties.
552
553 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
554 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
555 (bidi_cache_search, bidi_cache_iterator_state)
556 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
557 (bidi_level_of_next_char, bidi_move_to_visually_next):
558 Support character positions inside a run of characters covered by a
559 display string.
560 (bidi_paragraph_init, bidi_resolve_explicit_1)
561 (bidi_level_of_next_char): Call bidi_fetch_char and
562 bidi_fetch_char_advance instead of FETCH_CHAR and
563 FETCH_CHAR_ADVANCE.
564 (bidi_init_it): Initialize new members.
565 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
566 definitions.
567 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
568 instead of using explicit *_CHAR codes.
569 (bidi_resolve_explicit, bidi_resolve_weak):
570 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
571 bidirectional text is supported only in multibyte buffers.
572 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
573 it to initialize the frame_window_p member of struct bidi_it.
574 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
575 (bidi_resolve_explicit, bidi_resolve_weak)
576 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
577 bidi_it->nchars is non-positive.
578 (bidi_level_of_next_char): Don't try to lookup the cache for the
579 next/previous character if nothing is cached there yet, or if we
580 were just reseat()'ed to a new position.
581
582 * xdisp.c (set_cursor_from_row): Set start and stop points
583 according to the row's direction when priming the loop that looks
584 for the glyph on which to display cursor.
585 (single_display_spec_intangible_p): Function deleted.
586 (display_prop_intangible_p): Reimplement to call
587 handle_display_spec instead of single_display_spec_intangible_p.
588 Accept 3 additional arguments needed by handle_display_spec.
589 This fixes incorrect cursor motion across display property with complex
590 values: lists, `(when COND...)' forms, etc.
591 (single_display_spec_string_p): Support property values that are
592 lists with the argument STRING its top-level element.
593 (display_prop_string_p): Fix the condition for processing a
594 property that is a list to be consistent with handle_display_spec.
595 (handle_display_spec): New function, refactored from the
596 last portion of handle_display_prop.
597 (compute_display_string_pos): Accept additional argument
598 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
599 value of a `display' property is a "replacing spec".
600 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
601 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
602 the display property, but just return a value indicating whether
603 the display property will replace the characters it covers.
604 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
605 frame_window_p members of struct bidi_it.
606 (compute_display_string_pos, compute_display_string_end):
607 New functions.
608 (push_it): Accept second argument POSITION, where pop_it should
609 jump to continue iteration.
610 (reseat_1): Initialize bidi_it.disp_pos.
611
612 * keyboard.c (adjust_point_for_property): Adjust the call to
613 display_prop_intangible_p to its new signature.
614
615 * dispextern.h (struct bidi_it): New member frame_window_p.
616 (bidi_init_it): Update prototypes.
617 (display_prop_intangible_p): Update prototype.
618 (compute_display_string_pos, compute_display_string_end):
619 Declare prototypes.
620 (struct bidi_it): New members nchars and disp_pos. ch_len is now
621 EMACS_INT.
622
623 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
624
625 Malloc failure behavior now depends on size of allocation.
626 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
627 * lisp.h: Change signatures accordingly.
628 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
629 All callers changed. (Bug#8762)
630
631 * gnutls.c: Use Emacs's memory allocators.
632 Without this change, the gnutls library would invoke malloc etc.
633 directly, which causes problems on non-SYNC_INPUT hosts, and which
634 runs afoul of improving memory_full behavior. (Bug#8761)
635 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
636 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
637 xfree instead of the default malloc, realloc, free.
638 (Fgnutls_boot): No need to check for memory allocation failure,
639 since xmalloc does that for us.
640
641 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
642 * category.c (hash_get_category_set):
643 * ccl.c (ccl_driver):
644 * charset.c (Fdefine_charset_internal):
645 * charset.h (struct charset.hash_index):
646 * composite.c (get_composition_id, gstring_lookup_cache)
647 (composition_gstring_put_cache):
648 * composite.h (struct composition.hash_index):
649 * dispextern.h (struct image.hash):
650 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
651 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
652 (hashfn_equal, hashfn_user_defined, make_hash_table)
653 (maybe_resize_hash_table, hash_lookup, hash_put)
654 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
655 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
656 (Fsxhash, Fgethash, Fputhash, Fmaphash):
657 * image.c (make_image, search_image_cache, lookup_image)
658 (xpm_put_color_table_h):
659 * lisp.h (struct Lisp_Hash_Table):
660 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
661 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
662 for hashes and hash indexes, instead of 'unsigned' and 'int'.
663 * alloc.c (allocate_vectorlike):
664 Check for overflow in vector size calculations.
665 * ccl.c (ccl_driver):
666 Check for overflow when converting EMACS_INT to int.
667 * fns.c, image.c: Remove unnecessary static decls that would otherwise
668 need to be updated by these changes.
669 * fns.c (make_hash_table, maybe_resize_hash_table):
670 Check for integer overflow with large hash tables.
671 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
672 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
673 (SXHASH_REDUCE): New macro.
674 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
675 Use it instead of discarding useful hash info with large hash values.
676 (sxhash_float): New function.
677 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
678 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
679 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
680 Rewrite to use FIXNUM_BITS, as this simplifies things.
681 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
682 Adjust signatures to match updated version of code.
683 (consing_since_gc): Now EMACS_INT, since a single hash table can
684 use more than INT_MAX bytes.
685
686 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
687
688 Make it possible to build with GCC-4.6+ -O2 -flto.
689
690 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
691
692 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
693
694 * minibuf.c (get_minibuffer, read_minibuf_unwind):
695 Call minibuffer-inactive-mode.
696
697 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
698
699 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
700 Update dependencies.
701
702 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
703
704 * data.c (init_data): Remove code for UTS, this system is not
705 supported anymore.
706
707 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
708
709 Don't force ./temacs to start in terminal mode.
710
711 * frame.c (make_initial_frame): Initialize faces in all cases, not
712 only when CANNOT_DUMP is defined.
713 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
714
715 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
716
717 * dispnew.c (add_window_display_history): Use const for the string
718 pointer. Remove declaration, not needed.
719
720 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
721
722 Use 'inline', not 'INLINE'.
723 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
724 * alloc.c, fontset.c (INLINE): Remove.
725 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
726 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
727 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
728 * gmalloc.c (register_heapinfo): Use inline unconditionally.
729 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
730
731 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
732
733 Make it possible to run ./temacs.
734
735 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
736 syms_of_callproc does the same thing. Remove test for
737 "initialized", do it in the caller.
738 * emacs.c (main): Avoid calling set_initial_environment when dumping.
739
740 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
741
742 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
743 (read_minibuf): Use get_minibuffer.
744 (syms_of_minibuf): Use DEFSYM.
745 (Qmetadata): New var.
746 * data.c (Qbuffer): Don't make it static.
747 (syms_of_data): Use DEFSYM.
748
749 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
750
751 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
752 (CCL_CODE_MIN): New macro.
753
754 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
755
756 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
757
758 * eval.c (Qdebug): Now static.
759 * lisp.h (Qdebug): Remove decl. This reverts a part of the
760 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
761 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
762
763 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
764
765 * image.c: Various fixes to ImageMagick code comments.
766 (Fimagemagick_types): Doc fix.
767
768 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
769
770 Minor fixes prompted by GCC 4.6.0 warnings.
771
772 * xselect.c (converted_selections, conversion_fail_tag): Now static.
773
774 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
775 (x_clipboard_manager_save_all): Move extern decl to ...
776 * xterm.h: ... here, so that it can be checked for consistency.
777
778 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
779
780 * xselect.c (x_clipboard_manager_save_frame)
781 (x_clipboard_manager_save_all): New functions.
782 (Fx_clipboard_manager_save): Lisp function deleted.
783
784 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
785 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
786
787 * xterm.h: Update prototype.
788
789 2011-05-28 William Xu <william.xwl@gmail.com>
790
791 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
792 exiting (Bug#8239).
793
794 2011-05-28 Jim Meyering <meyering@redhat.com>
795
796 Avoid a sign-extension bug in crypto_hash_function.
797 * fns.c (to_uchar): Define.
798 (crypto_hash_function): Use it to convert some newly-signed
799 variables to unsigned, to avoid sign-extension bugs. For example,
800 without this change, (md5 "truc") would evaluate to
801 45723a2aff78ff4fff7fff1114760e62 rather than the expected
802 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
803 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
804
805 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
806
807 Integer overflow fixes.
808
809 * dbusbind.c: Serial number integer overflow fixes.
810 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
811 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
812 to hold a serial number that is too large for a fixnum.
813 (Fdbus_method_return_internal, Fdbus_method_error_internal):
814 Check for serial numbers out of range. Decode any serial number
815 that was so large that it became a float. (Bug#8722)
816
817 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
818 (Fdbus_call_method, Fdbus_call_method_asynchronously):
819 Use XFASTINT rather than XUINT when numbers are nonnegative.
820 (xd_append_arg, Fdbus_method_return_internal):
821 (Fdbus_method_error_internal): Likewise. Also, for unsigned
822 arguments, check that Lisp number is nonnegative, rather than
823 silently wrapping negative numbers around. (Bug#8722)
824 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
825 (Bug#8722)
826
827 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
828
829 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
830
831 ccl: add integer overflow checks
832 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
833 (IN_INT_RANGE): New macros.
834 (ccl_driver): Use them to check for integer overflow when
835 decoding a CCL program. Many of the new checks are whether XINT (x)
836 fits in int; it doesn't always, on 64-bit hosts. The new version
837 doesn't catch all possible integer overflows, but it's an
838 improvement. (Bug#8719)
839
840 * alloc.c (make_event_array): Use XINT, not XUINT.
841 There's no need for unsigned here.
842
843 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
844 This follows up to the 2011-05-06 change that substituted uintptr_t
845 for EMACS_INT. This case wasn't caught back then.
846
847 Rework Fformat to avoid integer overflow issues.
848 * editfns.c: Include <float.h> unconditionally, as it's everywhere
849 now (part of C89). Include <verify.h>.
850 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
851 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
852 (Fformat): Avoid the prepass trying to compute sizes; it was only
853 approximate and thus did not catch overflow reliably. Instead, walk
854 through the format just once, formatting and computing sizes as we go,
855 checking for integer overflow at every step, and allocating a larger
856 buffer as needed. Keep track separately whether the format is
857 multibyte. Keep only the most-recently calculated precision, rather
858 than them all. Record whether each argument has been converted to
859 string. Use EMACS_INT, not int, for byte and char and arg counts.
860 Support field widths and precisions larger than INT_MAX. Avoid
861 sprintf's undefined behavior with conversion specifications such as %#d
862 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
863 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
864 formatting out-of-range floating point numbers with int
865 formats. (Bug#8668)
866
867 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
868
869 * data.c: Avoid integer truncation in expressions involving floats.
870 * data.c: Include <intprops.h>.
871 (arith_driver): When there's an integer overflow in an expression
872 involving floating point, convert the integers to floating point
873 so that the resulting value does not suffer from catastrophic
874 integer truncation. For example, on a 64-bit host (* 4
875 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
876 Do not rely on undefined behavior after integer overflow.
877
878 merge count_size_as_multibyte, parse_str_to_multibyte
879 * character.c, character.h (count_size_as_multibyte):
880 Rename from parse_str_to_multibyte; all uses changed.
881 Check for integer overflow.
882 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
883 since it's now a duplicate of the other. This is more of
884 a character than a buffer op, so better that it's in character.c.
885 * fns.c, print.c: Adjust to above changes.
886
887 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
888
889 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
890
891 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
892
893 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
894 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
895 (x_clipboard_manager_save): Now static.
896 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
897
898 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
899 (crypto_hash_function): Now static.
900 Fix pointer signedness problems. Avoid unnecessary initializations.
901
902 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
903
904 * termhooks.h (Vselection_alist): Make it terminal-local.
905
906 * terminal.c (create_terminal): Initialize it.
907
908 * xselect.c: Support for clipboard managers.
909 (Vselection_alist): Move to termhooks.h as terminal-local var.
910 (LOCAL_SELECTION): New macro.
911 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
912 (symbol_to_x_atom): Remove gratuitous arg.
913 (x_handle_selection_request, lisp_data_to_selection_data)
914 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
915 (x_own_selection, x_get_local_selection, x_convert_selection):
916 New arg, specifying work frame. Use terminal-local Vselection_alist.
917 (some_frame_on_display): Delete unused function.
918 (Fx_own_selection_internal, Fx_get_selection_internal)
919 (Fx_disown_selection_internal, Fx_selection_owner_p)
920 (Fx_selection_exists_p): New optional frame arg.
921 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
922 (x_handle_selection_clear): Don't treat other terminals with the
923 same keyboard specially. Use the terminal-local Vselection_alist.
924 (x_clear_frame_selections): Use Frun_hook_with_args.
925
926 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
927
928 * xterm.h: Add support for those atoms.
929
930 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
931
932 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
933 (converted_selections, conversion_fail_tag): New global variables.
934 (x_selection_request_lisp_error): Free the above.
935 (x_get_local_selection): Remove unnecessary code.
936 (x_reply_selection_request): Args changed; handle arbitrary array
937 of converted selections stored in converted_selections.
938 Separate the XChangeProperty and SelectionNotify steps.
939 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
940 (x_convert_selection): New function.
941 (x_handle_selection_event): Simplify.
942 (x_get_foreign_selection): Don't ignore incoming requests while
943 waiting for an answer; this will fail when we implement
944 SAVE_TARGETS, and seems unnecessary anyway.
945 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
946 (Vx_sent_selection_functions): Doc fix.
947
948 2011-05-26 Leo Liu <sdl.web@gmail.com>
949
950 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
951
952 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
953
954 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
955
956 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
957 for fringe update if it has periodic bitmap.
958 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
959 and fringe_bitmap_periodic_p.
960
961 * fringe.c (get_fringe_bitmap_data): New function.
962 (draw_fringe_bitmap_1, update_window_fringes): Use it.
963 (update_window_fringes): Record periodicity of fringe bitmap in glyph
964 row. Mark glyph row for fringe update if periodicity changed.
965
966 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
967 for fringe update unless it has periodic bitmap.
968
969 2011-05-25 Kenichi Handa <handa@m17n.org>
970
971 * xdisp.c (get_next_display_element): Set correct it->face_id for
972 a static composition.
973
974 2011-05-24 Leo Liu <sdl.web@gmail.com>
975
976 * deps.mk (fns.o):
977 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
978
979 * fns.c (crypto_hash_function, Fsha1): New function.
980 (Fmd5): Use crypto_hash_function.
981 (syms_of_fns): Add Ssha1.
982
983 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
984
985 * gnutls.c: Remove unused macros.
986 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
987 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
988 Remove macros that are defined and never used.
989 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
990
991 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
992
993 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
994 (Fx_get_selection_internal): Minor cleanup.
995 (Fx_own_selection_internal): Rename arguments for consistency with
996 select.el.
997
998 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
999
1000 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1001
1002 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1003
1004 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1005
1006 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1007
1008 * dispnew.c (scrolling_window): Don't exclude the case that the
1009 last enabled row in the desired matrix touches the bottom boundary.
1010
1011 2011-05-21 Glenn Morris <rgm@gnu.org>
1012
1013 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1014 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1015 and add some more files.
1016
1017 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1018
1019 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1020 report_file_error introduced by the change from 2011-05-07.
1021
1022 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1023
1024 * systime.h (Time): Define only if emacs is defined.
1025 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1026 where the include path doesn't have X11/X.h by default. See
1027 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1028
1029 2011-05-20 Kenichi Handa <handa@m17n.org>
1030
1031 * composite.c (find_automatic_composition): Fix previous change.
1032
1033 2011-05-20 Glenn Morris <rgm@gnu.org>
1034
1035 * lisp.mk: New file, split from Makefile.in.
1036 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1037 (shortlisp): Remove.
1038 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1039
1040 2011-05-19 Glenn Morris <rgm@gnu.org>
1041
1042 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1043 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1044 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1045 (lisp): Set the order to that of loadup.el.
1046 (shortlisp): Make it a copy of $lisp.
1047 (SOME_MACHINE_LISP): Remove.
1048 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1049 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1050
1051 2011-05-18 Kenichi Handa <handa@m17n.org>
1052
1053 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1054 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1055 (find_automatic_composition): Mostly rewrite for efficiency.
1056
1057 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1058
1059 * makefile.w32-in: Update dependencies.
1060
1061 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1062
1063 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1064 revision 104625).
1065
1066 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1067
1068 Fix some integer overflow issues, such as string length overflow.
1069
1070 * insdel.c (count_size_as_multibyte): Check for string overflow.
1071
1072 * character.c (lisp_string_width): Check for string overflow.
1073 Use EMACS_INT, not int, for string indexes and lengths; in
1074 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1075 the resulting string length overflows an EMACS_INT; instead,
1076 report a string overflow if no precision given. When checking for
1077 precision exhaustion, use a check that cannot possibly have
1078 integer overflow. (Bug#8675)
1079 * character.h (lisp_string_width): Adjust to new signature.
1080
1081 * alloc.c (string_overflow): New function.
1082 (Fmake_string): Use it. This doesn't change behavior, but saves
1083 a few bytes and will simplify future changes.
1084 * character.c (string_escape_byte8): Likewise.
1085 * lisp.h (string_overflow): New decl.
1086
1087 Fixups, following up to the user-interface timestamp change.
1088 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1089 for UI timestamps, instead of unsigned long.
1090 * msdos.c (mouse_get_pos): Likewise.
1091 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1092 * w32gui.h (Time): Define by including "systime.h" rather than by
1093 declaring it ourselves. (Bug#8664)
1094
1095 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1096 * image.c (clear_image_cache): Likewise.
1097
1098 * term.c (term_mouse_position): Don't assume time_t wraparound.
1099
1100 Be more systematic about user-interface timestamps.
1101 Before, the code sometimes used 'Time', sometimes 'unsigned long',
1102 and sometimes 'EMACS_UINT', to represent these timestamps.
1103 This change causes it to use 'Time' uniformly, as that's what X uses.
1104 This makes the code easier to follow, and makes it easier to catch
1105 integer overflow bugs such as Bug#8664.
1106 * frame.c (Fmouse_position, Fmouse_pixel_position):
1107 Use Time, not unsigned long, for user-interface timestamps.
1108 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1109 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1110 * keyboard.h (last_event_timestamp): Likewise.
1111 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1112 * menu.h (xmenu_show): Likewise.
1113 * term.c (term_mouse_position): Likewise.
1114 * termhooks.h (struct input_event.timestamp): Likewise.
1115 (struct terminal.mouse_position_hook): Likewise.
1116 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1117 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1118 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1119 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1120 what it was before.
1121 * menu.h, termhooks.h: Include "systime.h", for Time.
1122
1123 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1124 Don't assume that the difference between two unsigned long values
1125 can fit into an integer. At this point, we know button_down_time
1126 <= event->timestamp, so the difference must be nonnegative, so
1127 there's no need to cast the result if double-click-time is
1128 nonnegative, as it should be; check that it's nonnegative, just in
1129 case. This bug is triggered when events are more than 2**31 ms
1130 apart (about 25 days). (Bug#8664)
1131
1132 * xselect.c (last_event_timestamp): Remove duplicate decl.
1133 (x_own_selection): Remove needless cast to unsigned long.
1134
1135 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1136 that always fit in int. Use a sentinel instead of a counter, to
1137 avoid a temp and to allay GCC's concerns about possible int overflow.
1138 * frame.h (struct frame): Use int for menu_bar_items_used
1139 instead of EMACS_INT, since it always fits in int.
1140
1141 * menu.c (grow_menu_items): Check for int overflow.
1142
1143 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1144
1145 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1146 Before, the code was not consistent. These values cannot exceed
1147 2**31 - 1 so there's no need to make them unsigned.
1148 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1149 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1150 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1151 as modifiers.
1152 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1153
1154 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1155 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1156 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1157 presumably because the widths might not match.
1158
1159 * window.c (size_window): Avoid needless test at loop start.
1160
1161 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1162
1163 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1164
1165 2011-05-12 Drew Adams <drew.adams@oracle.com>
1166
1167 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1168
1169 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1170
1171 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1172 `width' to `bar_area_x' and `bar_area_width', respectively.
1173 (x_scroll_run): Take account of fringe background extension.
1174
1175 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1176 Rename local vars `left' and `width' to `bar_area_x' and
1177 `bar_area_width', respectively.
1178 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1179 background extension.
1180
1181 2011-05-10 Jim Meyering <meyering@redhat.com>
1182
1183 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1184
1185 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
1186
1187 * image.c (Finit_image_library): Return t for built-in image types,
1188 like pbm and xbm. (Bug#8640)
1189
1190 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1191
1192 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1193
1194 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1195
1196 * w32console.c (Fset_screen_color): Doc fix.
1197 (Fget_screen_color): New function.
1198 (syms_of_ntterm): Defsubr it.
1199
1200 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1201 unlink the temporary file if Fcall_process didn't create it in the
1202 first place.
1203 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1204 child process will be redirected to a file specified with `:file'.
1205 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1206 cue to call_process_cleanup not to close that handle.
1207
1208 2011-05-07 Ben Key <bkey76@gmail.com>
1209
1210 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1211 one of two shell specific rules, either bootstrap-temacs-CMD or
1212 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1213 to the previous implementation of the bootstrap-temacs rule.
1214 The bootstrap-temacs-CMD rule is similar to the previous
1215 implementation of the bootstrap-temacs rule except that it
1216 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1217 variable.
1218
1219 These changes, along with some changes to nt/configure.bat,
1220 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1221 earlier fix to add support for --cflags and --ldflags options
1222 that include quotes so that it works whether make uses cmd or
1223 sh as the shell.
1224
1225 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1226
1227 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1228 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1229 is a constant.
1230 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1231 a string. Handle both cases.
1232 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1233 (Fdbus_register_method): Use Qinvalid_function.
1234
1235 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1236
1237 * makefile.w32-in: Update dependencies.
1238 (LISP_H): Add inttypes.h and stdin.h.
1239 (PROCESS_H): Add unistd.h.
1240
1241 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1242
1243 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1244 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1245
1246 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1247
1248 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1249
1250 * term.c (vfatal): Remove stray call to va_end.
1251 It's not needed and the C Standard doesn't allow it here anyway.
1252
1253 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1254 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1255
1256 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1257 bytes.
1258
1259 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1260
1261 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1262
1263 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1264
1265 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1266
1267 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1268
1269 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1270 * charset.c (Fdefine_charset_internal): Don't initialize
1271 charset.code_space[15]. The value was garbage, on hosts with
1272 32-bit int (Bug#8600).
1273
1274 * lread.c (read_integer): Be more consistent with string-to-number.
1275 Use string_to_number to do the actual conversion; this avoids
1276 rounding errors and fixes some other screwups. Without this fix,
1277 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1278 (digit_to_number): Move earlier, for benefit of read_integer.
1279 Return -1 if the digit is out of range for the base, -2 if it is
1280 not a digit in any supported base. (Bug#8602)
1281
1282 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1283
1284 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1285 to match comment at start of function. This also removes a
1286 GCC warning about overflow in a 32+64-bit port.
1287
1288 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1289
1290 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1291 Reported by Stefan Monnier in
1292 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1293 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1294 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1295
1296 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1297 (EMACS_UINTPTR): Likewise, with uintptr_t.
1298
1299 * lisp.h: Prefer 64-bit EMACS_INT if available.
1300 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1301 on 32-bit hosts that have 64-bit int, so that they can access
1302 large files.
1303 However, temporarily disable this change unless the temporary
1304 symbol WIDE_EMACS_INT is defined.
1305
1306 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1307
1308 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1309 This removes an assumption that EMACS_INT and long are the same
1310 width as pointers. The assumption is true for Emacs porting targets
1311 now, but we want to make other targets possible.
1312 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1313 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1314 In the rest of the code, change types of integers that hold casted
1315 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1316 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1317 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1318 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1319 No need to cast type when ORing.
1320 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1321 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1322 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1323 assume EMACS_INT is the same width as char *.
1324 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1325 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1326 Remove no-longer-needed casts.
1327 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1328 (xg_tool_bar_help_callback, xg_make_tool_item):
1329 Use EMACS_INTPTR to hold an integer
1330 that will be cast to void *; this can avoid a GCC warning
1331 if EMACS_INT is not the same width as void *.
1332 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1333 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1334 (current_message_1, set_message_1):
1335 Use a local to convert to proper width without a cast.
1336 * xmenu.c (dialog_selection_callback): Likewise.
1337
1338 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1339 Also, don't assume VALBITS / RAND_BITS is less than 5,
1340 and don't rely on undefined behavior when shifting a 1 left into
1341 the sign bit.
1342 * lisp.h (get_random): Change signature to match.
1343
1344 * lread.c (hash_string): Use size_t, not int, for hash computation.
1345 Normally we prefer signed values; but hashing is special, because
1346 it's better to use unsigned division on hash table sizes so that
1347 the remainder is nonnegative. Also, size_t is the natural width
1348 for hashing into memory. The previous code used 'int', which doesn't
1349 retain enough info to hash well into very large tables.
1350 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1351
1352 * dbusbind.c: Don't possibly lose pointer info when converting.
1353 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1354 Use XPNTR rather than XHASH, so that the high-order bits of
1355 the pointer aren't lost when converting through void *.
1356
1357 * eval.c (Fautoload): Don't double-shift a pointer.
1358
1359 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1360
1361 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1362
1363 * gnutls.c (DEF_GNUTLS_FN):
1364 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1365
1366 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1367
1368 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1369 marker. (Bug#8610)
1370
1371 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1372
1373 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1374 New version that can reserve upto 2GB of heap space.
1375
1376 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1377
1378 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1379
1380 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1381
1382 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1383 `gnutls_certificate_set_x509_key_file'.
1384
1385 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1386
1387 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1388 Update dependencies.
1389
1390 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1391
1392 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1393 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1394 Remove unused parameter `fildes'.
1395 * process.c (read_process_output, send_process): Don't pass it.
1396
1397 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1398
1399 Fix previous change: the library cache is defined in w32.c.
1400 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1401 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1402
1403 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1404
1405 Implement dynamic loading of GnuTLS on Windows.
1406
1407 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1408 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1409 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1410 Declare.
1411
1412 * gnutls.c (Qgnutls_dll): Define.
1413 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1414 (gnutls_*): Declare function pointers.
1415 (init_gnutls_functions): New function to initialize function pointers.
1416 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1417 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1418 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1419 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1420 (emacs_gnutls_write, emacs_gnutls_read)
1421 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1422 (Fgnutls_available_p): New function.
1423 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1424 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1425 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1426
1427 * image.c: Include w32.h.
1428 (Vimage_type_cache): Delete.
1429 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1430 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1431 (w32_delayed_load): Move to w32.c.
1432
1433 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1434
1435 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1436 (w32_delayed_load): Move from image.c. When loading a library, record
1437 its filename in the :loaded-from property of the library id.
1438 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1439 Initialize and staticpro them.
1440 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1441
1442 * process.c: Include lisp.h before w32.h, not after.
1443 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1444 instead of gnutls_record_check_pending.
1445
1446 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1447
1448 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1449
1450 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1451 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1452 as passed in.
1453
1454 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1455
1456 * xterm.c (x_set_frame_alpha): Do not set property on anything
1457 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1458
1459 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1460
1461 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1462
1463 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1464
1465 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1466 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1467 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1468 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1469 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1470 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1471 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1472 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1473 (Qgnutls_bootprop_callbacks_verify): Make static.
1474
1475 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1476
1477 * callproc.c: Indentation fixup.
1478
1479 * sysdep.c (wait_for_termination_1): Make static.
1480 (wait_for_termination, interruptible_wait_for_termination):
1481 Move after wait_for_termination_1.
1482
1483 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1484
1485 * sysdep.c (interruptible_wait_for_termination): New function
1486 which is like wait_for_termination, but allows keyboard
1487 interruptions.
1488
1489 * callproc.c (Fcall_process): Add (:file "file") as an option for
1490 the STDOUT buffer.
1491 (Fcall_process_region): Ditto.
1492
1493 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1494
1495 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1496 rather than `XVECTOR (FOO)->size'.
1497
1498 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1499 inttypes.h, as a gnulib replacement is used if it not available in
1500 system headers.
1501
1502 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1503
1504 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1505 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1506 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1507
1508 * coding.c (coding_alloc_by_realloc): Error out if destination
1509 will grow beyond MOST_POSITIVE_FIXNUM.
1510 (decode_coding_emacs_mule): Abort if there isn't enough place in
1511 charbuf for the composition carryover bytes. Reserve an extra
1512 space for up to 2 characters produced in a loop.
1513 (decode_coding_iso_2022): Abort if there isn't enough place in
1514 charbuf for the composition carryover bytes.
1515
1516 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1517
1518 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1519 aborting when %lld or %lll format is passed.
1520 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1521 %llo or %llx format is passed. (Bug#8545)
1522
1523 * window.c (window_scroll_line_based): Use a marker instead of
1524 simple variables to record original value of point. (Bug#7952)
1525
1526 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1527 produced by %s or %c overflows available buffer space. (Bug#8545)
1528
1529 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1530
1531 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1532 (SIZE_MAX): Move defn after all includes, as they might #define it.
1533
1534 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1535
1536 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1537
1538 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1539
1540 * keyboard.c (Qdelayed_warnings_hook): Define.
1541 (command_loop_1): Run `delayed-warnings-hook'
1542 if Vdelayed_warnings_list is non-nil.
1543 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1544 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1545
1546 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1547
1548 * doprnt.c (doprnt): Don't return value smaller than the buffer
1549 size if the message was truncated. (Bug#8545).
1550
1551 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1552
1553 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1554 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1555
1556 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1557
1558 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1559
1560 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1561
1562 * makefile.w32-in: Update dependencies.
1563
1564 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1565
1566 Improve `doprnt' and its usage. (Bug#8545)
1567 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1568 `format_end'. Remove support for %l as a conversion specifier.
1569 Don't use xrealloc. Improve diagnostics when the %l size modifier
1570 is used. Update the commentary.
1571
1572 * eval.c (verror): Simplify calculation of size_t.
1573
1574 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1575 messages.
1576
1577 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1578
1579 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1580 change.
1581
1582 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1583
1584 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1585 This makes this file independent of the recent pseudovector change.
1586
1587 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1588
1589 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1590
1591 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1592 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1593 Remove unused local.
1594 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1595
1596 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1597 GCC 4.6.0 optimizes based on type-based alias analysis.
1598 For example, if b is of type struct buffer * and v of type struct
1599 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1600 != &v->size, and therefore "v->size = 1; b->size = 2; return
1601 v->size;" must therefore return 1. This assumption is incorrect
1602 for Emacs, since it type-puns struct Lisp_Vector * with many other
1603 types. To fix this problem, this patch adds a new type struct
1604 vectorlike_header that documents the constraints on layout of vectors
1605 and pseudovectors, and helps optimizing compilers not get fooled
1606 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1607 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1608 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1609 the size member.
1610 (XSETPVECTYPE): Rewrite in terms of new macro.
1611 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1612 This is a bit clearer, and further avoids the possibility of
1613 undesirable aliasing.
1614 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1615 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1616 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1617 since Lisp_Subr is a special case (no "next" field).
1618 (ASIZE): Now uses header.size rather than size.
1619 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1620 to avoid the hassle of writing XVECTOR (foo)->header.size.
1621 (struct vectorlike_header): New type.
1622 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1623 object, to help avoid aliasing.
1624 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1625 (SUBRP): Likewise, since Lisp_Subr is a special case.
1626 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1627 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1628 (struct Lisp_Hash_Table): Combine first two members into a single
1629 struct vectorlike_header member. All uses of "size" and "next" members
1630 changed to be "header.size" and "header.next".
1631 * buffer.h (struct buffer): Likewise.
1632 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1633 * frame.h (struct frame): Likewise.
1634 * process.h (struct Lisp_Process): Likewise.
1635 * termhooks.h (struct terminal): Likewise.
1636 * window.c (struct save_window_data, struct saved_window): Likewise.
1637 * window.h (struct window): Likewise.
1638 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1639 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1640 * buffer.c (init_buffer_once): Likewise.
1641 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1642 special case.
1643 * process.c (Fformat_network_address): Use local var for size,
1644 for brevity.
1645
1646 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1647
1648 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1649 * data.c (atof): Remove decl; no longer used or needed.
1650 (digit_to_number): Move to lread.c.
1651 (Fstring_to_number): Use new string_to_number function, to be
1652 consistent with how the Lisp reader treats infinities and NaNs.
1653 Do not assume that floating-point numbers represent EMACS_INT
1654 without losing information; this is not true on most 64-bit hosts.
1655 Avoid double-rounding errors, by insisting on integers when
1656 parsing non-base-10 numbers, as the documentation specifies.
1657 * lisp.h (string_to_number): New decl, replacing ...
1658 (isfloat_string): Remove.
1659 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1660 (read1): Do not accept +. and -. as integers; this
1661 appears to have been a coding error. Similarly, do not accept
1662 strings like +-1e0 as floating point numbers. Do not report
1663 overflow for integer overflows unless the base is not 10 which
1664 means we have no simple and reliable way to continue.
1665 Break out the floating-point parsing into a new
1666 function string_to_number, so that Fstring_to_number parses
1667 floating point numbers consistently with the Lisp reader.
1668 (digit_to_number): Move here from data.c. Make it static inline.
1669 (E_CHAR, EXP_INT): Remove, replacing with ...
1670 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1671 (string_to_number): New function, replacing isfloat_string.
1672 This function checks for valid syntax and produces the resulting
1673 Lisp float number too. Rework it so that string-to-number
1674 no longer mishandles examples like "1.0e+". Use strtoumax,
1675 so that overflow for non-base-10 numbers is reported only when
1676 there's no portable and simple way to convert to floating point.
1677
1678 * textprop.c (set_text_properties_1): Rewrite for clarity,
1679 and to avoid GCC warning about integer overflow.
1680
1681 * intervals.h (struct interval): Use EMACS_INT for members
1682 where EMACS_UINT might cause problems. See
1683 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1684 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1685 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1686 All uses changed.
1687 (offset_intervals): Tell GCC not to worry about length overflow
1688 when negating a negative length.
1689
1690 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1691 (overrun_check_free): Likewise.
1692
1693 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1694 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1695 word size.
1696
1697 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1698 (gnutls_make_error): Rename local to avoid shadowing.
1699 (gnutls_emacs_global_deinit): ifdef out; not used.
1700 (Fgnutls_boot): Use const for pointer to readonly storage.
1701 Comment out unused local. Fix pointer signedness problems.
1702
1703 * lread.c (openp): Don't stuff size_t into an 'int'.
1704 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1705 about possible signed overflow.
1706
1707 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1708 (GDK_KEY_g): Don't define if already defined.
1709 (xg_prepare_tooltip): Avoid pointer signedness problem.
1710 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1711
1712 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1713 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1714
1715 * xfns.c (Fx_window_property): Simplify a bit,
1716 to make a bit faster and to avoid GCC 4.6.0 warning.
1717 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1718
1719 * fns.c (internal_equal): Don't assume size_t fits in int.
1720
1721 * alloc.c (compact_small_strings): Tighten assertion a little.
1722
1723 Replace pEd with more-general pI, and fix some printf arg casts.
1724 * lisp.h (pI): New macro, generalizing old pEd macro to other
1725 conversion specifiers. For example, use "...%"pI"d..." rather
1726 than "...%"pEd"...".
1727 (pEd): Remove. All uses replaced with similar uses of pI.
1728 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1729 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1730 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1731 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1732 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1733 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1734 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1735 64-bit hosts.
1736 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1737 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1738 * print.c (safe_debug_print, print_object): Likewise.
1739 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1740 to int.
1741 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1742 avoiding the 0 flag, which is not portable.
1743 * process.c (Fmake_network_process): Use pI to avoid cast.
1744 * region-cache.c (pp_cache): Likewise.
1745 * xdisp.c (decode_mode_spec): Likewise.
1746 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1747 behavior on 64-bit hosts with printf arg.
1748 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
1749 (x_stop_queuing_selection_requests): Likewise.
1750 (x_get_window_property): Don't truncate byte count to an 'int'
1751 when tracing.
1752
1753 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1754 here, since it parses constructs like leading '-' and spaces,
1755 which are not wanted; and it overflows with large numbers.
1756 Instead, simply match F[0-9]+, which is what is wanted anyway.
1757
1758 * alloc.c: Remove unportable assumptions about struct layout.
1759 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1760 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1761 (allocate_vectorlike, make_pure_vector): Use the new macros,
1762 plus offsetof, to remove unportable assumptions about struct layout.
1763 These assumptions hold on all porting targets that I know of, but
1764 they are not guaranteed, they're easy to remove, and removing them
1765 makes further changes easier.
1766
1767 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1768 This doesn't fix a bug but makes the code clearer.
1769 (string_overrun_cookie): Now const. Use initializers that
1770 don't formally overflow signed char, to avoid warnings.
1771 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1772 can cause Emacs to crash when string overrun checking is enabled.
1773 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1774 multiple of sizeof (EMACS_INT); it need not be, if
1775 alignof(EMACS_INT) < sizeof (EMACS_INT).
1776 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
1777
1778 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
1779
1780 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1781
1782 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1783
1784 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
1785 supposed to be handshaking. (Bug#8556)
1786 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1787
1788 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
1789
1790 * lisp.h (Qdebug): List symbol.
1791 * eval.c (Qdebug): Restore global linkage.
1792 * keyboard.c (debug-on-event): New variable.
1793 (handle_user_signal): Break into debugger when debug-on-event
1794 matches the current signal symbol.
1795
1796 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1797
1798 * alloc.c (check_sblock, check_string_bytes)
1799 (check_string_free_list): Convert to standard C.
1800
1801 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1802
1803 * w32.c (emacs_gnutls_push): Fix typo.
1804
1805 2011-04-25 Eli Zaretskii <eliz@gnu.org>
1806
1807 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1808 "cast to pointer from integer of different size".
1809
1810 Improve doprnt and its use in verror. (Bug#8545)
1811 * doprnt.c (doprnt): Document the set of format control sequences
1812 supported by the function. Use SAFE_ALLOCA instead of always
1813 using `alloca'.
1814
1815 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1816 is one byte too soon. Don't use xrealloc; instead xfree and
1817 xmalloc anew.
1818
1819 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1820
1821 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1822 callbacks stage.
1823
1824 * gnutls.c: Renamed global_initialized to
1825 gnutls_global_initialized. Added internals for the
1826 :verify-hostname-error, :verify-error, and :verify-flags
1827 parameters of `gnutls-boot' and documented those parameters in the
1828 docstring. Start callback support.
1829 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1830 unless a fatal error occured. Call gnutls_alert_send_appropriate
1831 on error. Return error code.
1832 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1833 (emacs_gnutls_read): Likewise.
1834 (Fgnutls_boot): Return handshake error code.
1835 (emacs_gnutls_handle_error): New function.
1836 (wsaerror_to_errno): Likewise.
1837
1838 * w32.h (emacs_gnutls_pull): Add prototype.
1839 (emacs_gnutls_push): Likewise.
1840
1841 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1842 (emacs_gnutls_push): Likewise.
1843
1844 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1845
1846 * process.c (wait_reading_process_output): Check if GnuTLS
1847 buffered some data internally if no FDs are set for TLS
1848 connections.
1849
1850 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1851 (LIBS): Link to USER_LIBS.
1852 ($(BLD)/gnutls.$(0)): New target.
1853
1854 2011-04-24 Eli Zaretskii <eliz@gnu.org>
1855
1856 * xdisp.c (handle_single_display_spec): Rename the
1857 display_replaced_before_p argument into display_replaced_p, to
1858 make it consistent with the commentary. Fix typos in the
1859 commentary.
1860
1861 * textprop.c (syms_of_textprop): Remove dead code.
1862 (copy_text_properties): Delete obsolete commentary about an
1863 interface that was deleted long ago. Fix typos in the description
1864 of arguments.
1865
1866 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1867 to changes in oldXMenu/XMenu.h from 2011-04-16.
1868 <menu_help_message, prev_menu_help_message>: Constify.
1869 (IT_menu_make_room): menu->help_text is now `const char **';
1870 adjust.
1871
1872 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1873 to changes in oldXMenu/XMenu.h from 2011-04-16.
1874 (struct XMenu): Declare `help_text' `const char **'.
1875
1876 * xfaces.c <Qunspecified>: Make extern again.
1877
1878 * syntax.c: Include sys/types.h before including regex.h, as
1879 required by Posix.
1880
1881 * doc.c (get_doc_string): Improve the format passed to `error'.
1882
1883 * doprnt.c (doprnt): Improve commentary.
1884
1885 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1886
1887 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1888 them with etags.
1889
1890 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1891 changes in globals.h immediately force recompilation.
1892 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1893 $(CURDIR)/s/ms-w32.h.
1894 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
1895
1896 * character.c (Fchar_direction): Function deleted.
1897 (syms_of_character): Don't defsubr it.
1898 <char-direction-table>: Deleted.
1899
1900 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1901
1902 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1903 * doprnt.c: Include limits.h.
1904 (SIZE_MAX): New macro.
1905 (doprnt): Return a size_t value. 2nd arg is now size_t.
1906 Many local variables are now size_t instead of int or unsigned.
1907 Improve overflow protection. Support `l' modifier for integer
1908 conversions. Support %l conversion. Don't assume an EMACS_INT
1909 argument for integer conversions and for %c.
1910
1911 * lisp.h (doprnt): Restore prototype.
1912
1913 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1914 $(SRC)/character.h.
1915
1916 * Makefile.in (base_obj): Add back doprnt.o.
1917
1918 * deps.mk (doprnt.o): Add back prerequisites.
1919 (callint.o): Depend on character.h.
1920
1921 * eval.c (internal_lisp_condition_case): Include the handler
1922 representation in the error message.
1923 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1924 when breaking from the loop.
1925
1926 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1927
1928 * callint.c (Fcall_interactively): When displaying error message
1929 about invalid control letter, pass the character's codepoint, not
1930 a pointer to its multibyte form. Improve display of the character
1931 in octal and display also its hex code.
1932
1933 * character.c (char_string): Use %x to display the (unsigned)
1934 codepoint of an invalid character, to avoid displaying a bogus
1935 negative value.
1936
1937 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1938 `error', not SYMBOL_NAME itself.
1939
1940 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1941 character arguments to `error'.
1942
1943 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1944 to `error' in error message about FINAL_CHAR argument. Make sure
1945 FINAL_CHAR is a character, and use %c when it is passed as
1946 argument to `error'.
1947
1948 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1949
1950 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1951
1952 * w32.c: Include <time.h>.
1953 (sys_localtime): New function.
1954
1955 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
1956
1957 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1958
1959 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1960
1961 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1962
1963 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1964 zombies (Bug#8467).
1965
1966 2011-04-19 Eli Zaretskii <eliz@gnu.org>
1967
1968 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1969 gl_state.e_property when gl_state.object is Qt.
1970
1971 * insdel.c (make_gap_larger): Remove limitation of buffer size
1972 to <= INT_MAX.
1973
1974 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
1975
1976 * xdisp.c (lookup_glyphless_char_display)
1977 (produce_glyphless_glyph): Handle cons cell entry in
1978 glyphless-char-display.
1979 (Vglyphless_char_display): Document it.
1980
1981 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1982 glyphless-char-display.
1983
1984 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
1985
1986 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1987
1988 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1989
1990 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1991 definition for no-X builds.
1992
1993 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1994
1995 Static checks with GCC 4.6.0 and non-default toolkits.
1996
1997 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1998
1999 * process.c (keyboard_bit_set): Define only if SIGIO.
2000 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2001 (send_process): Repair possible setjmp clobbering.
2002
2003 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2004
2005 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2006
2007 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2008
2009 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2010 Define only if needed.
2011
2012 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2013 by pacifying GCC about it. Maybe it's time to retire it?
2014 * xfaces.c (USG, __TIMEVAL__): Likewise.
2015
2016 * dispextern.h (struct redisplay_interface): Rename param
2017 to avoid shadowing.
2018 * termhooks.h (struct terminal): Likewise.
2019 * xterm.c (xembed_send_message): Likewise.
2020
2021 * insdel.c (make_gap_smaller): Define only if
2022 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2023
2024 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2025 it.
2026
2027 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2028 so that we aren't warned about unused symbols.
2029
2030 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2031
2032 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2033
2034 * xfns.c (x_real_positions): Mark locals as initialized.
2035
2036 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2037
2038 * xterm.c: Fix problems found by static analysis with other toolkits.
2039 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2040 (x_dispatch_event): Declare static if USE_GTK, and
2041 define if USE_GTK || USE_X_TOOLKIT.
2042 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2043 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2044 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2045 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2046
2047 * xmenu.c (menu_help_callback): Pointer type fixes.
2048 Use const pointers when pointing at readonly data. Avoid pointer
2049 signedness clashes.
2050 (FALSE): Remove unused macro.
2051 (update_frame_menubar): Remove unused decl.
2052
2053 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2054
2055 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2056 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2057 (single_menu_item): Rename local to avoid shadowing.
2058
2059 * keyboard.c (make_lispy_event): Remove unused local var.
2060
2061 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2062 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2063
2064 * bitmaps: Change bitmaps from unsigned char back to the X11
2065 compatible char. Avoid the old compiler warnings about
2066 out-of-range initializers by using, for example, '\xab' rather
2067 than 0xab.
2068
2069 * xgselect.c (xgselect_initialize): Check vs interface
2070 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2071
2072 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2073
2074 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2075 to read-only memory.
2076
2077 * fns.c (vector): Remove; this old hack is no longer needed.
2078
2079 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2080 Remove unused var.
2081 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2082
2083 * xrdb.c (x_load_resources): Omit unused local.
2084
2085 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2086 (x_window): Rename locals to avoid shadowing.
2087 (USG): Use the kludged USG macro, to pacify gcc.
2088
2089 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2090 (x_term_init): Remove local to avoid shadowing.
2091
2092 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2093
2094 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2095 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2096
2097 2011-04-16 Eli Zaretskii <eliz@gnu.org>
2098
2099 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2100
2101 Fix regex.c, syntax.c and friends for buffers > 2GB.
2102 * syntax.h (struct gl_state_s): Declare character position members
2103 EMACS_INT.
2104
2105 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2106
2107 * textprop.c (verify_interval_modification, interval_of):
2108 Declare arguments EMACS_INT.
2109
2110 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2111 EMACS_INT.
2112
2113 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2114
2115 * indent.c (Fvertical_motion): Local variable it_start is now
2116 EMACS_INT.
2117
2118 * regex.c (re_match, re_match_2, re_match_2_internal)
2119 (bcmp_translate, regcomp, regexec, print_double_string)
2120 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2121 (re_compile_pattern, re_exec): Declare arguments and local
2122 variables `size_t' and `ssize_t' and return values `regoff_t', as
2123 appropriate.
2124 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2125 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2126 <compile_stack_type>: `size' and `avail' are now `size_t'.
2127
2128 * regex.h <regoff_t>: Use ssize_t, not int.
2129 (re_search, re_search_2, re_match, re_match_2): Arguments that
2130 specify buffer/string position and length are now ssize_t and
2131 size_t. Return type is regoff_t.
2132
2133 2011-04-16 Ben Key <bkey76@gmail.com>
2134
2135 * nsfont.m: Fixed bugs in ns_get_family and
2136 ns_descriptor_to_entity that were caused by using free to
2137 deallocate memory blocks that were allocated by xmalloc (via
2138 xstrdup). This caused Emacs to crash when compiled with
2139 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2140 --enable-checking=xmallocoverrun). xfree is now used to
2141 deallocate these memory blocks.
2142
2143 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
2144
2145 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2146
2147 emacs_write: Accept and return EMACS_INT for sizes.
2148 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2149 et seq.
2150 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2151 Accept and return EMACS_INT.
2152 (emacs_gnutls_write): Return the number of bytes written on
2153 partial writes.
2154 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
2155 (emacs_read, emacs_write): Remove check for negative size, as the
2156 Emacs source code has been audited now.
2157 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2158 (emacs_read, emacs_write): Use it.
2159 * process.c (send_process): Adjust to the new signatures of
2160 emacs_write and emacs_gnutls_write. Do not attempt to store
2161 a byte offset into an 'int'; it might overflow.
2162 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
2163
2164 * sound.c: Don't assume sizes fit in 'int'.
2165 (struct sound_device.period_size, alsa_period_size):
2166 Return EMACS_INT, not int.
2167 (struct sound_device.write, vox_write, alsa_write):
2168 Accept EMACS_INT, not int.
2169 (wav_play, au_play): Use EMACS_INT to store sizes and to
2170 record read return values.
2171
2172 2011-04-15 Ben Key <bkey76@gmail.com>
2173
2174 * keyboard.c (Qundefined): Don't declare static since it is used
2175 in nsfns.m.
2176 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2177 static since they are used in nsfont.m.
2178
2179 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2180
2181 * process.c (Qprocessp): Don't declare static.
2182 * lisp.h (Qprocessp): Declare again.
2183
2184 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
2185
2186 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2187
2188 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2189
2190 Improve C-level modularity by making more things 'static'.
2191
2192 Don't publish debugger-only interfaces to other modules.
2193 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2194 (verify_bytepos, count_markers): Move decls to the only modules
2195 that need them.
2196 * region-cache.h (pp_cache): Likewise.
2197 * window.h (check_all_windows): Likewise.
2198 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2199
2200 * sysdep.c (croak): Now static, if
2201 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2202 * syssignal.h (croak): Declare only if not static.
2203
2204 * alloc.c (refill_memory_reserve): Now static if
2205 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2206 * lisp.h (refill_memory_reserve): Declare only if not static.
2207
2208 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2209 Define only if USE_LUCID.
2210
2211 * xrdb.c (x_customization_string, x_rm_string): Now static.
2212
2213 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2214 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2215
2216 * xdisp.c (draw_row_with_mouse_face): Now static.
2217 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2218
2219 * window.h (check_all_windows): Mark externally visible.
2220
2221 * window.c (window_deletion_count): Now static.
2222
2223 * undo.c: Make symbols static if they're not exported.
2224 (last_undo_buffer, last_boundary_position, pending_boundary):
2225 Now static.
2226
2227 * textprop.c (interval_insert_behind_hooks): Now static.
2228 (interval_insert_in_front_hooks): Likewise.
2229
2230 * term.c: Make symbols static if they're not exported.
2231 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2232 (max_frame_lines, tty_set_terminal_modes):
2233 (tty_reset_terminal_modes, tty_turn_off_highlight):
2234 (get_tty_terminal): Now static.
2235 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2236 * termhooks.h (term_mouse_moveto): Do not declare if
2237 HAVE_WINDOW_SYSTEM.
2238 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2239 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2240
2241 * sysdep.c: Make symbols static if they're not exported.
2242 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2243 Now static.
2244 (sigprocmask_set, full_mask): Remove; unused.
2245 (wait_debugging): Mark as visible.
2246 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2247 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2248
2249 * syntax.c (syntax_temp): Define only if !__GNUC__.
2250
2251 * sound.c (current_sound_device, current_sound): Now static.
2252
2253 * search.c (searchbufs, searchbuf_head): Now static.
2254
2255 * scroll.c (scroll_cost): Remove; unused.
2256 * dispextern.h (scroll_cost): Remove decl.
2257
2258 * region-cache.h (pp_cache): Mark as externally visible.
2259
2260 * process.c: Make symbols static if they're not exported.
2261 (process_tick, update_tick, create_process, chan_process):
2262 (Vprocess_alist, proc_buffered_char, datagram_access):
2263 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2264 (deactivate_process): Mark defn as static, as well as decl.
2265 * lisp.h (create_process): Remove decl.
2266 * process.h (chan_process, Vprocess_alist): Remove decls.
2267
2268 * print.c: Make symbols static if they're not exported.
2269 (print_depth, new_backquote_output, being_printed, print_buffer):
2270 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2271 (print_interval, print_number_index, initial_stderr_stream):
2272 Now static.
2273 * lisp.h (Fprinc): Remove decl.
2274 (debug_output_compilation_hack): Mark as externally visible.
2275
2276 * sysdep.c (croak): Move decl from here to syssignal.h.
2277 * syssignal.h (croak): Put it here, so the API can be checked when
2278 'croak' is called from dissociate_if_controlling_tty.
2279
2280 * minibuf.c: Make symbols static if they're not exported.
2281 (minibuf_save_list, choose_minibuf_frame): Now static.
2282 * lisp.h (choose_minibuf_frame): Remove decl.
2283
2284 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2285
2286 * lread.c: Make symbols static if they're not exported.
2287 (read_objects, initial_obarray, oblookup_last_bucket_number):
2288 Now static.
2289 (make_symbol): Remove; unused.
2290 * lisp.h (initial_obarray, make_symbol): Remove decls.
2291
2292 * keyboard.c: Make symbols static if they're not exported.
2293 (single_kboard, recent_keys_index, total_keys, recent_keys):
2294 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2295 (this_single_command_key_start, echoing, last_auto_save):
2296 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2297 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2298 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2299 (Vlispy_mouse_stem, double_click_count):
2300 Now static.
2301 (force_auto_save_soon): Define only if SIGDANGER.
2302 (ignore_mouse_drag_p): Now static if
2303 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2304 (print_help): Remove; unused.
2305 (stop_character, last_timer_event): Mark as externally visible.
2306 * keyboard.h (ignore_mouse_drag_p): Declare only if
2307 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2308 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2309 * lisp.h (echoing): Remove decl.
2310 (force_auto_save_soon): Declare only if SIGDANGER.
2311 * xdisp.c (redisplay_window): Simplify code, to make it more
2312 obvious that ignore_mouse_drag_p is not accessed if !defined
2313 USE_GTK && !defined HAVE_NS.
2314
2315 * intervals.c: Make symbols static if they're not exported.
2316 (merge_properties_sticky, merge_interval_right, delete_interval):
2317 Now static.
2318 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2319
2320 * insdel.c: Make symbols static if they're not exported.
2321 However, leave prepare_to_modify_buffer alone. It's never
2322 called from outside this function, but that appears to be a bug.
2323 (combine_after_change_list, combine_after_change_buffer):
2324 (adjust_after_replace, signal_before_change): Now static.
2325 (adjust_after_replace_noundo): Remove; unused.
2326 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2327 (signal_before_change): Remove decls.
2328
2329 * indent.c (val_compute_motion, val_vmotion): Now static.
2330
2331 * image.c: Make symbols static if they're not exported.
2332 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2333 if USE_GTK.
2334 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2335 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2336
2337 * fringe.c (standard_bitmaps): Now static.
2338 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2339
2340 * frame.c: Make symbols static if they're not exported.
2341 (x_report_frame_params, make_terminal_frame): Now static.
2342 (get_frame_param): Now static, unless HAVE_NS.
2343 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2344 (x_get_resource_string): Remove; not used.
2345 * frame.h (make_terminal_frame, x_report_frame_params):
2346 (x_get_resource_string); Remove decls.
2347 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2348 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2349
2350 * font.c, fontset.c: Make symbols static if they're not exported.
2351 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2352 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2353 * font.c (font_close_object): Now static.
2354 * font.h (font_close_object): Remove.
2355 * fontset.c (FONTSET_OBJLIST): Remove.
2356 (free_realized_fontset) #if-0 the body, which does nothing.
2357 (face_suitable_for_char_p): #if-0, as it's never called.
2358 * fontset.h (face_suitable_for_char_p): Remove decl.
2359 * xfaces.c (face_at_string_position):
2360 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2361 since 0 is always ASCII.
2362
2363 * fns.c (weak_hash_tables): Now static.
2364
2365 * fileio.c: Make symbols static if they're not exported.
2366 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2367 (Vwrite_region_annotation_buffers): Now static.
2368
2369 * eval.c: Make symbols static if they're not exported.
2370 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2371 * lisp.h (backtrace_list): Remove decl.
2372
2373 * emacs.c: Make symbols static if they're not exported.
2374 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2375 (fatal_error_code, fatal_error_signal_hook, standard_args):
2376 Now static.
2377 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2378 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2379 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2380 * lisp.h (fatal_error_signal_hook): Remove decl.
2381 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2382
2383 * editfns.c: Move a (normally-unused) function to its only use.
2384 * editfns.c, lisp.h (get_operating_system_release): Remove.
2385 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2386 worth the hassle of breaking this out.
2387
2388 * xterm.c: Make symbols static if they're not exported.
2389 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2390 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2391 (x_destroy_window, x_delete_display):
2392 Now static.
2393 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2394 (x_mouse_leave): Remove; unused.
2395 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2396 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2397 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2398 Remove decls.
2399 (x_mouse_leave): Declare only if WINDOWSNT.
2400 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2401 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2402 USE_X_TOOLKIT.
2403
2404 * ftxfont.c: Make symbols static if they're not exported.
2405 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2406 HAVE_FREETYPE.
2407 * font.h (ftxfont_driver): Likewise.
2408
2409 * xfns.c: Make symbols static if they're not exported.
2410 (x_last_font_name, x_display_info_for_name):
2411 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2412 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2413 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2414 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2415 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2416 (last_show_tip_args): Now static.
2417 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2418 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2419 (x_screen_planes): Remove; unused.
2420 * dispextern.h (x_screen_planes): Remove decl.
2421
2422 * dispnew.c: Make symbols static if they're not exported.
2423 * dispextern.h (redraw_garbaged_frames, scrolling):
2424 (increment_row_positions): Remove.
2425 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2426 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2427 Now static.
2428 (redraw_garbaged_frames): Remove; unused.
2429
2430 * xfaces.c: Make symbols static if they're not exported.
2431 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2432 Remove decls.
2433 * xterm.h (defined_color): Remove decls.
2434 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2435 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2436 (menu_face_changed_default, defined_color, free_realized_face):
2437 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2438 (ascii_face_of_lisp_face): Remove; unused.
2439
2440 * xdisp.c: Make symbols static if they're not exported.
2441 * dispextern.h (scratch_glyph_row, window_box_edges):
2442 (glyph_to_pixel_coords, set_cursor_from_row):
2443 (get_next_display_element, set_iterator_to_next):
2444 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2445 (show_mouse_face): Remove decls
2446 * frame.h (message_buf_print): Likewise.
2447 * lisp.h (pop_message, set_message, check_point_in_composition):
2448 Likewise.
2449 * xterm.h (set_vertical_scroll_bar): Likewise.
2450 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2451 (message_buf_print, scratch_glyph_row, displayed_buffer):
2452 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2453 (get_next_display_element, show_mouse_face, window_box_edges):
2454 (frame_to_window_pixel_xy, check_point_in_composition):
2455 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2456 (glyph_to_pixel_coords): Remove; unused.
2457
2458 * dired.c (file_name_completion): Now static.
2459
2460 * dbusbind.c (xd_in_read_queued_messages): Now static.
2461
2462 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2463 * data.c (circular_list_error): Remove.
2464
2465 * commands.h (last_point_position, last_point_position_buffer):
2466 (last_point_position_window): Remove decls.
2467 * keyboard.c: Make these variables static.
2468
2469 * coding.h (coding, code_convert_region, encode_coding_gap):
2470 Remove decls.
2471 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2472 (iso_code_class, detect_coding, code_convert_region): Now static.
2473 (encode_coding_gap): Remove; unused.
2474
2475 * chartab.c (chartab_chars, chartab_bits): Now static.
2476
2477 * charset.h (charset_iso_8859_1): Remove decl.
2478 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2479 Now static.
2480
2481 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2482 * ccl.c (Vccl_program_table): Now static.
2483 (check_ccl_update): Remove; unused.
2484
2485 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2486 * category.h: ... from here.
2487 * category.c (check_category_table, set_category_set): Now static.
2488
2489 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2490 * lisp.h: Remove these decls.
2491
2492 * buffer.c (buffer_count): Remove unused var.
2493
2494 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2495 so that it's not optimized away.
2496 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2497 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2498 exported only to the debugger.
2499
2500 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2501 * atimer.h (run_all_atimers): Remove; not exported.
2502
2503 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2504 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2505 was inaccessible from Lisp.
2506 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2507 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2508
2509 alloc.c: Import and export fewer symbols, and remove unused items.
2510 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2511 is defined.
2512 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2513 it's not optimized away by whole-program optimization.
2514 (message_enable_multibyte, free_misc): Remove.
2515 (catchlist, handlerlist, mark_backtrace):
2516 Declare only if BYTE_MARK_STACK.
2517 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2518 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2519 (message_enable_multibyte): Remove decl.
2520 (free_misc, interval_free_list, float_block, float_block_index):
2521 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2522 (cons_free_list, last_marked_index):
2523 Now static.
2524 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2525 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2526 (mark_backtrace): Define only if BYTE_MARK_STACK.
2527 * xdisp.c (message_enable_multibyte): Now static.
2528
2529 Declare Lisp_Object Q* variables to be 'static' if not exported.
2530 This makes it easier for human readers (and static analyzers)
2531 to see whether these variables are used from other modules.
2532 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2533 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2534 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2535 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2536 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2537 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2538 * xmenu.c, xselect.c:
2539 Declare Q* vars static if they are not used in other modules.
2540 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2541 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2542 Remove decls of unexported vars.
2543 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2544
2545 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2546
2547 Make Emacs functions such as Fatom 'static' by default.
2548 This makes it easier for human readers (and static analyzers)
2549 to see whether these functions can be called from other modules.
2550 DEFUN now defines a static function. To make the function external
2551 so that it can be used in other C modules, use the new macro DEFUE.
2552 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2553 (Finit_image_library):
2554 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2555 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2556 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2557 Remove decls, since these functions are now static.
2558 (Funintern, Fget_internal_run_time): New decls, since these functions
2559 were already external.
2560
2561 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2562 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2563 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2564 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2565 * keyboard.c, keymap.c, lread.c:
2566 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2567 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2568 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2569 Mark functions with DEFUE instead of DEFUN,
2570 if they are used in other modules.
2571 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2572 decls for now-static functions.
2573 * buffer.h (Fdelete_overlay): Remove decl.
2574 * callproc.c (Fgetenv_internal): Mark as internal.
2575 * composite.c (Fremove_list_of_text_properties): Remove decl.
2576 (Fcomposition_get_gstring): New forward static decl.
2577 * composite.h (Fcomposite_get_gstring): Remove decl.
2578 * dired.c (Ffile_attributes): New forward static decl.
2579 * doc.c (Fdocumntation_property): New forward static decl.
2580 * eval.c (Ffetch_bytecode): New forward static decl.
2581 (Funintern): Remove extern decl; now in .h file where it belongs.
2582 * fileio.c (Fmake_symbolic_link): New forward static decl.
2583 * image.c (Finit_image_library): New forward static decl.
2584 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2585 * intervals.h (Fprevious_property_change):
2586 (Fremove_list_of_text_properties): Remove decls.
2587 * keyboard.c (Fthis_command_keys): Remove decl.
2588 (Fcommand_execute): New forward static decl.
2589 * keymap.c (Flookup_key): New forward static decl.
2590 (Fcopy_keymap): Now static.
2591 * keymap.h (Flookup_key): Remove decl.
2592 * process.c (Fget_process): New forward static decl.
2593 (Fprocess_datagram_address): Mark as internal.
2594 * syntax.c (Fsyntax_table_p): New forward static decl.
2595 (skip_chars): Remove duplicate decl.
2596 * textprop.c (Fprevious_property_change): New forward static decl.
2597 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2598 Now internal.
2599 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2600 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2601
2602 * editfns.c (Fformat): Remove unreachable code.
2603
2604 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2605
2606 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2607 change. (Bug#8496)
2608
2609 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2610
2611 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2612 when at ZV. (Bug#8487)
2613
2614 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2615
2616 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2617 (Bug#8437)
2618 * keyboard.c (parse_tool_bar_item): Likewise.
2619 * sound.c (sound_cleanup, alsa_close): Likewise.
2620 * termcap.c (tgetent): Likewise.
2621 * xfns.c (x_default_font_parameter): Likewise.
2622 * xsettings.c (read_and_apply_settings): Likewise.
2623
2624 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2625 (overrun_check_free): Protoize.
2626
2627 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2628
2629 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2630 since callers should never pass a negative size.
2631 Change the signature to match that of plain 'read' and 'write'; see
2632 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2633 * lisp.h: Update prototypes of emacs_write and emacs_read.
2634
2635 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2636
2637 * xdisp.c (redisplay_window): Don't try to determine the character
2638 position of the scroll margin if the window start point w->startp
2639 is outside the buffer's accessible region. (Bug#8468)
2640
2641 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2642
2643 Fix write-region and its subroutines for buffers > 2GB.
2644 * fileio.c (a_write, e_write): Modify declaration of arguments and
2645 local variables to support buffers larger than 2GB.
2646 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2647
2648 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2649 argument, local variables, and return value.
2650
2651 * lisp.h: Update prototypes of emacs_write and emacs_read.
2652
2653 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2654
2655 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2656
2657 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2658
2659 Fix more problems found by GCC 4.6.0's static checks.
2660
2661 * xdisp.c (vmessage): Use a better test for character truncation.
2662
2663 * charset.c (load_charset_map): <, not <=, for optimization,
2664 and to avoid potential problems with integer overflow.
2665 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2666 * casetab.c (set_identity, shuffle): Likewise.
2667 * editfns.c (Fformat): Likewise.
2668 * syntax.c (skip_chars): Likewise.
2669
2670 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2671 This also lets GCC 4.6.0 generate slightly better loop code.
2672
2673 * callint.c (Fcall_interactively): <, not <=, for optimization.
2674 (Fcall_interactively): Count the number of arguments produced,
2675 not the number of arguments given. This is simpler and lets GCC
2676 4.6.0 generate slightly better code.
2677
2678 * ftfont.c: Distingish more carefully between FcChar8 and char.
2679 The previous code passed unsigned char * to a functions like
2680 strlen and xstrcasecmp that expect char *, which does not
2681 conform to the C standard.
2682 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2683 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2684 char * when the C standard requires it.
2685
2686 * keyboard.c (read_char): Remove unused var.
2687
2688 * eval.c: Port to Windows vsnprintf (Bug#8435).
2689 Include <limits.h>.
2690 (SIZE_MAX): Define if the headers do not.
2691 (verror): Do not give up if vsnprintf returns a negative count.
2692 Instead, grow the buffer. This ports to Windows vsnprintf, which
2693 does not conform to C99. Problem reported by Eli Zaretskii.
2694 Also, simplify the allocation scheme, by avoiding the need for
2695 calling realloc, and removing the ALLOCATED variable.
2696
2697 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2698
2699 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2700 But keep the doprint source code for now, as we might revamp it
2701 and use it again (Bug#8435).
2702 * lisp.h (doprnt): Remove.
2703 * Makefile.in (base_obj): Remove doprnt.o.
2704 * deps.mk (doprnt.o): Remove.
2705
2706 error: Print 32- and 64-bit integers portably (Bug#8435).
2707 Without this change, on typical 64-bit hosts error ("...%d...", N)
2708 was used to print both 32- and 64-bit integers N, which relied on
2709 undefined behavior.
2710 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2711 New macro.
2712 * lisp.h (error, verror): Mark as printf-like functions.
2713 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2714 Report overflow in size calculations when allocating printf buffer.
2715 Do not truncate output string at its first null byte.
2716 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2717 Truncate the output at a character boundary, since vsnprintf does not
2718 do that.
2719 * charset.c (check_iso_charset_parameter): Convert internal
2720 character to string before calling 'error', since %c now has the
2721 printf meaning.
2722 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2723 overflow when computing char to be passed to 'error'. Do not
2724 pass Lisp_Object to 'error'; pass the integer instead.
2725 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2726 formatted with plain %d.
2727
2728 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2729
2730 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2731
2732 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2733
2734 * xterm.c (x_catch_errors): Remove duplicate declaration.
2735
2736 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2737
2738 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2739
2740 2011-04-10 Jim Meyering <meyering@redhat.com>
2741
2742 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2743 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2744 return ssize_t not "int", and use size_t as the buffer length.
2745 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2746 * gnutls.h: Update declarations.
2747 * process.c (read_process_output): Use ssize_t, to match.
2748 (send_process): Likewise.
2749
2750 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2751
2752 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2753
2754 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2755
2756 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2757 Use unsigned char, to match FcChar8 type definition.
2758
2759 * xterm.c (handle_one_xevent):
2760 * xmenu.c (create_and_show_popup_menu):
2761 * xselect.c (x_decline_selection_request)
2762 (x_reply_selection_request): Avoid type-punned deref of X events.
2763
2764 2011-04-09 Eli Zaretskii <eliz@gnu.org>
2765
2766 Fix some uses of `int' instead of EMACS_INT.
2767 * search.c (string_match_1, fast_string_match)
2768 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2769 (scan_buffer, find_next_newline_no_quit)
2770 (find_before_next_newline, search_command, Freplace_match)
2771 (Fmatch_data): Make some `int' variables be EMACS_INT.
2772
2773 * xdisp.c (display_count_lines): 3rd argument and return value now
2774 EMACS_INT. All callers changed.
2775 (pint2hrstr): Last argument is now EMACS_INT.
2776
2777 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2778 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2779 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2780 (decode_coding_utf_16, decode_coding_emacs_mule)
2781 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2782 (decode_coding_ccl, decode_coding_charset)
2783 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2784 (decode_coding_iso_2022, decode_coding_emacs_mule)
2785 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2786 <char_offset, last_offset>: Declare EMACS_INT.
2787 (encode_coding_utf_8, encode_coding_utf_16)
2788 (encode_coding_emacs_mule, encode_invocation_designation)
2789 (encode_designation_at_bol, encode_coding_iso_2022)
2790 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2791 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2792 Declare EMACS_INT.
2793 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2794 (encode_invocation_designation): Last argument P_NCHARS is now
2795 EMACS_INT.
2796 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2797 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2798
2799 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2800 All users changed.
2801
2802 * ccl.c (Fccl_execute_on_string): Declare some variables
2803 EMACS_INT.
2804
2805 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
2806
2807 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2808
2809 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2810
2811 * process.c (Fformat_network_address): Doc fix.
2812
2813 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2814
2815 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2816
2817 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
2818
2819 * keyboard.c (read_char): Call Lisp function help-form-show,
2820 instead of using internal_with_output_to_temp_buffer.
2821 (Qhelp_form_show): New var.
2822 (syms_of_keyboard): Use DEFSYM macro.
2823
2824 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2825
2826 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2827
2828 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
2829
2830 * process.c (Flist_processes): Remove to Lisp.
2831 (list_processes_1): Delete.
2832
2833 2011-04-06 Eli Zaretskii <eliz@gnu.org>
2834
2835 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2836
2837 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2838
2839 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
2840
2841 Fix more problems found by GCC 4.6.0's static checks.
2842
2843 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2844
2845 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2846
2847 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
2848
2849 * xdisp.c (vmessage): Mark as a printf-like function.
2850
2851 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2852
2853 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2854
2855 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2856 printf-like functions.
2857 (tiff_load): Add casts to remove these marks before passing them
2858 to system-supplied API.
2859
2860 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2861
2862 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2863 This avoids several warnings with gcc -Wstrict-overflow.
2864 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2865 directly, rather than having caller test rule sign. This avoids
2866 some unnecessary tests.
2867 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2868 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2869 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
2870
2871 * xfont.c (xfont_text_extents): Remove var that was set but not used.
2872 (xfont_open): Avoid unnecessary tests.
2873
2874 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2875
2876 * composite.h, composite.c (composition_gstring_put_cache):
2877 Use EMACS_INT, not int, for length.
2878
2879 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2880 breaking out part of COMPOSITION_DECODE_RULE.
2881 (COMPOSITION_DECODE_RULE): Use it.
2882 * composite.c (get_composition_id): Remove unused local vars,
2883 by using the new macro.
2884
2885 * textprop.c (set_text_properties_1): Change while to do-while,
2886 since the condition is always true at first.
2887
2888 * intervals.c (graft_intervals_into_buffer): Mark var as used.
2889 (interval_deletion_adjustment): Return unsigned value.
2890 All uses changed.
2891
2892 * process.c (list_processes_1, create_pty, read_process_output):
2893 (exec_sentinel): Remove vars that were set but not used.
2894 (create_pty): Remove unnecessary "volatile"s.
2895 (Fnetwork_interface_info): Avoid possibility of int overflow.
2896 (read_process_output): Do adaptive read buffering even if carryover.
2897 (read_process_output): Simplify nbytes computation if buffered.
2898
2899 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2900
2901 * syntax.c (scan_words): Remove var that was set but not used.
2902 (update_syntax_table): Use unsigned instead of int.
2903
2904 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
2905 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
2906 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
2907
2908 * print.c (print_error_message): Avoid int overflow.
2909
2910 * font.c (font_list_entities): Redo for clarity,
2911 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2912
2913 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
2914 (font_score): Avoid potential overflow in diff calculation.
2915
2916 * fns.c (substring_both): Remove var that is set but not used.
2917 (sxhash): Redo loop for clarity and to avoid wraparound warning.
2918
2919 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2920
2921 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2922 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2923 can always succeed if overflow has undefined behavior.
2924
2925 * search.c (boyer_moore, wordify): Remove vars set but not used.
2926 (wordify): Omit three unnecessary tests.
2927
2928 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2929 All callers changed. This avoids the need for an unused var.
2930
2931 * casefiddle.c (casify_region): Remove var that is set but not used.
2932
2933 * dired.c (file_name_completion): Remove var that is set but not used.
2934
2935 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2936
2937 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2938 (Finsert_file_contents): Remove unnecessary code checking fd.
2939
2940 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2941 Check for integer overflow on size calculations.
2942
2943 * buffer.c (Fprevious_overlay_change): Remove var that is set
2944 but not used.
2945
2946 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2947 Remove vars that are set but not used.
2948 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2949 (timer_check_2): Mark vars as initialized.
2950
2951 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2952
2953 * image.c (lookup_image): Remove var that is set but not used.
2954 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2955
2956 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2957 that are set but not used.
2958
2959 * xfns.c (make_invisible_cursor): Don't return garbage
2960 if XCreateBitmapFromData fails (Bug#8410).
2961
2962 * xselect.c (x_get_local_selection, x_handle_property_notify):
2963 Remove vars that are set but not used.
2964
2965 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2966 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2967
2968 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2969 Remove var that is set but not used.
2970 (scroll_bar_windows_size): Now size_t, not int.
2971 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2972 Check for overflow.
2973
2974 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2975 (map_tty_color) [!defined MSDOS]: Likewise.
2976
2977 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2978
2979 * coding.c: Remove vars that are set but not used.
2980 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2981 All callers changed.
2982 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2983 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2984 (decode_coding_charset): Remove vars that are set but not used.
2985
2986 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2987 that is set but not used.
2988
2989 * print.c (print_object): Remove var that is set but not used.
2990
2991 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2992 The gnulib version avoids calling malloc in the usual case,
2993 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2994 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2995 * filelock.c (current_lock_owner): Likewise.
2996 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2997 * sysdep.c: Include allocator.h, careadlinkat.h.
2998 (emacs_no_realloc_allocator): New static constant.
2999 (emacs_readlink): New function.
3000 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3001 ../lib/careadlinkat.h.
3002
3003 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3004
3005 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3006 first non-nil return value).
3007
3008 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3009
3010 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3011 if not defined (Bug#8403).
3012
3013 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3014
3015 * xdisp.c (display_count_lines): Remove parameter `start',
3016 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3017 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3018 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3019 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3020 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3021 and thereabouts. All callers changed.
3022 (get_per_char_metric): Remove parameter `f', unused since
3023 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3024
3025 2011-04-02 Jim Meyering <meyering@redhat.com>
3026
3027 do not dereference NULL upon failed strdup
3028 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3029 (ns_get_family): Likewise.
3030
3031 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3032
3033 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3034
3035 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3036
3037 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3038 later (Bug#8403).
3039
3040 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3041
3042 Add lexical binding.
3043
3044 * window.c (Ftemp_output_buffer_show): New fun.
3045 (Fsave_window_excursion):
3046 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3047
3048 * lread.c (lisp_file_lexically_bound_p): New function.
3049 (Fload): Bind Qlexical_binding.
3050 (readevalloop): Remove `evalfun' arg.
3051 Bind Qinternal_interpreter_environment.
3052 (Feval_buffer): Bind Qlexical_binding.
3053 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3054 Mark as dynamic.
3055 (syms_of_lread): Declare `lexical-binding'.
3056
3057 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3058
3059 * keyboard.c (eval_dyn): New fun.
3060 (menu_item_eval_property): Use it.
3061
3062 * image.c (parse_image_spec): Use Ffunctionp.
3063
3064 * fns.c (concat, mapcar1): Accept byte-code-functions.
3065
3066 * eval.c (Fsetq): Handle lexical vars.
3067 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3068 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3069 (FletX, Flet): Obey lexical binding.
3070 (Fcommandp): Handle closures.
3071 (Feval): New `lexical' arg.
3072 (eval_sub): New function extracted from Feval. Use it almost
3073 everywhere where Feval was used. Look up vars in lexical env.
3074 Handle closures.
3075 (Ffunctionp): Move from subr.el.
3076 (Ffuncall): Handle closures.
3077 (apply_lambda): Remove `eval_flags'.
3078 (funcall_lambda): Handle closures and new byte-code-functions.
3079 (Fspecial_variable_p): New function.
3080 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3081 but without exporting it to Lisp.
3082
3083 * doc.c (Fdocumentation, store_function_docstring):
3084 * data.c (Finteractive_form): Handle closures.
3085
3086 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3087 interactive spec.
3088
3089 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3090 New byte-codes.
3091 (exec_byte_code): New function extracted from Fbyte_code to handle new
3092 calling convention for byte-code-functions. Add new byte-codes.
3093
3094 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3095
3096 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3097
3098 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3099
3100 * xdisp.c (redisplay_internal): Fix prototype.
3101
3102 2011-03-31 Eli Zaretskii <eliz@gnu.org>
3103
3104 * xdisp.c (SCROLL_LIMIT): New macro.
3105 (try_scrolling): Use it when setting scroll_limit.
3106 Limit scrolling to 100 screen lines.
3107 (redisplay_window): Even when falling back on "recentering",
3108 position point in the window according to scroll-conservatively,
3109 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3110
3111 (try_scrolling): When point is above the window, allow searching
3112 as far as scroll_max, or one screenful, to compute vertical
3113 distance from PT to the scroll margin position. This prevents
3114 try_scrolling from unnecessarily failing when
3115 scroll-conservatively is set to a value slightly larger than the
3116 window height. Clean up the case of PT below the margin at bottom
3117 of window: scroll_max can no longer be INT_MAX. When aggressive
3118 scrolling is in use, don't let point enter the opposite scroll
3119 margin as result of the scroll.
3120 (syms_of_xdisp) <scroll-conservatively>: Document the
3121 threshold of 100 lines for never-recentering scrolling.
3122
3123 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3124
3125 * dispextern.h (move_it_by_lines):
3126 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3127 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3128 (message_log_check_duplicate): Remove parameters `prev_bol' and
3129 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3130 (redisplay_internal): Remove parameter `preserve_echo_area',
3131 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3132
3133 * indent.c (Fvertical_motion):
3134 * window.c (window_scroll_pixel_based, Frecenter):
3135 Don't pass `need_y_p' to `move_it_by_lines'.
3136
3137 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3138
3139 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3140 steal a few bits to be more compact.
3141 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3142 Remove unneeded casts.
3143
3144 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3145
3146 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3147
3148 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3149 binding" message (bug#7967).
3150
3151 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3152
3153 Fix more problems found by GCC 4.6.0's static checks.
3154
3155 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3156 Remove unused local var.
3157
3158 * editfns.c (Fmessage_box): Remove unused local var.
3159
3160 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3161 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3162 Omit unused local vars.
3163 * window.c (shrink_windows): Omit unused local var.
3164 * menu.c (digest_single_submenu): Omit unused local var.
3165 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3166 Omit unused local var.
3167
3168 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3169 Don't assume string length fits in int.
3170 (keyremap_step, read_key_sequence): Use size_t for sizes.
3171 (read_key_sequence): Don't check last_real_key_start redundantly.
3172
3173 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3174 instead of alloca (Bug#8344).
3175
3176 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3177 (Fbacktrace_frame): Don't assume nframes fits in int.
3178
3179 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3180
3181 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3182 concerns.
3183
3184 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3185
3186 * cm.c (calccost): Turn while-do into do-while, for clarity.
3187
3188 * keyboard.c (syms_of_keyboard): Use the same style as later
3189 in this function when indexing through an array. This also
3190 works around GCC bug 48267.
3191
3192 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3193
3194 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3195
3196 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3197 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3198
3199 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3200 This avoids undefined behavior on integer overflow, and is a bit
3201 more convenient anyway since it is compared to a size_t variable.
3202
3203 Variadic C functions now count arguments with size_t, not int.
3204 This avoids an unnecessary limitation on 64-bit machines, which
3205 caused (substring ...) to crash on large vectors (Bug#8344).
3206 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3207 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3208 All variadic functions and their callers changed accordingly.
3209 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3210 * data.c (arith_driver, float_arith_driver): Likewise.
3211 * editfns.c (general_insert_function): Likewise.
3212 * eval.c (struct backtrace.nargs, interactive_p)
3213 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3214 (funcall_lambda, mark_backtrace): Likewise.
3215 * fns.c (concat): Likewise.
3216 * frame.c (x_set_frame_parameters): Likewise.
3217 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3218 0 if not found, not -1. All callers changed.
3219
3220 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3221 (stack_copy_size): Now size_t, not int.
3222 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3223
3224 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3225
3226 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3227 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3228 All callers changed.
3229
3230 * lisp.h (multibyte_char_to_unibyte):
3231 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3232 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3233 * character.h (CHAR_TO_BYTE8):
3234 * cmds.c (internal_self_insert):
3235 * editfns.c (general_insert_function):
3236 * keymap.c (push_key_description):
3237 * search.c (Freplace_match):
3238 * xdisp.c (message_dolog, set_message_1): All callers changed.
3239
3240 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3241
3242 * keyboard.c (safe_run_hook_funcall): New function.
3243 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3244 don't set the hook to nil, but remove the offending function instead.
3245 (Qcommand_hook_internal): Remove, unused.
3246 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3247 Vcommand_hook_internal.
3248
3249 * eval.c (enum run_hooks_condition): Remove.
3250 (funcall_nil, funcall_not): New functions.
3251 (run_hook_with_args): Call each function through a `funcall' argument.
3252 Remove `cond' argument, now redundant.
3253 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3254 (Frun_hook_with_args_until_failure): Adjust accordingly.
3255 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3256
3257 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3258
3259 * dispextern.h (string_buffer_position): Remove declaration.
3260
3261 * print.c (strout): Remove parameter `multibyte', unused since
3262 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3263
3264 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3265 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3266 All callers changed.
3267
3268 * w32.c (_wsa_errlist): Use braces for struct initializers.
3269
3270 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3271 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3272 All callers changed.
3273 (string_buffer_position): Likewise. Also, make static (it's never
3274 used outside xdisp.c).
3275 (cursor_row_p): Remove parameter `w', unused since
3276 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3277 (decode_mode_spec): Remove parameter `precision', introduced during
3278 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3279 All callers changed.
3280
3281 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3282
3283 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3284
3285 2011-03-27 Anders Lindgren <andlind@gmail.com>
3286
3287 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3288 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3289 (ns_update_auto_hide_menu_bar): New functions.
3290 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3291 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3292 ns_constrain_all_frames.
3293 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3294 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3295
3296 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3297
3298 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3299
3300 2011-03-27 Glenn Morris <rgm@gnu.org>
3301
3302 * syssignal.h: Replace RETSIGTYPE with void.
3303 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3304 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3305 Replace SIGTYPE with void everywhere.
3306 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3307 * s/template.h (SIGTYPE): Remove commented out definition.
3308
3309 2011-03-26 Eli Zaretskii <eliz@gnu.org>
3310
3311 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3312 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3313
3314 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3315
3316 * w32.c (read_unc_volume): Use parameter `henum', instead of
3317 global variable `wget_enum_handle'.
3318
3319 * keymap.c (describe_vector): Remove parameters `indices' and
3320 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3321 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3322
3323 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3324
3325 * keyboard.c (timer_check): Remove parameter `do_it_now',
3326 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3327 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3328 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3329
3330 * keyboard.c (read_char):
3331 * w32menu.c (w32_menu_display_help):
3332 * xmenu.c (show_help_event, menu_help_callback):
3333 Adjust calls to `show_help_echo'.
3334
3335 * gtkutil.c (xg_maybe_add_timer):
3336 * keyboard.c (readable_events):
3337 * process.c (wait_reading_process_output):
3338 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3339
3340 * insdel.c (adjust_markers_gap_motion):
3341 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3342 (gap_left, gap_right): Don't call it.
3343
3344 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3345
3346 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3347 incurred during fontification.
3348
3349 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3350
3351 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3352 (DEFVAR_PER_BUFFER): Don't pass it.
3353
3354 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3355 (scrolling_window): Don't pass it.
3356
3357 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3358
3359 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3360
3361 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3362 and `suffix'.
3363 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3364 of variables specific to SELinux and computation of `encoded_absname'.
3365
3366 * image.c (XPutPixel): Remove unused variable `height'.
3367
3368 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3369
3370 * unexw32.c (get_section_info): Remove unused variable `section'.
3371
3372 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3373 (system_process_attributes): Remove unused variable `sess'.
3374 (sys_read): Remove unused variable `err'.
3375
3376 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3377 (w32_wnd_proc): Remove unused variable `isdead'.
3378 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3379 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3380 (x_create_tip_frame): Remove unused variable `tem'.
3381
3382 * w32inevt.c (w32_console_read_socket):
3383 Remove unused variable `no_events'.
3384
3385 * w32term.c (x_draw_composite_glyph_string_foreground):
3386 Remove unused variable `width'.
3387
3388 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3389
3390 * w32term.c (x_set_glyph_string_clipping):
3391 Don't pass uninitialized region to CombineRgn.
3392
3393 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3394
3395 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3396 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3397 (Fx_close_connection): Remove unused variable `i'.
3398
3399 * w32font.c (w32font_draw): Return number of glyphs.
3400 (w32font_open_internal): Remove unused variable `i'.
3401 (w32font_driver): Add missing initializer.
3402
3403 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3404 (fill_in_menu): Remove unused variable `items_added'.
3405
3406 * w32term.c (last_mouse_press_frame): Remove static global variable.
3407 (w32_clip_to_row): Remove unused variable `f'.
3408 (x_delete_terminal): Remove unused variable `i'.
3409
3410 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3411 (NOTHING): Remove unused static global variable.
3412 (uniscribe_check_otf): Remove unused variable `table'.
3413 (uniscribe_font_driver): Add missing initializers.
3414
3415 2011-03-23 Julien Danjou <julien@danjou.info>
3416
3417 * term.c (Fsuspend_tty, Fresume_tty):
3418 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3419 * window.c (temp_output_buffer_show):
3420 * insdel.c (signal_before_change):
3421 * frame.c (Fhandle_switch_frame):
3422 * fileio.c (Fdo_auto_save):
3423 * emacs.c (Fkill_emacs):
3424 * editfns.c (save_excursion_restore):
3425 * cmds.c (internal_self_insert):
3426 * callint.c (Fcall_interactively):
3427 * buffer.c (Fkill_all_local_variables):
3428 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3429 Use Frun_hooks.
3430 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3431 unconditionnaly since it does the check itself.
3432
3433 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3434
3435 Fix more problems found by GCC 4.5.2's static checks.
3436
3437 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3438 the first time through the loop, since we know p0 < p1 then.
3439 This also avoids a gcc -Wstrict-overflow warning.
3440
3441 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3442 leading to a memory leak, possible in functions like
3443 load_charset_map_from_file that can allocate an unbounded number
3444 of objects (Bug#8318).
3445
3446 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3447 that could (at least in theory) be that large.
3448
3449 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3450 This is less likely to overflow, and avoids undefined behavior if
3451 overflow does occur. All callers changed. Use strtoul to scan
3452 for the unsigned long integer.
3453 (pint2hrstr): Simplify and tune code slightly.
3454 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3455
3456 * scroll.c (do_scrolling): Work around GCC bug 48228.
3457 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3458
3459 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3460 This also avoids a warning with gcc -Wstrict-overflow.
3461 (validate_x_resource_name): Simplify count usage.
3462 This also avoids a warning with gcc -Wstrict-overflow.
3463
3464 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3465 fail (Bug#8306).
3466
3467 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3468
3469 * process.c (Fmake_network_process): Use socklen_t, not int,
3470 where POSIX says socklen_t is required in portable programs.
3471 This fixes a porting bug on hosts like 64-bit HP-UX, where
3472 socklen_t is wider than int (Bug#8277).
3473 (Fmake_network_process, server_accept_connection):
3474 (wait_reading_process_output, read_process_output):
3475 Likewise.
3476
3477 * process.c: Rename or move locals to avoid shadowing.
3478 (list_processes_1, Fmake_network_process):
3479 (read_process_output_error_handler, exec_sentinel_error_handler):
3480 Rename or move locals.
3481 (Fmake_network_process): Define label "retry_connect" only if needed.
3482 (Fnetwork_interface_info): Fix pointer signedness.
3483 (process_send_signal): Add cast to avoid pointer signedness problem.
3484 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3485 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3486
3487 Make tparam.h and terminfo.c consistent.
3488 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3489 Include tparam.h instead, since it declares them.
3490 * cm.h (PC): Remove extern decl; tparam.h now does this.
3491 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3492 * terminfo.c: Include tparam.h, to check interfaces.
3493 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3494 (tparam): Adjust signature to match interface in tparam.h;
3495 this removes some undefined behavior. Check that outstring and len
3496 are zero, which they always are with Emacs.
3497 * tparam.h (PC, BC, UP): New extern decls.
3498
3499 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3500 (xftfont_open): Rename locals to avoid shadowing.
3501
3502 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3503 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3504 (OTF_TAG_SYM): Omit macro if not needed.
3505 (ftfont_list): Remove unused local.
3506 (get_adstyle_property, ftfont_pattern_entity):
3507 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3508 Rename locals to avoid shadowing.
3509
3510 * xfont.c (xfont_list_family): Mark var as initialized.
3511
3512 * xml.c (make_dom): Now static.
3513
3514 * composite.c (composition_compute_stop_pos): Rename local to
3515 avoid shadowing.
3516 (composition_reseat_it): Remove unused locals.
3517 (find_automatic_composition, composition_adjust_point): Likewise.
3518 (composition_update_it): Mark var as initialized.
3519 (find_automatic_composition): Mark vars as initialized,
3520 with a FIXME (Bug#8290).
3521
3522 character.h: Rename locals to avoid shadowing.
3523 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3524 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3525 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3526 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3527 to avoid shadowing.
3528
3529 * textprop.c (property_change_between_p): Remove; unused.
3530
3531 * intervals.c (interval_start_pos): Now static.
3532
3533 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3534
3535 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3536 Rename locals to avoid shadowing.
3537
3538 * sound.c (wav_play, au_play, Fplay_sound_internal):
3539 Fix pointer signedness.
3540 (alsa_choose_format): Remove unused local var.
3541 (wav_play): Initialize a variable to 0, to prevent undefined
3542 behavior (Bug#8278).
3543
3544 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3545
3546 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3547
3548 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3549 clobbering (Bug#8298).
3550 * sysdep.c (sys_subshell): Likewise.
3551 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3552
3553 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3554 This should get cleaned up, so that child_setup has the
3555 same signature on all platforms.
3556
3557 * callproc.c (call_process_cleanup): Now static.
3558 (relocate_fd): Rename locals to avoid shadowing.
3559
3560 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3561
3562 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3563 not to be necessary, and produces flickering.
3564
3565 2011-03-20 Glenn Morris <rgm@gnu.org>
3566
3567 * config.in: Remove file.
3568
3569 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3570
3571 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3572 are now in src/globals.h.
3573 (syms_of_minibuf): Remove spurious & from previous change.
3574
3575 2011-03-20 Leo <sdl.web@gmail.com>
3576
3577 * minibuf.c (completing-read-function): New variable.
3578 (completing-read-default): Rename from completing-read.
3579 (completing-read): Call completing-read-function.
3580
3581 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3582
3583 * xfaces.c (Fx_load_color_file):
3584 Read color file from absolute filename (bug#8250).
3585
3586 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3587
3588 * makefile.w32-in: Update dependencies.
3589
3590 2011-03-17 Eli Zaretskii <eliz@gnu.org>
3591
3592 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3593
3594 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3595
3596 Fix more problems found by GCC 4.5.2's static checks.
3597
3598 * process.c (make_serial_process_unwind, send_process_trap):
3599 (sigchld_handler): Now static.
3600
3601 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3602 That way, the code declares only the vars that it needs.
3603 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3604 * s/cygwin.h (PTY_ITERATION): Likewise.
3605 * s/darwin.h (PTY_ITERATION): Likewise.
3606 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3607
3608 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3609 * process.c (allocate_pty): Don't declare stb unless it's needed.
3610
3611 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3612 (CONSTANTLIM): Remove; unused.
3613 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3614 Define only if needed.
3615
3616 * unexelf.c (unexec): Name an expression,
3617 to avoid gcc -Wbad-function-cast warning.
3618 Use a different way to cause a compilation error if anyone uses
3619 n rather than nn, a way that does not involve shadowing.
3620 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3621
3622 * deps.mk (unexalpha.o): Remove; unused.
3623
3624 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3625 * unexec.h: New file.
3626 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3627 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3628 Depend on unexec.h.
3629 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3630 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3631 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3632 Change as necessary to match prototype in unexec.h.
3633
3634 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3635 shadowing.
3636 (back_comment, skip_chars): Mark vars as initialized.
3637
3638 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3639 Rename locals to avoid shadowing.
3640
3641 * lread.c (read1): Rewrite so as not to use empty "else".
3642 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3643
3644 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3645
3646 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3647 warning when compiling print.c.
3648
3649 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3650 instead of using an uninitialized var.
3651 (font_sort_entities): Mark var as initialized.
3652
3653 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3654
3655 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3656 pointers to constants.
3657 (font_parse_fcname): Remove unused vars.
3658 (font_delete_unmatched): Now static.
3659 (font_get_spec): Remove; unused.
3660 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3661 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3662 Rename or move locals to avoid shadowing.
3663
3664 * fns.c (require_nesting_list, require_unwind): Now static.
3665 (Ffillarray): Rename locals to avoid shadowing.
3666
3667 * floatfns.c (domain_error2): Define only if needed.
3668 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3669
3670 * alloc.c (mark_backtrace): Move decl from here ...
3671 * lisp.h: ... to here, so that it can be checked.
3672
3673 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3674 (Fdefvar): Rewrite so as not to use empty "else".
3675 (lisp_indirect_variable): Name an expression,
3676 to avoid gcc -Wbad-function-cast warning.
3677 (Fdefvar): Rename locals to avoid shadowing.
3678
3679 * callint.c (quotify_arg, quotify_args): Now static.
3680 (Fcall_interactively): Rename locals to avoid shadowing.
3681 Use const pointer when appropriate.
3682
3683 * lisp.h (get_system_name, get_operating_system_release):
3684 Move decls here, to check interfaces.
3685 * process.c (get_operating_system_release): Move decl to lisp.h.
3686 * xrdb.c (get_system_name): Likewise.
3687 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3688 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3689 some of which prompt warnings from gcc -Wbad-function-cast.
3690 (Fformat_time_string, Fencode_time, Finsert_char):
3691 (Ftranslate_region_internal, Fformat):
3692 Rename or remove local vars to avoid shadowing.
3693 (Ftranslate_region_internal): Mark var as initialized.
3694
3695 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3696 avoid shadowing.
3697
3698 * lisp.h (eassert): Check that the argument compiles, even if
3699 ENABLE_CHECKING is not defined.
3700
3701 * data.c (Findirect_variable): Name an expression, to avoid
3702 gcc -Wbad-function-cast warning.
3703 (default_value, arithcompare, arith_driver, arith_error): Now static.
3704 (store_symval_forwarding): Rename local to avoid shadowing.
3705 (Fmake_variable_buffer_local, Fmake_local_variable):
3706 Mark variables as initialized.
3707 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
3708
3709 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
3710 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3711 Rename locals to avoid shadowing.
3712 (mark_stack): Move local variables into the #ifdef region where
3713 they're used.
3714 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3715 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3716 needed otherwise.
3717 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3718 (GC_STRING_CHARS): Remove; not used.
3719 (Fmemory_limit): Cast sbrk's returned value to char *.
3720
3721 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3722 avoids undefined behavior in theory.
3723
3724 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3725
3726 Use functions, not macros, for up- and down-casing (Bug#8254).
3727 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3728 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3729 to use the following functions instead of these macros.
3730 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3731 EMACS_INT, since callers assume the returned value fits in int.
3732 (upcase1): Likewise, for UPCASE_TABLE.
3733 (uppercasep, lowercasep, upcase): New static inline functions.
3734 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
3735 the race-condition problem in the old DOWNCASE.
3736
3737 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3738 Rename locals to avoid shadowing.
3739 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
3740 (regex_compile, re_search_2, re_match_2_internal):
3741 Remove unused local vars.
3742 (FREE_VAR): Rewrite so as not to use empty "else",
3743 which gcc can warn about.
3744 (regex_compile, re_match_2_internal): Mark locals as initialized.
3745 (RETALLOC_IF): Define only if needed.
3746 (WORDCHAR_P): Likewise. This one is never needed, but is used
3747 only in a comment talking about a compiler bug, so put inside
3748 the #if 0 of that comment.
3749 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3750 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3751 Remove; unused.
3752
3753 * search.c (boyer_moore): Rename locals to avoid shadowing.
3754 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3755 (PREV_CHAR_BOUNDARY): Likewise.
3756
3757 * search.c (simple_search): Remove unused var.
3758
3759 * dired.c (compile_pattern): Move decl from here ...
3760 * lisp.h: ... to here, so that it can be checked.
3761 (struct re_registers): New forward decl.
3762
3763 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3764
3765 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3766 All uses changed.
3767 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3768 Rename locals to avoid shadowing.
3769 (Fvertical_motion): Mark locals as initialized.
3770
3771 * casefiddle.c (casify_object, casify_region): Now static.
3772 (casify_region): Mark local as initialized.
3773
3774 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3775
3776 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3777 New macros, so that the caller can use some names other than
3778 gcpro1, gcpro2, etc.
3779 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3780 of the new macros.
3781 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3782 argument, for consistency with GCPRO2_VAR, etc: it is now the
3783 prefix of the variable, not the variable itself. All uses
3784 changed.
3785 * dired.c (directory_files_internal, file_name_completion):
3786 Rename locals to avoid shadowing.
3787
3788 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3789 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3790 dired.c's scmp function, had undefined behavior.
3791 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3792 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3793 * buffer.h: ... to here, because these macros use current_buffer,
3794 and the new implementation with inline functions needs to have
3795 current_buffer in scope now, rather than later when the macros
3796 are used.
3797 (downcase, upcase1): New static inline functions.
3798 (DOWNCASE, UPCASE1): Reimplement using these functions.
3799 This avoids undefined behavior in expressions like
3800 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3801 from race conditions in accessing the global variables
3802 case_temp1 and case_temp2.
3803 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3804 * lisp.h (case_temp1, case_temp2): Remove their decls.
3805 * character.h (ASCII_CHAR_P): Move from here ...
3806 * lisp.h: ... to here, so that the inline functions mentioned
3807 above can use them.
3808
3809 * dired.c (directory_files_internal_unwind): Now static.
3810
3811 * fileio.c (file_name_as_directory, directory_file_name):
3812 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3813 Now static.
3814 (file_name_as_directory): Use const pointers when appropriate.
3815 (Fexpand_file_name): Likewise. In particular, newdir might
3816 point at constant storage, so make it a const pointer.
3817 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
3818 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3819 signedness issues.
3820 (Fset_file_times, Finsert_file_contents, auto_save_error):
3821 Rename locals to avoid shadowing.
3822
3823 * minibuf.c (choose_minibuf_frame_1): Now static.
3824 (Ftry_completion, Fall_completions): Rename or remove locals
3825 to avoid shadowing.
3826
3827 * marker.c (bytepos_to_charpos): Remove; unused.
3828
3829 * lisp.h (verify_bytepos, count_markers): New decls,
3830 so that gcc does not warn that these functions aren't declared.
3831
3832 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3833 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
3834 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
3835 (copy_text): Remove unused local var.
3836
3837 * filelock.c (within_one_second): Now static.
3838 (lock_file_1): Rename local to avoid shadowing.
3839
3840 * buffer.c (fix_overlays_before): Mark locals as initialized.
3841 (fix_start_end_in_overlays): Likewise. This function should be
3842 simplified by using pointers-to-pointers, but that's a different
3843 matter.
3844 (switch_to_buffer_1): Now static.
3845 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3846 (report_overlay_modification): Rename locals to avoid shadowing.
3847
3848 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
3849 Fix pointer signedness issue.
3850 (sys_subshell): Mark local as volatile if checking for lint,
3851 to suppress a gcc -Wclobbered warning that does not seem to be right.
3852 (MAXPATHLEN): Define only if needed.
3853
3854 * process.c (serial_open, serial_configure): Move decls from here ...
3855 * systty.h: ... to here, so that they can be checked.
3856
3857 * fns.c (get_random, seed_random): Move extern decls from here ...
3858 * lisp.h: ... to here, so that they can be checked.
3859
3860 * sysdep.c (reset_io): Now static.
3861 (wait_for_termination_signal): Remove; unused.
3862
3863 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3864 (copy_keymap_item, append_key, push_text_char_description):
3865 Now static.
3866 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
3867 (DENSE_TABLE_SIZE): Remove; unused.
3868 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3869 (describe_map_tree):
3870 Rename locals to avoid shadowing.
3871
3872 * keyboard.c: Declare functions static if they are not used elsewhere.
3873 (echo_char, echo_dash, cmd_error, top_level_2):
3874 (poll_for_input, handle_async_input): Now static.
3875 (read_char, kbd_buffer_get_event, make_lispy_position):
3876 (make_lispy_event, make_lispy_movement, apply_modifiers):
3877 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3878 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3879 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
3880 (read_key_sequence, read_char): Mark locals as initialized.
3881 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
3882
3883 * keyboard.h (make_ctrl_char): New decl.
3884 (mark_kboards): Move decl here ...
3885 * alloc.c (mark_kboards): ... from here.
3886
3887 * lisp.h (force_auto_save_soon): New decl.
3888
3889 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
3890 (DEFINE_DUMMY_FUNCTION): New macro.
3891 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3892 Use it.
3893 (main): Add casts to avoid warnings
3894 if GCC considers string literals to be constants.
3895
3896 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3897
3898 * dbusbind.c: Pointer signedness fixes.
3899 (xd_signature, xd_append_arg, xd_initialize):
3900 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3901 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3902 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3903 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3904
3905 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3906 if GCC considers string literals to be constants.
3907 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
3908
3909 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3910
3911 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3912 (print_preprocess, print_object): New macro to fix last change.
3913
3914 * print.c (print_preprocess): Don't forget font objects.
3915
3916 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
3917
3918 * emacs.c (USAGE3): Doc fixes.
3919
3920 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3921
3922 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3923 structure.
3924
3925 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
3926
3927 * lisp.h (VWindow_system, Qfile_name_history):
3928 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3929 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3930 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3931
3932 * w32select.c: Don't #include "keyboard.h".
3933 (run_protected): Add extern declaration for waiting_for_input.
3934
3935 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3936 * w32console.c (detect_input_pending, read_input_pending)
3937 (encode_terminal_code):
3938 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3939 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3940 (w32_system_caret_y, Qfile_name_history):
3941 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3942 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3943 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3944 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3945 * w32proc.c (Qlocal, report_file_error):
3946 * w32term.c (Vwindow_system, updating_frame):
3947 * w32uniscribe.c (initialized, uniscribe_font_driver):
3948 Remove unneeded extern declarations.
3949
3950 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
3951
3952 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3953
3954 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
3955
3956 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3957 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3958 These macros can no longer be used for assignment.
3959
3960 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3961 Assign struct members directly, instead of using BUF_BEGV etc.
3962 (record_buffer_markers, fetch_buffer_markers): New functions for
3963 recording and fetching special buffer markers.
3964 (set_buffer_internal_1, set_buffer_temp): Use them.
3965
3966 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3967
3968 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3969
3970 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3971 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3972
3973 * xdisp.c (hscroll_window_tree):
3974 (reconsider_clip_changes): Use PT instead of BUF_PT.
3975
3976 2011-03-13 Eli Zaretskii <eliz@gnu.org>
3977
3978 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3979 $(EMACS_ROOT)/lib/intprops.h.
3980
3981 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3982
3983 Fix more problems found by GCC 4.5.2's static checks.
3984
3985 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3986 to unsigned char * to avoid compiler diagnostic.
3987 (xg_free_frame_widgets): Make it clear that a local variable is
3988 needed only if USE_GTK_TOOLTIP.
3989 (gdk_window_get_screen): Make it clear that this macro is needed
3990 only if USE_GTK_TOOLTIP.
3991 (int_gtk_range_get_value): New function, which avoids a diagnostic
3992 from gcc -Wbad-function-cast.
3993 (xg_set_toolkit_scroll_bar_thumb): Use it.
3994 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3995 diagnostic from gcc -Wbad-function-cast.
3996 (get_utf8_string, xg_get_file_with_chooser):
3997 Rename locals to avoid shadowing.
3998 (create_dialog): Move locals to avoid shadowing.
3999
4000 * xgselect.c (xg_select): Remove unused var.
4001
4002 * image.c (four_corners_best): Mark locals as initialized.
4003 (gif_load): Initialize transparent_p to zero (Bug#8238).
4004 Mark another local as initialized.
4005 (my_png_error, my_error_exit): Mark with NO_RETURN.
4006
4007 * image.c (clear_image_cache): Now static.
4008 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4009 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4010 (x_edge_detection): Remove unnecessary cast that
4011 gcc -Wbad-function-cast diagnoses.
4012 (gif_load): Fix pointer signedness.
4013 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4014 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4015
4016 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4017
4018 Improve quality of tests for time stamp overflow.
4019 For example, without this patch (encode-time 0 0 0 1 1
4020 1152921504606846976) returns the obviously-bogus value (-948597
4021 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4022 reports time overflow. See
4023 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4024 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4025 * editfns.c: Include limits.h and intprops.h.
4026 (TIME_T_MIN, TIME_T_MAX): New macros.
4027 (time_overflow): Move earlier, to before first use.
4028 (hi_time, lo_time): New functions, for an accurate test for
4029 out-of-range times.
4030 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4031 (Fget_internal_run_time): Don't assume time_t fits in int.
4032 (make_time): Use list2 instead of Fcons twice.
4033 (Fdecode_time): More accurate test for out-of-range times.
4034 (check_tm_member): New function.
4035 (Fencode_time): Use it, to test for out-of-range times.
4036 (lisp_time_argument): Don't rely on undefined left-shift and
4037 right-shift behavior when checking for time stamp overflow.
4038
4039 * editfns.c (time_overflow): New function, refactoring common code.
4040 (Fformat_time_string, Fdecode_time, Fencode_time):
4041 (Fcurrent_time_string): Use it.
4042
4043 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4044 * dired.c (make_time): Move to ...
4045 * editfns.c (make_time): ... here.
4046 * systime.h: Note the move.
4047
4048 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4049
4050 * fringe.c (update_window_fringes): Remove unused variables.
4051
4052 * unexmacosx.c (copy_data_segment): Also copy __got section.
4053 (Bug#8223)
4054
4055 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4056
4057 * termcap.c [MSDOS]: Include "msdos.h".
4058 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4059 Constify `char *' arguments and their references according to
4060 prototypes in tparam.h.
4061
4062 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4063
4064 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4065 Adapt all references accordingly.
4066
4067 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4068
4069 2011-03-11 Tom Tromey <tromey@redhat.com>
4070
4071 * buffer.c (syms_of_buffer): Remove obsolete comment.
4072
4073 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4074
4075 * termhooks.h (encode_terminal_code): Declare prototype.
4076
4077 * msdos.c (encode_terminal_code): Don't declare prototype.
4078
4079 * term.c (encode_terminal_code): Now external again, used by
4080 w32console.c and msdos.c.
4081
4082 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4083 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4084
4085 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4086
4087 Fix some minor problems found by GCC 4.5.2's static checks.
4088
4089 * fringe.c (update_window_fringes): Mark locals as initialized
4090 (Bug#8227).
4091 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4092
4093 * alloc.c (mark_fringe_data): Move decl from here ...
4094 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4095 to check its interface.
4096 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4097
4098 * fontset.c (free_realized_fontset): Now static.
4099 (Fset_fontset_font): Rename local to avoid shadowing.
4100 (fontset_font): Mark local as initialized.
4101 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
4102
4103 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4104
4105 * xselect.c (x_disown_buffer_selections): Remove; not used.
4106 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
4107 (x_own_selection, Fx_disown_selection_internal): Rename locals
4108 to avoid shadowing.
4109 (x_handle_dnd_message): Remove local to avoid shadowing.
4110
4111 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4112 so that the caller can use some name other than gcpro1.
4113 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
4114 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4115 (Fx_backspace_delete_keys_p):
4116 Use them to avoid shadowing, and rename vars to avoid shadowing.
4117 (x_decode_color, x_set_name, x_window): Now static.
4118 (Fx_create_frame): Add braces to silence GCC warning.
4119 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
4120 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4121 Remove unused locals.
4122 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4123 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4124 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4125 macros.
4126
4127 * xterm.h (x_mouse_leave): New decl.
4128
4129 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4130 Remove unused functions.
4131 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4132 (x_calc_absolute_position): Now static.
4133 (XTread_socket): Don't define label "out" unless it's used.
4134 Don't declare local "event" unless it's used.
4135 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4136 unless they are used.
4137 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4138 (x_fatal_error_signal): Remove; not used.
4139 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4140 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4141 (x_error_catcher, x_connection_closed, x_error_handler):
4142 (x_error_quitter, xembed_send_message, x_iconify_frame):
4143 (my_log_handler): Rename locals to avoid shadowing.
4144 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
4145 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
4146
4147 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4148 Rename or move locals to avoid shadowing.
4149 (tty_defined_color, merge_face_heights): Now static.
4150 (free_realized_faces_for_fontset): Remove; not used.
4151 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4152 does not deduce is never used uninitialized.
4153 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4154 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
4155
4156 * terminal.c (store_terminal_param): Now static.
4157
4158 * xmenu.c (menu_highlight_callback): Now static.
4159 (set_frame_menubar): Remove unused local.
4160 (xmenu_show): Rename parameter to avoid shadowing.
4161 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4162 since they might point to immutable storage.
4163 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4164 since it's unused otherwise.
4165
4166 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
4167 Add a FIXME, since the code still doesn't look right. (Bug#8215)
4168 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4169 avoids a gcc -Wuninitialized diagnostic.
4170 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
4171 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4172 does not deduce are never used uninitialized.
4173
4174 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4175
4176 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4177 * window.c (window_loop, size_window):
4178 (run_window_configuration_change_hook, enlarge_window): Likewise.
4179
4180 * window.c (display_buffer): Now static.
4181 (size_window): Mark variables that gcc -Wuninitialized
4182 does not deduce are never used uninitialized.
4183 * window.h (check_all_windows): New decl, to forestall
4184 gcc -Wmissing-prototypes diagnostic.
4185 * dispextern.h (bidi_dump_cached_states): Likewise.
4186
4187 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4188 shadowing.
4189 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4190 Include <limits.h>.
4191 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4192 and to avoid gcc -Wuninitialized warning.
4193 (load_charset_map): Mark variables that gcc -Wuninitialized
4194 does not deduce are never used uninitialized.
4195 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4196
4197 * coding.c (coding_set_source, coding_set_destination):
4198 Use "else { /* comment */ }" rather than "else /* comment */;"
4199 for clarity, and to avoid gcc -Wempty-body warning.
4200 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4201 a block, when the outer 'i' will do.
4202 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4203 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4204 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4205 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4206 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4207 Rename locals to avoid shadowing.
4208 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4209 * coding.c (emacs_mule_char, encode_invocation_designation):
4210 Now static, since they're not used elsewhere.
4211 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4212 (decode_coding_object, encode_coding_object, detect_coding_system):
4213 (decode_coding_emacs_mule): Mark variables that gcc
4214 -Wuninitialized does not deduce are never used uninitialized.
4215 (detect_coding_iso_2022): Initialize a local variable that might
4216 be used uninitialized. Leave a FIXME because it's not clear that
4217 this initialization is needed. (Bug#8211)
4218 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4219 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4220 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4221 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4222 Remove unused macros.
4223
4224 * category.c (hash_get_category_set): Remove unused local var.
4225 (copy_category_table): Now static, since it's not used elsewhere.
4226 * character.c (string_count_byte8): Likewise.
4227
4228 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4229 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4230
4231 * chartab.c (copy_sub_char_table): Now static, since it's not used
4232 elsewhere.
4233 (sub_char_table_ref_and_range, char_table_ref_and_range):
4234 Rename locals to avoid shadowing.
4235 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4236
4237 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4238 (BIDI_BOB): Remove unused macro.
4239
4240 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4241 deduce are never used uninitialized.
4242 * term.c (encode_terminal_code): Likewise.
4243
4244 * term.c (encode_terminal_code): Now static. Remove unused local.
4245
4246 * tparam.h: New file.
4247 * term.c, tparam.h: Include it.
4248 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4249 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4250 Move these decls to tparam.h, and make them agree with what
4251 is actually in tparam.c. The previous trick of using incompatible
4252 decls in different modules does not conform to the C standard.
4253 All callers of tparam changed to use tparam's actual API.
4254 * tparam.c (tparam1, tparam, tgoto):
4255 Use const pointers where appropriate.
4256
4257 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4258 * cm.h (struct cm): Likewise.
4259 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4260 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4261 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4262 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4263 (turn_on_face, init_tty): Likewise.
4264 * termchar.h (struct tty_display_info): Likewise.
4265
4266 * term.c (term_mouse_position): Rename local to avoid shadowing.
4267
4268 * alloc.c (mark_ttys): Move decl from here ...
4269 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4270
4271 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4272
4273 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4274
4275 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4276
4277 * search.c (compile_pattern_1): Remove argument regp, unused since
4278 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4279 (compile_pattern): Don't pass it.
4280
4281 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4282
4283 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4284 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4285 for ! HAVE_GTK3.
4286 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4287
4288 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4289
4290 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4291 gdk_window_get_screen, gdk_window_get_geometry,
4292 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4293 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4294 (xg_get_pixbuf_from_pixmap): New function.
4295 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4296 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4297 Call xg_get_pixbuf_from_pixmap instead of
4298 gdk_pixbuf_get_from_drawable.
4299 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4300 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4301 (xg_check_special_colors): Use GtkStyleContext and its functions
4302 for HAVE_GTK3.
4303 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4304 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4305 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4306 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4307 Call gtk_widget_get_preferred_size.
4308 (xg_frame_resized): gdk_window_get_geometry only takes 5
4309 parameters.
4310 (xg_win_to_widget, xg_event_is_for_menubar):
4311 Call gdk_x11_window_lookup_for_display.
4312 (xg_set_widget_bg): New function.
4313 (delete_cb): New function.
4314 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4315 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4316 (xg_set_background_color): Call xg_set_widget_bg.
4317 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4318 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4319 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4320 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4321 if ! HAVE_GTK3.
4322 (update_frame_tool_bar): Call gtk_widget_hide.
4323 (xg_initialize): Use GDK_KEY_g.
4324
4325 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4326 if ! HAVE_GTK3
4327 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4328
4329 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4330 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4331 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4332
4333 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4334
4335 * w32xfns.c (select_palette): Check success of RealizePalette against
4336 GDI_ERROR, not zero.
4337
4338 See ChangeLog.11 for earlier changes.
4339
4340 ;; Local Variables:
4341 ;; coding: utf-8
4342 ;; End:
4343
4344 Copyright (C) 2011 Free Software Foundation, Inc.
4345
4346 This file is part of GNU Emacs.
4347
4348 GNU Emacs is free software: you can redistribute it and/or modify
4349 it under the terms of the GNU General Public License as published by
4350 the Free Software Foundation, either version 3 of the License, or
4351 (at your option) any later version.
4352
4353 GNU Emacs is distributed in the hope that it will be useful,
4354 but WITHOUT ANY WARRANTY; without even the implied warranty of
4355 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4356 GNU General Public License for more details.
4357
4358 You should have received a copy of the GNU General Public License
4359 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.