1 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3 * xdisp.c (move_it_in_display_line_to): Record the best matching
4 position for TO_CHARPOS while scanning the line, and restore it on
5 exit if none of the characters scanned was an exact match. Fixes
6 vertical-motion and pos-visible-in-window-p when exact match is
7 impossible due to invisible text, and the lines are truncated.
9 2011-07-22 Eli Zaretskii <eliz@gnu.org>
11 * xdisp.c (compute_stop_pos_backwards): New function.
12 (handle_stop_backwards): Revert last change.
13 (next_element_from_buffer): Call compute_stop_pos_backwards to
14 find a suitable prev_stop when we find ourselves before
15 base_level_stop. Remove the funky search for 1000 character
18 2011-07-19 Eli Zaretskii <eliz@gnu.org>
20 Fix a significant slow-down of vertical-motion when leaning on C-n
21 or C-p in a fontified buffer.
22 * xdisp.c (reseat): Don't look for prev_stop, as that could mean a
24 (next_element_from_buffer): When iterator oversteps prev_pos
25 backwards, don't search for a new prev_stop more than 1000
27 (handle_stop_backwards): Don't assume that CHARPOS is necessarily
29 (compute_display_string_pos): Check also BUF_OVERLAY_MODIFF for a
30 match, when testing the cached display string position for
33 2011-07-16 Eli Zaretskii <eliz@gnu.org>
35 * xdisp.c <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>:
36 Cache for last found display string position.
37 (compute_display_string_pos): Return the cached position if asked
38 about the same buffer.
40 2011-07-14 Eli Zaretskii <eliz@gnu.org>
42 * bidi.c (bidi_cache_fetch_state, bidi_cache_search)
43 (bidi_cache_find_level_change, bidi_cache_ensure_space)
44 (bidi_cache_iterator_state, bidi_cache_find)
45 (bidi_find_other_level_edge, bidi_cache_start_stack): All
46 variables related to cache indices are now EMACS_INT.
48 2011-07-09 Eli Zaretskii <eliz@gnu.org>
50 * bidi.c (bidi_fetch_char): Fix the type of `len' according to
51 what STRING_CHAR_AND_LENGTH expects.
53 * xdisp.c (move_it_in_display_line_to): Record prev_method and
54 prev_pos immediately before the call to set_iterator_to_next.
55 Fixes cursor motion in bidi-reordered lines with stretch glyphs
56 and strings displayed in margins. (Bug#8133) (Bug#8867)
57 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
59 (pos_visible_p): Support positions in bidi-reordered lines. Save
60 and restore bidi cache.
62 2011-07-08 Eli Zaretskii <eliz@gnu.org>
64 * xdisp.c (move_it_in_display_line_to): If iterator ended up at
65 EOL, but we never saw any buffer positions smaller than
66 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
67 motion in bidi-reordered lines.
69 2011-07-07 Eli Zaretskii <eliz@gnu.org>
71 * xdisp.c (find_row_edges): If ROW->start.pos gives position
72 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
74 2011-07-05 Eli Zaretskii <eliz@gnu.org>
76 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
77 cache around display iteration.
79 * window.c (Fwindow_end, window_scroll_pixel_based)
80 (displayed_window_lines, Frecenter): Save and restore the bidi
81 cache around display iteration.
83 * bidi.c (bidi_unshelve_cache): Ensure we have enough space before
84 restoring the shelved cache.
85 (bidi_cache_ensure_space): Don't assume the required size is just
86 one BIDI_CACHE_CHUNK away.
88 * xdisp.c (back_to_previous_visible_line_start, reseat_1)
89 (init_iterator): Empty the bidi cache "stack".
91 2011-07-03 Eli Zaretskii <eliz@gnu.org>
93 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): New functions.
95 * dispextern.h (bidi_shelve_cache, bidi_unshelve_cache): Declare
98 * xdisp.c (SAVE_IT, RESTORE_IT): New macros.
99 (pos_visible_p, face_before_or_after_it_pos)
100 (back_to_previous_visible_line_start)
101 (move_it_in_display_line_to, move_it_in_display_line)
102 (move_it_to, move_it_vertically_backward, move_it_by_lines)
103 (try_scrolling, redisplay_window, display_line): Use them when
104 saving a temporary copy of the iterator and restoring it back.
106 2011-07-02 Eli Zaretskii <eliz@gnu.org>
108 * xdisp.c (reseat_1): Call bidi_init_it to resync the bidi
109 iterator with IT's position. (Bug#7616)
110 (handle_stop, back_to_previous_visible_line_start, reseat_1):
111 Reset the from_disp_prop_p flag.
113 * bidi.c (bidi_cache_search): Don't assume bidi_cache_last_idx is
114 always valid if bidi_cache_idx is valid.
115 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
116 is valid if it's going to be used.
118 * dispextern.h (struct iterator_stack_entry, struct it): New
119 member from_disp_prop_p.
121 * xdisp.c (push_it, pop_it): Save and restore from_disp_prop_p.
122 (handle_single_display_spec, push_display_prop): Set the
123 from_disp_prop_p flag.
124 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
125 (pop_it): Call iterate_out_of_display_property only if we are
126 popping after iteration over a string that came from a display
127 property. Fix a typo in popping stretch info. Add an assertion
128 for verifying that the iterator position is in sync with the bidi
130 (handle_single_display_spec, get_overlay_strings_1)
131 (push_display_prop): Fix initialization of paragraph direction for
132 string when that of the parent object is not yet determined.
134 2011-07-01 Eli Zaretskii <eliz@gnu.org>
136 * dispextern.h (struct bidi_string_data): New member `unibyte'.
138 * xdisp.c (handle_single_display_spec, next_overlay_string)
139 (get_overlay_strings_1, reseat_1, reseat_to_string)
140 (push_display_prop): Set up the `unibyte' member of bidi_it.string
141 correctly. Don't assume unibyte strings are not bidi-reordered.
142 (compute_display_string_pos)
143 (compute_display_string_end): Fix handling the case of C string.
145 * bidi.c (bidi_count_bytes, bidi_char_at_pos): Accept an
146 additional argument UNIBYTE, and support unibyte strings. All
148 (bidi_fetch_char): Support unibyte strings.
150 2011-06-25 Eli Zaretskii <eliz@gnu.org>
152 * xdisp.c (set_iterator_to_next, get_visually_first_element): Use
153 it->bidi_it.string.schars rather than it->string_nchars when
154 testing whether we're beyond string end, because string_nchars is
155 zero for strings that come from overlays and display properties.
157 * bidi.c (bidi_cache_iterator_state): Fix a bug with testing
158 character positions against the cached range, when we use a
161 * xdisp.c (push_it, pop_it): Save and restore it.
163 * dispextern.h (struct iterator_stack_entry): New member
166 * xdisp.c (handle_single_display_spec, next_overlay_string)
167 (get_overlay_strings_1, push_display_prop): Set up the bidi
168 iterator for displaying display or overlay strings.
169 (forward_to_next_line_start): Don't use the shortcut if
171 (back_to_previous_visible_line_start): If handle_display_prop
172 pushed the iterator stack, restore the internal state of the bidi
173 iterator by calling bidi_pop_it same number of times.
174 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
175 and we are bidi-iterating, don't decrement the iterator position;
176 instead, set the first_elt flag in the bidi iterator, to produce
178 (reseat_1): Remove redundant setting of string_from_display_prop_p.
179 (push_display_prop): xassert that we are iterating a buffer.
181 * bidi.c (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
183 2011-06-24 Eli Zaretskii <eliz@gnu.org>
185 * xdisp.c (push_it, pop_it): Save and restore the state of the
186 bidi iterator. Save and restore the bidi_p flag.
187 (pop_it): Iterate out of display property for string iteration as
189 (iterate_out_of_display_property): Support iteration over strings.
190 (handle_single_display_spec): Set up it->bidi_it for iteration
191 over a display string, and call bidi_init_it.
193 * dispextern.h (struct iterator_stack_entry): New member bidi_p.
194 (struct it): Member bidi_p is now a bit field 1 bit wide.
196 2011-06-23 Eli Zaretskii <eliz@gnu.org>
198 * dispextern.h (bidi_push_it, bidi_pop_it): Add prototypes.
200 * bidi.c (bidi_push_it, bidi_pop_it): New functions.
201 (bidi_initialize): Initialize the bidi cache start stack pointer.
202 (bidi_cache_ensure_space): New function, refactored from part of
203 bidi_cache_iterator_state.
205 2011-06-18 Eli Zaretskii <eliz@gnu.org>
207 * xdisp.c (tool_bar_lines_needed, redisplay_tool_bar)
208 (display_menu_bar): Force left-to-right direction. Add a FIXME
209 comment for making that be controlled by a user option.
211 * bidi.c (bidi_move_to_visually_next): GCPRO the Lisp string we
214 * term.c (produce_glyphs): Add IT_GLYPHLESS to the values of
215 it->what accepted by the xassert. Fixes a gratuitous crash in an
216 Emacs built with -DXASSERTS.
218 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
219 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
220 and vector-like objects.
222 * xdisp.c (face_before_or_after_it_pos): Support bidi iteration.
223 (next_element_from_c_string): Handle the case of the first string
224 character that is not the first one in the visual order.
225 (get_visually_first_element): New function, refactored from common
226 parts of next_element_from_buffer, next_element_from_string, and
227 next_element_from_c_string.
229 2011-06-16 Eli Zaretskii <eliz@gnu.org>
231 * xdisp.c (init_iterator): Don't initialize it->bidi_p for strings
233 (reseat_to_string): Initialize it->bidi_p for strings here.
234 (next_element_from_string, next_element_from_c_string)
235 (next_element_from_buffer): Add xassert's for correspondence
236 between IT's object being iterated and it->bidi_it.string
239 * bidi.c (bidi_level_of_next_char): Fix the logic for looking up
240 the sentinel state in the cache.
242 2011-06-13 Eli Zaretskii <eliz@gnu.org>
244 * xdisp.c (compute_display_string_pos)
245 (compute_display_string_end, reseat_to_string): Don't assume
246 it->bidi_it.string.s always points to string.lstring's data.
248 * bidi.c (bidi_fetch_char, bidi_paragraph_init)
249 (bidi_resolve_explicit_1, bidi_resolve_explicit)
250 (bidi_resolve_weak, bidi_level_of_next_char): Don't assume
251 string.s always points to string.lstring's data.
253 2011-06-11 Eli Zaretskii <eliz@gnu.org>
255 * xdisp.c (set_iterator_to_next): Advance string position
256 correctly when padding it with blanks.
258 2011-06-11 Eli Zaretskii <eliz@gnu.org>
260 * xdisp.c (next_element_from_buffer): Improve commentary for when
261 the iterator is before prev_stop.
262 (init_iterator): Initialize bidi_p from the default value of
263 bidi-display-reordering, not from buffer-local value. Use the
264 buffer-local value only if initializing for buffer iteration.
265 (handle_invisible_prop): Support invisible properties on strings
266 that are being bidi-reordered.
267 (reseat_to_string): Enable bidi-related code.
268 (set_iterator_to_next): Support bidi reordering of C strings and
270 (next_element_from_string): Support bidi reordering of Lisp
272 (handle_stop_backwards): Support Lisp strings as well.
273 (display_mode_line, display_mode_element): Temporarily force L2R
275 (display_string): Support display of R2L glyph rows. Use
276 IT_STRING_CHARPOS when displaying from a Lisp string.
278 2011-06-10 Eli Zaretskii <eliz@gnu.org>
280 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
282 (compute_display_string_pos, compute_display_string_end):
283 Fix calculation of the object to scan. Fixes an error when using
285 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
286 base_level_stop; instead, set base_level_stop to BEGV. Fixes
287 crashes in vertical-motion.
289 2011-06-09 Eli Zaretskii <eliz@gnu.org>
291 * xdisp.c (compute_display_string_pos): First arg is now struct
292 `text_pos *'; all callers changed. Support display properties on
294 (compute_display_string_end): Support display properties on Lisp
296 (init_iterator, reseat_1, reseat_to_string): Initialize the
297 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
298 when iterating on a string not from display properties).
300 * bidi.c (bidi_fetch_char): Support strings with display
303 * dispextern.h (struct bidi_string_data): New member bufpos.
304 (compute_display_string_pos): Update prototype.
306 2011-06-09 Eli Zaretskii <eliz@gnu.org>
308 * bidi.c (bidi_level_of_next_char): Allow the sentinel "position"
309 to pass the test for valid cached positions.
311 * xdisp.c (init_iterator): Call bidi_init_it only of a valid
312 buffer position was specified. Initialize paragraph_embedding to
314 (reseat_to_string): Initialize the bidi iterator (for now ifdef'ed
316 (display_string): If we need to ignore text properties of
317 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
318 original value of -1 will not work with bidi.)
320 * dispextern.h (struct bidi_string_data): New member lstring.
322 2011-06-09 Eli Zaretskii <eliz@gnu.org>
324 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
325 itb.string.s to NULL (avoids a crash in bidi_paragraph_init).
327 2011-06-08 Eli Zaretskii <eliz@gnu.org>
329 * bidi.c (bidi_paragraph_info): Delete unused struct.
330 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
331 (bidi_cache_start): New variable.
332 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
334 (bidi_cache_fetch_state, bidi_cache_search)
335 (bidi_cache_find_level_change, bidi_cache_iterator_state)
336 (bidi_cache_find, bidi_peek_at_next_level)
337 (bidi_level_of_next_char, bidi_find_other_level_edge)
338 (bidi_move_to_visually_next): Compare cache index with
339 bidi_cache_start rather than with zero.
340 (bidi_fetch_char): Accept new argument STRING; all callers
341 changed. Support iteration over a string.
342 (bidi_paragraph_init, bidi_resolve_explicit_1)
343 (bidi_resolve_explicit, bidi_resolve_weak)
344 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
345 iteration over a string.
346 (bidi_set_sor_type, bidi_resolve_explicit_1)
347 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
348 can now be zero (for strings); special values 0 and -1 were
349 changed to -1 and -2, respectively.
350 (bidi_char_at_pos): New function.
351 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
352 Call it instead of FETCH_MULTIBYTE_CHAR.
353 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
354 initialized to valid values.
355 (bidi_init_it): Don't initialize charpos and bytepos with invalid
358 * xdisp.c (compute_display_string_pos)
359 (compute_display_string_end): Accept additional argument STRING.
360 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
361 (reseat_to_string): Initialize bidi_it->string.s and
362 bidi_it->string.schars.
364 * dispextern.h (struct bidi_string_data): New structure.
365 (struct bidi_it): New member `string'. Make flag members be 1-bit
366 fields, and put them last in the struct.
367 (compute_display_string_pos, compute_display_string_end): Update
370 2011-06-04 Eli Zaretskii <eliz@gnu.org>
372 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
374 2011-06-03 Eli Zaretskii <eliz@gnu.org>
376 * bidi.c (bidi_fetch_char_advance): Remove unused and
377 unimplemented function.
379 2011-05-28 Eli Zaretskii <eliz@gnu.org>
381 * xdisp.c (set_cursor_from_row): Set start and stop points
382 according to the row's direction when priming the loop that looks
383 for the glyph on which to display cursor.
384 (single_display_spec_intangible_p): Function deleted.
385 (display_prop_intangible_p): Reimplement to call
386 handle_display_spec instead of single_display_spec_intangible_p.
387 Accept 3 additional arguments needed by handle_display_spec. This
388 fixes incorrect cursor motion across display property with complex
389 values: lists, `(when COND...)' forms, etc.
390 (single_display_spec_string_p): Support property values that are
391 lists with the argument STRING its top-level element.
392 (display_prop_string_p): Fix the condition for processing a
393 property that is a list to be consistent with handle_display_spec.
395 * keyboard.c (adjust_point_for_property): Adjust the call to
396 display_prop_intangible_p to its new signature.
398 * dispextern.h (display_prop_intangible_p): Adjust prototype.
400 2011-05-21 Eli Zaretskii <eliz@gnu.org>
402 * xdisp.c (handle_display_spec): New function, refactored from the
403 last portion of handle_display_prop.
404 (compute_display_string_pos): Accept additional argument
405 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
406 value of a `display' property is a "replacing spec".
407 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
408 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
409 the display property, but just return a value indicating whether
410 the display property will replace the characters it covers.
411 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
412 frame_window_p members of struct bidi_it.
414 * bidi.c (bidi_fetch_char): Accept additional argument
415 FRAME_WINDOW_P and pass it to compute_display_string_pos. All
417 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
418 it to initialize the frame_window_p member of struct bidi_it.
420 * dispextern.h (struct bidi_it): New member frame_window_p.
421 (bidi_init_it, compute_display_string_pos): Update prototypes.
423 2011-05-14 Eli Zaretskii <eliz@gnu.org>
425 * xdisp.c (compute_display_string_pos): Non-trivial implementation.
426 (compute_display_string_end): New function.
427 (push_it): Accept second argument POSITION, where pop_it should
428 jump to continue iteration.
430 * dispextern.h (compute_display_string_end): Declare prototype.
432 * bidi.c (bidi_resolve_explicit_1): Use ZV for disp_pos.
433 (bidi_fetch_char): Implement support for runs of characters
434 covered by display strings.
436 * bidi.c (bidi_fetch_char): Accept also character position
437 corresponding to BYTEPOS. DISP_POS is now a character position,
438 not a byte position. All callers changed.
439 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
440 (bidi_resolve_explicit, bidi_resolve_weak)
441 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
442 bidi_it->nchars is non-positive.
443 (bidi_level_of_next_char): Don't try to lookup the cache for the
444 next/previous character if nothing is cached there yet, or if we
445 were just reseat()'ed to a new position.
446 (bidi_paragraph_init, bidi_resolve_explicit_1)
447 (bidi_level_of_next_char): Fix arguments in the calls to
450 2011-05-10 Eli Zaretskii <eliz@gnu.org>
452 * xdisp.c (compute_display_string_pos): New function.
453 (reseat_1): Initialize bidi_it.disp_pos.
455 * bidi.c (bidi_copy_it): Use offsetof.
456 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
457 (bidi_cache_search, bidi_cache_iterator_state)
458 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
459 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
460 character positions inside a run of characters covered by a
462 (bidi_paragraph_init, bidi_resolve_explicit_1)
463 (bidi_level_of_next_char): Call bidi_fetch_char and
464 bidi_fetch_char_advance instead of FETCH_CHAR and
466 (bidi_init_it): Initialize new members.
467 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
469 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
470 instead of using explicit *_CHAR codes.
471 (bidi_resolve_explicit, bidi_resolve_weak): Use
472 FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
473 bidirectional text is supported only in multibyte buffers.
475 * dispextern.h (struct bidi_it): New members nchars and disp_pos.
476 ch_len is now EMACS_INT.
477 (compute_display_string_pos): Declare prototype.
479 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
481 * w32menu.c (set_frame_menubar): Fix submenu allocation.
483 2011-05-07 Eli Zaretskii <eliz@gnu.org>
485 * w32console.c (Fset_screen_color): Doc fix.
486 (Fget_screen_color): New function.
487 (syms_of_ntterm): Defsubr it.
489 * callproc.c (call_process_cleanup): Don't close and unlink the
490 temporary file if Fcall_process didn't create it in the first
492 (Fcall_process): Don't create tempfile if stdout of the child
493 process will be redirected to a file specified with `:file'.
494 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
495 cue to call_process_cleanup not to close that handle.
497 2011-05-07 Ben Key <bkey76@gmail.com>
499 * makefile.w32-in: The bootstrap-temacs rule now makes use of
500 one of two shell specific rules, either bootstrap-temacs-CMD or
501 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
502 to the previous implementation of the bootstrap-temacs rule.
503 The bootstrap-temacs-CMD rule is similar to the previous
504 implementation of the bootstrap-temacs rule except that it
505 makes use of the ESC_CFLAGS variable instead of the CFLAGS
508 These changes, along with some changes to nt/configure.bat,
509 nt/gmake.defs, and nt/nmake.defs, are required to extend my
510 earlier fix to add support for --cflags and --ldflags options
511 that include quotes so that it works whether make uses cmd or
514 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
516 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
517 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
519 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
520 a string. Handle both cases.
521 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
522 (Fdbus_register_method): Use Qinvalid_function.
524 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
526 * makefile.w32-in: Update dependencies.
527 (LISP_H): Add inttypes.h and stdin.h.
528 (PROCESS_H): Add unistd.h.
530 2011-05-06 Eli Zaretskii <eliz@gnu.org>
532 * lread.c: Include limits.h (fixes the MS-Windows build broken by
533 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
535 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
537 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
539 * term.c (vfatal): Remove stray call to va_end.
540 It's not needed and the C Standard doesn't allow it here anyway.
542 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
543 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
545 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
548 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
550 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
552 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
554 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
556 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
558 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
559 * charset.c (Fdefine_charset_internal): Don't initialize
560 charset.code_space[15]. The value was garbage, on hosts with
561 32-bit int (Bug#8600).
563 * lread.c (read_integer): Be more consistent with string-to-number.
564 Use string_to_number to do the actual conversion; this avoids
565 rounding errors and fixes some other screwups. Without this fix,
566 for example, #x1fffffffffffffff was misread as -2305843009213693952.
567 (digit_to_number): Move earlier, for benefit of read_integer.
568 Return -1 if the digit is out of range for the base, -2 if it is
569 not a digit in any supported base. (Bug#8602)
571 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
573 * dispnew.c (scrolling_window): Return 1 if we scrolled,
574 to match comment at start of function. This also removes a
575 GCC warning about overflow in a 32+64-bit port.
577 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
579 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
580 Reported by Stefan Monnier in
581 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
582 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages): Use
583 SYMBOLP-guarded XSYMBOL, not XPNTR.
585 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
586 (EMACS_UINTPTR): Likewise, with uintptr_t.
588 * lisp.h: Prefer 64-bit EMACS_INT if available.
589 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
590 on 32-bit hosts that have 64-bit int, so that they can access
592 However, temporarily disable this change unless the temporary
593 symbol WIDE_EMACS_INT is defined.
595 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
597 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
598 This removes an assumption that EMACS_INT and long are the same
599 width as pointers. The assumption is true for Emacs porting targets
600 now, but we want to make other targets possible.
601 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
602 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
603 In the rest of the code, change types of integers that hold casted
604 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
605 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
606 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
607 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
608 No need to cast type when ORing.
609 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
610 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
611 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
612 assume EMACS_INT is the same width as char *.
613 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
614 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
615 Remove no-longer-needed casts.
616 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
617 (xg_tool_bar_help_callback, xg_make_tool_item):
618 Use EMACS_INTPTR to hold an integer
619 that will be cast to void *; this can avoid a GCC warning
620 if EMACS_INT is not the same width as void *.
621 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
622 * xdisp.c (display_echo_area_1, resize_mini_window_1):
623 (current_message_1, set_message_1):
624 Use a local to convert to proper width without a cast.
625 * xmenu.c (dialog_selection_callback): Likewise.
627 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
628 Also, don't assume VALBITS / RAND_BITS is less than 5,
629 and don't rely on undefined behavior when shifting a 1 left into
631 * lisp.h (get_random): Change signature to match.
633 * lread.c (hash_string): Use size_t, not int, for hash computation.
634 Normally we prefer signed values; but hashing is special, because
635 it's better to use unsigned division on hash table sizes so that
636 the remainder is nonnegative. Also, size_t is the natural width
637 for hashing into memory. The previous code used 'int', which doesn't
638 retain enough info to hash well into very large tables.
639 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
641 * dbusbind.c: Don't possibly lose pointer info when converting.
642 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
643 Use XPNTR rather than XHASH, so that the high-order bits of
644 the pointer aren't lost when converting through void *.
646 * eval.c (Fautoload): Don't double-shift a pointer.
648 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
650 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
652 * gnutls.c (DEF_GNUTLS_FN):
653 * image.c (DEF_IMGLIB_FN): Make function pointers static.
655 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
657 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
660 2011-05-05 Eli Zaretskii <eliz@gnu.org>
662 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
663 New version that can reserve upto 2GB of heap space.
665 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
667 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
669 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
671 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
672 `gnutls_certificate_set_x509_key_file'.
674 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
676 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
679 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
681 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
682 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
683 Remove unused parameter `fildes'.
684 * process.c (read_process_output, send_process): Don't pass it.
686 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
688 Fix previous change: the library cache is defined in w32.c.
689 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
690 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
692 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
694 Implement dynamic loading of GnuTLS on Windows.
696 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
697 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
698 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
701 * gnutls.c (Qgnutls_dll): Define.
702 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
703 (gnutls_*): Declare function pointers.
704 (init_gnutls_functions): New function to initialize function pointers.
705 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
706 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
707 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
708 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
709 (emacs_gnutls_write, emacs_gnutls_read)
710 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
711 (Fgnutls_available_p): New function.
712 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
713 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
714 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
716 * image.c: Include w32.h.
717 (Vimage_type_cache): Delete.
718 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
719 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
720 (w32_delayed_load): Move to w32.c.
722 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
724 * w32.c (QCloaded_from, Vlibrary_cache): Define.
725 (w32_delayed_load): Move from image.c. When loading a library, record
726 its filename in the :loaded-from property of the library id.
727 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
728 Initialize and staticpro them.
729 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
731 * process.c: Include lisp.h before w32.h, not after.
732 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
733 instead of gnutls_record_check_pending.
735 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
737 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
739 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
740 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
743 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
745 * xterm.c (x_set_frame_alpha): Do not set property on anything
746 else than FRAME_X_OUTER_WINDOW (Bug#8608).
748 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
750 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
752 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
754 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
755 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
756 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
757 (gnutls_global_initialized, Qgnutls_bootprop_priority)
758 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
759 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
760 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
761 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
762 (Qgnutls_bootprop_callbacks_verify): Make static.
764 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
766 * callproc.c: Indentation fixup.
768 * sysdep.c (wait_for_termination_1): Make static.
769 (wait_for_termination, interruptible_wait_for_termination): Move
770 after wait_for_termination_1.
772 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
774 * sysdep.c (interruptible_wait_for_termination): New function
775 which is like wait_for_termination, but allows keyboard
778 * callproc.c (Fcall_process): Add (:file "file") as an option for
780 (Fcall_process_region): Ditto.
782 2011-04-30 Eli Zaretskii <eliz@gnu.org>
784 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
785 rather than `XVECTOR (FOO)->size'.
787 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
788 inttypes.h, as a gnulib replacement is used if it not available in
791 2011-04-21 Eli Zaretskii <eliz@gnu.org>
793 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
794 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
795 of MOST_POSITIVE_FIXNUM. (Bug#8528)
797 * coding.c (coding_alloc_by_realloc): Error out if destination
798 will grow beyond MOST_POSITIVE_FIXNUM.
799 (decode_coding_emacs_mule): Abort if there isn't enough place in
800 charbuf for the composition carryover bytes. Reserve an extra
801 space for up to 2 characters produced in a loop.
802 (decode_coding_iso_2022): Abort if there isn't enough place in
803 charbuf for the composition carryover bytes.
805 2011-04-21 Eli Zaretskii <eliz@gnu.org>
807 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
808 aborting when %lld or %lll format is passed.
809 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
810 %llo or %llx format is passed. (Bug#8545)
812 * window.c (window_scroll_line_based): Use a marker instead of
813 simple variables to record original value of point. (Bug#7952)
815 * doprnt.c (doprnt): Fix the case where a multibyte sequence
816 produced by %s or %c overflows available buffer space. (Bug#8545)
818 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
820 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
821 (SIZE_MAX): Move defn after all includes, as they might #define it.
823 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
825 * w32.c (init_environment): Warn about defaulting HOME to C:\.
827 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
829 * keyboard.c (Qdelayed_warnings_hook): Define.
830 (command_loop_1): Run `delayed-warnings-hook'
831 if Vdelayed_warnings_list is non-nil.
832 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
833 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
835 2011-04-28 Eli Zaretskii <eliz@gnu.org>
837 * doprnt.c (doprnt): Don't return value smaller than the buffer
838 size if the message was truncated. (Bug#8545).
840 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
842 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
843 (Fx_window_property): #if-0 the whole functions, not just the bodies.
845 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
847 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
849 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
851 * makefile.w32-in: Update dependencies.
853 2011-04-27 Eli Zaretskii <eliz@gnu.org>
855 Improve `doprnt' and its usage. (Bug#8545)
856 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
857 `format_end'. Remove support for %l as a conversion specifier.
858 Don't use xrealloc. Improve diagnostics when the %l size modifier
859 is used. Update the commentary.
861 * eval.c (verror): Simplify calculation of size_t.
863 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
866 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
868 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
871 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
873 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
874 This makes this file independent of the recent pseudovector change.
876 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
878 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
880 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
881 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
883 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
885 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
886 GCC 4.6.0 optimizes based on type-based alias analysis. For
887 example, if b is of type struct buffer * and v of type struct
888 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
889 != &v->size, and therefore "v->size = 1; b->size = 2; return
890 v->size;" must therefore return 1. This assumption is incorrect
891 for Emacs, since it type-puns struct Lisp_Vector * with many other
892 types. To fix this problem, this patch adds a new type struct
893 vectorlike_header that documents the constraints on layout of vectors
894 and pseudovectors, and helps optimizing compilers not get fooled
895 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
896 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
897 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
899 (XSETPVECTYPE): Rewrite in terms of new macro.
900 (XSETPVECTYPESIZE): New macro, specifying both type and size.
901 This is a bit clearer, and further avoids the possibility of
902 undesirable aliasing.
903 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
904 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
905 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
906 since Lisp_Subr is a special case (no "next" field).
907 (ASIZE): Now uses header.size rather than size. All
908 previous uses of XVECTOR (foo)->size replaced to use this macro,
909 to avoid the hassle of writing XVECTOR (foo)->header.size.
910 (struct vectorlike_header): New type.
911 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
912 object, to help avoid aliasing.
913 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
914 (SUBRP): Likewise, since Lisp_Subr is a special case.
915 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
916 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
917 (struct Lisp_Hash_Table): Combine first two members into a single
918 struct vectorlike_header member. All uses of "size" and "next" members
919 changed to be "header.size" and "header.next".
920 * buffer.h (struct buffer): Likewise.
921 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
922 * frame.h (struct frame): Likewise.
923 * process.h (struct Lisp_Process): Likewise.
924 * termhooks.h (struct terminal): Likewise.
925 * window.c (struct save_window_data, struct saved_window): Likewise.
926 * window.h (struct window): Likewise.
927 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
928 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
929 * buffer.c (init_buffer_once): Likewise.
930 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
932 * process.c (Fformat_network_address): Use local var for size,
935 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
937 Make the Lisp reader and string-to-float more consistent (Bug#8525)
938 * data.c (atof): Remove decl; no longer used or needed.
939 (digit_to_number): Move to lread.c.
940 (Fstring_to_number): Use new string_to_number function, to be
941 consistent with how the Lisp reader treats infinities and NaNs.
942 Do not assume that floating-point numbers represent EMACS_INT
943 without losing information; this is not true on most 64-bit hosts.
944 Avoid double-rounding errors, by insisting on integers when
945 parsing non-base-10 numbers, as the documentation specifies.
946 * lisp.h (string_to_number): New decl, replacing ...
947 (isfloat_string): Remove.
948 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
949 (read1): Do not accept +. and -. as integers; this
950 appears to have been a coding error. Similarly, do not accept
951 strings like +-1e0 as floating point numbers. Do not report
952 overflow for integer overflows unless the base is not 10 which
953 means we have no simple and reliable way to continue.
954 Break out the floating-point parsing into a new
955 function string_to_number, so that Fstring_to_number parses
956 floating point numbers consistently with the Lisp reader.
957 (digit_to_number): Moved here from data.c. Make it static inline.
958 (E_CHAR, EXP_INT): Remove, replacing with ...
959 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
960 (string_to_number): New function, replacing isfloat_string.
961 This function checks for valid syntax and produces the resulting
962 Lisp float number too. Rework it so that string-to-number
963 no longer mishandles examples like "1.0e+". Use strtoumax,
964 so that overflow for non-base-10 numbers is reported only when
965 there's no portable and simple way to convert to floating point.
967 * textprop.c (set_text_properties_1): Rewrite for clarity,
968 and to avoid GCC warning about integer overflow.
970 * intervals.h (struct interval): Use EMACS_INT for members
971 where EMACS_UINT might cause problems. See
972 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
973 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
974 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
976 (offset_intervals): Tell GCC not to worry about length overflow
977 when negating a negative length.
979 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
980 (overrun_check_free): Likewise.
982 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
983 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
986 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
987 (gnutls_make_error): Rename local to avoid shadowing.
988 (gnutls_emacs_global_deinit): ifdef out; not used.
989 (Fgnutls_boot): Use const for pointer to readonly storage.
990 Comment out unused local. Fix pointer signedness problems.
992 * lread.c (openp): Don't stuff size_t into an 'int'.
993 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
994 about possible signed overflow.
996 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
997 (GDK_KEY_g): Don't define if already defined.
998 (xg_prepare_tooltip): Avoid pointer signedness problem.
999 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1001 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1002 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1004 * xfns.c (Fx_window_property): Simplify a bit,
1005 to make a bit faster and to avoid GCC 4.6.0 warning.
1006 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1008 * fns.c (internal_equal): Don't assume size_t fits in int.
1010 * alloc.c (compact_small_strings): Tighten assertion a little.
1012 Replace pEd with more-general pI, and fix some printf arg casts.
1013 * lisp.h (pI): New macro, generalizing old pEd macro to other
1014 conversion specifiers. For example, use "...%"pI"d..." rather
1015 than "...%"pEd"...".
1016 (pEd): Remove. All uses replaced with similar uses of pI.
1017 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1018 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1019 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1020 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1021 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1022 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1023 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1025 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1026 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1027 * print.c (safe_debug_print, print_object): Likewise.
1028 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1030 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1031 avoiding the 0 flag, which is not portable.
1032 * process.c (Fmake_network_process): Use pI to avoid cast.
1033 * region-cache.c (pp_cache): Likewise.
1034 * xdisp.c (decode_mode_spec): Likewise.
1035 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1036 behavior on 64-bit hosts with printf arg.
1037 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
1038 (x_stop_queuing_selection_requests): Likewise.
1039 (x_get_window_property): Don't truncate byte count to an 'int'
1042 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1043 here, since it parses constructs like leading '-' and spaces,
1044 which are not wanted; and it overflows with large numbers.
1045 Instead, simply match F[0-9]+, which is what is wanted anyway.
1047 * alloc.c: Remove unportable assumptions about struct layout.
1048 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1049 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1050 (allocate_vectorlike, make_pure_vector): Use the new macros,
1051 plus offsetof, to remove unportable assumptions about struct layout.
1052 These assumptions hold on all porting targets that I know of, but
1053 they are not guaranteed, they're easy to remove, and removing them
1054 makes further changes easier.
1056 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1057 This doesn't fix a bug but makes the code clearer.
1058 (string_overrun_cookie): Now const. Use initializers that
1059 don't formally overflow signed char, to avoid warnings.
1060 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1061 can cause Emacs to crash when string overrun checking is enabled.
1062 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1063 multiple of sizeof (EMACS_INT); it need not be, if
1064 alignof(EMACS_INT) < sizeof (EMACS_INT).
1065 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
1067 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
1069 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1071 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1073 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
1074 supposed to be handshaking. (Bug#8556)
1075 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1077 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
1079 * lisp.h (Qdebug): List symbol.
1080 * eval.c (Qdebug): Restore global linkage.
1081 * keyboard.c (debug-on-event): New variable.
1082 (handle_user_signal): Break into debugger when debug-on-event
1083 matches the current signal symbol.
1085 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1087 * alloc.c (check_sblock, check_string_bytes)
1088 (check_string_free_list): Convert to standard C.
1090 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1092 * w32.c (emacs_gnutls_push): Fix typo.
1094 2011-04-25 Eli Zaretskii <eliz@gnu.org>
1096 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1097 "cast to pointer from integer of different size".
1099 Improve doprnt and its use in verror. (Bug#8545)
1100 * doprnt.c (doprnt): Document the set of format control sequences
1101 supported by the function. Use SAFE_ALLOCA instead of always
1104 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1105 is one byte too soon. Don't use xrealloc; instead xfree and
1108 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1110 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1113 * gnutls.c: Renamed global_initialized to
1114 gnutls_global_initialized. Added internals for the
1115 :verify-hostname-error, :verify-error, and :verify-flags
1116 parameters of `gnutls-boot' and documented those parameters in the
1117 docstring. Start callback support.
1118 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1119 unless a fatal error occured. Call gnutls_alert_send_appropriate
1120 on error. Return error code.
1121 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1122 (emacs_gnutls_read): Likewise.
1123 (Fgnutls_boot): Return handshake error code.
1124 (emacs_gnutls_handle_error): New function.
1125 (wsaerror_to_errno): Likewise.
1127 * w32.h (emacs_gnutls_pull): Add prototype.
1128 (emacs_gnutls_push): Likewise.
1130 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1131 (emacs_gnutls_push): Likewise.
1133 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1135 * process.c (wait_reading_process_output): Check if GnuTLS
1136 buffered some data internally if no FDs are set for TLS
1139 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1140 (LIBS): Link to USER_LIBS.
1141 ($(BLD)/gnutls.$(0)): New target.
1143 2011-04-24 Eli Zaretskii <eliz@gnu.org>
1145 * xdisp.c (handle_single_display_spec): Rename the
1146 display_replaced_before_p argument into display_replaced_p, to
1147 make it consistent with the commentary. Fix typos in the
1150 * textprop.c (syms_of_textprop): Remove dead code.
1151 (copy_text_properties): Delete obsolete commentary about an
1152 interface that was deleted long ago. Fix typos in the description
1155 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1156 to changes in oldXMenu/XMenu.h from 2011-04-16.
1157 <menu_help_message, prev_menu_help_message>: Constify.
1158 (IT_menu_make_room): menu->help_text is now `const char **';
1161 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1162 to changes in oldXMenu/XMenu.h from 2011-04-16.
1163 (struct XMenu): Declare `help_text' `const char **'.
1165 * xfaces.c <Qunspecified>: Make extern again.
1167 * syntax.c: Include sys/types.h before including regex.h, as
1170 * doc.c (get_doc_string): Improve the format passed to `error'.
1172 * doprnt.c (doprnt): Improve commentary.
1174 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1176 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1179 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1180 changes in globals.h immediately force recompilation.
1181 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1182 $(CURDIR)/s/ms-w32.h.
1183 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
1185 * character.c (Fchar_direction): Function deleted.
1186 (syms_of_character): Don't defsubr it.
1187 <char-direction-table>: Deleted.
1189 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1191 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1192 * doprnt.c: Include limits.h.
1193 (SIZE_MAX): New macro.
1194 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
1195 local variables are now size_t instead of int or unsigned.
1196 Improve overflow protection. Support `l' modifier for integer
1197 conversions. Support %l conversion. Don't assume an EMACS_INT
1198 argument for integer conversions and for %c.
1200 * lisp.h (doprnt): Restore prototype.
1202 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1205 * Makefile.in (base_obj): Add back doprnt.o.
1207 * deps.mk (doprnt.o): Add back prerequisites.
1208 (callint.o): Depend on character.h.
1210 * eval.c (internal_lisp_condition_case): Include the handler
1211 representation in the error message.
1212 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1213 when breaking from the loop.
1215 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1217 * callint.c (Fcall_interactively): When displaying error message
1218 about invalid control letter, pass the character's codepoint, not
1219 a pointer to its multibyte form. Improve display of the character
1220 in octal and display also its hex code.
1222 * character.c (char_string): Use %x to display the (unsigned)
1223 codepoint of an invalid character, to avoid displaying a bogus
1226 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1227 `error', not SYMBOL_NAME itself.
1229 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1230 character arguments to `error'.
1232 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1233 to `error' in error message about FINAL_CHAR argument. Make sure
1234 FINAL_CHAR is a character, and use %c when it is passed as
1235 argument to `error'.
1237 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1239 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1241 * w32.c: Include <time.h>.
1242 (sys_localtime): New function.
1244 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
1246 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1248 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1250 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1252 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1255 2011-04-19 Eli Zaretskii <eliz@gnu.org>
1257 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1258 gl_state.e_property when gl_state.object is Qt.
1260 * insdel.c (make_gap_larger): Remove limitation of buffer size
1263 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
1265 * xdisp.c (lookup_glyphless_char_display)
1266 (produce_glyphless_glyph): Handle cons cell entry in
1267 glyphless-char-display.
1268 (Vglyphless_char_display): Document it.
1270 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1271 glyphless-char-display.
1273 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
1275 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1277 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1279 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1280 definition for no-X builds.
1282 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1284 Static checks with GCC 4.6.0 and non-default toolkits.
1286 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1288 * process.c (keyboard_bit_set): Define only if SIGIO.
1289 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1290 (send_process): Repair possible setjmp clobbering.
1292 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1294 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1296 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1298 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1299 Define only if needed.
1301 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1302 by pacifying GCC about it. Maybe it's time to retire it?
1303 * xfaces.c (USG, __TIMEVAL__): Likewise.
1305 * dispextern.h (struct redisplay_interface): Rename param
1307 * termhooks.h (struct terminal): Likewise.
1308 * xterm.c (xembed_send_message): Likewise.
1310 * insdel.c (make_gap_smaller): Define only if
1311 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1313 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1316 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1317 so that we aren't warned about unused symbols.
1319 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1321 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1323 * xfns.c (x_real_positions): Mark locals as initialized.
1325 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1327 * xterm.c: Fix problems found by static analysis with other toolkits.
1328 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1329 (x_dispatch_event): Declare static if USE_GTK, and
1330 define if USE_GTK || USE_X_TOOLKIT.
1331 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1332 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1333 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1334 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1336 * xmenu.c (menu_help_callback): Pointer type fixes.
1337 Use const pointers when pointing at readonly data. Avoid pointer
1339 (FALSE): Remove unused macro.
1340 (update_frame_menubar): Remove unused decl.
1342 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1344 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1345 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1346 (single_menu_item): Rename local to avoid shadowing.
1348 * keyboard.c (make_lispy_event): Remove unused local var.
1350 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1351 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1353 * bitmaps: Change bitmaps from unsigned char back to the X11
1354 compatible char. Avoid the old compiler warnings about
1355 out-of-range initializers by using, for example, '\xab' rather
1358 * xgselect.c (xgselect_initialize): Check vs interface
1359 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1361 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1363 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1364 to read-only memory.
1366 * fns.c (vector): Remove; this old hack is no longer needed.
1368 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1370 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1372 * xrdb.c (x_load_resources): Omit unused local.
1374 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1375 (x_window): Rename locals to avoid shadowing.
1376 (USG): Use the kludged USG macro, to pacify gcc.
1378 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1379 (x_term_init): Remove local to avoid shadowing.
1381 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1383 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1384 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1386 2011-04-16 Eli Zaretskii <eliz@gnu.org>
1388 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1390 Fix regex.c, syntax.c and friends for buffers > 2GB.
1391 * syntax.h (struct gl_state_s): Declare character position members
1394 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1396 * textprop.c (verify_interval_modification, interval_of): Declare
1397 arguments EMACS_INT.
1399 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1402 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1404 * indent.c (Fvertical_motion): Local variable it_start is now
1407 * regex.c (re_match, re_match_2, re_match_2_internal)
1408 (bcmp_translate, regcomp, regexec, print_double_string)
1409 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1410 (re_compile_pattern, re_exec): Declare arguments and local
1411 variables `size_t' and `ssize_t' and return values `regoff_t', as
1413 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1414 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1415 <compile_stack_type>: `size' and `avail' are now `size_t'.
1417 * regex.h <regoff_t>: Use ssize_t, not int.
1418 (re_search, re_search_2, re_match, re_match_2): Arguments that
1419 specify buffer/string position and length are now ssize_t and
1420 size_t. Return type is regoff_t.
1422 2011-04-16 Ben Key <bkey76@gmail.com>
1424 * nsfont.m: Fixed bugs in ns_get_family and
1425 ns_descriptor_to_entity that were caused by using free to
1426 deallocate memory blocks that were allocated by xmalloc (via
1427 xstrdup). This caused Emacs to crash when compiled with
1428 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1429 --enable-checking=xmallocoverrun). xfree is now used to
1430 deallocate these memory blocks.
1432 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1434 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1436 emacs_write: Accept and return EMACS_INT for sizes.
1437 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1439 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1440 Accept and return EMACS_INT.
1441 (emacs_gnutls_write): Return the number of bytes written on
1443 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1444 (emacs_read, emacs_write): Remove check for negative size, as the
1445 Emacs source code has been audited now.
1446 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1447 (emacs_read, emacs_write): Use it.
1448 * process.c (send_process): Adjust to the new signatures of
1449 emacs_write and emacs_gnutls_write. Do not attempt to store
1450 a byte offset into an 'int'; it might overflow.
1451 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1453 * sound.c: Don't assume sizes fit in 'int'.
1454 (struct sound_device.period_size, alsa_period_size):
1455 Return EMACS_INT, not int.
1456 (struct sound_device.write, vox_write, alsa_write):
1457 Accept EMACS_INT, not int.
1458 (wav_play, au_play): Use EMACS_INT to store sizes and to
1459 record read return values.
1461 2011-04-15 Ben Key <bkey76@gmail.com>
1463 * keyboard.c (Qundefined): Don't declare static since it is used
1465 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1466 static since they are used in nsfont.m.
1468 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1470 * process.c (Qprocessp): Don't declare static.
1471 * lisp.h (Qprocessp): Declare again.
1473 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
1475 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1477 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1479 Improve C-level modularity by making more things 'static'.
1481 Don't publish debugger-only interfaces to other modules.
1482 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1483 (verify_bytepos, count_markers): Move decls to the only modules
1485 * region-cache.h (pp_cache): Likewise.
1486 * window.h (check_all_windows): Likewise.
1487 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1489 * sysdep.c (croak): Now static, if
1490 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1491 * syssignal.h (croak): Declare only if not static.
1493 * alloc.c (refill_memory_reserve): Now static if
1494 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1495 * lisp.h (refill_memory_reserve): Declare only if not static.
1497 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1498 Define only if USE_LUCID.
1500 * xrdb.c (x_customization_string, x_rm_string): Now static.
1502 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1503 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1505 * xdisp.c (draw_row_with_mouse_face): Now static.
1506 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1508 * window.h (check_all_windows): Mark externally visible.
1510 * window.c (window_deletion_count): Now static.
1512 * undo.c: Make symbols static if they're not exported.
1513 (last_undo_buffer, last_boundary_position, pending_boundary):
1516 * textprop.c (interval_insert_behind_hooks): Now static.
1517 (interval_insert_in_front_hooks): Likewise.
1519 * term.c: Make symbols static if they're not exported.
1520 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1521 (max_frame_lines, tty_set_terminal_modes):
1522 (tty_reset_terminal_modes, tty_turn_off_highlight):
1523 (get_tty_terminal): Now static.
1524 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1525 * termhooks.h (term_mouse_moveto): Do not declare if
1527 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1528 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1530 * sysdep.c: Make symbols static if they're not exported.
1531 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1533 (sigprocmask_set, full_mask): Remove; unused.
1534 (wait_debugging): Mark as visible.
1535 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1536 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1538 * syntax.c (syntax_temp): Define only if !__GNUC__.
1540 * sound.c (current_sound_device, current_sound): Now static.
1542 * search.c (searchbufs, searchbuf_head): Now static.
1544 * scroll.c (scroll_cost): Remove; unused.
1545 * dispextern.h (scroll_cost): Remove decl.
1547 * region-cache.h (pp_cache): Mark as externally visible.
1549 * process.c: Make symbols static if they're not exported.
1550 (process_tick, update_tick, create_process, chan_process):
1551 (Vprocess_alist, proc_buffered_char, datagram_access):
1552 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1553 (deactivate_process): Mark defn as static, as well as decl.
1554 * lisp.h (create_process): Remove decl.
1555 * process.h (chan_process, Vprocess_alist): Remove decls.
1557 * print.c: Make symbols static if they're not exported.
1558 (print_depth, new_backquote_output, being_printed, print_buffer):
1559 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1560 (print_interval, print_number_index, initial_stderr_stream):
1562 * lisp.h (Fprinc): Remove decl.
1563 (debug_output_compilation_hack): Mark as externally visible.
1565 * sysdep.c (croak): Move decl from here to syssignal.h.
1566 * syssignal.h (croak): Put it here, so the API can be checked when
1567 'croak' is called from dissociate_if_controlling_tty.
1569 * minibuf.c: Make symbols static if they're not exported.
1570 (minibuf_save_list, choose_minibuf_frame): Now static.
1571 * lisp.h (choose_minibuf_frame): Remove decl.
1573 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1575 * lread.c: Make symbols static if they're not exported.
1576 (read_objects, initial_obarray, oblookup_last_bucket_number):
1578 (make_symbol): Remove; unused.
1579 * lisp.h (initial_obarray, make_symbol): Remove decls.
1581 * keyboard.c: Make symbols static if they're not exported.
1582 (single_kboard, recent_keys_index, total_keys, recent_keys):
1583 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1584 (this_single_command_key_start, echoing, last_auto_save):
1585 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1586 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1587 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1588 (Vlispy_mouse_stem, double_click_count):
1590 (force_auto_save_soon): Define only if SIGDANGER.
1591 (ignore_mouse_drag_p): Now static if
1592 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1593 (print_help): Remove; unused.
1594 (stop_character, last_timer_event): Mark as externally visible.
1595 * keyboard.h (ignore_mouse_drag_p): Declare only if
1596 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1597 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1598 * lisp.h (echoing): Remove decl.
1599 (force_auto_save_soon): Declare only if SIGDANGER.
1600 * xdisp.c (redisplay_window): Simplify code, to make it more
1601 obvious that ignore_mouse_drag_p is not accessed if !defined
1602 USE_GTK && !defined HAVE_NS.
1604 * intervals.c: Make symbols static if they're not exported.
1605 (merge_properties_sticky, merge_interval_right, delete_interval):
1607 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1609 * insdel.c: Make symbols static if they're not exported.
1610 However, leave prepare_to_modify_buffer alone. It's never
1611 called from outside this function, but that appears to be a bug.
1612 (combine_after_change_list, combine_after_change_buffer):
1613 (adjust_after_replace, signal_before_change): Now static.
1614 (adjust_after_replace_noundo): Remove; unused.
1615 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
1616 (signal_before_change): Remove decls.
1618 * indent.c (val_compute_motion, val_vmotion): Now static.
1620 * image.c: Make symbols static if they're not exported.
1621 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1623 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1624 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1626 * fringe.c (standard_bitmaps): Now static.
1627 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1629 * frame.c: Make symbols static if they're not exported.
1630 (x_report_frame_params, make_terminal_frame): Now static.
1631 (get_frame_param): Now static, unless HAVE_NS.
1632 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1633 (x_get_resource_string): Remove; not used.
1634 * frame.h (make_terminal_frame, x_report_frame_params):
1635 (x_get_resource_string); Remove decls.
1636 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1637 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1639 * font.c, fontset.c: Make symbols static if they're not exported.
1640 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1641 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1642 * font.c (font_close_object): Now static.
1643 * font.h (font_close_object): Remove.
1644 * fontset.c (FONTSET_OBJLIST): Remove.
1645 (free_realized_fontset) #if-0 the body, which does nothing.
1646 (face_suitable_for_char_p): #if-0, as it's never called.
1647 * fontset.h (face_suitable_for_char_p): Remove decl.
1648 * xfaces.c (face_at_string_position): Use
1649 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1650 since 0 is always ASCII.
1652 * fns.c (weak_hash_tables): Now static.
1654 * fileio.c: Make symbols static if they're not exported.
1655 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1656 (Vwrite_region_annotation_buffers): Now static.
1658 * eval.c: Make symbols static if they're not exported.
1659 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1660 * lisp.h (backtrace_list): Remove decl.
1662 * emacs.c: Make symbols static if they're not exported.
1663 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1664 (fatal_error_code, fatal_error_signal_hook, standard_args):
1666 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1667 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1668 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1669 * lisp.h (fatal_error_signal_hook): Remove decl.
1670 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1672 * editfns.c: Move a (normally-unused) function to its only use.
1673 * editfns.c, lisp.h (get_operating_system_release): Remove.
1674 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1675 worth the hassle of breaking this out.
1677 * xterm.c: Make symbols static if they're not exported.
1678 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1679 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1680 (x_destroy_window, x_delete_display):
1682 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1683 (x_mouse_leave): Remove; unused.
1684 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1685 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1686 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1688 (x_mouse_leave): Declare only if WINDOWSNT.
1689 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1690 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1693 * ftxfont.c: Make symbols static if they're not exported.
1694 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1696 * font.h (ftxfont_driver): Likewise.
1698 * xfns.c: Make symbols static if they're not exported.
1699 (x_last_font_name, x_display_info_for_name):
1700 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1701 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1702 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1703 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1704 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1705 (last_show_tip_args): Now static.
1706 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1707 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1708 (x_screen_planes): Remove; unused.
1709 * dispextern.h (x_screen_planes): Remove decl.
1711 * dispnew.c: Make symbols static if they're not exported.
1712 * dispextern.h (redraw_garbaged_frames, scrolling):
1713 (increment_row_positions): Remove.
1714 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1715 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1717 (redraw_garbaged_frames): Remove; unused.
1719 * xfaces.c: Make symbols static if they're not exported.
1720 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1722 * xterm.h (defined_color): Remove decls.
1723 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1724 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1725 (menu_face_changed_default, defined_color, free_realized_face):
1726 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1727 (ascii_face_of_lisp_face): Remove; unused.
1729 * xdisp.c: Make symbols static if they're not exported.
1730 * dispextern.h (scratch_glyph_row, window_box_edges):
1731 (glyph_to_pixel_coords, set_cursor_from_row):
1732 (get_next_display_element, set_iterator_to_next):
1733 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1734 (show_mouse_face): Remove decls
1735 * frame.h (message_buf_print): Likewise.
1736 * lisp.h (pop_message, set_message, check_point_in_composition):
1738 * xterm.h (set_vertical_scroll_bar): Likewise.
1739 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1740 (message_buf_print, scratch_glyph_row, displayed_buffer):
1741 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1742 (get_next_display_element, show_mouse_face, window_box_edges):
1743 (frame_to_window_pixel_xy, check_point_in_composition):
1744 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1745 (glyph_to_pixel_coords): Remove; unused.
1747 * dired.c (file_name_completion): Now static.
1749 * dbusbind.c (xd_in_read_queued_messages): Now static.
1751 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1752 * data.c (circular_list_error): Remove.
1754 * commands.h (last_point_position, last_point_position_buffer):
1755 (last_point_position_window): Remove decls.
1756 * keyboard.c: Make these variables static.
1758 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
1760 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1761 (iso_code_class, detect_coding, code_convert_region): Now static.
1762 (encode_coding_gap): Remove; unused.
1764 * chartab.c (chartab_chars, chartab_bits): Now static.
1766 * charset.h (charset_iso_8859_1): Remove decl.
1767 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1770 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1771 * ccl.c (Vccl_program_table): Now static.
1772 (check_ccl_update): Remove; unused.
1774 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1775 * category.h: ... from here.
1776 * category.c (check_category_table, set_category_set): Now static.
1778 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1779 * lisp.h: Remove these decls.
1781 * buffer.c (buffer_count): Remove unused var.
1783 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1784 so that it's not optimized away.
1785 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1786 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1787 exported only to the debugger.
1789 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1790 * atimer.h (run_all_atimers): Removed; not exported.
1792 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1793 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1794 was inaccessible from Lisp.
1795 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1796 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1798 alloc.c: Import and export fewer symbols, and remove unused items.
1799 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1801 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1802 it's not optimized away by whole-program optimization.
1803 (message_enable_multibyte, free_misc): Remove.
1804 (catchlist, handlerlist, mark_backtrace):
1805 Declare only if BYTE_MARK_STACK.
1806 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1807 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1808 (message_enable_multibyte): Remove decl.
1809 (free_misc, interval_free_list, float_block, float_block_index):
1810 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1811 (cons_free_list, last_marked_index):
1813 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1814 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1815 (mark_backtrace): Define only if BYTE_MARK_STACK.
1816 * xdisp.c (message_enable_multibyte): Now static.
1818 Declare Lisp_Object Q* variables to be 'static' if not exported.
1819 This makes it easier for human readers (and static analyzers)
1820 to see whether these variables are used from other modules.
1821 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1822 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1823 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1824 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1825 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1826 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1827 * xmenu.c, xselect.c:
1828 Declare Q* vars static if they are not used in other modules.
1829 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1830 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1831 Remove decls of unexported vars.
1832 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1834 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1836 Make Emacs functions such as Fatom 'static' by default.
1837 This makes it easier for human readers (and static analyzers)
1838 to see whether these functions can be called from other modules.
1839 DEFUN now defines a static function. To make the function external
1840 so that it can be used in other C modules, use the new macro DEFUE.
1841 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1842 (Finit_image_library):
1843 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1844 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1845 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1846 Remove decls, since these functions are now static.
1847 (Funintern, Fget_internal_run_time): New decls, since these functions
1848 were already external.
1850 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1851 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1852 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1853 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1854 * keyboard.c, keymap.c, lread.c:
1855 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1856 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1857 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1858 Mark functions with DEFUE instead of DEFUN,
1859 if they are used in other modules.
1860 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1861 decls for now-static functions.
1862 * buffer.h (Fdelete_overlay): Remove decl.
1863 * callproc.c (Fgetenv_internal): Mark as internal.
1864 * composite.c (Fremove_list_of_text_properties): Remove decl.
1865 (Fcomposition_get_gstring): New forward static decl.
1866 * composite.h (Fcomposite_get_gstring): Remove decl.
1867 * dired.c (Ffile_attributes): New forward static decl.
1868 * doc.c (Fdocumntation_property): New forward static decl.
1869 * eval.c (Ffetch_bytecode): New forward static decl.
1870 (Funintern): Remove extern decl; now in .h file where it belongs.
1871 * fileio.c (Fmake_symbolic_link): New forward static decl.
1872 * image.c (Finit_image_library): New forward static decl.
1873 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1874 * intervals.h (Fprevious_property_change):
1875 (Fremove_list_of_text_properties): Remove decls.
1876 * keyboard.c (Fthis_command_keys): Remove decl.
1877 (Fcommand_execute): New forward static decl.
1878 * keymap.c (Flookup_key): New forward static decl.
1879 (Fcopy_keymap): Now static.
1880 * keymap.h (Flookup_key): Remove decl.
1881 * process.c (Fget_process): New forward static decl.
1882 (Fprocess_datagram_address): Mark as internal.
1883 * syntax.c (Fsyntax_table_p): New forward static decl.
1884 (skip_chars): Remove duplicate decl.
1885 * textprop.c (Fprevious_property_change): New forward static decl.
1886 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1888 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1889 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1891 * editfns.c (Fformat): Remove unreachable code.
1893 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1895 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1898 2011-04-13 Eli Zaretskii <eliz@gnu.org>
1900 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1901 when at ZV. (Bug#8487)
1903 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1905 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1907 * keyboard.c (parse_tool_bar_item): Likewise.
1908 * sound.c (sound_cleanup, alsa_close): Likewise.
1909 * termcap.c (tgetent): Likewise.
1910 * xfns.c (x_default_font_parameter): Likewise.
1911 * xsettings.c (read_and_apply_settings): Likewise.
1913 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1914 (overrun_check_free): Protoize.
1916 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1918 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1919 since callers should never pass a negative size.
1920 Change the signature to match that of plain 'read' and 'write'; see
1921 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1922 * lisp.h: Update prototypes of emacs_write and emacs_read.
1924 2011-04-11 Eli Zaretskii <eliz@gnu.org>
1926 * xdisp.c (redisplay_window): Don't try to determine the character
1927 position of the scroll margin if the window start point w->startp
1928 is outside the buffer's accessible region. (Bug#8468)
1930 2011-04-10 Eli Zaretskii <eliz@gnu.org>
1932 Fix write-region and its subroutines for buffers > 2GB.
1933 * fileio.c (a_write, e_write): Modify declaration of arguments and
1934 local variables to support buffers larger than 2GB.
1935 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1937 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1938 argument, local variables, and return value.
1940 * lisp.h: Update prototypes of emacs_write and emacs_read.
1942 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1944 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
1946 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1948 Fix more problems found by GCC 4.6.0's static checks.
1950 * xdisp.c (vmessage): Use a better test for character truncation.
1952 * charset.c (load_charset_map): <, not <=, for optimization,
1953 and to avoid potential problems with integer overflow.
1954 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
1955 * casetab.c (set_identity, shuffle): Likewise.
1956 * editfns.c (Fformat): Likewise.
1957 * syntax.c (skip_chars): Likewise.
1959 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1960 This also lets GCC 4.6.0 generate slightly better loop code.
1962 * callint.c (Fcall_interactively): <, not <=, for optimization.
1963 (Fcall_interactively): Count the number of arguments produced,
1964 not the number of arguments given. This is simpler and lets GCC
1965 4.6.0 generate slightly better code.
1967 * ftfont.c: Distingish more carefully between FcChar8 and char.
1968 The previous code passed unsigned char * to a functions like
1969 strlen and xstrcasecmp that expect char *, which does not
1970 conform to the C standard.
1971 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1972 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1973 char * when the C standard requires it.
1975 * keyboard.c (read_char): Remove unused var.
1977 * eval.c: Port to Windows vsnprintf (Bug#8435).
1979 (SIZE_MAX): Define if the headers do not.
1980 (verror): Do not give up if vsnprintf returns a negative count.
1981 Instead, grow the buffer. This ports to Windows vsnprintf, which
1982 does not conform to C99. Problem reported by Eli Zaretskii.
1983 Also, simplify the allocation scheme, by avoiding the need for
1984 calling realloc, and removing the ALLOCATED variable.
1986 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1988 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1989 But keep the doprint source code for now, as we might revamp it
1990 and use it again (Bug#8435).
1991 * lisp.h (doprnt): Remove.
1992 * Makefile.in (base_obj): Remove doprnt.o.
1993 * deps.mk (doprnt.o): Remove.
1995 error: Print 32- and 64-bit integers portably (Bug#8435).
1996 Without this change, on typical 64-bit hosts error ("...%d...", N)
1997 was used to print both 32- and 64-bit integers N, which relied on
1999 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2001 * lisp.h (error, verror): Mark as printf-like functions.
2002 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2003 Report overflow in size calculations when allocating printf buffer.
2004 Do not truncate output string at its first null byte.
2005 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2006 Truncate the output at a character boundary, since vsnprintf does not
2008 * charset.c (check_iso_charset_parameter): Convert internal
2009 character to string before calling 'error', since %c now has the
2011 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2012 overflow when computing char to be passed to 'error'. Do not
2013 pass Lisp_Object to 'error'; pass the integer instead.
2014 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2015 formatted with plain %d.
2017 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2019 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2021 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2023 * xterm.c (x_catch_errors): Remove duplicate declaration.
2025 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2027 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2029 2011-04-10 Jim Meyering <meyering@redhat.com>
2031 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2032 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2033 return ssize_t not "int", and use size_t as the buffer length.
2034 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2035 * gnutls.h: Update declarations.
2036 * process.c (read_process_output): Use ssize_t, to match.
2037 (send_process): Likewise.
2039 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2041 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2043 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2045 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
2046 unsigned char, to match FcChar8 type definition.
2048 * xterm.c (handle_one_xevent):
2049 * xmenu.c (create_and_show_popup_menu):
2050 * xselect.c (x_decline_selection_request)
2051 (x_reply_selection_request): Avoid type-punned deref of X events.
2053 2011-04-09 Eli Zaretskii <eliz@gnu.org>
2055 Fix some uses of `int' instead of EMACS_INT.
2056 * search.c (string_match_1, fast_string_match)
2057 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2058 (scan_buffer, find_next_newline_no_quit)
2059 (find_before_next_newline, search_command, Freplace_match)
2060 (Fmatch_data): Make some `int' variables be EMACS_INT.
2062 * xdisp.c (display_count_lines): 3rd argument and return value now
2063 EMACS_INT. All callers changed.
2064 (pint2hrstr): Last argument is now EMACS_INT.
2066 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2067 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2068 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2069 (decode_coding_utf_16, decode_coding_emacs_mule)
2070 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2071 (decode_coding_ccl, decode_coding_charset)
2072 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2073 (decode_coding_iso_2022, decode_coding_emacs_mule)
2074 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2075 <char_offset, last_offset>: Declare EMACS_INT.
2076 (encode_coding_utf_8, encode_coding_utf_16)
2077 (encode_coding_emacs_mule, encode_invocation_designation)
2078 (encode_designation_at_bol, encode_coding_iso_2022)
2079 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2080 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2082 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2083 (encode_invocation_designation): Last argument P_NCHARS is now
2085 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2086 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2088 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2091 * ccl.c (Fccl_execute_on_string): Declare some variables
2094 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
2096 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2098 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2100 * process.c (Fformat_network_address): Doc fix.
2102 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2104 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2106 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
2108 * keyboard.c (read_char): Call Lisp function help-form-show,
2109 instead of using internal_with_output_to_temp_buffer.
2110 (Qhelp_form_show): New var.
2111 (syms_of_keyboard): Use DEFSYM macro.
2113 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2115 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2117 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
2119 * process.c (Flist_processes): Removed to Lisp.
2120 (list_processes_1): Deleted.
2122 2011-04-06 Eli Zaretskii <eliz@gnu.org>
2124 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2126 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2128 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
2130 Fix more problems found by GCC 4.6.0's static checks.
2132 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2134 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2136 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
2138 * xdisp.c (vmessage): Mark as a printf-like function.
2140 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2142 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2144 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2145 printf-like functions.
2146 (tiff_load): Add casts to remove these marks before passing them
2147 to system-supplied API.
2149 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2151 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2152 This avoids several warnings with gcc -Wstrict-overflow.
2153 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2154 directly, rather than having caller test rule sign. This avoids
2155 some unnecessary tests.
2156 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2157 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2158 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
2160 * xfont.c (xfont_text_extents): Remove var that was set but not used.
2161 (xfont_open): Avoid unnecessary tests.
2163 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2165 * composite.h, composite.c (composition_gstring_put_cache):
2166 Use EMACS_INT, not int, for length.
2168 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2169 breaking out part of COMPOSITION_DECODE_RULE.
2170 (COMPOSITION_DECODE_RULE): Use it.
2171 * composite.c (get_composition_id): Remove unused local vars,
2172 by using the new macro.
2174 * textprop.c (set_text_properties_1): Change while to do-while,
2175 since the condition is always true at first.
2177 * intervals.c (graft_intervals_into_buffer): Mark var as used.
2178 (interval_deletion_adjustment): Return unsigned value.
2181 * process.c (list_processes_1, create_pty, read_process_output):
2182 (exec_sentinel): Remove vars that were set but not used.
2183 (create_pty): Remove unnecessary "volatile"s.
2184 (Fnetwork_interface_info): Avoid possibility of int overflow.
2185 (read_process_output): Do adaptive read buffering even if carryover.
2186 (read_process_output): Simplify nbytes computation if buffered.
2188 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2190 * syntax.c (scan_words): Remove var that was set but not used.
2191 (update_syntax_table): Use unsigned instead of int.
2193 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
2194 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
2195 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
2197 * print.c (print_error_message): Avoid int overflow.
2199 * font.c (font_list_entities): Redo for clarity,
2200 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2202 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
2203 (font_score): Avoid potential overflow in diff calculation.
2205 * fns.c (substring_both): Remove var that is set but not used.
2206 (sxhash): Redo loop for clarity and to avoid wraparound warning.
2208 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2210 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2211 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2212 can always succeed if overflow has undefined behavior.
2214 * search.c (boyer_moore, wordify): Remove vars set but not used.
2215 (wordify): Omit three unnecessary tests.
2217 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2218 All callers changed. This avoids the need for an unused var.
2220 * casefiddle.c (casify_region): Remove var that is set but not used.
2222 * dired.c (file_name_completion): Remove var that is set but not used.
2224 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2226 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2227 (Finsert_file_contents): Remove unnecessary code checking fd.
2229 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2230 Check for integer overflow on size calculations.
2232 * buffer.c (Fprevious_overlay_change): Remove var that is set
2235 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2236 Remove vars that are set but not used.
2237 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2238 (timer_check_2): Mark vars as initialized.
2240 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2242 * image.c (lookup_image): Remove var that is set but not used.
2243 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2245 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2246 that are set but not used.
2248 * xfns.c (make_invisible_cursor): Don't return garbage
2249 if XCreateBitmapFromData fails (Bug#8410).
2251 * xselect.c (x_get_local_selection, x_handle_property_notify):
2252 Remove vars that are set but not used.
2254 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2255 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2257 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2258 Remove var that is set but not used.
2259 (scroll_bar_windows_size): Now size_t, not int.
2260 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2263 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2264 (map_tty_color) [!defined MSDOS]: Likewise.
2266 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2268 * coding.c: Remove vars that are set but not used.
2269 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2270 All callers changed.
2271 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2272 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2273 (decode_coding_charset): Remove vars that are set but not used.
2275 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2276 that is set but not used.
2278 * print.c (print_object): Remove var that is set but not used.
2280 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2281 The gnulib version avoids calling malloc in the usual case,
2282 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2283 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2284 * filelock.c (current_lock_owner): Likewise.
2285 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2286 * sysdep.c: Include allocator.h, careadlinkat.h.
2287 (emacs_no_realloc_allocator): New static constant.
2288 (emacs_readlink): New function.
2289 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2290 ../lib/careadlinkat.h.
2292 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2294 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2295 first non-nil return value).
2297 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2299 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2300 if not defined (Bug#8403).
2302 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2304 * xdisp.c (display_count_lines): Remove parameter `start',
2305 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2306 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2307 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2308 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2309 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2310 and thereabouts. All callers changed.
2311 (get_per_char_metric): Remove parameter `f', unused since
2312 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2314 2011-04-02 Jim Meyering <meyering@redhat.com>
2316 do not dereference NULL upon failed strdup
2317 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2318 (ns_get_family): Likewise.
2320 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2322 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2324 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2326 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2329 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2331 Add lexical binding.
2333 * window.c (Ftemp_output_buffer_show): New fun.
2334 (Fsave_window_excursion):
2335 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2337 * lread.c (lisp_file_lexically_bound_p): New function.
2338 (Fload): Bind Qlexical_binding.
2339 (readevalloop): Remove `evalfun' arg.
2340 Bind Qinternal_interpreter_environment.
2341 (Feval_buffer): Bind Qlexical_binding.
2342 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2344 (syms_of_lread): Declare `lexical-binding'.
2346 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2348 * keyboard.c (eval_dyn): New fun.
2349 (menu_item_eval_property): Use it.
2351 * image.c (parse_image_spec): Use Ffunctionp.
2353 * fns.c (concat, mapcar1): Accept byte-code-functions.
2355 * eval.c (Fsetq): Handle lexical vars.
2356 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2357 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2358 (FletX, Flet): Obey lexical binding.
2359 (Fcommandp): Handle closures.
2360 (Feval): New `lexical' arg.
2361 (eval_sub): New function extracted from Feval. Use it almost
2362 everywhere where Feval was used. Look up vars in lexical env.
2364 (Ffunctionp): Move from subr.el.
2365 (Ffuncall): Handle closures.
2366 (apply_lambda): Remove `eval_flags'.
2367 (funcall_lambda): Handle closures and new byte-code-functions.
2368 (Fspecial_variable_p): New function.
2369 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2370 but without exporting it to Lisp.
2372 * doc.c (Fdocumentation, store_function_docstring):
2373 * data.c (Finteractive_form): Handle closures.
2375 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2378 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
2380 (exec_byte_code): New function extracted from Fbyte_code to handle new
2381 calling convention for byte-code-functions. Add new byte-codes.
2383 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2385 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2387 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2389 * xdisp.c (redisplay_internal): Fix prototype.
2391 2011-03-31 Eli Zaretskii <eliz@gnu.org>
2393 * xdisp.c (SCROLL_LIMIT): New macro.
2394 (try_scrolling): Use it when setting scroll_limit. Limit
2395 scrolling to 100 screen lines.
2396 (redisplay_window): Even when falling back on "recentering",
2397 position point in the window according to scroll-conservatively,
2398 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2400 (try_scrolling): When point is above the window, allow searching
2401 as far as scroll_max, or one screenful, to compute vertical
2402 distance from PT to the scroll margin position. This prevents
2403 try_scrolling from unnecessarily failing when
2404 scroll-conservatively is set to a value slightly larger than the
2405 window height. Clean up the case of PT below the margin at bottom
2406 of window: scroll_max can no longer be INT_MAX. When aggressive
2407 scrolling is in use, don't let point enter the opposite scroll
2408 margin as result of the scroll.
2409 (syms_of_xdisp) <scroll-conservatively>: Document the
2410 threshold of 100 lines for never-recentering scrolling.
2412 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2414 * dispextern.h (move_it_by_lines):
2415 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2416 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2417 (message_log_check_duplicate): Remove parameters `prev_bol' and
2418 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2419 (redisplay_internal): Remove parameter `preserve_echo_area',
2420 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2422 * indent.c (Fvertical_motion):
2423 * window.c (window_scroll_pixel_based, Frecenter):
2424 Don't pass `need_y_p' to `move_it_by_lines'.
2426 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2428 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2429 steal a few bits to be more compact.
2430 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2431 Remove unneeded casts.
2433 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2435 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2437 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2438 binding" message (bug#7967).
2440 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2442 Fix more problems found by GCC 4.6.0's static checks.
2444 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2445 Remove unused local var.
2447 * editfns.c (Fmessage_box): Remove unused local var.
2449 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2450 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2451 Omit unused local vars.
2452 * window.c (shrink_windows): Omit unused local var.
2453 * menu.c (digest_single_submenu): Omit unused local var.
2454 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2455 Omit unused local var.
2457 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2458 Don't assume string length fits in int.
2459 (keyremap_step, read_key_sequence): Use size_t for sizes.
2460 (read_key_sequence): Don't check last_real_key_start redundantly.
2462 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2463 instead of alloca (Bug#8344).
2465 * eval.c (Fbacktrace): Don't assume nargs fits in int.
2466 (Fbacktrace_frame): Don't assume nframes fits in int.
2468 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2470 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2473 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2475 * cm.c (calccost): Turn while-do into do-while, for clarity.
2477 * keyboard.c (syms_of_keyboard): Use the same style as later
2478 in this function when indexing through an array. This also
2479 works around GCC bug 48267.
2481 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2483 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2485 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2486 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2488 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2489 This avoids undefined behavior on integer overflow, and is a bit
2490 more convenient anyway since it is compared to a size_t variable.
2492 Variadic C functions now count arguments with size_t, not int.
2493 This avoids an unnecessary limitation on 64-bit machines, which
2494 caused (substring ...) to crash on large vectors (Bug#8344).
2495 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2496 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
2497 All variadic functions and their callers changed accordingly.
2498 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2499 * data.c (arith_driver, float_arith_driver): Likewise.
2500 * editfns.c (general_insert_function): Likewise.
2501 * eval.c (struct backtrace.nargs, interactive_p)
2502 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2503 (funcall_lambda, mark_backtrace): Likewise.
2504 * fns.c (concat): Likewise.
2505 * frame.c (x_set_frame_parameters): Likewise.
2506 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2507 0 if not found, not -1. All callers changed.
2509 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2510 (stack_copy_size): Now size_t, not int.
2511 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2513 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2515 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2516 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2517 All callers changed.
2519 * lisp.h (multibyte_char_to_unibyte):
2520 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2521 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2522 * character.h (CHAR_TO_BYTE8):
2523 * cmds.c (internal_self_insert):
2524 * editfns.c (general_insert_function):
2525 * keymap.c (push_key_description):
2526 * search.c (Freplace_match):
2527 * xdisp.c (message_dolog, set_message_1): All callers changed.
2529 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2531 * keyboard.c (safe_run_hook_funcall): New function.
2532 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2533 don't set the hook to nil, but remove the offending function instead.
2534 (Qcommand_hook_internal): Remove, unused.
2535 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2536 Vcommand_hook_internal.
2538 * eval.c (enum run_hooks_condition): Remove.
2539 (funcall_nil, funcall_not): New functions.
2540 (run_hook_with_args): Call each function through a `funcall' argument.
2541 Remove `cond' argument, now redundant.
2542 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2543 (Frun_hook_with_args_until_failure): Adjust accordingly.
2544 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2546 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2548 * dispextern.h (string_buffer_position): Remove declaration.
2550 * print.c (strout): Remove parameter `multibyte', unused since
2551 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2553 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2554 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2555 All callers changed.
2557 * w32.c (_wsa_errlist): Use braces for struct initializers.
2559 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2560 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2561 All callers changed.
2562 (string_buffer_position): Likewise. Also, make static (it's never
2563 used outside xdisp.c).
2564 (cursor_row_p): Remove parameter `w', unused since
2565 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2566 (decode_mode_spec): Remove parameter `precision', introduced during
2567 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2568 All callers changed.
2570 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2572 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2574 2011-03-27 Anders Lindgren <andlind@gmail.com>
2576 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2577 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2578 (ns_update_auto_hide_menu_bar): New functions.
2579 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2580 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2581 ns_constrain_all_frames.
2582 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2583 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2585 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2587 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2589 2011-03-27 Glenn Morris <rgm@gnu.org>
2591 * syssignal.h: Replace RETSIGTYPE with void.
2592 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2593 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2594 Replace SIGTYPE with void everywhere.
2595 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2596 * s/template.h (SIGTYPE): Remove commented out definition.
2598 2011-03-26 Eli Zaretskii <eliz@gnu.org>
2600 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2601 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2603 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
2605 * w32.c (read_unc_volume): Use parameter `henum', instead of
2606 global variable `wget_enum_handle'.
2608 * keymap.c (describe_vector): Remove parameters `indices' and
2609 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2610 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2612 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2614 * keyboard.c (timer_check): Remove parameter `do_it_now',
2615 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2616 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2617 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2619 * keyboard.c (read_char):
2620 * w32menu.c (w32_menu_display_help):
2621 * xmenu.c (show_help_event, menu_help_callback):
2622 Adjust calls to `show_help_echo'.
2624 * gtkutil.c (xg_maybe_add_timer):
2625 * keyboard.c (readable_events):
2626 * process.c (wait_reading_process_output):
2627 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2629 * insdel.c (adjust_markers_gap_motion):
2630 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2631 (gap_left, gap_right): Don't call it.
2633 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
2635 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2636 incurred during fontification.
2638 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2640 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2641 (DEFVAR_PER_BUFFER): Don't pass it.
2643 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2644 (scrolling_window): Don't pass it.
2646 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2648 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2650 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2652 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2653 of variables specific to SELinux and computation of `encoded_absname'.
2655 * image.c (XPutPixel): Remove unused variable `height'.
2657 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2659 * unexw32.c (get_section_info): Remove unused variable `section'.
2661 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2662 (system_process_attributes): Remove unused variable `sess'.
2663 (sys_read): Remove unused variable `err'.
2665 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2666 (w32_wnd_proc): Remove unused variable `isdead'.
2667 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2668 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2669 (x_create_tip_frame): Remove unused variable `tem'.
2671 * w32inevt.c (w32_console_read_socket):
2672 Remove unused variable `no_events'.
2674 * w32term.c (x_draw_composite_glyph_string_foreground):
2675 Remove unused variable `width'.
2677 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
2679 * w32term.c (x_set_glyph_string_clipping):
2680 Don't pass uninitialized region to CombineRgn.
2682 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
2684 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2685 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2686 (Fx_close_connection): Remove unused variable `i'.
2688 * w32font.c (w32font_draw): Return number of glyphs.
2689 (w32font_open_internal): Remove unused variable `i'.
2690 (w32font_driver): Add missing initializer.
2692 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2693 (fill_in_menu): Remove unused variable `items_added'.
2695 * w32term.c (last_mouse_press_frame): Remove static global variable.
2696 (w32_clip_to_row): Remove unused variable `f'.
2697 (x_delete_terminal): Remove unused variable `i'.
2699 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2700 (NOTHING): Remove unused static global variable.
2701 (uniscribe_check_otf): Remove unused variable `table'.
2702 (uniscribe_font_driver): Add missing initializers.
2704 2011-03-23 Julien Danjou <julien@danjou.info>
2706 * term.c (Fsuspend_tty, Fresume_tty):
2707 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2708 * window.c (temp_output_buffer_show):
2709 * insdel.c (signal_before_change):
2710 * frame.c (Fhandle_switch_frame):
2711 * fileio.c (Fdo_auto_save):
2712 * emacs.c (Fkill_emacs):
2713 * editfns.c (save_excursion_restore):
2714 * cmds.c (internal_self_insert):
2715 * callint.c (Fcall_interactively):
2716 * buffer.c (Fkill_all_local_variables):
2717 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2719 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
2720 unconditionnaly since it does the check itself.
2722 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
2724 Fix more problems found by GCC 4.5.2's static checks.
2726 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2727 the first time through the loop, since we know p0 < p1 then.
2728 This also avoids a gcc -Wstrict-overflow warning.
2730 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2731 leading to a memory leak, possible in functions like
2732 load_charset_map_from_file that can allocate an unbounded number
2733 of objects (Bug#8318).
2735 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2736 that could (at least in theory) be that large.
2738 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2739 This is less likely to overflow, and avoids undefined behavior if
2740 overflow does occur. All callers changed. Use strtoul to scan
2741 for the unsigned long integer.
2742 (pint2hrstr): Simplify and tune code slightly.
2743 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
2745 * scroll.c (do_scrolling): Work around GCC bug 48228.
2746 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2748 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2749 This also avoids a warning with gcc -Wstrict-overflow.
2750 (validate_x_resource_name): Simplify count usage.
2751 This also avoids a warning with gcc -Wstrict-overflow.
2753 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2756 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
2758 * process.c (Fmake_network_process): Use socklen_t, not int,
2759 where POSIX says socklen_t is required in portable programs.
2760 This fixes a porting bug on hosts like 64-bit HP-UX, where
2761 socklen_t is wider than int (Bug#8277).
2762 (Fmake_network_process, server_accept_connection):
2763 (wait_reading_process_output, read_process_output):
2766 * process.c: Rename or move locals to avoid shadowing.
2767 (list_processes_1, Fmake_network_process):
2768 (read_process_output_error_handler, exec_sentinel_error_handler):
2769 Rename or move locals.
2770 (Fmake_network_process): Define label "retry_connect" only if needed.
2771 (Fnetwork_interface_info): Fix pointer signedness.
2772 (process_send_signal): Add cast to avoid pointer signedness problem.
2773 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
2774 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
2776 Make tparam.h and terminfo.c consistent.
2777 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2778 Include tparam.h instead, since it declares them.
2779 * cm.h (PC): Remove extern decl; tparam.h now does this.
2780 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2781 * terminfo.c: Include tparam.h, to check interfaces.
2782 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2783 (tparam): Adjust signature to match interface in tparam.h;
2784 this removes some undefined behavior. Check that outstring and len
2785 are zero, which they always are with Emacs.
2786 * tparam.h (PC, BC, UP): New extern decls.
2788 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
2789 (xftfont_open): Rename locals to avoid shadowing.
2791 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
2792 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2793 (OTF_TAG_SYM): Omit macro if not needed.
2794 (ftfont_list): Remove unused local.
2795 (get_adstyle_property, ftfont_pattern_entity):
2796 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2797 Rename locals to avoid shadowing.
2799 * xfont.c (xfont_list_family): Mark var as initialized.
2801 * xml.c (make_dom): Now static.
2803 * composite.c (composition_compute_stop_pos): Rename local to
2805 (composition_reseat_it): Remove unused locals.
2806 (find_automatic_composition, composition_adjust_point): Likewise.
2807 (composition_update_it): Mark var as initialized.
2808 (find_automatic_composition): Mark vars as initialized,
2809 with a FIXME (Bug#8290).
2811 character.h: Rename locals to avoid shadowing.
2812 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2813 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2814 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2815 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2818 * textprop.c (property_change_between_p): Remove; unused.
2820 * intervals.c (interval_start_pos): Now static.
2822 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2824 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2825 Rename locals to avoid shadowing.
2827 * sound.c (wav_play, au_play, Fplay_sound_internal):
2828 Fix pointer signedness.
2829 (alsa_choose_format): Remove unused local var.
2830 (wav_play): Initialize a variable to 0, to prevent undefined
2831 behavior (Bug#8278).
2833 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2835 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2837 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2838 clobbering (Bug#8298).
2839 * sysdep.c (sys_subshell): Likewise.
2840 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
2842 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2843 This should get cleaned up, so that child_setup has the
2844 same signature on all platforms.
2846 * callproc.c (call_process_cleanup): Now static.
2847 (relocate_fd): Rename locals to avoid shadowing.
2849 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
2851 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2852 not to be necessary, and produces flickering.
2854 2011-03-20 Glenn Morris <rgm@gnu.org>
2856 * config.in: Remove file.
2858 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
2860 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2861 are now in src/globals.h.
2862 (syms_of_minibuf): Remove spurious & from previous change.
2864 2011-03-20 Leo <sdl.web@gmail.com>
2866 * minibuf.c (completing-read-function): New variable.
2867 (completing-read-default): Rename from completing-read.
2868 (completing-read): Call completing-read-function.
2870 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2872 * xfaces.c (Fx_load_color_file):
2873 Read color file from absolute filename (bug#8250).
2875 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2877 * makefile.w32-in: Update dependencies.
2879 2011-03-17 Eli Zaretskii <eliz@gnu.org>
2881 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2883 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2885 Fix more problems found by GCC 4.5.2's static checks.
2887 * process.c (make_serial_process_unwind, send_process_trap):
2888 (sigchld_handler): Now static.
2890 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2891 That way, the code declares only the vars that it needs.
2892 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2893 * s/cygwin.h (PTY_ITERATION): Likewise.
2894 * s/darwin.h (PTY_ITERATION): Likewise.
2895 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2897 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2898 * process.c (allocate_pty): Don't declare stb unless it's needed.
2900 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
2901 (CONSTANTLIM): Remove; unused.
2902 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2903 Define only if needed.
2905 * unexelf.c (unexec): Name an expression,
2906 to avoid gcc -Wbad-function-cast warning.
2907 Use a different way to cause a compilation error if anyone uses
2908 n rather than nn, a way that does not involve shadowing.
2909 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
2911 * deps.mk (unexalpha.o): Remove; unused.
2913 New file unexec.h, the (simple) interface for unexec (Bug#8267).
2914 * unexec.h: New file.
2915 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2916 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2918 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2919 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2920 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
2921 Change as necessary to match prototype in unexec.h.
2923 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2925 (back_comment, skip_chars): Mark vars as initialized.
2927 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2928 Rename locals to avoid shadowing.
2930 * lread.c (read1): Rewrite so as not to use empty "else".
2931 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
2933 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2935 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2936 warning when compiling print.c.
2938 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2939 instead of using an uninitialized var.
2940 (font_sort_entities): Mark var as initialized.
2942 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2944 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2945 pointers to constants.
2946 (font_parse_fcname): Remove unused vars.
2947 (font_delete_unmatched): Now static.
2948 (font_get_spec): Remove; unused.
2949 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2950 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2951 Rename or move locals to avoid shadowing.
2953 * fns.c (require_nesting_list, require_unwind): Now static.
2954 (Ffillarray): Rename locals to avoid shadowing.
2956 * floatfns.c (domain_error2): Define only if needed.
2957 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
2959 * alloc.c (mark_backtrace): Move decl from here ...
2960 * lisp.h: ... to here, so that it can be checked.
2962 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
2963 (Fdefvar): Rewrite so as not to use empty "else".
2964 (lisp_indirect_variable): Name an expression,
2965 to avoid gcc -Wbad-function-cast warning.
2966 (Fdefvar): Rename locals to avoid shadowing.
2968 * callint.c (quotify_arg, quotify_args): Now static.
2969 (Fcall_interactively): Rename locals to avoid shadowing.
2970 Use const pointer when appropriate.
2972 * lisp.h (get_system_name, get_operating_system_release):
2973 Move decls here, to check interfaces.
2974 * process.c (get_operating_system_release): Move decl to lisp.h.
2975 * xrdb.c (get_system_name): Likewise.
2976 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2977 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2978 some of which prompt warnings from gcc -Wbad-function-cast.
2979 (Fformat_time_string, Fencode_time, Finsert_char):
2980 (Ftranslate_region_internal, Fformat):
2981 Rename or remove local vars to avoid shadowing.
2982 (Ftranslate_region_internal): Mark var as initialized.
2984 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2987 * lisp.h (eassert): Check that the argument compiles, even if
2988 ENABLE_CHECKING is not defined.
2990 * data.c (Findirect_variable): Name an expression, to avoid
2991 gcc -Wbad-function-cast warning.
2992 (default_value, arithcompare, arith_driver, arith_error): Now static.
2993 (store_symval_forwarding): Rename local to avoid shadowing.
2994 (Fmake_variable_buffer_local, Fmake_local_variable):
2995 Mark variables as initialized.
2996 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
2998 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
2999 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3000 Rename locals to avoid shadowing.
3001 (mark_stack): Move local variables into the #ifdef region where
3003 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3004 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3006 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3007 (GC_STRING_CHARS): Remove; not used.
3008 (Fmemory_limit): Cast sbrk's returned value to char *.
3010 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3011 avoids undefined behavior in theory.
3013 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3015 Use functions, not macros, for up- and down-casing (Bug#8254).
3016 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3017 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3018 to use the following functions instead of these macros.
3019 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3020 EMACS_INT, since callers assume the returned value fits in int.
3021 (upcase1): Likewise, for UPCASE_TABLE.
3022 (uppercasep, lowercasep, upcase): New static inline functions.
3023 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
3024 the race-condition problem in the old DOWNCASE.
3026 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3027 Rename locals to avoid shadowing.
3028 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
3029 (regex_compile, re_search_2, re_match_2_internal):
3030 Remove unused local vars.
3031 (FREE_VAR): Rewrite so as not to use empty "else",
3032 which gcc can warn about.
3033 (regex_compile, re_match_2_internal): Mark locals as initialized.
3034 (RETALLOC_IF): Define only if needed.
3035 (WORDCHAR_P): Likewise. This one is never needed, but is used
3036 only in a comment talking about a compiler bug, so put inside
3037 the #if 0 of that comment.
3038 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3039 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3042 * search.c (boyer_moore): Rename locals to avoid shadowing.
3043 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3044 (PREV_CHAR_BOUNDARY): Likewise.
3046 * search.c (simple_search): Remove unused var.
3048 * dired.c (compile_pattern): Move decl from here ...
3049 * lisp.h: ... to here, so that it can be checked.
3050 (struct re_registers): New forward decl.
3052 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3054 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3056 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3057 Rename locals to avoid shadowing.
3058 (Fvertical_motion): Mark locals as initialized.
3060 * casefiddle.c (casify_object, casify_region): Now static.
3061 (casify_region): Mark local as initialized.
3063 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3065 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3066 New macros, so that the caller can use some names other than
3067 gcpro1, gcpro2, etc.
3068 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3070 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3071 argument, for consistency with GCPRO2_VAR, etc: it is now the
3072 prefix of the variable, not the variable itself. All uses
3074 * dired.c (directory_files_internal, file_name_completion):
3075 Rename locals to avoid shadowing.
3077 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3078 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3079 dired.c's scmp function, had undefined behavior.
3080 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3081 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3082 * buffer.h: ... to here, because these macros use current_buffer,
3083 and the new implementation with inline functions needs to have
3084 current_buffer in scope now, rather than later when the macros
3086 (downcase, upcase1): New static inline functions.
3087 (DOWNCASE, UPCASE1): Reimplement using these functions.
3088 This avoids undefined behavior in expressions like
3089 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3090 from race conditions in accessing the global variables
3091 case_temp1 and case_temp2.
3092 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3093 * lisp.h (case_temp1, case_temp2): Remove their decls.
3094 * character.h (ASCII_CHAR_P): Move from here ...
3095 * lisp.h: ... to here, so that the inline functions mentioned
3098 * dired.c (directory_files_internal_unwind): Now static.
3100 * fileio.c (file_name_as_directory, directory_file_name):
3101 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3103 (file_name_as_directory): Use const pointers when appropriate.
3104 (Fexpand_file_name): Likewise. In particular, newdir might
3105 point at constant storage, so make it a const pointer.
3106 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
3107 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3109 (Fset_file_times, Finsert_file_contents, auto_save_error):
3110 Rename locals to avoid shadowing.
3112 * minibuf.c (choose_minibuf_frame_1): Now static.
3113 (Ftry_completion, Fall_completions): Rename or remove locals
3116 * marker.c (bytepos_to_charpos): Remove; unused.
3118 * lisp.h (verify_bytepos, count_markers): New decls,
3119 so that gcc does not warn that these functions aren't declared.
3121 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3122 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
3123 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
3124 (copy_text): Remove unused local var.
3126 * filelock.c (within_one_second): Now static.
3127 (lock_file_1): Rename local to avoid shadowing.
3129 * buffer.c (fix_overlays_before): Mark locals as initialized.
3130 (fix_start_end_in_overlays): Likewise. This function should be
3131 simplified by using pointers-to-pointers, but that's a different
3133 (switch_to_buffer_1): Now static.
3134 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3135 (report_overlay_modification): Rename locals to avoid shadowing.
3137 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
3138 Fix pointer signedness issue.
3139 (sys_subshell): Mark local as volatile if checking for lint,
3140 to suppress a gcc -Wclobbered warning that does not seem to be right.
3141 (MAXPATHLEN): Define only if needed.
3143 * process.c (serial_open, serial_configure): Move decls from here ...
3144 * systty.h: ... to here, so that they can be checked.
3146 * fns.c (get_random, seed_random): Move extern decls from here ...
3147 * lisp.h: ... to here, so that they can be checked.
3149 * sysdep.c (reset_io): Now static.
3150 (wait_for_termination_signal): Remove; unused.
3152 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3153 (copy_keymap_item, append_key, push_text_char_description):
3155 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
3156 (DENSE_TABLE_SIZE): Remove; unused.
3157 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3158 (describe_map_tree):
3159 Rename locals to avoid shadowing.
3161 * keyboard.c: Declare functions static if they are not used elsewhere.
3162 (echo_char, echo_dash, cmd_error, top_level_2):
3163 (poll_for_input, handle_async_input): Now static.
3164 (read_char, kbd_buffer_get_event, make_lispy_position):
3165 (make_lispy_event, make_lispy_movement, apply_modifiers):
3166 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3167 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3168 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
3169 (read_key_sequence, read_char): Mark locals as initialized.
3170 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
3172 * keyboard.h (make_ctrl_char): New decl.
3173 (mark_kboards): Move decl here ...
3174 * alloc.c (mark_kboards): ... from here.
3176 * lisp.h (force_auto_save_soon): New decl.
3178 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
3179 (DEFINE_DUMMY_FUNCTION): New macro.
3180 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3182 (main): Add casts to avoid warnings
3183 if GCC considers string literals to be constants.
3185 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3187 * dbusbind.c: Pointer signedness fixes.
3188 (xd_signature, xd_append_arg, xd_initialize):
3189 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3190 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3191 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3192 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3194 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3195 if GCC considers string literals to be constants.
3196 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
3198 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3200 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3201 (print_preprocess, print_object): New macro to fix last change.
3203 * print.c (print_preprocess): Don't forget font objects.
3205 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
3207 * emacs.c (USAGE3): Doc fixes.
3209 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3211 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3214 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
3216 * lisp.h (VWindow_system, Qfile_name_history):
3217 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3218 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3219 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3221 * w32select.c: Don't #include "keyboard.h".
3222 (run_protected): Add extern declaration for waiting_for_input.
3224 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3225 * w32console.c (detect_input_pending, read_input_pending)
3226 (encode_terminal_code):
3227 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3228 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3229 (w32_system_caret_y, Qfile_name_history):
3230 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3231 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3232 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3233 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3234 * w32proc.c (Qlocal, report_file_error):
3235 * w32term.c (Vwindow_system, updating_frame):
3236 * w32uniscribe.c (initialized, uniscribe_font_driver):
3237 Remove unneeded extern declarations.
3239 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
3241 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3243 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
3245 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3246 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3247 These macros can no longer be used for assignment.
3249 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3250 Assign struct members directly, instead of using BUF_BEGV etc.
3251 (record_buffer_markers, fetch_buffer_markers): New functions for
3252 recording and fetching special buffer markers.
3253 (set_buffer_internal_1, set_buffer_temp): Use them.
3255 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3257 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3259 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3260 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3262 * xdisp.c (hscroll_window_tree):
3263 (reconsider_clip_changes): Use PT instead of BUF_PT.
3265 2011-03-13 Eli Zaretskii <eliz@gnu.org>
3267 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3268 $(EMACS_ROOT)/lib/intprops.h.
3270 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3272 Fix more problems found by GCC 4.5.2's static checks.
3274 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3275 to unsigned char * to avoid compiler diagnostic.
3276 (xg_free_frame_widgets): Make it clear that a local variable is
3277 needed only if USE_GTK_TOOLTIP.
3278 (gdk_window_get_screen): Make it clear that this macro is needed
3279 only if USE_GTK_TOOLTIP.
3280 (int_gtk_range_get_value): New function, which avoids a diagnostic
3281 from gcc -Wbad-function-cast.
3282 (xg_set_toolkit_scroll_bar_thumb): Use it.
3283 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3284 diagnostic from gcc -Wbad-function-cast.
3285 (get_utf8_string, xg_get_file_with_chooser):
3286 Rename locals to avoid shadowing.
3287 (create_dialog): Move locals to avoid shadowing.
3289 * xgselect.c (xg_select): Remove unused var.
3291 * image.c (four_corners_best): Mark locals as initialized.
3292 (gif_load): Initialize transparent_p to zero (Bug#8238).
3293 Mark another local as initialized.
3294 (my_png_error, my_error_exit): Mark with NO_RETURN.
3296 * image.c (clear_image_cache): Now static.
3297 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
3298 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
3299 (x_edge_detection): Remove unnecessary cast that
3300 gcc -Wbad-function-cast diagnoses.
3301 (gif_load): Fix pointer signedness.
3302 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3303 (jpeg_load, gif_load): Rename locals to avoid shadowing.
3305 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3307 Improve quality of tests for time stamp overflow.
3308 For example, without this patch (encode-time 0 0 0 1 1
3309 1152921504606846976) returns the obviously-bogus value (-948597
3310 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3311 reports time overflow. See
3312 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
3313 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3314 * editfns.c: Include limits.h and intprops.h.
3315 (TIME_T_MIN, TIME_T_MAX): New macros.
3316 (time_overflow): Move earlier, to before first use.
3317 (hi_time, lo_time): New functions, for an accurate test for
3319 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3320 (Fget_internal_run_time): Don't assume time_t fits in int.
3321 (make_time): Use list2 instead of Fcons twice.
3322 (Fdecode_time): More accurate test for out-of-range times.
3323 (check_tm_member): New function.
3324 (Fencode_time): Use it, to test for out-of-range times.
3325 (lisp_time_argument): Don't rely on undefined left-shift and
3326 right-shift behavior when checking for time stamp overflow.
3328 * editfns.c (time_overflow): New function, refactoring common code.
3329 (Fformat_time_string, Fdecode_time, Fencode_time):
3330 (Fcurrent_time_string): Use it.
3332 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3333 * dired.c (make_time): Move to ...
3334 * editfns.c (make_time): ... here.
3335 * systime.h: Note the move.
3337 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3339 * fringe.c (update_window_fringes): Remove unused variables.
3341 * unexmacosx.c (copy_data_segment): Also copy __got section.
3344 2011-03-12 Eli Zaretskii <eliz@gnu.org>
3346 * termcap.c [MSDOS]: Include "msdos.h".
3347 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3348 Constify `char *' arguments and their references according to
3349 prototypes in tparam.h.
3351 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3353 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3354 Adapt all references accordingly.
3356 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3358 2011-03-11 Tom Tromey <tromey@redhat.com>
3360 * buffer.c (syms_of_buffer): Remove obsolete comment.
3362 2011-03-11 Eli Zaretskii <eliz@gnu.org>
3364 * termhooks.h (encode_terminal_code): Declare prototype.
3366 * msdos.c (encode_terminal_code): Don't declare prototype.
3368 * term.c (encode_terminal_code): Now external again, used by
3369 w32console.c and msdos.c.
3371 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3372 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3374 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3376 Fix some minor problems found by GCC 4.5.2's static checks.
3378 * fringe.c (update_window_fringes): Mark locals as initialized
3380 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3382 * alloc.c (mark_fringe_data): Move decl from here ...
3383 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3384 to check its interface.
3385 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3387 * fontset.c (free_realized_fontset): Now static.
3388 (Fset_fontset_font): Rename local to avoid shadowing.
3389 (fontset_font): Mark local as initialized.
3390 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3392 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3394 * xselect.c (x_disown_buffer_selections): Remove; not used.
3395 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3396 (x_own_selection, Fx_disown_selection_internal): Rename locals
3398 (x_handle_dnd_message): Remove local to avoid shadowing.
3400 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3401 so that the caller can use some name other than gcpro1.
3402 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3403 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3404 (Fx_backspace_delete_keys_p):
3405 Use them to avoid shadowing, and rename vars to avoid shadowing.
3406 (x_decode_color, x_set_name, x_window): Now static.
3407 (Fx_create_frame): Add braces to silence GCC warning.
3408 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3409 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3410 Remove unused locals.
3411 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3412 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3413 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3416 * xterm.h (x_mouse_leave): New decl.
3418 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3419 Remove unused functions.
3420 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3421 (x_calc_absolute_position): Now static.
3422 (XTread_socket): Don't define label "out" unless it's used.
3423 Don't declare local "event" unless it's used.
3424 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3425 unless they are used.
3426 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3427 (x_fatal_error_signal): Remove; not used.
3428 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3429 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3430 (x_error_catcher, x_connection_closed, x_error_handler):
3431 (x_error_quitter, xembed_send_message, x_iconify_frame):
3432 (my_log_handler): Rename locals to avoid shadowing.
3433 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3434 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3436 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3437 Rename or move locals to avoid shadowing.
3438 (tty_defined_color, merge_face_heights): Now static.
3439 (free_realized_faces_for_fontset): Remove; not used.
3440 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3441 does not deduce is never used uninitialized.
3442 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3443 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3445 * terminal.c (store_terminal_param): Now static.
3447 * xmenu.c (menu_highlight_callback): Now static.
3448 (set_frame_menubar): Remove unused local.
3449 (xmenu_show): Rename parameter to avoid shadowing.
3450 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3451 since they might point to immutable storage.
3452 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3453 since it's unused otherwise.
3455 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
3456 Add a FIXME, since the code still doesn't look right. (Bug#8215)
3457 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3458 avoids a gcc -Wuninitialized diagnostic.
3459 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
3460 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3461 does not deduce are never used uninitialized.
3463 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3465 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
3466 * window.c (window_loop, size_window):
3467 (run_window_configuration_change_hook, enlarge_window): Likewise.
3469 * window.c (display_buffer): Now static.
3470 (size_window): Mark variables that gcc -Wuninitialized
3471 does not deduce are never used uninitialized.
3472 * window.h (check_all_windows): New decl, to forestall
3473 gcc -Wmissing-prototypes diagnostic.
3474 * dispextern.h (bidi_dump_cached_states): Likewise.
3476 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3478 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
3480 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3481 and to avoid gcc -Wuninitialized warning.
3482 (load_charset_map): Mark variables that gcc -Wuninitialized
3483 does not deduce are never used uninitialized.
3484 (load_charset): Abort instead of using uninitialized var (Bug#8229).
3486 * coding.c (coding_set_source, coding_set_destination):
3487 Use "else { /* comment */ }" rather than "else /* comment */;"
3488 for clarity, and to avoid gcc -Wempty-body warning.
3489 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3490 a block, when the outer 'i' will do.
3491 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3492 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3493 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3494 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3495 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3496 Rename locals to avoid shadowing.
3497 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
3498 * coding.c (emacs_mule_char, encode_invocation_designation):
3499 Now static, since they're not used elsewhere.
3500 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
3501 (decode_coding_object, encode_coding_object, detect_coding_system):
3502 (decode_coding_emacs_mule): Mark variables that gcc
3503 -Wuninitialized does not deduce are never used uninitialized.
3504 (detect_coding_iso_2022): Initialize a local variable that might
3505 be used uninitialized. Leave a FIXME because it's not clear that
3506 this initialization is needed. (Bug#8211)
3507 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3508 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3509 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3510 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3511 Remove unused macros.
3513 * category.c (hash_get_category_set): Remove unused local var.
3514 (copy_category_table): Now static, since it's not used elsewhere.
3515 * character.c (string_count_byte8): Likewise.
3517 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3518 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3520 * chartab.c (copy_sub_char_table): Now static, since it's not used
3522 (sub_char_table_ref_and_range, char_table_ref_and_range):
3523 Rename locals to avoid shadowing.
3524 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
3526 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
3527 (BIDI_BOB): Remove unused macro.
3529 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3530 deduce are never used uninitialized.
3531 * term.c (encode_terminal_code): Likewise.
3533 * term.c (encode_terminal_code): Now static. Remove unused local.
3535 * tparam.h: New file.
3536 * term.c, tparam.h: Include it.
3537 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3538 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3539 Move these decls to tparam.h, and make them agree with what
3540 is actually in tparam.c. The previous trick of using incompatible
3541 decls in different modules does not conform to the C standard.
3542 All callers of tparam changed to use tparam's actual API.
3543 * tparam.c (tparam1, tparam, tgoto):
3544 Use const pointers where appropriate.
3546 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3547 * cm.h (struct cm): Likewise.
3548 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3549 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3550 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3551 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3552 (turn_on_face, init_tty): Likewise.
3553 * termchar.h (struct tty_display_info): Likewise.
3555 * term.c (term_mouse_position): Rename local to avoid shadowing.
3557 * alloc.c (mark_ttys): Move decl from here ...
3558 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3560 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3562 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3564 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
3566 * search.c (compile_pattern_1): Remove argument regp, unused since
3567 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3568 (compile_pattern): Don't pass it.
3570 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3572 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3573 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3575 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3577 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3579 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3580 gdk_window_get_screen, gdk_window_get_geometry,
3581 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3582 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3583 (xg_get_pixbuf_from_pixmap): New function.
3584 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3585 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3586 Call xg_get_pixbuf_from_pixmap instead of
3587 gdk_pixbuf_get_from_drawable.
3588 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3589 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3590 (xg_check_special_colors): Use GtkStyleContext and its functions
3592 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3593 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3594 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
3595 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3596 Call gtk_widget_get_preferred_size.
3597 (xg_frame_resized): gdk_window_get_geometry only takes 5
3599 (xg_win_to_widget, xg_event_is_for_menubar):
3600 Call gdk_x11_window_lookup_for_display.
3601 (xg_set_widget_bg): New function.
3602 (delete_cb): New function.
3603 (xg_create_frame_widgets): Connect delete-event to delete_cb.
3604 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3605 (xg_set_background_color): Call xg_set_widget_bg.
3606 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3607 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3608 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3609 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3611 (update_frame_tool_bar): Call gtk_widget_hide.
3612 (xg_initialize): Use GDK_KEY_g.
3614 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3616 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3618 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3619 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3620 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3622 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
3624 * w32xfns.c (select_palette): Check success of RealizePalette against
3625 GDI_ERROR, not zero.
3627 See ChangeLog.11 for earlier changes.
3633 Copyright (C) 2011 Free Software Foundation, Inc.
3635 This file is part of GNU Emacs.
3637 GNU Emacs is free software: you can redistribute it and/or modify
3638 it under the terms of the GNU General Public License as published by
3639 the Free Software Foundation, either version 3 of the License, or
3640 (at your option) any later version.
3642 GNU Emacs is distributed in the hope that it will be useful,
3643 but WITHOUT ANY WARRANTY; without even the implied warranty of
3644 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3645 GNU General Public License for more details.
3647 You should have received a copy of the GNU General Public License
3648 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.