1 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3 * xdisp.c (redisplay_window): Don't force window start if point
4 will be invisible in the resulting window. (Bug#9324)
6 2011-08-25 Eli Zaretskii <eliz@gnu.org>
8 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
9 the display spec is of the form `(space ...)'.
10 (handle_display_spec): Return the value returned by
11 handle_single_display_spec, not just 1 or zero.
12 (handle_single_display_spec): If the display spec is of the form
13 `(space ...)', and specifies display in the text area, return 2
15 (try_cursor_movement): Check for the need to scroll more
16 accurately, and prefer exact match for point under bidi. Don't
17 advance `row' beyond the last row of the window.
19 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
20 into disp_prop; all users changed.
22 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
23 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
24 for the text covered by the display property.
26 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
28 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
29 Change return value to nil.
30 (Frecord_buffer): Delete unused function.
32 2011-08-24 Eli Zaretskii <eliz@gnu.org>
34 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
35 buffers, return left-to-right.
36 (set_cursor_from_row): Consider candidate row a win if its glyph
37 represents a newline and point is on that newline. Fixes cursor
38 positioning on the newline at EOL of R2L text within L2R
39 paragraph, and vice versa.
40 (try_cursor_movement): Check continued rows, in addition to
41 continuation rows. Fixes unwarranted scroll when point enters a
42 continued line of R2L text within an L2R paragraph, or vice versa.
43 (cursor_row_p): Consider the case of point being equal to
44 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
45 from the end of a short line to the beginning of a continued line
46 of R2L text within L2R paragraph.
47 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
50 * bidi.c (bidi_check_type): Use xassert.
51 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
54 2011-08-23 Eli Zaretskii <eliz@gnu.org>
56 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
59 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
61 * nsfont.m (ns_otf_to_script): Fix typo.
63 2011-08-22 Kenichi Handa <handa@m17n.org>
65 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
66 extra slot even if the purpose is char-code-property-table.
68 2011-08-23 Eli Zaretskii <eliz@gnu.org>
70 * xdisp.c (redisplay_window): When computing centering_position,
71 account for the height of the header line. (Bug#8874)
73 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
74 instead of CHAR_TO_BYTE. Fixes a crash when a completion
75 candidate is selected by the mouse, and that candidate has a
76 composed character under the mouse.
78 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
79 coordinates reported by pos-visible-in-window-p for a composed
80 character in column zero.
82 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
84 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
86 2011-08-22 Eli Zaretskii <eliz@gnu.org>
88 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
89 consider it a hit if to_charpos is anywhere in the range of the
90 composed buffer positions.
92 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
94 * image.c (gif_load): Don't assume that each subimage has the same
95 dimensions as the base image. Handle disposal method that is
96 "undefined" by the gif spec (Bug#9335).
98 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
100 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
101 (Fcondition_case): Document `debug' symbol in error handler.
103 2011-08-19 Eli Zaretskii <eliz@gnu.org>
105 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
106 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
107 from an Org mode buffer to a Speedbar frame.
109 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
110 a composition, take its buffer position from IT->cmp_it.charpos.
111 Fixes cursor positioning at the beginning of a line that begins
112 with a composed character.
114 2011-08-18 Eli Zaretskii <eliz@gnu.org>
116 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
117 character bidirectional type, use STRONG_L instead. Fixes crashes
118 in a buffer produced by `describe-categories'.
120 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
121 members before the level stack, so they would be saved and
122 restored when copying iterator state. Fixes incorrect reordering
123 around TABs covered by display properties.
125 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
127 * process.c (Fnetwork_interface_list): Correctly determine buffer
130 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
132 * eval.c (internal_condition_case, internal_condition_case_1)
133 (internal_condition_case_2, internal_condition_case_n):
134 Remove unnecessary aborts (Bug#9081).
136 2011-08-17 Eli Zaretskii <eliz@gnu.org>
138 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
139 has no `load' handler, try opening the file locally. (Bug#9311)
141 2011-08-16 Ken Brown <kbrown@cornell.edu>
143 * gmalloc.c: Expand comment.
145 2011-08-16 Eli Zaretskii <eliz@gnu.org>
147 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
148 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
150 2011-08-16 Ken Brown <kbrown@cornell.edu>
152 Fix memory allocation problems in Cygwin build (Bug#9273).
154 * unexcw.c ( __malloc_initialized): Declare external variable.
155 (fixup_executable): Force the dumped emacs to reinitialize malloc.
157 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
159 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
161 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
163 [CYGWIN] (special_realloc): New function.
164 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
165 requests to realloc storage in the static heap.
167 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
169 * bidi.c (bidi_initialize): Remove unused local.
171 2011-08-15 Eli Zaretskii <eliz@gnu.org>
173 * biditype.h: File removed.
175 * bidimirror.h: File removed.
177 * deps.mk (bidi.o): Remove biditype.h and
180 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
183 * dispextern.h: Fix a typo in the comment to bidi_type_t.
185 * chartab.c: Improve commentary for the uniprop_table API.
187 * bidi.c (bidi_paragraph_init): Support zero value of
188 bidi_ignore_explicit_marks_for_paragraph_level.
189 (bidi_initialize): Use uniprop_table instead of including
190 biditype.h and bidimirror.h.
192 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
193 coordinates of the iterator when restoring from ppos_it.
196 2011-08-14 Kenichi Handa <handa@m17n.org>
198 * process.c (create_process): Call setup_process_coding_systems
199 after the pid of the process is set to -1 (Bug#8162).
201 2011-08-14 Eli Zaretskii <eliz@gnu.org>
203 * xdisp.c (move_it_in_display_line_to): Don't invoke
204 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
205 ppos_it. Fixes vertical cursor motion when line beginning is
206 covered by an image. (Bug#9296)
208 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
210 * nsterm.h (ns_run_ascript): Declare.
211 (NSAPP_DATA2_RUNASSCRIPT): Define.
213 * nsfns.m (as_script, as_result, as_status): New static variables.
214 (ns_run_ascript): New function.
215 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
216 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
217 the event loop. Get status from as_status (Bug#7276).
219 * nsterm.m (sendEvent): If event is NSApplicationDefined and
220 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
221 the event loop (Bug#7276).
223 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
225 * gnutls.c (QCgnutls_bootprop_priority)
226 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
227 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
228 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
229 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
230 (QCgnutls_bootprop_verify_hostname_error)
231 (QCgnutls_bootprop_callbacks_verify): Rename from
232 Qgnutls_bootprop_..., all uses changed.
234 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
237 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
239 * xfaces.c (Qframe_set_background_mode): Now static.
240 * dispextern.h (Qframe_set_background_mode): Remove decl.
242 * process.c (Fnetwork_interface_info): Declare local only if needed.
244 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
246 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
247 (Fnetwork_interface_list): Allocate in increments of bytes instead
248 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
249 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
251 (struct ifflag_def): notrailers is smart on OSX.
252 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
253 Get hardware address with getifaddrs if available.
255 2011-08-12 Eli Zaretskii <eliz@gnu.org>
257 * xdisp.c (iterate_out_of_display_property): xassert that
258 IT->position is set to within IT->object's boundaries. Break from
259 the loop as soon as EOB is reached; avoids infloops in redisplay
260 when IT->position is set up wrongly due to some bug.
261 Set IT->current to match the bidi iterator unconditionally.
262 (push_display_prop): Allow GET_FROM_STRING as IT->method on
263 entry. Force push_it to save on the stack the current
264 buffer/string position, to be restored by pop_it. Fix flags in
265 the iterator structure wrt the object coming from a display
266 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
267 properties. (Bug#9284)
269 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
271 * fontset.c (fontset_get_font_group): Add proper type checks.
274 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
276 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
277 and LC_VERSION_MIN_MACOSX.
278 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
279 (dump_it) [LC_FUNCTION_STARTS]: Use it.
281 2011-08-08 Eli Zaretskii <eliz@gnu.org>
283 * xdisp.c (forward_to_next_line_start): Allow to use the
284 no-display-properties-and-no-overlays under bidi display.
285 Set disp_pos in the bidi iterator to avoid searches for display
286 properties and overlays.
288 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
290 * editfns.c (Fset_time_zone_rule): Document relationship with the
293 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
294 the font entity extracted from the cache (Bug#8109).
296 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
298 * composite.c (autocmp_chars): Don't reset point. That is done by
299 restore_point_unwind (Bug#5984).
301 2011-08-07 Juri Linkov <juri@jurta.org>
303 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
304 to show the arg `TIME' instead of `TIMEVAL'.
306 2011-08-06 Eli Zaretskii <eliz@gnu.org>
308 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
309 display property strides EOL and includes a newline, as in
310 longlines-mode. (Bug#9254)
311 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
312 word-wrap under bidirectional display. (Bug#9224)
314 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
315 is non-zero, even if the data buffer is NULL. Fixes a crash in
316 vertical-motion with longlines-mode. (Bug#9254)
318 2011-08-05 Eli Zaretskii <eliz@gnu.org>
320 * bidi.c <bidi_cache_total_alloc>: Now static.
321 (bidi_initialize): Initialize bidi_cache_total_alloc.
323 * xdisp.c (display_line): Release buffer allocated for shelved bidi
326 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
327 amount allocated this far in `bidi_cache_total_alloc'.
328 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
329 non-zero, only free the data buffer without restoring the cache
330 contents. All callers changed.
332 * dispextern.h (bidi_unshelve_cache): Update prototype.
334 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
335 (move_it_in_display_line, move_it_to)
336 (move_it_vertically_backward, move_it_by_lines): Replace the call
337 to xfree to an equivalent call to bidi_unshelve_cache.
338 (move_it_in_display_line_to): Fix logic of returning
339 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
341 2011-08-05 Eli Zaretskii <eliz@gnu.org>
343 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
344 came from a string character with a `cursor' property. (Bug#9229)
346 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
348 * Makefile.in (LIB_PTHREAD): New variable.
349 (LIBES): Add LIB_PTHREAD (Bug#9216).
351 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
352 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
354 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
356 * regex.c (re_iswctype): Remove some redundant boolean
359 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
361 * xterm.c (x_find_topmost_parent): New function.
362 (x_set_frame_alpha): Find topmost parent window with
363 x_find_topmost_parent and set the property there also (bug#9181).
364 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
366 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
368 * callproc.c (Fcall_process): Avoid vfork clobbering
369 the local vars buffer, coding_systems, current_dir.
371 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
373 * keymap.c (Fmake_composed_keymap): Move to subr.el.
375 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
377 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
378 so that it is not optimized away.
380 * xdisp.c (compute_display_string_pos): Remove unused local.
382 2011-08-02 Eli Zaretskii <eliz@gnu.org>
384 Fix slow cursor motion and scrolling in large buffers with
385 selective display, like Org Mode buffers. (Bug#9218)
387 * dispextern.h (struct bidi_it): New member disp_prop_p.
389 * xdisp.c: Remove one-slot cache of display string positions.
390 (compute_display_string_pos): Accept an additional argument
391 DISP_PROP_P; callers changed. Scan at most 5K characters forward
392 for a display string or property. If found, set DISP_PROP_P
395 * bidi.c (bidi_fetch_char): Accept an additional argument
396 DISP_PROP_P, and pass it to compute_display_string_pos.
397 Only handle text covered by a display string if DISP_PROP_P is returned
398 non-zero. All callers of bidi_fetch_char changed.
400 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
402 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
404 2010-12-03 Don March <don@ohspite.net>
406 * keymap.c (Fdefine_key): Fix non-prefix key error message when
407 last character M-[char] is translated to ESC [char] (bug#7541).
409 2011-08-02 Kenichi Handa <handa@m17n.org>
411 * lisp.h (uniprop_table): Extern it.
413 * chartab.c (uniprop_table): Make it non-static.
415 2011-08-01 Eli Zaretskii <eliz@gnu.org>
417 * xdisp.c (forward_to_next_line_start): Accept additional argument
418 BIDI_IT_PREV, and store into it the state of the bidi iterator had
420 (reseat_at_next_visible_line_start): Use the bidi iterator state
421 returned by forward_to_next_line_start to restore the state of
422 it->bidi_it after backing up to previous newline. (Bug#9212)
424 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
426 * regex.c (re_comp): Protoize.
427 (re_exec): Fix return type.
428 (regexec): Fix type of `ret'. (Bug#9203)
430 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
432 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
433 This is needed if max-image-size is a floating-point number.
435 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
437 * print.c (print_object): Print empty symbol as ##.
439 * lread.c (read1): Read ## as empty symbol.
441 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
443 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
444 setting frame foreground color (Bug#9175).
445 (x_set_background_color): Likewise.
447 * nsmenu.m (-setText): Size tooltip dimensions precisely to
449 (EmacsTooltip -init): Remove bezels and add shadows to
452 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
453 or scroll bar (Bug#8470).
455 * nsfont.m (nsfont_open): Remove assignment to voffset and
456 unnecessary vars hshink, expand, hd, full_height, min_height.
457 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
459 * nsterm.h (nsfont_info): Remove voffset field.
461 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
463 Implement strike-through and overline on NextStep (Bug#8863).
465 * nsfont.m (nsfont_open): Use underline position provided by font,
466 instead of hard-coded value of 2.
467 (nsfont_draw): Call ns_draw_text_decoration instead.
469 * nsterm.h: Add declaration for ns_draw_text_decoration.
471 * nsterm.m (ns_draw_text_decoration): New function for drawing
472 underline, overline, and strike-through.
473 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
474 ns_draw_text_decoration. Change treatment of cursor drawing to
475 accomodate underlining, etc.
477 2011-07-28 Eli Zaretskii <eliz@gnu.org>
479 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
482 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
484 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
485 Without this fix, if a signal arrives just after memory fills up,
486 'malloc' might be invoked reentrantly.
488 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
489 In other words, assume that every image size is allowed, on non-X
490 hosts. This assumption is probably wrong, but it lets Emacs compile.
492 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
494 * regex.c (re_iswctype): Convert return values to boolean.
496 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
498 * xdisp.c (compute_display_string_pos): Don't use cached display
499 string position if the buffer had its restriction changed.
502 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
504 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
506 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
508 Integer signedness and overflow and related fixes. (Bug#9079)
510 * bidi.c: Integer size and overflow fixes.
511 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
512 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
513 (bidi_cache_find_level_change, bidi_cache_ensure_space)
514 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
515 (bidi_find_other_level_edge):
516 Use ptrdiff_t instead of EMACS_INT where either will do.
517 This works better on 32-bit hosts configured --with-wide-int.
518 (bidi_cache_ensure_space): Check for size-calculation overflow.
519 Use % rather than repeated addition, for better worst-case speed.
520 Don't set bidi_cache_size until after xrealloc returns, because it
522 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
523 (bidi_cache_ensure_space): Also check that the bidi cache size
524 does not exceed that of the largest Lisp string or buffer. See Eli
525 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
527 * alloc.c (__malloc_size_t): Remove.
528 All uses replaced by size_t. See Andreas Schwab's note
529 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
531 * image.c: Improve checking for integer overflow.
532 (check_image_size): Assume that f is nonnull, since
533 it is always nonnull in practice. This is one less thing to
534 worry about when checking for integer overflow later.
535 (x_check_image_size): New function, which checks for integer
536 overflow issues inside X.
537 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
538 This removes the need for a memory_full check.
539 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
540 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
541 (xbm_read_bitmap_data): Change locals back to 'int', since
542 their values must fit in 'int'.
543 (xpm_load_image, png_load, tiff_load):
544 Invoke x_create_x_image_and_pixmap earlier,
545 to avoid much needless work if the image is too large.
546 (tiff_load): Treat overly large images as if
547 x_create_x_image_and_pixmap failed, not as malloc failures.
548 (gs_load): Use x_check_image_size.
550 * gtkutil.c: Omit integer casts.
551 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
552 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
554 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
556 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
557 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
558 would wrongly return t on a 64-bit host.
560 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
561 The plain *_OVERFLOW macros run afoul of GCC bug 49705
562 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
563 and therefore cause GCC to emit a bogus diagnostic in some cases.
565 * image.c: Integer signedness and overflow and related fixes.
566 This is not an exhaustive set of fixes, but it's time to
567 record what I've got.
568 (lookup_pixel_color, check_image_size): Remove redundant decls.
569 (check_image_size): Don't assume that arbitrary EMACS_INT values
570 fit in 'int', or that arbitrary 'double' values fit in 'int'.
571 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
572 (tiff_load, imagemagick_load_image):
573 Check for overflow in size calculations.
574 (x_create_x_image_and_pixmap): Remove unnecessary test for
575 xmalloc returning NULL; that can't happen.
576 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
577 (xpm_color_bucket): Use better integer hashing function.
578 (xpm_cache_color): Don't possibly over-allocate memory.
579 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
581 Use ptrdiff_t, not int or size_t, to record sizes.
582 (png_load): Don't assume values greater than 2**31 fit in 'int'.
583 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
584 either works, as we prefer signed integers.
585 (tiff_read_from_memory, tiff_write_from_memory):
586 Return tsize_t, not size_t, since that's what the TIFF API wants.
587 (tiff_read_from_memory): Don't fail simply because the read would
588 go past EOF; instead, return a short read.
589 (tiff_load): Omit no-longer-needed casts.
590 (Fimagemagick_types): Don't assume size fits into 'int'.
592 Improve hashing quality when configured --with-wide-int.
593 * fns.c (hash_string): New function, taken from sxhash_string.
594 Do not discard information about ASCII character case; this
595 discarding is no longer needed.
596 (sxhash-string): Use it. Change sig to match it. Caller changed.
597 * lisp.h: Declare it.
598 * lread.c (hash_string): Remove, since we now use fns.c's version.
599 The fns.c version returns a wider integer if --with-wide-int is
600 specified, so this should help the quality of the hashing a bit.
602 * emacs.c: Integer overflow minor fix.
603 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
604 Define only if GNU_LINUX.
605 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
607 * dispnew.c: Integer signedness and overflow fixes.
608 Remove unnecessary forward decls, that were a maintenance hassle.
609 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
611 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
612 (scrolling_window): Use ptrdiff_t, not int, for byte count.
613 (prepare_desired_row, line_draw_cost):
614 Use int, not unsigned, where either works.
615 (save_current_matrix, restore_current_matrix):
616 Use ptrdiff_t, not size_t, where either works.
617 (init_display): Check for overflow more accurately, and without
618 relying on undefined behavior.
620 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
621 Remove, replacing with the new symbols in lisp.h. All uses changed.
622 * fileio.c (make_temp_name):
623 * filelock.c (lock_file_1, lock_file):
624 * xdisp.c (message_dolog):
625 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
626 Use pMd etc. instead.
627 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
628 replacing the pWIDE etc. symbols removed from editfns.c.
630 * keyboard.h (num_input_events): Now uintmax_t.
631 This is (very slightly) less likely to mess up due to wraparound.
634 * buffer.c: Integer signedness fixes.
635 (alloc_buffer_text, enlarge_buffer_text):
636 Use ptrdiff_t rather than size_t when either will do, as we prefer
639 * alloc.c: Integer signedness and overflow fixes.
640 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
641 (__malloc_size_t): Default to size_t, not to int.
642 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
643 (Fgarbage_collect, mark_object_loop_halt, mark_object):
644 Prefer ptrdiff_t to size_t when either would do, as we prefer
646 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
647 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
648 Now const. Initialize with values that are in range even if char
650 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
651 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
652 These functions do the right thing with sizes > 2**32.
653 (check_depth): Now ptrdiff_t, not int.
654 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
655 Adjust to new way of storing sizes. Check for size overflow bugs
657 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
658 slightly wrong anyway, as it missed one instance of
659 XMALLOC_OVERRUN_CHECK_OVERHEAD.
660 (refill_memory_reserve): Omit needless cast to size_t.
661 (mark_object_loop_halt): Mark as externally visible.
663 * xselect.c: Integer signedness and overflow fixes.
664 (Fx_register_dnd_atom, x_handle_dnd_message):
665 Use ptrdiff_t, not size_t, since we prefer signed.
666 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
667 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
668 x_dnd_atoms_size and x_dnd_atoms_length.
670 * doprnt.c: Prefer signed to unsigned when either works.
674 * xdisp.c (vmessage):
675 Use ptrdiff_t, not size_t, when using or implementing doprnt,
676 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
677 prefer signed arithmetic to avoid comparison confusion.
678 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
681 Assume freestanding C89 headers, string.h, stdlib.h.
682 * data.c, doprnt.c, floatfns.c, print.c:
683 Include float.h unconditionally.
684 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
685 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
686 * regex.c: Likewise for stddef.h, string.h.
687 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
688 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
689 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
690 (STDC_HEADERS): Remove obsolete defines.
691 * sysdep.c: Include limits.h unconditionally.
693 Assume support for memcmp, memcpy, memmove, memset.
694 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
695 * regex.c (memcmp, memcpy):
696 Remove; we assume C89 now.
698 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
699 (__malloc_safe_bcopy): Remove; no longer needed.
701 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
702 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
703 well either way, and we prefer signed to unsigned.
705 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
707 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
708 closes the connection while we're reading (bug#9182).
710 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
712 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
713 are specified (Bug#9168).
715 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
717 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
718 Found by GCC static checking and --with-wide-int on a 32-bit host.
720 2011-07-25 Eli Zaretskii <eliz@gnu.org>
722 * xdisp.c (compute_display_string_pos): Fix logic of caching
723 previous display string position. Initialize cached_prev_pos to
724 -1. Fixes slow-down at the beginning of a buffer.
726 2011-07-24 Eli Zaretskii <eliz@gnu.org>
728 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
729 for attrs[LFACE_FONTSET_INDEX].
731 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
733 * xml.c (parse_region): Remove unused local
734 that was recently introduced.
736 2011-07-23 Eli Zaretskii <eliz@gnu.org>
738 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
739 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
741 * xdisp.c (move_it_in_display_line_to): Record the best matching
742 position for TO_CHARPOS while scanning the line, and restore it on
743 exit if none of the characters scanned was an exact match.
744 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
745 when exact match is impossible due to invisible text, and the
748 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
750 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
753 2011-07-22 Eli Zaretskii <eliz@gnu.org>
755 Fix a significant slow-down of cursor motion with C-n, C-p,
756 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
757 auto-repeat under bidi redisplay in fontified buffers.
758 * xdisp.c (compute_stop_pos_backwards): New function.
759 (next_element_from_buffer): Call compute_stop_pos_backwards to
760 find a suitable prev_stop when we find ourselves before
762 (reseat): Don't look for prev_stop, as that could mean a very long
764 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
765 <cached_disp_overlay_modiff>: Cache for last found display string
767 (compute_display_string_pos): Return the cached position if asked
768 about the same buffer in the same area of character positions, and
769 the buffer wasn't changed since the time the display string
772 2011-07-22 Eli Zaretskii <eliz@gnu.org>
774 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
775 is an integer, which is important for empty lines. (Bug#9149)
777 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
779 * frame.c (Fmodify_frame_parameters): In tty case, update the
780 default face if necessary (Bug#4238).
782 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
784 * editfns.c (Fstring_to_char): No need to explain what a character
785 is in the docstring (Bug#6576).
787 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
789 * xml.c (parse_region): Make sure we always return a tree.
791 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
793 * xml.c (parse_region): If a document contains only comments,
796 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
798 * xml.c (make_dom): Return comments, too.
800 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
803 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
804 and the surrounding thread.
805 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
806 rather than fgets, and retry after EINTR. Otherwise, 'emacs
807 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
809 * s/openbsd.h (BROKEN_SIGIO): Define.
810 * unexelf.c (unexec) [__OpenBSD__]:
811 Don't update the .mdebug section of the Alpha COFF symbol table.
813 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
815 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
818 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
820 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
821 This fixes some race conditions on the permissions of any newly
824 * alloc.c (valid_pointer_p): Use pipe, not open.
825 This fixes some permissions issues when debugging.
827 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
828 If fchown fails to set both uid and gid, try to set just gid,
829 as that is sometimes allowed. Adjust the file's mode to eliminate
830 setuid or setgid bits that are inappropriate if fchown fails.
832 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
834 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
835 to compare Lisp_Objects.
836 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
837 global_gnutls_log_level, don't mistake it for a Lisp_Object.
838 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
840 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
842 * lread.c (read_integer): Unread even EOF character.
843 (read1): Likewise. Properly record start position of symbol.
845 * lread.c (read1): Read `#:' as empty uninterned symbol if no
846 symbol character follows.
848 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
850 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
851 This works around a problem with the previous change to Fcopy_file.
852 Recent glibc declares fchown with __attribute__((warn_unused_result)),
853 and without this change, GCC might complain about discarding
854 fchown's return value.
856 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
858 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
860 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
862 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
864 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
866 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
867 it's used from the C level.
869 * process.c: Use the same condition for POLL_FOR_INPUT in both
870 keyboard.c and process.c (bug#1858).
872 2011-07-09 Lawrence Mitchell <wence@gmx.li>
874 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
875 (Fgnutls_boot): Use it.
877 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
879 * doc.c (Fsubstitute_command_keys): Revert last change.
881 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
883 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
884 quotes the next character, and doesn't affect other longer
885 sequences (bug#8935).
887 * lread.c (syms_of_lread): Clarify that is isn't only
888 `eval-buffer' and `eval-defun' that's affected by
889 `lexical-binding' (bug#8460).
891 2011-07-15 Eli Zaretskii <eliz@gnu.org>
893 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
894 bidi redisplay when a line includes both an image and is
897 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
899 Fix minor problems found by static checking.
900 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
901 (elsz): Now a signed constant, not a size_t var. We prefer signed
902 types to unsigned, to avoid integer comparison confusion. Without
903 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
904 "cannot optimize loop, the loop counter may overflow", a symptom
906 * indent.c (Fvertical_motion): Mark locals as initialized.
907 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
909 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
911 * search.c (Fre_search_backward): Mention `case-fold-search' in
912 all the re_search_* functions (bug#8138).
914 * keyboard.c (Fopen_dribble_file): Document when the file is
917 2011-07-14 Eli Zaretskii <eliz@gnu.org>
919 * bidi.c (bidi_dump_cached_states): Fix format of displaying
922 Support bidi reordering of display and overlay strings.
923 * xdisp.c (compute_display_string_pos)
924 (compute_display_string_end): Accept additional argument STRING.
925 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
926 (reseat_to_string): Initialize bidi_it->string.s and
927 bidi_it->string.schars.
928 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
929 NULL (avoids a crash in bidi_paragraph_init).
930 Initialize itb.string.lstring.
931 (init_iterator): Call bidi_init_it only of a valid
932 buffer position was specified. Initialize paragraph_embedding to
934 (reseat_to_string): Initialize the bidi iterator.
935 (display_string): If we need to ignore text properties of
936 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
937 original value of -1 will not work with bidi.)
938 (compute_display_string_pos): First arg is now struct
939 `text_pos *'; all callers changed. Support display properties on
941 (compute_display_string_end): Support display properties on Lisp
943 (init_iterator, reseat_1, reseat_to_string): Initialize the
944 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
945 when iterating on a string not from display properties).
946 (compute_display_string_pos, compute_display_string_end):
947 Fix calculation of the object to scan. Fixes an error when using
949 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
950 base_level_stop; instead, set base_level_stop to BEGV.
951 Fixes crashes in vertical-motion.
952 (next_element_from_buffer): Improve commentary for when
953 the iterator is before prev_stop.
954 (init_iterator): Initialize bidi_p from the default value of
955 bidi-display-reordering, not from buffer-local value. Use the
956 buffer-local value only if initializing for buffer iteration.
957 (handle_invisible_prop): Support invisible properties on strings
958 that are being bidi-reordered.
959 (set_iterator_to_next): Support bidi reordering of C strings and
961 (next_element_from_string): Support bidi reordering of Lisp
963 (handle_stop_backwards): Support Lisp strings as well.
964 (display_string): Support display of R2L glyph rows.
965 Use IT_STRING_CHARPOS when displaying from a Lisp string.
966 (init_iterator): Don't initialize it->bidi_p for strings
968 (reseat_to_string): Initialize it->bidi_p for strings here.
969 (next_element_from_string, next_element_from_c_string)
970 (next_element_from_buffer): Add xassert's for correspondence
971 between IT's object being iterated and it->bidi_it.string
973 (face_before_or_after_it_pos): Support bidi iteration.
974 (next_element_from_c_string): Handle the case of the first string
975 character that is not the first one in the visual order.
976 (get_visually_first_element): New function, refactored from common
977 parts of next_element_from_buffer, next_element_from_string, and
978 next_element_from_c_string.
979 (tool_bar_lines_needed, redisplay_tool_bar)
980 (display_menu_bar): Force left-to-right direction. Add a FIXME
981 comment for making that be controlled by a user option.
982 (push_it, pop_it): Save and restore the state of the
983 bidi iterator. Save and restore the bidi_p flag.
984 (pop_it): Iterate out of display property for string iteration as
986 (iterate_out_of_display_property): Support iteration over strings.
987 (handle_single_display_spec): Set up it->bidi_it for iteration
988 over a display string, and call bidi_init_it.
989 (handle_single_display_spec, next_overlay_string)
990 (get_overlay_strings_1, push_display_prop): Set up the bidi
991 iterator for displaying display or overlay strings.
992 (forward_to_next_line_start): Don't use the shortcut if
994 (back_to_previous_visible_line_start): If handle_display_prop
995 pushed the iterator stack, restore the internal state of the bidi
996 iterator by calling bidi_pop_it same number of times.
997 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
998 and we are bidi-iterating, don't decrement the iterator position;
999 instead, set the first_elt flag in the bidi iterator, to produce
1001 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1002 (push_display_prop): xassert that we are iterating a buffer.
1003 (push_it, pop_it): Save and restore paragraph_embedding member.
1004 (handle_single_display_spec, next_overlay_string)
1005 (get_overlay_strings_1, reseat_1, reseat_to_string)
1006 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1007 correctly. Don't assume unibyte strings are not bidi-reordered.
1008 (compute_display_string_pos)
1009 (compute_display_string_end): Fix handling the case of C string.
1010 (push_it, pop_it): Save and restore from_disp_prop_p.
1011 (handle_single_display_spec, push_display_prop): Set the
1012 from_disp_prop_p flag.
1013 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1014 (pop_it): Call iterate_out_of_display_property only if we are
1015 popping after iteration over a string that came from a display
1016 property. Fix a typo in popping stretch info. Add an assertion
1017 for verifying that the iterator position is in sync with the bidi
1019 (handle_single_display_spec, get_overlay_strings_1)
1020 (push_display_prop): Fix initialization of paragraph direction for
1021 string when that of the parent object is not yet determined.
1022 (reseat_1): Call bidi_init_it to resync the bidi
1023 iterator with IT's position. (Bug#7616)
1024 (find_row_edges): If ROW->start.pos gives position
1025 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1026 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1027 Reset the from_disp_prop_p flag.
1028 (SAVE_IT, RESTORE_IT): New macros.
1029 (pos_visible_p, face_before_or_after_it_pos)
1030 (back_to_previous_visible_line_start)
1031 (move_it_in_display_line_to, move_it_in_display_line)
1032 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1033 (try_scrolling, redisplay_window, display_line): Use them when
1034 saving a temporary copy of the iterator and restoring it back.
1035 (back_to_previous_visible_line_start, reseat_1)
1036 (init_iterator): Empty the bidi cache "stack".
1037 (move_it_in_display_line_to): If iterator ended up at
1038 EOL, but we never saw any buffer positions smaller than
1039 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1040 motion in bidi-reordered lines.
1041 (move_it_in_display_line_to): Record prev_method and prev_pos
1042 immediately before the call to set_iterator_to_next. Fixes cursor
1043 motion in bidi-reordered lines with stretch glyphs and strings
1044 displayed in margins. (Bug#8133) (Bug#8867)
1045 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1047 (pos_visible_p): Support positions in bidi-reordered lines.
1048 Save and restore bidi cache.
1050 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1051 (bidi_paragraph_info): Delete unused struct.
1052 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1053 (bidi_cache_start): New variable.
1054 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1056 (bidi_cache_fetch_state, bidi_cache_search)
1057 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1058 (bidi_cache_find, bidi_peek_at_next_level)
1059 (bidi_level_of_next_char, bidi_find_other_level_edge)
1060 (bidi_move_to_visually_next): Compare cache index with
1061 bidi_cache_start rather than with zero.
1062 (bidi_fetch_char): Accept new argument STRING; all callers
1063 changed. Support iteration over a string. Support strings with
1064 display properties. Support unibyte strings. Fix the type of
1065 `len' according to what STRING_CHAR_AND_LENGTH expects.
1066 (bidi_paragraph_init, bidi_resolve_explicit_1)
1067 (bidi_resolve_explicit, bidi_resolve_weak)
1068 (bidi_level_of_next_char, bidi_move_to_visually_next):
1069 Support iteration over a string.
1070 (bidi_set_sor_type, bidi_resolve_explicit_1)
1071 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1072 can now be zero (for strings); special values 0 and -1 were
1073 changed to -1 and -2, respectively.
1074 (bidi_char_at_pos): New function.
1075 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1076 Call it instead of FETCH_MULTIBYTE_CHAR.
1077 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1078 initialized to valid values.
1079 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1081 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1082 the test for valid cached positions. Fix the logic for looking up
1083 the sentinel state in the cache. GCPRO the Lisp string we are
1085 (bidi_push_it, bidi_pop_it): New functions.
1086 (bidi_initialize): Initialize the bidi cache start stack pointer.
1087 (bidi_cache_ensure_space): New function, refactored from part of
1088 bidi_cache_iterator_state. Don't assume the required size is just
1089 one BIDI_CACHE_CHUNK away.
1090 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1091 (bidi_count_bytes, bidi_char_at_pos): New functions.
1092 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1093 always valid if bidi_cache_idx is valid.
1094 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1095 is valid if it's going to be used.
1096 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1097 (bidi_cache_fetch_state, bidi_cache_search)
1098 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1099 (bidi_cache_iterator_state, bidi_cache_find)
1100 (bidi_find_other_level_edge, bidi_cache_start_stack):
1101 All variables related to cache indices are now EMACS_INT.
1103 * dispextern.h (struct bidi_string_data): New structure.
1104 (struct bidi_it): New member `string'. Make flag members be 1-bit
1105 fields, and put them last in the struct.
1106 (compute_display_string_pos, compute_display_string_end):
1108 (bidi_push_it, bidi_pop_it): Add prototypes.
1109 (struct iterator_stack_entry): New members bidi_p,
1110 paragraph_embedding, and from_disp_prop_p.
1111 (struct it): Member bidi_p is now a bit field 1 bit wide.
1112 (bidi_shelve_cache, bidi_unshelve_cache):
1115 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1116 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1117 and vector-like objects.
1119 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1120 cache around display iteration.
1122 * window.c (Fwindow_end, window_scroll_pixel_based)
1123 (displayed_window_lines, Frecenter): Save and restore the bidi
1124 cache around display iteration.
1126 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1128 * editfns.c (Fdelete_region): Clarify the use of the named
1129 parameters (bug#6788).
1131 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1133 * indent.c (Fvertical_motion): Set and restore w->pointm when
1134 saving and restoring the window's buffer (Bug#9006).
1136 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1138 * editfns.c (Fstring_to_char): Clarify just what is returned
1139 (bug#6576). Text by Eli Zaretskii.
1141 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1143 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1145 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1147 * buffer.c (mmap_find): Fix a typo.
1149 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1151 Fix execution of x selection hooks.
1152 * xselect.c (Qx_lost_selection_functions)
1153 (Qx_sent_selection_functions): New vars.
1154 (syms_of_xselect): DEFSYM them.
1155 (x_handle_selection_request): Pass Qx_sent_selection_functions
1156 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1157 (x_handle_selection_clear,x_clear_frame_selections):
1158 Pass Qx_lost_selection_functions rather than
1159 Vx_lost_selection_functions to Frun_hook_with_args.
1161 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1163 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1164 The old code sometimes used this field without initializing it.
1166 * alloc.c (gc_sweep): Don't read past end of array.
1167 In theory, the old code could also have corrupted Emacs internals,
1168 though it'd be very unlikely.
1170 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1172 * character.c (Fcharacterp): Don't advertise optional ignored
1173 argument. (Bug#4026)
1175 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1177 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1180 * window.c (Fset_window_start): Doc fix (bug#4199).
1181 (Fset_window_hscroll): Ditto.
1183 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1185 Fix minor new problems caught by GCC 4.6.1.
1186 * term.c (init_tty): Remove unused local.
1187 * xsettings.c (store_monospaced_changed): Define this function only
1188 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1191 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1193 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1195 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1197 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1198 are the mini-buffer and the echo area (bug#3320).
1200 * term.c (init_tty): Remove support for supdup, c10 and perq
1201 terminals, which are no longer supported (bug#1482).
1203 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1205 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1207 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1209 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1210 for non-popups (Bug#3642).
1212 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1214 * alloc.c (reset_malloc_hooks): Protoize.
1215 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1216 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1217 * cm.c (losecursor): Likewise.
1218 * data.c (fmod): Likewise.
1219 * dispnew.c (swap_glyphs_in_rows): Likewise.
1220 * emacs.c (memory_warning_signal): Likewise.
1221 * floatfns.c (float_error): Likewise.
1222 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1223 (otf_open, font_otf_capability, generate_otf_features)
1224 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1226 * image.c (pbm_read_file): Likewise.
1227 * indent.c (string_display_width): Likewise.
1228 * intervals.c (check_for_interval, search_for_interval)
1229 (inc_interval_count, count_intervals, root_interval)
1230 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1231 * lread.c (defalias): Likewise.
1232 * ralloc.c (r_alloc_check): Likewise.
1233 * regex.c (set_image_of_range_1, set_image_of_range)
1234 (regex_grow_registers): Likewise.
1235 * sysdep.c (strerror): Likewise.
1236 * termcap.c (valid_filename_p, tprint, main): Likewise.
1237 * tparam.c (main): Likewise.
1238 * unexhp9k800.c (run_time_remap, save_data_space)
1239 (update_file_ptrs, read_header, write_header, calculate_checksum)
1240 (copy_file, copy_rest, display_header): Likewise.
1241 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1243 * xdisp.c (check_it): Likewise.
1244 * xfaces.c (register_color, unregister_color, unregister_colors):
1246 * xfns.c (print_fontset_result): Likewise.
1247 * xrdb.c (member, fatal, main): Likewise.
1249 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1251 Fix minor problems found by static checking (Bug#9031).
1252 * chartab.c (char_table_set_range, map_sub_char_table):
1253 Remove unused locals.
1254 (uniprop_table): Now static.
1255 * composite.c (_work_char): Remove unused static var.
1257 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1259 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1261 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1263 * gtkutil.c (qttip_cb): Remove code without function.
1265 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1267 * w32.c (pthread_sigmask): New stub.
1269 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1271 Use pthread_sigmask, not sigprocmask (Bug#9010).
1272 sigprocmask is portable only for single-threaded applications, and
1273 Emacs can be multi-threaded when it uses GTK.
1274 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1276 * callproc.c (Fcall_process):
1277 * process.c (create_process):
1278 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1279 Use pthread_sigmask, not sigprocmask.
1281 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1283 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1284 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1287 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1289 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1290 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1291 (xg_hide_tooltip): Fix comment.
1293 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1294 in registerServicesMenuSendTypes.
1295 (validRequestorForSendType): Don't check ns_return_types.
1297 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1300 2011-07-08 Jason Rumney <jasonr@gnu.org>
1302 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1303 frame struct members of non-existent frames (Bug#6284).
1305 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1307 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1308 variable firstTime not needed on OSX >= 10.6.
1309 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1310 >= 10.5. Use setKnobProportion, setDoubleValue.
1312 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1313 (MAC_OS_X_VERSION_10_5): Define if not defined.
1314 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1315 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1316 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1318 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1319 cString and lossyCString on OSX >= 10.4
1321 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1322 sizeToFit on OSX >= 10.2.
1324 * nsimage.m (allocInitFromFile): Don't use deprecated method
1325 bestRepresentationForDevice on OSX >= 10.6.
1327 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1330 * emacs.c: Declare unexec_init_emacs_zone.
1332 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1334 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1336 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1337 on svcsMenu (Bug#8842).
1339 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1341 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1343 * nsterm.m (QUTF8_STRING): Declare.
1344 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1345 (validRequestorForSendType): Return type is (id).
1346 Change indexOfObjectIdenticalTo to indexOfObject.
1347 Check if we have local selection before returning self (Bug#8842).
1348 (writeSelectionToPasteboard): Put local selection into paste board
1349 if we have a local selection (Bug#8842).
1350 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1352 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1353 (ns_get_local_selection): Declare.
1355 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1357 * keymap.c (describe_map_tree): Don't insert a double newline at
1358 the end of the buffer (bug#1169) and return whether we inserted
1361 * callint.c (Fcall_interactively): Change "reading args" to
1362 "providing args" to try to clarify what it does (bug#1010).
1364 2011-07-07 Kenichi Handa <handa@m17n.org>
1366 * composite.c (composition_compute_stop_pos): Ignore a static
1367 composition starting before CHARPOS (Bug#8915).
1369 * xdisp.c (handle_composition_prop): Likewise.
1371 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1373 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1376 2011-07-07 Kenichi Handa <handa@m17n.org>
1378 * character.h (unicode_category_t): New enum type.
1380 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1381 (Qchar_code_property_table): New variable.
1382 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1383 (UNIPROP_COMPRESSED_FORM_P): New macros.
1384 (char_table_ascii): Uncompress the compressed values.
1385 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1386 Uncompress the compressed values.
1387 (sub_char_table_ref_and_range): Likewise.
1388 (char_table_ref_and_range): Uncompress the compressed values.
1389 (sub_char_table_set): New arg is_uniprop. Callers changed.
1390 Uncompress the compressed values.
1391 (sub_char_table_set_range): Args changed. Callers changed.
1392 (char_table_set_range): Adjuted for the above change.
1393 (map_sub_char_table): Delete args default_val and parent. Add arg
1394 top. Give decoded values to a Lisp function.
1395 (map_char_table): Adjust for the above change. Give decoded
1396 values to a Lisp function. Gcpro more variables.
1397 (uniprop_table_uncompress)
1398 (uniprop_decode_value_run_length): New functions.
1399 (uniprop_decoder, uniprop_decoder_count): New variables.
1400 (uniprop_get_decoder, uniprop_encode_value_character)
1401 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1403 (uniprop_encoder, uniprop_encoder_count): New variables.
1404 (uniprop_get_encoder, uniprop_table)
1405 (Funicode_property_table_internal, Fget_unicode_property_internal)
1406 (Fput_unicode_property_internal): New functions.
1407 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1408 Sunicode_property_table_internal, Sget_unicode_property_internal,
1409 and Sput_unicode_property_internal. Defvar_lisp
1410 char-code-property-alist.
1412 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
1413 Vunicode_category_table.
1415 * font.c (font_range): Adjust for the change of
1416 Vunicode_category_table.
1418 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1420 * m/iris4d.h: Remove file, move contents ...
1421 * s/irix6-5.h: ... here.
1423 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1425 Remove unportable assumption about struct layout (Bug#8884).
1426 * alloc.c (mark_buffer):
1427 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1428 (clone_per_buffer_values): Don't assume that
1429 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1430 This isn't true in general, and it's particularly not true
1431 if Emacs is configured with --with-wide-int.
1432 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1433 New macros, used in the buffer.c change.
1435 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1437 * xsettings.c: Use both GConf and GSettings if both are available.
1438 (store_config_changed_event): Add comment.
1439 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1440 (store_tool_bar_style_changed): New functions.
1441 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1442 (struct xsettings): Move font inside HAVE_XFT.
1443 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1444 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
1445 Move inside HAVE_XFT.
1446 (something_changed_gsettingsCB): Rename from something_changedCB.
1447 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1449 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1450 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1451 (something_changed_gconfCB): Rename from something_changedCB.
1452 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1453 (parse_settings): Move check for font inside HAVE_XFT.
1454 (read_settings, apply_xft_settings): Add comment.
1455 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1456 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1457 call store_font_name_changed.
1458 (xft_settings_event): Add comment.
1459 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1460 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1461 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1462 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1463 (xsettings_initialize): Call init_gsettings last.
1464 (xsettings_get_system_font, xsettings_get_system_normal_font):
1467 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1469 Random fixes. E.g., (random) never returned negative values.
1470 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1471 subseconds part to the entropy, as that's a bit more random.
1472 Prefer signed to unsigned, since the signedness doesn't matter and
1473 in general we prefer signed. When given a limit, use a
1474 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1475 latter isn't right if USE_2_TAGS_FOR_INTS.
1476 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1477 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1479 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1481 * textprop.c (text_property_stickiness):
1482 Obey Vtext_property_default_nonsticky.
1483 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1484 * w32fns.c (syms_of_w32fns):
1485 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1487 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1489 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1490 This is more efficient than Ffile_directory_p and avoids a minor race.
1492 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1494 * buffer.c (Foverlay_put): Say what the return value is
1497 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1498 is a directory before asking whether to use the file name
1500 (barf_or_query_if_file_exists): Make the "File is a directory"
1501 error be more correct.
1503 * fns.c (Frequire): Remove the mention of the .gz files, since
1504 that's installation-specific, but keep the mention of
1505 `get-load-suffixes'.
1507 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1509 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1510 Report string overflow if the output is too long.
1512 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1514 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1515 (syms_of_gnutls): Remove duplicate DEFSYM for
1516 Qgnutls_bootprop_verify_hostname_error, an error for
1517 Qgnutls_bootprop_verify_error (which is no longer used).
1519 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1520 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1521 Also (re)move comments that are misplaced or no longer relevant.
1523 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1525 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1527 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1529 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1530 and background color parameters if they have been changed.
1532 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1534 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1536 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1538 * xsettings.c (SYSTEM_FONT): Define only when used.
1539 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1541 * keymap.c (access_keymap_1): Now static.
1543 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1545 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1546 leave any prefix arg for the up event (Bug#1586).
1548 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1550 * lread.c (syms_of_lread): Mention single symbols defined by
1551 `defvar' or `defconst' (bug#7154).
1553 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1554 (Frequire): Mention get-load-suffixes.
1556 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1558 * window.h (window): Remove clone_number slot.
1559 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1561 (make_parent_window, make_window, saved_window)
1562 (Fset_window_configuration, save_window_save): Don't deal with
1564 * buffer.c (Qclone_number): Remove declaration.
1565 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1567 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1569 Add multiple inheritance to keymaps.
1570 * keymap.c (Fmake_composed_keymap): New function.
1571 (Fset_keymap_parent): Simplify.
1572 (fix_submap_inheritance): Remove.
1573 (access_keymap_1): New function extracted from access_keymap to handle
1574 embedded parents and handle lists of maps.
1575 (access_keymap): Use it.
1576 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1577 (Fcopy_keymap): Handle embedded parents.
1578 (Fcommand_remapping, define_as_prefix): Simplify.
1579 (Fkey_binding): Simplify.
1580 (syms_of_keymap): Move minibuffer-local-completion-map,
1581 minibuffer-local-filename-completion-map,
1582 minibuffer-local-must-match-map, and
1583 minibuffer-local-filename-must-match-map to Elisp.
1584 (syms_of_keymap): Defsubr make-composed-keymap.
1585 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1586 (parse_menu_item): Trivial simplification.
1588 2011-07-01 Glenn Morris <rgm@gnu.org>
1590 * Makefile.in (SETTINGS_LIBS): Fix typo.
1592 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1594 * coding.c (Fencode_coding_string): Record the last coding system
1595 used, as the function doc string says (bug#8738).
1597 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1599 * xsettings.c (store_monospaced_changed): Take new font as arg and
1600 check for change against current_mono_font.
1601 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1602 (emacs_settings_constructor, emacs_settings_get_property)
1603 (emacs_settings_set_property, emacs_settings_class_init)
1604 (emacs_settings_init, gsettings_obj): Remove.
1605 (something_changedCB): New function for HAVE_GSETTINGS.
1606 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1607 with value as argument.
1608 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1609 g_settings_new (Bug#8967). Do not create gsettings_obj.
1610 Remove calls to g_settings_bind. Connect something_changedCB to
1613 * xgselect.c: Add defined (HAVE_GSETTINGS).
1614 (xgselect_initialize): Ditto.
1616 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1617 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1620 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1622 * eval.c (struct backtrace): Simplify and port the data structure.
1623 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1624 signed bit field, as this assumption is not portable and it makes
1625 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1626 "char debug_on_exit : 1" as this is not portable either; instead,
1627 use the portable "unsigned int debug_on_exit : 1". Remove unused
1628 member evalargs. Remove obsolete comments about cc bombing out.
1630 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1632 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1633 Let HAVE_GSETTINGS override HAVE_GCONF.
1634 (store_monospaced_changed): New function.
1635 (EMACS_SETTINGS): A new type derived from GObject to handle
1636 GSettings notifications.
1637 (emacs_settings_constructor, emacs_settings_get_property)
1638 (emacs_settings_set_property, emacs_settings_class_init):
1640 (gsettings_client, gsettings_obj): New variables.
1641 (GSETTINGS_SCHEMA): New define.
1642 (something_changedCB): Call store_monospaced_changed.
1643 (init_gsettings): New function.
1644 (xsettings_initialize): Call init_gsettings.
1645 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1648 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
1651 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1653 * window.c (resize_root_window, grow_mini_window)
1654 (shrink_mini_window): Rename Qresize_root_window to
1655 Qwindow_resize_root_window and Qresize_root_window_vertically to
1656 Qwindow_resize_root_window_vertically.
1658 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1660 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1662 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1664 * makefile.w32-in: Redesign dependencies so they reflect more
1665 clearly which files are directly included by each source file,
1666 and not through other includes.
1668 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1670 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1671 (sort_overlays, overlay_strings): When an overlay's clone number
1672 matches the window's clone number process the overlay even if
1673 the overlay's window property doesn't match the current window.
1675 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1676 (Fwindow_hchild): Rename to Fwindow_left_child.
1677 (Fwindow_next): Rename to Fwindow_next_sibling.
1678 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1679 (resize_window_check): Rename to window_resize_check.
1680 (resize_window_apply): Rename to window_resize_apply.
1681 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1682 (Fdelete_other_windows_internal, resize_frame_windows)
1683 (Fsplit_window_internal, Fdelete_window_internal)
1684 (grow_mini_window, shrink_mini_window)
1685 (Fresize_mini_window_internal): Fix callers accordingly.
1687 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1689 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1690 (emacs_fixed_set_min_size): Remove.
1691 (emacs_fixed_new): Take frame as argument.
1693 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1694 (_EmacsFixedPrivate): Remove minwidth/height.
1695 Add struct frame *f.
1696 (emacs_fixed_init): Initialize priv->f.
1697 (get_parent_class, emacs_fixed_set_min_size): Remove.
1698 (emacs_fixed_new): Set priv->f to argument.
1699 (emacs_fixed_get_preferred_width)
1700 (emacs_fixed_get_preferred_height): Use min_width/height from
1701 frames size_hint to set minimum and natural (Bug#8919).
1702 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1703 and use min_width/height from frames size_hint to set
1704 min_width/height (Bug#8919).
1706 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1707 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1710 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1712 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1713 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1716 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1718 * process.c (wait_reading_process_output): Bypass select if
1719 waiting for a cell while ignoring keyboard input, and input is
1720 pending. Suggested by Jan Djärv (Bug#8869).
1722 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1724 Use gnulib's dup2 module instead of rolling our own.
1725 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1727 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1729 * dispnew.c (scrolling_window): Before scrolling, turn off a
1730 mouse-highlight in the window being scrolled.
1732 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1734 Move DEFSYM to lisp.h and use everywhere.
1736 * character.h (DEFSYM): Move declaration...
1737 * lisp.h (DEFSYM): ...here.
1743 * w32select.c: Don't include character.h.
1745 * alloc.c (syms_of_alloc):
1746 * buffer.c (syms_of_buffer):
1747 * bytecode.c (syms_of_bytecode):
1748 * callint.c (syms_of_callint):
1749 * casefiddle.c (syms_of_casefiddle):
1750 * casetab.c (init_casetab_once):
1751 * category.c (init_category_once, syms_of_category):
1752 * ccl.c (syms_of_ccl):
1753 * cmds.c (syms_of_cmds):
1754 * composite.c (syms_of_composite):
1755 * dbusbind.c (syms_of_dbusbind):
1756 * dired.c (syms_of_dired):
1757 * dispnew.c (syms_of_display):
1758 * doc.c (syms_of_doc):
1759 * editfns.c (syms_of_editfns):
1760 * emacs.c (syms_of_emacs):
1761 * eval.c (syms_of_eval):
1762 * fileio.c (syms_of_fileio):
1763 * fns.c (syms_of_fns):
1764 * frame.c (syms_of_frame):
1765 * fringe.c (syms_of_fringe):
1766 * insdel.c (syms_of_insdel):
1767 * keymap.c (syms_of_keymap):
1768 * lread.c (init_obarray, syms_of_lread):
1769 * macros.c (syms_of_macros):
1770 * msdos.c (syms_of_msdos):
1771 * print.c (syms_of_print):
1772 * process.c (syms_of_process):
1773 * search.c (syms_of_search):
1774 * sound.c (syms_of_sound):
1775 * syntax.c (init_syntax_once, syms_of_syntax):
1776 * terminal.c (syms_of_terminal):
1777 * textprop.c (syms_of_textprop):
1778 * undo.c (syms_of_undo):
1779 * w32.c (globals_of_w32):
1780 * window.c (syms_of_window):
1781 * xdisp.c (syms_of_xdisp):
1782 * xfaces.c (syms_of_xfaces):
1783 * xfns.c (syms_of_xfns):
1784 * xmenu.c (syms_of_xmenu):
1785 * xsettings.c (syms_of_xsettings):
1786 * xterm.c (syms_of_xterm): Use DEFSYM.
1788 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1790 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1792 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1794 Integer and buffer overflow fixes (Bug#8873).
1796 * print.c (printchar, strout): Check for string overflow.
1797 (PRINTPREPARE, printchar, strout):
1798 Don't set size unless allocation succeeds.
1800 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1801 for sizes. Check for string overflow more accurately.
1802 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1804 * macros.c: Integer and buffer overflow fixes.
1805 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1806 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1807 Use ptrdiff_t, not int, for sizes.
1808 Don't increment bufsize until after realloc succeeds.
1809 Check for size-calculation overflow.
1810 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1812 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1814 * lread.c: Integer overflow fixes.
1815 (read_integer): Radix is now EMACS_INT, not int,
1816 to improve quality of diagnostics for out-of-range radices.
1817 Calculate buffer size correctly for out-of-range radices.
1818 (read1): Check for integer overflow in radices, and in
1819 read-circle numbers.
1820 (read_escape): Avoid int overflow.
1821 (Fload, openp, read_buffer_size, read1)
1822 (substitute_object_recurse, read_vector, read_list, map_obarray):
1823 Use ptrdiff_t, not int, for sizes.
1824 (read1): Use EMACS_INT, not int, for sizes.
1825 Check for size overflow.
1827 * image.c (cache_image): Check for size arithmetic overflow.
1829 * lread.c: Integer overflow issues.
1830 (saved_doc_string_size, saved_doc_string_length)
1831 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1832 Now ptrdiff_t, not int.
1833 (read1): Don't assume doc string length fits in int. Check for
1834 out-of-range doc string lengths.
1835 (read_list): Don't assume file position fits in int.
1836 (read_escape): Check for hex character overflow.
1838 2011-06-22 Leo Liu <sdl.web@gmail.com>
1840 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1841 Move to minibuffer.el.
1843 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1845 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1846 The following patches are for when GLYPH_DEBUG && !XASSERT.
1847 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1848 * dispnew.c (flush_stdout):
1849 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1850 Mark as externally visible.
1851 * dispnew.c (check_window_matrix_pointers): Now static.
1852 * dispnew.c (window_to_frame_vpos):
1853 * xfns.c (unwind_create_frame):
1854 * xterm.c (x_check_font): Remove unused local.
1855 * scroll.c (CHECK_BOUNDS):
1856 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1857 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1858 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1859 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1860 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1862 (debug_method_add): Use va_list and vsprintf rather than relying
1863 on undefined behavior with wrong number of arguments.
1864 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1865 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1866 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1867 since we're not interested in debugging glyphs with old libraries.
1868 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1869 GCC 4.6.0's static checking.
1871 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1873 Integer overflow and signedness fixes (Bug#8873).
1874 A few related buffer overrun fixes, too.
1876 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1878 * dispextern.h (struct face.stipple):
1879 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1880 (x_bitmap_mask, x_allocate_bitmap_record)
1881 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1882 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1883 (x_create_bitmap_from_xpm_data):
1884 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1885 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1887 * xfaces.c (load_pixmap):
1888 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1889 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1890 (.bitmaps_last, struct x_output.icon_bitmap):
1891 Use ptrdiff_t, not int, for bitmap indexes.
1892 (x_allocate_bitmap_record): Check for size overflow.
1893 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1895 Use ptrdiff_t, not int, for overlay counts.
1896 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1897 * editfns.c (overlays_around, get_pos_property):
1898 * textprop.c (get_char_property_and_overlay):
1899 * xdisp.c (next_overlay_change, note_mouse_highlight):
1900 * xfaces.c (face_at_buffer_position):
1901 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1902 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1903 (Fnext_overlay_change, Fprevious_overlay_change)
1904 (mouse_face_overlay_overlaps, Foverlays_in):
1905 Use ptrdiff_t, not int, for sizes.
1906 (overlays_at, overlays_in): Check for size-calculation overflow.
1908 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1910 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1911 (x_session_initialize): Do not assume string length fits in int.
1913 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1914 This is unlikely, but can occur if DPI is outlandish.
1916 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1917 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1919 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1920 * xrdb.c (magic_file_p, search_magic_path):
1921 Omit last arg SUFFIX; it was always 0. All callers changed.
1922 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1924 * xfont.c (xfont_match): Avoid need for strlen.
1926 * xfns.c: Don't assume strlen fits in int.
1927 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1929 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1930 not unsigned long, as we prefer signed integers. All callers changed.
1931 Detect integer overflow in repeat count.
1932 (message_dolog): Don't assume print length fits in 39 bytes.
1933 (display_mode_element): Don't assume strlen fits in int.
1935 * termcap.c: Don't assume sizes fit in int and never overflow.
1936 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1937 (gobble_line): Check for size-calculation overflow.
1939 * minibuf.c (Fread_buffer):
1940 * lread.c (intern, intern_c_string):
1941 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1942 Don't assume string length fits in int.
1944 * keyboard.c (parse_tool_bar_item):
1945 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1947 * font.c: Don't assume string length fits in int.
1948 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1949 Use ptrdiff_t, not int.
1950 (font_intern_prop): Don't assume string length fits in int.
1951 Don't assume integer property fits in fixnum.
1952 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1954 * filelock.c: Fix some buffer overrun and integer overflow issues.
1955 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1956 Reformulate so as not to need the command string.
1957 Invoke gzip -cd rather than gunzip, as it's more portable.
1958 (lock_info_type, lock_file_1, lock_file):
1959 Don't assume pid_t and time_t fit in unsigned long.
1960 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1961 (current_lock_owner): Prefer signed type for sizes.
1962 Use memcpy, not strncpy, where memcpy is what is really wanted.
1963 Don't assume (via atoi) that time_t and pid_t fit in int.
1964 Check for time_t and/or pid_t out of range, e.g., via a network share.
1965 Don't alloca where an auto var works fine.
1967 * fileio.c: Fix some integer overflow issues.
1968 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1969 Don't assume string length fits in int.
1970 (directory_file_name): Don't assume string length fits in long.
1971 (make_temp_name): Don't assume pid fits in int, or that its print
1972 length is less than 20.
1974 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1976 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1978 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1980 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1981 We prefer signed integers, even for size calculations.
1983 * emacs.c: Don't assume string length fits in 'int'.
1984 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1985 (main): Don't invoke strlen when not needed.
1987 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1988 (XD_DEBUG_MESSAGE): Don't waste a byte.
1990 * callproc.c (getenv_internal_1, getenv_internal)
1992 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1994 * lread.c (invalid_syntax): Omit length argument.
1995 All uses changed. This doesn't fix a bug, but it simplifies the
1996 code away from its former Hollerith-constant appearance, and it's
1997 one less 'int' to worry about when looking at integer-overflow issues.
1998 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2000 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2001 This didn't break anything, but it didn't help either.
2002 It's confusing to put a bogus integer in a place where the actual
2003 value does not matter.
2004 (LIST_END_P): Remove unused macro and its bogus comment.
2005 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2007 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2008 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2010 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2011 We prefer signed types, and the value cannot exceed the EMACS_INT
2012 range anyway (because otherwise the length would not be representable).
2013 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2014 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2015 This avoids a GCC warning when WIDE_EMACS_INT.
2017 * indent.c (sane_tab_width): New function.
2018 (current_column, scan_for_column, Findent_to, position_indentation)
2019 (compute_motion): Use it. This is just for clarity.
2020 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2022 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2024 * lisp.h (lint_assume): New macro.
2025 * composite.c (composition_gstring_put_cache):
2026 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2028 * editfns.c, insdel.c:
2029 Omit unnecessary forward decls, to simplify future changes.
2031 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2033 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2035 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2036 Use much-faster test for byte-length change.
2037 Don't assume string byte-length fits in 'int'.
2038 Check that character arg fits in 'int'.
2039 (mapcar1): Declare byte as byte, for clarity.
2041 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2043 * fns.c (concat): Catch string overflow earlier.
2044 Do not rely on integer wraparound.
2046 * dispextern.h (struct it.overlay_strings_charpos)
2047 (struct it.selective): Now EMACS_INT, not int.
2048 * xdisp.c (forward_to_next_line_start)
2049 (back_to_previous_visible_line_start)
2050 (reseat_at_next_visible_line_start, next_element_from_buffer):
2051 Don't arbitrarily truncate the value of 'selective' to int.
2053 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2055 * composite.c: Don't truncate sizes to 'int'.
2056 (composition_gstring_p, composition_reseat_it)
2057 (composition_adjust_point): Use EMACS_INT, not int.
2058 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2059 not EMACS_UINT, for indexes.
2061 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2063 * buffer.c: Include <verify.h>.
2064 (struct sortvec.priority, struct sortstr.priority):
2065 Now EMACS_INT, not int.
2066 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2067 (struct sortstr.size, record_overlay_string)
2068 (struct sortstrlist.size, struct sortlist.used):
2069 Don't truncate size to int.
2070 (record_overlay_string): Check for size-calculation overflow.
2071 (init_buffer_once): Check at compile-time, not run-time.
2073 2011-06-22 Jim Meyering <meyering@redhat.com>
2075 Don't leak an XBM-image-sized buffer
2076 * image.c (xbm_load): Free the image buffer after using it.
2078 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2081 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2082 that Sun C diagnosed.
2083 * fns.c (secure_hash): Fix pointer signedness issue.
2084 * intervals.c (static_offset_intervals): New function.
2085 (offset_intervals): Use it.
2087 2011-06-21 Leo Liu <sdl.web@gmail.com>
2090 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2093 * fns.c (secure_hash): Rename from crypto_hash_function and change
2094 the first arg to accept symbols.
2095 (Fsecure_hash): New primitive.
2096 (syms_of_fns): New symbols.
2098 2011-06-20 Deniz Dogan <deniz@dogan.se>
2100 * process.c (Fset_process_buffer): Clarify return value in
2103 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2105 * dispnew.c (add_window_display_history): Use BVAR.
2107 * xdisp.c (debug_method_add): Use BVAR.
2108 (check_window_end, dump_glyph_matrix, dump_glyph)
2109 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2111 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2114 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2115 check till after the cache is created in init_frame_faces.
2117 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2119 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2121 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2123 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2124 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2125 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2127 Improve buffer-overflow checking (Bug#8873).
2128 * fileio.c (Finsert_file_contents):
2129 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2130 Remove the old (too-loose) buffer overflow checks.
2131 They weren't needed, since make_gap checks for buffer overflow.
2132 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2133 The old code merely checked for Emacs fixnum overflow, and relied
2134 on undefined (wraparound) behavior. The new code avoids undefined
2135 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2137 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2138 Tune. Don't use wider integers than needed. Don't use alloca.
2139 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2141 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2143 * insdel.c, lisp.h (buffer_overflow): New function.
2144 (insert_from_buffer_1, replace_range, replace_range_2):
2145 * insdel.c (make_gap_larger):
2146 * editfns.c (Finsert_char):
2147 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2149 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2151 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2153 Integer overflow and signedness fixes (Bug#8873).
2155 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2156 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2158 * fileio.c: Don't assume EMACS_INT fits in off_t.
2159 (emacs_lseek): New static function.
2160 (Finsert_file_contents, Fwrite_region): Use it.
2161 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2163 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2165 * fns.c: Don't overflow int when computing a list length.
2166 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2167 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2168 truncation on 64-bit hosts. Check for QUIT every
2169 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2170 faster and is responsive enough.
2171 (Flength): Report an error instead of overflowing an integer.
2172 (Fsafe_length): Return a float if the value is not representable
2173 as a fixnum. This shouldn't happen except in contrived situations.
2174 (Fnthcdr, Fsort): Don't assume list length fits in int.
2175 (Fcopy_sequence): Don't assume vector length fits in int.
2177 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2178 (header_size, word_size): New constants.
2179 (allocate_vectorlike): Don't check size overflow here.
2180 (allocate_vector): Check it here instead, since this is the only
2181 caller of allocate_vectorlike that could cause overflow.
2182 Check that the new vector's length is representable as a fixnum.
2184 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2185 The previous code was bogus. For example, next_almost_prime (32)
2186 returned 39, which is undesirable as it is a multiple of 3; and
2187 next_almost_prime (24) returned 25, which is a multiple of 5 so
2188 why was the code bothering to check for multiples of 7?
2190 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2192 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2194 Variadic C functions now count arguments with ptrdiff_t.
2195 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2196 Back then I didn't know that the Emacs coding style prefers signed int.
2197 Also, in the meantime I found a few more instances where arguments
2198 were being counted with int, which may truncate counts on 64-bit
2199 machines, or EMACS_INT, which may be unnecessarily wide.
2200 * lisp.h (struct Lisp_Subr.function.aMANY)
2201 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2202 Arg counts are now ptrdiff_t, not size_t.
2203 All variadic functions and their callers changed accordingly.
2204 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2205 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2206 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2207 * callint.c (Fcall_interactively): Check arg count for overflow,
2208 to avoid potential buffer overrun. Use signed char, not 'int',
2209 for 'varies' array, so that we needn't bother to check its size
2210 calculation for overflow.
2211 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2212 * eval.c (apply_lambda):
2213 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2214 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2215 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2217 * callint.c (Fcall_interactively): Don't use index var as event count.
2219 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2220 * mem-limits.h (SIZE): Remove; no longer used.
2222 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2224 Remove unnecessary casts.
2225 * xterm.c (x_term_init):
2226 * xfns.c (x_set_border_pixel):
2227 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2228 These aren't needed now that we assume ANSI C.
2230 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2231 It's more likely to cause problems (due to unsigned overflow)
2234 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2236 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2238 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2240 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2242 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2244 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2246 GLYPH_CODE_FACE returns EMACS_INT, not int.
2247 * dispextern.h (merge_faces):
2248 * xfaces.c (merge_faces):
2249 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2250 Don't assume EMACS_INT fits in int.
2252 * character.h (CHAR_VALID_P): Remove unused parameter.
2253 * fontset.c, lisp.h, xdisp.c: All uses changed.
2255 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2257 * fns.c (concat): Minor tuning based on overflow analysis.
2258 This doesn't fix any bugs. Use int to hold character, instead
2259 of constantly refetching from Emacs object. Use XFASTINT, not
2260 XINT, for value known to be a character. Don't bother comparing
2261 a single byte to 0400, as it's always less.
2263 * floatfns.c (Fexpt):
2264 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2266 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2269 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2271 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2272 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2273 incorrectly succeed when S was a string, because 4294967386 was
2274 truncated before it was used.
2276 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2277 Otherwise, an out-of-range integer could cause undefined behavior
2280 * composite.c: Use int, not EMACS_INT, for characters.
2281 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2282 EMACS_INT, for values that are known to be in character range.
2283 This doesn't fix any bugs but is the usual style inside Emacs and
2284 may generate better code on 32-bit machines.
2286 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2287 This is for reasons similar to the recent CHAR_STRING fix.
2288 * charset.c (Fencode_char): Check that character arg is actually
2289 a character. Pass an int to ENCODE_CHAR.
2290 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2291 wider than 'int', as a compile-time check to prevent future regressions
2294 * character.c (char_string): Remove unnecessary casts.
2296 Make sure a 64-bit char is never passed to CHAR_STRING.
2297 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2298 by silently ignoring the top 32 bits, allowing some values
2299 that were far too large to be valid characters.
2300 * character.h: Include <verify.h>.
2301 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2302 arguments are no wider than unsigned, as a compile-time check
2303 to prevent future regressions in this area.
2305 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2306 (Fsubst_char_in_region):
2308 * xdisp.c (decode_mode_spec_coding):
2309 Adjust to CHAR_STRING's new requirement.
2310 * editfns.c (Finsert_char, Fsubst_char_in_region):
2311 * fns.c (concat): Check that character args are actually
2312 characters. Without this test, these functions did the wrong
2313 thing with wildly out-of-range values on 64-bit hosts.
2315 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2316 These casts should not be needed on 32-bit hosts, either.
2317 * keyboard.c (read_char):
2318 * lread.c (Fload): Remove casts to unsigned.
2320 * lisp.h (UNSIGNED_CMP): New macro.
2321 This fixes comparison bugs on 64-bit hosts.
2322 (ASCII_CHAR_P): Use it.
2323 * casefiddle.c (casify_object):
2324 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2325 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2326 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2327 * dispextern.h (FACE_FROM_ID):
2328 * keyboard.c (read_char): Use UNSIGNED_CMP.
2330 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2331 not to EMACS_INT, to avoid GCC warning.
2333 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2335 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2336 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2337 isn't needed on 32-bit machines.
2339 * buffer.c (Fgenerate_new_buffer_name):
2340 Use EMACS_INT for count, not int.
2341 (advance_to_char_boundary): Return EMACS_INT, not int.
2343 * data.c (Qcompiled_function): Now static.
2345 * window.c (window_body_lines): Now static.
2347 * image.c (gif_load): Rename local to avoid shadowing.
2349 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2350 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2351 * alloc.c (make_save_value): Integer argument is now of type
2353 (mark_object): Use ptrdiff_t, not int.
2354 * lisp.h (pD): New macro.
2355 * print.c (print_object): Use it.
2357 * alloc.c: Use EMACS_INT, not int, to count objects.
2358 (total_conses, total_markers, total_symbols, total_vector_size)
2359 (total_free_conses, total_free_markers, total_free_symbols)
2360 (total_free_floats, total_floats, total_free_intervals)
2361 (total_intervals, total_strings, total_free_strings):
2362 Now EMACS_INT, not int. All uses changed.
2363 (Fgarbage_collect): Compute overall total using a double, so that
2364 integer overflow is less likely to be a problem. Check for overflow
2365 when converting back to an integer.
2366 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2367 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2368 These were 'int' variables that could overflow on 64-bit hosts;
2369 they were never used, so remove them instead of repairing them.
2370 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2371 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2372 Previously, this ceilinged at INT_MAX, but that doesn't work on
2374 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2376 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2377 (allocate_vectorlike): Check for ptrdiff_t overflow.
2378 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2379 when a (possibly-narrower) signed value would do just as well.
2380 We prefer using signed arithmetic, to avoid comparison confusion.
2382 * alloc.c: Catch some string size overflows that we were missing.
2383 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2384 for convenience in STRING_BYTES_MAX.
2385 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2386 The definition here is exact; the one in lisp.h was approximate.
2387 (allocate_string_data): Check for string overflow. This catches
2388 some instances we weren't catching before. Also, it catches
2389 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2390 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2391 and ptrdiff_t and EMACS_INT are both 64 bits.
2393 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2394 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2395 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
2397 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2399 * alloc.c (Fmake_string): Check for out-of-range init.
2401 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2403 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2405 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2407 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2408 xg_get_default_scrollbar_width.
2410 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2411 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2412 (style_changed_cb): Call update_theme_scrollbar_width and call
2413 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2414 all frames (Bug#8505).
2415 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2416 Call gtk_window_set_resizable if HAVE_GTK3.
2417 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2418 and height if HAVE_GTK3 (Bug#8505).
2419 (scroll_bar_width_for_theme): New variable.
2420 (update_theme_scrollbar_width): New function.
2421 (xg_get_default_scrollbar_width): Move code to
2422 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2423 (xg_initialize): Call update_theme_scrollbar_width.
2425 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2427 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2429 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2431 * frame.c (make_frame): Call other_buffer_safely instead of
2434 * window.c (temp_output_buffer_show): Call display_buffer with
2435 second argument Vtemp_buffer_show_specifiers and reset latter
2436 immediately after the call.
2437 (Vtemp_buffer_show_specifiers): New variable.
2438 (auto_window_vscroll_p, next_screen_context_lines)
2439 (Vscroll_preserve_screen_position): Remove leading asterisks from
2442 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2444 Fix minor problems found by GCC 4.6.0 static checking.
2445 * buffer.c (Qclone_number): Remove for now, as it's unused.
2446 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2447 (record_buffer): Remove unused local.
2448 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2449 (set_frame_buffer_list): Remove; unused.
2450 * frame.h (other_visible_frames): Remove decl.
2451 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2452 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2453 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2455 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2456 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2457 Define only if HAVE_GPM.
2458 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2459 (update_hints_inhibit): Remove; never set. All uses removed.
2460 * widgetprv.h (emacsFrameClassRec): Remove decl.
2461 * window.c (delete_deletable_window): Now returns void, since it
2462 wasn't returning anything.
2463 (compare_window_configurations): Remove unused locals.
2464 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2465 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2466 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2467 the same widths as pointers. This follows up on the 2011-05-06 patch.
2468 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2469 * xterm.h: Likewise.
2470 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2472 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2474 * makefile.w32-in: Update dependencies.
2475 (LISP_H): Add lib/intprops.h.
2477 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2479 * image.c (gif_load): Add animation frame delay to the metadata.
2480 (syms_of_image): Use DEFSYM. New symbol `delay'.
2482 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2484 * window.c (delete_deletable_window): Re-add.
2485 (Fset_window_configuration): Rewrite to handle dead buffers and
2486 consequently deletable windows.
2487 (window_tree, Fwindow_tree): Remove. Supply functionality in
2489 (compare_window_configurations): Simplify code.
2491 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2493 * image.c (imagemagick_load_image): Fix type mismatch.
2494 (Fimagemagick_types): Likewise.
2496 * window.h (replace_buffer_in_windows): Declare.
2498 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2500 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2501 Qclone_number. Remove external declaration of Qdelete_window.
2502 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2504 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2505 Run Qbuffer_list_update_hook if allowed.
2506 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2507 buffer list implementation.
2508 (other_buffer_safely): New function.
2509 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2510 calls to replace_buffer_in_windows and
2511 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2513 (record_buffer): Inhibit quitting and rewrite using quittable
2514 functions. Run Qbuffer_list_update_hook if allowed.
2515 (Frecord_buffer, Funrecord_buffer): New functions.
2516 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2517 Move switch-to-buffer to window.el.
2518 (bury-buffer): Move to window.el.
2519 (Vbuffer_list_update_hook): New variable.
2521 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2524 * window.h (resize_frame_windows): Move up in code.
2525 (Fwindow_frame): Remove EXFUN.
2526 (replace_buffer_in_all_windows): Remove prototype.
2527 (replace_buffer_in_windows_safely): Add prototype.
2529 * window.c: Declare Qdelete_window static again. Move down
2530 declaration of select_count.
2531 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2532 (Fother_window): Move to window.el.
2533 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2534 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2535 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2537 (replace_buffer_in_windows): Implement by calling
2538 Qreplace_buffer_in_windows.
2539 (replace_buffer_in_all_windows): Remove with some functionality
2540 moved into replace_buffer_in_windows_safely.
2541 (replace_buffer_in_windows_safely): New function.
2542 (select_window_norecord, select_frame_norecord): Move in front
2543 of run_window_configuration_change_hook. Remove now obsolete
2545 (Fset_window_buffer): Rewrite doc-string.
2546 Call Qrecord_window_buffer.
2547 (keys_of_window): Move binding for other-window to window.el.
2549 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2551 * dispextern.h (struct image): Replace data member, whose int_val
2552 and ptr_val fields were not used by anything, with a single
2555 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2556 (gif_clear_image, gif_load, imagemagick_load_image)
2557 (gs_clear_image, gs_load): Callers changed.
2559 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2561 * buffer.h: Include <time.h>, for time_t.
2562 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2564 Fix minor problems found by static checking.
2566 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2568 Make identifiers static if they are not used in other modules.
2569 * data.c (Qcompiled_function, Qframe, Qvector):
2570 * image.c (QimageMagick, Qsvg):
2571 * minibuf.c (Qmetadata):
2572 * window.c (resize_window_check, resize_root_window): Now static.
2573 * window.h (resize_window_check, resize_root_window): Remove decls.
2575 * window.c (window_deletion_count, delete_deletable_window):
2577 (window_body_lines): Now static.
2578 (Fdelete_other_windows_internal): Mark vars as initialized.
2579 Make sure 'resize_failed' is initialized.
2580 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2581 (resize_window_apply): Remove unused local.
2582 * window.h (delete_deletable_window): Remove decl.
2584 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2585 (imagemagick_load_image): Fix pointer signedness problem by changing
2586 last arg from unsigned char * to char *. All uses changed.
2587 Also, fix a local for similar reasons.
2588 Remove unused locals. Remove locals to avoid shadowing.
2589 (fn_rsvg_handle_free): Remove; unused.
2590 (svg_load, svg_load_image): Fix pointer signedness problem.
2591 (imagemagick_load_image): Don't use garbage pointer image_wand.
2593 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2595 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2597 * image.c (gif_load): Fix omitted cast error introduced by
2600 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2602 * window.h (resize_proportionally, orig_total_lines)
2603 (orig_top_line): Remove from window structure.
2604 (set_window_height, set_window_width, change_window_heights)
2605 (Fdelete_window): Remove prototypes.
2606 (resize_frame_windows): Remove duplicate declaration.
2608 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2610 * window.h (resize_frame_windows, resize_window_check)
2611 (delete_deletable_window, resize_root_window)
2612 (resize_frame_windows): Declare prototypes.
2614 * window.c (resize_window_apply): Make definition be "static" to
2615 match the prototype.
2617 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2619 * window.c: Remove declarations of Qwindow_size_fixed,
2620 window_min_size_1, window_min_size_2, window_min_size,
2621 size_window, window_fixed_size_p, enlarge_window, delete_window.
2622 Remove static from declaration of Qdelete_window, it's
2623 temporarily needed by Fbury_buffer.
2624 (replace_window): Don't assign orig_top_line and
2626 (Fdelete_window, delete_window): Remove. Window deletion is
2627 handled by window.el.
2628 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2629 Replace Fdelete_window calls with calls to Qdelete_window.
2630 (Fdelete_other_windows): Remove. Deleting other windows is
2631 handled by window.el.
2632 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2633 handled in window.el.
2634 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2635 Window minimum sizes are handled in window.el.
2636 (shrink_windows, size_window, set_window_height)
2637 (set_window_width, change_window_heights, window_height)
2638 (window_width, CURBEG, CURSIZE, enlarge_window)
2639 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2640 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2641 handled in window.el.
2642 (make_dummy_parent): Rename to make_parent_window and give it a
2643 second argument horflag.
2644 (make_window): Don't set resize_proportionally any more.
2645 (Fsplit_window): Remove. Windows are split in window.el.
2646 (save_restore_action, save_restore_orig_size)
2647 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2648 Resize mini windows in window.el.
2649 (grow_mini_window, shrink_mini_window): Implement by calling
2650 Qresize_root_window_vertically, resize_window_check and
2651 resize_window_apply.
2652 (saved_window, Fset_window_configuration, save_window_save):
2653 Do not handle orig_top_line, orig_total_lines, and
2654 resize_proportionally.
2655 (window_min_height, window_min_width): Move to window.el.
2656 (keys_of_window): Move bindings for delete-other-windows,
2657 split-window, delete-window and enlarge-window to window.el.
2659 * buffer.c: Temporarily extern Qdelete_window.
2660 (Fbury_buffer): Temporarily call Qdelete_window instead of
2661 Fdelete_window (Fbury_buffer will move to window.el soon).
2663 * frame.c (set_menu_bar_lines_1): Remove code handling
2664 orig_top_line and orig_total_lines.
2666 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2667 set_window_height but set heights directly.
2668 (change_frame_size_1): Use resize_frame_windows.
2670 * xdisp.c (init_xdisp): Don't use set_window_height but set
2673 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2674 Use resize_frame_windows instead of change_window_heights and run
2675 run_window_configuration_change_hook.
2677 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2678 instead of change_window_heights and run
2679 run_window_configuration_change_hook.
2681 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2683 * window.c (replace_window): Rename second argument REPLACEMENT to
2684 NEW. New third argument SETFLAG. Rewrite.
2685 (delete_window, make_dummy_parent): Call replace_window with
2687 (window_list_1): Move down in code.
2688 (run_window_configuration_change_hook): Move set_buffer part
2689 before select_frame_norecord part in order to unwind correctly.
2690 Rename count1 to count.
2691 (recombine_windows, delete_deletable_window, resize_root_window)
2692 (Fdelete_other_windows_internal)
2693 (Frun_window_configuration_change_hook, make_parent_window)
2694 (resize_window_check, resize_window_apply, Fresize_window_apply)
2695 (resize_frame_windows, Fsplit_window_internal)
2696 (Fdelete_window_internal, Fresize_mini_window_internal):
2698 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2700 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2702 * window.h (window): Add some new members to window structure -
2703 normal_lines, normal_cols, new_total, new_normal, clone_number,
2704 splits, nest, prev_buffers, next_buffers.
2705 (WINDOW_TOTAL_SIZE): Move here from window.c.
2706 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2708 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2710 (make_dummy_parent): Set new members of windows structure.
2711 (make_window): Move down in code. Handle new members of window
2713 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2714 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2715 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2716 (Fset_window_prev_buffers, Fwindow_next_buffers)
2717 (Fset_window_next_buffers, Fset_window_clone_number):
2719 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2720 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2722 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2723 Argument WINDOW can be now internal window too.
2724 (Fwindow_use_time): Move up in code.
2725 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2727 (Fset_window_configuration, saved_window)
2728 (Fcurrent_window_configuration, save_window_save): Handle new
2729 members of window structure.
2730 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2731 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2732 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2733 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2734 Qget_mru_window, Qresize_root_window,
2735 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2736 Qauto_buffer_name; staticpro them.
2738 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2740 * window.c (Fwindow_total_size, Fwindow_left_column)
2741 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2742 (Fwindow_list_1): New functions.
2743 (window_box_text_cols): Replace with window_body_cols.
2744 (Fwindow_width, Fscroll_left, Fscroll_right):
2745 Use window_body_cols instead of window_box_text_cols.
2746 (delete_window, Fset_window_configuration):
2747 Call delete_all_subwindows with window as argument.
2748 (delete_all_subwindows): Take a window as argument and not a
2750 (window_loop): Remove handling of GET_LRU_WINDOW and
2752 (Fget_lru_window, Fget_largest_window): Move to window.el.
2754 * window.h: Extern window_body_cols instead of
2755 window_box_text_cols. delete_all_subwindows now takes a
2756 Lisp_Object as argument.
2758 * indent.c (compute_motion, Fcompute_motion):
2759 Use window_body_cols instead of window_box_text_cols.
2761 * frame.c (delete_frame): Call delete_all_subwindows with root
2764 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2766 * fns.c (Fputhash): Document return value.
2768 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2770 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2772 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2774 Cons<->int and similar integer overflow fixes (Bug#8794).
2776 Check for overflow when converting integer to cons and back.
2777 * charset.c (Fdefine_charset_internal, Fdecode_char):
2778 Use cons_to_unsigned to catch overflow.
2779 (Fencode_char): Use INTEGER_TO_CONS.
2780 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2781 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2782 * data.c (long_to_cons, cons_to_long): Remove.
2783 (cons_to_unsigned, cons_to_signed): New functions.
2784 These signal an error for invalid or out-of-range values.
2785 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2786 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2787 * font.c (Ffont_variation_glyphs):
2788 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2789 * lisp.h: Include <intprops.h>.
2790 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2791 (cons_to_signed, cons_to_unsigned): New decls.
2792 (long_to_cons, cons_to_long): Remove decls.
2793 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2794 (Fprimitive_undo): Use CONS_TO_INTEGER.
2795 * xfns.c (Fx_window_property): Likewise.
2796 * xselect.c: Include <limits.h>.
2797 (x_own_selection, selection_data_to_lisp_data):
2798 Use INTEGER_TO_CONS.
2799 (x_handle_selection_request, x_handle_selection_clear)
2800 (x_get_foreign_selection, Fx_disown_selection_internal)
2801 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2802 (lisp_data_to_selection_data): Use cons_to_unsigned.
2803 (x_fill_property_data): Use cons_to_signed.
2804 Report values out of range.
2806 Check for buffer and string overflow more precisely.
2807 * buffer.h (BUF_BYTES_MAX): New macro.
2808 * lisp.h (STRING_BYTES_MAX): New macro.
2809 * alloc.c (Fmake_string):
2810 * character.c (string_escape_byte8):
2811 * coding.c (coding_alloc_by_realloc):
2812 * doprnt.c (doprnt):
2813 * editfns.c (Fformat):
2815 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2816 since they may not be the same number.
2817 * editfns.c (Finsert_char):
2818 * fileio.c (Finsert_file_contents):
2819 Likewise for BUF_BYTES_MAX.
2821 * image.c: Use ptrdiff_t, not int, for sizes.
2822 (slurp_file): Switch from int to ptrdiff_t.
2824 (slurp_file): Check that file size fits in both size_t (for
2825 malloc) and ptrdiff_t (for sanity and safety).
2827 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2828 if b->modtime has its maximal value.
2830 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2832 Don't assume time_t can fit into int.
2833 * buffer.h (struct buffer.modtime): Now time_t, not int.
2834 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2835 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2837 Minor fixes for signed vs unsigned integers.
2838 * character.h (MAYBE_UNIFY_CHAR):
2839 * charset.c (maybe_unify_char):
2840 * keyboard.c (read_char, reorder_modifiers):
2841 XINT -> XFASTINT, since the integer must be nonnegative.
2842 * ftfont.c (ftfont_spec_pattern):
2843 * keymap.c (access_keymap, silly_event_symbol_error):
2844 XUINT -> XFASTINT, since the integer must be nonnegative.
2845 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2846 since it makes no difference and we prefer signed.
2847 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2848 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2851 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2853 * window.h (Fwindow_frame): Declare.
2855 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2857 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2858 (SPARE_MEMORY): Always define.
2859 (LARGE_REQUEST): Remove.
2860 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2862 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2864 * lisp.h: Move EXFUNS for Fframe_root_window,
2865 Fframe_first_window and Fset_frame_selected_window to window.h.
2867 * window.h: Move EXFUNS for Fframe_root_window,
2868 Fframe_first_window and Fset_frame_selected_window here from
2871 * frame.c (Fwindow_frame, Fframe_first_window)
2872 (Fframe_root_window, Fframe_selected_window)
2873 (Fset_frame_selected_window): Move to window.c.
2874 (Factive_minibuffer_window): Move to minibuf.c.
2875 (Fother_visible_frames_p): New function.
2877 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2879 * window.c (decode_window, decode_any_window): Move up in code.
2880 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2881 (inhibit_frame_unsplittable): Remove unused variable.
2882 (Fwindow_buffer): Move up and rewrite doc-string.
2883 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2884 (Fwindow_prev): New functions.
2885 (Fwindow_frame): Move here from frame.c. Accept any window as
2887 (Fframe_root_window, Fframe_first_window)
2888 (Fframe_selected_window): Move here from frame.c. Accept frame
2889 or arbitrary window as argument. Update doc-strings.
2890 (Fminibuffer_window): Move up in code.
2891 (Fwindow_minibuffer_p): Move up in code and simplify.
2892 (Fset_frame_selected_window): Move here from frame.c.
2894 (Fselected_window, select_window, Fselect_window): Move up in
2895 code. Minor doc-string fixes.
2897 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2899 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2900 Do not assume that spare memory exists; that assumption is valid
2901 only if SYSTEM_MALLOC.
2902 (LARGE_REQUEST): New macro, so that the issue of large requests
2903 is separated from the issue of spare memory.
2905 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2907 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2910 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2912 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2915 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2917 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2919 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2921 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2922 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2924 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2926 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2928 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2930 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2931 (x_clipboard_manager_save): Add return value.
2932 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2934 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2935 Obey Vx_select_enable_clipboard_manager. Catch errors in
2936 x_clipboard_manager_save (Bug#8779).
2937 (Vx_select_enable_clipboard_manager): New variable.
2938 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2940 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2942 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2944 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2946 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2947 in the current matrix if keep_current_p is non-zero.
2949 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2951 * bidi.c (bidi_level_of_next_char): Fix last change.
2953 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2955 Support bidi reordering of text covered by display properties.
2957 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2958 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2959 (bidi_cache_search, bidi_cache_iterator_state)
2960 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2961 (bidi_level_of_next_char, bidi_move_to_visually_next):
2962 Support character positions inside a run of characters covered by a
2964 (bidi_paragraph_init, bidi_resolve_explicit_1)
2965 (bidi_level_of_next_char): Call bidi_fetch_char and
2966 bidi_fetch_char_advance instead of FETCH_CHAR and
2968 (bidi_init_it): Initialize new members.
2969 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2971 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2972 instead of using explicit *_CHAR codes.
2973 (bidi_resolve_explicit, bidi_resolve_weak):
2974 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2975 bidirectional text is supported only in multibyte buffers.
2976 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2977 it to initialize the frame_window_p member of struct bidi_it.
2978 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2979 (bidi_resolve_explicit, bidi_resolve_weak)
2980 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2981 bidi_it->nchars is non-positive.
2982 (bidi_level_of_next_char): Don't try to lookup the cache for the
2983 next/previous character if nothing is cached there yet, or if we
2984 were just reseat()'ed to a new position.
2986 * xdisp.c (set_cursor_from_row): Set start and stop points
2987 according to the row's direction when priming the loop that looks
2988 for the glyph on which to display cursor.
2989 (single_display_spec_intangible_p): Function deleted.
2990 (display_prop_intangible_p): Reimplement to call
2991 handle_display_spec instead of single_display_spec_intangible_p.
2992 Accept 3 additional arguments needed by handle_display_spec.
2993 This fixes incorrect cursor motion across display property with complex
2994 values: lists, `(when COND...)' forms, etc.
2995 (single_display_spec_string_p): Support property values that are
2996 lists with the argument STRING its top-level element.
2997 (display_prop_string_p): Fix the condition for processing a
2998 property that is a list to be consistent with handle_display_spec.
2999 (handle_display_spec): New function, refactored from the
3000 last portion of handle_display_prop.
3001 (compute_display_string_pos): Accept additional argument
3002 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3003 value of a `display' property is a "replacing spec".
3004 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3005 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3006 the display property, but just return a value indicating whether
3007 the display property will replace the characters it covers.
3008 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3009 frame_window_p members of struct bidi_it.
3010 (compute_display_string_pos, compute_display_string_end):
3012 (push_it): Accept second argument POSITION, where pop_it should
3013 jump to continue iteration.
3014 (reseat_1): Initialize bidi_it.disp_pos.
3016 * keyboard.c (adjust_point_for_property): Adjust the call to
3017 display_prop_intangible_p to its new signature.
3019 * dispextern.h (struct bidi_it): New member frame_window_p.
3020 (bidi_init_it): Update prototypes.
3021 (display_prop_intangible_p): Update prototype.
3022 (compute_display_string_pos, compute_display_string_end):
3024 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3027 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3029 Malloc failure behavior now depends on size of allocation.
3030 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3031 * lisp.h: Change signatures accordingly.
3032 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3033 All callers changed. (Bug#8762)
3035 * gnutls.c: Use Emacs's memory allocators.
3036 Without this change, the gnutls library would invoke malloc etc.
3037 directly, which causes problems on non-SYNC_INPUT hosts, and which
3038 runs afoul of improving memory_full behavior. (Bug#8761)
3039 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3040 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3041 xfree instead of the default malloc, realloc, free.
3042 (Fgnutls_boot): No need to check for memory allocation failure,
3043 since xmalloc does that for us.
3045 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3046 * category.c (hash_get_category_set):
3047 * ccl.c (ccl_driver):
3048 * charset.c (Fdefine_charset_internal):
3049 * charset.h (struct charset.hash_index):
3050 * composite.c (get_composition_id, gstring_lookup_cache)
3051 (composition_gstring_put_cache):
3052 * composite.h (struct composition.hash_index):
3053 * dispextern.h (struct image.hash):
3054 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3055 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3056 (hashfn_equal, hashfn_user_defined, make_hash_table)
3057 (maybe_resize_hash_table, hash_lookup, hash_put)
3058 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3059 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3060 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3061 * image.c (make_image, search_image_cache, lookup_image)
3062 (xpm_put_color_table_h):
3063 * lisp.h (struct Lisp_Hash_Table):
3064 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3065 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3066 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3067 * alloc.c (allocate_vectorlike):
3068 Check for overflow in vector size calculations.
3069 * ccl.c (ccl_driver):
3070 Check for overflow when converting EMACS_INT to int.
3071 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3072 need to be updated by these changes.
3073 * fns.c (make_hash_table, maybe_resize_hash_table):
3074 Check for integer overflow with large hash tables.
3075 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3076 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3077 (SXHASH_REDUCE): New macro.
3078 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3079 Use it instead of discarding useful hash info with large hash values.
3080 (sxhash_float): New function.
3081 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3082 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3083 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3084 Rewrite to use FIXNUM_BITS, as this simplifies things.
3085 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3086 Adjust signatures to match updated version of code.
3087 (consing_since_gc): Now EMACS_INT, since a single hash table can
3088 use more than INT_MAX bytes.
3090 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3092 Make it possible to build with GCC-4.6+ -O2 -flto.
3094 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3096 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3098 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3099 Call minibuffer-inactive-mode.
3101 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3103 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3104 Update dependencies.
3106 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3108 * data.c (init_data): Remove code for UTS, this system is not
3111 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3113 Don't force ./temacs to start in terminal mode.
3115 * frame.c (make_initial_frame): Initialize faces in all cases, not
3116 only when CANNOT_DUMP is defined.
3117 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3119 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3121 * dispnew.c (add_window_display_history): Use const for the string
3122 pointer. Remove declaration, not needed.
3124 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3126 Use 'inline', not 'INLINE'.
3127 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3128 * alloc.c, fontset.c (INLINE): Remove.
3129 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3130 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3131 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3132 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3133 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3135 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3137 Make it possible to run ./temacs.
3139 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3140 syms_of_callproc does the same thing. Remove test for
3141 "initialized", do it in the caller.
3142 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3144 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3146 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3147 (read_minibuf): Use get_minibuffer.
3148 (syms_of_minibuf): Use DEFSYM.
3149 (Qmetadata): New var.
3150 * data.c (Qbuffer): Don't make it static.
3151 (syms_of_data): Use DEFSYM.
3153 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3155 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3156 (CCL_CODE_MIN): New macro.
3158 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3160 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3162 * eval.c (Qdebug): Now static.
3163 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3164 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3165 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3167 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3169 * image.c: Various fixes to ImageMagick code comments.
3170 (Fimagemagick_types): Doc fix.
3172 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3174 Minor fixes prompted by GCC 4.6.0 warnings.
3176 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3178 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3179 (x_clipboard_manager_save_all): Move extern decl to ...
3180 * xterm.h: ... here, so that it can be checked for consistency.
3182 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3184 * xselect.c (x_clipboard_manager_save_frame)
3185 (x_clipboard_manager_save_all): New functions.
3186 (Fx_clipboard_manager_save): Lisp function deleted.
3188 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3189 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3191 * xterm.h: Update prototype.
3193 2011-05-28 William Xu <william.xwl@gmail.com>
3195 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3198 2011-05-28 Jim Meyering <meyering@redhat.com>
3200 Avoid a sign-extension bug in crypto_hash_function.
3201 * fns.c (to_uchar): Define.
3202 (crypto_hash_function): Use it to convert some newly-signed
3203 variables to unsigned, to avoid sign-extension bugs. For example,
3204 without this change, (md5 "truc") would evaluate to
3205 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3206 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3207 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3209 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3211 Integer overflow fixes.
3213 * dbusbind.c: Serial number integer overflow fixes.
3214 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3215 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3216 to hold a serial number that is too large for a fixnum.
3217 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3218 Check for serial numbers out of range. Decode any serial number
3219 that was so large that it became a float. (Bug#8722)
3221 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3222 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3223 Use XFASTINT rather than XUINT when numbers are nonnegative.
3224 (xd_append_arg, Fdbus_method_return_internal):
3225 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3226 arguments, check that Lisp number is nonnegative, rather than
3227 silently wrapping negative numbers around. (Bug#8722)
3228 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3231 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3233 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3235 ccl: add integer overflow checks
3236 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3237 (IN_INT_RANGE): New macros.
3238 (ccl_driver): Use them to check for integer overflow when
3239 decoding a CCL program. Many of the new checks are whether XINT (x)
3240 fits in int; it doesn't always, on 64-bit hosts. The new version
3241 doesn't catch all possible integer overflows, but it's an
3242 improvement. (Bug#8719)
3244 * alloc.c (make_event_array): Use XINT, not XUINT.
3245 There's no need for unsigned here.
3247 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3248 This follows up to the 2011-05-06 change that substituted uintptr_t
3249 for EMACS_INT. This case wasn't caught back then.
3251 Rework Fformat to avoid integer overflow issues.
3252 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3253 now (part of C89). Include <verify.h>.
3254 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3255 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3256 (Fformat): Avoid the prepass trying to compute sizes; it was only
3257 approximate and thus did not catch overflow reliably. Instead, walk
3258 through the format just once, formatting and computing sizes as we go,
3259 checking for integer overflow at every step, and allocating a larger
3260 buffer as needed. Keep track separately whether the format is
3261 multibyte. Keep only the most-recently calculated precision, rather
3262 than them all. Record whether each argument has been converted to
3263 string. Use EMACS_INT, not int, for byte and char and arg counts.
3264 Support field widths and precisions larger than INT_MAX. Avoid
3265 sprintf's undefined behavior with conversion specifications such as %#d
3266 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3267 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3268 formatting out-of-range floating point numbers with int
3271 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3273 * data.c: Avoid integer truncation in expressions involving floats.
3274 * data.c: Include <intprops.h>.
3275 (arith_driver): When there's an integer overflow in an expression
3276 involving floating point, convert the integers to floating point
3277 so that the resulting value does not suffer from catastrophic
3278 integer truncation. For example, on a 64-bit host (* 4
3279 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3280 Do not rely on undefined behavior after integer overflow.
3282 merge count_size_as_multibyte, parse_str_to_multibyte
3283 * character.c, character.h (count_size_as_multibyte):
3284 Rename from parse_str_to_multibyte; all uses changed.
3285 Check for integer overflow.
3286 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3287 since it's now a duplicate of the other. This is more of
3288 a character than a buffer op, so better that it's in character.c.
3289 * fns.c, print.c: Adjust to above changes.
3291 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3293 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3295 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3297 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3298 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3299 (x_clipboard_manager_save): Now static.
3300 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3302 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3303 (crypto_hash_function): Now static.
3304 Fix pointer signedness problems. Avoid unnecessary initializations.
3306 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3308 * termhooks.h (Vselection_alist): Make it terminal-local.
3310 * terminal.c (create_terminal): Initialize it.
3312 * xselect.c: Support for clipboard managers.
3313 (Vselection_alist): Move to termhooks.h as terminal-local var.
3314 (LOCAL_SELECTION): New macro.
3315 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3316 (symbol_to_x_atom): Remove gratuitous arg.
3317 (x_handle_selection_request, lisp_data_to_selection_data)
3318 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3319 (x_own_selection, x_get_local_selection, x_convert_selection):
3320 New arg, specifying work frame. Use terminal-local Vselection_alist.
3321 (some_frame_on_display): Delete unused function.
3322 (Fx_own_selection_internal, Fx_get_selection_internal)
3323 (Fx_disown_selection_internal, Fx_selection_owner_p)
3324 (Fx_selection_exists_p): New optional frame arg.
3325 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3326 (x_handle_selection_clear): Don't treat other terminals with the
3327 same keyboard specially. Use the terminal-local Vselection_alist.
3328 (x_clear_frame_selections): Use Frun_hook_with_args.
3330 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3332 * xterm.h: Add support for those atoms.
3334 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3336 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3337 (converted_selections, conversion_fail_tag): New global variables.
3338 (x_selection_request_lisp_error): Free the above.
3339 (x_get_local_selection): Remove unnecessary code.
3340 (x_reply_selection_request): Args changed; handle arbitrary array
3341 of converted selections stored in converted_selections.
3342 Separate the XChangeProperty and SelectionNotify steps.
3343 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3344 (x_convert_selection): New function.
3345 (x_handle_selection_event): Simplify.
3346 (x_get_foreign_selection): Don't ignore incoming requests while
3347 waiting for an answer; this will fail when we implement
3348 SAVE_TARGETS, and seems unnecessary anyway.
3349 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3350 (Vx_sent_selection_functions): Doc fix.
3352 2011-05-26 Leo Liu <sdl.web@gmail.com>
3354 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3356 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3358 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3360 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3361 for fringe update if it has periodic bitmap.
3362 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3363 and fringe_bitmap_periodic_p.
3365 * fringe.c (get_fringe_bitmap_data): New function.
3366 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3367 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3368 row. Mark glyph row for fringe update if periodicity changed.
3370 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3371 for fringe update unless it has periodic bitmap.
3373 2011-05-25 Kenichi Handa <handa@m17n.org>
3375 * xdisp.c (get_next_display_element): Set correct it->face_id for
3376 a static composition.
3378 2011-05-24 Leo Liu <sdl.web@gmail.com>
3381 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3383 * fns.c (crypto_hash_function, Fsha1): New function.
3384 (Fmd5): Use crypto_hash_function.
3385 (syms_of_fns): Add Ssha1.
3387 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3389 * gnutls.c: Remove unused macros.
3390 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3391 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3392 Remove macros that are defined and never used.
3393 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3395 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3397 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3398 (Fx_get_selection_internal): Minor cleanup.
3399 (Fx_own_selection_internal): Rename arguments for consistency with
3402 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3404 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3406 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3408 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3410 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3412 * dispnew.c (scrolling_window): Don't exclude the case that the
3413 last enabled row in the desired matrix touches the bottom boundary.
3415 2011-05-21 Glenn Morris <rgm@gnu.org>
3417 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3418 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3419 and add some more files.
3421 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3423 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3424 report_file_error introduced by the change from 2011-05-07.
3426 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3428 * systime.h (Time): Define only if emacs is defined.
3429 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3430 where the include path doesn't have X11/X.h by default. See
3431 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3433 2011-05-20 Kenichi Handa <handa@m17n.org>
3435 * composite.c (find_automatic_composition): Fix previous change.
3437 2011-05-20 Glenn Morris <rgm@gnu.org>
3439 * lisp.mk: New file, split from Makefile.in.
3440 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3441 (shortlisp): Remove.
3442 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3444 2011-05-19 Glenn Morris <rgm@gnu.org>
3446 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3447 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3448 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3449 (lisp): Set the order to that of loadup.el.
3450 (shortlisp): Make it a copy of $lisp.
3451 (SOME_MACHINE_LISP): Remove.
3452 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3453 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3455 2011-05-18 Kenichi Handa <handa@m17n.org>
3457 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3458 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3459 (find_automatic_composition): Mostly rewrite for efficiency.
3461 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3463 * makefile.w32-in: Update dependencies.
3465 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3467 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3468 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3470 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3472 Fix some integer overflow issues, such as string length overflow.
3474 * insdel.c (count_size_as_multibyte): Check for string overflow.
3476 * character.c (lisp_string_width): Check for string overflow.
3477 Use EMACS_INT, not int, for string indexes and lengths; in
3478 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3479 the resulting string length overflows an EMACS_INT; instead,
3480 report a string overflow if no precision given. When checking for
3481 precision exhaustion, use a check that cannot possibly have
3482 integer overflow. (Bug#8675)
3483 * character.h (lisp_string_width): Adjust to new signature.
3485 * alloc.c (string_overflow): New function.
3486 (Fmake_string): Use it. This doesn't change behavior, but saves
3487 a few bytes and will simplify future changes.
3488 * character.c (string_escape_byte8): Likewise.
3489 * lisp.h (string_overflow): New decl.
3491 Fixups, following up to the user-interface timestamp change.
3492 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3493 for UI timestamps, instead of unsigned long.
3494 * msdos.c (mouse_get_pos): Likewise.
3495 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3496 * w32gui.h (Time): Define by including "systime.h" rather than by
3497 declaring it ourselves. (Bug#8664)
3499 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3500 * image.c (clear_image_cache): Likewise.
3502 * term.c (term_mouse_position): Don't assume time_t wraparound.
3504 Be more systematic about user-interface timestamps.
3505 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3506 and sometimes 'EMACS_UINT', to represent these timestamps.
3507 This change causes it to use 'Time' uniformly, as that's what X uses.
3508 This makes the code easier to follow, and makes it easier to catch
3509 integer overflow bugs such as Bug#8664.
3510 * frame.c (Fmouse_position, Fmouse_pixel_position):
3511 Use Time, not unsigned long, for user-interface timestamps.
3512 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3513 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3514 * keyboard.h (last_event_timestamp): Likewise.
3515 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3516 * menu.h (xmenu_show): Likewise.
3517 * term.c (term_mouse_position): Likewise.
3518 * termhooks.h (struct input_event.timestamp): Likewise.
3519 (struct terminal.mouse_position_hook): Likewise.
3520 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3521 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3522 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3523 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3525 * menu.h, termhooks.h: Include "systime.h", for Time.
3527 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3528 Don't assume that the difference between two unsigned long values
3529 can fit into an integer. At this point, we know button_down_time
3530 <= event->timestamp, so the difference must be nonnegative, so
3531 there's no need to cast the result if double-click-time is
3532 nonnegative, as it should be; check that it's nonnegative, just in
3533 case. This bug is triggered when events are more than 2**31 ms
3534 apart (about 25 days). (Bug#8664)
3536 * xselect.c (last_event_timestamp): Remove duplicate decl.
3537 (x_own_selection): Remove needless cast to unsigned long.
3539 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3540 that always fit in int. Use a sentinel instead of a counter, to
3541 avoid a temp and to allay GCC's concerns about possible int overflow.
3542 * frame.h (struct frame): Use int for menu_bar_items_used
3543 instead of EMACS_INT, since it always fits in int.
3545 * menu.c (grow_menu_items): Check for int overflow.
3547 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3549 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3550 Before, the code was not consistent. These values cannot exceed
3551 2**31 - 1 so there's no need to make them unsigned.
3552 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3553 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3554 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3556 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3558 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3559 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3560 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3561 presumably because the widths might not match.
3563 * window.c (size_window): Avoid needless test at loop start.
3565 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3567 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3569 2011-05-12 Drew Adams <drew.adams@oracle.com>
3571 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3573 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3575 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3576 `width' to `bar_area_x' and `bar_area_width', respectively.
3577 (x_scroll_run): Take account of fringe background extension.
3579 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3580 Rename local vars `left' and `width' to `bar_area_x' and
3581 `bar_area_width', respectively.
3582 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3583 background extension.
3585 2011-05-10 Jim Meyering <meyering@redhat.com>
3587 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3589 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3591 * image.c (Finit_image_library): Return t for built-in image types,
3592 like pbm and xbm. (Bug#8640)
3594 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3596 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3598 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3600 * w32console.c (Fset_screen_color): Doc fix.
3601 (Fget_screen_color): New function.
3602 (syms_of_ntterm): Defsubr it.
3604 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3605 unlink the temporary file if Fcall_process didn't create it in the
3607 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3608 child process will be redirected to a file specified with `:file'.
3609 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3610 cue to call_process_cleanup not to close that handle.
3612 2011-05-07 Ben Key <bkey76@gmail.com>
3614 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3615 one of two shell specific rules, either bootstrap-temacs-CMD or
3616 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3617 to the previous implementation of the bootstrap-temacs rule.
3618 The bootstrap-temacs-CMD rule is similar to the previous
3619 implementation of the bootstrap-temacs rule except that it
3620 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3623 These changes, along with some changes to nt/configure.bat,
3624 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3625 earlier fix to add support for --cflags and --ldflags options
3626 that include quotes so that it works whether make uses cmd or
3629 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3631 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3632 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3634 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3635 a string. Handle both cases.
3636 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3637 (Fdbus_register_method): Use Qinvalid_function.
3639 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3641 * makefile.w32-in: Update dependencies.
3642 (LISP_H): Add inttypes.h and stdin.h.
3643 (PROCESS_H): Add unistd.h.
3645 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3647 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3648 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3650 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3652 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3654 * term.c (vfatal): Remove stray call to va_end.
3655 It's not needed and the C Standard doesn't allow it here anyway.
3657 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3658 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3660 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3663 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3665 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3667 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3669 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3671 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3673 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3674 * charset.c (Fdefine_charset_internal): Don't initialize
3675 charset.code_space[15]. The value was garbage, on hosts with
3676 32-bit int (Bug#8600).
3678 * lread.c (read_integer): Be more consistent with string-to-number.
3679 Use string_to_number to do the actual conversion; this avoids
3680 rounding errors and fixes some other screwups. Without this fix,
3681 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3682 (digit_to_number): Move earlier, for benefit of read_integer.
3683 Return -1 if the digit is out of range for the base, -2 if it is
3684 not a digit in any supported base. (Bug#8602)
3686 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3688 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3689 to match comment at start of function. This also removes a
3690 GCC warning about overflow in a 32+64-bit port.
3692 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3694 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3695 Reported by Stefan Monnier in
3696 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3697 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3698 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3700 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3701 (EMACS_UINTPTR): Likewise, with uintptr_t.
3703 * lisp.h: Prefer 64-bit EMACS_INT if available.
3704 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3705 on 32-bit hosts that have 64-bit int, so that they can access
3707 However, temporarily disable this change unless the temporary
3708 symbol WIDE_EMACS_INT is defined.
3710 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3712 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3713 This removes an assumption that EMACS_INT and long are the same
3714 width as pointers. The assumption is true for Emacs porting targets
3715 now, but we want to make other targets possible.
3716 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3717 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3718 In the rest of the code, change types of integers that hold casted
3719 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3720 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3721 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3722 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3723 No need to cast type when ORing.
3724 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3725 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3726 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3727 assume EMACS_INT is the same width as char *.
3728 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3729 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3730 Remove no-longer-needed casts.
3731 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3732 (xg_tool_bar_help_callback, xg_make_tool_item):
3733 Use EMACS_INTPTR to hold an integer
3734 that will be cast to void *; this can avoid a GCC warning
3735 if EMACS_INT is not the same width as void *.
3736 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3737 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3738 (current_message_1, set_message_1):
3739 Use a local to convert to proper width without a cast.
3740 * xmenu.c (dialog_selection_callback): Likewise.
3742 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3743 Also, don't assume VALBITS / RAND_BITS is less than 5,
3744 and don't rely on undefined behavior when shifting a 1 left into
3746 * lisp.h (get_random): Change signature to match.
3748 * lread.c (hash_string): Use size_t, not int, for hash computation.
3749 Normally we prefer signed values; but hashing is special, because
3750 it's better to use unsigned division on hash table sizes so that
3751 the remainder is nonnegative. Also, size_t is the natural width
3752 for hashing into memory. The previous code used 'int', which doesn't
3753 retain enough info to hash well into very large tables.
3754 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3756 * dbusbind.c: Don't possibly lose pointer info when converting.
3757 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3758 Use XPNTR rather than XHASH, so that the high-order bits of
3759 the pointer aren't lost when converting through void *.
3761 * eval.c (Fautoload): Don't double-shift a pointer.
3763 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3765 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3767 * gnutls.c (DEF_GNUTLS_FN):
3768 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3770 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3772 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3775 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3777 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3778 New version that can reserve upto 2GB of heap space.
3780 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3782 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3784 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3786 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3787 `gnutls_certificate_set_x509_key_file'.
3789 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3791 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3792 Update dependencies.
3794 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3796 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3797 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3798 Remove unused parameter `fildes'.
3799 * process.c (read_process_output, send_process): Don't pass it.
3801 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3803 Fix previous change: the library cache is defined in w32.c.
3804 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3805 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3807 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3809 Implement dynamic loading of GnuTLS on Windows.
3811 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3812 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3813 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3816 * gnutls.c (Qgnutls_dll): Define.
3817 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3818 (gnutls_*): Declare function pointers.
3819 (init_gnutls_functions): New function to initialize function pointers.
3820 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3821 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3822 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3823 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3824 (emacs_gnutls_write, emacs_gnutls_read)
3825 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3826 (Fgnutls_available_p): New function.
3827 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3828 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3829 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3831 * image.c: Include w32.h.
3832 (Vimage_type_cache): Delete.
3833 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3834 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3835 (w32_delayed_load): Move to w32.c.
3837 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3839 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3840 (w32_delayed_load): Move from image.c. When loading a library, record
3841 its filename in the :loaded-from property of the library id.
3842 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3843 Initialize and staticpro them.
3844 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3846 * process.c: Include lisp.h before w32.h, not after.
3847 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3848 instead of gnutls_record_check_pending.
3850 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3852 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3854 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3855 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3858 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3860 * xterm.c (x_set_frame_alpha): Do not set property on anything
3861 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3863 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3865 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3867 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3869 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3870 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3871 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3872 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3873 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3874 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3875 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3876 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3877 (Qgnutls_bootprop_callbacks_verify): Make static.
3879 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3881 * callproc.c: Indentation fixup.
3883 * sysdep.c (wait_for_termination_1): Make static.
3884 (wait_for_termination, interruptible_wait_for_termination):
3885 Move after wait_for_termination_1.
3887 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3889 * sysdep.c (interruptible_wait_for_termination): New function
3890 which is like wait_for_termination, but allows keyboard
3893 * callproc.c (Fcall_process): Add (:file "file") as an option for
3895 (Fcall_process_region): Ditto.
3897 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3899 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3900 rather than `XVECTOR (FOO)->size'.
3902 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3903 inttypes.h, as a gnulib replacement is used if it not available in
3906 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3908 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3909 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3910 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3912 * coding.c (coding_alloc_by_realloc): Error out if destination
3913 will grow beyond MOST_POSITIVE_FIXNUM.
3914 (decode_coding_emacs_mule): Abort if there isn't enough place in
3915 charbuf for the composition carryover bytes. Reserve an extra
3916 space for up to 2 characters produced in a loop.
3917 (decode_coding_iso_2022): Abort if there isn't enough place in
3918 charbuf for the composition carryover bytes.
3920 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3922 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3923 aborting when %lld or %lll format is passed.
3924 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3925 %llo or %llx format is passed. (Bug#8545)
3927 * window.c (window_scroll_line_based): Use a marker instead of
3928 simple variables to record original value of point. (Bug#7952)
3930 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3931 produced by %s or %c overflows available buffer space. (Bug#8545)
3933 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3935 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3936 (SIZE_MAX): Move defn after all includes, as they might #define it.
3938 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3940 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3942 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3944 * keyboard.c (Qdelayed_warnings_hook): Define.
3945 (command_loop_1): Run `delayed-warnings-hook'
3946 if Vdelayed_warnings_list is non-nil.
3947 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3948 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3950 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3952 * doprnt.c (doprnt): Don't return value smaller than the buffer
3953 size if the message was truncated. (Bug#8545).
3955 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3957 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3958 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3960 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3962 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3964 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3966 * makefile.w32-in: Update dependencies.
3968 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3970 Improve `doprnt' and its usage. (Bug#8545)
3971 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3972 `format_end'. Remove support for %l as a conversion specifier.
3973 Don't use xrealloc. Improve diagnostics when the %l size modifier
3974 is used. Update the commentary.
3976 * eval.c (verror): Simplify calculation of size_t.
3978 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3981 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3983 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3986 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3988 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3989 This makes this file independent of the recent pseudovector change.
3991 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3993 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3995 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3996 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3997 Remove unused local.
3998 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4000 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4001 GCC 4.6.0 optimizes based on type-based alias analysis.
4002 For example, if b is of type struct buffer * and v of type struct
4003 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4004 != &v->size, and therefore "v->size = 1; b->size = 2; return
4005 v->size;" must therefore return 1. This assumption is incorrect
4006 for Emacs, since it type-puns struct Lisp_Vector * with many other
4007 types. To fix this problem, this patch adds a new type struct
4008 vectorlike_header that documents the constraints on layout of vectors
4009 and pseudovectors, and helps optimizing compilers not get fooled
4010 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4011 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4012 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4014 (XSETPVECTYPE): Rewrite in terms of new macro.
4015 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4016 This is a bit clearer, and further avoids the possibility of
4017 undesirable aliasing.
4018 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4019 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4020 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4021 since Lisp_Subr is a special case (no "next" field).
4022 (ASIZE): Now uses header.size rather than size.
4023 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4024 to avoid the hassle of writing XVECTOR (foo)->header.size.
4025 (struct vectorlike_header): New type.
4026 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4027 object, to help avoid aliasing.
4028 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4029 (SUBRP): Likewise, since Lisp_Subr is a special case.
4030 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4031 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4032 (struct Lisp_Hash_Table): Combine first two members into a single
4033 struct vectorlike_header member. All uses of "size" and "next" members
4034 changed to be "header.size" and "header.next".
4035 * buffer.h (struct buffer): Likewise.
4036 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4037 * frame.h (struct frame): Likewise.
4038 * process.h (struct Lisp_Process): Likewise.
4039 * termhooks.h (struct terminal): Likewise.
4040 * window.c (struct save_window_data, struct saved_window): Likewise.
4041 * window.h (struct window): Likewise.
4042 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4043 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4044 * buffer.c (init_buffer_once): Likewise.
4045 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4047 * process.c (Fformat_network_address): Use local var for size,
4050 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4052 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4053 * data.c (atof): Remove decl; no longer used or needed.
4054 (digit_to_number): Move to lread.c.
4055 (Fstring_to_number): Use new string_to_number function, to be
4056 consistent with how the Lisp reader treats infinities and NaNs.
4057 Do not assume that floating-point numbers represent EMACS_INT
4058 without losing information; this is not true on most 64-bit hosts.
4059 Avoid double-rounding errors, by insisting on integers when
4060 parsing non-base-10 numbers, as the documentation specifies.
4061 * lisp.h (string_to_number): New decl, replacing ...
4062 (isfloat_string): Remove.
4063 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4064 (read1): Do not accept +. and -. as integers; this
4065 appears to have been a coding error. Similarly, do not accept
4066 strings like +-1e0 as floating point numbers. Do not report
4067 overflow for integer overflows unless the base is not 10 which
4068 means we have no simple and reliable way to continue.
4069 Break out the floating-point parsing into a new
4070 function string_to_number, so that Fstring_to_number parses
4071 floating point numbers consistently with the Lisp reader.
4072 (digit_to_number): Move here from data.c. Make it static inline.
4073 (E_CHAR, EXP_INT): Remove, replacing with ...
4074 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4075 (string_to_number): New function, replacing isfloat_string.
4076 This function checks for valid syntax and produces the resulting
4077 Lisp float number too. Rework it so that string-to-number
4078 no longer mishandles examples like "1.0e+". Use strtoumax,
4079 so that overflow for non-base-10 numbers is reported only when
4080 there's no portable and simple way to convert to floating point.
4082 * textprop.c (set_text_properties_1): Rewrite for clarity,
4083 and to avoid GCC warning about integer overflow.
4085 * intervals.h (struct interval): Use EMACS_INT for members
4086 where EMACS_UINT might cause problems. See
4087 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4088 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4089 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4091 (offset_intervals): Tell GCC not to worry about length overflow
4092 when negating a negative length.
4094 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4095 (overrun_check_free): Likewise.
4097 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4098 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4101 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4102 (gnutls_make_error): Rename local to avoid shadowing.
4103 (gnutls_emacs_global_deinit): ifdef out; not used.
4104 (Fgnutls_boot): Use const for pointer to readonly storage.
4105 Comment out unused local. Fix pointer signedness problems.
4107 * lread.c (openp): Don't stuff size_t into an 'int'.
4108 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4109 about possible signed overflow.
4111 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4112 (GDK_KEY_g): Don't define if already defined.
4113 (xg_prepare_tooltip): Avoid pointer signedness problem.
4114 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4116 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4117 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4119 * xfns.c (Fx_window_property): Simplify a bit,
4120 to make a bit faster and to avoid GCC 4.6.0 warning.
4121 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4123 * fns.c (internal_equal): Don't assume size_t fits in int.
4125 * alloc.c (compact_small_strings): Tighten assertion a little.
4127 Replace pEd with more-general pI, and fix some printf arg casts.
4128 * lisp.h (pI): New macro, generalizing old pEd macro to other
4129 conversion specifiers. For example, use "...%"pI"d..." rather
4130 than "...%"pEd"...".
4131 (pEd): Remove. All uses replaced with similar uses of pI.
4132 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4133 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4134 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4135 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4136 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4137 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4138 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4140 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4141 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4142 * print.c (safe_debug_print, print_object): Likewise.
4143 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4145 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4146 avoiding the 0 flag, which is not portable.
4147 * process.c (Fmake_network_process): Use pI to avoid cast.
4148 * region-cache.c (pp_cache): Likewise.
4149 * xdisp.c (decode_mode_spec): Likewise.
4150 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4151 behavior on 64-bit hosts with printf arg.
4152 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4153 (x_stop_queuing_selection_requests): Likewise.
4154 (x_get_window_property): Don't truncate byte count to an 'int'
4157 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4158 here, since it parses constructs like leading '-' and spaces,
4159 which are not wanted; and it overflows with large numbers.
4160 Instead, simply match F[0-9]+, which is what is wanted anyway.
4162 * alloc.c: Remove unportable assumptions about struct layout.
4163 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4164 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4165 (allocate_vectorlike, make_pure_vector): Use the new macros,
4166 plus offsetof, to remove unportable assumptions about struct layout.
4167 These assumptions hold on all porting targets that I know of, but
4168 they are not guaranteed, they're easy to remove, and removing them
4169 makes further changes easier.
4171 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4172 This doesn't fix a bug but makes the code clearer.
4173 (string_overrun_cookie): Now const. Use initializers that
4174 don't formally overflow signed char, to avoid warnings.
4175 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4176 can cause Emacs to crash when string overrun checking is enabled.
4177 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4178 multiple of sizeof (EMACS_INT); it need not be, if
4179 alignof(EMACS_INT) < sizeof (EMACS_INT).
4180 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4182 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4184 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4186 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4188 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4189 supposed to be handshaking. (Bug#8556)
4190 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4192 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4194 * lisp.h (Qdebug): List symbol.
4195 * eval.c (Qdebug): Restore global linkage.
4196 * keyboard.c (debug-on-event): New variable.
4197 (handle_user_signal): Break into debugger when debug-on-event
4198 matches the current signal symbol.
4200 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4202 * alloc.c (check_sblock, check_string_bytes)
4203 (check_string_free_list): Convert to standard C.
4205 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4207 * w32.c (emacs_gnutls_push): Fix typo.
4209 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4211 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4212 "cast to pointer from integer of different size".
4214 Improve doprnt and its use in verror. (Bug#8545)
4215 * doprnt.c (doprnt): Document the set of format control sequences
4216 supported by the function. Use SAFE_ALLOCA instead of always
4219 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4220 is one byte too soon. Don't use xrealloc; instead xfree and
4223 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4225 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4228 * gnutls.c: Renamed global_initialized to
4229 gnutls_global_initialized. Added internals for the
4230 :verify-hostname-error, :verify-error, and :verify-flags
4231 parameters of `gnutls-boot' and documented those parameters in the
4232 docstring. Start callback support.
4233 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4234 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4235 on error. Return error code.
4236 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4237 (emacs_gnutls_read): Likewise.
4238 (Fgnutls_boot): Return handshake error code.
4239 (emacs_gnutls_handle_error): New function.
4240 (wsaerror_to_errno): Likewise.
4242 * w32.h (emacs_gnutls_pull): Add prototype.
4243 (emacs_gnutls_push): Likewise.
4245 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4246 (emacs_gnutls_push): Likewise.
4248 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4250 * process.c (wait_reading_process_output): Check if GnuTLS
4251 buffered some data internally if no FDs are set for TLS
4254 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4255 (LIBS): Link to USER_LIBS.
4256 ($(BLD)/gnutls.$(0)): New target.
4258 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4260 * xdisp.c (handle_single_display_spec): Rename the
4261 display_replaced_before_p argument into display_replaced_p, to
4262 make it consistent with the commentary. Fix typos in the
4265 * textprop.c (syms_of_textprop): Remove dead code.
4266 (copy_text_properties): Delete obsolete commentary about an
4267 interface that was deleted long ago. Fix typos in the description
4270 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4271 to changes in oldXMenu/XMenu.h from 2011-04-16.
4272 <menu_help_message, prev_menu_help_message>: Constify.
4273 (IT_menu_make_room): menu->help_text is now `const char **';
4276 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4277 to changes in oldXMenu/XMenu.h from 2011-04-16.
4278 (struct XMenu): Declare `help_text' `const char **'.
4280 * xfaces.c <Qunspecified>: Make extern again.
4282 * syntax.c: Include sys/types.h before including regex.h, as
4285 * doc.c (get_doc_string): Improve the format passed to `error'.
4287 * doprnt.c (doprnt): Improve commentary.
4289 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4291 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4294 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4295 changes in globals.h immediately force recompilation.
4296 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4297 $(CURDIR)/s/ms-w32.h.
4298 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4300 * character.c (Fchar_direction): Function deleted.
4301 (syms_of_character): Don't defsubr it.
4302 <char-direction-table>: Deleted.
4304 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4306 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4307 * doprnt.c: Include limits.h.
4308 (SIZE_MAX): New macro.
4309 (doprnt): Return a size_t value. 2nd arg is now size_t.
4310 Many local variables are now size_t instead of int or unsigned.
4311 Improve overflow protection. Support `l' modifier for integer
4312 conversions. Support %l conversion. Don't assume an EMACS_INT
4313 argument for integer conversions and for %c.
4315 * lisp.h (doprnt): Restore prototype.
4317 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4320 * Makefile.in (base_obj): Add back doprnt.o.
4322 * deps.mk (doprnt.o): Add back prerequisites.
4323 (callint.o): Depend on character.h.
4325 * eval.c (internal_lisp_condition_case): Include the handler
4326 representation in the error message.
4327 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4328 when breaking from the loop.
4330 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4332 * callint.c (Fcall_interactively): When displaying error message
4333 about invalid control letter, pass the character's codepoint, not
4334 a pointer to its multibyte form. Improve display of the character
4335 in octal and display also its hex code.
4337 * character.c (char_string): Use %x to display the (unsigned)
4338 codepoint of an invalid character, to avoid displaying a bogus
4341 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4342 `error', not SYMBOL_NAME itself.
4344 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4345 character arguments to `error'.
4347 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4348 to `error' in error message about FINAL_CHAR argument. Make sure
4349 FINAL_CHAR is a character, and use %c when it is passed as
4350 argument to `error'.
4352 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4354 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4356 * w32.c: Include <time.h>.
4357 (sys_localtime): New function.
4359 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4361 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4363 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4365 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4367 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4370 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4372 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4373 gl_state.e_property when gl_state.object is Qt.
4375 * insdel.c (make_gap_larger): Remove limitation of buffer size
4378 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4380 * xdisp.c (lookup_glyphless_char_display)
4381 (produce_glyphless_glyph): Handle cons cell entry in
4382 glyphless-char-display.
4383 (Vglyphless_char_display): Document it.
4385 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4386 glyphless-char-display.
4388 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4390 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4392 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4394 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4395 definition for no-X builds.
4397 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4399 Static checks with GCC 4.6.0 and non-default toolkits.
4401 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4403 * process.c (keyboard_bit_set): Define only if SIGIO.
4404 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4405 (send_process): Repair possible setjmp clobbering.
4407 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4409 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4411 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4413 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4414 Define only if needed.
4416 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4417 by pacifying GCC about it. Maybe it's time to retire it?
4418 * xfaces.c (USG, __TIMEVAL__): Likewise.
4420 * dispextern.h (struct redisplay_interface): Rename param
4422 * termhooks.h (struct terminal): Likewise.
4423 * xterm.c (xembed_send_message): Likewise.
4425 * insdel.c (make_gap_smaller): Define only if
4426 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4428 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4431 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4432 so that we aren't warned about unused symbols.
4434 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4436 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4438 * xfns.c (x_real_positions): Mark locals as initialized.
4440 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4442 * xterm.c: Fix problems found by static analysis with other toolkits.
4443 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4444 (x_dispatch_event): Declare static if USE_GTK, and
4445 define if USE_GTK || USE_X_TOOLKIT.
4446 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4447 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4448 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4449 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4451 * xmenu.c (menu_help_callback): Pointer type fixes.
4452 Use const pointers when pointing at readonly data. Avoid pointer
4454 (FALSE): Remove unused macro.
4455 (update_frame_menubar): Remove unused decl.
4457 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4459 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4460 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4461 (single_menu_item): Rename local to avoid shadowing.
4463 * keyboard.c (make_lispy_event): Remove unused local var.
4465 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4466 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4468 * bitmaps: Change bitmaps from unsigned char back to the X11
4469 compatible char. Avoid the old compiler warnings about
4470 out-of-range initializers by using, for example, '\xab' rather
4473 * xgselect.c (xgselect_initialize): Check vs interface
4474 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4476 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4478 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4479 to read-only memory.
4481 * fns.c (vector): Remove; this old hack is no longer needed.
4483 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4485 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4487 * xrdb.c (x_load_resources): Omit unused local.
4489 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4490 (x_window): Rename locals to avoid shadowing.
4491 (USG): Use the kludged USG macro, to pacify gcc.
4493 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4494 (x_term_init): Remove local to avoid shadowing.
4496 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4498 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4499 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4501 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4503 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4505 Fix regex.c, syntax.c and friends for buffers > 2GB.
4506 * syntax.h (struct gl_state_s): Declare character position members
4509 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4511 * textprop.c (verify_interval_modification, interval_of):
4512 Declare arguments EMACS_INT.
4514 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4517 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4519 * indent.c (Fvertical_motion): Local variable it_start is now
4522 * regex.c (re_match, re_match_2, re_match_2_internal)
4523 (bcmp_translate, regcomp, regexec, print_double_string)
4524 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4525 (re_compile_pattern, re_exec): Declare arguments and local
4526 variables `size_t' and `ssize_t' and return values `regoff_t', as
4528 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4529 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4530 <compile_stack_type>: `size' and `avail' are now `size_t'.
4532 * regex.h <regoff_t>: Use ssize_t, not int.
4533 (re_search, re_search_2, re_match, re_match_2): Arguments that
4534 specify buffer/string position and length are now ssize_t and
4535 size_t. Return type is regoff_t.
4537 2011-04-16 Ben Key <bkey76@gmail.com>
4539 * nsfont.m: Fixed bugs in ns_get_family and
4540 ns_descriptor_to_entity that were caused by using free to
4541 deallocate memory blocks that were allocated by xmalloc (via
4542 xstrdup). This caused Emacs to crash when compiled with
4543 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4544 --enable-checking=xmallocoverrun). xfree is now used to
4545 deallocate these memory blocks.
4547 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4549 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4551 emacs_write: Accept and return EMACS_INT for sizes.
4552 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4554 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4555 Accept and return EMACS_INT.
4556 (emacs_gnutls_write): Return the number of bytes written on
4558 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4559 (emacs_read, emacs_write): Remove check for negative size, as the
4560 Emacs source code has been audited now.
4561 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4562 (emacs_read, emacs_write): Use it.
4563 * process.c (send_process): Adjust to the new signatures of
4564 emacs_write and emacs_gnutls_write. Do not attempt to store
4565 a byte offset into an 'int'; it might overflow.
4566 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4568 * sound.c: Don't assume sizes fit in 'int'.
4569 (struct sound_device.period_size, alsa_period_size):
4570 Return EMACS_INT, not int.
4571 (struct sound_device.write, vox_write, alsa_write):
4572 Accept EMACS_INT, not int.
4573 (wav_play, au_play): Use EMACS_INT to store sizes and to
4574 record read return values.
4576 2011-04-15 Ben Key <bkey76@gmail.com>
4578 * keyboard.c (Qundefined): Don't declare static since it is used
4580 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4581 static since they are used in nsfont.m.
4583 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4585 * process.c (Qprocessp): Don't declare static.
4586 * lisp.h (Qprocessp): Declare again.
4588 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4590 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4592 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4594 Improve C-level modularity by making more things 'static'.
4596 Don't publish debugger-only interfaces to other modules.
4597 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4598 (verify_bytepos, count_markers): Move decls to the only modules
4600 * region-cache.h (pp_cache): Likewise.
4601 * window.h (check_all_windows): Likewise.
4602 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4604 * sysdep.c (croak): Now static, if
4605 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4606 * syssignal.h (croak): Declare only if not static.
4608 * alloc.c (refill_memory_reserve): Now static if
4609 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4610 * lisp.h (refill_memory_reserve): Declare only if not static.
4612 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4613 Define only if USE_LUCID.
4615 * xrdb.c (x_customization_string, x_rm_string): Now static.
4617 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4618 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4620 * xdisp.c (draw_row_with_mouse_face): Now static.
4621 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4623 * window.h (check_all_windows): Mark externally visible.
4625 * window.c (window_deletion_count): Now static.
4627 * undo.c: Make symbols static if they're not exported.
4628 (last_undo_buffer, last_boundary_position, pending_boundary):
4631 * textprop.c (interval_insert_behind_hooks): Now static.
4632 (interval_insert_in_front_hooks): Likewise.
4634 * term.c: Make symbols static if they're not exported.
4635 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4636 (max_frame_lines, tty_set_terminal_modes):
4637 (tty_reset_terminal_modes, tty_turn_off_highlight):
4638 (get_tty_terminal): Now static.
4639 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4640 * termhooks.h (term_mouse_moveto): Do not declare if
4642 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4643 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4645 * sysdep.c: Make symbols static if they're not exported.
4646 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4648 (sigprocmask_set, full_mask): Remove; unused.
4649 (wait_debugging): Mark as visible.
4650 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4651 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4653 * syntax.c (syntax_temp): Define only if !__GNUC__.
4655 * sound.c (current_sound_device, current_sound): Now static.
4657 * search.c (searchbufs, searchbuf_head): Now static.
4659 * scroll.c (scroll_cost): Remove; unused.
4660 * dispextern.h (scroll_cost): Remove decl.
4662 * region-cache.h (pp_cache): Mark as externally visible.
4664 * process.c: Make symbols static if they're not exported.
4665 (process_tick, update_tick, create_process, chan_process):
4666 (Vprocess_alist, proc_buffered_char, datagram_access):
4667 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4668 (deactivate_process): Mark defn as static, as well as decl.
4669 * lisp.h (create_process): Remove decl.
4670 * process.h (chan_process, Vprocess_alist): Remove decls.
4672 * print.c: Make symbols static if they're not exported.
4673 (print_depth, new_backquote_output, being_printed, print_buffer):
4674 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4675 (print_interval, print_number_index, initial_stderr_stream):
4677 * lisp.h (Fprinc): Remove decl.
4678 (debug_output_compilation_hack): Mark as externally visible.
4680 * sysdep.c (croak): Move decl from here to syssignal.h.
4681 * syssignal.h (croak): Put it here, so the API can be checked when
4682 'croak' is called from dissociate_if_controlling_tty.
4684 * minibuf.c: Make symbols static if they're not exported.
4685 (minibuf_save_list, choose_minibuf_frame): Now static.
4686 * lisp.h (choose_minibuf_frame): Remove decl.
4688 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4690 * lread.c: Make symbols static if they're not exported.
4691 (read_objects, initial_obarray, oblookup_last_bucket_number):
4693 (make_symbol): Remove; unused.
4694 * lisp.h (initial_obarray, make_symbol): Remove decls.
4696 * keyboard.c: Make symbols static if they're not exported.
4697 (single_kboard, recent_keys_index, total_keys, recent_keys):
4698 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4699 (this_single_command_key_start, echoing, last_auto_save):
4700 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4701 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4702 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4703 (Vlispy_mouse_stem, double_click_count):
4705 (force_auto_save_soon): Define only if SIGDANGER.
4706 (ignore_mouse_drag_p): Now static if
4707 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4708 (print_help): Remove; unused.
4709 (stop_character, last_timer_event): Mark as externally visible.
4710 * keyboard.h (ignore_mouse_drag_p): Declare only if
4711 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4712 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4713 * lisp.h (echoing): Remove decl.
4714 (force_auto_save_soon): Declare only if SIGDANGER.
4715 * xdisp.c (redisplay_window): Simplify code, to make it more
4716 obvious that ignore_mouse_drag_p is not accessed if !defined
4717 USE_GTK && !defined HAVE_NS.
4719 * intervals.c: Make symbols static if they're not exported.
4720 (merge_properties_sticky, merge_interval_right, delete_interval):
4722 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4724 * insdel.c: Make symbols static if they're not exported.
4725 However, leave prepare_to_modify_buffer alone. It's never
4726 called from outside this function, but that appears to be a bug.
4727 (combine_after_change_list, combine_after_change_buffer):
4728 (adjust_after_replace, signal_before_change): Now static.
4729 (adjust_after_replace_noundo): Remove; unused.
4730 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4731 (signal_before_change): Remove decls.
4733 * indent.c (val_compute_motion, val_vmotion): Now static.
4735 * image.c: Make symbols static if they're not exported.
4736 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4738 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4739 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4741 * fringe.c (standard_bitmaps): Now static.
4742 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4744 * frame.c: Make symbols static if they're not exported.
4745 (x_report_frame_params, make_terminal_frame): Now static.
4746 (get_frame_param): Now static, unless HAVE_NS.
4747 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4748 (x_get_resource_string): Remove; not used.
4749 * frame.h (make_terminal_frame, x_report_frame_params):
4750 (x_get_resource_string); Remove decls.
4751 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4752 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4754 * font.c, fontset.c: Make symbols static if they're not exported.
4755 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4756 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4757 * font.c (font_close_object): Now static.
4758 * font.h (font_close_object): Remove.
4759 * fontset.c (FONTSET_OBJLIST): Remove.
4760 (free_realized_fontset) #if-0 the body, which does nothing.
4761 (face_suitable_for_char_p): #if-0, as it's never called.
4762 * fontset.h (face_suitable_for_char_p): Remove decl.
4763 * xfaces.c (face_at_string_position):
4764 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4765 since 0 is always ASCII.
4767 * fns.c (weak_hash_tables): Now static.
4769 * fileio.c: Make symbols static if they're not exported.
4770 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4771 (Vwrite_region_annotation_buffers): Now static.
4773 * eval.c: Make symbols static if they're not exported.
4774 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4775 * lisp.h (backtrace_list): Remove decl.
4777 * emacs.c: Make symbols static if they're not exported.
4778 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4779 (fatal_error_code, fatal_error_signal_hook, standard_args):
4781 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4782 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4783 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4784 * lisp.h (fatal_error_signal_hook): Remove decl.
4785 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4787 * editfns.c: Move a (normally-unused) function to its only use.
4788 * editfns.c, lisp.h (get_operating_system_release): Remove.
4789 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4790 worth the hassle of breaking this out.
4792 * xterm.c: Make symbols static if they're not exported.
4793 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4794 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4795 (x_destroy_window, x_delete_display):
4797 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4798 (x_mouse_leave): Remove; unused.
4799 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4800 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4801 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4803 (x_mouse_leave): Declare only if WINDOWSNT.
4804 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4805 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4808 * ftxfont.c: Make symbols static if they're not exported.
4809 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4811 * font.h (ftxfont_driver): Likewise.
4813 * xfns.c: Make symbols static if they're not exported.
4814 (x_last_font_name, x_display_info_for_name):
4815 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4816 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4817 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4818 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4819 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4820 (last_show_tip_args): Now static.
4821 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4822 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4823 (x_screen_planes): Remove; unused.
4824 * dispextern.h (x_screen_planes): Remove decl.
4826 * dispnew.c: Make symbols static if they're not exported.
4827 * dispextern.h (redraw_garbaged_frames, scrolling):
4828 (increment_row_positions): Remove.
4829 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4830 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4832 (redraw_garbaged_frames): Remove; unused.
4834 * xfaces.c: Make symbols static if they're not exported.
4835 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4837 * xterm.h (defined_color): Remove decls.
4838 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4839 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4840 (menu_face_changed_default, defined_color, free_realized_face):
4841 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4842 (ascii_face_of_lisp_face): Remove; unused.
4844 * xdisp.c: Make symbols static if they're not exported.
4845 * dispextern.h (scratch_glyph_row, window_box_edges):
4846 (glyph_to_pixel_coords, set_cursor_from_row):
4847 (get_next_display_element, set_iterator_to_next):
4848 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4849 (show_mouse_face): Remove decls
4850 * frame.h (message_buf_print): Likewise.
4851 * lisp.h (pop_message, set_message, check_point_in_composition):
4853 * xterm.h (set_vertical_scroll_bar): Likewise.
4854 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4855 (message_buf_print, scratch_glyph_row, displayed_buffer):
4856 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4857 (get_next_display_element, show_mouse_face, window_box_edges):
4858 (frame_to_window_pixel_xy, check_point_in_composition):
4859 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4860 (glyph_to_pixel_coords): Remove; unused.
4862 * dired.c (file_name_completion): Now static.
4864 * dbusbind.c (xd_in_read_queued_messages): Now static.
4866 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4867 * data.c (circular_list_error): Remove.
4869 * commands.h (last_point_position, last_point_position_buffer):
4870 (last_point_position_window): Remove decls.
4871 * keyboard.c: Make these variables static.
4873 * coding.h (coding, code_convert_region, encode_coding_gap):
4875 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4876 (iso_code_class, detect_coding, code_convert_region): Now static.
4877 (encode_coding_gap): Remove; unused.
4879 * chartab.c (chartab_chars, chartab_bits): Now static.
4881 * charset.h (charset_iso_8859_1): Remove decl.
4882 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4885 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4886 * ccl.c (Vccl_program_table): Now static.
4887 (check_ccl_update): Remove; unused.
4889 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4890 * category.h: ... from here.
4891 * category.c (check_category_table, set_category_set): Now static.
4893 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4894 * lisp.h: Remove these decls.
4896 * buffer.c (buffer_count): Remove unused var.
4898 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4899 so that it's not optimized away.
4900 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4901 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4902 exported only to the debugger.
4904 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4905 * atimer.h (run_all_atimers): Remove; not exported.
4907 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4908 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4909 was inaccessible from Lisp.
4910 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4911 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4913 alloc.c: Import and export fewer symbols, and remove unused items.
4914 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4916 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4917 it's not optimized away by whole-program optimization.
4918 (message_enable_multibyte, free_misc): Remove.
4919 (catchlist, handlerlist, mark_backtrace):
4920 Declare only if BYTE_MARK_STACK.
4921 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4922 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4923 (message_enable_multibyte): Remove decl.
4924 (free_misc, interval_free_list, float_block, float_block_index):
4925 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4926 (cons_free_list, last_marked_index):
4928 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4929 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4930 (mark_backtrace): Define only if BYTE_MARK_STACK.
4931 * xdisp.c (message_enable_multibyte): Now static.
4933 Declare Lisp_Object Q* variables to be 'static' if not exported.
4934 This makes it easier for human readers (and static analyzers)
4935 to see whether these variables are used from other modules.
4936 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4937 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4938 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4939 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4940 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4941 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4942 * xmenu.c, xselect.c:
4943 Declare Q* vars static if they are not used in other modules.
4944 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4945 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4946 Remove decls of unexported vars.
4947 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4949 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4951 Make Emacs functions such as Fatom 'static' by default.
4952 This makes it easier for human readers (and static analyzers)
4953 to see whether these functions can be called from other modules.
4954 DEFUN now defines a static function. To make the function external
4955 so that it can be used in other C modules, use the new macro DEFUE.
4956 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4957 (Finit_image_library):
4958 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4959 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4960 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4961 Remove decls, since these functions are now static.
4962 (Funintern, Fget_internal_run_time): New decls, since these functions
4963 were already external.
4965 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4966 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4967 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4968 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4969 * keyboard.c, keymap.c, lread.c:
4970 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4971 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4972 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4973 Mark functions with DEFUE instead of DEFUN,
4974 if they are used in other modules.
4975 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4976 decls for now-static functions.
4977 * buffer.h (Fdelete_overlay): Remove decl.
4978 * callproc.c (Fgetenv_internal): Mark as internal.
4979 * composite.c (Fremove_list_of_text_properties): Remove decl.
4980 (Fcomposition_get_gstring): New forward static decl.
4981 * composite.h (Fcomposite_get_gstring): Remove decl.
4982 * dired.c (Ffile_attributes): New forward static decl.
4983 * doc.c (Fdocumntation_property): New forward static decl.
4984 * eval.c (Ffetch_bytecode): New forward static decl.
4985 (Funintern): Remove extern decl; now in .h file where it belongs.
4986 * fileio.c (Fmake_symbolic_link): New forward static decl.
4987 * image.c (Finit_image_library): New forward static decl.
4988 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4989 * intervals.h (Fprevious_property_change):
4990 (Fremove_list_of_text_properties): Remove decls.
4991 * keyboard.c (Fthis_command_keys): Remove decl.
4992 (Fcommand_execute): New forward static decl.
4993 * keymap.c (Flookup_key): New forward static decl.
4994 (Fcopy_keymap): Now static.
4995 * keymap.h (Flookup_key): Remove decl.
4996 * process.c (Fget_process): New forward static decl.
4997 (Fprocess_datagram_address): Mark as internal.
4998 * syntax.c (Fsyntax_table_p): New forward static decl.
4999 (skip_chars): Remove duplicate decl.
5000 * textprop.c (Fprevious_property_change): New forward static decl.
5001 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5003 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5004 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5006 * editfns.c (Fformat): Remove unreachable code.
5008 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5010 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5013 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5015 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5016 when at ZV. (Bug#8487)
5018 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5020 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5022 * keyboard.c (parse_tool_bar_item): Likewise.
5023 * sound.c (sound_cleanup, alsa_close): Likewise.
5024 * termcap.c (tgetent): Likewise.
5025 * xfns.c (x_default_font_parameter): Likewise.
5026 * xsettings.c (read_and_apply_settings): Likewise.
5028 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5029 (overrun_check_free): Protoize.
5031 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5033 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5034 since callers should never pass a negative size.
5035 Change the signature to match that of plain 'read' and 'write'; see
5036 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5037 * lisp.h: Update prototypes of emacs_write and emacs_read.
5039 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5041 * xdisp.c (redisplay_window): Don't try to determine the character
5042 position of the scroll margin if the window start point w->startp
5043 is outside the buffer's accessible region. (Bug#8468)
5045 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5047 Fix write-region and its subroutines for buffers > 2GB.
5048 * fileio.c (a_write, e_write): Modify declaration of arguments and
5049 local variables to support buffers larger than 2GB.
5050 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5052 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5053 argument, local variables, and return value.
5055 * lisp.h: Update prototypes of emacs_write and emacs_read.
5057 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5059 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5061 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5063 Fix more problems found by GCC 4.6.0's static checks.
5065 * xdisp.c (vmessage): Use a better test for character truncation.
5067 * charset.c (load_charset_map): <, not <=, for optimization,
5068 and to avoid potential problems with integer overflow.
5069 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5070 * casetab.c (set_identity, shuffle): Likewise.
5071 * editfns.c (Fformat): Likewise.
5072 * syntax.c (skip_chars): Likewise.
5074 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5075 This also lets GCC 4.6.0 generate slightly better loop code.
5077 * callint.c (Fcall_interactively): <, not <=, for optimization.
5078 (Fcall_interactively): Count the number of arguments produced,
5079 not the number of arguments given. This is simpler and lets GCC
5080 4.6.0 generate slightly better code.
5082 * ftfont.c: Distingish more carefully between FcChar8 and char.
5083 The previous code passed unsigned char * to a functions like
5084 strlen and xstrcasecmp that expect char *, which does not
5085 conform to the C standard.
5086 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5087 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5088 char * when the C standard requires it.
5090 * keyboard.c (read_char): Remove unused var.
5092 * eval.c: Port to Windows vsnprintf (Bug#8435).
5094 (SIZE_MAX): Define if the headers do not.
5095 (verror): Do not give up if vsnprintf returns a negative count.
5096 Instead, grow the buffer. This ports to Windows vsnprintf, which
5097 does not conform to C99. Problem reported by Eli Zaretskii.
5098 Also, simplify the allocation scheme, by avoiding the need for
5099 calling realloc, and removing the ALLOCATED variable.
5101 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5103 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5104 But keep the doprint source code for now, as we might revamp it
5105 and use it again (Bug#8435).
5106 * lisp.h (doprnt): Remove.
5107 * Makefile.in (base_obj): Remove doprnt.o.
5108 * deps.mk (doprnt.o): Remove.
5110 error: Print 32- and 64-bit integers portably (Bug#8435).
5111 Without this change, on typical 64-bit hosts error ("...%d...", N)
5112 was used to print both 32- and 64-bit integers N, which relied on
5114 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5116 * lisp.h (error, verror): Mark as printf-like functions.
5117 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5118 Report overflow in size calculations when allocating printf buffer.
5119 Do not truncate output string at its first null byte.
5120 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5121 Truncate the output at a character boundary, since vsnprintf does not
5123 * charset.c (check_iso_charset_parameter): Convert internal
5124 character to string before calling 'error', since %c now has the
5126 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5127 overflow when computing char to be passed to 'error'. Do not
5128 pass Lisp_Object to 'error'; pass the integer instead.
5129 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5130 formatted with plain %d.
5132 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5134 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5136 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5138 * xterm.c (x_catch_errors): Remove duplicate declaration.
5140 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5142 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5144 2011-04-10 Jim Meyering <meyering@redhat.com>
5146 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5147 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5148 return ssize_t not "int", and use size_t as the buffer length.
5149 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5150 * gnutls.h: Update declarations.
5151 * process.c (read_process_output): Use ssize_t, to match.
5152 (send_process): Likewise.
5154 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5156 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5158 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5160 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5161 Use unsigned char, to match FcChar8 type definition.
5163 * xterm.c (handle_one_xevent):
5164 * xmenu.c (create_and_show_popup_menu):
5165 * xselect.c (x_decline_selection_request)
5166 (x_reply_selection_request): Avoid type-punned deref of X events.
5168 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5170 Fix some uses of `int' instead of EMACS_INT.
5171 * search.c (string_match_1, fast_string_match)
5172 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5173 (scan_buffer, find_next_newline_no_quit)
5174 (find_before_next_newline, search_command, Freplace_match)
5175 (Fmatch_data): Make some `int' variables be EMACS_INT.
5177 * xdisp.c (display_count_lines): 3rd argument and return value now
5178 EMACS_INT. All callers changed.
5179 (pint2hrstr): Last argument is now EMACS_INT.
5181 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5182 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5183 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5184 (decode_coding_utf_16, decode_coding_emacs_mule)
5185 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5186 (decode_coding_ccl, decode_coding_charset)
5187 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5188 (decode_coding_iso_2022, decode_coding_emacs_mule)
5189 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5190 <char_offset, last_offset>: Declare EMACS_INT.
5191 (encode_coding_utf_8, encode_coding_utf_16)
5192 (encode_coding_emacs_mule, encode_invocation_designation)
5193 (encode_designation_at_bol, encode_coding_iso_2022)
5194 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5195 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5197 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5198 (encode_invocation_designation): Last argument P_NCHARS is now
5200 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5201 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5203 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5206 * ccl.c (Fccl_execute_on_string): Declare some variables
5209 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5211 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5213 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5215 * process.c (Fformat_network_address): Doc fix.
5217 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5219 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5221 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5223 * keyboard.c (read_char): Call Lisp function help-form-show,
5224 instead of using internal_with_output_to_temp_buffer.
5225 (Qhelp_form_show): New var.
5226 (syms_of_keyboard): Use DEFSYM macro.
5228 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5230 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5232 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5234 * process.c (Flist_processes): Remove to Lisp.
5235 (list_processes_1): Delete.
5237 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5239 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5241 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5243 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5245 Fix more problems found by GCC 4.6.0's static checks.
5247 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5249 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5251 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5253 * xdisp.c (vmessage): Mark as a printf-like function.
5255 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5257 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5259 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5260 printf-like functions.
5261 (tiff_load): Add casts to remove these marks before passing them
5262 to system-supplied API.
5264 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5266 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5267 This avoids several warnings with gcc -Wstrict-overflow.
5268 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5269 directly, rather than having caller test rule sign. This avoids
5270 some unnecessary tests.
5271 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5272 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5273 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5275 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5276 (xfont_open): Avoid unnecessary tests.
5278 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5280 * composite.h, composite.c (composition_gstring_put_cache):
5281 Use EMACS_INT, not int, for length.
5283 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5284 breaking out part of COMPOSITION_DECODE_RULE.
5285 (COMPOSITION_DECODE_RULE): Use it.
5286 * composite.c (get_composition_id): Remove unused local vars,
5287 by using the new macro.
5289 * textprop.c (set_text_properties_1): Change while to do-while,
5290 since the condition is always true at first.
5292 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5293 (interval_deletion_adjustment): Return unsigned value.
5296 * process.c (list_processes_1, create_pty, read_process_output):
5297 (exec_sentinel): Remove vars that were set but not used.
5298 (create_pty): Remove unnecessary "volatile"s.
5299 (Fnetwork_interface_info): Avoid possibility of int overflow.
5300 (read_process_output): Do adaptive read buffering even if carryover.
5301 (read_process_output): Simplify nbytes computation if buffered.
5303 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5305 * syntax.c (scan_words): Remove var that was set but not used.
5306 (update_syntax_table): Use unsigned instead of int.
5308 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5309 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5310 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5312 * print.c (print_error_message): Avoid int overflow.
5314 * font.c (font_list_entities): Redo for clarity,
5315 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5317 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5318 (font_score): Avoid potential overflow in diff calculation.
5320 * fns.c (substring_both): Remove var that is set but not used.
5321 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5323 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5325 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5326 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5327 can always succeed if overflow has undefined behavior.
5329 * search.c (boyer_moore, wordify): Remove vars set but not used.
5330 (wordify): Omit three unnecessary tests.
5332 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5333 All callers changed. This avoids the need for an unused var.
5335 * casefiddle.c (casify_region): Remove var that is set but not used.
5337 * dired.c (file_name_completion): Remove var that is set but not used.
5339 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5341 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5342 (Finsert_file_contents): Remove unnecessary code checking fd.
5344 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5345 Check for integer overflow on size calculations.
5347 * buffer.c (Fprevious_overlay_change): Remove var that is set
5350 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5351 Remove vars that are set but not used.
5352 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5353 (timer_check_2): Mark vars as initialized.
5355 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5357 * image.c (lookup_image): Remove var that is set but not used.
5358 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5360 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5361 that are set but not used.
5363 * xfns.c (make_invisible_cursor): Don't return garbage
5364 if XCreateBitmapFromData fails (Bug#8410).
5366 * xselect.c (x_get_local_selection, x_handle_property_notify):
5367 Remove vars that are set but not used.
5369 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5370 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5372 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5373 Remove var that is set but not used.
5374 (scroll_bar_windows_size): Now size_t, not int.
5375 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5378 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5379 (map_tty_color) [!defined MSDOS]: Likewise.
5381 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5383 * coding.c: Remove vars that are set but not used.
5384 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5385 All callers changed.
5386 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5387 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5388 (decode_coding_charset): Remove vars that are set but not used.
5390 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5391 that is set but not used.
5393 * print.c (print_object): Remove var that is set but not used.
5395 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5396 The gnulib version avoids calling malloc in the usual case,
5397 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5398 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5399 * filelock.c (current_lock_owner): Likewise.
5400 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5401 * sysdep.c: Include allocator.h, careadlinkat.h.
5402 (emacs_no_realloc_allocator): New static constant.
5403 (emacs_readlink): New function.
5404 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5405 ../lib/careadlinkat.h.
5407 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5409 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5410 first non-nil return value).
5412 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5414 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5415 if not defined (Bug#8403).
5417 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5419 * xdisp.c (display_count_lines): Remove parameter `start',
5420 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5421 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5422 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5423 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5424 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5425 and thereabouts. All callers changed.
5426 (get_per_char_metric): Remove parameter `f', unused since
5427 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5429 2011-04-02 Jim Meyering <meyering@redhat.com>
5431 do not dereference NULL upon failed strdup
5432 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5433 (ns_get_family): Likewise.
5435 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5437 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5439 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5441 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5444 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5446 Add lexical binding.
5448 * window.c (Ftemp_output_buffer_show): New fun.
5449 (Fsave_window_excursion):
5450 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5452 * lread.c (lisp_file_lexically_bound_p): New function.
5453 (Fload): Bind Qlexical_binding.
5454 (readevalloop): Remove `evalfun' arg.
5455 Bind Qinternal_interpreter_environment.
5456 (Feval_buffer): Bind Qlexical_binding.
5457 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5459 (syms_of_lread): Declare `lexical-binding'.
5461 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5463 * keyboard.c (eval_dyn): New fun.
5464 (menu_item_eval_property): Use it.
5466 * image.c (parse_image_spec): Use Ffunctionp.
5468 * fns.c (concat, mapcar1): Accept byte-code-functions.
5470 * eval.c (Fsetq): Handle lexical vars.
5471 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5472 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5473 (FletX, Flet): Obey lexical binding.
5474 (Fcommandp): Handle closures.
5475 (Feval): New `lexical' arg.
5476 (eval_sub): New function extracted from Feval. Use it almost
5477 everywhere where Feval was used. Look up vars in lexical env.
5479 (Ffunctionp): Move from subr.el.
5480 (Ffuncall): Handle closures.
5481 (apply_lambda): Remove `eval_flags'.
5482 (funcall_lambda): Handle closures and new byte-code-functions.
5483 (Fspecial_variable_p): New function.
5484 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5485 but without exporting it to Lisp.
5487 * doc.c (Fdocumentation, store_function_docstring):
5488 * data.c (Finteractive_form): Handle closures.
5490 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5493 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5495 (exec_byte_code): New function extracted from Fbyte_code to handle new
5496 calling convention for byte-code-functions. Add new byte-codes.
5498 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5500 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5502 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5504 * xdisp.c (redisplay_internal): Fix prototype.
5506 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5508 * xdisp.c (SCROLL_LIMIT): New macro.
5509 (try_scrolling): Use it when setting scroll_limit.
5510 Limit scrolling to 100 screen lines.
5511 (redisplay_window): Even when falling back on "recentering",
5512 position point in the window according to scroll-conservatively,
5513 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5515 (try_scrolling): When point is above the window, allow searching
5516 as far as scroll_max, or one screenful, to compute vertical
5517 distance from PT to the scroll margin position. This prevents
5518 try_scrolling from unnecessarily failing when
5519 scroll-conservatively is set to a value slightly larger than the
5520 window height. Clean up the case of PT below the margin at bottom
5521 of window: scroll_max can no longer be INT_MAX. When aggressive
5522 scrolling is in use, don't let point enter the opposite scroll
5523 margin as result of the scroll.
5524 (syms_of_xdisp) <scroll-conservatively>: Document the
5525 threshold of 100 lines for never-recentering scrolling.
5527 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5529 * dispextern.h (move_it_by_lines):
5530 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5531 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5532 (message_log_check_duplicate): Remove parameters `prev_bol' and
5533 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5534 (redisplay_internal): Remove parameter `preserve_echo_area',
5535 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5537 * indent.c (Fvertical_motion):
5538 * window.c (window_scroll_pixel_based, Frecenter):
5539 Don't pass `need_y_p' to `move_it_by_lines'.
5541 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5543 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5544 steal a few bits to be more compact.
5545 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5546 Remove unneeded casts.
5548 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5550 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5552 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5553 binding" message (bug#7967).
5555 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5557 Fix more problems found by GCC 4.6.0's static checks.
5559 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5560 Remove unused local var.
5562 * editfns.c (Fmessage_box): Remove unused local var.
5564 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5565 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5566 Omit unused local vars.
5567 * window.c (shrink_windows): Omit unused local var.
5568 * menu.c (digest_single_submenu): Omit unused local var.
5569 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5570 Omit unused local var.
5572 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5573 Don't assume string length fits in int.
5574 (keyremap_step, read_key_sequence): Use size_t for sizes.
5575 (read_key_sequence): Don't check last_real_key_start redundantly.
5577 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5578 instead of alloca (Bug#8344).
5580 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5581 (Fbacktrace_frame): Don't assume nframes fits in int.
5583 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5585 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5588 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5590 * cm.c (calccost): Turn while-do into do-while, for clarity.
5592 * keyboard.c (syms_of_keyboard): Use the same style as later
5593 in this function when indexing through an array. This also
5594 works around GCC bug 48267.
5596 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5598 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5600 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5601 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5603 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5604 This avoids undefined behavior on integer overflow, and is a bit
5605 more convenient anyway since it is compared to a size_t variable.
5607 Variadic C functions now count arguments with size_t, not int.
5608 This avoids an unnecessary limitation on 64-bit machines, which
5609 caused (substring ...) to crash on large vectors (Bug#8344).
5610 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5611 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5612 All variadic functions and their callers changed accordingly.
5613 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5614 * data.c (arith_driver, float_arith_driver): Likewise.
5615 * editfns.c (general_insert_function): Likewise.
5616 * eval.c (struct backtrace.nargs, interactive_p)
5617 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5618 (funcall_lambda, mark_backtrace): Likewise.
5619 * fns.c (concat): Likewise.
5620 * frame.c (x_set_frame_parameters): Likewise.
5621 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5622 0 if not found, not -1. All callers changed.
5624 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5625 (stack_copy_size): Now size_t, not int.
5626 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5628 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5630 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5631 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5632 All callers changed.
5634 * lisp.h (multibyte_char_to_unibyte):
5635 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5636 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5637 * character.h (CHAR_TO_BYTE8):
5638 * cmds.c (internal_self_insert):
5639 * editfns.c (general_insert_function):
5640 * keymap.c (push_key_description):
5641 * search.c (Freplace_match):
5642 * xdisp.c (message_dolog, set_message_1): All callers changed.
5644 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5646 * keyboard.c (safe_run_hook_funcall): New function.
5647 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5648 don't set the hook to nil, but remove the offending function instead.
5649 (Qcommand_hook_internal): Remove, unused.
5650 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5651 Vcommand_hook_internal.
5653 * eval.c (enum run_hooks_condition): Remove.
5654 (funcall_nil, funcall_not): New functions.
5655 (run_hook_with_args): Call each function through a `funcall' argument.
5656 Remove `cond' argument, now redundant.
5657 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5658 (Frun_hook_with_args_until_failure): Adjust accordingly.
5659 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5661 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5663 * dispextern.h (string_buffer_position): Remove declaration.
5665 * print.c (strout): Remove parameter `multibyte', unused since
5666 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5668 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5669 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5670 All callers changed.
5672 * w32.c (_wsa_errlist): Use braces for struct initializers.
5674 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5675 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5676 All callers changed.
5677 (string_buffer_position): Likewise. Also, make static (it's never
5678 used outside xdisp.c).
5679 (cursor_row_p): Remove parameter `w', unused since
5680 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5681 (decode_mode_spec): Remove parameter `precision', introduced during
5682 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5683 All callers changed.
5685 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5687 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5689 2011-03-27 Anders Lindgren <andlind@gmail.com>
5691 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5692 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5693 (ns_update_auto_hide_menu_bar): New functions.
5694 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5695 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5696 ns_constrain_all_frames.
5697 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5698 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5700 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5702 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5704 2011-03-27 Glenn Morris <rgm@gnu.org>
5706 * syssignal.h: Replace RETSIGTYPE with void.
5707 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5708 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5709 Replace SIGTYPE with void everywhere.
5710 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5711 * s/template.h (SIGTYPE): Remove commented out definition.
5713 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5715 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5716 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5718 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5720 * w32.c (read_unc_volume): Use parameter `henum', instead of
5721 global variable `wget_enum_handle'.
5723 * keymap.c (describe_vector): Remove parameters `indices' and
5724 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5725 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5727 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5729 * keyboard.c (timer_check): Remove parameter `do_it_now',
5730 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5731 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5732 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5734 * keyboard.c (read_char):
5735 * w32menu.c (w32_menu_display_help):
5736 * xmenu.c (show_help_event, menu_help_callback):
5737 Adjust calls to `show_help_echo'.
5739 * gtkutil.c (xg_maybe_add_timer):
5740 * keyboard.c (readable_events):
5741 * process.c (wait_reading_process_output):
5742 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5744 * insdel.c (adjust_markers_gap_motion):
5745 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5746 (gap_left, gap_right): Don't call it.
5748 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5750 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5751 incurred during fontification.
5753 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5755 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5756 (DEFVAR_PER_BUFFER): Don't pass it.
5758 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5759 (scrolling_window): Don't pass it.
5761 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5763 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5765 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5767 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5768 of variables specific to SELinux and computation of `encoded_absname'.
5770 * image.c (XPutPixel): Remove unused variable `height'.
5772 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5774 * unexw32.c (get_section_info): Remove unused variable `section'.
5776 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5777 (system_process_attributes): Remove unused variable `sess'.
5778 (sys_read): Remove unused variable `err'.
5780 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5781 (w32_wnd_proc): Remove unused variable `isdead'.
5782 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5783 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5784 (x_create_tip_frame): Remove unused variable `tem'.
5786 * w32inevt.c (w32_console_read_socket):
5787 Remove unused variable `no_events'.
5789 * w32term.c (x_draw_composite_glyph_string_foreground):
5790 Remove unused variable `width'.
5792 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5794 * w32term.c (x_set_glyph_string_clipping):
5795 Don't pass uninitialized region to CombineRgn.
5797 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5799 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5800 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5801 (Fx_close_connection): Remove unused variable `i'.
5803 * w32font.c (w32font_draw): Return number of glyphs.
5804 (w32font_open_internal): Remove unused variable `i'.
5805 (w32font_driver): Add missing initializer.
5807 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5808 (fill_in_menu): Remove unused variable `items_added'.
5810 * w32term.c (last_mouse_press_frame): Remove static global variable.
5811 (w32_clip_to_row): Remove unused variable `f'.
5812 (x_delete_terminal): Remove unused variable `i'.
5814 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5815 (NOTHING): Remove unused static global variable.
5816 (uniscribe_check_otf): Remove unused variable `table'.
5817 (uniscribe_font_driver): Add missing initializers.
5819 2011-03-23 Julien Danjou <julien@danjou.info>
5821 * term.c (Fsuspend_tty, Fresume_tty):
5822 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5823 * window.c (temp_output_buffer_show):
5824 * insdel.c (signal_before_change):
5825 * frame.c (Fhandle_switch_frame):
5826 * fileio.c (Fdo_auto_save):
5827 * emacs.c (Fkill_emacs):
5828 * editfns.c (save_excursion_restore):
5829 * cmds.c (internal_self_insert):
5830 * callint.c (Fcall_interactively):
5831 * buffer.c (Fkill_all_local_variables):
5832 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5834 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5835 unconditionnaly since it does the check itself.
5837 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5839 Fix more problems found by GCC 4.5.2's static checks.
5841 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5842 the first time through the loop, since we know p0 < p1 then.
5843 This also avoids a gcc -Wstrict-overflow warning.
5845 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5846 leading to a memory leak, possible in functions like
5847 load_charset_map_from_file that can allocate an unbounded number
5848 of objects (Bug#8318).
5850 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5851 that could (at least in theory) be that large.
5853 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5854 This is less likely to overflow, and avoids undefined behavior if
5855 overflow does occur. All callers changed. Use strtoul to scan
5856 for the unsigned long integer.
5857 (pint2hrstr): Simplify and tune code slightly.
5858 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5860 * scroll.c (do_scrolling): Work around GCC bug 48228.
5861 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5863 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5864 This also avoids a warning with gcc -Wstrict-overflow.
5865 (validate_x_resource_name): Simplify count usage.
5866 This also avoids a warning with gcc -Wstrict-overflow.
5868 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5871 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5873 * process.c (Fmake_network_process): Use socklen_t, not int,
5874 where POSIX says socklen_t is required in portable programs.
5875 This fixes a porting bug on hosts like 64-bit HP-UX, where
5876 socklen_t is wider than int (Bug#8277).
5877 (Fmake_network_process, server_accept_connection):
5878 (wait_reading_process_output, read_process_output):
5881 * process.c: Rename or move locals to avoid shadowing.
5882 (list_processes_1, Fmake_network_process):
5883 (read_process_output_error_handler, exec_sentinel_error_handler):
5884 Rename or move locals.
5885 (Fmake_network_process): Define label "retry_connect" only if needed.
5886 (Fnetwork_interface_info): Fix pointer signedness.
5887 (process_send_signal): Add cast to avoid pointer signedness problem.
5888 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5889 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5891 Make tparam.h and terminfo.c consistent.
5892 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5893 Include tparam.h instead, since it declares them.
5894 * cm.h (PC): Remove extern decl; tparam.h now does this.
5895 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5896 * terminfo.c: Include tparam.h, to check interfaces.
5897 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5898 (tparam): Adjust signature to match interface in tparam.h;
5899 this removes some undefined behavior. Check that outstring and len
5900 are zero, which they always are with Emacs.
5901 * tparam.h (PC, BC, UP): New extern decls.
5903 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5904 (xftfont_open): Rename locals to avoid shadowing.
5906 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5907 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5908 (OTF_TAG_SYM): Omit macro if not needed.
5909 (ftfont_list): Remove unused local.
5910 (get_adstyle_property, ftfont_pattern_entity):
5911 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5912 Rename locals to avoid shadowing.
5914 * xfont.c (xfont_list_family): Mark var as initialized.
5916 * xml.c (make_dom): Now static.
5918 * composite.c (composition_compute_stop_pos): Rename local to
5920 (composition_reseat_it): Remove unused locals.
5921 (find_automatic_composition, composition_adjust_point): Likewise.
5922 (composition_update_it): Mark var as initialized.
5923 (find_automatic_composition): Mark vars as initialized,
5924 with a FIXME (Bug#8290).
5926 character.h: Rename locals to avoid shadowing.
5927 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5928 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5929 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5930 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5933 * textprop.c (property_change_between_p): Remove; unused.
5935 * intervals.c (interval_start_pos): Now static.
5937 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5939 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5940 Rename locals to avoid shadowing.
5942 * sound.c (wav_play, au_play, Fplay_sound_internal):
5943 Fix pointer signedness.
5944 (alsa_choose_format): Remove unused local var.
5945 (wav_play): Initialize a variable to 0, to prevent undefined
5946 behavior (Bug#8278).
5948 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5950 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5952 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5953 clobbering (Bug#8298).
5954 * sysdep.c (sys_subshell): Likewise.
5955 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5957 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5958 This should get cleaned up, so that child_setup has the
5959 same signature on all platforms.
5961 * callproc.c (call_process_cleanup): Now static.
5962 (relocate_fd): Rename locals to avoid shadowing.
5964 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5966 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5967 not to be necessary, and produces flickering.
5969 2011-03-20 Glenn Morris <rgm@gnu.org>
5971 * config.in: Remove file.
5973 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5975 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5976 are now in src/globals.h.
5977 (syms_of_minibuf): Remove spurious & from previous change.
5979 2011-03-20 Leo <sdl.web@gmail.com>
5981 * minibuf.c (completing-read-function): New variable.
5982 (completing-read-default): Rename from completing-read.
5983 (completing-read): Call completing-read-function.
5985 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5987 * xfaces.c (Fx_load_color_file):
5988 Read color file from absolute filename (bug#8250).
5990 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5992 * makefile.w32-in: Update dependencies.
5994 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5996 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5998 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6000 Fix more problems found by GCC 4.5.2's static checks.
6002 * process.c (make_serial_process_unwind, send_process_trap):
6003 (sigchld_handler): Now static.
6005 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6006 That way, the code declares only the vars that it needs.
6007 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6008 * s/cygwin.h (PTY_ITERATION): Likewise.
6009 * s/darwin.h (PTY_ITERATION): Likewise.
6010 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6012 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6013 * process.c (allocate_pty): Don't declare stb unless it's needed.
6015 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6016 (CONSTANTLIM): Remove; unused.
6017 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6018 Define only if needed.
6020 * unexelf.c (unexec): Name an expression,
6021 to avoid gcc -Wbad-function-cast warning.
6022 Use a different way to cause a compilation error if anyone uses
6023 n rather than nn, a way that does not involve shadowing.
6024 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6026 * deps.mk (unexalpha.o): Remove; unused.
6028 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6029 * unexec.h: New file.
6030 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6031 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6033 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6034 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6035 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6036 Change as necessary to match prototype in unexec.h.
6038 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6040 (back_comment, skip_chars): Mark vars as initialized.
6042 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6043 Rename locals to avoid shadowing.
6045 * lread.c (read1): Rewrite so as not to use empty "else".
6046 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6048 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6050 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6051 warning when compiling print.c.
6053 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6054 instead of using an uninitialized var.
6055 (font_sort_entities): Mark var as initialized.
6057 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6059 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6060 pointers to constants.
6061 (font_parse_fcname): Remove unused vars.
6062 (font_delete_unmatched): Now static.
6063 (font_get_spec): Remove; unused.
6064 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6065 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6066 Rename or move locals to avoid shadowing.
6068 * fns.c (require_nesting_list, require_unwind): Now static.
6069 (Ffillarray): Rename locals to avoid shadowing.
6071 * floatfns.c (domain_error2): Define only if needed.
6072 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6074 * alloc.c (mark_backtrace): Move decl from here ...
6075 * lisp.h: ... to here, so that it can be checked.
6077 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6078 (Fdefvar): Rewrite so as not to use empty "else".
6079 (lisp_indirect_variable): Name an expression,
6080 to avoid gcc -Wbad-function-cast warning.
6081 (Fdefvar): Rename locals to avoid shadowing.
6083 * callint.c (quotify_arg, quotify_args): Now static.
6084 (Fcall_interactively): Rename locals to avoid shadowing.
6085 Use const pointer when appropriate.
6087 * lisp.h (get_system_name, get_operating_system_release):
6088 Move decls here, to check interfaces.
6089 * process.c (get_operating_system_release): Move decl to lisp.h.
6090 * xrdb.c (get_system_name): Likewise.
6091 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6092 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6093 some of which prompt warnings from gcc -Wbad-function-cast.
6094 (Fformat_time_string, Fencode_time, Finsert_char):
6095 (Ftranslate_region_internal, Fformat):
6096 Rename or remove local vars to avoid shadowing.
6097 (Ftranslate_region_internal): Mark var as initialized.
6099 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6102 * lisp.h (eassert): Check that the argument compiles, even if
6103 ENABLE_CHECKING is not defined.
6105 * data.c (Findirect_variable): Name an expression, to avoid
6106 gcc -Wbad-function-cast warning.
6107 (default_value, arithcompare, arith_driver, arith_error): Now static.
6108 (store_symval_forwarding): Rename local to avoid shadowing.
6109 (Fmake_variable_buffer_local, Fmake_local_variable):
6110 Mark variables as initialized.
6111 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6113 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6114 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6115 Rename locals to avoid shadowing.
6116 (mark_stack): Move local variables into the #ifdef region where
6118 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6119 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6121 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6122 (GC_STRING_CHARS): Remove; not used.
6123 (Fmemory_limit): Cast sbrk's returned value to char *.
6125 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6126 avoids undefined behavior in theory.
6128 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6130 Use functions, not macros, for up- and down-casing (Bug#8254).
6131 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6132 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6133 to use the following functions instead of these macros.
6134 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6135 EMACS_INT, since callers assume the returned value fits in int.
6136 (upcase1): Likewise, for UPCASE_TABLE.
6137 (uppercasep, lowercasep, upcase): New static inline functions.
6138 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6139 the race-condition problem in the old DOWNCASE.
6141 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6142 Rename locals to avoid shadowing.
6143 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6144 (regex_compile, re_search_2, re_match_2_internal):
6145 Remove unused local vars.
6146 (FREE_VAR): Rewrite so as not to use empty "else",
6147 which gcc can warn about.
6148 (regex_compile, re_match_2_internal): Mark locals as initialized.
6149 (RETALLOC_IF): Define only if needed.
6150 (WORDCHAR_P): Likewise. This one is never needed, but is used
6151 only in a comment talking about a compiler bug, so put inside
6152 the #if 0 of that comment.
6153 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6154 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6157 * search.c (boyer_moore): Rename locals to avoid shadowing.
6158 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6159 (PREV_CHAR_BOUNDARY): Likewise.
6161 * search.c (simple_search): Remove unused var.
6163 * dired.c (compile_pattern): Move decl from here ...
6164 * lisp.h: ... to here, so that it can be checked.
6165 (struct re_registers): New forward decl.
6167 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6169 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6171 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6172 Rename locals to avoid shadowing.
6173 (Fvertical_motion): Mark locals as initialized.
6175 * casefiddle.c (casify_object, casify_region): Now static.
6176 (casify_region): Mark local as initialized.
6178 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6180 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6181 New macros, so that the caller can use some names other than
6182 gcpro1, gcpro2, etc.
6183 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6185 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6186 argument, for consistency with GCPRO2_VAR, etc: it is now the
6187 prefix of the variable, not the variable itself. All uses
6189 * dired.c (directory_files_internal, file_name_completion):
6190 Rename locals to avoid shadowing.
6192 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6193 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6194 dired.c's scmp function, had undefined behavior.
6195 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6196 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6197 * buffer.h: ... to here, because these macros use current_buffer,
6198 and the new implementation with inline functions needs to have
6199 current_buffer in scope now, rather than later when the macros
6201 (downcase, upcase1): New static inline functions.
6202 (DOWNCASE, UPCASE1): Reimplement using these functions.
6203 This avoids undefined behavior in expressions like
6204 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6205 from race conditions in accessing the global variables
6206 case_temp1 and case_temp2.
6207 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6208 * lisp.h (case_temp1, case_temp2): Remove their decls.
6209 * character.h (ASCII_CHAR_P): Move from here ...
6210 * lisp.h: ... to here, so that the inline functions mentioned
6213 * dired.c (directory_files_internal_unwind): Now static.
6215 * fileio.c (file_name_as_directory, directory_file_name):
6216 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6218 (file_name_as_directory): Use const pointers when appropriate.
6219 (Fexpand_file_name): Likewise. In particular, newdir might
6220 point at constant storage, so make it a const pointer.
6221 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6222 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6224 (Fset_file_times, Finsert_file_contents, auto_save_error):
6225 Rename locals to avoid shadowing.
6227 * minibuf.c (choose_minibuf_frame_1): Now static.
6228 (Ftry_completion, Fall_completions): Rename or remove locals
6231 * marker.c (bytepos_to_charpos): Remove; unused.
6233 * lisp.h (verify_bytepos, count_markers): New decls,
6234 so that gcc does not warn that these functions aren't declared.
6236 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6237 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6238 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6239 (copy_text): Remove unused local var.
6241 * filelock.c (within_one_second): Now static.
6242 (lock_file_1): Rename local to avoid shadowing.
6244 * buffer.c (fix_overlays_before): Mark locals as initialized.
6245 (fix_start_end_in_overlays): Likewise. This function should be
6246 simplified by using pointers-to-pointers, but that's a different
6248 (switch_to_buffer_1): Now static.
6249 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6250 (report_overlay_modification): Rename locals to avoid shadowing.
6252 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6253 Fix pointer signedness issue.
6254 (sys_subshell): Mark local as volatile if checking for lint,
6255 to suppress a gcc -Wclobbered warning that does not seem to be right.
6256 (MAXPATHLEN): Define only if needed.
6258 * process.c (serial_open, serial_configure): Move decls from here ...
6259 * systty.h: ... to here, so that they can be checked.
6261 * fns.c (get_random, seed_random): Move extern decls from here ...
6262 * lisp.h: ... to here, so that they can be checked.
6264 * sysdep.c (reset_io): Now static.
6265 (wait_for_termination_signal): Remove; unused.
6267 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6268 (copy_keymap_item, append_key, push_text_char_description):
6270 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6271 (DENSE_TABLE_SIZE): Remove; unused.
6272 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6273 (describe_map_tree):
6274 Rename locals to avoid shadowing.
6276 * keyboard.c: Declare functions static if they are not used elsewhere.
6277 (echo_char, echo_dash, cmd_error, top_level_2):
6278 (poll_for_input, handle_async_input): Now static.
6279 (read_char, kbd_buffer_get_event, make_lispy_position):
6280 (make_lispy_event, make_lispy_movement, apply_modifiers):
6281 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6282 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6283 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6284 (read_key_sequence, read_char): Mark locals as initialized.
6285 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6287 * keyboard.h (make_ctrl_char): New decl.
6288 (mark_kboards): Move decl here ...
6289 * alloc.c (mark_kboards): ... from here.
6291 * lisp.h (force_auto_save_soon): New decl.
6293 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6294 (DEFINE_DUMMY_FUNCTION): New macro.
6295 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6297 (main): Add casts to avoid warnings
6298 if GCC considers string literals to be constants.
6300 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6302 * dbusbind.c: Pointer signedness fixes.
6303 (xd_signature, xd_append_arg, xd_initialize):
6304 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6305 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6306 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6307 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6309 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6310 if GCC considers string literals to be constants.
6311 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6313 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6315 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6316 (print_preprocess, print_object): New macro to fix last change.
6318 * print.c (print_preprocess): Don't forget font objects.
6320 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6322 * emacs.c (USAGE3): Doc fixes.
6324 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6326 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6329 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6331 * lisp.h (VWindow_system, Qfile_name_history):
6332 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6333 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6334 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6336 * w32select.c: Don't #include "keyboard.h".
6337 (run_protected): Add extern declaration for waiting_for_input.
6339 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6340 * w32console.c (detect_input_pending, read_input_pending)
6341 (encode_terminal_code):
6342 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6343 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6344 (w32_system_caret_y, Qfile_name_history):
6345 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6346 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6347 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6348 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6349 * w32proc.c (Qlocal, report_file_error):
6350 * w32term.c (Vwindow_system, updating_frame):
6351 * w32uniscribe.c (initialized, uniscribe_font_driver):
6352 Remove unneeded extern declarations.
6354 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6356 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6358 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6360 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6361 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6362 These macros can no longer be used for assignment.
6364 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6365 Assign struct members directly, instead of using BUF_BEGV etc.
6366 (record_buffer_markers, fetch_buffer_markers): New functions for
6367 recording and fetching special buffer markers.
6368 (set_buffer_internal_1, set_buffer_temp): Use them.
6370 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6372 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6374 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6375 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6377 * xdisp.c (hscroll_window_tree):
6378 (reconsider_clip_changes): Use PT instead of BUF_PT.
6380 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6382 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6383 $(EMACS_ROOT)/lib/intprops.h.
6385 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6387 Fix more problems found by GCC 4.5.2's static checks.
6389 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6390 to unsigned char * to avoid compiler diagnostic.
6391 (xg_free_frame_widgets): Make it clear that a local variable is
6392 needed only if USE_GTK_TOOLTIP.
6393 (gdk_window_get_screen): Make it clear that this macro is needed
6394 only if USE_GTK_TOOLTIP.
6395 (int_gtk_range_get_value): New function, which avoids a diagnostic
6396 from gcc -Wbad-function-cast.
6397 (xg_set_toolkit_scroll_bar_thumb): Use it.
6398 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6399 diagnostic from gcc -Wbad-function-cast.
6400 (get_utf8_string, xg_get_file_with_chooser):
6401 Rename locals to avoid shadowing.
6402 (create_dialog): Move locals to avoid shadowing.
6404 * xgselect.c (xg_select): Remove unused var.
6406 * image.c (four_corners_best): Mark locals as initialized.
6407 (gif_load): Initialize transparent_p to zero (Bug#8238).
6408 Mark another local as initialized.
6409 (my_png_error, my_error_exit): Mark with NO_RETURN.
6411 * image.c (clear_image_cache): Now static.
6412 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6413 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6414 (x_edge_detection): Remove unnecessary cast that
6415 gcc -Wbad-function-cast diagnoses.
6416 (gif_load): Fix pointer signedness.
6417 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6418 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6420 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6422 Improve quality of tests for time stamp overflow.
6423 For example, without this patch (encode-time 0 0 0 1 1
6424 1152921504606846976) returns the obviously-bogus value (-948597
6425 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6426 reports time overflow. See
6427 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6428 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6429 * editfns.c: Include limits.h and intprops.h.
6430 (TIME_T_MIN, TIME_T_MAX): New macros.
6431 (time_overflow): Move earlier, to before first use.
6432 (hi_time, lo_time): New functions, for an accurate test for
6434 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6435 (Fget_internal_run_time): Don't assume time_t fits in int.
6436 (make_time): Use list2 instead of Fcons twice.
6437 (Fdecode_time): More accurate test for out-of-range times.
6438 (check_tm_member): New function.
6439 (Fencode_time): Use it, to test for out-of-range times.
6440 (lisp_time_argument): Don't rely on undefined left-shift and
6441 right-shift behavior when checking for time stamp overflow.
6443 * editfns.c (time_overflow): New function, refactoring common code.
6444 (Fformat_time_string, Fdecode_time, Fencode_time):
6445 (Fcurrent_time_string): Use it.
6447 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6448 * dired.c (make_time): Move to ...
6449 * editfns.c (make_time): ... here.
6450 * systime.h: Note the move.
6452 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6454 * fringe.c (update_window_fringes): Remove unused variables.
6456 * unexmacosx.c (copy_data_segment): Also copy __got section.
6459 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6461 * termcap.c [MSDOS]: Include "msdos.h".
6462 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6463 Constify `char *' arguments and their references according to
6464 prototypes in tparam.h.
6466 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6468 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6469 Adapt all references accordingly.
6471 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6473 2011-03-11 Tom Tromey <tromey@redhat.com>
6475 * buffer.c (syms_of_buffer): Remove obsolete comment.
6477 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6479 * termhooks.h (encode_terminal_code): Declare prototype.
6481 * msdos.c (encode_terminal_code): Don't declare prototype.
6483 * term.c (encode_terminal_code): Now external again, used by
6484 w32console.c and msdos.c.
6486 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6487 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6489 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6491 Fix some minor problems found by GCC 4.5.2's static checks.
6493 * fringe.c (update_window_fringes): Mark locals as initialized
6495 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6497 * alloc.c (mark_fringe_data): Move decl from here ...
6498 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6499 to check its interface.
6500 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6502 * fontset.c (free_realized_fontset): Now static.
6503 (Fset_fontset_font): Rename local to avoid shadowing.
6504 (fontset_font): Mark local as initialized.
6505 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6507 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6509 * xselect.c (x_disown_buffer_selections): Remove; not used.
6510 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6511 (x_own_selection, Fx_disown_selection_internal): Rename locals
6513 (x_handle_dnd_message): Remove local to avoid shadowing.
6515 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6516 so that the caller can use some name other than gcpro1.
6517 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6518 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6519 (Fx_backspace_delete_keys_p):
6520 Use them to avoid shadowing, and rename vars to avoid shadowing.
6521 (x_decode_color, x_set_name, x_window): Now static.
6522 (Fx_create_frame): Add braces to silence GCC warning.
6523 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6524 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6525 Remove unused locals.
6526 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6527 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6528 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6531 * xterm.h (x_mouse_leave): New decl.
6533 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6534 Remove unused functions.
6535 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6536 (x_calc_absolute_position): Now static.
6537 (XTread_socket): Don't define label "out" unless it's used.
6538 Don't declare local "event" unless it's used.
6539 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6540 unless they are used.
6541 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6542 (x_fatal_error_signal): Remove; not used.
6543 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6544 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6545 (x_error_catcher, x_connection_closed, x_error_handler):
6546 (x_error_quitter, xembed_send_message, x_iconify_frame):
6547 (my_log_handler): Rename locals to avoid shadowing.
6548 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6549 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6551 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6552 Rename or move locals to avoid shadowing.
6553 (tty_defined_color, merge_face_heights): Now static.
6554 (free_realized_faces_for_fontset): Remove; not used.
6555 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6556 does not deduce is never used uninitialized.
6557 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6558 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6560 * terminal.c (store_terminal_param): Now static.
6562 * xmenu.c (menu_highlight_callback): Now static.
6563 (set_frame_menubar): Remove unused local.
6564 (xmenu_show): Rename parameter to avoid shadowing.
6565 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6566 since they might point to immutable storage.
6567 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6568 since it's unused otherwise.
6570 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6571 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6572 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6573 avoids a gcc -Wuninitialized diagnostic.
6574 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6575 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6576 does not deduce are never used uninitialized.
6578 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6580 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6581 * window.c (window_loop, size_window):
6582 (run_window_configuration_change_hook, enlarge_window): Likewise.
6584 * window.c (display_buffer): Now static.
6585 (size_window): Mark variables that gcc -Wuninitialized
6586 does not deduce are never used uninitialized.
6587 * window.h (check_all_windows): New decl, to forestall
6588 gcc -Wmissing-prototypes diagnostic.
6589 * dispextern.h (bidi_dump_cached_states): Likewise.
6591 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6593 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6595 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6596 and to avoid gcc -Wuninitialized warning.
6597 (load_charset_map): Mark variables that gcc -Wuninitialized
6598 does not deduce are never used uninitialized.
6599 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6601 * coding.c (coding_set_source, coding_set_destination):
6602 Use "else { /* comment */ }" rather than "else /* comment */;"
6603 for clarity, and to avoid gcc -Wempty-body warning.
6604 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6605 a block, when the outer 'i' will do.
6606 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6607 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6608 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6609 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6610 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6611 Rename locals to avoid shadowing.
6612 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6613 * coding.c (emacs_mule_char, encode_invocation_designation):
6614 Now static, since they're not used elsewhere.
6615 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6616 (decode_coding_object, encode_coding_object, detect_coding_system):
6617 (decode_coding_emacs_mule): Mark variables that gcc
6618 -Wuninitialized does not deduce are never used uninitialized.
6619 (detect_coding_iso_2022): Initialize a local variable that might
6620 be used uninitialized. Leave a FIXME because it's not clear that
6621 this initialization is needed. (Bug#8211)
6622 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6623 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6624 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6625 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6626 Remove unused macros.
6628 * category.c (hash_get_category_set): Remove unused local var.
6629 (copy_category_table): Now static, since it's not used elsewhere.
6630 * character.c (string_count_byte8): Likewise.
6632 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6633 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6635 * chartab.c (copy_sub_char_table): Now static, since it's not used
6637 (sub_char_table_ref_and_range, char_table_ref_and_range):
6638 Rename locals to avoid shadowing.
6639 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6641 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6642 (BIDI_BOB): Remove unused macro.
6644 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6645 deduce are never used uninitialized.
6646 * term.c (encode_terminal_code): Likewise.
6648 * term.c (encode_terminal_code): Now static. Remove unused local.
6650 * tparam.h: New file.
6651 * term.c, tparam.h: Include it.
6652 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6653 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6654 Move these decls to tparam.h, and make them agree with what
6655 is actually in tparam.c. The previous trick of using incompatible
6656 decls in different modules does not conform to the C standard.
6657 All callers of tparam changed to use tparam's actual API.
6658 * tparam.c (tparam1, tparam, tgoto):
6659 Use const pointers where appropriate.
6661 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6662 * cm.h (struct cm): Likewise.
6663 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6664 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6665 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6666 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6667 (turn_on_face, init_tty): Likewise.
6668 * termchar.h (struct tty_display_info): Likewise.
6670 * term.c (term_mouse_position): Rename local to avoid shadowing.
6672 * alloc.c (mark_ttys): Move decl from here ...
6673 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6675 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6677 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6679 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6681 * search.c (compile_pattern_1): Remove argument regp, unused since
6682 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6683 (compile_pattern): Don't pass it.
6685 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6687 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6688 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6690 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6692 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6694 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6695 gdk_window_get_screen, gdk_window_get_geometry,
6696 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6697 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6698 (xg_get_pixbuf_from_pixmap): New function.
6699 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6700 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6701 Call xg_get_pixbuf_from_pixmap instead of
6702 gdk_pixbuf_get_from_drawable.
6703 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6704 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6705 (xg_check_special_colors): Use GtkStyleContext and its functions
6707 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6708 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6709 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6710 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6711 Call gtk_widget_get_preferred_size.
6712 (xg_frame_resized): gdk_window_get_geometry only takes 5
6714 (xg_win_to_widget, xg_event_is_for_menubar):
6715 Call gdk_x11_window_lookup_for_display.
6716 (xg_set_widget_bg): New function.
6717 (delete_cb): New function.
6718 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6719 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6720 (xg_set_background_color): Call xg_set_widget_bg.
6721 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6722 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6723 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6724 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6726 (update_frame_tool_bar): Call gtk_widget_hide.
6727 (xg_initialize): Use GDK_KEY_g.
6729 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6731 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6733 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6734 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6735 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6737 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6739 * w32xfns.c (select_palette): Check success of RealizePalette against
6740 GDI_ERROR, not zero.
6742 See ChangeLog.11 for earlier changes.
6748 Copyright (C) 2011 Free Software Foundation, Inc.
6750 This file is part of GNU Emacs.
6752 GNU Emacs is free software: you can redistribute it and/or modify
6753 it under the terms of the GNU General Public License as published by
6754 the Free Software Foundation, either version 3 of the License, or
6755 (at your option) any later version.
6757 GNU Emacs is distributed in the hope that it will be useful,
6758 but WITHOUT ANY WARRANTY; without even the implied warranty of
6759 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6760 GNU General Public License for more details.
6762 You should have received a copy of the GNU General Public License
6763 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.