* alloc.c: Use EMACS_INT, not int, to count objects.
[bpt/emacs.git] / src / ChangeLog
1 2011-06-08 Paul Eggert <eggert@cs.ucla.edu>
2
3 * alloc.c: Use EMACS_INT, not int, to count objects.
4 (total_conses, total_markers, total_symbols, total_vector_size)
5 (total_free_conses, total_free_markers, total_free_symbols)
6 (total_free_floats, total_floats, total_free_intervals, total_intervals)
7 (total_strings, total_free_strings):
8 Now EMACS_INT, not int. All uses changed.
9 (Fgarbage_collect): Compute overall total using a double, so that
10 integer overflow is less likely to be a problem. Check for overflow
11 when converting back to an integer.
12
13 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
14 (allocate_vectorlike): Check for ptrdiff_t overflow.
15 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
16 when a (possibly-narrower) signed value would do just as well.
17 We prefer using signed arithmetic, to avoid comparison confusion.
18
19 * alloc.c: Catch some string size overflows that we were missing.
20 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
21 for convenience in STRING_BYTES_MAX.
22 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
23 The definition here is exact; the one in lisp.h was approximate.
24 (allocate_string_data): Check for string overflow. This catches
25 some instances we weren't catching before. Also, it catches
26 size_t overflow on (unusual) hosts where SIZE_MAX <= min
27 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
28 and ptrdiff_t and EMACS_INT are both 64 bits.
29
30 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
31 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
32 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
33
34 2011-06-07 Paul Eggert <eggert@cs.ucla.edu>
35
36 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
37
38 * alloc.c (Fmake_string): Check for out-of-range init.
39
40 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
41
42 * fns.c (Fputhash): Document return value.
43
44 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
45
46 * image.c (gif_load): Implement gif89a spec "no disposal" method.
47
48 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
49
50 Cons<->int and similar integer overflow fixes (Bug#8794).
51
52 Check for overflow when converting integer to cons and back.
53 * charset.c (Fdefine_charset_internal, Fdecode_char):
54 Use cons_to_unsigned to catch overflow.
55 (Fencode_char): Use INTEGER_TO_CONS.
56 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
57 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
58 * data.c (long_to_cons, cons_to_long): Remove.
59 (cons_to_unsigned, cons_to_signed): New functions.
60 These signal an error for invalid or out-of-range values.
61 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
62 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
63 * font.c (Ffont_variation_glyphs):
64 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
65 * lisp.h: Include <intprops.h>.
66 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
67 (cons_to_signed, cons_to_unsigned): New decls.
68 (long_to_cons, cons_to_long): Remove decls.
69 * undo.c (record_first_change): Use INTEGER_TO_CONS.
70 (Fprimitive_undo): Use CONS_TO_INTEGER.
71 * xfns.c (Fx_window_property): Likewise.
72 * xselect.c: Include <limits.h>.
73 (x_own_selection, selection_data_to_lisp_data):
74 Use INTEGER_TO_CONS.
75 (x_handle_selection_request, x_handle_selection_clear)
76 (x_get_foreign_selection, Fx_disown_selection_internal)
77 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
78 (lisp_data_to_selection_data): Use cons_to_unsigned.
79 (x_fill_property_data): Use cons_to_signed.
80 Report values out of range.
81
82 Check for buffer and string overflow more precisely.
83 * buffer.h (BUF_BYTES_MAX): New macro.
84 * lisp.h (STRING_BYTES_MAX): New macro.
85 * alloc.c (Fmake_string):
86 * character.c (string_escape_byte8):
87 * coding.c (coding_alloc_by_realloc):
88 * doprnt.c (doprnt):
89 * editfns.c (Fformat):
90 * eval.c (verror):
91 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
92 since they may not be the same number.
93 * editfns.c (Finsert_char):
94 * fileio.c (Finsert_file_contents):
95 Likewise for BUF_BYTES_MAX.
96
97 * image.c: Use ptrdiff_t, not int, for sizes.
98 (slurp_file): Switch from int to ptrdiff_t.
99 All uses changed.
100 (slurp_file): Check that file size fits in both size_t (for
101 malloc) and ptrdiff_t (for sanity and safety).
102
103 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
104 if b->modtime has its maximal value.
105
106 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
107
108 Don't assume time_t can fit into int.
109 * buffer.h (struct buffer.modtime): Now time_t, not int.
110 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
111 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
112
113 Minor fixes for signed vs unsigned integers.
114 * character.h (MAYBE_UNIFY_CHAR):
115 * charset.c (maybe_unify_char):
116 * keyboard.c (read_char, reorder_modifiers):
117 XINT -> XFASTINT, since the integer must be nonnegative.
118 * ftfont.c (ftfont_spec_pattern):
119 * keymap.c (access_keymap, silly_event_symbol_error):
120 XUINT -> XFASTINT, since the integer must be nonnegative.
121 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
122 since it makes no difference and we prefer signed.
123 * keyboard.c (record_char): Use XUINT when all the neighbors do.
124 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
125 nonnegative.
126
127 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
128
129 * window.h (Fwindow_frame): Declare.
130
131 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
132
133 * alloc.c: Simplify handling of large-request failures (Bug#8800).
134 (SPARE_MEMORY): Always define.
135 (LARGE_REQUEST): Remove.
136 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
137
138 2011-06-06 Martin Rudalics <rudalics@gmx.at>
139
140 * lisp.h: Move EXFUNS for Fframe_root_window,
141 Fframe_first_window and Fset_frame_selected_window to window.h.
142
143 * window.h: Move EXFUNS for Fframe_root_window,
144 Fframe_first_window and Fset_frame_selected_window here from
145 lisp.h.
146
147 * frame.c (Fwindow_frame, Fframe_first_window)
148 (Fframe_root_window, Fframe_selected_window)
149 (Fset_frame_selected_window): Move to window.c.
150 (Factive_minibuffer_window): Move to minibuf.c.
151 (Fother_visible_frames_p): New function.
152
153 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
154
155 * window.c (decode_window, decode_any_window): Move up in code.
156 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
157 (inhibit_frame_unsplittable): Remove unused variable.
158 (Fwindow_buffer): Move up and rewrite doc-string.
159 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
160 (Fwindow_prev): New functions.
161 (Fwindow_frame): Move here from frame.c. Accept any window as
162 argument.
163 (Fframe_root_window, Fframe_first_window)
164 (Fframe_selected_window): Move here from frame.c. Accept frame
165 or arbitrary window as argument. Update doc-strings.
166 (Fminibuffer_window): Move up in code.
167 (Fwindow_minibuffer_p): Move up in code and simplify.
168 (Fset_frame_selected_window): Move here from frame.c.
169 Marginal rewrite.
170 (Fselected_window, select_window, Fselect_window): Move up in
171 code. Minor doc-string fixes.
172
173 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
174
175 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
176 Do not assume that spare memory exists; that assumption is valid
177 only if SYSTEM_MALLOC.
178 (LARGE_REQUEST): New macro, so that the issue of large requests
179 is separated from the issue of spare memory.
180
181 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
182
183 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
184 format. (Bug#8806)
185
186 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
187
188 * xfns.c (x_set_scroll_bar_default_width): Move declarations
189 before statements.
190
191 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
192
193 * gtkutil.c (xg_get_default_scrollbar_width): New function.
194
195 * gtkutil.h: Declare xg_get_default_scrollbar_width.
196
197 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
198 min width by calling x_set_scroll_bar_default_width (Bug#8505).
199
200 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
201
202 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
203
204 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
205
206 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
207 (x_clipboard_manager_save): Add return value.
208 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
209 New error handlers.
210 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
211 Obey Vx_select_enable_clipboard_manager. Catch errors in
212 x_clipboard_manager_save (Bug#8779).
213 (Vx_select_enable_clipboard_manager): New variable.
214 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
215
216 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
217
218 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
219
220 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
221
222 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
223 in the current matrix if keep_current_p is non-zero.
224
225 2011-06-04 Eli Zaretskii <eliz@gnu.org>
226
227 * bidi.c (bidi_level_of_next_char): Fix last change.
228
229 2011-06-03 Eli Zaretskii <eliz@gnu.org>
230
231 Support bidi reordering of text covered by display properties.
232
233 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
234 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
235 (bidi_cache_search, bidi_cache_iterator_state)
236 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
237 (bidi_level_of_next_char, bidi_move_to_visually_next):
238 Support character positions inside a run of characters covered by a
239 display string.
240 (bidi_paragraph_init, bidi_resolve_explicit_1)
241 (bidi_level_of_next_char): Call bidi_fetch_char and
242 bidi_fetch_char_advance instead of FETCH_CHAR and
243 FETCH_CHAR_ADVANCE.
244 (bidi_init_it): Initialize new members.
245 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
246 definitions.
247 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
248 instead of using explicit *_CHAR codes.
249 (bidi_resolve_explicit, bidi_resolve_weak):
250 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
251 bidirectional text is supported only in multibyte buffers.
252 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
253 it to initialize the frame_window_p member of struct bidi_it.
254 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
255 (bidi_resolve_explicit, bidi_resolve_weak)
256 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
257 bidi_it->nchars is non-positive.
258 (bidi_level_of_next_char): Don't try to lookup the cache for the
259 next/previous character if nothing is cached there yet, or if we
260 were just reseat()'ed to a new position.
261
262 * xdisp.c (set_cursor_from_row): Set start and stop points
263 according to the row's direction when priming the loop that looks
264 for the glyph on which to display cursor.
265 (single_display_spec_intangible_p): Function deleted.
266 (display_prop_intangible_p): Reimplement to call
267 handle_display_spec instead of single_display_spec_intangible_p.
268 Accept 3 additional arguments needed by handle_display_spec.
269 This fixes incorrect cursor motion across display property with complex
270 values: lists, `(when COND...)' forms, etc.
271 (single_display_spec_string_p): Support property values that are
272 lists with the argument STRING its top-level element.
273 (display_prop_string_p): Fix the condition for processing a
274 property that is a list to be consistent with handle_display_spec.
275 (handle_display_spec): New function, refactored from the
276 last portion of handle_display_prop.
277 (compute_display_string_pos): Accept additional argument
278 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
279 value of a `display' property is a "replacing spec".
280 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
281 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
282 the display property, but just return a value indicating whether
283 the display property will replace the characters it covers.
284 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
285 frame_window_p members of struct bidi_it.
286 (compute_display_string_pos, compute_display_string_end):
287 New functions.
288 (push_it): Accept second argument POSITION, where pop_it should
289 jump to continue iteration.
290 (reseat_1): Initialize bidi_it.disp_pos.
291
292 * keyboard.c (adjust_point_for_property): Adjust the call to
293 display_prop_intangible_p to its new signature.
294
295 * dispextern.h (struct bidi_it): New member frame_window_p.
296 (bidi_init_it): Update prototypes.
297 (display_prop_intangible_p): Update prototype.
298 (compute_display_string_pos, compute_display_string_end):
299 Declare prototypes.
300 (struct bidi_it): New members nchars and disp_pos. ch_len is now
301 EMACS_INT.
302
303 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
304
305 Malloc failure behavior now depends on size of allocation.
306 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
307 * lisp.h: Change signatures accordingly.
308 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
309 All callers changed. (Bug#8762)
310
311 * gnutls.c: Use Emacs's memory allocators.
312 Without this change, the gnutls library would invoke malloc etc.
313 directly, which causes problems on non-SYNC_INPUT hosts, and which
314 runs afoul of improving memory_full behavior. (Bug#8761)
315 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
316 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
317 xfree instead of the default malloc, realloc, free.
318 (Fgnutls_boot): No need to check for memory allocation failure,
319 since xmalloc does that for us.
320
321 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
322 * category.c (hash_get_category_set):
323 * ccl.c (ccl_driver):
324 * charset.c (Fdefine_charset_internal):
325 * charset.h (struct charset.hash_index):
326 * composite.c (get_composition_id, gstring_lookup_cache)
327 (composition_gstring_put_cache):
328 * composite.h (struct composition.hash_index):
329 * dispextern.h (struct image.hash):
330 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
331 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
332 (hashfn_equal, hashfn_user_defined, make_hash_table)
333 (maybe_resize_hash_table, hash_lookup, hash_put)
334 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
335 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
336 (Fsxhash, Fgethash, Fputhash, Fmaphash):
337 * image.c (make_image, search_image_cache, lookup_image)
338 (xpm_put_color_table_h):
339 * lisp.h (struct Lisp_Hash_Table):
340 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
341 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
342 for hashes and hash indexes, instead of 'unsigned' and 'int'.
343 * alloc.c (allocate_vectorlike):
344 Check for overflow in vector size calculations.
345 * ccl.c (ccl_driver):
346 Check for overflow when converting EMACS_INT to int.
347 * fns.c, image.c: Remove unnecessary static decls that would otherwise
348 need to be updated by these changes.
349 * fns.c (make_hash_table, maybe_resize_hash_table):
350 Check for integer overflow with large hash tables.
351 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
352 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
353 (SXHASH_REDUCE): New macro.
354 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
355 Use it instead of discarding useful hash info with large hash values.
356 (sxhash_float): New function.
357 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
358 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
359 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
360 Rewrite to use FIXNUM_BITS, as this simplifies things.
361 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
362 Adjust signatures to match updated version of code.
363 (consing_since_gc): Now EMACS_INT, since a single hash table can
364 use more than INT_MAX bytes.
365
366 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
367
368 Make it possible to build with GCC-4.6+ -O2 -flto.
369
370 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
371
372 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
373
374 * minibuf.c (get_minibuffer, read_minibuf_unwind):
375 Call minibuffer-inactive-mode.
376
377 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
378
379 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
380 Update dependencies.
381
382 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
383
384 * data.c (init_data): Remove code for UTS, this system is not
385 supported anymore.
386
387 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
388
389 Don't force ./temacs to start in terminal mode.
390
391 * frame.c (make_initial_frame): Initialize faces in all cases, not
392 only when CANNOT_DUMP is defined.
393 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
394
395 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
396
397 * dispnew.c (add_window_display_history): Use const for the string
398 pointer. Remove declaration, not needed.
399
400 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
401
402 Use 'inline', not 'INLINE'.
403 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
404 * alloc.c, fontset.c (INLINE): Remove.
405 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
406 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
407 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
408 * gmalloc.c (register_heapinfo): Use inline unconditionally.
409 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
410
411 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
412
413 Make it possible to run ./temacs.
414
415 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
416 syms_of_callproc does the same thing. Remove test for
417 "initialized", do it in the caller.
418 * emacs.c (main): Avoid calling set_initial_environment when dumping.
419
420 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
421
422 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
423 (read_minibuf): Use get_minibuffer.
424 (syms_of_minibuf): Use DEFSYM.
425 (Qmetadata): New var.
426 * data.c (Qbuffer): Don't make it static.
427 (syms_of_data): Use DEFSYM.
428
429 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
430
431 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
432 (CCL_CODE_MIN): New macro.
433
434 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
435
436 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
437
438 * eval.c (Qdebug): Now static.
439 * lisp.h (Qdebug): Remove decl. This reverts a part of the
440 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
441 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
442
443 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
444
445 * image.c: Various fixes to ImageMagick code comments.
446 (Fimagemagick_types): Doc fix.
447
448 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
449
450 Minor fixes prompted by GCC 4.6.0 warnings.
451
452 * xselect.c (converted_selections, conversion_fail_tag): Now static.
453
454 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
455 (x_clipboard_manager_save_all): Move extern decl to ...
456 * xterm.h: ... here, so that it can be checked for consistency.
457
458 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
459
460 * xselect.c (x_clipboard_manager_save_frame)
461 (x_clipboard_manager_save_all): New functions.
462 (Fx_clipboard_manager_save): Lisp function deleted.
463
464 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
465 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
466
467 * xterm.h: Update prototype.
468
469 2011-05-28 William Xu <william.xwl@gmail.com>
470
471 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
472 exiting (Bug#8239).
473
474 2011-05-28 Jim Meyering <meyering@redhat.com>
475
476 Avoid a sign-extension bug in crypto_hash_function.
477 * fns.c (to_uchar): Define.
478 (crypto_hash_function): Use it to convert some newly-signed
479 variables to unsigned, to avoid sign-extension bugs. For example,
480 without this change, (md5 "truc") would evaluate to
481 45723a2aff78ff4fff7fff1114760e62 rather than the expected
482 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
483 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
484
485 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
486
487 Integer overflow fixes.
488
489 * dbusbind.c: Serial number integer overflow fixes.
490 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
491 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
492 to hold a serial number that is too large for a fixnum.
493 (Fdbus_method_return_internal, Fdbus_method_error_internal):
494 Check for serial numbers out of range. Decode any serial number
495 that was so large that it became a float. (Bug#8722)
496
497 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
498 (Fdbus_call_method, Fdbus_call_method_asynchronously):
499 Use XFASTINT rather than XUINT when numbers are nonnegative.
500 (xd_append_arg, Fdbus_method_return_internal):
501 (Fdbus_method_error_internal): Likewise. Also, for unsigned
502 arguments, check that Lisp number is nonnegative, rather than
503 silently wrapping negative numbers around. (Bug#8722)
504 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
505 (Bug#8722)
506
507 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
508
509 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
510
511 ccl: add integer overflow checks
512 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
513 (IN_INT_RANGE): New macros.
514 (ccl_driver): Use them to check for integer overflow when
515 decoding a CCL program. Many of the new checks are whether XINT (x)
516 fits in int; it doesn't always, on 64-bit hosts. The new version
517 doesn't catch all possible integer overflows, but it's an
518 improvement. (Bug#8719)
519
520 * alloc.c (make_event_array): Use XINT, not XUINT.
521 There's no need for unsigned here.
522
523 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
524 This follows up to the 2011-05-06 change that substituted uintptr_t
525 for EMACS_INT. This case wasn't caught back then.
526
527 Rework Fformat to avoid integer overflow issues.
528 * editfns.c: Include <float.h> unconditionally, as it's everywhere
529 now (part of C89). Include <verify.h>.
530 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
531 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
532 (Fformat): Avoid the prepass trying to compute sizes; it was only
533 approximate and thus did not catch overflow reliably. Instead, walk
534 through the format just once, formatting and computing sizes as we go,
535 checking for integer overflow at every step, and allocating a larger
536 buffer as needed. Keep track separately whether the format is
537 multibyte. Keep only the most-recently calculated precision, rather
538 than them all. Record whether each argument has been converted to
539 string. Use EMACS_INT, not int, for byte and char and arg counts.
540 Support field widths and precisions larger than INT_MAX. Avoid
541 sprintf's undefined behavior with conversion specifications such as %#d
542 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
543 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
544 formatting out-of-range floating point numbers with int
545 formats. (Bug#8668)
546
547 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
548
549 * data.c: Avoid integer truncation in expressions involving floats.
550 * data.c: Include <intprops.h>.
551 (arith_driver): When there's an integer overflow in an expression
552 involving floating point, convert the integers to floating point
553 so that the resulting value does not suffer from catastrophic
554 integer truncation. For example, on a 64-bit host (* 4
555 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
556 Do not rely on undefined behavior after integer overflow.
557
558 merge count_size_as_multibyte, parse_str_to_multibyte
559 * character.c, character.h (count_size_as_multibyte):
560 Rename from parse_str_to_multibyte; all uses changed.
561 Check for integer overflow.
562 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
563 since it's now a duplicate of the other. This is more of
564 a character than a buffer op, so better that it's in character.c.
565 * fns.c, print.c: Adjust to above changes.
566
567 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
568
569 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
570
571 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
572
573 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
574 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
575 (x_clipboard_manager_save): Now static.
576 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
577
578 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
579 (crypto_hash_function): Now static.
580 Fix pointer signedness problems. Avoid unnecessary initializations.
581
582 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
583
584 * termhooks.h (Vselection_alist): Make it terminal-local.
585
586 * terminal.c (create_terminal): Initialize it.
587
588 * xselect.c: Support for clipboard managers.
589 (Vselection_alist): Move to termhooks.h as terminal-local var.
590 (LOCAL_SELECTION): New macro.
591 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
592 (symbol_to_x_atom): Remove gratuitous arg.
593 (x_handle_selection_request, lisp_data_to_selection_data)
594 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
595 (x_own_selection, x_get_local_selection, x_convert_selection):
596 New arg, specifying work frame. Use terminal-local Vselection_alist.
597 (some_frame_on_display): Delete unused function.
598 (Fx_own_selection_internal, Fx_get_selection_internal)
599 (Fx_disown_selection_internal, Fx_selection_owner_p)
600 (Fx_selection_exists_p): New optional frame arg.
601 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
602 (x_handle_selection_clear): Don't treat other terminals with the
603 same keyboard specially. Use the terminal-local Vselection_alist.
604 (x_clear_frame_selections): Use Frun_hook_with_args.
605
606 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
607
608 * xterm.h: Add support for those atoms.
609
610 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
611
612 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
613 (converted_selections, conversion_fail_tag): New global variables.
614 (x_selection_request_lisp_error): Free the above.
615 (x_get_local_selection): Remove unnecessary code.
616 (x_reply_selection_request): Args changed; handle arbitrary array
617 of converted selections stored in converted_selections.
618 Separate the XChangeProperty and SelectionNotify steps.
619 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
620 (x_convert_selection): New function.
621 (x_handle_selection_event): Simplify.
622 (x_get_foreign_selection): Don't ignore incoming requests while
623 waiting for an answer; this will fail when we implement
624 SAVE_TARGETS, and seems unnecessary anyway.
625 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
626 (Vx_sent_selection_functions): Doc fix.
627
628 2011-05-26 Leo Liu <sdl.web@gmail.com>
629
630 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
631
632 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
633
634 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
635
636 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
637 for fringe update if it has periodic bitmap.
638 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
639 and fringe_bitmap_periodic_p.
640
641 * fringe.c (get_fringe_bitmap_data): New function.
642 (draw_fringe_bitmap_1, update_window_fringes): Use it.
643 (update_window_fringes): Record periodicity of fringe bitmap in glyph
644 row. Mark glyph row for fringe update if periodicity changed.
645
646 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
647 for fringe update unless it has periodic bitmap.
648
649 2011-05-25 Kenichi Handa <handa@m17n.org>
650
651 * xdisp.c (get_next_display_element): Set correct it->face_id for
652 a static composition.
653
654 2011-05-24 Leo Liu <sdl.web@gmail.com>
655
656 * deps.mk (fns.o):
657 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
658
659 * fns.c (crypto_hash_function, Fsha1): New function.
660 (Fmd5): Use crypto_hash_function.
661 (syms_of_fns): Add Ssha1.
662
663 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
664
665 * gnutls.c: Remove unused macros.
666 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
667 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
668 Remove macros that are defined and never used.
669 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
670
671 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
672
673 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
674 (Fx_get_selection_internal): Minor cleanup.
675 (Fx_own_selection_internal): Rename arguments for consistency with
676 select.el.
677
678 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
679
680 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
681
682 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
683
684 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
685
686 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
687
688 * dispnew.c (scrolling_window): Don't exclude the case that the
689 last enabled row in the desired matrix touches the bottom boundary.
690
691 2011-05-21 Glenn Morris <rgm@gnu.org>
692
693 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
694 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
695 and add some more files.
696
697 2011-05-20 Eli Zaretskii <eliz@gnu.org>
698
699 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
700 report_file_error introduced by the change from 2011-05-07.
701
702 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
703
704 * systime.h (Time): Define only if emacs is defined.
705 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
706 where the include path doesn't have X11/X.h by default. See
707 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
708
709 2011-05-20 Kenichi Handa <handa@m17n.org>
710
711 * composite.c (find_automatic_composition): Fix previous change.
712
713 2011-05-20 Glenn Morris <rgm@gnu.org>
714
715 * lisp.mk: New file, split from Makefile.in.
716 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
717 (shortlisp): Remove.
718 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
719
720 2011-05-19 Glenn Morris <rgm@gnu.org>
721
722 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
723 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
724 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
725 (lisp): Set the order to that of loadup.el.
726 (shortlisp): Make it a copy of $lisp.
727 (SOME_MACHINE_LISP): Remove.
728 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
729 Use just $shortlisp, not $SOME_MACHINE_LISP too.
730
731 2011-05-18 Kenichi Handa <handa@m17n.org>
732
733 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
734 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
735 (find_automatic_composition): Mostly rewrite for efficiency.
736
737 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
738
739 * makefile.w32-in: Update dependencies.
740
741 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
742
743 * menu.c: Include limits.h (fixes the MS-Windows build broken by
744 revision 104625).
745
746 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
747
748 Fix some integer overflow issues, such as string length overflow.
749
750 * insdel.c (count_size_as_multibyte): Check for string overflow.
751
752 * character.c (lisp_string_width): Check for string overflow.
753 Use EMACS_INT, not int, for string indexes and lengths; in
754 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
755 the resulting string length overflows an EMACS_INT; instead,
756 report a string overflow if no precision given. When checking for
757 precision exhaustion, use a check that cannot possibly have
758 integer overflow. (Bug#8675)
759 * character.h (lisp_string_width): Adjust to new signature.
760
761 * alloc.c (string_overflow): New function.
762 (Fmake_string): Use it. This doesn't change behavior, but saves
763 a few bytes and will simplify future changes.
764 * character.c (string_escape_byte8): Likewise.
765 * lisp.h (string_overflow): New decl.
766
767 Fixups, following up to the user-interface timestamp change.
768 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
769 for UI timestamps, instead of unsigned long.
770 * msdos.c (mouse_get_pos): Likewise.
771 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
772 * w32gui.h (Time): Define by including "systime.h" rather than by
773 declaring it ourselves. (Bug#8664)
774
775 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
776 * image.c (clear_image_cache): Likewise.
777
778 * term.c (term_mouse_position): Don't assume time_t wraparound.
779
780 Be more systematic about user-interface timestamps.
781 Before, the code sometimes used 'Time', sometimes 'unsigned long',
782 and sometimes 'EMACS_UINT', to represent these timestamps.
783 This change causes it to use 'Time' uniformly, as that's what X uses.
784 This makes the code easier to follow, and makes it easier to catch
785 integer overflow bugs such as Bug#8664.
786 * frame.c (Fmouse_position, Fmouse_pixel_position):
787 Use Time, not unsigned long, for user-interface timestamps.
788 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
789 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
790 * keyboard.h (last_event_timestamp): Likewise.
791 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
792 * menu.h (xmenu_show): Likewise.
793 * term.c (term_mouse_position): Likewise.
794 * termhooks.h (struct input_event.timestamp): Likewise.
795 (struct terminal.mouse_position_hook): Likewise.
796 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
797 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
798 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
799 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
800 what it was before.
801 * menu.h, termhooks.h: Include "systime.h", for Time.
802
803 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
804 Don't assume that the difference between two unsigned long values
805 can fit into an integer. At this point, we know button_down_time
806 <= event->timestamp, so the difference must be nonnegative, so
807 there's no need to cast the result if double-click-time is
808 nonnegative, as it should be; check that it's nonnegative, just in
809 case. This bug is triggered when events are more than 2**31 ms
810 apart (about 25 days). (Bug#8664)
811
812 * xselect.c (last_event_timestamp): Remove duplicate decl.
813 (x_own_selection): Remove needless cast to unsigned long.
814
815 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
816 that always fit in int. Use a sentinel instead of a counter, to
817 avoid a temp and to allay GCC's concerns about possible int overflow.
818 * frame.h (struct frame): Use int for menu_bar_items_used
819 instead of EMACS_INT, since it always fits in int.
820
821 * menu.c (grow_menu_items): Check for int overflow.
822
823 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
824
825 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
826 Before, the code was not consistent. These values cannot exceed
827 2**31 - 1 so there's no need to make them unsigned.
828 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
829 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
830 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
831 as modifiers.
832 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
833
834 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
835 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
836 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
837 presumably because the widths might not match.
838
839 * window.c (size_window): Avoid needless test at loop start.
840
841 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
842
843 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
844
845 2011-05-12 Drew Adams <drew.adams@oracle.com>
846
847 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
848
849 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
850
851 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
852 `width' to `bar_area_x' and `bar_area_width', respectively.
853 (x_scroll_run): Take account of fringe background extension.
854
855 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
856 Rename local vars `left' and `width' to `bar_area_x' and
857 `bar_area_width', respectively.
858 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
859 background extension.
860
861 2011-05-10 Jim Meyering <meyering@redhat.com>
862
863 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
864
865 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
866
867 * image.c (Finit_image_library): Return t for built-in image types,
868 like pbm and xbm. (Bug#8640)
869
870 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
871
872 * w32menu.c (set_frame_menubar): Fix submenu allocation.
873
874 2011-05-07 Eli Zaretskii <eliz@gnu.org>
875
876 * w32console.c (Fset_screen_color): Doc fix.
877 (Fget_screen_color): New function.
878 (syms_of_ntterm): Defsubr it.
879
880 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
881 unlink the temporary file if Fcall_process didn't create it in the
882 first place.
883 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
884 child process will be redirected to a file specified with `:file'.
885 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
886 cue to call_process_cleanup not to close that handle.
887
888 2011-05-07 Ben Key <bkey76@gmail.com>
889
890 * makefile.w32-in: The bootstrap-temacs rule now makes use of
891 one of two shell specific rules, either bootstrap-temacs-CMD or
892 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
893 to the previous implementation of the bootstrap-temacs rule.
894 The bootstrap-temacs-CMD rule is similar to the previous
895 implementation of the bootstrap-temacs rule except that it
896 makes use of the ESC_CFLAGS variable instead of the CFLAGS
897 variable.
898
899 These changes, along with some changes to nt/configure.bat,
900 nt/gmake.defs, and nt/nmake.defs, are required to extend my
901 earlier fix to add support for --cflags and --ldflags options
902 that include quotes so that it works whether make uses cmd or
903 sh as the shell.
904
905 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
906
907 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
908 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
909 is a constant.
910 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
911 a string. Handle both cases.
912 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
913 (Fdbus_register_method): Use Qinvalid_function.
914
915 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
916
917 * makefile.w32-in: Update dependencies.
918 (LISP_H): Add inttypes.h and stdin.h.
919 (PROCESS_H): Add unistd.h.
920
921 2011-05-06 Eli Zaretskii <eliz@gnu.org>
922
923 * lread.c: Include limits.h (fixes the MS-Windows build broken by
924 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
925
926 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
927
928 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
929
930 * term.c (vfatal): Remove stray call to va_end.
931 It's not needed and the C Standard doesn't allow it here anyway.
932
933 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
934 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
935
936 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
937 bytes.
938
939 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
940
941 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
942
943 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
944
945 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
946
947 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
948
949 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
950 * charset.c (Fdefine_charset_internal): Don't initialize
951 charset.code_space[15]. The value was garbage, on hosts with
952 32-bit int (Bug#8600).
953
954 * lread.c (read_integer): Be more consistent with string-to-number.
955 Use string_to_number to do the actual conversion; this avoids
956 rounding errors and fixes some other screwups. Without this fix,
957 for example, #x1fffffffffffffff was misread as -2305843009213693952.
958 (digit_to_number): Move earlier, for benefit of read_integer.
959 Return -1 if the digit is out of range for the base, -2 if it is
960 not a digit in any supported base. (Bug#8602)
961
962 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
963
964 * dispnew.c (scrolling_window): Return 1 if we scrolled,
965 to match comment at start of function. This also removes a
966 GCC warning about overflow in a 32+64-bit port.
967
968 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
969
970 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
971 Reported by Stefan Monnier in
972 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
973 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
974 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
975
976 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
977 (EMACS_UINTPTR): Likewise, with uintptr_t.
978
979 * lisp.h: Prefer 64-bit EMACS_INT if available.
980 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
981 on 32-bit hosts that have 64-bit int, so that they can access
982 large files.
983 However, temporarily disable this change unless the temporary
984 symbol WIDE_EMACS_INT is defined.
985
986 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
987
988 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
989 This removes an assumption that EMACS_INT and long are the same
990 width as pointers. The assumption is true for Emacs porting targets
991 now, but we want to make other targets possible.
992 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
993 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
994 In the rest of the code, change types of integers that hold casted
995 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
996 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
997 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
998 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
999 No need to cast type when ORing.
1000 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1001 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1002 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1003 assume EMACS_INT is the same width as char *.
1004 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1005 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1006 Remove no-longer-needed casts.
1007 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1008 (xg_tool_bar_help_callback, xg_make_tool_item):
1009 Use EMACS_INTPTR to hold an integer
1010 that will be cast to void *; this can avoid a GCC warning
1011 if EMACS_INT is not the same width as void *.
1012 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1013 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1014 (current_message_1, set_message_1):
1015 Use a local to convert to proper width without a cast.
1016 * xmenu.c (dialog_selection_callback): Likewise.
1017
1018 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1019 Also, don't assume VALBITS / RAND_BITS is less than 5,
1020 and don't rely on undefined behavior when shifting a 1 left into
1021 the sign bit.
1022 * lisp.h (get_random): Change signature to match.
1023
1024 * lread.c (hash_string): Use size_t, not int, for hash computation.
1025 Normally we prefer signed values; but hashing is special, because
1026 it's better to use unsigned division on hash table sizes so that
1027 the remainder is nonnegative. Also, size_t is the natural width
1028 for hashing into memory. The previous code used 'int', which doesn't
1029 retain enough info to hash well into very large tables.
1030 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1031
1032 * dbusbind.c: Don't possibly lose pointer info when converting.
1033 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1034 Use XPNTR rather than XHASH, so that the high-order bits of
1035 the pointer aren't lost when converting through void *.
1036
1037 * eval.c (Fautoload): Don't double-shift a pointer.
1038
1039 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1040
1041 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1042
1043 * gnutls.c (DEF_GNUTLS_FN):
1044 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1045
1046 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1047
1048 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1049 marker. (Bug#8610)
1050
1051 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1052
1053 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1054 New version that can reserve upto 2GB of heap space.
1055
1056 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1057
1058 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1059
1060 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1061
1062 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1063 `gnutls_certificate_set_x509_key_file'.
1064
1065 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1066
1067 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1068 Update dependencies.
1069
1070 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1071
1072 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1073 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1074 Remove unused parameter `fildes'.
1075 * process.c (read_process_output, send_process): Don't pass it.
1076
1077 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1078
1079 Fix previous change: the library cache is defined in w32.c.
1080 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1081 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1082
1083 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1084
1085 Implement dynamic loading of GnuTLS on Windows.
1086
1087 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1088 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1089 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1090 Declare.
1091
1092 * gnutls.c (Qgnutls_dll): Define.
1093 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1094 (gnutls_*): Declare function pointers.
1095 (init_gnutls_functions): New function to initialize function pointers.
1096 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1097 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1098 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1099 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1100 (emacs_gnutls_write, emacs_gnutls_read)
1101 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1102 (Fgnutls_available_p): New function.
1103 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1104 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1105 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1106
1107 * image.c: Include w32.h.
1108 (Vimage_type_cache): Delete.
1109 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1110 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1111 (w32_delayed_load): Move to w32.c.
1112
1113 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1114
1115 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1116 (w32_delayed_load): Move from image.c. When loading a library, record
1117 its filename in the :loaded-from property of the library id.
1118 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1119 Initialize and staticpro them.
1120 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1121
1122 * process.c: Include lisp.h before w32.h, not after.
1123 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1124 instead of gnutls_record_check_pending.
1125
1126 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1127
1128 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1129
1130 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1131 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1132 as passed in.
1133
1134 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1135
1136 * xterm.c (x_set_frame_alpha): Do not set property on anything
1137 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1138
1139 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1140
1141 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1142
1143 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1144
1145 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1146 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1147 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1148 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1149 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1150 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1151 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1152 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1153 (Qgnutls_bootprop_callbacks_verify): Make static.
1154
1155 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1156
1157 * callproc.c: Indentation fixup.
1158
1159 * sysdep.c (wait_for_termination_1): Make static.
1160 (wait_for_termination, interruptible_wait_for_termination):
1161 Move after wait_for_termination_1.
1162
1163 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1164
1165 * sysdep.c (interruptible_wait_for_termination): New function
1166 which is like wait_for_termination, but allows keyboard
1167 interruptions.
1168
1169 * callproc.c (Fcall_process): Add (:file "file") as an option for
1170 the STDOUT buffer.
1171 (Fcall_process_region): Ditto.
1172
1173 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1174
1175 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1176 rather than `XVECTOR (FOO)->size'.
1177
1178 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1179 inttypes.h, as a gnulib replacement is used if it not available in
1180 system headers.
1181
1182 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1183
1184 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1185 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1186 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1187
1188 * coding.c (coding_alloc_by_realloc): Error out if destination
1189 will grow beyond MOST_POSITIVE_FIXNUM.
1190 (decode_coding_emacs_mule): Abort if there isn't enough place in
1191 charbuf for the composition carryover bytes. Reserve an extra
1192 space for up to 2 characters produced in a loop.
1193 (decode_coding_iso_2022): Abort if there isn't enough place in
1194 charbuf for the composition carryover bytes.
1195
1196 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1197
1198 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1199 aborting when %lld or %lll format is passed.
1200 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1201 %llo or %llx format is passed. (Bug#8545)
1202
1203 * window.c (window_scroll_line_based): Use a marker instead of
1204 simple variables to record original value of point. (Bug#7952)
1205
1206 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1207 produced by %s or %c overflows available buffer space. (Bug#8545)
1208
1209 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1210
1211 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1212 (SIZE_MAX): Move defn after all includes, as they might #define it.
1213
1214 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1215
1216 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1217
1218 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1219
1220 * keyboard.c (Qdelayed_warnings_hook): Define.
1221 (command_loop_1): Run `delayed-warnings-hook'
1222 if Vdelayed_warnings_list is non-nil.
1223 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1224 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1225
1226 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1227
1228 * doprnt.c (doprnt): Don't return value smaller than the buffer
1229 size if the message was truncated. (Bug#8545).
1230
1231 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1232
1233 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1234 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1235
1236 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1237
1238 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1239
1240 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1241
1242 * makefile.w32-in: Update dependencies.
1243
1244 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1245
1246 Improve `doprnt' and its usage. (Bug#8545)
1247 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1248 `format_end'. Remove support for %l as a conversion specifier.
1249 Don't use xrealloc. Improve diagnostics when the %l size modifier
1250 is used. Update the commentary.
1251
1252 * eval.c (verror): Simplify calculation of size_t.
1253
1254 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1255 messages.
1256
1257 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1258
1259 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1260 change.
1261
1262 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1263
1264 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1265 This makes this file independent of the recent pseudovector change.
1266
1267 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1268
1269 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1270
1271 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1272 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1273 Remove unused local.
1274 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1275
1276 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1277 GCC 4.6.0 optimizes based on type-based alias analysis.
1278 For example, if b is of type struct buffer * and v of type struct
1279 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1280 != &v->size, and therefore "v->size = 1; b->size = 2; return
1281 v->size;" must therefore return 1. This assumption is incorrect
1282 for Emacs, since it type-puns struct Lisp_Vector * with many other
1283 types. To fix this problem, this patch adds a new type struct
1284 vectorlike_header that documents the constraints on layout of vectors
1285 and pseudovectors, and helps optimizing compilers not get fooled
1286 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1287 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1288 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1289 the size member.
1290 (XSETPVECTYPE): Rewrite in terms of new macro.
1291 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1292 This is a bit clearer, and further avoids the possibility of
1293 undesirable aliasing.
1294 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1295 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1296 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1297 since Lisp_Subr is a special case (no "next" field).
1298 (ASIZE): Now uses header.size rather than size.
1299 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1300 to avoid the hassle of writing XVECTOR (foo)->header.size.
1301 (struct vectorlike_header): New type.
1302 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1303 object, to help avoid aliasing.
1304 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1305 (SUBRP): Likewise, since Lisp_Subr is a special case.
1306 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1307 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1308 (struct Lisp_Hash_Table): Combine first two members into a single
1309 struct vectorlike_header member. All uses of "size" and "next" members
1310 changed to be "header.size" and "header.next".
1311 * buffer.h (struct buffer): Likewise.
1312 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1313 * frame.h (struct frame): Likewise.
1314 * process.h (struct Lisp_Process): Likewise.
1315 * termhooks.h (struct terminal): Likewise.
1316 * window.c (struct save_window_data, struct saved_window): Likewise.
1317 * window.h (struct window): Likewise.
1318 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1319 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1320 * buffer.c (init_buffer_once): Likewise.
1321 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1322 special case.
1323 * process.c (Fformat_network_address): Use local var for size,
1324 for brevity.
1325
1326 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1327
1328 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1329 * data.c (atof): Remove decl; no longer used or needed.
1330 (digit_to_number): Move to lread.c.
1331 (Fstring_to_number): Use new string_to_number function, to be
1332 consistent with how the Lisp reader treats infinities and NaNs.
1333 Do not assume that floating-point numbers represent EMACS_INT
1334 without losing information; this is not true on most 64-bit hosts.
1335 Avoid double-rounding errors, by insisting on integers when
1336 parsing non-base-10 numbers, as the documentation specifies.
1337 * lisp.h (string_to_number): New decl, replacing ...
1338 (isfloat_string): Remove.
1339 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1340 (read1): Do not accept +. and -. as integers; this
1341 appears to have been a coding error. Similarly, do not accept
1342 strings like +-1e0 as floating point numbers. Do not report
1343 overflow for integer overflows unless the base is not 10 which
1344 means we have no simple and reliable way to continue.
1345 Break out the floating-point parsing into a new
1346 function string_to_number, so that Fstring_to_number parses
1347 floating point numbers consistently with the Lisp reader.
1348 (digit_to_number): Move here from data.c. Make it static inline.
1349 (E_CHAR, EXP_INT): Remove, replacing with ...
1350 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1351 (string_to_number): New function, replacing isfloat_string.
1352 This function checks for valid syntax and produces the resulting
1353 Lisp float number too. Rework it so that string-to-number
1354 no longer mishandles examples like "1.0e+". Use strtoumax,
1355 so that overflow for non-base-10 numbers is reported only when
1356 there's no portable and simple way to convert to floating point.
1357
1358 * textprop.c (set_text_properties_1): Rewrite for clarity,
1359 and to avoid GCC warning about integer overflow.
1360
1361 * intervals.h (struct interval): Use EMACS_INT for members
1362 where EMACS_UINT might cause problems. See
1363 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1364 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1365 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1366 All uses changed.
1367 (offset_intervals): Tell GCC not to worry about length overflow
1368 when negating a negative length.
1369
1370 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1371 (overrun_check_free): Likewise.
1372
1373 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1374 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1375 word size.
1376
1377 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1378 (gnutls_make_error): Rename local to avoid shadowing.
1379 (gnutls_emacs_global_deinit): ifdef out; not used.
1380 (Fgnutls_boot): Use const for pointer to readonly storage.
1381 Comment out unused local. Fix pointer signedness problems.
1382
1383 * lread.c (openp): Don't stuff size_t into an 'int'.
1384 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1385 about possible signed overflow.
1386
1387 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1388 (GDK_KEY_g): Don't define if already defined.
1389 (xg_prepare_tooltip): Avoid pointer signedness problem.
1390 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1391
1392 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1393 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1394
1395 * xfns.c (Fx_window_property): Simplify a bit,
1396 to make a bit faster and to avoid GCC 4.6.0 warning.
1397 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1398
1399 * fns.c (internal_equal): Don't assume size_t fits in int.
1400
1401 * alloc.c (compact_small_strings): Tighten assertion a little.
1402
1403 Replace pEd with more-general pI, and fix some printf arg casts.
1404 * lisp.h (pI): New macro, generalizing old pEd macro to other
1405 conversion specifiers. For example, use "...%"pI"d..." rather
1406 than "...%"pEd"...".
1407 (pEd): Remove. All uses replaced with similar uses of pI.
1408 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1409 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1410 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1411 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1412 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1413 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1414 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1415 64-bit hosts.
1416 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1417 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1418 * print.c (safe_debug_print, print_object): Likewise.
1419 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1420 to int.
1421 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1422 avoiding the 0 flag, which is not portable.
1423 * process.c (Fmake_network_process): Use pI to avoid cast.
1424 * region-cache.c (pp_cache): Likewise.
1425 * xdisp.c (decode_mode_spec): Likewise.
1426 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1427 behavior on 64-bit hosts with printf arg.
1428 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
1429 (x_stop_queuing_selection_requests): Likewise.
1430 (x_get_window_property): Don't truncate byte count to an 'int'
1431 when tracing.
1432
1433 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1434 here, since it parses constructs like leading '-' and spaces,
1435 which are not wanted; and it overflows with large numbers.
1436 Instead, simply match F[0-9]+, which is what is wanted anyway.
1437
1438 * alloc.c: Remove unportable assumptions about struct layout.
1439 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1440 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1441 (allocate_vectorlike, make_pure_vector): Use the new macros,
1442 plus offsetof, to remove unportable assumptions about struct layout.
1443 These assumptions hold on all porting targets that I know of, but
1444 they are not guaranteed, they're easy to remove, and removing them
1445 makes further changes easier.
1446
1447 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1448 This doesn't fix a bug but makes the code clearer.
1449 (string_overrun_cookie): Now const. Use initializers that
1450 don't formally overflow signed char, to avoid warnings.
1451 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1452 can cause Emacs to crash when string overrun checking is enabled.
1453 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1454 multiple of sizeof (EMACS_INT); it need not be, if
1455 alignof(EMACS_INT) < sizeof (EMACS_INT).
1456 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
1457
1458 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
1459
1460 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1461
1462 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1463
1464 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
1465 supposed to be handshaking. (Bug#8556)
1466 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1467
1468 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
1469
1470 * lisp.h (Qdebug): List symbol.
1471 * eval.c (Qdebug): Restore global linkage.
1472 * keyboard.c (debug-on-event): New variable.
1473 (handle_user_signal): Break into debugger when debug-on-event
1474 matches the current signal symbol.
1475
1476 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1477
1478 * alloc.c (check_sblock, check_string_bytes)
1479 (check_string_free_list): Convert to standard C.
1480
1481 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1482
1483 * w32.c (emacs_gnutls_push): Fix typo.
1484
1485 2011-04-25 Eli Zaretskii <eliz@gnu.org>
1486
1487 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1488 "cast to pointer from integer of different size".
1489
1490 Improve doprnt and its use in verror. (Bug#8545)
1491 * doprnt.c (doprnt): Document the set of format control sequences
1492 supported by the function. Use SAFE_ALLOCA instead of always
1493 using `alloca'.
1494
1495 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1496 is one byte too soon. Don't use xrealloc; instead xfree and
1497 xmalloc anew.
1498
1499 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1500
1501 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1502 callbacks stage.
1503
1504 * gnutls.c: Renamed global_initialized to
1505 gnutls_global_initialized. Added internals for the
1506 :verify-hostname-error, :verify-error, and :verify-flags
1507 parameters of `gnutls-boot' and documented those parameters in the
1508 docstring. Start callback support.
1509 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1510 unless a fatal error occured. Call gnutls_alert_send_appropriate
1511 on error. Return error code.
1512 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1513 (emacs_gnutls_read): Likewise.
1514 (Fgnutls_boot): Return handshake error code.
1515 (emacs_gnutls_handle_error): New function.
1516 (wsaerror_to_errno): Likewise.
1517
1518 * w32.h (emacs_gnutls_pull): Add prototype.
1519 (emacs_gnutls_push): Likewise.
1520
1521 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1522 (emacs_gnutls_push): Likewise.
1523
1524 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1525
1526 * process.c (wait_reading_process_output): Check if GnuTLS
1527 buffered some data internally if no FDs are set for TLS
1528 connections.
1529
1530 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1531 (LIBS): Link to USER_LIBS.
1532 ($(BLD)/gnutls.$(0)): New target.
1533
1534 2011-04-24 Eli Zaretskii <eliz@gnu.org>
1535
1536 * xdisp.c (handle_single_display_spec): Rename the
1537 display_replaced_before_p argument into display_replaced_p, to
1538 make it consistent with the commentary. Fix typos in the
1539 commentary.
1540
1541 * textprop.c (syms_of_textprop): Remove dead code.
1542 (copy_text_properties): Delete obsolete commentary about an
1543 interface that was deleted long ago. Fix typos in the description
1544 of arguments.
1545
1546 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1547 to changes in oldXMenu/XMenu.h from 2011-04-16.
1548 <menu_help_message, prev_menu_help_message>: Constify.
1549 (IT_menu_make_room): menu->help_text is now `const char **';
1550 adjust.
1551
1552 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1553 to changes in oldXMenu/XMenu.h from 2011-04-16.
1554 (struct XMenu): Declare `help_text' `const char **'.
1555
1556 * xfaces.c <Qunspecified>: Make extern again.
1557
1558 * syntax.c: Include sys/types.h before including regex.h, as
1559 required by Posix.
1560
1561 * doc.c (get_doc_string): Improve the format passed to `error'.
1562
1563 * doprnt.c (doprnt): Improve commentary.
1564
1565 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1566
1567 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1568 them with etags.
1569
1570 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1571 changes in globals.h immediately force recompilation.
1572 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1573 $(CURDIR)/s/ms-w32.h.
1574 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
1575
1576 * character.c (Fchar_direction): Function deleted.
1577 (syms_of_character): Don't defsubr it.
1578 <char-direction-table>: Deleted.
1579
1580 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1581
1582 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1583 * doprnt.c: Include limits.h.
1584 (SIZE_MAX): New macro.
1585 (doprnt): Return a size_t value. 2nd arg is now size_t.
1586 Many local variables are now size_t instead of int or unsigned.
1587 Improve overflow protection. Support `l' modifier for integer
1588 conversions. Support %l conversion. Don't assume an EMACS_INT
1589 argument for integer conversions and for %c.
1590
1591 * lisp.h (doprnt): Restore prototype.
1592
1593 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1594 $(SRC)/character.h.
1595
1596 * Makefile.in (base_obj): Add back doprnt.o.
1597
1598 * deps.mk (doprnt.o): Add back prerequisites.
1599 (callint.o): Depend on character.h.
1600
1601 * eval.c (internal_lisp_condition_case): Include the handler
1602 representation in the error message.
1603 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1604 when breaking from the loop.
1605
1606 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1607
1608 * callint.c (Fcall_interactively): When displaying error message
1609 about invalid control letter, pass the character's codepoint, not
1610 a pointer to its multibyte form. Improve display of the character
1611 in octal and display also its hex code.
1612
1613 * character.c (char_string): Use %x to display the (unsigned)
1614 codepoint of an invalid character, to avoid displaying a bogus
1615 negative value.
1616
1617 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1618 `error', not SYMBOL_NAME itself.
1619
1620 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1621 character arguments to `error'.
1622
1623 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1624 to `error' in error message about FINAL_CHAR argument. Make sure
1625 FINAL_CHAR is a character, and use %c when it is passed as
1626 argument to `error'.
1627
1628 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1629
1630 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1631
1632 * w32.c: Include <time.h>.
1633 (sys_localtime): New function.
1634
1635 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
1636
1637 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1638
1639 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1640
1641 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1642
1643 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1644 zombies (Bug#8467).
1645
1646 2011-04-19 Eli Zaretskii <eliz@gnu.org>
1647
1648 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1649 gl_state.e_property when gl_state.object is Qt.
1650
1651 * insdel.c (make_gap_larger): Remove limitation of buffer size
1652 to <= INT_MAX.
1653
1654 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
1655
1656 * xdisp.c (lookup_glyphless_char_display)
1657 (produce_glyphless_glyph): Handle cons cell entry in
1658 glyphless-char-display.
1659 (Vglyphless_char_display): Document it.
1660
1661 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1662 glyphless-char-display.
1663
1664 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
1665
1666 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1667
1668 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1669
1670 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1671 definition for no-X builds.
1672
1673 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1674
1675 Static checks with GCC 4.6.0 and non-default toolkits.
1676
1677 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1678
1679 * process.c (keyboard_bit_set): Define only if SIGIO.
1680 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1681 (send_process): Repair possible setjmp clobbering.
1682
1683 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1684
1685 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1686
1687 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1688
1689 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1690 Define only if needed.
1691
1692 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1693 by pacifying GCC about it. Maybe it's time to retire it?
1694 * xfaces.c (USG, __TIMEVAL__): Likewise.
1695
1696 * dispextern.h (struct redisplay_interface): Rename param
1697 to avoid shadowing.
1698 * termhooks.h (struct terminal): Likewise.
1699 * xterm.c (xembed_send_message): Likewise.
1700
1701 * insdel.c (make_gap_smaller): Define only if
1702 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1703
1704 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1705 it.
1706
1707 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1708 so that we aren't warned about unused symbols.
1709
1710 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1711
1712 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1713
1714 * xfns.c (x_real_positions): Mark locals as initialized.
1715
1716 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1717
1718 * xterm.c: Fix problems found by static analysis with other toolkits.
1719 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1720 (x_dispatch_event): Declare static if USE_GTK, and
1721 define if USE_GTK || USE_X_TOOLKIT.
1722 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1723 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1724 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1725 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1726
1727 * xmenu.c (menu_help_callback): Pointer type fixes.
1728 Use const pointers when pointing at readonly data. Avoid pointer
1729 signedness clashes.
1730 (FALSE): Remove unused macro.
1731 (update_frame_menubar): Remove unused decl.
1732
1733 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1734
1735 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1736 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1737 (single_menu_item): Rename local to avoid shadowing.
1738
1739 * keyboard.c (make_lispy_event): Remove unused local var.
1740
1741 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1742 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1743
1744 * bitmaps: Change bitmaps from unsigned char back to the X11
1745 compatible char. Avoid the old compiler warnings about
1746 out-of-range initializers by using, for example, '\xab' rather
1747 than 0xab.
1748
1749 * xgselect.c (xgselect_initialize): Check vs interface
1750 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1751
1752 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1753
1754 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1755 to read-only memory.
1756
1757 * fns.c (vector): Remove; this old hack is no longer needed.
1758
1759 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1760 Remove unused var.
1761 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1762
1763 * xrdb.c (x_load_resources): Omit unused local.
1764
1765 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1766 (x_window): Rename locals to avoid shadowing.
1767 (USG): Use the kludged USG macro, to pacify gcc.
1768
1769 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1770 (x_term_init): Remove local to avoid shadowing.
1771
1772 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1773
1774 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1775 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1776
1777 2011-04-16 Eli Zaretskii <eliz@gnu.org>
1778
1779 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1780
1781 Fix regex.c, syntax.c and friends for buffers > 2GB.
1782 * syntax.h (struct gl_state_s): Declare character position members
1783 EMACS_INT.
1784
1785 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1786
1787 * textprop.c (verify_interval_modification, interval_of):
1788 Declare arguments EMACS_INT.
1789
1790 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1791 EMACS_INT.
1792
1793 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1794
1795 * indent.c (Fvertical_motion): Local variable it_start is now
1796 EMACS_INT.
1797
1798 * regex.c (re_match, re_match_2, re_match_2_internal)
1799 (bcmp_translate, regcomp, regexec, print_double_string)
1800 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1801 (re_compile_pattern, re_exec): Declare arguments and local
1802 variables `size_t' and `ssize_t' and return values `regoff_t', as
1803 appropriate.
1804 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1805 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1806 <compile_stack_type>: `size' and `avail' are now `size_t'.
1807
1808 * regex.h <regoff_t>: Use ssize_t, not int.
1809 (re_search, re_search_2, re_match, re_match_2): Arguments that
1810 specify buffer/string position and length are now ssize_t and
1811 size_t. Return type is regoff_t.
1812
1813 2011-04-16 Ben Key <bkey76@gmail.com>
1814
1815 * nsfont.m: Fixed bugs in ns_get_family and
1816 ns_descriptor_to_entity that were caused by using free to
1817 deallocate memory blocks that were allocated by xmalloc (via
1818 xstrdup). This caused Emacs to crash when compiled with
1819 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1820 --enable-checking=xmallocoverrun). xfree is now used to
1821 deallocate these memory blocks.
1822
1823 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1824
1825 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1826
1827 emacs_write: Accept and return EMACS_INT for sizes.
1828 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1829 et seq.
1830 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1831 Accept and return EMACS_INT.
1832 (emacs_gnutls_write): Return the number of bytes written on
1833 partial writes.
1834 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1835 (emacs_read, emacs_write): Remove check for negative size, as the
1836 Emacs source code has been audited now.
1837 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1838 (emacs_read, emacs_write): Use it.
1839 * process.c (send_process): Adjust to the new signatures of
1840 emacs_write and emacs_gnutls_write. Do not attempt to store
1841 a byte offset into an 'int'; it might overflow.
1842 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1843
1844 * sound.c: Don't assume sizes fit in 'int'.
1845 (struct sound_device.period_size, alsa_period_size):
1846 Return EMACS_INT, not int.
1847 (struct sound_device.write, vox_write, alsa_write):
1848 Accept EMACS_INT, not int.
1849 (wav_play, au_play): Use EMACS_INT to store sizes and to
1850 record read return values.
1851
1852 2011-04-15 Ben Key <bkey76@gmail.com>
1853
1854 * keyboard.c (Qundefined): Don't declare static since it is used
1855 in nsfns.m.
1856 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1857 static since they are used in nsfont.m.
1858
1859 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1860
1861 * process.c (Qprocessp): Don't declare static.
1862 * lisp.h (Qprocessp): Declare again.
1863
1864 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
1865
1866 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1867
1868 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1869
1870 Improve C-level modularity by making more things 'static'.
1871
1872 Don't publish debugger-only interfaces to other modules.
1873 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1874 (verify_bytepos, count_markers): Move decls to the only modules
1875 that need them.
1876 * region-cache.h (pp_cache): Likewise.
1877 * window.h (check_all_windows): Likewise.
1878 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1879
1880 * sysdep.c (croak): Now static, if
1881 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1882 * syssignal.h (croak): Declare only if not static.
1883
1884 * alloc.c (refill_memory_reserve): Now static if
1885 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1886 * lisp.h (refill_memory_reserve): Declare only if not static.
1887
1888 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1889 Define only if USE_LUCID.
1890
1891 * xrdb.c (x_customization_string, x_rm_string): Now static.
1892
1893 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1894 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1895
1896 * xdisp.c (draw_row_with_mouse_face): Now static.
1897 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1898
1899 * window.h (check_all_windows): Mark externally visible.
1900
1901 * window.c (window_deletion_count): Now static.
1902
1903 * undo.c: Make symbols static if they're not exported.
1904 (last_undo_buffer, last_boundary_position, pending_boundary):
1905 Now static.
1906
1907 * textprop.c (interval_insert_behind_hooks): Now static.
1908 (interval_insert_in_front_hooks): Likewise.
1909
1910 * term.c: Make symbols static if they're not exported.
1911 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1912 (max_frame_lines, tty_set_terminal_modes):
1913 (tty_reset_terminal_modes, tty_turn_off_highlight):
1914 (get_tty_terminal): Now static.
1915 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1916 * termhooks.h (term_mouse_moveto): Do not declare if
1917 HAVE_WINDOW_SYSTEM.
1918 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1919 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1920
1921 * sysdep.c: Make symbols static if they're not exported.
1922 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1923 Now static.
1924 (sigprocmask_set, full_mask): Remove; unused.
1925 (wait_debugging): Mark as visible.
1926 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1927 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1928
1929 * syntax.c (syntax_temp): Define only if !__GNUC__.
1930
1931 * sound.c (current_sound_device, current_sound): Now static.
1932
1933 * search.c (searchbufs, searchbuf_head): Now static.
1934
1935 * scroll.c (scroll_cost): Remove; unused.
1936 * dispextern.h (scroll_cost): Remove decl.
1937
1938 * region-cache.h (pp_cache): Mark as externally visible.
1939
1940 * process.c: Make symbols static if they're not exported.
1941 (process_tick, update_tick, create_process, chan_process):
1942 (Vprocess_alist, proc_buffered_char, datagram_access):
1943 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1944 (deactivate_process): Mark defn as static, as well as decl.
1945 * lisp.h (create_process): Remove decl.
1946 * process.h (chan_process, Vprocess_alist): Remove decls.
1947
1948 * print.c: Make symbols static if they're not exported.
1949 (print_depth, new_backquote_output, being_printed, print_buffer):
1950 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1951 (print_interval, print_number_index, initial_stderr_stream):
1952 Now static.
1953 * lisp.h (Fprinc): Remove decl.
1954 (debug_output_compilation_hack): Mark as externally visible.
1955
1956 * sysdep.c (croak): Move decl from here to syssignal.h.
1957 * syssignal.h (croak): Put it here, so the API can be checked when
1958 'croak' is called from dissociate_if_controlling_tty.
1959
1960 * minibuf.c: Make symbols static if they're not exported.
1961 (minibuf_save_list, choose_minibuf_frame): Now static.
1962 * lisp.h (choose_minibuf_frame): Remove decl.
1963
1964 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1965
1966 * lread.c: Make symbols static if they're not exported.
1967 (read_objects, initial_obarray, oblookup_last_bucket_number):
1968 Now static.
1969 (make_symbol): Remove; unused.
1970 * lisp.h (initial_obarray, make_symbol): Remove decls.
1971
1972 * keyboard.c: Make symbols static if they're not exported.
1973 (single_kboard, recent_keys_index, total_keys, recent_keys):
1974 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1975 (this_single_command_key_start, echoing, last_auto_save):
1976 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1977 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1978 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1979 (Vlispy_mouse_stem, double_click_count):
1980 Now static.
1981 (force_auto_save_soon): Define only if SIGDANGER.
1982 (ignore_mouse_drag_p): Now static if
1983 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1984 (print_help): Remove; unused.
1985 (stop_character, last_timer_event): Mark as externally visible.
1986 * keyboard.h (ignore_mouse_drag_p): Declare only if
1987 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1988 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1989 * lisp.h (echoing): Remove decl.
1990 (force_auto_save_soon): Declare only if SIGDANGER.
1991 * xdisp.c (redisplay_window): Simplify code, to make it more
1992 obvious that ignore_mouse_drag_p is not accessed if !defined
1993 USE_GTK && !defined HAVE_NS.
1994
1995 * intervals.c: Make symbols static if they're not exported.
1996 (merge_properties_sticky, merge_interval_right, delete_interval):
1997 Now static.
1998 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1999
2000 * insdel.c: Make symbols static if they're not exported.
2001 However, leave prepare_to_modify_buffer alone. It's never
2002 called from outside this function, but that appears to be a bug.
2003 (combine_after_change_list, combine_after_change_buffer):
2004 (adjust_after_replace, signal_before_change): Now static.
2005 (adjust_after_replace_noundo): Remove; unused.
2006 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2007 (signal_before_change): Remove decls.
2008
2009 * indent.c (val_compute_motion, val_vmotion): Now static.
2010
2011 * image.c: Make symbols static if they're not exported.
2012 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2013 if USE_GTK.
2014 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2015 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2016
2017 * fringe.c (standard_bitmaps): Now static.
2018 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2019
2020 * frame.c: Make symbols static if they're not exported.
2021 (x_report_frame_params, make_terminal_frame): Now static.
2022 (get_frame_param): Now static, unless HAVE_NS.
2023 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2024 (x_get_resource_string): Remove; not used.
2025 * frame.h (make_terminal_frame, x_report_frame_params):
2026 (x_get_resource_string); Remove decls.
2027 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2028 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2029
2030 * font.c, fontset.c: Make symbols static if they're not exported.
2031 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2032 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2033 * font.c (font_close_object): Now static.
2034 * font.h (font_close_object): Remove.
2035 * fontset.c (FONTSET_OBJLIST): Remove.
2036 (free_realized_fontset) #if-0 the body, which does nothing.
2037 (face_suitable_for_char_p): #if-0, as it's never called.
2038 * fontset.h (face_suitable_for_char_p): Remove decl.
2039 * xfaces.c (face_at_string_position):
2040 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2041 since 0 is always ASCII.
2042
2043 * fns.c (weak_hash_tables): Now static.
2044
2045 * fileio.c: Make symbols static if they're not exported.
2046 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2047 (Vwrite_region_annotation_buffers): Now static.
2048
2049 * eval.c: Make symbols static if they're not exported.
2050 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2051 * lisp.h (backtrace_list): Remove decl.
2052
2053 * emacs.c: Make symbols static if they're not exported.
2054 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2055 (fatal_error_code, fatal_error_signal_hook, standard_args):
2056 Now static.
2057 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2058 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2059 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2060 * lisp.h (fatal_error_signal_hook): Remove decl.
2061 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2062
2063 * editfns.c: Move a (normally-unused) function to its only use.
2064 * editfns.c, lisp.h (get_operating_system_release): Remove.
2065 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2066 worth the hassle of breaking this out.
2067
2068 * xterm.c: Make symbols static if they're not exported.
2069 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2070 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2071 (x_destroy_window, x_delete_display):
2072 Now static.
2073 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2074 (x_mouse_leave): Remove; unused.
2075 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2076 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2077 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2078 Remove decls.
2079 (x_mouse_leave): Declare only if WINDOWSNT.
2080 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2081 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2082 USE_X_TOOLKIT.
2083
2084 * ftxfont.c: Make symbols static if they're not exported.
2085 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2086 HAVE_FREETYPE.
2087 * font.h (ftxfont_driver): Likewise.
2088
2089 * xfns.c: Make symbols static if they're not exported.
2090 (x_last_font_name, x_display_info_for_name):
2091 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2092 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2093 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2094 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2095 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2096 (last_show_tip_args): Now static.
2097 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2098 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2099 (x_screen_planes): Remove; unused.
2100 * dispextern.h (x_screen_planes): Remove decl.
2101
2102 * dispnew.c: Make symbols static if they're not exported.
2103 * dispextern.h (redraw_garbaged_frames, scrolling):
2104 (increment_row_positions): Remove.
2105 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2106 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2107 Now static.
2108 (redraw_garbaged_frames): Remove; unused.
2109
2110 * xfaces.c: Make symbols static if they're not exported.
2111 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2112 Remove decls.
2113 * xterm.h (defined_color): Remove decls.
2114 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2115 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2116 (menu_face_changed_default, defined_color, free_realized_face):
2117 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2118 (ascii_face_of_lisp_face): Remove; unused.
2119
2120 * xdisp.c: Make symbols static if they're not exported.
2121 * dispextern.h (scratch_glyph_row, window_box_edges):
2122 (glyph_to_pixel_coords, set_cursor_from_row):
2123 (get_next_display_element, set_iterator_to_next):
2124 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2125 (show_mouse_face): Remove decls
2126 * frame.h (message_buf_print): Likewise.
2127 * lisp.h (pop_message, set_message, check_point_in_composition):
2128 Likewise.
2129 * xterm.h (set_vertical_scroll_bar): Likewise.
2130 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2131 (message_buf_print, scratch_glyph_row, displayed_buffer):
2132 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2133 (get_next_display_element, show_mouse_face, window_box_edges):
2134 (frame_to_window_pixel_xy, check_point_in_composition):
2135 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2136 (glyph_to_pixel_coords): Remove; unused.
2137
2138 * dired.c (file_name_completion): Now static.
2139
2140 * dbusbind.c (xd_in_read_queued_messages): Now static.
2141
2142 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2143 * data.c (circular_list_error): Remove.
2144
2145 * commands.h (last_point_position, last_point_position_buffer):
2146 (last_point_position_window): Remove decls.
2147 * keyboard.c: Make these variables static.
2148
2149 * coding.h (coding, code_convert_region, encode_coding_gap):
2150 Remove decls.
2151 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2152 (iso_code_class, detect_coding, code_convert_region): Now static.
2153 (encode_coding_gap): Remove; unused.
2154
2155 * chartab.c (chartab_chars, chartab_bits): Now static.
2156
2157 * charset.h (charset_iso_8859_1): Remove decl.
2158 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2159 Now static.
2160
2161 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2162 * ccl.c (Vccl_program_table): Now static.
2163 (check_ccl_update): Remove; unused.
2164
2165 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2166 * category.h: ... from here.
2167 * category.c (check_category_table, set_category_set): Now static.
2168
2169 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2170 * lisp.h: Remove these decls.
2171
2172 * buffer.c (buffer_count): Remove unused var.
2173
2174 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2175 so that it's not optimized away.
2176 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2177 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2178 exported only to the debugger.
2179
2180 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2181 * atimer.h (run_all_atimers): Remove; not exported.
2182
2183 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2184 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2185 was inaccessible from Lisp.
2186 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2187 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2188
2189 alloc.c: Import and export fewer symbols, and remove unused items.
2190 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2191 is defined.
2192 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2193 it's not optimized away by whole-program optimization.
2194 (message_enable_multibyte, free_misc): Remove.
2195 (catchlist, handlerlist, mark_backtrace):
2196 Declare only if BYTE_MARK_STACK.
2197 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2198 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2199 (message_enable_multibyte): Remove decl.
2200 (free_misc, interval_free_list, float_block, float_block_index):
2201 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2202 (cons_free_list, last_marked_index):
2203 Now static.
2204 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2205 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2206 (mark_backtrace): Define only if BYTE_MARK_STACK.
2207 * xdisp.c (message_enable_multibyte): Now static.
2208
2209 Declare Lisp_Object Q* variables to be 'static' if not exported.
2210 This makes it easier for human readers (and static analyzers)
2211 to see whether these variables are used from other modules.
2212 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2213 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2214 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2215 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2216 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2217 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2218 * xmenu.c, xselect.c:
2219 Declare Q* vars static if they are not used in other modules.
2220 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2221 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2222 Remove decls of unexported vars.
2223 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2224
2225 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2226
2227 Make Emacs functions such as Fatom 'static' by default.
2228 This makes it easier for human readers (and static analyzers)
2229 to see whether these functions can be called from other modules.
2230 DEFUN now defines a static function. To make the function external
2231 so that it can be used in other C modules, use the new macro DEFUE.
2232 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2233 (Finit_image_library):
2234 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2235 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2236 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2237 Remove decls, since these functions are now static.
2238 (Funintern, Fget_internal_run_time): New decls, since these functions
2239 were already external.
2240
2241 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2242 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2243 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2244 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2245 * keyboard.c, keymap.c, lread.c:
2246 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2247 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2248 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2249 Mark functions with DEFUE instead of DEFUN,
2250 if they are used in other modules.
2251 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2252 decls for now-static functions.
2253 * buffer.h (Fdelete_overlay): Remove decl.
2254 * callproc.c (Fgetenv_internal): Mark as internal.
2255 * composite.c (Fremove_list_of_text_properties): Remove decl.
2256 (Fcomposition_get_gstring): New forward static decl.
2257 * composite.h (Fcomposite_get_gstring): Remove decl.
2258 * dired.c (Ffile_attributes): New forward static decl.
2259 * doc.c (Fdocumntation_property): New forward static decl.
2260 * eval.c (Ffetch_bytecode): New forward static decl.
2261 (Funintern): Remove extern decl; now in .h file where it belongs.
2262 * fileio.c (Fmake_symbolic_link): New forward static decl.
2263 * image.c (Finit_image_library): New forward static decl.
2264 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2265 * intervals.h (Fprevious_property_change):
2266 (Fremove_list_of_text_properties): Remove decls.
2267 * keyboard.c (Fthis_command_keys): Remove decl.
2268 (Fcommand_execute): New forward static decl.
2269 * keymap.c (Flookup_key): New forward static decl.
2270 (Fcopy_keymap): Now static.
2271 * keymap.h (Flookup_key): Remove decl.
2272 * process.c (Fget_process): New forward static decl.
2273 (Fprocess_datagram_address): Mark as internal.
2274 * syntax.c (Fsyntax_table_p): New forward static decl.
2275 (skip_chars): Remove duplicate decl.
2276 * textprop.c (Fprevious_property_change): New forward static decl.
2277 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2278 Now internal.
2279 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2280 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2281
2282 * editfns.c (Fformat): Remove unreachable code.
2283
2284 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2285
2286 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2287 change. (Bug#8496)
2288
2289 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2290
2291 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2292 when at ZV. (Bug#8487)
2293
2294 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2295
2296 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2297 (Bug#8437)
2298 * keyboard.c (parse_tool_bar_item): Likewise.
2299 * sound.c (sound_cleanup, alsa_close): Likewise.
2300 * termcap.c (tgetent): Likewise.
2301 * xfns.c (x_default_font_parameter): Likewise.
2302 * xsettings.c (read_and_apply_settings): Likewise.
2303
2304 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2305 (overrun_check_free): Protoize.
2306
2307 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2308
2309 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2310 since callers should never pass a negative size.
2311 Change the signature to match that of plain 'read' and 'write'; see
2312 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2313 * lisp.h: Update prototypes of emacs_write and emacs_read.
2314
2315 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2316
2317 * xdisp.c (redisplay_window): Don't try to determine the character
2318 position of the scroll margin if the window start point w->startp
2319 is outside the buffer's accessible region. (Bug#8468)
2320
2321 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2322
2323 Fix write-region and its subroutines for buffers > 2GB.
2324 * fileio.c (a_write, e_write): Modify declaration of arguments and
2325 local variables to support buffers larger than 2GB.
2326 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2327
2328 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2329 argument, local variables, and return value.
2330
2331 * lisp.h: Update prototypes of emacs_write and emacs_read.
2332
2333 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2334
2335 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2336
2337 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2338
2339 Fix more problems found by GCC 4.6.0's static checks.
2340
2341 * xdisp.c (vmessage): Use a better test for character truncation.
2342
2343 * charset.c (load_charset_map): <, not <=, for optimization,
2344 and to avoid potential problems with integer overflow.
2345 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2346 * casetab.c (set_identity, shuffle): Likewise.
2347 * editfns.c (Fformat): Likewise.
2348 * syntax.c (skip_chars): Likewise.
2349
2350 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2351 This also lets GCC 4.6.0 generate slightly better loop code.
2352
2353 * callint.c (Fcall_interactively): <, not <=, for optimization.
2354 (Fcall_interactively): Count the number of arguments produced,
2355 not the number of arguments given. This is simpler and lets GCC
2356 4.6.0 generate slightly better code.
2357
2358 * ftfont.c: Distingish more carefully between FcChar8 and char.
2359 The previous code passed unsigned char * to a functions like
2360 strlen and xstrcasecmp that expect char *, which does not
2361 conform to the C standard.
2362 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2363 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2364 char * when the C standard requires it.
2365
2366 * keyboard.c (read_char): Remove unused var.
2367
2368 * eval.c: Port to Windows vsnprintf (Bug#8435).
2369 Include <limits.h>.
2370 (SIZE_MAX): Define if the headers do not.
2371 (verror): Do not give up if vsnprintf returns a negative count.
2372 Instead, grow the buffer. This ports to Windows vsnprintf, which
2373 does not conform to C99. Problem reported by Eli Zaretskii.
2374 Also, simplify the allocation scheme, by avoiding the need for
2375 calling realloc, and removing the ALLOCATED variable.
2376
2377 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2378
2379 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2380 But keep the doprint source code for now, as we might revamp it
2381 and use it again (Bug#8435).
2382 * lisp.h (doprnt): Remove.
2383 * Makefile.in (base_obj): Remove doprnt.o.
2384 * deps.mk (doprnt.o): Remove.
2385
2386 error: Print 32- and 64-bit integers portably (Bug#8435).
2387 Without this change, on typical 64-bit hosts error ("...%d...", N)
2388 was used to print both 32- and 64-bit integers N, which relied on
2389 undefined behavior.
2390 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2391 New macro.
2392 * lisp.h (error, verror): Mark as printf-like functions.
2393 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2394 Report overflow in size calculations when allocating printf buffer.
2395 Do not truncate output string at its first null byte.
2396 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2397 Truncate the output at a character boundary, since vsnprintf does not
2398 do that.
2399 * charset.c (check_iso_charset_parameter): Convert internal
2400 character to string before calling 'error', since %c now has the
2401 printf meaning.
2402 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2403 overflow when computing char to be passed to 'error'. Do not
2404 pass Lisp_Object to 'error'; pass the integer instead.
2405 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2406 formatted with plain %d.
2407
2408 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2409
2410 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2411
2412 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2413
2414 * xterm.c (x_catch_errors): Remove duplicate declaration.
2415
2416 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2417
2418 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2419
2420 2011-04-10 Jim Meyering <meyering@redhat.com>
2421
2422 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2423 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2424 return ssize_t not "int", and use size_t as the buffer length.
2425 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2426 * gnutls.h: Update declarations.
2427 * process.c (read_process_output): Use ssize_t, to match.
2428 (send_process): Likewise.
2429
2430 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2431
2432 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2433
2434 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2435
2436 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2437 Use unsigned char, to match FcChar8 type definition.
2438
2439 * xterm.c (handle_one_xevent):
2440 * xmenu.c (create_and_show_popup_menu):
2441 * xselect.c (x_decline_selection_request)
2442 (x_reply_selection_request): Avoid type-punned deref of X events.
2443
2444 2011-04-09 Eli Zaretskii <eliz@gnu.org>
2445
2446 Fix some uses of `int' instead of EMACS_INT.
2447 * search.c (string_match_1, fast_string_match)
2448 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2449 (scan_buffer, find_next_newline_no_quit)
2450 (find_before_next_newline, search_command, Freplace_match)
2451 (Fmatch_data): Make some `int' variables be EMACS_INT.
2452
2453 * xdisp.c (display_count_lines): 3rd argument and return value now
2454 EMACS_INT. All callers changed.
2455 (pint2hrstr): Last argument is now EMACS_INT.
2456
2457 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2458 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2459 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2460 (decode_coding_utf_16, decode_coding_emacs_mule)
2461 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2462 (decode_coding_ccl, decode_coding_charset)
2463 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2464 (decode_coding_iso_2022, decode_coding_emacs_mule)
2465 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2466 <char_offset, last_offset>: Declare EMACS_INT.
2467 (encode_coding_utf_8, encode_coding_utf_16)
2468 (encode_coding_emacs_mule, encode_invocation_designation)
2469 (encode_designation_at_bol, encode_coding_iso_2022)
2470 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2471 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2472 Declare EMACS_INT.
2473 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2474 (encode_invocation_designation): Last argument P_NCHARS is now
2475 EMACS_INT.
2476 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2477 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2478
2479 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2480 All users changed.
2481
2482 * ccl.c (Fccl_execute_on_string): Declare some variables
2483 EMACS_INT.
2484
2485 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
2486
2487 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2488
2489 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2490
2491 * process.c (Fformat_network_address): Doc fix.
2492
2493 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2494
2495 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2496
2497 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
2498
2499 * keyboard.c (read_char): Call Lisp function help-form-show,
2500 instead of using internal_with_output_to_temp_buffer.
2501 (Qhelp_form_show): New var.
2502 (syms_of_keyboard): Use DEFSYM macro.
2503
2504 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2505
2506 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2507
2508 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
2509
2510 * process.c (Flist_processes): Remove to Lisp.
2511 (list_processes_1): Delete.
2512
2513 2011-04-06 Eli Zaretskii <eliz@gnu.org>
2514
2515 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2516
2517 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2518
2519 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
2520
2521 Fix more problems found by GCC 4.6.0's static checks.
2522
2523 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2524
2525 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2526
2527 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
2528
2529 * xdisp.c (vmessage): Mark as a printf-like function.
2530
2531 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2532
2533 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2534
2535 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2536 printf-like functions.
2537 (tiff_load): Add casts to remove these marks before passing them
2538 to system-supplied API.
2539
2540 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2541
2542 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2543 This avoids several warnings with gcc -Wstrict-overflow.
2544 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2545 directly, rather than having caller test rule sign. This avoids
2546 some unnecessary tests.
2547 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2548 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2549 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
2550
2551 * xfont.c (xfont_text_extents): Remove var that was set but not used.
2552 (xfont_open): Avoid unnecessary tests.
2553
2554 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2555
2556 * composite.h, composite.c (composition_gstring_put_cache):
2557 Use EMACS_INT, not int, for length.
2558
2559 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2560 breaking out part of COMPOSITION_DECODE_RULE.
2561 (COMPOSITION_DECODE_RULE): Use it.
2562 * composite.c (get_composition_id): Remove unused local vars,
2563 by using the new macro.
2564
2565 * textprop.c (set_text_properties_1): Change while to do-while,
2566 since the condition is always true at first.
2567
2568 * intervals.c (graft_intervals_into_buffer): Mark var as used.
2569 (interval_deletion_adjustment): Return unsigned value.
2570 All uses changed.
2571
2572 * process.c (list_processes_1, create_pty, read_process_output):
2573 (exec_sentinel): Remove vars that were set but not used.
2574 (create_pty): Remove unnecessary "volatile"s.
2575 (Fnetwork_interface_info): Avoid possibility of int overflow.
2576 (read_process_output): Do adaptive read buffering even if carryover.
2577 (read_process_output): Simplify nbytes computation if buffered.
2578
2579 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2580
2581 * syntax.c (scan_words): Remove var that was set but not used.
2582 (update_syntax_table): Use unsigned instead of int.
2583
2584 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
2585 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
2586 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
2587
2588 * print.c (print_error_message): Avoid int overflow.
2589
2590 * font.c (font_list_entities): Redo for clarity,
2591 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2592
2593 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
2594 (font_score): Avoid potential overflow in diff calculation.
2595
2596 * fns.c (substring_both): Remove var that is set but not used.
2597 (sxhash): Redo loop for clarity and to avoid wraparound warning.
2598
2599 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2600
2601 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2602 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2603 can always succeed if overflow has undefined behavior.
2604
2605 * search.c (boyer_moore, wordify): Remove vars set but not used.
2606 (wordify): Omit three unnecessary tests.
2607
2608 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2609 All callers changed. This avoids the need for an unused var.
2610
2611 * casefiddle.c (casify_region): Remove var that is set but not used.
2612
2613 * dired.c (file_name_completion): Remove var that is set but not used.
2614
2615 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2616
2617 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2618 (Finsert_file_contents): Remove unnecessary code checking fd.
2619
2620 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2621 Check for integer overflow on size calculations.
2622
2623 * buffer.c (Fprevious_overlay_change): Remove var that is set
2624 but not used.
2625
2626 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2627 Remove vars that are set but not used.
2628 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2629 (timer_check_2): Mark vars as initialized.
2630
2631 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2632
2633 * image.c (lookup_image): Remove var that is set but not used.
2634 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2635
2636 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2637 that are set but not used.
2638
2639 * xfns.c (make_invisible_cursor): Don't return garbage
2640 if XCreateBitmapFromData fails (Bug#8410).
2641
2642 * xselect.c (x_get_local_selection, x_handle_property_notify):
2643 Remove vars that are set but not used.
2644
2645 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2646 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2647
2648 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2649 Remove var that is set but not used.
2650 (scroll_bar_windows_size): Now size_t, not int.
2651 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2652 Check for overflow.
2653
2654 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2655 (map_tty_color) [!defined MSDOS]: Likewise.
2656
2657 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2658
2659 * coding.c: Remove vars that are set but not used.
2660 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2661 All callers changed.
2662 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2663 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2664 (decode_coding_charset): Remove vars that are set but not used.
2665
2666 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2667 that is set but not used.
2668
2669 * print.c (print_object): Remove var that is set but not used.
2670
2671 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2672 The gnulib version avoids calling malloc in the usual case,
2673 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2674 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2675 * filelock.c (current_lock_owner): Likewise.
2676 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2677 * sysdep.c: Include allocator.h, careadlinkat.h.
2678 (emacs_no_realloc_allocator): New static constant.
2679 (emacs_readlink): New function.
2680 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2681 ../lib/careadlinkat.h.
2682
2683 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2684
2685 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2686 first non-nil return value).
2687
2688 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2689
2690 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2691 if not defined (Bug#8403).
2692
2693 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2694
2695 * xdisp.c (display_count_lines): Remove parameter `start',
2696 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2697 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2698 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2699 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2700 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2701 and thereabouts. All callers changed.
2702 (get_per_char_metric): Remove parameter `f', unused since
2703 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2704
2705 2011-04-02 Jim Meyering <meyering@redhat.com>
2706
2707 do not dereference NULL upon failed strdup
2708 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2709 (ns_get_family): Likewise.
2710
2711 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2712
2713 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2714
2715 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2716
2717 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2718 later (Bug#8403).
2719
2720 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2721
2722 Add lexical binding.
2723
2724 * window.c (Ftemp_output_buffer_show): New fun.
2725 (Fsave_window_excursion):
2726 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2727
2728 * lread.c (lisp_file_lexically_bound_p): New function.
2729 (Fload): Bind Qlexical_binding.
2730 (readevalloop): Remove `evalfun' arg.
2731 Bind Qinternal_interpreter_environment.
2732 (Feval_buffer): Bind Qlexical_binding.
2733 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2734 Mark as dynamic.
2735 (syms_of_lread): Declare `lexical-binding'.
2736
2737 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2738
2739 * keyboard.c (eval_dyn): New fun.
2740 (menu_item_eval_property): Use it.
2741
2742 * image.c (parse_image_spec): Use Ffunctionp.
2743
2744 * fns.c (concat, mapcar1): Accept byte-code-functions.
2745
2746 * eval.c (Fsetq): Handle lexical vars.
2747 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2748 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2749 (FletX, Flet): Obey lexical binding.
2750 (Fcommandp): Handle closures.
2751 (Feval): New `lexical' arg.
2752 (eval_sub): New function extracted from Feval. Use it almost
2753 everywhere where Feval was used. Look up vars in lexical env.
2754 Handle closures.
2755 (Ffunctionp): Move from subr.el.
2756 (Ffuncall): Handle closures.
2757 (apply_lambda): Remove `eval_flags'.
2758 (funcall_lambda): Handle closures and new byte-code-functions.
2759 (Fspecial_variable_p): New function.
2760 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2761 but without exporting it to Lisp.
2762
2763 * doc.c (Fdocumentation, store_function_docstring):
2764 * data.c (Finteractive_form): Handle closures.
2765
2766 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2767 interactive spec.
2768
2769 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2770 New byte-codes.
2771 (exec_byte_code): New function extracted from Fbyte_code to handle new
2772 calling convention for byte-code-functions. Add new byte-codes.
2773
2774 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2775
2776 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2777
2778 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2779
2780 * xdisp.c (redisplay_internal): Fix prototype.
2781
2782 2011-03-31 Eli Zaretskii <eliz@gnu.org>
2783
2784 * xdisp.c (SCROLL_LIMIT): New macro.
2785 (try_scrolling): Use it when setting scroll_limit.
2786 Limit scrolling to 100 screen lines.
2787 (redisplay_window): Even when falling back on "recentering",
2788 position point in the window according to scroll-conservatively,
2789 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2790
2791 (try_scrolling): When point is above the window, allow searching
2792 as far as scroll_max, or one screenful, to compute vertical
2793 distance from PT to the scroll margin position. This prevents
2794 try_scrolling from unnecessarily failing when
2795 scroll-conservatively is set to a value slightly larger than the
2796 window height. Clean up the case of PT below the margin at bottom
2797 of window: scroll_max can no longer be INT_MAX. When aggressive
2798 scrolling is in use, don't let point enter the opposite scroll
2799 margin as result of the scroll.
2800 (syms_of_xdisp) <scroll-conservatively>: Document the
2801 threshold of 100 lines for never-recentering scrolling.
2802
2803 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2804
2805 * dispextern.h (move_it_by_lines):
2806 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2807 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2808 (message_log_check_duplicate): Remove parameters `prev_bol' and
2809 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2810 (redisplay_internal): Remove parameter `preserve_echo_area',
2811 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2812
2813 * indent.c (Fvertical_motion):
2814 * window.c (window_scroll_pixel_based, Frecenter):
2815 Don't pass `need_y_p' to `move_it_by_lines'.
2816
2817 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2818
2819 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2820 steal a few bits to be more compact.
2821 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2822 Remove unneeded casts.
2823
2824 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2825
2826 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2827
2828 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2829 binding" message (bug#7967).
2830
2831 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2832
2833 Fix more problems found by GCC 4.6.0's static checks.
2834
2835 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2836 Remove unused local var.
2837
2838 * editfns.c (Fmessage_box): Remove unused local var.
2839
2840 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2841 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2842 Omit unused local vars.
2843 * window.c (shrink_windows): Omit unused local var.
2844 * menu.c (digest_single_submenu): Omit unused local var.
2845 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2846 Omit unused local var.
2847
2848 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2849 Don't assume string length fits in int.
2850 (keyremap_step, read_key_sequence): Use size_t for sizes.
2851 (read_key_sequence): Don't check last_real_key_start redundantly.
2852
2853 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2854 instead of alloca (Bug#8344).
2855
2856 * eval.c (Fbacktrace): Don't assume nargs fits in int.
2857 (Fbacktrace_frame): Don't assume nframes fits in int.
2858
2859 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2860
2861 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2862 concerns.
2863
2864 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2865
2866 * cm.c (calccost): Turn while-do into do-while, for clarity.
2867
2868 * keyboard.c (syms_of_keyboard): Use the same style as later
2869 in this function when indexing through an array. This also
2870 works around GCC bug 48267.
2871
2872 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2873
2874 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2875
2876 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2877 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2878
2879 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2880 This avoids undefined behavior on integer overflow, and is a bit
2881 more convenient anyway since it is compared to a size_t variable.
2882
2883 Variadic C functions now count arguments with size_t, not int.
2884 This avoids an unnecessary limitation on 64-bit machines, which
2885 caused (substring ...) to crash on large vectors (Bug#8344).
2886 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2887 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
2888 All variadic functions and their callers changed accordingly.
2889 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2890 * data.c (arith_driver, float_arith_driver): Likewise.
2891 * editfns.c (general_insert_function): Likewise.
2892 * eval.c (struct backtrace.nargs, interactive_p)
2893 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2894 (funcall_lambda, mark_backtrace): Likewise.
2895 * fns.c (concat): Likewise.
2896 * frame.c (x_set_frame_parameters): Likewise.
2897 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2898 0 if not found, not -1. All callers changed.
2899
2900 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2901 (stack_copy_size): Now size_t, not int.
2902 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2903
2904 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2905
2906 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2907 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2908 All callers changed.
2909
2910 * lisp.h (multibyte_char_to_unibyte):
2911 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2912 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2913 * character.h (CHAR_TO_BYTE8):
2914 * cmds.c (internal_self_insert):
2915 * editfns.c (general_insert_function):
2916 * keymap.c (push_key_description):
2917 * search.c (Freplace_match):
2918 * xdisp.c (message_dolog, set_message_1): All callers changed.
2919
2920 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2921
2922 * keyboard.c (safe_run_hook_funcall): New function.
2923 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2924 don't set the hook to nil, but remove the offending function instead.
2925 (Qcommand_hook_internal): Remove, unused.
2926 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2927 Vcommand_hook_internal.
2928
2929 * eval.c (enum run_hooks_condition): Remove.
2930 (funcall_nil, funcall_not): New functions.
2931 (run_hook_with_args): Call each function through a `funcall' argument.
2932 Remove `cond' argument, now redundant.
2933 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2934 (Frun_hook_with_args_until_failure): Adjust accordingly.
2935 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2936
2937 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2938
2939 * dispextern.h (string_buffer_position): Remove declaration.
2940
2941 * print.c (strout): Remove parameter `multibyte', unused since
2942 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2943
2944 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2945 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2946 All callers changed.
2947
2948 * w32.c (_wsa_errlist): Use braces for struct initializers.
2949
2950 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2951 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2952 All callers changed.
2953 (string_buffer_position): Likewise. Also, make static (it's never
2954 used outside xdisp.c).
2955 (cursor_row_p): Remove parameter `w', unused since
2956 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2957 (decode_mode_spec): Remove parameter `precision', introduced during
2958 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2959 All callers changed.
2960
2961 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2962
2963 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2964
2965 2011-03-27 Anders Lindgren <andlind@gmail.com>
2966
2967 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2968 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2969 (ns_update_auto_hide_menu_bar): New functions.
2970 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2971 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2972 ns_constrain_all_frames.
2973 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2974 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2975
2976 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2977
2978 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2979
2980 2011-03-27 Glenn Morris <rgm@gnu.org>
2981
2982 * syssignal.h: Replace RETSIGTYPE with void.
2983 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2984 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2985 Replace SIGTYPE with void everywhere.
2986 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2987 * s/template.h (SIGTYPE): Remove commented out definition.
2988
2989 2011-03-26 Eli Zaretskii <eliz@gnu.org>
2990
2991 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2992 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2993
2994 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
2995
2996 * w32.c (read_unc_volume): Use parameter `henum', instead of
2997 global variable `wget_enum_handle'.
2998
2999 * keymap.c (describe_vector): Remove parameters `indices' and
3000 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3001 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3002
3003 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3004
3005 * keyboard.c (timer_check): Remove parameter `do_it_now',
3006 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3007 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3008 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3009
3010 * keyboard.c (read_char):
3011 * w32menu.c (w32_menu_display_help):
3012 * xmenu.c (show_help_event, menu_help_callback):
3013 Adjust calls to `show_help_echo'.
3014
3015 * gtkutil.c (xg_maybe_add_timer):
3016 * keyboard.c (readable_events):
3017 * process.c (wait_reading_process_output):
3018 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3019
3020 * insdel.c (adjust_markers_gap_motion):
3021 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3022 (gap_left, gap_right): Don't call it.
3023
3024 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3025
3026 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3027 incurred during fontification.
3028
3029 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3030
3031 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3032 (DEFVAR_PER_BUFFER): Don't pass it.
3033
3034 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3035 (scrolling_window): Don't pass it.
3036
3037 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3038
3039 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3040
3041 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3042 and `suffix'.
3043 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3044 of variables specific to SELinux and computation of `encoded_absname'.
3045
3046 * image.c (XPutPixel): Remove unused variable `height'.
3047
3048 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3049
3050 * unexw32.c (get_section_info): Remove unused variable `section'.
3051
3052 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3053 (system_process_attributes): Remove unused variable `sess'.
3054 (sys_read): Remove unused variable `err'.
3055
3056 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3057 (w32_wnd_proc): Remove unused variable `isdead'.
3058 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3059 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3060 (x_create_tip_frame): Remove unused variable `tem'.
3061
3062 * w32inevt.c (w32_console_read_socket):
3063 Remove unused variable `no_events'.
3064
3065 * w32term.c (x_draw_composite_glyph_string_foreground):
3066 Remove unused variable `width'.
3067
3068 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3069
3070 * w32term.c (x_set_glyph_string_clipping):
3071 Don't pass uninitialized region to CombineRgn.
3072
3073 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3074
3075 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3076 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3077 (Fx_close_connection): Remove unused variable `i'.
3078
3079 * w32font.c (w32font_draw): Return number of glyphs.
3080 (w32font_open_internal): Remove unused variable `i'.
3081 (w32font_driver): Add missing initializer.
3082
3083 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3084 (fill_in_menu): Remove unused variable `items_added'.
3085
3086 * w32term.c (last_mouse_press_frame): Remove static global variable.
3087 (w32_clip_to_row): Remove unused variable `f'.
3088 (x_delete_terminal): Remove unused variable `i'.
3089
3090 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3091 (NOTHING): Remove unused static global variable.
3092 (uniscribe_check_otf): Remove unused variable `table'.
3093 (uniscribe_font_driver): Add missing initializers.
3094
3095 2011-03-23 Julien Danjou <julien@danjou.info>
3096
3097 * term.c (Fsuspend_tty, Fresume_tty):
3098 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3099 * window.c (temp_output_buffer_show):
3100 * insdel.c (signal_before_change):
3101 * frame.c (Fhandle_switch_frame):
3102 * fileio.c (Fdo_auto_save):
3103 * emacs.c (Fkill_emacs):
3104 * editfns.c (save_excursion_restore):
3105 * cmds.c (internal_self_insert):
3106 * callint.c (Fcall_interactively):
3107 * buffer.c (Fkill_all_local_variables):
3108 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3109 Use Frun_hooks.
3110 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3111 unconditionnaly since it does the check itself.
3112
3113 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3114
3115 Fix more problems found by GCC 4.5.2's static checks.
3116
3117 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3118 the first time through the loop, since we know p0 < p1 then.
3119 This also avoids a gcc -Wstrict-overflow warning.
3120
3121 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3122 leading to a memory leak, possible in functions like
3123 load_charset_map_from_file that can allocate an unbounded number
3124 of objects (Bug#8318).
3125
3126 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3127 that could (at least in theory) be that large.
3128
3129 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3130 This is less likely to overflow, and avoids undefined behavior if
3131 overflow does occur. All callers changed. Use strtoul to scan
3132 for the unsigned long integer.
3133 (pint2hrstr): Simplify and tune code slightly.
3134 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3135
3136 * scroll.c (do_scrolling): Work around GCC bug 48228.
3137 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3138
3139 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3140 This also avoids a warning with gcc -Wstrict-overflow.
3141 (validate_x_resource_name): Simplify count usage.
3142 This also avoids a warning with gcc -Wstrict-overflow.
3143
3144 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3145 fail (Bug#8306).
3146
3147 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3148
3149 * process.c (Fmake_network_process): Use socklen_t, not int,
3150 where POSIX says socklen_t is required in portable programs.
3151 This fixes a porting bug on hosts like 64-bit HP-UX, where
3152 socklen_t is wider than int (Bug#8277).
3153 (Fmake_network_process, server_accept_connection):
3154 (wait_reading_process_output, read_process_output):
3155 Likewise.
3156
3157 * process.c: Rename or move locals to avoid shadowing.
3158 (list_processes_1, Fmake_network_process):
3159 (read_process_output_error_handler, exec_sentinel_error_handler):
3160 Rename or move locals.
3161 (Fmake_network_process): Define label "retry_connect" only if needed.
3162 (Fnetwork_interface_info): Fix pointer signedness.
3163 (process_send_signal): Add cast to avoid pointer signedness problem.
3164 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3165 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3166
3167 Make tparam.h and terminfo.c consistent.
3168 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3169 Include tparam.h instead, since it declares them.
3170 * cm.h (PC): Remove extern decl; tparam.h now does this.
3171 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3172 * terminfo.c: Include tparam.h, to check interfaces.
3173 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3174 (tparam): Adjust signature to match interface in tparam.h;
3175 this removes some undefined behavior. Check that outstring and len
3176 are zero, which they always are with Emacs.
3177 * tparam.h (PC, BC, UP): New extern decls.
3178
3179 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3180 (xftfont_open): Rename locals to avoid shadowing.
3181
3182 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3183 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3184 (OTF_TAG_SYM): Omit macro if not needed.
3185 (ftfont_list): Remove unused local.
3186 (get_adstyle_property, ftfont_pattern_entity):
3187 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3188 Rename locals to avoid shadowing.
3189
3190 * xfont.c (xfont_list_family): Mark var as initialized.
3191
3192 * xml.c (make_dom): Now static.
3193
3194 * composite.c (composition_compute_stop_pos): Rename local to
3195 avoid shadowing.
3196 (composition_reseat_it): Remove unused locals.
3197 (find_automatic_composition, composition_adjust_point): Likewise.
3198 (composition_update_it): Mark var as initialized.
3199 (find_automatic_composition): Mark vars as initialized,
3200 with a FIXME (Bug#8290).
3201
3202 character.h: Rename locals to avoid shadowing.
3203 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3204 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3205 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3206 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3207 to avoid shadowing.
3208
3209 * textprop.c (property_change_between_p): Remove; unused.
3210
3211 * intervals.c (interval_start_pos): Now static.
3212
3213 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3214
3215 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3216 Rename locals to avoid shadowing.
3217
3218 * sound.c (wav_play, au_play, Fplay_sound_internal):
3219 Fix pointer signedness.
3220 (alsa_choose_format): Remove unused local var.
3221 (wav_play): Initialize a variable to 0, to prevent undefined
3222 behavior (Bug#8278).
3223
3224 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3225
3226 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3227
3228 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3229 clobbering (Bug#8298).
3230 * sysdep.c (sys_subshell): Likewise.
3231 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3232
3233 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3234 This should get cleaned up, so that child_setup has the
3235 same signature on all platforms.
3236
3237 * callproc.c (call_process_cleanup): Now static.
3238 (relocate_fd): Rename locals to avoid shadowing.
3239
3240 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3241
3242 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3243 not to be necessary, and produces flickering.
3244
3245 2011-03-20 Glenn Morris <rgm@gnu.org>
3246
3247 * config.in: Remove file.
3248
3249 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3250
3251 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3252 are now in src/globals.h.
3253 (syms_of_minibuf): Remove spurious & from previous change.
3254
3255 2011-03-20 Leo <sdl.web@gmail.com>
3256
3257 * minibuf.c (completing-read-function): New variable.
3258 (completing-read-default): Rename from completing-read.
3259 (completing-read): Call completing-read-function.
3260
3261 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3262
3263 * xfaces.c (Fx_load_color_file):
3264 Read color file from absolute filename (bug#8250).
3265
3266 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3267
3268 * makefile.w32-in: Update dependencies.
3269
3270 2011-03-17 Eli Zaretskii <eliz@gnu.org>
3271
3272 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3273
3274 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3275
3276 Fix more problems found by GCC 4.5.2's static checks.
3277
3278 * process.c (make_serial_process_unwind, send_process_trap):
3279 (sigchld_handler): Now static.
3280
3281 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3282 That way, the code declares only the vars that it needs.
3283 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3284 * s/cygwin.h (PTY_ITERATION): Likewise.
3285 * s/darwin.h (PTY_ITERATION): Likewise.
3286 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3287
3288 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3289 * process.c (allocate_pty): Don't declare stb unless it's needed.
3290
3291 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3292 (CONSTANTLIM): Remove; unused.
3293 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3294 Define only if needed.
3295
3296 * unexelf.c (unexec): Name an expression,
3297 to avoid gcc -Wbad-function-cast warning.
3298 Use a different way to cause a compilation error if anyone uses
3299 n rather than nn, a way that does not involve shadowing.
3300 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3301
3302 * deps.mk (unexalpha.o): Remove; unused.
3303
3304 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3305 * unexec.h: New file.
3306 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3307 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3308 Depend on unexec.h.
3309 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3310 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3311 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3312 Change as necessary to match prototype in unexec.h.
3313
3314 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3315 shadowing.
3316 (back_comment, skip_chars): Mark vars as initialized.
3317
3318 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3319 Rename locals to avoid shadowing.
3320
3321 * lread.c (read1): Rewrite so as not to use empty "else".
3322 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3323
3324 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3325
3326 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3327 warning when compiling print.c.
3328
3329 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3330 instead of using an uninitialized var.
3331 (font_sort_entities): Mark var as initialized.
3332
3333 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3334
3335 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3336 pointers to constants.
3337 (font_parse_fcname): Remove unused vars.
3338 (font_delete_unmatched): Now static.
3339 (font_get_spec): Remove; unused.
3340 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3341 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3342 Rename or move locals to avoid shadowing.
3343
3344 * fns.c (require_nesting_list, require_unwind): Now static.
3345 (Ffillarray): Rename locals to avoid shadowing.
3346
3347 * floatfns.c (domain_error2): Define only if needed.
3348 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3349
3350 * alloc.c (mark_backtrace): Move decl from here ...
3351 * lisp.h: ... to here, so that it can be checked.
3352
3353 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3354 (Fdefvar): Rewrite so as not to use empty "else".
3355 (lisp_indirect_variable): Name an expression,
3356 to avoid gcc -Wbad-function-cast warning.
3357 (Fdefvar): Rename locals to avoid shadowing.
3358
3359 * callint.c (quotify_arg, quotify_args): Now static.
3360 (Fcall_interactively): Rename locals to avoid shadowing.
3361 Use const pointer when appropriate.
3362
3363 * lisp.h (get_system_name, get_operating_system_release):
3364 Move decls here, to check interfaces.
3365 * process.c (get_operating_system_release): Move decl to lisp.h.
3366 * xrdb.c (get_system_name): Likewise.
3367 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3368 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3369 some of which prompt warnings from gcc -Wbad-function-cast.
3370 (Fformat_time_string, Fencode_time, Finsert_char):
3371 (Ftranslate_region_internal, Fformat):
3372 Rename or remove local vars to avoid shadowing.
3373 (Ftranslate_region_internal): Mark var as initialized.
3374
3375 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3376 avoid shadowing.
3377
3378 * lisp.h (eassert): Check that the argument compiles, even if
3379 ENABLE_CHECKING is not defined.
3380
3381 * data.c (Findirect_variable): Name an expression, to avoid
3382 gcc -Wbad-function-cast warning.
3383 (default_value, arithcompare, arith_driver, arith_error): Now static.
3384 (store_symval_forwarding): Rename local to avoid shadowing.
3385 (Fmake_variable_buffer_local, Fmake_local_variable):
3386 Mark variables as initialized.
3387 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
3388
3389 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
3390 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3391 Rename locals to avoid shadowing.
3392 (mark_stack): Move local variables into the #ifdef region where
3393 they're used.
3394 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3395 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3396 needed otherwise.
3397 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3398 (GC_STRING_CHARS): Remove; not used.
3399 (Fmemory_limit): Cast sbrk's returned value to char *.
3400
3401 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3402 avoids undefined behavior in theory.
3403
3404 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3405
3406 Use functions, not macros, for up- and down-casing (Bug#8254).
3407 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3408 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3409 to use the following functions instead of these macros.
3410 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3411 EMACS_INT, since callers assume the returned value fits in int.
3412 (upcase1): Likewise, for UPCASE_TABLE.
3413 (uppercasep, lowercasep, upcase): New static inline functions.
3414 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
3415 the race-condition problem in the old DOWNCASE.
3416
3417 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3418 Rename locals to avoid shadowing.
3419 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
3420 (regex_compile, re_search_2, re_match_2_internal):
3421 Remove unused local vars.
3422 (FREE_VAR): Rewrite so as not to use empty "else",
3423 which gcc can warn about.
3424 (regex_compile, re_match_2_internal): Mark locals as initialized.
3425 (RETALLOC_IF): Define only if needed.
3426 (WORDCHAR_P): Likewise. This one is never needed, but is used
3427 only in a comment talking about a compiler bug, so put inside
3428 the #if 0 of that comment.
3429 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3430 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3431 Remove; unused.
3432
3433 * search.c (boyer_moore): Rename locals to avoid shadowing.
3434 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3435 (PREV_CHAR_BOUNDARY): Likewise.
3436
3437 * search.c (simple_search): Remove unused var.
3438
3439 * dired.c (compile_pattern): Move decl from here ...
3440 * lisp.h: ... to here, so that it can be checked.
3441 (struct re_registers): New forward decl.
3442
3443 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3444
3445 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3446 All uses changed.
3447 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3448 Rename locals to avoid shadowing.
3449 (Fvertical_motion): Mark locals as initialized.
3450
3451 * casefiddle.c (casify_object, casify_region): Now static.
3452 (casify_region): Mark local as initialized.
3453
3454 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3455
3456 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3457 New macros, so that the caller can use some names other than
3458 gcpro1, gcpro2, etc.
3459 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3460 of the new macros.
3461 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3462 argument, for consistency with GCPRO2_VAR, etc: it is now the
3463 prefix of the variable, not the variable itself. All uses
3464 changed.
3465 * dired.c (directory_files_internal, file_name_completion):
3466 Rename locals to avoid shadowing.
3467
3468 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3469 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3470 dired.c's scmp function, had undefined behavior.
3471 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3472 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3473 * buffer.h: ... to here, because these macros use current_buffer,
3474 and the new implementation with inline functions needs to have
3475 current_buffer in scope now, rather than later when the macros
3476 are used.
3477 (downcase, upcase1): New static inline functions.
3478 (DOWNCASE, UPCASE1): Reimplement using these functions.
3479 This avoids undefined behavior in expressions like
3480 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3481 from race conditions in accessing the global variables
3482 case_temp1 and case_temp2.
3483 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3484 * lisp.h (case_temp1, case_temp2): Remove their decls.
3485 * character.h (ASCII_CHAR_P): Move from here ...
3486 * lisp.h: ... to here, so that the inline functions mentioned
3487 above can use them.
3488
3489 * dired.c (directory_files_internal_unwind): Now static.
3490
3491 * fileio.c (file_name_as_directory, directory_file_name):
3492 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3493 Now static.
3494 (file_name_as_directory): Use const pointers when appropriate.
3495 (Fexpand_file_name): Likewise. In particular, newdir might
3496 point at constant storage, so make it a const pointer.
3497 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
3498 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3499 signedness issues.
3500 (Fset_file_times, Finsert_file_contents, auto_save_error):
3501 Rename locals to avoid shadowing.
3502
3503 * minibuf.c (choose_minibuf_frame_1): Now static.
3504 (Ftry_completion, Fall_completions): Rename or remove locals
3505 to avoid shadowing.
3506
3507 * marker.c (bytepos_to_charpos): Remove; unused.
3508
3509 * lisp.h (verify_bytepos, count_markers): New decls,
3510 so that gcc does not warn that these functions aren't declared.
3511
3512 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3513 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
3514 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
3515 (copy_text): Remove unused local var.
3516
3517 * filelock.c (within_one_second): Now static.
3518 (lock_file_1): Rename local to avoid shadowing.
3519
3520 * buffer.c (fix_overlays_before): Mark locals as initialized.
3521 (fix_start_end_in_overlays): Likewise. This function should be
3522 simplified by using pointers-to-pointers, but that's a different
3523 matter.
3524 (switch_to_buffer_1): Now static.
3525 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3526 (report_overlay_modification): Rename locals to avoid shadowing.
3527
3528 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
3529 Fix pointer signedness issue.
3530 (sys_subshell): Mark local as volatile if checking for lint,
3531 to suppress a gcc -Wclobbered warning that does not seem to be right.
3532 (MAXPATHLEN): Define only if needed.
3533
3534 * process.c (serial_open, serial_configure): Move decls from here ...
3535 * systty.h: ... to here, so that they can be checked.
3536
3537 * fns.c (get_random, seed_random): Move extern decls from here ...
3538 * lisp.h: ... to here, so that they can be checked.
3539
3540 * sysdep.c (reset_io): Now static.
3541 (wait_for_termination_signal): Remove; unused.
3542
3543 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3544 (copy_keymap_item, append_key, push_text_char_description):
3545 Now static.
3546 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
3547 (DENSE_TABLE_SIZE): Remove; unused.
3548 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3549 (describe_map_tree):
3550 Rename locals to avoid shadowing.
3551
3552 * keyboard.c: Declare functions static if they are not used elsewhere.
3553 (echo_char, echo_dash, cmd_error, top_level_2):
3554 (poll_for_input, handle_async_input): Now static.
3555 (read_char, kbd_buffer_get_event, make_lispy_position):
3556 (make_lispy_event, make_lispy_movement, apply_modifiers):
3557 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3558 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3559 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
3560 (read_key_sequence, read_char): Mark locals as initialized.
3561 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
3562
3563 * keyboard.h (make_ctrl_char): New decl.
3564 (mark_kboards): Move decl here ...
3565 * alloc.c (mark_kboards): ... from here.
3566
3567 * lisp.h (force_auto_save_soon): New decl.
3568
3569 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
3570 (DEFINE_DUMMY_FUNCTION): New macro.
3571 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3572 Use it.
3573 (main): Add casts to avoid warnings
3574 if GCC considers string literals to be constants.
3575
3576 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3577
3578 * dbusbind.c: Pointer signedness fixes.
3579 (xd_signature, xd_append_arg, xd_initialize):
3580 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3581 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3582 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3583 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3584
3585 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3586 if GCC considers string literals to be constants.
3587 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
3588
3589 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3590
3591 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3592 (print_preprocess, print_object): New macro to fix last change.
3593
3594 * print.c (print_preprocess): Don't forget font objects.
3595
3596 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
3597
3598 * emacs.c (USAGE3): Doc fixes.
3599
3600 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3601
3602 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3603 structure.
3604
3605 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
3606
3607 * lisp.h (VWindow_system, Qfile_name_history):
3608 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3609 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3610 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3611
3612 * w32select.c: Don't #include "keyboard.h".
3613 (run_protected): Add extern declaration for waiting_for_input.
3614
3615 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3616 * w32console.c (detect_input_pending, read_input_pending)
3617 (encode_terminal_code):
3618 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3619 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3620 (w32_system_caret_y, Qfile_name_history):
3621 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3622 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3623 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3624 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3625 * w32proc.c (Qlocal, report_file_error):
3626 * w32term.c (Vwindow_system, updating_frame):
3627 * w32uniscribe.c (initialized, uniscribe_font_driver):
3628 Remove unneeded extern declarations.
3629
3630 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
3631
3632 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3633
3634 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
3635
3636 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3637 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3638 These macros can no longer be used for assignment.
3639
3640 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3641 Assign struct members directly, instead of using BUF_BEGV etc.
3642 (record_buffer_markers, fetch_buffer_markers): New functions for
3643 recording and fetching special buffer markers.
3644 (set_buffer_internal_1, set_buffer_temp): Use them.
3645
3646 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3647
3648 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3649
3650 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3651 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3652
3653 * xdisp.c (hscroll_window_tree):
3654 (reconsider_clip_changes): Use PT instead of BUF_PT.
3655
3656 2011-03-13 Eli Zaretskii <eliz@gnu.org>
3657
3658 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3659 $(EMACS_ROOT)/lib/intprops.h.
3660
3661 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3662
3663 Fix more problems found by GCC 4.5.2's static checks.
3664
3665 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3666 to unsigned char * to avoid compiler diagnostic.
3667 (xg_free_frame_widgets): Make it clear that a local variable is
3668 needed only if USE_GTK_TOOLTIP.
3669 (gdk_window_get_screen): Make it clear that this macro is needed
3670 only if USE_GTK_TOOLTIP.
3671 (int_gtk_range_get_value): New function, which avoids a diagnostic
3672 from gcc -Wbad-function-cast.
3673 (xg_set_toolkit_scroll_bar_thumb): Use it.
3674 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3675 diagnostic from gcc -Wbad-function-cast.
3676 (get_utf8_string, xg_get_file_with_chooser):
3677 Rename locals to avoid shadowing.
3678 (create_dialog): Move locals to avoid shadowing.
3679
3680 * xgselect.c (xg_select): Remove unused var.
3681
3682 * image.c (four_corners_best): Mark locals as initialized.
3683 (gif_load): Initialize transparent_p to zero (Bug#8238).
3684 Mark another local as initialized.
3685 (my_png_error, my_error_exit): Mark with NO_RETURN.
3686
3687 * image.c (clear_image_cache): Now static.
3688 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
3689 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
3690 (x_edge_detection): Remove unnecessary cast that
3691 gcc -Wbad-function-cast diagnoses.
3692 (gif_load): Fix pointer signedness.
3693 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3694 (jpeg_load, gif_load): Rename locals to avoid shadowing.
3695
3696 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3697
3698 Improve quality of tests for time stamp overflow.
3699 For example, without this patch (encode-time 0 0 0 1 1
3700 1152921504606846976) returns the obviously-bogus value (-948597
3701 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3702 reports time overflow. See
3703 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
3704 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3705 * editfns.c: Include limits.h and intprops.h.
3706 (TIME_T_MIN, TIME_T_MAX): New macros.
3707 (time_overflow): Move earlier, to before first use.
3708 (hi_time, lo_time): New functions, for an accurate test for
3709 out-of-range times.
3710 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3711 (Fget_internal_run_time): Don't assume time_t fits in int.
3712 (make_time): Use list2 instead of Fcons twice.
3713 (Fdecode_time): More accurate test for out-of-range times.
3714 (check_tm_member): New function.
3715 (Fencode_time): Use it, to test for out-of-range times.
3716 (lisp_time_argument): Don't rely on undefined left-shift and
3717 right-shift behavior when checking for time stamp overflow.
3718
3719 * editfns.c (time_overflow): New function, refactoring common code.
3720 (Fformat_time_string, Fdecode_time, Fencode_time):
3721 (Fcurrent_time_string): Use it.
3722
3723 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3724 * dired.c (make_time): Move to ...
3725 * editfns.c (make_time): ... here.
3726 * systime.h: Note the move.
3727
3728 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3729
3730 * fringe.c (update_window_fringes): Remove unused variables.
3731
3732 * unexmacosx.c (copy_data_segment): Also copy __got section.
3733 (Bug#8223)
3734
3735 2011-03-12 Eli Zaretskii <eliz@gnu.org>
3736
3737 * termcap.c [MSDOS]: Include "msdos.h".
3738 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3739 Constify `char *' arguments and their references according to
3740 prototypes in tparam.h.
3741
3742 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3743
3744 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3745 Adapt all references accordingly.
3746
3747 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3748
3749 2011-03-11 Tom Tromey <tromey@redhat.com>
3750
3751 * buffer.c (syms_of_buffer): Remove obsolete comment.
3752
3753 2011-03-11 Eli Zaretskii <eliz@gnu.org>
3754
3755 * termhooks.h (encode_terminal_code): Declare prototype.
3756
3757 * msdos.c (encode_terminal_code): Don't declare prototype.
3758
3759 * term.c (encode_terminal_code): Now external again, used by
3760 w32console.c and msdos.c.
3761
3762 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3763 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3764
3765 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3766
3767 Fix some minor problems found by GCC 4.5.2's static checks.
3768
3769 * fringe.c (update_window_fringes): Mark locals as initialized
3770 (Bug#8227).
3771 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3772
3773 * alloc.c (mark_fringe_data): Move decl from here ...
3774 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3775 to check its interface.
3776 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3777
3778 * fontset.c (free_realized_fontset): Now static.
3779 (Fset_fontset_font): Rename local to avoid shadowing.
3780 (fontset_font): Mark local as initialized.
3781 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3782
3783 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3784
3785 * xselect.c (x_disown_buffer_selections): Remove; not used.
3786 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3787 (x_own_selection, Fx_disown_selection_internal): Rename locals
3788 to avoid shadowing.
3789 (x_handle_dnd_message): Remove local to avoid shadowing.
3790
3791 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3792 so that the caller can use some name other than gcpro1.
3793 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3794 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3795 (Fx_backspace_delete_keys_p):
3796 Use them to avoid shadowing, and rename vars to avoid shadowing.
3797 (x_decode_color, x_set_name, x_window): Now static.
3798 (Fx_create_frame): Add braces to silence GCC warning.
3799 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3800 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3801 Remove unused locals.
3802 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3803 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3804 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3805 macros.
3806
3807 * xterm.h (x_mouse_leave): New decl.
3808
3809 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3810 Remove unused functions.
3811 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3812 (x_calc_absolute_position): Now static.
3813 (XTread_socket): Don't define label "out" unless it's used.
3814 Don't declare local "event" unless it's used.
3815 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3816 unless they are used.
3817 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3818 (x_fatal_error_signal): Remove; not used.
3819 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3820 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3821 (x_error_catcher, x_connection_closed, x_error_handler):
3822 (x_error_quitter, xembed_send_message, x_iconify_frame):
3823 (my_log_handler): Rename locals to avoid shadowing.
3824 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3825 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3826
3827 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3828 Rename or move locals to avoid shadowing.
3829 (tty_defined_color, merge_face_heights): Now static.
3830 (free_realized_faces_for_fontset): Remove; not used.
3831 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3832 does not deduce is never used uninitialized.
3833 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3834 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3835
3836 * terminal.c (store_terminal_param): Now static.
3837
3838 * xmenu.c (menu_highlight_callback): Now static.
3839 (set_frame_menubar): Remove unused local.
3840 (xmenu_show): Rename parameter to avoid shadowing.
3841 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3842 since they might point to immutable storage.
3843 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3844 since it's unused otherwise.
3845
3846 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
3847 Add a FIXME, since the code still doesn't look right. (Bug#8215)
3848 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3849 avoids a gcc -Wuninitialized diagnostic.
3850 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
3851 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3852 does not deduce are never used uninitialized.
3853
3854 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3855
3856 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
3857 * window.c (window_loop, size_window):
3858 (run_window_configuration_change_hook, enlarge_window): Likewise.
3859
3860 * window.c (display_buffer): Now static.
3861 (size_window): Mark variables that gcc -Wuninitialized
3862 does not deduce are never used uninitialized.
3863 * window.h (check_all_windows): New decl, to forestall
3864 gcc -Wmissing-prototypes diagnostic.
3865 * dispextern.h (bidi_dump_cached_states): Likewise.
3866
3867 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3868 shadowing.
3869 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
3870 Include <limits.h>.
3871 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3872 and to avoid gcc -Wuninitialized warning.
3873 (load_charset_map): Mark variables that gcc -Wuninitialized
3874 does not deduce are never used uninitialized.
3875 (load_charset): Abort instead of using uninitialized var (Bug#8229).
3876
3877 * coding.c (coding_set_source, coding_set_destination):
3878 Use "else { /* comment */ }" rather than "else /* comment */;"
3879 for clarity, and to avoid gcc -Wempty-body warning.
3880 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3881 a block, when the outer 'i' will do.
3882 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3883 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3884 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3885 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3886 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3887 Rename locals to avoid shadowing.
3888 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
3889 * coding.c (emacs_mule_char, encode_invocation_designation):
3890 Now static, since they're not used elsewhere.
3891 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
3892 (decode_coding_object, encode_coding_object, detect_coding_system):
3893 (decode_coding_emacs_mule): Mark variables that gcc
3894 -Wuninitialized does not deduce are never used uninitialized.
3895 (detect_coding_iso_2022): Initialize a local variable that might
3896 be used uninitialized. Leave a FIXME because it's not clear that
3897 this initialization is needed. (Bug#8211)
3898 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3899 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3900 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3901 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3902 Remove unused macros.
3903
3904 * category.c (hash_get_category_set): Remove unused local var.
3905 (copy_category_table): Now static, since it's not used elsewhere.
3906 * character.c (string_count_byte8): Likewise.
3907
3908 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3909 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3910
3911 * chartab.c (copy_sub_char_table): Now static, since it's not used
3912 elsewhere.
3913 (sub_char_table_ref_and_range, char_table_ref_and_range):
3914 Rename locals to avoid shadowing.
3915 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
3916
3917 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
3918 (BIDI_BOB): Remove unused macro.
3919
3920 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3921 deduce are never used uninitialized.
3922 * term.c (encode_terminal_code): Likewise.
3923
3924 * term.c (encode_terminal_code): Now static. Remove unused local.
3925
3926 * tparam.h: New file.
3927 * term.c, tparam.h: Include it.
3928 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3929 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3930 Move these decls to tparam.h, and make them agree with what
3931 is actually in tparam.c. The previous trick of using incompatible
3932 decls in different modules does not conform to the C standard.
3933 All callers of tparam changed to use tparam's actual API.
3934 * tparam.c (tparam1, tparam, tgoto):
3935 Use const pointers where appropriate.
3936
3937 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3938 * cm.h (struct cm): Likewise.
3939 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3940 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3941 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3942 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3943 (turn_on_face, init_tty): Likewise.
3944 * termchar.h (struct tty_display_info): Likewise.
3945
3946 * term.c (term_mouse_position): Rename local to avoid shadowing.
3947
3948 * alloc.c (mark_ttys): Move decl from here ...
3949 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3950
3951 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3952
3953 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3954
3955 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
3956
3957 * search.c (compile_pattern_1): Remove argument regp, unused since
3958 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3959 (compile_pattern): Don't pass it.
3960
3961 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3962
3963 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3964 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3965 for ! HAVE_GTK3.
3966 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3967
3968 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3969
3970 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3971 gdk_window_get_screen, gdk_window_get_geometry,
3972 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3973 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3974 (xg_get_pixbuf_from_pixmap): New function.
3975 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3976 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3977 Call xg_get_pixbuf_from_pixmap instead of
3978 gdk_pixbuf_get_from_drawable.
3979 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3980 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3981 (xg_check_special_colors): Use GtkStyleContext and its functions
3982 for HAVE_GTK3.
3983 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3984 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3985 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
3986 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3987 Call gtk_widget_get_preferred_size.
3988 (xg_frame_resized): gdk_window_get_geometry only takes 5
3989 parameters.
3990 (xg_win_to_widget, xg_event_is_for_menubar):
3991 Call gdk_x11_window_lookup_for_display.
3992 (xg_set_widget_bg): New function.
3993 (delete_cb): New function.
3994 (xg_create_frame_widgets): Connect delete-event to delete_cb.
3995 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3996 (xg_set_background_color): Call xg_set_widget_bg.
3997 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3998 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3999 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4000 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4001 if ! HAVE_GTK3.
4002 (update_frame_tool_bar): Call gtk_widget_hide.
4003 (xg_initialize): Use GDK_KEY_g.
4004
4005 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4006 if ! HAVE_GTK3
4007 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4008
4009 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4010 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4011 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4012
4013 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4014
4015 * w32xfns.c (select_palette): Check success of RealizePalette against
4016 GDI_ERROR, not zero.
4017
4018 See ChangeLog.11 for earlier changes.
4019
4020 ;; Local Variables:
4021 ;; coding: utf-8
4022 ;; End:
4023
4024 Copyright (C) 2011 Free Software Foundation, Inc.
4025
4026 This file is part of GNU Emacs.
4027
4028 GNU Emacs is free software: you can redistribute it and/or modify
4029 it under the terms of the GNU General Public License as published by
4030 the Free Software Foundation, either version 3 of the License, or
4031 (at your option) any later version.
4032
4033 GNU Emacs is distributed in the hope that it will be useful,
4034 but WITHOUT ANY WARRANTY; without even the implied warranty of
4035 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4036 GNU General Public License for more details.
4037
4038 You should have received a copy of the GNU General Public License
4039 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.