* alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
[bpt/emacs.git] / src / ChangeLog
1 2011-06-18 Paul Eggert <eggert@cs.ucla.edu>
2
3 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4
5 * fns.c (concat): Catch string overflow earlier.
6 Do not rely on integer wraparound.
7
8 * dispextern.h (struct it.overlay_strings_charpos): EMACS_INT, not int.
9
10 2011-06-17 Paul Eggert <eggert@cs.ucla.edu>
11
12 * dispextern.h (struct it.selective): Now EMACS_INT, not int.
13 * xdisp.c (forward_to_next_line_start)
14 (back_to_previous_visible_line_start)
15 (reseat_at_next_visible_line_start, next_element_from_buffer):
16 Don't arbitrarily truncate the value of 'selective' to int.
17
18 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
19
20 * composite.c: Don't truncate sizes to 'int'.
21 (composition_gstring_p, composition_reseat_it)
22 (composition_adjust_point): Use EMACS_INT, not int.
23 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
24 not EMACS_UINT, for indexes.
25
26 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
27
28 * buffer.c: Include <verify.h>.
29 (struct sortvec.priority, struct sortstr.priority):
30 Now EMACS_INT, not int.
31 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
32 (struct sortstr.size, record_overlay_string)
33 (struct sortstrlist.size, struct sortlist.used):
34 Don't truncate size to int.
35 (record_overlay_string): Check for size-calculation overflow.
36 (init_buffer_once): Check at compile-time, not run-time.
37
38 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
39
40 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
41 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
42 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
43
44 Improve buffer-overflow checking (Bug#8873).
45 * fileio.c (Finsert_file_contents):
46 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
47 Remove the old (too-loose) buffer overflow checks.
48 They weren't needed, since make_gap checks for buffer overflow.
49 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
50 The old code merely checked for Emacs fixnum overflow, and relied
51 on undefined (wraparound) behavior. The new code avoids undefined
52 behavior, and also checks for ptrdiff_t and/or size_t overflow.
53
54 * editfns.c (Finsert_char): Don't dump core with very negative counts.
55 Tune. Don't use wider integers than needed. Don't use alloca.
56 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
57
58 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
59
60 * insdel.c, lisp.h (buffer_overflow): New function.
61 (insert_from_buffer_1, replace_range, replace_range_2):
62 * insdel.c (make_gap_larger):
63 * editfns.c (Finsert_char):
64 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
65
66 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
67
68 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
69
70 Integer overflow and signedness fixes (Bug#8873).
71
72 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
73 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
74
75 * fileio.c: Don't assume EMACS_INT fits in off_t.
76 (emacs_lseek): New static function.
77 (Finsert_file_contents, Fwrite_region): Use it.
78 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
79
80 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
81
82 * fns.c: Don't overflow int when computing a list length.
83 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
84 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
85 truncation on 64-bit hosts. Check for QUIT every
86 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
87 faster and is responsive enough.
88 (Flength): Report an error instead of overflowing an integer.
89 (Fsafe_length): Return a float if the value is not representable
90 as a fixnum. This shouldn't happen except in contrived situations.
91 (Fnthcdr, Fsort): Don't assume list length fits in int.
92 (Fcopy_sequence): Don't assume vector length fits in int.
93
94 * alloc.c: Check that resized vectors' lengths fit in fixnums.
95 (header_size, word_size): New constants.
96 (allocate_vectorlike): Don't check size overflow here.
97 (allocate_vector): Check it here instead, since this is the only
98 caller of allocate_vectorlike that could cause overflow.
99 Check that the new vector's length is representable as a fixnum.
100
101 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
102 The previous code was bogus. For example, next_almost_prime (32)
103 returned 39, which is undesirable as it is a multiple of 3; and
104 next_almost_prime (24) returned 25, which is a multiple of 5 so
105 why was the code bothering to check for multiples of 7?
106
107 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
108
109 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
110
111 Variadic C functions now count arguments with ptrdiff_t.
112 This partly undoes my 2011-03-30 change, which replaced int with size_t.
113 Back then I didn't know that the Emacs coding style prefers signed int.
114 Also, in the meantime I found a few more instances where arguments
115 were being counted with int, which may truncate counts on 64-bit
116 machines, or EMACS_INT, which may be unnecessarily wide.
117 * lisp.h (struct Lisp_Subr.function.aMANY)
118 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
119 Arg counts are now ptrdiff_t, not size_t.
120 All variadic functions and their callers changed accordingly.
121 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
122 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
123 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
124 * callint.c (Fcall_interactively): Check arg count for overflow,
125 to avoid potential buffer overrun. Use signed char, not 'int',
126 for 'varies' array, so that we needn't bother to check its size
127 calculation for overflow.
128 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
129 * eval.c (apply_lambda):
130 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
131 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
132 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
133
134 * callint.c (Fcall_interactively): Don't use index var as event count.
135
136 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
137 * mem-limits.h (SIZE): Remove; no longer used.
138
139 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
140
141 Remove unnecessary casts.
142 * xterm.c (x_term_init):
143 * xfns.c (x_set_border_pixel):
144 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
145 These aren't needed now that we assume ANSI C.
146
147 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
148 It's more likely to cause problems (due to unsigned overflow)
149 than to cure them.
150
151 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
152
153 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
154
155 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
156
157 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
158
159 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
160
161 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
162
163 GLYPH_CODE_FACE returns EMACS_INT, not int.
164 * dispextern.h (merge_faces):
165 * xfaces.c (merge_faces):
166 * xdisp.c (get_next_display_element, next_element_from_display_vector):
167 Don't assume EMACS_INT fits in int.
168
169 * character.h (CHAR_VALID_P): Remove unused parameter.
170 * fontset.c, lisp.h, xdisp.c: All uses changed.
171
172 * editfns.c (Ftranslate_region_internal): Omit redundant test.
173
174 * fns.c (concat): Minor tuning based on overflow analysis.
175 This doesn't fix any bugs. Use int to hold character, instead
176 of constantly refetching from Emacs object. Use XFASTINT, not
177 XINT, for value known to be a character. Don't bother comparing
178 a single byte to 0400, as it's always less.
179
180 * floatfns.c (Fexpt):
181 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
182
183 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
184 for characters.
185
186 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
187
188 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
189 Without this fix, on a 64-bit host (aset S 0 4294967386) would
190 incorrectly succeed when S was a string, because 4294967386 was
191 truncated before it was used.
192
193 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
194 Otherwise, an out-of-range integer could cause undefined behavior
195 on a 64-bit host.
196
197 * composite.c: Use int, not EMACS_INT, for characters.
198 (fill_gstring_body, composition_compute_stop_pos): Use int, not
199 EMACS_INT, for values that are known to be in character range.
200 This doesn't fix any bugs but is the usual style inside Emacs and
201 may generate better code on 32-bit machines.
202
203 Make sure a 64-bit char is never passed to ENCODE_CHAR.
204 This is for reasons similar to the recent CHAR_STRING fix.
205 * charset.c (Fencode_char): Check that character arg is actually
206 a character. Pass an int to ENCODE_CHAR.
207 * charset.h (ENCODE_CHAR): Verify that the character argument is no
208 wider than 'int', as a compile-time check to prevent future regressions
209 in this area.
210
211 * character.c (char_string): Remove unnecessary casts.
212
213 Make sure a 64-bit char is never passed to CHAR_STRING.
214 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
215 by silently ignoring the top 32 bits, allowing some values
216 that were far too large to be valid characters.
217 * character.h: Include <verify.h>.
218 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
219 arguments are no wider than unsigned, as a compile-time check
220 to prevent future regressions in this area.
221 * data.c (Faset):
222 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
223 (Fsubst_char_in_region):
224 * fns.c (concat):
225 * xdisp.c (decode_mode_spec_coding):
226 Adjust to CHAR_STRING's new requirement.
227 * editfns.c (Finsert_char, Fsubst_char_in_region):
228 * fns.c (concat): Check that character args are actually
229 characters. Without this test, these functions did the wrong
230 thing with wildly out-of-range values on 64-bit hosts.
231
232 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
233 These casts should not be needed on 32-bit hosts, either.
234 * keyboard.c (read_char):
235 * lread.c (Fload): Remove casts to unsigned.
236
237 * lisp.h (UNSIGNED_CMP): New macro.
238 This fixes comparison bugs on 64-bit hosts.
239 (ASCII_CHAR_P): Use it.
240 * casefiddle.c (casify_object):
241 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
242 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
243 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
244 * dispextern.h (FACE_FROM_ID):
245 * keyboard.c (read_char): Use UNSIGNED_CMP.
246
247 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
248 not to EMACS_INT, to avoid GCC warning.
249
250 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
251
252 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
253 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
254 isn't needed on 32-bit machines.
255
256 * buffer.c (Fgenerate_new_buffer_name):
257 Use EMACS_INT for count, not int.
258 (advance_to_char_boundary): Return EMACS_INT, not int.
259
260 * data.c (Qcompiled_function): Now static.
261
262 * window.c (window_body_lines): Now static.
263
264 * image.c (gif_load): Rename local to avoid shadowing.
265
266 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
267 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
268 * alloc.c (make_save_value): Integer argument is now of type
269 ptrdiff_t, not int.
270 (mark_object): Use ptrdiff_t, not int.
271 * lisp.h (pD): New macro.
272 * print.c (print_object): Use it.
273
274 * alloc.c: Use EMACS_INT, not int, to count objects.
275 (total_conses, total_markers, total_symbols, total_vector_size)
276 (total_free_conses, total_free_markers, total_free_symbols)
277 (total_free_floats, total_floats, total_free_intervals)
278 (total_intervals, total_strings, total_free_strings):
279 Now EMACS_INT, not int. All uses changed.
280 (Fgarbage_collect): Compute overall total using a double, so that
281 integer overflow is less likely to be a problem. Check for overflow
282 when converting back to an integer.
283 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
284 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
285 These were 'int' variables that could overflow on 64-bit hosts;
286 they were never used, so remove them instead of repairing them.
287 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
288 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
289 Previously, this ceilinged at INT_MAX, but that doesn't work on
290 64-bit machines.
291 (allocate_pseudovector): Don't use EMACS_INT when int would do.
292
293 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
294 (allocate_vectorlike): Check for ptrdiff_t overflow.
295 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
296 when a (possibly-narrower) signed value would do just as well.
297 We prefer using signed arithmetic, to avoid comparison confusion.
298
299 * alloc.c: Catch some string size overflows that we were missing.
300 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
301 for convenience in STRING_BYTES_MAX.
302 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
303 The definition here is exact; the one in lisp.h was approximate.
304 (allocate_string_data): Check for string overflow. This catches
305 some instances we weren't catching before. Also, it catches
306 size_t overflow on (unusual) hosts where SIZE_MAX <= min
307 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
308 and ptrdiff_t and EMACS_INT are both 64 bits.
309
310 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
311 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
312 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
313
314 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
315
316 * alloc.c (Fmake_string): Check for out-of-range init.
317
318 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
319
320 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
321
322 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
323
324 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
325 xg_get_default_scrollbar_width.
326
327 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
328 (int_gtk_range_get_value): Move to the scroll bar part of the file.
329 (style_changed_cb): Call update_theme_scrollbar_width and call
330 x_set_scroll_bar_default_width and xg_frame_set_char_size for
331 all frames (Bug#8505).
332 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
333 Call gtk_window_set_resizable if HAVE_GTK3.
334 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
335 and height if HAVE_GTK3 (Bug#8505).
336 (scroll_bar_width_for_theme): New variable.
337 (update_theme_scrollbar_width): New function.
338 (xg_get_default_scrollbar_width): Move code to
339 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
340 (xg_initialize): Call update_theme_scrollbar_width.
341
342 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
343
344 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
345
346 2011-06-12 Martin Rudalics <rudalics@gmx.at>
347
348 * frame.c (make_frame): Call other_buffer_safely instead of
349 other_buffer.
350
351 * window.c (temp_output_buffer_show): Call display_buffer with
352 second argument Vtemp_buffer_show_specifiers and reset latter
353 immediately after the call.
354 (Vtemp_buffer_show_specifiers): New variable.
355 (auto_window_vscroll_p, next_screen_context_lines)
356 (Vscroll_preserve_screen_position): Remove leading asterisks from
357 doc-strings.
358
359 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
360
361 Fix minor problems found by GCC 4.6.0 static checking.
362 * buffer.c (Qclone_number): Remove for now, as it's unused.
363 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
364 (record_buffer): Remove unused local.
365 * frame.c (other_visible_frames, frame_buffer_list): Now static.
366 (set_frame_buffer_list): Remove; unused.
367 * frame.h (other_visible_frames): Remove decl.
368 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
369 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
370 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
371 if HAVE_GPM.
372 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
373 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
374 Define only if HAVE_GPM.
375 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
376 (update_hints_inhibit): Remove; never set. All uses removed.
377 * widgetprv.h (emacsFrameClassRec): Remove decl.
378 * window.c (delete_deletable_window): Now returns void, since it
379 wasn't returning anything.
380 (compare_window_configurations): Remove unused locals.
381 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
382 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
383 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
384 the same widths as pointers. This follows up on the 2011-05-06 patch.
385 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
386 * xterm.h: Likewise.
387 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
388
389 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
390
391 * makefile.w32-in: Update dependencies.
392 (LISP_H): Add lib/intprops.h.
393
394 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
395
396 * image.c (gif_load): Add animation frame delay to the metadata.
397 (syms_of_image): Use DEFSYM. New symbol `delay'.
398
399 2011-06-11 Martin Rudalics <rudalics@gmx.at>
400
401 * window.c (delete_deletable_window): Re-add.
402 (Fset_window_configuration): Rewrite to handle dead buffers and
403 consequently deletable windows.
404 (window_tree, Fwindow_tree): Remove. Supply functionality in
405 window.el.
406 (compare_window_configurations): Simplify code.
407
408 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
409
410 * image.c (imagemagick_load_image): Fix type mismatch.
411 (Fimagemagick_types): Likewise.
412
413 * window.h (replace_buffer_in_windows): Declare.
414
415 2011-06-11 Martin Rudalics <rudalics@gmx.at>
416
417 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
418 Qclone_number. Remove external declaration of Qdelete_window.
419 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
420 code.
421 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
422 Qbuffer_list_update_hook if allowed.
423 (Fother_buffer): Rewrite doc-string. Major rewrite for new
424 buffer list implementation.
425 (other_buffer_safely): New function.
426 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
427 calls to replace_buffer_in_windows and
428 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
429 if allowed.
430 (record_buffer): Inhibit quitting and rewrite using quittable
431 functions. Run Qbuffer_list_update_hook if allowed.
432 (Frecord_buffer, Funrecord_buffer): New functions.
433 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
434 switch-to-buffer to window.el.
435 (bury-buffer): Move to window.el.
436 (Vbuffer_list_update_hook): New variable.
437
438 * lisp.h (other_buffer_safely): Add prototype in buffer.c
439 section.
440
441 * window.h (resize_frame_windows): Move up in code.
442 (Fwindow_frame): Remove EXFUN.
443 (replace_buffer_in_all_windows): Remove prototype.
444 (replace_buffer_in_windows_safely): Add prototype.
445
446 * window.c: Declare Qdelete_window static again. Move down
447 declaration of select_count.
448 (Fnext_window, Fprevious_window): Rewrite doc-strings.
449 (Fother_window): Move to window.el.
450 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
451 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
452 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
453 window.el.
454 (replace_buffer_in_windows): Implement by calling
455 Qreplace_buffer_in_windows.
456 (replace_buffer_in_all_windows): Remove with some functionality
457 moved into replace_buffer_in_windows_safely.
458 (replace_buffer_in_windows_safely): New function.
459 (select_window_norecord, select_frame_norecord): Move in front
460 of run_window_configuration_change_hook. Remove now obsolete
461 declarations.
462 (Fset_window_buffer): Rewrite doc-string. Call
463 Qrecord_window_buffer.
464 (keys_of_window): Move binding for other-window to window.el.
465
466 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
467
468 * dispextern.h (struct image): Replace data member, whose int_val
469 and ptr_val fields were not used by anything, with a single
470 lisp_val object.
471
472 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
473 (gif_clear_image, gif_load, imagemagick_load_image)
474 (gs_clear_image, gs_load): Callers changed.
475
476 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
477
478 * buffer.h: Include <time.h>, for time_t.
479 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
480
481 Fix minor problems found by static checking.
482
483 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
484
485 Make identifiers static if they are not used in other modules.
486 * data.c (Qcompiled_function, Qframe, Qvector):
487 * image.c (QimageMagick, Qsvg):
488 * minibuf.c (Qmetadata):
489 * window.c (resize_window_check, resize_root_window): Now static.
490 * window.h (resize_window_check, resize_root_window): Remove decls.
491
492 * window.c (window_deletion_count, delete_deletable_window):
493 Remove; unused.
494 (window_body_lines): Now static.
495 (Fdelete_other_windows_internal): Mark vars as initialized.
496 Make sure 'resize_failed' is initialized.
497 (run_window_configuration_change_hook): Rename local to avoid shadowing.
498 (resize_window_apply): Remove unused local.
499 * window.h (delete_deletable_window): Remove decl.
500
501 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
502 (imagemagick_load_image): Fix pointer signedness problem by changing
503 last arg from unsigned char * to char *. All uses changed.
504 Also, fix a local for similar reasons.
505 Remove unused locals. Remove locals to avoid shadowing.
506 (fn_rsvg_handle_free): Remove; unused.
507 (svg_load, svg_load_image): Fix pointer signedness problem.
508 (imagemagick_load_image): Don't use garbage pointer image_wand.
509
510 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
511
512 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
513
514 * image.c (gif_load): Fix omitted cast error introduced by
515 2011-06-06 change.
516
517 2011-06-10 Martin Rudalics <rudalics@gmx.at>
518
519 * window.h (resize_proportionally, orig_total_lines)
520 (orig_top_line): Remove from window structure.
521 (set_window_height, set_window_width, change_window_heights)
522 (Fdelete_window): Remove prototypes.
523 (resize_frame_windows): Remove duplicate declaration.
524
525 2011-06-10 Eli Zaretskii <eliz@gnu.org>
526
527 * window.h (resize_frame_windows, resize_window_check)
528 (delete_deletable_window, resize_root_window)
529 (resize_frame_windows): Declare prototypes.
530
531 * window.c (resize_window_apply): Make definition be "static" to
532 match the prototype.
533
534 2011-06-10 Martin Rudalics <rudalics@gmx.at>
535
536 * window.c: Remove declarations of Qwindow_size_fixed,
537 window_min_size_1, window_min_size_2, window_min_size,
538 size_window, window_fixed_size_p, enlarge_window, delete_window.
539 Remove static from declaration of Qdelete_window, it's
540 temporarily needed by Fbury_buffer.
541 (replace_window): Don't assign orig_top_line and
542 orig_total_lines.
543 (Fdelete_window, delete_window): Remove. Window deletion is
544 handled by window.el.
545 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
546 Fdelete_window calls with calls to Qdelete_window.
547 (Fdelete_other_windows): Remove. Deleting other windows is
548 handled by window.el.
549 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
550 handled in window.el.
551 (window_min_size_2, window_min_size_1, window_min_size): Remove.
552 Window minimum sizes are handled in window.el.
553 (shrink_windows, size_window, set_window_height)
554 (set_window_width, change_window_heights, window_height)
555 (window_width, CURBEG, CURSIZE, enlarge_window)
556 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
557 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
558 handled in window.el.
559 (make_dummy_parent): Rename to make_parent_window and give it a
560 second argument horflag.
561 (make_window): Don't set resize_proportionally any more.
562 (Fsplit_window): Remove. Windows are split in window.el.
563 (save_restore_action, save_restore_orig_size)
564 (shrink_window_lowest_first, save_restore_orig_size): Remove.
565 Resize mini windows in window.el.
566 (grow_mini_window, shrink_mini_window): Implement by calling
567 Qresize_root_window_vertically, resize_window_check and
568 resize_window_apply.
569 (saved_window, Fset_window_configuration, save_window_save): Do
570 not handle orig_top_line, orig_total_lines, and
571 resize_proportionally.
572 (window_min_height, window_min_width): Move to window.el.
573 (keys_of_window): Move bindings for delete-other-windows,
574 split-window, delete-window and enlarge-window to window.el.
575
576 * buffer.c: Temporarily extern Qdelete_window.
577 (Fbury_buffer): Temporarily call Qdelete_window instead of
578 Fdelete_window (Fbury_buffer will move to window.el soon).
579
580 * frame.c (set_menu_bar_lines_1): Remove code handling
581 orig_top_line and orig_total_lines.
582
583 * dispnew.c (adjust_frame_glyphs_initially): Don't use
584 set_window_height but set heights directly.
585 (change_frame_size_1): Use resize_frame_windows.
586
587 * xdisp.c (init_xdisp): Don't use set_window_height but set
588 heights directly.
589
590 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
591 resize_frame_windows instead of change_window_heights and run
592 run_window_configuration_change_hook.
593
594 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
595 instead of change_window_heights and run
596 run_window_configuration_change_hook.
597
598 2011-06-09 Martin Rudalics <rudalics@gmx.at>
599
600 * window.c (replace_window): Rename second argument REPLACEMENT to
601 NEW. New third argument SETFLAG. Rewrite.
602 (delete_window, make_dummy_parent): Call replace_window with
603 third argument 1.
604 (window_list_1): Move down in code.
605 (run_window_configuration_change_hook): Move set_buffer part
606 before select_frame_norecord part in order to unwind correctly.
607 Rename count1 to count.
608 (recombine_windows, delete_deletable_window, resize_root_window)
609 (Fdelete_other_windows_internal)
610 (Frun_window_configuration_change_hook, make_parent_window)
611 (resize_window_check, resize_window_apply, Fresize_window_apply)
612 (resize_frame_windows, Fsplit_window_internal)
613 (Fdelete_window_internal, Fresize_mini_window_internal): New
614 functions.
615 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
616
617 2011-06-08 Martin Rudalics <rudalics@gmx.at>
618
619 * window.h (window): Add some new members to window structure -
620 normal_lines, normal_cols, new_total, new_normal, clone_number,
621 splits, nest, prev_buffers, next_buffers.
622 (WINDOW_TOTAL_SIZE): Move here from window.c.
623 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
624
625 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
626 Remove.
627 (make_dummy_parent): Set new members of windows structure.
628 (make_window): Move down in code. Handle new members of window
629 structure.
630 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
631 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
632 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
633 (Fset_window_prev_buffers, Fwindow_next_buffers)
634 (Fset_window_next_buffers, Fset_window_clone_number): New
635 functions.
636 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
637 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
638 Doc-string fixes.
639 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
640 Argument WINDOW can be now internal window too.
641 (Fwindow_use_time): Move up in code.
642 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
643 Rewrite doc-string.
644 (Fset_window_configuration, saved_window)
645 (Fcurrent_window_configuration, save_window_save): Handle new
646 members of window structure.
647 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
648 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
649 (syms_of_window): New Lisp objects Qrecord_window_buffer,
650 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
651 Qget_mru_window, Qresize_root_window,
652 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
653 Qauto_buffer_name; staticpro them.
654
655 2011-06-07 Martin Rudalics <rudalics@gmx.at>
656
657 * window.c (Fwindow_total_size, Fwindow_left_column)
658 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
659 (Fwindow_list_1): New functions.
660 (window_box_text_cols): Replace with window_body_cols.
661 (Fwindow_width, Fscroll_left, Fscroll_right): Use
662 window_body_cols instead of window_box_text_cols.
663 (delete_window, Fset_window_configuration): Call
664 delete_all_subwindows with window as argument.
665 (delete_all_subwindows): Take a window as argument and not a
666 structure. Rewrite.
667 (window_loop): Remove handling of GET_LRU_WINDOW and
668 GET_LARGEST_WINDOW.
669 (Fget_lru_window, Fget_largest_window): Move to window.el.
670
671 * window.h: Extern window_body_cols instead of
672 window_box_text_cols. delete_all_subwindows now takes a
673 Lisp_Object as argument.
674
675 * indent.c (compute_motion, Fcompute_motion): Use
676 window_body_cols instead of window_box_text_cols.
677
678 * frame.c (delete_frame): Call delete_all_subwindows with root
679 window as argument.
680
681 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
682
683 * fns.c (Fputhash): Document return value.
684
685 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
686
687 * image.c (gif_load): Implement gif89a spec "no disposal" method.
688
689 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
690
691 Cons<->int and similar integer overflow fixes (Bug#8794).
692
693 Check for overflow when converting integer to cons and back.
694 * charset.c (Fdefine_charset_internal, Fdecode_char):
695 Use cons_to_unsigned to catch overflow.
696 (Fencode_char): Use INTEGER_TO_CONS.
697 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
698 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
699 * data.c (long_to_cons, cons_to_long): Remove.
700 (cons_to_unsigned, cons_to_signed): New functions.
701 These signal an error for invalid or out-of-range values.
702 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
703 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
704 * font.c (Ffont_variation_glyphs):
705 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
706 * lisp.h: Include <intprops.h>.
707 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
708 (cons_to_signed, cons_to_unsigned): New decls.
709 (long_to_cons, cons_to_long): Remove decls.
710 * undo.c (record_first_change): Use INTEGER_TO_CONS.
711 (Fprimitive_undo): Use CONS_TO_INTEGER.
712 * xfns.c (Fx_window_property): Likewise.
713 * xselect.c: Include <limits.h>.
714 (x_own_selection, selection_data_to_lisp_data):
715 Use INTEGER_TO_CONS.
716 (x_handle_selection_request, x_handle_selection_clear)
717 (x_get_foreign_selection, Fx_disown_selection_internal)
718 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
719 (lisp_data_to_selection_data): Use cons_to_unsigned.
720 (x_fill_property_data): Use cons_to_signed.
721 Report values out of range.
722
723 Check for buffer and string overflow more precisely.
724 * buffer.h (BUF_BYTES_MAX): New macro.
725 * lisp.h (STRING_BYTES_MAX): New macro.
726 * alloc.c (Fmake_string):
727 * character.c (string_escape_byte8):
728 * coding.c (coding_alloc_by_realloc):
729 * doprnt.c (doprnt):
730 * editfns.c (Fformat):
731 * eval.c (verror):
732 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
733 since they may not be the same number.
734 * editfns.c (Finsert_char):
735 * fileio.c (Finsert_file_contents):
736 Likewise for BUF_BYTES_MAX.
737
738 * image.c: Use ptrdiff_t, not int, for sizes.
739 (slurp_file): Switch from int to ptrdiff_t.
740 All uses changed.
741 (slurp_file): Check that file size fits in both size_t (for
742 malloc) and ptrdiff_t (for sanity and safety).
743
744 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
745 if b->modtime has its maximal value.
746
747 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
748
749 Don't assume time_t can fit into int.
750 * buffer.h (struct buffer.modtime): Now time_t, not int.
751 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
752 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
753
754 Minor fixes for signed vs unsigned integers.
755 * character.h (MAYBE_UNIFY_CHAR):
756 * charset.c (maybe_unify_char):
757 * keyboard.c (read_char, reorder_modifiers):
758 XINT -> XFASTINT, since the integer must be nonnegative.
759 * ftfont.c (ftfont_spec_pattern):
760 * keymap.c (access_keymap, silly_event_symbol_error):
761 XUINT -> XFASTINT, since the integer must be nonnegative.
762 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
763 since it makes no difference and we prefer signed.
764 * keyboard.c (record_char): Use XUINT when all the neighbors do.
765 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
766 nonnegative.
767
768 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
769
770 * window.h (Fwindow_frame): Declare.
771
772 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
773
774 * alloc.c: Simplify handling of large-request failures (Bug#8800).
775 (SPARE_MEMORY): Always define.
776 (LARGE_REQUEST): Remove.
777 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
778
779 2011-06-06 Martin Rudalics <rudalics@gmx.at>
780
781 * lisp.h: Move EXFUNS for Fframe_root_window,
782 Fframe_first_window and Fset_frame_selected_window to window.h.
783
784 * window.h: Move EXFUNS for Fframe_root_window,
785 Fframe_first_window and Fset_frame_selected_window here from
786 lisp.h.
787
788 * frame.c (Fwindow_frame, Fframe_first_window)
789 (Fframe_root_window, Fframe_selected_window)
790 (Fset_frame_selected_window): Move to window.c.
791 (Factive_minibuffer_window): Move to minibuf.c.
792 (Fother_visible_frames_p): New function.
793
794 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
795
796 * window.c (decode_window, decode_any_window): Move up in code.
797 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
798 (inhibit_frame_unsplittable): Remove unused variable.
799 (Fwindow_buffer): Move up and rewrite doc-string.
800 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
801 (Fwindow_prev): New functions.
802 (Fwindow_frame): Move here from frame.c. Accept any window as
803 argument.
804 (Fframe_root_window, Fframe_first_window)
805 (Fframe_selected_window): Move here from frame.c. Accept frame
806 or arbitrary window as argument. Update doc-strings.
807 (Fminibuffer_window): Move up in code.
808 (Fwindow_minibuffer_p): Move up in code and simplify.
809 (Fset_frame_selected_window): Move here from frame.c.
810 Marginal rewrite.
811 (Fselected_window, select_window, Fselect_window): Move up in
812 code. Minor doc-string fixes.
813
814 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
815
816 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
817 Do not assume that spare memory exists; that assumption is valid
818 only if SYSTEM_MALLOC.
819 (LARGE_REQUEST): New macro, so that the issue of large requests
820 is separated from the issue of spare memory.
821
822 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
823
824 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
825 format. (Bug#8806)
826
827 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
828
829 * xfns.c (x_set_scroll_bar_default_width): Move declarations
830 before statements.
831
832 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
833
834 * gtkutil.c (xg_get_default_scrollbar_width): New function.
835
836 * gtkutil.h: Declare xg_get_default_scrollbar_width.
837
838 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
839 min width by calling x_set_scroll_bar_default_width (Bug#8505).
840
841 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
842
843 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
844
845 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
846
847 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
848 (x_clipboard_manager_save): Add return value.
849 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
850 New error handlers.
851 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
852 Obey Vx_select_enable_clipboard_manager. Catch errors in
853 x_clipboard_manager_save (Bug#8779).
854 (Vx_select_enable_clipboard_manager): New variable.
855 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
856
857 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
858
859 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
860
861 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
862
863 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
864 in the current matrix if keep_current_p is non-zero.
865
866 2011-06-04 Eli Zaretskii <eliz@gnu.org>
867
868 * bidi.c (bidi_level_of_next_char): Fix last change.
869
870 2011-06-03 Eli Zaretskii <eliz@gnu.org>
871
872 Support bidi reordering of text covered by display properties.
873
874 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
875 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
876 (bidi_cache_search, bidi_cache_iterator_state)
877 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
878 (bidi_level_of_next_char, bidi_move_to_visually_next):
879 Support character positions inside a run of characters covered by a
880 display string.
881 (bidi_paragraph_init, bidi_resolve_explicit_1)
882 (bidi_level_of_next_char): Call bidi_fetch_char and
883 bidi_fetch_char_advance instead of FETCH_CHAR and
884 FETCH_CHAR_ADVANCE.
885 (bidi_init_it): Initialize new members.
886 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
887 definitions.
888 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
889 instead of using explicit *_CHAR codes.
890 (bidi_resolve_explicit, bidi_resolve_weak):
891 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
892 bidirectional text is supported only in multibyte buffers.
893 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
894 it to initialize the frame_window_p member of struct bidi_it.
895 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
896 (bidi_resolve_explicit, bidi_resolve_weak)
897 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
898 bidi_it->nchars is non-positive.
899 (bidi_level_of_next_char): Don't try to lookup the cache for the
900 next/previous character if nothing is cached there yet, or if we
901 were just reseat()'ed to a new position.
902
903 * xdisp.c (set_cursor_from_row): Set start and stop points
904 according to the row's direction when priming the loop that looks
905 for the glyph on which to display cursor.
906 (single_display_spec_intangible_p): Function deleted.
907 (display_prop_intangible_p): Reimplement to call
908 handle_display_spec instead of single_display_spec_intangible_p.
909 Accept 3 additional arguments needed by handle_display_spec.
910 This fixes incorrect cursor motion across display property with complex
911 values: lists, `(when COND...)' forms, etc.
912 (single_display_spec_string_p): Support property values that are
913 lists with the argument STRING its top-level element.
914 (display_prop_string_p): Fix the condition for processing a
915 property that is a list to be consistent with handle_display_spec.
916 (handle_display_spec): New function, refactored from the
917 last portion of handle_display_prop.
918 (compute_display_string_pos): Accept additional argument
919 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
920 value of a `display' property is a "replacing spec".
921 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
922 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
923 the display property, but just return a value indicating whether
924 the display property will replace the characters it covers.
925 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
926 frame_window_p members of struct bidi_it.
927 (compute_display_string_pos, compute_display_string_end):
928 New functions.
929 (push_it): Accept second argument POSITION, where pop_it should
930 jump to continue iteration.
931 (reseat_1): Initialize bidi_it.disp_pos.
932
933 * keyboard.c (adjust_point_for_property): Adjust the call to
934 display_prop_intangible_p to its new signature.
935
936 * dispextern.h (struct bidi_it): New member frame_window_p.
937 (bidi_init_it): Update prototypes.
938 (display_prop_intangible_p): Update prototype.
939 (compute_display_string_pos, compute_display_string_end):
940 Declare prototypes.
941 (struct bidi_it): New members nchars and disp_pos. ch_len is now
942 EMACS_INT.
943
944 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
945
946 Malloc failure behavior now depends on size of allocation.
947 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
948 * lisp.h: Change signatures accordingly.
949 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
950 All callers changed. (Bug#8762)
951
952 * gnutls.c: Use Emacs's memory allocators.
953 Without this change, the gnutls library would invoke malloc etc.
954 directly, which causes problems on non-SYNC_INPUT hosts, and which
955 runs afoul of improving memory_full behavior. (Bug#8761)
956 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
957 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
958 xfree instead of the default malloc, realloc, free.
959 (Fgnutls_boot): No need to check for memory allocation failure,
960 since xmalloc does that for us.
961
962 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
963 * category.c (hash_get_category_set):
964 * ccl.c (ccl_driver):
965 * charset.c (Fdefine_charset_internal):
966 * charset.h (struct charset.hash_index):
967 * composite.c (get_composition_id, gstring_lookup_cache)
968 (composition_gstring_put_cache):
969 * composite.h (struct composition.hash_index):
970 * dispextern.h (struct image.hash):
971 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
972 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
973 (hashfn_equal, hashfn_user_defined, make_hash_table)
974 (maybe_resize_hash_table, hash_lookup, hash_put)
975 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
976 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
977 (Fsxhash, Fgethash, Fputhash, Fmaphash):
978 * image.c (make_image, search_image_cache, lookup_image)
979 (xpm_put_color_table_h):
980 * lisp.h (struct Lisp_Hash_Table):
981 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
982 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
983 for hashes and hash indexes, instead of 'unsigned' and 'int'.
984 * alloc.c (allocate_vectorlike):
985 Check for overflow in vector size calculations.
986 * ccl.c (ccl_driver):
987 Check for overflow when converting EMACS_INT to int.
988 * fns.c, image.c: Remove unnecessary static decls that would otherwise
989 need to be updated by these changes.
990 * fns.c (make_hash_table, maybe_resize_hash_table):
991 Check for integer overflow with large hash tables.
992 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
993 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
994 (SXHASH_REDUCE): New macro.
995 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
996 Use it instead of discarding useful hash info with large hash values.
997 (sxhash_float): New function.
998 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
999 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1000 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1001 Rewrite to use FIXNUM_BITS, as this simplifies things.
1002 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1003 Adjust signatures to match updated version of code.
1004 (consing_since_gc): Now EMACS_INT, since a single hash table can
1005 use more than INT_MAX bytes.
1006
1007 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1008
1009 Make it possible to build with GCC-4.6+ -O2 -flto.
1010
1011 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1012
1013 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1014
1015 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1016 Call minibuffer-inactive-mode.
1017
1018 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1019
1020 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1021 Update dependencies.
1022
1023 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1024
1025 * data.c (init_data): Remove code for UTS, this system is not
1026 supported anymore.
1027
1028 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1029
1030 Don't force ./temacs to start in terminal mode.
1031
1032 * frame.c (make_initial_frame): Initialize faces in all cases, not
1033 only when CANNOT_DUMP is defined.
1034 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1035
1036 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1037
1038 * dispnew.c (add_window_display_history): Use const for the string
1039 pointer. Remove declaration, not needed.
1040
1041 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1042
1043 Use 'inline', not 'INLINE'.
1044 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1045 * alloc.c, fontset.c (INLINE): Remove.
1046 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1047 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1048 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1049 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1050 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1051
1052 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1053
1054 Make it possible to run ./temacs.
1055
1056 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1057 syms_of_callproc does the same thing. Remove test for
1058 "initialized", do it in the caller.
1059 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1060
1061 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1062
1063 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1064 (read_minibuf): Use get_minibuffer.
1065 (syms_of_minibuf): Use DEFSYM.
1066 (Qmetadata): New var.
1067 * data.c (Qbuffer): Don't make it static.
1068 (syms_of_data): Use DEFSYM.
1069
1070 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1071
1072 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1073 (CCL_CODE_MIN): New macro.
1074
1075 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1076
1077 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1078
1079 * eval.c (Qdebug): Now static.
1080 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1081 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1082 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1083
1084 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1085
1086 * image.c: Various fixes to ImageMagick code comments.
1087 (Fimagemagick_types): Doc fix.
1088
1089 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1090
1091 Minor fixes prompted by GCC 4.6.0 warnings.
1092
1093 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1094
1095 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1096 (x_clipboard_manager_save_all): Move extern decl to ...
1097 * xterm.h: ... here, so that it can be checked for consistency.
1098
1099 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1100
1101 * xselect.c (x_clipboard_manager_save_frame)
1102 (x_clipboard_manager_save_all): New functions.
1103 (Fx_clipboard_manager_save): Lisp function deleted.
1104
1105 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1106 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1107
1108 * xterm.h: Update prototype.
1109
1110 2011-05-28 William Xu <william.xwl@gmail.com>
1111
1112 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1113 exiting (Bug#8239).
1114
1115 2011-05-28 Jim Meyering <meyering@redhat.com>
1116
1117 Avoid a sign-extension bug in crypto_hash_function.
1118 * fns.c (to_uchar): Define.
1119 (crypto_hash_function): Use it to convert some newly-signed
1120 variables to unsigned, to avoid sign-extension bugs. For example,
1121 without this change, (md5 "truc") would evaluate to
1122 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1123 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1124 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1125
1126 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1127
1128 Integer overflow fixes.
1129
1130 * dbusbind.c: Serial number integer overflow fixes.
1131 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1132 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1133 to hold a serial number that is too large for a fixnum.
1134 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1135 Check for serial numbers out of range. Decode any serial number
1136 that was so large that it became a float. (Bug#8722)
1137
1138 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1139 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1140 Use XFASTINT rather than XUINT when numbers are nonnegative.
1141 (xd_append_arg, Fdbus_method_return_internal):
1142 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1143 arguments, check that Lisp number is nonnegative, rather than
1144 silently wrapping negative numbers around. (Bug#8722)
1145 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1146 (Bug#8722)
1147
1148 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1149
1150 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1151
1152 ccl: add integer overflow checks
1153 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1154 (IN_INT_RANGE): New macros.
1155 (ccl_driver): Use them to check for integer overflow when
1156 decoding a CCL program. Many of the new checks are whether XINT (x)
1157 fits in int; it doesn't always, on 64-bit hosts. The new version
1158 doesn't catch all possible integer overflows, but it's an
1159 improvement. (Bug#8719)
1160
1161 * alloc.c (make_event_array): Use XINT, not XUINT.
1162 There's no need for unsigned here.
1163
1164 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1165 This follows up to the 2011-05-06 change that substituted uintptr_t
1166 for EMACS_INT. This case wasn't caught back then.
1167
1168 Rework Fformat to avoid integer overflow issues.
1169 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1170 now (part of C89). Include <verify.h>.
1171 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1172 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1173 (Fformat): Avoid the prepass trying to compute sizes; it was only
1174 approximate and thus did not catch overflow reliably. Instead, walk
1175 through the format just once, formatting and computing sizes as we go,
1176 checking for integer overflow at every step, and allocating a larger
1177 buffer as needed. Keep track separately whether the format is
1178 multibyte. Keep only the most-recently calculated precision, rather
1179 than them all. Record whether each argument has been converted to
1180 string. Use EMACS_INT, not int, for byte and char and arg counts.
1181 Support field widths and precisions larger than INT_MAX. Avoid
1182 sprintf's undefined behavior with conversion specifications such as %#d
1183 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1184 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1185 formatting out-of-range floating point numbers with int
1186 formats. (Bug#8668)
1187
1188 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1189
1190 * data.c: Avoid integer truncation in expressions involving floats.
1191 * data.c: Include <intprops.h>.
1192 (arith_driver): When there's an integer overflow in an expression
1193 involving floating point, convert the integers to floating point
1194 so that the resulting value does not suffer from catastrophic
1195 integer truncation. For example, on a 64-bit host (* 4
1196 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1197 Do not rely on undefined behavior after integer overflow.
1198
1199 merge count_size_as_multibyte, parse_str_to_multibyte
1200 * character.c, character.h (count_size_as_multibyte):
1201 Rename from parse_str_to_multibyte; all uses changed.
1202 Check for integer overflow.
1203 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1204 since it's now a duplicate of the other. This is more of
1205 a character than a buffer op, so better that it's in character.c.
1206 * fns.c, print.c: Adjust to above changes.
1207
1208 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1209
1210 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1211
1212 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1213
1214 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1215 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1216 (x_clipboard_manager_save): Now static.
1217 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1218
1219 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1220 (crypto_hash_function): Now static.
1221 Fix pointer signedness problems. Avoid unnecessary initializations.
1222
1223 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1224
1225 * termhooks.h (Vselection_alist): Make it terminal-local.
1226
1227 * terminal.c (create_terminal): Initialize it.
1228
1229 * xselect.c: Support for clipboard managers.
1230 (Vselection_alist): Move to termhooks.h as terminal-local var.
1231 (LOCAL_SELECTION): New macro.
1232 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1233 (symbol_to_x_atom): Remove gratuitous arg.
1234 (x_handle_selection_request, lisp_data_to_selection_data)
1235 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1236 (x_own_selection, x_get_local_selection, x_convert_selection):
1237 New arg, specifying work frame. Use terminal-local Vselection_alist.
1238 (some_frame_on_display): Delete unused function.
1239 (Fx_own_selection_internal, Fx_get_selection_internal)
1240 (Fx_disown_selection_internal, Fx_selection_owner_p)
1241 (Fx_selection_exists_p): New optional frame arg.
1242 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1243 (x_handle_selection_clear): Don't treat other terminals with the
1244 same keyboard specially. Use the terminal-local Vselection_alist.
1245 (x_clear_frame_selections): Use Frun_hook_with_args.
1246
1247 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1248
1249 * xterm.h: Add support for those atoms.
1250
1251 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1252
1253 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1254 (converted_selections, conversion_fail_tag): New global variables.
1255 (x_selection_request_lisp_error): Free the above.
1256 (x_get_local_selection): Remove unnecessary code.
1257 (x_reply_selection_request): Args changed; handle arbitrary array
1258 of converted selections stored in converted_selections.
1259 Separate the XChangeProperty and SelectionNotify steps.
1260 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1261 (x_convert_selection): New function.
1262 (x_handle_selection_event): Simplify.
1263 (x_get_foreign_selection): Don't ignore incoming requests while
1264 waiting for an answer; this will fail when we implement
1265 SAVE_TARGETS, and seems unnecessary anyway.
1266 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1267 (Vx_sent_selection_functions): Doc fix.
1268
1269 2011-05-26 Leo Liu <sdl.web@gmail.com>
1270
1271 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1272
1273 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1274
1275 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1276
1277 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1278 for fringe update if it has periodic bitmap.
1279 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1280 and fringe_bitmap_periodic_p.
1281
1282 * fringe.c (get_fringe_bitmap_data): New function.
1283 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1284 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1285 row. Mark glyph row for fringe update if periodicity changed.
1286
1287 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1288 for fringe update unless it has periodic bitmap.
1289
1290 2011-05-25 Kenichi Handa <handa@m17n.org>
1291
1292 * xdisp.c (get_next_display_element): Set correct it->face_id for
1293 a static composition.
1294
1295 2011-05-24 Leo Liu <sdl.web@gmail.com>
1296
1297 * deps.mk (fns.o):
1298 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1299
1300 * fns.c (crypto_hash_function, Fsha1): New function.
1301 (Fmd5): Use crypto_hash_function.
1302 (syms_of_fns): Add Ssha1.
1303
1304 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1305
1306 * gnutls.c: Remove unused macros.
1307 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1308 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1309 Remove macros that are defined and never used.
1310 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1311
1312 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1313
1314 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1315 (Fx_get_selection_internal): Minor cleanup.
1316 (Fx_own_selection_internal): Rename arguments for consistency with
1317 select.el.
1318
1319 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1320
1321 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1322
1323 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1324
1325 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1326
1327 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1328
1329 * dispnew.c (scrolling_window): Don't exclude the case that the
1330 last enabled row in the desired matrix touches the bottom boundary.
1331
1332 2011-05-21 Glenn Morris <rgm@gnu.org>
1333
1334 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1335 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1336 and add some more files.
1337
1338 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1339
1340 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1341 report_file_error introduced by the change from 2011-05-07.
1342
1343 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1344
1345 * systime.h (Time): Define only if emacs is defined.
1346 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1347 where the include path doesn't have X11/X.h by default. See
1348 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1349
1350 2011-05-20 Kenichi Handa <handa@m17n.org>
1351
1352 * composite.c (find_automatic_composition): Fix previous change.
1353
1354 2011-05-20 Glenn Morris <rgm@gnu.org>
1355
1356 * lisp.mk: New file, split from Makefile.in.
1357 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1358 (shortlisp): Remove.
1359 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1360
1361 2011-05-19 Glenn Morris <rgm@gnu.org>
1362
1363 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1364 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1365 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1366 (lisp): Set the order to that of loadup.el.
1367 (shortlisp): Make it a copy of $lisp.
1368 (SOME_MACHINE_LISP): Remove.
1369 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1370 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1371
1372 2011-05-18 Kenichi Handa <handa@m17n.org>
1373
1374 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1375 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1376 (find_automatic_composition): Mostly rewrite for efficiency.
1377
1378 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1379
1380 * makefile.w32-in: Update dependencies.
1381
1382 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1383
1384 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1385 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
1386
1387 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1388
1389 Fix some integer overflow issues, such as string length overflow.
1390
1391 * insdel.c (count_size_as_multibyte): Check for string overflow.
1392
1393 * character.c (lisp_string_width): Check for string overflow.
1394 Use EMACS_INT, not int, for string indexes and lengths; in
1395 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1396 the resulting string length overflows an EMACS_INT; instead,
1397 report a string overflow if no precision given. When checking for
1398 precision exhaustion, use a check that cannot possibly have
1399 integer overflow. (Bug#8675)
1400 * character.h (lisp_string_width): Adjust to new signature.
1401
1402 * alloc.c (string_overflow): New function.
1403 (Fmake_string): Use it. This doesn't change behavior, but saves
1404 a few bytes and will simplify future changes.
1405 * character.c (string_escape_byte8): Likewise.
1406 * lisp.h (string_overflow): New decl.
1407
1408 Fixups, following up to the user-interface timestamp change.
1409 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1410 for UI timestamps, instead of unsigned long.
1411 * msdos.c (mouse_get_pos): Likewise.
1412 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1413 * w32gui.h (Time): Define by including "systime.h" rather than by
1414 declaring it ourselves. (Bug#8664)
1415
1416 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1417 * image.c (clear_image_cache): Likewise.
1418
1419 * term.c (term_mouse_position): Don't assume time_t wraparound.
1420
1421 Be more systematic about user-interface timestamps.
1422 Before, the code sometimes used 'Time', sometimes 'unsigned long',
1423 and sometimes 'EMACS_UINT', to represent these timestamps.
1424 This change causes it to use 'Time' uniformly, as that's what X uses.
1425 This makes the code easier to follow, and makes it easier to catch
1426 integer overflow bugs such as Bug#8664.
1427 * frame.c (Fmouse_position, Fmouse_pixel_position):
1428 Use Time, not unsigned long, for user-interface timestamps.
1429 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1430 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1431 * keyboard.h (last_event_timestamp): Likewise.
1432 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1433 * menu.h (xmenu_show): Likewise.
1434 * term.c (term_mouse_position): Likewise.
1435 * termhooks.h (struct input_event.timestamp): Likewise.
1436 (struct terminal.mouse_position_hook): Likewise.
1437 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1438 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1439 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1440 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1441 what it was before.
1442 * menu.h, termhooks.h: Include "systime.h", for Time.
1443
1444 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1445 Don't assume that the difference between two unsigned long values
1446 can fit into an integer. At this point, we know button_down_time
1447 <= event->timestamp, so the difference must be nonnegative, so
1448 there's no need to cast the result if double-click-time is
1449 nonnegative, as it should be; check that it's nonnegative, just in
1450 case. This bug is triggered when events are more than 2**31 ms
1451 apart (about 25 days). (Bug#8664)
1452
1453 * xselect.c (last_event_timestamp): Remove duplicate decl.
1454 (x_own_selection): Remove needless cast to unsigned long.
1455
1456 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1457 that always fit in int. Use a sentinel instead of a counter, to
1458 avoid a temp and to allay GCC's concerns about possible int overflow.
1459 * frame.h (struct frame): Use int for menu_bar_items_used
1460 instead of EMACS_INT, since it always fits in int.
1461
1462 * menu.c (grow_menu_items): Check for int overflow.
1463
1464 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1465
1466 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1467 Before, the code was not consistent. These values cannot exceed
1468 2**31 - 1 so there's no need to make them unsigned.
1469 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1470 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1471 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1472 as modifiers.
1473 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1474
1475 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1476 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1477 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1478 presumably because the widths might not match.
1479
1480 * window.c (size_window): Avoid needless test at loop start.
1481
1482 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1483
1484 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1485
1486 2011-05-12 Drew Adams <drew.adams@oracle.com>
1487
1488 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1489
1490 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1491
1492 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1493 `width' to `bar_area_x' and `bar_area_width', respectively.
1494 (x_scroll_run): Take account of fringe background extension.
1495
1496 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1497 Rename local vars `left' and `width' to `bar_area_x' and
1498 `bar_area_width', respectively.
1499 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1500 background extension.
1501
1502 2011-05-10 Jim Meyering <meyering@redhat.com>
1503
1504 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1505
1506 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
1507
1508 * image.c (Finit_image_library): Return t for built-in image types,
1509 like pbm and xbm. (Bug#8640)
1510
1511 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1512
1513 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1514
1515 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1516
1517 * w32console.c (Fset_screen_color): Doc fix.
1518 (Fget_screen_color): New function.
1519 (syms_of_ntterm): Defsubr it.
1520
1521 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1522 unlink the temporary file if Fcall_process didn't create it in the
1523 first place.
1524 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1525 child process will be redirected to a file specified with `:file'.
1526 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1527 cue to call_process_cleanup not to close that handle.
1528
1529 2011-05-07 Ben Key <bkey76@gmail.com>
1530
1531 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1532 one of two shell specific rules, either bootstrap-temacs-CMD or
1533 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1534 to the previous implementation of the bootstrap-temacs rule.
1535 The bootstrap-temacs-CMD rule is similar to the previous
1536 implementation of the bootstrap-temacs rule except that it
1537 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1538 variable.
1539
1540 These changes, along with some changes to nt/configure.bat,
1541 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1542 earlier fix to add support for --cflags and --ldflags options
1543 that include quotes so that it works whether make uses cmd or
1544 sh as the shell.
1545
1546 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1547
1548 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1549 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1550 is a constant.
1551 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1552 a string. Handle both cases.
1553 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1554 (Fdbus_register_method): Use Qinvalid_function.
1555
1556 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1557
1558 * makefile.w32-in: Update dependencies.
1559 (LISP_H): Add inttypes.h and stdin.h.
1560 (PROCESS_H): Add unistd.h.
1561
1562 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1563
1564 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1565 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1566
1567 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1568
1569 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1570
1571 * term.c (vfatal): Remove stray call to va_end.
1572 It's not needed and the C Standard doesn't allow it here anyway.
1573
1574 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1575 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1576
1577 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1578 bytes.
1579
1580 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1581
1582 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1583
1584 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1585
1586 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1587
1588 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1589
1590 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1591 * charset.c (Fdefine_charset_internal): Don't initialize
1592 charset.code_space[15]. The value was garbage, on hosts with
1593 32-bit int (Bug#8600).
1594
1595 * lread.c (read_integer): Be more consistent with string-to-number.
1596 Use string_to_number to do the actual conversion; this avoids
1597 rounding errors and fixes some other screwups. Without this fix,
1598 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1599 (digit_to_number): Move earlier, for benefit of read_integer.
1600 Return -1 if the digit is out of range for the base, -2 if it is
1601 not a digit in any supported base. (Bug#8602)
1602
1603 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1604
1605 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1606 to match comment at start of function. This also removes a
1607 GCC warning about overflow in a 32+64-bit port.
1608
1609 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1610
1611 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1612 Reported by Stefan Monnier in
1613 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1614 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1615 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1616
1617 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1618 (EMACS_UINTPTR): Likewise, with uintptr_t.
1619
1620 * lisp.h: Prefer 64-bit EMACS_INT if available.
1621 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1622 on 32-bit hosts that have 64-bit int, so that they can access
1623 large files.
1624 However, temporarily disable this change unless the temporary
1625 symbol WIDE_EMACS_INT is defined.
1626
1627 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1628
1629 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1630 This removes an assumption that EMACS_INT and long are the same
1631 width as pointers. The assumption is true for Emacs porting targets
1632 now, but we want to make other targets possible.
1633 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1634 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1635 In the rest of the code, change types of integers that hold casted
1636 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1637 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1638 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1639 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1640 No need to cast type when ORing.
1641 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1642 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1643 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1644 assume EMACS_INT is the same width as char *.
1645 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1646 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1647 Remove no-longer-needed casts.
1648 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1649 (xg_tool_bar_help_callback, xg_make_tool_item):
1650 Use EMACS_INTPTR to hold an integer
1651 that will be cast to void *; this can avoid a GCC warning
1652 if EMACS_INT is not the same width as void *.
1653 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1654 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1655 (current_message_1, set_message_1):
1656 Use a local to convert to proper width without a cast.
1657 * xmenu.c (dialog_selection_callback): Likewise.
1658
1659 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1660 Also, don't assume VALBITS / RAND_BITS is less than 5,
1661 and don't rely on undefined behavior when shifting a 1 left into
1662 the sign bit.
1663 * lisp.h (get_random): Change signature to match.
1664
1665 * lread.c (hash_string): Use size_t, not int, for hash computation.
1666 Normally we prefer signed values; but hashing is special, because
1667 it's better to use unsigned division on hash table sizes so that
1668 the remainder is nonnegative. Also, size_t is the natural width
1669 for hashing into memory. The previous code used 'int', which doesn't
1670 retain enough info to hash well into very large tables.
1671 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1672
1673 * dbusbind.c: Don't possibly lose pointer info when converting.
1674 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1675 Use XPNTR rather than XHASH, so that the high-order bits of
1676 the pointer aren't lost when converting through void *.
1677
1678 * eval.c (Fautoload): Don't double-shift a pointer.
1679
1680 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1681
1682 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1683
1684 * gnutls.c (DEF_GNUTLS_FN):
1685 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1686
1687 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1688
1689 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1690 marker. (Bug#8610)
1691
1692 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1693
1694 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1695 New version that can reserve upto 2GB of heap space.
1696
1697 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1698
1699 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1700
1701 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1702
1703 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1704 `gnutls_certificate_set_x509_key_file'.
1705
1706 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1707
1708 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1709 Update dependencies.
1710
1711 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1712
1713 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1714 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1715 Remove unused parameter `fildes'.
1716 * process.c (read_process_output, send_process): Don't pass it.
1717
1718 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1719
1720 Fix previous change: the library cache is defined in w32.c.
1721 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1722 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1723
1724 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1725
1726 Implement dynamic loading of GnuTLS on Windows.
1727
1728 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1729 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1730 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1731 Declare.
1732
1733 * gnutls.c (Qgnutls_dll): Define.
1734 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1735 (gnutls_*): Declare function pointers.
1736 (init_gnutls_functions): New function to initialize function pointers.
1737 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1738 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1739 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1740 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1741 (emacs_gnutls_write, emacs_gnutls_read)
1742 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1743 (Fgnutls_available_p): New function.
1744 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1745 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1746 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1747
1748 * image.c: Include w32.h.
1749 (Vimage_type_cache): Delete.
1750 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1751 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1752 (w32_delayed_load): Move to w32.c.
1753
1754 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1755
1756 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1757 (w32_delayed_load): Move from image.c. When loading a library, record
1758 its filename in the :loaded-from property of the library id.
1759 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1760 Initialize and staticpro them.
1761 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1762
1763 * process.c: Include lisp.h before w32.h, not after.
1764 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1765 instead of gnutls_record_check_pending.
1766
1767 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1768
1769 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1770
1771 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1772 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1773 as passed in.
1774
1775 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1776
1777 * xterm.c (x_set_frame_alpha): Do not set property on anything
1778 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1779
1780 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1781
1782 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1783
1784 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1785
1786 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1787 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1788 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1789 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1790 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1791 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1792 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1793 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1794 (Qgnutls_bootprop_callbacks_verify): Make static.
1795
1796 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1797
1798 * callproc.c: Indentation fixup.
1799
1800 * sysdep.c (wait_for_termination_1): Make static.
1801 (wait_for_termination, interruptible_wait_for_termination):
1802 Move after wait_for_termination_1.
1803
1804 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1805
1806 * sysdep.c (interruptible_wait_for_termination): New function
1807 which is like wait_for_termination, but allows keyboard
1808 interruptions.
1809
1810 * callproc.c (Fcall_process): Add (:file "file") as an option for
1811 the STDOUT buffer.
1812 (Fcall_process_region): Ditto.
1813
1814 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1815
1816 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1817 rather than `XVECTOR (FOO)->size'.
1818
1819 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1820 inttypes.h, as a gnulib replacement is used if it not available in
1821 system headers.
1822
1823 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1824
1825 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1826 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1827 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1828
1829 * coding.c (coding_alloc_by_realloc): Error out if destination
1830 will grow beyond MOST_POSITIVE_FIXNUM.
1831 (decode_coding_emacs_mule): Abort if there isn't enough place in
1832 charbuf for the composition carryover bytes. Reserve an extra
1833 space for up to 2 characters produced in a loop.
1834 (decode_coding_iso_2022): Abort if there isn't enough place in
1835 charbuf for the composition carryover bytes.
1836
1837 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1838
1839 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1840 aborting when %lld or %lll format is passed.
1841 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1842 %llo or %llx format is passed. (Bug#8545)
1843
1844 * window.c (window_scroll_line_based): Use a marker instead of
1845 simple variables to record original value of point. (Bug#7952)
1846
1847 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1848 produced by %s or %c overflows available buffer space. (Bug#8545)
1849
1850 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1851
1852 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1853 (SIZE_MAX): Move defn after all includes, as they might #define it.
1854
1855 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1856
1857 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1858
1859 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1860
1861 * keyboard.c (Qdelayed_warnings_hook): Define.
1862 (command_loop_1): Run `delayed-warnings-hook'
1863 if Vdelayed_warnings_list is non-nil.
1864 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1865 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1866
1867 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1868
1869 * doprnt.c (doprnt): Don't return value smaller than the buffer
1870 size if the message was truncated. (Bug#8545).
1871
1872 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1873
1874 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1875 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1876
1877 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1878
1879 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1880
1881 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1882
1883 * makefile.w32-in: Update dependencies.
1884
1885 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1886
1887 Improve `doprnt' and its usage. (Bug#8545)
1888 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1889 `format_end'. Remove support for %l as a conversion specifier.
1890 Don't use xrealloc. Improve diagnostics when the %l size modifier
1891 is used. Update the commentary.
1892
1893 * eval.c (verror): Simplify calculation of size_t.
1894
1895 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1896 messages.
1897
1898 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1899
1900 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1901 change.
1902
1903 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1904
1905 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1906 This makes this file independent of the recent pseudovector change.
1907
1908 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1909
1910 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1911
1912 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1913 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1914 Remove unused local.
1915 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1916
1917 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1918 GCC 4.6.0 optimizes based on type-based alias analysis.
1919 For example, if b is of type struct buffer * and v of type struct
1920 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1921 != &v->size, and therefore "v->size = 1; b->size = 2; return
1922 v->size;" must therefore return 1. This assumption is incorrect
1923 for Emacs, since it type-puns struct Lisp_Vector * with many other
1924 types. To fix this problem, this patch adds a new type struct
1925 vectorlike_header that documents the constraints on layout of vectors
1926 and pseudovectors, and helps optimizing compilers not get fooled
1927 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1928 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1929 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1930 the size member.
1931 (XSETPVECTYPE): Rewrite in terms of new macro.
1932 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1933 This is a bit clearer, and further avoids the possibility of
1934 undesirable aliasing.
1935 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1936 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1937 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1938 since Lisp_Subr is a special case (no "next" field).
1939 (ASIZE): Now uses header.size rather than size.
1940 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1941 to avoid the hassle of writing XVECTOR (foo)->header.size.
1942 (struct vectorlike_header): New type.
1943 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1944 object, to help avoid aliasing.
1945 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1946 (SUBRP): Likewise, since Lisp_Subr is a special case.
1947 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1948 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1949 (struct Lisp_Hash_Table): Combine first two members into a single
1950 struct vectorlike_header member. All uses of "size" and "next" members
1951 changed to be "header.size" and "header.next".
1952 * buffer.h (struct buffer): Likewise.
1953 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1954 * frame.h (struct frame): Likewise.
1955 * process.h (struct Lisp_Process): Likewise.
1956 * termhooks.h (struct terminal): Likewise.
1957 * window.c (struct save_window_data, struct saved_window): Likewise.
1958 * window.h (struct window): Likewise.
1959 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1960 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1961 * buffer.c (init_buffer_once): Likewise.
1962 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1963 special case.
1964 * process.c (Fformat_network_address): Use local var for size,
1965 for brevity.
1966
1967 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1968
1969 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1970 * data.c (atof): Remove decl; no longer used or needed.
1971 (digit_to_number): Move to lread.c.
1972 (Fstring_to_number): Use new string_to_number function, to be
1973 consistent with how the Lisp reader treats infinities and NaNs.
1974 Do not assume that floating-point numbers represent EMACS_INT
1975 without losing information; this is not true on most 64-bit hosts.
1976 Avoid double-rounding errors, by insisting on integers when
1977 parsing non-base-10 numbers, as the documentation specifies.
1978 * lisp.h (string_to_number): New decl, replacing ...
1979 (isfloat_string): Remove.
1980 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1981 (read1): Do not accept +. and -. as integers; this
1982 appears to have been a coding error. Similarly, do not accept
1983 strings like +-1e0 as floating point numbers. Do not report
1984 overflow for integer overflows unless the base is not 10 which
1985 means we have no simple and reliable way to continue.
1986 Break out the floating-point parsing into a new
1987 function string_to_number, so that Fstring_to_number parses
1988 floating point numbers consistently with the Lisp reader.
1989 (digit_to_number): Move here from data.c. Make it static inline.
1990 (E_CHAR, EXP_INT): Remove, replacing with ...
1991 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1992 (string_to_number): New function, replacing isfloat_string.
1993 This function checks for valid syntax and produces the resulting
1994 Lisp float number too. Rework it so that string-to-number
1995 no longer mishandles examples like "1.0e+". Use strtoumax,
1996 so that overflow for non-base-10 numbers is reported only when
1997 there's no portable and simple way to convert to floating point.
1998
1999 * textprop.c (set_text_properties_1): Rewrite for clarity,
2000 and to avoid GCC warning about integer overflow.
2001
2002 * intervals.h (struct interval): Use EMACS_INT for members
2003 where EMACS_UINT might cause problems. See
2004 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2005 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2006 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2007 All uses changed.
2008 (offset_intervals): Tell GCC not to worry about length overflow
2009 when negating a negative length.
2010
2011 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2012 (overrun_check_free): Likewise.
2013
2014 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2015 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2016 word size.
2017
2018 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2019 (gnutls_make_error): Rename local to avoid shadowing.
2020 (gnutls_emacs_global_deinit): ifdef out; not used.
2021 (Fgnutls_boot): Use const for pointer to readonly storage.
2022 Comment out unused local. Fix pointer signedness problems.
2023
2024 * lread.c (openp): Don't stuff size_t into an 'int'.
2025 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2026 about possible signed overflow.
2027
2028 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2029 (GDK_KEY_g): Don't define if already defined.
2030 (xg_prepare_tooltip): Avoid pointer signedness problem.
2031 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2032
2033 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2034 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2035
2036 * xfns.c (Fx_window_property): Simplify a bit,
2037 to make a bit faster and to avoid GCC 4.6.0 warning.
2038 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2039
2040 * fns.c (internal_equal): Don't assume size_t fits in int.
2041
2042 * alloc.c (compact_small_strings): Tighten assertion a little.
2043
2044 Replace pEd with more-general pI, and fix some printf arg casts.
2045 * lisp.h (pI): New macro, generalizing old pEd macro to other
2046 conversion specifiers. For example, use "...%"pI"d..." rather
2047 than "...%"pEd"...".
2048 (pEd): Remove. All uses replaced with similar uses of pI.
2049 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2050 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2051 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2052 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2053 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2054 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2055 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2056 64-bit hosts.
2057 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2058 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2059 * print.c (safe_debug_print, print_object): Likewise.
2060 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2061 to int.
2062 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2063 avoiding the 0 flag, which is not portable.
2064 * process.c (Fmake_network_process): Use pI to avoid cast.
2065 * region-cache.c (pp_cache): Likewise.
2066 * xdisp.c (decode_mode_spec): Likewise.
2067 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2068 behavior on 64-bit hosts with printf arg.
2069 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2070 (x_stop_queuing_selection_requests): Likewise.
2071 (x_get_window_property): Don't truncate byte count to an 'int'
2072 when tracing.
2073
2074 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2075 here, since it parses constructs like leading '-' and spaces,
2076 which are not wanted; and it overflows with large numbers.
2077 Instead, simply match F[0-9]+, which is what is wanted anyway.
2078
2079 * alloc.c: Remove unportable assumptions about struct layout.
2080 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2081 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2082 (allocate_vectorlike, make_pure_vector): Use the new macros,
2083 plus offsetof, to remove unportable assumptions about struct layout.
2084 These assumptions hold on all porting targets that I know of, but
2085 they are not guaranteed, they're easy to remove, and removing them
2086 makes further changes easier.
2087
2088 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2089 This doesn't fix a bug but makes the code clearer.
2090 (string_overrun_cookie): Now const. Use initializers that
2091 don't formally overflow signed char, to avoid warnings.
2092 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2093 can cause Emacs to crash when string overrun checking is enabled.
2094 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2095 multiple of sizeof (EMACS_INT); it need not be, if
2096 alignof(EMACS_INT) < sizeof (EMACS_INT).
2097 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2098
2099 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2100
2101 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2102
2103 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2104
2105 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2106 supposed to be handshaking. (Bug#8556)
2107 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2108
2109 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2110
2111 * lisp.h (Qdebug): List symbol.
2112 * eval.c (Qdebug): Restore global linkage.
2113 * keyboard.c (debug-on-event): New variable.
2114 (handle_user_signal): Break into debugger when debug-on-event
2115 matches the current signal symbol.
2116
2117 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2118
2119 * alloc.c (check_sblock, check_string_bytes)
2120 (check_string_free_list): Convert to standard C.
2121
2122 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2123
2124 * w32.c (emacs_gnutls_push): Fix typo.
2125
2126 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2127
2128 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2129 "cast to pointer from integer of different size".
2130
2131 Improve doprnt and its use in verror. (Bug#8545)
2132 * doprnt.c (doprnt): Document the set of format control sequences
2133 supported by the function. Use SAFE_ALLOCA instead of always
2134 using `alloca'.
2135
2136 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2137 is one byte too soon. Don't use xrealloc; instead xfree and
2138 xmalloc anew.
2139
2140 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2141
2142 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2143 callbacks stage.
2144
2145 * gnutls.c: Renamed global_initialized to
2146 gnutls_global_initialized. Added internals for the
2147 :verify-hostname-error, :verify-error, and :verify-flags
2148 parameters of `gnutls-boot' and documented those parameters in the
2149 docstring. Start callback support.
2150 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2151 unless a fatal error occured. Call gnutls_alert_send_appropriate
2152 on error. Return error code.
2153 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2154 (emacs_gnutls_read): Likewise.
2155 (Fgnutls_boot): Return handshake error code.
2156 (emacs_gnutls_handle_error): New function.
2157 (wsaerror_to_errno): Likewise.
2158
2159 * w32.h (emacs_gnutls_pull): Add prototype.
2160 (emacs_gnutls_push): Likewise.
2161
2162 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2163 (emacs_gnutls_push): Likewise.
2164
2165 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2166
2167 * process.c (wait_reading_process_output): Check if GnuTLS
2168 buffered some data internally if no FDs are set for TLS
2169 connections.
2170
2171 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2172 (LIBS): Link to USER_LIBS.
2173 ($(BLD)/gnutls.$(0)): New target.
2174
2175 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2176
2177 * xdisp.c (handle_single_display_spec): Rename the
2178 display_replaced_before_p argument into display_replaced_p, to
2179 make it consistent with the commentary. Fix typos in the
2180 commentary.
2181
2182 * textprop.c (syms_of_textprop): Remove dead code.
2183 (copy_text_properties): Delete obsolete commentary about an
2184 interface that was deleted long ago. Fix typos in the description
2185 of arguments.
2186
2187 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2188 to changes in oldXMenu/XMenu.h from 2011-04-16.
2189 <menu_help_message, prev_menu_help_message>: Constify.
2190 (IT_menu_make_room): menu->help_text is now `const char **';
2191 adjust.
2192
2193 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2194 to changes in oldXMenu/XMenu.h from 2011-04-16.
2195 (struct XMenu): Declare `help_text' `const char **'.
2196
2197 * xfaces.c <Qunspecified>: Make extern again.
2198
2199 * syntax.c: Include sys/types.h before including regex.h, as
2200 required by Posix.
2201
2202 * doc.c (get_doc_string): Improve the format passed to `error'.
2203
2204 * doprnt.c (doprnt): Improve commentary.
2205
2206 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2207
2208 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2209 them with etags.
2210
2211 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2212 changes in globals.h immediately force recompilation.
2213 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2214 $(CURDIR)/s/ms-w32.h.
2215 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2216
2217 * character.c (Fchar_direction): Function deleted.
2218 (syms_of_character): Don't defsubr it.
2219 <char-direction-table>: Deleted.
2220
2221 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2222
2223 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2224 * doprnt.c: Include limits.h.
2225 (SIZE_MAX): New macro.
2226 (doprnt): Return a size_t value. 2nd arg is now size_t.
2227 Many local variables are now size_t instead of int or unsigned.
2228 Improve overflow protection. Support `l' modifier for integer
2229 conversions. Support %l conversion. Don't assume an EMACS_INT
2230 argument for integer conversions and for %c.
2231
2232 * lisp.h (doprnt): Restore prototype.
2233
2234 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2235 $(SRC)/character.h.
2236
2237 * Makefile.in (base_obj): Add back doprnt.o.
2238
2239 * deps.mk (doprnt.o): Add back prerequisites.
2240 (callint.o): Depend on character.h.
2241
2242 * eval.c (internal_lisp_condition_case): Include the handler
2243 representation in the error message.
2244 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2245 when breaking from the loop.
2246
2247 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2248
2249 * callint.c (Fcall_interactively): When displaying error message
2250 about invalid control letter, pass the character's codepoint, not
2251 a pointer to its multibyte form. Improve display of the character
2252 in octal and display also its hex code.
2253
2254 * character.c (char_string): Use %x to display the (unsigned)
2255 codepoint of an invalid character, to avoid displaying a bogus
2256 negative value.
2257
2258 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2259 `error', not SYMBOL_NAME itself.
2260
2261 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2262 character arguments to `error'.
2263
2264 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2265 to `error' in error message about FINAL_CHAR argument. Make sure
2266 FINAL_CHAR is a character, and use %c when it is passed as
2267 argument to `error'.
2268
2269 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2270
2271 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2272
2273 * w32.c: Include <time.h>.
2274 (sys_localtime): New function.
2275
2276 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2277
2278 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2279
2280 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2281
2282 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2283
2284 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2285 zombies (Bug#8467).
2286
2287 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2288
2289 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2290 gl_state.e_property when gl_state.object is Qt.
2291
2292 * insdel.c (make_gap_larger): Remove limitation of buffer size
2293 to <= INT_MAX.
2294
2295 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2296
2297 * xdisp.c (lookup_glyphless_char_display)
2298 (produce_glyphless_glyph): Handle cons cell entry in
2299 glyphless-char-display.
2300 (Vglyphless_char_display): Document it.
2301
2302 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2303 glyphless-char-display.
2304
2305 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2306
2307 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2308
2309 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2310
2311 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2312 definition for no-X builds.
2313
2314 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2315
2316 Static checks with GCC 4.6.0 and non-default toolkits.
2317
2318 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2319
2320 * process.c (keyboard_bit_set): Define only if SIGIO.
2321 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2322 (send_process): Repair possible setjmp clobbering.
2323
2324 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2325
2326 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2327
2328 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2329
2330 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2331 Define only if needed.
2332
2333 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2334 by pacifying GCC about it. Maybe it's time to retire it?
2335 * xfaces.c (USG, __TIMEVAL__): Likewise.
2336
2337 * dispextern.h (struct redisplay_interface): Rename param
2338 to avoid shadowing.
2339 * termhooks.h (struct terminal): Likewise.
2340 * xterm.c (xembed_send_message): Likewise.
2341
2342 * insdel.c (make_gap_smaller): Define only if
2343 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2344
2345 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2346 it.
2347
2348 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2349 so that we aren't warned about unused symbols.
2350
2351 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2352
2353 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2354
2355 * xfns.c (x_real_positions): Mark locals as initialized.
2356
2357 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2358
2359 * xterm.c: Fix problems found by static analysis with other toolkits.
2360 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2361 (x_dispatch_event): Declare static if USE_GTK, and
2362 define if USE_GTK || USE_X_TOOLKIT.
2363 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2364 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2365 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2366 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2367
2368 * xmenu.c (menu_help_callback): Pointer type fixes.
2369 Use const pointers when pointing at readonly data. Avoid pointer
2370 signedness clashes.
2371 (FALSE): Remove unused macro.
2372 (update_frame_menubar): Remove unused decl.
2373
2374 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2375
2376 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2377 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2378 (single_menu_item): Rename local to avoid shadowing.
2379
2380 * keyboard.c (make_lispy_event): Remove unused local var.
2381
2382 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2383 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2384
2385 * bitmaps: Change bitmaps from unsigned char back to the X11
2386 compatible char. Avoid the old compiler warnings about
2387 out-of-range initializers by using, for example, '\xab' rather
2388 than 0xab.
2389
2390 * xgselect.c (xgselect_initialize): Check vs interface
2391 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2392
2393 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2394
2395 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2396 to read-only memory.
2397
2398 * fns.c (vector): Remove; this old hack is no longer needed.
2399
2400 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2401 Remove unused var.
2402 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2403
2404 * xrdb.c (x_load_resources): Omit unused local.
2405
2406 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2407 (x_window): Rename locals to avoid shadowing.
2408 (USG): Use the kludged USG macro, to pacify gcc.
2409
2410 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2411 (x_term_init): Remove local to avoid shadowing.
2412
2413 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2414
2415 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2416 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2417
2418 2011-04-16 Eli Zaretskii <eliz@gnu.org>
2419
2420 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2421
2422 Fix regex.c, syntax.c and friends for buffers > 2GB.
2423 * syntax.h (struct gl_state_s): Declare character position members
2424 EMACS_INT.
2425
2426 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2427
2428 * textprop.c (verify_interval_modification, interval_of):
2429 Declare arguments EMACS_INT.
2430
2431 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2432 EMACS_INT.
2433
2434 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2435
2436 * indent.c (Fvertical_motion): Local variable it_start is now
2437 EMACS_INT.
2438
2439 * regex.c (re_match, re_match_2, re_match_2_internal)
2440 (bcmp_translate, regcomp, regexec, print_double_string)
2441 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2442 (re_compile_pattern, re_exec): Declare arguments and local
2443 variables `size_t' and `ssize_t' and return values `regoff_t', as
2444 appropriate.
2445 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2446 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2447 <compile_stack_type>: `size' and `avail' are now `size_t'.
2448
2449 * regex.h <regoff_t>: Use ssize_t, not int.
2450 (re_search, re_search_2, re_match, re_match_2): Arguments that
2451 specify buffer/string position and length are now ssize_t and
2452 size_t. Return type is regoff_t.
2453
2454 2011-04-16 Ben Key <bkey76@gmail.com>
2455
2456 * nsfont.m: Fixed bugs in ns_get_family and
2457 ns_descriptor_to_entity that were caused by using free to
2458 deallocate memory blocks that were allocated by xmalloc (via
2459 xstrdup). This caused Emacs to crash when compiled with
2460 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2461 --enable-checking=xmallocoverrun). xfree is now used to
2462 deallocate these memory blocks.
2463
2464 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
2465
2466 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2467
2468 emacs_write: Accept and return EMACS_INT for sizes.
2469 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2470 et seq.
2471 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2472 Accept and return EMACS_INT.
2473 (emacs_gnutls_write): Return the number of bytes written on
2474 partial writes.
2475 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
2476 (emacs_read, emacs_write): Remove check for negative size, as the
2477 Emacs source code has been audited now.
2478 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2479 (emacs_read, emacs_write): Use it.
2480 * process.c (send_process): Adjust to the new signatures of
2481 emacs_write and emacs_gnutls_write. Do not attempt to store
2482 a byte offset into an 'int'; it might overflow.
2483 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
2484
2485 * sound.c: Don't assume sizes fit in 'int'.
2486 (struct sound_device.period_size, alsa_period_size):
2487 Return EMACS_INT, not int.
2488 (struct sound_device.write, vox_write, alsa_write):
2489 Accept EMACS_INT, not int.
2490 (wav_play, au_play): Use EMACS_INT to store sizes and to
2491 record read return values.
2492
2493 2011-04-15 Ben Key <bkey76@gmail.com>
2494
2495 * keyboard.c (Qundefined): Don't declare static since it is used
2496 in nsfns.m.
2497 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2498 static since they are used in nsfont.m.
2499
2500 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2501
2502 * process.c (Qprocessp): Don't declare static.
2503 * lisp.h (Qprocessp): Declare again.
2504
2505 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
2506
2507 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2508
2509 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2510
2511 Improve C-level modularity by making more things 'static'.
2512
2513 Don't publish debugger-only interfaces to other modules.
2514 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2515 (verify_bytepos, count_markers): Move decls to the only modules
2516 that need them.
2517 * region-cache.h (pp_cache): Likewise.
2518 * window.h (check_all_windows): Likewise.
2519 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2520
2521 * sysdep.c (croak): Now static, if
2522 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2523 * syssignal.h (croak): Declare only if not static.
2524
2525 * alloc.c (refill_memory_reserve): Now static if
2526 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2527 * lisp.h (refill_memory_reserve): Declare only if not static.
2528
2529 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2530 Define only if USE_LUCID.
2531
2532 * xrdb.c (x_customization_string, x_rm_string): Now static.
2533
2534 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2535 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2536
2537 * xdisp.c (draw_row_with_mouse_face): Now static.
2538 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2539
2540 * window.h (check_all_windows): Mark externally visible.
2541
2542 * window.c (window_deletion_count): Now static.
2543
2544 * undo.c: Make symbols static if they're not exported.
2545 (last_undo_buffer, last_boundary_position, pending_boundary):
2546 Now static.
2547
2548 * textprop.c (interval_insert_behind_hooks): Now static.
2549 (interval_insert_in_front_hooks): Likewise.
2550
2551 * term.c: Make symbols static if they're not exported.
2552 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2553 (max_frame_lines, tty_set_terminal_modes):
2554 (tty_reset_terminal_modes, tty_turn_off_highlight):
2555 (get_tty_terminal): Now static.
2556 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2557 * termhooks.h (term_mouse_moveto): Do not declare if
2558 HAVE_WINDOW_SYSTEM.
2559 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2560 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2561
2562 * sysdep.c: Make symbols static if they're not exported.
2563 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2564 Now static.
2565 (sigprocmask_set, full_mask): Remove; unused.
2566 (wait_debugging): Mark as visible.
2567 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2568 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2569
2570 * syntax.c (syntax_temp): Define only if !__GNUC__.
2571
2572 * sound.c (current_sound_device, current_sound): Now static.
2573
2574 * search.c (searchbufs, searchbuf_head): Now static.
2575
2576 * scroll.c (scroll_cost): Remove; unused.
2577 * dispextern.h (scroll_cost): Remove decl.
2578
2579 * region-cache.h (pp_cache): Mark as externally visible.
2580
2581 * process.c: Make symbols static if they're not exported.
2582 (process_tick, update_tick, create_process, chan_process):
2583 (Vprocess_alist, proc_buffered_char, datagram_access):
2584 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2585 (deactivate_process): Mark defn as static, as well as decl.
2586 * lisp.h (create_process): Remove decl.
2587 * process.h (chan_process, Vprocess_alist): Remove decls.
2588
2589 * print.c: Make symbols static if they're not exported.
2590 (print_depth, new_backquote_output, being_printed, print_buffer):
2591 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2592 (print_interval, print_number_index, initial_stderr_stream):
2593 Now static.
2594 * lisp.h (Fprinc): Remove decl.
2595 (debug_output_compilation_hack): Mark as externally visible.
2596
2597 * sysdep.c (croak): Move decl from here to syssignal.h.
2598 * syssignal.h (croak): Put it here, so the API can be checked when
2599 'croak' is called from dissociate_if_controlling_tty.
2600
2601 * minibuf.c: Make symbols static if they're not exported.
2602 (minibuf_save_list, choose_minibuf_frame): Now static.
2603 * lisp.h (choose_minibuf_frame): Remove decl.
2604
2605 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2606
2607 * lread.c: Make symbols static if they're not exported.
2608 (read_objects, initial_obarray, oblookup_last_bucket_number):
2609 Now static.
2610 (make_symbol): Remove; unused.
2611 * lisp.h (initial_obarray, make_symbol): Remove decls.
2612
2613 * keyboard.c: Make symbols static if they're not exported.
2614 (single_kboard, recent_keys_index, total_keys, recent_keys):
2615 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2616 (this_single_command_key_start, echoing, last_auto_save):
2617 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2618 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2619 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2620 (Vlispy_mouse_stem, double_click_count):
2621 Now static.
2622 (force_auto_save_soon): Define only if SIGDANGER.
2623 (ignore_mouse_drag_p): Now static if
2624 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2625 (print_help): Remove; unused.
2626 (stop_character, last_timer_event): Mark as externally visible.
2627 * keyboard.h (ignore_mouse_drag_p): Declare only if
2628 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2629 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2630 * lisp.h (echoing): Remove decl.
2631 (force_auto_save_soon): Declare only if SIGDANGER.
2632 * xdisp.c (redisplay_window): Simplify code, to make it more
2633 obvious that ignore_mouse_drag_p is not accessed if !defined
2634 USE_GTK && !defined HAVE_NS.
2635
2636 * intervals.c: Make symbols static if they're not exported.
2637 (merge_properties_sticky, merge_interval_right, delete_interval):
2638 Now static.
2639 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2640
2641 * insdel.c: Make symbols static if they're not exported.
2642 However, leave prepare_to_modify_buffer alone. It's never
2643 called from outside this function, but that appears to be a bug.
2644 (combine_after_change_list, combine_after_change_buffer):
2645 (adjust_after_replace, signal_before_change): Now static.
2646 (adjust_after_replace_noundo): Remove; unused.
2647 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2648 (signal_before_change): Remove decls.
2649
2650 * indent.c (val_compute_motion, val_vmotion): Now static.
2651
2652 * image.c: Make symbols static if they're not exported.
2653 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2654 if USE_GTK.
2655 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2656 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2657
2658 * fringe.c (standard_bitmaps): Now static.
2659 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2660
2661 * frame.c: Make symbols static if they're not exported.
2662 (x_report_frame_params, make_terminal_frame): Now static.
2663 (get_frame_param): Now static, unless HAVE_NS.
2664 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2665 (x_get_resource_string): Remove; not used.
2666 * frame.h (make_terminal_frame, x_report_frame_params):
2667 (x_get_resource_string); Remove decls.
2668 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2669 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2670
2671 * font.c, fontset.c: Make symbols static if they're not exported.
2672 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2673 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2674 * font.c (font_close_object): Now static.
2675 * font.h (font_close_object): Remove.
2676 * fontset.c (FONTSET_OBJLIST): Remove.
2677 (free_realized_fontset) #if-0 the body, which does nothing.
2678 (face_suitable_for_char_p): #if-0, as it's never called.
2679 * fontset.h (face_suitable_for_char_p): Remove decl.
2680 * xfaces.c (face_at_string_position):
2681 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2682 since 0 is always ASCII.
2683
2684 * fns.c (weak_hash_tables): Now static.
2685
2686 * fileio.c: Make symbols static if they're not exported.
2687 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2688 (Vwrite_region_annotation_buffers): Now static.
2689
2690 * eval.c: Make symbols static if they're not exported.
2691 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2692 * lisp.h (backtrace_list): Remove decl.
2693
2694 * emacs.c: Make symbols static if they're not exported.
2695 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2696 (fatal_error_code, fatal_error_signal_hook, standard_args):
2697 Now static.
2698 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2699 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2700 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2701 * lisp.h (fatal_error_signal_hook): Remove decl.
2702 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2703
2704 * editfns.c: Move a (normally-unused) function to its only use.
2705 * editfns.c, lisp.h (get_operating_system_release): Remove.
2706 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2707 worth the hassle of breaking this out.
2708
2709 * xterm.c: Make symbols static if they're not exported.
2710 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2711 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2712 (x_destroy_window, x_delete_display):
2713 Now static.
2714 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2715 (x_mouse_leave): Remove; unused.
2716 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2717 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2718 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2719 Remove decls.
2720 (x_mouse_leave): Declare only if WINDOWSNT.
2721 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2722 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2723 USE_X_TOOLKIT.
2724
2725 * ftxfont.c: Make symbols static if they're not exported.
2726 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2727 HAVE_FREETYPE.
2728 * font.h (ftxfont_driver): Likewise.
2729
2730 * xfns.c: Make symbols static if they're not exported.
2731 (x_last_font_name, x_display_info_for_name):
2732 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2733 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2734 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2735 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2736 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2737 (last_show_tip_args): Now static.
2738 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2739 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2740 (x_screen_planes): Remove; unused.
2741 * dispextern.h (x_screen_planes): Remove decl.
2742
2743 * dispnew.c: Make symbols static if they're not exported.
2744 * dispextern.h (redraw_garbaged_frames, scrolling):
2745 (increment_row_positions): Remove.
2746 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2747 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2748 Now static.
2749 (redraw_garbaged_frames): Remove; unused.
2750
2751 * xfaces.c: Make symbols static if they're not exported.
2752 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2753 Remove decls.
2754 * xterm.h (defined_color): Remove decls.
2755 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2756 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2757 (menu_face_changed_default, defined_color, free_realized_face):
2758 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2759 (ascii_face_of_lisp_face): Remove; unused.
2760
2761 * xdisp.c: Make symbols static if they're not exported.
2762 * dispextern.h (scratch_glyph_row, window_box_edges):
2763 (glyph_to_pixel_coords, set_cursor_from_row):
2764 (get_next_display_element, set_iterator_to_next):
2765 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2766 (show_mouse_face): Remove decls
2767 * frame.h (message_buf_print): Likewise.
2768 * lisp.h (pop_message, set_message, check_point_in_composition):
2769 Likewise.
2770 * xterm.h (set_vertical_scroll_bar): Likewise.
2771 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2772 (message_buf_print, scratch_glyph_row, displayed_buffer):
2773 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2774 (get_next_display_element, show_mouse_face, window_box_edges):
2775 (frame_to_window_pixel_xy, check_point_in_composition):
2776 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2777 (glyph_to_pixel_coords): Remove; unused.
2778
2779 * dired.c (file_name_completion): Now static.
2780
2781 * dbusbind.c (xd_in_read_queued_messages): Now static.
2782
2783 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2784 * data.c (circular_list_error): Remove.
2785
2786 * commands.h (last_point_position, last_point_position_buffer):
2787 (last_point_position_window): Remove decls.
2788 * keyboard.c: Make these variables static.
2789
2790 * coding.h (coding, code_convert_region, encode_coding_gap):
2791 Remove decls.
2792 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2793 (iso_code_class, detect_coding, code_convert_region): Now static.
2794 (encode_coding_gap): Remove; unused.
2795
2796 * chartab.c (chartab_chars, chartab_bits): Now static.
2797
2798 * charset.h (charset_iso_8859_1): Remove decl.
2799 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2800 Now static.
2801
2802 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2803 * ccl.c (Vccl_program_table): Now static.
2804 (check_ccl_update): Remove; unused.
2805
2806 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2807 * category.h: ... from here.
2808 * category.c (check_category_table, set_category_set): Now static.
2809
2810 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2811 * lisp.h: Remove these decls.
2812
2813 * buffer.c (buffer_count): Remove unused var.
2814
2815 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2816 so that it's not optimized away.
2817 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2818 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2819 exported only to the debugger.
2820
2821 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2822 * atimer.h (run_all_atimers): Remove; not exported.
2823
2824 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2825 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2826 was inaccessible from Lisp.
2827 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2828 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2829
2830 alloc.c: Import and export fewer symbols, and remove unused items.
2831 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2832 is defined.
2833 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2834 it's not optimized away by whole-program optimization.
2835 (message_enable_multibyte, free_misc): Remove.
2836 (catchlist, handlerlist, mark_backtrace):
2837 Declare only if BYTE_MARK_STACK.
2838 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2839 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2840 (message_enable_multibyte): Remove decl.
2841 (free_misc, interval_free_list, float_block, float_block_index):
2842 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2843 (cons_free_list, last_marked_index):
2844 Now static.
2845 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2846 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2847 (mark_backtrace): Define only if BYTE_MARK_STACK.
2848 * xdisp.c (message_enable_multibyte): Now static.
2849
2850 Declare Lisp_Object Q* variables to be 'static' if not exported.
2851 This makes it easier for human readers (and static analyzers)
2852 to see whether these variables are used from other modules.
2853 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2854 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2855 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2856 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2857 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2858 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2859 * xmenu.c, xselect.c:
2860 Declare Q* vars static if they are not used in other modules.
2861 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2862 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2863 Remove decls of unexported vars.
2864 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2865
2866 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2867
2868 Make Emacs functions such as Fatom 'static' by default.
2869 This makes it easier for human readers (and static analyzers)
2870 to see whether these functions can be called from other modules.
2871 DEFUN now defines a static function. To make the function external
2872 so that it can be used in other C modules, use the new macro DEFUE.
2873 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2874 (Finit_image_library):
2875 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2876 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2877 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2878 Remove decls, since these functions are now static.
2879 (Funintern, Fget_internal_run_time): New decls, since these functions
2880 were already external.
2881
2882 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2883 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2884 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2885 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2886 * keyboard.c, keymap.c, lread.c:
2887 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2888 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2889 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2890 Mark functions with DEFUE instead of DEFUN,
2891 if they are used in other modules.
2892 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2893 decls for now-static functions.
2894 * buffer.h (Fdelete_overlay): Remove decl.
2895 * callproc.c (Fgetenv_internal): Mark as internal.
2896 * composite.c (Fremove_list_of_text_properties): Remove decl.
2897 (Fcomposition_get_gstring): New forward static decl.
2898 * composite.h (Fcomposite_get_gstring): Remove decl.
2899 * dired.c (Ffile_attributes): New forward static decl.
2900 * doc.c (Fdocumntation_property): New forward static decl.
2901 * eval.c (Ffetch_bytecode): New forward static decl.
2902 (Funintern): Remove extern decl; now in .h file where it belongs.
2903 * fileio.c (Fmake_symbolic_link): New forward static decl.
2904 * image.c (Finit_image_library): New forward static decl.
2905 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2906 * intervals.h (Fprevious_property_change):
2907 (Fremove_list_of_text_properties): Remove decls.
2908 * keyboard.c (Fthis_command_keys): Remove decl.
2909 (Fcommand_execute): New forward static decl.
2910 * keymap.c (Flookup_key): New forward static decl.
2911 (Fcopy_keymap): Now static.
2912 * keymap.h (Flookup_key): Remove decl.
2913 * process.c (Fget_process): New forward static decl.
2914 (Fprocess_datagram_address): Mark as internal.
2915 * syntax.c (Fsyntax_table_p): New forward static decl.
2916 (skip_chars): Remove duplicate decl.
2917 * textprop.c (Fprevious_property_change): New forward static decl.
2918 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2919 Now internal.
2920 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2921 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2922
2923 * editfns.c (Fformat): Remove unreachable code.
2924
2925 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2926
2927 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2928 change. (Bug#8496)
2929
2930 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2931
2932 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2933 when at ZV. (Bug#8487)
2934
2935 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2936
2937 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2938 (Bug#8437)
2939 * keyboard.c (parse_tool_bar_item): Likewise.
2940 * sound.c (sound_cleanup, alsa_close): Likewise.
2941 * termcap.c (tgetent): Likewise.
2942 * xfns.c (x_default_font_parameter): Likewise.
2943 * xsettings.c (read_and_apply_settings): Likewise.
2944
2945 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2946 (overrun_check_free): Protoize.
2947
2948 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2949
2950 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2951 since callers should never pass a negative size.
2952 Change the signature to match that of plain 'read' and 'write'; see
2953 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2954 * lisp.h: Update prototypes of emacs_write and emacs_read.
2955
2956 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2957
2958 * xdisp.c (redisplay_window): Don't try to determine the character
2959 position of the scroll margin if the window start point w->startp
2960 is outside the buffer's accessible region. (Bug#8468)
2961
2962 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2963
2964 Fix write-region and its subroutines for buffers > 2GB.
2965 * fileio.c (a_write, e_write): Modify declaration of arguments and
2966 local variables to support buffers larger than 2GB.
2967 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2968
2969 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2970 argument, local variables, and return value.
2971
2972 * lisp.h: Update prototypes of emacs_write and emacs_read.
2973
2974 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2975
2976 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2977
2978 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2979
2980 Fix more problems found by GCC 4.6.0's static checks.
2981
2982 * xdisp.c (vmessage): Use a better test for character truncation.
2983
2984 * charset.c (load_charset_map): <, not <=, for optimization,
2985 and to avoid potential problems with integer overflow.
2986 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2987 * casetab.c (set_identity, shuffle): Likewise.
2988 * editfns.c (Fformat): Likewise.
2989 * syntax.c (skip_chars): Likewise.
2990
2991 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2992 This also lets GCC 4.6.0 generate slightly better loop code.
2993
2994 * callint.c (Fcall_interactively): <, not <=, for optimization.
2995 (Fcall_interactively): Count the number of arguments produced,
2996 not the number of arguments given. This is simpler and lets GCC
2997 4.6.0 generate slightly better code.
2998
2999 * ftfont.c: Distingish more carefully between FcChar8 and char.
3000 The previous code passed unsigned char * to a functions like
3001 strlen and xstrcasecmp that expect char *, which does not
3002 conform to the C standard.
3003 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3004 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3005 char * when the C standard requires it.
3006
3007 * keyboard.c (read_char): Remove unused var.
3008
3009 * eval.c: Port to Windows vsnprintf (Bug#8435).
3010 Include <limits.h>.
3011 (SIZE_MAX): Define if the headers do not.
3012 (verror): Do not give up if vsnprintf returns a negative count.
3013 Instead, grow the buffer. This ports to Windows vsnprintf, which
3014 does not conform to C99. Problem reported by Eli Zaretskii.
3015 Also, simplify the allocation scheme, by avoiding the need for
3016 calling realloc, and removing the ALLOCATED variable.
3017
3018 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3019
3020 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3021 But keep the doprint source code for now, as we might revamp it
3022 and use it again (Bug#8435).
3023 * lisp.h (doprnt): Remove.
3024 * Makefile.in (base_obj): Remove doprnt.o.
3025 * deps.mk (doprnt.o): Remove.
3026
3027 error: Print 32- and 64-bit integers portably (Bug#8435).
3028 Without this change, on typical 64-bit hosts error ("...%d...", N)
3029 was used to print both 32- and 64-bit integers N, which relied on
3030 undefined behavior.
3031 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3032 New macro.
3033 * lisp.h (error, verror): Mark as printf-like functions.
3034 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3035 Report overflow in size calculations when allocating printf buffer.
3036 Do not truncate output string at its first null byte.
3037 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3038 Truncate the output at a character boundary, since vsnprintf does not
3039 do that.
3040 * charset.c (check_iso_charset_parameter): Convert internal
3041 character to string before calling 'error', since %c now has the
3042 printf meaning.
3043 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3044 overflow when computing char to be passed to 'error'. Do not
3045 pass Lisp_Object to 'error'; pass the integer instead.
3046 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3047 formatted with plain %d.
3048
3049 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3050
3051 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3052
3053 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3054
3055 * xterm.c (x_catch_errors): Remove duplicate declaration.
3056
3057 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3058
3059 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3060
3061 2011-04-10 Jim Meyering <meyering@redhat.com>
3062
3063 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3064 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3065 return ssize_t not "int", and use size_t as the buffer length.
3066 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3067 * gnutls.h: Update declarations.
3068 * process.c (read_process_output): Use ssize_t, to match.
3069 (send_process): Likewise.
3070
3071 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3072
3073 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3074
3075 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3076
3077 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3078 Use unsigned char, to match FcChar8 type definition.
3079
3080 * xterm.c (handle_one_xevent):
3081 * xmenu.c (create_and_show_popup_menu):
3082 * xselect.c (x_decline_selection_request)
3083 (x_reply_selection_request): Avoid type-punned deref of X events.
3084
3085 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3086
3087 Fix some uses of `int' instead of EMACS_INT.
3088 * search.c (string_match_1, fast_string_match)
3089 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3090 (scan_buffer, find_next_newline_no_quit)
3091 (find_before_next_newline, search_command, Freplace_match)
3092 (Fmatch_data): Make some `int' variables be EMACS_INT.
3093
3094 * xdisp.c (display_count_lines): 3rd argument and return value now
3095 EMACS_INT. All callers changed.
3096 (pint2hrstr): Last argument is now EMACS_INT.
3097
3098 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3099 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3100 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3101 (decode_coding_utf_16, decode_coding_emacs_mule)
3102 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3103 (decode_coding_ccl, decode_coding_charset)
3104 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3105 (decode_coding_iso_2022, decode_coding_emacs_mule)
3106 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3107 <char_offset, last_offset>: Declare EMACS_INT.
3108 (encode_coding_utf_8, encode_coding_utf_16)
3109 (encode_coding_emacs_mule, encode_invocation_designation)
3110 (encode_designation_at_bol, encode_coding_iso_2022)
3111 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3112 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3113 Declare EMACS_INT.
3114 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3115 (encode_invocation_designation): Last argument P_NCHARS is now
3116 EMACS_INT.
3117 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3118 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3119
3120 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3121 All users changed.
3122
3123 * ccl.c (Fccl_execute_on_string): Declare some variables
3124 EMACS_INT.
3125
3126 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3127
3128 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3129
3130 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3131
3132 * process.c (Fformat_network_address): Doc fix.
3133
3134 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3135
3136 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3137
3138 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3139
3140 * keyboard.c (read_char): Call Lisp function help-form-show,
3141 instead of using internal_with_output_to_temp_buffer.
3142 (Qhelp_form_show): New var.
3143 (syms_of_keyboard): Use DEFSYM macro.
3144
3145 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3146
3147 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3148
3149 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3150
3151 * process.c (Flist_processes): Remove to Lisp.
3152 (list_processes_1): Delete.
3153
3154 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3155
3156 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3157
3158 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3159
3160 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3161
3162 Fix more problems found by GCC 4.6.0's static checks.
3163
3164 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3165
3166 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3167
3168 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3169
3170 * xdisp.c (vmessage): Mark as a printf-like function.
3171
3172 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3173
3174 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3175
3176 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3177 printf-like functions.
3178 (tiff_load): Add casts to remove these marks before passing them
3179 to system-supplied API.
3180
3181 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3182
3183 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3184 This avoids several warnings with gcc -Wstrict-overflow.
3185 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3186 directly, rather than having caller test rule sign. This avoids
3187 some unnecessary tests.
3188 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3189 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3190 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3191
3192 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3193 (xfont_open): Avoid unnecessary tests.
3194
3195 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3196
3197 * composite.h, composite.c (composition_gstring_put_cache):
3198 Use EMACS_INT, not int, for length.
3199
3200 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3201 breaking out part of COMPOSITION_DECODE_RULE.
3202 (COMPOSITION_DECODE_RULE): Use it.
3203 * composite.c (get_composition_id): Remove unused local vars,
3204 by using the new macro.
3205
3206 * textprop.c (set_text_properties_1): Change while to do-while,
3207 since the condition is always true at first.
3208
3209 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3210 (interval_deletion_adjustment): Return unsigned value.
3211 All uses changed.
3212
3213 * process.c (list_processes_1, create_pty, read_process_output):
3214 (exec_sentinel): Remove vars that were set but not used.
3215 (create_pty): Remove unnecessary "volatile"s.
3216 (Fnetwork_interface_info): Avoid possibility of int overflow.
3217 (read_process_output): Do adaptive read buffering even if carryover.
3218 (read_process_output): Simplify nbytes computation if buffered.
3219
3220 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3221
3222 * syntax.c (scan_words): Remove var that was set but not used.
3223 (update_syntax_table): Use unsigned instead of int.
3224
3225 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3226 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3227 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3228
3229 * print.c (print_error_message): Avoid int overflow.
3230
3231 * font.c (font_list_entities): Redo for clarity,
3232 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3233
3234 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3235 (font_score): Avoid potential overflow in diff calculation.
3236
3237 * fns.c (substring_both): Remove var that is set but not used.
3238 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3239
3240 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3241
3242 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3243 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3244 can always succeed if overflow has undefined behavior.
3245
3246 * search.c (boyer_moore, wordify): Remove vars set but not used.
3247 (wordify): Omit three unnecessary tests.
3248
3249 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3250 All callers changed. This avoids the need for an unused var.
3251
3252 * casefiddle.c (casify_region): Remove var that is set but not used.
3253
3254 * dired.c (file_name_completion): Remove var that is set but not used.
3255
3256 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3257
3258 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3259 (Finsert_file_contents): Remove unnecessary code checking fd.
3260
3261 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3262 Check for integer overflow on size calculations.
3263
3264 * buffer.c (Fprevious_overlay_change): Remove var that is set
3265 but not used.
3266
3267 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3268 Remove vars that are set but not used.
3269 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3270 (timer_check_2): Mark vars as initialized.
3271
3272 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3273
3274 * image.c (lookup_image): Remove var that is set but not used.
3275 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3276
3277 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3278 that are set but not used.
3279
3280 * xfns.c (make_invisible_cursor): Don't return garbage
3281 if XCreateBitmapFromData fails (Bug#8410).
3282
3283 * xselect.c (x_get_local_selection, x_handle_property_notify):
3284 Remove vars that are set but not used.
3285
3286 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3287 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3288
3289 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3290 Remove var that is set but not used.
3291 (scroll_bar_windows_size): Now size_t, not int.
3292 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3293 Check for overflow.
3294
3295 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3296 (map_tty_color) [!defined MSDOS]: Likewise.
3297
3298 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3299
3300 * coding.c: Remove vars that are set but not used.
3301 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3302 All callers changed.
3303 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3304 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3305 (decode_coding_charset): Remove vars that are set but not used.
3306
3307 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3308 that is set but not used.
3309
3310 * print.c (print_object): Remove var that is set but not used.
3311
3312 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3313 The gnulib version avoids calling malloc in the usual case,
3314 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3315 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3316 * filelock.c (current_lock_owner): Likewise.
3317 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3318 * sysdep.c: Include allocator.h, careadlinkat.h.
3319 (emacs_no_realloc_allocator): New static constant.
3320 (emacs_readlink): New function.
3321 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3322 ../lib/careadlinkat.h.
3323
3324 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3325
3326 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3327 first non-nil return value).
3328
3329 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3330
3331 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3332 if not defined (Bug#8403).
3333
3334 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3335
3336 * xdisp.c (display_count_lines): Remove parameter `start',
3337 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3338 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3339 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3340 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3341 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3342 and thereabouts. All callers changed.
3343 (get_per_char_metric): Remove parameter `f', unused since
3344 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3345
3346 2011-04-02 Jim Meyering <meyering@redhat.com>
3347
3348 do not dereference NULL upon failed strdup
3349 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3350 (ns_get_family): Likewise.
3351
3352 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3353
3354 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3355
3356 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3357
3358 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3359 later (Bug#8403).
3360
3361 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3362
3363 Add lexical binding.
3364
3365 * window.c (Ftemp_output_buffer_show): New fun.
3366 (Fsave_window_excursion):
3367 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3368
3369 * lread.c (lisp_file_lexically_bound_p): New function.
3370 (Fload): Bind Qlexical_binding.
3371 (readevalloop): Remove `evalfun' arg.
3372 Bind Qinternal_interpreter_environment.
3373 (Feval_buffer): Bind Qlexical_binding.
3374 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3375 Mark as dynamic.
3376 (syms_of_lread): Declare `lexical-binding'.
3377
3378 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3379
3380 * keyboard.c (eval_dyn): New fun.
3381 (menu_item_eval_property): Use it.
3382
3383 * image.c (parse_image_spec): Use Ffunctionp.
3384
3385 * fns.c (concat, mapcar1): Accept byte-code-functions.
3386
3387 * eval.c (Fsetq): Handle lexical vars.
3388 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3389 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3390 (FletX, Flet): Obey lexical binding.
3391 (Fcommandp): Handle closures.
3392 (Feval): New `lexical' arg.
3393 (eval_sub): New function extracted from Feval. Use it almost
3394 everywhere where Feval was used. Look up vars in lexical env.
3395 Handle closures.
3396 (Ffunctionp): Move from subr.el.
3397 (Ffuncall): Handle closures.
3398 (apply_lambda): Remove `eval_flags'.
3399 (funcall_lambda): Handle closures and new byte-code-functions.
3400 (Fspecial_variable_p): New function.
3401 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3402 but without exporting it to Lisp.
3403
3404 * doc.c (Fdocumentation, store_function_docstring):
3405 * data.c (Finteractive_form): Handle closures.
3406
3407 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3408 interactive spec.
3409
3410 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3411 New byte-codes.
3412 (exec_byte_code): New function extracted from Fbyte_code to handle new
3413 calling convention for byte-code-functions. Add new byte-codes.
3414
3415 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3416
3417 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3418
3419 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3420
3421 * xdisp.c (redisplay_internal): Fix prototype.
3422
3423 2011-03-31 Eli Zaretskii <eliz@gnu.org>
3424
3425 * xdisp.c (SCROLL_LIMIT): New macro.
3426 (try_scrolling): Use it when setting scroll_limit.
3427 Limit scrolling to 100 screen lines.
3428 (redisplay_window): Even when falling back on "recentering",
3429 position point in the window according to scroll-conservatively,
3430 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3431
3432 (try_scrolling): When point is above the window, allow searching
3433 as far as scroll_max, or one screenful, to compute vertical
3434 distance from PT to the scroll margin position. This prevents
3435 try_scrolling from unnecessarily failing when
3436 scroll-conservatively is set to a value slightly larger than the
3437 window height. Clean up the case of PT below the margin at bottom
3438 of window: scroll_max can no longer be INT_MAX. When aggressive
3439 scrolling is in use, don't let point enter the opposite scroll
3440 margin as result of the scroll.
3441 (syms_of_xdisp) <scroll-conservatively>: Document the
3442 threshold of 100 lines for never-recentering scrolling.
3443
3444 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3445
3446 * dispextern.h (move_it_by_lines):
3447 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3448 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3449 (message_log_check_duplicate): Remove parameters `prev_bol' and
3450 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3451 (redisplay_internal): Remove parameter `preserve_echo_area',
3452 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3453
3454 * indent.c (Fvertical_motion):
3455 * window.c (window_scroll_pixel_based, Frecenter):
3456 Don't pass `need_y_p' to `move_it_by_lines'.
3457
3458 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3459
3460 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3461 steal a few bits to be more compact.
3462 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3463 Remove unneeded casts.
3464
3465 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3466
3467 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3468
3469 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3470 binding" message (bug#7967).
3471
3472 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3473
3474 Fix more problems found by GCC 4.6.0's static checks.
3475
3476 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3477 Remove unused local var.
3478
3479 * editfns.c (Fmessage_box): Remove unused local var.
3480
3481 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3482 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3483 Omit unused local vars.
3484 * window.c (shrink_windows): Omit unused local var.
3485 * menu.c (digest_single_submenu): Omit unused local var.
3486 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3487 Omit unused local var.
3488
3489 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3490 Don't assume string length fits in int.
3491 (keyremap_step, read_key_sequence): Use size_t for sizes.
3492 (read_key_sequence): Don't check last_real_key_start redundantly.
3493
3494 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3495 instead of alloca (Bug#8344).
3496
3497 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3498 (Fbacktrace_frame): Don't assume nframes fits in int.
3499
3500 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3501
3502 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3503 concerns.
3504
3505 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3506
3507 * cm.c (calccost): Turn while-do into do-while, for clarity.
3508
3509 * keyboard.c (syms_of_keyboard): Use the same style as later
3510 in this function when indexing through an array. This also
3511 works around GCC bug 48267.
3512
3513 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3514
3515 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3516
3517 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3518 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3519
3520 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3521 This avoids undefined behavior on integer overflow, and is a bit
3522 more convenient anyway since it is compared to a size_t variable.
3523
3524 Variadic C functions now count arguments with size_t, not int.
3525 This avoids an unnecessary limitation on 64-bit machines, which
3526 caused (substring ...) to crash on large vectors (Bug#8344).
3527 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3528 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3529 All variadic functions and their callers changed accordingly.
3530 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3531 * data.c (arith_driver, float_arith_driver): Likewise.
3532 * editfns.c (general_insert_function): Likewise.
3533 * eval.c (struct backtrace.nargs, interactive_p)
3534 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3535 (funcall_lambda, mark_backtrace): Likewise.
3536 * fns.c (concat): Likewise.
3537 * frame.c (x_set_frame_parameters): Likewise.
3538 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3539 0 if not found, not -1. All callers changed.
3540
3541 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3542 (stack_copy_size): Now size_t, not int.
3543 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3544
3545 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3546
3547 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3548 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3549 All callers changed.
3550
3551 * lisp.h (multibyte_char_to_unibyte):
3552 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3553 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3554 * character.h (CHAR_TO_BYTE8):
3555 * cmds.c (internal_self_insert):
3556 * editfns.c (general_insert_function):
3557 * keymap.c (push_key_description):
3558 * search.c (Freplace_match):
3559 * xdisp.c (message_dolog, set_message_1): All callers changed.
3560
3561 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3562
3563 * keyboard.c (safe_run_hook_funcall): New function.
3564 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3565 don't set the hook to nil, but remove the offending function instead.
3566 (Qcommand_hook_internal): Remove, unused.
3567 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3568 Vcommand_hook_internal.
3569
3570 * eval.c (enum run_hooks_condition): Remove.
3571 (funcall_nil, funcall_not): New functions.
3572 (run_hook_with_args): Call each function through a `funcall' argument.
3573 Remove `cond' argument, now redundant.
3574 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3575 (Frun_hook_with_args_until_failure): Adjust accordingly.
3576 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3577
3578 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3579
3580 * dispextern.h (string_buffer_position): Remove declaration.
3581
3582 * print.c (strout): Remove parameter `multibyte', unused since
3583 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3584
3585 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3586 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3587 All callers changed.
3588
3589 * w32.c (_wsa_errlist): Use braces for struct initializers.
3590
3591 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3592 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3593 All callers changed.
3594 (string_buffer_position): Likewise. Also, make static (it's never
3595 used outside xdisp.c).
3596 (cursor_row_p): Remove parameter `w', unused since
3597 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3598 (decode_mode_spec): Remove parameter `precision', introduced during
3599 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3600 All callers changed.
3601
3602 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3603
3604 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3605
3606 2011-03-27 Anders Lindgren <andlind@gmail.com>
3607
3608 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3609 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3610 (ns_update_auto_hide_menu_bar): New functions.
3611 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3612 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3613 ns_constrain_all_frames.
3614 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3615 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3616
3617 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3618
3619 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3620
3621 2011-03-27 Glenn Morris <rgm@gnu.org>
3622
3623 * syssignal.h: Replace RETSIGTYPE with void.
3624 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3625 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3626 Replace SIGTYPE with void everywhere.
3627 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3628 * s/template.h (SIGTYPE): Remove commented out definition.
3629
3630 2011-03-26 Eli Zaretskii <eliz@gnu.org>
3631
3632 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3633 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3634
3635 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3636
3637 * w32.c (read_unc_volume): Use parameter `henum', instead of
3638 global variable `wget_enum_handle'.
3639
3640 * keymap.c (describe_vector): Remove parameters `indices' and
3641 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3642 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3643
3644 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3645
3646 * keyboard.c (timer_check): Remove parameter `do_it_now',
3647 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3648 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3649 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3650
3651 * keyboard.c (read_char):
3652 * w32menu.c (w32_menu_display_help):
3653 * xmenu.c (show_help_event, menu_help_callback):
3654 Adjust calls to `show_help_echo'.
3655
3656 * gtkutil.c (xg_maybe_add_timer):
3657 * keyboard.c (readable_events):
3658 * process.c (wait_reading_process_output):
3659 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3660
3661 * insdel.c (adjust_markers_gap_motion):
3662 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3663 (gap_left, gap_right): Don't call it.
3664
3665 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3666
3667 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3668 incurred during fontification.
3669
3670 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3671
3672 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3673 (DEFVAR_PER_BUFFER): Don't pass it.
3674
3675 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3676 (scrolling_window): Don't pass it.
3677
3678 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3679
3680 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3681
3682 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3683 and `suffix'.
3684 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3685 of variables specific to SELinux and computation of `encoded_absname'.
3686
3687 * image.c (XPutPixel): Remove unused variable `height'.
3688
3689 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3690
3691 * unexw32.c (get_section_info): Remove unused variable `section'.
3692
3693 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3694 (system_process_attributes): Remove unused variable `sess'.
3695 (sys_read): Remove unused variable `err'.
3696
3697 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3698 (w32_wnd_proc): Remove unused variable `isdead'.
3699 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3700 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3701 (x_create_tip_frame): Remove unused variable `tem'.
3702
3703 * w32inevt.c (w32_console_read_socket):
3704 Remove unused variable `no_events'.
3705
3706 * w32term.c (x_draw_composite_glyph_string_foreground):
3707 Remove unused variable `width'.
3708
3709 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3710
3711 * w32term.c (x_set_glyph_string_clipping):
3712 Don't pass uninitialized region to CombineRgn.
3713
3714 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3715
3716 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3717 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3718 (Fx_close_connection): Remove unused variable `i'.
3719
3720 * w32font.c (w32font_draw): Return number of glyphs.
3721 (w32font_open_internal): Remove unused variable `i'.
3722 (w32font_driver): Add missing initializer.
3723
3724 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3725 (fill_in_menu): Remove unused variable `items_added'.
3726
3727 * w32term.c (last_mouse_press_frame): Remove static global variable.
3728 (w32_clip_to_row): Remove unused variable `f'.
3729 (x_delete_terminal): Remove unused variable `i'.
3730
3731 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3732 (NOTHING): Remove unused static global variable.
3733 (uniscribe_check_otf): Remove unused variable `table'.
3734 (uniscribe_font_driver): Add missing initializers.
3735
3736 2011-03-23 Julien Danjou <julien@danjou.info>
3737
3738 * term.c (Fsuspend_tty, Fresume_tty):
3739 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3740 * window.c (temp_output_buffer_show):
3741 * insdel.c (signal_before_change):
3742 * frame.c (Fhandle_switch_frame):
3743 * fileio.c (Fdo_auto_save):
3744 * emacs.c (Fkill_emacs):
3745 * editfns.c (save_excursion_restore):
3746 * cmds.c (internal_self_insert):
3747 * callint.c (Fcall_interactively):
3748 * buffer.c (Fkill_all_local_variables):
3749 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3750 Use Frun_hooks.
3751 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3752 unconditionnaly since it does the check itself.
3753
3754 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3755
3756 Fix more problems found by GCC 4.5.2's static checks.
3757
3758 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3759 the first time through the loop, since we know p0 < p1 then.
3760 This also avoids a gcc -Wstrict-overflow warning.
3761
3762 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3763 leading to a memory leak, possible in functions like
3764 load_charset_map_from_file that can allocate an unbounded number
3765 of objects (Bug#8318).
3766
3767 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3768 that could (at least in theory) be that large.
3769
3770 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3771 This is less likely to overflow, and avoids undefined behavior if
3772 overflow does occur. All callers changed. Use strtoul to scan
3773 for the unsigned long integer.
3774 (pint2hrstr): Simplify and tune code slightly.
3775 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3776
3777 * scroll.c (do_scrolling): Work around GCC bug 48228.
3778 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3779
3780 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3781 This also avoids a warning with gcc -Wstrict-overflow.
3782 (validate_x_resource_name): Simplify count usage.
3783 This also avoids a warning with gcc -Wstrict-overflow.
3784
3785 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3786 fail (Bug#8306).
3787
3788 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3789
3790 * process.c (Fmake_network_process): Use socklen_t, not int,
3791 where POSIX says socklen_t is required in portable programs.
3792 This fixes a porting bug on hosts like 64-bit HP-UX, where
3793 socklen_t is wider than int (Bug#8277).
3794 (Fmake_network_process, server_accept_connection):
3795 (wait_reading_process_output, read_process_output):
3796 Likewise.
3797
3798 * process.c: Rename or move locals to avoid shadowing.
3799 (list_processes_1, Fmake_network_process):
3800 (read_process_output_error_handler, exec_sentinel_error_handler):
3801 Rename or move locals.
3802 (Fmake_network_process): Define label "retry_connect" only if needed.
3803 (Fnetwork_interface_info): Fix pointer signedness.
3804 (process_send_signal): Add cast to avoid pointer signedness problem.
3805 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3806 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3807
3808 Make tparam.h and terminfo.c consistent.
3809 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3810 Include tparam.h instead, since it declares them.
3811 * cm.h (PC): Remove extern decl; tparam.h now does this.
3812 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3813 * terminfo.c: Include tparam.h, to check interfaces.
3814 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3815 (tparam): Adjust signature to match interface in tparam.h;
3816 this removes some undefined behavior. Check that outstring and len
3817 are zero, which they always are with Emacs.
3818 * tparam.h (PC, BC, UP): New extern decls.
3819
3820 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3821 (xftfont_open): Rename locals to avoid shadowing.
3822
3823 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3824 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3825 (OTF_TAG_SYM): Omit macro if not needed.
3826 (ftfont_list): Remove unused local.
3827 (get_adstyle_property, ftfont_pattern_entity):
3828 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3829 Rename locals to avoid shadowing.
3830
3831 * xfont.c (xfont_list_family): Mark var as initialized.
3832
3833 * xml.c (make_dom): Now static.
3834
3835 * composite.c (composition_compute_stop_pos): Rename local to
3836 avoid shadowing.
3837 (composition_reseat_it): Remove unused locals.
3838 (find_automatic_composition, composition_adjust_point): Likewise.
3839 (composition_update_it): Mark var as initialized.
3840 (find_automatic_composition): Mark vars as initialized,
3841 with a FIXME (Bug#8290).
3842
3843 character.h: Rename locals to avoid shadowing.
3844 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3845 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3846 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3847 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3848 to avoid shadowing.
3849
3850 * textprop.c (property_change_between_p): Remove; unused.
3851
3852 * intervals.c (interval_start_pos): Now static.
3853
3854 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3855
3856 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3857 Rename locals to avoid shadowing.
3858
3859 * sound.c (wav_play, au_play, Fplay_sound_internal):
3860 Fix pointer signedness.
3861 (alsa_choose_format): Remove unused local var.
3862 (wav_play): Initialize a variable to 0, to prevent undefined
3863 behavior (Bug#8278).
3864
3865 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3866
3867 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3868
3869 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3870 clobbering (Bug#8298).
3871 * sysdep.c (sys_subshell): Likewise.
3872 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3873
3874 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3875 This should get cleaned up, so that child_setup has the
3876 same signature on all platforms.
3877
3878 * callproc.c (call_process_cleanup): Now static.
3879 (relocate_fd): Rename locals to avoid shadowing.
3880
3881 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3882
3883 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3884 not to be necessary, and produces flickering.
3885
3886 2011-03-20 Glenn Morris <rgm@gnu.org>
3887
3888 * config.in: Remove file.
3889
3890 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3891
3892 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3893 are now in src/globals.h.
3894 (syms_of_minibuf): Remove spurious & from previous change.
3895
3896 2011-03-20 Leo <sdl.web@gmail.com>
3897
3898 * minibuf.c (completing-read-function): New variable.
3899 (completing-read-default): Rename from completing-read.
3900 (completing-read): Call completing-read-function.
3901
3902 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3903
3904 * xfaces.c (Fx_load_color_file):
3905 Read color file from absolute filename (bug#8250).
3906
3907 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3908
3909 * makefile.w32-in: Update dependencies.
3910
3911 2011-03-17 Eli Zaretskii <eliz@gnu.org>
3912
3913 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3914
3915 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3916
3917 Fix more problems found by GCC 4.5.2's static checks.
3918
3919 * process.c (make_serial_process_unwind, send_process_trap):
3920 (sigchld_handler): Now static.
3921
3922 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3923 That way, the code declares only the vars that it needs.
3924 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3925 * s/cygwin.h (PTY_ITERATION): Likewise.
3926 * s/darwin.h (PTY_ITERATION): Likewise.
3927 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3928
3929 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3930 * process.c (allocate_pty): Don't declare stb unless it's needed.
3931
3932 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3933 (CONSTANTLIM): Remove; unused.
3934 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3935 Define only if needed.
3936
3937 * unexelf.c (unexec): Name an expression,
3938 to avoid gcc -Wbad-function-cast warning.
3939 Use a different way to cause a compilation error if anyone uses
3940 n rather than nn, a way that does not involve shadowing.
3941 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3942
3943 * deps.mk (unexalpha.o): Remove; unused.
3944
3945 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3946 * unexec.h: New file.
3947 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3948 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3949 Depend on unexec.h.
3950 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3951 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3952 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3953 Change as necessary to match prototype in unexec.h.
3954
3955 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3956 shadowing.
3957 (back_comment, skip_chars): Mark vars as initialized.
3958
3959 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3960 Rename locals to avoid shadowing.
3961
3962 * lread.c (read1): Rewrite so as not to use empty "else".
3963 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3964
3965 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3966
3967 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3968 warning when compiling print.c.
3969
3970 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3971 instead of using an uninitialized var.
3972 (font_sort_entities): Mark var as initialized.
3973
3974 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3975
3976 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3977 pointers to constants.
3978 (font_parse_fcname): Remove unused vars.
3979 (font_delete_unmatched): Now static.
3980 (font_get_spec): Remove; unused.
3981 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3982 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3983 Rename or move locals to avoid shadowing.
3984
3985 * fns.c (require_nesting_list, require_unwind): Now static.
3986 (Ffillarray): Rename locals to avoid shadowing.
3987
3988 * floatfns.c (domain_error2): Define only if needed.
3989 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3990
3991 * alloc.c (mark_backtrace): Move decl from here ...
3992 * lisp.h: ... to here, so that it can be checked.
3993
3994 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3995 (Fdefvar): Rewrite so as not to use empty "else".
3996 (lisp_indirect_variable): Name an expression,
3997 to avoid gcc -Wbad-function-cast warning.
3998 (Fdefvar): Rename locals to avoid shadowing.
3999
4000 * callint.c (quotify_arg, quotify_args): Now static.
4001 (Fcall_interactively): Rename locals to avoid shadowing.
4002 Use const pointer when appropriate.
4003
4004 * lisp.h (get_system_name, get_operating_system_release):
4005 Move decls here, to check interfaces.
4006 * process.c (get_operating_system_release): Move decl to lisp.h.
4007 * xrdb.c (get_system_name): Likewise.
4008 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4009 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4010 some of which prompt warnings from gcc -Wbad-function-cast.
4011 (Fformat_time_string, Fencode_time, Finsert_char):
4012 (Ftranslate_region_internal, Fformat):
4013 Rename or remove local vars to avoid shadowing.
4014 (Ftranslate_region_internal): Mark var as initialized.
4015
4016 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4017 avoid shadowing.
4018
4019 * lisp.h (eassert): Check that the argument compiles, even if
4020 ENABLE_CHECKING is not defined.
4021
4022 * data.c (Findirect_variable): Name an expression, to avoid
4023 gcc -Wbad-function-cast warning.
4024 (default_value, arithcompare, arith_driver, arith_error): Now static.
4025 (store_symval_forwarding): Rename local to avoid shadowing.
4026 (Fmake_variable_buffer_local, Fmake_local_variable):
4027 Mark variables as initialized.
4028 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4029
4030 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4031 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4032 Rename locals to avoid shadowing.
4033 (mark_stack): Move local variables into the #ifdef region where
4034 they're used.
4035 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4036 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4037 needed otherwise.
4038 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4039 (GC_STRING_CHARS): Remove; not used.
4040 (Fmemory_limit): Cast sbrk's returned value to char *.
4041
4042 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4043 avoids undefined behavior in theory.
4044
4045 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4046
4047 Use functions, not macros, for up- and down-casing (Bug#8254).
4048 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4049 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4050 to use the following functions instead of these macros.
4051 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4052 EMACS_INT, since callers assume the returned value fits in int.
4053 (upcase1): Likewise, for UPCASE_TABLE.
4054 (uppercasep, lowercasep, upcase): New static inline functions.
4055 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4056 the race-condition problem in the old DOWNCASE.
4057
4058 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4059 Rename locals to avoid shadowing.
4060 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4061 (regex_compile, re_search_2, re_match_2_internal):
4062 Remove unused local vars.
4063 (FREE_VAR): Rewrite so as not to use empty "else",
4064 which gcc can warn about.
4065 (regex_compile, re_match_2_internal): Mark locals as initialized.
4066 (RETALLOC_IF): Define only if needed.
4067 (WORDCHAR_P): Likewise. This one is never needed, but is used
4068 only in a comment talking about a compiler bug, so put inside
4069 the #if 0 of that comment.
4070 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4071 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4072 Remove; unused.
4073
4074 * search.c (boyer_moore): Rename locals to avoid shadowing.
4075 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4076 (PREV_CHAR_BOUNDARY): Likewise.
4077
4078 * search.c (simple_search): Remove unused var.
4079
4080 * dired.c (compile_pattern): Move decl from here ...
4081 * lisp.h: ... to here, so that it can be checked.
4082 (struct re_registers): New forward decl.
4083
4084 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4085
4086 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4087 All uses changed.
4088 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4089 Rename locals to avoid shadowing.
4090 (Fvertical_motion): Mark locals as initialized.
4091
4092 * casefiddle.c (casify_object, casify_region): Now static.
4093 (casify_region): Mark local as initialized.
4094
4095 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4096
4097 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4098 New macros, so that the caller can use some names other than
4099 gcpro1, gcpro2, etc.
4100 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4101 of the new macros.
4102 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4103 argument, for consistency with GCPRO2_VAR, etc: it is now the
4104 prefix of the variable, not the variable itself. All uses
4105 changed.
4106 * dired.c (directory_files_internal, file_name_completion):
4107 Rename locals to avoid shadowing.
4108
4109 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4110 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4111 dired.c's scmp function, had undefined behavior.
4112 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4113 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4114 * buffer.h: ... to here, because these macros use current_buffer,
4115 and the new implementation with inline functions needs to have
4116 current_buffer in scope now, rather than later when the macros
4117 are used.
4118 (downcase, upcase1): New static inline functions.
4119 (DOWNCASE, UPCASE1): Reimplement using these functions.
4120 This avoids undefined behavior in expressions like
4121 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4122 from race conditions in accessing the global variables
4123 case_temp1 and case_temp2.
4124 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4125 * lisp.h (case_temp1, case_temp2): Remove their decls.
4126 * character.h (ASCII_CHAR_P): Move from here ...
4127 * lisp.h: ... to here, so that the inline functions mentioned
4128 above can use them.
4129
4130 * dired.c (directory_files_internal_unwind): Now static.
4131
4132 * fileio.c (file_name_as_directory, directory_file_name):
4133 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4134 Now static.
4135 (file_name_as_directory): Use const pointers when appropriate.
4136 (Fexpand_file_name): Likewise. In particular, newdir might
4137 point at constant storage, so make it a const pointer.
4138 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4139 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4140 signedness issues.
4141 (Fset_file_times, Finsert_file_contents, auto_save_error):
4142 Rename locals to avoid shadowing.
4143
4144 * minibuf.c (choose_minibuf_frame_1): Now static.
4145 (Ftry_completion, Fall_completions): Rename or remove locals
4146 to avoid shadowing.
4147
4148 * marker.c (bytepos_to_charpos): Remove; unused.
4149
4150 * lisp.h (verify_bytepos, count_markers): New decls,
4151 so that gcc does not warn that these functions aren't declared.
4152
4153 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4154 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4155 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4156 (copy_text): Remove unused local var.
4157
4158 * filelock.c (within_one_second): Now static.
4159 (lock_file_1): Rename local to avoid shadowing.
4160
4161 * buffer.c (fix_overlays_before): Mark locals as initialized.
4162 (fix_start_end_in_overlays): Likewise. This function should be
4163 simplified by using pointers-to-pointers, but that's a different
4164 matter.
4165 (switch_to_buffer_1): Now static.
4166 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4167 (report_overlay_modification): Rename locals to avoid shadowing.
4168
4169 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4170 Fix pointer signedness issue.
4171 (sys_subshell): Mark local as volatile if checking for lint,
4172 to suppress a gcc -Wclobbered warning that does not seem to be right.
4173 (MAXPATHLEN): Define only if needed.
4174
4175 * process.c (serial_open, serial_configure): Move decls from here ...
4176 * systty.h: ... to here, so that they can be checked.
4177
4178 * fns.c (get_random, seed_random): Move extern decls from here ...
4179 * lisp.h: ... to here, so that they can be checked.
4180
4181 * sysdep.c (reset_io): Now static.
4182 (wait_for_termination_signal): Remove; unused.
4183
4184 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4185 (copy_keymap_item, append_key, push_text_char_description):
4186 Now static.
4187 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4188 (DENSE_TABLE_SIZE): Remove; unused.
4189 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4190 (describe_map_tree):
4191 Rename locals to avoid shadowing.
4192
4193 * keyboard.c: Declare functions static if they are not used elsewhere.
4194 (echo_char, echo_dash, cmd_error, top_level_2):
4195 (poll_for_input, handle_async_input): Now static.
4196 (read_char, kbd_buffer_get_event, make_lispy_position):
4197 (make_lispy_event, make_lispy_movement, apply_modifiers):
4198 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4199 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4200 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4201 (read_key_sequence, read_char): Mark locals as initialized.
4202 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4203
4204 * keyboard.h (make_ctrl_char): New decl.
4205 (mark_kboards): Move decl here ...
4206 * alloc.c (mark_kboards): ... from here.
4207
4208 * lisp.h (force_auto_save_soon): New decl.
4209
4210 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4211 (DEFINE_DUMMY_FUNCTION): New macro.
4212 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4213 Use it.
4214 (main): Add casts to avoid warnings
4215 if GCC considers string literals to be constants.
4216
4217 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4218
4219 * dbusbind.c: Pointer signedness fixes.
4220 (xd_signature, xd_append_arg, xd_initialize):
4221 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4222 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4223 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4224 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4225
4226 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4227 if GCC considers string literals to be constants.
4228 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4229
4230 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4231
4232 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4233 (print_preprocess, print_object): New macro to fix last change.
4234
4235 * print.c (print_preprocess): Don't forget font objects.
4236
4237 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4238
4239 * emacs.c (USAGE3): Doc fixes.
4240
4241 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4242
4243 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4244 structure.
4245
4246 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4247
4248 * lisp.h (VWindow_system, Qfile_name_history):
4249 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4250 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4251 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4252
4253 * w32select.c: Don't #include "keyboard.h".
4254 (run_protected): Add extern declaration for waiting_for_input.
4255
4256 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4257 * w32console.c (detect_input_pending, read_input_pending)
4258 (encode_terminal_code):
4259 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4260 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4261 (w32_system_caret_y, Qfile_name_history):
4262 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4263 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4264 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4265 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4266 * w32proc.c (Qlocal, report_file_error):
4267 * w32term.c (Vwindow_system, updating_frame):
4268 * w32uniscribe.c (initialized, uniscribe_font_driver):
4269 Remove unneeded extern declarations.
4270
4271 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4272
4273 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4274
4275 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4276
4277 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4278 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4279 These macros can no longer be used for assignment.
4280
4281 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4282 Assign struct members directly, instead of using BUF_BEGV etc.
4283 (record_buffer_markers, fetch_buffer_markers): New functions for
4284 recording and fetching special buffer markers.
4285 (set_buffer_internal_1, set_buffer_temp): Use them.
4286
4287 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4288
4289 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4290
4291 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4292 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4293
4294 * xdisp.c (hscroll_window_tree):
4295 (reconsider_clip_changes): Use PT instead of BUF_PT.
4296
4297 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4298
4299 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4300 $(EMACS_ROOT)/lib/intprops.h.
4301
4302 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4303
4304 Fix more problems found by GCC 4.5.2's static checks.
4305
4306 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4307 to unsigned char * to avoid compiler diagnostic.
4308 (xg_free_frame_widgets): Make it clear that a local variable is
4309 needed only if USE_GTK_TOOLTIP.
4310 (gdk_window_get_screen): Make it clear that this macro is needed
4311 only if USE_GTK_TOOLTIP.
4312 (int_gtk_range_get_value): New function, which avoids a diagnostic
4313 from gcc -Wbad-function-cast.
4314 (xg_set_toolkit_scroll_bar_thumb): Use it.
4315 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4316 diagnostic from gcc -Wbad-function-cast.
4317 (get_utf8_string, xg_get_file_with_chooser):
4318 Rename locals to avoid shadowing.
4319 (create_dialog): Move locals to avoid shadowing.
4320
4321 * xgselect.c (xg_select): Remove unused var.
4322
4323 * image.c (four_corners_best): Mark locals as initialized.
4324 (gif_load): Initialize transparent_p to zero (Bug#8238).
4325 Mark another local as initialized.
4326 (my_png_error, my_error_exit): Mark with NO_RETURN.
4327
4328 * image.c (clear_image_cache): Now static.
4329 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4330 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4331 (x_edge_detection): Remove unnecessary cast that
4332 gcc -Wbad-function-cast diagnoses.
4333 (gif_load): Fix pointer signedness.
4334 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4335 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4336
4337 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4338
4339 Improve quality of tests for time stamp overflow.
4340 For example, without this patch (encode-time 0 0 0 1 1
4341 1152921504606846976) returns the obviously-bogus value (-948597
4342 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4343 reports time overflow. See
4344 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4345 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4346 * editfns.c: Include limits.h and intprops.h.
4347 (TIME_T_MIN, TIME_T_MAX): New macros.
4348 (time_overflow): Move earlier, to before first use.
4349 (hi_time, lo_time): New functions, for an accurate test for
4350 out-of-range times.
4351 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4352 (Fget_internal_run_time): Don't assume time_t fits in int.
4353 (make_time): Use list2 instead of Fcons twice.
4354 (Fdecode_time): More accurate test for out-of-range times.
4355 (check_tm_member): New function.
4356 (Fencode_time): Use it, to test for out-of-range times.
4357 (lisp_time_argument): Don't rely on undefined left-shift and
4358 right-shift behavior when checking for time stamp overflow.
4359
4360 * editfns.c (time_overflow): New function, refactoring common code.
4361 (Fformat_time_string, Fdecode_time, Fencode_time):
4362 (Fcurrent_time_string): Use it.
4363
4364 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4365 * dired.c (make_time): Move to ...
4366 * editfns.c (make_time): ... here.
4367 * systime.h: Note the move.
4368
4369 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4370
4371 * fringe.c (update_window_fringes): Remove unused variables.
4372
4373 * unexmacosx.c (copy_data_segment): Also copy __got section.
4374 (Bug#8223)
4375
4376 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4377
4378 * termcap.c [MSDOS]: Include "msdos.h".
4379 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4380 Constify `char *' arguments and their references according to
4381 prototypes in tparam.h.
4382
4383 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4384
4385 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4386 Adapt all references accordingly.
4387
4388 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4389
4390 2011-03-11 Tom Tromey <tromey@redhat.com>
4391
4392 * buffer.c (syms_of_buffer): Remove obsolete comment.
4393
4394 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4395
4396 * termhooks.h (encode_terminal_code): Declare prototype.
4397
4398 * msdos.c (encode_terminal_code): Don't declare prototype.
4399
4400 * term.c (encode_terminal_code): Now external again, used by
4401 w32console.c and msdos.c.
4402
4403 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4404 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4405
4406 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4407
4408 Fix some minor problems found by GCC 4.5.2's static checks.
4409
4410 * fringe.c (update_window_fringes): Mark locals as initialized
4411 (Bug#8227).
4412 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4413
4414 * alloc.c (mark_fringe_data): Move decl from here ...
4415 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4416 to check its interface.
4417 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4418
4419 * fontset.c (free_realized_fontset): Now static.
4420 (Fset_fontset_font): Rename local to avoid shadowing.
4421 (fontset_font): Mark local as initialized.
4422 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
4423
4424 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4425
4426 * xselect.c (x_disown_buffer_selections): Remove; not used.
4427 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
4428 (x_own_selection, Fx_disown_selection_internal): Rename locals
4429 to avoid shadowing.
4430 (x_handle_dnd_message): Remove local to avoid shadowing.
4431
4432 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4433 so that the caller can use some name other than gcpro1.
4434 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
4435 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4436 (Fx_backspace_delete_keys_p):
4437 Use them to avoid shadowing, and rename vars to avoid shadowing.
4438 (x_decode_color, x_set_name, x_window): Now static.
4439 (Fx_create_frame): Add braces to silence GCC warning.
4440 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
4441 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4442 Remove unused locals.
4443 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4444 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4445 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4446 macros.
4447
4448 * xterm.h (x_mouse_leave): New decl.
4449
4450 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4451 Remove unused functions.
4452 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4453 (x_calc_absolute_position): Now static.
4454 (XTread_socket): Don't define label "out" unless it's used.
4455 Don't declare local "event" unless it's used.
4456 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4457 unless they are used.
4458 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4459 (x_fatal_error_signal): Remove; not used.
4460 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4461 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4462 (x_error_catcher, x_connection_closed, x_error_handler):
4463 (x_error_quitter, xembed_send_message, x_iconify_frame):
4464 (my_log_handler): Rename locals to avoid shadowing.
4465 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
4466 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
4467
4468 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4469 Rename or move locals to avoid shadowing.
4470 (tty_defined_color, merge_face_heights): Now static.
4471 (free_realized_faces_for_fontset): Remove; not used.
4472 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4473 does not deduce is never used uninitialized.
4474 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4475 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
4476
4477 * terminal.c (store_terminal_param): Now static.
4478
4479 * xmenu.c (menu_highlight_callback): Now static.
4480 (set_frame_menubar): Remove unused local.
4481 (xmenu_show): Rename parameter to avoid shadowing.
4482 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4483 since they might point to immutable storage.
4484 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4485 since it's unused otherwise.
4486
4487 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
4488 Add a FIXME, since the code still doesn't look right. (Bug#8215)
4489 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4490 avoids a gcc -Wuninitialized diagnostic.
4491 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
4492 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4493 does not deduce are never used uninitialized.
4494
4495 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4496
4497 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4498 * window.c (window_loop, size_window):
4499 (run_window_configuration_change_hook, enlarge_window): Likewise.
4500
4501 * window.c (display_buffer): Now static.
4502 (size_window): Mark variables that gcc -Wuninitialized
4503 does not deduce are never used uninitialized.
4504 * window.h (check_all_windows): New decl, to forestall
4505 gcc -Wmissing-prototypes diagnostic.
4506 * dispextern.h (bidi_dump_cached_states): Likewise.
4507
4508 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4509 shadowing.
4510 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4511 Include <limits.h>.
4512 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4513 and to avoid gcc -Wuninitialized warning.
4514 (load_charset_map): Mark variables that gcc -Wuninitialized
4515 does not deduce are never used uninitialized.
4516 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4517
4518 * coding.c (coding_set_source, coding_set_destination):
4519 Use "else { /* comment */ }" rather than "else /* comment */;"
4520 for clarity, and to avoid gcc -Wempty-body warning.
4521 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4522 a block, when the outer 'i' will do.
4523 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4524 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4525 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4526 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4527 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4528 Rename locals to avoid shadowing.
4529 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4530 * coding.c (emacs_mule_char, encode_invocation_designation):
4531 Now static, since they're not used elsewhere.
4532 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4533 (decode_coding_object, encode_coding_object, detect_coding_system):
4534 (decode_coding_emacs_mule): Mark variables that gcc
4535 -Wuninitialized does not deduce are never used uninitialized.
4536 (detect_coding_iso_2022): Initialize a local variable that might
4537 be used uninitialized. Leave a FIXME because it's not clear that
4538 this initialization is needed. (Bug#8211)
4539 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4540 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4541 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4542 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4543 Remove unused macros.
4544
4545 * category.c (hash_get_category_set): Remove unused local var.
4546 (copy_category_table): Now static, since it's not used elsewhere.
4547 * character.c (string_count_byte8): Likewise.
4548
4549 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4550 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4551
4552 * chartab.c (copy_sub_char_table): Now static, since it's not used
4553 elsewhere.
4554 (sub_char_table_ref_and_range, char_table_ref_and_range):
4555 Rename locals to avoid shadowing.
4556 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4557
4558 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4559 (BIDI_BOB): Remove unused macro.
4560
4561 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4562 deduce are never used uninitialized.
4563 * term.c (encode_terminal_code): Likewise.
4564
4565 * term.c (encode_terminal_code): Now static. Remove unused local.
4566
4567 * tparam.h: New file.
4568 * term.c, tparam.h: Include it.
4569 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4570 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4571 Move these decls to tparam.h, and make them agree with what
4572 is actually in tparam.c. The previous trick of using incompatible
4573 decls in different modules does not conform to the C standard.
4574 All callers of tparam changed to use tparam's actual API.
4575 * tparam.c (tparam1, tparam, tgoto):
4576 Use const pointers where appropriate.
4577
4578 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4579 * cm.h (struct cm): Likewise.
4580 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4581 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4582 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4583 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4584 (turn_on_face, init_tty): Likewise.
4585 * termchar.h (struct tty_display_info): Likewise.
4586
4587 * term.c (term_mouse_position): Rename local to avoid shadowing.
4588
4589 * alloc.c (mark_ttys): Move decl from here ...
4590 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4591
4592 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4593
4594 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4595
4596 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4597
4598 * search.c (compile_pattern_1): Remove argument regp, unused since
4599 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4600 (compile_pattern): Don't pass it.
4601
4602 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4603
4604 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4605 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4606 for ! HAVE_GTK3.
4607 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4608
4609 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4610
4611 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4612 gdk_window_get_screen, gdk_window_get_geometry,
4613 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4614 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4615 (xg_get_pixbuf_from_pixmap): New function.
4616 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4617 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4618 Call xg_get_pixbuf_from_pixmap instead of
4619 gdk_pixbuf_get_from_drawable.
4620 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4621 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4622 (xg_check_special_colors): Use GtkStyleContext and its functions
4623 for HAVE_GTK3.
4624 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4625 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4626 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4627 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4628 Call gtk_widget_get_preferred_size.
4629 (xg_frame_resized): gdk_window_get_geometry only takes 5
4630 parameters.
4631 (xg_win_to_widget, xg_event_is_for_menubar):
4632 Call gdk_x11_window_lookup_for_display.
4633 (xg_set_widget_bg): New function.
4634 (delete_cb): New function.
4635 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4636 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4637 (xg_set_background_color): Call xg_set_widget_bg.
4638 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4639 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4640 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4641 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4642 if ! HAVE_GTK3.
4643 (update_frame_tool_bar): Call gtk_widget_hide.
4644 (xg_initialize): Use GDK_KEY_g.
4645
4646 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4647 if ! HAVE_GTK3
4648 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4649
4650 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4651 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4652 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4653
4654 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4655
4656 * w32xfns.c (select_palette): Check success of RealizePalette against
4657 GDI_ERROR, not zero.
4658
4659 See ChangeLog.11 for earlier changes.
4660
4661 ;; Local Variables:
4662 ;; coding: utf-8
4663 ;; End:
4664
4665 Copyright (C) 2011 Free Software Foundation, Inc.
4666
4667 This file is part of GNU Emacs.
4668
4669 GNU Emacs is free software: you can redistribute it and/or modify
4670 it under the terms of the GNU General Public License as published by
4671 the Free Software Foundation, either version 3 of the License, or
4672 (at your option) any later version.
4673
4674 GNU Emacs is distributed in the hope that it will be useful,
4675 but WITHOUT ANY WARRANTY; without even the implied warranty of
4676 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4677 GNU General Public License for more details.
4678
4679 You should have received a copy of the GNU General Public License
4680 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.