* process.c (Fnetwork_interface_list): Check for overflow
[bpt/emacs.git] / src / ChangeLog
1 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
2
3 * process.c (Fnetwork_interface_list): Check for overflow
4 in size calculation.
5
6 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7 Now ptrdiff_t, not int.
8 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
9 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
10
11 * minibuf.c (read_minibuf_noninteractive): Don't leak memory
12 on memory overflow.
13
14 * macros.c: Integer and memory overflow fixes.
15 (Fstart_kbd_macro): Don't update size until alloc done.
16 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
17
18 * lread.c (read1, init_obarray): Don't update size until alloc done.
19
20 * keymap.c: Integer overflow fixes.
21 (cmm_size, current_minor_maps): Use ptrdiff_t, not int, to count maps.
22 (current_minor_maps): Check for size calculation overflow.
23 * keymap.h: Change prototypes to match the above.
24
25 * keyboard.c: Integer and memory overflow fixes.
26 (read_char, menu_bar_items, tool_bar_items, read_char_x_menu_prompt)
27 (read_char_minibuf_menu_width, read_char_minibuf_menu_prompt)
28 (follow_key, read_key_sequence): Use ptrdiff_t, not int, to count maps.
29 (read_char_minibuf_menu_prompt): Check for overflow in size
30 calculations. Don't update size until allocation succeeds. Redo
31 calculations to avoid overflow.
32 * keyboard.h: Change prototypes to match the above.
33
34 * image.c: Integer and memory overflow fixes.
35 (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these are duplicate
36 now that they've been promoted to lisp.h.
37 (x_allocate_bitmap_record, x_alloc_image_color)
38 (make_image_cache, cache_image, xpm_load):
39 Don't update size until alloc is done.
40 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
41 (x_detect_edges):
42 Check for size calculation overflow.
43 (ct_colors_allocated_max): New constant.
44 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
45 overflow.
46
47 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
48
49 * gtkutil.c: Integer overflow fixes.
50 (get_utf8_string, xg_store_widget_in_map):
51 Check for size-calculation overflow.
52 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
53 do, as we prefer signed integers.
54 (id_to_widget.max_size, id_to_widget.used)
55 (xg_store_widget_in_map, xg_remove_widget_from_map)
56 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
57 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
58 Use and return ptrdiff_t, not int.
59 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
60 * gtkutil.h: Change prototypes to match the above.
61
62 * ftfont.c: Check for size overflow.
63 (ftfont_get_open_type_spec, setup_otf_gstring, ftfont_shape_by_flt):
64 Check for integer overflow in size calculations.
65
66 * fringe.c (Fdefine_fringe_bitmap): Don't update size until alloc works.
67
68 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
69 This is for the members text_lines, text_cols, total_lines, total_cols,
70 where the system imposes an 'int' limit.
71
72 * frame.c: Integer overflow fixes.
73 (set_menu_bar_lines, x_set_frame_parameters, x_set_scroll_bar_width)
74 (x_figure_window_size): Check for integer overflow.
75 (x_set_alpha): Do not assume XINT fits in int.
76
77 * eval.c: Integer and memory overflow fixes.
78 (init_eval_once, grow_specpdl): Don't update size until alloc succeeds.
79 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
80
81 * emacs.c (main, sort_args): Check for size-calculation overflow.
82
83 * editfns.c: Integer and memory overflow fixes.
84 (set_time_zone_rule): Don't assume environment length fits in int.
85 (message_length): Now ptrdiff_t, not int.
86 (Fmessage_box): Don't update size until allocation succeeds.
87 Don't assume message length fits in int.
88 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
89
90 * doc.c: Integer and memory overflow fixes.
91 (get_doc_string_buffer_size): Now ptrdiff_t, not int.
92 (get_doc_string): Check for size calculation overflow.
93 Don't update size until allocation succeeds.
94 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
95 EMACS_INT, where ptrdiff_t will do.
96 (Fsubstitute_command_keys): Check for string overflow.
97
98 Integer and memory overflow fixes for display code.
99 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
100 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool, scrolling_window):
101 Check for overflow in size calculations.
102 (line_draw_cost, realloc_glyph_pool, add_row_entry):
103 Don't assume glyph table len fits in int.
104 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
105 (row_table_size): Now ptrdiff_t, not int.
106 (scrolling_window): Avoid overflow in size calculations.
107 Don't update size until allocation succeeds.
108 * fns.c (concat): Check for overflow in size calculations.
109 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
110 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
111 (NEXT_ALMOST_PRIME_LIMIT): New constant.
112
113 * composite.c: Integer overflow fixes.
114 (get_composition_id): Check for overflow in glyph length calculations.
115
116 * coding.c: Integer and memory overflow fixes.
117 (produce_chars): Redo buffer-overflow calculations to avoid
118 unnecessary integer overflow. Check for size overflow.
119 (encode_coding_object): Don't update size until xmalloc succeeds.
120
121 * character.c (Fstring): Check for size-calculation overflow.
122
123 * ccl.c: Integer and memory overflow fixes.
124 (Fccl_execute_on_string): Check for memory overflow.
125 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
126 Redo buffer-overflow calculations to avoid integer overflow.
127
128 * callproc.c (child_setup): Don't assume strlen fits in int.
129
130 * buffer.c: Memory overflow fixes.
131 (overlays_at, overlays_in, record_overlay_string, overlay_strings):
132 Don't update size of array until after memory allocation succeeds,
133 because xmalloc/xrealloc may not return.
134
135 * bidi.c: Integer overflow fix.
136 (bidi_shelve_header_size): New constant.
137 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
138 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
139
140 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
141
142 Use ptrdiff_t for composition IDs.
143 * character.c (lisp_string_width):
144 * composite.c (composition_table_size, n_compositions)
145 (get_composition_id, composition_gstring_from_id):
146 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
147 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
148 * window.c (Frecenter):
149 Use ptrdiff_t, not int, for composition IDs.
150 * composite.c (get_composition_id): Check for integer overflow.
151 * composite.h: Adjust prototypes to match the above changes.
152
153 Use ptrdiff_t for hash table indexes.
154 * category.c (hash_get_category_set):
155 * ccl.c (ccl_driver):
156 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
157 * coding.c (coding_system_charset_list, detect_coding_system):
158 * coding.h (struct coding_system.id):
159 * composite.c (get_composition_id, gstring_lookup_cache):
160 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
161 * image.c (xpm_get_color_table_h):
162 * lisp.h (hash_lookup, hash_put):
163 * minibuf.c (Ftest_completion):
164 Use ptrdiff_t for hash table indexes, not int (which is too
165 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
166 32-bit --with-wide-int hosts).
167
168 * charset.c (Fdefine_charset_internal): Check for integer overflow.
169 Add a FIXME comment about memory leaks.
170 (syms_of_charset): Don't assume xmalloc returns.
171
172 Don't assume that stated character widths fit in int.
173 * character.c (Fchar_width, c_string_width, lisp_string_width):
174 * character.h (CHAR_WIDTH):
175 * indent.c (MULTIBYTE_BYTES_WIDTH):
176 Use sanitize_char_width to avoid undefined and/or bad behavior
177 with outlandish widths.
178 * character.h (sanitize_tab_width): Renamed from sanitize_width,
179 now that we have two such functions. All uses changed.
180 (sanitize_char_width): New inline function.
181
182 Don't assume that tab-width fits in int.
183 * character.h (sanitize_width): New inline function.
184 (SANE_TAB_WIDTH): New macro.
185 (ASCII_CHAR_WIDTH): Use it.
186 * indent.c (sane_tab_width): Remove. All uses replaced by
187 SANE_TAB_WIDTH (current_buffer).
188 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
189
190 * fileio.c: Integer overflow issues with file modes.
191 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
192
193 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
194 Remove unreachable code.
195 (read_hex, load_charset_map_from_file): Check for integer overflow.
196
197 * xterm.c: don't go over XClientMessageEvent limit
198 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
199 (x_send_scroll_bar_event): Likewise. Check that the size does not
200 exceed limits imposed by XClientMessageEvent, as well as the usual
201 ptrdiff_t and size_t limits.
202
203 * keyboard.c: Overflow, signedness and related fixes.
204 (make_lispy_movement): Use same integer type in forward decl
205 that is used in the definition.
206 (read_key_sequence, keyremap_step):
207 Change bufsize argument back to int, undoing my 2011-03-30 change.
208 We prefer signed types, and int is wide enough here.
209 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
210 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
211 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
212 length, not size_t. Use ptrdiff_t for index, not int.
213 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
214 possibility of integer overflow.
215
216 Overflow, signedness and related fixes for images.
217
218 * dispextern.h (struct it.stack[0].u.image.image_id)
219 (struct_it.image_id, struct image.id, struct image_cache.size)
220 (struct image_cache.used, struct image_cache.ref_count):
221 * gtkutil.c (update_frame_tool_bar):
222 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
223 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
224 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
225 * nsmenu.m (update_frame_tool_bar):
226 * xdisp.c (calc_pixel_width_or_height):
227 * xfns.c (image_cache_refcount):
228 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
229 on typical 64-bit hosts.
230
231 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
232 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
233 Omit unnecessary casts to int.
234 (parse_image_spec): Check that integers fall into 'int' range
235 when the callers expect that.
236 (image_ascent): Redo ascent calculation to avoid int overflow.
237 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
238 (lookup_image): Remove unnecessary tests.
239 (xbm_image_p): Locals are now of int, not EMACS_INT,
240 since parse_image_check makes sure they fit into int.
241 (png_load, gif_load, svg_load_image):
242 Prefer int to unsigned where either will do.
243 (tiff_handler): New function, combining the cores of the
244 old tiff_error_handler and tiff_warning_handler. This
245 function is rewritten to use vsnprintf and thereby avoid
246 stack buffer overflows. It uses only the features of vsnprintf
247 that are common to both POSIX and native Microsoft.
248 (tiff_error_handler, tiff_warning_handler): Use it.
249 (tiff_load, gif_load, imagemagick_load_image):
250 Don't assume :index value fits in 'int'.
251 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
252 (imagemagick_load_image): Check that crop parameters fit into
253 the integer types that MagickCropImage accepts. Don't assume
254 Vimagemagick_render_type has a nonnegative value. Don't assume
255 size_t fits in 'long'.
256 (gs_load): Use printmax_t to print the widest integers possible.
257 Check for integer overflow when computing image height and width.
258
259 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
260
261 Integer signedness and overflow and related fixes. (Bug#9079)
262
263 * bidi.c: Integer size and overflow fixes.
264 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
265 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
266 (bidi_cache_find_level_change, bidi_cache_ensure_space)
267 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
268 (bidi_find_other_level_edge):
269 Use ptrdiff_t instead of EMACS_INT where either will do.
270 This works better on 32-bit hosts configured --with-wide-int.
271 (bidi_cache_ensure_space): Check for size-calculation overflow.
272 Use % rather than repeated addition, for better worst-case speed.
273 Don't set bidi_cache_size until after xrealloc returns, because it
274 might not return.
275 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
276 (bidi_cache_ensure_space): Also check that the bidi cache size
277 does not exceed that of the largest Lisp string or buffer. See Eli
278 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
279
280 * alloc.c (__malloc_size_t): Remove.
281 All uses replaced by size_t. See Andreas Schwab's note
282 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
283
284 * image.c: Improve checking for integer overflow.
285 (check_image_size): Assume that f is nonnull, since
286 it is always nonnull in practice. This is one less thing to
287 worry about when checking for integer overflow later.
288 (x_check_image_size): New function, which checks for integer
289 overflow issues inside X.
290 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
291 This removes the need for a memory_full check.
292 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
293 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
294 (xbm_read_bitmap_data): Change locals back to 'int', since
295 their values must fit in 'int'.
296 (xpm_load_image, png_load, tiff_load):
297 Invoke x_create_x_image_and_pixmap earlier,
298 to avoid much needless work if the image is too large.
299 (tiff_load): Treat overly large images as if
300 x_create_x_image_and_pixmap failed, not as malloc failures.
301 (gs_load): Use x_check_image_size.
302
303 * gtkutil.c: Omit integer casts.
304 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
305 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
306
307 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
308
309 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
310 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
311 would wrongly return t on a 64-bit host.
312
313 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
314 The plain *_OVERFLOW macros run afoul of GCC bug 49705
315 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
316 and therefore cause GCC to emit a bogus diagnostic in some cases.
317
318 * image.c: Integer signedness and overflow and related fixes.
319 This is not an exhaustive set of fixes, but it's time to
320 record what I've got.
321 (lookup_pixel_color, check_image_size): Remove redundant decls.
322 (check_image_size): Don't assume that arbitrary EMACS_INT values
323 fit in 'int', or that arbitrary 'double' values fit in 'int'.
324 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
325 (tiff_load, imagemagick_load_image):
326 Check for overflow in size calculations.
327 (x_create_x_image_and_pixmap): Remove unnecessary test for
328 xmalloc returning NULL; that can't happen.
329 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
330 (xpm_color_bucket): Use better integer hashing function.
331 (xpm_cache_color): Don't possibly over-allocate memory.
332 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
333 (gif_memory_source):
334 Use ptrdiff_t, not int or size_t, to record sizes.
335 (png_load): Don't assume values greater than 2**31 fit in 'int'.
336 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
337 either works, as we prefer signed integers.
338 (tiff_read_from_memory, tiff_write_from_memory):
339 Return tsize_t, not size_t, since that's what the TIFF API wants.
340 (tiff_read_from_memory): Don't fail simply because the read would
341 go past EOF; instead, return a short read.
342 (tiff_load): Omit no-longer-needed casts.
343 (Fimagemagick_types): Don't assume size fits into 'int'.
344
345 Improve hashing quality when configured --with-wide-int.
346 * fns.c (hash_string): New function, taken from sxhash_string.
347 Do not discard information about ASCII character case; this
348 discarding is no longer needed.
349 (sxhash-string): Use it. Change sig to match it. Caller changed.
350 * lisp.h: Declare it.
351 * lread.c (hash_string): Remove, since we now use fns.c's version.
352 The fns.c version returns a wider integer if --with-wide-int is
353 specified, so this should help the quality of the hashing a bit.
354
355 * emacs.c: Integer overflow minor fix.
356 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
357 Define only if GNU_LINUX.
358 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
359
360 * dispnew.c: Integer signedness and overflow fixes.
361 Remove unnecessary forward decls, that were a maintenance hassle.
362 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
363 All uses changed.
364 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
365 (scrolling_window): Use ptrdiff_t, not int, for byte count.
366 (prepare_desired_row, line_draw_cost):
367 Use int, not unsigned, where either works.
368 (save_current_matrix, restore_current_matrix):
369 Use ptrdiff_t, not size_t, where either works.
370 (init_display): Check for overflow more accurately, and without
371 relying on undefined behavior.
372
373 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
374 Remove, replacing with the new symbols in lisp.h. All uses changed.
375 * fileio.c (make_temp_name):
376 * filelock.c (lock_file_1, lock_file):
377 * xdisp.c (message_dolog):
378 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
379 Use pMd etc. instead.
380 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
381 replacing the pWIDE etc. symbols removed from editfns.c.
382
383 * keyboard.h (num_input_events): Now uintmax_t.
384 This is (very slightly) less likely to mess up due to wraparound.
385 All uses changed.
386
387 * buffer.c: Integer signedness fixes.
388 (alloc_buffer_text, enlarge_buffer_text):
389 Use ptrdiff_t rather than size_t when either will do, as we prefer
390 signed integers.
391
392 * alloc.c: Integer signedness and overflow fixes.
393 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
394 (__malloc_size_t): Default to size_t, not to int.
395 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
396 (Fgarbage_collect, mark_object_loop_halt, mark_object):
397 Prefer ptrdiff_t to size_t when either would do, as we prefer
398 signed integers.
399 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
400 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
401 Now const. Initialize with values that are in range even if char
402 is signed.
403 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
404 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
405 These functions do the right thing with sizes > 2**32.
406 (check_depth): Now ptrdiff_t, not int.
407 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
408 Adjust to new way of storing sizes. Check for size overflow bugs
409 in rest of code.
410 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
411 slightly wrong anyway, as it missed one instance of
412 XMALLOC_OVERRUN_CHECK_OVERHEAD.
413 (refill_memory_reserve): Omit needless cast to size_t.
414 (mark_object_loop_halt): Mark as externally visible.
415
416 * xselect.c: Integer signedness and overflow fixes.
417 (Fx_register_dnd_atom, x_handle_dnd_message):
418 Use ptrdiff_t, not size_t, since we prefer signed.
419 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
420 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
421 x_dnd_atoms_size and x_dnd_atoms_length.
422
423 * doprnt.c: Prefer signed to unsigned when either works.
424 * eval.c (verror):
425 * doprnt.c (doprnt):
426 * lisp.h (doprnt):
427 * xdisp.c (vmessage):
428 Use ptrdiff_t, not size_t, when using or implementing doprnt,
429 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
430 prefer signed arithmetic to avoid comparison confusion.
431 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
432 but is a bit tricky.
433
434 Assume freestanding C89 headers, string.h, stdlib.h.
435 * data.c, doprnt.c, floatfns.c, print.c:
436 Include float.h unconditionally.
437 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
438 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
439 * regex.c: Likewise for stddef.h, string.h.
440 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
441 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
442 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
443 (STDC_HEADERS): Remove obsolete defines.
444 * sysdep.c: Include limits.h unconditionally.
445
446 Assume support for memcmp, memcpy, memmove, memset.
447 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
448 * regex.c (memcmp, memcpy):
449 Remove; we assume C89 now.
450
451 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
452 (__malloc_safe_bcopy): Remove; no longer needed.
453
454 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
455 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
456 well either way, and we prefer signed to unsigned.
457
458 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
459
460 Port to OpenBSD.
461 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
462 and the surrounding thread.
463 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
464 rather than fgets, and retry after EINTR. Otherwise, 'emacs
465 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
466 timer goes off.
467 * s/openbsd.h (BROKEN_SIGIO): Define.
468 * unexelf.c (unexec) [__OpenBSD__]:
469 Don't update the .mdebug section of the Alpha COFF symbol table.
470
471 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
472
473 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
474 (bug#8460).
475
476 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
477
478 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
479 This fixes some race conditions on the permissions of any newly
480 created file.
481
482 * alloc.c (valid_pointer_p): Use pipe, not open.
483 This fixes some permissions issues when debugging.
484
485 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
486 If fchown fails to set both uid and gid, try to set just gid,
487 as that is sometimes allowed. Adjust the file's mode to eliminate
488 setuid or setgid bits that are inappropriate if fchown fails.
489
490 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
491
492 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
493 to compare Lisp_Objects.
494 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
495 global_gnutls_log_level, don't mistake it for a Lisp_Object.
496 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
497
498 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
499
500 * lread.c (read_integer): Unread even EOF character.
501 (read1): Likewise. Properly record start position of symbol.
502
503 * lread.c (read1): Read `#:' as empty uninterned symbol if no
504 symbol character follows.
505
506 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
507
508 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
509 This works around a problem with the previous change to Fcopy_file.
510 Recent glibc declares fchown with __attribute__((warn_unused_result)),
511 and without this change, GCC might complain about discarding
512 fchown's return value.
513
514 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
515
516 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
517
518 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
519
520 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
521
522 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
523
524 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
525 it's used from the C level.
526
527 * process.c: Use the same condition for POLL_FOR_INPUT in both
528 keyboard.c and process.c (bug#1858).
529
530 2011-07-09 Lawrence Mitchell <wence@gmx.li>
531
532 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
533 (Fgnutls_boot): Use it.
534
535 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
536
537 * doc.c (Fsubstitute_command_keys): Revert last change.
538
539 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
540
541 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
542 quotes the next character, and doesn't affect other longer
543 sequences (bug#8935).
544
545 * lread.c (syms_of_lread): Clarify that is isn't only
546 `eval-buffer' and `eval-defun' that's affected by
547 `lexical-binding' (bug#8460).
548
549 2011-07-15 Eli Zaretskii <eliz@gnu.org>
550
551 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
552 bidi redisplay when a line includes both an image and is
553 truncated.
554
555 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
556
557 Fix minor problems found by static checking.
558 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
559 (elsz): Now a signed constant, not a size_t var. We prefer signed
560 types to unsigned, to avoid integer comparison confusion. Without
561 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
562 "cannot optimize loop, the loop counter may overflow", a symptom
563 of the confusion.
564 * indent.c (Fvertical_motion): Mark locals as initialized.
565 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
566
567 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
568
569 * search.c (Fre_search_backward): Mention `case-fold-search' in
570 all the re_search_* functions (bug#8138).
571
572 * keyboard.c (Fopen_dribble_file): Document when the file is
573 closed (bug#8056).
574
575 2011-07-14 Eli Zaretskii <eliz@gnu.org>
576
577 * bidi.c (bidi_dump_cached_states): Fix format of displaying
578 bidi_cache_idx.
579
580 Support bidi reordering of display and overlay strings.
581 * xdisp.c (compute_display_string_pos)
582 (compute_display_string_end): Accept additional argument STRING.
583 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
584 (reseat_to_string): Initialize bidi_it->string.s and
585 bidi_it->string.schars.
586 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
587 NULL (avoids a crash in bidi_paragraph_init). Initialize
588 itb.string.lstring.
589 (init_iterator): Call bidi_init_it only of a valid
590 buffer position was specified. Initialize paragraph_embedding to
591 L2R.
592 (reseat_to_string): Initialize the bidi iterator.
593 (display_string): If we need to ignore text properties of
594 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
595 original value of -1 will not work with bidi.)
596 (compute_display_string_pos): First arg is now struct
597 `text_pos *'; all callers changed. Support display properties on
598 Lisp strings.
599 (compute_display_string_end): Support display properties on Lisp
600 strings.
601 (init_iterator, reseat_1, reseat_to_string): Initialize the
602 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
603 when iterating on a string not from display properties).
604 (compute_display_string_pos, compute_display_string_end): Fix
605 calculation of the object to scan. Fixes an error when using
606 arrow keys.
607 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
608 base_level_stop; instead, set base_level_stop to BEGV. Fixes
609 crashes in vertical-motion.
610 (next_element_from_buffer): Improve commentary for when
611 the iterator is before prev_stop.
612 (init_iterator): Initialize bidi_p from the default value of
613 bidi-display-reordering, not from buffer-local value. Use the
614 buffer-local value only if initializing for buffer iteration.
615 (handle_invisible_prop): Support invisible properties on strings
616 that are being bidi-reordered.
617 (set_iterator_to_next): Support bidi reordering of C strings and
618 Lisp strings.
619 (next_element_from_string): Support bidi reordering of Lisp
620 strings.
621 (handle_stop_backwards): Support Lisp strings as well.
622 (display_string): Support display of R2L glyph rows. Use
623 IT_STRING_CHARPOS when displaying from a Lisp string.
624 (init_iterator): Don't initialize it->bidi_p for strings
625 here.
626 (reseat_to_string): Initialize it->bidi_p for strings here.
627 (next_element_from_string, next_element_from_c_string)
628 (next_element_from_buffer): Add xassert's for correspondence
629 between IT's object being iterated and it->bidi_it.string
630 structure.
631 (face_before_or_after_it_pos): Support bidi iteration.
632 (next_element_from_c_string): Handle the case of the first string
633 character that is not the first one in the visual order.
634 (get_visually_first_element): New function, refactored from common
635 parts of next_element_from_buffer, next_element_from_string, and
636 next_element_from_c_string.
637 (tool_bar_lines_needed, redisplay_tool_bar)
638 (display_menu_bar): Force left-to-right direction. Add a FIXME
639 comment for making that be controlled by a user option.
640 (push_it, pop_it): Save and restore the state of the
641 bidi iterator. Save and restore the bidi_p flag.
642 (pop_it): Iterate out of display property for string iteration as
643 well.
644 (iterate_out_of_display_property): Support iteration over strings.
645 (handle_single_display_spec): Set up it->bidi_it for iteration
646 over a display string, and call bidi_init_it.
647 (handle_single_display_spec, next_overlay_string)
648 (get_overlay_strings_1, push_display_prop): Set up the bidi
649 iterator for displaying display or overlay strings.
650 (forward_to_next_line_start): Don't use the shortcut if
651 bidi-iterating.
652 (back_to_previous_visible_line_start): If handle_display_prop
653 pushed the iterator stack, restore the internal state of the bidi
654 iterator by calling bidi_pop_it same number of times.
655 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
656 and we are bidi-iterating, don't decrement the iterator position;
657 instead, set the first_elt flag in the bidi iterator, to produce
658 the same effect.
659 (reseat_1): Remove redundant setting of string_from_display_prop_p.
660 (push_display_prop): xassert that we are iterating a buffer.
661 (push_it, pop_it): Save and restore paragraph_embedding member.
662 (handle_single_display_spec, next_overlay_string)
663 (get_overlay_strings_1, reseat_1, reseat_to_string)
664 (push_display_prop): Set up the `unibyte' member of bidi_it.string
665 correctly. Don't assume unibyte strings are not bidi-reordered.
666 (compute_display_string_pos)
667 (compute_display_string_end): Fix handling the case of C string.
668 (push_it, pop_it): Save and restore from_disp_prop_p.
669 (handle_single_display_spec, push_display_prop): Set the
670 from_disp_prop_p flag.
671 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
672 (pop_it): Call iterate_out_of_display_property only if we are
673 popping after iteration over a string that came from a display
674 property. Fix a typo in popping stretch info. Add an assertion
675 for verifying that the iterator position is in sync with the bidi
676 iterator.
677 (handle_single_display_spec, get_overlay_strings_1)
678 (push_display_prop): Fix initialization of paragraph direction for
679 string when that of the parent object is not yet determined.
680 (reseat_1): Call bidi_init_it to resync the bidi
681 iterator with IT's position. (Bug#7616)
682 (find_row_edges): If ROW->start.pos gives position
683 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
684 (handle_stop, back_to_previous_visible_line_start, reseat_1):
685 Reset the from_disp_prop_p flag.
686 (SAVE_IT, RESTORE_IT): New macros.
687 (pos_visible_p, face_before_or_after_it_pos)
688 (back_to_previous_visible_line_start)
689 (move_it_in_display_line_to, move_it_in_display_line)
690 (move_it_to, move_it_vertically_backward, move_it_by_lines)
691 (try_scrolling, redisplay_window, display_line): Use them when
692 saving a temporary copy of the iterator and restoring it back.
693 (back_to_previous_visible_line_start, reseat_1)
694 (init_iterator): Empty the bidi cache "stack".
695 (move_it_in_display_line_to): If iterator ended up at
696 EOL, but we never saw any buffer positions smaller than
697 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
698 motion in bidi-reordered lines.
699 (move_it_in_display_line_to): Record prev_method and prev_pos
700 immediately before the call to set_iterator_to_next. Fixes cursor
701 motion in bidi-reordered lines with stretch glyphs and strings
702 displayed in margins. (Bug#8133) (Bug#8867)
703 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
704 TO_CHARPOS.
705 (pos_visible_p): Support positions in bidi-reordered lines. Save
706 and restore bidi cache.
707
708 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
709 (bidi_paragraph_info): Delete unused struct.
710 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
711 (bidi_cache_start): New variable.
712 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
713 to zero.
714 (bidi_cache_fetch_state, bidi_cache_search)
715 (bidi_cache_find_level_change, bidi_cache_iterator_state)
716 (bidi_cache_find, bidi_peek_at_next_level)
717 (bidi_level_of_next_char, bidi_find_other_level_edge)
718 (bidi_move_to_visually_next): Compare cache index with
719 bidi_cache_start rather than with zero.
720 (bidi_fetch_char): Accept new argument STRING; all callers
721 changed. Support iteration over a string. Support strings with
722 display properties. Support unibyte strings. Fix the type of
723 `len' according to what STRING_CHAR_AND_LENGTH expects.
724 (bidi_paragraph_init, bidi_resolve_explicit_1)
725 (bidi_resolve_explicit, bidi_resolve_weak)
726 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
727 iteration over a string.
728 (bidi_set_sor_type, bidi_resolve_explicit_1)
729 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
730 can now be zero (for strings); special values 0 and -1 were
731 changed to -1 and -2, respectively.
732 (bidi_char_at_pos): New function.
733 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
734 Call it instead of FETCH_MULTIBYTE_CHAR.
735 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
736 initialized to valid values.
737 (bidi_init_it): Don't initialize charpos and bytepos with invalid
738 values.
739 (bidi_level_of_next_char): Allow the sentinel "position" to pass
740 the test for valid cached positions. Fix the logic for looking up
741 the sentinel state in the cache. GCPRO the Lisp string we are
742 iterating.
743 (bidi_push_it, bidi_pop_it): New functions.
744 (bidi_initialize): Initialize the bidi cache start stack pointer.
745 (bidi_cache_ensure_space): New function, refactored from part of
746 bidi_cache_iterator_state. Don't assume the required size is just
747 one BIDI_CACHE_CHUNK away.
748 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
749 (bidi_count_bytes, bidi_char_at_pos): New functions.
750 (bidi_cache_search): Don't assume bidi_cache_last_idx is
751 always valid if bidi_cache_idx is valid.
752 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
753 is valid if it's going to be used.
754 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
755 (bidi_cache_fetch_state, bidi_cache_search)
756 (bidi_cache_find_level_change, bidi_cache_ensure_space)
757 (bidi_cache_iterator_state, bidi_cache_find)
758 (bidi_find_other_level_edge, bidi_cache_start_stack): All
759 variables related to cache indices are now EMACS_INT.
760
761 * dispextern.h (struct bidi_string_data): New structure.
762 (struct bidi_it): New member `string'. Make flag members be 1-bit
763 fields, and put them last in the struct.
764 (compute_display_string_pos, compute_display_string_end): Update
765 prototypes.
766 (bidi_push_it, bidi_pop_it): Add prototypes.
767 (struct iterator_stack_entry): New members bidi_p,
768 paragraph_embedding, and from_disp_prop_p.
769 (struct it): Member bidi_p is now a bit field 1 bit wide.
770 (bidi_shelve_cache, bidi_unshelve_cache): Declare
771 prototypes.
772
773 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
774 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
775 and vector-like objects.
776
777 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
778 cache around display iteration.
779
780 * window.c (Fwindow_end, window_scroll_pixel_based)
781 (displayed_window_lines, Frecenter): Save and restore the bidi
782 cache around display iteration.
783
784 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
785
786 * editfns.c (Fdelete_region): Clarify the use of the named
787 parameters (bug#6788).
788
789 2011-07-14 Martin Rudalics <rudalics@gmx.at>
790
791 * indent.c (Fvertical_motion): Set and restore w->pointm when
792 saving and restoring the window's buffer (Bug#9006).
793
794 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
795
796 * editfns.c (Fstring_to_char): Clarify just what is returned
797 (bug#6576). Text by Eli Zaretskii.
798
799 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
800
801 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
802
803 2011-07-13 Eli Zaretskii <eliz@gnu.org>
804
805 * buffer.c (mmap_find): Fix a typo.
806
807 2011-07-13 Johan Bockgård <bojohan@gnu.org>
808
809 Fix execution of x selection hooks.
810 * xselect.c (Qx_lost_selection_functions)
811 (Qx_sent_selection_functions): New vars.
812 (syms_of_xselect): DEFSYM them.
813 (x_handle_selection_request): Pass Qx_sent_selection_functions
814 rather than Vx_sent_selection_functions to Frun_hook_with_args.
815 (x_handle_selection_clear,x_clear_frame_selections):
816 Pass Qx_lost_selection_functions rather than
817 Vx_lost_selection_functions to Frun_hook_with_args.
818
819 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
820
821 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
822 The old code sometimes used this field without initializing it.
823
824 * alloc.c (gc_sweep): Don't read past end of array.
825 In theory, the old code could also have corrupted Emacs internals,
826 though it'd be very unlikely.
827
828 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
829
830 * character.c (Fcharacterp): Don't advertise optional ignored
831 argument. (Bug#4026)
832
833 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
834
835 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
836 key" (bug#4257).
837
838 * window.c (Fset_window_start): Doc fix (bug#4199).
839 (Fset_window_hscroll): Ditto.
840
841 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
842
843 Fix minor new problems caught by GCC 4.6.1.
844 * term.c (init_tty): Remove unused local.
845 * xsettings.c (store_monospaced_changed): Define this function only
846 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
847 not used otherwise.
848
849 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
850
851 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
852
853 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
854
855 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
856 are the mini-buffer and the echo area (bug#3320).
857
858 * term.c (init_tty): Remove support for supdup, c10 and perq
859 terminals, which are no longer supported (bug#1482).
860
861 2011-07-10 Johan Bockgård <bojohan@gnu.org>
862
863 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
864
865 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
866
867 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
868 for non-popups (Bug#3642).
869
870 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
871
872 * alloc.c (reset_malloc_hooks): Protoize.
873 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
874 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
875 * cm.c (losecursor): Likewise.
876 * data.c (fmod): Likewise.
877 * dispnew.c (swap_glyphs_in_rows): Likewise.
878 * emacs.c (memory_warning_signal): Likewise.
879 * floatfns.c (float_error): Likewise.
880 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
881 (otf_open, font_otf_capability, generate_otf_features)
882 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
883 Likewise.
884 * image.c (pbm_read_file): Likewise.
885 * indent.c (string_display_width): Likewise.
886 * intervals.c (check_for_interval, search_for_interval)
887 (inc_interval_count, count_intervals, root_interval)
888 (adjust_intervals_for_insertion, make_new_interval): Likewise.
889 * lread.c (defalias): Likewise.
890 * ralloc.c (r_alloc_check): Likewise.
891 * regex.c (set_image_of_range_1, set_image_of_range)
892 (regex_grow_registers): Likewise.
893 * sysdep.c (strerror): Likewise.
894 * termcap.c (valid_filename_p, tprint, main): Likewise.
895 * tparam.c (main): Likewise.
896 * unexhp9k800.c (run_time_remap, save_data_space)
897 (update_file_ptrs, read_header, write_header, calculate_checksum)
898 (copy_file, copy_rest, display_header): Likewise.
899 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
900 Likewise.
901 * xdisp.c (check_it): Likewise.
902 * xfaces.c (register_color, unregister_color, unregister_colors):
903 Likewise.
904 * xfns.c (print_fontset_result): Likewise.
905 * xrdb.c (member, fatal, main): Likewise.
906
907 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
908
909 Fix minor problems found by static checking (Bug#9031).
910 * chartab.c (char_table_set_range, map_sub_char_table):
911 Remove unused locals.
912 (uniprop_table): Now static.
913 * composite.c (_work_char): Remove unused static var.
914
915 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
916
917 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
918
919 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
920
921 * gtkutil.c (qttip_cb): Remove code without function.
922
923 2011-07-09 Eli Zaretskii <eliz@gnu.org>
924
925 * w32.c (pthread_sigmask): New stub.
926
927 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
928
929 Use pthread_sigmask, not sigprocmask (Bug#9010).
930 sigprocmask is portable only for single-threaded applications, and
931 Emacs can be multi-threaded when it uses GTK.
932 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
933 (LIBES): Use it.
934 * callproc.c (Fcall_process):
935 * process.c (create_process):
936 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
937 Use pthread_sigmask, not sigprocmask.
938
939 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
940
941 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
942 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
943 wrong (Bug#8591).
944
945 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
946
947 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
948 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
949 (xg_hide_tooltip): Fix comment.
950
951 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
952 in registerServicesMenuSendTypes.
953 (validRequestorForSendType): Don't check ns_return_types.
954
955 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
956 ns_return_type.
957
958 2011-07-08 Jason Rumney <jasonr@gnu.org>
959
960 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
961 frame struct members of non-existent frames (Bug#6284).
962
963 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
964
965 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
966 variable firstTime not needed on OSX >= 10.6.
967 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
968 >= 10.5. Use setKnobProportion, setDoubleValue.
969
970 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
971 (MAC_OS_X_VERSION_10_5): Define if not defined.
972 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
973 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
974 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
975
976 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
977 cString and lossyCString on OSX >= 10.4
978
979 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
980 sizeToFit on OSX >= 10.2.
981
982 * nsimage.m (allocInitFromFile): Don't use deprecated method
983 bestRepresentationForDevice on OSX >= 10.6.
984
985 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
986 to avoid warning.
987
988 * emacs.c: Declare unexec_init_emacs_zone.
989
990 * nsgui.h: Fix compiler warning about gnulib redefining verify.
991
992 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
993
994 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
995 on svcsMenu (Bug#8842).
996
997 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
998 ns_return_types.
999 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1000
1001 * nsterm.m (QUTF8_STRING): Declare.
1002 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1003 (validRequestorForSendType): Return type is (id).
1004 Change indexOfObjectIdenticalTo to indexOfObject.
1005 Check if we have local selection before returning self (Bug#8842).
1006 (writeSelectionToPasteboard): Put local selection into paste board
1007 if we have a local selection (Bug#8842).
1008 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1009
1010 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1011 (ns_get_local_selection): Declare.
1012
1013 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1014
1015 * keymap.c (describe_map_tree): Don't insert a double newline at
1016 the end of the buffer (bug#1169) and return whether we inserted
1017 something.
1018
1019 * callint.c (Fcall_interactively): Change "reading args" to
1020 "providing args" to try to clarify what it does (bug#1010).
1021
1022 2011-07-07 Kenichi Handa <handa@m17n.org>
1023
1024 * composite.c (composition_compute_stop_pos): Ignore a static
1025 composition starting before CHARPOS (Bug#8915).
1026
1027 * xdisp.c (handle_composition_prop): Likewise.
1028
1029 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1030
1031 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1032 (Bug#9015)
1033
1034 2011-07-07 Kenichi Handa <handa@m17n.org>
1035
1036 * character.h (unicode_category_t): New enum type.
1037
1038 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1039 (Qchar_code_property_table): New variable.
1040 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1041 (UNIPROP_COMPRESSED_FORM_P): New macros.
1042 (char_table_ascii): Uncompress the compressed values.
1043 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1044 Uncompress the compressed values.
1045 (sub_char_table_ref_and_range): Likewise.
1046 (char_table_ref_and_range): Uncompress the compressed values.
1047 (sub_char_table_set): New arg is_uniprop. Callers changed.
1048 Uncompress the compressed values.
1049 (sub_char_table_set_range): Args changed. Callers changed.
1050 (char_table_set_range): Adjuted for the above change.
1051 (map_sub_char_table): Delete args default_val and parent. Add arg
1052 top. Give decoded values to a Lisp function.
1053 (map_char_table): Adjusted for the above change. Give decoded
1054 values to a Lisp function. Gcpro more variables.
1055 (uniprop_table_uncompress)
1056 (uniprop_decode_value_run_length): New functions.
1057 (uniprop_decoder, uniprop_decoder_count): New variables.
1058 (uniprop_get_decoder, uniprop_encode_value_character)
1059 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1060 New functions.
1061 (uniprop_encoder, uniprop_encoder_count): New variables.
1062 (uniprop_get_encoder, uniprop_table)
1063 (Funicode_property_table_internal, Fget_unicode_property_internal)
1064 (Fput_unicode_property_internal): New functions.
1065 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1066 Sunicode_property_table_internal, Sget_unicode_property_internal,
1067 and Sput_unicode_property_internal. Defvar_lisp
1068 char-code-property-alist.
1069
1070 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
1071 Vunicode_category_table.
1072
1073 * font.c (font_range): Adjusted for the change of
1074 Vunicode_category_table.
1075
1076 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1077
1078 * m/iris4d.h: Remove file, move contents ...
1079 * s/irix6-5.h: ... here.
1080
1081 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1082
1083 Remove unportable assumption about struct layout (Bug#8884).
1084 * alloc.c (mark_buffer):
1085 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1086 (clone_per_buffer_values): Don't assume that
1087 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1088 This isn't true in general, and it's particularly not true
1089 if Emacs is configured with --with-wide-int.
1090 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1091 New macros, used in the buffer.c change.
1092
1093 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1094
1095 * xsettings.c: Use both GConf and GSettings if both are available.
1096 (store_config_changed_event): Add comment.
1097 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1098 (store_tool_bar_style_changed): New functions.
1099 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1100 (struct xsettings): Move font inside HAVE_XFT.
1101 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1102 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
1103 Move inside HAVE_XFT.
1104 (something_changed_gsettingsCB): Renamed from something_changedCB.
1105 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1106 also.
1107 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1108 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1109 (something_changed_gconfCB): Renamed from something_changedCB.
1110 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1111 (parse_settings): Move check for font inside HAVE_XFT.
1112 (read_settings, apply_xft_settings): Add comment.
1113 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1114 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1115 call store_font_name_changed.
1116 (xft_settings_event): Add comment.
1117 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1118 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1119 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1120 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1121 (xsettings_initialize): Call init_gsettings last.
1122 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
1123 comment.
1124
1125 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1126
1127 Random fixes. E.g., (random) never returned negative values.
1128 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1129 subseconds part to the entropy, as that's a bit more random.
1130 Prefer signed to unsigned, since the signedness doesn't matter and
1131 in general we prefer signed. When given a limit, use a
1132 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1133 latter isn't right if USE_2_TAGS_FOR_INTS.
1134 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1135 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1136
1137 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1138
1139 * textprop.c (text_property_stickiness):
1140 Obey Vtext_property_default_nonsticky.
1141 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1142 * w32fns.c (syms_of_w32fns):
1143 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1144
1145 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1146
1147 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1148 This is more efficient than Ffile_directory_p and avoids a minor race.
1149
1150 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1151
1152 * buffer.c (Foverlay_put): Say what the return value is
1153 (bug#7835).
1154
1155 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1156 is a directory before asking whether to use the file name
1157 (bug#7564).
1158 (barf_or_query_if_file_exists): Make the "File is a directory"
1159 error be more correct.
1160
1161 * fns.c (Frequire): Remove the mention of the .gz files, since
1162 that's installation-specific, but keep the mention of
1163 `get-load-suffixes'.
1164
1165 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1166
1167 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1168 Report string overflow if the output is too long.
1169
1170 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1171
1172 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1173 (syms_of_gnutls): Remove duplicate DEFSYM for
1174 Qgnutls_bootprop_verify_hostname_error, an error for
1175 Qgnutls_bootprop_verify_error (which is no longer used).
1176
1177 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1178 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1179 Also (re)move comments that are misplaced or no longer relevant.
1180
1181 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1182
1183 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1184
1185 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1186
1187 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1188 and background color parameters if they have been changed.
1189
1190 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1191
1192 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1193
1194 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1195
1196 * xsettings.c (SYSTEM_FONT): Define only when used.
1197 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1198
1199 * keymap.c (access_keymap_1): Now static.
1200
1201 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1202
1203 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1204 leave any prefix arg for the up event (Bug#1586).
1205
1206 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1207
1208 * lread.c (syms_of_lread): Mention single symbols defined by
1209 `defvar' or `defconst' (bug#7154).
1210
1211 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1212 (Frequire): Mention get-load-suffixes.
1213
1214 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1215
1216 * window.h (window): Remove clone_number slot.
1217 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1218 Remove.
1219 (make_parent_window, make_window, saved_window)
1220 (Fset_window_configuration, save_window_save): Don't deal with
1221 clone numbers.
1222 * buffer.c (Qclone_number): Remove declaration.
1223 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1224
1225 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1226
1227 Add multiple inheritance to keymaps.
1228 * keymap.c (Fmake_composed_keymap): New function.
1229 (Fset_keymap_parent): Simplify.
1230 (fix_submap_inheritance): Remove.
1231 (access_keymap_1): New function extracted from access_keymap to handle
1232 embedded parents and handle lists of maps.
1233 (access_keymap): Use it.
1234 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1235 (Fcopy_keymap): Handle embedded parents.
1236 (Fcommand_remapping, define_as_prefix): Simplify.
1237 (Fkey_binding): Simplify.
1238 (syms_of_keymap): Move minibuffer-local-completion-map,
1239 minibuffer-local-filename-completion-map,
1240 minibuffer-local-must-match-map, and
1241 minibuffer-local-filename-must-match-map to Elisp.
1242 (syms_of_keymap): Defsubr make-composed-keymap.
1243 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1244 (parse_menu_item): Trivial simplification.
1245
1246 2011-07-01 Glenn Morris <rgm@gnu.org>
1247
1248 * Makefile.in (SETTINGS_LIBS): Fix typo.
1249
1250 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1251
1252 * coding.c (Fencode_coding_string): Record the last coding system
1253 used, as the function doc string says (bug#8738).
1254
1255 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1256
1257 * xsettings.c (store_monospaced_changed): Take new font as arg and
1258 check for change against current_mono_font.
1259 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1260 (emacs_settings_constructor, emacs_settings_get_property)
1261 (emacs_settings_set_property, emacs_settings_class_init)
1262 (emacs_settings_init, gsettings_obj): Remove.
1263 (something_changedCB): New function for HAVE_GSETTINGS.
1264 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1265 with value as argument.
1266 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1267 g_settings_new (Bug#8967). Do not create gsettings_obj.
1268 Remove calls to g_settings_bind. Connect something_changedCB to
1269 "changed".
1270
1271 * xgselect.c: Add defined (HAVE_GSETTINGS).
1272 (xgselect_initialize): Ditto.
1273
1274 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1275 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1276 xg_select.
1277
1278 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1279
1280 * eval.c (struct backtrace): Simplify and port the data structure.
1281 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1282 signed bit field, as this assumption is not portable and it makes
1283 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1284 "char debug_on_exit : 1" as this is not portable either; instead,
1285 use the portable "unsigned int debug_on_exit : 1". Remove unused
1286 member evalargs. Remove obsolete comments about cc bombing out.
1287
1288 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1289
1290 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1291 Let HAVE_GSETTINGS override HAVE_GCONF.
1292 (store_monospaced_changed): New function.
1293 (EMACS_SETTINGS): A new type derived from GObject to handle
1294 GSettings notifications.
1295 (emacs_settings_constructor, emacs_settings_get_property)
1296 (emacs_settings_set_property, emacs_settings_class_init):
1297 New functions.
1298 (gsettings_client, gsettings_obj): New variables.
1299 (GSETTINGS_SCHEMA): New define.
1300 (something_changedCB): Call store_monospaced_changed.
1301 (init_gsettings): New function.
1302 (xsettings_initialize): Call init_gsettings.
1303 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1304 to NULL.
1305
1306 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
1307 GCONF_CFLAGS/LIBS.
1308
1309 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1310
1311 * window.c (resize_root_window, grow_mini_window)
1312 (shrink_mini_window): Rename Qresize_root_window to
1313 Qwindow_resize_root_window and Qresize_root_window_vertically to
1314 Qwindow_resize_root_window_vertically.
1315
1316 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1317
1318 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1319
1320 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1321
1322 * makefile.w32-in: Redesign dependencies so they reflect more
1323 clearly which files are directly included by each source file,
1324 and not through other includes.
1325
1326 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1327
1328 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1329 (sort_overlays, overlay_strings): When an overlay's clone number
1330 matches the window's clone number process the overlay even if
1331 the overlay's window property doesn't match the current window.
1332
1333 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1334 (Fwindow_hchild): Rename to Fwindow_left_child.
1335 (Fwindow_next): Rename to Fwindow_next_sibling.
1336 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1337 (resize_window_check): Rename to window_resize_check.
1338 (resize_window_apply): Rename to window_resize_apply.
1339 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1340 (Fdelete_other_windows_internal, resize_frame_windows)
1341 (Fsplit_window_internal, Fdelete_window_internal)
1342 (grow_mini_window, shrink_mini_window)
1343 (Fresize_mini_window_internal): Fix callers accordingly.
1344
1345 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1346
1347 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1348 (emacs_fixed_set_min_size): Remove.
1349 (emacs_fixed_new): Take frame as argument.
1350
1351 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1352 (_EmacsFixedPrivate): Remove minwidth/height.
1353 Add struct frame *f.
1354 (emacs_fixed_init): Initialize priv->f.
1355 (get_parent_class, emacs_fixed_set_min_size): Remove.
1356 (emacs_fixed_new): Set priv->f to argument.
1357 (emacs_fixed_get_preferred_width)
1358 (emacs_fixed_get_preferred_height): Use min_width/height from
1359 frames size_hint to set minimum and natural (Bug#8919).
1360 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1361 and use min_width/height from frames size_hint to set
1362 min_width/height (Bug#8919).
1363
1364 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1365 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1366 Fix indentation.
1367
1368 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1369
1370 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1371 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1372 called at ZV.
1373
1374 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1375
1376 * process.c (wait_reading_process_output): Bypass select if
1377 waiting for a cell while ignoring keyboard input, and input is
1378 pending. Suggested by Jan Djärv (Bug#8869).
1379
1380 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1381
1382 Use gnulib's dup2 module instead of rolling our own.
1383 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1384
1385 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1386
1387 * dispnew.c (scrolling_window): Before scrolling, turn off a
1388 mouse-highlight in the window being scrolled.
1389
1390 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1391
1392 Move DEFSYM to lisp.h and use everywhere.
1393
1394 * character.h (DEFSYM): Move declaration...
1395 * lisp.h (DEFSYM): ...here.
1396
1397 * gnutls.c:
1398 * minibuf.c:
1399 * w32menu.c:
1400 * w32proc.c:
1401 * w32select.c: Don't include character.h.
1402
1403 * alloc.c (syms_of_alloc):
1404 * buffer.c (syms_of_buffer):
1405 * bytecode.c (syms_of_bytecode):
1406 * callint.c (syms_of_callint):
1407 * casefiddle.c (syms_of_casefiddle):
1408 * casetab.c (init_casetab_once):
1409 * category.c (init_category_once, syms_of_category):
1410 * ccl.c (syms_of_ccl):
1411 * cmds.c (syms_of_cmds):
1412 * composite.c (syms_of_composite):
1413 * dbusbind.c (syms_of_dbusbind):
1414 * dired.c (syms_of_dired):
1415 * dispnew.c (syms_of_display):
1416 * doc.c (syms_of_doc):
1417 * editfns.c (syms_of_editfns):
1418 * emacs.c (syms_of_emacs):
1419 * eval.c (syms_of_eval):
1420 * fileio.c (syms_of_fileio):
1421 * fns.c (syms_of_fns):
1422 * frame.c (syms_of_frame):
1423 * fringe.c (syms_of_fringe):
1424 * insdel.c (syms_of_insdel):
1425 * keymap.c (syms_of_keymap):
1426 * lread.c (init_obarray, syms_of_lread):
1427 * macros.c (syms_of_macros):
1428 * msdos.c (syms_of_msdos):
1429 * print.c (syms_of_print):
1430 * process.c (syms_of_process):
1431 * search.c (syms_of_search):
1432 * sound.c (syms_of_sound):
1433 * syntax.c (init_syntax_once, syms_of_syntax):
1434 * terminal.c (syms_of_terminal):
1435 * textprop.c (syms_of_textprop):
1436 * undo.c (syms_of_undo):
1437 * w32.c (globals_of_w32):
1438 * window.c (syms_of_window):
1439 * xdisp.c (syms_of_xdisp):
1440 * xfaces.c (syms_of_xfaces):
1441 * xfns.c (syms_of_xfns):
1442 * xmenu.c (syms_of_xmenu):
1443 * xsettings.c (syms_of_xsettings):
1444 * xterm.c (syms_of_xterm): Use DEFSYM.
1445
1446 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1447
1448 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1449
1450 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1451
1452 Integer and buffer overflow fixes (Bug#8873).
1453
1454 * print.c (printchar, strout): Check for string overflow.
1455 (PRINTPREPARE, printchar, strout):
1456 Don't set size unless allocation succeeds.
1457
1458 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1459 for sizes. Check for string overflow more accurately.
1460 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1461
1462 * macros.c: Integer and buffer overflow fixes.
1463 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1464 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1465 Use ptrdiff_t, not int, for sizes.
1466 Don't increment bufsize until after realloc succeeds.
1467 Check for size-calculation overflow.
1468 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1469
1470 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1471
1472 * lread.c: Integer overflow fixes.
1473 (read_integer): Radix is now EMACS_INT, not int,
1474 to improve quality of diagnostics for out-of-range radices.
1475 Calculate buffer size correctly for out-of-range radices.
1476 (read1): Check for integer overflow in radices, and in
1477 read-circle numbers.
1478 (read_escape): Avoid int overflow.
1479 (Fload, openp, read_buffer_size, read1)
1480 (substitute_object_recurse, read_vector, read_list, map_obarray):
1481 Use ptrdiff_t, not int, for sizes.
1482 (read1): Use EMACS_INT, not int, for sizes.
1483 Check for size overflow.
1484
1485 * image.c (cache_image): Check for size arithmetic overflow.
1486
1487 * lread.c: Integer overflow issues.
1488 (saved_doc_string_size, saved_doc_string_length)
1489 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1490 Now ptrdiff_t, not int.
1491 (read1): Don't assume doc string length fits in int. Check for
1492 out-of-range doc string lengths.
1493 (read_list): Don't assume file position fits in int.
1494 (read_escape): Check for hex character overflow.
1495
1496 2011-06-22 Leo Liu <sdl.web@gmail.com>
1497
1498 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1499 Move to minibuffer.el.
1500
1501 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1502
1503 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1504 The following patches are for when GLYPH_DEBUG && !XASSERT.
1505 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1506 * dispnew.c (flush_stdout):
1507 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1508 Mark as externally visible.
1509 * dispnew.c (check_window_matrix_pointers): Now static.
1510 * dispnew.c (window_to_frame_vpos):
1511 * xfns.c (unwind_create_frame):
1512 * xterm.c (x_check_font): Remove unused local.
1513 * scroll.c (CHECK_BOUNDS):
1514 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1515 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1516 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1517 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1518 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1519 Now static.
1520 (debug_method_add): Use va_list and vsprintf rather than relying
1521 on undefined behavior with wrong number of arguments.
1522 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1523 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1524 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1525 since we're not interested in debugging glyphs with old libraries.
1526 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1527 GCC 4.6.0's static checking.
1528
1529 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1530
1531 Integer overflow and signedness fixes (Bug#8873).
1532 A few related buffer overrun fixes, too.
1533
1534 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1535
1536 * dispextern.h (struct face.stipple):
1537 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1538 (x_bitmap_mask, x_allocate_bitmap_record)
1539 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1540 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1541 (x_create_bitmap_from_xpm_data):
1542 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1543 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1544 (.bitmaps_last):
1545 * xfaces.c (load_pixmap):
1546 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1547 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1548 (.bitmaps_last, struct x_output.icon_bitmap):
1549 Use ptrdiff_t, not int, for bitmap indexes.
1550 (x_allocate_bitmap_record): Check for size overflow.
1551 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1552
1553 Use ptrdiff_t, not int, for overlay counts.
1554 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1555 * editfns.c (overlays_around, get_pos_property):
1556 * textprop.c (get_char_property_and_overlay):
1557 * xdisp.c (next_overlay_change, note_mouse_highlight):
1558 * xfaces.c (face_at_buffer_position):
1559 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1560 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1561 (Fnext_overlay_change, Fprevious_overlay_change)
1562 (mouse_face_overlay_overlaps, Foverlays_in):
1563 Use ptrdiff_t, not int, for sizes.
1564 (overlays_at, overlays_in): Check for size-calculation overflow.
1565
1566 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1567
1568 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1569 (x_session_initialize): Do not assume string length fits in int.
1570
1571 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1572 This is unlikely, but can occur if DPI is outlandish.
1573
1574 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1575 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1576
1577 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1578 * xrdb.c (magic_file_p, search_magic_path):
1579 Omit last arg SUFFIX; it was always 0. All callers changed.
1580 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1581
1582 * xfont.c (xfont_match): Avoid need for strlen.
1583
1584 * xfns.c: Don't assume strlen fits in int.
1585 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1586
1587 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1588 not unsigned long, as we prefer signed integers. All callers changed.
1589 Detect integer overflow in repeat count.
1590 (message_dolog): Don't assume print length fits in 39 bytes.
1591 (display_mode_element): Don't assume strlen fits in int.
1592
1593 * termcap.c: Don't assume sizes fit in int and never overflow.
1594 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1595 (gobble_line): Check for size-calculation overflow.
1596
1597 * minibuf.c (Fread_buffer):
1598 * lread.c (intern, intern_c_string):
1599 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1600 Don't assume string length fits in int.
1601
1602 * keyboard.c (parse_tool_bar_item):
1603 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1604
1605 * font.c: Don't assume string length fits in int.
1606 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1607 Use ptrdiff_t, not int.
1608 (font_intern_prop): Don't assume string length fits in int.
1609 Don't assume integer property fits in fixnum.
1610 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1611
1612 * filelock.c: Fix some buffer overrun and integer overflow issues.
1613 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1614 Reformulate so as not to need the command string.
1615 Invoke gzip -cd rather than gunzip, as it's more portable.
1616 (lock_info_type, lock_file_1, lock_file):
1617 Don't assume pid_t and time_t fit in unsigned long.
1618 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1619 (current_lock_owner): Prefer signed type for sizes.
1620 Use memcpy, not strncpy, where memcpy is what is really wanted.
1621 Don't assume (via atoi) that time_t and pid_t fit in int.
1622 Check for time_t and/or pid_t out of range, e.g., via a network share.
1623 Don't alloca where an auto var works fine.
1624
1625 * fileio.c: Fix some integer overflow issues.
1626 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1627 Don't assume string length fits in int.
1628 (directory_file_name): Don't assume string length fits in long.
1629 (make_temp_name): Don't assume pid fits in int, or that its print
1630 length is less than 20.
1631
1632 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1633
1634 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1635
1636 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1637
1638 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1639 We prefer signed integers, even for size calculations.
1640
1641 * emacs.c: Don't assume string length fits in 'int'.
1642 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1643 (main): Don't invoke strlen when not needed.
1644
1645 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1646 (XD_DEBUG_MESSAGE): Don't waste a byte.
1647
1648 * callproc.c (getenv_internal_1, getenv_internal)
1649 (Fgetenv_internal):
1650 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1651
1652 * lread.c (invalid_syntax): Omit length argument.
1653 All uses changed. This doesn't fix a bug, but it simplifies the
1654 code away from its former Hollerith-constant appearance, and it's
1655 one less 'int' to worry about when looking at integer-overflow issues.
1656 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1657
1658 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1659 This didn't break anything, but it didn't help either.
1660 It's confusing to put a bogus integer in a place where the actual
1661 value does not matter.
1662 (LIST_END_P): Remove unused macro and its bogus comment.
1663 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1664
1665 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1666 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1667 implementation.
1668 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1669 We prefer signed types, and the value cannot exceed the EMACS_INT
1670 range anyway (because otherwise the length would not be representable).
1671 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1672 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1673 This avoids a GCC warning when WIDE_EMACS_INT.
1674
1675 * indent.c (sane_tab_width): New function.
1676 (current_column, scan_for_column, Findent_to, position_indentation)
1677 (compute_motion): Use it. This is just for clarity.
1678 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1679
1680 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1681
1682 * lisp.h (lint_assume): New macro.
1683 * composite.c (composition_gstring_put_cache):
1684 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1685
1686 * editfns.c, insdel.c:
1687 Omit unnecessary forward decls, to simplify future changes.
1688
1689 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1690
1691 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1692
1693 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1694 Use much-faster test for byte-length change.
1695 Don't assume string byte-length fits in 'int'.
1696 Check that character arg fits in 'int'.
1697 (mapcar1): Declare byte as byte, for clarity.
1698
1699 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1700
1701 * fns.c (concat): Catch string overflow earlier.
1702 Do not rely on integer wraparound.
1703
1704 * dispextern.h (struct it.overlay_strings_charpos)
1705 (struct it.selective): Now EMACS_INT, not int.
1706 * xdisp.c (forward_to_next_line_start)
1707 (back_to_previous_visible_line_start)
1708 (reseat_at_next_visible_line_start, next_element_from_buffer):
1709 Don't arbitrarily truncate the value of 'selective' to int.
1710
1711 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1712
1713 * composite.c: Don't truncate sizes to 'int'.
1714 (composition_gstring_p, composition_reseat_it)
1715 (composition_adjust_point): Use EMACS_INT, not int.
1716 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1717 not EMACS_UINT, for indexes.
1718
1719 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1720
1721 * buffer.c: Include <verify.h>.
1722 (struct sortvec.priority, struct sortstr.priority):
1723 Now EMACS_INT, not int.
1724 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1725 (struct sortstr.size, record_overlay_string)
1726 (struct sortstrlist.size, struct sortlist.used):
1727 Don't truncate size to int.
1728 (record_overlay_string): Check for size-calculation overflow.
1729 (init_buffer_once): Check at compile-time, not run-time.
1730
1731 2011-06-22 Jim Meyering <meyering@redhat.com>
1732
1733 Don't leak an XBM-image-sized buffer
1734 * image.c (xbm_load): Free the image buffer after using it.
1735
1736 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1737
1738 Port to Sun C.
1739 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1740 that Sun C diagnosed.
1741 * fns.c (secure_hash): Fix pointer signedness issue.
1742 * intervals.c (static_offset_intervals): New function.
1743 (offset_intervals): Use it.
1744
1745 2011-06-21 Leo Liu <sdl.web@gmail.com>
1746
1747 * deps.mk (fns.o):
1748 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1749 sha512.h.
1750
1751 * fns.c (secure_hash): Rename from crypto_hash_function and change
1752 the first arg to accept symbols.
1753 (Fsecure_hash): New primitive.
1754 (syms_of_fns): New symbols.
1755
1756 2011-06-20 Deniz Dogan <deniz@dogan.se>
1757
1758 * process.c (Fset_process_buffer): Clarify return value in
1759 docstring.
1760
1761 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1762
1763 * dispnew.c (add_window_display_history): Use BVAR.
1764
1765 * xdisp.c (debug_method_add): Use BVAR.
1766 (check_window_end, dump_glyph_matrix, dump_glyph)
1767 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1768
1769 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1770 Likewise.
1771
1772 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1773 check till after the cache is created in init_frame_faces.
1774
1775 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1776
1777 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1778
1779 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1780
1781 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1782 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1783 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1784
1785 Improve buffer-overflow checking (Bug#8873).
1786 * fileio.c (Finsert_file_contents):
1787 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1788 Remove the old (too-loose) buffer overflow checks.
1789 They weren't needed, since make_gap checks for buffer overflow.
1790 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1791 The old code merely checked for Emacs fixnum overflow, and relied
1792 on undefined (wraparound) behavior. The new code avoids undefined
1793 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1794
1795 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1796 Tune. Don't use wider integers than needed. Don't use alloca.
1797 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1798
1799 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1800
1801 * insdel.c, lisp.h (buffer_overflow): New function.
1802 (insert_from_buffer_1, replace_range, replace_range_2):
1803 * insdel.c (make_gap_larger):
1804 * editfns.c (Finsert_char):
1805 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1806
1807 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1808
1809 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1810
1811 Integer overflow and signedness fixes (Bug#8873).
1812
1813 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1814 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1815
1816 * fileio.c: Don't assume EMACS_INT fits in off_t.
1817 (emacs_lseek): New static function.
1818 (Finsert_file_contents, Fwrite_region): Use it.
1819 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1820
1821 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1822
1823 * fns.c: Don't overflow int when computing a list length.
1824 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1825 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1826 truncation on 64-bit hosts. Check for QUIT every
1827 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1828 faster and is responsive enough.
1829 (Flength): Report an error instead of overflowing an integer.
1830 (Fsafe_length): Return a float if the value is not representable
1831 as a fixnum. This shouldn't happen except in contrived situations.
1832 (Fnthcdr, Fsort): Don't assume list length fits in int.
1833 (Fcopy_sequence): Don't assume vector length fits in int.
1834
1835 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1836 (header_size, word_size): New constants.
1837 (allocate_vectorlike): Don't check size overflow here.
1838 (allocate_vector): Check it here instead, since this is the only
1839 caller of allocate_vectorlike that could cause overflow.
1840 Check that the new vector's length is representable as a fixnum.
1841
1842 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1843 The previous code was bogus. For example, next_almost_prime (32)
1844 returned 39, which is undesirable as it is a multiple of 3; and
1845 next_almost_prime (24) returned 25, which is a multiple of 5 so
1846 why was the code bothering to check for multiples of 7?
1847
1848 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1849
1850 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1851
1852 Variadic C functions now count arguments with ptrdiff_t.
1853 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1854 Back then I didn't know that the Emacs coding style prefers signed int.
1855 Also, in the meantime I found a few more instances where arguments
1856 were being counted with int, which may truncate counts on 64-bit
1857 machines, or EMACS_INT, which may be unnecessarily wide.
1858 * lisp.h (struct Lisp_Subr.function.aMANY)
1859 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1860 Arg counts are now ptrdiff_t, not size_t.
1861 All variadic functions and their callers changed accordingly.
1862 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1863 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1864 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1865 * callint.c (Fcall_interactively): Check arg count for overflow,
1866 to avoid potential buffer overrun. Use signed char, not 'int',
1867 for 'varies' array, so that we needn't bother to check its size
1868 calculation for overflow.
1869 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1870 * eval.c (apply_lambda):
1871 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1872 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1873 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1874
1875 * callint.c (Fcall_interactively): Don't use index var as event count.
1876
1877 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1878 * mem-limits.h (SIZE): Remove; no longer used.
1879
1880 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1881
1882 Remove unnecessary casts.
1883 * xterm.c (x_term_init):
1884 * xfns.c (x_set_border_pixel):
1885 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1886 These aren't needed now that we assume ANSI C.
1887
1888 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1889 It's more likely to cause problems (due to unsigned overflow)
1890 than to cure them.
1891
1892 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1893
1894 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1895
1896 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1897
1898 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1899
1900 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1901
1902 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1903
1904 GLYPH_CODE_FACE returns EMACS_INT, not int.
1905 * dispextern.h (merge_faces):
1906 * xfaces.c (merge_faces):
1907 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1908 Don't assume EMACS_INT fits in int.
1909
1910 * character.h (CHAR_VALID_P): Remove unused parameter.
1911 * fontset.c, lisp.h, xdisp.c: All uses changed.
1912
1913 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1914
1915 * fns.c (concat): Minor tuning based on overflow analysis.
1916 This doesn't fix any bugs. Use int to hold character, instead
1917 of constantly refetching from Emacs object. Use XFASTINT, not
1918 XINT, for value known to be a character. Don't bother comparing
1919 a single byte to 0400, as it's always less.
1920
1921 * floatfns.c (Fexpt):
1922 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1923
1924 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1925 for characters.
1926
1927 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1928
1929 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1930 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1931 incorrectly succeed when S was a string, because 4294967386 was
1932 truncated before it was used.
1933
1934 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1935 Otherwise, an out-of-range integer could cause undefined behavior
1936 on a 64-bit host.
1937
1938 * composite.c: Use int, not EMACS_INT, for characters.
1939 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1940 EMACS_INT, for values that are known to be in character range.
1941 This doesn't fix any bugs but is the usual style inside Emacs and
1942 may generate better code on 32-bit machines.
1943
1944 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1945 This is for reasons similar to the recent CHAR_STRING fix.
1946 * charset.c (Fencode_char): Check that character arg is actually
1947 a character. Pass an int to ENCODE_CHAR.
1948 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1949 wider than 'int', as a compile-time check to prevent future regressions
1950 in this area.
1951
1952 * character.c (char_string): Remove unnecessary casts.
1953
1954 Make sure a 64-bit char is never passed to CHAR_STRING.
1955 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1956 by silently ignoring the top 32 bits, allowing some values
1957 that were far too large to be valid characters.
1958 * character.h: Include <verify.h>.
1959 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1960 arguments are no wider than unsigned, as a compile-time check
1961 to prevent future regressions in this area.
1962 * data.c (Faset):
1963 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1964 (Fsubst_char_in_region):
1965 * fns.c (concat):
1966 * xdisp.c (decode_mode_spec_coding):
1967 Adjust to CHAR_STRING's new requirement.
1968 * editfns.c (Finsert_char, Fsubst_char_in_region):
1969 * fns.c (concat): Check that character args are actually
1970 characters. Without this test, these functions did the wrong
1971 thing with wildly out-of-range values on 64-bit hosts.
1972
1973 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1974 These casts should not be needed on 32-bit hosts, either.
1975 * keyboard.c (read_char):
1976 * lread.c (Fload): Remove casts to unsigned.
1977
1978 * lisp.h (UNSIGNED_CMP): New macro.
1979 This fixes comparison bugs on 64-bit hosts.
1980 (ASCII_CHAR_P): Use it.
1981 * casefiddle.c (casify_object):
1982 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1983 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1984 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1985 * dispextern.h (FACE_FROM_ID):
1986 * keyboard.c (read_char): Use UNSIGNED_CMP.
1987
1988 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1989 not to EMACS_INT, to avoid GCC warning.
1990
1991 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1992
1993 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1994 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1995 isn't needed on 32-bit machines.
1996
1997 * buffer.c (Fgenerate_new_buffer_name):
1998 Use EMACS_INT for count, not int.
1999 (advance_to_char_boundary): Return EMACS_INT, not int.
2000
2001 * data.c (Qcompiled_function): Now static.
2002
2003 * window.c (window_body_lines): Now static.
2004
2005 * image.c (gif_load): Rename local to avoid shadowing.
2006
2007 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2008 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2009 * alloc.c (make_save_value): Integer argument is now of type
2010 ptrdiff_t, not int.
2011 (mark_object): Use ptrdiff_t, not int.
2012 * lisp.h (pD): New macro.
2013 * print.c (print_object): Use it.
2014
2015 * alloc.c: Use EMACS_INT, not int, to count objects.
2016 (total_conses, total_markers, total_symbols, total_vector_size)
2017 (total_free_conses, total_free_markers, total_free_symbols)
2018 (total_free_floats, total_floats, total_free_intervals)
2019 (total_intervals, total_strings, total_free_strings):
2020 Now EMACS_INT, not int. All uses changed.
2021 (Fgarbage_collect): Compute overall total using a double, so that
2022 integer overflow is less likely to be a problem. Check for overflow
2023 when converting back to an integer.
2024 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2025 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2026 These were 'int' variables that could overflow on 64-bit hosts;
2027 they were never used, so remove them instead of repairing them.
2028 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2029 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2030 Previously, this ceilinged at INT_MAX, but that doesn't work on
2031 64-bit machines.
2032 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2033
2034 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2035 (allocate_vectorlike): Check for ptrdiff_t overflow.
2036 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2037 when a (possibly-narrower) signed value would do just as well.
2038 We prefer using signed arithmetic, to avoid comparison confusion.
2039
2040 * alloc.c: Catch some string size overflows that we were missing.
2041 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2042 for convenience in STRING_BYTES_MAX.
2043 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2044 The definition here is exact; the one in lisp.h was approximate.
2045 (allocate_string_data): Check for string overflow. This catches
2046 some instances we weren't catching before. Also, it catches
2047 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2048 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2049 and ptrdiff_t and EMACS_INT are both 64 bits.
2050
2051 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2052 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2053 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
2054
2055 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2056
2057 * alloc.c (Fmake_string): Check for out-of-range init.
2058
2059 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2060
2061 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2062
2063 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2064
2065 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2066 xg_get_default_scrollbar_width.
2067
2068 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2069 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2070 (style_changed_cb): Call update_theme_scrollbar_width and call
2071 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2072 all frames (Bug#8505).
2073 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2074 Call gtk_window_set_resizable if HAVE_GTK3.
2075 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2076 and height if HAVE_GTK3 (Bug#8505).
2077 (scroll_bar_width_for_theme): New variable.
2078 (update_theme_scrollbar_width): New function.
2079 (xg_get_default_scrollbar_width): Move code to
2080 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2081 (xg_initialize): Call update_theme_scrollbar_width.
2082
2083 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2084
2085 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2086
2087 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2088
2089 * frame.c (make_frame): Call other_buffer_safely instead of
2090 other_buffer.
2091
2092 * window.c (temp_output_buffer_show): Call display_buffer with
2093 second argument Vtemp_buffer_show_specifiers and reset latter
2094 immediately after the call.
2095 (Vtemp_buffer_show_specifiers): New variable.
2096 (auto_window_vscroll_p, next_screen_context_lines)
2097 (Vscroll_preserve_screen_position): Remove leading asterisks from
2098 doc-strings.
2099
2100 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2101
2102 Fix minor problems found by GCC 4.6.0 static checking.
2103 * buffer.c (Qclone_number): Remove for now, as it's unused.
2104 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2105 (record_buffer): Remove unused local.
2106 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2107 (set_frame_buffer_list): Remove; unused.
2108 * frame.h (other_visible_frames): Remove decl.
2109 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2110 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2111 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2112 if HAVE_GPM.
2113 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2114 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2115 Define only if HAVE_GPM.
2116 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2117 (update_hints_inhibit): Remove; never set. All uses removed.
2118 * widgetprv.h (emacsFrameClassRec): Remove decl.
2119 * window.c (delete_deletable_window): Now returns void, since it
2120 wasn't returning anything.
2121 (compare_window_configurations): Remove unused locals.
2122 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2123 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2124 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2125 the same widths as pointers. This follows up on the 2011-05-06 patch.
2126 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2127 * xterm.h: Likewise.
2128 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2129
2130 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2131
2132 * makefile.w32-in: Update dependencies.
2133 (LISP_H): Add lib/intprops.h.
2134
2135 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2136
2137 * image.c (gif_load): Add animation frame delay to the metadata.
2138 (syms_of_image): Use DEFSYM. New symbol `delay'.
2139
2140 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2141
2142 * window.c (delete_deletable_window): Re-add.
2143 (Fset_window_configuration): Rewrite to handle dead buffers and
2144 consequently deletable windows.
2145 (window_tree, Fwindow_tree): Remove. Supply functionality in
2146 window.el.
2147 (compare_window_configurations): Simplify code.
2148
2149 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2150
2151 * image.c (imagemagick_load_image): Fix type mismatch.
2152 (Fimagemagick_types): Likewise.
2153
2154 * window.h (replace_buffer_in_windows): Declare.
2155
2156 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2157
2158 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2159 Qclone_number. Remove external declaration of Qdelete_window.
2160 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2161 code.
2162 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
2163 Qbuffer_list_update_hook if allowed.
2164 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2165 buffer list implementation.
2166 (other_buffer_safely): New function.
2167 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2168 calls to replace_buffer_in_windows and
2169 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2170 if allowed.
2171 (record_buffer): Inhibit quitting and rewrite using quittable
2172 functions. Run Qbuffer_list_update_hook if allowed.
2173 (Frecord_buffer, Funrecord_buffer): New functions.
2174 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
2175 switch-to-buffer to window.el.
2176 (bury-buffer): Move to window.el.
2177 (Vbuffer_list_update_hook): New variable.
2178
2179 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2180 section.
2181
2182 * window.h (resize_frame_windows): Move up in code.
2183 (Fwindow_frame): Remove EXFUN.
2184 (replace_buffer_in_all_windows): Remove prototype.
2185 (replace_buffer_in_windows_safely): Add prototype.
2186
2187 * window.c: Declare Qdelete_window static again. Move down
2188 declaration of select_count.
2189 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2190 (Fother_window): Move to window.el.
2191 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2192 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2193 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2194 window.el.
2195 (replace_buffer_in_windows): Implement by calling
2196 Qreplace_buffer_in_windows.
2197 (replace_buffer_in_all_windows): Remove with some functionality
2198 moved into replace_buffer_in_windows_safely.
2199 (replace_buffer_in_windows_safely): New function.
2200 (select_window_norecord, select_frame_norecord): Move in front
2201 of run_window_configuration_change_hook. Remove now obsolete
2202 declarations.
2203 (Fset_window_buffer): Rewrite doc-string. Call
2204 Qrecord_window_buffer.
2205 (keys_of_window): Move binding for other-window to window.el.
2206
2207 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2208
2209 * dispextern.h (struct image): Replace data member, whose int_val
2210 and ptr_val fields were not used by anything, with a single
2211 lisp_val object.
2212
2213 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2214 (gif_clear_image, gif_load, imagemagick_load_image)
2215 (gs_clear_image, gs_load): Callers changed.
2216
2217 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2218
2219 * buffer.h: Include <time.h>, for time_t.
2220 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2221
2222 Fix minor problems found by static checking.
2223
2224 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2225
2226 Make identifiers static if they are not used in other modules.
2227 * data.c (Qcompiled_function, Qframe, Qvector):
2228 * image.c (QimageMagick, Qsvg):
2229 * minibuf.c (Qmetadata):
2230 * window.c (resize_window_check, resize_root_window): Now static.
2231 * window.h (resize_window_check, resize_root_window): Remove decls.
2232
2233 * window.c (window_deletion_count, delete_deletable_window):
2234 Remove; unused.
2235 (window_body_lines): Now static.
2236 (Fdelete_other_windows_internal): Mark vars as initialized.
2237 Make sure 'resize_failed' is initialized.
2238 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2239 (resize_window_apply): Remove unused local.
2240 * window.h (delete_deletable_window): Remove decl.
2241
2242 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2243 (imagemagick_load_image): Fix pointer signedness problem by changing
2244 last arg from unsigned char * to char *. All uses changed.
2245 Also, fix a local for similar reasons.
2246 Remove unused locals. Remove locals to avoid shadowing.
2247 (fn_rsvg_handle_free): Remove; unused.
2248 (svg_load, svg_load_image): Fix pointer signedness problem.
2249 (imagemagick_load_image): Don't use garbage pointer image_wand.
2250
2251 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2252
2253 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2254
2255 * image.c (gif_load): Fix omitted cast error introduced by
2256 2011-06-06 change.
2257
2258 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2259
2260 * window.h (resize_proportionally, orig_total_lines)
2261 (orig_top_line): Remove from window structure.
2262 (set_window_height, set_window_width, change_window_heights)
2263 (Fdelete_window): Remove prototypes.
2264 (resize_frame_windows): Remove duplicate declaration.
2265
2266 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2267
2268 * window.h (resize_frame_windows, resize_window_check)
2269 (delete_deletable_window, resize_root_window)
2270 (resize_frame_windows): Declare prototypes.
2271
2272 * window.c (resize_window_apply): Make definition be "static" to
2273 match the prototype.
2274
2275 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2276
2277 * window.c: Remove declarations of Qwindow_size_fixed,
2278 window_min_size_1, window_min_size_2, window_min_size,
2279 size_window, window_fixed_size_p, enlarge_window, delete_window.
2280 Remove static from declaration of Qdelete_window, it's
2281 temporarily needed by Fbury_buffer.
2282 (replace_window): Don't assign orig_top_line and
2283 orig_total_lines.
2284 (Fdelete_window, delete_window): Remove. Window deletion is
2285 handled by window.el.
2286 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
2287 Fdelete_window calls with calls to Qdelete_window.
2288 (Fdelete_other_windows): Remove. Deleting other windows is
2289 handled by window.el.
2290 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2291 handled in window.el.
2292 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2293 Window minimum sizes are handled in window.el.
2294 (shrink_windows, size_window, set_window_height)
2295 (set_window_width, change_window_heights, window_height)
2296 (window_width, CURBEG, CURSIZE, enlarge_window)
2297 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2298 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2299 handled in window.el.
2300 (make_dummy_parent): Rename to make_parent_window and give it a
2301 second argument horflag.
2302 (make_window): Don't set resize_proportionally any more.
2303 (Fsplit_window): Remove. Windows are split in window.el.
2304 (save_restore_action, save_restore_orig_size)
2305 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2306 Resize mini windows in window.el.
2307 (grow_mini_window, shrink_mini_window): Implement by calling
2308 Qresize_root_window_vertically, resize_window_check and
2309 resize_window_apply.
2310 (saved_window, Fset_window_configuration, save_window_save): Do
2311 not handle orig_top_line, orig_total_lines, and
2312 resize_proportionally.
2313 (window_min_height, window_min_width): Move to window.el.
2314 (keys_of_window): Move bindings for delete-other-windows,
2315 split-window, delete-window and enlarge-window to window.el.
2316
2317 * buffer.c: Temporarily extern Qdelete_window.
2318 (Fbury_buffer): Temporarily call Qdelete_window instead of
2319 Fdelete_window (Fbury_buffer will move to window.el soon).
2320
2321 * frame.c (set_menu_bar_lines_1): Remove code handling
2322 orig_top_line and orig_total_lines.
2323
2324 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2325 set_window_height but set heights directly.
2326 (change_frame_size_1): Use resize_frame_windows.
2327
2328 * xdisp.c (init_xdisp): Don't use set_window_height but set
2329 heights directly.
2330
2331 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
2332 resize_frame_windows instead of change_window_heights and run
2333 run_window_configuration_change_hook.
2334
2335 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2336 instead of change_window_heights and run
2337 run_window_configuration_change_hook.
2338
2339 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2340
2341 * window.c (replace_window): Rename second argument REPLACEMENT to
2342 NEW. New third argument SETFLAG. Rewrite.
2343 (delete_window, make_dummy_parent): Call replace_window with
2344 third argument 1.
2345 (window_list_1): Move down in code.
2346 (run_window_configuration_change_hook): Move set_buffer part
2347 before select_frame_norecord part in order to unwind correctly.
2348 Rename count1 to count.
2349 (recombine_windows, delete_deletable_window, resize_root_window)
2350 (Fdelete_other_windows_internal)
2351 (Frun_window_configuration_change_hook, make_parent_window)
2352 (resize_window_check, resize_window_apply, Fresize_window_apply)
2353 (resize_frame_windows, Fsplit_window_internal)
2354 (Fdelete_window_internal, Fresize_mini_window_internal): New
2355 functions.
2356 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2357
2358 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2359
2360 * window.h (window): Add some new members to window structure -
2361 normal_lines, normal_cols, new_total, new_normal, clone_number,
2362 splits, nest, prev_buffers, next_buffers.
2363 (WINDOW_TOTAL_SIZE): Move here from window.c.
2364 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2365
2366 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2367 Remove.
2368 (make_dummy_parent): Set new members of windows structure.
2369 (make_window): Move down in code. Handle new members of window
2370 structure.
2371 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2372 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2373 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2374 (Fset_window_prev_buffers, Fwindow_next_buffers)
2375 (Fset_window_next_buffers, Fset_window_clone_number): New
2376 functions.
2377 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2378 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2379 Doc-string fixes.
2380 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2381 Argument WINDOW can be now internal window too.
2382 (Fwindow_use_time): Move up in code.
2383 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2384 Rewrite doc-string.
2385 (Fset_window_configuration, saved_window)
2386 (Fcurrent_window_configuration, save_window_save): Handle new
2387 members of window structure.
2388 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2389 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2390 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2391 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2392 Qget_mru_window, Qresize_root_window,
2393 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2394 Qauto_buffer_name; staticpro them.
2395
2396 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2397
2398 * window.c (Fwindow_total_size, Fwindow_left_column)
2399 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2400 (Fwindow_list_1): New functions.
2401 (window_box_text_cols): Replace with window_body_cols.
2402 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2403 window_body_cols instead of window_box_text_cols.
2404 (delete_window, Fset_window_configuration): Call
2405 delete_all_subwindows with window as argument.
2406 (delete_all_subwindows): Take a window as argument and not a
2407 structure. Rewrite.
2408 (window_loop): Remove handling of GET_LRU_WINDOW and
2409 GET_LARGEST_WINDOW.
2410 (Fget_lru_window, Fget_largest_window): Move to window.el.
2411
2412 * window.h: Extern window_body_cols instead of
2413 window_box_text_cols. delete_all_subwindows now takes a
2414 Lisp_Object as argument.
2415
2416 * indent.c (compute_motion, Fcompute_motion): Use
2417 window_body_cols instead of window_box_text_cols.
2418
2419 * frame.c (delete_frame): Call delete_all_subwindows with root
2420 window as argument.
2421
2422 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2423
2424 * fns.c (Fputhash): Document return value.
2425
2426 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2427
2428 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2429
2430 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2431
2432 Cons<->int and similar integer overflow fixes (Bug#8794).
2433
2434 Check for overflow when converting integer to cons and back.
2435 * charset.c (Fdefine_charset_internal, Fdecode_char):
2436 Use cons_to_unsigned to catch overflow.
2437 (Fencode_char): Use INTEGER_TO_CONS.
2438 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2439 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2440 * data.c (long_to_cons, cons_to_long): Remove.
2441 (cons_to_unsigned, cons_to_signed): New functions.
2442 These signal an error for invalid or out-of-range values.
2443 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2444 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2445 * font.c (Ffont_variation_glyphs):
2446 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2447 * lisp.h: Include <intprops.h>.
2448 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2449 (cons_to_signed, cons_to_unsigned): New decls.
2450 (long_to_cons, cons_to_long): Remove decls.
2451 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2452 (Fprimitive_undo): Use CONS_TO_INTEGER.
2453 * xfns.c (Fx_window_property): Likewise.
2454 * xselect.c: Include <limits.h>.
2455 (x_own_selection, selection_data_to_lisp_data):
2456 Use INTEGER_TO_CONS.
2457 (x_handle_selection_request, x_handle_selection_clear)
2458 (x_get_foreign_selection, Fx_disown_selection_internal)
2459 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2460 (lisp_data_to_selection_data): Use cons_to_unsigned.
2461 (x_fill_property_data): Use cons_to_signed.
2462 Report values out of range.
2463
2464 Check for buffer and string overflow more precisely.
2465 * buffer.h (BUF_BYTES_MAX): New macro.
2466 * lisp.h (STRING_BYTES_MAX): New macro.
2467 * alloc.c (Fmake_string):
2468 * character.c (string_escape_byte8):
2469 * coding.c (coding_alloc_by_realloc):
2470 * doprnt.c (doprnt):
2471 * editfns.c (Fformat):
2472 * eval.c (verror):
2473 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2474 since they may not be the same number.
2475 * editfns.c (Finsert_char):
2476 * fileio.c (Finsert_file_contents):
2477 Likewise for BUF_BYTES_MAX.
2478
2479 * image.c: Use ptrdiff_t, not int, for sizes.
2480 (slurp_file): Switch from int to ptrdiff_t.
2481 All uses changed.
2482 (slurp_file): Check that file size fits in both size_t (for
2483 malloc) and ptrdiff_t (for sanity and safety).
2484
2485 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2486 if b->modtime has its maximal value.
2487
2488 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2489
2490 Don't assume time_t can fit into int.
2491 * buffer.h (struct buffer.modtime): Now time_t, not int.
2492 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2493 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2494
2495 Minor fixes for signed vs unsigned integers.
2496 * character.h (MAYBE_UNIFY_CHAR):
2497 * charset.c (maybe_unify_char):
2498 * keyboard.c (read_char, reorder_modifiers):
2499 XINT -> XFASTINT, since the integer must be nonnegative.
2500 * ftfont.c (ftfont_spec_pattern):
2501 * keymap.c (access_keymap, silly_event_symbol_error):
2502 XUINT -> XFASTINT, since the integer must be nonnegative.
2503 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2504 since it makes no difference and we prefer signed.
2505 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2506 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2507 nonnegative.
2508
2509 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2510
2511 * window.h (Fwindow_frame): Declare.
2512
2513 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2514
2515 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2516 (SPARE_MEMORY): Always define.
2517 (LARGE_REQUEST): Remove.
2518 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2519
2520 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2521
2522 * lisp.h: Move EXFUNS for Fframe_root_window,
2523 Fframe_first_window and Fset_frame_selected_window to window.h.
2524
2525 * window.h: Move EXFUNS for Fframe_root_window,
2526 Fframe_first_window and Fset_frame_selected_window here from
2527 lisp.h.
2528
2529 * frame.c (Fwindow_frame, Fframe_first_window)
2530 (Fframe_root_window, Fframe_selected_window)
2531 (Fset_frame_selected_window): Move to window.c.
2532 (Factive_minibuffer_window): Move to minibuf.c.
2533 (Fother_visible_frames_p): New function.
2534
2535 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2536
2537 * window.c (decode_window, decode_any_window): Move up in code.
2538 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2539 (inhibit_frame_unsplittable): Remove unused variable.
2540 (Fwindow_buffer): Move up and rewrite doc-string.
2541 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2542 (Fwindow_prev): New functions.
2543 (Fwindow_frame): Move here from frame.c. Accept any window as
2544 argument.
2545 (Fframe_root_window, Fframe_first_window)
2546 (Fframe_selected_window): Move here from frame.c. Accept frame
2547 or arbitrary window as argument. Update doc-strings.
2548 (Fminibuffer_window): Move up in code.
2549 (Fwindow_minibuffer_p): Move up in code and simplify.
2550 (Fset_frame_selected_window): Move here from frame.c.
2551 Marginal rewrite.
2552 (Fselected_window, select_window, Fselect_window): Move up in
2553 code. Minor doc-string fixes.
2554
2555 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2556
2557 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2558 Do not assume that spare memory exists; that assumption is valid
2559 only if SYSTEM_MALLOC.
2560 (LARGE_REQUEST): New macro, so that the issue of large requests
2561 is separated from the issue of spare memory.
2562
2563 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2564
2565 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2566 format. (Bug#8806)
2567
2568 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2569
2570 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2571 before statements.
2572
2573 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2574
2575 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2576
2577 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2578
2579 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2580 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2581
2582 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2583
2584 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2585
2586 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2587
2588 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2589 (x_clipboard_manager_save): Add return value.
2590 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2591 New error handlers.
2592 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2593 Obey Vx_select_enable_clipboard_manager. Catch errors in
2594 x_clipboard_manager_save (Bug#8779).
2595 (Vx_select_enable_clipboard_manager): New variable.
2596 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2597
2598 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2599
2600 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2601
2602 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2603
2604 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2605 in the current matrix if keep_current_p is non-zero.
2606
2607 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2608
2609 * bidi.c (bidi_level_of_next_char): Fix last change.
2610
2611 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2612
2613 Support bidi reordering of text covered by display properties.
2614
2615 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2616 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2617 (bidi_cache_search, bidi_cache_iterator_state)
2618 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2619 (bidi_level_of_next_char, bidi_move_to_visually_next):
2620 Support character positions inside a run of characters covered by a
2621 display string.
2622 (bidi_paragraph_init, bidi_resolve_explicit_1)
2623 (bidi_level_of_next_char): Call bidi_fetch_char and
2624 bidi_fetch_char_advance instead of FETCH_CHAR and
2625 FETCH_CHAR_ADVANCE.
2626 (bidi_init_it): Initialize new members.
2627 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2628 definitions.
2629 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2630 instead of using explicit *_CHAR codes.
2631 (bidi_resolve_explicit, bidi_resolve_weak):
2632 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2633 bidirectional text is supported only in multibyte buffers.
2634 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2635 it to initialize the frame_window_p member of struct bidi_it.
2636 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2637 (bidi_resolve_explicit, bidi_resolve_weak)
2638 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2639 bidi_it->nchars is non-positive.
2640 (bidi_level_of_next_char): Don't try to lookup the cache for the
2641 next/previous character if nothing is cached there yet, or if we
2642 were just reseat()'ed to a new position.
2643
2644 * xdisp.c (set_cursor_from_row): Set start and stop points
2645 according to the row's direction when priming the loop that looks
2646 for the glyph on which to display cursor.
2647 (single_display_spec_intangible_p): Function deleted.
2648 (display_prop_intangible_p): Reimplement to call
2649 handle_display_spec instead of single_display_spec_intangible_p.
2650 Accept 3 additional arguments needed by handle_display_spec.
2651 This fixes incorrect cursor motion across display property with complex
2652 values: lists, `(when COND...)' forms, etc.
2653 (single_display_spec_string_p): Support property values that are
2654 lists with the argument STRING its top-level element.
2655 (display_prop_string_p): Fix the condition for processing a
2656 property that is a list to be consistent with handle_display_spec.
2657 (handle_display_spec): New function, refactored from the
2658 last portion of handle_display_prop.
2659 (compute_display_string_pos): Accept additional argument
2660 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2661 value of a `display' property is a "replacing spec".
2662 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2663 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2664 the display property, but just return a value indicating whether
2665 the display property will replace the characters it covers.
2666 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2667 frame_window_p members of struct bidi_it.
2668 (compute_display_string_pos, compute_display_string_end):
2669 New functions.
2670 (push_it): Accept second argument POSITION, where pop_it should
2671 jump to continue iteration.
2672 (reseat_1): Initialize bidi_it.disp_pos.
2673
2674 * keyboard.c (adjust_point_for_property): Adjust the call to
2675 display_prop_intangible_p to its new signature.
2676
2677 * dispextern.h (struct bidi_it): New member frame_window_p.
2678 (bidi_init_it): Update prototypes.
2679 (display_prop_intangible_p): Update prototype.
2680 (compute_display_string_pos, compute_display_string_end):
2681 Declare prototypes.
2682 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2683 EMACS_INT.
2684
2685 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2686
2687 Malloc failure behavior now depends on size of allocation.
2688 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2689 * lisp.h: Change signatures accordingly.
2690 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2691 All callers changed. (Bug#8762)
2692
2693 * gnutls.c: Use Emacs's memory allocators.
2694 Without this change, the gnutls library would invoke malloc etc.
2695 directly, which causes problems on non-SYNC_INPUT hosts, and which
2696 runs afoul of improving memory_full behavior. (Bug#8761)
2697 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2698 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2699 xfree instead of the default malloc, realloc, free.
2700 (Fgnutls_boot): No need to check for memory allocation failure,
2701 since xmalloc does that for us.
2702
2703 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2704 * category.c (hash_get_category_set):
2705 * ccl.c (ccl_driver):
2706 * charset.c (Fdefine_charset_internal):
2707 * charset.h (struct charset.hash_index):
2708 * composite.c (get_composition_id, gstring_lookup_cache)
2709 (composition_gstring_put_cache):
2710 * composite.h (struct composition.hash_index):
2711 * dispextern.h (struct image.hash):
2712 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2713 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2714 (hashfn_equal, hashfn_user_defined, make_hash_table)
2715 (maybe_resize_hash_table, hash_lookup, hash_put)
2716 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2717 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2718 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2719 * image.c (make_image, search_image_cache, lookup_image)
2720 (xpm_put_color_table_h):
2721 * lisp.h (struct Lisp_Hash_Table):
2722 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2723 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2724 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2725 * alloc.c (allocate_vectorlike):
2726 Check for overflow in vector size calculations.
2727 * ccl.c (ccl_driver):
2728 Check for overflow when converting EMACS_INT to int.
2729 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2730 need to be updated by these changes.
2731 * fns.c (make_hash_table, maybe_resize_hash_table):
2732 Check for integer overflow with large hash tables.
2733 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2734 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2735 (SXHASH_REDUCE): New macro.
2736 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2737 Use it instead of discarding useful hash info with large hash values.
2738 (sxhash_float): New function.
2739 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2740 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2741 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2742 Rewrite to use FIXNUM_BITS, as this simplifies things.
2743 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2744 Adjust signatures to match updated version of code.
2745 (consing_since_gc): Now EMACS_INT, since a single hash table can
2746 use more than INT_MAX bytes.
2747
2748 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2749
2750 Make it possible to build with GCC-4.6+ -O2 -flto.
2751
2752 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2753
2754 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2755
2756 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2757 Call minibuffer-inactive-mode.
2758
2759 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2760
2761 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2762 Update dependencies.
2763
2764 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2765
2766 * data.c (init_data): Remove code for UTS, this system is not
2767 supported anymore.
2768
2769 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2770
2771 Don't force ./temacs to start in terminal mode.
2772
2773 * frame.c (make_initial_frame): Initialize faces in all cases, not
2774 only when CANNOT_DUMP is defined.
2775 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2776
2777 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2778
2779 * dispnew.c (add_window_display_history): Use const for the string
2780 pointer. Remove declaration, not needed.
2781
2782 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2783
2784 Use 'inline', not 'INLINE'.
2785 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2786 * alloc.c, fontset.c (INLINE): Remove.
2787 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2788 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2789 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2790 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2791 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2792
2793 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2794
2795 Make it possible to run ./temacs.
2796
2797 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2798 syms_of_callproc does the same thing. Remove test for
2799 "initialized", do it in the caller.
2800 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2801
2802 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2803
2804 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2805 (read_minibuf): Use get_minibuffer.
2806 (syms_of_minibuf): Use DEFSYM.
2807 (Qmetadata): New var.
2808 * data.c (Qbuffer): Don't make it static.
2809 (syms_of_data): Use DEFSYM.
2810
2811 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2812
2813 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2814 (CCL_CODE_MIN): New macro.
2815
2816 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2817
2818 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2819
2820 * eval.c (Qdebug): Now static.
2821 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2822 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2823 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2824
2825 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2826
2827 * image.c: Various fixes to ImageMagick code comments.
2828 (Fimagemagick_types): Doc fix.
2829
2830 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2831
2832 Minor fixes prompted by GCC 4.6.0 warnings.
2833
2834 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2835
2836 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2837 (x_clipboard_manager_save_all): Move extern decl to ...
2838 * xterm.h: ... here, so that it can be checked for consistency.
2839
2840 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2841
2842 * xselect.c (x_clipboard_manager_save_frame)
2843 (x_clipboard_manager_save_all): New functions.
2844 (Fx_clipboard_manager_save): Lisp function deleted.
2845
2846 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2847 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2848
2849 * xterm.h: Update prototype.
2850
2851 2011-05-28 William Xu <william.xwl@gmail.com>
2852
2853 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2854 exiting (Bug#8239).
2855
2856 2011-05-28 Jim Meyering <meyering@redhat.com>
2857
2858 Avoid a sign-extension bug in crypto_hash_function.
2859 * fns.c (to_uchar): Define.
2860 (crypto_hash_function): Use it to convert some newly-signed
2861 variables to unsigned, to avoid sign-extension bugs. For example,
2862 without this change, (md5 "truc") would evaluate to
2863 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2864 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2865 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2866
2867 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2868
2869 Integer overflow fixes.
2870
2871 * dbusbind.c: Serial number integer overflow fixes.
2872 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2873 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2874 to hold a serial number that is too large for a fixnum.
2875 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2876 Check for serial numbers out of range. Decode any serial number
2877 that was so large that it became a float. (Bug#8722)
2878
2879 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2880 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2881 Use XFASTINT rather than XUINT when numbers are nonnegative.
2882 (xd_append_arg, Fdbus_method_return_internal):
2883 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2884 arguments, check that Lisp number is nonnegative, rather than
2885 silently wrapping negative numbers around. (Bug#8722)
2886 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2887 (Bug#8722)
2888
2889 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2890
2891 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2892
2893 ccl: add integer overflow checks
2894 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2895 (IN_INT_RANGE): New macros.
2896 (ccl_driver): Use them to check for integer overflow when
2897 decoding a CCL program. Many of the new checks are whether XINT (x)
2898 fits in int; it doesn't always, on 64-bit hosts. The new version
2899 doesn't catch all possible integer overflows, but it's an
2900 improvement. (Bug#8719)
2901
2902 * alloc.c (make_event_array): Use XINT, not XUINT.
2903 There's no need for unsigned here.
2904
2905 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2906 This follows up to the 2011-05-06 change that substituted uintptr_t
2907 for EMACS_INT. This case wasn't caught back then.
2908
2909 Rework Fformat to avoid integer overflow issues.
2910 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2911 now (part of C89). Include <verify.h>.
2912 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2913 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2914 (Fformat): Avoid the prepass trying to compute sizes; it was only
2915 approximate and thus did not catch overflow reliably. Instead, walk
2916 through the format just once, formatting and computing sizes as we go,
2917 checking for integer overflow at every step, and allocating a larger
2918 buffer as needed. Keep track separately whether the format is
2919 multibyte. Keep only the most-recently calculated precision, rather
2920 than them all. Record whether each argument has been converted to
2921 string. Use EMACS_INT, not int, for byte and char and arg counts.
2922 Support field widths and precisions larger than INT_MAX. Avoid
2923 sprintf's undefined behavior with conversion specifications such as %#d
2924 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2925 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2926 formatting out-of-range floating point numbers with int
2927 formats. (Bug#8668)
2928
2929 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2930
2931 * data.c: Avoid integer truncation in expressions involving floats.
2932 * data.c: Include <intprops.h>.
2933 (arith_driver): When there's an integer overflow in an expression
2934 involving floating point, convert the integers to floating point
2935 so that the resulting value does not suffer from catastrophic
2936 integer truncation. For example, on a 64-bit host (* 4
2937 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2938 Do not rely on undefined behavior after integer overflow.
2939
2940 merge count_size_as_multibyte, parse_str_to_multibyte
2941 * character.c, character.h (count_size_as_multibyte):
2942 Rename from parse_str_to_multibyte; all uses changed.
2943 Check for integer overflow.
2944 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2945 since it's now a duplicate of the other. This is more of
2946 a character than a buffer op, so better that it's in character.c.
2947 * fns.c, print.c: Adjust to above changes.
2948
2949 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2950
2951 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2952
2953 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2954
2955 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2956 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2957 (x_clipboard_manager_save): Now static.
2958 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2959
2960 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2961 (crypto_hash_function): Now static.
2962 Fix pointer signedness problems. Avoid unnecessary initializations.
2963
2964 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2965
2966 * termhooks.h (Vselection_alist): Make it terminal-local.
2967
2968 * terminal.c (create_terminal): Initialize it.
2969
2970 * xselect.c: Support for clipboard managers.
2971 (Vselection_alist): Move to termhooks.h as terminal-local var.
2972 (LOCAL_SELECTION): New macro.
2973 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2974 (symbol_to_x_atom): Remove gratuitous arg.
2975 (x_handle_selection_request, lisp_data_to_selection_data)
2976 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2977 (x_own_selection, x_get_local_selection, x_convert_selection):
2978 New arg, specifying work frame. Use terminal-local Vselection_alist.
2979 (some_frame_on_display): Delete unused function.
2980 (Fx_own_selection_internal, Fx_get_selection_internal)
2981 (Fx_disown_selection_internal, Fx_selection_owner_p)
2982 (Fx_selection_exists_p): New optional frame arg.
2983 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2984 (x_handle_selection_clear): Don't treat other terminals with the
2985 same keyboard specially. Use the terminal-local Vselection_alist.
2986 (x_clear_frame_selections): Use Frun_hook_with_args.
2987
2988 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2989
2990 * xterm.h: Add support for those atoms.
2991
2992 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2993
2994 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2995 (converted_selections, conversion_fail_tag): New global variables.
2996 (x_selection_request_lisp_error): Free the above.
2997 (x_get_local_selection): Remove unnecessary code.
2998 (x_reply_selection_request): Args changed; handle arbitrary array
2999 of converted selections stored in converted_selections.
3000 Separate the XChangeProperty and SelectionNotify steps.
3001 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3002 (x_convert_selection): New function.
3003 (x_handle_selection_event): Simplify.
3004 (x_get_foreign_selection): Don't ignore incoming requests while
3005 waiting for an answer; this will fail when we implement
3006 SAVE_TARGETS, and seems unnecessary anyway.
3007 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3008 (Vx_sent_selection_functions): Doc fix.
3009
3010 2011-05-26 Leo Liu <sdl.web@gmail.com>
3011
3012 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3013
3014 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3015
3016 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3017
3018 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3019 for fringe update if it has periodic bitmap.
3020 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3021 and fringe_bitmap_periodic_p.
3022
3023 * fringe.c (get_fringe_bitmap_data): New function.
3024 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3025 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3026 row. Mark glyph row for fringe update if periodicity changed.
3027
3028 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3029 for fringe update unless it has periodic bitmap.
3030
3031 2011-05-25 Kenichi Handa <handa@m17n.org>
3032
3033 * xdisp.c (get_next_display_element): Set correct it->face_id for
3034 a static composition.
3035
3036 2011-05-24 Leo Liu <sdl.web@gmail.com>
3037
3038 * deps.mk (fns.o):
3039 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3040
3041 * fns.c (crypto_hash_function, Fsha1): New function.
3042 (Fmd5): Use crypto_hash_function.
3043 (syms_of_fns): Add Ssha1.
3044
3045 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3046
3047 * gnutls.c: Remove unused macros.
3048 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3049 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3050 Remove macros that are defined and never used.
3051 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3052
3053 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3054
3055 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3056 (Fx_get_selection_internal): Minor cleanup.
3057 (Fx_own_selection_internal): Rename arguments for consistency with
3058 select.el.
3059
3060 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3061
3062 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3063
3064 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3065
3066 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3067
3068 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3069
3070 * dispnew.c (scrolling_window): Don't exclude the case that the
3071 last enabled row in the desired matrix touches the bottom boundary.
3072
3073 2011-05-21 Glenn Morris <rgm@gnu.org>
3074
3075 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3076 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3077 and add some more files.
3078
3079 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3080
3081 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3082 report_file_error introduced by the change from 2011-05-07.
3083
3084 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3085
3086 * systime.h (Time): Define only if emacs is defined.
3087 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3088 where the include path doesn't have X11/X.h by default. See
3089 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3090
3091 2011-05-20 Kenichi Handa <handa@m17n.org>
3092
3093 * composite.c (find_automatic_composition): Fix previous change.
3094
3095 2011-05-20 Glenn Morris <rgm@gnu.org>
3096
3097 * lisp.mk: New file, split from Makefile.in.
3098 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3099 (shortlisp): Remove.
3100 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3101
3102 2011-05-19 Glenn Morris <rgm@gnu.org>
3103
3104 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3105 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3106 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3107 (lisp): Set the order to that of loadup.el.
3108 (shortlisp): Make it a copy of $lisp.
3109 (SOME_MACHINE_LISP): Remove.
3110 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3111 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3112
3113 2011-05-18 Kenichi Handa <handa@m17n.org>
3114
3115 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3116 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3117 (find_automatic_composition): Mostly rewrite for efficiency.
3118
3119 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3120
3121 * makefile.w32-in: Update dependencies.
3122
3123 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3124
3125 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3126 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3127
3128 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3129
3130 Fix some integer overflow issues, such as string length overflow.
3131
3132 * insdel.c (count_size_as_multibyte): Check for string overflow.
3133
3134 * character.c (lisp_string_width): Check for string overflow.
3135 Use EMACS_INT, not int, for string indexes and lengths; in
3136 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3137 the resulting string length overflows an EMACS_INT; instead,
3138 report a string overflow if no precision given. When checking for
3139 precision exhaustion, use a check that cannot possibly have
3140 integer overflow. (Bug#8675)
3141 * character.h (lisp_string_width): Adjust to new signature.
3142
3143 * alloc.c (string_overflow): New function.
3144 (Fmake_string): Use it. This doesn't change behavior, but saves
3145 a few bytes and will simplify future changes.
3146 * character.c (string_escape_byte8): Likewise.
3147 * lisp.h (string_overflow): New decl.
3148
3149 Fixups, following up to the user-interface timestamp change.
3150 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3151 for UI timestamps, instead of unsigned long.
3152 * msdos.c (mouse_get_pos): Likewise.
3153 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3154 * w32gui.h (Time): Define by including "systime.h" rather than by
3155 declaring it ourselves. (Bug#8664)
3156
3157 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3158 * image.c (clear_image_cache): Likewise.
3159
3160 * term.c (term_mouse_position): Don't assume time_t wraparound.
3161
3162 Be more systematic about user-interface timestamps.
3163 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3164 and sometimes 'EMACS_UINT', to represent these timestamps.
3165 This change causes it to use 'Time' uniformly, as that's what X uses.
3166 This makes the code easier to follow, and makes it easier to catch
3167 integer overflow bugs such as Bug#8664.
3168 * frame.c (Fmouse_position, Fmouse_pixel_position):
3169 Use Time, not unsigned long, for user-interface timestamps.
3170 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3171 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3172 * keyboard.h (last_event_timestamp): Likewise.
3173 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3174 * menu.h (xmenu_show): Likewise.
3175 * term.c (term_mouse_position): Likewise.
3176 * termhooks.h (struct input_event.timestamp): Likewise.
3177 (struct terminal.mouse_position_hook): Likewise.
3178 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3179 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3180 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3181 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3182 what it was before.
3183 * menu.h, termhooks.h: Include "systime.h", for Time.
3184
3185 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3186 Don't assume that the difference between two unsigned long values
3187 can fit into an integer. At this point, we know button_down_time
3188 <= event->timestamp, so the difference must be nonnegative, so
3189 there's no need to cast the result if double-click-time is
3190 nonnegative, as it should be; check that it's nonnegative, just in
3191 case. This bug is triggered when events are more than 2**31 ms
3192 apart (about 25 days). (Bug#8664)
3193
3194 * xselect.c (last_event_timestamp): Remove duplicate decl.
3195 (x_own_selection): Remove needless cast to unsigned long.
3196
3197 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3198 that always fit in int. Use a sentinel instead of a counter, to
3199 avoid a temp and to allay GCC's concerns about possible int overflow.
3200 * frame.h (struct frame): Use int for menu_bar_items_used
3201 instead of EMACS_INT, since it always fits in int.
3202
3203 * menu.c (grow_menu_items): Check for int overflow.
3204
3205 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3206
3207 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3208 Before, the code was not consistent. These values cannot exceed
3209 2**31 - 1 so there's no need to make them unsigned.
3210 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3211 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3212 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3213 as modifiers.
3214 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3215
3216 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3217 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3218 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3219 presumably because the widths might not match.
3220
3221 * window.c (size_window): Avoid needless test at loop start.
3222
3223 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3224
3225 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3226
3227 2011-05-12 Drew Adams <drew.adams@oracle.com>
3228
3229 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3230
3231 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3232
3233 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3234 `width' to `bar_area_x' and `bar_area_width', respectively.
3235 (x_scroll_run): Take account of fringe background extension.
3236
3237 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3238 Rename local vars `left' and `width' to `bar_area_x' and
3239 `bar_area_width', respectively.
3240 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3241 background extension.
3242
3243 2011-05-10 Jim Meyering <meyering@redhat.com>
3244
3245 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3246
3247 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3248
3249 * image.c (Finit_image_library): Return t for built-in image types,
3250 like pbm and xbm. (Bug#8640)
3251
3252 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3253
3254 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3255
3256 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3257
3258 * w32console.c (Fset_screen_color): Doc fix.
3259 (Fget_screen_color): New function.
3260 (syms_of_ntterm): Defsubr it.
3261
3262 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3263 unlink the temporary file if Fcall_process didn't create it in the
3264 first place.
3265 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3266 child process will be redirected to a file specified with `:file'.
3267 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3268 cue to call_process_cleanup not to close that handle.
3269
3270 2011-05-07 Ben Key <bkey76@gmail.com>
3271
3272 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3273 one of two shell specific rules, either bootstrap-temacs-CMD or
3274 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3275 to the previous implementation of the bootstrap-temacs rule.
3276 The bootstrap-temacs-CMD rule is similar to the previous
3277 implementation of the bootstrap-temacs rule except that it
3278 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3279 variable.
3280
3281 These changes, along with some changes to nt/configure.bat,
3282 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3283 earlier fix to add support for --cflags and --ldflags options
3284 that include quotes so that it works whether make uses cmd or
3285 sh as the shell.
3286
3287 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3288
3289 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3290 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3291 is a constant.
3292 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3293 a string. Handle both cases.
3294 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3295 (Fdbus_register_method): Use Qinvalid_function.
3296
3297 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3298
3299 * makefile.w32-in: Update dependencies.
3300 (LISP_H): Add inttypes.h and stdin.h.
3301 (PROCESS_H): Add unistd.h.
3302
3303 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3304
3305 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3306 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3307
3308 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3309
3310 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3311
3312 * term.c (vfatal): Remove stray call to va_end.
3313 It's not needed and the C Standard doesn't allow it here anyway.
3314
3315 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3316 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3317
3318 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3319 bytes.
3320
3321 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3322
3323 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3324
3325 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3326
3327 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3328
3329 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3330
3331 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3332 * charset.c (Fdefine_charset_internal): Don't initialize
3333 charset.code_space[15]. The value was garbage, on hosts with
3334 32-bit int (Bug#8600).
3335
3336 * lread.c (read_integer): Be more consistent with string-to-number.
3337 Use string_to_number to do the actual conversion; this avoids
3338 rounding errors and fixes some other screwups. Without this fix,
3339 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3340 (digit_to_number): Move earlier, for benefit of read_integer.
3341 Return -1 if the digit is out of range for the base, -2 if it is
3342 not a digit in any supported base. (Bug#8602)
3343
3344 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3345
3346 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3347 to match comment at start of function. This also removes a
3348 GCC warning about overflow in a 32+64-bit port.
3349
3350 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3351
3352 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3353 Reported by Stefan Monnier in
3354 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3355 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3356 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3357
3358 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3359 (EMACS_UINTPTR): Likewise, with uintptr_t.
3360
3361 * lisp.h: Prefer 64-bit EMACS_INT if available.
3362 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3363 on 32-bit hosts that have 64-bit int, so that they can access
3364 large files.
3365 However, temporarily disable this change unless the temporary
3366 symbol WIDE_EMACS_INT is defined.
3367
3368 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3369
3370 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3371 This removes an assumption that EMACS_INT and long are the same
3372 width as pointers. The assumption is true for Emacs porting targets
3373 now, but we want to make other targets possible.
3374 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3375 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3376 In the rest of the code, change types of integers that hold casted
3377 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3378 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3379 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3380 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3381 No need to cast type when ORing.
3382 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3383 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3384 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3385 assume EMACS_INT is the same width as char *.
3386 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3387 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3388 Remove no-longer-needed casts.
3389 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3390 (xg_tool_bar_help_callback, xg_make_tool_item):
3391 Use EMACS_INTPTR to hold an integer
3392 that will be cast to void *; this can avoid a GCC warning
3393 if EMACS_INT is not the same width as void *.
3394 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3395 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3396 (current_message_1, set_message_1):
3397 Use a local to convert to proper width without a cast.
3398 * xmenu.c (dialog_selection_callback): Likewise.
3399
3400 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3401 Also, don't assume VALBITS / RAND_BITS is less than 5,
3402 and don't rely on undefined behavior when shifting a 1 left into
3403 the sign bit.
3404 * lisp.h (get_random): Change signature to match.
3405
3406 * lread.c (hash_string): Use size_t, not int, for hash computation.
3407 Normally we prefer signed values; but hashing is special, because
3408 it's better to use unsigned division on hash table sizes so that
3409 the remainder is nonnegative. Also, size_t is the natural width
3410 for hashing into memory. The previous code used 'int', which doesn't
3411 retain enough info to hash well into very large tables.
3412 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3413
3414 * dbusbind.c: Don't possibly lose pointer info when converting.
3415 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3416 Use XPNTR rather than XHASH, so that the high-order bits of
3417 the pointer aren't lost when converting through void *.
3418
3419 * eval.c (Fautoload): Don't double-shift a pointer.
3420
3421 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3422
3423 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3424
3425 * gnutls.c (DEF_GNUTLS_FN):
3426 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3427
3428 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3429
3430 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3431 marker. (Bug#8610)
3432
3433 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3434
3435 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3436 New version that can reserve upto 2GB of heap space.
3437
3438 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3439
3440 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3441
3442 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3443
3444 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3445 `gnutls_certificate_set_x509_key_file'.
3446
3447 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3448
3449 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3450 Update dependencies.
3451
3452 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3453
3454 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3455 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3456 Remove unused parameter `fildes'.
3457 * process.c (read_process_output, send_process): Don't pass it.
3458
3459 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3460
3461 Fix previous change: the library cache is defined in w32.c.
3462 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3463 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3464
3465 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3466
3467 Implement dynamic loading of GnuTLS on Windows.
3468
3469 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3470 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3471 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3472 Declare.
3473
3474 * gnutls.c (Qgnutls_dll): Define.
3475 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3476 (gnutls_*): Declare function pointers.
3477 (init_gnutls_functions): New function to initialize function pointers.
3478 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3479 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3480 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3481 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3482 (emacs_gnutls_write, emacs_gnutls_read)
3483 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3484 (Fgnutls_available_p): New function.
3485 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3486 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3487 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3488
3489 * image.c: Include w32.h.
3490 (Vimage_type_cache): Delete.
3491 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3492 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3493 (w32_delayed_load): Move to w32.c.
3494
3495 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3496
3497 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3498 (w32_delayed_load): Move from image.c. When loading a library, record
3499 its filename in the :loaded-from property of the library id.
3500 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3501 Initialize and staticpro them.
3502 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3503
3504 * process.c: Include lisp.h before w32.h, not after.
3505 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3506 instead of gnutls_record_check_pending.
3507
3508 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3509
3510 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3511
3512 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3513 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3514 as passed in.
3515
3516 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3517
3518 * xterm.c (x_set_frame_alpha): Do not set property on anything
3519 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3520
3521 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3522
3523 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3524
3525 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3526
3527 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3528 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3529 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3530 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3531 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3532 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3533 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3534 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3535 (Qgnutls_bootprop_callbacks_verify): Make static.
3536
3537 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3538
3539 * callproc.c: Indentation fixup.
3540
3541 * sysdep.c (wait_for_termination_1): Make static.
3542 (wait_for_termination, interruptible_wait_for_termination):
3543 Move after wait_for_termination_1.
3544
3545 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3546
3547 * sysdep.c (interruptible_wait_for_termination): New function
3548 which is like wait_for_termination, but allows keyboard
3549 interruptions.
3550
3551 * callproc.c (Fcall_process): Add (:file "file") as an option for
3552 the STDOUT buffer.
3553 (Fcall_process_region): Ditto.
3554
3555 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3556
3557 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3558 rather than `XVECTOR (FOO)->size'.
3559
3560 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3561 inttypes.h, as a gnulib replacement is used if it not available in
3562 system headers.
3563
3564 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3565
3566 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3567 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3568 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3569
3570 * coding.c (coding_alloc_by_realloc): Error out if destination
3571 will grow beyond MOST_POSITIVE_FIXNUM.
3572 (decode_coding_emacs_mule): Abort if there isn't enough place in
3573 charbuf for the composition carryover bytes. Reserve an extra
3574 space for up to 2 characters produced in a loop.
3575 (decode_coding_iso_2022): Abort if there isn't enough place in
3576 charbuf for the composition carryover bytes.
3577
3578 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3579
3580 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3581 aborting when %lld or %lll format is passed.
3582 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3583 %llo or %llx format is passed. (Bug#8545)
3584
3585 * window.c (window_scroll_line_based): Use a marker instead of
3586 simple variables to record original value of point. (Bug#7952)
3587
3588 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3589 produced by %s or %c overflows available buffer space. (Bug#8545)
3590
3591 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3592
3593 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3594 (SIZE_MAX): Move defn after all includes, as they might #define it.
3595
3596 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3597
3598 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3599
3600 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3601
3602 * keyboard.c (Qdelayed_warnings_hook): Define.
3603 (command_loop_1): Run `delayed-warnings-hook'
3604 if Vdelayed_warnings_list is non-nil.
3605 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3606 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3607
3608 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3609
3610 * doprnt.c (doprnt): Don't return value smaller than the buffer
3611 size if the message was truncated. (Bug#8545).
3612
3613 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3614
3615 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3616 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3617
3618 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3619
3620 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3621
3622 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3623
3624 * makefile.w32-in: Update dependencies.
3625
3626 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3627
3628 Improve `doprnt' and its usage. (Bug#8545)
3629 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3630 `format_end'. Remove support for %l as a conversion specifier.
3631 Don't use xrealloc. Improve diagnostics when the %l size modifier
3632 is used. Update the commentary.
3633
3634 * eval.c (verror): Simplify calculation of size_t.
3635
3636 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3637 messages.
3638
3639 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3640
3641 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3642 change.
3643
3644 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3645
3646 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3647 This makes this file independent of the recent pseudovector change.
3648
3649 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3650
3651 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3652
3653 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3654 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3655 Remove unused local.
3656 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3657
3658 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3659 GCC 4.6.0 optimizes based on type-based alias analysis.
3660 For example, if b is of type struct buffer * and v of type struct
3661 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3662 != &v->size, and therefore "v->size = 1; b->size = 2; return
3663 v->size;" must therefore return 1. This assumption is incorrect
3664 for Emacs, since it type-puns struct Lisp_Vector * with many other
3665 types. To fix this problem, this patch adds a new type struct
3666 vectorlike_header that documents the constraints on layout of vectors
3667 and pseudovectors, and helps optimizing compilers not get fooled
3668 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3669 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3670 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3671 the size member.
3672 (XSETPVECTYPE): Rewrite in terms of new macro.
3673 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3674 This is a bit clearer, and further avoids the possibility of
3675 undesirable aliasing.
3676 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3677 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3678 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3679 since Lisp_Subr is a special case (no "next" field).
3680 (ASIZE): Now uses header.size rather than size.
3681 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3682 to avoid the hassle of writing XVECTOR (foo)->header.size.
3683 (struct vectorlike_header): New type.
3684 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3685 object, to help avoid aliasing.
3686 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3687 (SUBRP): Likewise, since Lisp_Subr is a special case.
3688 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3689 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3690 (struct Lisp_Hash_Table): Combine first two members into a single
3691 struct vectorlike_header member. All uses of "size" and "next" members
3692 changed to be "header.size" and "header.next".
3693 * buffer.h (struct buffer): Likewise.
3694 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3695 * frame.h (struct frame): Likewise.
3696 * process.h (struct Lisp_Process): Likewise.
3697 * termhooks.h (struct terminal): Likewise.
3698 * window.c (struct save_window_data, struct saved_window): Likewise.
3699 * window.h (struct window): Likewise.
3700 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3701 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3702 * buffer.c (init_buffer_once): Likewise.
3703 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3704 special case.
3705 * process.c (Fformat_network_address): Use local var for size,
3706 for brevity.
3707
3708 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3709
3710 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3711 * data.c (atof): Remove decl; no longer used or needed.
3712 (digit_to_number): Move to lread.c.
3713 (Fstring_to_number): Use new string_to_number function, to be
3714 consistent with how the Lisp reader treats infinities and NaNs.
3715 Do not assume that floating-point numbers represent EMACS_INT
3716 without losing information; this is not true on most 64-bit hosts.
3717 Avoid double-rounding errors, by insisting on integers when
3718 parsing non-base-10 numbers, as the documentation specifies.
3719 * lisp.h (string_to_number): New decl, replacing ...
3720 (isfloat_string): Remove.
3721 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3722 (read1): Do not accept +. and -. as integers; this
3723 appears to have been a coding error. Similarly, do not accept
3724 strings like +-1e0 as floating point numbers. Do not report
3725 overflow for integer overflows unless the base is not 10 which
3726 means we have no simple and reliable way to continue.
3727 Break out the floating-point parsing into a new
3728 function string_to_number, so that Fstring_to_number parses
3729 floating point numbers consistently with the Lisp reader.
3730 (digit_to_number): Move here from data.c. Make it static inline.
3731 (E_CHAR, EXP_INT): Remove, replacing with ...
3732 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3733 (string_to_number): New function, replacing isfloat_string.
3734 This function checks for valid syntax and produces the resulting
3735 Lisp float number too. Rework it so that string-to-number
3736 no longer mishandles examples like "1.0e+". Use strtoumax,
3737 so that overflow for non-base-10 numbers is reported only when
3738 there's no portable and simple way to convert to floating point.
3739
3740 * textprop.c (set_text_properties_1): Rewrite for clarity,
3741 and to avoid GCC warning about integer overflow.
3742
3743 * intervals.h (struct interval): Use EMACS_INT for members
3744 where EMACS_UINT might cause problems. See
3745 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3746 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3747 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3748 All uses changed.
3749 (offset_intervals): Tell GCC not to worry about length overflow
3750 when negating a negative length.
3751
3752 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3753 (overrun_check_free): Likewise.
3754
3755 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3756 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3757 word size.
3758
3759 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3760 (gnutls_make_error): Rename local to avoid shadowing.
3761 (gnutls_emacs_global_deinit): ifdef out; not used.
3762 (Fgnutls_boot): Use const for pointer to readonly storage.
3763 Comment out unused local. Fix pointer signedness problems.
3764
3765 * lread.c (openp): Don't stuff size_t into an 'int'.
3766 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3767 about possible signed overflow.
3768
3769 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3770 (GDK_KEY_g): Don't define if already defined.
3771 (xg_prepare_tooltip): Avoid pointer signedness problem.
3772 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3773
3774 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3775 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3776
3777 * xfns.c (Fx_window_property): Simplify a bit,
3778 to make a bit faster and to avoid GCC 4.6.0 warning.
3779 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3780
3781 * fns.c (internal_equal): Don't assume size_t fits in int.
3782
3783 * alloc.c (compact_small_strings): Tighten assertion a little.
3784
3785 Replace pEd with more-general pI, and fix some printf arg casts.
3786 * lisp.h (pI): New macro, generalizing old pEd macro to other
3787 conversion specifiers. For example, use "...%"pI"d..." rather
3788 than "...%"pEd"...".
3789 (pEd): Remove. All uses replaced with similar uses of pI.
3790 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3791 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3792 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3793 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3794 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3795 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3796 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3797 64-bit hosts.
3798 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3799 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3800 * print.c (safe_debug_print, print_object): Likewise.
3801 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3802 to int.
3803 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3804 avoiding the 0 flag, which is not portable.
3805 * process.c (Fmake_network_process): Use pI to avoid cast.
3806 * region-cache.c (pp_cache): Likewise.
3807 * xdisp.c (decode_mode_spec): Likewise.
3808 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3809 behavior on 64-bit hosts with printf arg.
3810 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3811 (x_stop_queuing_selection_requests): Likewise.
3812 (x_get_window_property): Don't truncate byte count to an 'int'
3813 when tracing.
3814
3815 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3816 here, since it parses constructs like leading '-' and spaces,
3817 which are not wanted; and it overflows with large numbers.
3818 Instead, simply match F[0-9]+, which is what is wanted anyway.
3819
3820 * alloc.c: Remove unportable assumptions about struct layout.
3821 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3822 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3823 (allocate_vectorlike, make_pure_vector): Use the new macros,
3824 plus offsetof, to remove unportable assumptions about struct layout.
3825 These assumptions hold on all porting targets that I know of, but
3826 they are not guaranteed, they're easy to remove, and removing them
3827 makes further changes easier.
3828
3829 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3830 This doesn't fix a bug but makes the code clearer.
3831 (string_overrun_cookie): Now const. Use initializers that
3832 don't formally overflow signed char, to avoid warnings.
3833 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3834 can cause Emacs to crash when string overrun checking is enabled.
3835 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3836 multiple of sizeof (EMACS_INT); it need not be, if
3837 alignof(EMACS_INT) < sizeof (EMACS_INT).
3838 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3839
3840 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3841
3842 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3843
3844 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3845
3846 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3847 supposed to be handshaking. (Bug#8556)
3848 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3849
3850 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3851
3852 * lisp.h (Qdebug): List symbol.
3853 * eval.c (Qdebug): Restore global linkage.
3854 * keyboard.c (debug-on-event): New variable.
3855 (handle_user_signal): Break into debugger when debug-on-event
3856 matches the current signal symbol.
3857
3858 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3859
3860 * alloc.c (check_sblock, check_string_bytes)
3861 (check_string_free_list): Convert to standard C.
3862
3863 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3864
3865 * w32.c (emacs_gnutls_push): Fix typo.
3866
3867 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3868
3869 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3870 "cast to pointer from integer of different size".
3871
3872 Improve doprnt and its use in verror. (Bug#8545)
3873 * doprnt.c (doprnt): Document the set of format control sequences
3874 supported by the function. Use SAFE_ALLOCA instead of always
3875 using `alloca'.
3876
3877 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3878 is one byte too soon. Don't use xrealloc; instead xfree and
3879 xmalloc anew.
3880
3881 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3882
3883 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3884 callbacks stage.
3885
3886 * gnutls.c: Renamed global_initialized to
3887 gnutls_global_initialized. Added internals for the
3888 :verify-hostname-error, :verify-error, and :verify-flags
3889 parameters of `gnutls-boot' and documented those parameters in the
3890 docstring. Start callback support.
3891 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3892 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3893 on error. Return error code.
3894 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3895 (emacs_gnutls_read): Likewise.
3896 (Fgnutls_boot): Return handshake error code.
3897 (emacs_gnutls_handle_error): New function.
3898 (wsaerror_to_errno): Likewise.
3899
3900 * w32.h (emacs_gnutls_pull): Add prototype.
3901 (emacs_gnutls_push): Likewise.
3902
3903 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3904 (emacs_gnutls_push): Likewise.
3905
3906 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3907
3908 * process.c (wait_reading_process_output): Check if GnuTLS
3909 buffered some data internally if no FDs are set for TLS
3910 connections.
3911
3912 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3913 (LIBS): Link to USER_LIBS.
3914 ($(BLD)/gnutls.$(0)): New target.
3915
3916 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3917
3918 * xdisp.c (handle_single_display_spec): Rename the
3919 display_replaced_before_p argument into display_replaced_p, to
3920 make it consistent with the commentary. Fix typos in the
3921 commentary.
3922
3923 * textprop.c (syms_of_textprop): Remove dead code.
3924 (copy_text_properties): Delete obsolete commentary about an
3925 interface that was deleted long ago. Fix typos in the description
3926 of arguments.
3927
3928 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3929 to changes in oldXMenu/XMenu.h from 2011-04-16.
3930 <menu_help_message, prev_menu_help_message>: Constify.
3931 (IT_menu_make_room): menu->help_text is now `const char **';
3932 adjust.
3933
3934 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3935 to changes in oldXMenu/XMenu.h from 2011-04-16.
3936 (struct XMenu): Declare `help_text' `const char **'.
3937
3938 * xfaces.c <Qunspecified>: Make extern again.
3939
3940 * syntax.c: Include sys/types.h before including regex.h, as
3941 required by Posix.
3942
3943 * doc.c (get_doc_string): Improve the format passed to `error'.
3944
3945 * doprnt.c (doprnt): Improve commentary.
3946
3947 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3948
3949 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3950 them with etags.
3951
3952 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3953 changes in globals.h immediately force recompilation.
3954 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3955 $(CURDIR)/s/ms-w32.h.
3956 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3957
3958 * character.c (Fchar_direction): Function deleted.
3959 (syms_of_character): Don't defsubr it.
3960 <char-direction-table>: Deleted.
3961
3962 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3963
3964 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3965 * doprnt.c: Include limits.h.
3966 (SIZE_MAX): New macro.
3967 (doprnt): Return a size_t value. 2nd arg is now size_t.
3968 Many local variables are now size_t instead of int or unsigned.
3969 Improve overflow protection. Support `l' modifier for integer
3970 conversions. Support %l conversion. Don't assume an EMACS_INT
3971 argument for integer conversions and for %c.
3972
3973 * lisp.h (doprnt): Restore prototype.
3974
3975 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3976 $(SRC)/character.h.
3977
3978 * Makefile.in (base_obj): Add back doprnt.o.
3979
3980 * deps.mk (doprnt.o): Add back prerequisites.
3981 (callint.o): Depend on character.h.
3982
3983 * eval.c (internal_lisp_condition_case): Include the handler
3984 representation in the error message.
3985 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3986 when breaking from the loop.
3987
3988 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3989
3990 * callint.c (Fcall_interactively): When displaying error message
3991 about invalid control letter, pass the character's codepoint, not
3992 a pointer to its multibyte form. Improve display of the character
3993 in octal and display also its hex code.
3994
3995 * character.c (char_string): Use %x to display the (unsigned)
3996 codepoint of an invalid character, to avoid displaying a bogus
3997 negative value.
3998
3999 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4000 `error', not SYMBOL_NAME itself.
4001
4002 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4003 character arguments to `error'.
4004
4005 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4006 to `error' in error message about FINAL_CHAR argument. Make sure
4007 FINAL_CHAR is a character, and use %c when it is passed as
4008 argument to `error'.
4009
4010 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4011
4012 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4013
4014 * w32.c: Include <time.h>.
4015 (sys_localtime): New function.
4016
4017 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4018
4019 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4020
4021 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4022
4023 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4024
4025 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4026 zombies (Bug#8467).
4027
4028 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4029
4030 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4031 gl_state.e_property when gl_state.object is Qt.
4032
4033 * insdel.c (make_gap_larger): Remove limitation of buffer size
4034 to <= INT_MAX.
4035
4036 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4037
4038 * xdisp.c (lookup_glyphless_char_display)
4039 (produce_glyphless_glyph): Handle cons cell entry in
4040 glyphless-char-display.
4041 (Vglyphless_char_display): Document it.
4042
4043 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4044 glyphless-char-display.
4045
4046 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4047
4048 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4049
4050 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4051
4052 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4053 definition for no-X builds.
4054
4055 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4056
4057 Static checks with GCC 4.6.0 and non-default toolkits.
4058
4059 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4060
4061 * process.c (keyboard_bit_set): Define only if SIGIO.
4062 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4063 (send_process): Repair possible setjmp clobbering.
4064
4065 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4066
4067 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4068
4069 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4070
4071 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4072 Define only if needed.
4073
4074 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4075 by pacifying GCC about it. Maybe it's time to retire it?
4076 * xfaces.c (USG, __TIMEVAL__): Likewise.
4077
4078 * dispextern.h (struct redisplay_interface): Rename param
4079 to avoid shadowing.
4080 * termhooks.h (struct terminal): Likewise.
4081 * xterm.c (xembed_send_message): Likewise.
4082
4083 * insdel.c (make_gap_smaller): Define only if
4084 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4085
4086 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4087 it.
4088
4089 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4090 so that we aren't warned about unused symbols.
4091
4092 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4093
4094 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4095
4096 * xfns.c (x_real_positions): Mark locals as initialized.
4097
4098 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4099
4100 * xterm.c: Fix problems found by static analysis with other toolkits.
4101 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4102 (x_dispatch_event): Declare static if USE_GTK, and
4103 define if USE_GTK || USE_X_TOOLKIT.
4104 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4105 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4106 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4107 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4108
4109 * xmenu.c (menu_help_callback): Pointer type fixes.
4110 Use const pointers when pointing at readonly data. Avoid pointer
4111 signedness clashes.
4112 (FALSE): Remove unused macro.
4113 (update_frame_menubar): Remove unused decl.
4114
4115 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4116
4117 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4118 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4119 (single_menu_item): Rename local to avoid shadowing.
4120
4121 * keyboard.c (make_lispy_event): Remove unused local var.
4122
4123 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4124 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4125
4126 * bitmaps: Change bitmaps from unsigned char back to the X11
4127 compatible char. Avoid the old compiler warnings about
4128 out-of-range initializers by using, for example, '\xab' rather
4129 than 0xab.
4130
4131 * xgselect.c (xgselect_initialize): Check vs interface
4132 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4133
4134 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4135
4136 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4137 to read-only memory.
4138
4139 * fns.c (vector): Remove; this old hack is no longer needed.
4140
4141 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4142 Remove unused var.
4143 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4144
4145 * xrdb.c (x_load_resources): Omit unused local.
4146
4147 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4148 (x_window): Rename locals to avoid shadowing.
4149 (USG): Use the kludged USG macro, to pacify gcc.
4150
4151 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4152 (x_term_init): Remove local to avoid shadowing.
4153
4154 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4155
4156 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4157 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4158
4159 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4160
4161 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4162
4163 Fix regex.c, syntax.c and friends for buffers > 2GB.
4164 * syntax.h (struct gl_state_s): Declare character position members
4165 EMACS_INT.
4166
4167 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4168
4169 * textprop.c (verify_interval_modification, interval_of):
4170 Declare arguments EMACS_INT.
4171
4172 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4173 EMACS_INT.
4174
4175 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4176
4177 * indent.c (Fvertical_motion): Local variable it_start is now
4178 EMACS_INT.
4179
4180 * regex.c (re_match, re_match_2, re_match_2_internal)
4181 (bcmp_translate, regcomp, regexec, print_double_string)
4182 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4183 (re_compile_pattern, re_exec): Declare arguments and local
4184 variables `size_t' and `ssize_t' and return values `regoff_t', as
4185 appropriate.
4186 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4187 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4188 <compile_stack_type>: `size' and `avail' are now `size_t'.
4189
4190 * regex.h <regoff_t>: Use ssize_t, not int.
4191 (re_search, re_search_2, re_match, re_match_2): Arguments that
4192 specify buffer/string position and length are now ssize_t and
4193 size_t. Return type is regoff_t.
4194
4195 2011-04-16 Ben Key <bkey76@gmail.com>
4196
4197 * nsfont.m: Fixed bugs in ns_get_family and
4198 ns_descriptor_to_entity that were caused by using free to
4199 deallocate memory blocks that were allocated by xmalloc (via
4200 xstrdup). This caused Emacs to crash when compiled with
4201 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4202 --enable-checking=xmallocoverrun). xfree is now used to
4203 deallocate these memory blocks.
4204
4205 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4206
4207 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4208
4209 emacs_write: Accept and return EMACS_INT for sizes.
4210 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4211 et seq.
4212 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4213 Accept and return EMACS_INT.
4214 (emacs_gnutls_write): Return the number of bytes written on
4215 partial writes.
4216 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4217 (emacs_read, emacs_write): Remove check for negative size, as the
4218 Emacs source code has been audited now.
4219 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4220 (emacs_read, emacs_write): Use it.
4221 * process.c (send_process): Adjust to the new signatures of
4222 emacs_write and emacs_gnutls_write. Do not attempt to store
4223 a byte offset into an 'int'; it might overflow.
4224 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4225
4226 * sound.c: Don't assume sizes fit in 'int'.
4227 (struct sound_device.period_size, alsa_period_size):
4228 Return EMACS_INT, not int.
4229 (struct sound_device.write, vox_write, alsa_write):
4230 Accept EMACS_INT, not int.
4231 (wav_play, au_play): Use EMACS_INT to store sizes and to
4232 record read return values.
4233
4234 2011-04-15 Ben Key <bkey76@gmail.com>
4235
4236 * keyboard.c (Qundefined): Don't declare static since it is used
4237 in nsfns.m.
4238 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4239 static since they are used in nsfont.m.
4240
4241 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4242
4243 * process.c (Qprocessp): Don't declare static.
4244 * lisp.h (Qprocessp): Declare again.
4245
4246 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4247
4248 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4249
4250 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4251
4252 Improve C-level modularity by making more things 'static'.
4253
4254 Don't publish debugger-only interfaces to other modules.
4255 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4256 (verify_bytepos, count_markers): Move decls to the only modules
4257 that need them.
4258 * region-cache.h (pp_cache): Likewise.
4259 * window.h (check_all_windows): Likewise.
4260 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4261
4262 * sysdep.c (croak): Now static, if
4263 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4264 * syssignal.h (croak): Declare only if not static.
4265
4266 * alloc.c (refill_memory_reserve): Now static if
4267 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4268 * lisp.h (refill_memory_reserve): Declare only if not static.
4269
4270 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4271 Define only if USE_LUCID.
4272
4273 * xrdb.c (x_customization_string, x_rm_string): Now static.
4274
4275 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4276 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4277
4278 * xdisp.c (draw_row_with_mouse_face): Now static.
4279 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4280
4281 * window.h (check_all_windows): Mark externally visible.
4282
4283 * window.c (window_deletion_count): Now static.
4284
4285 * undo.c: Make symbols static if they're not exported.
4286 (last_undo_buffer, last_boundary_position, pending_boundary):
4287 Now static.
4288
4289 * textprop.c (interval_insert_behind_hooks): Now static.
4290 (interval_insert_in_front_hooks): Likewise.
4291
4292 * term.c: Make symbols static if they're not exported.
4293 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4294 (max_frame_lines, tty_set_terminal_modes):
4295 (tty_reset_terminal_modes, tty_turn_off_highlight):
4296 (get_tty_terminal): Now static.
4297 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4298 * termhooks.h (term_mouse_moveto): Do not declare if
4299 HAVE_WINDOW_SYSTEM.
4300 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4301 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4302
4303 * sysdep.c: Make symbols static if they're not exported.
4304 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4305 Now static.
4306 (sigprocmask_set, full_mask): Remove; unused.
4307 (wait_debugging): Mark as visible.
4308 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4309 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4310
4311 * syntax.c (syntax_temp): Define only if !__GNUC__.
4312
4313 * sound.c (current_sound_device, current_sound): Now static.
4314
4315 * search.c (searchbufs, searchbuf_head): Now static.
4316
4317 * scroll.c (scroll_cost): Remove; unused.
4318 * dispextern.h (scroll_cost): Remove decl.
4319
4320 * region-cache.h (pp_cache): Mark as externally visible.
4321
4322 * process.c: Make symbols static if they're not exported.
4323 (process_tick, update_tick, create_process, chan_process):
4324 (Vprocess_alist, proc_buffered_char, datagram_access):
4325 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4326 (deactivate_process): Mark defn as static, as well as decl.
4327 * lisp.h (create_process): Remove decl.
4328 * process.h (chan_process, Vprocess_alist): Remove decls.
4329
4330 * print.c: Make symbols static if they're not exported.
4331 (print_depth, new_backquote_output, being_printed, print_buffer):
4332 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4333 (print_interval, print_number_index, initial_stderr_stream):
4334 Now static.
4335 * lisp.h (Fprinc): Remove decl.
4336 (debug_output_compilation_hack): Mark as externally visible.
4337
4338 * sysdep.c (croak): Move decl from here to syssignal.h.
4339 * syssignal.h (croak): Put it here, so the API can be checked when
4340 'croak' is called from dissociate_if_controlling_tty.
4341
4342 * minibuf.c: Make symbols static if they're not exported.
4343 (minibuf_save_list, choose_minibuf_frame): Now static.
4344 * lisp.h (choose_minibuf_frame): Remove decl.
4345
4346 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4347
4348 * lread.c: Make symbols static if they're not exported.
4349 (read_objects, initial_obarray, oblookup_last_bucket_number):
4350 Now static.
4351 (make_symbol): Remove; unused.
4352 * lisp.h (initial_obarray, make_symbol): Remove decls.
4353
4354 * keyboard.c: Make symbols static if they're not exported.
4355 (single_kboard, recent_keys_index, total_keys, recent_keys):
4356 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4357 (this_single_command_key_start, echoing, last_auto_save):
4358 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4359 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4360 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4361 (Vlispy_mouse_stem, double_click_count):
4362 Now static.
4363 (force_auto_save_soon): Define only if SIGDANGER.
4364 (ignore_mouse_drag_p): Now static if
4365 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4366 (print_help): Remove; unused.
4367 (stop_character, last_timer_event): Mark as externally visible.
4368 * keyboard.h (ignore_mouse_drag_p): Declare only if
4369 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4370 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4371 * lisp.h (echoing): Remove decl.
4372 (force_auto_save_soon): Declare only if SIGDANGER.
4373 * xdisp.c (redisplay_window): Simplify code, to make it more
4374 obvious that ignore_mouse_drag_p is not accessed if !defined
4375 USE_GTK && !defined HAVE_NS.
4376
4377 * intervals.c: Make symbols static if they're not exported.
4378 (merge_properties_sticky, merge_interval_right, delete_interval):
4379 Now static.
4380 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4381
4382 * insdel.c: Make symbols static if they're not exported.
4383 However, leave prepare_to_modify_buffer alone. It's never
4384 called from outside this function, but that appears to be a bug.
4385 (combine_after_change_list, combine_after_change_buffer):
4386 (adjust_after_replace, signal_before_change): Now static.
4387 (adjust_after_replace_noundo): Remove; unused.
4388 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4389 (signal_before_change): Remove decls.
4390
4391 * indent.c (val_compute_motion, val_vmotion): Now static.
4392
4393 * image.c: Make symbols static if they're not exported.
4394 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4395 if USE_GTK.
4396 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4397 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4398
4399 * fringe.c (standard_bitmaps): Now static.
4400 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4401
4402 * frame.c: Make symbols static if they're not exported.
4403 (x_report_frame_params, make_terminal_frame): Now static.
4404 (get_frame_param): Now static, unless HAVE_NS.
4405 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4406 (x_get_resource_string): Remove; not used.
4407 * frame.h (make_terminal_frame, x_report_frame_params):
4408 (x_get_resource_string); Remove decls.
4409 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4410 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4411
4412 * font.c, fontset.c: Make symbols static if they're not exported.
4413 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4414 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4415 * font.c (font_close_object): Now static.
4416 * font.h (font_close_object): Remove.
4417 * fontset.c (FONTSET_OBJLIST): Remove.
4418 (free_realized_fontset) #if-0 the body, which does nothing.
4419 (face_suitable_for_char_p): #if-0, as it's never called.
4420 * fontset.h (face_suitable_for_char_p): Remove decl.
4421 * xfaces.c (face_at_string_position):
4422 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4423 since 0 is always ASCII.
4424
4425 * fns.c (weak_hash_tables): Now static.
4426
4427 * fileio.c: Make symbols static if they're not exported.
4428 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4429 (Vwrite_region_annotation_buffers): Now static.
4430
4431 * eval.c: Make symbols static if they're not exported.
4432 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4433 * lisp.h (backtrace_list): Remove decl.
4434
4435 * emacs.c: Make symbols static if they're not exported.
4436 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4437 (fatal_error_code, fatal_error_signal_hook, standard_args):
4438 Now static.
4439 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4440 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4441 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4442 * lisp.h (fatal_error_signal_hook): Remove decl.
4443 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4444
4445 * editfns.c: Move a (normally-unused) function to its only use.
4446 * editfns.c, lisp.h (get_operating_system_release): Remove.
4447 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4448 worth the hassle of breaking this out.
4449
4450 * xterm.c: Make symbols static if they're not exported.
4451 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4452 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4453 (x_destroy_window, x_delete_display):
4454 Now static.
4455 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4456 (x_mouse_leave): Remove; unused.
4457 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4458 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4459 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4460 Remove decls.
4461 (x_mouse_leave): Declare only if WINDOWSNT.
4462 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4463 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4464 USE_X_TOOLKIT.
4465
4466 * ftxfont.c: Make symbols static if they're not exported.
4467 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4468 HAVE_FREETYPE.
4469 * font.h (ftxfont_driver): Likewise.
4470
4471 * xfns.c: Make symbols static if they're not exported.
4472 (x_last_font_name, x_display_info_for_name):
4473 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4474 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4475 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4476 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4477 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4478 (last_show_tip_args): Now static.
4479 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4480 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4481 (x_screen_planes): Remove; unused.
4482 * dispextern.h (x_screen_planes): Remove decl.
4483
4484 * dispnew.c: Make symbols static if they're not exported.
4485 * dispextern.h (redraw_garbaged_frames, scrolling):
4486 (increment_row_positions): Remove.
4487 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4488 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4489 Now static.
4490 (redraw_garbaged_frames): Remove; unused.
4491
4492 * xfaces.c: Make symbols static if they're not exported.
4493 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4494 Remove decls.
4495 * xterm.h (defined_color): Remove decls.
4496 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4497 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4498 (menu_face_changed_default, defined_color, free_realized_face):
4499 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4500 (ascii_face_of_lisp_face): Remove; unused.
4501
4502 * xdisp.c: Make symbols static if they're not exported.
4503 * dispextern.h (scratch_glyph_row, window_box_edges):
4504 (glyph_to_pixel_coords, set_cursor_from_row):
4505 (get_next_display_element, set_iterator_to_next):
4506 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4507 (show_mouse_face): Remove decls
4508 * frame.h (message_buf_print): Likewise.
4509 * lisp.h (pop_message, set_message, check_point_in_composition):
4510 Likewise.
4511 * xterm.h (set_vertical_scroll_bar): Likewise.
4512 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4513 (message_buf_print, scratch_glyph_row, displayed_buffer):
4514 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4515 (get_next_display_element, show_mouse_face, window_box_edges):
4516 (frame_to_window_pixel_xy, check_point_in_composition):
4517 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4518 (glyph_to_pixel_coords): Remove; unused.
4519
4520 * dired.c (file_name_completion): Now static.
4521
4522 * dbusbind.c (xd_in_read_queued_messages): Now static.
4523
4524 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4525 * data.c (circular_list_error): Remove.
4526
4527 * commands.h (last_point_position, last_point_position_buffer):
4528 (last_point_position_window): Remove decls.
4529 * keyboard.c: Make these variables static.
4530
4531 * coding.h (coding, code_convert_region, encode_coding_gap):
4532 Remove decls.
4533 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4534 (iso_code_class, detect_coding, code_convert_region): Now static.
4535 (encode_coding_gap): Remove; unused.
4536
4537 * chartab.c (chartab_chars, chartab_bits): Now static.
4538
4539 * charset.h (charset_iso_8859_1): Remove decl.
4540 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4541 Now static.
4542
4543 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4544 * ccl.c (Vccl_program_table): Now static.
4545 (check_ccl_update): Remove; unused.
4546
4547 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4548 * category.h: ... from here.
4549 * category.c (check_category_table, set_category_set): Now static.
4550
4551 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4552 * lisp.h: Remove these decls.
4553
4554 * buffer.c (buffer_count): Remove unused var.
4555
4556 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4557 so that it's not optimized away.
4558 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4559 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4560 exported only to the debugger.
4561
4562 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4563 * atimer.h (run_all_atimers): Remove; not exported.
4564
4565 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4566 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4567 was inaccessible from Lisp.
4568 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4569 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4570
4571 alloc.c: Import and export fewer symbols, and remove unused items.
4572 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4573 is defined.
4574 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4575 it's not optimized away by whole-program optimization.
4576 (message_enable_multibyte, free_misc): Remove.
4577 (catchlist, handlerlist, mark_backtrace):
4578 Declare only if BYTE_MARK_STACK.
4579 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4580 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4581 (message_enable_multibyte): Remove decl.
4582 (free_misc, interval_free_list, float_block, float_block_index):
4583 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4584 (cons_free_list, last_marked_index):
4585 Now static.
4586 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4587 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4588 (mark_backtrace): Define only if BYTE_MARK_STACK.
4589 * xdisp.c (message_enable_multibyte): Now static.
4590
4591 Declare Lisp_Object Q* variables to be 'static' if not exported.
4592 This makes it easier for human readers (and static analyzers)
4593 to see whether these variables are used from other modules.
4594 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4595 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4596 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4597 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4598 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4599 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4600 * xmenu.c, xselect.c:
4601 Declare Q* vars static if they are not used in other modules.
4602 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4603 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4604 Remove decls of unexported vars.
4605 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4606
4607 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4608
4609 Make Emacs functions such as Fatom 'static' by default.
4610 This makes it easier for human readers (and static analyzers)
4611 to see whether these functions can be called from other modules.
4612 DEFUN now defines a static function. To make the function external
4613 so that it can be used in other C modules, use the new macro DEFUE.
4614 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4615 (Finit_image_library):
4616 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4617 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4618 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4619 Remove decls, since these functions are now static.
4620 (Funintern, Fget_internal_run_time): New decls, since these functions
4621 were already external.
4622
4623 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4624 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4625 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4626 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4627 * keyboard.c, keymap.c, lread.c:
4628 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4629 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4630 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4631 Mark functions with DEFUE instead of DEFUN,
4632 if they are used in other modules.
4633 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4634 decls for now-static functions.
4635 * buffer.h (Fdelete_overlay): Remove decl.
4636 * callproc.c (Fgetenv_internal): Mark as internal.
4637 * composite.c (Fremove_list_of_text_properties): Remove decl.
4638 (Fcomposition_get_gstring): New forward static decl.
4639 * composite.h (Fcomposite_get_gstring): Remove decl.
4640 * dired.c (Ffile_attributes): New forward static decl.
4641 * doc.c (Fdocumntation_property): New forward static decl.
4642 * eval.c (Ffetch_bytecode): New forward static decl.
4643 (Funintern): Remove extern decl; now in .h file where it belongs.
4644 * fileio.c (Fmake_symbolic_link): New forward static decl.
4645 * image.c (Finit_image_library): New forward static decl.
4646 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4647 * intervals.h (Fprevious_property_change):
4648 (Fremove_list_of_text_properties): Remove decls.
4649 * keyboard.c (Fthis_command_keys): Remove decl.
4650 (Fcommand_execute): New forward static decl.
4651 * keymap.c (Flookup_key): New forward static decl.
4652 (Fcopy_keymap): Now static.
4653 * keymap.h (Flookup_key): Remove decl.
4654 * process.c (Fget_process): New forward static decl.
4655 (Fprocess_datagram_address): Mark as internal.
4656 * syntax.c (Fsyntax_table_p): New forward static decl.
4657 (skip_chars): Remove duplicate decl.
4658 * textprop.c (Fprevious_property_change): New forward static decl.
4659 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4660 Now internal.
4661 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4662 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4663
4664 * editfns.c (Fformat): Remove unreachable code.
4665
4666 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4667
4668 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4669 change. (Bug#8496)
4670
4671 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4672
4673 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4674 when at ZV. (Bug#8487)
4675
4676 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4677
4678 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4679 (Bug#8437)
4680 * keyboard.c (parse_tool_bar_item): Likewise.
4681 * sound.c (sound_cleanup, alsa_close): Likewise.
4682 * termcap.c (tgetent): Likewise.
4683 * xfns.c (x_default_font_parameter): Likewise.
4684 * xsettings.c (read_and_apply_settings): Likewise.
4685
4686 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4687 (overrun_check_free): Protoize.
4688
4689 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4690
4691 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4692 since callers should never pass a negative size.
4693 Change the signature to match that of plain 'read' and 'write'; see
4694 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4695 * lisp.h: Update prototypes of emacs_write and emacs_read.
4696
4697 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4698
4699 * xdisp.c (redisplay_window): Don't try to determine the character
4700 position of the scroll margin if the window start point w->startp
4701 is outside the buffer's accessible region. (Bug#8468)
4702
4703 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4704
4705 Fix write-region and its subroutines for buffers > 2GB.
4706 * fileio.c (a_write, e_write): Modify declaration of arguments and
4707 local variables to support buffers larger than 2GB.
4708 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4709
4710 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4711 argument, local variables, and return value.
4712
4713 * lisp.h: Update prototypes of emacs_write and emacs_read.
4714
4715 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4716
4717 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4718
4719 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4720
4721 Fix more problems found by GCC 4.6.0's static checks.
4722
4723 * xdisp.c (vmessage): Use a better test for character truncation.
4724
4725 * charset.c (load_charset_map): <, not <=, for optimization,
4726 and to avoid potential problems with integer overflow.
4727 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4728 * casetab.c (set_identity, shuffle): Likewise.
4729 * editfns.c (Fformat): Likewise.
4730 * syntax.c (skip_chars): Likewise.
4731
4732 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4733 This also lets GCC 4.6.0 generate slightly better loop code.
4734
4735 * callint.c (Fcall_interactively): <, not <=, for optimization.
4736 (Fcall_interactively): Count the number of arguments produced,
4737 not the number of arguments given. This is simpler and lets GCC
4738 4.6.0 generate slightly better code.
4739
4740 * ftfont.c: Distingish more carefully between FcChar8 and char.
4741 The previous code passed unsigned char * to a functions like
4742 strlen and xstrcasecmp that expect char *, which does not
4743 conform to the C standard.
4744 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4745 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4746 char * when the C standard requires it.
4747
4748 * keyboard.c (read_char): Remove unused var.
4749
4750 * eval.c: Port to Windows vsnprintf (Bug#8435).
4751 Include <limits.h>.
4752 (SIZE_MAX): Define if the headers do not.
4753 (verror): Do not give up if vsnprintf returns a negative count.
4754 Instead, grow the buffer. This ports to Windows vsnprintf, which
4755 does not conform to C99. Problem reported by Eli Zaretskii.
4756 Also, simplify the allocation scheme, by avoiding the need for
4757 calling realloc, and removing the ALLOCATED variable.
4758
4759 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4760
4761 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4762 But keep the doprint source code for now, as we might revamp it
4763 and use it again (Bug#8435).
4764 * lisp.h (doprnt): Remove.
4765 * Makefile.in (base_obj): Remove doprnt.o.
4766 * deps.mk (doprnt.o): Remove.
4767
4768 error: Print 32- and 64-bit integers portably (Bug#8435).
4769 Without this change, on typical 64-bit hosts error ("...%d...", N)
4770 was used to print both 32- and 64-bit integers N, which relied on
4771 undefined behavior.
4772 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4773 New macro.
4774 * lisp.h (error, verror): Mark as printf-like functions.
4775 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4776 Report overflow in size calculations when allocating printf buffer.
4777 Do not truncate output string at its first null byte.
4778 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4779 Truncate the output at a character boundary, since vsnprintf does not
4780 do that.
4781 * charset.c (check_iso_charset_parameter): Convert internal
4782 character to string before calling 'error', since %c now has the
4783 printf meaning.
4784 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4785 overflow when computing char to be passed to 'error'. Do not
4786 pass Lisp_Object to 'error'; pass the integer instead.
4787 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4788 formatted with plain %d.
4789
4790 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4791
4792 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4793
4794 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4795
4796 * xterm.c (x_catch_errors): Remove duplicate declaration.
4797
4798 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4799
4800 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4801
4802 2011-04-10 Jim Meyering <meyering@redhat.com>
4803
4804 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4805 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4806 return ssize_t not "int", and use size_t as the buffer length.
4807 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4808 * gnutls.h: Update declarations.
4809 * process.c (read_process_output): Use ssize_t, to match.
4810 (send_process): Likewise.
4811
4812 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4813
4814 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4815
4816 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4817
4818 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4819 Use unsigned char, to match FcChar8 type definition.
4820
4821 * xterm.c (handle_one_xevent):
4822 * xmenu.c (create_and_show_popup_menu):
4823 * xselect.c (x_decline_selection_request)
4824 (x_reply_selection_request): Avoid type-punned deref of X events.
4825
4826 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4827
4828 Fix some uses of `int' instead of EMACS_INT.
4829 * search.c (string_match_1, fast_string_match)
4830 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4831 (scan_buffer, find_next_newline_no_quit)
4832 (find_before_next_newline, search_command, Freplace_match)
4833 (Fmatch_data): Make some `int' variables be EMACS_INT.
4834
4835 * xdisp.c (display_count_lines): 3rd argument and return value now
4836 EMACS_INT. All callers changed.
4837 (pint2hrstr): Last argument is now EMACS_INT.
4838
4839 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4840 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4841 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4842 (decode_coding_utf_16, decode_coding_emacs_mule)
4843 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4844 (decode_coding_ccl, decode_coding_charset)
4845 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4846 (decode_coding_iso_2022, decode_coding_emacs_mule)
4847 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4848 <char_offset, last_offset>: Declare EMACS_INT.
4849 (encode_coding_utf_8, encode_coding_utf_16)
4850 (encode_coding_emacs_mule, encode_invocation_designation)
4851 (encode_designation_at_bol, encode_coding_iso_2022)
4852 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4853 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4854 Declare EMACS_INT.
4855 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4856 (encode_invocation_designation): Last argument P_NCHARS is now
4857 EMACS_INT.
4858 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4859 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4860
4861 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4862 All users changed.
4863
4864 * ccl.c (Fccl_execute_on_string): Declare some variables
4865 EMACS_INT.
4866
4867 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4868
4869 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4870
4871 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4872
4873 * process.c (Fformat_network_address): Doc fix.
4874
4875 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4876
4877 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4878
4879 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4880
4881 * keyboard.c (read_char): Call Lisp function help-form-show,
4882 instead of using internal_with_output_to_temp_buffer.
4883 (Qhelp_form_show): New var.
4884 (syms_of_keyboard): Use DEFSYM macro.
4885
4886 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4887
4888 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4889
4890 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4891
4892 * process.c (Flist_processes): Remove to Lisp.
4893 (list_processes_1): Delete.
4894
4895 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4896
4897 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4898
4899 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4900
4901 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4902
4903 Fix more problems found by GCC 4.6.0's static checks.
4904
4905 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4906
4907 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4908
4909 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4910
4911 * xdisp.c (vmessage): Mark as a printf-like function.
4912
4913 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4914
4915 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4916
4917 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4918 printf-like functions.
4919 (tiff_load): Add casts to remove these marks before passing them
4920 to system-supplied API.
4921
4922 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4923
4924 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4925 This avoids several warnings with gcc -Wstrict-overflow.
4926 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4927 directly, rather than having caller test rule sign. This avoids
4928 some unnecessary tests.
4929 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4930 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4931 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4932
4933 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4934 (xfont_open): Avoid unnecessary tests.
4935
4936 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4937
4938 * composite.h, composite.c (composition_gstring_put_cache):
4939 Use EMACS_INT, not int, for length.
4940
4941 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4942 breaking out part of COMPOSITION_DECODE_RULE.
4943 (COMPOSITION_DECODE_RULE): Use it.
4944 * composite.c (get_composition_id): Remove unused local vars,
4945 by using the new macro.
4946
4947 * textprop.c (set_text_properties_1): Change while to do-while,
4948 since the condition is always true at first.
4949
4950 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4951 (interval_deletion_adjustment): Return unsigned value.
4952 All uses changed.
4953
4954 * process.c (list_processes_1, create_pty, read_process_output):
4955 (exec_sentinel): Remove vars that were set but not used.
4956 (create_pty): Remove unnecessary "volatile"s.
4957 (Fnetwork_interface_info): Avoid possibility of int overflow.
4958 (read_process_output): Do adaptive read buffering even if carryover.
4959 (read_process_output): Simplify nbytes computation if buffered.
4960
4961 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4962
4963 * syntax.c (scan_words): Remove var that was set but not used.
4964 (update_syntax_table): Use unsigned instead of int.
4965
4966 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4967 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4968 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4969
4970 * print.c (print_error_message): Avoid int overflow.
4971
4972 * font.c (font_list_entities): Redo for clarity,
4973 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4974
4975 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4976 (font_score): Avoid potential overflow in diff calculation.
4977
4978 * fns.c (substring_both): Remove var that is set but not used.
4979 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4980
4981 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4982
4983 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4984 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4985 can always succeed if overflow has undefined behavior.
4986
4987 * search.c (boyer_moore, wordify): Remove vars set but not used.
4988 (wordify): Omit three unnecessary tests.
4989
4990 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4991 All callers changed. This avoids the need for an unused var.
4992
4993 * casefiddle.c (casify_region): Remove var that is set but not used.
4994
4995 * dired.c (file_name_completion): Remove var that is set but not used.
4996
4997 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4998
4999 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5000 (Finsert_file_contents): Remove unnecessary code checking fd.
5001
5002 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5003 Check for integer overflow on size calculations.
5004
5005 * buffer.c (Fprevious_overlay_change): Remove var that is set
5006 but not used.
5007
5008 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5009 Remove vars that are set but not used.
5010 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5011 (timer_check_2): Mark vars as initialized.
5012
5013 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5014
5015 * image.c (lookup_image): Remove var that is set but not used.
5016 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5017
5018 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5019 that are set but not used.
5020
5021 * xfns.c (make_invisible_cursor): Don't return garbage
5022 if XCreateBitmapFromData fails (Bug#8410).
5023
5024 * xselect.c (x_get_local_selection, x_handle_property_notify):
5025 Remove vars that are set but not used.
5026
5027 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5028 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5029
5030 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5031 Remove var that is set but not used.
5032 (scroll_bar_windows_size): Now size_t, not int.
5033 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5034 Check for overflow.
5035
5036 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5037 (map_tty_color) [!defined MSDOS]: Likewise.
5038
5039 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5040
5041 * coding.c: Remove vars that are set but not used.
5042 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5043 All callers changed.
5044 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5045 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5046 (decode_coding_charset): Remove vars that are set but not used.
5047
5048 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5049 that is set but not used.
5050
5051 * print.c (print_object): Remove var that is set but not used.
5052
5053 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5054 The gnulib version avoids calling malloc in the usual case,
5055 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5056 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5057 * filelock.c (current_lock_owner): Likewise.
5058 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5059 * sysdep.c: Include allocator.h, careadlinkat.h.
5060 (emacs_no_realloc_allocator): New static constant.
5061 (emacs_readlink): New function.
5062 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5063 ../lib/careadlinkat.h.
5064
5065 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5066
5067 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5068 first non-nil return value).
5069
5070 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5071
5072 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5073 if not defined (Bug#8403).
5074
5075 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5076
5077 * xdisp.c (display_count_lines): Remove parameter `start',
5078 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5079 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5080 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5081 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5082 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5083 and thereabouts. All callers changed.
5084 (get_per_char_metric): Remove parameter `f', unused since
5085 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5086
5087 2011-04-02 Jim Meyering <meyering@redhat.com>
5088
5089 do not dereference NULL upon failed strdup
5090 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5091 (ns_get_family): Likewise.
5092
5093 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5094
5095 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5096
5097 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5098
5099 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5100 later (Bug#8403).
5101
5102 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5103
5104 Add lexical binding.
5105
5106 * window.c (Ftemp_output_buffer_show): New fun.
5107 (Fsave_window_excursion):
5108 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5109
5110 * lread.c (lisp_file_lexically_bound_p): New function.
5111 (Fload): Bind Qlexical_binding.
5112 (readevalloop): Remove `evalfun' arg.
5113 Bind Qinternal_interpreter_environment.
5114 (Feval_buffer): Bind Qlexical_binding.
5115 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5116 Mark as dynamic.
5117 (syms_of_lread): Declare `lexical-binding'.
5118
5119 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5120
5121 * keyboard.c (eval_dyn): New fun.
5122 (menu_item_eval_property): Use it.
5123
5124 * image.c (parse_image_spec): Use Ffunctionp.
5125
5126 * fns.c (concat, mapcar1): Accept byte-code-functions.
5127
5128 * eval.c (Fsetq): Handle lexical vars.
5129 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5130 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5131 (FletX, Flet): Obey lexical binding.
5132 (Fcommandp): Handle closures.
5133 (Feval): New `lexical' arg.
5134 (eval_sub): New function extracted from Feval. Use it almost
5135 everywhere where Feval was used. Look up vars in lexical env.
5136 Handle closures.
5137 (Ffunctionp): Move from subr.el.
5138 (Ffuncall): Handle closures.
5139 (apply_lambda): Remove `eval_flags'.
5140 (funcall_lambda): Handle closures and new byte-code-functions.
5141 (Fspecial_variable_p): New function.
5142 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5143 but without exporting it to Lisp.
5144
5145 * doc.c (Fdocumentation, store_function_docstring):
5146 * data.c (Finteractive_form): Handle closures.
5147
5148 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5149 interactive spec.
5150
5151 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5152 New byte-codes.
5153 (exec_byte_code): New function extracted from Fbyte_code to handle new
5154 calling convention for byte-code-functions. Add new byte-codes.
5155
5156 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5157
5158 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5159
5160 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5161
5162 * xdisp.c (redisplay_internal): Fix prototype.
5163
5164 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5165
5166 * xdisp.c (SCROLL_LIMIT): New macro.
5167 (try_scrolling): Use it when setting scroll_limit.
5168 Limit scrolling to 100 screen lines.
5169 (redisplay_window): Even when falling back on "recentering",
5170 position point in the window according to scroll-conservatively,
5171 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5172
5173 (try_scrolling): When point is above the window, allow searching
5174 as far as scroll_max, or one screenful, to compute vertical
5175 distance from PT to the scroll margin position. This prevents
5176 try_scrolling from unnecessarily failing when
5177 scroll-conservatively is set to a value slightly larger than the
5178 window height. Clean up the case of PT below the margin at bottom
5179 of window: scroll_max can no longer be INT_MAX. When aggressive
5180 scrolling is in use, don't let point enter the opposite scroll
5181 margin as result of the scroll.
5182 (syms_of_xdisp) <scroll-conservatively>: Document the
5183 threshold of 100 lines for never-recentering scrolling.
5184
5185 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5186
5187 * dispextern.h (move_it_by_lines):
5188 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5189 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5190 (message_log_check_duplicate): Remove parameters `prev_bol' and
5191 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5192 (redisplay_internal): Remove parameter `preserve_echo_area',
5193 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5194
5195 * indent.c (Fvertical_motion):
5196 * window.c (window_scroll_pixel_based, Frecenter):
5197 Don't pass `need_y_p' to `move_it_by_lines'.
5198
5199 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5200
5201 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5202 steal a few bits to be more compact.
5203 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5204 Remove unneeded casts.
5205
5206 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5207
5208 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5209
5210 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5211 binding" message (bug#7967).
5212
5213 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5214
5215 Fix more problems found by GCC 4.6.0's static checks.
5216
5217 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5218 Remove unused local var.
5219
5220 * editfns.c (Fmessage_box): Remove unused local var.
5221
5222 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5223 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5224 Omit unused local vars.
5225 * window.c (shrink_windows): Omit unused local var.
5226 * menu.c (digest_single_submenu): Omit unused local var.
5227 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5228 Omit unused local var.
5229
5230 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5231 Don't assume string length fits in int.
5232 (keyremap_step, read_key_sequence): Use size_t for sizes.
5233 (read_key_sequence): Don't check last_real_key_start redundantly.
5234
5235 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5236 instead of alloca (Bug#8344).
5237
5238 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5239 (Fbacktrace_frame): Don't assume nframes fits in int.
5240
5241 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5242
5243 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5244 concerns.
5245
5246 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5247
5248 * cm.c (calccost): Turn while-do into do-while, for clarity.
5249
5250 * keyboard.c (syms_of_keyboard): Use the same style as later
5251 in this function when indexing through an array. This also
5252 works around GCC bug 48267.
5253
5254 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5255
5256 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5257
5258 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5259 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5260
5261 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5262 This avoids undefined behavior on integer overflow, and is a bit
5263 more convenient anyway since it is compared to a size_t variable.
5264
5265 Variadic C functions now count arguments with size_t, not int.
5266 This avoids an unnecessary limitation on 64-bit machines, which
5267 caused (substring ...) to crash on large vectors (Bug#8344).
5268 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5269 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5270 All variadic functions and their callers changed accordingly.
5271 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5272 * data.c (arith_driver, float_arith_driver): Likewise.
5273 * editfns.c (general_insert_function): Likewise.
5274 * eval.c (struct backtrace.nargs, interactive_p)
5275 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5276 (funcall_lambda, mark_backtrace): Likewise.
5277 * fns.c (concat): Likewise.
5278 * frame.c (x_set_frame_parameters): Likewise.
5279 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5280 0 if not found, not -1. All callers changed.
5281
5282 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5283 (stack_copy_size): Now size_t, not int.
5284 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5285
5286 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5287
5288 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5289 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5290 All callers changed.
5291
5292 * lisp.h (multibyte_char_to_unibyte):
5293 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5294 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5295 * character.h (CHAR_TO_BYTE8):
5296 * cmds.c (internal_self_insert):
5297 * editfns.c (general_insert_function):
5298 * keymap.c (push_key_description):
5299 * search.c (Freplace_match):
5300 * xdisp.c (message_dolog, set_message_1): All callers changed.
5301
5302 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5303
5304 * keyboard.c (safe_run_hook_funcall): New function.
5305 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5306 don't set the hook to nil, but remove the offending function instead.
5307 (Qcommand_hook_internal): Remove, unused.
5308 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5309 Vcommand_hook_internal.
5310
5311 * eval.c (enum run_hooks_condition): Remove.
5312 (funcall_nil, funcall_not): New functions.
5313 (run_hook_with_args): Call each function through a `funcall' argument.
5314 Remove `cond' argument, now redundant.
5315 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5316 (Frun_hook_with_args_until_failure): Adjust accordingly.
5317 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5318
5319 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5320
5321 * dispextern.h (string_buffer_position): Remove declaration.
5322
5323 * print.c (strout): Remove parameter `multibyte', unused since
5324 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5325
5326 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5327 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5328 All callers changed.
5329
5330 * w32.c (_wsa_errlist): Use braces for struct initializers.
5331
5332 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5333 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5334 All callers changed.
5335 (string_buffer_position): Likewise. Also, make static (it's never
5336 used outside xdisp.c).
5337 (cursor_row_p): Remove parameter `w', unused since
5338 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5339 (decode_mode_spec): Remove parameter `precision', introduced during
5340 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5341 All callers changed.
5342
5343 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5344
5345 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5346
5347 2011-03-27 Anders Lindgren <andlind@gmail.com>
5348
5349 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5350 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5351 (ns_update_auto_hide_menu_bar): New functions.
5352 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5353 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5354 ns_constrain_all_frames.
5355 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5356 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5357
5358 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5359
5360 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5361
5362 2011-03-27 Glenn Morris <rgm@gnu.org>
5363
5364 * syssignal.h: Replace RETSIGTYPE with void.
5365 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5366 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5367 Replace SIGTYPE with void everywhere.
5368 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5369 * s/template.h (SIGTYPE): Remove commented out definition.
5370
5371 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5372
5373 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5374 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5375
5376 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5377
5378 * w32.c (read_unc_volume): Use parameter `henum', instead of
5379 global variable `wget_enum_handle'.
5380
5381 * keymap.c (describe_vector): Remove parameters `indices' and
5382 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5383 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5384
5385 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5386
5387 * keyboard.c (timer_check): Remove parameter `do_it_now',
5388 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5389 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5390 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5391
5392 * keyboard.c (read_char):
5393 * w32menu.c (w32_menu_display_help):
5394 * xmenu.c (show_help_event, menu_help_callback):
5395 Adjust calls to `show_help_echo'.
5396
5397 * gtkutil.c (xg_maybe_add_timer):
5398 * keyboard.c (readable_events):
5399 * process.c (wait_reading_process_output):
5400 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5401
5402 * insdel.c (adjust_markers_gap_motion):
5403 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5404 (gap_left, gap_right): Don't call it.
5405
5406 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5407
5408 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5409 incurred during fontification.
5410
5411 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5412
5413 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5414 (DEFVAR_PER_BUFFER): Don't pass it.
5415
5416 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5417 (scrolling_window): Don't pass it.
5418
5419 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5420
5421 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5422
5423 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5424 and `suffix'.
5425 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5426 of variables specific to SELinux and computation of `encoded_absname'.
5427
5428 * image.c (XPutPixel): Remove unused variable `height'.
5429
5430 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5431
5432 * unexw32.c (get_section_info): Remove unused variable `section'.
5433
5434 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5435 (system_process_attributes): Remove unused variable `sess'.
5436 (sys_read): Remove unused variable `err'.
5437
5438 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5439 (w32_wnd_proc): Remove unused variable `isdead'.
5440 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5441 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5442 (x_create_tip_frame): Remove unused variable `tem'.
5443
5444 * w32inevt.c (w32_console_read_socket):
5445 Remove unused variable `no_events'.
5446
5447 * w32term.c (x_draw_composite_glyph_string_foreground):
5448 Remove unused variable `width'.
5449
5450 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5451
5452 * w32term.c (x_set_glyph_string_clipping):
5453 Don't pass uninitialized region to CombineRgn.
5454
5455 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5456
5457 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5458 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5459 (Fx_close_connection): Remove unused variable `i'.
5460
5461 * w32font.c (w32font_draw): Return number of glyphs.
5462 (w32font_open_internal): Remove unused variable `i'.
5463 (w32font_driver): Add missing initializer.
5464
5465 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5466 (fill_in_menu): Remove unused variable `items_added'.
5467
5468 * w32term.c (last_mouse_press_frame): Remove static global variable.
5469 (w32_clip_to_row): Remove unused variable `f'.
5470 (x_delete_terminal): Remove unused variable `i'.
5471
5472 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5473 (NOTHING): Remove unused static global variable.
5474 (uniscribe_check_otf): Remove unused variable `table'.
5475 (uniscribe_font_driver): Add missing initializers.
5476
5477 2011-03-23 Julien Danjou <julien@danjou.info>
5478
5479 * term.c (Fsuspend_tty, Fresume_tty):
5480 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5481 * window.c (temp_output_buffer_show):
5482 * insdel.c (signal_before_change):
5483 * frame.c (Fhandle_switch_frame):
5484 * fileio.c (Fdo_auto_save):
5485 * emacs.c (Fkill_emacs):
5486 * editfns.c (save_excursion_restore):
5487 * cmds.c (internal_self_insert):
5488 * callint.c (Fcall_interactively):
5489 * buffer.c (Fkill_all_local_variables):
5490 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5491 Use Frun_hooks.
5492 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5493 unconditionnaly since it does the check itself.
5494
5495 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5496
5497 Fix more problems found by GCC 4.5.2's static checks.
5498
5499 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5500 the first time through the loop, since we know p0 < p1 then.
5501 This also avoids a gcc -Wstrict-overflow warning.
5502
5503 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5504 leading to a memory leak, possible in functions like
5505 load_charset_map_from_file that can allocate an unbounded number
5506 of objects (Bug#8318).
5507
5508 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5509 that could (at least in theory) be that large.
5510
5511 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5512 This is less likely to overflow, and avoids undefined behavior if
5513 overflow does occur. All callers changed. Use strtoul to scan
5514 for the unsigned long integer.
5515 (pint2hrstr): Simplify and tune code slightly.
5516 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5517
5518 * scroll.c (do_scrolling): Work around GCC bug 48228.
5519 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5520
5521 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5522 This also avoids a warning with gcc -Wstrict-overflow.
5523 (validate_x_resource_name): Simplify count usage.
5524 This also avoids a warning with gcc -Wstrict-overflow.
5525
5526 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5527 fail (Bug#8306).
5528
5529 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5530
5531 * process.c (Fmake_network_process): Use socklen_t, not int,
5532 where POSIX says socklen_t is required in portable programs.
5533 This fixes a porting bug on hosts like 64-bit HP-UX, where
5534 socklen_t is wider than int (Bug#8277).
5535 (Fmake_network_process, server_accept_connection):
5536 (wait_reading_process_output, read_process_output):
5537 Likewise.
5538
5539 * process.c: Rename or move locals to avoid shadowing.
5540 (list_processes_1, Fmake_network_process):
5541 (read_process_output_error_handler, exec_sentinel_error_handler):
5542 Rename or move locals.
5543 (Fmake_network_process): Define label "retry_connect" only if needed.
5544 (Fnetwork_interface_info): Fix pointer signedness.
5545 (process_send_signal): Add cast to avoid pointer signedness problem.
5546 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5547 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5548
5549 Make tparam.h and terminfo.c consistent.
5550 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5551 Include tparam.h instead, since it declares them.
5552 * cm.h (PC): Remove extern decl; tparam.h now does this.
5553 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5554 * terminfo.c: Include tparam.h, to check interfaces.
5555 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5556 (tparam): Adjust signature to match interface in tparam.h;
5557 this removes some undefined behavior. Check that outstring and len
5558 are zero, which they always are with Emacs.
5559 * tparam.h (PC, BC, UP): New extern decls.
5560
5561 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5562 (xftfont_open): Rename locals to avoid shadowing.
5563
5564 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5565 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5566 (OTF_TAG_SYM): Omit macro if not needed.
5567 (ftfont_list): Remove unused local.
5568 (get_adstyle_property, ftfont_pattern_entity):
5569 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5570 Rename locals to avoid shadowing.
5571
5572 * xfont.c (xfont_list_family): Mark var as initialized.
5573
5574 * xml.c (make_dom): Now static.
5575
5576 * composite.c (composition_compute_stop_pos): Rename local to
5577 avoid shadowing.
5578 (composition_reseat_it): Remove unused locals.
5579 (find_automatic_composition, composition_adjust_point): Likewise.
5580 (composition_update_it): Mark var as initialized.
5581 (find_automatic_composition): Mark vars as initialized,
5582 with a FIXME (Bug#8290).
5583
5584 character.h: Rename locals to avoid shadowing.
5585 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5586 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5587 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5588 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5589 to avoid shadowing.
5590
5591 * textprop.c (property_change_between_p): Remove; unused.
5592
5593 * intervals.c (interval_start_pos): Now static.
5594
5595 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5596
5597 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5598 Rename locals to avoid shadowing.
5599
5600 * sound.c (wav_play, au_play, Fplay_sound_internal):
5601 Fix pointer signedness.
5602 (alsa_choose_format): Remove unused local var.
5603 (wav_play): Initialize a variable to 0, to prevent undefined
5604 behavior (Bug#8278).
5605
5606 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5607
5608 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5609
5610 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5611 clobbering (Bug#8298).
5612 * sysdep.c (sys_subshell): Likewise.
5613 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5614
5615 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5616 This should get cleaned up, so that child_setup has the
5617 same signature on all platforms.
5618
5619 * callproc.c (call_process_cleanup): Now static.
5620 (relocate_fd): Rename locals to avoid shadowing.
5621
5622 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5623
5624 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5625 not to be necessary, and produces flickering.
5626
5627 2011-03-20 Glenn Morris <rgm@gnu.org>
5628
5629 * config.in: Remove file.
5630
5631 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5632
5633 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5634 are now in src/globals.h.
5635 (syms_of_minibuf): Remove spurious & from previous change.
5636
5637 2011-03-20 Leo <sdl.web@gmail.com>
5638
5639 * minibuf.c (completing-read-function): New variable.
5640 (completing-read-default): Rename from completing-read.
5641 (completing-read): Call completing-read-function.
5642
5643 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5644
5645 * xfaces.c (Fx_load_color_file):
5646 Read color file from absolute filename (bug#8250).
5647
5648 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5649
5650 * makefile.w32-in: Update dependencies.
5651
5652 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5653
5654 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5655
5656 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5657
5658 Fix more problems found by GCC 4.5.2's static checks.
5659
5660 * process.c (make_serial_process_unwind, send_process_trap):
5661 (sigchld_handler): Now static.
5662
5663 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5664 That way, the code declares only the vars that it needs.
5665 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5666 * s/cygwin.h (PTY_ITERATION): Likewise.
5667 * s/darwin.h (PTY_ITERATION): Likewise.
5668 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5669
5670 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5671 * process.c (allocate_pty): Don't declare stb unless it's needed.
5672
5673 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5674 (CONSTANTLIM): Remove; unused.
5675 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5676 Define only if needed.
5677
5678 * unexelf.c (unexec): Name an expression,
5679 to avoid gcc -Wbad-function-cast warning.
5680 Use a different way to cause a compilation error if anyone uses
5681 n rather than nn, a way that does not involve shadowing.
5682 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5683
5684 * deps.mk (unexalpha.o): Remove; unused.
5685
5686 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5687 * unexec.h: New file.
5688 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5689 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5690 Depend on unexec.h.
5691 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5692 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5693 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5694 Change as necessary to match prototype in unexec.h.
5695
5696 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5697 shadowing.
5698 (back_comment, skip_chars): Mark vars as initialized.
5699
5700 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5701 Rename locals to avoid shadowing.
5702
5703 * lread.c (read1): Rewrite so as not to use empty "else".
5704 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5705
5706 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5707
5708 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5709 warning when compiling print.c.
5710
5711 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5712 instead of using an uninitialized var.
5713 (font_sort_entities): Mark var as initialized.
5714
5715 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5716
5717 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5718 pointers to constants.
5719 (font_parse_fcname): Remove unused vars.
5720 (font_delete_unmatched): Now static.
5721 (font_get_spec): Remove; unused.
5722 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5723 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5724 Rename or move locals to avoid shadowing.
5725
5726 * fns.c (require_nesting_list, require_unwind): Now static.
5727 (Ffillarray): Rename locals to avoid shadowing.
5728
5729 * floatfns.c (domain_error2): Define only if needed.
5730 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5731
5732 * alloc.c (mark_backtrace): Move decl from here ...
5733 * lisp.h: ... to here, so that it can be checked.
5734
5735 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5736 (Fdefvar): Rewrite so as not to use empty "else".
5737 (lisp_indirect_variable): Name an expression,
5738 to avoid gcc -Wbad-function-cast warning.
5739 (Fdefvar): Rename locals to avoid shadowing.
5740
5741 * callint.c (quotify_arg, quotify_args): Now static.
5742 (Fcall_interactively): Rename locals to avoid shadowing.
5743 Use const pointer when appropriate.
5744
5745 * lisp.h (get_system_name, get_operating_system_release):
5746 Move decls here, to check interfaces.
5747 * process.c (get_operating_system_release): Move decl to lisp.h.
5748 * xrdb.c (get_system_name): Likewise.
5749 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5750 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5751 some of which prompt warnings from gcc -Wbad-function-cast.
5752 (Fformat_time_string, Fencode_time, Finsert_char):
5753 (Ftranslate_region_internal, Fformat):
5754 Rename or remove local vars to avoid shadowing.
5755 (Ftranslate_region_internal): Mark var as initialized.
5756
5757 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5758 avoid shadowing.
5759
5760 * lisp.h (eassert): Check that the argument compiles, even if
5761 ENABLE_CHECKING is not defined.
5762
5763 * data.c (Findirect_variable): Name an expression, to avoid
5764 gcc -Wbad-function-cast warning.
5765 (default_value, arithcompare, arith_driver, arith_error): Now static.
5766 (store_symval_forwarding): Rename local to avoid shadowing.
5767 (Fmake_variable_buffer_local, Fmake_local_variable):
5768 Mark variables as initialized.
5769 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5770
5771 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5772 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5773 Rename locals to avoid shadowing.
5774 (mark_stack): Move local variables into the #ifdef region where
5775 they're used.
5776 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5777 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5778 needed otherwise.
5779 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5780 (GC_STRING_CHARS): Remove; not used.
5781 (Fmemory_limit): Cast sbrk's returned value to char *.
5782
5783 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5784 avoids undefined behavior in theory.
5785
5786 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5787
5788 Use functions, not macros, for up- and down-casing (Bug#8254).
5789 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5790 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5791 to use the following functions instead of these macros.
5792 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5793 EMACS_INT, since callers assume the returned value fits in int.
5794 (upcase1): Likewise, for UPCASE_TABLE.
5795 (uppercasep, lowercasep, upcase): New static inline functions.
5796 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5797 the race-condition problem in the old DOWNCASE.
5798
5799 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5800 Rename locals to avoid shadowing.
5801 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5802 (regex_compile, re_search_2, re_match_2_internal):
5803 Remove unused local vars.
5804 (FREE_VAR): Rewrite so as not to use empty "else",
5805 which gcc can warn about.
5806 (regex_compile, re_match_2_internal): Mark locals as initialized.
5807 (RETALLOC_IF): Define only if needed.
5808 (WORDCHAR_P): Likewise. This one is never needed, but is used
5809 only in a comment talking about a compiler bug, so put inside
5810 the #if 0 of that comment.
5811 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5812 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5813 Remove; unused.
5814
5815 * search.c (boyer_moore): Rename locals to avoid shadowing.
5816 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5817 (PREV_CHAR_BOUNDARY): Likewise.
5818
5819 * search.c (simple_search): Remove unused var.
5820
5821 * dired.c (compile_pattern): Move decl from here ...
5822 * lisp.h: ... to here, so that it can be checked.
5823 (struct re_registers): New forward decl.
5824
5825 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5826
5827 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5828 All uses changed.
5829 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5830 Rename locals to avoid shadowing.
5831 (Fvertical_motion): Mark locals as initialized.
5832
5833 * casefiddle.c (casify_object, casify_region): Now static.
5834 (casify_region): Mark local as initialized.
5835
5836 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5837
5838 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5839 New macros, so that the caller can use some names other than
5840 gcpro1, gcpro2, etc.
5841 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5842 of the new macros.
5843 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5844 argument, for consistency with GCPRO2_VAR, etc: it is now the
5845 prefix of the variable, not the variable itself. All uses
5846 changed.
5847 * dired.c (directory_files_internal, file_name_completion):
5848 Rename locals to avoid shadowing.
5849
5850 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5851 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5852 dired.c's scmp function, had undefined behavior.
5853 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5854 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5855 * buffer.h: ... to here, because these macros use current_buffer,
5856 and the new implementation with inline functions needs to have
5857 current_buffer in scope now, rather than later when the macros
5858 are used.
5859 (downcase, upcase1): New static inline functions.
5860 (DOWNCASE, UPCASE1): Reimplement using these functions.
5861 This avoids undefined behavior in expressions like
5862 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5863 from race conditions in accessing the global variables
5864 case_temp1 and case_temp2.
5865 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5866 * lisp.h (case_temp1, case_temp2): Remove their decls.
5867 * character.h (ASCII_CHAR_P): Move from here ...
5868 * lisp.h: ... to here, so that the inline functions mentioned
5869 above can use them.
5870
5871 * dired.c (directory_files_internal_unwind): Now static.
5872
5873 * fileio.c (file_name_as_directory, directory_file_name):
5874 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5875 Now static.
5876 (file_name_as_directory): Use const pointers when appropriate.
5877 (Fexpand_file_name): Likewise. In particular, newdir might
5878 point at constant storage, so make it a const pointer.
5879 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5880 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5881 signedness issues.
5882 (Fset_file_times, Finsert_file_contents, auto_save_error):
5883 Rename locals to avoid shadowing.
5884
5885 * minibuf.c (choose_minibuf_frame_1): Now static.
5886 (Ftry_completion, Fall_completions): Rename or remove locals
5887 to avoid shadowing.
5888
5889 * marker.c (bytepos_to_charpos): Remove; unused.
5890
5891 * lisp.h (verify_bytepos, count_markers): New decls,
5892 so that gcc does not warn that these functions aren't declared.
5893
5894 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5895 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5896 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5897 (copy_text): Remove unused local var.
5898
5899 * filelock.c (within_one_second): Now static.
5900 (lock_file_1): Rename local to avoid shadowing.
5901
5902 * buffer.c (fix_overlays_before): Mark locals as initialized.
5903 (fix_start_end_in_overlays): Likewise. This function should be
5904 simplified by using pointers-to-pointers, but that's a different
5905 matter.
5906 (switch_to_buffer_1): Now static.
5907 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5908 (report_overlay_modification): Rename locals to avoid shadowing.
5909
5910 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5911 Fix pointer signedness issue.
5912 (sys_subshell): Mark local as volatile if checking for lint,
5913 to suppress a gcc -Wclobbered warning that does not seem to be right.
5914 (MAXPATHLEN): Define only if needed.
5915
5916 * process.c (serial_open, serial_configure): Move decls from here ...
5917 * systty.h: ... to here, so that they can be checked.
5918
5919 * fns.c (get_random, seed_random): Move extern decls from here ...
5920 * lisp.h: ... to here, so that they can be checked.
5921
5922 * sysdep.c (reset_io): Now static.
5923 (wait_for_termination_signal): Remove; unused.
5924
5925 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5926 (copy_keymap_item, append_key, push_text_char_description):
5927 Now static.
5928 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5929 (DENSE_TABLE_SIZE): Remove; unused.
5930 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5931 (describe_map_tree):
5932 Rename locals to avoid shadowing.
5933
5934 * keyboard.c: Declare functions static if they are not used elsewhere.
5935 (echo_char, echo_dash, cmd_error, top_level_2):
5936 (poll_for_input, handle_async_input): Now static.
5937 (read_char, kbd_buffer_get_event, make_lispy_position):
5938 (make_lispy_event, make_lispy_movement, apply_modifiers):
5939 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5940 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5941 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5942 (read_key_sequence, read_char): Mark locals as initialized.
5943 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5944
5945 * keyboard.h (make_ctrl_char): New decl.
5946 (mark_kboards): Move decl here ...
5947 * alloc.c (mark_kboards): ... from here.
5948
5949 * lisp.h (force_auto_save_soon): New decl.
5950
5951 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5952 (DEFINE_DUMMY_FUNCTION): New macro.
5953 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5954 Use it.
5955 (main): Add casts to avoid warnings
5956 if GCC considers string literals to be constants.
5957
5958 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5959
5960 * dbusbind.c: Pointer signedness fixes.
5961 (xd_signature, xd_append_arg, xd_initialize):
5962 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5963 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5964 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5965 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5966
5967 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5968 if GCC considers string literals to be constants.
5969 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5970
5971 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5972
5973 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5974 (print_preprocess, print_object): New macro to fix last change.
5975
5976 * print.c (print_preprocess): Don't forget font objects.
5977
5978 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5979
5980 * emacs.c (USAGE3): Doc fixes.
5981
5982 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5983
5984 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5985 structure.
5986
5987 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5988
5989 * lisp.h (VWindow_system, Qfile_name_history):
5990 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5991 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5992 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5993
5994 * w32select.c: Don't #include "keyboard.h".
5995 (run_protected): Add extern declaration for waiting_for_input.
5996
5997 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5998 * w32console.c (detect_input_pending, read_input_pending)
5999 (encode_terminal_code):
6000 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6001 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6002 (w32_system_caret_y, Qfile_name_history):
6003 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6004 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6005 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6006 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6007 * w32proc.c (Qlocal, report_file_error):
6008 * w32term.c (Vwindow_system, updating_frame):
6009 * w32uniscribe.c (initialized, uniscribe_font_driver):
6010 Remove unneeded extern declarations.
6011
6012 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6013
6014 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6015
6016 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6017
6018 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6019 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6020 These macros can no longer be used for assignment.
6021
6022 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6023 Assign struct members directly, instead of using BUF_BEGV etc.
6024 (record_buffer_markers, fetch_buffer_markers): New functions for
6025 recording and fetching special buffer markers.
6026 (set_buffer_internal_1, set_buffer_temp): Use them.
6027
6028 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6029
6030 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6031
6032 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6033 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6034
6035 * xdisp.c (hscroll_window_tree):
6036 (reconsider_clip_changes): Use PT instead of BUF_PT.
6037
6038 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6039
6040 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6041 $(EMACS_ROOT)/lib/intprops.h.
6042
6043 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6044
6045 Fix more problems found by GCC 4.5.2's static checks.
6046
6047 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6048 to unsigned char * to avoid compiler diagnostic.
6049 (xg_free_frame_widgets): Make it clear that a local variable is
6050 needed only if USE_GTK_TOOLTIP.
6051 (gdk_window_get_screen): Make it clear that this macro is needed
6052 only if USE_GTK_TOOLTIP.
6053 (int_gtk_range_get_value): New function, which avoids a diagnostic
6054 from gcc -Wbad-function-cast.
6055 (xg_set_toolkit_scroll_bar_thumb): Use it.
6056 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6057 diagnostic from gcc -Wbad-function-cast.
6058 (get_utf8_string, xg_get_file_with_chooser):
6059 Rename locals to avoid shadowing.
6060 (create_dialog): Move locals to avoid shadowing.
6061
6062 * xgselect.c (xg_select): Remove unused var.
6063
6064 * image.c (four_corners_best): Mark locals as initialized.
6065 (gif_load): Initialize transparent_p to zero (Bug#8238).
6066 Mark another local as initialized.
6067 (my_png_error, my_error_exit): Mark with NO_RETURN.
6068
6069 * image.c (clear_image_cache): Now static.
6070 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6071 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6072 (x_edge_detection): Remove unnecessary cast that
6073 gcc -Wbad-function-cast diagnoses.
6074 (gif_load): Fix pointer signedness.
6075 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6076 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6077
6078 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6079
6080 Improve quality of tests for time stamp overflow.
6081 For example, without this patch (encode-time 0 0 0 1 1
6082 1152921504606846976) returns the obviously-bogus value (-948597
6083 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6084 reports time overflow. See
6085 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6086 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6087 * editfns.c: Include limits.h and intprops.h.
6088 (TIME_T_MIN, TIME_T_MAX): New macros.
6089 (time_overflow): Move earlier, to before first use.
6090 (hi_time, lo_time): New functions, for an accurate test for
6091 out-of-range times.
6092 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6093 (Fget_internal_run_time): Don't assume time_t fits in int.
6094 (make_time): Use list2 instead of Fcons twice.
6095 (Fdecode_time): More accurate test for out-of-range times.
6096 (check_tm_member): New function.
6097 (Fencode_time): Use it, to test for out-of-range times.
6098 (lisp_time_argument): Don't rely on undefined left-shift and
6099 right-shift behavior when checking for time stamp overflow.
6100
6101 * editfns.c (time_overflow): New function, refactoring common code.
6102 (Fformat_time_string, Fdecode_time, Fencode_time):
6103 (Fcurrent_time_string): Use it.
6104
6105 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6106 * dired.c (make_time): Move to ...
6107 * editfns.c (make_time): ... here.
6108 * systime.h: Note the move.
6109
6110 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6111
6112 * fringe.c (update_window_fringes): Remove unused variables.
6113
6114 * unexmacosx.c (copy_data_segment): Also copy __got section.
6115 (Bug#8223)
6116
6117 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6118
6119 * termcap.c [MSDOS]: Include "msdos.h".
6120 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6121 Constify `char *' arguments and their references according to
6122 prototypes in tparam.h.
6123
6124 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6125
6126 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6127 Adapt all references accordingly.
6128
6129 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6130
6131 2011-03-11 Tom Tromey <tromey@redhat.com>
6132
6133 * buffer.c (syms_of_buffer): Remove obsolete comment.
6134
6135 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6136
6137 * termhooks.h (encode_terminal_code): Declare prototype.
6138
6139 * msdos.c (encode_terminal_code): Don't declare prototype.
6140
6141 * term.c (encode_terminal_code): Now external again, used by
6142 w32console.c and msdos.c.
6143
6144 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6145 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6146
6147 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6148
6149 Fix some minor problems found by GCC 4.5.2's static checks.
6150
6151 * fringe.c (update_window_fringes): Mark locals as initialized
6152 (Bug#8227).
6153 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6154
6155 * alloc.c (mark_fringe_data): Move decl from here ...
6156 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6157 to check its interface.
6158 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6159
6160 * fontset.c (free_realized_fontset): Now static.
6161 (Fset_fontset_font): Rename local to avoid shadowing.
6162 (fontset_font): Mark local as initialized.
6163 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6164
6165 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6166
6167 * xselect.c (x_disown_buffer_selections): Remove; not used.
6168 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6169 (x_own_selection, Fx_disown_selection_internal): Rename locals
6170 to avoid shadowing.
6171 (x_handle_dnd_message): Remove local to avoid shadowing.
6172
6173 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6174 so that the caller can use some name other than gcpro1.
6175 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6176 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6177 (Fx_backspace_delete_keys_p):
6178 Use them to avoid shadowing, and rename vars to avoid shadowing.
6179 (x_decode_color, x_set_name, x_window): Now static.
6180 (Fx_create_frame): Add braces to silence GCC warning.
6181 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6182 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6183 Remove unused locals.
6184 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6185 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6186 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6187 macros.
6188
6189 * xterm.h (x_mouse_leave): New decl.
6190
6191 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6192 Remove unused functions.
6193 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6194 (x_calc_absolute_position): Now static.
6195 (XTread_socket): Don't define label "out" unless it's used.
6196 Don't declare local "event" unless it's used.
6197 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6198 unless they are used.
6199 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6200 (x_fatal_error_signal): Remove; not used.
6201 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6202 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6203 (x_error_catcher, x_connection_closed, x_error_handler):
6204 (x_error_quitter, xembed_send_message, x_iconify_frame):
6205 (my_log_handler): Rename locals to avoid shadowing.
6206 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6207 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6208
6209 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6210 Rename or move locals to avoid shadowing.
6211 (tty_defined_color, merge_face_heights): Now static.
6212 (free_realized_faces_for_fontset): Remove; not used.
6213 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6214 does not deduce is never used uninitialized.
6215 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6216 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6217
6218 * terminal.c (store_terminal_param): Now static.
6219
6220 * xmenu.c (menu_highlight_callback): Now static.
6221 (set_frame_menubar): Remove unused local.
6222 (xmenu_show): Rename parameter to avoid shadowing.
6223 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6224 since they might point to immutable storage.
6225 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6226 since it's unused otherwise.
6227
6228 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6229 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6230 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6231 avoids a gcc -Wuninitialized diagnostic.
6232 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6233 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6234 does not deduce are never used uninitialized.
6235
6236 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6237
6238 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6239 * window.c (window_loop, size_window):
6240 (run_window_configuration_change_hook, enlarge_window): Likewise.
6241
6242 * window.c (display_buffer): Now static.
6243 (size_window): Mark variables that gcc -Wuninitialized
6244 does not deduce are never used uninitialized.
6245 * window.h (check_all_windows): New decl, to forestall
6246 gcc -Wmissing-prototypes diagnostic.
6247 * dispextern.h (bidi_dump_cached_states): Likewise.
6248
6249 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6250 shadowing.
6251 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6252 Include <limits.h>.
6253 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6254 and to avoid gcc -Wuninitialized warning.
6255 (load_charset_map): Mark variables that gcc -Wuninitialized
6256 does not deduce are never used uninitialized.
6257 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6258
6259 * coding.c (coding_set_source, coding_set_destination):
6260 Use "else { /* comment */ }" rather than "else /* comment */;"
6261 for clarity, and to avoid gcc -Wempty-body warning.
6262 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6263 a block, when the outer 'i' will do.
6264 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6265 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6266 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6267 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6268 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6269 Rename locals to avoid shadowing.
6270 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6271 * coding.c (emacs_mule_char, encode_invocation_designation):
6272 Now static, since they're not used elsewhere.
6273 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6274 (decode_coding_object, encode_coding_object, detect_coding_system):
6275 (decode_coding_emacs_mule): Mark variables that gcc
6276 -Wuninitialized does not deduce are never used uninitialized.
6277 (detect_coding_iso_2022): Initialize a local variable that might
6278 be used uninitialized. Leave a FIXME because it's not clear that
6279 this initialization is needed. (Bug#8211)
6280 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6281 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6282 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6283 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6284 Remove unused macros.
6285
6286 * category.c (hash_get_category_set): Remove unused local var.
6287 (copy_category_table): Now static, since it's not used elsewhere.
6288 * character.c (string_count_byte8): Likewise.
6289
6290 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6291 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6292
6293 * chartab.c (copy_sub_char_table): Now static, since it's not used
6294 elsewhere.
6295 (sub_char_table_ref_and_range, char_table_ref_and_range):
6296 Rename locals to avoid shadowing.
6297 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6298
6299 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6300 (BIDI_BOB): Remove unused macro.
6301
6302 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6303 deduce are never used uninitialized.
6304 * term.c (encode_terminal_code): Likewise.
6305
6306 * term.c (encode_terminal_code): Now static. Remove unused local.
6307
6308 * tparam.h: New file.
6309 * term.c, tparam.h: Include it.
6310 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6311 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6312 Move these decls to tparam.h, and make them agree with what
6313 is actually in tparam.c. The previous trick of using incompatible
6314 decls in different modules does not conform to the C standard.
6315 All callers of tparam changed to use tparam's actual API.
6316 * tparam.c (tparam1, tparam, tgoto):
6317 Use const pointers where appropriate.
6318
6319 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6320 * cm.h (struct cm): Likewise.
6321 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6322 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6323 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6324 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6325 (turn_on_face, init_tty): Likewise.
6326 * termchar.h (struct tty_display_info): Likewise.
6327
6328 * term.c (term_mouse_position): Rename local to avoid shadowing.
6329
6330 * alloc.c (mark_ttys): Move decl from here ...
6331 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6332
6333 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6334
6335 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6336
6337 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6338
6339 * search.c (compile_pattern_1): Remove argument regp, unused since
6340 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6341 (compile_pattern): Don't pass it.
6342
6343 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6344
6345 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6346 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6347 for ! HAVE_GTK3.
6348 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6349
6350 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6351
6352 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6353 gdk_window_get_screen, gdk_window_get_geometry,
6354 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6355 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6356 (xg_get_pixbuf_from_pixmap): New function.
6357 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6358 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6359 Call xg_get_pixbuf_from_pixmap instead of
6360 gdk_pixbuf_get_from_drawable.
6361 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6362 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6363 (xg_check_special_colors): Use GtkStyleContext and its functions
6364 for HAVE_GTK3.
6365 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6366 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6367 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6368 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6369 Call gtk_widget_get_preferred_size.
6370 (xg_frame_resized): gdk_window_get_geometry only takes 5
6371 parameters.
6372 (xg_win_to_widget, xg_event_is_for_menubar):
6373 Call gdk_x11_window_lookup_for_display.
6374 (xg_set_widget_bg): New function.
6375 (delete_cb): New function.
6376 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6377 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6378 (xg_set_background_color): Call xg_set_widget_bg.
6379 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6380 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6381 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6382 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6383 if ! HAVE_GTK3.
6384 (update_frame_tool_bar): Call gtk_widget_hide.
6385 (xg_initialize): Use GDK_KEY_g.
6386
6387 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6388 if ! HAVE_GTK3
6389 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6390
6391 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6392 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6393 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6394
6395 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6396
6397 * w32xfns.c (select_palette): Check success of RealizePalette against
6398 GDI_ERROR, not zero.
6399
6400 See ChangeLog.11 for earlier changes.
6401
6402 ;; Local Variables:
6403 ;; coding: utf-8
6404 ;; End:
6405
6406 Copyright (C) 2011 Free Software Foundation, Inc.
6407
6408 This file is part of GNU Emacs.
6409
6410 GNU Emacs is free software: you can redistribute it and/or modify
6411 it under the terms of the GNU General Public License as published by
6412 the Free Software Foundation, either version 3 of the License, or
6413 (at your option) any later version.
6414
6415 GNU Emacs is distributed in the hope that it will be useful,
6416 but WITHOUT ANY WARRANTY; without even the implied warranty of
6417 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6418 GNU General Public License for more details.
6419
6420 You should have received a copy of the GNU General Public License
6421 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.