1 2012-04-13 Ken Brown <kbrown@cornell.edu>
3 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
5 2012-04-13 Reuben Thomas <rrt@sc3d.org>
7 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
9 2012-04-11 Daniel Colascione <dancol@dancol.org>
11 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
12 against is gone. It's better to use vfork now so that when Cygwin
13 gains a new, working vfork, we use it automatically (bug#10398).
15 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
17 * window.c (save_window_save): Obey window-point-insertion-type.
19 2012-04-11 Glenn Morris <rgm@gnu.org>
21 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
23 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
25 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
27 2012-04-10 "Jason S. Cornez" <jcornez@ravenpack.com> (tiny change)
29 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
30 (force_quit_count): New var.
31 (handle_interrupt): Use it.
33 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
35 * w32.c (w32_delayed_load): Record the full path of the library
36 being loaded (bug#10424).
38 2012-04-09 Glenn Morris <rgm@gnu.org>
40 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
41 not just in the obarray, before snarfing them. (Bug#11036)
43 * Makefile.in ($(leimdir)/leim-list.el):
44 Pass EMACS rather than BUILT_EMACS.
46 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
48 * process.c (make_process):
49 * process.h: Add integer `gnutls_handshakes_tried' member to
52 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
53 Add convenience `GNUTLS_LOG2i' macro.
55 * gnutls.c (gnutls_log_function2i): Convenience log function.
56 (emacs_gnutls_read): Use new log functions,
57 `gnutls_handshakes_tried' process member, and
58 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
59 attempts per process (connection).
61 2012-04-09 Chong Yidong <cyd@gnu.org>
63 * eval.c (Fuser_variable_p, user_variable_p_eh)
64 (lisp_indirect_variable): Functions deleted.
65 (Fdefvar): Caller changed.
67 * callint.c (Finteractive, Fcall_interactively):
68 * minibuf.c (Fread_variable): Callers changed.
70 2012-04-09 Eli Zaretskii <eliz@gnu.org>
72 * xdisp.c (set_cursor_from_row): If the display string appears in
73 the buffer at position that is closer to point than the position
74 after the display string, display the cursor on the first glyph of
75 the display string. Fixes cursor display when a 'display' text
76 property immediately follows invisible text. (Bug#11094)
78 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
80 composite.c: use 'double' consistently
81 * composite.c (get_composition_id): Use 'double' consistently
82 instead of converting 'float' to 'double' and vice versa; this is
83 easier to understand and avoids a GCC warning.
85 2012-04-09 Glenn Morris <rgm@gnu.org>
87 * Makefile.in: Generate leim-list with bootstrap-emacs, in
88 preparation for dumping it with emacs. (Bug#4789)
89 (leimdir): New variable.
90 ($(leimdir)/leim-list.el): New rule.
91 (emacs$(EXEEXT)): Depend on leim-list.el.
93 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
94 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
95 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
97 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
99 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
102 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
104 * xml.c (init_libxml2_functions) [WINDOWSNT]:
105 Remove unused local variable.
107 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
109 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
110 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
111 (mark_memory): Mark Lisp_Objects only if pointers might hide in
112 objects, as mark_maybe_pointer will catch them otherwise.
113 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
114 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
116 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
118 Fix typo that broke non-Windows builds.
119 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
121 2012-04-07 Eli Zaretskii <eliz@gnu.org>
123 Support building on MS-Windows with libxml2.
125 * makefile.w32-in (OBJ2): Add xml.$(O).
126 (GLOBAL_SOURCES): Add xml.c.
127 ($(BLD)/xml.$(O)): New dependency list.
129 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
130 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
131 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
132 [!WINDOWSNT]: New macros.
133 (init_libxml2_functions, libxml2_loaded_p): New functions.
134 (parse_region): Call fn_xmlCheckVersion instead of using the macro
135 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
136 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
137 Calls xmlCleanupParser only if libxml2 was loaded (or statically
139 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
140 Call init_libxml2_functions before calling libxml2 functions.
141 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
143 * emacs.c: Don't include libxml/parser.h.
144 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
145 xmlCleanupParser directly.
147 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
149 2012-04-07 Eli Zaretskii <eliz@gnu.org>
151 * indent.c (Fvertical_motion): If there is a display string at
152 point, use it.vpos to compute how many lines to backtrack after
153 move_it_to point. (Bug#11133)
155 2012-04-06 Eli Zaretskii <eliz@gnu.org>
157 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
158 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
159 about subtle differences between FETCH_CHAR* and STRING_CHAR*
160 macros related to unification of CJK characters. For the details,
161 see the discussion following the message here:
162 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
164 2012-04-04 Chong Yidong <cyd@gnu.org>
166 * keyboard.c (Vdelayed_warnings_list): Doc fix.
168 2012-04-01 Eli Zaretskii <eliz@gnu.org>
170 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
171 instead of alloca. (Bug#11138)
173 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
175 * w32menu.c (is_simple_dialog): Properly check lisp types.
178 2012-03-31 Eli Zaretskii <eliz@gnu.org>
180 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
181 position we get to after a call to move_it_to fails the
182 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
183 only if we wind up in a string from display property. (Bug#11063)
185 * window.c (Fdelete_other_windows_internal): Invalidate the row
186 and column information about mouse highlight, so that redisplay
187 restores it after reallocating the glyph matrices. (Bug#7464)
189 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
190 string comes from a `display' text property, use the buffer
191 position of that property as if we actually saw that position in
193 (move_it_by_lines): Remove the assertion that
194 "it->current_x == 0 && it->hpos == 0" which can be legitimately
195 violated when there's a before-string at the beginning of a line.
198 2012-03-30 Eli Zaretskii <eliz@gnu.org>
200 * xdisp.c (append_space_for_newline): If the default face was
201 remapped, use the remapped face for the appended newline.
202 (extend_face_to_end_of_line): Use the remapped default face for
203 extending the face to the end of the line.
204 (display_line): Call extend_face_to_end_of_line when the default
205 face was remapped. (Bug#11068)
207 2012-03-29 Eli Zaretskii <eliz@gnu.org>
209 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
211 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
213 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
215 2012-03-27 Glenn Morris <rgm@gnu.org>
217 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
220 2012-03-26 Kenichi Handa <handa@m17n.org>
222 * dispextern.h (struct glyph): Fix previous change. Change the
223 bit length of glyphless.ch to 25 (Bug#11082).
225 2012-03-26 Chong Yidong <cyd@gnu.org>
227 * keyboard.c (Vselection_inhibit_update_commands): New variable.
228 (command_loop_1): Use it; inhibit selection update for
229 handle-select-window too (Bug#8996).
231 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
233 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
235 2012-03-25 Kenichi Handa <handa@m17n.org>
237 * dispextern.h (struct glyph): Change the bit length of
238 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
240 2012-03-24 Eli Zaretskii <eliz@gnu.org>
242 * s/ms-w32.h (tzname): Include time.h before redirecting to
243 _tzname. Fixes the MSVC build. (Bug#9960)
245 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
247 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
250 * xterm.c (XTread_socket): Only modify handling_signal if
251 !SYNC_INPUT. (Bug#11080)
253 2012-03-23 Eli Zaretskii <eliz@gnu.org>
255 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
256 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
257 when fetching a multibyte character consumes more bytes than
258 CHAR_BYTES returns, due to unification of CJK characters in
259 string_char. (Bug#11073)
261 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
263 * process.c (wait_reading_process_output): Handle pty disconnect
264 by refraining from sending oneself a SIGCHLD (bug#10933).
266 2012-03-22 Chong Yidong <cyd@gnu.org>
268 * dispextern.h (struct it): New member string_from_prefix_prop_p.
270 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
271 Mark string as coming from a prefix property.
272 (handle_face_prop): Use default face for prefix strings (Bug#4281).
273 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
275 2012-03-21 Chong Yidong <cyd@gnu.org>
277 * xfaces.c (Vface_remapping_alist): Doc fix.
279 2012-03-20 Eli Zaretskii <eliz@gnu.org>
281 * w32proc.c (Fw32_set_console_codepage)
282 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
285 2012-03-20 Chong Yidong <cyd@gnu.org>
287 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
288 to reflect default non-nil value of redisplay-dont-pause.
290 2012-03-19 Kenichi Handa <handa@m17n.org>
292 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
293 it fit in a valid range (Bug#11003).
295 2012-03-18 Eli Zaretskii <eliz@gnu.org>
297 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
298 that is not from display property, accept the row as a "cursor
299 row" if one of the string's character has a non-nil `cursor'
300 property. Fixes cursor positioning when there are newlines in
301 overlay strings, e.g. in icomplete.el. (Bug#11035)
303 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
305 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
307 2012-03-12 Chong Yidong <cyd@gnu.org>
309 * eval.c (inhibit_lisp_code): Rename from
310 inhibit_window_configuration_change_hook; move from window.c.
312 * xfns.c (unwind_create_frame_1, Fx_create_frame):
313 * window.c (run_window_configuration_change_hook)
314 (syms_of_window): Callers changed.
316 2012-03-11 Chong Yidong <cyd@gnu.org>
318 * keymap.c (Fkey_description): Doc fix (Bug#9700).
320 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
322 2012-03-10 Chong Yidong <cyd@gnu.org>
324 * frame.c (other_visible_frames): Don't assume the selected frame
325 is visible (Bug#10955).
327 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
329 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
331 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
333 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
334 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
337 2012-03-03 Glenn Morris <rgm@gnu.org>
339 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
341 2012-03-02 Eli Zaretskii <eliz@gnu.org>
343 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
344 position past the first glyph_row that ends at ZV. (Bug#10902)
345 (redisplay_window, next_element_from_string): Fix typos in
347 (redisplay_window): Pass to move_it_vertically the margin in
348 pixels, not in screen lines.
350 2012-03-02 Glenn Morris <rgm@gnu.org>
352 * buffer.c (buffer-list-update-hook): Doc fix.
354 2012-02-29 Eli Zaretskii <eliz@gnu.org>
356 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
357 push_it before setting up the iterator for the first overlay
358 string, even if we have an empty string loaded.
359 (next_overlay_string): If there's an empty string on the iterator
360 stack, pop the stack. (Bug#10903)
362 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
364 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
365 Suggested by Stefan Monnier in
366 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
367 * alloc.c (widen_to_Lisp_Object): New static function.
368 (mark_memory): Also mark Lisp_Objects by fetching pointer words
369 and widening them to Lisp_Objects. This would work even if
370 USE_LSB_TAG is defined and wide integers are used, which might
371 happen in a future version of Emacs.
373 2012-02-25 Chong Yidong <cyd@gnu.org>
375 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
378 * xselect.c (Fx_selection_exists_p): Doc fix.
379 (x_clipboard_manager_save_all): Print an informative message
380 before saving to clipboard manager.
382 2012-02-24 Chong Yidong <cyd@gnu.org>
384 * keyboard.c (process_special_events): Handle all X selection
385 requests in kbd_buffer, not just the next one (Bug#8869).
387 2012-02-23 Chong Yidong <cyd@gnu.org>
389 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
390 call when setting menu-bar-lines and tool-bar-lines parameters.
391 (unwind_create_frame_1): New helper function.
393 * window.c (inhibit_window_configuration_change_hook): New var.
394 (run_window_configuration_change_hook): Obey it.
395 (syms_of_window): Initialize it.
397 2012-02-22 Chong Yidong <cyd@gnu.org>
399 * xterm.c (x_draw_image_relief): Add missing type check for
400 Vtool_bar_button_margin (Bug#10743).
402 2012-02-21 Chong Yidong <cyd@gnu.org>
404 * fileio.c (Vfile_name_handler_alist): Doc fix.
406 * buffer.c (Fget_file_buffer): Protect against invalid file
407 handler return value.
409 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
411 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
412 when computing $valmask.
414 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
415 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
416 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
417 It's useless in that case, and it can cause problems on hosts
418 that allocate halves of EMACS_INT values separately.
419 Reported by Dan Horák. Diagnosed by Andreas Schwab in
420 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
421 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
422 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
423 it avoids undefined behavior on hosts where shifting right by more
424 than the word width has undefined behavior.
426 2012-02-19 Chong Yidong <cyd@gnu.org>
428 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
429 (Funhandled_file_name_directory, Ffile_name_as_directory)
430 (Fdirectory_file_name, Fexpand_file_name)
431 (Fsubstitute_in_file_name): Protect against invalid file handler
432 return values (Bug#10845).
434 2012-02-18 Eli Zaretskii <eliz@gnu.org>
436 * .gdbinit (pitx): Fix incorrect references to fields of the
439 2012-02-17 Chong Yidong <cyd@gnu.org>
441 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
443 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
445 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
446 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
448 2012-02-15 Chong Yidong <cyd@gnu.org>
450 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
451 marked as special. Also, starting docstrings with * is obsolete.
453 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
455 * gnutls.c (emacs_gnutls_write): Fix last change.
457 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
459 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
462 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
464 * keymap.c (Fsingle_key_description): Handle char ranges.
466 2012-02-12 Chong Yidong <cyd@gnu.org>
468 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
469 as that creates a dangerous corner case.
471 * window.c (Fdelete_window_internal): Invalidate the mouse
472 highlight (Bug#9904).
474 2012-02-12 Glenn Morris <rgm@gnu.org>
476 * xselect.c (Fx_own_selection_internal)
477 (Fx_get_selection_internal, Fx_disown_selection_internal)
478 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
479 * nsselect.m (Fx_own_selection_internal)
480 (Fx_disown_selection_internal, Fx_selection_exists_p)
481 (Fx_selection_owner_p, Fx_get_selection_internal):
482 Sync docs and argument specs with the xselect.c versions.
484 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
486 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
488 2012-02-11 Eli Zaretskii <eliz@gnu.org>
490 * w32select.c (Fx_selection_exists_p): Sync doc string and
491 argument list with xselect.c. (Bug#10783)
493 * w16select.c (Fx_selection_exists_p): Sync doc string and
494 argument list with xselect.c. (Bug#10783)
496 2012-02-10 Glenn Morris <rgm@gnu.org>
498 * fns.c (Fsecure_hash): Doc fix.
500 2012-02-09 Kenichi Handa <handa@m17n.org>
502 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
504 2012-02-07 Chong Yidong <cyd@gnu.org>
506 * buffer.c (Fbuffer_local_variables)
507 (buffer_lisp_local_variables): Handle unbound vars correctly;
508 don't let Qunbound leak into Lisp.
510 2012-02-07 Glenn Morris <rgm@gnu.org>
512 * image.c (Fimagemagick_types): Doc fix.
514 * image.c (imagemagick-render-type): Change it from a lisp object
515 to an integer. Move the doc here from the lisp manual.
516 Treat all values not equal to 0 the same.
518 2012-02-06 Chong Yidong <cyd@gnu.org>
520 * doc.c (store_function_docstring): Avoid applying docstring of
521 alias to base function (Bug#2603).
523 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
525 * .gdbinit (pp1, pv1): Remove redundant defines.
528 2012-02-04 Chong Yidong <cyd@gnu.org>
530 * nsterm.m: Declare a global (Bug#10694).
532 2012-02-04 Eli Zaretskii <eliz@gnu.org>
534 * w32.c (get_emacs_configuration_options):
535 Include --enable-checking, if specified, in the return value.
537 2012-02-04 Martin Rudalics <rudalics@gmx.at>
539 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
540 after rounding frame sizes. (Bug#9723)
542 2012-02-04 Eli Zaretskii <eliz@gnu.org>
544 * keyboard.c (adjust_point_for_property): Don't position point
545 before BEGV. (Bug#10696)
547 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
549 Handle overflow when computing char display width (Bug#9496).
550 * character.c (char_width): Return EMACS_INT, not int.
551 (char_width, c_string_width): Check for overflow when
552 computing the width; this is possible now that individual
553 characters can have unbounded width. Problem introduced
554 by merge from Emacs 23 on 2012-01-19.
556 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
558 * dbusbind.c (Fdbus_register_method): Mention the return value
559 :ignore in the docstring.
561 2012-02-02 Glenn Morris <rgm@gnu.org>
563 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
565 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
566 Unconditionally set to t. (Bug#10673)
567 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
568 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
569 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
571 2012-02-02 Kenichi Handa <handa@m17n.org>
573 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
574 0, do not call append_composite_glyph.
576 2012-02-02 Kenichi Handa <handa@m17n.org>
578 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
580 (x_produce_glyphs): If the component of a composition is a null
581 string, set it->pixel_width to 1 to avoid zero-width glyph.
583 2012-02-01 Eli Zaretskii <eliz@gnu.org>
585 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
586 first 2 arguments are identical. This makes inserting large
587 output from a subprocess an order of magnitude faster on
588 MS-Windows, where all sbrk'ed memory is always contiguous.
590 2012-01-31 Glenn Morris <rgm@gnu.org>
592 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
593 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
594 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
596 2012-01-29 Glenn Morris <rgm@gnu.org>
598 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
600 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
602 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
604 2012-01-28 Chong Yidong <cyd@gnu.org>
606 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
608 2012-01-26 Chong Yidong <cyd@gnu.org>
610 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
612 * search.c (Fsearch_forward, Fsearch_backward): Document negative
613 repeat counts (Bug#10507).
615 2012-01-26 Glenn Morris <rgm@gnu.org>
617 * lread.c (syms_of_lread): Doc fix.
619 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
621 * coding.c (encode_designation_at_bol): Change return value to
624 2012-01-25 Chong Yidong <cyd@gnu.org>
626 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
628 2012-01-21 Chong Yidong <cyd@gnu.org>
630 * floatfns.c (Fcopysign): Make the second argument non-optional,
631 since nil is not allowed anyway.
633 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
635 * process.c (read_process_output): Use p instead of XPROCESS (proc).
636 (send_process): Likewise.
638 2012-01-19 Martin Rudalics <rudalics@gmx.at>
640 * window.c (save_window_save, Fcurrent_window_configuration)
641 (Vwindow_persistent_parameters): Do not use Qstate.
644 2012-01-19 Kenichi Handa <handa@m17n.org>
646 * character.c (char_width): New function.
647 (Fchar_width, c_string_width, lisp_string_width):
648 Use char_width (Bug#9496).
650 2012-01-16 Martin Rudalics <rudalics@gmx.at>
652 * window.c (Vwindow_persistent_parameters): New variable.
653 (Fset_window_configuration, save_window_save): Handle persistent
656 2012-01-14 Eli Zaretskii <eliz@gnu.org>
658 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
659 thrashing the stack of the thread. (Bug#9087)
661 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
663 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
665 2012-01-11 Eli Zaretskii <eliz@gnu.org>
667 * xdisp.c (rows_from_pos_range): Handle the case where the
668 highlight ends on a newline. (Bug#10464)
669 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
670 he end column for display of highlight that ends on a newline
673 2012-01-11 Glenn Morris <rgm@gnu.org>
675 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
676 from load-path also when installation-directory is nil. (Bug#10208)
678 2012-01-10 Glenn Morris <rgm@gnu.org>
680 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
682 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
683 Update template values to be closer to their typical values these days.
685 2012-01-09 Eli Zaretskii <eliz@gnu.org>
687 * xdisp.c (rows_from_pos_range): Accept additional argument
688 DISP_STRING, and accept any glyph in a row whose object is that
689 string as eligible for mouse highlight. Fixes mouse highlight of
690 display strings from overlays. (Bug#10464)
692 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
694 emacs: fix an auto-save permissions race condition (Bug#10400)
695 * fileio.c (auto_saving_dir_umask): New static var.
696 (Fmake_directory_internal): Use it.
697 (do_auto_save_make_dir): Set it, instead of invoking chmod after
698 creating the directory. The old code temporarily assigns
699 too-generous permissions to the directory.
700 (do_auto_save_eh): Clear it.
701 (Fdo_auto_save): Catch all errors, not just file errors, so
702 that the var is always cleared.
704 2012-01-07 Eli Zaretskii <eliz@gnu.org>
706 * search.c (scan_buffer): Pass character positions to
707 know_region_cache, not byte positions. (Bug#6540)
709 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
711 * w32.c (sys_rename): Report EXDEV when rename of a directory
712 fails because the target is on another logical disk. (Bug#10284)
714 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
716 * xterm.c (x_embed_request_focus): New function.
718 * xterm.h: Add prototype.
720 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
722 2012-01-05 Glenn Morris <rgm@gnu.org>
724 * emacs.c (emacs_copyright): Update short copyright year to 2012.
726 2012-01-01 Eli Zaretskii <eliz@gnu.org>
728 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
729 Load gnutls_transport_set_lowat only if GnuTLS version is below
731 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
732 GnuTLS versions below 2.11.1.
734 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
736 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
737 to the doc string advising against its use for altering the way
738 windows are scrolled.
740 2011-12-28 Kenichi Handa <handa@m17n.org>
742 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
743 coding-system ASCII compatible only when it does not produce BOM
744 on encoding (Bug#10383).
746 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
748 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
750 (create_and_show_popup_menu): Always use menu_position_func for
753 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
755 * callint.c (Fcall_interactively): Don't truncate prompt string.
757 2011-12-23 Eli Zaretskii <eliz@gnu.org>
759 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
760 property that ends at ZV, so that the bidi iteration could be
761 resumed from there (after widening). (Bug#10360)
763 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
765 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
767 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
769 * nsterm.m (x_free_frame_resources):
770 Release f->output_data.ns->miniimage.
771 (ns_index_color): Fix indentation. Do not retain
772 color_table->colors[i].
774 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
777 * nsfns.m (x_set_background_color): Assign return value from
778 ns_index_color to face-background instead of NSColor*.
779 (ns_implicitly_set_icon_type): Fix indentation.
780 Change assignment in for loop to comparison.
782 * emacs.c (ns_pool): New variable.
783 (main): Assign ns_pool.
784 (Fkill_emacs): Call ns_release_autorelease_pool.
786 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
787 autorelease fdesc, release fdAttrs and tdict.
788 (ns_get_covering_families): Release charset.
789 (ns_findfonts): Release NSFontDescriptor created with new.
790 (ns_uni_to_glyphs): Fix indentation.
791 (setString): Release attrStr before assigning new value.
793 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
795 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
797 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
798 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
800 2011-12-18 David Reitter <reitter@cmu.edu>
802 * nsterm.m (ns_term_init): Subscribe for notifications
803 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
804 to method trackingNotification in EmacsMenu.
806 * nsmenu.m (trackingMenu): New variable.
807 (trackingNotification): New method (from Aquamacs).
808 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
809 from Aquamacs (Bug#7030).
811 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
813 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
814 (symbol_to_nsstring): Fix indentation.
815 (ns_symbol_to_pb): New function.
816 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
817 (Fns_rotate_cut_buffers_internal): Remove.
818 (Fns_store_selection_internal): Rename from
819 Fns_store_cut_buffer_internal.
820 (ns_get_foreign_selection, Fx_own_selection_internal)
821 (Fx_disown_selection_internal, Fx_selection_exists_p)
822 (Fns_get_selection_internal, Fns_store_selection_internal):
823 Use ns_symbol_to_pb and check if return value is nil.
824 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
825 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
826 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
827 renamed to Sns_store_selection_internal.
828 (ns_handle_selection_request): Move code to Fx_own_selection_internal
829 and remove this function.
830 (ns_handle_selection_clear): Remove, never used.
831 (Fx_own_selection_internal): Move code from ns_handle_selection_request
834 2011-12-17 Ken Brown <kbrown@cornell.edu>
836 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
837 GID is unknown (Bug#10257).
839 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
841 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
842 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
843 which caused a build failure on GNU/Linux IA-64. This problem was
844 introduced by my 2011-10-07 patch.
846 2011-12-15 Juri Linkov <juri@jurta.org>
848 * image.c (imagemagick_error): New function. (Bug#10112)
849 (imagemagick_load_image): Comment out `MagickSetResolution' call.
850 Use `imagemagick_error' where ImageMagick functions return
852 (Fimagemagick_types): Add `Fnreverse' to return the list in the
855 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
857 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
858 fill background (Bug#8992).
860 2011-12-13 Martin Rudalics <rudalics@gmx.at>
862 * window.c (Vwindow_combination_resize)
863 (Vwindow_combination_limit): Use t instead of non-nil in
865 (Vrecenter_redisplay): Add first sentence of doc-string on
867 (Frecenter): Fix doc-string typo.
869 2011-12-11 Kenichi Handa <handa@m17n.org>
871 * coding.c (Funencodable_char_position): Pay attention to the
872 buffer text relocation (Bug#9389).
874 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
876 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
877 gtk_init (Bug#10100).
879 2011-12-10 Eli Zaretskii <eliz@gnu.org>
881 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
882 IT->string is nil. (Bug#10263)
884 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
886 * nsterm.h (x_free_frame_resources): Declare.
888 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
889 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
891 * nsterm.h (ns_get_defaults_value): Declare.
893 * nsterm.m (ns_default): Call ns_get_defaults_value.
895 2011-12-09 Eli Zaretskii <eliz@gnu.org>
897 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
900 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
902 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
903 that where the value of an _OBJC_* symbol points to is in the .bss
906 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
908 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
909 after the loop to call ccl_driver at least once (Bug#8619).
911 2011-12-08 Kenichi Handa <handa@m17n.org>
913 * ftfont.c (get_adstyle_property): Fix previous change
916 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
918 * w32.c (init_environment): If no_site_lisp, remove site-lisp
919 dirs from the default value of EMACSLOADPATH (bug#10208).
921 2011-12-07 Glenn Morris <rgm@gnu.org>
923 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
924 installation and source directories as well. (Bug#10208)
926 2011-12-06 Chong Yidong <cyd@gnu.org>
928 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
930 2011-12-06 Glenn Morris <rgm@gnu.org>
932 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
933 as an error, not just -1. (Bug#10217)
935 2011-12-05 Chong Yidong <cyd@gnu.org>
937 * keyboard.c (process_special_events): New function.
938 (swallow_events, Finput_pending_p): Use it (Bug#10195).
940 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
942 * coding.c (encode_designation_at_bol): Don't use uninitialized
943 local variable (Bug#9318).
945 2011-12-05 Kenichi Handa <handa@m17n.org>
947 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
948 return Qnil (Bug#8046, Bug#10193).
950 2011-12-05 Kenichi Handa <handa@m17n.org>
952 * coding.c (encode_designation_at_bol): New args charbuf_end and
953 dst. Return the number of produced bytes. Callers changed.
954 (coding_set_source): Return how many bytes coding->source was
956 (coding_set_destination): Return how many bytes
957 coding->destination was relocated.
958 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
959 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
961 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
963 * coding.c (CODING_CHAR_CHARSET_P): New macro.
964 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
967 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
969 The following changes are to fix Bug#9318.
971 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
972 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
973 (encode_coding_iso_2022, encode_coding_sjis)
974 (encode_coding_big5, encode_coding_charset): Use the above macros.
976 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
978 * lisp.h (process_quit_flag): Fix external declaration.
980 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
982 Don't macro-inline non-performance-critical code.
983 * eval.c (process_quit_flag): New function.
984 * lisp.h (QUIT): Use it.
986 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
988 * nsfns.m (get_geometry_from_preferences): New function.
989 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
991 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
993 * emacs.c (Qkill_emacs): Define.
994 (syms_of_emacs): Initialize it.
995 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
996 Qquit_flag to `kill-emacs' instead.
997 (quit_throw_to_read_char): Add parameter `from_signal'.
998 All callers changed. Call Fkill_emacs if requested and safe.
999 * lisp.h (QUIT): Call Fkill_emacs if requested.
1001 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1003 * widget.c (update_wm_hints): Return if wmshell is null.
1004 (widget_update_wm_size_hints): New function.
1006 * widget.h (widget_update_wm_size_hints): Declare.
1008 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1009 widget_update_wm_size_hints (Bug#10104).
1011 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1013 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1014 before a newline, prepare the bidi iterator for consuming the
1015 newline, and keep the current paragraph direction. (Bug#10183)
1016 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1018 2011-12-02 Juri Linkov <juri@jurta.org>
1020 * search.c (Fword_search_regexp): New Lisp function created from
1021 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1022 (Fword_search_backward, Fword_search_forward)
1023 (Fword_search_backward_lax, Fword_search_forward_lax):
1024 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1025 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1027 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1029 * fileio.c (Finsert_file_contents): Move after-change-function call
1030 to before the "handled:" label, since all "goto handled" appear in
1031 cases where the *-change-functions have already been properly called
1034 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1036 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1037 waiting for input. (Bug#10169)
1039 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1041 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1042 verifies glyph row's hash code--we have just reallocated the
1043 glyphs, so their contents can be complete garbage. (Bug#10164)
1045 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1047 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1049 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1051 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1052 attributes are tested _before_ calling verify_row_hash, to protect
1053 against GCC re-ordering of the tests. (Bug#10164)
1055 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1057 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1059 * xterm.c (handle_one_xevent): Only set async_visible and friends
1060 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1061 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1062 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1064 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1066 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1067 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1068 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1069 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1070 All uses changed to use GCPRO1 etc.
1071 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1072 Revert to old implementation (i.e., before 2011-03-11).
1074 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1076 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1077 of scroll runs so as to avoid assigning disabled bogus rows and
1078 unnecessary graphics copy operations.
1080 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1082 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1083 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1084 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1085 (malloc, free, realloc, calloc): Redirect to e_* only when
1088 * lisp.h (GCTYPEBITS): Move before first use.
1089 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1090 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1091 this macro definition.
1093 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1096 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1098 * gtkutil.c (xg_create_frame_widgets):
1099 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1100 present with Gtk+ 2.0.
1102 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1104 * fileio.c (Finsert_file_contents): Undo previous change; see
1105 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1107 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1109 Rename locals to avoid shadowing.
1110 * fileio.c (Finsert_file_contents):
1111 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1112 * process.c (wait_reading_process_output):
1113 Rename inner 'proc' to 'p' to avoid shadowing.
1114 Indent for consistency with usual Emacs style.
1116 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1118 * xdisp.c (redisplay_window): If cursor row is not fully visible
1119 after recentering, and scroll-conservatively is set to a large
1120 number, scroll window by a few more lines to make the cursor fully
1121 visible and out of scroll-margin. (Bug#10105)
1122 (start_display): Don't move to the next line if the display should
1123 start at a newline that is part of a display vector or an overlay
1126 2011-11-24 Juri Linkov <juri@jurta.org>
1128 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1129 after the `MagickPingImage' call. (Bug#10112)
1131 2011-11-23 Chong Yidong <cyd@gnu.org>
1133 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1135 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1137 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1138 making another buffer current. (Bug#10114)
1140 2011-11-23 Glenn Morris <rgm@gnu.org>
1142 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1144 2011-11-23 Chong Yidong <cyd@gnu.org>
1146 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1147 using it (Bug#5984).
1149 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1151 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1152 and header-lines, as they don't have one computed for them.
1155 * .gdbinit (prow): Make displayed values more self-explaining.
1156 Add row's hash code.
1158 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1160 * process.c (wait_reading_process_output): Fix asynchrounous
1161 GnuTLS socket handling on some versions of the GnuTLS library.
1162 (wait_reading_process_output): Add comment and URL.
1164 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1166 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1168 2011-11-21 Chong Yidong <cyd@gnu.org>
1170 * window.c (Fnext_window, Fprevious_window): Doc fix.
1172 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1174 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1176 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1178 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1180 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1182 * window.c (Fset_window_combination_limit): Rename argument
1184 (Vwindow_combination_limit): Remove "status" from doc-string.
1186 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1188 * m/ibms390.h: Remove.
1189 * m/ibms390x.h: Don't include "ibms390.h".
1191 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1193 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1194 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1196 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1198 * casetab.c (Fset_case_table):
1199 * charset.c (Fcharset_after): Fix typos.
1201 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1203 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1204 Otherwise, valgrind does not work on some platforms.
1205 Problem reported by Andreas Schwab in
1206 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1207 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1208 is set, removing the need for VIRT_ADDRESS_VARIES.
1209 (PURE_P): Use a more-efficient implementation that needs just one
1210 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1211 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1212 to 4 (xorl, subq, cmpq, setbe).
1213 * alloc.c (pure): Always extern now, since that's the
1214 VIRT_ADDR_VARIES behavior.
1215 (PURE_POINTER_P): Use a single comparison, not two, for
1216 consistency with the new puresize.h.
1217 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1218 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1219 Remove VIRT_ADDR_VARIES no longer needed.
1221 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1223 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1224 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1225 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1226 behave as if the cursor position were at the window margin.
1228 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1229 and the cursor position is out of bounds, behave as if the cursor
1230 position were at the window margin. (Bug#10075)
1232 2011-11-18 Chong Yidong <cyd@gnu.org>
1234 * window.c (Fwindow_combination_limit): Make first argument
1235 non-optional, since it is meaningless for live windows like the
1238 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1240 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1242 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1244 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1245 (graft_intervals_into_buffer): Simplify.
1247 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1249 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1250 hash values of the two rows.
1251 (copy_row_except_pointers): Preserve the used[] arrays and the
1252 hash values of the two rows. (Bug#10035)
1253 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1255 * xdisp.c (row_hash): New function, body extracted from
1256 compute_line_metrics.
1257 (compute_line_metrics): Call row_hash, instead of computing the
1260 * dispnew.c (verify_row_hash): Call row_hash for computing the
1261 hash code of a row, instead of duplicating code from xdisp.c.
1263 * dispextern.h (row_hash): Add prototype.
1265 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1267 * frame.c (delete_frame): Don't delete the terminal when the last
1268 X frame is closed if emacs is built with GTK toolkit.
1270 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1272 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1274 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1276 * window.c (Vwindow_splits): Rename to
1277 Vwindow_combination_resize. Suggested by Juri Linkov.
1278 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1281 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1283 * nsfns.m (Fns_font_name):
1284 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1286 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1288 * window.h (window): Rename slot "nest" to "combination_limit".
1289 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1290 (Fset_window_nest): Rename to Fset_window_combination_limit.
1291 (Vwindow_nest): Rename to Vwindow_combination_limit.
1292 (recombine_windows, make_parent_window, make_window)
1293 (Fsplit_window_internal, saved_window)
1294 (Fset_window_configuration, save_window_save): Rename all
1295 occurrences of window_nest to window_combination_limit.
1297 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1299 * image.c (imagemagick_load_image): Fix typo.
1301 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1303 * xdisp.c (display_line): Move the call to
1304 highlight_trailing_whitespace before the call to
1305 compute_line_metrics, since the latter needs to see the final
1306 faces of all the glyphs to compute ROW's hash value.
1307 Fixes assertion violations in row_equal_p. (Bug#10035)
1309 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1311 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1312 just return (bug#10044).
1314 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1316 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1317 with user-defined heap size. Bump the default size of the temacs
1318 heap to 27MB, to avoid memory warning when running temacs.
1319 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1321 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1322 current_matrix and desired_matrix. (Bug#9990)
1323 (verify_row_hash) [XASSERTS]: New function.
1324 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1325 that the hash value of glyph rows is correct.
1327 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1329 * window.h (window): Remove splits slot.
1330 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1331 (Fdelete_other_windows_internal, make_parent_window)
1332 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1333 (Fset_window_configuration, save_window_save): Don't deal with
1334 split status of windows.
1335 (saved_window): Remove splits slot.
1336 (Vwindow_splits): Rewrite doc-string.
1338 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1340 * xfns.c (unwind_create_frame):
1341 * nsfns.m (unwind_create_frame):
1342 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1343 Vframe_list (Bug#9999).
1345 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1347 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1349 2011-11-11 Kenichi Handa <handa@m17n.org>
1351 * callproc.c (Fcall_process): Set the member dst_multibyte of
1354 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1356 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1357 avoid a crash (bug#9496).
1359 2011-11-09 Chong Yidong <cyd@gnu.org>
1361 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1362 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1364 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1366 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1368 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1370 Avoid some portability problems by eschewing 'extern inline' functions.
1371 The trivial performance wins aren't worth the portability hassles; see
1372 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1374 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1375 (window_box_width, window_box_left, window_box_left_offset)
1376 (window_box_right, window_box_right_offset): Undo previous change,
1377 by removing the "extern"s.
1378 * intervals.c (adjust_intervals_for_insertion)
1379 (adjust_intervals_for_deletion): Undo previous change,
1380 making these static again.
1381 (offset_intervals, temp_set_point_both, temp_set_point)
1382 (copy_intervals_to_string): No longer inline.
1383 * xdisp.c (window_text_bottom_y, window_box_width)
1384 (window_box_height, window_box_left_offset)
1385 (window_box_right_offset, window_box_left, window_box_right)
1386 (window_box): No longer inline.
1388 2011-11-08 Chong Yidong <cyd@gnu.org>
1390 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1391 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1392 Signal an error if not a live window.
1393 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1394 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1396 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1398 * lisp.h (syms_of_abbrev): Remove declaration.
1399 Reported by CHENG Gao <chenggao@royau.me>.
1401 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1403 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1404 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1405 of temacs in GUI mode.
1407 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1409 * window.h: Declare delete_all_child_windows instead of
1410 delete_all_subwindows.
1411 * window.c (Fwindow_nest, Fset_window_nest)
1412 (Fset_window_new_total, Fset_window_new_normal)
1413 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1414 (delete_all_subwindows): Rename to delete_all_child_windows.
1415 (Fdelete_other_windows_internal, Fset_window_configuration):
1416 Call delete_all_child_windows instead of delete_all_subwindows.
1417 * frame.c (delete_frame): Call delete_all_child_windows instead
1418 of delete_all_subwindows.
1420 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1422 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1423 This is also needed for porting to any host where GC_MARK_STACK is
1424 not GC_MAKE_GCPROS_NOOPS.
1425 (which_symbols): Use it.
1427 2011-11-07 Kenichi Handa <handa@m17n.org>
1429 * coding.c (coding_set_destination): Check coding->src_pos only
1430 when coding->src_object is a buffer (bug#9910).
1432 * process.c (send_process): Set the member src_multibyte of coding
1433 to 0 (bug#9911) when sending a unibyte text.
1435 * callproc.c (Fcall_process): Set the member src_multibyte of
1436 process_coding to 0 (bug#9912).
1438 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1440 * xmenu.c (cleanup_widget_value_tree): New function.
1441 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1442 calling free_menubar_widget_value_tree directly (Bug#9830).
1444 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1446 Fix some portability problems with 'inline'.
1447 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1448 (window_box_width, window_box_left, window_box_left_offset)
1449 (window_box_right, window_box_right_offset): Declare extern.
1450 Otherwise, these inline functions do not conform to C99 and
1451 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1452 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1453 * intervals.c (adjust_intervals_for_insertion)
1454 (adjust_intervals_for_deletion): Now extern, because otherwise the
1455 extern inline functions 'offset_intervals' couldn't refer to it.
1456 (static_offset_intervals): Remove.
1457 (offset_intervals): Rewrite using the old contents of
1458 static_offset_intervals. The old version didn't conform to C99
1459 because an extern inline function contained a reference to an
1460 identifier with static linkage.
1462 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1464 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1467 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1469 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1470 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1471 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1472 return Qleft_to_right.
1474 2011-11-06 Chong Yidong <cyd@gnu.org>
1476 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1477 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1478 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1479 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1480 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1481 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1482 (Fwindow_vscroll): Doc fix.
1483 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1484 argument, since it makes no sense to pass a live window and for
1485 consistency with window-child.
1487 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1489 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1492 2011-11-05 Jason Rumney <jasonr@gnu.org>
1494 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1495 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1497 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1498 bitwise arithmetic preventing use of unicode-sip and non-truetype
1501 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1503 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1506 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1507 initialization code to keep similarity to xfns.c after changes
1510 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1512 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1513 (unwind_create_frame): New function (Bug#9943).
1514 (Fx_create_frame): Restructure code to be more similar to the one in
1515 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1516 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1517 Move terminal->reference_count++ just before making the frame official
1520 * nsterm.m (x_free_frame_resources): New function.
1521 (x_destroy_window): Move code to x_free_frame_resources.
1523 * xfns.c (unwind_create_frame): Fix comment.
1524 (Fx_create_frame, x_create_tip_frame):
1525 Move terminal->reference_count++ just before making the frame
1526 official. Move initialization of image_cache_refcount and
1527 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1529 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1531 Support MSVC build with newer versions of Visual Studio.
1532 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1533 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1536 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1537 which are not supported by MSVC.
1538 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1539 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1541 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1543 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1545 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1547 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1549 Support MSVC build with newer versions of Visual Studio.
1550 * w32.c: Don't include w32api.h for MSVC.
1551 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1553 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1554 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1555 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1556 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1558 (alloca) [_MSC_VER]: Define to _alloca.
1560 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1562 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1564 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1566 * xdisp.c (note_mouse_highlight): If either of
1567 previous/next-single-property-change returns nil, treat that as
1568 the beginning or the end of the buffer. (Bug#9955)
1570 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1572 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1573 label is not null (Bug#9951).
1574 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1577 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1579 * window.c (Fwindow_body_size): Mention in the doc string that the
1580 return value is in frame's canonical units. (Bug#9949)
1582 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1584 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1586 * w32fns.c (unwind_create_frame): If needed, free the glyph
1587 matrices of the partially constructed frame. (Bug#9943)
1588 * xfns.c (unwind_create_frame): Likewise.
1590 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1592 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1593 Don't stop backward scan on the continuation glyph, even though
1594 its CHARPOS is positive.
1595 (mouse_face_from_buffer_pos, note_mouse_highlight):
1596 Rename cover_string to disp_string.
1598 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1600 * window.c (temp_output_buffer_show): Don't use
1601 Vtemp_buffer_show_specifiers.
1602 (Vtemp_buffer_show_specifiers): Remove unused variable.
1604 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1606 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1607 past the beginning of the current glyph matrix.
1609 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1611 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1612 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1613 HAVE_GTK3 (Bug#9869).
1615 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1616 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1618 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1620 * xterm.c: Declare x_handle_net_wm_state to return int.
1621 (handle_one_xevent): Check if we are iconified but don't have
1622 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1623 (get_current_wm_state): Return non-zero if not hidden,
1624 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1625 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1626 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1627 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1629 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1631 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1632 so that this new function doesn't get optimized away by a
1633 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1635 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1637 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1639 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1641 Fix the `xbytecode' command.
1642 * .gdbinit (xprintbytestr): New command.
1643 (xwhichsymbols): Rename from `which'; all callers changed.
1644 (xbytecode): Print the byte-code string as well.
1646 2011-10-29 Kim Storm <storm@cua.dk>
1648 * alloc.c (which_symbols): New function.
1650 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1652 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1655 2011-10-29 Glenn Morris <rgm@gnu.org>
1657 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1658 Not clear what it was for, and it causes various bugs. (Bug#9839)
1660 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1662 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1663 possible random value that matches one of those tested as
1664 condition to clear the mouse face.
1666 2011-10-28 Chong Yidong <cyd@gnu.org>
1668 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1670 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1672 * window.c (make_window): Initialize phys_cursor_on_p.
1674 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1676 * lisp.h (struct Lisp_Symbol): Update comments.
1678 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1680 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1682 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1684 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1685 <oslsachem@gmail.com> for helping to debug this.
1687 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1688 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1689 (g_b_init_get_glyph_outline_w): New static variables.
1690 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1691 (GetGlyphOutlineW_Proc): New typedefs.
1692 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1693 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1695 (w32font_open_internal, compute_metrics):
1696 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1697 instead of calling the "wide" APIs directly.
1699 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1701 * w32.h (syms_of_w32font): Add prototype.
1703 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1705 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1706 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1707 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1708 (Fmove_to_window_line): Doc fix.
1710 2011-10-27 Chong Yidong <cyd@gnu.org>
1712 * process.c (make_process): Set gnutls_state to NULL.
1714 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1715 non-NULL, regardless of GNUTLS_INITSTAGE.
1716 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1717 an error. Set process slots as soon as we allocate them.
1719 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1721 2011-10-27 Chong Yidong <cyd@gnu.org>
1723 * gnutls.c (emacs_gnutls_deinit): New function.
1724 Deallocate credentials structures as well as calling gnutls_deinit.
1725 (Fgnutls_deinit, Fgnutls_boot): Use it.
1727 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1728 (deactivate_process): Call emacs_gnutls_deinit.
1730 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1732 * image.c (x_create_x_image_and_pixmap):
1733 * w32.c (sys_rename, w32_delayed_load):
1734 * w32font.c (fill_in_logfont):
1735 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1737 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1739 * w32fns.c (w32_default_color_map): New function,
1740 extracted from Fw32_default_color_map.
1741 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1743 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1745 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1747 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1749 * keyboard.c (test_undefined): New function (bug#9751).
1750 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1752 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1754 * sysdep.c (init_sys_modes): Fix the check for the controlling
1755 terminal (Bug#6649).
1757 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1759 * dispextern.h (struct bidi_it): New member next_en_type.
1761 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1762 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1763 current character, check also for next_en_type being WEAK_EN.
1764 (bidi_resolve_weak): Don't enter the expensive loop if the current
1765 position is before next_en_pos. Record the bidi type of the first
1766 non-ET, non-BN character we find, in addition to its position.
1767 (bidi_level_of_next_char): Invalidate next_en_type when
1768 next_en_pos is over-stepped.
1770 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1772 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1773 * editfns.c: Rewrite current-time-zone so that it invokes
1774 the equivalent of (format-time-string "%Z") to get the time zone name.
1775 This fixes a bug when the time zone name contains characters that
1776 need converting from the system time locale to Emacs internal format.
1777 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1778 that patch fixed format-time-string to do the conversion, but
1779 I forgot to fix current-time-zone.
1780 (format_time_string): New function, containing most of
1781 what Fformat_time_string used to contain.
1782 (Fformat_time_string): Rewrite in terms of format_time_string.
1783 This doesn't change this function's behavior.
1784 (current-time-zone): Rewrite to use format_time_string.
1785 This fixes the bug reported by Michael Schierl in
1786 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1787 Jason Rumney's 2007-06-07 change worked around this bug, but
1789 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1791 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1793 * xdisp.c (start_display): If the character at POS is displayed
1794 via a display vector, reset IT->current.dpvec_index to zero.
1795 (try_window_reusing_current_matrix): If a line ends in a display
1796 vector or the next line starts in a display vector, continue
1797 redrawing the window even though the character position of
1798 start_row was reached.
1801 2011-10-18 Chong Yidong <cyd@gnu.org>
1803 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1804 with nobreak-char-display too.
1806 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1808 Fix part 3 of bug#9771.
1809 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1810 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1811 non-neutral characters if the current character is a paragraph
1812 separator (a.k.a. Newline). This avoids running the same
1813 expensive loop twice, once when we consume the preceding newline
1814 and the other time when the line actually needs to be displayed.
1815 Avoid the loop when we see neutrals on the base embedding level
1816 following a character whose directionality is the same as the
1817 paragraph's. This avoids running the expensive loop when a line
1818 ends in a long sequence of neutrals, like control characters.
1819 Add assertion against STRONG_AL type. Slightly rearrange code
1820 that determines the type of a neutral given the first non-neutral
1822 (bidi_level_of_next_char): Set next_en_pos to zero when
1823 invalidating its info.
1825 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1827 * xdisp.c (push_display_prop): Determine whether to record string
1828 or buffer position by IT->string, not by IT->method. Allow
1829 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1830 (move_it_vertically_backward): Don't look for character position
1831 immediately after the newline when in a continuation line.
1834 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1836 * window.c (coordinates_in_window): Rewrite and delabelize
1837 vertical border check. (Bug#5357) (Bug#9618)
1839 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1841 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1842 errors in XSetWindowBorder (bug#9310).
1844 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1846 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1847 avoid crash when xmalloc overrun checking is enabled.
1849 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1851 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1852 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1853 cursor motion with <left> and <right> arrow keys.
1855 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1856 some callers set that themselves.
1858 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1860 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1861 display string and the previous row comes from the same string and
1862 is empty. (Bug#9739) (Bug#9738)
1864 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1866 * doc.c (get_doc_string): Encode file name (bug#9735).
1868 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1870 * bidi.c (bidi_level_of_next_char):
1871 * xdisp.c (get_visually_first_element): Remove old incorrect
1872 comments regarding the Unicode Line Separator character.
1874 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1876 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1878 * alloc.c (Fgc_status): Do not access beyond zombies array
1879 boundary if nzombies > MAX_ZOMBIES.
1880 * alloc.c (dump_zombies): Add missing format specifier.
1882 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1884 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1885 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1887 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1888 Some packages use them to denote characters with modifiers.
1890 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1892 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1893 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1894 matching a pp-number. Rename parameter var to var1.
1896 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1898 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1900 2011-10-08 Glenn Morris <rgm@gnu.org>
1902 * callint.c (Fcall_interactively): Give a more explicit error for the
1903 'c' case with a non-character input. (Bug#8479)
1905 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1907 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1909 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1910 lines that are hscrolled on the left.
1912 * dispnew.c (buffer_posn_from_coords): Account for a possible
1913 presence of header-line. (Bug#4426)
1915 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1917 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1918 Don't advertise functionality which we discourage or doesn't work.
1920 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1922 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1923 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1924 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1925 this makes Emacs dump core during garbage collection on rare
1926 occasions. sizeof is obviously inferior to offsetof here, so
1927 stick with offsetof.
1928 (GC_POINTER_ALIGNMENT): New macro.
1929 (mark_memory): Omit 3rd (offset) arg; caller changed.
1930 Don't assume EMACS_INT alignment is the same as pointer alignment.
1932 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1934 * keyboard.c (read_key_sequence_remapped): New var.
1935 (read_key_sequence): Compute remapping in the right buffer.
1936 (command_loop_1): Use read_key_sequence's remapping directly.
1938 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1940 * dired.c (file_name_completion): Don't expand file name.
1941 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1942 before checking file name handler.
1944 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1945 they've been requested explicitly (bug#9591).
1947 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1949 * keymap.c (Fsingle_key_description): Use make_specified_string
1950 instead of build_string to build string from push_key_description.
1953 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1955 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1956 This fixes a Y2038 bug on 64-bit hosts.
1957 * buffer.c (reset_buffer):
1958 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1959 (Fclear_buffer_auto_save_failure):
1960 Use 0, not -1, to represent an unset failure time, since time_t
1961 might not be signed.
1963 Remove dependency on glibc malloc internals.
1964 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1965 Move back here from lisp.h, but with their new implementations.
1966 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1967 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1968 * charset.c (charset_table_init): New static var.
1969 (syms_of_charset): Use it instead of xmalloc. This removes a
1970 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1971 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1972 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1973 Move back to alloc.c.
1974 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1975 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1977 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1979 * nsterm.m (windowDidResize): Call x_set_window_size only when
1980 ns_in_resize is true. Otherwise set pixelwidth/height and
1981 call change_frame_size (Bug#9628).
1983 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1985 Port --enable-checking=all to Fedora 14 x86-64.
1986 * charset.c (syms_of_charset): Also account for glibc malloc's
1987 internal overhead when calculating the initial malloc maximum.
1989 Port --enable-checking=all to Fedora 14 x86.
1990 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1992 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1993 (overrun_check_realloc, overrun_check_free):
1994 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1995 That way, xmalloc returns a properly-aligned pointer even if
1996 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1997 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1998 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1999 into account when calculating the initial malloc maximum.
2000 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2001 Move here from alloc.c, so that charset.c can use it too.
2002 Properly align; the old code wasn't right for common 32-bit hosts
2003 when configured with --enable-checking=all.
2004 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2005 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2007 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2009 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2012 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2014 * xdisp.c (compute_display_string_end): If there's no display
2015 string at CHARPOS, return -1.
2017 * bidi.c (bidi_fetch_char): When compute_display_string_end
2018 returns a negative value, treat the character as a normal
2019 character not covered by a display string. (Bug#9624)
2021 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2023 * lread.c (Fread_from_string): Fix typo in docstring.
2025 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2027 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2028 newline, reseat the iterator instead of bidi-iterating there one
2029 character at a time. (Bug#9610)
2030 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2031 TO_CHARPOS if the bidi iterator is at base embedding level.
2033 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2035 * lread.c (readevalloop): Use correct code for NBSP.
2036 (read1): Likewise. (Bug#9608)
2038 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2040 * dbusbind.c (Fdbus_register_signal): When service is not
2041 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2043 2011-09-25 Glenn Morris <rgm@gnu.org>
2045 * buffer.c (truncate-lines): Doc fix.
2047 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2049 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2050 (Fset_window_next_buffers): Doc fix.
2052 2011-09-24 Glenn Morris <rgm@gnu.org>
2054 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2056 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2058 Fix minor problems found by static checking.
2059 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2060 * indent.c (Fvertical_motion): Fix == vs = typo.
2062 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2064 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2065 Default value is now t. Doc fix.
2067 * indent.c (Fvertical_motion): Compute and apply the overshoot
2068 logic when moving up, not only when moving down. Fix the
2069 confusing name and values of the it_overshoot_expected variable;
2070 logic changes accordingly. (Bug#9254) (Bug#9549)
2072 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2073 CHARPOS is covered by a display string which includes newlines.
2074 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2075 is covered by a display string with embedded newlines.
2077 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2079 * dbusbind.c (Fdbus_register_signal): Add match rule to
2080 Vdbus_registered_objects_table. (Bug#9581)
2081 (Fdbus_register_method, Vdbus_registered_objects_table):
2084 2011-09-24 Jim Meyering <meyering@redhat.com>
2086 do not ignore write error for any output size
2087 The previous change was incomplete.
2088 While it makes emacs --batch detect the vast majority of stdout
2089 write failures, errors were still ignored whenever the output size is
2090 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2091 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2092 && echo FAIL: ignored write error
2093 FAIL: ignored write error
2094 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2095 && echo FAIL: ignored write error
2096 FAIL: ignored write error
2097 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2099 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2101 * emacs.c (Fkill_emacs): In noninteractive mode exit
2102 non-successfully if a write error occurred on stdout. (Bug#9574)
2104 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2106 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2109 * dispextern.h (struct it): Update the comment documenting what
2112 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2114 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2115 a display string, extend search for cursor position to end of row.
2116 (find_row_edges): If the row ends in a newline from a display
2117 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2118 Handle the case of a display string with multiple newlines.
2119 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2120 non-empty line. Fixes confusing cursor motion with arrow keys at
2121 the beginning of a line that starts with whitespace.
2123 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2125 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2128 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2130 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2133 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2135 * xdisp.c (display_line): Record maximum and minimum buffer
2136 positions even if no glyphs were produced (e.g., by a zero-width
2137 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2138 buffer positions that will be removed from the glyph row because
2140 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2141 column is beyond frame width: don't subtract 1 "pixel" when
2142 computing width of the stretch.
2143 (reseat_at_next_visible_line_start): Undo the change made on
2144 2011-09-17 that saved paragraph information and restored it after
2145 the call to `reseat'. (Bug#9545)
2147 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2149 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2150 and turn window cursor on if cleared (Bug#9415).
2152 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2154 * search.c (boyer_moore): Take unibyte characters from pattern
2155 literally. (Bug#9458)
2157 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2159 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2161 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2163 Fix minor problem found by static checking.
2164 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2165 initialized, to pacify gcc -Wuninitialized.
2167 * fileio.c: Report proper errno when syscall falls.
2168 (Finsert_file_contents): Save and restore errno,
2169 so that report_file_error outputs the correct diagnostic.
2170 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2172 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2174 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2176 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2178 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2179 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2181 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2183 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2184 about the current paragraph and restore it after the call to reseat.
2186 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2187 (bidi_find_paragraph_start): Search back for paragraph beginning
2188 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2189 (bidi_move_to_visually_next): Only trigger paragraph-related
2190 computations when the last character is a newline or at EOB, not
2191 just any NEUTRAL_B. (Bug#9470)
2193 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2194 truncated lines if point is covered by a display string. (Bug#9524)
2196 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2198 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2199 (cons_to_x_long): New function.
2200 (lisp_data_to_selection_data): Use it. Correct the test for
2201 short-versus-long data; it was negated. Break out of vector
2202 loop, for efficiency, when a long datum is discovered.
2204 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2206 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2208 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2210 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2211 GCC PR/17406) by declaring this function with external scope.
2213 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2215 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2216 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2218 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2220 * editfns.c (Fformat): Correctly handle text properties on "%%".
2222 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2224 * xterm.c (x_draw_composite_glyph_string_foreground):
2225 * w32term.c (x_draw_composite_glyph_string_foreground):
2226 * term.c (encode_terminal_code):
2227 * composite.c (composition_update_it, get_composition_id):
2228 * xdisp.c (get_next_display_element)
2229 (fill_composite_glyph_string): Add comments about special meaning
2230 of TAB characters in a composition.
2232 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2234 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2235 This occurs when processing a multibyte format.
2236 Problem reported by Wolfgang Jenker.
2238 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2240 * xdisp.c (try_cursor_movement): Only check for exact match if
2241 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2243 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2245 Remove unused external symbols.
2246 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2247 * xdisp.c (calc_pixel_width_or_height): Now static.
2248 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2249 * indent.c (check_display_width):
2250 * w32term.c: Fix comment to match code.
2251 * xterm.c, xterm.h (x_catching_errors): Remove.
2253 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2255 * xselect.c: Use signed conversions more consistently (Bug#9498).
2256 (selection_data_to_lisp_data): Assume incoming selection data are
2257 signed integers, not unsigned. This is to be consistent with
2258 outgoing selection data, which was modified to use signed integers
2259 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2260 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2261 expects long, not unsigned long.
2263 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2265 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2266 computation of loop end. Reported by Johan Bockgård
2269 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2271 * frame.c (Fother_visible_frames_p): Function deleted.
2273 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2275 * indent.c (compute_motion): Process display vector front to back
2276 rather than the other way around. (Bug#2496)
2278 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2280 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2282 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2284 * minibuf.c (Fread_from_minibuffer): Doc fix.
2286 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2288 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2289 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2291 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2293 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2294 value for non-existent files.
2296 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2298 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2299 set its "size" to -1. This will set the modtime_size field of
2300 the corresponding buffer to -1, which is what
2301 verify-visited-file-modtime expects for files that do not exist.
2304 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2306 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2308 * lisp.h: ... from here. push_key_description is no longer
2309 defined in keyboard.c, so its declaration should not be in
2310 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2311 logically belongs with push_key_description.
2313 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2315 * buffer.h: Include <sys/types.h> instead of <time.h>.
2316 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2317 Problem reported by Herbert J. Skuhra.
2319 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2321 * xml.c (parse_region): Make the parsing work for
2322 non-comment-starting XML files again (bug#9144).
2324 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2326 * image.c (gif_load): Fix calculation of bottom and right corner.
2329 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2331 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2332 redisplay in small windows.
2334 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2336 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2338 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2340 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2341 Operate on live windows only.
2343 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2345 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2347 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2349 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2350 only under bidi iteration.
2352 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2354 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2356 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2358 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2359 Without this fix, the command to link temacs failed due to an
2360 undefined symbol __builtin_isnan. This is because
2361 /usr/include/iso/math_c99.h #defines isnan(x) to
2362 __builtin_isnan(x), but the bundled gcc, which identifies itself
2363 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2365 * floatfns.c (isnan): #undef, and then #define to a clone of
2367 (Fisnan): Always define, since it's always available now.
2368 (syms_of_floatfns): Always define isnan at the Lisp level.
2370 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2372 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2374 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2376 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2377 The previous code assumed that file offsets (off_t values) fit in
2378 EMACS_INT variables, which is not true on typical 32-bit hosts.
2379 The code messed up by falsely reporting buffer overflow in cases
2380 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2381 when "big" contains more than 2**29 bytes, even though this
2382 inserts just one byte and does not overflow the buffer.
2383 (Finsert_file_contents): Store file offsets as off_t
2384 values, not as EMACS_INT values. Check for overflow when
2385 converting between EMACS_INT and off_t. When checking for
2386 buffer overflow or for overlap, take the offsets into account.
2387 Don't use EMACS_INT for small values where int suffices.
2388 When checking for overlap, fix a typo: ZV was used where
2389 ZV_BYTE was intended.
2390 (Fwrite_region): Don't assume off_t fits into 'long'.
2391 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2393 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2395 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2397 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2399 sprintf-related integer and memory overflow issues (Bug#9412).
2401 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2402 (esprintf, exprintf, evxprintf): New functions.
2403 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2404 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2405 (modify_event_symbol): Do not assume that the length of
2406 name_alist_or_stem is safe to alloca and fits in int.
2407 (Fexecute_extended_command): Likewise for function name and binding.
2408 (Frecursion_depth): Wrap around reliably on integer overflow.
2409 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2410 since some callers pass EMACS_INT values.
2411 (Fsingle_key_description): Don't crash if symbol name contains more
2412 than MAX_ALLOCA bytes.
2413 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2414 (get_minibuffer): Arg is now EMACS_INT, not int.
2415 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2416 (esprintf, exprintf, evxprintf): New decls.
2417 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2419 * dbusbind.c (signature_cat): New function.
2420 (xd_signature, Fdbus_register_signal):
2421 Do not overrun buffer; instead, report string overflow.
2423 * dispnew.c (add_window_display_history): Don't overrun buffer.
2424 Truncate instead; this is OK since it's just a log.
2426 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2427 even if the time zone offset is outlandishly large.
2428 Don't mishandle offset == INT_MIN.
2430 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2431 when creating daemon; the previous buffer-overflow check was incorrect.
2433 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2434 which has the guts of the old verror function.
2436 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2437 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2439 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2440 (font_unparse_xlfd): Don't blindly alloca long strings.
2441 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2442 fits in int, when using sprintf. Use single snprintf to count
2443 length of string rather than counting it via multiple sprintfs;
2444 that's simpler and more reliable.
2445 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2446 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2447 sprintf, in case result does not fit in int.
2449 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2450 (fontset_from_font): Print it.
2452 * frame.c (tty_frame_count): Now printmax_t, not int.
2453 (make_terminal_frame, set_term_frame_name): Print it.
2454 (x_report_frame_params): In X, window IDs are unsigned long,
2455 not signed long, so print them as unsigned.
2456 (validate_x_resource_name): Check for implausibly long names,
2457 and don't assume name length fits in 'int'.
2458 (x_get_resource_string): Don't blindly alloca invocation name;
2459 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2462 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2463 (xg_check_special_colors, xg_set_geometry):
2464 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2466 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2467 Use esprintf, not sprintf, in case result does not fit in int.
2469 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2470 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2471 it as a large positive number.
2472 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2473 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2475 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2476 in case result does not fit in int.
2478 * print.c (float_to_string): Detect width overflow more reliably.
2479 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2480 buffer overrun. Don't assume list length fits in 'int'. Treat
2481 print length of 0 as 0, not as infinity; to be consistent with other
2482 uses of print length in this function. Don't overflow print length
2483 index. Don't assume hash table size fits in 'long', or that
2484 vectorlike size fits in 'unsigned long'.
2486 * process.c (make_process): Use printmax_t, not int, to format
2487 process-name gensyms.
2489 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2491 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2492 to avoid potential buffer overrun.
2494 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2495 if X resource line is longer than 512 bytes.
2497 * xfns.c (x_window): Make sprintf buffer a bit bigger
2498 to avoid potential buffer overrun.
2500 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2502 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2504 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2506 Integer overflow fixes for scrolling, etc.
2507 Without these, Emacs silently mishandles large integers sometimes.
2508 For example, "C-u 4294967297 M-x recenter" was treated as if
2509 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2511 * xdisp.c (try_window_id): Check Emacs fixnum range before
2512 converting to 'int'.
2514 * window.c (window_scroll_line_based, Frecenter):
2515 Check that an Emacs fixnum is in range before assigning it to 'int'.
2516 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2517 values converted from Emacs fixnums.
2518 (Frecenter): Don't wrap around a line count if it is out of 'int'
2519 range; instead, treat it as an extreme value.
2520 (Fset_window_configuration, compare_window_configurations):
2521 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2523 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2524 that can exceed INT_MAX. Check that EMACS_INT value is in range
2525 before assigning it to the (possibly-narrower) index.
2526 (match_limit): Don't assume that a fixnum can fit in 'int'.
2528 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2531 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2532 (Fvertical_motion): Don't wrap around LINES values that don't fit
2533 in 'int'. Instead, treat them as extreme values. This is good
2534 enough for windows, which can't have more than INT_MAX lines anyway.
2536 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2538 * Require libxml/parser.h to avoid compilation warning.
2540 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2542 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2543 since this reportedly can destroy thread storage.
2545 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2547 * syntax.c (find_defun_start): Update all cache variables if
2548 exiting early (Bug#9401).
2550 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2552 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2554 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2555 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2556 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2558 * term.c (tty_append_glyph): New function.
2559 (produce_stretch_glyph): Static function and its prototype deleted.
2561 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2564 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2566 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2567 when checking :margin (Bug#9390).
2568 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2569 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2570 so that the name doesn't mislead. All uses changed.
2572 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2574 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2577 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2579 * xdisp.c (move_it_to): Don't bail out early when reaching
2580 position beyond to_charpos, if we are scanning backwards.
2581 (move_it_vertically_backward): When DY == 0, make sure we get to
2582 the first character in the line after the newline.
2584 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2586 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2587 (ccl_driver): Do not generate an out-of-range pointer.
2588 (Fccl_execute_on_string): Remove unnecessary check for
2589 integer overflow, noted by Stefan Monnier in
2590 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2591 Remove a FIXME that didn't need fixing.
2592 Simplify the newly-introduced buffer reallocation code.
2594 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2596 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2598 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2600 Integer and memory overflow issues (Bug#9196).
2602 * doc.c (get_doc_string): Rework so that
2603 get_doc_string_buffer_size is the actual buffer size, rather than
2604 being 1 less than the actual buffer size; this makes xpalloc more
2607 * image.c (x_allocate_bitmap_record, cache_image):
2608 * xselect.c (Fx_register_dnd_atom):
2609 Simplify previous changes by using xpalloc.
2611 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2612 since either will do and ptrdiff_t is convenient with xpalloc.
2614 * charset.c (charset_table_size)
2615 (struct charset_sort_data.priority): Now ptrdiff_t.
2616 (charset_compare): Don't overflow if priorities differ greatly.
2617 (Fsort_charsets): Don't assume list length fits in int.
2618 Check for size-calculation overflow when allocating sort data.
2619 (syms_of_charset): Allocate an initial charset table that is
2620 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2622 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2624 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2625 The actual value is always <= INT_MAX, and leaving it unsigned made
2626 overflow checking harder.
2628 * dispextern.h (struct glyph_matrix.rows_allocated)
2629 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2630 with xpalloc. The values are still always <= INT_MAX.
2632 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2634 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2635 (SAFE_NALLOCA): New macro.
2637 * region-cache.c (struct boundary.pos, find_cache_boundary)
2638 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2639 (set_cache_region, invalidate_region_cache)
2640 (revalidate_region_cache, know_region_cache, region_cache_forward)
2641 (region_cache_backward, pp_cache):
2642 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2643 so that ptrdiff_t * can be passed to xpalloc.
2644 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2645 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2646 (pp_cache): Don't assume cache_len fits in int.
2647 * region-cache.h: Adjust extern decls to match.
2649 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2650 EMACS_INT, since either will do, for xpalloc.
2652 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2653 (xnmalloc, xnrealloc, xpalloc): New functions.
2655 * bidi.c (bidi_shelve_header_size): New constant.
2656 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2657 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2659 * bidi.c (bidi_cache_shrink):
2660 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2662 Don't update size of array until after memory allocation succeeds,
2663 because xmalloc/xrealloc may not return.
2664 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2665 now that we have proper integer overflow checking.
2666 (record_overlay_string, overlay_strings): Catch overflows when
2667 calculating size of overlay_str_buf.
2669 * callproc.c (Fcall_process): Check for size overflow when
2670 calculating size of args2.
2671 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2672 Normally we prefer signed values, but sticking with ptrdiff_t would
2673 require adding more-complicated checks.
2675 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2676 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2677 Redo buffer-overflow calculations to avoid integer overflow.
2678 Add a FIXME comment where memory seems to be over-allocated.
2680 * character.c (Fstring): Check for size-calculation overflow.
2682 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2683 unnecessary integer overflow. Check for size overflow.
2684 (encode_coding_object): Don't update size until xmalloc succeeds.
2686 * composite.c (get_composition_id): Check for overflow in glyph
2687 length calculations.
2689 Integer and memory overflow fixes for display code.
2690 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2691 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2692 (scrolling_window): Check for overflow in size calculations.
2693 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2694 Don't assume glyph table len fits in int.
2695 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2696 (row_table_size): Now ptrdiff_t, not int.
2697 (scrolling_window): Avoid overflow in size calculations.
2698 Don't update size until allocation succeeds.
2699 * fns.c (concat): Check for overflow in size calculations.
2700 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2701 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2702 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2704 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2705 (get_doc_string): Check for size calculation overflow.
2706 Don't update size until allocation succeeds.
2707 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2708 EMACS_INT, where ptrdiff_t will do.
2709 (Fsubstitute_command_keys): Check for string overflow.
2711 * editfns.c (set_time_zone_rule): Don't assume environment length
2713 (message_length): Now ptrdiff_t, not int.
2714 (Fmessage_box): Don't update size until allocation succeeds.
2715 Don't assume message length fits in int.
2716 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2718 * emacs.c (main): Do not reallocate argv, since there is a null at
2719 the end that can be overwritten, and this way there's no need to
2720 worry about size-calculation overflow.
2721 (sort_args): Check for size-calculation overflow.
2723 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2725 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2727 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2728 (x_set_scroll_bar_width, x_figure_window_size):
2729 Check for integer overflow.
2730 (x_set_alpha): Do not assume XINT fits in int.
2732 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2733 This is for the members text_lines, text_cols, total_lines, total_cols,
2734 where the system imposes an 'int' limit.
2736 * fringe.c (Fdefine_fringe_bitmap):
2737 Don't update size until alloc works.
2739 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2740 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2742 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2743 Check for size-calculation overflow.
2744 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2745 do, as we prefer signed integers.
2746 (id_to_widget.max_size, id_to_widget.used)
2747 (xg_store_widget_in_map, xg_remove_widget_from_map)
2748 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2749 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2750 Use and return ptrdiff_t, not int.
2751 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2752 * gtkutil.h: Change prototypes to match the above.
2754 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2755 are duplicate now that they've been promoted to lisp.h.
2756 (x_allocate_bitmap_record, x_alloc_image_color)
2757 (make_image_cache, cache_image, xpm_load):
2758 Don't update size until alloc is done.
2759 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2761 Check for size calculation overflow.
2762 (ct_colors_allocated_max): New constant.
2763 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2766 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2767 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2768 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2769 Use ptrdiff_t, not int, to count maps.
2770 (read_char_minibuf_menu_prompt): Check for overflow in size
2771 calculations. Don't update size until allocation succeeds.
2772 Redo calculations to avoid overflow.
2773 * keyboard.h: Change prototypes to match the above.
2775 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2777 (current_minor_maps): Check for size calculation overflow.
2778 * keymap.h: Change prototypes to match the above.
2780 * lread.c (read1, init_obarray): Don't update size until alloc done.
2782 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2783 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2785 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2786 Now ptrdiff_t, not int.
2787 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2788 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2790 * process.c (Fnetwork_interface_list): Check for overflow
2791 in size calculation.
2793 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2795 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2796 overflow. Don't bother calling xmalloc when xrealloc will do.
2798 * search.c (Freplace_match): Check for size calculation overflow.
2799 (Fset_match_data): Don't assume list lengths fit in 'int'.
2801 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2802 for command line length. Do not attempt to address one before the
2803 beginning of an array, as that's not portable.
2805 * term.c (max_frame_lines): Remove; unused.
2806 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2808 (encode_terminal_code, calculate_costs): Check for size
2809 calculation overflow.
2810 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2811 table lengths and related sizes. Don't update size until alloc
2812 done. Redo calculations to avoid overflow.
2813 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2815 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2816 subtracting pointers.
2817 (gobble_line): Check for overflow more carefully. Don't update size
2820 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2821 Don't update size until alloc done.
2822 Redo size calculations to avoid overflow.
2823 Check for size calculation overflow.
2824 (main) [DEBUG]: Fix typo in invoking tparam1.
2826 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2827 Use ptrdiff_t, not int, for sizes.
2828 (store_mode_line_noprop_char): Don't update size until alloc done.
2830 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2831 Use ptrdiff_t, not int, for sizes.
2832 (Finternal_make_lisp_face, cache_face):
2833 Check for size calculation overflow.
2834 (cache_face): Treat size calculation overflows as if they were
2835 memory exhaustion (the usual treatment), rather than aborting.
2837 * xfns.c (x_encode_text, x_set_name_internal)
2838 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2839 sizes, since they can exceed INT_MAX in size. Check for size
2840 calculation overflow.
2842 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2843 (xg_select): Check for size calculation overflow.
2844 Don't update size until alloc done.
2846 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2847 as sprintf is limited to int lengths.
2849 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2850 (X_LONG_MIN): New macros.
2851 Use them to make the following changes clearer.
2852 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2853 This change doesn't affect the value now, but it may help remind
2854 future maintainers not to raise the value too much later.
2855 (SELECTION_QUANTUM): Remove, replacing with ...
2856 (selection_quantum): ... new function, which avoids overflow.
2858 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2859 assumption that selection length fits in 'int'.
2860 (x_reply_selection_request, x_handle_selection_request)
2861 (x_get_window_property, receive_incremental_selection)
2862 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2863 (lisp_data_to_selection_data, clean_local_selection_data):
2864 Use ptrdiff_t, not int, to record length of selection.
2865 (x_reply_selection_request, x_get_window_property)
2866 (receive_incremental_selection, x_property_data_to_lisp):
2867 Redo calculations to avoid overflow.
2868 (x_reply_selection_request): When sending hint, ceiling it at
2869 X_LONG_MAX rather than relying on wraparound overflow to send
2871 (x_get_window_property, receive_incremental_selection)
2872 (lisp_data_to_selection_data, x_property_data_to_lisp):
2873 Check for size-calculation overflow.
2874 (x_get_window_property, receive_incremental_selection)
2875 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2876 Don't store size until memory allocation succeeds.
2877 (x_get_window_property): Plug memory leak on memory exhaustion.
2878 Don't double-block input; malloc is safe here. Don't assume 2**34
2879 - 4 fits in unsigned long. Add an xassert to check
2880 XGetWindowProperty overflow. Be more careful about overflow
2881 calculations, and distinguish size from memory overflow better.
2882 (receive_incremental_selection): When tracing, don't assume
2883 unsigned int is less than INT_MAX.
2884 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2885 harmful) conversions of unsigned short to int.
2886 (lisp_data_to_selection_data): Don't assume that integers
2887 in the range -65535 through -1 fit in an X unsigned short.
2888 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2889 result parameters unless successful. Rely on cons_to_unsigned
2890 to report problems with elements; the old code wasn't right anyway.
2891 (x_check_property_data): Check for int overflow; we cannot use
2892 a wider type due to X limits.
2893 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2895 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2897 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2898 (x_term_init): Check for size calculation overflow.
2899 (x_color_cells): Don't store size until memory allocation succeeds.
2900 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2901 Don't assume alloca size is less than MAX_ALLOCA.
2902 (x_term_init): Don't assume length fits in int (sprintf is limited
2905 Use ptrdiff_t for composition IDs.
2906 * character.c (lisp_string_width):
2907 * composite.c (composition_table_size, n_compositions)
2908 (get_composition_id, composition_gstring_from_id):
2909 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2910 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2911 * window.c (Frecenter):
2912 Use ptrdiff_t, not int, for composition IDs.
2913 * composite.c (get_composition_id): Check for integer overflow.
2914 * composite.h: Adjust prototypes to match the above changes.
2916 Use ptrdiff_t for hash table indexes.
2917 * category.c (hash_get_category_set):
2918 * ccl.c (ccl_driver):
2919 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2920 * coding.c (coding_system_charset_list, detect_coding_system):
2921 * coding.h (struct coding_system.id):
2922 * composite.c (get_composition_id, gstring_lookup_cache):
2923 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2924 * image.c (xpm_get_color_table_h):
2925 * lisp.h (hash_lookup, hash_put):
2926 * minibuf.c (Ftest_completion):
2927 Use ptrdiff_t for hash table indexes, not int (which is too
2928 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2929 32-bit --with-wide-int hosts).
2931 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2932 Add a FIXME comment about memory leaks.
2933 (syms_of_charset): Don't assume xmalloc returns.
2935 Don't assume that stated character widths fit in int.
2936 * character.c (Fchar_width, c_string_width, lisp_string_width):
2937 * character.h (CHAR_WIDTH):
2938 * indent.c (MULTIBYTE_BYTES_WIDTH):
2939 Use sanitize_char_width to avoid undefined and/or bad behavior
2940 with outlandish widths.
2941 * character.h (sanitize_tab_width): Rename from sanitize_width,
2942 now that we have two such functions. All uses changed.
2943 (sanitize_char_width): New inline function.
2945 Don't assume that tab-width fits in int.
2946 * character.h (sanitize_width): New inline function.
2947 (SANE_TAB_WIDTH): New macro.
2948 (ASCII_CHAR_WIDTH): Use it.
2949 * indent.c (sane_tab_width): Remove. All uses replaced by
2950 SANE_TAB_WIDTH (current_buffer).
2951 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2953 * fileio.c: Integer overflow issues with file modes.
2954 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2956 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2957 Remove unreachable code.
2958 (read_hex, load_charset_map_from_file): Check for integer overflow.
2960 * xterm.c: Don't go over XClientMessageEvent limit.
2961 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2962 (x_send_scroll_bar_event): Likewise. Check that the size does not
2963 exceed limits imposed by XClientMessageEvent, as well as the usual
2964 ptrdiff_t and size_t limits.
2966 * keyboard.c: Overflow, signedness and related fixes.
2967 (make_lispy_movement): Use same integer type in forward decl
2968 that is used in the definition.
2969 (read_key_sequence, keyremap_step):
2970 Change bufsize argument back to int, undoing my 2011-03-30 change.
2971 We prefer signed types, and int is wide enough here.
2972 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2973 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2974 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2975 length, not size_t. Use ptrdiff_t for index, not int.
2976 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2977 possibility of integer overflow.
2979 Overflow, signedness and related fixes for images.
2981 * dispextern.h (struct it.stack[0].u.image.image_id)
2982 (struct_it.image_id, struct image.id, struct image_cache.size)
2983 (struct image_cache.used, struct image_cache.ref_count):
2984 * gtkutil.c (update_frame_tool_bar):
2985 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2986 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2987 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2988 * nsmenu.m (update_frame_tool_bar):
2989 * xdisp.c (calc_pixel_width_or_height):
2990 * xfns.c (image_cache_refcount):
2991 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2992 on typical 64-bit hosts.
2994 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2995 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2996 Omit unnecessary casts to int.
2997 (parse_image_spec): Check that integers fall into 'int' range
2998 when the callers expect that.
2999 (image_ascent): Redo ascent calculation to avoid int overflow.
3000 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3001 (lookup_image): Remove unnecessary tests.
3002 (xbm_image_p): Locals are now of int, not EMACS_INT,
3003 since parse_image_check makes sure they fit into int.
3004 (png_load, gif_load, svg_load_image):
3005 Prefer int to unsigned where either will do.
3006 (tiff_handler): New function, combining the cores of the
3007 old tiff_error_handler and tiff_warning_handler.
3008 This function is rewritten to use vsnprintf and thereby avoid
3009 stack buffer overflows. It uses only the features of vsnprintf
3010 that are common to both POSIX and native Microsoft.
3011 (tiff_error_handler, tiff_warning_handler): Use it.
3012 (tiff_load, gif_load, imagemagick_load_image):
3013 Don't assume :index value fits in 'int'.
3014 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3015 (imagemagick_load_image): Check that crop parameters fit into
3016 the integer types that MagickCropImage accepts. Don't assume
3017 Vimagemagick_render_type has a nonnegative value. Don't assume
3018 size_t fits in 'long'.
3019 (gs_load): Use printmax_t to print the widest integers possible.
3020 Check for integer overflow when computing image height and width.
3022 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3024 * xdisp.c (redisplay_window): Don't force window start if point
3025 will be invisible in the resulting window. (Bug#9324)
3027 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3029 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3030 the display spec is of the form `(space ...)'.
3031 (handle_display_spec): Return the value returned by
3032 handle_single_display_spec, not just 1 or zero.
3033 (handle_single_display_spec): If the display spec is of the form
3034 `(space ...)', and specifies display in the text area, return 2
3036 (try_cursor_movement): Check for the need to scroll more
3037 accurately, and prefer exact match for point under bidi.
3038 Don't advance `row' beyond the last row of the window.
3040 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3041 into disp_prop; all users changed.
3043 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3044 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3045 for the text covered by the display property.
3047 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3049 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3050 Change return value to nil.
3051 (Frecord_buffer): Delete unused function.
3053 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3055 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3056 buffers, return left-to-right.
3057 (set_cursor_from_row): Consider candidate row a win if its glyph
3058 represents a newline and point is on that newline. Fixes cursor
3059 positioning on the newline at EOL of R2L text within L2R
3060 paragraph, and vice versa.
3061 (try_cursor_movement): Check continued rows, in addition to
3062 continuation rows. Fixes unwarranted scroll when point enters a
3063 continued line of R2L text within an L2R paragraph, or vice versa.
3064 (cursor_row_p): Consider the case of point being equal to
3065 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3066 from the end of a short line to the beginning of a continued line
3067 of R2L text within L2R paragraph.
3068 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3069 composed characters.
3071 * bidi.c (bidi_check_type): Use xassert.
3072 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3075 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3077 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3080 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3082 * nsfont.m (ns_otf_to_script): Fix typo.
3084 2011-08-22 Kenichi Handa <handa@m17n.org>
3086 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3087 extra slot even if the purpose is char-code-property-table.
3089 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3091 * xdisp.c (redisplay_window): When computing centering_position,
3092 account for the height of the header line. (Bug#8874)
3094 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3095 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3096 candidate is selected by the mouse, and that candidate has a
3097 composed character under the mouse.
3099 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3100 coordinates reported by pos-visible-in-window-p for a composed
3101 character in column zero.
3103 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3105 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3107 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3109 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3110 consider it a hit if to_charpos is anywhere in the range of the
3111 composed buffer positions.
3113 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3115 * image.c (gif_load): Don't assume that each subimage has the same
3116 dimensions as the base image. Handle disposal method that is
3117 "undefined" by the gif spec (Bug#9335).
3119 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3121 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3122 (Fcondition_case): Document `debug' symbol in error handler.
3124 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3126 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3127 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3128 from an Org mode buffer to a Speedbar frame.
3130 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3131 a composition, take its buffer position from IT->cmp_it.charpos.
3132 Fixes cursor positioning at the beginning of a line that begins
3133 with a composed character.
3135 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3137 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3138 character bidirectional type, use STRONG_L instead. Fixes crashes
3139 in a buffer produced by `describe-categories'.
3141 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3142 members before the level stack, so they would be saved and
3143 restored when copying iterator state. Fixes incorrect reordering
3144 around TABs covered by display properties.
3146 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3148 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3150 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3152 * eval.c (internal_condition_case, internal_condition_case_1)
3153 (internal_condition_case_2, internal_condition_case_n):
3154 Remove unnecessary aborts (Bug#9081).
3156 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3158 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3159 has no `load' handler, try opening the file locally. (Bug#9311)
3161 2011-08-16 Ken Brown <kbrown@cornell.edu>
3163 * gmalloc.c: Expand comment.
3165 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3167 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3168 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3170 2011-08-16 Ken Brown <kbrown@cornell.edu>
3172 Fix memory allocation problems in Cygwin build (Bug#9273).
3174 * unexcw.c ( __malloc_initialized): Declare external variable.
3175 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3177 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3179 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3181 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3183 [CYGWIN] (special_realloc): New function.
3184 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3185 requests to realloc storage in the static heap.
3187 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3189 * bidi.c (bidi_initialize): Remove unused local.
3191 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3194 * biditype.h: Remove file.
3195 * makefile.w32-in ($(BLD)/bidi.$(O)):
3196 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3198 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3200 * chartab.c: Improve commentary for the uniprop_table API.
3202 * bidi.c (bidi_paragraph_init): Support zero value of
3203 bidi_ignore_explicit_marks_for_paragraph_level.
3204 (bidi_initialize): Use uniprop_table instead of including
3205 biditype.h and bidimirror.h.
3207 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3208 coordinates of the iterator when restoring from ppos_it.
3211 2011-08-14 Kenichi Handa <handa@m17n.org>
3213 * process.c (create_process): Call setup_process_coding_systems
3214 after the pid of the process is set to -1 (Bug#8162).
3216 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3218 * xdisp.c (move_it_in_display_line_to): Don't invoke
3219 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3220 ppos_it. Fixes vertical cursor motion when line beginning is
3221 covered by an image. (Bug#9296)
3223 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3225 * nsterm.h (ns_run_ascript): Declare.
3226 (NSAPP_DATA2_RUNASSCRIPT): Define.
3228 * nsfns.m (as_script, as_result, as_status): New static variables.
3229 (ns_run_ascript): New function.
3230 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3231 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3232 the event loop. Get status from as_status (Bug#7276).
3234 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3235 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3236 the event loop (Bug#7276).
3238 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3240 * gnutls.c (QCgnutls_bootprop_priority)
3241 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3242 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3243 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3244 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3245 (QCgnutls_bootprop_verify_hostname_error)
3246 (QCgnutls_bootprop_callbacks_verify): Rename from
3247 Qgnutls_bootprop_..., all uses changed.
3249 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3252 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3254 * xfaces.c (Qframe_set_background_mode): Now static.
3255 * dispextern.h (Qframe_set_background_mode): Remove decl.
3257 * process.c (Fnetwork_interface_info): Declare local only if needed.
3259 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3261 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3262 (Fnetwork_interface_list): Allocate in increments of bytes instead
3263 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3264 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3266 (struct ifflag_def): notrailers is smart on OSX.
3267 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3268 Get hardware address with getifaddrs if available.
3270 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3272 * xdisp.c (iterate_out_of_display_property): xassert that
3273 IT->position is set to within IT->object's boundaries. Break from
3274 the loop as soon as EOB is reached; avoids infloops in redisplay
3275 when IT->position is set up wrongly due to some bug.
3276 Set IT->current to match the bidi iterator unconditionally.
3277 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3278 entry. Force push_it to save on the stack the current
3279 buffer/string position, to be restored by pop_it. Fix flags in
3280 the iterator structure wrt the object coming from a display
3281 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3282 properties. (Bug#9284)
3284 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3286 * fontset.c (fontset_get_font_group): Add proper type checks.
3289 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3291 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3292 and LC_VERSION_MIN_MACOSX.
3293 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3294 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3296 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3298 * xdisp.c (forward_to_next_line_start): Allow to use the
3299 no-display-properties-and-no-overlays under bidi display.
3300 Set disp_pos in the bidi iterator to avoid searches for display
3301 properties and overlays.
3303 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3305 * editfns.c (Fset_time_zone_rule): Document relationship with the
3308 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3309 the font entity extracted from the cache (Bug#8109).
3311 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3313 * composite.c (autocmp_chars): Don't reset point. That is done by
3314 restore_point_unwind (Bug#5984).
3316 2011-08-07 Juri Linkov <juri@jurta.org>
3318 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3319 to show the arg `TIME' instead of `TIMEVAL'.
3321 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3323 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3324 display property strides EOL and includes a newline, as in
3325 longlines-mode. (Bug#9254)
3326 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3327 word-wrap under bidirectional display. (Bug#9224)
3329 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3330 is non-zero, even if the data buffer is NULL. Fixes a crash in
3331 vertical-motion with longlines-mode. (Bug#9254)
3333 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3335 * bidi.c <bidi_cache_total_alloc>: Now static.
3336 (bidi_initialize): Initialize bidi_cache_total_alloc.
3338 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3341 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3342 amount allocated this far in `bidi_cache_total_alloc'.
3343 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3344 non-zero, only free the data buffer without restoring the cache
3345 contents. All callers changed.
3347 * dispextern.h (bidi_unshelve_cache): Update prototype.
3349 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3350 (move_it_in_display_line, move_it_to)
3351 (move_it_vertically_backward, move_it_by_lines): Replace the call
3352 to xfree to an equivalent call to bidi_unshelve_cache.
3353 (move_it_in_display_line_to): Fix logic of returning
3354 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3356 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3358 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3359 came from a string character with a `cursor' property. (Bug#9229)
3361 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3363 * Makefile.in (LIB_PTHREAD): New variable.
3364 (LIBES): Add LIB_PTHREAD (Bug#9216).
3366 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3367 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3369 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3371 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3373 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3375 * xterm.c (x_find_topmost_parent): New function.
3376 (x_set_frame_alpha): Find topmost parent window with
3377 x_find_topmost_parent and set the property there also (bug#9181).
3378 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3380 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3382 * callproc.c (Fcall_process): Avoid vfork clobbering
3383 the local vars buffer, coding_systems, current_dir.
3385 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3387 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3389 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3391 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3392 so that it is not optimized away.
3394 * xdisp.c (compute_display_string_pos): Remove unused local.
3396 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3398 Fix slow cursor motion and scrolling in large buffers with
3399 selective display, like Org Mode buffers. (Bug#9218)
3401 * dispextern.h (struct bidi_it): New member disp_prop_p.
3403 * xdisp.c: Remove one-slot cache of display string positions.
3404 (compute_display_string_pos): Accept an additional argument
3405 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3406 for a display string or property. If found, set DISP_PROP_P
3409 * bidi.c (bidi_fetch_char): Accept an additional argument
3410 DISP_PROP_P, and pass it to compute_display_string_pos.
3411 Only handle text covered by a display string if DISP_PROP_P is returned
3412 non-zero. All callers of bidi_fetch_char changed.
3414 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3416 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3418 2010-12-03 Don March <don@ohspite.net>
3420 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3421 last character M-[char] is translated to ESC [char] (bug#7541).
3423 2011-08-02 Kenichi Handa <handa@m17n.org>
3425 * lisp.h (uniprop_table): Extern it.
3427 * chartab.c (uniprop_table): Make it non-static.
3429 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3431 * xdisp.c (forward_to_next_line_start): Accept additional argument
3432 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3434 (reseat_at_next_visible_line_start): Use the bidi iterator state
3435 returned by forward_to_next_line_start to restore the state of
3436 it->bidi_it after backing up to previous newline. (Bug#9212)
3438 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3440 * regex.c (re_comp): Protoize.
3441 (re_exec): Fix return type.
3442 (regexec): Fix type of `ret'. (Bug#9203)
3444 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3446 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3447 This is needed if max-image-size is a floating-point number.
3449 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3451 * print.c (print_object): Print empty symbol as ##.
3453 * lread.c (read1): Read ## as empty symbol.
3455 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3457 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3458 setting frame foreground color (Bug#9175).
3459 (x_set_background_color): Likewise.
3461 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3462 contents (Bug#9176).
3463 (EmacsTooltip -init): Remove bezels and add shadows to
3466 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3467 or scroll bar (Bug#8470).
3469 * nsfont.m (nsfont_open): Remove assignment to voffset and
3470 unnecessary vars hshink, expand, hd, full_height, min_height.
3471 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3473 * nsterm.h (nsfont_info): Remove voffset field.
3475 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3477 Implement strike-through and overline on NextStep (Bug#8863).
3479 * nsfont.m (nsfont_open): Use underline position provided by font,
3480 instead of hard-coded value of 2.
3481 (nsfont_draw): Call ns_draw_text_decoration instead.
3483 * nsterm.h: Add declaration for ns_draw_text_decoration.
3485 * nsterm.m (ns_draw_text_decoration): New function for drawing
3486 underline, overline, and strike-through.
3487 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3488 ns_draw_text_decoration. Change treatment of cursor drawing to
3489 accommodate underlining, etc.
3491 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3493 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3496 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3498 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3499 Without this fix, if a signal arrives just after memory fills up,
3500 'malloc' might be invoked reentrantly.
3502 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3503 In other words, assume that every image size is allowed, on non-X
3504 hosts. This assumption is probably wrong, but it lets Emacs compile.
3506 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3508 * regex.c (re_iswctype): Convert return values to boolean.
3510 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3512 * xdisp.c (compute_display_string_pos): Don't use cached display
3513 string position if the buffer had its restriction changed.
3516 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3518 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3520 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3522 Integer signedness and overflow and related fixes. (Bug#9079)
3524 * bidi.c: Integer size and overflow fixes.
3525 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3526 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3527 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3528 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3529 (bidi_find_other_level_edge):
3530 Use ptrdiff_t instead of EMACS_INT where either will do.
3531 This works better on 32-bit hosts configured --with-wide-int.
3532 (bidi_cache_ensure_space): Check for size-calculation overflow.
3533 Use % rather than repeated addition, for better worst-case speed.
3534 Don't set bidi_cache_size until after xrealloc returns, because it
3536 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3537 (bidi_cache_ensure_space): Also check that the bidi cache size
3538 does not exceed that of the largest Lisp string or buffer. See Eli
3539 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3541 * alloc.c (__malloc_size_t): Remove.
3542 All uses replaced by size_t. See Andreas Schwab's note
3543 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3545 * image.c: Improve checking for integer overflow.
3546 (check_image_size): Assume that f is nonnull, since
3547 it is always nonnull in practice. This is one less thing to
3548 worry about when checking for integer overflow later.
3549 (x_check_image_size): New function, which checks for integer
3550 overflow issues inside X.
3551 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3552 This removes the need for a memory_full check.
3553 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3554 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3555 (xbm_read_bitmap_data): Change locals back to 'int', since
3556 their values must fit in 'int'.
3557 (xpm_load_image, png_load, tiff_load):
3558 Invoke x_create_x_image_and_pixmap earlier,
3559 to avoid much needless work if the image is too large.
3560 (tiff_load): Treat overly large images as if
3561 x_create_x_image_and_pixmap failed, not as malloc failures.
3562 (gs_load): Use x_check_image_size.
3564 * gtkutil.c: Omit integer casts.
3565 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3566 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3568 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3570 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3571 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3572 would wrongly return t on a 64-bit host.
3574 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3575 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3576 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3577 and therefore cause GCC to emit a bogus diagnostic in some cases.
3579 * image.c: Integer signedness and overflow and related fixes.
3580 This is not an exhaustive set of fixes, but it's time to
3581 record what I've got.
3582 (lookup_pixel_color, check_image_size): Remove redundant decls.
3583 (check_image_size): Don't assume that arbitrary EMACS_INT values
3584 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3585 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3586 (tiff_load, imagemagick_load_image):
3587 Check for overflow in size calculations.
3588 (x_create_x_image_and_pixmap): Remove unnecessary test for
3589 xmalloc returning NULL; that can't happen.
3590 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3591 (xpm_color_bucket): Use better integer hashing function.
3592 (xpm_cache_color): Don't possibly over-allocate memory.
3593 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3594 (gif_memory_source):
3595 Use ptrdiff_t, not int or size_t, to record sizes.
3596 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3597 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3598 either works, as we prefer signed integers.
3599 (tiff_read_from_memory, tiff_write_from_memory):
3600 Return tsize_t, not size_t, since that's what the TIFF API wants.
3601 (tiff_read_from_memory): Don't fail simply because the read would
3602 go past EOF; instead, return a short read.
3603 (tiff_load): Omit no-longer-needed casts.
3604 (Fimagemagick_types): Don't assume size fits into 'int'.
3606 Improve hashing quality when configured --with-wide-int.
3607 * fns.c (hash_string): New function, taken from sxhash_string.
3608 Do not discard information about ASCII character case; this
3609 discarding is no longer needed.
3610 (sxhash-string): Use it. Change sig to match it. Caller changed.
3611 * lisp.h: Declare it.
3612 * lread.c (hash_string): Remove, since we now use fns.c's version.
3613 The fns.c version returns a wider integer if --with-wide-int is
3614 specified, so this should help the quality of the hashing a bit.
3616 * emacs.c: Integer overflow minor fix.
3617 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3618 Define only if GNU_LINUX.
3619 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3621 * dispnew.c: Integer signedness and overflow fixes.
3622 Remove unnecessary forward decls, that were a maintenance hassle.
3623 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3625 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3626 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3627 (prepare_desired_row, line_draw_cost):
3628 Use int, not unsigned, where either works.
3629 (save_current_matrix, restore_current_matrix):
3630 Use ptrdiff_t, not size_t, where either works.
3631 (init_display): Check for overflow more accurately, and without
3632 relying on undefined behavior.
3634 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3635 Remove, replacing with the new symbols in lisp.h. All uses changed.
3636 * fileio.c (make_temp_name):
3637 * filelock.c (lock_file_1, lock_file):
3638 * xdisp.c (message_dolog):
3639 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3640 Use pMd etc. instead.
3641 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3642 replacing the pWIDE etc. symbols removed from editfns.c.
3644 * keyboard.h (num_input_events): Now uintmax_t.
3645 This is (very slightly) less likely to mess up due to wraparound.
3648 * buffer.c: Integer signedness fixes.
3649 (alloc_buffer_text, enlarge_buffer_text):
3650 Use ptrdiff_t rather than size_t when either will do, as we prefer
3653 * alloc.c: Integer signedness and overflow fixes.
3654 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3655 (__malloc_size_t): Default to size_t, not to int.
3656 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3657 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3658 Prefer ptrdiff_t to size_t when either would do, as we prefer
3660 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3661 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3662 Now const. Initialize with values that are in range even if char
3664 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3665 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3666 These functions do the right thing with sizes > 2**32.
3667 (check_depth): Now ptrdiff_t, not int.
3668 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3669 Adjust to new way of storing sizes. Check for size overflow bugs
3671 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3672 slightly wrong anyway, as it missed one instance of
3673 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3674 (refill_memory_reserve): Omit needless cast to size_t.
3675 (mark_object_loop_halt): Mark as externally visible.
3677 * xselect.c: Integer signedness and overflow fixes.
3678 (Fx_register_dnd_atom, x_handle_dnd_message):
3679 Use ptrdiff_t, not size_t, since we prefer signed.
3680 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3681 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3682 x_dnd_atoms_size and x_dnd_atoms_length.
3684 * doprnt.c: Prefer signed to unsigned when either works.
3686 * doprnt.c (doprnt):
3688 * xdisp.c (vmessage):
3689 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3690 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3691 prefer signed arithmetic to avoid comparison confusion.
3692 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3693 but is a bit tricky.
3695 Assume freestanding C89 headers, string.h, stdlib.h.
3696 * data.c, doprnt.c, floatfns.c, print.c:
3697 Include float.h unconditionally.
3698 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3699 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3700 * regex.c: Likewise for stddef.h, string.h.
3701 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3702 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3703 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3704 (STDC_HEADERS): Remove obsolete defines.
3705 * sysdep.c: Include limits.h unconditionally.
3707 Assume support for memcmp, memcpy, memmove, memset.
3708 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3709 * regex.c (memcmp, memcpy):
3710 Remove; we assume C89 now.
3712 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3713 (__malloc_safe_bcopy): Remove; no longer needed.
3715 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3716 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3717 well either way, and we prefer signed to unsigned.
3719 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3721 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3722 closes the connection while we're reading (bug#9182).
3724 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3726 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3727 are specified (Bug#9168).
3729 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3731 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3732 Found by GCC static checking and --with-wide-int on a 32-bit host.
3734 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3736 * xdisp.c (compute_display_string_pos): Fix logic of caching
3737 previous display string position. Initialize cached_prev_pos to
3738 -1. Fixes slow-down at the beginning of a buffer.
3740 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3742 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3743 for attrs[LFACE_FONTSET_INDEX].
3745 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3747 * xml.c (parse_region): Remove unused local
3748 that was recently introduced.
3750 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3752 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3753 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3755 * xdisp.c (move_it_in_display_line_to): Record the best matching
3756 position for TO_CHARPOS while scanning the line, and restore it on
3757 exit if none of the characters scanned was an exact match.
3758 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3759 when exact match is impossible due to invisible text, and the
3760 lines are truncated.
3762 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3764 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3767 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3769 Fix a significant slow-down of cursor motion with C-n, C-p,
3770 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3771 auto-repeat under bidi redisplay in fontified buffers.
3772 * xdisp.c (compute_stop_pos_backwards): New function.
3773 (next_element_from_buffer): Call compute_stop_pos_backwards to
3774 find a suitable prev_stop when we find ourselves before
3776 (reseat): Don't look for prev_stop, as that could mean a very long
3778 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3779 <cached_disp_overlay_modiff>: Cache for last found display string
3781 (compute_display_string_pos): Return the cached position if asked
3782 about the same buffer in the same area of character positions, and
3783 the buffer wasn't changed since the time the display string
3784 position was cached.
3786 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3788 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3789 is an integer, which is important for empty lines. (Bug#9149)
3791 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3793 * frame.c (Fmodify_frame_parameters): In tty case, update the
3794 default face if necessary (Bug#4238).
3796 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3798 * editfns.c (Fstring_to_char): No need to explain what a character
3799 is in the docstring (Bug#6576).
3801 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3803 * xml.c (parse_region): Make sure we always return a tree.
3805 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3807 * xml.c (parse_region): If a document contains only comments,
3810 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3812 * xml.c (make_dom): Return comments, too.
3814 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3817 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3818 and the surrounding thread.
3819 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3820 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3821 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3823 * s/openbsd.h (BROKEN_SIGIO): Define.
3824 * unexelf.c (unexec) [__OpenBSD__]:
3825 Don't update the .mdebug section of the Alpha COFF symbol table.
3827 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3829 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3832 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3834 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3835 This fixes some race conditions on the permissions of any newly
3838 * alloc.c (valid_pointer_p): Use pipe, not open.
3839 This fixes some permissions issues when debugging.
3841 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3842 If fchown fails to set both uid and gid, try to set just gid,
3843 as that is sometimes allowed. Adjust the file's mode to eliminate
3844 setuid or setgid bits that are inappropriate if fchown fails.
3846 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3848 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3849 to compare Lisp_Objects.
3850 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3851 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3852 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3854 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3856 * lread.c (read_integer): Unread even EOF character.
3857 (read1): Likewise. Properly record start position of symbol.
3859 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3860 symbol character follows.
3862 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3864 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3865 This works around a problem with the previous change to Fcopy_file.
3866 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3867 and without this change, GCC might complain about discarding
3868 fchown's return value.
3870 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3872 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3874 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3876 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3878 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3880 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3881 it's used from the C level.
3883 * process.c: Use the same condition for POLL_FOR_INPUT in both
3884 keyboard.c and process.c (bug#1858).
3886 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3888 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3889 (Fgnutls_boot): Use it.
3891 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3893 * doc.c (Fsubstitute_command_keys): Revert last change.
3895 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3897 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3898 quotes the next character, and doesn't affect other longer
3899 sequences (bug#8935).
3901 * lread.c (syms_of_lread): Clarify that is isn't only
3902 `eval-buffer' and `eval-defun' that's affected by
3903 `lexical-binding' (bug#8460).
3905 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3907 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3908 bidi redisplay when a line includes both an image and is truncated.
3910 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3912 Fix minor problems found by static checking.
3913 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3914 (elsz): Now a signed constant, not a size_t var. We prefer signed
3915 types to unsigned, to avoid integer comparison confusion. Without
3916 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3917 "cannot optimize loop, the loop counter may overflow", a symptom
3919 * indent.c (Fvertical_motion): Mark locals as initialized.
3920 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3922 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3924 * search.c (Fre_search_backward): Mention `case-fold-search' in
3925 all the re_search_* functions (bug#8138).
3927 * keyboard.c (Fopen_dribble_file): Document when the file is
3930 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3932 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3935 Support bidi reordering of display and overlay strings.
3936 * xdisp.c (compute_display_string_pos)
3937 (compute_display_string_end): Accept additional argument STRING.
3938 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3939 (reseat_to_string): Initialize bidi_it->string.s and
3940 bidi_it->string.schars.
3941 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3942 NULL (avoids a crash in bidi_paragraph_init).
3943 Initialize itb.string.lstring.
3944 (init_iterator): Call bidi_init_it only of a valid
3945 buffer position was specified. Initialize paragraph_embedding to
3947 (reseat_to_string): Initialize the bidi iterator.
3948 (display_string): If we need to ignore text properties of
3949 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3950 original value of -1 will not work with bidi.)
3951 (compute_display_string_pos): First arg is now struct
3952 `text_pos *'; all callers changed. Support display properties on
3954 (compute_display_string_end): Support display properties on Lisp
3956 (init_iterator, reseat_1, reseat_to_string): Initialize the
3957 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3958 when iterating on a string not from display properties).
3959 (compute_display_string_pos, compute_display_string_end):
3960 Fix calculation of the object to scan. Fixes an error when using
3962 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3963 base_level_stop; instead, set base_level_stop to BEGV.
3964 Fixes crashes in vertical-motion.
3965 (next_element_from_buffer): Improve commentary for when
3966 the iterator is before prev_stop.
3967 (init_iterator): Initialize bidi_p from the default value of
3968 bidi-display-reordering, not from buffer-local value. Use the
3969 buffer-local value only if initializing for buffer iteration.
3970 (handle_invisible_prop): Support invisible properties on strings
3971 that are being bidi-reordered.
3972 (set_iterator_to_next): Support bidi reordering of C strings and
3974 (next_element_from_string): Support bidi reordering of Lisp
3976 (handle_stop_backwards): Support Lisp strings as well.
3977 (display_string): Support display of R2L glyph rows.
3978 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3979 (init_iterator): Don't initialize it->bidi_p for strings
3981 (reseat_to_string): Initialize it->bidi_p for strings here.
3982 (next_element_from_string, next_element_from_c_string)
3983 (next_element_from_buffer): Add xassert's for correspondence
3984 between IT's object being iterated and it->bidi_it.string
3986 (face_before_or_after_it_pos): Support bidi iteration.
3987 (next_element_from_c_string): Handle the case of the first string
3988 character that is not the first one in the visual order.
3989 (get_visually_first_element): New function, refactored from common
3990 parts of next_element_from_buffer, next_element_from_string, and
3991 next_element_from_c_string.
3992 (tool_bar_lines_needed, redisplay_tool_bar)
3993 (display_menu_bar): Force left-to-right direction. Add a FIXME
3994 comment for making that be controlled by a user option.
3995 (push_it, pop_it): Save and restore the state of the
3996 bidi iterator. Save and restore the bidi_p flag.
3997 (pop_it): Iterate out of display property for string iteration as
3999 (iterate_out_of_display_property): Support iteration over strings.
4000 (handle_single_display_spec): Set up it->bidi_it for iteration
4001 over a display string, and call bidi_init_it.
4002 (handle_single_display_spec, next_overlay_string)
4003 (get_overlay_strings_1, push_display_prop): Set up the bidi
4004 iterator for displaying display or overlay strings.
4005 (forward_to_next_line_start): Don't use the shortcut if
4007 (back_to_previous_visible_line_start): If handle_display_prop
4008 pushed the iterator stack, restore the internal state of the bidi
4009 iterator by calling bidi_pop_it same number of times.
4010 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4011 and we are bidi-iterating, don't decrement the iterator position;
4012 instead, set the first_elt flag in the bidi iterator, to produce
4014 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4015 (push_display_prop): xassert that we are iterating a buffer.
4016 (push_it, pop_it): Save and restore paragraph_embedding member.
4017 (handle_single_display_spec, next_overlay_string)
4018 (get_overlay_strings_1, reseat_1, reseat_to_string)
4019 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4020 correctly. Don't assume unibyte strings are not bidi-reordered.
4021 (compute_display_string_pos)
4022 (compute_display_string_end): Fix handling the case of C string.
4023 (push_it, pop_it): Save and restore from_disp_prop_p.
4024 (handle_single_display_spec, push_display_prop): Set the
4025 from_disp_prop_p flag.
4026 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4027 (pop_it): Call iterate_out_of_display_property only if we are
4028 popping after iteration over a string that came from a display
4029 property. Fix a typo in popping stretch info. Add an assertion
4030 for verifying that the iterator position is in sync with the bidi
4032 (handle_single_display_spec, get_overlay_strings_1)
4033 (push_display_prop): Fix initialization of paragraph direction for
4034 string when that of the parent object is not yet determined.
4035 (reseat_1): Call bidi_init_it to resync the bidi
4036 iterator with IT's position. (Bug#7616)
4037 (find_row_edges): If ROW->start.pos gives position
4038 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4039 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4040 Reset the from_disp_prop_p flag.
4041 (SAVE_IT, RESTORE_IT): New macros.
4042 (pos_visible_p, face_before_or_after_it_pos)
4043 (back_to_previous_visible_line_start)
4044 (move_it_in_display_line_to, move_it_in_display_line)
4045 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4046 (try_scrolling, redisplay_window, display_line): Use them when
4047 saving a temporary copy of the iterator and restoring it back.
4048 (back_to_previous_visible_line_start, reseat_1)
4049 (init_iterator): Empty the bidi cache "stack".
4050 (move_it_in_display_line_to): If iterator ended up at
4051 EOL, but we never saw any buffer positions smaller than
4052 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4053 motion in bidi-reordered lines.
4054 (move_it_in_display_line_to): Record prev_method and prev_pos
4055 immediately before the call to set_iterator_to_next. Fixes cursor
4056 motion in bidi-reordered lines with stretch glyphs and strings
4057 displayed in margins. (Bug#8133) (Bug#8867)
4058 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4060 (pos_visible_p): Support positions in bidi-reordered lines.
4061 Save and restore bidi cache.
4063 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4064 (bidi_paragraph_info): Delete unused struct.
4065 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4066 (bidi_cache_start): New variable.
4067 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4069 (bidi_cache_fetch_state, bidi_cache_search)
4070 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4071 (bidi_cache_find, bidi_peek_at_next_level)
4072 (bidi_level_of_next_char, bidi_find_other_level_edge)
4073 (bidi_move_to_visually_next): Compare cache index with
4074 bidi_cache_start rather than with zero.
4075 (bidi_fetch_char): Accept new argument STRING; all callers
4076 changed. Support iteration over a string. Support strings with
4077 display properties. Support unibyte strings. Fix the type of
4078 `len' according to what STRING_CHAR_AND_LENGTH expects.
4079 (bidi_paragraph_init, bidi_resolve_explicit_1)
4080 (bidi_resolve_explicit, bidi_resolve_weak)
4081 (bidi_level_of_next_char, bidi_move_to_visually_next):
4082 Support iteration over a string.
4083 (bidi_set_sor_type, bidi_resolve_explicit_1)
4084 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4085 can now be zero (for strings); special values 0 and -1 were
4086 changed to -1 and -2, respectively.
4087 (bidi_char_at_pos): New function.
4088 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4089 Call it instead of FETCH_MULTIBYTE_CHAR.
4090 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4091 initialized to valid values.
4092 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4094 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4095 the test for valid cached positions. Fix the logic for looking up
4096 the sentinel state in the cache. GCPRO the Lisp string we are
4098 (bidi_push_it, bidi_pop_it): New functions.
4099 (bidi_initialize): Initialize the bidi cache start stack pointer.
4100 (bidi_cache_ensure_space): New function, refactored from part of
4101 bidi_cache_iterator_state. Don't assume the required size is just
4102 one BIDI_CACHE_CHUNK away.
4103 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4104 (bidi_count_bytes, bidi_char_at_pos): New functions.
4105 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4106 always valid if bidi_cache_idx is valid.
4107 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4108 is valid if it's going to be used.
4109 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4110 (bidi_cache_fetch_state, bidi_cache_search)
4111 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4112 (bidi_cache_iterator_state, bidi_cache_find)
4113 (bidi_find_other_level_edge, bidi_cache_start_stack):
4114 All variables related to cache indices are now EMACS_INT.
4116 * dispextern.h (struct bidi_string_data): New structure.
4117 (struct bidi_it): New member `string'. Make flag members be 1-bit
4118 fields, and put them last in the struct.
4119 (compute_display_string_pos, compute_display_string_end):
4121 (bidi_push_it, bidi_pop_it): Add prototypes.
4122 (struct iterator_stack_entry): New members bidi_p,
4123 paragraph_embedding, and from_disp_prop_p.
4124 (struct it): Member bidi_p is now a bit field 1 bit wide.
4125 (bidi_shelve_cache, bidi_unshelve_cache):
4128 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4129 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4130 and vector-like objects.
4132 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4133 cache around display iteration.
4135 * window.c (Fwindow_end, window_scroll_pixel_based)
4136 (displayed_window_lines, Frecenter): Save and restore the bidi
4137 cache around display iteration.
4139 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4141 * editfns.c (Fdelete_region): Clarify the use of the named
4142 parameters (bug#6788).
4144 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4146 * indent.c (Fvertical_motion): Set and restore w->pointm when
4147 saving and restoring the window's buffer (Bug#9006).
4149 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4151 * editfns.c (Fstring_to_char): Clarify just what is returned
4152 (bug#6576). Text by Eli Zaretskii.
4154 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4156 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4158 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4160 * buffer.c (mmap_find): Fix a typo.
4162 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4164 Fix execution of x selection hooks.
4165 * xselect.c (Qx_lost_selection_functions)
4166 (Qx_sent_selection_functions): New vars.
4167 (syms_of_xselect): DEFSYM them.
4168 (x_handle_selection_request): Pass Qx_sent_selection_functions
4169 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4170 (x_handle_selection_clear,x_clear_frame_selections):
4171 Pass Qx_lost_selection_functions rather than
4172 Vx_lost_selection_functions to Frun_hook_with_args.
4174 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4176 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4177 The old code sometimes used this field without initializing it.
4179 * alloc.c (gc_sweep): Don't read past end of array.
4180 In theory, the old code could also have corrupted Emacs internals,
4181 though it'd be very unlikely.
4183 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4185 * character.c (Fcharacterp): Don't advertise optional ignored
4186 argument. (Bug#4026)
4188 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4190 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4193 * window.c (Fset_window_start): Doc fix (bug#4199).
4194 (Fset_window_hscroll): Ditto.
4196 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4198 Fix minor new problems caught by GCC 4.6.1.
4199 * term.c (init_tty): Remove unused local.
4200 * xsettings.c (store_monospaced_changed): Define this function only
4201 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4204 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4206 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4208 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4210 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4211 are the mini-buffer and the echo area (bug#3320).
4213 * term.c (init_tty): Remove support for supdup, c10 and perq
4214 terminals, which are no longer supported (bug#1482).
4216 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4218 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4220 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4222 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4223 for non-popups (Bug#3642).
4225 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4227 * alloc.c (reset_malloc_hooks): Protoize.
4228 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4229 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4230 * cm.c (losecursor): Likewise.
4231 * data.c (fmod): Likewise.
4232 * dispnew.c (swap_glyphs_in_rows): Likewise.
4233 * emacs.c (memory_warning_signal): Likewise.
4234 * floatfns.c (float_error): Likewise.
4235 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4236 (otf_open, font_otf_capability, generate_otf_features)
4237 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4239 * image.c (pbm_read_file): Likewise.
4240 * indent.c (string_display_width): Likewise.
4241 * intervals.c (check_for_interval, search_for_interval)
4242 (inc_interval_count, count_intervals, root_interval)
4243 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4244 * lread.c (defalias): Likewise.
4245 * ralloc.c (r_alloc_check): Likewise.
4246 * regex.c (set_image_of_range_1, set_image_of_range)
4247 (regex_grow_registers): Likewise.
4248 * sysdep.c (strerror): Likewise.
4249 * termcap.c (valid_filename_p, tprint, main): Likewise.
4250 * tparam.c (main): Likewise.
4251 * unexhp9k800.c (run_time_remap, save_data_space)
4252 (update_file_ptrs, read_header, write_header, calculate_checksum)
4253 (copy_file, copy_rest, display_header): Likewise.
4254 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4256 * xdisp.c (check_it): Likewise.
4257 * xfaces.c (register_color, unregister_color, unregister_colors):
4259 * xfns.c (print_fontset_result): Likewise.
4260 * xrdb.c (member, fatal, main): Likewise.
4262 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4264 Fix minor problems found by static checking (Bug#9031).
4265 * chartab.c (char_table_set_range, map_sub_char_table):
4266 Remove unused locals.
4267 (uniprop_table): Now static.
4268 * composite.c (_work_char): Remove unused static var.
4270 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4272 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4274 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4276 * gtkutil.c (qttip_cb): Remove code without function.
4278 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4280 * w32.c (pthread_sigmask): New stub.
4282 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4284 Use pthread_sigmask, not sigprocmask (Bug#9010).
4285 sigprocmask is portable only for single-threaded applications, and
4286 Emacs can be multi-threaded when it uses GTK.
4287 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4289 * callproc.c (Fcall_process):
4290 * process.c (create_process):
4291 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4292 Use pthread_sigmask, not sigprocmask.
4294 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4296 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4297 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4300 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4302 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4303 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4304 (xg_hide_tooltip): Fix comment.
4306 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4307 in registerServicesMenuSendTypes.
4308 (validRequestorForSendType): Don't check ns_return_types.
4310 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4313 2011-07-08 Jason Rumney <jasonr@gnu.org>
4315 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4316 SH_SHOW for hidden windows (Bug#5482).
4318 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4319 frame struct members of non-existent frames (Bug#6284).
4321 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4323 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4324 variable firstTime not needed on OSX >= 10.6.
4325 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4326 >= 10.5. Use setKnobProportion, setDoubleValue.
4328 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4329 (MAC_OS_X_VERSION_10_5): Define if not defined.
4330 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4331 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4332 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4334 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4335 cString and lossyCString on OSX >= 10.4
4337 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4338 sizeToFit on OSX >= 10.2.
4340 * nsimage.m (allocInitFromFile): Don't use deprecated method
4341 bestRepresentationForDevice on OSX >= 10.6.
4343 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4346 * emacs.c: Declare unexec_init_emacs_zone.
4348 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4350 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4352 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4353 on svcsMenu (Bug#8842).
4355 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4357 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4359 * nsterm.m (QUTF8_STRING): Declare.
4360 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4361 (validRequestorForSendType): Return type is (id).
4362 Change indexOfObjectIdenticalTo to indexOfObject.
4363 Check if we have local selection before returning self (Bug#8842).
4364 (writeSelectionToPasteboard): Put local selection into paste board
4365 if we have a local selection (Bug#8842).
4366 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4368 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4369 (ns_get_local_selection): Declare.
4371 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4373 * keymap.c (describe_map_tree): Don't insert a double newline at
4374 the end of the buffer (bug#1169) and return whether we inserted
4377 * callint.c (Fcall_interactively): Change "reading args" to
4378 "providing args" to try to clarify what it does (bug#1010).
4380 2011-07-07 Kenichi Handa <handa@m17n.org>
4382 * composite.c (composition_compute_stop_pos): Ignore a static
4383 composition starting before CHARPOS (Bug#8915).
4385 * xdisp.c (handle_composition_prop): Likewise.
4387 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4389 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4392 2011-07-07 Kenichi Handa <handa@m17n.org>
4394 * character.h (unicode_category_t): New enum type.
4396 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4397 (Qchar_code_property_table): New variable.
4398 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4399 (UNIPROP_COMPRESSED_FORM_P): New macros.
4400 (char_table_ascii): Uncompress the compressed values.
4401 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4402 Uncompress the compressed values.
4403 (sub_char_table_ref_and_range): Likewise.
4404 (char_table_ref_and_range): Uncompress the compressed values.
4405 (sub_char_table_set): New arg is_uniprop. Callers changed.
4406 Uncompress the compressed values.
4407 (sub_char_table_set_range): Args changed. Callers changed.
4408 (char_table_set_range): Adjuted for the above change.
4409 (map_sub_char_table): Delete args default_val and parent. Add arg
4410 top. Give decoded values to a Lisp function.
4411 (map_char_table): Adjust for the above change. Give decoded
4412 values to a Lisp function. Gcpro more variables.
4413 (uniprop_table_uncompress)
4414 (uniprop_decode_value_run_length): New functions.
4415 (uniprop_decoder, uniprop_decoder_count): New variables.
4416 (uniprop_get_decoder, uniprop_encode_value_character)
4417 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4419 (uniprop_encoder, uniprop_encoder_count): New variables.
4420 (uniprop_get_encoder, uniprop_table)
4421 (Funicode_property_table_internal, Fget_unicode_property_internal)
4422 (Fput_unicode_property_internal): New functions.
4423 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4424 Sunicode_property_table_internal, Sget_unicode_property_internal,
4425 and Sput_unicode_property_internal. Defvar_lisp
4426 char-code-property-alist.
4428 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4429 Vunicode_category_table.
4431 * font.c (font_range): Adjust for the change of
4432 Vunicode_category_table.
4434 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4436 * m/iris4d.h: Remove file, move contents ...
4437 * s/irix6-5.h: ... here.
4439 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4441 Remove unportable assumption about struct layout (Bug#8884).
4442 * alloc.c (mark_buffer):
4443 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4444 (clone_per_buffer_values): Don't assume that
4445 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4446 This isn't true in general, and it's particularly not true
4447 if Emacs is configured with --with-wide-int.
4448 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4449 New macros, used in the buffer.c change.
4451 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4453 * xsettings.c: Use both GConf and GSettings if both are available.
4454 (store_config_changed_event): Add comment.
4455 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4456 (store_tool_bar_style_changed): New functions.
4457 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4458 (struct xsettings): Move font inside HAVE_XFT.
4459 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4460 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4461 Move inside HAVE_XFT.
4462 (something_changed_gsettingsCB): Rename from something_changedCB.
4463 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4465 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4466 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4467 (something_changed_gconfCB): Rename from something_changedCB.
4468 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4469 (parse_settings): Move check for font inside HAVE_XFT.
4470 (read_settings, apply_xft_settings): Add comment.
4471 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4472 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4473 call store_font_name_changed.
4474 (xft_settings_event): Add comment.
4475 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4476 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4477 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4478 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4479 (xsettings_initialize): Call init_gsettings last.
4480 (xsettings_get_system_font, xsettings_get_system_normal_font):
4483 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4485 Random fixes. E.g., (random) never returned negative values.
4486 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4487 subseconds part to the entropy, as that's a bit more random.
4488 Prefer signed to unsigned, since the signedness doesn't matter and
4489 in general we prefer signed. When given a limit, use a
4490 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4491 latter isn't right if USE_2_TAGS_FOR_INTS.
4492 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4493 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4495 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4497 * textprop.c (text_property_stickiness):
4498 Obey Vtext_property_default_nonsticky.
4499 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4500 * w32fns.c (syms_of_w32fns):
4501 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4503 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4505 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4506 This is more efficient than Ffile_directory_p and avoids a minor race.
4508 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4510 * buffer.c (Foverlay_put): Say what the return value is
4513 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4514 is a directory before asking whether to use the file name
4516 (barf_or_query_if_file_exists): Make the "File is a directory"
4517 error be more correct.
4519 * fns.c (Frequire): Remove the mention of the .gz files, since
4520 that's installation-specific, but keep the mention of
4521 `get-load-suffixes'.
4523 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4525 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4526 Report string overflow if the output is too long.
4528 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4530 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4531 (syms_of_gnutls): Remove duplicate DEFSYM for
4532 Qgnutls_bootprop_verify_hostname_error, an error for
4533 Qgnutls_bootprop_verify_error (which is no longer used).
4535 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4536 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4537 Also (re)move comments that are misplaced or no longer relevant.
4539 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4541 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4543 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4545 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4546 and background color parameters if they have been changed.
4548 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4550 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4552 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4554 * xsettings.c (SYSTEM_FONT): Define only when used.
4555 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4557 * keymap.c (access_keymap_1): Now static.
4559 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4561 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4562 leave any prefix arg for the up event (Bug#1586).
4564 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4566 * lread.c (syms_of_lread): Mention single symbols defined by
4567 `defvar' or `defconst' (bug#7154).
4569 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4570 (Frequire): Mention get-load-suffixes.
4572 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4574 * window.h (window): Remove clone_number slot.
4575 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4577 (make_parent_window, make_window, saved_window)
4578 (Fset_window_configuration, save_window_save): Don't deal with
4580 * buffer.c (Qclone_number): Remove declaration.
4581 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4583 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4585 Add multiple inheritance to keymaps.
4586 * keymap.c (Fmake_composed_keymap): New function.
4587 (Fset_keymap_parent): Simplify.
4588 (fix_submap_inheritance): Remove.
4589 (access_keymap_1): New function extracted from access_keymap to handle
4590 embedded parents and handle lists of maps.
4591 (access_keymap): Use it.
4592 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4593 (Fcopy_keymap): Handle embedded parents.
4594 (Fcommand_remapping, define_as_prefix): Simplify.
4595 (Fkey_binding): Simplify.
4596 (syms_of_keymap): Move minibuffer-local-completion-map,
4597 minibuffer-local-filename-completion-map,
4598 minibuffer-local-must-match-map, and
4599 minibuffer-local-filename-must-match-map to Elisp.
4600 (syms_of_keymap): Defsubr make-composed-keymap.
4601 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4602 (parse_menu_item): Trivial simplification.
4604 2011-07-01 Glenn Morris <rgm@gnu.org>
4606 * Makefile.in (SETTINGS_LIBS): Fix typo.
4608 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4610 * coding.c (Fencode_coding_string): Record the last coding system
4611 used, as the function doc string says (bug#8738).
4613 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4615 * xsettings.c (store_monospaced_changed): Take new font as arg and
4616 check for change against current_mono_font.
4617 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4618 (emacs_settings_constructor, emacs_settings_get_property)
4619 (emacs_settings_set_property, emacs_settings_class_init)
4620 (emacs_settings_init, gsettings_obj): Remove.
4621 (something_changedCB): New function for HAVE_GSETTINGS.
4622 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4623 with value as argument.
4624 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4625 g_settings_new (Bug#8967). Do not create gsettings_obj.
4626 Remove calls to g_settings_bind. Connect something_changedCB to
4629 * xgselect.c: Add defined (HAVE_GSETTINGS).
4630 (xgselect_initialize): Ditto.
4632 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4633 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4636 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4638 * eval.c (struct backtrace): Simplify and port the data structure.
4639 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4640 signed bit field, as this assumption is not portable and it makes
4641 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4642 "char debug_on_exit : 1" as this is not portable either; instead,
4643 use the portable "unsigned int debug_on_exit : 1". Remove unused
4644 member evalargs. Remove obsolete comments about cc bombing out.
4646 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4648 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4649 Let HAVE_GSETTINGS override HAVE_GCONF.
4650 (store_monospaced_changed): New function.
4651 (EMACS_SETTINGS): A new type derived from GObject to handle
4652 GSettings notifications.
4653 (emacs_settings_constructor, emacs_settings_get_property)
4654 (emacs_settings_set_property, emacs_settings_class_init):
4656 (gsettings_client, gsettings_obj): New variables.
4657 (GSETTINGS_SCHEMA): New define.
4658 (something_changedCB): Call store_monospaced_changed.
4659 (init_gsettings): New function.
4660 (xsettings_initialize): Call init_gsettings.
4661 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4664 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4667 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4669 * window.c (resize_root_window, grow_mini_window)
4670 (shrink_mini_window): Rename Qresize_root_window to
4671 Qwindow_resize_root_window and Qresize_root_window_vertically to
4672 Qwindow_resize_root_window_vertically.
4674 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4676 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4678 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4680 * makefile.w32-in: Redesign dependencies so they reflect more
4681 clearly which files are directly included by each source file,
4682 and not through other includes.
4684 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4686 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4687 (sort_overlays, overlay_strings): When an overlay's clone number
4688 matches the window's clone number process the overlay even if
4689 the overlay's window property doesn't match the current window.
4691 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4692 (Fwindow_hchild): Rename to Fwindow_left_child.
4693 (Fwindow_next): Rename to Fwindow_next_sibling.
4694 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4695 (resize_window_check): Rename to window_resize_check.
4696 (resize_window_apply): Rename to window_resize_apply.
4697 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4698 (Fdelete_other_windows_internal, resize_frame_windows)
4699 (Fsplit_window_internal, Fdelete_window_internal)
4700 (grow_mini_window, shrink_mini_window)
4701 (Fresize_mini_window_internal): Fix callers accordingly.
4703 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4705 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4706 (emacs_fixed_set_min_size): Remove.
4707 (emacs_fixed_new): Take frame as argument.
4709 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4710 (_EmacsFixedPrivate): Remove minwidth/height.
4711 Add struct frame *f.
4712 (emacs_fixed_init): Initialize priv->f.
4713 (get_parent_class, emacs_fixed_set_min_size): Remove.
4714 (emacs_fixed_new): Set priv->f to argument.
4715 (emacs_fixed_get_preferred_width)
4716 (emacs_fixed_get_preferred_height): Use min_width/height from
4717 frames size_hint to set minimum and natural (Bug#8919).
4718 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4719 and use min_width/height from frames size_hint to set
4720 min_width/height (Bug#8919).
4722 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4723 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4726 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4728 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4729 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4732 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4734 * process.c (wait_reading_process_output): Bypass select if
4735 waiting for a cell while ignoring keyboard input, and input is
4736 pending. Suggested by Jan Djärv (Bug#8869).
4738 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4740 Use gnulib's dup2 module instead of rolling our own.
4741 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4743 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4745 * dispnew.c (scrolling_window): Before scrolling, turn off a
4746 mouse-highlight in the window being scrolled.
4748 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4750 Move DEFSYM to lisp.h and use everywhere.
4752 * character.h (DEFSYM): Move declaration...
4753 * lisp.h (DEFSYM): ...here.
4759 * w32select.c: Don't include character.h.
4761 * alloc.c (syms_of_alloc):
4762 * buffer.c (syms_of_buffer):
4763 * bytecode.c (syms_of_bytecode):
4764 * callint.c (syms_of_callint):
4765 * casefiddle.c (syms_of_casefiddle):
4766 * casetab.c (init_casetab_once):
4767 * category.c (init_category_once, syms_of_category):
4768 * ccl.c (syms_of_ccl):
4769 * cmds.c (syms_of_cmds):
4770 * composite.c (syms_of_composite):
4771 * dbusbind.c (syms_of_dbusbind):
4772 * dired.c (syms_of_dired):
4773 * dispnew.c (syms_of_display):
4774 * doc.c (syms_of_doc):
4775 * editfns.c (syms_of_editfns):
4776 * emacs.c (syms_of_emacs):
4777 * eval.c (syms_of_eval):
4778 * fileio.c (syms_of_fileio):
4779 * fns.c (syms_of_fns):
4780 * frame.c (syms_of_frame):
4781 * fringe.c (syms_of_fringe):
4782 * insdel.c (syms_of_insdel):
4783 * keymap.c (syms_of_keymap):
4784 * lread.c (init_obarray, syms_of_lread):
4785 * macros.c (syms_of_macros):
4786 * msdos.c (syms_of_msdos):
4787 * print.c (syms_of_print):
4788 * process.c (syms_of_process):
4789 * search.c (syms_of_search):
4790 * sound.c (syms_of_sound):
4791 * syntax.c (init_syntax_once, syms_of_syntax):
4792 * terminal.c (syms_of_terminal):
4793 * textprop.c (syms_of_textprop):
4794 * undo.c (syms_of_undo):
4795 * w32.c (globals_of_w32):
4796 * window.c (syms_of_window):
4797 * xdisp.c (syms_of_xdisp):
4798 * xfaces.c (syms_of_xfaces):
4799 * xfns.c (syms_of_xfns):
4800 * xmenu.c (syms_of_xmenu):
4801 * xsettings.c (syms_of_xsettings):
4802 * xterm.c (syms_of_xterm): Use DEFSYM.
4804 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4806 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4808 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4810 Integer and buffer overflow fixes (Bug#8873).
4812 * print.c (printchar, strout): Check for string overflow.
4813 (PRINTPREPARE, printchar, strout):
4814 Don't set size unless allocation succeeds.
4816 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4817 for sizes. Check for string overflow more accurately.
4818 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4820 * macros.c: Integer and buffer overflow fixes.
4821 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4822 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4823 Use ptrdiff_t, not int, for sizes.
4824 Don't increment bufsize until after realloc succeeds.
4825 Check for size-calculation overflow.
4826 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4828 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4830 * lread.c: Integer overflow fixes.
4831 (read_integer): Radix is now EMACS_INT, not int,
4832 to improve quality of diagnostics for out-of-range radices.
4833 Calculate buffer size correctly for out-of-range radices.
4834 (read1): Check for integer overflow in radices, and in
4835 read-circle numbers.
4836 (read_escape): Avoid int overflow.
4837 (Fload, openp, read_buffer_size, read1)
4838 (substitute_object_recurse, read_vector, read_list, map_obarray):
4839 Use ptrdiff_t, not int, for sizes.
4840 (read1): Use EMACS_INT, not int, for sizes.
4841 Check for size overflow.
4843 * image.c (cache_image): Check for size arithmetic overflow.
4845 * lread.c: Integer overflow issues.
4846 (saved_doc_string_size, saved_doc_string_length)
4847 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4848 Now ptrdiff_t, not int.
4849 (read1): Don't assume doc string length fits in int. Check for
4850 out-of-range doc string lengths.
4851 (read_list): Don't assume file position fits in int.
4852 (read_escape): Check for hex character overflow.
4854 2011-06-22 Leo Liu <sdl.web@gmail.com>
4856 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4857 Move to minibuffer.el.
4859 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4861 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4862 The following patches are for when GLYPH_DEBUG && !XASSERT.
4863 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4864 * dispnew.c (flush_stdout):
4865 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4866 Mark as externally visible.
4867 * dispnew.c (check_window_matrix_pointers): Now static.
4868 * dispnew.c (window_to_frame_vpos):
4869 * xfns.c (unwind_create_frame):
4870 * xterm.c (x_check_font): Remove unused local.
4871 * scroll.c (CHECK_BOUNDS):
4872 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4873 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4874 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4875 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4876 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4878 (debug_method_add): Use va_list and vsprintf rather than relying
4879 on undefined behavior with wrong number of arguments.
4880 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4881 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4882 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4883 since we're not interested in debugging glyphs with old libraries.
4884 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4885 GCC 4.6.0's static checking.
4887 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4889 Integer overflow and signedness fixes (Bug#8873).
4890 A few related buffer overrun fixes, too.
4892 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4894 * dispextern.h (struct face.stipple):
4895 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4896 (x_bitmap_mask, x_allocate_bitmap_record)
4897 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4898 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4899 (x_create_bitmap_from_xpm_data):
4900 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4901 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4903 * xfaces.c (load_pixmap):
4904 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4905 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4906 (.bitmaps_last, struct x_output.icon_bitmap):
4907 Use ptrdiff_t, not int, for bitmap indexes.
4908 (x_allocate_bitmap_record): Check for size overflow.
4909 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4911 Use ptrdiff_t, not int, for overlay counts.
4912 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4913 * editfns.c (overlays_around, get_pos_property):
4914 * textprop.c (get_char_property_and_overlay):
4915 * xdisp.c (next_overlay_change, note_mouse_highlight):
4916 * xfaces.c (face_at_buffer_position):
4917 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4918 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4919 (Fnext_overlay_change, Fprevious_overlay_change)
4920 (mouse_face_overlay_overlaps, Foverlays_in):
4921 Use ptrdiff_t, not int, for sizes.
4922 (overlays_at, overlays_in): Check for size-calculation overflow.
4924 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4926 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4927 (x_session_initialize): Do not assume string length fits in int.
4929 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4930 This is unlikely, but can occur if DPI is outlandish.
4932 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4933 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4935 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4936 * xrdb.c (magic_file_p, search_magic_path):
4937 Omit last arg SUFFIX; it was always 0. All callers changed.
4938 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4940 * xfont.c (xfont_match): Avoid need for strlen.
4942 * xfns.c: Don't assume strlen fits in int.
4943 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4945 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4946 not unsigned long, as we prefer signed integers. All callers changed.
4947 Detect integer overflow in repeat count.
4948 (message_dolog): Don't assume print length fits in 39 bytes.
4949 (display_mode_element): Don't assume strlen fits in int.
4951 * termcap.c: Don't assume sizes fit in int and never overflow.
4952 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4953 (gobble_line): Check for size-calculation overflow.
4955 * minibuf.c (Fread_buffer):
4956 * lread.c (intern, intern_c_string):
4957 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4958 Don't assume string length fits in int.
4960 * keyboard.c (parse_tool_bar_item):
4961 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4963 * font.c: Don't assume string length fits in int.
4964 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4965 Use ptrdiff_t, not int.
4966 (font_intern_prop): Don't assume string length fits in int.
4967 Don't assume integer property fits in fixnum.
4968 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4970 * filelock.c: Fix some buffer overrun and integer overflow issues.
4971 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4972 Reformulate so as not to need the command string.
4973 Invoke gzip -cd rather than gunzip, as it's more portable.
4974 (lock_info_type, lock_file_1, lock_file):
4975 Don't assume pid_t and time_t fit in unsigned long.
4976 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4977 (current_lock_owner): Prefer signed type for sizes.
4978 Use memcpy, not strncpy, where memcpy is what is really wanted.
4979 Don't assume (via atoi) that time_t and pid_t fit in int.
4980 Check for time_t and/or pid_t out of range, e.g., via a network share.
4981 Don't alloca where an auto var works fine.
4983 * fileio.c: Fix some integer overflow issues.
4984 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4985 Don't assume string length fits in int.
4986 (directory_file_name): Don't assume string length fits in long.
4987 (make_temp_name): Don't assume pid fits in int, or that its print
4988 length is less than 20.
4990 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4992 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4994 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4996 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4997 We prefer signed integers, even for size calculations.
4999 * emacs.c: Don't assume string length fits in 'int'.
5000 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5001 (main): Don't invoke strlen when not needed.
5003 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5004 (XD_DEBUG_MESSAGE): Don't waste a byte.
5006 * callproc.c (getenv_internal_1, getenv_internal)
5008 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5010 * lread.c (invalid_syntax): Omit length argument.
5011 All uses changed. This doesn't fix a bug, but it simplifies the
5012 code away from its former Hollerith-constant appearance, and it's
5013 one less 'int' to worry about when looking at integer-overflow issues.
5014 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5016 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5017 This didn't break anything, but it didn't help either.
5018 It's confusing to put a bogus integer in a place where the actual
5019 value does not matter.
5020 (LIST_END_P): Remove unused macro and its bogus comment.
5021 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5023 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5024 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5026 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5027 We prefer signed types, and the value cannot exceed the EMACS_INT
5028 range anyway (because otherwise the length would not be representable).
5029 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5030 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5031 This avoids a GCC warning when WIDE_EMACS_INT.
5033 * indent.c (sane_tab_width): New function.
5034 (current_column, scan_for_column, Findent_to, position_indentation)
5035 (compute_motion): Use it. This is just for clarity.
5036 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5038 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5040 * lisp.h (lint_assume): New macro.
5041 * composite.c (composition_gstring_put_cache):
5042 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5044 * editfns.c, insdel.c:
5045 Omit unnecessary forward decls, to simplify future changes.
5047 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5049 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5051 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5052 Use much-faster test for byte-length change.
5053 Don't assume string byte-length fits in 'int'.
5054 Check that character arg fits in 'int'.
5055 (mapcar1): Declare byte as byte, for clarity.
5057 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5059 * fns.c (concat): Catch string overflow earlier.
5060 Do not rely on integer wraparound.
5062 * dispextern.h (struct it.overlay_strings_charpos)
5063 (struct it.selective): Now EMACS_INT, not int.
5064 * xdisp.c (forward_to_next_line_start)
5065 (back_to_previous_visible_line_start)
5066 (reseat_at_next_visible_line_start, next_element_from_buffer):
5067 Don't arbitrarily truncate the value of 'selective' to int.
5069 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5071 * composite.c: Don't truncate sizes to 'int'.
5072 (composition_gstring_p, composition_reseat_it)
5073 (composition_adjust_point): Use EMACS_INT, not int.
5074 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5075 not EMACS_UINT, for indexes.
5077 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5079 * buffer.c: Include <verify.h>.
5080 (struct sortvec.priority, struct sortstr.priority):
5081 Now EMACS_INT, not int.
5082 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5083 (struct sortstr.size, record_overlay_string)
5084 (struct sortstrlist.size, struct sortlist.used):
5085 Don't truncate size to int.
5086 (record_overlay_string): Check for size-calculation overflow.
5087 (init_buffer_once): Check at compile-time, not run-time.
5089 2011-06-22 Jim Meyering <meyering@redhat.com>
5091 Don't leak an XBM-image-sized buffer
5092 * image.c (xbm_load): Free the image buffer after using it.
5094 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5097 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5098 that Sun C diagnosed.
5099 * fns.c (secure_hash): Fix pointer signedness issue.
5100 * intervals.c (static_offset_intervals): New function.
5101 (offset_intervals): Use it.
5103 2011-06-21 Leo Liu <sdl.web@gmail.com>
5106 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5109 * fns.c (secure_hash): Rename from crypto_hash_function and change
5110 the first arg to accept symbols.
5111 (Fsecure_hash): New primitive.
5112 (syms_of_fns): New symbols.
5114 2011-06-20 Deniz Dogan <deniz@dogan.se>
5116 * process.c (Fset_process_buffer): Clarify return value in
5119 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5121 * dispnew.c (add_window_display_history): Use BVAR.
5123 * xdisp.c (debug_method_add): Use BVAR.
5124 (check_window_end, dump_glyph_matrix, dump_glyph)
5125 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5127 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5130 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5131 check till after the cache is created in init_frame_faces.
5133 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5135 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5137 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5139 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5140 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5141 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5143 Improve buffer-overflow checking (Bug#8873).
5144 * fileio.c (Finsert_file_contents):
5145 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5146 Remove the old (too-loose) buffer overflow checks.
5147 They weren't needed, since make_gap checks for buffer overflow.
5148 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5149 The old code merely checked for Emacs fixnum overflow, and relied
5150 on undefined (wraparound) behavior. The new code avoids undefined
5151 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5153 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5154 Tune. Don't use wider integers than needed. Don't use alloca.
5155 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5157 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5159 * insdel.c, lisp.h (buffer_overflow): New function.
5160 (insert_from_buffer_1, replace_range, replace_range_2):
5161 * insdel.c (make_gap_larger):
5162 * editfns.c (Finsert_char):
5163 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5165 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5167 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5169 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5171 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5172 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5174 * fileio.c: Don't assume EMACS_INT fits in off_t.
5175 (emacs_lseek): New static function.
5176 (Finsert_file_contents, Fwrite_region): Use it.
5177 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5179 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5181 * fns.c: Don't overflow int when computing a list length.
5182 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5183 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5184 truncation on 64-bit hosts. Check for QUIT every
5185 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5186 faster and is responsive enough.
5187 (Flength): Report an error instead of overflowing an integer.
5188 (Fsafe_length): Return a float if the value is not representable
5189 as a fixnum. This shouldn't happen except in contrived situations.
5190 (Fnthcdr, Fsort): Don't assume list length fits in int.
5191 (Fcopy_sequence): Don't assume vector length fits in int.
5193 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5194 (header_size, word_size): New constants.
5195 (allocate_vectorlike): Don't check size overflow here.
5196 (allocate_vector): Check it here instead, since this is the only
5197 caller of allocate_vectorlike that could cause overflow.
5198 Check that the new vector's length is representable as a fixnum.
5200 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5201 The previous code was bogus. For example, next_almost_prime (32)
5202 returned 39, which is undesirable as it is a multiple of 3; and
5203 next_almost_prime (24) returned 25, which is a multiple of 5 so
5204 why was the code bothering to check for multiples of 7?
5206 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5208 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5210 Variadic C functions now count arguments with ptrdiff_t.
5211 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5212 Back then I didn't know that the Emacs coding style prefers signed int.
5213 Also, in the meantime I found a few more instances where arguments
5214 were being counted with int, which may truncate counts on 64-bit
5215 machines, or EMACS_INT, which may be unnecessarily wide.
5216 * lisp.h (struct Lisp_Subr.function.aMANY)
5217 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5218 Arg counts are now ptrdiff_t, not size_t.
5219 All variadic functions and their callers changed accordingly.
5220 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5221 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5222 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5223 * callint.c (Fcall_interactively): Check arg count for overflow,
5224 to avoid potential buffer overrun. Use signed char, not 'int',
5225 for 'varies' array, so that we needn't bother to check its size
5226 calculation for overflow.
5227 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5228 * eval.c (apply_lambda):
5229 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5230 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5231 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5233 * callint.c (Fcall_interactively): Don't use index var as event count.
5235 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5236 * mem-limits.h (SIZE): Remove; no longer used.
5238 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5240 Remove unnecessary casts.
5241 * xterm.c (x_term_init):
5242 * xfns.c (x_set_border_pixel):
5243 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5244 These aren't needed now that we assume ANSI C.
5246 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5247 It's more likely to cause problems (due to unsigned overflow)
5250 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5252 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5254 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5256 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5258 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5260 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5262 GLYPH_CODE_FACE returns EMACS_INT, not int.
5263 * dispextern.h (merge_faces):
5264 * xfaces.c (merge_faces):
5265 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5266 Don't assume EMACS_INT fits in int.
5268 * character.h (CHAR_VALID_P): Remove unused parameter.
5269 * fontset.c, lisp.h, xdisp.c: All uses changed.
5271 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5273 * fns.c (concat): Minor tuning based on overflow analysis.
5274 This doesn't fix any bugs. Use int to hold character, instead
5275 of constantly refetching from Emacs object. Use XFASTINT, not
5276 XINT, for value known to be a character. Don't bother comparing
5277 a single byte to 0400, as it's always less.
5279 * floatfns.c (Fexpt):
5280 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5282 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5285 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5287 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5288 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5289 incorrectly succeed when S was a string, because 4294967386 was
5290 truncated before it was used.
5292 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5293 Otherwise, an out-of-range integer could cause undefined behavior
5296 * composite.c: Use int, not EMACS_INT, for characters.
5297 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5298 EMACS_INT, for values that are known to be in character range.
5299 This doesn't fix any bugs but is the usual style inside Emacs and
5300 may generate better code on 32-bit machines.
5302 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5303 This is for reasons similar to the recent CHAR_STRING fix.
5304 * charset.c (Fencode_char): Check that character arg is actually
5305 a character. Pass an int to ENCODE_CHAR.
5306 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5307 wider than 'int', as a compile-time check to prevent future regressions
5310 * character.c (char_string): Remove unnecessary casts.
5312 Make sure a 64-bit char is never passed to CHAR_STRING.
5313 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5314 by silently ignoring the top 32 bits, allowing some values
5315 that were far too large to be valid characters.
5316 * character.h: Include <verify.h>.
5317 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5318 arguments are no wider than unsigned, as a compile-time check
5319 to prevent future regressions in this area.
5321 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5322 (Fsubst_char_in_region):
5324 * xdisp.c (decode_mode_spec_coding):
5325 Adjust to CHAR_STRING's new requirement.
5326 * editfns.c (Finsert_char, Fsubst_char_in_region):
5327 * fns.c (concat): Check that character args are actually
5328 characters. Without this test, these functions did the wrong
5329 thing with wildly out-of-range values on 64-bit hosts.
5331 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5332 These casts should not be needed on 32-bit hosts, either.
5333 * keyboard.c (read_char):
5334 * lread.c (Fload): Remove casts to unsigned.
5336 * lisp.h (UNSIGNED_CMP): New macro.
5337 This fixes comparison bugs on 64-bit hosts.
5338 (ASCII_CHAR_P): Use it.
5339 * casefiddle.c (casify_object):
5340 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5341 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5342 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5343 * dispextern.h (FACE_FROM_ID):
5344 * keyboard.c (read_char): Use UNSIGNED_CMP.
5346 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5347 not to EMACS_INT, to avoid GCC warning.
5349 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5351 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5352 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5353 isn't needed on 32-bit machines.
5355 * buffer.c (Fgenerate_new_buffer_name):
5356 Use EMACS_INT for count, not int.
5357 (advance_to_char_boundary): Return EMACS_INT, not int.
5359 * data.c (Qcompiled_function): Now static.
5361 * window.c (window_body_lines): Now static.
5363 * image.c (gif_load): Rename local to avoid shadowing.
5365 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5366 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5367 * alloc.c (make_save_value): Integer argument is now of type
5369 (mark_object): Use ptrdiff_t, not int.
5370 * lisp.h (pD): New macro.
5371 * print.c (print_object): Use it.
5373 * alloc.c: Use EMACS_INT, not int, to count objects.
5374 (total_conses, total_markers, total_symbols, total_vector_size)
5375 (total_free_conses, total_free_markers, total_free_symbols)
5376 (total_free_floats, total_floats, total_free_intervals)
5377 (total_intervals, total_strings, total_free_strings):
5378 Now EMACS_INT, not int. All uses changed.
5379 (Fgarbage_collect): Compute overall total using a double, so that
5380 integer overflow is less likely to be a problem. Check for overflow
5381 when converting back to an integer.
5382 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5383 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5384 These were 'int' variables that could overflow on 64-bit hosts;
5385 they were never used, so remove them instead of repairing them.
5386 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5387 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5388 Previously, this ceilinged at INT_MAX, but that doesn't work on
5390 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5392 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5393 (allocate_vectorlike): Check for ptrdiff_t overflow.
5394 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5395 when a (possibly-narrower) signed value would do just as well.
5396 We prefer using signed arithmetic, to avoid comparison confusion.
5398 * alloc.c: Catch some string size overflows that we were missing.
5399 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5400 for convenience in STRING_BYTES_MAX.
5401 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5402 The definition here is exact; the one in lisp.h was approximate.
5403 (allocate_string_data): Check for string overflow. This catches
5404 some instances we weren't catching before. Also, it catches
5405 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5406 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5407 and ptrdiff_t and EMACS_INT are both 64 bits.
5409 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5410 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5411 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5413 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5415 * alloc.c (Fmake_string): Check for out-of-range init.
5417 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5419 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5421 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5423 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5424 xg_get_default_scrollbar_width.
5426 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5427 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5428 (style_changed_cb): Call update_theme_scrollbar_width and call
5429 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5430 all frames (Bug#8505).
5431 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5432 Call gtk_window_set_resizable if HAVE_GTK3.
5433 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5434 and height if HAVE_GTK3 (Bug#8505).
5435 (scroll_bar_width_for_theme): New variable.
5436 (update_theme_scrollbar_width): New function.
5437 (xg_get_default_scrollbar_width): Move code to
5438 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5439 (xg_initialize): Call update_theme_scrollbar_width.
5441 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5443 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5445 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5447 * frame.c (make_frame): Call other_buffer_safely instead of
5450 * window.c (temp_output_buffer_show): Call display_buffer with
5451 second argument Vtemp_buffer_show_specifiers and reset latter
5452 immediately after the call.
5453 (Vtemp_buffer_show_specifiers): New variable.
5454 (auto_window_vscroll_p, next_screen_context_lines)
5455 (Vscroll_preserve_screen_position): Remove leading asterisks from
5458 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5460 Fix minor problems found by GCC 4.6.0 static checking.
5461 * buffer.c (Qclone_number): Remove for now, as it's unused.
5462 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5463 (record_buffer): Remove unused local.
5464 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5465 (set_frame_buffer_list): Remove; unused.
5466 * frame.h (other_visible_frames): Remove decl.
5467 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5468 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5469 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5471 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5472 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5473 Define only if HAVE_GPM.
5474 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5475 (update_hints_inhibit): Remove; never set. All uses removed.
5476 * widgetprv.h (emacsFrameClassRec): Remove decl.
5477 * window.c (delete_deletable_window): Now returns void, since it
5478 wasn't returning anything.
5479 (compare_window_configurations): Remove unused locals.
5480 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5481 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5482 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5483 the same widths as pointers. This follows up on the 2011-05-06 patch.
5484 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5485 * xterm.h: Likewise.
5486 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5488 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5490 * makefile.w32-in: Update dependencies.
5491 (LISP_H): Add lib/intprops.h.
5493 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5495 * image.c (gif_load): Add animation frame delay to the metadata.
5496 (syms_of_image): Use DEFSYM. New symbol `delay'.
5498 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5500 * window.c (delete_deletable_window): Re-add.
5501 (Fset_window_configuration): Rewrite to handle dead buffers and
5502 consequently deletable windows.
5503 (window_tree, Fwindow_tree): Remove. Supply functionality in
5505 (compare_window_configurations): Simplify code.
5507 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5509 * image.c (imagemagick_load_image): Fix type mismatch.
5510 (Fimagemagick_types): Likewise.
5512 * window.h (replace_buffer_in_windows): Declare.
5514 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5516 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5517 Qclone_number. Remove external declaration of Qdelete_window.
5518 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5520 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5521 Run Qbuffer_list_update_hook if allowed.
5522 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5523 buffer list implementation.
5524 (other_buffer_safely): New function.
5525 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5526 calls to replace_buffer_in_windows and
5527 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5529 (record_buffer): Inhibit quitting and rewrite using quittable
5530 functions. Run Qbuffer_list_update_hook if allowed.
5531 (Frecord_buffer, Funrecord_buffer): New functions.
5532 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5533 Move switch-to-buffer to window.el.
5534 (bury-buffer): Move to window.el.
5535 (Vbuffer_list_update_hook): New variable.
5537 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5540 * window.h (resize_frame_windows): Move up in code.
5541 (Fwindow_frame): Remove EXFUN.
5542 (replace_buffer_in_all_windows): Remove prototype.
5543 (replace_buffer_in_windows_safely): Add prototype.
5545 * window.c: Declare Qdelete_window static again. Move down
5546 declaration of select_count.
5547 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5548 (Fother_window): Move to window.el.
5549 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5550 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5551 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5553 (replace_buffer_in_windows): Implement by calling
5554 Qreplace_buffer_in_windows.
5555 (replace_buffer_in_all_windows): Remove with some functionality
5556 moved into replace_buffer_in_windows_safely.
5557 (replace_buffer_in_windows_safely): New function.
5558 (select_window_norecord, select_frame_norecord): Move in front
5559 of run_window_configuration_change_hook. Remove now obsolete
5561 (Fset_window_buffer): Rewrite doc-string.
5562 Call Qrecord_window_buffer.
5563 (keys_of_window): Move binding for other-window to window.el.
5565 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5567 * dispextern.h (struct image): Replace data member, whose int_val
5568 and ptr_val fields were not used by anything, with a single
5571 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5572 (gif_clear_image, gif_load, imagemagick_load_image)
5573 (gs_clear_image, gs_load): Callers changed.
5575 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5577 * buffer.h: Include <time.h>, for time_t.
5578 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5580 Fix minor problems found by static checking.
5582 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5584 Make identifiers static if they are not used in other modules.
5585 * data.c (Qcompiled_function, Qframe, Qvector):
5586 * image.c (QimageMagick, Qsvg):
5587 * minibuf.c (Qmetadata):
5588 * window.c (resize_window_check, resize_root_window): Now static.
5589 * window.h (resize_window_check, resize_root_window): Remove decls.
5591 * window.c (window_deletion_count, delete_deletable_window):
5593 (window_body_lines): Now static.
5594 (Fdelete_other_windows_internal): Mark vars as initialized.
5595 Make sure 'resize_failed' is initialized.
5596 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5597 (resize_window_apply): Remove unused local.
5598 * window.h (delete_deletable_window): Remove decl.
5600 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5601 (imagemagick_load_image): Fix pointer signedness problem by changing
5602 last arg from unsigned char * to char *. All uses changed.
5603 Also, fix a local for similar reasons.
5604 Remove unused locals. Remove locals to avoid shadowing.
5605 (fn_rsvg_handle_free): Remove; unused.
5606 (svg_load, svg_load_image): Fix pointer signedness problem.
5607 (imagemagick_load_image): Don't use garbage pointer image_wand.
5609 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5611 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5613 * image.c (gif_load): Fix omitted cast error introduced by
5616 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5618 * window.h (resize_proportionally, orig_total_lines)
5619 (orig_top_line): Remove from window structure.
5620 (set_window_height, set_window_width, change_window_heights)
5621 (Fdelete_window): Remove prototypes.
5622 (resize_frame_windows): Remove duplicate declaration.
5624 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5626 * window.h (resize_frame_windows, resize_window_check)
5627 (delete_deletable_window, resize_root_window)
5628 (resize_frame_windows): Declare prototypes.
5630 * window.c (resize_window_apply): Make definition be "static" to
5631 match the prototype.
5633 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5635 * window.c: Remove declarations of Qwindow_size_fixed,
5636 window_min_size_1, window_min_size_2, window_min_size,
5637 size_window, window_fixed_size_p, enlarge_window, delete_window.
5638 Remove static from declaration of Qdelete_window, it's
5639 temporarily needed by Fbury_buffer.
5640 (replace_window): Don't assign orig_top_line and
5642 (Fdelete_window, delete_window): Remove. Window deletion is
5643 handled by window.el.
5644 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5645 Replace Fdelete_window calls with calls to Qdelete_window.
5646 (Fdelete_other_windows): Remove. Deleting other windows is
5647 handled by window.el.
5648 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5649 handled in window.el.
5650 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5651 Window minimum sizes are handled in window.el.
5652 (shrink_windows, size_window, set_window_height)
5653 (set_window_width, change_window_heights, window_height)
5654 (window_width, CURBEG, CURSIZE, enlarge_window)
5655 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5656 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5657 handled in window.el.
5658 (make_dummy_parent): Rename to make_parent_window and give it a
5659 second argument horflag.
5660 (make_window): Don't set resize_proportionally any more.
5661 (Fsplit_window): Remove. Windows are split in window.el.
5662 (save_restore_action, save_restore_orig_size)
5663 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5664 Resize mini windows in window.el.
5665 (grow_mini_window, shrink_mini_window): Implement by calling
5666 Qresize_root_window_vertically, resize_window_check and
5667 resize_window_apply.
5668 (saved_window, Fset_window_configuration, save_window_save):
5669 Do not handle orig_top_line, orig_total_lines, and
5670 resize_proportionally.
5671 (window_min_height, window_min_width): Move to window.el.
5672 (keys_of_window): Move bindings for delete-other-windows,
5673 split-window, delete-window and enlarge-window to window.el.
5675 * buffer.c: Temporarily extern Qdelete_window.
5676 (Fbury_buffer): Temporarily call Qdelete_window instead of
5677 Fdelete_window (Fbury_buffer will move to window.el soon).
5679 * frame.c (set_menu_bar_lines_1): Remove code handling
5680 orig_top_line and orig_total_lines.
5682 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5683 set_window_height but set heights directly.
5684 (change_frame_size_1): Use resize_frame_windows.
5686 * xdisp.c (init_xdisp): Don't use set_window_height but set
5689 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5690 Use resize_frame_windows instead of change_window_heights and run
5691 run_window_configuration_change_hook.
5693 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5694 instead of change_window_heights and run
5695 run_window_configuration_change_hook.
5697 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5699 * window.c (replace_window): Rename second argument REPLACEMENT to
5700 NEW. New third argument SETFLAG. Rewrite.
5701 (delete_window, make_dummy_parent): Call replace_window with
5703 (window_list_1): Move down in code.
5704 (run_window_configuration_change_hook): Move set_buffer part
5705 before select_frame_norecord part in order to unwind correctly.
5706 Rename count1 to count.
5707 (recombine_windows, delete_deletable_window, resize_root_window)
5708 (Fdelete_other_windows_internal)
5709 (Frun_window_configuration_change_hook, make_parent_window)
5710 (resize_window_check, resize_window_apply, Fresize_window_apply)
5711 (resize_frame_windows, Fsplit_window_internal)
5712 (Fdelete_window_internal, Fresize_mini_window_internal):
5714 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5716 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5718 * window.h (window): Add some new members to window structure -
5719 normal_lines, normal_cols, new_total, new_normal, clone_number,
5720 splits, nest, prev_buffers, next_buffers.
5721 (WINDOW_TOTAL_SIZE): Move here from window.c.
5722 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5724 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5726 (make_dummy_parent): Set new members of windows structure.
5727 (make_window): Move down in code. Handle new members of window
5729 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5730 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5731 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5732 (Fset_window_prev_buffers, Fwindow_next_buffers)
5733 (Fset_window_next_buffers, Fset_window_clone_number):
5735 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5736 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5738 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5739 Argument WINDOW can be now internal window too.
5740 (Fwindow_use_time): Move up in code.
5741 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5743 (Fset_window_configuration, saved_window)
5744 (Fcurrent_window_configuration, save_window_save): Handle new
5745 members of window structure.
5746 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5747 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5748 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5749 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5750 Qget_mru_window, Qresize_root_window,
5751 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5752 Qauto_buffer_name; staticpro them.
5754 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5756 * window.c (Fwindow_total_size, Fwindow_left_column)
5757 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5758 (Fwindow_list_1): New functions.
5759 (window_box_text_cols): Replace with window_body_cols.
5760 (Fwindow_width, Fscroll_left, Fscroll_right):
5761 Use window_body_cols instead of window_box_text_cols.
5762 (delete_window, Fset_window_configuration):
5763 Call delete_all_subwindows with window as argument.
5764 (delete_all_subwindows): Take a window as argument and not a
5766 (window_loop): Remove handling of GET_LRU_WINDOW and
5768 (Fget_lru_window, Fget_largest_window): Move to window.el.
5770 * window.h: Extern window_body_cols instead of
5771 window_box_text_cols. delete_all_subwindows now takes a
5772 Lisp_Object as argument.
5774 * indent.c (compute_motion, Fcompute_motion):
5775 Use window_body_cols instead of window_box_text_cols.
5777 * frame.c (delete_frame): Call delete_all_subwindows with root
5780 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5782 * fns.c (Fputhash): Document return value.
5784 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5786 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5788 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5790 Cons<->int and similar integer overflow fixes (Bug#8794).
5792 Check for overflow when converting integer to cons and back.
5793 * charset.c (Fdefine_charset_internal, Fdecode_char):
5794 Use cons_to_unsigned to catch overflow.
5795 (Fencode_char): Use INTEGER_TO_CONS.
5796 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5797 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5798 * data.c (long_to_cons, cons_to_long): Remove.
5799 (cons_to_unsigned, cons_to_signed): New functions.
5800 These signal an error for invalid or out-of-range values.
5801 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5802 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5803 * font.c (Ffont_variation_glyphs):
5804 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5805 * lisp.h: Include <intprops.h>.
5806 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5807 (cons_to_signed, cons_to_unsigned): New decls.
5808 (long_to_cons, cons_to_long): Remove decls.
5809 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5810 (Fprimitive_undo): Use CONS_TO_INTEGER.
5811 * xfns.c (Fx_window_property): Likewise.
5812 * xselect.c: Include <limits.h>.
5813 (x_own_selection, selection_data_to_lisp_data):
5814 Use INTEGER_TO_CONS.
5815 (x_handle_selection_request, x_handle_selection_clear)
5816 (x_get_foreign_selection, Fx_disown_selection_internal)
5817 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5818 (lisp_data_to_selection_data): Use cons_to_unsigned.
5819 (x_fill_property_data): Use cons_to_signed.
5820 Report values out of range.
5822 Check for buffer and string overflow more precisely.
5823 * buffer.h (BUF_BYTES_MAX): New macro.
5824 * lisp.h (STRING_BYTES_MAX): New macro.
5825 * alloc.c (Fmake_string):
5826 * character.c (string_escape_byte8):
5827 * coding.c (coding_alloc_by_realloc):
5828 * doprnt.c (doprnt):
5829 * editfns.c (Fformat):
5831 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5832 since they may not be the same number.
5833 * editfns.c (Finsert_char):
5834 * fileio.c (Finsert_file_contents):
5835 Likewise for BUF_BYTES_MAX.
5837 * image.c: Use ptrdiff_t, not int, for sizes.
5838 (slurp_file): Switch from int to ptrdiff_t.
5840 (slurp_file): Check that file size fits in both size_t (for
5841 malloc) and ptrdiff_t (for sanity and safety).
5843 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5844 if b->modtime has its maximal value.
5846 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5848 Don't assume time_t can fit into int.
5849 * buffer.h (struct buffer.modtime): Now time_t, not int.
5850 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5851 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5853 Minor fixes for signed vs unsigned integers.
5854 * character.h (MAYBE_UNIFY_CHAR):
5855 * charset.c (maybe_unify_char):
5856 * keyboard.c (read_char, reorder_modifiers):
5857 XINT -> XFASTINT, since the integer must be nonnegative.
5858 * ftfont.c (ftfont_spec_pattern):
5859 * keymap.c (access_keymap, silly_event_symbol_error):
5860 XUINT -> XFASTINT, since the integer must be nonnegative.
5861 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5862 since it makes no difference and we prefer signed.
5863 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5864 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5867 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5869 * window.h (Fwindow_frame): Declare.
5871 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5873 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5874 (SPARE_MEMORY): Always define.
5875 (LARGE_REQUEST): Remove.
5876 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5878 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5880 * lisp.h: Move EXFUNS for Fframe_root_window,
5881 Fframe_first_window and Fset_frame_selected_window to window.h.
5883 * window.h: Move EXFUNS for Fframe_root_window,
5884 Fframe_first_window and Fset_frame_selected_window here from
5887 * frame.c (Fwindow_frame, Fframe_first_window)
5888 (Fframe_root_window, Fframe_selected_window)
5889 (Fset_frame_selected_window): Move to window.c.
5890 (Factive_minibuffer_window): Move to minibuf.c.
5891 (Fother_visible_frames_p): New function.
5893 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5895 * window.c (decode_window, decode_any_window): Move up in code.
5896 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5897 (inhibit_frame_unsplittable): Remove unused variable.
5898 (Fwindow_buffer): Move up and rewrite doc-string.
5899 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5900 (Fwindow_prev): New functions.
5901 (Fwindow_frame): Move here from frame.c. Accept any window as
5903 (Fframe_root_window, Fframe_first_window)
5904 (Fframe_selected_window): Move here from frame.c. Accept frame
5905 or arbitrary window as argument. Update doc-strings.
5906 (Fminibuffer_window): Move up in code.
5907 (Fwindow_minibuffer_p): Move up in code and simplify.
5908 (Fset_frame_selected_window): Move here from frame.c.
5910 (Fselected_window, select_window, Fselect_window): Move up in
5911 code. Minor doc-string fixes.
5913 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5915 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5916 Do not assume that spare memory exists; that assumption is valid
5917 only if SYSTEM_MALLOC.
5918 (LARGE_REQUEST): New macro, so that the issue of large requests
5919 is separated from the issue of spare memory.
5921 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5923 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5926 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5928 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5931 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5933 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5935 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5937 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5938 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5940 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5942 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5944 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5946 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5947 (x_clipboard_manager_save): Add return value.
5948 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5950 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5951 Obey Vx_select_enable_clipboard_manager. Catch errors in
5952 x_clipboard_manager_save (Bug#8779).
5953 (Vx_select_enable_clipboard_manager): New variable.
5954 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5956 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5958 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5960 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5962 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5963 in the current matrix if keep_current_p is non-zero.
5965 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5967 * bidi.c (bidi_level_of_next_char): Fix last change.
5969 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5971 Support bidi reordering of text covered by display properties.
5973 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5974 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5975 (bidi_cache_search, bidi_cache_iterator_state)
5976 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5977 (bidi_level_of_next_char, bidi_move_to_visually_next):
5978 Support character positions inside a run of characters covered by a
5980 (bidi_paragraph_init, bidi_resolve_explicit_1)
5981 (bidi_level_of_next_char): Call bidi_fetch_char and
5982 bidi_fetch_char_advance instead of FETCH_CHAR and
5984 (bidi_init_it): Initialize new members.
5985 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5987 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5988 instead of using explicit *_CHAR codes.
5989 (bidi_resolve_explicit, bidi_resolve_weak):
5990 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5991 bidirectional text is supported only in multibyte buffers.
5992 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5993 it to initialize the frame_window_p member of struct bidi_it.
5994 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5995 (bidi_resolve_explicit, bidi_resolve_weak)
5996 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5997 bidi_it->nchars is non-positive.
5998 (bidi_level_of_next_char): Don't try to lookup the cache for the
5999 next/previous character if nothing is cached there yet, or if we
6000 were just reseat()'ed to a new position.
6002 * xdisp.c (set_cursor_from_row): Set start and stop points
6003 according to the row's direction when priming the loop that looks
6004 for the glyph on which to display cursor.
6005 (single_display_spec_intangible_p): Function deleted.
6006 (display_prop_intangible_p): Reimplement to call
6007 handle_display_spec instead of single_display_spec_intangible_p.
6008 Accept 3 additional arguments needed by handle_display_spec.
6009 This fixes incorrect cursor motion across display property with complex
6010 values: lists, `(when COND...)' forms, etc.
6011 (single_display_spec_string_p): Support property values that are
6012 lists with the argument STRING its top-level element.
6013 (display_prop_string_p): Fix the condition for processing a
6014 property that is a list to be consistent with handle_display_spec.
6015 (handle_display_spec): New function, refactored from the
6016 last portion of handle_display_prop.
6017 (compute_display_string_pos): Accept additional argument
6018 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6019 value of a `display' property is a "replacing spec".
6020 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6021 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6022 the display property, but just return a value indicating whether
6023 the display property will replace the characters it covers.
6024 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6025 frame_window_p members of struct bidi_it.
6026 (compute_display_string_pos, compute_display_string_end):
6028 (push_it): Accept second argument POSITION, where pop_it should
6029 jump to continue iteration.
6030 (reseat_1): Initialize bidi_it.disp_pos.
6032 * keyboard.c (adjust_point_for_property): Adjust the call to
6033 display_prop_intangible_p to its new signature.
6035 * dispextern.h (struct bidi_it): New member frame_window_p.
6036 (bidi_init_it): Update prototypes.
6037 (display_prop_intangible_p): Update prototype.
6038 (compute_display_string_pos, compute_display_string_end):
6040 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6043 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6045 Malloc failure behavior now depends on size of allocation.
6046 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6047 * lisp.h: Change signatures accordingly.
6048 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6049 All callers changed. (Bug#8762)
6051 * gnutls.c: Use Emacs's memory allocators.
6052 Without this change, the gnutls library would invoke malloc etc.
6053 directly, which causes problems on non-SYNC_INPUT hosts, and which
6054 runs afoul of improving memory_full behavior. (Bug#8761)
6055 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6056 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6057 xfree instead of the default malloc, realloc, free.
6058 (Fgnutls_boot): No need to check for memory allocation failure,
6059 since xmalloc does that for us.
6061 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6062 * category.c (hash_get_category_set):
6063 * ccl.c (ccl_driver):
6064 * charset.c (Fdefine_charset_internal):
6065 * charset.h (struct charset.hash_index):
6066 * composite.c (get_composition_id, gstring_lookup_cache)
6067 (composition_gstring_put_cache):
6068 * composite.h (struct composition.hash_index):
6069 * dispextern.h (struct image.hash):
6070 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6071 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6072 (hashfn_equal, hashfn_user_defined, make_hash_table)
6073 (maybe_resize_hash_table, hash_lookup, hash_put)
6074 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6075 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6076 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6077 * image.c (make_image, search_image_cache, lookup_image)
6078 (xpm_put_color_table_h):
6079 * lisp.h (struct Lisp_Hash_Table):
6080 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6081 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6082 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6083 * alloc.c (allocate_vectorlike):
6084 Check for overflow in vector size calculations.
6085 * ccl.c (ccl_driver):
6086 Check for overflow when converting EMACS_INT to int.
6087 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6088 need to be updated by these changes.
6089 * fns.c (make_hash_table, maybe_resize_hash_table):
6090 Check for integer overflow with large hash tables.
6091 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6092 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6093 (SXHASH_REDUCE): New macro.
6094 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6095 Use it instead of discarding useful hash info with large hash values.
6096 (sxhash_float): New function.
6097 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6098 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6099 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6100 Rewrite to use FIXNUM_BITS, as this simplifies things.
6101 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6102 Adjust signatures to match updated version of code.
6103 (consing_since_gc): Now EMACS_INT, since a single hash table can
6104 use more than INT_MAX bytes.
6106 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6108 Make it possible to build with GCC-4.6+ -O2 -flto.
6110 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6112 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6114 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6115 Call minibuffer-inactive-mode.
6117 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6119 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6120 Update dependencies.
6122 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6124 * data.c (init_data): Remove code for UTS, this system is not
6127 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6129 Don't force ./temacs to start in terminal mode.
6131 * frame.c (make_initial_frame): Initialize faces in all cases, not
6132 only when CANNOT_DUMP is defined.
6133 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6135 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6137 * dispnew.c (add_window_display_history): Use const for the string
6138 pointer. Remove declaration, not needed.
6140 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6142 Use 'inline', not 'INLINE'.
6143 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6144 * alloc.c, fontset.c (INLINE): Remove.
6145 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6146 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6147 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6148 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6149 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6151 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6153 Make it possible to run ./temacs.
6155 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6156 syms_of_callproc does the same thing. Remove test for
6157 "initialized", do it in the caller.
6158 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6160 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6162 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6163 (read_minibuf): Use get_minibuffer.
6164 (syms_of_minibuf): Use DEFSYM.
6165 (Qmetadata): New var.
6166 * data.c (Qbuffer): Don't make it static.
6167 (syms_of_data): Use DEFSYM.
6169 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6171 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6172 (CCL_CODE_MIN): New macro.
6174 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6176 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6178 * eval.c (Qdebug): Now static.
6179 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6180 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6181 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6183 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6185 * image.c: Various fixes to ImageMagick code comments.
6186 (Fimagemagick_types): Doc fix.
6188 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6190 Minor fixes prompted by GCC 4.6.0 warnings.
6192 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6194 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6195 (x_clipboard_manager_save_all): Move extern decl to ...
6196 * xterm.h: ... here, so that it can be checked for consistency.
6198 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6200 * xselect.c (x_clipboard_manager_save_frame)
6201 (x_clipboard_manager_save_all): New functions.
6202 (Fx_clipboard_manager_save): Lisp function deleted.
6204 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6205 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6207 * xterm.h: Update prototype.
6209 2011-05-28 William Xu <william.xwl@gmail.com>
6211 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6214 2011-05-28 Jim Meyering <meyering@redhat.com>
6216 Avoid a sign-extension bug in crypto_hash_function.
6217 * fns.c (to_uchar): Define.
6218 (crypto_hash_function): Use it to convert some newly-signed
6219 variables to unsigned, to avoid sign-extension bugs. For example,
6220 without this change, (md5 "truc") would evaluate to
6221 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6222 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6223 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6225 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6227 Integer overflow fixes.
6229 * dbusbind.c: Serial number integer overflow fixes.
6230 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6231 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6232 to hold a serial number that is too large for a fixnum.
6233 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6234 Check for serial numbers out of range. Decode any serial number
6235 that was so large that it became a float. (Bug#8722)
6237 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6238 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6239 Use XFASTINT rather than XUINT when numbers are nonnegative.
6240 (xd_append_arg, Fdbus_method_return_internal):
6241 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6242 arguments, check that Lisp number is nonnegative, rather than
6243 silently wrapping negative numbers around. (Bug#8722)
6244 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6247 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6249 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6251 ccl: Add integer overflow checks.
6252 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6253 (IN_INT_RANGE): New macros.
6254 (ccl_driver): Use them to check for integer overflow when
6255 decoding a CCL program. Many of the new checks are whether XINT (x)
6256 fits in int; it doesn't always, on 64-bit hosts. The new version
6257 doesn't catch all possible integer overflows, but it's an
6258 improvement. (Bug#8719)
6260 * alloc.c (make_event_array): Use XINT, not XUINT.
6261 There's no need for unsigned here.
6263 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6264 This follows up to the 2011-05-06 change that substituted uintptr_t
6265 for EMACS_INT. This case wasn't caught back then.
6267 Rework Fformat to avoid integer overflow issues.
6268 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6269 now (part of C89). Include <verify.h>.
6270 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6271 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6272 (Fformat): Avoid the prepass trying to compute sizes; it was only
6273 approximate and thus did not catch overflow reliably. Instead, walk
6274 through the format just once, formatting and computing sizes as we go,
6275 checking for integer overflow at every step, and allocating a larger
6276 buffer as needed. Keep track separately whether the format is
6277 multibyte. Keep only the most-recently calculated precision, rather
6278 than them all. Record whether each argument has been converted to
6279 string. Use EMACS_INT, not int, for byte and char and arg counts.
6280 Support field widths and precisions larger than INT_MAX. Avoid
6281 sprintf's undefined behavior with conversion specifications such as %#d
6282 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6283 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6284 formatting out-of-range floating point numbers with int
6287 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6289 * data.c: Avoid integer truncation in expressions involving floats.
6290 * data.c: Include <intprops.h>.
6291 (arith_driver): When there's an integer overflow in an expression
6292 involving floating point, convert the integers to floating point
6293 so that the resulting value does not suffer from catastrophic
6294 integer truncation. For example, on a 64-bit host (* 4
6295 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6296 Do not rely on undefined behavior after integer overflow.
6298 merge count_size_as_multibyte, parse_str_to_multibyte
6299 * character.c, character.h (count_size_as_multibyte):
6300 Rename from parse_str_to_multibyte; all uses changed.
6301 Check for integer overflow.
6302 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6303 since it's now a duplicate of the other. This is more of
6304 a character than a buffer op, so better that it's in character.c.
6305 * fns.c, print.c: Adjust to above changes.
6307 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6309 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6311 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6313 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6314 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6315 (x_clipboard_manager_save): Now static.
6316 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6318 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6319 (crypto_hash_function): Now static.
6320 Fix pointer signedness problems. Avoid unnecessary initializations.
6322 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6324 * termhooks.h (Vselection_alist): Make it terminal-local.
6326 * terminal.c (create_terminal): Initialize it.
6328 * xselect.c: Support for clipboard managers.
6329 (Vselection_alist): Move to termhooks.h as terminal-local var.
6330 (LOCAL_SELECTION): New macro.
6331 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6332 (symbol_to_x_atom): Remove gratuitous arg.
6333 (x_handle_selection_request, lisp_data_to_selection_data)
6334 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6335 (x_own_selection, x_get_local_selection, x_convert_selection):
6336 New arg, specifying work frame. Use terminal-local Vselection_alist.
6337 (some_frame_on_display): Delete unused function.
6338 (Fx_own_selection_internal, Fx_get_selection_internal)
6339 (Fx_disown_selection_internal, Fx_selection_owner_p)
6340 (Fx_selection_exists_p): New optional frame arg.
6341 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6342 (x_handle_selection_clear): Don't treat other terminals with the
6343 same keyboard specially. Use the terminal-local Vselection_alist.
6344 (x_clear_frame_selections): Use Frun_hook_with_args.
6346 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6348 * xterm.h: Add support for those atoms.
6350 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6352 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6353 (converted_selections, conversion_fail_tag): New global variables.
6354 (x_selection_request_lisp_error): Free the above.
6355 (x_get_local_selection): Remove unnecessary code.
6356 (x_reply_selection_request): Args changed; handle arbitrary array
6357 of converted selections stored in converted_selections.
6358 Separate the XChangeProperty and SelectionNotify steps.
6359 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6360 (x_convert_selection): New function.
6361 (x_handle_selection_event): Simplify.
6362 (x_get_foreign_selection): Don't ignore incoming requests while
6363 waiting for an answer; this will fail when we implement
6364 SAVE_TARGETS, and seems unnecessary anyway.
6365 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6366 (Vx_sent_selection_functions): Doc fix.
6368 2011-05-26 Leo Liu <sdl.web@gmail.com>
6370 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6372 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6374 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6376 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6377 for fringe update if it has periodic bitmap.
6378 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6379 and fringe_bitmap_periodic_p.
6381 * fringe.c (get_fringe_bitmap_data): New function.
6382 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6383 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6384 row. Mark glyph row for fringe update if periodicity changed.
6386 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6387 for fringe update unless it has periodic bitmap.
6389 2011-05-25 Kenichi Handa <handa@m17n.org>
6391 * xdisp.c (get_next_display_element): Set correct it->face_id for
6392 a static composition.
6394 2011-05-24 Leo Liu <sdl.web@gmail.com>
6397 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6399 * fns.c (crypto_hash_function, Fsha1): New function.
6400 (Fmd5): Use crypto_hash_function.
6401 (syms_of_fns): Add Ssha1.
6403 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6405 * gnutls.c: Remove unused macros.
6406 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6407 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6408 Remove macros that are defined and never used.
6409 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6411 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6413 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6414 (Fx_get_selection_internal): Minor cleanup.
6415 (Fx_own_selection_internal): Rename arguments for consistency with
6418 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6420 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6422 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6424 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6426 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6428 * dispnew.c (scrolling_window): Don't exclude the case that the
6429 last enabled row in the desired matrix touches the bottom boundary.
6431 2011-05-21 Glenn Morris <rgm@gnu.org>
6433 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6434 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6435 and add some more files.
6437 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6439 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6440 report_file_error introduced by the change from 2011-05-07.
6442 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6444 * systime.h (Time): Define only if emacs is defined.
6445 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6446 where the include path doesn't have X11/X.h by default. See
6447 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6449 2011-05-20 Kenichi Handa <handa@m17n.org>
6451 * composite.c (find_automatic_composition): Fix previous change.
6453 2011-05-20 Glenn Morris <rgm@gnu.org>
6455 * lisp.mk: New file, split from Makefile.in.
6456 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6457 (shortlisp): Remove.
6458 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6460 2011-05-19 Glenn Morris <rgm@gnu.org>
6462 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6463 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6464 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6465 (lisp): Set the order to that of loadup.el.
6466 (shortlisp): Make it a copy of $lisp.
6467 (SOME_MACHINE_LISP): Remove.
6468 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6469 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6471 2011-05-18 Kenichi Handa <handa@m17n.org>
6473 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6474 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6475 (find_automatic_composition): Mostly rewrite for efficiency.
6477 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6479 * makefile.w32-in: Update dependencies.
6481 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6483 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6484 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6486 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6488 Fix some integer overflow issues, such as string length overflow.
6490 * insdel.c (count_size_as_multibyte): Check for string overflow.
6492 * character.c (lisp_string_width): Check for string overflow.
6493 Use EMACS_INT, not int, for string indexes and lengths; in
6494 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6495 the resulting string length overflows an EMACS_INT; instead,
6496 report a string overflow if no precision given. When checking for
6497 precision exhaustion, use a check that cannot possibly have
6498 integer overflow. (Bug#8675)
6499 * character.h (lisp_string_width): Adjust to new signature.
6501 * alloc.c (string_overflow): New function.
6502 (Fmake_string): Use it. This doesn't change behavior, but saves
6503 a few bytes and will simplify future changes.
6504 * character.c (string_escape_byte8): Likewise.
6505 * lisp.h (string_overflow): New decl.
6507 Fixups, following up to the user-interface timestamp change.
6508 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6509 for UI timestamps, instead of unsigned long.
6510 * msdos.c (mouse_get_pos): Likewise.
6511 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6512 * w32gui.h (Time): Define by including "systime.h" rather than by
6513 declaring it ourselves. (Bug#8664)
6515 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6516 * image.c (clear_image_cache): Likewise.
6518 * term.c (term_mouse_position): Don't assume time_t wraparound.
6520 Be more systematic about user-interface timestamps.
6521 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6522 and sometimes 'EMACS_UINT', to represent these timestamps.
6523 This change causes it to use 'Time' uniformly, as that's what X uses.
6524 This makes the code easier to follow, and makes it easier to catch
6525 integer overflow bugs such as Bug#8664.
6526 * frame.c (Fmouse_position, Fmouse_pixel_position):
6527 Use Time, not unsigned long, for user-interface timestamps.
6528 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6529 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6530 * keyboard.h (last_event_timestamp): Likewise.
6531 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6532 * menu.h (xmenu_show): Likewise.
6533 * term.c (term_mouse_position): Likewise.
6534 * termhooks.h (struct input_event.timestamp): Likewise.
6535 (struct terminal.mouse_position_hook): Likewise.
6536 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6537 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6538 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6539 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6541 * menu.h, termhooks.h: Include "systime.h", for Time.
6543 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6544 Don't assume that the difference between two unsigned long values
6545 can fit into an integer. At this point, we know button_down_time
6546 <= event->timestamp, so the difference must be nonnegative, so
6547 there's no need to cast the result if double-click-time is
6548 nonnegative, as it should be; check that it's nonnegative, just in
6549 case. This bug is triggered when events are more than 2**31 ms
6550 apart (about 25 days). (Bug#8664)
6552 * xselect.c (last_event_timestamp): Remove duplicate decl.
6553 (x_own_selection): Remove needless cast to unsigned long.
6555 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6556 that always fit in int. Use a sentinel instead of a counter, to
6557 avoid a temp and to allay GCC's concerns about possible int overflow.
6558 * frame.h (struct frame): Use int for menu_bar_items_used
6559 instead of EMACS_INT, since it always fits in int.
6561 * menu.c (grow_menu_items): Check for int overflow.
6563 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6565 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6566 Before, the code was not consistent. These values cannot exceed
6567 2**31 - 1 so there's no need to make them unsigned.
6568 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6569 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6570 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6572 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6574 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6575 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6576 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6577 presumably because the widths might not match.
6579 * window.c (size_window): Avoid needless test at loop start.
6581 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6583 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6585 2011-05-12 Drew Adams <drew.adams@oracle.com>
6587 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6589 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6591 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6592 `width' to `bar_area_x' and `bar_area_width', respectively.
6593 (x_scroll_run): Take account of fringe background extension.
6595 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6596 Rename local vars `left' and `width' to `bar_area_x' and
6597 `bar_area_width', respectively.
6598 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6599 background extension.
6601 2011-05-10 Jim Meyering <meyering@redhat.com>
6603 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6605 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6607 * image.c (Finit_image_library): Return t for built-in image types,
6608 like pbm and xbm. (Bug#8640)
6610 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6612 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6614 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6616 * w32console.c (Fset_screen_color): Doc fix.
6617 (Fget_screen_color): New function.
6618 (syms_of_ntterm): Defsubr it.
6620 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6621 unlink the temporary file if Fcall_process didn't create it in the
6623 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6624 child process will be redirected to a file specified with `:file'.
6625 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6626 cue to call_process_cleanup not to close that handle.
6628 2011-05-07 Ben Key <bkey76@gmail.com>
6630 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6631 one of two shell specific rules, either bootstrap-temacs-CMD or
6632 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6633 to the previous implementation of the bootstrap-temacs rule.
6634 The bootstrap-temacs-CMD rule is similar to the previous
6635 implementation of the bootstrap-temacs rule except that it
6636 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6639 These changes, along with some changes to nt/configure.bat,
6640 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6641 earlier fix to add support for --cflags and --ldflags options
6642 that include quotes so that it works whether make uses cmd or
6645 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6647 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6648 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6650 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6651 a string. Handle both cases.
6652 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6653 (Fdbus_register_method): Use Qinvalid_function.
6655 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6657 * makefile.w32-in: Update dependencies.
6658 (LISP_H): Add inttypes.h and stdin.h.
6659 (PROCESS_H): Add unistd.h.
6661 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6663 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6664 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6666 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6668 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6670 * term.c (vfatal): Remove stray call to va_end.
6671 It's not needed and the C Standard doesn't allow it here anyway.
6673 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6674 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6676 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6679 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6681 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6683 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6685 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6687 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6689 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6690 * charset.c (Fdefine_charset_internal): Don't initialize
6691 charset.code_space[15]. The value was garbage, on hosts with
6692 32-bit int (Bug#8600).
6694 * lread.c (read_integer): Be more consistent with string-to-number.
6695 Use string_to_number to do the actual conversion; this avoids
6696 rounding errors and fixes some other screwups. Without this fix,
6697 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6698 (digit_to_number): Move earlier, for benefit of read_integer.
6699 Return -1 if the digit is out of range for the base, -2 if it is
6700 not a digit in any supported base. (Bug#8602)
6702 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6704 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6705 to match comment at start of function. This also removes a
6706 GCC warning about overflow in a 32+64-bit port.
6708 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6710 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6711 Reported by Stefan Monnier in
6712 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6713 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6714 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6716 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6717 (EMACS_UINTPTR): Likewise, with uintptr_t.
6719 * lisp.h: Prefer 64-bit EMACS_INT if available.
6720 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6721 on 32-bit hosts that have 64-bit int, so that they can access
6723 However, temporarily disable this change unless the temporary
6724 symbol WIDE_EMACS_INT is defined.
6726 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6728 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6729 This removes an assumption that EMACS_INT and long are the same
6730 width as pointers. The assumption is true for Emacs porting targets
6731 now, but we want to make other targets possible.
6732 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6733 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6734 In the rest of the code, change types of integers that hold casted
6735 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6736 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6737 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6738 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6739 No need to cast type when ORing.
6740 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6741 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6742 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6743 assume EMACS_INT is the same width as char *.
6744 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6745 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6746 Remove no-longer-needed casts.
6747 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6748 (xg_tool_bar_help_callback, xg_make_tool_item):
6749 Use EMACS_INTPTR to hold an integer
6750 that will be cast to void *; this can avoid a GCC warning
6751 if EMACS_INT is not the same width as void *.
6752 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6753 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6754 (current_message_1, set_message_1):
6755 Use a local to convert to proper width without a cast.
6756 * xmenu.c (dialog_selection_callback): Likewise.
6758 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6759 Also, don't assume VALBITS / RAND_BITS is less than 5,
6760 and don't rely on undefined behavior when shifting a 1 left into
6762 * lisp.h (get_random): Change signature to match.
6764 * lread.c (hash_string): Use size_t, not int, for hash computation.
6765 Normally we prefer signed values; but hashing is special, because
6766 it's better to use unsigned division on hash table sizes so that
6767 the remainder is nonnegative. Also, size_t is the natural width
6768 for hashing into memory. The previous code used 'int', which doesn't
6769 retain enough info to hash well into very large tables.
6770 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6772 * dbusbind.c: Don't possibly lose pointer info when converting.
6773 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6774 Use XPNTR rather than XHASH, so that the high-order bits of
6775 the pointer aren't lost when converting through void *.
6777 * eval.c (Fautoload): Don't double-shift a pointer.
6779 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6781 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6783 * gnutls.c (DEF_GNUTLS_FN):
6784 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6786 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6788 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6791 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6793 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6794 New version that can reserve upto 2GB of heap space.
6796 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6798 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6800 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6802 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6803 `gnutls_certificate_set_x509_key_file'.
6805 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6807 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6808 Update dependencies.
6810 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6812 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6813 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6814 Remove unused parameter `fildes'.
6815 * process.c (read_process_output, send_process): Don't pass it.
6817 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6819 Fix previous change: the library cache is defined in w32.c.
6820 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6821 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6823 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6825 Implement dynamic loading of GnuTLS on Windows.
6827 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6828 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6829 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6832 * gnutls.c (Qgnutls_dll): Define.
6833 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6834 (gnutls_*): Declare function pointers.
6835 (init_gnutls_functions): New function to initialize function pointers.
6836 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6837 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6838 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6839 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6840 (emacs_gnutls_write, emacs_gnutls_read)
6841 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6842 (Fgnutls_available_p): New function.
6843 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6844 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6845 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6847 * image.c: Include w32.h.
6848 (Vimage_type_cache): Delete.
6849 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6850 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6851 (w32_delayed_load): Move to w32.c.
6853 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6855 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6856 (w32_delayed_load): Move from image.c. When loading a library, record
6857 its filename in the :loaded-from property of the library id.
6858 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6859 Initialize and staticpro them.
6860 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6862 * process.c: Include lisp.h before w32.h, not after.
6863 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6864 instead of gnutls_record_check_pending.
6866 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6868 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6870 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6871 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6874 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6876 * xterm.c (x_set_frame_alpha): Do not set property on anything
6877 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6879 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6881 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6883 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6885 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6886 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6887 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6888 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6889 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6890 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6891 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6892 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6893 (Qgnutls_bootprop_callbacks_verify): Make static.
6895 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6897 * callproc.c: Indentation fixup.
6899 * sysdep.c (wait_for_termination_1): Make static.
6900 (wait_for_termination, interruptible_wait_for_termination):
6901 Move after wait_for_termination_1.
6903 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6905 * sysdep.c (interruptible_wait_for_termination): New function
6906 which is like wait_for_termination, but allows keyboard
6909 * callproc.c (Fcall_process): Add (:file "file") as an option for
6911 (Fcall_process_region): Ditto.
6913 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6915 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6916 rather than `XVECTOR (FOO)->size'.
6918 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6919 inttypes.h, as a gnulib replacement is used if it not available in
6922 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6924 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6925 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6926 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6928 * coding.c (coding_alloc_by_realloc): Error out if destination
6929 will grow beyond MOST_POSITIVE_FIXNUM.
6930 (decode_coding_emacs_mule): Abort if there isn't enough place in
6931 charbuf for the composition carryover bytes. Reserve an extra
6932 space for up to 2 characters produced in a loop.
6933 (decode_coding_iso_2022): Abort if there isn't enough place in
6934 charbuf for the composition carryover bytes.
6936 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6938 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6939 aborting when %lld or %lll format is passed.
6940 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6941 %llo or %llx format is passed. (Bug#8545)
6943 * window.c (window_scroll_line_based): Use a marker instead of
6944 simple variables to record original value of point. (Bug#7952)
6946 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6947 produced by %s or %c overflows available buffer space. (Bug#8545)
6949 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6951 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6952 (SIZE_MAX): Move defn after all includes, as they might #define it.
6954 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6956 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6958 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6960 * keyboard.c (Qdelayed_warnings_hook): Define.
6961 (command_loop_1): Run `delayed-warnings-hook'
6962 if Vdelayed_warnings_list is non-nil.
6963 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6964 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6966 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6968 * doprnt.c (doprnt): Don't return value smaller than the buffer
6969 size if the message was truncated. (Bug#8545).
6971 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6973 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6974 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6976 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6978 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6980 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6982 * makefile.w32-in: Update dependencies.
6984 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6986 Improve `doprnt' and its usage. (Bug#8545)
6987 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6988 `format_end'. Remove support for %l as a conversion specifier.
6989 Don't use xrealloc. Improve diagnostics when the %l size modifier
6990 is used. Update the commentary.
6992 * eval.c (verror): Simplify calculation of size_t.
6994 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6997 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6999 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7002 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7004 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7005 This makes this file independent of the recent pseudovector change.
7007 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7009 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7011 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7012 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7013 Remove unused local.
7014 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7016 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7017 GCC 4.6.0 optimizes based on type-based alias analysis.
7018 For example, if b is of type struct buffer * and v of type struct
7019 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7020 != &v->size, and therefore "v->size = 1; b->size = 2; return
7021 v->size;" must therefore return 1. This assumption is incorrect
7022 for Emacs, since it type-puns struct Lisp_Vector * with many other
7023 types. To fix this problem, this patch adds a new type struct
7024 vectorlike_header that documents the constraints on layout of vectors
7025 and pseudovectors, and helps optimizing compilers not get fooled
7026 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7027 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7028 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7030 (XSETPVECTYPE): Rewrite in terms of new macro.
7031 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7032 This is a bit clearer, and further avoids the possibility of
7033 undesirable aliasing.
7034 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7035 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7036 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7037 since Lisp_Subr is a special case (no "next" field).
7038 (ASIZE): Now uses header.size rather than size.
7039 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7040 to avoid the hassle of writing XVECTOR (foo)->header.size.
7041 (struct vectorlike_header): New type.
7042 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7043 object, to help avoid aliasing.
7044 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7045 (SUBRP): Likewise, since Lisp_Subr is a special case.
7046 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7047 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7048 (struct Lisp_Hash_Table): Combine first two members into a single
7049 struct vectorlike_header member. All uses of "size" and "next" members
7050 changed to be "header.size" and "header.next".
7051 * buffer.h (struct buffer): Likewise.
7052 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7053 * frame.h (struct frame): Likewise.
7054 * process.h (struct Lisp_Process): Likewise.
7055 * termhooks.h (struct terminal): Likewise.
7056 * window.c (struct save_window_data, struct saved_window): Likewise.
7057 * window.h (struct window): Likewise.
7058 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7059 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7060 * buffer.c (init_buffer_once): Likewise.
7061 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7063 * process.c (Fformat_network_address): Use local var for size,
7066 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7068 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7069 * data.c (atof): Remove decl; no longer used or needed.
7070 (digit_to_number): Move to lread.c.
7071 (Fstring_to_number): Use new string_to_number function, to be
7072 consistent with how the Lisp reader treats infinities and NaNs.
7073 Do not assume that floating-point numbers represent EMACS_INT
7074 without losing information; this is not true on most 64-bit hosts.
7075 Avoid double-rounding errors, by insisting on integers when
7076 parsing non-base-10 numbers, as the documentation specifies.
7077 * lisp.h (string_to_number): New decl, replacing ...
7078 (isfloat_string): Remove.
7079 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7080 (read1): Do not accept +. and -. as integers; this
7081 appears to have been a coding error. Similarly, do not accept
7082 strings like +-1e0 as floating point numbers. Do not report
7083 overflow for integer overflows unless the base is not 10 which
7084 means we have no simple and reliable way to continue.
7085 Break out the floating-point parsing into a new
7086 function string_to_number, so that Fstring_to_number parses
7087 floating point numbers consistently with the Lisp reader.
7088 (digit_to_number): Move here from data.c. Make it static inline.
7089 (E_CHAR, EXP_INT): Remove, replacing with ...
7090 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7091 (string_to_number): New function, replacing isfloat_string.
7092 This function checks for valid syntax and produces the resulting
7093 Lisp float number too. Rework it so that string-to-number
7094 no longer mishandles examples like "1.0e+". Use strtoumax,
7095 so that overflow for non-base-10 numbers is reported only when
7096 there's no portable and simple way to convert to floating point.
7098 * textprop.c (set_text_properties_1): Rewrite for clarity,
7099 and to avoid GCC warning about integer overflow.
7101 * intervals.h (struct interval): Use EMACS_INT for members
7102 where EMACS_UINT might cause problems. See
7103 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7104 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7105 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7107 (offset_intervals): Tell GCC not to worry about length overflow
7108 when negating a negative length.
7110 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7111 (overrun_check_free): Likewise.
7113 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7114 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7117 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7118 (gnutls_make_error): Rename local to avoid shadowing.
7119 (gnutls_emacs_global_deinit): ifdef out; not used.
7120 (Fgnutls_boot): Use const for pointer to readonly storage.
7121 Comment out unused local. Fix pointer signedness problems.
7123 * lread.c (openp): Don't stuff size_t into an 'int'.
7124 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7125 about possible signed overflow.
7127 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7128 (GDK_KEY_g): Don't define if already defined.
7129 (xg_prepare_tooltip): Avoid pointer signedness problem.
7130 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7132 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7133 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7135 * xfns.c (Fx_window_property): Simplify a bit,
7136 to make a bit faster and to avoid GCC 4.6.0 warning.
7137 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7139 * fns.c (internal_equal): Don't assume size_t fits in int.
7141 * alloc.c (compact_small_strings): Tighten assertion a little.
7143 Replace pEd with more-general pI, and fix some printf arg casts.
7144 * lisp.h (pI): New macro, generalizing old pEd macro to other
7145 conversion specifiers. For example, use "...%"pI"d..." rather
7146 than "...%"pEd"...".
7147 (pEd): Remove. All uses replaced with similar uses of pI.
7148 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7149 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7150 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7151 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7152 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7153 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7154 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7156 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7157 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7158 * print.c (safe_debug_print, print_object): Likewise.
7159 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7161 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7162 avoiding the 0 flag, which is not portable.
7163 * process.c (Fmake_network_process): Use pI to avoid cast.
7164 * region-cache.c (pp_cache): Likewise.
7165 * xdisp.c (decode_mode_spec): Likewise.
7166 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7167 behavior on 64-bit hosts with printf arg.
7168 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7169 (x_stop_queuing_selection_requests): Likewise.
7170 (x_get_window_property): Don't truncate byte count to an 'int'
7173 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7174 here, since it parses constructs like leading '-' and spaces,
7175 which are not wanted; and it overflows with large numbers.
7176 Instead, simply match F[0-9]+, which is what is wanted anyway.
7178 * alloc.c: Remove unportable assumptions about struct layout.
7179 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7180 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7181 (allocate_vectorlike, make_pure_vector): Use the new macros,
7182 plus offsetof, to remove unportable assumptions about struct layout.
7183 These assumptions hold on all porting targets that I know of, but
7184 they are not guaranteed, they're easy to remove, and removing them
7185 makes further changes easier.
7187 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7188 This doesn't fix a bug but makes the code clearer.
7189 (string_overrun_cookie): Now const. Use initializers that
7190 don't formally overflow signed char, to avoid warnings.
7191 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7192 can cause Emacs to crash when string overrun checking is enabled.
7193 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7194 multiple of sizeof (EMACS_INT); it need not be, if
7195 alignof(EMACS_INT) < sizeof (EMACS_INT).
7196 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7198 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7200 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7202 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7204 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7205 supposed to be handshaking. (Bug#8556)
7206 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7208 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7210 * lisp.h (Qdebug): List symbol.
7211 * eval.c (Qdebug): Restore global linkage.
7212 * keyboard.c (debug-on-event): New variable.
7213 (handle_user_signal): Break into debugger when debug-on-event
7214 matches the current signal symbol.
7216 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7218 * alloc.c (check_sblock, check_string_bytes)
7219 (check_string_free_list): Convert to standard C.
7221 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7223 * w32.c (emacs_gnutls_push): Fix typo.
7225 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7227 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7228 "cast to pointer from integer of different size".
7230 Improve doprnt and its use in verror. (Bug#8545)
7231 * doprnt.c (doprnt): Document the set of format control sequences
7232 supported by the function. Use SAFE_ALLOCA instead of always
7235 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7236 is one byte too soon. Don't use xrealloc; instead xfree and
7239 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7241 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7244 * gnutls.c: Renamed global_initialized to
7245 gnutls_global_initialized. Added internals for the
7246 :verify-hostname-error, :verify-error, and :verify-flags
7247 parameters of `gnutls-boot' and documented those parameters in the
7248 docstring. Start callback support.
7249 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7250 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7251 on error. Return error code.
7252 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7253 (emacs_gnutls_read): Likewise.
7254 (Fgnutls_boot): Return handshake error code.
7255 (emacs_gnutls_handle_error): New function.
7256 (wsaerror_to_errno): Likewise.
7258 * w32.h (emacs_gnutls_pull): Add prototype.
7259 (emacs_gnutls_push): Likewise.
7261 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7262 (emacs_gnutls_push): Likewise.
7264 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7266 * process.c (wait_reading_process_output): Check if GnuTLS
7267 buffered some data internally if no FDs are set for TLS
7270 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7271 (LIBS): Link to USER_LIBS.
7272 ($(BLD)/gnutls.$(0)): New target.
7274 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7276 * xdisp.c (handle_single_display_spec): Rename the
7277 display_replaced_before_p argument into display_replaced_p, to
7278 make it consistent with the commentary. Fix typos in the
7281 * textprop.c (syms_of_textprop): Remove dead code.
7282 (copy_text_properties): Delete obsolete commentary about an
7283 interface that was deleted long ago. Fix typos in the description
7286 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7287 to changes in oldXMenu/XMenu.h from 2011-04-16.
7288 <menu_help_message, prev_menu_help_message>: Constify.
7289 (IT_menu_make_room): menu->help_text is now `const char **';
7292 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7293 to changes in oldXMenu/XMenu.h from 2011-04-16.
7294 (struct XMenu): Declare `help_text' `const char **'.
7296 * xfaces.c <Qunspecified>: Make extern again.
7298 * syntax.c: Include sys/types.h before including regex.h, as
7301 * doc.c (get_doc_string): Improve the format passed to `error'.
7303 * doprnt.c (doprnt): Improve commentary.
7305 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7307 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7310 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7311 changes in globals.h immediately force recompilation.
7312 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7313 $(CURDIR)/s/ms-w32.h.
7314 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7316 * character.c (Fchar_direction): Function deleted.
7317 (syms_of_character): Don't defsubr it.
7318 <char-direction-table>: Deleted.
7320 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7322 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7323 * doprnt.c: Include limits.h.
7324 (SIZE_MAX): New macro.
7325 (doprnt): Return a size_t value. 2nd arg is now size_t.
7326 Many local variables are now size_t instead of int or unsigned.
7327 Improve overflow protection. Support `l' modifier for integer
7328 conversions. Support %l conversion. Don't assume an EMACS_INT
7329 argument for integer conversions and for %c.
7331 * lisp.h (doprnt): Restore prototype.
7333 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7336 * Makefile.in (base_obj): Add back doprnt.o.
7338 * deps.mk (doprnt.o): Add back prerequisites.
7339 (callint.o): Depend on character.h.
7341 * eval.c (internal_lisp_condition_case): Include the handler
7342 representation in the error message.
7343 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7344 when breaking from the loop.
7346 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7348 * callint.c (Fcall_interactively): When displaying error message
7349 about invalid control letter, pass the character's codepoint, not
7350 a pointer to its multibyte form. Improve display of the character
7351 in octal and display also its hex code.
7353 * character.c (char_string): Use %x to display the (unsigned)
7354 codepoint of an invalid character, to avoid displaying a bogus
7357 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7358 `error', not SYMBOL_NAME itself.
7360 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7361 character arguments to `error'.
7363 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7364 to `error' in error message about FINAL_CHAR argument. Make sure
7365 FINAL_CHAR is a character, and use %c when it is passed as
7366 argument to `error'.
7368 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7370 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7372 * w32.c: Include <time.h>.
7373 (sys_localtime): New function.
7375 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7377 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7379 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7381 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7383 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7386 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7388 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7389 gl_state.e_property when gl_state.object is Qt.
7391 * insdel.c (make_gap_larger): Remove limitation of buffer size
7394 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7396 * xdisp.c (lookup_glyphless_char_display)
7397 (produce_glyphless_glyph): Handle cons cell entry in
7398 glyphless-char-display.
7399 (Vglyphless_char_display): Document it.
7401 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7402 glyphless-char-display.
7404 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7406 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7408 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7410 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7411 definition for no-X builds.
7413 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7415 Static checks with GCC 4.6.0 and non-default toolkits.
7417 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7419 * process.c (keyboard_bit_set): Define only if SIGIO.
7420 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7421 (send_process): Repair possible setjmp clobbering.
7423 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7425 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7427 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7429 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7430 Define only if needed.
7432 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7433 by pacifying GCC about it. Maybe it's time to retire it?
7434 * xfaces.c (USG, __TIMEVAL__): Likewise.
7436 * dispextern.h (struct redisplay_interface): Rename param
7438 * termhooks.h (struct terminal): Likewise.
7439 * xterm.c (xembed_send_message): Likewise.
7441 * insdel.c (make_gap_smaller): Define only if
7442 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7444 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7447 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7448 so that we aren't warned about unused symbols.
7450 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7452 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7454 * xfns.c (x_real_positions): Mark locals as initialized.
7456 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7458 * xterm.c: Fix problems found by static analysis with other toolkits.
7459 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7460 (x_dispatch_event): Declare static if USE_GTK, and
7461 define if USE_GTK || USE_X_TOOLKIT.
7462 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7463 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7464 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7465 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7467 * xmenu.c (menu_help_callback): Pointer type fixes.
7468 Use const pointers when pointing at readonly data. Avoid pointer
7470 (FALSE): Remove unused macro.
7471 (update_frame_menubar): Remove unused decl.
7473 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7475 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7476 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7477 (single_menu_item): Rename local to avoid shadowing.
7479 * keyboard.c (make_lispy_event): Remove unused local var.
7481 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7482 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7484 * bitmaps: Change bitmaps from unsigned char back to the X11
7485 compatible char. Avoid the old compiler warnings about
7486 out-of-range initializers by using, for example, '\xab' rather
7489 * xgselect.c (xgselect_initialize): Check vs interface
7490 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7492 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7494 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7495 to read-only memory.
7497 * fns.c (vector): Remove; this old hack is no longer needed.
7499 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7501 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7503 * xrdb.c (x_load_resources): Omit unused local.
7505 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7506 (x_window): Rename locals to avoid shadowing.
7507 (USG): Use the kludged USG macro, to pacify gcc.
7509 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7510 (x_term_init): Remove local to avoid shadowing.
7512 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7514 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7515 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7517 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7519 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7521 Fix regex.c, syntax.c and friends for buffers > 2GB.
7522 * syntax.h (struct gl_state_s): Declare character position members
7525 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7527 * textprop.c (verify_interval_modification, interval_of):
7528 Declare arguments EMACS_INT.
7530 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7533 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7535 * indent.c (Fvertical_motion): Local variable it_start is now
7538 * regex.c (re_match, re_match_2, re_match_2_internal)
7539 (bcmp_translate, regcomp, regexec, print_double_string)
7540 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7541 (re_compile_pattern, re_exec): Declare arguments and local
7542 variables `size_t' and `ssize_t' and return values `regoff_t', as
7544 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7545 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7546 <compile_stack_type>: `size' and `avail' are now `size_t'.
7548 * regex.h <regoff_t>: Use ssize_t, not int.
7549 (re_search, re_search_2, re_match, re_match_2): Arguments that
7550 specify buffer/string position and length are now ssize_t and
7551 size_t. Return type is regoff_t.
7553 2011-04-16 Ben Key <bkey76@gmail.com>
7555 * nsfont.m: Fixed bugs in ns_get_family and
7556 ns_descriptor_to_entity that were caused by using free to
7557 deallocate memory blocks that were allocated by xmalloc (via
7558 xstrdup). This caused Emacs to crash when compiled with
7559 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7560 --enable-checking=xmallocoverrun). xfree is now used to
7561 deallocate these memory blocks.
7563 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7565 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7567 emacs_write: Accept and return EMACS_INT for sizes.
7568 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7570 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7571 Accept and return EMACS_INT.
7572 (emacs_gnutls_write): Return the number of bytes written on
7574 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7575 (emacs_read, emacs_write): Remove check for negative size, as the
7576 Emacs source code has been audited now.
7577 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7578 (emacs_read, emacs_write): Use it.
7579 * process.c (send_process): Adjust to the new signatures of
7580 emacs_write and emacs_gnutls_write. Do not attempt to store
7581 a byte offset into an 'int'; it might overflow.
7582 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7584 * sound.c: Don't assume sizes fit in 'int'.
7585 (struct sound_device.period_size, alsa_period_size):
7586 Return EMACS_INT, not int.
7587 (struct sound_device.write, vox_write, alsa_write):
7588 Accept EMACS_INT, not int.
7589 (wav_play, au_play): Use EMACS_INT to store sizes and to
7590 record read return values.
7592 2011-04-15 Ben Key <bkey76@gmail.com>
7594 * keyboard.c (Qundefined): Don't declare static since it is used
7596 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7597 static since they are used in nsfont.m.
7599 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7601 * process.c (Qprocessp): Don't declare static.
7602 * lisp.h (Qprocessp): Declare again.
7604 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7606 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7608 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7610 Improve C-level modularity by making more things 'static'.
7612 Don't publish debugger-only interfaces to other modules.
7613 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7614 (verify_bytepos, count_markers): Move decls to the only modules
7616 * region-cache.h (pp_cache): Likewise.
7617 * window.h (check_all_windows): Likewise.
7618 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7620 * sysdep.c (croak): Now static, if
7621 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7622 * syssignal.h (croak): Declare only if not static.
7624 * alloc.c (refill_memory_reserve): Now static if
7625 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7626 * lisp.h (refill_memory_reserve): Declare only if not static.
7628 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7629 Define only if USE_LUCID.
7631 * xrdb.c (x_customization_string, x_rm_string): Now static.
7633 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7634 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7636 * xdisp.c (draw_row_with_mouse_face): Now static.
7637 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7639 * window.h (check_all_windows): Mark externally visible.
7641 * window.c (window_deletion_count): Now static.
7643 * undo.c: Make symbols static if they're not exported.
7644 (last_undo_buffer, last_boundary_position, pending_boundary):
7647 * textprop.c (interval_insert_behind_hooks): Now static.
7648 (interval_insert_in_front_hooks): Likewise.
7650 * term.c: Make symbols static if they're not exported.
7651 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7652 (max_frame_lines, tty_set_terminal_modes):
7653 (tty_reset_terminal_modes, tty_turn_off_highlight):
7654 (get_tty_terminal): Now static.
7655 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7656 * termhooks.h (term_mouse_moveto): Do not declare if
7658 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7659 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7661 * sysdep.c: Make symbols static if they're not exported.
7662 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7664 (sigprocmask_set, full_mask): Remove; unused.
7665 (wait_debugging): Mark as visible.
7666 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7667 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7669 * syntax.c (syntax_temp): Define only if !__GNUC__.
7671 * sound.c (current_sound_device, current_sound): Now static.
7673 * search.c (searchbufs, searchbuf_head): Now static.
7675 * scroll.c (scroll_cost): Remove; unused.
7676 * dispextern.h (scroll_cost): Remove decl.
7678 * region-cache.h (pp_cache): Mark as externally visible.
7680 * process.c: Make symbols static if they're not exported.
7681 (process_tick, update_tick, create_process, chan_process):
7682 (Vprocess_alist, proc_buffered_char, datagram_access):
7683 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7684 (deactivate_process): Mark defn as static, as well as decl.
7685 * lisp.h (create_process): Remove decl.
7686 * process.h (chan_process, Vprocess_alist): Remove decls.
7688 * print.c: Make symbols static if they're not exported.
7689 (print_depth, new_backquote_output, being_printed, print_buffer):
7690 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7691 (print_interval, print_number_index, initial_stderr_stream):
7693 * lisp.h (Fprinc): Remove decl.
7694 (debug_output_compilation_hack): Mark as externally visible.
7696 * sysdep.c (croak): Move decl from here to syssignal.h.
7697 * syssignal.h (croak): Put it here, so the API can be checked when
7698 'croak' is called from dissociate_if_controlling_tty.
7700 * minibuf.c: Make symbols static if they're not exported.
7701 (minibuf_save_list, choose_minibuf_frame): Now static.
7702 * lisp.h (choose_minibuf_frame): Remove decl.
7704 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7706 * lread.c: Make symbols static if they're not exported.
7707 (read_objects, initial_obarray, oblookup_last_bucket_number):
7709 (make_symbol): Remove; unused.
7710 * lisp.h (initial_obarray, make_symbol): Remove decls.
7712 * keyboard.c: Make symbols static if they're not exported.
7713 (single_kboard, recent_keys_index, total_keys, recent_keys):
7714 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7715 (this_single_command_key_start, echoing, last_auto_save):
7716 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7717 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7718 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7719 (Vlispy_mouse_stem, double_click_count):
7721 (force_auto_save_soon): Define only if SIGDANGER.
7722 (ignore_mouse_drag_p): Now static if
7723 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7724 (print_help): Remove; unused.
7725 (stop_character, last_timer_event): Mark as externally visible.
7726 * keyboard.h (ignore_mouse_drag_p): Declare only if
7727 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7728 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7729 * lisp.h (echoing): Remove decl.
7730 (force_auto_save_soon): Declare only if SIGDANGER.
7731 * xdisp.c (redisplay_window): Simplify code, to make it more
7732 obvious that ignore_mouse_drag_p is not accessed if !defined
7733 USE_GTK && !defined HAVE_NS.
7735 * intervals.c: Make symbols static if they're not exported.
7736 (merge_properties_sticky, merge_interval_right, delete_interval):
7738 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7740 * insdel.c: Make symbols static if they're not exported.
7741 However, leave prepare_to_modify_buffer alone. It's never
7742 called from outside this function, but that appears to be a bug.
7743 (combine_after_change_list, combine_after_change_buffer):
7744 (adjust_after_replace, signal_before_change): Now static.
7745 (adjust_after_replace_noundo): Remove; unused.
7746 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7747 (signal_before_change): Remove decls.
7749 * indent.c (val_compute_motion, val_vmotion): Now static.
7751 * image.c: Make symbols static if they're not exported.
7752 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7754 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7755 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7757 * fringe.c (standard_bitmaps): Now static.
7758 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7760 * frame.c: Make symbols static if they're not exported.
7761 (x_report_frame_params, make_terminal_frame): Now static.
7762 (get_frame_param): Now static, unless HAVE_NS.
7763 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7764 (x_get_resource_string): Remove; not used.
7765 * frame.h (make_terminal_frame, x_report_frame_params):
7766 (x_get_resource_string); Remove decls.
7767 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7768 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7770 * font.c, fontset.c: Make symbols static if they're not exported.
7771 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7772 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7773 * font.c (font_close_object): Now static.
7774 * font.h (font_close_object): Remove.
7775 * fontset.c (FONTSET_OBJLIST): Remove.
7776 (free_realized_fontset) #if-0 the body, which does nothing.
7777 (face_suitable_for_char_p): #if-0, as it's never called.
7778 * fontset.h (face_suitable_for_char_p): Remove decl.
7779 * xfaces.c (face_at_string_position):
7780 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7781 since 0 is always ASCII.
7783 * fns.c (weak_hash_tables): Now static.
7785 * fileio.c: Make symbols static if they're not exported.
7786 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7787 (Vwrite_region_annotation_buffers): Now static.
7789 * eval.c: Make symbols static if they're not exported.
7790 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7791 * lisp.h (backtrace_list): Remove decl.
7793 * emacs.c: Make symbols static if they're not exported.
7794 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7795 (fatal_error_code, fatal_error_signal_hook, standard_args):
7797 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7798 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7799 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7800 * lisp.h (fatal_error_signal_hook): Remove decl.
7801 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7803 * editfns.c: Move a (normally-unused) function to its only use.
7804 * editfns.c, lisp.h (get_operating_system_release): Remove.
7805 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7806 worth the hassle of breaking this out.
7808 * xterm.c: Make symbols static if they're not exported.
7809 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7810 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7811 (x_destroy_window, x_delete_display):
7813 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7814 (x_mouse_leave): Remove; unused.
7815 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7816 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7817 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7819 (x_mouse_leave): Declare only if WINDOWSNT.
7820 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7821 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7824 * ftxfont.c: Make symbols static if they're not exported.
7825 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7827 * font.h (ftxfont_driver): Likewise.
7829 * xfns.c: Make symbols static if they're not exported.
7830 (x_last_font_name, x_display_info_for_name):
7831 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7832 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7833 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7834 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7835 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7836 (last_show_tip_args): Now static.
7837 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7838 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7839 (x_screen_planes): Remove; unused.
7840 * dispextern.h (x_screen_planes): Remove decl.
7842 * dispnew.c: Make symbols static if they're not exported.
7843 * dispextern.h (redraw_garbaged_frames, scrolling):
7844 (increment_row_positions): Remove.
7845 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7846 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7848 (redraw_garbaged_frames): Remove; unused.
7850 * xfaces.c: Make symbols static if they're not exported.
7851 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7853 * xterm.h (defined_color): Remove decls.
7854 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7855 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7856 (menu_face_changed_default, defined_color, free_realized_face):
7857 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7858 (ascii_face_of_lisp_face): Remove; unused.
7860 * xdisp.c: Make symbols static if they're not exported.
7861 * dispextern.h (scratch_glyph_row, window_box_edges):
7862 (glyph_to_pixel_coords, set_cursor_from_row):
7863 (get_next_display_element, set_iterator_to_next):
7864 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7865 (show_mouse_face): Remove decls
7866 * frame.h (message_buf_print): Likewise.
7867 * lisp.h (pop_message, set_message, check_point_in_composition):
7869 * xterm.h (set_vertical_scroll_bar): Likewise.
7870 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7871 (message_buf_print, scratch_glyph_row, displayed_buffer):
7872 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7873 (get_next_display_element, show_mouse_face, window_box_edges):
7874 (frame_to_window_pixel_xy, check_point_in_composition):
7875 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7876 (glyph_to_pixel_coords): Remove; unused.
7878 * dired.c (file_name_completion): Now static.
7880 * dbusbind.c (xd_in_read_queued_messages): Now static.
7882 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7883 * data.c (circular_list_error): Remove.
7885 * commands.h (last_point_position, last_point_position_buffer):
7886 (last_point_position_window): Remove decls.
7887 * keyboard.c: Make these variables static.
7889 * coding.h (coding, code_convert_region, encode_coding_gap):
7891 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7892 (iso_code_class, detect_coding, code_convert_region): Now static.
7893 (encode_coding_gap): Remove; unused.
7895 * chartab.c (chartab_chars, chartab_bits): Now static.
7897 * charset.h (charset_iso_8859_1): Remove decl.
7898 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7901 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7902 * ccl.c (Vccl_program_table): Now static.
7903 (check_ccl_update): Remove; unused.
7905 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7906 * category.h: ... from here.
7907 * category.c (check_category_table, set_category_set): Now static.
7909 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7910 * lisp.h: Remove these decls.
7912 * buffer.c (buffer_count): Remove unused var.
7914 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7915 so that it's not optimized away.
7916 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7917 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7918 exported only to the debugger.
7920 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7921 * atimer.h (run_all_atimers): Remove; not exported.
7923 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7924 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7925 was inaccessible from Lisp.
7926 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7927 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7929 alloc.c: Import and export fewer symbols, and remove unused items.
7930 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7932 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7933 it's not optimized away by whole-program optimization.
7934 (message_enable_multibyte, free_misc): Remove.
7935 (catchlist, handlerlist, mark_backtrace):
7936 Declare only if BYTE_MARK_STACK.
7937 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7938 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7939 (message_enable_multibyte): Remove decl.
7940 (free_misc, interval_free_list, float_block, float_block_index):
7941 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7942 (cons_free_list, last_marked_index):
7944 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7945 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7946 (mark_backtrace): Define only if BYTE_MARK_STACK.
7947 * xdisp.c (message_enable_multibyte): Now static.
7949 Declare Lisp_Object Q* variables to be 'static' if not exported.
7950 This makes it easier for human readers (and static analyzers)
7951 to see whether these variables are used from other modules.
7952 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7953 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7954 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7955 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7956 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7957 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7958 * xmenu.c, xselect.c:
7959 Declare Q* vars static if they are not used in other modules.
7960 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7961 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7962 Remove decls of unexported vars.
7963 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7965 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7967 Make Emacs functions such as Fatom 'static' by default.
7968 This makes it easier for human readers (and static analyzers)
7969 to see whether these functions can be called from other modules.
7970 DEFUN now defines a static function. To make the function external
7971 so that it can be used in other C modules, use the new macro DEFUE.
7972 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7973 (Finit_image_library):
7974 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7975 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7976 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7977 Remove decls, since these functions are now static.
7978 (Funintern, Fget_internal_run_time): New decls, since these functions
7979 were already external.
7981 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7982 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7983 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7984 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7985 * keyboard.c, keymap.c, lread.c:
7986 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7987 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7988 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7989 Mark functions with DEFUE instead of DEFUN,
7990 if they are used in other modules.
7991 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7992 decls for now-static functions.
7993 * buffer.h (Fdelete_overlay): Remove decl.
7994 * callproc.c (Fgetenv_internal): Mark as internal.
7995 * composite.c (Fremove_list_of_text_properties): Remove decl.
7996 (Fcomposition_get_gstring): New forward static decl.
7997 * composite.h (Fcomposite_get_gstring): Remove decl.
7998 * dired.c (Ffile_attributes): New forward static decl.
7999 * doc.c (Fdocumntation_property): New forward static decl.
8000 * eval.c (Ffetch_bytecode): New forward static decl.
8001 (Funintern): Remove extern decl; now in .h file where it belongs.
8002 * fileio.c (Fmake_symbolic_link): New forward static decl.
8003 * image.c (Finit_image_library): New forward static decl.
8004 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8005 * intervals.h (Fprevious_property_change):
8006 (Fremove_list_of_text_properties): Remove decls.
8007 * keyboard.c (Fthis_command_keys): Remove decl.
8008 (Fcommand_execute): New forward static decl.
8009 * keymap.c (Flookup_key): New forward static decl.
8010 (Fcopy_keymap): Now static.
8011 * keymap.h (Flookup_key): Remove decl.
8012 * process.c (Fget_process): New forward static decl.
8013 (Fprocess_datagram_address): Mark as internal.
8014 * syntax.c (Fsyntax_table_p): New forward static decl.
8015 (skip_chars): Remove duplicate decl.
8016 * textprop.c (Fprevious_property_change): New forward static decl.
8017 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8019 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8020 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8022 * editfns.c (Fformat): Remove unreachable code.
8024 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8026 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8029 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8031 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8032 when at ZV. (Bug#8487)
8034 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8036 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8038 * keyboard.c (parse_tool_bar_item): Likewise.
8039 * sound.c (sound_cleanup, alsa_close): Likewise.
8040 * termcap.c (tgetent): Likewise.
8041 * xfns.c (x_default_font_parameter): Likewise.
8042 * xsettings.c (read_and_apply_settings): Likewise.
8044 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8045 (overrun_check_free): Protoize.
8047 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8049 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8050 since callers should never pass a negative size.
8051 Change the signature to match that of plain 'read' and 'write'; see
8052 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8053 * lisp.h: Update prototypes of emacs_write and emacs_read.
8055 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8057 * xdisp.c (redisplay_window): Don't try to determine the character
8058 position of the scroll margin if the window start point w->startp
8059 is outside the buffer's accessible region. (Bug#8468)
8061 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8063 Fix write-region and its subroutines for buffers > 2GB.
8064 * fileio.c (a_write, e_write): Modify declaration of arguments and
8065 local variables to support buffers larger than 2GB.
8066 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8068 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8069 argument, local variables, and return value.
8071 * lisp.h: Update prototypes of emacs_write and emacs_read.
8073 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8075 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8077 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8079 Fix more problems found by GCC 4.6.0's static checks.
8081 * xdisp.c (vmessage): Use a better test for character truncation.
8083 * charset.c (load_charset_map): <, not <=, for optimization,
8084 and to avoid potential problems with integer overflow.
8085 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8086 * casetab.c (set_identity, shuffle): Likewise.
8087 * editfns.c (Fformat): Likewise.
8088 * syntax.c (skip_chars): Likewise.
8090 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8091 This also lets GCC 4.6.0 generate slightly better loop code.
8093 * callint.c (Fcall_interactively): <, not <=, for optimization.
8094 (Fcall_interactively): Count the number of arguments produced,
8095 not the number of arguments given. This is simpler and lets GCC
8096 4.6.0 generate slightly better code.
8098 * ftfont.c: Distingish more carefully between FcChar8 and char.
8099 The previous code passed unsigned char * to a functions like
8100 strlen and xstrcasecmp that expect char *, which does not
8101 conform to the C standard.
8102 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8103 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8104 char * when the C standard requires it.
8106 * keyboard.c (read_char): Remove unused var.
8108 * eval.c: Port to Windows vsnprintf (Bug#8435).
8110 (SIZE_MAX): Define if the headers do not.
8111 (verror): Do not give up if vsnprintf returns a negative count.
8112 Instead, grow the buffer. This ports to Windows vsnprintf, which
8113 does not conform to C99. Problem reported by Eli Zaretskii.
8114 Also, simplify the allocation scheme, by avoiding the need for
8115 calling realloc, and removing the ALLOCATED variable.
8117 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8119 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8120 But keep the doprint source code for now, as we might revamp it
8121 and use it again (Bug#8435).
8122 * lisp.h (doprnt): Remove.
8123 * Makefile.in (base_obj): Remove doprnt.o.
8124 * deps.mk (doprnt.o): Remove.
8126 error: Print 32- and 64-bit integers portably (Bug#8435).
8127 Without this change, on typical 64-bit hosts error ("...%d...", N)
8128 was used to print both 32- and 64-bit integers N, which relied on
8130 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8131 * lisp.h (error, verror): Mark as printf-like functions.
8132 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8133 Report overflow in size calculations when allocating printf buffer.
8134 Do not truncate output string at its first null byte.
8135 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8136 Truncate the output at a character boundary, since vsnprintf does not
8138 * charset.c (check_iso_charset_parameter): Convert internal
8139 character to string before calling 'error', since %c now has the
8141 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8142 overflow when computing char to be passed to 'error'. Do not
8143 pass Lisp_Object to 'error'; pass the integer instead.
8144 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8145 formatted with plain %d.
8147 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8149 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8151 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8153 * xterm.c (x_catch_errors): Remove duplicate declaration.
8155 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8157 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8159 2011-04-10 Jim Meyering <meyering@redhat.com>
8161 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8162 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8163 return ssize_t not "int", and use size_t as the buffer length.
8164 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8165 * gnutls.h: Update declarations.
8166 * process.c (read_process_output): Use ssize_t, to match.
8167 (send_process): Likewise.
8169 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8171 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8173 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8175 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8176 Use unsigned char, to match FcChar8 type definition.
8178 * xterm.c (handle_one_xevent):
8179 * xmenu.c (create_and_show_popup_menu):
8180 * xselect.c (x_decline_selection_request)
8181 (x_reply_selection_request): Avoid type-punned deref of X events.
8183 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8185 Fix some uses of `int' instead of EMACS_INT.
8186 * search.c (string_match_1, fast_string_match)
8187 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8188 (scan_buffer, find_next_newline_no_quit)
8189 (find_before_next_newline, search_command, Freplace_match)
8190 (Fmatch_data): Make some `int' variables be EMACS_INT.
8192 * xdisp.c (display_count_lines): 3rd argument and return value now
8193 EMACS_INT. All callers changed.
8194 (pint2hrstr): Last argument is now EMACS_INT.
8196 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8197 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8198 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8199 (decode_coding_utf_16, decode_coding_emacs_mule)
8200 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8201 (decode_coding_ccl, decode_coding_charset)
8202 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8203 (decode_coding_iso_2022, decode_coding_emacs_mule)
8204 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8205 <char_offset, last_offset>: Declare EMACS_INT.
8206 (encode_coding_utf_8, encode_coding_utf_16)
8207 (encode_coding_emacs_mule, encode_invocation_designation)
8208 (encode_designation_at_bol, encode_coding_iso_2022)
8209 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8210 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8212 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8213 (encode_invocation_designation): Last argument P_NCHARS is now
8215 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8216 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8218 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8221 * ccl.c (Fccl_execute_on_string): Declare some variables
8224 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8226 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8228 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8230 * process.c (Fformat_network_address): Doc fix.
8232 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8234 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8236 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8238 * keyboard.c (read_char): Call Lisp function help-form-show,
8239 instead of using internal_with_output_to_temp_buffer.
8240 (Qhelp_form_show): New var.
8241 (syms_of_keyboard): Use DEFSYM macro.
8243 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8245 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8247 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8249 * process.c (Flist_processes): Remove to Lisp.
8250 (list_processes_1): Delete.
8252 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8254 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8256 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8258 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8260 Fix more problems found by GCC 4.6.0's static checks.
8262 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8264 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8266 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8268 * xdisp.c (vmessage): Mark as a printf-like function.
8270 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8272 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8274 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8275 printf-like functions.
8276 (tiff_load): Add casts to remove these marks before passing them
8277 to system-supplied API.
8279 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8281 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8282 This avoids several warnings with gcc -Wstrict-overflow.
8283 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8284 directly, rather than having caller test rule sign. This avoids
8285 some unnecessary tests.
8286 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8287 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8288 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8290 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8291 (xfont_open): Avoid unnecessary tests.
8293 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8295 * composite.h, composite.c (composition_gstring_put_cache):
8296 Use EMACS_INT, not int, for length.
8298 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8299 breaking out part of COMPOSITION_DECODE_RULE.
8300 (COMPOSITION_DECODE_RULE): Use it.
8301 * composite.c (get_composition_id): Remove unused local vars,
8302 by using the new macro.
8304 * textprop.c (set_text_properties_1): Change while to do-while,
8305 since the condition is always true at first.
8307 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8308 (interval_deletion_adjustment): Return unsigned value.
8311 * process.c (list_processes_1, create_pty, read_process_output):
8312 (exec_sentinel): Remove vars that were set but not used.
8313 (create_pty): Remove unnecessary "volatile"s.
8314 (Fnetwork_interface_info): Avoid possibility of int overflow.
8315 (read_process_output): Do adaptive read buffering even if carryover.
8316 (read_process_output): Simplify nbytes computation if buffered.
8318 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8320 * syntax.c (scan_words): Remove var that was set but not used.
8321 (update_syntax_table): Use unsigned instead of int.
8323 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8324 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8325 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8327 * print.c (print_error_message): Avoid int overflow.
8329 * font.c (font_list_entities): Redo for clarity,
8330 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8332 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8333 (font_score): Avoid potential overflow in diff calculation.
8335 * fns.c (substring_both): Remove var that is set but not used.
8336 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8338 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8340 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8341 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8342 can always succeed if overflow has undefined behavior.
8344 * search.c (boyer_moore, wordify): Remove vars set but not used.
8345 (wordify): Omit three unnecessary tests.
8347 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8348 All callers changed. This avoids the need for an unused var.
8350 * casefiddle.c (casify_region): Remove var that is set but not used.
8352 * dired.c (file_name_completion): Remove var that is set but not used.
8354 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8356 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8357 (Finsert_file_contents): Remove unnecessary code checking fd.
8359 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8360 Check for integer overflow on size calculations.
8362 * buffer.c (Fprevious_overlay_change): Remove var that is set
8365 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8366 Remove vars that are set but not used.
8367 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8368 (timer_check_2): Mark vars as initialized.
8370 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8372 * image.c (lookup_image): Remove var that is set but not used.
8373 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8375 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8376 that are set but not used.
8378 * xfns.c (make_invisible_cursor): Don't return garbage
8379 if XCreateBitmapFromData fails (Bug#8410).
8381 * xselect.c (x_get_local_selection, x_handle_property_notify):
8382 Remove vars that are set but not used.
8384 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8385 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8387 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8388 Remove var that is set but not used.
8389 (scroll_bar_windows_size): Now size_t, not int.
8390 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8393 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8394 (map_tty_color) [!defined MSDOS]: Likewise.
8396 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8398 * coding.c: Remove vars that are set but not used.
8399 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8400 All callers changed.
8401 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8402 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8403 (decode_coding_charset): Remove vars that are set but not used.
8405 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8406 that is set but not used.
8408 * print.c (print_object): Remove var that is set but not used.
8410 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8411 The gnulib version avoids calling malloc in the usual case,
8412 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8413 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8414 * filelock.c (current_lock_owner): Likewise.
8415 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8416 * sysdep.c: Include allocator.h, careadlinkat.h.
8417 (emacs_no_realloc_allocator): New static constant.
8418 (emacs_readlink): New function.
8419 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8420 ../lib/careadlinkat.h.
8422 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8424 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8425 first non-nil return value).
8427 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8429 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8430 if not defined (Bug#8403).
8432 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8434 * xdisp.c (display_count_lines): Remove parameter `start',
8435 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8436 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8437 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8438 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8439 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8440 and thereabouts. All callers changed.
8441 (get_per_char_metric): Remove parameter `f', unused since
8442 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8444 2011-04-02 Jim Meyering <meyering@redhat.com>
8446 do not dereference NULL upon failed strdup
8447 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8448 (ns_get_family): Likewise.
8450 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8452 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8454 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8456 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8459 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8461 Add lexical binding.
8463 * window.c (Ftemp_output_buffer_show): New fun.
8464 (Fsave_window_excursion):
8465 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8467 * lread.c (lisp_file_lexically_bound_p): New function.
8468 (Fload): Bind Qlexical_binding.
8469 (readevalloop): Remove `evalfun' arg.
8470 Bind Qinternal_interpreter_environment.
8471 (Feval_buffer): Bind Qlexical_binding.
8472 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8474 (syms_of_lread): Declare `lexical-binding'.
8476 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8478 * keyboard.c (eval_dyn): New fun.
8479 (menu_item_eval_property): Use it.
8481 * image.c (parse_image_spec): Use Ffunctionp.
8483 * fns.c (concat, mapcar1): Accept byte-code-functions.
8485 * eval.c (Fsetq): Handle lexical vars.
8486 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8487 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8488 (FletX, Flet): Obey lexical binding.
8489 (Fcommandp): Handle closures.
8490 (Feval): New `lexical' arg.
8491 (eval_sub): New function extracted from Feval. Use it almost
8492 everywhere where Feval was used. Look up vars in lexical env.
8494 (Ffunctionp): Move from subr.el.
8495 (Ffuncall): Handle closures.
8496 (apply_lambda): Remove `eval_flags'.
8497 (funcall_lambda): Handle closures and new byte-code-functions.
8498 (Fspecial_variable_p): New function.
8499 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8500 but without exporting it to Lisp.
8502 * doc.c (Fdocumentation, store_function_docstring):
8503 * data.c (Finteractive_form): Handle closures.
8505 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8508 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8510 (exec_byte_code): New function extracted from Fbyte_code to handle new
8511 calling convention for byte-code-functions. Add new byte-codes.
8513 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8515 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8517 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8519 * xdisp.c (redisplay_internal): Fix prototype.
8521 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8523 * xdisp.c (SCROLL_LIMIT): New macro.
8524 (try_scrolling): Use it when setting scroll_limit.
8525 Limit scrolling to 100 screen lines.
8526 (redisplay_window): Even when falling back on "recentering",
8527 position point in the window according to scroll-conservatively,
8528 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8530 (try_scrolling): When point is above the window, allow searching
8531 as far as scroll_max, or one screenful, to compute vertical
8532 distance from PT to the scroll margin position. This prevents
8533 try_scrolling from unnecessarily failing when
8534 scroll-conservatively is set to a value slightly larger than the
8535 window height. Clean up the case of PT below the margin at bottom
8536 of window: scroll_max can no longer be INT_MAX. When aggressive
8537 scrolling is in use, don't let point enter the opposite scroll
8538 margin as result of the scroll.
8539 (syms_of_xdisp) <scroll-conservatively>: Document the
8540 threshold of 100 lines for never-recentering scrolling.
8542 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8544 * dispextern.h (move_it_by_lines):
8545 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8546 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8547 (message_log_check_duplicate): Remove parameters `prev_bol' and
8548 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8549 (redisplay_internal): Remove parameter `preserve_echo_area',
8550 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8552 * indent.c (Fvertical_motion):
8553 * window.c (window_scroll_pixel_based, Frecenter):
8554 Don't pass `need_y_p' to `move_it_by_lines'.
8556 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8558 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8559 steal a few bits to be more compact.
8560 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8561 Remove unneeded casts.
8563 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8565 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8567 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8568 binding" message (bug#7967).
8570 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8572 Fix more problems found by GCC 4.6.0's static checks.
8574 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8575 Remove unused local var.
8577 * editfns.c (Fmessage_box): Remove unused local var.
8579 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8580 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8581 Omit unused local vars.
8582 * window.c (shrink_windows): Omit unused local var.
8583 * menu.c (digest_single_submenu): Omit unused local var.
8584 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8585 Omit unused local var.
8587 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8588 Don't assume string length fits in int.
8589 (keyremap_step, read_key_sequence): Use size_t for sizes.
8590 (read_key_sequence): Don't check last_real_key_start redundantly.
8592 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8593 instead of alloca (Bug#8344).
8595 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8596 (Fbacktrace_frame): Don't assume nframes fits in int.
8598 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8600 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8603 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8605 * cm.c (calccost): Turn while-do into do-while, for clarity.
8607 * keyboard.c (syms_of_keyboard): Use the same style as later
8608 in this function when indexing through an array. This also
8609 works around GCC bug 48267.
8611 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8613 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8615 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8616 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8618 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8619 This avoids undefined behavior on integer overflow, and is a bit
8620 more convenient anyway since it is compared to a size_t variable.
8622 Variadic C functions now count arguments with size_t, not int.
8623 This avoids an unnecessary limitation on 64-bit machines, which
8624 caused (substring ...) to crash on large vectors (Bug#8344).
8625 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8626 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8627 All variadic functions and their callers changed accordingly.
8628 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8629 * data.c (arith_driver, float_arith_driver): Likewise.
8630 * editfns.c (general_insert_function): Likewise.
8631 * eval.c (struct backtrace.nargs, interactive_p)
8632 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8633 (funcall_lambda, mark_backtrace): Likewise.
8634 * fns.c (concat): Likewise.
8635 * frame.c (x_set_frame_parameters): Likewise.
8636 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8637 0 if not found, not -1. All callers changed.
8639 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8640 (stack_copy_size): Now size_t, not int.
8641 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8643 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8645 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8646 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8647 All callers changed.
8649 * lisp.h (multibyte_char_to_unibyte):
8650 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8651 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8652 * character.h (CHAR_TO_BYTE8):
8653 * cmds.c (internal_self_insert):
8654 * editfns.c (general_insert_function):
8655 * keymap.c (push_key_description):
8656 * search.c (Freplace_match):
8657 * xdisp.c (message_dolog, set_message_1): All callers changed.
8659 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8661 * keyboard.c (safe_run_hook_funcall): New function.
8662 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8663 don't set the hook to nil, but remove the offending function instead.
8664 (Qcommand_hook_internal): Remove, unused.
8665 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8666 Vcommand_hook_internal.
8668 * eval.c (enum run_hooks_condition): Remove.
8669 (funcall_nil, funcall_not): New functions.
8670 (run_hook_with_args): Call each function through a `funcall' argument.
8671 Remove `cond' argument, now redundant.
8672 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8673 (Frun_hook_with_args_until_failure): Adjust accordingly.
8674 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8676 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8678 * dispextern.h (string_buffer_position): Remove declaration.
8680 * print.c (strout): Remove parameter `multibyte', unused since
8681 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8683 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8684 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8685 All callers changed.
8687 * w32.c (_wsa_errlist): Use braces for struct initializers.
8689 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8690 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8691 All callers changed.
8692 (string_buffer_position): Likewise. Also, make static (it's never
8693 used outside xdisp.c).
8694 (cursor_row_p): Remove parameter `w', unused since
8695 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8696 (decode_mode_spec): Remove parameter `precision', introduced during
8697 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8698 All callers changed.
8700 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8702 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8704 2011-03-27 Anders Lindgren <andlind@gmail.com>
8706 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8707 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8708 (ns_update_auto_hide_menu_bar): New functions.
8709 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8710 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8711 ns_constrain_all_frames.
8712 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8713 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8715 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8717 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8719 2011-03-27 Glenn Morris <rgm@gnu.org>
8721 * syssignal.h: Replace RETSIGTYPE with void.
8722 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8723 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8724 Replace SIGTYPE with void everywhere.
8725 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8726 * s/template.h (SIGTYPE): Remove commented out definition.
8728 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8730 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8731 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8733 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8735 * w32.c (read_unc_volume): Use parameter `henum', instead of
8736 global variable `wget_enum_handle'.
8738 * keymap.c (describe_vector): Remove parameters `indices' and
8739 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8740 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8742 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8744 * keyboard.c (timer_check): Remove parameter `do_it_now',
8745 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8746 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8747 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8749 * keyboard.c (read_char):
8750 * w32menu.c (w32_menu_display_help):
8751 * xmenu.c (show_help_event, menu_help_callback):
8752 Adjust calls to `show_help_echo'.
8754 * gtkutil.c (xg_maybe_add_timer):
8755 * keyboard.c (readable_events):
8756 * process.c (wait_reading_process_output):
8757 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8759 * insdel.c (adjust_markers_gap_motion):
8760 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8761 (gap_left, gap_right): Don't call it.
8763 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8765 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8766 incurred during fontification.
8768 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8770 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8771 (DEFVAR_PER_BUFFER): Don't pass it.
8773 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8774 (scrolling_window): Don't pass it.
8776 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8778 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8780 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8782 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8783 of variables specific to SELinux and computation of `encoded_absname'.
8785 * image.c (XPutPixel): Remove unused variable `height'.
8787 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8789 * unexw32.c (get_section_info): Remove unused variable `section'.
8791 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8792 (system_process_attributes): Remove unused variable `sess'.
8793 (sys_read): Remove unused variable `err'.
8795 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8796 (w32_wnd_proc): Remove unused variable `isdead'.
8797 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8798 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8799 (x_create_tip_frame): Remove unused variable `tem'.
8801 * w32inevt.c (w32_console_read_socket):
8802 Remove unused variable `no_events'.
8804 * w32term.c (x_draw_composite_glyph_string_foreground):
8805 Remove unused variable `width'.
8807 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8809 * w32term.c (x_set_glyph_string_clipping):
8810 Don't pass uninitialized region to CombineRgn.
8812 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8814 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8815 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8816 (Fx_close_connection): Remove unused variable `i'.
8818 * w32font.c (w32font_draw): Return number of glyphs.
8819 (w32font_open_internal): Remove unused variable `i'.
8820 (w32font_driver): Add missing initializer.
8822 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8823 (fill_in_menu): Remove unused variable `items_added'.
8825 * w32term.c (last_mouse_press_frame): Remove static global variable.
8826 (w32_clip_to_row): Remove unused variable `f'.
8827 (x_delete_terminal): Remove unused variable `i'.
8829 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8830 (NOTHING): Remove unused static global variable.
8831 (uniscribe_check_otf): Remove unused variable `table'.
8832 (uniscribe_font_driver): Add missing initializers.
8834 2011-03-23 Julien Danjou <julien@danjou.info>
8836 * term.c (Fsuspend_tty, Fresume_tty):
8837 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8838 * window.c (temp_output_buffer_show):
8839 * insdel.c (signal_before_change):
8840 * frame.c (Fhandle_switch_frame):
8841 * fileio.c (Fdo_auto_save):
8842 * emacs.c (Fkill_emacs):
8843 * editfns.c (save_excursion_restore):
8844 * cmds.c (internal_self_insert):
8845 * callint.c (Fcall_interactively):
8846 * buffer.c (Fkill_all_local_variables):
8847 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8849 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8850 unconditionally since it does the check itself.
8852 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8854 Fix more problems found by GCC 4.5.2's static checks.
8856 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8857 the first time through the loop, since we know p0 < p1 then.
8858 This also avoids a gcc -Wstrict-overflow warning.
8860 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8861 leading to a memory leak, possible in functions like
8862 load_charset_map_from_file that can allocate an unbounded number
8863 of objects (Bug#8318).
8865 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8866 that could (at least in theory) be that large.
8868 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8869 This is less likely to overflow, and avoids undefined behavior if
8870 overflow does occur. All callers changed. Use strtoul to scan
8871 for the unsigned long integer.
8872 (pint2hrstr): Simplify and tune code slightly.
8873 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8875 * scroll.c (do_scrolling): Work around GCC bug 48228.
8876 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8878 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8879 This also avoids a warning with gcc -Wstrict-overflow.
8880 (validate_x_resource_name): Simplify count usage.
8881 This also avoids a warning with gcc -Wstrict-overflow.
8883 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8886 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8888 * process.c (Fmake_network_process): Use socklen_t, not int,
8889 where POSIX says socklen_t is required in portable programs.
8890 This fixes a porting bug on hosts like 64-bit HP-UX, where
8891 socklen_t is wider than int (Bug#8277).
8892 (Fmake_network_process, server_accept_connection):
8893 (wait_reading_process_output, read_process_output):
8896 * process.c: Rename or move locals to avoid shadowing.
8897 (list_processes_1, Fmake_network_process):
8898 (read_process_output_error_handler, exec_sentinel_error_handler):
8899 Rename or move locals.
8900 (Fmake_network_process): Define label "retry_connect" only if needed.
8901 (Fnetwork_interface_info): Fix pointer signedness.
8902 (process_send_signal): Add cast to avoid pointer signedness problem.
8903 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8904 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8906 Make tparam.h and terminfo.c consistent.
8907 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8908 Include tparam.h instead, since it declares them.
8909 * cm.h (PC): Remove extern decl; tparam.h now does this.
8910 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8911 * terminfo.c: Include tparam.h, to check interfaces.
8912 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8913 (tparam): Adjust signature to match interface in tparam.h;
8914 this removes some undefined behavior. Check that outstring and len
8915 are zero, which they always are with Emacs.
8916 * tparam.h (PC, BC, UP): New extern decls.
8918 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8919 (xftfont_open): Rename locals to avoid shadowing.
8921 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8922 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8923 (OTF_TAG_SYM): Omit macro if not needed.
8924 (ftfont_list): Remove unused local.
8925 (get_adstyle_property, ftfont_pattern_entity):
8926 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8927 Rename locals to avoid shadowing.
8929 * xfont.c (xfont_list_family): Mark var as initialized.
8931 * xml.c (make_dom): Now static.
8933 * composite.c (composition_compute_stop_pos): Rename local to
8935 (composition_reseat_it): Remove unused locals.
8936 (find_automatic_composition, composition_adjust_point): Likewise.
8937 (composition_update_it): Mark var as initialized.
8938 (find_automatic_composition): Mark vars as initialized,
8939 with a FIXME (Bug#8290).
8941 character.h: Rename locals to avoid shadowing.
8942 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8943 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8944 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8945 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8948 * textprop.c (property_change_between_p): Remove; unused.
8950 * intervals.c (interval_start_pos): Now static.
8952 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8954 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8955 Rename locals to avoid shadowing.
8957 * sound.c (wav_play, au_play, Fplay_sound_internal):
8958 Fix pointer signedness.
8959 (alsa_choose_format): Remove unused local var.
8960 (wav_play): Initialize a variable to 0, to prevent undefined
8961 behavior (Bug#8278).
8963 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8965 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8967 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8968 clobbering (Bug#8298).
8969 * sysdep.c (sys_subshell): Likewise.
8970 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8972 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8973 This should get cleaned up, so that child_setup has the
8974 same signature on all platforms.
8976 * callproc.c (call_process_cleanup): Now static.
8977 (relocate_fd): Rename locals to avoid shadowing.
8979 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8981 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8982 not to be necessary, and produces flickering.
8984 2011-03-20 Glenn Morris <rgm@gnu.org>
8986 * config.in: Remove file.
8988 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8990 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8991 are now in src/globals.h.
8992 (syms_of_minibuf): Remove spurious & from previous change.
8994 2011-03-20 Leo Liu <sdl.web@gmail.com>
8996 * minibuf.c (completing-read-function): New variable.
8997 (completing-read-default): Rename from completing-read.
8998 (completing-read): Call completing-read-function.
9000 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9002 * xfaces.c (Fx_load_color_file):
9003 Read color file from absolute filename (bug#8250).
9005 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9007 * makefile.w32-in: Update dependencies.
9009 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9011 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9013 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9015 Fix more problems found by GCC 4.5.2's static checks.
9017 * process.c (make_serial_process_unwind, send_process_trap):
9018 (sigchld_handler): Now static.
9020 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9021 That way, the code declares only the vars that it needs.
9022 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9023 * s/cygwin.h (PTY_ITERATION): Likewise.
9024 * s/darwin.h (PTY_ITERATION): Likewise.
9025 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9027 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9028 * process.c (allocate_pty): Don't declare stb unless it's needed.
9030 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9031 (CONSTANTLIM): Remove; unused.
9032 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9033 Define only if needed.
9035 * unexelf.c (unexec): Name an expression,
9036 to avoid gcc -Wbad-function-cast warning.
9037 Use a different way to cause a compilation error if anyone uses
9038 n rather than nn, a way that does not involve shadowing.
9039 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9041 * deps.mk (unexalpha.o): Remove; unused.
9043 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9044 * unexec.h: New file.
9045 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9046 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9048 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9049 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9050 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9051 Change as necessary to match prototype in unexec.h.
9053 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9055 (back_comment, skip_chars): Mark vars as initialized.
9057 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9058 Rename locals to avoid shadowing.
9060 * lread.c (read1): Rewrite so as not to use empty "else".
9061 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9063 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9065 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9066 warning when compiling print.c.
9068 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9069 instead of using an uninitialized var.
9070 (font_sort_entities): Mark var as initialized.
9072 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9074 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9075 pointers to constants.
9076 (font_parse_fcname): Remove unused vars.
9077 (font_delete_unmatched): Now static.
9078 (font_get_spec): Remove; unused.
9079 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9080 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9081 Rename or move locals to avoid shadowing.
9083 * fns.c (require_nesting_list, require_unwind): Now static.
9084 (Ffillarray): Rename locals to avoid shadowing.
9086 * floatfns.c (domain_error2): Define only if needed.
9087 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9089 * alloc.c (mark_backtrace): Move decl from here ...
9090 * lisp.h: ... to here, so that it can be checked.
9092 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9093 (Fdefvar): Rewrite so as not to use empty "else".
9094 (lisp_indirect_variable): Name an expression,
9095 to avoid gcc -Wbad-function-cast warning.
9096 (Fdefvar): Rename locals to avoid shadowing.
9098 * callint.c (quotify_arg, quotify_args): Now static.
9099 (Fcall_interactively): Rename locals to avoid shadowing.
9100 Use const pointer when appropriate.
9102 * lisp.h (get_system_name, get_operating_system_release):
9103 Move decls here, to check interfaces.
9104 * process.c (get_operating_system_release): Move decl to lisp.h.
9105 * xrdb.c (get_system_name): Likewise.
9106 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9107 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9108 some of which prompt warnings from gcc -Wbad-function-cast.
9109 (Fformat_time_string, Fencode_time, Finsert_char):
9110 (Ftranslate_region_internal, Fformat):
9111 Rename or remove local vars to avoid shadowing.
9112 (Ftranslate_region_internal): Mark var as initialized.
9114 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9117 * lisp.h (eassert): Check that the argument compiles, even if
9118 ENABLE_CHECKING is not defined.
9120 * data.c (Findirect_variable): Name an expression, to avoid
9121 gcc -Wbad-function-cast warning.
9122 (default_value, arithcompare, arith_driver, arith_error): Now static.
9123 (store_symval_forwarding): Rename local to avoid shadowing.
9124 (Fmake_variable_buffer_local, Fmake_local_variable):
9125 Mark variables as initialized.
9126 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9128 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9129 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9130 Rename locals to avoid shadowing.
9131 (mark_stack): Move local variables into the #ifdef region where
9133 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9134 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9136 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9137 (GC_STRING_CHARS): Remove; not used.
9138 (Fmemory_limit): Cast sbrk's returned value to char *.
9140 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9141 avoids undefined behavior in theory.
9143 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9145 Use functions, not macros, for up- and down-casing (Bug#8254).
9146 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9147 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9148 to use the following functions instead of these macros.
9149 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9150 EMACS_INT, since callers assume the returned value fits in int.
9151 (upcase1): Likewise, for UPCASE_TABLE.
9152 (uppercasep, lowercasep, upcase): New static inline functions.
9153 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9154 the race-condition problem in the old DOWNCASE.
9156 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9157 Rename locals to avoid shadowing.
9158 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9159 (regex_compile, re_search_2, re_match_2_internal):
9160 Remove unused local vars.
9161 (FREE_VAR): Rewrite so as not to use empty "else",
9162 which gcc can warn about.
9163 (regex_compile, re_match_2_internal): Mark locals as initialized.
9164 (RETALLOC_IF): Define only if needed.
9165 (WORDCHAR_P): Likewise. This one is never needed, but is used
9166 only in a comment talking about a compiler bug, so put inside
9167 the #if 0 of that comment.
9168 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9169 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9172 * search.c (boyer_moore): Rename locals to avoid shadowing.
9173 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9174 (PREV_CHAR_BOUNDARY): Likewise.
9176 * search.c (simple_search): Remove unused var.
9178 * dired.c (compile_pattern): Move decl from here ...
9179 * lisp.h: ... to here, so that it can be checked.
9180 (struct re_registers): New forward decl.
9182 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9184 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9186 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9187 Rename locals to avoid shadowing.
9188 (Fvertical_motion): Mark locals as initialized.
9190 * casefiddle.c (casify_object, casify_region): Now static.
9191 (casify_region): Mark local as initialized.
9193 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9195 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9196 New macros, so that the caller can use some names other than
9197 gcpro1, gcpro2, etc.
9198 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9200 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9201 argument, for consistency with GCPRO2_VAR, etc: it is now the
9202 prefix of the variable, not the variable itself. All uses
9204 * dired.c (directory_files_internal, file_name_completion):
9205 Rename locals to avoid shadowing.
9207 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9208 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9209 dired.c's scmp function, had undefined behavior.
9210 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9211 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9212 * buffer.h: ... to here, because these macros use current_buffer,
9213 and the new implementation with inline functions needs to have
9214 current_buffer in scope now, rather than later when the macros
9216 (downcase, upcase1): New static inline functions.
9217 (DOWNCASE, UPCASE1): Reimplement using these functions.
9218 This avoids undefined behavior in expressions like
9219 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9220 from race conditions in accessing the global variables
9221 case_temp1 and case_temp2.
9222 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9223 * lisp.h (case_temp1, case_temp2): Remove their decls.
9224 * character.h (ASCII_CHAR_P): Move from here ...
9225 * lisp.h: ... to here, so that the inline functions mentioned
9228 * dired.c (directory_files_internal_unwind): Now static.
9230 * fileio.c (file_name_as_directory, directory_file_name):
9231 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9233 (file_name_as_directory): Use const pointers when appropriate.
9234 (Fexpand_file_name): Likewise. In particular, newdir might
9235 point at constant storage, so make it a const pointer.
9236 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9237 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9239 (Fset_file_times, Finsert_file_contents, auto_save_error):
9240 Rename locals to avoid shadowing.
9242 * minibuf.c (choose_minibuf_frame_1): Now static.
9243 (Ftry_completion, Fall_completions): Rename or remove locals
9246 * marker.c (bytepos_to_charpos): Remove; unused.
9248 * lisp.h (verify_bytepos, count_markers): New decls,
9249 so that gcc does not warn that these functions aren't declared.
9251 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9252 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9253 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9254 (copy_text): Remove unused local var.
9256 * filelock.c (within_one_second): Now static.
9257 (lock_file_1): Rename local to avoid shadowing.
9259 * buffer.c (fix_overlays_before): Mark locals as initialized.
9260 (fix_start_end_in_overlays): Likewise. This function should be
9261 simplified by using pointers-to-pointers, but that's a different
9263 (switch_to_buffer_1): Now static.
9264 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9265 (report_overlay_modification): Rename locals to avoid shadowing.
9267 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9268 Fix pointer signedness issue.
9269 (sys_subshell): Mark local as volatile if checking for lint,
9270 to suppress a gcc -Wclobbered warning that does not seem to be right.
9271 (MAXPATHLEN): Define only if needed.
9273 * process.c (serial_open, serial_configure): Move decls from here ...
9274 * systty.h: ... to here, so that they can be checked.
9276 * fns.c (get_random, seed_random): Move extern decls from here ...
9277 * lisp.h: ... to here, so that they can be checked.
9279 * sysdep.c (reset_io): Now static.
9280 (wait_for_termination_signal): Remove; unused.
9282 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9283 (copy_keymap_item, append_key, push_text_char_description):
9285 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9286 (DENSE_TABLE_SIZE): Remove; unused.
9287 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9288 (describe_map_tree):
9289 Rename locals to avoid shadowing.
9291 * keyboard.c: Declare functions static if they are not used elsewhere.
9292 (echo_char, echo_dash, cmd_error, top_level_2):
9293 (poll_for_input, handle_async_input): Now static.
9294 (read_char, kbd_buffer_get_event, make_lispy_position):
9295 (make_lispy_event, make_lispy_movement, apply_modifiers):
9296 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9297 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9298 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9299 (read_key_sequence, read_char): Mark locals as initialized.
9300 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9302 * keyboard.h (make_ctrl_char): New decl.
9303 (mark_kboards): Move decl here ...
9304 * alloc.c (mark_kboards): ... from here.
9306 * lisp.h (force_auto_save_soon): New decl.
9308 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9309 (DEFINE_DUMMY_FUNCTION): New macro.
9310 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9312 (main): Add casts to avoid warnings
9313 if GCC considers string literals to be constants.
9315 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9317 * dbusbind.c: Pointer signedness fixes.
9318 (xd_signature, xd_append_arg, xd_initialize):
9319 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9320 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9321 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9322 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9324 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9325 if GCC considers string literals to be constants.
9326 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9328 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9330 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9331 (print_preprocess, print_object): New macro to fix last change.
9333 * print.c (print_preprocess): Don't forget font objects.
9335 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9337 * emacs.c (USAGE3): Doc fixes.
9339 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9341 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9344 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9346 * lisp.h (VWindow_system, Qfile_name_history):
9347 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9348 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9349 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9351 * w32select.c: Don't #include "keyboard.h".
9352 (run_protected): Add extern declaration for waiting_for_input.
9354 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9355 * w32console.c (detect_input_pending, read_input_pending)
9356 (encode_terminal_code):
9357 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9358 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9359 (w32_system_caret_y, Qfile_name_history):
9360 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9361 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9362 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9363 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9364 * w32proc.c (Qlocal, report_file_error):
9365 * w32term.c (Vwindow_system, updating_frame):
9366 * w32uniscribe.c (initialized, uniscribe_font_driver):
9367 Remove unneeded extern declarations.
9369 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9371 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9373 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9375 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9376 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9377 These macros can no longer be used for assignment.
9379 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9380 Assign struct members directly, instead of using BUF_BEGV etc.
9381 (record_buffer_markers, fetch_buffer_markers): New functions for
9382 recording and fetching special buffer markers.
9383 (set_buffer_internal_1, set_buffer_temp): Use them.
9385 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9387 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9389 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9390 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9392 * xdisp.c (hscroll_window_tree):
9393 (reconsider_clip_changes): Use PT instead of BUF_PT.
9395 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9397 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9398 $(EMACS_ROOT)/lib/intprops.h.
9400 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9402 Fix more problems found by GCC 4.5.2's static checks.
9404 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9405 to unsigned char * to avoid compiler diagnostic.
9406 (xg_free_frame_widgets): Make it clear that a local variable is
9407 needed only if USE_GTK_TOOLTIP.
9408 (gdk_window_get_screen): Make it clear that this macro is needed
9409 only if USE_GTK_TOOLTIP.
9410 (int_gtk_range_get_value): New function, which avoids a diagnostic
9411 from gcc -Wbad-function-cast.
9412 (xg_set_toolkit_scroll_bar_thumb): Use it.
9413 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9414 diagnostic from gcc -Wbad-function-cast.
9415 (get_utf8_string, xg_get_file_with_chooser):
9416 Rename locals to avoid shadowing.
9417 (create_dialog): Move locals to avoid shadowing.
9419 * xgselect.c (xg_select): Remove unused var.
9421 * image.c (four_corners_best): Mark locals as initialized.
9422 (gif_load): Initialize transparent_p to zero (Bug#8238).
9423 Mark another local as initialized.
9424 (my_png_error, my_error_exit): Mark with NO_RETURN.
9426 * image.c (clear_image_cache): Now static.
9427 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9428 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9429 (x_edge_detection): Remove unnecessary cast that
9430 gcc -Wbad-function-cast diagnoses.
9431 (gif_load): Fix pointer signedness.
9432 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9433 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9435 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9437 Improve quality of tests for time stamp overflow.
9438 For example, without this patch (encode-time 0 0 0 1 1
9439 1152921504606846976) returns the obviously-bogus value (-948597
9440 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9441 reports time overflow. See
9442 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9443 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9444 * editfns.c: Include limits.h and intprops.h.
9445 (TIME_T_MIN, TIME_T_MAX): New macros.
9446 (time_overflow): Move earlier, to before first use.
9447 (hi_time, lo_time): New functions, for an accurate test for
9449 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9450 (Fget_internal_run_time): Don't assume time_t fits in int.
9451 (make_time): Use list2 instead of Fcons twice.
9452 (Fdecode_time): More accurate test for out-of-range times.
9453 (check_tm_member): New function.
9454 (Fencode_time): Use it, to test for out-of-range times.
9455 (lisp_time_argument): Don't rely on undefined left-shift and
9456 right-shift behavior when checking for time stamp overflow.
9458 * editfns.c (time_overflow): New function, refactoring common code.
9459 (Fformat_time_string, Fdecode_time, Fencode_time):
9460 (Fcurrent_time_string): Use it.
9462 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9463 * dired.c (make_time): Move to ...
9464 * editfns.c (make_time): ... here.
9465 * systime.h: Note the move.
9467 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9469 * fringe.c (update_window_fringes): Remove unused variables.
9471 * unexmacosx.c (copy_data_segment): Also copy __got section.
9474 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9476 * termcap.c [MSDOS]: Include "msdos.h".
9477 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9478 Constify `char *' arguments and their references according to
9479 prototypes in tparam.h.
9481 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9483 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9484 Adapt all references accordingly.
9486 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9488 2011-03-11 Tom Tromey <tromey@redhat.com>
9490 * buffer.c (syms_of_buffer): Remove obsolete comment.
9492 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9494 * termhooks.h (encode_terminal_code): Declare prototype.
9496 * msdos.c (encode_terminal_code): Don't declare prototype.
9498 * term.c (encode_terminal_code): Now external again, used by
9499 w32console.c and msdos.c.
9501 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9502 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9504 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9506 Fix some minor problems found by GCC 4.5.2's static checks.
9508 * fringe.c (update_window_fringes): Mark locals as initialized
9510 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9512 * alloc.c (mark_fringe_data): Move decl from here ...
9513 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9514 to check its interface.
9515 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9517 * fontset.c (free_realized_fontset): Now static.
9518 (Fset_fontset_font): Rename local to avoid shadowing.
9519 (fontset_font): Mark local as initialized.
9520 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9522 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9524 * xselect.c (x_disown_buffer_selections): Remove; not used.
9525 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9526 (x_own_selection, Fx_disown_selection_internal): Rename locals
9528 (x_handle_dnd_message): Remove local to avoid shadowing.
9530 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9531 so that the caller can use some name other than gcpro1.
9532 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9533 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9534 (Fx_backspace_delete_keys_p):
9535 Use them to avoid shadowing, and rename vars to avoid shadowing.
9536 (x_decode_color, x_set_name, x_window): Now static.
9537 (Fx_create_frame): Add braces to silence GCC warning.
9538 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9539 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9540 Remove unused locals.
9541 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9542 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9543 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9546 * xterm.h (x_mouse_leave): New decl.
9548 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9549 Remove unused functions.
9550 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9551 (x_calc_absolute_position): Now static.
9552 (XTread_socket): Don't define label "out" unless it's used.
9553 Don't declare local "event" unless it's used.
9554 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9555 unless they are used.
9556 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9557 (x_fatal_error_signal): Remove; not used.
9558 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9559 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9560 (x_error_catcher, x_connection_closed, x_error_handler):
9561 (x_error_quitter, xembed_send_message, x_iconify_frame):
9562 (my_log_handler): Rename locals to avoid shadowing.
9563 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9564 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9566 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9567 Rename or move locals to avoid shadowing.
9568 (tty_defined_color, merge_face_heights): Now static.
9569 (free_realized_faces_for_fontset): Remove; not used.
9570 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9571 does not deduce is never used uninitialized.
9572 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9573 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9575 * terminal.c (store_terminal_param): Now static.
9577 * xmenu.c (menu_highlight_callback): Now static.
9578 (set_frame_menubar): Remove unused local.
9579 (xmenu_show): Rename parameter to avoid shadowing.
9580 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9581 since they might point to immutable storage.
9582 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9583 since it's unused otherwise.
9585 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9586 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9587 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9588 avoids a gcc -Wuninitialized diagnostic.
9589 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9590 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9591 does not deduce are never used uninitialized.
9593 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9595 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9596 * window.c (window_loop, size_window):
9597 (run_window_configuration_change_hook, enlarge_window): Likewise.
9599 * window.c (display_buffer): Now static.
9600 (size_window): Mark variables that gcc -Wuninitialized
9601 does not deduce are never used uninitialized.
9602 * window.h (check_all_windows): New decl, to forestall
9603 gcc -Wmissing-prototypes diagnostic.
9604 * dispextern.h (bidi_dump_cached_states): Likewise.
9606 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9608 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9610 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9611 and to avoid gcc -Wuninitialized warning.
9612 (load_charset_map): Mark variables that gcc -Wuninitialized
9613 does not deduce are never used uninitialized.
9614 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9616 * coding.c (coding_set_source, coding_set_destination):
9617 Use "else { /* comment */ }" rather than "else /* comment */;"
9618 for clarity, and to avoid gcc -Wempty-body warning.
9619 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9620 a block, when the outer 'i' will do.
9621 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9622 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9623 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9624 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9625 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9626 Rename locals to avoid shadowing.
9627 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9628 * coding.c (emacs_mule_char, encode_invocation_designation):
9629 Now static, since they're not used elsewhere.
9630 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9631 (decode_coding_object, encode_coding_object, detect_coding_system):
9632 (decode_coding_emacs_mule): Mark variables that gcc
9633 -Wuninitialized does not deduce are never used uninitialized.
9634 (detect_coding_iso_2022): Initialize a local variable that might
9635 be used uninitialized. Leave a FIXME because it's not clear that
9636 this initialization is needed. (Bug#8211)
9637 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9638 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9639 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9640 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9641 Remove unused macros.
9643 * category.c (hash_get_category_set): Remove unused local var.
9644 (copy_category_table): Now static, since it's not used elsewhere.
9645 * character.c (string_count_byte8): Likewise.
9647 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9648 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9650 * chartab.c (copy_sub_char_table): Now static, since it's not used
9652 (sub_char_table_ref_and_range, char_table_ref_and_range):
9653 Rename locals to avoid shadowing.
9654 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9656 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9657 (BIDI_BOB): Remove unused macro.
9659 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9660 deduce are never used uninitialized.
9661 * term.c (encode_terminal_code): Likewise.
9663 * term.c (encode_terminal_code): Now static. Remove unused local.
9665 * tparam.h: New file.
9666 * term.c, tparam.h: Include it.
9667 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9668 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9669 Move these decls to tparam.h, and make them agree with what
9670 is actually in tparam.c. The previous trick of using incompatible
9671 decls in different modules does not conform to the C standard.
9672 All callers of tparam changed to use tparam's actual API.
9673 * tparam.c (tparam1, tparam, tgoto):
9674 Use const pointers where appropriate.
9676 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9677 * cm.h (struct cm): Likewise.
9678 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9679 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9680 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9681 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9682 (turn_on_face, init_tty): Likewise.
9683 * termchar.h (struct tty_display_info): Likewise.
9685 * term.c (term_mouse_position): Rename local to avoid shadowing.
9687 * alloc.c (mark_ttys): Move decl from here ...
9688 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9690 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9692 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9694 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9696 * search.c (compile_pattern_1): Remove argument regp, unused since
9697 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9698 (compile_pattern): Don't pass it.
9700 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9702 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9703 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9705 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9707 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9709 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9710 gdk_window_get_screen, gdk_window_get_geometry,
9711 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9712 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9713 (xg_get_pixbuf_from_pixmap): New function.
9714 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9715 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9716 Call xg_get_pixbuf_from_pixmap instead of
9717 gdk_pixbuf_get_from_drawable.
9718 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9719 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9720 (xg_check_special_colors): Use GtkStyleContext and its functions
9722 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9723 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9724 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9725 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9726 Call gtk_widget_get_preferred_size.
9727 (xg_frame_resized): gdk_window_get_geometry only takes 5
9729 (xg_win_to_widget, xg_event_is_for_menubar):
9730 Call gdk_x11_window_lookup_for_display.
9731 (xg_set_widget_bg): New function.
9732 (delete_cb): New function.
9733 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9734 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9735 (xg_set_background_color): Call xg_set_widget_bg.
9736 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9737 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9738 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9739 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9741 (update_frame_tool_bar): Call gtk_widget_hide.
9742 (xg_initialize): Use GDK_KEY_g.
9744 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9746 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9748 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9749 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9750 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9752 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9754 * w32xfns.c (select_palette): Check success of RealizePalette against
9755 GDI_ERROR, not zero.
9757 See ChangeLog.11 for earlier changes.
9763 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9765 This file is part of GNU Emacs.
9767 GNU Emacs is free software: you can redistribute it and/or modify
9768 it under the terms of the GNU General Public License as published by
9769 the Free Software Foundation, either version 3 of the License, or
9770 (at your option) any later version.
9772 GNU Emacs is distributed in the hope that it will be useful,
9773 but WITHOUT ANY WARRANTY; without even the implied warranty of
9774 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9775 GNU General Public License for more details.
9777 You should have received a copy of the GNU General Public License
9778 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.