* bidi.c: Integer overflow fix.
[bpt/emacs.git] / src / ChangeLog
1 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2
3 * bidi.c: Integer overflow fix.
4 (bidi_shelve_header_size): New constant.
5 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7
8 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
9
10 Use ptrdiff_t for composition IDs.
11 * character.c (lisp_string_width):
12 * composite.c (composition_table_size, n_compositions)
13 (get_composition_id, composition_gstring_from_id):
14 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
15 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
16 * window.c (Frecenter):
17 Use ptrdiff_t, not int, for composition IDs.
18 * composite.c (get_composition_id): Check for integer overflow.
19 * composite.h: Adjust prototypes to match the above changes.
20
21 Use ptrdiff_t for hash table indexes.
22 * category.c (hash_get_category_set):
23 * ccl.c (ccl_driver):
24 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
25 * coding.c (coding_system_charset_list, detect_coding_system):
26 * coding.h (struct coding_system.id):
27 * composite.c (get_composition_id, gstring_lookup_cache):
28 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
29 * image.c (xpm_get_color_table_h):
30 * lisp.h (hash_lookup, hash_put):
31 * minibuf.c (Ftest_completion):
32 Use ptrdiff_t for hash table indexes, not int (which is too
33 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
34 32-bit --with-wide-int hosts).
35
36 * charset.c (Fdefine_charset_internal): Check for integer overflow.
37 Add a FIXME comment about memory leaks.
38 (syms_of_charset): Don't assume xmalloc returns.
39
40 Don't assume that stated character widths fit in int.
41 * character.c (Fchar_width, c_string_width, lisp_string_width):
42 * character.h (CHAR_WIDTH):
43 * indent.c (MULTIBYTE_BYTES_WIDTH):
44 Use sanitize_char_width to avoid undefined and/or bad behavior
45 with outlandish widths.
46 * character.h (sanitize_tab_width): Renamed from sanitize_width,
47 now that we have two such functions. All uses changed.
48 (sanitize_char_width): New inline function.
49
50 Don't assume that tab-width fits in int.
51 * character.h (sanitize_width): New inline function.
52 (SANE_TAB_WIDTH): New macro.
53 (ASCII_CHAR_WIDTH): Use it.
54 * indent.c (sane_tab_width): Remove. All uses replaced by
55 SANE_TAB_WIDTH (current_buffer).
56 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
57
58 * fileio.c: Integer overflow issues with file modes.
59 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
60
61 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
62 Remove unreachable code.
63 (read_hex, load_charset_map_from_file): Check for integer overflow.
64
65 * xterm.c: don't go over XClientMessageEvent limit
66 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
67 (x_send_scroll_bar_event): Likewise. Check that the size does not
68 exceed limits imposed by XClientMessageEvent, as well as the usual
69 ptrdiff_t and size_t limits.
70
71 * keyboard.c: Overflow, signedness and related fixes.
72 (make_lispy_movement): Use same integer type in forward decl
73 that is used in the definition.
74 (read_key_sequence, keyremap_step):
75 Change bufsize argument back to int, undoing my 2011-03-30 change.
76 We prefer signed types, and int is wide enough here.
77 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
78 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
79 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
80 length, not size_t. Use ptrdiff_t for index, not int.
81 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
82 possibility of integer overflow.
83
84 Overflow, signedness and related fixes for images.
85
86 * dispextern.h (struct it.stack[0].u.image.image_id)
87 (struct_it.image_id, struct image.id, struct image_cache.size)
88 (struct image_cache.used, struct image_cache.ref_count):
89 * gtkutil.c (update_frame_tool_bar):
90 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
91 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
92 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
93 * nsmenu.m (update_frame_tool_bar):
94 * xdisp.c (calc_pixel_width_or_height):
95 * xfns.c (image_cache_refcount):
96 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
97 on typical 64-bit hosts.
98
99 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
100 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
101 Omit unnecessary casts to int.
102 (parse_image_spec): Check that integers fall into 'int' range
103 when the callers expect that.
104 (image_ascent): Redo ascent calculation to avoid int overflow.
105 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
106 (lookup_image): Remove unnecessary tests.
107 (xbm_image_p): Locals are now of int, not EMACS_INT,
108 since parse_image_check makes sure they fit into int.
109 (png_load, gif_load, svg_load_image):
110 Prefer int to unsigned where either will do.
111 (tiff_handler): New function, combining the cores of the
112 old tiff_error_handler and tiff_warning_handler. This
113 function is rewritten to use vsnprintf and thereby avoid
114 stack buffer overflows. It uses only the features of vsnprintf
115 that are common to both POSIX and native Microsoft.
116 (tiff_error_handler, tiff_warning_handler): Use it.
117 (tiff_load, gif_load, imagemagick_load_image):
118 Don't assume :index value fits in 'int'.
119 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
120 (imagemagick_load_image): Check that crop parameters fit into
121 the integer types that MagickCropImage accepts. Don't assume
122 Vimagemagick_render_type has a nonnegative value. Don't assume
123 size_t fits in 'long'.
124 (gs_load): Use printmax_t to print the widest integers possible.
125 Check for integer overflow when computing image height and width.
126
127 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
128
129 Integer signedness and overflow and related fixes. (Bug#9079)
130
131 * bidi.c: Integer size and overflow fixes.
132 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
133 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
134 (bidi_cache_find_level_change, bidi_cache_ensure_space)
135 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
136 (bidi_find_other_level_edge):
137 Use ptrdiff_t instead of EMACS_INT where either will do.
138 This works better on 32-bit hosts configured --with-wide-int.
139 (bidi_cache_ensure_space): Check for size-calculation overflow.
140 Use % rather than repeated addition, for better worst-case speed.
141 Don't set bidi_cache_size until after xrealloc returns, because it
142 might not return.
143 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
144 (bidi_cache_ensure_space): Also check that the bidi cache size
145 does not exceed that of the largest Lisp string or buffer. See Eli
146 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
147
148 * alloc.c (__malloc_size_t): Remove.
149 All uses replaced by size_t. See Andreas Schwab's note
150 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
151
152 * image.c: Improve checking for integer overflow.
153 (check_image_size): Assume that f is nonnull, since
154 it is always nonnull in practice. This is one less thing to
155 worry about when checking for integer overflow later.
156 (x_check_image_size): New function, which checks for integer
157 overflow issues inside X.
158 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
159 This removes the need for a memory_full check.
160 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
161 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
162 (xbm_read_bitmap_data): Change locals back to 'int', since
163 their values must fit in 'int'.
164 (xpm_load_image, png_load, tiff_load):
165 Invoke x_create_x_image_and_pixmap earlier,
166 to avoid much needless work if the image is too large.
167 (tiff_load): Treat overly large images as if
168 x_create_x_image_and_pixmap failed, not as malloc failures.
169 (gs_load): Use x_check_image_size.
170
171 * gtkutil.c: Omit integer casts.
172 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
173 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
174
175 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
176
177 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
178 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
179 would wrongly return t on a 64-bit host.
180
181 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
182 The plain *_OVERFLOW macros run afoul of GCC bug 49705
183 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
184 and therefore cause GCC to emit a bogus diagnostic in some cases.
185
186 * image.c: Integer signedness and overflow and related fixes.
187 This is not an exhaustive set of fixes, but it's time to
188 record what I've got.
189 (lookup_pixel_color, check_image_size): Remove redundant decls.
190 (check_image_size): Don't assume that arbitrary EMACS_INT values
191 fit in 'int', or that arbitrary 'double' values fit in 'int'.
192 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
193 (tiff_load, imagemagick_load_image):
194 Check for overflow in size calculations.
195 (x_create_x_image_and_pixmap): Remove unnecessary test for
196 xmalloc returning NULL; that can't happen.
197 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
198 (xpm_color_bucket): Use better integer hashing function.
199 (xpm_cache_color): Don't possibly over-allocate memory.
200 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
201 (gif_memory_source):
202 Use ptrdiff_t, not int or size_t, to record sizes.
203 (png_load): Don't assume values greater than 2**31 fit in 'int'.
204 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
205 either works, as we prefer signed integers.
206 (tiff_read_from_memory, tiff_write_from_memory):
207 Return tsize_t, not size_t, since that's what the TIFF API wants.
208 (tiff_read_from_memory): Don't fail simply because the read would
209 go past EOF; instead, return a short read.
210 (tiff_load): Omit no-longer-needed casts.
211 (Fimagemagick_types): Don't assume size fits into 'int'.
212
213 Improve hashing quality when configured --with-wide-int.
214 * fns.c (hash_string): New function, taken from sxhash_string.
215 Do not discard information about ASCII character case; this
216 discarding is no longer needed.
217 (sxhash-string): Use it. Change sig to match it. Caller changed.
218 * lisp.h: Declare it.
219 * lread.c (hash_string): Remove, since we now use fns.c's version.
220 The fns.c version returns a wider integer if --with-wide-int is
221 specified, so this should help the quality of the hashing a bit.
222
223 * emacs.c: Integer overflow minor fix.
224 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
225 Define only if GNU_LINUX.
226 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
227
228 * dispnew.c: Integer signedness and overflow fixes.
229 Remove unnecessary forward decls, that were a maintenance hassle.
230 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
231 All uses changed.
232 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
233 (scrolling_window): Use ptrdiff_t, not int, for byte count.
234 (prepare_desired_row, line_draw_cost):
235 Use int, not unsigned, where either works.
236 (save_current_matrix, restore_current_matrix):
237 Use ptrdiff_t, not size_t, where either works.
238 (init_display): Check for overflow more accurately, and without
239 relying on undefined behavior.
240
241 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
242 Remove, replacing with the new symbols in lisp.h. All uses changed.
243 * fileio.c (make_temp_name):
244 * filelock.c (lock_file_1, lock_file):
245 * xdisp.c (message_dolog):
246 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
247 Use pMd etc. instead.
248 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
249 replacing the pWIDE etc. symbols removed from editfns.c.
250
251 * keyboard.h (num_input_events): Now uintmax_t.
252 This is (very slightly) less likely to mess up due to wraparound.
253 All uses changed.
254
255 * buffer.c: Integer signedness fixes.
256 (alloc_buffer_text, enlarge_buffer_text):
257 Use ptrdiff_t rather than size_t when either will do, as we prefer
258 signed integers.
259
260 * alloc.c: Integer signedness and overflow fixes.
261 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
262 (__malloc_size_t): Default to size_t, not to int.
263 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
264 (Fgarbage_collect, mark_object_loop_halt, mark_object):
265 Prefer ptrdiff_t to size_t when either would do, as we prefer
266 signed integers.
267 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
268 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
269 Now const. Initialize with values that are in range even if char
270 is signed.
271 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
272 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
273 These functions do the right thing with sizes > 2**32.
274 (check_depth): Now ptrdiff_t, not int.
275 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
276 Adjust to new way of storing sizes. Check for size overflow bugs
277 in rest of code.
278 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
279 slightly wrong anyway, as it missed one instance of
280 XMALLOC_OVERRUN_CHECK_OVERHEAD.
281 (refill_memory_reserve): Omit needless cast to size_t.
282 (mark_object_loop_halt): Mark as externally visible.
283
284 * xselect.c: Integer signedness and overflow fixes.
285 (Fx_register_dnd_atom, x_handle_dnd_message):
286 Use ptrdiff_t, not size_t, since we prefer signed.
287 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
288 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
289 x_dnd_atoms_size and x_dnd_atoms_length.
290
291 * doprnt.c: Prefer signed to unsigned when either works.
292 * eval.c (verror):
293 * doprnt.c (doprnt):
294 * lisp.h (doprnt):
295 * xdisp.c (vmessage):
296 Use ptrdiff_t, not size_t, when using or implementing doprnt,
297 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
298 prefer signed arithmetic to avoid comparison confusion.
299 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
300 but is a bit tricky.
301
302 Assume freestanding C89 headers, string.h, stdlib.h.
303 * data.c, doprnt.c, floatfns.c, print.c:
304 Include float.h unconditionally.
305 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
306 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
307 * regex.c: Likewise for stddef.h, string.h.
308 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
309 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
310 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
311 (STDC_HEADERS): Remove obsolete defines.
312 * sysdep.c: Include limits.h unconditionally.
313
314 Assume support for memcmp, memcpy, memmove, memset.
315 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
316 * regex.c (memcmp, memcpy):
317 Remove; we assume C89 now.
318
319 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
320 (__malloc_safe_bcopy): Remove; no longer needed.
321
322 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
323 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
324 well either way, and we prefer signed to unsigned.
325
326 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
327
328 Port to OpenBSD.
329 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
330 and the surrounding thread.
331 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
332 rather than fgets, and retry after EINTR. Otherwise, 'emacs
333 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
334 timer goes off.
335 * s/openbsd.h (BROKEN_SIGIO): Define.
336 * unexelf.c (unexec) [__OpenBSD__]:
337 Don't update the .mdebug section of the Alpha COFF symbol table.
338
339 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
340
341 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
342 (bug#8460).
343
344 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
345
346 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
347 This fixes some race conditions on the permissions of any newly
348 created file.
349
350 * alloc.c (valid_pointer_p): Use pipe, not open.
351 This fixes some permissions issues when debugging.
352
353 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
354 If fchown fails to set both uid and gid, try to set just gid,
355 as that is sometimes allowed. Adjust the file's mode to eliminate
356 setuid or setgid bits that are inappropriate if fchown fails.
357
358 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
359
360 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
361 to compare Lisp_Objects.
362 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
363 global_gnutls_log_level, don't mistake it for a Lisp_Object.
364 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
365
366 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
367
368 * lread.c (read_integer): Unread even EOF character.
369 (read1): Likewise. Properly record start position of symbol.
370
371 * lread.c (read1): Read `#:' as empty uninterned symbol if no
372 symbol character follows.
373
374 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
375
376 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
377 This works around a problem with the previous change to Fcopy_file.
378 Recent glibc declares fchown with __attribute__((warn_unused_result)),
379 and without this change, GCC might complain about discarding
380 fchown's return value.
381
382 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
383
384 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
385
386 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
387
388 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
389
390 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
391
392 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
393 it's used from the C level.
394
395 * process.c: Use the same condition for POLL_FOR_INPUT in both
396 keyboard.c and process.c (bug#1858).
397
398 2011-07-09 Lawrence Mitchell <wence@gmx.li>
399
400 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
401 (Fgnutls_boot): Use it.
402
403 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
404
405 * doc.c (Fsubstitute_command_keys): Revert last change.
406
407 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
408
409 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
410 quotes the next character, and doesn't affect other longer
411 sequences (bug#8935).
412
413 * lread.c (syms_of_lread): Clarify that is isn't only
414 `eval-buffer' and `eval-defun' that's affected by
415 `lexical-binding' (bug#8460).
416
417 2011-07-15 Eli Zaretskii <eliz@gnu.org>
418
419 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
420 bidi redisplay when a line includes both an image and is
421 truncated.
422
423 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
424
425 Fix minor problems found by static checking.
426 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
427 (elsz): Now a signed constant, not a size_t var. We prefer signed
428 types to unsigned, to avoid integer comparison confusion. Without
429 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
430 "cannot optimize loop, the loop counter may overflow", a symptom
431 of the confusion.
432 * indent.c (Fvertical_motion): Mark locals as initialized.
433 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
434
435 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
436
437 * search.c (Fre_search_backward): Mention `case-fold-search' in
438 all the re_search_* functions (bug#8138).
439
440 * keyboard.c (Fopen_dribble_file): Document when the file is
441 closed (bug#8056).
442
443 2011-07-14 Eli Zaretskii <eliz@gnu.org>
444
445 * bidi.c (bidi_dump_cached_states): Fix format of displaying
446 bidi_cache_idx.
447
448 Support bidi reordering of display and overlay strings.
449 * xdisp.c (compute_display_string_pos)
450 (compute_display_string_end): Accept additional argument STRING.
451 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
452 (reseat_to_string): Initialize bidi_it->string.s and
453 bidi_it->string.schars.
454 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
455 NULL (avoids a crash in bidi_paragraph_init). Initialize
456 itb.string.lstring.
457 (init_iterator): Call bidi_init_it only of a valid
458 buffer position was specified. Initialize paragraph_embedding to
459 L2R.
460 (reseat_to_string): Initialize the bidi iterator.
461 (display_string): If we need to ignore text properties of
462 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
463 original value of -1 will not work with bidi.)
464 (compute_display_string_pos): First arg is now struct
465 `text_pos *'; all callers changed. Support display properties on
466 Lisp strings.
467 (compute_display_string_end): Support display properties on Lisp
468 strings.
469 (init_iterator, reseat_1, reseat_to_string): Initialize the
470 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
471 when iterating on a string not from display properties).
472 (compute_display_string_pos, compute_display_string_end): Fix
473 calculation of the object to scan. Fixes an error when using
474 arrow keys.
475 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
476 base_level_stop; instead, set base_level_stop to BEGV. Fixes
477 crashes in vertical-motion.
478 (next_element_from_buffer): Improve commentary for when
479 the iterator is before prev_stop.
480 (init_iterator): Initialize bidi_p from the default value of
481 bidi-display-reordering, not from buffer-local value. Use the
482 buffer-local value only if initializing for buffer iteration.
483 (handle_invisible_prop): Support invisible properties on strings
484 that are being bidi-reordered.
485 (set_iterator_to_next): Support bidi reordering of C strings and
486 Lisp strings.
487 (next_element_from_string): Support bidi reordering of Lisp
488 strings.
489 (handle_stop_backwards): Support Lisp strings as well.
490 (display_string): Support display of R2L glyph rows. Use
491 IT_STRING_CHARPOS when displaying from a Lisp string.
492 (init_iterator): Don't initialize it->bidi_p for strings
493 here.
494 (reseat_to_string): Initialize it->bidi_p for strings here.
495 (next_element_from_string, next_element_from_c_string)
496 (next_element_from_buffer): Add xassert's for correspondence
497 between IT's object being iterated and it->bidi_it.string
498 structure.
499 (face_before_or_after_it_pos): Support bidi iteration.
500 (next_element_from_c_string): Handle the case of the first string
501 character that is not the first one in the visual order.
502 (get_visually_first_element): New function, refactored from common
503 parts of next_element_from_buffer, next_element_from_string, and
504 next_element_from_c_string.
505 (tool_bar_lines_needed, redisplay_tool_bar)
506 (display_menu_bar): Force left-to-right direction. Add a FIXME
507 comment for making that be controlled by a user option.
508 (push_it, pop_it): Save and restore the state of the
509 bidi iterator. Save and restore the bidi_p flag.
510 (pop_it): Iterate out of display property for string iteration as
511 well.
512 (iterate_out_of_display_property): Support iteration over strings.
513 (handle_single_display_spec): Set up it->bidi_it for iteration
514 over a display string, and call bidi_init_it.
515 (handle_single_display_spec, next_overlay_string)
516 (get_overlay_strings_1, push_display_prop): Set up the bidi
517 iterator for displaying display or overlay strings.
518 (forward_to_next_line_start): Don't use the shortcut if
519 bidi-iterating.
520 (back_to_previous_visible_line_start): If handle_display_prop
521 pushed the iterator stack, restore the internal state of the bidi
522 iterator by calling bidi_pop_it same number of times.
523 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
524 and we are bidi-iterating, don't decrement the iterator position;
525 instead, set the first_elt flag in the bidi iterator, to produce
526 the same effect.
527 (reseat_1): Remove redundant setting of string_from_display_prop_p.
528 (push_display_prop): xassert that we are iterating a buffer.
529 (push_it, pop_it): Save and restore paragraph_embedding member.
530 (handle_single_display_spec, next_overlay_string)
531 (get_overlay_strings_1, reseat_1, reseat_to_string)
532 (push_display_prop): Set up the `unibyte' member of bidi_it.string
533 correctly. Don't assume unibyte strings are not bidi-reordered.
534 (compute_display_string_pos)
535 (compute_display_string_end): Fix handling the case of C string.
536 (push_it, pop_it): Save and restore from_disp_prop_p.
537 (handle_single_display_spec, push_display_prop): Set the
538 from_disp_prop_p flag.
539 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
540 (pop_it): Call iterate_out_of_display_property only if we are
541 popping after iteration over a string that came from a display
542 property. Fix a typo in popping stretch info. Add an assertion
543 for verifying that the iterator position is in sync with the bidi
544 iterator.
545 (handle_single_display_spec, get_overlay_strings_1)
546 (push_display_prop): Fix initialization of paragraph direction for
547 string when that of the parent object is not yet determined.
548 (reseat_1): Call bidi_init_it to resync the bidi
549 iterator with IT's position. (Bug#7616)
550 (find_row_edges): If ROW->start.pos gives position
551 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
552 (handle_stop, back_to_previous_visible_line_start, reseat_1):
553 Reset the from_disp_prop_p flag.
554 (SAVE_IT, RESTORE_IT): New macros.
555 (pos_visible_p, face_before_or_after_it_pos)
556 (back_to_previous_visible_line_start)
557 (move_it_in_display_line_to, move_it_in_display_line)
558 (move_it_to, move_it_vertically_backward, move_it_by_lines)
559 (try_scrolling, redisplay_window, display_line): Use them when
560 saving a temporary copy of the iterator and restoring it back.
561 (back_to_previous_visible_line_start, reseat_1)
562 (init_iterator): Empty the bidi cache "stack".
563 (move_it_in_display_line_to): If iterator ended up at
564 EOL, but we never saw any buffer positions smaller than
565 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
566 motion in bidi-reordered lines.
567 (move_it_in_display_line_to): Record prev_method and prev_pos
568 immediately before the call to set_iterator_to_next. Fixes cursor
569 motion in bidi-reordered lines with stretch glyphs and strings
570 displayed in margins. (Bug#8133) (Bug#8867)
571 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
572 TO_CHARPOS.
573 (pos_visible_p): Support positions in bidi-reordered lines. Save
574 and restore bidi cache.
575
576 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
577 (bidi_paragraph_info): Delete unused struct.
578 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
579 (bidi_cache_start): New variable.
580 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
581 to zero.
582 (bidi_cache_fetch_state, bidi_cache_search)
583 (bidi_cache_find_level_change, bidi_cache_iterator_state)
584 (bidi_cache_find, bidi_peek_at_next_level)
585 (bidi_level_of_next_char, bidi_find_other_level_edge)
586 (bidi_move_to_visually_next): Compare cache index with
587 bidi_cache_start rather than with zero.
588 (bidi_fetch_char): Accept new argument STRING; all callers
589 changed. Support iteration over a string. Support strings with
590 display properties. Support unibyte strings. Fix the type of
591 `len' according to what STRING_CHAR_AND_LENGTH expects.
592 (bidi_paragraph_init, bidi_resolve_explicit_1)
593 (bidi_resolve_explicit, bidi_resolve_weak)
594 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
595 iteration over a string.
596 (bidi_set_sor_type, bidi_resolve_explicit_1)
597 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
598 can now be zero (for strings); special values 0 and -1 were
599 changed to -1 and -2, respectively.
600 (bidi_char_at_pos): New function.
601 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
602 Call it instead of FETCH_MULTIBYTE_CHAR.
603 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
604 initialized to valid values.
605 (bidi_init_it): Don't initialize charpos and bytepos with invalid
606 values.
607 (bidi_level_of_next_char): Allow the sentinel "position" to pass
608 the test for valid cached positions. Fix the logic for looking up
609 the sentinel state in the cache. GCPRO the Lisp string we are
610 iterating.
611 (bidi_push_it, bidi_pop_it): New functions.
612 (bidi_initialize): Initialize the bidi cache start stack pointer.
613 (bidi_cache_ensure_space): New function, refactored from part of
614 bidi_cache_iterator_state. Don't assume the required size is just
615 one BIDI_CACHE_CHUNK away.
616 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
617 (bidi_count_bytes, bidi_char_at_pos): New functions.
618 (bidi_cache_search): Don't assume bidi_cache_last_idx is
619 always valid if bidi_cache_idx is valid.
620 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
621 is valid if it's going to be used.
622 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
623 (bidi_cache_fetch_state, bidi_cache_search)
624 (bidi_cache_find_level_change, bidi_cache_ensure_space)
625 (bidi_cache_iterator_state, bidi_cache_find)
626 (bidi_find_other_level_edge, bidi_cache_start_stack): All
627 variables related to cache indices are now EMACS_INT.
628
629 * dispextern.h (struct bidi_string_data): New structure.
630 (struct bidi_it): New member `string'. Make flag members be 1-bit
631 fields, and put them last in the struct.
632 (compute_display_string_pos, compute_display_string_end): Update
633 prototypes.
634 (bidi_push_it, bidi_pop_it): Add prototypes.
635 (struct iterator_stack_entry): New members bidi_p,
636 paragraph_embedding, and from_disp_prop_p.
637 (struct it): Member bidi_p is now a bit field 1 bit wide.
638 (bidi_shelve_cache, bidi_unshelve_cache): Declare
639 prototypes.
640
641 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
642 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
643 and vector-like objects.
644
645 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
646 cache around display iteration.
647
648 * window.c (Fwindow_end, window_scroll_pixel_based)
649 (displayed_window_lines, Frecenter): Save and restore the bidi
650 cache around display iteration.
651
652 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
653
654 * editfns.c (Fdelete_region): Clarify the use of the named
655 parameters (bug#6788).
656
657 2011-07-14 Martin Rudalics <rudalics@gmx.at>
658
659 * indent.c (Fvertical_motion): Set and restore w->pointm when
660 saving and restoring the window's buffer (Bug#9006).
661
662 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
663
664 * editfns.c (Fstring_to_char): Clarify just what is returned
665 (bug#6576). Text by Eli Zaretskii.
666
667 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
668
669 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
670
671 2011-07-13 Eli Zaretskii <eliz@gnu.org>
672
673 * buffer.c (mmap_find): Fix a typo.
674
675 2011-07-13 Johan Bockgård <bojohan@gnu.org>
676
677 Fix execution of x selection hooks.
678 * xselect.c (Qx_lost_selection_functions)
679 (Qx_sent_selection_functions): New vars.
680 (syms_of_xselect): DEFSYM them.
681 (x_handle_selection_request): Pass Qx_sent_selection_functions
682 rather than Vx_sent_selection_functions to Frun_hook_with_args.
683 (x_handle_selection_clear,x_clear_frame_selections):
684 Pass Qx_lost_selection_functions rather than
685 Vx_lost_selection_functions to Frun_hook_with_args.
686
687 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
688
689 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
690 The old code sometimes used this field without initializing it.
691
692 * alloc.c (gc_sweep): Don't read past end of array.
693 In theory, the old code could also have corrupted Emacs internals,
694 though it'd be very unlikely.
695
696 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
697
698 * character.c (Fcharacterp): Don't advertise optional ignored
699 argument. (Bug#4026)
700
701 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
702
703 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
704 key" (bug#4257).
705
706 * window.c (Fset_window_start): Doc fix (bug#4199).
707 (Fset_window_hscroll): Ditto.
708
709 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
710
711 Fix minor new problems caught by GCC 4.6.1.
712 * term.c (init_tty): Remove unused local.
713 * xsettings.c (store_monospaced_changed): Define this function only
714 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
715 not used otherwise.
716
717 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
718
719 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
720
721 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
722
723 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
724 are the mini-buffer and the echo area (bug#3320).
725
726 * term.c (init_tty): Remove support for supdup, c10 and perq
727 terminals, which are no longer supported (bug#1482).
728
729 2011-07-10 Johan Bockgård <bojohan@gnu.org>
730
731 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
732
733 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
734
735 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
736 for non-popups (Bug#3642).
737
738 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
739
740 * alloc.c (reset_malloc_hooks): Protoize.
741 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
742 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
743 * cm.c (losecursor): Likewise.
744 * data.c (fmod): Likewise.
745 * dispnew.c (swap_glyphs_in_rows): Likewise.
746 * emacs.c (memory_warning_signal): Likewise.
747 * floatfns.c (float_error): Likewise.
748 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
749 (otf_open, font_otf_capability, generate_otf_features)
750 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
751 Likewise.
752 * image.c (pbm_read_file): Likewise.
753 * indent.c (string_display_width): Likewise.
754 * intervals.c (check_for_interval, search_for_interval)
755 (inc_interval_count, count_intervals, root_interval)
756 (adjust_intervals_for_insertion, make_new_interval): Likewise.
757 * lread.c (defalias): Likewise.
758 * ralloc.c (r_alloc_check): Likewise.
759 * regex.c (set_image_of_range_1, set_image_of_range)
760 (regex_grow_registers): Likewise.
761 * sysdep.c (strerror): Likewise.
762 * termcap.c (valid_filename_p, tprint, main): Likewise.
763 * tparam.c (main): Likewise.
764 * unexhp9k800.c (run_time_remap, save_data_space)
765 (update_file_ptrs, read_header, write_header, calculate_checksum)
766 (copy_file, copy_rest, display_header): Likewise.
767 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
768 Likewise.
769 * xdisp.c (check_it): Likewise.
770 * xfaces.c (register_color, unregister_color, unregister_colors):
771 Likewise.
772 * xfns.c (print_fontset_result): Likewise.
773 * xrdb.c (member, fatal, main): Likewise.
774
775 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
776
777 Fix minor problems found by static checking (Bug#9031).
778 * chartab.c (char_table_set_range, map_sub_char_table):
779 Remove unused locals.
780 (uniprop_table): Now static.
781 * composite.c (_work_char): Remove unused static var.
782
783 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
784
785 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
786
787 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
788
789 * gtkutil.c (qttip_cb): Remove code without function.
790
791 2011-07-09 Eli Zaretskii <eliz@gnu.org>
792
793 * w32.c (pthread_sigmask): New stub.
794
795 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
796
797 Use pthread_sigmask, not sigprocmask (Bug#9010).
798 sigprocmask is portable only for single-threaded applications, and
799 Emacs can be multi-threaded when it uses GTK.
800 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
801 (LIBES): Use it.
802 * callproc.c (Fcall_process):
803 * process.c (create_process):
804 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
805 Use pthread_sigmask, not sigprocmask.
806
807 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
808
809 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
810 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
811 wrong (Bug#8591).
812
813 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
814
815 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
816 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
817 (xg_hide_tooltip): Fix comment.
818
819 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
820 in registerServicesMenuSendTypes.
821 (validRequestorForSendType): Don't check ns_return_types.
822
823 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
824 ns_return_type.
825
826 2011-07-08 Jason Rumney <jasonr@gnu.org>
827
828 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
829 frame struct members of non-existent frames (Bug#6284).
830
831 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
832
833 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
834 variable firstTime not needed on OSX >= 10.6.
835 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
836 >= 10.5. Use setKnobProportion, setDoubleValue.
837
838 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
839 (MAC_OS_X_VERSION_10_5): Define if not defined.
840 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
841 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
842 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
843
844 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
845 cString and lossyCString on OSX >= 10.4
846
847 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
848 sizeToFit on OSX >= 10.2.
849
850 * nsimage.m (allocInitFromFile): Don't use deprecated method
851 bestRepresentationForDevice on OSX >= 10.6.
852
853 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
854 to avoid warning.
855
856 * emacs.c: Declare unexec_init_emacs_zone.
857
858 * nsgui.h: Fix compiler warning about gnulib redefining verify.
859
860 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
861
862 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
863 on svcsMenu (Bug#8842).
864
865 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
866 ns_return_types.
867 (Fns_list_services): Just return Qnil on 10.6, code not working there.
868
869 * nsterm.m (QUTF8_STRING): Declare.
870 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
871 (validRequestorForSendType): Return type is (id).
872 Change indexOfObjectIdenticalTo to indexOfObject.
873 Check if we have local selection before returning self (Bug#8842).
874 (writeSelectionToPasteboard): Put local selection into paste board
875 if we have a local selection (Bug#8842).
876 (syms_of_nsterm): DEFSYM QUTF8_STRING.
877
878 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
879 (ns_get_local_selection): Declare.
880
881 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
882
883 * keymap.c (describe_map_tree): Don't insert a double newline at
884 the end of the buffer (bug#1169) and return whether we inserted
885 something.
886
887 * callint.c (Fcall_interactively): Change "reading args" to
888 "providing args" to try to clarify what it does (bug#1010).
889
890 2011-07-07 Kenichi Handa <handa@m17n.org>
891
892 * composite.c (composition_compute_stop_pos): Ignore a static
893 composition starting before CHARPOS (Bug#8915).
894
895 * xdisp.c (handle_composition_prop): Likewise.
896
897 2011-07-07 Eli Zaretskii <eliz@gnu.org>
898
899 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
900 (Bug#9015)
901
902 2011-07-07 Kenichi Handa <handa@m17n.org>
903
904 * character.h (unicode_category_t): New enum type.
905
906 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
907 (Qchar_code_property_table): New variable.
908 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
909 (UNIPROP_COMPRESSED_FORM_P): New macros.
910 (char_table_ascii): Uncompress the compressed values.
911 (sub_char_table_ref): New arg is_uniprop. Callers changed.
912 Uncompress the compressed values.
913 (sub_char_table_ref_and_range): Likewise.
914 (char_table_ref_and_range): Uncompress the compressed values.
915 (sub_char_table_set): New arg is_uniprop. Callers changed.
916 Uncompress the compressed values.
917 (sub_char_table_set_range): Args changed. Callers changed.
918 (char_table_set_range): Adjuted for the above change.
919 (map_sub_char_table): Delete args default_val and parent. Add arg
920 top. Give decoded values to a Lisp function.
921 (map_char_table): Adjusted for the above change. Give decoded
922 values to a Lisp function. Gcpro more variables.
923 (uniprop_table_uncompress)
924 (uniprop_decode_value_run_length): New functions.
925 (uniprop_decoder, uniprop_decoder_count): New variables.
926 (uniprop_get_decoder, uniprop_encode_value_character)
927 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
928 New functions.
929 (uniprop_encoder, uniprop_encoder_count): New variables.
930 (uniprop_get_encoder, uniprop_table)
931 (Funicode_property_table_internal, Fget_unicode_property_internal)
932 (Fput_unicode_property_internal): New functions.
933 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
934 Sunicode_property_table_internal, Sget_unicode_property_internal,
935 and Sput_unicode_property_internal. Defvar_lisp
936 char-code-property-alist.
937
938 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
939 Vunicode_category_table.
940
941 * font.c (font_range): Adjusted for the change of
942 Vunicode_category_table.
943
944 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
945
946 * m/iris4d.h: Remove file, move contents ...
947 * s/irix6-5.h: ... here.
948
949 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
950
951 Remove unportable assumption about struct layout (Bug#8884).
952 * alloc.c (mark_buffer):
953 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
954 (clone_per_buffer_values): Don't assume that
955 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
956 This isn't true in general, and it's particularly not true
957 if Emacs is configured with --with-wide-int.
958 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
959 New macros, used in the buffer.c change.
960
961 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
962
963 * xsettings.c: Use both GConf and GSettings if both are available.
964 (store_config_changed_event): Add comment.
965 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
966 (store_tool_bar_style_changed): New functions.
967 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
968 (struct xsettings): Move font inside HAVE_XFT.
969 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
970 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
971 Move inside HAVE_XFT.
972 (something_changed_gsettingsCB): Renamed from something_changedCB.
973 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
974 also.
975 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
976 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
977 (something_changed_gconfCB): Renamed from something_changedCB.
978 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
979 (parse_settings): Move check for font inside HAVE_XFT.
980 (read_settings, apply_xft_settings): Add comment.
981 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
982 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
983 call store_font_name_changed.
984 (xft_settings_event): Add comment.
985 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
986 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
987 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
988 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
989 (xsettings_initialize): Call init_gsettings last.
990 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
991 comment.
992
993 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
994
995 Random fixes. E.g., (random) never returned negative values.
996 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
997 subseconds part to the entropy, as that's a bit more random.
998 Prefer signed to unsigned, since the signedness doesn't matter and
999 in general we prefer signed. When given a limit, use a
1000 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1001 latter isn't right if USE_2_TAGS_FOR_INTS.
1002 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1003 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1004
1005 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1006
1007 * textprop.c (text_property_stickiness):
1008 Obey Vtext_property_default_nonsticky.
1009 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1010 * w32fns.c (syms_of_w32fns):
1011 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1012
1013 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1014
1015 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1016 This is more efficient than Ffile_directory_p and avoids a minor race.
1017
1018 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1019
1020 * buffer.c (Foverlay_put): Say what the return value is
1021 (bug#7835).
1022
1023 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1024 is a directory before asking whether to use the file name
1025 (bug#7564).
1026 (barf_or_query_if_file_exists): Make the "File is a directory"
1027 error be more correct.
1028
1029 * fns.c (Frequire): Remove the mention of the .gz files, since
1030 that's installation-specific, but keep the mention of
1031 `get-load-suffixes'.
1032
1033 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1034
1035 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1036 Report string overflow if the output is too long.
1037
1038 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1039
1040 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1041 (syms_of_gnutls): Remove duplicate DEFSYM for
1042 Qgnutls_bootprop_verify_hostname_error, an error for
1043 Qgnutls_bootprop_verify_error (which is no longer used).
1044
1045 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1046 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1047 Also (re)move comments that are misplaced or no longer relevant.
1048
1049 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1050
1051 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1052
1053 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1054
1055 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1056 and background color parameters if they have been changed.
1057
1058 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1059
1060 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1061
1062 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1063
1064 * xsettings.c (SYSTEM_FONT): Define only when used.
1065 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1066
1067 * keymap.c (access_keymap_1): Now static.
1068
1069 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1070
1071 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1072 leave any prefix arg for the up event (Bug#1586).
1073
1074 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1075
1076 * lread.c (syms_of_lread): Mention single symbols defined by
1077 `defvar' or `defconst' (bug#7154).
1078
1079 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1080 (Frequire): Mention get-load-suffixes.
1081
1082 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1083
1084 * window.h (window): Remove clone_number slot.
1085 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1086 Remove.
1087 (make_parent_window, make_window, saved_window)
1088 (Fset_window_configuration, save_window_save): Don't deal with
1089 clone numbers.
1090 * buffer.c (Qclone_number): Remove declaration.
1091 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1092
1093 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1094
1095 Add multiple inheritance to keymaps.
1096 * keymap.c (Fmake_composed_keymap): New function.
1097 (Fset_keymap_parent): Simplify.
1098 (fix_submap_inheritance): Remove.
1099 (access_keymap_1): New function extracted from access_keymap to handle
1100 embedded parents and handle lists of maps.
1101 (access_keymap): Use it.
1102 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1103 (Fcopy_keymap): Handle embedded parents.
1104 (Fcommand_remapping, define_as_prefix): Simplify.
1105 (Fkey_binding): Simplify.
1106 (syms_of_keymap): Move minibuffer-local-completion-map,
1107 minibuffer-local-filename-completion-map,
1108 minibuffer-local-must-match-map, and
1109 minibuffer-local-filename-must-match-map to Elisp.
1110 (syms_of_keymap): Defsubr make-composed-keymap.
1111 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1112 (parse_menu_item): Trivial simplification.
1113
1114 2011-07-01 Glenn Morris <rgm@gnu.org>
1115
1116 * Makefile.in (SETTINGS_LIBS): Fix typo.
1117
1118 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1119
1120 * coding.c (Fencode_coding_string): Record the last coding system
1121 used, as the function doc string says (bug#8738).
1122
1123 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1124
1125 * xsettings.c (store_monospaced_changed): Take new font as arg and
1126 check for change against current_mono_font.
1127 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1128 (emacs_settings_constructor, emacs_settings_get_property)
1129 (emacs_settings_set_property, emacs_settings_class_init)
1130 (emacs_settings_init, gsettings_obj): Remove.
1131 (something_changedCB): New function for HAVE_GSETTINGS.
1132 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1133 with value as argument.
1134 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1135 g_settings_new (Bug#8967). Do not create gsettings_obj.
1136 Remove calls to g_settings_bind. Connect something_changedCB to
1137 "changed".
1138
1139 * xgselect.c: Add defined (HAVE_GSETTINGS).
1140 (xgselect_initialize): Ditto.
1141
1142 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1143 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1144 xg_select.
1145
1146 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1147
1148 * eval.c (struct backtrace): Simplify and port the data structure.
1149 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1150 signed bit field, as this assumption is not portable and it makes
1151 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1152 "char debug_on_exit : 1" as this is not portable either; instead,
1153 use the portable "unsigned int debug_on_exit : 1". Remove unused
1154 member evalargs. Remove obsolete comments about cc bombing out.
1155
1156 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1157
1158 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1159 Let HAVE_GSETTINGS override HAVE_GCONF.
1160 (store_monospaced_changed): New function.
1161 (EMACS_SETTINGS): A new type derived from GObject to handle
1162 GSettings notifications.
1163 (emacs_settings_constructor, emacs_settings_get_property)
1164 (emacs_settings_set_property, emacs_settings_class_init):
1165 New functions.
1166 (gsettings_client, gsettings_obj): New variables.
1167 (GSETTINGS_SCHEMA): New define.
1168 (something_changedCB): Call store_monospaced_changed.
1169 (init_gsettings): New function.
1170 (xsettings_initialize): Call init_gsettings.
1171 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1172 to NULL.
1173
1174 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
1175 GCONF_CFLAGS/LIBS.
1176
1177 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1178
1179 * window.c (resize_root_window, grow_mini_window)
1180 (shrink_mini_window): Rename Qresize_root_window to
1181 Qwindow_resize_root_window and Qresize_root_window_vertically to
1182 Qwindow_resize_root_window_vertically.
1183
1184 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1185
1186 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1187
1188 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1189
1190 * makefile.w32-in: Redesign dependencies so they reflect more
1191 clearly which files are directly included by each source file,
1192 and not through other includes.
1193
1194 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1195
1196 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1197 (sort_overlays, overlay_strings): When an overlay's clone number
1198 matches the window's clone number process the overlay even if
1199 the overlay's window property doesn't match the current window.
1200
1201 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1202 (Fwindow_hchild): Rename to Fwindow_left_child.
1203 (Fwindow_next): Rename to Fwindow_next_sibling.
1204 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1205 (resize_window_check): Rename to window_resize_check.
1206 (resize_window_apply): Rename to window_resize_apply.
1207 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1208 (Fdelete_other_windows_internal, resize_frame_windows)
1209 (Fsplit_window_internal, Fdelete_window_internal)
1210 (grow_mini_window, shrink_mini_window)
1211 (Fresize_mini_window_internal): Fix callers accordingly.
1212
1213 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1214
1215 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1216 (emacs_fixed_set_min_size): Remove.
1217 (emacs_fixed_new): Take frame as argument.
1218
1219 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1220 (_EmacsFixedPrivate): Remove minwidth/height.
1221 Add struct frame *f.
1222 (emacs_fixed_init): Initialize priv->f.
1223 (get_parent_class, emacs_fixed_set_min_size): Remove.
1224 (emacs_fixed_new): Set priv->f to argument.
1225 (emacs_fixed_get_preferred_width)
1226 (emacs_fixed_get_preferred_height): Use min_width/height from
1227 frames size_hint to set minimum and natural (Bug#8919).
1228 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1229 and use min_width/height from frames size_hint to set
1230 min_width/height (Bug#8919).
1231
1232 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1233 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1234 Fix indentation.
1235
1236 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1237
1238 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1239 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1240 called at ZV.
1241
1242 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1243
1244 * process.c (wait_reading_process_output): Bypass select if
1245 waiting for a cell while ignoring keyboard input, and input is
1246 pending. Suggested by Jan Djärv (Bug#8869).
1247
1248 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1249
1250 Use gnulib's dup2 module instead of rolling our own.
1251 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1252
1253 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1254
1255 * dispnew.c (scrolling_window): Before scrolling, turn off a
1256 mouse-highlight in the window being scrolled.
1257
1258 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1259
1260 Move DEFSYM to lisp.h and use everywhere.
1261
1262 * character.h (DEFSYM): Move declaration...
1263 * lisp.h (DEFSYM): ...here.
1264
1265 * gnutls.c:
1266 * minibuf.c:
1267 * w32menu.c:
1268 * w32proc.c:
1269 * w32select.c: Don't include character.h.
1270
1271 * alloc.c (syms_of_alloc):
1272 * buffer.c (syms_of_buffer):
1273 * bytecode.c (syms_of_bytecode):
1274 * callint.c (syms_of_callint):
1275 * casefiddle.c (syms_of_casefiddle):
1276 * casetab.c (init_casetab_once):
1277 * category.c (init_category_once, syms_of_category):
1278 * ccl.c (syms_of_ccl):
1279 * cmds.c (syms_of_cmds):
1280 * composite.c (syms_of_composite):
1281 * dbusbind.c (syms_of_dbusbind):
1282 * dired.c (syms_of_dired):
1283 * dispnew.c (syms_of_display):
1284 * doc.c (syms_of_doc):
1285 * editfns.c (syms_of_editfns):
1286 * emacs.c (syms_of_emacs):
1287 * eval.c (syms_of_eval):
1288 * fileio.c (syms_of_fileio):
1289 * fns.c (syms_of_fns):
1290 * frame.c (syms_of_frame):
1291 * fringe.c (syms_of_fringe):
1292 * insdel.c (syms_of_insdel):
1293 * keymap.c (syms_of_keymap):
1294 * lread.c (init_obarray, syms_of_lread):
1295 * macros.c (syms_of_macros):
1296 * msdos.c (syms_of_msdos):
1297 * print.c (syms_of_print):
1298 * process.c (syms_of_process):
1299 * search.c (syms_of_search):
1300 * sound.c (syms_of_sound):
1301 * syntax.c (init_syntax_once, syms_of_syntax):
1302 * terminal.c (syms_of_terminal):
1303 * textprop.c (syms_of_textprop):
1304 * undo.c (syms_of_undo):
1305 * w32.c (globals_of_w32):
1306 * window.c (syms_of_window):
1307 * xdisp.c (syms_of_xdisp):
1308 * xfaces.c (syms_of_xfaces):
1309 * xfns.c (syms_of_xfns):
1310 * xmenu.c (syms_of_xmenu):
1311 * xsettings.c (syms_of_xsettings):
1312 * xterm.c (syms_of_xterm): Use DEFSYM.
1313
1314 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1315
1316 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1317
1318 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1319
1320 Integer and buffer overflow fixes (Bug#8873).
1321
1322 * print.c (printchar, strout): Check for string overflow.
1323 (PRINTPREPARE, printchar, strout):
1324 Don't set size unless allocation succeeds.
1325
1326 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1327 for sizes. Check for string overflow more accurately.
1328 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1329
1330 * macros.c: Integer and buffer overflow fixes.
1331 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1332 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1333 Use ptrdiff_t, not int, for sizes.
1334 Don't increment bufsize until after realloc succeeds.
1335 Check for size-calculation overflow.
1336 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1337
1338 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1339
1340 * lread.c: Integer overflow fixes.
1341 (read_integer): Radix is now EMACS_INT, not int,
1342 to improve quality of diagnostics for out-of-range radices.
1343 Calculate buffer size correctly for out-of-range radices.
1344 (read1): Check for integer overflow in radices, and in
1345 read-circle numbers.
1346 (read_escape): Avoid int overflow.
1347 (Fload, openp, read_buffer_size, read1)
1348 (substitute_object_recurse, read_vector, read_list, map_obarray):
1349 Use ptrdiff_t, not int, for sizes.
1350 (read1): Use EMACS_INT, not int, for sizes.
1351 Check for size overflow.
1352
1353 * image.c (cache_image): Check for size arithmetic overflow.
1354
1355 * lread.c: Integer overflow issues.
1356 (saved_doc_string_size, saved_doc_string_length)
1357 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1358 Now ptrdiff_t, not int.
1359 (read1): Don't assume doc string length fits in int. Check for
1360 out-of-range doc string lengths.
1361 (read_list): Don't assume file position fits in int.
1362 (read_escape): Check for hex character overflow.
1363
1364 2011-06-22 Leo Liu <sdl.web@gmail.com>
1365
1366 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1367 Move to minibuffer.el.
1368
1369 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1370
1371 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1372 The following patches are for when GLYPH_DEBUG && !XASSERT.
1373 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1374 * dispnew.c (flush_stdout):
1375 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1376 Mark as externally visible.
1377 * dispnew.c (check_window_matrix_pointers): Now static.
1378 * dispnew.c (window_to_frame_vpos):
1379 * xfns.c (unwind_create_frame):
1380 * xterm.c (x_check_font): Remove unused local.
1381 * scroll.c (CHECK_BOUNDS):
1382 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1383 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1384 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1385 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1386 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1387 Now static.
1388 (debug_method_add): Use va_list and vsprintf rather than relying
1389 on undefined behavior with wrong number of arguments.
1390 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1391 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1392 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1393 since we're not interested in debugging glyphs with old libraries.
1394 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1395 GCC 4.6.0's static checking.
1396
1397 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1398
1399 Integer overflow and signedness fixes (Bug#8873).
1400 A few related buffer overrun fixes, too.
1401
1402 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1403
1404 * dispextern.h (struct face.stipple):
1405 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1406 (x_bitmap_mask, x_allocate_bitmap_record)
1407 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1408 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1409 (x_create_bitmap_from_xpm_data):
1410 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1411 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1412 (.bitmaps_last):
1413 * xfaces.c (load_pixmap):
1414 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1415 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1416 (.bitmaps_last, struct x_output.icon_bitmap):
1417 Use ptrdiff_t, not int, for bitmap indexes.
1418 (x_allocate_bitmap_record): Check for size overflow.
1419 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1420
1421 Use ptrdiff_t, not int, for overlay counts.
1422 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1423 * editfns.c (overlays_around, get_pos_property):
1424 * textprop.c (get_char_property_and_overlay):
1425 * xdisp.c (next_overlay_change, note_mouse_highlight):
1426 * xfaces.c (face_at_buffer_position):
1427 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1428 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1429 (Fnext_overlay_change, Fprevious_overlay_change)
1430 (mouse_face_overlay_overlaps, Foverlays_in):
1431 Use ptrdiff_t, not int, for sizes.
1432 (overlays_at, overlays_in): Check for size-calculation overflow.
1433
1434 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1435
1436 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1437 (x_session_initialize): Do not assume string length fits in int.
1438
1439 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1440 This is unlikely, but can occur if DPI is outlandish.
1441
1442 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1443 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1444
1445 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1446 * xrdb.c (magic_file_p, search_magic_path):
1447 Omit last arg SUFFIX; it was always 0. All callers changed.
1448 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1449
1450 * xfont.c (xfont_match): Avoid need for strlen.
1451
1452 * xfns.c: Don't assume strlen fits in int.
1453 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1454
1455 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1456 not unsigned long, as we prefer signed integers. All callers changed.
1457 Detect integer overflow in repeat count.
1458 (message_dolog): Don't assume print length fits in 39 bytes.
1459 (display_mode_element): Don't assume strlen fits in int.
1460
1461 * termcap.c: Don't assume sizes fit in int and never overflow.
1462 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1463 (gobble_line): Check for size-calculation overflow.
1464
1465 * minibuf.c (Fread_buffer):
1466 * lread.c (intern, intern_c_string):
1467 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1468 Don't assume string length fits in int.
1469
1470 * keyboard.c (parse_tool_bar_item):
1471 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1472
1473 * font.c: Don't assume string length fits in int.
1474 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1475 Use ptrdiff_t, not int.
1476 (font_intern_prop): Don't assume string length fits in int.
1477 Don't assume integer property fits in fixnum.
1478 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1479
1480 * filelock.c: Fix some buffer overrun and integer overflow issues.
1481 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1482 Reformulate so as not to need the command string.
1483 Invoke gzip -cd rather than gunzip, as it's more portable.
1484 (lock_info_type, lock_file_1, lock_file):
1485 Don't assume pid_t and time_t fit in unsigned long.
1486 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1487 (current_lock_owner): Prefer signed type for sizes.
1488 Use memcpy, not strncpy, where memcpy is what is really wanted.
1489 Don't assume (via atoi) that time_t and pid_t fit in int.
1490 Check for time_t and/or pid_t out of range, e.g., via a network share.
1491 Don't alloca where an auto var works fine.
1492
1493 * fileio.c: Fix some integer overflow issues.
1494 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1495 Don't assume string length fits in int.
1496 (directory_file_name): Don't assume string length fits in long.
1497 (make_temp_name): Don't assume pid fits in int, or that its print
1498 length is less than 20.
1499
1500 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1501
1502 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1503
1504 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1505
1506 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1507 We prefer signed integers, even for size calculations.
1508
1509 * emacs.c: Don't assume string length fits in 'int'.
1510 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1511 (main): Don't invoke strlen when not needed.
1512
1513 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1514 (XD_DEBUG_MESSAGE): Don't waste a byte.
1515
1516 * callproc.c (getenv_internal_1, getenv_internal)
1517 (Fgetenv_internal):
1518 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1519
1520 * lread.c (invalid_syntax): Omit length argument.
1521 All uses changed. This doesn't fix a bug, but it simplifies the
1522 code away from its former Hollerith-constant appearance, and it's
1523 one less 'int' to worry about when looking at integer-overflow issues.
1524 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1525
1526 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1527 This didn't break anything, but it didn't help either.
1528 It's confusing to put a bogus integer in a place where the actual
1529 value does not matter.
1530 (LIST_END_P): Remove unused macro and its bogus comment.
1531 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1532
1533 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1534 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1535 implementation.
1536 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1537 We prefer signed types, and the value cannot exceed the EMACS_INT
1538 range anyway (because otherwise the length would not be representable).
1539 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1540 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1541 This avoids a GCC warning when WIDE_EMACS_INT.
1542
1543 * indent.c (sane_tab_width): New function.
1544 (current_column, scan_for_column, Findent_to, position_indentation)
1545 (compute_motion): Use it. This is just for clarity.
1546 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1547
1548 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1549
1550 * lisp.h (lint_assume): New macro.
1551 * composite.c (composition_gstring_put_cache):
1552 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1553
1554 * editfns.c, insdel.c:
1555 Omit unnecessary forward decls, to simplify future changes.
1556
1557 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1558
1559 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1560
1561 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1562 Use much-faster test for byte-length change.
1563 Don't assume string byte-length fits in 'int'.
1564 Check that character arg fits in 'int'.
1565 (mapcar1): Declare byte as byte, for clarity.
1566
1567 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1568
1569 * fns.c (concat): Catch string overflow earlier.
1570 Do not rely on integer wraparound.
1571
1572 * dispextern.h (struct it.overlay_strings_charpos)
1573 (struct it.selective): Now EMACS_INT, not int.
1574 * xdisp.c (forward_to_next_line_start)
1575 (back_to_previous_visible_line_start)
1576 (reseat_at_next_visible_line_start, next_element_from_buffer):
1577 Don't arbitrarily truncate the value of 'selective' to int.
1578
1579 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1580
1581 * composite.c: Don't truncate sizes to 'int'.
1582 (composition_gstring_p, composition_reseat_it)
1583 (composition_adjust_point): Use EMACS_INT, not int.
1584 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1585 not EMACS_UINT, for indexes.
1586
1587 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1588
1589 * buffer.c: Include <verify.h>.
1590 (struct sortvec.priority, struct sortstr.priority):
1591 Now EMACS_INT, not int.
1592 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1593 (struct sortstr.size, record_overlay_string)
1594 (struct sortstrlist.size, struct sortlist.used):
1595 Don't truncate size to int.
1596 (record_overlay_string): Check for size-calculation overflow.
1597 (init_buffer_once): Check at compile-time, not run-time.
1598
1599 2011-06-22 Jim Meyering <meyering@redhat.com>
1600
1601 Don't leak an XBM-image-sized buffer
1602 * image.c (xbm_load): Free the image buffer after using it.
1603
1604 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1605
1606 Port to Sun C.
1607 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1608 that Sun C diagnosed.
1609 * fns.c (secure_hash): Fix pointer signedness issue.
1610 * intervals.c (static_offset_intervals): New function.
1611 (offset_intervals): Use it.
1612
1613 2011-06-21 Leo Liu <sdl.web@gmail.com>
1614
1615 * deps.mk (fns.o):
1616 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1617 sha512.h.
1618
1619 * fns.c (secure_hash): Rename from crypto_hash_function and change
1620 the first arg to accept symbols.
1621 (Fsecure_hash): New primitive.
1622 (syms_of_fns): New symbols.
1623
1624 2011-06-20 Deniz Dogan <deniz@dogan.se>
1625
1626 * process.c (Fset_process_buffer): Clarify return value in
1627 docstring.
1628
1629 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1630
1631 * dispnew.c (add_window_display_history): Use BVAR.
1632
1633 * xdisp.c (debug_method_add): Use BVAR.
1634 (check_window_end, dump_glyph_matrix, dump_glyph)
1635 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1636
1637 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1638 Likewise.
1639
1640 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1641 check till after the cache is created in init_frame_faces.
1642
1643 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1644
1645 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1646
1647 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1648
1649 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1650 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1651 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1652
1653 Improve buffer-overflow checking (Bug#8873).
1654 * fileio.c (Finsert_file_contents):
1655 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1656 Remove the old (too-loose) buffer overflow checks.
1657 They weren't needed, since make_gap checks for buffer overflow.
1658 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1659 The old code merely checked for Emacs fixnum overflow, and relied
1660 on undefined (wraparound) behavior. The new code avoids undefined
1661 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1662
1663 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1664 Tune. Don't use wider integers than needed. Don't use alloca.
1665 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1666
1667 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1668
1669 * insdel.c, lisp.h (buffer_overflow): New function.
1670 (insert_from_buffer_1, replace_range, replace_range_2):
1671 * insdel.c (make_gap_larger):
1672 * editfns.c (Finsert_char):
1673 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1674
1675 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1676
1677 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1678
1679 Integer overflow and signedness fixes (Bug#8873).
1680
1681 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1682 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1683
1684 * fileio.c: Don't assume EMACS_INT fits in off_t.
1685 (emacs_lseek): New static function.
1686 (Finsert_file_contents, Fwrite_region): Use it.
1687 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1688
1689 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1690
1691 * fns.c: Don't overflow int when computing a list length.
1692 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1693 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1694 truncation on 64-bit hosts. Check for QUIT every
1695 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1696 faster and is responsive enough.
1697 (Flength): Report an error instead of overflowing an integer.
1698 (Fsafe_length): Return a float if the value is not representable
1699 as a fixnum. This shouldn't happen except in contrived situations.
1700 (Fnthcdr, Fsort): Don't assume list length fits in int.
1701 (Fcopy_sequence): Don't assume vector length fits in int.
1702
1703 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1704 (header_size, word_size): New constants.
1705 (allocate_vectorlike): Don't check size overflow here.
1706 (allocate_vector): Check it here instead, since this is the only
1707 caller of allocate_vectorlike that could cause overflow.
1708 Check that the new vector's length is representable as a fixnum.
1709
1710 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1711 The previous code was bogus. For example, next_almost_prime (32)
1712 returned 39, which is undesirable as it is a multiple of 3; and
1713 next_almost_prime (24) returned 25, which is a multiple of 5 so
1714 why was the code bothering to check for multiples of 7?
1715
1716 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1717
1718 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1719
1720 Variadic C functions now count arguments with ptrdiff_t.
1721 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1722 Back then I didn't know that the Emacs coding style prefers signed int.
1723 Also, in the meantime I found a few more instances where arguments
1724 were being counted with int, which may truncate counts on 64-bit
1725 machines, or EMACS_INT, which may be unnecessarily wide.
1726 * lisp.h (struct Lisp_Subr.function.aMANY)
1727 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1728 Arg counts are now ptrdiff_t, not size_t.
1729 All variadic functions and their callers changed accordingly.
1730 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1731 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1732 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1733 * callint.c (Fcall_interactively): Check arg count for overflow,
1734 to avoid potential buffer overrun. Use signed char, not 'int',
1735 for 'varies' array, so that we needn't bother to check its size
1736 calculation for overflow.
1737 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1738 * eval.c (apply_lambda):
1739 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1740 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1741 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1742
1743 * callint.c (Fcall_interactively): Don't use index var as event count.
1744
1745 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1746 * mem-limits.h (SIZE): Remove; no longer used.
1747
1748 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1749
1750 Remove unnecessary casts.
1751 * xterm.c (x_term_init):
1752 * xfns.c (x_set_border_pixel):
1753 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1754 These aren't needed now that we assume ANSI C.
1755
1756 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1757 It's more likely to cause problems (due to unsigned overflow)
1758 than to cure them.
1759
1760 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1761
1762 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1763
1764 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1765
1766 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1767
1768 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1769
1770 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1771
1772 GLYPH_CODE_FACE returns EMACS_INT, not int.
1773 * dispextern.h (merge_faces):
1774 * xfaces.c (merge_faces):
1775 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1776 Don't assume EMACS_INT fits in int.
1777
1778 * character.h (CHAR_VALID_P): Remove unused parameter.
1779 * fontset.c, lisp.h, xdisp.c: All uses changed.
1780
1781 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1782
1783 * fns.c (concat): Minor tuning based on overflow analysis.
1784 This doesn't fix any bugs. Use int to hold character, instead
1785 of constantly refetching from Emacs object. Use XFASTINT, not
1786 XINT, for value known to be a character. Don't bother comparing
1787 a single byte to 0400, as it's always less.
1788
1789 * floatfns.c (Fexpt):
1790 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1791
1792 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1793 for characters.
1794
1795 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1796
1797 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1798 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1799 incorrectly succeed when S was a string, because 4294967386 was
1800 truncated before it was used.
1801
1802 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1803 Otherwise, an out-of-range integer could cause undefined behavior
1804 on a 64-bit host.
1805
1806 * composite.c: Use int, not EMACS_INT, for characters.
1807 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1808 EMACS_INT, for values that are known to be in character range.
1809 This doesn't fix any bugs but is the usual style inside Emacs and
1810 may generate better code on 32-bit machines.
1811
1812 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1813 This is for reasons similar to the recent CHAR_STRING fix.
1814 * charset.c (Fencode_char): Check that character arg is actually
1815 a character. Pass an int to ENCODE_CHAR.
1816 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1817 wider than 'int', as a compile-time check to prevent future regressions
1818 in this area.
1819
1820 * character.c (char_string): Remove unnecessary casts.
1821
1822 Make sure a 64-bit char is never passed to CHAR_STRING.
1823 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1824 by silently ignoring the top 32 bits, allowing some values
1825 that were far too large to be valid characters.
1826 * character.h: Include <verify.h>.
1827 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1828 arguments are no wider than unsigned, as a compile-time check
1829 to prevent future regressions in this area.
1830 * data.c (Faset):
1831 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1832 (Fsubst_char_in_region):
1833 * fns.c (concat):
1834 * xdisp.c (decode_mode_spec_coding):
1835 Adjust to CHAR_STRING's new requirement.
1836 * editfns.c (Finsert_char, Fsubst_char_in_region):
1837 * fns.c (concat): Check that character args are actually
1838 characters. Without this test, these functions did the wrong
1839 thing with wildly out-of-range values on 64-bit hosts.
1840
1841 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1842 These casts should not be needed on 32-bit hosts, either.
1843 * keyboard.c (read_char):
1844 * lread.c (Fload): Remove casts to unsigned.
1845
1846 * lisp.h (UNSIGNED_CMP): New macro.
1847 This fixes comparison bugs on 64-bit hosts.
1848 (ASCII_CHAR_P): Use it.
1849 * casefiddle.c (casify_object):
1850 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1851 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1852 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1853 * dispextern.h (FACE_FROM_ID):
1854 * keyboard.c (read_char): Use UNSIGNED_CMP.
1855
1856 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1857 not to EMACS_INT, to avoid GCC warning.
1858
1859 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1860
1861 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1862 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1863 isn't needed on 32-bit machines.
1864
1865 * buffer.c (Fgenerate_new_buffer_name):
1866 Use EMACS_INT for count, not int.
1867 (advance_to_char_boundary): Return EMACS_INT, not int.
1868
1869 * data.c (Qcompiled_function): Now static.
1870
1871 * window.c (window_body_lines): Now static.
1872
1873 * image.c (gif_load): Rename local to avoid shadowing.
1874
1875 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1876 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1877 * alloc.c (make_save_value): Integer argument is now of type
1878 ptrdiff_t, not int.
1879 (mark_object): Use ptrdiff_t, not int.
1880 * lisp.h (pD): New macro.
1881 * print.c (print_object): Use it.
1882
1883 * alloc.c: Use EMACS_INT, not int, to count objects.
1884 (total_conses, total_markers, total_symbols, total_vector_size)
1885 (total_free_conses, total_free_markers, total_free_symbols)
1886 (total_free_floats, total_floats, total_free_intervals)
1887 (total_intervals, total_strings, total_free_strings):
1888 Now EMACS_INT, not int. All uses changed.
1889 (Fgarbage_collect): Compute overall total using a double, so that
1890 integer overflow is less likely to be a problem. Check for overflow
1891 when converting back to an integer.
1892 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1893 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1894 These were 'int' variables that could overflow on 64-bit hosts;
1895 they were never used, so remove them instead of repairing them.
1896 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
1897 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1898 Previously, this ceilinged at INT_MAX, but that doesn't work on
1899 64-bit machines.
1900 (allocate_pseudovector): Don't use EMACS_INT when int would do.
1901
1902 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
1903 (allocate_vectorlike): Check for ptrdiff_t overflow.
1904 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1905 when a (possibly-narrower) signed value would do just as well.
1906 We prefer using signed arithmetic, to avoid comparison confusion.
1907
1908 * alloc.c: Catch some string size overflows that we were missing.
1909 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1910 for convenience in STRING_BYTES_MAX.
1911 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1912 The definition here is exact; the one in lisp.h was approximate.
1913 (allocate_string_data): Check for string overflow. This catches
1914 some instances we weren't catching before. Also, it catches
1915 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1916 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1917 and ptrdiff_t and EMACS_INT are both 64 bits.
1918
1919 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1920 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1921 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1922
1923 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1924
1925 * alloc.c (Fmake_string): Check for out-of-range init.
1926
1927 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1928
1929 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1930
1931 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1932
1933 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1934 xg_get_default_scrollbar_width.
1935
1936 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1937 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1938 (style_changed_cb): Call update_theme_scrollbar_width and call
1939 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1940 all frames (Bug#8505).
1941 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1942 Call gtk_window_set_resizable if HAVE_GTK3.
1943 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1944 and height if HAVE_GTK3 (Bug#8505).
1945 (scroll_bar_width_for_theme): New variable.
1946 (update_theme_scrollbar_width): New function.
1947 (xg_get_default_scrollbar_width): Move code to
1948 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1949 (xg_initialize): Call update_theme_scrollbar_width.
1950
1951 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1952
1953 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1954
1955 2011-06-12 Martin Rudalics <rudalics@gmx.at>
1956
1957 * frame.c (make_frame): Call other_buffer_safely instead of
1958 other_buffer.
1959
1960 * window.c (temp_output_buffer_show): Call display_buffer with
1961 second argument Vtemp_buffer_show_specifiers and reset latter
1962 immediately after the call.
1963 (Vtemp_buffer_show_specifiers): New variable.
1964 (auto_window_vscroll_p, next_screen_context_lines)
1965 (Vscroll_preserve_screen_position): Remove leading asterisks from
1966 doc-strings.
1967
1968 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
1969
1970 Fix minor problems found by GCC 4.6.0 static checking.
1971 * buffer.c (Qclone_number): Remove for now, as it's unused.
1972 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1973 (record_buffer): Remove unused local.
1974 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1975 (set_frame_buffer_list): Remove; unused.
1976 * frame.h (other_visible_frames): Remove decl.
1977 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1978 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1979 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1980 if HAVE_GPM.
1981 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1982 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1983 Define only if HAVE_GPM.
1984 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1985 (update_hints_inhibit): Remove; never set. All uses removed.
1986 * widgetprv.h (emacsFrameClassRec): Remove decl.
1987 * window.c (delete_deletable_window): Now returns void, since it
1988 wasn't returning anything.
1989 (compare_window_configurations): Remove unused locals.
1990 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1991 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
1992 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1993 the same widths as pointers. This follows up on the 2011-05-06 patch.
1994 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1995 * xterm.h: Likewise.
1996 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1997
1998 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
1999
2000 * makefile.w32-in: Update dependencies.
2001 (LISP_H): Add lib/intprops.h.
2002
2003 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2004
2005 * image.c (gif_load): Add animation frame delay to the metadata.
2006 (syms_of_image): Use DEFSYM. New symbol `delay'.
2007
2008 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2009
2010 * window.c (delete_deletable_window): Re-add.
2011 (Fset_window_configuration): Rewrite to handle dead buffers and
2012 consequently deletable windows.
2013 (window_tree, Fwindow_tree): Remove. Supply functionality in
2014 window.el.
2015 (compare_window_configurations): Simplify code.
2016
2017 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2018
2019 * image.c (imagemagick_load_image): Fix type mismatch.
2020 (Fimagemagick_types): Likewise.
2021
2022 * window.h (replace_buffer_in_windows): Declare.
2023
2024 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2025
2026 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2027 Qclone_number. Remove external declaration of Qdelete_window.
2028 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2029 code.
2030 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
2031 Qbuffer_list_update_hook if allowed.
2032 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2033 buffer list implementation.
2034 (other_buffer_safely): New function.
2035 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2036 calls to replace_buffer_in_windows and
2037 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2038 if allowed.
2039 (record_buffer): Inhibit quitting and rewrite using quittable
2040 functions. Run Qbuffer_list_update_hook if allowed.
2041 (Frecord_buffer, Funrecord_buffer): New functions.
2042 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
2043 switch-to-buffer to window.el.
2044 (bury-buffer): Move to window.el.
2045 (Vbuffer_list_update_hook): New variable.
2046
2047 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2048 section.
2049
2050 * window.h (resize_frame_windows): Move up in code.
2051 (Fwindow_frame): Remove EXFUN.
2052 (replace_buffer_in_all_windows): Remove prototype.
2053 (replace_buffer_in_windows_safely): Add prototype.
2054
2055 * window.c: Declare Qdelete_window static again. Move down
2056 declaration of select_count.
2057 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2058 (Fother_window): Move to window.el.
2059 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2060 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2061 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2062 window.el.
2063 (replace_buffer_in_windows): Implement by calling
2064 Qreplace_buffer_in_windows.
2065 (replace_buffer_in_all_windows): Remove with some functionality
2066 moved into replace_buffer_in_windows_safely.
2067 (replace_buffer_in_windows_safely): New function.
2068 (select_window_norecord, select_frame_norecord): Move in front
2069 of run_window_configuration_change_hook. Remove now obsolete
2070 declarations.
2071 (Fset_window_buffer): Rewrite doc-string. Call
2072 Qrecord_window_buffer.
2073 (keys_of_window): Move binding for other-window to window.el.
2074
2075 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2076
2077 * dispextern.h (struct image): Replace data member, whose int_val
2078 and ptr_val fields were not used by anything, with a single
2079 lisp_val object.
2080
2081 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2082 (gif_clear_image, gif_load, imagemagick_load_image)
2083 (gs_clear_image, gs_load): Callers changed.
2084
2085 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2086
2087 * buffer.h: Include <time.h>, for time_t.
2088 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2089
2090 Fix minor problems found by static checking.
2091
2092 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2093
2094 Make identifiers static if they are not used in other modules.
2095 * data.c (Qcompiled_function, Qframe, Qvector):
2096 * image.c (QimageMagick, Qsvg):
2097 * minibuf.c (Qmetadata):
2098 * window.c (resize_window_check, resize_root_window): Now static.
2099 * window.h (resize_window_check, resize_root_window): Remove decls.
2100
2101 * window.c (window_deletion_count, delete_deletable_window):
2102 Remove; unused.
2103 (window_body_lines): Now static.
2104 (Fdelete_other_windows_internal): Mark vars as initialized.
2105 Make sure 'resize_failed' is initialized.
2106 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2107 (resize_window_apply): Remove unused local.
2108 * window.h (delete_deletable_window): Remove decl.
2109
2110 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2111 (imagemagick_load_image): Fix pointer signedness problem by changing
2112 last arg from unsigned char * to char *. All uses changed.
2113 Also, fix a local for similar reasons.
2114 Remove unused locals. Remove locals to avoid shadowing.
2115 (fn_rsvg_handle_free): Remove; unused.
2116 (svg_load, svg_load_image): Fix pointer signedness problem.
2117 (imagemagick_load_image): Don't use garbage pointer image_wand.
2118
2119 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2120
2121 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2122
2123 * image.c (gif_load): Fix omitted cast error introduced by
2124 2011-06-06 change.
2125
2126 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2127
2128 * window.h (resize_proportionally, orig_total_lines)
2129 (orig_top_line): Remove from window structure.
2130 (set_window_height, set_window_width, change_window_heights)
2131 (Fdelete_window): Remove prototypes.
2132 (resize_frame_windows): Remove duplicate declaration.
2133
2134 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2135
2136 * window.h (resize_frame_windows, resize_window_check)
2137 (delete_deletable_window, resize_root_window)
2138 (resize_frame_windows): Declare prototypes.
2139
2140 * window.c (resize_window_apply): Make definition be "static" to
2141 match the prototype.
2142
2143 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2144
2145 * window.c: Remove declarations of Qwindow_size_fixed,
2146 window_min_size_1, window_min_size_2, window_min_size,
2147 size_window, window_fixed_size_p, enlarge_window, delete_window.
2148 Remove static from declaration of Qdelete_window, it's
2149 temporarily needed by Fbury_buffer.
2150 (replace_window): Don't assign orig_top_line and
2151 orig_total_lines.
2152 (Fdelete_window, delete_window): Remove. Window deletion is
2153 handled by window.el.
2154 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
2155 Fdelete_window calls with calls to Qdelete_window.
2156 (Fdelete_other_windows): Remove. Deleting other windows is
2157 handled by window.el.
2158 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2159 handled in window.el.
2160 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2161 Window minimum sizes are handled in window.el.
2162 (shrink_windows, size_window, set_window_height)
2163 (set_window_width, change_window_heights, window_height)
2164 (window_width, CURBEG, CURSIZE, enlarge_window)
2165 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2166 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2167 handled in window.el.
2168 (make_dummy_parent): Rename to make_parent_window and give it a
2169 second argument horflag.
2170 (make_window): Don't set resize_proportionally any more.
2171 (Fsplit_window): Remove. Windows are split in window.el.
2172 (save_restore_action, save_restore_orig_size)
2173 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2174 Resize mini windows in window.el.
2175 (grow_mini_window, shrink_mini_window): Implement by calling
2176 Qresize_root_window_vertically, resize_window_check and
2177 resize_window_apply.
2178 (saved_window, Fset_window_configuration, save_window_save): Do
2179 not handle orig_top_line, orig_total_lines, and
2180 resize_proportionally.
2181 (window_min_height, window_min_width): Move to window.el.
2182 (keys_of_window): Move bindings for delete-other-windows,
2183 split-window, delete-window and enlarge-window to window.el.
2184
2185 * buffer.c: Temporarily extern Qdelete_window.
2186 (Fbury_buffer): Temporarily call Qdelete_window instead of
2187 Fdelete_window (Fbury_buffer will move to window.el soon).
2188
2189 * frame.c (set_menu_bar_lines_1): Remove code handling
2190 orig_top_line and orig_total_lines.
2191
2192 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2193 set_window_height but set heights directly.
2194 (change_frame_size_1): Use resize_frame_windows.
2195
2196 * xdisp.c (init_xdisp): Don't use set_window_height but set
2197 heights directly.
2198
2199 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
2200 resize_frame_windows instead of change_window_heights and run
2201 run_window_configuration_change_hook.
2202
2203 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2204 instead of change_window_heights and run
2205 run_window_configuration_change_hook.
2206
2207 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2208
2209 * window.c (replace_window): Rename second argument REPLACEMENT to
2210 NEW. New third argument SETFLAG. Rewrite.
2211 (delete_window, make_dummy_parent): Call replace_window with
2212 third argument 1.
2213 (window_list_1): Move down in code.
2214 (run_window_configuration_change_hook): Move set_buffer part
2215 before select_frame_norecord part in order to unwind correctly.
2216 Rename count1 to count.
2217 (recombine_windows, delete_deletable_window, resize_root_window)
2218 (Fdelete_other_windows_internal)
2219 (Frun_window_configuration_change_hook, make_parent_window)
2220 (resize_window_check, resize_window_apply, Fresize_window_apply)
2221 (resize_frame_windows, Fsplit_window_internal)
2222 (Fdelete_window_internal, Fresize_mini_window_internal): New
2223 functions.
2224 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2225
2226 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2227
2228 * window.h (window): Add some new members to window structure -
2229 normal_lines, normal_cols, new_total, new_normal, clone_number,
2230 splits, nest, prev_buffers, next_buffers.
2231 (WINDOW_TOTAL_SIZE): Move here from window.c.
2232 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2233
2234 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2235 Remove.
2236 (make_dummy_parent): Set new members of windows structure.
2237 (make_window): Move down in code. Handle new members of window
2238 structure.
2239 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2240 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2241 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2242 (Fset_window_prev_buffers, Fwindow_next_buffers)
2243 (Fset_window_next_buffers, Fset_window_clone_number): New
2244 functions.
2245 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2246 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2247 Doc-string fixes.
2248 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2249 Argument WINDOW can be now internal window too.
2250 (Fwindow_use_time): Move up in code.
2251 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2252 Rewrite doc-string.
2253 (Fset_window_configuration, saved_window)
2254 (Fcurrent_window_configuration, save_window_save): Handle new
2255 members of window structure.
2256 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2257 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2258 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2259 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2260 Qget_mru_window, Qresize_root_window,
2261 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2262 Qauto_buffer_name; staticpro them.
2263
2264 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2265
2266 * window.c (Fwindow_total_size, Fwindow_left_column)
2267 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2268 (Fwindow_list_1): New functions.
2269 (window_box_text_cols): Replace with window_body_cols.
2270 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2271 window_body_cols instead of window_box_text_cols.
2272 (delete_window, Fset_window_configuration): Call
2273 delete_all_subwindows with window as argument.
2274 (delete_all_subwindows): Take a window as argument and not a
2275 structure. Rewrite.
2276 (window_loop): Remove handling of GET_LRU_WINDOW and
2277 GET_LARGEST_WINDOW.
2278 (Fget_lru_window, Fget_largest_window): Move to window.el.
2279
2280 * window.h: Extern window_body_cols instead of
2281 window_box_text_cols. delete_all_subwindows now takes a
2282 Lisp_Object as argument.
2283
2284 * indent.c (compute_motion, Fcompute_motion): Use
2285 window_body_cols instead of window_box_text_cols.
2286
2287 * frame.c (delete_frame): Call delete_all_subwindows with root
2288 window as argument.
2289
2290 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2291
2292 * fns.c (Fputhash): Document return value.
2293
2294 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2295
2296 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2297
2298 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2299
2300 Cons<->int and similar integer overflow fixes (Bug#8794).
2301
2302 Check for overflow when converting integer to cons and back.
2303 * charset.c (Fdefine_charset_internal, Fdecode_char):
2304 Use cons_to_unsigned to catch overflow.
2305 (Fencode_char): Use INTEGER_TO_CONS.
2306 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2307 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2308 * data.c (long_to_cons, cons_to_long): Remove.
2309 (cons_to_unsigned, cons_to_signed): New functions.
2310 These signal an error for invalid or out-of-range values.
2311 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2312 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2313 * font.c (Ffont_variation_glyphs):
2314 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2315 * lisp.h: Include <intprops.h>.
2316 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2317 (cons_to_signed, cons_to_unsigned): New decls.
2318 (long_to_cons, cons_to_long): Remove decls.
2319 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2320 (Fprimitive_undo): Use CONS_TO_INTEGER.
2321 * xfns.c (Fx_window_property): Likewise.
2322 * xselect.c: Include <limits.h>.
2323 (x_own_selection, selection_data_to_lisp_data):
2324 Use INTEGER_TO_CONS.
2325 (x_handle_selection_request, x_handle_selection_clear)
2326 (x_get_foreign_selection, Fx_disown_selection_internal)
2327 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2328 (lisp_data_to_selection_data): Use cons_to_unsigned.
2329 (x_fill_property_data): Use cons_to_signed.
2330 Report values out of range.
2331
2332 Check for buffer and string overflow more precisely.
2333 * buffer.h (BUF_BYTES_MAX): New macro.
2334 * lisp.h (STRING_BYTES_MAX): New macro.
2335 * alloc.c (Fmake_string):
2336 * character.c (string_escape_byte8):
2337 * coding.c (coding_alloc_by_realloc):
2338 * doprnt.c (doprnt):
2339 * editfns.c (Fformat):
2340 * eval.c (verror):
2341 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2342 since they may not be the same number.
2343 * editfns.c (Finsert_char):
2344 * fileio.c (Finsert_file_contents):
2345 Likewise for BUF_BYTES_MAX.
2346
2347 * image.c: Use ptrdiff_t, not int, for sizes.
2348 (slurp_file): Switch from int to ptrdiff_t.
2349 All uses changed.
2350 (slurp_file): Check that file size fits in both size_t (for
2351 malloc) and ptrdiff_t (for sanity and safety).
2352
2353 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2354 if b->modtime has its maximal value.
2355
2356 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2357
2358 Don't assume time_t can fit into int.
2359 * buffer.h (struct buffer.modtime): Now time_t, not int.
2360 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2361 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2362
2363 Minor fixes for signed vs unsigned integers.
2364 * character.h (MAYBE_UNIFY_CHAR):
2365 * charset.c (maybe_unify_char):
2366 * keyboard.c (read_char, reorder_modifiers):
2367 XINT -> XFASTINT, since the integer must be nonnegative.
2368 * ftfont.c (ftfont_spec_pattern):
2369 * keymap.c (access_keymap, silly_event_symbol_error):
2370 XUINT -> XFASTINT, since the integer must be nonnegative.
2371 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2372 since it makes no difference and we prefer signed.
2373 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2374 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2375 nonnegative.
2376
2377 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2378
2379 * window.h (Fwindow_frame): Declare.
2380
2381 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2382
2383 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2384 (SPARE_MEMORY): Always define.
2385 (LARGE_REQUEST): Remove.
2386 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2387
2388 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2389
2390 * lisp.h: Move EXFUNS for Fframe_root_window,
2391 Fframe_first_window and Fset_frame_selected_window to window.h.
2392
2393 * window.h: Move EXFUNS for Fframe_root_window,
2394 Fframe_first_window and Fset_frame_selected_window here from
2395 lisp.h.
2396
2397 * frame.c (Fwindow_frame, Fframe_first_window)
2398 (Fframe_root_window, Fframe_selected_window)
2399 (Fset_frame_selected_window): Move to window.c.
2400 (Factive_minibuffer_window): Move to minibuf.c.
2401 (Fother_visible_frames_p): New function.
2402
2403 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2404
2405 * window.c (decode_window, decode_any_window): Move up in code.
2406 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2407 (inhibit_frame_unsplittable): Remove unused variable.
2408 (Fwindow_buffer): Move up and rewrite doc-string.
2409 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2410 (Fwindow_prev): New functions.
2411 (Fwindow_frame): Move here from frame.c. Accept any window as
2412 argument.
2413 (Fframe_root_window, Fframe_first_window)
2414 (Fframe_selected_window): Move here from frame.c. Accept frame
2415 or arbitrary window as argument. Update doc-strings.
2416 (Fminibuffer_window): Move up in code.
2417 (Fwindow_minibuffer_p): Move up in code and simplify.
2418 (Fset_frame_selected_window): Move here from frame.c.
2419 Marginal rewrite.
2420 (Fselected_window, select_window, Fselect_window): Move up in
2421 code. Minor doc-string fixes.
2422
2423 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2424
2425 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2426 Do not assume that spare memory exists; that assumption is valid
2427 only if SYSTEM_MALLOC.
2428 (LARGE_REQUEST): New macro, so that the issue of large requests
2429 is separated from the issue of spare memory.
2430
2431 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2432
2433 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2434 format. (Bug#8806)
2435
2436 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2437
2438 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2439 before statements.
2440
2441 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2442
2443 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2444
2445 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2446
2447 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2448 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2449
2450 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2451
2452 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2453
2454 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2455
2456 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2457 (x_clipboard_manager_save): Add return value.
2458 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2459 New error handlers.
2460 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2461 Obey Vx_select_enable_clipboard_manager. Catch errors in
2462 x_clipboard_manager_save (Bug#8779).
2463 (Vx_select_enable_clipboard_manager): New variable.
2464 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2465
2466 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2467
2468 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2469
2470 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2471
2472 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2473 in the current matrix if keep_current_p is non-zero.
2474
2475 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2476
2477 * bidi.c (bidi_level_of_next_char): Fix last change.
2478
2479 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2480
2481 Support bidi reordering of text covered by display properties.
2482
2483 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2484 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2485 (bidi_cache_search, bidi_cache_iterator_state)
2486 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2487 (bidi_level_of_next_char, bidi_move_to_visually_next):
2488 Support character positions inside a run of characters covered by a
2489 display string.
2490 (bidi_paragraph_init, bidi_resolve_explicit_1)
2491 (bidi_level_of_next_char): Call bidi_fetch_char and
2492 bidi_fetch_char_advance instead of FETCH_CHAR and
2493 FETCH_CHAR_ADVANCE.
2494 (bidi_init_it): Initialize new members.
2495 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2496 definitions.
2497 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2498 instead of using explicit *_CHAR codes.
2499 (bidi_resolve_explicit, bidi_resolve_weak):
2500 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2501 bidirectional text is supported only in multibyte buffers.
2502 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2503 it to initialize the frame_window_p member of struct bidi_it.
2504 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2505 (bidi_resolve_explicit, bidi_resolve_weak)
2506 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2507 bidi_it->nchars is non-positive.
2508 (bidi_level_of_next_char): Don't try to lookup the cache for the
2509 next/previous character if nothing is cached there yet, or if we
2510 were just reseat()'ed to a new position.
2511
2512 * xdisp.c (set_cursor_from_row): Set start and stop points
2513 according to the row's direction when priming the loop that looks
2514 for the glyph on which to display cursor.
2515 (single_display_spec_intangible_p): Function deleted.
2516 (display_prop_intangible_p): Reimplement to call
2517 handle_display_spec instead of single_display_spec_intangible_p.
2518 Accept 3 additional arguments needed by handle_display_spec.
2519 This fixes incorrect cursor motion across display property with complex
2520 values: lists, `(when COND...)' forms, etc.
2521 (single_display_spec_string_p): Support property values that are
2522 lists with the argument STRING its top-level element.
2523 (display_prop_string_p): Fix the condition for processing a
2524 property that is a list to be consistent with handle_display_spec.
2525 (handle_display_spec): New function, refactored from the
2526 last portion of handle_display_prop.
2527 (compute_display_string_pos): Accept additional argument
2528 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2529 value of a `display' property is a "replacing spec".
2530 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2531 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2532 the display property, but just return a value indicating whether
2533 the display property will replace the characters it covers.
2534 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2535 frame_window_p members of struct bidi_it.
2536 (compute_display_string_pos, compute_display_string_end):
2537 New functions.
2538 (push_it): Accept second argument POSITION, where pop_it should
2539 jump to continue iteration.
2540 (reseat_1): Initialize bidi_it.disp_pos.
2541
2542 * keyboard.c (adjust_point_for_property): Adjust the call to
2543 display_prop_intangible_p to its new signature.
2544
2545 * dispextern.h (struct bidi_it): New member frame_window_p.
2546 (bidi_init_it): Update prototypes.
2547 (display_prop_intangible_p): Update prototype.
2548 (compute_display_string_pos, compute_display_string_end):
2549 Declare prototypes.
2550 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2551 EMACS_INT.
2552
2553 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2554
2555 Malloc failure behavior now depends on size of allocation.
2556 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2557 * lisp.h: Change signatures accordingly.
2558 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2559 All callers changed. (Bug#8762)
2560
2561 * gnutls.c: Use Emacs's memory allocators.
2562 Without this change, the gnutls library would invoke malloc etc.
2563 directly, which causes problems on non-SYNC_INPUT hosts, and which
2564 runs afoul of improving memory_full behavior. (Bug#8761)
2565 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2566 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2567 xfree instead of the default malloc, realloc, free.
2568 (Fgnutls_boot): No need to check for memory allocation failure,
2569 since xmalloc does that for us.
2570
2571 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2572 * category.c (hash_get_category_set):
2573 * ccl.c (ccl_driver):
2574 * charset.c (Fdefine_charset_internal):
2575 * charset.h (struct charset.hash_index):
2576 * composite.c (get_composition_id, gstring_lookup_cache)
2577 (composition_gstring_put_cache):
2578 * composite.h (struct composition.hash_index):
2579 * dispextern.h (struct image.hash):
2580 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2581 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2582 (hashfn_equal, hashfn_user_defined, make_hash_table)
2583 (maybe_resize_hash_table, hash_lookup, hash_put)
2584 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2585 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2586 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2587 * image.c (make_image, search_image_cache, lookup_image)
2588 (xpm_put_color_table_h):
2589 * lisp.h (struct Lisp_Hash_Table):
2590 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2591 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2592 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2593 * alloc.c (allocate_vectorlike):
2594 Check for overflow in vector size calculations.
2595 * ccl.c (ccl_driver):
2596 Check for overflow when converting EMACS_INT to int.
2597 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2598 need to be updated by these changes.
2599 * fns.c (make_hash_table, maybe_resize_hash_table):
2600 Check for integer overflow with large hash tables.
2601 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2602 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2603 (SXHASH_REDUCE): New macro.
2604 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2605 Use it instead of discarding useful hash info with large hash values.
2606 (sxhash_float): New function.
2607 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2608 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2609 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2610 Rewrite to use FIXNUM_BITS, as this simplifies things.
2611 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2612 Adjust signatures to match updated version of code.
2613 (consing_since_gc): Now EMACS_INT, since a single hash table can
2614 use more than INT_MAX bytes.
2615
2616 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2617
2618 Make it possible to build with GCC-4.6+ -O2 -flto.
2619
2620 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2621
2622 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2623
2624 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2625 Call minibuffer-inactive-mode.
2626
2627 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2628
2629 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2630 Update dependencies.
2631
2632 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2633
2634 * data.c (init_data): Remove code for UTS, this system is not
2635 supported anymore.
2636
2637 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2638
2639 Don't force ./temacs to start in terminal mode.
2640
2641 * frame.c (make_initial_frame): Initialize faces in all cases, not
2642 only when CANNOT_DUMP is defined.
2643 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2644
2645 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2646
2647 * dispnew.c (add_window_display_history): Use const for the string
2648 pointer. Remove declaration, not needed.
2649
2650 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2651
2652 Use 'inline', not 'INLINE'.
2653 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2654 * alloc.c, fontset.c (INLINE): Remove.
2655 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2656 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2657 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2658 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2659 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2660
2661 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2662
2663 Make it possible to run ./temacs.
2664
2665 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2666 syms_of_callproc does the same thing. Remove test for
2667 "initialized", do it in the caller.
2668 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2669
2670 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2671
2672 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2673 (read_minibuf): Use get_minibuffer.
2674 (syms_of_minibuf): Use DEFSYM.
2675 (Qmetadata): New var.
2676 * data.c (Qbuffer): Don't make it static.
2677 (syms_of_data): Use DEFSYM.
2678
2679 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2680
2681 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2682 (CCL_CODE_MIN): New macro.
2683
2684 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2685
2686 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2687
2688 * eval.c (Qdebug): Now static.
2689 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2690 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2691 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2692
2693 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2694
2695 * image.c: Various fixes to ImageMagick code comments.
2696 (Fimagemagick_types): Doc fix.
2697
2698 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2699
2700 Minor fixes prompted by GCC 4.6.0 warnings.
2701
2702 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2703
2704 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2705 (x_clipboard_manager_save_all): Move extern decl to ...
2706 * xterm.h: ... here, so that it can be checked for consistency.
2707
2708 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2709
2710 * xselect.c (x_clipboard_manager_save_frame)
2711 (x_clipboard_manager_save_all): New functions.
2712 (Fx_clipboard_manager_save): Lisp function deleted.
2713
2714 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2715 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2716
2717 * xterm.h: Update prototype.
2718
2719 2011-05-28 William Xu <william.xwl@gmail.com>
2720
2721 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2722 exiting (Bug#8239).
2723
2724 2011-05-28 Jim Meyering <meyering@redhat.com>
2725
2726 Avoid a sign-extension bug in crypto_hash_function.
2727 * fns.c (to_uchar): Define.
2728 (crypto_hash_function): Use it to convert some newly-signed
2729 variables to unsigned, to avoid sign-extension bugs. For example,
2730 without this change, (md5 "truc") would evaluate to
2731 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2732 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2733 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2734
2735 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2736
2737 Integer overflow fixes.
2738
2739 * dbusbind.c: Serial number integer overflow fixes.
2740 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2741 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2742 to hold a serial number that is too large for a fixnum.
2743 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2744 Check for serial numbers out of range. Decode any serial number
2745 that was so large that it became a float. (Bug#8722)
2746
2747 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2748 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2749 Use XFASTINT rather than XUINT when numbers are nonnegative.
2750 (xd_append_arg, Fdbus_method_return_internal):
2751 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2752 arguments, check that Lisp number is nonnegative, rather than
2753 silently wrapping negative numbers around. (Bug#8722)
2754 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2755 (Bug#8722)
2756
2757 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2758
2759 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2760
2761 ccl: add integer overflow checks
2762 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2763 (IN_INT_RANGE): New macros.
2764 (ccl_driver): Use them to check for integer overflow when
2765 decoding a CCL program. Many of the new checks are whether XINT (x)
2766 fits in int; it doesn't always, on 64-bit hosts. The new version
2767 doesn't catch all possible integer overflows, but it's an
2768 improvement. (Bug#8719)
2769
2770 * alloc.c (make_event_array): Use XINT, not XUINT.
2771 There's no need for unsigned here.
2772
2773 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2774 This follows up to the 2011-05-06 change that substituted uintptr_t
2775 for EMACS_INT. This case wasn't caught back then.
2776
2777 Rework Fformat to avoid integer overflow issues.
2778 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2779 now (part of C89). Include <verify.h>.
2780 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2781 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2782 (Fformat): Avoid the prepass trying to compute sizes; it was only
2783 approximate and thus did not catch overflow reliably. Instead, walk
2784 through the format just once, formatting and computing sizes as we go,
2785 checking for integer overflow at every step, and allocating a larger
2786 buffer as needed. Keep track separately whether the format is
2787 multibyte. Keep only the most-recently calculated precision, rather
2788 than them all. Record whether each argument has been converted to
2789 string. Use EMACS_INT, not int, for byte and char and arg counts.
2790 Support field widths and precisions larger than INT_MAX. Avoid
2791 sprintf's undefined behavior with conversion specifications such as %#d
2792 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2793 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2794 formatting out-of-range floating point numbers with int
2795 formats. (Bug#8668)
2796
2797 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2798
2799 * data.c: Avoid integer truncation in expressions involving floats.
2800 * data.c: Include <intprops.h>.
2801 (arith_driver): When there's an integer overflow in an expression
2802 involving floating point, convert the integers to floating point
2803 so that the resulting value does not suffer from catastrophic
2804 integer truncation. For example, on a 64-bit host (* 4
2805 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2806 Do not rely on undefined behavior after integer overflow.
2807
2808 merge count_size_as_multibyte, parse_str_to_multibyte
2809 * character.c, character.h (count_size_as_multibyte):
2810 Rename from parse_str_to_multibyte; all uses changed.
2811 Check for integer overflow.
2812 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2813 since it's now a duplicate of the other. This is more of
2814 a character than a buffer op, so better that it's in character.c.
2815 * fns.c, print.c: Adjust to above changes.
2816
2817 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2818
2819 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2820
2821 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2822
2823 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2824 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2825 (x_clipboard_manager_save): Now static.
2826 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2827
2828 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2829 (crypto_hash_function): Now static.
2830 Fix pointer signedness problems. Avoid unnecessary initializations.
2831
2832 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2833
2834 * termhooks.h (Vselection_alist): Make it terminal-local.
2835
2836 * terminal.c (create_terminal): Initialize it.
2837
2838 * xselect.c: Support for clipboard managers.
2839 (Vselection_alist): Move to termhooks.h as terminal-local var.
2840 (LOCAL_SELECTION): New macro.
2841 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2842 (symbol_to_x_atom): Remove gratuitous arg.
2843 (x_handle_selection_request, lisp_data_to_selection_data)
2844 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2845 (x_own_selection, x_get_local_selection, x_convert_selection):
2846 New arg, specifying work frame. Use terminal-local Vselection_alist.
2847 (some_frame_on_display): Delete unused function.
2848 (Fx_own_selection_internal, Fx_get_selection_internal)
2849 (Fx_disown_selection_internal, Fx_selection_owner_p)
2850 (Fx_selection_exists_p): New optional frame arg.
2851 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2852 (x_handle_selection_clear): Don't treat other terminals with the
2853 same keyboard specially. Use the terminal-local Vselection_alist.
2854 (x_clear_frame_selections): Use Frun_hook_with_args.
2855
2856 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2857
2858 * xterm.h: Add support for those atoms.
2859
2860 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2861
2862 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2863 (converted_selections, conversion_fail_tag): New global variables.
2864 (x_selection_request_lisp_error): Free the above.
2865 (x_get_local_selection): Remove unnecessary code.
2866 (x_reply_selection_request): Args changed; handle arbitrary array
2867 of converted selections stored in converted_selections.
2868 Separate the XChangeProperty and SelectionNotify steps.
2869 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2870 (x_convert_selection): New function.
2871 (x_handle_selection_event): Simplify.
2872 (x_get_foreign_selection): Don't ignore incoming requests while
2873 waiting for an answer; this will fail when we implement
2874 SAVE_TARGETS, and seems unnecessary anyway.
2875 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2876 (Vx_sent_selection_functions): Doc fix.
2877
2878 2011-05-26 Leo Liu <sdl.web@gmail.com>
2879
2880 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2881
2882 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2883
2884 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2885
2886 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2887 for fringe update if it has periodic bitmap.
2888 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2889 and fringe_bitmap_periodic_p.
2890
2891 * fringe.c (get_fringe_bitmap_data): New function.
2892 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2893 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2894 row. Mark glyph row for fringe update if periodicity changed.
2895
2896 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2897 for fringe update unless it has periodic bitmap.
2898
2899 2011-05-25 Kenichi Handa <handa@m17n.org>
2900
2901 * xdisp.c (get_next_display_element): Set correct it->face_id for
2902 a static composition.
2903
2904 2011-05-24 Leo Liu <sdl.web@gmail.com>
2905
2906 * deps.mk (fns.o):
2907 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2908
2909 * fns.c (crypto_hash_function, Fsha1): New function.
2910 (Fmd5): Use crypto_hash_function.
2911 (syms_of_fns): Add Ssha1.
2912
2913 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2914
2915 * gnutls.c: Remove unused macros.
2916 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2917 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2918 Remove macros that are defined and never used.
2919 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2920
2921 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2922
2923 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2924 (Fx_get_selection_internal): Minor cleanup.
2925 (Fx_own_selection_internal): Rename arguments for consistency with
2926 select.el.
2927
2928 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2929
2930 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2931
2932 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2933
2934 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2935
2936 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2937
2938 * dispnew.c (scrolling_window): Don't exclude the case that the
2939 last enabled row in the desired matrix touches the bottom boundary.
2940
2941 2011-05-21 Glenn Morris <rgm@gnu.org>
2942
2943 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
2944 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2945 and add some more files.
2946
2947 2011-05-20 Eli Zaretskii <eliz@gnu.org>
2948
2949 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2950 report_file_error introduced by the change from 2011-05-07.
2951
2952 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2953
2954 * systime.h (Time): Define only if emacs is defined.
2955 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2956 where the include path doesn't have X11/X.h by default. See
2957 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2958
2959 2011-05-20 Kenichi Handa <handa@m17n.org>
2960
2961 * composite.c (find_automatic_composition): Fix previous change.
2962
2963 2011-05-20 Glenn Morris <rgm@gnu.org>
2964
2965 * lisp.mk: New file, split from Makefile.in.
2966 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2967 (shortlisp): Remove.
2968 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2969
2970 2011-05-19 Glenn Morris <rgm@gnu.org>
2971
2972 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2973 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2974 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2975 (lisp): Set the order to that of loadup.el.
2976 (shortlisp): Make it a copy of $lisp.
2977 (SOME_MACHINE_LISP): Remove.
2978 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2979 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2980
2981 2011-05-18 Kenichi Handa <handa@m17n.org>
2982
2983 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2984 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2985 (find_automatic_composition): Mostly rewrite for efficiency.
2986
2987 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
2988
2989 * makefile.w32-in: Update dependencies.
2990
2991 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2992
2993 * menu.c: Include limits.h (fixes the MS-Windows build broken by
2994 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
2995
2996 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
2997
2998 Fix some integer overflow issues, such as string length overflow.
2999
3000 * insdel.c (count_size_as_multibyte): Check for string overflow.
3001
3002 * character.c (lisp_string_width): Check for string overflow.
3003 Use EMACS_INT, not int, for string indexes and lengths; in
3004 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3005 the resulting string length overflows an EMACS_INT; instead,
3006 report a string overflow if no precision given. When checking for
3007 precision exhaustion, use a check that cannot possibly have
3008 integer overflow. (Bug#8675)
3009 * character.h (lisp_string_width): Adjust to new signature.
3010
3011 * alloc.c (string_overflow): New function.
3012 (Fmake_string): Use it. This doesn't change behavior, but saves
3013 a few bytes and will simplify future changes.
3014 * character.c (string_escape_byte8): Likewise.
3015 * lisp.h (string_overflow): New decl.
3016
3017 Fixups, following up to the user-interface timestamp change.
3018 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3019 for UI timestamps, instead of unsigned long.
3020 * msdos.c (mouse_get_pos): Likewise.
3021 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3022 * w32gui.h (Time): Define by including "systime.h" rather than by
3023 declaring it ourselves. (Bug#8664)
3024
3025 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3026 * image.c (clear_image_cache): Likewise.
3027
3028 * term.c (term_mouse_position): Don't assume time_t wraparound.
3029
3030 Be more systematic about user-interface timestamps.
3031 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3032 and sometimes 'EMACS_UINT', to represent these timestamps.
3033 This change causes it to use 'Time' uniformly, as that's what X uses.
3034 This makes the code easier to follow, and makes it easier to catch
3035 integer overflow bugs such as Bug#8664.
3036 * frame.c (Fmouse_position, Fmouse_pixel_position):
3037 Use Time, not unsigned long, for user-interface timestamps.
3038 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3039 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3040 * keyboard.h (last_event_timestamp): Likewise.
3041 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3042 * menu.h (xmenu_show): Likewise.
3043 * term.c (term_mouse_position): Likewise.
3044 * termhooks.h (struct input_event.timestamp): Likewise.
3045 (struct terminal.mouse_position_hook): Likewise.
3046 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3047 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3048 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3049 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3050 what it was before.
3051 * menu.h, termhooks.h: Include "systime.h", for Time.
3052
3053 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3054 Don't assume that the difference between two unsigned long values
3055 can fit into an integer. At this point, we know button_down_time
3056 <= event->timestamp, so the difference must be nonnegative, so
3057 there's no need to cast the result if double-click-time is
3058 nonnegative, as it should be; check that it's nonnegative, just in
3059 case. This bug is triggered when events are more than 2**31 ms
3060 apart (about 25 days). (Bug#8664)
3061
3062 * xselect.c (last_event_timestamp): Remove duplicate decl.
3063 (x_own_selection): Remove needless cast to unsigned long.
3064
3065 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3066 that always fit in int. Use a sentinel instead of a counter, to
3067 avoid a temp and to allay GCC's concerns about possible int overflow.
3068 * frame.h (struct frame): Use int for menu_bar_items_used
3069 instead of EMACS_INT, since it always fits in int.
3070
3071 * menu.c (grow_menu_items): Check for int overflow.
3072
3073 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3074
3075 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3076 Before, the code was not consistent. These values cannot exceed
3077 2**31 - 1 so there's no need to make them unsigned.
3078 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3079 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3080 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3081 as modifiers.
3082 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3083
3084 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3085 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3086 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3087 presumably because the widths might not match.
3088
3089 * window.c (size_window): Avoid needless test at loop start.
3090
3091 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3092
3093 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3094
3095 2011-05-12 Drew Adams <drew.adams@oracle.com>
3096
3097 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3098
3099 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3100
3101 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3102 `width' to `bar_area_x' and `bar_area_width', respectively.
3103 (x_scroll_run): Take account of fringe background extension.
3104
3105 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3106 Rename local vars `left' and `width' to `bar_area_x' and
3107 `bar_area_width', respectively.
3108 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3109 background extension.
3110
3111 2011-05-10 Jim Meyering <meyering@redhat.com>
3112
3113 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3114
3115 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3116
3117 * image.c (Finit_image_library): Return t for built-in image types,
3118 like pbm and xbm. (Bug#8640)
3119
3120 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3121
3122 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3123
3124 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3125
3126 * w32console.c (Fset_screen_color): Doc fix.
3127 (Fget_screen_color): New function.
3128 (syms_of_ntterm): Defsubr it.
3129
3130 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3131 unlink the temporary file if Fcall_process didn't create it in the
3132 first place.
3133 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3134 child process will be redirected to a file specified with `:file'.
3135 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3136 cue to call_process_cleanup not to close that handle.
3137
3138 2011-05-07 Ben Key <bkey76@gmail.com>
3139
3140 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3141 one of two shell specific rules, either bootstrap-temacs-CMD or
3142 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3143 to the previous implementation of the bootstrap-temacs rule.
3144 The bootstrap-temacs-CMD rule is similar to the previous
3145 implementation of the bootstrap-temacs rule except that it
3146 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3147 variable.
3148
3149 These changes, along with some changes to nt/configure.bat,
3150 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3151 earlier fix to add support for --cflags and --ldflags options
3152 that include quotes so that it works whether make uses cmd or
3153 sh as the shell.
3154
3155 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3156
3157 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3158 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3159 is a constant.
3160 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3161 a string. Handle both cases.
3162 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3163 (Fdbus_register_method): Use Qinvalid_function.
3164
3165 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3166
3167 * makefile.w32-in: Update dependencies.
3168 (LISP_H): Add inttypes.h and stdin.h.
3169 (PROCESS_H): Add unistd.h.
3170
3171 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3172
3173 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3174 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3175
3176 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3177
3178 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3179
3180 * term.c (vfatal): Remove stray call to va_end.
3181 It's not needed and the C Standard doesn't allow it here anyway.
3182
3183 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3184 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3185
3186 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3187 bytes.
3188
3189 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3190
3191 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3192
3193 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3194
3195 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3196
3197 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3198
3199 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3200 * charset.c (Fdefine_charset_internal): Don't initialize
3201 charset.code_space[15]. The value was garbage, on hosts with
3202 32-bit int (Bug#8600).
3203
3204 * lread.c (read_integer): Be more consistent with string-to-number.
3205 Use string_to_number to do the actual conversion; this avoids
3206 rounding errors and fixes some other screwups. Without this fix,
3207 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3208 (digit_to_number): Move earlier, for benefit of read_integer.
3209 Return -1 if the digit is out of range for the base, -2 if it is
3210 not a digit in any supported base. (Bug#8602)
3211
3212 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3213
3214 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3215 to match comment at start of function. This also removes a
3216 GCC warning about overflow in a 32+64-bit port.
3217
3218 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3219
3220 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3221 Reported by Stefan Monnier in
3222 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3223 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3224 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3225
3226 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3227 (EMACS_UINTPTR): Likewise, with uintptr_t.
3228
3229 * lisp.h: Prefer 64-bit EMACS_INT if available.
3230 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3231 on 32-bit hosts that have 64-bit int, so that they can access
3232 large files.
3233 However, temporarily disable this change unless the temporary
3234 symbol WIDE_EMACS_INT is defined.
3235
3236 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3237
3238 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3239 This removes an assumption that EMACS_INT and long are the same
3240 width as pointers. The assumption is true for Emacs porting targets
3241 now, but we want to make other targets possible.
3242 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3243 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3244 In the rest of the code, change types of integers that hold casted
3245 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3246 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3247 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3248 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3249 No need to cast type when ORing.
3250 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3251 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3252 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3253 assume EMACS_INT is the same width as char *.
3254 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3255 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3256 Remove no-longer-needed casts.
3257 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3258 (xg_tool_bar_help_callback, xg_make_tool_item):
3259 Use EMACS_INTPTR to hold an integer
3260 that will be cast to void *; this can avoid a GCC warning
3261 if EMACS_INT is not the same width as void *.
3262 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3263 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3264 (current_message_1, set_message_1):
3265 Use a local to convert to proper width without a cast.
3266 * xmenu.c (dialog_selection_callback): Likewise.
3267
3268 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3269 Also, don't assume VALBITS / RAND_BITS is less than 5,
3270 and don't rely on undefined behavior when shifting a 1 left into
3271 the sign bit.
3272 * lisp.h (get_random): Change signature to match.
3273
3274 * lread.c (hash_string): Use size_t, not int, for hash computation.
3275 Normally we prefer signed values; but hashing is special, because
3276 it's better to use unsigned division on hash table sizes so that
3277 the remainder is nonnegative. Also, size_t is the natural width
3278 for hashing into memory. The previous code used 'int', which doesn't
3279 retain enough info to hash well into very large tables.
3280 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3281
3282 * dbusbind.c: Don't possibly lose pointer info when converting.
3283 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3284 Use XPNTR rather than XHASH, so that the high-order bits of
3285 the pointer aren't lost when converting through void *.
3286
3287 * eval.c (Fautoload): Don't double-shift a pointer.
3288
3289 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3290
3291 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3292
3293 * gnutls.c (DEF_GNUTLS_FN):
3294 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3295
3296 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3297
3298 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3299 marker. (Bug#8610)
3300
3301 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3302
3303 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3304 New version that can reserve upto 2GB of heap space.
3305
3306 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3307
3308 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3309
3310 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3311
3312 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3313 `gnutls_certificate_set_x509_key_file'.
3314
3315 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3316
3317 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3318 Update dependencies.
3319
3320 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3321
3322 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3323 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3324 Remove unused parameter `fildes'.
3325 * process.c (read_process_output, send_process): Don't pass it.
3326
3327 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3328
3329 Fix previous change: the library cache is defined in w32.c.
3330 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3331 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3332
3333 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3334
3335 Implement dynamic loading of GnuTLS on Windows.
3336
3337 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3338 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3339 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3340 Declare.
3341
3342 * gnutls.c (Qgnutls_dll): Define.
3343 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3344 (gnutls_*): Declare function pointers.
3345 (init_gnutls_functions): New function to initialize function pointers.
3346 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3347 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3348 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3349 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3350 (emacs_gnutls_write, emacs_gnutls_read)
3351 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3352 (Fgnutls_available_p): New function.
3353 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3354 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3355 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3356
3357 * image.c: Include w32.h.
3358 (Vimage_type_cache): Delete.
3359 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3360 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3361 (w32_delayed_load): Move to w32.c.
3362
3363 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3364
3365 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3366 (w32_delayed_load): Move from image.c. When loading a library, record
3367 its filename in the :loaded-from property of the library id.
3368 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3369 Initialize and staticpro them.
3370 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3371
3372 * process.c: Include lisp.h before w32.h, not after.
3373 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3374 instead of gnutls_record_check_pending.
3375
3376 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3377
3378 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3379
3380 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3381 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3382 as passed in.
3383
3384 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3385
3386 * xterm.c (x_set_frame_alpha): Do not set property on anything
3387 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3388
3389 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3390
3391 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3392
3393 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3394
3395 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3396 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3397 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3398 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3399 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3400 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3401 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3402 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3403 (Qgnutls_bootprop_callbacks_verify): Make static.
3404
3405 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3406
3407 * callproc.c: Indentation fixup.
3408
3409 * sysdep.c (wait_for_termination_1): Make static.
3410 (wait_for_termination, interruptible_wait_for_termination):
3411 Move after wait_for_termination_1.
3412
3413 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3414
3415 * sysdep.c (interruptible_wait_for_termination): New function
3416 which is like wait_for_termination, but allows keyboard
3417 interruptions.
3418
3419 * callproc.c (Fcall_process): Add (:file "file") as an option for
3420 the STDOUT buffer.
3421 (Fcall_process_region): Ditto.
3422
3423 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3424
3425 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3426 rather than `XVECTOR (FOO)->size'.
3427
3428 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3429 inttypes.h, as a gnulib replacement is used if it not available in
3430 system headers.
3431
3432 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3433
3434 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3435 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3436 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3437
3438 * coding.c (coding_alloc_by_realloc): Error out if destination
3439 will grow beyond MOST_POSITIVE_FIXNUM.
3440 (decode_coding_emacs_mule): Abort if there isn't enough place in
3441 charbuf for the composition carryover bytes. Reserve an extra
3442 space for up to 2 characters produced in a loop.
3443 (decode_coding_iso_2022): Abort if there isn't enough place in
3444 charbuf for the composition carryover bytes.
3445
3446 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3447
3448 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3449 aborting when %lld or %lll format is passed.
3450 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3451 %llo or %llx format is passed. (Bug#8545)
3452
3453 * window.c (window_scroll_line_based): Use a marker instead of
3454 simple variables to record original value of point. (Bug#7952)
3455
3456 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3457 produced by %s or %c overflows available buffer space. (Bug#8545)
3458
3459 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3460
3461 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3462 (SIZE_MAX): Move defn after all includes, as they might #define it.
3463
3464 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3465
3466 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3467
3468 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3469
3470 * keyboard.c (Qdelayed_warnings_hook): Define.
3471 (command_loop_1): Run `delayed-warnings-hook'
3472 if Vdelayed_warnings_list is non-nil.
3473 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3474 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3475
3476 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3477
3478 * doprnt.c (doprnt): Don't return value smaller than the buffer
3479 size if the message was truncated. (Bug#8545).
3480
3481 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3482
3483 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3484 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3485
3486 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3487
3488 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3489
3490 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3491
3492 * makefile.w32-in: Update dependencies.
3493
3494 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3495
3496 Improve `doprnt' and its usage. (Bug#8545)
3497 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3498 `format_end'. Remove support for %l as a conversion specifier.
3499 Don't use xrealloc. Improve diagnostics when the %l size modifier
3500 is used. Update the commentary.
3501
3502 * eval.c (verror): Simplify calculation of size_t.
3503
3504 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3505 messages.
3506
3507 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3508
3509 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3510 change.
3511
3512 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3513
3514 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3515 This makes this file independent of the recent pseudovector change.
3516
3517 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3518
3519 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3520
3521 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3522 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3523 Remove unused local.
3524 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3525
3526 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3527 GCC 4.6.0 optimizes based on type-based alias analysis.
3528 For example, if b is of type struct buffer * and v of type struct
3529 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3530 != &v->size, and therefore "v->size = 1; b->size = 2; return
3531 v->size;" must therefore return 1. This assumption is incorrect
3532 for Emacs, since it type-puns struct Lisp_Vector * with many other
3533 types. To fix this problem, this patch adds a new type struct
3534 vectorlike_header that documents the constraints on layout of vectors
3535 and pseudovectors, and helps optimizing compilers not get fooled
3536 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3537 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3538 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3539 the size member.
3540 (XSETPVECTYPE): Rewrite in terms of new macro.
3541 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3542 This is a bit clearer, and further avoids the possibility of
3543 undesirable aliasing.
3544 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3545 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3546 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3547 since Lisp_Subr is a special case (no "next" field).
3548 (ASIZE): Now uses header.size rather than size.
3549 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3550 to avoid the hassle of writing XVECTOR (foo)->header.size.
3551 (struct vectorlike_header): New type.
3552 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3553 object, to help avoid aliasing.
3554 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3555 (SUBRP): Likewise, since Lisp_Subr is a special case.
3556 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3557 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3558 (struct Lisp_Hash_Table): Combine first two members into a single
3559 struct vectorlike_header member. All uses of "size" and "next" members
3560 changed to be "header.size" and "header.next".
3561 * buffer.h (struct buffer): Likewise.
3562 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3563 * frame.h (struct frame): Likewise.
3564 * process.h (struct Lisp_Process): Likewise.
3565 * termhooks.h (struct terminal): Likewise.
3566 * window.c (struct save_window_data, struct saved_window): Likewise.
3567 * window.h (struct window): Likewise.
3568 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3569 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3570 * buffer.c (init_buffer_once): Likewise.
3571 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3572 special case.
3573 * process.c (Fformat_network_address): Use local var for size,
3574 for brevity.
3575
3576 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3577
3578 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3579 * data.c (atof): Remove decl; no longer used or needed.
3580 (digit_to_number): Move to lread.c.
3581 (Fstring_to_number): Use new string_to_number function, to be
3582 consistent with how the Lisp reader treats infinities and NaNs.
3583 Do not assume that floating-point numbers represent EMACS_INT
3584 without losing information; this is not true on most 64-bit hosts.
3585 Avoid double-rounding errors, by insisting on integers when
3586 parsing non-base-10 numbers, as the documentation specifies.
3587 * lisp.h (string_to_number): New decl, replacing ...
3588 (isfloat_string): Remove.
3589 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3590 (read1): Do not accept +. and -. as integers; this
3591 appears to have been a coding error. Similarly, do not accept
3592 strings like +-1e0 as floating point numbers. Do not report
3593 overflow for integer overflows unless the base is not 10 which
3594 means we have no simple and reliable way to continue.
3595 Break out the floating-point parsing into a new
3596 function string_to_number, so that Fstring_to_number parses
3597 floating point numbers consistently with the Lisp reader.
3598 (digit_to_number): Move here from data.c. Make it static inline.
3599 (E_CHAR, EXP_INT): Remove, replacing with ...
3600 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3601 (string_to_number): New function, replacing isfloat_string.
3602 This function checks for valid syntax and produces the resulting
3603 Lisp float number too. Rework it so that string-to-number
3604 no longer mishandles examples like "1.0e+". Use strtoumax,
3605 so that overflow for non-base-10 numbers is reported only when
3606 there's no portable and simple way to convert to floating point.
3607
3608 * textprop.c (set_text_properties_1): Rewrite for clarity,
3609 and to avoid GCC warning about integer overflow.
3610
3611 * intervals.h (struct interval): Use EMACS_INT for members
3612 where EMACS_UINT might cause problems. See
3613 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3614 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3615 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3616 All uses changed.
3617 (offset_intervals): Tell GCC not to worry about length overflow
3618 when negating a negative length.
3619
3620 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3621 (overrun_check_free): Likewise.
3622
3623 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3624 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3625 word size.
3626
3627 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3628 (gnutls_make_error): Rename local to avoid shadowing.
3629 (gnutls_emacs_global_deinit): ifdef out; not used.
3630 (Fgnutls_boot): Use const for pointer to readonly storage.
3631 Comment out unused local. Fix pointer signedness problems.
3632
3633 * lread.c (openp): Don't stuff size_t into an 'int'.
3634 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3635 about possible signed overflow.
3636
3637 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3638 (GDK_KEY_g): Don't define if already defined.
3639 (xg_prepare_tooltip): Avoid pointer signedness problem.
3640 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3641
3642 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3643 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3644
3645 * xfns.c (Fx_window_property): Simplify a bit,
3646 to make a bit faster and to avoid GCC 4.6.0 warning.
3647 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3648
3649 * fns.c (internal_equal): Don't assume size_t fits in int.
3650
3651 * alloc.c (compact_small_strings): Tighten assertion a little.
3652
3653 Replace pEd with more-general pI, and fix some printf arg casts.
3654 * lisp.h (pI): New macro, generalizing old pEd macro to other
3655 conversion specifiers. For example, use "...%"pI"d..." rather
3656 than "...%"pEd"...".
3657 (pEd): Remove. All uses replaced with similar uses of pI.
3658 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3659 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3660 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3661 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3662 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3663 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3664 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3665 64-bit hosts.
3666 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3667 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3668 * print.c (safe_debug_print, print_object): Likewise.
3669 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3670 to int.
3671 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3672 avoiding the 0 flag, which is not portable.
3673 * process.c (Fmake_network_process): Use pI to avoid cast.
3674 * region-cache.c (pp_cache): Likewise.
3675 * xdisp.c (decode_mode_spec): Likewise.
3676 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3677 behavior on 64-bit hosts with printf arg.
3678 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3679 (x_stop_queuing_selection_requests): Likewise.
3680 (x_get_window_property): Don't truncate byte count to an 'int'
3681 when tracing.
3682
3683 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3684 here, since it parses constructs like leading '-' and spaces,
3685 which are not wanted; and it overflows with large numbers.
3686 Instead, simply match F[0-9]+, which is what is wanted anyway.
3687
3688 * alloc.c: Remove unportable assumptions about struct layout.
3689 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3690 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3691 (allocate_vectorlike, make_pure_vector): Use the new macros,
3692 plus offsetof, to remove unportable assumptions about struct layout.
3693 These assumptions hold on all porting targets that I know of, but
3694 they are not guaranteed, they're easy to remove, and removing them
3695 makes further changes easier.
3696
3697 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3698 This doesn't fix a bug but makes the code clearer.
3699 (string_overrun_cookie): Now const. Use initializers that
3700 don't formally overflow signed char, to avoid warnings.
3701 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3702 can cause Emacs to crash when string overrun checking is enabled.
3703 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3704 multiple of sizeof (EMACS_INT); it need not be, if
3705 alignof(EMACS_INT) < sizeof (EMACS_INT).
3706 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3707
3708 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3709
3710 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3711
3712 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3713
3714 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3715 supposed to be handshaking. (Bug#8556)
3716 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3717
3718 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3719
3720 * lisp.h (Qdebug): List symbol.
3721 * eval.c (Qdebug): Restore global linkage.
3722 * keyboard.c (debug-on-event): New variable.
3723 (handle_user_signal): Break into debugger when debug-on-event
3724 matches the current signal symbol.
3725
3726 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3727
3728 * alloc.c (check_sblock, check_string_bytes)
3729 (check_string_free_list): Convert to standard C.
3730
3731 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3732
3733 * w32.c (emacs_gnutls_push): Fix typo.
3734
3735 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3736
3737 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3738 "cast to pointer from integer of different size".
3739
3740 Improve doprnt and its use in verror. (Bug#8545)
3741 * doprnt.c (doprnt): Document the set of format control sequences
3742 supported by the function. Use SAFE_ALLOCA instead of always
3743 using `alloca'.
3744
3745 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3746 is one byte too soon. Don't use xrealloc; instead xfree and
3747 xmalloc anew.
3748
3749 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3750
3751 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3752 callbacks stage.
3753
3754 * gnutls.c: Renamed global_initialized to
3755 gnutls_global_initialized. Added internals for the
3756 :verify-hostname-error, :verify-error, and :verify-flags
3757 parameters of `gnutls-boot' and documented those parameters in the
3758 docstring. Start callback support.
3759 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3760 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3761 on error. Return error code.
3762 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3763 (emacs_gnutls_read): Likewise.
3764 (Fgnutls_boot): Return handshake error code.
3765 (emacs_gnutls_handle_error): New function.
3766 (wsaerror_to_errno): Likewise.
3767
3768 * w32.h (emacs_gnutls_pull): Add prototype.
3769 (emacs_gnutls_push): Likewise.
3770
3771 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3772 (emacs_gnutls_push): Likewise.
3773
3774 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3775
3776 * process.c (wait_reading_process_output): Check if GnuTLS
3777 buffered some data internally if no FDs are set for TLS
3778 connections.
3779
3780 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3781 (LIBS): Link to USER_LIBS.
3782 ($(BLD)/gnutls.$(0)): New target.
3783
3784 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3785
3786 * xdisp.c (handle_single_display_spec): Rename the
3787 display_replaced_before_p argument into display_replaced_p, to
3788 make it consistent with the commentary. Fix typos in the
3789 commentary.
3790
3791 * textprop.c (syms_of_textprop): Remove dead code.
3792 (copy_text_properties): Delete obsolete commentary about an
3793 interface that was deleted long ago. Fix typos in the description
3794 of arguments.
3795
3796 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3797 to changes in oldXMenu/XMenu.h from 2011-04-16.
3798 <menu_help_message, prev_menu_help_message>: Constify.
3799 (IT_menu_make_room): menu->help_text is now `const char **';
3800 adjust.
3801
3802 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3803 to changes in oldXMenu/XMenu.h from 2011-04-16.
3804 (struct XMenu): Declare `help_text' `const char **'.
3805
3806 * xfaces.c <Qunspecified>: Make extern again.
3807
3808 * syntax.c: Include sys/types.h before including regex.h, as
3809 required by Posix.
3810
3811 * doc.c (get_doc_string): Improve the format passed to `error'.
3812
3813 * doprnt.c (doprnt): Improve commentary.
3814
3815 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3816
3817 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3818 them with etags.
3819
3820 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3821 changes in globals.h immediately force recompilation.
3822 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3823 $(CURDIR)/s/ms-w32.h.
3824 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3825
3826 * character.c (Fchar_direction): Function deleted.
3827 (syms_of_character): Don't defsubr it.
3828 <char-direction-table>: Deleted.
3829
3830 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3831
3832 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3833 * doprnt.c: Include limits.h.
3834 (SIZE_MAX): New macro.
3835 (doprnt): Return a size_t value. 2nd arg is now size_t.
3836 Many local variables are now size_t instead of int or unsigned.
3837 Improve overflow protection. Support `l' modifier for integer
3838 conversions. Support %l conversion. Don't assume an EMACS_INT
3839 argument for integer conversions and for %c.
3840
3841 * lisp.h (doprnt): Restore prototype.
3842
3843 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3844 $(SRC)/character.h.
3845
3846 * Makefile.in (base_obj): Add back doprnt.o.
3847
3848 * deps.mk (doprnt.o): Add back prerequisites.
3849 (callint.o): Depend on character.h.
3850
3851 * eval.c (internal_lisp_condition_case): Include the handler
3852 representation in the error message.
3853 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3854 when breaking from the loop.
3855
3856 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3857
3858 * callint.c (Fcall_interactively): When displaying error message
3859 about invalid control letter, pass the character's codepoint, not
3860 a pointer to its multibyte form. Improve display of the character
3861 in octal and display also its hex code.
3862
3863 * character.c (char_string): Use %x to display the (unsigned)
3864 codepoint of an invalid character, to avoid displaying a bogus
3865 negative value.
3866
3867 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3868 `error', not SYMBOL_NAME itself.
3869
3870 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3871 character arguments to `error'.
3872
3873 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3874 to `error' in error message about FINAL_CHAR argument. Make sure
3875 FINAL_CHAR is a character, and use %c when it is passed as
3876 argument to `error'.
3877
3878 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3879
3880 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3881
3882 * w32.c: Include <time.h>.
3883 (sys_localtime): New function.
3884
3885 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
3886
3887 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3888
3889 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
3890
3891 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
3892
3893 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3894 zombies (Bug#8467).
3895
3896 2011-04-19 Eli Zaretskii <eliz@gnu.org>
3897
3898 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3899 gl_state.e_property when gl_state.object is Qt.
3900
3901 * insdel.c (make_gap_larger): Remove limitation of buffer size
3902 to <= INT_MAX.
3903
3904 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
3905
3906 * xdisp.c (lookup_glyphless_char_display)
3907 (produce_glyphless_glyph): Handle cons cell entry in
3908 glyphless-char-display.
3909 (Vglyphless_char_display): Document it.
3910
3911 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3912 glyphless-char-display.
3913
3914 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
3915
3916 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3917
3918 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3919
3920 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3921 definition for no-X builds.
3922
3923 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
3924
3925 Static checks with GCC 4.6.0 and non-default toolkits.
3926
3927 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3928
3929 * process.c (keyboard_bit_set): Define only if SIGIO.
3930 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3931 (send_process): Repair possible setjmp clobbering.
3932
3933 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3934
3935 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3936
3937 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3938
3939 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3940 Define only if needed.
3941
3942 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3943 by pacifying GCC about it. Maybe it's time to retire it?
3944 * xfaces.c (USG, __TIMEVAL__): Likewise.
3945
3946 * dispextern.h (struct redisplay_interface): Rename param
3947 to avoid shadowing.
3948 * termhooks.h (struct terminal): Likewise.
3949 * xterm.c (xembed_send_message): Likewise.
3950
3951 * insdel.c (make_gap_smaller): Define only if
3952 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3953
3954 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3955 it.
3956
3957 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3958 so that we aren't warned about unused symbols.
3959
3960 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3961
3962 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
3963
3964 * xfns.c (x_real_positions): Mark locals as initialized.
3965
3966 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3967
3968 * xterm.c: Fix problems found by static analysis with other toolkits.
3969 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
3970 (x_dispatch_event): Declare static if USE_GTK, and
3971 define if USE_GTK || USE_X_TOOLKIT.
3972 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
3973 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
3974 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3975 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
3976
3977 * xmenu.c (menu_help_callback): Pointer type fixes.
3978 Use const pointers when pointing at readonly data. Avoid pointer
3979 signedness clashes.
3980 (FALSE): Remove unused macro.
3981 (update_frame_menubar): Remove unused decl.
3982
3983 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3984
3985 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3986 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3987 (single_menu_item): Rename local to avoid shadowing.
3988
3989 * keyboard.c (make_lispy_event): Remove unused local var.
3990
3991 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3992 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3993
3994 * bitmaps: Change bitmaps from unsigned char back to the X11
3995 compatible char. Avoid the old compiler warnings about
3996 out-of-range initializers by using, for example, '\xab' rather
3997 than 0xab.
3998
3999 * xgselect.c (xgselect_initialize): Check vs interface
4000 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4001
4002 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4003
4004 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4005 to read-only memory.
4006
4007 * fns.c (vector): Remove; this old hack is no longer needed.
4008
4009 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4010 Remove unused var.
4011 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4012
4013 * xrdb.c (x_load_resources): Omit unused local.
4014
4015 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4016 (x_window): Rename locals to avoid shadowing.
4017 (USG): Use the kludged USG macro, to pacify gcc.
4018
4019 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4020 (x_term_init): Remove local to avoid shadowing.
4021
4022 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4023
4024 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4025 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4026
4027 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4028
4029 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4030
4031 Fix regex.c, syntax.c and friends for buffers > 2GB.
4032 * syntax.h (struct gl_state_s): Declare character position members
4033 EMACS_INT.
4034
4035 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4036
4037 * textprop.c (verify_interval_modification, interval_of):
4038 Declare arguments EMACS_INT.
4039
4040 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4041 EMACS_INT.
4042
4043 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4044
4045 * indent.c (Fvertical_motion): Local variable it_start is now
4046 EMACS_INT.
4047
4048 * regex.c (re_match, re_match_2, re_match_2_internal)
4049 (bcmp_translate, regcomp, regexec, print_double_string)
4050 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4051 (re_compile_pattern, re_exec): Declare arguments and local
4052 variables `size_t' and `ssize_t' and return values `regoff_t', as
4053 appropriate.
4054 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4055 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4056 <compile_stack_type>: `size' and `avail' are now `size_t'.
4057
4058 * regex.h <regoff_t>: Use ssize_t, not int.
4059 (re_search, re_search_2, re_match, re_match_2): Arguments that
4060 specify buffer/string position and length are now ssize_t and
4061 size_t. Return type is regoff_t.
4062
4063 2011-04-16 Ben Key <bkey76@gmail.com>
4064
4065 * nsfont.m: Fixed bugs in ns_get_family and
4066 ns_descriptor_to_entity that were caused by using free to
4067 deallocate memory blocks that were allocated by xmalloc (via
4068 xstrdup). This caused Emacs to crash when compiled with
4069 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4070 --enable-checking=xmallocoverrun). xfree is now used to
4071 deallocate these memory blocks.
4072
4073 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4074
4075 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4076
4077 emacs_write: Accept and return EMACS_INT for sizes.
4078 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4079 et seq.
4080 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4081 Accept and return EMACS_INT.
4082 (emacs_gnutls_write): Return the number of bytes written on
4083 partial writes.
4084 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4085 (emacs_read, emacs_write): Remove check for negative size, as the
4086 Emacs source code has been audited now.
4087 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4088 (emacs_read, emacs_write): Use it.
4089 * process.c (send_process): Adjust to the new signatures of
4090 emacs_write and emacs_gnutls_write. Do not attempt to store
4091 a byte offset into an 'int'; it might overflow.
4092 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4093
4094 * sound.c: Don't assume sizes fit in 'int'.
4095 (struct sound_device.period_size, alsa_period_size):
4096 Return EMACS_INT, not int.
4097 (struct sound_device.write, vox_write, alsa_write):
4098 Accept EMACS_INT, not int.
4099 (wav_play, au_play): Use EMACS_INT to store sizes and to
4100 record read return values.
4101
4102 2011-04-15 Ben Key <bkey76@gmail.com>
4103
4104 * keyboard.c (Qundefined): Don't declare static since it is used
4105 in nsfns.m.
4106 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4107 static since they are used in nsfont.m.
4108
4109 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4110
4111 * process.c (Qprocessp): Don't declare static.
4112 * lisp.h (Qprocessp): Declare again.
4113
4114 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4115
4116 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4117
4118 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4119
4120 Improve C-level modularity by making more things 'static'.
4121
4122 Don't publish debugger-only interfaces to other modules.
4123 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4124 (verify_bytepos, count_markers): Move decls to the only modules
4125 that need them.
4126 * region-cache.h (pp_cache): Likewise.
4127 * window.h (check_all_windows): Likewise.
4128 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4129
4130 * sysdep.c (croak): Now static, if
4131 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4132 * syssignal.h (croak): Declare only if not static.
4133
4134 * alloc.c (refill_memory_reserve): Now static if
4135 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4136 * lisp.h (refill_memory_reserve): Declare only if not static.
4137
4138 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4139 Define only if USE_LUCID.
4140
4141 * xrdb.c (x_customization_string, x_rm_string): Now static.
4142
4143 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4144 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4145
4146 * xdisp.c (draw_row_with_mouse_face): Now static.
4147 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4148
4149 * window.h (check_all_windows): Mark externally visible.
4150
4151 * window.c (window_deletion_count): Now static.
4152
4153 * undo.c: Make symbols static if they're not exported.
4154 (last_undo_buffer, last_boundary_position, pending_boundary):
4155 Now static.
4156
4157 * textprop.c (interval_insert_behind_hooks): Now static.
4158 (interval_insert_in_front_hooks): Likewise.
4159
4160 * term.c: Make symbols static if they're not exported.
4161 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4162 (max_frame_lines, tty_set_terminal_modes):
4163 (tty_reset_terminal_modes, tty_turn_off_highlight):
4164 (get_tty_terminal): Now static.
4165 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4166 * termhooks.h (term_mouse_moveto): Do not declare if
4167 HAVE_WINDOW_SYSTEM.
4168 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4169 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4170
4171 * sysdep.c: Make symbols static if they're not exported.
4172 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4173 Now static.
4174 (sigprocmask_set, full_mask): Remove; unused.
4175 (wait_debugging): Mark as visible.
4176 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4177 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4178
4179 * syntax.c (syntax_temp): Define only if !__GNUC__.
4180
4181 * sound.c (current_sound_device, current_sound): Now static.
4182
4183 * search.c (searchbufs, searchbuf_head): Now static.
4184
4185 * scroll.c (scroll_cost): Remove; unused.
4186 * dispextern.h (scroll_cost): Remove decl.
4187
4188 * region-cache.h (pp_cache): Mark as externally visible.
4189
4190 * process.c: Make symbols static if they're not exported.
4191 (process_tick, update_tick, create_process, chan_process):
4192 (Vprocess_alist, proc_buffered_char, datagram_access):
4193 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4194 (deactivate_process): Mark defn as static, as well as decl.
4195 * lisp.h (create_process): Remove decl.
4196 * process.h (chan_process, Vprocess_alist): Remove decls.
4197
4198 * print.c: Make symbols static if they're not exported.
4199 (print_depth, new_backquote_output, being_printed, print_buffer):
4200 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4201 (print_interval, print_number_index, initial_stderr_stream):
4202 Now static.
4203 * lisp.h (Fprinc): Remove decl.
4204 (debug_output_compilation_hack): Mark as externally visible.
4205
4206 * sysdep.c (croak): Move decl from here to syssignal.h.
4207 * syssignal.h (croak): Put it here, so the API can be checked when
4208 'croak' is called from dissociate_if_controlling_tty.
4209
4210 * minibuf.c: Make symbols static if they're not exported.
4211 (minibuf_save_list, choose_minibuf_frame): Now static.
4212 * lisp.h (choose_minibuf_frame): Remove decl.
4213
4214 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4215
4216 * lread.c: Make symbols static if they're not exported.
4217 (read_objects, initial_obarray, oblookup_last_bucket_number):
4218 Now static.
4219 (make_symbol): Remove; unused.
4220 * lisp.h (initial_obarray, make_symbol): Remove decls.
4221
4222 * keyboard.c: Make symbols static if they're not exported.
4223 (single_kboard, recent_keys_index, total_keys, recent_keys):
4224 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4225 (this_single_command_key_start, echoing, last_auto_save):
4226 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4227 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4228 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4229 (Vlispy_mouse_stem, double_click_count):
4230 Now static.
4231 (force_auto_save_soon): Define only if SIGDANGER.
4232 (ignore_mouse_drag_p): Now static if
4233 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4234 (print_help): Remove; unused.
4235 (stop_character, last_timer_event): Mark as externally visible.
4236 * keyboard.h (ignore_mouse_drag_p): Declare only if
4237 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4238 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4239 * lisp.h (echoing): Remove decl.
4240 (force_auto_save_soon): Declare only if SIGDANGER.
4241 * xdisp.c (redisplay_window): Simplify code, to make it more
4242 obvious that ignore_mouse_drag_p is not accessed if !defined
4243 USE_GTK && !defined HAVE_NS.
4244
4245 * intervals.c: Make symbols static if they're not exported.
4246 (merge_properties_sticky, merge_interval_right, delete_interval):
4247 Now static.
4248 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4249
4250 * insdel.c: Make symbols static if they're not exported.
4251 However, leave prepare_to_modify_buffer alone. It's never
4252 called from outside this function, but that appears to be a bug.
4253 (combine_after_change_list, combine_after_change_buffer):
4254 (adjust_after_replace, signal_before_change): Now static.
4255 (adjust_after_replace_noundo): Remove; unused.
4256 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4257 (signal_before_change): Remove decls.
4258
4259 * indent.c (val_compute_motion, val_vmotion): Now static.
4260
4261 * image.c: Make symbols static if they're not exported.
4262 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4263 if USE_GTK.
4264 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4265 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4266
4267 * fringe.c (standard_bitmaps): Now static.
4268 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4269
4270 * frame.c: Make symbols static if they're not exported.
4271 (x_report_frame_params, make_terminal_frame): Now static.
4272 (get_frame_param): Now static, unless HAVE_NS.
4273 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4274 (x_get_resource_string): Remove; not used.
4275 * frame.h (make_terminal_frame, x_report_frame_params):
4276 (x_get_resource_string); Remove decls.
4277 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4278 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4279
4280 * font.c, fontset.c: Make symbols static if they're not exported.
4281 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4282 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4283 * font.c (font_close_object): Now static.
4284 * font.h (font_close_object): Remove.
4285 * fontset.c (FONTSET_OBJLIST): Remove.
4286 (free_realized_fontset) #if-0 the body, which does nothing.
4287 (face_suitable_for_char_p): #if-0, as it's never called.
4288 * fontset.h (face_suitable_for_char_p): Remove decl.
4289 * xfaces.c (face_at_string_position):
4290 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4291 since 0 is always ASCII.
4292
4293 * fns.c (weak_hash_tables): Now static.
4294
4295 * fileio.c: Make symbols static if they're not exported.
4296 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4297 (Vwrite_region_annotation_buffers): Now static.
4298
4299 * eval.c: Make symbols static if they're not exported.
4300 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4301 * lisp.h (backtrace_list): Remove decl.
4302
4303 * emacs.c: Make symbols static if they're not exported.
4304 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4305 (fatal_error_code, fatal_error_signal_hook, standard_args):
4306 Now static.
4307 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4308 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4309 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4310 * lisp.h (fatal_error_signal_hook): Remove decl.
4311 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4312
4313 * editfns.c: Move a (normally-unused) function to its only use.
4314 * editfns.c, lisp.h (get_operating_system_release): Remove.
4315 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4316 worth the hassle of breaking this out.
4317
4318 * xterm.c: Make symbols static if they're not exported.
4319 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4320 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4321 (x_destroy_window, x_delete_display):
4322 Now static.
4323 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4324 (x_mouse_leave): Remove; unused.
4325 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4326 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4327 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4328 Remove decls.
4329 (x_mouse_leave): Declare only if WINDOWSNT.
4330 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4331 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4332 USE_X_TOOLKIT.
4333
4334 * ftxfont.c: Make symbols static if they're not exported.
4335 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4336 HAVE_FREETYPE.
4337 * font.h (ftxfont_driver): Likewise.
4338
4339 * xfns.c: Make symbols static if they're not exported.
4340 (x_last_font_name, x_display_info_for_name):
4341 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4342 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4343 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4344 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4345 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4346 (last_show_tip_args): Now static.
4347 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4348 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4349 (x_screen_planes): Remove; unused.
4350 * dispextern.h (x_screen_planes): Remove decl.
4351
4352 * dispnew.c: Make symbols static if they're not exported.
4353 * dispextern.h (redraw_garbaged_frames, scrolling):
4354 (increment_row_positions): Remove.
4355 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4356 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4357 Now static.
4358 (redraw_garbaged_frames): Remove; unused.
4359
4360 * xfaces.c: Make symbols static if they're not exported.
4361 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4362 Remove decls.
4363 * xterm.h (defined_color): Remove decls.
4364 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4365 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4366 (menu_face_changed_default, defined_color, free_realized_face):
4367 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4368 (ascii_face_of_lisp_face): Remove; unused.
4369
4370 * xdisp.c: Make symbols static if they're not exported.
4371 * dispextern.h (scratch_glyph_row, window_box_edges):
4372 (glyph_to_pixel_coords, set_cursor_from_row):
4373 (get_next_display_element, set_iterator_to_next):
4374 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4375 (show_mouse_face): Remove decls
4376 * frame.h (message_buf_print): Likewise.
4377 * lisp.h (pop_message, set_message, check_point_in_composition):
4378 Likewise.
4379 * xterm.h (set_vertical_scroll_bar): Likewise.
4380 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4381 (message_buf_print, scratch_glyph_row, displayed_buffer):
4382 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4383 (get_next_display_element, show_mouse_face, window_box_edges):
4384 (frame_to_window_pixel_xy, check_point_in_composition):
4385 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4386 (glyph_to_pixel_coords): Remove; unused.
4387
4388 * dired.c (file_name_completion): Now static.
4389
4390 * dbusbind.c (xd_in_read_queued_messages): Now static.
4391
4392 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4393 * data.c (circular_list_error): Remove.
4394
4395 * commands.h (last_point_position, last_point_position_buffer):
4396 (last_point_position_window): Remove decls.
4397 * keyboard.c: Make these variables static.
4398
4399 * coding.h (coding, code_convert_region, encode_coding_gap):
4400 Remove decls.
4401 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4402 (iso_code_class, detect_coding, code_convert_region): Now static.
4403 (encode_coding_gap): Remove; unused.
4404
4405 * chartab.c (chartab_chars, chartab_bits): Now static.
4406
4407 * charset.h (charset_iso_8859_1): Remove decl.
4408 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4409 Now static.
4410
4411 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4412 * ccl.c (Vccl_program_table): Now static.
4413 (check_ccl_update): Remove; unused.
4414
4415 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4416 * category.h: ... from here.
4417 * category.c (check_category_table, set_category_set): Now static.
4418
4419 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4420 * lisp.h: Remove these decls.
4421
4422 * buffer.c (buffer_count): Remove unused var.
4423
4424 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4425 so that it's not optimized away.
4426 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4427 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4428 exported only to the debugger.
4429
4430 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4431 * atimer.h (run_all_atimers): Remove; not exported.
4432
4433 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4434 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4435 was inaccessible from Lisp.
4436 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4437 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4438
4439 alloc.c: Import and export fewer symbols, and remove unused items.
4440 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4441 is defined.
4442 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4443 it's not optimized away by whole-program optimization.
4444 (message_enable_multibyte, free_misc): Remove.
4445 (catchlist, handlerlist, mark_backtrace):
4446 Declare only if BYTE_MARK_STACK.
4447 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4448 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4449 (message_enable_multibyte): Remove decl.
4450 (free_misc, interval_free_list, float_block, float_block_index):
4451 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4452 (cons_free_list, last_marked_index):
4453 Now static.
4454 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4455 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4456 (mark_backtrace): Define only if BYTE_MARK_STACK.
4457 * xdisp.c (message_enable_multibyte): Now static.
4458
4459 Declare Lisp_Object Q* variables to be 'static' if not exported.
4460 This makes it easier for human readers (and static analyzers)
4461 to see whether these variables are used from other modules.
4462 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4463 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4464 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4465 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4466 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4467 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4468 * xmenu.c, xselect.c:
4469 Declare Q* vars static if they are not used in other modules.
4470 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4471 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4472 Remove decls of unexported vars.
4473 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4474
4475 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4476
4477 Make Emacs functions such as Fatom 'static' by default.
4478 This makes it easier for human readers (and static analyzers)
4479 to see whether these functions can be called from other modules.
4480 DEFUN now defines a static function. To make the function external
4481 so that it can be used in other C modules, use the new macro DEFUE.
4482 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4483 (Finit_image_library):
4484 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4485 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4486 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4487 Remove decls, since these functions are now static.
4488 (Funintern, Fget_internal_run_time): New decls, since these functions
4489 were already external.
4490
4491 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4492 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4493 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4494 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4495 * keyboard.c, keymap.c, lread.c:
4496 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4497 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4498 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4499 Mark functions with DEFUE instead of DEFUN,
4500 if they are used in other modules.
4501 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4502 decls for now-static functions.
4503 * buffer.h (Fdelete_overlay): Remove decl.
4504 * callproc.c (Fgetenv_internal): Mark as internal.
4505 * composite.c (Fremove_list_of_text_properties): Remove decl.
4506 (Fcomposition_get_gstring): New forward static decl.
4507 * composite.h (Fcomposite_get_gstring): Remove decl.
4508 * dired.c (Ffile_attributes): New forward static decl.
4509 * doc.c (Fdocumntation_property): New forward static decl.
4510 * eval.c (Ffetch_bytecode): New forward static decl.
4511 (Funintern): Remove extern decl; now in .h file where it belongs.
4512 * fileio.c (Fmake_symbolic_link): New forward static decl.
4513 * image.c (Finit_image_library): New forward static decl.
4514 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4515 * intervals.h (Fprevious_property_change):
4516 (Fremove_list_of_text_properties): Remove decls.
4517 * keyboard.c (Fthis_command_keys): Remove decl.
4518 (Fcommand_execute): New forward static decl.
4519 * keymap.c (Flookup_key): New forward static decl.
4520 (Fcopy_keymap): Now static.
4521 * keymap.h (Flookup_key): Remove decl.
4522 * process.c (Fget_process): New forward static decl.
4523 (Fprocess_datagram_address): Mark as internal.
4524 * syntax.c (Fsyntax_table_p): New forward static decl.
4525 (skip_chars): Remove duplicate decl.
4526 * textprop.c (Fprevious_property_change): New forward static decl.
4527 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4528 Now internal.
4529 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4530 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4531
4532 * editfns.c (Fformat): Remove unreachable code.
4533
4534 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4535
4536 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4537 change. (Bug#8496)
4538
4539 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4540
4541 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4542 when at ZV. (Bug#8487)
4543
4544 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4545
4546 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4547 (Bug#8437)
4548 * keyboard.c (parse_tool_bar_item): Likewise.
4549 * sound.c (sound_cleanup, alsa_close): Likewise.
4550 * termcap.c (tgetent): Likewise.
4551 * xfns.c (x_default_font_parameter): Likewise.
4552 * xsettings.c (read_and_apply_settings): Likewise.
4553
4554 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4555 (overrun_check_free): Protoize.
4556
4557 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4558
4559 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4560 since callers should never pass a negative size.
4561 Change the signature to match that of plain 'read' and 'write'; see
4562 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4563 * lisp.h: Update prototypes of emacs_write and emacs_read.
4564
4565 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4566
4567 * xdisp.c (redisplay_window): Don't try to determine the character
4568 position of the scroll margin if the window start point w->startp
4569 is outside the buffer's accessible region. (Bug#8468)
4570
4571 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4572
4573 Fix write-region and its subroutines for buffers > 2GB.
4574 * fileio.c (a_write, e_write): Modify declaration of arguments and
4575 local variables to support buffers larger than 2GB.
4576 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4577
4578 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4579 argument, local variables, and return value.
4580
4581 * lisp.h: Update prototypes of emacs_write and emacs_read.
4582
4583 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4584
4585 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4586
4587 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4588
4589 Fix more problems found by GCC 4.6.0's static checks.
4590
4591 * xdisp.c (vmessage): Use a better test for character truncation.
4592
4593 * charset.c (load_charset_map): <, not <=, for optimization,
4594 and to avoid potential problems with integer overflow.
4595 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4596 * casetab.c (set_identity, shuffle): Likewise.
4597 * editfns.c (Fformat): Likewise.
4598 * syntax.c (skip_chars): Likewise.
4599
4600 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4601 This also lets GCC 4.6.0 generate slightly better loop code.
4602
4603 * callint.c (Fcall_interactively): <, not <=, for optimization.
4604 (Fcall_interactively): Count the number of arguments produced,
4605 not the number of arguments given. This is simpler and lets GCC
4606 4.6.0 generate slightly better code.
4607
4608 * ftfont.c: Distingish more carefully between FcChar8 and char.
4609 The previous code passed unsigned char * to a functions like
4610 strlen and xstrcasecmp that expect char *, which does not
4611 conform to the C standard.
4612 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4613 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4614 char * when the C standard requires it.
4615
4616 * keyboard.c (read_char): Remove unused var.
4617
4618 * eval.c: Port to Windows vsnprintf (Bug#8435).
4619 Include <limits.h>.
4620 (SIZE_MAX): Define if the headers do not.
4621 (verror): Do not give up if vsnprintf returns a negative count.
4622 Instead, grow the buffer. This ports to Windows vsnprintf, which
4623 does not conform to C99. Problem reported by Eli Zaretskii.
4624 Also, simplify the allocation scheme, by avoiding the need for
4625 calling realloc, and removing the ALLOCATED variable.
4626
4627 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4628
4629 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4630 But keep the doprint source code for now, as we might revamp it
4631 and use it again (Bug#8435).
4632 * lisp.h (doprnt): Remove.
4633 * Makefile.in (base_obj): Remove doprnt.o.
4634 * deps.mk (doprnt.o): Remove.
4635
4636 error: Print 32- and 64-bit integers portably (Bug#8435).
4637 Without this change, on typical 64-bit hosts error ("...%d...", N)
4638 was used to print both 32- and 64-bit integers N, which relied on
4639 undefined behavior.
4640 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4641 New macro.
4642 * lisp.h (error, verror): Mark as printf-like functions.
4643 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4644 Report overflow in size calculations when allocating printf buffer.
4645 Do not truncate output string at its first null byte.
4646 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4647 Truncate the output at a character boundary, since vsnprintf does not
4648 do that.
4649 * charset.c (check_iso_charset_parameter): Convert internal
4650 character to string before calling 'error', since %c now has the
4651 printf meaning.
4652 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4653 overflow when computing char to be passed to 'error'. Do not
4654 pass Lisp_Object to 'error'; pass the integer instead.
4655 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4656 formatted with plain %d.
4657
4658 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4659
4660 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4661
4662 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4663
4664 * xterm.c (x_catch_errors): Remove duplicate declaration.
4665
4666 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4667
4668 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4669
4670 2011-04-10 Jim Meyering <meyering@redhat.com>
4671
4672 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4673 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4674 return ssize_t not "int", and use size_t as the buffer length.
4675 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4676 * gnutls.h: Update declarations.
4677 * process.c (read_process_output): Use ssize_t, to match.
4678 (send_process): Likewise.
4679
4680 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4681
4682 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4683
4684 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4685
4686 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4687 Use unsigned char, to match FcChar8 type definition.
4688
4689 * xterm.c (handle_one_xevent):
4690 * xmenu.c (create_and_show_popup_menu):
4691 * xselect.c (x_decline_selection_request)
4692 (x_reply_selection_request): Avoid type-punned deref of X events.
4693
4694 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4695
4696 Fix some uses of `int' instead of EMACS_INT.
4697 * search.c (string_match_1, fast_string_match)
4698 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4699 (scan_buffer, find_next_newline_no_quit)
4700 (find_before_next_newline, search_command, Freplace_match)
4701 (Fmatch_data): Make some `int' variables be EMACS_INT.
4702
4703 * xdisp.c (display_count_lines): 3rd argument and return value now
4704 EMACS_INT. All callers changed.
4705 (pint2hrstr): Last argument is now EMACS_INT.
4706
4707 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4708 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4709 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4710 (decode_coding_utf_16, decode_coding_emacs_mule)
4711 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4712 (decode_coding_ccl, decode_coding_charset)
4713 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4714 (decode_coding_iso_2022, decode_coding_emacs_mule)
4715 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4716 <char_offset, last_offset>: Declare EMACS_INT.
4717 (encode_coding_utf_8, encode_coding_utf_16)
4718 (encode_coding_emacs_mule, encode_invocation_designation)
4719 (encode_designation_at_bol, encode_coding_iso_2022)
4720 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4721 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4722 Declare EMACS_INT.
4723 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4724 (encode_invocation_designation): Last argument P_NCHARS is now
4725 EMACS_INT.
4726 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4727 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4728
4729 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4730 All users changed.
4731
4732 * ccl.c (Fccl_execute_on_string): Declare some variables
4733 EMACS_INT.
4734
4735 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4736
4737 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4738
4739 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4740
4741 * process.c (Fformat_network_address): Doc fix.
4742
4743 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4744
4745 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4746
4747 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4748
4749 * keyboard.c (read_char): Call Lisp function help-form-show,
4750 instead of using internal_with_output_to_temp_buffer.
4751 (Qhelp_form_show): New var.
4752 (syms_of_keyboard): Use DEFSYM macro.
4753
4754 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4755
4756 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4757
4758 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4759
4760 * process.c (Flist_processes): Remove to Lisp.
4761 (list_processes_1): Delete.
4762
4763 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4764
4765 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4766
4767 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4768
4769 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4770
4771 Fix more problems found by GCC 4.6.0's static checks.
4772
4773 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4774
4775 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4776
4777 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4778
4779 * xdisp.c (vmessage): Mark as a printf-like function.
4780
4781 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4782
4783 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4784
4785 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4786 printf-like functions.
4787 (tiff_load): Add casts to remove these marks before passing them
4788 to system-supplied API.
4789
4790 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4791
4792 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4793 This avoids several warnings with gcc -Wstrict-overflow.
4794 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4795 directly, rather than having caller test rule sign. This avoids
4796 some unnecessary tests.
4797 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4798 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4799 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4800
4801 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4802 (xfont_open): Avoid unnecessary tests.
4803
4804 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4805
4806 * composite.h, composite.c (composition_gstring_put_cache):
4807 Use EMACS_INT, not int, for length.
4808
4809 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4810 breaking out part of COMPOSITION_DECODE_RULE.
4811 (COMPOSITION_DECODE_RULE): Use it.
4812 * composite.c (get_composition_id): Remove unused local vars,
4813 by using the new macro.
4814
4815 * textprop.c (set_text_properties_1): Change while to do-while,
4816 since the condition is always true at first.
4817
4818 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4819 (interval_deletion_adjustment): Return unsigned value.
4820 All uses changed.
4821
4822 * process.c (list_processes_1, create_pty, read_process_output):
4823 (exec_sentinel): Remove vars that were set but not used.
4824 (create_pty): Remove unnecessary "volatile"s.
4825 (Fnetwork_interface_info): Avoid possibility of int overflow.
4826 (read_process_output): Do adaptive read buffering even if carryover.
4827 (read_process_output): Simplify nbytes computation if buffered.
4828
4829 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4830
4831 * syntax.c (scan_words): Remove var that was set but not used.
4832 (update_syntax_table): Use unsigned instead of int.
4833
4834 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4835 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4836 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4837
4838 * print.c (print_error_message): Avoid int overflow.
4839
4840 * font.c (font_list_entities): Redo for clarity,
4841 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4842
4843 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4844 (font_score): Avoid potential overflow in diff calculation.
4845
4846 * fns.c (substring_both): Remove var that is set but not used.
4847 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4848
4849 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4850
4851 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4852 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4853 can always succeed if overflow has undefined behavior.
4854
4855 * search.c (boyer_moore, wordify): Remove vars set but not used.
4856 (wordify): Omit three unnecessary tests.
4857
4858 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4859 All callers changed. This avoids the need for an unused var.
4860
4861 * casefiddle.c (casify_region): Remove var that is set but not used.
4862
4863 * dired.c (file_name_completion): Remove var that is set but not used.
4864
4865 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4866
4867 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4868 (Finsert_file_contents): Remove unnecessary code checking fd.
4869
4870 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4871 Check for integer overflow on size calculations.
4872
4873 * buffer.c (Fprevious_overlay_change): Remove var that is set
4874 but not used.
4875
4876 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4877 Remove vars that are set but not used.
4878 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4879 (timer_check_2): Mark vars as initialized.
4880
4881 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4882
4883 * image.c (lookup_image): Remove var that is set but not used.
4884 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
4885
4886 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4887 that are set but not used.
4888
4889 * xfns.c (make_invisible_cursor): Don't return garbage
4890 if XCreateBitmapFromData fails (Bug#8410).
4891
4892 * xselect.c (x_get_local_selection, x_handle_property_notify):
4893 Remove vars that are set but not used.
4894
4895 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
4896 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
4897
4898 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4899 Remove var that is set but not used.
4900 (scroll_bar_windows_size): Now size_t, not int.
4901 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4902 Check for overflow.
4903
4904 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4905 (map_tty_color) [!defined MSDOS]: Likewise.
4906
4907 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4908
4909 * coding.c: Remove vars that are set but not used.
4910 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4911 All callers changed.
4912 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4913 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4914 (decode_coding_charset): Remove vars that are set but not used.
4915
4916 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4917 that is set but not used.
4918
4919 * print.c (print_object): Remove var that is set but not used.
4920
4921 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
4922 The gnulib version avoids calling malloc in the usual case,
4923 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4924 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4925 * filelock.c (current_lock_owner): Likewise.
4926 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4927 * sysdep.c: Include allocator.h, careadlinkat.h.
4928 (emacs_no_realloc_allocator): New static constant.
4929 (emacs_readlink): New function.
4930 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4931 ../lib/careadlinkat.h.
4932
4933 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4934
4935 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4936 first non-nil return value).
4937
4938 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4939
4940 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4941 if not defined (Bug#8403).
4942
4943 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4944
4945 * xdisp.c (display_count_lines): Remove parameter `start',
4946 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4947 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4948 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4949 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4950 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4951 and thereabouts. All callers changed.
4952 (get_per_char_metric): Remove parameter `f', unused since
4953 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4954
4955 2011-04-02 Jim Meyering <meyering@redhat.com>
4956
4957 do not dereference NULL upon failed strdup
4958 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4959 (ns_get_family): Likewise.
4960
4961 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4962
4963 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4964
4965 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4966
4967 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4968 later (Bug#8403).
4969
4970 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4971
4972 Add lexical binding.
4973
4974 * window.c (Ftemp_output_buffer_show): New fun.
4975 (Fsave_window_excursion):
4976 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4977
4978 * lread.c (lisp_file_lexically_bound_p): New function.
4979 (Fload): Bind Qlexical_binding.
4980 (readevalloop): Remove `evalfun' arg.
4981 Bind Qinternal_interpreter_environment.
4982 (Feval_buffer): Bind Qlexical_binding.
4983 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4984 Mark as dynamic.
4985 (syms_of_lread): Declare `lexical-binding'.
4986
4987 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4988
4989 * keyboard.c (eval_dyn): New fun.
4990 (menu_item_eval_property): Use it.
4991
4992 * image.c (parse_image_spec): Use Ffunctionp.
4993
4994 * fns.c (concat, mapcar1): Accept byte-code-functions.
4995
4996 * eval.c (Fsetq): Handle lexical vars.
4997 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4998 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4999 (FletX, Flet): Obey lexical binding.
5000 (Fcommandp): Handle closures.
5001 (Feval): New `lexical' arg.
5002 (eval_sub): New function extracted from Feval. Use it almost
5003 everywhere where Feval was used. Look up vars in lexical env.
5004 Handle closures.
5005 (Ffunctionp): Move from subr.el.
5006 (Ffuncall): Handle closures.
5007 (apply_lambda): Remove `eval_flags'.
5008 (funcall_lambda): Handle closures and new byte-code-functions.
5009 (Fspecial_variable_p): New function.
5010 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5011 but without exporting it to Lisp.
5012
5013 * doc.c (Fdocumentation, store_function_docstring):
5014 * data.c (Finteractive_form): Handle closures.
5015
5016 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5017 interactive spec.
5018
5019 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5020 New byte-codes.
5021 (exec_byte_code): New function extracted from Fbyte_code to handle new
5022 calling convention for byte-code-functions. Add new byte-codes.
5023
5024 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5025
5026 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5027
5028 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5029
5030 * xdisp.c (redisplay_internal): Fix prototype.
5031
5032 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5033
5034 * xdisp.c (SCROLL_LIMIT): New macro.
5035 (try_scrolling): Use it when setting scroll_limit.
5036 Limit scrolling to 100 screen lines.
5037 (redisplay_window): Even when falling back on "recentering",
5038 position point in the window according to scroll-conservatively,
5039 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5040
5041 (try_scrolling): When point is above the window, allow searching
5042 as far as scroll_max, or one screenful, to compute vertical
5043 distance from PT to the scroll margin position. This prevents
5044 try_scrolling from unnecessarily failing when
5045 scroll-conservatively is set to a value slightly larger than the
5046 window height. Clean up the case of PT below the margin at bottom
5047 of window: scroll_max can no longer be INT_MAX. When aggressive
5048 scrolling is in use, don't let point enter the opposite scroll
5049 margin as result of the scroll.
5050 (syms_of_xdisp) <scroll-conservatively>: Document the
5051 threshold of 100 lines for never-recentering scrolling.
5052
5053 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5054
5055 * dispextern.h (move_it_by_lines):
5056 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5057 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5058 (message_log_check_duplicate): Remove parameters `prev_bol' and
5059 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5060 (redisplay_internal): Remove parameter `preserve_echo_area',
5061 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5062
5063 * indent.c (Fvertical_motion):
5064 * window.c (window_scroll_pixel_based, Frecenter):
5065 Don't pass `need_y_p' to `move_it_by_lines'.
5066
5067 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5068
5069 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5070 steal a few bits to be more compact.
5071 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5072 Remove unneeded casts.
5073
5074 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5075
5076 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5077
5078 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5079 binding" message (bug#7967).
5080
5081 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5082
5083 Fix more problems found by GCC 4.6.0's static checks.
5084
5085 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5086 Remove unused local var.
5087
5088 * editfns.c (Fmessage_box): Remove unused local var.
5089
5090 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5091 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5092 Omit unused local vars.
5093 * window.c (shrink_windows): Omit unused local var.
5094 * menu.c (digest_single_submenu): Omit unused local var.
5095 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5096 Omit unused local var.
5097
5098 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5099 Don't assume string length fits in int.
5100 (keyremap_step, read_key_sequence): Use size_t for sizes.
5101 (read_key_sequence): Don't check last_real_key_start redundantly.
5102
5103 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5104 instead of alloca (Bug#8344).
5105
5106 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5107 (Fbacktrace_frame): Don't assume nframes fits in int.
5108
5109 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5110
5111 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5112 concerns.
5113
5114 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5115
5116 * cm.c (calccost): Turn while-do into do-while, for clarity.
5117
5118 * keyboard.c (syms_of_keyboard): Use the same style as later
5119 in this function when indexing through an array. This also
5120 works around GCC bug 48267.
5121
5122 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5123
5124 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5125
5126 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5127 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5128
5129 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5130 This avoids undefined behavior on integer overflow, and is a bit
5131 more convenient anyway since it is compared to a size_t variable.
5132
5133 Variadic C functions now count arguments with size_t, not int.
5134 This avoids an unnecessary limitation on 64-bit machines, which
5135 caused (substring ...) to crash on large vectors (Bug#8344).
5136 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5137 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5138 All variadic functions and their callers changed accordingly.
5139 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5140 * data.c (arith_driver, float_arith_driver): Likewise.
5141 * editfns.c (general_insert_function): Likewise.
5142 * eval.c (struct backtrace.nargs, interactive_p)
5143 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5144 (funcall_lambda, mark_backtrace): Likewise.
5145 * fns.c (concat): Likewise.
5146 * frame.c (x_set_frame_parameters): Likewise.
5147 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5148 0 if not found, not -1. All callers changed.
5149
5150 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5151 (stack_copy_size): Now size_t, not int.
5152 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5153
5154 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5155
5156 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5157 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5158 All callers changed.
5159
5160 * lisp.h (multibyte_char_to_unibyte):
5161 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5162 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5163 * character.h (CHAR_TO_BYTE8):
5164 * cmds.c (internal_self_insert):
5165 * editfns.c (general_insert_function):
5166 * keymap.c (push_key_description):
5167 * search.c (Freplace_match):
5168 * xdisp.c (message_dolog, set_message_1): All callers changed.
5169
5170 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5171
5172 * keyboard.c (safe_run_hook_funcall): New function.
5173 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5174 don't set the hook to nil, but remove the offending function instead.
5175 (Qcommand_hook_internal): Remove, unused.
5176 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5177 Vcommand_hook_internal.
5178
5179 * eval.c (enum run_hooks_condition): Remove.
5180 (funcall_nil, funcall_not): New functions.
5181 (run_hook_with_args): Call each function through a `funcall' argument.
5182 Remove `cond' argument, now redundant.
5183 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5184 (Frun_hook_with_args_until_failure): Adjust accordingly.
5185 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5186
5187 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5188
5189 * dispextern.h (string_buffer_position): Remove declaration.
5190
5191 * print.c (strout): Remove parameter `multibyte', unused since
5192 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5193
5194 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5195 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5196 All callers changed.
5197
5198 * w32.c (_wsa_errlist): Use braces for struct initializers.
5199
5200 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5201 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5202 All callers changed.
5203 (string_buffer_position): Likewise. Also, make static (it's never
5204 used outside xdisp.c).
5205 (cursor_row_p): Remove parameter `w', unused since
5206 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5207 (decode_mode_spec): Remove parameter `precision', introduced during
5208 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5209 All callers changed.
5210
5211 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5212
5213 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5214
5215 2011-03-27 Anders Lindgren <andlind@gmail.com>
5216
5217 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5218 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5219 (ns_update_auto_hide_menu_bar): New functions.
5220 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5221 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5222 ns_constrain_all_frames.
5223 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5224 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5225
5226 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5227
5228 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5229
5230 2011-03-27 Glenn Morris <rgm@gnu.org>
5231
5232 * syssignal.h: Replace RETSIGTYPE with void.
5233 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5234 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5235 Replace SIGTYPE with void everywhere.
5236 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5237 * s/template.h (SIGTYPE): Remove commented out definition.
5238
5239 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5240
5241 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5242 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5243
5244 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5245
5246 * w32.c (read_unc_volume): Use parameter `henum', instead of
5247 global variable `wget_enum_handle'.
5248
5249 * keymap.c (describe_vector): Remove parameters `indices' and
5250 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5251 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5252
5253 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5254
5255 * keyboard.c (timer_check): Remove parameter `do_it_now',
5256 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5257 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5258 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5259
5260 * keyboard.c (read_char):
5261 * w32menu.c (w32_menu_display_help):
5262 * xmenu.c (show_help_event, menu_help_callback):
5263 Adjust calls to `show_help_echo'.
5264
5265 * gtkutil.c (xg_maybe_add_timer):
5266 * keyboard.c (readable_events):
5267 * process.c (wait_reading_process_output):
5268 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5269
5270 * insdel.c (adjust_markers_gap_motion):
5271 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5272 (gap_left, gap_right): Don't call it.
5273
5274 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5275
5276 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5277 incurred during fontification.
5278
5279 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5280
5281 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5282 (DEFVAR_PER_BUFFER): Don't pass it.
5283
5284 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5285 (scrolling_window): Don't pass it.
5286
5287 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5288
5289 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5290
5291 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5292 and `suffix'.
5293 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5294 of variables specific to SELinux and computation of `encoded_absname'.
5295
5296 * image.c (XPutPixel): Remove unused variable `height'.
5297
5298 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5299
5300 * unexw32.c (get_section_info): Remove unused variable `section'.
5301
5302 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5303 (system_process_attributes): Remove unused variable `sess'.
5304 (sys_read): Remove unused variable `err'.
5305
5306 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5307 (w32_wnd_proc): Remove unused variable `isdead'.
5308 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5309 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5310 (x_create_tip_frame): Remove unused variable `tem'.
5311
5312 * w32inevt.c (w32_console_read_socket):
5313 Remove unused variable `no_events'.
5314
5315 * w32term.c (x_draw_composite_glyph_string_foreground):
5316 Remove unused variable `width'.
5317
5318 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5319
5320 * w32term.c (x_set_glyph_string_clipping):
5321 Don't pass uninitialized region to CombineRgn.
5322
5323 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5324
5325 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5326 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5327 (Fx_close_connection): Remove unused variable `i'.
5328
5329 * w32font.c (w32font_draw): Return number of glyphs.
5330 (w32font_open_internal): Remove unused variable `i'.
5331 (w32font_driver): Add missing initializer.
5332
5333 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5334 (fill_in_menu): Remove unused variable `items_added'.
5335
5336 * w32term.c (last_mouse_press_frame): Remove static global variable.
5337 (w32_clip_to_row): Remove unused variable `f'.
5338 (x_delete_terminal): Remove unused variable `i'.
5339
5340 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5341 (NOTHING): Remove unused static global variable.
5342 (uniscribe_check_otf): Remove unused variable `table'.
5343 (uniscribe_font_driver): Add missing initializers.
5344
5345 2011-03-23 Julien Danjou <julien@danjou.info>
5346
5347 * term.c (Fsuspend_tty, Fresume_tty):
5348 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5349 * window.c (temp_output_buffer_show):
5350 * insdel.c (signal_before_change):
5351 * frame.c (Fhandle_switch_frame):
5352 * fileio.c (Fdo_auto_save):
5353 * emacs.c (Fkill_emacs):
5354 * editfns.c (save_excursion_restore):
5355 * cmds.c (internal_self_insert):
5356 * callint.c (Fcall_interactively):
5357 * buffer.c (Fkill_all_local_variables):
5358 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5359 Use Frun_hooks.
5360 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5361 unconditionnaly since it does the check itself.
5362
5363 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5364
5365 Fix more problems found by GCC 4.5.2's static checks.
5366
5367 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5368 the first time through the loop, since we know p0 < p1 then.
5369 This also avoids a gcc -Wstrict-overflow warning.
5370
5371 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5372 leading to a memory leak, possible in functions like
5373 load_charset_map_from_file that can allocate an unbounded number
5374 of objects (Bug#8318).
5375
5376 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5377 that could (at least in theory) be that large.
5378
5379 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5380 This is less likely to overflow, and avoids undefined behavior if
5381 overflow does occur. All callers changed. Use strtoul to scan
5382 for the unsigned long integer.
5383 (pint2hrstr): Simplify and tune code slightly.
5384 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5385
5386 * scroll.c (do_scrolling): Work around GCC bug 48228.
5387 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5388
5389 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5390 This also avoids a warning with gcc -Wstrict-overflow.
5391 (validate_x_resource_name): Simplify count usage.
5392 This also avoids a warning with gcc -Wstrict-overflow.
5393
5394 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5395 fail (Bug#8306).
5396
5397 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5398
5399 * process.c (Fmake_network_process): Use socklen_t, not int,
5400 where POSIX says socklen_t is required in portable programs.
5401 This fixes a porting bug on hosts like 64-bit HP-UX, where
5402 socklen_t is wider than int (Bug#8277).
5403 (Fmake_network_process, server_accept_connection):
5404 (wait_reading_process_output, read_process_output):
5405 Likewise.
5406
5407 * process.c: Rename or move locals to avoid shadowing.
5408 (list_processes_1, Fmake_network_process):
5409 (read_process_output_error_handler, exec_sentinel_error_handler):
5410 Rename or move locals.
5411 (Fmake_network_process): Define label "retry_connect" only if needed.
5412 (Fnetwork_interface_info): Fix pointer signedness.
5413 (process_send_signal): Add cast to avoid pointer signedness problem.
5414 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5415 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5416
5417 Make tparam.h and terminfo.c consistent.
5418 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5419 Include tparam.h instead, since it declares them.
5420 * cm.h (PC): Remove extern decl; tparam.h now does this.
5421 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5422 * terminfo.c: Include tparam.h, to check interfaces.
5423 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5424 (tparam): Adjust signature to match interface in tparam.h;
5425 this removes some undefined behavior. Check that outstring and len
5426 are zero, which they always are with Emacs.
5427 * tparam.h (PC, BC, UP): New extern decls.
5428
5429 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5430 (xftfont_open): Rename locals to avoid shadowing.
5431
5432 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5433 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5434 (OTF_TAG_SYM): Omit macro if not needed.
5435 (ftfont_list): Remove unused local.
5436 (get_adstyle_property, ftfont_pattern_entity):
5437 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5438 Rename locals to avoid shadowing.
5439
5440 * xfont.c (xfont_list_family): Mark var as initialized.
5441
5442 * xml.c (make_dom): Now static.
5443
5444 * composite.c (composition_compute_stop_pos): Rename local to
5445 avoid shadowing.
5446 (composition_reseat_it): Remove unused locals.
5447 (find_automatic_composition, composition_adjust_point): Likewise.
5448 (composition_update_it): Mark var as initialized.
5449 (find_automatic_composition): Mark vars as initialized,
5450 with a FIXME (Bug#8290).
5451
5452 character.h: Rename locals to avoid shadowing.
5453 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5454 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5455 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5456 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5457 to avoid shadowing.
5458
5459 * textprop.c (property_change_between_p): Remove; unused.
5460
5461 * intervals.c (interval_start_pos): Now static.
5462
5463 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5464
5465 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5466 Rename locals to avoid shadowing.
5467
5468 * sound.c (wav_play, au_play, Fplay_sound_internal):
5469 Fix pointer signedness.
5470 (alsa_choose_format): Remove unused local var.
5471 (wav_play): Initialize a variable to 0, to prevent undefined
5472 behavior (Bug#8278).
5473
5474 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5475
5476 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5477
5478 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5479 clobbering (Bug#8298).
5480 * sysdep.c (sys_subshell): Likewise.
5481 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5482
5483 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5484 This should get cleaned up, so that child_setup has the
5485 same signature on all platforms.
5486
5487 * callproc.c (call_process_cleanup): Now static.
5488 (relocate_fd): Rename locals to avoid shadowing.
5489
5490 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5491
5492 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5493 not to be necessary, and produces flickering.
5494
5495 2011-03-20 Glenn Morris <rgm@gnu.org>
5496
5497 * config.in: Remove file.
5498
5499 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5500
5501 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5502 are now in src/globals.h.
5503 (syms_of_minibuf): Remove spurious & from previous change.
5504
5505 2011-03-20 Leo <sdl.web@gmail.com>
5506
5507 * minibuf.c (completing-read-function): New variable.
5508 (completing-read-default): Rename from completing-read.
5509 (completing-read): Call completing-read-function.
5510
5511 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5512
5513 * xfaces.c (Fx_load_color_file):
5514 Read color file from absolute filename (bug#8250).
5515
5516 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5517
5518 * makefile.w32-in: Update dependencies.
5519
5520 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5521
5522 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5523
5524 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5525
5526 Fix more problems found by GCC 4.5.2's static checks.
5527
5528 * process.c (make_serial_process_unwind, send_process_trap):
5529 (sigchld_handler): Now static.
5530
5531 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5532 That way, the code declares only the vars that it needs.
5533 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5534 * s/cygwin.h (PTY_ITERATION): Likewise.
5535 * s/darwin.h (PTY_ITERATION): Likewise.
5536 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5537
5538 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5539 * process.c (allocate_pty): Don't declare stb unless it's needed.
5540
5541 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5542 (CONSTANTLIM): Remove; unused.
5543 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5544 Define only if needed.
5545
5546 * unexelf.c (unexec): Name an expression,
5547 to avoid gcc -Wbad-function-cast warning.
5548 Use a different way to cause a compilation error if anyone uses
5549 n rather than nn, a way that does not involve shadowing.
5550 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5551
5552 * deps.mk (unexalpha.o): Remove; unused.
5553
5554 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5555 * unexec.h: New file.
5556 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5557 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5558 Depend on unexec.h.
5559 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5560 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5561 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5562 Change as necessary to match prototype in unexec.h.
5563
5564 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5565 shadowing.
5566 (back_comment, skip_chars): Mark vars as initialized.
5567
5568 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5569 Rename locals to avoid shadowing.
5570
5571 * lread.c (read1): Rewrite so as not to use empty "else".
5572 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5573
5574 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5575
5576 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5577 warning when compiling print.c.
5578
5579 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5580 instead of using an uninitialized var.
5581 (font_sort_entities): Mark var as initialized.
5582
5583 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5584
5585 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5586 pointers to constants.
5587 (font_parse_fcname): Remove unused vars.
5588 (font_delete_unmatched): Now static.
5589 (font_get_spec): Remove; unused.
5590 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5591 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5592 Rename or move locals to avoid shadowing.
5593
5594 * fns.c (require_nesting_list, require_unwind): Now static.
5595 (Ffillarray): Rename locals to avoid shadowing.
5596
5597 * floatfns.c (domain_error2): Define only if needed.
5598 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5599
5600 * alloc.c (mark_backtrace): Move decl from here ...
5601 * lisp.h: ... to here, so that it can be checked.
5602
5603 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5604 (Fdefvar): Rewrite so as not to use empty "else".
5605 (lisp_indirect_variable): Name an expression,
5606 to avoid gcc -Wbad-function-cast warning.
5607 (Fdefvar): Rename locals to avoid shadowing.
5608
5609 * callint.c (quotify_arg, quotify_args): Now static.
5610 (Fcall_interactively): Rename locals to avoid shadowing.
5611 Use const pointer when appropriate.
5612
5613 * lisp.h (get_system_name, get_operating_system_release):
5614 Move decls here, to check interfaces.
5615 * process.c (get_operating_system_release): Move decl to lisp.h.
5616 * xrdb.c (get_system_name): Likewise.
5617 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5618 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5619 some of which prompt warnings from gcc -Wbad-function-cast.
5620 (Fformat_time_string, Fencode_time, Finsert_char):
5621 (Ftranslate_region_internal, Fformat):
5622 Rename or remove local vars to avoid shadowing.
5623 (Ftranslate_region_internal): Mark var as initialized.
5624
5625 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5626 avoid shadowing.
5627
5628 * lisp.h (eassert): Check that the argument compiles, even if
5629 ENABLE_CHECKING is not defined.
5630
5631 * data.c (Findirect_variable): Name an expression, to avoid
5632 gcc -Wbad-function-cast warning.
5633 (default_value, arithcompare, arith_driver, arith_error): Now static.
5634 (store_symval_forwarding): Rename local to avoid shadowing.
5635 (Fmake_variable_buffer_local, Fmake_local_variable):
5636 Mark variables as initialized.
5637 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5638
5639 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5640 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5641 Rename locals to avoid shadowing.
5642 (mark_stack): Move local variables into the #ifdef region where
5643 they're used.
5644 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5645 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5646 needed otherwise.
5647 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5648 (GC_STRING_CHARS): Remove; not used.
5649 (Fmemory_limit): Cast sbrk's returned value to char *.
5650
5651 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5652 avoids undefined behavior in theory.
5653
5654 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5655
5656 Use functions, not macros, for up- and down-casing (Bug#8254).
5657 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5658 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5659 to use the following functions instead of these macros.
5660 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5661 EMACS_INT, since callers assume the returned value fits in int.
5662 (upcase1): Likewise, for UPCASE_TABLE.
5663 (uppercasep, lowercasep, upcase): New static inline functions.
5664 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5665 the race-condition problem in the old DOWNCASE.
5666
5667 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5668 Rename locals to avoid shadowing.
5669 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5670 (regex_compile, re_search_2, re_match_2_internal):
5671 Remove unused local vars.
5672 (FREE_VAR): Rewrite so as not to use empty "else",
5673 which gcc can warn about.
5674 (regex_compile, re_match_2_internal): Mark locals as initialized.
5675 (RETALLOC_IF): Define only if needed.
5676 (WORDCHAR_P): Likewise. This one is never needed, but is used
5677 only in a comment talking about a compiler bug, so put inside
5678 the #if 0 of that comment.
5679 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5680 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5681 Remove; unused.
5682
5683 * search.c (boyer_moore): Rename locals to avoid shadowing.
5684 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5685 (PREV_CHAR_BOUNDARY): Likewise.
5686
5687 * search.c (simple_search): Remove unused var.
5688
5689 * dired.c (compile_pattern): Move decl from here ...
5690 * lisp.h: ... to here, so that it can be checked.
5691 (struct re_registers): New forward decl.
5692
5693 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5694
5695 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5696 All uses changed.
5697 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5698 Rename locals to avoid shadowing.
5699 (Fvertical_motion): Mark locals as initialized.
5700
5701 * casefiddle.c (casify_object, casify_region): Now static.
5702 (casify_region): Mark local as initialized.
5703
5704 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5705
5706 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5707 New macros, so that the caller can use some names other than
5708 gcpro1, gcpro2, etc.
5709 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5710 of the new macros.
5711 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5712 argument, for consistency with GCPRO2_VAR, etc: it is now the
5713 prefix of the variable, not the variable itself. All uses
5714 changed.
5715 * dired.c (directory_files_internal, file_name_completion):
5716 Rename locals to avoid shadowing.
5717
5718 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5719 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5720 dired.c's scmp function, had undefined behavior.
5721 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5722 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5723 * buffer.h: ... to here, because these macros use current_buffer,
5724 and the new implementation with inline functions needs to have
5725 current_buffer in scope now, rather than later when the macros
5726 are used.
5727 (downcase, upcase1): New static inline functions.
5728 (DOWNCASE, UPCASE1): Reimplement using these functions.
5729 This avoids undefined behavior in expressions like
5730 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5731 from race conditions in accessing the global variables
5732 case_temp1 and case_temp2.
5733 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5734 * lisp.h (case_temp1, case_temp2): Remove their decls.
5735 * character.h (ASCII_CHAR_P): Move from here ...
5736 * lisp.h: ... to here, so that the inline functions mentioned
5737 above can use them.
5738
5739 * dired.c (directory_files_internal_unwind): Now static.
5740
5741 * fileio.c (file_name_as_directory, directory_file_name):
5742 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5743 Now static.
5744 (file_name_as_directory): Use const pointers when appropriate.
5745 (Fexpand_file_name): Likewise. In particular, newdir might
5746 point at constant storage, so make it a const pointer.
5747 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5748 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5749 signedness issues.
5750 (Fset_file_times, Finsert_file_contents, auto_save_error):
5751 Rename locals to avoid shadowing.
5752
5753 * minibuf.c (choose_minibuf_frame_1): Now static.
5754 (Ftry_completion, Fall_completions): Rename or remove locals
5755 to avoid shadowing.
5756
5757 * marker.c (bytepos_to_charpos): Remove; unused.
5758
5759 * lisp.h (verify_bytepos, count_markers): New decls,
5760 so that gcc does not warn that these functions aren't declared.
5761
5762 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5763 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5764 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5765 (copy_text): Remove unused local var.
5766
5767 * filelock.c (within_one_second): Now static.
5768 (lock_file_1): Rename local to avoid shadowing.
5769
5770 * buffer.c (fix_overlays_before): Mark locals as initialized.
5771 (fix_start_end_in_overlays): Likewise. This function should be
5772 simplified by using pointers-to-pointers, but that's a different
5773 matter.
5774 (switch_to_buffer_1): Now static.
5775 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5776 (report_overlay_modification): Rename locals to avoid shadowing.
5777
5778 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5779 Fix pointer signedness issue.
5780 (sys_subshell): Mark local as volatile if checking for lint,
5781 to suppress a gcc -Wclobbered warning that does not seem to be right.
5782 (MAXPATHLEN): Define only if needed.
5783
5784 * process.c (serial_open, serial_configure): Move decls from here ...
5785 * systty.h: ... to here, so that they can be checked.
5786
5787 * fns.c (get_random, seed_random): Move extern decls from here ...
5788 * lisp.h: ... to here, so that they can be checked.
5789
5790 * sysdep.c (reset_io): Now static.
5791 (wait_for_termination_signal): Remove; unused.
5792
5793 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5794 (copy_keymap_item, append_key, push_text_char_description):
5795 Now static.
5796 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5797 (DENSE_TABLE_SIZE): Remove; unused.
5798 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5799 (describe_map_tree):
5800 Rename locals to avoid shadowing.
5801
5802 * keyboard.c: Declare functions static if they are not used elsewhere.
5803 (echo_char, echo_dash, cmd_error, top_level_2):
5804 (poll_for_input, handle_async_input): Now static.
5805 (read_char, kbd_buffer_get_event, make_lispy_position):
5806 (make_lispy_event, make_lispy_movement, apply_modifiers):
5807 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5808 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5809 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5810 (read_key_sequence, read_char): Mark locals as initialized.
5811 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5812
5813 * keyboard.h (make_ctrl_char): New decl.
5814 (mark_kboards): Move decl here ...
5815 * alloc.c (mark_kboards): ... from here.
5816
5817 * lisp.h (force_auto_save_soon): New decl.
5818
5819 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5820 (DEFINE_DUMMY_FUNCTION): New macro.
5821 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5822 Use it.
5823 (main): Add casts to avoid warnings
5824 if GCC considers string literals to be constants.
5825
5826 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5827
5828 * dbusbind.c: Pointer signedness fixes.
5829 (xd_signature, xd_append_arg, xd_initialize):
5830 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5831 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5832 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5833 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5834
5835 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5836 if GCC considers string literals to be constants.
5837 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5838
5839 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5840
5841 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5842 (print_preprocess, print_object): New macro to fix last change.
5843
5844 * print.c (print_preprocess): Don't forget font objects.
5845
5846 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5847
5848 * emacs.c (USAGE3): Doc fixes.
5849
5850 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5851
5852 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5853 structure.
5854
5855 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5856
5857 * lisp.h (VWindow_system, Qfile_name_history):
5858 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5859 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5860 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5861
5862 * w32select.c: Don't #include "keyboard.h".
5863 (run_protected): Add extern declaration for waiting_for_input.
5864
5865 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5866 * w32console.c (detect_input_pending, read_input_pending)
5867 (encode_terminal_code):
5868 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5869 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5870 (w32_system_caret_y, Qfile_name_history):
5871 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5872 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5873 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5874 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5875 * w32proc.c (Qlocal, report_file_error):
5876 * w32term.c (Vwindow_system, updating_frame):
5877 * w32uniscribe.c (initialized, uniscribe_font_driver):
5878 Remove unneeded extern declarations.
5879
5880 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
5881
5882 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
5883
5884 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
5885
5886 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5887 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5888 These macros can no longer be used for assignment.
5889
5890 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5891 Assign struct members directly, instead of using BUF_BEGV etc.
5892 (record_buffer_markers, fetch_buffer_markers): New functions for
5893 recording and fetching special buffer markers.
5894 (set_buffer_internal_1, set_buffer_temp): Use them.
5895
5896 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5897
5898 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5899
5900 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5901 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5902
5903 * xdisp.c (hscroll_window_tree):
5904 (reconsider_clip_changes): Use PT instead of BUF_PT.
5905
5906 2011-03-13 Eli Zaretskii <eliz@gnu.org>
5907
5908 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5909 $(EMACS_ROOT)/lib/intprops.h.
5910
5911 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5912
5913 Fix more problems found by GCC 4.5.2's static checks.
5914
5915 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5916 to unsigned char * to avoid compiler diagnostic.
5917 (xg_free_frame_widgets): Make it clear that a local variable is
5918 needed only if USE_GTK_TOOLTIP.
5919 (gdk_window_get_screen): Make it clear that this macro is needed
5920 only if USE_GTK_TOOLTIP.
5921 (int_gtk_range_get_value): New function, which avoids a diagnostic
5922 from gcc -Wbad-function-cast.
5923 (xg_set_toolkit_scroll_bar_thumb): Use it.
5924 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5925 diagnostic from gcc -Wbad-function-cast.
5926 (get_utf8_string, xg_get_file_with_chooser):
5927 Rename locals to avoid shadowing.
5928 (create_dialog): Move locals to avoid shadowing.
5929
5930 * xgselect.c (xg_select): Remove unused var.
5931
5932 * image.c (four_corners_best): Mark locals as initialized.
5933 (gif_load): Initialize transparent_p to zero (Bug#8238).
5934 Mark another local as initialized.
5935 (my_png_error, my_error_exit): Mark with NO_RETURN.
5936
5937 * image.c (clear_image_cache): Now static.
5938 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
5939 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
5940 (x_edge_detection): Remove unnecessary cast that
5941 gcc -Wbad-function-cast diagnoses.
5942 (gif_load): Fix pointer signedness.
5943 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5944 (jpeg_load, gif_load): Rename locals to avoid shadowing.
5945
5946 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
5947
5948 Improve quality of tests for time stamp overflow.
5949 For example, without this patch (encode-time 0 0 0 1 1
5950 1152921504606846976) returns the obviously-bogus value (-948597
5951 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5952 reports time overflow. See
5953 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
5954 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5955 * editfns.c: Include limits.h and intprops.h.
5956 (TIME_T_MIN, TIME_T_MAX): New macros.
5957 (time_overflow): Move earlier, to before first use.
5958 (hi_time, lo_time): New functions, for an accurate test for
5959 out-of-range times.
5960 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5961 (Fget_internal_run_time): Don't assume time_t fits in int.
5962 (make_time): Use list2 instead of Fcons twice.
5963 (Fdecode_time): More accurate test for out-of-range times.
5964 (check_tm_member): New function.
5965 (Fencode_time): Use it, to test for out-of-range times.
5966 (lisp_time_argument): Don't rely on undefined left-shift and
5967 right-shift behavior when checking for time stamp overflow.
5968
5969 * editfns.c (time_overflow): New function, refactoring common code.
5970 (Fformat_time_string, Fdecode_time, Fencode_time):
5971 (Fcurrent_time_string): Use it.
5972
5973 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5974 * dired.c (make_time): Move to ...
5975 * editfns.c (make_time): ... here.
5976 * systime.h: Note the move.
5977
5978 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5979
5980 * fringe.c (update_window_fringes): Remove unused variables.
5981
5982 * unexmacosx.c (copy_data_segment): Also copy __got section.
5983 (Bug#8223)
5984
5985 2011-03-12 Eli Zaretskii <eliz@gnu.org>
5986
5987 * termcap.c [MSDOS]: Include "msdos.h".
5988 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5989 Constify `char *' arguments and their references according to
5990 prototypes in tparam.h.
5991
5992 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
5993
5994 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5995 Adapt all references accordingly.
5996
5997 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5998
5999 2011-03-11 Tom Tromey <tromey@redhat.com>
6000
6001 * buffer.c (syms_of_buffer): Remove obsolete comment.
6002
6003 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6004
6005 * termhooks.h (encode_terminal_code): Declare prototype.
6006
6007 * msdos.c (encode_terminal_code): Don't declare prototype.
6008
6009 * term.c (encode_terminal_code): Now external again, used by
6010 w32console.c and msdos.c.
6011
6012 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6013 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6014
6015 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6016
6017 Fix some minor problems found by GCC 4.5.2's static checks.
6018
6019 * fringe.c (update_window_fringes): Mark locals as initialized
6020 (Bug#8227).
6021 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6022
6023 * alloc.c (mark_fringe_data): Move decl from here ...
6024 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6025 to check its interface.
6026 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6027
6028 * fontset.c (free_realized_fontset): Now static.
6029 (Fset_fontset_font): Rename local to avoid shadowing.
6030 (fontset_font): Mark local as initialized.
6031 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6032
6033 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6034
6035 * xselect.c (x_disown_buffer_selections): Remove; not used.
6036 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6037 (x_own_selection, Fx_disown_selection_internal): Rename locals
6038 to avoid shadowing.
6039 (x_handle_dnd_message): Remove local to avoid shadowing.
6040
6041 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6042 so that the caller can use some name other than gcpro1.
6043 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6044 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6045 (Fx_backspace_delete_keys_p):
6046 Use them to avoid shadowing, and rename vars to avoid shadowing.
6047 (x_decode_color, x_set_name, x_window): Now static.
6048 (Fx_create_frame): Add braces to silence GCC warning.
6049 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6050 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6051 Remove unused locals.
6052 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6053 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6054 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6055 macros.
6056
6057 * xterm.h (x_mouse_leave): New decl.
6058
6059 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6060 Remove unused functions.
6061 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6062 (x_calc_absolute_position): Now static.
6063 (XTread_socket): Don't define label "out" unless it's used.
6064 Don't declare local "event" unless it's used.
6065 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6066 unless they are used.
6067 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6068 (x_fatal_error_signal): Remove; not used.
6069 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6070 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6071 (x_error_catcher, x_connection_closed, x_error_handler):
6072 (x_error_quitter, xembed_send_message, x_iconify_frame):
6073 (my_log_handler): Rename locals to avoid shadowing.
6074 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6075 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6076
6077 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6078 Rename or move locals to avoid shadowing.
6079 (tty_defined_color, merge_face_heights): Now static.
6080 (free_realized_faces_for_fontset): Remove; not used.
6081 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6082 does not deduce is never used uninitialized.
6083 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6084 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6085
6086 * terminal.c (store_terminal_param): Now static.
6087
6088 * xmenu.c (menu_highlight_callback): Now static.
6089 (set_frame_menubar): Remove unused local.
6090 (xmenu_show): Rename parameter to avoid shadowing.
6091 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6092 since they might point to immutable storage.
6093 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6094 since it's unused otherwise.
6095
6096 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6097 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6098 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6099 avoids a gcc -Wuninitialized diagnostic.
6100 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6101 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6102 does not deduce are never used uninitialized.
6103
6104 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6105
6106 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6107 * window.c (window_loop, size_window):
6108 (run_window_configuration_change_hook, enlarge_window): Likewise.
6109
6110 * window.c (display_buffer): Now static.
6111 (size_window): Mark variables that gcc -Wuninitialized
6112 does not deduce are never used uninitialized.
6113 * window.h (check_all_windows): New decl, to forestall
6114 gcc -Wmissing-prototypes diagnostic.
6115 * dispextern.h (bidi_dump_cached_states): Likewise.
6116
6117 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6118 shadowing.
6119 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6120 Include <limits.h>.
6121 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6122 and to avoid gcc -Wuninitialized warning.
6123 (load_charset_map): Mark variables that gcc -Wuninitialized
6124 does not deduce are never used uninitialized.
6125 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6126
6127 * coding.c (coding_set_source, coding_set_destination):
6128 Use "else { /* comment */ }" rather than "else /* comment */;"
6129 for clarity, and to avoid gcc -Wempty-body warning.
6130 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6131 a block, when the outer 'i' will do.
6132 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6133 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6134 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6135 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6136 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6137 Rename locals to avoid shadowing.
6138 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6139 * coding.c (emacs_mule_char, encode_invocation_designation):
6140 Now static, since they're not used elsewhere.
6141 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6142 (decode_coding_object, encode_coding_object, detect_coding_system):
6143 (decode_coding_emacs_mule): Mark variables that gcc
6144 -Wuninitialized does not deduce are never used uninitialized.
6145 (detect_coding_iso_2022): Initialize a local variable that might
6146 be used uninitialized. Leave a FIXME because it's not clear that
6147 this initialization is needed. (Bug#8211)
6148 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6149 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6150 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6151 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6152 Remove unused macros.
6153
6154 * category.c (hash_get_category_set): Remove unused local var.
6155 (copy_category_table): Now static, since it's not used elsewhere.
6156 * character.c (string_count_byte8): Likewise.
6157
6158 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6159 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6160
6161 * chartab.c (copy_sub_char_table): Now static, since it's not used
6162 elsewhere.
6163 (sub_char_table_ref_and_range, char_table_ref_and_range):
6164 Rename locals to avoid shadowing.
6165 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6166
6167 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6168 (BIDI_BOB): Remove unused macro.
6169
6170 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6171 deduce are never used uninitialized.
6172 * term.c (encode_terminal_code): Likewise.
6173
6174 * term.c (encode_terminal_code): Now static. Remove unused local.
6175
6176 * tparam.h: New file.
6177 * term.c, tparam.h: Include it.
6178 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6179 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6180 Move these decls to tparam.h, and make them agree with what
6181 is actually in tparam.c. The previous trick of using incompatible
6182 decls in different modules does not conform to the C standard.
6183 All callers of tparam changed to use tparam's actual API.
6184 * tparam.c (tparam1, tparam, tgoto):
6185 Use const pointers where appropriate.
6186
6187 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6188 * cm.h (struct cm): Likewise.
6189 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6190 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6191 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6192 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6193 (turn_on_face, init_tty): Likewise.
6194 * termchar.h (struct tty_display_info): Likewise.
6195
6196 * term.c (term_mouse_position): Rename local to avoid shadowing.
6197
6198 * alloc.c (mark_ttys): Move decl from here ...
6199 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6200
6201 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6202
6203 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6204
6205 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6206
6207 * search.c (compile_pattern_1): Remove argument regp, unused since
6208 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6209 (compile_pattern): Don't pass it.
6210
6211 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6212
6213 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6214 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6215 for ! HAVE_GTK3.
6216 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6217
6218 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6219
6220 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6221 gdk_window_get_screen, gdk_window_get_geometry,
6222 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6223 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6224 (xg_get_pixbuf_from_pixmap): New function.
6225 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6226 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6227 Call xg_get_pixbuf_from_pixmap instead of
6228 gdk_pixbuf_get_from_drawable.
6229 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6230 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6231 (xg_check_special_colors): Use GtkStyleContext and its functions
6232 for HAVE_GTK3.
6233 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6234 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6235 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6236 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6237 Call gtk_widget_get_preferred_size.
6238 (xg_frame_resized): gdk_window_get_geometry only takes 5
6239 parameters.
6240 (xg_win_to_widget, xg_event_is_for_menubar):
6241 Call gdk_x11_window_lookup_for_display.
6242 (xg_set_widget_bg): New function.
6243 (delete_cb): New function.
6244 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6245 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6246 (xg_set_background_color): Call xg_set_widget_bg.
6247 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6248 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6249 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6250 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6251 if ! HAVE_GTK3.
6252 (update_frame_tool_bar): Call gtk_widget_hide.
6253 (xg_initialize): Use GDK_KEY_g.
6254
6255 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6256 if ! HAVE_GTK3
6257 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6258
6259 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6260 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6261 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6262
6263 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6264
6265 * w32xfns.c (select_palette): Check success of RealizePalette against
6266 GDI_ERROR, not zero.
6267
6268 See ChangeLog.11 for earlier changes.
6269
6270 ;; Local Variables:
6271 ;; coding: utf-8
6272 ;; End:
6273
6274 Copyright (C) 2011 Free Software Foundation, Inc.
6275
6276 This file is part of GNU Emacs.
6277
6278 GNU Emacs is free software: you can redistribute it and/or modify
6279 it under the terms of the GNU General Public License as published by
6280 the Free Software Foundation, either version 3 of the License, or
6281 (at your option) any later version.
6282
6283 GNU Emacs is distributed in the hope that it will be useful,
6284 but WITHOUT ANY WARRANTY; without even the implied warranty of
6285 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6286 GNU General Public License for more details.
6287
6288 You should have received a copy of the GNU General Public License
6289 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.