Fix mouse highlight in continued lines on a TTY.
[bpt/emacs.git] / src / ChangeLog
1 2011-11-01 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4 Don't stop backward scan on the continuation glyph, even though
5 its CHARPOS is positive.
6
7 2011-11-01 Martin Rudalics <rudalics@gmx.at>
8
9 * window.c (temp_output_buffer_show): Don't use
10 Vtemp_buffer_show_specifiers.
11 (Vtemp_buffer_show_specifiers): Remove unused variable.
12
13 2011-10-30 Eli Zaretskii <eliz@gnu.org>
14
15 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
16 past the beginning of the current glyph matrix.
17
18 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
19
20 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
21 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
22 HAVE_GTK3 (Bug#9869).
23
24 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
25 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
26
27 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
28
29 * xterm.c: Declare x_handle_net_wm_state to return int.
30 (handle_one_xevent): Check if we are iconified but don't have
31 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
32 (get_current_wm_state): Return non-zero if not hidden,
33 check for _NET_WM_STATE_HIDDEN (Bug#9893).
34 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
35 (x_handle_net_wm_state): Return what get_current_wm_state returns.
36 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
37
38 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
39
40 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
41 so that this new function doesn't get optimized away by a
42 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
43
44 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
45
46 * frame.h (MOUSE_HL_INFO): Remove excess parens.
47
48 2011-10-29 Eli Zaretskii <eliz@gnu.org>
49
50 Fix the `xbytecode' command.
51 * .gdbinit (xprintbytestr): New command.
52 (xwhichsymbols): Renamed from `which'; all callers changed.
53 (xbytecode): Print the byte-code string as well.
54
55 2011-10-29 Kim Storm <storm@cua.dk>
56
57 * alloc.c (which_symbols): New function.
58
59 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
60
61 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
62 line. (Bug#9903)
63
64 2011-10-29 Glenn Morris <rgm@gnu.org>
65
66 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
67 Not clear what it was for, and it causes various bugs. (Bug#9839)
68
69 2011-10-28 Eli Zaretskii <eliz@gnu.org>
70
71 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
72 possible random value that matches one of those tested as
73 condition to clear the mouse face.
74
75 2011-10-28 Chong Yidong <cyd@gnu.org>
76
77 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
78
79 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
80
81 * window.c (make_window): Initialize phys_cursor_on_p.
82
83 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
84
85 * lisp.h (struct Lisp_Symbol): Update comments.
86
87 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
88
89 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
90
91 2011-10-28 Eli Zaretskii <eliz@gnu.org>
92
93 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
94 <oslsachem@gmail.com> for helping to debug this.
95
96 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
97 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
98 (g_b_init_get_glyph_outline_w): New static variables.
99 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
100 (GetGlyphOutlineW_Proc): New typedefs.
101 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
102 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
103 New functions.
104 (w32font_open_internal, compute_metrics):
105 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
106 instead of calling the "wide" APIs directly.
107
108 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
109
110 * w32.h (syms_of_w32font): Add prototype.
111
112 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
113
114 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
115 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
116 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
117 (Fmove_to_window_line): Doc fix.
118
119 2011-10-27 Chong Yidong <cyd@gnu.org>
120
121 * process.c (make_process): Set gnutls_state to NULL.
122
123 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
124 non-NULL, regardless of GNUTLS_INITSTAGE.
125 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
126 an error. Set process slots as soon as we allocate them.
127
128 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
129
130 2011-10-27 Chong Yidong <cyd@gnu.org>
131
132 * gnutls.c (emacs_gnutls_deinit): New function.
133 Deallocate credentials structures as well as calling gnutls_deinit.
134 (Fgnutls_deinit, Fgnutls_boot): Use it.
135
136 * process.c (make_process): Initialize GnuTLS credentials to NULL.
137 (deactivate_process): Call emacs_gnutls_deinit.
138
139 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
140
141 * image.c (x_create_x_image_and_pixmap):
142 * w32.c (sys_rename, w32_delayed_load):
143 * w32font.c (fill_in_logfont):
144 * w32reg.c (x_get_string_resource): Silence compiler warnings.
145
146 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
147
148 * w32fns.c (w32_default_color_map): New function,
149 extracted from Fw32_default_color_map.
150 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
151
152 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
153
154 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
155
156 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
157
158 * keyboard.c (test_undefined): New function (bug#9751).
159 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
160
161 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
162
163 * sysdep.c (init_sys_modes): Fix the check for the controlling
164 terminal (Bug#6649).
165
166 2011-10-20 Eli Zaretskii <eliz@gnu.org>
167
168 * dispextern.h (struct bidi_it): New member next_en_type.
169
170 * bidi.c (bidi_line_init): Initialize the next_en_type member.
171 (bidi_resolve_explicit_1): When next_en_pos is valid for the
172 current character, check also for next_en_type being WEAK_EN.
173 (bidi_resolve_weak): Don't enter the expensive loop if the current
174 position is before next_en_pos. Record the bidi type of the first
175 non-ET, non-BN character we find, in addition to its position.
176 (bidi_level_of_next_char): Invalidate next_en_type when
177 next_en_pos is over-stepped.
178
179 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
180
181 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
182 * editfns.c: Rewrite current-time-zone so that it invokes
183 the equivalent of (format-time-string "%Z") to get the time zone name.
184 This fixes a bug when the time zone name contains characters that
185 need converting from the system time locale to Emacs internal format.
186 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
187 that patch fixed format-time-string to do the conversion, but
188 I forgot to fix current-time-zone.
189 (format_time_string): New function, containing most of
190 what Fformat_time_string used to contain.
191 (Fformat_time_string): Rewrite in terms of format_time_string.
192 This doesn't change this function's behavior.
193 (current-time-zone): Rewrite to use format_time_string.
194 This fixes the bug reported by Michael Schierl in
195 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
196 Jason Rumney's 2007-06-07 change worked around this bug, but
197 didn't fix it.
198 * systime.h (tzname, timezone): Remove no-longer-used declarations.
199
200 2011-10-19 Eli Zaretskii <eliz@gnu.org>
201
202 * xdisp.c (start_display): If the character at POS is displayed
203 via a display vector, reset IT->current.dpvec_index to zero.
204 (try_window_reusing_current_matrix): If a line ends in a display
205 vector or the next line starts in a display vector, continue
206 redrawing the window even though the character position of
207 start_row was reached.
208 (Bug#9771, part 2)
209
210 2011-10-18 Chong Yidong <cyd@gnu.org>
211
212 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
213 with nobreak-char-display too.
214
215 2011-10-18 Eli Zaretskii <eliz@gnu.org>
216
217 Fix part 3 of bug#9771.
218 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
219 (bidi_resolve_neutral): Don't enter the expensive loop looking for
220 non-neutral characters if the current character is a paragraph
221 separator (a.k.a. Newline). This avoids running the same
222 expensive loop twice, once when we consume the preceding newline
223 and the other time when the line actually needs to be displayed.
224 Avoid the loop when we see neutrals on the base embedding level
225 following a character whose directionality is the same as the
226 paragraph's. This avoids running the expensive loop when a line
227 ends in a long sequence of neutrals, like control characters.
228 Add assertion against STRONG_AL type. Slightly rearrange code
229 that determines the type of a neutral given the first non-neutral
230 that follows it.
231 (bidi_level_of_next_char): Set next_en_pos to zero when
232 invalidating its info.
233
234 2011-10-17 Eli Zaretskii <eliz@gnu.org>
235
236 * xdisp.c (push_display_prop): Determine whether to record string
237 or buffer position by IT->string, not by IT->method. Allow
238 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
239 (move_it_vertically_backward): Don't look for character position
240 immediately after the newline when in a continuation line.
241 (Bug#9771, part 1)
242
243 2011-10-15 Martin Rudalics <rudalics@gmx.at>
244
245 * window.c (coordinates_in_window): Rewrite and delabelize
246 vertical border check. (Bug#5357) (Bug#9618)
247
248 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
249
250 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
251 errors in XSetWindowBorder (bug#9310).
252
253 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
254
255 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
256 avoid crash when xmalloc overrun checking is enabled.
257
258 2011-10-13 Eli Zaretskii <eliz@gnu.org>
259
260 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
261 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
262 cursor motion with <left> and <right> arrow keys.
263
264 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
265 some callers set that themselves.
266
267 2011-10-12 Eli Zaretskii <eliz@gnu.org>
268
269 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
270 display string and the previous row comes from the same string and
271 is empty. (Bug#9739) (Bug#9738)
272
273 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
274
275 * doc.c (get_doc_string): Encode file name (bug#9735).
276
277 2011-10-12 Eli Zaretskii <eliz@gnu.org>
278
279 * bidi.c (bidi_level_of_next_char):
280 * xdisp.c (get_visually_first_element): Remove old incorrect
281 comments regarding the Unicode Line Separator character.
282
283 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
284
285 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
286
287 * alloc.c (Fgc_status): Do not access beyond zombies array
288 boundary if nzombies > MAX_ZOMBIES.
289 * alloc.c (dump_zombies): Add missing format specifier.
290
291 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
292
293 * xdisp.c (set_cursor_from_row): Simplify conditionals,
294 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
295
296 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
297 Some packages use them to denote characters with modifiers.
298
299 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
300
301 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
302 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
303 matching a pp-number. Rename parameter var to var1.
304
305 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
306
307 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
308
309 2011-10-08 Glenn Morris <rgm@gnu.org>
310
311 * callint.c (Fcall_interactively): Give a more explicit error for the
312 'c' case with a non-character input. (Bug#8479)
313
314 2011-10-08 Eli Zaretskii <eliz@gnu.org>
315
316 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
317 lines.
318 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
319 lines that are hscrolled on the left.
320
321 * dispnew.c (buffer_posn_from_coords): Account for a possible
322 presence of header-line. (Bug#4426)
323
324 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
325
326 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
327 Don't advertise functionality which we discourage or doesn't work.
328
329 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
330
331 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
332 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
333 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
334 this makes Emacs dump core during garbage collection on rare
335 occasions. sizeof is obviously inferior to offsetof here, so
336 stick with offsetof.
337 (GC_POINTER_ALIGNMENT): New macro.
338 (mark_memory): Omit 3rd (offset) arg; caller changed.
339 Don't assume EMACS_INT alignment is the same as pointer alignment.
340
341 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
342
343 * keyboard.c (read_key_sequence_remapped): New var.
344 (read_key_sequence): Compute remapping in the right buffer.
345 (command_loop_1): Use read_key_sequence's remapping directly.
346
347 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
348
349 * dired.c (file_name_completion): Don't expand file name.
350 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
351 before checking file name handler.
352
353 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
354 they've been requested explicitly (bug#9591).
355
356 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
357
358 * keymap.c (Fsingle_key_description): Use make_specified_string
359 instead of build_string to build string from push_key_description.
360 (Bug#5193)
361
362 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
363
364 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
365 This fixes a Y2038 bug on 64-bit hosts.
366 * buffer.c (reset_buffer):
367 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
368 (Fclear_buffer_auto_save_failure):
369 Use 0, not -1, to represent an unset failure time, since time_t
370 might not be signed.
371
372 Remove dependency on glibc malloc internals.
373 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
374 Move back here from lisp.h, but with their new implementations.
375 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
376 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
377 * charset.c (charset_table_init): New static var.
378 (syms_of_charset): Use it instead of xmalloc. This removes a
379 dependency on glibc malloc internals. See Eli Zaretskii's comment in
380 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
381 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
382 Move back to alloc.c.
383 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
384 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
385
386 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
387
388 * nsterm.m (windowDidResize): Call x_set_window_size only when
389 ns_in_resize is true. Otherwise set pixelwidth/height and
390 call change_frame_size (Bug#9628).
391
392 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
393
394 Port --enable-checking=all to Fedora 14 x86-64.
395 * charset.c (syms_of_charset): Also account for glibc malloc's
396 internal overhead when calculating the initial malloc maximum.
397
398 Port --enable-checking=all to Fedora 14 x86.
399 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
400 Move to lisp.h.
401 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
402 (overrun_check_realloc, overrun_check_free):
403 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
404 That way, xmalloc returns a properly-aligned pointer even if
405 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
406 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
407 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
408 into account when calculating the initial malloc maximum.
409 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
410 Move here from alloc.c, so that charset.c can use it too.
411 Properly align; the old code wasn't right for common 32-bit hosts
412 when configured with --enable-checking=all.
413 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
414 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
415
416 2011-09-29 Eli Zaretskii <eliz@gnu.org>
417
418 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
419 use EDOM.
420
421 2011-09-28 Eli Zaretskii <eliz@gnu.org>
422
423 * xdisp.c (compute_display_string_end): If there's no display
424 string at CHARPOS, return -1.
425
426 * bidi.c (bidi_fetch_char): When compute_display_string_end
427 returns a negative value, treat the character as a normal
428 character not covered by a display string. (Bug#9624)
429
430 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
431
432 * lread.c (Fread_from_string): Fix typo in docstring.
433
434 2011-09-27 Eli Zaretskii <eliz@gnu.org>
435
436 * xdisp.c (handle_invisible_prop): If invisible text ends on a
437 newline, reseat the iterator instead of bidi-iterating there one
438 character at a time. (Bug#9610)
439 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
440 TO_CHARPOS if the bidi iterator is at base embedding level.
441
442 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
443
444 * lread.c (readevalloop): Use correct code for NBSP.
445 (read1): Likewise. (Bug#9608)
446
447 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
448
449 * dbusbind.c (Fdbus_register_signal): When service is not
450 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
451
452 2011-09-25 Glenn Morris <rgm@gnu.org>
453
454 * buffer.c (truncate-lines): Doc fix.
455
456 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
457
458 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
459 (Fset_window_next_buffers): Doc fix.
460
461 2011-09-24 Glenn Morris <rgm@gnu.org>
462
463 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
464
465 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
466
467 Fix minor problems found by static checking.
468 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
469 * indent.c (Fvertical_motion): Fix == vs = typo.
470
471 2011-09-24 Eli Zaretskii <eliz@gnu.org>
472
473 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
474 Default value is now t. Doc fix.
475
476 * indent.c (Fvertical_motion): Compute and apply the overshoot
477 logic when moving up, not only when moving down. Fix the
478 confusing name and values of the it_overshoot_expected variable;
479 logic changes accordingly. (Bug#9254) (Bug#9549)
480
481 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
482 CHARPOS is covered by a display string which includes newlines.
483 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
484 is covered by a display string with embedded newlines.
485
486 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
487
488 * dbusbind.c (Fdbus_register_signal): Add match rule to
489 Vdbus_registered_objects_table. (Bug#9581)
490 (Fdbus_register_method, Vdbus_registered_objects_table):
491 Fix docstring.
492
493 2011-09-24 Jim Meyering <meyering@redhat.com>
494
495 do not ignore write error for any output size
496 The previous change was incomplete.
497 While it makes emacs --batch detect the vast majority of stdout
498 write failures, errors were still ignored whenever the output size is
499 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
500 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
501 && echo FAIL: ignored write error
502 FAIL: ignored write error
503 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
504 && echo FAIL: ignored write error
505 FAIL: ignored write error
506 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
507
508 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
509
510 * emacs.c (Fkill_emacs): In noninteractive mode exit
511 non-successfully if a write error occurred on stdout. (Bug#9574)
512
513 2011-09-21 Eli Zaretskii <eliz@gnu.org>
514
515 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
516 the xassert test.
517
518 * dispextern.h (struct it): Update the comment documenting what
519 can it->OBJECT be.
520
521 2011-09-20 Eli Zaretskii <eliz@gnu.org>
522
523 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
524 a display string, extend search for cursor position to end of row.
525 (find_row_edges): If the row ends in a newline from a display
526 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
527 Handle the case of a display string with multiple newlines.
528 (Fcurrent_bidi_paragraph_direction): Fix search for previous
529 non-empty line. Fixes confusing cursor motion with arrow keys at
530 the beginning of a line that starts with whitespace.
531
532 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
533
534 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
535 (bug#9493).
536
537 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
538
539 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
540 boolean (Bug#9154).
541
542 2011-09-18 Eli Zaretskii <eliz@gnu.org>
543
544 * xdisp.c (display_line): Record maximum and minimum buffer
545 positions even if no glyphs were produced (e.g., by a zero-width
546 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
547 buffer positions that will be removed from the glyph row because
548 they don't fit.
549 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
550 column is beyond frame width: don't subtract 1 "pixel" when
551 computing width of the stretch.
552 (reseat_at_next_visible_line_start): Undo the change made on
553 2011-09-17 that saved paragraph information and restored it after
554 the call to `reseat'. (Bug#9545)
555
556 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
557
558 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
559 and turn window cursor on if cleared (Bug#9415).
560
561 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
562
563 * search.c (boyer_moore): Take unibyte characters from pattern
564 literally. (Bug#9458)
565
566 2011-09-18 Eli Zaretskii <eliz@gnu.org>
567
568 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
569
570 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
571
572 Fix minor problem found by static checking.
573 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
574 initialized, to pacify gcc -Wuninitialized.
575
576 * fileio.c: Report proper errno when syscall falls.
577 (Finsert_file_contents): Save and restore errno,
578 so that report_file_error outputs the correct diagnostic.
579 (Fwrite_region) [CLASH_DETECTION]: Likewise.
580
581 2011-09-18 Eli Zaretskii <eliz@gnu.org>
582
583 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
584
585 2011-09-17 Eli Zaretskii <eliz@gnu.org>
586
587 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
588 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
589
590 2011-09-17 Eli Zaretskii <eliz@gnu.org>
591
592 * xdisp.c (reseat_at_next_visible_line_start): Keep information
593 about the current paragraph and restore it after the call to reseat.
594
595 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
596 (bidi_find_paragraph_start): Search back for paragraph beginning
597 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
598 (bidi_move_to_visually_next): Only trigger paragraph-related
599 computations when the last character is a newline or at EOB, not
600 just any NEUTRAL_B. (Bug#9470)
601
602 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
603 truncated lines if point is covered by a display string. (Bug#9524)
604
605 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
606
607 * xselect.c: Relax test for outgoing X longs (Bug#9498).
608 (cons_to_x_long): New function.
609 (lisp_data_to_selection_data): Use it. Correct the test for
610 short-versus-long data; it was negated. Break out of vector
611 loop, for efficiency, when a long datum is discovered.
612
613 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
614
615 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
616
617 2011-09-16 Eli Zaretskii <eliz@gnu.org>
618
619 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
620 GCC PR/17406) by declaring this function with external scope.
621
622 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
623
624 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
625 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
626
627 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
628
629 * editfns.c (Fformat): Correctly handle text properties on "%%".
630
631 2011-09-15 Eli Zaretskii <eliz@gnu.org>
632
633 * xterm.c (x_draw_composite_glyph_string_foreground):
634 * w32term.c (x_draw_composite_glyph_string_foreground):
635 * term.c (encode_terminal_code):
636 * composite.c (composition_update_it, get_composition_id):
637 * xdisp.c (get_next_display_element)
638 (fill_composite_glyph_string): Add comments about special meaning
639 of TAB characters in a composition.
640
641 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
642
643 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
644 This occurs when processing a multibyte format.
645 Problem reported by Wolfgang Jenker.
646
647 2011-09-15 Johan Bockgård <bojohan@gnu.org>
648
649 * xdisp.c (try_cursor_movement): Only check for exact match if
650 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
651
652 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
653
654 Remove unused external symbols.
655 * dispextern.h (calc_pixel_width_or_height): Remove decl.
656 * xdisp.c (calc_pixel_width_or_height): Now static.
657 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
658 * indent.c (check_display_width):
659 * w32term.c: Fix comment to match code.
660 * xterm.c, xterm.h (x_catching_errors): Remove.
661
662 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
663
664 * xselect.c: Use signed conversions more consistently (Bug#9498).
665 (selection_data_to_lisp_data): Assume incoming selection data are
666 signed integers, not unsigned. This is to be consistent with
667 outgoing selection data, which was modified to use signed integers
668 in as part of the fix to Bug#9196 in response to Jan D.'s comment
669 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
670 expects long, not unsigned long.
671
672 2011-09-14 Eli Zaretskii <eliz@gnu.org>
673
674 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
675 computation of loop end. Reported by Johan Bockgård
676 <bojohan@gnu.org>.
677
678 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
679
680 * frame.c (Fother_visible_frames_p): Function deleted.
681
682 2011-09-12 Eli Zaretskii <eliz@gnu.org>
683
684 * indent.c (compute_motion): Process display vector front to back
685 rather than the other way around. (Bug#2496)
686
687 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
688
689 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
690
691 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
692
693 * minibuf.c (Fread_from_minibuffer): Doc fix.
694
695 2011-09-11 Eli Zaretskii <eliz@gnu.org>
696
697 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
698 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
699
700 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
701
702 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
703 value for non-existent files.
704
705 2011-09-11 Eli Zaretskii <eliz@gnu.org>
706
707 * fileio.c (Finsert_file_contents): If the file cannot be opened,
708 set its "size" to -1. This will set the modtime_size field of
709 the corresponding buffer to -1, which is what
710 verify-visited-file-modtime expects for files that do not exist.
711 (Bug#9139)
712
713 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
714
715 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
716 here ...
717 * lisp.h: ... from here. push_key_description is no longer
718 defined in keyboard.c, so its declaration should not be in
719 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
720 logically belongs with push_key_description.
721
722 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
723
724 * buffer.h: Include <sys/types.h> instead of <time.h>.
725 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
726 Problem reported by Herbert J. Skuhra.
727
728 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
729
730 * xml.c (parse_region): Make the parsing work for
731 non-comment-starting XML files again (bug#9144).
732
733 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
734
735 * image.c (gif_load): Fix calculation of bottom and right corner.
736 (Bug#9468)
737
738 2011-09-10 Eli Zaretskii <eliz@gnu.org>
739
740 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
741 redisplay in small windows.
742
743 2011-09-09 Eli Zaretskii <eliz@gnu.org>
744
745 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
746
747 2011-09-08 Martin Rudalics <rudalics@gmx.at>
748
749 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
750 Operate on live windows only.
751
752 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
753
754 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
755
756 2011-09-07 Eli Zaretskii <eliz@gnu.org>
757
758 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
759 only under bidi iteration.
760
761 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
762
763 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
764
765 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
766
767 isnan: Fix porting problem to Solaris 10 with bundled gcc.
768 Without this fix, the command to link temacs failed due to an
769 undefined symbol __builtin_isnan. This is because
770 /usr/include/iso/math_c99.h #defines isnan(x) to
771 __builtin_isnan(x), but the bundled gcc, which identifies itself
772 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
773 a __builtin_isnan.
774 * floatfns.c (isnan): #undef, and then #define to a clone of
775 what's in data.c.
776 (Fisnan): Always define, since it's always available now.
777 (syms_of_floatfns): Always define isnan at the Lisp level.
778
779 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
780
781 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
782
783 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
784
785 * fileio.c: Fix bugs with large file offsets (Bug#9428).
786 The previous code assumed that file offsets (off_t values) fit in
787 EMACS_INT variables, which is not true on typical 32-bit hosts.
788 The code messed up by falsely reporting buffer overflow in cases
789 such as (insert-file-contents "big" nil 1 2) into an empty buffer
790 when "big" contains more than 2**29 bytes, even though this
791 inserts just one byte and does not overflow the buffer.
792 (Finsert_file_contents): Store file offsets as off_t
793 values, not as EMACS_INT values. Check for overflow when
794 converting between EMACS_INT and off_t. When checking for
795 buffer overflow or for overlap, take the offsets into account.
796 Don't use EMACS_INT for small values where int suffices.
797 When checking for overlap, fix a typo: ZV was used where
798 ZV_BYTE was intended.
799 (Fwrite_region): Don't assume off_t fits into 'long'.
800 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
801
802 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
803
804 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
805
806 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
807
808 sprintf-related integer and memory overflow issues (Bug#9412).
809
810 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
811 (esprintf, exprintf, evxprintf): New functions.
812 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
813 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
814 (modify_event_symbol): Do not assume that the length of
815 name_alist_or_stem is safe to alloca and fits in int.
816 (Fexecute_extended_command): Likewise for function name and binding.
817 (Frecursion_depth): Wrap around reliably on integer overflow.
818 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
819 since some callers pass EMACS_INT values.
820 (Fsingle_key_description): Don't crash if symbol name contains more
821 than MAX_ALLOCA bytes.
822 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
823 (get_minibuffer): Arg is now EMACS_INT, not int.
824 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
825 (esprintf, exprintf, evxprintf): New decls.
826 * window.h (command_loop_level, minibuf_level): Reflect API changes.
827
828 * dbusbind.c (signature_cat): New function.
829 (xd_signature, Fdbus_register_signal):
830 Do not overrun buffer; instead, report string overflow.
831
832 * dispnew.c (add_window_display_history): Don't overrun buffer.
833 Truncate instead; this is OK since it's just a log.
834
835 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
836 even if the time zone offset is outlandishly large.
837 Don't mishandle offset == INT_MIN.
838
839 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
840 when creating daemon; the previous buffer-overflow check was incorrect.
841
842 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
843 which has the guts of the old verror function.
844
845 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
846 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
847
848 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
849 (font_unparse_xlfd): Don't blindly alloca long strings.
850 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
851 fits in int, when using sprintf. Use single snprintf to count
852 length of string rather than counting it via multiple sprintfs;
853 that's simpler and more reliable.
854 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
855 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
856 sprintf, in case result does not fit in int.
857
858 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
859 (fontset_from_font): Print it.
860
861 * frame.c (tty_frame_count): Now printmax_t, not int.
862 (make_terminal_frame, set_term_frame_name): Print it.
863 (x_report_frame_params): In X, window IDs are unsigned long,
864 not signed long, so print them as unsigned.
865 (validate_x_resource_name): Check for implausibly long names,
866 and don't assume name length fits in 'int'.
867 (x_get_resource_string): Don't blindly alloca invocation name;
868 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
869 not fit in int.
870
871 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
872 (xg_check_special_colors, xg_set_geometry):
873 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
874
875 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
876 Use esprintf, not sprintf, in case result does not fit in int.
877
878 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
879 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
880 it as a large positive number.
881 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
882 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
883
884 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
885 in case result does not fit in int.
886
887 * print.c (float_to_string): Detect width overflow more reliably.
888 (print_object): Make sprintf buffer a bit bigger, to avoid potential
889 buffer overrun. Don't assume list length fits in 'int'. Treat
890 print length of 0 as 0, not as infinity; to be consistent with other
891 uses of print length in this function. Don't overflow print length
892 index. Don't assume hash table size fits in 'long', or that
893 vectorlike size fits in 'unsigned long'.
894
895 * process.c (make_process): Use printmax_t, not int, to format
896 process-name gensyms.
897
898 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
899
900 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
901 to avoid potential buffer overrun.
902
903 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
904 if X resource line is longer than 512 bytes.
905
906 * xfns.c (x_window): Make sprintf buffer a bit bigger
907 to avoid potential buffer overrun.
908
909 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
910
911 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
912
913 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
914
915 Integer overflow fixes for scrolling, etc.
916 Without these, Emacs silently mishandles large integers sometimes.
917 For example, "C-u 4294967297 M-x recenter" was treated as if
918 it were "C-u 1 M-x recenter" on a typical 64-bit host.
919
920 * xdisp.c (try_window_id): Check Emacs fixnum range before
921 converting to 'int'.
922
923 * window.c (window_scroll_line_based, Frecenter):
924 Check that an Emacs fixnum is in range before assigning it to 'int'.
925 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
926 values converted from Emacs fixnums.
927 (Frecenter): Don't wrap around a line count if it is out of 'int'
928 range; instead, treat it as an extreme value.
929 (Fset_window_configuration, compare_window_configurations):
930 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
931
932 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
933 that can exceed INT_MAX. Check that EMACS_INT value is in range
934 before assigning it to the (possibly-narrower) index.
935 (match_limit): Don't assume that a fixnum can fit in 'int'.
936
937 * print.c (print_object): Use ptrdiff_t, not int, for index that can
938 exceed INT_MAX.
939
940 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
941 (Fvertical_motion): Don't wrap around LINES values that don't fit
942 in 'int'. Instead, treat them as extreme values. This is good
943 enough for windows, which can't have more than INT_MAX lines anyway.
944
945 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
946
947 * Require libxml/parser.h to avoid compilation warning.
948
949 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
950
951 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
952 since this reportedly can destroy thread storage.
953
954 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
955
956 * syntax.c (find_defun_start): Update all cache variables if
957 exiting early (Bug#9401).
958
959 2011-08-30 Eli Zaretskii <eliz@gnu.org>
960
961 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
962
963 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
964 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
965 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
966
967 * term.c (tty_append_glyph): New function.
968 (produce_stretch_glyph): Static function and its prototype deleted.
969
970 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
971 Add prototypes.
972
973 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
974
975 * image.c (parse_image_spec): Check for nonnegative, not for positive,
976 when checking :margin (Bug#9390).
977 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
978 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
979 so that the name doesn't mislead. All uses changed.
980
981 2011-08-28 Johan Bockgård <bojohan@gnu.org>
982
983 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
984 set_tty_hooks.
985
986 2011-08-27 Eli Zaretskii <eliz@gnu.org>
987
988 * xdisp.c (move_it_to): Don't bail out early when reaching
989 position beyond to_charpos, if we are scanning backwards.
990 (move_it_vertically_backward): When DY == 0, make sure we get to
991 the first character in the line after the newline.
992
993 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
994
995 * ccl.c: Improve and simplify overflow checking (Bug#9196).
996 (ccl_driver): Do not generate an out-of-range pointer.
997 (Fccl_execute_on_string): Remove unnecessary check for
998 integer overflow, noted by Stefan Monnier in
999 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1000 Remove a FIXME that didn't need fixing.
1001 Simplify the newly-introduced buffer reallocation code.
1002
1003 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
1004
1005 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1006
1007 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1008
1009 Integer and memory overflow issues (Bug#9196).
1010
1011 * doc.c (get_doc_string): Rework so that
1012 get_doc_string_buffer_size is the actual buffer size, rather than
1013 being 1 less than the actual buffer size; this makes xpalloc more
1014 convenient.
1015
1016 * image.c (x_allocate_bitmap_record, cache_image):
1017 * xselect.c (Fx_register_dnd_atom):
1018 Simplify previous changes by using xpalloc.
1019
1020 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1021 since either will do and ptrdiff_t is convenient with xpalloc.
1022
1023 * charset.c (charset_table_size)
1024 (struct charset_sort_data.priority): Now ptrdiff_t.
1025 (charset_compare): Don't overflow if priorities differ greatly.
1026 (Fsort_charsets): Don't assume list length fits in int.
1027 Check for size-calculation overflow when allocating sort data.
1028 (syms_of_charset): Allocate an initial charset table that is
1029 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1030
1031 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1032
1033 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1034 The actual value is always <= INT_MAX, and leaving it unsigned made
1035 overflow checking harder.
1036
1037 * dispextern.h (struct glyph_matrix.rows_allocated)
1038 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1039 with xpalloc. The values are still always <= INT_MAX.
1040
1041 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1042
1043 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1044 (SAFE_NALLOCA): New macro.
1045
1046 * region-cache.c (struct boundary.pos, find_cache_boundary)
1047 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1048 (set_cache_region, invalidate_region_cache)
1049 (revalidate_region_cache, know_region_cache, region_cache_forward)
1050 (region_cache_backward, pp_cache):
1051 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1052 so that ptrdiff_t * can be passed to xpalloc.
1053 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1054 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1055 (pp_cache): Don't assume cache_len fits in int.
1056 * region-cache.h: Adjust extern decls to match.
1057
1058 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1059 EMACS_INT, since either will do, for xpalloc.
1060
1061 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1062 (xnmalloc, xnrealloc, xpalloc): New functions.
1063
1064 * bidi.c (bidi_shelve_header_size): New constant.
1065 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1066 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1067
1068 * bidi.c (bidi_cache_shrink):
1069 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1070 (overlay_strings):
1071 Don't update size of array until after memory allocation succeeds,
1072 because xmalloc/xrealloc may not return.
1073 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1074 now that we have proper integer overflow checking.
1075 (record_overlay_string, overlay_strings): Catch overflows when
1076 calculating size of overlay_str_buf.
1077
1078 * callproc.c (Fcall_process): Check for size overflow when
1079 calculating size of args2.
1080 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1081 Normally we prefer signed values, but sticking with ptrdiff_t would
1082 require adding more-complicated checks.
1083
1084 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1085 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1086 Redo buffer-overflow calculations to avoid integer overflow.
1087 Add a FIXME comment where memory seems to be over-allocated.
1088
1089 * character.c (Fstring): Check for size-calculation overflow.
1090
1091 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1092 unnecessary integer overflow. Check for size overflow.
1093 (encode_coding_object): Don't update size until xmalloc succeeds.
1094
1095 * composite.c (get_composition_id): Check for overflow in glyph
1096 length calculations.
1097
1098 Integer and memory overflow fixes for display code.
1099 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1100 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1101 (scrolling_window): Check for overflow in size calculations.
1102 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1103 Don't assume glyph table len fits in int.
1104 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1105 (row_table_size): Now ptrdiff_t, not int.
1106 (scrolling_window): Avoid overflow in size calculations.
1107 Don't update size until allocation succeeds.
1108 * fns.c (concat): Check for overflow in size calculations.
1109 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1110 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1111 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1112
1113 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1114 (get_doc_string): Check for size calculation overflow.
1115 Don't update size until allocation succeeds.
1116 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1117 EMACS_INT, where ptrdiff_t will do.
1118 (Fsubstitute_command_keys): Check for string overflow.
1119
1120 * editfns.c (set_time_zone_rule): Don't assume environment length
1121 fits in int.
1122 (message_length): Now ptrdiff_t, not int.
1123 (Fmessage_box): Don't update size until allocation succeeds.
1124 Don't assume message length fits in int.
1125 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1126
1127 * emacs.c (main): Do not reallocate argv, since there is a null at
1128 the end that can be overwritten, and this way there's no need to
1129 worry about size-calculation overflow.
1130 (sort_args): Check for size-calculation overflow.
1131
1132 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1133 alloc succeeds.
1134 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1135
1136 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1137 (x_set_scroll_bar_width, x_figure_window_size):
1138 Check for integer overflow.
1139 (x_set_alpha): Do not assume XINT fits in int.
1140
1141 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1142 This is for the members text_lines, text_cols, total_lines, total_cols,
1143 where the system imposes an 'int' limit.
1144
1145 * fringe.c (Fdefine_fringe_bitmap):
1146 Don't update size until alloc works.
1147
1148 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1149 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1150
1151 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1152 Check for size-calculation overflow.
1153 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1154 do, as we prefer signed integers.
1155 (id_to_widget.max_size, id_to_widget.used)
1156 (xg_store_widget_in_map, xg_remove_widget_from_map)
1157 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1158 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1159 Use and return ptrdiff_t, not int.
1160 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1161 * gtkutil.h: Change prototypes to match the above.
1162
1163 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1164 are duplicate now that they've been promoted to lisp.h.
1165 (x_allocate_bitmap_record, x_alloc_image_color)
1166 (make_image_cache, cache_image, xpm_load):
1167 Don't update size until alloc is done.
1168 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1169 (x_detect_edges):
1170 Check for size calculation overflow.
1171 (ct_colors_allocated_max): New constant.
1172 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1173 overflow.
1174
1175 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1176 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1177 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1178 Use ptrdiff_t, not int, to count maps.
1179 (read_char_minibuf_menu_prompt): Check for overflow in size
1180 calculations. Don't update size until allocation succeeds.
1181 Redo calculations to avoid overflow.
1182 * keyboard.h: Change prototypes to match the above.
1183
1184 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1185 to count maps.
1186 (current_minor_maps): Check for size calculation overflow.
1187 * keymap.h: Change prototypes to match the above.
1188
1189 * lread.c (read1, init_obarray): Don't update size until alloc done.
1190
1191 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1192 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1193
1194 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1195 Now ptrdiff_t, not int.
1196 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1197 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1198
1199 * process.c (Fnetwork_interface_list): Check for overflow
1200 in size calculation.
1201
1202 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1203
1204 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1205 overflow. Don't bother calling xmalloc when xrealloc will do.
1206
1207 * search.c (Freplace_match): Check for size calculation overflow.
1208 (Fset_match_data): Don't assume list lengths fit in 'int'.
1209
1210 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1211 for command line length. Do not attempt to address one before the
1212 beginning of an array, as that's not portable.
1213
1214 * term.c (max_frame_lines): Remove; unused.
1215 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1216 not int.
1217 (encode_terminal_code, calculate_costs): Check for size
1218 calculation overflow.
1219 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1220 table lengths and related sizes. Don't update size until alloc
1221 done. Redo calculations to avoid overflow.
1222 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1223
1224 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1225 subtracting pointers.
1226 (gobble_line): Check for overflow more carefully. Don't update size
1227 until alloc done.
1228
1229 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1230 Don't update size until alloc done.
1231 Redo size calculations to avoid overflow.
1232 Check for size calculation overflow.
1233 (main) [DEBUG]: Fix typo in invoking tparam1.
1234
1235 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1236 Use ptrdiff_t, not int, for sizes.
1237 (store_mode_line_noprop_char): Don't update size until alloc done.
1238
1239 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1240 Use ptrdiff_t, not int, for sizes.
1241 (Finternal_make_lisp_face, cache_face):
1242 Check for size calculation overflow.
1243 (cache_face): Treat size calculation overflows as if they were
1244 memory exhaustion (the usual treatment), rather than aborting.
1245
1246 * xfns.c (x_encode_text, x_set_name_internal)
1247 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1248 sizes, since they can exceed INT_MAX in size. Check for size
1249 calculation overflow.
1250
1251 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1252 (xg_select): Check for size calculation overflow.
1253 Don't update size until alloc done.
1254
1255 * xrdb.c (get_environ_db): Don't assume path length fits in int,
1256 as sprintf is limited to int lengths.
1257
1258 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1259 (X_LONG_MIN): New macros.
1260 Use them to make the following changes clearer.
1261 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1262 This change doesn't affect the value now, but it may help remind
1263 future maintainers not to raise the value too much later.
1264 (SELECTION_QUANTUM): Remove, replacing with ...
1265 (selection_quantum): ... new function, which avoids overflow.
1266 All uses changed.
1267 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1268 assumption that selection length fits in 'int'.
1269 (x_reply_selection_request, x_handle_selection_request)
1270 (x_get_window_property, receive_incremental_selection)
1271 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1272 (lisp_data_to_selection_data, clean_local_selection_data):
1273 Use ptrdiff_t, not int, to record length of selection.
1274 (x_reply_selection_request, x_get_window_property)
1275 (receive_incremental_selection, x_property_data_to_lisp):
1276 Redo calculations to avoid overflow.
1277 (x_reply_selection_request): When sending hint, ceiling it at
1278 X_LONG_MAX rather than relying on wraparound overflow to send
1279 something.
1280 (x_get_window_property, receive_incremental_selection)
1281 (lisp_data_to_selection_data, x_property_data_to_lisp):
1282 Check for size-calculation overflow.
1283 (x_get_window_property, receive_incremental_selection)
1284 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1285 Don't store size until memory allocation succeeds.
1286 (x_get_window_property): Plug memory leak on memory exhaustion.
1287 Don't double-block input; malloc is safe here. Don't assume 2**34
1288 - 4 fits in unsigned long. Add an xassert to check
1289 XGetWindowProperty overflow. Be more careful about overflow
1290 calculations, and distinguish size from memory overflow better.
1291 (receive_incremental_selection): When tracing, don't assume
1292 unsigned int is less than INT_MAX.
1293 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1294 harmful) conversions of unsigned short to int.
1295 (lisp_data_to_selection_data): Don't assume that integers
1296 in the range -65535 through -1 fit in an X unsigned short.
1297 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1298 result parameters unless successful. Rely on cons_to_unsigned
1299 to report problems with elements; the old code wasn't right anyway.
1300 (x_check_property_data): Check for int overflow; we cannot use
1301 a wider type due to X limits.
1302 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1303
1304 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
1305
1306 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1307 (x_term_init): Check for size calculation overflow.
1308 (x_color_cells): Don't store size until memory allocation succeeds.
1309 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
1310 Don't assume alloca size is less than MAX_ALLOCA.
1311 (x_term_init): Don't assume length fits in int (sprintf is limited
1312 to int size).
1313
1314 Use ptrdiff_t for composition IDs.
1315 * character.c (lisp_string_width):
1316 * composite.c (composition_table_size, n_compositions)
1317 (get_composition_id, composition_gstring_from_id):
1318 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1319 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1320 * window.c (Frecenter):
1321 Use ptrdiff_t, not int, for composition IDs.
1322 * composite.c (get_composition_id): Check for integer overflow.
1323 * composite.h: Adjust prototypes to match the above changes.
1324
1325 Use ptrdiff_t for hash table indexes.
1326 * category.c (hash_get_category_set):
1327 * ccl.c (ccl_driver):
1328 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1329 * coding.c (coding_system_charset_list, detect_coding_system):
1330 * coding.h (struct coding_system.id):
1331 * composite.c (get_composition_id, gstring_lookup_cache):
1332 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1333 * image.c (xpm_get_color_table_h):
1334 * lisp.h (hash_lookup, hash_put):
1335 * minibuf.c (Ftest_completion):
1336 Use ptrdiff_t for hash table indexes, not int (which is too
1337 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1338 32-bit --with-wide-int hosts).
1339
1340 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1341 Add a FIXME comment about memory leaks.
1342 (syms_of_charset): Don't assume xmalloc returns.
1343
1344 Don't assume that stated character widths fit in int.
1345 * character.c (Fchar_width, c_string_width, lisp_string_width):
1346 * character.h (CHAR_WIDTH):
1347 * indent.c (MULTIBYTE_BYTES_WIDTH):
1348 Use sanitize_char_width to avoid undefined and/or bad behavior
1349 with outlandish widths.
1350 * character.h (sanitize_tab_width): Rename from sanitize_width,
1351 now that we have two such functions. All uses changed.
1352 (sanitize_char_width): New inline function.
1353
1354 Don't assume that tab-width fits in int.
1355 * character.h (sanitize_width): New inline function.
1356 (SANE_TAB_WIDTH): New macro.
1357 (ASCII_CHAR_WIDTH): Use it.
1358 * indent.c (sane_tab_width): Remove. All uses replaced by
1359 SANE_TAB_WIDTH (current_buffer).
1360 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1361
1362 * fileio.c: Integer overflow issues with file modes.
1363 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1364
1365 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1366 Remove unreachable code.
1367 (read_hex, load_charset_map_from_file): Check for integer overflow.
1368
1369 * xterm.c: don't go over XClientMessageEvent limit
1370 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1371 (x_send_scroll_bar_event): Likewise. Check that the size does not
1372 exceed limits imposed by XClientMessageEvent, as well as the usual
1373 ptrdiff_t and size_t limits.
1374
1375 * keyboard.c: Overflow, signedness and related fixes.
1376 (make_lispy_movement): Use same integer type in forward decl
1377 that is used in the definition.
1378 (read_key_sequence, keyremap_step):
1379 Change bufsize argument back to int, undoing my 2011-03-30 change.
1380 We prefer signed types, and int is wide enough here.
1381 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1382 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1383 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1384 length, not size_t. Use ptrdiff_t for index, not int.
1385 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1386 possibility of integer overflow.
1387
1388 Overflow, signedness and related fixes for images.
1389
1390 * dispextern.h (struct it.stack[0].u.image.image_id)
1391 (struct_it.image_id, struct image.id, struct image_cache.size)
1392 (struct image_cache.used, struct image_cache.ref_count):
1393 * gtkutil.c (update_frame_tool_bar):
1394 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1395 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1396 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1397 * nsmenu.m (update_frame_tool_bar):
1398 * xdisp.c (calc_pixel_width_or_height):
1399 * xfns.c (image_cache_refcount):
1400 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1401 on typical 64-bit hosts.
1402
1403 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1404 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1405 Omit unnecessary casts to int.
1406 (parse_image_spec): Check that integers fall into 'int' range
1407 when the callers expect that.
1408 (image_ascent): Redo ascent calculation to avoid int overflow.
1409 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1410 (lookup_image): Remove unnecessary tests.
1411 (xbm_image_p): Locals are now of int, not EMACS_INT,
1412 since parse_image_check makes sure they fit into int.
1413 (png_load, gif_load, svg_load_image):
1414 Prefer int to unsigned where either will do.
1415 (tiff_handler): New function, combining the cores of the
1416 old tiff_error_handler and tiff_warning_handler.
1417 This function is rewritten to use vsnprintf and thereby avoid
1418 stack buffer overflows. It uses only the features of vsnprintf
1419 that are common to both POSIX and native Microsoft.
1420 (tiff_error_handler, tiff_warning_handler): Use it.
1421 (tiff_load, gif_load, imagemagick_load_image):
1422 Don't assume :index value fits in 'int'.
1423 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1424 (imagemagick_load_image): Check that crop parameters fit into
1425 the integer types that MagickCropImage accepts. Don't assume
1426 Vimagemagick_render_type has a nonnegative value. Don't assume
1427 size_t fits in 'long'.
1428 (gs_load): Use printmax_t to print the widest integers possible.
1429 Check for integer overflow when computing image height and width.
1430
1431 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1432
1433 * xdisp.c (redisplay_window): Don't force window start if point
1434 will be invisible in the resulting window. (Bug#9324)
1435
1436 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1437
1438 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1439 the display spec is of the form `(space ...)'.
1440 (handle_display_spec): Return the value returned by
1441 handle_single_display_spec, not just 1 or zero.
1442 (handle_single_display_spec): If the display spec is of the form
1443 `(space ...)', and specifies display in the text area, return 2
1444 rather than 1.
1445 (try_cursor_movement): Check for the need to scroll more
1446 accurately, and prefer exact match for point under bidi.
1447 Don't advance `row' beyond the last row of the window.
1448
1449 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1450 into disp_prop; all users changed.
1451
1452 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1453 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1454 for the text covered by the display property.
1455
1456 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1457
1458 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1459 Change return value to nil.
1460 (Frecord_buffer): Delete unused function.
1461
1462 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1463
1464 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1465 buffers, return left-to-right.
1466 (set_cursor_from_row): Consider candidate row a win if its glyph
1467 represents a newline and point is on that newline. Fixes cursor
1468 positioning on the newline at EOL of R2L text within L2R
1469 paragraph, and vice versa.
1470 (try_cursor_movement): Check continued rows, in addition to
1471 continuation rows. Fixes unwarranted scroll when point enters a
1472 continued line of R2L text within an L2R paragraph, or vice versa.
1473 (cursor_row_p): Consider the case of point being equal to
1474 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1475 from the end of a short line to the beginning of a continued line
1476 of R2L text within L2R paragraph.
1477 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1478 composed characters.
1479
1480 * bidi.c (bidi_check_type): Use xassert.
1481 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1482 members.
1483
1484 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1485
1486 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1487 a character.
1488
1489 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1490
1491 * nsfont.m (ns_otf_to_script): Fix typo.
1492
1493 2011-08-22 Kenichi Handa <handa@m17n.org>
1494
1495 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1496 extra slot even if the purpose is char-code-property-table.
1497
1498 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1499
1500 * xdisp.c (redisplay_window): When computing centering_position,
1501 account for the height of the header line. (Bug#8874)
1502
1503 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1504 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1505 candidate is selected by the mouse, and that candidate has a
1506 composed character under the mouse.
1507
1508 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1509 coordinates reported by pos-visible-in-window-p for a composed
1510 character in column zero.
1511
1512 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1513
1514 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1515
1516 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1517
1518 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1519 consider it a hit if to_charpos is anywhere in the range of the
1520 composed buffer positions.
1521
1522 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1523
1524 * image.c (gif_load): Don't assume that each subimage has the same
1525 dimensions as the base image. Handle disposal method that is
1526 "undefined" by the gif spec (Bug#9335).
1527
1528 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1529
1530 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1531 (Fcondition_case): Document `debug' symbol in error handler.
1532
1533 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1534
1535 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1536 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1537 from an Org mode buffer to a Speedbar frame.
1538
1539 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1540 a composition, take its buffer position from IT->cmp_it.charpos.
1541 Fixes cursor positioning at the beginning of a line that begins
1542 with a composed character.
1543
1544 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1545
1546 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1547 character bidirectional type, use STRONG_L instead. Fixes crashes
1548 in a buffer produced by `describe-categories'.
1549
1550 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1551 members before the level stack, so they would be saved and
1552 restored when copying iterator state. Fixes incorrect reordering
1553 around TABs covered by display properties.
1554
1555 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1556
1557 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
1558
1559 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1560
1561 * eval.c (internal_condition_case, internal_condition_case_1)
1562 (internal_condition_case_2, internal_condition_case_n):
1563 Remove unnecessary aborts (Bug#9081).
1564
1565 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1566
1567 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1568 has no `load' handler, try opening the file locally. (Bug#9311)
1569
1570 2011-08-16 Ken Brown <kbrown@cornell.edu>
1571
1572 * gmalloc.c: Expand comment.
1573
1574 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1575
1576 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1577 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1578
1579 2011-08-16 Ken Brown <kbrown@cornell.edu>
1580
1581 Fix memory allocation problems in Cygwin build (Bug#9273).
1582
1583 * unexcw.c ( __malloc_initialized): Declare external variable.
1584 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1585
1586 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1587 New variables.
1588 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1589 dumped emacs.
1590 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1591 in the static heap.
1592 [CYGWIN] (special_realloc): New function.
1593 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1594 requests to realloc storage in the static heap.
1595
1596 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1597
1598 * bidi.c (bidi_initialize): Remove unused local.
1599
1600 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1601
1602 * bidimirror.h:
1603 * biditype.h: Remove file.
1604 * makefile.w32-in ($(BLD)/bidi.$(O)):
1605 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
1606
1607 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1608
1609 * chartab.c: Improve commentary for the uniprop_table API.
1610
1611 * bidi.c (bidi_paragraph_init): Support zero value of
1612 bidi_ignore_explicit_marks_for_paragraph_level.
1613 (bidi_initialize): Use uniprop_table instead of including
1614 biditype.h and bidimirror.h.
1615
1616 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1617 coordinates of the iterator when restoring from ppos_it.
1618 (Bug#9296)
1619
1620 2011-08-14 Kenichi Handa <handa@m17n.org>
1621
1622 * process.c (create_process): Call setup_process_coding_systems
1623 after the pid of the process is set to -1 (Bug#8162).
1624
1625 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1626
1627 * xdisp.c (move_it_in_display_line_to): Don't invoke
1628 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1629 ppos_it. Fixes vertical cursor motion when line beginning is
1630 covered by an image. (Bug#9296)
1631
1632 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1633
1634 * nsterm.h (ns_run_ascript): Declare.
1635 (NSAPP_DATA2_RUNASSCRIPT): Define.
1636
1637 * nsfns.m (as_script, as_result, as_status): New static variables.
1638 (ns_run_ascript): New function.
1639 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1640 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1641 the event loop. Get status from as_status (Bug#7276).
1642
1643 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1644 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1645 the event loop (Bug#7276).
1646
1647 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1648
1649 * gnutls.c (QCgnutls_bootprop_priority)
1650 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1651 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1652 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1653 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1654 (QCgnutls_bootprop_verify_hostname_error)
1655 (QCgnutls_bootprop_callbacks_verify): Rename from
1656 Qgnutls_bootprop_..., all uses changed.
1657
1658 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1659 uses changed.
1660
1661 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1662
1663 * xfaces.c (Qframe_set_background_mode): Now static.
1664 * dispextern.h (Qframe_set_background_mode): Remove decl.
1665
1666 * process.c (Fnetwork_interface_info): Declare local only if needed.
1667
1668 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1669
1670 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1671 (Fnetwork_interface_list): Allocate in increments of bytes instead
1672 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1673 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1674 sockaddr.
1675 (struct ifflag_def): notrailers is smart on OSX.
1676 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1677 Get hardware address with getifaddrs if available.
1678
1679 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1680
1681 * xdisp.c (iterate_out_of_display_property): xassert that
1682 IT->position is set to within IT->object's boundaries. Break from
1683 the loop as soon as EOB is reached; avoids infloops in redisplay
1684 when IT->position is set up wrongly due to some bug.
1685 Set IT->current to match the bidi iterator unconditionally.
1686 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1687 entry. Force push_it to save on the stack the current
1688 buffer/string position, to be restored by pop_it. Fix flags in
1689 the iterator structure wrt the object coming from a display
1690 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1691 properties. (Bug#9284)
1692
1693 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1694
1695 * fontset.c (fontset_get_font_group): Add proper type checks.
1696 (Bug#9172)
1697
1698 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1699
1700 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1701 and LC_VERSION_MIN_MACOSX.
1702 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1703 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1704
1705 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1706
1707 * xdisp.c (forward_to_next_line_start): Allow to use the
1708 no-display-properties-and-no-overlays under bidi display.
1709 Set disp_pos in the bidi iterator to avoid searches for display
1710 properties and overlays.
1711
1712 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1713
1714 * editfns.c (Fset_time_zone_rule): Document relationship with the
1715 setenv function.
1716
1717 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1718 the font entity extracted from the cache (Bug#8109).
1719
1720 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1721
1722 * composite.c (autocmp_chars): Don't reset point. That is done by
1723 restore_point_unwind (Bug#5984).
1724
1725 2011-08-07 Juri Linkov <juri@jurta.org>
1726
1727 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1728 to show the arg `TIME' instead of `TIMEVAL'.
1729
1730 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1731
1732 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1733 display property strides EOL and includes a newline, as in
1734 longlines-mode. (Bug#9254)
1735 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1736 word-wrap under bidirectional display. (Bug#9224)
1737
1738 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1739 is non-zero, even if the data buffer is NULL. Fixes a crash in
1740 vertical-motion with longlines-mode. (Bug#9254)
1741
1742 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1743
1744 * bidi.c <bidi_cache_total_alloc>: Now static.
1745 (bidi_initialize): Initialize bidi_cache_total_alloc.
1746
1747 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1748 cache. (Bug#9221)
1749
1750 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1751 amount allocated this far in `bidi_cache_total_alloc'.
1752 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1753 non-zero, only free the data buffer without restoring the cache
1754 contents. All callers changed.
1755
1756 * dispextern.h (bidi_unshelve_cache): Update prototype.
1757
1758 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1759 (move_it_in_display_line, move_it_to)
1760 (move_it_vertically_backward, move_it_by_lines): Replace the call
1761 to xfree to an equivalent call to bidi_unshelve_cache.
1762 (move_it_in_display_line_to): Fix logic of returning
1763 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1764
1765 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1766
1767 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1768 came from a string character with a `cursor' property. (Bug#9229)
1769
1770 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1771
1772 * Makefile.in (LIB_PTHREAD): New variable.
1773 (LIBES): Add LIB_PTHREAD (Bug#9216).
1774
1775 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1776 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1777
1778 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1779
1780 * regex.c (re_iswctype): Remove some redundant boolean conversions.
1781
1782 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1783
1784 * xterm.c (x_find_topmost_parent): New function.
1785 (x_set_frame_alpha): Find topmost parent window with
1786 x_find_topmost_parent and set the property there also (bug#9181).
1787 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1788
1789 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1790
1791 * callproc.c (Fcall_process): Avoid vfork clobbering
1792 the local vars buffer, coding_systems, current_dir.
1793
1794 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1795
1796 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1797
1798 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1799
1800 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1801 so that it is not optimized away.
1802
1803 * xdisp.c (compute_display_string_pos): Remove unused local.
1804
1805 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1806
1807 Fix slow cursor motion and scrolling in large buffers with
1808 selective display, like Org Mode buffers. (Bug#9218)
1809
1810 * dispextern.h (struct bidi_it): New member disp_prop_p.
1811
1812 * xdisp.c: Remove one-slot cache of display string positions.
1813 (compute_display_string_pos): Accept an additional argument
1814 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1815 for a display string or property. If found, set DISP_PROP_P
1816 non-zero.
1817
1818 * bidi.c (bidi_fetch_char): Accept an additional argument
1819 DISP_PROP_P, and pass it to compute_display_string_pos.
1820 Only handle text covered by a display string if DISP_PROP_P is returned
1821 non-zero. All callers of bidi_fetch_char changed.
1822
1823 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1824
1825 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1826
1827 2010-12-03 Don March <don@ohspite.net>
1828
1829 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1830 last character M-[char] is translated to ESC [char] (bug#7541).
1831
1832 2011-08-02 Kenichi Handa <handa@m17n.org>
1833
1834 * lisp.h (uniprop_table): Extern it.
1835
1836 * chartab.c (uniprop_table): Make it non-static.
1837
1838 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1839
1840 * xdisp.c (forward_to_next_line_start): Accept additional argument
1841 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1842 on the newline.
1843 (reseat_at_next_visible_line_start): Use the bidi iterator state
1844 returned by forward_to_next_line_start to restore the state of
1845 it->bidi_it after backing up to previous newline. (Bug#9212)
1846
1847 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1848
1849 * regex.c (re_comp): Protoize.
1850 (re_exec): Fix return type.
1851 (regexec): Fix type of `ret'. (Bug#9203)
1852
1853 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1854
1855 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1856 This is needed if max-image-size is a floating-point number.
1857
1858 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1859
1860 * print.c (print_object): Print empty symbol as ##.
1861
1862 * lread.c (read1): Read ## as empty symbol.
1863
1864 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1865
1866 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1867 setting frame foreground color (Bug#9175).
1868 (x_set_background_color): Likewise.
1869
1870 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1871 contents (Bug#9176).
1872 (EmacsTooltip -init): Remove bezels and add shadows to
1873 tooltip windows.
1874
1875 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1876 or scroll bar (Bug#8470).
1877
1878 * nsfont.m (nsfont_open): Remove assignment to voffset and
1879 unnecessary vars hshink, expand, hd, full_height, min_height.
1880 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1881
1882 * nsterm.h (nsfont_info): Remove voffset field.
1883
1884 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1885
1886 Implement strike-through and overline on NextStep (Bug#8863).
1887
1888 * nsfont.m (nsfont_open): Use underline position provided by font,
1889 instead of hard-coded value of 2.
1890 (nsfont_draw): Call ns_draw_text_decoration instead.
1891
1892 * nsterm.h: Add declaration for ns_draw_text_decoration.
1893
1894 * nsterm.m (ns_draw_text_decoration): New function for drawing
1895 underline, overline, and strike-through.
1896 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1897 ns_draw_text_decoration. Change treatment of cursor drawing to
1898 accommodate underlining, etc.
1899
1900 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1901
1902 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1903 default.
1904
1905 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1906
1907 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1908 Without this fix, if a signal arrives just after memory fills up,
1909 'malloc' might be invoked reentrantly.
1910
1911 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1912 In other words, assume that every image size is allowed, on non-X
1913 hosts. This assumption is probably wrong, but it lets Emacs compile.
1914
1915 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1916
1917 * regex.c (re_iswctype): Convert return values to boolean.
1918
1919 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1920
1921 * xdisp.c (compute_display_string_pos): Don't use cached display
1922 string position if the buffer had its restriction changed.
1923 (Bug#9184)
1924
1925 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1926
1927 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1928
1929 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1930
1931 Integer signedness and overflow and related fixes. (Bug#9079)
1932
1933 * bidi.c: Integer size and overflow fixes.
1934 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1935 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1936 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1937 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1938 (bidi_find_other_level_edge):
1939 Use ptrdiff_t instead of EMACS_INT where either will do.
1940 This works better on 32-bit hosts configured --with-wide-int.
1941 (bidi_cache_ensure_space): Check for size-calculation overflow.
1942 Use % rather than repeated addition, for better worst-case speed.
1943 Don't set bidi_cache_size until after xrealloc returns, because it
1944 might not return.
1945 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1946 (bidi_cache_ensure_space): Also check that the bidi cache size
1947 does not exceed that of the largest Lisp string or buffer. See Eli
1948 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1949
1950 * alloc.c (__malloc_size_t): Remove.
1951 All uses replaced by size_t. See Andreas Schwab's note
1952 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1953
1954 * image.c: Improve checking for integer overflow.
1955 (check_image_size): Assume that f is nonnull, since
1956 it is always nonnull in practice. This is one less thing to
1957 worry about when checking for integer overflow later.
1958 (x_check_image_size): New function, which checks for integer
1959 overflow issues inside X.
1960 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1961 This removes the need for a memory_full check.
1962 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1963 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1964 (xbm_read_bitmap_data): Change locals back to 'int', since
1965 their values must fit in 'int'.
1966 (xpm_load_image, png_load, tiff_load):
1967 Invoke x_create_x_image_and_pixmap earlier,
1968 to avoid much needless work if the image is too large.
1969 (tiff_load): Treat overly large images as if
1970 x_create_x_image_and_pixmap failed, not as malloc failures.
1971 (gs_load): Use x_check_image_size.
1972
1973 * gtkutil.c: Omit integer casts.
1974 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1975 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1976
1977 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1978
1979 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1980 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1981 would wrongly return t on a 64-bit host.
1982
1983 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1984 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1985 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1986 and therefore cause GCC to emit a bogus diagnostic in some cases.
1987
1988 * image.c: Integer signedness and overflow and related fixes.
1989 This is not an exhaustive set of fixes, but it's time to
1990 record what I've got.
1991 (lookup_pixel_color, check_image_size): Remove redundant decls.
1992 (check_image_size): Don't assume that arbitrary EMACS_INT values
1993 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1994 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1995 (tiff_load, imagemagick_load_image):
1996 Check for overflow in size calculations.
1997 (x_create_x_image_and_pixmap): Remove unnecessary test for
1998 xmalloc returning NULL; that can't happen.
1999 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2000 (xpm_color_bucket): Use better integer hashing function.
2001 (xpm_cache_color): Don't possibly over-allocate memory.
2002 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2003 (gif_memory_source):
2004 Use ptrdiff_t, not int or size_t, to record sizes.
2005 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2006 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2007 either works, as we prefer signed integers.
2008 (tiff_read_from_memory, tiff_write_from_memory):
2009 Return tsize_t, not size_t, since that's what the TIFF API wants.
2010 (tiff_read_from_memory): Don't fail simply because the read would
2011 go past EOF; instead, return a short read.
2012 (tiff_load): Omit no-longer-needed casts.
2013 (Fimagemagick_types): Don't assume size fits into 'int'.
2014
2015 Improve hashing quality when configured --with-wide-int.
2016 * fns.c (hash_string): New function, taken from sxhash_string.
2017 Do not discard information about ASCII character case; this
2018 discarding is no longer needed.
2019 (sxhash-string): Use it. Change sig to match it. Caller changed.
2020 * lisp.h: Declare it.
2021 * lread.c (hash_string): Remove, since we now use fns.c's version.
2022 The fns.c version returns a wider integer if --with-wide-int is
2023 specified, so this should help the quality of the hashing a bit.
2024
2025 * emacs.c: Integer overflow minor fix.
2026 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2027 Define only if GNU_LINUX.
2028 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2029
2030 * dispnew.c: Integer signedness and overflow fixes.
2031 Remove unnecessary forward decls, that were a maintenance hassle.
2032 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2033 All uses changed.
2034 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2035 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2036 (prepare_desired_row, line_draw_cost):
2037 Use int, not unsigned, where either works.
2038 (save_current_matrix, restore_current_matrix):
2039 Use ptrdiff_t, not size_t, where either works.
2040 (init_display): Check for overflow more accurately, and without
2041 relying on undefined behavior.
2042
2043 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2044 Remove, replacing with the new symbols in lisp.h. All uses changed.
2045 * fileio.c (make_temp_name):
2046 * filelock.c (lock_file_1, lock_file):
2047 * xdisp.c (message_dolog):
2048 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2049 Use pMd etc. instead.
2050 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2051 replacing the pWIDE etc. symbols removed from editfns.c.
2052
2053 * keyboard.h (num_input_events): Now uintmax_t.
2054 This is (very slightly) less likely to mess up due to wraparound.
2055 All uses changed.
2056
2057 * buffer.c: Integer signedness fixes.
2058 (alloc_buffer_text, enlarge_buffer_text):
2059 Use ptrdiff_t rather than size_t when either will do, as we prefer
2060 signed integers.
2061
2062 * alloc.c: Integer signedness and overflow fixes.
2063 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2064 (__malloc_size_t): Default to size_t, not to int.
2065 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2066 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2067 Prefer ptrdiff_t to size_t when either would do, as we prefer
2068 signed integers.
2069 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2070 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2071 Now const. Initialize with values that are in range even if char
2072 is signed.
2073 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2074 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2075 These functions do the right thing with sizes > 2**32.
2076 (check_depth): Now ptrdiff_t, not int.
2077 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2078 Adjust to new way of storing sizes. Check for size overflow bugs
2079 in rest of code.
2080 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2081 slightly wrong anyway, as it missed one instance of
2082 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2083 (refill_memory_reserve): Omit needless cast to size_t.
2084 (mark_object_loop_halt): Mark as externally visible.
2085
2086 * xselect.c: Integer signedness and overflow fixes.
2087 (Fx_register_dnd_atom, x_handle_dnd_message):
2088 Use ptrdiff_t, not size_t, since we prefer signed.
2089 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2090 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2091 x_dnd_atoms_size and x_dnd_atoms_length.
2092
2093 * doprnt.c: Prefer signed to unsigned when either works.
2094 * eval.c (verror):
2095 * doprnt.c (doprnt):
2096 * lisp.h (doprnt):
2097 * xdisp.c (vmessage):
2098 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2099 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2100 prefer signed arithmetic to avoid comparison confusion.
2101 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2102 but is a bit tricky.
2103
2104 Assume freestanding C89 headers, string.h, stdlib.h.
2105 * data.c, doprnt.c, floatfns.c, print.c:
2106 Include float.h unconditionally.
2107 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2108 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2109 * regex.c: Likewise for stddef.h, string.h.
2110 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2111 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2112 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2113 (STDC_HEADERS): Remove obsolete defines.
2114 * sysdep.c: Include limits.h unconditionally.
2115
2116 Assume support for memcmp, memcpy, memmove, memset.
2117 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2118 * regex.c (memcmp, memcpy):
2119 Remove; we assume C89 now.
2120
2121 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2122 (__malloc_safe_bcopy): Remove; no longer needed.
2123
2124 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
2125 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2126 well either way, and we prefer signed to unsigned.
2127
2128 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2129
2130 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2131 closes the connection while we're reading (bug#9182).
2132
2133 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
2134
2135 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2136 are specified (Bug#9168).
2137
2138 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2139
2140 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2141 Found by GCC static checking and --with-wide-int on a 32-bit host.
2142
2143 2011-07-25 Eli Zaretskii <eliz@gnu.org>
2144
2145 * xdisp.c (compute_display_string_pos): Fix logic of caching
2146 previous display string position. Initialize cached_prev_pos to
2147 -1. Fixes slow-down at the beginning of a buffer.
2148
2149 2011-07-24 Eli Zaretskii <eliz@gnu.org>
2150
2151 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2152 for attrs[LFACE_FONTSET_INDEX].
2153
2154 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2155
2156 * xml.c (parse_region): Remove unused local
2157 that was recently introduced.
2158
2159 2011-07-23 Eli Zaretskii <eliz@gnu.org>
2160
2161 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2162 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2163
2164 * xdisp.c (move_it_in_display_line_to): Record the best matching
2165 position for TO_CHARPOS while scanning the line, and restore it on
2166 exit if none of the characters scanned was an exact match.
2167 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
2168 when exact match is impossible due to invisible text, and the
2169 lines are truncated.
2170
2171 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2172
2173 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2174 for OSX >= 10.7.
2175
2176 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2177
2178 Fix a significant slow-down of cursor motion with C-n, C-p,
2179 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2180 auto-repeat under bidi redisplay in fontified buffers.
2181 * xdisp.c (compute_stop_pos_backwards): New function.
2182 (next_element_from_buffer): Call compute_stop_pos_backwards to
2183 find a suitable prev_stop when we find ourselves before
2184 base_level_stop.
2185 (reseat): Don't look for prev_stop, as that could mean a very long
2186 run.
2187 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2188 <cached_disp_overlay_modiff>: Cache for last found display string
2189 position.
2190 (compute_display_string_pos): Return the cached position if asked
2191 about the same buffer in the same area of character positions, and
2192 the buffer wasn't changed since the time the display string
2193 position was cached.
2194
2195 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2196
2197 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2198 is an integer, which is important for empty lines. (Bug#9149)
2199
2200 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
2201
2202 * frame.c (Fmodify_frame_parameters): In tty case, update the
2203 default face if necessary (Bug#4238).
2204
2205 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
2206
2207 * editfns.c (Fstring_to_char): No need to explain what a character
2208 is in the docstring (Bug#6576).
2209
2210 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2211
2212 * xml.c (parse_region): Make sure we always return a tree.
2213
2214 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2215
2216 * xml.c (parse_region): If a document contains only comments,
2217 return that, too.
2218
2219 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2220
2221 * xml.c (make_dom): Return comments, too.
2222
2223 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2224
2225 Port to OpenBSD.
2226 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2227 and the surrounding thread.
2228 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2229 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2230 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2231 timer goes off.
2232 * s/openbsd.h (BROKEN_SIGIO): Define.
2233 * unexelf.c (unexec) [__OpenBSD__]:
2234 Don't update the .mdebug section of the Alpha COFF symbol table.
2235
2236 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2237
2238 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2239 (bug#8460).
2240
2241 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2242
2243 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2244 This fixes some race conditions on the permissions of any newly
2245 created file.
2246
2247 * alloc.c (valid_pointer_p): Use pipe, not open.
2248 This fixes some permissions issues when debugging.
2249
2250 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2251 If fchown fails to set both uid and gid, try to set just gid,
2252 as that is sometimes allowed. Adjust the file's mode to eliminate
2253 setuid or setgid bits that are inappropriate if fchown fails.
2254
2255 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2256
2257 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2258 to compare Lisp_Objects.
2259 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2260 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2261 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2262
2263 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2264
2265 * lread.c (read_integer): Unread even EOF character.
2266 (read1): Likewise. Properly record start position of symbol.
2267
2268 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2269 symbol character follows.
2270
2271 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2272
2273 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2274 This works around a problem with the previous change to Fcopy_file.
2275 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2276 and without this change, GCC might complain about discarding
2277 fchown's return value.
2278
2279 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
2280
2281 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2282
2283 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2284
2285 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2286
2287 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2288
2289 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2290 it's used from the C level.
2291
2292 * process.c: Use the same condition for POLL_FOR_INPUT in both
2293 keyboard.c and process.c (bug#1858).
2294
2295 2011-07-09 Lawrence Mitchell <wence@gmx.li>
2296
2297 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2298 (Fgnutls_boot): Use it.
2299
2300 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2301
2302 * doc.c (Fsubstitute_command_keys): Revert last change.
2303
2304 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2305
2306 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2307 quotes the next character, and doesn't affect other longer
2308 sequences (bug#8935).
2309
2310 * lread.c (syms_of_lread): Clarify that is isn't only
2311 `eval-buffer' and `eval-defun' that's affected by
2312 `lexical-binding' (bug#8460).
2313
2314 2011-07-15 Eli Zaretskii <eliz@gnu.org>
2315
2316 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2317 bidi redisplay when a line includes both an image and is truncated.
2318
2319 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2320
2321 Fix minor problems found by static checking.
2322 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2323 (elsz): Now a signed constant, not a size_t var. We prefer signed
2324 types to unsigned, to avoid integer comparison confusion. Without
2325 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2326 "cannot optimize loop, the loop counter may overflow", a symptom
2327 of the confusion.
2328 * indent.c (Fvertical_motion): Mark locals as initialized.
2329 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2330
2331 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2332
2333 * search.c (Fre_search_backward): Mention `case-fold-search' in
2334 all the re_search_* functions (bug#8138).
2335
2336 * keyboard.c (Fopen_dribble_file): Document when the file is
2337 closed (bug#8056).
2338
2339 2011-07-14 Eli Zaretskii <eliz@gnu.org>
2340
2341 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2342 bidi_cache_idx.
2343
2344 Support bidi reordering of display and overlay strings.
2345 * xdisp.c (compute_display_string_pos)
2346 (compute_display_string_end): Accept additional argument STRING.
2347 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2348 (reseat_to_string): Initialize bidi_it->string.s and
2349 bidi_it->string.schars.
2350 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
2351 NULL (avoids a crash in bidi_paragraph_init).
2352 Initialize itb.string.lstring.
2353 (init_iterator): Call bidi_init_it only of a valid
2354 buffer position was specified. Initialize paragraph_embedding to
2355 L2R.
2356 (reseat_to_string): Initialize the bidi iterator.
2357 (display_string): If we need to ignore text properties of
2358 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2359 original value of -1 will not work with bidi.)
2360 (compute_display_string_pos): First arg is now struct
2361 `text_pos *'; all callers changed. Support display properties on
2362 Lisp strings.
2363 (compute_display_string_end): Support display properties on Lisp
2364 strings.
2365 (init_iterator, reseat_1, reseat_to_string): Initialize the
2366 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2367 when iterating on a string not from display properties).
2368 (compute_display_string_pos, compute_display_string_end):
2369 Fix calculation of the object to scan. Fixes an error when using
2370 arrow keys.
2371 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2372 base_level_stop; instead, set base_level_stop to BEGV.
2373 Fixes crashes in vertical-motion.
2374 (next_element_from_buffer): Improve commentary for when
2375 the iterator is before prev_stop.
2376 (init_iterator): Initialize bidi_p from the default value of
2377 bidi-display-reordering, not from buffer-local value. Use the
2378 buffer-local value only if initializing for buffer iteration.
2379 (handle_invisible_prop): Support invisible properties on strings
2380 that are being bidi-reordered.
2381 (set_iterator_to_next): Support bidi reordering of C strings and
2382 Lisp strings.
2383 (next_element_from_string): Support bidi reordering of Lisp
2384 strings.
2385 (handle_stop_backwards): Support Lisp strings as well.
2386 (display_string): Support display of R2L glyph rows.
2387 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2388 (init_iterator): Don't initialize it->bidi_p for strings
2389 here.
2390 (reseat_to_string): Initialize it->bidi_p for strings here.
2391 (next_element_from_string, next_element_from_c_string)
2392 (next_element_from_buffer): Add xassert's for correspondence
2393 between IT's object being iterated and it->bidi_it.string
2394 structure.
2395 (face_before_or_after_it_pos): Support bidi iteration.
2396 (next_element_from_c_string): Handle the case of the first string
2397 character that is not the first one in the visual order.
2398 (get_visually_first_element): New function, refactored from common
2399 parts of next_element_from_buffer, next_element_from_string, and
2400 next_element_from_c_string.
2401 (tool_bar_lines_needed, redisplay_tool_bar)
2402 (display_menu_bar): Force left-to-right direction. Add a FIXME
2403 comment for making that be controlled by a user option.
2404 (push_it, pop_it): Save and restore the state of the
2405 bidi iterator. Save and restore the bidi_p flag.
2406 (pop_it): Iterate out of display property for string iteration as
2407 well.
2408 (iterate_out_of_display_property): Support iteration over strings.
2409 (handle_single_display_spec): Set up it->bidi_it for iteration
2410 over a display string, and call bidi_init_it.
2411 (handle_single_display_spec, next_overlay_string)
2412 (get_overlay_strings_1, push_display_prop): Set up the bidi
2413 iterator for displaying display or overlay strings.
2414 (forward_to_next_line_start): Don't use the shortcut if
2415 bidi-iterating.
2416 (back_to_previous_visible_line_start): If handle_display_prop
2417 pushed the iterator stack, restore the internal state of the bidi
2418 iterator by calling bidi_pop_it same number of times.
2419 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2420 and we are bidi-iterating, don't decrement the iterator position;
2421 instead, set the first_elt flag in the bidi iterator, to produce
2422 the same effect.
2423 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2424 (push_display_prop): xassert that we are iterating a buffer.
2425 (push_it, pop_it): Save and restore paragraph_embedding member.
2426 (handle_single_display_spec, next_overlay_string)
2427 (get_overlay_strings_1, reseat_1, reseat_to_string)
2428 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2429 correctly. Don't assume unibyte strings are not bidi-reordered.
2430 (compute_display_string_pos)
2431 (compute_display_string_end): Fix handling the case of C string.
2432 (push_it, pop_it): Save and restore from_disp_prop_p.
2433 (handle_single_display_spec, push_display_prop): Set the
2434 from_disp_prop_p flag.
2435 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2436 (pop_it): Call iterate_out_of_display_property only if we are
2437 popping after iteration over a string that came from a display
2438 property. Fix a typo in popping stretch info. Add an assertion
2439 for verifying that the iterator position is in sync with the bidi
2440 iterator.
2441 (handle_single_display_spec, get_overlay_strings_1)
2442 (push_display_prop): Fix initialization of paragraph direction for
2443 string when that of the parent object is not yet determined.
2444 (reseat_1): Call bidi_init_it to resync the bidi
2445 iterator with IT's position. (Bug#7616)
2446 (find_row_edges): If ROW->start.pos gives position
2447 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2448 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2449 Reset the from_disp_prop_p flag.
2450 (SAVE_IT, RESTORE_IT): New macros.
2451 (pos_visible_p, face_before_or_after_it_pos)
2452 (back_to_previous_visible_line_start)
2453 (move_it_in_display_line_to, move_it_in_display_line)
2454 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2455 (try_scrolling, redisplay_window, display_line): Use them when
2456 saving a temporary copy of the iterator and restoring it back.
2457 (back_to_previous_visible_line_start, reseat_1)
2458 (init_iterator): Empty the bidi cache "stack".
2459 (move_it_in_display_line_to): If iterator ended up at
2460 EOL, but we never saw any buffer positions smaller than
2461 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2462 motion in bidi-reordered lines.
2463 (move_it_in_display_line_to): Record prev_method and prev_pos
2464 immediately before the call to set_iterator_to_next. Fixes cursor
2465 motion in bidi-reordered lines with stretch glyphs and strings
2466 displayed in margins. (Bug#8133) (Bug#8867)
2467 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2468 TO_CHARPOS.
2469 (pos_visible_p): Support positions in bidi-reordered lines.
2470 Save and restore bidi cache.
2471
2472 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2473 (bidi_paragraph_info): Delete unused struct.
2474 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2475 (bidi_cache_start): New variable.
2476 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2477 to zero.
2478 (bidi_cache_fetch_state, bidi_cache_search)
2479 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2480 (bidi_cache_find, bidi_peek_at_next_level)
2481 (bidi_level_of_next_char, bidi_find_other_level_edge)
2482 (bidi_move_to_visually_next): Compare cache index with
2483 bidi_cache_start rather than with zero.
2484 (bidi_fetch_char): Accept new argument STRING; all callers
2485 changed. Support iteration over a string. Support strings with
2486 display properties. Support unibyte strings. Fix the type of
2487 `len' according to what STRING_CHAR_AND_LENGTH expects.
2488 (bidi_paragraph_init, bidi_resolve_explicit_1)
2489 (bidi_resolve_explicit, bidi_resolve_weak)
2490 (bidi_level_of_next_char, bidi_move_to_visually_next):
2491 Support iteration over a string.
2492 (bidi_set_sor_type, bidi_resolve_explicit_1)
2493 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2494 can now be zero (for strings); special values 0 and -1 were
2495 changed to -1 and -2, respectively.
2496 (bidi_char_at_pos): New function.
2497 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2498 Call it instead of FETCH_MULTIBYTE_CHAR.
2499 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2500 initialized to valid values.
2501 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2502 values.
2503 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2504 the test for valid cached positions. Fix the logic for looking up
2505 the sentinel state in the cache. GCPRO the Lisp string we are
2506 iterating.
2507 (bidi_push_it, bidi_pop_it): New functions.
2508 (bidi_initialize): Initialize the bidi cache start stack pointer.
2509 (bidi_cache_ensure_space): New function, refactored from part of
2510 bidi_cache_iterator_state. Don't assume the required size is just
2511 one BIDI_CACHE_CHUNK away.
2512 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2513 (bidi_count_bytes, bidi_char_at_pos): New functions.
2514 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2515 always valid if bidi_cache_idx is valid.
2516 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2517 is valid if it's going to be used.
2518 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2519 (bidi_cache_fetch_state, bidi_cache_search)
2520 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2521 (bidi_cache_iterator_state, bidi_cache_find)
2522 (bidi_find_other_level_edge, bidi_cache_start_stack):
2523 All variables related to cache indices are now EMACS_INT.
2524
2525 * dispextern.h (struct bidi_string_data): New structure.
2526 (struct bidi_it): New member `string'. Make flag members be 1-bit
2527 fields, and put them last in the struct.
2528 (compute_display_string_pos, compute_display_string_end):
2529 Update prototypes.
2530 (bidi_push_it, bidi_pop_it): Add prototypes.
2531 (struct iterator_stack_entry): New members bidi_p,
2532 paragraph_embedding, and from_disp_prop_p.
2533 (struct it): Member bidi_p is now a bit field 1 bit wide.
2534 (bidi_shelve_cache, bidi_unshelve_cache):
2535 Declare prototypes.
2536
2537 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2538 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2539 and vector-like objects.
2540
2541 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2542 cache around display iteration.
2543
2544 * window.c (Fwindow_end, window_scroll_pixel_based)
2545 (displayed_window_lines, Frecenter): Save and restore the bidi
2546 cache around display iteration.
2547
2548 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2549
2550 * editfns.c (Fdelete_region): Clarify the use of the named
2551 parameters (bug#6788).
2552
2553 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2554
2555 * indent.c (Fvertical_motion): Set and restore w->pointm when
2556 saving and restoring the window's buffer (Bug#9006).
2557
2558 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2559
2560 * editfns.c (Fstring_to_char): Clarify just what is returned
2561 (bug#6576). Text by Eli Zaretskii.
2562
2563 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2564
2565 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2566
2567 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2568
2569 * buffer.c (mmap_find): Fix a typo.
2570
2571 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2572
2573 Fix execution of x selection hooks.
2574 * xselect.c (Qx_lost_selection_functions)
2575 (Qx_sent_selection_functions): New vars.
2576 (syms_of_xselect): DEFSYM them.
2577 (x_handle_selection_request): Pass Qx_sent_selection_functions
2578 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2579 (x_handle_selection_clear,x_clear_frame_selections):
2580 Pass Qx_lost_selection_functions rather than
2581 Vx_lost_selection_functions to Frun_hook_with_args.
2582
2583 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2584
2585 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2586 The old code sometimes used this field without initializing it.
2587
2588 * alloc.c (gc_sweep): Don't read past end of array.
2589 In theory, the old code could also have corrupted Emacs internals,
2590 though it'd be very unlikely.
2591
2592 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2593
2594 * character.c (Fcharacterp): Don't advertise optional ignored
2595 argument. (Bug#4026)
2596
2597 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2598
2599 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2600 key" (bug#4257).
2601
2602 * window.c (Fset_window_start): Doc fix (bug#4199).
2603 (Fset_window_hscroll): Ditto.
2604
2605 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2606
2607 Fix minor new problems caught by GCC 4.6.1.
2608 * term.c (init_tty): Remove unused local.
2609 * xsettings.c (store_monospaced_changed): Define this function only
2610 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2611 not used otherwise.
2612
2613 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2614
2615 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2616
2617 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2618
2619 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2620 are the mini-buffer and the echo area (bug#3320).
2621
2622 * term.c (init_tty): Remove support for supdup, c10 and perq
2623 terminals, which are no longer supported (bug#1482).
2624
2625 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2626
2627 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2628
2629 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2630
2631 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2632 for non-popups (Bug#3642).
2633
2634 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2635
2636 * alloc.c (reset_malloc_hooks): Protoize.
2637 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2638 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2639 * cm.c (losecursor): Likewise.
2640 * data.c (fmod): Likewise.
2641 * dispnew.c (swap_glyphs_in_rows): Likewise.
2642 * emacs.c (memory_warning_signal): Likewise.
2643 * floatfns.c (float_error): Likewise.
2644 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2645 (otf_open, font_otf_capability, generate_otf_features)
2646 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2647 Likewise.
2648 * image.c (pbm_read_file): Likewise.
2649 * indent.c (string_display_width): Likewise.
2650 * intervals.c (check_for_interval, search_for_interval)
2651 (inc_interval_count, count_intervals, root_interval)
2652 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2653 * lread.c (defalias): Likewise.
2654 * ralloc.c (r_alloc_check): Likewise.
2655 * regex.c (set_image_of_range_1, set_image_of_range)
2656 (regex_grow_registers): Likewise.
2657 * sysdep.c (strerror): Likewise.
2658 * termcap.c (valid_filename_p, tprint, main): Likewise.
2659 * tparam.c (main): Likewise.
2660 * unexhp9k800.c (run_time_remap, save_data_space)
2661 (update_file_ptrs, read_header, write_header, calculate_checksum)
2662 (copy_file, copy_rest, display_header): Likewise.
2663 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2664 Likewise.
2665 * xdisp.c (check_it): Likewise.
2666 * xfaces.c (register_color, unregister_color, unregister_colors):
2667 Likewise.
2668 * xfns.c (print_fontset_result): Likewise.
2669 * xrdb.c (member, fatal, main): Likewise.
2670
2671 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2672
2673 Fix minor problems found by static checking (Bug#9031).
2674 * chartab.c (char_table_set_range, map_sub_char_table):
2675 Remove unused locals.
2676 (uniprop_table): Now static.
2677 * composite.c (_work_char): Remove unused static var.
2678
2679 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2680
2681 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2682
2683 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2684
2685 * gtkutil.c (qttip_cb): Remove code without function.
2686
2687 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2688
2689 * w32.c (pthread_sigmask): New stub.
2690
2691 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2692
2693 Use pthread_sigmask, not sigprocmask (Bug#9010).
2694 sigprocmask is portable only for single-threaded applications, and
2695 Emacs can be multi-threaded when it uses GTK.
2696 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2697 (LIBES): Use it.
2698 * callproc.c (Fcall_process):
2699 * process.c (create_process):
2700 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2701 Use pthread_sigmask, not sigprocmask.
2702
2703 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2704
2705 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2706 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2707 wrong (Bug#8591).
2708
2709 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2710
2711 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2712 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2713 (xg_hide_tooltip): Fix comment.
2714
2715 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2716 in registerServicesMenuSendTypes.
2717 (validRequestorForSendType): Don't check ns_return_types.
2718
2719 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2720 ns_return_type.
2721
2722 2011-07-08 Jason Rumney <jasonr@gnu.org>
2723
2724 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2725 frame struct members of non-existent frames (Bug#6284).
2726
2727 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2728
2729 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2730 variable firstTime not needed on OSX >= 10.6.
2731 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2732 >= 10.5. Use setKnobProportion, setDoubleValue.
2733
2734 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2735 (MAC_OS_X_VERSION_10_5): Define if not defined.
2736 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2737 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2738 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2739
2740 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2741 cString and lossyCString on OSX >= 10.4
2742
2743 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2744 sizeToFit on OSX >= 10.2.
2745
2746 * nsimage.m (allocInitFromFile): Don't use deprecated method
2747 bestRepresentationForDevice on OSX >= 10.6.
2748
2749 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2750 to avoid warning.
2751
2752 * emacs.c: Declare unexec_init_emacs_zone.
2753
2754 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2755
2756 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2757
2758 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2759 on svcsMenu (Bug#8842).
2760
2761 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2762 ns_return_types.
2763 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2764
2765 * nsterm.m (QUTF8_STRING): Declare.
2766 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2767 (validRequestorForSendType): Return type is (id).
2768 Change indexOfObjectIdenticalTo to indexOfObject.
2769 Check if we have local selection before returning self (Bug#8842).
2770 (writeSelectionToPasteboard): Put local selection into paste board
2771 if we have a local selection (Bug#8842).
2772 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2773
2774 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2775 (ns_get_local_selection): Declare.
2776
2777 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2778
2779 * keymap.c (describe_map_tree): Don't insert a double newline at
2780 the end of the buffer (bug#1169) and return whether we inserted
2781 something.
2782
2783 * callint.c (Fcall_interactively): Change "reading args" to
2784 "providing args" to try to clarify what it does (bug#1010).
2785
2786 2011-07-07 Kenichi Handa <handa@m17n.org>
2787
2788 * composite.c (composition_compute_stop_pos): Ignore a static
2789 composition starting before CHARPOS (Bug#8915).
2790
2791 * xdisp.c (handle_composition_prop): Likewise.
2792
2793 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2794
2795 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2796 (Bug#9015)
2797
2798 2011-07-07 Kenichi Handa <handa@m17n.org>
2799
2800 * character.h (unicode_category_t): New enum type.
2801
2802 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2803 (Qchar_code_property_table): New variable.
2804 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2805 (UNIPROP_COMPRESSED_FORM_P): New macros.
2806 (char_table_ascii): Uncompress the compressed values.
2807 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2808 Uncompress the compressed values.
2809 (sub_char_table_ref_and_range): Likewise.
2810 (char_table_ref_and_range): Uncompress the compressed values.
2811 (sub_char_table_set): New arg is_uniprop. Callers changed.
2812 Uncompress the compressed values.
2813 (sub_char_table_set_range): Args changed. Callers changed.
2814 (char_table_set_range): Adjuted for the above change.
2815 (map_sub_char_table): Delete args default_val and parent. Add arg
2816 top. Give decoded values to a Lisp function.
2817 (map_char_table): Adjust for the above change. Give decoded
2818 values to a Lisp function. Gcpro more variables.
2819 (uniprop_table_uncompress)
2820 (uniprop_decode_value_run_length): New functions.
2821 (uniprop_decoder, uniprop_decoder_count): New variables.
2822 (uniprop_get_decoder, uniprop_encode_value_character)
2823 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2824 New functions.
2825 (uniprop_encoder, uniprop_encoder_count): New variables.
2826 (uniprop_get_encoder, uniprop_table)
2827 (Funicode_property_table_internal, Fget_unicode_property_internal)
2828 (Fput_unicode_property_internal): New functions.
2829 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2830 Sunicode_property_table_internal, Sget_unicode_property_internal,
2831 and Sput_unicode_property_internal. Defvar_lisp
2832 char-code-property-alist.
2833
2834 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2835 Vunicode_category_table.
2836
2837 * font.c (font_range): Adjust for the change of
2838 Vunicode_category_table.
2839
2840 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2841
2842 * m/iris4d.h: Remove file, move contents ...
2843 * s/irix6-5.h: ... here.
2844
2845 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2846
2847 Remove unportable assumption about struct layout (Bug#8884).
2848 * alloc.c (mark_buffer):
2849 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2850 (clone_per_buffer_values): Don't assume that
2851 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2852 This isn't true in general, and it's particularly not true
2853 if Emacs is configured with --with-wide-int.
2854 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2855 New macros, used in the buffer.c change.
2856
2857 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2858
2859 * xsettings.c: Use both GConf and GSettings if both are available.
2860 (store_config_changed_event): Add comment.
2861 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2862 (store_tool_bar_style_changed): New functions.
2863 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2864 (struct xsettings): Move font inside HAVE_XFT.
2865 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2866 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2867 Move inside HAVE_XFT.
2868 (something_changed_gsettingsCB): Rename from something_changedCB.
2869 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2870 also.
2871 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2872 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2873 (something_changed_gconfCB): Rename from something_changedCB.
2874 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2875 (parse_settings): Move check for font inside HAVE_XFT.
2876 (read_settings, apply_xft_settings): Add comment.
2877 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2878 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2879 call store_font_name_changed.
2880 (xft_settings_event): Add comment.
2881 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2882 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2883 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2884 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2885 (xsettings_initialize): Call init_gsettings last.
2886 (xsettings_get_system_font, xsettings_get_system_normal_font):
2887 Add comment.
2888
2889 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2890
2891 Random fixes. E.g., (random) never returned negative values.
2892 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2893 subseconds part to the entropy, as that's a bit more random.
2894 Prefer signed to unsigned, since the signedness doesn't matter and
2895 in general we prefer signed. When given a limit, use a
2896 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2897 latter isn't right if USE_2_TAGS_FOR_INTS.
2898 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2899 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2900
2901 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2902
2903 * textprop.c (text_property_stickiness):
2904 Obey Vtext_property_default_nonsticky.
2905 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2906 * w32fns.c (syms_of_w32fns):
2907 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2908
2909 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2910
2911 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2912 This is more efficient than Ffile_directory_p and avoids a minor race.
2913
2914 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2915
2916 * buffer.c (Foverlay_put): Say what the return value is
2917 (bug#7835).
2918
2919 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2920 is a directory before asking whether to use the file name
2921 (bug#7564).
2922 (barf_or_query_if_file_exists): Make the "File is a directory"
2923 error be more correct.
2924
2925 * fns.c (Frequire): Remove the mention of the .gz files, since
2926 that's installation-specific, but keep the mention of
2927 `get-load-suffixes'.
2928
2929 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2930
2931 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2932 Report string overflow if the output is too long.
2933
2934 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2935
2936 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2937 (syms_of_gnutls): Remove duplicate DEFSYM for
2938 Qgnutls_bootprop_verify_hostname_error, an error for
2939 Qgnutls_bootprop_verify_error (which is no longer used).
2940
2941 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2942 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2943 Also (re)move comments that are misplaced or no longer relevant.
2944
2945 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2946
2947 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2948
2949 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2950
2951 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2952 and background color parameters if they have been changed.
2953
2954 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2955
2956 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2957
2958 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2959
2960 * xsettings.c (SYSTEM_FONT): Define only when used.
2961 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2962
2963 * keymap.c (access_keymap_1): Now static.
2964
2965 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2966
2967 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2968 leave any prefix arg for the up event (Bug#1586).
2969
2970 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2971
2972 * lread.c (syms_of_lread): Mention single symbols defined by
2973 `defvar' or `defconst' (bug#7154).
2974
2975 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2976 (Frequire): Mention get-load-suffixes.
2977
2978 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2979
2980 * window.h (window): Remove clone_number slot.
2981 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2982 Remove.
2983 (make_parent_window, make_window, saved_window)
2984 (Fset_window_configuration, save_window_save): Don't deal with
2985 clone numbers.
2986 * buffer.c (Qclone_number): Remove declaration.
2987 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2988
2989 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2990
2991 Add multiple inheritance to keymaps.
2992 * keymap.c (Fmake_composed_keymap): New function.
2993 (Fset_keymap_parent): Simplify.
2994 (fix_submap_inheritance): Remove.
2995 (access_keymap_1): New function extracted from access_keymap to handle
2996 embedded parents and handle lists of maps.
2997 (access_keymap): Use it.
2998 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2999 (Fcopy_keymap): Handle embedded parents.
3000 (Fcommand_remapping, define_as_prefix): Simplify.
3001 (Fkey_binding): Simplify.
3002 (syms_of_keymap): Move minibuffer-local-completion-map,
3003 minibuffer-local-filename-completion-map,
3004 minibuffer-local-must-match-map, and
3005 minibuffer-local-filename-must-match-map to Elisp.
3006 (syms_of_keymap): Defsubr make-composed-keymap.
3007 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3008 (parse_menu_item): Trivial simplification.
3009
3010 2011-07-01 Glenn Morris <rgm@gnu.org>
3011
3012 * Makefile.in (SETTINGS_LIBS): Fix typo.
3013
3014 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3015
3016 * coding.c (Fencode_coding_string): Record the last coding system
3017 used, as the function doc string says (bug#8738).
3018
3019 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3020
3021 * xsettings.c (store_monospaced_changed): Take new font as arg and
3022 check for change against current_mono_font.
3023 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3024 (emacs_settings_constructor, emacs_settings_get_property)
3025 (emacs_settings_set_property, emacs_settings_class_init)
3026 (emacs_settings_init, gsettings_obj): Remove.
3027 (something_changedCB): New function for HAVE_GSETTINGS.
3028 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3029 with value as argument.
3030 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3031 g_settings_new (Bug#8967). Do not create gsettings_obj.
3032 Remove calls to g_settings_bind. Connect something_changedCB to
3033 "changed".
3034
3035 * xgselect.c: Add defined (HAVE_GSETTINGS).
3036 (xgselect_initialize): Ditto.
3037
3038 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3039 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3040 xg_select.
3041
3042 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3043
3044 * eval.c (struct backtrace): Simplify and port the data structure.
3045 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3046 signed bit field, as this assumption is not portable and it makes
3047 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3048 "char debug_on_exit : 1" as this is not portable either; instead,
3049 use the portable "unsigned int debug_on_exit : 1". Remove unused
3050 member evalargs. Remove obsolete comments about cc bombing out.
3051
3052 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3053
3054 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
3055 Let HAVE_GSETTINGS override HAVE_GCONF.
3056 (store_monospaced_changed): New function.
3057 (EMACS_SETTINGS): A new type derived from GObject to handle
3058 GSettings notifications.
3059 (emacs_settings_constructor, emacs_settings_get_property)
3060 (emacs_settings_set_property, emacs_settings_class_init):
3061 New functions.
3062 (gsettings_client, gsettings_obj): New variables.
3063 (GSETTINGS_SCHEMA): New define.
3064 (something_changedCB): Call store_monospaced_changed.
3065 (init_gsettings): New function.
3066 (xsettings_initialize): Call init_gsettings.
3067 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3068 to NULL.
3069
3070 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
3071 GCONF_CFLAGS/LIBS.
3072
3073 2011-06-29 Martin Rudalics <rudalics@gmx.at>
3074
3075 * window.c (resize_root_window, grow_mini_window)
3076 (shrink_mini_window): Rename Qresize_root_window to
3077 Qwindow_resize_root_window and Qresize_root_window_vertically to
3078 Qwindow_resize_root_window_vertically.
3079
3080 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3081
3082 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3083
3084 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
3085
3086 * makefile.w32-in: Redesign dependencies so they reflect more
3087 clearly which files are directly included by each source file,
3088 and not through other includes.
3089
3090 2011-06-27 Martin Rudalics <rudalics@gmx.at>
3091
3092 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3093 (sort_overlays, overlay_strings): When an overlay's clone number
3094 matches the window's clone number process the overlay even if
3095 the overlay's window property doesn't match the current window.
3096
3097 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3098 (Fwindow_hchild): Rename to Fwindow_left_child.
3099 (Fwindow_next): Rename to Fwindow_next_sibling.
3100 (Fwindow_prev): Rename to Fwindow_prev_sibling.
3101 (resize_window_check): Rename to window_resize_check.
3102 (resize_window_apply): Rename to window_resize_apply.
3103 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3104 (Fdelete_other_windows_internal, resize_frame_windows)
3105 (Fsplit_window_internal, Fdelete_window_internal)
3106 (grow_mini_window, shrink_mini_window)
3107 (Fresize_mini_window_internal): Fix callers accordingly.
3108
3109 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3110
3111 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3112 (emacs_fixed_set_min_size): Remove.
3113 (emacs_fixed_new): Take frame as argument.
3114
3115 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3116 (_EmacsFixedPrivate): Remove minwidth/height.
3117 Add struct frame *f.
3118 (emacs_fixed_init): Initialize priv->f.
3119 (get_parent_class, emacs_fixed_set_min_size): Remove.
3120 (emacs_fixed_new): Set priv->f to argument.
3121 (emacs_fixed_get_preferred_width)
3122 (emacs_fixed_get_preferred_height): Use min_width/height from
3123 frames size_hint to set minimum and natural (Bug#8919).
3124 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3125 and use min_width/height from frames size_hint to set
3126 min_width/height (Bug#8919).
3127
3128 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
3129 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3130 Fix indentation.
3131
3132 2011-06-26 Eli Zaretskii <eliz@gnu.org>
3133
3134 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3135 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3136 called at ZV.
3137
3138 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
3139
3140 * process.c (wait_reading_process_output): Bypass select if
3141 waiting for a cell while ignoring keyboard input, and input is
3142 pending. Suggested by Jan Djärv (Bug#8869).
3143
3144 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3145
3146 Use gnulib's dup2 module instead of rolling our own.
3147 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3148
3149 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3150
3151 * dispnew.c (scrolling_window): Before scrolling, turn off a
3152 mouse-highlight in the window being scrolled.
3153
3154 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
3155
3156 Move DEFSYM to lisp.h and use everywhere.
3157
3158 * character.h (DEFSYM): Move declaration...
3159 * lisp.h (DEFSYM): ...here.
3160
3161 * gnutls.c:
3162 * minibuf.c:
3163 * w32menu.c:
3164 * w32proc.c:
3165 * w32select.c: Don't include character.h.
3166
3167 * alloc.c (syms_of_alloc):
3168 * buffer.c (syms_of_buffer):
3169 * bytecode.c (syms_of_bytecode):
3170 * callint.c (syms_of_callint):
3171 * casefiddle.c (syms_of_casefiddle):
3172 * casetab.c (init_casetab_once):
3173 * category.c (init_category_once, syms_of_category):
3174 * ccl.c (syms_of_ccl):
3175 * cmds.c (syms_of_cmds):
3176 * composite.c (syms_of_composite):
3177 * dbusbind.c (syms_of_dbusbind):
3178 * dired.c (syms_of_dired):
3179 * dispnew.c (syms_of_display):
3180 * doc.c (syms_of_doc):
3181 * editfns.c (syms_of_editfns):
3182 * emacs.c (syms_of_emacs):
3183 * eval.c (syms_of_eval):
3184 * fileio.c (syms_of_fileio):
3185 * fns.c (syms_of_fns):
3186 * frame.c (syms_of_frame):
3187 * fringe.c (syms_of_fringe):
3188 * insdel.c (syms_of_insdel):
3189 * keymap.c (syms_of_keymap):
3190 * lread.c (init_obarray, syms_of_lread):
3191 * macros.c (syms_of_macros):
3192 * msdos.c (syms_of_msdos):
3193 * print.c (syms_of_print):
3194 * process.c (syms_of_process):
3195 * search.c (syms_of_search):
3196 * sound.c (syms_of_sound):
3197 * syntax.c (init_syntax_once, syms_of_syntax):
3198 * terminal.c (syms_of_terminal):
3199 * textprop.c (syms_of_textprop):
3200 * undo.c (syms_of_undo):
3201 * w32.c (globals_of_w32):
3202 * window.c (syms_of_window):
3203 * xdisp.c (syms_of_xdisp):
3204 * xfaces.c (syms_of_xfaces):
3205 * xfns.c (syms_of_xfns):
3206 * xmenu.c (syms_of_xmenu):
3207 * xsettings.c (syms_of_xsettings):
3208 * xterm.c (syms_of_xterm): Use DEFSYM.
3209
3210 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3211
3212 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
3213
3214 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3215
3216 Integer and buffer overflow fixes (Bug#8873).
3217
3218 * print.c (printchar, strout): Check for string overflow.
3219 (PRINTPREPARE, printchar, strout):
3220 Don't set size unless allocation succeeds.
3221
3222 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3223 for sizes. Check for string overflow more accurately.
3224 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3225
3226 * macros.c: Integer and buffer overflow fixes.
3227 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3228 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3229 Use ptrdiff_t, not int, for sizes.
3230 Don't increment bufsize until after realloc succeeds.
3231 Check for size-calculation overflow.
3232 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3233
3234 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3235
3236 * lread.c: Integer overflow fixes.
3237 (read_integer): Radix is now EMACS_INT, not int,
3238 to improve quality of diagnostics for out-of-range radices.
3239 Calculate buffer size correctly for out-of-range radices.
3240 (read1): Check for integer overflow in radices, and in
3241 read-circle numbers.
3242 (read_escape): Avoid int overflow.
3243 (Fload, openp, read_buffer_size, read1)
3244 (substitute_object_recurse, read_vector, read_list, map_obarray):
3245 Use ptrdiff_t, not int, for sizes.
3246 (read1): Use EMACS_INT, not int, for sizes.
3247 Check for size overflow.
3248
3249 * image.c (cache_image): Check for size arithmetic overflow.
3250
3251 * lread.c: Integer overflow issues.
3252 (saved_doc_string_size, saved_doc_string_length)
3253 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3254 Now ptrdiff_t, not int.
3255 (read1): Don't assume doc string length fits in int. Check for
3256 out-of-range doc string lengths.
3257 (read_list): Don't assume file position fits in int.
3258 (read_escape): Check for hex character overflow.
3259
3260 2011-06-22 Leo Liu <sdl.web@gmail.com>
3261
3262 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3263 Move to minibuffer.el.
3264
3265 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3266
3267 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
3268 The following patches are for when GLYPH_DEBUG && !XASSERT.
3269 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3270 * dispnew.c (flush_stdout):
3271 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3272 Mark as externally visible.
3273 * dispnew.c (check_window_matrix_pointers): Now static.
3274 * dispnew.c (window_to_frame_vpos):
3275 * xfns.c (unwind_create_frame):
3276 * xterm.c (x_check_font): Remove unused local.
3277 * scroll.c (CHECK_BOUNDS):
3278 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3279 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3280 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3281 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3282 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3283 Now static.
3284 (debug_method_add): Use va_list and vsprintf rather than relying
3285 on undefined behavior with wrong number of arguments.
3286 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3287 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3288 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3289 since we're not interested in debugging glyphs with old libraries.
3290 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3291 GCC 4.6.0's static checking.
3292
3293 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3294
3295 Integer overflow and signedness fixes (Bug#8873).
3296 A few related buffer overrun fixes, too.
3297
3298 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3299
3300 * dispextern.h (struct face.stipple):
3301 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3302 (x_bitmap_mask, x_allocate_bitmap_record)
3303 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3304 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3305 (x_create_bitmap_from_xpm_data):
3306 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3307 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3308 (.bitmaps_last):
3309 * xfaces.c (load_pixmap):
3310 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3311 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3312 (.bitmaps_last, struct x_output.icon_bitmap):
3313 Use ptrdiff_t, not int, for bitmap indexes.
3314 (x_allocate_bitmap_record): Check for size overflow.
3315 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3316
3317 Use ptrdiff_t, not int, for overlay counts.
3318 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3319 * editfns.c (overlays_around, get_pos_property):
3320 * textprop.c (get_char_property_and_overlay):
3321 * xdisp.c (next_overlay_change, note_mouse_highlight):
3322 * xfaces.c (face_at_buffer_position):
3323 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3324 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3325 (Fnext_overlay_change, Fprevious_overlay_change)
3326 (mouse_face_overlay_overlaps, Foverlays_in):
3327 Use ptrdiff_t, not int, for sizes.
3328 (overlays_at, overlays_in): Check for size-calculation overflow.
3329
3330 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3331
3332 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3333 (x_session_initialize): Do not assume string length fits in int.
3334
3335 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3336 This is unlikely, but can occur if DPI is outlandish.
3337
3338 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3339 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3340
3341 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3342 * xrdb.c (magic_file_p, search_magic_path):
3343 Omit last arg SUFFIX; it was always 0. All callers changed.
3344 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3345
3346 * xfont.c (xfont_match): Avoid need for strlen.
3347
3348 * xfns.c: Don't assume strlen fits in int.
3349 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3350
3351 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3352 not unsigned long, as we prefer signed integers. All callers changed.
3353 Detect integer overflow in repeat count.
3354 (message_dolog): Don't assume print length fits in 39 bytes.
3355 (display_mode_element): Don't assume strlen fits in int.
3356
3357 * termcap.c: Don't assume sizes fit in int and never overflow.
3358 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3359 (gobble_line): Check for size-calculation overflow.
3360
3361 * minibuf.c (Fread_buffer):
3362 * lread.c (intern, intern_c_string):
3363 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3364 Don't assume string length fits in int.
3365
3366 * keyboard.c (parse_tool_bar_item):
3367 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3368
3369 * font.c: Don't assume string length fits in int.
3370 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3371 Use ptrdiff_t, not int.
3372 (font_intern_prop): Don't assume string length fits in int.
3373 Don't assume integer property fits in fixnum.
3374 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3375
3376 * filelock.c: Fix some buffer overrun and integer overflow issues.
3377 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3378 Reformulate so as not to need the command string.
3379 Invoke gzip -cd rather than gunzip, as it's more portable.
3380 (lock_info_type, lock_file_1, lock_file):
3381 Don't assume pid_t and time_t fit in unsigned long.
3382 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3383 (current_lock_owner): Prefer signed type for sizes.
3384 Use memcpy, not strncpy, where memcpy is what is really wanted.
3385 Don't assume (via atoi) that time_t and pid_t fit in int.
3386 Check for time_t and/or pid_t out of range, e.g., via a network share.
3387 Don't alloca where an auto var works fine.
3388
3389 * fileio.c: Fix some integer overflow issues.
3390 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3391 Don't assume string length fits in int.
3392 (directory_file_name): Don't assume string length fits in long.
3393 (make_temp_name): Don't assume pid fits in int, or that its print
3394 length is less than 20.
3395
3396 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3397
3398 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3399
3400 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3401
3402 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3403 We prefer signed integers, even for size calculations.
3404
3405 * emacs.c: Don't assume string length fits in 'int'.
3406 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3407 (main): Don't invoke strlen when not needed.
3408
3409 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3410 (XD_DEBUG_MESSAGE): Don't waste a byte.
3411
3412 * callproc.c (getenv_internal_1, getenv_internal)
3413 (Fgetenv_internal):
3414 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3415
3416 * lread.c (invalid_syntax): Omit length argument.
3417 All uses changed. This doesn't fix a bug, but it simplifies the
3418 code away from its former Hollerith-constant appearance, and it's
3419 one less 'int' to worry about when looking at integer-overflow issues.
3420 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3421
3422 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3423 This didn't break anything, but it didn't help either.
3424 It's confusing to put a bogus integer in a place where the actual
3425 value does not matter.
3426 (LIST_END_P): Remove unused macro and its bogus comment.
3427 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3428
3429 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3430 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3431 implementation.
3432 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3433 We prefer signed types, and the value cannot exceed the EMACS_INT
3434 range anyway (because otherwise the length would not be representable).
3435 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3436 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3437 This avoids a GCC warning when WIDE_EMACS_INT.
3438
3439 * indent.c (sane_tab_width): New function.
3440 (current_column, scan_for_column, Findent_to, position_indentation)
3441 (compute_motion): Use it. This is just for clarity.
3442 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3443
3444 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3445
3446 * lisp.h (lint_assume): New macro.
3447 * composite.c (composition_gstring_put_cache):
3448 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3449
3450 * editfns.c, insdel.c:
3451 Omit unnecessary forward decls, to simplify future changes.
3452
3453 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3454
3455 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3456
3457 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3458 Use much-faster test for byte-length change.
3459 Don't assume string byte-length fits in 'int'.
3460 Check that character arg fits in 'int'.
3461 (mapcar1): Declare byte as byte, for clarity.
3462
3463 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3464
3465 * fns.c (concat): Catch string overflow earlier.
3466 Do not rely on integer wraparound.
3467
3468 * dispextern.h (struct it.overlay_strings_charpos)
3469 (struct it.selective): Now EMACS_INT, not int.
3470 * xdisp.c (forward_to_next_line_start)
3471 (back_to_previous_visible_line_start)
3472 (reseat_at_next_visible_line_start, next_element_from_buffer):
3473 Don't arbitrarily truncate the value of 'selective' to int.
3474
3475 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3476
3477 * composite.c: Don't truncate sizes to 'int'.
3478 (composition_gstring_p, composition_reseat_it)
3479 (composition_adjust_point): Use EMACS_INT, not int.
3480 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3481 not EMACS_UINT, for indexes.
3482
3483 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3484
3485 * buffer.c: Include <verify.h>.
3486 (struct sortvec.priority, struct sortstr.priority):
3487 Now EMACS_INT, not int.
3488 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3489 (struct sortstr.size, record_overlay_string)
3490 (struct sortstrlist.size, struct sortlist.used):
3491 Don't truncate size to int.
3492 (record_overlay_string): Check for size-calculation overflow.
3493 (init_buffer_once): Check at compile-time, not run-time.
3494
3495 2011-06-22 Jim Meyering <meyering@redhat.com>
3496
3497 Don't leak an XBM-image-sized buffer
3498 * image.c (xbm_load): Free the image buffer after using it.
3499
3500 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3501
3502 Port to Sun C.
3503 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3504 that Sun C diagnosed.
3505 * fns.c (secure_hash): Fix pointer signedness issue.
3506 * intervals.c (static_offset_intervals): New function.
3507 (offset_intervals): Use it.
3508
3509 2011-06-21 Leo Liu <sdl.web@gmail.com>
3510
3511 * deps.mk (fns.o):
3512 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3513 sha512.h.
3514
3515 * fns.c (secure_hash): Rename from crypto_hash_function and change
3516 the first arg to accept symbols.
3517 (Fsecure_hash): New primitive.
3518 (syms_of_fns): New symbols.
3519
3520 2011-06-20 Deniz Dogan <deniz@dogan.se>
3521
3522 * process.c (Fset_process_buffer): Clarify return value in
3523 docstring.
3524
3525 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3526
3527 * dispnew.c (add_window_display_history): Use BVAR.
3528
3529 * xdisp.c (debug_method_add): Use BVAR.
3530 (check_window_end, dump_glyph_matrix, dump_glyph)
3531 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3532
3533 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3534 Likewise.
3535
3536 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3537 check till after the cache is created in init_frame_faces.
3538
3539 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3540
3541 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3542
3543 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3544
3545 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3546 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3547 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3548
3549 Improve buffer-overflow checking (Bug#8873).
3550 * fileio.c (Finsert_file_contents):
3551 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3552 Remove the old (too-loose) buffer overflow checks.
3553 They weren't needed, since make_gap checks for buffer overflow.
3554 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3555 The old code merely checked for Emacs fixnum overflow, and relied
3556 on undefined (wraparound) behavior. The new code avoids undefined
3557 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3558
3559 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3560 Tune. Don't use wider integers than needed. Don't use alloca.
3561 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3562
3563 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3564
3565 * insdel.c, lisp.h (buffer_overflow): New function.
3566 (insert_from_buffer_1, replace_range, replace_range_2):
3567 * insdel.c (make_gap_larger):
3568 * editfns.c (Finsert_char):
3569 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3570
3571 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3572
3573 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3574
3575 Integer overflow and signedness fixes (Bug#8873).
3576
3577 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3578 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3579
3580 * fileio.c: Don't assume EMACS_INT fits in off_t.
3581 (emacs_lseek): New static function.
3582 (Finsert_file_contents, Fwrite_region): Use it.
3583 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3584
3585 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3586
3587 * fns.c: Don't overflow int when computing a list length.
3588 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3589 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3590 truncation on 64-bit hosts. Check for QUIT every
3591 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3592 faster and is responsive enough.
3593 (Flength): Report an error instead of overflowing an integer.
3594 (Fsafe_length): Return a float if the value is not representable
3595 as a fixnum. This shouldn't happen except in contrived situations.
3596 (Fnthcdr, Fsort): Don't assume list length fits in int.
3597 (Fcopy_sequence): Don't assume vector length fits in int.
3598
3599 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3600 (header_size, word_size): New constants.
3601 (allocate_vectorlike): Don't check size overflow here.
3602 (allocate_vector): Check it here instead, since this is the only
3603 caller of allocate_vectorlike that could cause overflow.
3604 Check that the new vector's length is representable as a fixnum.
3605
3606 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3607 The previous code was bogus. For example, next_almost_prime (32)
3608 returned 39, which is undesirable as it is a multiple of 3; and
3609 next_almost_prime (24) returned 25, which is a multiple of 5 so
3610 why was the code bothering to check for multiples of 7?
3611
3612 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3613
3614 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3615
3616 Variadic C functions now count arguments with ptrdiff_t.
3617 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3618 Back then I didn't know that the Emacs coding style prefers signed int.
3619 Also, in the meantime I found a few more instances where arguments
3620 were being counted with int, which may truncate counts on 64-bit
3621 machines, or EMACS_INT, which may be unnecessarily wide.
3622 * lisp.h (struct Lisp_Subr.function.aMANY)
3623 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3624 Arg counts are now ptrdiff_t, not size_t.
3625 All variadic functions and their callers changed accordingly.
3626 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3627 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3628 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3629 * callint.c (Fcall_interactively): Check arg count for overflow,
3630 to avoid potential buffer overrun. Use signed char, not 'int',
3631 for 'varies' array, so that we needn't bother to check its size
3632 calculation for overflow.
3633 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3634 * eval.c (apply_lambda):
3635 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3636 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3637 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3638
3639 * callint.c (Fcall_interactively): Don't use index var as event count.
3640
3641 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3642 * mem-limits.h (SIZE): Remove; no longer used.
3643
3644 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3645
3646 Remove unnecessary casts.
3647 * xterm.c (x_term_init):
3648 * xfns.c (x_set_border_pixel):
3649 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3650 These aren't needed now that we assume ANSI C.
3651
3652 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3653 It's more likely to cause problems (due to unsigned overflow)
3654 than to cure them.
3655
3656 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3657
3658 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3659
3660 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3661
3662 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3663
3664 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3665
3666 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3667
3668 GLYPH_CODE_FACE returns EMACS_INT, not int.
3669 * dispextern.h (merge_faces):
3670 * xfaces.c (merge_faces):
3671 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3672 Don't assume EMACS_INT fits in int.
3673
3674 * character.h (CHAR_VALID_P): Remove unused parameter.
3675 * fontset.c, lisp.h, xdisp.c: All uses changed.
3676
3677 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3678
3679 * fns.c (concat): Minor tuning based on overflow analysis.
3680 This doesn't fix any bugs. Use int to hold character, instead
3681 of constantly refetching from Emacs object. Use XFASTINT, not
3682 XINT, for value known to be a character. Don't bother comparing
3683 a single byte to 0400, as it's always less.
3684
3685 * floatfns.c (Fexpt):
3686 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3687
3688 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3689 for characters.
3690
3691 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3692
3693 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3694 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3695 incorrectly succeed when S was a string, because 4294967386 was
3696 truncated before it was used.
3697
3698 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3699 Otherwise, an out-of-range integer could cause undefined behavior
3700 on a 64-bit host.
3701
3702 * composite.c: Use int, not EMACS_INT, for characters.
3703 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3704 EMACS_INT, for values that are known to be in character range.
3705 This doesn't fix any bugs but is the usual style inside Emacs and
3706 may generate better code on 32-bit machines.
3707
3708 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3709 This is for reasons similar to the recent CHAR_STRING fix.
3710 * charset.c (Fencode_char): Check that character arg is actually
3711 a character. Pass an int to ENCODE_CHAR.
3712 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3713 wider than 'int', as a compile-time check to prevent future regressions
3714 in this area.
3715
3716 * character.c (char_string): Remove unnecessary casts.
3717
3718 Make sure a 64-bit char is never passed to CHAR_STRING.
3719 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3720 by silently ignoring the top 32 bits, allowing some values
3721 that were far too large to be valid characters.
3722 * character.h: Include <verify.h>.
3723 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3724 arguments are no wider than unsigned, as a compile-time check
3725 to prevent future regressions in this area.
3726 * data.c (Faset):
3727 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3728 (Fsubst_char_in_region):
3729 * fns.c (concat):
3730 * xdisp.c (decode_mode_spec_coding):
3731 Adjust to CHAR_STRING's new requirement.
3732 * editfns.c (Finsert_char, Fsubst_char_in_region):
3733 * fns.c (concat): Check that character args are actually
3734 characters. Without this test, these functions did the wrong
3735 thing with wildly out-of-range values on 64-bit hosts.
3736
3737 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3738 These casts should not be needed on 32-bit hosts, either.
3739 * keyboard.c (read_char):
3740 * lread.c (Fload): Remove casts to unsigned.
3741
3742 * lisp.h (UNSIGNED_CMP): New macro.
3743 This fixes comparison bugs on 64-bit hosts.
3744 (ASCII_CHAR_P): Use it.
3745 * casefiddle.c (casify_object):
3746 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3747 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3748 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3749 * dispextern.h (FACE_FROM_ID):
3750 * keyboard.c (read_char): Use UNSIGNED_CMP.
3751
3752 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3753 not to EMACS_INT, to avoid GCC warning.
3754
3755 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3756
3757 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3758 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3759 isn't needed on 32-bit machines.
3760
3761 * buffer.c (Fgenerate_new_buffer_name):
3762 Use EMACS_INT for count, not int.
3763 (advance_to_char_boundary): Return EMACS_INT, not int.
3764
3765 * data.c (Qcompiled_function): Now static.
3766
3767 * window.c (window_body_lines): Now static.
3768
3769 * image.c (gif_load): Rename local to avoid shadowing.
3770
3771 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3772 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3773 * alloc.c (make_save_value): Integer argument is now of type
3774 ptrdiff_t, not int.
3775 (mark_object): Use ptrdiff_t, not int.
3776 * lisp.h (pD): New macro.
3777 * print.c (print_object): Use it.
3778
3779 * alloc.c: Use EMACS_INT, not int, to count objects.
3780 (total_conses, total_markers, total_symbols, total_vector_size)
3781 (total_free_conses, total_free_markers, total_free_symbols)
3782 (total_free_floats, total_floats, total_free_intervals)
3783 (total_intervals, total_strings, total_free_strings):
3784 Now EMACS_INT, not int. All uses changed.
3785 (Fgarbage_collect): Compute overall total using a double, so that
3786 integer overflow is less likely to be a problem. Check for overflow
3787 when converting back to an integer.
3788 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3789 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3790 These were 'int' variables that could overflow on 64-bit hosts;
3791 they were never used, so remove them instead of repairing them.
3792 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3793 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3794 Previously, this ceilinged at INT_MAX, but that doesn't work on
3795 64-bit machines.
3796 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3797
3798 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3799 (allocate_vectorlike): Check for ptrdiff_t overflow.
3800 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3801 when a (possibly-narrower) signed value would do just as well.
3802 We prefer using signed arithmetic, to avoid comparison confusion.
3803
3804 * alloc.c: Catch some string size overflows that we were missing.
3805 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3806 for convenience in STRING_BYTES_MAX.
3807 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3808 The definition here is exact; the one in lisp.h was approximate.
3809 (allocate_string_data): Check for string overflow. This catches
3810 some instances we weren't catching before. Also, it catches
3811 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3812 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3813 and ptrdiff_t and EMACS_INT are both 64 bits.
3814
3815 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3816 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3817 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3818
3819 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3820
3821 * alloc.c (Fmake_string): Check for out-of-range init.
3822
3823 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3824
3825 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3826
3827 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3828
3829 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3830 xg_get_default_scrollbar_width.
3831
3832 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3833 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3834 (style_changed_cb): Call update_theme_scrollbar_width and call
3835 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3836 all frames (Bug#8505).
3837 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3838 Call gtk_window_set_resizable if HAVE_GTK3.
3839 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3840 and height if HAVE_GTK3 (Bug#8505).
3841 (scroll_bar_width_for_theme): New variable.
3842 (update_theme_scrollbar_width): New function.
3843 (xg_get_default_scrollbar_width): Move code to
3844 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3845 (xg_initialize): Call update_theme_scrollbar_width.
3846
3847 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3848
3849 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3850
3851 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3852
3853 * frame.c (make_frame): Call other_buffer_safely instead of
3854 other_buffer.
3855
3856 * window.c (temp_output_buffer_show): Call display_buffer with
3857 second argument Vtemp_buffer_show_specifiers and reset latter
3858 immediately after the call.
3859 (Vtemp_buffer_show_specifiers): New variable.
3860 (auto_window_vscroll_p, next_screen_context_lines)
3861 (Vscroll_preserve_screen_position): Remove leading asterisks from
3862 doc-strings.
3863
3864 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3865
3866 Fix minor problems found by GCC 4.6.0 static checking.
3867 * buffer.c (Qclone_number): Remove for now, as it's unused.
3868 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3869 (record_buffer): Remove unused local.
3870 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3871 (set_frame_buffer_list): Remove; unused.
3872 * frame.h (other_visible_frames): Remove decl.
3873 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3874 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3875 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3876 if HAVE_GPM.
3877 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3878 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3879 Define only if HAVE_GPM.
3880 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3881 (update_hints_inhibit): Remove; never set. All uses removed.
3882 * widgetprv.h (emacsFrameClassRec): Remove decl.
3883 * window.c (delete_deletable_window): Now returns void, since it
3884 wasn't returning anything.
3885 (compare_window_configurations): Remove unused locals.
3886 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3887 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3888 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3889 the same widths as pointers. This follows up on the 2011-05-06 patch.
3890 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3891 * xterm.h: Likewise.
3892 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3893
3894 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3895
3896 * makefile.w32-in: Update dependencies.
3897 (LISP_H): Add lib/intprops.h.
3898
3899 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3900
3901 * image.c (gif_load): Add animation frame delay to the metadata.
3902 (syms_of_image): Use DEFSYM. New symbol `delay'.
3903
3904 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3905
3906 * window.c (delete_deletable_window): Re-add.
3907 (Fset_window_configuration): Rewrite to handle dead buffers and
3908 consequently deletable windows.
3909 (window_tree, Fwindow_tree): Remove. Supply functionality in
3910 window.el.
3911 (compare_window_configurations): Simplify code.
3912
3913 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3914
3915 * image.c (imagemagick_load_image): Fix type mismatch.
3916 (Fimagemagick_types): Likewise.
3917
3918 * window.h (replace_buffer_in_windows): Declare.
3919
3920 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3921
3922 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3923 Qclone_number. Remove external declaration of Qdelete_window.
3924 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3925 code.
3926 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3927 Run Qbuffer_list_update_hook if allowed.
3928 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3929 buffer list implementation.
3930 (other_buffer_safely): New function.
3931 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3932 calls to replace_buffer_in_windows and
3933 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3934 if allowed.
3935 (record_buffer): Inhibit quitting and rewrite using quittable
3936 functions. Run Qbuffer_list_update_hook if allowed.
3937 (Frecord_buffer, Funrecord_buffer): New functions.
3938 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3939 Move switch-to-buffer to window.el.
3940 (bury-buffer): Move to window.el.
3941 (Vbuffer_list_update_hook): New variable.
3942
3943 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3944 section.
3945
3946 * window.h (resize_frame_windows): Move up in code.
3947 (Fwindow_frame): Remove EXFUN.
3948 (replace_buffer_in_all_windows): Remove prototype.
3949 (replace_buffer_in_windows_safely): Add prototype.
3950
3951 * window.c: Declare Qdelete_window static again. Move down
3952 declaration of select_count.
3953 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3954 (Fother_window): Move to window.el.
3955 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3956 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3957 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3958 window.el.
3959 (replace_buffer_in_windows): Implement by calling
3960 Qreplace_buffer_in_windows.
3961 (replace_buffer_in_all_windows): Remove with some functionality
3962 moved into replace_buffer_in_windows_safely.
3963 (replace_buffer_in_windows_safely): New function.
3964 (select_window_norecord, select_frame_norecord): Move in front
3965 of run_window_configuration_change_hook. Remove now obsolete
3966 declarations.
3967 (Fset_window_buffer): Rewrite doc-string.
3968 Call Qrecord_window_buffer.
3969 (keys_of_window): Move binding for other-window to window.el.
3970
3971 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3972
3973 * dispextern.h (struct image): Replace data member, whose int_val
3974 and ptr_val fields were not used by anything, with a single
3975 lisp_val object.
3976
3977 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3978 (gif_clear_image, gif_load, imagemagick_load_image)
3979 (gs_clear_image, gs_load): Callers changed.
3980
3981 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3982
3983 * buffer.h: Include <time.h>, for time_t.
3984 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3985
3986 Fix minor problems found by static checking.
3987
3988 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3989
3990 Make identifiers static if they are not used in other modules.
3991 * data.c (Qcompiled_function, Qframe, Qvector):
3992 * image.c (QimageMagick, Qsvg):
3993 * minibuf.c (Qmetadata):
3994 * window.c (resize_window_check, resize_root_window): Now static.
3995 * window.h (resize_window_check, resize_root_window): Remove decls.
3996
3997 * window.c (window_deletion_count, delete_deletable_window):
3998 Remove; unused.
3999 (window_body_lines): Now static.
4000 (Fdelete_other_windows_internal): Mark vars as initialized.
4001 Make sure 'resize_failed' is initialized.
4002 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4003 (resize_window_apply): Remove unused local.
4004 * window.h (delete_deletable_window): Remove decl.
4005
4006 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4007 (imagemagick_load_image): Fix pointer signedness problem by changing
4008 last arg from unsigned char * to char *. All uses changed.
4009 Also, fix a local for similar reasons.
4010 Remove unused locals. Remove locals to avoid shadowing.
4011 (fn_rsvg_handle_free): Remove; unused.
4012 (svg_load, svg_load_image): Fix pointer signedness problem.
4013 (imagemagick_load_image): Don't use garbage pointer image_wand.
4014
4015 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4016
4017 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
4018
4019 * image.c (gif_load): Fix omitted cast error introduced by
4020 2011-06-06 change.
4021
4022 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4023
4024 * window.h (resize_proportionally, orig_total_lines)
4025 (orig_top_line): Remove from window structure.
4026 (set_window_height, set_window_width, change_window_heights)
4027 (Fdelete_window): Remove prototypes.
4028 (resize_frame_windows): Remove duplicate declaration.
4029
4030 2011-06-10 Eli Zaretskii <eliz@gnu.org>
4031
4032 * window.h (resize_frame_windows, resize_window_check)
4033 (delete_deletable_window, resize_root_window)
4034 (resize_frame_windows): Declare prototypes.
4035
4036 * window.c (resize_window_apply): Make definition be "static" to
4037 match the prototype.
4038
4039 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4040
4041 * window.c: Remove declarations of Qwindow_size_fixed,
4042 window_min_size_1, window_min_size_2, window_min_size,
4043 size_window, window_fixed_size_p, enlarge_window, delete_window.
4044 Remove static from declaration of Qdelete_window, it's
4045 temporarily needed by Fbury_buffer.
4046 (replace_window): Don't assign orig_top_line and
4047 orig_total_lines.
4048 (Fdelete_window, delete_window): Remove. Window deletion is
4049 handled by window.el.
4050 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4051 Replace Fdelete_window calls with calls to Qdelete_window.
4052 (Fdelete_other_windows): Remove. Deleting other windows is
4053 handled by window.el.
4054 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4055 handled in window.el.
4056 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4057 Window minimum sizes are handled in window.el.
4058 (shrink_windows, size_window, set_window_height)
4059 (set_window_width, change_window_heights, window_height)
4060 (window_width, CURBEG, CURSIZE, enlarge_window)
4061 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4062 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4063 handled in window.el.
4064 (make_dummy_parent): Rename to make_parent_window and give it a
4065 second argument horflag.
4066 (make_window): Don't set resize_proportionally any more.
4067 (Fsplit_window): Remove. Windows are split in window.el.
4068 (save_restore_action, save_restore_orig_size)
4069 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4070 Resize mini windows in window.el.
4071 (grow_mini_window, shrink_mini_window): Implement by calling
4072 Qresize_root_window_vertically, resize_window_check and
4073 resize_window_apply.
4074 (saved_window, Fset_window_configuration, save_window_save):
4075 Do not handle orig_top_line, orig_total_lines, and
4076 resize_proportionally.
4077 (window_min_height, window_min_width): Move to window.el.
4078 (keys_of_window): Move bindings for delete-other-windows,
4079 split-window, delete-window and enlarge-window to window.el.
4080
4081 * buffer.c: Temporarily extern Qdelete_window.
4082 (Fbury_buffer): Temporarily call Qdelete_window instead of
4083 Fdelete_window (Fbury_buffer will move to window.el soon).
4084
4085 * frame.c (set_menu_bar_lines_1): Remove code handling
4086 orig_top_line and orig_total_lines.
4087
4088 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4089 set_window_height but set heights directly.
4090 (change_frame_size_1): Use resize_frame_windows.
4091
4092 * xdisp.c (init_xdisp): Don't use set_window_height but set
4093 heights directly.
4094
4095 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4096 Use resize_frame_windows instead of change_window_heights and run
4097 run_window_configuration_change_hook.
4098
4099 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4100 instead of change_window_heights and run
4101 run_window_configuration_change_hook.
4102
4103 2011-06-09 Martin Rudalics <rudalics@gmx.at>
4104
4105 * window.c (replace_window): Rename second argument REPLACEMENT to
4106 NEW. New third argument SETFLAG. Rewrite.
4107 (delete_window, make_dummy_parent): Call replace_window with
4108 third argument 1.
4109 (window_list_1): Move down in code.
4110 (run_window_configuration_change_hook): Move set_buffer part
4111 before select_frame_norecord part in order to unwind correctly.
4112 Rename count1 to count.
4113 (recombine_windows, delete_deletable_window, resize_root_window)
4114 (Fdelete_other_windows_internal)
4115 (Frun_window_configuration_change_hook, make_parent_window)
4116 (resize_window_check, resize_window_apply, Fresize_window_apply)
4117 (resize_frame_windows, Fsplit_window_internal)
4118 (Fdelete_window_internal, Fresize_mini_window_internal):
4119 New functions.
4120 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4121
4122 2011-06-08 Martin Rudalics <rudalics@gmx.at>
4123
4124 * window.h (window): Add some new members to window structure -
4125 normal_lines, normal_cols, new_total, new_normal, clone_number,
4126 splits, nest, prev_buffers, next_buffers.
4127 (WINDOW_TOTAL_SIZE): Move here from window.c.
4128 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
4129
4130 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4131 Remove.
4132 (make_dummy_parent): Set new members of windows structure.
4133 (make_window): Move down in code. Handle new members of window
4134 structure.
4135 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4136 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4137 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4138 (Fset_window_prev_buffers, Fwindow_next_buffers)
4139 (Fset_window_next_buffers, Fset_window_clone_number):
4140 New functions.
4141 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4142 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4143 Doc-string fixes.
4144 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4145 Argument WINDOW can be now internal window too.
4146 (Fwindow_use_time): Move up in code.
4147 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4148 Rewrite doc-string.
4149 (Fset_window_configuration, saved_window)
4150 (Fcurrent_window_configuration, save_window_save): Handle new
4151 members of window structure.
4152 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4153 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4154 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4155 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4156 Qget_mru_window, Qresize_root_window,
4157 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4158 Qauto_buffer_name; staticpro them.
4159
4160 2011-06-07 Martin Rudalics <rudalics@gmx.at>
4161
4162 * window.c (Fwindow_total_size, Fwindow_left_column)
4163 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4164 (Fwindow_list_1): New functions.
4165 (window_box_text_cols): Replace with window_body_cols.
4166 (Fwindow_width, Fscroll_left, Fscroll_right):
4167 Use window_body_cols instead of window_box_text_cols.
4168 (delete_window, Fset_window_configuration):
4169 Call delete_all_subwindows with window as argument.
4170 (delete_all_subwindows): Take a window as argument and not a
4171 structure. Rewrite.
4172 (window_loop): Remove handling of GET_LRU_WINDOW and
4173 GET_LARGEST_WINDOW.
4174 (Fget_lru_window, Fget_largest_window): Move to window.el.
4175
4176 * window.h: Extern window_body_cols instead of
4177 window_box_text_cols. delete_all_subwindows now takes a
4178 Lisp_Object as argument.
4179
4180 * indent.c (compute_motion, Fcompute_motion):
4181 Use window_body_cols instead of window_box_text_cols.
4182
4183 * frame.c (delete_frame): Call delete_all_subwindows with root
4184 window as argument.
4185
4186 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4187
4188 * fns.c (Fputhash): Document return value.
4189
4190 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
4191
4192 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4193
4194 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4195
4196 Cons<->int and similar integer overflow fixes (Bug#8794).
4197
4198 Check for overflow when converting integer to cons and back.
4199 * charset.c (Fdefine_charset_internal, Fdecode_char):
4200 Use cons_to_unsigned to catch overflow.
4201 (Fencode_char): Use INTEGER_TO_CONS.
4202 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4203 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4204 * data.c (long_to_cons, cons_to_long): Remove.
4205 (cons_to_unsigned, cons_to_signed): New functions.
4206 These signal an error for invalid or out-of-range values.
4207 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4208 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4209 * font.c (Ffont_variation_glyphs):
4210 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4211 * lisp.h: Include <intprops.h>.
4212 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4213 (cons_to_signed, cons_to_unsigned): New decls.
4214 (long_to_cons, cons_to_long): Remove decls.
4215 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4216 (Fprimitive_undo): Use CONS_TO_INTEGER.
4217 * xfns.c (Fx_window_property): Likewise.
4218 * xselect.c: Include <limits.h>.
4219 (x_own_selection, selection_data_to_lisp_data):
4220 Use INTEGER_TO_CONS.
4221 (x_handle_selection_request, x_handle_selection_clear)
4222 (x_get_foreign_selection, Fx_disown_selection_internal)
4223 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4224 (lisp_data_to_selection_data): Use cons_to_unsigned.
4225 (x_fill_property_data): Use cons_to_signed.
4226 Report values out of range.
4227
4228 Check for buffer and string overflow more precisely.
4229 * buffer.h (BUF_BYTES_MAX): New macro.
4230 * lisp.h (STRING_BYTES_MAX): New macro.
4231 * alloc.c (Fmake_string):
4232 * character.c (string_escape_byte8):
4233 * coding.c (coding_alloc_by_realloc):
4234 * doprnt.c (doprnt):
4235 * editfns.c (Fformat):
4236 * eval.c (verror):
4237 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4238 since they may not be the same number.
4239 * editfns.c (Finsert_char):
4240 * fileio.c (Finsert_file_contents):
4241 Likewise for BUF_BYTES_MAX.
4242
4243 * image.c: Use ptrdiff_t, not int, for sizes.
4244 (slurp_file): Switch from int to ptrdiff_t.
4245 All uses changed.
4246 (slurp_file): Check that file size fits in both size_t (for
4247 malloc) and ptrdiff_t (for sanity and safety).
4248
4249 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4250 if b->modtime has its maximal value.
4251
4252 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4253
4254 Don't assume time_t can fit into int.
4255 * buffer.h (struct buffer.modtime): Now time_t, not int.
4256 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4257 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4258
4259 Minor fixes for signed vs unsigned integers.
4260 * character.h (MAYBE_UNIFY_CHAR):
4261 * charset.c (maybe_unify_char):
4262 * keyboard.c (read_char, reorder_modifiers):
4263 XINT -> XFASTINT, since the integer must be nonnegative.
4264 * ftfont.c (ftfont_spec_pattern):
4265 * keymap.c (access_keymap, silly_event_symbol_error):
4266 XUINT -> XFASTINT, since the integer must be nonnegative.
4267 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4268 since it makes no difference and we prefer signed.
4269 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4270 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4271 nonnegative.
4272
4273 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4274
4275 * window.h (Fwindow_frame): Declare.
4276
4277 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4278
4279 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4280 (SPARE_MEMORY): Always define.
4281 (LARGE_REQUEST): Remove.
4282 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4283
4284 2011-06-06 Martin Rudalics <rudalics@gmx.at>
4285
4286 * lisp.h: Move EXFUNS for Fframe_root_window,
4287 Fframe_first_window and Fset_frame_selected_window to window.h.
4288
4289 * window.h: Move EXFUNS for Fframe_root_window,
4290 Fframe_first_window and Fset_frame_selected_window here from
4291 lisp.h.
4292
4293 * frame.c (Fwindow_frame, Fframe_first_window)
4294 (Fframe_root_window, Fframe_selected_window)
4295 (Fset_frame_selected_window): Move to window.c.
4296 (Factive_minibuffer_window): Move to minibuf.c.
4297 (Fother_visible_frames_p): New function.
4298
4299 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4300
4301 * window.c (decode_window, decode_any_window): Move up in code.
4302 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4303 (inhibit_frame_unsplittable): Remove unused variable.
4304 (Fwindow_buffer): Move up and rewrite doc-string.
4305 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4306 (Fwindow_prev): New functions.
4307 (Fwindow_frame): Move here from frame.c. Accept any window as
4308 argument.
4309 (Fframe_root_window, Fframe_first_window)
4310 (Fframe_selected_window): Move here from frame.c. Accept frame
4311 or arbitrary window as argument. Update doc-strings.
4312 (Fminibuffer_window): Move up in code.
4313 (Fwindow_minibuffer_p): Move up in code and simplify.
4314 (Fset_frame_selected_window): Move here from frame.c.
4315 Marginal rewrite.
4316 (Fselected_window, select_window, Fselect_window): Move up in
4317 code. Minor doc-string fixes.
4318
4319 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4320
4321 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4322 Do not assume that spare memory exists; that assumption is valid
4323 only if SYSTEM_MALLOC.
4324 (LARGE_REQUEST): New macro, so that the issue of large requests
4325 is separated from the issue of spare memory.
4326
4327 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4328
4329 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4330 format. (Bug#8806)
4331
4332 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4333
4334 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4335 before statements.
4336
4337 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4338
4339 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4340
4341 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4342
4343 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4344 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4345
4346 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
4347
4348 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4349
4350 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
4351
4352 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4353 (x_clipboard_manager_save): Add return value.
4354 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4355 New error handlers.
4356 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4357 Obey Vx_select_enable_clipboard_manager. Catch errors in
4358 x_clipboard_manager_save (Bug#8779).
4359 (Vx_select_enable_clipboard_manager): New variable.
4360 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4361
4362 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4363
4364 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4365
4366 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4367
4368 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4369 in the current matrix if keep_current_p is non-zero.
4370
4371 2011-06-04 Eli Zaretskii <eliz@gnu.org>
4372
4373 * bidi.c (bidi_level_of_next_char): Fix last change.
4374
4375 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4376
4377 Support bidi reordering of text covered by display properties.
4378
4379 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4380 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4381 (bidi_cache_search, bidi_cache_iterator_state)
4382 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4383 (bidi_level_of_next_char, bidi_move_to_visually_next):
4384 Support character positions inside a run of characters covered by a
4385 display string.
4386 (bidi_paragraph_init, bidi_resolve_explicit_1)
4387 (bidi_level_of_next_char): Call bidi_fetch_char and
4388 bidi_fetch_char_advance instead of FETCH_CHAR and
4389 FETCH_CHAR_ADVANCE.
4390 (bidi_init_it): Initialize new members.
4391 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4392 definitions.
4393 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4394 instead of using explicit *_CHAR codes.
4395 (bidi_resolve_explicit, bidi_resolve_weak):
4396 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4397 bidirectional text is supported only in multibyte buffers.
4398 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4399 it to initialize the frame_window_p member of struct bidi_it.
4400 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4401 (bidi_resolve_explicit, bidi_resolve_weak)
4402 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4403 bidi_it->nchars is non-positive.
4404 (bidi_level_of_next_char): Don't try to lookup the cache for the
4405 next/previous character if nothing is cached there yet, or if we
4406 were just reseat()'ed to a new position.
4407
4408 * xdisp.c (set_cursor_from_row): Set start and stop points
4409 according to the row's direction when priming the loop that looks
4410 for the glyph on which to display cursor.
4411 (single_display_spec_intangible_p): Function deleted.
4412 (display_prop_intangible_p): Reimplement to call
4413 handle_display_spec instead of single_display_spec_intangible_p.
4414 Accept 3 additional arguments needed by handle_display_spec.
4415 This fixes incorrect cursor motion across display property with complex
4416 values: lists, `(when COND...)' forms, etc.
4417 (single_display_spec_string_p): Support property values that are
4418 lists with the argument STRING its top-level element.
4419 (display_prop_string_p): Fix the condition for processing a
4420 property that is a list to be consistent with handle_display_spec.
4421 (handle_display_spec): New function, refactored from the
4422 last portion of handle_display_prop.
4423 (compute_display_string_pos): Accept additional argument
4424 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4425 value of a `display' property is a "replacing spec".
4426 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4427 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4428 the display property, but just return a value indicating whether
4429 the display property will replace the characters it covers.
4430 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4431 frame_window_p members of struct bidi_it.
4432 (compute_display_string_pos, compute_display_string_end):
4433 New functions.
4434 (push_it): Accept second argument POSITION, where pop_it should
4435 jump to continue iteration.
4436 (reseat_1): Initialize bidi_it.disp_pos.
4437
4438 * keyboard.c (adjust_point_for_property): Adjust the call to
4439 display_prop_intangible_p to its new signature.
4440
4441 * dispextern.h (struct bidi_it): New member frame_window_p.
4442 (bidi_init_it): Update prototypes.
4443 (display_prop_intangible_p): Update prototype.
4444 (compute_display_string_pos, compute_display_string_end):
4445 Declare prototypes.
4446 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4447 EMACS_INT.
4448
4449 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4450
4451 Malloc failure behavior now depends on size of allocation.
4452 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4453 * lisp.h: Change signatures accordingly.
4454 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4455 All callers changed. (Bug#8762)
4456
4457 * gnutls.c: Use Emacs's memory allocators.
4458 Without this change, the gnutls library would invoke malloc etc.
4459 directly, which causes problems on non-SYNC_INPUT hosts, and which
4460 runs afoul of improving memory_full behavior. (Bug#8761)
4461 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4462 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4463 xfree instead of the default malloc, realloc, free.
4464 (Fgnutls_boot): No need to check for memory allocation failure,
4465 since xmalloc does that for us.
4466
4467 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4468 * category.c (hash_get_category_set):
4469 * ccl.c (ccl_driver):
4470 * charset.c (Fdefine_charset_internal):
4471 * charset.h (struct charset.hash_index):
4472 * composite.c (get_composition_id, gstring_lookup_cache)
4473 (composition_gstring_put_cache):
4474 * composite.h (struct composition.hash_index):
4475 * dispextern.h (struct image.hash):
4476 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4477 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4478 (hashfn_equal, hashfn_user_defined, make_hash_table)
4479 (maybe_resize_hash_table, hash_lookup, hash_put)
4480 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4481 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4482 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4483 * image.c (make_image, search_image_cache, lookup_image)
4484 (xpm_put_color_table_h):
4485 * lisp.h (struct Lisp_Hash_Table):
4486 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4487 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4488 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4489 * alloc.c (allocate_vectorlike):
4490 Check for overflow in vector size calculations.
4491 * ccl.c (ccl_driver):
4492 Check for overflow when converting EMACS_INT to int.
4493 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4494 need to be updated by these changes.
4495 * fns.c (make_hash_table, maybe_resize_hash_table):
4496 Check for integer overflow with large hash tables.
4497 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4498 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4499 (SXHASH_REDUCE): New macro.
4500 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4501 Use it instead of discarding useful hash info with large hash values.
4502 (sxhash_float): New function.
4503 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4504 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4505 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4506 Rewrite to use FIXNUM_BITS, as this simplifies things.
4507 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4508 Adjust signatures to match updated version of code.
4509 (consing_since_gc): Now EMACS_INT, since a single hash table can
4510 use more than INT_MAX bytes.
4511
4512 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4513
4514 Make it possible to build with GCC-4.6+ -O2 -flto.
4515
4516 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4517
4518 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4519
4520 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4521 Call minibuffer-inactive-mode.
4522
4523 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4524
4525 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4526 Update dependencies.
4527
4528 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4529
4530 * data.c (init_data): Remove code for UTS, this system is not
4531 supported anymore.
4532
4533 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4534
4535 Don't force ./temacs to start in terminal mode.
4536
4537 * frame.c (make_initial_frame): Initialize faces in all cases, not
4538 only when CANNOT_DUMP is defined.
4539 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4540
4541 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4542
4543 * dispnew.c (add_window_display_history): Use const for the string
4544 pointer. Remove declaration, not needed.
4545
4546 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4547
4548 Use 'inline', not 'INLINE'.
4549 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4550 * alloc.c, fontset.c (INLINE): Remove.
4551 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4552 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4553 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4554 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4555 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4556
4557 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4558
4559 Make it possible to run ./temacs.
4560
4561 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4562 syms_of_callproc does the same thing. Remove test for
4563 "initialized", do it in the caller.
4564 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4565
4566 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4567
4568 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4569 (read_minibuf): Use get_minibuffer.
4570 (syms_of_minibuf): Use DEFSYM.
4571 (Qmetadata): New var.
4572 * data.c (Qbuffer): Don't make it static.
4573 (syms_of_data): Use DEFSYM.
4574
4575 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4576
4577 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4578 (CCL_CODE_MIN): New macro.
4579
4580 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4581
4582 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4583
4584 * eval.c (Qdebug): Now static.
4585 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4586 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4587 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4588
4589 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4590
4591 * image.c: Various fixes to ImageMagick code comments.
4592 (Fimagemagick_types): Doc fix.
4593
4594 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4595
4596 Minor fixes prompted by GCC 4.6.0 warnings.
4597
4598 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4599
4600 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4601 (x_clipboard_manager_save_all): Move extern decl to ...
4602 * xterm.h: ... here, so that it can be checked for consistency.
4603
4604 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4605
4606 * xselect.c (x_clipboard_manager_save_frame)
4607 (x_clipboard_manager_save_all): New functions.
4608 (Fx_clipboard_manager_save): Lisp function deleted.
4609
4610 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4611 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4612
4613 * xterm.h: Update prototype.
4614
4615 2011-05-28 William Xu <william.xwl@gmail.com>
4616
4617 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4618 exiting (Bug#8239).
4619
4620 2011-05-28 Jim Meyering <meyering@redhat.com>
4621
4622 Avoid a sign-extension bug in crypto_hash_function.
4623 * fns.c (to_uchar): Define.
4624 (crypto_hash_function): Use it to convert some newly-signed
4625 variables to unsigned, to avoid sign-extension bugs. For example,
4626 without this change, (md5 "truc") would evaluate to
4627 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4628 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4629 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4630
4631 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4632
4633 Integer overflow fixes.
4634
4635 * dbusbind.c: Serial number integer overflow fixes.
4636 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4637 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4638 to hold a serial number that is too large for a fixnum.
4639 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4640 Check for serial numbers out of range. Decode any serial number
4641 that was so large that it became a float. (Bug#8722)
4642
4643 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4644 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4645 Use XFASTINT rather than XUINT when numbers are nonnegative.
4646 (xd_append_arg, Fdbus_method_return_internal):
4647 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4648 arguments, check that Lisp number is nonnegative, rather than
4649 silently wrapping negative numbers around. (Bug#8722)
4650 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4651 (Bug#8722)
4652
4653 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4654
4655 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4656
4657 ccl: add integer overflow checks
4658 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4659 (IN_INT_RANGE): New macros.
4660 (ccl_driver): Use them to check for integer overflow when
4661 decoding a CCL program. Many of the new checks are whether XINT (x)
4662 fits in int; it doesn't always, on 64-bit hosts. The new version
4663 doesn't catch all possible integer overflows, but it's an
4664 improvement. (Bug#8719)
4665
4666 * alloc.c (make_event_array): Use XINT, not XUINT.
4667 There's no need for unsigned here.
4668
4669 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4670 This follows up to the 2011-05-06 change that substituted uintptr_t
4671 for EMACS_INT. This case wasn't caught back then.
4672
4673 Rework Fformat to avoid integer overflow issues.
4674 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4675 now (part of C89). Include <verify.h>.
4676 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4677 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4678 (Fformat): Avoid the prepass trying to compute sizes; it was only
4679 approximate and thus did not catch overflow reliably. Instead, walk
4680 through the format just once, formatting and computing sizes as we go,
4681 checking for integer overflow at every step, and allocating a larger
4682 buffer as needed. Keep track separately whether the format is
4683 multibyte. Keep only the most-recently calculated precision, rather
4684 than them all. Record whether each argument has been converted to
4685 string. Use EMACS_INT, not int, for byte and char and arg counts.
4686 Support field widths and precisions larger than INT_MAX. Avoid
4687 sprintf's undefined behavior with conversion specifications such as %#d
4688 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4689 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4690 formatting out-of-range floating point numbers with int
4691 formats. (Bug#8668)
4692
4693 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4694
4695 * data.c: Avoid integer truncation in expressions involving floats.
4696 * data.c: Include <intprops.h>.
4697 (arith_driver): When there's an integer overflow in an expression
4698 involving floating point, convert the integers to floating point
4699 so that the resulting value does not suffer from catastrophic
4700 integer truncation. For example, on a 64-bit host (* 4
4701 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4702 Do not rely on undefined behavior after integer overflow.
4703
4704 merge count_size_as_multibyte, parse_str_to_multibyte
4705 * character.c, character.h (count_size_as_multibyte):
4706 Rename from parse_str_to_multibyte; all uses changed.
4707 Check for integer overflow.
4708 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4709 since it's now a duplicate of the other. This is more of
4710 a character than a buffer op, so better that it's in character.c.
4711 * fns.c, print.c: Adjust to above changes.
4712
4713 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4714
4715 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4716
4717 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4718
4719 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4720 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4721 (x_clipboard_manager_save): Now static.
4722 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4723
4724 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4725 (crypto_hash_function): Now static.
4726 Fix pointer signedness problems. Avoid unnecessary initializations.
4727
4728 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4729
4730 * termhooks.h (Vselection_alist): Make it terminal-local.
4731
4732 * terminal.c (create_terminal): Initialize it.
4733
4734 * xselect.c: Support for clipboard managers.
4735 (Vselection_alist): Move to termhooks.h as terminal-local var.
4736 (LOCAL_SELECTION): New macro.
4737 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4738 (symbol_to_x_atom): Remove gratuitous arg.
4739 (x_handle_selection_request, lisp_data_to_selection_data)
4740 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4741 (x_own_selection, x_get_local_selection, x_convert_selection):
4742 New arg, specifying work frame. Use terminal-local Vselection_alist.
4743 (some_frame_on_display): Delete unused function.
4744 (Fx_own_selection_internal, Fx_get_selection_internal)
4745 (Fx_disown_selection_internal, Fx_selection_owner_p)
4746 (Fx_selection_exists_p): New optional frame arg.
4747 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4748 (x_handle_selection_clear): Don't treat other terminals with the
4749 same keyboard specially. Use the terminal-local Vselection_alist.
4750 (x_clear_frame_selections): Use Frun_hook_with_args.
4751
4752 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4753
4754 * xterm.h: Add support for those atoms.
4755
4756 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4757
4758 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4759 (converted_selections, conversion_fail_tag): New global variables.
4760 (x_selection_request_lisp_error): Free the above.
4761 (x_get_local_selection): Remove unnecessary code.
4762 (x_reply_selection_request): Args changed; handle arbitrary array
4763 of converted selections stored in converted_selections.
4764 Separate the XChangeProperty and SelectionNotify steps.
4765 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4766 (x_convert_selection): New function.
4767 (x_handle_selection_event): Simplify.
4768 (x_get_foreign_selection): Don't ignore incoming requests while
4769 waiting for an answer; this will fail when we implement
4770 SAVE_TARGETS, and seems unnecessary anyway.
4771 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4772 (Vx_sent_selection_functions): Doc fix.
4773
4774 2011-05-26 Leo Liu <sdl.web@gmail.com>
4775
4776 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4777
4778 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4779
4780 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4781
4782 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4783 for fringe update if it has periodic bitmap.
4784 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4785 and fringe_bitmap_periodic_p.
4786
4787 * fringe.c (get_fringe_bitmap_data): New function.
4788 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4789 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4790 row. Mark glyph row for fringe update if periodicity changed.
4791
4792 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4793 for fringe update unless it has periodic bitmap.
4794
4795 2011-05-25 Kenichi Handa <handa@m17n.org>
4796
4797 * xdisp.c (get_next_display_element): Set correct it->face_id for
4798 a static composition.
4799
4800 2011-05-24 Leo Liu <sdl.web@gmail.com>
4801
4802 * deps.mk (fns.o):
4803 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4804
4805 * fns.c (crypto_hash_function, Fsha1): New function.
4806 (Fmd5): Use crypto_hash_function.
4807 (syms_of_fns): Add Ssha1.
4808
4809 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4810
4811 * gnutls.c: Remove unused macros.
4812 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4813 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4814 Remove macros that are defined and never used.
4815 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4816
4817 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4818
4819 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4820 (Fx_get_selection_internal): Minor cleanup.
4821 (Fx_own_selection_internal): Rename arguments for consistency with
4822 select.el.
4823
4824 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4825
4826 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4827
4828 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4829
4830 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4831
4832 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4833
4834 * dispnew.c (scrolling_window): Don't exclude the case that the
4835 last enabled row in the desired matrix touches the bottom boundary.
4836
4837 2011-05-21 Glenn Morris <rgm@gnu.org>
4838
4839 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4840 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4841 and add some more files.
4842
4843 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4844
4845 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4846 report_file_error introduced by the change from 2011-05-07.
4847
4848 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4849
4850 * systime.h (Time): Define only if emacs is defined.
4851 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4852 where the include path doesn't have X11/X.h by default. See
4853 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4854
4855 2011-05-20 Kenichi Handa <handa@m17n.org>
4856
4857 * composite.c (find_automatic_composition): Fix previous change.
4858
4859 2011-05-20 Glenn Morris <rgm@gnu.org>
4860
4861 * lisp.mk: New file, split from Makefile.in.
4862 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4863 (shortlisp): Remove.
4864 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4865
4866 2011-05-19 Glenn Morris <rgm@gnu.org>
4867
4868 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4869 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4870 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4871 (lisp): Set the order to that of loadup.el.
4872 (shortlisp): Make it a copy of $lisp.
4873 (SOME_MACHINE_LISP): Remove.
4874 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4875 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4876
4877 2011-05-18 Kenichi Handa <handa@m17n.org>
4878
4879 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4880 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4881 (find_automatic_composition): Mostly rewrite for efficiency.
4882
4883 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4884
4885 * makefile.w32-in: Update dependencies.
4886
4887 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4888
4889 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4890 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4891
4892 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4893
4894 Fix some integer overflow issues, such as string length overflow.
4895
4896 * insdel.c (count_size_as_multibyte): Check for string overflow.
4897
4898 * character.c (lisp_string_width): Check for string overflow.
4899 Use EMACS_INT, not int, for string indexes and lengths; in
4900 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4901 the resulting string length overflows an EMACS_INT; instead,
4902 report a string overflow if no precision given. When checking for
4903 precision exhaustion, use a check that cannot possibly have
4904 integer overflow. (Bug#8675)
4905 * character.h (lisp_string_width): Adjust to new signature.
4906
4907 * alloc.c (string_overflow): New function.
4908 (Fmake_string): Use it. This doesn't change behavior, but saves
4909 a few bytes and will simplify future changes.
4910 * character.c (string_escape_byte8): Likewise.
4911 * lisp.h (string_overflow): New decl.
4912
4913 Fixups, following up to the user-interface timestamp change.
4914 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4915 for UI timestamps, instead of unsigned long.
4916 * msdos.c (mouse_get_pos): Likewise.
4917 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4918 * w32gui.h (Time): Define by including "systime.h" rather than by
4919 declaring it ourselves. (Bug#8664)
4920
4921 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4922 * image.c (clear_image_cache): Likewise.
4923
4924 * term.c (term_mouse_position): Don't assume time_t wraparound.
4925
4926 Be more systematic about user-interface timestamps.
4927 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4928 and sometimes 'EMACS_UINT', to represent these timestamps.
4929 This change causes it to use 'Time' uniformly, as that's what X uses.
4930 This makes the code easier to follow, and makes it easier to catch
4931 integer overflow bugs such as Bug#8664.
4932 * frame.c (Fmouse_position, Fmouse_pixel_position):
4933 Use Time, not unsigned long, for user-interface timestamps.
4934 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4935 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4936 * keyboard.h (last_event_timestamp): Likewise.
4937 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4938 * menu.h (xmenu_show): Likewise.
4939 * term.c (term_mouse_position): Likewise.
4940 * termhooks.h (struct input_event.timestamp): Likewise.
4941 (struct terminal.mouse_position_hook): Likewise.
4942 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4943 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4944 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4945 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4946 what it was before.
4947 * menu.h, termhooks.h: Include "systime.h", for Time.
4948
4949 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4950 Don't assume that the difference between two unsigned long values
4951 can fit into an integer. At this point, we know button_down_time
4952 <= event->timestamp, so the difference must be nonnegative, so
4953 there's no need to cast the result if double-click-time is
4954 nonnegative, as it should be; check that it's nonnegative, just in
4955 case. This bug is triggered when events are more than 2**31 ms
4956 apart (about 25 days). (Bug#8664)
4957
4958 * xselect.c (last_event_timestamp): Remove duplicate decl.
4959 (x_own_selection): Remove needless cast to unsigned long.
4960
4961 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4962 that always fit in int. Use a sentinel instead of a counter, to
4963 avoid a temp and to allay GCC's concerns about possible int overflow.
4964 * frame.h (struct frame): Use int for menu_bar_items_used
4965 instead of EMACS_INT, since it always fits in int.
4966
4967 * menu.c (grow_menu_items): Check for int overflow.
4968
4969 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4970
4971 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4972 Before, the code was not consistent. These values cannot exceed
4973 2**31 - 1 so there's no need to make them unsigned.
4974 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4975 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4976 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4977 as modifiers.
4978 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4979
4980 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4981 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4982 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4983 presumably because the widths might not match.
4984
4985 * window.c (size_window): Avoid needless test at loop start.
4986
4987 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4988
4989 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4990
4991 2011-05-12 Drew Adams <drew.adams@oracle.com>
4992
4993 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4994
4995 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4996
4997 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4998 `width' to `bar_area_x' and `bar_area_width', respectively.
4999 (x_scroll_run): Take account of fringe background extension.
5000
5001 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5002 Rename local vars `left' and `width' to `bar_area_x' and
5003 `bar_area_width', respectively.
5004 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5005 background extension.
5006
5007 2011-05-10 Jim Meyering <meyering@redhat.com>
5008
5009 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5010
5011 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5012
5013 * image.c (Finit_image_library): Return t for built-in image types,
5014 like pbm and xbm. (Bug#8640)
5015
5016 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5017
5018 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5019
5020 2011-05-07 Eli Zaretskii <eliz@gnu.org>
5021
5022 * w32console.c (Fset_screen_color): Doc fix.
5023 (Fget_screen_color): New function.
5024 (syms_of_ntterm): Defsubr it.
5025
5026 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5027 unlink the temporary file if Fcall_process didn't create it in the
5028 first place.
5029 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5030 child process will be redirected to a file specified with `:file'.
5031 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5032 cue to call_process_cleanup not to close that handle.
5033
5034 2011-05-07 Ben Key <bkey76@gmail.com>
5035
5036 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5037 one of two shell specific rules, either bootstrap-temacs-CMD or
5038 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5039 to the previous implementation of the bootstrap-temacs rule.
5040 The bootstrap-temacs-CMD rule is similar to the previous
5041 implementation of the bootstrap-temacs rule except that it
5042 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5043 variable.
5044
5045 These changes, along with some changes to nt/configure.bat,
5046 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5047 earlier fix to add support for --cflags and --ldflags options
5048 that include quotes so that it works whether make uses cmd or
5049 sh as the shell.
5050
5051 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
5052
5053 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5054 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5055 is a constant.
5056 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5057 a string. Handle both cases.
5058 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5059 (Fdbus_register_method): Use Qinvalid_function.
5060
5061 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5062
5063 * makefile.w32-in: Update dependencies.
5064 (LISP_H): Add inttypes.h and stdin.h.
5065 (PROCESS_H): Add unistd.h.
5066
5067 2011-05-06 Eli Zaretskii <eliz@gnu.org>
5068
5069 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5070 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5071
5072 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
5073
5074 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5075
5076 * term.c (vfatal): Remove stray call to va_end.
5077 It's not needed and the C Standard doesn't allow it here anyway.
5078
5079 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5080 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5081
5082 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5083 bytes.
5084
5085 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5086
5087 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5088
5089 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5090
5091 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5092
5093 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5094
5095 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5096 * charset.c (Fdefine_charset_internal): Don't initialize
5097 charset.code_space[15]. The value was garbage, on hosts with
5098 32-bit int (Bug#8600).
5099
5100 * lread.c (read_integer): Be more consistent with string-to-number.
5101 Use string_to_number to do the actual conversion; this avoids
5102 rounding errors and fixes some other screwups. Without this fix,
5103 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5104 (digit_to_number): Move earlier, for benefit of read_integer.
5105 Return -1 if the digit is out of range for the base, -2 if it is
5106 not a digit in any supported base. (Bug#8602)
5107
5108 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5109
5110 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5111 to match comment at start of function. This also removes a
5112 GCC warning about overflow in a 32+64-bit port.
5113
5114 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5115
5116 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5117 Reported by Stefan Monnier in
5118 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
5119 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5120 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
5121
5122 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5123 (EMACS_UINTPTR): Likewise, with uintptr_t.
5124
5125 * lisp.h: Prefer 64-bit EMACS_INT if available.
5126 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5127 on 32-bit hosts that have 64-bit int, so that they can access
5128 large files.
5129 However, temporarily disable this change unless the temporary
5130 symbol WIDE_EMACS_INT is defined.
5131
5132 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5133
5134 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5135 This removes an assumption that EMACS_INT and long are the same
5136 width as pointers. The assumption is true for Emacs porting targets
5137 now, but we want to make other targets possible.
5138 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5139 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5140 In the rest of the code, change types of integers that hold casted
5141 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5142 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5143 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5144 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5145 No need to cast type when ORing.
5146 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5147 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5148 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5149 assume EMACS_INT is the same width as char *.
5150 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5151 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5152 Remove no-longer-needed casts.
5153 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5154 (xg_tool_bar_help_callback, xg_make_tool_item):
5155 Use EMACS_INTPTR to hold an integer
5156 that will be cast to void *; this can avoid a GCC warning
5157 if EMACS_INT is not the same width as void *.
5158 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5159 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5160 (current_message_1, set_message_1):
5161 Use a local to convert to proper width without a cast.
5162 * xmenu.c (dialog_selection_callback): Likewise.
5163
5164 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5165 Also, don't assume VALBITS / RAND_BITS is less than 5,
5166 and don't rely on undefined behavior when shifting a 1 left into
5167 the sign bit.
5168 * lisp.h (get_random): Change signature to match.
5169
5170 * lread.c (hash_string): Use size_t, not int, for hash computation.
5171 Normally we prefer signed values; but hashing is special, because
5172 it's better to use unsigned division on hash table sizes so that
5173 the remainder is nonnegative. Also, size_t is the natural width
5174 for hashing into memory. The previous code used 'int', which doesn't
5175 retain enough info to hash well into very large tables.
5176 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5177
5178 * dbusbind.c: Don't possibly lose pointer info when converting.
5179 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5180 Use XPNTR rather than XHASH, so that the high-order bits of
5181 the pointer aren't lost when converting through void *.
5182
5183 * eval.c (Fautoload): Don't double-shift a pointer.
5184
5185 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5186
5187 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5188
5189 * gnutls.c (DEF_GNUTLS_FN):
5190 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5191
5192 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5193
5194 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5195 marker. (Bug#8610)
5196
5197 2011-05-05 Eli Zaretskii <eliz@gnu.org>
5198
5199 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5200 New version that can reserve upto 2GB of heap space.
5201
5202 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
5203
5204 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5205
5206 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5207
5208 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5209 `gnutls_certificate_set_x509_key_file'.
5210
5211 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
5212
5213 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5214 Update dependencies.
5215
5216 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5217
5218 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5219 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5220 Remove unused parameter `fildes'.
5221 * process.c (read_process_output, send_process): Don't pass it.
5222
5223 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5224
5225 Fix previous change: the library cache is defined in w32.c.
5226 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5227 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5228
5229 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5230
5231 Implement dynamic loading of GnuTLS on Windows.
5232
5233 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5234 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5235 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5236 Declare.
5237
5238 * gnutls.c (Qgnutls_dll): Define.
5239 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5240 (gnutls_*): Declare function pointers.
5241 (init_gnutls_functions): New function to initialize function pointers.
5242 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5243 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5244 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5245 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5246 (emacs_gnutls_write, emacs_gnutls_read)
5247 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5248 (Fgnutls_available_p): New function.
5249 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5250 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5251 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5252
5253 * image.c: Include w32.h.
5254 (Vimage_type_cache): Delete.
5255 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5256 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5257 (w32_delayed_load): Move to w32.c.
5258
5259 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5260
5261 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5262 (w32_delayed_load): Move from image.c. When loading a library, record
5263 its filename in the :loaded-from property of the library id.
5264 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5265 Initialize and staticpro them.
5266 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5267
5268 * process.c: Include lisp.h before w32.h, not after.
5269 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5270 instead of gnutls_record_check_pending.
5271
5272 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5273
5274 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5275
5276 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5277 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5278 as passed in.
5279
5280 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5281
5282 * xterm.c (x_set_frame_alpha): Do not set property on anything
5283 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5284
5285 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5286
5287 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5288
5289 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5290
5291 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5292 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5293 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5294 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5295 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5296 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5297 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5298 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5299 (Qgnutls_bootprop_callbacks_verify): Make static.
5300
5301 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5302
5303 * callproc.c: Indentation fixup.
5304
5305 * sysdep.c (wait_for_termination_1): Make static.
5306 (wait_for_termination, interruptible_wait_for_termination):
5307 Move after wait_for_termination_1.
5308
5309 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5310
5311 * sysdep.c (interruptible_wait_for_termination): New function
5312 which is like wait_for_termination, but allows keyboard
5313 interruptions.
5314
5315 * callproc.c (Fcall_process): Add (:file "file") as an option for
5316 the STDOUT buffer.
5317 (Fcall_process_region): Ditto.
5318
5319 2011-04-30 Eli Zaretskii <eliz@gnu.org>
5320
5321 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5322 rather than `XVECTOR (FOO)->size'.
5323
5324 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5325 inttypes.h, as a gnulib replacement is used if it not available in
5326 system headers.
5327
5328 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5329
5330 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5331 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5332 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5333
5334 * coding.c (coding_alloc_by_realloc): Error out if destination
5335 will grow beyond MOST_POSITIVE_FIXNUM.
5336 (decode_coding_emacs_mule): Abort if there isn't enough place in
5337 charbuf for the composition carryover bytes. Reserve an extra
5338 space for up to 2 characters produced in a loop.
5339 (decode_coding_iso_2022): Abort if there isn't enough place in
5340 charbuf for the composition carryover bytes.
5341
5342 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5343
5344 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5345 aborting when %lld or %lll format is passed.
5346 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5347 %llo or %llx format is passed. (Bug#8545)
5348
5349 * window.c (window_scroll_line_based): Use a marker instead of
5350 simple variables to record original value of point. (Bug#7952)
5351
5352 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5353 produced by %s or %c overflows available buffer space. (Bug#8545)
5354
5355 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5356
5357 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5358 (SIZE_MAX): Move defn after all includes, as they might #define it.
5359
5360 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5361
5362 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5363
5364 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5365
5366 * keyboard.c (Qdelayed_warnings_hook): Define.
5367 (command_loop_1): Run `delayed-warnings-hook'
5368 if Vdelayed_warnings_list is non-nil.
5369 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5370 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5371
5372 2011-04-28 Eli Zaretskii <eliz@gnu.org>
5373
5374 * doprnt.c (doprnt): Don't return value smaller than the buffer
5375 size if the message was truncated. (Bug#8545).
5376
5377 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5378
5379 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5380 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5381
5382 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5383
5384 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5385
5386 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5387
5388 * makefile.w32-in: Update dependencies.
5389
5390 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5391
5392 Improve `doprnt' and its usage. (Bug#8545)
5393 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5394 `format_end'. Remove support for %l as a conversion specifier.
5395 Don't use xrealloc. Improve diagnostics when the %l size modifier
5396 is used. Update the commentary.
5397
5398 * eval.c (verror): Simplify calculation of size_t.
5399
5400 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5401 messages.
5402
5403 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5404
5405 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5406 change.
5407
5408 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5409
5410 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5411 This makes this file independent of the recent pseudovector change.
5412
5413 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5414
5415 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5416
5417 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5418 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5419 Remove unused local.
5420 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5421
5422 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5423 GCC 4.6.0 optimizes based on type-based alias analysis.
5424 For example, if b is of type struct buffer * and v of type struct
5425 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5426 != &v->size, and therefore "v->size = 1; b->size = 2; return
5427 v->size;" must therefore return 1. This assumption is incorrect
5428 for Emacs, since it type-puns struct Lisp_Vector * with many other
5429 types. To fix this problem, this patch adds a new type struct
5430 vectorlike_header that documents the constraints on layout of vectors
5431 and pseudovectors, and helps optimizing compilers not get fooled
5432 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5433 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5434 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5435 the size member.
5436 (XSETPVECTYPE): Rewrite in terms of new macro.
5437 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5438 This is a bit clearer, and further avoids the possibility of
5439 undesirable aliasing.
5440 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5441 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5442 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5443 since Lisp_Subr is a special case (no "next" field).
5444 (ASIZE): Now uses header.size rather than size.
5445 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5446 to avoid the hassle of writing XVECTOR (foo)->header.size.
5447 (struct vectorlike_header): New type.
5448 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5449 object, to help avoid aliasing.
5450 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5451 (SUBRP): Likewise, since Lisp_Subr is a special case.
5452 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5453 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5454 (struct Lisp_Hash_Table): Combine first two members into a single
5455 struct vectorlike_header member. All uses of "size" and "next" members
5456 changed to be "header.size" and "header.next".
5457 * buffer.h (struct buffer): Likewise.
5458 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5459 * frame.h (struct frame): Likewise.
5460 * process.h (struct Lisp_Process): Likewise.
5461 * termhooks.h (struct terminal): Likewise.
5462 * window.c (struct save_window_data, struct saved_window): Likewise.
5463 * window.h (struct window): Likewise.
5464 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5465 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5466 * buffer.c (init_buffer_once): Likewise.
5467 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5468 special case.
5469 * process.c (Fformat_network_address): Use local var for size,
5470 for brevity.
5471
5472 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5473
5474 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5475 * data.c (atof): Remove decl; no longer used or needed.
5476 (digit_to_number): Move to lread.c.
5477 (Fstring_to_number): Use new string_to_number function, to be
5478 consistent with how the Lisp reader treats infinities and NaNs.
5479 Do not assume that floating-point numbers represent EMACS_INT
5480 without losing information; this is not true on most 64-bit hosts.
5481 Avoid double-rounding errors, by insisting on integers when
5482 parsing non-base-10 numbers, as the documentation specifies.
5483 * lisp.h (string_to_number): New decl, replacing ...
5484 (isfloat_string): Remove.
5485 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5486 (read1): Do not accept +. and -. as integers; this
5487 appears to have been a coding error. Similarly, do not accept
5488 strings like +-1e0 as floating point numbers. Do not report
5489 overflow for integer overflows unless the base is not 10 which
5490 means we have no simple and reliable way to continue.
5491 Break out the floating-point parsing into a new
5492 function string_to_number, so that Fstring_to_number parses
5493 floating point numbers consistently with the Lisp reader.
5494 (digit_to_number): Move here from data.c. Make it static inline.
5495 (E_CHAR, EXP_INT): Remove, replacing with ...
5496 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5497 (string_to_number): New function, replacing isfloat_string.
5498 This function checks for valid syntax and produces the resulting
5499 Lisp float number too. Rework it so that string-to-number
5500 no longer mishandles examples like "1.0e+". Use strtoumax,
5501 so that overflow for non-base-10 numbers is reported only when
5502 there's no portable and simple way to convert to floating point.
5503
5504 * textprop.c (set_text_properties_1): Rewrite for clarity,
5505 and to avoid GCC warning about integer overflow.
5506
5507 * intervals.h (struct interval): Use EMACS_INT for members
5508 where EMACS_UINT might cause problems. See
5509 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5510 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5511 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5512 All uses changed.
5513 (offset_intervals): Tell GCC not to worry about length overflow
5514 when negating a negative length.
5515
5516 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5517 (overrun_check_free): Likewise.
5518
5519 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5520 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5521 word size.
5522
5523 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5524 (gnutls_make_error): Rename local to avoid shadowing.
5525 (gnutls_emacs_global_deinit): ifdef out; not used.
5526 (Fgnutls_boot): Use const for pointer to readonly storage.
5527 Comment out unused local. Fix pointer signedness problems.
5528
5529 * lread.c (openp): Don't stuff size_t into an 'int'.
5530 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5531 about possible signed overflow.
5532
5533 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5534 (GDK_KEY_g): Don't define if already defined.
5535 (xg_prepare_tooltip): Avoid pointer signedness problem.
5536 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5537
5538 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5539 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5540
5541 * xfns.c (Fx_window_property): Simplify a bit,
5542 to make a bit faster and to avoid GCC 4.6.0 warning.
5543 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5544
5545 * fns.c (internal_equal): Don't assume size_t fits in int.
5546
5547 * alloc.c (compact_small_strings): Tighten assertion a little.
5548
5549 Replace pEd with more-general pI, and fix some printf arg casts.
5550 * lisp.h (pI): New macro, generalizing old pEd macro to other
5551 conversion specifiers. For example, use "...%"pI"d..." rather
5552 than "...%"pEd"...".
5553 (pEd): Remove. All uses replaced with similar uses of pI.
5554 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5555 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5556 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5557 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5558 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5559 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5560 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5561 64-bit hosts.
5562 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5563 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5564 * print.c (safe_debug_print, print_object): Likewise.
5565 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5566 to int.
5567 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5568 avoiding the 0 flag, which is not portable.
5569 * process.c (Fmake_network_process): Use pI to avoid cast.
5570 * region-cache.c (pp_cache): Likewise.
5571 * xdisp.c (decode_mode_spec): Likewise.
5572 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5573 behavior on 64-bit hosts with printf arg.
5574 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5575 (x_stop_queuing_selection_requests): Likewise.
5576 (x_get_window_property): Don't truncate byte count to an 'int'
5577 when tracing.
5578
5579 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5580 here, since it parses constructs like leading '-' and spaces,
5581 which are not wanted; and it overflows with large numbers.
5582 Instead, simply match F[0-9]+, which is what is wanted anyway.
5583
5584 * alloc.c: Remove unportable assumptions about struct layout.
5585 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5586 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5587 (allocate_vectorlike, make_pure_vector): Use the new macros,
5588 plus offsetof, to remove unportable assumptions about struct layout.
5589 These assumptions hold on all porting targets that I know of, but
5590 they are not guaranteed, they're easy to remove, and removing them
5591 makes further changes easier.
5592
5593 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5594 This doesn't fix a bug but makes the code clearer.
5595 (string_overrun_cookie): Now const. Use initializers that
5596 don't formally overflow signed char, to avoid warnings.
5597 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5598 can cause Emacs to crash when string overrun checking is enabled.
5599 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5600 multiple of sizeof (EMACS_INT); it need not be, if
5601 alignof(EMACS_INT) < sizeof (EMACS_INT).
5602 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5603
5604 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5605
5606 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5607
5608 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5609
5610 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5611 supposed to be handshaking. (Bug#8556)
5612 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5613
5614 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5615
5616 * lisp.h (Qdebug): List symbol.
5617 * eval.c (Qdebug): Restore global linkage.
5618 * keyboard.c (debug-on-event): New variable.
5619 (handle_user_signal): Break into debugger when debug-on-event
5620 matches the current signal symbol.
5621
5622 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5623
5624 * alloc.c (check_sblock, check_string_bytes)
5625 (check_string_free_list): Convert to standard C.
5626
5627 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5628
5629 * w32.c (emacs_gnutls_push): Fix typo.
5630
5631 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5632
5633 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5634 "cast to pointer from integer of different size".
5635
5636 Improve doprnt and its use in verror. (Bug#8545)
5637 * doprnt.c (doprnt): Document the set of format control sequences
5638 supported by the function. Use SAFE_ALLOCA instead of always
5639 using `alloca'.
5640
5641 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5642 is one byte too soon. Don't use xrealloc; instead xfree and
5643 xmalloc anew.
5644
5645 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5646
5647 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5648 callbacks stage.
5649
5650 * gnutls.c: Renamed global_initialized to
5651 gnutls_global_initialized. Added internals for the
5652 :verify-hostname-error, :verify-error, and :verify-flags
5653 parameters of `gnutls-boot' and documented those parameters in the
5654 docstring. Start callback support.
5655 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5656 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5657 on error. Return error code.
5658 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5659 (emacs_gnutls_read): Likewise.
5660 (Fgnutls_boot): Return handshake error code.
5661 (emacs_gnutls_handle_error): New function.
5662 (wsaerror_to_errno): Likewise.
5663
5664 * w32.h (emacs_gnutls_pull): Add prototype.
5665 (emacs_gnutls_push): Likewise.
5666
5667 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5668 (emacs_gnutls_push): Likewise.
5669
5670 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5671
5672 * process.c (wait_reading_process_output): Check if GnuTLS
5673 buffered some data internally if no FDs are set for TLS
5674 connections.
5675
5676 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5677 (LIBS): Link to USER_LIBS.
5678 ($(BLD)/gnutls.$(0)): New target.
5679
5680 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5681
5682 * xdisp.c (handle_single_display_spec): Rename the
5683 display_replaced_before_p argument into display_replaced_p, to
5684 make it consistent with the commentary. Fix typos in the
5685 commentary.
5686
5687 * textprop.c (syms_of_textprop): Remove dead code.
5688 (copy_text_properties): Delete obsolete commentary about an
5689 interface that was deleted long ago. Fix typos in the description
5690 of arguments.
5691
5692 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5693 to changes in oldXMenu/XMenu.h from 2011-04-16.
5694 <menu_help_message, prev_menu_help_message>: Constify.
5695 (IT_menu_make_room): menu->help_text is now `const char **';
5696 adjust.
5697
5698 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5699 to changes in oldXMenu/XMenu.h from 2011-04-16.
5700 (struct XMenu): Declare `help_text' `const char **'.
5701
5702 * xfaces.c <Qunspecified>: Make extern again.
5703
5704 * syntax.c: Include sys/types.h before including regex.h, as
5705 required by Posix.
5706
5707 * doc.c (get_doc_string): Improve the format passed to `error'.
5708
5709 * doprnt.c (doprnt): Improve commentary.
5710
5711 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5712
5713 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5714 them with etags.
5715
5716 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5717 changes in globals.h immediately force recompilation.
5718 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5719 $(CURDIR)/s/ms-w32.h.
5720 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5721
5722 * character.c (Fchar_direction): Function deleted.
5723 (syms_of_character): Don't defsubr it.
5724 <char-direction-table>: Deleted.
5725
5726 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5727
5728 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5729 * doprnt.c: Include limits.h.
5730 (SIZE_MAX): New macro.
5731 (doprnt): Return a size_t value. 2nd arg is now size_t.
5732 Many local variables are now size_t instead of int or unsigned.
5733 Improve overflow protection. Support `l' modifier for integer
5734 conversions. Support %l conversion. Don't assume an EMACS_INT
5735 argument for integer conversions and for %c.
5736
5737 * lisp.h (doprnt): Restore prototype.
5738
5739 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5740 $(SRC)/character.h.
5741
5742 * Makefile.in (base_obj): Add back doprnt.o.
5743
5744 * deps.mk (doprnt.o): Add back prerequisites.
5745 (callint.o): Depend on character.h.
5746
5747 * eval.c (internal_lisp_condition_case): Include the handler
5748 representation in the error message.
5749 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5750 when breaking from the loop.
5751
5752 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5753
5754 * callint.c (Fcall_interactively): When displaying error message
5755 about invalid control letter, pass the character's codepoint, not
5756 a pointer to its multibyte form. Improve display of the character
5757 in octal and display also its hex code.
5758
5759 * character.c (char_string): Use %x to display the (unsigned)
5760 codepoint of an invalid character, to avoid displaying a bogus
5761 negative value.
5762
5763 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5764 `error', not SYMBOL_NAME itself.
5765
5766 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5767 character arguments to `error'.
5768
5769 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5770 to `error' in error message about FINAL_CHAR argument. Make sure
5771 FINAL_CHAR is a character, and use %c when it is passed as
5772 argument to `error'.
5773
5774 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5775
5776 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5777
5778 * w32.c: Include <time.h>.
5779 (sys_localtime): New function.
5780
5781 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5782
5783 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5784
5785 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5786
5787 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5788
5789 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5790 zombies (Bug#8467).
5791
5792 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5793
5794 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5795 gl_state.e_property when gl_state.object is Qt.
5796
5797 * insdel.c (make_gap_larger): Remove limitation of buffer size
5798 to <= INT_MAX.
5799
5800 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5801
5802 * xdisp.c (lookup_glyphless_char_display)
5803 (produce_glyphless_glyph): Handle cons cell entry in
5804 glyphless-char-display.
5805 (Vglyphless_char_display): Document it.
5806
5807 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5808 glyphless-char-display.
5809
5810 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5811
5812 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5813
5814 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5815
5816 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5817 definition for no-X builds.
5818
5819 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5820
5821 Static checks with GCC 4.6.0 and non-default toolkits.
5822
5823 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5824
5825 * process.c (keyboard_bit_set): Define only if SIGIO.
5826 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5827 (send_process): Repair possible setjmp clobbering.
5828
5829 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5830
5831 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5832
5833 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5834
5835 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5836 Define only if needed.
5837
5838 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5839 by pacifying GCC about it. Maybe it's time to retire it?
5840 * xfaces.c (USG, __TIMEVAL__): Likewise.
5841
5842 * dispextern.h (struct redisplay_interface): Rename param
5843 to avoid shadowing.
5844 * termhooks.h (struct terminal): Likewise.
5845 * xterm.c (xembed_send_message): Likewise.
5846
5847 * insdel.c (make_gap_smaller): Define only if
5848 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5849
5850 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5851 it.
5852
5853 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5854 so that we aren't warned about unused symbols.
5855
5856 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5857
5858 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5859
5860 * xfns.c (x_real_positions): Mark locals as initialized.
5861
5862 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5863
5864 * xterm.c: Fix problems found by static analysis with other toolkits.
5865 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5866 (x_dispatch_event): Declare static if USE_GTK, and
5867 define if USE_GTK || USE_X_TOOLKIT.
5868 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5869 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5870 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5871 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5872
5873 * xmenu.c (menu_help_callback): Pointer type fixes.
5874 Use const pointers when pointing at readonly data. Avoid pointer
5875 signedness clashes.
5876 (FALSE): Remove unused macro.
5877 (update_frame_menubar): Remove unused decl.
5878
5879 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5880
5881 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5882 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5883 (single_menu_item): Rename local to avoid shadowing.
5884
5885 * keyboard.c (make_lispy_event): Remove unused local var.
5886
5887 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5888 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5889
5890 * bitmaps: Change bitmaps from unsigned char back to the X11
5891 compatible char. Avoid the old compiler warnings about
5892 out-of-range initializers by using, for example, '\xab' rather
5893 than 0xab.
5894
5895 * xgselect.c (xgselect_initialize): Check vs interface
5896 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5897
5898 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5899
5900 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5901 to read-only memory.
5902
5903 * fns.c (vector): Remove; this old hack is no longer needed.
5904
5905 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5906 Remove unused var.
5907 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5908
5909 * xrdb.c (x_load_resources): Omit unused local.
5910
5911 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5912 (x_window): Rename locals to avoid shadowing.
5913 (USG): Use the kludged USG macro, to pacify gcc.
5914
5915 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5916 (x_term_init): Remove local to avoid shadowing.
5917
5918 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5919
5920 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5921 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5922
5923 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5924
5925 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5926
5927 Fix regex.c, syntax.c and friends for buffers > 2GB.
5928 * syntax.h (struct gl_state_s): Declare character position members
5929 EMACS_INT.
5930
5931 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5932
5933 * textprop.c (verify_interval_modification, interval_of):
5934 Declare arguments EMACS_INT.
5935
5936 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5937 EMACS_INT.
5938
5939 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5940
5941 * indent.c (Fvertical_motion): Local variable it_start is now
5942 EMACS_INT.
5943
5944 * regex.c (re_match, re_match_2, re_match_2_internal)
5945 (bcmp_translate, regcomp, regexec, print_double_string)
5946 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5947 (re_compile_pattern, re_exec): Declare arguments and local
5948 variables `size_t' and `ssize_t' and return values `regoff_t', as
5949 appropriate.
5950 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5951 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5952 <compile_stack_type>: `size' and `avail' are now `size_t'.
5953
5954 * regex.h <regoff_t>: Use ssize_t, not int.
5955 (re_search, re_search_2, re_match, re_match_2): Arguments that
5956 specify buffer/string position and length are now ssize_t and
5957 size_t. Return type is regoff_t.
5958
5959 2011-04-16 Ben Key <bkey76@gmail.com>
5960
5961 * nsfont.m: Fixed bugs in ns_get_family and
5962 ns_descriptor_to_entity that were caused by using free to
5963 deallocate memory blocks that were allocated by xmalloc (via
5964 xstrdup). This caused Emacs to crash when compiled with
5965 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5966 --enable-checking=xmallocoverrun). xfree is now used to
5967 deallocate these memory blocks.
5968
5969 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5970
5971 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5972
5973 emacs_write: Accept and return EMACS_INT for sizes.
5974 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5975 et seq.
5976 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5977 Accept and return EMACS_INT.
5978 (emacs_gnutls_write): Return the number of bytes written on
5979 partial writes.
5980 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5981 (emacs_read, emacs_write): Remove check for negative size, as the
5982 Emacs source code has been audited now.
5983 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5984 (emacs_read, emacs_write): Use it.
5985 * process.c (send_process): Adjust to the new signatures of
5986 emacs_write and emacs_gnutls_write. Do not attempt to store
5987 a byte offset into an 'int'; it might overflow.
5988 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5989
5990 * sound.c: Don't assume sizes fit in 'int'.
5991 (struct sound_device.period_size, alsa_period_size):
5992 Return EMACS_INT, not int.
5993 (struct sound_device.write, vox_write, alsa_write):
5994 Accept EMACS_INT, not int.
5995 (wav_play, au_play): Use EMACS_INT to store sizes and to
5996 record read return values.
5997
5998 2011-04-15 Ben Key <bkey76@gmail.com>
5999
6000 * keyboard.c (Qundefined): Don't declare static since it is used
6001 in nsfns.m.
6002 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6003 static since they are used in nsfont.m.
6004
6005 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6006
6007 * process.c (Qprocessp): Don't declare static.
6008 * lisp.h (Qprocessp): Declare again.
6009
6010 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
6011
6012 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6013
6014 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6015
6016 Improve C-level modularity by making more things 'static'.
6017
6018 Don't publish debugger-only interfaces to other modules.
6019 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6020 (verify_bytepos, count_markers): Move decls to the only modules
6021 that need them.
6022 * region-cache.h (pp_cache): Likewise.
6023 * window.h (check_all_windows): Likewise.
6024 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6025
6026 * sysdep.c (croak): Now static, if
6027 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6028 * syssignal.h (croak): Declare only if not static.
6029
6030 * alloc.c (refill_memory_reserve): Now static if
6031 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6032 * lisp.h (refill_memory_reserve): Declare only if not static.
6033
6034 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6035 Define only if USE_LUCID.
6036
6037 * xrdb.c (x_customization_string, x_rm_string): Now static.
6038
6039 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6040 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6041
6042 * xdisp.c (draw_row_with_mouse_face): Now static.
6043 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6044
6045 * window.h (check_all_windows): Mark externally visible.
6046
6047 * window.c (window_deletion_count): Now static.
6048
6049 * undo.c: Make symbols static if they're not exported.
6050 (last_undo_buffer, last_boundary_position, pending_boundary):
6051 Now static.
6052
6053 * textprop.c (interval_insert_behind_hooks): Now static.
6054 (interval_insert_in_front_hooks): Likewise.
6055
6056 * term.c: Make symbols static if they're not exported.
6057 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6058 (max_frame_lines, tty_set_terminal_modes):
6059 (tty_reset_terminal_modes, tty_turn_off_highlight):
6060 (get_tty_terminal): Now static.
6061 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6062 * termhooks.h (term_mouse_moveto): Do not declare if
6063 HAVE_WINDOW_SYSTEM.
6064 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6065 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6066
6067 * sysdep.c: Make symbols static if they're not exported.
6068 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6069 Now static.
6070 (sigprocmask_set, full_mask): Remove; unused.
6071 (wait_debugging): Mark as visible.
6072 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6073 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6074
6075 * syntax.c (syntax_temp): Define only if !__GNUC__.
6076
6077 * sound.c (current_sound_device, current_sound): Now static.
6078
6079 * search.c (searchbufs, searchbuf_head): Now static.
6080
6081 * scroll.c (scroll_cost): Remove; unused.
6082 * dispextern.h (scroll_cost): Remove decl.
6083
6084 * region-cache.h (pp_cache): Mark as externally visible.
6085
6086 * process.c: Make symbols static if they're not exported.
6087 (process_tick, update_tick, create_process, chan_process):
6088 (Vprocess_alist, proc_buffered_char, datagram_access):
6089 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6090 (deactivate_process): Mark defn as static, as well as decl.
6091 * lisp.h (create_process): Remove decl.
6092 * process.h (chan_process, Vprocess_alist): Remove decls.
6093
6094 * print.c: Make symbols static if they're not exported.
6095 (print_depth, new_backquote_output, being_printed, print_buffer):
6096 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6097 (print_interval, print_number_index, initial_stderr_stream):
6098 Now static.
6099 * lisp.h (Fprinc): Remove decl.
6100 (debug_output_compilation_hack): Mark as externally visible.
6101
6102 * sysdep.c (croak): Move decl from here to syssignal.h.
6103 * syssignal.h (croak): Put it here, so the API can be checked when
6104 'croak' is called from dissociate_if_controlling_tty.
6105
6106 * minibuf.c: Make symbols static if they're not exported.
6107 (minibuf_save_list, choose_minibuf_frame): Now static.
6108 * lisp.h (choose_minibuf_frame): Remove decl.
6109
6110 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6111
6112 * lread.c: Make symbols static if they're not exported.
6113 (read_objects, initial_obarray, oblookup_last_bucket_number):
6114 Now static.
6115 (make_symbol): Remove; unused.
6116 * lisp.h (initial_obarray, make_symbol): Remove decls.
6117
6118 * keyboard.c: Make symbols static if they're not exported.
6119 (single_kboard, recent_keys_index, total_keys, recent_keys):
6120 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6121 (this_single_command_key_start, echoing, last_auto_save):
6122 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6123 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6124 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6125 (Vlispy_mouse_stem, double_click_count):
6126 Now static.
6127 (force_auto_save_soon): Define only if SIGDANGER.
6128 (ignore_mouse_drag_p): Now static if
6129 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6130 (print_help): Remove; unused.
6131 (stop_character, last_timer_event): Mark as externally visible.
6132 * keyboard.h (ignore_mouse_drag_p): Declare only if
6133 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6134 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6135 * lisp.h (echoing): Remove decl.
6136 (force_auto_save_soon): Declare only if SIGDANGER.
6137 * xdisp.c (redisplay_window): Simplify code, to make it more
6138 obvious that ignore_mouse_drag_p is not accessed if !defined
6139 USE_GTK && !defined HAVE_NS.
6140
6141 * intervals.c: Make symbols static if they're not exported.
6142 (merge_properties_sticky, merge_interval_right, delete_interval):
6143 Now static.
6144 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6145
6146 * insdel.c: Make symbols static if they're not exported.
6147 However, leave prepare_to_modify_buffer alone. It's never
6148 called from outside this function, but that appears to be a bug.
6149 (combine_after_change_list, combine_after_change_buffer):
6150 (adjust_after_replace, signal_before_change): Now static.
6151 (adjust_after_replace_noundo): Remove; unused.
6152 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
6153 (signal_before_change): Remove decls.
6154
6155 * indent.c (val_compute_motion, val_vmotion): Now static.
6156
6157 * image.c: Make symbols static if they're not exported.
6158 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6159 if USE_GTK.
6160 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6161 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6162
6163 * fringe.c (standard_bitmaps): Now static.
6164 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6165
6166 * frame.c: Make symbols static if they're not exported.
6167 (x_report_frame_params, make_terminal_frame): Now static.
6168 (get_frame_param): Now static, unless HAVE_NS.
6169 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6170 (x_get_resource_string): Remove; not used.
6171 * frame.h (make_terminal_frame, x_report_frame_params):
6172 (x_get_resource_string); Remove decls.
6173 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6174 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6175
6176 * font.c, fontset.c: Make symbols static if they're not exported.
6177 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6178 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6179 * font.c (font_close_object): Now static.
6180 * font.h (font_close_object): Remove.
6181 * fontset.c (FONTSET_OBJLIST): Remove.
6182 (free_realized_fontset) #if-0 the body, which does nothing.
6183 (face_suitable_for_char_p): #if-0, as it's never called.
6184 * fontset.h (face_suitable_for_char_p): Remove decl.
6185 * xfaces.c (face_at_string_position):
6186 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
6187 since 0 is always ASCII.
6188
6189 * fns.c (weak_hash_tables): Now static.
6190
6191 * fileio.c: Make symbols static if they're not exported.
6192 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6193 (Vwrite_region_annotation_buffers): Now static.
6194
6195 * eval.c: Make symbols static if they're not exported.
6196 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6197 * lisp.h (backtrace_list): Remove decl.
6198
6199 * emacs.c: Make symbols static if they're not exported.
6200 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6201 (fatal_error_code, fatal_error_signal_hook, standard_args):
6202 Now static.
6203 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6204 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6205 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6206 * lisp.h (fatal_error_signal_hook): Remove decl.
6207 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6208
6209 * editfns.c: Move a (normally-unused) function to its only use.
6210 * editfns.c, lisp.h (get_operating_system_release): Remove.
6211 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6212 worth the hassle of breaking this out.
6213
6214 * xterm.c: Make symbols static if they're not exported.
6215 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6216 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6217 (x_destroy_window, x_delete_display):
6218 Now static.
6219 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6220 (x_mouse_leave): Remove; unused.
6221 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6222 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6223 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6224 Remove decls.
6225 (x_mouse_leave): Declare only if WINDOWSNT.
6226 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6227 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6228 USE_X_TOOLKIT.
6229
6230 * ftxfont.c: Make symbols static if they're not exported.
6231 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6232 HAVE_FREETYPE.
6233 * font.h (ftxfont_driver): Likewise.
6234
6235 * xfns.c: Make symbols static if they're not exported.
6236 (x_last_font_name, x_display_info_for_name):
6237 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6238 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6239 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6240 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6241 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6242 (last_show_tip_args): Now static.
6243 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6244 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6245 (x_screen_planes): Remove; unused.
6246 * dispextern.h (x_screen_planes): Remove decl.
6247
6248 * dispnew.c: Make symbols static if they're not exported.
6249 * dispextern.h (redraw_garbaged_frames, scrolling):
6250 (increment_row_positions): Remove.
6251 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6252 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6253 Now static.
6254 (redraw_garbaged_frames): Remove; unused.
6255
6256 * xfaces.c: Make symbols static if they're not exported.
6257 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6258 Remove decls.
6259 * xterm.h (defined_color): Remove decls.
6260 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6261 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6262 (menu_face_changed_default, defined_color, free_realized_face):
6263 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6264 (ascii_face_of_lisp_face): Remove; unused.
6265
6266 * xdisp.c: Make symbols static if they're not exported.
6267 * dispextern.h (scratch_glyph_row, window_box_edges):
6268 (glyph_to_pixel_coords, set_cursor_from_row):
6269 (get_next_display_element, set_iterator_to_next):
6270 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6271 (show_mouse_face): Remove decls
6272 * frame.h (message_buf_print): Likewise.
6273 * lisp.h (pop_message, set_message, check_point_in_composition):
6274 Likewise.
6275 * xterm.h (set_vertical_scroll_bar): Likewise.
6276 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6277 (message_buf_print, scratch_glyph_row, displayed_buffer):
6278 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6279 (get_next_display_element, show_mouse_face, window_box_edges):
6280 (frame_to_window_pixel_xy, check_point_in_composition):
6281 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6282 (glyph_to_pixel_coords): Remove; unused.
6283
6284 * dired.c (file_name_completion): Now static.
6285
6286 * dbusbind.c (xd_in_read_queued_messages): Now static.
6287
6288 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6289 * data.c (circular_list_error): Remove.
6290
6291 * commands.h (last_point_position, last_point_position_buffer):
6292 (last_point_position_window): Remove decls.
6293 * keyboard.c: Make these variables static.
6294
6295 * coding.h (coding, code_convert_region, encode_coding_gap):
6296 Remove decls.
6297 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6298 (iso_code_class, detect_coding, code_convert_region): Now static.
6299 (encode_coding_gap): Remove; unused.
6300
6301 * chartab.c (chartab_chars, chartab_bits): Now static.
6302
6303 * charset.h (charset_iso_8859_1): Remove decl.
6304 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6305 Now static.
6306
6307 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6308 * ccl.c (Vccl_program_table): Now static.
6309 (check_ccl_update): Remove; unused.
6310
6311 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6312 * category.h: ... from here.
6313 * category.c (check_category_table, set_category_set): Now static.
6314
6315 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6316 * lisp.h: Remove these decls.
6317
6318 * buffer.c (buffer_count): Remove unused var.
6319
6320 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6321 so that it's not optimized away.
6322 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6323 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6324 exported only to the debugger.
6325
6326 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
6327 * atimer.h (run_all_atimers): Remove; not exported.
6328
6329 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6330 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6331 was inaccessible from Lisp.
6332 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6333 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6334
6335 alloc.c: Import and export fewer symbols, and remove unused items.
6336 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6337 is defined.
6338 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6339 it's not optimized away by whole-program optimization.
6340 (message_enable_multibyte, free_misc): Remove.
6341 (catchlist, handlerlist, mark_backtrace):
6342 Declare only if BYTE_MARK_STACK.
6343 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6344 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6345 (message_enable_multibyte): Remove decl.
6346 (free_misc, interval_free_list, float_block, float_block_index):
6347 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6348 (cons_free_list, last_marked_index):
6349 Now static.
6350 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6351 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6352 (mark_backtrace): Define only if BYTE_MARK_STACK.
6353 * xdisp.c (message_enable_multibyte): Now static.
6354
6355 Declare Lisp_Object Q* variables to be 'static' if not exported.
6356 This makes it easier for human readers (and static analyzers)
6357 to see whether these variables are used from other modules.
6358 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6359 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6360 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6361 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6362 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6363 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6364 * xmenu.c, xselect.c:
6365 Declare Q* vars static if they are not used in other modules.
6366 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6367 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6368 Remove decls of unexported vars.
6369 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6370
6371 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6372
6373 Make Emacs functions such as Fatom 'static' by default.
6374 This makes it easier for human readers (and static analyzers)
6375 to see whether these functions can be called from other modules.
6376 DEFUN now defines a static function. To make the function external
6377 so that it can be used in other C modules, use the new macro DEFUE.
6378 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6379 (Finit_image_library):
6380 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6381 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6382 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6383 Remove decls, since these functions are now static.
6384 (Funintern, Fget_internal_run_time): New decls, since these functions
6385 were already external.
6386
6387 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6388 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6389 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6390 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6391 * keyboard.c, keymap.c, lread.c:
6392 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6393 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6394 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6395 Mark functions with DEFUE instead of DEFUN,
6396 if they are used in other modules.
6397 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6398 decls for now-static functions.
6399 * buffer.h (Fdelete_overlay): Remove decl.
6400 * callproc.c (Fgetenv_internal): Mark as internal.
6401 * composite.c (Fremove_list_of_text_properties): Remove decl.
6402 (Fcomposition_get_gstring): New forward static decl.
6403 * composite.h (Fcomposite_get_gstring): Remove decl.
6404 * dired.c (Ffile_attributes): New forward static decl.
6405 * doc.c (Fdocumntation_property): New forward static decl.
6406 * eval.c (Ffetch_bytecode): New forward static decl.
6407 (Funintern): Remove extern decl; now in .h file where it belongs.
6408 * fileio.c (Fmake_symbolic_link): New forward static decl.
6409 * image.c (Finit_image_library): New forward static decl.
6410 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6411 * intervals.h (Fprevious_property_change):
6412 (Fremove_list_of_text_properties): Remove decls.
6413 * keyboard.c (Fthis_command_keys): Remove decl.
6414 (Fcommand_execute): New forward static decl.
6415 * keymap.c (Flookup_key): New forward static decl.
6416 (Fcopy_keymap): Now static.
6417 * keymap.h (Flookup_key): Remove decl.
6418 * process.c (Fget_process): New forward static decl.
6419 (Fprocess_datagram_address): Mark as internal.
6420 * syntax.c (Fsyntax_table_p): New forward static decl.
6421 (skip_chars): Remove duplicate decl.
6422 * textprop.c (Fprevious_property_change): New forward static decl.
6423 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6424 Now internal.
6425 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6426 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6427
6428 * editfns.c (Fformat): Remove unreachable code.
6429
6430 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6431
6432 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6433 change. (Bug#8496)
6434
6435 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6436
6437 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6438 when at ZV. (Bug#8487)
6439
6440 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6441
6442 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6443 (Bug#8437)
6444 * keyboard.c (parse_tool_bar_item): Likewise.
6445 * sound.c (sound_cleanup, alsa_close): Likewise.
6446 * termcap.c (tgetent): Likewise.
6447 * xfns.c (x_default_font_parameter): Likewise.
6448 * xsettings.c (read_and_apply_settings): Likewise.
6449
6450 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6451 (overrun_check_free): Protoize.
6452
6453 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6454
6455 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6456 since callers should never pass a negative size.
6457 Change the signature to match that of plain 'read' and 'write'; see
6458 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6459 * lisp.h: Update prototypes of emacs_write and emacs_read.
6460
6461 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6462
6463 * xdisp.c (redisplay_window): Don't try to determine the character
6464 position of the scroll margin if the window start point w->startp
6465 is outside the buffer's accessible region. (Bug#8468)
6466
6467 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6468
6469 Fix write-region and its subroutines for buffers > 2GB.
6470 * fileio.c (a_write, e_write): Modify declaration of arguments and
6471 local variables to support buffers larger than 2GB.
6472 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6473
6474 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6475 argument, local variables, and return value.
6476
6477 * lisp.h: Update prototypes of emacs_write and emacs_read.
6478
6479 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6480
6481 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6482
6483 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6484
6485 Fix more problems found by GCC 4.6.0's static checks.
6486
6487 * xdisp.c (vmessage): Use a better test for character truncation.
6488
6489 * charset.c (load_charset_map): <, not <=, for optimization,
6490 and to avoid potential problems with integer overflow.
6491 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6492 * casetab.c (set_identity, shuffle): Likewise.
6493 * editfns.c (Fformat): Likewise.
6494 * syntax.c (skip_chars): Likewise.
6495
6496 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6497 This also lets GCC 4.6.0 generate slightly better loop code.
6498
6499 * callint.c (Fcall_interactively): <, not <=, for optimization.
6500 (Fcall_interactively): Count the number of arguments produced,
6501 not the number of arguments given. This is simpler and lets GCC
6502 4.6.0 generate slightly better code.
6503
6504 * ftfont.c: Distingish more carefully between FcChar8 and char.
6505 The previous code passed unsigned char * to a functions like
6506 strlen and xstrcasecmp that expect char *, which does not
6507 conform to the C standard.
6508 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6509 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6510 char * when the C standard requires it.
6511
6512 * keyboard.c (read_char): Remove unused var.
6513
6514 * eval.c: Port to Windows vsnprintf (Bug#8435).
6515 Include <limits.h>.
6516 (SIZE_MAX): Define if the headers do not.
6517 (verror): Do not give up if vsnprintf returns a negative count.
6518 Instead, grow the buffer. This ports to Windows vsnprintf, which
6519 does not conform to C99. Problem reported by Eli Zaretskii.
6520 Also, simplify the allocation scheme, by avoiding the need for
6521 calling realloc, and removing the ALLOCATED variable.
6522
6523 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6524
6525 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6526 But keep the doprint source code for now, as we might revamp it
6527 and use it again (Bug#8435).
6528 * lisp.h (doprnt): Remove.
6529 * Makefile.in (base_obj): Remove doprnt.o.
6530 * deps.mk (doprnt.o): Remove.
6531
6532 error: Print 32- and 64-bit integers portably (Bug#8435).
6533 Without this change, on typical 64-bit hosts error ("...%d...", N)
6534 was used to print both 32- and 64-bit integers N, which relied on
6535 undefined behavior.
6536 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6537 New macro.
6538 * lisp.h (error, verror): Mark as printf-like functions.
6539 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6540 Report overflow in size calculations when allocating printf buffer.
6541 Do not truncate output string at its first null byte.
6542 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6543 Truncate the output at a character boundary, since vsnprintf does not
6544 do that.
6545 * charset.c (check_iso_charset_parameter): Convert internal
6546 character to string before calling 'error', since %c now has the
6547 printf meaning.
6548 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6549 overflow when computing char to be passed to 'error'. Do not
6550 pass Lisp_Object to 'error'; pass the integer instead.
6551 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6552 formatted with plain %d.
6553
6554 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6555
6556 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6557
6558 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6559
6560 * xterm.c (x_catch_errors): Remove duplicate declaration.
6561
6562 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6563
6564 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6565
6566 2011-04-10 Jim Meyering <meyering@redhat.com>
6567
6568 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6569 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6570 return ssize_t not "int", and use size_t as the buffer length.
6571 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6572 * gnutls.h: Update declarations.
6573 * process.c (read_process_output): Use ssize_t, to match.
6574 (send_process): Likewise.
6575
6576 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6577
6578 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6579
6580 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6581
6582 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6583 Use unsigned char, to match FcChar8 type definition.
6584
6585 * xterm.c (handle_one_xevent):
6586 * xmenu.c (create_and_show_popup_menu):
6587 * xselect.c (x_decline_selection_request)
6588 (x_reply_selection_request): Avoid type-punned deref of X events.
6589
6590 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6591
6592 Fix some uses of `int' instead of EMACS_INT.
6593 * search.c (string_match_1, fast_string_match)
6594 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6595 (scan_buffer, find_next_newline_no_quit)
6596 (find_before_next_newline, search_command, Freplace_match)
6597 (Fmatch_data): Make some `int' variables be EMACS_INT.
6598
6599 * xdisp.c (display_count_lines): 3rd argument and return value now
6600 EMACS_INT. All callers changed.
6601 (pint2hrstr): Last argument is now EMACS_INT.
6602
6603 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6604 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6605 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6606 (decode_coding_utf_16, decode_coding_emacs_mule)
6607 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6608 (decode_coding_ccl, decode_coding_charset)
6609 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6610 (decode_coding_iso_2022, decode_coding_emacs_mule)
6611 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6612 <char_offset, last_offset>: Declare EMACS_INT.
6613 (encode_coding_utf_8, encode_coding_utf_16)
6614 (encode_coding_emacs_mule, encode_invocation_designation)
6615 (encode_designation_at_bol, encode_coding_iso_2022)
6616 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6617 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6618 Declare EMACS_INT.
6619 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6620 (encode_invocation_designation): Last argument P_NCHARS is now
6621 EMACS_INT.
6622 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6623 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6624
6625 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6626 All users changed.
6627
6628 * ccl.c (Fccl_execute_on_string): Declare some variables
6629 EMACS_INT.
6630
6631 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6632
6633 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6634
6635 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6636
6637 * process.c (Fformat_network_address): Doc fix.
6638
6639 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6640
6641 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6642
6643 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6644
6645 * keyboard.c (read_char): Call Lisp function help-form-show,
6646 instead of using internal_with_output_to_temp_buffer.
6647 (Qhelp_form_show): New var.
6648 (syms_of_keyboard): Use DEFSYM macro.
6649
6650 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6651
6652 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6653
6654 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6655
6656 * process.c (Flist_processes): Remove to Lisp.
6657 (list_processes_1): Delete.
6658
6659 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6660
6661 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6662
6663 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6664
6665 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6666
6667 Fix more problems found by GCC 4.6.0's static checks.
6668
6669 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6670
6671 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6672
6673 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6674
6675 * xdisp.c (vmessage): Mark as a printf-like function.
6676
6677 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6678
6679 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6680
6681 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6682 printf-like functions.
6683 (tiff_load): Add casts to remove these marks before passing them
6684 to system-supplied API.
6685
6686 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6687
6688 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6689 This avoids several warnings with gcc -Wstrict-overflow.
6690 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6691 directly, rather than having caller test rule sign. This avoids
6692 some unnecessary tests.
6693 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6694 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6695 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6696
6697 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6698 (xfont_open): Avoid unnecessary tests.
6699
6700 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6701
6702 * composite.h, composite.c (composition_gstring_put_cache):
6703 Use EMACS_INT, not int, for length.
6704
6705 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6706 breaking out part of COMPOSITION_DECODE_RULE.
6707 (COMPOSITION_DECODE_RULE): Use it.
6708 * composite.c (get_composition_id): Remove unused local vars,
6709 by using the new macro.
6710
6711 * textprop.c (set_text_properties_1): Change while to do-while,
6712 since the condition is always true at first.
6713
6714 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6715 (interval_deletion_adjustment): Return unsigned value.
6716 All uses changed.
6717
6718 * process.c (list_processes_1, create_pty, read_process_output):
6719 (exec_sentinel): Remove vars that were set but not used.
6720 (create_pty): Remove unnecessary "volatile"s.
6721 (Fnetwork_interface_info): Avoid possibility of int overflow.
6722 (read_process_output): Do adaptive read buffering even if carryover.
6723 (read_process_output): Simplify nbytes computation if buffered.
6724
6725 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6726
6727 * syntax.c (scan_words): Remove var that was set but not used.
6728 (update_syntax_table): Use unsigned instead of int.
6729
6730 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6731 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6732 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6733
6734 * print.c (print_error_message): Avoid int overflow.
6735
6736 * font.c (font_list_entities): Redo for clarity,
6737 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6738
6739 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6740 (font_score): Avoid potential overflow in diff calculation.
6741
6742 * fns.c (substring_both): Remove var that is set but not used.
6743 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6744
6745 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6746
6747 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6748 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6749 can always succeed if overflow has undefined behavior.
6750
6751 * search.c (boyer_moore, wordify): Remove vars set but not used.
6752 (wordify): Omit three unnecessary tests.
6753
6754 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6755 All callers changed. This avoids the need for an unused var.
6756
6757 * casefiddle.c (casify_region): Remove var that is set but not used.
6758
6759 * dired.c (file_name_completion): Remove var that is set but not used.
6760
6761 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6762
6763 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6764 (Finsert_file_contents): Remove unnecessary code checking fd.
6765
6766 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6767 Check for integer overflow on size calculations.
6768
6769 * buffer.c (Fprevious_overlay_change): Remove var that is set
6770 but not used.
6771
6772 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6773 Remove vars that are set but not used.
6774 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6775 (timer_check_2): Mark vars as initialized.
6776
6777 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6778
6779 * image.c (lookup_image): Remove var that is set but not used.
6780 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6781
6782 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6783 that are set but not used.
6784
6785 * xfns.c (make_invisible_cursor): Don't return garbage
6786 if XCreateBitmapFromData fails (Bug#8410).
6787
6788 * xselect.c (x_get_local_selection, x_handle_property_notify):
6789 Remove vars that are set but not used.
6790
6791 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6792 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6793
6794 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6795 Remove var that is set but not used.
6796 (scroll_bar_windows_size): Now size_t, not int.
6797 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6798 Check for overflow.
6799
6800 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6801 (map_tty_color) [!defined MSDOS]: Likewise.
6802
6803 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6804
6805 * coding.c: Remove vars that are set but not used.
6806 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6807 All callers changed.
6808 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6809 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6810 (decode_coding_charset): Remove vars that are set but not used.
6811
6812 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6813 that is set but not used.
6814
6815 * print.c (print_object): Remove var that is set but not used.
6816
6817 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6818 The gnulib version avoids calling malloc in the usual case,
6819 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6820 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6821 * filelock.c (current_lock_owner): Likewise.
6822 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6823 * sysdep.c: Include allocator.h, careadlinkat.h.
6824 (emacs_no_realloc_allocator): New static constant.
6825 (emacs_readlink): New function.
6826 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6827 ../lib/careadlinkat.h.
6828
6829 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6830
6831 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6832 first non-nil return value).
6833
6834 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6835
6836 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6837 if not defined (Bug#8403).
6838
6839 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6840
6841 * xdisp.c (display_count_lines): Remove parameter `start',
6842 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6843 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6844 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6845 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6846 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6847 and thereabouts. All callers changed.
6848 (get_per_char_metric): Remove parameter `f', unused since
6849 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6850
6851 2011-04-02 Jim Meyering <meyering@redhat.com>
6852
6853 do not dereference NULL upon failed strdup
6854 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6855 (ns_get_family): Likewise.
6856
6857 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6858
6859 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6860
6861 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6862
6863 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6864 later (Bug#8403).
6865
6866 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6867
6868 Add lexical binding.
6869
6870 * window.c (Ftemp_output_buffer_show): New fun.
6871 (Fsave_window_excursion):
6872 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6873
6874 * lread.c (lisp_file_lexically_bound_p): New function.
6875 (Fload): Bind Qlexical_binding.
6876 (readevalloop): Remove `evalfun' arg.
6877 Bind Qinternal_interpreter_environment.
6878 (Feval_buffer): Bind Qlexical_binding.
6879 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6880 Mark as dynamic.
6881 (syms_of_lread): Declare `lexical-binding'.
6882
6883 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6884
6885 * keyboard.c (eval_dyn): New fun.
6886 (menu_item_eval_property): Use it.
6887
6888 * image.c (parse_image_spec): Use Ffunctionp.
6889
6890 * fns.c (concat, mapcar1): Accept byte-code-functions.
6891
6892 * eval.c (Fsetq): Handle lexical vars.
6893 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6894 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6895 (FletX, Flet): Obey lexical binding.
6896 (Fcommandp): Handle closures.
6897 (Feval): New `lexical' arg.
6898 (eval_sub): New function extracted from Feval. Use it almost
6899 everywhere where Feval was used. Look up vars in lexical env.
6900 Handle closures.
6901 (Ffunctionp): Move from subr.el.
6902 (Ffuncall): Handle closures.
6903 (apply_lambda): Remove `eval_flags'.
6904 (funcall_lambda): Handle closures and new byte-code-functions.
6905 (Fspecial_variable_p): New function.
6906 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6907 but without exporting it to Lisp.
6908
6909 * doc.c (Fdocumentation, store_function_docstring):
6910 * data.c (Finteractive_form): Handle closures.
6911
6912 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6913 interactive spec.
6914
6915 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6916 New byte-codes.
6917 (exec_byte_code): New function extracted from Fbyte_code to handle new
6918 calling convention for byte-code-functions. Add new byte-codes.
6919
6920 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6921
6922 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6923
6924 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6925
6926 * xdisp.c (redisplay_internal): Fix prototype.
6927
6928 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6929
6930 * xdisp.c (SCROLL_LIMIT): New macro.
6931 (try_scrolling): Use it when setting scroll_limit.
6932 Limit scrolling to 100 screen lines.
6933 (redisplay_window): Even when falling back on "recentering",
6934 position point in the window according to scroll-conservatively,
6935 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6936
6937 (try_scrolling): When point is above the window, allow searching
6938 as far as scroll_max, or one screenful, to compute vertical
6939 distance from PT to the scroll margin position. This prevents
6940 try_scrolling from unnecessarily failing when
6941 scroll-conservatively is set to a value slightly larger than the
6942 window height. Clean up the case of PT below the margin at bottom
6943 of window: scroll_max can no longer be INT_MAX. When aggressive
6944 scrolling is in use, don't let point enter the opposite scroll
6945 margin as result of the scroll.
6946 (syms_of_xdisp) <scroll-conservatively>: Document the
6947 threshold of 100 lines for never-recentering scrolling.
6948
6949 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6950
6951 * dispextern.h (move_it_by_lines):
6952 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6953 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6954 (message_log_check_duplicate): Remove parameters `prev_bol' and
6955 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6956 (redisplay_internal): Remove parameter `preserve_echo_area',
6957 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6958
6959 * indent.c (Fvertical_motion):
6960 * window.c (window_scroll_pixel_based, Frecenter):
6961 Don't pass `need_y_p' to `move_it_by_lines'.
6962
6963 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6964
6965 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6966 steal a few bits to be more compact.
6967 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6968 Remove unneeded casts.
6969
6970 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6971
6972 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6973
6974 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6975 binding" message (bug#7967).
6976
6977 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6978
6979 Fix more problems found by GCC 4.6.0's static checks.
6980
6981 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6982 Remove unused local var.
6983
6984 * editfns.c (Fmessage_box): Remove unused local var.
6985
6986 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6987 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6988 Omit unused local vars.
6989 * window.c (shrink_windows): Omit unused local var.
6990 * menu.c (digest_single_submenu): Omit unused local var.
6991 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6992 Omit unused local var.
6993
6994 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6995 Don't assume string length fits in int.
6996 (keyremap_step, read_key_sequence): Use size_t for sizes.
6997 (read_key_sequence): Don't check last_real_key_start redundantly.
6998
6999 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7000 instead of alloca (Bug#8344).
7001
7002 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7003 (Fbacktrace_frame): Don't assume nframes fits in int.
7004
7005 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7006
7007 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7008 concerns.
7009
7010 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7011
7012 * cm.c (calccost): Turn while-do into do-while, for clarity.
7013
7014 * keyboard.c (syms_of_keyboard): Use the same style as later
7015 in this function when indexing through an array. This also
7016 works around GCC bug 48267.
7017
7018 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7019
7020 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7021
7022 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7023 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7024
7025 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7026 This avoids undefined behavior on integer overflow, and is a bit
7027 more convenient anyway since it is compared to a size_t variable.
7028
7029 Variadic C functions now count arguments with size_t, not int.
7030 This avoids an unnecessary limitation on 64-bit machines, which
7031 caused (substring ...) to crash on large vectors (Bug#8344).
7032 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7033 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7034 All variadic functions and their callers changed accordingly.
7035 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7036 * data.c (arith_driver, float_arith_driver): Likewise.
7037 * editfns.c (general_insert_function): Likewise.
7038 * eval.c (struct backtrace.nargs, interactive_p)
7039 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7040 (funcall_lambda, mark_backtrace): Likewise.
7041 * fns.c (concat): Likewise.
7042 * frame.c (x_set_frame_parameters): Likewise.
7043 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7044 0 if not found, not -1. All callers changed.
7045
7046 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7047 (stack_copy_size): Now size_t, not int.
7048 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7049
7050 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7051
7052 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7053 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7054 All callers changed.
7055
7056 * lisp.h (multibyte_char_to_unibyte):
7057 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7058 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7059 * character.h (CHAR_TO_BYTE8):
7060 * cmds.c (internal_self_insert):
7061 * editfns.c (general_insert_function):
7062 * keymap.c (push_key_description):
7063 * search.c (Freplace_match):
7064 * xdisp.c (message_dolog, set_message_1): All callers changed.
7065
7066 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7067
7068 * keyboard.c (safe_run_hook_funcall): New function.
7069 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7070 don't set the hook to nil, but remove the offending function instead.
7071 (Qcommand_hook_internal): Remove, unused.
7072 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7073 Vcommand_hook_internal.
7074
7075 * eval.c (enum run_hooks_condition): Remove.
7076 (funcall_nil, funcall_not): New functions.
7077 (run_hook_with_args): Call each function through a `funcall' argument.
7078 Remove `cond' argument, now redundant.
7079 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7080 (Frun_hook_with_args_until_failure): Adjust accordingly.
7081 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7082
7083 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7084
7085 * dispextern.h (string_buffer_position): Remove declaration.
7086
7087 * print.c (strout): Remove parameter `multibyte', unused since
7088 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7089
7090 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7091 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7092 All callers changed.
7093
7094 * w32.c (_wsa_errlist): Use braces for struct initializers.
7095
7096 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7097 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7098 All callers changed.
7099 (string_buffer_position): Likewise. Also, make static (it's never
7100 used outside xdisp.c).
7101 (cursor_row_p): Remove parameter `w', unused since
7102 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7103 (decode_mode_spec): Remove parameter `precision', introduced during
7104 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7105 All callers changed.
7106
7107 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7108
7109 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7110
7111 2011-03-27 Anders Lindgren <andlind@gmail.com>
7112
7113 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7114 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7115 (ns_update_auto_hide_menu_bar): New functions.
7116 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7117 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7118 ns_constrain_all_frames.
7119 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7120 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7121
7122 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7123
7124 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7125
7126 2011-03-27 Glenn Morris <rgm@gnu.org>
7127
7128 * syssignal.h: Replace RETSIGTYPE with void.
7129 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7130 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7131 Replace SIGTYPE with void everywhere.
7132 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7133 * s/template.h (SIGTYPE): Remove commented out definition.
7134
7135 2011-03-26 Eli Zaretskii <eliz@gnu.org>
7136
7137 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7138 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7139
7140 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
7141
7142 * w32.c (read_unc_volume): Use parameter `henum', instead of
7143 global variable `wget_enum_handle'.
7144
7145 * keymap.c (describe_vector): Remove parameters `indices' and
7146 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7147 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7148
7149 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7150
7151 * keyboard.c (timer_check): Remove parameter `do_it_now',
7152 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7153 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7154 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7155
7156 * keyboard.c (read_char):
7157 * w32menu.c (w32_menu_display_help):
7158 * xmenu.c (show_help_event, menu_help_callback):
7159 Adjust calls to `show_help_echo'.
7160
7161 * gtkutil.c (xg_maybe_add_timer):
7162 * keyboard.c (readable_events):
7163 * process.c (wait_reading_process_output):
7164 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7165
7166 * insdel.c (adjust_markers_gap_motion):
7167 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7168 (gap_left, gap_right): Don't call it.
7169
7170 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
7171
7172 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7173 incurred during fontification.
7174
7175 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7176
7177 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7178 (DEFVAR_PER_BUFFER): Don't pass it.
7179
7180 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7181 (scrolling_window): Don't pass it.
7182
7183 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7184
7185 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7186
7187 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7188 and `suffix'.
7189 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7190 of variables specific to SELinux and computation of `encoded_absname'.
7191
7192 * image.c (XPutPixel): Remove unused variable `height'.
7193
7194 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7195
7196 * unexw32.c (get_section_info): Remove unused variable `section'.
7197
7198 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7199 (system_process_attributes): Remove unused variable `sess'.
7200 (sys_read): Remove unused variable `err'.
7201
7202 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7203 (w32_wnd_proc): Remove unused variable `isdead'.
7204 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7205 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7206 (x_create_tip_frame): Remove unused variable `tem'.
7207
7208 * w32inevt.c (w32_console_read_socket):
7209 Remove unused variable `no_events'.
7210
7211 * w32term.c (x_draw_composite_glyph_string_foreground):
7212 Remove unused variable `width'.
7213
7214 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
7215
7216 * w32term.c (x_set_glyph_string_clipping):
7217 Don't pass uninitialized region to CombineRgn.
7218
7219 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
7220
7221 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7222 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7223 (Fx_close_connection): Remove unused variable `i'.
7224
7225 * w32font.c (w32font_draw): Return number of glyphs.
7226 (w32font_open_internal): Remove unused variable `i'.
7227 (w32font_driver): Add missing initializer.
7228
7229 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7230 (fill_in_menu): Remove unused variable `items_added'.
7231
7232 * w32term.c (last_mouse_press_frame): Remove static global variable.
7233 (w32_clip_to_row): Remove unused variable `f'.
7234 (x_delete_terminal): Remove unused variable `i'.
7235
7236 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7237 (NOTHING): Remove unused static global variable.
7238 (uniscribe_check_otf): Remove unused variable `table'.
7239 (uniscribe_font_driver): Add missing initializers.
7240
7241 2011-03-23 Julien Danjou <julien@danjou.info>
7242
7243 * term.c (Fsuspend_tty, Fresume_tty):
7244 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7245 * window.c (temp_output_buffer_show):
7246 * insdel.c (signal_before_change):
7247 * frame.c (Fhandle_switch_frame):
7248 * fileio.c (Fdo_auto_save):
7249 * emacs.c (Fkill_emacs):
7250 * editfns.c (save_excursion_restore):
7251 * cmds.c (internal_self_insert):
7252 * callint.c (Fcall_interactively):
7253 * buffer.c (Fkill_all_local_variables):
7254 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7255 Use Frun_hooks.
7256 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
7257 unconditionnaly since it does the check itself.
7258
7259 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
7260
7261 Fix more problems found by GCC 4.5.2's static checks.
7262
7263 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7264 the first time through the loop, since we know p0 < p1 then.
7265 This also avoids a gcc -Wstrict-overflow warning.
7266
7267 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7268 leading to a memory leak, possible in functions like
7269 load_charset_map_from_file that can allocate an unbounded number
7270 of objects (Bug#8318).
7271
7272 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7273 that could (at least in theory) be that large.
7274
7275 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7276 This is less likely to overflow, and avoids undefined behavior if
7277 overflow does occur. All callers changed. Use strtoul to scan
7278 for the unsigned long integer.
7279 (pint2hrstr): Simplify and tune code slightly.
7280 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
7281
7282 * scroll.c (do_scrolling): Work around GCC bug 48228.
7283 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7284
7285 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7286 This also avoids a warning with gcc -Wstrict-overflow.
7287 (validate_x_resource_name): Simplify count usage.
7288 This also avoids a warning with gcc -Wstrict-overflow.
7289
7290 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7291 fail (Bug#8306).
7292
7293 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
7294
7295 * process.c (Fmake_network_process): Use socklen_t, not int,
7296 where POSIX says socklen_t is required in portable programs.
7297 This fixes a porting bug on hosts like 64-bit HP-UX, where
7298 socklen_t is wider than int (Bug#8277).
7299 (Fmake_network_process, server_accept_connection):
7300 (wait_reading_process_output, read_process_output):
7301 Likewise.
7302
7303 * process.c: Rename or move locals to avoid shadowing.
7304 (list_processes_1, Fmake_network_process):
7305 (read_process_output_error_handler, exec_sentinel_error_handler):
7306 Rename or move locals.
7307 (Fmake_network_process): Define label "retry_connect" only if needed.
7308 (Fnetwork_interface_info): Fix pointer signedness.
7309 (process_send_signal): Add cast to avoid pointer signedness problem.
7310 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
7311 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
7312
7313 Make tparam.h and terminfo.c consistent.
7314 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7315 Include tparam.h instead, since it declares them.
7316 * cm.h (PC): Remove extern decl; tparam.h now does this.
7317 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7318 * terminfo.c: Include tparam.h, to check interfaces.
7319 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7320 (tparam): Adjust signature to match interface in tparam.h;
7321 this removes some undefined behavior. Check that outstring and len
7322 are zero, which they always are with Emacs.
7323 * tparam.h (PC, BC, UP): New extern decls.
7324
7325 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
7326 (xftfont_open): Rename locals to avoid shadowing.
7327
7328 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
7329 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7330 (OTF_TAG_SYM): Omit macro if not needed.
7331 (ftfont_list): Remove unused local.
7332 (get_adstyle_property, ftfont_pattern_entity):
7333 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7334 Rename locals to avoid shadowing.
7335
7336 * xfont.c (xfont_list_family): Mark var as initialized.
7337
7338 * xml.c (make_dom): Now static.
7339
7340 * composite.c (composition_compute_stop_pos): Rename local to
7341 avoid shadowing.
7342 (composition_reseat_it): Remove unused locals.
7343 (find_automatic_composition, composition_adjust_point): Likewise.
7344 (composition_update_it): Mark var as initialized.
7345 (find_automatic_composition): Mark vars as initialized,
7346 with a FIXME (Bug#8290).
7347
7348 character.h: Rename locals to avoid shadowing.
7349 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7350 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7351 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7352 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7353 to avoid shadowing.
7354
7355 * textprop.c (property_change_between_p): Remove; unused.
7356
7357 * intervals.c (interval_start_pos): Now static.
7358
7359 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7360
7361 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7362 Rename locals to avoid shadowing.
7363
7364 * sound.c (wav_play, au_play, Fplay_sound_internal):
7365 Fix pointer signedness.
7366 (alsa_choose_format): Remove unused local var.
7367 (wav_play): Initialize a variable to 0, to prevent undefined
7368 behavior (Bug#8278).
7369
7370 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7371
7372 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7373
7374 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7375 clobbering (Bug#8298).
7376 * sysdep.c (sys_subshell): Likewise.
7377 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7378
7379 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7380 This should get cleaned up, so that child_setup has the
7381 same signature on all platforms.
7382
7383 * callproc.c (call_process_cleanup): Now static.
7384 (relocate_fd): Rename locals to avoid shadowing.
7385
7386 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7387
7388 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7389 not to be necessary, and produces flickering.
7390
7391 2011-03-20 Glenn Morris <rgm@gnu.org>
7392
7393 * config.in: Remove file.
7394
7395 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7396
7397 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7398 are now in src/globals.h.
7399 (syms_of_minibuf): Remove spurious & from previous change.
7400
7401 2011-03-20 Leo <sdl.web@gmail.com>
7402
7403 * minibuf.c (completing-read-function): New variable.
7404 (completing-read-default): Rename from completing-read.
7405 (completing-read): Call completing-read-function.
7406
7407 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7408
7409 * xfaces.c (Fx_load_color_file):
7410 Read color file from absolute filename (bug#8250).
7411
7412 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7413
7414 * makefile.w32-in: Update dependencies.
7415
7416 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7417
7418 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7419
7420 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7421
7422 Fix more problems found by GCC 4.5.2's static checks.
7423
7424 * process.c (make_serial_process_unwind, send_process_trap):
7425 (sigchld_handler): Now static.
7426
7427 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7428 That way, the code declares only the vars that it needs.
7429 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7430 * s/cygwin.h (PTY_ITERATION): Likewise.
7431 * s/darwin.h (PTY_ITERATION): Likewise.
7432 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7433
7434 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7435 * process.c (allocate_pty): Don't declare stb unless it's needed.
7436
7437 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7438 (CONSTANTLIM): Remove; unused.
7439 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7440 Define only if needed.
7441
7442 * unexelf.c (unexec): Name an expression,
7443 to avoid gcc -Wbad-function-cast warning.
7444 Use a different way to cause a compilation error if anyone uses
7445 n rather than nn, a way that does not involve shadowing.
7446 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7447
7448 * deps.mk (unexalpha.o): Remove; unused.
7449
7450 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7451 * unexec.h: New file.
7452 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7453 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7454 Depend on unexec.h.
7455 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7456 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7457 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7458 Change as necessary to match prototype in unexec.h.
7459
7460 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7461 shadowing.
7462 (back_comment, skip_chars): Mark vars as initialized.
7463
7464 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7465 Rename locals to avoid shadowing.
7466
7467 * lread.c (read1): Rewrite so as not to use empty "else".
7468 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7469
7470 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7471
7472 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7473 warning when compiling print.c.
7474
7475 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7476 instead of using an uninitialized var.
7477 (font_sort_entities): Mark var as initialized.
7478
7479 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7480
7481 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7482 pointers to constants.
7483 (font_parse_fcname): Remove unused vars.
7484 (font_delete_unmatched): Now static.
7485 (font_get_spec): Remove; unused.
7486 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7487 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7488 Rename or move locals to avoid shadowing.
7489
7490 * fns.c (require_nesting_list, require_unwind): Now static.
7491 (Ffillarray): Rename locals to avoid shadowing.
7492
7493 * floatfns.c (domain_error2): Define only if needed.
7494 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7495
7496 * alloc.c (mark_backtrace): Move decl from here ...
7497 * lisp.h: ... to here, so that it can be checked.
7498
7499 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7500 (Fdefvar): Rewrite so as not to use empty "else".
7501 (lisp_indirect_variable): Name an expression,
7502 to avoid gcc -Wbad-function-cast warning.
7503 (Fdefvar): Rename locals to avoid shadowing.
7504
7505 * callint.c (quotify_arg, quotify_args): Now static.
7506 (Fcall_interactively): Rename locals to avoid shadowing.
7507 Use const pointer when appropriate.
7508
7509 * lisp.h (get_system_name, get_operating_system_release):
7510 Move decls here, to check interfaces.
7511 * process.c (get_operating_system_release): Move decl to lisp.h.
7512 * xrdb.c (get_system_name): Likewise.
7513 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7514 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7515 some of which prompt warnings from gcc -Wbad-function-cast.
7516 (Fformat_time_string, Fencode_time, Finsert_char):
7517 (Ftranslate_region_internal, Fformat):
7518 Rename or remove local vars to avoid shadowing.
7519 (Ftranslate_region_internal): Mark var as initialized.
7520
7521 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7522 avoid shadowing.
7523
7524 * lisp.h (eassert): Check that the argument compiles, even if
7525 ENABLE_CHECKING is not defined.
7526
7527 * data.c (Findirect_variable): Name an expression, to avoid
7528 gcc -Wbad-function-cast warning.
7529 (default_value, arithcompare, arith_driver, arith_error): Now static.
7530 (store_symval_forwarding): Rename local to avoid shadowing.
7531 (Fmake_variable_buffer_local, Fmake_local_variable):
7532 Mark variables as initialized.
7533 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7534
7535 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7536 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7537 Rename locals to avoid shadowing.
7538 (mark_stack): Move local variables into the #ifdef region where
7539 they're used.
7540 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7541 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7542 needed otherwise.
7543 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7544 (GC_STRING_CHARS): Remove; not used.
7545 (Fmemory_limit): Cast sbrk's returned value to char *.
7546
7547 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7548 avoids undefined behavior in theory.
7549
7550 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7551
7552 Use functions, not macros, for up- and down-casing (Bug#8254).
7553 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7554 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7555 to use the following functions instead of these macros.
7556 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7557 EMACS_INT, since callers assume the returned value fits in int.
7558 (upcase1): Likewise, for UPCASE_TABLE.
7559 (uppercasep, lowercasep, upcase): New static inline functions.
7560 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7561 the race-condition problem in the old DOWNCASE.
7562
7563 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7564 Rename locals to avoid shadowing.
7565 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7566 (regex_compile, re_search_2, re_match_2_internal):
7567 Remove unused local vars.
7568 (FREE_VAR): Rewrite so as not to use empty "else",
7569 which gcc can warn about.
7570 (regex_compile, re_match_2_internal): Mark locals as initialized.
7571 (RETALLOC_IF): Define only if needed.
7572 (WORDCHAR_P): Likewise. This one is never needed, but is used
7573 only in a comment talking about a compiler bug, so put inside
7574 the #if 0 of that comment.
7575 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7576 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7577 Remove; unused.
7578
7579 * search.c (boyer_moore): Rename locals to avoid shadowing.
7580 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7581 (PREV_CHAR_BOUNDARY): Likewise.
7582
7583 * search.c (simple_search): Remove unused var.
7584
7585 * dired.c (compile_pattern): Move decl from here ...
7586 * lisp.h: ... to here, so that it can be checked.
7587 (struct re_registers): New forward decl.
7588
7589 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7590
7591 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7592 All uses changed.
7593 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7594 Rename locals to avoid shadowing.
7595 (Fvertical_motion): Mark locals as initialized.
7596
7597 * casefiddle.c (casify_object, casify_region): Now static.
7598 (casify_region): Mark local as initialized.
7599
7600 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7601
7602 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7603 New macros, so that the caller can use some names other than
7604 gcpro1, gcpro2, etc.
7605 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7606 of the new macros.
7607 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7608 argument, for consistency with GCPRO2_VAR, etc: it is now the
7609 prefix of the variable, not the variable itself. All uses
7610 changed.
7611 * dired.c (directory_files_internal, file_name_completion):
7612 Rename locals to avoid shadowing.
7613
7614 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7615 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7616 dired.c's scmp function, had undefined behavior.
7617 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7618 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7619 * buffer.h: ... to here, because these macros use current_buffer,
7620 and the new implementation with inline functions needs to have
7621 current_buffer in scope now, rather than later when the macros
7622 are used.
7623 (downcase, upcase1): New static inline functions.
7624 (DOWNCASE, UPCASE1): Reimplement using these functions.
7625 This avoids undefined behavior in expressions like
7626 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7627 from race conditions in accessing the global variables
7628 case_temp1 and case_temp2.
7629 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7630 * lisp.h (case_temp1, case_temp2): Remove their decls.
7631 * character.h (ASCII_CHAR_P): Move from here ...
7632 * lisp.h: ... to here, so that the inline functions mentioned
7633 above can use them.
7634
7635 * dired.c (directory_files_internal_unwind): Now static.
7636
7637 * fileio.c (file_name_as_directory, directory_file_name):
7638 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7639 Now static.
7640 (file_name_as_directory): Use const pointers when appropriate.
7641 (Fexpand_file_name): Likewise. In particular, newdir might
7642 point at constant storage, so make it a const pointer.
7643 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7644 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7645 signedness issues.
7646 (Fset_file_times, Finsert_file_contents, auto_save_error):
7647 Rename locals to avoid shadowing.
7648
7649 * minibuf.c (choose_minibuf_frame_1): Now static.
7650 (Ftry_completion, Fall_completions): Rename or remove locals
7651 to avoid shadowing.
7652
7653 * marker.c (bytepos_to_charpos): Remove; unused.
7654
7655 * lisp.h (verify_bytepos, count_markers): New decls,
7656 so that gcc does not warn that these functions aren't declared.
7657
7658 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7659 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7660 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7661 (copy_text): Remove unused local var.
7662
7663 * filelock.c (within_one_second): Now static.
7664 (lock_file_1): Rename local to avoid shadowing.
7665
7666 * buffer.c (fix_overlays_before): Mark locals as initialized.
7667 (fix_start_end_in_overlays): Likewise. This function should be
7668 simplified by using pointers-to-pointers, but that's a different
7669 matter.
7670 (switch_to_buffer_1): Now static.
7671 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7672 (report_overlay_modification): Rename locals to avoid shadowing.
7673
7674 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7675 Fix pointer signedness issue.
7676 (sys_subshell): Mark local as volatile if checking for lint,
7677 to suppress a gcc -Wclobbered warning that does not seem to be right.
7678 (MAXPATHLEN): Define only if needed.
7679
7680 * process.c (serial_open, serial_configure): Move decls from here ...
7681 * systty.h: ... to here, so that they can be checked.
7682
7683 * fns.c (get_random, seed_random): Move extern decls from here ...
7684 * lisp.h: ... to here, so that they can be checked.
7685
7686 * sysdep.c (reset_io): Now static.
7687 (wait_for_termination_signal): Remove; unused.
7688
7689 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7690 (copy_keymap_item, append_key, push_text_char_description):
7691 Now static.
7692 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7693 (DENSE_TABLE_SIZE): Remove; unused.
7694 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7695 (describe_map_tree):
7696 Rename locals to avoid shadowing.
7697
7698 * keyboard.c: Declare functions static if they are not used elsewhere.
7699 (echo_char, echo_dash, cmd_error, top_level_2):
7700 (poll_for_input, handle_async_input): Now static.
7701 (read_char, kbd_buffer_get_event, make_lispy_position):
7702 (make_lispy_event, make_lispy_movement, apply_modifiers):
7703 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7704 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7705 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7706 (read_key_sequence, read_char): Mark locals as initialized.
7707 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7708
7709 * keyboard.h (make_ctrl_char): New decl.
7710 (mark_kboards): Move decl here ...
7711 * alloc.c (mark_kboards): ... from here.
7712
7713 * lisp.h (force_auto_save_soon): New decl.
7714
7715 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7716 (DEFINE_DUMMY_FUNCTION): New macro.
7717 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7718 Use it.
7719 (main): Add casts to avoid warnings
7720 if GCC considers string literals to be constants.
7721
7722 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7723
7724 * dbusbind.c: Pointer signedness fixes.
7725 (xd_signature, xd_append_arg, xd_initialize):
7726 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7727 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7728 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7729 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7730
7731 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7732 if GCC considers string literals to be constants.
7733 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7734
7735 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7736
7737 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7738 (print_preprocess, print_object): New macro to fix last change.
7739
7740 * print.c (print_preprocess): Don't forget font objects.
7741
7742 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7743
7744 * emacs.c (USAGE3): Doc fixes.
7745
7746 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7747
7748 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7749 structure.
7750
7751 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7752
7753 * lisp.h (VWindow_system, Qfile_name_history):
7754 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7755 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7756 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7757
7758 * w32select.c: Don't #include "keyboard.h".
7759 (run_protected): Add extern declaration for waiting_for_input.
7760
7761 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7762 * w32console.c (detect_input_pending, read_input_pending)
7763 (encode_terminal_code):
7764 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7765 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7766 (w32_system_caret_y, Qfile_name_history):
7767 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7768 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7769 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7770 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7771 * w32proc.c (Qlocal, report_file_error):
7772 * w32term.c (Vwindow_system, updating_frame):
7773 * w32uniscribe.c (initialized, uniscribe_font_driver):
7774 Remove unneeded extern declarations.
7775
7776 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7777
7778 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7779
7780 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7781
7782 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7783 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7784 These macros can no longer be used for assignment.
7785
7786 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7787 Assign struct members directly, instead of using BUF_BEGV etc.
7788 (record_buffer_markers, fetch_buffer_markers): New functions for
7789 recording and fetching special buffer markers.
7790 (set_buffer_internal_1, set_buffer_temp): Use them.
7791
7792 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7793
7794 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7795
7796 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7797 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7798
7799 * xdisp.c (hscroll_window_tree):
7800 (reconsider_clip_changes): Use PT instead of BUF_PT.
7801
7802 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7803
7804 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7805 $(EMACS_ROOT)/lib/intprops.h.
7806
7807 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7808
7809 Fix more problems found by GCC 4.5.2's static checks.
7810
7811 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7812 to unsigned char * to avoid compiler diagnostic.
7813 (xg_free_frame_widgets): Make it clear that a local variable is
7814 needed only if USE_GTK_TOOLTIP.
7815 (gdk_window_get_screen): Make it clear that this macro is needed
7816 only if USE_GTK_TOOLTIP.
7817 (int_gtk_range_get_value): New function, which avoids a diagnostic
7818 from gcc -Wbad-function-cast.
7819 (xg_set_toolkit_scroll_bar_thumb): Use it.
7820 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7821 diagnostic from gcc -Wbad-function-cast.
7822 (get_utf8_string, xg_get_file_with_chooser):
7823 Rename locals to avoid shadowing.
7824 (create_dialog): Move locals to avoid shadowing.
7825
7826 * xgselect.c (xg_select): Remove unused var.
7827
7828 * image.c (four_corners_best): Mark locals as initialized.
7829 (gif_load): Initialize transparent_p to zero (Bug#8238).
7830 Mark another local as initialized.
7831 (my_png_error, my_error_exit): Mark with NO_RETURN.
7832
7833 * image.c (clear_image_cache): Now static.
7834 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7835 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7836 (x_edge_detection): Remove unnecessary cast that
7837 gcc -Wbad-function-cast diagnoses.
7838 (gif_load): Fix pointer signedness.
7839 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7840 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7841
7842 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7843
7844 Improve quality of tests for time stamp overflow.
7845 For example, without this patch (encode-time 0 0 0 1 1
7846 1152921504606846976) returns the obviously-bogus value (-948597
7847 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7848 reports time overflow. See
7849 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7850 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7851 * editfns.c: Include limits.h and intprops.h.
7852 (TIME_T_MIN, TIME_T_MAX): New macros.
7853 (time_overflow): Move earlier, to before first use.
7854 (hi_time, lo_time): New functions, for an accurate test for
7855 out-of-range times.
7856 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7857 (Fget_internal_run_time): Don't assume time_t fits in int.
7858 (make_time): Use list2 instead of Fcons twice.
7859 (Fdecode_time): More accurate test for out-of-range times.
7860 (check_tm_member): New function.
7861 (Fencode_time): Use it, to test for out-of-range times.
7862 (lisp_time_argument): Don't rely on undefined left-shift and
7863 right-shift behavior when checking for time stamp overflow.
7864
7865 * editfns.c (time_overflow): New function, refactoring common code.
7866 (Fformat_time_string, Fdecode_time, Fencode_time):
7867 (Fcurrent_time_string): Use it.
7868
7869 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7870 * dired.c (make_time): Move to ...
7871 * editfns.c (make_time): ... here.
7872 * systime.h: Note the move.
7873
7874 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7875
7876 * fringe.c (update_window_fringes): Remove unused variables.
7877
7878 * unexmacosx.c (copy_data_segment): Also copy __got section.
7879 (Bug#8223)
7880
7881 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7882
7883 * termcap.c [MSDOS]: Include "msdos.h".
7884 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7885 Constify `char *' arguments and their references according to
7886 prototypes in tparam.h.
7887
7888 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7889
7890 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7891 Adapt all references accordingly.
7892
7893 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7894
7895 2011-03-11 Tom Tromey <tromey@redhat.com>
7896
7897 * buffer.c (syms_of_buffer): Remove obsolete comment.
7898
7899 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7900
7901 * termhooks.h (encode_terminal_code): Declare prototype.
7902
7903 * msdos.c (encode_terminal_code): Don't declare prototype.
7904
7905 * term.c (encode_terminal_code): Now external again, used by
7906 w32console.c and msdos.c.
7907
7908 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7909 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7910
7911 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7912
7913 Fix some minor problems found by GCC 4.5.2's static checks.
7914
7915 * fringe.c (update_window_fringes): Mark locals as initialized
7916 (Bug#8227).
7917 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7918
7919 * alloc.c (mark_fringe_data): Move decl from here ...
7920 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7921 to check its interface.
7922 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7923
7924 * fontset.c (free_realized_fontset): Now static.
7925 (Fset_fontset_font): Rename local to avoid shadowing.
7926 (fontset_font): Mark local as initialized.
7927 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7928
7929 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7930
7931 * xselect.c (x_disown_buffer_selections): Remove; not used.
7932 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7933 (x_own_selection, Fx_disown_selection_internal): Rename locals
7934 to avoid shadowing.
7935 (x_handle_dnd_message): Remove local to avoid shadowing.
7936
7937 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7938 so that the caller can use some name other than gcpro1.
7939 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7940 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7941 (Fx_backspace_delete_keys_p):
7942 Use them to avoid shadowing, and rename vars to avoid shadowing.
7943 (x_decode_color, x_set_name, x_window): Now static.
7944 (Fx_create_frame): Add braces to silence GCC warning.
7945 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7946 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7947 Remove unused locals.
7948 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7949 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7950 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7951 macros.
7952
7953 * xterm.h (x_mouse_leave): New decl.
7954
7955 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7956 Remove unused functions.
7957 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7958 (x_calc_absolute_position): Now static.
7959 (XTread_socket): Don't define label "out" unless it's used.
7960 Don't declare local "event" unless it's used.
7961 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7962 unless they are used.
7963 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7964 (x_fatal_error_signal): Remove; not used.
7965 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7966 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7967 (x_error_catcher, x_connection_closed, x_error_handler):
7968 (x_error_quitter, xembed_send_message, x_iconify_frame):
7969 (my_log_handler): Rename locals to avoid shadowing.
7970 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7971 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7972
7973 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7974 Rename or move locals to avoid shadowing.
7975 (tty_defined_color, merge_face_heights): Now static.
7976 (free_realized_faces_for_fontset): Remove; not used.
7977 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7978 does not deduce is never used uninitialized.
7979 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7980 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7981
7982 * terminal.c (store_terminal_param): Now static.
7983
7984 * xmenu.c (menu_highlight_callback): Now static.
7985 (set_frame_menubar): Remove unused local.
7986 (xmenu_show): Rename parameter to avoid shadowing.
7987 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7988 since they might point to immutable storage.
7989 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7990 since it's unused otherwise.
7991
7992 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7993 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7994 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7995 avoids a gcc -Wuninitialized diagnostic.
7996 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7997 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7998 does not deduce are never used uninitialized.
7999
8000 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8001
8002 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8003 * window.c (window_loop, size_window):
8004 (run_window_configuration_change_hook, enlarge_window): Likewise.
8005
8006 * window.c (display_buffer): Now static.
8007 (size_window): Mark variables that gcc -Wuninitialized
8008 does not deduce are never used uninitialized.
8009 * window.h (check_all_windows): New decl, to forestall
8010 gcc -Wmissing-prototypes diagnostic.
8011 * dispextern.h (bidi_dump_cached_states): Likewise.
8012
8013 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8014 shadowing.
8015 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8016 Include <limits.h>.
8017 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8018 and to avoid gcc -Wuninitialized warning.
8019 (load_charset_map): Mark variables that gcc -Wuninitialized
8020 does not deduce are never used uninitialized.
8021 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8022
8023 * coding.c (coding_set_source, coding_set_destination):
8024 Use "else { /* comment */ }" rather than "else /* comment */;"
8025 for clarity, and to avoid gcc -Wempty-body warning.
8026 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8027 a block, when the outer 'i' will do.
8028 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8029 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8030 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8031 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8032 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8033 Rename locals to avoid shadowing.
8034 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8035 * coding.c (emacs_mule_char, encode_invocation_designation):
8036 Now static, since they're not used elsewhere.
8037 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8038 (decode_coding_object, encode_coding_object, detect_coding_system):
8039 (decode_coding_emacs_mule): Mark variables that gcc
8040 -Wuninitialized does not deduce are never used uninitialized.
8041 (detect_coding_iso_2022): Initialize a local variable that might
8042 be used uninitialized. Leave a FIXME because it's not clear that
8043 this initialization is needed. (Bug#8211)
8044 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8045 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8046 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8047 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8048 Remove unused macros.
8049
8050 * category.c (hash_get_category_set): Remove unused local var.
8051 (copy_category_table): Now static, since it's not used elsewhere.
8052 * character.c (string_count_byte8): Likewise.
8053
8054 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8055 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8056
8057 * chartab.c (copy_sub_char_table): Now static, since it's not used
8058 elsewhere.
8059 (sub_char_table_ref_and_range, char_table_ref_and_range):
8060 Rename locals to avoid shadowing.
8061 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8062
8063 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8064 (BIDI_BOB): Remove unused macro.
8065
8066 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8067 deduce are never used uninitialized.
8068 * term.c (encode_terminal_code): Likewise.
8069
8070 * term.c (encode_terminal_code): Now static. Remove unused local.
8071
8072 * tparam.h: New file.
8073 * term.c, tparam.h: Include it.
8074 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8075 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8076 Move these decls to tparam.h, and make them agree with what
8077 is actually in tparam.c. The previous trick of using incompatible
8078 decls in different modules does not conform to the C standard.
8079 All callers of tparam changed to use tparam's actual API.
8080 * tparam.c (tparam1, tparam, tgoto):
8081 Use const pointers where appropriate.
8082
8083 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8084 * cm.h (struct cm): Likewise.
8085 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8086 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8087 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8088 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8089 (turn_on_face, init_tty): Likewise.
8090 * termchar.h (struct tty_display_info): Likewise.
8091
8092 * term.c (term_mouse_position): Rename local to avoid shadowing.
8093
8094 * alloc.c (mark_ttys): Move decl from here ...
8095 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8096
8097 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8098
8099 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8100
8101 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
8102
8103 * search.c (compile_pattern_1): Remove argument regp, unused since
8104 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8105 (compile_pattern): Don't pass it.
8106
8107 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8108
8109 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8110 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8111 for ! HAVE_GTK3.
8112 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8113
8114 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8115
8116 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8117 gdk_window_get_screen, gdk_window_get_geometry,
8118 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8119 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8120 (xg_get_pixbuf_from_pixmap): New function.
8121 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8122 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8123 Call xg_get_pixbuf_from_pixmap instead of
8124 gdk_pixbuf_get_from_drawable.
8125 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8126 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8127 (xg_check_special_colors): Use GtkStyleContext and its functions
8128 for HAVE_GTK3.
8129 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8130 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8131 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
8132 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8133 Call gtk_widget_get_preferred_size.
8134 (xg_frame_resized): gdk_window_get_geometry only takes 5
8135 parameters.
8136 (xg_win_to_widget, xg_event_is_for_menubar):
8137 Call gdk_x11_window_lookup_for_display.
8138 (xg_set_widget_bg): New function.
8139 (delete_cb): New function.
8140 (xg_create_frame_widgets): Connect delete-event to delete_cb.
8141 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8142 (xg_set_background_color): Call xg_set_widget_bg.
8143 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8144 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8145 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8146 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8147 if ! HAVE_GTK3.
8148 (update_frame_tool_bar): Call gtk_widget_hide.
8149 (xg_initialize): Use GDK_KEY_g.
8150
8151 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8152 if ! HAVE_GTK3
8153 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8154
8155 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8156 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8157 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8158
8159 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
8160
8161 * w32xfns.c (select_palette): Check success of RealizePalette against
8162 GDI_ERROR, not zero.
8163
8164 See ChangeLog.11 for earlier changes.
8165
8166 ;; Local Variables:
8167 ;; coding: utf-8
8168 ;; End:
8169
8170 Copyright (C) 2011 Free Software Foundation, Inc.
8171
8172 This file is part of GNU Emacs.
8173
8174 GNU Emacs is free software: you can redistribute it and/or modify
8175 it under the terms of the GNU General Public License as published by
8176 the Free Software Foundation, either version 3 of the License, or
8177 (at your option) any later version.
8178
8179 GNU Emacs is distributed in the hope that it will be useful,
8180 but WITHOUT ANY WARRANTY; without even the implied warranty of
8181 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8182 GNU General Public License for more details.
8183
8184 You should have received a copy of the GNU General Public License
8185 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.