* eval.c (struct backtrace): Simplify and port the data structure.
[bpt/emacs.git] / src / ChangeLog
1 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2
3 * eval.c (struct backtrace): Simplify and port the data structure.
4 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
5 signed bit field, as this assumption is not portable and it makes
6 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7 "char debug_on_exit : 1" as this is not portable either; instead,
8 use the portable "unsigned int debug_on_exit : 1". Remove unused
9 member evalargs. Remove obsolete comments about cc bombing out.
10
11 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
12
13 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
14 Let HAVE_GSETTINGS override HAVE_GCONF.
15 (store_monospaced_changed): New function.
16 (EMACS_SETTINGS): A new type derived from GObject to handle
17 GSettings notifications.
18 (emacs_settings_constructor, emacs_settings_get_property)
19 (emacs_settings_set_property, emacs_settings_class_init):
20 New functions.
21 (gsettings_client, gsettings_obj): New variables.
22 (GSETTINGS_SCHEMA): New define.
23 (something_changedCB): Call store_monospaced_changed.
24 (init_gsettings): New function.
25 (xsettings_initialize): Call init_gsettings.
26 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
27 to NULL.
28
29 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
30 GCONF_CFLAGS/LIBS.
31
32 2011-06-29 Martin Rudalics <rudalics@gmx.at>
33
34 * window.c (resize_root_window, grow_mini_window)
35 (shrink_mini_window): Rename Qresize_root_window to
36 Qwindow_resize_root_window and Qresize_root_window_vertically to
37 Qwindow_resize_root_window_vertically.
38
39 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
40
41 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
42
43 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
44
45 * makefile.w32-in: Redesign dependencies so they reflect more
46 clearly which files are directly included by each source file,
47 and not through other includes.
48
49 2011-06-27 Martin Rudalics <rudalics@gmx.at>
50
51 * buffer.c (Qclone_number): Declare static and DEFSYM it.
52 (sort_overlays, overlay_strings): When an overlay's clone number
53 matches the window's clone number process the overlay even if
54 the overlay's window property doesn't match the current window.
55
56 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
57 (Fwindow_hchild): Rename to Fwindow_left_child.
58 (Fwindow_next): Rename to Fwindow_next_sibling.
59 (Fwindow_prev): Rename to Fwindow_prev_sibling.
60 (resize_window_check): Rename to window_resize_check.
61 (resize_window_apply): Rename to window_resize_apply.
62 (Fresize_window_apply): Rename to Fwindow_resize_apply.
63 (Fdelete_other_windows_internal, resize_frame_windows)
64 (Fsplit_window_internal, Fdelete_window_internal)
65 (grow_mini_window, shrink_mini_window)
66 (Fresize_mini_window_internal): Fix callers accordingly.
67
68 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
69
70 * emacsgtkfixed.h: State that this is only used with Gtk+3.
71 (emacs_fixed_set_min_size): Remove.
72 (emacs_fixed_new): Take frame as argument.
73
74 * emacsgtkfixed.c: State that this is only used with Gtk+3.
75 (_EmacsFixedPrivate): Remove minwidth/height.
76 Add struct frame *f.
77 (emacs_fixed_init): Initialize priv->f.
78 (get_parent_class, emacs_fixed_set_min_size): Remove.
79 (emacs_fixed_new): Set priv->f to argument.
80 (emacs_fixed_get_preferred_width)
81 (emacs_fixed_get_preferred_height): Use min_width/height from
82 frames size_hint to set minimum and natural (Bug#8919).
83 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
84 and use min_width/height from frames size_hint to set
85 min_width/height (Bug#8919).
86
87 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
88 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size. Fix
89 indentation.
90
91 2011-06-26 Eli Zaretskii <eliz@gnu.org>
92
93 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
94 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
95 called at ZV.
96
97 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
98
99 * process.c (wait_reading_process_output): Bypass select if
100 waiting for a cell while ignoring keyboard input, and input is
101 pending. Suggested by Jan Djärv (Bug#8869).
102
103 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
104
105 Use gnulib's dup2 module instead of rolling our own.
106 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
107
108 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
109
110 * dispnew.c (scrolling_window): Before scrolling, turn off a
111 mouse-highlight in the window being scrolled.
112
113 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
114
115 Move DEFSYM to lisp.h and use everywhere.
116
117 * character.h (DEFSYM): Move declaration...
118 * lisp.h (DEFSYM): ...here.
119
120 * gnutls.c:
121 * minibuf.c:
122 * w32menu.c:
123 * w32proc.c:
124 * w32select.c: Don't include character.h.
125
126 * alloc.c (syms_of_alloc):
127 * buffer.c (syms_of_buffer):
128 * bytecode.c (syms_of_bytecode):
129 * callint.c (syms_of_callint):
130 * casefiddle.c (syms_of_casefiddle):
131 * casetab.c (init_casetab_once):
132 * category.c (init_category_once, syms_of_category):
133 * ccl.c (syms_of_ccl):
134 * cmds.c (syms_of_cmds):
135 * composite.c (syms_of_composite):
136 * dbusbind.c (syms_of_dbusbind):
137 * dired.c (syms_of_dired):
138 * dispnew.c (syms_of_display):
139 * doc.c (syms_of_doc):
140 * editfns.c (syms_of_editfns):
141 * emacs.c (syms_of_emacs):
142 * eval.c (syms_of_eval):
143 * fileio.c (syms_of_fileio):
144 * fns.c (syms_of_fns):
145 * frame.c (syms_of_frame):
146 * fringe.c (syms_of_fringe):
147 * insdel.c (syms_of_insdel):
148 * keymap.c (syms_of_keymap):
149 * lread.c (init_obarray, syms_of_lread):
150 * macros.c (syms_of_macros):
151 * msdos.c (syms_of_msdos):
152 * print.c (syms_of_print):
153 * process.c (syms_of_process):
154 * search.c (syms_of_search):
155 * sound.c (syms_of_sound):
156 * syntax.c (init_syntax_once, syms_of_syntax):
157 * terminal.c (syms_of_terminal):
158 * textprop.c (syms_of_textprop):
159 * undo.c (syms_of_undo):
160 * w32.c (globals_of_w32):
161 * window.c (syms_of_window):
162 * xdisp.c (syms_of_xdisp):
163 * xfaces.c (syms_of_xfaces):
164 * xfns.c (syms_of_xfns):
165 * xmenu.c (syms_of_xmenu):
166 * xsettings.c (syms_of_xsettings):
167 * xterm.c (syms_of_xterm): Use DEFSYM.
168
169 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
170
171 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
172
173 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
174
175 Integer and buffer overflow fixes (Bug#8873).
176
177 * print.c (printchar, strout): Check for string overflow.
178 (PRINTPREPARE, printchar, strout):
179 Don't set size unless allocation succeeds.
180
181 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
182 for sizes. Check for string overflow more accurately.
183 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
184
185 * macros.c: Integer and buffer overflow fixes.
186 * keyboard.h (struct keyboard.kbd_macro_bufsize):
187 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
188 Use ptrdiff_t, not int, for sizes.
189 Don't increment bufsize until after realloc succeeds.
190 Check for size-calculation overflow.
191 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
192
193 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
194
195 * lread.c: Integer overflow fixes.
196 (read_integer): Radix is now EMACS_INT, not int,
197 to improve quality of diagnostics for out-of-range radices.
198 Calculate buffer size correctly for out-of-range radices.
199 (read1): Check for integer overflow in radices, and in
200 read-circle numbers.
201 (read_escape): Avoid int overflow.
202 (Fload, openp, read_buffer_size, read1)
203 (substitute_object_recurse, read_vector, read_list, map_obarray):
204 Use ptrdiff_t, not int, for sizes.
205 (read1): Use EMACS_INT, not int, for sizes.
206 Check for size overflow.
207
208 * image.c (cache_image): Check for size arithmetic overflow.
209
210 * lread.c: Integer overflow issues.
211 (saved_doc_string_size, saved_doc_string_length)
212 (prev_saved_doc_string_size, prev_saved_doc_string_length):
213 Now ptrdiff_t, not int.
214 (read1): Don't assume doc string length fits in int. Check for
215 out-of-range doc string lengths.
216 (read_list): Don't assume file position fits in int.
217 (read_escape): Check for hex character overflow.
218
219 2011-06-22 Leo Liu <sdl.web@gmail.com>
220
221 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
222 Move to minibuffer.el.
223
224 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
225
226 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
227 The following patches are for when GLYPH_DEBUG && !XASSERT.
228 * dispextern.h (trace_redisplay_p, dump_glyph_string):
229 * dispnew.c (flush_stdout):
230 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
231 Mark as externally visible.
232 * dispnew.c (check_window_matrix_pointers): Now static.
233 * dispnew.c (window_to_frame_vpos):
234 * xfns.c (unwind_create_frame):
235 * xterm.c (x_check_font): Remove unused local.
236 * scroll.c (CHECK_BOUNDS):
237 * xfaces.c (cache_fache): Rename local to avoid shadowing.
238 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
239 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
240 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
241 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
242 Now static.
243 (debug_method_add): Use va_list and vsprintf rather than relying
244 on undefined behavior with wrong number of arguments.
245 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
246 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
247 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
248 since we're not interested in debugging glyphs with old libraries.
249 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
250 GCC 4.6.0's static checking.
251
252 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
253
254 Integer overflow and signedness fixes (Bug#8873).
255 A few related buffer overrun fixes, too.
256
257 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
258
259 * dispextern.h (struct face.stipple):
260 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
261 (x_bitmap_mask, x_allocate_bitmap_record)
262 (x_create_bitmap_from_data, x_create_bitmap_from_file)
263 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
264 (x_create_bitmap_from_xpm_data):
265 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
266 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
267 (.bitmaps_last):
268 * xfaces.c (load_pixmap):
269 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
270 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
271 (.bitmaps_last, struct x_output.icon_bitmap):
272 Use ptrdiff_t, not int, for bitmap indexes.
273 (x_allocate_bitmap_record): Check for size overflow.
274 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
275
276 Use ptrdiff_t, not int, for overlay counts.
277 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
278 * editfns.c (overlays_around, get_pos_property):
279 * textprop.c (get_char_property_and_overlay):
280 * xdisp.c (next_overlay_change, note_mouse_highlight):
281 * xfaces.c (face_at_buffer_position):
282 * buffer.c (OVERLAY_COUNT_MAX): New macro.
283 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
284 (Fnext_overlay_change, Fprevious_overlay_change)
285 (mouse_face_overlay_overlaps, Foverlays_in):
286 Use ptrdiff_t, not int, for sizes.
287 (overlays_at, overlays_in): Check for size-calculation overflow.
288
289 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
290
291 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
292 (x_session_initialize): Do not assume string length fits in int.
293
294 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
295 This is unlikely, but can occur if DPI is outlandish.
296
297 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
298 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
299
300 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
301 * xrdb.c (magic_file_p, search_magic_path):
302 Omit last arg SUFFIX; it was always 0. All callers changed.
303 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
304
305 * xfont.c (xfont_match): Avoid need for strlen.
306
307 * xfns.c: Don't assume strlen fits in int.
308 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
309
310 * xdisp.c (message_log_check_duplicate): Return intmax_t,
311 not unsigned long, as we prefer signed integers. All callers changed.
312 Detect integer overflow in repeat count.
313 (message_dolog): Don't assume print length fits in 39 bytes.
314 (display_mode_element): Don't assume strlen fits in int.
315
316 * termcap.c: Don't assume sizes fit in int and never overflow.
317 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
318 (gobble_line): Check for size-calculation overflow.
319
320 * minibuf.c (Fread_buffer):
321 * lread.c (intern, intern_c_string):
322 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
323 Don't assume string length fits in int.
324
325 * keyboard.c (parse_tool_bar_item):
326 * gtkutil.c (style_changed_cb): Avoid need for strlen.
327
328 * font.c: Don't assume string length fits in int.
329 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
330 Use ptrdiff_t, not int.
331 (font_intern_prop): Don't assume string length fits in int.
332 Don't assume integer property fits in fixnum.
333 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
334
335 * filelock.c: Fix some buffer overrun and integer overflow issues.
336 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
337 Reformulate so as not to need the command string.
338 Invoke gzip -cd rather than gunzip, as it's more portable.
339 (lock_info_type, lock_file_1, lock_file):
340 Don't assume pid_t and time_t fit in unsigned long.
341 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
342 (current_lock_owner): Prefer signed type for sizes.
343 Use memcpy, not strncpy, where memcpy is what is really wanted.
344 Don't assume (via atoi) that time_t and pid_t fit in int.
345 Check for time_t and/or pid_t out of range, e.g., via a network share.
346 Don't alloca where an auto var works fine.
347
348 * fileio.c: Fix some integer overflow issues.
349 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
350 Don't assume string length fits in int.
351 (directory_file_name): Don't assume string length fits in long.
352 (make_temp_name): Don't assume pid fits in int, or that its print
353 length is less than 20.
354
355 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
356
357 * coding.c (make_subsidiaries): Don't assume string length fits in int.
358
359 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
360
361 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
362 We prefer signed integers, even for size calculations.
363
364 * emacs.c: Don't assume string length fits in 'int'.
365 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
366 (main): Don't invoke strlen when not needed.
367
368 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
369 (XD_DEBUG_MESSAGE): Don't waste a byte.
370
371 * callproc.c (getenv_internal_1, getenv_internal)
372 (Fgetenv_internal):
373 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
374
375 * lread.c (invalid_syntax): Omit length argument.
376 All uses changed. This doesn't fix a bug, but it simplifies the
377 code away from its former Hollerith-constant appearance, and it's
378 one less 'int' to worry about when looking at integer-overflow issues.
379 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
380
381 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
382 This didn't break anything, but it didn't help either.
383 It's confusing to put a bogus integer in a place where the actual
384 value does not matter.
385 (LIST_END_P): Remove unused macro and its bogus comment.
386 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
387
388 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
389 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
390 implementation.
391 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
392 We prefer signed types, and the value cannot exceed the EMACS_INT
393 range anyway (because otherwise the length would not be representable).
394 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
395 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
396 This avoids a GCC warning when WIDE_EMACS_INT.
397
398 * indent.c (sane_tab_width): New function.
399 (current_column, scan_for_column, Findent_to, position_indentation)
400 (compute_motion): Use it. This is just for clarity.
401 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
402
403 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
404
405 * lisp.h (lint_assume): New macro.
406 * composite.c (composition_gstring_put_cache):
407 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
408
409 * editfns.c, insdel.c:
410 Omit unnecessary forward decls, to simplify future changes.
411
412 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
413
414 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
415
416 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
417 Use much-faster test for byte-length change.
418 Don't assume string byte-length fits in 'int'.
419 Check that character arg fits in 'int'.
420 (mapcar1): Declare byte as byte, for clarity.
421
422 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
423
424 * fns.c (concat): Catch string overflow earlier.
425 Do not rely on integer wraparound.
426
427 * dispextern.h (struct it.overlay_strings_charpos)
428 (struct it.selective): Now EMACS_INT, not int.
429 * xdisp.c (forward_to_next_line_start)
430 (back_to_previous_visible_line_start)
431 (reseat_at_next_visible_line_start, next_element_from_buffer):
432 Don't arbitrarily truncate the value of 'selective' to int.
433
434 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
435
436 * composite.c: Don't truncate sizes to 'int'.
437 (composition_gstring_p, composition_reseat_it)
438 (composition_adjust_point): Use EMACS_INT, not int.
439 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
440 not EMACS_UINT, for indexes.
441
442 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
443
444 * buffer.c: Include <verify.h>.
445 (struct sortvec.priority, struct sortstr.priority):
446 Now EMACS_INT, not int.
447 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
448 (struct sortstr.size, record_overlay_string)
449 (struct sortstrlist.size, struct sortlist.used):
450 Don't truncate size to int.
451 (record_overlay_string): Check for size-calculation overflow.
452 (init_buffer_once): Check at compile-time, not run-time.
453
454 2011-06-22 Jim Meyering <meyering@redhat.com>
455
456 Don't leak an XBM-image-sized buffer
457 * image.c (xbm_load): Free the image buffer after using it.
458
459 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
460
461 Port to Sun C.
462 * composite.c (find_automatic_composition): Omit needless 'return 0;'
463 that Sun C diagnosed.
464 * fns.c (secure_hash): Fix pointer signedness issue.
465 * intervals.c (static_offset_intervals): New function.
466 (offset_intervals): Use it.
467
468 2011-06-21 Leo Liu <sdl.web@gmail.com>
469
470 * deps.mk (fns.o):
471 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
472 sha512.h.
473
474 * fns.c (secure_hash): Rename from crypto_hash_function and change
475 the first arg to accept symbols.
476 (Fsecure_hash): New primitive.
477 (syms_of_fns): New symbols.
478
479 2011-06-20 Deniz Dogan <deniz@dogan.se>
480
481 * process.c (Fset_process_buffer): Clarify return value in
482 docstring.
483
484 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
485
486 * dispnew.c (add_window_display_history): Use BVAR.
487
488 * xdisp.c (debug_method_add): Use BVAR.
489 (check_window_end, dump_glyph_matrix, dump_glyph)
490 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
491
492 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
493 Likewise.
494
495 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
496 check till after the cache is created in init_frame_faces.
497
498 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
499
500 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
501
502 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
503
504 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
505 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
506 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
507
508 Improve buffer-overflow checking (Bug#8873).
509 * fileio.c (Finsert_file_contents):
510 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
511 Remove the old (too-loose) buffer overflow checks.
512 They weren't needed, since make_gap checks for buffer overflow.
513 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
514 The old code merely checked for Emacs fixnum overflow, and relied
515 on undefined (wraparound) behavior. The new code avoids undefined
516 behavior, and also checks for ptrdiff_t and/or size_t overflow.
517
518 * editfns.c (Finsert_char): Don't dump core with very negative counts.
519 Tune. Don't use wider integers than needed. Don't use alloca.
520 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
521
522 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
523
524 * insdel.c, lisp.h (buffer_overflow): New function.
525 (insert_from_buffer_1, replace_range, replace_range_2):
526 * insdel.c (make_gap_larger):
527 * editfns.c (Finsert_char):
528 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
529
530 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
531
532 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
533
534 Integer overflow and signedness fixes (Bug#8873).
535
536 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
537 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
538
539 * fileio.c: Don't assume EMACS_INT fits in off_t.
540 (emacs_lseek): New static function.
541 (Finsert_file_contents, Fwrite_region): Use it.
542 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
543
544 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
545
546 * fns.c: Don't overflow int when computing a list length.
547 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
548 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
549 truncation on 64-bit hosts. Check for QUIT every
550 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
551 faster and is responsive enough.
552 (Flength): Report an error instead of overflowing an integer.
553 (Fsafe_length): Return a float if the value is not representable
554 as a fixnum. This shouldn't happen except in contrived situations.
555 (Fnthcdr, Fsort): Don't assume list length fits in int.
556 (Fcopy_sequence): Don't assume vector length fits in int.
557
558 * alloc.c: Check that resized vectors' lengths fit in fixnums.
559 (header_size, word_size): New constants.
560 (allocate_vectorlike): Don't check size overflow here.
561 (allocate_vector): Check it here instead, since this is the only
562 caller of allocate_vectorlike that could cause overflow.
563 Check that the new vector's length is representable as a fixnum.
564
565 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
566 The previous code was bogus. For example, next_almost_prime (32)
567 returned 39, which is undesirable as it is a multiple of 3; and
568 next_almost_prime (24) returned 25, which is a multiple of 5 so
569 why was the code bothering to check for multiples of 7?
570
571 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
572
573 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
574
575 Variadic C functions now count arguments with ptrdiff_t.
576 This partly undoes my 2011-03-30 change, which replaced int with size_t.
577 Back then I didn't know that the Emacs coding style prefers signed int.
578 Also, in the meantime I found a few more instances where arguments
579 were being counted with int, which may truncate counts on 64-bit
580 machines, or EMACS_INT, which may be unnecessarily wide.
581 * lisp.h (struct Lisp_Subr.function.aMANY)
582 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
583 Arg counts are now ptrdiff_t, not size_t.
584 All variadic functions and their callers changed accordingly.
585 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
586 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
587 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
588 * callint.c (Fcall_interactively): Check arg count for overflow,
589 to avoid potential buffer overrun. Use signed char, not 'int',
590 for 'varies' array, so that we needn't bother to check its size
591 calculation for overflow.
592 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
593 * eval.c (apply_lambda):
594 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
595 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
596 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
597
598 * callint.c (Fcall_interactively): Don't use index var as event count.
599
600 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
601 * mem-limits.h (SIZE): Remove; no longer used.
602
603 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
604
605 Remove unnecessary casts.
606 * xterm.c (x_term_init):
607 * xfns.c (x_set_border_pixel):
608 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
609 These aren't needed now that we assume ANSI C.
610
611 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
612 It's more likely to cause problems (due to unsigned overflow)
613 than to cure them.
614
615 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
616
617 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
618
619 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
620
621 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
622
623 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
624
625 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
626
627 GLYPH_CODE_FACE returns EMACS_INT, not int.
628 * dispextern.h (merge_faces):
629 * xfaces.c (merge_faces):
630 * xdisp.c (get_next_display_element, next_element_from_display_vector):
631 Don't assume EMACS_INT fits in int.
632
633 * character.h (CHAR_VALID_P): Remove unused parameter.
634 * fontset.c, lisp.h, xdisp.c: All uses changed.
635
636 * editfns.c (Ftranslate_region_internal): Omit redundant test.
637
638 * fns.c (concat): Minor tuning based on overflow analysis.
639 This doesn't fix any bugs. Use int to hold character, instead
640 of constantly refetching from Emacs object. Use XFASTINT, not
641 XINT, for value known to be a character. Don't bother comparing
642 a single byte to 0400, as it's always less.
643
644 * floatfns.c (Fexpt):
645 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
646
647 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
648 for characters.
649
650 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
651
652 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
653 Without this fix, on a 64-bit host (aset S 0 4294967386) would
654 incorrectly succeed when S was a string, because 4294967386 was
655 truncated before it was used.
656
657 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
658 Otherwise, an out-of-range integer could cause undefined behavior
659 on a 64-bit host.
660
661 * composite.c: Use int, not EMACS_INT, for characters.
662 (fill_gstring_body, composition_compute_stop_pos): Use int, not
663 EMACS_INT, for values that are known to be in character range.
664 This doesn't fix any bugs but is the usual style inside Emacs and
665 may generate better code on 32-bit machines.
666
667 Make sure a 64-bit char is never passed to ENCODE_CHAR.
668 This is for reasons similar to the recent CHAR_STRING fix.
669 * charset.c (Fencode_char): Check that character arg is actually
670 a character. Pass an int to ENCODE_CHAR.
671 * charset.h (ENCODE_CHAR): Verify that the character argument is no
672 wider than 'int', as a compile-time check to prevent future regressions
673 in this area.
674
675 * character.c (char_string): Remove unnecessary casts.
676
677 Make sure a 64-bit char is never passed to CHAR_STRING.
678 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
679 by silently ignoring the top 32 bits, allowing some values
680 that were far too large to be valid characters.
681 * character.h: Include <verify.h>.
682 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
683 arguments are no wider than unsigned, as a compile-time check
684 to prevent future regressions in this area.
685 * data.c (Faset):
686 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
687 (Fsubst_char_in_region):
688 * fns.c (concat):
689 * xdisp.c (decode_mode_spec_coding):
690 Adjust to CHAR_STRING's new requirement.
691 * editfns.c (Finsert_char, Fsubst_char_in_region):
692 * fns.c (concat): Check that character args are actually
693 characters. Without this test, these functions did the wrong
694 thing with wildly out-of-range values on 64-bit hosts.
695
696 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
697 These casts should not be needed on 32-bit hosts, either.
698 * keyboard.c (read_char):
699 * lread.c (Fload): Remove casts to unsigned.
700
701 * lisp.h (UNSIGNED_CMP): New macro.
702 This fixes comparison bugs on 64-bit hosts.
703 (ASCII_CHAR_P): Use it.
704 * casefiddle.c (casify_object):
705 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
706 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
707 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
708 * dispextern.h (FACE_FROM_ID):
709 * keyboard.c (read_char): Use UNSIGNED_CMP.
710
711 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
712 not to EMACS_INT, to avoid GCC warning.
713
714 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
715
716 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
717 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
718 isn't needed on 32-bit machines.
719
720 * buffer.c (Fgenerate_new_buffer_name):
721 Use EMACS_INT for count, not int.
722 (advance_to_char_boundary): Return EMACS_INT, not int.
723
724 * data.c (Qcompiled_function): Now static.
725
726 * window.c (window_body_lines): Now static.
727
728 * image.c (gif_load): Rename local to avoid shadowing.
729
730 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
731 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
732 * alloc.c (make_save_value): Integer argument is now of type
733 ptrdiff_t, not int.
734 (mark_object): Use ptrdiff_t, not int.
735 * lisp.h (pD): New macro.
736 * print.c (print_object): Use it.
737
738 * alloc.c: Use EMACS_INT, not int, to count objects.
739 (total_conses, total_markers, total_symbols, total_vector_size)
740 (total_free_conses, total_free_markers, total_free_symbols)
741 (total_free_floats, total_floats, total_free_intervals)
742 (total_intervals, total_strings, total_free_strings):
743 Now EMACS_INT, not int. All uses changed.
744 (Fgarbage_collect): Compute overall total using a double, so that
745 integer overflow is less likely to be a problem. Check for overflow
746 when converting back to an integer.
747 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
748 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
749 These were 'int' variables that could overflow on 64-bit hosts;
750 they were never used, so remove them instead of repairing them.
751 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
752 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
753 Previously, this ceilinged at INT_MAX, but that doesn't work on
754 64-bit machines.
755 (allocate_pseudovector): Don't use EMACS_INT when int would do.
756
757 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
758 (allocate_vectorlike): Check for ptrdiff_t overflow.
759 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
760 when a (possibly-narrower) signed value would do just as well.
761 We prefer using signed arithmetic, to avoid comparison confusion.
762
763 * alloc.c: Catch some string size overflows that we were missing.
764 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
765 for convenience in STRING_BYTES_MAX.
766 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
767 The definition here is exact; the one in lisp.h was approximate.
768 (allocate_string_data): Check for string overflow. This catches
769 some instances we weren't catching before. Also, it catches
770 size_t overflow on (unusual) hosts where SIZE_MAX <= min
771 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
772 and ptrdiff_t and EMACS_INT are both 64 bits.
773
774 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
775 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
776 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
777
778 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
779
780 * alloc.c (Fmake_string): Check for out-of-range init.
781
782 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
783
784 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
785
786 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
787
788 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
789 xg_get_default_scrollbar_width.
790
791 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
792 (int_gtk_range_get_value): Move to the scroll bar part of the file.
793 (style_changed_cb): Call update_theme_scrollbar_width and call
794 x_set_scroll_bar_default_width and xg_frame_set_char_size for
795 all frames (Bug#8505).
796 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
797 Call gtk_window_set_resizable if HAVE_GTK3.
798 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
799 and height if HAVE_GTK3 (Bug#8505).
800 (scroll_bar_width_for_theme): New variable.
801 (update_theme_scrollbar_width): New function.
802 (xg_get_default_scrollbar_width): Move code to
803 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
804 (xg_initialize): Call update_theme_scrollbar_width.
805
806 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
807
808 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
809
810 2011-06-12 Martin Rudalics <rudalics@gmx.at>
811
812 * frame.c (make_frame): Call other_buffer_safely instead of
813 other_buffer.
814
815 * window.c (temp_output_buffer_show): Call display_buffer with
816 second argument Vtemp_buffer_show_specifiers and reset latter
817 immediately after the call.
818 (Vtemp_buffer_show_specifiers): New variable.
819 (auto_window_vscroll_p, next_screen_context_lines)
820 (Vscroll_preserve_screen_position): Remove leading asterisks from
821 doc-strings.
822
823 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
824
825 Fix minor problems found by GCC 4.6.0 static checking.
826 * buffer.c (Qclone_number): Remove for now, as it's unused.
827 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
828 (record_buffer): Remove unused local.
829 * frame.c (other_visible_frames, frame_buffer_list): Now static.
830 (set_frame_buffer_list): Remove; unused.
831 * frame.h (other_visible_frames): Remove decl.
832 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
833 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
834 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
835 if HAVE_GPM.
836 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
837 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
838 Define only if HAVE_GPM.
839 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
840 (update_hints_inhibit): Remove; never set. All uses removed.
841 * widgetprv.h (emacsFrameClassRec): Remove decl.
842 * window.c (delete_deletable_window): Now returns void, since it
843 wasn't returning anything.
844 (compare_window_configurations): Remove unused locals.
845 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
846 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
847 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
848 the same widths as pointers. This follows up on the 2011-05-06 patch.
849 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
850 * xterm.h: Likewise.
851 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
852
853 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
854
855 * makefile.w32-in: Update dependencies.
856 (LISP_H): Add lib/intprops.h.
857
858 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
859
860 * image.c (gif_load): Add animation frame delay to the metadata.
861 (syms_of_image): Use DEFSYM. New symbol `delay'.
862
863 2011-06-11 Martin Rudalics <rudalics@gmx.at>
864
865 * window.c (delete_deletable_window): Re-add.
866 (Fset_window_configuration): Rewrite to handle dead buffers and
867 consequently deletable windows.
868 (window_tree, Fwindow_tree): Remove. Supply functionality in
869 window.el.
870 (compare_window_configurations): Simplify code.
871
872 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
873
874 * image.c (imagemagick_load_image): Fix type mismatch.
875 (Fimagemagick_types): Likewise.
876
877 * window.h (replace_buffer_in_windows): Declare.
878
879 2011-06-11 Martin Rudalics <rudalics@gmx.at>
880
881 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
882 Qclone_number. Remove external declaration of Qdelete_window.
883 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
884 code.
885 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
886 Qbuffer_list_update_hook if allowed.
887 (Fother_buffer): Rewrite doc-string. Major rewrite for new
888 buffer list implementation.
889 (other_buffer_safely): New function.
890 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
891 calls to replace_buffer_in_windows and
892 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
893 if allowed.
894 (record_buffer): Inhibit quitting and rewrite using quittable
895 functions. Run Qbuffer_list_update_hook if allowed.
896 (Frecord_buffer, Funrecord_buffer): New functions.
897 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
898 switch-to-buffer to window.el.
899 (bury-buffer): Move to window.el.
900 (Vbuffer_list_update_hook): New variable.
901
902 * lisp.h (other_buffer_safely): Add prototype in buffer.c
903 section.
904
905 * window.h (resize_frame_windows): Move up in code.
906 (Fwindow_frame): Remove EXFUN.
907 (replace_buffer_in_all_windows): Remove prototype.
908 (replace_buffer_in_windows_safely): Add prototype.
909
910 * window.c: Declare Qdelete_window static again. Move down
911 declaration of select_count.
912 (Fnext_window, Fprevious_window): Rewrite doc-strings.
913 (Fother_window): Move to window.el.
914 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
915 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
916 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
917 window.el.
918 (replace_buffer_in_windows): Implement by calling
919 Qreplace_buffer_in_windows.
920 (replace_buffer_in_all_windows): Remove with some functionality
921 moved into replace_buffer_in_windows_safely.
922 (replace_buffer_in_windows_safely): New function.
923 (select_window_norecord, select_frame_norecord): Move in front
924 of run_window_configuration_change_hook. Remove now obsolete
925 declarations.
926 (Fset_window_buffer): Rewrite doc-string. Call
927 Qrecord_window_buffer.
928 (keys_of_window): Move binding for other-window to window.el.
929
930 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
931
932 * dispextern.h (struct image): Replace data member, whose int_val
933 and ptr_val fields were not used by anything, with a single
934 lisp_val object.
935
936 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
937 (gif_clear_image, gif_load, imagemagick_load_image)
938 (gs_clear_image, gs_load): Callers changed.
939
940 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
941
942 * buffer.h: Include <time.h>, for time_t.
943 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
944
945 Fix minor problems found by static checking.
946
947 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
948
949 Make identifiers static if they are not used in other modules.
950 * data.c (Qcompiled_function, Qframe, Qvector):
951 * image.c (QimageMagick, Qsvg):
952 * minibuf.c (Qmetadata):
953 * window.c (resize_window_check, resize_root_window): Now static.
954 * window.h (resize_window_check, resize_root_window): Remove decls.
955
956 * window.c (window_deletion_count, delete_deletable_window):
957 Remove; unused.
958 (window_body_lines): Now static.
959 (Fdelete_other_windows_internal): Mark vars as initialized.
960 Make sure 'resize_failed' is initialized.
961 (run_window_configuration_change_hook): Rename local to avoid shadowing.
962 (resize_window_apply): Remove unused local.
963 * window.h (delete_deletable_window): Remove decl.
964
965 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
966 (imagemagick_load_image): Fix pointer signedness problem by changing
967 last arg from unsigned char * to char *. All uses changed.
968 Also, fix a local for similar reasons.
969 Remove unused locals. Remove locals to avoid shadowing.
970 (fn_rsvg_handle_free): Remove; unused.
971 (svg_load, svg_load_image): Fix pointer signedness problem.
972 (imagemagick_load_image): Don't use garbage pointer image_wand.
973
974 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
975
976 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
977
978 * image.c (gif_load): Fix omitted cast error introduced by
979 2011-06-06 change.
980
981 2011-06-10 Martin Rudalics <rudalics@gmx.at>
982
983 * window.h (resize_proportionally, orig_total_lines)
984 (orig_top_line): Remove from window structure.
985 (set_window_height, set_window_width, change_window_heights)
986 (Fdelete_window): Remove prototypes.
987 (resize_frame_windows): Remove duplicate declaration.
988
989 2011-06-10 Eli Zaretskii <eliz@gnu.org>
990
991 * window.h (resize_frame_windows, resize_window_check)
992 (delete_deletable_window, resize_root_window)
993 (resize_frame_windows): Declare prototypes.
994
995 * window.c (resize_window_apply): Make definition be "static" to
996 match the prototype.
997
998 2011-06-10 Martin Rudalics <rudalics@gmx.at>
999
1000 * window.c: Remove declarations of Qwindow_size_fixed,
1001 window_min_size_1, window_min_size_2, window_min_size,
1002 size_window, window_fixed_size_p, enlarge_window, delete_window.
1003 Remove static from declaration of Qdelete_window, it's
1004 temporarily needed by Fbury_buffer.
1005 (replace_window): Don't assign orig_top_line and
1006 orig_total_lines.
1007 (Fdelete_window, delete_window): Remove. Window deletion is
1008 handled by window.el.
1009 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1010 Fdelete_window calls with calls to Qdelete_window.
1011 (Fdelete_other_windows): Remove. Deleting other windows is
1012 handled by window.el.
1013 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1014 handled in window.el.
1015 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1016 Window minimum sizes are handled in window.el.
1017 (shrink_windows, size_window, set_window_height)
1018 (set_window_width, change_window_heights, window_height)
1019 (window_width, CURBEG, CURSIZE, enlarge_window)
1020 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1021 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1022 handled in window.el.
1023 (make_dummy_parent): Rename to make_parent_window and give it a
1024 second argument horflag.
1025 (make_window): Don't set resize_proportionally any more.
1026 (Fsplit_window): Remove. Windows are split in window.el.
1027 (save_restore_action, save_restore_orig_size)
1028 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1029 Resize mini windows in window.el.
1030 (grow_mini_window, shrink_mini_window): Implement by calling
1031 Qresize_root_window_vertically, resize_window_check and
1032 resize_window_apply.
1033 (saved_window, Fset_window_configuration, save_window_save): Do
1034 not handle orig_top_line, orig_total_lines, and
1035 resize_proportionally.
1036 (window_min_height, window_min_width): Move to window.el.
1037 (keys_of_window): Move bindings for delete-other-windows,
1038 split-window, delete-window and enlarge-window to window.el.
1039
1040 * buffer.c: Temporarily extern Qdelete_window.
1041 (Fbury_buffer): Temporarily call Qdelete_window instead of
1042 Fdelete_window (Fbury_buffer will move to window.el soon).
1043
1044 * frame.c (set_menu_bar_lines_1): Remove code handling
1045 orig_top_line and orig_total_lines.
1046
1047 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1048 set_window_height but set heights directly.
1049 (change_frame_size_1): Use resize_frame_windows.
1050
1051 * xdisp.c (init_xdisp): Don't use set_window_height but set
1052 heights directly.
1053
1054 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1055 resize_frame_windows instead of change_window_heights and run
1056 run_window_configuration_change_hook.
1057
1058 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1059 instead of change_window_heights and run
1060 run_window_configuration_change_hook.
1061
1062 2011-06-09 Martin Rudalics <rudalics@gmx.at>
1063
1064 * window.c (replace_window): Rename second argument REPLACEMENT to
1065 NEW. New third argument SETFLAG. Rewrite.
1066 (delete_window, make_dummy_parent): Call replace_window with
1067 third argument 1.
1068 (window_list_1): Move down in code.
1069 (run_window_configuration_change_hook): Move set_buffer part
1070 before select_frame_norecord part in order to unwind correctly.
1071 Rename count1 to count.
1072 (recombine_windows, delete_deletable_window, resize_root_window)
1073 (Fdelete_other_windows_internal)
1074 (Frun_window_configuration_change_hook, make_parent_window)
1075 (resize_window_check, resize_window_apply, Fresize_window_apply)
1076 (resize_frame_windows, Fsplit_window_internal)
1077 (Fdelete_window_internal, Fresize_mini_window_internal): New
1078 functions.
1079 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1080
1081 2011-06-08 Martin Rudalics <rudalics@gmx.at>
1082
1083 * window.h (window): Add some new members to window structure -
1084 normal_lines, normal_cols, new_total, new_normal, clone_number,
1085 splits, nest, prev_buffers, next_buffers.
1086 (WINDOW_TOTAL_SIZE): Move here from window.c.
1087 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
1088
1089 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1090 Remove.
1091 (make_dummy_parent): Set new members of windows structure.
1092 (make_window): Move down in code. Handle new members of window
1093 structure.
1094 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1095 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1096 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1097 (Fset_window_prev_buffers, Fwindow_next_buffers)
1098 (Fset_window_next_buffers, Fset_window_clone_number): New
1099 functions.
1100 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1101 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1102 Doc-string fixes.
1103 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1104 Argument WINDOW can be now internal window too.
1105 (Fwindow_use_time): Move up in code.
1106 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1107 Rewrite doc-string.
1108 (Fset_window_configuration, saved_window)
1109 (Fcurrent_window_configuration, save_window_save): Handle new
1110 members of window structure.
1111 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1112 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1113 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1114 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1115 Qget_mru_window, Qresize_root_window,
1116 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1117 Qauto_buffer_name; staticpro them.
1118
1119 2011-06-07 Martin Rudalics <rudalics@gmx.at>
1120
1121 * window.c (Fwindow_total_size, Fwindow_left_column)
1122 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1123 (Fwindow_list_1): New functions.
1124 (window_box_text_cols): Replace with window_body_cols.
1125 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1126 window_body_cols instead of window_box_text_cols.
1127 (delete_window, Fset_window_configuration): Call
1128 delete_all_subwindows with window as argument.
1129 (delete_all_subwindows): Take a window as argument and not a
1130 structure. Rewrite.
1131 (window_loop): Remove handling of GET_LRU_WINDOW and
1132 GET_LARGEST_WINDOW.
1133 (Fget_lru_window, Fget_largest_window): Move to window.el.
1134
1135 * window.h: Extern window_body_cols instead of
1136 window_box_text_cols. delete_all_subwindows now takes a
1137 Lisp_Object as argument.
1138
1139 * indent.c (compute_motion, Fcompute_motion): Use
1140 window_body_cols instead of window_box_text_cols.
1141
1142 * frame.c (delete_frame): Call delete_all_subwindows with root
1143 window as argument.
1144
1145 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1146
1147 * fns.c (Fputhash): Document return value.
1148
1149 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
1150
1151 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1152
1153 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1154
1155 Cons<->int and similar integer overflow fixes (Bug#8794).
1156
1157 Check for overflow when converting integer to cons and back.
1158 * charset.c (Fdefine_charset_internal, Fdecode_char):
1159 Use cons_to_unsigned to catch overflow.
1160 (Fencode_char): Use INTEGER_TO_CONS.
1161 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1162 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1163 * data.c (long_to_cons, cons_to_long): Remove.
1164 (cons_to_unsigned, cons_to_signed): New functions.
1165 These signal an error for invalid or out-of-range values.
1166 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1167 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1168 * font.c (Ffont_variation_glyphs):
1169 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1170 * lisp.h: Include <intprops.h>.
1171 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1172 (cons_to_signed, cons_to_unsigned): New decls.
1173 (long_to_cons, cons_to_long): Remove decls.
1174 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1175 (Fprimitive_undo): Use CONS_TO_INTEGER.
1176 * xfns.c (Fx_window_property): Likewise.
1177 * xselect.c: Include <limits.h>.
1178 (x_own_selection, selection_data_to_lisp_data):
1179 Use INTEGER_TO_CONS.
1180 (x_handle_selection_request, x_handle_selection_clear)
1181 (x_get_foreign_selection, Fx_disown_selection_internal)
1182 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1183 (lisp_data_to_selection_data): Use cons_to_unsigned.
1184 (x_fill_property_data): Use cons_to_signed.
1185 Report values out of range.
1186
1187 Check for buffer and string overflow more precisely.
1188 * buffer.h (BUF_BYTES_MAX): New macro.
1189 * lisp.h (STRING_BYTES_MAX): New macro.
1190 * alloc.c (Fmake_string):
1191 * character.c (string_escape_byte8):
1192 * coding.c (coding_alloc_by_realloc):
1193 * doprnt.c (doprnt):
1194 * editfns.c (Fformat):
1195 * eval.c (verror):
1196 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1197 since they may not be the same number.
1198 * editfns.c (Finsert_char):
1199 * fileio.c (Finsert_file_contents):
1200 Likewise for BUF_BYTES_MAX.
1201
1202 * image.c: Use ptrdiff_t, not int, for sizes.
1203 (slurp_file): Switch from int to ptrdiff_t.
1204 All uses changed.
1205 (slurp_file): Check that file size fits in both size_t (for
1206 malloc) and ptrdiff_t (for sanity and safety).
1207
1208 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1209 if b->modtime has its maximal value.
1210
1211 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1212
1213 Don't assume time_t can fit into int.
1214 * buffer.h (struct buffer.modtime): Now time_t, not int.
1215 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1216 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1217
1218 Minor fixes for signed vs unsigned integers.
1219 * character.h (MAYBE_UNIFY_CHAR):
1220 * charset.c (maybe_unify_char):
1221 * keyboard.c (read_char, reorder_modifiers):
1222 XINT -> XFASTINT, since the integer must be nonnegative.
1223 * ftfont.c (ftfont_spec_pattern):
1224 * keymap.c (access_keymap, silly_event_symbol_error):
1225 XUINT -> XFASTINT, since the integer must be nonnegative.
1226 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1227 since it makes no difference and we prefer signed.
1228 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1229 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1230 nonnegative.
1231
1232 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1233
1234 * window.h (Fwindow_frame): Declare.
1235
1236 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1237
1238 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1239 (SPARE_MEMORY): Always define.
1240 (LARGE_REQUEST): Remove.
1241 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1242
1243 2011-06-06 Martin Rudalics <rudalics@gmx.at>
1244
1245 * lisp.h: Move EXFUNS for Fframe_root_window,
1246 Fframe_first_window and Fset_frame_selected_window to window.h.
1247
1248 * window.h: Move EXFUNS for Fframe_root_window,
1249 Fframe_first_window and Fset_frame_selected_window here from
1250 lisp.h.
1251
1252 * frame.c (Fwindow_frame, Fframe_first_window)
1253 (Fframe_root_window, Fframe_selected_window)
1254 (Fset_frame_selected_window): Move to window.c.
1255 (Factive_minibuffer_window): Move to minibuf.c.
1256 (Fother_visible_frames_p): New function.
1257
1258 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1259
1260 * window.c (decode_window, decode_any_window): Move up in code.
1261 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1262 (inhibit_frame_unsplittable): Remove unused variable.
1263 (Fwindow_buffer): Move up and rewrite doc-string.
1264 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1265 (Fwindow_prev): New functions.
1266 (Fwindow_frame): Move here from frame.c. Accept any window as
1267 argument.
1268 (Fframe_root_window, Fframe_first_window)
1269 (Fframe_selected_window): Move here from frame.c. Accept frame
1270 or arbitrary window as argument. Update doc-strings.
1271 (Fminibuffer_window): Move up in code.
1272 (Fwindow_minibuffer_p): Move up in code and simplify.
1273 (Fset_frame_selected_window): Move here from frame.c.
1274 Marginal rewrite.
1275 (Fselected_window, select_window, Fselect_window): Move up in
1276 code. Minor doc-string fixes.
1277
1278 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1279
1280 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1281 Do not assume that spare memory exists; that assumption is valid
1282 only if SYSTEM_MALLOC.
1283 (LARGE_REQUEST): New macro, so that the issue of large requests
1284 is separated from the issue of spare memory.
1285
1286 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1287
1288 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1289 format. (Bug#8806)
1290
1291 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1292
1293 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1294 before statements.
1295
1296 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1297
1298 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1299
1300 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1301
1302 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1303 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1304
1305 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
1306
1307 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1308
1309 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
1310
1311 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1312 (x_clipboard_manager_save): Add return value.
1313 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1314 New error handlers.
1315 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1316 Obey Vx_select_enable_clipboard_manager. Catch errors in
1317 x_clipboard_manager_save (Bug#8779).
1318 (Vx_select_enable_clipboard_manager): New variable.
1319 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
1320
1321 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
1322
1323 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1324
1325 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1326
1327 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1328 in the current matrix if keep_current_p is non-zero.
1329
1330 2011-06-04 Eli Zaretskii <eliz@gnu.org>
1331
1332 * bidi.c (bidi_level_of_next_char): Fix last change.
1333
1334 2011-06-03 Eli Zaretskii <eliz@gnu.org>
1335
1336 Support bidi reordering of text covered by display properties.
1337
1338 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1339 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1340 (bidi_cache_search, bidi_cache_iterator_state)
1341 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1342 (bidi_level_of_next_char, bidi_move_to_visually_next):
1343 Support character positions inside a run of characters covered by a
1344 display string.
1345 (bidi_paragraph_init, bidi_resolve_explicit_1)
1346 (bidi_level_of_next_char): Call bidi_fetch_char and
1347 bidi_fetch_char_advance instead of FETCH_CHAR and
1348 FETCH_CHAR_ADVANCE.
1349 (bidi_init_it): Initialize new members.
1350 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1351 definitions.
1352 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1353 instead of using explicit *_CHAR codes.
1354 (bidi_resolve_explicit, bidi_resolve_weak):
1355 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
1356 bidirectional text is supported only in multibyte buffers.
1357 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1358 it to initialize the frame_window_p member of struct bidi_it.
1359 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1360 (bidi_resolve_explicit, bidi_resolve_weak)
1361 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1362 bidi_it->nchars is non-positive.
1363 (bidi_level_of_next_char): Don't try to lookup the cache for the
1364 next/previous character if nothing is cached there yet, or if we
1365 were just reseat()'ed to a new position.
1366
1367 * xdisp.c (set_cursor_from_row): Set start and stop points
1368 according to the row's direction when priming the loop that looks
1369 for the glyph on which to display cursor.
1370 (single_display_spec_intangible_p): Function deleted.
1371 (display_prop_intangible_p): Reimplement to call
1372 handle_display_spec instead of single_display_spec_intangible_p.
1373 Accept 3 additional arguments needed by handle_display_spec.
1374 This fixes incorrect cursor motion across display property with complex
1375 values: lists, `(when COND...)' forms, etc.
1376 (single_display_spec_string_p): Support property values that are
1377 lists with the argument STRING its top-level element.
1378 (display_prop_string_p): Fix the condition for processing a
1379 property that is a list to be consistent with handle_display_spec.
1380 (handle_display_spec): New function, refactored from the
1381 last portion of handle_display_prop.
1382 (compute_display_string_pos): Accept additional argument
1383 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1384 value of a `display' property is a "replacing spec".
1385 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1386 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1387 the display property, but just return a value indicating whether
1388 the display property will replace the characters it covers.
1389 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1390 frame_window_p members of struct bidi_it.
1391 (compute_display_string_pos, compute_display_string_end):
1392 New functions.
1393 (push_it): Accept second argument POSITION, where pop_it should
1394 jump to continue iteration.
1395 (reseat_1): Initialize bidi_it.disp_pos.
1396
1397 * keyboard.c (adjust_point_for_property): Adjust the call to
1398 display_prop_intangible_p to its new signature.
1399
1400 * dispextern.h (struct bidi_it): New member frame_window_p.
1401 (bidi_init_it): Update prototypes.
1402 (display_prop_intangible_p): Update prototype.
1403 (compute_display_string_pos, compute_display_string_end):
1404 Declare prototypes.
1405 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1406 EMACS_INT.
1407
1408 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
1409
1410 Malloc failure behavior now depends on size of allocation.
1411 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1412 * lisp.h: Change signatures accordingly.
1413 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1414 All callers changed. (Bug#8762)
1415
1416 * gnutls.c: Use Emacs's memory allocators.
1417 Without this change, the gnutls library would invoke malloc etc.
1418 directly, which causes problems on non-SYNC_INPUT hosts, and which
1419 runs afoul of improving memory_full behavior. (Bug#8761)
1420 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1421 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1422 xfree instead of the default malloc, realloc, free.
1423 (Fgnutls_boot): No need to check for memory allocation failure,
1424 since xmalloc does that for us.
1425
1426 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1427 * category.c (hash_get_category_set):
1428 * ccl.c (ccl_driver):
1429 * charset.c (Fdefine_charset_internal):
1430 * charset.h (struct charset.hash_index):
1431 * composite.c (get_composition_id, gstring_lookup_cache)
1432 (composition_gstring_put_cache):
1433 * composite.h (struct composition.hash_index):
1434 * dispextern.h (struct image.hash):
1435 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1436 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1437 (hashfn_equal, hashfn_user_defined, make_hash_table)
1438 (maybe_resize_hash_table, hash_lookup, hash_put)
1439 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1440 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1441 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1442 * image.c (make_image, search_image_cache, lookup_image)
1443 (xpm_put_color_table_h):
1444 * lisp.h (struct Lisp_Hash_Table):
1445 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1446 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1447 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1448 * alloc.c (allocate_vectorlike):
1449 Check for overflow in vector size calculations.
1450 * ccl.c (ccl_driver):
1451 Check for overflow when converting EMACS_INT to int.
1452 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1453 need to be updated by these changes.
1454 * fns.c (make_hash_table, maybe_resize_hash_table):
1455 Check for integer overflow with large hash tables.
1456 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1457 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1458 (SXHASH_REDUCE): New macro.
1459 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1460 Use it instead of discarding useful hash info with large hash values.
1461 (sxhash_float): New function.
1462 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1463 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1464 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1465 Rewrite to use FIXNUM_BITS, as this simplifies things.
1466 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1467 Adjust signatures to match updated version of code.
1468 (consing_since_gc): Now EMACS_INT, since a single hash table can
1469 use more than INT_MAX bytes.
1470
1471 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1472
1473 Make it possible to build with GCC-4.6+ -O2 -flto.
1474
1475 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1476
1477 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1478
1479 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1480 Call minibuffer-inactive-mode.
1481
1482 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1483
1484 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1485 Update dependencies.
1486
1487 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1488
1489 * data.c (init_data): Remove code for UTS, this system is not
1490 supported anymore.
1491
1492 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1493
1494 Don't force ./temacs to start in terminal mode.
1495
1496 * frame.c (make_initial_frame): Initialize faces in all cases, not
1497 only when CANNOT_DUMP is defined.
1498 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1499
1500 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1501
1502 * dispnew.c (add_window_display_history): Use const for the string
1503 pointer. Remove declaration, not needed.
1504
1505 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1506
1507 Use 'inline', not 'INLINE'.
1508 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1509 * alloc.c, fontset.c (INLINE): Remove.
1510 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1511 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1512 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1513 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1514 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1515
1516 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1517
1518 Make it possible to run ./temacs.
1519
1520 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1521 syms_of_callproc does the same thing. Remove test for
1522 "initialized", do it in the caller.
1523 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1524
1525 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1526
1527 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1528 (read_minibuf): Use get_minibuffer.
1529 (syms_of_minibuf): Use DEFSYM.
1530 (Qmetadata): New var.
1531 * data.c (Qbuffer): Don't make it static.
1532 (syms_of_data): Use DEFSYM.
1533
1534 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1535
1536 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1537 (CCL_CODE_MIN): New macro.
1538
1539 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1540
1541 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1542
1543 * eval.c (Qdebug): Now static.
1544 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1545 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1546 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1547
1548 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1549
1550 * image.c: Various fixes to ImageMagick code comments.
1551 (Fimagemagick_types): Doc fix.
1552
1553 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1554
1555 Minor fixes prompted by GCC 4.6.0 warnings.
1556
1557 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1558
1559 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1560 (x_clipboard_manager_save_all): Move extern decl to ...
1561 * xterm.h: ... here, so that it can be checked for consistency.
1562
1563 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1564
1565 * xselect.c (x_clipboard_manager_save_frame)
1566 (x_clipboard_manager_save_all): New functions.
1567 (Fx_clipboard_manager_save): Lisp function deleted.
1568
1569 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1570 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1571
1572 * xterm.h: Update prototype.
1573
1574 2011-05-28 William Xu <william.xwl@gmail.com>
1575
1576 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1577 exiting (Bug#8239).
1578
1579 2011-05-28 Jim Meyering <meyering@redhat.com>
1580
1581 Avoid a sign-extension bug in crypto_hash_function.
1582 * fns.c (to_uchar): Define.
1583 (crypto_hash_function): Use it to convert some newly-signed
1584 variables to unsigned, to avoid sign-extension bugs. For example,
1585 without this change, (md5 "truc") would evaluate to
1586 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1587 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1588 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1589
1590 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1591
1592 Integer overflow fixes.
1593
1594 * dbusbind.c: Serial number integer overflow fixes.
1595 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1596 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1597 to hold a serial number that is too large for a fixnum.
1598 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1599 Check for serial numbers out of range. Decode any serial number
1600 that was so large that it became a float. (Bug#8722)
1601
1602 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1603 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1604 Use XFASTINT rather than XUINT when numbers are nonnegative.
1605 (xd_append_arg, Fdbus_method_return_internal):
1606 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1607 arguments, check that Lisp number is nonnegative, rather than
1608 silently wrapping negative numbers around. (Bug#8722)
1609 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1610 (Bug#8722)
1611
1612 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1613
1614 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1615
1616 ccl: add integer overflow checks
1617 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1618 (IN_INT_RANGE): New macros.
1619 (ccl_driver): Use them to check for integer overflow when
1620 decoding a CCL program. Many of the new checks are whether XINT (x)
1621 fits in int; it doesn't always, on 64-bit hosts. The new version
1622 doesn't catch all possible integer overflows, but it's an
1623 improvement. (Bug#8719)
1624
1625 * alloc.c (make_event_array): Use XINT, not XUINT.
1626 There's no need for unsigned here.
1627
1628 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1629 This follows up to the 2011-05-06 change that substituted uintptr_t
1630 for EMACS_INT. This case wasn't caught back then.
1631
1632 Rework Fformat to avoid integer overflow issues.
1633 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1634 now (part of C89). Include <verify.h>.
1635 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1636 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1637 (Fformat): Avoid the prepass trying to compute sizes; it was only
1638 approximate and thus did not catch overflow reliably. Instead, walk
1639 through the format just once, formatting and computing sizes as we go,
1640 checking for integer overflow at every step, and allocating a larger
1641 buffer as needed. Keep track separately whether the format is
1642 multibyte. Keep only the most-recently calculated precision, rather
1643 than them all. Record whether each argument has been converted to
1644 string. Use EMACS_INT, not int, for byte and char and arg counts.
1645 Support field widths and precisions larger than INT_MAX. Avoid
1646 sprintf's undefined behavior with conversion specifications such as %#d
1647 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1648 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1649 formatting out-of-range floating point numbers with int
1650 formats. (Bug#8668)
1651
1652 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1653
1654 * data.c: Avoid integer truncation in expressions involving floats.
1655 * data.c: Include <intprops.h>.
1656 (arith_driver): When there's an integer overflow in an expression
1657 involving floating point, convert the integers to floating point
1658 so that the resulting value does not suffer from catastrophic
1659 integer truncation. For example, on a 64-bit host (* 4
1660 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1661 Do not rely on undefined behavior after integer overflow.
1662
1663 merge count_size_as_multibyte, parse_str_to_multibyte
1664 * character.c, character.h (count_size_as_multibyte):
1665 Rename from parse_str_to_multibyte; all uses changed.
1666 Check for integer overflow.
1667 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1668 since it's now a duplicate of the other. This is more of
1669 a character than a buffer op, so better that it's in character.c.
1670 * fns.c, print.c: Adjust to above changes.
1671
1672 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1673
1674 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1675
1676 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1677
1678 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1679 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1680 (x_clipboard_manager_save): Now static.
1681 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1682
1683 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1684 (crypto_hash_function): Now static.
1685 Fix pointer signedness problems. Avoid unnecessary initializations.
1686
1687 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1688
1689 * termhooks.h (Vselection_alist): Make it terminal-local.
1690
1691 * terminal.c (create_terminal): Initialize it.
1692
1693 * xselect.c: Support for clipboard managers.
1694 (Vselection_alist): Move to termhooks.h as terminal-local var.
1695 (LOCAL_SELECTION): New macro.
1696 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1697 (symbol_to_x_atom): Remove gratuitous arg.
1698 (x_handle_selection_request, lisp_data_to_selection_data)
1699 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1700 (x_own_selection, x_get_local_selection, x_convert_selection):
1701 New arg, specifying work frame. Use terminal-local Vselection_alist.
1702 (some_frame_on_display): Delete unused function.
1703 (Fx_own_selection_internal, Fx_get_selection_internal)
1704 (Fx_disown_selection_internal, Fx_selection_owner_p)
1705 (Fx_selection_exists_p): New optional frame arg.
1706 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1707 (x_handle_selection_clear): Don't treat other terminals with the
1708 same keyboard specially. Use the terminal-local Vselection_alist.
1709 (x_clear_frame_selections): Use Frun_hook_with_args.
1710
1711 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1712
1713 * xterm.h: Add support for those atoms.
1714
1715 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1716
1717 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1718 (converted_selections, conversion_fail_tag): New global variables.
1719 (x_selection_request_lisp_error): Free the above.
1720 (x_get_local_selection): Remove unnecessary code.
1721 (x_reply_selection_request): Args changed; handle arbitrary array
1722 of converted selections stored in converted_selections.
1723 Separate the XChangeProperty and SelectionNotify steps.
1724 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1725 (x_convert_selection): New function.
1726 (x_handle_selection_event): Simplify.
1727 (x_get_foreign_selection): Don't ignore incoming requests while
1728 waiting for an answer; this will fail when we implement
1729 SAVE_TARGETS, and seems unnecessary anyway.
1730 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1731 (Vx_sent_selection_functions): Doc fix.
1732
1733 2011-05-26 Leo Liu <sdl.web@gmail.com>
1734
1735 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1736
1737 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1738
1739 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1740
1741 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1742 for fringe update if it has periodic bitmap.
1743 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1744 and fringe_bitmap_periodic_p.
1745
1746 * fringe.c (get_fringe_bitmap_data): New function.
1747 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1748 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1749 row. Mark glyph row for fringe update if periodicity changed.
1750
1751 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1752 for fringe update unless it has periodic bitmap.
1753
1754 2011-05-25 Kenichi Handa <handa@m17n.org>
1755
1756 * xdisp.c (get_next_display_element): Set correct it->face_id for
1757 a static composition.
1758
1759 2011-05-24 Leo Liu <sdl.web@gmail.com>
1760
1761 * deps.mk (fns.o):
1762 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1763
1764 * fns.c (crypto_hash_function, Fsha1): New function.
1765 (Fmd5): Use crypto_hash_function.
1766 (syms_of_fns): Add Ssha1.
1767
1768 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1769
1770 * gnutls.c: Remove unused macros.
1771 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1772 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1773 Remove macros that are defined and never used.
1774 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1775
1776 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1777
1778 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1779 (Fx_get_selection_internal): Minor cleanup.
1780 (Fx_own_selection_internal): Rename arguments for consistency with
1781 select.el.
1782
1783 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1784
1785 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1786
1787 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1788
1789 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1790
1791 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1792
1793 * dispnew.c (scrolling_window): Don't exclude the case that the
1794 last enabled row in the desired matrix touches the bottom boundary.
1795
1796 2011-05-21 Glenn Morris <rgm@gnu.org>
1797
1798 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1799 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1800 and add some more files.
1801
1802 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1803
1804 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1805 report_file_error introduced by the change from 2011-05-07.
1806
1807 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1808
1809 * systime.h (Time): Define only if emacs is defined.
1810 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1811 where the include path doesn't have X11/X.h by default. See
1812 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1813
1814 2011-05-20 Kenichi Handa <handa@m17n.org>
1815
1816 * composite.c (find_automatic_composition): Fix previous change.
1817
1818 2011-05-20 Glenn Morris <rgm@gnu.org>
1819
1820 * lisp.mk: New file, split from Makefile.in.
1821 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1822 (shortlisp): Remove.
1823 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1824
1825 2011-05-19 Glenn Morris <rgm@gnu.org>
1826
1827 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1828 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1829 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1830 (lisp): Set the order to that of loadup.el.
1831 (shortlisp): Make it a copy of $lisp.
1832 (SOME_MACHINE_LISP): Remove.
1833 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1834 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1835
1836 2011-05-18 Kenichi Handa <handa@m17n.org>
1837
1838 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1839 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1840 (find_automatic_composition): Mostly rewrite for efficiency.
1841
1842 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1843
1844 * makefile.w32-in: Update dependencies.
1845
1846 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1847
1848 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1849 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
1850
1851 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1852
1853 Fix some integer overflow issues, such as string length overflow.
1854
1855 * insdel.c (count_size_as_multibyte): Check for string overflow.
1856
1857 * character.c (lisp_string_width): Check for string overflow.
1858 Use EMACS_INT, not int, for string indexes and lengths; in
1859 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1860 the resulting string length overflows an EMACS_INT; instead,
1861 report a string overflow if no precision given. When checking for
1862 precision exhaustion, use a check that cannot possibly have
1863 integer overflow. (Bug#8675)
1864 * character.h (lisp_string_width): Adjust to new signature.
1865
1866 * alloc.c (string_overflow): New function.
1867 (Fmake_string): Use it. This doesn't change behavior, but saves
1868 a few bytes and will simplify future changes.
1869 * character.c (string_escape_byte8): Likewise.
1870 * lisp.h (string_overflow): New decl.
1871
1872 Fixups, following up to the user-interface timestamp change.
1873 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1874 for UI timestamps, instead of unsigned long.
1875 * msdos.c (mouse_get_pos): Likewise.
1876 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1877 * w32gui.h (Time): Define by including "systime.h" rather than by
1878 declaring it ourselves. (Bug#8664)
1879
1880 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1881 * image.c (clear_image_cache): Likewise.
1882
1883 * term.c (term_mouse_position): Don't assume time_t wraparound.
1884
1885 Be more systematic about user-interface timestamps.
1886 Before, the code sometimes used 'Time', sometimes 'unsigned long',
1887 and sometimes 'EMACS_UINT', to represent these timestamps.
1888 This change causes it to use 'Time' uniformly, as that's what X uses.
1889 This makes the code easier to follow, and makes it easier to catch
1890 integer overflow bugs such as Bug#8664.
1891 * frame.c (Fmouse_position, Fmouse_pixel_position):
1892 Use Time, not unsigned long, for user-interface timestamps.
1893 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1894 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1895 * keyboard.h (last_event_timestamp): Likewise.
1896 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1897 * menu.h (xmenu_show): Likewise.
1898 * term.c (term_mouse_position): Likewise.
1899 * termhooks.h (struct input_event.timestamp): Likewise.
1900 (struct terminal.mouse_position_hook): Likewise.
1901 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1902 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1903 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1904 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1905 what it was before.
1906 * menu.h, termhooks.h: Include "systime.h", for Time.
1907
1908 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1909 Don't assume that the difference between two unsigned long values
1910 can fit into an integer. At this point, we know button_down_time
1911 <= event->timestamp, so the difference must be nonnegative, so
1912 there's no need to cast the result if double-click-time is
1913 nonnegative, as it should be; check that it's nonnegative, just in
1914 case. This bug is triggered when events are more than 2**31 ms
1915 apart (about 25 days). (Bug#8664)
1916
1917 * xselect.c (last_event_timestamp): Remove duplicate decl.
1918 (x_own_selection): Remove needless cast to unsigned long.
1919
1920 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1921 that always fit in int. Use a sentinel instead of a counter, to
1922 avoid a temp and to allay GCC's concerns about possible int overflow.
1923 * frame.h (struct frame): Use int for menu_bar_items_used
1924 instead of EMACS_INT, since it always fits in int.
1925
1926 * menu.c (grow_menu_items): Check for int overflow.
1927
1928 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1929
1930 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1931 Before, the code was not consistent. These values cannot exceed
1932 2**31 - 1 so there's no need to make them unsigned.
1933 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1934 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1935 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1936 as modifiers.
1937 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1938
1939 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1940 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1941 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1942 presumably because the widths might not match.
1943
1944 * window.c (size_window): Avoid needless test at loop start.
1945
1946 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1947
1948 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1949
1950 2011-05-12 Drew Adams <drew.adams@oracle.com>
1951
1952 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1953
1954 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1955
1956 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1957 `width' to `bar_area_x' and `bar_area_width', respectively.
1958 (x_scroll_run): Take account of fringe background extension.
1959
1960 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1961 Rename local vars `left' and `width' to `bar_area_x' and
1962 `bar_area_width', respectively.
1963 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1964 background extension.
1965
1966 2011-05-10 Jim Meyering <meyering@redhat.com>
1967
1968 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1969
1970 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
1971
1972 * image.c (Finit_image_library): Return t for built-in image types,
1973 like pbm and xbm. (Bug#8640)
1974
1975 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1976
1977 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1978
1979 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1980
1981 * w32console.c (Fset_screen_color): Doc fix.
1982 (Fget_screen_color): New function.
1983 (syms_of_ntterm): Defsubr it.
1984
1985 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1986 unlink the temporary file if Fcall_process didn't create it in the
1987 first place.
1988 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1989 child process will be redirected to a file specified with `:file'.
1990 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1991 cue to call_process_cleanup not to close that handle.
1992
1993 2011-05-07 Ben Key <bkey76@gmail.com>
1994
1995 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1996 one of two shell specific rules, either bootstrap-temacs-CMD or
1997 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1998 to the previous implementation of the bootstrap-temacs rule.
1999 The bootstrap-temacs-CMD rule is similar to the previous
2000 implementation of the bootstrap-temacs rule except that it
2001 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2002 variable.
2003
2004 These changes, along with some changes to nt/configure.bat,
2005 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2006 earlier fix to add support for --cflags and --ldflags options
2007 that include quotes so that it works whether make uses cmd or
2008 sh as the shell.
2009
2010 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
2011
2012 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2013 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2014 is a constant.
2015 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2016 a string. Handle both cases.
2017 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2018 (Fdbus_register_method): Use Qinvalid_function.
2019
2020 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2021
2022 * makefile.w32-in: Update dependencies.
2023 (LISP_H): Add inttypes.h and stdin.h.
2024 (PROCESS_H): Add unistd.h.
2025
2026 2011-05-06 Eli Zaretskii <eliz@gnu.org>
2027
2028 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2029 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2030
2031 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
2032
2033 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2034
2035 * term.c (vfatal): Remove stray call to va_end.
2036 It's not needed and the C Standard doesn't allow it here anyway.
2037
2038 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2039 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2040
2041 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2042 bytes.
2043
2044 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2045
2046 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2047
2048 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2049
2050 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2051
2052 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2053
2054 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2055 * charset.c (Fdefine_charset_internal): Don't initialize
2056 charset.code_space[15]. The value was garbage, on hosts with
2057 32-bit int (Bug#8600).
2058
2059 * lread.c (read_integer): Be more consistent with string-to-number.
2060 Use string_to_number to do the actual conversion; this avoids
2061 rounding errors and fixes some other screwups. Without this fix,
2062 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2063 (digit_to_number): Move earlier, for benefit of read_integer.
2064 Return -1 if the digit is out of range for the base, -2 if it is
2065 not a digit in any supported base. (Bug#8602)
2066
2067 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2068
2069 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2070 to match comment at start of function. This also removes a
2071 GCC warning about overflow in a 32+64-bit port.
2072
2073 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2074
2075 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2076 Reported by Stefan Monnier in
2077 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
2078 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2079 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
2080
2081 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2082 (EMACS_UINTPTR): Likewise, with uintptr_t.
2083
2084 * lisp.h: Prefer 64-bit EMACS_INT if available.
2085 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2086 on 32-bit hosts that have 64-bit int, so that they can access
2087 large files.
2088 However, temporarily disable this change unless the temporary
2089 symbol WIDE_EMACS_INT is defined.
2090
2091 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2092
2093 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2094 This removes an assumption that EMACS_INT and long are the same
2095 width as pointers. The assumption is true for Emacs porting targets
2096 now, but we want to make other targets possible.
2097 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2098 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2099 In the rest of the code, change types of integers that hold casted
2100 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2101 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2102 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2103 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2104 No need to cast type when ORing.
2105 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2106 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2107 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2108 assume EMACS_INT is the same width as char *.
2109 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2110 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2111 Remove no-longer-needed casts.
2112 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2113 (xg_tool_bar_help_callback, xg_make_tool_item):
2114 Use EMACS_INTPTR to hold an integer
2115 that will be cast to void *; this can avoid a GCC warning
2116 if EMACS_INT is not the same width as void *.
2117 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2118 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2119 (current_message_1, set_message_1):
2120 Use a local to convert to proper width without a cast.
2121 * xmenu.c (dialog_selection_callback): Likewise.
2122
2123 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2124 Also, don't assume VALBITS / RAND_BITS is less than 5,
2125 and don't rely on undefined behavior when shifting a 1 left into
2126 the sign bit.
2127 * lisp.h (get_random): Change signature to match.
2128
2129 * lread.c (hash_string): Use size_t, not int, for hash computation.
2130 Normally we prefer signed values; but hashing is special, because
2131 it's better to use unsigned division on hash table sizes so that
2132 the remainder is nonnegative. Also, size_t is the natural width
2133 for hashing into memory. The previous code used 'int', which doesn't
2134 retain enough info to hash well into very large tables.
2135 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2136
2137 * dbusbind.c: Don't possibly lose pointer info when converting.
2138 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2139 Use XPNTR rather than XHASH, so that the high-order bits of
2140 the pointer aren't lost when converting through void *.
2141
2142 * eval.c (Fautoload): Don't double-shift a pointer.
2143
2144 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2145
2146 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2147
2148 * gnutls.c (DEF_GNUTLS_FN):
2149 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2150
2151 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2152
2153 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2154 marker. (Bug#8610)
2155
2156 2011-05-05 Eli Zaretskii <eliz@gnu.org>
2157
2158 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2159 New version that can reserve upto 2GB of heap space.
2160
2161 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
2162
2163 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2164
2165 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2166
2167 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2168 `gnutls_certificate_set_x509_key_file'.
2169
2170 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
2171
2172 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2173 Update dependencies.
2174
2175 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2176
2177 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2178 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2179 Remove unused parameter `fildes'.
2180 * process.c (read_process_output, send_process): Don't pass it.
2181
2182 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2183
2184 Fix previous change: the library cache is defined in w32.c.
2185 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2186 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2187
2188 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2189
2190 Implement dynamic loading of GnuTLS on Windows.
2191
2192 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2193 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2194 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2195 Declare.
2196
2197 * gnutls.c (Qgnutls_dll): Define.
2198 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2199 (gnutls_*): Declare function pointers.
2200 (init_gnutls_functions): New function to initialize function pointers.
2201 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2202 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2203 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2204 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2205 (emacs_gnutls_write, emacs_gnutls_read)
2206 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2207 (Fgnutls_available_p): New function.
2208 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2209 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2210 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2211
2212 * image.c: Include w32.h.
2213 (Vimage_type_cache): Delete.
2214 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2215 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2216 (w32_delayed_load): Move to w32.c.
2217
2218 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2219
2220 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2221 (w32_delayed_load): Move from image.c. When loading a library, record
2222 its filename in the :loaded-from property of the library id.
2223 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2224 Initialize and staticpro them.
2225 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2226
2227 * process.c: Include lisp.h before w32.h, not after.
2228 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2229 instead of gnutls_record_check_pending.
2230
2231 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2232
2233 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2234
2235 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2236 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2237 as passed in.
2238
2239 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2240
2241 * xterm.c (x_set_frame_alpha): Do not set property on anything
2242 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2243
2244 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2245
2246 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2247
2248 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2249
2250 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2251 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2252 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2253 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2254 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2255 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2256 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2257 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2258 (Qgnutls_bootprop_callbacks_verify): Make static.
2259
2260 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2261
2262 * callproc.c: Indentation fixup.
2263
2264 * sysdep.c (wait_for_termination_1): Make static.
2265 (wait_for_termination, interruptible_wait_for_termination):
2266 Move after wait_for_termination_1.
2267
2268 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2269
2270 * sysdep.c (interruptible_wait_for_termination): New function
2271 which is like wait_for_termination, but allows keyboard
2272 interruptions.
2273
2274 * callproc.c (Fcall_process): Add (:file "file") as an option for
2275 the STDOUT buffer.
2276 (Fcall_process_region): Ditto.
2277
2278 2011-04-30 Eli Zaretskii <eliz@gnu.org>
2279
2280 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2281 rather than `XVECTOR (FOO)->size'.
2282
2283 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2284 inttypes.h, as a gnulib replacement is used if it not available in
2285 system headers.
2286
2287 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2288
2289 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2290 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2291 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2292
2293 * coding.c (coding_alloc_by_realloc): Error out if destination
2294 will grow beyond MOST_POSITIVE_FIXNUM.
2295 (decode_coding_emacs_mule): Abort if there isn't enough place in
2296 charbuf for the composition carryover bytes. Reserve an extra
2297 space for up to 2 characters produced in a loop.
2298 (decode_coding_iso_2022): Abort if there isn't enough place in
2299 charbuf for the composition carryover bytes.
2300
2301 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2302
2303 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2304 aborting when %lld or %lll format is passed.
2305 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2306 %llo or %llx format is passed. (Bug#8545)
2307
2308 * window.c (window_scroll_line_based): Use a marker instead of
2309 simple variables to record original value of point. (Bug#7952)
2310
2311 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2312 produced by %s or %c overflows available buffer space. (Bug#8545)
2313
2314 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2315
2316 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
2317 (SIZE_MAX): Move defn after all includes, as they might #define it.
2318
2319 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2320
2321 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2322
2323 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2324
2325 * keyboard.c (Qdelayed_warnings_hook): Define.
2326 (command_loop_1): Run `delayed-warnings-hook'
2327 if Vdelayed_warnings_list is non-nil.
2328 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2329 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2330
2331 2011-04-28 Eli Zaretskii <eliz@gnu.org>
2332
2333 * doprnt.c (doprnt): Don't return value smaller than the buffer
2334 size if the message was truncated. (Bug#8545).
2335
2336 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2337
2338 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2339 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2340
2341 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2342
2343 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2344
2345 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
2346
2347 * makefile.w32-in: Update dependencies.
2348
2349 2011-04-27 Eli Zaretskii <eliz@gnu.org>
2350
2351 Improve `doprnt' and its usage. (Bug#8545)
2352 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2353 `format_end'. Remove support for %l as a conversion specifier.
2354 Don't use xrealloc. Improve diagnostics when the %l size modifier
2355 is used. Update the commentary.
2356
2357 * eval.c (verror): Simplify calculation of size_t.
2358
2359 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2360 messages.
2361
2362 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2363
2364 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2365 change.
2366
2367 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2368
2369 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2370 This makes this file independent of the recent pseudovector change.
2371
2372 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
2373
2374 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2375
2376 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
2377 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
2378 Remove unused local.
2379 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
2380
2381 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
2382 GCC 4.6.0 optimizes based on type-based alias analysis.
2383 For example, if b is of type struct buffer * and v of type struct
2384 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2385 != &v->size, and therefore "v->size = 1; b->size = 2; return
2386 v->size;" must therefore return 1. This assumption is incorrect
2387 for Emacs, since it type-puns struct Lisp_Vector * with many other
2388 types. To fix this problem, this patch adds a new type struct
2389 vectorlike_header that documents the constraints on layout of vectors
2390 and pseudovectors, and helps optimizing compilers not get fooled
2391 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2392 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
2393 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2394 the size member.
2395 (XSETPVECTYPE): Rewrite in terms of new macro.
2396 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2397 This is a bit clearer, and further avoids the possibility of
2398 undesirable aliasing.
2399 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
2400 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
2401 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2402 since Lisp_Subr is a special case (no "next" field).
2403 (ASIZE): Now uses header.size rather than size.
2404 All previous uses of XVECTOR (foo)->size replaced to use this macro,
2405 to avoid the hassle of writing XVECTOR (foo)->header.size.
2406 (struct vectorlike_header): New type.
2407 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2408 object, to help avoid aliasing.
2409 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2410 (SUBRP): Likewise, since Lisp_Subr is a special case.
2411 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2412 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2413 (struct Lisp_Hash_Table): Combine first two members into a single
2414 struct vectorlike_header member. All uses of "size" and "next" members
2415 changed to be "header.size" and "header.next".
2416 * buffer.h (struct buffer): Likewise.
2417 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2418 * frame.h (struct frame): Likewise.
2419 * process.h (struct Lisp_Process): Likewise.
2420 * termhooks.h (struct terminal): Likewise.
2421 * window.c (struct save_window_data, struct saved_window): Likewise.
2422 * window.h (struct window): Likewise.
2423 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2424 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2425 * buffer.c (init_buffer_once): Likewise.
2426 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2427 special case.
2428 * process.c (Fformat_network_address): Use local var for size,
2429 for brevity.
2430
2431 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2432
2433 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2434 * data.c (atof): Remove decl; no longer used or needed.
2435 (digit_to_number): Move to lread.c.
2436 (Fstring_to_number): Use new string_to_number function, to be
2437 consistent with how the Lisp reader treats infinities and NaNs.
2438 Do not assume that floating-point numbers represent EMACS_INT
2439 without losing information; this is not true on most 64-bit hosts.
2440 Avoid double-rounding errors, by insisting on integers when
2441 parsing non-base-10 numbers, as the documentation specifies.
2442 * lisp.h (string_to_number): New decl, replacing ...
2443 (isfloat_string): Remove.
2444 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2445 (read1): Do not accept +. and -. as integers; this
2446 appears to have been a coding error. Similarly, do not accept
2447 strings like +-1e0 as floating point numbers. Do not report
2448 overflow for integer overflows unless the base is not 10 which
2449 means we have no simple and reliable way to continue.
2450 Break out the floating-point parsing into a new
2451 function string_to_number, so that Fstring_to_number parses
2452 floating point numbers consistently with the Lisp reader.
2453 (digit_to_number): Move here from data.c. Make it static inline.
2454 (E_CHAR, EXP_INT): Remove, replacing with ...
2455 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2456 (string_to_number): New function, replacing isfloat_string.
2457 This function checks for valid syntax and produces the resulting
2458 Lisp float number too. Rework it so that string-to-number
2459 no longer mishandles examples like "1.0e+". Use strtoumax,
2460 so that overflow for non-base-10 numbers is reported only when
2461 there's no portable and simple way to convert to floating point.
2462
2463 * textprop.c (set_text_properties_1): Rewrite for clarity,
2464 and to avoid GCC warning about integer overflow.
2465
2466 * intervals.h (struct interval): Use EMACS_INT for members
2467 where EMACS_UINT might cause problems. See
2468 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2469 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2470 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2471 All uses changed.
2472 (offset_intervals): Tell GCC not to worry about length overflow
2473 when negating a negative length.
2474
2475 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2476 (overrun_check_free): Likewise.
2477
2478 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2479 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2480 word size.
2481
2482 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2483 (gnutls_make_error): Rename local to avoid shadowing.
2484 (gnutls_emacs_global_deinit): ifdef out; not used.
2485 (Fgnutls_boot): Use const for pointer to readonly storage.
2486 Comment out unused local. Fix pointer signedness problems.
2487
2488 * lread.c (openp): Don't stuff size_t into an 'int'.
2489 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2490 about possible signed overflow.
2491
2492 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2493 (GDK_KEY_g): Don't define if already defined.
2494 (xg_prepare_tooltip): Avoid pointer signedness problem.
2495 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2496
2497 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2498 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2499
2500 * xfns.c (Fx_window_property): Simplify a bit,
2501 to make a bit faster and to avoid GCC 4.6.0 warning.
2502 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2503
2504 * fns.c (internal_equal): Don't assume size_t fits in int.
2505
2506 * alloc.c (compact_small_strings): Tighten assertion a little.
2507
2508 Replace pEd with more-general pI, and fix some printf arg casts.
2509 * lisp.h (pI): New macro, generalizing old pEd macro to other
2510 conversion specifiers. For example, use "...%"pI"d..." rather
2511 than "...%"pEd"...".
2512 (pEd): Remove. All uses replaced with similar uses of pI.
2513 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2514 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2515 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2516 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2517 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2518 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2519 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2520 64-bit hosts.
2521 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2522 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2523 * print.c (safe_debug_print, print_object): Likewise.
2524 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2525 to int.
2526 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2527 avoiding the 0 flag, which is not portable.
2528 * process.c (Fmake_network_process): Use pI to avoid cast.
2529 * region-cache.c (pp_cache): Likewise.
2530 * xdisp.c (decode_mode_spec): Likewise.
2531 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2532 behavior on 64-bit hosts with printf arg.
2533 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2534 (x_stop_queuing_selection_requests): Likewise.
2535 (x_get_window_property): Don't truncate byte count to an 'int'
2536 when tracing.
2537
2538 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2539 here, since it parses constructs like leading '-' and spaces,
2540 which are not wanted; and it overflows with large numbers.
2541 Instead, simply match F[0-9]+, which is what is wanted anyway.
2542
2543 * alloc.c: Remove unportable assumptions about struct layout.
2544 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2545 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2546 (allocate_vectorlike, make_pure_vector): Use the new macros,
2547 plus offsetof, to remove unportable assumptions about struct layout.
2548 These assumptions hold on all porting targets that I know of, but
2549 they are not guaranteed, they're easy to remove, and removing them
2550 makes further changes easier.
2551
2552 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2553 This doesn't fix a bug but makes the code clearer.
2554 (string_overrun_cookie): Now const. Use initializers that
2555 don't formally overflow signed char, to avoid warnings.
2556 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2557 can cause Emacs to crash when string overrun checking is enabled.
2558 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2559 multiple of sizeof (EMACS_INT); it need not be, if
2560 alignof(EMACS_INT) < sizeof (EMACS_INT).
2561 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2562
2563 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2564
2565 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2566
2567 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2568
2569 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2570 supposed to be handshaking. (Bug#8556)
2571 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2572
2573 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2574
2575 * lisp.h (Qdebug): List symbol.
2576 * eval.c (Qdebug): Restore global linkage.
2577 * keyboard.c (debug-on-event): New variable.
2578 (handle_user_signal): Break into debugger when debug-on-event
2579 matches the current signal symbol.
2580
2581 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2582
2583 * alloc.c (check_sblock, check_string_bytes)
2584 (check_string_free_list): Convert to standard C.
2585
2586 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2587
2588 * w32.c (emacs_gnutls_push): Fix typo.
2589
2590 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2591
2592 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2593 "cast to pointer from integer of different size".
2594
2595 Improve doprnt and its use in verror. (Bug#8545)
2596 * doprnt.c (doprnt): Document the set of format control sequences
2597 supported by the function. Use SAFE_ALLOCA instead of always
2598 using `alloca'.
2599
2600 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2601 is one byte too soon. Don't use xrealloc; instead xfree and
2602 xmalloc anew.
2603
2604 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2605
2606 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2607 callbacks stage.
2608
2609 * gnutls.c: Renamed global_initialized to
2610 gnutls_global_initialized. Added internals for the
2611 :verify-hostname-error, :verify-error, and :verify-flags
2612 parameters of `gnutls-boot' and documented those parameters in the
2613 docstring. Start callback support.
2614 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2615 unless a fatal error occured. Call gnutls_alert_send_appropriate
2616 on error. Return error code.
2617 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2618 (emacs_gnutls_read): Likewise.
2619 (Fgnutls_boot): Return handshake error code.
2620 (emacs_gnutls_handle_error): New function.
2621 (wsaerror_to_errno): Likewise.
2622
2623 * w32.h (emacs_gnutls_pull): Add prototype.
2624 (emacs_gnutls_push): Likewise.
2625
2626 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2627 (emacs_gnutls_push): Likewise.
2628
2629 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2630
2631 * process.c (wait_reading_process_output): Check if GnuTLS
2632 buffered some data internally if no FDs are set for TLS
2633 connections.
2634
2635 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2636 (LIBS): Link to USER_LIBS.
2637 ($(BLD)/gnutls.$(0)): New target.
2638
2639 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2640
2641 * xdisp.c (handle_single_display_spec): Rename the
2642 display_replaced_before_p argument into display_replaced_p, to
2643 make it consistent with the commentary. Fix typos in the
2644 commentary.
2645
2646 * textprop.c (syms_of_textprop): Remove dead code.
2647 (copy_text_properties): Delete obsolete commentary about an
2648 interface that was deleted long ago. Fix typos in the description
2649 of arguments.
2650
2651 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2652 to changes in oldXMenu/XMenu.h from 2011-04-16.
2653 <menu_help_message, prev_menu_help_message>: Constify.
2654 (IT_menu_make_room): menu->help_text is now `const char **';
2655 adjust.
2656
2657 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2658 to changes in oldXMenu/XMenu.h from 2011-04-16.
2659 (struct XMenu): Declare `help_text' `const char **'.
2660
2661 * xfaces.c <Qunspecified>: Make extern again.
2662
2663 * syntax.c: Include sys/types.h before including regex.h, as
2664 required by Posix.
2665
2666 * doc.c (get_doc_string): Improve the format passed to `error'.
2667
2668 * doprnt.c (doprnt): Improve commentary.
2669
2670 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2671
2672 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2673 them with etags.
2674
2675 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2676 changes in globals.h immediately force recompilation.
2677 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2678 $(CURDIR)/s/ms-w32.h.
2679 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2680
2681 * character.c (Fchar_direction): Function deleted.
2682 (syms_of_character): Don't defsubr it.
2683 <char-direction-table>: Deleted.
2684
2685 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2686
2687 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2688 * doprnt.c: Include limits.h.
2689 (SIZE_MAX): New macro.
2690 (doprnt): Return a size_t value. 2nd arg is now size_t.
2691 Many local variables are now size_t instead of int or unsigned.
2692 Improve overflow protection. Support `l' modifier for integer
2693 conversions. Support %l conversion. Don't assume an EMACS_INT
2694 argument for integer conversions and for %c.
2695
2696 * lisp.h (doprnt): Restore prototype.
2697
2698 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2699 $(SRC)/character.h.
2700
2701 * Makefile.in (base_obj): Add back doprnt.o.
2702
2703 * deps.mk (doprnt.o): Add back prerequisites.
2704 (callint.o): Depend on character.h.
2705
2706 * eval.c (internal_lisp_condition_case): Include the handler
2707 representation in the error message.
2708 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2709 when breaking from the loop.
2710
2711 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2712
2713 * callint.c (Fcall_interactively): When displaying error message
2714 about invalid control letter, pass the character's codepoint, not
2715 a pointer to its multibyte form. Improve display of the character
2716 in octal and display also its hex code.
2717
2718 * character.c (char_string): Use %x to display the (unsigned)
2719 codepoint of an invalid character, to avoid displaying a bogus
2720 negative value.
2721
2722 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2723 `error', not SYMBOL_NAME itself.
2724
2725 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2726 character arguments to `error'.
2727
2728 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2729 to `error' in error message about FINAL_CHAR argument. Make sure
2730 FINAL_CHAR is a character, and use %c when it is passed as
2731 argument to `error'.
2732
2733 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2734
2735 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2736
2737 * w32.c: Include <time.h>.
2738 (sys_localtime): New function.
2739
2740 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2741
2742 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2743
2744 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2745
2746 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2747
2748 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2749 zombies (Bug#8467).
2750
2751 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2752
2753 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2754 gl_state.e_property when gl_state.object is Qt.
2755
2756 * insdel.c (make_gap_larger): Remove limitation of buffer size
2757 to <= INT_MAX.
2758
2759 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2760
2761 * xdisp.c (lookup_glyphless_char_display)
2762 (produce_glyphless_glyph): Handle cons cell entry in
2763 glyphless-char-display.
2764 (Vglyphless_char_display): Document it.
2765
2766 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2767 glyphless-char-display.
2768
2769 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2770
2771 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2772
2773 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2774
2775 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2776 definition for no-X builds.
2777
2778 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2779
2780 Static checks with GCC 4.6.0 and non-default toolkits.
2781
2782 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2783
2784 * process.c (keyboard_bit_set): Define only if SIGIO.
2785 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2786 (send_process): Repair possible setjmp clobbering.
2787
2788 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2789
2790 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2791
2792 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2793
2794 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2795 Define only if needed.
2796
2797 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2798 by pacifying GCC about it. Maybe it's time to retire it?
2799 * xfaces.c (USG, __TIMEVAL__): Likewise.
2800
2801 * dispextern.h (struct redisplay_interface): Rename param
2802 to avoid shadowing.
2803 * termhooks.h (struct terminal): Likewise.
2804 * xterm.c (xembed_send_message): Likewise.
2805
2806 * insdel.c (make_gap_smaller): Define only if
2807 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2808
2809 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2810 it.
2811
2812 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2813 so that we aren't warned about unused symbols.
2814
2815 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2816
2817 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2818
2819 * xfns.c (x_real_positions): Mark locals as initialized.
2820
2821 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2822
2823 * xterm.c: Fix problems found by static analysis with other toolkits.
2824 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2825 (x_dispatch_event): Declare static if USE_GTK, and
2826 define if USE_GTK || USE_X_TOOLKIT.
2827 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2828 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2829 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2830 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2831
2832 * xmenu.c (menu_help_callback): Pointer type fixes.
2833 Use const pointers when pointing at readonly data. Avoid pointer
2834 signedness clashes.
2835 (FALSE): Remove unused macro.
2836 (update_frame_menubar): Remove unused decl.
2837
2838 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2839
2840 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2841 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2842 (single_menu_item): Rename local to avoid shadowing.
2843
2844 * keyboard.c (make_lispy_event): Remove unused local var.
2845
2846 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2847 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2848
2849 * bitmaps: Change bitmaps from unsigned char back to the X11
2850 compatible char. Avoid the old compiler warnings about
2851 out-of-range initializers by using, for example, '\xab' rather
2852 than 0xab.
2853
2854 * xgselect.c (xgselect_initialize): Check vs interface
2855 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2856
2857 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2858
2859 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2860 to read-only memory.
2861
2862 * fns.c (vector): Remove; this old hack is no longer needed.
2863
2864 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2865 Remove unused var.
2866 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2867
2868 * xrdb.c (x_load_resources): Omit unused local.
2869
2870 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2871 (x_window): Rename locals to avoid shadowing.
2872 (USG): Use the kludged USG macro, to pacify gcc.
2873
2874 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2875 (x_term_init): Remove local to avoid shadowing.
2876
2877 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2878
2879 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2880 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2881
2882 2011-04-16 Eli Zaretskii <eliz@gnu.org>
2883
2884 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2885
2886 Fix regex.c, syntax.c and friends for buffers > 2GB.
2887 * syntax.h (struct gl_state_s): Declare character position members
2888 EMACS_INT.
2889
2890 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2891
2892 * textprop.c (verify_interval_modification, interval_of):
2893 Declare arguments EMACS_INT.
2894
2895 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2896 EMACS_INT.
2897
2898 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2899
2900 * indent.c (Fvertical_motion): Local variable it_start is now
2901 EMACS_INT.
2902
2903 * regex.c (re_match, re_match_2, re_match_2_internal)
2904 (bcmp_translate, regcomp, regexec, print_double_string)
2905 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2906 (re_compile_pattern, re_exec): Declare arguments and local
2907 variables `size_t' and `ssize_t' and return values `regoff_t', as
2908 appropriate.
2909 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2910 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2911 <compile_stack_type>: `size' and `avail' are now `size_t'.
2912
2913 * regex.h <regoff_t>: Use ssize_t, not int.
2914 (re_search, re_search_2, re_match, re_match_2): Arguments that
2915 specify buffer/string position and length are now ssize_t and
2916 size_t. Return type is regoff_t.
2917
2918 2011-04-16 Ben Key <bkey76@gmail.com>
2919
2920 * nsfont.m: Fixed bugs in ns_get_family and
2921 ns_descriptor_to_entity that were caused by using free to
2922 deallocate memory blocks that were allocated by xmalloc (via
2923 xstrdup). This caused Emacs to crash when compiled with
2924 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2925 --enable-checking=xmallocoverrun). xfree is now used to
2926 deallocate these memory blocks.
2927
2928 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
2929
2930 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2931
2932 emacs_write: Accept and return EMACS_INT for sizes.
2933 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2934 et seq.
2935 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2936 Accept and return EMACS_INT.
2937 (emacs_gnutls_write): Return the number of bytes written on
2938 partial writes.
2939 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
2940 (emacs_read, emacs_write): Remove check for negative size, as the
2941 Emacs source code has been audited now.
2942 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2943 (emacs_read, emacs_write): Use it.
2944 * process.c (send_process): Adjust to the new signatures of
2945 emacs_write and emacs_gnutls_write. Do not attempt to store
2946 a byte offset into an 'int'; it might overflow.
2947 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
2948
2949 * sound.c: Don't assume sizes fit in 'int'.
2950 (struct sound_device.period_size, alsa_period_size):
2951 Return EMACS_INT, not int.
2952 (struct sound_device.write, vox_write, alsa_write):
2953 Accept EMACS_INT, not int.
2954 (wav_play, au_play): Use EMACS_INT to store sizes and to
2955 record read return values.
2956
2957 2011-04-15 Ben Key <bkey76@gmail.com>
2958
2959 * keyboard.c (Qundefined): Don't declare static since it is used
2960 in nsfns.m.
2961 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2962 static since they are used in nsfont.m.
2963
2964 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2965
2966 * process.c (Qprocessp): Don't declare static.
2967 * lisp.h (Qprocessp): Declare again.
2968
2969 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
2970
2971 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2972
2973 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2974
2975 Improve C-level modularity by making more things 'static'.
2976
2977 Don't publish debugger-only interfaces to other modules.
2978 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2979 (verify_bytepos, count_markers): Move decls to the only modules
2980 that need them.
2981 * region-cache.h (pp_cache): Likewise.
2982 * window.h (check_all_windows): Likewise.
2983 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2984
2985 * sysdep.c (croak): Now static, if
2986 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2987 * syssignal.h (croak): Declare only if not static.
2988
2989 * alloc.c (refill_memory_reserve): Now static if
2990 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2991 * lisp.h (refill_memory_reserve): Declare only if not static.
2992
2993 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2994 Define only if USE_LUCID.
2995
2996 * xrdb.c (x_customization_string, x_rm_string): Now static.
2997
2998 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2999 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3000
3001 * xdisp.c (draw_row_with_mouse_face): Now static.
3002 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3003
3004 * window.h (check_all_windows): Mark externally visible.
3005
3006 * window.c (window_deletion_count): Now static.
3007
3008 * undo.c: Make symbols static if they're not exported.
3009 (last_undo_buffer, last_boundary_position, pending_boundary):
3010 Now static.
3011
3012 * textprop.c (interval_insert_behind_hooks): Now static.
3013 (interval_insert_in_front_hooks): Likewise.
3014
3015 * term.c: Make symbols static if they're not exported.
3016 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3017 (max_frame_lines, tty_set_terminal_modes):
3018 (tty_reset_terminal_modes, tty_turn_off_highlight):
3019 (get_tty_terminal): Now static.
3020 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3021 * termhooks.h (term_mouse_moveto): Do not declare if
3022 HAVE_WINDOW_SYSTEM.
3023 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3024 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3025
3026 * sysdep.c: Make symbols static if they're not exported.
3027 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3028 Now static.
3029 (sigprocmask_set, full_mask): Remove; unused.
3030 (wait_debugging): Mark as visible.
3031 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3032 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3033
3034 * syntax.c (syntax_temp): Define only if !__GNUC__.
3035
3036 * sound.c (current_sound_device, current_sound): Now static.
3037
3038 * search.c (searchbufs, searchbuf_head): Now static.
3039
3040 * scroll.c (scroll_cost): Remove; unused.
3041 * dispextern.h (scroll_cost): Remove decl.
3042
3043 * region-cache.h (pp_cache): Mark as externally visible.
3044
3045 * process.c: Make symbols static if they're not exported.
3046 (process_tick, update_tick, create_process, chan_process):
3047 (Vprocess_alist, proc_buffered_char, datagram_access):
3048 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3049 (deactivate_process): Mark defn as static, as well as decl.
3050 * lisp.h (create_process): Remove decl.
3051 * process.h (chan_process, Vprocess_alist): Remove decls.
3052
3053 * print.c: Make symbols static if they're not exported.
3054 (print_depth, new_backquote_output, being_printed, print_buffer):
3055 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3056 (print_interval, print_number_index, initial_stderr_stream):
3057 Now static.
3058 * lisp.h (Fprinc): Remove decl.
3059 (debug_output_compilation_hack): Mark as externally visible.
3060
3061 * sysdep.c (croak): Move decl from here to syssignal.h.
3062 * syssignal.h (croak): Put it here, so the API can be checked when
3063 'croak' is called from dissociate_if_controlling_tty.
3064
3065 * minibuf.c: Make symbols static if they're not exported.
3066 (minibuf_save_list, choose_minibuf_frame): Now static.
3067 * lisp.h (choose_minibuf_frame): Remove decl.
3068
3069 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3070
3071 * lread.c: Make symbols static if they're not exported.
3072 (read_objects, initial_obarray, oblookup_last_bucket_number):
3073 Now static.
3074 (make_symbol): Remove; unused.
3075 * lisp.h (initial_obarray, make_symbol): Remove decls.
3076
3077 * keyboard.c: Make symbols static if they're not exported.
3078 (single_kboard, recent_keys_index, total_keys, recent_keys):
3079 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3080 (this_single_command_key_start, echoing, last_auto_save):
3081 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3082 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3083 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3084 (Vlispy_mouse_stem, double_click_count):
3085 Now static.
3086 (force_auto_save_soon): Define only if SIGDANGER.
3087 (ignore_mouse_drag_p): Now static if
3088 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3089 (print_help): Remove; unused.
3090 (stop_character, last_timer_event): Mark as externally visible.
3091 * keyboard.h (ignore_mouse_drag_p): Declare only if
3092 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3093 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3094 * lisp.h (echoing): Remove decl.
3095 (force_auto_save_soon): Declare only if SIGDANGER.
3096 * xdisp.c (redisplay_window): Simplify code, to make it more
3097 obvious that ignore_mouse_drag_p is not accessed if !defined
3098 USE_GTK && !defined HAVE_NS.
3099
3100 * intervals.c: Make symbols static if they're not exported.
3101 (merge_properties_sticky, merge_interval_right, delete_interval):
3102 Now static.
3103 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3104
3105 * insdel.c: Make symbols static if they're not exported.
3106 However, leave prepare_to_modify_buffer alone. It's never
3107 called from outside this function, but that appears to be a bug.
3108 (combine_after_change_list, combine_after_change_buffer):
3109 (adjust_after_replace, signal_before_change): Now static.
3110 (adjust_after_replace_noundo): Remove; unused.
3111 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
3112 (signal_before_change): Remove decls.
3113
3114 * indent.c (val_compute_motion, val_vmotion): Now static.
3115
3116 * image.c: Make symbols static if they're not exported.
3117 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3118 if USE_GTK.
3119 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3120 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3121
3122 * fringe.c (standard_bitmaps): Now static.
3123 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3124
3125 * frame.c: Make symbols static if they're not exported.
3126 (x_report_frame_params, make_terminal_frame): Now static.
3127 (get_frame_param): Now static, unless HAVE_NS.
3128 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3129 (x_get_resource_string): Remove; not used.
3130 * frame.h (make_terminal_frame, x_report_frame_params):
3131 (x_get_resource_string); Remove decls.
3132 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3133 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3134
3135 * font.c, fontset.c: Make symbols static if they're not exported.
3136 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3137 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3138 * font.c (font_close_object): Now static.
3139 * font.h (font_close_object): Remove.
3140 * fontset.c (FONTSET_OBJLIST): Remove.
3141 (free_realized_fontset) #if-0 the body, which does nothing.
3142 (face_suitable_for_char_p): #if-0, as it's never called.
3143 * fontset.h (face_suitable_for_char_p): Remove decl.
3144 * xfaces.c (face_at_string_position):
3145 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
3146 since 0 is always ASCII.
3147
3148 * fns.c (weak_hash_tables): Now static.
3149
3150 * fileio.c: Make symbols static if they're not exported.
3151 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3152 (Vwrite_region_annotation_buffers): Now static.
3153
3154 * eval.c: Make symbols static if they're not exported.
3155 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3156 * lisp.h (backtrace_list): Remove decl.
3157
3158 * emacs.c: Make symbols static if they're not exported.
3159 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3160 (fatal_error_code, fatal_error_signal_hook, standard_args):
3161 Now static.
3162 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3163 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3164 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3165 * lisp.h (fatal_error_signal_hook): Remove decl.
3166 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3167
3168 * editfns.c: Move a (normally-unused) function to its only use.
3169 * editfns.c, lisp.h (get_operating_system_release): Remove.
3170 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3171 worth the hassle of breaking this out.
3172
3173 * xterm.c: Make symbols static if they're not exported.
3174 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3175 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3176 (x_destroy_window, x_delete_display):
3177 Now static.
3178 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3179 (x_mouse_leave): Remove; unused.
3180 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3181 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3182 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3183 Remove decls.
3184 (x_mouse_leave): Declare only if WINDOWSNT.
3185 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3186 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3187 USE_X_TOOLKIT.
3188
3189 * ftxfont.c: Make symbols static if they're not exported.
3190 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3191 HAVE_FREETYPE.
3192 * font.h (ftxfont_driver): Likewise.
3193
3194 * xfns.c: Make symbols static if they're not exported.
3195 (x_last_font_name, x_display_info_for_name):
3196 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3197 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3198 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3199 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3200 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3201 (last_show_tip_args): Now static.
3202 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3203 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3204 (x_screen_planes): Remove; unused.
3205 * dispextern.h (x_screen_planes): Remove decl.
3206
3207 * dispnew.c: Make symbols static if they're not exported.
3208 * dispextern.h (redraw_garbaged_frames, scrolling):
3209 (increment_row_positions): Remove.
3210 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3211 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3212 Now static.
3213 (redraw_garbaged_frames): Remove; unused.
3214
3215 * xfaces.c: Make symbols static if they're not exported.
3216 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3217 Remove decls.
3218 * xterm.h (defined_color): Remove decls.
3219 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3220 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3221 (menu_face_changed_default, defined_color, free_realized_face):
3222 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3223 (ascii_face_of_lisp_face): Remove; unused.
3224
3225 * xdisp.c: Make symbols static if they're not exported.
3226 * dispextern.h (scratch_glyph_row, window_box_edges):
3227 (glyph_to_pixel_coords, set_cursor_from_row):
3228 (get_next_display_element, set_iterator_to_next):
3229 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3230 (show_mouse_face): Remove decls
3231 * frame.h (message_buf_print): Likewise.
3232 * lisp.h (pop_message, set_message, check_point_in_composition):
3233 Likewise.
3234 * xterm.h (set_vertical_scroll_bar): Likewise.
3235 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3236 (message_buf_print, scratch_glyph_row, displayed_buffer):
3237 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3238 (get_next_display_element, show_mouse_face, window_box_edges):
3239 (frame_to_window_pixel_xy, check_point_in_composition):
3240 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3241 (glyph_to_pixel_coords): Remove; unused.
3242
3243 * dired.c (file_name_completion): Now static.
3244
3245 * dbusbind.c (xd_in_read_queued_messages): Now static.
3246
3247 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3248 * data.c (circular_list_error): Remove.
3249
3250 * commands.h (last_point_position, last_point_position_buffer):
3251 (last_point_position_window): Remove decls.
3252 * keyboard.c: Make these variables static.
3253
3254 * coding.h (coding, code_convert_region, encode_coding_gap):
3255 Remove decls.
3256 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3257 (iso_code_class, detect_coding, code_convert_region): Now static.
3258 (encode_coding_gap): Remove; unused.
3259
3260 * chartab.c (chartab_chars, chartab_bits): Now static.
3261
3262 * charset.h (charset_iso_8859_1): Remove decl.
3263 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3264 Now static.
3265
3266 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3267 * ccl.c (Vccl_program_table): Now static.
3268 (check_ccl_update): Remove; unused.
3269
3270 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3271 * category.h: ... from here.
3272 * category.c (check_category_table, set_category_set): Now static.
3273
3274 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3275 * lisp.h: Remove these decls.
3276
3277 * buffer.c (buffer_count): Remove unused var.
3278
3279 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3280 so that it's not optimized away.
3281 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3282 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3283 exported only to the debugger.
3284
3285 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
3286 * atimer.h (run_all_atimers): Remove; not exported.
3287
3288 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3289 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3290 was inaccessible from Lisp.
3291 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3292 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3293
3294 alloc.c: Import and export fewer symbols, and remove unused items.
3295 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3296 is defined.
3297 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3298 it's not optimized away by whole-program optimization.
3299 (message_enable_multibyte, free_misc): Remove.
3300 (catchlist, handlerlist, mark_backtrace):
3301 Declare only if BYTE_MARK_STACK.
3302 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3303 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3304 (message_enable_multibyte): Remove decl.
3305 (free_misc, interval_free_list, float_block, float_block_index):
3306 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3307 (cons_free_list, last_marked_index):
3308 Now static.
3309 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3310 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3311 (mark_backtrace): Define only if BYTE_MARK_STACK.
3312 * xdisp.c (message_enable_multibyte): Now static.
3313
3314 Declare Lisp_Object Q* variables to be 'static' if not exported.
3315 This makes it easier for human readers (and static analyzers)
3316 to see whether these variables are used from other modules.
3317 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3318 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3319 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3320 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3321 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3322 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3323 * xmenu.c, xselect.c:
3324 Declare Q* vars static if they are not used in other modules.
3325 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3326 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3327 Remove decls of unexported vars.
3328 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3329
3330 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3331
3332 Make Emacs functions such as Fatom 'static' by default.
3333 This makes it easier for human readers (and static analyzers)
3334 to see whether these functions can be called from other modules.
3335 DEFUN now defines a static function. To make the function external
3336 so that it can be used in other C modules, use the new macro DEFUE.
3337 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3338 (Finit_image_library):
3339 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3340 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3341 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3342 Remove decls, since these functions are now static.
3343 (Funintern, Fget_internal_run_time): New decls, since these functions
3344 were already external.
3345
3346 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3347 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3348 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3349 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3350 * keyboard.c, keymap.c, lread.c:
3351 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3352 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3353 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3354 Mark functions with DEFUE instead of DEFUN,
3355 if they are used in other modules.
3356 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3357 decls for now-static functions.
3358 * buffer.h (Fdelete_overlay): Remove decl.
3359 * callproc.c (Fgetenv_internal): Mark as internal.
3360 * composite.c (Fremove_list_of_text_properties): Remove decl.
3361 (Fcomposition_get_gstring): New forward static decl.
3362 * composite.h (Fcomposite_get_gstring): Remove decl.
3363 * dired.c (Ffile_attributes): New forward static decl.
3364 * doc.c (Fdocumntation_property): New forward static decl.
3365 * eval.c (Ffetch_bytecode): New forward static decl.
3366 (Funintern): Remove extern decl; now in .h file where it belongs.
3367 * fileio.c (Fmake_symbolic_link): New forward static decl.
3368 * image.c (Finit_image_library): New forward static decl.
3369 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3370 * intervals.h (Fprevious_property_change):
3371 (Fremove_list_of_text_properties): Remove decls.
3372 * keyboard.c (Fthis_command_keys): Remove decl.
3373 (Fcommand_execute): New forward static decl.
3374 * keymap.c (Flookup_key): New forward static decl.
3375 (Fcopy_keymap): Now static.
3376 * keymap.h (Flookup_key): Remove decl.
3377 * process.c (Fget_process): New forward static decl.
3378 (Fprocess_datagram_address): Mark as internal.
3379 * syntax.c (Fsyntax_table_p): New forward static decl.
3380 (skip_chars): Remove duplicate decl.
3381 * textprop.c (Fprevious_property_change): New forward static decl.
3382 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3383 Now internal.
3384 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3385 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3386
3387 * editfns.c (Fformat): Remove unreachable code.
3388
3389 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3390
3391 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3392 change. (Bug#8496)
3393
3394 2011-04-13 Eli Zaretskii <eliz@gnu.org>
3395
3396 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3397 when at ZV. (Bug#8487)
3398
3399 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3400
3401 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3402 (Bug#8437)
3403 * keyboard.c (parse_tool_bar_item): Likewise.
3404 * sound.c (sound_cleanup, alsa_close): Likewise.
3405 * termcap.c (tgetent): Likewise.
3406 * xfns.c (x_default_font_parameter): Likewise.
3407 * xsettings.c (read_and_apply_settings): Likewise.
3408
3409 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3410 (overrun_check_free): Protoize.
3411
3412 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3413
3414 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3415 since callers should never pass a negative size.
3416 Change the signature to match that of plain 'read' and 'write'; see
3417 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3418 * lisp.h: Update prototypes of emacs_write and emacs_read.
3419
3420 2011-04-11 Eli Zaretskii <eliz@gnu.org>
3421
3422 * xdisp.c (redisplay_window): Don't try to determine the character
3423 position of the scroll margin if the window start point w->startp
3424 is outside the buffer's accessible region. (Bug#8468)
3425
3426 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3427
3428 Fix write-region and its subroutines for buffers > 2GB.
3429 * fileio.c (a_write, e_write): Modify declaration of arguments and
3430 local variables to support buffers larger than 2GB.
3431 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3432
3433 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3434 argument, local variables, and return value.
3435
3436 * lisp.h: Update prototypes of emacs_write and emacs_read.
3437
3438 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3439
3440 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3441
3442 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3443
3444 Fix more problems found by GCC 4.6.0's static checks.
3445
3446 * xdisp.c (vmessage): Use a better test for character truncation.
3447
3448 * charset.c (load_charset_map): <, not <=, for optimization,
3449 and to avoid potential problems with integer overflow.
3450 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3451 * casetab.c (set_identity, shuffle): Likewise.
3452 * editfns.c (Fformat): Likewise.
3453 * syntax.c (skip_chars): Likewise.
3454
3455 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3456 This also lets GCC 4.6.0 generate slightly better loop code.
3457
3458 * callint.c (Fcall_interactively): <, not <=, for optimization.
3459 (Fcall_interactively): Count the number of arguments produced,
3460 not the number of arguments given. This is simpler and lets GCC
3461 4.6.0 generate slightly better code.
3462
3463 * ftfont.c: Distingish more carefully between FcChar8 and char.
3464 The previous code passed unsigned char * to a functions like
3465 strlen and xstrcasecmp that expect char *, which does not
3466 conform to the C standard.
3467 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3468 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3469 char * when the C standard requires it.
3470
3471 * keyboard.c (read_char): Remove unused var.
3472
3473 * eval.c: Port to Windows vsnprintf (Bug#8435).
3474 Include <limits.h>.
3475 (SIZE_MAX): Define if the headers do not.
3476 (verror): Do not give up if vsnprintf returns a negative count.
3477 Instead, grow the buffer. This ports to Windows vsnprintf, which
3478 does not conform to C99. Problem reported by Eli Zaretskii.
3479 Also, simplify the allocation scheme, by avoiding the need for
3480 calling realloc, and removing the ALLOCATED variable.
3481
3482 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3483
3484 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3485 But keep the doprint source code for now, as we might revamp it
3486 and use it again (Bug#8435).
3487 * lisp.h (doprnt): Remove.
3488 * Makefile.in (base_obj): Remove doprnt.o.
3489 * deps.mk (doprnt.o): Remove.
3490
3491 error: Print 32- and 64-bit integers portably (Bug#8435).
3492 Without this change, on typical 64-bit hosts error ("...%d...", N)
3493 was used to print both 32- and 64-bit integers N, which relied on
3494 undefined behavior.
3495 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3496 New macro.
3497 * lisp.h (error, verror): Mark as printf-like functions.
3498 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3499 Report overflow in size calculations when allocating printf buffer.
3500 Do not truncate output string at its first null byte.
3501 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3502 Truncate the output at a character boundary, since vsnprintf does not
3503 do that.
3504 * charset.c (check_iso_charset_parameter): Convert internal
3505 character to string before calling 'error', since %c now has the
3506 printf meaning.
3507 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3508 overflow when computing char to be passed to 'error'. Do not
3509 pass Lisp_Object to 'error'; pass the integer instead.
3510 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3511 formatted with plain %d.
3512
3513 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3514
3515 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3516
3517 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3518
3519 * xterm.c (x_catch_errors): Remove duplicate declaration.
3520
3521 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3522
3523 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3524
3525 2011-04-10 Jim Meyering <meyering@redhat.com>
3526
3527 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3528 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3529 return ssize_t not "int", and use size_t as the buffer length.
3530 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3531 * gnutls.h: Update declarations.
3532 * process.c (read_process_output): Use ssize_t, to match.
3533 (send_process): Likewise.
3534
3535 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3536
3537 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3538
3539 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3540
3541 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3542 Use unsigned char, to match FcChar8 type definition.
3543
3544 * xterm.c (handle_one_xevent):
3545 * xmenu.c (create_and_show_popup_menu):
3546 * xselect.c (x_decline_selection_request)
3547 (x_reply_selection_request): Avoid type-punned deref of X events.
3548
3549 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3550
3551 Fix some uses of `int' instead of EMACS_INT.
3552 * search.c (string_match_1, fast_string_match)
3553 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3554 (scan_buffer, find_next_newline_no_quit)
3555 (find_before_next_newline, search_command, Freplace_match)
3556 (Fmatch_data): Make some `int' variables be EMACS_INT.
3557
3558 * xdisp.c (display_count_lines): 3rd argument and return value now
3559 EMACS_INT. All callers changed.
3560 (pint2hrstr): Last argument is now EMACS_INT.
3561
3562 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3563 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3564 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3565 (decode_coding_utf_16, decode_coding_emacs_mule)
3566 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3567 (decode_coding_ccl, decode_coding_charset)
3568 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3569 (decode_coding_iso_2022, decode_coding_emacs_mule)
3570 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3571 <char_offset, last_offset>: Declare EMACS_INT.
3572 (encode_coding_utf_8, encode_coding_utf_16)
3573 (encode_coding_emacs_mule, encode_invocation_designation)
3574 (encode_designation_at_bol, encode_coding_iso_2022)
3575 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3576 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3577 Declare EMACS_INT.
3578 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3579 (encode_invocation_designation): Last argument P_NCHARS is now
3580 EMACS_INT.
3581 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3582 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3583
3584 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3585 All users changed.
3586
3587 * ccl.c (Fccl_execute_on_string): Declare some variables
3588 EMACS_INT.
3589
3590 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3591
3592 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3593
3594 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3595
3596 * process.c (Fformat_network_address): Doc fix.
3597
3598 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3599
3600 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3601
3602 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3603
3604 * keyboard.c (read_char): Call Lisp function help-form-show,
3605 instead of using internal_with_output_to_temp_buffer.
3606 (Qhelp_form_show): New var.
3607 (syms_of_keyboard): Use DEFSYM macro.
3608
3609 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3610
3611 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3612
3613 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3614
3615 * process.c (Flist_processes): Remove to Lisp.
3616 (list_processes_1): Delete.
3617
3618 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3619
3620 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3621
3622 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3623
3624 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3625
3626 Fix more problems found by GCC 4.6.0's static checks.
3627
3628 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3629
3630 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3631
3632 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3633
3634 * xdisp.c (vmessage): Mark as a printf-like function.
3635
3636 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3637
3638 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3639
3640 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3641 printf-like functions.
3642 (tiff_load): Add casts to remove these marks before passing them
3643 to system-supplied API.
3644
3645 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3646
3647 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3648 This avoids several warnings with gcc -Wstrict-overflow.
3649 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3650 directly, rather than having caller test rule sign. This avoids
3651 some unnecessary tests.
3652 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3653 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3654 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3655
3656 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3657 (xfont_open): Avoid unnecessary tests.
3658
3659 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3660
3661 * composite.h, composite.c (composition_gstring_put_cache):
3662 Use EMACS_INT, not int, for length.
3663
3664 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3665 breaking out part of COMPOSITION_DECODE_RULE.
3666 (COMPOSITION_DECODE_RULE): Use it.
3667 * composite.c (get_composition_id): Remove unused local vars,
3668 by using the new macro.
3669
3670 * textprop.c (set_text_properties_1): Change while to do-while,
3671 since the condition is always true at first.
3672
3673 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3674 (interval_deletion_adjustment): Return unsigned value.
3675 All uses changed.
3676
3677 * process.c (list_processes_1, create_pty, read_process_output):
3678 (exec_sentinel): Remove vars that were set but not used.
3679 (create_pty): Remove unnecessary "volatile"s.
3680 (Fnetwork_interface_info): Avoid possibility of int overflow.
3681 (read_process_output): Do adaptive read buffering even if carryover.
3682 (read_process_output): Simplify nbytes computation if buffered.
3683
3684 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3685
3686 * syntax.c (scan_words): Remove var that was set but not used.
3687 (update_syntax_table): Use unsigned instead of int.
3688
3689 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3690 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3691 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3692
3693 * print.c (print_error_message): Avoid int overflow.
3694
3695 * font.c (font_list_entities): Redo for clarity,
3696 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3697
3698 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3699 (font_score): Avoid potential overflow in diff calculation.
3700
3701 * fns.c (substring_both): Remove var that is set but not used.
3702 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3703
3704 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3705
3706 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3707 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3708 can always succeed if overflow has undefined behavior.
3709
3710 * search.c (boyer_moore, wordify): Remove vars set but not used.
3711 (wordify): Omit three unnecessary tests.
3712
3713 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3714 All callers changed. This avoids the need for an unused var.
3715
3716 * casefiddle.c (casify_region): Remove var that is set but not used.
3717
3718 * dired.c (file_name_completion): Remove var that is set but not used.
3719
3720 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3721
3722 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3723 (Finsert_file_contents): Remove unnecessary code checking fd.
3724
3725 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3726 Check for integer overflow on size calculations.
3727
3728 * buffer.c (Fprevious_overlay_change): Remove var that is set
3729 but not used.
3730
3731 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3732 Remove vars that are set but not used.
3733 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3734 (timer_check_2): Mark vars as initialized.
3735
3736 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3737
3738 * image.c (lookup_image): Remove var that is set but not used.
3739 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3740
3741 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3742 that are set but not used.
3743
3744 * xfns.c (make_invisible_cursor): Don't return garbage
3745 if XCreateBitmapFromData fails (Bug#8410).
3746
3747 * xselect.c (x_get_local_selection, x_handle_property_notify):
3748 Remove vars that are set but not used.
3749
3750 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3751 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3752
3753 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3754 Remove var that is set but not used.
3755 (scroll_bar_windows_size): Now size_t, not int.
3756 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3757 Check for overflow.
3758
3759 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3760 (map_tty_color) [!defined MSDOS]: Likewise.
3761
3762 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3763
3764 * coding.c: Remove vars that are set but not used.
3765 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3766 All callers changed.
3767 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3768 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3769 (decode_coding_charset): Remove vars that are set but not used.
3770
3771 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3772 that is set but not used.
3773
3774 * print.c (print_object): Remove var that is set but not used.
3775
3776 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3777 The gnulib version avoids calling malloc in the usual case,
3778 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3779 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3780 * filelock.c (current_lock_owner): Likewise.
3781 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3782 * sysdep.c: Include allocator.h, careadlinkat.h.
3783 (emacs_no_realloc_allocator): New static constant.
3784 (emacs_readlink): New function.
3785 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3786 ../lib/careadlinkat.h.
3787
3788 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3789
3790 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3791 first non-nil return value).
3792
3793 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3794
3795 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3796 if not defined (Bug#8403).
3797
3798 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3799
3800 * xdisp.c (display_count_lines): Remove parameter `start',
3801 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3802 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3803 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3804 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3805 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3806 and thereabouts. All callers changed.
3807 (get_per_char_metric): Remove parameter `f', unused since
3808 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3809
3810 2011-04-02 Jim Meyering <meyering@redhat.com>
3811
3812 do not dereference NULL upon failed strdup
3813 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3814 (ns_get_family): Likewise.
3815
3816 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3817
3818 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3819
3820 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3821
3822 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3823 later (Bug#8403).
3824
3825 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3826
3827 Add lexical binding.
3828
3829 * window.c (Ftemp_output_buffer_show): New fun.
3830 (Fsave_window_excursion):
3831 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3832
3833 * lread.c (lisp_file_lexically_bound_p): New function.
3834 (Fload): Bind Qlexical_binding.
3835 (readevalloop): Remove `evalfun' arg.
3836 Bind Qinternal_interpreter_environment.
3837 (Feval_buffer): Bind Qlexical_binding.
3838 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3839 Mark as dynamic.
3840 (syms_of_lread): Declare `lexical-binding'.
3841
3842 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3843
3844 * keyboard.c (eval_dyn): New fun.
3845 (menu_item_eval_property): Use it.
3846
3847 * image.c (parse_image_spec): Use Ffunctionp.
3848
3849 * fns.c (concat, mapcar1): Accept byte-code-functions.
3850
3851 * eval.c (Fsetq): Handle lexical vars.
3852 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3853 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3854 (FletX, Flet): Obey lexical binding.
3855 (Fcommandp): Handle closures.
3856 (Feval): New `lexical' arg.
3857 (eval_sub): New function extracted from Feval. Use it almost
3858 everywhere where Feval was used. Look up vars in lexical env.
3859 Handle closures.
3860 (Ffunctionp): Move from subr.el.
3861 (Ffuncall): Handle closures.
3862 (apply_lambda): Remove `eval_flags'.
3863 (funcall_lambda): Handle closures and new byte-code-functions.
3864 (Fspecial_variable_p): New function.
3865 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3866 but without exporting it to Lisp.
3867
3868 * doc.c (Fdocumentation, store_function_docstring):
3869 * data.c (Finteractive_form): Handle closures.
3870
3871 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3872 interactive spec.
3873
3874 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3875 New byte-codes.
3876 (exec_byte_code): New function extracted from Fbyte_code to handle new
3877 calling convention for byte-code-functions. Add new byte-codes.
3878
3879 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3880
3881 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3882
3883 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3884
3885 * xdisp.c (redisplay_internal): Fix prototype.
3886
3887 2011-03-31 Eli Zaretskii <eliz@gnu.org>
3888
3889 * xdisp.c (SCROLL_LIMIT): New macro.
3890 (try_scrolling): Use it when setting scroll_limit.
3891 Limit scrolling to 100 screen lines.
3892 (redisplay_window): Even when falling back on "recentering",
3893 position point in the window according to scroll-conservatively,
3894 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3895
3896 (try_scrolling): When point is above the window, allow searching
3897 as far as scroll_max, or one screenful, to compute vertical
3898 distance from PT to the scroll margin position. This prevents
3899 try_scrolling from unnecessarily failing when
3900 scroll-conservatively is set to a value slightly larger than the
3901 window height. Clean up the case of PT below the margin at bottom
3902 of window: scroll_max can no longer be INT_MAX. When aggressive
3903 scrolling is in use, don't let point enter the opposite scroll
3904 margin as result of the scroll.
3905 (syms_of_xdisp) <scroll-conservatively>: Document the
3906 threshold of 100 lines for never-recentering scrolling.
3907
3908 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3909
3910 * dispextern.h (move_it_by_lines):
3911 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3912 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3913 (message_log_check_duplicate): Remove parameters `prev_bol' and
3914 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3915 (redisplay_internal): Remove parameter `preserve_echo_area',
3916 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3917
3918 * indent.c (Fvertical_motion):
3919 * window.c (window_scroll_pixel_based, Frecenter):
3920 Don't pass `need_y_p' to `move_it_by_lines'.
3921
3922 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3923
3924 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3925 steal a few bits to be more compact.
3926 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3927 Remove unneeded casts.
3928
3929 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3930
3931 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3932
3933 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3934 binding" message (bug#7967).
3935
3936 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3937
3938 Fix more problems found by GCC 4.6.0's static checks.
3939
3940 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3941 Remove unused local var.
3942
3943 * editfns.c (Fmessage_box): Remove unused local var.
3944
3945 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3946 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3947 Omit unused local vars.
3948 * window.c (shrink_windows): Omit unused local var.
3949 * menu.c (digest_single_submenu): Omit unused local var.
3950 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3951 Omit unused local var.
3952
3953 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3954 Don't assume string length fits in int.
3955 (keyremap_step, read_key_sequence): Use size_t for sizes.
3956 (read_key_sequence): Don't check last_real_key_start redundantly.
3957
3958 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3959 instead of alloca (Bug#8344).
3960
3961 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3962 (Fbacktrace_frame): Don't assume nframes fits in int.
3963
3964 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3965
3966 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3967 concerns.
3968
3969 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3970
3971 * cm.c (calccost): Turn while-do into do-while, for clarity.
3972
3973 * keyboard.c (syms_of_keyboard): Use the same style as later
3974 in this function when indexing through an array. This also
3975 works around GCC bug 48267.
3976
3977 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3978
3979 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3980
3981 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3982 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3983
3984 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3985 This avoids undefined behavior on integer overflow, and is a bit
3986 more convenient anyway since it is compared to a size_t variable.
3987
3988 Variadic C functions now count arguments with size_t, not int.
3989 This avoids an unnecessary limitation on 64-bit machines, which
3990 caused (substring ...) to crash on large vectors (Bug#8344).
3991 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3992 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3993 All variadic functions and their callers changed accordingly.
3994 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3995 * data.c (arith_driver, float_arith_driver): Likewise.
3996 * editfns.c (general_insert_function): Likewise.
3997 * eval.c (struct backtrace.nargs, interactive_p)
3998 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3999 (funcall_lambda, mark_backtrace): Likewise.
4000 * fns.c (concat): Likewise.
4001 * frame.c (x_set_frame_parameters): Likewise.
4002 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4003 0 if not found, not -1. All callers changed.
4004
4005 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4006 (stack_copy_size): Now size_t, not int.
4007 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4008
4009 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4010
4011 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4012 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4013 All callers changed.
4014
4015 * lisp.h (multibyte_char_to_unibyte):
4016 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4017 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4018 * character.h (CHAR_TO_BYTE8):
4019 * cmds.c (internal_self_insert):
4020 * editfns.c (general_insert_function):
4021 * keymap.c (push_key_description):
4022 * search.c (Freplace_match):
4023 * xdisp.c (message_dolog, set_message_1): All callers changed.
4024
4025 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4026
4027 * keyboard.c (safe_run_hook_funcall): New function.
4028 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4029 don't set the hook to nil, but remove the offending function instead.
4030 (Qcommand_hook_internal): Remove, unused.
4031 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4032 Vcommand_hook_internal.
4033
4034 * eval.c (enum run_hooks_condition): Remove.
4035 (funcall_nil, funcall_not): New functions.
4036 (run_hook_with_args): Call each function through a `funcall' argument.
4037 Remove `cond' argument, now redundant.
4038 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4039 (Frun_hook_with_args_until_failure): Adjust accordingly.
4040 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4041
4042 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4043
4044 * dispextern.h (string_buffer_position): Remove declaration.
4045
4046 * print.c (strout): Remove parameter `multibyte', unused since
4047 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4048
4049 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4050 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4051 All callers changed.
4052
4053 * w32.c (_wsa_errlist): Use braces for struct initializers.
4054
4055 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4056 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4057 All callers changed.
4058 (string_buffer_position): Likewise. Also, make static (it's never
4059 used outside xdisp.c).
4060 (cursor_row_p): Remove parameter `w', unused since
4061 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4062 (decode_mode_spec): Remove parameter `precision', introduced during
4063 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4064 All callers changed.
4065
4066 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4067
4068 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4069
4070 2011-03-27 Anders Lindgren <andlind@gmail.com>
4071
4072 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4073 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4074 (ns_update_auto_hide_menu_bar): New functions.
4075 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4076 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4077 ns_constrain_all_frames.
4078 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4079 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4080
4081 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4082
4083 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4084
4085 2011-03-27 Glenn Morris <rgm@gnu.org>
4086
4087 * syssignal.h: Replace RETSIGTYPE with void.
4088 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4089 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4090 Replace SIGTYPE with void everywhere.
4091 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4092 * s/template.h (SIGTYPE): Remove commented out definition.
4093
4094 2011-03-26 Eli Zaretskii <eliz@gnu.org>
4095
4096 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4097 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4098
4099 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
4100
4101 * w32.c (read_unc_volume): Use parameter `henum', instead of
4102 global variable `wget_enum_handle'.
4103
4104 * keymap.c (describe_vector): Remove parameters `indices' and
4105 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4106 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4107
4108 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4109
4110 * keyboard.c (timer_check): Remove parameter `do_it_now',
4111 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4112 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4113 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4114
4115 * keyboard.c (read_char):
4116 * w32menu.c (w32_menu_display_help):
4117 * xmenu.c (show_help_event, menu_help_callback):
4118 Adjust calls to `show_help_echo'.
4119
4120 * gtkutil.c (xg_maybe_add_timer):
4121 * keyboard.c (readable_events):
4122 * process.c (wait_reading_process_output):
4123 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4124
4125 * insdel.c (adjust_markers_gap_motion):
4126 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4127 (gap_left, gap_right): Don't call it.
4128
4129 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
4130
4131 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4132 incurred during fontification.
4133
4134 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4135
4136 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4137 (DEFVAR_PER_BUFFER): Don't pass it.
4138
4139 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4140 (scrolling_window): Don't pass it.
4141
4142 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4143
4144 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4145
4146 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4147 and `suffix'.
4148 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4149 of variables specific to SELinux and computation of `encoded_absname'.
4150
4151 * image.c (XPutPixel): Remove unused variable `height'.
4152
4153 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4154
4155 * unexw32.c (get_section_info): Remove unused variable `section'.
4156
4157 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4158 (system_process_attributes): Remove unused variable `sess'.
4159 (sys_read): Remove unused variable `err'.
4160
4161 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4162 (w32_wnd_proc): Remove unused variable `isdead'.
4163 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4164 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4165 (x_create_tip_frame): Remove unused variable `tem'.
4166
4167 * w32inevt.c (w32_console_read_socket):
4168 Remove unused variable `no_events'.
4169
4170 * w32term.c (x_draw_composite_glyph_string_foreground):
4171 Remove unused variable `width'.
4172
4173 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
4174
4175 * w32term.c (x_set_glyph_string_clipping):
4176 Don't pass uninitialized region to CombineRgn.
4177
4178 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
4179
4180 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4181 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4182 (Fx_close_connection): Remove unused variable `i'.
4183
4184 * w32font.c (w32font_draw): Return number of glyphs.
4185 (w32font_open_internal): Remove unused variable `i'.
4186 (w32font_driver): Add missing initializer.
4187
4188 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4189 (fill_in_menu): Remove unused variable `items_added'.
4190
4191 * w32term.c (last_mouse_press_frame): Remove static global variable.
4192 (w32_clip_to_row): Remove unused variable `f'.
4193 (x_delete_terminal): Remove unused variable `i'.
4194
4195 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4196 (NOTHING): Remove unused static global variable.
4197 (uniscribe_check_otf): Remove unused variable `table'.
4198 (uniscribe_font_driver): Add missing initializers.
4199
4200 2011-03-23 Julien Danjou <julien@danjou.info>
4201
4202 * term.c (Fsuspend_tty, Fresume_tty):
4203 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4204 * window.c (temp_output_buffer_show):
4205 * insdel.c (signal_before_change):
4206 * frame.c (Fhandle_switch_frame):
4207 * fileio.c (Fdo_auto_save):
4208 * emacs.c (Fkill_emacs):
4209 * editfns.c (save_excursion_restore):
4210 * cmds.c (internal_self_insert):
4211 * callint.c (Fcall_interactively):
4212 * buffer.c (Fkill_all_local_variables):
4213 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4214 Use Frun_hooks.
4215 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
4216 unconditionnaly since it does the check itself.
4217
4218 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
4219
4220 Fix more problems found by GCC 4.5.2's static checks.
4221
4222 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4223 the first time through the loop, since we know p0 < p1 then.
4224 This also avoids a gcc -Wstrict-overflow warning.
4225
4226 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4227 leading to a memory leak, possible in functions like
4228 load_charset_map_from_file that can allocate an unbounded number
4229 of objects (Bug#8318).
4230
4231 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4232 that could (at least in theory) be that large.
4233
4234 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4235 This is less likely to overflow, and avoids undefined behavior if
4236 overflow does occur. All callers changed. Use strtoul to scan
4237 for the unsigned long integer.
4238 (pint2hrstr): Simplify and tune code slightly.
4239 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
4240
4241 * scroll.c (do_scrolling): Work around GCC bug 48228.
4242 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4243
4244 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4245 This also avoids a warning with gcc -Wstrict-overflow.
4246 (validate_x_resource_name): Simplify count usage.
4247 This also avoids a warning with gcc -Wstrict-overflow.
4248
4249 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4250 fail (Bug#8306).
4251
4252 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
4253
4254 * process.c (Fmake_network_process): Use socklen_t, not int,
4255 where POSIX says socklen_t is required in portable programs.
4256 This fixes a porting bug on hosts like 64-bit HP-UX, where
4257 socklen_t is wider than int (Bug#8277).
4258 (Fmake_network_process, server_accept_connection):
4259 (wait_reading_process_output, read_process_output):
4260 Likewise.
4261
4262 * process.c: Rename or move locals to avoid shadowing.
4263 (list_processes_1, Fmake_network_process):
4264 (read_process_output_error_handler, exec_sentinel_error_handler):
4265 Rename or move locals.
4266 (Fmake_network_process): Define label "retry_connect" only if needed.
4267 (Fnetwork_interface_info): Fix pointer signedness.
4268 (process_send_signal): Add cast to avoid pointer signedness problem.
4269 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
4270 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
4271
4272 Make tparam.h and terminfo.c consistent.
4273 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4274 Include tparam.h instead, since it declares them.
4275 * cm.h (PC): Remove extern decl; tparam.h now does this.
4276 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4277 * terminfo.c: Include tparam.h, to check interfaces.
4278 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4279 (tparam): Adjust signature to match interface in tparam.h;
4280 this removes some undefined behavior. Check that outstring and len
4281 are zero, which they always are with Emacs.
4282 * tparam.h (PC, BC, UP): New extern decls.
4283
4284 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
4285 (xftfont_open): Rename locals to avoid shadowing.
4286
4287 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
4288 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4289 (OTF_TAG_SYM): Omit macro if not needed.
4290 (ftfont_list): Remove unused local.
4291 (get_adstyle_property, ftfont_pattern_entity):
4292 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4293 Rename locals to avoid shadowing.
4294
4295 * xfont.c (xfont_list_family): Mark var as initialized.
4296
4297 * xml.c (make_dom): Now static.
4298
4299 * composite.c (composition_compute_stop_pos): Rename local to
4300 avoid shadowing.
4301 (composition_reseat_it): Remove unused locals.
4302 (find_automatic_composition, composition_adjust_point): Likewise.
4303 (composition_update_it): Mark var as initialized.
4304 (find_automatic_composition): Mark vars as initialized,
4305 with a FIXME (Bug#8290).
4306
4307 character.h: Rename locals to avoid shadowing.
4308 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4309 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4310 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4311 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4312 to avoid shadowing.
4313
4314 * textprop.c (property_change_between_p): Remove; unused.
4315
4316 * intervals.c (interval_start_pos): Now static.
4317
4318 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4319
4320 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4321 Rename locals to avoid shadowing.
4322
4323 * sound.c (wav_play, au_play, Fplay_sound_internal):
4324 Fix pointer signedness.
4325 (alsa_choose_format): Remove unused local var.
4326 (wav_play): Initialize a variable to 0, to prevent undefined
4327 behavior (Bug#8278).
4328
4329 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4330
4331 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4332
4333 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4334 clobbering (Bug#8298).
4335 * sysdep.c (sys_subshell): Likewise.
4336 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
4337
4338 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4339 This should get cleaned up, so that child_setup has the
4340 same signature on all platforms.
4341
4342 * callproc.c (call_process_cleanup): Now static.
4343 (relocate_fd): Rename locals to avoid shadowing.
4344
4345 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
4346
4347 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4348 not to be necessary, and produces flickering.
4349
4350 2011-03-20 Glenn Morris <rgm@gnu.org>
4351
4352 * config.in: Remove file.
4353
4354 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
4355
4356 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4357 are now in src/globals.h.
4358 (syms_of_minibuf): Remove spurious & from previous change.
4359
4360 2011-03-20 Leo <sdl.web@gmail.com>
4361
4362 * minibuf.c (completing-read-function): New variable.
4363 (completing-read-default): Rename from completing-read.
4364 (completing-read): Call completing-read-function.
4365
4366 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4367
4368 * xfaces.c (Fx_load_color_file):
4369 Read color file from absolute filename (bug#8250).
4370
4371 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4372
4373 * makefile.w32-in: Update dependencies.
4374
4375 2011-03-17 Eli Zaretskii <eliz@gnu.org>
4376
4377 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4378
4379 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4380
4381 Fix more problems found by GCC 4.5.2's static checks.
4382
4383 * process.c (make_serial_process_unwind, send_process_trap):
4384 (sigchld_handler): Now static.
4385
4386 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4387 That way, the code declares only the vars that it needs.
4388 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4389 * s/cygwin.h (PTY_ITERATION): Likewise.
4390 * s/darwin.h (PTY_ITERATION): Likewise.
4391 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4392
4393 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4394 * process.c (allocate_pty): Don't declare stb unless it's needed.
4395
4396 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
4397 (CONSTANTLIM): Remove; unused.
4398 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4399 Define only if needed.
4400
4401 * unexelf.c (unexec): Name an expression,
4402 to avoid gcc -Wbad-function-cast warning.
4403 Use a different way to cause a compilation error if anyone uses
4404 n rather than nn, a way that does not involve shadowing.
4405 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
4406
4407 * deps.mk (unexalpha.o): Remove; unused.
4408
4409 New file unexec.h, the (simple) interface for unexec (Bug#8267).
4410 * unexec.h: New file.
4411 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4412 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4413 Depend on unexec.h.
4414 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4415 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4416 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4417 Change as necessary to match prototype in unexec.h.
4418
4419 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4420 shadowing.
4421 (back_comment, skip_chars): Mark vars as initialized.
4422
4423 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4424 Rename locals to avoid shadowing.
4425
4426 * lread.c (read1): Rewrite so as not to use empty "else".
4427 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4428
4429 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4430
4431 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4432 warning when compiling print.c.
4433
4434 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4435 instead of using an uninitialized var.
4436 (font_sort_entities): Mark var as initialized.
4437
4438 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4439
4440 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4441 pointers to constants.
4442 (font_parse_fcname): Remove unused vars.
4443 (font_delete_unmatched): Now static.
4444 (font_get_spec): Remove; unused.
4445 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4446 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4447 Rename or move locals to avoid shadowing.
4448
4449 * fns.c (require_nesting_list, require_unwind): Now static.
4450 (Ffillarray): Rename locals to avoid shadowing.
4451
4452 * floatfns.c (domain_error2): Define only if needed.
4453 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4454
4455 * alloc.c (mark_backtrace): Move decl from here ...
4456 * lisp.h: ... to here, so that it can be checked.
4457
4458 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4459 (Fdefvar): Rewrite so as not to use empty "else".
4460 (lisp_indirect_variable): Name an expression,
4461 to avoid gcc -Wbad-function-cast warning.
4462 (Fdefvar): Rename locals to avoid shadowing.
4463
4464 * callint.c (quotify_arg, quotify_args): Now static.
4465 (Fcall_interactively): Rename locals to avoid shadowing.
4466 Use const pointer when appropriate.
4467
4468 * lisp.h (get_system_name, get_operating_system_release):
4469 Move decls here, to check interfaces.
4470 * process.c (get_operating_system_release): Move decl to lisp.h.
4471 * xrdb.c (get_system_name): Likewise.
4472 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4473 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4474 some of which prompt warnings from gcc -Wbad-function-cast.
4475 (Fformat_time_string, Fencode_time, Finsert_char):
4476 (Ftranslate_region_internal, Fformat):
4477 Rename or remove local vars to avoid shadowing.
4478 (Ftranslate_region_internal): Mark var as initialized.
4479
4480 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4481 avoid shadowing.
4482
4483 * lisp.h (eassert): Check that the argument compiles, even if
4484 ENABLE_CHECKING is not defined.
4485
4486 * data.c (Findirect_variable): Name an expression, to avoid
4487 gcc -Wbad-function-cast warning.
4488 (default_value, arithcompare, arith_driver, arith_error): Now static.
4489 (store_symval_forwarding): Rename local to avoid shadowing.
4490 (Fmake_variable_buffer_local, Fmake_local_variable):
4491 Mark variables as initialized.
4492 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4493
4494 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4495 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4496 Rename locals to avoid shadowing.
4497 (mark_stack): Move local variables into the #ifdef region where
4498 they're used.
4499 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4500 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4501 needed otherwise.
4502 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4503 (GC_STRING_CHARS): Remove; not used.
4504 (Fmemory_limit): Cast sbrk's returned value to char *.
4505
4506 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4507 avoids undefined behavior in theory.
4508
4509 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4510
4511 Use functions, not macros, for up- and down-casing (Bug#8254).
4512 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4513 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4514 to use the following functions instead of these macros.
4515 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4516 EMACS_INT, since callers assume the returned value fits in int.
4517 (upcase1): Likewise, for UPCASE_TABLE.
4518 (uppercasep, lowercasep, upcase): New static inline functions.
4519 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4520 the race-condition problem in the old DOWNCASE.
4521
4522 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4523 Rename locals to avoid shadowing.
4524 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4525 (regex_compile, re_search_2, re_match_2_internal):
4526 Remove unused local vars.
4527 (FREE_VAR): Rewrite so as not to use empty "else",
4528 which gcc can warn about.
4529 (regex_compile, re_match_2_internal): Mark locals as initialized.
4530 (RETALLOC_IF): Define only if needed.
4531 (WORDCHAR_P): Likewise. This one is never needed, but is used
4532 only in a comment talking about a compiler bug, so put inside
4533 the #if 0 of that comment.
4534 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4535 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4536 Remove; unused.
4537
4538 * search.c (boyer_moore): Rename locals to avoid shadowing.
4539 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4540 (PREV_CHAR_BOUNDARY): Likewise.
4541
4542 * search.c (simple_search): Remove unused var.
4543
4544 * dired.c (compile_pattern): Move decl from here ...
4545 * lisp.h: ... to here, so that it can be checked.
4546 (struct re_registers): New forward decl.
4547
4548 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4549
4550 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4551 All uses changed.
4552 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4553 Rename locals to avoid shadowing.
4554 (Fvertical_motion): Mark locals as initialized.
4555
4556 * casefiddle.c (casify_object, casify_region): Now static.
4557 (casify_region): Mark local as initialized.
4558
4559 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4560
4561 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4562 New macros, so that the caller can use some names other than
4563 gcpro1, gcpro2, etc.
4564 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4565 of the new macros.
4566 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4567 argument, for consistency with GCPRO2_VAR, etc: it is now the
4568 prefix of the variable, not the variable itself. All uses
4569 changed.
4570 * dired.c (directory_files_internal, file_name_completion):
4571 Rename locals to avoid shadowing.
4572
4573 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4574 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4575 dired.c's scmp function, had undefined behavior.
4576 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4577 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4578 * buffer.h: ... to here, because these macros use current_buffer,
4579 and the new implementation with inline functions needs to have
4580 current_buffer in scope now, rather than later when the macros
4581 are used.
4582 (downcase, upcase1): New static inline functions.
4583 (DOWNCASE, UPCASE1): Reimplement using these functions.
4584 This avoids undefined behavior in expressions like
4585 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4586 from race conditions in accessing the global variables
4587 case_temp1 and case_temp2.
4588 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4589 * lisp.h (case_temp1, case_temp2): Remove their decls.
4590 * character.h (ASCII_CHAR_P): Move from here ...
4591 * lisp.h: ... to here, so that the inline functions mentioned
4592 above can use them.
4593
4594 * dired.c (directory_files_internal_unwind): Now static.
4595
4596 * fileio.c (file_name_as_directory, directory_file_name):
4597 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4598 Now static.
4599 (file_name_as_directory): Use const pointers when appropriate.
4600 (Fexpand_file_name): Likewise. In particular, newdir might
4601 point at constant storage, so make it a const pointer.
4602 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4603 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4604 signedness issues.
4605 (Fset_file_times, Finsert_file_contents, auto_save_error):
4606 Rename locals to avoid shadowing.
4607
4608 * minibuf.c (choose_minibuf_frame_1): Now static.
4609 (Ftry_completion, Fall_completions): Rename or remove locals
4610 to avoid shadowing.
4611
4612 * marker.c (bytepos_to_charpos): Remove; unused.
4613
4614 * lisp.h (verify_bytepos, count_markers): New decls,
4615 so that gcc does not warn that these functions aren't declared.
4616
4617 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4618 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4619 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4620 (copy_text): Remove unused local var.
4621
4622 * filelock.c (within_one_second): Now static.
4623 (lock_file_1): Rename local to avoid shadowing.
4624
4625 * buffer.c (fix_overlays_before): Mark locals as initialized.
4626 (fix_start_end_in_overlays): Likewise. This function should be
4627 simplified by using pointers-to-pointers, but that's a different
4628 matter.
4629 (switch_to_buffer_1): Now static.
4630 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4631 (report_overlay_modification): Rename locals to avoid shadowing.
4632
4633 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4634 Fix pointer signedness issue.
4635 (sys_subshell): Mark local as volatile if checking for lint,
4636 to suppress a gcc -Wclobbered warning that does not seem to be right.
4637 (MAXPATHLEN): Define only if needed.
4638
4639 * process.c (serial_open, serial_configure): Move decls from here ...
4640 * systty.h: ... to here, so that they can be checked.
4641
4642 * fns.c (get_random, seed_random): Move extern decls from here ...
4643 * lisp.h: ... to here, so that they can be checked.
4644
4645 * sysdep.c (reset_io): Now static.
4646 (wait_for_termination_signal): Remove; unused.
4647
4648 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4649 (copy_keymap_item, append_key, push_text_char_description):
4650 Now static.
4651 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4652 (DENSE_TABLE_SIZE): Remove; unused.
4653 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4654 (describe_map_tree):
4655 Rename locals to avoid shadowing.
4656
4657 * keyboard.c: Declare functions static if they are not used elsewhere.
4658 (echo_char, echo_dash, cmd_error, top_level_2):
4659 (poll_for_input, handle_async_input): Now static.
4660 (read_char, kbd_buffer_get_event, make_lispy_position):
4661 (make_lispy_event, make_lispy_movement, apply_modifiers):
4662 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4663 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4664 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4665 (read_key_sequence, read_char): Mark locals as initialized.
4666 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4667
4668 * keyboard.h (make_ctrl_char): New decl.
4669 (mark_kboards): Move decl here ...
4670 * alloc.c (mark_kboards): ... from here.
4671
4672 * lisp.h (force_auto_save_soon): New decl.
4673
4674 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4675 (DEFINE_DUMMY_FUNCTION): New macro.
4676 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4677 Use it.
4678 (main): Add casts to avoid warnings
4679 if GCC considers string literals to be constants.
4680
4681 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4682
4683 * dbusbind.c: Pointer signedness fixes.
4684 (xd_signature, xd_append_arg, xd_initialize):
4685 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4686 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4687 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4688 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4689
4690 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4691 if GCC considers string literals to be constants.
4692 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4693
4694 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4695
4696 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4697 (print_preprocess, print_object): New macro to fix last change.
4698
4699 * print.c (print_preprocess): Don't forget font objects.
4700
4701 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4702
4703 * emacs.c (USAGE3): Doc fixes.
4704
4705 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4706
4707 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4708 structure.
4709
4710 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4711
4712 * lisp.h (VWindow_system, Qfile_name_history):
4713 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4714 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4715 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4716
4717 * w32select.c: Don't #include "keyboard.h".
4718 (run_protected): Add extern declaration for waiting_for_input.
4719
4720 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4721 * w32console.c (detect_input_pending, read_input_pending)
4722 (encode_terminal_code):
4723 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4724 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4725 (w32_system_caret_y, Qfile_name_history):
4726 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4727 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4728 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4729 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4730 * w32proc.c (Qlocal, report_file_error):
4731 * w32term.c (Vwindow_system, updating_frame):
4732 * w32uniscribe.c (initialized, uniscribe_font_driver):
4733 Remove unneeded extern declarations.
4734
4735 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4736
4737 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4738
4739 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4740
4741 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4742 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4743 These macros can no longer be used for assignment.
4744
4745 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4746 Assign struct members directly, instead of using BUF_BEGV etc.
4747 (record_buffer_markers, fetch_buffer_markers): New functions for
4748 recording and fetching special buffer markers.
4749 (set_buffer_internal_1, set_buffer_temp): Use them.
4750
4751 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4752
4753 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4754
4755 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4756 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4757
4758 * xdisp.c (hscroll_window_tree):
4759 (reconsider_clip_changes): Use PT instead of BUF_PT.
4760
4761 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4762
4763 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4764 $(EMACS_ROOT)/lib/intprops.h.
4765
4766 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4767
4768 Fix more problems found by GCC 4.5.2's static checks.
4769
4770 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4771 to unsigned char * to avoid compiler diagnostic.
4772 (xg_free_frame_widgets): Make it clear that a local variable is
4773 needed only if USE_GTK_TOOLTIP.
4774 (gdk_window_get_screen): Make it clear that this macro is needed
4775 only if USE_GTK_TOOLTIP.
4776 (int_gtk_range_get_value): New function, which avoids a diagnostic
4777 from gcc -Wbad-function-cast.
4778 (xg_set_toolkit_scroll_bar_thumb): Use it.
4779 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4780 diagnostic from gcc -Wbad-function-cast.
4781 (get_utf8_string, xg_get_file_with_chooser):
4782 Rename locals to avoid shadowing.
4783 (create_dialog): Move locals to avoid shadowing.
4784
4785 * xgselect.c (xg_select): Remove unused var.
4786
4787 * image.c (four_corners_best): Mark locals as initialized.
4788 (gif_load): Initialize transparent_p to zero (Bug#8238).
4789 Mark another local as initialized.
4790 (my_png_error, my_error_exit): Mark with NO_RETURN.
4791
4792 * image.c (clear_image_cache): Now static.
4793 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4794 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4795 (x_edge_detection): Remove unnecessary cast that
4796 gcc -Wbad-function-cast diagnoses.
4797 (gif_load): Fix pointer signedness.
4798 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4799 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4800
4801 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4802
4803 Improve quality of tests for time stamp overflow.
4804 For example, without this patch (encode-time 0 0 0 1 1
4805 1152921504606846976) returns the obviously-bogus value (-948597
4806 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4807 reports time overflow. See
4808 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4809 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4810 * editfns.c: Include limits.h and intprops.h.
4811 (TIME_T_MIN, TIME_T_MAX): New macros.
4812 (time_overflow): Move earlier, to before first use.
4813 (hi_time, lo_time): New functions, for an accurate test for
4814 out-of-range times.
4815 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4816 (Fget_internal_run_time): Don't assume time_t fits in int.
4817 (make_time): Use list2 instead of Fcons twice.
4818 (Fdecode_time): More accurate test for out-of-range times.
4819 (check_tm_member): New function.
4820 (Fencode_time): Use it, to test for out-of-range times.
4821 (lisp_time_argument): Don't rely on undefined left-shift and
4822 right-shift behavior when checking for time stamp overflow.
4823
4824 * editfns.c (time_overflow): New function, refactoring common code.
4825 (Fformat_time_string, Fdecode_time, Fencode_time):
4826 (Fcurrent_time_string): Use it.
4827
4828 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4829 * dired.c (make_time): Move to ...
4830 * editfns.c (make_time): ... here.
4831 * systime.h: Note the move.
4832
4833 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4834
4835 * fringe.c (update_window_fringes): Remove unused variables.
4836
4837 * unexmacosx.c (copy_data_segment): Also copy __got section.
4838 (Bug#8223)
4839
4840 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4841
4842 * termcap.c [MSDOS]: Include "msdos.h".
4843 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4844 Constify `char *' arguments and their references according to
4845 prototypes in tparam.h.
4846
4847 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4848
4849 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4850 Adapt all references accordingly.
4851
4852 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4853
4854 2011-03-11 Tom Tromey <tromey@redhat.com>
4855
4856 * buffer.c (syms_of_buffer): Remove obsolete comment.
4857
4858 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4859
4860 * termhooks.h (encode_terminal_code): Declare prototype.
4861
4862 * msdos.c (encode_terminal_code): Don't declare prototype.
4863
4864 * term.c (encode_terminal_code): Now external again, used by
4865 w32console.c and msdos.c.
4866
4867 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4868 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4869
4870 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4871
4872 Fix some minor problems found by GCC 4.5.2's static checks.
4873
4874 * fringe.c (update_window_fringes): Mark locals as initialized
4875 (Bug#8227).
4876 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4877
4878 * alloc.c (mark_fringe_data): Move decl from here ...
4879 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4880 to check its interface.
4881 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4882
4883 * fontset.c (free_realized_fontset): Now static.
4884 (Fset_fontset_font): Rename local to avoid shadowing.
4885 (fontset_font): Mark local as initialized.
4886 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
4887
4888 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4889
4890 * xselect.c (x_disown_buffer_selections): Remove; not used.
4891 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
4892 (x_own_selection, Fx_disown_selection_internal): Rename locals
4893 to avoid shadowing.
4894 (x_handle_dnd_message): Remove local to avoid shadowing.
4895
4896 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4897 so that the caller can use some name other than gcpro1.
4898 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
4899 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4900 (Fx_backspace_delete_keys_p):
4901 Use them to avoid shadowing, and rename vars to avoid shadowing.
4902 (x_decode_color, x_set_name, x_window): Now static.
4903 (Fx_create_frame): Add braces to silence GCC warning.
4904 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
4905 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4906 Remove unused locals.
4907 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4908 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4909 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4910 macros.
4911
4912 * xterm.h (x_mouse_leave): New decl.
4913
4914 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4915 Remove unused functions.
4916 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4917 (x_calc_absolute_position): Now static.
4918 (XTread_socket): Don't define label "out" unless it's used.
4919 Don't declare local "event" unless it's used.
4920 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4921 unless they are used.
4922 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4923 (x_fatal_error_signal): Remove; not used.
4924 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4925 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4926 (x_error_catcher, x_connection_closed, x_error_handler):
4927 (x_error_quitter, xembed_send_message, x_iconify_frame):
4928 (my_log_handler): Rename locals to avoid shadowing.
4929 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
4930 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
4931
4932 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4933 Rename or move locals to avoid shadowing.
4934 (tty_defined_color, merge_face_heights): Now static.
4935 (free_realized_faces_for_fontset): Remove; not used.
4936 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4937 does not deduce is never used uninitialized.
4938 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4939 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
4940
4941 * terminal.c (store_terminal_param): Now static.
4942
4943 * xmenu.c (menu_highlight_callback): Now static.
4944 (set_frame_menubar): Remove unused local.
4945 (xmenu_show): Rename parameter to avoid shadowing.
4946 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4947 since they might point to immutable storage.
4948 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4949 since it's unused otherwise.
4950
4951 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
4952 Add a FIXME, since the code still doesn't look right. (Bug#8215)
4953 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4954 avoids a gcc -Wuninitialized diagnostic.
4955 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
4956 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4957 does not deduce are never used uninitialized.
4958
4959 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4960
4961 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4962 * window.c (window_loop, size_window):
4963 (run_window_configuration_change_hook, enlarge_window): Likewise.
4964
4965 * window.c (display_buffer): Now static.
4966 (size_window): Mark variables that gcc -Wuninitialized
4967 does not deduce are never used uninitialized.
4968 * window.h (check_all_windows): New decl, to forestall
4969 gcc -Wmissing-prototypes diagnostic.
4970 * dispextern.h (bidi_dump_cached_states): Likewise.
4971
4972 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4973 shadowing.
4974 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4975 Include <limits.h>.
4976 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4977 and to avoid gcc -Wuninitialized warning.
4978 (load_charset_map): Mark variables that gcc -Wuninitialized
4979 does not deduce are never used uninitialized.
4980 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4981
4982 * coding.c (coding_set_source, coding_set_destination):
4983 Use "else { /* comment */ }" rather than "else /* comment */;"
4984 for clarity, and to avoid gcc -Wempty-body warning.
4985 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4986 a block, when the outer 'i' will do.
4987 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4988 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4989 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4990 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4991 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4992 Rename locals to avoid shadowing.
4993 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4994 * coding.c (emacs_mule_char, encode_invocation_designation):
4995 Now static, since they're not used elsewhere.
4996 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4997 (decode_coding_object, encode_coding_object, detect_coding_system):
4998 (decode_coding_emacs_mule): Mark variables that gcc
4999 -Wuninitialized does not deduce are never used uninitialized.
5000 (detect_coding_iso_2022): Initialize a local variable that might
5001 be used uninitialized. Leave a FIXME because it's not clear that
5002 this initialization is needed. (Bug#8211)
5003 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5004 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5005 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5006 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5007 Remove unused macros.
5008
5009 * category.c (hash_get_category_set): Remove unused local var.
5010 (copy_category_table): Now static, since it's not used elsewhere.
5011 * character.c (string_count_byte8): Likewise.
5012
5013 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5014 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5015
5016 * chartab.c (copy_sub_char_table): Now static, since it's not used
5017 elsewhere.
5018 (sub_char_table_ref_and_range, char_table_ref_and_range):
5019 Rename locals to avoid shadowing.
5020 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
5021
5022 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
5023 (BIDI_BOB): Remove unused macro.
5024
5025 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5026 deduce are never used uninitialized.
5027 * term.c (encode_terminal_code): Likewise.
5028
5029 * term.c (encode_terminal_code): Now static. Remove unused local.
5030
5031 * tparam.h: New file.
5032 * term.c, tparam.h: Include it.
5033 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5034 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5035 Move these decls to tparam.h, and make them agree with what
5036 is actually in tparam.c. The previous trick of using incompatible
5037 decls in different modules does not conform to the C standard.
5038 All callers of tparam changed to use tparam's actual API.
5039 * tparam.c (tparam1, tparam, tgoto):
5040 Use const pointers where appropriate.
5041
5042 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5043 * cm.h (struct cm): Likewise.
5044 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5045 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5046 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5047 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5048 (turn_on_face, init_tty): Likewise.
5049 * termchar.h (struct tty_display_info): Likewise.
5050
5051 * term.c (term_mouse_position): Rename local to avoid shadowing.
5052
5053 * alloc.c (mark_ttys): Move decl from here ...
5054 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5055
5056 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5057
5058 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5059
5060 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
5061
5062 * search.c (compile_pattern_1): Remove argument regp, unused since
5063 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5064 (compile_pattern): Don't pass it.
5065
5066 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5067
5068 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5069 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5070 for ! HAVE_GTK3.
5071 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5072
5073 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5074
5075 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5076 gdk_window_get_screen, gdk_window_get_geometry,
5077 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5078 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5079 (xg_get_pixbuf_from_pixmap): New function.
5080 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5081 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5082 Call xg_get_pixbuf_from_pixmap instead of
5083 gdk_pixbuf_get_from_drawable.
5084 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5085 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5086 (xg_check_special_colors): Use GtkStyleContext and its functions
5087 for HAVE_GTK3.
5088 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5089 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5090 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
5091 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5092 Call gtk_widget_get_preferred_size.
5093 (xg_frame_resized): gdk_window_get_geometry only takes 5
5094 parameters.
5095 (xg_win_to_widget, xg_event_is_for_menubar):
5096 Call gdk_x11_window_lookup_for_display.
5097 (xg_set_widget_bg): New function.
5098 (delete_cb): New function.
5099 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5100 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5101 (xg_set_background_color): Call xg_set_widget_bg.
5102 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5103 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5104 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5105 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5106 if ! HAVE_GTK3.
5107 (update_frame_tool_bar): Call gtk_widget_hide.
5108 (xg_initialize): Use GDK_KEY_g.
5109
5110 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5111 if ! HAVE_GTK3
5112 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5113
5114 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5115 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5116 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5117
5118 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
5119
5120 * w32xfns.c (select_palette): Check success of RealizePalette against
5121 GDI_ERROR, not zero.
5122
5123 See ChangeLog.11 for earlier changes.
5124
5125 ;; Local Variables:
5126 ;; coding: utf-8
5127 ;; End:
5128
5129 Copyright (C) 2011 Free Software Foundation, Inc.
5130
5131 This file is part of GNU Emacs.
5132
5133 GNU Emacs is free software: you can redistribute it and/or modify
5134 it under the terms of the GNU General Public License as published by
5135 the Free Software Foundation, either version 3 of the License, or
5136 (at your option) any later version.
5137
5138 GNU Emacs is distributed in the hope that it will be useful,
5139 but WITHOUT ANY WARRANTY; without even the implied warranty of
5140 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5141 GNU General Public License for more details.
5142
5143 You should have received a copy of the GNU General Public License
5144 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.