merge trunk
[bpt/emacs.git] / src / ChangeLog
1 2012-02-02 Glenn Morris <rgm@gnu.org>
2
3 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4
5 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
6 Unconditionally set to t. (Bug#10673)
7 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
8 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
9 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
10
11 2012-02-02 Kenichi Handa <handa@m17n.org>
12
13 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
14 0, do not call append_composite_glyph.
15
16 2012-02-02 Kenichi Handa <handa@m17n.org>
17
18 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
19 NULL (Bug#6988).
20 (x_produce_glyphs): If the component of a composition is a null
21 string, set it->pixel_width to 1 to avoid zero-width glyph.
22
23 2012-02-01 Eli Zaretskii <eliz@gnu.org>
24
25 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
26 first 2 arguments are identical. This makes inserting large
27 output from a subprocess an order of magnitude faster on
28 MS-Windows, where all sbrk'ed memory is always contiguous.
29
30 2012-01-31 Glenn Morris <rgm@gnu.org>
31
32 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
33 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
34 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
35
36 2012-01-29 Glenn Morris <rgm@gnu.org>
37
38 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
39
40 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
41
42 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
43
44 2012-01-28 Chong Yidong <cyd@gnu.org>
45
46 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
47
48 2012-01-26 Chong Yidong <cyd@gnu.org>
49
50 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
51
52 * search.c (Fsearch_forward, Fsearch_backward): Document negative
53 repeat counts (Bug#10507).
54
55 2012-01-26 Glenn Morris <rgm@gnu.org>
56
57 * lread.c (syms_of_lread): Doc fix.
58
59 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
60
61 * coding.c (encode_designation_at_bol): Change return value to
62 EMACS_INT.
63
64 2012-01-25 Chong Yidong <cyd@gnu.org>
65
66 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
67
68 2012-01-21 Chong Yidong <cyd@gnu.org>
69
70 * floatfns.c (Fcopysign): Make the second argument non-optional,
71 since nil is not allowed anyway.
72
73 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
74
75 * process.c (read_process_output): Use p instead of XPROCESS (proc).
76 (send_process): Likewise.
77
78 2012-01-19 Martin Rudalics <rudalics@gmx.at>
79
80 * window.c (save_window_save, Fcurrent_window_configuration)
81 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
82 doc-strings.
83
84 2012-01-19 Kenichi Handa <handa@m17n.org>
85
86 * character.c (char_width): New function.
87 (Fchar_width, c_string_width, lisp_string_width):
88 Use char_width (Bug#9496).
89
90 2012-01-16 Martin Rudalics <rudalics@gmx.at>
91
92 * window.c (Vwindow_persistent_parameters): New variable.
93 (Fset_window_configuration, save_window_save): Handle persistent
94 window parameters.
95
96 2012-01-14 Eli Zaretskii <eliz@gnu.org>
97
98 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
99 thrashing the stack of the thread. (Bug#9087)
100
101 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
102
103 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
104
105 2012-01-11 Eli Zaretskii <eliz@gnu.org>
106
107 * xdisp.c (rows_from_pos_range): Handle the case where the
108 highlight ends on a newline. (Bug#10464)
109 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
110 he end column for display of highlight that ends on a newline
111 before a R2L line.
112
113 2012-01-11 Glenn Morris <rgm@gnu.org>
114
115 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
116 from load-path also when installation-directory is nil. (Bug#10208)
117
118 2012-01-10 Glenn Morris <rgm@gnu.org>
119
120 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
121
122 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
123 Update template values to be closer to their typical values these days.
124
125 2012-01-09 Eli Zaretskii <eliz@gnu.org>
126
127 * xdisp.c (rows_from_pos_range): Accept additional argument
128 DISP_STRING, and accept any glyph in a row whose object is that
129 string as eligible for mouse highlight. Fixes mouse highlight of
130 display strings from overlays. (Bug#10464)
131
132 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
133
134 emacs: fix an auto-save permissions race condition (Bug#10400)
135 * fileio.c (auto_saving_dir_umask): New static var.
136 (Fmake_directory_internal): Use it.
137 (do_auto_save_make_dir): Set it, instead of invoking chmod after
138 creating the directory. The old code temporarily assigns
139 too-generous permissions to the directory.
140 (do_auto_save_eh): Clear it.
141 (Fdo_auto_save): Catch all errors, not just file errors, so
142 that the var is always cleared.
143
144 2012-01-07 Eli Zaretskii <eliz@gnu.org>
145
146 * search.c (scan_buffer): Pass character positions to
147 know_region_cache, not byte positions. (Bug#6540)
148
149 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
150
151 * w32.c (sys_rename): Report EXDEV when rename of a directory
152 fails because the target is on another logical disk. (Bug#10284)
153
154 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
155
156 * xterm.c (x_embed_request_focus): New function.
157
158 * xterm.h: Add prototype.
159
160 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
161
162 2012-01-05 Glenn Morris <rgm@gnu.org>
163
164 * emacs.c (emacs_copyright): Update short copyright year to 2012.
165
166 2012-01-01 Eli Zaretskii <eliz@gnu.org>
167
168 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
169 Load gnutls_transport_set_lowat only if GnuTLS version is below
170 2.11.1.
171 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
172 GnuTLS versions below 2.11.1.
173
174 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
175
176 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
177 to the doc string advising against its use for altering the way
178 windows are scrolled.
179
180 2011-12-28 Kenichi Handa <handa@m17n.org>
181
182 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
183 coding-system ASCII compatible only when it does not produce BOM
184 on encoding (Bug#10383).
185
186 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
187
188 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
189 can scroll.
190 (create_and_show_popup_menu): Always use menu_position_func for
191 Gtk3 (Bug#10361).
192
193 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
194
195 * callint.c (Fcall_interactively): Don't truncate prompt string.
196
197 2011-12-23 Eli Zaretskii <eliz@gnu.org>
198
199 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
200 property that ends at ZV, so that the bidi iteration could be
201 resumed from there (after widening). (Bug#10360)
202
203 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
204
205 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
206
207 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
208
209 * nsterm.m (x_free_frame_resources):
210 Release f->output_data.ns->miniimage.
211 (ns_index_color): Fix indentation. Do not retain
212 color_table->colors[i].
213
214 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
215 before returning.
216
217 * nsfns.m (x_set_background_color): Assign return value from
218 ns_index_color to face-background instead of NSColor*.
219 (ns_implicitly_set_icon_type): Fix indentation.
220 Change assignment in for loop to comparison.
221
222 * emacs.c (ns_pool): New variable.
223 (main): Assign ns_pool.
224 (Fkill_emacs): Call ns_release_autorelease_pool.
225
226 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
227 autorelease fdesc, release fdAttrs and tdict.
228 (ns_get_covering_families): Release charset.
229 (ns_findfonts): Release NSFontDescriptor created with new.
230 (ns_uni_to_glyphs): Fix indentation.
231 (setString): Release attrStr before assigning new value.
232
233 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
234
235 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
236 and NS_IMPL_COCOA.
237 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
238 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
239
240 2011-12-18 David Reitter <reitter@cmu.edu>
241
242 * nsterm.m (ns_term_init): Subscribe for notifications
243 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
244 to method trackingNotification in EmacsMenu.
245
246 * nsmenu.m (trackingMenu): New variable.
247 (trackingNotification): New method (from Aquamacs).
248 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
249 from Aquamacs (Bug#7030).
250
251 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
252
253 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
254 (symbol_to_nsstring): Fix indentation.
255 (ns_symbol_to_pb): New function.
256 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
257 (Fns_rotate_cut_buffers_internal): Removed.
258 (Fns_store_selection_internal): Renamed from
259 Fns_store_cut_buffer_internal.
260 (ns_get_foreign_selection, Fx_own_selection_internal)
261 (Fx_disown_selection_internal, Fx_selection_exists_p)
262 (Fns_get_selection_internal, Fns_store_selection_internal):
263 Use ns_symbol_to_pb and check if return value is nil.
264 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
265 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
266 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
267 renamed to Sns_store_selection_internal.
268 (ns_handle_selection_request): Move code to Fx_own_selection_internal
269 and remove this function.
270 (ns_handle_selection_clear): Remove, never used.
271 (Fx_own_selection_internal): Move code from ns_handle_selection_request
272 here.
273
274 2011-12-17 Ken Brown <kbrown@cornell.edu>
275
276 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
277 GID is unknown (Bug#10257).
278
279 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
280
281 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
282 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
283 which caused a build failure on GNU/Linux IA-64. This problem was
284 introduced by my 2011-10-07 patch.
285
286 2011-12-15 Juri Linkov <juri@jurta.org>
287
288 * image.c (imagemagick_error): New function. (Bug#10112)
289 (imagemagick_load_image): Comment out `MagickSetResolution' call.
290 Use `imagemagick_error' where ImageMagick functions return
291 `MagickFalse'.
292 (Fimagemagick_types): Add `Fnreverse' to return the list in the
293 proper order.
294
295 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
296
297 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
298 fill background (Bug#8992).
299
300 2011-12-13 Martin Rudalics <rudalics@gmx.at>
301
302 * window.c (Vwindow_combination_resize)
303 (Vwindow_combination_limit): Use t instead of non-nil in
304 doc-strings.
305 (Vrecenter_redisplay): Add first sentence of doc-string on
306 separate line.
307 (Frecenter): Fix doc-string typo.
308
309 2011-12-11 Kenichi Handa <handa@m17n.org>
310
311 * coding.c (Funencodable_char_position): Pay attention to the
312 buffer text relocation (Bug#9389).
313
314 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
315
316 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
317 gtk_init (Bug#10100).
318
319 2011-12-10 Eli Zaretskii <eliz@gnu.org>
320
321 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
322 IT->string is nil. (Bug#10263)
323
324 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
325
326 * nsterm.h (x_free_frame_resources): Declare.
327
328 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
329 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
330
331 * nsterm.h (ns_get_defaults_value): Declare.
332
333 * nsterm.m (ns_default): Call ns_get_defaults_value.
334
335 2011-12-09 Eli Zaretskii <eliz@gnu.org>
336
337 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
338 (Bug#10170)
339
340 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
341
342 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
343 that where the value of an _OBJC_* symbol points to is in the .bss
344 section (Bug#10240).
345
346 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
347
348 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
349 after the loop to call ccl_driver at least once (Bug#8619).
350
351 2011-12-08 Kenichi Handa <handa@m17n.org>
352
353 * ftfont.c (get_adstyle_property): Fix previous change
354 (Bug#10233).
355
356 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
357
358 * w32.c (init_environment): If no_site_lisp, remove site-lisp
359 dirs from the default value of EMACSLOADPATH (bug#10208).
360
361 2011-12-07 Glenn Morris <rgm@gnu.org>
362
363 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
364 installation and source directories as well. (Bug#10208)
365
366 2011-12-06 Chong Yidong <cyd@gnu.org>
367
368 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
369
370 2011-12-06 Glenn Morris <rgm@gnu.org>
371
372 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
373 as an error, not just -1. (Bug#10217)
374
375 2011-12-05 Chong Yidong <cyd@gnu.org>
376
377 * keyboard.c (process_special_events): New function.
378 (swallow_events, Finput_pending_p): Use it (Bug#10195).
379
380 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
381
382 * coding.c (encode_designation_at_bol): Don't use uninitialized
383 local variable (Bug#9318).
384
385 2011-12-05 Kenichi Handa <handa@m17n.org>
386
387 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
388 return Qnil (Bug#8046, Bug#10193).
389
390 2011-12-05 Kenichi Handa <handa@m17n.org>
391
392 * coding.c (encode_designation_at_bol): New args charbuf_end and
393 dst. Return the number of produced bytes. Callers changed.
394 (coding_set_source): Return how many bytes coding->source was
395 relocated.
396 (coding_set_destination): Return how many bytes
397 coding->destination was relocated.
398 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
399 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
400
401 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
402
403 * coding.c (CODING_CHAR_CHARSET_P): New macro.
404 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
405 macro (Bug#9318).
406
407 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
408
409 The following changes are to fix Bug#9318.
410
411 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
412 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
413 (encode_coding_iso_2022, encode_coding_sjis)
414 (encode_coding_big5, encode_coding_charset): Use the above macros.
415
416 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
417
418 * lisp.h (process_quit_flag): Fix external declaration.
419
420 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
421
422 Don't macro-inline non-performance-critical code.
423 * eval.c (process_quit_flag): New function.
424 * lisp.h (QUIT): Use it.
425
426 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
427
428 * nsfns.m (get_geometry_from_preferences): New function.
429 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
430
431 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
432
433 * emacs.c (Qkill_emacs): Define.
434 (syms_of_emacs): Initialize it.
435 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
436 Qquit_flag to `kill-emacs' instead.
437 (quit_throw_to_read_char): Add parameter `from_signal'.
438 All callers changed. Call Fkill_emacs if requested and safe.
439 * lisp.h (QUIT): Call Fkill_emacs if requested.
440
441 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
442
443 * widget.c (update_wm_hints): Return if wmshell is null.
444 (widget_update_wm_size_hints): New function.
445
446 * widget.h (widget_update_wm_size_hints): Declare.
447
448 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
449 widget_update_wm_size_hints (Bug#10104).
450
451 2011-12-03 Eli Zaretskii <eliz@gnu.org>
452
453 * xdisp.c (handle_invisible_prop): If the invisible text ends just
454 before a newline, prepare the bidi iterator for consuming the
455 newline, and keep the current paragraph direction. (Bug#10183)
456 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
457
458 2011-12-02 Juri Linkov <juri@jurta.org>
459
460 * search.c (Fword_search_regexp): New Lisp function created from
461 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
462 (Fword_search_backward, Fword_search_forward)
463 (Fword_search_backward_lax, Fword_search_forward_lax):
464 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
465 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
466
467 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
468
469 * fileio.c (Finsert_file_contents): Move after-change-function call
470 to before the "handled:" label, since all "goto handled" appear in
471 cases where the *-change-functions have already been properly called
472 (bug#10117).
473
474 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
475
476 * keyboard.c (interrupt_signal): Don't call kill-emacs when
477 waiting for input. (Bug#10169)
478
479 2011-11-30 Eli Zaretskii <eliz@gnu.org>
480
481 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
482 verifies glyph row's hash code--we have just reallocated the
483 glyphs, so their contents can be complete garbage. (Bug#10164)
484
485 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
486
487 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
488
489 2011-11-30 Eli Zaretskii <eliz@gnu.org>
490
491 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
492 attributes are tested _before_ calling verify_row_hash, to protect
493 against GCC re-ordering of the tests. (Bug#10164)
494
495 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
496
497 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
498
499 * xterm.c (handle_one_xevent): Only set async_visible and friends
500 if net_wm_state_hidden_seen is non-zero (Bug#10002)
501 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
502 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
503
504 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
505
506 Remove GCPRO-related macros that exist only to avoid shadowing locals.
507 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
508 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
509 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
510 All uses changed to use GCPRO1 etc.
511 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
512 Revert to old implementation (i.e., before 2011-03-11).
513
514 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
515
516 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
517 of scroll runs so as to avoid assigning disabled bogus rows and
518 unnecessary graphics copy operations.
519
520 2011-11-27 Eli Zaretskii <eliz@gnu.org>
521
522 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
523 (snprintf) [_MSC_VER]: Redirect to _snprintf.
524 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
525 (malloc, free, realloc, calloc): Redirect to e_* only when
526 compiling Emacs.
527
528 * lisp.h (GCTYPEBITS): Move before first use.
529 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
530 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
531 this macro definition.
532
533 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
534 _MSC_VER.
535
536 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
537
538 * gtkutil.c (xg_create_frame_widgets):
539 Call gtk_window_set_has_resize_grip (FALSE) if that function is
540 present with Gtk+ 2.0.
541
542 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
543
544 * fileio.c (Finsert_file_contents): Undo previous change; see
545 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
546
547 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
548
549 Rename locals to avoid shadowing.
550 * fileio.c (Finsert_file_contents):
551 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
552 * process.c (wait_reading_process_output):
553 Rename inner 'proc' to 'p' to avoid shadowing.
554 Indent for consistency with usual Emacs style.
555
556 2011-11-25 Eli Zaretskii <eliz@gnu.org>
557
558 * xdisp.c (redisplay_window): If cursor row is not fully visible
559 after recentering, and scroll-conservatively is set to a large
560 number, scroll window by a few more lines to make the cursor fully
561 visible and out of scroll-margin. (Bug#10105)
562 (start_display): Don't move to the next line if the display should
563 start at a newline that is part of a display vector or an overlay
564 string. (Bug#10119)
565
566 2011-11-24 Juri Linkov <juri@jurta.org>
567
568 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
569 after the `MagickPingImage' call. (Bug#10112)
570
571 2011-11-23 Chong Yidong <cyd@gnu.org>
572
573 * window.c (Fcoordinates_in_window_p): Accept only live windows.
574
575 2011-11-23 Martin Rudalics <rudalics@gmx.at>
576
577 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
578 making another buffer current. (Bug#10114)
579
580 2011-11-23 Glenn Morris <rgm@gnu.org>
581
582 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
583
584 2011-11-23 Chong Yidong <cyd@gnu.org>
585
586 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
587 using it (Bug#5984).
588
589 2011-11-22 Eli Zaretskii <eliz@gnu.org>
590
591 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
592 and header-lines, as they don't have one computed for them.
593 (Bug#10098)
594
595 * .gdbinit (prow): Make displayed values more self-explaining.
596 Add row's hash code.
597
598 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
599
600 * process.c (wait_reading_process_output): Fix asynchrounous
601 GnuTLS socket handling on some versions of the GnuTLS library.
602 (wait_reading_process_output): Add comment and URL.
603
604 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
605
606 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
607
608 2011-11-21 Chong Yidong <cyd@gnu.org>
609
610 * window.c (Fnext_window, Fprevious_window): Doc fix.
611
612 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
613
614 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
615
616 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
617
618 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
619
620 2011-11-20 Martin Rudalics <rudalics@gmx.at>
621
622 * window.c (Fset_window_combination_limit): Rename argument
623 STATUS to LIMIT.
624 (Vwindow_combination_limit): Remove "status" from doc-string.
625
626 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
627
628 * m/ibms390.h: Remove.
629 * m/ibms390x.h: Don't include "ibms390.h".
630
631 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
632
633 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
634 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
635
636 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
637
638 * casetab.c (Fset_case_table):
639 * charset.c (Fcharset_after): Fix typos.
640
641 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
642
643 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
644 Otherwise, valgrind does not work on some platforms.
645 Problem reported by Andreas Schwab in
646 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
647 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
648 is set, removing the need for VIRT_ADDRESS_VARIES.
649 (PURE_P): Use a more-efficient implementation that needs just one
650 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
651 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
652 to 4 (xorl, subq, cmpq, setbe).
653 * alloc.c (pure): Always extern now, since that's the
654 VIRT_ADDR_VARIES behavior.
655 (PURE_POINTER_P): Use a single comparison, not two, for
656 consistency with the new puresize.h.
657 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
658 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
659 Remove VIRT_ADDR_VARIES no longer needed.
660
661 2011-11-19 Eli Zaretskii <eliz@gnu.org>
662
663 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
664 (erase_phys_cursor, update_window_cursor, show_mouse_face)
665 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
666 behave as if the cursor position were at the window margin.
667
668 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
669 and the cursor position is out of bounds, behave as if the cursor
670 position were at the window margin. (Bug#10075)
671
672 2011-11-18 Chong Yidong <cyd@gnu.org>
673
674 * window.c (Fwindow_combination_limit): Make first argument
675 non-optional, since it is meaningless for live windows like the
676 selected window.
677
678 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
679
680 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
681
682 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
683
684 * intervals.c: Fix grafting over the whole buffer (bug#10071).
685 (graft_intervals_into_buffer): Simplify.
686
687 2011-11-18 Eli Zaretskii <eliz@gnu.org>
688
689 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
690 hash values of the two rows.
691 (copy_row_except_pointers): Preserve the used[] arrays and the
692 hash values of the two rows. (Bug#10035)
693 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
694
695 * xdisp.c (row_hash): New function, body extracted from
696 compute_line_metrics.
697 (compute_line_metrics): Call row_hash, instead of computing the
698 hash code inline.
699
700 * dispnew.c (verify_row_hash): Call row_hash for computing the
701 hash code of a row, instead of duplicating code from xdisp.c.
702
703 * dispextern.h (row_hash): Add prototype.
704
705 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
706
707 * frame.c (delete_frame): Don't delete the terminal when the last
708 X frame is closed if emacs is built with GTK toolkit.
709
710 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
711
712 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
713
714 2011-11-17 Martin Rudalics <rudalics@gmx.at>
715
716 * window.c (Vwindow_splits): Rename to
717 Vwindow_combination_resize. Suggested by Juri Linkov.
718 (Fsplit_window_internal): Use Vwindow_combination_resize instead
719 of Vwindow_splits.
720
721 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
722
723 * nsfns.m (Fns_font_name):
724 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
725
726 2011-11-16 Martin Rudalics <rudalics@gmx.at>
727
728 * window.h (window): Rename slot "nest" to "combination_limit".
729 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
730 (Fset_window_nest): Rename to Fset_window_combination_limit.
731 (Vwindow_nest): Rename to Vwindow_combination_limit.
732 (recombine_windows, make_parent_window, make_window)
733 (Fsplit_window_internal, saved_window)
734 (Fset_window_configuration, save_window_save): Rename all
735 occurrences of window_nest to window_combination_limit.
736
737 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
738
739 * image.c (imagemagick_load_image): Fix typo.
740
741 2011-11-14 Eli Zaretskii <eliz@gnu.org>
742
743 * xdisp.c (display_line): Move the call to
744 highlight_trailing_whitespace before the call to
745 compute_line_metrics, since the latter needs to see the final
746 faces of all the glyphs to compute ROW's hash value.
747 Fixes assertion violations in row_equal_p. (Bug#10035)
748
749 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
750
751 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
752 just return (bug#10044).
753
754 2011-11-12 Eli Zaretskii <eliz@gnu.org>
755
756 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
757 with user-defined heap size. Bump the default size of the temacs
758 heap to 27MB, to avoid memory warning when running temacs.
759 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
760
761 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
762 current_matrix and desired_matrix. (Bug#9990)
763 (verify_row_hash) [XASSERTS]: New function.
764 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
765 that the hash value of glyph rows is correct.
766
767 2011-11-12 Martin Rudalics <rudalics@gmx.at>
768
769 * window.h (window): Remove splits slot.
770 * window.c (Fwindow_splits, Fset_window_splits): Remove.
771 (Fdelete_other_windows_internal, make_parent_window)
772 (make_window, Fsplit_window_internal, Fdelete_window_internal)
773 (Fset_window_configuration, save_window_save): Don't deal with
774 split status of windows.
775 (saved_window): Remove splits slot.
776 (Vwindow_splits): Rewrite doc-string.
777
778 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
779
780 * xfns.c (unwind_create_frame):
781 * nsfns.m (unwind_create_frame):
782 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
783 Vframe_list (Bug#9999).
784
785 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
786
787 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
788
789 2011-11-11 Kenichi Handa <handa@m17n.org>
790
791 * callproc.c (Fcall_process): Set the member dst_multibyte of
792 process_coding.
793
794 2011-11-11 Johan Bockgård <bojohan@gnu.org>
795
796 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
797 avoid a crash (bug#9496).
798
799 2011-11-09 Chong Yidong <cyd@gnu.org>
800
801 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
802 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
803
804 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
805
806 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
807
808 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
809
810 Avoid some portability problems by eschewing 'extern inline' functions.
811 The trivial performance wins aren't worth the portability hassles; see
812 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
813 et seq.
814 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
815 (window_box_width, window_box_left, window_box_left_offset)
816 (window_box_right, window_box_right_offset): Undo previous change,
817 by removing the "extern"s.
818 * intervals.c (adjust_intervals_for_insertion)
819 (adjust_intervals_for_deletion): Undo previous change,
820 making these static again.
821 (offset_intervals, temp_set_point_both, temp_set_point)
822 (copy_intervals_to_string): No longer inline.
823 * xdisp.c (window_text_bottom_y, window_box_width)
824 (window_box_height, window_box_left_offset)
825 (window_box_right_offset, window_box_left, window_box_right)
826 (window_box): No longer inline.
827
828 2011-11-08 Chong Yidong <cyd@gnu.org>
829
830 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
831 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
832 Signal an error if not a live window.
833 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
834 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
835
836 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
837
838 * lisp.h (syms_of_abbrev): Remove declaration.
839 Reported by CHENG Gao <chenggao@royau.me>.
840
841 2011-11-07 Eli Zaretskii <eliz@gnu.org>
842
843 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
844 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
845 of temacs in GUI mode.
846
847 2011-11-07 Martin Rudalics <rudalics@gmx.at>
848
849 * window.h: Declare delete_all_child_windows instead of
850 delete_all_subwindows.
851 * window.c (Fwindow_nest, Fset_window_nest)
852 (Fset_window_new_total, Fset_window_new_normal)
853 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
854 (delete_all_subwindows): Rename to delete_all_child_windows.
855 (Fdelete_other_windows_internal, Fset_window_configuration):
856 Call delete_all_child_windows instead of delete_all_subwindows.
857 * frame.c (delete_frame): Call delete_all_child_windows instead
858 of delete_all_subwindows.
859
860 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
861
862 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
863 This is also needed for porting to any host where GC_MARK_STACK is
864 not GC_MAKE_GCPROS_NOOPS.
865 (which_symbols): Use it.
866
867 2011-11-07 Kenichi Handa <handa@m17n.org>
868
869 * coding.c (coding_set_destination): Check coding->src_pos only
870 when coding->src_object is a buffer (bug#9910).
871
872 * process.c (send_process): Set the member src_multibyte of coding
873 to 0 (bug#9911) when sending a unibyte text.
874
875 * callproc.c (Fcall_process): Set the member src_multibyte of
876 process_coding to 0 (bug#9912).
877
878 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
879
880 * xmenu.c (cleanup_widget_value_tree): New function.
881 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
882 calling free_menubar_widget_value_tree directly (Bug#9830).
883
884 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
885
886 Fix some portability problems with 'inline'.
887 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
888 (window_box_width, window_box_left, window_box_left_offset)
889 (window_box_right, window_box_right_offset): Declare extern.
890 Otherwise, these inline functions do not conform to C99 and
891 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
892 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
893 * intervals.c (adjust_intervals_for_insertion)
894 (adjust_intervals_for_deletion): Now extern, because otherwise the
895 extern inline functions 'offset_intervals' couldn't refer to it.
896 (static_offset_intervals): Remove.
897 (offset_intervals): Rewrite using the old contents of
898 static_offset_intervals. The old version didn't conform to C99
899 because an extern inline function contained a reference to an
900 identifier with static linkage.
901
902 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
903
904 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
905 GC.
906
907 2011-11-06 Eli Zaretskii <eliz@gnu.org>
908
909 * xdisp.c (init_iterator, reseat_to_string): Don't set the
910 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
911 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
912 return Qleft_to_right.
913
914 2011-11-06 Chong Yidong <cyd@gnu.org>
915
916 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
917 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
918 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
919 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
920 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
921 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
922 (Fwindow_vscroll): Doc fix.
923 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
924 argument, since it makes no sense to pass a live window and for
925 consistency with window-child.
926
927 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
928
929 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
930 support MSVC.
931
932 2011-11-05 Jason Rumney <jasonr@gnu.org>
933
934 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
935 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
936 fonts (Bug#6029).
937 (add_font_entity_to_list): Fix logic errors in mixed boolean and
938 bitwise arithmetic preventing use of unicode-sip and non-truetype
939 opentype fonts.
940
941 2011-11-05 Eli Zaretskii <eliz@gnu.org>
942
943 * s/ms-w32.h (fstat, stat, utime): Move redirections to
944 "emacs"-only part.
945
946 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
947 initialization code to keep similarity to xfns.c after changes
948 from 2011-11-05.
949
950 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
951
952 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
953 (unwind_create_frame): New function (Bug#9943).
954 (Fx_create_frame): Restructure code to be more similar to the one in
955 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
956 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
957 Move terminal->reference_count++ just before making the frame official
958 (Bug#9943).
959
960 * nsterm.m (x_free_frame_resources): New function.
961 (x_destroy_window): Move code to x_free_frame_resources.
962
963 * xfns.c (unwind_create_frame): Fix comment.
964 (Fx_create_frame, x_create_tip_frame):
965 Move terminal->reference_count++ just before making the frame
966 official. Move initialization of image_cache_refcount and
967 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
968
969 2011-11-05 Eli Zaretskii <eliz@gnu.org>
970
971 Support MSVC build with newer versions of Visual Studio.
972 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
973 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
974 nt/gmake.defs.
975
976 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
977 which are not supported by MSVC.
978 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
979 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
980 bitfields.
981 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
982 types in bitfields.
983 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
984
985 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
986
987 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
988
989 Support MSVC build with newer versions of Visual Studio.
990 * w32.c: Don't include w32api.h for MSVC.
991 (init_environment) [_MSC_VER]: Call sys_access, not _access.
992
993 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
994 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
995 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
996 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
997 e_* cousins.
998 (alloca) [_MSC_VER]: Define to _alloca.
999
1000 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1001
1002 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1003
1004 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1005
1006 * xdisp.c (note_mouse_highlight): If either of
1007 previous/next-single-property-change returns nil, treat that as
1008 the beginning or the end of the buffer. (Bug#9955)
1009
1010 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1011
1012 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1013 label is not null (Bug#9951).
1014 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1015 may be NULL.
1016
1017 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1018
1019 * window.c (Fwindow_body_size): Mention in the doc string that the
1020 return value is in frame's canonical units. (Bug#9949)
1021
1022 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1023
1024 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1025
1026 * w32fns.c (unwind_create_frame): If needed, free the glyph
1027 matrices of the partially constructed frame. (Bug#9943)
1028 * xfns.c (unwind_create_frame): Likewise.
1029
1030 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1031
1032 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1033 Don't stop backward scan on the continuation glyph, even though
1034 its CHARPOS is positive.
1035 (mouse_face_from_buffer_pos, note_mouse_highlight):
1036 Rename cover_string to disp_string.
1037
1038 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1039
1040 * window.c (temp_output_buffer_show): Don't use
1041 Vtemp_buffer_show_specifiers.
1042 (Vtemp_buffer_show_specifiers): Remove unused variable.
1043
1044 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1045
1046 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1047 past the beginning of the current glyph matrix.
1048
1049 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1050
1051 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1052 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1053 HAVE_GTK3 (Bug#9869).
1054
1055 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1056 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1057
1058 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1059
1060 * xterm.c: Declare x_handle_net_wm_state to return int.
1061 (handle_one_xevent): Check if we are iconified but don't have
1062 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1063 (get_current_wm_state): Return non-zero if not hidden,
1064 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1065 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1066 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1067 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1068
1069 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1070
1071 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1072 so that this new function doesn't get optimized away by a
1073 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1074
1075 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1076
1077 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1078
1079 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1080
1081 Fix the `xbytecode' command.
1082 * .gdbinit (xprintbytestr): New command.
1083 (xwhichsymbols): Rename from `which'; all callers changed.
1084 (xbytecode): Print the byte-code string as well.
1085
1086 2011-10-29 Kim Storm <storm@cua.dk>
1087
1088 * alloc.c (which_symbols): New function.
1089
1090 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1091
1092 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1093 line. (Bug#9903)
1094
1095 2011-10-29 Glenn Morris <rgm@gnu.org>
1096
1097 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1098 Not clear what it was for, and it causes various bugs. (Bug#9839)
1099
1100 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1101
1102 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1103 possible random value that matches one of those tested as
1104 condition to clear the mouse face.
1105
1106 2011-10-28 Chong Yidong <cyd@gnu.org>
1107
1108 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1109
1110 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1111
1112 * window.c (make_window): Initialize phys_cursor_on_p.
1113
1114 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1115
1116 * lisp.h (struct Lisp_Symbol): Update comments.
1117
1118 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1119
1120 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1121
1122 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1123
1124 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1125 <oslsachem@gmail.com> for helping to debug this.
1126
1127 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1128 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1129 (g_b_init_get_glyph_outline_w): New static variables.
1130 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1131 (GetGlyphOutlineW_Proc): New typedefs.
1132 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1133 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1134 New functions.
1135 (w32font_open_internal, compute_metrics):
1136 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1137 instead of calling the "wide" APIs directly.
1138
1139 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1140
1141 * w32.h (syms_of_w32font): Add prototype.
1142
1143 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1144
1145 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1146 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1147 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1148 (Fmove_to_window_line): Doc fix.
1149
1150 2011-10-27 Chong Yidong <cyd@gnu.org>
1151
1152 * process.c (make_process): Set gnutls_state to NULL.
1153
1154 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1155 non-NULL, regardless of GNUTLS_INITSTAGE.
1156 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1157 an error. Set process slots as soon as we allocate them.
1158
1159 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1160
1161 2011-10-27 Chong Yidong <cyd@gnu.org>
1162
1163 * gnutls.c (emacs_gnutls_deinit): New function.
1164 Deallocate credentials structures as well as calling gnutls_deinit.
1165 (Fgnutls_deinit, Fgnutls_boot): Use it.
1166
1167 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1168 (deactivate_process): Call emacs_gnutls_deinit.
1169
1170 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1171
1172 * image.c (x_create_x_image_and_pixmap):
1173 * w32.c (sys_rename, w32_delayed_load):
1174 * w32font.c (fill_in_logfont):
1175 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1176
1177 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1178
1179 * w32fns.c (w32_default_color_map): New function,
1180 extracted from Fw32_default_color_map.
1181 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1182
1183 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1184
1185 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1186
1187 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1188
1189 * keyboard.c (test_undefined): New function (bug#9751).
1190 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1191
1192 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1193
1194 * sysdep.c (init_sys_modes): Fix the check for the controlling
1195 terminal (Bug#6649).
1196
1197 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1198
1199 * dispextern.h (struct bidi_it): New member next_en_type.
1200
1201 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1202 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1203 current character, check also for next_en_type being WEAK_EN.
1204 (bidi_resolve_weak): Don't enter the expensive loop if the current
1205 position is before next_en_pos. Record the bidi type of the first
1206 non-ET, non-BN character we find, in addition to its position.
1207 (bidi_level_of_next_char): Invalidate next_en_type when
1208 next_en_pos is over-stepped.
1209
1210 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1211
1212 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1213 * editfns.c: Rewrite current-time-zone so that it invokes
1214 the equivalent of (format-time-string "%Z") to get the time zone name.
1215 This fixes a bug when the time zone name contains characters that
1216 need converting from the system time locale to Emacs internal format.
1217 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1218 that patch fixed format-time-string to do the conversion, but
1219 I forgot to fix current-time-zone.
1220 (format_time_string): New function, containing most of
1221 what Fformat_time_string used to contain.
1222 (Fformat_time_string): Rewrite in terms of format_time_string.
1223 This doesn't change this function's behavior.
1224 (current-time-zone): Rewrite to use format_time_string.
1225 This fixes the bug reported by Michael Schierl in
1226 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1227 Jason Rumney's 2007-06-07 change worked around this bug, but
1228 didn't fix it.
1229 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1230
1231 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1232
1233 * xdisp.c (start_display): If the character at POS is displayed
1234 via a display vector, reset IT->current.dpvec_index to zero.
1235 (try_window_reusing_current_matrix): If a line ends in a display
1236 vector or the next line starts in a display vector, continue
1237 redrawing the window even though the character position of
1238 start_row was reached.
1239 (Bug#9771, part 2)
1240
1241 2011-10-18 Chong Yidong <cyd@gnu.org>
1242
1243 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1244 with nobreak-char-display too.
1245
1246 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1247
1248 Fix part 3 of bug#9771.
1249 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1250 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1251 non-neutral characters if the current character is a paragraph
1252 separator (a.k.a. Newline). This avoids running the same
1253 expensive loop twice, once when we consume the preceding newline
1254 and the other time when the line actually needs to be displayed.
1255 Avoid the loop when we see neutrals on the base embedding level
1256 following a character whose directionality is the same as the
1257 paragraph's. This avoids running the expensive loop when a line
1258 ends in a long sequence of neutrals, like control characters.
1259 Add assertion against STRONG_AL type. Slightly rearrange code
1260 that determines the type of a neutral given the first non-neutral
1261 that follows it.
1262 (bidi_level_of_next_char): Set next_en_pos to zero when
1263 invalidating its info.
1264
1265 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1266
1267 * xdisp.c (push_display_prop): Determine whether to record string
1268 or buffer position by IT->string, not by IT->method. Allow
1269 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1270 (move_it_vertically_backward): Don't look for character position
1271 immediately after the newline when in a continuation line.
1272 (Bug#9771, part 1)
1273
1274 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1275
1276 * window.c (coordinates_in_window): Rewrite and delabelize
1277 vertical border check. (Bug#5357) (Bug#9618)
1278
1279 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1280
1281 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1282 errors in XSetWindowBorder (bug#9310).
1283
1284 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1285
1286 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1287 avoid crash when xmalloc overrun checking is enabled.
1288
1289 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1290
1291 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1292 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1293 cursor motion with <left> and <right> arrow keys.
1294
1295 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1296 some callers set that themselves.
1297
1298 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1299
1300 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1301 display string and the previous row comes from the same string and
1302 is empty. (Bug#9739) (Bug#9738)
1303
1304 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1305
1306 * doc.c (get_doc_string): Encode file name (bug#9735).
1307
1308 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1309
1310 * bidi.c (bidi_level_of_next_char):
1311 * xdisp.c (get_visually_first_element): Remove old incorrect
1312 comments regarding the Unicode Line Separator character.
1313
1314 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1315
1316 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1317
1318 * alloc.c (Fgc_status): Do not access beyond zombies array
1319 boundary if nzombies > MAX_ZOMBIES.
1320 * alloc.c (dump_zombies): Add missing format specifier.
1321
1322 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1323
1324 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1325 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1326
1327 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1328 Some packages use them to denote characters with modifiers.
1329
1330 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1331
1332 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1333 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1334 matching a pp-number. Rename parameter var to var1.
1335
1336 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1337
1338 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1339
1340 2011-10-08 Glenn Morris <rgm@gnu.org>
1341
1342 * callint.c (Fcall_interactively): Give a more explicit error for the
1343 'c' case with a non-character input. (Bug#8479)
1344
1345 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1346
1347 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1348 lines.
1349 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1350 lines that are hscrolled on the left.
1351
1352 * dispnew.c (buffer_posn_from_coords): Account for a possible
1353 presence of header-line. (Bug#4426)
1354
1355 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1356
1357 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1358 Don't advertise functionality which we discourage or doesn't work.
1359
1360 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1361
1362 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1363 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1364 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1365 this makes Emacs dump core during garbage collection on rare
1366 occasions. sizeof is obviously inferior to offsetof here, so
1367 stick with offsetof.
1368 (GC_POINTER_ALIGNMENT): New macro.
1369 (mark_memory): Omit 3rd (offset) arg; caller changed.
1370 Don't assume EMACS_INT alignment is the same as pointer alignment.
1371
1372 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1373
1374 * keyboard.c (read_key_sequence_remapped): New var.
1375 (read_key_sequence): Compute remapping in the right buffer.
1376 (command_loop_1): Use read_key_sequence's remapping directly.
1377
1378 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1379
1380 * dired.c (file_name_completion): Don't expand file name.
1381 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1382 before checking file name handler.
1383
1384 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1385 they've been requested explicitly (bug#9591).
1386
1387 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1388
1389 * keymap.c (Fsingle_key_description): Use make_specified_string
1390 instead of build_string to build string from push_key_description.
1391 (Bug#5193)
1392
1393 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1394
1395 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1396 This fixes a Y2038 bug on 64-bit hosts.
1397 * buffer.c (reset_buffer):
1398 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1399 (Fclear_buffer_auto_save_failure):
1400 Use 0, not -1, to represent an unset failure time, since time_t
1401 might not be signed.
1402
1403 Remove dependency on glibc malloc internals.
1404 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1405 Move back here from lisp.h, but with their new implementations.
1406 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1407 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1408 * charset.c (charset_table_init): New static var.
1409 (syms_of_charset): Use it instead of xmalloc. This removes a
1410 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1411 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1412 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1413 Move back to alloc.c.
1414 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1415 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1416
1417 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1418
1419 * nsterm.m (windowDidResize): Call x_set_window_size only when
1420 ns_in_resize is true. Otherwise set pixelwidth/height and
1421 call change_frame_size (Bug#9628).
1422
1423 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1424
1425 Port --enable-checking=all to Fedora 14 x86-64.
1426 * charset.c (syms_of_charset): Also account for glibc malloc's
1427 internal overhead when calculating the initial malloc maximum.
1428
1429 Port --enable-checking=all to Fedora 14 x86.
1430 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1431 Move to lisp.h.
1432 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1433 (overrun_check_realloc, overrun_check_free):
1434 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1435 That way, xmalloc returns a properly-aligned pointer even if
1436 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1437 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1438 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1439 into account when calculating the initial malloc maximum.
1440 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1441 Move here from alloc.c, so that charset.c can use it too.
1442 Properly align; the old code wasn't right for common 32-bit hosts
1443 when configured with --enable-checking=all.
1444 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1445 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1446
1447 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1448
1449 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1450 use EDOM.
1451
1452 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1453
1454 * xdisp.c (compute_display_string_end): If there's no display
1455 string at CHARPOS, return -1.
1456
1457 * bidi.c (bidi_fetch_char): When compute_display_string_end
1458 returns a negative value, treat the character as a normal
1459 character not covered by a display string. (Bug#9624)
1460
1461 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1462
1463 * lread.c (Fread_from_string): Fix typo in docstring.
1464
1465 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1466
1467 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1468 newline, reseat the iterator instead of bidi-iterating there one
1469 character at a time. (Bug#9610)
1470 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1471 TO_CHARPOS if the bidi iterator is at base embedding level.
1472
1473 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1474
1475 * lread.c (readevalloop): Use correct code for NBSP.
1476 (read1): Likewise. (Bug#9608)
1477
1478 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1479
1480 * dbusbind.c (Fdbus_register_signal): When service is not
1481 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1482
1483 2011-09-25 Glenn Morris <rgm@gnu.org>
1484
1485 * buffer.c (truncate-lines): Doc fix.
1486
1487 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1488
1489 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1490 (Fset_window_next_buffers): Doc fix.
1491
1492 2011-09-24 Glenn Morris <rgm@gnu.org>
1493
1494 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1495
1496 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1497
1498 Fix minor problems found by static checking.
1499 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1500 * indent.c (Fvertical_motion): Fix == vs = typo.
1501
1502 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1503
1504 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1505 Default value is now t. Doc fix.
1506
1507 * indent.c (Fvertical_motion): Compute and apply the overshoot
1508 logic when moving up, not only when moving down. Fix the
1509 confusing name and values of the it_overshoot_expected variable;
1510 logic changes accordingly. (Bug#9254) (Bug#9549)
1511
1512 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1513 CHARPOS is covered by a display string which includes newlines.
1514 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1515 is covered by a display string with embedded newlines.
1516
1517 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1518
1519 * dbusbind.c (Fdbus_register_signal): Add match rule to
1520 Vdbus_registered_objects_table. (Bug#9581)
1521 (Fdbus_register_method, Vdbus_registered_objects_table):
1522 Fix docstring.
1523
1524 2011-09-24 Jim Meyering <meyering@redhat.com>
1525
1526 do not ignore write error for any output size
1527 The previous change was incomplete.
1528 While it makes emacs --batch detect the vast majority of stdout
1529 write failures, errors were still ignored whenever the output size is
1530 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1531 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1532 && echo FAIL: ignored write error
1533 FAIL: ignored write error
1534 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1535 && echo FAIL: ignored write error
1536 FAIL: ignored write error
1537 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1538
1539 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1540
1541 * emacs.c (Fkill_emacs): In noninteractive mode exit
1542 non-successfully if a write error occurred on stdout. (Bug#9574)
1543
1544 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1545
1546 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1547 the xassert test.
1548
1549 * dispextern.h (struct it): Update the comment documenting what
1550 can it->OBJECT be.
1551
1552 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1553
1554 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1555 a display string, extend search for cursor position to end of row.
1556 (find_row_edges): If the row ends in a newline from a display
1557 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1558 Handle the case of a display string with multiple newlines.
1559 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1560 non-empty line. Fixes confusing cursor motion with arrow keys at
1561 the beginning of a line that starts with whitespace.
1562
1563 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1564
1565 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1566 (bug#9493).
1567
1568 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1569
1570 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1571 boolean (Bug#9154).
1572
1573 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1574
1575 * xdisp.c (display_line): Record maximum and minimum buffer
1576 positions even if no glyphs were produced (e.g., by a zero-width
1577 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1578 buffer positions that will be removed from the glyph row because
1579 they don't fit.
1580 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1581 column is beyond frame width: don't subtract 1 "pixel" when
1582 computing width of the stretch.
1583 (reseat_at_next_visible_line_start): Undo the change made on
1584 2011-09-17 that saved paragraph information and restored it after
1585 the call to `reseat'. (Bug#9545)
1586
1587 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1588
1589 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1590 and turn window cursor on if cleared (Bug#9415).
1591
1592 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1593
1594 * search.c (boyer_moore): Take unibyte characters from pattern
1595 literally. (Bug#9458)
1596
1597 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1598
1599 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1600
1601 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1602
1603 Fix minor problem found by static checking.
1604 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1605 initialized, to pacify gcc -Wuninitialized.
1606
1607 * fileio.c: Report proper errno when syscall falls.
1608 (Finsert_file_contents): Save and restore errno,
1609 so that report_file_error outputs the correct diagnostic.
1610 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1611
1612 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1613
1614 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1615
1616 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1617
1618 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1619 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1620
1621 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1622
1623 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1624 about the current paragraph and restore it after the call to reseat.
1625
1626 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1627 (bidi_find_paragraph_start): Search back for paragraph beginning
1628 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1629 (bidi_move_to_visually_next): Only trigger paragraph-related
1630 computations when the last character is a newline or at EOB, not
1631 just any NEUTRAL_B. (Bug#9470)
1632
1633 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1634 truncated lines if point is covered by a display string. (Bug#9524)
1635
1636 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1637
1638 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1639 (cons_to_x_long): New function.
1640 (lisp_data_to_selection_data): Use it. Correct the test for
1641 short-versus-long data; it was negated. Break out of vector
1642 loop, for efficiency, when a long datum is discovered.
1643
1644 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1645
1646 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1647
1648 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1649
1650 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1651 GCC PR/17406) by declaring this function with external scope.
1652
1653 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1654
1655 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1656 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1657
1658 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1659
1660 * editfns.c (Fformat): Correctly handle text properties on "%%".
1661
1662 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1663
1664 * xterm.c (x_draw_composite_glyph_string_foreground):
1665 * w32term.c (x_draw_composite_glyph_string_foreground):
1666 * term.c (encode_terminal_code):
1667 * composite.c (composition_update_it, get_composition_id):
1668 * xdisp.c (get_next_display_element)
1669 (fill_composite_glyph_string): Add comments about special meaning
1670 of TAB characters in a composition.
1671
1672 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1673
1674 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1675 This occurs when processing a multibyte format.
1676 Problem reported by Wolfgang Jenker.
1677
1678 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1679
1680 * xdisp.c (try_cursor_movement): Only check for exact match if
1681 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1682
1683 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1684
1685 Remove unused external symbols.
1686 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1687 * xdisp.c (calc_pixel_width_or_height): Now static.
1688 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1689 * indent.c (check_display_width):
1690 * w32term.c: Fix comment to match code.
1691 * xterm.c, xterm.h (x_catching_errors): Remove.
1692
1693 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1694
1695 * xselect.c: Use signed conversions more consistently (Bug#9498).
1696 (selection_data_to_lisp_data): Assume incoming selection data are
1697 signed integers, not unsigned. This is to be consistent with
1698 outgoing selection data, which was modified to use signed integers
1699 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1700 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1701 expects long, not unsigned long.
1702
1703 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1704
1705 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1706 computation of loop end. Reported by Johan Bockgård
1707 <bojohan@gnu.org>.
1708
1709 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1710
1711 * frame.c (Fother_visible_frames_p): Function deleted.
1712
1713 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1714
1715 * indent.c (compute_motion): Process display vector front to back
1716 rather than the other way around. (Bug#2496)
1717
1718 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1719
1720 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1721
1722 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1723
1724 * minibuf.c (Fread_from_minibuffer): Doc fix.
1725
1726 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1727
1728 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1729 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1730
1731 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1732
1733 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1734 value for non-existent files.
1735
1736 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1737
1738 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1739 set its "size" to -1. This will set the modtime_size field of
1740 the corresponding buffer to -1, which is what
1741 verify-visited-file-modtime expects for files that do not exist.
1742 (Bug#9139)
1743
1744 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1745
1746 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1747 here ...
1748 * lisp.h: ... from here. push_key_description is no longer
1749 defined in keyboard.c, so its declaration should not be in
1750 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1751 logically belongs with push_key_description.
1752
1753 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1754
1755 * buffer.h: Include <sys/types.h> instead of <time.h>.
1756 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1757 Problem reported by Herbert J. Skuhra.
1758
1759 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1760
1761 * xml.c (parse_region): Make the parsing work for
1762 non-comment-starting XML files again (bug#9144).
1763
1764 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1765
1766 * image.c (gif_load): Fix calculation of bottom and right corner.
1767 (Bug#9468)
1768
1769 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1770
1771 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1772 redisplay in small windows.
1773
1774 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1775
1776 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1777
1778 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1779
1780 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1781 Operate on live windows only.
1782
1783 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1784
1785 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1786
1787 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1788
1789 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1790 only under bidi iteration.
1791
1792 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1793
1794 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1795
1796 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1797
1798 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1799 Without this fix, the command to link temacs failed due to an
1800 undefined symbol __builtin_isnan. This is because
1801 /usr/include/iso/math_c99.h #defines isnan(x) to
1802 __builtin_isnan(x), but the bundled gcc, which identifies itself
1803 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1804 a __builtin_isnan.
1805 * floatfns.c (isnan): #undef, and then #define to a clone of
1806 what's in data.c.
1807 (Fisnan): Always define, since it's always available now.
1808 (syms_of_floatfns): Always define isnan at the Lisp level.
1809
1810 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1811
1812 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1813
1814 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1815
1816 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1817 The previous code assumed that file offsets (off_t values) fit in
1818 EMACS_INT variables, which is not true on typical 32-bit hosts.
1819 The code messed up by falsely reporting buffer overflow in cases
1820 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1821 when "big" contains more than 2**29 bytes, even though this
1822 inserts just one byte and does not overflow the buffer.
1823 (Finsert_file_contents): Store file offsets as off_t
1824 values, not as EMACS_INT values. Check for overflow when
1825 converting between EMACS_INT and off_t. When checking for
1826 buffer overflow or for overlap, take the offsets into account.
1827 Don't use EMACS_INT for small values where int suffices.
1828 When checking for overlap, fix a typo: ZV was used where
1829 ZV_BYTE was intended.
1830 (Fwrite_region): Don't assume off_t fits into 'long'.
1831 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1832
1833 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1834
1835 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1836
1837 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1838
1839 sprintf-related integer and memory overflow issues (Bug#9412).
1840
1841 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1842 (esprintf, exprintf, evxprintf): New functions.
1843 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1844 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1845 (modify_event_symbol): Do not assume that the length of
1846 name_alist_or_stem is safe to alloca and fits in int.
1847 (Fexecute_extended_command): Likewise for function name and binding.
1848 (Frecursion_depth): Wrap around reliably on integer overflow.
1849 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1850 since some callers pass EMACS_INT values.
1851 (Fsingle_key_description): Don't crash if symbol name contains more
1852 than MAX_ALLOCA bytes.
1853 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1854 (get_minibuffer): Arg is now EMACS_INT, not int.
1855 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1856 (esprintf, exprintf, evxprintf): New decls.
1857 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1858
1859 * dbusbind.c (signature_cat): New function.
1860 (xd_signature, Fdbus_register_signal):
1861 Do not overrun buffer; instead, report string overflow.
1862
1863 * dispnew.c (add_window_display_history): Don't overrun buffer.
1864 Truncate instead; this is OK since it's just a log.
1865
1866 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1867 even if the time zone offset is outlandishly large.
1868 Don't mishandle offset == INT_MIN.
1869
1870 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1871 when creating daemon; the previous buffer-overflow check was incorrect.
1872
1873 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1874 which has the guts of the old verror function.
1875
1876 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1877 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1878
1879 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1880 (font_unparse_xlfd): Don't blindly alloca long strings.
1881 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1882 fits in int, when using sprintf. Use single snprintf to count
1883 length of string rather than counting it via multiple sprintfs;
1884 that's simpler and more reliable.
1885 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1886 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1887 sprintf, in case result does not fit in int.
1888
1889 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1890 (fontset_from_font): Print it.
1891
1892 * frame.c (tty_frame_count): Now printmax_t, not int.
1893 (make_terminal_frame, set_term_frame_name): Print it.
1894 (x_report_frame_params): In X, window IDs are unsigned long,
1895 not signed long, so print them as unsigned.
1896 (validate_x_resource_name): Check for implausibly long names,
1897 and don't assume name length fits in 'int'.
1898 (x_get_resource_string): Don't blindly alloca invocation name;
1899 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1900 not fit in int.
1901
1902 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1903 (xg_check_special_colors, xg_set_geometry):
1904 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1905
1906 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1907 Use esprintf, not sprintf, in case result does not fit in int.
1908
1909 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1910 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1911 it as a large positive number.
1912 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1913 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1914
1915 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1916 in case result does not fit in int.
1917
1918 * print.c (float_to_string): Detect width overflow more reliably.
1919 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1920 buffer overrun. Don't assume list length fits in 'int'. Treat
1921 print length of 0 as 0, not as infinity; to be consistent with other
1922 uses of print length in this function. Don't overflow print length
1923 index. Don't assume hash table size fits in 'long', or that
1924 vectorlike size fits in 'unsigned long'.
1925
1926 * process.c (make_process): Use printmax_t, not int, to format
1927 process-name gensyms.
1928
1929 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1930
1931 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1932 to avoid potential buffer overrun.
1933
1934 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1935 if X resource line is longer than 512 bytes.
1936
1937 * xfns.c (x_window): Make sprintf buffer a bit bigger
1938 to avoid potential buffer overrun.
1939
1940 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1941
1942 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1943
1944 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1945
1946 Integer overflow fixes for scrolling, etc.
1947 Without these, Emacs silently mishandles large integers sometimes.
1948 For example, "C-u 4294967297 M-x recenter" was treated as if
1949 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1950
1951 * xdisp.c (try_window_id): Check Emacs fixnum range before
1952 converting to 'int'.
1953
1954 * window.c (window_scroll_line_based, Frecenter):
1955 Check that an Emacs fixnum is in range before assigning it to 'int'.
1956 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1957 values converted from Emacs fixnums.
1958 (Frecenter): Don't wrap around a line count if it is out of 'int'
1959 range; instead, treat it as an extreme value.
1960 (Fset_window_configuration, compare_window_configurations):
1961 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1962
1963 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1964 that can exceed INT_MAX. Check that EMACS_INT value is in range
1965 before assigning it to the (possibly-narrower) index.
1966 (match_limit): Don't assume that a fixnum can fit in 'int'.
1967
1968 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1969 exceed INT_MAX.
1970
1971 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1972 (Fvertical_motion): Don't wrap around LINES values that don't fit
1973 in 'int'. Instead, treat them as extreme values. This is good
1974 enough for windows, which can't have more than INT_MAX lines anyway.
1975
1976 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1977
1978 * Require libxml/parser.h to avoid compilation warning.
1979
1980 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1981
1982 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1983 since this reportedly can destroy thread storage.
1984
1985 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1986
1987 * syntax.c (find_defun_start): Update all cache variables if
1988 exiting early (Bug#9401).
1989
1990 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1991
1992 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1993
1994 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1995 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1996 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1997
1998 * term.c (tty_append_glyph): New function.
1999 (produce_stretch_glyph): Static function and its prototype deleted.
2000
2001 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2002 Add prototypes.
2003
2004 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2005
2006 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2007 when checking :margin (Bug#9390).
2008 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2009 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2010 so that the name doesn't mislead. All uses changed.
2011
2012 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2013
2014 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2015 set_tty_hooks.
2016
2017 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2018
2019 * xdisp.c (move_it_to): Don't bail out early when reaching
2020 position beyond to_charpos, if we are scanning backwards.
2021 (move_it_vertically_backward): When DY == 0, make sure we get to
2022 the first character in the line after the newline.
2023
2024 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2025
2026 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2027 (ccl_driver): Do not generate an out-of-range pointer.
2028 (Fccl_execute_on_string): Remove unnecessary check for
2029 integer overflow, noted by Stefan Monnier in
2030 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2031 Remove a FIXME that didn't need fixing.
2032 Simplify the newly-introduced buffer reallocation code.
2033
2034 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2035
2036 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2037
2038 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2039
2040 Integer and memory overflow issues (Bug#9196).
2041
2042 * doc.c (get_doc_string): Rework so that
2043 get_doc_string_buffer_size is the actual buffer size, rather than
2044 being 1 less than the actual buffer size; this makes xpalloc more
2045 convenient.
2046
2047 * image.c (x_allocate_bitmap_record, cache_image):
2048 * xselect.c (Fx_register_dnd_atom):
2049 Simplify previous changes by using xpalloc.
2050
2051 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2052 since either will do and ptrdiff_t is convenient with xpalloc.
2053
2054 * charset.c (charset_table_size)
2055 (struct charset_sort_data.priority): Now ptrdiff_t.
2056 (charset_compare): Don't overflow if priorities differ greatly.
2057 (Fsort_charsets): Don't assume list length fits in int.
2058 Check for size-calculation overflow when allocating sort data.
2059 (syms_of_charset): Allocate an initial charset table that is
2060 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2061
2062 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2063
2064 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2065 The actual value is always <= INT_MAX, and leaving it unsigned made
2066 overflow checking harder.
2067
2068 * dispextern.h (struct glyph_matrix.rows_allocated)
2069 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2070 with xpalloc. The values are still always <= INT_MAX.
2071
2072 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2073
2074 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2075 (SAFE_NALLOCA): New macro.
2076
2077 * region-cache.c (struct boundary.pos, find_cache_boundary)
2078 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2079 (set_cache_region, invalidate_region_cache)
2080 (revalidate_region_cache, know_region_cache, region_cache_forward)
2081 (region_cache_backward, pp_cache):
2082 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2083 so that ptrdiff_t * can be passed to xpalloc.
2084 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2085 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2086 (pp_cache): Don't assume cache_len fits in int.
2087 * region-cache.h: Adjust extern decls to match.
2088
2089 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2090 EMACS_INT, since either will do, for xpalloc.
2091
2092 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2093 (xnmalloc, xnrealloc, xpalloc): New functions.
2094
2095 * bidi.c (bidi_shelve_header_size): New constant.
2096 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2097 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2098
2099 * bidi.c (bidi_cache_shrink):
2100 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2101 (overlay_strings):
2102 Don't update size of array until after memory allocation succeeds,
2103 because xmalloc/xrealloc may not return.
2104 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2105 now that we have proper integer overflow checking.
2106 (record_overlay_string, overlay_strings): Catch overflows when
2107 calculating size of overlay_str_buf.
2108
2109 * callproc.c (Fcall_process): Check for size overflow when
2110 calculating size of args2.
2111 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2112 Normally we prefer signed values, but sticking with ptrdiff_t would
2113 require adding more-complicated checks.
2114
2115 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2116 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2117 Redo buffer-overflow calculations to avoid integer overflow.
2118 Add a FIXME comment where memory seems to be over-allocated.
2119
2120 * character.c (Fstring): Check for size-calculation overflow.
2121
2122 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2123 unnecessary integer overflow. Check for size overflow.
2124 (encode_coding_object): Don't update size until xmalloc succeeds.
2125
2126 * composite.c (get_composition_id): Check for overflow in glyph
2127 length calculations.
2128
2129 Integer and memory overflow fixes for display code.
2130 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2131 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2132 (scrolling_window): Check for overflow in size calculations.
2133 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2134 Don't assume glyph table len fits in int.
2135 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2136 (row_table_size): Now ptrdiff_t, not int.
2137 (scrolling_window): Avoid overflow in size calculations.
2138 Don't update size until allocation succeeds.
2139 * fns.c (concat): Check for overflow in size calculations.
2140 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2141 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2142 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2143
2144 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2145 (get_doc_string): Check for size calculation overflow.
2146 Don't update size until allocation succeeds.
2147 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2148 EMACS_INT, where ptrdiff_t will do.
2149 (Fsubstitute_command_keys): Check for string overflow.
2150
2151 * editfns.c (set_time_zone_rule): Don't assume environment length
2152 fits in int.
2153 (message_length): Now ptrdiff_t, not int.
2154 (Fmessage_box): Don't update size until allocation succeeds.
2155 Don't assume message length fits in int.
2156 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2157
2158 * emacs.c (main): Do not reallocate argv, since there is a null at
2159 the end that can be overwritten, and this way there's no need to
2160 worry about size-calculation overflow.
2161 (sort_args): Check for size-calculation overflow.
2162
2163 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2164 alloc succeeds.
2165 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2166
2167 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2168 (x_set_scroll_bar_width, x_figure_window_size):
2169 Check for integer overflow.
2170 (x_set_alpha): Do not assume XINT fits in int.
2171
2172 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2173 This is for the members text_lines, text_cols, total_lines, total_cols,
2174 where the system imposes an 'int' limit.
2175
2176 * fringe.c (Fdefine_fringe_bitmap):
2177 Don't update size until alloc works.
2178
2179 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2180 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2181
2182 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2183 Check for size-calculation overflow.
2184 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2185 do, as we prefer signed integers.
2186 (id_to_widget.max_size, id_to_widget.used)
2187 (xg_store_widget_in_map, xg_remove_widget_from_map)
2188 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2189 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2190 Use and return ptrdiff_t, not int.
2191 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2192 * gtkutil.h: Change prototypes to match the above.
2193
2194 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2195 are duplicate now that they've been promoted to lisp.h.
2196 (x_allocate_bitmap_record, x_alloc_image_color)
2197 (make_image_cache, cache_image, xpm_load):
2198 Don't update size until alloc is done.
2199 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2200 (x_detect_edges):
2201 Check for size calculation overflow.
2202 (ct_colors_allocated_max): New constant.
2203 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2204 overflow.
2205
2206 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2207 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2208 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2209 Use ptrdiff_t, not int, to count maps.
2210 (read_char_minibuf_menu_prompt): Check for overflow in size
2211 calculations. Don't update size until allocation succeeds.
2212 Redo calculations to avoid overflow.
2213 * keyboard.h: Change prototypes to match the above.
2214
2215 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2216 to count maps.
2217 (current_minor_maps): Check for size calculation overflow.
2218 * keymap.h: Change prototypes to match the above.
2219
2220 * lread.c (read1, init_obarray): Don't update size until alloc done.
2221
2222 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2223 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2224
2225 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2226 Now ptrdiff_t, not int.
2227 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2228 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2229
2230 * process.c (Fnetwork_interface_list): Check for overflow
2231 in size calculation.
2232
2233 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2234
2235 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2236 overflow. Don't bother calling xmalloc when xrealloc will do.
2237
2238 * search.c (Freplace_match): Check for size calculation overflow.
2239 (Fset_match_data): Don't assume list lengths fit in 'int'.
2240
2241 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2242 for command line length. Do not attempt to address one before the
2243 beginning of an array, as that's not portable.
2244
2245 * term.c (max_frame_lines): Remove; unused.
2246 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2247 not int.
2248 (encode_terminal_code, calculate_costs): Check for size
2249 calculation overflow.
2250 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2251 table lengths and related sizes. Don't update size until alloc
2252 done. Redo calculations to avoid overflow.
2253 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2254
2255 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2256 subtracting pointers.
2257 (gobble_line): Check for overflow more carefully. Don't update size
2258 until alloc done.
2259
2260 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2261 Don't update size until alloc done.
2262 Redo size calculations to avoid overflow.
2263 Check for size calculation overflow.
2264 (main) [DEBUG]: Fix typo in invoking tparam1.
2265
2266 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2267 Use ptrdiff_t, not int, for sizes.
2268 (store_mode_line_noprop_char): Don't update size until alloc done.
2269
2270 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2271 Use ptrdiff_t, not int, for sizes.
2272 (Finternal_make_lisp_face, cache_face):
2273 Check for size calculation overflow.
2274 (cache_face): Treat size calculation overflows as if they were
2275 memory exhaustion (the usual treatment), rather than aborting.
2276
2277 * xfns.c (x_encode_text, x_set_name_internal)
2278 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2279 sizes, since they can exceed INT_MAX in size. Check for size
2280 calculation overflow.
2281
2282 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2283 (xg_select): Check for size calculation overflow.
2284 Don't update size until alloc done.
2285
2286 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2287 as sprintf is limited to int lengths.
2288
2289 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2290 (X_LONG_MIN): New macros.
2291 Use them to make the following changes clearer.
2292 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2293 This change doesn't affect the value now, but it may help remind
2294 future maintainers not to raise the value too much later.
2295 (SELECTION_QUANTUM): Remove, replacing with ...
2296 (selection_quantum): ... new function, which avoids overflow.
2297 All uses changed.
2298 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2299 assumption that selection length fits in 'int'.
2300 (x_reply_selection_request, x_handle_selection_request)
2301 (x_get_window_property, receive_incremental_selection)
2302 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2303 (lisp_data_to_selection_data, clean_local_selection_data):
2304 Use ptrdiff_t, not int, to record length of selection.
2305 (x_reply_selection_request, x_get_window_property)
2306 (receive_incremental_selection, x_property_data_to_lisp):
2307 Redo calculations to avoid overflow.
2308 (x_reply_selection_request): When sending hint, ceiling it at
2309 X_LONG_MAX rather than relying on wraparound overflow to send
2310 something.
2311 (x_get_window_property, receive_incremental_selection)
2312 (lisp_data_to_selection_data, x_property_data_to_lisp):
2313 Check for size-calculation overflow.
2314 (x_get_window_property, receive_incremental_selection)
2315 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2316 Don't store size until memory allocation succeeds.
2317 (x_get_window_property): Plug memory leak on memory exhaustion.
2318 Don't double-block input; malloc is safe here. Don't assume 2**34
2319 - 4 fits in unsigned long. Add an xassert to check
2320 XGetWindowProperty overflow. Be more careful about overflow
2321 calculations, and distinguish size from memory overflow better.
2322 (receive_incremental_selection): When tracing, don't assume
2323 unsigned int is less than INT_MAX.
2324 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2325 harmful) conversions of unsigned short to int.
2326 (lisp_data_to_selection_data): Don't assume that integers
2327 in the range -65535 through -1 fit in an X unsigned short.
2328 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2329 result parameters unless successful. Rely on cons_to_unsigned
2330 to report problems with elements; the old code wasn't right anyway.
2331 (x_check_property_data): Check for int overflow; we cannot use
2332 a wider type due to X limits.
2333 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2334
2335 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2336
2337 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2338 (x_term_init): Check for size calculation overflow.
2339 (x_color_cells): Don't store size until memory allocation succeeds.
2340 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2341 Don't assume alloca size is less than MAX_ALLOCA.
2342 (x_term_init): Don't assume length fits in int (sprintf is limited
2343 to int size).
2344
2345 Use ptrdiff_t for composition IDs.
2346 * character.c (lisp_string_width):
2347 * composite.c (composition_table_size, n_compositions)
2348 (get_composition_id, composition_gstring_from_id):
2349 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2350 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2351 * window.c (Frecenter):
2352 Use ptrdiff_t, not int, for composition IDs.
2353 * composite.c (get_composition_id): Check for integer overflow.
2354 * composite.h: Adjust prototypes to match the above changes.
2355
2356 Use ptrdiff_t for hash table indexes.
2357 * category.c (hash_get_category_set):
2358 * ccl.c (ccl_driver):
2359 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2360 * coding.c (coding_system_charset_list, detect_coding_system):
2361 * coding.h (struct coding_system.id):
2362 * composite.c (get_composition_id, gstring_lookup_cache):
2363 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2364 * image.c (xpm_get_color_table_h):
2365 * lisp.h (hash_lookup, hash_put):
2366 * minibuf.c (Ftest_completion):
2367 Use ptrdiff_t for hash table indexes, not int (which is too
2368 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2369 32-bit --with-wide-int hosts).
2370
2371 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2372 Add a FIXME comment about memory leaks.
2373 (syms_of_charset): Don't assume xmalloc returns.
2374
2375 Don't assume that stated character widths fit in int.
2376 * character.c (Fchar_width, c_string_width, lisp_string_width):
2377 * character.h (CHAR_WIDTH):
2378 * indent.c (MULTIBYTE_BYTES_WIDTH):
2379 Use sanitize_char_width to avoid undefined and/or bad behavior
2380 with outlandish widths.
2381 * character.h (sanitize_tab_width): Rename from sanitize_width,
2382 now that we have two such functions. All uses changed.
2383 (sanitize_char_width): New inline function.
2384
2385 Don't assume that tab-width fits in int.
2386 * character.h (sanitize_width): New inline function.
2387 (SANE_TAB_WIDTH): New macro.
2388 (ASCII_CHAR_WIDTH): Use it.
2389 * indent.c (sane_tab_width): Remove. All uses replaced by
2390 SANE_TAB_WIDTH (current_buffer).
2391 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2392
2393 * fileio.c: Integer overflow issues with file modes.
2394 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2395
2396 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2397 Remove unreachable code.
2398 (read_hex, load_charset_map_from_file): Check for integer overflow.
2399
2400 * xterm.c: Don't go over XClientMessageEvent limit.
2401 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2402 (x_send_scroll_bar_event): Likewise. Check that the size does not
2403 exceed limits imposed by XClientMessageEvent, as well as the usual
2404 ptrdiff_t and size_t limits.
2405
2406 * keyboard.c: Overflow, signedness and related fixes.
2407 (make_lispy_movement): Use same integer type in forward decl
2408 that is used in the definition.
2409 (read_key_sequence, keyremap_step):
2410 Change bufsize argument back to int, undoing my 2011-03-30 change.
2411 We prefer signed types, and int is wide enough here.
2412 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2413 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2414 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2415 length, not size_t. Use ptrdiff_t for index, not int.
2416 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2417 possibility of integer overflow.
2418
2419 Overflow, signedness and related fixes for images.
2420
2421 * dispextern.h (struct it.stack[0].u.image.image_id)
2422 (struct_it.image_id, struct image.id, struct image_cache.size)
2423 (struct image_cache.used, struct image_cache.ref_count):
2424 * gtkutil.c (update_frame_tool_bar):
2425 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2426 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2427 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2428 * nsmenu.m (update_frame_tool_bar):
2429 * xdisp.c (calc_pixel_width_or_height):
2430 * xfns.c (image_cache_refcount):
2431 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2432 on typical 64-bit hosts.
2433
2434 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2435 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2436 Omit unnecessary casts to int.
2437 (parse_image_spec): Check that integers fall into 'int' range
2438 when the callers expect that.
2439 (image_ascent): Redo ascent calculation to avoid int overflow.
2440 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2441 (lookup_image): Remove unnecessary tests.
2442 (xbm_image_p): Locals are now of int, not EMACS_INT,
2443 since parse_image_check makes sure they fit into int.
2444 (png_load, gif_load, svg_load_image):
2445 Prefer int to unsigned where either will do.
2446 (tiff_handler): New function, combining the cores of the
2447 old tiff_error_handler and tiff_warning_handler.
2448 This function is rewritten to use vsnprintf and thereby avoid
2449 stack buffer overflows. It uses only the features of vsnprintf
2450 that are common to both POSIX and native Microsoft.
2451 (tiff_error_handler, tiff_warning_handler): Use it.
2452 (tiff_load, gif_load, imagemagick_load_image):
2453 Don't assume :index value fits in 'int'.
2454 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2455 (imagemagick_load_image): Check that crop parameters fit into
2456 the integer types that MagickCropImage accepts. Don't assume
2457 Vimagemagick_render_type has a nonnegative value. Don't assume
2458 size_t fits in 'long'.
2459 (gs_load): Use printmax_t to print the widest integers possible.
2460 Check for integer overflow when computing image height and width.
2461
2462 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2463
2464 * xdisp.c (redisplay_window): Don't force window start if point
2465 will be invisible in the resulting window. (Bug#9324)
2466
2467 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2468
2469 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2470 the display spec is of the form `(space ...)'.
2471 (handle_display_spec): Return the value returned by
2472 handle_single_display_spec, not just 1 or zero.
2473 (handle_single_display_spec): If the display spec is of the form
2474 `(space ...)', and specifies display in the text area, return 2
2475 rather than 1.
2476 (try_cursor_movement): Check for the need to scroll more
2477 accurately, and prefer exact match for point under bidi.
2478 Don't advance `row' beyond the last row of the window.
2479
2480 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2481 into disp_prop; all users changed.
2482
2483 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2484 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2485 for the text covered by the display property.
2486
2487 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2488
2489 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2490 Change return value to nil.
2491 (Frecord_buffer): Delete unused function.
2492
2493 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2494
2495 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2496 buffers, return left-to-right.
2497 (set_cursor_from_row): Consider candidate row a win if its glyph
2498 represents a newline and point is on that newline. Fixes cursor
2499 positioning on the newline at EOL of R2L text within L2R
2500 paragraph, and vice versa.
2501 (try_cursor_movement): Check continued rows, in addition to
2502 continuation rows. Fixes unwarranted scroll when point enters a
2503 continued line of R2L text within an L2R paragraph, or vice versa.
2504 (cursor_row_p): Consider the case of point being equal to
2505 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2506 from the end of a short line to the beginning of a continued line
2507 of R2L text within L2R paragraph.
2508 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2509 composed characters.
2510
2511 * bidi.c (bidi_check_type): Use xassert.
2512 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2513 members.
2514
2515 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2516
2517 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2518 a character.
2519
2520 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2521
2522 * nsfont.m (ns_otf_to_script): Fix typo.
2523
2524 2011-08-22 Kenichi Handa <handa@m17n.org>
2525
2526 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2527 extra slot even if the purpose is char-code-property-table.
2528
2529 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2530
2531 * xdisp.c (redisplay_window): When computing centering_position,
2532 account for the height of the header line. (Bug#8874)
2533
2534 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2535 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2536 candidate is selected by the mouse, and that candidate has a
2537 composed character under the mouse.
2538
2539 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2540 coordinates reported by pos-visible-in-window-p for a composed
2541 character in column zero.
2542
2543 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2544
2545 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2546
2547 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2548
2549 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2550 consider it a hit if to_charpos is anywhere in the range of the
2551 composed buffer positions.
2552
2553 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2554
2555 * image.c (gif_load): Don't assume that each subimage has the same
2556 dimensions as the base image. Handle disposal method that is
2557 "undefined" by the gif spec (Bug#9335).
2558
2559 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2560
2561 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2562 (Fcondition_case): Document `debug' symbol in error handler.
2563
2564 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2565
2566 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2567 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2568 from an Org mode buffer to a Speedbar frame.
2569
2570 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2571 a composition, take its buffer position from IT->cmp_it.charpos.
2572 Fixes cursor positioning at the beginning of a line that begins
2573 with a composed character.
2574
2575 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2576
2577 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2578 character bidirectional type, use STRONG_L instead. Fixes crashes
2579 in a buffer produced by `describe-categories'.
2580
2581 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2582 members before the level stack, so they would be saved and
2583 restored when copying iterator state. Fixes incorrect reordering
2584 around TABs covered by display properties.
2585
2586 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2587
2588 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2589
2590 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2591
2592 * eval.c (internal_condition_case, internal_condition_case_1)
2593 (internal_condition_case_2, internal_condition_case_n):
2594 Remove unnecessary aborts (Bug#9081).
2595
2596 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2597
2598 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2599 has no `load' handler, try opening the file locally. (Bug#9311)
2600
2601 2011-08-16 Ken Brown <kbrown@cornell.edu>
2602
2603 * gmalloc.c: Expand comment.
2604
2605 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2606
2607 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2608 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2609
2610 2011-08-16 Ken Brown <kbrown@cornell.edu>
2611
2612 Fix memory allocation problems in Cygwin build (Bug#9273).
2613
2614 * unexcw.c ( __malloc_initialized): Declare external variable.
2615 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2616
2617 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2618 New variables.
2619 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2620 dumped emacs.
2621 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2622 in the static heap.
2623 [CYGWIN] (special_realloc): New function.
2624 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2625 requests to realloc storage in the static heap.
2626
2627 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2628
2629 * bidi.c (bidi_initialize): Remove unused local.
2630
2631 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2632
2633 * bidimirror.h:
2634 * biditype.h: Remove file.
2635 * makefile.w32-in ($(BLD)/bidi.$(O)):
2636 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2637
2638 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2639
2640 * chartab.c: Improve commentary for the uniprop_table API.
2641
2642 * bidi.c (bidi_paragraph_init): Support zero value of
2643 bidi_ignore_explicit_marks_for_paragraph_level.
2644 (bidi_initialize): Use uniprop_table instead of including
2645 biditype.h and bidimirror.h.
2646
2647 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2648 coordinates of the iterator when restoring from ppos_it.
2649 (Bug#9296)
2650
2651 2011-08-14 Kenichi Handa <handa@m17n.org>
2652
2653 * process.c (create_process): Call setup_process_coding_systems
2654 after the pid of the process is set to -1 (Bug#8162).
2655
2656 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2657
2658 * xdisp.c (move_it_in_display_line_to): Don't invoke
2659 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2660 ppos_it. Fixes vertical cursor motion when line beginning is
2661 covered by an image. (Bug#9296)
2662
2663 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2664
2665 * nsterm.h (ns_run_ascript): Declare.
2666 (NSAPP_DATA2_RUNASSCRIPT): Define.
2667
2668 * nsfns.m (as_script, as_result, as_status): New static variables.
2669 (ns_run_ascript): New function.
2670 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2671 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2672 the event loop. Get status from as_status (Bug#7276).
2673
2674 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2675 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2676 the event loop (Bug#7276).
2677
2678 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2679
2680 * gnutls.c (QCgnutls_bootprop_priority)
2681 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2682 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2683 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2684 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2685 (QCgnutls_bootprop_verify_hostname_error)
2686 (QCgnutls_bootprop_callbacks_verify): Rename from
2687 Qgnutls_bootprop_..., all uses changed.
2688
2689 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2690 uses changed.
2691
2692 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2693
2694 * xfaces.c (Qframe_set_background_mode): Now static.
2695 * dispextern.h (Qframe_set_background_mode): Remove decl.
2696
2697 * process.c (Fnetwork_interface_info): Declare local only if needed.
2698
2699 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2700
2701 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2702 (Fnetwork_interface_list): Allocate in increments of bytes instead
2703 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2704 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2705 sockaddr.
2706 (struct ifflag_def): notrailers is smart on OSX.
2707 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2708 Get hardware address with getifaddrs if available.
2709
2710 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2711
2712 * xdisp.c (iterate_out_of_display_property): xassert that
2713 IT->position is set to within IT->object's boundaries. Break from
2714 the loop as soon as EOB is reached; avoids infloops in redisplay
2715 when IT->position is set up wrongly due to some bug.
2716 Set IT->current to match the bidi iterator unconditionally.
2717 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2718 entry. Force push_it to save on the stack the current
2719 buffer/string position, to be restored by pop_it. Fix flags in
2720 the iterator structure wrt the object coming from a display
2721 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2722 properties. (Bug#9284)
2723
2724 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2725
2726 * fontset.c (fontset_get_font_group): Add proper type checks.
2727 (Bug#9172)
2728
2729 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2730
2731 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2732 and LC_VERSION_MIN_MACOSX.
2733 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2734 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2735
2736 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2737
2738 * xdisp.c (forward_to_next_line_start): Allow to use the
2739 no-display-properties-and-no-overlays under bidi display.
2740 Set disp_pos in the bidi iterator to avoid searches for display
2741 properties and overlays.
2742
2743 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2744
2745 * editfns.c (Fset_time_zone_rule): Document relationship with the
2746 setenv function.
2747
2748 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2749 the font entity extracted from the cache (Bug#8109).
2750
2751 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2752
2753 * composite.c (autocmp_chars): Don't reset point. That is done by
2754 restore_point_unwind (Bug#5984).
2755
2756 2011-08-07 Juri Linkov <juri@jurta.org>
2757
2758 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2759 to show the arg `TIME' instead of `TIMEVAL'.
2760
2761 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2762
2763 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2764 display property strides EOL and includes a newline, as in
2765 longlines-mode. (Bug#9254)
2766 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2767 word-wrap under bidirectional display. (Bug#9224)
2768
2769 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2770 is non-zero, even if the data buffer is NULL. Fixes a crash in
2771 vertical-motion with longlines-mode. (Bug#9254)
2772
2773 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2774
2775 * bidi.c <bidi_cache_total_alloc>: Now static.
2776 (bidi_initialize): Initialize bidi_cache_total_alloc.
2777
2778 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2779 cache. (Bug#9221)
2780
2781 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2782 amount allocated this far in `bidi_cache_total_alloc'.
2783 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2784 non-zero, only free the data buffer without restoring the cache
2785 contents. All callers changed.
2786
2787 * dispextern.h (bidi_unshelve_cache): Update prototype.
2788
2789 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2790 (move_it_in_display_line, move_it_to)
2791 (move_it_vertically_backward, move_it_by_lines): Replace the call
2792 to xfree to an equivalent call to bidi_unshelve_cache.
2793 (move_it_in_display_line_to): Fix logic of returning
2794 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2795
2796 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2797
2798 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2799 came from a string character with a `cursor' property. (Bug#9229)
2800
2801 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2802
2803 * Makefile.in (LIB_PTHREAD): New variable.
2804 (LIBES): Add LIB_PTHREAD (Bug#9216).
2805
2806 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2807 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2808
2809 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2810
2811 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2812
2813 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2814
2815 * xterm.c (x_find_topmost_parent): New function.
2816 (x_set_frame_alpha): Find topmost parent window with
2817 x_find_topmost_parent and set the property there also (bug#9181).
2818 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2819
2820 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2821
2822 * callproc.c (Fcall_process): Avoid vfork clobbering
2823 the local vars buffer, coding_systems, current_dir.
2824
2825 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2826
2827 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2828
2829 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2830
2831 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2832 so that it is not optimized away.
2833
2834 * xdisp.c (compute_display_string_pos): Remove unused local.
2835
2836 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2837
2838 Fix slow cursor motion and scrolling in large buffers with
2839 selective display, like Org Mode buffers. (Bug#9218)
2840
2841 * dispextern.h (struct bidi_it): New member disp_prop_p.
2842
2843 * xdisp.c: Remove one-slot cache of display string positions.
2844 (compute_display_string_pos): Accept an additional argument
2845 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2846 for a display string or property. If found, set DISP_PROP_P
2847 non-zero.
2848
2849 * bidi.c (bidi_fetch_char): Accept an additional argument
2850 DISP_PROP_P, and pass it to compute_display_string_pos.
2851 Only handle text covered by a display string if DISP_PROP_P is returned
2852 non-zero. All callers of bidi_fetch_char changed.
2853
2854 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2855
2856 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2857
2858 2010-12-03 Don March <don@ohspite.net>
2859
2860 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2861 last character M-[char] is translated to ESC [char] (bug#7541).
2862
2863 2011-08-02 Kenichi Handa <handa@m17n.org>
2864
2865 * lisp.h (uniprop_table): Extern it.
2866
2867 * chartab.c (uniprop_table): Make it non-static.
2868
2869 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2870
2871 * xdisp.c (forward_to_next_line_start): Accept additional argument
2872 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2873 on the newline.
2874 (reseat_at_next_visible_line_start): Use the bidi iterator state
2875 returned by forward_to_next_line_start to restore the state of
2876 it->bidi_it after backing up to previous newline. (Bug#9212)
2877
2878 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2879
2880 * regex.c (re_comp): Protoize.
2881 (re_exec): Fix return type.
2882 (regexec): Fix type of `ret'. (Bug#9203)
2883
2884 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2885
2886 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2887 This is needed if max-image-size is a floating-point number.
2888
2889 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2890
2891 * print.c (print_object): Print empty symbol as ##.
2892
2893 * lread.c (read1): Read ## as empty symbol.
2894
2895 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2896
2897 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2898 setting frame foreground color (Bug#9175).
2899 (x_set_background_color): Likewise.
2900
2901 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2902 contents (Bug#9176).
2903 (EmacsTooltip -init): Remove bezels and add shadows to
2904 tooltip windows.
2905
2906 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2907 or scroll bar (Bug#8470).
2908
2909 * nsfont.m (nsfont_open): Remove assignment to voffset and
2910 unnecessary vars hshink, expand, hd, full_height, min_height.
2911 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2912
2913 * nsterm.h (nsfont_info): Remove voffset field.
2914
2915 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2916
2917 Implement strike-through and overline on NextStep (Bug#8863).
2918
2919 * nsfont.m (nsfont_open): Use underline position provided by font,
2920 instead of hard-coded value of 2.
2921 (nsfont_draw): Call ns_draw_text_decoration instead.
2922
2923 * nsterm.h: Add declaration for ns_draw_text_decoration.
2924
2925 * nsterm.m (ns_draw_text_decoration): New function for drawing
2926 underline, overline, and strike-through.
2927 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2928 ns_draw_text_decoration. Change treatment of cursor drawing to
2929 accommodate underlining, etc.
2930
2931 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2932
2933 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2934 default.
2935
2936 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2937
2938 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2939 Without this fix, if a signal arrives just after memory fills up,
2940 'malloc' might be invoked reentrantly.
2941
2942 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2943 In other words, assume that every image size is allowed, on non-X
2944 hosts. This assumption is probably wrong, but it lets Emacs compile.
2945
2946 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2947
2948 * regex.c (re_iswctype): Convert return values to boolean.
2949
2950 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2951
2952 * xdisp.c (compute_display_string_pos): Don't use cached display
2953 string position if the buffer had its restriction changed.
2954 (Bug#9184)
2955
2956 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2957
2958 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2959
2960 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2961
2962 Integer signedness and overflow and related fixes. (Bug#9079)
2963
2964 * bidi.c: Integer size and overflow fixes.
2965 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2966 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2967 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2968 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2969 (bidi_find_other_level_edge):
2970 Use ptrdiff_t instead of EMACS_INT where either will do.
2971 This works better on 32-bit hosts configured --with-wide-int.
2972 (bidi_cache_ensure_space): Check for size-calculation overflow.
2973 Use % rather than repeated addition, for better worst-case speed.
2974 Don't set bidi_cache_size until after xrealloc returns, because it
2975 might not return.
2976 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2977 (bidi_cache_ensure_space): Also check that the bidi cache size
2978 does not exceed that of the largest Lisp string or buffer. See Eli
2979 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2980
2981 * alloc.c (__malloc_size_t): Remove.
2982 All uses replaced by size_t. See Andreas Schwab's note
2983 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2984
2985 * image.c: Improve checking for integer overflow.
2986 (check_image_size): Assume that f is nonnull, since
2987 it is always nonnull in practice. This is one less thing to
2988 worry about when checking for integer overflow later.
2989 (x_check_image_size): New function, which checks for integer
2990 overflow issues inside X.
2991 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2992 This removes the need for a memory_full check.
2993 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2994 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2995 (xbm_read_bitmap_data): Change locals back to 'int', since
2996 their values must fit in 'int'.
2997 (xpm_load_image, png_load, tiff_load):
2998 Invoke x_create_x_image_and_pixmap earlier,
2999 to avoid much needless work if the image is too large.
3000 (tiff_load): Treat overly large images as if
3001 x_create_x_image_and_pixmap failed, not as malloc failures.
3002 (gs_load): Use x_check_image_size.
3003
3004 * gtkutil.c: Omit integer casts.
3005 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3006 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3007
3008 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3009
3010 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3011 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3012 would wrongly return t on a 64-bit host.
3013
3014 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3015 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3016 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3017 and therefore cause GCC to emit a bogus diagnostic in some cases.
3018
3019 * image.c: Integer signedness and overflow and related fixes.
3020 This is not an exhaustive set of fixes, but it's time to
3021 record what I've got.
3022 (lookup_pixel_color, check_image_size): Remove redundant decls.
3023 (check_image_size): Don't assume that arbitrary EMACS_INT values
3024 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3025 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3026 (tiff_load, imagemagick_load_image):
3027 Check for overflow in size calculations.
3028 (x_create_x_image_and_pixmap): Remove unnecessary test for
3029 xmalloc returning NULL; that can't happen.
3030 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3031 (xpm_color_bucket): Use better integer hashing function.
3032 (xpm_cache_color): Don't possibly over-allocate memory.
3033 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3034 (gif_memory_source):
3035 Use ptrdiff_t, not int or size_t, to record sizes.
3036 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3037 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3038 either works, as we prefer signed integers.
3039 (tiff_read_from_memory, tiff_write_from_memory):
3040 Return tsize_t, not size_t, since that's what the TIFF API wants.
3041 (tiff_read_from_memory): Don't fail simply because the read would
3042 go past EOF; instead, return a short read.
3043 (tiff_load): Omit no-longer-needed casts.
3044 (Fimagemagick_types): Don't assume size fits into 'int'.
3045
3046 Improve hashing quality when configured --with-wide-int.
3047 * fns.c (hash_string): New function, taken from sxhash_string.
3048 Do not discard information about ASCII character case; this
3049 discarding is no longer needed.
3050 (sxhash-string): Use it. Change sig to match it. Caller changed.
3051 * lisp.h: Declare it.
3052 * lread.c (hash_string): Remove, since we now use fns.c's version.
3053 The fns.c version returns a wider integer if --with-wide-int is
3054 specified, so this should help the quality of the hashing a bit.
3055
3056 * emacs.c: Integer overflow minor fix.
3057 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3058 Define only if GNU_LINUX.
3059 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3060
3061 * dispnew.c: Integer signedness and overflow fixes.
3062 Remove unnecessary forward decls, that were a maintenance hassle.
3063 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3064 All uses changed.
3065 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3066 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3067 (prepare_desired_row, line_draw_cost):
3068 Use int, not unsigned, where either works.
3069 (save_current_matrix, restore_current_matrix):
3070 Use ptrdiff_t, not size_t, where either works.
3071 (init_display): Check for overflow more accurately, and without
3072 relying on undefined behavior.
3073
3074 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3075 Remove, replacing with the new symbols in lisp.h. All uses changed.
3076 * fileio.c (make_temp_name):
3077 * filelock.c (lock_file_1, lock_file):
3078 * xdisp.c (message_dolog):
3079 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3080 Use pMd etc. instead.
3081 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3082 replacing the pWIDE etc. symbols removed from editfns.c.
3083
3084 * keyboard.h (num_input_events): Now uintmax_t.
3085 This is (very slightly) less likely to mess up due to wraparound.
3086 All uses changed.
3087
3088 * buffer.c: Integer signedness fixes.
3089 (alloc_buffer_text, enlarge_buffer_text):
3090 Use ptrdiff_t rather than size_t when either will do, as we prefer
3091 signed integers.
3092
3093 * alloc.c: Integer signedness and overflow fixes.
3094 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3095 (__malloc_size_t): Default to size_t, not to int.
3096 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3097 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3098 Prefer ptrdiff_t to size_t when either would do, as we prefer
3099 signed integers.
3100 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3101 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3102 Now const. Initialize with values that are in range even if char
3103 is signed.
3104 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3105 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3106 These functions do the right thing with sizes > 2**32.
3107 (check_depth): Now ptrdiff_t, not int.
3108 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3109 Adjust to new way of storing sizes. Check for size overflow bugs
3110 in rest of code.
3111 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3112 slightly wrong anyway, as it missed one instance of
3113 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3114 (refill_memory_reserve): Omit needless cast to size_t.
3115 (mark_object_loop_halt): Mark as externally visible.
3116
3117 * xselect.c: Integer signedness and overflow fixes.
3118 (Fx_register_dnd_atom, x_handle_dnd_message):
3119 Use ptrdiff_t, not size_t, since we prefer signed.
3120 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3121 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3122 x_dnd_atoms_size and x_dnd_atoms_length.
3123
3124 * doprnt.c: Prefer signed to unsigned when either works.
3125 * eval.c (verror):
3126 * doprnt.c (doprnt):
3127 * lisp.h (doprnt):
3128 * xdisp.c (vmessage):
3129 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3130 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3131 prefer signed arithmetic to avoid comparison confusion.
3132 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3133 but is a bit tricky.
3134
3135 Assume freestanding C89 headers, string.h, stdlib.h.
3136 * data.c, doprnt.c, floatfns.c, print.c:
3137 Include float.h unconditionally.
3138 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3139 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3140 * regex.c: Likewise for stddef.h, string.h.
3141 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3142 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3143 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3144 (STDC_HEADERS): Remove obsolete defines.
3145 * sysdep.c: Include limits.h unconditionally.
3146
3147 Assume support for memcmp, memcpy, memmove, memset.
3148 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3149 * regex.c (memcmp, memcpy):
3150 Remove; we assume C89 now.
3151
3152 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3153 (__malloc_safe_bcopy): Remove; no longer needed.
3154
3155 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3156 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3157 well either way, and we prefer signed to unsigned.
3158
3159 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3160
3161 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3162 closes the connection while we're reading (bug#9182).
3163
3164 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3165
3166 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3167 are specified (Bug#9168).
3168
3169 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3170
3171 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3172 Found by GCC static checking and --with-wide-int on a 32-bit host.
3173
3174 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3175
3176 * xdisp.c (compute_display_string_pos): Fix logic of caching
3177 previous display string position. Initialize cached_prev_pos to
3178 -1. Fixes slow-down at the beginning of a buffer.
3179
3180 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3181
3182 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3183 for attrs[LFACE_FONTSET_INDEX].
3184
3185 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3186
3187 * xml.c (parse_region): Remove unused local
3188 that was recently introduced.
3189
3190 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3191
3192 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3193 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3194
3195 * xdisp.c (move_it_in_display_line_to): Record the best matching
3196 position for TO_CHARPOS while scanning the line, and restore it on
3197 exit if none of the characters scanned was an exact match.
3198 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3199 when exact match is impossible due to invisible text, and the
3200 lines are truncated.
3201
3202 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3203
3204 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3205 for OSX >= 10.7.
3206
3207 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3208
3209 Fix a significant slow-down of cursor motion with C-n, C-p,
3210 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3211 auto-repeat under bidi redisplay in fontified buffers.
3212 * xdisp.c (compute_stop_pos_backwards): New function.
3213 (next_element_from_buffer): Call compute_stop_pos_backwards to
3214 find a suitable prev_stop when we find ourselves before
3215 base_level_stop.
3216 (reseat): Don't look for prev_stop, as that could mean a very long
3217 run.
3218 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3219 <cached_disp_overlay_modiff>: Cache for last found display string
3220 position.
3221 (compute_display_string_pos): Return the cached position if asked
3222 about the same buffer in the same area of character positions, and
3223 the buffer wasn't changed since the time the display string
3224 position was cached.
3225
3226 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3227
3228 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3229 is an integer, which is important for empty lines. (Bug#9149)
3230
3231 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3232
3233 * frame.c (Fmodify_frame_parameters): In tty case, update the
3234 default face if necessary (Bug#4238).
3235
3236 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3237
3238 * editfns.c (Fstring_to_char): No need to explain what a character
3239 is in the docstring (Bug#6576).
3240
3241 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3242
3243 * xml.c (parse_region): Make sure we always return a tree.
3244
3245 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3246
3247 * xml.c (parse_region): If a document contains only comments,
3248 return that, too.
3249
3250 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3251
3252 * xml.c (make_dom): Return comments, too.
3253
3254 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3255
3256 Port to OpenBSD.
3257 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3258 and the surrounding thread.
3259 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3260 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3261 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3262 timer goes off.
3263 * s/openbsd.h (BROKEN_SIGIO): Define.
3264 * unexelf.c (unexec) [__OpenBSD__]:
3265 Don't update the .mdebug section of the Alpha COFF symbol table.
3266
3267 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3268
3269 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3270 (bug#8460).
3271
3272 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3273
3274 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3275 This fixes some race conditions on the permissions of any newly
3276 created file.
3277
3278 * alloc.c (valid_pointer_p): Use pipe, not open.
3279 This fixes some permissions issues when debugging.
3280
3281 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3282 If fchown fails to set both uid and gid, try to set just gid,
3283 as that is sometimes allowed. Adjust the file's mode to eliminate
3284 setuid or setgid bits that are inappropriate if fchown fails.
3285
3286 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3287
3288 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3289 to compare Lisp_Objects.
3290 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3291 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3292 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3293
3294 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3295
3296 * lread.c (read_integer): Unread even EOF character.
3297 (read1): Likewise. Properly record start position of symbol.
3298
3299 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3300 symbol character follows.
3301
3302 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3303
3304 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3305 This works around a problem with the previous change to Fcopy_file.
3306 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3307 and without this change, GCC might complain about discarding
3308 fchown's return value.
3309
3310 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3311
3312 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3313
3314 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3315
3316 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3317
3318 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3319
3320 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3321 it's used from the C level.
3322
3323 * process.c: Use the same condition for POLL_FOR_INPUT in both
3324 keyboard.c and process.c (bug#1858).
3325
3326 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3327
3328 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3329 (Fgnutls_boot): Use it.
3330
3331 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3332
3333 * doc.c (Fsubstitute_command_keys): Revert last change.
3334
3335 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3336
3337 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3338 quotes the next character, and doesn't affect other longer
3339 sequences (bug#8935).
3340
3341 * lread.c (syms_of_lread): Clarify that is isn't only
3342 `eval-buffer' and `eval-defun' that's affected by
3343 `lexical-binding' (bug#8460).
3344
3345 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3346
3347 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3348 bidi redisplay when a line includes both an image and is truncated.
3349
3350 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3351
3352 Fix minor problems found by static checking.
3353 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3354 (elsz): Now a signed constant, not a size_t var. We prefer signed
3355 types to unsigned, to avoid integer comparison confusion. Without
3356 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3357 "cannot optimize loop, the loop counter may overflow", a symptom
3358 of the confusion.
3359 * indent.c (Fvertical_motion): Mark locals as initialized.
3360 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3361
3362 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3363
3364 * search.c (Fre_search_backward): Mention `case-fold-search' in
3365 all the re_search_* functions (bug#8138).
3366
3367 * keyboard.c (Fopen_dribble_file): Document when the file is
3368 closed (bug#8056).
3369
3370 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3371
3372 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3373 bidi_cache_idx.
3374
3375 Support bidi reordering of display and overlay strings.
3376 * xdisp.c (compute_display_string_pos)
3377 (compute_display_string_end): Accept additional argument STRING.
3378 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3379 (reseat_to_string): Initialize bidi_it->string.s and
3380 bidi_it->string.schars.
3381 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3382 NULL (avoids a crash in bidi_paragraph_init).
3383 Initialize itb.string.lstring.
3384 (init_iterator): Call bidi_init_it only of a valid
3385 buffer position was specified. Initialize paragraph_embedding to
3386 L2R.
3387 (reseat_to_string): Initialize the bidi iterator.
3388 (display_string): If we need to ignore text properties of
3389 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3390 original value of -1 will not work with bidi.)
3391 (compute_display_string_pos): First arg is now struct
3392 `text_pos *'; all callers changed. Support display properties on
3393 Lisp strings.
3394 (compute_display_string_end): Support display properties on Lisp
3395 strings.
3396 (init_iterator, reseat_1, reseat_to_string): Initialize the
3397 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3398 when iterating on a string not from display properties).
3399 (compute_display_string_pos, compute_display_string_end):
3400 Fix calculation of the object to scan. Fixes an error when using
3401 arrow keys.
3402 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3403 base_level_stop; instead, set base_level_stop to BEGV.
3404 Fixes crashes in vertical-motion.
3405 (next_element_from_buffer): Improve commentary for when
3406 the iterator is before prev_stop.
3407 (init_iterator): Initialize bidi_p from the default value of
3408 bidi-display-reordering, not from buffer-local value. Use the
3409 buffer-local value only if initializing for buffer iteration.
3410 (handle_invisible_prop): Support invisible properties on strings
3411 that are being bidi-reordered.
3412 (set_iterator_to_next): Support bidi reordering of C strings and
3413 Lisp strings.
3414 (next_element_from_string): Support bidi reordering of Lisp
3415 strings.
3416 (handle_stop_backwards): Support Lisp strings as well.
3417 (display_string): Support display of R2L glyph rows.
3418 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3419 (init_iterator): Don't initialize it->bidi_p for strings
3420 here.
3421 (reseat_to_string): Initialize it->bidi_p for strings here.
3422 (next_element_from_string, next_element_from_c_string)
3423 (next_element_from_buffer): Add xassert's for correspondence
3424 between IT's object being iterated and it->bidi_it.string
3425 structure.
3426 (face_before_or_after_it_pos): Support bidi iteration.
3427 (next_element_from_c_string): Handle the case of the first string
3428 character that is not the first one in the visual order.
3429 (get_visually_first_element): New function, refactored from common
3430 parts of next_element_from_buffer, next_element_from_string, and
3431 next_element_from_c_string.
3432 (tool_bar_lines_needed, redisplay_tool_bar)
3433 (display_menu_bar): Force left-to-right direction. Add a FIXME
3434 comment for making that be controlled by a user option.
3435 (push_it, pop_it): Save and restore the state of the
3436 bidi iterator. Save and restore the bidi_p flag.
3437 (pop_it): Iterate out of display property for string iteration as
3438 well.
3439 (iterate_out_of_display_property): Support iteration over strings.
3440 (handle_single_display_spec): Set up it->bidi_it for iteration
3441 over a display string, and call bidi_init_it.
3442 (handle_single_display_spec, next_overlay_string)
3443 (get_overlay_strings_1, push_display_prop): Set up the bidi
3444 iterator for displaying display or overlay strings.
3445 (forward_to_next_line_start): Don't use the shortcut if
3446 bidi-iterating.
3447 (back_to_previous_visible_line_start): If handle_display_prop
3448 pushed the iterator stack, restore the internal state of the bidi
3449 iterator by calling bidi_pop_it same number of times.
3450 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3451 and we are bidi-iterating, don't decrement the iterator position;
3452 instead, set the first_elt flag in the bidi iterator, to produce
3453 the same effect.
3454 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3455 (push_display_prop): xassert that we are iterating a buffer.
3456 (push_it, pop_it): Save and restore paragraph_embedding member.
3457 (handle_single_display_spec, next_overlay_string)
3458 (get_overlay_strings_1, reseat_1, reseat_to_string)
3459 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3460 correctly. Don't assume unibyte strings are not bidi-reordered.
3461 (compute_display_string_pos)
3462 (compute_display_string_end): Fix handling the case of C string.
3463 (push_it, pop_it): Save and restore from_disp_prop_p.
3464 (handle_single_display_spec, push_display_prop): Set the
3465 from_disp_prop_p flag.
3466 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3467 (pop_it): Call iterate_out_of_display_property only if we are
3468 popping after iteration over a string that came from a display
3469 property. Fix a typo in popping stretch info. Add an assertion
3470 for verifying that the iterator position is in sync with the bidi
3471 iterator.
3472 (handle_single_display_spec, get_overlay_strings_1)
3473 (push_display_prop): Fix initialization of paragraph direction for
3474 string when that of the parent object is not yet determined.
3475 (reseat_1): Call bidi_init_it to resync the bidi
3476 iterator with IT's position. (Bug#7616)
3477 (find_row_edges): If ROW->start.pos gives position
3478 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3479 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3480 Reset the from_disp_prop_p flag.
3481 (SAVE_IT, RESTORE_IT): New macros.
3482 (pos_visible_p, face_before_or_after_it_pos)
3483 (back_to_previous_visible_line_start)
3484 (move_it_in_display_line_to, move_it_in_display_line)
3485 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3486 (try_scrolling, redisplay_window, display_line): Use them when
3487 saving a temporary copy of the iterator and restoring it back.
3488 (back_to_previous_visible_line_start, reseat_1)
3489 (init_iterator): Empty the bidi cache "stack".
3490 (move_it_in_display_line_to): If iterator ended up at
3491 EOL, but we never saw any buffer positions smaller than
3492 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3493 motion in bidi-reordered lines.
3494 (move_it_in_display_line_to): Record prev_method and prev_pos
3495 immediately before the call to set_iterator_to_next. Fixes cursor
3496 motion in bidi-reordered lines with stretch glyphs and strings
3497 displayed in margins. (Bug#8133) (Bug#8867)
3498 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3499 TO_CHARPOS.
3500 (pos_visible_p): Support positions in bidi-reordered lines.
3501 Save and restore bidi cache.
3502
3503 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3504 (bidi_paragraph_info): Delete unused struct.
3505 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3506 (bidi_cache_start): New variable.
3507 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3508 to zero.
3509 (bidi_cache_fetch_state, bidi_cache_search)
3510 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3511 (bidi_cache_find, bidi_peek_at_next_level)
3512 (bidi_level_of_next_char, bidi_find_other_level_edge)
3513 (bidi_move_to_visually_next): Compare cache index with
3514 bidi_cache_start rather than with zero.
3515 (bidi_fetch_char): Accept new argument STRING; all callers
3516 changed. Support iteration over a string. Support strings with
3517 display properties. Support unibyte strings. Fix the type of
3518 `len' according to what STRING_CHAR_AND_LENGTH expects.
3519 (bidi_paragraph_init, bidi_resolve_explicit_1)
3520 (bidi_resolve_explicit, bidi_resolve_weak)
3521 (bidi_level_of_next_char, bidi_move_to_visually_next):
3522 Support iteration over a string.
3523 (bidi_set_sor_type, bidi_resolve_explicit_1)
3524 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3525 can now be zero (for strings); special values 0 and -1 were
3526 changed to -1 and -2, respectively.
3527 (bidi_char_at_pos): New function.
3528 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3529 Call it instead of FETCH_MULTIBYTE_CHAR.
3530 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3531 initialized to valid values.
3532 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3533 values.
3534 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3535 the test for valid cached positions. Fix the logic for looking up
3536 the sentinel state in the cache. GCPRO the Lisp string we are
3537 iterating.
3538 (bidi_push_it, bidi_pop_it): New functions.
3539 (bidi_initialize): Initialize the bidi cache start stack pointer.
3540 (bidi_cache_ensure_space): New function, refactored from part of
3541 bidi_cache_iterator_state. Don't assume the required size is just
3542 one BIDI_CACHE_CHUNK away.
3543 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3544 (bidi_count_bytes, bidi_char_at_pos): New functions.
3545 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3546 always valid if bidi_cache_idx is valid.
3547 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3548 is valid if it's going to be used.
3549 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3550 (bidi_cache_fetch_state, bidi_cache_search)
3551 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3552 (bidi_cache_iterator_state, bidi_cache_find)
3553 (bidi_find_other_level_edge, bidi_cache_start_stack):
3554 All variables related to cache indices are now EMACS_INT.
3555
3556 * dispextern.h (struct bidi_string_data): New structure.
3557 (struct bidi_it): New member `string'. Make flag members be 1-bit
3558 fields, and put them last in the struct.
3559 (compute_display_string_pos, compute_display_string_end):
3560 Update prototypes.
3561 (bidi_push_it, bidi_pop_it): Add prototypes.
3562 (struct iterator_stack_entry): New members bidi_p,
3563 paragraph_embedding, and from_disp_prop_p.
3564 (struct it): Member bidi_p is now a bit field 1 bit wide.
3565 (bidi_shelve_cache, bidi_unshelve_cache):
3566 Declare prototypes.
3567
3568 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3569 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3570 and vector-like objects.
3571
3572 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3573 cache around display iteration.
3574
3575 * window.c (Fwindow_end, window_scroll_pixel_based)
3576 (displayed_window_lines, Frecenter): Save and restore the bidi
3577 cache around display iteration.
3578
3579 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3580
3581 * editfns.c (Fdelete_region): Clarify the use of the named
3582 parameters (bug#6788).
3583
3584 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3585
3586 * indent.c (Fvertical_motion): Set and restore w->pointm when
3587 saving and restoring the window's buffer (Bug#9006).
3588
3589 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3590
3591 * editfns.c (Fstring_to_char): Clarify just what is returned
3592 (bug#6576). Text by Eli Zaretskii.
3593
3594 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3595
3596 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3597
3598 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3599
3600 * buffer.c (mmap_find): Fix a typo.
3601
3602 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3603
3604 Fix execution of x selection hooks.
3605 * xselect.c (Qx_lost_selection_functions)
3606 (Qx_sent_selection_functions): New vars.
3607 (syms_of_xselect): DEFSYM them.
3608 (x_handle_selection_request): Pass Qx_sent_selection_functions
3609 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3610 (x_handle_selection_clear,x_clear_frame_selections):
3611 Pass Qx_lost_selection_functions rather than
3612 Vx_lost_selection_functions to Frun_hook_with_args.
3613
3614 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3615
3616 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3617 The old code sometimes used this field without initializing it.
3618
3619 * alloc.c (gc_sweep): Don't read past end of array.
3620 In theory, the old code could also have corrupted Emacs internals,
3621 though it'd be very unlikely.
3622
3623 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3624
3625 * character.c (Fcharacterp): Don't advertise optional ignored
3626 argument. (Bug#4026)
3627
3628 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3629
3630 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3631 key" (bug#4257).
3632
3633 * window.c (Fset_window_start): Doc fix (bug#4199).
3634 (Fset_window_hscroll): Ditto.
3635
3636 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3637
3638 Fix minor new problems caught by GCC 4.6.1.
3639 * term.c (init_tty): Remove unused local.
3640 * xsettings.c (store_monospaced_changed): Define this function only
3641 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3642 not used otherwise.
3643
3644 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3645
3646 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3647
3648 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3649
3650 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3651 are the mini-buffer and the echo area (bug#3320).
3652
3653 * term.c (init_tty): Remove support for supdup, c10 and perq
3654 terminals, which are no longer supported (bug#1482).
3655
3656 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3657
3658 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3659
3660 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3661
3662 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3663 for non-popups (Bug#3642).
3664
3665 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3666
3667 * alloc.c (reset_malloc_hooks): Protoize.
3668 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3669 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3670 * cm.c (losecursor): Likewise.
3671 * data.c (fmod): Likewise.
3672 * dispnew.c (swap_glyphs_in_rows): Likewise.
3673 * emacs.c (memory_warning_signal): Likewise.
3674 * floatfns.c (float_error): Likewise.
3675 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3676 (otf_open, font_otf_capability, generate_otf_features)
3677 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3678 Likewise.
3679 * image.c (pbm_read_file): Likewise.
3680 * indent.c (string_display_width): Likewise.
3681 * intervals.c (check_for_interval, search_for_interval)
3682 (inc_interval_count, count_intervals, root_interval)
3683 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3684 * lread.c (defalias): Likewise.
3685 * ralloc.c (r_alloc_check): Likewise.
3686 * regex.c (set_image_of_range_1, set_image_of_range)
3687 (regex_grow_registers): Likewise.
3688 * sysdep.c (strerror): Likewise.
3689 * termcap.c (valid_filename_p, tprint, main): Likewise.
3690 * tparam.c (main): Likewise.
3691 * unexhp9k800.c (run_time_remap, save_data_space)
3692 (update_file_ptrs, read_header, write_header, calculate_checksum)
3693 (copy_file, copy_rest, display_header): Likewise.
3694 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3695 Likewise.
3696 * xdisp.c (check_it): Likewise.
3697 * xfaces.c (register_color, unregister_color, unregister_colors):
3698 Likewise.
3699 * xfns.c (print_fontset_result): Likewise.
3700 * xrdb.c (member, fatal, main): Likewise.
3701
3702 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3703
3704 Fix minor problems found by static checking (Bug#9031).
3705 * chartab.c (char_table_set_range, map_sub_char_table):
3706 Remove unused locals.
3707 (uniprop_table): Now static.
3708 * composite.c (_work_char): Remove unused static var.
3709
3710 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3711
3712 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3713
3714 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3715
3716 * gtkutil.c (qttip_cb): Remove code without function.
3717
3718 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3719
3720 * w32.c (pthread_sigmask): New stub.
3721
3722 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3723
3724 Use pthread_sigmask, not sigprocmask (Bug#9010).
3725 sigprocmask is portable only for single-threaded applications, and
3726 Emacs can be multi-threaded when it uses GTK.
3727 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3728 (LIBES): Use it.
3729 * callproc.c (Fcall_process):
3730 * process.c (create_process):
3731 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3732 Use pthread_sigmask, not sigprocmask.
3733
3734 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3735
3736 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3737 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3738 wrong (Bug#8591).
3739
3740 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3741
3742 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3743 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3744 (xg_hide_tooltip): Fix comment.
3745
3746 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3747 in registerServicesMenuSendTypes.
3748 (validRequestorForSendType): Don't check ns_return_types.
3749
3750 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3751 ns_return_type.
3752
3753 2011-07-08 Jason Rumney <jasonr@gnu.org>
3754
3755 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3756 SH_SHOW for hidden windows (Bug#5482).
3757
3758 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3759 frame struct members of non-existent frames (Bug#6284).
3760
3761 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3762
3763 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3764 variable firstTime not needed on OSX >= 10.6.
3765 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3766 >= 10.5. Use setKnobProportion, setDoubleValue.
3767
3768 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3769 (MAC_OS_X_VERSION_10_5): Define if not defined.
3770 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3771 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3772 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3773
3774 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3775 cString and lossyCString on OSX >= 10.4
3776
3777 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3778 sizeToFit on OSX >= 10.2.
3779
3780 * nsimage.m (allocInitFromFile): Don't use deprecated method
3781 bestRepresentationForDevice on OSX >= 10.6.
3782
3783 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3784 to avoid warning.
3785
3786 * emacs.c: Declare unexec_init_emacs_zone.
3787
3788 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3789
3790 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3791
3792 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3793 on svcsMenu (Bug#8842).
3794
3795 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3796 ns_return_types.
3797 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3798
3799 * nsterm.m (QUTF8_STRING): Declare.
3800 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3801 (validRequestorForSendType): Return type is (id).
3802 Change indexOfObjectIdenticalTo to indexOfObject.
3803 Check if we have local selection before returning self (Bug#8842).
3804 (writeSelectionToPasteboard): Put local selection into paste board
3805 if we have a local selection (Bug#8842).
3806 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3807
3808 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3809 (ns_get_local_selection): Declare.
3810
3811 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3812
3813 * keymap.c (describe_map_tree): Don't insert a double newline at
3814 the end of the buffer (bug#1169) and return whether we inserted
3815 something.
3816
3817 * callint.c (Fcall_interactively): Change "reading args" to
3818 "providing args" to try to clarify what it does (bug#1010).
3819
3820 2011-07-07 Kenichi Handa <handa@m17n.org>
3821
3822 * composite.c (composition_compute_stop_pos): Ignore a static
3823 composition starting before CHARPOS (Bug#8915).
3824
3825 * xdisp.c (handle_composition_prop): Likewise.
3826
3827 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3828
3829 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3830 (Bug#9015)
3831
3832 2011-07-07 Kenichi Handa <handa@m17n.org>
3833
3834 * character.h (unicode_category_t): New enum type.
3835
3836 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3837 (Qchar_code_property_table): New variable.
3838 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3839 (UNIPROP_COMPRESSED_FORM_P): New macros.
3840 (char_table_ascii): Uncompress the compressed values.
3841 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3842 Uncompress the compressed values.
3843 (sub_char_table_ref_and_range): Likewise.
3844 (char_table_ref_and_range): Uncompress the compressed values.
3845 (sub_char_table_set): New arg is_uniprop. Callers changed.
3846 Uncompress the compressed values.
3847 (sub_char_table_set_range): Args changed. Callers changed.
3848 (char_table_set_range): Adjuted for the above change.
3849 (map_sub_char_table): Delete args default_val and parent. Add arg
3850 top. Give decoded values to a Lisp function.
3851 (map_char_table): Adjust for the above change. Give decoded
3852 values to a Lisp function. Gcpro more variables.
3853 (uniprop_table_uncompress)
3854 (uniprop_decode_value_run_length): New functions.
3855 (uniprop_decoder, uniprop_decoder_count): New variables.
3856 (uniprop_get_decoder, uniprop_encode_value_character)
3857 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3858 New functions.
3859 (uniprop_encoder, uniprop_encoder_count): New variables.
3860 (uniprop_get_encoder, uniprop_table)
3861 (Funicode_property_table_internal, Fget_unicode_property_internal)
3862 (Fput_unicode_property_internal): New functions.
3863 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3864 Sunicode_property_table_internal, Sget_unicode_property_internal,
3865 and Sput_unicode_property_internal. Defvar_lisp
3866 char-code-property-alist.
3867
3868 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3869 Vunicode_category_table.
3870
3871 * font.c (font_range): Adjust for the change of
3872 Vunicode_category_table.
3873
3874 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3875
3876 * m/iris4d.h: Remove file, move contents ...
3877 * s/irix6-5.h: ... here.
3878
3879 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3880
3881 Remove unportable assumption about struct layout (Bug#8884).
3882 * alloc.c (mark_buffer):
3883 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3884 (clone_per_buffer_values): Don't assume that
3885 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3886 This isn't true in general, and it's particularly not true
3887 if Emacs is configured with --with-wide-int.
3888 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3889 New macros, used in the buffer.c change.
3890
3891 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3892
3893 * xsettings.c: Use both GConf and GSettings if both are available.
3894 (store_config_changed_event): Add comment.
3895 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3896 (store_tool_bar_style_changed): New functions.
3897 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3898 (struct xsettings): Move font inside HAVE_XFT.
3899 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3900 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3901 Move inside HAVE_XFT.
3902 (something_changed_gsettingsCB): Rename from something_changedCB.
3903 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3904 also.
3905 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3906 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3907 (something_changed_gconfCB): Rename from something_changedCB.
3908 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3909 (parse_settings): Move check for font inside HAVE_XFT.
3910 (read_settings, apply_xft_settings): Add comment.
3911 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3912 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3913 call store_font_name_changed.
3914 (xft_settings_event): Add comment.
3915 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3916 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3917 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3918 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3919 (xsettings_initialize): Call init_gsettings last.
3920 (xsettings_get_system_font, xsettings_get_system_normal_font):
3921 Add comment.
3922
3923 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3924
3925 Random fixes. E.g., (random) never returned negative values.
3926 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3927 subseconds part to the entropy, as that's a bit more random.
3928 Prefer signed to unsigned, since the signedness doesn't matter and
3929 in general we prefer signed. When given a limit, use a
3930 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3931 latter isn't right if USE_2_TAGS_FOR_INTS.
3932 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3933 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3934
3935 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3936
3937 * textprop.c (text_property_stickiness):
3938 Obey Vtext_property_default_nonsticky.
3939 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3940 * w32fns.c (syms_of_w32fns):
3941 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3942
3943 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3944
3945 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3946 This is more efficient than Ffile_directory_p and avoids a minor race.
3947
3948 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3949
3950 * buffer.c (Foverlay_put): Say what the return value is
3951 (bug#7835).
3952
3953 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3954 is a directory before asking whether to use the file name
3955 (bug#7564).
3956 (barf_or_query_if_file_exists): Make the "File is a directory"
3957 error be more correct.
3958
3959 * fns.c (Frequire): Remove the mention of the .gz files, since
3960 that's installation-specific, but keep the mention of
3961 `get-load-suffixes'.
3962
3963 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3964
3965 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3966 Report string overflow if the output is too long.
3967
3968 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3969
3970 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3971 (syms_of_gnutls): Remove duplicate DEFSYM for
3972 Qgnutls_bootprop_verify_hostname_error, an error for
3973 Qgnutls_bootprop_verify_error (which is no longer used).
3974
3975 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3976 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3977 Also (re)move comments that are misplaced or no longer relevant.
3978
3979 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3980
3981 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3982
3983 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3984
3985 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3986 and background color parameters if they have been changed.
3987
3988 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3989
3990 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3991
3992 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3993
3994 * xsettings.c (SYSTEM_FONT): Define only when used.
3995 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3996
3997 * keymap.c (access_keymap_1): Now static.
3998
3999 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4000
4001 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4002 leave any prefix arg for the up event (Bug#1586).
4003
4004 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4005
4006 * lread.c (syms_of_lread): Mention single symbols defined by
4007 `defvar' or `defconst' (bug#7154).
4008
4009 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4010 (Frequire): Mention get-load-suffixes.
4011
4012 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4013
4014 * window.h (window): Remove clone_number slot.
4015 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4016 Remove.
4017 (make_parent_window, make_window, saved_window)
4018 (Fset_window_configuration, save_window_save): Don't deal with
4019 clone numbers.
4020 * buffer.c (Qclone_number): Remove declaration.
4021 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4022
4023 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4024
4025 Add multiple inheritance to keymaps.
4026 * keymap.c (Fmake_composed_keymap): New function.
4027 (Fset_keymap_parent): Simplify.
4028 (fix_submap_inheritance): Remove.
4029 (access_keymap_1): New function extracted from access_keymap to handle
4030 embedded parents and handle lists of maps.
4031 (access_keymap): Use it.
4032 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4033 (Fcopy_keymap): Handle embedded parents.
4034 (Fcommand_remapping, define_as_prefix): Simplify.
4035 (Fkey_binding): Simplify.
4036 (syms_of_keymap): Move minibuffer-local-completion-map,
4037 minibuffer-local-filename-completion-map,
4038 minibuffer-local-must-match-map, and
4039 minibuffer-local-filename-must-match-map to Elisp.
4040 (syms_of_keymap): Defsubr make-composed-keymap.
4041 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4042 (parse_menu_item): Trivial simplification.
4043
4044 2011-07-01 Glenn Morris <rgm@gnu.org>
4045
4046 * Makefile.in (SETTINGS_LIBS): Fix typo.
4047
4048 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4049
4050 * coding.c (Fencode_coding_string): Record the last coding system
4051 used, as the function doc string says (bug#8738).
4052
4053 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4054
4055 * xsettings.c (store_monospaced_changed): Take new font as arg and
4056 check for change against current_mono_font.
4057 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4058 (emacs_settings_constructor, emacs_settings_get_property)
4059 (emacs_settings_set_property, emacs_settings_class_init)
4060 (emacs_settings_init, gsettings_obj): Remove.
4061 (something_changedCB): New function for HAVE_GSETTINGS.
4062 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4063 with value as argument.
4064 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4065 g_settings_new (Bug#8967). Do not create gsettings_obj.
4066 Remove calls to g_settings_bind. Connect something_changedCB to
4067 "changed".
4068
4069 * xgselect.c: Add defined (HAVE_GSETTINGS).
4070 (xgselect_initialize): Ditto.
4071
4072 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4073 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4074 xg_select.
4075
4076 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4077
4078 * eval.c (struct backtrace): Simplify and port the data structure.
4079 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4080 signed bit field, as this assumption is not portable and it makes
4081 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4082 "char debug_on_exit : 1" as this is not portable either; instead,
4083 use the portable "unsigned int debug_on_exit : 1". Remove unused
4084 member evalargs. Remove obsolete comments about cc bombing out.
4085
4086 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4087
4088 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4089 Let HAVE_GSETTINGS override HAVE_GCONF.
4090 (store_monospaced_changed): New function.
4091 (EMACS_SETTINGS): A new type derived from GObject to handle
4092 GSettings notifications.
4093 (emacs_settings_constructor, emacs_settings_get_property)
4094 (emacs_settings_set_property, emacs_settings_class_init):
4095 New functions.
4096 (gsettings_client, gsettings_obj): New variables.
4097 (GSETTINGS_SCHEMA): New define.
4098 (something_changedCB): Call store_monospaced_changed.
4099 (init_gsettings): New function.
4100 (xsettings_initialize): Call init_gsettings.
4101 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4102 to NULL.
4103
4104 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4105 GCONF_CFLAGS/LIBS.
4106
4107 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4108
4109 * window.c (resize_root_window, grow_mini_window)
4110 (shrink_mini_window): Rename Qresize_root_window to
4111 Qwindow_resize_root_window and Qresize_root_window_vertically to
4112 Qwindow_resize_root_window_vertically.
4113
4114 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4115
4116 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4117
4118 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4119
4120 * makefile.w32-in: Redesign dependencies so they reflect more
4121 clearly which files are directly included by each source file,
4122 and not through other includes.
4123
4124 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4125
4126 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4127 (sort_overlays, overlay_strings): When an overlay's clone number
4128 matches the window's clone number process the overlay even if
4129 the overlay's window property doesn't match the current window.
4130
4131 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4132 (Fwindow_hchild): Rename to Fwindow_left_child.
4133 (Fwindow_next): Rename to Fwindow_next_sibling.
4134 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4135 (resize_window_check): Rename to window_resize_check.
4136 (resize_window_apply): Rename to window_resize_apply.
4137 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4138 (Fdelete_other_windows_internal, resize_frame_windows)
4139 (Fsplit_window_internal, Fdelete_window_internal)
4140 (grow_mini_window, shrink_mini_window)
4141 (Fresize_mini_window_internal): Fix callers accordingly.
4142
4143 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4144
4145 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4146 (emacs_fixed_set_min_size): Remove.
4147 (emacs_fixed_new): Take frame as argument.
4148
4149 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4150 (_EmacsFixedPrivate): Remove minwidth/height.
4151 Add struct frame *f.
4152 (emacs_fixed_init): Initialize priv->f.
4153 (get_parent_class, emacs_fixed_set_min_size): Remove.
4154 (emacs_fixed_new): Set priv->f to argument.
4155 (emacs_fixed_get_preferred_width)
4156 (emacs_fixed_get_preferred_height): Use min_width/height from
4157 frames size_hint to set minimum and natural (Bug#8919).
4158 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4159 and use min_width/height from frames size_hint to set
4160 min_width/height (Bug#8919).
4161
4162 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4163 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4164 Fix indentation.
4165
4166 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4167
4168 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4169 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4170 called at ZV.
4171
4172 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4173
4174 * process.c (wait_reading_process_output): Bypass select if
4175 waiting for a cell while ignoring keyboard input, and input is
4176 pending. Suggested by Jan Djärv (Bug#8869).
4177
4178 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4179
4180 Use gnulib's dup2 module instead of rolling our own.
4181 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4182
4183 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4184
4185 * dispnew.c (scrolling_window): Before scrolling, turn off a
4186 mouse-highlight in the window being scrolled.
4187
4188 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4189
4190 Move DEFSYM to lisp.h and use everywhere.
4191
4192 * character.h (DEFSYM): Move declaration...
4193 * lisp.h (DEFSYM): ...here.
4194
4195 * gnutls.c:
4196 * minibuf.c:
4197 * w32menu.c:
4198 * w32proc.c:
4199 * w32select.c: Don't include character.h.
4200
4201 * alloc.c (syms_of_alloc):
4202 * buffer.c (syms_of_buffer):
4203 * bytecode.c (syms_of_bytecode):
4204 * callint.c (syms_of_callint):
4205 * casefiddle.c (syms_of_casefiddle):
4206 * casetab.c (init_casetab_once):
4207 * category.c (init_category_once, syms_of_category):
4208 * ccl.c (syms_of_ccl):
4209 * cmds.c (syms_of_cmds):
4210 * composite.c (syms_of_composite):
4211 * dbusbind.c (syms_of_dbusbind):
4212 * dired.c (syms_of_dired):
4213 * dispnew.c (syms_of_display):
4214 * doc.c (syms_of_doc):
4215 * editfns.c (syms_of_editfns):
4216 * emacs.c (syms_of_emacs):
4217 * eval.c (syms_of_eval):
4218 * fileio.c (syms_of_fileio):
4219 * fns.c (syms_of_fns):
4220 * frame.c (syms_of_frame):
4221 * fringe.c (syms_of_fringe):
4222 * insdel.c (syms_of_insdel):
4223 * keymap.c (syms_of_keymap):
4224 * lread.c (init_obarray, syms_of_lread):
4225 * macros.c (syms_of_macros):
4226 * msdos.c (syms_of_msdos):
4227 * print.c (syms_of_print):
4228 * process.c (syms_of_process):
4229 * search.c (syms_of_search):
4230 * sound.c (syms_of_sound):
4231 * syntax.c (init_syntax_once, syms_of_syntax):
4232 * terminal.c (syms_of_terminal):
4233 * textprop.c (syms_of_textprop):
4234 * undo.c (syms_of_undo):
4235 * w32.c (globals_of_w32):
4236 * window.c (syms_of_window):
4237 * xdisp.c (syms_of_xdisp):
4238 * xfaces.c (syms_of_xfaces):
4239 * xfns.c (syms_of_xfns):
4240 * xmenu.c (syms_of_xmenu):
4241 * xsettings.c (syms_of_xsettings):
4242 * xterm.c (syms_of_xterm): Use DEFSYM.
4243
4244 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4245
4246 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4247
4248 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4249
4250 Integer and buffer overflow fixes (Bug#8873).
4251
4252 * print.c (printchar, strout): Check for string overflow.
4253 (PRINTPREPARE, printchar, strout):
4254 Don't set size unless allocation succeeds.
4255
4256 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4257 for sizes. Check for string overflow more accurately.
4258 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4259
4260 * macros.c: Integer and buffer overflow fixes.
4261 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4262 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4263 Use ptrdiff_t, not int, for sizes.
4264 Don't increment bufsize until after realloc succeeds.
4265 Check for size-calculation overflow.
4266 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4267
4268 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4269
4270 * lread.c: Integer overflow fixes.
4271 (read_integer): Radix is now EMACS_INT, not int,
4272 to improve quality of diagnostics for out-of-range radices.
4273 Calculate buffer size correctly for out-of-range radices.
4274 (read1): Check for integer overflow in radices, and in
4275 read-circle numbers.
4276 (read_escape): Avoid int overflow.
4277 (Fload, openp, read_buffer_size, read1)
4278 (substitute_object_recurse, read_vector, read_list, map_obarray):
4279 Use ptrdiff_t, not int, for sizes.
4280 (read1): Use EMACS_INT, not int, for sizes.
4281 Check for size overflow.
4282
4283 * image.c (cache_image): Check for size arithmetic overflow.
4284
4285 * lread.c: Integer overflow issues.
4286 (saved_doc_string_size, saved_doc_string_length)
4287 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4288 Now ptrdiff_t, not int.
4289 (read1): Don't assume doc string length fits in int. Check for
4290 out-of-range doc string lengths.
4291 (read_list): Don't assume file position fits in int.
4292 (read_escape): Check for hex character overflow.
4293
4294 2011-06-22 Leo Liu <sdl.web@gmail.com>
4295
4296 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4297 Move to minibuffer.el.
4298
4299 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4300
4301 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4302 The following patches are for when GLYPH_DEBUG && !XASSERT.
4303 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4304 * dispnew.c (flush_stdout):
4305 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4306 Mark as externally visible.
4307 * dispnew.c (check_window_matrix_pointers): Now static.
4308 * dispnew.c (window_to_frame_vpos):
4309 * xfns.c (unwind_create_frame):
4310 * xterm.c (x_check_font): Remove unused local.
4311 * scroll.c (CHECK_BOUNDS):
4312 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4313 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4314 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4315 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4316 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4317 Now static.
4318 (debug_method_add): Use va_list and vsprintf rather than relying
4319 on undefined behavior with wrong number of arguments.
4320 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4321 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4322 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4323 since we're not interested in debugging glyphs with old libraries.
4324 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4325 GCC 4.6.0's static checking.
4326
4327 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4328
4329 Integer overflow and signedness fixes (Bug#8873).
4330 A few related buffer overrun fixes, too.
4331
4332 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4333
4334 * dispextern.h (struct face.stipple):
4335 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4336 (x_bitmap_mask, x_allocate_bitmap_record)
4337 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4338 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4339 (x_create_bitmap_from_xpm_data):
4340 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4341 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4342 (.bitmaps_last):
4343 * xfaces.c (load_pixmap):
4344 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4345 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4346 (.bitmaps_last, struct x_output.icon_bitmap):
4347 Use ptrdiff_t, not int, for bitmap indexes.
4348 (x_allocate_bitmap_record): Check for size overflow.
4349 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4350
4351 Use ptrdiff_t, not int, for overlay counts.
4352 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4353 * editfns.c (overlays_around, get_pos_property):
4354 * textprop.c (get_char_property_and_overlay):
4355 * xdisp.c (next_overlay_change, note_mouse_highlight):
4356 * xfaces.c (face_at_buffer_position):
4357 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4358 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4359 (Fnext_overlay_change, Fprevious_overlay_change)
4360 (mouse_face_overlay_overlaps, Foverlays_in):
4361 Use ptrdiff_t, not int, for sizes.
4362 (overlays_at, overlays_in): Check for size-calculation overflow.
4363
4364 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4365
4366 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4367 (x_session_initialize): Do not assume string length fits in int.
4368
4369 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4370 This is unlikely, but can occur if DPI is outlandish.
4371
4372 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4373 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4374
4375 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4376 * xrdb.c (magic_file_p, search_magic_path):
4377 Omit last arg SUFFIX; it was always 0. All callers changed.
4378 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4379
4380 * xfont.c (xfont_match): Avoid need for strlen.
4381
4382 * xfns.c: Don't assume strlen fits in int.
4383 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4384
4385 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4386 not unsigned long, as we prefer signed integers. All callers changed.
4387 Detect integer overflow in repeat count.
4388 (message_dolog): Don't assume print length fits in 39 bytes.
4389 (display_mode_element): Don't assume strlen fits in int.
4390
4391 * termcap.c: Don't assume sizes fit in int and never overflow.
4392 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4393 (gobble_line): Check for size-calculation overflow.
4394
4395 * minibuf.c (Fread_buffer):
4396 * lread.c (intern, intern_c_string):
4397 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4398 Don't assume string length fits in int.
4399
4400 * keyboard.c (parse_tool_bar_item):
4401 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4402
4403 * font.c: Don't assume string length fits in int.
4404 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4405 Use ptrdiff_t, not int.
4406 (font_intern_prop): Don't assume string length fits in int.
4407 Don't assume integer property fits in fixnum.
4408 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4409
4410 * filelock.c: Fix some buffer overrun and integer overflow issues.
4411 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4412 Reformulate so as not to need the command string.
4413 Invoke gzip -cd rather than gunzip, as it's more portable.
4414 (lock_info_type, lock_file_1, lock_file):
4415 Don't assume pid_t and time_t fit in unsigned long.
4416 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4417 (current_lock_owner): Prefer signed type for sizes.
4418 Use memcpy, not strncpy, where memcpy is what is really wanted.
4419 Don't assume (via atoi) that time_t and pid_t fit in int.
4420 Check for time_t and/or pid_t out of range, e.g., via a network share.
4421 Don't alloca where an auto var works fine.
4422
4423 * fileio.c: Fix some integer overflow issues.
4424 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4425 Don't assume string length fits in int.
4426 (directory_file_name): Don't assume string length fits in long.
4427 (make_temp_name): Don't assume pid fits in int, or that its print
4428 length is less than 20.
4429
4430 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4431
4432 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4433
4434 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4435
4436 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4437 We prefer signed integers, even for size calculations.
4438
4439 * emacs.c: Don't assume string length fits in 'int'.
4440 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4441 (main): Don't invoke strlen when not needed.
4442
4443 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4444 (XD_DEBUG_MESSAGE): Don't waste a byte.
4445
4446 * callproc.c (getenv_internal_1, getenv_internal)
4447 (Fgetenv_internal):
4448 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4449
4450 * lread.c (invalid_syntax): Omit length argument.
4451 All uses changed. This doesn't fix a bug, but it simplifies the
4452 code away from its former Hollerith-constant appearance, and it's
4453 one less 'int' to worry about when looking at integer-overflow issues.
4454 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4455
4456 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4457 This didn't break anything, but it didn't help either.
4458 It's confusing to put a bogus integer in a place where the actual
4459 value does not matter.
4460 (LIST_END_P): Remove unused macro and its bogus comment.
4461 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4462
4463 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4464 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4465 implementation.
4466 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4467 We prefer signed types, and the value cannot exceed the EMACS_INT
4468 range anyway (because otherwise the length would not be representable).
4469 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4470 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4471 This avoids a GCC warning when WIDE_EMACS_INT.
4472
4473 * indent.c (sane_tab_width): New function.
4474 (current_column, scan_for_column, Findent_to, position_indentation)
4475 (compute_motion): Use it. This is just for clarity.
4476 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4477
4478 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4479
4480 * lisp.h (lint_assume): New macro.
4481 * composite.c (composition_gstring_put_cache):
4482 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4483
4484 * editfns.c, insdel.c:
4485 Omit unnecessary forward decls, to simplify future changes.
4486
4487 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4488
4489 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4490
4491 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4492 Use much-faster test for byte-length change.
4493 Don't assume string byte-length fits in 'int'.
4494 Check that character arg fits in 'int'.
4495 (mapcar1): Declare byte as byte, for clarity.
4496
4497 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4498
4499 * fns.c (concat): Catch string overflow earlier.
4500 Do not rely on integer wraparound.
4501
4502 * dispextern.h (struct it.overlay_strings_charpos)
4503 (struct it.selective): Now EMACS_INT, not int.
4504 * xdisp.c (forward_to_next_line_start)
4505 (back_to_previous_visible_line_start)
4506 (reseat_at_next_visible_line_start, next_element_from_buffer):
4507 Don't arbitrarily truncate the value of 'selective' to int.
4508
4509 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4510
4511 * composite.c: Don't truncate sizes to 'int'.
4512 (composition_gstring_p, composition_reseat_it)
4513 (composition_adjust_point): Use EMACS_INT, not int.
4514 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4515 not EMACS_UINT, for indexes.
4516
4517 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4518
4519 * buffer.c: Include <verify.h>.
4520 (struct sortvec.priority, struct sortstr.priority):
4521 Now EMACS_INT, not int.
4522 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4523 (struct sortstr.size, record_overlay_string)
4524 (struct sortstrlist.size, struct sortlist.used):
4525 Don't truncate size to int.
4526 (record_overlay_string): Check for size-calculation overflow.
4527 (init_buffer_once): Check at compile-time, not run-time.
4528
4529 2011-06-22 Jim Meyering <meyering@redhat.com>
4530
4531 Don't leak an XBM-image-sized buffer
4532 * image.c (xbm_load): Free the image buffer after using it.
4533
4534 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4535
4536 Port to Sun C.
4537 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4538 that Sun C diagnosed.
4539 * fns.c (secure_hash): Fix pointer signedness issue.
4540 * intervals.c (static_offset_intervals): New function.
4541 (offset_intervals): Use it.
4542
4543 2011-06-21 Leo Liu <sdl.web@gmail.com>
4544
4545 * deps.mk (fns.o):
4546 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4547 sha512.h.
4548
4549 * fns.c (secure_hash): Rename from crypto_hash_function and change
4550 the first arg to accept symbols.
4551 (Fsecure_hash): New primitive.
4552 (syms_of_fns): New symbols.
4553
4554 2011-06-20 Deniz Dogan <deniz@dogan.se>
4555
4556 * process.c (Fset_process_buffer): Clarify return value in
4557 docstring.
4558
4559 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4560
4561 * dispnew.c (add_window_display_history): Use BVAR.
4562
4563 * xdisp.c (debug_method_add): Use BVAR.
4564 (check_window_end, dump_glyph_matrix, dump_glyph)
4565 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4566
4567 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4568 Likewise.
4569
4570 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4571 check till after the cache is created in init_frame_faces.
4572
4573 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4574
4575 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4576
4577 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4578
4579 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4580 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4581 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4582
4583 Improve buffer-overflow checking (Bug#8873).
4584 * fileio.c (Finsert_file_contents):
4585 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4586 Remove the old (too-loose) buffer overflow checks.
4587 They weren't needed, since make_gap checks for buffer overflow.
4588 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4589 The old code merely checked for Emacs fixnum overflow, and relied
4590 on undefined (wraparound) behavior. The new code avoids undefined
4591 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4592
4593 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4594 Tune. Don't use wider integers than needed. Don't use alloca.
4595 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4596
4597 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4598
4599 * insdel.c, lisp.h (buffer_overflow): New function.
4600 (insert_from_buffer_1, replace_range, replace_range_2):
4601 * insdel.c (make_gap_larger):
4602 * editfns.c (Finsert_char):
4603 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4604
4605 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4606
4607 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4608
4609 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4610
4611 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4612 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4613
4614 * fileio.c: Don't assume EMACS_INT fits in off_t.
4615 (emacs_lseek): New static function.
4616 (Finsert_file_contents, Fwrite_region): Use it.
4617 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4618
4619 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4620
4621 * fns.c: Don't overflow int when computing a list length.
4622 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4623 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4624 truncation on 64-bit hosts. Check for QUIT every
4625 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4626 faster and is responsive enough.
4627 (Flength): Report an error instead of overflowing an integer.
4628 (Fsafe_length): Return a float if the value is not representable
4629 as a fixnum. This shouldn't happen except in contrived situations.
4630 (Fnthcdr, Fsort): Don't assume list length fits in int.
4631 (Fcopy_sequence): Don't assume vector length fits in int.
4632
4633 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4634 (header_size, word_size): New constants.
4635 (allocate_vectorlike): Don't check size overflow here.
4636 (allocate_vector): Check it here instead, since this is the only
4637 caller of allocate_vectorlike that could cause overflow.
4638 Check that the new vector's length is representable as a fixnum.
4639
4640 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4641 The previous code was bogus. For example, next_almost_prime (32)
4642 returned 39, which is undesirable as it is a multiple of 3; and
4643 next_almost_prime (24) returned 25, which is a multiple of 5 so
4644 why was the code bothering to check for multiples of 7?
4645
4646 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4647
4648 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4649
4650 Variadic C functions now count arguments with ptrdiff_t.
4651 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4652 Back then I didn't know that the Emacs coding style prefers signed int.
4653 Also, in the meantime I found a few more instances where arguments
4654 were being counted with int, which may truncate counts on 64-bit
4655 machines, or EMACS_INT, which may be unnecessarily wide.
4656 * lisp.h (struct Lisp_Subr.function.aMANY)
4657 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4658 Arg counts are now ptrdiff_t, not size_t.
4659 All variadic functions and their callers changed accordingly.
4660 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4661 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4662 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4663 * callint.c (Fcall_interactively): Check arg count for overflow,
4664 to avoid potential buffer overrun. Use signed char, not 'int',
4665 for 'varies' array, so that we needn't bother to check its size
4666 calculation for overflow.
4667 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4668 * eval.c (apply_lambda):
4669 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4670 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4671 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4672
4673 * callint.c (Fcall_interactively): Don't use index var as event count.
4674
4675 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4676 * mem-limits.h (SIZE): Remove; no longer used.
4677
4678 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4679
4680 Remove unnecessary casts.
4681 * xterm.c (x_term_init):
4682 * xfns.c (x_set_border_pixel):
4683 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4684 These aren't needed now that we assume ANSI C.
4685
4686 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4687 It's more likely to cause problems (due to unsigned overflow)
4688 than to cure them.
4689
4690 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4691
4692 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4693
4694 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4695
4696 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4697
4698 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4699
4700 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4701
4702 GLYPH_CODE_FACE returns EMACS_INT, not int.
4703 * dispextern.h (merge_faces):
4704 * xfaces.c (merge_faces):
4705 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4706 Don't assume EMACS_INT fits in int.
4707
4708 * character.h (CHAR_VALID_P): Remove unused parameter.
4709 * fontset.c, lisp.h, xdisp.c: All uses changed.
4710
4711 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4712
4713 * fns.c (concat): Minor tuning based on overflow analysis.
4714 This doesn't fix any bugs. Use int to hold character, instead
4715 of constantly refetching from Emacs object. Use XFASTINT, not
4716 XINT, for value known to be a character. Don't bother comparing
4717 a single byte to 0400, as it's always less.
4718
4719 * floatfns.c (Fexpt):
4720 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4721
4722 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4723 for characters.
4724
4725 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4726
4727 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4728 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4729 incorrectly succeed when S was a string, because 4294967386 was
4730 truncated before it was used.
4731
4732 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4733 Otherwise, an out-of-range integer could cause undefined behavior
4734 on a 64-bit host.
4735
4736 * composite.c: Use int, not EMACS_INT, for characters.
4737 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4738 EMACS_INT, for values that are known to be in character range.
4739 This doesn't fix any bugs but is the usual style inside Emacs and
4740 may generate better code on 32-bit machines.
4741
4742 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4743 This is for reasons similar to the recent CHAR_STRING fix.
4744 * charset.c (Fencode_char): Check that character arg is actually
4745 a character. Pass an int to ENCODE_CHAR.
4746 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4747 wider than 'int', as a compile-time check to prevent future regressions
4748 in this area.
4749
4750 * character.c (char_string): Remove unnecessary casts.
4751
4752 Make sure a 64-bit char is never passed to CHAR_STRING.
4753 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4754 by silently ignoring the top 32 bits, allowing some values
4755 that were far too large to be valid characters.
4756 * character.h: Include <verify.h>.
4757 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4758 arguments are no wider than unsigned, as a compile-time check
4759 to prevent future regressions in this area.
4760 * data.c (Faset):
4761 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4762 (Fsubst_char_in_region):
4763 * fns.c (concat):
4764 * xdisp.c (decode_mode_spec_coding):
4765 Adjust to CHAR_STRING's new requirement.
4766 * editfns.c (Finsert_char, Fsubst_char_in_region):
4767 * fns.c (concat): Check that character args are actually
4768 characters. Without this test, these functions did the wrong
4769 thing with wildly out-of-range values on 64-bit hosts.
4770
4771 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4772 These casts should not be needed on 32-bit hosts, either.
4773 * keyboard.c (read_char):
4774 * lread.c (Fload): Remove casts to unsigned.
4775
4776 * lisp.h (UNSIGNED_CMP): New macro.
4777 This fixes comparison bugs on 64-bit hosts.
4778 (ASCII_CHAR_P): Use it.
4779 * casefiddle.c (casify_object):
4780 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4781 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4782 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4783 * dispextern.h (FACE_FROM_ID):
4784 * keyboard.c (read_char): Use UNSIGNED_CMP.
4785
4786 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4787 not to EMACS_INT, to avoid GCC warning.
4788
4789 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4790
4791 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4792 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4793 isn't needed on 32-bit machines.
4794
4795 * buffer.c (Fgenerate_new_buffer_name):
4796 Use EMACS_INT for count, not int.
4797 (advance_to_char_boundary): Return EMACS_INT, not int.
4798
4799 * data.c (Qcompiled_function): Now static.
4800
4801 * window.c (window_body_lines): Now static.
4802
4803 * image.c (gif_load): Rename local to avoid shadowing.
4804
4805 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4806 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4807 * alloc.c (make_save_value): Integer argument is now of type
4808 ptrdiff_t, not int.
4809 (mark_object): Use ptrdiff_t, not int.
4810 * lisp.h (pD): New macro.
4811 * print.c (print_object): Use it.
4812
4813 * alloc.c: Use EMACS_INT, not int, to count objects.
4814 (total_conses, total_markers, total_symbols, total_vector_size)
4815 (total_free_conses, total_free_markers, total_free_symbols)
4816 (total_free_floats, total_floats, total_free_intervals)
4817 (total_intervals, total_strings, total_free_strings):
4818 Now EMACS_INT, not int. All uses changed.
4819 (Fgarbage_collect): Compute overall total using a double, so that
4820 integer overflow is less likely to be a problem. Check for overflow
4821 when converting back to an integer.
4822 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4823 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4824 These were 'int' variables that could overflow on 64-bit hosts;
4825 they were never used, so remove them instead of repairing them.
4826 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4827 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4828 Previously, this ceilinged at INT_MAX, but that doesn't work on
4829 64-bit machines.
4830 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4831
4832 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4833 (allocate_vectorlike): Check for ptrdiff_t overflow.
4834 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4835 when a (possibly-narrower) signed value would do just as well.
4836 We prefer using signed arithmetic, to avoid comparison confusion.
4837
4838 * alloc.c: Catch some string size overflows that we were missing.
4839 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4840 for convenience in STRING_BYTES_MAX.
4841 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4842 The definition here is exact; the one in lisp.h was approximate.
4843 (allocate_string_data): Check for string overflow. This catches
4844 some instances we weren't catching before. Also, it catches
4845 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4846 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4847 and ptrdiff_t and EMACS_INT are both 64 bits.
4848
4849 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4850 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4851 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4852
4853 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4854
4855 * alloc.c (Fmake_string): Check for out-of-range init.
4856
4857 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4858
4859 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4860
4861 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4862
4863 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4864 xg_get_default_scrollbar_width.
4865
4866 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4867 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4868 (style_changed_cb): Call update_theme_scrollbar_width and call
4869 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4870 all frames (Bug#8505).
4871 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4872 Call gtk_window_set_resizable if HAVE_GTK3.
4873 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4874 and height if HAVE_GTK3 (Bug#8505).
4875 (scroll_bar_width_for_theme): New variable.
4876 (update_theme_scrollbar_width): New function.
4877 (xg_get_default_scrollbar_width): Move code to
4878 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4879 (xg_initialize): Call update_theme_scrollbar_width.
4880
4881 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4882
4883 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4884
4885 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4886
4887 * frame.c (make_frame): Call other_buffer_safely instead of
4888 other_buffer.
4889
4890 * window.c (temp_output_buffer_show): Call display_buffer with
4891 second argument Vtemp_buffer_show_specifiers and reset latter
4892 immediately after the call.
4893 (Vtemp_buffer_show_specifiers): New variable.
4894 (auto_window_vscroll_p, next_screen_context_lines)
4895 (Vscroll_preserve_screen_position): Remove leading asterisks from
4896 doc-strings.
4897
4898 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4899
4900 Fix minor problems found by GCC 4.6.0 static checking.
4901 * buffer.c (Qclone_number): Remove for now, as it's unused.
4902 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4903 (record_buffer): Remove unused local.
4904 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4905 (set_frame_buffer_list): Remove; unused.
4906 * frame.h (other_visible_frames): Remove decl.
4907 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4908 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4909 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4910 if HAVE_GPM.
4911 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4912 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4913 Define only if HAVE_GPM.
4914 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4915 (update_hints_inhibit): Remove; never set. All uses removed.
4916 * widgetprv.h (emacsFrameClassRec): Remove decl.
4917 * window.c (delete_deletable_window): Now returns void, since it
4918 wasn't returning anything.
4919 (compare_window_configurations): Remove unused locals.
4920 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4921 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4922 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4923 the same widths as pointers. This follows up on the 2011-05-06 patch.
4924 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4925 * xterm.h: Likewise.
4926 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4927
4928 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4929
4930 * makefile.w32-in: Update dependencies.
4931 (LISP_H): Add lib/intprops.h.
4932
4933 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4934
4935 * image.c (gif_load): Add animation frame delay to the metadata.
4936 (syms_of_image): Use DEFSYM. New symbol `delay'.
4937
4938 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4939
4940 * window.c (delete_deletable_window): Re-add.
4941 (Fset_window_configuration): Rewrite to handle dead buffers and
4942 consequently deletable windows.
4943 (window_tree, Fwindow_tree): Remove. Supply functionality in
4944 window.el.
4945 (compare_window_configurations): Simplify code.
4946
4947 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4948
4949 * image.c (imagemagick_load_image): Fix type mismatch.
4950 (Fimagemagick_types): Likewise.
4951
4952 * window.h (replace_buffer_in_windows): Declare.
4953
4954 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4955
4956 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4957 Qclone_number. Remove external declaration of Qdelete_window.
4958 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4959 code.
4960 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4961 Run Qbuffer_list_update_hook if allowed.
4962 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4963 buffer list implementation.
4964 (other_buffer_safely): New function.
4965 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4966 calls to replace_buffer_in_windows and
4967 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4968 if allowed.
4969 (record_buffer): Inhibit quitting and rewrite using quittable
4970 functions. Run Qbuffer_list_update_hook if allowed.
4971 (Frecord_buffer, Funrecord_buffer): New functions.
4972 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4973 Move switch-to-buffer to window.el.
4974 (bury-buffer): Move to window.el.
4975 (Vbuffer_list_update_hook): New variable.
4976
4977 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4978 section.
4979
4980 * window.h (resize_frame_windows): Move up in code.
4981 (Fwindow_frame): Remove EXFUN.
4982 (replace_buffer_in_all_windows): Remove prototype.
4983 (replace_buffer_in_windows_safely): Add prototype.
4984
4985 * window.c: Declare Qdelete_window static again. Move down
4986 declaration of select_count.
4987 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4988 (Fother_window): Move to window.el.
4989 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4990 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4991 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4992 window.el.
4993 (replace_buffer_in_windows): Implement by calling
4994 Qreplace_buffer_in_windows.
4995 (replace_buffer_in_all_windows): Remove with some functionality
4996 moved into replace_buffer_in_windows_safely.
4997 (replace_buffer_in_windows_safely): New function.
4998 (select_window_norecord, select_frame_norecord): Move in front
4999 of run_window_configuration_change_hook. Remove now obsolete
5000 declarations.
5001 (Fset_window_buffer): Rewrite doc-string.
5002 Call Qrecord_window_buffer.
5003 (keys_of_window): Move binding for other-window to window.el.
5004
5005 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5006
5007 * dispextern.h (struct image): Replace data member, whose int_val
5008 and ptr_val fields were not used by anything, with a single
5009 lisp_val object.
5010
5011 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5012 (gif_clear_image, gif_load, imagemagick_load_image)
5013 (gs_clear_image, gs_load): Callers changed.
5014
5015 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5016
5017 * buffer.h: Include <time.h>, for time_t.
5018 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5019
5020 Fix minor problems found by static checking.
5021
5022 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5023
5024 Make identifiers static if they are not used in other modules.
5025 * data.c (Qcompiled_function, Qframe, Qvector):
5026 * image.c (QimageMagick, Qsvg):
5027 * minibuf.c (Qmetadata):
5028 * window.c (resize_window_check, resize_root_window): Now static.
5029 * window.h (resize_window_check, resize_root_window): Remove decls.
5030
5031 * window.c (window_deletion_count, delete_deletable_window):
5032 Remove; unused.
5033 (window_body_lines): Now static.
5034 (Fdelete_other_windows_internal): Mark vars as initialized.
5035 Make sure 'resize_failed' is initialized.
5036 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5037 (resize_window_apply): Remove unused local.
5038 * window.h (delete_deletable_window): Remove decl.
5039
5040 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5041 (imagemagick_load_image): Fix pointer signedness problem by changing
5042 last arg from unsigned char * to char *. All uses changed.
5043 Also, fix a local for similar reasons.
5044 Remove unused locals. Remove locals to avoid shadowing.
5045 (fn_rsvg_handle_free): Remove; unused.
5046 (svg_load, svg_load_image): Fix pointer signedness problem.
5047 (imagemagick_load_image): Don't use garbage pointer image_wand.
5048
5049 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5050
5051 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5052
5053 * image.c (gif_load): Fix omitted cast error introduced by
5054 2011-06-06 change.
5055
5056 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5057
5058 * window.h (resize_proportionally, orig_total_lines)
5059 (orig_top_line): Remove from window structure.
5060 (set_window_height, set_window_width, change_window_heights)
5061 (Fdelete_window): Remove prototypes.
5062 (resize_frame_windows): Remove duplicate declaration.
5063
5064 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5065
5066 * window.h (resize_frame_windows, resize_window_check)
5067 (delete_deletable_window, resize_root_window)
5068 (resize_frame_windows): Declare prototypes.
5069
5070 * window.c (resize_window_apply): Make definition be "static" to
5071 match the prototype.
5072
5073 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5074
5075 * window.c: Remove declarations of Qwindow_size_fixed,
5076 window_min_size_1, window_min_size_2, window_min_size,
5077 size_window, window_fixed_size_p, enlarge_window, delete_window.
5078 Remove static from declaration of Qdelete_window, it's
5079 temporarily needed by Fbury_buffer.
5080 (replace_window): Don't assign orig_top_line and
5081 orig_total_lines.
5082 (Fdelete_window, delete_window): Remove. Window deletion is
5083 handled by window.el.
5084 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5085 Replace Fdelete_window calls with calls to Qdelete_window.
5086 (Fdelete_other_windows): Remove. Deleting other windows is
5087 handled by window.el.
5088 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5089 handled in window.el.
5090 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5091 Window minimum sizes are handled in window.el.
5092 (shrink_windows, size_window, set_window_height)
5093 (set_window_width, change_window_heights, window_height)
5094 (window_width, CURBEG, CURSIZE, enlarge_window)
5095 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5096 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5097 handled in window.el.
5098 (make_dummy_parent): Rename to make_parent_window and give it a
5099 second argument horflag.
5100 (make_window): Don't set resize_proportionally any more.
5101 (Fsplit_window): Remove. Windows are split in window.el.
5102 (save_restore_action, save_restore_orig_size)
5103 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5104 Resize mini windows in window.el.
5105 (grow_mini_window, shrink_mini_window): Implement by calling
5106 Qresize_root_window_vertically, resize_window_check and
5107 resize_window_apply.
5108 (saved_window, Fset_window_configuration, save_window_save):
5109 Do not handle orig_top_line, orig_total_lines, and
5110 resize_proportionally.
5111 (window_min_height, window_min_width): Move to window.el.
5112 (keys_of_window): Move bindings for delete-other-windows,
5113 split-window, delete-window and enlarge-window to window.el.
5114
5115 * buffer.c: Temporarily extern Qdelete_window.
5116 (Fbury_buffer): Temporarily call Qdelete_window instead of
5117 Fdelete_window (Fbury_buffer will move to window.el soon).
5118
5119 * frame.c (set_menu_bar_lines_1): Remove code handling
5120 orig_top_line and orig_total_lines.
5121
5122 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5123 set_window_height but set heights directly.
5124 (change_frame_size_1): Use resize_frame_windows.
5125
5126 * xdisp.c (init_xdisp): Don't use set_window_height but set
5127 heights directly.
5128
5129 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5130 Use resize_frame_windows instead of change_window_heights and run
5131 run_window_configuration_change_hook.
5132
5133 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5134 instead of change_window_heights and run
5135 run_window_configuration_change_hook.
5136
5137 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5138
5139 * window.c (replace_window): Rename second argument REPLACEMENT to
5140 NEW. New third argument SETFLAG. Rewrite.
5141 (delete_window, make_dummy_parent): Call replace_window with
5142 third argument 1.
5143 (window_list_1): Move down in code.
5144 (run_window_configuration_change_hook): Move set_buffer part
5145 before select_frame_norecord part in order to unwind correctly.
5146 Rename count1 to count.
5147 (recombine_windows, delete_deletable_window, resize_root_window)
5148 (Fdelete_other_windows_internal)
5149 (Frun_window_configuration_change_hook, make_parent_window)
5150 (resize_window_check, resize_window_apply, Fresize_window_apply)
5151 (resize_frame_windows, Fsplit_window_internal)
5152 (Fdelete_window_internal, Fresize_mini_window_internal):
5153 New functions.
5154 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5155
5156 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5157
5158 * window.h (window): Add some new members to window structure -
5159 normal_lines, normal_cols, new_total, new_normal, clone_number,
5160 splits, nest, prev_buffers, next_buffers.
5161 (WINDOW_TOTAL_SIZE): Move here from window.c.
5162 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5163
5164 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5165 Remove.
5166 (make_dummy_parent): Set new members of windows structure.
5167 (make_window): Move down in code. Handle new members of window
5168 structure.
5169 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5170 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5171 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5172 (Fset_window_prev_buffers, Fwindow_next_buffers)
5173 (Fset_window_next_buffers, Fset_window_clone_number):
5174 New functions.
5175 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5176 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5177 Doc-string fixes.
5178 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5179 Argument WINDOW can be now internal window too.
5180 (Fwindow_use_time): Move up in code.
5181 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5182 Rewrite doc-string.
5183 (Fset_window_configuration, saved_window)
5184 (Fcurrent_window_configuration, save_window_save): Handle new
5185 members of window structure.
5186 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5187 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5188 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5189 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5190 Qget_mru_window, Qresize_root_window,
5191 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5192 Qauto_buffer_name; staticpro them.
5193
5194 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5195
5196 * window.c (Fwindow_total_size, Fwindow_left_column)
5197 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5198 (Fwindow_list_1): New functions.
5199 (window_box_text_cols): Replace with window_body_cols.
5200 (Fwindow_width, Fscroll_left, Fscroll_right):
5201 Use window_body_cols instead of window_box_text_cols.
5202 (delete_window, Fset_window_configuration):
5203 Call delete_all_subwindows with window as argument.
5204 (delete_all_subwindows): Take a window as argument and not a
5205 structure. Rewrite.
5206 (window_loop): Remove handling of GET_LRU_WINDOW and
5207 GET_LARGEST_WINDOW.
5208 (Fget_lru_window, Fget_largest_window): Move to window.el.
5209
5210 * window.h: Extern window_body_cols instead of
5211 window_box_text_cols. delete_all_subwindows now takes a
5212 Lisp_Object as argument.
5213
5214 * indent.c (compute_motion, Fcompute_motion):
5215 Use window_body_cols instead of window_box_text_cols.
5216
5217 * frame.c (delete_frame): Call delete_all_subwindows with root
5218 window as argument.
5219
5220 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5221
5222 * fns.c (Fputhash): Document return value.
5223
5224 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5225
5226 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5227
5228 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5229
5230 Cons<->int and similar integer overflow fixes (Bug#8794).
5231
5232 Check for overflow when converting integer to cons and back.
5233 * charset.c (Fdefine_charset_internal, Fdecode_char):
5234 Use cons_to_unsigned to catch overflow.
5235 (Fencode_char): Use INTEGER_TO_CONS.
5236 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5237 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5238 * data.c (long_to_cons, cons_to_long): Remove.
5239 (cons_to_unsigned, cons_to_signed): New functions.
5240 These signal an error for invalid or out-of-range values.
5241 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5242 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5243 * font.c (Ffont_variation_glyphs):
5244 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5245 * lisp.h: Include <intprops.h>.
5246 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5247 (cons_to_signed, cons_to_unsigned): New decls.
5248 (long_to_cons, cons_to_long): Remove decls.
5249 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5250 (Fprimitive_undo): Use CONS_TO_INTEGER.
5251 * xfns.c (Fx_window_property): Likewise.
5252 * xselect.c: Include <limits.h>.
5253 (x_own_selection, selection_data_to_lisp_data):
5254 Use INTEGER_TO_CONS.
5255 (x_handle_selection_request, x_handle_selection_clear)
5256 (x_get_foreign_selection, Fx_disown_selection_internal)
5257 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5258 (lisp_data_to_selection_data): Use cons_to_unsigned.
5259 (x_fill_property_data): Use cons_to_signed.
5260 Report values out of range.
5261
5262 Check for buffer and string overflow more precisely.
5263 * buffer.h (BUF_BYTES_MAX): New macro.
5264 * lisp.h (STRING_BYTES_MAX): New macro.
5265 * alloc.c (Fmake_string):
5266 * character.c (string_escape_byte8):
5267 * coding.c (coding_alloc_by_realloc):
5268 * doprnt.c (doprnt):
5269 * editfns.c (Fformat):
5270 * eval.c (verror):
5271 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5272 since they may not be the same number.
5273 * editfns.c (Finsert_char):
5274 * fileio.c (Finsert_file_contents):
5275 Likewise for BUF_BYTES_MAX.
5276
5277 * image.c: Use ptrdiff_t, not int, for sizes.
5278 (slurp_file): Switch from int to ptrdiff_t.
5279 All uses changed.
5280 (slurp_file): Check that file size fits in both size_t (for
5281 malloc) and ptrdiff_t (for sanity and safety).
5282
5283 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5284 if b->modtime has its maximal value.
5285
5286 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5287
5288 Don't assume time_t can fit into int.
5289 * buffer.h (struct buffer.modtime): Now time_t, not int.
5290 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5291 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5292
5293 Minor fixes for signed vs unsigned integers.
5294 * character.h (MAYBE_UNIFY_CHAR):
5295 * charset.c (maybe_unify_char):
5296 * keyboard.c (read_char, reorder_modifiers):
5297 XINT -> XFASTINT, since the integer must be nonnegative.
5298 * ftfont.c (ftfont_spec_pattern):
5299 * keymap.c (access_keymap, silly_event_symbol_error):
5300 XUINT -> XFASTINT, since the integer must be nonnegative.
5301 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5302 since it makes no difference and we prefer signed.
5303 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5304 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5305 nonnegative.
5306
5307 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5308
5309 * window.h (Fwindow_frame): Declare.
5310
5311 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5312
5313 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5314 (SPARE_MEMORY): Always define.
5315 (LARGE_REQUEST): Remove.
5316 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5317
5318 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5319
5320 * lisp.h: Move EXFUNS for Fframe_root_window,
5321 Fframe_first_window and Fset_frame_selected_window to window.h.
5322
5323 * window.h: Move EXFUNS for Fframe_root_window,
5324 Fframe_first_window and Fset_frame_selected_window here from
5325 lisp.h.
5326
5327 * frame.c (Fwindow_frame, Fframe_first_window)
5328 (Fframe_root_window, Fframe_selected_window)
5329 (Fset_frame_selected_window): Move to window.c.
5330 (Factive_minibuffer_window): Move to minibuf.c.
5331 (Fother_visible_frames_p): New function.
5332
5333 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5334
5335 * window.c (decode_window, decode_any_window): Move up in code.
5336 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5337 (inhibit_frame_unsplittable): Remove unused variable.
5338 (Fwindow_buffer): Move up and rewrite doc-string.
5339 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5340 (Fwindow_prev): New functions.
5341 (Fwindow_frame): Move here from frame.c. Accept any window as
5342 argument.
5343 (Fframe_root_window, Fframe_first_window)
5344 (Fframe_selected_window): Move here from frame.c. Accept frame
5345 or arbitrary window as argument. Update doc-strings.
5346 (Fminibuffer_window): Move up in code.
5347 (Fwindow_minibuffer_p): Move up in code and simplify.
5348 (Fset_frame_selected_window): Move here from frame.c.
5349 Marginal rewrite.
5350 (Fselected_window, select_window, Fselect_window): Move up in
5351 code. Minor doc-string fixes.
5352
5353 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5354
5355 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5356 Do not assume that spare memory exists; that assumption is valid
5357 only if SYSTEM_MALLOC.
5358 (LARGE_REQUEST): New macro, so that the issue of large requests
5359 is separated from the issue of spare memory.
5360
5361 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5362
5363 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5364 format. (Bug#8806)
5365
5366 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5367
5368 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5369 before statements.
5370
5371 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5372
5373 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5374
5375 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5376
5377 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5378 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5379
5380 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5381
5382 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5383
5384 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5385
5386 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5387 (x_clipboard_manager_save): Add return value.
5388 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5389 New error handlers.
5390 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5391 Obey Vx_select_enable_clipboard_manager. Catch errors in
5392 x_clipboard_manager_save (Bug#8779).
5393 (Vx_select_enable_clipboard_manager): New variable.
5394 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5395
5396 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5397
5398 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5399
5400 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5401
5402 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5403 in the current matrix if keep_current_p is non-zero.
5404
5405 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5406
5407 * bidi.c (bidi_level_of_next_char): Fix last change.
5408
5409 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5410
5411 Support bidi reordering of text covered by display properties.
5412
5413 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5414 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5415 (bidi_cache_search, bidi_cache_iterator_state)
5416 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5417 (bidi_level_of_next_char, bidi_move_to_visually_next):
5418 Support character positions inside a run of characters covered by a
5419 display string.
5420 (bidi_paragraph_init, bidi_resolve_explicit_1)
5421 (bidi_level_of_next_char): Call bidi_fetch_char and
5422 bidi_fetch_char_advance instead of FETCH_CHAR and
5423 FETCH_CHAR_ADVANCE.
5424 (bidi_init_it): Initialize new members.
5425 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5426 definitions.
5427 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5428 instead of using explicit *_CHAR codes.
5429 (bidi_resolve_explicit, bidi_resolve_weak):
5430 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5431 bidirectional text is supported only in multibyte buffers.
5432 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5433 it to initialize the frame_window_p member of struct bidi_it.
5434 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5435 (bidi_resolve_explicit, bidi_resolve_weak)
5436 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5437 bidi_it->nchars is non-positive.
5438 (bidi_level_of_next_char): Don't try to lookup the cache for the
5439 next/previous character if nothing is cached there yet, or if we
5440 were just reseat()'ed to a new position.
5441
5442 * xdisp.c (set_cursor_from_row): Set start and stop points
5443 according to the row's direction when priming the loop that looks
5444 for the glyph on which to display cursor.
5445 (single_display_spec_intangible_p): Function deleted.
5446 (display_prop_intangible_p): Reimplement to call
5447 handle_display_spec instead of single_display_spec_intangible_p.
5448 Accept 3 additional arguments needed by handle_display_spec.
5449 This fixes incorrect cursor motion across display property with complex
5450 values: lists, `(when COND...)' forms, etc.
5451 (single_display_spec_string_p): Support property values that are
5452 lists with the argument STRING its top-level element.
5453 (display_prop_string_p): Fix the condition for processing a
5454 property that is a list to be consistent with handle_display_spec.
5455 (handle_display_spec): New function, refactored from the
5456 last portion of handle_display_prop.
5457 (compute_display_string_pos): Accept additional argument
5458 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5459 value of a `display' property is a "replacing spec".
5460 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5461 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5462 the display property, but just return a value indicating whether
5463 the display property will replace the characters it covers.
5464 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5465 frame_window_p members of struct bidi_it.
5466 (compute_display_string_pos, compute_display_string_end):
5467 New functions.
5468 (push_it): Accept second argument POSITION, where pop_it should
5469 jump to continue iteration.
5470 (reseat_1): Initialize bidi_it.disp_pos.
5471
5472 * keyboard.c (adjust_point_for_property): Adjust the call to
5473 display_prop_intangible_p to its new signature.
5474
5475 * dispextern.h (struct bidi_it): New member frame_window_p.
5476 (bidi_init_it): Update prototypes.
5477 (display_prop_intangible_p): Update prototype.
5478 (compute_display_string_pos, compute_display_string_end):
5479 Declare prototypes.
5480 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5481 EMACS_INT.
5482
5483 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5484
5485 Malloc failure behavior now depends on size of allocation.
5486 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5487 * lisp.h: Change signatures accordingly.
5488 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5489 All callers changed. (Bug#8762)
5490
5491 * gnutls.c: Use Emacs's memory allocators.
5492 Without this change, the gnutls library would invoke malloc etc.
5493 directly, which causes problems on non-SYNC_INPUT hosts, and which
5494 runs afoul of improving memory_full behavior. (Bug#8761)
5495 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5496 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5497 xfree instead of the default malloc, realloc, free.
5498 (Fgnutls_boot): No need to check for memory allocation failure,
5499 since xmalloc does that for us.
5500
5501 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5502 * category.c (hash_get_category_set):
5503 * ccl.c (ccl_driver):
5504 * charset.c (Fdefine_charset_internal):
5505 * charset.h (struct charset.hash_index):
5506 * composite.c (get_composition_id, gstring_lookup_cache)
5507 (composition_gstring_put_cache):
5508 * composite.h (struct composition.hash_index):
5509 * dispextern.h (struct image.hash):
5510 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5511 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5512 (hashfn_equal, hashfn_user_defined, make_hash_table)
5513 (maybe_resize_hash_table, hash_lookup, hash_put)
5514 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5515 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5516 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5517 * image.c (make_image, search_image_cache, lookup_image)
5518 (xpm_put_color_table_h):
5519 * lisp.h (struct Lisp_Hash_Table):
5520 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5521 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5522 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5523 * alloc.c (allocate_vectorlike):
5524 Check for overflow in vector size calculations.
5525 * ccl.c (ccl_driver):
5526 Check for overflow when converting EMACS_INT to int.
5527 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5528 need to be updated by these changes.
5529 * fns.c (make_hash_table, maybe_resize_hash_table):
5530 Check for integer overflow with large hash tables.
5531 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5532 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5533 (SXHASH_REDUCE): New macro.
5534 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5535 Use it instead of discarding useful hash info with large hash values.
5536 (sxhash_float): New function.
5537 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5538 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5539 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5540 Rewrite to use FIXNUM_BITS, as this simplifies things.
5541 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5542 Adjust signatures to match updated version of code.
5543 (consing_since_gc): Now EMACS_INT, since a single hash table can
5544 use more than INT_MAX bytes.
5545
5546 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5547
5548 Make it possible to build with GCC-4.6+ -O2 -flto.
5549
5550 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5551
5552 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5553
5554 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5555 Call minibuffer-inactive-mode.
5556
5557 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5558
5559 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5560 Update dependencies.
5561
5562 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5563
5564 * data.c (init_data): Remove code for UTS, this system is not
5565 supported anymore.
5566
5567 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5568
5569 Don't force ./temacs to start in terminal mode.
5570
5571 * frame.c (make_initial_frame): Initialize faces in all cases, not
5572 only when CANNOT_DUMP is defined.
5573 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5574
5575 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5576
5577 * dispnew.c (add_window_display_history): Use const for the string
5578 pointer. Remove declaration, not needed.
5579
5580 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5581
5582 Use 'inline', not 'INLINE'.
5583 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5584 * alloc.c, fontset.c (INLINE): Remove.
5585 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5586 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5587 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5588 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5589 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5590
5591 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5592
5593 Make it possible to run ./temacs.
5594
5595 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5596 syms_of_callproc does the same thing. Remove test for
5597 "initialized", do it in the caller.
5598 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5599
5600 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5601
5602 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5603 (read_minibuf): Use get_minibuffer.
5604 (syms_of_minibuf): Use DEFSYM.
5605 (Qmetadata): New var.
5606 * data.c (Qbuffer): Don't make it static.
5607 (syms_of_data): Use DEFSYM.
5608
5609 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5610
5611 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5612 (CCL_CODE_MIN): New macro.
5613
5614 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5615
5616 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5617
5618 * eval.c (Qdebug): Now static.
5619 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5620 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5621 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5622
5623 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5624
5625 * image.c: Various fixes to ImageMagick code comments.
5626 (Fimagemagick_types): Doc fix.
5627
5628 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5629
5630 Minor fixes prompted by GCC 4.6.0 warnings.
5631
5632 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5633
5634 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5635 (x_clipboard_manager_save_all): Move extern decl to ...
5636 * xterm.h: ... here, so that it can be checked for consistency.
5637
5638 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5639
5640 * xselect.c (x_clipboard_manager_save_frame)
5641 (x_clipboard_manager_save_all): New functions.
5642 (Fx_clipboard_manager_save): Lisp function deleted.
5643
5644 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5645 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5646
5647 * xterm.h: Update prototype.
5648
5649 2011-05-28 William Xu <william.xwl@gmail.com>
5650
5651 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5652 exiting (Bug#8239).
5653
5654 2011-05-28 Jim Meyering <meyering@redhat.com>
5655
5656 Avoid a sign-extension bug in crypto_hash_function.
5657 * fns.c (to_uchar): Define.
5658 (crypto_hash_function): Use it to convert some newly-signed
5659 variables to unsigned, to avoid sign-extension bugs. For example,
5660 without this change, (md5 "truc") would evaluate to
5661 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5662 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5663 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5664
5665 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5666
5667 Integer overflow fixes.
5668
5669 * dbusbind.c: Serial number integer overflow fixes.
5670 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5671 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5672 to hold a serial number that is too large for a fixnum.
5673 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5674 Check for serial numbers out of range. Decode any serial number
5675 that was so large that it became a float. (Bug#8722)
5676
5677 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5678 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5679 Use XFASTINT rather than XUINT when numbers are nonnegative.
5680 (xd_append_arg, Fdbus_method_return_internal):
5681 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5682 arguments, check that Lisp number is nonnegative, rather than
5683 silently wrapping negative numbers around. (Bug#8722)
5684 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5685 (Bug#8722)
5686
5687 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5688
5689 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5690
5691 ccl: Add integer overflow checks.
5692 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5693 (IN_INT_RANGE): New macros.
5694 (ccl_driver): Use them to check for integer overflow when
5695 decoding a CCL program. Many of the new checks are whether XINT (x)
5696 fits in int; it doesn't always, on 64-bit hosts. The new version
5697 doesn't catch all possible integer overflows, but it's an
5698 improvement. (Bug#8719)
5699
5700 * alloc.c (make_event_array): Use XINT, not XUINT.
5701 There's no need for unsigned here.
5702
5703 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5704 This follows up to the 2011-05-06 change that substituted uintptr_t
5705 for EMACS_INT. This case wasn't caught back then.
5706
5707 Rework Fformat to avoid integer overflow issues.
5708 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5709 now (part of C89). Include <verify.h>.
5710 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5711 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5712 (Fformat): Avoid the prepass trying to compute sizes; it was only
5713 approximate and thus did not catch overflow reliably. Instead, walk
5714 through the format just once, formatting and computing sizes as we go,
5715 checking for integer overflow at every step, and allocating a larger
5716 buffer as needed. Keep track separately whether the format is
5717 multibyte. Keep only the most-recently calculated precision, rather
5718 than them all. Record whether each argument has been converted to
5719 string. Use EMACS_INT, not int, for byte and char and arg counts.
5720 Support field widths and precisions larger than INT_MAX. Avoid
5721 sprintf's undefined behavior with conversion specifications such as %#d
5722 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5723 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5724 formatting out-of-range floating point numbers with int
5725 formats. (Bug#8668)
5726
5727 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5728
5729 * data.c: Avoid integer truncation in expressions involving floats.
5730 * data.c: Include <intprops.h>.
5731 (arith_driver): When there's an integer overflow in an expression
5732 involving floating point, convert the integers to floating point
5733 so that the resulting value does not suffer from catastrophic
5734 integer truncation. For example, on a 64-bit host (* 4
5735 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5736 Do not rely on undefined behavior after integer overflow.
5737
5738 merge count_size_as_multibyte, parse_str_to_multibyte
5739 * character.c, character.h (count_size_as_multibyte):
5740 Rename from parse_str_to_multibyte; all uses changed.
5741 Check for integer overflow.
5742 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5743 since it's now a duplicate of the other. This is more of
5744 a character than a buffer op, so better that it's in character.c.
5745 * fns.c, print.c: Adjust to above changes.
5746
5747 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5748
5749 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5750
5751 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5752
5753 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5754 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5755 (x_clipboard_manager_save): Now static.
5756 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5757
5758 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5759 (crypto_hash_function): Now static.
5760 Fix pointer signedness problems. Avoid unnecessary initializations.
5761
5762 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5763
5764 * termhooks.h (Vselection_alist): Make it terminal-local.
5765
5766 * terminal.c (create_terminal): Initialize it.
5767
5768 * xselect.c: Support for clipboard managers.
5769 (Vselection_alist): Move to termhooks.h as terminal-local var.
5770 (LOCAL_SELECTION): New macro.
5771 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5772 (symbol_to_x_atom): Remove gratuitous arg.
5773 (x_handle_selection_request, lisp_data_to_selection_data)
5774 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5775 (x_own_selection, x_get_local_selection, x_convert_selection):
5776 New arg, specifying work frame. Use terminal-local Vselection_alist.
5777 (some_frame_on_display): Delete unused function.
5778 (Fx_own_selection_internal, Fx_get_selection_internal)
5779 (Fx_disown_selection_internal, Fx_selection_owner_p)
5780 (Fx_selection_exists_p): New optional frame arg.
5781 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5782 (x_handle_selection_clear): Don't treat other terminals with the
5783 same keyboard specially. Use the terminal-local Vselection_alist.
5784 (x_clear_frame_selections): Use Frun_hook_with_args.
5785
5786 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5787
5788 * xterm.h: Add support for those atoms.
5789
5790 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5791
5792 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5793 (converted_selections, conversion_fail_tag): New global variables.
5794 (x_selection_request_lisp_error): Free the above.
5795 (x_get_local_selection): Remove unnecessary code.
5796 (x_reply_selection_request): Args changed; handle arbitrary array
5797 of converted selections stored in converted_selections.
5798 Separate the XChangeProperty and SelectionNotify steps.
5799 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5800 (x_convert_selection): New function.
5801 (x_handle_selection_event): Simplify.
5802 (x_get_foreign_selection): Don't ignore incoming requests while
5803 waiting for an answer; this will fail when we implement
5804 SAVE_TARGETS, and seems unnecessary anyway.
5805 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5806 (Vx_sent_selection_functions): Doc fix.
5807
5808 2011-05-26 Leo Liu <sdl.web@gmail.com>
5809
5810 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5811
5812 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5813
5814 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5815
5816 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5817 for fringe update if it has periodic bitmap.
5818 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5819 and fringe_bitmap_periodic_p.
5820
5821 * fringe.c (get_fringe_bitmap_data): New function.
5822 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5823 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5824 row. Mark glyph row for fringe update if periodicity changed.
5825
5826 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5827 for fringe update unless it has periodic bitmap.
5828
5829 2011-05-25 Kenichi Handa <handa@m17n.org>
5830
5831 * xdisp.c (get_next_display_element): Set correct it->face_id for
5832 a static composition.
5833
5834 2011-05-24 Leo Liu <sdl.web@gmail.com>
5835
5836 * deps.mk (fns.o):
5837 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5838
5839 * fns.c (crypto_hash_function, Fsha1): New function.
5840 (Fmd5): Use crypto_hash_function.
5841 (syms_of_fns): Add Ssha1.
5842
5843 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5844
5845 * gnutls.c: Remove unused macros.
5846 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5847 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5848 Remove macros that are defined and never used.
5849 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5850
5851 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5852
5853 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5854 (Fx_get_selection_internal): Minor cleanup.
5855 (Fx_own_selection_internal): Rename arguments for consistency with
5856 select.el.
5857
5858 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5859
5860 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5861
5862 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5863
5864 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5865
5866 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5867
5868 * dispnew.c (scrolling_window): Don't exclude the case that the
5869 last enabled row in the desired matrix touches the bottom boundary.
5870
5871 2011-05-21 Glenn Morris <rgm@gnu.org>
5872
5873 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5874 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5875 and add some more files.
5876
5877 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5878
5879 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5880 report_file_error introduced by the change from 2011-05-07.
5881
5882 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5883
5884 * systime.h (Time): Define only if emacs is defined.
5885 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5886 where the include path doesn't have X11/X.h by default. See
5887 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5888
5889 2011-05-20 Kenichi Handa <handa@m17n.org>
5890
5891 * composite.c (find_automatic_composition): Fix previous change.
5892
5893 2011-05-20 Glenn Morris <rgm@gnu.org>
5894
5895 * lisp.mk: New file, split from Makefile.in.
5896 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5897 (shortlisp): Remove.
5898 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5899
5900 2011-05-19 Glenn Morris <rgm@gnu.org>
5901
5902 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5903 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5904 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5905 (lisp): Set the order to that of loadup.el.
5906 (shortlisp): Make it a copy of $lisp.
5907 (SOME_MACHINE_LISP): Remove.
5908 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5909 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5910
5911 2011-05-18 Kenichi Handa <handa@m17n.org>
5912
5913 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5914 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5915 (find_automatic_composition): Mostly rewrite for efficiency.
5916
5917 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5918
5919 * makefile.w32-in: Update dependencies.
5920
5921 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5922
5923 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5924 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5925
5926 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5927
5928 Fix some integer overflow issues, such as string length overflow.
5929
5930 * insdel.c (count_size_as_multibyte): Check for string overflow.
5931
5932 * character.c (lisp_string_width): Check for string overflow.
5933 Use EMACS_INT, not int, for string indexes and lengths; in
5934 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5935 the resulting string length overflows an EMACS_INT; instead,
5936 report a string overflow if no precision given. When checking for
5937 precision exhaustion, use a check that cannot possibly have
5938 integer overflow. (Bug#8675)
5939 * character.h (lisp_string_width): Adjust to new signature.
5940
5941 * alloc.c (string_overflow): New function.
5942 (Fmake_string): Use it. This doesn't change behavior, but saves
5943 a few bytes and will simplify future changes.
5944 * character.c (string_escape_byte8): Likewise.
5945 * lisp.h (string_overflow): New decl.
5946
5947 Fixups, following up to the user-interface timestamp change.
5948 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5949 for UI timestamps, instead of unsigned long.
5950 * msdos.c (mouse_get_pos): Likewise.
5951 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5952 * w32gui.h (Time): Define by including "systime.h" rather than by
5953 declaring it ourselves. (Bug#8664)
5954
5955 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5956 * image.c (clear_image_cache): Likewise.
5957
5958 * term.c (term_mouse_position): Don't assume time_t wraparound.
5959
5960 Be more systematic about user-interface timestamps.
5961 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5962 and sometimes 'EMACS_UINT', to represent these timestamps.
5963 This change causes it to use 'Time' uniformly, as that's what X uses.
5964 This makes the code easier to follow, and makes it easier to catch
5965 integer overflow bugs such as Bug#8664.
5966 * frame.c (Fmouse_position, Fmouse_pixel_position):
5967 Use Time, not unsigned long, for user-interface timestamps.
5968 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5969 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5970 * keyboard.h (last_event_timestamp): Likewise.
5971 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5972 * menu.h (xmenu_show): Likewise.
5973 * term.c (term_mouse_position): Likewise.
5974 * termhooks.h (struct input_event.timestamp): Likewise.
5975 (struct terminal.mouse_position_hook): Likewise.
5976 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5977 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5978 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5979 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5980 what it was before.
5981 * menu.h, termhooks.h: Include "systime.h", for Time.
5982
5983 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5984 Don't assume that the difference between two unsigned long values
5985 can fit into an integer. At this point, we know button_down_time
5986 <= event->timestamp, so the difference must be nonnegative, so
5987 there's no need to cast the result if double-click-time is
5988 nonnegative, as it should be; check that it's nonnegative, just in
5989 case. This bug is triggered when events are more than 2**31 ms
5990 apart (about 25 days). (Bug#8664)
5991
5992 * xselect.c (last_event_timestamp): Remove duplicate decl.
5993 (x_own_selection): Remove needless cast to unsigned long.
5994
5995 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5996 that always fit in int. Use a sentinel instead of a counter, to
5997 avoid a temp and to allay GCC's concerns about possible int overflow.
5998 * frame.h (struct frame): Use int for menu_bar_items_used
5999 instead of EMACS_INT, since it always fits in int.
6000
6001 * menu.c (grow_menu_items): Check for int overflow.
6002
6003 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6004
6005 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6006 Before, the code was not consistent. These values cannot exceed
6007 2**31 - 1 so there's no need to make them unsigned.
6008 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6009 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6010 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6011 as modifiers.
6012 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6013
6014 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6015 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6016 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6017 presumably because the widths might not match.
6018
6019 * window.c (size_window): Avoid needless test at loop start.
6020
6021 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6022
6023 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6024
6025 2011-05-12 Drew Adams <drew.adams@oracle.com>
6026
6027 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6028
6029 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6030
6031 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6032 `width' to `bar_area_x' and `bar_area_width', respectively.
6033 (x_scroll_run): Take account of fringe background extension.
6034
6035 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6036 Rename local vars `left' and `width' to `bar_area_x' and
6037 `bar_area_width', respectively.
6038 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6039 background extension.
6040
6041 2011-05-10 Jim Meyering <meyering@redhat.com>
6042
6043 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6044
6045 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6046
6047 * image.c (Finit_image_library): Return t for built-in image types,
6048 like pbm and xbm. (Bug#8640)
6049
6050 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6051
6052 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6053
6054 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6055
6056 * w32console.c (Fset_screen_color): Doc fix.
6057 (Fget_screen_color): New function.
6058 (syms_of_ntterm): Defsubr it.
6059
6060 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6061 unlink the temporary file if Fcall_process didn't create it in the
6062 first place.
6063 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6064 child process will be redirected to a file specified with `:file'.
6065 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6066 cue to call_process_cleanup not to close that handle.
6067
6068 2011-05-07 Ben Key <bkey76@gmail.com>
6069
6070 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6071 one of two shell specific rules, either bootstrap-temacs-CMD or
6072 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6073 to the previous implementation of the bootstrap-temacs rule.
6074 The bootstrap-temacs-CMD rule is similar to the previous
6075 implementation of the bootstrap-temacs rule except that it
6076 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6077 variable.
6078
6079 These changes, along with some changes to nt/configure.bat,
6080 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6081 earlier fix to add support for --cflags and --ldflags options
6082 that include quotes so that it works whether make uses cmd or
6083 sh as the shell.
6084
6085 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6086
6087 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6088 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6089 is a constant.
6090 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6091 a string. Handle both cases.
6092 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6093 (Fdbus_register_method): Use Qinvalid_function.
6094
6095 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6096
6097 * makefile.w32-in: Update dependencies.
6098 (LISP_H): Add inttypes.h and stdin.h.
6099 (PROCESS_H): Add unistd.h.
6100
6101 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6102
6103 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6104 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6105
6106 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6107
6108 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6109
6110 * term.c (vfatal): Remove stray call to va_end.
6111 It's not needed and the C Standard doesn't allow it here anyway.
6112
6113 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6114 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6115
6116 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6117 bytes.
6118
6119 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6120
6121 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6122
6123 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6124
6125 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6126
6127 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6128
6129 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6130 * charset.c (Fdefine_charset_internal): Don't initialize
6131 charset.code_space[15]. The value was garbage, on hosts with
6132 32-bit int (Bug#8600).
6133
6134 * lread.c (read_integer): Be more consistent with string-to-number.
6135 Use string_to_number to do the actual conversion; this avoids
6136 rounding errors and fixes some other screwups. Without this fix,
6137 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6138 (digit_to_number): Move earlier, for benefit of read_integer.
6139 Return -1 if the digit is out of range for the base, -2 if it is
6140 not a digit in any supported base. (Bug#8602)
6141
6142 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6143
6144 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6145 to match comment at start of function. This also removes a
6146 GCC warning about overflow in a 32+64-bit port.
6147
6148 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6149
6150 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6151 Reported by Stefan Monnier in
6152 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6153 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6154 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6155
6156 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6157 (EMACS_UINTPTR): Likewise, with uintptr_t.
6158
6159 * lisp.h: Prefer 64-bit EMACS_INT if available.
6160 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6161 on 32-bit hosts that have 64-bit int, so that they can access
6162 large files.
6163 However, temporarily disable this change unless the temporary
6164 symbol WIDE_EMACS_INT is defined.
6165
6166 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6167
6168 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6169 This removes an assumption that EMACS_INT and long are the same
6170 width as pointers. The assumption is true for Emacs porting targets
6171 now, but we want to make other targets possible.
6172 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6173 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6174 In the rest of the code, change types of integers that hold casted
6175 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6176 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6177 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6178 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6179 No need to cast type when ORing.
6180 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6181 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6182 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6183 assume EMACS_INT is the same width as char *.
6184 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6185 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6186 Remove no-longer-needed casts.
6187 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6188 (xg_tool_bar_help_callback, xg_make_tool_item):
6189 Use EMACS_INTPTR to hold an integer
6190 that will be cast to void *; this can avoid a GCC warning
6191 if EMACS_INT is not the same width as void *.
6192 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6193 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6194 (current_message_1, set_message_1):
6195 Use a local to convert to proper width without a cast.
6196 * xmenu.c (dialog_selection_callback): Likewise.
6197
6198 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6199 Also, don't assume VALBITS / RAND_BITS is less than 5,
6200 and don't rely on undefined behavior when shifting a 1 left into
6201 the sign bit.
6202 * lisp.h (get_random): Change signature to match.
6203
6204 * lread.c (hash_string): Use size_t, not int, for hash computation.
6205 Normally we prefer signed values; but hashing is special, because
6206 it's better to use unsigned division on hash table sizes so that
6207 the remainder is nonnegative. Also, size_t is the natural width
6208 for hashing into memory. The previous code used 'int', which doesn't
6209 retain enough info to hash well into very large tables.
6210 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6211
6212 * dbusbind.c: Don't possibly lose pointer info when converting.
6213 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6214 Use XPNTR rather than XHASH, so that the high-order bits of
6215 the pointer aren't lost when converting through void *.
6216
6217 * eval.c (Fautoload): Don't double-shift a pointer.
6218
6219 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6220
6221 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6222
6223 * gnutls.c (DEF_GNUTLS_FN):
6224 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6225
6226 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6227
6228 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6229 marker. (Bug#8610)
6230
6231 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6232
6233 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6234 New version that can reserve upto 2GB of heap space.
6235
6236 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6237
6238 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6239
6240 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6241
6242 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6243 `gnutls_certificate_set_x509_key_file'.
6244
6245 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6246
6247 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6248 Update dependencies.
6249
6250 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6251
6252 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6253 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6254 Remove unused parameter `fildes'.
6255 * process.c (read_process_output, send_process): Don't pass it.
6256
6257 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6258
6259 Fix previous change: the library cache is defined in w32.c.
6260 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6261 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6262
6263 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6264
6265 Implement dynamic loading of GnuTLS on Windows.
6266
6267 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6268 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6269 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6270 Declare.
6271
6272 * gnutls.c (Qgnutls_dll): Define.
6273 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6274 (gnutls_*): Declare function pointers.
6275 (init_gnutls_functions): New function to initialize function pointers.
6276 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6277 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6278 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6279 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6280 (emacs_gnutls_write, emacs_gnutls_read)
6281 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6282 (Fgnutls_available_p): New function.
6283 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6284 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6285 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6286
6287 * image.c: Include w32.h.
6288 (Vimage_type_cache): Delete.
6289 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6290 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6291 (w32_delayed_load): Move to w32.c.
6292
6293 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6294
6295 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6296 (w32_delayed_load): Move from image.c. When loading a library, record
6297 its filename in the :loaded-from property of the library id.
6298 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6299 Initialize and staticpro them.
6300 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6301
6302 * process.c: Include lisp.h before w32.h, not after.
6303 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6304 instead of gnutls_record_check_pending.
6305
6306 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6307
6308 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6309
6310 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6311 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6312 as passed in.
6313
6314 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6315
6316 * xterm.c (x_set_frame_alpha): Do not set property on anything
6317 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6318
6319 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6320
6321 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6322
6323 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6324
6325 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6326 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6327 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6328 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6329 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6330 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6331 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6332 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6333 (Qgnutls_bootprop_callbacks_verify): Make static.
6334
6335 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6336
6337 * callproc.c: Indentation fixup.
6338
6339 * sysdep.c (wait_for_termination_1): Make static.
6340 (wait_for_termination, interruptible_wait_for_termination):
6341 Move after wait_for_termination_1.
6342
6343 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6344
6345 * sysdep.c (interruptible_wait_for_termination): New function
6346 which is like wait_for_termination, but allows keyboard
6347 interruptions.
6348
6349 * callproc.c (Fcall_process): Add (:file "file") as an option for
6350 the STDOUT buffer.
6351 (Fcall_process_region): Ditto.
6352
6353 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6354
6355 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6356 rather than `XVECTOR (FOO)->size'.
6357
6358 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6359 inttypes.h, as a gnulib replacement is used if it not available in
6360 system headers.
6361
6362 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6363
6364 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6365 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6366 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6367
6368 * coding.c (coding_alloc_by_realloc): Error out if destination
6369 will grow beyond MOST_POSITIVE_FIXNUM.
6370 (decode_coding_emacs_mule): Abort if there isn't enough place in
6371 charbuf for the composition carryover bytes. Reserve an extra
6372 space for up to 2 characters produced in a loop.
6373 (decode_coding_iso_2022): Abort if there isn't enough place in
6374 charbuf for the composition carryover bytes.
6375
6376 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6377
6378 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6379 aborting when %lld or %lll format is passed.
6380 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6381 %llo or %llx format is passed. (Bug#8545)
6382
6383 * window.c (window_scroll_line_based): Use a marker instead of
6384 simple variables to record original value of point. (Bug#7952)
6385
6386 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6387 produced by %s or %c overflows available buffer space. (Bug#8545)
6388
6389 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6390
6391 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6392 (SIZE_MAX): Move defn after all includes, as they might #define it.
6393
6394 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6395
6396 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6397
6398 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6399
6400 * keyboard.c (Qdelayed_warnings_hook): Define.
6401 (command_loop_1): Run `delayed-warnings-hook'
6402 if Vdelayed_warnings_list is non-nil.
6403 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6404 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6405
6406 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6407
6408 * doprnt.c (doprnt): Don't return value smaller than the buffer
6409 size if the message was truncated. (Bug#8545).
6410
6411 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6412
6413 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6414 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6415
6416 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6417
6418 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6419
6420 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6421
6422 * makefile.w32-in: Update dependencies.
6423
6424 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6425
6426 Improve `doprnt' and its usage. (Bug#8545)
6427 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6428 `format_end'. Remove support for %l as a conversion specifier.
6429 Don't use xrealloc. Improve diagnostics when the %l size modifier
6430 is used. Update the commentary.
6431
6432 * eval.c (verror): Simplify calculation of size_t.
6433
6434 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6435 messages.
6436
6437 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6438
6439 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6440 change.
6441
6442 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6443
6444 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6445 This makes this file independent of the recent pseudovector change.
6446
6447 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6448
6449 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6450
6451 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6452 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6453 Remove unused local.
6454 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6455
6456 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6457 GCC 4.6.0 optimizes based on type-based alias analysis.
6458 For example, if b is of type struct buffer * and v of type struct
6459 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6460 != &v->size, and therefore "v->size = 1; b->size = 2; return
6461 v->size;" must therefore return 1. This assumption is incorrect
6462 for Emacs, since it type-puns struct Lisp_Vector * with many other
6463 types. To fix this problem, this patch adds a new type struct
6464 vectorlike_header that documents the constraints on layout of vectors
6465 and pseudovectors, and helps optimizing compilers not get fooled
6466 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6467 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6468 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6469 the size member.
6470 (XSETPVECTYPE): Rewrite in terms of new macro.
6471 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6472 This is a bit clearer, and further avoids the possibility of
6473 undesirable aliasing.
6474 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6475 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6476 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6477 since Lisp_Subr is a special case (no "next" field).
6478 (ASIZE): Now uses header.size rather than size.
6479 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6480 to avoid the hassle of writing XVECTOR (foo)->header.size.
6481 (struct vectorlike_header): New type.
6482 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6483 object, to help avoid aliasing.
6484 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6485 (SUBRP): Likewise, since Lisp_Subr is a special case.
6486 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6487 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6488 (struct Lisp_Hash_Table): Combine first two members into a single
6489 struct vectorlike_header member. All uses of "size" and "next" members
6490 changed to be "header.size" and "header.next".
6491 * buffer.h (struct buffer): Likewise.
6492 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6493 * frame.h (struct frame): Likewise.
6494 * process.h (struct Lisp_Process): Likewise.
6495 * termhooks.h (struct terminal): Likewise.
6496 * window.c (struct save_window_data, struct saved_window): Likewise.
6497 * window.h (struct window): Likewise.
6498 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6499 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6500 * buffer.c (init_buffer_once): Likewise.
6501 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6502 special case.
6503 * process.c (Fformat_network_address): Use local var for size,
6504 for brevity.
6505
6506 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6507
6508 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6509 * data.c (atof): Remove decl; no longer used or needed.
6510 (digit_to_number): Move to lread.c.
6511 (Fstring_to_number): Use new string_to_number function, to be
6512 consistent with how the Lisp reader treats infinities and NaNs.
6513 Do not assume that floating-point numbers represent EMACS_INT
6514 without losing information; this is not true on most 64-bit hosts.
6515 Avoid double-rounding errors, by insisting on integers when
6516 parsing non-base-10 numbers, as the documentation specifies.
6517 * lisp.h (string_to_number): New decl, replacing ...
6518 (isfloat_string): Remove.
6519 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6520 (read1): Do not accept +. and -. as integers; this
6521 appears to have been a coding error. Similarly, do not accept
6522 strings like +-1e0 as floating point numbers. Do not report
6523 overflow for integer overflows unless the base is not 10 which
6524 means we have no simple and reliable way to continue.
6525 Break out the floating-point parsing into a new
6526 function string_to_number, so that Fstring_to_number parses
6527 floating point numbers consistently with the Lisp reader.
6528 (digit_to_number): Move here from data.c. Make it static inline.
6529 (E_CHAR, EXP_INT): Remove, replacing with ...
6530 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6531 (string_to_number): New function, replacing isfloat_string.
6532 This function checks for valid syntax and produces the resulting
6533 Lisp float number too. Rework it so that string-to-number
6534 no longer mishandles examples like "1.0e+". Use strtoumax,
6535 so that overflow for non-base-10 numbers is reported only when
6536 there's no portable and simple way to convert to floating point.
6537
6538 * textprop.c (set_text_properties_1): Rewrite for clarity,
6539 and to avoid GCC warning about integer overflow.
6540
6541 * intervals.h (struct interval): Use EMACS_INT for members
6542 where EMACS_UINT might cause problems. See
6543 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6544 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6545 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6546 All uses changed.
6547 (offset_intervals): Tell GCC not to worry about length overflow
6548 when negating a negative length.
6549
6550 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6551 (overrun_check_free): Likewise.
6552
6553 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6554 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6555 word size.
6556
6557 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6558 (gnutls_make_error): Rename local to avoid shadowing.
6559 (gnutls_emacs_global_deinit): ifdef out; not used.
6560 (Fgnutls_boot): Use const for pointer to readonly storage.
6561 Comment out unused local. Fix pointer signedness problems.
6562
6563 * lread.c (openp): Don't stuff size_t into an 'int'.
6564 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6565 about possible signed overflow.
6566
6567 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6568 (GDK_KEY_g): Don't define if already defined.
6569 (xg_prepare_tooltip): Avoid pointer signedness problem.
6570 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6571
6572 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6573 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6574
6575 * xfns.c (Fx_window_property): Simplify a bit,
6576 to make a bit faster and to avoid GCC 4.6.0 warning.
6577 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6578
6579 * fns.c (internal_equal): Don't assume size_t fits in int.
6580
6581 * alloc.c (compact_small_strings): Tighten assertion a little.
6582
6583 Replace pEd with more-general pI, and fix some printf arg casts.
6584 * lisp.h (pI): New macro, generalizing old pEd macro to other
6585 conversion specifiers. For example, use "...%"pI"d..." rather
6586 than "...%"pEd"...".
6587 (pEd): Remove. All uses replaced with similar uses of pI.
6588 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6589 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6590 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6591 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6592 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6593 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6594 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6595 64-bit hosts.
6596 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6597 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6598 * print.c (safe_debug_print, print_object): Likewise.
6599 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6600 to int.
6601 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6602 avoiding the 0 flag, which is not portable.
6603 * process.c (Fmake_network_process): Use pI to avoid cast.
6604 * region-cache.c (pp_cache): Likewise.
6605 * xdisp.c (decode_mode_spec): Likewise.
6606 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6607 behavior on 64-bit hosts with printf arg.
6608 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6609 (x_stop_queuing_selection_requests): Likewise.
6610 (x_get_window_property): Don't truncate byte count to an 'int'
6611 when tracing.
6612
6613 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6614 here, since it parses constructs like leading '-' and spaces,
6615 which are not wanted; and it overflows with large numbers.
6616 Instead, simply match F[0-9]+, which is what is wanted anyway.
6617
6618 * alloc.c: Remove unportable assumptions about struct layout.
6619 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6620 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6621 (allocate_vectorlike, make_pure_vector): Use the new macros,
6622 plus offsetof, to remove unportable assumptions about struct layout.
6623 These assumptions hold on all porting targets that I know of, but
6624 they are not guaranteed, they're easy to remove, and removing them
6625 makes further changes easier.
6626
6627 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6628 This doesn't fix a bug but makes the code clearer.
6629 (string_overrun_cookie): Now const. Use initializers that
6630 don't formally overflow signed char, to avoid warnings.
6631 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6632 can cause Emacs to crash when string overrun checking is enabled.
6633 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6634 multiple of sizeof (EMACS_INT); it need not be, if
6635 alignof(EMACS_INT) < sizeof (EMACS_INT).
6636 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6637
6638 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6639
6640 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6641
6642 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6643
6644 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6645 supposed to be handshaking. (Bug#8556)
6646 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6647
6648 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6649
6650 * lisp.h (Qdebug): List symbol.
6651 * eval.c (Qdebug): Restore global linkage.
6652 * keyboard.c (debug-on-event): New variable.
6653 (handle_user_signal): Break into debugger when debug-on-event
6654 matches the current signal symbol.
6655
6656 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6657
6658 * alloc.c (check_sblock, check_string_bytes)
6659 (check_string_free_list): Convert to standard C.
6660
6661 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6662
6663 * w32.c (emacs_gnutls_push): Fix typo.
6664
6665 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6666
6667 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6668 "cast to pointer from integer of different size".
6669
6670 Improve doprnt and its use in verror. (Bug#8545)
6671 * doprnt.c (doprnt): Document the set of format control sequences
6672 supported by the function. Use SAFE_ALLOCA instead of always
6673 using `alloca'.
6674
6675 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6676 is one byte too soon. Don't use xrealloc; instead xfree and
6677 xmalloc anew.
6678
6679 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6680
6681 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6682 callbacks stage.
6683
6684 * gnutls.c: Renamed global_initialized to
6685 gnutls_global_initialized. Added internals for the
6686 :verify-hostname-error, :verify-error, and :verify-flags
6687 parameters of `gnutls-boot' and documented those parameters in the
6688 docstring. Start callback support.
6689 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6690 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6691 on error. Return error code.
6692 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6693 (emacs_gnutls_read): Likewise.
6694 (Fgnutls_boot): Return handshake error code.
6695 (emacs_gnutls_handle_error): New function.
6696 (wsaerror_to_errno): Likewise.
6697
6698 * w32.h (emacs_gnutls_pull): Add prototype.
6699 (emacs_gnutls_push): Likewise.
6700
6701 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6702 (emacs_gnutls_push): Likewise.
6703
6704 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6705
6706 * process.c (wait_reading_process_output): Check if GnuTLS
6707 buffered some data internally if no FDs are set for TLS
6708 connections.
6709
6710 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6711 (LIBS): Link to USER_LIBS.
6712 ($(BLD)/gnutls.$(0)): New target.
6713
6714 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6715
6716 * xdisp.c (handle_single_display_spec): Rename the
6717 display_replaced_before_p argument into display_replaced_p, to
6718 make it consistent with the commentary. Fix typos in the
6719 commentary.
6720
6721 * textprop.c (syms_of_textprop): Remove dead code.
6722 (copy_text_properties): Delete obsolete commentary about an
6723 interface that was deleted long ago. Fix typos in the description
6724 of arguments.
6725
6726 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6727 to changes in oldXMenu/XMenu.h from 2011-04-16.
6728 <menu_help_message, prev_menu_help_message>: Constify.
6729 (IT_menu_make_room): menu->help_text is now `const char **';
6730 adjust.
6731
6732 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6733 to changes in oldXMenu/XMenu.h from 2011-04-16.
6734 (struct XMenu): Declare `help_text' `const char **'.
6735
6736 * xfaces.c <Qunspecified>: Make extern again.
6737
6738 * syntax.c: Include sys/types.h before including regex.h, as
6739 required by Posix.
6740
6741 * doc.c (get_doc_string): Improve the format passed to `error'.
6742
6743 * doprnt.c (doprnt): Improve commentary.
6744
6745 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6746
6747 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6748 them with etags.
6749
6750 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6751 changes in globals.h immediately force recompilation.
6752 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6753 $(CURDIR)/s/ms-w32.h.
6754 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6755
6756 * character.c (Fchar_direction): Function deleted.
6757 (syms_of_character): Don't defsubr it.
6758 <char-direction-table>: Deleted.
6759
6760 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6761
6762 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6763 * doprnt.c: Include limits.h.
6764 (SIZE_MAX): New macro.
6765 (doprnt): Return a size_t value. 2nd arg is now size_t.
6766 Many local variables are now size_t instead of int or unsigned.
6767 Improve overflow protection. Support `l' modifier for integer
6768 conversions. Support %l conversion. Don't assume an EMACS_INT
6769 argument for integer conversions and for %c.
6770
6771 * lisp.h (doprnt): Restore prototype.
6772
6773 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6774 $(SRC)/character.h.
6775
6776 * Makefile.in (base_obj): Add back doprnt.o.
6777
6778 * deps.mk (doprnt.o): Add back prerequisites.
6779 (callint.o): Depend on character.h.
6780
6781 * eval.c (internal_lisp_condition_case): Include the handler
6782 representation in the error message.
6783 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6784 when breaking from the loop.
6785
6786 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6787
6788 * callint.c (Fcall_interactively): When displaying error message
6789 about invalid control letter, pass the character's codepoint, not
6790 a pointer to its multibyte form. Improve display of the character
6791 in octal and display also its hex code.
6792
6793 * character.c (char_string): Use %x to display the (unsigned)
6794 codepoint of an invalid character, to avoid displaying a bogus
6795 negative value.
6796
6797 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6798 `error', not SYMBOL_NAME itself.
6799
6800 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6801 character arguments to `error'.
6802
6803 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6804 to `error' in error message about FINAL_CHAR argument. Make sure
6805 FINAL_CHAR is a character, and use %c when it is passed as
6806 argument to `error'.
6807
6808 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6809
6810 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6811
6812 * w32.c: Include <time.h>.
6813 (sys_localtime): New function.
6814
6815 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6816
6817 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6818
6819 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6820
6821 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6822
6823 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6824 zombies (Bug#8467).
6825
6826 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6827
6828 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6829 gl_state.e_property when gl_state.object is Qt.
6830
6831 * insdel.c (make_gap_larger): Remove limitation of buffer size
6832 to <= INT_MAX.
6833
6834 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6835
6836 * xdisp.c (lookup_glyphless_char_display)
6837 (produce_glyphless_glyph): Handle cons cell entry in
6838 glyphless-char-display.
6839 (Vglyphless_char_display): Document it.
6840
6841 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6842 glyphless-char-display.
6843
6844 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6845
6846 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6847
6848 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6849
6850 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6851 definition for no-X builds.
6852
6853 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6854
6855 Static checks with GCC 4.6.0 and non-default toolkits.
6856
6857 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6858
6859 * process.c (keyboard_bit_set): Define only if SIGIO.
6860 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6861 (send_process): Repair possible setjmp clobbering.
6862
6863 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6864
6865 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6866
6867 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6868
6869 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6870 Define only if needed.
6871
6872 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6873 by pacifying GCC about it. Maybe it's time to retire it?
6874 * xfaces.c (USG, __TIMEVAL__): Likewise.
6875
6876 * dispextern.h (struct redisplay_interface): Rename param
6877 to avoid shadowing.
6878 * termhooks.h (struct terminal): Likewise.
6879 * xterm.c (xembed_send_message): Likewise.
6880
6881 * insdel.c (make_gap_smaller): Define only if
6882 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6883
6884 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6885 it.
6886
6887 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6888 so that we aren't warned about unused symbols.
6889
6890 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6891
6892 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6893
6894 * xfns.c (x_real_positions): Mark locals as initialized.
6895
6896 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6897
6898 * xterm.c: Fix problems found by static analysis with other toolkits.
6899 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6900 (x_dispatch_event): Declare static if USE_GTK, and
6901 define if USE_GTK || USE_X_TOOLKIT.
6902 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6903 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6904 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6905 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6906
6907 * xmenu.c (menu_help_callback): Pointer type fixes.
6908 Use const pointers when pointing at readonly data. Avoid pointer
6909 signedness clashes.
6910 (FALSE): Remove unused macro.
6911 (update_frame_menubar): Remove unused decl.
6912
6913 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6914
6915 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6916 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6917 (single_menu_item): Rename local to avoid shadowing.
6918
6919 * keyboard.c (make_lispy_event): Remove unused local var.
6920
6921 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6922 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6923
6924 * bitmaps: Change bitmaps from unsigned char back to the X11
6925 compatible char. Avoid the old compiler warnings about
6926 out-of-range initializers by using, for example, '\xab' rather
6927 than 0xab.
6928
6929 * xgselect.c (xgselect_initialize): Check vs interface
6930 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6931
6932 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6933
6934 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6935 to read-only memory.
6936
6937 * fns.c (vector): Remove; this old hack is no longer needed.
6938
6939 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6940 Remove unused var.
6941 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6942
6943 * xrdb.c (x_load_resources): Omit unused local.
6944
6945 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6946 (x_window): Rename locals to avoid shadowing.
6947 (USG): Use the kludged USG macro, to pacify gcc.
6948
6949 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6950 (x_term_init): Remove local to avoid shadowing.
6951
6952 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6953
6954 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6955 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6956
6957 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6958
6959 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6960
6961 Fix regex.c, syntax.c and friends for buffers > 2GB.
6962 * syntax.h (struct gl_state_s): Declare character position members
6963 EMACS_INT.
6964
6965 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6966
6967 * textprop.c (verify_interval_modification, interval_of):
6968 Declare arguments EMACS_INT.
6969
6970 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6971 EMACS_INT.
6972
6973 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6974
6975 * indent.c (Fvertical_motion): Local variable it_start is now
6976 EMACS_INT.
6977
6978 * regex.c (re_match, re_match_2, re_match_2_internal)
6979 (bcmp_translate, regcomp, regexec, print_double_string)
6980 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6981 (re_compile_pattern, re_exec): Declare arguments and local
6982 variables `size_t' and `ssize_t' and return values `regoff_t', as
6983 appropriate.
6984 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6985 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6986 <compile_stack_type>: `size' and `avail' are now `size_t'.
6987
6988 * regex.h <regoff_t>: Use ssize_t, not int.
6989 (re_search, re_search_2, re_match, re_match_2): Arguments that
6990 specify buffer/string position and length are now ssize_t and
6991 size_t. Return type is regoff_t.
6992
6993 2011-04-16 Ben Key <bkey76@gmail.com>
6994
6995 * nsfont.m: Fixed bugs in ns_get_family and
6996 ns_descriptor_to_entity that were caused by using free to
6997 deallocate memory blocks that were allocated by xmalloc (via
6998 xstrdup). This caused Emacs to crash when compiled with
6999 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7000 --enable-checking=xmallocoverrun). xfree is now used to
7001 deallocate these memory blocks.
7002
7003 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7004
7005 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7006
7007 emacs_write: Accept and return EMACS_INT for sizes.
7008 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7009 et seq.
7010 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7011 Accept and return EMACS_INT.
7012 (emacs_gnutls_write): Return the number of bytes written on
7013 partial writes.
7014 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7015 (emacs_read, emacs_write): Remove check for negative size, as the
7016 Emacs source code has been audited now.
7017 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7018 (emacs_read, emacs_write): Use it.
7019 * process.c (send_process): Adjust to the new signatures of
7020 emacs_write and emacs_gnutls_write. Do not attempt to store
7021 a byte offset into an 'int'; it might overflow.
7022 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7023
7024 * sound.c: Don't assume sizes fit in 'int'.
7025 (struct sound_device.period_size, alsa_period_size):
7026 Return EMACS_INT, not int.
7027 (struct sound_device.write, vox_write, alsa_write):
7028 Accept EMACS_INT, not int.
7029 (wav_play, au_play): Use EMACS_INT to store sizes and to
7030 record read return values.
7031
7032 2011-04-15 Ben Key <bkey76@gmail.com>
7033
7034 * keyboard.c (Qundefined): Don't declare static since it is used
7035 in nsfns.m.
7036 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7037 static since they are used in nsfont.m.
7038
7039 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7040
7041 * process.c (Qprocessp): Don't declare static.
7042 * lisp.h (Qprocessp): Declare again.
7043
7044 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7045
7046 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7047
7048 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7049
7050 Improve C-level modularity by making more things 'static'.
7051
7052 Don't publish debugger-only interfaces to other modules.
7053 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7054 (verify_bytepos, count_markers): Move decls to the only modules
7055 that need them.
7056 * region-cache.h (pp_cache): Likewise.
7057 * window.h (check_all_windows): Likewise.
7058 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7059
7060 * sysdep.c (croak): Now static, if
7061 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7062 * syssignal.h (croak): Declare only if not static.
7063
7064 * alloc.c (refill_memory_reserve): Now static if
7065 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7066 * lisp.h (refill_memory_reserve): Declare only if not static.
7067
7068 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7069 Define only if USE_LUCID.
7070
7071 * xrdb.c (x_customization_string, x_rm_string): Now static.
7072
7073 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7074 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7075
7076 * xdisp.c (draw_row_with_mouse_face): Now static.
7077 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7078
7079 * window.h (check_all_windows): Mark externally visible.
7080
7081 * window.c (window_deletion_count): Now static.
7082
7083 * undo.c: Make symbols static if they're not exported.
7084 (last_undo_buffer, last_boundary_position, pending_boundary):
7085 Now static.
7086
7087 * textprop.c (interval_insert_behind_hooks): Now static.
7088 (interval_insert_in_front_hooks): Likewise.
7089
7090 * term.c: Make symbols static if they're not exported.
7091 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7092 (max_frame_lines, tty_set_terminal_modes):
7093 (tty_reset_terminal_modes, tty_turn_off_highlight):
7094 (get_tty_terminal): Now static.
7095 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7096 * termhooks.h (term_mouse_moveto): Do not declare if
7097 HAVE_WINDOW_SYSTEM.
7098 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7099 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7100
7101 * sysdep.c: Make symbols static if they're not exported.
7102 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7103 Now static.
7104 (sigprocmask_set, full_mask): Remove; unused.
7105 (wait_debugging): Mark as visible.
7106 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7107 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7108
7109 * syntax.c (syntax_temp): Define only if !__GNUC__.
7110
7111 * sound.c (current_sound_device, current_sound): Now static.
7112
7113 * search.c (searchbufs, searchbuf_head): Now static.
7114
7115 * scroll.c (scroll_cost): Remove; unused.
7116 * dispextern.h (scroll_cost): Remove decl.
7117
7118 * region-cache.h (pp_cache): Mark as externally visible.
7119
7120 * process.c: Make symbols static if they're not exported.
7121 (process_tick, update_tick, create_process, chan_process):
7122 (Vprocess_alist, proc_buffered_char, datagram_access):
7123 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7124 (deactivate_process): Mark defn as static, as well as decl.
7125 * lisp.h (create_process): Remove decl.
7126 * process.h (chan_process, Vprocess_alist): Remove decls.
7127
7128 * print.c: Make symbols static if they're not exported.
7129 (print_depth, new_backquote_output, being_printed, print_buffer):
7130 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7131 (print_interval, print_number_index, initial_stderr_stream):
7132 Now static.
7133 * lisp.h (Fprinc): Remove decl.
7134 (debug_output_compilation_hack): Mark as externally visible.
7135
7136 * sysdep.c (croak): Move decl from here to syssignal.h.
7137 * syssignal.h (croak): Put it here, so the API can be checked when
7138 'croak' is called from dissociate_if_controlling_tty.
7139
7140 * minibuf.c: Make symbols static if they're not exported.
7141 (minibuf_save_list, choose_minibuf_frame): Now static.
7142 * lisp.h (choose_minibuf_frame): Remove decl.
7143
7144 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7145
7146 * lread.c: Make symbols static if they're not exported.
7147 (read_objects, initial_obarray, oblookup_last_bucket_number):
7148 Now static.
7149 (make_symbol): Remove; unused.
7150 * lisp.h (initial_obarray, make_symbol): Remove decls.
7151
7152 * keyboard.c: Make symbols static if they're not exported.
7153 (single_kboard, recent_keys_index, total_keys, recent_keys):
7154 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7155 (this_single_command_key_start, echoing, last_auto_save):
7156 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7157 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7158 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7159 (Vlispy_mouse_stem, double_click_count):
7160 Now static.
7161 (force_auto_save_soon): Define only if SIGDANGER.
7162 (ignore_mouse_drag_p): Now static if
7163 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7164 (print_help): Remove; unused.
7165 (stop_character, last_timer_event): Mark as externally visible.
7166 * keyboard.h (ignore_mouse_drag_p): Declare only if
7167 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7168 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7169 * lisp.h (echoing): Remove decl.
7170 (force_auto_save_soon): Declare only if SIGDANGER.
7171 * xdisp.c (redisplay_window): Simplify code, to make it more
7172 obvious that ignore_mouse_drag_p is not accessed if !defined
7173 USE_GTK && !defined HAVE_NS.
7174
7175 * intervals.c: Make symbols static if they're not exported.
7176 (merge_properties_sticky, merge_interval_right, delete_interval):
7177 Now static.
7178 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7179
7180 * insdel.c: Make symbols static if they're not exported.
7181 However, leave prepare_to_modify_buffer alone. It's never
7182 called from outside this function, but that appears to be a bug.
7183 (combine_after_change_list, combine_after_change_buffer):
7184 (adjust_after_replace, signal_before_change): Now static.
7185 (adjust_after_replace_noundo): Remove; unused.
7186 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7187 (signal_before_change): Remove decls.
7188
7189 * indent.c (val_compute_motion, val_vmotion): Now static.
7190
7191 * image.c: Make symbols static if they're not exported.
7192 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7193 if USE_GTK.
7194 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7195 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7196
7197 * fringe.c (standard_bitmaps): Now static.
7198 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7199
7200 * frame.c: Make symbols static if they're not exported.
7201 (x_report_frame_params, make_terminal_frame): Now static.
7202 (get_frame_param): Now static, unless HAVE_NS.
7203 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7204 (x_get_resource_string): Remove; not used.
7205 * frame.h (make_terminal_frame, x_report_frame_params):
7206 (x_get_resource_string); Remove decls.
7207 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7208 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7209
7210 * font.c, fontset.c: Make symbols static if they're not exported.
7211 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7212 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7213 * font.c (font_close_object): Now static.
7214 * font.h (font_close_object): Remove.
7215 * fontset.c (FONTSET_OBJLIST): Remove.
7216 (free_realized_fontset) #if-0 the body, which does nothing.
7217 (face_suitable_for_char_p): #if-0, as it's never called.
7218 * fontset.h (face_suitable_for_char_p): Remove decl.
7219 * xfaces.c (face_at_string_position):
7220 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7221 since 0 is always ASCII.
7222
7223 * fns.c (weak_hash_tables): Now static.
7224
7225 * fileio.c: Make symbols static if they're not exported.
7226 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7227 (Vwrite_region_annotation_buffers): Now static.
7228
7229 * eval.c: Make symbols static if they're not exported.
7230 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7231 * lisp.h (backtrace_list): Remove decl.
7232
7233 * emacs.c: Make symbols static if they're not exported.
7234 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7235 (fatal_error_code, fatal_error_signal_hook, standard_args):
7236 Now static.
7237 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7238 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7239 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7240 * lisp.h (fatal_error_signal_hook): Remove decl.
7241 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7242
7243 * editfns.c: Move a (normally-unused) function to its only use.
7244 * editfns.c, lisp.h (get_operating_system_release): Remove.
7245 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7246 worth the hassle of breaking this out.
7247
7248 * xterm.c: Make symbols static if they're not exported.
7249 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7250 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7251 (x_destroy_window, x_delete_display):
7252 Now static.
7253 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7254 (x_mouse_leave): Remove; unused.
7255 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7256 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7257 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7258 Remove decls.
7259 (x_mouse_leave): Declare only if WINDOWSNT.
7260 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7261 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7262 USE_X_TOOLKIT.
7263
7264 * ftxfont.c: Make symbols static if they're not exported.
7265 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7266 HAVE_FREETYPE.
7267 * font.h (ftxfont_driver): Likewise.
7268
7269 * xfns.c: Make symbols static if they're not exported.
7270 (x_last_font_name, x_display_info_for_name):
7271 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7272 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7273 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7274 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7275 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7276 (last_show_tip_args): Now static.
7277 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7278 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7279 (x_screen_planes): Remove; unused.
7280 * dispextern.h (x_screen_planes): Remove decl.
7281
7282 * dispnew.c: Make symbols static if they're not exported.
7283 * dispextern.h (redraw_garbaged_frames, scrolling):
7284 (increment_row_positions): Remove.
7285 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7286 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7287 Now static.
7288 (redraw_garbaged_frames): Remove; unused.
7289
7290 * xfaces.c: Make symbols static if they're not exported.
7291 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7292 Remove decls.
7293 * xterm.h (defined_color): Remove decls.
7294 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7295 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7296 (menu_face_changed_default, defined_color, free_realized_face):
7297 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7298 (ascii_face_of_lisp_face): Remove; unused.
7299
7300 * xdisp.c: Make symbols static if they're not exported.
7301 * dispextern.h (scratch_glyph_row, window_box_edges):
7302 (glyph_to_pixel_coords, set_cursor_from_row):
7303 (get_next_display_element, set_iterator_to_next):
7304 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7305 (show_mouse_face): Remove decls
7306 * frame.h (message_buf_print): Likewise.
7307 * lisp.h (pop_message, set_message, check_point_in_composition):
7308 Likewise.
7309 * xterm.h (set_vertical_scroll_bar): Likewise.
7310 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7311 (message_buf_print, scratch_glyph_row, displayed_buffer):
7312 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7313 (get_next_display_element, show_mouse_face, window_box_edges):
7314 (frame_to_window_pixel_xy, check_point_in_composition):
7315 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7316 (glyph_to_pixel_coords): Remove; unused.
7317
7318 * dired.c (file_name_completion): Now static.
7319
7320 * dbusbind.c (xd_in_read_queued_messages): Now static.
7321
7322 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7323 * data.c (circular_list_error): Remove.
7324
7325 * commands.h (last_point_position, last_point_position_buffer):
7326 (last_point_position_window): Remove decls.
7327 * keyboard.c: Make these variables static.
7328
7329 * coding.h (coding, code_convert_region, encode_coding_gap):
7330 Remove decls.
7331 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7332 (iso_code_class, detect_coding, code_convert_region): Now static.
7333 (encode_coding_gap): Remove; unused.
7334
7335 * chartab.c (chartab_chars, chartab_bits): Now static.
7336
7337 * charset.h (charset_iso_8859_1): Remove decl.
7338 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7339 Now static.
7340
7341 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7342 * ccl.c (Vccl_program_table): Now static.
7343 (check_ccl_update): Remove; unused.
7344
7345 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7346 * category.h: ... from here.
7347 * category.c (check_category_table, set_category_set): Now static.
7348
7349 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7350 * lisp.h: Remove these decls.
7351
7352 * buffer.c (buffer_count): Remove unused var.
7353
7354 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7355 so that it's not optimized away.
7356 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7357 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7358 exported only to the debugger.
7359
7360 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7361 * atimer.h (run_all_atimers): Remove; not exported.
7362
7363 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7364 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7365 was inaccessible from Lisp.
7366 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7367 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7368
7369 alloc.c: Import and export fewer symbols, and remove unused items.
7370 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7371 is defined.
7372 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7373 it's not optimized away by whole-program optimization.
7374 (message_enable_multibyte, free_misc): Remove.
7375 (catchlist, handlerlist, mark_backtrace):
7376 Declare only if BYTE_MARK_STACK.
7377 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7378 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7379 (message_enable_multibyte): Remove decl.
7380 (free_misc, interval_free_list, float_block, float_block_index):
7381 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7382 (cons_free_list, last_marked_index):
7383 Now static.
7384 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7385 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7386 (mark_backtrace): Define only if BYTE_MARK_STACK.
7387 * xdisp.c (message_enable_multibyte): Now static.
7388
7389 Declare Lisp_Object Q* variables to be 'static' if not exported.
7390 This makes it easier for human readers (and static analyzers)
7391 to see whether these variables are used from other modules.
7392 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7393 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7394 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7395 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7396 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7397 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7398 * xmenu.c, xselect.c:
7399 Declare Q* vars static if they are not used in other modules.
7400 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7401 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7402 Remove decls of unexported vars.
7403 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7404
7405 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7406
7407 Make Emacs functions such as Fatom 'static' by default.
7408 This makes it easier for human readers (and static analyzers)
7409 to see whether these functions can be called from other modules.
7410 DEFUN now defines a static function. To make the function external
7411 so that it can be used in other C modules, use the new macro DEFUE.
7412 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7413 (Finit_image_library):
7414 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7415 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7416 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7417 Remove decls, since these functions are now static.
7418 (Funintern, Fget_internal_run_time): New decls, since these functions
7419 were already external.
7420
7421 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7422 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7423 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7424 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7425 * keyboard.c, keymap.c, lread.c:
7426 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7427 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7428 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7429 Mark functions with DEFUE instead of DEFUN,
7430 if they are used in other modules.
7431 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7432 decls for now-static functions.
7433 * buffer.h (Fdelete_overlay): Remove decl.
7434 * callproc.c (Fgetenv_internal): Mark as internal.
7435 * composite.c (Fremove_list_of_text_properties): Remove decl.
7436 (Fcomposition_get_gstring): New forward static decl.
7437 * composite.h (Fcomposite_get_gstring): Remove decl.
7438 * dired.c (Ffile_attributes): New forward static decl.
7439 * doc.c (Fdocumntation_property): New forward static decl.
7440 * eval.c (Ffetch_bytecode): New forward static decl.
7441 (Funintern): Remove extern decl; now in .h file where it belongs.
7442 * fileio.c (Fmake_symbolic_link): New forward static decl.
7443 * image.c (Finit_image_library): New forward static decl.
7444 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7445 * intervals.h (Fprevious_property_change):
7446 (Fremove_list_of_text_properties): Remove decls.
7447 * keyboard.c (Fthis_command_keys): Remove decl.
7448 (Fcommand_execute): New forward static decl.
7449 * keymap.c (Flookup_key): New forward static decl.
7450 (Fcopy_keymap): Now static.
7451 * keymap.h (Flookup_key): Remove decl.
7452 * process.c (Fget_process): New forward static decl.
7453 (Fprocess_datagram_address): Mark as internal.
7454 * syntax.c (Fsyntax_table_p): New forward static decl.
7455 (skip_chars): Remove duplicate decl.
7456 * textprop.c (Fprevious_property_change): New forward static decl.
7457 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7458 Now internal.
7459 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7460 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7461
7462 * editfns.c (Fformat): Remove unreachable code.
7463
7464 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7465
7466 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7467 change. (Bug#8496)
7468
7469 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7470
7471 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7472 when at ZV. (Bug#8487)
7473
7474 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7475
7476 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7477 (Bug#8437)
7478 * keyboard.c (parse_tool_bar_item): Likewise.
7479 * sound.c (sound_cleanup, alsa_close): Likewise.
7480 * termcap.c (tgetent): Likewise.
7481 * xfns.c (x_default_font_parameter): Likewise.
7482 * xsettings.c (read_and_apply_settings): Likewise.
7483
7484 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7485 (overrun_check_free): Protoize.
7486
7487 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7488
7489 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7490 since callers should never pass a negative size.
7491 Change the signature to match that of plain 'read' and 'write'; see
7492 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7493 * lisp.h: Update prototypes of emacs_write and emacs_read.
7494
7495 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7496
7497 * xdisp.c (redisplay_window): Don't try to determine the character
7498 position of the scroll margin if the window start point w->startp
7499 is outside the buffer's accessible region. (Bug#8468)
7500
7501 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7502
7503 Fix write-region and its subroutines for buffers > 2GB.
7504 * fileio.c (a_write, e_write): Modify declaration of arguments and
7505 local variables to support buffers larger than 2GB.
7506 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7507
7508 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7509 argument, local variables, and return value.
7510
7511 * lisp.h: Update prototypes of emacs_write and emacs_read.
7512
7513 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7514
7515 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7516
7517 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7518
7519 Fix more problems found by GCC 4.6.0's static checks.
7520
7521 * xdisp.c (vmessage): Use a better test for character truncation.
7522
7523 * charset.c (load_charset_map): <, not <=, for optimization,
7524 and to avoid potential problems with integer overflow.
7525 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7526 * casetab.c (set_identity, shuffle): Likewise.
7527 * editfns.c (Fformat): Likewise.
7528 * syntax.c (skip_chars): Likewise.
7529
7530 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7531 This also lets GCC 4.6.0 generate slightly better loop code.
7532
7533 * callint.c (Fcall_interactively): <, not <=, for optimization.
7534 (Fcall_interactively): Count the number of arguments produced,
7535 not the number of arguments given. This is simpler and lets GCC
7536 4.6.0 generate slightly better code.
7537
7538 * ftfont.c: Distingish more carefully between FcChar8 and char.
7539 The previous code passed unsigned char * to a functions like
7540 strlen and xstrcasecmp that expect char *, which does not
7541 conform to the C standard.
7542 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7543 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7544 char * when the C standard requires it.
7545
7546 * keyboard.c (read_char): Remove unused var.
7547
7548 * eval.c: Port to Windows vsnprintf (Bug#8435).
7549 Include <limits.h>.
7550 (SIZE_MAX): Define if the headers do not.
7551 (verror): Do not give up if vsnprintf returns a negative count.
7552 Instead, grow the buffer. This ports to Windows vsnprintf, which
7553 does not conform to C99. Problem reported by Eli Zaretskii.
7554 Also, simplify the allocation scheme, by avoiding the need for
7555 calling realloc, and removing the ALLOCATED variable.
7556
7557 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7558
7559 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7560 But keep the doprint source code for now, as we might revamp it
7561 and use it again (Bug#8435).
7562 * lisp.h (doprnt): Remove.
7563 * Makefile.in (base_obj): Remove doprnt.o.
7564 * deps.mk (doprnt.o): Remove.
7565
7566 error: Print 32- and 64-bit integers portably (Bug#8435).
7567 Without this change, on typical 64-bit hosts error ("...%d...", N)
7568 was used to print both 32- and 64-bit integers N, which relied on
7569 undefined behavior.
7570 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7571 New macro.
7572 * lisp.h (error, verror): Mark as printf-like functions.
7573 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7574 Report overflow in size calculations when allocating printf buffer.
7575 Do not truncate output string at its first null byte.
7576 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7577 Truncate the output at a character boundary, since vsnprintf does not
7578 do that.
7579 * charset.c (check_iso_charset_parameter): Convert internal
7580 character to string before calling 'error', since %c now has the
7581 printf meaning.
7582 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7583 overflow when computing char to be passed to 'error'. Do not
7584 pass Lisp_Object to 'error'; pass the integer instead.
7585 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7586 formatted with plain %d.
7587
7588 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7589
7590 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7591
7592 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7593
7594 * xterm.c (x_catch_errors): Remove duplicate declaration.
7595
7596 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7597
7598 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7599
7600 2011-04-10 Jim Meyering <meyering@redhat.com>
7601
7602 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7603 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7604 return ssize_t not "int", and use size_t as the buffer length.
7605 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7606 * gnutls.h: Update declarations.
7607 * process.c (read_process_output): Use ssize_t, to match.
7608 (send_process): Likewise.
7609
7610 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7611
7612 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7613
7614 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7615
7616 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7617 Use unsigned char, to match FcChar8 type definition.
7618
7619 * xterm.c (handle_one_xevent):
7620 * xmenu.c (create_and_show_popup_menu):
7621 * xselect.c (x_decline_selection_request)
7622 (x_reply_selection_request): Avoid type-punned deref of X events.
7623
7624 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7625
7626 Fix some uses of `int' instead of EMACS_INT.
7627 * search.c (string_match_1, fast_string_match)
7628 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7629 (scan_buffer, find_next_newline_no_quit)
7630 (find_before_next_newline, search_command, Freplace_match)
7631 (Fmatch_data): Make some `int' variables be EMACS_INT.
7632
7633 * xdisp.c (display_count_lines): 3rd argument and return value now
7634 EMACS_INT. All callers changed.
7635 (pint2hrstr): Last argument is now EMACS_INT.
7636
7637 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7638 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7639 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7640 (decode_coding_utf_16, decode_coding_emacs_mule)
7641 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7642 (decode_coding_ccl, decode_coding_charset)
7643 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7644 (decode_coding_iso_2022, decode_coding_emacs_mule)
7645 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7646 <char_offset, last_offset>: Declare EMACS_INT.
7647 (encode_coding_utf_8, encode_coding_utf_16)
7648 (encode_coding_emacs_mule, encode_invocation_designation)
7649 (encode_designation_at_bol, encode_coding_iso_2022)
7650 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7651 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7652 Declare EMACS_INT.
7653 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7654 (encode_invocation_designation): Last argument P_NCHARS is now
7655 EMACS_INT.
7656 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7657 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7658
7659 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7660 All users changed.
7661
7662 * ccl.c (Fccl_execute_on_string): Declare some variables
7663 EMACS_INT.
7664
7665 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7666
7667 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7668
7669 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7670
7671 * process.c (Fformat_network_address): Doc fix.
7672
7673 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7674
7675 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7676
7677 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7678
7679 * keyboard.c (read_char): Call Lisp function help-form-show,
7680 instead of using internal_with_output_to_temp_buffer.
7681 (Qhelp_form_show): New var.
7682 (syms_of_keyboard): Use DEFSYM macro.
7683
7684 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7685
7686 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7687
7688 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7689
7690 * process.c (Flist_processes): Remove to Lisp.
7691 (list_processes_1): Delete.
7692
7693 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7694
7695 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7696
7697 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7698
7699 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7700
7701 Fix more problems found by GCC 4.6.0's static checks.
7702
7703 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7704
7705 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7706
7707 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7708
7709 * xdisp.c (vmessage): Mark as a printf-like function.
7710
7711 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7712
7713 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7714
7715 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7716 printf-like functions.
7717 (tiff_load): Add casts to remove these marks before passing them
7718 to system-supplied API.
7719
7720 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7721
7722 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7723 This avoids several warnings with gcc -Wstrict-overflow.
7724 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7725 directly, rather than having caller test rule sign. This avoids
7726 some unnecessary tests.
7727 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7728 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7729 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7730
7731 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7732 (xfont_open): Avoid unnecessary tests.
7733
7734 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7735
7736 * composite.h, composite.c (composition_gstring_put_cache):
7737 Use EMACS_INT, not int, for length.
7738
7739 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7740 breaking out part of COMPOSITION_DECODE_RULE.
7741 (COMPOSITION_DECODE_RULE): Use it.
7742 * composite.c (get_composition_id): Remove unused local vars,
7743 by using the new macro.
7744
7745 * textprop.c (set_text_properties_1): Change while to do-while,
7746 since the condition is always true at first.
7747
7748 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7749 (interval_deletion_adjustment): Return unsigned value.
7750 All uses changed.
7751
7752 * process.c (list_processes_1, create_pty, read_process_output):
7753 (exec_sentinel): Remove vars that were set but not used.
7754 (create_pty): Remove unnecessary "volatile"s.
7755 (Fnetwork_interface_info): Avoid possibility of int overflow.
7756 (read_process_output): Do adaptive read buffering even if carryover.
7757 (read_process_output): Simplify nbytes computation if buffered.
7758
7759 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7760
7761 * syntax.c (scan_words): Remove var that was set but not used.
7762 (update_syntax_table): Use unsigned instead of int.
7763
7764 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7765 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7766 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7767
7768 * print.c (print_error_message): Avoid int overflow.
7769
7770 * font.c (font_list_entities): Redo for clarity,
7771 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7772
7773 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7774 (font_score): Avoid potential overflow in diff calculation.
7775
7776 * fns.c (substring_both): Remove var that is set but not used.
7777 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7778
7779 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7780
7781 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7782 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7783 can always succeed if overflow has undefined behavior.
7784
7785 * search.c (boyer_moore, wordify): Remove vars set but not used.
7786 (wordify): Omit three unnecessary tests.
7787
7788 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7789 All callers changed. This avoids the need for an unused var.
7790
7791 * casefiddle.c (casify_region): Remove var that is set but not used.
7792
7793 * dired.c (file_name_completion): Remove var that is set but not used.
7794
7795 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7796
7797 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7798 (Finsert_file_contents): Remove unnecessary code checking fd.
7799
7800 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7801 Check for integer overflow on size calculations.
7802
7803 * buffer.c (Fprevious_overlay_change): Remove var that is set
7804 but not used.
7805
7806 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7807 Remove vars that are set but not used.
7808 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7809 (timer_check_2): Mark vars as initialized.
7810
7811 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7812
7813 * image.c (lookup_image): Remove var that is set but not used.
7814 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7815
7816 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7817 that are set but not used.
7818
7819 * xfns.c (make_invisible_cursor): Don't return garbage
7820 if XCreateBitmapFromData fails (Bug#8410).
7821
7822 * xselect.c (x_get_local_selection, x_handle_property_notify):
7823 Remove vars that are set but not used.
7824
7825 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7826 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7827
7828 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7829 Remove var that is set but not used.
7830 (scroll_bar_windows_size): Now size_t, not int.
7831 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7832 Check for overflow.
7833
7834 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7835 (map_tty_color) [!defined MSDOS]: Likewise.
7836
7837 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7838
7839 * coding.c: Remove vars that are set but not used.
7840 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7841 All callers changed.
7842 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7843 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7844 (decode_coding_charset): Remove vars that are set but not used.
7845
7846 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7847 that is set but not used.
7848
7849 * print.c (print_object): Remove var that is set but not used.
7850
7851 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7852 The gnulib version avoids calling malloc in the usual case,
7853 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7854 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7855 * filelock.c (current_lock_owner): Likewise.
7856 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7857 * sysdep.c: Include allocator.h, careadlinkat.h.
7858 (emacs_no_realloc_allocator): New static constant.
7859 (emacs_readlink): New function.
7860 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7861 ../lib/careadlinkat.h.
7862
7863 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7864
7865 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7866 first non-nil return value).
7867
7868 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7869
7870 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7871 if not defined (Bug#8403).
7872
7873 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7874
7875 * xdisp.c (display_count_lines): Remove parameter `start',
7876 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7877 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7878 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7879 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7880 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7881 and thereabouts. All callers changed.
7882 (get_per_char_metric): Remove parameter `f', unused since
7883 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7884
7885 2011-04-02 Jim Meyering <meyering@redhat.com>
7886
7887 do not dereference NULL upon failed strdup
7888 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7889 (ns_get_family): Likewise.
7890
7891 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7892
7893 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7894
7895 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7896
7897 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7898 later (Bug#8403).
7899
7900 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7901
7902 Add lexical binding.
7903
7904 * window.c (Ftemp_output_buffer_show): New fun.
7905 (Fsave_window_excursion):
7906 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7907
7908 * lread.c (lisp_file_lexically_bound_p): New function.
7909 (Fload): Bind Qlexical_binding.
7910 (readevalloop): Remove `evalfun' arg.
7911 Bind Qinternal_interpreter_environment.
7912 (Feval_buffer): Bind Qlexical_binding.
7913 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7914 Mark as dynamic.
7915 (syms_of_lread): Declare `lexical-binding'.
7916
7917 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7918
7919 * keyboard.c (eval_dyn): New fun.
7920 (menu_item_eval_property): Use it.
7921
7922 * image.c (parse_image_spec): Use Ffunctionp.
7923
7924 * fns.c (concat, mapcar1): Accept byte-code-functions.
7925
7926 * eval.c (Fsetq): Handle lexical vars.
7927 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7928 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7929 (FletX, Flet): Obey lexical binding.
7930 (Fcommandp): Handle closures.
7931 (Feval): New `lexical' arg.
7932 (eval_sub): New function extracted from Feval. Use it almost
7933 everywhere where Feval was used. Look up vars in lexical env.
7934 Handle closures.
7935 (Ffunctionp): Move from subr.el.
7936 (Ffuncall): Handle closures.
7937 (apply_lambda): Remove `eval_flags'.
7938 (funcall_lambda): Handle closures and new byte-code-functions.
7939 (Fspecial_variable_p): New function.
7940 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7941 but without exporting it to Lisp.
7942
7943 * doc.c (Fdocumentation, store_function_docstring):
7944 * data.c (Finteractive_form): Handle closures.
7945
7946 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7947 interactive spec.
7948
7949 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7950 New byte-codes.
7951 (exec_byte_code): New function extracted from Fbyte_code to handle new
7952 calling convention for byte-code-functions. Add new byte-codes.
7953
7954 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7955
7956 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7957
7958 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7959
7960 * xdisp.c (redisplay_internal): Fix prototype.
7961
7962 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7963
7964 * xdisp.c (SCROLL_LIMIT): New macro.
7965 (try_scrolling): Use it when setting scroll_limit.
7966 Limit scrolling to 100 screen lines.
7967 (redisplay_window): Even when falling back on "recentering",
7968 position point in the window according to scroll-conservatively,
7969 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7970
7971 (try_scrolling): When point is above the window, allow searching
7972 as far as scroll_max, or one screenful, to compute vertical
7973 distance from PT to the scroll margin position. This prevents
7974 try_scrolling from unnecessarily failing when
7975 scroll-conservatively is set to a value slightly larger than the
7976 window height. Clean up the case of PT below the margin at bottom
7977 of window: scroll_max can no longer be INT_MAX. When aggressive
7978 scrolling is in use, don't let point enter the opposite scroll
7979 margin as result of the scroll.
7980 (syms_of_xdisp) <scroll-conservatively>: Document the
7981 threshold of 100 lines for never-recentering scrolling.
7982
7983 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7984
7985 * dispextern.h (move_it_by_lines):
7986 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7987 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7988 (message_log_check_duplicate): Remove parameters `prev_bol' and
7989 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7990 (redisplay_internal): Remove parameter `preserve_echo_area',
7991 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7992
7993 * indent.c (Fvertical_motion):
7994 * window.c (window_scroll_pixel_based, Frecenter):
7995 Don't pass `need_y_p' to `move_it_by_lines'.
7996
7997 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7998
7999 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8000 steal a few bits to be more compact.
8001 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8002 Remove unneeded casts.
8003
8004 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8005
8006 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8007
8008 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8009 binding" message (bug#7967).
8010
8011 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8012
8013 Fix more problems found by GCC 4.6.0's static checks.
8014
8015 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8016 Remove unused local var.
8017
8018 * editfns.c (Fmessage_box): Remove unused local var.
8019
8020 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8021 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8022 Omit unused local vars.
8023 * window.c (shrink_windows): Omit unused local var.
8024 * menu.c (digest_single_submenu): Omit unused local var.
8025 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8026 Omit unused local var.
8027
8028 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8029 Don't assume string length fits in int.
8030 (keyremap_step, read_key_sequence): Use size_t for sizes.
8031 (read_key_sequence): Don't check last_real_key_start redundantly.
8032
8033 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8034 instead of alloca (Bug#8344).
8035
8036 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8037 (Fbacktrace_frame): Don't assume nframes fits in int.
8038
8039 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8040
8041 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8042 concerns.
8043
8044 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8045
8046 * cm.c (calccost): Turn while-do into do-while, for clarity.
8047
8048 * keyboard.c (syms_of_keyboard): Use the same style as later
8049 in this function when indexing through an array. This also
8050 works around GCC bug 48267.
8051
8052 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8053
8054 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8055
8056 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8057 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8058
8059 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8060 This avoids undefined behavior on integer overflow, and is a bit
8061 more convenient anyway since it is compared to a size_t variable.
8062
8063 Variadic C functions now count arguments with size_t, not int.
8064 This avoids an unnecessary limitation on 64-bit machines, which
8065 caused (substring ...) to crash on large vectors (Bug#8344).
8066 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8067 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8068 All variadic functions and their callers changed accordingly.
8069 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8070 * data.c (arith_driver, float_arith_driver): Likewise.
8071 * editfns.c (general_insert_function): Likewise.
8072 * eval.c (struct backtrace.nargs, interactive_p)
8073 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8074 (funcall_lambda, mark_backtrace): Likewise.
8075 * fns.c (concat): Likewise.
8076 * frame.c (x_set_frame_parameters): Likewise.
8077 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8078 0 if not found, not -1. All callers changed.
8079
8080 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8081 (stack_copy_size): Now size_t, not int.
8082 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8083
8084 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8085
8086 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8087 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8088 All callers changed.
8089
8090 * lisp.h (multibyte_char_to_unibyte):
8091 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8092 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8093 * character.h (CHAR_TO_BYTE8):
8094 * cmds.c (internal_self_insert):
8095 * editfns.c (general_insert_function):
8096 * keymap.c (push_key_description):
8097 * search.c (Freplace_match):
8098 * xdisp.c (message_dolog, set_message_1): All callers changed.
8099
8100 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8101
8102 * keyboard.c (safe_run_hook_funcall): New function.
8103 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8104 don't set the hook to nil, but remove the offending function instead.
8105 (Qcommand_hook_internal): Remove, unused.
8106 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8107 Vcommand_hook_internal.
8108
8109 * eval.c (enum run_hooks_condition): Remove.
8110 (funcall_nil, funcall_not): New functions.
8111 (run_hook_with_args): Call each function through a `funcall' argument.
8112 Remove `cond' argument, now redundant.
8113 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8114 (Frun_hook_with_args_until_failure): Adjust accordingly.
8115 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8116
8117 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8118
8119 * dispextern.h (string_buffer_position): Remove declaration.
8120
8121 * print.c (strout): Remove parameter `multibyte', unused since
8122 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8123
8124 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8125 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8126 All callers changed.
8127
8128 * w32.c (_wsa_errlist): Use braces for struct initializers.
8129
8130 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8131 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8132 All callers changed.
8133 (string_buffer_position): Likewise. Also, make static (it's never
8134 used outside xdisp.c).
8135 (cursor_row_p): Remove parameter `w', unused since
8136 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8137 (decode_mode_spec): Remove parameter `precision', introduced during
8138 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8139 All callers changed.
8140
8141 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8142
8143 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8144
8145 2011-03-27 Anders Lindgren <andlind@gmail.com>
8146
8147 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8148 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8149 (ns_update_auto_hide_menu_bar): New functions.
8150 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8151 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8152 ns_constrain_all_frames.
8153 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8154 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8155
8156 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8157
8158 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8159
8160 2011-03-27 Glenn Morris <rgm@gnu.org>
8161
8162 * syssignal.h: Replace RETSIGTYPE with void.
8163 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8164 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8165 Replace SIGTYPE with void everywhere.
8166 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8167 * s/template.h (SIGTYPE): Remove commented out definition.
8168
8169 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8170
8171 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8172 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8173
8174 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8175
8176 * w32.c (read_unc_volume): Use parameter `henum', instead of
8177 global variable `wget_enum_handle'.
8178
8179 * keymap.c (describe_vector): Remove parameters `indices' and
8180 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8181 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8182
8183 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8184
8185 * keyboard.c (timer_check): Remove parameter `do_it_now',
8186 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8187 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8188 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8189
8190 * keyboard.c (read_char):
8191 * w32menu.c (w32_menu_display_help):
8192 * xmenu.c (show_help_event, menu_help_callback):
8193 Adjust calls to `show_help_echo'.
8194
8195 * gtkutil.c (xg_maybe_add_timer):
8196 * keyboard.c (readable_events):
8197 * process.c (wait_reading_process_output):
8198 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8199
8200 * insdel.c (adjust_markers_gap_motion):
8201 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8202 (gap_left, gap_right): Don't call it.
8203
8204 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8205
8206 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8207 incurred during fontification.
8208
8209 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8210
8211 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8212 (DEFVAR_PER_BUFFER): Don't pass it.
8213
8214 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8215 (scrolling_window): Don't pass it.
8216
8217 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8218
8219 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8220
8221 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8222 and `suffix'.
8223 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8224 of variables specific to SELinux and computation of `encoded_absname'.
8225
8226 * image.c (XPutPixel): Remove unused variable `height'.
8227
8228 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8229
8230 * unexw32.c (get_section_info): Remove unused variable `section'.
8231
8232 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8233 (system_process_attributes): Remove unused variable `sess'.
8234 (sys_read): Remove unused variable `err'.
8235
8236 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8237 (w32_wnd_proc): Remove unused variable `isdead'.
8238 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8239 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8240 (x_create_tip_frame): Remove unused variable `tem'.
8241
8242 * w32inevt.c (w32_console_read_socket):
8243 Remove unused variable `no_events'.
8244
8245 * w32term.c (x_draw_composite_glyph_string_foreground):
8246 Remove unused variable `width'.
8247
8248 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8249
8250 * w32term.c (x_set_glyph_string_clipping):
8251 Don't pass uninitialized region to CombineRgn.
8252
8253 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8254
8255 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8256 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8257 (Fx_close_connection): Remove unused variable `i'.
8258
8259 * w32font.c (w32font_draw): Return number of glyphs.
8260 (w32font_open_internal): Remove unused variable `i'.
8261 (w32font_driver): Add missing initializer.
8262
8263 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8264 (fill_in_menu): Remove unused variable `items_added'.
8265
8266 * w32term.c (last_mouse_press_frame): Remove static global variable.
8267 (w32_clip_to_row): Remove unused variable `f'.
8268 (x_delete_terminal): Remove unused variable `i'.
8269
8270 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8271 (NOTHING): Remove unused static global variable.
8272 (uniscribe_check_otf): Remove unused variable `table'.
8273 (uniscribe_font_driver): Add missing initializers.
8274
8275 2011-03-23 Julien Danjou <julien@danjou.info>
8276
8277 * term.c (Fsuspend_tty, Fresume_tty):
8278 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8279 * window.c (temp_output_buffer_show):
8280 * insdel.c (signal_before_change):
8281 * frame.c (Fhandle_switch_frame):
8282 * fileio.c (Fdo_auto_save):
8283 * emacs.c (Fkill_emacs):
8284 * editfns.c (save_excursion_restore):
8285 * cmds.c (internal_self_insert):
8286 * callint.c (Fcall_interactively):
8287 * buffer.c (Fkill_all_local_variables):
8288 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8289 Use Frun_hooks.
8290 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8291 unconditionally since it does the check itself.
8292
8293 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8294
8295 Fix more problems found by GCC 4.5.2's static checks.
8296
8297 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8298 the first time through the loop, since we know p0 < p1 then.
8299 This also avoids a gcc -Wstrict-overflow warning.
8300
8301 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8302 leading to a memory leak, possible in functions like
8303 load_charset_map_from_file that can allocate an unbounded number
8304 of objects (Bug#8318).
8305
8306 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8307 that could (at least in theory) be that large.
8308
8309 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8310 This is less likely to overflow, and avoids undefined behavior if
8311 overflow does occur. All callers changed. Use strtoul to scan
8312 for the unsigned long integer.
8313 (pint2hrstr): Simplify and tune code slightly.
8314 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8315
8316 * scroll.c (do_scrolling): Work around GCC bug 48228.
8317 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8318
8319 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8320 This also avoids a warning with gcc -Wstrict-overflow.
8321 (validate_x_resource_name): Simplify count usage.
8322 This also avoids a warning with gcc -Wstrict-overflow.
8323
8324 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8325 fail (Bug#8306).
8326
8327 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8328
8329 * process.c (Fmake_network_process): Use socklen_t, not int,
8330 where POSIX says socklen_t is required in portable programs.
8331 This fixes a porting bug on hosts like 64-bit HP-UX, where
8332 socklen_t is wider than int (Bug#8277).
8333 (Fmake_network_process, server_accept_connection):
8334 (wait_reading_process_output, read_process_output):
8335 Likewise.
8336
8337 * process.c: Rename or move locals to avoid shadowing.
8338 (list_processes_1, Fmake_network_process):
8339 (read_process_output_error_handler, exec_sentinel_error_handler):
8340 Rename or move locals.
8341 (Fmake_network_process): Define label "retry_connect" only if needed.
8342 (Fnetwork_interface_info): Fix pointer signedness.
8343 (process_send_signal): Add cast to avoid pointer signedness problem.
8344 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8345 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8346
8347 Make tparam.h and terminfo.c consistent.
8348 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8349 Include tparam.h instead, since it declares them.
8350 * cm.h (PC): Remove extern decl; tparam.h now does this.
8351 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8352 * terminfo.c: Include tparam.h, to check interfaces.
8353 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8354 (tparam): Adjust signature to match interface in tparam.h;
8355 this removes some undefined behavior. Check that outstring and len
8356 are zero, which they always are with Emacs.
8357 * tparam.h (PC, BC, UP): New extern decls.
8358
8359 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8360 (xftfont_open): Rename locals to avoid shadowing.
8361
8362 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8363 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8364 (OTF_TAG_SYM): Omit macro if not needed.
8365 (ftfont_list): Remove unused local.
8366 (get_adstyle_property, ftfont_pattern_entity):
8367 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8368 Rename locals to avoid shadowing.
8369
8370 * xfont.c (xfont_list_family): Mark var as initialized.
8371
8372 * xml.c (make_dom): Now static.
8373
8374 * composite.c (composition_compute_stop_pos): Rename local to
8375 avoid shadowing.
8376 (composition_reseat_it): Remove unused locals.
8377 (find_automatic_composition, composition_adjust_point): Likewise.
8378 (composition_update_it): Mark var as initialized.
8379 (find_automatic_composition): Mark vars as initialized,
8380 with a FIXME (Bug#8290).
8381
8382 character.h: Rename locals to avoid shadowing.
8383 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8384 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8385 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8386 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8387 to avoid shadowing.
8388
8389 * textprop.c (property_change_between_p): Remove; unused.
8390
8391 * intervals.c (interval_start_pos): Now static.
8392
8393 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8394
8395 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8396 Rename locals to avoid shadowing.
8397
8398 * sound.c (wav_play, au_play, Fplay_sound_internal):
8399 Fix pointer signedness.
8400 (alsa_choose_format): Remove unused local var.
8401 (wav_play): Initialize a variable to 0, to prevent undefined
8402 behavior (Bug#8278).
8403
8404 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8405
8406 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8407
8408 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8409 clobbering (Bug#8298).
8410 * sysdep.c (sys_subshell): Likewise.
8411 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8412
8413 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8414 This should get cleaned up, so that child_setup has the
8415 same signature on all platforms.
8416
8417 * callproc.c (call_process_cleanup): Now static.
8418 (relocate_fd): Rename locals to avoid shadowing.
8419
8420 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8421
8422 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8423 not to be necessary, and produces flickering.
8424
8425 2011-03-20 Glenn Morris <rgm@gnu.org>
8426
8427 * config.in: Remove file.
8428
8429 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8430
8431 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8432 are now in src/globals.h.
8433 (syms_of_minibuf): Remove spurious & from previous change.
8434
8435 2011-03-20 Leo Liu <sdl.web@gmail.com>
8436
8437 * minibuf.c (completing-read-function): New variable.
8438 (completing-read-default): Rename from completing-read.
8439 (completing-read): Call completing-read-function.
8440
8441 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8442
8443 * xfaces.c (Fx_load_color_file):
8444 Read color file from absolute filename (bug#8250).
8445
8446 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8447
8448 * makefile.w32-in: Update dependencies.
8449
8450 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8451
8452 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8453
8454 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8455
8456 Fix more problems found by GCC 4.5.2's static checks.
8457
8458 * process.c (make_serial_process_unwind, send_process_trap):
8459 (sigchld_handler): Now static.
8460
8461 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8462 That way, the code declares only the vars that it needs.
8463 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8464 * s/cygwin.h (PTY_ITERATION): Likewise.
8465 * s/darwin.h (PTY_ITERATION): Likewise.
8466 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8467
8468 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8469 * process.c (allocate_pty): Don't declare stb unless it's needed.
8470
8471 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8472 (CONSTANTLIM): Remove; unused.
8473 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8474 Define only if needed.
8475
8476 * unexelf.c (unexec): Name an expression,
8477 to avoid gcc -Wbad-function-cast warning.
8478 Use a different way to cause a compilation error if anyone uses
8479 n rather than nn, a way that does not involve shadowing.
8480 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8481
8482 * deps.mk (unexalpha.o): Remove; unused.
8483
8484 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8485 * unexec.h: New file.
8486 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8487 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8488 Depend on unexec.h.
8489 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8490 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8491 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8492 Change as necessary to match prototype in unexec.h.
8493
8494 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8495 shadowing.
8496 (back_comment, skip_chars): Mark vars as initialized.
8497
8498 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8499 Rename locals to avoid shadowing.
8500
8501 * lread.c (read1): Rewrite so as not to use empty "else".
8502 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8503
8504 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8505
8506 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8507 warning when compiling print.c.
8508
8509 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8510 instead of using an uninitialized var.
8511 (font_sort_entities): Mark var as initialized.
8512
8513 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8514
8515 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8516 pointers to constants.
8517 (font_parse_fcname): Remove unused vars.
8518 (font_delete_unmatched): Now static.
8519 (font_get_spec): Remove; unused.
8520 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8521 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8522 Rename or move locals to avoid shadowing.
8523
8524 * fns.c (require_nesting_list, require_unwind): Now static.
8525 (Ffillarray): Rename locals to avoid shadowing.
8526
8527 * floatfns.c (domain_error2): Define only if needed.
8528 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8529
8530 * alloc.c (mark_backtrace): Move decl from here ...
8531 * lisp.h: ... to here, so that it can be checked.
8532
8533 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8534 (Fdefvar): Rewrite so as not to use empty "else".
8535 (lisp_indirect_variable): Name an expression,
8536 to avoid gcc -Wbad-function-cast warning.
8537 (Fdefvar): Rename locals to avoid shadowing.
8538
8539 * callint.c (quotify_arg, quotify_args): Now static.
8540 (Fcall_interactively): Rename locals to avoid shadowing.
8541 Use const pointer when appropriate.
8542
8543 * lisp.h (get_system_name, get_operating_system_release):
8544 Move decls here, to check interfaces.
8545 * process.c (get_operating_system_release): Move decl to lisp.h.
8546 * xrdb.c (get_system_name): Likewise.
8547 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8548 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8549 some of which prompt warnings from gcc -Wbad-function-cast.
8550 (Fformat_time_string, Fencode_time, Finsert_char):
8551 (Ftranslate_region_internal, Fformat):
8552 Rename or remove local vars to avoid shadowing.
8553 (Ftranslate_region_internal): Mark var as initialized.
8554
8555 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8556 avoid shadowing.
8557
8558 * lisp.h (eassert): Check that the argument compiles, even if
8559 ENABLE_CHECKING is not defined.
8560
8561 * data.c (Findirect_variable): Name an expression, to avoid
8562 gcc -Wbad-function-cast warning.
8563 (default_value, arithcompare, arith_driver, arith_error): Now static.
8564 (store_symval_forwarding): Rename local to avoid shadowing.
8565 (Fmake_variable_buffer_local, Fmake_local_variable):
8566 Mark variables as initialized.
8567 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8568
8569 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8570 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8571 Rename locals to avoid shadowing.
8572 (mark_stack): Move local variables into the #ifdef region where
8573 they're used.
8574 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8575 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8576 needed otherwise.
8577 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8578 (GC_STRING_CHARS): Remove; not used.
8579 (Fmemory_limit): Cast sbrk's returned value to char *.
8580
8581 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8582 avoids undefined behavior in theory.
8583
8584 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8585
8586 Use functions, not macros, for up- and down-casing (Bug#8254).
8587 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8588 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8589 to use the following functions instead of these macros.
8590 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8591 EMACS_INT, since callers assume the returned value fits in int.
8592 (upcase1): Likewise, for UPCASE_TABLE.
8593 (uppercasep, lowercasep, upcase): New static inline functions.
8594 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8595 the race-condition problem in the old DOWNCASE.
8596
8597 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8598 Rename locals to avoid shadowing.
8599 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8600 (regex_compile, re_search_2, re_match_2_internal):
8601 Remove unused local vars.
8602 (FREE_VAR): Rewrite so as not to use empty "else",
8603 which gcc can warn about.
8604 (regex_compile, re_match_2_internal): Mark locals as initialized.
8605 (RETALLOC_IF): Define only if needed.
8606 (WORDCHAR_P): Likewise. This one is never needed, but is used
8607 only in a comment talking about a compiler bug, so put inside
8608 the #if 0 of that comment.
8609 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8610 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8611 Remove; unused.
8612
8613 * search.c (boyer_moore): Rename locals to avoid shadowing.
8614 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8615 (PREV_CHAR_BOUNDARY): Likewise.
8616
8617 * search.c (simple_search): Remove unused var.
8618
8619 * dired.c (compile_pattern): Move decl from here ...
8620 * lisp.h: ... to here, so that it can be checked.
8621 (struct re_registers): New forward decl.
8622
8623 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8624
8625 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8626 All uses changed.
8627 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8628 Rename locals to avoid shadowing.
8629 (Fvertical_motion): Mark locals as initialized.
8630
8631 * casefiddle.c (casify_object, casify_region): Now static.
8632 (casify_region): Mark local as initialized.
8633
8634 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8635
8636 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8637 New macros, so that the caller can use some names other than
8638 gcpro1, gcpro2, etc.
8639 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8640 of the new macros.
8641 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8642 argument, for consistency with GCPRO2_VAR, etc: it is now the
8643 prefix of the variable, not the variable itself. All uses
8644 changed.
8645 * dired.c (directory_files_internal, file_name_completion):
8646 Rename locals to avoid shadowing.
8647
8648 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8649 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8650 dired.c's scmp function, had undefined behavior.
8651 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8652 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8653 * buffer.h: ... to here, because these macros use current_buffer,
8654 and the new implementation with inline functions needs to have
8655 current_buffer in scope now, rather than later when the macros
8656 are used.
8657 (downcase, upcase1): New static inline functions.
8658 (DOWNCASE, UPCASE1): Reimplement using these functions.
8659 This avoids undefined behavior in expressions like
8660 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8661 from race conditions in accessing the global variables
8662 case_temp1 and case_temp2.
8663 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8664 * lisp.h (case_temp1, case_temp2): Remove their decls.
8665 * character.h (ASCII_CHAR_P): Move from here ...
8666 * lisp.h: ... to here, so that the inline functions mentioned
8667 above can use them.
8668
8669 * dired.c (directory_files_internal_unwind): Now static.
8670
8671 * fileio.c (file_name_as_directory, directory_file_name):
8672 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8673 Now static.
8674 (file_name_as_directory): Use const pointers when appropriate.
8675 (Fexpand_file_name): Likewise. In particular, newdir might
8676 point at constant storage, so make it a const pointer.
8677 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8678 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8679 signedness issues.
8680 (Fset_file_times, Finsert_file_contents, auto_save_error):
8681 Rename locals to avoid shadowing.
8682
8683 * minibuf.c (choose_minibuf_frame_1): Now static.
8684 (Ftry_completion, Fall_completions): Rename or remove locals
8685 to avoid shadowing.
8686
8687 * marker.c (bytepos_to_charpos): Remove; unused.
8688
8689 * lisp.h (verify_bytepos, count_markers): New decls,
8690 so that gcc does not warn that these functions aren't declared.
8691
8692 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8693 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8694 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8695 (copy_text): Remove unused local var.
8696
8697 * filelock.c (within_one_second): Now static.
8698 (lock_file_1): Rename local to avoid shadowing.
8699
8700 * buffer.c (fix_overlays_before): Mark locals as initialized.
8701 (fix_start_end_in_overlays): Likewise. This function should be
8702 simplified by using pointers-to-pointers, but that's a different
8703 matter.
8704 (switch_to_buffer_1): Now static.
8705 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8706 (report_overlay_modification): Rename locals to avoid shadowing.
8707
8708 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8709 Fix pointer signedness issue.
8710 (sys_subshell): Mark local as volatile if checking for lint,
8711 to suppress a gcc -Wclobbered warning that does not seem to be right.
8712 (MAXPATHLEN): Define only if needed.
8713
8714 * process.c (serial_open, serial_configure): Move decls from here ...
8715 * systty.h: ... to here, so that they can be checked.
8716
8717 * fns.c (get_random, seed_random): Move extern decls from here ...
8718 * lisp.h: ... to here, so that they can be checked.
8719
8720 * sysdep.c (reset_io): Now static.
8721 (wait_for_termination_signal): Remove; unused.
8722
8723 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8724 (copy_keymap_item, append_key, push_text_char_description):
8725 Now static.
8726 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8727 (DENSE_TABLE_SIZE): Remove; unused.
8728 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8729 (describe_map_tree):
8730 Rename locals to avoid shadowing.
8731
8732 * keyboard.c: Declare functions static if they are not used elsewhere.
8733 (echo_char, echo_dash, cmd_error, top_level_2):
8734 (poll_for_input, handle_async_input): Now static.
8735 (read_char, kbd_buffer_get_event, make_lispy_position):
8736 (make_lispy_event, make_lispy_movement, apply_modifiers):
8737 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8738 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8739 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8740 (read_key_sequence, read_char): Mark locals as initialized.
8741 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8742
8743 * keyboard.h (make_ctrl_char): New decl.
8744 (mark_kboards): Move decl here ...
8745 * alloc.c (mark_kboards): ... from here.
8746
8747 * lisp.h (force_auto_save_soon): New decl.
8748
8749 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8750 (DEFINE_DUMMY_FUNCTION): New macro.
8751 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8752 Use it.
8753 (main): Add casts to avoid warnings
8754 if GCC considers string literals to be constants.
8755
8756 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8757
8758 * dbusbind.c: Pointer signedness fixes.
8759 (xd_signature, xd_append_arg, xd_initialize):
8760 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8761 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8762 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8763 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8764
8765 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8766 if GCC considers string literals to be constants.
8767 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8768
8769 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8770
8771 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8772 (print_preprocess, print_object): New macro to fix last change.
8773
8774 * print.c (print_preprocess): Don't forget font objects.
8775
8776 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8777
8778 * emacs.c (USAGE3): Doc fixes.
8779
8780 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8781
8782 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8783 structure.
8784
8785 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8786
8787 * lisp.h (VWindow_system, Qfile_name_history):
8788 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8789 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8790 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8791
8792 * w32select.c: Don't #include "keyboard.h".
8793 (run_protected): Add extern declaration for waiting_for_input.
8794
8795 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8796 * w32console.c (detect_input_pending, read_input_pending)
8797 (encode_terminal_code):
8798 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8799 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8800 (w32_system_caret_y, Qfile_name_history):
8801 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8802 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8803 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8804 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8805 * w32proc.c (Qlocal, report_file_error):
8806 * w32term.c (Vwindow_system, updating_frame):
8807 * w32uniscribe.c (initialized, uniscribe_font_driver):
8808 Remove unneeded extern declarations.
8809
8810 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8811
8812 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8813
8814 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8815
8816 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8817 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8818 These macros can no longer be used for assignment.
8819
8820 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8821 Assign struct members directly, instead of using BUF_BEGV etc.
8822 (record_buffer_markers, fetch_buffer_markers): New functions for
8823 recording and fetching special buffer markers.
8824 (set_buffer_internal_1, set_buffer_temp): Use them.
8825
8826 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8827
8828 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8829
8830 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8831 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8832
8833 * xdisp.c (hscroll_window_tree):
8834 (reconsider_clip_changes): Use PT instead of BUF_PT.
8835
8836 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8837
8838 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8839 $(EMACS_ROOT)/lib/intprops.h.
8840
8841 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8842
8843 Fix more problems found by GCC 4.5.2's static checks.
8844
8845 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8846 to unsigned char * to avoid compiler diagnostic.
8847 (xg_free_frame_widgets): Make it clear that a local variable is
8848 needed only if USE_GTK_TOOLTIP.
8849 (gdk_window_get_screen): Make it clear that this macro is needed
8850 only if USE_GTK_TOOLTIP.
8851 (int_gtk_range_get_value): New function, which avoids a diagnostic
8852 from gcc -Wbad-function-cast.
8853 (xg_set_toolkit_scroll_bar_thumb): Use it.
8854 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8855 diagnostic from gcc -Wbad-function-cast.
8856 (get_utf8_string, xg_get_file_with_chooser):
8857 Rename locals to avoid shadowing.
8858 (create_dialog): Move locals to avoid shadowing.
8859
8860 * xgselect.c (xg_select): Remove unused var.
8861
8862 * image.c (four_corners_best): Mark locals as initialized.
8863 (gif_load): Initialize transparent_p to zero (Bug#8238).
8864 Mark another local as initialized.
8865 (my_png_error, my_error_exit): Mark with NO_RETURN.
8866
8867 * image.c (clear_image_cache): Now static.
8868 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8869 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8870 (x_edge_detection): Remove unnecessary cast that
8871 gcc -Wbad-function-cast diagnoses.
8872 (gif_load): Fix pointer signedness.
8873 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8874 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8875
8876 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8877
8878 Improve quality of tests for time stamp overflow.
8879 For example, without this patch (encode-time 0 0 0 1 1
8880 1152921504606846976) returns the obviously-bogus value (-948597
8881 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8882 reports time overflow. See
8883 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8884 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8885 * editfns.c: Include limits.h and intprops.h.
8886 (TIME_T_MIN, TIME_T_MAX): New macros.
8887 (time_overflow): Move earlier, to before first use.
8888 (hi_time, lo_time): New functions, for an accurate test for
8889 out-of-range times.
8890 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8891 (Fget_internal_run_time): Don't assume time_t fits in int.
8892 (make_time): Use list2 instead of Fcons twice.
8893 (Fdecode_time): More accurate test for out-of-range times.
8894 (check_tm_member): New function.
8895 (Fencode_time): Use it, to test for out-of-range times.
8896 (lisp_time_argument): Don't rely on undefined left-shift and
8897 right-shift behavior when checking for time stamp overflow.
8898
8899 * editfns.c (time_overflow): New function, refactoring common code.
8900 (Fformat_time_string, Fdecode_time, Fencode_time):
8901 (Fcurrent_time_string): Use it.
8902
8903 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8904 * dired.c (make_time): Move to ...
8905 * editfns.c (make_time): ... here.
8906 * systime.h: Note the move.
8907
8908 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8909
8910 * fringe.c (update_window_fringes): Remove unused variables.
8911
8912 * unexmacosx.c (copy_data_segment): Also copy __got section.
8913 (Bug#8223)
8914
8915 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8916
8917 * termcap.c [MSDOS]: Include "msdos.h".
8918 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8919 Constify `char *' arguments and their references according to
8920 prototypes in tparam.h.
8921
8922 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8923
8924 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8925 Adapt all references accordingly.
8926
8927 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8928
8929 2011-03-11 Tom Tromey <tromey@redhat.com>
8930
8931 * buffer.c (syms_of_buffer): Remove obsolete comment.
8932
8933 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8934
8935 * termhooks.h (encode_terminal_code): Declare prototype.
8936
8937 * msdos.c (encode_terminal_code): Don't declare prototype.
8938
8939 * term.c (encode_terminal_code): Now external again, used by
8940 w32console.c and msdos.c.
8941
8942 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8943 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8944
8945 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8946
8947 Fix some minor problems found by GCC 4.5.2's static checks.
8948
8949 * fringe.c (update_window_fringes): Mark locals as initialized
8950 (Bug#8227).
8951 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8952
8953 * alloc.c (mark_fringe_data): Move decl from here ...
8954 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8955 to check its interface.
8956 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8957
8958 * fontset.c (free_realized_fontset): Now static.
8959 (Fset_fontset_font): Rename local to avoid shadowing.
8960 (fontset_font): Mark local as initialized.
8961 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8962
8963 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8964
8965 * xselect.c (x_disown_buffer_selections): Remove; not used.
8966 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8967 (x_own_selection, Fx_disown_selection_internal): Rename locals
8968 to avoid shadowing.
8969 (x_handle_dnd_message): Remove local to avoid shadowing.
8970
8971 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8972 so that the caller can use some name other than gcpro1.
8973 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8974 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8975 (Fx_backspace_delete_keys_p):
8976 Use them to avoid shadowing, and rename vars to avoid shadowing.
8977 (x_decode_color, x_set_name, x_window): Now static.
8978 (Fx_create_frame): Add braces to silence GCC warning.
8979 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8980 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8981 Remove unused locals.
8982 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8983 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8984 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8985 macros.
8986
8987 * xterm.h (x_mouse_leave): New decl.
8988
8989 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8990 Remove unused functions.
8991 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8992 (x_calc_absolute_position): Now static.
8993 (XTread_socket): Don't define label "out" unless it's used.
8994 Don't declare local "event" unless it's used.
8995 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8996 unless they are used.
8997 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8998 (x_fatal_error_signal): Remove; not used.
8999 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9000 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9001 (x_error_catcher, x_connection_closed, x_error_handler):
9002 (x_error_quitter, xembed_send_message, x_iconify_frame):
9003 (my_log_handler): Rename locals to avoid shadowing.
9004 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9005 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9006
9007 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9008 Rename or move locals to avoid shadowing.
9009 (tty_defined_color, merge_face_heights): Now static.
9010 (free_realized_faces_for_fontset): Remove; not used.
9011 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9012 does not deduce is never used uninitialized.
9013 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9014 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9015
9016 * terminal.c (store_terminal_param): Now static.
9017
9018 * xmenu.c (menu_highlight_callback): Now static.
9019 (set_frame_menubar): Remove unused local.
9020 (xmenu_show): Rename parameter to avoid shadowing.
9021 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9022 since they might point to immutable storage.
9023 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9024 since it's unused otherwise.
9025
9026 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9027 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9028 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9029 avoids a gcc -Wuninitialized diagnostic.
9030 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9031 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9032 does not deduce are never used uninitialized.
9033
9034 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9035
9036 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9037 * window.c (window_loop, size_window):
9038 (run_window_configuration_change_hook, enlarge_window): Likewise.
9039
9040 * window.c (display_buffer): Now static.
9041 (size_window): Mark variables that gcc -Wuninitialized
9042 does not deduce are never used uninitialized.
9043 * window.h (check_all_windows): New decl, to forestall
9044 gcc -Wmissing-prototypes diagnostic.
9045 * dispextern.h (bidi_dump_cached_states): Likewise.
9046
9047 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9048 shadowing.
9049 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9050 Include <limits.h>.
9051 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9052 and to avoid gcc -Wuninitialized warning.
9053 (load_charset_map): Mark variables that gcc -Wuninitialized
9054 does not deduce are never used uninitialized.
9055 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9056
9057 * coding.c (coding_set_source, coding_set_destination):
9058 Use "else { /* comment */ }" rather than "else /* comment */;"
9059 for clarity, and to avoid gcc -Wempty-body warning.
9060 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9061 a block, when the outer 'i' will do.
9062 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9063 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9064 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9065 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9066 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9067 Rename locals to avoid shadowing.
9068 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9069 * coding.c (emacs_mule_char, encode_invocation_designation):
9070 Now static, since they're not used elsewhere.
9071 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9072 (decode_coding_object, encode_coding_object, detect_coding_system):
9073 (decode_coding_emacs_mule): Mark variables that gcc
9074 -Wuninitialized does not deduce are never used uninitialized.
9075 (detect_coding_iso_2022): Initialize a local variable that might
9076 be used uninitialized. Leave a FIXME because it's not clear that
9077 this initialization is needed. (Bug#8211)
9078 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9079 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9080 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9081 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9082 Remove unused macros.
9083
9084 * category.c (hash_get_category_set): Remove unused local var.
9085 (copy_category_table): Now static, since it's not used elsewhere.
9086 * character.c (string_count_byte8): Likewise.
9087
9088 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9089 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9090
9091 * chartab.c (copy_sub_char_table): Now static, since it's not used
9092 elsewhere.
9093 (sub_char_table_ref_and_range, char_table_ref_and_range):
9094 Rename locals to avoid shadowing.
9095 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9096
9097 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9098 (BIDI_BOB): Remove unused macro.
9099
9100 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9101 deduce are never used uninitialized.
9102 * term.c (encode_terminal_code): Likewise.
9103
9104 * term.c (encode_terminal_code): Now static. Remove unused local.
9105
9106 * tparam.h: New file.
9107 * term.c, tparam.h: Include it.
9108 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9109 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9110 Move these decls to tparam.h, and make them agree with what
9111 is actually in tparam.c. The previous trick of using incompatible
9112 decls in different modules does not conform to the C standard.
9113 All callers of tparam changed to use tparam's actual API.
9114 * tparam.c (tparam1, tparam, tgoto):
9115 Use const pointers where appropriate.
9116
9117 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9118 * cm.h (struct cm): Likewise.
9119 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9120 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9121 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9122 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9123 (turn_on_face, init_tty): Likewise.
9124 * termchar.h (struct tty_display_info): Likewise.
9125
9126 * term.c (term_mouse_position): Rename local to avoid shadowing.
9127
9128 * alloc.c (mark_ttys): Move decl from here ...
9129 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9130
9131 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9132
9133 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9134
9135 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9136
9137 * search.c (compile_pattern_1): Remove argument regp, unused since
9138 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9139 (compile_pattern): Don't pass it.
9140
9141 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9142
9143 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9144 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9145 for ! HAVE_GTK3.
9146 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9147
9148 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9149
9150 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9151 gdk_window_get_screen, gdk_window_get_geometry,
9152 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9153 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9154 (xg_get_pixbuf_from_pixmap): New function.
9155 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9156 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9157 Call xg_get_pixbuf_from_pixmap instead of
9158 gdk_pixbuf_get_from_drawable.
9159 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9160 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9161 (xg_check_special_colors): Use GtkStyleContext and its functions
9162 for HAVE_GTK3.
9163 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9164 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9165 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9166 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9167 Call gtk_widget_get_preferred_size.
9168 (xg_frame_resized): gdk_window_get_geometry only takes 5
9169 parameters.
9170 (xg_win_to_widget, xg_event_is_for_menubar):
9171 Call gdk_x11_window_lookup_for_display.
9172 (xg_set_widget_bg): New function.
9173 (delete_cb): New function.
9174 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9175 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9176 (xg_set_background_color): Call xg_set_widget_bg.
9177 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9178 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9179 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9180 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9181 if ! HAVE_GTK3.
9182 (update_frame_tool_bar): Call gtk_widget_hide.
9183 (xg_initialize): Use GDK_KEY_g.
9184
9185 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9186 if ! HAVE_GTK3
9187 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9188
9189 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9190 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9191 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9192
9193 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9194
9195 * w32xfns.c (select_palette): Check success of RealizePalette against
9196 GDI_ERROR, not zero.
9197
9198 See ChangeLog.11 for earlier changes.
9199
9200 ;; Local Variables:
9201 ;; coding: utf-8
9202 ;; End:
9203
9204 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9205
9206 This file is part of GNU Emacs.
9207
9208 GNU Emacs is free software: you can redistribute it and/or modify
9209 it under the terms of the GNU General Public License as published by
9210 the Free Software Foundation, either version 3 of the License, or
9211 (at your option) any later version.
9212
9213 GNU Emacs is distributed in the hope that it will be useful,
9214 but WITHOUT ANY WARRANTY; without even the implied warranty of
9215 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9216 GNU General Public License for more details.
9217
9218 You should have received a copy of the GNU General Public License
9219 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.