Add Bug#.
[bpt/emacs.git] / src / ChangeLog
1 2011-12-29 Paul Eggert <eggert@cs.ucla.edu>
2
3 emacs: fix an auto-save permissions race condition (Bug#10400)
4 * fileio.c (auto_saving_dir_umask): New static var.
5 (Fmake_directory_internal): Use it.
6 (do_auto_save_make_dir): Set it, instead of invoking chmod after
7 creating the directory. The old code temporarily assigns
8 too-generous permissions to the directory.
9 (do_auto_save_eh): Clear it.
10 (Fdo_auto_save): Catch all errors, not just file errors, so
11 that the var is always cleared.
12
13 2011-12-28 Kenichi Handa <handa@m17n.org>
14
15 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
16 coding-system ASCII compatible only when it does not produce BOM
17 on encoding (Bug#10383).
18
19 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
20
21 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
22 can scroll.
23 (create_and_show_popup_menu): Always use menu_position_func for
24 Gtk3 (Bug#10361).
25
26 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
27
28 * callint.c (Fcall_interactively): Don't truncate prompt string.
29
30 2011-12-23 Eli Zaretskii <eliz@gnu.org>
31
32 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
33 property that ends at ZV, so that the bidi iteration could be
34 resumed from there (after widening). (Bug#10360)
35
36 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
37
38 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
39
40 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
41
42 * nsterm.m (x_free_frame_resources): Release
43 f->output_data.ns->miniimage
44 (ns_index_color): Fix indentation. Do not retain
45 color_table->colors[i].
46
47 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
48 before returning.
49
50 * nsfns.m (x_set_background_color): Assign return value from
51 ns_index_color to face-background instead of NSColor*.
52 (ns_implicitly_set_icon_type): Fix indentation.
53 Change assignment in for loop to comparison.
54
55 * emacs.c (ns_pool): New variable.
56 (main): Assign ns_pool.
57 (Fkill_emacs): Call ns_release_autorelease_pool.
58
59 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
60 autorelease fdesc, release fdAttrs and tdict.
61 (ns_get_covering_families): Release charset.
62 (ns_findfonts): Release NSFontDescriptor created with new.
63 (ns_uni_to_glyphs): Fix indentation.
64 (setString): Release attrStr before assigning new value.
65
66 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
67
68 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
69 and NS_IMPL_COCOA.
70 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
71 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
72
73 2011-12-18 David Reitter <reitter@cmu.edu>
74
75 * nsterm.m (ns_term_init): Subscribe for notifications
76 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
77 to method trackingNotification in EmacsMenu.
78
79 * nsmenu.m (trackingMenu): New variable.
80 (trackingNotification): New method (from Aquamacs).
81 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
82 from Aquamacs (Bug#7030).
83
84 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
85
86 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
87 (symbol_to_nsstring): Fix indentation.
88 (ns_symbol_to_pb): New function.
89 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
90 (Fns_rotate_cut_buffers_internal): Removed.
91 (Fns_store_selection_internal): Renamed from
92 Fns_store_cut_buffer_internal.
93 (ns_get_foreign_selection, Fx_own_selection_internal)
94 (Fx_disown_selection_internal, Fx_selection_exists_p)
95 (Fns_get_selection_internal, Fns_store_selection_internal): Use
96 ns_symbol_to_pb and check if return value is nil.
97 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove
98 defsubr Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
99 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
100 renamed to Sns_store_selection_internal.
101 (ns_handle_selection_request): Move code to Fx_own_selection_internal
102 and remove this function.
103 (ns_handle_selection_clear): Remove, never used.
104 (Fx_own_selection_internal): Move code from ns_handle_selection_request
105 here.
106
107 2011-12-17 Ken Brown <kbrown@cornell.edu>
108
109 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
110 GID is unknown (Bug#10257).
111
112 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
113
114 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
115 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
116 which caused a build failure on GNU/Linux IA-64. This problem was
117 introduced by my 2011-10-07 patch.
118
119 2011-12-15 Juri Linkov <juri@jurta.org>
120
121 * image.c (imagemagick_error): New function. (Bug#10112)
122 (imagemagick_load_image): Comment out `MagickSetResolution' call.
123 Use `imagemagick_error' where ImageMagick functions return
124 `MagickFalse'.
125 (Fimagemagick_types): Add `Fnreverse' to return the list in the
126 proper order.
127
128 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
129
130 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
131 fill background (Bug#8992).
132
133 2011-12-13 Martin Rudalics <rudalics@gmx.at>
134
135 * window.c (Vwindow_combination_resize)
136 (Vwindow_combination_limit): Use t instead of non-nil in
137 doc-strings.
138 (Vrecenter_redisplay): Add first sentence of doc-string on
139 separate line.
140 (Frecenter): Fix doc-string typo.
141
142 2011-12-11 Kenichi Handa <handa@m17n.org>
143
144 * coding.c (Funencodable_char_position): Pay attention to the
145 buffer text relocation (Bug#9389).
146
147 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
148
149 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
150 gtk_init (Bug#10100).
151
152 2011-12-10 Eli Zaretskii <eliz@gnu.org>
153
154 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
155 IT->string is nil. (Bug#10263)
156
157 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
158
159 * nsterm.h (x_free_frame_resources): Declare.
160
161 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
162 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
163
164 * nsterm.h (ns_get_defaults_value): Declare.
165
166 * nsterm.m (ns_default): Call ns_get_defaults_value.
167
168 2011-12-09 Eli Zaretskii <eliz@gnu.org>
169
170 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
171 (Bug#10170)
172
173 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
174
175 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
176 that where the value of an _OBJC_* symbol points to is in the .bss
177 section (Bug#10240).
178
179 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
180
181 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
182 after the loop to call ccl_driver at least once (Bug#8619).
183
184 2011-12-08 Kenichi Handa <handa@m17n.org>
185
186 * ftfont.c (get_adstyle_property): Fix previous change
187 (Bug#10233).
188
189 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
190
191 * w32.c (init_environment): If no_site_lisp, remove site-lisp
192 dirs from the default value of EMACSLOADPATH (bug#10208).
193
194 2011-12-07 Glenn Morris <rgm@gnu.org>
195
196 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
197 installation and source directories as well. (Bug#10208)
198
199 2011-12-06 Chong Yidong <cyd@gnu.org>
200
201 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
202
203 2011-12-06 Glenn Morris <rgm@gnu.org>
204
205 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
206 as an error, not just -1. (Bug#10217)
207
208 2011-12-05 Chong Yidong <cyd@gnu.org>
209
210 * keyboard.c (process_special_events): New function.
211 (swallow_events, Finput_pending_p): Use it (Bug#10195).
212
213 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
214
215 * coding.c (encode_designation_at_bol): Don't use uninitialized
216 local variable (Bug#9318).
217
218 2011-12-05 Kenichi Handa <handa@m17n.org>
219
220 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
221 return Qnil (Bug#8046, Bug#10193).
222
223 2011-12-05 Kenichi Handa <handa@m17n.org>
224
225 * coding.c (encode_designation_at_bol): New args charbuf_end and
226 dst. Return the number of produced bytes. Callers changed.
227 (coding_set_source): Return how many bytes coding->source was
228 relocated.
229 (coding_set_destination): Return how many bytes
230 coding->destination was relocated.
231 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
232 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
233
234 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
235
236 * coding.c (CODING_CHAR_CHARSET_P): New macro.
237 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
238 macro (Bug#9318).
239
240 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
241
242 The following changes are to fix Bug#9318.
243
244 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
245 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
246 (encode_coding_iso_2022, encode_coding_sjis)
247 (encode_coding_big5, encode_coding_charset): Use the above macros.
248
249 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
250
251 * lisp.h (process_quit_flag): Fix external declaration.
252
253 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
254
255 Don't macro-inline non-performance-critical code.
256 * eval.c (process_quit_flag): New function.
257 * lisp.h (QUIT): Use it.
258
259 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
260
261 * nsfns.m (get_geometry_from_preferences): New function.
262 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
263
264 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
265
266 * emacs.c (Qkill_emacs): Define.
267 (syms_of_emacs): Initialize it.
268 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
269 Qquit_flag to `kill-emacs' instead.
270 (quit_throw_to_read_char): Add parameter `from_signal'.
271 All callers changed. Call Fkill_emacs if requested and safe.
272 * lisp.h (QUIT): Call Fkill_emacs if requested.
273
274 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
275
276 * widget.c (update_wm_hints): Return if wmshell is null.
277 (widget_update_wm_size_hints): New function.
278
279 * widget.h (widget_update_wm_size_hints): Declare.
280
281 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
282 widget_update_wm_size_hints (Bug#10104).
283
284 2011-12-03 Eli Zaretskii <eliz@gnu.org>
285
286 * xdisp.c (handle_invisible_prop): If the invisible text ends just
287 before a newline, prepare the bidi iterator for consuming the
288 newline, and keep the current paragraph direction. (Bug#10183)
289 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
290
291 2011-12-02 Juri Linkov <juri@jurta.org>
292
293 * search.c (Fword_search_regexp): New Lisp function created from
294 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
295 (Fword_search_backward, Fword_search_forward)
296 (Fword_search_backward_lax, Fword_search_forward_lax):
297 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
298 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
299
300 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
301
302 * fileio.c (Finsert_file_contents): Move after-change-function call
303 to before the "handled:" label, since all "goto handled" appear in
304 cases where the *-change-functions have already been properly called
305 (bug#10117).
306
307 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
308
309 * keyboard.c (interrupt_signal): Don't call kill-emacs when
310 waiting for input. (Bug#10169)
311
312 2011-11-30 Eli Zaretskii <eliz@gnu.org>
313
314 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
315 verifies glyph row's hash code--we have just reallocated the
316 glyphs, so their contents can be complete garbage. (Bug#10164)
317
318 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
319
320 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
321
322 2011-11-30 Eli Zaretskii <eliz@gnu.org>
323
324 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
325 attributes are tested _before_ calling verify_row_hash, to protect
326 against GCC re-ordering of the tests. (Bug#10164)
327
328 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
329
330 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
331
332 * xterm.c (handle_one_xevent): Only set async_visible and friends
333 if net_wm_state_hidden_seen is non-zero (Bug#10002)
334 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
335 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
336
337 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
338
339 Remove GCPRO-related macros that exist only to avoid shadowing locals.
340 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
341 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
342 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
343 All uses changed to use GCPRO1 etc.
344 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
345 Revert to old implementation (i.e., before 2011-03-11).
346
347 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
348
349 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
350 of scroll runs so as to avoid assigning disabled bogus rows and
351 unnecessary graphics copy operations.
352
353 2011-11-27 Eli Zaretskii <eliz@gnu.org>
354
355 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
356 (snprintf) [_MSC_VER]: Redirect to _snprintf.
357 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
358 (malloc, free, realloc, calloc): Redirect to e_* only when
359 compiling Emacs.
360
361 * lisp.h (GCTYPEBITS): Move before first use.
362 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
363 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
364 this macro definition.
365
366 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
367 _MSC_VER.
368
369 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
370
371 * gtkutil.c (xg_create_frame_widgets):
372 Call gtk_window_set_has_resize_grip (FALSE) if that function is
373 present with Gtk+ 2.0.
374
375 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
376
377 * fileio.c (Finsert_file_contents): Undo previous change; see
378 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
379
380 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
381
382 Rename locals to avoid shadowing.
383 * fileio.c (Finsert_file_contents):
384 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
385 * process.c (wait_reading_process_output):
386 Rename inner 'proc' to 'p' to avoid shadowing.
387 Indent for consistency with usual Emacs style.
388
389 2011-11-25 Eli Zaretskii <eliz@gnu.org>
390
391 * xdisp.c (redisplay_window): If cursor row is not fully visible
392 after recentering, and scroll-conservatively is set to a large
393 number, scroll window by a few more lines to make the cursor fully
394 visible and out of scroll-margin. (Bug#10105)
395 (start_display): Don't move to the next line if the display should
396 start at a newline that is part of a display vector or an overlay
397 string. (Bug#10119)
398
399 2011-11-24 Juri Linkov <juri@jurta.org>
400
401 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
402 after the `MagickPingImage' call. (Bug#10112)
403
404 2011-11-23 Chong Yidong <cyd@gnu.org>
405
406 * window.c (Fcoordinates_in_window_p): Accept only live windows.
407
408 2011-11-23 Martin Rudalics <rudalics@gmx.at>
409
410 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
411 making another buffer current. (Bug#10114)
412
413 2011-11-23 Glenn Morris <rgm@gnu.org>
414
415 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
416
417 2011-11-23 Chong Yidong <cyd@gnu.org>
418
419 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
420 using it (Bug#5984).
421
422 2011-11-22 Eli Zaretskii <eliz@gnu.org>
423
424 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
425 and header-lines, as they don't have one computed for them.
426 (Bug#10098)
427
428 * .gdbinit (prow): Make displayed values more self-explaining.
429 Add row's hash code.
430
431 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
432
433 * process.c (wait_reading_process_output): Fix asynchrounous
434 GnuTLS socket handling on some versions of the GnuTLS library.
435 (wait_reading_process_output): Add comment and URL.
436
437 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
438
439 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
440
441 2011-11-21 Chong Yidong <cyd@gnu.org>
442
443 * window.c (Fnext_window, Fprevious_window): Doc fix.
444
445 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
446
447 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
448
449 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
450
451 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
452
453 2011-11-20 Martin Rudalics <rudalics@gmx.at>
454
455 * window.c (Fset_window_combination_limit): Rename argument
456 STATUS to LIMIT.
457 (Vwindow_combination_limit): Remove "status" from doc-string.
458
459 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
460
461 * m/ibms390.h: Remove.
462 * m/ibms390x.h: Don't include "ibms390.h".
463
464 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
465
466 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
467 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
468
469 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
470
471 * casetab.c (Fset_case_table):
472 * charset.c (Fcharset_after): Fix typos.
473
474 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
475
476 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
477 Otherwise, valgrind does not work on some platforms.
478 Problem reported by Andreas Schwab in
479 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
480 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
481 is set, removing the need for VIRT_ADDRESS_VARIES.
482 (PURE_P): Use a more-efficient implementation that needs just one
483 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
484 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
485 to 4 (xorl, subq, cmpq, setbe).
486 * alloc.c (pure): Always extern now, since that's the
487 VIRT_ADDR_VARIES behavior.
488 (PURE_POINTER_P): Use a single comparison, not two, for
489 consistency with the new puresize.h.
490 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
491 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
492 Remove VIRT_ADDR_VARIES no longer needed.
493
494 2011-11-19 Eli Zaretskii <eliz@gnu.org>
495
496 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
497 (erase_phys_cursor, update_window_cursor, show_mouse_face)
498 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
499 behave as if the cursor position were at the window margin.
500
501 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
502 and the cursor position is out of bounds, behave as if the cursor
503 position were at the window margin. (Bug#10075)
504
505 2011-11-18 Chong Yidong <cyd@gnu.org>
506
507 * window.c (Fwindow_combination_limit): Make first argument
508 non-optional, since it is meaningless for live windows like the
509 selected window.
510
511 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
512
513 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
514
515 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
516
517 * intervals.c: Fix grafting over the whole buffer (bug#10071).
518 (graft_intervals_into_buffer): Simplify.
519
520 2011-11-18 Eli Zaretskii <eliz@gnu.org>
521
522 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
523 hash values of the two rows.
524 (copy_row_except_pointers): Preserve the used[] arrays and the
525 hash values of the two rows. (Bug#10035)
526 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
527
528 * xdisp.c (row_hash): New function, body extracted from
529 compute_line_metrics.
530 (compute_line_metrics): Call row_hash, instead of computing the
531 hash code inline.
532
533 * dispnew.c (verify_row_hash): Call row_hash for computing the
534 hash code of a row, instead of duplicating code from xdisp.c.
535
536 * dispextern.h (row_hash): Add prototype.
537
538 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
539
540 * frame.c (delete_frame): Don't delete the terminal when the last
541 X frame is closed if emacs is built with GTK toolkit.
542
543 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
544
545 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
546
547 2011-11-17 Martin Rudalics <rudalics@gmx.at>
548
549 * window.c (Vwindow_splits): Rename to
550 Vwindow_combination_resize. Suggested by Juri Linkov.
551 (Fsplit_window_internal): Use Vwindow_combination_resize instead
552 of Vwindow_splits.
553
554 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
555
556 * nsfns.m (Fns_font_name):
557 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
558
559 2011-11-16 Martin Rudalics <rudalics@gmx.at>
560
561 * window.h (window): Rename slot "nest" to "combination_limit".
562 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
563 (Fset_window_nest): Rename to Fset_window_combination_limit.
564 (Vwindow_nest): Rename to Vwindow_combination_limit.
565 (recombine_windows, make_parent_window, make_window)
566 (Fsplit_window_internal, saved_window)
567 (Fset_window_configuration, save_window_save): Rename all
568 occurrences of window_nest to window_combination_limit.
569
570 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
571
572 * image.c (imagemagick_load_image): Fix typo.
573
574 2011-11-14 Eli Zaretskii <eliz@gnu.org>
575
576 * xdisp.c (display_line): Move the call to
577 highlight_trailing_whitespace before the call to
578 compute_line_metrics, since the latter needs to see the final
579 faces of all the glyphs to compute ROW's hash value.
580 Fixes assertion violations in row_equal_p. (Bug#10035)
581
582 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
583
584 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
585 just return (bug#10044).
586
587 2011-11-12 Eli Zaretskii <eliz@gnu.org>
588
589 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
590 with user-defined heap size. Bump the default size of the temacs
591 heap to 27MB, to avoid memory warning when running temacs.
592 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
593
594 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
595 current_matrix and desired_matrix. (Bug#9990)
596 (verify_row_hash) [XASSERTS]: New function.
597 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
598 that the hash value of glyph rows is correct.
599
600 2011-11-12 Martin Rudalics <rudalics@gmx.at>
601
602 * window.h (window): Remove splits slot.
603 * window.c (Fwindow_splits, Fset_window_splits): Remove.
604 (Fdelete_other_windows_internal, make_parent_window)
605 (make_window, Fsplit_window_internal, Fdelete_window_internal)
606 (Fset_window_configuration, save_window_save): Don't deal with
607 split status of windows.
608 (saved_window): Remove splits slot.
609 (Vwindow_splits): Rewrite doc-string.
610
611 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
612
613 * xfns.c (unwind_create_frame):
614 * nsfns.m (unwind_create_frame):
615 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
616 Vframe_list (Bug#9999).
617
618 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
619
620 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
621
622 2011-11-11 Kenichi Handa <handa@m17n.org>
623
624 * callproc.c (Fcall_process): Set the member dst_multibyte of
625 process_coding.
626
627 2011-11-11 Johan Bockgård <bojohan@gnu.org>
628
629 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
630 avoid a crash (bug#9496).
631
632 2011-11-09 Chong Yidong <cyd@gnu.org>
633
634 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
635 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
636
637 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
638
639 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
640
641 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
642
643 Avoid some portability problems by eschewing 'extern inline' functions.
644 The trivial performance wins aren't worth the portability hassles; see
645 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
646 et seq.
647 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
648 (window_box_width, window_box_left, window_box_left_offset)
649 (window_box_right, window_box_right_offset): Undo previous change,
650 by removing the "extern"s.
651 * intervals.c (adjust_intervals_for_insertion)
652 (adjust_intervals_for_deletion): Undo previous change,
653 making these static again.
654 (offset_intervals, temp_set_point_both, temp_set_point)
655 (copy_intervals_to_string): No longer inline.
656 * xdisp.c (window_text_bottom_y, window_box_width)
657 (window_box_height, window_box_left_offset)
658 (window_box_right_offset, window_box_left, window_box_right)
659 (window_box): No longer inline.
660
661 2011-11-08 Chong Yidong <cyd@gnu.org>
662
663 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
664 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
665 Signal an error if not a live window.
666 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
667 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
668
669 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
670
671 * lisp.h (syms_of_abbrev): Remove declaration.
672 Reported by CHENG Gao <chenggao@royau.me>.
673
674 2011-11-07 Eli Zaretskii <eliz@gnu.org>
675
676 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
677 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
678 of temacs in GUI mode.
679
680 2011-11-07 Martin Rudalics <rudalics@gmx.at>
681
682 * window.h: Declare delete_all_child_windows instead of
683 delete_all_subwindows.
684 * window.c (Fwindow_nest, Fset_window_nest)
685 (Fset_window_new_total, Fset_window_new_normal)
686 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
687 (delete_all_subwindows): Rename to delete_all_child_windows.
688 (Fdelete_other_windows_internal, Fset_window_configuration):
689 Call delete_all_child_windows instead of delete_all_subwindows.
690 * frame.c (delete_frame): Call delete_all_child_windows instead
691 of delete_all_subwindows.
692
693 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
694
695 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
696 This is also needed for porting to any host where GC_MARK_STACK is
697 not GC_MAKE_GCPROS_NOOPS.
698 (which_symbols): Use it.
699
700 2011-11-07 Kenichi Handa <handa@m17n.org>
701
702 * coding.c (coding_set_destination): Check coding->src_pos only
703 when coding->src_object is a buffer (bug#9910).
704
705 * process.c (send_process): Set the member src_multibyte of coding
706 to 0 (bug#9911) when sending a unibyte text.
707
708 * callproc.c (Fcall_process): Set the member src_multibyte of
709 process_coding to 0 (bug#9912).
710
711 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
712
713 * xmenu.c (cleanup_widget_value_tree): New function.
714 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
715 calling free_menubar_widget_value_tree directly (Bug#9830).
716
717 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
718
719 Fix some portability problems with 'inline'.
720 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
721 (window_box_width, window_box_left, window_box_left_offset)
722 (window_box_right, window_box_right_offset): Declare extern.
723 Otherwise, these inline functions do not conform to C99 and
724 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
725 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
726 * intervals.c (adjust_intervals_for_insertion)
727 (adjust_intervals_for_deletion): Now extern, because otherwise the
728 extern inline functions 'offset_intervals' couldn't refer to it.
729 (static_offset_intervals): Remove.
730 (offset_intervals): Rewrite using the old contents of
731 static_offset_intervals. The old version didn't conform to C99
732 because an extern inline function contained a reference to an
733 identifier with static linkage.
734
735 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
736
737 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
738 GC.
739
740 2011-11-06 Eli Zaretskii <eliz@gnu.org>
741
742 * xdisp.c (init_iterator, reseat_to_string): Don't set the
743 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
744 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
745 return Qleft_to_right.
746
747 2011-11-06 Chong Yidong <cyd@gnu.org>
748
749 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
750 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
751 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
752 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
753 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
754 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
755 (Fwindow_vscroll): Doc fix.
756 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
757 argument, since it makes no sense to pass a live window and for
758 consistency with window-child.
759
760 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
761
762 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
763 support MSVC.
764
765 2011-11-05 Jason Rumney <jasonr@gnu.org>
766
767 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
768 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
769 fonts (Bug#6029).
770 (add_font_entity_to_list): Fix logic errors in mixed boolean and
771 bitwise arithmetic preventing use of unicode-sip and non-truetype
772 opentype fonts.
773
774 2011-11-05 Eli Zaretskii <eliz@gnu.org>
775
776 * s/ms-w32.h (fstat, stat, utime): Move redirections to
777 "emacs"-only part.
778
779 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
780 initialization code to keep similarity to xfns.c after changes
781 from 2011-11-05.
782
783 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
784
785 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
786 (unwind_create_frame): New function (Bug#9943).
787 (Fx_create_frame): Restructure code to be more similar to the one in
788 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
789 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
790 Move terminal->reference_count++ just before making the frame official
791 (Bug#9943).
792
793 * nsterm.m (x_free_frame_resources): New function.
794 (x_destroy_window): Move code to x_free_frame_resources.
795
796 * xfns.c (unwind_create_frame): Fix comment.
797 (Fx_create_frame, x_create_tip_frame):
798 Move terminal->reference_count++ just before making the frame
799 official. Move initialization of image_cache_refcount and
800 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
801
802 2011-11-05 Eli Zaretskii <eliz@gnu.org>
803
804 Support MSVC build with newer versions of Visual Studio.
805 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
806 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
807 nt/gmake.defs.
808
809 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
810 which are not supported by MSVC.
811 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
812 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
813 bitfields.
814 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
815 types in bitfields.
816 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
817
818 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
819
820 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
821
822 Support MSVC build with newer versions of Visual Studio.
823 * w32.c: Don't include w32api.h for MSVC.
824 (init_environment) [_MSC_VER]: Call sys_access, not _access.
825
826 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
827 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
828 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
829 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
830 e_* cousins.
831 (alloca) [_MSC_VER]: Define to _alloca.
832
833 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
834
835 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
836
837 2011-11-04 Eli Zaretskii <eliz@gnu.org>
838
839 * xdisp.c (note_mouse_highlight): If either of
840 previous/next-single-property-change returns nil, treat that as
841 the beginning or the end of the buffer. (Bug#9955)
842
843 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
844
845 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
846 label is not null (Bug#9951).
847 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
848 may be NULL.
849
850 2011-11-04 Eli Zaretskii <eliz@gnu.org>
851
852 * window.c (Fwindow_body_size): Mention in the doc string that the
853 return value is in frame's canonical units. (Bug#9949)
854
855 2011-11-03 Eli Zaretskii <eliz@gnu.org>
856
857 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
858
859 * w32fns.c (unwind_create_frame): If needed, free the glyph
860 matrices of the partially constructed frame. (Bug#9943)
861 * xfns.c (unwind_create_frame): Likewise.
862
863 2011-11-01 Eli Zaretskii <eliz@gnu.org>
864
865 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
866 Don't stop backward scan on the continuation glyph, even though
867 its CHARPOS is positive.
868 (mouse_face_from_buffer_pos, note_mouse_highlight):
869 Rename cover_string to disp_string.
870
871 2011-11-01 Martin Rudalics <rudalics@gmx.at>
872
873 * window.c (temp_output_buffer_show): Don't use
874 Vtemp_buffer_show_specifiers.
875 (Vtemp_buffer_show_specifiers): Remove unused variable.
876
877 2011-10-30 Eli Zaretskii <eliz@gnu.org>
878
879 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
880 past the beginning of the current glyph matrix.
881
882 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
883
884 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
885 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
886 HAVE_GTK3 (Bug#9869).
887
888 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
889 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
890
891 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
892
893 * xterm.c: Declare x_handle_net_wm_state to return int.
894 (handle_one_xevent): Check if we are iconified but don't have
895 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
896 (get_current_wm_state): Return non-zero if not hidden,
897 check for _NET_WM_STATE_HIDDEN (Bug#9893).
898 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
899 (x_handle_net_wm_state): Return what get_current_wm_state returns.
900 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
901
902 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
903
904 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
905 so that this new function doesn't get optimized away by a
906 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
907
908 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
909
910 * frame.h (MOUSE_HL_INFO): Remove excess parens.
911
912 2011-10-29 Eli Zaretskii <eliz@gnu.org>
913
914 Fix the `xbytecode' command.
915 * .gdbinit (xprintbytestr): New command.
916 (xwhichsymbols): Rename from `which'; all callers changed.
917 (xbytecode): Print the byte-code string as well.
918
919 2011-10-29 Kim Storm <storm@cua.dk>
920
921 * alloc.c (which_symbols): New function.
922
923 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
924
925 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
926 line. (Bug#9903)
927
928 2011-10-29 Glenn Morris <rgm@gnu.org>
929
930 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
931 Not clear what it was for, and it causes various bugs. (Bug#9839)
932
933 2011-10-28 Eli Zaretskii <eliz@gnu.org>
934
935 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
936 possible random value that matches one of those tested as
937 condition to clear the mouse face.
938
939 2011-10-28 Chong Yidong <cyd@gnu.org>
940
941 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
942
943 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
944
945 * window.c (make_window): Initialize phys_cursor_on_p.
946
947 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
948
949 * lisp.h (struct Lisp_Symbol): Update comments.
950
951 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
952
953 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
954
955 2011-10-28 Eli Zaretskii <eliz@gnu.org>
956
957 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
958 <oslsachem@gmail.com> for helping to debug this.
959
960 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
961 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
962 (g_b_init_get_glyph_outline_w): New static variables.
963 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
964 (GetGlyphOutlineW_Proc): New typedefs.
965 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
966 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
967 New functions.
968 (w32font_open_internal, compute_metrics):
969 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
970 instead of calling the "wide" APIs directly.
971
972 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
973
974 * w32.h (syms_of_w32font): Add prototype.
975
976 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
977
978 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
979 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
980 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
981 (Fmove_to_window_line): Doc fix.
982
983 2011-10-27 Chong Yidong <cyd@gnu.org>
984
985 * process.c (make_process): Set gnutls_state to NULL.
986
987 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
988 non-NULL, regardless of GNUTLS_INITSTAGE.
989 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
990 an error. Set process slots as soon as we allocate them.
991
992 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
993
994 2011-10-27 Chong Yidong <cyd@gnu.org>
995
996 * gnutls.c (emacs_gnutls_deinit): New function.
997 Deallocate credentials structures as well as calling gnutls_deinit.
998 (Fgnutls_deinit, Fgnutls_boot): Use it.
999
1000 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1001 (deactivate_process): Call emacs_gnutls_deinit.
1002
1003 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1004
1005 * image.c (x_create_x_image_and_pixmap):
1006 * w32.c (sys_rename, w32_delayed_load):
1007 * w32font.c (fill_in_logfont):
1008 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1009
1010 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1011
1012 * w32fns.c (w32_default_color_map): New function,
1013 extracted from Fw32_default_color_map.
1014 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1015
1016 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1017
1018 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1019
1020 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1021
1022 * keyboard.c (test_undefined): New function (bug#9751).
1023 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1024
1025 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1026
1027 * sysdep.c (init_sys_modes): Fix the check for the controlling
1028 terminal (Bug#6649).
1029
1030 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1031
1032 * dispextern.h (struct bidi_it): New member next_en_type.
1033
1034 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1035 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1036 current character, check also for next_en_type being WEAK_EN.
1037 (bidi_resolve_weak): Don't enter the expensive loop if the current
1038 position is before next_en_pos. Record the bidi type of the first
1039 non-ET, non-BN character we find, in addition to its position.
1040 (bidi_level_of_next_char): Invalidate next_en_type when
1041 next_en_pos is over-stepped.
1042
1043 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1044
1045 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1046 * editfns.c: Rewrite current-time-zone so that it invokes
1047 the equivalent of (format-time-string "%Z") to get the time zone name.
1048 This fixes a bug when the time zone name contains characters that
1049 need converting from the system time locale to Emacs internal format.
1050 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1051 that patch fixed format-time-string to do the conversion, but
1052 I forgot to fix current-time-zone.
1053 (format_time_string): New function, containing most of
1054 what Fformat_time_string used to contain.
1055 (Fformat_time_string): Rewrite in terms of format_time_string.
1056 This doesn't change this function's behavior.
1057 (current-time-zone): Rewrite to use format_time_string.
1058 This fixes the bug reported by Michael Schierl in
1059 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1060 Jason Rumney's 2007-06-07 change worked around this bug, but
1061 didn't fix it.
1062 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1063
1064 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1065
1066 * xdisp.c (start_display): If the character at POS is displayed
1067 via a display vector, reset IT->current.dpvec_index to zero.
1068 (try_window_reusing_current_matrix): If a line ends in a display
1069 vector or the next line starts in a display vector, continue
1070 redrawing the window even though the character position of
1071 start_row was reached.
1072 (Bug#9771, part 2)
1073
1074 2011-10-18 Chong Yidong <cyd@gnu.org>
1075
1076 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1077 with nobreak-char-display too.
1078
1079 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1080
1081 Fix part 3 of bug#9771.
1082 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1083 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1084 non-neutral characters if the current character is a paragraph
1085 separator (a.k.a. Newline). This avoids running the same
1086 expensive loop twice, once when we consume the preceding newline
1087 and the other time when the line actually needs to be displayed.
1088 Avoid the loop when we see neutrals on the base embedding level
1089 following a character whose directionality is the same as the
1090 paragraph's. This avoids running the expensive loop when a line
1091 ends in a long sequence of neutrals, like control characters.
1092 Add assertion against STRONG_AL type. Slightly rearrange code
1093 that determines the type of a neutral given the first non-neutral
1094 that follows it.
1095 (bidi_level_of_next_char): Set next_en_pos to zero when
1096 invalidating its info.
1097
1098 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1099
1100 * xdisp.c (push_display_prop): Determine whether to record string
1101 or buffer position by IT->string, not by IT->method. Allow
1102 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1103 (move_it_vertically_backward): Don't look for character position
1104 immediately after the newline when in a continuation line.
1105 (Bug#9771, part 1)
1106
1107 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1108
1109 * window.c (coordinates_in_window): Rewrite and delabelize
1110 vertical border check. (Bug#5357) (Bug#9618)
1111
1112 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1113
1114 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1115 errors in XSetWindowBorder (bug#9310).
1116
1117 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1118
1119 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1120 avoid crash when xmalloc overrun checking is enabled.
1121
1122 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1123
1124 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1125 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1126 cursor motion with <left> and <right> arrow keys.
1127
1128 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1129 some callers set that themselves.
1130
1131 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1132
1133 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1134 display string and the previous row comes from the same string and
1135 is empty. (Bug#9739) (Bug#9738)
1136
1137 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1138
1139 * doc.c (get_doc_string): Encode file name (bug#9735).
1140
1141 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1142
1143 * bidi.c (bidi_level_of_next_char):
1144 * xdisp.c (get_visually_first_element): Remove old incorrect
1145 comments regarding the Unicode Line Separator character.
1146
1147 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1148
1149 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1150
1151 * alloc.c (Fgc_status): Do not access beyond zombies array
1152 boundary if nzombies > MAX_ZOMBIES.
1153 * alloc.c (dump_zombies): Add missing format specifier.
1154
1155 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1156
1157 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1158 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1159
1160 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1161 Some packages use them to denote characters with modifiers.
1162
1163 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1164
1165 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1166 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1167 matching a pp-number. Rename parameter var to var1.
1168
1169 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1170
1171 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1172
1173 2011-10-08 Glenn Morris <rgm@gnu.org>
1174
1175 * callint.c (Fcall_interactively): Give a more explicit error for the
1176 'c' case with a non-character input. (Bug#8479)
1177
1178 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1179
1180 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1181 lines.
1182 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1183 lines that are hscrolled on the left.
1184
1185 * dispnew.c (buffer_posn_from_coords): Account for a possible
1186 presence of header-line. (Bug#4426)
1187
1188 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1189
1190 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1191 Don't advertise functionality which we discourage or doesn't work.
1192
1193 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1194
1195 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1196 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1197 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1198 this makes Emacs dump core during garbage collection on rare
1199 occasions. sizeof is obviously inferior to offsetof here, so
1200 stick with offsetof.
1201 (GC_POINTER_ALIGNMENT): New macro.
1202 (mark_memory): Omit 3rd (offset) arg; caller changed.
1203 Don't assume EMACS_INT alignment is the same as pointer alignment.
1204
1205 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1206
1207 * keyboard.c (read_key_sequence_remapped): New var.
1208 (read_key_sequence): Compute remapping in the right buffer.
1209 (command_loop_1): Use read_key_sequence's remapping directly.
1210
1211 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1212
1213 * dired.c (file_name_completion): Don't expand file name.
1214 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1215 before checking file name handler.
1216
1217 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1218 they've been requested explicitly (bug#9591).
1219
1220 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1221
1222 * keymap.c (Fsingle_key_description): Use make_specified_string
1223 instead of build_string to build string from push_key_description.
1224 (Bug#5193)
1225
1226 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1227
1228 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1229 This fixes a Y2038 bug on 64-bit hosts.
1230 * buffer.c (reset_buffer):
1231 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1232 (Fclear_buffer_auto_save_failure):
1233 Use 0, not -1, to represent an unset failure time, since time_t
1234 might not be signed.
1235
1236 Remove dependency on glibc malloc internals.
1237 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1238 Move back here from lisp.h, but with their new implementations.
1239 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1240 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1241 * charset.c (charset_table_init): New static var.
1242 (syms_of_charset): Use it instead of xmalloc. This removes a
1243 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1244 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1245 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1246 Move back to alloc.c.
1247 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1248 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1249
1250 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1251
1252 * nsterm.m (windowDidResize): Call x_set_window_size only when
1253 ns_in_resize is true. Otherwise set pixelwidth/height and
1254 call change_frame_size (Bug#9628).
1255
1256 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1257
1258 Port --enable-checking=all to Fedora 14 x86-64.
1259 * charset.c (syms_of_charset): Also account for glibc malloc's
1260 internal overhead when calculating the initial malloc maximum.
1261
1262 Port --enable-checking=all to Fedora 14 x86.
1263 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1264 Move to lisp.h.
1265 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1266 (overrun_check_realloc, overrun_check_free):
1267 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1268 That way, xmalloc returns a properly-aligned pointer even if
1269 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1270 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1271 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1272 into account when calculating the initial malloc maximum.
1273 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1274 Move here from alloc.c, so that charset.c can use it too.
1275 Properly align; the old code wasn't right for common 32-bit hosts
1276 when configured with --enable-checking=all.
1277 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1278 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1279
1280 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1281
1282 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1283 use EDOM.
1284
1285 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1286
1287 * xdisp.c (compute_display_string_end): If there's no display
1288 string at CHARPOS, return -1.
1289
1290 * bidi.c (bidi_fetch_char): When compute_display_string_end
1291 returns a negative value, treat the character as a normal
1292 character not covered by a display string. (Bug#9624)
1293
1294 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1295
1296 * lread.c (Fread_from_string): Fix typo in docstring.
1297
1298 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1299
1300 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1301 newline, reseat the iterator instead of bidi-iterating there one
1302 character at a time. (Bug#9610)
1303 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1304 TO_CHARPOS if the bidi iterator is at base embedding level.
1305
1306 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1307
1308 * lread.c (readevalloop): Use correct code for NBSP.
1309 (read1): Likewise. (Bug#9608)
1310
1311 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1312
1313 * dbusbind.c (Fdbus_register_signal): When service is not
1314 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1315
1316 2011-09-25 Glenn Morris <rgm@gnu.org>
1317
1318 * buffer.c (truncate-lines): Doc fix.
1319
1320 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1321
1322 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1323 (Fset_window_next_buffers): Doc fix.
1324
1325 2011-09-24 Glenn Morris <rgm@gnu.org>
1326
1327 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1328
1329 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1330
1331 Fix minor problems found by static checking.
1332 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1333 * indent.c (Fvertical_motion): Fix == vs = typo.
1334
1335 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1336
1337 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1338 Default value is now t. Doc fix.
1339
1340 * indent.c (Fvertical_motion): Compute and apply the overshoot
1341 logic when moving up, not only when moving down. Fix the
1342 confusing name and values of the it_overshoot_expected variable;
1343 logic changes accordingly. (Bug#9254) (Bug#9549)
1344
1345 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1346 CHARPOS is covered by a display string which includes newlines.
1347 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1348 is covered by a display string with embedded newlines.
1349
1350 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1351
1352 * dbusbind.c (Fdbus_register_signal): Add match rule to
1353 Vdbus_registered_objects_table. (Bug#9581)
1354 (Fdbus_register_method, Vdbus_registered_objects_table):
1355 Fix docstring.
1356
1357 2011-09-24 Jim Meyering <meyering@redhat.com>
1358
1359 do not ignore write error for any output size
1360 The previous change was incomplete.
1361 While it makes emacs --batch detect the vast majority of stdout
1362 write failures, errors were still ignored whenever the output size is
1363 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1364 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1365 && echo FAIL: ignored write error
1366 FAIL: ignored write error
1367 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1368 && echo FAIL: ignored write error
1369 FAIL: ignored write error
1370 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1371
1372 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1373
1374 * emacs.c (Fkill_emacs): In noninteractive mode exit
1375 non-successfully if a write error occurred on stdout. (Bug#9574)
1376
1377 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1378
1379 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1380 the xassert test.
1381
1382 * dispextern.h (struct it): Update the comment documenting what
1383 can it->OBJECT be.
1384
1385 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1386
1387 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1388 a display string, extend search for cursor position to end of row.
1389 (find_row_edges): If the row ends in a newline from a display
1390 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1391 Handle the case of a display string with multiple newlines.
1392 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1393 non-empty line. Fixes confusing cursor motion with arrow keys at
1394 the beginning of a line that starts with whitespace.
1395
1396 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1397
1398 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1399 (bug#9493).
1400
1401 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1402
1403 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1404 boolean (Bug#9154).
1405
1406 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1407
1408 * xdisp.c (display_line): Record maximum and minimum buffer
1409 positions even if no glyphs were produced (e.g., by a zero-width
1410 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1411 buffer positions that will be removed from the glyph row because
1412 they don't fit.
1413 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1414 column is beyond frame width: don't subtract 1 "pixel" when
1415 computing width of the stretch.
1416 (reseat_at_next_visible_line_start): Undo the change made on
1417 2011-09-17 that saved paragraph information and restored it after
1418 the call to `reseat'. (Bug#9545)
1419
1420 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1421
1422 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1423 and turn window cursor on if cleared (Bug#9415).
1424
1425 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1426
1427 * search.c (boyer_moore): Take unibyte characters from pattern
1428 literally. (Bug#9458)
1429
1430 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1431
1432 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1433
1434 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1435
1436 Fix minor problem found by static checking.
1437 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1438 initialized, to pacify gcc -Wuninitialized.
1439
1440 * fileio.c: Report proper errno when syscall falls.
1441 (Finsert_file_contents): Save and restore errno,
1442 so that report_file_error outputs the correct diagnostic.
1443 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1444
1445 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1446
1447 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1448
1449 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1450
1451 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1452 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1453
1454 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1455
1456 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1457 about the current paragraph and restore it after the call to reseat.
1458
1459 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1460 (bidi_find_paragraph_start): Search back for paragraph beginning
1461 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1462 (bidi_move_to_visually_next): Only trigger paragraph-related
1463 computations when the last character is a newline or at EOB, not
1464 just any NEUTRAL_B. (Bug#9470)
1465
1466 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1467 truncated lines if point is covered by a display string. (Bug#9524)
1468
1469 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1470
1471 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1472 (cons_to_x_long): New function.
1473 (lisp_data_to_selection_data): Use it. Correct the test for
1474 short-versus-long data; it was negated. Break out of vector
1475 loop, for efficiency, when a long datum is discovered.
1476
1477 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1478
1479 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1480
1481 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1482
1483 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1484 GCC PR/17406) by declaring this function with external scope.
1485
1486 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1487
1488 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1489 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1490
1491 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1492
1493 * editfns.c (Fformat): Correctly handle text properties on "%%".
1494
1495 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1496
1497 * xterm.c (x_draw_composite_glyph_string_foreground):
1498 * w32term.c (x_draw_composite_glyph_string_foreground):
1499 * term.c (encode_terminal_code):
1500 * composite.c (composition_update_it, get_composition_id):
1501 * xdisp.c (get_next_display_element)
1502 (fill_composite_glyph_string): Add comments about special meaning
1503 of TAB characters in a composition.
1504
1505 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1506
1507 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1508 This occurs when processing a multibyte format.
1509 Problem reported by Wolfgang Jenker.
1510
1511 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1512
1513 * xdisp.c (try_cursor_movement): Only check for exact match if
1514 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1515
1516 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1517
1518 Remove unused external symbols.
1519 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1520 * xdisp.c (calc_pixel_width_or_height): Now static.
1521 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1522 * indent.c (check_display_width):
1523 * w32term.c: Fix comment to match code.
1524 * xterm.c, xterm.h (x_catching_errors): Remove.
1525
1526 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1527
1528 * xselect.c: Use signed conversions more consistently (Bug#9498).
1529 (selection_data_to_lisp_data): Assume incoming selection data are
1530 signed integers, not unsigned. This is to be consistent with
1531 outgoing selection data, which was modified to use signed integers
1532 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1533 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1534 expects long, not unsigned long.
1535
1536 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1537
1538 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1539 computation of loop end. Reported by Johan Bockgård
1540 <bojohan@gnu.org>.
1541
1542 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1543
1544 * frame.c (Fother_visible_frames_p): Function deleted.
1545
1546 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1547
1548 * indent.c (compute_motion): Process display vector front to back
1549 rather than the other way around. (Bug#2496)
1550
1551 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1552
1553 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1554
1555 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1556
1557 * minibuf.c (Fread_from_minibuffer): Doc fix.
1558
1559 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1560
1561 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1562 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1563
1564 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1565
1566 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1567 value for non-existent files.
1568
1569 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1570
1571 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1572 set its "size" to -1. This will set the modtime_size field of
1573 the corresponding buffer to -1, which is what
1574 verify-visited-file-modtime expects for files that do not exist.
1575 (Bug#9139)
1576
1577 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1578
1579 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1580 here ...
1581 * lisp.h: ... from here. push_key_description is no longer
1582 defined in keyboard.c, so its declaration should not be in
1583 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1584 logically belongs with push_key_description.
1585
1586 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1587
1588 * buffer.h: Include <sys/types.h> instead of <time.h>.
1589 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1590 Problem reported by Herbert J. Skuhra.
1591
1592 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1593
1594 * xml.c (parse_region): Make the parsing work for
1595 non-comment-starting XML files again (bug#9144).
1596
1597 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1598
1599 * image.c (gif_load): Fix calculation of bottom and right corner.
1600 (Bug#9468)
1601
1602 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1603
1604 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1605 redisplay in small windows.
1606
1607 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1608
1609 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1610
1611 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1612
1613 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1614 Operate on live windows only.
1615
1616 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1617
1618 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1619
1620 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1621
1622 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1623 only under bidi iteration.
1624
1625 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1626
1627 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1628
1629 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1630
1631 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1632 Without this fix, the command to link temacs failed due to an
1633 undefined symbol __builtin_isnan. This is because
1634 /usr/include/iso/math_c99.h #defines isnan(x) to
1635 __builtin_isnan(x), but the bundled gcc, which identifies itself
1636 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1637 a __builtin_isnan.
1638 * floatfns.c (isnan): #undef, and then #define to a clone of
1639 what's in data.c.
1640 (Fisnan): Always define, since it's always available now.
1641 (syms_of_floatfns): Always define isnan at the Lisp level.
1642
1643 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1644
1645 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1646
1647 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1648
1649 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1650 The previous code assumed that file offsets (off_t values) fit in
1651 EMACS_INT variables, which is not true on typical 32-bit hosts.
1652 The code messed up by falsely reporting buffer overflow in cases
1653 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1654 when "big" contains more than 2**29 bytes, even though this
1655 inserts just one byte and does not overflow the buffer.
1656 (Finsert_file_contents): Store file offsets as off_t
1657 values, not as EMACS_INT values. Check for overflow when
1658 converting between EMACS_INT and off_t. When checking for
1659 buffer overflow or for overlap, take the offsets into account.
1660 Don't use EMACS_INT for small values where int suffices.
1661 When checking for overlap, fix a typo: ZV was used where
1662 ZV_BYTE was intended.
1663 (Fwrite_region): Don't assume off_t fits into 'long'.
1664 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1665
1666 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1667
1668 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1669
1670 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1671
1672 sprintf-related integer and memory overflow issues (Bug#9412).
1673
1674 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1675 (esprintf, exprintf, evxprintf): New functions.
1676 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1677 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1678 (modify_event_symbol): Do not assume that the length of
1679 name_alist_or_stem is safe to alloca and fits in int.
1680 (Fexecute_extended_command): Likewise for function name and binding.
1681 (Frecursion_depth): Wrap around reliably on integer overflow.
1682 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1683 since some callers pass EMACS_INT values.
1684 (Fsingle_key_description): Don't crash if symbol name contains more
1685 than MAX_ALLOCA bytes.
1686 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1687 (get_minibuffer): Arg is now EMACS_INT, not int.
1688 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1689 (esprintf, exprintf, evxprintf): New decls.
1690 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1691
1692 * dbusbind.c (signature_cat): New function.
1693 (xd_signature, Fdbus_register_signal):
1694 Do not overrun buffer; instead, report string overflow.
1695
1696 * dispnew.c (add_window_display_history): Don't overrun buffer.
1697 Truncate instead; this is OK since it's just a log.
1698
1699 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1700 even if the time zone offset is outlandishly large.
1701 Don't mishandle offset == INT_MIN.
1702
1703 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1704 when creating daemon; the previous buffer-overflow check was incorrect.
1705
1706 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1707 which has the guts of the old verror function.
1708
1709 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1710 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1711
1712 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1713 (font_unparse_xlfd): Don't blindly alloca long strings.
1714 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1715 fits in int, when using sprintf. Use single snprintf to count
1716 length of string rather than counting it via multiple sprintfs;
1717 that's simpler and more reliable.
1718 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1719 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1720 sprintf, in case result does not fit in int.
1721
1722 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1723 (fontset_from_font): Print it.
1724
1725 * frame.c (tty_frame_count): Now printmax_t, not int.
1726 (make_terminal_frame, set_term_frame_name): Print it.
1727 (x_report_frame_params): In X, window IDs are unsigned long,
1728 not signed long, so print them as unsigned.
1729 (validate_x_resource_name): Check for implausibly long names,
1730 and don't assume name length fits in 'int'.
1731 (x_get_resource_string): Don't blindly alloca invocation name;
1732 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1733 not fit in int.
1734
1735 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1736 (xg_check_special_colors, xg_set_geometry):
1737 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1738
1739 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1740 Use esprintf, not sprintf, in case result does not fit in int.
1741
1742 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1743 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1744 it as a large positive number.
1745 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1746 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1747
1748 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1749 in case result does not fit in int.
1750
1751 * print.c (float_to_string): Detect width overflow more reliably.
1752 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1753 buffer overrun. Don't assume list length fits in 'int'. Treat
1754 print length of 0 as 0, not as infinity; to be consistent with other
1755 uses of print length in this function. Don't overflow print length
1756 index. Don't assume hash table size fits in 'long', or that
1757 vectorlike size fits in 'unsigned long'.
1758
1759 * process.c (make_process): Use printmax_t, not int, to format
1760 process-name gensyms.
1761
1762 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1763
1764 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1765 to avoid potential buffer overrun.
1766
1767 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1768 if X resource line is longer than 512 bytes.
1769
1770 * xfns.c (x_window): Make sprintf buffer a bit bigger
1771 to avoid potential buffer overrun.
1772
1773 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1774
1775 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1776
1777 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1778
1779 Integer overflow fixes for scrolling, etc.
1780 Without these, Emacs silently mishandles large integers sometimes.
1781 For example, "C-u 4294967297 M-x recenter" was treated as if
1782 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1783
1784 * xdisp.c (try_window_id): Check Emacs fixnum range before
1785 converting to 'int'.
1786
1787 * window.c (window_scroll_line_based, Frecenter):
1788 Check that an Emacs fixnum is in range before assigning it to 'int'.
1789 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1790 values converted from Emacs fixnums.
1791 (Frecenter): Don't wrap around a line count if it is out of 'int'
1792 range; instead, treat it as an extreme value.
1793 (Fset_window_configuration, compare_window_configurations):
1794 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1795
1796 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1797 that can exceed INT_MAX. Check that EMACS_INT value is in range
1798 before assigning it to the (possibly-narrower) index.
1799 (match_limit): Don't assume that a fixnum can fit in 'int'.
1800
1801 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1802 exceed INT_MAX.
1803
1804 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1805 (Fvertical_motion): Don't wrap around LINES values that don't fit
1806 in 'int'. Instead, treat them as extreme values. This is good
1807 enough for windows, which can't have more than INT_MAX lines anyway.
1808
1809 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1810
1811 * Require libxml/parser.h to avoid compilation warning.
1812
1813 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1814
1815 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1816 since this reportedly can destroy thread storage.
1817
1818 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1819
1820 * syntax.c (find_defun_start): Update all cache variables if
1821 exiting early (Bug#9401).
1822
1823 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1824
1825 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1826
1827 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1828 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1829 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1830
1831 * term.c (tty_append_glyph): New function.
1832 (produce_stretch_glyph): Static function and its prototype deleted.
1833
1834 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1835 Add prototypes.
1836
1837 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1838
1839 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1840 when checking :margin (Bug#9390).
1841 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1842 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1843 so that the name doesn't mislead. All uses changed.
1844
1845 2011-08-28 Johan Bockgård <bojohan@gnu.org>
1846
1847 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1848 set_tty_hooks.
1849
1850 2011-08-27 Eli Zaretskii <eliz@gnu.org>
1851
1852 * xdisp.c (move_it_to): Don't bail out early when reaching
1853 position beyond to_charpos, if we are scanning backwards.
1854 (move_it_vertically_backward): When DY == 0, make sure we get to
1855 the first character in the line after the newline.
1856
1857 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1858
1859 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1860 (ccl_driver): Do not generate an out-of-range pointer.
1861 (Fccl_execute_on_string): Remove unnecessary check for
1862 integer overflow, noted by Stefan Monnier in
1863 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1864 Remove a FIXME that didn't need fixing.
1865 Simplify the newly-introduced buffer reallocation code.
1866
1867 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
1868
1869 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1870
1871 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1872
1873 Integer and memory overflow issues (Bug#9196).
1874
1875 * doc.c (get_doc_string): Rework so that
1876 get_doc_string_buffer_size is the actual buffer size, rather than
1877 being 1 less than the actual buffer size; this makes xpalloc more
1878 convenient.
1879
1880 * image.c (x_allocate_bitmap_record, cache_image):
1881 * xselect.c (Fx_register_dnd_atom):
1882 Simplify previous changes by using xpalloc.
1883
1884 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1885 since either will do and ptrdiff_t is convenient with xpalloc.
1886
1887 * charset.c (charset_table_size)
1888 (struct charset_sort_data.priority): Now ptrdiff_t.
1889 (charset_compare): Don't overflow if priorities differ greatly.
1890 (Fsort_charsets): Don't assume list length fits in int.
1891 Check for size-calculation overflow when allocating sort data.
1892 (syms_of_charset): Allocate an initial charset table that is
1893 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1894
1895 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1896
1897 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1898 The actual value is always <= INT_MAX, and leaving it unsigned made
1899 overflow checking harder.
1900
1901 * dispextern.h (struct glyph_matrix.rows_allocated)
1902 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1903 with xpalloc. The values are still always <= INT_MAX.
1904
1905 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1906
1907 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1908 (SAFE_NALLOCA): New macro.
1909
1910 * region-cache.c (struct boundary.pos, find_cache_boundary)
1911 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1912 (set_cache_region, invalidate_region_cache)
1913 (revalidate_region_cache, know_region_cache, region_cache_forward)
1914 (region_cache_backward, pp_cache):
1915 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1916 so that ptrdiff_t * can be passed to xpalloc.
1917 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1918 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1919 (pp_cache): Don't assume cache_len fits in int.
1920 * region-cache.h: Adjust extern decls to match.
1921
1922 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1923 EMACS_INT, since either will do, for xpalloc.
1924
1925 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1926 (xnmalloc, xnrealloc, xpalloc): New functions.
1927
1928 * bidi.c (bidi_shelve_header_size): New constant.
1929 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1930 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1931
1932 * bidi.c (bidi_cache_shrink):
1933 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1934 (overlay_strings):
1935 Don't update size of array until after memory allocation succeeds,
1936 because xmalloc/xrealloc may not return.
1937 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1938 now that we have proper integer overflow checking.
1939 (record_overlay_string, overlay_strings): Catch overflows when
1940 calculating size of overlay_str_buf.
1941
1942 * callproc.c (Fcall_process): Check for size overflow when
1943 calculating size of args2.
1944 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1945 Normally we prefer signed values, but sticking with ptrdiff_t would
1946 require adding more-complicated checks.
1947
1948 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1949 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1950 Redo buffer-overflow calculations to avoid integer overflow.
1951 Add a FIXME comment where memory seems to be over-allocated.
1952
1953 * character.c (Fstring): Check for size-calculation overflow.
1954
1955 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1956 unnecessary integer overflow. Check for size overflow.
1957 (encode_coding_object): Don't update size until xmalloc succeeds.
1958
1959 * composite.c (get_composition_id): Check for overflow in glyph
1960 length calculations.
1961
1962 Integer and memory overflow fixes for display code.
1963 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1964 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1965 (scrolling_window): Check for overflow in size calculations.
1966 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1967 Don't assume glyph table len fits in int.
1968 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1969 (row_table_size): Now ptrdiff_t, not int.
1970 (scrolling_window): Avoid overflow in size calculations.
1971 Don't update size until allocation succeeds.
1972 * fns.c (concat): Check for overflow in size calculations.
1973 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1974 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1975 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1976
1977 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1978 (get_doc_string): Check for size calculation overflow.
1979 Don't update size until allocation succeeds.
1980 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1981 EMACS_INT, where ptrdiff_t will do.
1982 (Fsubstitute_command_keys): Check for string overflow.
1983
1984 * editfns.c (set_time_zone_rule): Don't assume environment length
1985 fits in int.
1986 (message_length): Now ptrdiff_t, not int.
1987 (Fmessage_box): Don't update size until allocation succeeds.
1988 Don't assume message length fits in int.
1989 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1990
1991 * emacs.c (main): Do not reallocate argv, since there is a null at
1992 the end that can be overwritten, and this way there's no need to
1993 worry about size-calculation overflow.
1994 (sort_args): Check for size-calculation overflow.
1995
1996 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1997 alloc succeeds.
1998 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1999
2000 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2001 (x_set_scroll_bar_width, x_figure_window_size):
2002 Check for integer overflow.
2003 (x_set_alpha): Do not assume XINT fits in int.
2004
2005 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2006 This is for the members text_lines, text_cols, total_lines, total_cols,
2007 where the system imposes an 'int' limit.
2008
2009 * fringe.c (Fdefine_fringe_bitmap):
2010 Don't update size until alloc works.
2011
2012 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2013 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2014
2015 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2016 Check for size-calculation overflow.
2017 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2018 do, as we prefer signed integers.
2019 (id_to_widget.max_size, id_to_widget.used)
2020 (xg_store_widget_in_map, xg_remove_widget_from_map)
2021 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2022 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2023 Use and return ptrdiff_t, not int.
2024 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2025 * gtkutil.h: Change prototypes to match the above.
2026
2027 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2028 are duplicate now that they've been promoted to lisp.h.
2029 (x_allocate_bitmap_record, x_alloc_image_color)
2030 (make_image_cache, cache_image, xpm_load):
2031 Don't update size until alloc is done.
2032 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2033 (x_detect_edges):
2034 Check for size calculation overflow.
2035 (ct_colors_allocated_max): New constant.
2036 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2037 overflow.
2038
2039 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2040 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2041 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2042 Use ptrdiff_t, not int, to count maps.
2043 (read_char_minibuf_menu_prompt): Check for overflow in size
2044 calculations. Don't update size until allocation succeeds.
2045 Redo calculations to avoid overflow.
2046 * keyboard.h: Change prototypes to match the above.
2047
2048 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2049 to count maps.
2050 (current_minor_maps): Check for size calculation overflow.
2051 * keymap.h: Change prototypes to match the above.
2052
2053 * lread.c (read1, init_obarray): Don't update size until alloc done.
2054
2055 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2056 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2057
2058 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2059 Now ptrdiff_t, not int.
2060 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2061 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2062
2063 * process.c (Fnetwork_interface_list): Check for overflow
2064 in size calculation.
2065
2066 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2067
2068 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2069 overflow. Don't bother calling xmalloc when xrealloc will do.
2070
2071 * search.c (Freplace_match): Check for size calculation overflow.
2072 (Fset_match_data): Don't assume list lengths fit in 'int'.
2073
2074 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2075 for command line length. Do not attempt to address one before the
2076 beginning of an array, as that's not portable.
2077
2078 * term.c (max_frame_lines): Remove; unused.
2079 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2080 not int.
2081 (encode_terminal_code, calculate_costs): Check for size
2082 calculation overflow.
2083 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2084 table lengths and related sizes. Don't update size until alloc
2085 done. Redo calculations to avoid overflow.
2086 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2087
2088 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2089 subtracting pointers.
2090 (gobble_line): Check for overflow more carefully. Don't update size
2091 until alloc done.
2092
2093 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2094 Don't update size until alloc done.
2095 Redo size calculations to avoid overflow.
2096 Check for size calculation overflow.
2097 (main) [DEBUG]: Fix typo in invoking tparam1.
2098
2099 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2100 Use ptrdiff_t, not int, for sizes.
2101 (store_mode_line_noprop_char): Don't update size until alloc done.
2102
2103 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2104 Use ptrdiff_t, not int, for sizes.
2105 (Finternal_make_lisp_face, cache_face):
2106 Check for size calculation overflow.
2107 (cache_face): Treat size calculation overflows as if they were
2108 memory exhaustion (the usual treatment), rather than aborting.
2109
2110 * xfns.c (x_encode_text, x_set_name_internal)
2111 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2112 sizes, since they can exceed INT_MAX in size. Check for size
2113 calculation overflow.
2114
2115 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2116 (xg_select): Check for size calculation overflow.
2117 Don't update size until alloc done.
2118
2119 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2120 as sprintf is limited to int lengths.
2121
2122 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2123 (X_LONG_MIN): New macros.
2124 Use them to make the following changes clearer.
2125 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2126 This change doesn't affect the value now, but it may help remind
2127 future maintainers not to raise the value too much later.
2128 (SELECTION_QUANTUM): Remove, replacing with ...
2129 (selection_quantum): ... new function, which avoids overflow.
2130 All uses changed.
2131 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2132 assumption that selection length fits in 'int'.
2133 (x_reply_selection_request, x_handle_selection_request)
2134 (x_get_window_property, receive_incremental_selection)
2135 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2136 (lisp_data_to_selection_data, clean_local_selection_data):
2137 Use ptrdiff_t, not int, to record length of selection.
2138 (x_reply_selection_request, x_get_window_property)
2139 (receive_incremental_selection, x_property_data_to_lisp):
2140 Redo calculations to avoid overflow.
2141 (x_reply_selection_request): When sending hint, ceiling it at
2142 X_LONG_MAX rather than relying on wraparound overflow to send
2143 something.
2144 (x_get_window_property, receive_incremental_selection)
2145 (lisp_data_to_selection_data, x_property_data_to_lisp):
2146 Check for size-calculation overflow.
2147 (x_get_window_property, receive_incremental_selection)
2148 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2149 Don't store size until memory allocation succeeds.
2150 (x_get_window_property): Plug memory leak on memory exhaustion.
2151 Don't double-block input; malloc is safe here. Don't assume 2**34
2152 - 4 fits in unsigned long. Add an xassert to check
2153 XGetWindowProperty overflow. Be more careful about overflow
2154 calculations, and distinguish size from memory overflow better.
2155 (receive_incremental_selection): When tracing, don't assume
2156 unsigned int is less than INT_MAX.
2157 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2158 harmful) conversions of unsigned short to int.
2159 (lisp_data_to_selection_data): Don't assume that integers
2160 in the range -65535 through -1 fit in an X unsigned short.
2161 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2162 result parameters unless successful. Rely on cons_to_unsigned
2163 to report problems with elements; the old code wasn't right anyway.
2164 (x_check_property_data): Check for int overflow; we cannot use
2165 a wider type due to X limits.
2166 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2167
2168 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2169
2170 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2171 (x_term_init): Check for size calculation overflow.
2172 (x_color_cells): Don't store size until memory allocation succeeds.
2173 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2174 Don't assume alloca size is less than MAX_ALLOCA.
2175 (x_term_init): Don't assume length fits in int (sprintf is limited
2176 to int size).
2177
2178 Use ptrdiff_t for composition IDs.
2179 * character.c (lisp_string_width):
2180 * composite.c (composition_table_size, n_compositions)
2181 (get_composition_id, composition_gstring_from_id):
2182 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2183 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2184 * window.c (Frecenter):
2185 Use ptrdiff_t, not int, for composition IDs.
2186 * composite.c (get_composition_id): Check for integer overflow.
2187 * composite.h: Adjust prototypes to match the above changes.
2188
2189 Use ptrdiff_t for hash table indexes.
2190 * category.c (hash_get_category_set):
2191 * ccl.c (ccl_driver):
2192 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2193 * coding.c (coding_system_charset_list, detect_coding_system):
2194 * coding.h (struct coding_system.id):
2195 * composite.c (get_composition_id, gstring_lookup_cache):
2196 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2197 * image.c (xpm_get_color_table_h):
2198 * lisp.h (hash_lookup, hash_put):
2199 * minibuf.c (Ftest_completion):
2200 Use ptrdiff_t for hash table indexes, not int (which is too
2201 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2202 32-bit --with-wide-int hosts).
2203
2204 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2205 Add a FIXME comment about memory leaks.
2206 (syms_of_charset): Don't assume xmalloc returns.
2207
2208 Don't assume that stated character widths fit in int.
2209 * character.c (Fchar_width, c_string_width, lisp_string_width):
2210 * character.h (CHAR_WIDTH):
2211 * indent.c (MULTIBYTE_BYTES_WIDTH):
2212 Use sanitize_char_width to avoid undefined and/or bad behavior
2213 with outlandish widths.
2214 * character.h (sanitize_tab_width): Rename from sanitize_width,
2215 now that we have two such functions. All uses changed.
2216 (sanitize_char_width): New inline function.
2217
2218 Don't assume that tab-width fits in int.
2219 * character.h (sanitize_width): New inline function.
2220 (SANE_TAB_WIDTH): New macro.
2221 (ASCII_CHAR_WIDTH): Use it.
2222 * indent.c (sane_tab_width): Remove. All uses replaced by
2223 SANE_TAB_WIDTH (current_buffer).
2224 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2225
2226 * fileio.c: Integer overflow issues with file modes.
2227 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2228
2229 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2230 Remove unreachable code.
2231 (read_hex, load_charset_map_from_file): Check for integer overflow.
2232
2233 * xterm.c: don't go over XClientMessageEvent limit
2234 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2235 (x_send_scroll_bar_event): Likewise. Check that the size does not
2236 exceed limits imposed by XClientMessageEvent, as well as the usual
2237 ptrdiff_t and size_t limits.
2238
2239 * keyboard.c: Overflow, signedness and related fixes.
2240 (make_lispy_movement): Use same integer type in forward decl
2241 that is used in the definition.
2242 (read_key_sequence, keyremap_step):
2243 Change bufsize argument back to int, undoing my 2011-03-30 change.
2244 We prefer signed types, and int is wide enough here.
2245 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2246 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2247 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2248 length, not size_t. Use ptrdiff_t for index, not int.
2249 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2250 possibility of integer overflow.
2251
2252 Overflow, signedness and related fixes for images.
2253
2254 * dispextern.h (struct it.stack[0].u.image.image_id)
2255 (struct_it.image_id, struct image.id, struct image_cache.size)
2256 (struct image_cache.used, struct image_cache.ref_count):
2257 * gtkutil.c (update_frame_tool_bar):
2258 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2259 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2260 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2261 * nsmenu.m (update_frame_tool_bar):
2262 * xdisp.c (calc_pixel_width_or_height):
2263 * xfns.c (image_cache_refcount):
2264 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2265 on typical 64-bit hosts.
2266
2267 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2268 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2269 Omit unnecessary casts to int.
2270 (parse_image_spec): Check that integers fall into 'int' range
2271 when the callers expect that.
2272 (image_ascent): Redo ascent calculation to avoid int overflow.
2273 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2274 (lookup_image): Remove unnecessary tests.
2275 (xbm_image_p): Locals are now of int, not EMACS_INT,
2276 since parse_image_check makes sure they fit into int.
2277 (png_load, gif_load, svg_load_image):
2278 Prefer int to unsigned where either will do.
2279 (tiff_handler): New function, combining the cores of the
2280 old tiff_error_handler and tiff_warning_handler.
2281 This function is rewritten to use vsnprintf and thereby avoid
2282 stack buffer overflows. It uses only the features of vsnprintf
2283 that are common to both POSIX and native Microsoft.
2284 (tiff_error_handler, tiff_warning_handler): Use it.
2285 (tiff_load, gif_load, imagemagick_load_image):
2286 Don't assume :index value fits in 'int'.
2287 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2288 (imagemagick_load_image): Check that crop parameters fit into
2289 the integer types that MagickCropImage accepts. Don't assume
2290 Vimagemagick_render_type has a nonnegative value. Don't assume
2291 size_t fits in 'long'.
2292 (gs_load): Use printmax_t to print the widest integers possible.
2293 Check for integer overflow when computing image height and width.
2294
2295 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2296
2297 * xdisp.c (redisplay_window): Don't force window start if point
2298 will be invisible in the resulting window. (Bug#9324)
2299
2300 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2301
2302 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2303 the display spec is of the form `(space ...)'.
2304 (handle_display_spec): Return the value returned by
2305 handle_single_display_spec, not just 1 or zero.
2306 (handle_single_display_spec): If the display spec is of the form
2307 `(space ...)', and specifies display in the text area, return 2
2308 rather than 1.
2309 (try_cursor_movement): Check for the need to scroll more
2310 accurately, and prefer exact match for point under bidi.
2311 Don't advance `row' beyond the last row of the window.
2312
2313 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2314 into disp_prop; all users changed.
2315
2316 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2317 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2318 for the text covered by the display property.
2319
2320 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2321
2322 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2323 Change return value to nil.
2324 (Frecord_buffer): Delete unused function.
2325
2326 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2327
2328 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2329 buffers, return left-to-right.
2330 (set_cursor_from_row): Consider candidate row a win if its glyph
2331 represents a newline and point is on that newline. Fixes cursor
2332 positioning on the newline at EOL of R2L text within L2R
2333 paragraph, and vice versa.
2334 (try_cursor_movement): Check continued rows, in addition to
2335 continuation rows. Fixes unwarranted scroll when point enters a
2336 continued line of R2L text within an L2R paragraph, or vice versa.
2337 (cursor_row_p): Consider the case of point being equal to
2338 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2339 from the end of a short line to the beginning of a continued line
2340 of R2L text within L2R paragraph.
2341 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2342 composed characters.
2343
2344 * bidi.c (bidi_check_type): Use xassert.
2345 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2346 members.
2347
2348 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2349
2350 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2351 a character.
2352
2353 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2354
2355 * nsfont.m (ns_otf_to_script): Fix typo.
2356
2357 2011-08-22 Kenichi Handa <handa@m17n.org>
2358
2359 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2360 extra slot even if the purpose is char-code-property-table.
2361
2362 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2363
2364 * xdisp.c (redisplay_window): When computing centering_position,
2365 account for the height of the header line. (Bug#8874)
2366
2367 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2368 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2369 candidate is selected by the mouse, and that candidate has a
2370 composed character under the mouse.
2371
2372 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2373 coordinates reported by pos-visible-in-window-p for a composed
2374 character in column zero.
2375
2376 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2377
2378 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2379
2380 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2381
2382 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2383 consider it a hit if to_charpos is anywhere in the range of the
2384 composed buffer positions.
2385
2386 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2387
2388 * image.c (gif_load): Don't assume that each subimage has the same
2389 dimensions as the base image. Handle disposal method that is
2390 "undefined" by the gif spec (Bug#9335).
2391
2392 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2393
2394 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2395 (Fcondition_case): Document `debug' symbol in error handler.
2396
2397 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2398
2399 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2400 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2401 from an Org mode buffer to a Speedbar frame.
2402
2403 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2404 a composition, take its buffer position from IT->cmp_it.charpos.
2405 Fixes cursor positioning at the beginning of a line that begins
2406 with a composed character.
2407
2408 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2409
2410 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2411 character bidirectional type, use STRONG_L instead. Fixes crashes
2412 in a buffer produced by `describe-categories'.
2413
2414 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2415 members before the level stack, so they would be saved and
2416 restored when copying iterator state. Fixes incorrect reordering
2417 around TABs covered by display properties.
2418
2419 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2420
2421 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2422
2423 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2424
2425 * eval.c (internal_condition_case, internal_condition_case_1)
2426 (internal_condition_case_2, internal_condition_case_n):
2427 Remove unnecessary aborts (Bug#9081).
2428
2429 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2430
2431 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2432 has no `load' handler, try opening the file locally. (Bug#9311)
2433
2434 2011-08-16 Ken Brown <kbrown@cornell.edu>
2435
2436 * gmalloc.c: Expand comment.
2437
2438 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2439
2440 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2441 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2442
2443 2011-08-16 Ken Brown <kbrown@cornell.edu>
2444
2445 Fix memory allocation problems in Cygwin build (Bug#9273).
2446
2447 * unexcw.c ( __malloc_initialized): Declare external variable.
2448 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2449
2450 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2451 New variables.
2452 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2453 dumped emacs.
2454 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2455 in the static heap.
2456 [CYGWIN] (special_realloc): New function.
2457 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2458 requests to realloc storage in the static heap.
2459
2460 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2461
2462 * bidi.c (bidi_initialize): Remove unused local.
2463
2464 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2465
2466 * bidimirror.h:
2467 * biditype.h: Remove file.
2468 * makefile.w32-in ($(BLD)/bidi.$(O)):
2469 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2470
2471 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2472
2473 * chartab.c: Improve commentary for the uniprop_table API.
2474
2475 * bidi.c (bidi_paragraph_init): Support zero value of
2476 bidi_ignore_explicit_marks_for_paragraph_level.
2477 (bidi_initialize): Use uniprop_table instead of including
2478 biditype.h and bidimirror.h.
2479
2480 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2481 coordinates of the iterator when restoring from ppos_it.
2482 (Bug#9296)
2483
2484 2011-08-14 Kenichi Handa <handa@m17n.org>
2485
2486 * process.c (create_process): Call setup_process_coding_systems
2487 after the pid of the process is set to -1 (Bug#8162).
2488
2489 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2490
2491 * xdisp.c (move_it_in_display_line_to): Don't invoke
2492 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2493 ppos_it. Fixes vertical cursor motion when line beginning is
2494 covered by an image. (Bug#9296)
2495
2496 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2497
2498 * nsterm.h (ns_run_ascript): Declare.
2499 (NSAPP_DATA2_RUNASSCRIPT): Define.
2500
2501 * nsfns.m (as_script, as_result, as_status): New static variables.
2502 (ns_run_ascript): New function.
2503 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2504 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2505 the event loop. Get status from as_status (Bug#7276).
2506
2507 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2508 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2509 the event loop (Bug#7276).
2510
2511 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2512
2513 * gnutls.c (QCgnutls_bootprop_priority)
2514 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2515 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2516 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2517 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2518 (QCgnutls_bootprop_verify_hostname_error)
2519 (QCgnutls_bootprop_callbacks_verify): Rename from
2520 Qgnutls_bootprop_..., all uses changed.
2521
2522 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2523 uses changed.
2524
2525 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2526
2527 * xfaces.c (Qframe_set_background_mode): Now static.
2528 * dispextern.h (Qframe_set_background_mode): Remove decl.
2529
2530 * process.c (Fnetwork_interface_info): Declare local only if needed.
2531
2532 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2533
2534 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2535 (Fnetwork_interface_list): Allocate in increments of bytes instead
2536 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2537 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2538 sockaddr.
2539 (struct ifflag_def): notrailers is smart on OSX.
2540 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2541 Get hardware address with getifaddrs if available.
2542
2543 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2544
2545 * xdisp.c (iterate_out_of_display_property): xassert that
2546 IT->position is set to within IT->object's boundaries. Break from
2547 the loop as soon as EOB is reached; avoids infloops in redisplay
2548 when IT->position is set up wrongly due to some bug.
2549 Set IT->current to match the bidi iterator unconditionally.
2550 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2551 entry. Force push_it to save on the stack the current
2552 buffer/string position, to be restored by pop_it. Fix flags in
2553 the iterator structure wrt the object coming from a display
2554 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2555 properties. (Bug#9284)
2556
2557 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2558
2559 * fontset.c (fontset_get_font_group): Add proper type checks.
2560 (Bug#9172)
2561
2562 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2563
2564 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2565 and LC_VERSION_MIN_MACOSX.
2566 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2567 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2568
2569 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2570
2571 * xdisp.c (forward_to_next_line_start): Allow to use the
2572 no-display-properties-and-no-overlays under bidi display.
2573 Set disp_pos in the bidi iterator to avoid searches for display
2574 properties and overlays.
2575
2576 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2577
2578 * editfns.c (Fset_time_zone_rule): Document relationship with the
2579 setenv function.
2580
2581 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2582 the font entity extracted from the cache (Bug#8109).
2583
2584 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2585
2586 * composite.c (autocmp_chars): Don't reset point. That is done by
2587 restore_point_unwind (Bug#5984).
2588
2589 2011-08-07 Juri Linkov <juri@jurta.org>
2590
2591 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2592 to show the arg `TIME' instead of `TIMEVAL'.
2593
2594 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2595
2596 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2597 display property strides EOL and includes a newline, as in
2598 longlines-mode. (Bug#9254)
2599 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2600 word-wrap under bidirectional display. (Bug#9224)
2601
2602 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2603 is non-zero, even if the data buffer is NULL. Fixes a crash in
2604 vertical-motion with longlines-mode. (Bug#9254)
2605
2606 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2607
2608 * bidi.c <bidi_cache_total_alloc>: Now static.
2609 (bidi_initialize): Initialize bidi_cache_total_alloc.
2610
2611 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2612 cache. (Bug#9221)
2613
2614 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2615 amount allocated this far in `bidi_cache_total_alloc'.
2616 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2617 non-zero, only free the data buffer without restoring the cache
2618 contents. All callers changed.
2619
2620 * dispextern.h (bidi_unshelve_cache): Update prototype.
2621
2622 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2623 (move_it_in_display_line, move_it_to)
2624 (move_it_vertically_backward, move_it_by_lines): Replace the call
2625 to xfree to an equivalent call to bidi_unshelve_cache.
2626 (move_it_in_display_line_to): Fix logic of returning
2627 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2628
2629 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2630
2631 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2632 came from a string character with a `cursor' property. (Bug#9229)
2633
2634 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2635
2636 * Makefile.in (LIB_PTHREAD): New variable.
2637 (LIBES): Add LIB_PTHREAD (Bug#9216).
2638
2639 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2640 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2641
2642 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2643
2644 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2645
2646 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2647
2648 * xterm.c (x_find_topmost_parent): New function.
2649 (x_set_frame_alpha): Find topmost parent window with
2650 x_find_topmost_parent and set the property there also (bug#9181).
2651 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2652
2653 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2654
2655 * callproc.c (Fcall_process): Avoid vfork clobbering
2656 the local vars buffer, coding_systems, current_dir.
2657
2658 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2659
2660 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2661
2662 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2663
2664 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2665 so that it is not optimized away.
2666
2667 * xdisp.c (compute_display_string_pos): Remove unused local.
2668
2669 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2670
2671 Fix slow cursor motion and scrolling in large buffers with
2672 selective display, like Org Mode buffers. (Bug#9218)
2673
2674 * dispextern.h (struct bidi_it): New member disp_prop_p.
2675
2676 * xdisp.c: Remove one-slot cache of display string positions.
2677 (compute_display_string_pos): Accept an additional argument
2678 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2679 for a display string or property. If found, set DISP_PROP_P
2680 non-zero.
2681
2682 * bidi.c (bidi_fetch_char): Accept an additional argument
2683 DISP_PROP_P, and pass it to compute_display_string_pos.
2684 Only handle text covered by a display string if DISP_PROP_P is returned
2685 non-zero. All callers of bidi_fetch_char changed.
2686
2687 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2688
2689 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2690
2691 2010-12-03 Don March <don@ohspite.net>
2692
2693 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2694 last character M-[char] is translated to ESC [char] (bug#7541).
2695
2696 2011-08-02 Kenichi Handa <handa@m17n.org>
2697
2698 * lisp.h (uniprop_table): Extern it.
2699
2700 * chartab.c (uniprop_table): Make it non-static.
2701
2702 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2703
2704 * xdisp.c (forward_to_next_line_start): Accept additional argument
2705 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2706 on the newline.
2707 (reseat_at_next_visible_line_start): Use the bidi iterator state
2708 returned by forward_to_next_line_start to restore the state of
2709 it->bidi_it after backing up to previous newline. (Bug#9212)
2710
2711 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2712
2713 * regex.c (re_comp): Protoize.
2714 (re_exec): Fix return type.
2715 (regexec): Fix type of `ret'. (Bug#9203)
2716
2717 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2718
2719 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2720 This is needed if max-image-size is a floating-point number.
2721
2722 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2723
2724 * print.c (print_object): Print empty symbol as ##.
2725
2726 * lread.c (read1): Read ## as empty symbol.
2727
2728 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2729
2730 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2731 setting frame foreground color (Bug#9175).
2732 (x_set_background_color): Likewise.
2733
2734 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2735 contents (Bug#9176).
2736 (EmacsTooltip -init): Remove bezels and add shadows to
2737 tooltip windows.
2738
2739 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2740 or scroll bar (Bug#8470).
2741
2742 * nsfont.m (nsfont_open): Remove assignment to voffset and
2743 unnecessary vars hshink, expand, hd, full_height, min_height.
2744 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2745
2746 * nsterm.h (nsfont_info): Remove voffset field.
2747
2748 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2749
2750 Implement strike-through and overline on NextStep (Bug#8863).
2751
2752 * nsfont.m (nsfont_open): Use underline position provided by font,
2753 instead of hard-coded value of 2.
2754 (nsfont_draw): Call ns_draw_text_decoration instead.
2755
2756 * nsterm.h: Add declaration for ns_draw_text_decoration.
2757
2758 * nsterm.m (ns_draw_text_decoration): New function for drawing
2759 underline, overline, and strike-through.
2760 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2761 ns_draw_text_decoration. Change treatment of cursor drawing to
2762 accommodate underlining, etc.
2763
2764 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2765
2766 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2767 default.
2768
2769 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2770
2771 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2772 Without this fix, if a signal arrives just after memory fills up,
2773 'malloc' might be invoked reentrantly.
2774
2775 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2776 In other words, assume that every image size is allowed, on non-X
2777 hosts. This assumption is probably wrong, but it lets Emacs compile.
2778
2779 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2780
2781 * regex.c (re_iswctype): Convert return values to boolean.
2782
2783 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2784
2785 * xdisp.c (compute_display_string_pos): Don't use cached display
2786 string position if the buffer had its restriction changed.
2787 (Bug#9184)
2788
2789 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2790
2791 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2792
2793 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2794
2795 Integer signedness and overflow and related fixes. (Bug#9079)
2796
2797 * bidi.c: Integer size and overflow fixes.
2798 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2799 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2800 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2801 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2802 (bidi_find_other_level_edge):
2803 Use ptrdiff_t instead of EMACS_INT where either will do.
2804 This works better on 32-bit hosts configured --with-wide-int.
2805 (bidi_cache_ensure_space): Check for size-calculation overflow.
2806 Use % rather than repeated addition, for better worst-case speed.
2807 Don't set bidi_cache_size until after xrealloc returns, because it
2808 might not return.
2809 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2810 (bidi_cache_ensure_space): Also check that the bidi cache size
2811 does not exceed that of the largest Lisp string or buffer. See Eli
2812 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2813
2814 * alloc.c (__malloc_size_t): Remove.
2815 All uses replaced by size_t. See Andreas Schwab's note
2816 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2817
2818 * image.c: Improve checking for integer overflow.
2819 (check_image_size): Assume that f is nonnull, since
2820 it is always nonnull in practice. This is one less thing to
2821 worry about when checking for integer overflow later.
2822 (x_check_image_size): New function, which checks for integer
2823 overflow issues inside X.
2824 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2825 This removes the need for a memory_full check.
2826 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2827 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2828 (xbm_read_bitmap_data): Change locals back to 'int', since
2829 their values must fit in 'int'.
2830 (xpm_load_image, png_load, tiff_load):
2831 Invoke x_create_x_image_and_pixmap earlier,
2832 to avoid much needless work if the image is too large.
2833 (tiff_load): Treat overly large images as if
2834 x_create_x_image_and_pixmap failed, not as malloc failures.
2835 (gs_load): Use x_check_image_size.
2836
2837 * gtkutil.c: Omit integer casts.
2838 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2839 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2840
2841 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2842
2843 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2844 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2845 would wrongly return t on a 64-bit host.
2846
2847 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2848 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2849 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2850 and therefore cause GCC to emit a bogus diagnostic in some cases.
2851
2852 * image.c: Integer signedness and overflow and related fixes.
2853 This is not an exhaustive set of fixes, but it's time to
2854 record what I've got.
2855 (lookup_pixel_color, check_image_size): Remove redundant decls.
2856 (check_image_size): Don't assume that arbitrary EMACS_INT values
2857 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2858 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2859 (tiff_load, imagemagick_load_image):
2860 Check for overflow in size calculations.
2861 (x_create_x_image_and_pixmap): Remove unnecessary test for
2862 xmalloc returning NULL; that can't happen.
2863 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2864 (xpm_color_bucket): Use better integer hashing function.
2865 (xpm_cache_color): Don't possibly over-allocate memory.
2866 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2867 (gif_memory_source):
2868 Use ptrdiff_t, not int or size_t, to record sizes.
2869 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2870 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2871 either works, as we prefer signed integers.
2872 (tiff_read_from_memory, tiff_write_from_memory):
2873 Return tsize_t, not size_t, since that's what the TIFF API wants.
2874 (tiff_read_from_memory): Don't fail simply because the read would
2875 go past EOF; instead, return a short read.
2876 (tiff_load): Omit no-longer-needed casts.
2877 (Fimagemagick_types): Don't assume size fits into 'int'.
2878
2879 Improve hashing quality when configured --with-wide-int.
2880 * fns.c (hash_string): New function, taken from sxhash_string.
2881 Do not discard information about ASCII character case; this
2882 discarding is no longer needed.
2883 (sxhash-string): Use it. Change sig to match it. Caller changed.
2884 * lisp.h: Declare it.
2885 * lread.c (hash_string): Remove, since we now use fns.c's version.
2886 The fns.c version returns a wider integer if --with-wide-int is
2887 specified, so this should help the quality of the hashing a bit.
2888
2889 * emacs.c: Integer overflow minor fix.
2890 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2891 Define only if GNU_LINUX.
2892 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2893
2894 * dispnew.c: Integer signedness and overflow fixes.
2895 Remove unnecessary forward decls, that were a maintenance hassle.
2896 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2897 All uses changed.
2898 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2899 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2900 (prepare_desired_row, line_draw_cost):
2901 Use int, not unsigned, where either works.
2902 (save_current_matrix, restore_current_matrix):
2903 Use ptrdiff_t, not size_t, where either works.
2904 (init_display): Check for overflow more accurately, and without
2905 relying on undefined behavior.
2906
2907 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2908 Remove, replacing with the new symbols in lisp.h. All uses changed.
2909 * fileio.c (make_temp_name):
2910 * filelock.c (lock_file_1, lock_file):
2911 * xdisp.c (message_dolog):
2912 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2913 Use pMd etc. instead.
2914 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2915 replacing the pWIDE etc. symbols removed from editfns.c.
2916
2917 * keyboard.h (num_input_events): Now uintmax_t.
2918 This is (very slightly) less likely to mess up due to wraparound.
2919 All uses changed.
2920
2921 * buffer.c: Integer signedness fixes.
2922 (alloc_buffer_text, enlarge_buffer_text):
2923 Use ptrdiff_t rather than size_t when either will do, as we prefer
2924 signed integers.
2925
2926 * alloc.c: Integer signedness and overflow fixes.
2927 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2928 (__malloc_size_t): Default to size_t, not to int.
2929 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2930 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2931 Prefer ptrdiff_t to size_t when either would do, as we prefer
2932 signed integers.
2933 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2934 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2935 Now const. Initialize with values that are in range even if char
2936 is signed.
2937 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2938 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2939 These functions do the right thing with sizes > 2**32.
2940 (check_depth): Now ptrdiff_t, not int.
2941 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2942 Adjust to new way of storing sizes. Check for size overflow bugs
2943 in rest of code.
2944 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2945 slightly wrong anyway, as it missed one instance of
2946 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2947 (refill_memory_reserve): Omit needless cast to size_t.
2948 (mark_object_loop_halt): Mark as externally visible.
2949
2950 * xselect.c: Integer signedness and overflow fixes.
2951 (Fx_register_dnd_atom, x_handle_dnd_message):
2952 Use ptrdiff_t, not size_t, since we prefer signed.
2953 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2954 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2955 x_dnd_atoms_size and x_dnd_atoms_length.
2956
2957 * doprnt.c: Prefer signed to unsigned when either works.
2958 * eval.c (verror):
2959 * doprnt.c (doprnt):
2960 * lisp.h (doprnt):
2961 * xdisp.c (vmessage):
2962 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2963 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2964 prefer signed arithmetic to avoid comparison confusion.
2965 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2966 but is a bit tricky.
2967
2968 Assume freestanding C89 headers, string.h, stdlib.h.
2969 * data.c, doprnt.c, floatfns.c, print.c:
2970 Include float.h unconditionally.
2971 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2972 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2973 * regex.c: Likewise for stddef.h, string.h.
2974 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2975 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2976 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2977 (STDC_HEADERS): Remove obsolete defines.
2978 * sysdep.c: Include limits.h unconditionally.
2979
2980 Assume support for memcmp, memcpy, memmove, memset.
2981 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2982 * regex.c (memcmp, memcpy):
2983 Remove; we assume C89 now.
2984
2985 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2986 (__malloc_safe_bcopy): Remove; no longer needed.
2987
2988 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
2989 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2990 well either way, and we prefer signed to unsigned.
2991
2992 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2993
2994 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2995 closes the connection while we're reading (bug#9182).
2996
2997 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
2998
2999 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3000 are specified (Bug#9168).
3001
3002 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3003
3004 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3005 Found by GCC static checking and --with-wide-int on a 32-bit host.
3006
3007 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3008
3009 * xdisp.c (compute_display_string_pos): Fix logic of caching
3010 previous display string position. Initialize cached_prev_pos to
3011 -1. Fixes slow-down at the beginning of a buffer.
3012
3013 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3014
3015 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3016 for attrs[LFACE_FONTSET_INDEX].
3017
3018 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3019
3020 * xml.c (parse_region): Remove unused local
3021 that was recently introduced.
3022
3023 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3024
3025 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3026 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3027
3028 * xdisp.c (move_it_in_display_line_to): Record the best matching
3029 position for TO_CHARPOS while scanning the line, and restore it on
3030 exit if none of the characters scanned was an exact match.
3031 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3032 when exact match is impossible due to invisible text, and the
3033 lines are truncated.
3034
3035 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3036
3037 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3038 for OSX >= 10.7.
3039
3040 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3041
3042 Fix a significant slow-down of cursor motion with C-n, C-p,
3043 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3044 auto-repeat under bidi redisplay in fontified buffers.
3045 * xdisp.c (compute_stop_pos_backwards): New function.
3046 (next_element_from_buffer): Call compute_stop_pos_backwards to
3047 find a suitable prev_stop when we find ourselves before
3048 base_level_stop.
3049 (reseat): Don't look for prev_stop, as that could mean a very long
3050 run.
3051 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3052 <cached_disp_overlay_modiff>: Cache for last found display string
3053 position.
3054 (compute_display_string_pos): Return the cached position if asked
3055 about the same buffer in the same area of character positions, and
3056 the buffer wasn't changed since the time the display string
3057 position was cached.
3058
3059 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3060
3061 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3062 is an integer, which is important for empty lines. (Bug#9149)
3063
3064 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3065
3066 * frame.c (Fmodify_frame_parameters): In tty case, update the
3067 default face if necessary (Bug#4238).
3068
3069 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3070
3071 * editfns.c (Fstring_to_char): No need to explain what a character
3072 is in the docstring (Bug#6576).
3073
3074 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3075
3076 * xml.c (parse_region): Make sure we always return a tree.
3077
3078 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3079
3080 * xml.c (parse_region): If a document contains only comments,
3081 return that, too.
3082
3083 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3084
3085 * xml.c (make_dom): Return comments, too.
3086
3087 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3088
3089 Port to OpenBSD.
3090 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3091 and the surrounding thread.
3092 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3093 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3094 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3095 timer goes off.
3096 * s/openbsd.h (BROKEN_SIGIO): Define.
3097 * unexelf.c (unexec) [__OpenBSD__]:
3098 Don't update the .mdebug section of the Alpha COFF symbol table.
3099
3100 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3101
3102 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3103 (bug#8460).
3104
3105 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3106
3107 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3108 This fixes some race conditions on the permissions of any newly
3109 created file.
3110
3111 * alloc.c (valid_pointer_p): Use pipe, not open.
3112 This fixes some permissions issues when debugging.
3113
3114 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3115 If fchown fails to set both uid and gid, try to set just gid,
3116 as that is sometimes allowed. Adjust the file's mode to eliminate
3117 setuid or setgid bits that are inappropriate if fchown fails.
3118
3119 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3120
3121 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3122 to compare Lisp_Objects.
3123 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3124 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3125 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3126
3127 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3128
3129 * lread.c (read_integer): Unread even EOF character.
3130 (read1): Likewise. Properly record start position of symbol.
3131
3132 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3133 symbol character follows.
3134
3135 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3136
3137 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3138 This works around a problem with the previous change to Fcopy_file.
3139 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3140 and without this change, GCC might complain about discarding
3141 fchown's return value.
3142
3143 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3144
3145 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3146
3147 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3148
3149 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3150
3151 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3152
3153 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3154 it's used from the C level.
3155
3156 * process.c: Use the same condition for POLL_FOR_INPUT in both
3157 keyboard.c and process.c (bug#1858).
3158
3159 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3160
3161 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3162 (Fgnutls_boot): Use it.
3163
3164 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3165
3166 * doc.c (Fsubstitute_command_keys): Revert last change.
3167
3168 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3169
3170 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3171 quotes the next character, and doesn't affect other longer
3172 sequences (bug#8935).
3173
3174 * lread.c (syms_of_lread): Clarify that is isn't only
3175 `eval-buffer' and `eval-defun' that's affected by
3176 `lexical-binding' (bug#8460).
3177
3178 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3179
3180 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3181 bidi redisplay when a line includes both an image and is truncated.
3182
3183 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3184
3185 Fix minor problems found by static checking.
3186 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3187 (elsz): Now a signed constant, not a size_t var. We prefer signed
3188 types to unsigned, to avoid integer comparison confusion. Without
3189 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3190 "cannot optimize loop, the loop counter may overflow", a symptom
3191 of the confusion.
3192 * indent.c (Fvertical_motion): Mark locals as initialized.
3193 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3194
3195 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3196
3197 * search.c (Fre_search_backward): Mention `case-fold-search' in
3198 all the re_search_* functions (bug#8138).
3199
3200 * keyboard.c (Fopen_dribble_file): Document when the file is
3201 closed (bug#8056).
3202
3203 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3204
3205 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3206 bidi_cache_idx.
3207
3208 Support bidi reordering of display and overlay strings.
3209 * xdisp.c (compute_display_string_pos)
3210 (compute_display_string_end): Accept additional argument STRING.
3211 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3212 (reseat_to_string): Initialize bidi_it->string.s and
3213 bidi_it->string.schars.
3214 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3215 NULL (avoids a crash in bidi_paragraph_init).
3216 Initialize itb.string.lstring.
3217 (init_iterator): Call bidi_init_it only of a valid
3218 buffer position was specified. Initialize paragraph_embedding to
3219 L2R.
3220 (reseat_to_string): Initialize the bidi iterator.
3221 (display_string): If we need to ignore text properties of
3222 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3223 original value of -1 will not work with bidi.)
3224 (compute_display_string_pos): First arg is now struct
3225 `text_pos *'; all callers changed. Support display properties on
3226 Lisp strings.
3227 (compute_display_string_end): Support display properties on Lisp
3228 strings.
3229 (init_iterator, reseat_1, reseat_to_string): Initialize the
3230 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3231 when iterating on a string not from display properties).
3232 (compute_display_string_pos, compute_display_string_end):
3233 Fix calculation of the object to scan. Fixes an error when using
3234 arrow keys.
3235 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3236 base_level_stop; instead, set base_level_stop to BEGV.
3237 Fixes crashes in vertical-motion.
3238 (next_element_from_buffer): Improve commentary for when
3239 the iterator is before prev_stop.
3240 (init_iterator): Initialize bidi_p from the default value of
3241 bidi-display-reordering, not from buffer-local value. Use the
3242 buffer-local value only if initializing for buffer iteration.
3243 (handle_invisible_prop): Support invisible properties on strings
3244 that are being bidi-reordered.
3245 (set_iterator_to_next): Support bidi reordering of C strings and
3246 Lisp strings.
3247 (next_element_from_string): Support bidi reordering of Lisp
3248 strings.
3249 (handle_stop_backwards): Support Lisp strings as well.
3250 (display_string): Support display of R2L glyph rows.
3251 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3252 (init_iterator): Don't initialize it->bidi_p for strings
3253 here.
3254 (reseat_to_string): Initialize it->bidi_p for strings here.
3255 (next_element_from_string, next_element_from_c_string)
3256 (next_element_from_buffer): Add xassert's for correspondence
3257 between IT's object being iterated and it->bidi_it.string
3258 structure.
3259 (face_before_or_after_it_pos): Support bidi iteration.
3260 (next_element_from_c_string): Handle the case of the first string
3261 character that is not the first one in the visual order.
3262 (get_visually_first_element): New function, refactored from common
3263 parts of next_element_from_buffer, next_element_from_string, and
3264 next_element_from_c_string.
3265 (tool_bar_lines_needed, redisplay_tool_bar)
3266 (display_menu_bar): Force left-to-right direction. Add a FIXME
3267 comment for making that be controlled by a user option.
3268 (push_it, pop_it): Save and restore the state of the
3269 bidi iterator. Save and restore the bidi_p flag.
3270 (pop_it): Iterate out of display property for string iteration as
3271 well.
3272 (iterate_out_of_display_property): Support iteration over strings.
3273 (handle_single_display_spec): Set up it->bidi_it for iteration
3274 over a display string, and call bidi_init_it.
3275 (handle_single_display_spec, next_overlay_string)
3276 (get_overlay_strings_1, push_display_prop): Set up the bidi
3277 iterator for displaying display or overlay strings.
3278 (forward_to_next_line_start): Don't use the shortcut if
3279 bidi-iterating.
3280 (back_to_previous_visible_line_start): If handle_display_prop
3281 pushed the iterator stack, restore the internal state of the bidi
3282 iterator by calling bidi_pop_it same number of times.
3283 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3284 and we are bidi-iterating, don't decrement the iterator position;
3285 instead, set the first_elt flag in the bidi iterator, to produce
3286 the same effect.
3287 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3288 (push_display_prop): xassert that we are iterating a buffer.
3289 (push_it, pop_it): Save and restore paragraph_embedding member.
3290 (handle_single_display_spec, next_overlay_string)
3291 (get_overlay_strings_1, reseat_1, reseat_to_string)
3292 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3293 correctly. Don't assume unibyte strings are not bidi-reordered.
3294 (compute_display_string_pos)
3295 (compute_display_string_end): Fix handling the case of C string.
3296 (push_it, pop_it): Save and restore from_disp_prop_p.
3297 (handle_single_display_spec, push_display_prop): Set the
3298 from_disp_prop_p flag.
3299 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3300 (pop_it): Call iterate_out_of_display_property only if we are
3301 popping after iteration over a string that came from a display
3302 property. Fix a typo in popping stretch info. Add an assertion
3303 for verifying that the iterator position is in sync with the bidi
3304 iterator.
3305 (handle_single_display_spec, get_overlay_strings_1)
3306 (push_display_prop): Fix initialization of paragraph direction for
3307 string when that of the parent object is not yet determined.
3308 (reseat_1): Call bidi_init_it to resync the bidi
3309 iterator with IT's position. (Bug#7616)
3310 (find_row_edges): If ROW->start.pos gives position
3311 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3312 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3313 Reset the from_disp_prop_p flag.
3314 (SAVE_IT, RESTORE_IT): New macros.
3315 (pos_visible_p, face_before_or_after_it_pos)
3316 (back_to_previous_visible_line_start)
3317 (move_it_in_display_line_to, move_it_in_display_line)
3318 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3319 (try_scrolling, redisplay_window, display_line): Use them when
3320 saving a temporary copy of the iterator and restoring it back.
3321 (back_to_previous_visible_line_start, reseat_1)
3322 (init_iterator): Empty the bidi cache "stack".
3323 (move_it_in_display_line_to): If iterator ended up at
3324 EOL, but we never saw any buffer positions smaller than
3325 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3326 motion in bidi-reordered lines.
3327 (move_it_in_display_line_to): Record prev_method and prev_pos
3328 immediately before the call to set_iterator_to_next. Fixes cursor
3329 motion in bidi-reordered lines with stretch glyphs and strings
3330 displayed in margins. (Bug#8133) (Bug#8867)
3331 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3332 TO_CHARPOS.
3333 (pos_visible_p): Support positions in bidi-reordered lines.
3334 Save and restore bidi cache.
3335
3336 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3337 (bidi_paragraph_info): Delete unused struct.
3338 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3339 (bidi_cache_start): New variable.
3340 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3341 to zero.
3342 (bidi_cache_fetch_state, bidi_cache_search)
3343 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3344 (bidi_cache_find, bidi_peek_at_next_level)
3345 (bidi_level_of_next_char, bidi_find_other_level_edge)
3346 (bidi_move_to_visually_next): Compare cache index with
3347 bidi_cache_start rather than with zero.
3348 (bidi_fetch_char): Accept new argument STRING; all callers
3349 changed. Support iteration over a string. Support strings with
3350 display properties. Support unibyte strings. Fix the type of
3351 `len' according to what STRING_CHAR_AND_LENGTH expects.
3352 (bidi_paragraph_init, bidi_resolve_explicit_1)
3353 (bidi_resolve_explicit, bidi_resolve_weak)
3354 (bidi_level_of_next_char, bidi_move_to_visually_next):
3355 Support iteration over a string.
3356 (bidi_set_sor_type, bidi_resolve_explicit_1)
3357 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3358 can now be zero (for strings); special values 0 and -1 were
3359 changed to -1 and -2, respectively.
3360 (bidi_char_at_pos): New function.
3361 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3362 Call it instead of FETCH_MULTIBYTE_CHAR.
3363 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3364 initialized to valid values.
3365 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3366 values.
3367 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3368 the test for valid cached positions. Fix the logic for looking up
3369 the sentinel state in the cache. GCPRO the Lisp string we are
3370 iterating.
3371 (bidi_push_it, bidi_pop_it): New functions.
3372 (bidi_initialize): Initialize the bidi cache start stack pointer.
3373 (bidi_cache_ensure_space): New function, refactored from part of
3374 bidi_cache_iterator_state. Don't assume the required size is just
3375 one BIDI_CACHE_CHUNK away.
3376 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3377 (bidi_count_bytes, bidi_char_at_pos): New functions.
3378 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3379 always valid if bidi_cache_idx is valid.
3380 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3381 is valid if it's going to be used.
3382 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3383 (bidi_cache_fetch_state, bidi_cache_search)
3384 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3385 (bidi_cache_iterator_state, bidi_cache_find)
3386 (bidi_find_other_level_edge, bidi_cache_start_stack):
3387 All variables related to cache indices are now EMACS_INT.
3388
3389 * dispextern.h (struct bidi_string_data): New structure.
3390 (struct bidi_it): New member `string'. Make flag members be 1-bit
3391 fields, and put them last in the struct.
3392 (compute_display_string_pos, compute_display_string_end):
3393 Update prototypes.
3394 (bidi_push_it, bidi_pop_it): Add prototypes.
3395 (struct iterator_stack_entry): New members bidi_p,
3396 paragraph_embedding, and from_disp_prop_p.
3397 (struct it): Member bidi_p is now a bit field 1 bit wide.
3398 (bidi_shelve_cache, bidi_unshelve_cache):
3399 Declare prototypes.
3400
3401 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3402 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3403 and vector-like objects.
3404
3405 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3406 cache around display iteration.
3407
3408 * window.c (Fwindow_end, window_scroll_pixel_based)
3409 (displayed_window_lines, Frecenter): Save and restore the bidi
3410 cache around display iteration.
3411
3412 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3413
3414 * editfns.c (Fdelete_region): Clarify the use of the named
3415 parameters (bug#6788).
3416
3417 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3418
3419 * indent.c (Fvertical_motion): Set and restore w->pointm when
3420 saving and restoring the window's buffer (Bug#9006).
3421
3422 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3423
3424 * editfns.c (Fstring_to_char): Clarify just what is returned
3425 (bug#6576). Text by Eli Zaretskii.
3426
3427 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3428
3429 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3430
3431 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3432
3433 * buffer.c (mmap_find): Fix a typo.
3434
3435 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3436
3437 Fix execution of x selection hooks.
3438 * xselect.c (Qx_lost_selection_functions)
3439 (Qx_sent_selection_functions): New vars.
3440 (syms_of_xselect): DEFSYM them.
3441 (x_handle_selection_request): Pass Qx_sent_selection_functions
3442 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3443 (x_handle_selection_clear,x_clear_frame_selections):
3444 Pass Qx_lost_selection_functions rather than
3445 Vx_lost_selection_functions to Frun_hook_with_args.
3446
3447 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3448
3449 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3450 The old code sometimes used this field without initializing it.
3451
3452 * alloc.c (gc_sweep): Don't read past end of array.
3453 In theory, the old code could also have corrupted Emacs internals,
3454 though it'd be very unlikely.
3455
3456 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3457
3458 * character.c (Fcharacterp): Don't advertise optional ignored
3459 argument. (Bug#4026)
3460
3461 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3462
3463 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3464 key" (bug#4257).
3465
3466 * window.c (Fset_window_start): Doc fix (bug#4199).
3467 (Fset_window_hscroll): Ditto.
3468
3469 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3470
3471 Fix minor new problems caught by GCC 4.6.1.
3472 * term.c (init_tty): Remove unused local.
3473 * xsettings.c (store_monospaced_changed): Define this function only
3474 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3475 not used otherwise.
3476
3477 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3478
3479 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3480
3481 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3482
3483 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3484 are the mini-buffer and the echo area (bug#3320).
3485
3486 * term.c (init_tty): Remove support for supdup, c10 and perq
3487 terminals, which are no longer supported (bug#1482).
3488
3489 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3490
3491 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3492
3493 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3494
3495 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3496 for non-popups (Bug#3642).
3497
3498 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3499
3500 * alloc.c (reset_malloc_hooks): Protoize.
3501 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3502 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3503 * cm.c (losecursor): Likewise.
3504 * data.c (fmod): Likewise.
3505 * dispnew.c (swap_glyphs_in_rows): Likewise.
3506 * emacs.c (memory_warning_signal): Likewise.
3507 * floatfns.c (float_error): Likewise.
3508 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3509 (otf_open, font_otf_capability, generate_otf_features)
3510 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3511 Likewise.
3512 * image.c (pbm_read_file): Likewise.
3513 * indent.c (string_display_width): Likewise.
3514 * intervals.c (check_for_interval, search_for_interval)
3515 (inc_interval_count, count_intervals, root_interval)
3516 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3517 * lread.c (defalias): Likewise.
3518 * ralloc.c (r_alloc_check): Likewise.
3519 * regex.c (set_image_of_range_1, set_image_of_range)
3520 (regex_grow_registers): Likewise.
3521 * sysdep.c (strerror): Likewise.
3522 * termcap.c (valid_filename_p, tprint, main): Likewise.
3523 * tparam.c (main): Likewise.
3524 * unexhp9k800.c (run_time_remap, save_data_space)
3525 (update_file_ptrs, read_header, write_header, calculate_checksum)
3526 (copy_file, copy_rest, display_header): Likewise.
3527 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3528 Likewise.
3529 * xdisp.c (check_it): Likewise.
3530 * xfaces.c (register_color, unregister_color, unregister_colors):
3531 Likewise.
3532 * xfns.c (print_fontset_result): Likewise.
3533 * xrdb.c (member, fatal, main): Likewise.
3534
3535 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3536
3537 Fix minor problems found by static checking (Bug#9031).
3538 * chartab.c (char_table_set_range, map_sub_char_table):
3539 Remove unused locals.
3540 (uniprop_table): Now static.
3541 * composite.c (_work_char): Remove unused static var.
3542
3543 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3544
3545 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3546
3547 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3548
3549 * gtkutil.c (qttip_cb): Remove code without function.
3550
3551 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3552
3553 * w32.c (pthread_sigmask): New stub.
3554
3555 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3556
3557 Use pthread_sigmask, not sigprocmask (Bug#9010).
3558 sigprocmask is portable only for single-threaded applications, and
3559 Emacs can be multi-threaded when it uses GTK.
3560 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3561 (LIBES): Use it.
3562 * callproc.c (Fcall_process):
3563 * process.c (create_process):
3564 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3565 Use pthread_sigmask, not sigprocmask.
3566
3567 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3568
3569 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3570 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3571 wrong (Bug#8591).
3572
3573 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3574
3575 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3576 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3577 (xg_hide_tooltip): Fix comment.
3578
3579 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3580 in registerServicesMenuSendTypes.
3581 (validRequestorForSendType): Don't check ns_return_types.
3582
3583 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3584 ns_return_type.
3585
3586 2011-07-08 Jason Rumney <jasonr@gnu.org>
3587
3588 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3589 SH_SHOW for hidden windows (Bug#5482).
3590
3591 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3592 frame struct members of non-existent frames (Bug#6284).
3593
3594 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3595
3596 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3597 variable firstTime not needed on OSX >= 10.6.
3598 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3599 >= 10.5. Use setKnobProportion, setDoubleValue.
3600
3601 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3602 (MAC_OS_X_VERSION_10_5): Define if not defined.
3603 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3604 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3605 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3606
3607 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3608 cString and lossyCString on OSX >= 10.4
3609
3610 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3611 sizeToFit on OSX >= 10.2.
3612
3613 * nsimage.m (allocInitFromFile): Don't use deprecated method
3614 bestRepresentationForDevice on OSX >= 10.6.
3615
3616 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3617 to avoid warning.
3618
3619 * emacs.c: Declare unexec_init_emacs_zone.
3620
3621 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3622
3623 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3624
3625 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3626 on svcsMenu (Bug#8842).
3627
3628 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3629 ns_return_types.
3630 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3631
3632 * nsterm.m (QUTF8_STRING): Declare.
3633 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3634 (validRequestorForSendType): Return type is (id).
3635 Change indexOfObjectIdenticalTo to indexOfObject.
3636 Check if we have local selection before returning self (Bug#8842).
3637 (writeSelectionToPasteboard): Put local selection into paste board
3638 if we have a local selection (Bug#8842).
3639 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3640
3641 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3642 (ns_get_local_selection): Declare.
3643
3644 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3645
3646 * keymap.c (describe_map_tree): Don't insert a double newline at
3647 the end of the buffer (bug#1169) and return whether we inserted
3648 something.
3649
3650 * callint.c (Fcall_interactively): Change "reading args" to
3651 "providing args" to try to clarify what it does (bug#1010).
3652
3653 2011-07-07 Kenichi Handa <handa@m17n.org>
3654
3655 * composite.c (composition_compute_stop_pos): Ignore a static
3656 composition starting before CHARPOS (Bug#8915).
3657
3658 * xdisp.c (handle_composition_prop): Likewise.
3659
3660 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3661
3662 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3663 (Bug#9015)
3664
3665 2011-07-07 Kenichi Handa <handa@m17n.org>
3666
3667 * character.h (unicode_category_t): New enum type.
3668
3669 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3670 (Qchar_code_property_table): New variable.
3671 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3672 (UNIPROP_COMPRESSED_FORM_P): New macros.
3673 (char_table_ascii): Uncompress the compressed values.
3674 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3675 Uncompress the compressed values.
3676 (sub_char_table_ref_and_range): Likewise.
3677 (char_table_ref_and_range): Uncompress the compressed values.
3678 (sub_char_table_set): New arg is_uniprop. Callers changed.
3679 Uncompress the compressed values.
3680 (sub_char_table_set_range): Args changed. Callers changed.
3681 (char_table_set_range): Adjuted for the above change.
3682 (map_sub_char_table): Delete args default_val and parent. Add arg
3683 top. Give decoded values to a Lisp function.
3684 (map_char_table): Adjust for the above change. Give decoded
3685 values to a Lisp function. Gcpro more variables.
3686 (uniprop_table_uncompress)
3687 (uniprop_decode_value_run_length): New functions.
3688 (uniprop_decoder, uniprop_decoder_count): New variables.
3689 (uniprop_get_decoder, uniprop_encode_value_character)
3690 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3691 New functions.
3692 (uniprop_encoder, uniprop_encoder_count): New variables.
3693 (uniprop_get_encoder, uniprop_table)
3694 (Funicode_property_table_internal, Fget_unicode_property_internal)
3695 (Fput_unicode_property_internal): New functions.
3696 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3697 Sunicode_property_table_internal, Sget_unicode_property_internal,
3698 and Sput_unicode_property_internal. Defvar_lisp
3699 char-code-property-alist.
3700
3701 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3702 Vunicode_category_table.
3703
3704 * font.c (font_range): Adjust for the change of
3705 Vunicode_category_table.
3706
3707 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3708
3709 * m/iris4d.h: Remove file, move contents ...
3710 * s/irix6-5.h: ... here.
3711
3712 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3713
3714 Remove unportable assumption about struct layout (Bug#8884).
3715 * alloc.c (mark_buffer):
3716 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3717 (clone_per_buffer_values): Don't assume that
3718 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3719 This isn't true in general, and it's particularly not true
3720 if Emacs is configured with --with-wide-int.
3721 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3722 New macros, used in the buffer.c change.
3723
3724 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3725
3726 * xsettings.c: Use both GConf and GSettings if both are available.
3727 (store_config_changed_event): Add comment.
3728 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3729 (store_tool_bar_style_changed): New functions.
3730 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3731 (struct xsettings): Move font inside HAVE_XFT.
3732 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3733 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3734 Move inside HAVE_XFT.
3735 (something_changed_gsettingsCB): Rename from something_changedCB.
3736 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3737 also.
3738 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3739 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3740 (something_changed_gconfCB): Rename from something_changedCB.
3741 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3742 (parse_settings): Move check for font inside HAVE_XFT.
3743 (read_settings, apply_xft_settings): Add comment.
3744 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3745 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3746 call store_font_name_changed.
3747 (xft_settings_event): Add comment.
3748 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3749 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3750 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3751 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3752 (xsettings_initialize): Call init_gsettings last.
3753 (xsettings_get_system_font, xsettings_get_system_normal_font):
3754 Add comment.
3755
3756 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3757
3758 Random fixes. E.g., (random) never returned negative values.
3759 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3760 subseconds part to the entropy, as that's a bit more random.
3761 Prefer signed to unsigned, since the signedness doesn't matter and
3762 in general we prefer signed. When given a limit, use a
3763 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3764 latter isn't right if USE_2_TAGS_FOR_INTS.
3765 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3766 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3767
3768 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3769
3770 * textprop.c (text_property_stickiness):
3771 Obey Vtext_property_default_nonsticky.
3772 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3773 * w32fns.c (syms_of_w32fns):
3774 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3775
3776 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3777
3778 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3779 This is more efficient than Ffile_directory_p and avoids a minor race.
3780
3781 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3782
3783 * buffer.c (Foverlay_put): Say what the return value is
3784 (bug#7835).
3785
3786 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3787 is a directory before asking whether to use the file name
3788 (bug#7564).
3789 (barf_or_query_if_file_exists): Make the "File is a directory"
3790 error be more correct.
3791
3792 * fns.c (Frequire): Remove the mention of the .gz files, since
3793 that's installation-specific, but keep the mention of
3794 `get-load-suffixes'.
3795
3796 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3797
3798 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3799 Report string overflow if the output is too long.
3800
3801 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3802
3803 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3804 (syms_of_gnutls): Remove duplicate DEFSYM for
3805 Qgnutls_bootprop_verify_hostname_error, an error for
3806 Qgnutls_bootprop_verify_error (which is no longer used).
3807
3808 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3809 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3810 Also (re)move comments that are misplaced or no longer relevant.
3811
3812 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3813
3814 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3815
3816 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3817
3818 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3819 and background color parameters if they have been changed.
3820
3821 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3822
3823 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3824
3825 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3826
3827 * xsettings.c (SYSTEM_FONT): Define only when used.
3828 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3829
3830 * keymap.c (access_keymap_1): Now static.
3831
3832 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3833
3834 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3835 leave any prefix arg for the up event (Bug#1586).
3836
3837 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3838
3839 * lread.c (syms_of_lread): Mention single symbols defined by
3840 `defvar' or `defconst' (bug#7154).
3841
3842 * fns.c (Frequire): Mention .el.gz files (bug#7314).
3843 (Frequire): Mention get-load-suffixes.
3844
3845 2011-07-02 Martin Rudalics <rudalics@gmx.at>
3846
3847 * window.h (window): Remove clone_number slot.
3848 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3849 Remove.
3850 (make_parent_window, make_window, saved_window)
3851 (Fset_window_configuration, save_window_save): Don't deal with
3852 clone numbers.
3853 * buffer.c (Qclone_number): Remove declaration.
3854 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3855
3856 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3857
3858 Add multiple inheritance to keymaps.
3859 * keymap.c (Fmake_composed_keymap): New function.
3860 (Fset_keymap_parent): Simplify.
3861 (fix_submap_inheritance): Remove.
3862 (access_keymap_1): New function extracted from access_keymap to handle
3863 embedded parents and handle lists of maps.
3864 (access_keymap): Use it.
3865 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3866 (Fcopy_keymap): Handle embedded parents.
3867 (Fcommand_remapping, define_as_prefix): Simplify.
3868 (Fkey_binding): Simplify.
3869 (syms_of_keymap): Move minibuffer-local-completion-map,
3870 minibuffer-local-filename-completion-map,
3871 minibuffer-local-must-match-map, and
3872 minibuffer-local-filename-must-match-map to Elisp.
3873 (syms_of_keymap): Defsubr make-composed-keymap.
3874 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3875 (parse_menu_item): Trivial simplification.
3876
3877 2011-07-01 Glenn Morris <rgm@gnu.org>
3878
3879 * Makefile.in (SETTINGS_LIBS): Fix typo.
3880
3881 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3882
3883 * coding.c (Fencode_coding_string): Record the last coding system
3884 used, as the function doc string says (bug#8738).
3885
3886 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3887
3888 * xsettings.c (store_monospaced_changed): Take new font as arg and
3889 check for change against current_mono_font.
3890 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3891 (emacs_settings_constructor, emacs_settings_get_property)
3892 (emacs_settings_set_property, emacs_settings_class_init)
3893 (emacs_settings_init, gsettings_obj): Remove.
3894 (something_changedCB): New function for HAVE_GSETTINGS.
3895 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3896 with value as argument.
3897 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3898 g_settings_new (Bug#8967). Do not create gsettings_obj.
3899 Remove calls to g_settings_bind. Connect something_changedCB to
3900 "changed".
3901
3902 * xgselect.c: Add defined (HAVE_GSETTINGS).
3903 (xgselect_initialize): Ditto.
3904
3905 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3906 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3907 xg_select.
3908
3909 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3910
3911 * eval.c (struct backtrace): Simplify and port the data structure.
3912 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3913 signed bit field, as this assumption is not portable and it makes
3914 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3915 "char debug_on_exit : 1" as this is not portable either; instead,
3916 use the portable "unsigned int debug_on_exit : 1". Remove unused
3917 member evalargs. Remove obsolete comments about cc bombing out.
3918
3919 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3920
3921 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
3922 Let HAVE_GSETTINGS override HAVE_GCONF.
3923 (store_monospaced_changed): New function.
3924 (EMACS_SETTINGS): A new type derived from GObject to handle
3925 GSettings notifications.
3926 (emacs_settings_constructor, emacs_settings_get_property)
3927 (emacs_settings_set_property, emacs_settings_class_init):
3928 New functions.
3929 (gsettings_client, gsettings_obj): New variables.
3930 (GSETTINGS_SCHEMA): New define.
3931 (something_changedCB): Call store_monospaced_changed.
3932 (init_gsettings): New function.
3933 (xsettings_initialize): Call init_gsettings.
3934 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3935 to NULL.
3936
3937 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
3938 GCONF_CFLAGS/LIBS.
3939
3940 2011-06-29 Martin Rudalics <rudalics@gmx.at>
3941
3942 * window.c (resize_root_window, grow_mini_window)
3943 (shrink_mini_window): Rename Qresize_root_window to
3944 Qwindow_resize_root_window and Qresize_root_window_vertically to
3945 Qwindow_resize_root_window_vertically.
3946
3947 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3948
3949 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3950
3951 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
3952
3953 * makefile.w32-in: Redesign dependencies so they reflect more
3954 clearly which files are directly included by each source file,
3955 and not through other includes.
3956
3957 2011-06-27 Martin Rudalics <rudalics@gmx.at>
3958
3959 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3960 (sort_overlays, overlay_strings): When an overlay's clone number
3961 matches the window's clone number process the overlay even if
3962 the overlay's window property doesn't match the current window.
3963
3964 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3965 (Fwindow_hchild): Rename to Fwindow_left_child.
3966 (Fwindow_next): Rename to Fwindow_next_sibling.
3967 (Fwindow_prev): Rename to Fwindow_prev_sibling.
3968 (resize_window_check): Rename to window_resize_check.
3969 (resize_window_apply): Rename to window_resize_apply.
3970 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3971 (Fdelete_other_windows_internal, resize_frame_windows)
3972 (Fsplit_window_internal, Fdelete_window_internal)
3973 (grow_mini_window, shrink_mini_window)
3974 (Fresize_mini_window_internal): Fix callers accordingly.
3975
3976 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3977
3978 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3979 (emacs_fixed_set_min_size): Remove.
3980 (emacs_fixed_new): Take frame as argument.
3981
3982 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3983 (_EmacsFixedPrivate): Remove minwidth/height.
3984 Add struct frame *f.
3985 (emacs_fixed_init): Initialize priv->f.
3986 (get_parent_class, emacs_fixed_set_min_size): Remove.
3987 (emacs_fixed_new): Set priv->f to argument.
3988 (emacs_fixed_get_preferred_width)
3989 (emacs_fixed_get_preferred_height): Use min_width/height from
3990 frames size_hint to set minimum and natural (Bug#8919).
3991 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3992 and use min_width/height from frames size_hint to set
3993 min_width/height (Bug#8919).
3994
3995 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
3996 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3997 Fix indentation.
3998
3999 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4000
4001 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4002 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4003 called at ZV.
4004
4005 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4006
4007 * process.c (wait_reading_process_output): Bypass select if
4008 waiting for a cell while ignoring keyboard input, and input is
4009 pending. Suggested by Jan Djärv (Bug#8869).
4010
4011 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4012
4013 Use gnulib's dup2 module instead of rolling our own.
4014 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4015
4016 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4017
4018 * dispnew.c (scrolling_window): Before scrolling, turn off a
4019 mouse-highlight in the window being scrolled.
4020
4021 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4022
4023 Move DEFSYM to lisp.h and use everywhere.
4024
4025 * character.h (DEFSYM): Move declaration...
4026 * lisp.h (DEFSYM): ...here.
4027
4028 * gnutls.c:
4029 * minibuf.c:
4030 * w32menu.c:
4031 * w32proc.c:
4032 * w32select.c: Don't include character.h.
4033
4034 * alloc.c (syms_of_alloc):
4035 * buffer.c (syms_of_buffer):
4036 * bytecode.c (syms_of_bytecode):
4037 * callint.c (syms_of_callint):
4038 * casefiddle.c (syms_of_casefiddle):
4039 * casetab.c (init_casetab_once):
4040 * category.c (init_category_once, syms_of_category):
4041 * ccl.c (syms_of_ccl):
4042 * cmds.c (syms_of_cmds):
4043 * composite.c (syms_of_composite):
4044 * dbusbind.c (syms_of_dbusbind):
4045 * dired.c (syms_of_dired):
4046 * dispnew.c (syms_of_display):
4047 * doc.c (syms_of_doc):
4048 * editfns.c (syms_of_editfns):
4049 * emacs.c (syms_of_emacs):
4050 * eval.c (syms_of_eval):
4051 * fileio.c (syms_of_fileio):
4052 * fns.c (syms_of_fns):
4053 * frame.c (syms_of_frame):
4054 * fringe.c (syms_of_fringe):
4055 * insdel.c (syms_of_insdel):
4056 * keymap.c (syms_of_keymap):
4057 * lread.c (init_obarray, syms_of_lread):
4058 * macros.c (syms_of_macros):
4059 * msdos.c (syms_of_msdos):
4060 * print.c (syms_of_print):
4061 * process.c (syms_of_process):
4062 * search.c (syms_of_search):
4063 * sound.c (syms_of_sound):
4064 * syntax.c (init_syntax_once, syms_of_syntax):
4065 * terminal.c (syms_of_terminal):
4066 * textprop.c (syms_of_textprop):
4067 * undo.c (syms_of_undo):
4068 * w32.c (globals_of_w32):
4069 * window.c (syms_of_window):
4070 * xdisp.c (syms_of_xdisp):
4071 * xfaces.c (syms_of_xfaces):
4072 * xfns.c (syms_of_xfns):
4073 * xmenu.c (syms_of_xmenu):
4074 * xsettings.c (syms_of_xsettings):
4075 * xterm.c (syms_of_xterm): Use DEFSYM.
4076
4077 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4078
4079 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4080
4081 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4082
4083 Integer and buffer overflow fixes (Bug#8873).
4084
4085 * print.c (printchar, strout): Check for string overflow.
4086 (PRINTPREPARE, printchar, strout):
4087 Don't set size unless allocation succeeds.
4088
4089 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4090 for sizes. Check for string overflow more accurately.
4091 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4092
4093 * macros.c: Integer and buffer overflow fixes.
4094 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4095 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4096 Use ptrdiff_t, not int, for sizes.
4097 Don't increment bufsize until after realloc succeeds.
4098 Check for size-calculation overflow.
4099 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4100
4101 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4102
4103 * lread.c: Integer overflow fixes.
4104 (read_integer): Radix is now EMACS_INT, not int,
4105 to improve quality of diagnostics for out-of-range radices.
4106 Calculate buffer size correctly for out-of-range radices.
4107 (read1): Check for integer overflow in radices, and in
4108 read-circle numbers.
4109 (read_escape): Avoid int overflow.
4110 (Fload, openp, read_buffer_size, read1)
4111 (substitute_object_recurse, read_vector, read_list, map_obarray):
4112 Use ptrdiff_t, not int, for sizes.
4113 (read1): Use EMACS_INT, not int, for sizes.
4114 Check for size overflow.
4115
4116 * image.c (cache_image): Check for size arithmetic overflow.
4117
4118 * lread.c: Integer overflow issues.
4119 (saved_doc_string_size, saved_doc_string_length)
4120 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4121 Now ptrdiff_t, not int.
4122 (read1): Don't assume doc string length fits in int. Check for
4123 out-of-range doc string lengths.
4124 (read_list): Don't assume file position fits in int.
4125 (read_escape): Check for hex character overflow.
4126
4127 2011-06-22 Leo Liu <sdl.web@gmail.com>
4128
4129 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4130 Move to minibuffer.el.
4131
4132 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4133
4134 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4135 The following patches are for when GLYPH_DEBUG && !XASSERT.
4136 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4137 * dispnew.c (flush_stdout):
4138 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4139 Mark as externally visible.
4140 * dispnew.c (check_window_matrix_pointers): Now static.
4141 * dispnew.c (window_to_frame_vpos):
4142 * xfns.c (unwind_create_frame):
4143 * xterm.c (x_check_font): Remove unused local.
4144 * scroll.c (CHECK_BOUNDS):
4145 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4146 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4147 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4148 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4149 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4150 Now static.
4151 (debug_method_add): Use va_list and vsprintf rather than relying
4152 on undefined behavior with wrong number of arguments.
4153 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4154 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4155 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4156 since we're not interested in debugging glyphs with old libraries.
4157 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4158 GCC 4.6.0's static checking.
4159
4160 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4161
4162 Integer overflow and signedness fixes (Bug#8873).
4163 A few related buffer overrun fixes, too.
4164
4165 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4166
4167 * dispextern.h (struct face.stipple):
4168 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4169 (x_bitmap_mask, x_allocate_bitmap_record)
4170 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4171 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4172 (x_create_bitmap_from_xpm_data):
4173 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4174 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4175 (.bitmaps_last):
4176 * xfaces.c (load_pixmap):
4177 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4178 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4179 (.bitmaps_last, struct x_output.icon_bitmap):
4180 Use ptrdiff_t, not int, for bitmap indexes.
4181 (x_allocate_bitmap_record): Check for size overflow.
4182 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4183
4184 Use ptrdiff_t, not int, for overlay counts.
4185 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4186 * editfns.c (overlays_around, get_pos_property):
4187 * textprop.c (get_char_property_and_overlay):
4188 * xdisp.c (next_overlay_change, note_mouse_highlight):
4189 * xfaces.c (face_at_buffer_position):
4190 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4191 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4192 (Fnext_overlay_change, Fprevious_overlay_change)
4193 (mouse_face_overlay_overlaps, Foverlays_in):
4194 Use ptrdiff_t, not int, for sizes.
4195 (overlays_at, overlays_in): Check for size-calculation overflow.
4196
4197 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4198
4199 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4200 (x_session_initialize): Do not assume string length fits in int.
4201
4202 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4203 This is unlikely, but can occur if DPI is outlandish.
4204
4205 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4206 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4207
4208 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4209 * xrdb.c (magic_file_p, search_magic_path):
4210 Omit last arg SUFFIX; it was always 0. All callers changed.
4211 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4212
4213 * xfont.c (xfont_match): Avoid need for strlen.
4214
4215 * xfns.c: Don't assume strlen fits in int.
4216 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4217
4218 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4219 not unsigned long, as we prefer signed integers. All callers changed.
4220 Detect integer overflow in repeat count.
4221 (message_dolog): Don't assume print length fits in 39 bytes.
4222 (display_mode_element): Don't assume strlen fits in int.
4223
4224 * termcap.c: Don't assume sizes fit in int and never overflow.
4225 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4226 (gobble_line): Check for size-calculation overflow.
4227
4228 * minibuf.c (Fread_buffer):
4229 * lread.c (intern, intern_c_string):
4230 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4231 Don't assume string length fits in int.
4232
4233 * keyboard.c (parse_tool_bar_item):
4234 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4235
4236 * font.c: Don't assume string length fits in int.
4237 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4238 Use ptrdiff_t, not int.
4239 (font_intern_prop): Don't assume string length fits in int.
4240 Don't assume integer property fits in fixnum.
4241 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4242
4243 * filelock.c: Fix some buffer overrun and integer overflow issues.
4244 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4245 Reformulate so as not to need the command string.
4246 Invoke gzip -cd rather than gunzip, as it's more portable.
4247 (lock_info_type, lock_file_1, lock_file):
4248 Don't assume pid_t and time_t fit in unsigned long.
4249 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4250 (current_lock_owner): Prefer signed type for sizes.
4251 Use memcpy, not strncpy, where memcpy is what is really wanted.
4252 Don't assume (via atoi) that time_t and pid_t fit in int.
4253 Check for time_t and/or pid_t out of range, e.g., via a network share.
4254 Don't alloca where an auto var works fine.
4255
4256 * fileio.c: Fix some integer overflow issues.
4257 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4258 Don't assume string length fits in int.
4259 (directory_file_name): Don't assume string length fits in long.
4260 (make_temp_name): Don't assume pid fits in int, or that its print
4261 length is less than 20.
4262
4263 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4264
4265 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4266
4267 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4268
4269 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4270 We prefer signed integers, even for size calculations.
4271
4272 * emacs.c: Don't assume string length fits in 'int'.
4273 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4274 (main): Don't invoke strlen when not needed.
4275
4276 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4277 (XD_DEBUG_MESSAGE): Don't waste a byte.
4278
4279 * callproc.c (getenv_internal_1, getenv_internal)
4280 (Fgetenv_internal):
4281 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4282
4283 * lread.c (invalid_syntax): Omit length argument.
4284 All uses changed. This doesn't fix a bug, but it simplifies the
4285 code away from its former Hollerith-constant appearance, and it's
4286 one less 'int' to worry about when looking at integer-overflow issues.
4287 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4288
4289 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4290 This didn't break anything, but it didn't help either.
4291 It's confusing to put a bogus integer in a place where the actual
4292 value does not matter.
4293 (LIST_END_P): Remove unused macro and its bogus comment.
4294 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4295
4296 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4297 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4298 implementation.
4299 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4300 We prefer signed types, and the value cannot exceed the EMACS_INT
4301 range anyway (because otherwise the length would not be representable).
4302 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4303 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4304 This avoids a GCC warning when WIDE_EMACS_INT.
4305
4306 * indent.c (sane_tab_width): New function.
4307 (current_column, scan_for_column, Findent_to, position_indentation)
4308 (compute_motion): Use it. This is just for clarity.
4309 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4310
4311 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4312
4313 * lisp.h (lint_assume): New macro.
4314 * composite.c (composition_gstring_put_cache):
4315 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4316
4317 * editfns.c, insdel.c:
4318 Omit unnecessary forward decls, to simplify future changes.
4319
4320 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4321
4322 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4323
4324 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4325 Use much-faster test for byte-length change.
4326 Don't assume string byte-length fits in 'int'.
4327 Check that character arg fits in 'int'.
4328 (mapcar1): Declare byte as byte, for clarity.
4329
4330 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4331
4332 * fns.c (concat): Catch string overflow earlier.
4333 Do not rely on integer wraparound.
4334
4335 * dispextern.h (struct it.overlay_strings_charpos)
4336 (struct it.selective): Now EMACS_INT, not int.
4337 * xdisp.c (forward_to_next_line_start)
4338 (back_to_previous_visible_line_start)
4339 (reseat_at_next_visible_line_start, next_element_from_buffer):
4340 Don't arbitrarily truncate the value of 'selective' to int.
4341
4342 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4343
4344 * composite.c: Don't truncate sizes to 'int'.
4345 (composition_gstring_p, composition_reseat_it)
4346 (composition_adjust_point): Use EMACS_INT, not int.
4347 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4348 not EMACS_UINT, for indexes.
4349
4350 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4351
4352 * buffer.c: Include <verify.h>.
4353 (struct sortvec.priority, struct sortstr.priority):
4354 Now EMACS_INT, not int.
4355 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4356 (struct sortstr.size, record_overlay_string)
4357 (struct sortstrlist.size, struct sortlist.used):
4358 Don't truncate size to int.
4359 (record_overlay_string): Check for size-calculation overflow.
4360 (init_buffer_once): Check at compile-time, not run-time.
4361
4362 2011-06-22 Jim Meyering <meyering@redhat.com>
4363
4364 Don't leak an XBM-image-sized buffer
4365 * image.c (xbm_load): Free the image buffer after using it.
4366
4367 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4368
4369 Port to Sun C.
4370 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4371 that Sun C diagnosed.
4372 * fns.c (secure_hash): Fix pointer signedness issue.
4373 * intervals.c (static_offset_intervals): New function.
4374 (offset_intervals): Use it.
4375
4376 2011-06-21 Leo Liu <sdl.web@gmail.com>
4377
4378 * deps.mk (fns.o):
4379 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4380 sha512.h.
4381
4382 * fns.c (secure_hash): Rename from crypto_hash_function and change
4383 the first arg to accept symbols.
4384 (Fsecure_hash): New primitive.
4385 (syms_of_fns): New symbols.
4386
4387 2011-06-20 Deniz Dogan <deniz@dogan.se>
4388
4389 * process.c (Fset_process_buffer): Clarify return value in
4390 docstring.
4391
4392 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4393
4394 * dispnew.c (add_window_display_history): Use BVAR.
4395
4396 * xdisp.c (debug_method_add): Use BVAR.
4397 (check_window_end, dump_glyph_matrix, dump_glyph)
4398 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4399
4400 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4401 Likewise.
4402
4403 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4404 check till after the cache is created in init_frame_faces.
4405
4406 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4407
4408 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4409
4410 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4411
4412 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4413 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4414 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4415
4416 Improve buffer-overflow checking (Bug#8873).
4417 * fileio.c (Finsert_file_contents):
4418 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4419 Remove the old (too-loose) buffer overflow checks.
4420 They weren't needed, since make_gap checks for buffer overflow.
4421 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4422 The old code merely checked for Emacs fixnum overflow, and relied
4423 on undefined (wraparound) behavior. The new code avoids undefined
4424 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4425
4426 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4427 Tune. Don't use wider integers than needed. Don't use alloca.
4428 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4429
4430 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4431
4432 * insdel.c, lisp.h (buffer_overflow): New function.
4433 (insert_from_buffer_1, replace_range, replace_range_2):
4434 * insdel.c (make_gap_larger):
4435 * editfns.c (Finsert_char):
4436 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4437
4438 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4439
4440 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4441
4442 Integer overflow and signedness fixes (Bug#8873).
4443
4444 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4445 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4446
4447 * fileio.c: Don't assume EMACS_INT fits in off_t.
4448 (emacs_lseek): New static function.
4449 (Finsert_file_contents, Fwrite_region): Use it.
4450 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4451
4452 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4453
4454 * fns.c: Don't overflow int when computing a list length.
4455 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4456 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4457 truncation on 64-bit hosts. Check for QUIT every
4458 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4459 faster and is responsive enough.
4460 (Flength): Report an error instead of overflowing an integer.
4461 (Fsafe_length): Return a float if the value is not representable
4462 as a fixnum. This shouldn't happen except in contrived situations.
4463 (Fnthcdr, Fsort): Don't assume list length fits in int.
4464 (Fcopy_sequence): Don't assume vector length fits in int.
4465
4466 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4467 (header_size, word_size): New constants.
4468 (allocate_vectorlike): Don't check size overflow here.
4469 (allocate_vector): Check it here instead, since this is the only
4470 caller of allocate_vectorlike that could cause overflow.
4471 Check that the new vector's length is representable as a fixnum.
4472
4473 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4474 The previous code was bogus. For example, next_almost_prime (32)
4475 returned 39, which is undesirable as it is a multiple of 3; and
4476 next_almost_prime (24) returned 25, which is a multiple of 5 so
4477 why was the code bothering to check for multiples of 7?
4478
4479 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4480
4481 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4482
4483 Variadic C functions now count arguments with ptrdiff_t.
4484 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4485 Back then I didn't know that the Emacs coding style prefers signed int.
4486 Also, in the meantime I found a few more instances where arguments
4487 were being counted with int, which may truncate counts on 64-bit
4488 machines, or EMACS_INT, which may be unnecessarily wide.
4489 * lisp.h (struct Lisp_Subr.function.aMANY)
4490 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4491 Arg counts are now ptrdiff_t, not size_t.
4492 All variadic functions and their callers changed accordingly.
4493 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4494 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4495 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4496 * callint.c (Fcall_interactively): Check arg count for overflow,
4497 to avoid potential buffer overrun. Use signed char, not 'int',
4498 for 'varies' array, so that we needn't bother to check its size
4499 calculation for overflow.
4500 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4501 * eval.c (apply_lambda):
4502 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4503 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4504 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4505
4506 * callint.c (Fcall_interactively): Don't use index var as event count.
4507
4508 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4509 * mem-limits.h (SIZE): Remove; no longer used.
4510
4511 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4512
4513 Remove unnecessary casts.
4514 * xterm.c (x_term_init):
4515 * xfns.c (x_set_border_pixel):
4516 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4517 These aren't needed now that we assume ANSI C.
4518
4519 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4520 It's more likely to cause problems (due to unsigned overflow)
4521 than to cure them.
4522
4523 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4524
4525 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4526
4527 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4528
4529 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4530
4531 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4532
4533 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4534
4535 GLYPH_CODE_FACE returns EMACS_INT, not int.
4536 * dispextern.h (merge_faces):
4537 * xfaces.c (merge_faces):
4538 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4539 Don't assume EMACS_INT fits in int.
4540
4541 * character.h (CHAR_VALID_P): Remove unused parameter.
4542 * fontset.c, lisp.h, xdisp.c: All uses changed.
4543
4544 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4545
4546 * fns.c (concat): Minor tuning based on overflow analysis.
4547 This doesn't fix any bugs. Use int to hold character, instead
4548 of constantly refetching from Emacs object. Use XFASTINT, not
4549 XINT, for value known to be a character. Don't bother comparing
4550 a single byte to 0400, as it's always less.
4551
4552 * floatfns.c (Fexpt):
4553 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4554
4555 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4556 for characters.
4557
4558 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4559
4560 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4561 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4562 incorrectly succeed when S was a string, because 4294967386 was
4563 truncated before it was used.
4564
4565 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4566 Otherwise, an out-of-range integer could cause undefined behavior
4567 on a 64-bit host.
4568
4569 * composite.c: Use int, not EMACS_INT, for characters.
4570 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4571 EMACS_INT, for values that are known to be in character range.
4572 This doesn't fix any bugs but is the usual style inside Emacs and
4573 may generate better code on 32-bit machines.
4574
4575 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4576 This is for reasons similar to the recent CHAR_STRING fix.
4577 * charset.c (Fencode_char): Check that character arg is actually
4578 a character. Pass an int to ENCODE_CHAR.
4579 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4580 wider than 'int', as a compile-time check to prevent future regressions
4581 in this area.
4582
4583 * character.c (char_string): Remove unnecessary casts.
4584
4585 Make sure a 64-bit char is never passed to CHAR_STRING.
4586 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4587 by silently ignoring the top 32 bits, allowing some values
4588 that were far too large to be valid characters.
4589 * character.h: Include <verify.h>.
4590 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4591 arguments are no wider than unsigned, as a compile-time check
4592 to prevent future regressions in this area.
4593 * data.c (Faset):
4594 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4595 (Fsubst_char_in_region):
4596 * fns.c (concat):
4597 * xdisp.c (decode_mode_spec_coding):
4598 Adjust to CHAR_STRING's new requirement.
4599 * editfns.c (Finsert_char, Fsubst_char_in_region):
4600 * fns.c (concat): Check that character args are actually
4601 characters. Without this test, these functions did the wrong
4602 thing with wildly out-of-range values on 64-bit hosts.
4603
4604 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4605 These casts should not be needed on 32-bit hosts, either.
4606 * keyboard.c (read_char):
4607 * lread.c (Fload): Remove casts to unsigned.
4608
4609 * lisp.h (UNSIGNED_CMP): New macro.
4610 This fixes comparison bugs on 64-bit hosts.
4611 (ASCII_CHAR_P): Use it.
4612 * casefiddle.c (casify_object):
4613 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4614 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4615 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4616 * dispextern.h (FACE_FROM_ID):
4617 * keyboard.c (read_char): Use UNSIGNED_CMP.
4618
4619 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4620 not to EMACS_INT, to avoid GCC warning.
4621
4622 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4623
4624 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4625 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4626 isn't needed on 32-bit machines.
4627
4628 * buffer.c (Fgenerate_new_buffer_name):
4629 Use EMACS_INT for count, not int.
4630 (advance_to_char_boundary): Return EMACS_INT, not int.
4631
4632 * data.c (Qcompiled_function): Now static.
4633
4634 * window.c (window_body_lines): Now static.
4635
4636 * image.c (gif_load): Rename local to avoid shadowing.
4637
4638 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4639 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4640 * alloc.c (make_save_value): Integer argument is now of type
4641 ptrdiff_t, not int.
4642 (mark_object): Use ptrdiff_t, not int.
4643 * lisp.h (pD): New macro.
4644 * print.c (print_object): Use it.
4645
4646 * alloc.c: Use EMACS_INT, not int, to count objects.
4647 (total_conses, total_markers, total_symbols, total_vector_size)
4648 (total_free_conses, total_free_markers, total_free_symbols)
4649 (total_free_floats, total_floats, total_free_intervals)
4650 (total_intervals, total_strings, total_free_strings):
4651 Now EMACS_INT, not int. All uses changed.
4652 (Fgarbage_collect): Compute overall total using a double, so that
4653 integer overflow is less likely to be a problem. Check for overflow
4654 when converting back to an integer.
4655 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4656 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4657 These were 'int' variables that could overflow on 64-bit hosts;
4658 they were never used, so remove them instead of repairing them.
4659 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4660 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4661 Previously, this ceilinged at INT_MAX, but that doesn't work on
4662 64-bit machines.
4663 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4664
4665 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4666 (allocate_vectorlike): Check for ptrdiff_t overflow.
4667 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4668 when a (possibly-narrower) signed value would do just as well.
4669 We prefer using signed arithmetic, to avoid comparison confusion.
4670
4671 * alloc.c: Catch some string size overflows that we were missing.
4672 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4673 for convenience in STRING_BYTES_MAX.
4674 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4675 The definition here is exact; the one in lisp.h was approximate.
4676 (allocate_string_data): Check for string overflow. This catches
4677 some instances we weren't catching before. Also, it catches
4678 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4679 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4680 and ptrdiff_t and EMACS_INT are both 64 bits.
4681
4682 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4683 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4684 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4685
4686 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4687
4688 * alloc.c (Fmake_string): Check for out-of-range init.
4689
4690 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4691
4692 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4693
4694 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4695
4696 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4697 xg_get_default_scrollbar_width.
4698
4699 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4700 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4701 (style_changed_cb): Call update_theme_scrollbar_width and call
4702 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4703 all frames (Bug#8505).
4704 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4705 Call gtk_window_set_resizable if HAVE_GTK3.
4706 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4707 and height if HAVE_GTK3 (Bug#8505).
4708 (scroll_bar_width_for_theme): New variable.
4709 (update_theme_scrollbar_width): New function.
4710 (xg_get_default_scrollbar_width): Move code to
4711 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4712 (xg_initialize): Call update_theme_scrollbar_width.
4713
4714 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4715
4716 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4717
4718 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4719
4720 * frame.c (make_frame): Call other_buffer_safely instead of
4721 other_buffer.
4722
4723 * window.c (temp_output_buffer_show): Call display_buffer with
4724 second argument Vtemp_buffer_show_specifiers and reset latter
4725 immediately after the call.
4726 (Vtemp_buffer_show_specifiers): New variable.
4727 (auto_window_vscroll_p, next_screen_context_lines)
4728 (Vscroll_preserve_screen_position): Remove leading asterisks from
4729 doc-strings.
4730
4731 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4732
4733 Fix minor problems found by GCC 4.6.0 static checking.
4734 * buffer.c (Qclone_number): Remove for now, as it's unused.
4735 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4736 (record_buffer): Remove unused local.
4737 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4738 (set_frame_buffer_list): Remove; unused.
4739 * frame.h (other_visible_frames): Remove decl.
4740 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4741 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4742 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4743 if HAVE_GPM.
4744 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4745 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4746 Define only if HAVE_GPM.
4747 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4748 (update_hints_inhibit): Remove; never set. All uses removed.
4749 * widgetprv.h (emacsFrameClassRec): Remove decl.
4750 * window.c (delete_deletable_window): Now returns void, since it
4751 wasn't returning anything.
4752 (compare_window_configurations): Remove unused locals.
4753 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4754 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4755 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4756 the same widths as pointers. This follows up on the 2011-05-06 patch.
4757 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4758 * xterm.h: Likewise.
4759 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4760
4761 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4762
4763 * makefile.w32-in: Update dependencies.
4764 (LISP_H): Add lib/intprops.h.
4765
4766 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4767
4768 * image.c (gif_load): Add animation frame delay to the metadata.
4769 (syms_of_image): Use DEFSYM. New symbol `delay'.
4770
4771 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4772
4773 * window.c (delete_deletable_window): Re-add.
4774 (Fset_window_configuration): Rewrite to handle dead buffers and
4775 consequently deletable windows.
4776 (window_tree, Fwindow_tree): Remove. Supply functionality in
4777 window.el.
4778 (compare_window_configurations): Simplify code.
4779
4780 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4781
4782 * image.c (imagemagick_load_image): Fix type mismatch.
4783 (Fimagemagick_types): Likewise.
4784
4785 * window.h (replace_buffer_in_windows): Declare.
4786
4787 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4788
4789 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4790 Qclone_number. Remove external declaration of Qdelete_window.
4791 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4792 code.
4793 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4794 Run Qbuffer_list_update_hook if allowed.
4795 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4796 buffer list implementation.
4797 (other_buffer_safely): New function.
4798 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4799 calls to replace_buffer_in_windows and
4800 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4801 if allowed.
4802 (record_buffer): Inhibit quitting and rewrite using quittable
4803 functions. Run Qbuffer_list_update_hook if allowed.
4804 (Frecord_buffer, Funrecord_buffer): New functions.
4805 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4806 Move switch-to-buffer to window.el.
4807 (bury-buffer): Move to window.el.
4808 (Vbuffer_list_update_hook): New variable.
4809
4810 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4811 section.
4812
4813 * window.h (resize_frame_windows): Move up in code.
4814 (Fwindow_frame): Remove EXFUN.
4815 (replace_buffer_in_all_windows): Remove prototype.
4816 (replace_buffer_in_windows_safely): Add prototype.
4817
4818 * window.c: Declare Qdelete_window static again. Move down
4819 declaration of select_count.
4820 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4821 (Fother_window): Move to window.el.
4822 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4823 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4824 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4825 window.el.
4826 (replace_buffer_in_windows): Implement by calling
4827 Qreplace_buffer_in_windows.
4828 (replace_buffer_in_all_windows): Remove with some functionality
4829 moved into replace_buffer_in_windows_safely.
4830 (replace_buffer_in_windows_safely): New function.
4831 (select_window_norecord, select_frame_norecord): Move in front
4832 of run_window_configuration_change_hook. Remove now obsolete
4833 declarations.
4834 (Fset_window_buffer): Rewrite doc-string.
4835 Call Qrecord_window_buffer.
4836 (keys_of_window): Move binding for other-window to window.el.
4837
4838 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4839
4840 * dispextern.h (struct image): Replace data member, whose int_val
4841 and ptr_val fields were not used by anything, with a single
4842 lisp_val object.
4843
4844 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4845 (gif_clear_image, gif_load, imagemagick_load_image)
4846 (gs_clear_image, gs_load): Callers changed.
4847
4848 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4849
4850 * buffer.h: Include <time.h>, for time_t.
4851 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4852
4853 Fix minor problems found by static checking.
4854
4855 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4856
4857 Make identifiers static if they are not used in other modules.
4858 * data.c (Qcompiled_function, Qframe, Qvector):
4859 * image.c (QimageMagick, Qsvg):
4860 * minibuf.c (Qmetadata):
4861 * window.c (resize_window_check, resize_root_window): Now static.
4862 * window.h (resize_window_check, resize_root_window): Remove decls.
4863
4864 * window.c (window_deletion_count, delete_deletable_window):
4865 Remove; unused.
4866 (window_body_lines): Now static.
4867 (Fdelete_other_windows_internal): Mark vars as initialized.
4868 Make sure 'resize_failed' is initialized.
4869 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4870 (resize_window_apply): Remove unused local.
4871 * window.h (delete_deletable_window): Remove decl.
4872
4873 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4874 (imagemagick_load_image): Fix pointer signedness problem by changing
4875 last arg from unsigned char * to char *. All uses changed.
4876 Also, fix a local for similar reasons.
4877 Remove unused locals. Remove locals to avoid shadowing.
4878 (fn_rsvg_handle_free): Remove; unused.
4879 (svg_load, svg_load_image): Fix pointer signedness problem.
4880 (imagemagick_load_image): Don't use garbage pointer image_wand.
4881
4882 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4883
4884 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
4885
4886 * image.c (gif_load): Fix omitted cast error introduced by
4887 2011-06-06 change.
4888
4889 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4890
4891 * window.h (resize_proportionally, orig_total_lines)
4892 (orig_top_line): Remove from window structure.
4893 (set_window_height, set_window_width, change_window_heights)
4894 (Fdelete_window): Remove prototypes.
4895 (resize_frame_windows): Remove duplicate declaration.
4896
4897 2011-06-10 Eli Zaretskii <eliz@gnu.org>
4898
4899 * window.h (resize_frame_windows, resize_window_check)
4900 (delete_deletable_window, resize_root_window)
4901 (resize_frame_windows): Declare prototypes.
4902
4903 * window.c (resize_window_apply): Make definition be "static" to
4904 match the prototype.
4905
4906 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4907
4908 * window.c: Remove declarations of Qwindow_size_fixed,
4909 window_min_size_1, window_min_size_2, window_min_size,
4910 size_window, window_fixed_size_p, enlarge_window, delete_window.
4911 Remove static from declaration of Qdelete_window, it's
4912 temporarily needed by Fbury_buffer.
4913 (replace_window): Don't assign orig_top_line and
4914 orig_total_lines.
4915 (Fdelete_window, delete_window): Remove. Window deletion is
4916 handled by window.el.
4917 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4918 Replace Fdelete_window calls with calls to Qdelete_window.
4919 (Fdelete_other_windows): Remove. Deleting other windows is
4920 handled by window.el.
4921 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4922 handled in window.el.
4923 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4924 Window minimum sizes are handled in window.el.
4925 (shrink_windows, size_window, set_window_height)
4926 (set_window_width, change_window_heights, window_height)
4927 (window_width, CURBEG, CURSIZE, enlarge_window)
4928 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4929 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4930 handled in window.el.
4931 (make_dummy_parent): Rename to make_parent_window and give it a
4932 second argument horflag.
4933 (make_window): Don't set resize_proportionally any more.
4934 (Fsplit_window): Remove. Windows are split in window.el.
4935 (save_restore_action, save_restore_orig_size)
4936 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4937 Resize mini windows in window.el.
4938 (grow_mini_window, shrink_mini_window): Implement by calling
4939 Qresize_root_window_vertically, resize_window_check and
4940 resize_window_apply.
4941 (saved_window, Fset_window_configuration, save_window_save):
4942 Do not handle orig_top_line, orig_total_lines, and
4943 resize_proportionally.
4944 (window_min_height, window_min_width): Move to window.el.
4945 (keys_of_window): Move bindings for delete-other-windows,
4946 split-window, delete-window and enlarge-window to window.el.
4947
4948 * buffer.c: Temporarily extern Qdelete_window.
4949 (Fbury_buffer): Temporarily call Qdelete_window instead of
4950 Fdelete_window (Fbury_buffer will move to window.el soon).
4951
4952 * frame.c (set_menu_bar_lines_1): Remove code handling
4953 orig_top_line and orig_total_lines.
4954
4955 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4956 set_window_height but set heights directly.
4957 (change_frame_size_1): Use resize_frame_windows.
4958
4959 * xdisp.c (init_xdisp): Don't use set_window_height but set
4960 heights directly.
4961
4962 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4963 Use resize_frame_windows instead of change_window_heights and run
4964 run_window_configuration_change_hook.
4965
4966 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4967 instead of change_window_heights and run
4968 run_window_configuration_change_hook.
4969
4970 2011-06-09 Martin Rudalics <rudalics@gmx.at>
4971
4972 * window.c (replace_window): Rename second argument REPLACEMENT to
4973 NEW. New third argument SETFLAG. Rewrite.
4974 (delete_window, make_dummy_parent): Call replace_window with
4975 third argument 1.
4976 (window_list_1): Move down in code.
4977 (run_window_configuration_change_hook): Move set_buffer part
4978 before select_frame_norecord part in order to unwind correctly.
4979 Rename count1 to count.
4980 (recombine_windows, delete_deletable_window, resize_root_window)
4981 (Fdelete_other_windows_internal)
4982 (Frun_window_configuration_change_hook, make_parent_window)
4983 (resize_window_check, resize_window_apply, Fresize_window_apply)
4984 (resize_frame_windows, Fsplit_window_internal)
4985 (Fdelete_window_internal, Fresize_mini_window_internal):
4986 New functions.
4987 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4988
4989 2011-06-08 Martin Rudalics <rudalics@gmx.at>
4990
4991 * window.h (window): Add some new members to window structure -
4992 normal_lines, normal_cols, new_total, new_normal, clone_number,
4993 splits, nest, prev_buffers, next_buffers.
4994 (WINDOW_TOTAL_SIZE): Move here from window.c.
4995 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
4996
4997 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4998 Remove.
4999 (make_dummy_parent): Set new members of windows structure.
5000 (make_window): Move down in code. Handle new members of window
5001 structure.
5002 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5003 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5004 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5005 (Fset_window_prev_buffers, Fwindow_next_buffers)
5006 (Fset_window_next_buffers, Fset_window_clone_number):
5007 New functions.
5008 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5009 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5010 Doc-string fixes.
5011 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5012 Argument WINDOW can be now internal window too.
5013 (Fwindow_use_time): Move up in code.
5014 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5015 Rewrite doc-string.
5016 (Fset_window_configuration, saved_window)
5017 (Fcurrent_window_configuration, save_window_save): Handle new
5018 members of window structure.
5019 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5020 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5021 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5022 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5023 Qget_mru_window, Qresize_root_window,
5024 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5025 Qauto_buffer_name; staticpro them.
5026
5027 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5028
5029 * window.c (Fwindow_total_size, Fwindow_left_column)
5030 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5031 (Fwindow_list_1): New functions.
5032 (window_box_text_cols): Replace with window_body_cols.
5033 (Fwindow_width, Fscroll_left, Fscroll_right):
5034 Use window_body_cols instead of window_box_text_cols.
5035 (delete_window, Fset_window_configuration):
5036 Call delete_all_subwindows with window as argument.
5037 (delete_all_subwindows): Take a window as argument and not a
5038 structure. Rewrite.
5039 (window_loop): Remove handling of GET_LRU_WINDOW and
5040 GET_LARGEST_WINDOW.
5041 (Fget_lru_window, Fget_largest_window): Move to window.el.
5042
5043 * window.h: Extern window_body_cols instead of
5044 window_box_text_cols. delete_all_subwindows now takes a
5045 Lisp_Object as argument.
5046
5047 * indent.c (compute_motion, Fcompute_motion):
5048 Use window_body_cols instead of window_box_text_cols.
5049
5050 * frame.c (delete_frame): Call delete_all_subwindows with root
5051 window as argument.
5052
5053 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5054
5055 * fns.c (Fputhash): Document return value.
5056
5057 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5058
5059 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5060
5061 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5062
5063 Cons<->int and similar integer overflow fixes (Bug#8794).
5064
5065 Check for overflow when converting integer to cons and back.
5066 * charset.c (Fdefine_charset_internal, Fdecode_char):
5067 Use cons_to_unsigned to catch overflow.
5068 (Fencode_char): Use INTEGER_TO_CONS.
5069 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5070 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5071 * data.c (long_to_cons, cons_to_long): Remove.
5072 (cons_to_unsigned, cons_to_signed): New functions.
5073 These signal an error for invalid or out-of-range values.
5074 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5075 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5076 * font.c (Ffont_variation_glyphs):
5077 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5078 * lisp.h: Include <intprops.h>.
5079 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5080 (cons_to_signed, cons_to_unsigned): New decls.
5081 (long_to_cons, cons_to_long): Remove decls.
5082 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5083 (Fprimitive_undo): Use CONS_TO_INTEGER.
5084 * xfns.c (Fx_window_property): Likewise.
5085 * xselect.c: Include <limits.h>.
5086 (x_own_selection, selection_data_to_lisp_data):
5087 Use INTEGER_TO_CONS.
5088 (x_handle_selection_request, x_handle_selection_clear)
5089 (x_get_foreign_selection, Fx_disown_selection_internal)
5090 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5091 (lisp_data_to_selection_data): Use cons_to_unsigned.
5092 (x_fill_property_data): Use cons_to_signed.
5093 Report values out of range.
5094
5095 Check for buffer and string overflow more precisely.
5096 * buffer.h (BUF_BYTES_MAX): New macro.
5097 * lisp.h (STRING_BYTES_MAX): New macro.
5098 * alloc.c (Fmake_string):
5099 * character.c (string_escape_byte8):
5100 * coding.c (coding_alloc_by_realloc):
5101 * doprnt.c (doprnt):
5102 * editfns.c (Fformat):
5103 * eval.c (verror):
5104 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5105 since they may not be the same number.
5106 * editfns.c (Finsert_char):
5107 * fileio.c (Finsert_file_contents):
5108 Likewise for BUF_BYTES_MAX.
5109
5110 * image.c: Use ptrdiff_t, not int, for sizes.
5111 (slurp_file): Switch from int to ptrdiff_t.
5112 All uses changed.
5113 (slurp_file): Check that file size fits in both size_t (for
5114 malloc) and ptrdiff_t (for sanity and safety).
5115
5116 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5117 if b->modtime has its maximal value.
5118
5119 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5120
5121 Don't assume time_t can fit into int.
5122 * buffer.h (struct buffer.modtime): Now time_t, not int.
5123 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5124 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5125
5126 Minor fixes for signed vs unsigned integers.
5127 * character.h (MAYBE_UNIFY_CHAR):
5128 * charset.c (maybe_unify_char):
5129 * keyboard.c (read_char, reorder_modifiers):
5130 XINT -> XFASTINT, since the integer must be nonnegative.
5131 * ftfont.c (ftfont_spec_pattern):
5132 * keymap.c (access_keymap, silly_event_symbol_error):
5133 XUINT -> XFASTINT, since the integer must be nonnegative.
5134 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5135 since it makes no difference and we prefer signed.
5136 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5137 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5138 nonnegative.
5139
5140 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5141
5142 * window.h (Fwindow_frame): Declare.
5143
5144 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5145
5146 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5147 (SPARE_MEMORY): Always define.
5148 (LARGE_REQUEST): Remove.
5149 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5150
5151 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5152
5153 * lisp.h: Move EXFUNS for Fframe_root_window,
5154 Fframe_first_window and Fset_frame_selected_window to window.h.
5155
5156 * window.h: Move EXFUNS for Fframe_root_window,
5157 Fframe_first_window and Fset_frame_selected_window here from
5158 lisp.h.
5159
5160 * frame.c (Fwindow_frame, Fframe_first_window)
5161 (Fframe_root_window, Fframe_selected_window)
5162 (Fset_frame_selected_window): Move to window.c.
5163 (Factive_minibuffer_window): Move to minibuf.c.
5164 (Fother_visible_frames_p): New function.
5165
5166 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5167
5168 * window.c (decode_window, decode_any_window): Move up in code.
5169 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5170 (inhibit_frame_unsplittable): Remove unused variable.
5171 (Fwindow_buffer): Move up and rewrite doc-string.
5172 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5173 (Fwindow_prev): New functions.
5174 (Fwindow_frame): Move here from frame.c. Accept any window as
5175 argument.
5176 (Fframe_root_window, Fframe_first_window)
5177 (Fframe_selected_window): Move here from frame.c. Accept frame
5178 or arbitrary window as argument. Update doc-strings.
5179 (Fminibuffer_window): Move up in code.
5180 (Fwindow_minibuffer_p): Move up in code and simplify.
5181 (Fset_frame_selected_window): Move here from frame.c.
5182 Marginal rewrite.
5183 (Fselected_window, select_window, Fselect_window): Move up in
5184 code. Minor doc-string fixes.
5185
5186 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5187
5188 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5189 Do not assume that spare memory exists; that assumption is valid
5190 only if SYSTEM_MALLOC.
5191 (LARGE_REQUEST): New macro, so that the issue of large requests
5192 is separated from the issue of spare memory.
5193
5194 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5195
5196 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5197 format. (Bug#8806)
5198
5199 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5200
5201 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5202 before statements.
5203
5204 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5205
5206 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5207
5208 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5209
5210 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5211 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5212
5213 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5214
5215 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5216
5217 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5218
5219 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5220 (x_clipboard_manager_save): Add return value.
5221 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5222 New error handlers.
5223 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5224 Obey Vx_select_enable_clipboard_manager. Catch errors in
5225 x_clipboard_manager_save (Bug#8779).
5226 (Vx_select_enable_clipboard_manager): New variable.
5227 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5228
5229 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5230
5231 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5232
5233 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5234
5235 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5236 in the current matrix if keep_current_p is non-zero.
5237
5238 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5239
5240 * bidi.c (bidi_level_of_next_char): Fix last change.
5241
5242 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5243
5244 Support bidi reordering of text covered by display properties.
5245
5246 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5247 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5248 (bidi_cache_search, bidi_cache_iterator_state)
5249 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5250 (bidi_level_of_next_char, bidi_move_to_visually_next):
5251 Support character positions inside a run of characters covered by a
5252 display string.
5253 (bidi_paragraph_init, bidi_resolve_explicit_1)
5254 (bidi_level_of_next_char): Call bidi_fetch_char and
5255 bidi_fetch_char_advance instead of FETCH_CHAR and
5256 FETCH_CHAR_ADVANCE.
5257 (bidi_init_it): Initialize new members.
5258 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5259 definitions.
5260 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5261 instead of using explicit *_CHAR codes.
5262 (bidi_resolve_explicit, bidi_resolve_weak):
5263 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5264 bidirectional text is supported only in multibyte buffers.
5265 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5266 it to initialize the frame_window_p member of struct bidi_it.
5267 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5268 (bidi_resolve_explicit, bidi_resolve_weak)
5269 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5270 bidi_it->nchars is non-positive.
5271 (bidi_level_of_next_char): Don't try to lookup the cache for the
5272 next/previous character if nothing is cached there yet, or if we
5273 were just reseat()'ed to a new position.
5274
5275 * xdisp.c (set_cursor_from_row): Set start and stop points
5276 according to the row's direction when priming the loop that looks
5277 for the glyph on which to display cursor.
5278 (single_display_spec_intangible_p): Function deleted.
5279 (display_prop_intangible_p): Reimplement to call
5280 handle_display_spec instead of single_display_spec_intangible_p.
5281 Accept 3 additional arguments needed by handle_display_spec.
5282 This fixes incorrect cursor motion across display property with complex
5283 values: lists, `(when COND...)' forms, etc.
5284 (single_display_spec_string_p): Support property values that are
5285 lists with the argument STRING its top-level element.
5286 (display_prop_string_p): Fix the condition for processing a
5287 property that is a list to be consistent with handle_display_spec.
5288 (handle_display_spec): New function, refactored from the
5289 last portion of handle_display_prop.
5290 (compute_display_string_pos): Accept additional argument
5291 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5292 value of a `display' property is a "replacing spec".
5293 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5294 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5295 the display property, but just return a value indicating whether
5296 the display property will replace the characters it covers.
5297 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5298 frame_window_p members of struct bidi_it.
5299 (compute_display_string_pos, compute_display_string_end):
5300 New functions.
5301 (push_it): Accept second argument POSITION, where pop_it should
5302 jump to continue iteration.
5303 (reseat_1): Initialize bidi_it.disp_pos.
5304
5305 * keyboard.c (adjust_point_for_property): Adjust the call to
5306 display_prop_intangible_p to its new signature.
5307
5308 * dispextern.h (struct bidi_it): New member frame_window_p.
5309 (bidi_init_it): Update prototypes.
5310 (display_prop_intangible_p): Update prototype.
5311 (compute_display_string_pos, compute_display_string_end):
5312 Declare prototypes.
5313 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5314 EMACS_INT.
5315
5316 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5317
5318 Malloc failure behavior now depends on size of allocation.
5319 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5320 * lisp.h: Change signatures accordingly.
5321 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5322 All callers changed. (Bug#8762)
5323
5324 * gnutls.c: Use Emacs's memory allocators.
5325 Without this change, the gnutls library would invoke malloc etc.
5326 directly, which causes problems on non-SYNC_INPUT hosts, and which
5327 runs afoul of improving memory_full behavior. (Bug#8761)
5328 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5329 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5330 xfree instead of the default malloc, realloc, free.
5331 (Fgnutls_boot): No need to check for memory allocation failure,
5332 since xmalloc does that for us.
5333
5334 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5335 * category.c (hash_get_category_set):
5336 * ccl.c (ccl_driver):
5337 * charset.c (Fdefine_charset_internal):
5338 * charset.h (struct charset.hash_index):
5339 * composite.c (get_composition_id, gstring_lookup_cache)
5340 (composition_gstring_put_cache):
5341 * composite.h (struct composition.hash_index):
5342 * dispextern.h (struct image.hash):
5343 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5344 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5345 (hashfn_equal, hashfn_user_defined, make_hash_table)
5346 (maybe_resize_hash_table, hash_lookup, hash_put)
5347 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5348 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5349 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5350 * image.c (make_image, search_image_cache, lookup_image)
5351 (xpm_put_color_table_h):
5352 * lisp.h (struct Lisp_Hash_Table):
5353 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5354 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5355 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5356 * alloc.c (allocate_vectorlike):
5357 Check for overflow in vector size calculations.
5358 * ccl.c (ccl_driver):
5359 Check for overflow when converting EMACS_INT to int.
5360 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5361 need to be updated by these changes.
5362 * fns.c (make_hash_table, maybe_resize_hash_table):
5363 Check for integer overflow with large hash tables.
5364 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5365 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5366 (SXHASH_REDUCE): New macro.
5367 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5368 Use it instead of discarding useful hash info with large hash values.
5369 (sxhash_float): New function.
5370 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5371 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5372 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5373 Rewrite to use FIXNUM_BITS, as this simplifies things.
5374 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5375 Adjust signatures to match updated version of code.
5376 (consing_since_gc): Now EMACS_INT, since a single hash table can
5377 use more than INT_MAX bytes.
5378
5379 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5380
5381 Make it possible to build with GCC-4.6+ -O2 -flto.
5382
5383 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5384
5385 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5386
5387 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5388 Call minibuffer-inactive-mode.
5389
5390 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5391
5392 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5393 Update dependencies.
5394
5395 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5396
5397 * data.c (init_data): Remove code for UTS, this system is not
5398 supported anymore.
5399
5400 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5401
5402 Don't force ./temacs to start in terminal mode.
5403
5404 * frame.c (make_initial_frame): Initialize faces in all cases, not
5405 only when CANNOT_DUMP is defined.
5406 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5407
5408 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5409
5410 * dispnew.c (add_window_display_history): Use const for the string
5411 pointer. Remove declaration, not needed.
5412
5413 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5414
5415 Use 'inline', not 'INLINE'.
5416 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5417 * alloc.c, fontset.c (INLINE): Remove.
5418 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5419 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5420 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5421 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5422 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5423
5424 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5425
5426 Make it possible to run ./temacs.
5427
5428 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5429 syms_of_callproc does the same thing. Remove test for
5430 "initialized", do it in the caller.
5431 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5432
5433 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5434
5435 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5436 (read_minibuf): Use get_minibuffer.
5437 (syms_of_minibuf): Use DEFSYM.
5438 (Qmetadata): New var.
5439 * data.c (Qbuffer): Don't make it static.
5440 (syms_of_data): Use DEFSYM.
5441
5442 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5443
5444 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5445 (CCL_CODE_MIN): New macro.
5446
5447 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5448
5449 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5450
5451 * eval.c (Qdebug): Now static.
5452 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5453 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5454 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5455
5456 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5457
5458 * image.c: Various fixes to ImageMagick code comments.
5459 (Fimagemagick_types): Doc fix.
5460
5461 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5462
5463 Minor fixes prompted by GCC 4.6.0 warnings.
5464
5465 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5466
5467 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5468 (x_clipboard_manager_save_all): Move extern decl to ...
5469 * xterm.h: ... here, so that it can be checked for consistency.
5470
5471 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5472
5473 * xselect.c (x_clipboard_manager_save_frame)
5474 (x_clipboard_manager_save_all): New functions.
5475 (Fx_clipboard_manager_save): Lisp function deleted.
5476
5477 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5478 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5479
5480 * xterm.h: Update prototype.
5481
5482 2011-05-28 William Xu <william.xwl@gmail.com>
5483
5484 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5485 exiting (Bug#8239).
5486
5487 2011-05-28 Jim Meyering <meyering@redhat.com>
5488
5489 Avoid a sign-extension bug in crypto_hash_function.
5490 * fns.c (to_uchar): Define.
5491 (crypto_hash_function): Use it to convert some newly-signed
5492 variables to unsigned, to avoid sign-extension bugs. For example,
5493 without this change, (md5 "truc") would evaluate to
5494 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5495 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5496 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5497
5498 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5499
5500 Integer overflow fixes.
5501
5502 * dbusbind.c: Serial number integer overflow fixes.
5503 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5504 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5505 to hold a serial number that is too large for a fixnum.
5506 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5507 Check for serial numbers out of range. Decode any serial number
5508 that was so large that it became a float. (Bug#8722)
5509
5510 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5511 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5512 Use XFASTINT rather than XUINT when numbers are nonnegative.
5513 (xd_append_arg, Fdbus_method_return_internal):
5514 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5515 arguments, check that Lisp number is nonnegative, rather than
5516 silently wrapping negative numbers around. (Bug#8722)
5517 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5518 (Bug#8722)
5519
5520 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5521
5522 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5523
5524 ccl: add integer overflow checks
5525 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5526 (IN_INT_RANGE): New macros.
5527 (ccl_driver): Use them to check for integer overflow when
5528 decoding a CCL program. Many of the new checks are whether XINT (x)
5529 fits in int; it doesn't always, on 64-bit hosts. The new version
5530 doesn't catch all possible integer overflows, but it's an
5531 improvement. (Bug#8719)
5532
5533 * alloc.c (make_event_array): Use XINT, not XUINT.
5534 There's no need for unsigned here.
5535
5536 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5537 This follows up to the 2011-05-06 change that substituted uintptr_t
5538 for EMACS_INT. This case wasn't caught back then.
5539
5540 Rework Fformat to avoid integer overflow issues.
5541 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5542 now (part of C89). Include <verify.h>.
5543 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5544 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5545 (Fformat): Avoid the prepass trying to compute sizes; it was only
5546 approximate and thus did not catch overflow reliably. Instead, walk
5547 through the format just once, formatting and computing sizes as we go,
5548 checking for integer overflow at every step, and allocating a larger
5549 buffer as needed. Keep track separately whether the format is
5550 multibyte. Keep only the most-recently calculated precision, rather
5551 than them all. Record whether each argument has been converted to
5552 string. Use EMACS_INT, not int, for byte and char and arg counts.
5553 Support field widths and precisions larger than INT_MAX. Avoid
5554 sprintf's undefined behavior with conversion specifications such as %#d
5555 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5556 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5557 formatting out-of-range floating point numbers with int
5558 formats. (Bug#8668)
5559
5560 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5561
5562 * data.c: Avoid integer truncation in expressions involving floats.
5563 * data.c: Include <intprops.h>.
5564 (arith_driver): When there's an integer overflow in an expression
5565 involving floating point, convert the integers to floating point
5566 so that the resulting value does not suffer from catastrophic
5567 integer truncation. For example, on a 64-bit host (* 4
5568 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5569 Do not rely on undefined behavior after integer overflow.
5570
5571 merge count_size_as_multibyte, parse_str_to_multibyte
5572 * character.c, character.h (count_size_as_multibyte):
5573 Rename from parse_str_to_multibyte; all uses changed.
5574 Check for integer overflow.
5575 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5576 since it's now a duplicate of the other. This is more of
5577 a character than a buffer op, so better that it's in character.c.
5578 * fns.c, print.c: Adjust to above changes.
5579
5580 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5581
5582 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5583
5584 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5585
5586 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5587 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5588 (x_clipboard_manager_save): Now static.
5589 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5590
5591 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5592 (crypto_hash_function): Now static.
5593 Fix pointer signedness problems. Avoid unnecessary initializations.
5594
5595 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5596
5597 * termhooks.h (Vselection_alist): Make it terminal-local.
5598
5599 * terminal.c (create_terminal): Initialize it.
5600
5601 * xselect.c: Support for clipboard managers.
5602 (Vselection_alist): Move to termhooks.h as terminal-local var.
5603 (LOCAL_SELECTION): New macro.
5604 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5605 (symbol_to_x_atom): Remove gratuitous arg.
5606 (x_handle_selection_request, lisp_data_to_selection_data)
5607 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5608 (x_own_selection, x_get_local_selection, x_convert_selection):
5609 New arg, specifying work frame. Use terminal-local Vselection_alist.
5610 (some_frame_on_display): Delete unused function.
5611 (Fx_own_selection_internal, Fx_get_selection_internal)
5612 (Fx_disown_selection_internal, Fx_selection_owner_p)
5613 (Fx_selection_exists_p): New optional frame arg.
5614 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5615 (x_handle_selection_clear): Don't treat other terminals with the
5616 same keyboard specially. Use the terminal-local Vselection_alist.
5617 (x_clear_frame_selections): Use Frun_hook_with_args.
5618
5619 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5620
5621 * xterm.h: Add support for those atoms.
5622
5623 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5624
5625 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5626 (converted_selections, conversion_fail_tag): New global variables.
5627 (x_selection_request_lisp_error): Free the above.
5628 (x_get_local_selection): Remove unnecessary code.
5629 (x_reply_selection_request): Args changed; handle arbitrary array
5630 of converted selections stored in converted_selections.
5631 Separate the XChangeProperty and SelectionNotify steps.
5632 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5633 (x_convert_selection): New function.
5634 (x_handle_selection_event): Simplify.
5635 (x_get_foreign_selection): Don't ignore incoming requests while
5636 waiting for an answer; this will fail when we implement
5637 SAVE_TARGETS, and seems unnecessary anyway.
5638 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5639 (Vx_sent_selection_functions): Doc fix.
5640
5641 2011-05-26 Leo Liu <sdl.web@gmail.com>
5642
5643 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5644
5645 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5646
5647 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5648
5649 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5650 for fringe update if it has periodic bitmap.
5651 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5652 and fringe_bitmap_periodic_p.
5653
5654 * fringe.c (get_fringe_bitmap_data): New function.
5655 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5656 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5657 row. Mark glyph row for fringe update if periodicity changed.
5658
5659 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5660 for fringe update unless it has periodic bitmap.
5661
5662 2011-05-25 Kenichi Handa <handa@m17n.org>
5663
5664 * xdisp.c (get_next_display_element): Set correct it->face_id for
5665 a static composition.
5666
5667 2011-05-24 Leo Liu <sdl.web@gmail.com>
5668
5669 * deps.mk (fns.o):
5670 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5671
5672 * fns.c (crypto_hash_function, Fsha1): New function.
5673 (Fmd5): Use crypto_hash_function.
5674 (syms_of_fns): Add Ssha1.
5675
5676 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5677
5678 * gnutls.c: Remove unused macros.
5679 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5680 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5681 Remove macros that are defined and never used.
5682 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5683
5684 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5685
5686 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5687 (Fx_get_selection_internal): Minor cleanup.
5688 (Fx_own_selection_internal): Rename arguments for consistency with
5689 select.el.
5690
5691 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5692
5693 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5694
5695 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5696
5697 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5698
5699 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5700
5701 * dispnew.c (scrolling_window): Don't exclude the case that the
5702 last enabled row in the desired matrix touches the bottom boundary.
5703
5704 2011-05-21 Glenn Morris <rgm@gnu.org>
5705
5706 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5707 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5708 and add some more files.
5709
5710 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5711
5712 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5713 report_file_error introduced by the change from 2011-05-07.
5714
5715 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5716
5717 * systime.h (Time): Define only if emacs is defined.
5718 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5719 where the include path doesn't have X11/X.h by default. See
5720 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5721
5722 2011-05-20 Kenichi Handa <handa@m17n.org>
5723
5724 * composite.c (find_automatic_composition): Fix previous change.
5725
5726 2011-05-20 Glenn Morris <rgm@gnu.org>
5727
5728 * lisp.mk: New file, split from Makefile.in.
5729 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5730 (shortlisp): Remove.
5731 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5732
5733 2011-05-19 Glenn Morris <rgm@gnu.org>
5734
5735 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5736 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5737 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5738 (lisp): Set the order to that of loadup.el.
5739 (shortlisp): Make it a copy of $lisp.
5740 (SOME_MACHINE_LISP): Remove.
5741 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5742 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5743
5744 2011-05-18 Kenichi Handa <handa@m17n.org>
5745
5746 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5747 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5748 (find_automatic_composition): Mostly rewrite for efficiency.
5749
5750 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5751
5752 * makefile.w32-in: Update dependencies.
5753
5754 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5755
5756 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5757 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5758
5759 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5760
5761 Fix some integer overflow issues, such as string length overflow.
5762
5763 * insdel.c (count_size_as_multibyte): Check for string overflow.
5764
5765 * character.c (lisp_string_width): Check for string overflow.
5766 Use EMACS_INT, not int, for string indexes and lengths; in
5767 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5768 the resulting string length overflows an EMACS_INT; instead,
5769 report a string overflow if no precision given. When checking for
5770 precision exhaustion, use a check that cannot possibly have
5771 integer overflow. (Bug#8675)
5772 * character.h (lisp_string_width): Adjust to new signature.
5773
5774 * alloc.c (string_overflow): New function.
5775 (Fmake_string): Use it. This doesn't change behavior, but saves
5776 a few bytes and will simplify future changes.
5777 * character.c (string_escape_byte8): Likewise.
5778 * lisp.h (string_overflow): New decl.
5779
5780 Fixups, following up to the user-interface timestamp change.
5781 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5782 for UI timestamps, instead of unsigned long.
5783 * msdos.c (mouse_get_pos): Likewise.
5784 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5785 * w32gui.h (Time): Define by including "systime.h" rather than by
5786 declaring it ourselves. (Bug#8664)
5787
5788 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5789 * image.c (clear_image_cache): Likewise.
5790
5791 * term.c (term_mouse_position): Don't assume time_t wraparound.
5792
5793 Be more systematic about user-interface timestamps.
5794 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5795 and sometimes 'EMACS_UINT', to represent these timestamps.
5796 This change causes it to use 'Time' uniformly, as that's what X uses.
5797 This makes the code easier to follow, and makes it easier to catch
5798 integer overflow bugs such as Bug#8664.
5799 * frame.c (Fmouse_position, Fmouse_pixel_position):
5800 Use Time, not unsigned long, for user-interface timestamps.
5801 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5802 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5803 * keyboard.h (last_event_timestamp): Likewise.
5804 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5805 * menu.h (xmenu_show): Likewise.
5806 * term.c (term_mouse_position): Likewise.
5807 * termhooks.h (struct input_event.timestamp): Likewise.
5808 (struct terminal.mouse_position_hook): Likewise.
5809 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5810 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5811 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5812 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5813 what it was before.
5814 * menu.h, termhooks.h: Include "systime.h", for Time.
5815
5816 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5817 Don't assume that the difference between two unsigned long values
5818 can fit into an integer. At this point, we know button_down_time
5819 <= event->timestamp, so the difference must be nonnegative, so
5820 there's no need to cast the result if double-click-time is
5821 nonnegative, as it should be; check that it's nonnegative, just in
5822 case. This bug is triggered when events are more than 2**31 ms
5823 apart (about 25 days). (Bug#8664)
5824
5825 * xselect.c (last_event_timestamp): Remove duplicate decl.
5826 (x_own_selection): Remove needless cast to unsigned long.
5827
5828 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5829 that always fit in int. Use a sentinel instead of a counter, to
5830 avoid a temp and to allay GCC's concerns about possible int overflow.
5831 * frame.h (struct frame): Use int for menu_bar_items_used
5832 instead of EMACS_INT, since it always fits in int.
5833
5834 * menu.c (grow_menu_items): Check for int overflow.
5835
5836 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5837
5838 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5839 Before, the code was not consistent. These values cannot exceed
5840 2**31 - 1 so there's no need to make them unsigned.
5841 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5842 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5843 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5844 as modifiers.
5845 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5846
5847 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5848 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5849 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5850 presumably because the widths might not match.
5851
5852 * window.c (size_window): Avoid needless test at loop start.
5853
5854 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5855
5856 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5857
5858 2011-05-12 Drew Adams <drew.adams@oracle.com>
5859
5860 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5861
5862 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5863
5864 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5865 `width' to `bar_area_x' and `bar_area_width', respectively.
5866 (x_scroll_run): Take account of fringe background extension.
5867
5868 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5869 Rename local vars `left' and `width' to `bar_area_x' and
5870 `bar_area_width', respectively.
5871 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5872 background extension.
5873
5874 2011-05-10 Jim Meyering <meyering@redhat.com>
5875
5876 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5877
5878 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5879
5880 * image.c (Finit_image_library): Return t for built-in image types,
5881 like pbm and xbm. (Bug#8640)
5882
5883 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5884
5885 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5886
5887 2011-05-07 Eli Zaretskii <eliz@gnu.org>
5888
5889 * w32console.c (Fset_screen_color): Doc fix.
5890 (Fget_screen_color): New function.
5891 (syms_of_ntterm): Defsubr it.
5892
5893 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5894 unlink the temporary file if Fcall_process didn't create it in the
5895 first place.
5896 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5897 child process will be redirected to a file specified with `:file'.
5898 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5899 cue to call_process_cleanup not to close that handle.
5900
5901 2011-05-07 Ben Key <bkey76@gmail.com>
5902
5903 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5904 one of two shell specific rules, either bootstrap-temacs-CMD or
5905 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5906 to the previous implementation of the bootstrap-temacs rule.
5907 The bootstrap-temacs-CMD rule is similar to the previous
5908 implementation of the bootstrap-temacs rule except that it
5909 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5910 variable.
5911
5912 These changes, along with some changes to nt/configure.bat,
5913 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5914 earlier fix to add support for --cflags and --ldflags options
5915 that include quotes so that it works whether make uses cmd or
5916 sh as the shell.
5917
5918 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
5919
5920 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5921 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5922 is a constant.
5923 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5924 a string. Handle both cases.
5925 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5926 (Fdbus_register_method): Use Qinvalid_function.
5927
5928 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5929
5930 * makefile.w32-in: Update dependencies.
5931 (LISP_H): Add inttypes.h and stdin.h.
5932 (PROCESS_H): Add unistd.h.
5933
5934 2011-05-06 Eli Zaretskii <eliz@gnu.org>
5935
5936 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5937 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5938
5939 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
5940
5941 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5942
5943 * term.c (vfatal): Remove stray call to va_end.
5944 It's not needed and the C Standard doesn't allow it here anyway.
5945
5946 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5947 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5948
5949 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5950 bytes.
5951
5952 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5953
5954 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5955
5956 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5957
5958 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5959
5960 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5961
5962 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5963 * charset.c (Fdefine_charset_internal): Don't initialize
5964 charset.code_space[15]. The value was garbage, on hosts with
5965 32-bit int (Bug#8600).
5966
5967 * lread.c (read_integer): Be more consistent with string-to-number.
5968 Use string_to_number to do the actual conversion; this avoids
5969 rounding errors and fixes some other screwups. Without this fix,
5970 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5971 (digit_to_number): Move earlier, for benefit of read_integer.
5972 Return -1 if the digit is out of range for the base, -2 if it is
5973 not a digit in any supported base. (Bug#8602)
5974
5975 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5976
5977 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5978 to match comment at start of function. This also removes a
5979 GCC warning about overflow in a 32+64-bit port.
5980
5981 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5982
5983 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5984 Reported by Stefan Monnier in
5985 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
5986 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5987 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
5988
5989 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5990 (EMACS_UINTPTR): Likewise, with uintptr_t.
5991
5992 * lisp.h: Prefer 64-bit EMACS_INT if available.
5993 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5994 on 32-bit hosts that have 64-bit int, so that they can access
5995 large files.
5996 However, temporarily disable this change unless the temporary
5997 symbol WIDE_EMACS_INT is defined.
5998
5999 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6000
6001 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6002 This removes an assumption that EMACS_INT and long are the same
6003 width as pointers. The assumption is true for Emacs porting targets
6004 now, but we want to make other targets possible.
6005 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6006 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6007 In the rest of the code, change types of integers that hold casted
6008 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6009 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6010 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6011 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6012 No need to cast type when ORing.
6013 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6014 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6015 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6016 assume EMACS_INT is the same width as char *.
6017 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6018 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6019 Remove no-longer-needed casts.
6020 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6021 (xg_tool_bar_help_callback, xg_make_tool_item):
6022 Use EMACS_INTPTR to hold an integer
6023 that will be cast to void *; this can avoid a GCC warning
6024 if EMACS_INT is not the same width as void *.
6025 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6026 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6027 (current_message_1, set_message_1):
6028 Use a local to convert to proper width without a cast.
6029 * xmenu.c (dialog_selection_callback): Likewise.
6030
6031 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6032 Also, don't assume VALBITS / RAND_BITS is less than 5,
6033 and don't rely on undefined behavior when shifting a 1 left into
6034 the sign bit.
6035 * lisp.h (get_random): Change signature to match.
6036
6037 * lread.c (hash_string): Use size_t, not int, for hash computation.
6038 Normally we prefer signed values; but hashing is special, because
6039 it's better to use unsigned division on hash table sizes so that
6040 the remainder is nonnegative. Also, size_t is the natural width
6041 for hashing into memory. The previous code used 'int', which doesn't
6042 retain enough info to hash well into very large tables.
6043 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6044
6045 * dbusbind.c: Don't possibly lose pointer info when converting.
6046 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6047 Use XPNTR rather than XHASH, so that the high-order bits of
6048 the pointer aren't lost when converting through void *.
6049
6050 * eval.c (Fautoload): Don't double-shift a pointer.
6051
6052 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6053
6054 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6055
6056 * gnutls.c (DEF_GNUTLS_FN):
6057 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6058
6059 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6060
6061 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6062 marker. (Bug#8610)
6063
6064 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6065
6066 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6067 New version that can reserve upto 2GB of heap space.
6068
6069 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6070
6071 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6072
6073 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6074
6075 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6076 `gnutls_certificate_set_x509_key_file'.
6077
6078 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6079
6080 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6081 Update dependencies.
6082
6083 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6084
6085 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6086 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6087 Remove unused parameter `fildes'.
6088 * process.c (read_process_output, send_process): Don't pass it.
6089
6090 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6091
6092 Fix previous change: the library cache is defined in w32.c.
6093 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6094 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6095
6096 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6097
6098 Implement dynamic loading of GnuTLS on Windows.
6099
6100 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6101 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6102 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6103 Declare.
6104
6105 * gnutls.c (Qgnutls_dll): Define.
6106 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6107 (gnutls_*): Declare function pointers.
6108 (init_gnutls_functions): New function to initialize function pointers.
6109 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6110 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6111 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6112 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6113 (emacs_gnutls_write, emacs_gnutls_read)
6114 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6115 (Fgnutls_available_p): New function.
6116 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6117 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6118 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6119
6120 * image.c: Include w32.h.
6121 (Vimage_type_cache): Delete.
6122 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6123 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6124 (w32_delayed_load): Move to w32.c.
6125
6126 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6127
6128 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6129 (w32_delayed_load): Move from image.c. When loading a library, record
6130 its filename in the :loaded-from property of the library id.
6131 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6132 Initialize and staticpro them.
6133 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6134
6135 * process.c: Include lisp.h before w32.h, not after.
6136 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6137 instead of gnutls_record_check_pending.
6138
6139 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6140
6141 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6142
6143 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6144 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6145 as passed in.
6146
6147 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6148
6149 * xterm.c (x_set_frame_alpha): Do not set property on anything
6150 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6151
6152 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6153
6154 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6155
6156 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6157
6158 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6159 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6160 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6161 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6162 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6163 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6164 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6165 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6166 (Qgnutls_bootprop_callbacks_verify): Make static.
6167
6168 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6169
6170 * callproc.c: Indentation fixup.
6171
6172 * sysdep.c (wait_for_termination_1): Make static.
6173 (wait_for_termination, interruptible_wait_for_termination):
6174 Move after wait_for_termination_1.
6175
6176 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6177
6178 * sysdep.c (interruptible_wait_for_termination): New function
6179 which is like wait_for_termination, but allows keyboard
6180 interruptions.
6181
6182 * callproc.c (Fcall_process): Add (:file "file") as an option for
6183 the STDOUT buffer.
6184 (Fcall_process_region): Ditto.
6185
6186 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6187
6188 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6189 rather than `XVECTOR (FOO)->size'.
6190
6191 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6192 inttypes.h, as a gnulib replacement is used if it not available in
6193 system headers.
6194
6195 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6196
6197 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6198 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6199 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6200
6201 * coding.c (coding_alloc_by_realloc): Error out if destination
6202 will grow beyond MOST_POSITIVE_FIXNUM.
6203 (decode_coding_emacs_mule): Abort if there isn't enough place in
6204 charbuf for the composition carryover bytes. Reserve an extra
6205 space for up to 2 characters produced in a loop.
6206 (decode_coding_iso_2022): Abort if there isn't enough place in
6207 charbuf for the composition carryover bytes.
6208
6209 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6210
6211 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6212 aborting when %lld or %lll format is passed.
6213 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6214 %llo or %llx format is passed. (Bug#8545)
6215
6216 * window.c (window_scroll_line_based): Use a marker instead of
6217 simple variables to record original value of point. (Bug#7952)
6218
6219 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6220 produced by %s or %c overflows available buffer space. (Bug#8545)
6221
6222 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6223
6224 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6225 (SIZE_MAX): Move defn after all includes, as they might #define it.
6226
6227 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6228
6229 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6230
6231 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6232
6233 * keyboard.c (Qdelayed_warnings_hook): Define.
6234 (command_loop_1): Run `delayed-warnings-hook'
6235 if Vdelayed_warnings_list is non-nil.
6236 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6237 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6238
6239 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6240
6241 * doprnt.c (doprnt): Don't return value smaller than the buffer
6242 size if the message was truncated. (Bug#8545).
6243
6244 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6245
6246 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6247 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6248
6249 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6250
6251 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6252
6253 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6254
6255 * makefile.w32-in: Update dependencies.
6256
6257 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6258
6259 Improve `doprnt' and its usage. (Bug#8545)
6260 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6261 `format_end'. Remove support for %l as a conversion specifier.
6262 Don't use xrealloc. Improve diagnostics when the %l size modifier
6263 is used. Update the commentary.
6264
6265 * eval.c (verror): Simplify calculation of size_t.
6266
6267 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6268 messages.
6269
6270 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6271
6272 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6273 change.
6274
6275 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6276
6277 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6278 This makes this file independent of the recent pseudovector change.
6279
6280 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6281
6282 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6283
6284 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6285 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6286 Remove unused local.
6287 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6288
6289 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6290 GCC 4.6.0 optimizes based on type-based alias analysis.
6291 For example, if b is of type struct buffer * and v of type struct
6292 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6293 != &v->size, and therefore "v->size = 1; b->size = 2; return
6294 v->size;" must therefore return 1. This assumption is incorrect
6295 for Emacs, since it type-puns struct Lisp_Vector * with many other
6296 types. To fix this problem, this patch adds a new type struct
6297 vectorlike_header that documents the constraints on layout of vectors
6298 and pseudovectors, and helps optimizing compilers not get fooled
6299 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6300 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6301 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6302 the size member.
6303 (XSETPVECTYPE): Rewrite in terms of new macro.
6304 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6305 This is a bit clearer, and further avoids the possibility of
6306 undesirable aliasing.
6307 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6308 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6309 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6310 since Lisp_Subr is a special case (no "next" field).
6311 (ASIZE): Now uses header.size rather than size.
6312 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6313 to avoid the hassle of writing XVECTOR (foo)->header.size.
6314 (struct vectorlike_header): New type.
6315 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6316 object, to help avoid aliasing.
6317 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6318 (SUBRP): Likewise, since Lisp_Subr is a special case.
6319 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6320 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6321 (struct Lisp_Hash_Table): Combine first two members into a single
6322 struct vectorlike_header member. All uses of "size" and "next" members
6323 changed to be "header.size" and "header.next".
6324 * buffer.h (struct buffer): Likewise.
6325 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6326 * frame.h (struct frame): Likewise.
6327 * process.h (struct Lisp_Process): Likewise.
6328 * termhooks.h (struct terminal): Likewise.
6329 * window.c (struct save_window_data, struct saved_window): Likewise.
6330 * window.h (struct window): Likewise.
6331 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6332 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6333 * buffer.c (init_buffer_once): Likewise.
6334 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6335 special case.
6336 * process.c (Fformat_network_address): Use local var for size,
6337 for brevity.
6338
6339 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6340
6341 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6342 * data.c (atof): Remove decl; no longer used or needed.
6343 (digit_to_number): Move to lread.c.
6344 (Fstring_to_number): Use new string_to_number function, to be
6345 consistent with how the Lisp reader treats infinities and NaNs.
6346 Do not assume that floating-point numbers represent EMACS_INT
6347 without losing information; this is not true on most 64-bit hosts.
6348 Avoid double-rounding errors, by insisting on integers when
6349 parsing non-base-10 numbers, as the documentation specifies.
6350 * lisp.h (string_to_number): New decl, replacing ...
6351 (isfloat_string): Remove.
6352 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6353 (read1): Do not accept +. and -. as integers; this
6354 appears to have been a coding error. Similarly, do not accept
6355 strings like +-1e0 as floating point numbers. Do not report
6356 overflow for integer overflows unless the base is not 10 which
6357 means we have no simple and reliable way to continue.
6358 Break out the floating-point parsing into a new
6359 function string_to_number, so that Fstring_to_number parses
6360 floating point numbers consistently with the Lisp reader.
6361 (digit_to_number): Move here from data.c. Make it static inline.
6362 (E_CHAR, EXP_INT): Remove, replacing with ...
6363 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6364 (string_to_number): New function, replacing isfloat_string.
6365 This function checks for valid syntax and produces the resulting
6366 Lisp float number too. Rework it so that string-to-number
6367 no longer mishandles examples like "1.0e+". Use strtoumax,
6368 so that overflow for non-base-10 numbers is reported only when
6369 there's no portable and simple way to convert to floating point.
6370
6371 * textprop.c (set_text_properties_1): Rewrite for clarity,
6372 and to avoid GCC warning about integer overflow.
6373
6374 * intervals.h (struct interval): Use EMACS_INT for members
6375 where EMACS_UINT might cause problems. See
6376 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6377 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6378 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6379 All uses changed.
6380 (offset_intervals): Tell GCC not to worry about length overflow
6381 when negating a negative length.
6382
6383 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6384 (overrun_check_free): Likewise.
6385
6386 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6387 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6388 word size.
6389
6390 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6391 (gnutls_make_error): Rename local to avoid shadowing.
6392 (gnutls_emacs_global_deinit): ifdef out; not used.
6393 (Fgnutls_boot): Use const for pointer to readonly storage.
6394 Comment out unused local. Fix pointer signedness problems.
6395
6396 * lread.c (openp): Don't stuff size_t into an 'int'.
6397 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6398 about possible signed overflow.
6399
6400 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6401 (GDK_KEY_g): Don't define if already defined.
6402 (xg_prepare_tooltip): Avoid pointer signedness problem.
6403 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6404
6405 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6406 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6407
6408 * xfns.c (Fx_window_property): Simplify a bit,
6409 to make a bit faster and to avoid GCC 4.6.0 warning.
6410 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6411
6412 * fns.c (internal_equal): Don't assume size_t fits in int.
6413
6414 * alloc.c (compact_small_strings): Tighten assertion a little.
6415
6416 Replace pEd with more-general pI, and fix some printf arg casts.
6417 * lisp.h (pI): New macro, generalizing old pEd macro to other
6418 conversion specifiers. For example, use "...%"pI"d..." rather
6419 than "...%"pEd"...".
6420 (pEd): Remove. All uses replaced with similar uses of pI.
6421 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6422 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6423 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6424 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6425 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6426 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6427 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6428 64-bit hosts.
6429 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6430 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6431 * print.c (safe_debug_print, print_object): Likewise.
6432 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6433 to int.
6434 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6435 avoiding the 0 flag, which is not portable.
6436 * process.c (Fmake_network_process): Use pI to avoid cast.
6437 * region-cache.c (pp_cache): Likewise.
6438 * xdisp.c (decode_mode_spec): Likewise.
6439 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6440 behavior on 64-bit hosts with printf arg.
6441 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6442 (x_stop_queuing_selection_requests): Likewise.
6443 (x_get_window_property): Don't truncate byte count to an 'int'
6444 when tracing.
6445
6446 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6447 here, since it parses constructs like leading '-' and spaces,
6448 which are not wanted; and it overflows with large numbers.
6449 Instead, simply match F[0-9]+, which is what is wanted anyway.
6450
6451 * alloc.c: Remove unportable assumptions about struct layout.
6452 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6453 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6454 (allocate_vectorlike, make_pure_vector): Use the new macros,
6455 plus offsetof, to remove unportable assumptions about struct layout.
6456 These assumptions hold on all porting targets that I know of, but
6457 they are not guaranteed, they're easy to remove, and removing them
6458 makes further changes easier.
6459
6460 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6461 This doesn't fix a bug but makes the code clearer.
6462 (string_overrun_cookie): Now const. Use initializers that
6463 don't formally overflow signed char, to avoid warnings.
6464 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6465 can cause Emacs to crash when string overrun checking is enabled.
6466 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6467 multiple of sizeof (EMACS_INT); it need not be, if
6468 alignof(EMACS_INT) < sizeof (EMACS_INT).
6469 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6470
6471 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6472
6473 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6474
6475 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6476
6477 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6478 supposed to be handshaking. (Bug#8556)
6479 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6480
6481 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6482
6483 * lisp.h (Qdebug): List symbol.
6484 * eval.c (Qdebug): Restore global linkage.
6485 * keyboard.c (debug-on-event): New variable.
6486 (handle_user_signal): Break into debugger when debug-on-event
6487 matches the current signal symbol.
6488
6489 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6490
6491 * alloc.c (check_sblock, check_string_bytes)
6492 (check_string_free_list): Convert to standard C.
6493
6494 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6495
6496 * w32.c (emacs_gnutls_push): Fix typo.
6497
6498 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6499
6500 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6501 "cast to pointer from integer of different size".
6502
6503 Improve doprnt and its use in verror. (Bug#8545)
6504 * doprnt.c (doprnt): Document the set of format control sequences
6505 supported by the function. Use SAFE_ALLOCA instead of always
6506 using `alloca'.
6507
6508 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6509 is one byte too soon. Don't use xrealloc; instead xfree and
6510 xmalloc anew.
6511
6512 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6513
6514 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6515 callbacks stage.
6516
6517 * gnutls.c: Renamed global_initialized to
6518 gnutls_global_initialized. Added internals for the
6519 :verify-hostname-error, :verify-error, and :verify-flags
6520 parameters of `gnutls-boot' and documented those parameters in the
6521 docstring. Start callback support.
6522 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6523 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6524 on error. Return error code.
6525 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6526 (emacs_gnutls_read): Likewise.
6527 (Fgnutls_boot): Return handshake error code.
6528 (emacs_gnutls_handle_error): New function.
6529 (wsaerror_to_errno): Likewise.
6530
6531 * w32.h (emacs_gnutls_pull): Add prototype.
6532 (emacs_gnutls_push): Likewise.
6533
6534 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6535 (emacs_gnutls_push): Likewise.
6536
6537 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6538
6539 * process.c (wait_reading_process_output): Check if GnuTLS
6540 buffered some data internally if no FDs are set for TLS
6541 connections.
6542
6543 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6544 (LIBS): Link to USER_LIBS.
6545 ($(BLD)/gnutls.$(0)): New target.
6546
6547 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6548
6549 * xdisp.c (handle_single_display_spec): Rename the
6550 display_replaced_before_p argument into display_replaced_p, to
6551 make it consistent with the commentary. Fix typos in the
6552 commentary.
6553
6554 * textprop.c (syms_of_textprop): Remove dead code.
6555 (copy_text_properties): Delete obsolete commentary about an
6556 interface that was deleted long ago. Fix typos in the description
6557 of arguments.
6558
6559 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6560 to changes in oldXMenu/XMenu.h from 2011-04-16.
6561 <menu_help_message, prev_menu_help_message>: Constify.
6562 (IT_menu_make_room): menu->help_text is now `const char **';
6563 adjust.
6564
6565 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6566 to changes in oldXMenu/XMenu.h from 2011-04-16.
6567 (struct XMenu): Declare `help_text' `const char **'.
6568
6569 * xfaces.c <Qunspecified>: Make extern again.
6570
6571 * syntax.c: Include sys/types.h before including regex.h, as
6572 required by Posix.
6573
6574 * doc.c (get_doc_string): Improve the format passed to `error'.
6575
6576 * doprnt.c (doprnt): Improve commentary.
6577
6578 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6579
6580 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6581 them with etags.
6582
6583 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6584 changes in globals.h immediately force recompilation.
6585 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6586 $(CURDIR)/s/ms-w32.h.
6587 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6588
6589 * character.c (Fchar_direction): Function deleted.
6590 (syms_of_character): Don't defsubr it.
6591 <char-direction-table>: Deleted.
6592
6593 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6594
6595 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6596 * doprnt.c: Include limits.h.
6597 (SIZE_MAX): New macro.
6598 (doprnt): Return a size_t value. 2nd arg is now size_t.
6599 Many local variables are now size_t instead of int or unsigned.
6600 Improve overflow protection. Support `l' modifier for integer
6601 conversions. Support %l conversion. Don't assume an EMACS_INT
6602 argument for integer conversions and for %c.
6603
6604 * lisp.h (doprnt): Restore prototype.
6605
6606 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6607 $(SRC)/character.h.
6608
6609 * Makefile.in (base_obj): Add back doprnt.o.
6610
6611 * deps.mk (doprnt.o): Add back prerequisites.
6612 (callint.o): Depend on character.h.
6613
6614 * eval.c (internal_lisp_condition_case): Include the handler
6615 representation in the error message.
6616 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6617 when breaking from the loop.
6618
6619 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6620
6621 * callint.c (Fcall_interactively): When displaying error message
6622 about invalid control letter, pass the character's codepoint, not
6623 a pointer to its multibyte form. Improve display of the character
6624 in octal and display also its hex code.
6625
6626 * character.c (char_string): Use %x to display the (unsigned)
6627 codepoint of an invalid character, to avoid displaying a bogus
6628 negative value.
6629
6630 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6631 `error', not SYMBOL_NAME itself.
6632
6633 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6634 character arguments to `error'.
6635
6636 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6637 to `error' in error message about FINAL_CHAR argument. Make sure
6638 FINAL_CHAR is a character, and use %c when it is passed as
6639 argument to `error'.
6640
6641 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6642
6643 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6644
6645 * w32.c: Include <time.h>.
6646 (sys_localtime): New function.
6647
6648 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6649
6650 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6651
6652 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6653
6654 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6655
6656 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6657 zombies (Bug#8467).
6658
6659 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6660
6661 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6662 gl_state.e_property when gl_state.object is Qt.
6663
6664 * insdel.c (make_gap_larger): Remove limitation of buffer size
6665 to <= INT_MAX.
6666
6667 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6668
6669 * xdisp.c (lookup_glyphless_char_display)
6670 (produce_glyphless_glyph): Handle cons cell entry in
6671 glyphless-char-display.
6672 (Vglyphless_char_display): Document it.
6673
6674 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6675 glyphless-char-display.
6676
6677 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6678
6679 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6680
6681 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6682
6683 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6684 definition for no-X builds.
6685
6686 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6687
6688 Static checks with GCC 4.6.0 and non-default toolkits.
6689
6690 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6691
6692 * process.c (keyboard_bit_set): Define only if SIGIO.
6693 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6694 (send_process): Repair possible setjmp clobbering.
6695
6696 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6697
6698 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6699
6700 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6701
6702 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6703 Define only if needed.
6704
6705 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6706 by pacifying GCC about it. Maybe it's time to retire it?
6707 * xfaces.c (USG, __TIMEVAL__): Likewise.
6708
6709 * dispextern.h (struct redisplay_interface): Rename param
6710 to avoid shadowing.
6711 * termhooks.h (struct terminal): Likewise.
6712 * xterm.c (xembed_send_message): Likewise.
6713
6714 * insdel.c (make_gap_smaller): Define only if
6715 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6716
6717 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6718 it.
6719
6720 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6721 so that we aren't warned about unused symbols.
6722
6723 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6724
6725 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6726
6727 * xfns.c (x_real_positions): Mark locals as initialized.
6728
6729 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6730
6731 * xterm.c: Fix problems found by static analysis with other toolkits.
6732 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6733 (x_dispatch_event): Declare static if USE_GTK, and
6734 define if USE_GTK || USE_X_TOOLKIT.
6735 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6736 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6737 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6738 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6739
6740 * xmenu.c (menu_help_callback): Pointer type fixes.
6741 Use const pointers when pointing at readonly data. Avoid pointer
6742 signedness clashes.
6743 (FALSE): Remove unused macro.
6744 (update_frame_menubar): Remove unused decl.
6745
6746 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6747
6748 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6749 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6750 (single_menu_item): Rename local to avoid shadowing.
6751
6752 * keyboard.c (make_lispy_event): Remove unused local var.
6753
6754 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6755 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6756
6757 * bitmaps: Change bitmaps from unsigned char back to the X11
6758 compatible char. Avoid the old compiler warnings about
6759 out-of-range initializers by using, for example, '\xab' rather
6760 than 0xab.
6761
6762 * xgselect.c (xgselect_initialize): Check vs interface
6763 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6764
6765 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6766
6767 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6768 to read-only memory.
6769
6770 * fns.c (vector): Remove; this old hack is no longer needed.
6771
6772 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6773 Remove unused var.
6774 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6775
6776 * xrdb.c (x_load_resources): Omit unused local.
6777
6778 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6779 (x_window): Rename locals to avoid shadowing.
6780 (USG): Use the kludged USG macro, to pacify gcc.
6781
6782 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6783 (x_term_init): Remove local to avoid shadowing.
6784
6785 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6786
6787 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6788 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6789
6790 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6791
6792 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6793
6794 Fix regex.c, syntax.c and friends for buffers > 2GB.
6795 * syntax.h (struct gl_state_s): Declare character position members
6796 EMACS_INT.
6797
6798 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6799
6800 * textprop.c (verify_interval_modification, interval_of):
6801 Declare arguments EMACS_INT.
6802
6803 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6804 EMACS_INT.
6805
6806 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6807
6808 * indent.c (Fvertical_motion): Local variable it_start is now
6809 EMACS_INT.
6810
6811 * regex.c (re_match, re_match_2, re_match_2_internal)
6812 (bcmp_translate, regcomp, regexec, print_double_string)
6813 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6814 (re_compile_pattern, re_exec): Declare arguments and local
6815 variables `size_t' and `ssize_t' and return values `regoff_t', as
6816 appropriate.
6817 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6818 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6819 <compile_stack_type>: `size' and `avail' are now `size_t'.
6820
6821 * regex.h <regoff_t>: Use ssize_t, not int.
6822 (re_search, re_search_2, re_match, re_match_2): Arguments that
6823 specify buffer/string position and length are now ssize_t and
6824 size_t. Return type is regoff_t.
6825
6826 2011-04-16 Ben Key <bkey76@gmail.com>
6827
6828 * nsfont.m: Fixed bugs in ns_get_family and
6829 ns_descriptor_to_entity that were caused by using free to
6830 deallocate memory blocks that were allocated by xmalloc (via
6831 xstrdup). This caused Emacs to crash when compiled with
6832 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6833 --enable-checking=xmallocoverrun). xfree is now used to
6834 deallocate these memory blocks.
6835
6836 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6837
6838 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6839
6840 emacs_write: Accept and return EMACS_INT for sizes.
6841 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6842 et seq.
6843 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6844 Accept and return EMACS_INT.
6845 (emacs_gnutls_write): Return the number of bytes written on
6846 partial writes.
6847 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6848 (emacs_read, emacs_write): Remove check for negative size, as the
6849 Emacs source code has been audited now.
6850 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6851 (emacs_read, emacs_write): Use it.
6852 * process.c (send_process): Adjust to the new signatures of
6853 emacs_write and emacs_gnutls_write. Do not attempt to store
6854 a byte offset into an 'int'; it might overflow.
6855 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
6856
6857 * sound.c: Don't assume sizes fit in 'int'.
6858 (struct sound_device.period_size, alsa_period_size):
6859 Return EMACS_INT, not int.
6860 (struct sound_device.write, vox_write, alsa_write):
6861 Accept EMACS_INT, not int.
6862 (wav_play, au_play): Use EMACS_INT to store sizes and to
6863 record read return values.
6864
6865 2011-04-15 Ben Key <bkey76@gmail.com>
6866
6867 * keyboard.c (Qundefined): Don't declare static since it is used
6868 in nsfns.m.
6869 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6870 static since they are used in nsfont.m.
6871
6872 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6873
6874 * process.c (Qprocessp): Don't declare static.
6875 * lisp.h (Qprocessp): Declare again.
6876
6877 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
6878
6879 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6880
6881 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6882
6883 Improve C-level modularity by making more things 'static'.
6884
6885 Don't publish debugger-only interfaces to other modules.
6886 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6887 (verify_bytepos, count_markers): Move decls to the only modules
6888 that need them.
6889 * region-cache.h (pp_cache): Likewise.
6890 * window.h (check_all_windows): Likewise.
6891 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6892
6893 * sysdep.c (croak): Now static, if
6894 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6895 * syssignal.h (croak): Declare only if not static.
6896
6897 * alloc.c (refill_memory_reserve): Now static if
6898 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6899 * lisp.h (refill_memory_reserve): Declare only if not static.
6900
6901 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6902 Define only if USE_LUCID.
6903
6904 * xrdb.c (x_customization_string, x_rm_string): Now static.
6905
6906 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6907 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6908
6909 * xdisp.c (draw_row_with_mouse_face): Now static.
6910 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6911
6912 * window.h (check_all_windows): Mark externally visible.
6913
6914 * window.c (window_deletion_count): Now static.
6915
6916 * undo.c: Make symbols static if they're not exported.
6917 (last_undo_buffer, last_boundary_position, pending_boundary):
6918 Now static.
6919
6920 * textprop.c (interval_insert_behind_hooks): Now static.
6921 (interval_insert_in_front_hooks): Likewise.
6922
6923 * term.c: Make symbols static if they're not exported.
6924 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6925 (max_frame_lines, tty_set_terminal_modes):
6926 (tty_reset_terminal_modes, tty_turn_off_highlight):
6927 (get_tty_terminal): Now static.
6928 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6929 * termhooks.h (term_mouse_moveto): Do not declare if
6930 HAVE_WINDOW_SYSTEM.
6931 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6932 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6933
6934 * sysdep.c: Make symbols static if they're not exported.
6935 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6936 Now static.
6937 (sigprocmask_set, full_mask): Remove; unused.
6938 (wait_debugging): Mark as visible.
6939 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6940 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6941
6942 * syntax.c (syntax_temp): Define only if !__GNUC__.
6943
6944 * sound.c (current_sound_device, current_sound): Now static.
6945
6946 * search.c (searchbufs, searchbuf_head): Now static.
6947
6948 * scroll.c (scroll_cost): Remove; unused.
6949 * dispextern.h (scroll_cost): Remove decl.
6950
6951 * region-cache.h (pp_cache): Mark as externally visible.
6952
6953 * process.c: Make symbols static if they're not exported.
6954 (process_tick, update_tick, create_process, chan_process):
6955 (Vprocess_alist, proc_buffered_char, datagram_access):
6956 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6957 (deactivate_process): Mark defn as static, as well as decl.
6958 * lisp.h (create_process): Remove decl.
6959 * process.h (chan_process, Vprocess_alist): Remove decls.
6960
6961 * print.c: Make symbols static if they're not exported.
6962 (print_depth, new_backquote_output, being_printed, print_buffer):
6963 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6964 (print_interval, print_number_index, initial_stderr_stream):
6965 Now static.
6966 * lisp.h (Fprinc): Remove decl.
6967 (debug_output_compilation_hack): Mark as externally visible.
6968
6969 * sysdep.c (croak): Move decl from here to syssignal.h.
6970 * syssignal.h (croak): Put it here, so the API can be checked when
6971 'croak' is called from dissociate_if_controlling_tty.
6972
6973 * minibuf.c: Make symbols static if they're not exported.
6974 (minibuf_save_list, choose_minibuf_frame): Now static.
6975 * lisp.h (choose_minibuf_frame): Remove decl.
6976
6977 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6978
6979 * lread.c: Make symbols static if they're not exported.
6980 (read_objects, initial_obarray, oblookup_last_bucket_number):
6981 Now static.
6982 (make_symbol): Remove; unused.
6983 * lisp.h (initial_obarray, make_symbol): Remove decls.
6984
6985 * keyboard.c: Make symbols static if they're not exported.
6986 (single_kboard, recent_keys_index, total_keys, recent_keys):
6987 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6988 (this_single_command_key_start, echoing, last_auto_save):
6989 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6990 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6991 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6992 (Vlispy_mouse_stem, double_click_count):
6993 Now static.
6994 (force_auto_save_soon): Define only if SIGDANGER.
6995 (ignore_mouse_drag_p): Now static if
6996 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6997 (print_help): Remove; unused.
6998 (stop_character, last_timer_event): Mark as externally visible.
6999 * keyboard.h (ignore_mouse_drag_p): Declare only if
7000 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7001 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7002 * lisp.h (echoing): Remove decl.
7003 (force_auto_save_soon): Declare only if SIGDANGER.
7004 * xdisp.c (redisplay_window): Simplify code, to make it more
7005 obvious that ignore_mouse_drag_p is not accessed if !defined
7006 USE_GTK && !defined HAVE_NS.
7007
7008 * intervals.c: Make symbols static if they're not exported.
7009 (merge_properties_sticky, merge_interval_right, delete_interval):
7010 Now static.
7011 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7012
7013 * insdel.c: Make symbols static if they're not exported.
7014 However, leave prepare_to_modify_buffer alone. It's never
7015 called from outside this function, but that appears to be a bug.
7016 (combine_after_change_list, combine_after_change_buffer):
7017 (adjust_after_replace, signal_before_change): Now static.
7018 (adjust_after_replace_noundo): Remove; unused.
7019 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7020 (signal_before_change): Remove decls.
7021
7022 * indent.c (val_compute_motion, val_vmotion): Now static.
7023
7024 * image.c: Make symbols static if they're not exported.
7025 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7026 if USE_GTK.
7027 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7028 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7029
7030 * fringe.c (standard_bitmaps): Now static.
7031 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7032
7033 * frame.c: Make symbols static if they're not exported.
7034 (x_report_frame_params, make_terminal_frame): Now static.
7035 (get_frame_param): Now static, unless HAVE_NS.
7036 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7037 (x_get_resource_string): Remove; not used.
7038 * frame.h (make_terminal_frame, x_report_frame_params):
7039 (x_get_resource_string); Remove decls.
7040 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7041 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7042
7043 * font.c, fontset.c: Make symbols static if they're not exported.
7044 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7045 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7046 * font.c (font_close_object): Now static.
7047 * font.h (font_close_object): Remove.
7048 * fontset.c (FONTSET_OBJLIST): Remove.
7049 (free_realized_fontset) #if-0 the body, which does nothing.
7050 (face_suitable_for_char_p): #if-0, as it's never called.
7051 * fontset.h (face_suitable_for_char_p): Remove decl.
7052 * xfaces.c (face_at_string_position):
7053 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7054 since 0 is always ASCII.
7055
7056 * fns.c (weak_hash_tables): Now static.
7057
7058 * fileio.c: Make symbols static if they're not exported.
7059 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7060 (Vwrite_region_annotation_buffers): Now static.
7061
7062 * eval.c: Make symbols static if they're not exported.
7063 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7064 * lisp.h (backtrace_list): Remove decl.
7065
7066 * emacs.c: Make symbols static if they're not exported.
7067 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7068 (fatal_error_code, fatal_error_signal_hook, standard_args):
7069 Now static.
7070 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7071 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7072 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7073 * lisp.h (fatal_error_signal_hook): Remove decl.
7074 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7075
7076 * editfns.c: Move a (normally-unused) function to its only use.
7077 * editfns.c, lisp.h (get_operating_system_release): Remove.
7078 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7079 worth the hassle of breaking this out.
7080
7081 * xterm.c: Make symbols static if they're not exported.
7082 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7083 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7084 (x_destroy_window, x_delete_display):
7085 Now static.
7086 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7087 (x_mouse_leave): Remove; unused.
7088 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7089 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7090 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7091 Remove decls.
7092 (x_mouse_leave): Declare only if WINDOWSNT.
7093 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7094 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7095 USE_X_TOOLKIT.
7096
7097 * ftxfont.c: Make symbols static if they're not exported.
7098 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7099 HAVE_FREETYPE.
7100 * font.h (ftxfont_driver): Likewise.
7101
7102 * xfns.c: Make symbols static if they're not exported.
7103 (x_last_font_name, x_display_info_for_name):
7104 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7105 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7106 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7107 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7108 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7109 (last_show_tip_args): Now static.
7110 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7111 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7112 (x_screen_planes): Remove; unused.
7113 * dispextern.h (x_screen_planes): Remove decl.
7114
7115 * dispnew.c: Make symbols static if they're not exported.
7116 * dispextern.h (redraw_garbaged_frames, scrolling):
7117 (increment_row_positions): Remove.
7118 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7119 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7120 Now static.
7121 (redraw_garbaged_frames): Remove; unused.
7122
7123 * xfaces.c: Make symbols static if they're not exported.
7124 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7125 Remove decls.
7126 * xterm.h (defined_color): Remove decls.
7127 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7128 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7129 (menu_face_changed_default, defined_color, free_realized_face):
7130 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7131 (ascii_face_of_lisp_face): Remove; unused.
7132
7133 * xdisp.c: Make symbols static if they're not exported.
7134 * dispextern.h (scratch_glyph_row, window_box_edges):
7135 (glyph_to_pixel_coords, set_cursor_from_row):
7136 (get_next_display_element, set_iterator_to_next):
7137 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7138 (show_mouse_face): Remove decls
7139 * frame.h (message_buf_print): Likewise.
7140 * lisp.h (pop_message, set_message, check_point_in_composition):
7141 Likewise.
7142 * xterm.h (set_vertical_scroll_bar): Likewise.
7143 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7144 (message_buf_print, scratch_glyph_row, displayed_buffer):
7145 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7146 (get_next_display_element, show_mouse_face, window_box_edges):
7147 (frame_to_window_pixel_xy, check_point_in_composition):
7148 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7149 (glyph_to_pixel_coords): Remove; unused.
7150
7151 * dired.c (file_name_completion): Now static.
7152
7153 * dbusbind.c (xd_in_read_queued_messages): Now static.
7154
7155 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7156 * data.c (circular_list_error): Remove.
7157
7158 * commands.h (last_point_position, last_point_position_buffer):
7159 (last_point_position_window): Remove decls.
7160 * keyboard.c: Make these variables static.
7161
7162 * coding.h (coding, code_convert_region, encode_coding_gap):
7163 Remove decls.
7164 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7165 (iso_code_class, detect_coding, code_convert_region): Now static.
7166 (encode_coding_gap): Remove; unused.
7167
7168 * chartab.c (chartab_chars, chartab_bits): Now static.
7169
7170 * charset.h (charset_iso_8859_1): Remove decl.
7171 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7172 Now static.
7173
7174 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7175 * ccl.c (Vccl_program_table): Now static.
7176 (check_ccl_update): Remove; unused.
7177
7178 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7179 * category.h: ... from here.
7180 * category.c (check_category_table, set_category_set): Now static.
7181
7182 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7183 * lisp.h: Remove these decls.
7184
7185 * buffer.c (buffer_count): Remove unused var.
7186
7187 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7188 so that it's not optimized away.
7189 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7190 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7191 exported only to the debugger.
7192
7193 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7194 * atimer.h (run_all_atimers): Remove; not exported.
7195
7196 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7197 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7198 was inaccessible from Lisp.
7199 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7200 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7201
7202 alloc.c: Import and export fewer symbols, and remove unused items.
7203 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7204 is defined.
7205 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7206 it's not optimized away by whole-program optimization.
7207 (message_enable_multibyte, free_misc): Remove.
7208 (catchlist, handlerlist, mark_backtrace):
7209 Declare only if BYTE_MARK_STACK.
7210 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7211 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7212 (message_enable_multibyte): Remove decl.
7213 (free_misc, interval_free_list, float_block, float_block_index):
7214 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7215 (cons_free_list, last_marked_index):
7216 Now static.
7217 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7218 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7219 (mark_backtrace): Define only if BYTE_MARK_STACK.
7220 * xdisp.c (message_enable_multibyte): Now static.
7221
7222 Declare Lisp_Object Q* variables to be 'static' if not exported.
7223 This makes it easier for human readers (and static analyzers)
7224 to see whether these variables are used from other modules.
7225 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7226 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7227 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7228 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7229 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7230 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7231 * xmenu.c, xselect.c:
7232 Declare Q* vars static if they are not used in other modules.
7233 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7234 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7235 Remove decls of unexported vars.
7236 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7237
7238 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7239
7240 Make Emacs functions such as Fatom 'static' by default.
7241 This makes it easier for human readers (and static analyzers)
7242 to see whether these functions can be called from other modules.
7243 DEFUN now defines a static function. To make the function external
7244 so that it can be used in other C modules, use the new macro DEFUE.
7245 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7246 (Finit_image_library):
7247 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7248 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7249 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7250 Remove decls, since these functions are now static.
7251 (Funintern, Fget_internal_run_time): New decls, since these functions
7252 were already external.
7253
7254 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7255 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7256 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7257 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7258 * keyboard.c, keymap.c, lread.c:
7259 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7260 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7261 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7262 Mark functions with DEFUE instead of DEFUN,
7263 if they are used in other modules.
7264 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7265 decls for now-static functions.
7266 * buffer.h (Fdelete_overlay): Remove decl.
7267 * callproc.c (Fgetenv_internal): Mark as internal.
7268 * composite.c (Fremove_list_of_text_properties): Remove decl.
7269 (Fcomposition_get_gstring): New forward static decl.
7270 * composite.h (Fcomposite_get_gstring): Remove decl.
7271 * dired.c (Ffile_attributes): New forward static decl.
7272 * doc.c (Fdocumntation_property): New forward static decl.
7273 * eval.c (Ffetch_bytecode): New forward static decl.
7274 (Funintern): Remove extern decl; now in .h file where it belongs.
7275 * fileio.c (Fmake_symbolic_link): New forward static decl.
7276 * image.c (Finit_image_library): New forward static decl.
7277 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7278 * intervals.h (Fprevious_property_change):
7279 (Fremove_list_of_text_properties): Remove decls.
7280 * keyboard.c (Fthis_command_keys): Remove decl.
7281 (Fcommand_execute): New forward static decl.
7282 * keymap.c (Flookup_key): New forward static decl.
7283 (Fcopy_keymap): Now static.
7284 * keymap.h (Flookup_key): Remove decl.
7285 * process.c (Fget_process): New forward static decl.
7286 (Fprocess_datagram_address): Mark as internal.
7287 * syntax.c (Fsyntax_table_p): New forward static decl.
7288 (skip_chars): Remove duplicate decl.
7289 * textprop.c (Fprevious_property_change): New forward static decl.
7290 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7291 Now internal.
7292 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7293 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7294
7295 * editfns.c (Fformat): Remove unreachable code.
7296
7297 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7298
7299 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7300 change. (Bug#8496)
7301
7302 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7303
7304 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7305 when at ZV. (Bug#8487)
7306
7307 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7308
7309 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7310 (Bug#8437)
7311 * keyboard.c (parse_tool_bar_item): Likewise.
7312 * sound.c (sound_cleanup, alsa_close): Likewise.
7313 * termcap.c (tgetent): Likewise.
7314 * xfns.c (x_default_font_parameter): Likewise.
7315 * xsettings.c (read_and_apply_settings): Likewise.
7316
7317 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7318 (overrun_check_free): Protoize.
7319
7320 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7321
7322 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7323 since callers should never pass a negative size.
7324 Change the signature to match that of plain 'read' and 'write'; see
7325 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7326 * lisp.h: Update prototypes of emacs_write and emacs_read.
7327
7328 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7329
7330 * xdisp.c (redisplay_window): Don't try to determine the character
7331 position of the scroll margin if the window start point w->startp
7332 is outside the buffer's accessible region. (Bug#8468)
7333
7334 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7335
7336 Fix write-region and its subroutines for buffers > 2GB.
7337 * fileio.c (a_write, e_write): Modify declaration of arguments and
7338 local variables to support buffers larger than 2GB.
7339 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7340
7341 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7342 argument, local variables, and return value.
7343
7344 * lisp.h: Update prototypes of emacs_write and emacs_read.
7345
7346 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7347
7348 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7349
7350 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7351
7352 Fix more problems found by GCC 4.6.0's static checks.
7353
7354 * xdisp.c (vmessage): Use a better test for character truncation.
7355
7356 * charset.c (load_charset_map): <, not <=, for optimization,
7357 and to avoid potential problems with integer overflow.
7358 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7359 * casetab.c (set_identity, shuffle): Likewise.
7360 * editfns.c (Fformat): Likewise.
7361 * syntax.c (skip_chars): Likewise.
7362
7363 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7364 This also lets GCC 4.6.0 generate slightly better loop code.
7365
7366 * callint.c (Fcall_interactively): <, not <=, for optimization.
7367 (Fcall_interactively): Count the number of arguments produced,
7368 not the number of arguments given. This is simpler and lets GCC
7369 4.6.0 generate slightly better code.
7370
7371 * ftfont.c: Distingish more carefully between FcChar8 and char.
7372 The previous code passed unsigned char * to a functions like
7373 strlen and xstrcasecmp that expect char *, which does not
7374 conform to the C standard.
7375 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7376 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7377 char * when the C standard requires it.
7378
7379 * keyboard.c (read_char): Remove unused var.
7380
7381 * eval.c: Port to Windows vsnprintf (Bug#8435).
7382 Include <limits.h>.
7383 (SIZE_MAX): Define if the headers do not.
7384 (verror): Do not give up if vsnprintf returns a negative count.
7385 Instead, grow the buffer. This ports to Windows vsnprintf, which
7386 does not conform to C99. Problem reported by Eli Zaretskii.
7387 Also, simplify the allocation scheme, by avoiding the need for
7388 calling realloc, and removing the ALLOCATED variable.
7389
7390 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7391
7392 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7393 But keep the doprint source code for now, as we might revamp it
7394 and use it again (Bug#8435).
7395 * lisp.h (doprnt): Remove.
7396 * Makefile.in (base_obj): Remove doprnt.o.
7397 * deps.mk (doprnt.o): Remove.
7398
7399 error: Print 32- and 64-bit integers portably (Bug#8435).
7400 Without this change, on typical 64-bit hosts error ("...%d...", N)
7401 was used to print both 32- and 64-bit integers N, which relied on
7402 undefined behavior.
7403 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7404 New macro.
7405 * lisp.h (error, verror): Mark as printf-like functions.
7406 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7407 Report overflow in size calculations when allocating printf buffer.
7408 Do not truncate output string at its first null byte.
7409 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7410 Truncate the output at a character boundary, since vsnprintf does not
7411 do that.
7412 * charset.c (check_iso_charset_parameter): Convert internal
7413 character to string before calling 'error', since %c now has the
7414 printf meaning.
7415 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7416 overflow when computing char to be passed to 'error'. Do not
7417 pass Lisp_Object to 'error'; pass the integer instead.
7418 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7419 formatted with plain %d.
7420
7421 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7422
7423 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7424
7425 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7426
7427 * xterm.c (x_catch_errors): Remove duplicate declaration.
7428
7429 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7430
7431 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7432
7433 2011-04-10 Jim Meyering <meyering@redhat.com>
7434
7435 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7436 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7437 return ssize_t not "int", and use size_t as the buffer length.
7438 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7439 * gnutls.h: Update declarations.
7440 * process.c (read_process_output): Use ssize_t, to match.
7441 (send_process): Likewise.
7442
7443 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7444
7445 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7446
7447 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7448
7449 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7450 Use unsigned char, to match FcChar8 type definition.
7451
7452 * xterm.c (handle_one_xevent):
7453 * xmenu.c (create_and_show_popup_menu):
7454 * xselect.c (x_decline_selection_request)
7455 (x_reply_selection_request): Avoid type-punned deref of X events.
7456
7457 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7458
7459 Fix some uses of `int' instead of EMACS_INT.
7460 * search.c (string_match_1, fast_string_match)
7461 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7462 (scan_buffer, find_next_newline_no_quit)
7463 (find_before_next_newline, search_command, Freplace_match)
7464 (Fmatch_data): Make some `int' variables be EMACS_INT.
7465
7466 * xdisp.c (display_count_lines): 3rd argument and return value now
7467 EMACS_INT. All callers changed.
7468 (pint2hrstr): Last argument is now EMACS_INT.
7469
7470 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7471 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7472 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7473 (decode_coding_utf_16, decode_coding_emacs_mule)
7474 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7475 (decode_coding_ccl, decode_coding_charset)
7476 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7477 (decode_coding_iso_2022, decode_coding_emacs_mule)
7478 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7479 <char_offset, last_offset>: Declare EMACS_INT.
7480 (encode_coding_utf_8, encode_coding_utf_16)
7481 (encode_coding_emacs_mule, encode_invocation_designation)
7482 (encode_designation_at_bol, encode_coding_iso_2022)
7483 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7484 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7485 Declare EMACS_INT.
7486 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7487 (encode_invocation_designation): Last argument P_NCHARS is now
7488 EMACS_INT.
7489 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7490 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7491
7492 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7493 All users changed.
7494
7495 * ccl.c (Fccl_execute_on_string): Declare some variables
7496 EMACS_INT.
7497
7498 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7499
7500 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7501
7502 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7503
7504 * process.c (Fformat_network_address): Doc fix.
7505
7506 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7507
7508 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7509
7510 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7511
7512 * keyboard.c (read_char): Call Lisp function help-form-show,
7513 instead of using internal_with_output_to_temp_buffer.
7514 (Qhelp_form_show): New var.
7515 (syms_of_keyboard): Use DEFSYM macro.
7516
7517 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7518
7519 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7520
7521 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7522
7523 * process.c (Flist_processes): Remove to Lisp.
7524 (list_processes_1): Delete.
7525
7526 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7527
7528 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7529
7530 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7531
7532 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7533
7534 Fix more problems found by GCC 4.6.0's static checks.
7535
7536 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7537
7538 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7539
7540 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7541
7542 * xdisp.c (vmessage): Mark as a printf-like function.
7543
7544 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7545
7546 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7547
7548 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7549 printf-like functions.
7550 (tiff_load): Add casts to remove these marks before passing them
7551 to system-supplied API.
7552
7553 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7554
7555 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7556 This avoids several warnings with gcc -Wstrict-overflow.
7557 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7558 directly, rather than having caller test rule sign. This avoids
7559 some unnecessary tests.
7560 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7561 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7562 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7563
7564 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7565 (xfont_open): Avoid unnecessary tests.
7566
7567 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7568
7569 * composite.h, composite.c (composition_gstring_put_cache):
7570 Use EMACS_INT, not int, for length.
7571
7572 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7573 breaking out part of COMPOSITION_DECODE_RULE.
7574 (COMPOSITION_DECODE_RULE): Use it.
7575 * composite.c (get_composition_id): Remove unused local vars,
7576 by using the new macro.
7577
7578 * textprop.c (set_text_properties_1): Change while to do-while,
7579 since the condition is always true at first.
7580
7581 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7582 (interval_deletion_adjustment): Return unsigned value.
7583 All uses changed.
7584
7585 * process.c (list_processes_1, create_pty, read_process_output):
7586 (exec_sentinel): Remove vars that were set but not used.
7587 (create_pty): Remove unnecessary "volatile"s.
7588 (Fnetwork_interface_info): Avoid possibility of int overflow.
7589 (read_process_output): Do adaptive read buffering even if carryover.
7590 (read_process_output): Simplify nbytes computation if buffered.
7591
7592 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7593
7594 * syntax.c (scan_words): Remove var that was set but not used.
7595 (update_syntax_table): Use unsigned instead of int.
7596
7597 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7598 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7599 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7600
7601 * print.c (print_error_message): Avoid int overflow.
7602
7603 * font.c (font_list_entities): Redo for clarity,
7604 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7605
7606 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7607 (font_score): Avoid potential overflow in diff calculation.
7608
7609 * fns.c (substring_both): Remove var that is set but not used.
7610 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7611
7612 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7613
7614 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7615 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7616 can always succeed if overflow has undefined behavior.
7617
7618 * search.c (boyer_moore, wordify): Remove vars set but not used.
7619 (wordify): Omit three unnecessary tests.
7620
7621 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7622 All callers changed. This avoids the need for an unused var.
7623
7624 * casefiddle.c (casify_region): Remove var that is set but not used.
7625
7626 * dired.c (file_name_completion): Remove var that is set but not used.
7627
7628 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7629
7630 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7631 (Finsert_file_contents): Remove unnecessary code checking fd.
7632
7633 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7634 Check for integer overflow on size calculations.
7635
7636 * buffer.c (Fprevious_overlay_change): Remove var that is set
7637 but not used.
7638
7639 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7640 Remove vars that are set but not used.
7641 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7642 (timer_check_2): Mark vars as initialized.
7643
7644 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7645
7646 * image.c (lookup_image): Remove var that is set but not used.
7647 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7648
7649 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7650 that are set but not used.
7651
7652 * xfns.c (make_invisible_cursor): Don't return garbage
7653 if XCreateBitmapFromData fails (Bug#8410).
7654
7655 * xselect.c (x_get_local_selection, x_handle_property_notify):
7656 Remove vars that are set but not used.
7657
7658 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7659 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7660
7661 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7662 Remove var that is set but not used.
7663 (scroll_bar_windows_size): Now size_t, not int.
7664 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7665 Check for overflow.
7666
7667 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7668 (map_tty_color) [!defined MSDOS]: Likewise.
7669
7670 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7671
7672 * coding.c: Remove vars that are set but not used.
7673 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7674 All callers changed.
7675 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7676 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7677 (decode_coding_charset): Remove vars that are set but not used.
7678
7679 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7680 that is set but not used.
7681
7682 * print.c (print_object): Remove var that is set but not used.
7683
7684 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7685 The gnulib version avoids calling malloc in the usual case,
7686 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7687 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7688 * filelock.c (current_lock_owner): Likewise.
7689 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7690 * sysdep.c: Include allocator.h, careadlinkat.h.
7691 (emacs_no_realloc_allocator): New static constant.
7692 (emacs_readlink): New function.
7693 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7694 ../lib/careadlinkat.h.
7695
7696 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7697
7698 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7699 first non-nil return value).
7700
7701 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7702
7703 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7704 if not defined (Bug#8403).
7705
7706 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7707
7708 * xdisp.c (display_count_lines): Remove parameter `start',
7709 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7710 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7711 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7712 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7713 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7714 and thereabouts. All callers changed.
7715 (get_per_char_metric): Remove parameter `f', unused since
7716 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7717
7718 2011-04-02 Jim Meyering <meyering@redhat.com>
7719
7720 do not dereference NULL upon failed strdup
7721 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7722 (ns_get_family): Likewise.
7723
7724 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7725
7726 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7727
7728 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7729
7730 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7731 later (Bug#8403).
7732
7733 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7734
7735 Add lexical binding.
7736
7737 * window.c (Ftemp_output_buffer_show): New fun.
7738 (Fsave_window_excursion):
7739 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7740
7741 * lread.c (lisp_file_lexically_bound_p): New function.
7742 (Fload): Bind Qlexical_binding.
7743 (readevalloop): Remove `evalfun' arg.
7744 Bind Qinternal_interpreter_environment.
7745 (Feval_buffer): Bind Qlexical_binding.
7746 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7747 Mark as dynamic.
7748 (syms_of_lread): Declare `lexical-binding'.
7749
7750 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7751
7752 * keyboard.c (eval_dyn): New fun.
7753 (menu_item_eval_property): Use it.
7754
7755 * image.c (parse_image_spec): Use Ffunctionp.
7756
7757 * fns.c (concat, mapcar1): Accept byte-code-functions.
7758
7759 * eval.c (Fsetq): Handle lexical vars.
7760 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7761 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7762 (FletX, Flet): Obey lexical binding.
7763 (Fcommandp): Handle closures.
7764 (Feval): New `lexical' arg.
7765 (eval_sub): New function extracted from Feval. Use it almost
7766 everywhere where Feval was used. Look up vars in lexical env.
7767 Handle closures.
7768 (Ffunctionp): Move from subr.el.
7769 (Ffuncall): Handle closures.
7770 (apply_lambda): Remove `eval_flags'.
7771 (funcall_lambda): Handle closures and new byte-code-functions.
7772 (Fspecial_variable_p): New function.
7773 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7774 but without exporting it to Lisp.
7775
7776 * doc.c (Fdocumentation, store_function_docstring):
7777 * data.c (Finteractive_form): Handle closures.
7778
7779 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7780 interactive spec.
7781
7782 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7783 New byte-codes.
7784 (exec_byte_code): New function extracted from Fbyte_code to handle new
7785 calling convention for byte-code-functions. Add new byte-codes.
7786
7787 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7788
7789 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7790
7791 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7792
7793 * xdisp.c (redisplay_internal): Fix prototype.
7794
7795 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7796
7797 * xdisp.c (SCROLL_LIMIT): New macro.
7798 (try_scrolling): Use it when setting scroll_limit.
7799 Limit scrolling to 100 screen lines.
7800 (redisplay_window): Even when falling back on "recentering",
7801 position point in the window according to scroll-conservatively,
7802 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7803
7804 (try_scrolling): When point is above the window, allow searching
7805 as far as scroll_max, or one screenful, to compute vertical
7806 distance from PT to the scroll margin position. This prevents
7807 try_scrolling from unnecessarily failing when
7808 scroll-conservatively is set to a value slightly larger than the
7809 window height. Clean up the case of PT below the margin at bottom
7810 of window: scroll_max can no longer be INT_MAX. When aggressive
7811 scrolling is in use, don't let point enter the opposite scroll
7812 margin as result of the scroll.
7813 (syms_of_xdisp) <scroll-conservatively>: Document the
7814 threshold of 100 lines for never-recentering scrolling.
7815
7816 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7817
7818 * dispextern.h (move_it_by_lines):
7819 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7820 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7821 (message_log_check_duplicate): Remove parameters `prev_bol' and
7822 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7823 (redisplay_internal): Remove parameter `preserve_echo_area',
7824 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7825
7826 * indent.c (Fvertical_motion):
7827 * window.c (window_scroll_pixel_based, Frecenter):
7828 Don't pass `need_y_p' to `move_it_by_lines'.
7829
7830 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7831
7832 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7833 steal a few bits to be more compact.
7834 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7835 Remove unneeded casts.
7836
7837 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7838
7839 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7840
7841 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7842 binding" message (bug#7967).
7843
7844 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7845
7846 Fix more problems found by GCC 4.6.0's static checks.
7847
7848 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7849 Remove unused local var.
7850
7851 * editfns.c (Fmessage_box): Remove unused local var.
7852
7853 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7854 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7855 Omit unused local vars.
7856 * window.c (shrink_windows): Omit unused local var.
7857 * menu.c (digest_single_submenu): Omit unused local var.
7858 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7859 Omit unused local var.
7860
7861 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7862 Don't assume string length fits in int.
7863 (keyremap_step, read_key_sequence): Use size_t for sizes.
7864 (read_key_sequence): Don't check last_real_key_start redundantly.
7865
7866 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7867 instead of alloca (Bug#8344).
7868
7869 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7870 (Fbacktrace_frame): Don't assume nframes fits in int.
7871
7872 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7873
7874 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7875 concerns.
7876
7877 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7878
7879 * cm.c (calccost): Turn while-do into do-while, for clarity.
7880
7881 * keyboard.c (syms_of_keyboard): Use the same style as later
7882 in this function when indexing through an array. This also
7883 works around GCC bug 48267.
7884
7885 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7886
7887 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7888
7889 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7890 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7891
7892 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7893 This avoids undefined behavior on integer overflow, and is a bit
7894 more convenient anyway since it is compared to a size_t variable.
7895
7896 Variadic C functions now count arguments with size_t, not int.
7897 This avoids an unnecessary limitation on 64-bit machines, which
7898 caused (substring ...) to crash on large vectors (Bug#8344).
7899 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7900 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7901 All variadic functions and their callers changed accordingly.
7902 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7903 * data.c (arith_driver, float_arith_driver): Likewise.
7904 * editfns.c (general_insert_function): Likewise.
7905 * eval.c (struct backtrace.nargs, interactive_p)
7906 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7907 (funcall_lambda, mark_backtrace): Likewise.
7908 * fns.c (concat): Likewise.
7909 * frame.c (x_set_frame_parameters): Likewise.
7910 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7911 0 if not found, not -1. All callers changed.
7912
7913 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7914 (stack_copy_size): Now size_t, not int.
7915 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7916
7917 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7918
7919 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7920 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7921 All callers changed.
7922
7923 * lisp.h (multibyte_char_to_unibyte):
7924 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7925 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7926 * character.h (CHAR_TO_BYTE8):
7927 * cmds.c (internal_self_insert):
7928 * editfns.c (general_insert_function):
7929 * keymap.c (push_key_description):
7930 * search.c (Freplace_match):
7931 * xdisp.c (message_dolog, set_message_1): All callers changed.
7932
7933 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7934
7935 * keyboard.c (safe_run_hook_funcall): New function.
7936 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7937 don't set the hook to nil, but remove the offending function instead.
7938 (Qcommand_hook_internal): Remove, unused.
7939 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7940 Vcommand_hook_internal.
7941
7942 * eval.c (enum run_hooks_condition): Remove.
7943 (funcall_nil, funcall_not): New functions.
7944 (run_hook_with_args): Call each function through a `funcall' argument.
7945 Remove `cond' argument, now redundant.
7946 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7947 (Frun_hook_with_args_until_failure): Adjust accordingly.
7948 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7949
7950 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7951
7952 * dispextern.h (string_buffer_position): Remove declaration.
7953
7954 * print.c (strout): Remove parameter `multibyte', unused since
7955 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7956
7957 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7958 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7959 All callers changed.
7960
7961 * w32.c (_wsa_errlist): Use braces for struct initializers.
7962
7963 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7964 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7965 All callers changed.
7966 (string_buffer_position): Likewise. Also, make static (it's never
7967 used outside xdisp.c).
7968 (cursor_row_p): Remove parameter `w', unused since
7969 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7970 (decode_mode_spec): Remove parameter `precision', introduced during
7971 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7972 All callers changed.
7973
7974 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7975
7976 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7977
7978 2011-03-27 Anders Lindgren <andlind@gmail.com>
7979
7980 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7981 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7982 (ns_update_auto_hide_menu_bar): New functions.
7983 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7984 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7985 ns_constrain_all_frames.
7986 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7987 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7988
7989 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7990
7991 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7992
7993 2011-03-27 Glenn Morris <rgm@gnu.org>
7994
7995 * syssignal.h: Replace RETSIGTYPE with void.
7996 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7997 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7998 Replace SIGTYPE with void everywhere.
7999 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8000 * s/template.h (SIGTYPE): Remove commented out definition.
8001
8002 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8003
8004 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8005 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8006
8007 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8008
8009 * w32.c (read_unc_volume): Use parameter `henum', instead of
8010 global variable `wget_enum_handle'.
8011
8012 * keymap.c (describe_vector): Remove parameters `indices' and
8013 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8014 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8015
8016 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8017
8018 * keyboard.c (timer_check): Remove parameter `do_it_now',
8019 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8020 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8021 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8022
8023 * keyboard.c (read_char):
8024 * w32menu.c (w32_menu_display_help):
8025 * xmenu.c (show_help_event, menu_help_callback):
8026 Adjust calls to `show_help_echo'.
8027
8028 * gtkutil.c (xg_maybe_add_timer):
8029 * keyboard.c (readable_events):
8030 * process.c (wait_reading_process_output):
8031 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8032
8033 * insdel.c (adjust_markers_gap_motion):
8034 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8035 (gap_left, gap_right): Don't call it.
8036
8037 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8038
8039 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8040 incurred during fontification.
8041
8042 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8043
8044 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8045 (DEFVAR_PER_BUFFER): Don't pass it.
8046
8047 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8048 (scrolling_window): Don't pass it.
8049
8050 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8051
8052 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8053
8054 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8055 and `suffix'.
8056 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8057 of variables specific to SELinux and computation of `encoded_absname'.
8058
8059 * image.c (XPutPixel): Remove unused variable `height'.
8060
8061 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8062
8063 * unexw32.c (get_section_info): Remove unused variable `section'.
8064
8065 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8066 (system_process_attributes): Remove unused variable `sess'.
8067 (sys_read): Remove unused variable `err'.
8068
8069 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8070 (w32_wnd_proc): Remove unused variable `isdead'.
8071 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8072 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8073 (x_create_tip_frame): Remove unused variable `tem'.
8074
8075 * w32inevt.c (w32_console_read_socket):
8076 Remove unused variable `no_events'.
8077
8078 * w32term.c (x_draw_composite_glyph_string_foreground):
8079 Remove unused variable `width'.
8080
8081 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8082
8083 * w32term.c (x_set_glyph_string_clipping):
8084 Don't pass uninitialized region to CombineRgn.
8085
8086 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8087
8088 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8089 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8090 (Fx_close_connection): Remove unused variable `i'.
8091
8092 * w32font.c (w32font_draw): Return number of glyphs.
8093 (w32font_open_internal): Remove unused variable `i'.
8094 (w32font_driver): Add missing initializer.
8095
8096 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8097 (fill_in_menu): Remove unused variable `items_added'.
8098
8099 * w32term.c (last_mouse_press_frame): Remove static global variable.
8100 (w32_clip_to_row): Remove unused variable `f'.
8101 (x_delete_terminal): Remove unused variable `i'.
8102
8103 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8104 (NOTHING): Remove unused static global variable.
8105 (uniscribe_check_otf): Remove unused variable `table'.
8106 (uniscribe_font_driver): Add missing initializers.
8107
8108 2011-03-23 Julien Danjou <julien@danjou.info>
8109
8110 * term.c (Fsuspend_tty, Fresume_tty):
8111 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8112 * window.c (temp_output_buffer_show):
8113 * insdel.c (signal_before_change):
8114 * frame.c (Fhandle_switch_frame):
8115 * fileio.c (Fdo_auto_save):
8116 * emacs.c (Fkill_emacs):
8117 * editfns.c (save_excursion_restore):
8118 * cmds.c (internal_self_insert):
8119 * callint.c (Fcall_interactively):
8120 * buffer.c (Fkill_all_local_variables):
8121 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8122 Use Frun_hooks.
8123 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8124 unconditionally since it does the check itself.
8125
8126 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8127
8128 Fix more problems found by GCC 4.5.2's static checks.
8129
8130 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8131 the first time through the loop, since we know p0 < p1 then.
8132 This also avoids a gcc -Wstrict-overflow warning.
8133
8134 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8135 leading to a memory leak, possible in functions like
8136 load_charset_map_from_file that can allocate an unbounded number
8137 of objects (Bug#8318).
8138
8139 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8140 that could (at least in theory) be that large.
8141
8142 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8143 This is less likely to overflow, and avoids undefined behavior if
8144 overflow does occur. All callers changed. Use strtoul to scan
8145 for the unsigned long integer.
8146 (pint2hrstr): Simplify and tune code slightly.
8147 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8148
8149 * scroll.c (do_scrolling): Work around GCC bug 48228.
8150 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8151
8152 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8153 This also avoids a warning with gcc -Wstrict-overflow.
8154 (validate_x_resource_name): Simplify count usage.
8155 This also avoids a warning with gcc -Wstrict-overflow.
8156
8157 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8158 fail (Bug#8306).
8159
8160 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8161
8162 * process.c (Fmake_network_process): Use socklen_t, not int,
8163 where POSIX says socklen_t is required in portable programs.
8164 This fixes a porting bug on hosts like 64-bit HP-UX, where
8165 socklen_t is wider than int (Bug#8277).
8166 (Fmake_network_process, server_accept_connection):
8167 (wait_reading_process_output, read_process_output):
8168 Likewise.
8169
8170 * process.c: Rename or move locals to avoid shadowing.
8171 (list_processes_1, Fmake_network_process):
8172 (read_process_output_error_handler, exec_sentinel_error_handler):
8173 Rename or move locals.
8174 (Fmake_network_process): Define label "retry_connect" only if needed.
8175 (Fnetwork_interface_info): Fix pointer signedness.
8176 (process_send_signal): Add cast to avoid pointer signedness problem.
8177 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8178 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8179
8180 Make tparam.h and terminfo.c consistent.
8181 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8182 Include tparam.h instead, since it declares them.
8183 * cm.h (PC): Remove extern decl; tparam.h now does this.
8184 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8185 * terminfo.c: Include tparam.h, to check interfaces.
8186 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8187 (tparam): Adjust signature to match interface in tparam.h;
8188 this removes some undefined behavior. Check that outstring and len
8189 are zero, which they always are with Emacs.
8190 * tparam.h (PC, BC, UP): New extern decls.
8191
8192 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8193 (xftfont_open): Rename locals to avoid shadowing.
8194
8195 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8196 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8197 (OTF_TAG_SYM): Omit macro if not needed.
8198 (ftfont_list): Remove unused local.
8199 (get_adstyle_property, ftfont_pattern_entity):
8200 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8201 Rename locals to avoid shadowing.
8202
8203 * xfont.c (xfont_list_family): Mark var as initialized.
8204
8205 * xml.c (make_dom): Now static.
8206
8207 * composite.c (composition_compute_stop_pos): Rename local to
8208 avoid shadowing.
8209 (composition_reseat_it): Remove unused locals.
8210 (find_automatic_composition, composition_adjust_point): Likewise.
8211 (composition_update_it): Mark var as initialized.
8212 (find_automatic_composition): Mark vars as initialized,
8213 with a FIXME (Bug#8290).
8214
8215 character.h: Rename locals to avoid shadowing.
8216 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8217 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8218 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8219 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8220 to avoid shadowing.
8221
8222 * textprop.c (property_change_between_p): Remove; unused.
8223
8224 * intervals.c (interval_start_pos): Now static.
8225
8226 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8227
8228 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8229 Rename locals to avoid shadowing.
8230
8231 * sound.c (wav_play, au_play, Fplay_sound_internal):
8232 Fix pointer signedness.
8233 (alsa_choose_format): Remove unused local var.
8234 (wav_play): Initialize a variable to 0, to prevent undefined
8235 behavior (Bug#8278).
8236
8237 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8238
8239 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8240
8241 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8242 clobbering (Bug#8298).
8243 * sysdep.c (sys_subshell): Likewise.
8244 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8245
8246 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8247 This should get cleaned up, so that child_setup has the
8248 same signature on all platforms.
8249
8250 * callproc.c (call_process_cleanup): Now static.
8251 (relocate_fd): Rename locals to avoid shadowing.
8252
8253 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8254
8255 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8256 not to be necessary, and produces flickering.
8257
8258 2011-03-20 Glenn Morris <rgm@gnu.org>
8259
8260 * config.in: Remove file.
8261
8262 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8263
8264 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8265 are now in src/globals.h.
8266 (syms_of_minibuf): Remove spurious & from previous change.
8267
8268 2011-03-20 Leo <sdl.web@gmail.com>
8269
8270 * minibuf.c (completing-read-function): New variable.
8271 (completing-read-default): Rename from completing-read.
8272 (completing-read): Call completing-read-function.
8273
8274 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8275
8276 * xfaces.c (Fx_load_color_file):
8277 Read color file from absolute filename (bug#8250).
8278
8279 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8280
8281 * makefile.w32-in: Update dependencies.
8282
8283 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8284
8285 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8286
8287 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8288
8289 Fix more problems found by GCC 4.5.2's static checks.
8290
8291 * process.c (make_serial_process_unwind, send_process_trap):
8292 (sigchld_handler): Now static.
8293
8294 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8295 That way, the code declares only the vars that it needs.
8296 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8297 * s/cygwin.h (PTY_ITERATION): Likewise.
8298 * s/darwin.h (PTY_ITERATION): Likewise.
8299 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8300
8301 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8302 * process.c (allocate_pty): Don't declare stb unless it's needed.
8303
8304 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8305 (CONSTANTLIM): Remove; unused.
8306 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8307 Define only if needed.
8308
8309 * unexelf.c (unexec): Name an expression,
8310 to avoid gcc -Wbad-function-cast warning.
8311 Use a different way to cause a compilation error if anyone uses
8312 n rather than nn, a way that does not involve shadowing.
8313 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8314
8315 * deps.mk (unexalpha.o): Remove; unused.
8316
8317 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8318 * unexec.h: New file.
8319 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8320 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8321 Depend on unexec.h.
8322 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8323 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8324 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8325 Change as necessary to match prototype in unexec.h.
8326
8327 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8328 shadowing.
8329 (back_comment, skip_chars): Mark vars as initialized.
8330
8331 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8332 Rename locals to avoid shadowing.
8333
8334 * lread.c (read1): Rewrite so as not to use empty "else".
8335 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8336
8337 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8338
8339 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8340 warning when compiling print.c.
8341
8342 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8343 instead of using an uninitialized var.
8344 (font_sort_entities): Mark var as initialized.
8345
8346 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8347
8348 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8349 pointers to constants.
8350 (font_parse_fcname): Remove unused vars.
8351 (font_delete_unmatched): Now static.
8352 (font_get_spec): Remove; unused.
8353 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8354 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8355 Rename or move locals to avoid shadowing.
8356
8357 * fns.c (require_nesting_list, require_unwind): Now static.
8358 (Ffillarray): Rename locals to avoid shadowing.
8359
8360 * floatfns.c (domain_error2): Define only if needed.
8361 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8362
8363 * alloc.c (mark_backtrace): Move decl from here ...
8364 * lisp.h: ... to here, so that it can be checked.
8365
8366 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8367 (Fdefvar): Rewrite so as not to use empty "else".
8368 (lisp_indirect_variable): Name an expression,
8369 to avoid gcc -Wbad-function-cast warning.
8370 (Fdefvar): Rename locals to avoid shadowing.
8371
8372 * callint.c (quotify_arg, quotify_args): Now static.
8373 (Fcall_interactively): Rename locals to avoid shadowing.
8374 Use const pointer when appropriate.
8375
8376 * lisp.h (get_system_name, get_operating_system_release):
8377 Move decls here, to check interfaces.
8378 * process.c (get_operating_system_release): Move decl to lisp.h.
8379 * xrdb.c (get_system_name): Likewise.
8380 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8381 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8382 some of which prompt warnings from gcc -Wbad-function-cast.
8383 (Fformat_time_string, Fencode_time, Finsert_char):
8384 (Ftranslate_region_internal, Fformat):
8385 Rename or remove local vars to avoid shadowing.
8386 (Ftranslate_region_internal): Mark var as initialized.
8387
8388 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8389 avoid shadowing.
8390
8391 * lisp.h (eassert): Check that the argument compiles, even if
8392 ENABLE_CHECKING is not defined.
8393
8394 * data.c (Findirect_variable): Name an expression, to avoid
8395 gcc -Wbad-function-cast warning.
8396 (default_value, arithcompare, arith_driver, arith_error): Now static.
8397 (store_symval_forwarding): Rename local to avoid shadowing.
8398 (Fmake_variable_buffer_local, Fmake_local_variable):
8399 Mark variables as initialized.
8400 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8401
8402 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8403 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8404 Rename locals to avoid shadowing.
8405 (mark_stack): Move local variables into the #ifdef region where
8406 they're used.
8407 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8408 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8409 needed otherwise.
8410 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8411 (GC_STRING_CHARS): Remove; not used.
8412 (Fmemory_limit): Cast sbrk's returned value to char *.
8413
8414 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8415 avoids undefined behavior in theory.
8416
8417 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8418
8419 Use functions, not macros, for up- and down-casing (Bug#8254).
8420 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8421 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8422 to use the following functions instead of these macros.
8423 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8424 EMACS_INT, since callers assume the returned value fits in int.
8425 (upcase1): Likewise, for UPCASE_TABLE.
8426 (uppercasep, lowercasep, upcase): New static inline functions.
8427 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8428 the race-condition problem in the old DOWNCASE.
8429
8430 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8431 Rename locals to avoid shadowing.
8432 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8433 (regex_compile, re_search_2, re_match_2_internal):
8434 Remove unused local vars.
8435 (FREE_VAR): Rewrite so as not to use empty "else",
8436 which gcc can warn about.
8437 (regex_compile, re_match_2_internal): Mark locals as initialized.
8438 (RETALLOC_IF): Define only if needed.
8439 (WORDCHAR_P): Likewise. This one is never needed, but is used
8440 only in a comment talking about a compiler bug, so put inside
8441 the #if 0 of that comment.
8442 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8443 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8444 Remove; unused.
8445
8446 * search.c (boyer_moore): Rename locals to avoid shadowing.
8447 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8448 (PREV_CHAR_BOUNDARY): Likewise.
8449
8450 * search.c (simple_search): Remove unused var.
8451
8452 * dired.c (compile_pattern): Move decl from here ...
8453 * lisp.h: ... to here, so that it can be checked.
8454 (struct re_registers): New forward decl.
8455
8456 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8457
8458 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8459 All uses changed.
8460 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8461 Rename locals to avoid shadowing.
8462 (Fvertical_motion): Mark locals as initialized.
8463
8464 * casefiddle.c (casify_object, casify_region): Now static.
8465 (casify_region): Mark local as initialized.
8466
8467 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8468
8469 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8470 New macros, so that the caller can use some names other than
8471 gcpro1, gcpro2, etc.
8472 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8473 of the new macros.
8474 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8475 argument, for consistency with GCPRO2_VAR, etc: it is now the
8476 prefix of the variable, not the variable itself. All uses
8477 changed.
8478 * dired.c (directory_files_internal, file_name_completion):
8479 Rename locals to avoid shadowing.
8480
8481 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8482 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8483 dired.c's scmp function, had undefined behavior.
8484 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8485 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8486 * buffer.h: ... to here, because these macros use current_buffer,
8487 and the new implementation with inline functions needs to have
8488 current_buffer in scope now, rather than later when the macros
8489 are used.
8490 (downcase, upcase1): New static inline functions.
8491 (DOWNCASE, UPCASE1): Reimplement using these functions.
8492 This avoids undefined behavior in expressions like
8493 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8494 from race conditions in accessing the global variables
8495 case_temp1 and case_temp2.
8496 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8497 * lisp.h (case_temp1, case_temp2): Remove their decls.
8498 * character.h (ASCII_CHAR_P): Move from here ...
8499 * lisp.h: ... to here, so that the inline functions mentioned
8500 above can use them.
8501
8502 * dired.c (directory_files_internal_unwind): Now static.
8503
8504 * fileio.c (file_name_as_directory, directory_file_name):
8505 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8506 Now static.
8507 (file_name_as_directory): Use const pointers when appropriate.
8508 (Fexpand_file_name): Likewise. In particular, newdir might
8509 point at constant storage, so make it a const pointer.
8510 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8511 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8512 signedness issues.
8513 (Fset_file_times, Finsert_file_contents, auto_save_error):
8514 Rename locals to avoid shadowing.
8515
8516 * minibuf.c (choose_minibuf_frame_1): Now static.
8517 (Ftry_completion, Fall_completions): Rename or remove locals
8518 to avoid shadowing.
8519
8520 * marker.c (bytepos_to_charpos): Remove; unused.
8521
8522 * lisp.h (verify_bytepos, count_markers): New decls,
8523 so that gcc does not warn that these functions aren't declared.
8524
8525 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8526 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8527 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8528 (copy_text): Remove unused local var.
8529
8530 * filelock.c (within_one_second): Now static.
8531 (lock_file_1): Rename local to avoid shadowing.
8532
8533 * buffer.c (fix_overlays_before): Mark locals as initialized.
8534 (fix_start_end_in_overlays): Likewise. This function should be
8535 simplified by using pointers-to-pointers, but that's a different
8536 matter.
8537 (switch_to_buffer_1): Now static.
8538 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8539 (report_overlay_modification): Rename locals to avoid shadowing.
8540
8541 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8542 Fix pointer signedness issue.
8543 (sys_subshell): Mark local as volatile if checking for lint,
8544 to suppress a gcc -Wclobbered warning that does not seem to be right.
8545 (MAXPATHLEN): Define only if needed.
8546
8547 * process.c (serial_open, serial_configure): Move decls from here ...
8548 * systty.h: ... to here, so that they can be checked.
8549
8550 * fns.c (get_random, seed_random): Move extern decls from here ...
8551 * lisp.h: ... to here, so that they can be checked.
8552
8553 * sysdep.c (reset_io): Now static.
8554 (wait_for_termination_signal): Remove; unused.
8555
8556 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8557 (copy_keymap_item, append_key, push_text_char_description):
8558 Now static.
8559 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8560 (DENSE_TABLE_SIZE): Remove; unused.
8561 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8562 (describe_map_tree):
8563 Rename locals to avoid shadowing.
8564
8565 * keyboard.c: Declare functions static if they are not used elsewhere.
8566 (echo_char, echo_dash, cmd_error, top_level_2):
8567 (poll_for_input, handle_async_input): Now static.
8568 (read_char, kbd_buffer_get_event, make_lispy_position):
8569 (make_lispy_event, make_lispy_movement, apply_modifiers):
8570 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8571 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8572 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8573 (read_key_sequence, read_char): Mark locals as initialized.
8574 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8575
8576 * keyboard.h (make_ctrl_char): New decl.
8577 (mark_kboards): Move decl here ...
8578 * alloc.c (mark_kboards): ... from here.
8579
8580 * lisp.h (force_auto_save_soon): New decl.
8581
8582 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8583 (DEFINE_DUMMY_FUNCTION): New macro.
8584 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8585 Use it.
8586 (main): Add casts to avoid warnings
8587 if GCC considers string literals to be constants.
8588
8589 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8590
8591 * dbusbind.c: Pointer signedness fixes.
8592 (xd_signature, xd_append_arg, xd_initialize):
8593 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8594 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8595 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8596 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8597
8598 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8599 if GCC considers string literals to be constants.
8600 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8601
8602 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8603
8604 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8605 (print_preprocess, print_object): New macro to fix last change.
8606
8607 * print.c (print_preprocess): Don't forget font objects.
8608
8609 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8610
8611 * emacs.c (USAGE3): Doc fixes.
8612
8613 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8614
8615 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8616 structure.
8617
8618 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8619
8620 * lisp.h (VWindow_system, Qfile_name_history):
8621 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8622 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8623 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8624
8625 * w32select.c: Don't #include "keyboard.h".
8626 (run_protected): Add extern declaration for waiting_for_input.
8627
8628 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8629 * w32console.c (detect_input_pending, read_input_pending)
8630 (encode_terminal_code):
8631 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8632 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8633 (w32_system_caret_y, Qfile_name_history):
8634 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8635 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8636 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8637 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8638 * w32proc.c (Qlocal, report_file_error):
8639 * w32term.c (Vwindow_system, updating_frame):
8640 * w32uniscribe.c (initialized, uniscribe_font_driver):
8641 Remove unneeded extern declarations.
8642
8643 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8644
8645 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8646
8647 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8648
8649 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8650 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8651 These macros can no longer be used for assignment.
8652
8653 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8654 Assign struct members directly, instead of using BUF_BEGV etc.
8655 (record_buffer_markers, fetch_buffer_markers): New functions for
8656 recording and fetching special buffer markers.
8657 (set_buffer_internal_1, set_buffer_temp): Use them.
8658
8659 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8660
8661 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8662
8663 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8664 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8665
8666 * xdisp.c (hscroll_window_tree):
8667 (reconsider_clip_changes): Use PT instead of BUF_PT.
8668
8669 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8670
8671 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8672 $(EMACS_ROOT)/lib/intprops.h.
8673
8674 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8675
8676 Fix more problems found by GCC 4.5.2's static checks.
8677
8678 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8679 to unsigned char * to avoid compiler diagnostic.
8680 (xg_free_frame_widgets): Make it clear that a local variable is
8681 needed only if USE_GTK_TOOLTIP.
8682 (gdk_window_get_screen): Make it clear that this macro is needed
8683 only if USE_GTK_TOOLTIP.
8684 (int_gtk_range_get_value): New function, which avoids a diagnostic
8685 from gcc -Wbad-function-cast.
8686 (xg_set_toolkit_scroll_bar_thumb): Use it.
8687 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8688 diagnostic from gcc -Wbad-function-cast.
8689 (get_utf8_string, xg_get_file_with_chooser):
8690 Rename locals to avoid shadowing.
8691 (create_dialog): Move locals to avoid shadowing.
8692
8693 * xgselect.c (xg_select): Remove unused var.
8694
8695 * image.c (four_corners_best): Mark locals as initialized.
8696 (gif_load): Initialize transparent_p to zero (Bug#8238).
8697 Mark another local as initialized.
8698 (my_png_error, my_error_exit): Mark with NO_RETURN.
8699
8700 * image.c (clear_image_cache): Now static.
8701 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8702 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8703 (x_edge_detection): Remove unnecessary cast that
8704 gcc -Wbad-function-cast diagnoses.
8705 (gif_load): Fix pointer signedness.
8706 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8707 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8708
8709 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8710
8711 Improve quality of tests for time stamp overflow.
8712 For example, without this patch (encode-time 0 0 0 1 1
8713 1152921504606846976) returns the obviously-bogus value (-948597
8714 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8715 reports time overflow. See
8716 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8717 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8718 * editfns.c: Include limits.h and intprops.h.
8719 (TIME_T_MIN, TIME_T_MAX): New macros.
8720 (time_overflow): Move earlier, to before first use.
8721 (hi_time, lo_time): New functions, for an accurate test for
8722 out-of-range times.
8723 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8724 (Fget_internal_run_time): Don't assume time_t fits in int.
8725 (make_time): Use list2 instead of Fcons twice.
8726 (Fdecode_time): More accurate test for out-of-range times.
8727 (check_tm_member): New function.
8728 (Fencode_time): Use it, to test for out-of-range times.
8729 (lisp_time_argument): Don't rely on undefined left-shift and
8730 right-shift behavior when checking for time stamp overflow.
8731
8732 * editfns.c (time_overflow): New function, refactoring common code.
8733 (Fformat_time_string, Fdecode_time, Fencode_time):
8734 (Fcurrent_time_string): Use it.
8735
8736 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8737 * dired.c (make_time): Move to ...
8738 * editfns.c (make_time): ... here.
8739 * systime.h: Note the move.
8740
8741 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8742
8743 * fringe.c (update_window_fringes): Remove unused variables.
8744
8745 * unexmacosx.c (copy_data_segment): Also copy __got section.
8746 (Bug#8223)
8747
8748 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8749
8750 * termcap.c [MSDOS]: Include "msdos.h".
8751 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8752 Constify `char *' arguments and their references according to
8753 prototypes in tparam.h.
8754
8755 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8756
8757 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8758 Adapt all references accordingly.
8759
8760 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8761
8762 2011-03-11 Tom Tromey <tromey@redhat.com>
8763
8764 * buffer.c (syms_of_buffer): Remove obsolete comment.
8765
8766 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8767
8768 * termhooks.h (encode_terminal_code): Declare prototype.
8769
8770 * msdos.c (encode_terminal_code): Don't declare prototype.
8771
8772 * term.c (encode_terminal_code): Now external again, used by
8773 w32console.c and msdos.c.
8774
8775 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8776 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8777
8778 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8779
8780 Fix some minor problems found by GCC 4.5.2's static checks.
8781
8782 * fringe.c (update_window_fringes): Mark locals as initialized
8783 (Bug#8227).
8784 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8785
8786 * alloc.c (mark_fringe_data): Move decl from here ...
8787 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8788 to check its interface.
8789 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8790
8791 * fontset.c (free_realized_fontset): Now static.
8792 (Fset_fontset_font): Rename local to avoid shadowing.
8793 (fontset_font): Mark local as initialized.
8794 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8795
8796 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8797
8798 * xselect.c (x_disown_buffer_selections): Remove; not used.
8799 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8800 (x_own_selection, Fx_disown_selection_internal): Rename locals
8801 to avoid shadowing.
8802 (x_handle_dnd_message): Remove local to avoid shadowing.
8803
8804 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8805 so that the caller can use some name other than gcpro1.
8806 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8807 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8808 (Fx_backspace_delete_keys_p):
8809 Use them to avoid shadowing, and rename vars to avoid shadowing.
8810 (x_decode_color, x_set_name, x_window): Now static.
8811 (Fx_create_frame): Add braces to silence GCC warning.
8812 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8813 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8814 Remove unused locals.
8815 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8816 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8817 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8818 macros.
8819
8820 * xterm.h (x_mouse_leave): New decl.
8821
8822 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8823 Remove unused functions.
8824 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8825 (x_calc_absolute_position): Now static.
8826 (XTread_socket): Don't define label "out" unless it's used.
8827 Don't declare local "event" unless it's used.
8828 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8829 unless they are used.
8830 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8831 (x_fatal_error_signal): Remove; not used.
8832 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8833 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8834 (x_error_catcher, x_connection_closed, x_error_handler):
8835 (x_error_quitter, xembed_send_message, x_iconify_frame):
8836 (my_log_handler): Rename locals to avoid shadowing.
8837 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8838 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8839
8840 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8841 Rename or move locals to avoid shadowing.
8842 (tty_defined_color, merge_face_heights): Now static.
8843 (free_realized_faces_for_fontset): Remove; not used.
8844 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8845 does not deduce is never used uninitialized.
8846 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8847 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8848
8849 * terminal.c (store_terminal_param): Now static.
8850
8851 * xmenu.c (menu_highlight_callback): Now static.
8852 (set_frame_menubar): Remove unused local.
8853 (xmenu_show): Rename parameter to avoid shadowing.
8854 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8855 since they might point to immutable storage.
8856 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8857 since it's unused otherwise.
8858
8859 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8860 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8861 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8862 avoids a gcc -Wuninitialized diagnostic.
8863 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
8864 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8865 does not deduce are never used uninitialized.
8866
8867 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8868
8869 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8870 * window.c (window_loop, size_window):
8871 (run_window_configuration_change_hook, enlarge_window): Likewise.
8872
8873 * window.c (display_buffer): Now static.
8874 (size_window): Mark variables that gcc -Wuninitialized
8875 does not deduce are never used uninitialized.
8876 * window.h (check_all_windows): New decl, to forestall
8877 gcc -Wmissing-prototypes diagnostic.
8878 * dispextern.h (bidi_dump_cached_states): Likewise.
8879
8880 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8881 shadowing.
8882 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8883 Include <limits.h>.
8884 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8885 and to avoid gcc -Wuninitialized warning.
8886 (load_charset_map): Mark variables that gcc -Wuninitialized
8887 does not deduce are never used uninitialized.
8888 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8889
8890 * coding.c (coding_set_source, coding_set_destination):
8891 Use "else { /* comment */ }" rather than "else /* comment */;"
8892 for clarity, and to avoid gcc -Wempty-body warning.
8893 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8894 a block, when the outer 'i' will do.
8895 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8896 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8897 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8898 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8899 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8900 Rename locals to avoid shadowing.
8901 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8902 * coding.c (emacs_mule_char, encode_invocation_designation):
8903 Now static, since they're not used elsewhere.
8904 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8905 (decode_coding_object, encode_coding_object, detect_coding_system):
8906 (decode_coding_emacs_mule): Mark variables that gcc
8907 -Wuninitialized does not deduce are never used uninitialized.
8908 (detect_coding_iso_2022): Initialize a local variable that might
8909 be used uninitialized. Leave a FIXME because it's not clear that
8910 this initialization is needed. (Bug#8211)
8911 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8912 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8913 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8914 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8915 Remove unused macros.
8916
8917 * category.c (hash_get_category_set): Remove unused local var.
8918 (copy_category_table): Now static, since it's not used elsewhere.
8919 * character.c (string_count_byte8): Likewise.
8920
8921 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8922 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8923
8924 * chartab.c (copy_sub_char_table): Now static, since it's not used
8925 elsewhere.
8926 (sub_char_table_ref_and_range, char_table_ref_and_range):
8927 Rename locals to avoid shadowing.
8928 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8929
8930 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8931 (BIDI_BOB): Remove unused macro.
8932
8933 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8934 deduce are never used uninitialized.
8935 * term.c (encode_terminal_code): Likewise.
8936
8937 * term.c (encode_terminal_code): Now static. Remove unused local.
8938
8939 * tparam.h: New file.
8940 * term.c, tparam.h: Include it.
8941 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8942 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8943 Move these decls to tparam.h, and make them agree with what
8944 is actually in tparam.c. The previous trick of using incompatible
8945 decls in different modules does not conform to the C standard.
8946 All callers of tparam changed to use tparam's actual API.
8947 * tparam.c (tparam1, tparam, tgoto):
8948 Use const pointers where appropriate.
8949
8950 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8951 * cm.h (struct cm): Likewise.
8952 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8953 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8954 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8955 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8956 (turn_on_face, init_tty): Likewise.
8957 * termchar.h (struct tty_display_info): Likewise.
8958
8959 * term.c (term_mouse_position): Rename local to avoid shadowing.
8960
8961 * alloc.c (mark_ttys): Move decl from here ...
8962 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8963
8964 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8965
8966 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8967
8968 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
8969
8970 * search.c (compile_pattern_1): Remove argument regp, unused since
8971 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8972 (compile_pattern): Don't pass it.
8973
8974 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8975
8976 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8977 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8978 for ! HAVE_GTK3.
8979 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8980
8981 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8982
8983 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8984 gdk_window_get_screen, gdk_window_get_geometry,
8985 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8986 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8987 (xg_get_pixbuf_from_pixmap): New function.
8988 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8989 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8990 Call xg_get_pixbuf_from_pixmap instead of
8991 gdk_pixbuf_get_from_drawable.
8992 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8993 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8994 (xg_check_special_colors): Use GtkStyleContext and its functions
8995 for HAVE_GTK3.
8996 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8997 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8998 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
8999 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9000 Call gtk_widget_get_preferred_size.
9001 (xg_frame_resized): gdk_window_get_geometry only takes 5
9002 parameters.
9003 (xg_win_to_widget, xg_event_is_for_menubar):
9004 Call gdk_x11_window_lookup_for_display.
9005 (xg_set_widget_bg): New function.
9006 (delete_cb): New function.
9007 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9008 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9009 (xg_set_background_color): Call xg_set_widget_bg.
9010 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9011 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9012 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9013 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9014 if ! HAVE_GTK3.
9015 (update_frame_tool_bar): Call gtk_widget_hide.
9016 (xg_initialize): Use GDK_KEY_g.
9017
9018 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9019 if ! HAVE_GTK3
9020 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9021
9022 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9023 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9024 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9025
9026 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9027
9028 * w32xfns.c (select_palette): Check success of RealizePalette against
9029 GDI_ERROR, not zero.
9030
9031 See ChangeLog.11 for earlier changes.
9032
9033 ;; Local Variables:
9034 ;; coding: utf-8
9035 ;; End:
9036
9037 Copyright (C) 2011 Free Software Foundation, Inc.
9038
9039 This file is part of GNU Emacs.
9040
9041 GNU Emacs is free software: you can redistribute it and/or modify
9042 it under the terms of the GNU General Public License as published by
9043 the Free Software Foundation, either version 3 of the License, or
9044 (at your option) any later version.
9045
9046 GNU Emacs is distributed in the hope that it will be useful,
9047 but WITHOUT ANY WARRANTY; without even the implied warranty of
9048 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9049 GNU General Public License for more details.
9050
9051 You should have received a copy of the GNU General Public License
9052 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.