Merge: Make the Lisp reader and string-to-float more consistent.
[bpt/emacs.git] / src / ChangeLog
1 2011-04-20 Paul Eggert <eggert@cs.ucla.edu>
2
3 Make the Lisp reader and string-to-float more consistent.
4 * data.c (atof): Remove decl; no longer used or needed.
5 (Fstring_to_number): Use new string_to_float function, to be
6 consistent with how the Lisp reader treats infinities and NaNs.
7 Do not assume that floating-point numbers represent EMACS_INT
8 without losing information; this is not true on most 64-bit hosts.
9 Avoid double-rounding errors, by insisting on integers when
10 parsing non-base-10 numbers, as the documentation specifies.
11 Report integer overflow instead of silently converting to
12 integers.
13 * lisp.h (string_to_float): New decl, replacing ...
14 (isfloat_string): Remove.
15 * lread.c (read1): Do not accept +. and -. as integers; this
16 appears to have been a coding error. Similarly, do not accept
17 strings like +-1e0 as floating point numbers. Do not report
18 overflow for some integer overflows and not others; instead,
19 report them all. Break out the floating-point parsing into a new
20 function string_to_float, so that Fstring_to_number parses
21 floating point numbers consistently with the Lisp reader.
22 (string_to_float): New function, replacing isfloat_string.
23 This function checks for valid syntax and produces the resulting
24 Lisp float number too.
25
26 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
27 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
28 word size.
29
30 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
31 (gnutls_make_error): Rename local to avoid shadowing.
32 (gnutls_emacs_global_deinit): ifdef out; not used.
33 (Fgnutls_boot): Use const for pointer to readonly storage.
34 Comment out unused local. Fix pointer signedness problems.
35
36 * lread.c (openp): Don't stuff size_t into an 'int'.
37 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
38 about possible signed overflow.
39
40 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
41 (GDK_KEY_g): Don't define if already defined.
42 (xg_prepare_tooltip): Avoid pointer signedness problem.
43 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
44
45 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
46 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
47
48 * xfns.c (Fx_window_property): Simplify a bit,
49 to make a bit faster and to avoid GCC 4.6.0 warning.
50 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
51
52 * fns.c (internal_equal): Don't assume size_t fits in int.
53
54 * alloc.c (compact_small_strings): Tighten assertion a little.
55
56 Replace pEd with more-general pI, and fix some printf arg casts.
57 * lisp.h (pI): New macro, generalizing old pEd macro to other
58 conversion specifiers. For example, use "...%"pI"d..." rather
59 than "...%"pEd"...".
60 (pEd): Remove. All uses replaced with similar uses of pI.
61 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
62 * alloc.c (check_pure_size): Don't overflow by converting size to int.
63 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
64 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
65 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
66 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
67 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
68 64-bit hosts.
69 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
70 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
71 * print.c (safe_debug_print, print_object): Likewise.
72 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
73 to int.
74 Use pI instead of if-then-else-abort. Use %p to avoid casts,
75 avoiding the 0 flag, which is not portable.
76 * process.c (Fmake_network_process): Use pI to avoid cast.
77 * region-cache.c (pp_cache): Likewise.
78 * xdisp.c (decode_mode_spec): Likewise.
79 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
80 behavior on 64-bit hosts with printf arg.
81 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
82 (x_stop_queuing_selection_requests): Likewise.
83 (x_get_window_property): Don't truncate byte count to an 'int'
84 when tracing.
85
86 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
87 here, since it parses constructs like leading '-' and spaces,
88 which are not wanted; and it overflows with large numbers.
89 Instead, simply match F[0-9]+, which is what is wanted anyway.
90
91 * alloc.c: Remove unportable assumptions about struct layout.
92 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
93 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
94 (allocate_vectorlike, make_pure_vector): Use the new macros,
95 plus offsetof, to remove unportable assumptions about struct layout.
96 These assumptions hold on all porting targets that I know of, but
97 they are not guaranteed, they're easy to remove, and removing them
98 makes further changes easier.
99
100 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
101 This doesn't fix a bug but makes the code clearer.
102 (string_overrun_cookie): Now const. Use initializers that
103 don't formally overflow signed char, to avoid warnings.
104 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
105 can cause Emacs to crash when string overrun checking is enabled.
106 (allocate_buffer): Don't assume sizeof (struct buffer) is a
107 multiple of sizeof (EMACS_INT); it need not be, if
108 alignof(EMACS_INT) < sizeof (EMACS_INT).
109 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
110
111 2011-04-19 Eli Zaretskii <eliz@gnu.org>
112
113 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
114 gl_state.e_property when gl_state.object is Qt.
115
116 * insdel.c (make_gap_larger): Remove limitation of buffer size
117 to <= INT_MAX.
118
119 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
120
121 * xdisp.c (lookup_glyphless_char_display)
122 (produce_glyphless_glyph): Handle cons cell entry in
123 glyphless-char-display.
124 (Vglyphless_char_display): Document it.
125
126 * term.c (produce_glyphless_glyph): Handle cons cell entry in
127 glyphless-char-display.
128
129 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
130
131 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
132
133 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
134
135 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
136 definition for no-X builds.
137
138 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
139
140 Static checks with GCC 4.6.0 and non-default toolkits.
141
142 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
143
144 * process.c (keyboard_bit_set): Define only if SIGIO.
145 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
146 (send_process): Repair possible setjmp clobbering.
147
148 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
149
150 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
151
152 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
153
154 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
155 Define only if needed.
156
157 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
158 by pacifying GCC about it. Maybe it's time to retire it?
159 * xfaces.c (USG, __TIMEVAL__): Likewise.
160
161 * dispextern.h (struct redisplay_interface): Rename param
162 to avoid shadowing.
163 * termhooks.h (struct terminal): Likewise.
164 * xterm.c (xembed_send_message): Likewise.
165
166 * insdel.c (make_gap_smaller): Define only if
167 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
168
169 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
170 it.
171
172 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
173 so that we aren't warned about unused symbols.
174
175 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
176
177 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
178
179 * xfns.c (x_real_positions): Mark locals as initialized.
180
181 * xmenu.c (xmenu_show): Don't use uninitialized vars.
182
183 * xterm.c: Fix problems found by static analysis with other toolkits.
184 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
185 (x_dispatch_event): Declare static if USE_GTK, and
186 define if USE_GTK || USE_X_TOOLKIT.
187 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
188 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
189 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only if
190 defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
191
192 * xmenu.c (menu_help_callback): Pointer type fixes.
193 Use const pointers when pointing at readonly data. Avoid pointer
194 signedness clashes.
195 (FALSE): Remove unused macro.
196 (update_frame_menubar): Remove unused decl.
197
198 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
199
200 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
201 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
202 (single_menu_item): Rename local to avoid shadowing.
203
204 * keyboard.c (make_lispy_event): Remove unused local var.
205
206 * frame.c, frame.h (x_get_resource_string): Bring this back, but
207 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
208
209 * bitmaps: Change bitmaps from unsigned char back to the X11
210 compatible char. Avoid the old compiler warnings about
211 out-of-range initializers by using, for example, '\xab' rather
212 than 0xab.
213
214 * xgselect.c (xgselect_initialize): Check vs interface
215 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
216
217 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
218
219 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
220 to read-only memory.
221
222 * fns.c (vector): Remove; this old hack is no longer needed.
223
224 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
225 Remove unused var.
226 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
227
228 * xrdb.c (x_load_resources): Omit unused local.
229
230 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
231 (x_window): Rename locals to avoid shadowing.
232 (USG): Use the kludged USG macro, to pacify gcc.
233
234 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
235 (x_term_init): Remove local to avoid shadowing.
236
237 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
238
239 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
240 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
241
242 2011-04-16 Eli Zaretskii <eliz@gnu.org>
243
244 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
245
246 Fix regex.c, syntax.c and friends for buffers > 2GB.
247 * syntax.h (struct gl_state_s): Declare character position members
248 EMACS_INT.
249
250 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
251
252 * textprop.c (verify_interval_modification, interval_of): Declare
253 arguments EMACS_INT.
254
255 * intervals.c (adjust_intervals_for_insertion): Declare arguments
256 EMACS_INT.
257
258 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
259
260 * indent.c (Fvertical_motion): Local variable it_start is now
261 EMACS_INT.
262
263 * regex.c (re_match, re_match_2, re_match_2_internal)
264 (bcmp_translate, regcomp, regexec, print_double_string)
265 (group_in_compile_stack, re_search, re_search_2, regex_compile)
266 (re_compile_pattern, re_exec): Declare arguments and local
267 variables `size_t' and `ssize_t' and return values `regoff_t', as
268 appropriate.
269 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
270 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
271 <compile_stack_type>: `size' and `avail' are now `size_t'.
272
273 * regex.h <regoff_t>: Use ssize_t, not int.
274 (re_search, re_search_2, re_match, re_match_2): Arguments that
275 specify buffer/string position and length are now ssize_t and
276 size_t. Return type is regoff_t.
277
278 2011-04-16 Ben Key <bkey76@gmail.com>
279
280 * nsfont.m: Fixed bugs in ns_get_family and
281 ns_descriptor_to_entity that were caused by using free to
282 deallocate memory blocks that were allocated by xmalloc (via
283 xstrdup). This caused Emacs to crash when compiled with
284 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
285 --enable-checking=xmallocoverrun). xfree is now used to
286 deallocate these memory blocks.
287
288 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
289
290 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
291
292 emacs_write: Accept and return EMACS_INT for sizes.
293 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
294 et seq.
295 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
296 Accept and return EMACS_INT.
297 (emacs_gnutls_write): Return the number of bytes written on
298 partial writes.
299 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
300 (emacs_read, emacs_write): Remove check for negative size, as the
301 Emacs source code has been audited now.
302 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
303 (emacs_read, emacs_write): Use it.
304 * process.c (send_process): Adjust to the new signatures of
305 emacs_write and emacs_gnutls_write. Do not attempt to store
306 a byte offset into an 'int'; it might overflow.
307 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
308
309 * sound.c: Don't assume sizes fit in 'int'.
310 (struct sound_device.period_size, alsa_period_size):
311 Return EMACS_INT, not int.
312 (struct sound_device.write, vox_write, alsa_write):
313 Accept EMACS_INT, not int.
314 (wav_play, au_play): Use EMACS_INT to store sizes and to
315 record read return values.
316
317 2011-04-15 Ben Key <bkey76@gmail.com>
318
319 * keyboard.c (Qundefined): Don't declare static since it is used
320 in nsfns.m.
321 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
322 static since they are used in nsfont.m.
323
324 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
325
326 * process.c (Qprocessp): Don't declare static.
327 * lisp.h (Qprocessp): Declare again.
328
329 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
330
331 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
332
333 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
334
335 Improve C-level modularity by making more things 'static'.
336
337 Don't publish debugger-only interfaces to other modules.
338 * lisp.h (safe_debug_print, debug_output_compilation_hack):
339 (verify_bytepos, count_markers): Move decls to the only modules
340 that need them.
341 * region-cache.h (pp_cache): Likewise.
342 * window.h (check_all_windows): Likewise.
343 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
344
345 * sysdep.c (croak): Now static, if
346 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
347 * syssignal.h (croak): Declare only if not static.
348
349 * alloc.c (refill_memory_reserve): Now static if
350 !defined REL_ALLOC || defined SYSTEM_MALLOC.
351 * lisp.h (refill_memory_reserve): Declare only if not static.
352
353 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
354 Define only if USE_LUCID.
355
356 * xrdb.c (x_customization_string, x_rm_string): Now static.
357
358 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
359 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
360
361 * xdisp.c (draw_row_with_mouse_face): Now static.
362 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
363
364 * window.h (check_all_windows): Mark externally visible.
365
366 * window.c (window_deletion_count): Now static.
367
368 * undo.c: Make symbols static if they're not exported.
369 (last_undo_buffer, last_boundary_position, pending_boundary):
370 Now static.
371
372 * textprop.c (interval_insert_behind_hooks): Now static.
373 (interval_insert_in_front_hooks): Likewise.
374
375 * term.c: Make symbols static if they're not exported.
376 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
377 (max_frame_lines, tty_set_terminal_modes):
378 (tty_reset_terminal_modes, tty_turn_off_highlight):
379 (get_tty_terminal): Now static.
380 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
381 * termhooks.h (term_mouse_moveto): Do not declare if
382 HAVE_WINDOW_SYSTEM.
383 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
384 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
385
386 * sysdep.c: Make symbols static if they're not exported.
387 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
388 Now static.
389 (sigprocmask_set, full_mask): Remove; unused.
390 (wait_debugging): Mark as visible.
391 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
392 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
393
394 * syntax.c (syntax_temp): Define only if !__GNUC__.
395
396 * sound.c (current_sound_device, current_sound): Now static.
397
398 * search.c (searchbufs, searchbuf_head): Now static.
399
400 * scroll.c (scroll_cost): Remove; unused.
401 * dispextern.h (scroll_cost): Remove decl.
402
403 * region-cache.h (pp_cache): Mark as externally visible.
404
405 * process.c: Make symbols static if they're not exported.
406 (process_tick, update_tick, create_process, chan_process):
407 (Vprocess_alist, proc_buffered_char, datagram_access):
408 (fd_callback_data, send_process_frame, process_sent_to): Now static.
409 (deactivate_process): Mark defn as static, as well as decl.
410 * lisp.h (create_process): Remove decl.
411 * process.h (chan_process, Vprocess_alist): Remove decls.
412
413 * print.c: Make symbols static if they're not exported.
414 (print_depth, new_backquote_output, being_printed, print_buffer):
415 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
416 (print_interval, print_number_index, initial_stderr_stream):
417 Now static.
418 * lisp.h (Fprinc): Remove decl.
419 (debug_output_compilation_hack): Mark as externally visible.
420
421 * sysdep.c (croak): Move decl from here to syssignal.h.
422 * syssignal.h (croak): Put it here, so the API can be checked when
423 'croak' is called from dissociate_if_controlling_tty.
424
425 * minibuf.c: Make symbols static if they're not exported.
426 (minibuf_save_list, choose_minibuf_frame): Now static.
427 * lisp.h (choose_minibuf_frame): Remove decl.
428
429 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
430
431 * lread.c: Make symbols static if they're not exported.
432 (read_objects, initial_obarray, oblookup_last_bucket_number):
433 Now static.
434 (make_symbol): Remove; unused.
435 * lisp.h (initial_obarray, make_symbol): Remove decls.
436
437 * keyboard.c: Make symbols static if they're not exported.
438 (single_kboard, recent_keys_index, total_keys, recent_keys):
439 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
440 (this_single_command_key_start, echoing, last_auto_save):
441 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
442 (command_loop, echo_now, keyboard_init_hook, help_char_p):
443 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
444 (Vlispy_mouse_stem, double_click_count):
445 Now static.
446 (force_auto_save_soon): Define only if SIGDANGER.
447 (ignore_mouse_drag_p): Now static if
448 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
449 (print_help): Remove; unused.
450 (stop_character, last_timer_event): Mark as externally visible.
451 * keyboard.h (ignore_mouse_drag_p): Declare only if
452 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
453 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
454 * lisp.h (echoing): Remove decl.
455 (force_auto_save_soon): Declare only if SIGDANGER.
456 * xdisp.c (redisplay_window): Simplify code, to make it more
457 obvious that ignore_mouse_drag_p is not accessed if !defined
458 USE_GTK && !defined HAVE_NS.
459
460 * intervals.c: Make symbols static if they're not exported.
461 (merge_properties_sticky, merge_interval_right, delete_interval):
462 Now static.
463 * intervals.h (merge_interval_right, delete_interval): Remove decls.
464
465 * insdel.c: Make symbols static if they're not exported.
466 However, leave prepare_to_modify_buffer alone. It's never
467 called from outside this function, but that appears to be a bug.
468 (combine_after_change_list, combine_after_change_buffer):
469 (adjust_after_replace, signal_before_change): Now static.
470 (adjust_after_replace_noundo): Remove; unused.
471 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
472 (signal_before_change): Remove decls.
473
474 * indent.c (val_compute_motion, val_vmotion): Now static.
475
476 * image.c: Make symbols static if they're not exported.
477 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
478 if USE_GTK.
479 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
480 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
481
482 * fringe.c (standard_bitmaps): Now static.
483 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
484
485 * frame.c: Make symbols static if they're not exported.
486 (x_report_frame_params, make_terminal_frame): Now static.
487 (get_frame_param): Now static, unless HAVE_NS.
488 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
489 (x_get_resource_string): Remove; not used.
490 * frame.h (make_terminal_frame, x_report_frame_params):
491 (x_get_resource_string); Remove decls.
492 (x_fullscreen_adjust): Declare only if WINDOWSNT.
493 * lisp.h (get_frame_param): Declare only if HAVE_NS.
494
495 * font.c, fontset.c: Make symbols static if they're not exported.
496 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
497 (FACE_SUITABLE_FOR_CHAR_P): Use it.
498 * font.c (font_close_object): Now static.
499 * font.h (font_close_object): Remove.
500 * fontset.c (FONTSET_OBJLIST): Remove.
501 (free_realized_fontset) #if-0 the body, which does nothing.
502 (face_suitable_for_char_p): #if-0, as it's never called.
503 * fontset.h (face_suitable_for_char_p): Remove decl.
504 * xfaces.c (face_at_string_position): Use
505 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
506 since 0 is always ASCII.
507
508 * fns.c (weak_hash_tables): Now static.
509
510 * fileio.c: Make symbols static if they're not exported.
511 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
512 (Vwrite_region_annotation_buffers): Now static.
513
514 * eval.c: Make symbols static if they're not exported.
515 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
516 * lisp.h (backtrace_list): Remove decl.
517
518 * emacs.c: Make symbols static if they're not exported.
519 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
520 (fatal_error_code, fatal_error_signal_hook, standard_args):
521 Now static.
522 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
523 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
524 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
525 * lisp.h (fatal_error_signal_hook): Remove decl.
526 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
527
528 * editfns.c: Move a (normally-unused) function to its only use.
529 * editfns.c, lisp.h (get_operating_system_release): Remove.
530 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
531 worth the hassle of breaking this out.
532
533 * xterm.c: Make symbols static if they're not exported.
534 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
535 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
536 (x_destroy_window, x_delete_display):
537 Now static.
538 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
539 (x_mouse_leave): Remove; unused.
540 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
541 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
542 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
543 Remove decls.
544 (x_mouse_leave): Declare only if WINDOWSNT.
545 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
546 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
547 USE_X_TOOLKIT.
548
549 * ftxfont.c: Make symbols static if they're not exported.
550 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
551 HAVE_FREETYPE.
552 * font.h (ftxfont_driver): Likewise.
553
554 * xfns.c: Make symbols static if they're not exported.
555 (x_last_font_name, x_display_info_for_name):
556 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
557 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
558 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
559 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
560 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
561 (last_show_tip_args): Now static.
562 (xic_defaut_fontset, xic_create_fontsetname): Define only if
563 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
564 (x_screen_planes): Remove; unused.
565 * dispextern.h (x_screen_planes): Remove decl.
566
567 * dispnew.c: Make symbols static if they're not exported.
568 * dispextern.h (redraw_garbaged_frames, scrolling):
569 (increment_row_positions): Remove.
570 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
571 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
572 Now static.
573 (redraw_garbaged_frames): Remove; unused.
574
575 * xfaces.c: Make symbols static if they're not exported.
576 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
577 Remove decls.
578 * xterm.h (defined_color): Remove decls.
579 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
580 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
581 (menu_face_changed_default, defined_color, free_realized_face):
582 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
583 (ascii_face_of_lisp_face): Remove; unused.
584
585 * xdisp.c: Make symbols static if they're not exported.
586 * dispextern.h (scratch_glyph_row, window_box_edges):
587 (glyph_to_pixel_coords, set_cursor_from_row):
588 (get_next_display_element, set_iterator_to_next):
589 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
590 (show_mouse_face): Remove decls
591 * frame.h (message_buf_print): Likewise.
592 * lisp.h (pop_message, set_message, check_point_in_composition):
593 Likewise.
594 * xterm.h (set_vertical_scroll_bar): Likewise.
595 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
596 (message_buf_print, scratch_glyph_row, displayed_buffer):
597 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
598 (get_next_display_element, show_mouse_face, window_box_edges):
599 (frame_to_window_pixel_xy, check_point_in_composition):
600 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
601 (glyph_to_pixel_coords): Remove; unused.
602
603 * dired.c (file_name_completion): Now static.
604
605 * dbusbind.c (xd_in_read_queued_messages): Now static.
606
607 * lisp.h (circular_list_error, FOREACH): Remove; unused.
608 * data.c (circular_list_error): Remove.
609
610 * commands.h (last_point_position, last_point_position_buffer):
611 (last_point_position_window): Remove decls.
612 * keyboard.c: Make these variables static.
613
614 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
615 decls.
616 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
617 (iso_code_class, detect_coding, code_convert_region): Now static.
618 (encode_coding_gap): Remove; unused.
619
620 * chartab.c (chartab_chars, chartab_bits): Now static.
621
622 * charset.h (charset_iso_8859_1): Remove decl.
623 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
624 Now static.
625
626 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
627 * ccl.c (Vccl_program_table): Now static.
628 (check_ccl_update): Remove; unused.
629
630 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
631 * category.h: ... from here.
632 * category.c (check_category_table, set_category_set): Now static.
633
634 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
635 * lisp.h: Remove these decls.
636
637 * buffer.c (buffer_count): Remove unused var.
638
639 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
640 so that it's not optimized away.
641 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
642 * dispextern.h (bidi_dump_cached_states): Remove, since it's
643 exported only to the debugger.
644
645 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
646 * atimer.h (run_all_atimers): Removed; not exported.
647
648 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
649 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
650 was inaccessible from Lisp.
651 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
652 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
653
654 alloc.c: Import and export fewer symbols, and remove unused items.
655 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
656 is defined.
657 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
658 it's not optimized away by whole-program optimization.
659 (message_enable_multibyte, free_misc): Remove.
660 (catchlist, handlerlist, mark_backtrace):
661 Declare only if BYTE_MARK_STACK.
662 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
663 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
664 (message_enable_multibyte): Remove decl.
665 (free_misc, interval_free_list, float_block, float_block_index):
666 (n_float_blocks, float_free_list, cons_block, cons_block_index):
667 (cons_free_list, last_marked_index):
668 Now static.
669 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
670 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
671 (mark_backtrace): Define only if BYTE_MARK_STACK.
672 * xdisp.c (message_enable_multibyte): Now static.
673
674 Declare Lisp_Object Q* variables to be 'static' if not exported.
675 This makes it easier for human readers (and static analyzers)
676 to see whether these variables are used from other modules.
677 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
678 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
679 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
680 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
681 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
682 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
683 * xmenu.c, xselect.c:
684 Declare Q* vars static if they are not used in other modules.
685 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
686 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
687 Remove decls of unexported vars.
688 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
689
690 * lisp.h (DEFINE_FUNC): Make sname 'static'.
691
692 Make Emacs functions such as Fatom 'static' by default.
693 This makes it easier for human readers (and static analyzers)
694 to see whether these functions can be called from other modules.
695 DEFUN now defines a static function. To make the function external
696 so that it can be used in other C modules, use the new macro DEFUE.
697 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
698 (Finit_image_library):
699 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
700 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
701 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
702 Remove decls, since these functions are now static.
703 (Funintern, Fget_internal_run_time): New decls, since these functions
704 were already external.
705
706 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
707 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
708 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
709 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
710 * keyboard.c, keymap.c, lread.c:
711 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
712 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
713 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
714 Mark functions with DEFUE instead of DEFUN,
715 if they are used in other modules.
716 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
717 decls for now-static functions.
718 * buffer.h (Fdelete_overlay): Remove decl.
719 * callproc.c (Fgetenv_internal): Mark as internal.
720 * composite.c (Fremove_list_of_text_properties): Remove decl.
721 (Fcomposition_get_gstring): New forward static decl.
722 * composite.h (Fcomposite_get_gstring): Remove decl.
723 * dired.c (Ffile_attributes): New forward static decl.
724 * doc.c (Fdocumntation_property): New forward static decl.
725 * eval.c (Ffetch_bytecode): New forward static decl.
726 (Funintern): Remove extern decl; now in .h file where it belongs.
727 * fileio.c (Fmake_symbolic_link): New forward static decl.
728 * image.c (Finit_image_library): New forward static decl.
729 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
730 * intervals.h (Fprevious_property_change):
731 (Fremove_list_of_text_properties): Remove decls.
732 * keyboard.c (Fthis_command_keys): Remove decl.
733 (Fcommand_execute): New forward static decl.
734 * keymap.c (Flookup_key): New forward static decl.
735 (Fcopy_keymap): Now static.
736 * keymap.h (Flookup_key): Remove decl.
737 * process.c (Fget_process): New forward static decl.
738 (Fprocess_datagram_address): Mark as internal.
739 * syntax.c (Fsyntax_table_p): New forward static decl.
740 (skip_chars): Remove duplicate decl.
741 * textprop.c (Fprevious_property_change): New forward static decl.
742 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
743 Now internal.
744 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
745 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
746
747 * editfns.c (Fformat): Remove unreachable code.
748
749 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
750
751 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
752 change. (Bug#8496)
753
754 2011-04-13 Eli Zaretskii <eliz@gnu.org>
755
756 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
757 when at ZV. (Bug#8487)
758
759 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
760
761 * charset.c (Fclear_charset_maps): Use xfree instead of free.
762 (Bug#8437)
763 * keyboard.c (parse_tool_bar_item): Likewise.
764 * sound.c (sound_cleanup, alsa_close): Likewise.
765 * termcap.c (tgetent): Likewise.
766 * xfns.c (x_default_font_parameter): Likewise.
767 * xsettings.c (read_and_apply_settings): Likewise.
768
769 * alloc.c (overrun_check_malloc, overrun_check_realloc)
770 (overrun_check_free): Protoize.
771
772 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
773
774 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
775 since callers should never pass a negative size.
776 Change the signature to match that of plain 'read' and 'write'; see
777 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
778 * lisp.h: Update prototypes of emacs_write and emacs_read.
779
780 2011-04-11 Eli Zaretskii <eliz@gnu.org>
781
782 * xdisp.c (redisplay_window): Don't try to determine the character
783 position of the scroll margin if the window start point w->startp
784 is outside the buffer's accessible region. (Bug#8468)
785
786 2011-04-10 Eli Zaretskii <eliz@gnu.org>
787
788 Fix write-region and its subroutines for buffers > 2GB.
789 * fileio.c (a_write, e_write): Modify declaration of arguments and
790 local variables to support buffers larger than 2GB.
791 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
792
793 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
794 argument, local variables, and return value.
795
796 * lisp.h: Update prototypes of emacs_write and emacs_read.
797
798 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
799
800 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
801
802 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
803
804 Fix more problems found by GCC 4.6.0's static checks.
805
806 * xdisp.c (vmessage): Use a better test for character truncation.
807
808 * charset.c (load_charset_map): <, not <=, for optimization,
809 and to avoid potential problems with integer overflow.
810 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
811 * casetab.c (set_identity, shuffle): Likewise.
812 * editfns.c (Fformat): Likewise.
813 * syntax.c (skip_chars): Likewise.
814
815 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
816 This also lets GCC 4.6.0 generate slightly better loop code.
817
818 * callint.c (Fcall_interactively): <, not <=, for optimization.
819 (Fcall_interactively): Count the number of arguments produced,
820 not the number of arguments given. This is simpler and lets GCC
821 4.6.0 generate slightly better code.
822
823 * ftfont.c: Distingish more carefully between FcChar8 and char.
824 The previous code passed unsigned char * to a functions like
825 strlen and xstrcasecmp that expect char *, which does not
826 conform to the C standard.
827 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
828 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
829 char * when the C standard requires it.
830
831 * keyboard.c (read_char): Remove unused var.
832
833 * eval.c: Port to Windows vsnprintf (Bug#8435).
834 Include <limits.h>.
835 (SIZE_MAX): Define if the headers do not.
836 (verror): Do not give up if vsnprintf returns a negative count.
837 Instead, grow the buffer. This ports to Windows vsnprintf, which
838 does not conform to C99. Problem reported by Eli Zaretskii.
839 Also, simplify the allocation scheme, by avoiding the need for
840 calling realloc, and removing the ALLOCATED variable.
841
842 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
843
844 Remove invocations of doprnt, as Emacs now uses vsnprintf.
845 But keep the doprint source code for now, as we might revamp it
846 and use it again (Bug#8435).
847 * lisp.h (doprnt): Remove.
848 * Makefile.in (base_obj): Remove doprnt.o.
849 * deps.mk (doprnt.o): Remove.
850
851 error: Print 32- and 64-bit integers portably (Bug#8435).
852 Without this change, on typical 64-bit hosts error ("...%d...", N)
853 was used to print both 32- and 64-bit integers N, which relied on
854 undefined behavior.
855 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
856 New macro.
857 * lisp.h (error, verror): Mark as printf-like functions.
858 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
859 Report overflow in size calculations when allocating printf buffer.
860 Do not truncate output string at its first null byte.
861 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
862 Truncate the output at a character boundary, since vsnprintf does not
863 do that.
864 * charset.c (check_iso_charset_parameter): Convert internal
865 character to string before calling 'error', since %c now has the
866 printf meaning.
867 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
868 overflow when computing char to be passed to 'error'. Do not
869 pass Lisp_Object to 'error'; pass the integer instead.
870 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
871 formatted with plain %d.
872
873 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
874
875 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
876
877 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
878
879 * xterm.c (x_catch_errors): Remove duplicate declaration.
880
881 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
882
883 * xdisp.c, lisp.h (message_nolog): Remove; unused.
884
885 2011-04-10 Jim Meyering <meyering@redhat.com>
886
887 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
888 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
889 return ssize_t not "int", and use size_t as the buffer length.
890 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
891 * gnutls.h: Update declarations.
892 * process.c (read_process_output): Use ssize_t, to match.
893 (send_process): Likewise.
894
895 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
896
897 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
898
899 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
900
901 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
902 unsigned char, to match FcChar8 type definition.
903
904 * xterm.c (handle_one_xevent):
905 * xmenu.c (create_and_show_popup_menu):
906 * xselect.c (x_decline_selection_request)
907 (x_reply_selection_request): Avoid type-punned deref of X events.
908
909 2011-04-09 Eli Zaretskii <eliz@gnu.org>
910
911 Fix some uses of `int' instead of EMACS_INT.
912 * search.c (string_match_1, fast_string_match)
913 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
914 (scan_buffer, find_next_newline_no_quit)
915 (find_before_next_newline, search_command, Freplace_match)
916 (Fmatch_data): Make some `int' variables be EMACS_INT.
917
918 * xdisp.c (display_count_lines): 3rd argument and return value now
919 EMACS_INT. All callers changed.
920 (pint2hrstr): Last argument is now EMACS_INT.
921
922 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
923 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
924 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
925 (decode_coding_utf_16, decode_coding_emacs_mule)
926 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
927 (decode_coding_ccl, decode_coding_charset)
928 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
929 (decode_coding_iso_2022, decode_coding_emacs_mule)
930 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
931 <char_offset, last_offset>: Declare EMACS_INT.
932 (encode_coding_utf_8, encode_coding_utf_16)
933 (encode_coding_emacs_mule, encode_invocation_designation)
934 (encode_designation_at_bol, encode_coding_iso_2022)
935 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
936 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
937 Declare EMACS_INT.
938 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
939 (encode_invocation_designation): Last argument P_NCHARS is now
940 EMACS_INT.
941 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
942 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
943
944 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
945 All users changed.
946
947 * ccl.c (Fccl_execute_on_string): Declare some variables
948 EMACS_INT.
949
950 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
951
952 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
953
954 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
955
956 * process.c (Fformat_network_address): Doc fix.
957
958 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
959
960 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
961
962 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
963
964 * keyboard.c (read_char): Call Lisp function help-form-show,
965 instead of using internal_with_output_to_temp_buffer.
966 (Qhelp_form_show): New var.
967 (syms_of_keyboard): Use DEFSYM macro.
968
969 * print.c (internal_with_output_to_temp_buffer): Function deleted.
970
971 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
972
973 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
974
975 * process.c (Flist_processes): Removed to Lisp.
976 (list_processes_1): Deleted.
977
978 2011-04-06 Eli Zaretskii <eliz@gnu.org>
979
980 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
981
982 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
983
984 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
985
986 Fix more problems found by GCC 4.6.0's static checks.
987
988 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
989
990 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
991
992 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
993
994 * xdisp.c (vmessage): Mark as a printf-like function.
995
996 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
997
998 * sound.c (sound_warning): Don't crash if arg contains a printf format.
999
1000 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1001 printf-like functions.
1002 (tiff_load): Add casts to remove these marks before passing them
1003 to system-supplied API.
1004
1005 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1006
1007 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1008 This avoids several warnings with gcc -Wstrict-overflow.
1009 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1010 directly, rather than having caller test rule sign. This avoids
1011 some unnecessary tests.
1012 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1013 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1014 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
1015
1016 * xfont.c (xfont_text_extents): Remove var that was set but not used.
1017 (xfont_open): Avoid unnecessary tests.
1018
1019 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1020
1021 * composite.h, composite.c (composition_gstring_put_cache):
1022 Use EMACS_INT, not int, for length.
1023
1024 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1025 breaking out part of COMPOSITION_DECODE_RULE.
1026 (COMPOSITION_DECODE_RULE): Use it.
1027 * composite.c (get_composition_id): Remove unused local vars,
1028 by using the new macro.
1029
1030 * textprop.c (set_text_properties_1): Change while to do-while,
1031 since the condition is always true at first.
1032
1033 * intervals.c (graft_intervals_into_buffer): Mark var as used.
1034 (interval_deletion_adjustment): Return unsigned value.
1035 All uses changed.
1036
1037 * process.c (list_processes_1, create_pty, read_process_output):
1038 (exec_sentinel): Remove vars that were set but not used.
1039 (create_pty): Remove unnecessary "volatile"s.
1040 (Fnetwork_interface_info): Avoid possibility of int overflow.
1041 (read_process_output): Do adaptive read buffering even if carryover.
1042 (read_process_output): Simplify nbytes computation if buffered.
1043
1044 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1045
1046 * syntax.c (scan_words): Remove var that was set but not used.
1047 (update_syntax_table): Use unsigned instead of int.
1048
1049 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
1050 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
1051 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
1052
1053 * print.c (print_error_message): Avoid int overflow.
1054
1055 * font.c (font_list_entities): Redo for clarity,
1056 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1057
1058 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
1059 (font_score): Avoid potential overflow in diff calculation.
1060
1061 * fns.c (substring_both): Remove var that is set but not used.
1062 (sxhash): Redo loop for clarity and to avoid wraparound warning.
1063
1064 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1065
1066 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1067 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1068 can always succeed if overflow has undefined behavior.
1069
1070 * search.c (boyer_moore, wordify): Remove vars set but not used.
1071 (wordify): Omit three unnecessary tests.
1072
1073 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1074 All callers changed. This avoids the need for an unused var.
1075
1076 * casefiddle.c (casify_region): Remove var that is set but not used.
1077
1078 * dired.c (file_name_completion): Remove var that is set but not used.
1079
1080 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1081
1082 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
1083 (Finsert_file_contents): Remove unnecessary code checking fd.
1084
1085 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1086 Check for integer overflow on size calculations.
1087
1088 * buffer.c (Fprevious_overlay_change): Remove var that is set
1089 but not used.
1090
1091 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1092 Remove vars that are set but not used.
1093 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
1094 (timer_check_2): Mark vars as initialized.
1095
1096 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1097
1098 * image.c (lookup_image): Remove var that is set but not used.
1099 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
1100
1101 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1102 that are set but not used.
1103
1104 * xfns.c (make_invisible_cursor): Don't return garbage
1105 if XCreateBitmapFromData fails (Bug#8410).
1106
1107 * xselect.c (x_get_local_selection, x_handle_property_notify):
1108 Remove vars that are set but not used.
1109
1110 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
1111 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
1112
1113 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1114 Remove var that is set but not used.
1115 (scroll_bar_windows_size): Now size_t, not int.
1116 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1117 Check for overflow.
1118
1119 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1120 (map_tty_color) [!defined MSDOS]: Likewise.
1121
1122 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1123
1124 * coding.c: Remove vars that are set but not used.
1125 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1126 All callers changed.
1127 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1128 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1129 (decode_coding_charset): Remove vars that are set but not used.
1130
1131 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1132 that is set but not used.
1133
1134 * print.c (print_object): Remove var that is set but not used.
1135
1136 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
1137 The gnulib version avoids calling malloc in the usual case,
1138 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1139 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1140 * filelock.c (current_lock_owner): Likewise.
1141 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1142 * sysdep.c: Include allocator.h, careadlinkat.h.
1143 (emacs_no_realloc_allocator): New static constant.
1144 (emacs_readlink): New function.
1145 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1146 ../lib/careadlinkat.h.
1147
1148 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1149
1150 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1151 first non-nil return value).
1152
1153 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1154
1155 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1156 if not defined (Bug#8403).
1157
1158 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1159
1160 * xdisp.c (display_count_lines): Remove parameter `start',
1161 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1162 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1163 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1164 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1165 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1166 and thereabouts. All callers changed.
1167 (get_per_char_metric): Remove parameter `f', unused since
1168 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1169
1170 2011-04-02 Jim Meyering <meyering@redhat.com>
1171
1172 do not dereference NULL upon failed strdup
1173 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1174 (ns_get_family): Likewise.
1175
1176 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1177
1178 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1179
1180 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1181
1182 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1183 later (Bug#8403).
1184
1185 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1186
1187 Add lexical binding.
1188
1189 * window.c (Ftemp_output_buffer_show): New fun.
1190 (Fsave_window_excursion):
1191 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1192
1193 * lread.c (lisp_file_lexically_bound_p): New function.
1194 (Fload): Bind Qlexical_binding.
1195 (readevalloop): Remove `evalfun' arg.
1196 Bind Qinternal_interpreter_environment.
1197 (Feval_buffer): Bind Qlexical_binding.
1198 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1199 Mark as dynamic.
1200 (syms_of_lread): Declare `lexical-binding'.
1201
1202 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1203
1204 * keyboard.c (eval_dyn): New fun.
1205 (menu_item_eval_property): Use it.
1206
1207 * image.c (parse_image_spec): Use Ffunctionp.
1208
1209 * fns.c (concat, mapcar1): Accept byte-code-functions.
1210
1211 * eval.c (Fsetq): Handle lexical vars.
1212 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1213 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1214 (FletX, Flet): Obey lexical binding.
1215 (Fcommandp): Handle closures.
1216 (Feval): New `lexical' arg.
1217 (eval_sub): New function extracted from Feval. Use it almost
1218 everywhere where Feval was used. Look up vars in lexical env.
1219 Handle closures.
1220 (Ffunctionp): Move from subr.el.
1221 (Ffuncall): Handle closures.
1222 (apply_lambda): Remove `eval_flags'.
1223 (funcall_lambda): Handle closures and new byte-code-functions.
1224 (Fspecial_variable_p): New function.
1225 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1226 but without exporting it to Lisp.
1227
1228 * doc.c (Fdocumentation, store_function_docstring):
1229 * data.c (Finteractive_form): Handle closures.
1230
1231 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1232 interactive spec.
1233
1234 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1235 byte-codes.
1236 (exec_byte_code): New function extracted from Fbyte_code to handle new
1237 calling convention for byte-code-functions. Add new byte-codes.
1238
1239 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
1240
1241 * alloc.c (Fmake_symbol): Init new `declared_special' field.
1242
1243 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1244
1245 * xdisp.c (redisplay_internal): Fix prototype.
1246
1247 2011-03-31 Eli Zaretskii <eliz@gnu.org>
1248
1249 * xdisp.c (SCROLL_LIMIT): New macro.
1250 (try_scrolling): Use it when setting scroll_limit. Limit
1251 scrolling to 100 screen lines.
1252 (redisplay_window): Even when falling back on "recentering",
1253 position point in the window according to scroll-conservatively,
1254 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1255
1256 (try_scrolling): When point is above the window, allow searching
1257 as far as scroll_max, or one screenful, to compute vertical
1258 distance from PT to the scroll margin position. This prevents
1259 try_scrolling from unnecessarily failing when
1260 scroll-conservatively is set to a value slightly larger than the
1261 window height. Clean up the case of PT below the margin at bottom
1262 of window: scroll_max can no longer be INT_MAX. When aggressive
1263 scrolling is in use, don't let point enter the opposite scroll
1264 margin as result of the scroll.
1265 (syms_of_xdisp) <scroll-conservatively>: Document the
1266 threshold of 100 lines for never-recentering scrolling.
1267
1268 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1269
1270 * dispextern.h (move_it_by_lines):
1271 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1272 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1273 (message_log_check_duplicate): Remove parameters `prev_bol' and
1274 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1275 (redisplay_internal): Remove parameter `preserve_echo_area',
1276 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1277
1278 * indent.c (Fvertical_motion):
1279 * window.c (window_scroll_pixel_based, Frecenter):
1280 Don't pass `need_y_p' to `move_it_by_lines'.
1281
1282 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1283
1284 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1285 steal a few bits to be more compact.
1286 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1287 Remove unneeded casts.
1288
1289 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1290
1291 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1292
1293 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1294 binding" message (bug#7967).
1295
1296 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1297
1298 Fix more problems found by GCC 4.6.0's static checks.
1299
1300 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1301 Remove unused local var.
1302
1303 * editfns.c (Fmessage_box): Remove unused local var.
1304
1305 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1306 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1307 Omit unused local vars.
1308 * window.c (shrink_windows): Omit unused local var.
1309 * menu.c (digest_single_submenu): Omit unused local var.
1310 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1311 Omit unused local var.
1312
1313 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1314 Don't assume string length fits in int.
1315 (keyremap_step, read_key_sequence): Use size_t for sizes.
1316 (read_key_sequence): Don't check last_real_key_start redundantly.
1317
1318 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1319 instead of alloca (Bug#8344).
1320
1321 * eval.c (Fbacktrace): Don't assume nargs fits in int.
1322 (Fbacktrace_frame): Don't assume nframes fits in int.
1323
1324 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1325
1326 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1327 concerns.
1328
1329 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1330
1331 * cm.c (calccost): Turn while-do into do-while, for clarity.
1332
1333 * keyboard.c (syms_of_keyboard): Use the same style as later
1334 in this function when indexing through an array. This also
1335 works around GCC bug 48267.
1336
1337 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1338
1339 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1340
1341 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1342 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1343
1344 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1345 This avoids undefined behavior on integer overflow, and is a bit
1346 more convenient anyway since it is compared to a size_t variable.
1347
1348 Variadic C functions now count arguments with size_t, not int.
1349 This avoids an unnecessary limitation on 64-bit machines, which
1350 caused (substring ...) to crash on large vectors (Bug#8344).
1351 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1352 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
1353 All variadic functions and their callers changed accordingly.
1354 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1355 * data.c (arith_driver, float_arith_driver): Likewise.
1356 * editfns.c (general_insert_function): Likewise.
1357 * eval.c (struct backtrace.nargs, interactive_p)
1358 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1359 (funcall_lambda, mark_backtrace): Likewise.
1360 * fns.c (concat): Likewise.
1361 * frame.c (x_set_frame_parameters): Likewise.
1362 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1363 0 if not found, not -1. All callers changed.
1364
1365 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1366 (stack_copy_size): Now size_t, not int.
1367 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1368
1369 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1370
1371 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1372 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1373 All callers changed.
1374
1375 * lisp.h (multibyte_char_to_unibyte):
1376 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1377 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1378 * character.h (CHAR_TO_BYTE8):
1379 * cmds.c (internal_self_insert):
1380 * editfns.c (general_insert_function):
1381 * keymap.c (push_key_description):
1382 * search.c (Freplace_match):
1383 * xdisp.c (message_dolog, set_message_1): All callers changed.
1384
1385 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1386
1387 * keyboard.c (safe_run_hook_funcall): New function.
1388 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1389 don't set the hook to nil, but remove the offending function instead.
1390 (Qcommand_hook_internal): Remove, unused.
1391 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1392 Vcommand_hook_internal.
1393
1394 * eval.c (enum run_hooks_condition): Remove.
1395 (funcall_nil, funcall_not): New functions.
1396 (run_hook_with_args): Call each function through a `funcall' argument.
1397 Remove `cond' argument, now redundant.
1398 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1399 (Frun_hook_with_args_until_failure): Adjust accordingly.
1400 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1401
1402 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1403
1404 * dispextern.h (string_buffer_position): Remove declaration.
1405
1406 * print.c (strout): Remove parameter `multibyte', unused since
1407 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1408
1409 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1410 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1411 All callers changed.
1412
1413 * w32.c (_wsa_errlist): Use braces for struct initializers.
1414
1415 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1416 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1417 All callers changed.
1418 (string_buffer_position): Likewise. Also, make static (it's never
1419 used outside xdisp.c).
1420 (cursor_row_p): Remove parameter `w', unused since
1421 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1422 (decode_mode_spec): Remove parameter `precision', introduced during
1423 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1424 All callers changed.
1425
1426 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1427
1428 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1429
1430 2011-03-27 Anders Lindgren <andlind@gmail.com>
1431
1432 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1433 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1434 (ns_update_auto_hide_menu_bar): New functions.
1435 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1436 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1437 ns_constrain_all_frames.
1438 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1439 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1440
1441 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1442
1443 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1444
1445 2011-03-27 Glenn Morris <rgm@gnu.org>
1446
1447 * syssignal.h: Replace RETSIGTYPE with void.
1448 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1449 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1450 Replace SIGTYPE with void everywhere.
1451 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1452 * s/template.h (SIGTYPE): Remove commented out definition.
1453
1454 2011-03-26 Eli Zaretskii <eliz@gnu.org>
1455
1456 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1457 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1458
1459 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
1460
1461 * w32.c (read_unc_volume): Use parameter `henum', instead of
1462 global variable `wget_enum_handle'.
1463
1464 * keymap.c (describe_vector): Remove parameters `indices' and
1465 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1466 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1467
1468 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1469
1470 * keyboard.c (timer_check): Remove parameter `do_it_now',
1471 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1472 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1473 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1474
1475 * keyboard.c (read_char):
1476 * w32menu.c (w32_menu_display_help):
1477 * xmenu.c (show_help_event, menu_help_callback):
1478 Adjust calls to `show_help_echo'.
1479
1480 * gtkutil.c (xg_maybe_add_timer):
1481 * keyboard.c (readable_events):
1482 * process.c (wait_reading_process_output):
1483 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1484
1485 * insdel.c (adjust_markers_gap_motion):
1486 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1487 (gap_left, gap_right): Don't call it.
1488
1489 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
1490
1491 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1492 incurred during fontification.
1493
1494 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1495
1496 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1497 (DEFVAR_PER_BUFFER): Don't pass it.
1498
1499 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1500 (scrolling_window): Don't pass it.
1501
1502 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1503
1504 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1505
1506 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1507 and `suffix'.
1508 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1509 of variables specific to SELinux and computation of `encoded_absname'.
1510
1511 * image.c (XPutPixel): Remove unused variable `height'.
1512
1513 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1514
1515 * unexw32.c (get_section_info): Remove unused variable `section'.
1516
1517 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1518 (system_process_attributes): Remove unused variable `sess'.
1519 (sys_read): Remove unused variable `err'.
1520
1521 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1522 (w32_wnd_proc): Remove unused variable `isdead'.
1523 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1524 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1525 (x_create_tip_frame): Remove unused variable `tem'.
1526
1527 * w32inevt.c (w32_console_read_socket):
1528 Remove unused variable `no_events'.
1529
1530 * w32term.c (x_draw_composite_glyph_string_foreground):
1531 Remove unused variable `width'.
1532
1533 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
1534
1535 * w32term.c (x_set_glyph_string_clipping):
1536 Don't pass uninitialized region to CombineRgn.
1537
1538 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
1539
1540 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1541 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1542 (Fx_close_connection): Remove unused variable `i'.
1543
1544 * w32font.c (w32font_draw): Return number of glyphs.
1545 (w32font_open_internal): Remove unused variable `i'.
1546 (w32font_driver): Add missing initializer.
1547
1548 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1549 (fill_in_menu): Remove unused variable `items_added'.
1550
1551 * w32term.c (last_mouse_press_frame): Remove static global variable.
1552 (w32_clip_to_row): Remove unused variable `f'.
1553 (x_delete_terminal): Remove unused variable `i'.
1554
1555 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1556 (NOTHING): Remove unused static global variable.
1557 (uniscribe_check_otf): Remove unused variable `table'.
1558 (uniscribe_font_driver): Add missing initializers.
1559
1560 2011-03-23 Julien Danjou <julien@danjou.info>
1561
1562 * term.c (Fsuspend_tty, Fresume_tty):
1563 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1564 * window.c (temp_output_buffer_show):
1565 * insdel.c (signal_before_change):
1566 * frame.c (Fhandle_switch_frame):
1567 * fileio.c (Fdo_auto_save):
1568 * emacs.c (Fkill_emacs):
1569 * editfns.c (save_excursion_restore):
1570 * cmds.c (internal_self_insert):
1571 * callint.c (Fcall_interactively):
1572 * buffer.c (Fkill_all_local_variables):
1573 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1574 Use Frun_hooks.
1575 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
1576 unconditionnaly since it does the check itself.
1577
1578 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
1579
1580 Fix more problems found by GCC 4.5.2's static checks.
1581
1582 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1583 the first time through the loop, since we know p0 < p1 then.
1584 This also avoids a gcc -Wstrict-overflow warning.
1585
1586 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1587 leading to a memory leak, possible in functions like
1588 load_charset_map_from_file that can allocate an unbounded number
1589 of objects (Bug#8318).
1590
1591 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1592 that could (at least in theory) be that large.
1593
1594 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1595 This is less likely to overflow, and avoids undefined behavior if
1596 overflow does occur. All callers changed. Use strtoul to scan
1597 for the unsigned long integer.
1598 (pint2hrstr): Simplify and tune code slightly.
1599 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
1600
1601 * scroll.c (do_scrolling): Work around GCC bug 48228.
1602 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1603
1604 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1605 This also avoids a warning with gcc -Wstrict-overflow.
1606 (validate_x_resource_name): Simplify count usage.
1607 This also avoids a warning with gcc -Wstrict-overflow.
1608
1609 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1610 fail (Bug#8306).
1611
1612 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
1613
1614 * process.c (Fmake_network_process): Use socklen_t, not int,
1615 where POSIX says socklen_t is required in portable programs.
1616 This fixes a porting bug on hosts like 64-bit HP-UX, where
1617 socklen_t is wider than int (Bug#8277).
1618 (Fmake_network_process, server_accept_connection):
1619 (wait_reading_process_output, read_process_output):
1620 Likewise.
1621
1622 * process.c: Rename or move locals to avoid shadowing.
1623 (list_processes_1, Fmake_network_process):
1624 (read_process_output_error_handler, exec_sentinel_error_handler):
1625 Rename or move locals.
1626 (Fmake_network_process): Define label "retry_connect" only if needed.
1627 (Fnetwork_interface_info): Fix pointer signedness.
1628 (process_send_signal): Add cast to avoid pointer signedness problem.
1629 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
1630 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
1631
1632 Make tparam.h and terminfo.c consistent.
1633 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1634 Include tparam.h instead, since it declares them.
1635 * cm.h (PC): Remove extern decl; tparam.h now does this.
1636 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1637 * terminfo.c: Include tparam.h, to check interfaces.
1638 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1639 (tparam): Adjust signature to match interface in tparam.h;
1640 this removes some undefined behavior. Check that outstring and len
1641 are zero, which they always are with Emacs.
1642 * tparam.h (PC, BC, UP): New extern decls.
1643
1644 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
1645 (xftfont_open): Rename locals to avoid shadowing.
1646
1647 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
1648 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1649 (OTF_TAG_SYM): Omit macro if not needed.
1650 (ftfont_list): Remove unused local.
1651 (get_adstyle_property, ftfont_pattern_entity):
1652 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1653 Rename locals to avoid shadowing.
1654
1655 * xfont.c (xfont_list_family): Mark var as initialized.
1656
1657 * xml.c (make_dom): Now static.
1658
1659 * composite.c (composition_compute_stop_pos): Rename local to
1660 avoid shadowing.
1661 (composition_reseat_it): Remove unused locals.
1662 (find_automatic_composition, composition_adjust_point): Likewise.
1663 (composition_update_it): Mark var as initialized.
1664 (find_automatic_composition): Mark vars as initialized,
1665 with a FIXME (Bug#8290).
1666
1667 character.h: Rename locals to avoid shadowing.
1668 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1669 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1670 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1671 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1672 to avoid shadowing.
1673
1674 * textprop.c (property_change_between_p): Remove; unused.
1675
1676 * intervals.c (interval_start_pos): Now static.
1677
1678 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1679
1680 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1681 Rename locals to avoid shadowing.
1682
1683 * sound.c (wav_play, au_play, Fplay_sound_internal):
1684 Fix pointer signedness.
1685 (alsa_choose_format): Remove unused local var.
1686 (wav_play): Initialize a variable to 0, to prevent undefined
1687 behavior (Bug#8278).
1688
1689 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1690
1691 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1692
1693 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1694 clobbering (Bug#8298).
1695 * sysdep.c (sys_subshell): Likewise.
1696 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
1697
1698 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1699 This should get cleaned up, so that child_setup has the
1700 same signature on all platforms.
1701
1702 * callproc.c (call_process_cleanup): Now static.
1703 (relocate_fd): Rename locals to avoid shadowing.
1704
1705 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
1706
1707 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1708 not to be necessary, and produces flickering.
1709
1710 2011-03-20 Glenn Morris <rgm@gnu.org>
1711
1712 * config.in: Remove file.
1713
1714 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
1715
1716 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1717 are now in src/globals.h.
1718 (syms_of_minibuf): Remove spurious & from previous change.
1719
1720 2011-03-20 Leo <sdl.web@gmail.com>
1721
1722 * minibuf.c (completing-read-function): New variable.
1723 (completing-read-default): Rename from completing-read.
1724 (completing-read): Call completing-read-function.
1725
1726 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
1727
1728 * xfaces.c (Fx_load_color_file):
1729 Read color file from absolute filename (bug#8250).
1730
1731 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
1732
1733 * makefile.w32-in: Update dependencies.
1734
1735 2011-03-17 Eli Zaretskii <eliz@gnu.org>
1736
1737 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1738
1739 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1740
1741 Fix more problems found by GCC 4.5.2's static checks.
1742
1743 * process.c (make_serial_process_unwind, send_process_trap):
1744 (sigchld_handler): Now static.
1745
1746 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1747 That way, the code declares only the vars that it needs.
1748 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1749 * s/cygwin.h (PTY_ITERATION): Likewise.
1750 * s/darwin.h (PTY_ITERATION): Likewise.
1751 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1752
1753 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1754 * process.c (allocate_pty): Don't declare stb unless it's needed.
1755
1756 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
1757 (CONSTANTLIM): Remove; unused.
1758 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1759 Define only if needed.
1760
1761 * unexelf.c (unexec): Name an expression,
1762 to avoid gcc -Wbad-function-cast warning.
1763 Use a different way to cause a compilation error if anyone uses
1764 n rather than nn, a way that does not involve shadowing.
1765 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
1766
1767 * deps.mk (unexalpha.o): Remove; unused.
1768
1769 New file unexec.h, the (simple) interface for unexec (Bug#8267).
1770 * unexec.h: New file.
1771 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1772 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1773 Depend on unexec.h.
1774 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1775 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1776 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
1777 Change as necessary to match prototype in unexec.h.
1778
1779 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1780 shadowing.
1781 (back_comment, skip_chars): Mark vars as initialized.
1782
1783 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1784 Rename locals to avoid shadowing.
1785
1786 * lread.c (read1): Rewrite so as not to use empty "else".
1787 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
1788
1789 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1790
1791 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1792 warning when compiling print.c.
1793
1794 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1795 instead of using an uninitialized var.
1796 (font_sort_entities): Mark var as initialized.
1797
1798 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1799
1800 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1801 pointers to constants.
1802 (font_parse_fcname): Remove unused vars.
1803 (font_delete_unmatched): Now static.
1804 (font_get_spec): Remove; unused.
1805 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1806 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1807 Rename or move locals to avoid shadowing.
1808
1809 * fns.c (require_nesting_list, require_unwind): Now static.
1810 (Ffillarray): Rename locals to avoid shadowing.
1811
1812 * floatfns.c (domain_error2): Define only if needed.
1813 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1814
1815 * alloc.c (mark_backtrace): Move decl from here ...
1816 * lisp.h: ... to here, so that it can be checked.
1817
1818 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
1819 (Fdefvar): Rewrite so as not to use empty "else".
1820 (lisp_indirect_variable): Name an expression,
1821 to avoid gcc -Wbad-function-cast warning.
1822 (Fdefvar): Rename locals to avoid shadowing.
1823
1824 * callint.c (quotify_arg, quotify_args): Now static.
1825 (Fcall_interactively): Rename locals to avoid shadowing.
1826 Use const pointer when appropriate.
1827
1828 * lisp.h (get_system_name, get_operating_system_release):
1829 Move decls here, to check interfaces.
1830 * process.c (get_operating_system_release): Move decl to lisp.h.
1831 * xrdb.c (get_system_name): Likewise.
1832 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1833 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1834 some of which prompt warnings from gcc -Wbad-function-cast.
1835 (Fformat_time_string, Fencode_time, Finsert_char):
1836 (Ftranslate_region_internal, Fformat):
1837 Rename or remove local vars to avoid shadowing.
1838 (Ftranslate_region_internal): Mark var as initialized.
1839
1840 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1841 avoid shadowing.
1842
1843 * lisp.h (eassert): Check that the argument compiles, even if
1844 ENABLE_CHECKING is not defined.
1845
1846 * data.c (Findirect_variable): Name an expression, to avoid
1847 gcc -Wbad-function-cast warning.
1848 (default_value, arithcompare, arith_driver, arith_error): Now static.
1849 (store_symval_forwarding): Rename local to avoid shadowing.
1850 (Fmake_variable_buffer_local, Fmake_local_variable):
1851 Mark variables as initialized.
1852 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
1853
1854 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
1855 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1856 Rename locals to avoid shadowing.
1857 (mark_stack): Move local variables into the #ifdef region where
1858 they're used.
1859 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1860 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1861 needed otherwise.
1862 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1863 (GC_STRING_CHARS): Remove; not used.
1864 (Fmemory_limit): Cast sbrk's returned value to char *.
1865
1866 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1867 avoids undefined behavior in theory.
1868
1869 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1870
1871 Use functions, not macros, for up- and down-casing (Bug#8254).
1872 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1873 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1874 to use the following functions instead of these macros.
1875 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1876 EMACS_INT, since callers assume the returned value fits in int.
1877 (upcase1): Likewise, for UPCASE_TABLE.
1878 (uppercasep, lowercasep, upcase): New static inline functions.
1879 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
1880 the race-condition problem in the old DOWNCASE.
1881
1882 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1883 Rename locals to avoid shadowing.
1884 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
1885 (regex_compile, re_search_2, re_match_2_internal):
1886 Remove unused local vars.
1887 (FREE_VAR): Rewrite so as not to use empty "else",
1888 which gcc can warn about.
1889 (regex_compile, re_match_2_internal): Mark locals as initialized.
1890 (RETALLOC_IF): Define only if needed.
1891 (WORDCHAR_P): Likewise. This one is never needed, but is used
1892 only in a comment talking about a compiler bug, so put inside
1893 the #if 0 of that comment.
1894 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1895 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1896 Remove; unused.
1897
1898 * search.c (boyer_moore): Rename locals to avoid shadowing.
1899 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1900 (PREV_CHAR_BOUNDARY): Likewise.
1901
1902 * search.c (simple_search): Remove unused var.
1903
1904 * dired.c (compile_pattern): Move decl from here ...
1905 * lisp.h: ... to here, so that it can be checked.
1906 (struct re_registers): New forward decl.
1907
1908 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1909
1910 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1911 All uses changed.
1912 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1913 Rename locals to avoid shadowing.
1914 (Fvertical_motion): Mark locals as initialized.
1915
1916 * casefiddle.c (casify_object, casify_region): Now static.
1917 (casify_region): Mark local as initialized.
1918
1919 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1920
1921 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1922 New macros, so that the caller can use some names other than
1923 gcpro1, gcpro2, etc.
1924 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1925 of the new macros.
1926 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1927 argument, for consistency with GCPRO2_VAR, etc: it is now the
1928 prefix of the variable, not the variable itself. All uses
1929 changed.
1930 * dired.c (directory_files_internal, file_name_completion):
1931 Rename locals to avoid shadowing.
1932
1933 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1934 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1935 dired.c's scmp function, had undefined behavior.
1936 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1937 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1938 * buffer.h: ... to here, because these macros use current_buffer,
1939 and the new implementation with inline functions needs to have
1940 current_buffer in scope now, rather than later when the macros
1941 are used.
1942 (downcase, upcase1): New static inline functions.
1943 (DOWNCASE, UPCASE1): Reimplement using these functions.
1944 This avoids undefined behavior in expressions like
1945 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1946 from race conditions in accessing the global variables
1947 case_temp1 and case_temp2.
1948 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1949 * lisp.h (case_temp1, case_temp2): Remove their decls.
1950 * character.h (ASCII_CHAR_P): Move from here ...
1951 * lisp.h: ... to here, so that the inline functions mentioned
1952 above can use them.
1953
1954 * dired.c (directory_files_internal_unwind): Now static.
1955
1956 * fileio.c (file_name_as_directory, directory_file_name):
1957 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1958 Now static.
1959 (file_name_as_directory): Use const pointers when appropriate.
1960 (Fexpand_file_name): Likewise. In particular, newdir might
1961 point at constant storage, so make it a const pointer.
1962 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
1963 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1964 signedness issues.
1965 (Fset_file_times, Finsert_file_contents, auto_save_error):
1966 Rename locals to avoid shadowing.
1967
1968 * minibuf.c (choose_minibuf_frame_1): Now static.
1969 (Ftry_completion, Fall_completions): Rename or remove locals
1970 to avoid shadowing.
1971
1972 * marker.c (bytepos_to_charpos): Remove; unused.
1973
1974 * lisp.h (verify_bytepos, count_markers): New decls,
1975 so that gcc does not warn that these functions aren't declared.
1976
1977 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1978 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
1979 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
1980 (copy_text): Remove unused local var.
1981
1982 * filelock.c (within_one_second): Now static.
1983 (lock_file_1): Rename local to avoid shadowing.
1984
1985 * buffer.c (fix_overlays_before): Mark locals as initialized.
1986 (fix_start_end_in_overlays): Likewise. This function should be
1987 simplified by using pointers-to-pointers, but that's a different
1988 matter.
1989 (switch_to_buffer_1): Now static.
1990 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1991 (report_overlay_modification): Rename locals to avoid shadowing.
1992
1993 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
1994 Fix pointer signedness issue.
1995 (sys_subshell): Mark local as volatile if checking for lint,
1996 to suppress a gcc -Wclobbered warning that does not seem to be right.
1997 (MAXPATHLEN): Define only if needed.
1998
1999 * process.c (serial_open, serial_configure): Move decls from here ...
2000 * systty.h: ... to here, so that they can be checked.
2001
2002 * fns.c (get_random, seed_random): Move extern decls from here ...
2003 * lisp.h: ... to here, so that they can be checked.
2004
2005 * sysdep.c (reset_io): Now static.
2006 (wait_for_termination_signal): Remove; unused.
2007
2008 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2009 (copy_keymap_item, append_key, push_text_char_description):
2010 Now static.
2011 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
2012 (DENSE_TABLE_SIZE): Remove; unused.
2013 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2014 (describe_map_tree):
2015 Rename locals to avoid shadowing.
2016
2017 * keyboard.c: Declare functions static if they are not used elsewhere.
2018 (echo_char, echo_dash, cmd_error, top_level_2):
2019 (poll_for_input, handle_async_input): Now static.
2020 (read_char, kbd_buffer_get_event, make_lispy_position):
2021 (make_lispy_event, make_lispy_movement, apply_modifiers):
2022 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2023 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2024 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
2025 (read_key_sequence, read_char): Mark locals as initialized.
2026 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2027
2028 * keyboard.h (make_ctrl_char): New decl.
2029 (mark_kboards): Move decl here ...
2030 * alloc.c (mark_kboards): ... from here.
2031
2032 * lisp.h (force_auto_save_soon): New decl.
2033
2034 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
2035 (DEFINE_DUMMY_FUNCTION): New macro.
2036 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2037 Use it.
2038 (main): Add casts to avoid warnings
2039 if GCC considers string literals to be constants.
2040
2041 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2042
2043 * dbusbind.c: Pointer signedness fixes.
2044 (xd_signature, xd_append_arg, xd_initialize):
2045 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2046 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2047 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2048 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2049
2050 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2051 if GCC considers string literals to be constants.
2052 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
2053
2054 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2055
2056 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2057 (print_preprocess, print_object): New macro to fix last change.
2058
2059 * print.c (print_preprocess): Don't forget font objects.
2060
2061 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
2062
2063 * emacs.c (USAGE3): Doc fixes.
2064
2065 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2066
2067 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2068 structure.
2069
2070 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
2071
2072 * lisp.h (VWindow_system, Qfile_name_history):
2073 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2074 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2075 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2076
2077 * w32select.c: Don't #include "keyboard.h".
2078 (run_protected): Add extern declaration for waiting_for_input.
2079
2080 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2081 * w32console.c (detect_input_pending, read_input_pending)
2082 (encode_terminal_code):
2083 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2084 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2085 (w32_system_caret_y, Qfile_name_history):
2086 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2087 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2088 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2089 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2090 * w32proc.c (Qlocal, report_file_error):
2091 * w32term.c (Vwindow_system, updating_frame):
2092 * w32uniscribe.c (initialized, uniscribe_font_driver):
2093 Remove unneeded extern declarations.
2094
2095 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
2096
2097 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2098
2099 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
2100
2101 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2102 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2103 These macros can no longer be used for assignment.
2104
2105 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2106 Assign struct members directly, instead of using BUF_BEGV etc.
2107 (record_buffer_markers, fetch_buffer_markers): New functions for
2108 recording and fetching special buffer markers.
2109 (set_buffer_internal_1, set_buffer_temp): Use them.
2110
2111 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2112
2113 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2114
2115 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2116 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2117
2118 * xdisp.c (hscroll_window_tree):
2119 (reconsider_clip_changes): Use PT instead of BUF_PT.
2120
2121 2011-03-13 Eli Zaretskii <eliz@gnu.org>
2122
2123 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2124 $(EMACS_ROOT)/lib/intprops.h.
2125
2126 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2127
2128 Fix more problems found by GCC 4.5.2's static checks.
2129
2130 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2131 to unsigned char * to avoid compiler diagnostic.
2132 (xg_free_frame_widgets): Make it clear that a local variable is
2133 needed only if USE_GTK_TOOLTIP.
2134 (gdk_window_get_screen): Make it clear that this macro is needed
2135 only if USE_GTK_TOOLTIP.
2136 (int_gtk_range_get_value): New function, which avoids a diagnostic
2137 from gcc -Wbad-function-cast.
2138 (xg_set_toolkit_scroll_bar_thumb): Use it.
2139 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2140 diagnostic from gcc -Wbad-function-cast.
2141 (get_utf8_string, xg_get_file_with_chooser):
2142 Rename locals to avoid shadowing.
2143 (create_dialog): Move locals to avoid shadowing.
2144
2145 * xgselect.c (xg_select): Remove unused var.
2146
2147 * image.c (four_corners_best): Mark locals as initialized.
2148 (gif_load): Initialize transparent_p to zero (Bug#8238).
2149 Mark another local as initialized.
2150 (my_png_error, my_error_exit): Mark with NO_RETURN.
2151
2152 * image.c (clear_image_cache): Now static.
2153 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
2154 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
2155 (x_edge_detection): Remove unnecessary cast that
2156 gcc -Wbad-function-cast diagnoses.
2157 (gif_load): Fix pointer signedness.
2158 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2159 (jpeg_load, gif_load): Rename locals to avoid shadowing.
2160
2161 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
2162
2163 Improve quality of tests for time stamp overflow.
2164 For example, without this patch (encode-time 0 0 0 1 1
2165 1152921504606846976) returns the obviously-bogus value (-948597
2166 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2167 reports time overflow. See
2168 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
2169 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2170 * editfns.c: Include limits.h and intprops.h.
2171 (TIME_T_MIN, TIME_T_MAX): New macros.
2172 (time_overflow): Move earlier, to before first use.
2173 (hi_time, lo_time): New functions, for an accurate test for
2174 out-of-range times.
2175 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2176 (Fget_internal_run_time): Don't assume time_t fits in int.
2177 (make_time): Use list2 instead of Fcons twice.
2178 (Fdecode_time): More accurate test for out-of-range times.
2179 (check_tm_member): New function.
2180 (Fencode_time): Use it, to test for out-of-range times.
2181 (lisp_time_argument): Don't rely on undefined left-shift and
2182 right-shift behavior when checking for time stamp overflow.
2183
2184 * editfns.c (time_overflow): New function, refactoring common code.
2185 (Fformat_time_string, Fdecode_time, Fencode_time):
2186 (Fcurrent_time_string): Use it.
2187
2188 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2189 * dired.c (make_time): Move to ...
2190 * editfns.c (make_time): ... here.
2191 * systime.h: Note the move.
2192
2193 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2194
2195 * fringe.c (update_window_fringes): Remove unused variables.
2196
2197 * unexmacosx.c (copy_data_segment): Also copy __got section.
2198 (Bug#8223)
2199
2200 2011-03-12 Eli Zaretskii <eliz@gnu.org>
2201
2202 * termcap.c [MSDOS]: Include "msdos.h".
2203 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2204 Constify `char *' arguments and their references according to
2205 prototypes in tparam.h.
2206
2207 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
2208
2209 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2210 Adapt all references accordingly.
2211
2212 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2213
2214 2011-03-11 Tom Tromey <tromey@redhat.com>
2215
2216 * buffer.c (syms_of_buffer): Remove obsolete comment.
2217
2218 2011-03-11 Eli Zaretskii <eliz@gnu.org>
2219
2220 * termhooks.h (encode_terminal_code): Declare prototype.
2221
2222 * msdos.c (encode_terminal_code): Don't declare prototype.
2223
2224 * term.c (encode_terminal_code): Now external again, used by
2225 w32console.c and msdos.c.
2226
2227 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2228 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
2229
2230 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
2231
2232 Fix some minor problems found by GCC 4.5.2's static checks.
2233
2234 * fringe.c (update_window_fringes): Mark locals as initialized
2235 (Bug#8227).
2236 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
2237
2238 * alloc.c (mark_fringe_data): Move decl from here ...
2239 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2240 to check its interface.
2241 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2242
2243 * fontset.c (free_realized_fontset): Now static.
2244 (Fset_fontset_font): Rename local to avoid shadowing.
2245 (fontset_font): Mark local as initialized.
2246 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
2247
2248 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2249
2250 * xselect.c (x_disown_buffer_selections): Remove; not used.
2251 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
2252 (x_own_selection, Fx_disown_selection_internal): Rename locals
2253 to avoid shadowing.
2254 (x_handle_dnd_message): Remove local to avoid shadowing.
2255
2256 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2257 so that the caller can use some name other than gcpro1.
2258 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
2259 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2260 (Fx_backspace_delete_keys_p):
2261 Use them to avoid shadowing, and rename vars to avoid shadowing.
2262 (x_decode_color, x_set_name, x_window): Now static.
2263 (Fx_create_frame): Add braces to silence GCC warning.
2264 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
2265 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2266 Remove unused locals.
2267 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2268 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2269 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2270 macros.
2271
2272 * xterm.h (x_mouse_leave): New decl.
2273
2274 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2275 Remove unused functions.
2276 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2277 (x_calc_absolute_position): Now static.
2278 (XTread_socket): Don't define label "out" unless it's used.
2279 Don't declare local "event" unless it's used.
2280 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2281 unless they are used.
2282 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2283 (x_fatal_error_signal): Remove; not used.
2284 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2285 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2286 (x_error_catcher, x_connection_closed, x_error_handler):
2287 (x_error_quitter, xembed_send_message, x_iconify_frame):
2288 (my_log_handler): Rename locals to avoid shadowing.
2289 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2290 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
2291
2292 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2293 Rename or move locals to avoid shadowing.
2294 (tty_defined_color, merge_face_heights): Now static.
2295 (free_realized_faces_for_fontset): Remove; not used.
2296 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2297 does not deduce is never used uninitialized.
2298 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2299 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
2300
2301 * terminal.c (store_terminal_param): Now static.
2302
2303 * xmenu.c (menu_highlight_callback): Now static.
2304 (set_frame_menubar): Remove unused local.
2305 (xmenu_show): Rename parameter to avoid shadowing.
2306 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2307 since they might point to immutable storage.
2308 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2309 since it's unused otherwise.
2310
2311 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
2312 Add a FIXME, since the code still doesn't look right. (Bug#8215)
2313 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2314 avoids a gcc -Wuninitialized diagnostic.
2315 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
2316 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2317 does not deduce are never used uninitialized.
2318
2319 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2320
2321 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
2322 * window.c (window_loop, size_window):
2323 (run_window_configuration_change_hook, enlarge_window): Likewise.
2324
2325 * window.c (display_buffer): Now static.
2326 (size_window): Mark variables that gcc -Wuninitialized
2327 does not deduce are never used uninitialized.
2328 * window.h (check_all_windows): New decl, to forestall
2329 gcc -Wmissing-prototypes diagnostic.
2330 * dispextern.h (bidi_dump_cached_states): Likewise.
2331
2332 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2333 shadowing.
2334 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
2335 Include <limits.h>.
2336 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2337 and to avoid gcc -Wuninitialized warning.
2338 (load_charset_map): Mark variables that gcc -Wuninitialized
2339 does not deduce are never used uninitialized.
2340 (load_charset): Abort instead of using uninitialized var (Bug#8229).
2341
2342 * coding.c (coding_set_source, coding_set_destination):
2343 Use "else { /* comment */ }" rather than "else /* comment */;"
2344 for clarity, and to avoid gcc -Wempty-body warning.
2345 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2346 a block, when the outer 'i' will do.
2347 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2348 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2349 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2350 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2351 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2352 Rename locals to avoid shadowing.
2353 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
2354 * coding.c (emacs_mule_char, encode_invocation_designation):
2355 Now static, since they're not used elsewhere.
2356 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
2357 (decode_coding_object, encode_coding_object, detect_coding_system):
2358 (decode_coding_emacs_mule): Mark variables that gcc
2359 -Wuninitialized does not deduce are never used uninitialized.
2360 (detect_coding_iso_2022): Initialize a local variable that might
2361 be used uninitialized. Leave a FIXME because it's not clear that
2362 this initialization is needed. (Bug#8211)
2363 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2364 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2365 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2366 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2367 Remove unused macros.
2368
2369 * category.c (hash_get_category_set): Remove unused local var.
2370 (copy_category_table): Now static, since it's not used elsewhere.
2371 * character.c (string_count_byte8): Likewise.
2372
2373 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2374 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2375
2376 * chartab.c (copy_sub_char_table): Now static, since it's not used
2377 elsewhere.
2378 (sub_char_table_ref_and_range, char_table_ref_and_range):
2379 Rename locals to avoid shadowing.
2380 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
2381
2382 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
2383 (BIDI_BOB): Remove unused macro.
2384
2385 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2386 deduce are never used uninitialized.
2387 * term.c (encode_terminal_code): Likewise.
2388
2389 * term.c (encode_terminal_code): Now static. Remove unused local.
2390
2391 * tparam.h: New file.
2392 * term.c, tparam.h: Include it.
2393 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2394 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2395 Move these decls to tparam.h, and make them agree with what
2396 is actually in tparam.c. The previous trick of using incompatible
2397 decls in different modules does not conform to the C standard.
2398 All callers of tparam changed to use tparam's actual API.
2399 * tparam.c (tparam1, tparam, tgoto):
2400 Use const pointers where appropriate.
2401
2402 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2403 * cm.h (struct cm): Likewise.
2404 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2405 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2406 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2407 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2408 (turn_on_face, init_tty): Likewise.
2409 * termchar.h (struct tty_display_info): Likewise.
2410
2411 * term.c (term_mouse_position): Rename local to avoid shadowing.
2412
2413 * alloc.c (mark_ttys): Move decl from here ...
2414 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2415
2416 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2417
2418 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2419
2420 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
2421
2422 * search.c (compile_pattern_1): Remove argument regp, unused since
2423 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2424 (compile_pattern): Don't pass it.
2425
2426 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2427
2428 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2429 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2430 for ! HAVE_GTK3.
2431 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2432
2433 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2434
2435 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2436 gdk_window_get_screen, gdk_window_get_geometry,
2437 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2438 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2439 (xg_get_pixbuf_from_pixmap): New function.
2440 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2441 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2442 Call xg_get_pixbuf_from_pixmap instead of
2443 gdk_pixbuf_get_from_drawable.
2444 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2445 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2446 (xg_check_special_colors): Use GtkStyleContext and its functions
2447 for HAVE_GTK3.
2448 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2449 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2450 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
2451 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2452 Call gtk_widget_get_preferred_size.
2453 (xg_frame_resized): gdk_window_get_geometry only takes 5
2454 parameters.
2455 (xg_win_to_widget, xg_event_is_for_menubar):
2456 Call gdk_x11_window_lookup_for_display.
2457 (xg_set_widget_bg): New function.
2458 (delete_cb): New function.
2459 (xg_create_frame_widgets): connect delete-event to delete_cb.
2460 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2461 (xg_set_background_color): Call xg_set_widget_bg.
2462 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2463 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2464 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2465 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2466 if ! HAVE_GTK3.
2467 (update_frame_tool_bar): Call gtk_widget_hide.
2468 (xg_initialize): Use GDK_KEY_g.
2469
2470 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2471 if ! HAVE_GTK3
2472 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2473
2474 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2475 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2476 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2477
2478 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
2479
2480 * w32xfns.c (select_palette): Check success of RealizePalette against
2481 GDI_ERROR, not zero.
2482
2483 See ChangeLog.11 for earlier changes.
2484
2485 ;; Local Variables:
2486 ;; coding: utf-8
2487 ;; End:
2488
2489 Copyright (C) 2011 Free Software Foundation, Inc.
2490
2491 This file is part of GNU Emacs.
2492
2493 GNU Emacs is free software: you can redistribute it and/or modify
2494 it under the terms of the GNU General Public License as published by
2495 the Free Software Foundation, either version 3 of the License, or
2496 (at your option) any later version.
2497
2498 GNU Emacs is distributed in the hope that it will be useful,
2499 but WITHOUT ANY WARRANTY; without even the implied warranty of
2500 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2501 GNU General Public License for more details.
2502
2503 You should have received a copy of the GNU General Public License
2504 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.