1 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3 configure: new option --enable-gcc-warnings
4 * Makefile.in (C_WARNINGS_SWITCH): Remove.
5 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
6 (ALL_CFLAGS): Use new macros rather than old.
7 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
8 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
9 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
10 -Wunused-result, -Wunused-variable. This should go away once
11 the Emacs and Gnulib regex code is merged.
12 (xmalloc, xrealloc): Now static.
14 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
16 composite.c: use 'double' consistently
17 * composite.c (get_composition_id): Use 'double' consistently
18 instead of converting 'float' to 'double' and vice versa; this is
19 easier to understand and avoids a GCC warning.
21 2012-04-09 Glenn Morris <rgm@gnu.org>
23 * Makefile.in: Generate leim-list with bootstrap-emacs, in
24 preparation for dumping it with emacs. (Bug#4789)
25 (leimdir): New variable.
26 ($(leimdir)/leim-list.el): New rule.
27 (emacs$(EXEEXT)): Depend on leim-list.el.
29 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
30 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
31 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
33 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
35 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
38 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
40 * xml.c (init_libxml2_functions) [WINDOWSNT]:
41 Remove unused local variable.
43 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
45 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
46 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
47 (mark_memory): Mark Lisp_Objects only if pointers might hide in
48 objects, as mark_maybe_pointer will catch them otherwise.
49 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
50 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
52 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
54 Fix typo that broke non-Windows builds.
55 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
57 2012-04-07 Eli Zaretskii <eliz@gnu.org>
59 Support building on MS-Windows with libxml2.
61 * makefile.w32-in (OBJ2): Add xml.$(O).
62 (GLOBAL_SOURCES): Add xml.c.
63 ($(BLD)/xml.$(O)): New dependency list.
65 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
66 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
67 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
68 [!WINDOWSNT]: New macros.
69 (init_libxml2_functions, libxml2_loaded_p): New functions.
70 (parse_region): Call fn_xmlCheckVersion instead of using the macro
71 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
72 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
73 Calls xmlCleanupParser only if libxml2 was loaded (or statically
75 (Flibxml_parse_html_region, Flibxml_parse_xml_region): Call
76 init_libxml2_functions before calling libxml2 functions.
77 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
79 * emacs.c: Don't include libxml/parser.h.
80 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
81 xmlCleanupParser directly.
83 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
85 2012-04-07 Eli Zaretskii <eliz@gnu.org>
87 * indent.c (Fvertical_motion): If there is a display string at
88 point, use it.vpos to compute how many lines to backtrack after
89 move_it_to point. (Bug#11133)
91 2012-04-06 Eli Zaretskii <eliz@gnu.org>
93 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
94 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
95 about subtle differences between FETCH_CHAR* and STRING_CHAR*
96 macros related to unification of CJK characters. For the details,
97 see the discussion following the message here:
98 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
100 2012-04-04 Chong Yidong <cyd@gnu.org>
102 * keyboard.c (Vdelayed_warnings_list): Doc fix.
104 2012-04-01 Eli Zaretskii <eliz@gnu.org>
106 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
107 instead of alloca. (Bug#11138)
109 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
111 * w32menu.c (is_simple_dialog): Properly check lisp types.
114 2012-03-31 Eli Zaretskii <eliz@gnu.org>
116 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
117 position we get to after a call to move_it_to fails the
118 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
119 only if we wind up in a string from display property. (Bug#11063)
121 * window.c (Fdelete_other_windows_internal): Invalidate the row
122 and column information about mouse highlight, so that redisplay
123 restores it after reallocating the glyph matrices. (Bug#7464)
125 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
126 string comes from a `display' text property, use the buffer
127 position of that property as if we actually saw that position in
129 (move_it_by_lines): Remove the assertion that
130 "it->current_x == 0 && it->hpos == 0" which can be legitimately
131 violated when there's a before-string at the beginning of a line.
134 2012-03-30 Eli Zaretskii <eliz@gnu.org>
136 * xdisp.c (append_space_for_newline): If the default face was
137 remapped, use the remapped face for the appended newline.
138 (extend_face_to_end_of_line): Use the remapped default face for
139 extending the face to the end of the line.
140 (display_line): Call extend_face_to_end_of_line when the default
141 face was remapped. (Bug#11068)
143 2012-03-29 Eli Zaretskii <eliz@gnu.org>
145 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
147 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
149 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
151 2012-03-27 Glenn Morris <rgm@gnu.org>
153 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
156 2012-03-26 Kenichi Handa <handa@m17n.org>
158 * dispextern.h (struct glyph): Fix previous change. Change the
159 bit length of glyphless.ch to 25 (Bug#11082).
161 2012-03-26 Chong Yidong <cyd@gnu.org>
163 * keyboard.c (Vselection_inhibit_update_commands): New variable.
164 (command_loop_1): Use it; inhibit selection update for
165 handle-select-window too (Bug#8996).
167 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
169 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
171 2012-03-25 Kenichi Handa <handa@m17n.org>
173 * dispextern.h (struct glyph): Change the bit length of
174 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
176 2012-03-24 Eli Zaretskii <eliz@gnu.org>
178 * s/ms-w32.h (tzname): Include time.h before redirecting to
179 _tzname. Fixes the MSVC build. (Bug#9960)
181 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
183 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
186 * xterm.c (XTread_socket): Only modify handling_signal if
187 !SYNC_INPUT. (Bug#11080)
189 2012-03-23 Eli Zaretskii <eliz@gnu.org>
191 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
192 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
193 when fetching a multibyte character consumes more bytes than
194 CHAR_BYTES returns, due to unification of CJK characters in
195 string_char. (Bug#11073)
197 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
199 * process.c (wait_reading_process_output): Handle pty disconnect
200 by refraining from sending oneself a SIGCHLD (bug#10933).
202 2012-03-22 Chong Yidong <cyd@gnu.org>
204 * dispextern.h (struct it): New member string_from_prefix_prop_p.
206 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
207 Mark string as coming from a prefix property.
208 (handle_face_prop): Use default face for prefix strings (Bug#4281).
209 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
211 2012-03-21 Chong Yidong <cyd@gnu.org>
213 * xfaces.c (Vface_remapping_alist): Doc fix.
215 2012-03-20 Eli Zaretskii <eliz@gnu.org>
217 * w32proc.c (Fw32_set_console_codepage)
218 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
221 2012-03-20 Chong Yidong <cyd@gnu.org>
223 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
224 to reflect default non-nil value of redisplay-dont-pause.
226 2012-03-19 Kenichi Handa <handa@m17n.org>
228 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
229 it fit in a valid range (Bug#11003).
231 2012-03-18 Eli Zaretskii <eliz@gnu.org>
233 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
234 that is not from display property, accept the row as a "cursor
235 row" if one of the string's character has a non-nil `cursor'
236 property. Fixes cursor positioning when there are newlines in
237 overlay strings, e.g. in icomplete.el. (Bug#11035)
239 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
241 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
243 2012-03-12 Chong Yidong <cyd@gnu.org>
245 * eval.c (inhibit_lisp_code): Rename from
246 inhibit_window_configuration_change_hook; move from window.c.
248 * xfns.c (unwind_create_frame_1, Fx_create_frame):
249 * window.c (run_window_configuration_change_hook)
250 (syms_of_window): Callers changed.
252 2012-03-11 Chong Yidong <cyd@gnu.org>
254 * keymap.c (Fkey_description): Doc fix (Bug#9700).
256 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
258 2012-03-10 Chong Yidong <cyd@gnu.org>
260 * frame.c (other_visible_frames): Don't assume the selected frame
261 is visible (Bug#10955).
263 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
265 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
267 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
269 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
270 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
273 2012-03-03 Glenn Morris <rgm@gnu.org>
275 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
277 2012-03-02 Eli Zaretskii <eliz@gnu.org>
279 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
280 position past the first glyph_row that ends at ZV. (Bug#10902)
281 (redisplay_window, next_element_from_string): Fix typos in
283 (redisplay_window): Pass to move_it_vertically the margin in
284 pixels, not in screen lines.
286 2012-03-02 Glenn Morris <rgm@gnu.org>
288 * buffer.c (buffer-list-update-hook): Doc fix.
290 2012-02-29 Eli Zaretskii <eliz@gnu.org>
292 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
293 push_it before setting up the iterator for the first overlay
294 string, even if we have an empty string loaded.
295 (next_overlay_string): If there's an empty string on the iterator
296 stack, pop the stack. (Bug#10903)
298 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
300 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
301 Suggested by Stefan Monnier in
302 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
303 * alloc.c (widen_to_Lisp_Object): New static function.
304 (mark_memory): Also mark Lisp_Objects by fetching pointer words
305 and widening them to Lisp_Objects. This would work even if
306 USE_LSB_TAG is defined and wide integers are used, which might
307 happen in a future version of Emacs.
309 2012-02-25 Chong Yidong <cyd@gnu.org>
311 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
314 * xselect.c (Fx_selection_exists_p): Doc fix.
315 (x_clipboard_manager_save_all): Print an informative message
316 before saving to clipboard manager.
318 2012-02-24 Chong Yidong <cyd@gnu.org>
320 * keyboard.c (process_special_events): Handle all X selection
321 requests in kbd_buffer, not just the next one (Bug#8869).
323 2012-02-23 Chong Yidong <cyd@gnu.org>
325 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
326 call when setting menu-bar-lines and tool-bar-lines parameters.
327 (unwind_create_frame_1): New helper function.
329 * window.c (inhibit_window_configuration_change_hook): New var.
330 (run_window_configuration_change_hook): Obey it.
331 (syms_of_window): Initialize it.
333 2012-02-22 Chong Yidong <cyd@gnu.org>
335 * xterm.c (x_draw_image_relief): Add missing type check for
336 Vtool_bar_button_margin (Bug#10743).
338 2012-02-21 Chong Yidong <cyd@gnu.org>
340 * fileio.c (Vfile_name_handler_alist): Doc fix.
342 * buffer.c (Fget_file_buffer): Protect against invalid file
343 handler return value.
345 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
347 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
348 when computing $valmask.
350 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
351 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
352 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
353 It's useless in that case, and it can cause problems on hosts
354 that allocate halves of EMACS_INT values separately.
355 Reported by Dan Horák. Diagnosed by Andreas Schwab in
356 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
357 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
358 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
359 it avoids undefined behavior on hosts where shifting right by more
360 than the word width has undefined behavior.
362 2012-02-19 Chong Yidong <cyd@gnu.org>
364 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
365 (Funhandled_file_name_directory, Ffile_name_as_directory)
366 (Fdirectory_file_name, Fexpand_file_name)
367 (Fsubstitute_in_file_name): Protect against invalid file handler
368 return values (Bug#10845).
370 2012-02-18 Eli Zaretskii <eliz@gnu.org>
372 * .gdbinit (pitx): Fix incorrect references to fields of the
375 2012-02-17 Chong Yidong <cyd@gnu.org>
377 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
379 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
381 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
382 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
384 2012-02-15 Chong Yidong <cyd@gnu.org>
386 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
387 marked as special. Also, starting docstrings with * is obsolete.
389 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
391 * gnutls.c (emacs_gnutls_write): Fix last change.
393 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
395 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
398 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
400 * keymap.c (Fsingle_key_description): Handle char ranges.
402 2012-02-12 Chong Yidong <cyd@gnu.org>
404 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
405 as that creates a dangerous corner case.
407 * window.c (Fdelete_window_internal): Invalidate the mouse
408 highlight (Bug#9904).
410 2012-02-12 Glenn Morris <rgm@gnu.org>
412 * xselect.c (Fx_own_selection_internal)
413 (Fx_get_selection_internal, Fx_disown_selection_internal)
414 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
415 * nsselect.m (Fx_own_selection_internal)
416 (Fx_disown_selection_internal, Fx_selection_exists_p)
417 (Fx_selection_owner_p, Fx_get_selection_internal):
418 Sync docs and argument specs with the xselect.c versions.
420 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
422 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
424 2012-02-11 Eli Zaretskii <eliz@gnu.org>
426 * w32select.c (Fx_selection_exists_p): Sync doc string and
427 argument list with xselect.c. (Bug#10783)
429 * w16select.c (Fx_selection_exists_p): Sync doc string and
430 argument list with xselect.c. (Bug#10783)
432 2012-02-10 Glenn Morris <rgm@gnu.org>
434 * fns.c (Fsecure_hash): Doc fix.
436 2012-02-09 Kenichi Handa <handa@m17n.org>
438 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
440 2012-02-07 Chong Yidong <cyd@gnu.org>
442 * buffer.c (Fbuffer_local_variables)
443 (buffer_lisp_local_variables): Handle unbound vars correctly;
444 don't let Qunbound leak into Lisp.
446 2012-02-07 Glenn Morris <rgm@gnu.org>
448 * image.c (Fimagemagick_types): Doc fix.
450 * image.c (imagemagick-render-type): Change it from a lisp object
451 to an integer. Move the doc here from the lisp manual.
452 Treat all values not equal to 0 the same.
454 2012-02-06 Chong Yidong <cyd@gnu.org>
456 * doc.c (store_function_docstring): Avoid applying docstring of
457 alias to base function (Bug#2603).
459 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
461 * .gdbinit (pp1, pv1): Remove redundant defines.
464 2012-02-04 Chong Yidong <cyd@gnu.org>
466 * nsterm.m: Declare a global (Bug#10694).
468 2012-02-04 Eli Zaretskii <eliz@gnu.org>
470 * w32.c (get_emacs_configuration_options):
471 Include --enable-checking, if specified, in the return value.
473 2012-02-04 Martin Rudalics <rudalics@gmx.at>
475 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
476 after rounding frame sizes. (Bug#9723)
478 2012-02-04 Eli Zaretskii <eliz@gnu.org>
480 * keyboard.c (adjust_point_for_property): Don't position point
481 before BEGV. (Bug#10696)
483 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
485 Handle overflow when computing char display width (Bug#9496).
486 * character.c (char_width): Return EMACS_INT, not int.
487 (char_width, c_string_width): Check for overflow when
488 computing the width; this is possible now that individual
489 characters can have unbounded width. Problem introduced
490 by merge from Emacs 23 on 2012-01-19.
492 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
494 * dbusbind.c (Fdbus_register_method): Mention the return value
495 :ignore in the docstring.
497 2012-02-02 Glenn Morris <rgm@gnu.org>
499 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
501 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
502 Unconditionally set to t. (Bug#10673)
503 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
504 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
505 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
507 2012-02-02 Kenichi Handa <handa@m17n.org>
509 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
510 0, do not call append_composite_glyph.
512 2012-02-02 Kenichi Handa <handa@m17n.org>
514 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
516 (x_produce_glyphs): If the component of a composition is a null
517 string, set it->pixel_width to 1 to avoid zero-width glyph.
519 2012-02-01 Eli Zaretskii <eliz@gnu.org>
521 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
522 first 2 arguments are identical. This makes inserting large
523 output from a subprocess an order of magnitude faster on
524 MS-Windows, where all sbrk'ed memory is always contiguous.
526 2012-01-31 Glenn Morris <rgm@gnu.org>
528 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
529 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
530 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
532 2012-01-29 Glenn Morris <rgm@gnu.org>
534 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
536 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
538 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
540 2012-01-28 Chong Yidong <cyd@gnu.org>
542 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
544 2012-01-26 Chong Yidong <cyd@gnu.org>
546 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
548 * search.c (Fsearch_forward, Fsearch_backward): Document negative
549 repeat counts (Bug#10507).
551 2012-01-26 Glenn Morris <rgm@gnu.org>
553 * lread.c (syms_of_lread): Doc fix.
555 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
557 * coding.c (encode_designation_at_bol): Change return value to
560 2012-01-25 Chong Yidong <cyd@gnu.org>
562 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
564 2012-01-21 Chong Yidong <cyd@gnu.org>
566 * floatfns.c (Fcopysign): Make the second argument non-optional,
567 since nil is not allowed anyway.
569 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
571 * process.c (read_process_output): Use p instead of XPROCESS (proc).
572 (send_process): Likewise.
574 2012-01-19 Martin Rudalics <rudalics@gmx.at>
576 * window.c (save_window_save, Fcurrent_window_configuration)
577 (Vwindow_persistent_parameters): Do not use Qstate.
580 2012-01-19 Kenichi Handa <handa@m17n.org>
582 * character.c (char_width): New function.
583 (Fchar_width, c_string_width, lisp_string_width):
584 Use char_width (Bug#9496).
586 2012-01-16 Martin Rudalics <rudalics@gmx.at>
588 * window.c (Vwindow_persistent_parameters): New variable.
589 (Fset_window_configuration, save_window_save): Handle persistent
592 2012-01-14 Eli Zaretskii <eliz@gnu.org>
594 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
595 thrashing the stack of the thread. (Bug#9087)
597 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
599 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
601 2012-01-11 Eli Zaretskii <eliz@gnu.org>
603 * xdisp.c (rows_from_pos_range): Handle the case where the
604 highlight ends on a newline. (Bug#10464)
605 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
606 he end column for display of highlight that ends on a newline
609 2012-01-11 Glenn Morris <rgm@gnu.org>
611 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
612 from load-path also when installation-directory is nil. (Bug#10208)
614 2012-01-10 Glenn Morris <rgm@gnu.org>
616 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
618 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
619 Update template values to be closer to their typical values these days.
621 2012-01-09 Eli Zaretskii <eliz@gnu.org>
623 * xdisp.c (rows_from_pos_range): Accept additional argument
624 DISP_STRING, and accept any glyph in a row whose object is that
625 string as eligible for mouse highlight. Fixes mouse highlight of
626 display strings from overlays. (Bug#10464)
628 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
630 emacs: fix an auto-save permissions race condition (Bug#10400)
631 * fileio.c (auto_saving_dir_umask): New static var.
632 (Fmake_directory_internal): Use it.
633 (do_auto_save_make_dir): Set it, instead of invoking chmod after
634 creating the directory. The old code temporarily assigns
635 too-generous permissions to the directory.
636 (do_auto_save_eh): Clear it.
637 (Fdo_auto_save): Catch all errors, not just file errors, so
638 that the var is always cleared.
640 2012-01-07 Eli Zaretskii <eliz@gnu.org>
642 * search.c (scan_buffer): Pass character positions to
643 know_region_cache, not byte positions. (Bug#6540)
645 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
647 * w32.c (sys_rename): Report EXDEV when rename of a directory
648 fails because the target is on another logical disk. (Bug#10284)
650 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
652 * xterm.c (x_embed_request_focus): New function.
654 * xterm.h: Add prototype.
656 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
658 2012-01-05 Glenn Morris <rgm@gnu.org>
660 * emacs.c (emacs_copyright): Update short copyright year to 2012.
662 2012-01-01 Eli Zaretskii <eliz@gnu.org>
664 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
665 Load gnutls_transport_set_lowat only if GnuTLS version is below
667 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
668 GnuTLS versions below 2.11.1.
670 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
672 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
673 to the doc string advising against its use for altering the way
674 windows are scrolled.
676 2011-12-28 Kenichi Handa <handa@m17n.org>
678 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
679 coding-system ASCII compatible only when it does not produce BOM
680 on encoding (Bug#10383).
682 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
684 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
686 (create_and_show_popup_menu): Always use menu_position_func for
689 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
691 * callint.c (Fcall_interactively): Don't truncate prompt string.
693 2011-12-23 Eli Zaretskii <eliz@gnu.org>
695 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
696 property that ends at ZV, so that the bidi iteration could be
697 resumed from there (after widening). (Bug#10360)
699 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
701 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
703 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
705 * nsterm.m (x_free_frame_resources):
706 Release f->output_data.ns->miniimage.
707 (ns_index_color): Fix indentation. Do not retain
708 color_table->colors[i].
710 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
713 * nsfns.m (x_set_background_color): Assign return value from
714 ns_index_color to face-background instead of NSColor*.
715 (ns_implicitly_set_icon_type): Fix indentation.
716 Change assignment in for loop to comparison.
718 * emacs.c (ns_pool): New variable.
719 (main): Assign ns_pool.
720 (Fkill_emacs): Call ns_release_autorelease_pool.
722 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
723 autorelease fdesc, release fdAttrs and tdict.
724 (ns_get_covering_families): Release charset.
725 (ns_findfonts): Release NSFontDescriptor created with new.
726 (ns_uni_to_glyphs): Fix indentation.
727 (setString): Release attrStr before assigning new value.
729 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
731 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
733 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
734 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
736 2011-12-18 David Reitter <reitter@cmu.edu>
738 * nsterm.m (ns_term_init): Subscribe for notifications
739 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
740 to method trackingNotification in EmacsMenu.
742 * nsmenu.m (trackingMenu): New variable.
743 (trackingNotification): New method (from Aquamacs).
744 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
745 from Aquamacs (Bug#7030).
747 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
749 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
750 (symbol_to_nsstring): Fix indentation.
751 (ns_symbol_to_pb): New function.
752 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
753 (Fns_rotate_cut_buffers_internal): Remove.
754 (Fns_store_selection_internal): Rename from
755 Fns_store_cut_buffer_internal.
756 (ns_get_foreign_selection, Fx_own_selection_internal)
757 (Fx_disown_selection_internal, Fx_selection_exists_p)
758 (Fns_get_selection_internal, Fns_store_selection_internal):
759 Use ns_symbol_to_pb and check if return value is nil.
760 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
761 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
762 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
763 renamed to Sns_store_selection_internal.
764 (ns_handle_selection_request): Move code to Fx_own_selection_internal
765 and remove this function.
766 (ns_handle_selection_clear): Remove, never used.
767 (Fx_own_selection_internal): Move code from ns_handle_selection_request
770 2011-12-17 Ken Brown <kbrown@cornell.edu>
772 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
773 GID is unknown (Bug#10257).
775 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
777 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
778 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
779 which caused a build failure on GNU/Linux IA-64. This problem was
780 introduced by my 2011-10-07 patch.
782 2011-12-15 Juri Linkov <juri@jurta.org>
784 * image.c (imagemagick_error): New function. (Bug#10112)
785 (imagemagick_load_image): Comment out `MagickSetResolution' call.
786 Use `imagemagick_error' where ImageMagick functions return
788 (Fimagemagick_types): Add `Fnreverse' to return the list in the
791 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
793 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
794 fill background (Bug#8992).
796 2011-12-13 Martin Rudalics <rudalics@gmx.at>
798 * window.c (Vwindow_combination_resize)
799 (Vwindow_combination_limit): Use t instead of non-nil in
801 (Vrecenter_redisplay): Add first sentence of doc-string on
803 (Frecenter): Fix doc-string typo.
805 2011-12-11 Kenichi Handa <handa@m17n.org>
807 * coding.c (Funencodable_char_position): Pay attention to the
808 buffer text relocation (Bug#9389).
810 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
812 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
813 gtk_init (Bug#10100).
815 2011-12-10 Eli Zaretskii <eliz@gnu.org>
817 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
818 IT->string is nil. (Bug#10263)
820 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
822 * nsterm.h (x_free_frame_resources): Declare.
824 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
825 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
827 * nsterm.h (ns_get_defaults_value): Declare.
829 * nsterm.m (ns_default): Call ns_get_defaults_value.
831 2011-12-09 Eli Zaretskii <eliz@gnu.org>
833 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
836 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
838 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
839 that where the value of an _OBJC_* symbol points to is in the .bss
842 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
844 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
845 after the loop to call ccl_driver at least once (Bug#8619).
847 2011-12-08 Kenichi Handa <handa@m17n.org>
849 * ftfont.c (get_adstyle_property): Fix previous change
852 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
854 * w32.c (init_environment): If no_site_lisp, remove site-lisp
855 dirs from the default value of EMACSLOADPATH (bug#10208).
857 2011-12-07 Glenn Morris <rgm@gnu.org>
859 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
860 installation and source directories as well. (Bug#10208)
862 2011-12-06 Chong Yidong <cyd@gnu.org>
864 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
866 2011-12-06 Glenn Morris <rgm@gnu.org>
868 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
869 as an error, not just -1. (Bug#10217)
871 2011-12-05 Chong Yidong <cyd@gnu.org>
873 * keyboard.c (process_special_events): New function.
874 (swallow_events, Finput_pending_p): Use it (Bug#10195).
876 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
878 * coding.c (encode_designation_at_bol): Don't use uninitialized
879 local variable (Bug#9318).
881 2011-12-05 Kenichi Handa <handa@m17n.org>
883 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
884 return Qnil (Bug#8046, Bug#10193).
886 2011-12-05 Kenichi Handa <handa@m17n.org>
888 * coding.c (encode_designation_at_bol): New args charbuf_end and
889 dst. Return the number of produced bytes. Callers changed.
890 (coding_set_source): Return how many bytes coding->source was
892 (coding_set_destination): Return how many bytes
893 coding->destination was relocated.
894 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
895 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
897 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
899 * coding.c (CODING_CHAR_CHARSET_P): New macro.
900 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
903 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
905 The following changes are to fix Bug#9318.
907 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
908 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
909 (encode_coding_iso_2022, encode_coding_sjis)
910 (encode_coding_big5, encode_coding_charset): Use the above macros.
912 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
914 * lisp.h (process_quit_flag): Fix external declaration.
916 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
918 Don't macro-inline non-performance-critical code.
919 * eval.c (process_quit_flag): New function.
920 * lisp.h (QUIT): Use it.
922 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
924 * nsfns.m (get_geometry_from_preferences): New function.
925 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
927 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
929 * emacs.c (Qkill_emacs): Define.
930 (syms_of_emacs): Initialize it.
931 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
932 Qquit_flag to `kill-emacs' instead.
933 (quit_throw_to_read_char): Add parameter `from_signal'.
934 All callers changed. Call Fkill_emacs if requested and safe.
935 * lisp.h (QUIT): Call Fkill_emacs if requested.
937 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
939 * widget.c (update_wm_hints): Return if wmshell is null.
940 (widget_update_wm_size_hints): New function.
942 * widget.h (widget_update_wm_size_hints): Declare.
944 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
945 widget_update_wm_size_hints (Bug#10104).
947 2011-12-03 Eli Zaretskii <eliz@gnu.org>
949 * xdisp.c (handle_invisible_prop): If the invisible text ends just
950 before a newline, prepare the bidi iterator for consuming the
951 newline, and keep the current paragraph direction. (Bug#10183)
952 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
954 2011-12-02 Juri Linkov <juri@jurta.org>
956 * search.c (Fword_search_regexp): New Lisp function created from
957 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
958 (Fword_search_backward, Fword_search_forward)
959 (Fword_search_backward_lax, Fword_search_forward_lax):
960 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
961 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
963 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
965 * fileio.c (Finsert_file_contents): Move after-change-function call
966 to before the "handled:" label, since all "goto handled" appear in
967 cases where the *-change-functions have already been properly called
970 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
972 * keyboard.c (interrupt_signal): Don't call kill-emacs when
973 waiting for input. (Bug#10169)
975 2011-11-30 Eli Zaretskii <eliz@gnu.org>
977 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
978 verifies glyph row's hash code--we have just reallocated the
979 glyphs, so their contents can be complete garbage. (Bug#10164)
981 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
983 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
985 2011-11-30 Eli Zaretskii <eliz@gnu.org>
987 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
988 attributes are tested _before_ calling verify_row_hash, to protect
989 against GCC re-ordering of the tests. (Bug#10164)
991 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
993 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
995 * xterm.c (handle_one_xevent): Only set async_visible and friends
996 if net_wm_state_hidden_seen is non-zero (Bug#10002)
997 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
998 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1000 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1002 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1003 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1004 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1005 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1006 All uses changed to use GCPRO1 etc.
1007 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1008 Revert to old implementation (i.e., before 2011-03-11).
1010 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1012 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1013 of scroll runs so as to avoid assigning disabled bogus rows and
1014 unnecessary graphics copy operations.
1016 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1018 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1019 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1020 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1021 (malloc, free, realloc, calloc): Redirect to e_* only when
1024 * lisp.h (GCTYPEBITS): Move before first use.
1025 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1026 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1027 this macro definition.
1029 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1032 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1034 * gtkutil.c (xg_create_frame_widgets):
1035 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1036 present with Gtk+ 2.0.
1038 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1040 * fileio.c (Finsert_file_contents): Undo previous change; see
1041 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1043 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1045 Rename locals to avoid shadowing.
1046 * fileio.c (Finsert_file_contents):
1047 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1048 * process.c (wait_reading_process_output):
1049 Rename inner 'proc' to 'p' to avoid shadowing.
1050 Indent for consistency with usual Emacs style.
1052 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1054 * xdisp.c (redisplay_window): If cursor row is not fully visible
1055 after recentering, and scroll-conservatively is set to a large
1056 number, scroll window by a few more lines to make the cursor fully
1057 visible and out of scroll-margin. (Bug#10105)
1058 (start_display): Don't move to the next line if the display should
1059 start at a newline that is part of a display vector or an overlay
1062 2011-11-24 Juri Linkov <juri@jurta.org>
1064 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1065 after the `MagickPingImage' call. (Bug#10112)
1067 2011-11-23 Chong Yidong <cyd@gnu.org>
1069 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1071 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1073 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1074 making another buffer current. (Bug#10114)
1076 2011-11-23 Glenn Morris <rgm@gnu.org>
1078 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1080 2011-11-23 Chong Yidong <cyd@gnu.org>
1082 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1083 using it (Bug#5984).
1085 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1087 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1088 and header-lines, as they don't have one computed for them.
1091 * .gdbinit (prow): Make displayed values more self-explaining.
1092 Add row's hash code.
1094 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1096 * process.c (wait_reading_process_output): Fix asynchrounous
1097 GnuTLS socket handling on some versions of the GnuTLS library.
1098 (wait_reading_process_output): Add comment and URL.
1100 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1102 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1104 2011-11-21 Chong Yidong <cyd@gnu.org>
1106 * window.c (Fnext_window, Fprevious_window): Doc fix.
1108 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1110 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1112 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1114 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1116 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1118 * window.c (Fset_window_combination_limit): Rename argument
1120 (Vwindow_combination_limit): Remove "status" from doc-string.
1122 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1124 * m/ibms390.h: Remove.
1125 * m/ibms390x.h: Don't include "ibms390.h".
1127 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1129 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1130 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1132 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1134 * casetab.c (Fset_case_table):
1135 * charset.c (Fcharset_after): Fix typos.
1137 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1139 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1140 Otherwise, valgrind does not work on some platforms.
1141 Problem reported by Andreas Schwab in
1142 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1143 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1144 is set, removing the need for VIRT_ADDRESS_VARIES.
1145 (PURE_P): Use a more-efficient implementation that needs just one
1146 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1147 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1148 to 4 (xorl, subq, cmpq, setbe).
1149 * alloc.c (pure): Always extern now, since that's the
1150 VIRT_ADDR_VARIES behavior.
1151 (PURE_POINTER_P): Use a single comparison, not two, for
1152 consistency with the new puresize.h.
1153 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1154 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1155 Remove VIRT_ADDR_VARIES no longer needed.
1157 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1159 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1160 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1161 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1162 behave as if the cursor position were at the window margin.
1164 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1165 and the cursor position is out of bounds, behave as if the cursor
1166 position were at the window margin. (Bug#10075)
1168 2011-11-18 Chong Yidong <cyd@gnu.org>
1170 * window.c (Fwindow_combination_limit): Make first argument
1171 non-optional, since it is meaningless for live windows like the
1174 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1176 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1178 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1180 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1181 (graft_intervals_into_buffer): Simplify.
1183 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1185 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1186 hash values of the two rows.
1187 (copy_row_except_pointers): Preserve the used[] arrays and the
1188 hash values of the two rows. (Bug#10035)
1189 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1191 * xdisp.c (row_hash): New function, body extracted from
1192 compute_line_metrics.
1193 (compute_line_metrics): Call row_hash, instead of computing the
1196 * dispnew.c (verify_row_hash): Call row_hash for computing the
1197 hash code of a row, instead of duplicating code from xdisp.c.
1199 * dispextern.h (row_hash): Add prototype.
1201 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1203 * frame.c (delete_frame): Don't delete the terminal when the last
1204 X frame is closed if emacs is built with GTK toolkit.
1206 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1208 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1210 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1212 * window.c (Vwindow_splits): Rename to
1213 Vwindow_combination_resize. Suggested by Juri Linkov.
1214 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1217 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1219 * nsfns.m (Fns_font_name):
1220 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1222 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1224 * window.h (window): Rename slot "nest" to "combination_limit".
1225 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1226 (Fset_window_nest): Rename to Fset_window_combination_limit.
1227 (Vwindow_nest): Rename to Vwindow_combination_limit.
1228 (recombine_windows, make_parent_window, make_window)
1229 (Fsplit_window_internal, saved_window)
1230 (Fset_window_configuration, save_window_save): Rename all
1231 occurrences of window_nest to window_combination_limit.
1233 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1235 * image.c (imagemagick_load_image): Fix typo.
1237 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1239 * xdisp.c (display_line): Move the call to
1240 highlight_trailing_whitespace before the call to
1241 compute_line_metrics, since the latter needs to see the final
1242 faces of all the glyphs to compute ROW's hash value.
1243 Fixes assertion violations in row_equal_p. (Bug#10035)
1245 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1247 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1248 just return (bug#10044).
1250 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1252 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1253 with user-defined heap size. Bump the default size of the temacs
1254 heap to 27MB, to avoid memory warning when running temacs.
1255 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1257 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1258 current_matrix and desired_matrix. (Bug#9990)
1259 (verify_row_hash) [XASSERTS]: New function.
1260 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1261 that the hash value of glyph rows is correct.
1263 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1265 * window.h (window): Remove splits slot.
1266 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1267 (Fdelete_other_windows_internal, make_parent_window)
1268 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1269 (Fset_window_configuration, save_window_save): Don't deal with
1270 split status of windows.
1271 (saved_window): Remove splits slot.
1272 (Vwindow_splits): Rewrite doc-string.
1274 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1276 * xfns.c (unwind_create_frame):
1277 * nsfns.m (unwind_create_frame):
1278 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1279 Vframe_list (Bug#9999).
1281 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1283 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1285 2011-11-11 Kenichi Handa <handa@m17n.org>
1287 * callproc.c (Fcall_process): Set the member dst_multibyte of
1290 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1292 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1293 avoid a crash (bug#9496).
1295 2011-11-09 Chong Yidong <cyd@gnu.org>
1297 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1298 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1300 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1302 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1304 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1306 Avoid some portability problems by eschewing 'extern inline' functions.
1307 The trivial performance wins aren't worth the portability hassles; see
1308 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1310 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1311 (window_box_width, window_box_left, window_box_left_offset)
1312 (window_box_right, window_box_right_offset): Undo previous change,
1313 by removing the "extern"s.
1314 * intervals.c (adjust_intervals_for_insertion)
1315 (adjust_intervals_for_deletion): Undo previous change,
1316 making these static again.
1317 (offset_intervals, temp_set_point_both, temp_set_point)
1318 (copy_intervals_to_string): No longer inline.
1319 * xdisp.c (window_text_bottom_y, window_box_width)
1320 (window_box_height, window_box_left_offset)
1321 (window_box_right_offset, window_box_left, window_box_right)
1322 (window_box): No longer inline.
1324 2011-11-08 Chong Yidong <cyd@gnu.org>
1326 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1327 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1328 Signal an error if not a live window.
1329 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1330 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1332 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1334 * lisp.h (syms_of_abbrev): Remove declaration.
1335 Reported by CHENG Gao <chenggao@royau.me>.
1337 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1339 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1340 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1341 of temacs in GUI mode.
1343 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1345 * window.h: Declare delete_all_child_windows instead of
1346 delete_all_subwindows.
1347 * window.c (Fwindow_nest, Fset_window_nest)
1348 (Fset_window_new_total, Fset_window_new_normal)
1349 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1350 (delete_all_subwindows): Rename to delete_all_child_windows.
1351 (Fdelete_other_windows_internal, Fset_window_configuration):
1352 Call delete_all_child_windows instead of delete_all_subwindows.
1353 * frame.c (delete_frame): Call delete_all_child_windows instead
1354 of delete_all_subwindows.
1356 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1358 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1359 This is also needed for porting to any host where GC_MARK_STACK is
1360 not GC_MAKE_GCPROS_NOOPS.
1361 (which_symbols): Use it.
1363 2011-11-07 Kenichi Handa <handa@m17n.org>
1365 * coding.c (coding_set_destination): Check coding->src_pos only
1366 when coding->src_object is a buffer (bug#9910).
1368 * process.c (send_process): Set the member src_multibyte of coding
1369 to 0 (bug#9911) when sending a unibyte text.
1371 * callproc.c (Fcall_process): Set the member src_multibyte of
1372 process_coding to 0 (bug#9912).
1374 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1376 * xmenu.c (cleanup_widget_value_tree): New function.
1377 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1378 calling free_menubar_widget_value_tree directly (Bug#9830).
1380 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1382 Fix some portability problems with 'inline'.
1383 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1384 (window_box_width, window_box_left, window_box_left_offset)
1385 (window_box_right, window_box_right_offset): Declare extern.
1386 Otherwise, these inline functions do not conform to C99 and
1387 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1388 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1389 * intervals.c (adjust_intervals_for_insertion)
1390 (adjust_intervals_for_deletion): Now extern, because otherwise the
1391 extern inline functions 'offset_intervals' couldn't refer to it.
1392 (static_offset_intervals): Remove.
1393 (offset_intervals): Rewrite using the old contents of
1394 static_offset_intervals. The old version didn't conform to C99
1395 because an extern inline function contained a reference to an
1396 identifier with static linkage.
1398 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1400 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1403 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1405 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1406 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1407 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1408 return Qleft_to_right.
1410 2011-11-06 Chong Yidong <cyd@gnu.org>
1412 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1413 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1414 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1415 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1416 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1417 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1418 (Fwindow_vscroll): Doc fix.
1419 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1420 argument, since it makes no sense to pass a live window and for
1421 consistency with window-child.
1423 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1425 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1428 2011-11-05 Jason Rumney <jasonr@gnu.org>
1430 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1431 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1433 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1434 bitwise arithmetic preventing use of unicode-sip and non-truetype
1437 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1439 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1442 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1443 initialization code to keep similarity to xfns.c after changes
1446 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1448 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1449 (unwind_create_frame): New function (Bug#9943).
1450 (Fx_create_frame): Restructure code to be more similar to the one in
1451 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1452 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1453 Move terminal->reference_count++ just before making the frame official
1456 * nsterm.m (x_free_frame_resources): New function.
1457 (x_destroy_window): Move code to x_free_frame_resources.
1459 * xfns.c (unwind_create_frame): Fix comment.
1460 (Fx_create_frame, x_create_tip_frame):
1461 Move terminal->reference_count++ just before making the frame
1462 official. Move initialization of image_cache_refcount and
1463 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1465 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1467 Support MSVC build with newer versions of Visual Studio.
1468 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1469 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1472 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1473 which are not supported by MSVC.
1474 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1475 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1477 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1479 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1481 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1483 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1485 Support MSVC build with newer versions of Visual Studio.
1486 * w32.c: Don't include w32api.h for MSVC.
1487 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1489 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1490 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1491 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1492 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1494 (alloca) [_MSC_VER]: Define to _alloca.
1496 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1498 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1500 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1502 * xdisp.c (note_mouse_highlight): If either of
1503 previous/next-single-property-change returns nil, treat that as
1504 the beginning or the end of the buffer. (Bug#9955)
1506 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1508 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1509 label is not null (Bug#9951).
1510 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1513 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1515 * window.c (Fwindow_body_size): Mention in the doc string that the
1516 return value is in frame's canonical units. (Bug#9949)
1518 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1520 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1522 * w32fns.c (unwind_create_frame): If needed, free the glyph
1523 matrices of the partially constructed frame. (Bug#9943)
1524 * xfns.c (unwind_create_frame): Likewise.
1526 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1528 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1529 Don't stop backward scan on the continuation glyph, even though
1530 its CHARPOS is positive.
1531 (mouse_face_from_buffer_pos, note_mouse_highlight):
1532 Rename cover_string to disp_string.
1534 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1536 * window.c (temp_output_buffer_show): Don't use
1537 Vtemp_buffer_show_specifiers.
1538 (Vtemp_buffer_show_specifiers): Remove unused variable.
1540 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1542 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1543 past the beginning of the current glyph matrix.
1545 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1547 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1548 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1549 HAVE_GTK3 (Bug#9869).
1551 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1552 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1554 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1556 * xterm.c: Declare x_handle_net_wm_state to return int.
1557 (handle_one_xevent): Check if we are iconified but don't have
1558 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1559 (get_current_wm_state): Return non-zero if not hidden,
1560 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1561 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1562 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1563 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1565 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1567 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1568 so that this new function doesn't get optimized away by a
1569 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1571 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1573 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1575 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1577 Fix the `xbytecode' command.
1578 * .gdbinit (xprintbytestr): New command.
1579 (xwhichsymbols): Rename from `which'; all callers changed.
1580 (xbytecode): Print the byte-code string as well.
1582 2011-10-29 Kim Storm <storm@cua.dk>
1584 * alloc.c (which_symbols): New function.
1586 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1588 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1591 2011-10-29 Glenn Morris <rgm@gnu.org>
1593 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1594 Not clear what it was for, and it causes various bugs. (Bug#9839)
1596 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1598 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1599 possible random value that matches one of those tested as
1600 condition to clear the mouse face.
1602 2011-10-28 Chong Yidong <cyd@gnu.org>
1604 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1606 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1608 * window.c (make_window): Initialize phys_cursor_on_p.
1610 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1612 * lisp.h (struct Lisp_Symbol): Update comments.
1614 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1616 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1618 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1620 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1621 <oslsachem@gmail.com> for helping to debug this.
1623 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1624 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1625 (g_b_init_get_glyph_outline_w): New static variables.
1626 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1627 (GetGlyphOutlineW_Proc): New typedefs.
1628 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1629 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1631 (w32font_open_internal, compute_metrics):
1632 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1633 instead of calling the "wide" APIs directly.
1635 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1637 * w32.h (syms_of_w32font): Add prototype.
1639 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1641 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1642 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1643 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1644 (Fmove_to_window_line): Doc fix.
1646 2011-10-27 Chong Yidong <cyd@gnu.org>
1648 * process.c (make_process): Set gnutls_state to NULL.
1650 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1651 non-NULL, regardless of GNUTLS_INITSTAGE.
1652 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1653 an error. Set process slots as soon as we allocate them.
1655 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1657 2011-10-27 Chong Yidong <cyd@gnu.org>
1659 * gnutls.c (emacs_gnutls_deinit): New function.
1660 Deallocate credentials structures as well as calling gnutls_deinit.
1661 (Fgnutls_deinit, Fgnutls_boot): Use it.
1663 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1664 (deactivate_process): Call emacs_gnutls_deinit.
1666 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1668 * image.c (x_create_x_image_and_pixmap):
1669 * w32.c (sys_rename, w32_delayed_load):
1670 * w32font.c (fill_in_logfont):
1671 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1673 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1675 * w32fns.c (w32_default_color_map): New function,
1676 extracted from Fw32_default_color_map.
1677 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1679 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1681 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1683 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1685 * keyboard.c (test_undefined): New function (bug#9751).
1686 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1688 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1690 * sysdep.c (init_sys_modes): Fix the check for the controlling
1691 terminal (Bug#6649).
1693 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1695 * dispextern.h (struct bidi_it): New member next_en_type.
1697 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1698 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1699 current character, check also for next_en_type being WEAK_EN.
1700 (bidi_resolve_weak): Don't enter the expensive loop if the current
1701 position is before next_en_pos. Record the bidi type of the first
1702 non-ET, non-BN character we find, in addition to its position.
1703 (bidi_level_of_next_char): Invalidate next_en_type when
1704 next_en_pos is over-stepped.
1706 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1708 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1709 * editfns.c: Rewrite current-time-zone so that it invokes
1710 the equivalent of (format-time-string "%Z") to get the time zone name.
1711 This fixes a bug when the time zone name contains characters that
1712 need converting from the system time locale to Emacs internal format.
1713 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1714 that patch fixed format-time-string to do the conversion, but
1715 I forgot to fix current-time-zone.
1716 (format_time_string): New function, containing most of
1717 what Fformat_time_string used to contain.
1718 (Fformat_time_string): Rewrite in terms of format_time_string.
1719 This doesn't change this function's behavior.
1720 (current-time-zone): Rewrite to use format_time_string.
1721 This fixes the bug reported by Michael Schierl in
1722 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1723 Jason Rumney's 2007-06-07 change worked around this bug, but
1725 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1727 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1729 * xdisp.c (start_display): If the character at POS is displayed
1730 via a display vector, reset IT->current.dpvec_index to zero.
1731 (try_window_reusing_current_matrix): If a line ends in a display
1732 vector or the next line starts in a display vector, continue
1733 redrawing the window even though the character position of
1734 start_row was reached.
1737 2011-10-18 Chong Yidong <cyd@gnu.org>
1739 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1740 with nobreak-char-display too.
1742 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1744 Fix part 3 of bug#9771.
1745 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1746 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1747 non-neutral characters if the current character is a paragraph
1748 separator (a.k.a. Newline). This avoids running the same
1749 expensive loop twice, once when we consume the preceding newline
1750 and the other time when the line actually needs to be displayed.
1751 Avoid the loop when we see neutrals on the base embedding level
1752 following a character whose directionality is the same as the
1753 paragraph's. This avoids running the expensive loop when a line
1754 ends in a long sequence of neutrals, like control characters.
1755 Add assertion against STRONG_AL type. Slightly rearrange code
1756 that determines the type of a neutral given the first non-neutral
1758 (bidi_level_of_next_char): Set next_en_pos to zero when
1759 invalidating its info.
1761 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1763 * xdisp.c (push_display_prop): Determine whether to record string
1764 or buffer position by IT->string, not by IT->method. Allow
1765 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1766 (move_it_vertically_backward): Don't look for character position
1767 immediately after the newline when in a continuation line.
1770 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1772 * window.c (coordinates_in_window): Rewrite and delabelize
1773 vertical border check. (Bug#5357) (Bug#9618)
1775 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1777 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1778 errors in XSetWindowBorder (bug#9310).
1780 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1782 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1783 avoid crash when xmalloc overrun checking is enabled.
1785 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1787 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1788 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1789 cursor motion with <left> and <right> arrow keys.
1791 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1792 some callers set that themselves.
1794 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1796 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1797 display string and the previous row comes from the same string and
1798 is empty. (Bug#9739) (Bug#9738)
1800 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1802 * doc.c (get_doc_string): Encode file name (bug#9735).
1804 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1806 * bidi.c (bidi_level_of_next_char):
1807 * xdisp.c (get_visually_first_element): Remove old incorrect
1808 comments regarding the Unicode Line Separator character.
1810 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1812 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1814 * alloc.c (Fgc_status): Do not access beyond zombies array
1815 boundary if nzombies > MAX_ZOMBIES.
1816 * alloc.c (dump_zombies): Add missing format specifier.
1818 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1820 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1821 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1823 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1824 Some packages use them to denote characters with modifiers.
1826 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1828 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1829 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1830 matching a pp-number. Rename parameter var to var1.
1832 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1834 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1836 2011-10-08 Glenn Morris <rgm@gnu.org>
1838 * callint.c (Fcall_interactively): Give a more explicit error for the
1839 'c' case with a non-character input. (Bug#8479)
1841 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1843 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1845 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1846 lines that are hscrolled on the left.
1848 * dispnew.c (buffer_posn_from_coords): Account for a possible
1849 presence of header-line. (Bug#4426)
1851 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1853 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1854 Don't advertise functionality which we discourage or doesn't work.
1856 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1858 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1859 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1860 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1861 this makes Emacs dump core during garbage collection on rare
1862 occasions. sizeof is obviously inferior to offsetof here, so
1863 stick with offsetof.
1864 (GC_POINTER_ALIGNMENT): New macro.
1865 (mark_memory): Omit 3rd (offset) arg; caller changed.
1866 Don't assume EMACS_INT alignment is the same as pointer alignment.
1868 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1870 * keyboard.c (read_key_sequence_remapped): New var.
1871 (read_key_sequence): Compute remapping in the right buffer.
1872 (command_loop_1): Use read_key_sequence's remapping directly.
1874 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1876 * dired.c (file_name_completion): Don't expand file name.
1877 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1878 before checking file name handler.
1880 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1881 they've been requested explicitly (bug#9591).
1883 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1885 * keymap.c (Fsingle_key_description): Use make_specified_string
1886 instead of build_string to build string from push_key_description.
1889 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1891 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1892 This fixes a Y2038 bug on 64-bit hosts.
1893 * buffer.c (reset_buffer):
1894 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1895 (Fclear_buffer_auto_save_failure):
1896 Use 0, not -1, to represent an unset failure time, since time_t
1897 might not be signed.
1899 Remove dependency on glibc malloc internals.
1900 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1901 Move back here from lisp.h, but with their new implementations.
1902 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1903 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1904 * charset.c (charset_table_init): New static var.
1905 (syms_of_charset): Use it instead of xmalloc. This removes a
1906 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1907 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1908 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1909 Move back to alloc.c.
1910 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1911 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1913 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1915 * nsterm.m (windowDidResize): Call x_set_window_size only when
1916 ns_in_resize is true. Otherwise set pixelwidth/height and
1917 call change_frame_size (Bug#9628).
1919 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1921 Port --enable-checking=all to Fedora 14 x86-64.
1922 * charset.c (syms_of_charset): Also account for glibc malloc's
1923 internal overhead when calculating the initial malloc maximum.
1925 Port --enable-checking=all to Fedora 14 x86.
1926 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1928 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1929 (overrun_check_realloc, overrun_check_free):
1930 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1931 That way, xmalloc returns a properly-aligned pointer even if
1932 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1933 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1934 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1935 into account when calculating the initial malloc maximum.
1936 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1937 Move here from alloc.c, so that charset.c can use it too.
1938 Properly align; the old code wasn't right for common 32-bit hosts
1939 when configured with --enable-checking=all.
1940 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1941 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1943 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1945 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1948 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1950 * xdisp.c (compute_display_string_end): If there's no display
1951 string at CHARPOS, return -1.
1953 * bidi.c (bidi_fetch_char): When compute_display_string_end
1954 returns a negative value, treat the character as a normal
1955 character not covered by a display string. (Bug#9624)
1957 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1959 * lread.c (Fread_from_string): Fix typo in docstring.
1961 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1963 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1964 newline, reseat the iterator instead of bidi-iterating there one
1965 character at a time. (Bug#9610)
1966 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1967 TO_CHARPOS if the bidi iterator is at base embedding level.
1969 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1971 * lread.c (readevalloop): Use correct code for NBSP.
1972 (read1): Likewise. (Bug#9608)
1974 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1976 * dbusbind.c (Fdbus_register_signal): When service is not
1977 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1979 2011-09-25 Glenn Morris <rgm@gnu.org>
1981 * buffer.c (truncate-lines): Doc fix.
1983 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1985 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1986 (Fset_window_next_buffers): Doc fix.
1988 2011-09-24 Glenn Morris <rgm@gnu.org>
1990 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1992 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1994 Fix minor problems found by static checking.
1995 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1996 * indent.c (Fvertical_motion): Fix == vs = typo.
1998 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2000 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2001 Default value is now t. Doc fix.
2003 * indent.c (Fvertical_motion): Compute and apply the overshoot
2004 logic when moving up, not only when moving down. Fix the
2005 confusing name and values of the it_overshoot_expected variable;
2006 logic changes accordingly. (Bug#9254) (Bug#9549)
2008 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2009 CHARPOS is covered by a display string which includes newlines.
2010 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2011 is covered by a display string with embedded newlines.
2013 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2015 * dbusbind.c (Fdbus_register_signal): Add match rule to
2016 Vdbus_registered_objects_table. (Bug#9581)
2017 (Fdbus_register_method, Vdbus_registered_objects_table):
2020 2011-09-24 Jim Meyering <meyering@redhat.com>
2022 do not ignore write error for any output size
2023 The previous change was incomplete.
2024 While it makes emacs --batch detect the vast majority of stdout
2025 write failures, errors were still ignored whenever the output size is
2026 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2027 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2028 && echo FAIL: ignored write error
2029 FAIL: ignored write error
2030 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2031 && echo FAIL: ignored write error
2032 FAIL: ignored write error
2033 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2035 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2037 * emacs.c (Fkill_emacs): In noninteractive mode exit
2038 non-successfully if a write error occurred on stdout. (Bug#9574)
2040 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2042 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2045 * dispextern.h (struct it): Update the comment documenting what
2048 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2050 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2051 a display string, extend search for cursor position to end of row.
2052 (find_row_edges): If the row ends in a newline from a display
2053 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2054 Handle the case of a display string with multiple newlines.
2055 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2056 non-empty line. Fixes confusing cursor motion with arrow keys at
2057 the beginning of a line that starts with whitespace.
2059 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2061 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2064 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2066 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2069 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2071 * xdisp.c (display_line): Record maximum and minimum buffer
2072 positions even if no glyphs were produced (e.g., by a zero-width
2073 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2074 buffer positions that will be removed from the glyph row because
2076 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2077 column is beyond frame width: don't subtract 1 "pixel" when
2078 computing width of the stretch.
2079 (reseat_at_next_visible_line_start): Undo the change made on
2080 2011-09-17 that saved paragraph information and restored it after
2081 the call to `reseat'. (Bug#9545)
2083 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2085 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2086 and turn window cursor on if cleared (Bug#9415).
2088 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2090 * search.c (boyer_moore): Take unibyte characters from pattern
2091 literally. (Bug#9458)
2093 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2095 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2097 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2099 Fix minor problem found by static checking.
2100 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2101 initialized, to pacify gcc -Wuninitialized.
2103 * fileio.c: Report proper errno when syscall falls.
2104 (Finsert_file_contents): Save and restore errno,
2105 so that report_file_error outputs the correct diagnostic.
2106 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2108 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2110 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2112 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2114 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2115 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2117 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2119 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2120 about the current paragraph and restore it after the call to reseat.
2122 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2123 (bidi_find_paragraph_start): Search back for paragraph beginning
2124 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2125 (bidi_move_to_visually_next): Only trigger paragraph-related
2126 computations when the last character is a newline or at EOB, not
2127 just any NEUTRAL_B. (Bug#9470)
2129 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2130 truncated lines if point is covered by a display string. (Bug#9524)
2132 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2134 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2135 (cons_to_x_long): New function.
2136 (lisp_data_to_selection_data): Use it. Correct the test for
2137 short-versus-long data; it was negated. Break out of vector
2138 loop, for efficiency, when a long datum is discovered.
2140 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2142 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2144 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2146 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2147 GCC PR/17406) by declaring this function with external scope.
2149 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2151 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2152 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2154 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2156 * editfns.c (Fformat): Correctly handle text properties on "%%".
2158 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2160 * xterm.c (x_draw_composite_glyph_string_foreground):
2161 * w32term.c (x_draw_composite_glyph_string_foreground):
2162 * term.c (encode_terminal_code):
2163 * composite.c (composition_update_it, get_composition_id):
2164 * xdisp.c (get_next_display_element)
2165 (fill_composite_glyph_string): Add comments about special meaning
2166 of TAB characters in a composition.
2168 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2170 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2171 This occurs when processing a multibyte format.
2172 Problem reported by Wolfgang Jenker.
2174 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2176 * xdisp.c (try_cursor_movement): Only check for exact match if
2177 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2179 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2181 Remove unused external symbols.
2182 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2183 * xdisp.c (calc_pixel_width_or_height): Now static.
2184 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2185 * indent.c (check_display_width):
2186 * w32term.c: Fix comment to match code.
2187 * xterm.c, xterm.h (x_catching_errors): Remove.
2189 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2191 * xselect.c: Use signed conversions more consistently (Bug#9498).
2192 (selection_data_to_lisp_data): Assume incoming selection data are
2193 signed integers, not unsigned. This is to be consistent with
2194 outgoing selection data, which was modified to use signed integers
2195 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2196 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2197 expects long, not unsigned long.
2199 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2201 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2202 computation of loop end. Reported by Johan Bockgård
2205 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2207 * frame.c (Fother_visible_frames_p): Function deleted.
2209 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2211 * indent.c (compute_motion): Process display vector front to back
2212 rather than the other way around. (Bug#2496)
2214 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2216 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2218 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2220 * minibuf.c (Fread_from_minibuffer): Doc fix.
2222 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2224 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2225 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2227 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2229 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2230 value for non-existent files.
2232 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2234 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2235 set its "size" to -1. This will set the modtime_size field of
2236 the corresponding buffer to -1, which is what
2237 verify-visited-file-modtime expects for files that do not exist.
2240 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2242 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2244 * lisp.h: ... from here. push_key_description is no longer
2245 defined in keyboard.c, so its declaration should not be in
2246 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2247 logically belongs with push_key_description.
2249 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2251 * buffer.h: Include <sys/types.h> instead of <time.h>.
2252 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2253 Problem reported by Herbert J. Skuhra.
2255 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2257 * xml.c (parse_region): Make the parsing work for
2258 non-comment-starting XML files again (bug#9144).
2260 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2262 * image.c (gif_load): Fix calculation of bottom and right corner.
2265 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2267 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2268 redisplay in small windows.
2270 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2272 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2274 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2276 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2277 Operate on live windows only.
2279 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2281 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2283 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2285 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2286 only under bidi iteration.
2288 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2290 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2292 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2294 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2295 Without this fix, the command to link temacs failed due to an
2296 undefined symbol __builtin_isnan. This is because
2297 /usr/include/iso/math_c99.h #defines isnan(x) to
2298 __builtin_isnan(x), but the bundled gcc, which identifies itself
2299 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2301 * floatfns.c (isnan): #undef, and then #define to a clone of
2303 (Fisnan): Always define, since it's always available now.
2304 (syms_of_floatfns): Always define isnan at the Lisp level.
2306 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2308 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2310 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2312 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2313 The previous code assumed that file offsets (off_t values) fit in
2314 EMACS_INT variables, which is not true on typical 32-bit hosts.
2315 The code messed up by falsely reporting buffer overflow in cases
2316 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2317 when "big" contains more than 2**29 bytes, even though this
2318 inserts just one byte and does not overflow the buffer.
2319 (Finsert_file_contents): Store file offsets as off_t
2320 values, not as EMACS_INT values. Check for overflow when
2321 converting between EMACS_INT and off_t. When checking for
2322 buffer overflow or for overlap, take the offsets into account.
2323 Don't use EMACS_INT for small values where int suffices.
2324 When checking for overlap, fix a typo: ZV was used where
2325 ZV_BYTE was intended.
2326 (Fwrite_region): Don't assume off_t fits into 'long'.
2327 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2329 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2331 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2333 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2335 sprintf-related integer and memory overflow issues (Bug#9412).
2337 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2338 (esprintf, exprintf, evxprintf): New functions.
2339 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2340 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2341 (modify_event_symbol): Do not assume that the length of
2342 name_alist_or_stem is safe to alloca and fits in int.
2343 (Fexecute_extended_command): Likewise for function name and binding.
2344 (Frecursion_depth): Wrap around reliably on integer overflow.
2345 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2346 since some callers pass EMACS_INT values.
2347 (Fsingle_key_description): Don't crash if symbol name contains more
2348 than MAX_ALLOCA bytes.
2349 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2350 (get_minibuffer): Arg is now EMACS_INT, not int.
2351 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2352 (esprintf, exprintf, evxprintf): New decls.
2353 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2355 * dbusbind.c (signature_cat): New function.
2356 (xd_signature, Fdbus_register_signal):
2357 Do not overrun buffer; instead, report string overflow.
2359 * dispnew.c (add_window_display_history): Don't overrun buffer.
2360 Truncate instead; this is OK since it's just a log.
2362 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2363 even if the time zone offset is outlandishly large.
2364 Don't mishandle offset == INT_MIN.
2366 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2367 when creating daemon; the previous buffer-overflow check was incorrect.
2369 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2370 which has the guts of the old verror function.
2372 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2373 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2375 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2376 (font_unparse_xlfd): Don't blindly alloca long strings.
2377 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2378 fits in int, when using sprintf. Use single snprintf to count
2379 length of string rather than counting it via multiple sprintfs;
2380 that's simpler and more reliable.
2381 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2382 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2383 sprintf, in case result does not fit in int.
2385 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2386 (fontset_from_font): Print it.
2388 * frame.c (tty_frame_count): Now printmax_t, not int.
2389 (make_terminal_frame, set_term_frame_name): Print it.
2390 (x_report_frame_params): In X, window IDs are unsigned long,
2391 not signed long, so print them as unsigned.
2392 (validate_x_resource_name): Check for implausibly long names,
2393 and don't assume name length fits in 'int'.
2394 (x_get_resource_string): Don't blindly alloca invocation name;
2395 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2398 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2399 (xg_check_special_colors, xg_set_geometry):
2400 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2402 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2403 Use esprintf, not sprintf, in case result does not fit in int.
2405 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2406 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2407 it as a large positive number.
2408 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2409 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2411 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2412 in case result does not fit in int.
2414 * print.c (float_to_string): Detect width overflow more reliably.
2415 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2416 buffer overrun. Don't assume list length fits in 'int'. Treat
2417 print length of 0 as 0, not as infinity; to be consistent with other
2418 uses of print length in this function. Don't overflow print length
2419 index. Don't assume hash table size fits in 'long', or that
2420 vectorlike size fits in 'unsigned long'.
2422 * process.c (make_process): Use printmax_t, not int, to format
2423 process-name gensyms.
2425 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2427 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2428 to avoid potential buffer overrun.
2430 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2431 if X resource line is longer than 512 bytes.
2433 * xfns.c (x_window): Make sprintf buffer a bit bigger
2434 to avoid potential buffer overrun.
2436 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2438 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2440 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2442 Integer overflow fixes for scrolling, etc.
2443 Without these, Emacs silently mishandles large integers sometimes.
2444 For example, "C-u 4294967297 M-x recenter" was treated as if
2445 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2447 * xdisp.c (try_window_id): Check Emacs fixnum range before
2448 converting to 'int'.
2450 * window.c (window_scroll_line_based, Frecenter):
2451 Check that an Emacs fixnum is in range before assigning it to 'int'.
2452 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2453 values converted from Emacs fixnums.
2454 (Frecenter): Don't wrap around a line count if it is out of 'int'
2455 range; instead, treat it as an extreme value.
2456 (Fset_window_configuration, compare_window_configurations):
2457 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2459 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2460 that can exceed INT_MAX. Check that EMACS_INT value is in range
2461 before assigning it to the (possibly-narrower) index.
2462 (match_limit): Don't assume that a fixnum can fit in 'int'.
2464 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2467 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2468 (Fvertical_motion): Don't wrap around LINES values that don't fit
2469 in 'int'. Instead, treat them as extreme values. This is good
2470 enough for windows, which can't have more than INT_MAX lines anyway.
2472 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2474 * Require libxml/parser.h to avoid compilation warning.
2476 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2478 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2479 since this reportedly can destroy thread storage.
2481 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2483 * syntax.c (find_defun_start): Update all cache variables if
2484 exiting early (Bug#9401).
2486 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2488 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2490 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2491 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2492 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2494 * term.c (tty_append_glyph): New function.
2495 (produce_stretch_glyph): Static function and its prototype deleted.
2497 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2500 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2502 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2503 when checking :margin (Bug#9390).
2504 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2505 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2506 so that the name doesn't mislead. All uses changed.
2508 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2510 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2513 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2515 * xdisp.c (move_it_to): Don't bail out early when reaching
2516 position beyond to_charpos, if we are scanning backwards.
2517 (move_it_vertically_backward): When DY == 0, make sure we get to
2518 the first character in the line after the newline.
2520 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2522 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2523 (ccl_driver): Do not generate an out-of-range pointer.
2524 (Fccl_execute_on_string): Remove unnecessary check for
2525 integer overflow, noted by Stefan Monnier in
2526 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2527 Remove a FIXME that didn't need fixing.
2528 Simplify the newly-introduced buffer reallocation code.
2530 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2532 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2534 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2536 Integer and memory overflow issues (Bug#9196).
2538 * doc.c (get_doc_string): Rework so that
2539 get_doc_string_buffer_size is the actual buffer size, rather than
2540 being 1 less than the actual buffer size; this makes xpalloc more
2543 * image.c (x_allocate_bitmap_record, cache_image):
2544 * xselect.c (Fx_register_dnd_atom):
2545 Simplify previous changes by using xpalloc.
2547 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2548 since either will do and ptrdiff_t is convenient with xpalloc.
2550 * charset.c (charset_table_size)
2551 (struct charset_sort_data.priority): Now ptrdiff_t.
2552 (charset_compare): Don't overflow if priorities differ greatly.
2553 (Fsort_charsets): Don't assume list length fits in int.
2554 Check for size-calculation overflow when allocating sort data.
2555 (syms_of_charset): Allocate an initial charset table that is
2556 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2558 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2560 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2561 The actual value is always <= INT_MAX, and leaving it unsigned made
2562 overflow checking harder.
2564 * dispextern.h (struct glyph_matrix.rows_allocated)
2565 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2566 with xpalloc. The values are still always <= INT_MAX.
2568 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2570 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2571 (SAFE_NALLOCA): New macro.
2573 * region-cache.c (struct boundary.pos, find_cache_boundary)
2574 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2575 (set_cache_region, invalidate_region_cache)
2576 (revalidate_region_cache, know_region_cache, region_cache_forward)
2577 (region_cache_backward, pp_cache):
2578 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2579 so that ptrdiff_t * can be passed to xpalloc.
2580 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2581 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2582 (pp_cache): Don't assume cache_len fits in int.
2583 * region-cache.h: Adjust extern decls to match.
2585 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2586 EMACS_INT, since either will do, for xpalloc.
2588 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2589 (xnmalloc, xnrealloc, xpalloc): New functions.
2591 * bidi.c (bidi_shelve_header_size): New constant.
2592 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2593 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2595 * bidi.c (bidi_cache_shrink):
2596 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2598 Don't update size of array until after memory allocation succeeds,
2599 because xmalloc/xrealloc may not return.
2600 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2601 now that we have proper integer overflow checking.
2602 (record_overlay_string, overlay_strings): Catch overflows when
2603 calculating size of overlay_str_buf.
2605 * callproc.c (Fcall_process): Check for size overflow when
2606 calculating size of args2.
2607 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2608 Normally we prefer signed values, but sticking with ptrdiff_t would
2609 require adding more-complicated checks.
2611 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2612 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2613 Redo buffer-overflow calculations to avoid integer overflow.
2614 Add a FIXME comment where memory seems to be over-allocated.
2616 * character.c (Fstring): Check for size-calculation overflow.
2618 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2619 unnecessary integer overflow. Check for size overflow.
2620 (encode_coding_object): Don't update size until xmalloc succeeds.
2622 * composite.c (get_composition_id): Check for overflow in glyph
2623 length calculations.
2625 Integer and memory overflow fixes for display code.
2626 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2627 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2628 (scrolling_window): Check for overflow in size calculations.
2629 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2630 Don't assume glyph table len fits in int.
2631 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2632 (row_table_size): Now ptrdiff_t, not int.
2633 (scrolling_window): Avoid overflow in size calculations.
2634 Don't update size until allocation succeeds.
2635 * fns.c (concat): Check for overflow in size calculations.
2636 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2637 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2638 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2640 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2641 (get_doc_string): Check for size calculation overflow.
2642 Don't update size until allocation succeeds.
2643 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2644 EMACS_INT, where ptrdiff_t will do.
2645 (Fsubstitute_command_keys): Check for string overflow.
2647 * editfns.c (set_time_zone_rule): Don't assume environment length
2649 (message_length): Now ptrdiff_t, not int.
2650 (Fmessage_box): Don't update size until allocation succeeds.
2651 Don't assume message length fits in int.
2652 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2654 * emacs.c (main): Do not reallocate argv, since there is a null at
2655 the end that can be overwritten, and this way there's no need to
2656 worry about size-calculation overflow.
2657 (sort_args): Check for size-calculation overflow.
2659 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2661 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2663 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2664 (x_set_scroll_bar_width, x_figure_window_size):
2665 Check for integer overflow.
2666 (x_set_alpha): Do not assume XINT fits in int.
2668 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2669 This is for the members text_lines, text_cols, total_lines, total_cols,
2670 where the system imposes an 'int' limit.
2672 * fringe.c (Fdefine_fringe_bitmap):
2673 Don't update size until alloc works.
2675 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2676 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2678 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2679 Check for size-calculation overflow.
2680 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2681 do, as we prefer signed integers.
2682 (id_to_widget.max_size, id_to_widget.used)
2683 (xg_store_widget_in_map, xg_remove_widget_from_map)
2684 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2685 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2686 Use and return ptrdiff_t, not int.
2687 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2688 * gtkutil.h: Change prototypes to match the above.
2690 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2691 are duplicate now that they've been promoted to lisp.h.
2692 (x_allocate_bitmap_record, x_alloc_image_color)
2693 (make_image_cache, cache_image, xpm_load):
2694 Don't update size until alloc is done.
2695 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2697 Check for size calculation overflow.
2698 (ct_colors_allocated_max): New constant.
2699 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2702 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2703 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2704 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2705 Use ptrdiff_t, not int, to count maps.
2706 (read_char_minibuf_menu_prompt): Check for overflow in size
2707 calculations. Don't update size until allocation succeeds.
2708 Redo calculations to avoid overflow.
2709 * keyboard.h: Change prototypes to match the above.
2711 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2713 (current_minor_maps): Check for size calculation overflow.
2714 * keymap.h: Change prototypes to match the above.
2716 * lread.c (read1, init_obarray): Don't update size until alloc done.
2718 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2719 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2721 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2722 Now ptrdiff_t, not int.
2723 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2724 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2726 * process.c (Fnetwork_interface_list): Check for overflow
2727 in size calculation.
2729 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2731 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2732 overflow. Don't bother calling xmalloc when xrealloc will do.
2734 * search.c (Freplace_match): Check for size calculation overflow.
2735 (Fset_match_data): Don't assume list lengths fit in 'int'.
2737 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2738 for command line length. Do not attempt to address one before the
2739 beginning of an array, as that's not portable.
2741 * term.c (max_frame_lines): Remove; unused.
2742 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2744 (encode_terminal_code, calculate_costs): Check for size
2745 calculation overflow.
2746 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2747 table lengths and related sizes. Don't update size until alloc
2748 done. Redo calculations to avoid overflow.
2749 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2751 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2752 subtracting pointers.
2753 (gobble_line): Check for overflow more carefully. Don't update size
2756 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2757 Don't update size until alloc done.
2758 Redo size calculations to avoid overflow.
2759 Check for size calculation overflow.
2760 (main) [DEBUG]: Fix typo in invoking tparam1.
2762 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2763 Use ptrdiff_t, not int, for sizes.
2764 (store_mode_line_noprop_char): Don't update size until alloc done.
2766 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2767 Use ptrdiff_t, not int, for sizes.
2768 (Finternal_make_lisp_face, cache_face):
2769 Check for size calculation overflow.
2770 (cache_face): Treat size calculation overflows as if they were
2771 memory exhaustion (the usual treatment), rather than aborting.
2773 * xfns.c (x_encode_text, x_set_name_internal)
2774 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2775 sizes, since they can exceed INT_MAX in size. Check for size
2776 calculation overflow.
2778 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2779 (xg_select): Check for size calculation overflow.
2780 Don't update size until alloc done.
2782 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2783 as sprintf is limited to int lengths.
2785 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2786 (X_LONG_MIN): New macros.
2787 Use them to make the following changes clearer.
2788 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2789 This change doesn't affect the value now, but it may help remind
2790 future maintainers not to raise the value too much later.
2791 (SELECTION_QUANTUM): Remove, replacing with ...
2792 (selection_quantum): ... new function, which avoids overflow.
2794 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2795 assumption that selection length fits in 'int'.
2796 (x_reply_selection_request, x_handle_selection_request)
2797 (x_get_window_property, receive_incremental_selection)
2798 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2799 (lisp_data_to_selection_data, clean_local_selection_data):
2800 Use ptrdiff_t, not int, to record length of selection.
2801 (x_reply_selection_request, x_get_window_property)
2802 (receive_incremental_selection, x_property_data_to_lisp):
2803 Redo calculations to avoid overflow.
2804 (x_reply_selection_request): When sending hint, ceiling it at
2805 X_LONG_MAX rather than relying on wraparound overflow to send
2807 (x_get_window_property, receive_incremental_selection)
2808 (lisp_data_to_selection_data, x_property_data_to_lisp):
2809 Check for size-calculation overflow.
2810 (x_get_window_property, receive_incremental_selection)
2811 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2812 Don't store size until memory allocation succeeds.
2813 (x_get_window_property): Plug memory leak on memory exhaustion.
2814 Don't double-block input; malloc is safe here. Don't assume 2**34
2815 - 4 fits in unsigned long. Add an xassert to check
2816 XGetWindowProperty overflow. Be more careful about overflow
2817 calculations, and distinguish size from memory overflow better.
2818 (receive_incremental_selection): When tracing, don't assume
2819 unsigned int is less than INT_MAX.
2820 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2821 harmful) conversions of unsigned short to int.
2822 (lisp_data_to_selection_data): Don't assume that integers
2823 in the range -65535 through -1 fit in an X unsigned short.
2824 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2825 result parameters unless successful. Rely on cons_to_unsigned
2826 to report problems with elements; the old code wasn't right anyway.
2827 (x_check_property_data): Check for int overflow; we cannot use
2828 a wider type due to X limits.
2829 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2831 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2833 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2834 (x_term_init): Check for size calculation overflow.
2835 (x_color_cells): Don't store size until memory allocation succeeds.
2836 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2837 Don't assume alloca size is less than MAX_ALLOCA.
2838 (x_term_init): Don't assume length fits in int (sprintf is limited
2841 Use ptrdiff_t for composition IDs.
2842 * character.c (lisp_string_width):
2843 * composite.c (composition_table_size, n_compositions)
2844 (get_composition_id, composition_gstring_from_id):
2845 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2846 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2847 * window.c (Frecenter):
2848 Use ptrdiff_t, not int, for composition IDs.
2849 * composite.c (get_composition_id): Check for integer overflow.
2850 * composite.h: Adjust prototypes to match the above changes.
2852 Use ptrdiff_t for hash table indexes.
2853 * category.c (hash_get_category_set):
2854 * ccl.c (ccl_driver):
2855 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2856 * coding.c (coding_system_charset_list, detect_coding_system):
2857 * coding.h (struct coding_system.id):
2858 * composite.c (get_composition_id, gstring_lookup_cache):
2859 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2860 * image.c (xpm_get_color_table_h):
2861 * lisp.h (hash_lookup, hash_put):
2862 * minibuf.c (Ftest_completion):
2863 Use ptrdiff_t for hash table indexes, not int (which is too
2864 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2865 32-bit --with-wide-int hosts).
2867 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2868 Add a FIXME comment about memory leaks.
2869 (syms_of_charset): Don't assume xmalloc returns.
2871 Don't assume that stated character widths fit in int.
2872 * character.c (Fchar_width, c_string_width, lisp_string_width):
2873 * character.h (CHAR_WIDTH):
2874 * indent.c (MULTIBYTE_BYTES_WIDTH):
2875 Use sanitize_char_width to avoid undefined and/or bad behavior
2876 with outlandish widths.
2877 * character.h (sanitize_tab_width): Rename from sanitize_width,
2878 now that we have two such functions. All uses changed.
2879 (sanitize_char_width): New inline function.
2881 Don't assume that tab-width fits in int.
2882 * character.h (sanitize_width): New inline function.
2883 (SANE_TAB_WIDTH): New macro.
2884 (ASCII_CHAR_WIDTH): Use it.
2885 * indent.c (sane_tab_width): Remove. All uses replaced by
2886 SANE_TAB_WIDTH (current_buffer).
2887 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2889 * fileio.c: Integer overflow issues with file modes.
2890 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2892 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2893 Remove unreachable code.
2894 (read_hex, load_charset_map_from_file): Check for integer overflow.
2896 * xterm.c: Don't go over XClientMessageEvent limit.
2897 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2898 (x_send_scroll_bar_event): Likewise. Check that the size does not
2899 exceed limits imposed by XClientMessageEvent, as well as the usual
2900 ptrdiff_t and size_t limits.
2902 * keyboard.c: Overflow, signedness and related fixes.
2903 (make_lispy_movement): Use same integer type in forward decl
2904 that is used in the definition.
2905 (read_key_sequence, keyremap_step):
2906 Change bufsize argument back to int, undoing my 2011-03-30 change.
2907 We prefer signed types, and int is wide enough here.
2908 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2909 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2910 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2911 length, not size_t. Use ptrdiff_t for index, not int.
2912 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2913 possibility of integer overflow.
2915 Overflow, signedness and related fixes for images.
2917 * dispextern.h (struct it.stack[0].u.image.image_id)
2918 (struct_it.image_id, struct image.id, struct image_cache.size)
2919 (struct image_cache.used, struct image_cache.ref_count):
2920 * gtkutil.c (update_frame_tool_bar):
2921 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2922 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2923 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2924 * nsmenu.m (update_frame_tool_bar):
2925 * xdisp.c (calc_pixel_width_or_height):
2926 * xfns.c (image_cache_refcount):
2927 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2928 on typical 64-bit hosts.
2930 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2931 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2932 Omit unnecessary casts to int.
2933 (parse_image_spec): Check that integers fall into 'int' range
2934 when the callers expect that.
2935 (image_ascent): Redo ascent calculation to avoid int overflow.
2936 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2937 (lookup_image): Remove unnecessary tests.
2938 (xbm_image_p): Locals are now of int, not EMACS_INT,
2939 since parse_image_check makes sure they fit into int.
2940 (png_load, gif_load, svg_load_image):
2941 Prefer int to unsigned where either will do.
2942 (tiff_handler): New function, combining the cores of the
2943 old tiff_error_handler and tiff_warning_handler.
2944 This function is rewritten to use vsnprintf and thereby avoid
2945 stack buffer overflows. It uses only the features of vsnprintf
2946 that are common to both POSIX and native Microsoft.
2947 (tiff_error_handler, tiff_warning_handler): Use it.
2948 (tiff_load, gif_load, imagemagick_load_image):
2949 Don't assume :index value fits in 'int'.
2950 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2951 (imagemagick_load_image): Check that crop parameters fit into
2952 the integer types that MagickCropImage accepts. Don't assume
2953 Vimagemagick_render_type has a nonnegative value. Don't assume
2954 size_t fits in 'long'.
2955 (gs_load): Use printmax_t to print the widest integers possible.
2956 Check for integer overflow when computing image height and width.
2958 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2960 * xdisp.c (redisplay_window): Don't force window start if point
2961 will be invisible in the resulting window. (Bug#9324)
2963 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2965 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2966 the display spec is of the form `(space ...)'.
2967 (handle_display_spec): Return the value returned by
2968 handle_single_display_spec, not just 1 or zero.
2969 (handle_single_display_spec): If the display spec is of the form
2970 `(space ...)', and specifies display in the text area, return 2
2972 (try_cursor_movement): Check for the need to scroll more
2973 accurately, and prefer exact match for point under bidi.
2974 Don't advance `row' beyond the last row of the window.
2976 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2977 into disp_prop; all users changed.
2979 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2980 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2981 for the text covered by the display property.
2983 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2985 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2986 Change return value to nil.
2987 (Frecord_buffer): Delete unused function.
2989 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2991 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2992 buffers, return left-to-right.
2993 (set_cursor_from_row): Consider candidate row a win if its glyph
2994 represents a newline and point is on that newline. Fixes cursor
2995 positioning on the newline at EOL of R2L text within L2R
2996 paragraph, and vice versa.
2997 (try_cursor_movement): Check continued rows, in addition to
2998 continuation rows. Fixes unwarranted scroll when point enters a
2999 continued line of R2L text within an L2R paragraph, or vice versa.
3000 (cursor_row_p): Consider the case of point being equal to
3001 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3002 from the end of a short line to the beginning of a continued line
3003 of R2L text within L2R paragraph.
3004 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3005 composed characters.
3007 * bidi.c (bidi_check_type): Use xassert.
3008 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3011 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3013 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3016 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3018 * nsfont.m (ns_otf_to_script): Fix typo.
3020 2011-08-22 Kenichi Handa <handa@m17n.org>
3022 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3023 extra slot even if the purpose is char-code-property-table.
3025 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3027 * xdisp.c (redisplay_window): When computing centering_position,
3028 account for the height of the header line. (Bug#8874)
3030 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3031 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3032 candidate is selected by the mouse, and that candidate has a
3033 composed character under the mouse.
3035 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3036 coordinates reported by pos-visible-in-window-p for a composed
3037 character in column zero.
3039 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3041 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3043 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3045 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3046 consider it a hit if to_charpos is anywhere in the range of the
3047 composed buffer positions.
3049 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3051 * image.c (gif_load): Don't assume that each subimage has the same
3052 dimensions as the base image. Handle disposal method that is
3053 "undefined" by the gif spec (Bug#9335).
3055 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3057 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3058 (Fcondition_case): Document `debug' symbol in error handler.
3060 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3062 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3063 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3064 from an Org mode buffer to a Speedbar frame.
3066 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3067 a composition, take its buffer position from IT->cmp_it.charpos.
3068 Fixes cursor positioning at the beginning of a line that begins
3069 with a composed character.
3071 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3073 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3074 character bidirectional type, use STRONG_L instead. Fixes crashes
3075 in a buffer produced by `describe-categories'.
3077 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3078 members before the level stack, so they would be saved and
3079 restored when copying iterator state. Fixes incorrect reordering
3080 around TABs covered by display properties.
3082 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3084 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3086 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3088 * eval.c (internal_condition_case, internal_condition_case_1)
3089 (internal_condition_case_2, internal_condition_case_n):
3090 Remove unnecessary aborts (Bug#9081).
3092 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3094 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3095 has no `load' handler, try opening the file locally. (Bug#9311)
3097 2011-08-16 Ken Brown <kbrown@cornell.edu>
3099 * gmalloc.c: Expand comment.
3101 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3103 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3104 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3106 2011-08-16 Ken Brown <kbrown@cornell.edu>
3108 Fix memory allocation problems in Cygwin build (Bug#9273).
3110 * unexcw.c ( __malloc_initialized): Declare external variable.
3111 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3113 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3115 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3117 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3119 [CYGWIN] (special_realloc): New function.
3120 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3121 requests to realloc storage in the static heap.
3123 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3125 * bidi.c (bidi_initialize): Remove unused local.
3127 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3130 * biditype.h: Remove file.
3131 * makefile.w32-in ($(BLD)/bidi.$(O)):
3132 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3134 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3136 * chartab.c: Improve commentary for the uniprop_table API.
3138 * bidi.c (bidi_paragraph_init): Support zero value of
3139 bidi_ignore_explicit_marks_for_paragraph_level.
3140 (bidi_initialize): Use uniprop_table instead of including
3141 biditype.h and bidimirror.h.
3143 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3144 coordinates of the iterator when restoring from ppos_it.
3147 2011-08-14 Kenichi Handa <handa@m17n.org>
3149 * process.c (create_process): Call setup_process_coding_systems
3150 after the pid of the process is set to -1 (Bug#8162).
3152 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3154 * xdisp.c (move_it_in_display_line_to): Don't invoke
3155 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3156 ppos_it. Fixes vertical cursor motion when line beginning is
3157 covered by an image. (Bug#9296)
3159 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3161 * nsterm.h (ns_run_ascript): Declare.
3162 (NSAPP_DATA2_RUNASSCRIPT): Define.
3164 * nsfns.m (as_script, as_result, as_status): New static variables.
3165 (ns_run_ascript): New function.
3166 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3167 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3168 the event loop. Get status from as_status (Bug#7276).
3170 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3171 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3172 the event loop (Bug#7276).
3174 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3176 * gnutls.c (QCgnutls_bootprop_priority)
3177 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3178 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3179 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3180 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3181 (QCgnutls_bootprop_verify_hostname_error)
3182 (QCgnutls_bootprop_callbacks_verify): Rename from
3183 Qgnutls_bootprop_..., all uses changed.
3185 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3188 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3190 * xfaces.c (Qframe_set_background_mode): Now static.
3191 * dispextern.h (Qframe_set_background_mode): Remove decl.
3193 * process.c (Fnetwork_interface_info): Declare local only if needed.
3195 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3197 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3198 (Fnetwork_interface_list): Allocate in increments of bytes instead
3199 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3200 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3202 (struct ifflag_def): notrailers is smart on OSX.
3203 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3204 Get hardware address with getifaddrs if available.
3206 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3208 * xdisp.c (iterate_out_of_display_property): xassert that
3209 IT->position is set to within IT->object's boundaries. Break from
3210 the loop as soon as EOB is reached; avoids infloops in redisplay
3211 when IT->position is set up wrongly due to some bug.
3212 Set IT->current to match the bidi iterator unconditionally.
3213 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3214 entry. Force push_it to save on the stack the current
3215 buffer/string position, to be restored by pop_it. Fix flags in
3216 the iterator structure wrt the object coming from a display
3217 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3218 properties. (Bug#9284)
3220 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3222 * fontset.c (fontset_get_font_group): Add proper type checks.
3225 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3227 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3228 and LC_VERSION_MIN_MACOSX.
3229 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3230 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3232 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3234 * xdisp.c (forward_to_next_line_start): Allow to use the
3235 no-display-properties-and-no-overlays under bidi display.
3236 Set disp_pos in the bidi iterator to avoid searches for display
3237 properties and overlays.
3239 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3241 * editfns.c (Fset_time_zone_rule): Document relationship with the
3244 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3245 the font entity extracted from the cache (Bug#8109).
3247 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3249 * composite.c (autocmp_chars): Don't reset point. That is done by
3250 restore_point_unwind (Bug#5984).
3252 2011-08-07 Juri Linkov <juri@jurta.org>
3254 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3255 to show the arg `TIME' instead of `TIMEVAL'.
3257 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3259 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3260 display property strides EOL and includes a newline, as in
3261 longlines-mode. (Bug#9254)
3262 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3263 word-wrap under bidirectional display. (Bug#9224)
3265 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3266 is non-zero, even if the data buffer is NULL. Fixes a crash in
3267 vertical-motion with longlines-mode. (Bug#9254)
3269 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3271 * bidi.c <bidi_cache_total_alloc>: Now static.
3272 (bidi_initialize): Initialize bidi_cache_total_alloc.
3274 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3277 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3278 amount allocated this far in `bidi_cache_total_alloc'.
3279 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3280 non-zero, only free the data buffer without restoring the cache
3281 contents. All callers changed.
3283 * dispextern.h (bidi_unshelve_cache): Update prototype.
3285 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3286 (move_it_in_display_line, move_it_to)
3287 (move_it_vertically_backward, move_it_by_lines): Replace the call
3288 to xfree to an equivalent call to bidi_unshelve_cache.
3289 (move_it_in_display_line_to): Fix logic of returning
3290 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3292 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3294 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3295 came from a string character with a `cursor' property. (Bug#9229)
3297 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3299 * Makefile.in (LIB_PTHREAD): New variable.
3300 (LIBES): Add LIB_PTHREAD (Bug#9216).
3302 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3303 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3305 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3307 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3309 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3311 * xterm.c (x_find_topmost_parent): New function.
3312 (x_set_frame_alpha): Find topmost parent window with
3313 x_find_topmost_parent and set the property there also (bug#9181).
3314 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3316 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3318 * callproc.c (Fcall_process): Avoid vfork clobbering
3319 the local vars buffer, coding_systems, current_dir.
3321 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3323 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3325 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3327 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3328 so that it is not optimized away.
3330 * xdisp.c (compute_display_string_pos): Remove unused local.
3332 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3334 Fix slow cursor motion and scrolling in large buffers with
3335 selective display, like Org Mode buffers. (Bug#9218)
3337 * dispextern.h (struct bidi_it): New member disp_prop_p.
3339 * xdisp.c: Remove one-slot cache of display string positions.
3340 (compute_display_string_pos): Accept an additional argument
3341 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3342 for a display string or property. If found, set DISP_PROP_P
3345 * bidi.c (bidi_fetch_char): Accept an additional argument
3346 DISP_PROP_P, and pass it to compute_display_string_pos.
3347 Only handle text covered by a display string if DISP_PROP_P is returned
3348 non-zero. All callers of bidi_fetch_char changed.
3350 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3352 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3354 2010-12-03 Don March <don@ohspite.net>
3356 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3357 last character M-[char] is translated to ESC [char] (bug#7541).
3359 2011-08-02 Kenichi Handa <handa@m17n.org>
3361 * lisp.h (uniprop_table): Extern it.
3363 * chartab.c (uniprop_table): Make it non-static.
3365 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3367 * xdisp.c (forward_to_next_line_start): Accept additional argument
3368 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3370 (reseat_at_next_visible_line_start): Use the bidi iterator state
3371 returned by forward_to_next_line_start to restore the state of
3372 it->bidi_it after backing up to previous newline. (Bug#9212)
3374 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3376 * regex.c (re_comp): Protoize.
3377 (re_exec): Fix return type.
3378 (regexec): Fix type of `ret'. (Bug#9203)
3380 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3382 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3383 This is needed if max-image-size is a floating-point number.
3385 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3387 * print.c (print_object): Print empty symbol as ##.
3389 * lread.c (read1): Read ## as empty symbol.
3391 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3393 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3394 setting frame foreground color (Bug#9175).
3395 (x_set_background_color): Likewise.
3397 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3398 contents (Bug#9176).
3399 (EmacsTooltip -init): Remove bezels and add shadows to
3402 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3403 or scroll bar (Bug#8470).
3405 * nsfont.m (nsfont_open): Remove assignment to voffset and
3406 unnecessary vars hshink, expand, hd, full_height, min_height.
3407 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3409 * nsterm.h (nsfont_info): Remove voffset field.
3411 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3413 Implement strike-through and overline on NextStep (Bug#8863).
3415 * nsfont.m (nsfont_open): Use underline position provided by font,
3416 instead of hard-coded value of 2.
3417 (nsfont_draw): Call ns_draw_text_decoration instead.
3419 * nsterm.h: Add declaration for ns_draw_text_decoration.
3421 * nsterm.m (ns_draw_text_decoration): New function for drawing
3422 underline, overline, and strike-through.
3423 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3424 ns_draw_text_decoration. Change treatment of cursor drawing to
3425 accommodate underlining, etc.
3427 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3429 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3432 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3434 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3435 Without this fix, if a signal arrives just after memory fills up,
3436 'malloc' might be invoked reentrantly.
3438 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3439 In other words, assume that every image size is allowed, on non-X
3440 hosts. This assumption is probably wrong, but it lets Emacs compile.
3442 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3444 * regex.c (re_iswctype): Convert return values to boolean.
3446 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3448 * xdisp.c (compute_display_string_pos): Don't use cached display
3449 string position if the buffer had its restriction changed.
3452 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3454 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3456 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3458 Integer signedness and overflow and related fixes. (Bug#9079)
3460 * bidi.c: Integer size and overflow fixes.
3461 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3462 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3463 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3464 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3465 (bidi_find_other_level_edge):
3466 Use ptrdiff_t instead of EMACS_INT where either will do.
3467 This works better on 32-bit hosts configured --with-wide-int.
3468 (bidi_cache_ensure_space): Check for size-calculation overflow.
3469 Use % rather than repeated addition, for better worst-case speed.
3470 Don't set bidi_cache_size until after xrealloc returns, because it
3472 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3473 (bidi_cache_ensure_space): Also check that the bidi cache size
3474 does not exceed that of the largest Lisp string or buffer. See Eli
3475 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3477 * alloc.c (__malloc_size_t): Remove.
3478 All uses replaced by size_t. See Andreas Schwab's note
3479 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3481 * image.c: Improve checking for integer overflow.
3482 (check_image_size): Assume that f is nonnull, since
3483 it is always nonnull in practice. This is one less thing to
3484 worry about when checking for integer overflow later.
3485 (x_check_image_size): New function, which checks for integer
3486 overflow issues inside X.
3487 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3488 This removes the need for a memory_full check.
3489 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3490 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3491 (xbm_read_bitmap_data): Change locals back to 'int', since
3492 their values must fit in 'int'.
3493 (xpm_load_image, png_load, tiff_load):
3494 Invoke x_create_x_image_and_pixmap earlier,
3495 to avoid much needless work if the image is too large.
3496 (tiff_load): Treat overly large images as if
3497 x_create_x_image_and_pixmap failed, not as malloc failures.
3498 (gs_load): Use x_check_image_size.
3500 * gtkutil.c: Omit integer casts.
3501 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3502 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3504 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3506 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3507 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3508 would wrongly return t on a 64-bit host.
3510 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3511 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3512 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3513 and therefore cause GCC to emit a bogus diagnostic in some cases.
3515 * image.c: Integer signedness and overflow and related fixes.
3516 This is not an exhaustive set of fixes, but it's time to
3517 record what I've got.
3518 (lookup_pixel_color, check_image_size): Remove redundant decls.
3519 (check_image_size): Don't assume that arbitrary EMACS_INT values
3520 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3521 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3522 (tiff_load, imagemagick_load_image):
3523 Check for overflow in size calculations.
3524 (x_create_x_image_and_pixmap): Remove unnecessary test for
3525 xmalloc returning NULL; that can't happen.
3526 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3527 (xpm_color_bucket): Use better integer hashing function.
3528 (xpm_cache_color): Don't possibly over-allocate memory.
3529 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3530 (gif_memory_source):
3531 Use ptrdiff_t, not int or size_t, to record sizes.
3532 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3533 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3534 either works, as we prefer signed integers.
3535 (tiff_read_from_memory, tiff_write_from_memory):
3536 Return tsize_t, not size_t, since that's what the TIFF API wants.
3537 (tiff_read_from_memory): Don't fail simply because the read would
3538 go past EOF; instead, return a short read.
3539 (tiff_load): Omit no-longer-needed casts.
3540 (Fimagemagick_types): Don't assume size fits into 'int'.
3542 Improve hashing quality when configured --with-wide-int.
3543 * fns.c (hash_string): New function, taken from sxhash_string.
3544 Do not discard information about ASCII character case; this
3545 discarding is no longer needed.
3546 (sxhash-string): Use it. Change sig to match it. Caller changed.
3547 * lisp.h: Declare it.
3548 * lread.c (hash_string): Remove, since we now use fns.c's version.
3549 The fns.c version returns a wider integer if --with-wide-int is
3550 specified, so this should help the quality of the hashing a bit.
3552 * emacs.c: Integer overflow minor fix.
3553 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3554 Define only if GNU_LINUX.
3555 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3557 * dispnew.c: Integer signedness and overflow fixes.
3558 Remove unnecessary forward decls, that were a maintenance hassle.
3559 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3561 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3562 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3563 (prepare_desired_row, line_draw_cost):
3564 Use int, not unsigned, where either works.
3565 (save_current_matrix, restore_current_matrix):
3566 Use ptrdiff_t, not size_t, where either works.
3567 (init_display): Check for overflow more accurately, and without
3568 relying on undefined behavior.
3570 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3571 Remove, replacing with the new symbols in lisp.h. All uses changed.
3572 * fileio.c (make_temp_name):
3573 * filelock.c (lock_file_1, lock_file):
3574 * xdisp.c (message_dolog):
3575 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3576 Use pMd etc. instead.
3577 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3578 replacing the pWIDE etc. symbols removed from editfns.c.
3580 * keyboard.h (num_input_events): Now uintmax_t.
3581 This is (very slightly) less likely to mess up due to wraparound.
3584 * buffer.c: Integer signedness fixes.
3585 (alloc_buffer_text, enlarge_buffer_text):
3586 Use ptrdiff_t rather than size_t when either will do, as we prefer
3589 * alloc.c: Integer signedness and overflow fixes.
3590 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3591 (__malloc_size_t): Default to size_t, not to int.
3592 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3593 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3594 Prefer ptrdiff_t to size_t when either would do, as we prefer
3596 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3597 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3598 Now const. Initialize with values that are in range even if char
3600 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3601 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3602 These functions do the right thing with sizes > 2**32.
3603 (check_depth): Now ptrdiff_t, not int.
3604 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3605 Adjust to new way of storing sizes. Check for size overflow bugs
3607 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3608 slightly wrong anyway, as it missed one instance of
3609 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3610 (refill_memory_reserve): Omit needless cast to size_t.
3611 (mark_object_loop_halt): Mark as externally visible.
3613 * xselect.c: Integer signedness and overflow fixes.
3614 (Fx_register_dnd_atom, x_handle_dnd_message):
3615 Use ptrdiff_t, not size_t, since we prefer signed.
3616 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3617 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3618 x_dnd_atoms_size and x_dnd_atoms_length.
3620 * doprnt.c: Prefer signed to unsigned when either works.
3622 * doprnt.c (doprnt):
3624 * xdisp.c (vmessage):
3625 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3626 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3627 prefer signed arithmetic to avoid comparison confusion.
3628 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3629 but is a bit tricky.
3631 Assume freestanding C89 headers, string.h, stdlib.h.
3632 * data.c, doprnt.c, floatfns.c, print.c:
3633 Include float.h unconditionally.
3634 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3635 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3636 * regex.c: Likewise for stddef.h, string.h.
3637 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3638 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3639 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3640 (STDC_HEADERS): Remove obsolete defines.
3641 * sysdep.c: Include limits.h unconditionally.
3643 Assume support for memcmp, memcpy, memmove, memset.
3644 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3645 * regex.c (memcmp, memcpy):
3646 Remove; we assume C89 now.
3648 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3649 (__malloc_safe_bcopy): Remove; no longer needed.
3651 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3652 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3653 well either way, and we prefer signed to unsigned.
3655 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3657 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3658 closes the connection while we're reading (bug#9182).
3660 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3662 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3663 are specified (Bug#9168).
3665 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3667 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3668 Found by GCC static checking and --with-wide-int on a 32-bit host.
3670 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3672 * xdisp.c (compute_display_string_pos): Fix logic of caching
3673 previous display string position. Initialize cached_prev_pos to
3674 -1. Fixes slow-down at the beginning of a buffer.
3676 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3678 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3679 for attrs[LFACE_FONTSET_INDEX].
3681 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3683 * xml.c (parse_region): Remove unused local
3684 that was recently introduced.
3686 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3688 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3689 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3691 * xdisp.c (move_it_in_display_line_to): Record the best matching
3692 position for TO_CHARPOS while scanning the line, and restore it on
3693 exit if none of the characters scanned was an exact match.
3694 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3695 when exact match is impossible due to invisible text, and the
3696 lines are truncated.
3698 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3700 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3703 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3705 Fix a significant slow-down of cursor motion with C-n, C-p,
3706 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3707 auto-repeat under bidi redisplay in fontified buffers.
3708 * xdisp.c (compute_stop_pos_backwards): New function.
3709 (next_element_from_buffer): Call compute_stop_pos_backwards to
3710 find a suitable prev_stop when we find ourselves before
3712 (reseat): Don't look for prev_stop, as that could mean a very long
3714 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3715 <cached_disp_overlay_modiff>: Cache for last found display string
3717 (compute_display_string_pos): Return the cached position if asked
3718 about the same buffer in the same area of character positions, and
3719 the buffer wasn't changed since the time the display string
3720 position was cached.
3722 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3724 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3725 is an integer, which is important for empty lines. (Bug#9149)
3727 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3729 * frame.c (Fmodify_frame_parameters): In tty case, update the
3730 default face if necessary (Bug#4238).
3732 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3734 * editfns.c (Fstring_to_char): No need to explain what a character
3735 is in the docstring (Bug#6576).
3737 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3739 * xml.c (parse_region): Make sure we always return a tree.
3741 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3743 * xml.c (parse_region): If a document contains only comments,
3746 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3748 * xml.c (make_dom): Return comments, too.
3750 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3753 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3754 and the surrounding thread.
3755 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3756 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3757 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3759 * s/openbsd.h (BROKEN_SIGIO): Define.
3760 * unexelf.c (unexec) [__OpenBSD__]:
3761 Don't update the .mdebug section of the Alpha COFF symbol table.
3763 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3765 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3768 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3770 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3771 This fixes some race conditions on the permissions of any newly
3774 * alloc.c (valid_pointer_p): Use pipe, not open.
3775 This fixes some permissions issues when debugging.
3777 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3778 If fchown fails to set both uid and gid, try to set just gid,
3779 as that is sometimes allowed. Adjust the file's mode to eliminate
3780 setuid or setgid bits that are inappropriate if fchown fails.
3782 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3784 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3785 to compare Lisp_Objects.
3786 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3787 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3788 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3790 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3792 * lread.c (read_integer): Unread even EOF character.
3793 (read1): Likewise. Properly record start position of symbol.
3795 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3796 symbol character follows.
3798 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3800 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3801 This works around a problem with the previous change to Fcopy_file.
3802 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3803 and without this change, GCC might complain about discarding
3804 fchown's return value.
3806 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3808 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3810 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3812 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3814 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3816 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3817 it's used from the C level.
3819 * process.c: Use the same condition for POLL_FOR_INPUT in both
3820 keyboard.c and process.c (bug#1858).
3822 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3824 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3825 (Fgnutls_boot): Use it.
3827 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3829 * doc.c (Fsubstitute_command_keys): Revert last change.
3831 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3833 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3834 quotes the next character, and doesn't affect other longer
3835 sequences (bug#8935).
3837 * lread.c (syms_of_lread): Clarify that is isn't only
3838 `eval-buffer' and `eval-defun' that's affected by
3839 `lexical-binding' (bug#8460).
3841 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3843 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3844 bidi redisplay when a line includes both an image and is truncated.
3846 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3848 Fix minor problems found by static checking.
3849 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3850 (elsz): Now a signed constant, not a size_t var. We prefer signed
3851 types to unsigned, to avoid integer comparison confusion. Without
3852 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3853 "cannot optimize loop, the loop counter may overflow", a symptom
3855 * indent.c (Fvertical_motion): Mark locals as initialized.
3856 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3858 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3860 * search.c (Fre_search_backward): Mention `case-fold-search' in
3861 all the re_search_* functions (bug#8138).
3863 * keyboard.c (Fopen_dribble_file): Document when the file is
3866 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3868 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3871 Support bidi reordering of display and overlay strings.
3872 * xdisp.c (compute_display_string_pos)
3873 (compute_display_string_end): Accept additional argument STRING.
3874 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3875 (reseat_to_string): Initialize bidi_it->string.s and
3876 bidi_it->string.schars.
3877 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3878 NULL (avoids a crash in bidi_paragraph_init).
3879 Initialize itb.string.lstring.
3880 (init_iterator): Call bidi_init_it only of a valid
3881 buffer position was specified. Initialize paragraph_embedding to
3883 (reseat_to_string): Initialize the bidi iterator.
3884 (display_string): If we need to ignore text properties of
3885 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3886 original value of -1 will not work with bidi.)
3887 (compute_display_string_pos): First arg is now struct
3888 `text_pos *'; all callers changed. Support display properties on
3890 (compute_display_string_end): Support display properties on Lisp
3892 (init_iterator, reseat_1, reseat_to_string): Initialize the
3893 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3894 when iterating on a string not from display properties).
3895 (compute_display_string_pos, compute_display_string_end):
3896 Fix calculation of the object to scan. Fixes an error when using
3898 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3899 base_level_stop; instead, set base_level_stop to BEGV.
3900 Fixes crashes in vertical-motion.
3901 (next_element_from_buffer): Improve commentary for when
3902 the iterator is before prev_stop.
3903 (init_iterator): Initialize bidi_p from the default value of
3904 bidi-display-reordering, not from buffer-local value. Use the
3905 buffer-local value only if initializing for buffer iteration.
3906 (handle_invisible_prop): Support invisible properties on strings
3907 that are being bidi-reordered.
3908 (set_iterator_to_next): Support bidi reordering of C strings and
3910 (next_element_from_string): Support bidi reordering of Lisp
3912 (handle_stop_backwards): Support Lisp strings as well.
3913 (display_string): Support display of R2L glyph rows.
3914 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3915 (init_iterator): Don't initialize it->bidi_p for strings
3917 (reseat_to_string): Initialize it->bidi_p for strings here.
3918 (next_element_from_string, next_element_from_c_string)
3919 (next_element_from_buffer): Add xassert's for correspondence
3920 between IT's object being iterated and it->bidi_it.string
3922 (face_before_or_after_it_pos): Support bidi iteration.
3923 (next_element_from_c_string): Handle the case of the first string
3924 character that is not the first one in the visual order.
3925 (get_visually_first_element): New function, refactored from common
3926 parts of next_element_from_buffer, next_element_from_string, and
3927 next_element_from_c_string.
3928 (tool_bar_lines_needed, redisplay_tool_bar)
3929 (display_menu_bar): Force left-to-right direction. Add a FIXME
3930 comment for making that be controlled by a user option.
3931 (push_it, pop_it): Save and restore the state of the
3932 bidi iterator. Save and restore the bidi_p flag.
3933 (pop_it): Iterate out of display property for string iteration as
3935 (iterate_out_of_display_property): Support iteration over strings.
3936 (handle_single_display_spec): Set up it->bidi_it for iteration
3937 over a display string, and call bidi_init_it.
3938 (handle_single_display_spec, next_overlay_string)
3939 (get_overlay_strings_1, push_display_prop): Set up the bidi
3940 iterator for displaying display or overlay strings.
3941 (forward_to_next_line_start): Don't use the shortcut if
3943 (back_to_previous_visible_line_start): If handle_display_prop
3944 pushed the iterator stack, restore the internal state of the bidi
3945 iterator by calling bidi_pop_it same number of times.
3946 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3947 and we are bidi-iterating, don't decrement the iterator position;
3948 instead, set the first_elt flag in the bidi iterator, to produce
3950 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3951 (push_display_prop): xassert that we are iterating a buffer.
3952 (push_it, pop_it): Save and restore paragraph_embedding member.
3953 (handle_single_display_spec, next_overlay_string)
3954 (get_overlay_strings_1, reseat_1, reseat_to_string)
3955 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3956 correctly. Don't assume unibyte strings are not bidi-reordered.
3957 (compute_display_string_pos)
3958 (compute_display_string_end): Fix handling the case of C string.
3959 (push_it, pop_it): Save and restore from_disp_prop_p.
3960 (handle_single_display_spec, push_display_prop): Set the
3961 from_disp_prop_p flag.
3962 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3963 (pop_it): Call iterate_out_of_display_property only if we are
3964 popping after iteration over a string that came from a display
3965 property. Fix a typo in popping stretch info. Add an assertion
3966 for verifying that the iterator position is in sync with the bidi
3968 (handle_single_display_spec, get_overlay_strings_1)
3969 (push_display_prop): Fix initialization of paragraph direction for
3970 string when that of the parent object is not yet determined.
3971 (reseat_1): Call bidi_init_it to resync the bidi
3972 iterator with IT's position. (Bug#7616)
3973 (find_row_edges): If ROW->start.pos gives position
3974 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3975 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3976 Reset the from_disp_prop_p flag.
3977 (SAVE_IT, RESTORE_IT): New macros.
3978 (pos_visible_p, face_before_or_after_it_pos)
3979 (back_to_previous_visible_line_start)
3980 (move_it_in_display_line_to, move_it_in_display_line)
3981 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3982 (try_scrolling, redisplay_window, display_line): Use them when
3983 saving a temporary copy of the iterator and restoring it back.
3984 (back_to_previous_visible_line_start, reseat_1)
3985 (init_iterator): Empty the bidi cache "stack".
3986 (move_it_in_display_line_to): If iterator ended up at
3987 EOL, but we never saw any buffer positions smaller than
3988 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3989 motion in bidi-reordered lines.
3990 (move_it_in_display_line_to): Record prev_method and prev_pos
3991 immediately before the call to set_iterator_to_next. Fixes cursor
3992 motion in bidi-reordered lines with stretch glyphs and strings
3993 displayed in margins. (Bug#8133) (Bug#8867)
3994 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3996 (pos_visible_p): Support positions in bidi-reordered lines.
3997 Save and restore bidi cache.
3999 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4000 (bidi_paragraph_info): Delete unused struct.
4001 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4002 (bidi_cache_start): New variable.
4003 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4005 (bidi_cache_fetch_state, bidi_cache_search)
4006 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4007 (bidi_cache_find, bidi_peek_at_next_level)
4008 (bidi_level_of_next_char, bidi_find_other_level_edge)
4009 (bidi_move_to_visually_next): Compare cache index with
4010 bidi_cache_start rather than with zero.
4011 (bidi_fetch_char): Accept new argument STRING; all callers
4012 changed. Support iteration over a string. Support strings with
4013 display properties. Support unibyte strings. Fix the type of
4014 `len' according to what STRING_CHAR_AND_LENGTH expects.
4015 (bidi_paragraph_init, bidi_resolve_explicit_1)
4016 (bidi_resolve_explicit, bidi_resolve_weak)
4017 (bidi_level_of_next_char, bidi_move_to_visually_next):
4018 Support iteration over a string.
4019 (bidi_set_sor_type, bidi_resolve_explicit_1)
4020 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4021 can now be zero (for strings); special values 0 and -1 were
4022 changed to -1 and -2, respectively.
4023 (bidi_char_at_pos): New function.
4024 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4025 Call it instead of FETCH_MULTIBYTE_CHAR.
4026 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4027 initialized to valid values.
4028 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4030 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4031 the test for valid cached positions. Fix the logic for looking up
4032 the sentinel state in the cache. GCPRO the Lisp string we are
4034 (bidi_push_it, bidi_pop_it): New functions.
4035 (bidi_initialize): Initialize the bidi cache start stack pointer.
4036 (bidi_cache_ensure_space): New function, refactored from part of
4037 bidi_cache_iterator_state. Don't assume the required size is just
4038 one BIDI_CACHE_CHUNK away.
4039 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4040 (bidi_count_bytes, bidi_char_at_pos): New functions.
4041 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4042 always valid if bidi_cache_idx is valid.
4043 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4044 is valid if it's going to be used.
4045 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4046 (bidi_cache_fetch_state, bidi_cache_search)
4047 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4048 (bidi_cache_iterator_state, bidi_cache_find)
4049 (bidi_find_other_level_edge, bidi_cache_start_stack):
4050 All variables related to cache indices are now EMACS_INT.
4052 * dispextern.h (struct bidi_string_data): New structure.
4053 (struct bidi_it): New member `string'. Make flag members be 1-bit
4054 fields, and put them last in the struct.
4055 (compute_display_string_pos, compute_display_string_end):
4057 (bidi_push_it, bidi_pop_it): Add prototypes.
4058 (struct iterator_stack_entry): New members bidi_p,
4059 paragraph_embedding, and from_disp_prop_p.
4060 (struct it): Member bidi_p is now a bit field 1 bit wide.
4061 (bidi_shelve_cache, bidi_unshelve_cache):
4064 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4065 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4066 and vector-like objects.
4068 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4069 cache around display iteration.
4071 * window.c (Fwindow_end, window_scroll_pixel_based)
4072 (displayed_window_lines, Frecenter): Save and restore the bidi
4073 cache around display iteration.
4075 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4077 * editfns.c (Fdelete_region): Clarify the use of the named
4078 parameters (bug#6788).
4080 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4082 * indent.c (Fvertical_motion): Set and restore w->pointm when
4083 saving and restoring the window's buffer (Bug#9006).
4085 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4087 * editfns.c (Fstring_to_char): Clarify just what is returned
4088 (bug#6576). Text by Eli Zaretskii.
4090 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4092 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4094 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4096 * buffer.c (mmap_find): Fix a typo.
4098 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4100 Fix execution of x selection hooks.
4101 * xselect.c (Qx_lost_selection_functions)
4102 (Qx_sent_selection_functions): New vars.
4103 (syms_of_xselect): DEFSYM them.
4104 (x_handle_selection_request): Pass Qx_sent_selection_functions
4105 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4106 (x_handle_selection_clear,x_clear_frame_selections):
4107 Pass Qx_lost_selection_functions rather than
4108 Vx_lost_selection_functions to Frun_hook_with_args.
4110 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4112 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4113 The old code sometimes used this field without initializing it.
4115 * alloc.c (gc_sweep): Don't read past end of array.
4116 In theory, the old code could also have corrupted Emacs internals,
4117 though it'd be very unlikely.
4119 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4121 * character.c (Fcharacterp): Don't advertise optional ignored
4122 argument. (Bug#4026)
4124 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4126 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4129 * window.c (Fset_window_start): Doc fix (bug#4199).
4130 (Fset_window_hscroll): Ditto.
4132 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4134 Fix minor new problems caught by GCC 4.6.1.
4135 * term.c (init_tty): Remove unused local.
4136 * xsettings.c (store_monospaced_changed): Define this function only
4137 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4140 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4142 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4144 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4146 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4147 are the mini-buffer and the echo area (bug#3320).
4149 * term.c (init_tty): Remove support for supdup, c10 and perq
4150 terminals, which are no longer supported (bug#1482).
4152 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4154 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4156 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4158 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4159 for non-popups (Bug#3642).
4161 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4163 * alloc.c (reset_malloc_hooks): Protoize.
4164 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4165 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4166 * cm.c (losecursor): Likewise.
4167 * data.c (fmod): Likewise.
4168 * dispnew.c (swap_glyphs_in_rows): Likewise.
4169 * emacs.c (memory_warning_signal): Likewise.
4170 * floatfns.c (float_error): Likewise.
4171 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4172 (otf_open, font_otf_capability, generate_otf_features)
4173 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4175 * image.c (pbm_read_file): Likewise.
4176 * indent.c (string_display_width): Likewise.
4177 * intervals.c (check_for_interval, search_for_interval)
4178 (inc_interval_count, count_intervals, root_interval)
4179 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4180 * lread.c (defalias): Likewise.
4181 * ralloc.c (r_alloc_check): Likewise.
4182 * regex.c (set_image_of_range_1, set_image_of_range)
4183 (regex_grow_registers): Likewise.
4184 * sysdep.c (strerror): Likewise.
4185 * termcap.c (valid_filename_p, tprint, main): Likewise.
4186 * tparam.c (main): Likewise.
4187 * unexhp9k800.c (run_time_remap, save_data_space)
4188 (update_file_ptrs, read_header, write_header, calculate_checksum)
4189 (copy_file, copy_rest, display_header): Likewise.
4190 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4192 * xdisp.c (check_it): Likewise.
4193 * xfaces.c (register_color, unregister_color, unregister_colors):
4195 * xfns.c (print_fontset_result): Likewise.
4196 * xrdb.c (member, fatal, main): Likewise.
4198 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4200 Fix minor problems found by static checking (Bug#9031).
4201 * chartab.c (char_table_set_range, map_sub_char_table):
4202 Remove unused locals.
4203 (uniprop_table): Now static.
4204 * composite.c (_work_char): Remove unused static var.
4206 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4208 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4210 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4212 * gtkutil.c (qttip_cb): Remove code without function.
4214 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4216 * w32.c (pthread_sigmask): New stub.
4218 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4220 Use pthread_sigmask, not sigprocmask (Bug#9010).
4221 sigprocmask is portable only for single-threaded applications, and
4222 Emacs can be multi-threaded when it uses GTK.
4223 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4225 * callproc.c (Fcall_process):
4226 * process.c (create_process):
4227 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4228 Use pthread_sigmask, not sigprocmask.
4230 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4232 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4233 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4236 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4238 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4239 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4240 (xg_hide_tooltip): Fix comment.
4242 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4243 in registerServicesMenuSendTypes.
4244 (validRequestorForSendType): Don't check ns_return_types.
4246 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4249 2011-07-08 Jason Rumney <jasonr@gnu.org>
4251 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4252 SH_SHOW for hidden windows (Bug#5482).
4254 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4255 frame struct members of non-existent frames (Bug#6284).
4257 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4259 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4260 variable firstTime not needed on OSX >= 10.6.
4261 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4262 >= 10.5. Use setKnobProportion, setDoubleValue.
4264 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4265 (MAC_OS_X_VERSION_10_5): Define if not defined.
4266 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4267 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4268 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4270 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4271 cString and lossyCString on OSX >= 10.4
4273 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4274 sizeToFit on OSX >= 10.2.
4276 * nsimage.m (allocInitFromFile): Don't use deprecated method
4277 bestRepresentationForDevice on OSX >= 10.6.
4279 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4282 * emacs.c: Declare unexec_init_emacs_zone.
4284 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4286 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4288 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4289 on svcsMenu (Bug#8842).
4291 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4293 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4295 * nsterm.m (QUTF8_STRING): Declare.
4296 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4297 (validRequestorForSendType): Return type is (id).
4298 Change indexOfObjectIdenticalTo to indexOfObject.
4299 Check if we have local selection before returning self (Bug#8842).
4300 (writeSelectionToPasteboard): Put local selection into paste board
4301 if we have a local selection (Bug#8842).
4302 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4304 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4305 (ns_get_local_selection): Declare.
4307 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4309 * keymap.c (describe_map_tree): Don't insert a double newline at
4310 the end of the buffer (bug#1169) and return whether we inserted
4313 * callint.c (Fcall_interactively): Change "reading args" to
4314 "providing args" to try to clarify what it does (bug#1010).
4316 2011-07-07 Kenichi Handa <handa@m17n.org>
4318 * composite.c (composition_compute_stop_pos): Ignore a static
4319 composition starting before CHARPOS (Bug#8915).
4321 * xdisp.c (handle_composition_prop): Likewise.
4323 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4325 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4328 2011-07-07 Kenichi Handa <handa@m17n.org>
4330 * character.h (unicode_category_t): New enum type.
4332 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4333 (Qchar_code_property_table): New variable.
4334 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4335 (UNIPROP_COMPRESSED_FORM_P): New macros.
4336 (char_table_ascii): Uncompress the compressed values.
4337 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4338 Uncompress the compressed values.
4339 (sub_char_table_ref_and_range): Likewise.
4340 (char_table_ref_and_range): Uncompress the compressed values.
4341 (sub_char_table_set): New arg is_uniprop. Callers changed.
4342 Uncompress the compressed values.
4343 (sub_char_table_set_range): Args changed. Callers changed.
4344 (char_table_set_range): Adjuted for the above change.
4345 (map_sub_char_table): Delete args default_val and parent. Add arg
4346 top. Give decoded values to a Lisp function.
4347 (map_char_table): Adjust for the above change. Give decoded
4348 values to a Lisp function. Gcpro more variables.
4349 (uniprop_table_uncompress)
4350 (uniprop_decode_value_run_length): New functions.
4351 (uniprop_decoder, uniprop_decoder_count): New variables.
4352 (uniprop_get_decoder, uniprop_encode_value_character)
4353 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4355 (uniprop_encoder, uniprop_encoder_count): New variables.
4356 (uniprop_get_encoder, uniprop_table)
4357 (Funicode_property_table_internal, Fget_unicode_property_internal)
4358 (Fput_unicode_property_internal): New functions.
4359 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4360 Sunicode_property_table_internal, Sget_unicode_property_internal,
4361 and Sput_unicode_property_internal. Defvar_lisp
4362 char-code-property-alist.
4364 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4365 Vunicode_category_table.
4367 * font.c (font_range): Adjust for the change of
4368 Vunicode_category_table.
4370 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4372 * m/iris4d.h: Remove file, move contents ...
4373 * s/irix6-5.h: ... here.
4375 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4377 Remove unportable assumption about struct layout (Bug#8884).
4378 * alloc.c (mark_buffer):
4379 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4380 (clone_per_buffer_values): Don't assume that
4381 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4382 This isn't true in general, and it's particularly not true
4383 if Emacs is configured with --with-wide-int.
4384 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4385 New macros, used in the buffer.c change.
4387 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4389 * xsettings.c: Use both GConf and GSettings if both are available.
4390 (store_config_changed_event): Add comment.
4391 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4392 (store_tool_bar_style_changed): New functions.
4393 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4394 (struct xsettings): Move font inside HAVE_XFT.
4395 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4396 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4397 Move inside HAVE_XFT.
4398 (something_changed_gsettingsCB): Rename from something_changedCB.
4399 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4401 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4402 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4403 (something_changed_gconfCB): Rename from something_changedCB.
4404 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4405 (parse_settings): Move check for font inside HAVE_XFT.
4406 (read_settings, apply_xft_settings): Add comment.
4407 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4408 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4409 call store_font_name_changed.
4410 (xft_settings_event): Add comment.
4411 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4412 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4413 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4414 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4415 (xsettings_initialize): Call init_gsettings last.
4416 (xsettings_get_system_font, xsettings_get_system_normal_font):
4419 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4421 Random fixes. E.g., (random) never returned negative values.
4422 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4423 subseconds part to the entropy, as that's a bit more random.
4424 Prefer signed to unsigned, since the signedness doesn't matter and
4425 in general we prefer signed. When given a limit, use a
4426 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4427 latter isn't right if USE_2_TAGS_FOR_INTS.
4428 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4429 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4431 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4433 * textprop.c (text_property_stickiness):
4434 Obey Vtext_property_default_nonsticky.
4435 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4436 * w32fns.c (syms_of_w32fns):
4437 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4439 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4441 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4442 This is more efficient than Ffile_directory_p and avoids a minor race.
4444 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4446 * buffer.c (Foverlay_put): Say what the return value is
4449 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4450 is a directory before asking whether to use the file name
4452 (barf_or_query_if_file_exists): Make the "File is a directory"
4453 error be more correct.
4455 * fns.c (Frequire): Remove the mention of the .gz files, since
4456 that's installation-specific, but keep the mention of
4457 `get-load-suffixes'.
4459 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4461 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4462 Report string overflow if the output is too long.
4464 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4466 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4467 (syms_of_gnutls): Remove duplicate DEFSYM for
4468 Qgnutls_bootprop_verify_hostname_error, an error for
4469 Qgnutls_bootprop_verify_error (which is no longer used).
4471 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4472 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4473 Also (re)move comments that are misplaced or no longer relevant.
4475 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4477 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4479 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4481 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4482 and background color parameters if they have been changed.
4484 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4486 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4488 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4490 * xsettings.c (SYSTEM_FONT): Define only when used.
4491 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4493 * keymap.c (access_keymap_1): Now static.
4495 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4497 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4498 leave any prefix arg for the up event (Bug#1586).
4500 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4502 * lread.c (syms_of_lread): Mention single symbols defined by
4503 `defvar' or `defconst' (bug#7154).
4505 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4506 (Frequire): Mention get-load-suffixes.
4508 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4510 * window.h (window): Remove clone_number slot.
4511 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4513 (make_parent_window, make_window, saved_window)
4514 (Fset_window_configuration, save_window_save): Don't deal with
4516 * buffer.c (Qclone_number): Remove declaration.
4517 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4519 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4521 Add multiple inheritance to keymaps.
4522 * keymap.c (Fmake_composed_keymap): New function.
4523 (Fset_keymap_parent): Simplify.
4524 (fix_submap_inheritance): Remove.
4525 (access_keymap_1): New function extracted from access_keymap to handle
4526 embedded parents and handle lists of maps.
4527 (access_keymap): Use it.
4528 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4529 (Fcopy_keymap): Handle embedded parents.
4530 (Fcommand_remapping, define_as_prefix): Simplify.
4531 (Fkey_binding): Simplify.
4532 (syms_of_keymap): Move minibuffer-local-completion-map,
4533 minibuffer-local-filename-completion-map,
4534 minibuffer-local-must-match-map, and
4535 minibuffer-local-filename-must-match-map to Elisp.
4536 (syms_of_keymap): Defsubr make-composed-keymap.
4537 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4538 (parse_menu_item): Trivial simplification.
4540 2011-07-01 Glenn Morris <rgm@gnu.org>
4542 * Makefile.in (SETTINGS_LIBS): Fix typo.
4544 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4546 * coding.c (Fencode_coding_string): Record the last coding system
4547 used, as the function doc string says (bug#8738).
4549 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4551 * xsettings.c (store_monospaced_changed): Take new font as arg and
4552 check for change against current_mono_font.
4553 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4554 (emacs_settings_constructor, emacs_settings_get_property)
4555 (emacs_settings_set_property, emacs_settings_class_init)
4556 (emacs_settings_init, gsettings_obj): Remove.
4557 (something_changedCB): New function for HAVE_GSETTINGS.
4558 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4559 with value as argument.
4560 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4561 g_settings_new (Bug#8967). Do not create gsettings_obj.
4562 Remove calls to g_settings_bind. Connect something_changedCB to
4565 * xgselect.c: Add defined (HAVE_GSETTINGS).
4566 (xgselect_initialize): Ditto.
4568 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4569 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4572 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4574 * eval.c (struct backtrace): Simplify and port the data structure.
4575 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4576 signed bit field, as this assumption is not portable and it makes
4577 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4578 "char debug_on_exit : 1" as this is not portable either; instead,
4579 use the portable "unsigned int debug_on_exit : 1". Remove unused
4580 member evalargs. Remove obsolete comments about cc bombing out.
4582 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4584 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4585 Let HAVE_GSETTINGS override HAVE_GCONF.
4586 (store_monospaced_changed): New function.
4587 (EMACS_SETTINGS): A new type derived from GObject to handle
4588 GSettings notifications.
4589 (emacs_settings_constructor, emacs_settings_get_property)
4590 (emacs_settings_set_property, emacs_settings_class_init):
4592 (gsettings_client, gsettings_obj): New variables.
4593 (GSETTINGS_SCHEMA): New define.
4594 (something_changedCB): Call store_monospaced_changed.
4595 (init_gsettings): New function.
4596 (xsettings_initialize): Call init_gsettings.
4597 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4600 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4603 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4605 * window.c (resize_root_window, grow_mini_window)
4606 (shrink_mini_window): Rename Qresize_root_window to
4607 Qwindow_resize_root_window and Qresize_root_window_vertically to
4608 Qwindow_resize_root_window_vertically.
4610 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4612 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4614 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4616 * makefile.w32-in: Redesign dependencies so they reflect more
4617 clearly which files are directly included by each source file,
4618 and not through other includes.
4620 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4622 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4623 (sort_overlays, overlay_strings): When an overlay's clone number
4624 matches the window's clone number process the overlay even if
4625 the overlay's window property doesn't match the current window.
4627 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4628 (Fwindow_hchild): Rename to Fwindow_left_child.
4629 (Fwindow_next): Rename to Fwindow_next_sibling.
4630 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4631 (resize_window_check): Rename to window_resize_check.
4632 (resize_window_apply): Rename to window_resize_apply.
4633 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4634 (Fdelete_other_windows_internal, resize_frame_windows)
4635 (Fsplit_window_internal, Fdelete_window_internal)
4636 (grow_mini_window, shrink_mini_window)
4637 (Fresize_mini_window_internal): Fix callers accordingly.
4639 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4641 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4642 (emacs_fixed_set_min_size): Remove.
4643 (emacs_fixed_new): Take frame as argument.
4645 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4646 (_EmacsFixedPrivate): Remove minwidth/height.
4647 Add struct frame *f.
4648 (emacs_fixed_init): Initialize priv->f.
4649 (get_parent_class, emacs_fixed_set_min_size): Remove.
4650 (emacs_fixed_new): Set priv->f to argument.
4651 (emacs_fixed_get_preferred_width)
4652 (emacs_fixed_get_preferred_height): Use min_width/height from
4653 frames size_hint to set minimum and natural (Bug#8919).
4654 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4655 and use min_width/height from frames size_hint to set
4656 min_width/height (Bug#8919).
4658 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4659 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4662 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4664 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4665 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4668 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4670 * process.c (wait_reading_process_output): Bypass select if
4671 waiting for a cell while ignoring keyboard input, and input is
4672 pending. Suggested by Jan Djärv (Bug#8869).
4674 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4676 Use gnulib's dup2 module instead of rolling our own.
4677 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4679 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4681 * dispnew.c (scrolling_window): Before scrolling, turn off a
4682 mouse-highlight in the window being scrolled.
4684 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4686 Move DEFSYM to lisp.h and use everywhere.
4688 * character.h (DEFSYM): Move declaration...
4689 * lisp.h (DEFSYM): ...here.
4695 * w32select.c: Don't include character.h.
4697 * alloc.c (syms_of_alloc):
4698 * buffer.c (syms_of_buffer):
4699 * bytecode.c (syms_of_bytecode):
4700 * callint.c (syms_of_callint):
4701 * casefiddle.c (syms_of_casefiddle):
4702 * casetab.c (init_casetab_once):
4703 * category.c (init_category_once, syms_of_category):
4704 * ccl.c (syms_of_ccl):
4705 * cmds.c (syms_of_cmds):
4706 * composite.c (syms_of_composite):
4707 * dbusbind.c (syms_of_dbusbind):
4708 * dired.c (syms_of_dired):
4709 * dispnew.c (syms_of_display):
4710 * doc.c (syms_of_doc):
4711 * editfns.c (syms_of_editfns):
4712 * emacs.c (syms_of_emacs):
4713 * eval.c (syms_of_eval):
4714 * fileio.c (syms_of_fileio):
4715 * fns.c (syms_of_fns):
4716 * frame.c (syms_of_frame):
4717 * fringe.c (syms_of_fringe):
4718 * insdel.c (syms_of_insdel):
4719 * keymap.c (syms_of_keymap):
4720 * lread.c (init_obarray, syms_of_lread):
4721 * macros.c (syms_of_macros):
4722 * msdos.c (syms_of_msdos):
4723 * print.c (syms_of_print):
4724 * process.c (syms_of_process):
4725 * search.c (syms_of_search):
4726 * sound.c (syms_of_sound):
4727 * syntax.c (init_syntax_once, syms_of_syntax):
4728 * terminal.c (syms_of_terminal):
4729 * textprop.c (syms_of_textprop):
4730 * undo.c (syms_of_undo):
4731 * w32.c (globals_of_w32):
4732 * window.c (syms_of_window):
4733 * xdisp.c (syms_of_xdisp):
4734 * xfaces.c (syms_of_xfaces):
4735 * xfns.c (syms_of_xfns):
4736 * xmenu.c (syms_of_xmenu):
4737 * xsettings.c (syms_of_xsettings):
4738 * xterm.c (syms_of_xterm): Use DEFSYM.
4740 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4742 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4744 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4746 Integer and buffer overflow fixes (Bug#8873).
4748 * print.c (printchar, strout): Check for string overflow.
4749 (PRINTPREPARE, printchar, strout):
4750 Don't set size unless allocation succeeds.
4752 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4753 for sizes. Check for string overflow more accurately.
4754 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4756 * macros.c: Integer and buffer overflow fixes.
4757 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4758 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4759 Use ptrdiff_t, not int, for sizes.
4760 Don't increment bufsize until after realloc succeeds.
4761 Check for size-calculation overflow.
4762 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4764 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4766 * lread.c: Integer overflow fixes.
4767 (read_integer): Radix is now EMACS_INT, not int,
4768 to improve quality of diagnostics for out-of-range radices.
4769 Calculate buffer size correctly for out-of-range radices.
4770 (read1): Check for integer overflow in radices, and in
4771 read-circle numbers.
4772 (read_escape): Avoid int overflow.
4773 (Fload, openp, read_buffer_size, read1)
4774 (substitute_object_recurse, read_vector, read_list, map_obarray):
4775 Use ptrdiff_t, not int, for sizes.
4776 (read1): Use EMACS_INT, not int, for sizes.
4777 Check for size overflow.
4779 * image.c (cache_image): Check for size arithmetic overflow.
4781 * lread.c: Integer overflow issues.
4782 (saved_doc_string_size, saved_doc_string_length)
4783 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4784 Now ptrdiff_t, not int.
4785 (read1): Don't assume doc string length fits in int. Check for
4786 out-of-range doc string lengths.
4787 (read_list): Don't assume file position fits in int.
4788 (read_escape): Check for hex character overflow.
4790 2011-06-22 Leo Liu <sdl.web@gmail.com>
4792 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4793 Move to minibuffer.el.
4795 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4797 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4798 The following patches are for when GLYPH_DEBUG && !XASSERT.
4799 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4800 * dispnew.c (flush_stdout):
4801 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4802 Mark as externally visible.
4803 * dispnew.c (check_window_matrix_pointers): Now static.
4804 * dispnew.c (window_to_frame_vpos):
4805 * xfns.c (unwind_create_frame):
4806 * xterm.c (x_check_font): Remove unused local.
4807 * scroll.c (CHECK_BOUNDS):
4808 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4809 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4810 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4811 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4812 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4814 (debug_method_add): Use va_list and vsprintf rather than relying
4815 on undefined behavior with wrong number of arguments.
4816 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4817 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4818 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4819 since we're not interested in debugging glyphs with old libraries.
4820 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4821 GCC 4.6.0's static checking.
4823 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4825 Integer overflow and signedness fixes (Bug#8873).
4826 A few related buffer overrun fixes, too.
4828 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4830 * dispextern.h (struct face.stipple):
4831 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4832 (x_bitmap_mask, x_allocate_bitmap_record)
4833 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4834 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4835 (x_create_bitmap_from_xpm_data):
4836 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4837 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4839 * xfaces.c (load_pixmap):
4840 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4841 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4842 (.bitmaps_last, struct x_output.icon_bitmap):
4843 Use ptrdiff_t, not int, for bitmap indexes.
4844 (x_allocate_bitmap_record): Check for size overflow.
4845 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4847 Use ptrdiff_t, not int, for overlay counts.
4848 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4849 * editfns.c (overlays_around, get_pos_property):
4850 * textprop.c (get_char_property_and_overlay):
4851 * xdisp.c (next_overlay_change, note_mouse_highlight):
4852 * xfaces.c (face_at_buffer_position):
4853 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4854 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4855 (Fnext_overlay_change, Fprevious_overlay_change)
4856 (mouse_face_overlay_overlaps, Foverlays_in):
4857 Use ptrdiff_t, not int, for sizes.
4858 (overlays_at, overlays_in): Check for size-calculation overflow.
4860 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4862 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4863 (x_session_initialize): Do not assume string length fits in int.
4865 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4866 This is unlikely, but can occur if DPI is outlandish.
4868 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4869 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4871 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4872 * xrdb.c (magic_file_p, search_magic_path):
4873 Omit last arg SUFFIX; it was always 0. All callers changed.
4874 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4876 * xfont.c (xfont_match): Avoid need for strlen.
4878 * xfns.c: Don't assume strlen fits in int.
4879 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4881 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4882 not unsigned long, as we prefer signed integers. All callers changed.
4883 Detect integer overflow in repeat count.
4884 (message_dolog): Don't assume print length fits in 39 bytes.
4885 (display_mode_element): Don't assume strlen fits in int.
4887 * termcap.c: Don't assume sizes fit in int and never overflow.
4888 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4889 (gobble_line): Check for size-calculation overflow.
4891 * minibuf.c (Fread_buffer):
4892 * lread.c (intern, intern_c_string):
4893 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4894 Don't assume string length fits in int.
4896 * keyboard.c (parse_tool_bar_item):
4897 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4899 * font.c: Don't assume string length fits in int.
4900 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4901 Use ptrdiff_t, not int.
4902 (font_intern_prop): Don't assume string length fits in int.
4903 Don't assume integer property fits in fixnum.
4904 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4906 * filelock.c: Fix some buffer overrun and integer overflow issues.
4907 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4908 Reformulate so as not to need the command string.
4909 Invoke gzip -cd rather than gunzip, as it's more portable.
4910 (lock_info_type, lock_file_1, lock_file):
4911 Don't assume pid_t and time_t fit in unsigned long.
4912 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4913 (current_lock_owner): Prefer signed type for sizes.
4914 Use memcpy, not strncpy, where memcpy is what is really wanted.
4915 Don't assume (via atoi) that time_t and pid_t fit in int.
4916 Check for time_t and/or pid_t out of range, e.g., via a network share.
4917 Don't alloca where an auto var works fine.
4919 * fileio.c: Fix some integer overflow issues.
4920 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4921 Don't assume string length fits in int.
4922 (directory_file_name): Don't assume string length fits in long.
4923 (make_temp_name): Don't assume pid fits in int, or that its print
4924 length is less than 20.
4926 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4928 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4930 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4932 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4933 We prefer signed integers, even for size calculations.
4935 * emacs.c: Don't assume string length fits in 'int'.
4936 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4937 (main): Don't invoke strlen when not needed.
4939 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4940 (XD_DEBUG_MESSAGE): Don't waste a byte.
4942 * callproc.c (getenv_internal_1, getenv_internal)
4944 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4946 * lread.c (invalid_syntax): Omit length argument.
4947 All uses changed. This doesn't fix a bug, but it simplifies the
4948 code away from its former Hollerith-constant appearance, and it's
4949 one less 'int' to worry about when looking at integer-overflow issues.
4950 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4952 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4953 This didn't break anything, but it didn't help either.
4954 It's confusing to put a bogus integer in a place where the actual
4955 value does not matter.
4956 (LIST_END_P): Remove unused macro and its bogus comment.
4957 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4959 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4960 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4962 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4963 We prefer signed types, and the value cannot exceed the EMACS_INT
4964 range anyway (because otherwise the length would not be representable).
4965 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4966 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4967 This avoids a GCC warning when WIDE_EMACS_INT.
4969 * indent.c (sane_tab_width): New function.
4970 (current_column, scan_for_column, Findent_to, position_indentation)
4971 (compute_motion): Use it. This is just for clarity.
4972 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4974 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4976 * lisp.h (lint_assume): New macro.
4977 * composite.c (composition_gstring_put_cache):
4978 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4980 * editfns.c, insdel.c:
4981 Omit unnecessary forward decls, to simplify future changes.
4983 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4985 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4987 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4988 Use much-faster test for byte-length change.
4989 Don't assume string byte-length fits in 'int'.
4990 Check that character arg fits in 'int'.
4991 (mapcar1): Declare byte as byte, for clarity.
4993 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4995 * fns.c (concat): Catch string overflow earlier.
4996 Do not rely on integer wraparound.
4998 * dispextern.h (struct it.overlay_strings_charpos)
4999 (struct it.selective): Now EMACS_INT, not int.
5000 * xdisp.c (forward_to_next_line_start)
5001 (back_to_previous_visible_line_start)
5002 (reseat_at_next_visible_line_start, next_element_from_buffer):
5003 Don't arbitrarily truncate the value of 'selective' to int.
5005 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5007 * composite.c: Don't truncate sizes to 'int'.
5008 (composition_gstring_p, composition_reseat_it)
5009 (composition_adjust_point): Use EMACS_INT, not int.
5010 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5011 not EMACS_UINT, for indexes.
5013 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5015 * buffer.c: Include <verify.h>.
5016 (struct sortvec.priority, struct sortstr.priority):
5017 Now EMACS_INT, not int.
5018 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5019 (struct sortstr.size, record_overlay_string)
5020 (struct sortstrlist.size, struct sortlist.used):
5021 Don't truncate size to int.
5022 (record_overlay_string): Check for size-calculation overflow.
5023 (init_buffer_once): Check at compile-time, not run-time.
5025 2011-06-22 Jim Meyering <meyering@redhat.com>
5027 Don't leak an XBM-image-sized buffer
5028 * image.c (xbm_load): Free the image buffer after using it.
5030 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5033 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5034 that Sun C diagnosed.
5035 * fns.c (secure_hash): Fix pointer signedness issue.
5036 * intervals.c (static_offset_intervals): New function.
5037 (offset_intervals): Use it.
5039 2011-06-21 Leo Liu <sdl.web@gmail.com>
5042 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5045 * fns.c (secure_hash): Rename from crypto_hash_function and change
5046 the first arg to accept symbols.
5047 (Fsecure_hash): New primitive.
5048 (syms_of_fns): New symbols.
5050 2011-06-20 Deniz Dogan <deniz@dogan.se>
5052 * process.c (Fset_process_buffer): Clarify return value in
5055 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5057 * dispnew.c (add_window_display_history): Use BVAR.
5059 * xdisp.c (debug_method_add): Use BVAR.
5060 (check_window_end, dump_glyph_matrix, dump_glyph)
5061 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5063 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5066 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5067 check till after the cache is created in init_frame_faces.
5069 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5071 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5073 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5075 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5076 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5077 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5079 Improve buffer-overflow checking (Bug#8873).
5080 * fileio.c (Finsert_file_contents):
5081 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5082 Remove the old (too-loose) buffer overflow checks.
5083 They weren't needed, since make_gap checks for buffer overflow.
5084 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5085 The old code merely checked for Emacs fixnum overflow, and relied
5086 on undefined (wraparound) behavior. The new code avoids undefined
5087 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5089 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5090 Tune. Don't use wider integers than needed. Don't use alloca.
5091 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5093 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5095 * insdel.c, lisp.h (buffer_overflow): New function.
5096 (insert_from_buffer_1, replace_range, replace_range_2):
5097 * insdel.c (make_gap_larger):
5098 * editfns.c (Finsert_char):
5099 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5101 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5103 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5105 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5107 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5108 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5110 * fileio.c: Don't assume EMACS_INT fits in off_t.
5111 (emacs_lseek): New static function.
5112 (Finsert_file_contents, Fwrite_region): Use it.
5113 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5115 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5117 * fns.c: Don't overflow int when computing a list length.
5118 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5119 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5120 truncation on 64-bit hosts. Check for QUIT every
5121 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5122 faster and is responsive enough.
5123 (Flength): Report an error instead of overflowing an integer.
5124 (Fsafe_length): Return a float if the value is not representable
5125 as a fixnum. This shouldn't happen except in contrived situations.
5126 (Fnthcdr, Fsort): Don't assume list length fits in int.
5127 (Fcopy_sequence): Don't assume vector length fits in int.
5129 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5130 (header_size, word_size): New constants.
5131 (allocate_vectorlike): Don't check size overflow here.
5132 (allocate_vector): Check it here instead, since this is the only
5133 caller of allocate_vectorlike that could cause overflow.
5134 Check that the new vector's length is representable as a fixnum.
5136 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5137 The previous code was bogus. For example, next_almost_prime (32)
5138 returned 39, which is undesirable as it is a multiple of 3; and
5139 next_almost_prime (24) returned 25, which is a multiple of 5 so
5140 why was the code bothering to check for multiples of 7?
5142 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5144 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5146 Variadic C functions now count arguments with ptrdiff_t.
5147 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5148 Back then I didn't know that the Emacs coding style prefers signed int.
5149 Also, in the meantime I found a few more instances where arguments
5150 were being counted with int, which may truncate counts on 64-bit
5151 machines, or EMACS_INT, which may be unnecessarily wide.
5152 * lisp.h (struct Lisp_Subr.function.aMANY)
5153 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5154 Arg counts are now ptrdiff_t, not size_t.
5155 All variadic functions and their callers changed accordingly.
5156 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5157 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5158 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5159 * callint.c (Fcall_interactively): Check arg count for overflow,
5160 to avoid potential buffer overrun. Use signed char, not 'int',
5161 for 'varies' array, so that we needn't bother to check its size
5162 calculation for overflow.
5163 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5164 * eval.c (apply_lambda):
5165 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5166 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5167 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5169 * callint.c (Fcall_interactively): Don't use index var as event count.
5171 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5172 * mem-limits.h (SIZE): Remove; no longer used.
5174 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5176 Remove unnecessary casts.
5177 * xterm.c (x_term_init):
5178 * xfns.c (x_set_border_pixel):
5179 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5180 These aren't needed now that we assume ANSI C.
5182 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5183 It's more likely to cause problems (due to unsigned overflow)
5186 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5188 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5190 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5192 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5194 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5196 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5198 GLYPH_CODE_FACE returns EMACS_INT, not int.
5199 * dispextern.h (merge_faces):
5200 * xfaces.c (merge_faces):
5201 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5202 Don't assume EMACS_INT fits in int.
5204 * character.h (CHAR_VALID_P): Remove unused parameter.
5205 * fontset.c, lisp.h, xdisp.c: All uses changed.
5207 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5209 * fns.c (concat): Minor tuning based on overflow analysis.
5210 This doesn't fix any bugs. Use int to hold character, instead
5211 of constantly refetching from Emacs object. Use XFASTINT, not
5212 XINT, for value known to be a character. Don't bother comparing
5213 a single byte to 0400, as it's always less.
5215 * floatfns.c (Fexpt):
5216 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5218 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5221 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5223 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5224 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5225 incorrectly succeed when S was a string, because 4294967386 was
5226 truncated before it was used.
5228 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5229 Otherwise, an out-of-range integer could cause undefined behavior
5232 * composite.c: Use int, not EMACS_INT, for characters.
5233 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5234 EMACS_INT, for values that are known to be in character range.
5235 This doesn't fix any bugs but is the usual style inside Emacs and
5236 may generate better code on 32-bit machines.
5238 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5239 This is for reasons similar to the recent CHAR_STRING fix.
5240 * charset.c (Fencode_char): Check that character arg is actually
5241 a character. Pass an int to ENCODE_CHAR.
5242 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5243 wider than 'int', as a compile-time check to prevent future regressions
5246 * character.c (char_string): Remove unnecessary casts.
5248 Make sure a 64-bit char is never passed to CHAR_STRING.
5249 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5250 by silently ignoring the top 32 bits, allowing some values
5251 that were far too large to be valid characters.
5252 * character.h: Include <verify.h>.
5253 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5254 arguments are no wider than unsigned, as a compile-time check
5255 to prevent future regressions in this area.
5257 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5258 (Fsubst_char_in_region):
5260 * xdisp.c (decode_mode_spec_coding):
5261 Adjust to CHAR_STRING's new requirement.
5262 * editfns.c (Finsert_char, Fsubst_char_in_region):
5263 * fns.c (concat): Check that character args are actually
5264 characters. Without this test, these functions did the wrong
5265 thing with wildly out-of-range values on 64-bit hosts.
5267 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5268 These casts should not be needed on 32-bit hosts, either.
5269 * keyboard.c (read_char):
5270 * lread.c (Fload): Remove casts to unsigned.
5272 * lisp.h (UNSIGNED_CMP): New macro.
5273 This fixes comparison bugs on 64-bit hosts.
5274 (ASCII_CHAR_P): Use it.
5275 * casefiddle.c (casify_object):
5276 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5277 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5278 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5279 * dispextern.h (FACE_FROM_ID):
5280 * keyboard.c (read_char): Use UNSIGNED_CMP.
5282 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5283 not to EMACS_INT, to avoid GCC warning.
5285 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5287 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5288 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5289 isn't needed on 32-bit machines.
5291 * buffer.c (Fgenerate_new_buffer_name):
5292 Use EMACS_INT for count, not int.
5293 (advance_to_char_boundary): Return EMACS_INT, not int.
5295 * data.c (Qcompiled_function): Now static.
5297 * window.c (window_body_lines): Now static.
5299 * image.c (gif_load): Rename local to avoid shadowing.
5301 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5302 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5303 * alloc.c (make_save_value): Integer argument is now of type
5305 (mark_object): Use ptrdiff_t, not int.
5306 * lisp.h (pD): New macro.
5307 * print.c (print_object): Use it.
5309 * alloc.c: Use EMACS_INT, not int, to count objects.
5310 (total_conses, total_markers, total_symbols, total_vector_size)
5311 (total_free_conses, total_free_markers, total_free_symbols)
5312 (total_free_floats, total_floats, total_free_intervals)
5313 (total_intervals, total_strings, total_free_strings):
5314 Now EMACS_INT, not int. All uses changed.
5315 (Fgarbage_collect): Compute overall total using a double, so that
5316 integer overflow is less likely to be a problem. Check for overflow
5317 when converting back to an integer.
5318 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5319 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5320 These were 'int' variables that could overflow on 64-bit hosts;
5321 they were never used, so remove them instead of repairing them.
5322 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5323 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5324 Previously, this ceilinged at INT_MAX, but that doesn't work on
5326 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5328 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5329 (allocate_vectorlike): Check for ptrdiff_t overflow.
5330 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5331 when a (possibly-narrower) signed value would do just as well.
5332 We prefer using signed arithmetic, to avoid comparison confusion.
5334 * alloc.c: Catch some string size overflows that we were missing.
5335 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5336 for convenience in STRING_BYTES_MAX.
5337 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5338 The definition here is exact; the one in lisp.h was approximate.
5339 (allocate_string_data): Check for string overflow. This catches
5340 some instances we weren't catching before. Also, it catches
5341 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5342 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5343 and ptrdiff_t and EMACS_INT are both 64 bits.
5345 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5346 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5347 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5349 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5351 * alloc.c (Fmake_string): Check for out-of-range init.
5353 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5355 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5357 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5359 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5360 xg_get_default_scrollbar_width.
5362 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5363 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5364 (style_changed_cb): Call update_theme_scrollbar_width and call
5365 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5366 all frames (Bug#8505).
5367 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5368 Call gtk_window_set_resizable if HAVE_GTK3.
5369 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5370 and height if HAVE_GTK3 (Bug#8505).
5371 (scroll_bar_width_for_theme): New variable.
5372 (update_theme_scrollbar_width): New function.
5373 (xg_get_default_scrollbar_width): Move code to
5374 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5375 (xg_initialize): Call update_theme_scrollbar_width.
5377 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5379 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5381 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5383 * frame.c (make_frame): Call other_buffer_safely instead of
5386 * window.c (temp_output_buffer_show): Call display_buffer with
5387 second argument Vtemp_buffer_show_specifiers and reset latter
5388 immediately after the call.
5389 (Vtemp_buffer_show_specifiers): New variable.
5390 (auto_window_vscroll_p, next_screen_context_lines)
5391 (Vscroll_preserve_screen_position): Remove leading asterisks from
5394 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5396 Fix minor problems found by GCC 4.6.0 static checking.
5397 * buffer.c (Qclone_number): Remove for now, as it's unused.
5398 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5399 (record_buffer): Remove unused local.
5400 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5401 (set_frame_buffer_list): Remove; unused.
5402 * frame.h (other_visible_frames): Remove decl.
5403 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5404 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5405 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5407 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5408 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5409 Define only if HAVE_GPM.
5410 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5411 (update_hints_inhibit): Remove; never set. All uses removed.
5412 * widgetprv.h (emacsFrameClassRec): Remove decl.
5413 * window.c (delete_deletable_window): Now returns void, since it
5414 wasn't returning anything.
5415 (compare_window_configurations): Remove unused locals.
5416 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5417 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5418 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5419 the same widths as pointers. This follows up on the 2011-05-06 patch.
5420 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5421 * xterm.h: Likewise.
5422 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5424 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5426 * makefile.w32-in: Update dependencies.
5427 (LISP_H): Add lib/intprops.h.
5429 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5431 * image.c (gif_load): Add animation frame delay to the metadata.
5432 (syms_of_image): Use DEFSYM. New symbol `delay'.
5434 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5436 * window.c (delete_deletable_window): Re-add.
5437 (Fset_window_configuration): Rewrite to handle dead buffers and
5438 consequently deletable windows.
5439 (window_tree, Fwindow_tree): Remove. Supply functionality in
5441 (compare_window_configurations): Simplify code.
5443 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5445 * image.c (imagemagick_load_image): Fix type mismatch.
5446 (Fimagemagick_types): Likewise.
5448 * window.h (replace_buffer_in_windows): Declare.
5450 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5452 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5453 Qclone_number. Remove external declaration of Qdelete_window.
5454 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5456 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5457 Run Qbuffer_list_update_hook if allowed.
5458 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5459 buffer list implementation.
5460 (other_buffer_safely): New function.
5461 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5462 calls to replace_buffer_in_windows and
5463 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5465 (record_buffer): Inhibit quitting and rewrite using quittable
5466 functions. Run Qbuffer_list_update_hook if allowed.
5467 (Frecord_buffer, Funrecord_buffer): New functions.
5468 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5469 Move switch-to-buffer to window.el.
5470 (bury-buffer): Move to window.el.
5471 (Vbuffer_list_update_hook): New variable.
5473 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5476 * window.h (resize_frame_windows): Move up in code.
5477 (Fwindow_frame): Remove EXFUN.
5478 (replace_buffer_in_all_windows): Remove prototype.
5479 (replace_buffer_in_windows_safely): Add prototype.
5481 * window.c: Declare Qdelete_window static again. Move down
5482 declaration of select_count.
5483 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5484 (Fother_window): Move to window.el.
5485 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5486 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5487 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5489 (replace_buffer_in_windows): Implement by calling
5490 Qreplace_buffer_in_windows.
5491 (replace_buffer_in_all_windows): Remove with some functionality
5492 moved into replace_buffer_in_windows_safely.
5493 (replace_buffer_in_windows_safely): New function.
5494 (select_window_norecord, select_frame_norecord): Move in front
5495 of run_window_configuration_change_hook. Remove now obsolete
5497 (Fset_window_buffer): Rewrite doc-string.
5498 Call Qrecord_window_buffer.
5499 (keys_of_window): Move binding for other-window to window.el.
5501 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5503 * dispextern.h (struct image): Replace data member, whose int_val
5504 and ptr_val fields were not used by anything, with a single
5507 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5508 (gif_clear_image, gif_load, imagemagick_load_image)
5509 (gs_clear_image, gs_load): Callers changed.
5511 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5513 * buffer.h: Include <time.h>, for time_t.
5514 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5516 Fix minor problems found by static checking.
5518 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5520 Make identifiers static if they are not used in other modules.
5521 * data.c (Qcompiled_function, Qframe, Qvector):
5522 * image.c (QimageMagick, Qsvg):
5523 * minibuf.c (Qmetadata):
5524 * window.c (resize_window_check, resize_root_window): Now static.
5525 * window.h (resize_window_check, resize_root_window): Remove decls.
5527 * window.c (window_deletion_count, delete_deletable_window):
5529 (window_body_lines): Now static.
5530 (Fdelete_other_windows_internal): Mark vars as initialized.
5531 Make sure 'resize_failed' is initialized.
5532 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5533 (resize_window_apply): Remove unused local.
5534 * window.h (delete_deletable_window): Remove decl.
5536 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5537 (imagemagick_load_image): Fix pointer signedness problem by changing
5538 last arg from unsigned char * to char *. All uses changed.
5539 Also, fix a local for similar reasons.
5540 Remove unused locals. Remove locals to avoid shadowing.
5541 (fn_rsvg_handle_free): Remove; unused.
5542 (svg_load, svg_load_image): Fix pointer signedness problem.
5543 (imagemagick_load_image): Don't use garbage pointer image_wand.
5545 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5547 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5549 * image.c (gif_load): Fix omitted cast error introduced by
5552 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5554 * window.h (resize_proportionally, orig_total_lines)
5555 (orig_top_line): Remove from window structure.
5556 (set_window_height, set_window_width, change_window_heights)
5557 (Fdelete_window): Remove prototypes.
5558 (resize_frame_windows): Remove duplicate declaration.
5560 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5562 * window.h (resize_frame_windows, resize_window_check)
5563 (delete_deletable_window, resize_root_window)
5564 (resize_frame_windows): Declare prototypes.
5566 * window.c (resize_window_apply): Make definition be "static" to
5567 match the prototype.
5569 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5571 * window.c: Remove declarations of Qwindow_size_fixed,
5572 window_min_size_1, window_min_size_2, window_min_size,
5573 size_window, window_fixed_size_p, enlarge_window, delete_window.
5574 Remove static from declaration of Qdelete_window, it's
5575 temporarily needed by Fbury_buffer.
5576 (replace_window): Don't assign orig_top_line and
5578 (Fdelete_window, delete_window): Remove. Window deletion is
5579 handled by window.el.
5580 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5581 Replace Fdelete_window calls with calls to Qdelete_window.
5582 (Fdelete_other_windows): Remove. Deleting other windows is
5583 handled by window.el.
5584 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5585 handled in window.el.
5586 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5587 Window minimum sizes are handled in window.el.
5588 (shrink_windows, size_window, set_window_height)
5589 (set_window_width, change_window_heights, window_height)
5590 (window_width, CURBEG, CURSIZE, enlarge_window)
5591 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5592 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5593 handled in window.el.
5594 (make_dummy_parent): Rename to make_parent_window and give it a
5595 second argument horflag.
5596 (make_window): Don't set resize_proportionally any more.
5597 (Fsplit_window): Remove. Windows are split in window.el.
5598 (save_restore_action, save_restore_orig_size)
5599 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5600 Resize mini windows in window.el.
5601 (grow_mini_window, shrink_mini_window): Implement by calling
5602 Qresize_root_window_vertically, resize_window_check and
5603 resize_window_apply.
5604 (saved_window, Fset_window_configuration, save_window_save):
5605 Do not handle orig_top_line, orig_total_lines, and
5606 resize_proportionally.
5607 (window_min_height, window_min_width): Move to window.el.
5608 (keys_of_window): Move bindings for delete-other-windows,
5609 split-window, delete-window and enlarge-window to window.el.
5611 * buffer.c: Temporarily extern Qdelete_window.
5612 (Fbury_buffer): Temporarily call Qdelete_window instead of
5613 Fdelete_window (Fbury_buffer will move to window.el soon).
5615 * frame.c (set_menu_bar_lines_1): Remove code handling
5616 orig_top_line and orig_total_lines.
5618 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5619 set_window_height but set heights directly.
5620 (change_frame_size_1): Use resize_frame_windows.
5622 * xdisp.c (init_xdisp): Don't use set_window_height but set
5625 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5626 Use resize_frame_windows instead of change_window_heights and run
5627 run_window_configuration_change_hook.
5629 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5630 instead of change_window_heights and run
5631 run_window_configuration_change_hook.
5633 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5635 * window.c (replace_window): Rename second argument REPLACEMENT to
5636 NEW. New third argument SETFLAG. Rewrite.
5637 (delete_window, make_dummy_parent): Call replace_window with
5639 (window_list_1): Move down in code.
5640 (run_window_configuration_change_hook): Move set_buffer part
5641 before select_frame_norecord part in order to unwind correctly.
5642 Rename count1 to count.
5643 (recombine_windows, delete_deletable_window, resize_root_window)
5644 (Fdelete_other_windows_internal)
5645 (Frun_window_configuration_change_hook, make_parent_window)
5646 (resize_window_check, resize_window_apply, Fresize_window_apply)
5647 (resize_frame_windows, Fsplit_window_internal)
5648 (Fdelete_window_internal, Fresize_mini_window_internal):
5650 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5652 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5654 * window.h (window): Add some new members to window structure -
5655 normal_lines, normal_cols, new_total, new_normal, clone_number,
5656 splits, nest, prev_buffers, next_buffers.
5657 (WINDOW_TOTAL_SIZE): Move here from window.c.
5658 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5660 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5662 (make_dummy_parent): Set new members of windows structure.
5663 (make_window): Move down in code. Handle new members of window
5665 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5666 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5667 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5668 (Fset_window_prev_buffers, Fwindow_next_buffers)
5669 (Fset_window_next_buffers, Fset_window_clone_number):
5671 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5672 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5674 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5675 Argument WINDOW can be now internal window too.
5676 (Fwindow_use_time): Move up in code.
5677 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5679 (Fset_window_configuration, saved_window)
5680 (Fcurrent_window_configuration, save_window_save): Handle new
5681 members of window structure.
5682 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5683 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5684 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5685 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5686 Qget_mru_window, Qresize_root_window,
5687 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5688 Qauto_buffer_name; staticpro them.
5690 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5692 * window.c (Fwindow_total_size, Fwindow_left_column)
5693 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5694 (Fwindow_list_1): New functions.
5695 (window_box_text_cols): Replace with window_body_cols.
5696 (Fwindow_width, Fscroll_left, Fscroll_right):
5697 Use window_body_cols instead of window_box_text_cols.
5698 (delete_window, Fset_window_configuration):
5699 Call delete_all_subwindows with window as argument.
5700 (delete_all_subwindows): Take a window as argument and not a
5702 (window_loop): Remove handling of GET_LRU_WINDOW and
5704 (Fget_lru_window, Fget_largest_window): Move to window.el.
5706 * window.h: Extern window_body_cols instead of
5707 window_box_text_cols. delete_all_subwindows now takes a
5708 Lisp_Object as argument.
5710 * indent.c (compute_motion, Fcompute_motion):
5711 Use window_body_cols instead of window_box_text_cols.
5713 * frame.c (delete_frame): Call delete_all_subwindows with root
5716 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5718 * fns.c (Fputhash): Document return value.
5720 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5722 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5724 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5726 Cons<->int and similar integer overflow fixes (Bug#8794).
5728 Check for overflow when converting integer to cons and back.
5729 * charset.c (Fdefine_charset_internal, Fdecode_char):
5730 Use cons_to_unsigned to catch overflow.
5731 (Fencode_char): Use INTEGER_TO_CONS.
5732 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5733 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5734 * data.c (long_to_cons, cons_to_long): Remove.
5735 (cons_to_unsigned, cons_to_signed): New functions.
5736 These signal an error for invalid or out-of-range values.
5737 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5738 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5739 * font.c (Ffont_variation_glyphs):
5740 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5741 * lisp.h: Include <intprops.h>.
5742 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5743 (cons_to_signed, cons_to_unsigned): New decls.
5744 (long_to_cons, cons_to_long): Remove decls.
5745 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5746 (Fprimitive_undo): Use CONS_TO_INTEGER.
5747 * xfns.c (Fx_window_property): Likewise.
5748 * xselect.c: Include <limits.h>.
5749 (x_own_selection, selection_data_to_lisp_data):
5750 Use INTEGER_TO_CONS.
5751 (x_handle_selection_request, x_handle_selection_clear)
5752 (x_get_foreign_selection, Fx_disown_selection_internal)
5753 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5754 (lisp_data_to_selection_data): Use cons_to_unsigned.
5755 (x_fill_property_data): Use cons_to_signed.
5756 Report values out of range.
5758 Check for buffer and string overflow more precisely.
5759 * buffer.h (BUF_BYTES_MAX): New macro.
5760 * lisp.h (STRING_BYTES_MAX): New macro.
5761 * alloc.c (Fmake_string):
5762 * character.c (string_escape_byte8):
5763 * coding.c (coding_alloc_by_realloc):
5764 * doprnt.c (doprnt):
5765 * editfns.c (Fformat):
5767 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5768 since they may not be the same number.
5769 * editfns.c (Finsert_char):
5770 * fileio.c (Finsert_file_contents):
5771 Likewise for BUF_BYTES_MAX.
5773 * image.c: Use ptrdiff_t, not int, for sizes.
5774 (slurp_file): Switch from int to ptrdiff_t.
5776 (slurp_file): Check that file size fits in both size_t (for
5777 malloc) and ptrdiff_t (for sanity and safety).
5779 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5780 if b->modtime has its maximal value.
5782 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5784 Don't assume time_t can fit into int.
5785 * buffer.h (struct buffer.modtime): Now time_t, not int.
5786 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5787 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5789 Minor fixes for signed vs unsigned integers.
5790 * character.h (MAYBE_UNIFY_CHAR):
5791 * charset.c (maybe_unify_char):
5792 * keyboard.c (read_char, reorder_modifiers):
5793 XINT -> XFASTINT, since the integer must be nonnegative.
5794 * ftfont.c (ftfont_spec_pattern):
5795 * keymap.c (access_keymap, silly_event_symbol_error):
5796 XUINT -> XFASTINT, since the integer must be nonnegative.
5797 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5798 since it makes no difference and we prefer signed.
5799 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5800 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5803 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5805 * window.h (Fwindow_frame): Declare.
5807 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5809 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5810 (SPARE_MEMORY): Always define.
5811 (LARGE_REQUEST): Remove.
5812 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5814 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5816 * lisp.h: Move EXFUNS for Fframe_root_window,
5817 Fframe_first_window and Fset_frame_selected_window to window.h.
5819 * window.h: Move EXFUNS for Fframe_root_window,
5820 Fframe_first_window and Fset_frame_selected_window here from
5823 * frame.c (Fwindow_frame, Fframe_first_window)
5824 (Fframe_root_window, Fframe_selected_window)
5825 (Fset_frame_selected_window): Move to window.c.
5826 (Factive_minibuffer_window): Move to minibuf.c.
5827 (Fother_visible_frames_p): New function.
5829 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5831 * window.c (decode_window, decode_any_window): Move up in code.
5832 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5833 (inhibit_frame_unsplittable): Remove unused variable.
5834 (Fwindow_buffer): Move up and rewrite doc-string.
5835 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5836 (Fwindow_prev): New functions.
5837 (Fwindow_frame): Move here from frame.c. Accept any window as
5839 (Fframe_root_window, Fframe_first_window)
5840 (Fframe_selected_window): Move here from frame.c. Accept frame
5841 or arbitrary window as argument. Update doc-strings.
5842 (Fminibuffer_window): Move up in code.
5843 (Fwindow_minibuffer_p): Move up in code and simplify.
5844 (Fset_frame_selected_window): Move here from frame.c.
5846 (Fselected_window, select_window, Fselect_window): Move up in
5847 code. Minor doc-string fixes.
5849 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5851 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5852 Do not assume that spare memory exists; that assumption is valid
5853 only if SYSTEM_MALLOC.
5854 (LARGE_REQUEST): New macro, so that the issue of large requests
5855 is separated from the issue of spare memory.
5857 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5859 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5862 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5864 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5867 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5869 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5871 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5873 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5874 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5876 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5878 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5880 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5882 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5883 (x_clipboard_manager_save): Add return value.
5884 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5886 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5887 Obey Vx_select_enable_clipboard_manager. Catch errors in
5888 x_clipboard_manager_save (Bug#8779).
5889 (Vx_select_enable_clipboard_manager): New variable.
5890 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5892 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5894 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5896 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5898 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5899 in the current matrix if keep_current_p is non-zero.
5901 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5903 * bidi.c (bidi_level_of_next_char): Fix last change.
5905 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5907 Support bidi reordering of text covered by display properties.
5909 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5910 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5911 (bidi_cache_search, bidi_cache_iterator_state)
5912 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5913 (bidi_level_of_next_char, bidi_move_to_visually_next):
5914 Support character positions inside a run of characters covered by a
5916 (bidi_paragraph_init, bidi_resolve_explicit_1)
5917 (bidi_level_of_next_char): Call bidi_fetch_char and
5918 bidi_fetch_char_advance instead of FETCH_CHAR and
5920 (bidi_init_it): Initialize new members.
5921 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5923 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5924 instead of using explicit *_CHAR codes.
5925 (bidi_resolve_explicit, bidi_resolve_weak):
5926 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5927 bidirectional text is supported only in multibyte buffers.
5928 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5929 it to initialize the frame_window_p member of struct bidi_it.
5930 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5931 (bidi_resolve_explicit, bidi_resolve_weak)
5932 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5933 bidi_it->nchars is non-positive.
5934 (bidi_level_of_next_char): Don't try to lookup the cache for the
5935 next/previous character if nothing is cached there yet, or if we
5936 were just reseat()'ed to a new position.
5938 * xdisp.c (set_cursor_from_row): Set start and stop points
5939 according to the row's direction when priming the loop that looks
5940 for the glyph on which to display cursor.
5941 (single_display_spec_intangible_p): Function deleted.
5942 (display_prop_intangible_p): Reimplement to call
5943 handle_display_spec instead of single_display_spec_intangible_p.
5944 Accept 3 additional arguments needed by handle_display_spec.
5945 This fixes incorrect cursor motion across display property with complex
5946 values: lists, `(when COND...)' forms, etc.
5947 (single_display_spec_string_p): Support property values that are
5948 lists with the argument STRING its top-level element.
5949 (display_prop_string_p): Fix the condition for processing a
5950 property that is a list to be consistent with handle_display_spec.
5951 (handle_display_spec): New function, refactored from the
5952 last portion of handle_display_prop.
5953 (compute_display_string_pos): Accept additional argument
5954 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5955 value of a `display' property is a "replacing spec".
5956 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5957 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5958 the display property, but just return a value indicating whether
5959 the display property will replace the characters it covers.
5960 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5961 frame_window_p members of struct bidi_it.
5962 (compute_display_string_pos, compute_display_string_end):
5964 (push_it): Accept second argument POSITION, where pop_it should
5965 jump to continue iteration.
5966 (reseat_1): Initialize bidi_it.disp_pos.
5968 * keyboard.c (adjust_point_for_property): Adjust the call to
5969 display_prop_intangible_p to its new signature.
5971 * dispextern.h (struct bidi_it): New member frame_window_p.
5972 (bidi_init_it): Update prototypes.
5973 (display_prop_intangible_p): Update prototype.
5974 (compute_display_string_pos, compute_display_string_end):
5976 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5979 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5981 Malloc failure behavior now depends on size of allocation.
5982 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5983 * lisp.h: Change signatures accordingly.
5984 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5985 All callers changed. (Bug#8762)
5987 * gnutls.c: Use Emacs's memory allocators.
5988 Without this change, the gnutls library would invoke malloc etc.
5989 directly, which causes problems on non-SYNC_INPUT hosts, and which
5990 runs afoul of improving memory_full behavior. (Bug#8761)
5991 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5992 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5993 xfree instead of the default malloc, realloc, free.
5994 (Fgnutls_boot): No need to check for memory allocation failure,
5995 since xmalloc does that for us.
5997 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5998 * category.c (hash_get_category_set):
5999 * ccl.c (ccl_driver):
6000 * charset.c (Fdefine_charset_internal):
6001 * charset.h (struct charset.hash_index):
6002 * composite.c (get_composition_id, gstring_lookup_cache)
6003 (composition_gstring_put_cache):
6004 * composite.h (struct composition.hash_index):
6005 * dispextern.h (struct image.hash):
6006 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6007 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6008 (hashfn_equal, hashfn_user_defined, make_hash_table)
6009 (maybe_resize_hash_table, hash_lookup, hash_put)
6010 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6011 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6012 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6013 * image.c (make_image, search_image_cache, lookup_image)
6014 (xpm_put_color_table_h):
6015 * lisp.h (struct Lisp_Hash_Table):
6016 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6017 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6018 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6019 * alloc.c (allocate_vectorlike):
6020 Check for overflow in vector size calculations.
6021 * ccl.c (ccl_driver):
6022 Check for overflow when converting EMACS_INT to int.
6023 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6024 need to be updated by these changes.
6025 * fns.c (make_hash_table, maybe_resize_hash_table):
6026 Check for integer overflow with large hash tables.
6027 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6028 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6029 (SXHASH_REDUCE): New macro.
6030 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6031 Use it instead of discarding useful hash info with large hash values.
6032 (sxhash_float): New function.
6033 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6034 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6035 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6036 Rewrite to use FIXNUM_BITS, as this simplifies things.
6037 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6038 Adjust signatures to match updated version of code.
6039 (consing_since_gc): Now EMACS_INT, since a single hash table can
6040 use more than INT_MAX bytes.
6042 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6044 Make it possible to build with GCC-4.6+ -O2 -flto.
6046 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6048 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6050 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6051 Call minibuffer-inactive-mode.
6053 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6055 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6056 Update dependencies.
6058 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6060 * data.c (init_data): Remove code for UTS, this system is not
6063 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6065 Don't force ./temacs to start in terminal mode.
6067 * frame.c (make_initial_frame): Initialize faces in all cases, not
6068 only when CANNOT_DUMP is defined.
6069 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6071 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6073 * dispnew.c (add_window_display_history): Use const for the string
6074 pointer. Remove declaration, not needed.
6076 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6078 Use 'inline', not 'INLINE'.
6079 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6080 * alloc.c, fontset.c (INLINE): Remove.
6081 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6082 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6083 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6084 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6085 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6087 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6089 Make it possible to run ./temacs.
6091 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6092 syms_of_callproc does the same thing. Remove test for
6093 "initialized", do it in the caller.
6094 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6096 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6098 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6099 (read_minibuf): Use get_minibuffer.
6100 (syms_of_minibuf): Use DEFSYM.
6101 (Qmetadata): New var.
6102 * data.c (Qbuffer): Don't make it static.
6103 (syms_of_data): Use DEFSYM.
6105 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6107 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6108 (CCL_CODE_MIN): New macro.
6110 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6112 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6114 * eval.c (Qdebug): Now static.
6115 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6116 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6117 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6119 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6121 * image.c: Various fixes to ImageMagick code comments.
6122 (Fimagemagick_types): Doc fix.
6124 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6126 Minor fixes prompted by GCC 4.6.0 warnings.
6128 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6130 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6131 (x_clipboard_manager_save_all): Move extern decl to ...
6132 * xterm.h: ... here, so that it can be checked for consistency.
6134 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6136 * xselect.c (x_clipboard_manager_save_frame)
6137 (x_clipboard_manager_save_all): New functions.
6138 (Fx_clipboard_manager_save): Lisp function deleted.
6140 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6141 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6143 * xterm.h: Update prototype.
6145 2011-05-28 William Xu <william.xwl@gmail.com>
6147 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6150 2011-05-28 Jim Meyering <meyering@redhat.com>
6152 Avoid a sign-extension bug in crypto_hash_function.
6153 * fns.c (to_uchar): Define.
6154 (crypto_hash_function): Use it to convert some newly-signed
6155 variables to unsigned, to avoid sign-extension bugs. For example,
6156 without this change, (md5 "truc") would evaluate to
6157 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6158 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6159 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6161 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6163 Integer overflow fixes.
6165 * dbusbind.c: Serial number integer overflow fixes.
6166 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6167 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6168 to hold a serial number that is too large for a fixnum.
6169 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6170 Check for serial numbers out of range. Decode any serial number
6171 that was so large that it became a float. (Bug#8722)
6173 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6174 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6175 Use XFASTINT rather than XUINT when numbers are nonnegative.
6176 (xd_append_arg, Fdbus_method_return_internal):
6177 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6178 arguments, check that Lisp number is nonnegative, rather than
6179 silently wrapping negative numbers around. (Bug#8722)
6180 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6183 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6185 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6187 ccl: Add integer overflow checks.
6188 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6189 (IN_INT_RANGE): New macros.
6190 (ccl_driver): Use them to check for integer overflow when
6191 decoding a CCL program. Many of the new checks are whether XINT (x)
6192 fits in int; it doesn't always, on 64-bit hosts. The new version
6193 doesn't catch all possible integer overflows, but it's an
6194 improvement. (Bug#8719)
6196 * alloc.c (make_event_array): Use XINT, not XUINT.
6197 There's no need for unsigned here.
6199 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6200 This follows up to the 2011-05-06 change that substituted uintptr_t
6201 for EMACS_INT. This case wasn't caught back then.
6203 Rework Fformat to avoid integer overflow issues.
6204 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6205 now (part of C89). Include <verify.h>.
6206 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6207 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6208 (Fformat): Avoid the prepass trying to compute sizes; it was only
6209 approximate and thus did not catch overflow reliably. Instead, walk
6210 through the format just once, formatting and computing sizes as we go,
6211 checking for integer overflow at every step, and allocating a larger
6212 buffer as needed. Keep track separately whether the format is
6213 multibyte. Keep only the most-recently calculated precision, rather
6214 than them all. Record whether each argument has been converted to
6215 string. Use EMACS_INT, not int, for byte and char and arg counts.
6216 Support field widths and precisions larger than INT_MAX. Avoid
6217 sprintf's undefined behavior with conversion specifications such as %#d
6218 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6219 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6220 formatting out-of-range floating point numbers with int
6223 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6225 * data.c: Avoid integer truncation in expressions involving floats.
6226 * data.c: Include <intprops.h>.
6227 (arith_driver): When there's an integer overflow in an expression
6228 involving floating point, convert the integers to floating point
6229 so that the resulting value does not suffer from catastrophic
6230 integer truncation. For example, on a 64-bit host (* 4
6231 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6232 Do not rely on undefined behavior after integer overflow.
6234 merge count_size_as_multibyte, parse_str_to_multibyte
6235 * character.c, character.h (count_size_as_multibyte):
6236 Rename from parse_str_to_multibyte; all uses changed.
6237 Check for integer overflow.
6238 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6239 since it's now a duplicate of the other. This is more of
6240 a character than a buffer op, so better that it's in character.c.
6241 * fns.c, print.c: Adjust to above changes.
6243 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6245 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6247 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6249 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6250 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6251 (x_clipboard_manager_save): Now static.
6252 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6254 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6255 (crypto_hash_function): Now static.
6256 Fix pointer signedness problems. Avoid unnecessary initializations.
6258 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6260 * termhooks.h (Vselection_alist): Make it terminal-local.
6262 * terminal.c (create_terminal): Initialize it.
6264 * xselect.c: Support for clipboard managers.
6265 (Vselection_alist): Move to termhooks.h as terminal-local var.
6266 (LOCAL_SELECTION): New macro.
6267 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6268 (symbol_to_x_atom): Remove gratuitous arg.
6269 (x_handle_selection_request, lisp_data_to_selection_data)
6270 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6271 (x_own_selection, x_get_local_selection, x_convert_selection):
6272 New arg, specifying work frame. Use terminal-local Vselection_alist.
6273 (some_frame_on_display): Delete unused function.
6274 (Fx_own_selection_internal, Fx_get_selection_internal)
6275 (Fx_disown_selection_internal, Fx_selection_owner_p)
6276 (Fx_selection_exists_p): New optional frame arg.
6277 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6278 (x_handle_selection_clear): Don't treat other terminals with the
6279 same keyboard specially. Use the terminal-local Vselection_alist.
6280 (x_clear_frame_selections): Use Frun_hook_with_args.
6282 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6284 * xterm.h: Add support for those atoms.
6286 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6288 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6289 (converted_selections, conversion_fail_tag): New global variables.
6290 (x_selection_request_lisp_error): Free the above.
6291 (x_get_local_selection): Remove unnecessary code.
6292 (x_reply_selection_request): Args changed; handle arbitrary array
6293 of converted selections stored in converted_selections.
6294 Separate the XChangeProperty and SelectionNotify steps.
6295 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6296 (x_convert_selection): New function.
6297 (x_handle_selection_event): Simplify.
6298 (x_get_foreign_selection): Don't ignore incoming requests while
6299 waiting for an answer; this will fail when we implement
6300 SAVE_TARGETS, and seems unnecessary anyway.
6301 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6302 (Vx_sent_selection_functions): Doc fix.
6304 2011-05-26 Leo Liu <sdl.web@gmail.com>
6306 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6308 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6310 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6312 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6313 for fringe update if it has periodic bitmap.
6314 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6315 and fringe_bitmap_periodic_p.
6317 * fringe.c (get_fringe_bitmap_data): New function.
6318 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6319 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6320 row. Mark glyph row for fringe update if periodicity changed.
6322 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6323 for fringe update unless it has periodic bitmap.
6325 2011-05-25 Kenichi Handa <handa@m17n.org>
6327 * xdisp.c (get_next_display_element): Set correct it->face_id for
6328 a static composition.
6330 2011-05-24 Leo Liu <sdl.web@gmail.com>
6333 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6335 * fns.c (crypto_hash_function, Fsha1): New function.
6336 (Fmd5): Use crypto_hash_function.
6337 (syms_of_fns): Add Ssha1.
6339 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6341 * gnutls.c: Remove unused macros.
6342 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6343 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6344 Remove macros that are defined and never used.
6345 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6347 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6349 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6350 (Fx_get_selection_internal): Minor cleanup.
6351 (Fx_own_selection_internal): Rename arguments for consistency with
6354 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6356 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6358 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6360 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6362 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6364 * dispnew.c (scrolling_window): Don't exclude the case that the
6365 last enabled row in the desired matrix touches the bottom boundary.
6367 2011-05-21 Glenn Morris <rgm@gnu.org>
6369 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6370 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6371 and add some more files.
6373 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6375 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6376 report_file_error introduced by the change from 2011-05-07.
6378 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6380 * systime.h (Time): Define only if emacs is defined.
6381 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6382 where the include path doesn't have X11/X.h by default. See
6383 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6385 2011-05-20 Kenichi Handa <handa@m17n.org>
6387 * composite.c (find_automatic_composition): Fix previous change.
6389 2011-05-20 Glenn Morris <rgm@gnu.org>
6391 * lisp.mk: New file, split from Makefile.in.
6392 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6393 (shortlisp): Remove.
6394 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6396 2011-05-19 Glenn Morris <rgm@gnu.org>
6398 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6399 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6400 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6401 (lisp): Set the order to that of loadup.el.
6402 (shortlisp): Make it a copy of $lisp.
6403 (SOME_MACHINE_LISP): Remove.
6404 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6405 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6407 2011-05-18 Kenichi Handa <handa@m17n.org>
6409 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6410 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6411 (find_automatic_composition): Mostly rewrite for efficiency.
6413 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6415 * makefile.w32-in: Update dependencies.
6417 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6419 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6420 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6422 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6424 Fix some integer overflow issues, such as string length overflow.
6426 * insdel.c (count_size_as_multibyte): Check for string overflow.
6428 * character.c (lisp_string_width): Check for string overflow.
6429 Use EMACS_INT, not int, for string indexes and lengths; in
6430 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6431 the resulting string length overflows an EMACS_INT; instead,
6432 report a string overflow if no precision given. When checking for
6433 precision exhaustion, use a check that cannot possibly have
6434 integer overflow. (Bug#8675)
6435 * character.h (lisp_string_width): Adjust to new signature.
6437 * alloc.c (string_overflow): New function.
6438 (Fmake_string): Use it. This doesn't change behavior, but saves
6439 a few bytes and will simplify future changes.
6440 * character.c (string_escape_byte8): Likewise.
6441 * lisp.h (string_overflow): New decl.
6443 Fixups, following up to the user-interface timestamp change.
6444 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6445 for UI timestamps, instead of unsigned long.
6446 * msdos.c (mouse_get_pos): Likewise.
6447 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6448 * w32gui.h (Time): Define by including "systime.h" rather than by
6449 declaring it ourselves. (Bug#8664)
6451 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6452 * image.c (clear_image_cache): Likewise.
6454 * term.c (term_mouse_position): Don't assume time_t wraparound.
6456 Be more systematic about user-interface timestamps.
6457 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6458 and sometimes 'EMACS_UINT', to represent these timestamps.
6459 This change causes it to use 'Time' uniformly, as that's what X uses.
6460 This makes the code easier to follow, and makes it easier to catch
6461 integer overflow bugs such as Bug#8664.
6462 * frame.c (Fmouse_position, Fmouse_pixel_position):
6463 Use Time, not unsigned long, for user-interface timestamps.
6464 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6465 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6466 * keyboard.h (last_event_timestamp): Likewise.
6467 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6468 * menu.h (xmenu_show): Likewise.
6469 * term.c (term_mouse_position): Likewise.
6470 * termhooks.h (struct input_event.timestamp): Likewise.
6471 (struct terminal.mouse_position_hook): Likewise.
6472 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6473 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6474 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6475 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6477 * menu.h, termhooks.h: Include "systime.h", for Time.
6479 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6480 Don't assume that the difference between two unsigned long values
6481 can fit into an integer. At this point, we know button_down_time
6482 <= event->timestamp, so the difference must be nonnegative, so
6483 there's no need to cast the result if double-click-time is
6484 nonnegative, as it should be; check that it's nonnegative, just in
6485 case. This bug is triggered when events are more than 2**31 ms
6486 apart (about 25 days). (Bug#8664)
6488 * xselect.c (last_event_timestamp): Remove duplicate decl.
6489 (x_own_selection): Remove needless cast to unsigned long.
6491 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6492 that always fit in int. Use a sentinel instead of a counter, to
6493 avoid a temp and to allay GCC's concerns about possible int overflow.
6494 * frame.h (struct frame): Use int for menu_bar_items_used
6495 instead of EMACS_INT, since it always fits in int.
6497 * menu.c (grow_menu_items): Check for int overflow.
6499 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6501 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6502 Before, the code was not consistent. These values cannot exceed
6503 2**31 - 1 so there's no need to make them unsigned.
6504 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6505 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6506 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6508 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6510 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6511 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6512 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6513 presumably because the widths might not match.
6515 * window.c (size_window): Avoid needless test at loop start.
6517 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6519 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6521 2011-05-12 Drew Adams <drew.adams@oracle.com>
6523 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6525 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6527 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6528 `width' to `bar_area_x' and `bar_area_width', respectively.
6529 (x_scroll_run): Take account of fringe background extension.
6531 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6532 Rename local vars `left' and `width' to `bar_area_x' and
6533 `bar_area_width', respectively.
6534 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6535 background extension.
6537 2011-05-10 Jim Meyering <meyering@redhat.com>
6539 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6541 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6543 * image.c (Finit_image_library): Return t for built-in image types,
6544 like pbm and xbm. (Bug#8640)
6546 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6548 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6550 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6552 * w32console.c (Fset_screen_color): Doc fix.
6553 (Fget_screen_color): New function.
6554 (syms_of_ntterm): Defsubr it.
6556 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6557 unlink the temporary file if Fcall_process didn't create it in the
6559 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6560 child process will be redirected to a file specified with `:file'.
6561 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6562 cue to call_process_cleanup not to close that handle.
6564 2011-05-07 Ben Key <bkey76@gmail.com>
6566 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6567 one of two shell specific rules, either bootstrap-temacs-CMD or
6568 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6569 to the previous implementation of the bootstrap-temacs rule.
6570 The bootstrap-temacs-CMD rule is similar to the previous
6571 implementation of the bootstrap-temacs rule except that it
6572 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6575 These changes, along with some changes to nt/configure.bat,
6576 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6577 earlier fix to add support for --cflags and --ldflags options
6578 that include quotes so that it works whether make uses cmd or
6581 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6583 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6584 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6586 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6587 a string. Handle both cases.
6588 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6589 (Fdbus_register_method): Use Qinvalid_function.
6591 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6593 * makefile.w32-in: Update dependencies.
6594 (LISP_H): Add inttypes.h and stdin.h.
6595 (PROCESS_H): Add unistd.h.
6597 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6599 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6600 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6602 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6604 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6606 * term.c (vfatal): Remove stray call to va_end.
6607 It's not needed and the C Standard doesn't allow it here anyway.
6609 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6610 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6612 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6615 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6617 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6619 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6621 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6623 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6625 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6626 * charset.c (Fdefine_charset_internal): Don't initialize
6627 charset.code_space[15]. The value was garbage, on hosts with
6628 32-bit int (Bug#8600).
6630 * lread.c (read_integer): Be more consistent with string-to-number.
6631 Use string_to_number to do the actual conversion; this avoids
6632 rounding errors and fixes some other screwups. Without this fix,
6633 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6634 (digit_to_number): Move earlier, for benefit of read_integer.
6635 Return -1 if the digit is out of range for the base, -2 if it is
6636 not a digit in any supported base. (Bug#8602)
6638 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6640 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6641 to match comment at start of function. This also removes a
6642 GCC warning about overflow in a 32+64-bit port.
6644 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6646 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6647 Reported by Stefan Monnier in
6648 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6649 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6650 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6652 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6653 (EMACS_UINTPTR): Likewise, with uintptr_t.
6655 * lisp.h: Prefer 64-bit EMACS_INT if available.
6656 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6657 on 32-bit hosts that have 64-bit int, so that they can access
6659 However, temporarily disable this change unless the temporary
6660 symbol WIDE_EMACS_INT is defined.
6662 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6664 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6665 This removes an assumption that EMACS_INT and long are the same
6666 width as pointers. The assumption is true for Emacs porting targets
6667 now, but we want to make other targets possible.
6668 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6669 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6670 In the rest of the code, change types of integers that hold casted
6671 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6672 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6673 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6674 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6675 No need to cast type when ORing.
6676 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6677 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6678 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6679 assume EMACS_INT is the same width as char *.
6680 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6681 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6682 Remove no-longer-needed casts.
6683 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6684 (xg_tool_bar_help_callback, xg_make_tool_item):
6685 Use EMACS_INTPTR to hold an integer
6686 that will be cast to void *; this can avoid a GCC warning
6687 if EMACS_INT is not the same width as void *.
6688 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6689 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6690 (current_message_1, set_message_1):
6691 Use a local to convert to proper width without a cast.
6692 * xmenu.c (dialog_selection_callback): Likewise.
6694 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6695 Also, don't assume VALBITS / RAND_BITS is less than 5,
6696 and don't rely on undefined behavior when shifting a 1 left into
6698 * lisp.h (get_random): Change signature to match.
6700 * lread.c (hash_string): Use size_t, not int, for hash computation.
6701 Normally we prefer signed values; but hashing is special, because
6702 it's better to use unsigned division on hash table sizes so that
6703 the remainder is nonnegative. Also, size_t is the natural width
6704 for hashing into memory. The previous code used 'int', which doesn't
6705 retain enough info to hash well into very large tables.
6706 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6708 * dbusbind.c: Don't possibly lose pointer info when converting.
6709 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6710 Use XPNTR rather than XHASH, so that the high-order bits of
6711 the pointer aren't lost when converting through void *.
6713 * eval.c (Fautoload): Don't double-shift a pointer.
6715 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6717 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6719 * gnutls.c (DEF_GNUTLS_FN):
6720 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6722 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6724 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6727 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6729 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6730 New version that can reserve upto 2GB of heap space.
6732 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6734 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6736 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6738 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6739 `gnutls_certificate_set_x509_key_file'.
6741 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6743 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6744 Update dependencies.
6746 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6748 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6749 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6750 Remove unused parameter `fildes'.
6751 * process.c (read_process_output, send_process): Don't pass it.
6753 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6755 Fix previous change: the library cache is defined in w32.c.
6756 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6757 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6759 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6761 Implement dynamic loading of GnuTLS on Windows.
6763 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6764 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6765 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6768 * gnutls.c (Qgnutls_dll): Define.
6769 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6770 (gnutls_*): Declare function pointers.
6771 (init_gnutls_functions): New function to initialize function pointers.
6772 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6773 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6774 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6775 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6776 (emacs_gnutls_write, emacs_gnutls_read)
6777 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6778 (Fgnutls_available_p): New function.
6779 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6780 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6781 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6783 * image.c: Include w32.h.
6784 (Vimage_type_cache): Delete.
6785 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6786 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6787 (w32_delayed_load): Move to w32.c.
6789 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6791 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6792 (w32_delayed_load): Move from image.c. When loading a library, record
6793 its filename in the :loaded-from property of the library id.
6794 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6795 Initialize and staticpro them.
6796 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6798 * process.c: Include lisp.h before w32.h, not after.
6799 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6800 instead of gnutls_record_check_pending.
6802 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6804 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6806 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6807 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6810 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6812 * xterm.c (x_set_frame_alpha): Do not set property on anything
6813 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6815 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6817 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6819 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6821 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6822 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6823 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6824 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6825 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6826 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6827 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6828 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6829 (Qgnutls_bootprop_callbacks_verify): Make static.
6831 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6833 * callproc.c: Indentation fixup.
6835 * sysdep.c (wait_for_termination_1): Make static.
6836 (wait_for_termination, interruptible_wait_for_termination):
6837 Move after wait_for_termination_1.
6839 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6841 * sysdep.c (interruptible_wait_for_termination): New function
6842 which is like wait_for_termination, but allows keyboard
6845 * callproc.c (Fcall_process): Add (:file "file") as an option for
6847 (Fcall_process_region): Ditto.
6849 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6851 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6852 rather than `XVECTOR (FOO)->size'.
6854 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6855 inttypes.h, as a gnulib replacement is used if it not available in
6858 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6860 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6861 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6862 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6864 * coding.c (coding_alloc_by_realloc): Error out if destination
6865 will grow beyond MOST_POSITIVE_FIXNUM.
6866 (decode_coding_emacs_mule): Abort if there isn't enough place in
6867 charbuf for the composition carryover bytes. Reserve an extra
6868 space for up to 2 characters produced in a loop.
6869 (decode_coding_iso_2022): Abort if there isn't enough place in
6870 charbuf for the composition carryover bytes.
6872 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6874 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6875 aborting when %lld or %lll format is passed.
6876 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6877 %llo or %llx format is passed. (Bug#8545)
6879 * window.c (window_scroll_line_based): Use a marker instead of
6880 simple variables to record original value of point. (Bug#7952)
6882 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6883 produced by %s or %c overflows available buffer space. (Bug#8545)
6885 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6887 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6888 (SIZE_MAX): Move defn after all includes, as they might #define it.
6890 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6892 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6894 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6896 * keyboard.c (Qdelayed_warnings_hook): Define.
6897 (command_loop_1): Run `delayed-warnings-hook'
6898 if Vdelayed_warnings_list is non-nil.
6899 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6900 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6902 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6904 * doprnt.c (doprnt): Don't return value smaller than the buffer
6905 size if the message was truncated. (Bug#8545).
6907 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6909 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6910 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6912 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6914 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6916 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6918 * makefile.w32-in: Update dependencies.
6920 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6922 Improve `doprnt' and its usage. (Bug#8545)
6923 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6924 `format_end'. Remove support for %l as a conversion specifier.
6925 Don't use xrealloc. Improve diagnostics when the %l size modifier
6926 is used. Update the commentary.
6928 * eval.c (verror): Simplify calculation of size_t.
6930 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6933 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6935 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6938 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6940 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6941 This makes this file independent of the recent pseudovector change.
6943 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6945 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6947 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6948 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6949 Remove unused local.
6950 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6952 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6953 GCC 4.6.0 optimizes based on type-based alias analysis.
6954 For example, if b is of type struct buffer * and v of type struct
6955 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6956 != &v->size, and therefore "v->size = 1; b->size = 2; return
6957 v->size;" must therefore return 1. This assumption is incorrect
6958 for Emacs, since it type-puns struct Lisp_Vector * with many other
6959 types. To fix this problem, this patch adds a new type struct
6960 vectorlike_header that documents the constraints on layout of vectors
6961 and pseudovectors, and helps optimizing compilers not get fooled
6962 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6963 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6964 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6966 (XSETPVECTYPE): Rewrite in terms of new macro.
6967 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6968 This is a bit clearer, and further avoids the possibility of
6969 undesirable aliasing.
6970 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6971 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6972 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6973 since Lisp_Subr is a special case (no "next" field).
6974 (ASIZE): Now uses header.size rather than size.
6975 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6976 to avoid the hassle of writing XVECTOR (foo)->header.size.
6977 (struct vectorlike_header): New type.
6978 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6979 object, to help avoid aliasing.
6980 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6981 (SUBRP): Likewise, since Lisp_Subr is a special case.
6982 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6983 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6984 (struct Lisp_Hash_Table): Combine first two members into a single
6985 struct vectorlike_header member. All uses of "size" and "next" members
6986 changed to be "header.size" and "header.next".
6987 * buffer.h (struct buffer): Likewise.
6988 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6989 * frame.h (struct frame): Likewise.
6990 * process.h (struct Lisp_Process): Likewise.
6991 * termhooks.h (struct terminal): Likewise.
6992 * window.c (struct save_window_data, struct saved_window): Likewise.
6993 * window.h (struct window): Likewise.
6994 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6995 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6996 * buffer.c (init_buffer_once): Likewise.
6997 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6999 * process.c (Fformat_network_address): Use local var for size,
7002 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7004 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7005 * data.c (atof): Remove decl; no longer used or needed.
7006 (digit_to_number): Move to lread.c.
7007 (Fstring_to_number): Use new string_to_number function, to be
7008 consistent with how the Lisp reader treats infinities and NaNs.
7009 Do not assume that floating-point numbers represent EMACS_INT
7010 without losing information; this is not true on most 64-bit hosts.
7011 Avoid double-rounding errors, by insisting on integers when
7012 parsing non-base-10 numbers, as the documentation specifies.
7013 * lisp.h (string_to_number): New decl, replacing ...
7014 (isfloat_string): Remove.
7015 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7016 (read1): Do not accept +. and -. as integers; this
7017 appears to have been a coding error. Similarly, do not accept
7018 strings like +-1e0 as floating point numbers. Do not report
7019 overflow for integer overflows unless the base is not 10 which
7020 means we have no simple and reliable way to continue.
7021 Break out the floating-point parsing into a new
7022 function string_to_number, so that Fstring_to_number parses
7023 floating point numbers consistently with the Lisp reader.
7024 (digit_to_number): Move here from data.c. Make it static inline.
7025 (E_CHAR, EXP_INT): Remove, replacing with ...
7026 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7027 (string_to_number): New function, replacing isfloat_string.
7028 This function checks for valid syntax and produces the resulting
7029 Lisp float number too. Rework it so that string-to-number
7030 no longer mishandles examples like "1.0e+". Use strtoumax,
7031 so that overflow for non-base-10 numbers is reported only when
7032 there's no portable and simple way to convert to floating point.
7034 * textprop.c (set_text_properties_1): Rewrite for clarity,
7035 and to avoid GCC warning about integer overflow.
7037 * intervals.h (struct interval): Use EMACS_INT for members
7038 where EMACS_UINT might cause problems. See
7039 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7040 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7041 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7043 (offset_intervals): Tell GCC not to worry about length overflow
7044 when negating a negative length.
7046 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7047 (overrun_check_free): Likewise.
7049 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7050 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7053 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7054 (gnutls_make_error): Rename local to avoid shadowing.
7055 (gnutls_emacs_global_deinit): ifdef out; not used.
7056 (Fgnutls_boot): Use const for pointer to readonly storage.
7057 Comment out unused local. Fix pointer signedness problems.
7059 * lread.c (openp): Don't stuff size_t into an 'int'.
7060 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7061 about possible signed overflow.
7063 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7064 (GDK_KEY_g): Don't define if already defined.
7065 (xg_prepare_tooltip): Avoid pointer signedness problem.
7066 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7068 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7069 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7071 * xfns.c (Fx_window_property): Simplify a bit,
7072 to make a bit faster and to avoid GCC 4.6.0 warning.
7073 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7075 * fns.c (internal_equal): Don't assume size_t fits in int.
7077 * alloc.c (compact_small_strings): Tighten assertion a little.
7079 Replace pEd with more-general pI, and fix some printf arg casts.
7080 * lisp.h (pI): New macro, generalizing old pEd macro to other
7081 conversion specifiers. For example, use "...%"pI"d..." rather
7082 than "...%"pEd"...".
7083 (pEd): Remove. All uses replaced with similar uses of pI.
7084 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7085 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7086 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7087 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7088 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7089 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7090 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7092 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7093 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7094 * print.c (safe_debug_print, print_object): Likewise.
7095 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7097 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7098 avoiding the 0 flag, which is not portable.
7099 * process.c (Fmake_network_process): Use pI to avoid cast.
7100 * region-cache.c (pp_cache): Likewise.
7101 * xdisp.c (decode_mode_spec): Likewise.
7102 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7103 behavior on 64-bit hosts with printf arg.
7104 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7105 (x_stop_queuing_selection_requests): Likewise.
7106 (x_get_window_property): Don't truncate byte count to an 'int'
7109 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7110 here, since it parses constructs like leading '-' and spaces,
7111 which are not wanted; and it overflows with large numbers.
7112 Instead, simply match F[0-9]+, which is what is wanted anyway.
7114 * alloc.c: Remove unportable assumptions about struct layout.
7115 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7116 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7117 (allocate_vectorlike, make_pure_vector): Use the new macros,
7118 plus offsetof, to remove unportable assumptions about struct layout.
7119 These assumptions hold on all porting targets that I know of, but
7120 they are not guaranteed, they're easy to remove, and removing them
7121 makes further changes easier.
7123 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7124 This doesn't fix a bug but makes the code clearer.
7125 (string_overrun_cookie): Now const. Use initializers that
7126 don't formally overflow signed char, to avoid warnings.
7127 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7128 can cause Emacs to crash when string overrun checking is enabled.
7129 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7130 multiple of sizeof (EMACS_INT); it need not be, if
7131 alignof(EMACS_INT) < sizeof (EMACS_INT).
7132 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7134 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7136 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7138 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7140 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7141 supposed to be handshaking. (Bug#8556)
7142 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7144 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7146 * lisp.h (Qdebug): List symbol.
7147 * eval.c (Qdebug): Restore global linkage.
7148 * keyboard.c (debug-on-event): New variable.
7149 (handle_user_signal): Break into debugger when debug-on-event
7150 matches the current signal symbol.
7152 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7154 * alloc.c (check_sblock, check_string_bytes)
7155 (check_string_free_list): Convert to standard C.
7157 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7159 * w32.c (emacs_gnutls_push): Fix typo.
7161 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7163 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7164 "cast to pointer from integer of different size".
7166 Improve doprnt and its use in verror. (Bug#8545)
7167 * doprnt.c (doprnt): Document the set of format control sequences
7168 supported by the function. Use SAFE_ALLOCA instead of always
7171 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7172 is one byte too soon. Don't use xrealloc; instead xfree and
7175 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7177 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7180 * gnutls.c: Renamed global_initialized to
7181 gnutls_global_initialized. Added internals for the
7182 :verify-hostname-error, :verify-error, and :verify-flags
7183 parameters of `gnutls-boot' and documented those parameters in the
7184 docstring. Start callback support.
7185 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7186 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7187 on error. Return error code.
7188 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7189 (emacs_gnutls_read): Likewise.
7190 (Fgnutls_boot): Return handshake error code.
7191 (emacs_gnutls_handle_error): New function.
7192 (wsaerror_to_errno): Likewise.
7194 * w32.h (emacs_gnutls_pull): Add prototype.
7195 (emacs_gnutls_push): Likewise.
7197 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7198 (emacs_gnutls_push): Likewise.
7200 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7202 * process.c (wait_reading_process_output): Check if GnuTLS
7203 buffered some data internally if no FDs are set for TLS
7206 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7207 (LIBS): Link to USER_LIBS.
7208 ($(BLD)/gnutls.$(0)): New target.
7210 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7212 * xdisp.c (handle_single_display_spec): Rename the
7213 display_replaced_before_p argument into display_replaced_p, to
7214 make it consistent with the commentary. Fix typos in the
7217 * textprop.c (syms_of_textprop): Remove dead code.
7218 (copy_text_properties): Delete obsolete commentary about an
7219 interface that was deleted long ago. Fix typos in the description
7222 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7223 to changes in oldXMenu/XMenu.h from 2011-04-16.
7224 <menu_help_message, prev_menu_help_message>: Constify.
7225 (IT_menu_make_room): menu->help_text is now `const char **';
7228 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7229 to changes in oldXMenu/XMenu.h from 2011-04-16.
7230 (struct XMenu): Declare `help_text' `const char **'.
7232 * xfaces.c <Qunspecified>: Make extern again.
7234 * syntax.c: Include sys/types.h before including regex.h, as
7237 * doc.c (get_doc_string): Improve the format passed to `error'.
7239 * doprnt.c (doprnt): Improve commentary.
7241 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7243 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7246 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7247 changes in globals.h immediately force recompilation.
7248 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7249 $(CURDIR)/s/ms-w32.h.
7250 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7252 * character.c (Fchar_direction): Function deleted.
7253 (syms_of_character): Don't defsubr it.
7254 <char-direction-table>: Deleted.
7256 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7258 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7259 * doprnt.c: Include limits.h.
7260 (SIZE_MAX): New macro.
7261 (doprnt): Return a size_t value. 2nd arg is now size_t.
7262 Many local variables are now size_t instead of int or unsigned.
7263 Improve overflow protection. Support `l' modifier for integer
7264 conversions. Support %l conversion. Don't assume an EMACS_INT
7265 argument for integer conversions and for %c.
7267 * lisp.h (doprnt): Restore prototype.
7269 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7272 * Makefile.in (base_obj): Add back doprnt.o.
7274 * deps.mk (doprnt.o): Add back prerequisites.
7275 (callint.o): Depend on character.h.
7277 * eval.c (internal_lisp_condition_case): Include the handler
7278 representation in the error message.
7279 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7280 when breaking from the loop.
7282 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7284 * callint.c (Fcall_interactively): When displaying error message
7285 about invalid control letter, pass the character's codepoint, not
7286 a pointer to its multibyte form. Improve display of the character
7287 in octal and display also its hex code.
7289 * character.c (char_string): Use %x to display the (unsigned)
7290 codepoint of an invalid character, to avoid displaying a bogus
7293 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7294 `error', not SYMBOL_NAME itself.
7296 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7297 character arguments to `error'.
7299 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7300 to `error' in error message about FINAL_CHAR argument. Make sure
7301 FINAL_CHAR is a character, and use %c when it is passed as
7302 argument to `error'.
7304 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7306 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7308 * w32.c: Include <time.h>.
7309 (sys_localtime): New function.
7311 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7313 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7315 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7317 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7319 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7322 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7324 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7325 gl_state.e_property when gl_state.object is Qt.
7327 * insdel.c (make_gap_larger): Remove limitation of buffer size
7330 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7332 * xdisp.c (lookup_glyphless_char_display)
7333 (produce_glyphless_glyph): Handle cons cell entry in
7334 glyphless-char-display.
7335 (Vglyphless_char_display): Document it.
7337 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7338 glyphless-char-display.
7340 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7342 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7344 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7346 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7347 definition for no-X builds.
7349 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7351 Static checks with GCC 4.6.0 and non-default toolkits.
7353 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7355 * process.c (keyboard_bit_set): Define only if SIGIO.
7356 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7357 (send_process): Repair possible setjmp clobbering.
7359 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7361 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7363 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7365 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7366 Define only if needed.
7368 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7369 by pacifying GCC about it. Maybe it's time to retire it?
7370 * xfaces.c (USG, __TIMEVAL__): Likewise.
7372 * dispextern.h (struct redisplay_interface): Rename param
7374 * termhooks.h (struct terminal): Likewise.
7375 * xterm.c (xembed_send_message): Likewise.
7377 * insdel.c (make_gap_smaller): Define only if
7378 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7380 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7383 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7384 so that we aren't warned about unused symbols.
7386 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7388 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7390 * xfns.c (x_real_positions): Mark locals as initialized.
7392 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7394 * xterm.c: Fix problems found by static analysis with other toolkits.
7395 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7396 (x_dispatch_event): Declare static if USE_GTK, and
7397 define if USE_GTK || USE_X_TOOLKIT.
7398 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7399 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7400 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7401 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7403 * xmenu.c (menu_help_callback): Pointer type fixes.
7404 Use const pointers when pointing at readonly data. Avoid pointer
7406 (FALSE): Remove unused macro.
7407 (update_frame_menubar): Remove unused decl.
7409 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7411 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7412 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7413 (single_menu_item): Rename local to avoid shadowing.
7415 * keyboard.c (make_lispy_event): Remove unused local var.
7417 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7418 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7420 * bitmaps: Change bitmaps from unsigned char back to the X11
7421 compatible char. Avoid the old compiler warnings about
7422 out-of-range initializers by using, for example, '\xab' rather
7425 * xgselect.c (xgselect_initialize): Check vs interface
7426 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7428 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7430 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7431 to read-only memory.
7433 * fns.c (vector): Remove; this old hack is no longer needed.
7435 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7437 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7439 * xrdb.c (x_load_resources): Omit unused local.
7441 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7442 (x_window): Rename locals to avoid shadowing.
7443 (USG): Use the kludged USG macro, to pacify gcc.
7445 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7446 (x_term_init): Remove local to avoid shadowing.
7448 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7450 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7451 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7453 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7455 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7457 Fix regex.c, syntax.c and friends for buffers > 2GB.
7458 * syntax.h (struct gl_state_s): Declare character position members
7461 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7463 * textprop.c (verify_interval_modification, interval_of):
7464 Declare arguments EMACS_INT.
7466 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7469 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7471 * indent.c (Fvertical_motion): Local variable it_start is now
7474 * regex.c (re_match, re_match_2, re_match_2_internal)
7475 (bcmp_translate, regcomp, regexec, print_double_string)
7476 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7477 (re_compile_pattern, re_exec): Declare arguments and local
7478 variables `size_t' and `ssize_t' and return values `regoff_t', as
7480 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7481 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7482 <compile_stack_type>: `size' and `avail' are now `size_t'.
7484 * regex.h <regoff_t>: Use ssize_t, not int.
7485 (re_search, re_search_2, re_match, re_match_2): Arguments that
7486 specify buffer/string position and length are now ssize_t and
7487 size_t. Return type is regoff_t.
7489 2011-04-16 Ben Key <bkey76@gmail.com>
7491 * nsfont.m: Fixed bugs in ns_get_family and
7492 ns_descriptor_to_entity that were caused by using free to
7493 deallocate memory blocks that were allocated by xmalloc (via
7494 xstrdup). This caused Emacs to crash when compiled with
7495 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7496 --enable-checking=xmallocoverrun). xfree is now used to
7497 deallocate these memory blocks.
7499 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7501 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7503 emacs_write: Accept and return EMACS_INT for sizes.
7504 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7506 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7507 Accept and return EMACS_INT.
7508 (emacs_gnutls_write): Return the number of bytes written on
7510 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7511 (emacs_read, emacs_write): Remove check for negative size, as the
7512 Emacs source code has been audited now.
7513 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7514 (emacs_read, emacs_write): Use it.
7515 * process.c (send_process): Adjust to the new signatures of
7516 emacs_write and emacs_gnutls_write. Do not attempt to store
7517 a byte offset into an 'int'; it might overflow.
7518 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7520 * sound.c: Don't assume sizes fit in 'int'.
7521 (struct sound_device.period_size, alsa_period_size):
7522 Return EMACS_INT, not int.
7523 (struct sound_device.write, vox_write, alsa_write):
7524 Accept EMACS_INT, not int.
7525 (wav_play, au_play): Use EMACS_INT to store sizes and to
7526 record read return values.
7528 2011-04-15 Ben Key <bkey76@gmail.com>
7530 * keyboard.c (Qundefined): Don't declare static since it is used
7532 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7533 static since they are used in nsfont.m.
7535 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7537 * process.c (Qprocessp): Don't declare static.
7538 * lisp.h (Qprocessp): Declare again.
7540 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7542 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7544 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7546 Improve C-level modularity by making more things 'static'.
7548 Don't publish debugger-only interfaces to other modules.
7549 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7550 (verify_bytepos, count_markers): Move decls to the only modules
7552 * region-cache.h (pp_cache): Likewise.
7553 * window.h (check_all_windows): Likewise.
7554 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7556 * sysdep.c (croak): Now static, if
7557 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7558 * syssignal.h (croak): Declare only if not static.
7560 * alloc.c (refill_memory_reserve): Now static if
7561 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7562 * lisp.h (refill_memory_reserve): Declare only if not static.
7564 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7565 Define only if USE_LUCID.
7567 * xrdb.c (x_customization_string, x_rm_string): Now static.
7569 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7570 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7572 * xdisp.c (draw_row_with_mouse_face): Now static.
7573 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7575 * window.h (check_all_windows): Mark externally visible.
7577 * window.c (window_deletion_count): Now static.
7579 * undo.c: Make symbols static if they're not exported.
7580 (last_undo_buffer, last_boundary_position, pending_boundary):
7583 * textprop.c (interval_insert_behind_hooks): Now static.
7584 (interval_insert_in_front_hooks): Likewise.
7586 * term.c: Make symbols static if they're not exported.
7587 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7588 (max_frame_lines, tty_set_terminal_modes):
7589 (tty_reset_terminal_modes, tty_turn_off_highlight):
7590 (get_tty_terminal): Now static.
7591 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7592 * termhooks.h (term_mouse_moveto): Do not declare if
7594 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7595 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7597 * sysdep.c: Make symbols static if they're not exported.
7598 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7600 (sigprocmask_set, full_mask): Remove; unused.
7601 (wait_debugging): Mark as visible.
7602 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7603 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7605 * syntax.c (syntax_temp): Define only if !__GNUC__.
7607 * sound.c (current_sound_device, current_sound): Now static.
7609 * search.c (searchbufs, searchbuf_head): Now static.
7611 * scroll.c (scroll_cost): Remove; unused.
7612 * dispextern.h (scroll_cost): Remove decl.
7614 * region-cache.h (pp_cache): Mark as externally visible.
7616 * process.c: Make symbols static if they're not exported.
7617 (process_tick, update_tick, create_process, chan_process):
7618 (Vprocess_alist, proc_buffered_char, datagram_access):
7619 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7620 (deactivate_process): Mark defn as static, as well as decl.
7621 * lisp.h (create_process): Remove decl.
7622 * process.h (chan_process, Vprocess_alist): Remove decls.
7624 * print.c: Make symbols static if they're not exported.
7625 (print_depth, new_backquote_output, being_printed, print_buffer):
7626 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7627 (print_interval, print_number_index, initial_stderr_stream):
7629 * lisp.h (Fprinc): Remove decl.
7630 (debug_output_compilation_hack): Mark as externally visible.
7632 * sysdep.c (croak): Move decl from here to syssignal.h.
7633 * syssignal.h (croak): Put it here, so the API can be checked when
7634 'croak' is called from dissociate_if_controlling_tty.
7636 * minibuf.c: Make symbols static if they're not exported.
7637 (minibuf_save_list, choose_minibuf_frame): Now static.
7638 * lisp.h (choose_minibuf_frame): Remove decl.
7640 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7642 * lread.c: Make symbols static if they're not exported.
7643 (read_objects, initial_obarray, oblookup_last_bucket_number):
7645 (make_symbol): Remove; unused.
7646 * lisp.h (initial_obarray, make_symbol): Remove decls.
7648 * keyboard.c: Make symbols static if they're not exported.
7649 (single_kboard, recent_keys_index, total_keys, recent_keys):
7650 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7651 (this_single_command_key_start, echoing, last_auto_save):
7652 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7653 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7654 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7655 (Vlispy_mouse_stem, double_click_count):
7657 (force_auto_save_soon): Define only if SIGDANGER.
7658 (ignore_mouse_drag_p): Now static if
7659 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7660 (print_help): Remove; unused.
7661 (stop_character, last_timer_event): Mark as externally visible.
7662 * keyboard.h (ignore_mouse_drag_p): Declare only if
7663 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7664 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7665 * lisp.h (echoing): Remove decl.
7666 (force_auto_save_soon): Declare only if SIGDANGER.
7667 * xdisp.c (redisplay_window): Simplify code, to make it more
7668 obvious that ignore_mouse_drag_p is not accessed if !defined
7669 USE_GTK && !defined HAVE_NS.
7671 * intervals.c: Make symbols static if they're not exported.
7672 (merge_properties_sticky, merge_interval_right, delete_interval):
7674 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7676 * insdel.c: Make symbols static if they're not exported.
7677 However, leave prepare_to_modify_buffer alone. It's never
7678 called from outside this function, but that appears to be a bug.
7679 (combine_after_change_list, combine_after_change_buffer):
7680 (adjust_after_replace, signal_before_change): Now static.
7681 (adjust_after_replace_noundo): Remove; unused.
7682 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7683 (signal_before_change): Remove decls.
7685 * indent.c (val_compute_motion, val_vmotion): Now static.
7687 * image.c: Make symbols static if they're not exported.
7688 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7690 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7691 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7693 * fringe.c (standard_bitmaps): Now static.
7694 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7696 * frame.c: Make symbols static if they're not exported.
7697 (x_report_frame_params, make_terminal_frame): Now static.
7698 (get_frame_param): Now static, unless HAVE_NS.
7699 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7700 (x_get_resource_string): Remove; not used.
7701 * frame.h (make_terminal_frame, x_report_frame_params):
7702 (x_get_resource_string); Remove decls.
7703 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7704 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7706 * font.c, fontset.c: Make symbols static if they're not exported.
7707 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7708 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7709 * font.c (font_close_object): Now static.
7710 * font.h (font_close_object): Remove.
7711 * fontset.c (FONTSET_OBJLIST): Remove.
7712 (free_realized_fontset) #if-0 the body, which does nothing.
7713 (face_suitable_for_char_p): #if-0, as it's never called.
7714 * fontset.h (face_suitable_for_char_p): Remove decl.
7715 * xfaces.c (face_at_string_position):
7716 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7717 since 0 is always ASCII.
7719 * fns.c (weak_hash_tables): Now static.
7721 * fileio.c: Make symbols static if they're not exported.
7722 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7723 (Vwrite_region_annotation_buffers): Now static.
7725 * eval.c: Make symbols static if they're not exported.
7726 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7727 * lisp.h (backtrace_list): Remove decl.
7729 * emacs.c: Make symbols static if they're not exported.
7730 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7731 (fatal_error_code, fatal_error_signal_hook, standard_args):
7733 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7734 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7735 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7736 * lisp.h (fatal_error_signal_hook): Remove decl.
7737 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7739 * editfns.c: Move a (normally-unused) function to its only use.
7740 * editfns.c, lisp.h (get_operating_system_release): Remove.
7741 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7742 worth the hassle of breaking this out.
7744 * xterm.c: Make symbols static if they're not exported.
7745 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7746 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7747 (x_destroy_window, x_delete_display):
7749 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7750 (x_mouse_leave): Remove; unused.
7751 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7752 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7753 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7755 (x_mouse_leave): Declare only if WINDOWSNT.
7756 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7757 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7760 * ftxfont.c: Make symbols static if they're not exported.
7761 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7763 * font.h (ftxfont_driver): Likewise.
7765 * xfns.c: Make symbols static if they're not exported.
7766 (x_last_font_name, x_display_info_for_name):
7767 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7768 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7769 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7770 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7771 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7772 (last_show_tip_args): Now static.
7773 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7774 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7775 (x_screen_planes): Remove; unused.
7776 * dispextern.h (x_screen_planes): Remove decl.
7778 * dispnew.c: Make symbols static if they're not exported.
7779 * dispextern.h (redraw_garbaged_frames, scrolling):
7780 (increment_row_positions): Remove.
7781 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7782 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7784 (redraw_garbaged_frames): Remove; unused.
7786 * xfaces.c: Make symbols static if they're not exported.
7787 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7789 * xterm.h (defined_color): Remove decls.
7790 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7791 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7792 (menu_face_changed_default, defined_color, free_realized_face):
7793 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7794 (ascii_face_of_lisp_face): Remove; unused.
7796 * xdisp.c: Make symbols static if they're not exported.
7797 * dispextern.h (scratch_glyph_row, window_box_edges):
7798 (glyph_to_pixel_coords, set_cursor_from_row):
7799 (get_next_display_element, set_iterator_to_next):
7800 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7801 (show_mouse_face): Remove decls
7802 * frame.h (message_buf_print): Likewise.
7803 * lisp.h (pop_message, set_message, check_point_in_composition):
7805 * xterm.h (set_vertical_scroll_bar): Likewise.
7806 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7807 (message_buf_print, scratch_glyph_row, displayed_buffer):
7808 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7809 (get_next_display_element, show_mouse_face, window_box_edges):
7810 (frame_to_window_pixel_xy, check_point_in_composition):
7811 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7812 (glyph_to_pixel_coords): Remove; unused.
7814 * dired.c (file_name_completion): Now static.
7816 * dbusbind.c (xd_in_read_queued_messages): Now static.
7818 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7819 * data.c (circular_list_error): Remove.
7821 * commands.h (last_point_position, last_point_position_buffer):
7822 (last_point_position_window): Remove decls.
7823 * keyboard.c: Make these variables static.
7825 * coding.h (coding, code_convert_region, encode_coding_gap):
7827 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7828 (iso_code_class, detect_coding, code_convert_region): Now static.
7829 (encode_coding_gap): Remove; unused.
7831 * chartab.c (chartab_chars, chartab_bits): Now static.
7833 * charset.h (charset_iso_8859_1): Remove decl.
7834 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7837 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7838 * ccl.c (Vccl_program_table): Now static.
7839 (check_ccl_update): Remove; unused.
7841 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7842 * category.h: ... from here.
7843 * category.c (check_category_table, set_category_set): Now static.
7845 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7846 * lisp.h: Remove these decls.
7848 * buffer.c (buffer_count): Remove unused var.
7850 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7851 so that it's not optimized away.
7852 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7853 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7854 exported only to the debugger.
7856 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7857 * atimer.h (run_all_atimers): Remove; not exported.
7859 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7860 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7861 was inaccessible from Lisp.
7862 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7863 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7865 alloc.c: Import and export fewer symbols, and remove unused items.
7866 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7868 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7869 it's not optimized away by whole-program optimization.
7870 (message_enable_multibyte, free_misc): Remove.
7871 (catchlist, handlerlist, mark_backtrace):
7872 Declare only if BYTE_MARK_STACK.
7873 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7874 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7875 (message_enable_multibyte): Remove decl.
7876 (free_misc, interval_free_list, float_block, float_block_index):
7877 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7878 (cons_free_list, last_marked_index):
7880 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7881 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7882 (mark_backtrace): Define only if BYTE_MARK_STACK.
7883 * xdisp.c (message_enable_multibyte): Now static.
7885 Declare Lisp_Object Q* variables to be 'static' if not exported.
7886 This makes it easier for human readers (and static analyzers)
7887 to see whether these variables are used from other modules.
7888 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7889 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7890 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7891 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7892 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7893 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7894 * xmenu.c, xselect.c:
7895 Declare Q* vars static if they are not used in other modules.
7896 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7897 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7898 Remove decls of unexported vars.
7899 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7901 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7903 Make Emacs functions such as Fatom 'static' by default.
7904 This makes it easier for human readers (and static analyzers)
7905 to see whether these functions can be called from other modules.
7906 DEFUN now defines a static function. To make the function external
7907 so that it can be used in other C modules, use the new macro DEFUE.
7908 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7909 (Finit_image_library):
7910 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7911 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7912 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7913 Remove decls, since these functions are now static.
7914 (Funintern, Fget_internal_run_time): New decls, since these functions
7915 were already external.
7917 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7918 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7919 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7920 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7921 * keyboard.c, keymap.c, lread.c:
7922 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7923 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7924 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7925 Mark functions with DEFUE instead of DEFUN,
7926 if they are used in other modules.
7927 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7928 decls for now-static functions.
7929 * buffer.h (Fdelete_overlay): Remove decl.
7930 * callproc.c (Fgetenv_internal): Mark as internal.
7931 * composite.c (Fremove_list_of_text_properties): Remove decl.
7932 (Fcomposition_get_gstring): New forward static decl.
7933 * composite.h (Fcomposite_get_gstring): Remove decl.
7934 * dired.c (Ffile_attributes): New forward static decl.
7935 * doc.c (Fdocumntation_property): New forward static decl.
7936 * eval.c (Ffetch_bytecode): New forward static decl.
7937 (Funintern): Remove extern decl; now in .h file where it belongs.
7938 * fileio.c (Fmake_symbolic_link): New forward static decl.
7939 * image.c (Finit_image_library): New forward static decl.
7940 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7941 * intervals.h (Fprevious_property_change):
7942 (Fremove_list_of_text_properties): Remove decls.
7943 * keyboard.c (Fthis_command_keys): Remove decl.
7944 (Fcommand_execute): New forward static decl.
7945 * keymap.c (Flookup_key): New forward static decl.
7946 (Fcopy_keymap): Now static.
7947 * keymap.h (Flookup_key): Remove decl.
7948 * process.c (Fget_process): New forward static decl.
7949 (Fprocess_datagram_address): Mark as internal.
7950 * syntax.c (Fsyntax_table_p): New forward static decl.
7951 (skip_chars): Remove duplicate decl.
7952 * textprop.c (Fprevious_property_change): New forward static decl.
7953 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7955 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7956 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7958 * editfns.c (Fformat): Remove unreachable code.
7960 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7962 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7965 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7967 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7968 when at ZV. (Bug#8487)
7970 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7972 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7974 * keyboard.c (parse_tool_bar_item): Likewise.
7975 * sound.c (sound_cleanup, alsa_close): Likewise.
7976 * termcap.c (tgetent): Likewise.
7977 * xfns.c (x_default_font_parameter): Likewise.
7978 * xsettings.c (read_and_apply_settings): Likewise.
7980 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7981 (overrun_check_free): Protoize.
7983 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7985 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7986 since callers should never pass a negative size.
7987 Change the signature to match that of plain 'read' and 'write'; see
7988 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7989 * lisp.h: Update prototypes of emacs_write and emacs_read.
7991 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7993 * xdisp.c (redisplay_window): Don't try to determine the character
7994 position of the scroll margin if the window start point w->startp
7995 is outside the buffer's accessible region. (Bug#8468)
7997 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7999 Fix write-region and its subroutines for buffers > 2GB.
8000 * fileio.c (a_write, e_write): Modify declaration of arguments and
8001 local variables to support buffers larger than 2GB.
8002 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8004 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8005 argument, local variables, and return value.
8007 * lisp.h: Update prototypes of emacs_write and emacs_read.
8009 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8011 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8013 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8015 Fix more problems found by GCC 4.6.0's static checks.
8017 * xdisp.c (vmessage): Use a better test for character truncation.
8019 * charset.c (load_charset_map): <, not <=, for optimization,
8020 and to avoid potential problems with integer overflow.
8021 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8022 * casetab.c (set_identity, shuffle): Likewise.
8023 * editfns.c (Fformat): Likewise.
8024 * syntax.c (skip_chars): Likewise.
8026 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8027 This also lets GCC 4.6.0 generate slightly better loop code.
8029 * callint.c (Fcall_interactively): <, not <=, for optimization.
8030 (Fcall_interactively): Count the number of arguments produced,
8031 not the number of arguments given. This is simpler and lets GCC
8032 4.6.0 generate slightly better code.
8034 * ftfont.c: Distingish more carefully between FcChar8 and char.
8035 The previous code passed unsigned char * to a functions like
8036 strlen and xstrcasecmp that expect char *, which does not
8037 conform to the C standard.
8038 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8039 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8040 char * when the C standard requires it.
8042 * keyboard.c (read_char): Remove unused var.
8044 * eval.c: Port to Windows vsnprintf (Bug#8435).
8046 (SIZE_MAX): Define if the headers do not.
8047 (verror): Do not give up if vsnprintf returns a negative count.
8048 Instead, grow the buffer. This ports to Windows vsnprintf, which
8049 does not conform to C99. Problem reported by Eli Zaretskii.
8050 Also, simplify the allocation scheme, by avoiding the need for
8051 calling realloc, and removing the ALLOCATED variable.
8053 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8055 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8056 But keep the doprint source code for now, as we might revamp it
8057 and use it again (Bug#8435).
8058 * lisp.h (doprnt): Remove.
8059 * Makefile.in (base_obj): Remove doprnt.o.
8060 * deps.mk (doprnt.o): Remove.
8062 error: Print 32- and 64-bit integers portably (Bug#8435).
8063 Without this change, on typical 64-bit hosts error ("...%d...", N)
8064 was used to print both 32- and 64-bit integers N, which relied on
8066 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8067 * lisp.h (error, verror): Mark as printf-like functions.
8068 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8069 Report overflow in size calculations when allocating printf buffer.
8070 Do not truncate output string at its first null byte.
8071 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8072 Truncate the output at a character boundary, since vsnprintf does not
8074 * charset.c (check_iso_charset_parameter): Convert internal
8075 character to string before calling 'error', since %c now has the
8077 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8078 overflow when computing char to be passed to 'error'. Do not
8079 pass Lisp_Object to 'error'; pass the integer instead.
8080 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8081 formatted with plain %d.
8083 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8085 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8087 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8089 * xterm.c (x_catch_errors): Remove duplicate declaration.
8091 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8093 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8095 2011-04-10 Jim Meyering <meyering@redhat.com>
8097 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8098 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8099 return ssize_t not "int", and use size_t as the buffer length.
8100 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8101 * gnutls.h: Update declarations.
8102 * process.c (read_process_output): Use ssize_t, to match.
8103 (send_process): Likewise.
8105 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8107 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8109 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8111 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8112 Use unsigned char, to match FcChar8 type definition.
8114 * xterm.c (handle_one_xevent):
8115 * xmenu.c (create_and_show_popup_menu):
8116 * xselect.c (x_decline_selection_request)
8117 (x_reply_selection_request): Avoid type-punned deref of X events.
8119 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8121 Fix some uses of `int' instead of EMACS_INT.
8122 * search.c (string_match_1, fast_string_match)
8123 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8124 (scan_buffer, find_next_newline_no_quit)
8125 (find_before_next_newline, search_command, Freplace_match)
8126 (Fmatch_data): Make some `int' variables be EMACS_INT.
8128 * xdisp.c (display_count_lines): 3rd argument and return value now
8129 EMACS_INT. All callers changed.
8130 (pint2hrstr): Last argument is now EMACS_INT.
8132 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8133 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8134 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8135 (decode_coding_utf_16, decode_coding_emacs_mule)
8136 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8137 (decode_coding_ccl, decode_coding_charset)
8138 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8139 (decode_coding_iso_2022, decode_coding_emacs_mule)
8140 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8141 <char_offset, last_offset>: Declare EMACS_INT.
8142 (encode_coding_utf_8, encode_coding_utf_16)
8143 (encode_coding_emacs_mule, encode_invocation_designation)
8144 (encode_designation_at_bol, encode_coding_iso_2022)
8145 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8146 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8148 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8149 (encode_invocation_designation): Last argument P_NCHARS is now
8151 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8152 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8154 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8157 * ccl.c (Fccl_execute_on_string): Declare some variables
8160 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8162 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8164 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8166 * process.c (Fformat_network_address): Doc fix.
8168 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8170 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8172 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8174 * keyboard.c (read_char): Call Lisp function help-form-show,
8175 instead of using internal_with_output_to_temp_buffer.
8176 (Qhelp_form_show): New var.
8177 (syms_of_keyboard): Use DEFSYM macro.
8179 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8181 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8183 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8185 * process.c (Flist_processes): Remove to Lisp.
8186 (list_processes_1): Delete.
8188 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8190 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8192 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8194 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8196 Fix more problems found by GCC 4.6.0's static checks.
8198 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8200 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8202 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8204 * xdisp.c (vmessage): Mark as a printf-like function.
8206 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8208 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8210 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8211 printf-like functions.
8212 (tiff_load): Add casts to remove these marks before passing them
8213 to system-supplied API.
8215 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8217 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8218 This avoids several warnings with gcc -Wstrict-overflow.
8219 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8220 directly, rather than having caller test rule sign. This avoids
8221 some unnecessary tests.
8222 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8223 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8224 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8226 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8227 (xfont_open): Avoid unnecessary tests.
8229 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8231 * composite.h, composite.c (composition_gstring_put_cache):
8232 Use EMACS_INT, not int, for length.
8234 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8235 breaking out part of COMPOSITION_DECODE_RULE.
8236 (COMPOSITION_DECODE_RULE): Use it.
8237 * composite.c (get_composition_id): Remove unused local vars,
8238 by using the new macro.
8240 * textprop.c (set_text_properties_1): Change while to do-while,
8241 since the condition is always true at first.
8243 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8244 (interval_deletion_adjustment): Return unsigned value.
8247 * process.c (list_processes_1, create_pty, read_process_output):
8248 (exec_sentinel): Remove vars that were set but not used.
8249 (create_pty): Remove unnecessary "volatile"s.
8250 (Fnetwork_interface_info): Avoid possibility of int overflow.
8251 (read_process_output): Do adaptive read buffering even if carryover.
8252 (read_process_output): Simplify nbytes computation if buffered.
8254 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8256 * syntax.c (scan_words): Remove var that was set but not used.
8257 (update_syntax_table): Use unsigned instead of int.
8259 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8260 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8261 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8263 * print.c (print_error_message): Avoid int overflow.
8265 * font.c (font_list_entities): Redo for clarity,
8266 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8268 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8269 (font_score): Avoid potential overflow in diff calculation.
8271 * fns.c (substring_both): Remove var that is set but not used.
8272 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8274 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8276 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8277 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8278 can always succeed if overflow has undefined behavior.
8280 * search.c (boyer_moore, wordify): Remove vars set but not used.
8281 (wordify): Omit three unnecessary tests.
8283 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8284 All callers changed. This avoids the need for an unused var.
8286 * casefiddle.c (casify_region): Remove var that is set but not used.
8288 * dired.c (file_name_completion): Remove var that is set but not used.
8290 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8292 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8293 (Finsert_file_contents): Remove unnecessary code checking fd.
8295 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8296 Check for integer overflow on size calculations.
8298 * buffer.c (Fprevious_overlay_change): Remove var that is set
8301 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8302 Remove vars that are set but not used.
8303 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8304 (timer_check_2): Mark vars as initialized.
8306 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8308 * image.c (lookup_image): Remove var that is set but not used.
8309 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8311 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8312 that are set but not used.
8314 * xfns.c (make_invisible_cursor): Don't return garbage
8315 if XCreateBitmapFromData fails (Bug#8410).
8317 * xselect.c (x_get_local_selection, x_handle_property_notify):
8318 Remove vars that are set but not used.
8320 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8321 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8323 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8324 Remove var that is set but not used.
8325 (scroll_bar_windows_size): Now size_t, not int.
8326 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8329 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8330 (map_tty_color) [!defined MSDOS]: Likewise.
8332 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8334 * coding.c: Remove vars that are set but not used.
8335 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8336 All callers changed.
8337 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8338 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8339 (decode_coding_charset): Remove vars that are set but not used.
8341 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8342 that is set but not used.
8344 * print.c (print_object): Remove var that is set but not used.
8346 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8347 The gnulib version avoids calling malloc in the usual case,
8348 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8349 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8350 * filelock.c (current_lock_owner): Likewise.
8351 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8352 * sysdep.c: Include allocator.h, careadlinkat.h.
8353 (emacs_no_realloc_allocator): New static constant.
8354 (emacs_readlink): New function.
8355 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8356 ../lib/careadlinkat.h.
8358 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8360 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8361 first non-nil return value).
8363 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8365 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8366 if not defined (Bug#8403).
8368 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8370 * xdisp.c (display_count_lines): Remove parameter `start',
8371 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8372 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8373 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8374 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8375 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8376 and thereabouts. All callers changed.
8377 (get_per_char_metric): Remove parameter `f', unused since
8378 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8380 2011-04-02 Jim Meyering <meyering@redhat.com>
8382 do not dereference NULL upon failed strdup
8383 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8384 (ns_get_family): Likewise.
8386 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8388 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8390 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8392 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8395 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8397 Add lexical binding.
8399 * window.c (Ftemp_output_buffer_show): New fun.
8400 (Fsave_window_excursion):
8401 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8403 * lread.c (lisp_file_lexically_bound_p): New function.
8404 (Fload): Bind Qlexical_binding.
8405 (readevalloop): Remove `evalfun' arg.
8406 Bind Qinternal_interpreter_environment.
8407 (Feval_buffer): Bind Qlexical_binding.
8408 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8410 (syms_of_lread): Declare `lexical-binding'.
8412 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8414 * keyboard.c (eval_dyn): New fun.
8415 (menu_item_eval_property): Use it.
8417 * image.c (parse_image_spec): Use Ffunctionp.
8419 * fns.c (concat, mapcar1): Accept byte-code-functions.
8421 * eval.c (Fsetq): Handle lexical vars.
8422 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8423 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8424 (FletX, Flet): Obey lexical binding.
8425 (Fcommandp): Handle closures.
8426 (Feval): New `lexical' arg.
8427 (eval_sub): New function extracted from Feval. Use it almost
8428 everywhere where Feval was used. Look up vars in lexical env.
8430 (Ffunctionp): Move from subr.el.
8431 (Ffuncall): Handle closures.
8432 (apply_lambda): Remove `eval_flags'.
8433 (funcall_lambda): Handle closures and new byte-code-functions.
8434 (Fspecial_variable_p): New function.
8435 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8436 but without exporting it to Lisp.
8438 * doc.c (Fdocumentation, store_function_docstring):
8439 * data.c (Finteractive_form): Handle closures.
8441 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8444 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8446 (exec_byte_code): New function extracted from Fbyte_code to handle new
8447 calling convention for byte-code-functions. Add new byte-codes.
8449 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8451 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8453 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8455 * xdisp.c (redisplay_internal): Fix prototype.
8457 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8459 * xdisp.c (SCROLL_LIMIT): New macro.
8460 (try_scrolling): Use it when setting scroll_limit.
8461 Limit scrolling to 100 screen lines.
8462 (redisplay_window): Even when falling back on "recentering",
8463 position point in the window according to scroll-conservatively,
8464 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8466 (try_scrolling): When point is above the window, allow searching
8467 as far as scroll_max, or one screenful, to compute vertical
8468 distance from PT to the scroll margin position. This prevents
8469 try_scrolling from unnecessarily failing when
8470 scroll-conservatively is set to a value slightly larger than the
8471 window height. Clean up the case of PT below the margin at bottom
8472 of window: scroll_max can no longer be INT_MAX. When aggressive
8473 scrolling is in use, don't let point enter the opposite scroll
8474 margin as result of the scroll.
8475 (syms_of_xdisp) <scroll-conservatively>: Document the
8476 threshold of 100 lines for never-recentering scrolling.
8478 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8480 * dispextern.h (move_it_by_lines):
8481 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8482 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8483 (message_log_check_duplicate): Remove parameters `prev_bol' and
8484 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8485 (redisplay_internal): Remove parameter `preserve_echo_area',
8486 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8488 * indent.c (Fvertical_motion):
8489 * window.c (window_scroll_pixel_based, Frecenter):
8490 Don't pass `need_y_p' to `move_it_by_lines'.
8492 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8494 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8495 steal a few bits to be more compact.
8496 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8497 Remove unneeded casts.
8499 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8501 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8503 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8504 binding" message (bug#7967).
8506 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8508 Fix more problems found by GCC 4.6.0's static checks.
8510 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8511 Remove unused local var.
8513 * editfns.c (Fmessage_box): Remove unused local var.
8515 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8516 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8517 Omit unused local vars.
8518 * window.c (shrink_windows): Omit unused local var.
8519 * menu.c (digest_single_submenu): Omit unused local var.
8520 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8521 Omit unused local var.
8523 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8524 Don't assume string length fits in int.
8525 (keyremap_step, read_key_sequence): Use size_t for sizes.
8526 (read_key_sequence): Don't check last_real_key_start redundantly.
8528 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8529 instead of alloca (Bug#8344).
8531 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8532 (Fbacktrace_frame): Don't assume nframes fits in int.
8534 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8536 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8539 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8541 * cm.c (calccost): Turn while-do into do-while, for clarity.
8543 * keyboard.c (syms_of_keyboard): Use the same style as later
8544 in this function when indexing through an array. This also
8545 works around GCC bug 48267.
8547 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8549 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8551 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8552 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8554 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8555 This avoids undefined behavior on integer overflow, and is a bit
8556 more convenient anyway since it is compared to a size_t variable.
8558 Variadic C functions now count arguments with size_t, not int.
8559 This avoids an unnecessary limitation on 64-bit machines, which
8560 caused (substring ...) to crash on large vectors (Bug#8344).
8561 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8562 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8563 All variadic functions and their callers changed accordingly.
8564 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8565 * data.c (arith_driver, float_arith_driver): Likewise.
8566 * editfns.c (general_insert_function): Likewise.
8567 * eval.c (struct backtrace.nargs, interactive_p)
8568 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8569 (funcall_lambda, mark_backtrace): Likewise.
8570 * fns.c (concat): Likewise.
8571 * frame.c (x_set_frame_parameters): Likewise.
8572 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8573 0 if not found, not -1. All callers changed.
8575 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8576 (stack_copy_size): Now size_t, not int.
8577 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8579 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8581 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8582 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8583 All callers changed.
8585 * lisp.h (multibyte_char_to_unibyte):
8586 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8587 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8588 * character.h (CHAR_TO_BYTE8):
8589 * cmds.c (internal_self_insert):
8590 * editfns.c (general_insert_function):
8591 * keymap.c (push_key_description):
8592 * search.c (Freplace_match):
8593 * xdisp.c (message_dolog, set_message_1): All callers changed.
8595 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8597 * keyboard.c (safe_run_hook_funcall): New function.
8598 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8599 don't set the hook to nil, but remove the offending function instead.
8600 (Qcommand_hook_internal): Remove, unused.
8601 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8602 Vcommand_hook_internal.
8604 * eval.c (enum run_hooks_condition): Remove.
8605 (funcall_nil, funcall_not): New functions.
8606 (run_hook_with_args): Call each function through a `funcall' argument.
8607 Remove `cond' argument, now redundant.
8608 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8609 (Frun_hook_with_args_until_failure): Adjust accordingly.
8610 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8612 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8614 * dispextern.h (string_buffer_position): Remove declaration.
8616 * print.c (strout): Remove parameter `multibyte', unused since
8617 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8619 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8620 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8621 All callers changed.
8623 * w32.c (_wsa_errlist): Use braces for struct initializers.
8625 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8626 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8627 All callers changed.
8628 (string_buffer_position): Likewise. Also, make static (it's never
8629 used outside xdisp.c).
8630 (cursor_row_p): Remove parameter `w', unused since
8631 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8632 (decode_mode_spec): Remove parameter `precision', introduced during
8633 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8634 All callers changed.
8636 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8638 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8640 2011-03-27 Anders Lindgren <andlind@gmail.com>
8642 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8643 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8644 (ns_update_auto_hide_menu_bar): New functions.
8645 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8646 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8647 ns_constrain_all_frames.
8648 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8649 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8651 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8653 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8655 2011-03-27 Glenn Morris <rgm@gnu.org>
8657 * syssignal.h: Replace RETSIGTYPE with void.
8658 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8659 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8660 Replace SIGTYPE with void everywhere.
8661 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8662 * s/template.h (SIGTYPE): Remove commented out definition.
8664 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8666 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8667 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8669 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8671 * w32.c (read_unc_volume): Use parameter `henum', instead of
8672 global variable `wget_enum_handle'.
8674 * keymap.c (describe_vector): Remove parameters `indices' and
8675 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8676 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8678 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8680 * keyboard.c (timer_check): Remove parameter `do_it_now',
8681 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8682 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8683 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8685 * keyboard.c (read_char):
8686 * w32menu.c (w32_menu_display_help):
8687 * xmenu.c (show_help_event, menu_help_callback):
8688 Adjust calls to `show_help_echo'.
8690 * gtkutil.c (xg_maybe_add_timer):
8691 * keyboard.c (readable_events):
8692 * process.c (wait_reading_process_output):
8693 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8695 * insdel.c (adjust_markers_gap_motion):
8696 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8697 (gap_left, gap_right): Don't call it.
8699 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8701 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8702 incurred during fontification.
8704 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8706 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8707 (DEFVAR_PER_BUFFER): Don't pass it.
8709 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8710 (scrolling_window): Don't pass it.
8712 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8714 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8716 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8718 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8719 of variables specific to SELinux and computation of `encoded_absname'.
8721 * image.c (XPutPixel): Remove unused variable `height'.
8723 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8725 * unexw32.c (get_section_info): Remove unused variable `section'.
8727 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8728 (system_process_attributes): Remove unused variable `sess'.
8729 (sys_read): Remove unused variable `err'.
8731 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8732 (w32_wnd_proc): Remove unused variable `isdead'.
8733 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8734 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8735 (x_create_tip_frame): Remove unused variable `tem'.
8737 * w32inevt.c (w32_console_read_socket):
8738 Remove unused variable `no_events'.
8740 * w32term.c (x_draw_composite_glyph_string_foreground):
8741 Remove unused variable `width'.
8743 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8745 * w32term.c (x_set_glyph_string_clipping):
8746 Don't pass uninitialized region to CombineRgn.
8748 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8750 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8751 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8752 (Fx_close_connection): Remove unused variable `i'.
8754 * w32font.c (w32font_draw): Return number of glyphs.
8755 (w32font_open_internal): Remove unused variable `i'.
8756 (w32font_driver): Add missing initializer.
8758 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8759 (fill_in_menu): Remove unused variable `items_added'.
8761 * w32term.c (last_mouse_press_frame): Remove static global variable.
8762 (w32_clip_to_row): Remove unused variable `f'.
8763 (x_delete_terminal): Remove unused variable `i'.
8765 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8766 (NOTHING): Remove unused static global variable.
8767 (uniscribe_check_otf): Remove unused variable `table'.
8768 (uniscribe_font_driver): Add missing initializers.
8770 2011-03-23 Julien Danjou <julien@danjou.info>
8772 * term.c (Fsuspend_tty, Fresume_tty):
8773 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8774 * window.c (temp_output_buffer_show):
8775 * insdel.c (signal_before_change):
8776 * frame.c (Fhandle_switch_frame):
8777 * fileio.c (Fdo_auto_save):
8778 * emacs.c (Fkill_emacs):
8779 * editfns.c (save_excursion_restore):
8780 * cmds.c (internal_self_insert):
8781 * callint.c (Fcall_interactively):
8782 * buffer.c (Fkill_all_local_variables):
8783 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8785 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8786 unconditionally since it does the check itself.
8788 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8790 Fix more problems found by GCC 4.5.2's static checks.
8792 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8793 the first time through the loop, since we know p0 < p1 then.
8794 This also avoids a gcc -Wstrict-overflow warning.
8796 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8797 leading to a memory leak, possible in functions like
8798 load_charset_map_from_file that can allocate an unbounded number
8799 of objects (Bug#8318).
8801 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8802 that could (at least in theory) be that large.
8804 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8805 This is less likely to overflow, and avoids undefined behavior if
8806 overflow does occur. All callers changed. Use strtoul to scan
8807 for the unsigned long integer.
8808 (pint2hrstr): Simplify and tune code slightly.
8809 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8811 * scroll.c (do_scrolling): Work around GCC bug 48228.
8812 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8814 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8815 This also avoids a warning with gcc -Wstrict-overflow.
8816 (validate_x_resource_name): Simplify count usage.
8817 This also avoids a warning with gcc -Wstrict-overflow.
8819 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8822 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8824 * process.c (Fmake_network_process): Use socklen_t, not int,
8825 where POSIX says socklen_t is required in portable programs.
8826 This fixes a porting bug on hosts like 64-bit HP-UX, where
8827 socklen_t is wider than int (Bug#8277).
8828 (Fmake_network_process, server_accept_connection):
8829 (wait_reading_process_output, read_process_output):
8832 * process.c: Rename or move locals to avoid shadowing.
8833 (list_processes_1, Fmake_network_process):
8834 (read_process_output_error_handler, exec_sentinel_error_handler):
8835 Rename or move locals.
8836 (Fmake_network_process): Define label "retry_connect" only if needed.
8837 (Fnetwork_interface_info): Fix pointer signedness.
8838 (process_send_signal): Add cast to avoid pointer signedness problem.
8839 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8840 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8842 Make tparam.h and terminfo.c consistent.
8843 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8844 Include tparam.h instead, since it declares them.
8845 * cm.h (PC): Remove extern decl; tparam.h now does this.
8846 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8847 * terminfo.c: Include tparam.h, to check interfaces.
8848 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8849 (tparam): Adjust signature to match interface in tparam.h;
8850 this removes some undefined behavior. Check that outstring and len
8851 are zero, which they always are with Emacs.
8852 * tparam.h (PC, BC, UP): New extern decls.
8854 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8855 (xftfont_open): Rename locals to avoid shadowing.
8857 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8858 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8859 (OTF_TAG_SYM): Omit macro if not needed.
8860 (ftfont_list): Remove unused local.
8861 (get_adstyle_property, ftfont_pattern_entity):
8862 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8863 Rename locals to avoid shadowing.
8865 * xfont.c (xfont_list_family): Mark var as initialized.
8867 * xml.c (make_dom): Now static.
8869 * composite.c (composition_compute_stop_pos): Rename local to
8871 (composition_reseat_it): Remove unused locals.
8872 (find_automatic_composition, composition_adjust_point): Likewise.
8873 (composition_update_it): Mark var as initialized.
8874 (find_automatic_composition): Mark vars as initialized,
8875 with a FIXME (Bug#8290).
8877 character.h: Rename locals to avoid shadowing.
8878 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8879 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8880 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8881 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8884 * textprop.c (property_change_between_p): Remove; unused.
8886 * intervals.c (interval_start_pos): Now static.
8888 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8890 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8891 Rename locals to avoid shadowing.
8893 * sound.c (wav_play, au_play, Fplay_sound_internal):
8894 Fix pointer signedness.
8895 (alsa_choose_format): Remove unused local var.
8896 (wav_play): Initialize a variable to 0, to prevent undefined
8897 behavior (Bug#8278).
8899 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8901 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8903 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8904 clobbering (Bug#8298).
8905 * sysdep.c (sys_subshell): Likewise.
8906 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8908 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8909 This should get cleaned up, so that child_setup has the
8910 same signature on all platforms.
8912 * callproc.c (call_process_cleanup): Now static.
8913 (relocate_fd): Rename locals to avoid shadowing.
8915 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8917 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8918 not to be necessary, and produces flickering.
8920 2011-03-20 Glenn Morris <rgm@gnu.org>
8922 * config.in: Remove file.
8924 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8926 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8927 are now in src/globals.h.
8928 (syms_of_minibuf): Remove spurious & from previous change.
8930 2011-03-20 Leo Liu <sdl.web@gmail.com>
8932 * minibuf.c (completing-read-function): New variable.
8933 (completing-read-default): Rename from completing-read.
8934 (completing-read): Call completing-read-function.
8936 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8938 * xfaces.c (Fx_load_color_file):
8939 Read color file from absolute filename (bug#8250).
8941 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8943 * makefile.w32-in: Update dependencies.
8945 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8947 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8949 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8951 Fix more problems found by GCC 4.5.2's static checks.
8953 * process.c (make_serial_process_unwind, send_process_trap):
8954 (sigchld_handler): Now static.
8956 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8957 That way, the code declares only the vars that it needs.
8958 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8959 * s/cygwin.h (PTY_ITERATION): Likewise.
8960 * s/darwin.h (PTY_ITERATION): Likewise.
8961 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8963 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8964 * process.c (allocate_pty): Don't declare stb unless it's needed.
8966 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8967 (CONSTANTLIM): Remove; unused.
8968 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8969 Define only if needed.
8971 * unexelf.c (unexec): Name an expression,
8972 to avoid gcc -Wbad-function-cast warning.
8973 Use a different way to cause a compilation error if anyone uses
8974 n rather than nn, a way that does not involve shadowing.
8975 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8977 * deps.mk (unexalpha.o): Remove; unused.
8979 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8980 * unexec.h: New file.
8981 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8982 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8984 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8985 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8986 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8987 Change as necessary to match prototype in unexec.h.
8989 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8991 (back_comment, skip_chars): Mark vars as initialized.
8993 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8994 Rename locals to avoid shadowing.
8996 * lread.c (read1): Rewrite so as not to use empty "else".
8997 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8999 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9001 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9002 warning when compiling print.c.
9004 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9005 instead of using an uninitialized var.
9006 (font_sort_entities): Mark var as initialized.
9008 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9010 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9011 pointers to constants.
9012 (font_parse_fcname): Remove unused vars.
9013 (font_delete_unmatched): Now static.
9014 (font_get_spec): Remove; unused.
9015 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9016 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9017 Rename or move locals to avoid shadowing.
9019 * fns.c (require_nesting_list, require_unwind): Now static.
9020 (Ffillarray): Rename locals to avoid shadowing.
9022 * floatfns.c (domain_error2): Define only if needed.
9023 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9025 * alloc.c (mark_backtrace): Move decl from here ...
9026 * lisp.h: ... to here, so that it can be checked.
9028 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9029 (Fdefvar): Rewrite so as not to use empty "else".
9030 (lisp_indirect_variable): Name an expression,
9031 to avoid gcc -Wbad-function-cast warning.
9032 (Fdefvar): Rename locals to avoid shadowing.
9034 * callint.c (quotify_arg, quotify_args): Now static.
9035 (Fcall_interactively): Rename locals to avoid shadowing.
9036 Use const pointer when appropriate.
9038 * lisp.h (get_system_name, get_operating_system_release):
9039 Move decls here, to check interfaces.
9040 * process.c (get_operating_system_release): Move decl to lisp.h.
9041 * xrdb.c (get_system_name): Likewise.
9042 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9043 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9044 some of which prompt warnings from gcc -Wbad-function-cast.
9045 (Fformat_time_string, Fencode_time, Finsert_char):
9046 (Ftranslate_region_internal, Fformat):
9047 Rename or remove local vars to avoid shadowing.
9048 (Ftranslate_region_internal): Mark var as initialized.
9050 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9053 * lisp.h (eassert): Check that the argument compiles, even if
9054 ENABLE_CHECKING is not defined.
9056 * data.c (Findirect_variable): Name an expression, to avoid
9057 gcc -Wbad-function-cast warning.
9058 (default_value, arithcompare, arith_driver, arith_error): Now static.
9059 (store_symval_forwarding): Rename local to avoid shadowing.
9060 (Fmake_variable_buffer_local, Fmake_local_variable):
9061 Mark variables as initialized.
9062 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9064 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9065 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9066 Rename locals to avoid shadowing.
9067 (mark_stack): Move local variables into the #ifdef region where
9069 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9070 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9072 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9073 (GC_STRING_CHARS): Remove; not used.
9074 (Fmemory_limit): Cast sbrk's returned value to char *.
9076 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9077 avoids undefined behavior in theory.
9079 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9081 Use functions, not macros, for up- and down-casing (Bug#8254).
9082 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9083 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9084 to use the following functions instead of these macros.
9085 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9086 EMACS_INT, since callers assume the returned value fits in int.
9087 (upcase1): Likewise, for UPCASE_TABLE.
9088 (uppercasep, lowercasep, upcase): New static inline functions.
9089 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9090 the race-condition problem in the old DOWNCASE.
9092 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9093 Rename locals to avoid shadowing.
9094 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9095 (regex_compile, re_search_2, re_match_2_internal):
9096 Remove unused local vars.
9097 (FREE_VAR): Rewrite so as not to use empty "else",
9098 which gcc can warn about.
9099 (regex_compile, re_match_2_internal): Mark locals as initialized.
9100 (RETALLOC_IF): Define only if needed.
9101 (WORDCHAR_P): Likewise. This one is never needed, but is used
9102 only in a comment talking about a compiler bug, so put inside
9103 the #if 0 of that comment.
9104 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9105 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9108 * search.c (boyer_moore): Rename locals to avoid shadowing.
9109 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9110 (PREV_CHAR_BOUNDARY): Likewise.
9112 * search.c (simple_search): Remove unused var.
9114 * dired.c (compile_pattern): Move decl from here ...
9115 * lisp.h: ... to here, so that it can be checked.
9116 (struct re_registers): New forward decl.
9118 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9120 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9122 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9123 Rename locals to avoid shadowing.
9124 (Fvertical_motion): Mark locals as initialized.
9126 * casefiddle.c (casify_object, casify_region): Now static.
9127 (casify_region): Mark local as initialized.
9129 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9131 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9132 New macros, so that the caller can use some names other than
9133 gcpro1, gcpro2, etc.
9134 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9136 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9137 argument, for consistency with GCPRO2_VAR, etc: it is now the
9138 prefix of the variable, not the variable itself. All uses
9140 * dired.c (directory_files_internal, file_name_completion):
9141 Rename locals to avoid shadowing.
9143 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9144 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9145 dired.c's scmp function, had undefined behavior.
9146 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9147 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9148 * buffer.h: ... to here, because these macros use current_buffer,
9149 and the new implementation with inline functions needs to have
9150 current_buffer in scope now, rather than later when the macros
9152 (downcase, upcase1): New static inline functions.
9153 (DOWNCASE, UPCASE1): Reimplement using these functions.
9154 This avoids undefined behavior in expressions like
9155 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9156 from race conditions in accessing the global variables
9157 case_temp1 and case_temp2.
9158 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9159 * lisp.h (case_temp1, case_temp2): Remove their decls.
9160 * character.h (ASCII_CHAR_P): Move from here ...
9161 * lisp.h: ... to here, so that the inline functions mentioned
9164 * dired.c (directory_files_internal_unwind): Now static.
9166 * fileio.c (file_name_as_directory, directory_file_name):
9167 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9169 (file_name_as_directory): Use const pointers when appropriate.
9170 (Fexpand_file_name): Likewise. In particular, newdir might
9171 point at constant storage, so make it a const pointer.
9172 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9173 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9175 (Fset_file_times, Finsert_file_contents, auto_save_error):
9176 Rename locals to avoid shadowing.
9178 * minibuf.c (choose_minibuf_frame_1): Now static.
9179 (Ftry_completion, Fall_completions): Rename or remove locals
9182 * marker.c (bytepos_to_charpos): Remove; unused.
9184 * lisp.h (verify_bytepos, count_markers): New decls,
9185 so that gcc does not warn that these functions aren't declared.
9187 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9188 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9189 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9190 (copy_text): Remove unused local var.
9192 * filelock.c (within_one_second): Now static.
9193 (lock_file_1): Rename local to avoid shadowing.
9195 * buffer.c (fix_overlays_before): Mark locals as initialized.
9196 (fix_start_end_in_overlays): Likewise. This function should be
9197 simplified by using pointers-to-pointers, but that's a different
9199 (switch_to_buffer_1): Now static.
9200 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9201 (report_overlay_modification): Rename locals to avoid shadowing.
9203 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9204 Fix pointer signedness issue.
9205 (sys_subshell): Mark local as volatile if checking for lint,
9206 to suppress a gcc -Wclobbered warning that does not seem to be right.
9207 (MAXPATHLEN): Define only if needed.
9209 * process.c (serial_open, serial_configure): Move decls from here ...
9210 * systty.h: ... to here, so that they can be checked.
9212 * fns.c (get_random, seed_random): Move extern decls from here ...
9213 * lisp.h: ... to here, so that they can be checked.
9215 * sysdep.c (reset_io): Now static.
9216 (wait_for_termination_signal): Remove; unused.
9218 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9219 (copy_keymap_item, append_key, push_text_char_description):
9221 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9222 (DENSE_TABLE_SIZE): Remove; unused.
9223 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9224 (describe_map_tree):
9225 Rename locals to avoid shadowing.
9227 * keyboard.c: Declare functions static if they are not used elsewhere.
9228 (echo_char, echo_dash, cmd_error, top_level_2):
9229 (poll_for_input, handle_async_input): Now static.
9230 (read_char, kbd_buffer_get_event, make_lispy_position):
9231 (make_lispy_event, make_lispy_movement, apply_modifiers):
9232 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9233 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9234 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9235 (read_key_sequence, read_char): Mark locals as initialized.
9236 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9238 * keyboard.h (make_ctrl_char): New decl.
9239 (mark_kboards): Move decl here ...
9240 * alloc.c (mark_kboards): ... from here.
9242 * lisp.h (force_auto_save_soon): New decl.
9244 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9245 (DEFINE_DUMMY_FUNCTION): New macro.
9246 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9248 (main): Add casts to avoid warnings
9249 if GCC considers string literals to be constants.
9251 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9253 * dbusbind.c: Pointer signedness fixes.
9254 (xd_signature, xd_append_arg, xd_initialize):
9255 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9256 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9257 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9258 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9260 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9261 if GCC considers string literals to be constants.
9262 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9264 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9266 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9267 (print_preprocess, print_object): New macro to fix last change.
9269 * print.c (print_preprocess): Don't forget font objects.
9271 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9273 * emacs.c (USAGE3): Doc fixes.
9275 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9277 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9280 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9282 * lisp.h (VWindow_system, Qfile_name_history):
9283 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9284 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9285 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9287 * w32select.c: Don't #include "keyboard.h".
9288 (run_protected): Add extern declaration for waiting_for_input.
9290 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9291 * w32console.c (detect_input_pending, read_input_pending)
9292 (encode_terminal_code):
9293 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9294 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9295 (w32_system_caret_y, Qfile_name_history):
9296 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9297 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9298 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9299 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9300 * w32proc.c (Qlocal, report_file_error):
9301 * w32term.c (Vwindow_system, updating_frame):
9302 * w32uniscribe.c (initialized, uniscribe_font_driver):
9303 Remove unneeded extern declarations.
9305 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9307 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9309 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9311 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9312 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9313 These macros can no longer be used for assignment.
9315 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9316 Assign struct members directly, instead of using BUF_BEGV etc.
9317 (record_buffer_markers, fetch_buffer_markers): New functions for
9318 recording and fetching special buffer markers.
9319 (set_buffer_internal_1, set_buffer_temp): Use them.
9321 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9323 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9325 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9326 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9328 * xdisp.c (hscroll_window_tree):
9329 (reconsider_clip_changes): Use PT instead of BUF_PT.
9331 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9333 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9334 $(EMACS_ROOT)/lib/intprops.h.
9336 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9338 Fix more problems found by GCC 4.5.2's static checks.
9340 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9341 to unsigned char * to avoid compiler diagnostic.
9342 (xg_free_frame_widgets): Make it clear that a local variable is
9343 needed only if USE_GTK_TOOLTIP.
9344 (gdk_window_get_screen): Make it clear that this macro is needed
9345 only if USE_GTK_TOOLTIP.
9346 (int_gtk_range_get_value): New function, which avoids a diagnostic
9347 from gcc -Wbad-function-cast.
9348 (xg_set_toolkit_scroll_bar_thumb): Use it.
9349 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9350 diagnostic from gcc -Wbad-function-cast.
9351 (get_utf8_string, xg_get_file_with_chooser):
9352 Rename locals to avoid shadowing.
9353 (create_dialog): Move locals to avoid shadowing.
9355 * xgselect.c (xg_select): Remove unused var.
9357 * image.c (four_corners_best): Mark locals as initialized.
9358 (gif_load): Initialize transparent_p to zero (Bug#8238).
9359 Mark another local as initialized.
9360 (my_png_error, my_error_exit): Mark with NO_RETURN.
9362 * image.c (clear_image_cache): Now static.
9363 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9364 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9365 (x_edge_detection): Remove unnecessary cast that
9366 gcc -Wbad-function-cast diagnoses.
9367 (gif_load): Fix pointer signedness.
9368 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9369 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9371 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9373 Improve quality of tests for time stamp overflow.
9374 For example, without this patch (encode-time 0 0 0 1 1
9375 1152921504606846976) returns the obviously-bogus value (-948597
9376 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9377 reports time overflow. See
9378 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9379 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9380 * editfns.c: Include limits.h and intprops.h.
9381 (TIME_T_MIN, TIME_T_MAX): New macros.
9382 (time_overflow): Move earlier, to before first use.
9383 (hi_time, lo_time): New functions, for an accurate test for
9385 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9386 (Fget_internal_run_time): Don't assume time_t fits in int.
9387 (make_time): Use list2 instead of Fcons twice.
9388 (Fdecode_time): More accurate test for out-of-range times.
9389 (check_tm_member): New function.
9390 (Fencode_time): Use it, to test for out-of-range times.
9391 (lisp_time_argument): Don't rely on undefined left-shift and
9392 right-shift behavior when checking for time stamp overflow.
9394 * editfns.c (time_overflow): New function, refactoring common code.
9395 (Fformat_time_string, Fdecode_time, Fencode_time):
9396 (Fcurrent_time_string): Use it.
9398 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9399 * dired.c (make_time): Move to ...
9400 * editfns.c (make_time): ... here.
9401 * systime.h: Note the move.
9403 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9405 * fringe.c (update_window_fringes): Remove unused variables.
9407 * unexmacosx.c (copy_data_segment): Also copy __got section.
9410 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9412 * termcap.c [MSDOS]: Include "msdos.h".
9413 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9414 Constify `char *' arguments and their references according to
9415 prototypes in tparam.h.
9417 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9419 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9420 Adapt all references accordingly.
9422 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9424 2011-03-11 Tom Tromey <tromey@redhat.com>
9426 * buffer.c (syms_of_buffer): Remove obsolete comment.
9428 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9430 * termhooks.h (encode_terminal_code): Declare prototype.
9432 * msdos.c (encode_terminal_code): Don't declare prototype.
9434 * term.c (encode_terminal_code): Now external again, used by
9435 w32console.c and msdos.c.
9437 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9438 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9440 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9442 Fix some minor problems found by GCC 4.5.2's static checks.
9444 * fringe.c (update_window_fringes): Mark locals as initialized
9446 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9448 * alloc.c (mark_fringe_data): Move decl from here ...
9449 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9450 to check its interface.
9451 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9453 * fontset.c (free_realized_fontset): Now static.
9454 (Fset_fontset_font): Rename local to avoid shadowing.
9455 (fontset_font): Mark local as initialized.
9456 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9458 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9460 * xselect.c (x_disown_buffer_selections): Remove; not used.
9461 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9462 (x_own_selection, Fx_disown_selection_internal): Rename locals
9464 (x_handle_dnd_message): Remove local to avoid shadowing.
9466 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9467 so that the caller can use some name other than gcpro1.
9468 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9469 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9470 (Fx_backspace_delete_keys_p):
9471 Use them to avoid shadowing, and rename vars to avoid shadowing.
9472 (x_decode_color, x_set_name, x_window): Now static.
9473 (Fx_create_frame): Add braces to silence GCC warning.
9474 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9475 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9476 Remove unused locals.
9477 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9478 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9479 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9482 * xterm.h (x_mouse_leave): New decl.
9484 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9485 Remove unused functions.
9486 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9487 (x_calc_absolute_position): Now static.
9488 (XTread_socket): Don't define label "out" unless it's used.
9489 Don't declare local "event" unless it's used.
9490 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9491 unless they are used.
9492 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9493 (x_fatal_error_signal): Remove; not used.
9494 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9495 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9496 (x_error_catcher, x_connection_closed, x_error_handler):
9497 (x_error_quitter, xembed_send_message, x_iconify_frame):
9498 (my_log_handler): Rename locals to avoid shadowing.
9499 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9500 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9502 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9503 Rename or move locals to avoid shadowing.
9504 (tty_defined_color, merge_face_heights): Now static.
9505 (free_realized_faces_for_fontset): Remove; not used.
9506 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9507 does not deduce is never used uninitialized.
9508 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9509 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9511 * terminal.c (store_terminal_param): Now static.
9513 * xmenu.c (menu_highlight_callback): Now static.
9514 (set_frame_menubar): Remove unused local.
9515 (xmenu_show): Rename parameter to avoid shadowing.
9516 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9517 since they might point to immutable storage.
9518 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9519 since it's unused otherwise.
9521 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9522 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9523 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9524 avoids a gcc -Wuninitialized diagnostic.
9525 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9526 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9527 does not deduce are never used uninitialized.
9529 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9531 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9532 * window.c (window_loop, size_window):
9533 (run_window_configuration_change_hook, enlarge_window): Likewise.
9535 * window.c (display_buffer): Now static.
9536 (size_window): Mark variables that gcc -Wuninitialized
9537 does not deduce are never used uninitialized.
9538 * window.h (check_all_windows): New decl, to forestall
9539 gcc -Wmissing-prototypes diagnostic.
9540 * dispextern.h (bidi_dump_cached_states): Likewise.
9542 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9544 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9546 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9547 and to avoid gcc -Wuninitialized warning.
9548 (load_charset_map): Mark variables that gcc -Wuninitialized
9549 does not deduce are never used uninitialized.
9550 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9552 * coding.c (coding_set_source, coding_set_destination):
9553 Use "else { /* comment */ }" rather than "else /* comment */;"
9554 for clarity, and to avoid gcc -Wempty-body warning.
9555 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9556 a block, when the outer 'i' will do.
9557 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9558 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9559 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9560 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9561 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9562 Rename locals to avoid shadowing.
9563 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9564 * coding.c (emacs_mule_char, encode_invocation_designation):
9565 Now static, since they're not used elsewhere.
9566 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9567 (decode_coding_object, encode_coding_object, detect_coding_system):
9568 (decode_coding_emacs_mule): Mark variables that gcc
9569 -Wuninitialized does not deduce are never used uninitialized.
9570 (detect_coding_iso_2022): Initialize a local variable that might
9571 be used uninitialized. Leave a FIXME because it's not clear that
9572 this initialization is needed. (Bug#8211)
9573 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9574 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9575 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9576 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9577 Remove unused macros.
9579 * category.c (hash_get_category_set): Remove unused local var.
9580 (copy_category_table): Now static, since it's not used elsewhere.
9581 * character.c (string_count_byte8): Likewise.
9583 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9584 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9586 * chartab.c (copy_sub_char_table): Now static, since it's not used
9588 (sub_char_table_ref_and_range, char_table_ref_and_range):
9589 Rename locals to avoid shadowing.
9590 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9592 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9593 (BIDI_BOB): Remove unused macro.
9595 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9596 deduce are never used uninitialized.
9597 * term.c (encode_terminal_code): Likewise.
9599 * term.c (encode_terminal_code): Now static. Remove unused local.
9601 * tparam.h: New file.
9602 * term.c, tparam.h: Include it.
9603 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9604 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9605 Move these decls to tparam.h, and make them agree with what
9606 is actually in tparam.c. The previous trick of using incompatible
9607 decls in different modules does not conform to the C standard.
9608 All callers of tparam changed to use tparam's actual API.
9609 * tparam.c (tparam1, tparam, tgoto):
9610 Use const pointers where appropriate.
9612 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9613 * cm.h (struct cm): Likewise.
9614 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9615 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9616 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9617 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9618 (turn_on_face, init_tty): Likewise.
9619 * termchar.h (struct tty_display_info): Likewise.
9621 * term.c (term_mouse_position): Rename local to avoid shadowing.
9623 * alloc.c (mark_ttys): Move decl from here ...
9624 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9626 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9628 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9630 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9632 * search.c (compile_pattern_1): Remove argument regp, unused since
9633 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9634 (compile_pattern): Don't pass it.
9636 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9638 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9639 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9641 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9643 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9645 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9646 gdk_window_get_screen, gdk_window_get_geometry,
9647 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9648 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9649 (xg_get_pixbuf_from_pixmap): New function.
9650 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9651 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9652 Call xg_get_pixbuf_from_pixmap instead of
9653 gdk_pixbuf_get_from_drawable.
9654 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9655 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9656 (xg_check_special_colors): Use GtkStyleContext and its functions
9658 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9659 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9660 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9661 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9662 Call gtk_widget_get_preferred_size.
9663 (xg_frame_resized): gdk_window_get_geometry only takes 5
9665 (xg_win_to_widget, xg_event_is_for_menubar):
9666 Call gdk_x11_window_lookup_for_display.
9667 (xg_set_widget_bg): New function.
9668 (delete_cb): New function.
9669 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9670 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9671 (xg_set_background_color): Call xg_set_widget_bg.
9672 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9673 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9674 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9675 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9677 (update_frame_tool_bar): Call gtk_widget_hide.
9678 (xg_initialize): Use GDK_KEY_g.
9680 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9682 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9684 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9685 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9686 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9688 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9690 * w32xfns.c (select_palette): Check success of RealizePalette against
9691 GDI_ERROR, not zero.
9693 See ChangeLog.11 for earlier changes.
9699 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9701 This file is part of GNU Emacs.
9703 GNU Emacs is free software: you can redistribute it and/or modify
9704 it under the terms of the GNU General Public License as published by
9705 the Free Software Foundation, either version 3 of the License, or
9706 (at your option) any later version.
9708 GNU Emacs is distributed in the hope that it will be useful,
9709 but WITHOUT ANY WARRANTY; without even the implied warranty of
9710 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9711 GNU General Public License for more details.
9713 You should have received a copy of the GNU General Public License
9714 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.