1 2011-11-23 Glenn Morris <rgm@gnu.org>
3 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5 2011-11-23 Chong Yidong <cyd@gnu.org>
7 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
10 2011-11-22 Eli Zaretskii <eliz@gnu.org>
12 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
13 and header-lines, as they don't have one computed for them.
16 * .gdbinit (prow): Make displayed values more self-explaining.
19 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
21 * process.c (wait_reading_process_output): Fix asynchrounous
22 GnuTLS socket handling on some versions of the GnuTLS library.
23 (wait_reading_process_output): Add comment and URL.
25 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
27 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
29 2011-11-21 Chong Yidong <cyd@gnu.org>
31 * window.c (Fnext_window, Fprevious_window): Doc fix.
33 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
35 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
37 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
39 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
41 2011-11-20 Martin Rudalics <rudalics@gmx.at>
43 * window.c (Fset_window_combination_limit): Rename argument
45 (Vwindow_combination_limit): Remove "status" from doc-string.
47 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
49 * m/ibms390.h: Remove.
50 * m/ibms390x.h: Don't include "ibms390.h".
52 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
54 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
55 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
57 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
59 * casetab.c (Fset_case_table):
60 * charset.c (Fcharset_after): Fix typos.
62 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
64 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
65 Otherwise, valgrind does not work on some platforms.
66 Problem reported by Andreas Schwab in
67 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
68 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
69 is set, removing the need for VIRT_ADDRESS_VARIES.
70 (PURE_P): Use a more-efficient implementation that needs just one
71 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
72 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
73 to 4 (xorl, subq, cmpq, setbe).
74 * alloc.c (pure): Always extern now, since that's the
75 VIRT_ADDR_VARIES behavior.
76 (PURE_POINTER_P): Use a single comparison, not two, for
77 consistency with the new puresize.h.
78 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
79 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
80 Remove VIRT_ADDR_VARIES no longer needed.
82 2011-11-19 Eli Zaretskii <eliz@gnu.org>
84 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
85 (erase_phys_cursor, update_window_cursor, show_mouse_face)
86 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
87 behave as if the cursor position were at the window margin.
89 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
90 and the cursor position is out of bounds, behave as if the cursor
91 position were at the window margin. (Bug#10075)
93 2011-11-18 Chong Yidong <cyd@gnu.org>
95 * window.c (Fwindow_combination_limit): Make first argument
96 non-optional, since it is meaningless for live windows like the
99 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
101 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
103 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
105 * intervals.c: Fix grafting over the whole buffer (bug#10071).
106 (graft_intervals_into_buffer): Simplify.
108 2011-11-18 Eli Zaretskii <eliz@gnu.org>
110 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
111 hash values of the two rows.
112 (copy_row_except_pointers): Preserve the used[] arrays and the
113 hash values of the two rows. (Bug#10035)
114 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
116 * xdisp.c (row_hash): New function, body extracted from
117 compute_line_metrics.
118 (compute_line_metrics): Call row_hash, instead of computing the
121 * dispnew.c (verify_row_hash): Call row_hash for computing the
122 hash code of a row, instead of duplicating code from xdisp.c.
124 * dispextern.h (row_hash): Add prototype.
126 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
128 * frame.c (delete_frame): Don't delete the terminal when the last
129 X frame is closed if emacs is built with GTK toolkit.
131 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
133 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
135 2011-11-17 Martin Rudalics <rudalics@gmx.at>
137 * window.c (Vwindow_splits): Rename to
138 Vwindow_combination_resize. Suggested by Juri Linkov.
139 (Fsplit_window_internal): Use Vwindow_combination_resize instead
142 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
144 * nsfns.m (Fns_font_name):
145 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
147 2011-11-16 Martin Rudalics <rudalics@gmx.at>
149 * window.h (window): Rename slot "nest" to "combination_limit".
150 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
151 (Fset_window_nest): Rename to Fset_window_combination_limit.
152 (Vwindow_nest): Rename to Vwindow_combination_limit.
153 (recombine_windows, make_parent_window, make_window)
154 (Fsplit_window_internal, saved_window)
155 (Fset_window_configuration, save_window_save): Rename all
156 occurrences of window_nest to window_combination_limit.
158 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
160 * image.c (imagemagick_load_image): Fix typo.
162 2011-11-14 Eli Zaretskii <eliz@gnu.org>
164 * xdisp.c (display_line): Move the call to
165 highlight_trailing_whitespace before the call to
166 compute_line_metrics, since the latter needs to see the final
167 faces of all the glyphs to compute ROW's hash value. Fixes
168 assertion violations in row_equal_p. (Bug#10035)
170 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
172 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
173 just return (bug#10044).
175 2011-11-12 Eli Zaretskii <eliz@gnu.org>
177 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
178 with user-defined heap size. Bump the default size of the temacs
179 heap to 27MB, to avoid memory warning when running temacs.
180 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
182 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
183 current_matrix and desired_matrix. (Bug#9990)
184 (verify_row_hash) [XASSERTS]: New function.
185 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
186 that the hash value of glyph rows is correct.
188 2011-11-12 Martin Rudalics <rudalics@gmx.at>
190 * window.h (window): Remove splits slot.
191 * window.c (Fwindow_splits, Fset_window_splits): Remove.
192 (Fdelete_other_windows_internal, make_parent_window)
193 (make_window, Fsplit_window_internal, Fdelete_window_internal)
194 (Fset_window_configuration, save_window_save): Don't deal with
195 split status of windows.
196 (saved_window): Remove splits slot.
197 (Vwindow_splits): Rewrite doc-string.
199 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
201 * xfns.c (unwind_create_frame):
202 * nsfns.m (unwind_create_frame):
203 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
204 Vframe_list (Bug#9999).
206 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
208 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
210 2011-11-11 Kenichi Handa <handa@m17n.org>
212 * callproc.c (Fcall_process): Set the member dst_multibyte of
215 2011-11-11 Johan Bockgård <bojohan@gnu.org>
217 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
218 avoid a crash (bug#9496).
220 2011-11-09 Chong Yidong <cyd@gnu.org>
222 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
223 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
225 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
227 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
229 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
231 Avoid some portability problems by eschewing 'extern inline' functions.
232 The trivial performance wins aren't worth the portability hassles; see
233 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
235 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
236 (window_box_width, window_box_left, window_box_left_offset)
237 (window_box_right, window_box_right_offset): Undo previous change,
238 by removing the "extern"s.
239 * intervals.c (adjust_intervals_for_insertion)
240 (adjust_intervals_for_deletion): Undo previous change,
241 making these static again.
242 (offset_intervals, temp_set_point_both, temp_set_point)
243 (copy_intervals_to_string): No longer inline.
244 * xdisp.c (window_text_bottom_y, window_box_width)
245 (window_box_height, window_box_left_offset)
246 (window_box_right_offset, window_box_left, window_box_right)
247 (window_box): No longer inline.
249 2011-11-08 Chong Yidong <cyd@gnu.org>
251 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
252 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
253 an error if not a live window.
254 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
255 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
257 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
259 * lisp.h (syms_of_abbrev): Remove declaration.
260 Reported by CHENG Gao <chenggao@royau.me>.
262 2011-11-07 Eli Zaretskii <eliz@gnu.org>
264 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
265 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
266 of temacs in GUI mode.
268 2011-11-07 Martin Rudalics <rudalics@gmx.at>
270 * window.h: Declare delete_all_child_windows instead of
271 delete_all_subwindows.
272 * window.c (Fwindow_nest, Fset_window_nest)
273 (Fset_window_new_total, Fset_window_new_normal)
274 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
275 (delete_all_subwindows): Rename to delete_all_child_windows.
276 (Fdelete_other_windows_internal, Fset_window_configuration):
277 Call delete_all_child_windows instead of delete_all_subwindows.
278 * frame.c (delete_frame): Call delete_all_child_windows instead
279 of delete_all_subwindows.
281 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
283 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
284 This is also needed for porting to any host where GC_MARK_STACK is
285 not GC_MAKE_GCPROS_NOOPS.
286 (which_symbols): Use it.
288 2011-11-07 Kenichi Handa <handa@m17n.org>
290 * coding.c (coding_set_destination): Check coding->src_pos only
291 when coding->src_object is a buffer (bug#9910).
293 * process.c (send_process): Set the member src_multibyte of coding
294 to 0 (bug#9911) when sending a unibyte text.
296 * callproc.c (Fcall_process): Set the member src_multibyte of
297 process_coding to 0 (bug#9912).
299 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
301 * xmenu.c (cleanup_widget_value_tree): New function.
302 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
303 calling free_menubar_widget_value_tree directly (Bug#9830).
305 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
307 Fix some portability problems with 'inline'.
308 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
309 (window_box_width, window_box_left, window_box_left_offset)
310 (window_box_right, window_box_right_offset): Declare extern.
311 Otherwise, these inline functions do not conform to C99 and
312 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
313 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
314 * intervals.c (adjust_intervals_for_insertion)
315 (adjust_intervals_for_deletion): Now extern, because otherwise the
316 extern inline functions 'offset_intervals' couldn't refer to it.
317 (static_offset_intervals): Remove.
318 (offset_intervals): Rewrite using the old contents of
319 static_offset_intervals. The old version didn't conform to C99
320 because an extern inline function contained a reference to an
321 identifier with static linkage.
323 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
325 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
328 2011-11-06 Eli Zaretskii <eliz@gnu.org>
330 * xdisp.c (init_iterator, reseat_to_string): Don't set the
331 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
332 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
333 return Qleft_to_right.
335 2011-11-06 Chong Yidong <cyd@gnu.org>
337 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
338 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
339 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
340 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
341 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
342 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
343 (Fwindow_vscroll): Doc fix.
344 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
345 argument, since it makes no sense to pass a live window and for
346 consistency with window-child.
348 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
350 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
353 2011-11-05 Jason Rumney <jasonr@gnu.org>
355 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
356 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
358 (add_font_entity_to_list): Fix logic errors in mixed boolean and
359 bitwise arithmetic preventing use of unicode-sip and non-truetype
362 2011-11-05 Eli Zaretskii <eliz@gnu.org>
364 * s/ms-w32.h (fstat, stat, utime): Move redirections to
367 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
368 initialization code to keep similarity to xfns.c after changes
371 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
373 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
374 (unwind_create_frame): New function (Bug#9943).
375 (Fx_create_frame): Restructure code to be more similar to the one in
376 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
377 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
378 Move terminal->reference_count++ just before making the frame official
381 * nsterm.m (x_free_frame_resources): New function.
382 (x_destroy_window): Move code to x_free_frame_resources.
384 * xfns.c (unwind_create_frame): Fix comment.
385 (Fx_create_frame, x_create_tip_frame): Move
386 terminal->reference_count++ just before making the frame
387 official. Move initialization of image_cache_refcount and
388 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
390 2011-11-05 Eli Zaretskii <eliz@gnu.org>
392 Support MSVC build with newer versions of Visual Studio.
393 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
394 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
397 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
398 which are not supported by MSVC.
399 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
400 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
402 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
404 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
406 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
408 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
410 Support MSVC build with newer versions of Visual Studio.
411 * w32.c: Don't include w32api.h for MSVC.
412 (init_environment) [_MSC_VER]: Call sys_access, not _access.
414 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
415 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
416 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
417 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
419 (alloca) [_MSC_VER]: Define to _alloca.
421 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
423 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
425 2011-11-04 Eli Zaretskii <eliz@gnu.org>
427 * xdisp.c (note_mouse_highlight): If either of
428 previous/next-single-property-change returns nil, treat that as
429 the beginning or the end of the buffer. (Bug#9955)
431 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
433 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
434 label is not null (Bug#9951).
435 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
438 2011-11-04 Eli Zaretskii <eliz@gnu.org>
440 * window.c (Fwindow_body_size): Mention in the doc string that the
441 return value is in frame's canonical units. (Bug#9949)
443 2011-11-03 Eli Zaretskii <eliz@gnu.org>
445 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
447 * w32fns.c (unwind_create_frame): If needed, free the glyph
448 matrices of the partially constructed frame. (Bug#9943)
449 * xfns.c (unwind_create_frame): Likewise.
451 2011-11-01 Eli Zaretskii <eliz@gnu.org>
453 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
454 Don't stop backward scan on the continuation glyph, even though
455 its CHARPOS is positive.
456 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
457 cover_string to disp_string.
459 2011-11-01 Martin Rudalics <rudalics@gmx.at>
461 * window.c (temp_output_buffer_show): Don't use
462 Vtemp_buffer_show_specifiers.
463 (Vtemp_buffer_show_specifiers): Remove unused variable.
465 2011-10-30 Eli Zaretskii <eliz@gnu.org>
467 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
468 past the beginning of the current glyph matrix.
470 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
472 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
473 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
474 HAVE_GTK3 (Bug#9869).
476 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
477 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
479 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
481 * xterm.c: Declare x_handle_net_wm_state to return int.
482 (handle_one_xevent): Check if we are iconified but don't have
483 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
484 (get_current_wm_state): Return non-zero if not hidden,
485 check for _NET_WM_STATE_HIDDEN (Bug#9893).
486 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
487 (x_handle_net_wm_state): Return what get_current_wm_state returns.
488 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
490 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
492 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
493 so that this new function doesn't get optimized away by a
494 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
496 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
498 * frame.h (MOUSE_HL_INFO): Remove excess parens.
500 2011-10-29 Eli Zaretskii <eliz@gnu.org>
502 Fix the `xbytecode' command.
503 * .gdbinit (xprintbytestr): New command.
504 (xwhichsymbols): Rename from `which'; all callers changed.
505 (xbytecode): Print the byte-code string as well.
507 2011-10-29 Kim Storm <storm@cua.dk>
509 * alloc.c (which_symbols): New function.
511 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
513 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
516 2011-10-29 Glenn Morris <rgm@gnu.org>
518 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
519 Not clear what it was for, and it causes various bugs. (Bug#9839)
521 2011-10-28 Eli Zaretskii <eliz@gnu.org>
523 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
524 possible random value that matches one of those tested as
525 condition to clear the mouse face.
527 2011-10-28 Chong Yidong <cyd@gnu.org>
529 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
531 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
533 * window.c (make_window): Initialize phys_cursor_on_p.
535 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
537 * lisp.h (struct Lisp_Symbol): Update comments.
539 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
541 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
543 2011-10-28 Eli Zaretskii <eliz@gnu.org>
545 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
546 <oslsachem@gmail.com> for helping to debug this.
548 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
549 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
550 (g_b_init_get_glyph_outline_w): New static variables.
551 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
552 (GetGlyphOutlineW_Proc): New typedefs.
553 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
554 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
556 (w32font_open_internal, compute_metrics):
557 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
558 instead of calling the "wide" APIs directly.
560 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
562 * w32.h (syms_of_w32font): Add prototype.
564 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
566 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
567 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
568 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
569 (Fmove_to_window_line): Doc fix.
571 2011-10-27 Chong Yidong <cyd@gnu.org>
573 * process.c (make_process): Set gnutls_state to NULL.
575 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
576 non-NULL, regardless of GNUTLS_INITSTAGE.
577 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
578 an error. Set process slots as soon as we allocate them.
580 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
582 2011-10-27 Chong Yidong <cyd@gnu.org>
584 * gnutls.c (emacs_gnutls_deinit): New function.
585 Deallocate credentials structures as well as calling gnutls_deinit.
586 (Fgnutls_deinit, Fgnutls_boot): Use it.
588 * process.c (make_process): Initialize GnuTLS credentials to NULL.
589 (deactivate_process): Call emacs_gnutls_deinit.
591 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
593 * image.c (x_create_x_image_and_pixmap):
594 * w32.c (sys_rename, w32_delayed_load):
595 * w32font.c (fill_in_logfont):
596 * w32reg.c (x_get_string_resource): Silence compiler warnings.
598 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
600 * w32fns.c (w32_default_color_map): New function,
601 extracted from Fw32_default_color_map.
602 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
604 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
606 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
608 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
610 * keyboard.c (test_undefined): New function (bug#9751).
611 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
613 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
615 * sysdep.c (init_sys_modes): Fix the check for the controlling
618 2011-10-20 Eli Zaretskii <eliz@gnu.org>
620 * dispextern.h (struct bidi_it): New member next_en_type.
622 * bidi.c (bidi_line_init): Initialize the next_en_type member.
623 (bidi_resolve_explicit_1): When next_en_pos is valid for the
624 current character, check also for next_en_type being WEAK_EN.
625 (bidi_resolve_weak): Don't enter the expensive loop if the current
626 position is before next_en_pos. Record the bidi type of the first
627 non-ET, non-BN character we find, in addition to its position.
628 (bidi_level_of_next_char): Invalidate next_en_type when
629 next_en_pos is over-stepped.
631 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
633 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
634 * editfns.c: Rewrite current-time-zone so that it invokes
635 the equivalent of (format-time-string "%Z") to get the time zone name.
636 This fixes a bug when the time zone name contains characters that
637 need converting from the system time locale to Emacs internal format.
638 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
639 that patch fixed format-time-string to do the conversion, but
640 I forgot to fix current-time-zone.
641 (format_time_string): New function, containing most of
642 what Fformat_time_string used to contain.
643 (Fformat_time_string): Rewrite in terms of format_time_string.
644 This doesn't change this function's behavior.
645 (current-time-zone): Rewrite to use format_time_string.
646 This fixes the bug reported by Michael Schierl in
647 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
648 Jason Rumney's 2007-06-07 change worked around this bug, but
650 * systime.h (tzname, timezone): Remove no-longer-used declarations.
652 2011-10-19 Eli Zaretskii <eliz@gnu.org>
654 * xdisp.c (start_display): If the character at POS is displayed
655 via a display vector, reset IT->current.dpvec_index to zero.
656 (try_window_reusing_current_matrix): If a line ends in a display
657 vector or the next line starts in a display vector, continue
658 redrawing the window even though the character position of
659 start_row was reached.
662 2011-10-18 Chong Yidong <cyd@gnu.org>
664 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
665 with nobreak-char-display too.
667 2011-10-18 Eli Zaretskii <eliz@gnu.org>
669 Fix part 3 of bug#9771.
670 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
671 (bidi_resolve_neutral): Don't enter the expensive loop looking for
672 non-neutral characters if the current character is a paragraph
673 separator (a.k.a. Newline). This avoids running the same
674 expensive loop twice, once when we consume the preceding newline
675 and the other time when the line actually needs to be displayed.
676 Avoid the loop when we see neutrals on the base embedding level
677 following a character whose directionality is the same as the
678 paragraph's. This avoids running the expensive loop when a line
679 ends in a long sequence of neutrals, like control characters.
680 Add assertion against STRONG_AL type. Slightly rearrange code
681 that determines the type of a neutral given the first non-neutral
683 (bidi_level_of_next_char): Set next_en_pos to zero when
684 invalidating its info.
686 2011-10-17 Eli Zaretskii <eliz@gnu.org>
688 * xdisp.c (push_display_prop): Determine whether to record string
689 or buffer position by IT->string, not by IT->method. Allow
690 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
691 (move_it_vertically_backward): Don't look for character position
692 immediately after the newline when in a continuation line.
695 2011-10-15 Martin Rudalics <rudalics@gmx.at>
697 * window.c (coordinates_in_window): Rewrite and delabelize
698 vertical border check. (Bug#5357) (Bug#9618)
700 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
702 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
703 errors in XSetWindowBorder (bug#9310).
705 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
707 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
708 avoid crash when xmalloc overrun checking is enabled.
710 2011-10-13 Eli Zaretskii <eliz@gnu.org>
712 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
713 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
714 cursor motion with <left> and <right> arrow keys.
716 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
717 some callers set that themselves.
719 2011-10-12 Eli Zaretskii <eliz@gnu.org>
721 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
722 display string and the previous row comes from the same string and
723 is empty. (Bug#9739) (Bug#9738)
725 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
727 * doc.c (get_doc_string): Encode file name (bug#9735).
729 2011-10-12 Eli Zaretskii <eliz@gnu.org>
731 * bidi.c (bidi_level_of_next_char):
732 * xdisp.c (get_visually_first_element): Remove old incorrect
733 comments regarding the Unicode Line Separator character.
735 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
737 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
739 * alloc.c (Fgc_status): Do not access beyond zombies array
740 boundary if nzombies > MAX_ZOMBIES.
741 * alloc.c (dump_zombies): Add missing format specifier.
743 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
745 * xdisp.c (set_cursor_from_row): Simplify conditionals,
746 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
748 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
749 Some packages use them to denote characters with modifiers.
751 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
753 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
754 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
755 matching a pp-number. Rename parameter var to var1.
757 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
759 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
761 2011-10-08 Glenn Morris <rgm@gnu.org>
763 * callint.c (Fcall_interactively): Give a more explicit error for the
764 'c' case with a non-character input. (Bug#8479)
766 2011-10-08 Eli Zaretskii <eliz@gnu.org>
768 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
770 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
771 lines that are hscrolled on the left.
773 * dispnew.c (buffer_posn_from_coords): Account for a possible
774 presence of header-line. (Bug#4426)
776 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
778 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
779 Don't advertise functionality which we discourage or doesn't work.
781 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
783 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
784 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
785 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
786 this makes Emacs dump core during garbage collection on rare
787 occasions. sizeof is obviously inferior to offsetof here, so
789 (GC_POINTER_ALIGNMENT): New macro.
790 (mark_memory): Omit 3rd (offset) arg; caller changed.
791 Don't assume EMACS_INT alignment is the same as pointer alignment.
793 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
795 * keyboard.c (read_key_sequence_remapped): New var.
796 (read_key_sequence): Compute remapping in the right buffer.
797 (command_loop_1): Use read_key_sequence's remapping directly.
799 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
801 * dired.c (file_name_completion): Don't expand file name.
802 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
803 before checking file name handler.
805 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
806 they've been requested explicitly (bug#9591).
808 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
810 * keymap.c (Fsingle_key_description): Use make_specified_string
811 instead of build_string to build string from push_key_description.
814 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
816 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
817 This fixes a Y2038 bug on 64-bit hosts.
818 * buffer.c (reset_buffer):
819 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
820 (Fclear_buffer_auto_save_failure):
821 Use 0, not -1, to represent an unset failure time, since time_t
824 Remove dependency on glibc malloc internals.
825 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
826 Move back here from lisp.h, but with their new implementations.
827 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
828 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
829 * charset.c (charset_table_init): New static var.
830 (syms_of_charset): Use it instead of xmalloc. This removes a
831 dependency on glibc malloc internals. See Eli Zaretskii's comment in
832 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
833 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
834 Move back to alloc.c.
835 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
836 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
838 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
840 * nsterm.m (windowDidResize): Call x_set_window_size only when
841 ns_in_resize is true. Otherwise set pixelwidth/height and
842 call change_frame_size (Bug#9628).
844 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
846 Port --enable-checking=all to Fedora 14 x86-64.
847 * charset.c (syms_of_charset): Also account for glibc malloc's
848 internal overhead when calculating the initial malloc maximum.
850 Port --enable-checking=all to Fedora 14 x86.
851 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
853 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
854 (overrun_check_realloc, overrun_check_free):
855 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
856 That way, xmalloc returns a properly-aligned pointer even if
857 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
858 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
859 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
860 into account when calculating the initial malloc maximum.
861 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
862 Move here from alloc.c, so that charset.c can use it too.
863 Properly align; the old code wasn't right for common 32-bit hosts
864 when configured with --enable-checking=all.
865 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
866 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
868 2011-09-29 Eli Zaretskii <eliz@gnu.org>
870 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
873 2011-09-28 Eli Zaretskii <eliz@gnu.org>
875 * xdisp.c (compute_display_string_end): If there's no display
876 string at CHARPOS, return -1.
878 * bidi.c (bidi_fetch_char): When compute_display_string_end
879 returns a negative value, treat the character as a normal
880 character not covered by a display string. (Bug#9624)
882 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
884 * lread.c (Fread_from_string): Fix typo in docstring.
886 2011-09-27 Eli Zaretskii <eliz@gnu.org>
888 * xdisp.c (handle_invisible_prop): If invisible text ends on a
889 newline, reseat the iterator instead of bidi-iterating there one
890 character at a time. (Bug#9610)
891 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
892 TO_CHARPOS if the bidi iterator is at base embedding level.
894 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
896 * lread.c (readevalloop): Use correct code for NBSP.
897 (read1): Likewise. (Bug#9608)
899 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
901 * dbusbind.c (Fdbus_register_signal): When service is not
902 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
904 2011-09-25 Glenn Morris <rgm@gnu.org>
906 * buffer.c (truncate-lines): Doc fix.
908 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
910 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
911 (Fset_window_next_buffers): Doc fix.
913 2011-09-24 Glenn Morris <rgm@gnu.org>
915 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
917 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
919 Fix minor problems found by static checking.
920 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
921 * indent.c (Fvertical_motion): Fix == vs = typo.
923 2011-09-24 Eli Zaretskii <eliz@gnu.org>
925 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
926 Default value is now t. Doc fix.
928 * indent.c (Fvertical_motion): Compute and apply the overshoot
929 logic when moving up, not only when moving down. Fix the
930 confusing name and values of the it_overshoot_expected variable;
931 logic changes accordingly. (Bug#9254) (Bug#9549)
933 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
934 CHARPOS is covered by a display string which includes newlines.
935 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
936 is covered by a display string with embedded newlines.
938 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
940 * dbusbind.c (Fdbus_register_signal): Add match rule to
941 Vdbus_registered_objects_table. (Bug#9581)
942 (Fdbus_register_method, Vdbus_registered_objects_table):
945 2011-09-24 Jim Meyering <meyering@redhat.com>
947 do not ignore write error for any output size
948 The previous change was incomplete.
949 While it makes emacs --batch detect the vast majority of stdout
950 write failures, errors were still ignored whenever the output size is
951 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
952 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
953 && echo FAIL: ignored write error
954 FAIL: ignored write error
955 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
956 && echo FAIL: ignored write error
957 FAIL: ignored write error
958 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
960 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
962 * emacs.c (Fkill_emacs): In noninteractive mode exit
963 non-successfully if a write error occurred on stdout. (Bug#9574)
965 2011-09-21 Eli Zaretskii <eliz@gnu.org>
967 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
970 * dispextern.h (struct it): Update the comment documenting what
973 2011-09-20 Eli Zaretskii <eliz@gnu.org>
975 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
976 a display string, extend search for cursor position to end of row.
977 (find_row_edges): If the row ends in a newline from a display
978 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
979 Handle the case of a display string with multiple newlines.
980 (Fcurrent_bidi_paragraph_direction): Fix search for previous
981 non-empty line. Fixes confusing cursor motion with arrow keys at
982 the beginning of a line that starts with whitespace.
984 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
986 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
989 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
991 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
994 2011-09-18 Eli Zaretskii <eliz@gnu.org>
996 * xdisp.c (display_line): Record maximum and minimum buffer
997 positions even if no glyphs were produced (e.g., by a zero-width
998 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
999 buffer positions that will be removed from the glyph row because
1001 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1002 column is beyond frame width: don't subtract 1 "pixel" when
1003 computing width of the stretch.
1004 (reseat_at_next_visible_line_start): Undo the change made on
1005 2011-09-17 that saved paragraph information and restored it after
1006 the call to `reseat'. (Bug#9545)
1008 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1010 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1011 and turn window cursor on if cleared (Bug#9415).
1013 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1015 * search.c (boyer_moore): Take unibyte characters from pattern
1016 literally. (Bug#9458)
1018 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1020 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1022 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1024 Fix minor problem found by static checking.
1025 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1026 initialized, to pacify gcc -Wuninitialized.
1028 * fileio.c: Report proper errno when syscall falls.
1029 (Finsert_file_contents): Save and restore errno,
1030 so that report_file_error outputs the correct diagnostic.
1031 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1033 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1035 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1037 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1039 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1040 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1042 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1044 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1045 about the current paragraph and restore it after the call to reseat.
1047 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1048 (bidi_find_paragraph_start): Search back for paragraph beginning
1049 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1050 (bidi_move_to_visually_next): Only trigger paragraph-related
1051 computations when the last character is a newline or at EOB, not
1052 just any NEUTRAL_B. (Bug#9470)
1054 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1055 truncated lines if point is covered by a display string. (Bug#9524)
1057 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1059 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1060 (cons_to_x_long): New function.
1061 (lisp_data_to_selection_data): Use it. Correct the test for
1062 short-versus-long data; it was negated. Break out of vector
1063 loop, for efficiency, when a long datum is discovered.
1065 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1067 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1069 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1071 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1072 GCC PR/17406) by declaring this function with external scope.
1074 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1076 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1077 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1079 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1081 * editfns.c (Fformat): Correctly handle text properties on "%%".
1083 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1085 * xterm.c (x_draw_composite_glyph_string_foreground):
1086 * w32term.c (x_draw_composite_glyph_string_foreground):
1087 * term.c (encode_terminal_code):
1088 * composite.c (composition_update_it, get_composition_id):
1089 * xdisp.c (get_next_display_element)
1090 (fill_composite_glyph_string): Add comments about special meaning
1091 of TAB characters in a composition.
1093 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1095 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1096 This occurs when processing a multibyte format.
1097 Problem reported by Wolfgang Jenker.
1099 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1101 * xdisp.c (try_cursor_movement): Only check for exact match if
1102 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1104 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1106 Remove unused external symbols.
1107 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1108 * xdisp.c (calc_pixel_width_or_height): Now static.
1109 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1110 * indent.c (check_display_width):
1111 * w32term.c: Fix comment to match code.
1112 * xterm.c, xterm.h (x_catching_errors): Remove.
1114 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1116 * xselect.c: Use signed conversions more consistently (Bug#9498).
1117 (selection_data_to_lisp_data): Assume incoming selection data are
1118 signed integers, not unsigned. This is to be consistent with
1119 outgoing selection data, which was modified to use signed integers
1120 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1121 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1122 expects long, not unsigned long.
1124 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1126 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1127 computation of loop end. Reported by Johan Bockgård
1130 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1132 * frame.c (Fother_visible_frames_p): Function deleted.
1134 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1136 * indent.c (compute_motion): Process display vector front to back
1137 rather than the other way around. (Bug#2496)
1139 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1141 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1143 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1145 * minibuf.c (Fread_from_minibuffer): Doc fix.
1147 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1149 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1150 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1152 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1154 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1155 value for non-existent files.
1157 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1159 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1160 set its "size" to -1. This will set the modtime_size field of
1161 the corresponding buffer to -1, which is what
1162 verify-visited-file-modtime expects for files that do not exist.
1165 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1167 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1169 * lisp.h: ... from here. push_key_description is no longer
1170 defined in keyboard.c, so its declaration should not be in
1171 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1172 logically belongs with push_key_description.
1174 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1176 * buffer.h: Include <sys/types.h> instead of <time.h>.
1177 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1178 Problem reported by Herbert J. Skuhra.
1180 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1182 * xml.c (parse_region): Make the parsing work for
1183 non-comment-starting XML files again (bug#9144).
1185 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1187 * image.c (gif_load): Fix calculation of bottom and right corner.
1190 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1192 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1193 redisplay in small windows.
1195 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1197 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1199 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1201 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1202 Operate on live windows only.
1204 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1206 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1208 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1210 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1211 only under bidi iteration.
1213 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1215 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1217 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1219 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1220 Without this fix, the command to link temacs failed due to an
1221 undefined symbol __builtin_isnan. This is because
1222 /usr/include/iso/math_c99.h #defines isnan(x) to
1223 __builtin_isnan(x), but the bundled gcc, which identifies itself
1224 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1226 * floatfns.c (isnan): #undef, and then #define to a clone of
1228 (Fisnan): Always define, since it's always available now.
1229 (syms_of_floatfns): Always define isnan at the Lisp level.
1231 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1233 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1235 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1237 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1238 The previous code assumed that file offsets (off_t values) fit in
1239 EMACS_INT variables, which is not true on typical 32-bit hosts.
1240 The code messed up by falsely reporting buffer overflow in cases
1241 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1242 when "big" contains more than 2**29 bytes, even though this
1243 inserts just one byte and does not overflow the buffer.
1244 (Finsert_file_contents): Store file offsets as off_t
1245 values, not as EMACS_INT values. Check for overflow when
1246 converting between EMACS_INT and off_t. When checking for
1247 buffer overflow or for overlap, take the offsets into account.
1248 Don't use EMACS_INT for small values where int suffices.
1249 When checking for overlap, fix a typo: ZV was used where
1250 ZV_BYTE was intended.
1251 (Fwrite_region): Don't assume off_t fits into 'long'.
1252 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1254 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1256 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1258 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1260 sprintf-related integer and memory overflow issues (Bug#9412).
1262 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1263 (esprintf, exprintf, evxprintf): New functions.
1264 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1265 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1266 (modify_event_symbol): Do not assume that the length of
1267 name_alist_or_stem is safe to alloca and fits in int.
1268 (Fexecute_extended_command): Likewise for function name and binding.
1269 (Frecursion_depth): Wrap around reliably on integer overflow.
1270 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1271 since some callers pass EMACS_INT values.
1272 (Fsingle_key_description): Don't crash if symbol name contains more
1273 than MAX_ALLOCA bytes.
1274 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1275 (get_minibuffer): Arg is now EMACS_INT, not int.
1276 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1277 (esprintf, exprintf, evxprintf): New decls.
1278 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1280 * dbusbind.c (signature_cat): New function.
1281 (xd_signature, Fdbus_register_signal):
1282 Do not overrun buffer; instead, report string overflow.
1284 * dispnew.c (add_window_display_history): Don't overrun buffer.
1285 Truncate instead; this is OK since it's just a log.
1287 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1288 even if the time zone offset is outlandishly large.
1289 Don't mishandle offset == INT_MIN.
1291 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1292 when creating daemon; the previous buffer-overflow check was incorrect.
1294 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1295 which has the guts of the old verror function.
1297 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1298 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1300 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1301 (font_unparse_xlfd): Don't blindly alloca long strings.
1302 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1303 fits in int, when using sprintf. Use single snprintf to count
1304 length of string rather than counting it via multiple sprintfs;
1305 that's simpler and more reliable.
1306 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1307 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1308 sprintf, in case result does not fit in int.
1310 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1311 (fontset_from_font): Print it.
1313 * frame.c (tty_frame_count): Now printmax_t, not int.
1314 (make_terminal_frame, set_term_frame_name): Print it.
1315 (x_report_frame_params): In X, window IDs are unsigned long,
1316 not signed long, so print them as unsigned.
1317 (validate_x_resource_name): Check for implausibly long names,
1318 and don't assume name length fits in 'int'.
1319 (x_get_resource_string): Don't blindly alloca invocation name;
1320 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1323 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1324 (xg_check_special_colors, xg_set_geometry):
1325 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1327 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1328 Use esprintf, not sprintf, in case result does not fit in int.
1330 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1331 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1332 it as a large positive number.
1333 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1334 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1336 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1337 in case result does not fit in int.
1339 * print.c (float_to_string): Detect width overflow more reliably.
1340 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1341 buffer overrun. Don't assume list length fits in 'int'. Treat
1342 print length of 0 as 0, not as infinity; to be consistent with other
1343 uses of print length in this function. Don't overflow print length
1344 index. Don't assume hash table size fits in 'long', or that
1345 vectorlike size fits in 'unsigned long'.
1347 * process.c (make_process): Use printmax_t, not int, to format
1348 process-name gensyms.
1350 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1352 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1353 to avoid potential buffer overrun.
1355 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1356 if X resource line is longer than 512 bytes.
1358 * xfns.c (x_window): Make sprintf buffer a bit bigger
1359 to avoid potential buffer overrun.
1361 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1363 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1365 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1367 Integer overflow fixes for scrolling, etc.
1368 Without these, Emacs silently mishandles large integers sometimes.
1369 For example, "C-u 4294967297 M-x recenter" was treated as if
1370 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1372 * xdisp.c (try_window_id): Check Emacs fixnum range before
1373 converting to 'int'.
1375 * window.c (window_scroll_line_based, Frecenter):
1376 Check that an Emacs fixnum is in range before assigning it to 'int'.
1377 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1378 values converted from Emacs fixnums.
1379 (Frecenter): Don't wrap around a line count if it is out of 'int'
1380 range; instead, treat it as an extreme value.
1381 (Fset_window_configuration, compare_window_configurations):
1382 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1384 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1385 that can exceed INT_MAX. Check that EMACS_INT value is in range
1386 before assigning it to the (possibly-narrower) index.
1387 (match_limit): Don't assume that a fixnum can fit in 'int'.
1389 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1392 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1393 (Fvertical_motion): Don't wrap around LINES values that don't fit
1394 in 'int'. Instead, treat them as extreme values. This is good
1395 enough for windows, which can't have more than INT_MAX lines anyway.
1397 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1399 * Require libxml/parser.h to avoid compilation warning.
1401 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1403 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1404 since this reportedly can destroy thread storage.
1406 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1408 * syntax.c (find_defun_start): Update all cache variables if
1409 exiting early (Bug#9401).
1411 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1413 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1415 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1416 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1417 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1419 * term.c (tty_append_glyph): New function.
1420 (produce_stretch_glyph): Static function and its prototype deleted.
1422 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1425 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1427 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1428 when checking :margin (Bug#9390).
1429 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1430 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1431 so that the name doesn't mislead. All uses changed.
1433 2011-08-28 Johan Bockgård <bojohan@gnu.org>
1435 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1438 2011-08-27 Eli Zaretskii <eliz@gnu.org>
1440 * xdisp.c (move_it_to): Don't bail out early when reaching
1441 position beyond to_charpos, if we are scanning backwards.
1442 (move_it_vertically_backward): When DY == 0, make sure we get to
1443 the first character in the line after the newline.
1445 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1447 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1448 (ccl_driver): Do not generate an out-of-range pointer.
1449 (Fccl_execute_on_string): Remove unnecessary check for
1450 integer overflow, noted by Stefan Monnier in
1451 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1452 Remove a FIXME that didn't need fixing.
1453 Simplify the newly-introduced buffer reallocation code.
1455 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
1457 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1459 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1461 Integer and memory overflow issues (Bug#9196).
1463 * doc.c (get_doc_string): Rework so that
1464 get_doc_string_buffer_size is the actual buffer size, rather than
1465 being 1 less than the actual buffer size; this makes xpalloc more
1468 * image.c (x_allocate_bitmap_record, cache_image):
1469 * xselect.c (Fx_register_dnd_atom):
1470 Simplify previous changes by using xpalloc.
1472 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1473 since either will do and ptrdiff_t is convenient with xpalloc.
1475 * charset.c (charset_table_size)
1476 (struct charset_sort_data.priority): Now ptrdiff_t.
1477 (charset_compare): Don't overflow if priorities differ greatly.
1478 (Fsort_charsets): Don't assume list length fits in int.
1479 Check for size-calculation overflow when allocating sort data.
1480 (syms_of_charset): Allocate an initial charset table that is
1481 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1483 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1485 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1486 The actual value is always <= INT_MAX, and leaving it unsigned made
1487 overflow checking harder.
1489 * dispextern.h (struct glyph_matrix.rows_allocated)
1490 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1491 with xpalloc. The values are still always <= INT_MAX.
1493 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1495 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1496 (SAFE_NALLOCA): New macro.
1498 * region-cache.c (struct boundary.pos, find_cache_boundary)
1499 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1500 (set_cache_region, invalidate_region_cache)
1501 (revalidate_region_cache, know_region_cache, region_cache_forward)
1502 (region_cache_backward, pp_cache):
1503 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1504 so that ptrdiff_t * can be passed to xpalloc.
1505 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1506 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1507 (pp_cache): Don't assume cache_len fits in int.
1508 * region-cache.h: Adjust extern decls to match.
1510 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1511 EMACS_INT, since either will do, for xpalloc.
1513 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1514 (xnmalloc, xnrealloc, xpalloc): New functions.
1516 * bidi.c (bidi_shelve_header_size): New constant.
1517 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1518 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1520 * bidi.c (bidi_cache_shrink):
1521 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1523 Don't update size of array until after memory allocation succeeds,
1524 because xmalloc/xrealloc may not return.
1525 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1526 now that we have proper integer overflow checking.
1527 (record_overlay_string, overlay_strings): Catch overflows when
1528 calculating size of overlay_str_buf.
1530 * callproc.c (Fcall_process): Check for size overflow when
1531 calculating size of args2.
1532 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1533 Normally we prefer signed values, but sticking with ptrdiff_t would
1534 require adding more-complicated checks.
1536 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1537 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1538 Redo buffer-overflow calculations to avoid integer overflow.
1539 Add a FIXME comment where memory seems to be over-allocated.
1541 * character.c (Fstring): Check for size-calculation overflow.
1543 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1544 unnecessary integer overflow. Check for size overflow.
1545 (encode_coding_object): Don't update size until xmalloc succeeds.
1547 * composite.c (get_composition_id): Check for overflow in glyph
1548 length calculations.
1550 Integer and memory overflow fixes for display code.
1551 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1552 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1553 (scrolling_window): Check for overflow in size calculations.
1554 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1555 Don't assume glyph table len fits in int.
1556 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1557 (row_table_size): Now ptrdiff_t, not int.
1558 (scrolling_window): Avoid overflow in size calculations.
1559 Don't update size until allocation succeeds.
1560 * fns.c (concat): Check for overflow in size calculations.
1561 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1562 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1563 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1565 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1566 (get_doc_string): Check for size calculation overflow.
1567 Don't update size until allocation succeeds.
1568 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1569 EMACS_INT, where ptrdiff_t will do.
1570 (Fsubstitute_command_keys): Check for string overflow.
1572 * editfns.c (set_time_zone_rule): Don't assume environment length
1574 (message_length): Now ptrdiff_t, not int.
1575 (Fmessage_box): Don't update size until allocation succeeds.
1576 Don't assume message length fits in int.
1577 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1579 * emacs.c (main): Do not reallocate argv, since there is a null at
1580 the end that can be overwritten, and this way there's no need to
1581 worry about size-calculation overflow.
1582 (sort_args): Check for size-calculation overflow.
1584 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1586 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1588 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1589 (x_set_scroll_bar_width, x_figure_window_size):
1590 Check for integer overflow.
1591 (x_set_alpha): Do not assume XINT fits in int.
1593 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1594 This is for the members text_lines, text_cols, total_lines, total_cols,
1595 where the system imposes an 'int' limit.
1597 * fringe.c (Fdefine_fringe_bitmap):
1598 Don't update size until alloc works.
1600 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1601 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1603 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1604 Check for size-calculation overflow.
1605 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1606 do, as we prefer signed integers.
1607 (id_to_widget.max_size, id_to_widget.used)
1608 (xg_store_widget_in_map, xg_remove_widget_from_map)
1609 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1610 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1611 Use and return ptrdiff_t, not int.
1612 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1613 * gtkutil.h: Change prototypes to match the above.
1615 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1616 are duplicate now that they've been promoted to lisp.h.
1617 (x_allocate_bitmap_record, x_alloc_image_color)
1618 (make_image_cache, cache_image, xpm_load):
1619 Don't update size until alloc is done.
1620 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1622 Check for size calculation overflow.
1623 (ct_colors_allocated_max): New constant.
1624 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1627 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1628 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1629 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1630 Use ptrdiff_t, not int, to count maps.
1631 (read_char_minibuf_menu_prompt): Check for overflow in size
1632 calculations. Don't update size until allocation succeeds.
1633 Redo calculations to avoid overflow.
1634 * keyboard.h: Change prototypes to match the above.
1636 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1638 (current_minor_maps): Check for size calculation overflow.
1639 * keymap.h: Change prototypes to match the above.
1641 * lread.c (read1, init_obarray): Don't update size until alloc done.
1643 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1644 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1646 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1647 Now ptrdiff_t, not int.
1648 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1649 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1651 * process.c (Fnetwork_interface_list): Check for overflow
1652 in size calculation.
1654 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1656 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1657 overflow. Don't bother calling xmalloc when xrealloc will do.
1659 * search.c (Freplace_match): Check for size calculation overflow.
1660 (Fset_match_data): Don't assume list lengths fit in 'int'.
1662 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1663 for command line length. Do not attempt to address one before the
1664 beginning of an array, as that's not portable.
1666 * term.c (max_frame_lines): Remove; unused.
1667 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1669 (encode_terminal_code, calculate_costs): Check for size
1670 calculation overflow.
1671 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1672 table lengths and related sizes. Don't update size until alloc
1673 done. Redo calculations to avoid overflow.
1674 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1676 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1677 subtracting pointers.
1678 (gobble_line): Check for overflow more carefully. Don't update size
1681 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1682 Don't update size until alloc done.
1683 Redo size calculations to avoid overflow.
1684 Check for size calculation overflow.
1685 (main) [DEBUG]: Fix typo in invoking tparam1.
1687 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1688 Use ptrdiff_t, not int, for sizes.
1689 (store_mode_line_noprop_char): Don't update size until alloc done.
1691 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1692 Use ptrdiff_t, not int, for sizes.
1693 (Finternal_make_lisp_face, cache_face):
1694 Check for size calculation overflow.
1695 (cache_face): Treat size calculation overflows as if they were
1696 memory exhaustion (the usual treatment), rather than aborting.
1698 * xfns.c (x_encode_text, x_set_name_internal)
1699 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1700 sizes, since they can exceed INT_MAX in size. Check for size
1701 calculation overflow.
1703 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1704 (xg_select): Check for size calculation overflow.
1705 Don't update size until alloc done.
1707 * xrdb.c (get_environ_db): Don't assume path length fits in int,
1708 as sprintf is limited to int lengths.
1710 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1711 (X_LONG_MIN): New macros.
1712 Use them to make the following changes clearer.
1713 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1714 This change doesn't affect the value now, but it may help remind
1715 future maintainers not to raise the value too much later.
1716 (SELECTION_QUANTUM): Remove, replacing with ...
1717 (selection_quantum): ... new function, which avoids overflow.
1719 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1720 assumption that selection length fits in 'int'.
1721 (x_reply_selection_request, x_handle_selection_request)
1722 (x_get_window_property, receive_incremental_selection)
1723 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1724 (lisp_data_to_selection_data, clean_local_selection_data):
1725 Use ptrdiff_t, not int, to record length of selection.
1726 (x_reply_selection_request, x_get_window_property)
1727 (receive_incremental_selection, x_property_data_to_lisp):
1728 Redo calculations to avoid overflow.
1729 (x_reply_selection_request): When sending hint, ceiling it at
1730 X_LONG_MAX rather than relying on wraparound overflow to send
1732 (x_get_window_property, receive_incremental_selection)
1733 (lisp_data_to_selection_data, x_property_data_to_lisp):
1734 Check for size-calculation overflow.
1735 (x_get_window_property, receive_incremental_selection)
1736 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1737 Don't store size until memory allocation succeeds.
1738 (x_get_window_property): Plug memory leak on memory exhaustion.
1739 Don't double-block input; malloc is safe here. Don't assume 2**34
1740 - 4 fits in unsigned long. Add an xassert to check
1741 XGetWindowProperty overflow. Be more careful about overflow
1742 calculations, and distinguish size from memory overflow better.
1743 (receive_incremental_selection): When tracing, don't assume
1744 unsigned int is less than INT_MAX.
1745 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1746 harmful) conversions of unsigned short to int.
1747 (lisp_data_to_selection_data): Don't assume that integers
1748 in the range -65535 through -1 fit in an X unsigned short.
1749 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1750 result parameters unless successful. Rely on cons_to_unsigned
1751 to report problems with elements; the old code wasn't right anyway.
1752 (x_check_property_data): Check for int overflow; we cannot use
1753 a wider type due to X limits.
1754 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1756 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
1758 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1759 (x_term_init): Check for size calculation overflow.
1760 (x_color_cells): Don't store size until memory allocation succeeds.
1761 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
1762 Don't assume alloca size is less than MAX_ALLOCA.
1763 (x_term_init): Don't assume length fits in int (sprintf is limited
1766 Use ptrdiff_t for composition IDs.
1767 * character.c (lisp_string_width):
1768 * composite.c (composition_table_size, n_compositions)
1769 (get_composition_id, composition_gstring_from_id):
1770 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1771 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1772 * window.c (Frecenter):
1773 Use ptrdiff_t, not int, for composition IDs.
1774 * composite.c (get_composition_id): Check for integer overflow.
1775 * composite.h: Adjust prototypes to match the above changes.
1777 Use ptrdiff_t for hash table indexes.
1778 * category.c (hash_get_category_set):
1779 * ccl.c (ccl_driver):
1780 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1781 * coding.c (coding_system_charset_list, detect_coding_system):
1782 * coding.h (struct coding_system.id):
1783 * composite.c (get_composition_id, gstring_lookup_cache):
1784 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1785 * image.c (xpm_get_color_table_h):
1786 * lisp.h (hash_lookup, hash_put):
1787 * minibuf.c (Ftest_completion):
1788 Use ptrdiff_t for hash table indexes, not int (which is too
1789 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1790 32-bit --with-wide-int hosts).
1792 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1793 Add a FIXME comment about memory leaks.
1794 (syms_of_charset): Don't assume xmalloc returns.
1796 Don't assume that stated character widths fit in int.
1797 * character.c (Fchar_width, c_string_width, lisp_string_width):
1798 * character.h (CHAR_WIDTH):
1799 * indent.c (MULTIBYTE_BYTES_WIDTH):
1800 Use sanitize_char_width to avoid undefined and/or bad behavior
1801 with outlandish widths.
1802 * character.h (sanitize_tab_width): Rename from sanitize_width,
1803 now that we have two such functions. All uses changed.
1804 (sanitize_char_width): New inline function.
1806 Don't assume that tab-width fits in int.
1807 * character.h (sanitize_width): New inline function.
1808 (SANE_TAB_WIDTH): New macro.
1809 (ASCII_CHAR_WIDTH): Use it.
1810 * indent.c (sane_tab_width): Remove. All uses replaced by
1811 SANE_TAB_WIDTH (current_buffer).
1812 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1814 * fileio.c: Integer overflow issues with file modes.
1815 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1817 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1818 Remove unreachable code.
1819 (read_hex, load_charset_map_from_file): Check for integer overflow.
1821 * xterm.c: don't go over XClientMessageEvent limit
1822 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1823 (x_send_scroll_bar_event): Likewise. Check that the size does not
1824 exceed limits imposed by XClientMessageEvent, as well as the usual
1825 ptrdiff_t and size_t limits.
1827 * keyboard.c: Overflow, signedness and related fixes.
1828 (make_lispy_movement): Use same integer type in forward decl
1829 that is used in the definition.
1830 (read_key_sequence, keyremap_step):
1831 Change bufsize argument back to int, undoing my 2011-03-30 change.
1832 We prefer signed types, and int is wide enough here.
1833 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1834 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1835 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1836 length, not size_t. Use ptrdiff_t for index, not int.
1837 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1838 possibility of integer overflow.
1840 Overflow, signedness and related fixes for images.
1842 * dispextern.h (struct it.stack[0].u.image.image_id)
1843 (struct_it.image_id, struct image.id, struct image_cache.size)
1844 (struct image_cache.used, struct image_cache.ref_count):
1845 * gtkutil.c (update_frame_tool_bar):
1846 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1847 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1848 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1849 * nsmenu.m (update_frame_tool_bar):
1850 * xdisp.c (calc_pixel_width_or_height):
1851 * xfns.c (image_cache_refcount):
1852 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1853 on typical 64-bit hosts.
1855 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1856 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1857 Omit unnecessary casts to int.
1858 (parse_image_spec): Check that integers fall into 'int' range
1859 when the callers expect that.
1860 (image_ascent): Redo ascent calculation to avoid int overflow.
1861 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1862 (lookup_image): Remove unnecessary tests.
1863 (xbm_image_p): Locals are now of int, not EMACS_INT,
1864 since parse_image_check makes sure they fit into int.
1865 (png_load, gif_load, svg_load_image):
1866 Prefer int to unsigned where either will do.
1867 (tiff_handler): New function, combining the cores of the
1868 old tiff_error_handler and tiff_warning_handler.
1869 This function is rewritten to use vsnprintf and thereby avoid
1870 stack buffer overflows. It uses only the features of vsnprintf
1871 that are common to both POSIX and native Microsoft.
1872 (tiff_error_handler, tiff_warning_handler): Use it.
1873 (tiff_load, gif_load, imagemagick_load_image):
1874 Don't assume :index value fits in 'int'.
1875 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1876 (imagemagick_load_image): Check that crop parameters fit into
1877 the integer types that MagickCropImage accepts. Don't assume
1878 Vimagemagick_render_type has a nonnegative value. Don't assume
1879 size_t fits in 'long'.
1880 (gs_load): Use printmax_t to print the widest integers possible.
1881 Check for integer overflow when computing image height and width.
1883 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1885 * xdisp.c (redisplay_window): Don't force window start if point
1886 will be invisible in the resulting window. (Bug#9324)
1888 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1890 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1891 the display spec is of the form `(space ...)'.
1892 (handle_display_spec): Return the value returned by
1893 handle_single_display_spec, not just 1 or zero.
1894 (handle_single_display_spec): If the display spec is of the form
1895 `(space ...)', and specifies display in the text area, return 2
1897 (try_cursor_movement): Check for the need to scroll more
1898 accurately, and prefer exact match for point under bidi.
1899 Don't advance `row' beyond the last row of the window.
1901 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1902 into disp_prop; all users changed.
1904 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1905 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1906 for the text covered by the display property.
1908 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1910 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1911 Change return value to nil.
1912 (Frecord_buffer): Delete unused function.
1914 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1916 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1917 buffers, return left-to-right.
1918 (set_cursor_from_row): Consider candidate row a win if its glyph
1919 represents a newline and point is on that newline. Fixes cursor
1920 positioning on the newline at EOL of R2L text within L2R
1921 paragraph, and vice versa.
1922 (try_cursor_movement): Check continued rows, in addition to
1923 continuation rows. Fixes unwarranted scroll when point enters a
1924 continued line of R2L text within an L2R paragraph, or vice versa.
1925 (cursor_row_p): Consider the case of point being equal to
1926 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1927 from the end of a short line to the beginning of a continued line
1928 of R2L text within L2R paragraph.
1929 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1930 composed characters.
1932 * bidi.c (bidi_check_type): Use xassert.
1933 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1936 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1938 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1941 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1943 * nsfont.m (ns_otf_to_script): Fix typo.
1945 2011-08-22 Kenichi Handa <handa@m17n.org>
1947 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1948 extra slot even if the purpose is char-code-property-table.
1950 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1952 * xdisp.c (redisplay_window): When computing centering_position,
1953 account for the height of the header line. (Bug#8874)
1955 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1956 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1957 candidate is selected by the mouse, and that candidate has a
1958 composed character under the mouse.
1960 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1961 coordinates reported by pos-visible-in-window-p for a composed
1962 character in column zero.
1964 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1966 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1968 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1970 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1971 consider it a hit if to_charpos is anywhere in the range of the
1972 composed buffer positions.
1974 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1976 * image.c (gif_load): Don't assume that each subimage has the same
1977 dimensions as the base image. Handle disposal method that is
1978 "undefined" by the gif spec (Bug#9335).
1980 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1982 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1983 (Fcondition_case): Document `debug' symbol in error handler.
1985 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1987 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1988 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1989 from an Org mode buffer to a Speedbar frame.
1991 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1992 a composition, take its buffer position from IT->cmp_it.charpos.
1993 Fixes cursor positioning at the beginning of a line that begins
1994 with a composed character.
1996 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1998 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1999 character bidirectional type, use STRONG_L instead. Fixes crashes
2000 in a buffer produced by `describe-categories'.
2002 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2003 members before the level stack, so they would be saved and
2004 restored when copying iterator state. Fixes incorrect reordering
2005 around TABs covered by display properties.
2007 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2009 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2011 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2013 * eval.c (internal_condition_case, internal_condition_case_1)
2014 (internal_condition_case_2, internal_condition_case_n):
2015 Remove unnecessary aborts (Bug#9081).
2017 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2019 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2020 has no `load' handler, try opening the file locally. (Bug#9311)
2022 2011-08-16 Ken Brown <kbrown@cornell.edu>
2024 * gmalloc.c: Expand comment.
2026 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2028 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2029 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2031 2011-08-16 Ken Brown <kbrown@cornell.edu>
2033 Fix memory allocation problems in Cygwin build (Bug#9273).
2035 * unexcw.c ( __malloc_initialized): Declare external variable.
2036 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2038 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2040 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2042 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2044 [CYGWIN] (special_realloc): New function.
2045 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2046 requests to realloc storage in the static heap.
2048 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2050 * bidi.c (bidi_initialize): Remove unused local.
2052 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2055 * biditype.h: Remove file.
2056 * makefile.w32-in ($(BLD)/bidi.$(O)):
2057 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2059 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2061 * chartab.c: Improve commentary for the uniprop_table API.
2063 * bidi.c (bidi_paragraph_init): Support zero value of
2064 bidi_ignore_explicit_marks_for_paragraph_level.
2065 (bidi_initialize): Use uniprop_table instead of including
2066 biditype.h and bidimirror.h.
2068 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2069 coordinates of the iterator when restoring from ppos_it.
2072 2011-08-14 Kenichi Handa <handa@m17n.org>
2074 * process.c (create_process): Call setup_process_coding_systems
2075 after the pid of the process is set to -1 (Bug#8162).
2077 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2079 * xdisp.c (move_it_in_display_line_to): Don't invoke
2080 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2081 ppos_it. Fixes vertical cursor motion when line beginning is
2082 covered by an image. (Bug#9296)
2084 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2086 * nsterm.h (ns_run_ascript): Declare.
2087 (NSAPP_DATA2_RUNASSCRIPT): Define.
2089 * nsfns.m (as_script, as_result, as_status): New static variables.
2090 (ns_run_ascript): New function.
2091 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2092 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2093 the event loop. Get status from as_status (Bug#7276).
2095 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2096 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2097 the event loop (Bug#7276).
2099 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2101 * gnutls.c (QCgnutls_bootprop_priority)
2102 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2103 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2104 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2105 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2106 (QCgnutls_bootprop_verify_hostname_error)
2107 (QCgnutls_bootprop_callbacks_verify): Rename from
2108 Qgnutls_bootprop_..., all uses changed.
2110 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2113 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2115 * xfaces.c (Qframe_set_background_mode): Now static.
2116 * dispextern.h (Qframe_set_background_mode): Remove decl.
2118 * process.c (Fnetwork_interface_info): Declare local only if needed.
2120 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2122 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2123 (Fnetwork_interface_list): Allocate in increments of bytes instead
2124 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2125 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2127 (struct ifflag_def): notrailers is smart on OSX.
2128 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2129 Get hardware address with getifaddrs if available.
2131 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2133 * xdisp.c (iterate_out_of_display_property): xassert that
2134 IT->position is set to within IT->object's boundaries. Break from
2135 the loop as soon as EOB is reached; avoids infloops in redisplay
2136 when IT->position is set up wrongly due to some bug.
2137 Set IT->current to match the bidi iterator unconditionally.
2138 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2139 entry. Force push_it to save on the stack the current
2140 buffer/string position, to be restored by pop_it. Fix flags in
2141 the iterator structure wrt the object coming from a display
2142 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2143 properties. (Bug#9284)
2145 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2147 * fontset.c (fontset_get_font_group): Add proper type checks.
2150 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2152 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2153 and LC_VERSION_MIN_MACOSX.
2154 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2155 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2157 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2159 * xdisp.c (forward_to_next_line_start): Allow to use the
2160 no-display-properties-and-no-overlays under bidi display.
2161 Set disp_pos in the bidi iterator to avoid searches for display
2162 properties and overlays.
2164 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2166 * editfns.c (Fset_time_zone_rule): Document relationship with the
2169 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2170 the font entity extracted from the cache (Bug#8109).
2172 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2174 * composite.c (autocmp_chars): Don't reset point. That is done by
2175 restore_point_unwind (Bug#5984).
2177 2011-08-07 Juri Linkov <juri@jurta.org>
2179 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2180 to show the arg `TIME' instead of `TIMEVAL'.
2182 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2184 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2185 display property strides EOL and includes a newline, as in
2186 longlines-mode. (Bug#9254)
2187 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2188 word-wrap under bidirectional display. (Bug#9224)
2190 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2191 is non-zero, even if the data buffer is NULL. Fixes a crash in
2192 vertical-motion with longlines-mode. (Bug#9254)
2194 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2196 * bidi.c <bidi_cache_total_alloc>: Now static.
2197 (bidi_initialize): Initialize bidi_cache_total_alloc.
2199 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2202 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2203 amount allocated this far in `bidi_cache_total_alloc'.
2204 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2205 non-zero, only free the data buffer without restoring the cache
2206 contents. All callers changed.
2208 * dispextern.h (bidi_unshelve_cache): Update prototype.
2210 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2211 (move_it_in_display_line, move_it_to)
2212 (move_it_vertically_backward, move_it_by_lines): Replace the call
2213 to xfree to an equivalent call to bidi_unshelve_cache.
2214 (move_it_in_display_line_to): Fix logic of returning
2215 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2217 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2219 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2220 came from a string character with a `cursor' property. (Bug#9229)
2222 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2224 * Makefile.in (LIB_PTHREAD): New variable.
2225 (LIBES): Add LIB_PTHREAD (Bug#9216).
2227 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2228 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2230 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2232 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2234 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2236 * xterm.c (x_find_topmost_parent): New function.
2237 (x_set_frame_alpha): Find topmost parent window with
2238 x_find_topmost_parent and set the property there also (bug#9181).
2239 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2241 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2243 * callproc.c (Fcall_process): Avoid vfork clobbering
2244 the local vars buffer, coding_systems, current_dir.
2246 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2248 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2250 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2252 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2253 so that it is not optimized away.
2255 * xdisp.c (compute_display_string_pos): Remove unused local.
2257 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2259 Fix slow cursor motion and scrolling in large buffers with
2260 selective display, like Org Mode buffers. (Bug#9218)
2262 * dispextern.h (struct bidi_it): New member disp_prop_p.
2264 * xdisp.c: Remove one-slot cache of display string positions.
2265 (compute_display_string_pos): Accept an additional argument
2266 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2267 for a display string or property. If found, set DISP_PROP_P
2270 * bidi.c (bidi_fetch_char): Accept an additional argument
2271 DISP_PROP_P, and pass it to compute_display_string_pos.
2272 Only handle text covered by a display string if DISP_PROP_P is returned
2273 non-zero. All callers of bidi_fetch_char changed.
2275 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2277 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2279 2010-12-03 Don March <don@ohspite.net>
2281 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2282 last character M-[char] is translated to ESC [char] (bug#7541).
2284 2011-08-02 Kenichi Handa <handa@m17n.org>
2286 * lisp.h (uniprop_table): Extern it.
2288 * chartab.c (uniprop_table): Make it non-static.
2290 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2292 * xdisp.c (forward_to_next_line_start): Accept additional argument
2293 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2295 (reseat_at_next_visible_line_start): Use the bidi iterator state
2296 returned by forward_to_next_line_start to restore the state of
2297 it->bidi_it after backing up to previous newline. (Bug#9212)
2299 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2301 * regex.c (re_comp): Protoize.
2302 (re_exec): Fix return type.
2303 (regexec): Fix type of `ret'. (Bug#9203)
2305 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2307 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2308 This is needed if max-image-size is a floating-point number.
2310 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2312 * print.c (print_object): Print empty symbol as ##.
2314 * lread.c (read1): Read ## as empty symbol.
2316 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2318 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2319 setting frame foreground color (Bug#9175).
2320 (x_set_background_color): Likewise.
2322 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2323 contents (Bug#9176).
2324 (EmacsTooltip -init): Remove bezels and add shadows to
2327 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2328 or scroll bar (Bug#8470).
2330 * nsfont.m (nsfont_open): Remove assignment to voffset and
2331 unnecessary vars hshink, expand, hd, full_height, min_height.
2332 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2334 * nsterm.h (nsfont_info): Remove voffset field.
2336 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2338 Implement strike-through and overline on NextStep (Bug#8863).
2340 * nsfont.m (nsfont_open): Use underline position provided by font,
2341 instead of hard-coded value of 2.
2342 (nsfont_draw): Call ns_draw_text_decoration instead.
2344 * nsterm.h: Add declaration for ns_draw_text_decoration.
2346 * nsterm.m (ns_draw_text_decoration): New function for drawing
2347 underline, overline, and strike-through.
2348 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2349 ns_draw_text_decoration. Change treatment of cursor drawing to
2350 accommodate underlining, etc.
2352 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2354 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2357 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2359 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2360 Without this fix, if a signal arrives just after memory fills up,
2361 'malloc' might be invoked reentrantly.
2363 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2364 In other words, assume that every image size is allowed, on non-X
2365 hosts. This assumption is probably wrong, but it lets Emacs compile.
2367 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2369 * regex.c (re_iswctype): Convert return values to boolean.
2371 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2373 * xdisp.c (compute_display_string_pos): Don't use cached display
2374 string position if the buffer had its restriction changed.
2377 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2379 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2381 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2383 Integer signedness and overflow and related fixes. (Bug#9079)
2385 * bidi.c: Integer size and overflow fixes.
2386 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2387 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2388 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2389 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2390 (bidi_find_other_level_edge):
2391 Use ptrdiff_t instead of EMACS_INT where either will do.
2392 This works better on 32-bit hosts configured --with-wide-int.
2393 (bidi_cache_ensure_space): Check for size-calculation overflow.
2394 Use % rather than repeated addition, for better worst-case speed.
2395 Don't set bidi_cache_size until after xrealloc returns, because it
2397 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2398 (bidi_cache_ensure_space): Also check that the bidi cache size
2399 does not exceed that of the largest Lisp string or buffer. See Eli
2400 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2402 * alloc.c (__malloc_size_t): Remove.
2403 All uses replaced by size_t. See Andreas Schwab's note
2404 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2406 * image.c: Improve checking for integer overflow.
2407 (check_image_size): Assume that f is nonnull, since
2408 it is always nonnull in practice. This is one less thing to
2409 worry about when checking for integer overflow later.
2410 (x_check_image_size): New function, which checks for integer
2411 overflow issues inside X.
2412 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2413 This removes the need for a memory_full check.
2414 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2415 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2416 (xbm_read_bitmap_data): Change locals back to 'int', since
2417 their values must fit in 'int'.
2418 (xpm_load_image, png_load, tiff_load):
2419 Invoke x_create_x_image_and_pixmap earlier,
2420 to avoid much needless work if the image is too large.
2421 (tiff_load): Treat overly large images as if
2422 x_create_x_image_and_pixmap failed, not as malloc failures.
2423 (gs_load): Use x_check_image_size.
2425 * gtkutil.c: Omit integer casts.
2426 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2427 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2429 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2431 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2432 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2433 would wrongly return t on a 64-bit host.
2435 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2436 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2437 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2438 and therefore cause GCC to emit a bogus diagnostic in some cases.
2440 * image.c: Integer signedness and overflow and related fixes.
2441 This is not an exhaustive set of fixes, but it's time to
2442 record what I've got.
2443 (lookup_pixel_color, check_image_size): Remove redundant decls.
2444 (check_image_size): Don't assume that arbitrary EMACS_INT values
2445 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2446 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2447 (tiff_load, imagemagick_load_image):
2448 Check for overflow in size calculations.
2449 (x_create_x_image_and_pixmap): Remove unnecessary test for
2450 xmalloc returning NULL; that can't happen.
2451 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2452 (xpm_color_bucket): Use better integer hashing function.
2453 (xpm_cache_color): Don't possibly over-allocate memory.
2454 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2455 (gif_memory_source):
2456 Use ptrdiff_t, not int or size_t, to record sizes.
2457 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2458 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2459 either works, as we prefer signed integers.
2460 (tiff_read_from_memory, tiff_write_from_memory):
2461 Return tsize_t, not size_t, since that's what the TIFF API wants.
2462 (tiff_read_from_memory): Don't fail simply because the read would
2463 go past EOF; instead, return a short read.
2464 (tiff_load): Omit no-longer-needed casts.
2465 (Fimagemagick_types): Don't assume size fits into 'int'.
2467 Improve hashing quality when configured --with-wide-int.
2468 * fns.c (hash_string): New function, taken from sxhash_string.
2469 Do not discard information about ASCII character case; this
2470 discarding is no longer needed.
2471 (sxhash-string): Use it. Change sig to match it. Caller changed.
2472 * lisp.h: Declare it.
2473 * lread.c (hash_string): Remove, since we now use fns.c's version.
2474 The fns.c version returns a wider integer if --with-wide-int is
2475 specified, so this should help the quality of the hashing a bit.
2477 * emacs.c: Integer overflow minor fix.
2478 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2479 Define only if GNU_LINUX.
2480 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2482 * dispnew.c: Integer signedness and overflow fixes.
2483 Remove unnecessary forward decls, that were a maintenance hassle.
2484 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2486 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2487 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2488 (prepare_desired_row, line_draw_cost):
2489 Use int, not unsigned, where either works.
2490 (save_current_matrix, restore_current_matrix):
2491 Use ptrdiff_t, not size_t, where either works.
2492 (init_display): Check for overflow more accurately, and without
2493 relying on undefined behavior.
2495 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2496 Remove, replacing with the new symbols in lisp.h. All uses changed.
2497 * fileio.c (make_temp_name):
2498 * filelock.c (lock_file_1, lock_file):
2499 * xdisp.c (message_dolog):
2500 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2501 Use pMd etc. instead.
2502 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2503 replacing the pWIDE etc. symbols removed from editfns.c.
2505 * keyboard.h (num_input_events): Now uintmax_t.
2506 This is (very slightly) less likely to mess up due to wraparound.
2509 * buffer.c: Integer signedness fixes.
2510 (alloc_buffer_text, enlarge_buffer_text):
2511 Use ptrdiff_t rather than size_t when either will do, as we prefer
2514 * alloc.c: Integer signedness and overflow fixes.
2515 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2516 (__malloc_size_t): Default to size_t, not to int.
2517 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2518 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2519 Prefer ptrdiff_t to size_t when either would do, as we prefer
2521 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2522 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2523 Now const. Initialize with values that are in range even if char
2525 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2526 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2527 These functions do the right thing with sizes > 2**32.
2528 (check_depth): Now ptrdiff_t, not int.
2529 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2530 Adjust to new way of storing sizes. Check for size overflow bugs
2532 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2533 slightly wrong anyway, as it missed one instance of
2534 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2535 (refill_memory_reserve): Omit needless cast to size_t.
2536 (mark_object_loop_halt): Mark as externally visible.
2538 * xselect.c: Integer signedness and overflow fixes.
2539 (Fx_register_dnd_atom, x_handle_dnd_message):
2540 Use ptrdiff_t, not size_t, since we prefer signed.
2541 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2542 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2543 x_dnd_atoms_size and x_dnd_atoms_length.
2545 * doprnt.c: Prefer signed to unsigned when either works.
2547 * doprnt.c (doprnt):
2549 * xdisp.c (vmessage):
2550 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2551 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2552 prefer signed arithmetic to avoid comparison confusion.
2553 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2554 but is a bit tricky.
2556 Assume freestanding C89 headers, string.h, stdlib.h.
2557 * data.c, doprnt.c, floatfns.c, print.c:
2558 Include float.h unconditionally.
2559 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2560 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2561 * regex.c: Likewise for stddef.h, string.h.
2562 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2563 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2564 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2565 (STDC_HEADERS): Remove obsolete defines.
2566 * sysdep.c: Include limits.h unconditionally.
2568 Assume support for memcmp, memcpy, memmove, memset.
2569 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2570 * regex.c (memcmp, memcpy):
2571 Remove; we assume C89 now.
2573 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2574 (__malloc_safe_bcopy): Remove; no longer needed.
2576 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
2577 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2578 well either way, and we prefer signed to unsigned.
2580 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2582 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2583 closes the connection while we're reading (bug#9182).
2585 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
2587 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2588 are specified (Bug#9168).
2590 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2592 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2593 Found by GCC static checking and --with-wide-int on a 32-bit host.
2595 2011-07-25 Eli Zaretskii <eliz@gnu.org>
2597 * xdisp.c (compute_display_string_pos): Fix logic of caching
2598 previous display string position. Initialize cached_prev_pos to
2599 -1. Fixes slow-down at the beginning of a buffer.
2601 2011-07-24 Eli Zaretskii <eliz@gnu.org>
2603 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2604 for attrs[LFACE_FONTSET_INDEX].
2606 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2608 * xml.c (parse_region): Remove unused local
2609 that was recently introduced.
2611 2011-07-23 Eli Zaretskii <eliz@gnu.org>
2613 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2614 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2616 * xdisp.c (move_it_in_display_line_to): Record the best matching
2617 position for TO_CHARPOS while scanning the line, and restore it on
2618 exit if none of the characters scanned was an exact match.
2619 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
2620 when exact match is impossible due to invisible text, and the
2621 lines are truncated.
2623 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2625 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2628 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2630 Fix a significant slow-down of cursor motion with C-n, C-p,
2631 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2632 auto-repeat under bidi redisplay in fontified buffers.
2633 * xdisp.c (compute_stop_pos_backwards): New function.
2634 (next_element_from_buffer): Call compute_stop_pos_backwards to
2635 find a suitable prev_stop when we find ourselves before
2637 (reseat): Don't look for prev_stop, as that could mean a very long
2639 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2640 <cached_disp_overlay_modiff>: Cache for last found display string
2642 (compute_display_string_pos): Return the cached position if asked
2643 about the same buffer in the same area of character positions, and
2644 the buffer wasn't changed since the time the display string
2645 position was cached.
2647 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2649 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2650 is an integer, which is important for empty lines. (Bug#9149)
2652 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
2654 * frame.c (Fmodify_frame_parameters): In tty case, update the
2655 default face if necessary (Bug#4238).
2657 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
2659 * editfns.c (Fstring_to_char): No need to explain what a character
2660 is in the docstring (Bug#6576).
2662 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2664 * xml.c (parse_region): Make sure we always return a tree.
2666 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2668 * xml.c (parse_region): If a document contains only comments,
2671 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2673 * xml.c (make_dom): Return comments, too.
2675 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2678 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2679 and the surrounding thread.
2680 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2681 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2682 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2684 * s/openbsd.h (BROKEN_SIGIO): Define.
2685 * unexelf.c (unexec) [__OpenBSD__]:
2686 Don't update the .mdebug section of the Alpha COFF symbol table.
2688 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2690 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2693 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2695 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2696 This fixes some race conditions on the permissions of any newly
2699 * alloc.c (valid_pointer_p): Use pipe, not open.
2700 This fixes some permissions issues when debugging.
2702 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2703 If fchown fails to set both uid and gid, try to set just gid,
2704 as that is sometimes allowed. Adjust the file's mode to eliminate
2705 setuid or setgid bits that are inappropriate if fchown fails.
2707 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2709 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2710 to compare Lisp_Objects.
2711 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2712 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2713 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2715 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2717 * lread.c (read_integer): Unread even EOF character.
2718 (read1): Likewise. Properly record start position of symbol.
2720 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2721 symbol character follows.
2723 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2725 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2726 This works around a problem with the previous change to Fcopy_file.
2727 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2728 and without this change, GCC might complain about discarding
2729 fchown's return value.
2731 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
2733 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2735 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2737 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2739 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2741 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2742 it's used from the C level.
2744 * process.c: Use the same condition for POLL_FOR_INPUT in both
2745 keyboard.c and process.c (bug#1858).
2747 2011-07-09 Lawrence Mitchell <wence@gmx.li>
2749 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2750 (Fgnutls_boot): Use it.
2752 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2754 * doc.c (Fsubstitute_command_keys): Revert last change.
2756 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2758 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2759 quotes the next character, and doesn't affect other longer
2760 sequences (bug#8935).
2762 * lread.c (syms_of_lread): Clarify that is isn't only
2763 `eval-buffer' and `eval-defun' that's affected by
2764 `lexical-binding' (bug#8460).
2766 2011-07-15 Eli Zaretskii <eliz@gnu.org>
2768 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2769 bidi redisplay when a line includes both an image and is truncated.
2771 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2773 Fix minor problems found by static checking.
2774 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2775 (elsz): Now a signed constant, not a size_t var. We prefer signed
2776 types to unsigned, to avoid integer comparison confusion. Without
2777 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2778 "cannot optimize loop, the loop counter may overflow", a symptom
2780 * indent.c (Fvertical_motion): Mark locals as initialized.
2781 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2783 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2785 * search.c (Fre_search_backward): Mention `case-fold-search' in
2786 all the re_search_* functions (bug#8138).
2788 * keyboard.c (Fopen_dribble_file): Document when the file is
2791 2011-07-14 Eli Zaretskii <eliz@gnu.org>
2793 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2796 Support bidi reordering of display and overlay strings.
2797 * xdisp.c (compute_display_string_pos)
2798 (compute_display_string_end): Accept additional argument STRING.
2799 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2800 (reseat_to_string): Initialize bidi_it->string.s and
2801 bidi_it->string.schars.
2802 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
2803 NULL (avoids a crash in bidi_paragraph_init).
2804 Initialize itb.string.lstring.
2805 (init_iterator): Call bidi_init_it only of a valid
2806 buffer position was specified. Initialize paragraph_embedding to
2808 (reseat_to_string): Initialize the bidi iterator.
2809 (display_string): If we need to ignore text properties of
2810 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2811 original value of -1 will not work with bidi.)
2812 (compute_display_string_pos): First arg is now struct
2813 `text_pos *'; all callers changed. Support display properties on
2815 (compute_display_string_end): Support display properties on Lisp
2817 (init_iterator, reseat_1, reseat_to_string): Initialize the
2818 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2819 when iterating on a string not from display properties).
2820 (compute_display_string_pos, compute_display_string_end):
2821 Fix calculation of the object to scan. Fixes an error when using
2823 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2824 base_level_stop; instead, set base_level_stop to BEGV.
2825 Fixes crashes in vertical-motion.
2826 (next_element_from_buffer): Improve commentary for when
2827 the iterator is before prev_stop.
2828 (init_iterator): Initialize bidi_p from the default value of
2829 bidi-display-reordering, not from buffer-local value. Use the
2830 buffer-local value only if initializing for buffer iteration.
2831 (handle_invisible_prop): Support invisible properties on strings
2832 that are being bidi-reordered.
2833 (set_iterator_to_next): Support bidi reordering of C strings and
2835 (next_element_from_string): Support bidi reordering of Lisp
2837 (handle_stop_backwards): Support Lisp strings as well.
2838 (display_string): Support display of R2L glyph rows.
2839 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2840 (init_iterator): Don't initialize it->bidi_p for strings
2842 (reseat_to_string): Initialize it->bidi_p for strings here.
2843 (next_element_from_string, next_element_from_c_string)
2844 (next_element_from_buffer): Add xassert's for correspondence
2845 between IT's object being iterated and it->bidi_it.string
2847 (face_before_or_after_it_pos): Support bidi iteration.
2848 (next_element_from_c_string): Handle the case of the first string
2849 character that is not the first one in the visual order.
2850 (get_visually_first_element): New function, refactored from common
2851 parts of next_element_from_buffer, next_element_from_string, and
2852 next_element_from_c_string.
2853 (tool_bar_lines_needed, redisplay_tool_bar)
2854 (display_menu_bar): Force left-to-right direction. Add a FIXME
2855 comment for making that be controlled by a user option.
2856 (push_it, pop_it): Save and restore the state of the
2857 bidi iterator. Save and restore the bidi_p flag.
2858 (pop_it): Iterate out of display property for string iteration as
2860 (iterate_out_of_display_property): Support iteration over strings.
2861 (handle_single_display_spec): Set up it->bidi_it for iteration
2862 over a display string, and call bidi_init_it.
2863 (handle_single_display_spec, next_overlay_string)
2864 (get_overlay_strings_1, push_display_prop): Set up the bidi
2865 iterator for displaying display or overlay strings.
2866 (forward_to_next_line_start): Don't use the shortcut if
2868 (back_to_previous_visible_line_start): If handle_display_prop
2869 pushed the iterator stack, restore the internal state of the bidi
2870 iterator by calling bidi_pop_it same number of times.
2871 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2872 and we are bidi-iterating, don't decrement the iterator position;
2873 instead, set the first_elt flag in the bidi iterator, to produce
2875 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2876 (push_display_prop): xassert that we are iterating a buffer.
2877 (push_it, pop_it): Save and restore paragraph_embedding member.
2878 (handle_single_display_spec, next_overlay_string)
2879 (get_overlay_strings_1, reseat_1, reseat_to_string)
2880 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2881 correctly. Don't assume unibyte strings are not bidi-reordered.
2882 (compute_display_string_pos)
2883 (compute_display_string_end): Fix handling the case of C string.
2884 (push_it, pop_it): Save and restore from_disp_prop_p.
2885 (handle_single_display_spec, push_display_prop): Set the
2886 from_disp_prop_p flag.
2887 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2888 (pop_it): Call iterate_out_of_display_property only if we are
2889 popping after iteration over a string that came from a display
2890 property. Fix a typo in popping stretch info. Add an assertion
2891 for verifying that the iterator position is in sync with the bidi
2893 (handle_single_display_spec, get_overlay_strings_1)
2894 (push_display_prop): Fix initialization of paragraph direction for
2895 string when that of the parent object is not yet determined.
2896 (reseat_1): Call bidi_init_it to resync the bidi
2897 iterator with IT's position. (Bug#7616)
2898 (find_row_edges): If ROW->start.pos gives position
2899 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2900 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2901 Reset the from_disp_prop_p flag.
2902 (SAVE_IT, RESTORE_IT): New macros.
2903 (pos_visible_p, face_before_or_after_it_pos)
2904 (back_to_previous_visible_line_start)
2905 (move_it_in_display_line_to, move_it_in_display_line)
2906 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2907 (try_scrolling, redisplay_window, display_line): Use them when
2908 saving a temporary copy of the iterator and restoring it back.
2909 (back_to_previous_visible_line_start, reseat_1)
2910 (init_iterator): Empty the bidi cache "stack".
2911 (move_it_in_display_line_to): If iterator ended up at
2912 EOL, but we never saw any buffer positions smaller than
2913 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2914 motion in bidi-reordered lines.
2915 (move_it_in_display_line_to): Record prev_method and prev_pos
2916 immediately before the call to set_iterator_to_next. Fixes cursor
2917 motion in bidi-reordered lines with stretch glyphs and strings
2918 displayed in margins. (Bug#8133) (Bug#8867)
2919 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2921 (pos_visible_p): Support positions in bidi-reordered lines.
2922 Save and restore bidi cache.
2924 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2925 (bidi_paragraph_info): Delete unused struct.
2926 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2927 (bidi_cache_start): New variable.
2928 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2930 (bidi_cache_fetch_state, bidi_cache_search)
2931 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2932 (bidi_cache_find, bidi_peek_at_next_level)
2933 (bidi_level_of_next_char, bidi_find_other_level_edge)
2934 (bidi_move_to_visually_next): Compare cache index with
2935 bidi_cache_start rather than with zero.
2936 (bidi_fetch_char): Accept new argument STRING; all callers
2937 changed. Support iteration over a string. Support strings with
2938 display properties. Support unibyte strings. Fix the type of
2939 `len' according to what STRING_CHAR_AND_LENGTH expects.
2940 (bidi_paragraph_init, bidi_resolve_explicit_1)
2941 (bidi_resolve_explicit, bidi_resolve_weak)
2942 (bidi_level_of_next_char, bidi_move_to_visually_next):
2943 Support iteration over a string.
2944 (bidi_set_sor_type, bidi_resolve_explicit_1)
2945 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2946 can now be zero (for strings); special values 0 and -1 were
2947 changed to -1 and -2, respectively.
2948 (bidi_char_at_pos): New function.
2949 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2950 Call it instead of FETCH_MULTIBYTE_CHAR.
2951 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2952 initialized to valid values.
2953 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2955 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2956 the test for valid cached positions. Fix the logic for looking up
2957 the sentinel state in the cache. GCPRO the Lisp string we are
2959 (bidi_push_it, bidi_pop_it): New functions.
2960 (bidi_initialize): Initialize the bidi cache start stack pointer.
2961 (bidi_cache_ensure_space): New function, refactored from part of
2962 bidi_cache_iterator_state. Don't assume the required size is just
2963 one BIDI_CACHE_CHUNK away.
2964 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2965 (bidi_count_bytes, bidi_char_at_pos): New functions.
2966 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2967 always valid if bidi_cache_idx is valid.
2968 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2969 is valid if it's going to be used.
2970 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2971 (bidi_cache_fetch_state, bidi_cache_search)
2972 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2973 (bidi_cache_iterator_state, bidi_cache_find)
2974 (bidi_find_other_level_edge, bidi_cache_start_stack):
2975 All variables related to cache indices are now EMACS_INT.
2977 * dispextern.h (struct bidi_string_data): New structure.
2978 (struct bidi_it): New member `string'. Make flag members be 1-bit
2979 fields, and put them last in the struct.
2980 (compute_display_string_pos, compute_display_string_end):
2982 (bidi_push_it, bidi_pop_it): Add prototypes.
2983 (struct iterator_stack_entry): New members bidi_p,
2984 paragraph_embedding, and from_disp_prop_p.
2985 (struct it): Member bidi_p is now a bit field 1 bit wide.
2986 (bidi_shelve_cache, bidi_unshelve_cache):
2989 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2990 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2991 and vector-like objects.
2993 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2994 cache around display iteration.
2996 * window.c (Fwindow_end, window_scroll_pixel_based)
2997 (displayed_window_lines, Frecenter): Save and restore the bidi
2998 cache around display iteration.
3000 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3002 * editfns.c (Fdelete_region): Clarify the use of the named
3003 parameters (bug#6788).
3005 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3007 * indent.c (Fvertical_motion): Set and restore w->pointm when
3008 saving and restoring the window's buffer (Bug#9006).
3010 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3012 * editfns.c (Fstring_to_char): Clarify just what is returned
3013 (bug#6576). Text by Eli Zaretskii.
3015 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3017 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3019 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3021 * buffer.c (mmap_find): Fix a typo.
3023 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3025 Fix execution of x selection hooks.
3026 * xselect.c (Qx_lost_selection_functions)
3027 (Qx_sent_selection_functions): New vars.
3028 (syms_of_xselect): DEFSYM them.
3029 (x_handle_selection_request): Pass Qx_sent_selection_functions
3030 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3031 (x_handle_selection_clear,x_clear_frame_selections):
3032 Pass Qx_lost_selection_functions rather than
3033 Vx_lost_selection_functions to Frun_hook_with_args.
3035 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3037 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3038 The old code sometimes used this field without initializing it.
3040 * alloc.c (gc_sweep): Don't read past end of array.
3041 In theory, the old code could also have corrupted Emacs internals,
3042 though it'd be very unlikely.
3044 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3046 * character.c (Fcharacterp): Don't advertise optional ignored
3047 argument. (Bug#4026)
3049 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3051 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3054 * window.c (Fset_window_start): Doc fix (bug#4199).
3055 (Fset_window_hscroll): Ditto.
3057 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3059 Fix minor new problems caught by GCC 4.6.1.
3060 * term.c (init_tty): Remove unused local.
3061 * xsettings.c (store_monospaced_changed): Define this function only
3062 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3065 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3067 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3069 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3071 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3072 are the mini-buffer and the echo area (bug#3320).
3074 * term.c (init_tty): Remove support for supdup, c10 and perq
3075 terminals, which are no longer supported (bug#1482).
3077 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3079 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3081 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3083 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3084 for non-popups (Bug#3642).
3086 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3088 * alloc.c (reset_malloc_hooks): Protoize.
3089 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3090 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3091 * cm.c (losecursor): Likewise.
3092 * data.c (fmod): Likewise.
3093 * dispnew.c (swap_glyphs_in_rows): Likewise.
3094 * emacs.c (memory_warning_signal): Likewise.
3095 * floatfns.c (float_error): Likewise.
3096 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3097 (otf_open, font_otf_capability, generate_otf_features)
3098 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3100 * image.c (pbm_read_file): Likewise.
3101 * indent.c (string_display_width): Likewise.
3102 * intervals.c (check_for_interval, search_for_interval)
3103 (inc_interval_count, count_intervals, root_interval)
3104 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3105 * lread.c (defalias): Likewise.
3106 * ralloc.c (r_alloc_check): Likewise.
3107 * regex.c (set_image_of_range_1, set_image_of_range)
3108 (regex_grow_registers): Likewise.
3109 * sysdep.c (strerror): Likewise.
3110 * termcap.c (valid_filename_p, tprint, main): Likewise.
3111 * tparam.c (main): Likewise.
3112 * unexhp9k800.c (run_time_remap, save_data_space)
3113 (update_file_ptrs, read_header, write_header, calculate_checksum)
3114 (copy_file, copy_rest, display_header): Likewise.
3115 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3117 * xdisp.c (check_it): Likewise.
3118 * xfaces.c (register_color, unregister_color, unregister_colors):
3120 * xfns.c (print_fontset_result): Likewise.
3121 * xrdb.c (member, fatal, main): Likewise.
3123 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3125 Fix minor problems found by static checking (Bug#9031).
3126 * chartab.c (char_table_set_range, map_sub_char_table):
3127 Remove unused locals.
3128 (uniprop_table): Now static.
3129 * composite.c (_work_char): Remove unused static var.
3131 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3133 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3135 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3137 * gtkutil.c (qttip_cb): Remove code without function.
3139 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3141 * w32.c (pthread_sigmask): New stub.
3143 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3145 Use pthread_sigmask, not sigprocmask (Bug#9010).
3146 sigprocmask is portable only for single-threaded applications, and
3147 Emacs can be multi-threaded when it uses GTK.
3148 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3150 * callproc.c (Fcall_process):
3151 * process.c (create_process):
3152 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3153 Use pthread_sigmask, not sigprocmask.
3155 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3157 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3158 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3161 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3163 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3164 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3165 (xg_hide_tooltip): Fix comment.
3167 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3168 in registerServicesMenuSendTypes.
3169 (validRequestorForSendType): Don't check ns_return_types.
3171 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3174 2011-07-08 Jason Rumney <jasonr@gnu.org>
3176 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3177 SH_SHOW for hidden windows (Bug#5482).
3179 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3180 frame struct members of non-existent frames (Bug#6284).
3182 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3184 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3185 variable firstTime not needed on OSX >= 10.6.
3186 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3187 >= 10.5. Use setKnobProportion, setDoubleValue.
3189 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3190 (MAC_OS_X_VERSION_10_5): Define if not defined.
3191 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3192 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3193 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3195 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3196 cString and lossyCString on OSX >= 10.4
3198 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3199 sizeToFit on OSX >= 10.2.
3201 * nsimage.m (allocInitFromFile): Don't use deprecated method
3202 bestRepresentationForDevice on OSX >= 10.6.
3204 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3207 * emacs.c: Declare unexec_init_emacs_zone.
3209 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3211 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3213 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3214 on svcsMenu (Bug#8842).
3216 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3218 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3220 * nsterm.m (QUTF8_STRING): Declare.
3221 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3222 (validRequestorForSendType): Return type is (id).
3223 Change indexOfObjectIdenticalTo to indexOfObject.
3224 Check if we have local selection before returning self (Bug#8842).
3225 (writeSelectionToPasteboard): Put local selection into paste board
3226 if we have a local selection (Bug#8842).
3227 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3229 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3230 (ns_get_local_selection): Declare.
3232 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3234 * keymap.c (describe_map_tree): Don't insert a double newline at
3235 the end of the buffer (bug#1169) and return whether we inserted
3238 * callint.c (Fcall_interactively): Change "reading args" to
3239 "providing args" to try to clarify what it does (bug#1010).
3241 2011-07-07 Kenichi Handa <handa@m17n.org>
3243 * composite.c (composition_compute_stop_pos): Ignore a static
3244 composition starting before CHARPOS (Bug#8915).
3246 * xdisp.c (handle_composition_prop): Likewise.
3248 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3250 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3253 2011-07-07 Kenichi Handa <handa@m17n.org>
3255 * character.h (unicode_category_t): New enum type.
3257 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3258 (Qchar_code_property_table): New variable.
3259 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3260 (UNIPROP_COMPRESSED_FORM_P): New macros.
3261 (char_table_ascii): Uncompress the compressed values.
3262 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3263 Uncompress the compressed values.
3264 (sub_char_table_ref_and_range): Likewise.
3265 (char_table_ref_and_range): Uncompress the compressed values.
3266 (sub_char_table_set): New arg is_uniprop. Callers changed.
3267 Uncompress the compressed values.
3268 (sub_char_table_set_range): Args changed. Callers changed.
3269 (char_table_set_range): Adjuted for the above change.
3270 (map_sub_char_table): Delete args default_val and parent. Add arg
3271 top. Give decoded values to a Lisp function.
3272 (map_char_table): Adjust for the above change. Give decoded
3273 values to a Lisp function. Gcpro more variables.
3274 (uniprop_table_uncompress)
3275 (uniprop_decode_value_run_length): New functions.
3276 (uniprop_decoder, uniprop_decoder_count): New variables.
3277 (uniprop_get_decoder, uniprop_encode_value_character)
3278 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3280 (uniprop_encoder, uniprop_encoder_count): New variables.
3281 (uniprop_get_encoder, uniprop_table)
3282 (Funicode_property_table_internal, Fget_unicode_property_internal)
3283 (Fput_unicode_property_internal): New functions.
3284 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3285 Sunicode_property_table_internal, Sget_unicode_property_internal,
3286 and Sput_unicode_property_internal. Defvar_lisp
3287 char-code-property-alist.
3289 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3290 Vunicode_category_table.
3292 * font.c (font_range): Adjust for the change of
3293 Vunicode_category_table.
3295 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3297 * m/iris4d.h: Remove file, move contents ...
3298 * s/irix6-5.h: ... here.
3300 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3302 Remove unportable assumption about struct layout (Bug#8884).
3303 * alloc.c (mark_buffer):
3304 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3305 (clone_per_buffer_values): Don't assume that
3306 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3307 This isn't true in general, and it's particularly not true
3308 if Emacs is configured with --with-wide-int.
3309 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3310 New macros, used in the buffer.c change.
3312 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3314 * xsettings.c: Use both GConf and GSettings if both are available.
3315 (store_config_changed_event): Add comment.
3316 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3317 (store_tool_bar_style_changed): New functions.
3318 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3319 (struct xsettings): Move font inside HAVE_XFT.
3320 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3321 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3322 Move inside HAVE_XFT.
3323 (something_changed_gsettingsCB): Rename from something_changedCB.
3324 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3326 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3327 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3328 (something_changed_gconfCB): Rename from something_changedCB.
3329 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3330 (parse_settings): Move check for font inside HAVE_XFT.
3331 (read_settings, apply_xft_settings): Add comment.
3332 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3333 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3334 call store_font_name_changed.
3335 (xft_settings_event): Add comment.
3336 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3337 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3338 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3339 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3340 (xsettings_initialize): Call init_gsettings last.
3341 (xsettings_get_system_font, xsettings_get_system_normal_font):
3344 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3346 Random fixes. E.g., (random) never returned negative values.
3347 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3348 subseconds part to the entropy, as that's a bit more random.
3349 Prefer signed to unsigned, since the signedness doesn't matter and
3350 in general we prefer signed. When given a limit, use a
3351 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3352 latter isn't right if USE_2_TAGS_FOR_INTS.
3353 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3354 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3356 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3358 * textprop.c (text_property_stickiness):
3359 Obey Vtext_property_default_nonsticky.
3360 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3361 * w32fns.c (syms_of_w32fns):
3362 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3364 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3366 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3367 This is more efficient than Ffile_directory_p and avoids a minor race.
3369 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3371 * buffer.c (Foverlay_put): Say what the return value is
3374 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3375 is a directory before asking whether to use the file name
3377 (barf_or_query_if_file_exists): Make the "File is a directory"
3378 error be more correct.
3380 * fns.c (Frequire): Remove the mention of the .gz files, since
3381 that's installation-specific, but keep the mention of
3382 `get-load-suffixes'.
3384 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3386 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3387 Report string overflow if the output is too long.
3389 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3391 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3392 (syms_of_gnutls): Remove duplicate DEFSYM for
3393 Qgnutls_bootprop_verify_hostname_error, an error for
3394 Qgnutls_bootprop_verify_error (which is no longer used).
3396 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3397 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3398 Also (re)move comments that are misplaced or no longer relevant.
3400 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3402 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3404 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3406 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3407 and background color parameters if they have been changed.
3409 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3411 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3413 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3415 * xsettings.c (SYSTEM_FONT): Define only when used.
3416 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3418 * keymap.c (access_keymap_1): Now static.
3420 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3422 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3423 leave any prefix arg for the up event (Bug#1586).
3425 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3427 * lread.c (syms_of_lread): Mention single symbols defined by
3428 `defvar' or `defconst' (bug#7154).
3430 * fns.c (Frequire): Mention .el.gz files (bug#7314).
3431 (Frequire): Mention get-load-suffixes.
3433 2011-07-02 Martin Rudalics <rudalics@gmx.at>
3435 * window.h (window): Remove clone_number slot.
3436 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3438 (make_parent_window, make_window, saved_window)
3439 (Fset_window_configuration, save_window_save): Don't deal with
3441 * buffer.c (Qclone_number): Remove declaration.
3442 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3444 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3446 Add multiple inheritance to keymaps.
3447 * keymap.c (Fmake_composed_keymap): New function.
3448 (Fset_keymap_parent): Simplify.
3449 (fix_submap_inheritance): Remove.
3450 (access_keymap_1): New function extracted from access_keymap to handle
3451 embedded parents and handle lists of maps.
3452 (access_keymap): Use it.
3453 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3454 (Fcopy_keymap): Handle embedded parents.
3455 (Fcommand_remapping, define_as_prefix): Simplify.
3456 (Fkey_binding): Simplify.
3457 (syms_of_keymap): Move minibuffer-local-completion-map,
3458 minibuffer-local-filename-completion-map,
3459 minibuffer-local-must-match-map, and
3460 minibuffer-local-filename-must-match-map to Elisp.
3461 (syms_of_keymap): Defsubr make-composed-keymap.
3462 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3463 (parse_menu_item): Trivial simplification.
3465 2011-07-01 Glenn Morris <rgm@gnu.org>
3467 * Makefile.in (SETTINGS_LIBS): Fix typo.
3469 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3471 * coding.c (Fencode_coding_string): Record the last coding system
3472 used, as the function doc string says (bug#8738).
3474 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3476 * xsettings.c (store_monospaced_changed): Take new font as arg and
3477 check for change against current_mono_font.
3478 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3479 (emacs_settings_constructor, emacs_settings_get_property)
3480 (emacs_settings_set_property, emacs_settings_class_init)
3481 (emacs_settings_init, gsettings_obj): Remove.
3482 (something_changedCB): New function for HAVE_GSETTINGS.
3483 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3484 with value as argument.
3485 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3486 g_settings_new (Bug#8967). Do not create gsettings_obj.
3487 Remove calls to g_settings_bind. Connect something_changedCB to
3490 * xgselect.c: Add defined (HAVE_GSETTINGS).
3491 (xgselect_initialize): Ditto.
3493 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3494 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3497 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3499 * eval.c (struct backtrace): Simplify and port the data structure.
3500 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3501 signed bit field, as this assumption is not portable and it makes
3502 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3503 "char debug_on_exit : 1" as this is not portable either; instead,
3504 use the portable "unsigned int debug_on_exit : 1". Remove unused
3505 member evalargs. Remove obsolete comments about cc bombing out.
3507 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3509 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
3510 Let HAVE_GSETTINGS override HAVE_GCONF.
3511 (store_monospaced_changed): New function.
3512 (EMACS_SETTINGS): A new type derived from GObject to handle
3513 GSettings notifications.
3514 (emacs_settings_constructor, emacs_settings_get_property)
3515 (emacs_settings_set_property, emacs_settings_class_init):
3517 (gsettings_client, gsettings_obj): New variables.
3518 (GSETTINGS_SCHEMA): New define.
3519 (something_changedCB): Call store_monospaced_changed.
3520 (init_gsettings): New function.
3521 (xsettings_initialize): Call init_gsettings.
3522 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3525 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
3528 2011-06-29 Martin Rudalics <rudalics@gmx.at>
3530 * window.c (resize_root_window, grow_mini_window)
3531 (shrink_mini_window): Rename Qresize_root_window to
3532 Qwindow_resize_root_window and Qresize_root_window_vertically to
3533 Qwindow_resize_root_window_vertically.
3535 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3537 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3539 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
3541 * makefile.w32-in: Redesign dependencies so they reflect more
3542 clearly which files are directly included by each source file,
3543 and not through other includes.
3545 2011-06-27 Martin Rudalics <rudalics@gmx.at>
3547 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3548 (sort_overlays, overlay_strings): When an overlay's clone number
3549 matches the window's clone number process the overlay even if
3550 the overlay's window property doesn't match the current window.
3552 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3553 (Fwindow_hchild): Rename to Fwindow_left_child.
3554 (Fwindow_next): Rename to Fwindow_next_sibling.
3555 (Fwindow_prev): Rename to Fwindow_prev_sibling.
3556 (resize_window_check): Rename to window_resize_check.
3557 (resize_window_apply): Rename to window_resize_apply.
3558 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3559 (Fdelete_other_windows_internal, resize_frame_windows)
3560 (Fsplit_window_internal, Fdelete_window_internal)
3561 (grow_mini_window, shrink_mini_window)
3562 (Fresize_mini_window_internal): Fix callers accordingly.
3564 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3566 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3567 (emacs_fixed_set_min_size): Remove.
3568 (emacs_fixed_new): Take frame as argument.
3570 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3571 (_EmacsFixedPrivate): Remove minwidth/height.
3572 Add struct frame *f.
3573 (emacs_fixed_init): Initialize priv->f.
3574 (get_parent_class, emacs_fixed_set_min_size): Remove.
3575 (emacs_fixed_new): Set priv->f to argument.
3576 (emacs_fixed_get_preferred_width)
3577 (emacs_fixed_get_preferred_height): Use min_width/height from
3578 frames size_hint to set minimum and natural (Bug#8919).
3579 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3580 and use min_width/height from frames size_hint to set
3581 min_width/height (Bug#8919).
3583 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
3584 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3587 2011-06-26 Eli Zaretskii <eliz@gnu.org>
3589 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3590 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3593 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
3595 * process.c (wait_reading_process_output): Bypass select if
3596 waiting for a cell while ignoring keyboard input, and input is
3597 pending. Suggested by Jan Djärv (Bug#8869).
3599 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3601 Use gnulib's dup2 module instead of rolling our own.
3602 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3604 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3606 * dispnew.c (scrolling_window): Before scrolling, turn off a
3607 mouse-highlight in the window being scrolled.
3609 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
3611 Move DEFSYM to lisp.h and use everywhere.
3613 * character.h (DEFSYM): Move declaration...
3614 * lisp.h (DEFSYM): ...here.
3620 * w32select.c: Don't include character.h.
3622 * alloc.c (syms_of_alloc):
3623 * buffer.c (syms_of_buffer):
3624 * bytecode.c (syms_of_bytecode):
3625 * callint.c (syms_of_callint):
3626 * casefiddle.c (syms_of_casefiddle):
3627 * casetab.c (init_casetab_once):
3628 * category.c (init_category_once, syms_of_category):
3629 * ccl.c (syms_of_ccl):
3630 * cmds.c (syms_of_cmds):
3631 * composite.c (syms_of_composite):
3632 * dbusbind.c (syms_of_dbusbind):
3633 * dired.c (syms_of_dired):
3634 * dispnew.c (syms_of_display):
3635 * doc.c (syms_of_doc):
3636 * editfns.c (syms_of_editfns):
3637 * emacs.c (syms_of_emacs):
3638 * eval.c (syms_of_eval):
3639 * fileio.c (syms_of_fileio):
3640 * fns.c (syms_of_fns):
3641 * frame.c (syms_of_frame):
3642 * fringe.c (syms_of_fringe):
3643 * insdel.c (syms_of_insdel):
3644 * keymap.c (syms_of_keymap):
3645 * lread.c (init_obarray, syms_of_lread):
3646 * macros.c (syms_of_macros):
3647 * msdos.c (syms_of_msdos):
3648 * print.c (syms_of_print):
3649 * process.c (syms_of_process):
3650 * search.c (syms_of_search):
3651 * sound.c (syms_of_sound):
3652 * syntax.c (init_syntax_once, syms_of_syntax):
3653 * terminal.c (syms_of_terminal):
3654 * textprop.c (syms_of_textprop):
3655 * undo.c (syms_of_undo):
3656 * w32.c (globals_of_w32):
3657 * window.c (syms_of_window):
3658 * xdisp.c (syms_of_xdisp):
3659 * xfaces.c (syms_of_xfaces):
3660 * xfns.c (syms_of_xfns):
3661 * xmenu.c (syms_of_xmenu):
3662 * xsettings.c (syms_of_xsettings):
3663 * xterm.c (syms_of_xterm): Use DEFSYM.
3665 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3667 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
3669 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3671 Integer and buffer overflow fixes (Bug#8873).
3673 * print.c (printchar, strout): Check for string overflow.
3674 (PRINTPREPARE, printchar, strout):
3675 Don't set size unless allocation succeeds.
3677 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3678 for sizes. Check for string overflow more accurately.
3679 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3681 * macros.c: Integer and buffer overflow fixes.
3682 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3683 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3684 Use ptrdiff_t, not int, for sizes.
3685 Don't increment bufsize until after realloc succeeds.
3686 Check for size-calculation overflow.
3687 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3689 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3691 * lread.c: Integer overflow fixes.
3692 (read_integer): Radix is now EMACS_INT, not int,
3693 to improve quality of diagnostics for out-of-range radices.
3694 Calculate buffer size correctly for out-of-range radices.
3695 (read1): Check for integer overflow in radices, and in
3696 read-circle numbers.
3697 (read_escape): Avoid int overflow.
3698 (Fload, openp, read_buffer_size, read1)
3699 (substitute_object_recurse, read_vector, read_list, map_obarray):
3700 Use ptrdiff_t, not int, for sizes.
3701 (read1): Use EMACS_INT, not int, for sizes.
3702 Check for size overflow.
3704 * image.c (cache_image): Check for size arithmetic overflow.
3706 * lread.c: Integer overflow issues.
3707 (saved_doc_string_size, saved_doc_string_length)
3708 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3709 Now ptrdiff_t, not int.
3710 (read1): Don't assume doc string length fits in int. Check for
3711 out-of-range doc string lengths.
3712 (read_list): Don't assume file position fits in int.
3713 (read_escape): Check for hex character overflow.
3715 2011-06-22 Leo Liu <sdl.web@gmail.com>
3717 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3718 Move to minibuffer.el.
3720 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3722 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
3723 The following patches are for when GLYPH_DEBUG && !XASSERT.
3724 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3725 * dispnew.c (flush_stdout):
3726 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3727 Mark as externally visible.
3728 * dispnew.c (check_window_matrix_pointers): Now static.
3729 * dispnew.c (window_to_frame_vpos):
3730 * xfns.c (unwind_create_frame):
3731 * xterm.c (x_check_font): Remove unused local.
3732 * scroll.c (CHECK_BOUNDS):
3733 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3734 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3735 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3736 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3737 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3739 (debug_method_add): Use va_list and vsprintf rather than relying
3740 on undefined behavior with wrong number of arguments.
3741 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3742 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3743 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3744 since we're not interested in debugging glyphs with old libraries.
3745 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3746 GCC 4.6.0's static checking.
3748 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3750 Integer overflow and signedness fixes (Bug#8873).
3751 A few related buffer overrun fixes, too.
3753 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3755 * dispextern.h (struct face.stipple):
3756 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3757 (x_bitmap_mask, x_allocate_bitmap_record)
3758 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3759 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3760 (x_create_bitmap_from_xpm_data):
3761 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3762 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3764 * xfaces.c (load_pixmap):
3765 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3766 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3767 (.bitmaps_last, struct x_output.icon_bitmap):
3768 Use ptrdiff_t, not int, for bitmap indexes.
3769 (x_allocate_bitmap_record): Check for size overflow.
3770 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3772 Use ptrdiff_t, not int, for overlay counts.
3773 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3774 * editfns.c (overlays_around, get_pos_property):
3775 * textprop.c (get_char_property_and_overlay):
3776 * xdisp.c (next_overlay_change, note_mouse_highlight):
3777 * xfaces.c (face_at_buffer_position):
3778 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3779 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3780 (Fnext_overlay_change, Fprevious_overlay_change)
3781 (mouse_face_overlay_overlaps, Foverlays_in):
3782 Use ptrdiff_t, not int, for sizes.
3783 (overlays_at, overlays_in): Check for size-calculation overflow.
3785 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3787 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3788 (x_session_initialize): Do not assume string length fits in int.
3790 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3791 This is unlikely, but can occur if DPI is outlandish.
3793 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3794 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3796 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3797 * xrdb.c (magic_file_p, search_magic_path):
3798 Omit last arg SUFFIX; it was always 0. All callers changed.
3799 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3801 * xfont.c (xfont_match): Avoid need for strlen.
3803 * xfns.c: Don't assume strlen fits in int.
3804 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3806 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3807 not unsigned long, as we prefer signed integers. All callers changed.
3808 Detect integer overflow in repeat count.
3809 (message_dolog): Don't assume print length fits in 39 bytes.
3810 (display_mode_element): Don't assume strlen fits in int.
3812 * termcap.c: Don't assume sizes fit in int and never overflow.
3813 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3814 (gobble_line): Check for size-calculation overflow.
3816 * minibuf.c (Fread_buffer):
3817 * lread.c (intern, intern_c_string):
3818 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3819 Don't assume string length fits in int.
3821 * keyboard.c (parse_tool_bar_item):
3822 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3824 * font.c: Don't assume string length fits in int.
3825 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3826 Use ptrdiff_t, not int.
3827 (font_intern_prop): Don't assume string length fits in int.
3828 Don't assume integer property fits in fixnum.
3829 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3831 * filelock.c: Fix some buffer overrun and integer overflow issues.
3832 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3833 Reformulate so as not to need the command string.
3834 Invoke gzip -cd rather than gunzip, as it's more portable.
3835 (lock_info_type, lock_file_1, lock_file):
3836 Don't assume pid_t and time_t fit in unsigned long.
3837 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3838 (current_lock_owner): Prefer signed type for sizes.
3839 Use memcpy, not strncpy, where memcpy is what is really wanted.
3840 Don't assume (via atoi) that time_t and pid_t fit in int.
3841 Check for time_t and/or pid_t out of range, e.g., via a network share.
3842 Don't alloca where an auto var works fine.
3844 * fileio.c: Fix some integer overflow issues.
3845 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3846 Don't assume string length fits in int.
3847 (directory_file_name): Don't assume string length fits in long.
3848 (make_temp_name): Don't assume pid fits in int, or that its print
3849 length is less than 20.
3851 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3853 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3855 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3857 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3858 We prefer signed integers, even for size calculations.
3860 * emacs.c: Don't assume string length fits in 'int'.
3861 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3862 (main): Don't invoke strlen when not needed.
3864 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3865 (XD_DEBUG_MESSAGE): Don't waste a byte.
3867 * callproc.c (getenv_internal_1, getenv_internal)
3869 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3871 * lread.c (invalid_syntax): Omit length argument.
3872 All uses changed. This doesn't fix a bug, but it simplifies the
3873 code away from its former Hollerith-constant appearance, and it's
3874 one less 'int' to worry about when looking at integer-overflow issues.
3875 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3877 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3878 This didn't break anything, but it didn't help either.
3879 It's confusing to put a bogus integer in a place where the actual
3880 value does not matter.
3881 (LIST_END_P): Remove unused macro and its bogus comment.
3882 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3884 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3885 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3887 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3888 We prefer signed types, and the value cannot exceed the EMACS_INT
3889 range anyway (because otherwise the length would not be representable).
3890 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3891 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3892 This avoids a GCC warning when WIDE_EMACS_INT.
3894 * indent.c (sane_tab_width): New function.
3895 (current_column, scan_for_column, Findent_to, position_indentation)
3896 (compute_motion): Use it. This is just for clarity.
3897 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3899 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3901 * lisp.h (lint_assume): New macro.
3902 * composite.c (composition_gstring_put_cache):
3903 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3905 * editfns.c, insdel.c:
3906 Omit unnecessary forward decls, to simplify future changes.
3908 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3910 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3912 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3913 Use much-faster test for byte-length change.
3914 Don't assume string byte-length fits in 'int'.
3915 Check that character arg fits in 'int'.
3916 (mapcar1): Declare byte as byte, for clarity.
3918 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3920 * fns.c (concat): Catch string overflow earlier.
3921 Do not rely on integer wraparound.
3923 * dispextern.h (struct it.overlay_strings_charpos)
3924 (struct it.selective): Now EMACS_INT, not int.
3925 * xdisp.c (forward_to_next_line_start)
3926 (back_to_previous_visible_line_start)
3927 (reseat_at_next_visible_line_start, next_element_from_buffer):
3928 Don't arbitrarily truncate the value of 'selective' to int.
3930 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3932 * composite.c: Don't truncate sizes to 'int'.
3933 (composition_gstring_p, composition_reseat_it)
3934 (composition_adjust_point): Use EMACS_INT, not int.
3935 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3936 not EMACS_UINT, for indexes.
3938 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3940 * buffer.c: Include <verify.h>.
3941 (struct sortvec.priority, struct sortstr.priority):
3942 Now EMACS_INT, not int.
3943 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3944 (struct sortstr.size, record_overlay_string)
3945 (struct sortstrlist.size, struct sortlist.used):
3946 Don't truncate size to int.
3947 (record_overlay_string): Check for size-calculation overflow.
3948 (init_buffer_once): Check at compile-time, not run-time.
3950 2011-06-22 Jim Meyering <meyering@redhat.com>
3952 Don't leak an XBM-image-sized buffer
3953 * image.c (xbm_load): Free the image buffer after using it.
3955 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3958 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3959 that Sun C diagnosed.
3960 * fns.c (secure_hash): Fix pointer signedness issue.
3961 * intervals.c (static_offset_intervals): New function.
3962 (offset_intervals): Use it.
3964 2011-06-21 Leo Liu <sdl.web@gmail.com>
3967 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3970 * fns.c (secure_hash): Rename from crypto_hash_function and change
3971 the first arg to accept symbols.
3972 (Fsecure_hash): New primitive.
3973 (syms_of_fns): New symbols.
3975 2011-06-20 Deniz Dogan <deniz@dogan.se>
3977 * process.c (Fset_process_buffer): Clarify return value in
3980 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3982 * dispnew.c (add_window_display_history): Use BVAR.
3984 * xdisp.c (debug_method_add): Use BVAR.
3985 (check_window_end, dump_glyph_matrix, dump_glyph)
3986 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3988 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3991 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3992 check till after the cache is created in init_frame_faces.
3994 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3996 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3998 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4000 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4001 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4002 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4004 Improve buffer-overflow checking (Bug#8873).
4005 * fileio.c (Finsert_file_contents):
4006 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4007 Remove the old (too-loose) buffer overflow checks.
4008 They weren't needed, since make_gap checks for buffer overflow.
4009 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4010 The old code merely checked for Emacs fixnum overflow, and relied
4011 on undefined (wraparound) behavior. The new code avoids undefined
4012 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4014 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4015 Tune. Don't use wider integers than needed. Don't use alloca.
4016 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4018 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4020 * insdel.c, lisp.h (buffer_overflow): New function.
4021 (insert_from_buffer_1, replace_range, replace_range_2):
4022 * insdel.c (make_gap_larger):
4023 * editfns.c (Finsert_char):
4024 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4026 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4028 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4030 Integer overflow and signedness fixes (Bug#8873).
4032 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4033 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4035 * fileio.c: Don't assume EMACS_INT fits in off_t.
4036 (emacs_lseek): New static function.
4037 (Finsert_file_contents, Fwrite_region): Use it.
4038 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4040 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4042 * fns.c: Don't overflow int when computing a list length.
4043 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4044 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4045 truncation on 64-bit hosts. Check for QUIT every
4046 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4047 faster and is responsive enough.
4048 (Flength): Report an error instead of overflowing an integer.
4049 (Fsafe_length): Return a float if the value is not representable
4050 as a fixnum. This shouldn't happen except in contrived situations.
4051 (Fnthcdr, Fsort): Don't assume list length fits in int.
4052 (Fcopy_sequence): Don't assume vector length fits in int.
4054 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4055 (header_size, word_size): New constants.
4056 (allocate_vectorlike): Don't check size overflow here.
4057 (allocate_vector): Check it here instead, since this is the only
4058 caller of allocate_vectorlike that could cause overflow.
4059 Check that the new vector's length is representable as a fixnum.
4061 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4062 The previous code was bogus. For example, next_almost_prime (32)
4063 returned 39, which is undesirable as it is a multiple of 3; and
4064 next_almost_prime (24) returned 25, which is a multiple of 5 so
4065 why was the code bothering to check for multiples of 7?
4067 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4069 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4071 Variadic C functions now count arguments with ptrdiff_t.
4072 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4073 Back then I didn't know that the Emacs coding style prefers signed int.
4074 Also, in the meantime I found a few more instances where arguments
4075 were being counted with int, which may truncate counts on 64-bit
4076 machines, or EMACS_INT, which may be unnecessarily wide.
4077 * lisp.h (struct Lisp_Subr.function.aMANY)
4078 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4079 Arg counts are now ptrdiff_t, not size_t.
4080 All variadic functions and their callers changed accordingly.
4081 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4082 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4083 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4084 * callint.c (Fcall_interactively): Check arg count for overflow,
4085 to avoid potential buffer overrun. Use signed char, not 'int',
4086 for 'varies' array, so that we needn't bother to check its size
4087 calculation for overflow.
4088 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4089 * eval.c (apply_lambda):
4090 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4091 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4092 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4094 * callint.c (Fcall_interactively): Don't use index var as event count.
4096 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4097 * mem-limits.h (SIZE): Remove; no longer used.
4099 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4101 Remove unnecessary casts.
4102 * xterm.c (x_term_init):
4103 * xfns.c (x_set_border_pixel):
4104 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4105 These aren't needed now that we assume ANSI C.
4107 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4108 It's more likely to cause problems (due to unsigned overflow)
4111 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4113 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4115 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4117 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4119 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4121 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4123 GLYPH_CODE_FACE returns EMACS_INT, not int.
4124 * dispextern.h (merge_faces):
4125 * xfaces.c (merge_faces):
4126 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4127 Don't assume EMACS_INT fits in int.
4129 * character.h (CHAR_VALID_P): Remove unused parameter.
4130 * fontset.c, lisp.h, xdisp.c: All uses changed.
4132 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4134 * fns.c (concat): Minor tuning based on overflow analysis.
4135 This doesn't fix any bugs. Use int to hold character, instead
4136 of constantly refetching from Emacs object. Use XFASTINT, not
4137 XINT, for value known to be a character. Don't bother comparing
4138 a single byte to 0400, as it's always less.
4140 * floatfns.c (Fexpt):
4141 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4143 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4146 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4148 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4149 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4150 incorrectly succeed when S was a string, because 4294967386 was
4151 truncated before it was used.
4153 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4154 Otherwise, an out-of-range integer could cause undefined behavior
4157 * composite.c: Use int, not EMACS_INT, for characters.
4158 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4159 EMACS_INT, for values that are known to be in character range.
4160 This doesn't fix any bugs but is the usual style inside Emacs and
4161 may generate better code on 32-bit machines.
4163 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4164 This is for reasons similar to the recent CHAR_STRING fix.
4165 * charset.c (Fencode_char): Check that character arg is actually
4166 a character. Pass an int to ENCODE_CHAR.
4167 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4168 wider than 'int', as a compile-time check to prevent future regressions
4171 * character.c (char_string): Remove unnecessary casts.
4173 Make sure a 64-bit char is never passed to CHAR_STRING.
4174 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4175 by silently ignoring the top 32 bits, allowing some values
4176 that were far too large to be valid characters.
4177 * character.h: Include <verify.h>.
4178 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4179 arguments are no wider than unsigned, as a compile-time check
4180 to prevent future regressions in this area.
4182 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4183 (Fsubst_char_in_region):
4185 * xdisp.c (decode_mode_spec_coding):
4186 Adjust to CHAR_STRING's new requirement.
4187 * editfns.c (Finsert_char, Fsubst_char_in_region):
4188 * fns.c (concat): Check that character args are actually
4189 characters. Without this test, these functions did the wrong
4190 thing with wildly out-of-range values on 64-bit hosts.
4192 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4193 These casts should not be needed on 32-bit hosts, either.
4194 * keyboard.c (read_char):
4195 * lread.c (Fload): Remove casts to unsigned.
4197 * lisp.h (UNSIGNED_CMP): New macro.
4198 This fixes comparison bugs on 64-bit hosts.
4199 (ASCII_CHAR_P): Use it.
4200 * casefiddle.c (casify_object):
4201 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4202 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4203 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4204 * dispextern.h (FACE_FROM_ID):
4205 * keyboard.c (read_char): Use UNSIGNED_CMP.
4207 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4208 not to EMACS_INT, to avoid GCC warning.
4210 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4212 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4213 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4214 isn't needed on 32-bit machines.
4216 * buffer.c (Fgenerate_new_buffer_name):
4217 Use EMACS_INT for count, not int.
4218 (advance_to_char_boundary): Return EMACS_INT, not int.
4220 * data.c (Qcompiled_function): Now static.
4222 * window.c (window_body_lines): Now static.
4224 * image.c (gif_load): Rename local to avoid shadowing.
4226 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4227 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4228 * alloc.c (make_save_value): Integer argument is now of type
4230 (mark_object): Use ptrdiff_t, not int.
4231 * lisp.h (pD): New macro.
4232 * print.c (print_object): Use it.
4234 * alloc.c: Use EMACS_INT, not int, to count objects.
4235 (total_conses, total_markers, total_symbols, total_vector_size)
4236 (total_free_conses, total_free_markers, total_free_symbols)
4237 (total_free_floats, total_floats, total_free_intervals)
4238 (total_intervals, total_strings, total_free_strings):
4239 Now EMACS_INT, not int. All uses changed.
4240 (Fgarbage_collect): Compute overall total using a double, so that
4241 integer overflow is less likely to be a problem. Check for overflow
4242 when converting back to an integer.
4243 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4244 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4245 These were 'int' variables that could overflow on 64-bit hosts;
4246 they were never used, so remove them instead of repairing them.
4247 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4248 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4249 Previously, this ceilinged at INT_MAX, but that doesn't work on
4251 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4253 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4254 (allocate_vectorlike): Check for ptrdiff_t overflow.
4255 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4256 when a (possibly-narrower) signed value would do just as well.
4257 We prefer using signed arithmetic, to avoid comparison confusion.
4259 * alloc.c: Catch some string size overflows that we were missing.
4260 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4261 for convenience in STRING_BYTES_MAX.
4262 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4263 The definition here is exact; the one in lisp.h was approximate.
4264 (allocate_string_data): Check for string overflow. This catches
4265 some instances we weren't catching before. Also, it catches
4266 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4267 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4268 and ptrdiff_t and EMACS_INT are both 64 bits.
4270 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4271 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4272 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4274 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4276 * alloc.c (Fmake_string): Check for out-of-range init.
4278 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4280 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4282 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4284 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4285 xg_get_default_scrollbar_width.
4287 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4288 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4289 (style_changed_cb): Call update_theme_scrollbar_width and call
4290 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4291 all frames (Bug#8505).
4292 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4293 Call gtk_window_set_resizable if HAVE_GTK3.
4294 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4295 and height if HAVE_GTK3 (Bug#8505).
4296 (scroll_bar_width_for_theme): New variable.
4297 (update_theme_scrollbar_width): New function.
4298 (xg_get_default_scrollbar_width): Move code to
4299 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4300 (xg_initialize): Call update_theme_scrollbar_width.
4302 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4304 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4306 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4308 * frame.c (make_frame): Call other_buffer_safely instead of
4311 * window.c (temp_output_buffer_show): Call display_buffer with
4312 second argument Vtemp_buffer_show_specifiers and reset latter
4313 immediately after the call.
4314 (Vtemp_buffer_show_specifiers): New variable.
4315 (auto_window_vscroll_p, next_screen_context_lines)
4316 (Vscroll_preserve_screen_position): Remove leading asterisks from
4319 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4321 Fix minor problems found by GCC 4.6.0 static checking.
4322 * buffer.c (Qclone_number): Remove for now, as it's unused.
4323 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4324 (record_buffer): Remove unused local.
4325 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4326 (set_frame_buffer_list): Remove; unused.
4327 * frame.h (other_visible_frames): Remove decl.
4328 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4329 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4330 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4332 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4333 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4334 Define only if HAVE_GPM.
4335 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4336 (update_hints_inhibit): Remove; never set. All uses removed.
4337 * widgetprv.h (emacsFrameClassRec): Remove decl.
4338 * window.c (delete_deletable_window): Now returns void, since it
4339 wasn't returning anything.
4340 (compare_window_configurations): Remove unused locals.
4341 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4342 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4343 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4344 the same widths as pointers. This follows up on the 2011-05-06 patch.
4345 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4346 * xterm.h: Likewise.
4347 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4349 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4351 * makefile.w32-in: Update dependencies.
4352 (LISP_H): Add lib/intprops.h.
4354 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4356 * image.c (gif_load): Add animation frame delay to the metadata.
4357 (syms_of_image): Use DEFSYM. New symbol `delay'.
4359 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4361 * window.c (delete_deletable_window): Re-add.
4362 (Fset_window_configuration): Rewrite to handle dead buffers and
4363 consequently deletable windows.
4364 (window_tree, Fwindow_tree): Remove. Supply functionality in
4366 (compare_window_configurations): Simplify code.
4368 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4370 * image.c (imagemagick_load_image): Fix type mismatch.
4371 (Fimagemagick_types): Likewise.
4373 * window.h (replace_buffer_in_windows): Declare.
4375 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4377 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4378 Qclone_number. Remove external declaration of Qdelete_window.
4379 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4381 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4382 Run Qbuffer_list_update_hook if allowed.
4383 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4384 buffer list implementation.
4385 (other_buffer_safely): New function.
4386 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4387 calls to replace_buffer_in_windows and
4388 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4390 (record_buffer): Inhibit quitting and rewrite using quittable
4391 functions. Run Qbuffer_list_update_hook if allowed.
4392 (Frecord_buffer, Funrecord_buffer): New functions.
4393 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4394 Move switch-to-buffer to window.el.
4395 (bury-buffer): Move to window.el.
4396 (Vbuffer_list_update_hook): New variable.
4398 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4401 * window.h (resize_frame_windows): Move up in code.
4402 (Fwindow_frame): Remove EXFUN.
4403 (replace_buffer_in_all_windows): Remove prototype.
4404 (replace_buffer_in_windows_safely): Add prototype.
4406 * window.c: Declare Qdelete_window static again. Move down
4407 declaration of select_count.
4408 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4409 (Fother_window): Move to window.el.
4410 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4411 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4412 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4414 (replace_buffer_in_windows): Implement by calling
4415 Qreplace_buffer_in_windows.
4416 (replace_buffer_in_all_windows): Remove with some functionality
4417 moved into replace_buffer_in_windows_safely.
4418 (replace_buffer_in_windows_safely): New function.
4419 (select_window_norecord, select_frame_norecord): Move in front
4420 of run_window_configuration_change_hook. Remove now obsolete
4422 (Fset_window_buffer): Rewrite doc-string.
4423 Call Qrecord_window_buffer.
4424 (keys_of_window): Move binding for other-window to window.el.
4426 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4428 * dispextern.h (struct image): Replace data member, whose int_val
4429 and ptr_val fields were not used by anything, with a single
4432 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4433 (gif_clear_image, gif_load, imagemagick_load_image)
4434 (gs_clear_image, gs_load): Callers changed.
4436 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4438 * buffer.h: Include <time.h>, for time_t.
4439 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4441 Fix minor problems found by static checking.
4443 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4445 Make identifiers static if they are not used in other modules.
4446 * data.c (Qcompiled_function, Qframe, Qvector):
4447 * image.c (QimageMagick, Qsvg):
4448 * minibuf.c (Qmetadata):
4449 * window.c (resize_window_check, resize_root_window): Now static.
4450 * window.h (resize_window_check, resize_root_window): Remove decls.
4452 * window.c (window_deletion_count, delete_deletable_window):
4454 (window_body_lines): Now static.
4455 (Fdelete_other_windows_internal): Mark vars as initialized.
4456 Make sure 'resize_failed' is initialized.
4457 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4458 (resize_window_apply): Remove unused local.
4459 * window.h (delete_deletable_window): Remove decl.
4461 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4462 (imagemagick_load_image): Fix pointer signedness problem by changing
4463 last arg from unsigned char * to char *. All uses changed.
4464 Also, fix a local for similar reasons.
4465 Remove unused locals. Remove locals to avoid shadowing.
4466 (fn_rsvg_handle_free): Remove; unused.
4467 (svg_load, svg_load_image): Fix pointer signedness problem.
4468 (imagemagick_load_image): Don't use garbage pointer image_wand.
4470 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4472 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
4474 * image.c (gif_load): Fix omitted cast error introduced by
4477 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4479 * window.h (resize_proportionally, orig_total_lines)
4480 (orig_top_line): Remove from window structure.
4481 (set_window_height, set_window_width, change_window_heights)
4482 (Fdelete_window): Remove prototypes.
4483 (resize_frame_windows): Remove duplicate declaration.
4485 2011-06-10 Eli Zaretskii <eliz@gnu.org>
4487 * window.h (resize_frame_windows, resize_window_check)
4488 (delete_deletable_window, resize_root_window)
4489 (resize_frame_windows): Declare prototypes.
4491 * window.c (resize_window_apply): Make definition be "static" to
4492 match the prototype.
4494 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4496 * window.c: Remove declarations of Qwindow_size_fixed,
4497 window_min_size_1, window_min_size_2, window_min_size,
4498 size_window, window_fixed_size_p, enlarge_window, delete_window.
4499 Remove static from declaration of Qdelete_window, it's
4500 temporarily needed by Fbury_buffer.
4501 (replace_window): Don't assign orig_top_line and
4503 (Fdelete_window, delete_window): Remove. Window deletion is
4504 handled by window.el.
4505 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4506 Replace Fdelete_window calls with calls to Qdelete_window.
4507 (Fdelete_other_windows): Remove. Deleting other windows is
4508 handled by window.el.
4509 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4510 handled in window.el.
4511 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4512 Window minimum sizes are handled in window.el.
4513 (shrink_windows, size_window, set_window_height)
4514 (set_window_width, change_window_heights, window_height)
4515 (window_width, CURBEG, CURSIZE, enlarge_window)
4516 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4517 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4518 handled in window.el.
4519 (make_dummy_parent): Rename to make_parent_window and give it a
4520 second argument horflag.
4521 (make_window): Don't set resize_proportionally any more.
4522 (Fsplit_window): Remove. Windows are split in window.el.
4523 (save_restore_action, save_restore_orig_size)
4524 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4525 Resize mini windows in window.el.
4526 (grow_mini_window, shrink_mini_window): Implement by calling
4527 Qresize_root_window_vertically, resize_window_check and
4528 resize_window_apply.
4529 (saved_window, Fset_window_configuration, save_window_save):
4530 Do not handle orig_top_line, orig_total_lines, and
4531 resize_proportionally.
4532 (window_min_height, window_min_width): Move to window.el.
4533 (keys_of_window): Move bindings for delete-other-windows,
4534 split-window, delete-window and enlarge-window to window.el.
4536 * buffer.c: Temporarily extern Qdelete_window.
4537 (Fbury_buffer): Temporarily call Qdelete_window instead of
4538 Fdelete_window (Fbury_buffer will move to window.el soon).
4540 * frame.c (set_menu_bar_lines_1): Remove code handling
4541 orig_top_line and orig_total_lines.
4543 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4544 set_window_height but set heights directly.
4545 (change_frame_size_1): Use resize_frame_windows.
4547 * xdisp.c (init_xdisp): Don't use set_window_height but set
4550 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4551 Use resize_frame_windows instead of change_window_heights and run
4552 run_window_configuration_change_hook.
4554 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4555 instead of change_window_heights and run
4556 run_window_configuration_change_hook.
4558 2011-06-09 Martin Rudalics <rudalics@gmx.at>
4560 * window.c (replace_window): Rename second argument REPLACEMENT to
4561 NEW. New third argument SETFLAG. Rewrite.
4562 (delete_window, make_dummy_parent): Call replace_window with
4564 (window_list_1): Move down in code.
4565 (run_window_configuration_change_hook): Move set_buffer part
4566 before select_frame_norecord part in order to unwind correctly.
4567 Rename count1 to count.
4568 (recombine_windows, delete_deletable_window, resize_root_window)
4569 (Fdelete_other_windows_internal)
4570 (Frun_window_configuration_change_hook, make_parent_window)
4571 (resize_window_check, resize_window_apply, Fresize_window_apply)
4572 (resize_frame_windows, Fsplit_window_internal)
4573 (Fdelete_window_internal, Fresize_mini_window_internal):
4575 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4577 2011-06-08 Martin Rudalics <rudalics@gmx.at>
4579 * window.h (window): Add some new members to window structure -
4580 normal_lines, normal_cols, new_total, new_normal, clone_number,
4581 splits, nest, prev_buffers, next_buffers.
4582 (WINDOW_TOTAL_SIZE): Move here from window.c.
4583 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
4585 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4587 (make_dummy_parent): Set new members of windows structure.
4588 (make_window): Move down in code. Handle new members of window
4590 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4591 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4592 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4593 (Fset_window_prev_buffers, Fwindow_next_buffers)
4594 (Fset_window_next_buffers, Fset_window_clone_number):
4596 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4597 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4599 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4600 Argument WINDOW can be now internal window too.
4601 (Fwindow_use_time): Move up in code.
4602 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4604 (Fset_window_configuration, saved_window)
4605 (Fcurrent_window_configuration, save_window_save): Handle new
4606 members of window structure.
4607 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4608 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4609 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4610 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4611 Qget_mru_window, Qresize_root_window,
4612 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4613 Qauto_buffer_name; staticpro them.
4615 2011-06-07 Martin Rudalics <rudalics@gmx.at>
4617 * window.c (Fwindow_total_size, Fwindow_left_column)
4618 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4619 (Fwindow_list_1): New functions.
4620 (window_box_text_cols): Replace with window_body_cols.
4621 (Fwindow_width, Fscroll_left, Fscroll_right):
4622 Use window_body_cols instead of window_box_text_cols.
4623 (delete_window, Fset_window_configuration):
4624 Call delete_all_subwindows with window as argument.
4625 (delete_all_subwindows): Take a window as argument and not a
4627 (window_loop): Remove handling of GET_LRU_WINDOW and
4629 (Fget_lru_window, Fget_largest_window): Move to window.el.
4631 * window.h: Extern window_body_cols instead of
4632 window_box_text_cols. delete_all_subwindows now takes a
4633 Lisp_Object as argument.
4635 * indent.c (compute_motion, Fcompute_motion):
4636 Use window_body_cols instead of window_box_text_cols.
4638 * frame.c (delete_frame): Call delete_all_subwindows with root
4641 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4643 * fns.c (Fputhash): Document return value.
4645 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
4647 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4649 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4651 Cons<->int and similar integer overflow fixes (Bug#8794).
4653 Check for overflow when converting integer to cons and back.
4654 * charset.c (Fdefine_charset_internal, Fdecode_char):
4655 Use cons_to_unsigned to catch overflow.
4656 (Fencode_char): Use INTEGER_TO_CONS.
4657 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4658 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4659 * data.c (long_to_cons, cons_to_long): Remove.
4660 (cons_to_unsigned, cons_to_signed): New functions.
4661 These signal an error for invalid or out-of-range values.
4662 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4663 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4664 * font.c (Ffont_variation_glyphs):
4665 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4666 * lisp.h: Include <intprops.h>.
4667 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4668 (cons_to_signed, cons_to_unsigned): New decls.
4669 (long_to_cons, cons_to_long): Remove decls.
4670 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4671 (Fprimitive_undo): Use CONS_TO_INTEGER.
4672 * xfns.c (Fx_window_property): Likewise.
4673 * xselect.c: Include <limits.h>.
4674 (x_own_selection, selection_data_to_lisp_data):
4675 Use INTEGER_TO_CONS.
4676 (x_handle_selection_request, x_handle_selection_clear)
4677 (x_get_foreign_selection, Fx_disown_selection_internal)
4678 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4679 (lisp_data_to_selection_data): Use cons_to_unsigned.
4680 (x_fill_property_data): Use cons_to_signed.
4681 Report values out of range.
4683 Check for buffer and string overflow more precisely.
4684 * buffer.h (BUF_BYTES_MAX): New macro.
4685 * lisp.h (STRING_BYTES_MAX): New macro.
4686 * alloc.c (Fmake_string):
4687 * character.c (string_escape_byte8):
4688 * coding.c (coding_alloc_by_realloc):
4689 * doprnt.c (doprnt):
4690 * editfns.c (Fformat):
4692 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4693 since they may not be the same number.
4694 * editfns.c (Finsert_char):
4695 * fileio.c (Finsert_file_contents):
4696 Likewise for BUF_BYTES_MAX.
4698 * image.c: Use ptrdiff_t, not int, for sizes.
4699 (slurp_file): Switch from int to ptrdiff_t.
4701 (slurp_file): Check that file size fits in both size_t (for
4702 malloc) and ptrdiff_t (for sanity and safety).
4704 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4705 if b->modtime has its maximal value.
4707 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4709 Don't assume time_t can fit into int.
4710 * buffer.h (struct buffer.modtime): Now time_t, not int.
4711 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4712 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4714 Minor fixes for signed vs unsigned integers.
4715 * character.h (MAYBE_UNIFY_CHAR):
4716 * charset.c (maybe_unify_char):
4717 * keyboard.c (read_char, reorder_modifiers):
4718 XINT -> XFASTINT, since the integer must be nonnegative.
4719 * ftfont.c (ftfont_spec_pattern):
4720 * keymap.c (access_keymap, silly_event_symbol_error):
4721 XUINT -> XFASTINT, since the integer must be nonnegative.
4722 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4723 since it makes no difference and we prefer signed.
4724 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4725 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4728 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4730 * window.h (Fwindow_frame): Declare.
4732 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4734 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4735 (SPARE_MEMORY): Always define.
4736 (LARGE_REQUEST): Remove.
4737 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4739 2011-06-06 Martin Rudalics <rudalics@gmx.at>
4741 * lisp.h: Move EXFUNS for Fframe_root_window,
4742 Fframe_first_window and Fset_frame_selected_window to window.h.
4744 * window.h: Move EXFUNS for Fframe_root_window,
4745 Fframe_first_window and Fset_frame_selected_window here from
4748 * frame.c (Fwindow_frame, Fframe_first_window)
4749 (Fframe_root_window, Fframe_selected_window)
4750 (Fset_frame_selected_window): Move to window.c.
4751 (Factive_minibuffer_window): Move to minibuf.c.
4752 (Fother_visible_frames_p): New function.
4754 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4756 * window.c (decode_window, decode_any_window): Move up in code.
4757 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4758 (inhibit_frame_unsplittable): Remove unused variable.
4759 (Fwindow_buffer): Move up and rewrite doc-string.
4760 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4761 (Fwindow_prev): New functions.
4762 (Fwindow_frame): Move here from frame.c. Accept any window as
4764 (Fframe_root_window, Fframe_first_window)
4765 (Fframe_selected_window): Move here from frame.c. Accept frame
4766 or arbitrary window as argument. Update doc-strings.
4767 (Fminibuffer_window): Move up in code.
4768 (Fwindow_minibuffer_p): Move up in code and simplify.
4769 (Fset_frame_selected_window): Move here from frame.c.
4771 (Fselected_window, select_window, Fselect_window): Move up in
4772 code. Minor doc-string fixes.
4774 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4776 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4777 Do not assume that spare memory exists; that assumption is valid
4778 only if SYSTEM_MALLOC.
4779 (LARGE_REQUEST): New macro, so that the issue of large requests
4780 is separated from the issue of spare memory.
4782 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4784 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4787 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4789 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4792 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4794 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4796 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4798 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4799 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4801 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
4803 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4805 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
4807 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4808 (x_clipboard_manager_save): Add return value.
4809 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4811 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4812 Obey Vx_select_enable_clipboard_manager. Catch errors in
4813 x_clipboard_manager_save (Bug#8779).
4814 (Vx_select_enable_clipboard_manager): New variable.
4815 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4817 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4819 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4821 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4823 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4824 in the current matrix if keep_current_p is non-zero.
4826 2011-06-04 Eli Zaretskii <eliz@gnu.org>
4828 * bidi.c (bidi_level_of_next_char): Fix last change.
4830 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4832 Support bidi reordering of text covered by display properties.
4834 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4835 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4836 (bidi_cache_search, bidi_cache_iterator_state)
4837 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4838 (bidi_level_of_next_char, bidi_move_to_visually_next):
4839 Support character positions inside a run of characters covered by a
4841 (bidi_paragraph_init, bidi_resolve_explicit_1)
4842 (bidi_level_of_next_char): Call bidi_fetch_char and
4843 bidi_fetch_char_advance instead of FETCH_CHAR and
4845 (bidi_init_it): Initialize new members.
4846 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4848 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4849 instead of using explicit *_CHAR codes.
4850 (bidi_resolve_explicit, bidi_resolve_weak):
4851 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4852 bidirectional text is supported only in multibyte buffers.
4853 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4854 it to initialize the frame_window_p member of struct bidi_it.
4855 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4856 (bidi_resolve_explicit, bidi_resolve_weak)
4857 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4858 bidi_it->nchars is non-positive.
4859 (bidi_level_of_next_char): Don't try to lookup the cache for the
4860 next/previous character if nothing is cached there yet, or if we
4861 were just reseat()'ed to a new position.
4863 * xdisp.c (set_cursor_from_row): Set start and stop points
4864 according to the row's direction when priming the loop that looks
4865 for the glyph on which to display cursor.
4866 (single_display_spec_intangible_p): Function deleted.
4867 (display_prop_intangible_p): Reimplement to call
4868 handle_display_spec instead of single_display_spec_intangible_p.
4869 Accept 3 additional arguments needed by handle_display_spec.
4870 This fixes incorrect cursor motion across display property with complex
4871 values: lists, `(when COND...)' forms, etc.
4872 (single_display_spec_string_p): Support property values that are
4873 lists with the argument STRING its top-level element.
4874 (display_prop_string_p): Fix the condition for processing a
4875 property that is a list to be consistent with handle_display_spec.
4876 (handle_display_spec): New function, refactored from the
4877 last portion of handle_display_prop.
4878 (compute_display_string_pos): Accept additional argument
4879 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4880 value of a `display' property is a "replacing spec".
4881 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4882 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4883 the display property, but just return a value indicating whether
4884 the display property will replace the characters it covers.
4885 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4886 frame_window_p members of struct bidi_it.
4887 (compute_display_string_pos, compute_display_string_end):
4889 (push_it): Accept second argument POSITION, where pop_it should
4890 jump to continue iteration.
4891 (reseat_1): Initialize bidi_it.disp_pos.
4893 * keyboard.c (adjust_point_for_property): Adjust the call to
4894 display_prop_intangible_p to its new signature.
4896 * dispextern.h (struct bidi_it): New member frame_window_p.
4897 (bidi_init_it): Update prototypes.
4898 (display_prop_intangible_p): Update prototype.
4899 (compute_display_string_pos, compute_display_string_end):
4901 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4904 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4906 Malloc failure behavior now depends on size of allocation.
4907 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4908 * lisp.h: Change signatures accordingly.
4909 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4910 All callers changed. (Bug#8762)
4912 * gnutls.c: Use Emacs's memory allocators.
4913 Without this change, the gnutls library would invoke malloc etc.
4914 directly, which causes problems on non-SYNC_INPUT hosts, and which
4915 runs afoul of improving memory_full behavior. (Bug#8761)
4916 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4917 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4918 xfree instead of the default malloc, realloc, free.
4919 (Fgnutls_boot): No need to check for memory allocation failure,
4920 since xmalloc does that for us.
4922 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4923 * category.c (hash_get_category_set):
4924 * ccl.c (ccl_driver):
4925 * charset.c (Fdefine_charset_internal):
4926 * charset.h (struct charset.hash_index):
4927 * composite.c (get_composition_id, gstring_lookup_cache)
4928 (composition_gstring_put_cache):
4929 * composite.h (struct composition.hash_index):
4930 * dispextern.h (struct image.hash):
4931 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4932 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4933 (hashfn_equal, hashfn_user_defined, make_hash_table)
4934 (maybe_resize_hash_table, hash_lookup, hash_put)
4935 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4936 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4937 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4938 * image.c (make_image, search_image_cache, lookup_image)
4939 (xpm_put_color_table_h):
4940 * lisp.h (struct Lisp_Hash_Table):
4941 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4942 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4943 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4944 * alloc.c (allocate_vectorlike):
4945 Check for overflow in vector size calculations.
4946 * ccl.c (ccl_driver):
4947 Check for overflow when converting EMACS_INT to int.
4948 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4949 need to be updated by these changes.
4950 * fns.c (make_hash_table, maybe_resize_hash_table):
4951 Check for integer overflow with large hash tables.
4952 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4953 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4954 (SXHASH_REDUCE): New macro.
4955 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4956 Use it instead of discarding useful hash info with large hash values.
4957 (sxhash_float): New function.
4958 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4959 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4960 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4961 Rewrite to use FIXNUM_BITS, as this simplifies things.
4962 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4963 Adjust signatures to match updated version of code.
4964 (consing_since_gc): Now EMACS_INT, since a single hash table can
4965 use more than INT_MAX bytes.
4967 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4969 Make it possible to build with GCC-4.6+ -O2 -flto.
4971 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4973 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4975 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4976 Call minibuffer-inactive-mode.
4978 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4980 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4981 Update dependencies.
4983 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4985 * data.c (init_data): Remove code for UTS, this system is not
4988 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4990 Don't force ./temacs to start in terminal mode.
4992 * frame.c (make_initial_frame): Initialize faces in all cases, not
4993 only when CANNOT_DUMP is defined.
4994 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4996 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4998 * dispnew.c (add_window_display_history): Use const for the string
4999 pointer. Remove declaration, not needed.
5001 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5003 Use 'inline', not 'INLINE'.
5004 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5005 * alloc.c, fontset.c (INLINE): Remove.
5006 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5007 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5008 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5009 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5010 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5012 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5014 Make it possible to run ./temacs.
5016 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5017 syms_of_callproc does the same thing. Remove test for
5018 "initialized", do it in the caller.
5019 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5021 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5023 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5024 (read_minibuf): Use get_minibuffer.
5025 (syms_of_minibuf): Use DEFSYM.
5026 (Qmetadata): New var.
5027 * data.c (Qbuffer): Don't make it static.
5028 (syms_of_data): Use DEFSYM.
5030 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5032 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5033 (CCL_CODE_MIN): New macro.
5035 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5037 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5039 * eval.c (Qdebug): Now static.
5040 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5041 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5042 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5044 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5046 * image.c: Various fixes to ImageMagick code comments.
5047 (Fimagemagick_types): Doc fix.
5049 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5051 Minor fixes prompted by GCC 4.6.0 warnings.
5053 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5055 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5056 (x_clipboard_manager_save_all): Move extern decl to ...
5057 * xterm.h: ... here, so that it can be checked for consistency.
5059 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5061 * xselect.c (x_clipboard_manager_save_frame)
5062 (x_clipboard_manager_save_all): New functions.
5063 (Fx_clipboard_manager_save): Lisp function deleted.
5065 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5066 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5068 * xterm.h: Update prototype.
5070 2011-05-28 William Xu <william.xwl@gmail.com>
5072 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5075 2011-05-28 Jim Meyering <meyering@redhat.com>
5077 Avoid a sign-extension bug in crypto_hash_function.
5078 * fns.c (to_uchar): Define.
5079 (crypto_hash_function): Use it to convert some newly-signed
5080 variables to unsigned, to avoid sign-extension bugs. For example,
5081 without this change, (md5 "truc") would evaluate to
5082 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5083 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5084 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5086 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5088 Integer overflow fixes.
5090 * dbusbind.c: Serial number integer overflow fixes.
5091 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5092 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5093 to hold a serial number that is too large for a fixnum.
5094 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5095 Check for serial numbers out of range. Decode any serial number
5096 that was so large that it became a float. (Bug#8722)
5098 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5099 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5100 Use XFASTINT rather than XUINT when numbers are nonnegative.
5101 (xd_append_arg, Fdbus_method_return_internal):
5102 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5103 arguments, check that Lisp number is nonnegative, rather than
5104 silently wrapping negative numbers around. (Bug#8722)
5105 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5108 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5110 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5112 ccl: add integer overflow checks
5113 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5114 (IN_INT_RANGE): New macros.
5115 (ccl_driver): Use them to check for integer overflow when
5116 decoding a CCL program. Many of the new checks are whether XINT (x)
5117 fits in int; it doesn't always, on 64-bit hosts. The new version
5118 doesn't catch all possible integer overflows, but it's an
5119 improvement. (Bug#8719)
5121 * alloc.c (make_event_array): Use XINT, not XUINT.
5122 There's no need for unsigned here.
5124 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5125 This follows up to the 2011-05-06 change that substituted uintptr_t
5126 for EMACS_INT. This case wasn't caught back then.
5128 Rework Fformat to avoid integer overflow issues.
5129 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5130 now (part of C89). Include <verify.h>.
5131 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5132 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5133 (Fformat): Avoid the prepass trying to compute sizes; it was only
5134 approximate and thus did not catch overflow reliably. Instead, walk
5135 through the format just once, formatting and computing sizes as we go,
5136 checking for integer overflow at every step, and allocating a larger
5137 buffer as needed. Keep track separately whether the format is
5138 multibyte. Keep only the most-recently calculated precision, rather
5139 than them all. Record whether each argument has been converted to
5140 string. Use EMACS_INT, not int, for byte and char and arg counts.
5141 Support field widths and precisions larger than INT_MAX. Avoid
5142 sprintf's undefined behavior with conversion specifications such as %#d
5143 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5144 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5145 formatting out-of-range floating point numbers with int
5148 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5150 * data.c: Avoid integer truncation in expressions involving floats.
5151 * data.c: Include <intprops.h>.
5152 (arith_driver): When there's an integer overflow in an expression
5153 involving floating point, convert the integers to floating point
5154 so that the resulting value does not suffer from catastrophic
5155 integer truncation. For example, on a 64-bit host (* 4
5156 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5157 Do not rely on undefined behavior after integer overflow.
5159 merge count_size_as_multibyte, parse_str_to_multibyte
5160 * character.c, character.h (count_size_as_multibyte):
5161 Rename from parse_str_to_multibyte; all uses changed.
5162 Check for integer overflow.
5163 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5164 since it's now a duplicate of the other. This is more of
5165 a character than a buffer op, so better that it's in character.c.
5166 * fns.c, print.c: Adjust to above changes.
5168 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5170 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5172 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5174 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5175 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5176 (x_clipboard_manager_save): Now static.
5177 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5179 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5180 (crypto_hash_function): Now static.
5181 Fix pointer signedness problems. Avoid unnecessary initializations.
5183 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5185 * termhooks.h (Vselection_alist): Make it terminal-local.
5187 * terminal.c (create_terminal): Initialize it.
5189 * xselect.c: Support for clipboard managers.
5190 (Vselection_alist): Move to termhooks.h as terminal-local var.
5191 (LOCAL_SELECTION): New macro.
5192 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5193 (symbol_to_x_atom): Remove gratuitous arg.
5194 (x_handle_selection_request, lisp_data_to_selection_data)
5195 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5196 (x_own_selection, x_get_local_selection, x_convert_selection):
5197 New arg, specifying work frame. Use terminal-local Vselection_alist.
5198 (some_frame_on_display): Delete unused function.
5199 (Fx_own_selection_internal, Fx_get_selection_internal)
5200 (Fx_disown_selection_internal, Fx_selection_owner_p)
5201 (Fx_selection_exists_p): New optional frame arg.
5202 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5203 (x_handle_selection_clear): Don't treat other terminals with the
5204 same keyboard specially. Use the terminal-local Vselection_alist.
5205 (x_clear_frame_selections): Use Frun_hook_with_args.
5207 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5209 * xterm.h: Add support for those atoms.
5211 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5213 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5214 (converted_selections, conversion_fail_tag): New global variables.
5215 (x_selection_request_lisp_error): Free the above.
5216 (x_get_local_selection): Remove unnecessary code.
5217 (x_reply_selection_request): Args changed; handle arbitrary array
5218 of converted selections stored in converted_selections.
5219 Separate the XChangeProperty and SelectionNotify steps.
5220 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5221 (x_convert_selection): New function.
5222 (x_handle_selection_event): Simplify.
5223 (x_get_foreign_selection): Don't ignore incoming requests while
5224 waiting for an answer; this will fail when we implement
5225 SAVE_TARGETS, and seems unnecessary anyway.
5226 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5227 (Vx_sent_selection_functions): Doc fix.
5229 2011-05-26 Leo Liu <sdl.web@gmail.com>
5231 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5233 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5235 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5237 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5238 for fringe update if it has periodic bitmap.
5239 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5240 and fringe_bitmap_periodic_p.
5242 * fringe.c (get_fringe_bitmap_data): New function.
5243 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5244 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5245 row. Mark glyph row for fringe update if periodicity changed.
5247 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5248 for fringe update unless it has periodic bitmap.
5250 2011-05-25 Kenichi Handa <handa@m17n.org>
5252 * xdisp.c (get_next_display_element): Set correct it->face_id for
5253 a static composition.
5255 2011-05-24 Leo Liu <sdl.web@gmail.com>
5258 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5260 * fns.c (crypto_hash_function, Fsha1): New function.
5261 (Fmd5): Use crypto_hash_function.
5262 (syms_of_fns): Add Ssha1.
5264 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5266 * gnutls.c: Remove unused macros.
5267 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5268 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5269 Remove macros that are defined and never used.
5270 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5272 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5274 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5275 (Fx_get_selection_internal): Minor cleanup.
5276 (Fx_own_selection_internal): Rename arguments for consistency with
5279 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5281 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5283 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5285 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5287 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5289 * dispnew.c (scrolling_window): Don't exclude the case that the
5290 last enabled row in the desired matrix touches the bottom boundary.
5292 2011-05-21 Glenn Morris <rgm@gnu.org>
5294 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5295 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5296 and add some more files.
5298 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5300 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5301 report_file_error introduced by the change from 2011-05-07.
5303 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5305 * systime.h (Time): Define only if emacs is defined.
5306 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5307 where the include path doesn't have X11/X.h by default. See
5308 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5310 2011-05-20 Kenichi Handa <handa@m17n.org>
5312 * composite.c (find_automatic_composition): Fix previous change.
5314 2011-05-20 Glenn Morris <rgm@gnu.org>
5316 * lisp.mk: New file, split from Makefile.in.
5317 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5318 (shortlisp): Remove.
5319 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5321 2011-05-19 Glenn Morris <rgm@gnu.org>
5323 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5324 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5325 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5326 (lisp): Set the order to that of loadup.el.
5327 (shortlisp): Make it a copy of $lisp.
5328 (SOME_MACHINE_LISP): Remove.
5329 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5330 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5332 2011-05-18 Kenichi Handa <handa@m17n.org>
5334 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5335 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5336 (find_automatic_composition): Mostly rewrite for efficiency.
5338 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5340 * makefile.w32-in: Update dependencies.
5342 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5344 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5345 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5347 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5349 Fix some integer overflow issues, such as string length overflow.
5351 * insdel.c (count_size_as_multibyte): Check for string overflow.
5353 * character.c (lisp_string_width): Check for string overflow.
5354 Use EMACS_INT, not int, for string indexes and lengths; in
5355 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5356 the resulting string length overflows an EMACS_INT; instead,
5357 report a string overflow if no precision given. When checking for
5358 precision exhaustion, use a check that cannot possibly have
5359 integer overflow. (Bug#8675)
5360 * character.h (lisp_string_width): Adjust to new signature.
5362 * alloc.c (string_overflow): New function.
5363 (Fmake_string): Use it. This doesn't change behavior, but saves
5364 a few bytes and will simplify future changes.
5365 * character.c (string_escape_byte8): Likewise.
5366 * lisp.h (string_overflow): New decl.
5368 Fixups, following up to the user-interface timestamp change.
5369 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5370 for UI timestamps, instead of unsigned long.
5371 * msdos.c (mouse_get_pos): Likewise.
5372 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5373 * w32gui.h (Time): Define by including "systime.h" rather than by
5374 declaring it ourselves. (Bug#8664)
5376 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5377 * image.c (clear_image_cache): Likewise.
5379 * term.c (term_mouse_position): Don't assume time_t wraparound.
5381 Be more systematic about user-interface timestamps.
5382 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5383 and sometimes 'EMACS_UINT', to represent these timestamps.
5384 This change causes it to use 'Time' uniformly, as that's what X uses.
5385 This makes the code easier to follow, and makes it easier to catch
5386 integer overflow bugs such as Bug#8664.
5387 * frame.c (Fmouse_position, Fmouse_pixel_position):
5388 Use Time, not unsigned long, for user-interface timestamps.
5389 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5390 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5391 * keyboard.h (last_event_timestamp): Likewise.
5392 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5393 * menu.h (xmenu_show): Likewise.
5394 * term.c (term_mouse_position): Likewise.
5395 * termhooks.h (struct input_event.timestamp): Likewise.
5396 (struct terminal.mouse_position_hook): Likewise.
5397 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5398 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5399 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5400 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5402 * menu.h, termhooks.h: Include "systime.h", for Time.
5404 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5405 Don't assume that the difference between two unsigned long values
5406 can fit into an integer. At this point, we know button_down_time
5407 <= event->timestamp, so the difference must be nonnegative, so
5408 there's no need to cast the result if double-click-time is
5409 nonnegative, as it should be; check that it's nonnegative, just in
5410 case. This bug is triggered when events are more than 2**31 ms
5411 apart (about 25 days). (Bug#8664)
5413 * xselect.c (last_event_timestamp): Remove duplicate decl.
5414 (x_own_selection): Remove needless cast to unsigned long.
5416 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5417 that always fit in int. Use a sentinel instead of a counter, to
5418 avoid a temp and to allay GCC's concerns about possible int overflow.
5419 * frame.h (struct frame): Use int for menu_bar_items_used
5420 instead of EMACS_INT, since it always fits in int.
5422 * menu.c (grow_menu_items): Check for int overflow.
5424 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5426 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5427 Before, the code was not consistent. These values cannot exceed
5428 2**31 - 1 so there's no need to make them unsigned.
5429 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5430 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5431 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5433 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5435 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5436 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5437 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5438 presumably because the widths might not match.
5440 * window.c (size_window): Avoid needless test at loop start.
5442 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5444 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5446 2011-05-12 Drew Adams <drew.adams@oracle.com>
5448 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5450 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5452 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5453 `width' to `bar_area_x' and `bar_area_width', respectively.
5454 (x_scroll_run): Take account of fringe background extension.
5456 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5457 Rename local vars `left' and `width' to `bar_area_x' and
5458 `bar_area_width', respectively.
5459 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5460 background extension.
5462 2011-05-10 Jim Meyering <meyering@redhat.com>
5464 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5466 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5468 * image.c (Finit_image_library): Return t for built-in image types,
5469 like pbm and xbm. (Bug#8640)
5471 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5473 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5475 2011-05-07 Eli Zaretskii <eliz@gnu.org>
5477 * w32console.c (Fset_screen_color): Doc fix.
5478 (Fget_screen_color): New function.
5479 (syms_of_ntterm): Defsubr it.
5481 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5482 unlink the temporary file if Fcall_process didn't create it in the
5484 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5485 child process will be redirected to a file specified with `:file'.
5486 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5487 cue to call_process_cleanup not to close that handle.
5489 2011-05-07 Ben Key <bkey76@gmail.com>
5491 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5492 one of two shell specific rules, either bootstrap-temacs-CMD or
5493 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5494 to the previous implementation of the bootstrap-temacs rule.
5495 The bootstrap-temacs-CMD rule is similar to the previous
5496 implementation of the bootstrap-temacs rule except that it
5497 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5500 These changes, along with some changes to nt/configure.bat,
5501 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5502 earlier fix to add support for --cflags and --ldflags options
5503 that include quotes so that it works whether make uses cmd or
5506 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
5508 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5509 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5511 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5512 a string. Handle both cases.
5513 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5514 (Fdbus_register_method): Use Qinvalid_function.
5516 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5518 * makefile.w32-in: Update dependencies.
5519 (LISP_H): Add inttypes.h and stdin.h.
5520 (PROCESS_H): Add unistd.h.
5522 2011-05-06 Eli Zaretskii <eliz@gnu.org>
5524 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5525 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5527 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
5529 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5531 * term.c (vfatal): Remove stray call to va_end.
5532 It's not needed and the C Standard doesn't allow it here anyway.
5534 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5535 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5537 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5540 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5542 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5544 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5546 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5548 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5550 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5551 * charset.c (Fdefine_charset_internal): Don't initialize
5552 charset.code_space[15]. The value was garbage, on hosts with
5553 32-bit int (Bug#8600).
5555 * lread.c (read_integer): Be more consistent with string-to-number.
5556 Use string_to_number to do the actual conversion; this avoids
5557 rounding errors and fixes some other screwups. Without this fix,
5558 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5559 (digit_to_number): Move earlier, for benefit of read_integer.
5560 Return -1 if the digit is out of range for the base, -2 if it is
5561 not a digit in any supported base. (Bug#8602)
5563 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5565 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5566 to match comment at start of function. This also removes a
5567 GCC warning about overflow in a 32+64-bit port.
5569 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5571 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5572 Reported by Stefan Monnier in
5573 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
5574 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5575 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
5577 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5578 (EMACS_UINTPTR): Likewise, with uintptr_t.
5580 * lisp.h: Prefer 64-bit EMACS_INT if available.
5581 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5582 on 32-bit hosts that have 64-bit int, so that they can access
5584 However, temporarily disable this change unless the temporary
5585 symbol WIDE_EMACS_INT is defined.
5587 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5589 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5590 This removes an assumption that EMACS_INT and long are the same
5591 width as pointers. The assumption is true for Emacs porting targets
5592 now, but we want to make other targets possible.
5593 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5594 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5595 In the rest of the code, change types of integers that hold casted
5596 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5597 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5598 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5599 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5600 No need to cast type when ORing.
5601 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5602 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5603 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5604 assume EMACS_INT is the same width as char *.
5605 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5606 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5607 Remove no-longer-needed casts.
5608 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5609 (xg_tool_bar_help_callback, xg_make_tool_item):
5610 Use EMACS_INTPTR to hold an integer
5611 that will be cast to void *; this can avoid a GCC warning
5612 if EMACS_INT is not the same width as void *.
5613 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5614 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5615 (current_message_1, set_message_1):
5616 Use a local to convert to proper width without a cast.
5617 * xmenu.c (dialog_selection_callback): Likewise.
5619 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5620 Also, don't assume VALBITS / RAND_BITS is less than 5,
5621 and don't rely on undefined behavior when shifting a 1 left into
5623 * lisp.h (get_random): Change signature to match.
5625 * lread.c (hash_string): Use size_t, not int, for hash computation.
5626 Normally we prefer signed values; but hashing is special, because
5627 it's better to use unsigned division on hash table sizes so that
5628 the remainder is nonnegative. Also, size_t is the natural width
5629 for hashing into memory. The previous code used 'int', which doesn't
5630 retain enough info to hash well into very large tables.
5631 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5633 * dbusbind.c: Don't possibly lose pointer info when converting.
5634 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5635 Use XPNTR rather than XHASH, so that the high-order bits of
5636 the pointer aren't lost when converting through void *.
5638 * eval.c (Fautoload): Don't double-shift a pointer.
5640 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5642 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5644 * gnutls.c (DEF_GNUTLS_FN):
5645 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5647 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5649 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5652 2011-05-05 Eli Zaretskii <eliz@gnu.org>
5654 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5655 New version that can reserve upto 2GB of heap space.
5657 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
5659 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5661 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5663 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5664 `gnutls_certificate_set_x509_key_file'.
5666 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
5668 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5669 Update dependencies.
5671 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5673 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5674 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5675 Remove unused parameter `fildes'.
5676 * process.c (read_process_output, send_process): Don't pass it.
5678 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5680 Fix previous change: the library cache is defined in w32.c.
5681 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5682 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5684 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5686 Implement dynamic loading of GnuTLS on Windows.
5688 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5689 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5690 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5693 * gnutls.c (Qgnutls_dll): Define.
5694 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5695 (gnutls_*): Declare function pointers.
5696 (init_gnutls_functions): New function to initialize function pointers.
5697 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5698 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5699 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5700 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5701 (emacs_gnutls_write, emacs_gnutls_read)
5702 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5703 (Fgnutls_available_p): New function.
5704 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5705 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5706 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5708 * image.c: Include w32.h.
5709 (Vimage_type_cache): Delete.
5710 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5711 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5712 (w32_delayed_load): Move to w32.c.
5714 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5716 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5717 (w32_delayed_load): Move from image.c. When loading a library, record
5718 its filename in the :loaded-from property of the library id.
5719 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5720 Initialize and staticpro them.
5721 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5723 * process.c: Include lisp.h before w32.h, not after.
5724 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5725 instead of gnutls_record_check_pending.
5727 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5729 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5731 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5732 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5735 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5737 * xterm.c (x_set_frame_alpha): Do not set property on anything
5738 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5740 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5742 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5744 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5746 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5747 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5748 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5749 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5750 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5751 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5752 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5753 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5754 (Qgnutls_bootprop_callbacks_verify): Make static.
5756 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5758 * callproc.c: Indentation fixup.
5760 * sysdep.c (wait_for_termination_1): Make static.
5761 (wait_for_termination, interruptible_wait_for_termination):
5762 Move after wait_for_termination_1.
5764 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5766 * sysdep.c (interruptible_wait_for_termination): New function
5767 which is like wait_for_termination, but allows keyboard
5770 * callproc.c (Fcall_process): Add (:file "file") as an option for
5772 (Fcall_process_region): Ditto.
5774 2011-04-30 Eli Zaretskii <eliz@gnu.org>
5776 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5777 rather than `XVECTOR (FOO)->size'.
5779 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5780 inttypes.h, as a gnulib replacement is used if it not available in
5783 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5785 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5786 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5787 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5789 * coding.c (coding_alloc_by_realloc): Error out if destination
5790 will grow beyond MOST_POSITIVE_FIXNUM.
5791 (decode_coding_emacs_mule): Abort if there isn't enough place in
5792 charbuf for the composition carryover bytes. Reserve an extra
5793 space for up to 2 characters produced in a loop.
5794 (decode_coding_iso_2022): Abort if there isn't enough place in
5795 charbuf for the composition carryover bytes.
5797 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5799 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5800 aborting when %lld or %lll format is passed.
5801 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5802 %llo or %llx format is passed. (Bug#8545)
5804 * window.c (window_scroll_line_based): Use a marker instead of
5805 simple variables to record original value of point. (Bug#7952)
5807 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5808 produced by %s or %c overflows available buffer space. (Bug#8545)
5810 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5812 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5813 (SIZE_MAX): Move defn after all includes, as they might #define it.
5815 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5817 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5819 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5821 * keyboard.c (Qdelayed_warnings_hook): Define.
5822 (command_loop_1): Run `delayed-warnings-hook'
5823 if Vdelayed_warnings_list is non-nil.
5824 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5825 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5827 2011-04-28 Eli Zaretskii <eliz@gnu.org>
5829 * doprnt.c (doprnt): Don't return value smaller than the buffer
5830 size if the message was truncated. (Bug#8545).
5832 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5834 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5835 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5837 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5839 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5841 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5843 * makefile.w32-in: Update dependencies.
5845 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5847 Improve `doprnt' and its usage. (Bug#8545)
5848 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5849 `format_end'. Remove support for %l as a conversion specifier.
5850 Don't use xrealloc. Improve diagnostics when the %l size modifier
5851 is used. Update the commentary.
5853 * eval.c (verror): Simplify calculation of size_t.
5855 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5858 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5860 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5863 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5865 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5866 This makes this file independent of the recent pseudovector change.
5868 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5870 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5872 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5873 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5874 Remove unused local.
5875 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5877 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5878 GCC 4.6.0 optimizes based on type-based alias analysis.
5879 For example, if b is of type struct buffer * and v of type struct
5880 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5881 != &v->size, and therefore "v->size = 1; b->size = 2; return
5882 v->size;" must therefore return 1. This assumption is incorrect
5883 for Emacs, since it type-puns struct Lisp_Vector * with many other
5884 types. To fix this problem, this patch adds a new type struct
5885 vectorlike_header that documents the constraints on layout of vectors
5886 and pseudovectors, and helps optimizing compilers not get fooled
5887 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5888 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5889 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5891 (XSETPVECTYPE): Rewrite in terms of new macro.
5892 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5893 This is a bit clearer, and further avoids the possibility of
5894 undesirable aliasing.
5895 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5896 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5897 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5898 since Lisp_Subr is a special case (no "next" field).
5899 (ASIZE): Now uses header.size rather than size.
5900 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5901 to avoid the hassle of writing XVECTOR (foo)->header.size.
5902 (struct vectorlike_header): New type.
5903 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5904 object, to help avoid aliasing.
5905 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5906 (SUBRP): Likewise, since Lisp_Subr is a special case.
5907 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5908 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5909 (struct Lisp_Hash_Table): Combine first two members into a single
5910 struct vectorlike_header member. All uses of "size" and "next" members
5911 changed to be "header.size" and "header.next".
5912 * buffer.h (struct buffer): Likewise.
5913 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5914 * frame.h (struct frame): Likewise.
5915 * process.h (struct Lisp_Process): Likewise.
5916 * termhooks.h (struct terminal): Likewise.
5917 * window.c (struct save_window_data, struct saved_window): Likewise.
5918 * window.h (struct window): Likewise.
5919 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5920 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5921 * buffer.c (init_buffer_once): Likewise.
5922 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5924 * process.c (Fformat_network_address): Use local var for size,
5927 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5929 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5930 * data.c (atof): Remove decl; no longer used or needed.
5931 (digit_to_number): Move to lread.c.
5932 (Fstring_to_number): Use new string_to_number function, to be
5933 consistent with how the Lisp reader treats infinities and NaNs.
5934 Do not assume that floating-point numbers represent EMACS_INT
5935 without losing information; this is not true on most 64-bit hosts.
5936 Avoid double-rounding errors, by insisting on integers when
5937 parsing non-base-10 numbers, as the documentation specifies.
5938 * lisp.h (string_to_number): New decl, replacing ...
5939 (isfloat_string): Remove.
5940 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5941 (read1): Do not accept +. and -. as integers; this
5942 appears to have been a coding error. Similarly, do not accept
5943 strings like +-1e0 as floating point numbers. Do not report
5944 overflow for integer overflows unless the base is not 10 which
5945 means we have no simple and reliable way to continue.
5946 Break out the floating-point parsing into a new
5947 function string_to_number, so that Fstring_to_number parses
5948 floating point numbers consistently with the Lisp reader.
5949 (digit_to_number): Move here from data.c. Make it static inline.
5950 (E_CHAR, EXP_INT): Remove, replacing with ...
5951 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5952 (string_to_number): New function, replacing isfloat_string.
5953 This function checks for valid syntax and produces the resulting
5954 Lisp float number too. Rework it so that string-to-number
5955 no longer mishandles examples like "1.0e+". Use strtoumax,
5956 so that overflow for non-base-10 numbers is reported only when
5957 there's no portable and simple way to convert to floating point.
5959 * textprop.c (set_text_properties_1): Rewrite for clarity,
5960 and to avoid GCC warning about integer overflow.
5962 * intervals.h (struct interval): Use EMACS_INT for members
5963 where EMACS_UINT might cause problems. See
5964 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5965 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5966 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5968 (offset_intervals): Tell GCC not to worry about length overflow
5969 when negating a negative length.
5971 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5972 (overrun_check_free): Likewise.
5974 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5975 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5978 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5979 (gnutls_make_error): Rename local to avoid shadowing.
5980 (gnutls_emacs_global_deinit): ifdef out; not used.
5981 (Fgnutls_boot): Use const for pointer to readonly storage.
5982 Comment out unused local. Fix pointer signedness problems.
5984 * lread.c (openp): Don't stuff size_t into an 'int'.
5985 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5986 about possible signed overflow.
5988 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5989 (GDK_KEY_g): Don't define if already defined.
5990 (xg_prepare_tooltip): Avoid pointer signedness problem.
5991 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5993 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5994 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5996 * xfns.c (Fx_window_property): Simplify a bit,
5997 to make a bit faster and to avoid GCC 4.6.0 warning.
5998 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6000 * fns.c (internal_equal): Don't assume size_t fits in int.
6002 * alloc.c (compact_small_strings): Tighten assertion a little.
6004 Replace pEd with more-general pI, and fix some printf arg casts.
6005 * lisp.h (pI): New macro, generalizing old pEd macro to other
6006 conversion specifiers. For example, use "...%"pI"d..." rather
6007 than "...%"pEd"...".
6008 (pEd): Remove. All uses replaced with similar uses of pI.
6009 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6010 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6011 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6012 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6013 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6014 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6015 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6017 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6018 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6019 * print.c (safe_debug_print, print_object): Likewise.
6020 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6022 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6023 avoiding the 0 flag, which is not portable.
6024 * process.c (Fmake_network_process): Use pI to avoid cast.
6025 * region-cache.c (pp_cache): Likewise.
6026 * xdisp.c (decode_mode_spec): Likewise.
6027 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6028 behavior on 64-bit hosts with printf arg.
6029 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6030 (x_stop_queuing_selection_requests): Likewise.
6031 (x_get_window_property): Don't truncate byte count to an 'int'
6034 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6035 here, since it parses constructs like leading '-' and spaces,
6036 which are not wanted; and it overflows with large numbers.
6037 Instead, simply match F[0-9]+, which is what is wanted anyway.
6039 * alloc.c: Remove unportable assumptions about struct layout.
6040 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6041 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6042 (allocate_vectorlike, make_pure_vector): Use the new macros,
6043 plus offsetof, to remove unportable assumptions about struct layout.
6044 These assumptions hold on all porting targets that I know of, but
6045 they are not guaranteed, they're easy to remove, and removing them
6046 makes further changes easier.
6048 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6049 This doesn't fix a bug but makes the code clearer.
6050 (string_overrun_cookie): Now const. Use initializers that
6051 don't formally overflow signed char, to avoid warnings.
6052 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6053 can cause Emacs to crash when string overrun checking is enabled.
6054 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6055 multiple of sizeof (EMACS_INT); it need not be, if
6056 alignof(EMACS_INT) < sizeof (EMACS_INT).
6057 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6059 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6061 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6063 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6065 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6066 supposed to be handshaking. (Bug#8556)
6067 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6069 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6071 * lisp.h (Qdebug): List symbol.
6072 * eval.c (Qdebug): Restore global linkage.
6073 * keyboard.c (debug-on-event): New variable.
6074 (handle_user_signal): Break into debugger when debug-on-event
6075 matches the current signal symbol.
6077 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6079 * alloc.c (check_sblock, check_string_bytes)
6080 (check_string_free_list): Convert to standard C.
6082 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6084 * w32.c (emacs_gnutls_push): Fix typo.
6086 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6088 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6089 "cast to pointer from integer of different size".
6091 Improve doprnt and its use in verror. (Bug#8545)
6092 * doprnt.c (doprnt): Document the set of format control sequences
6093 supported by the function. Use SAFE_ALLOCA instead of always
6096 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6097 is one byte too soon. Don't use xrealloc; instead xfree and
6100 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6102 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6105 * gnutls.c: Renamed global_initialized to
6106 gnutls_global_initialized. Added internals for the
6107 :verify-hostname-error, :verify-error, and :verify-flags
6108 parameters of `gnutls-boot' and documented those parameters in the
6109 docstring. Start callback support.
6110 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6111 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6112 on error. Return error code.
6113 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6114 (emacs_gnutls_read): Likewise.
6115 (Fgnutls_boot): Return handshake error code.
6116 (emacs_gnutls_handle_error): New function.
6117 (wsaerror_to_errno): Likewise.
6119 * w32.h (emacs_gnutls_pull): Add prototype.
6120 (emacs_gnutls_push): Likewise.
6122 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6123 (emacs_gnutls_push): Likewise.
6125 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6127 * process.c (wait_reading_process_output): Check if GnuTLS
6128 buffered some data internally if no FDs are set for TLS
6131 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6132 (LIBS): Link to USER_LIBS.
6133 ($(BLD)/gnutls.$(0)): New target.
6135 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6137 * xdisp.c (handle_single_display_spec): Rename the
6138 display_replaced_before_p argument into display_replaced_p, to
6139 make it consistent with the commentary. Fix typos in the
6142 * textprop.c (syms_of_textprop): Remove dead code.
6143 (copy_text_properties): Delete obsolete commentary about an
6144 interface that was deleted long ago. Fix typos in the description
6147 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6148 to changes in oldXMenu/XMenu.h from 2011-04-16.
6149 <menu_help_message, prev_menu_help_message>: Constify.
6150 (IT_menu_make_room): menu->help_text is now `const char **';
6153 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6154 to changes in oldXMenu/XMenu.h from 2011-04-16.
6155 (struct XMenu): Declare `help_text' `const char **'.
6157 * xfaces.c <Qunspecified>: Make extern again.
6159 * syntax.c: Include sys/types.h before including regex.h, as
6162 * doc.c (get_doc_string): Improve the format passed to `error'.
6164 * doprnt.c (doprnt): Improve commentary.
6166 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6168 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6171 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6172 changes in globals.h immediately force recompilation.
6173 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6174 $(CURDIR)/s/ms-w32.h.
6175 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6177 * character.c (Fchar_direction): Function deleted.
6178 (syms_of_character): Don't defsubr it.
6179 <char-direction-table>: Deleted.
6181 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6183 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6184 * doprnt.c: Include limits.h.
6185 (SIZE_MAX): New macro.
6186 (doprnt): Return a size_t value. 2nd arg is now size_t.
6187 Many local variables are now size_t instead of int or unsigned.
6188 Improve overflow protection. Support `l' modifier for integer
6189 conversions. Support %l conversion. Don't assume an EMACS_INT
6190 argument for integer conversions and for %c.
6192 * lisp.h (doprnt): Restore prototype.
6194 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6197 * Makefile.in (base_obj): Add back doprnt.o.
6199 * deps.mk (doprnt.o): Add back prerequisites.
6200 (callint.o): Depend on character.h.
6202 * eval.c (internal_lisp_condition_case): Include the handler
6203 representation in the error message.
6204 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6205 when breaking from the loop.
6207 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6209 * callint.c (Fcall_interactively): When displaying error message
6210 about invalid control letter, pass the character's codepoint, not
6211 a pointer to its multibyte form. Improve display of the character
6212 in octal and display also its hex code.
6214 * character.c (char_string): Use %x to display the (unsigned)
6215 codepoint of an invalid character, to avoid displaying a bogus
6218 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6219 `error', not SYMBOL_NAME itself.
6221 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6222 character arguments to `error'.
6224 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6225 to `error' in error message about FINAL_CHAR argument. Make sure
6226 FINAL_CHAR is a character, and use %c when it is passed as
6227 argument to `error'.
6229 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6231 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6233 * w32.c: Include <time.h>.
6234 (sys_localtime): New function.
6236 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6238 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6240 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6242 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6244 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6247 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6249 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6250 gl_state.e_property when gl_state.object is Qt.
6252 * insdel.c (make_gap_larger): Remove limitation of buffer size
6255 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6257 * xdisp.c (lookup_glyphless_char_display)
6258 (produce_glyphless_glyph): Handle cons cell entry in
6259 glyphless-char-display.
6260 (Vglyphless_char_display): Document it.
6262 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6263 glyphless-char-display.
6265 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6267 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6269 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6271 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6272 definition for no-X builds.
6274 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6276 Static checks with GCC 4.6.0 and non-default toolkits.
6278 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6280 * process.c (keyboard_bit_set): Define only if SIGIO.
6281 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6282 (send_process): Repair possible setjmp clobbering.
6284 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6286 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6288 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6290 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6291 Define only if needed.
6293 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6294 by pacifying GCC about it. Maybe it's time to retire it?
6295 * xfaces.c (USG, __TIMEVAL__): Likewise.
6297 * dispextern.h (struct redisplay_interface): Rename param
6299 * termhooks.h (struct terminal): Likewise.
6300 * xterm.c (xembed_send_message): Likewise.
6302 * insdel.c (make_gap_smaller): Define only if
6303 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6305 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6308 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6309 so that we aren't warned about unused symbols.
6311 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6313 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6315 * xfns.c (x_real_positions): Mark locals as initialized.
6317 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6319 * xterm.c: Fix problems found by static analysis with other toolkits.
6320 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6321 (x_dispatch_event): Declare static if USE_GTK, and
6322 define if USE_GTK || USE_X_TOOLKIT.
6323 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6324 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6325 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6326 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6328 * xmenu.c (menu_help_callback): Pointer type fixes.
6329 Use const pointers when pointing at readonly data. Avoid pointer
6331 (FALSE): Remove unused macro.
6332 (update_frame_menubar): Remove unused decl.
6334 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6336 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6337 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6338 (single_menu_item): Rename local to avoid shadowing.
6340 * keyboard.c (make_lispy_event): Remove unused local var.
6342 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6343 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6345 * bitmaps: Change bitmaps from unsigned char back to the X11
6346 compatible char. Avoid the old compiler warnings about
6347 out-of-range initializers by using, for example, '\xab' rather
6350 * xgselect.c (xgselect_initialize): Check vs interface
6351 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6353 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6355 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6356 to read-only memory.
6358 * fns.c (vector): Remove; this old hack is no longer needed.
6360 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6362 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6364 * xrdb.c (x_load_resources): Omit unused local.
6366 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6367 (x_window): Rename locals to avoid shadowing.
6368 (USG): Use the kludged USG macro, to pacify gcc.
6370 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6371 (x_term_init): Remove local to avoid shadowing.
6373 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6375 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6376 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6378 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6380 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6382 Fix regex.c, syntax.c and friends for buffers > 2GB.
6383 * syntax.h (struct gl_state_s): Declare character position members
6386 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6388 * textprop.c (verify_interval_modification, interval_of):
6389 Declare arguments EMACS_INT.
6391 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6394 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6396 * indent.c (Fvertical_motion): Local variable it_start is now
6399 * regex.c (re_match, re_match_2, re_match_2_internal)
6400 (bcmp_translate, regcomp, regexec, print_double_string)
6401 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6402 (re_compile_pattern, re_exec): Declare arguments and local
6403 variables `size_t' and `ssize_t' and return values `regoff_t', as
6405 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6406 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6407 <compile_stack_type>: `size' and `avail' are now `size_t'.
6409 * regex.h <regoff_t>: Use ssize_t, not int.
6410 (re_search, re_search_2, re_match, re_match_2): Arguments that
6411 specify buffer/string position and length are now ssize_t and
6412 size_t. Return type is regoff_t.
6414 2011-04-16 Ben Key <bkey76@gmail.com>
6416 * nsfont.m: Fixed bugs in ns_get_family and
6417 ns_descriptor_to_entity that were caused by using free to
6418 deallocate memory blocks that were allocated by xmalloc (via
6419 xstrdup). This caused Emacs to crash when compiled with
6420 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6421 --enable-checking=xmallocoverrun). xfree is now used to
6422 deallocate these memory blocks.
6424 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6426 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6428 emacs_write: Accept and return EMACS_INT for sizes.
6429 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6431 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6432 Accept and return EMACS_INT.
6433 (emacs_gnutls_write): Return the number of bytes written on
6435 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6436 (emacs_read, emacs_write): Remove check for negative size, as the
6437 Emacs source code has been audited now.
6438 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6439 (emacs_read, emacs_write): Use it.
6440 * process.c (send_process): Adjust to the new signatures of
6441 emacs_write and emacs_gnutls_write. Do not attempt to store
6442 a byte offset into an 'int'; it might overflow.
6443 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
6445 * sound.c: Don't assume sizes fit in 'int'.
6446 (struct sound_device.period_size, alsa_period_size):
6447 Return EMACS_INT, not int.
6448 (struct sound_device.write, vox_write, alsa_write):
6449 Accept EMACS_INT, not int.
6450 (wav_play, au_play): Use EMACS_INT to store sizes and to
6451 record read return values.
6453 2011-04-15 Ben Key <bkey76@gmail.com>
6455 * keyboard.c (Qundefined): Don't declare static since it is used
6457 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6458 static since they are used in nsfont.m.
6460 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6462 * process.c (Qprocessp): Don't declare static.
6463 * lisp.h (Qprocessp): Declare again.
6465 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
6467 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6469 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6471 Improve C-level modularity by making more things 'static'.
6473 Don't publish debugger-only interfaces to other modules.
6474 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6475 (verify_bytepos, count_markers): Move decls to the only modules
6477 * region-cache.h (pp_cache): Likewise.
6478 * window.h (check_all_windows): Likewise.
6479 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6481 * sysdep.c (croak): Now static, if
6482 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6483 * syssignal.h (croak): Declare only if not static.
6485 * alloc.c (refill_memory_reserve): Now static if
6486 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6487 * lisp.h (refill_memory_reserve): Declare only if not static.
6489 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6490 Define only if USE_LUCID.
6492 * xrdb.c (x_customization_string, x_rm_string): Now static.
6494 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6495 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6497 * xdisp.c (draw_row_with_mouse_face): Now static.
6498 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6500 * window.h (check_all_windows): Mark externally visible.
6502 * window.c (window_deletion_count): Now static.
6504 * undo.c: Make symbols static if they're not exported.
6505 (last_undo_buffer, last_boundary_position, pending_boundary):
6508 * textprop.c (interval_insert_behind_hooks): Now static.
6509 (interval_insert_in_front_hooks): Likewise.
6511 * term.c: Make symbols static if they're not exported.
6512 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6513 (max_frame_lines, tty_set_terminal_modes):
6514 (tty_reset_terminal_modes, tty_turn_off_highlight):
6515 (get_tty_terminal): Now static.
6516 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6517 * termhooks.h (term_mouse_moveto): Do not declare if
6519 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6520 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6522 * sysdep.c: Make symbols static if they're not exported.
6523 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6525 (sigprocmask_set, full_mask): Remove; unused.
6526 (wait_debugging): Mark as visible.
6527 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6528 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6530 * syntax.c (syntax_temp): Define only if !__GNUC__.
6532 * sound.c (current_sound_device, current_sound): Now static.
6534 * search.c (searchbufs, searchbuf_head): Now static.
6536 * scroll.c (scroll_cost): Remove; unused.
6537 * dispextern.h (scroll_cost): Remove decl.
6539 * region-cache.h (pp_cache): Mark as externally visible.
6541 * process.c: Make symbols static if they're not exported.
6542 (process_tick, update_tick, create_process, chan_process):
6543 (Vprocess_alist, proc_buffered_char, datagram_access):
6544 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6545 (deactivate_process): Mark defn as static, as well as decl.
6546 * lisp.h (create_process): Remove decl.
6547 * process.h (chan_process, Vprocess_alist): Remove decls.
6549 * print.c: Make symbols static if they're not exported.
6550 (print_depth, new_backquote_output, being_printed, print_buffer):
6551 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6552 (print_interval, print_number_index, initial_stderr_stream):
6554 * lisp.h (Fprinc): Remove decl.
6555 (debug_output_compilation_hack): Mark as externally visible.
6557 * sysdep.c (croak): Move decl from here to syssignal.h.
6558 * syssignal.h (croak): Put it here, so the API can be checked when
6559 'croak' is called from dissociate_if_controlling_tty.
6561 * minibuf.c: Make symbols static if they're not exported.
6562 (minibuf_save_list, choose_minibuf_frame): Now static.
6563 * lisp.h (choose_minibuf_frame): Remove decl.
6565 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6567 * lread.c: Make symbols static if they're not exported.
6568 (read_objects, initial_obarray, oblookup_last_bucket_number):
6570 (make_symbol): Remove; unused.
6571 * lisp.h (initial_obarray, make_symbol): Remove decls.
6573 * keyboard.c: Make symbols static if they're not exported.
6574 (single_kboard, recent_keys_index, total_keys, recent_keys):
6575 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6576 (this_single_command_key_start, echoing, last_auto_save):
6577 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6578 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6579 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6580 (Vlispy_mouse_stem, double_click_count):
6582 (force_auto_save_soon): Define only if SIGDANGER.
6583 (ignore_mouse_drag_p): Now static if
6584 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6585 (print_help): Remove; unused.
6586 (stop_character, last_timer_event): Mark as externally visible.
6587 * keyboard.h (ignore_mouse_drag_p): Declare only if
6588 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6589 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6590 * lisp.h (echoing): Remove decl.
6591 (force_auto_save_soon): Declare only if SIGDANGER.
6592 * xdisp.c (redisplay_window): Simplify code, to make it more
6593 obvious that ignore_mouse_drag_p is not accessed if !defined
6594 USE_GTK && !defined HAVE_NS.
6596 * intervals.c: Make symbols static if they're not exported.
6597 (merge_properties_sticky, merge_interval_right, delete_interval):
6599 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6601 * insdel.c: Make symbols static if they're not exported.
6602 However, leave prepare_to_modify_buffer alone. It's never
6603 called from outside this function, but that appears to be a bug.
6604 (combine_after_change_list, combine_after_change_buffer):
6605 (adjust_after_replace, signal_before_change): Now static.
6606 (adjust_after_replace_noundo): Remove; unused.
6607 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
6608 (signal_before_change): Remove decls.
6610 * indent.c (val_compute_motion, val_vmotion): Now static.
6612 * image.c: Make symbols static if they're not exported.
6613 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6615 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6616 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6618 * fringe.c (standard_bitmaps): Now static.
6619 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6621 * frame.c: Make symbols static if they're not exported.
6622 (x_report_frame_params, make_terminal_frame): Now static.
6623 (get_frame_param): Now static, unless HAVE_NS.
6624 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6625 (x_get_resource_string): Remove; not used.
6626 * frame.h (make_terminal_frame, x_report_frame_params):
6627 (x_get_resource_string); Remove decls.
6628 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6629 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6631 * font.c, fontset.c: Make symbols static if they're not exported.
6632 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6633 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6634 * font.c (font_close_object): Now static.
6635 * font.h (font_close_object): Remove.
6636 * fontset.c (FONTSET_OBJLIST): Remove.
6637 (free_realized_fontset) #if-0 the body, which does nothing.
6638 (face_suitable_for_char_p): #if-0, as it's never called.
6639 * fontset.h (face_suitable_for_char_p): Remove decl.
6640 * xfaces.c (face_at_string_position):
6641 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
6642 since 0 is always ASCII.
6644 * fns.c (weak_hash_tables): Now static.
6646 * fileio.c: Make symbols static if they're not exported.
6647 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6648 (Vwrite_region_annotation_buffers): Now static.
6650 * eval.c: Make symbols static if they're not exported.
6651 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6652 * lisp.h (backtrace_list): Remove decl.
6654 * emacs.c: Make symbols static if they're not exported.
6655 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6656 (fatal_error_code, fatal_error_signal_hook, standard_args):
6658 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6659 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6660 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6661 * lisp.h (fatal_error_signal_hook): Remove decl.
6662 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6664 * editfns.c: Move a (normally-unused) function to its only use.
6665 * editfns.c, lisp.h (get_operating_system_release): Remove.
6666 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6667 worth the hassle of breaking this out.
6669 * xterm.c: Make symbols static if they're not exported.
6670 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6671 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6672 (x_destroy_window, x_delete_display):
6674 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6675 (x_mouse_leave): Remove; unused.
6676 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6677 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6678 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6680 (x_mouse_leave): Declare only if WINDOWSNT.
6681 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6682 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6685 * ftxfont.c: Make symbols static if they're not exported.
6686 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6688 * font.h (ftxfont_driver): Likewise.
6690 * xfns.c: Make symbols static if they're not exported.
6691 (x_last_font_name, x_display_info_for_name):
6692 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6693 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6694 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6695 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6696 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6697 (last_show_tip_args): Now static.
6698 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6699 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6700 (x_screen_planes): Remove; unused.
6701 * dispextern.h (x_screen_planes): Remove decl.
6703 * dispnew.c: Make symbols static if they're not exported.
6704 * dispextern.h (redraw_garbaged_frames, scrolling):
6705 (increment_row_positions): Remove.
6706 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6707 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6709 (redraw_garbaged_frames): Remove; unused.
6711 * xfaces.c: Make symbols static if they're not exported.
6712 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6714 * xterm.h (defined_color): Remove decls.
6715 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6716 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6717 (menu_face_changed_default, defined_color, free_realized_face):
6718 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6719 (ascii_face_of_lisp_face): Remove; unused.
6721 * xdisp.c: Make symbols static if they're not exported.
6722 * dispextern.h (scratch_glyph_row, window_box_edges):
6723 (glyph_to_pixel_coords, set_cursor_from_row):
6724 (get_next_display_element, set_iterator_to_next):
6725 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6726 (show_mouse_face): Remove decls
6727 * frame.h (message_buf_print): Likewise.
6728 * lisp.h (pop_message, set_message, check_point_in_composition):
6730 * xterm.h (set_vertical_scroll_bar): Likewise.
6731 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6732 (message_buf_print, scratch_glyph_row, displayed_buffer):
6733 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6734 (get_next_display_element, show_mouse_face, window_box_edges):
6735 (frame_to_window_pixel_xy, check_point_in_composition):
6736 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6737 (glyph_to_pixel_coords): Remove; unused.
6739 * dired.c (file_name_completion): Now static.
6741 * dbusbind.c (xd_in_read_queued_messages): Now static.
6743 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6744 * data.c (circular_list_error): Remove.
6746 * commands.h (last_point_position, last_point_position_buffer):
6747 (last_point_position_window): Remove decls.
6748 * keyboard.c: Make these variables static.
6750 * coding.h (coding, code_convert_region, encode_coding_gap):
6752 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6753 (iso_code_class, detect_coding, code_convert_region): Now static.
6754 (encode_coding_gap): Remove; unused.
6756 * chartab.c (chartab_chars, chartab_bits): Now static.
6758 * charset.h (charset_iso_8859_1): Remove decl.
6759 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6762 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6763 * ccl.c (Vccl_program_table): Now static.
6764 (check_ccl_update): Remove; unused.
6766 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6767 * category.h: ... from here.
6768 * category.c (check_category_table, set_category_set): Now static.
6770 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6771 * lisp.h: Remove these decls.
6773 * buffer.c (buffer_count): Remove unused var.
6775 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6776 so that it's not optimized away.
6777 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6778 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6779 exported only to the debugger.
6781 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
6782 * atimer.h (run_all_atimers): Remove; not exported.
6784 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6785 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6786 was inaccessible from Lisp.
6787 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6788 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6790 alloc.c: Import and export fewer symbols, and remove unused items.
6791 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6793 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6794 it's not optimized away by whole-program optimization.
6795 (message_enable_multibyte, free_misc): Remove.
6796 (catchlist, handlerlist, mark_backtrace):
6797 Declare only if BYTE_MARK_STACK.
6798 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6799 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6800 (message_enable_multibyte): Remove decl.
6801 (free_misc, interval_free_list, float_block, float_block_index):
6802 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6803 (cons_free_list, last_marked_index):
6805 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6806 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6807 (mark_backtrace): Define only if BYTE_MARK_STACK.
6808 * xdisp.c (message_enable_multibyte): Now static.
6810 Declare Lisp_Object Q* variables to be 'static' if not exported.
6811 This makes it easier for human readers (and static analyzers)
6812 to see whether these variables are used from other modules.
6813 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6814 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6815 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6816 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6817 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6818 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6819 * xmenu.c, xselect.c:
6820 Declare Q* vars static if they are not used in other modules.
6821 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6822 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6823 Remove decls of unexported vars.
6824 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6826 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6828 Make Emacs functions such as Fatom 'static' by default.
6829 This makes it easier for human readers (and static analyzers)
6830 to see whether these functions can be called from other modules.
6831 DEFUN now defines a static function. To make the function external
6832 so that it can be used in other C modules, use the new macro DEFUE.
6833 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6834 (Finit_image_library):
6835 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6836 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6837 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6838 Remove decls, since these functions are now static.
6839 (Funintern, Fget_internal_run_time): New decls, since these functions
6840 were already external.
6842 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6843 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6844 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6845 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6846 * keyboard.c, keymap.c, lread.c:
6847 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6848 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6849 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6850 Mark functions with DEFUE instead of DEFUN,
6851 if they are used in other modules.
6852 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6853 decls for now-static functions.
6854 * buffer.h (Fdelete_overlay): Remove decl.
6855 * callproc.c (Fgetenv_internal): Mark as internal.
6856 * composite.c (Fremove_list_of_text_properties): Remove decl.
6857 (Fcomposition_get_gstring): New forward static decl.
6858 * composite.h (Fcomposite_get_gstring): Remove decl.
6859 * dired.c (Ffile_attributes): New forward static decl.
6860 * doc.c (Fdocumntation_property): New forward static decl.
6861 * eval.c (Ffetch_bytecode): New forward static decl.
6862 (Funintern): Remove extern decl; now in .h file where it belongs.
6863 * fileio.c (Fmake_symbolic_link): New forward static decl.
6864 * image.c (Finit_image_library): New forward static decl.
6865 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6866 * intervals.h (Fprevious_property_change):
6867 (Fremove_list_of_text_properties): Remove decls.
6868 * keyboard.c (Fthis_command_keys): Remove decl.
6869 (Fcommand_execute): New forward static decl.
6870 * keymap.c (Flookup_key): New forward static decl.
6871 (Fcopy_keymap): Now static.
6872 * keymap.h (Flookup_key): Remove decl.
6873 * process.c (Fget_process): New forward static decl.
6874 (Fprocess_datagram_address): Mark as internal.
6875 * syntax.c (Fsyntax_table_p): New forward static decl.
6876 (skip_chars): Remove duplicate decl.
6877 * textprop.c (Fprevious_property_change): New forward static decl.
6878 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6880 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6881 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6883 * editfns.c (Fformat): Remove unreachable code.
6885 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6887 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6890 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6892 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6893 when at ZV. (Bug#8487)
6895 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6897 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6899 * keyboard.c (parse_tool_bar_item): Likewise.
6900 * sound.c (sound_cleanup, alsa_close): Likewise.
6901 * termcap.c (tgetent): Likewise.
6902 * xfns.c (x_default_font_parameter): Likewise.
6903 * xsettings.c (read_and_apply_settings): Likewise.
6905 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6906 (overrun_check_free): Protoize.
6908 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6910 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6911 since callers should never pass a negative size.
6912 Change the signature to match that of plain 'read' and 'write'; see
6913 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6914 * lisp.h: Update prototypes of emacs_write and emacs_read.
6916 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6918 * xdisp.c (redisplay_window): Don't try to determine the character
6919 position of the scroll margin if the window start point w->startp
6920 is outside the buffer's accessible region. (Bug#8468)
6922 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6924 Fix write-region and its subroutines for buffers > 2GB.
6925 * fileio.c (a_write, e_write): Modify declaration of arguments and
6926 local variables to support buffers larger than 2GB.
6927 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6929 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6930 argument, local variables, and return value.
6932 * lisp.h: Update prototypes of emacs_write and emacs_read.
6934 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6936 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6938 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6940 Fix more problems found by GCC 4.6.0's static checks.
6942 * xdisp.c (vmessage): Use a better test for character truncation.
6944 * charset.c (load_charset_map): <, not <=, for optimization,
6945 and to avoid potential problems with integer overflow.
6946 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6947 * casetab.c (set_identity, shuffle): Likewise.
6948 * editfns.c (Fformat): Likewise.
6949 * syntax.c (skip_chars): Likewise.
6951 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6952 This also lets GCC 4.6.0 generate slightly better loop code.
6954 * callint.c (Fcall_interactively): <, not <=, for optimization.
6955 (Fcall_interactively): Count the number of arguments produced,
6956 not the number of arguments given. This is simpler and lets GCC
6957 4.6.0 generate slightly better code.
6959 * ftfont.c: Distingish more carefully between FcChar8 and char.
6960 The previous code passed unsigned char * to a functions like
6961 strlen and xstrcasecmp that expect char *, which does not
6962 conform to the C standard.
6963 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6964 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6965 char * when the C standard requires it.
6967 * keyboard.c (read_char): Remove unused var.
6969 * eval.c: Port to Windows vsnprintf (Bug#8435).
6971 (SIZE_MAX): Define if the headers do not.
6972 (verror): Do not give up if vsnprintf returns a negative count.
6973 Instead, grow the buffer. This ports to Windows vsnprintf, which
6974 does not conform to C99. Problem reported by Eli Zaretskii.
6975 Also, simplify the allocation scheme, by avoiding the need for
6976 calling realloc, and removing the ALLOCATED variable.
6978 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6980 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6981 But keep the doprint source code for now, as we might revamp it
6982 and use it again (Bug#8435).
6983 * lisp.h (doprnt): Remove.
6984 * Makefile.in (base_obj): Remove doprnt.o.
6985 * deps.mk (doprnt.o): Remove.
6987 error: Print 32- and 64-bit integers portably (Bug#8435).
6988 Without this change, on typical 64-bit hosts error ("...%d...", N)
6989 was used to print both 32- and 64-bit integers N, which relied on
6991 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6993 * lisp.h (error, verror): Mark as printf-like functions.
6994 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6995 Report overflow in size calculations when allocating printf buffer.
6996 Do not truncate output string at its first null byte.
6997 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6998 Truncate the output at a character boundary, since vsnprintf does not
7000 * charset.c (check_iso_charset_parameter): Convert internal
7001 character to string before calling 'error', since %c now has the
7003 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7004 overflow when computing char to be passed to 'error'. Do not
7005 pass Lisp_Object to 'error'; pass the integer instead.
7006 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7007 formatted with plain %d.
7009 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7011 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7013 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7015 * xterm.c (x_catch_errors): Remove duplicate declaration.
7017 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7019 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7021 2011-04-10 Jim Meyering <meyering@redhat.com>
7023 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7024 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7025 return ssize_t not "int", and use size_t as the buffer length.
7026 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7027 * gnutls.h: Update declarations.
7028 * process.c (read_process_output): Use ssize_t, to match.
7029 (send_process): Likewise.
7031 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7033 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7035 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7037 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7038 Use unsigned char, to match FcChar8 type definition.
7040 * xterm.c (handle_one_xevent):
7041 * xmenu.c (create_and_show_popup_menu):
7042 * xselect.c (x_decline_selection_request)
7043 (x_reply_selection_request): Avoid type-punned deref of X events.
7045 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7047 Fix some uses of `int' instead of EMACS_INT.
7048 * search.c (string_match_1, fast_string_match)
7049 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7050 (scan_buffer, find_next_newline_no_quit)
7051 (find_before_next_newline, search_command, Freplace_match)
7052 (Fmatch_data): Make some `int' variables be EMACS_INT.
7054 * xdisp.c (display_count_lines): 3rd argument and return value now
7055 EMACS_INT. All callers changed.
7056 (pint2hrstr): Last argument is now EMACS_INT.
7058 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7059 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7060 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7061 (decode_coding_utf_16, decode_coding_emacs_mule)
7062 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7063 (decode_coding_ccl, decode_coding_charset)
7064 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7065 (decode_coding_iso_2022, decode_coding_emacs_mule)
7066 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7067 <char_offset, last_offset>: Declare EMACS_INT.
7068 (encode_coding_utf_8, encode_coding_utf_16)
7069 (encode_coding_emacs_mule, encode_invocation_designation)
7070 (encode_designation_at_bol, encode_coding_iso_2022)
7071 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7072 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7074 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7075 (encode_invocation_designation): Last argument P_NCHARS is now
7077 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7078 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7080 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7083 * ccl.c (Fccl_execute_on_string): Declare some variables
7086 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7088 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7090 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7092 * process.c (Fformat_network_address): Doc fix.
7094 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7096 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7098 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7100 * keyboard.c (read_char): Call Lisp function help-form-show,
7101 instead of using internal_with_output_to_temp_buffer.
7102 (Qhelp_form_show): New var.
7103 (syms_of_keyboard): Use DEFSYM macro.
7105 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7107 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7109 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7111 * process.c (Flist_processes): Remove to Lisp.
7112 (list_processes_1): Delete.
7114 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7116 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7118 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7120 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7122 Fix more problems found by GCC 4.6.0's static checks.
7124 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7126 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7128 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7130 * xdisp.c (vmessage): Mark as a printf-like function.
7132 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7134 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7136 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7137 printf-like functions.
7138 (tiff_load): Add casts to remove these marks before passing them
7139 to system-supplied API.
7141 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7143 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7144 This avoids several warnings with gcc -Wstrict-overflow.
7145 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7146 directly, rather than having caller test rule sign. This avoids
7147 some unnecessary tests.
7148 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7149 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7150 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7152 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7153 (xfont_open): Avoid unnecessary tests.
7155 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7157 * composite.h, composite.c (composition_gstring_put_cache):
7158 Use EMACS_INT, not int, for length.
7160 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7161 breaking out part of COMPOSITION_DECODE_RULE.
7162 (COMPOSITION_DECODE_RULE): Use it.
7163 * composite.c (get_composition_id): Remove unused local vars,
7164 by using the new macro.
7166 * textprop.c (set_text_properties_1): Change while to do-while,
7167 since the condition is always true at first.
7169 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7170 (interval_deletion_adjustment): Return unsigned value.
7173 * process.c (list_processes_1, create_pty, read_process_output):
7174 (exec_sentinel): Remove vars that were set but not used.
7175 (create_pty): Remove unnecessary "volatile"s.
7176 (Fnetwork_interface_info): Avoid possibility of int overflow.
7177 (read_process_output): Do adaptive read buffering even if carryover.
7178 (read_process_output): Simplify nbytes computation if buffered.
7180 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7182 * syntax.c (scan_words): Remove var that was set but not used.
7183 (update_syntax_table): Use unsigned instead of int.
7185 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7186 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7187 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7189 * print.c (print_error_message): Avoid int overflow.
7191 * font.c (font_list_entities): Redo for clarity,
7192 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7194 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7195 (font_score): Avoid potential overflow in diff calculation.
7197 * fns.c (substring_both): Remove var that is set but not used.
7198 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7200 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7202 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7203 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7204 can always succeed if overflow has undefined behavior.
7206 * search.c (boyer_moore, wordify): Remove vars set but not used.
7207 (wordify): Omit three unnecessary tests.
7209 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7210 All callers changed. This avoids the need for an unused var.
7212 * casefiddle.c (casify_region): Remove var that is set but not used.
7214 * dired.c (file_name_completion): Remove var that is set but not used.
7216 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7218 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7219 (Finsert_file_contents): Remove unnecessary code checking fd.
7221 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7222 Check for integer overflow on size calculations.
7224 * buffer.c (Fprevious_overlay_change): Remove var that is set
7227 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7228 Remove vars that are set but not used.
7229 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7230 (timer_check_2): Mark vars as initialized.
7232 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7234 * image.c (lookup_image): Remove var that is set but not used.
7235 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7237 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7238 that are set but not used.
7240 * xfns.c (make_invisible_cursor): Don't return garbage
7241 if XCreateBitmapFromData fails (Bug#8410).
7243 * xselect.c (x_get_local_selection, x_handle_property_notify):
7244 Remove vars that are set but not used.
7246 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7247 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7249 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7250 Remove var that is set but not used.
7251 (scroll_bar_windows_size): Now size_t, not int.
7252 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7255 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7256 (map_tty_color) [!defined MSDOS]: Likewise.
7258 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7260 * coding.c: Remove vars that are set but not used.
7261 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7262 All callers changed.
7263 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7264 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7265 (decode_coding_charset): Remove vars that are set but not used.
7267 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7268 that is set but not used.
7270 * print.c (print_object): Remove var that is set but not used.
7272 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7273 The gnulib version avoids calling malloc in the usual case,
7274 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7275 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7276 * filelock.c (current_lock_owner): Likewise.
7277 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7278 * sysdep.c: Include allocator.h, careadlinkat.h.
7279 (emacs_no_realloc_allocator): New static constant.
7280 (emacs_readlink): New function.
7281 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7282 ../lib/careadlinkat.h.
7284 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7286 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7287 first non-nil return value).
7289 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7291 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7292 if not defined (Bug#8403).
7294 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7296 * xdisp.c (display_count_lines): Remove parameter `start',
7297 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7298 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7299 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7300 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7301 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7302 and thereabouts. All callers changed.
7303 (get_per_char_metric): Remove parameter `f', unused since
7304 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7306 2011-04-02 Jim Meyering <meyering@redhat.com>
7308 do not dereference NULL upon failed strdup
7309 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7310 (ns_get_family): Likewise.
7312 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7314 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7316 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7318 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7321 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7323 Add lexical binding.
7325 * window.c (Ftemp_output_buffer_show): New fun.
7326 (Fsave_window_excursion):
7327 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7329 * lread.c (lisp_file_lexically_bound_p): New function.
7330 (Fload): Bind Qlexical_binding.
7331 (readevalloop): Remove `evalfun' arg.
7332 Bind Qinternal_interpreter_environment.
7333 (Feval_buffer): Bind Qlexical_binding.
7334 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7336 (syms_of_lread): Declare `lexical-binding'.
7338 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7340 * keyboard.c (eval_dyn): New fun.
7341 (menu_item_eval_property): Use it.
7343 * image.c (parse_image_spec): Use Ffunctionp.
7345 * fns.c (concat, mapcar1): Accept byte-code-functions.
7347 * eval.c (Fsetq): Handle lexical vars.
7348 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7349 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7350 (FletX, Flet): Obey lexical binding.
7351 (Fcommandp): Handle closures.
7352 (Feval): New `lexical' arg.
7353 (eval_sub): New function extracted from Feval. Use it almost
7354 everywhere where Feval was used. Look up vars in lexical env.
7356 (Ffunctionp): Move from subr.el.
7357 (Ffuncall): Handle closures.
7358 (apply_lambda): Remove `eval_flags'.
7359 (funcall_lambda): Handle closures and new byte-code-functions.
7360 (Fspecial_variable_p): New function.
7361 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7362 but without exporting it to Lisp.
7364 * doc.c (Fdocumentation, store_function_docstring):
7365 * data.c (Finteractive_form): Handle closures.
7367 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7370 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7372 (exec_byte_code): New function extracted from Fbyte_code to handle new
7373 calling convention for byte-code-functions. Add new byte-codes.
7375 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7377 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7379 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7381 * xdisp.c (redisplay_internal): Fix prototype.
7383 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7385 * xdisp.c (SCROLL_LIMIT): New macro.
7386 (try_scrolling): Use it when setting scroll_limit.
7387 Limit scrolling to 100 screen lines.
7388 (redisplay_window): Even when falling back on "recentering",
7389 position point in the window according to scroll-conservatively,
7390 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7392 (try_scrolling): When point is above the window, allow searching
7393 as far as scroll_max, or one screenful, to compute vertical
7394 distance from PT to the scroll margin position. This prevents
7395 try_scrolling from unnecessarily failing when
7396 scroll-conservatively is set to a value slightly larger than the
7397 window height. Clean up the case of PT below the margin at bottom
7398 of window: scroll_max can no longer be INT_MAX. When aggressive
7399 scrolling is in use, don't let point enter the opposite scroll
7400 margin as result of the scroll.
7401 (syms_of_xdisp) <scroll-conservatively>: Document the
7402 threshold of 100 lines for never-recentering scrolling.
7404 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7406 * dispextern.h (move_it_by_lines):
7407 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7408 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7409 (message_log_check_duplicate): Remove parameters `prev_bol' and
7410 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7411 (redisplay_internal): Remove parameter `preserve_echo_area',
7412 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7414 * indent.c (Fvertical_motion):
7415 * window.c (window_scroll_pixel_based, Frecenter):
7416 Don't pass `need_y_p' to `move_it_by_lines'.
7418 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7420 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7421 steal a few bits to be more compact.
7422 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7423 Remove unneeded casts.
7425 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7427 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7429 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7430 binding" message (bug#7967).
7432 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7434 Fix more problems found by GCC 4.6.0's static checks.
7436 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7437 Remove unused local var.
7439 * editfns.c (Fmessage_box): Remove unused local var.
7441 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7442 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7443 Omit unused local vars.
7444 * window.c (shrink_windows): Omit unused local var.
7445 * menu.c (digest_single_submenu): Omit unused local var.
7446 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7447 Omit unused local var.
7449 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7450 Don't assume string length fits in int.
7451 (keyremap_step, read_key_sequence): Use size_t for sizes.
7452 (read_key_sequence): Don't check last_real_key_start redundantly.
7454 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7455 instead of alloca (Bug#8344).
7457 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7458 (Fbacktrace_frame): Don't assume nframes fits in int.
7460 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7462 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7465 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7467 * cm.c (calccost): Turn while-do into do-while, for clarity.
7469 * keyboard.c (syms_of_keyboard): Use the same style as later
7470 in this function when indexing through an array. This also
7471 works around GCC bug 48267.
7473 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7475 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7477 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7478 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7480 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7481 This avoids undefined behavior on integer overflow, and is a bit
7482 more convenient anyway since it is compared to a size_t variable.
7484 Variadic C functions now count arguments with size_t, not int.
7485 This avoids an unnecessary limitation on 64-bit machines, which
7486 caused (substring ...) to crash on large vectors (Bug#8344).
7487 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7488 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7489 All variadic functions and their callers changed accordingly.
7490 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7491 * data.c (arith_driver, float_arith_driver): Likewise.
7492 * editfns.c (general_insert_function): Likewise.
7493 * eval.c (struct backtrace.nargs, interactive_p)
7494 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7495 (funcall_lambda, mark_backtrace): Likewise.
7496 * fns.c (concat): Likewise.
7497 * frame.c (x_set_frame_parameters): Likewise.
7498 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7499 0 if not found, not -1. All callers changed.
7501 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7502 (stack_copy_size): Now size_t, not int.
7503 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7505 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7507 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7508 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7509 All callers changed.
7511 * lisp.h (multibyte_char_to_unibyte):
7512 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7513 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7514 * character.h (CHAR_TO_BYTE8):
7515 * cmds.c (internal_self_insert):
7516 * editfns.c (general_insert_function):
7517 * keymap.c (push_key_description):
7518 * search.c (Freplace_match):
7519 * xdisp.c (message_dolog, set_message_1): All callers changed.
7521 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7523 * keyboard.c (safe_run_hook_funcall): New function.
7524 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7525 don't set the hook to nil, but remove the offending function instead.
7526 (Qcommand_hook_internal): Remove, unused.
7527 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7528 Vcommand_hook_internal.
7530 * eval.c (enum run_hooks_condition): Remove.
7531 (funcall_nil, funcall_not): New functions.
7532 (run_hook_with_args): Call each function through a `funcall' argument.
7533 Remove `cond' argument, now redundant.
7534 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7535 (Frun_hook_with_args_until_failure): Adjust accordingly.
7536 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7538 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7540 * dispextern.h (string_buffer_position): Remove declaration.
7542 * print.c (strout): Remove parameter `multibyte', unused since
7543 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7545 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7546 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7547 All callers changed.
7549 * w32.c (_wsa_errlist): Use braces for struct initializers.
7551 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7552 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7553 All callers changed.
7554 (string_buffer_position): Likewise. Also, make static (it's never
7555 used outside xdisp.c).
7556 (cursor_row_p): Remove parameter `w', unused since
7557 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7558 (decode_mode_spec): Remove parameter `precision', introduced during
7559 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7560 All callers changed.
7562 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7564 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7566 2011-03-27 Anders Lindgren <andlind@gmail.com>
7568 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7569 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7570 (ns_update_auto_hide_menu_bar): New functions.
7571 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7572 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7573 ns_constrain_all_frames.
7574 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7575 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7577 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7579 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7581 2011-03-27 Glenn Morris <rgm@gnu.org>
7583 * syssignal.h: Replace RETSIGTYPE with void.
7584 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7585 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7586 Replace SIGTYPE with void everywhere.
7587 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7588 * s/template.h (SIGTYPE): Remove commented out definition.
7590 2011-03-26 Eli Zaretskii <eliz@gnu.org>
7592 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7593 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7595 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
7597 * w32.c (read_unc_volume): Use parameter `henum', instead of
7598 global variable `wget_enum_handle'.
7600 * keymap.c (describe_vector): Remove parameters `indices' and
7601 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7602 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7604 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7606 * keyboard.c (timer_check): Remove parameter `do_it_now',
7607 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7608 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7609 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7611 * keyboard.c (read_char):
7612 * w32menu.c (w32_menu_display_help):
7613 * xmenu.c (show_help_event, menu_help_callback):
7614 Adjust calls to `show_help_echo'.
7616 * gtkutil.c (xg_maybe_add_timer):
7617 * keyboard.c (readable_events):
7618 * process.c (wait_reading_process_output):
7619 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7621 * insdel.c (adjust_markers_gap_motion):
7622 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7623 (gap_left, gap_right): Don't call it.
7625 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
7627 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7628 incurred during fontification.
7630 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7632 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7633 (DEFVAR_PER_BUFFER): Don't pass it.
7635 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7636 (scrolling_window): Don't pass it.
7638 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7640 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7642 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7644 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7645 of variables specific to SELinux and computation of `encoded_absname'.
7647 * image.c (XPutPixel): Remove unused variable `height'.
7649 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7651 * unexw32.c (get_section_info): Remove unused variable `section'.
7653 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7654 (system_process_attributes): Remove unused variable `sess'.
7655 (sys_read): Remove unused variable `err'.
7657 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7658 (w32_wnd_proc): Remove unused variable `isdead'.
7659 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7660 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7661 (x_create_tip_frame): Remove unused variable `tem'.
7663 * w32inevt.c (w32_console_read_socket):
7664 Remove unused variable `no_events'.
7666 * w32term.c (x_draw_composite_glyph_string_foreground):
7667 Remove unused variable `width'.
7669 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
7671 * w32term.c (x_set_glyph_string_clipping):
7672 Don't pass uninitialized region to CombineRgn.
7674 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
7676 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7677 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7678 (Fx_close_connection): Remove unused variable `i'.
7680 * w32font.c (w32font_draw): Return number of glyphs.
7681 (w32font_open_internal): Remove unused variable `i'.
7682 (w32font_driver): Add missing initializer.
7684 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7685 (fill_in_menu): Remove unused variable `items_added'.
7687 * w32term.c (last_mouse_press_frame): Remove static global variable.
7688 (w32_clip_to_row): Remove unused variable `f'.
7689 (x_delete_terminal): Remove unused variable `i'.
7691 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7692 (NOTHING): Remove unused static global variable.
7693 (uniscribe_check_otf): Remove unused variable `table'.
7694 (uniscribe_font_driver): Add missing initializers.
7696 2011-03-23 Julien Danjou <julien@danjou.info>
7698 * term.c (Fsuspend_tty, Fresume_tty):
7699 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7700 * window.c (temp_output_buffer_show):
7701 * insdel.c (signal_before_change):
7702 * frame.c (Fhandle_switch_frame):
7703 * fileio.c (Fdo_auto_save):
7704 * emacs.c (Fkill_emacs):
7705 * editfns.c (save_excursion_restore):
7706 * cmds.c (internal_self_insert):
7707 * callint.c (Fcall_interactively):
7708 * buffer.c (Fkill_all_local_variables):
7709 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7711 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
7712 unconditionnaly since it does the check itself.
7714 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
7716 Fix more problems found by GCC 4.5.2's static checks.
7718 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7719 the first time through the loop, since we know p0 < p1 then.
7720 This also avoids a gcc -Wstrict-overflow warning.
7722 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7723 leading to a memory leak, possible in functions like
7724 load_charset_map_from_file that can allocate an unbounded number
7725 of objects (Bug#8318).
7727 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7728 that could (at least in theory) be that large.
7730 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7731 This is less likely to overflow, and avoids undefined behavior if
7732 overflow does occur. All callers changed. Use strtoul to scan
7733 for the unsigned long integer.
7734 (pint2hrstr): Simplify and tune code slightly.
7735 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
7737 * scroll.c (do_scrolling): Work around GCC bug 48228.
7738 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7740 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7741 This also avoids a warning with gcc -Wstrict-overflow.
7742 (validate_x_resource_name): Simplify count usage.
7743 This also avoids a warning with gcc -Wstrict-overflow.
7745 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7748 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
7750 * process.c (Fmake_network_process): Use socklen_t, not int,
7751 where POSIX says socklen_t is required in portable programs.
7752 This fixes a porting bug on hosts like 64-bit HP-UX, where
7753 socklen_t is wider than int (Bug#8277).
7754 (Fmake_network_process, server_accept_connection):
7755 (wait_reading_process_output, read_process_output):
7758 * process.c: Rename or move locals to avoid shadowing.
7759 (list_processes_1, Fmake_network_process):
7760 (read_process_output_error_handler, exec_sentinel_error_handler):
7761 Rename or move locals.
7762 (Fmake_network_process): Define label "retry_connect" only if needed.
7763 (Fnetwork_interface_info): Fix pointer signedness.
7764 (process_send_signal): Add cast to avoid pointer signedness problem.
7765 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
7766 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
7768 Make tparam.h and terminfo.c consistent.
7769 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7770 Include tparam.h instead, since it declares them.
7771 * cm.h (PC): Remove extern decl; tparam.h now does this.
7772 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7773 * terminfo.c: Include tparam.h, to check interfaces.
7774 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7775 (tparam): Adjust signature to match interface in tparam.h;
7776 this removes some undefined behavior. Check that outstring and len
7777 are zero, which they always are with Emacs.
7778 * tparam.h (PC, BC, UP): New extern decls.
7780 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
7781 (xftfont_open): Rename locals to avoid shadowing.
7783 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
7784 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7785 (OTF_TAG_SYM): Omit macro if not needed.
7786 (ftfont_list): Remove unused local.
7787 (get_adstyle_property, ftfont_pattern_entity):
7788 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7789 Rename locals to avoid shadowing.
7791 * xfont.c (xfont_list_family): Mark var as initialized.
7793 * xml.c (make_dom): Now static.
7795 * composite.c (composition_compute_stop_pos): Rename local to
7797 (composition_reseat_it): Remove unused locals.
7798 (find_automatic_composition, composition_adjust_point): Likewise.
7799 (composition_update_it): Mark var as initialized.
7800 (find_automatic_composition): Mark vars as initialized,
7801 with a FIXME (Bug#8290).
7803 character.h: Rename locals to avoid shadowing.
7804 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7805 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7806 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7807 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7810 * textprop.c (property_change_between_p): Remove; unused.
7812 * intervals.c (interval_start_pos): Now static.
7814 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7816 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7817 Rename locals to avoid shadowing.
7819 * sound.c (wav_play, au_play, Fplay_sound_internal):
7820 Fix pointer signedness.
7821 (alsa_choose_format): Remove unused local var.
7822 (wav_play): Initialize a variable to 0, to prevent undefined
7823 behavior (Bug#8278).
7825 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7827 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7829 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7830 clobbering (Bug#8298).
7831 * sysdep.c (sys_subshell): Likewise.
7832 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7834 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7835 This should get cleaned up, so that child_setup has the
7836 same signature on all platforms.
7838 * callproc.c (call_process_cleanup): Now static.
7839 (relocate_fd): Rename locals to avoid shadowing.
7841 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7843 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7844 not to be necessary, and produces flickering.
7846 2011-03-20 Glenn Morris <rgm@gnu.org>
7848 * config.in: Remove file.
7850 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7852 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7853 are now in src/globals.h.
7854 (syms_of_minibuf): Remove spurious & from previous change.
7856 2011-03-20 Leo <sdl.web@gmail.com>
7858 * minibuf.c (completing-read-function): New variable.
7859 (completing-read-default): Rename from completing-read.
7860 (completing-read): Call completing-read-function.
7862 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7864 * xfaces.c (Fx_load_color_file):
7865 Read color file from absolute filename (bug#8250).
7867 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7869 * makefile.w32-in: Update dependencies.
7871 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7873 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7875 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7877 Fix more problems found by GCC 4.5.2's static checks.
7879 * process.c (make_serial_process_unwind, send_process_trap):
7880 (sigchld_handler): Now static.
7882 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7883 That way, the code declares only the vars that it needs.
7884 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7885 * s/cygwin.h (PTY_ITERATION): Likewise.
7886 * s/darwin.h (PTY_ITERATION): Likewise.
7887 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7889 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7890 * process.c (allocate_pty): Don't declare stb unless it's needed.
7892 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7893 (CONSTANTLIM): Remove; unused.
7894 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7895 Define only if needed.
7897 * unexelf.c (unexec): Name an expression,
7898 to avoid gcc -Wbad-function-cast warning.
7899 Use a different way to cause a compilation error if anyone uses
7900 n rather than nn, a way that does not involve shadowing.
7901 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7903 * deps.mk (unexalpha.o): Remove; unused.
7905 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7906 * unexec.h: New file.
7907 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7908 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7910 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7911 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7912 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7913 Change as necessary to match prototype in unexec.h.
7915 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7917 (back_comment, skip_chars): Mark vars as initialized.
7919 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7920 Rename locals to avoid shadowing.
7922 * lread.c (read1): Rewrite so as not to use empty "else".
7923 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7925 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7927 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7928 warning when compiling print.c.
7930 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7931 instead of using an uninitialized var.
7932 (font_sort_entities): Mark var as initialized.
7934 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7936 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7937 pointers to constants.
7938 (font_parse_fcname): Remove unused vars.
7939 (font_delete_unmatched): Now static.
7940 (font_get_spec): Remove; unused.
7941 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7942 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7943 Rename or move locals to avoid shadowing.
7945 * fns.c (require_nesting_list, require_unwind): Now static.
7946 (Ffillarray): Rename locals to avoid shadowing.
7948 * floatfns.c (domain_error2): Define only if needed.
7949 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7951 * alloc.c (mark_backtrace): Move decl from here ...
7952 * lisp.h: ... to here, so that it can be checked.
7954 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7955 (Fdefvar): Rewrite so as not to use empty "else".
7956 (lisp_indirect_variable): Name an expression,
7957 to avoid gcc -Wbad-function-cast warning.
7958 (Fdefvar): Rename locals to avoid shadowing.
7960 * callint.c (quotify_arg, quotify_args): Now static.
7961 (Fcall_interactively): Rename locals to avoid shadowing.
7962 Use const pointer when appropriate.
7964 * lisp.h (get_system_name, get_operating_system_release):
7965 Move decls here, to check interfaces.
7966 * process.c (get_operating_system_release): Move decl to lisp.h.
7967 * xrdb.c (get_system_name): Likewise.
7968 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7969 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7970 some of which prompt warnings from gcc -Wbad-function-cast.
7971 (Fformat_time_string, Fencode_time, Finsert_char):
7972 (Ftranslate_region_internal, Fformat):
7973 Rename or remove local vars to avoid shadowing.
7974 (Ftranslate_region_internal): Mark var as initialized.
7976 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7979 * lisp.h (eassert): Check that the argument compiles, even if
7980 ENABLE_CHECKING is not defined.
7982 * data.c (Findirect_variable): Name an expression, to avoid
7983 gcc -Wbad-function-cast warning.
7984 (default_value, arithcompare, arith_driver, arith_error): Now static.
7985 (store_symval_forwarding): Rename local to avoid shadowing.
7986 (Fmake_variable_buffer_local, Fmake_local_variable):
7987 Mark variables as initialized.
7988 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7990 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7991 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7992 Rename locals to avoid shadowing.
7993 (mark_stack): Move local variables into the #ifdef region where
7995 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7996 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7998 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7999 (GC_STRING_CHARS): Remove; not used.
8000 (Fmemory_limit): Cast sbrk's returned value to char *.
8002 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8003 avoids undefined behavior in theory.
8005 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8007 Use functions, not macros, for up- and down-casing (Bug#8254).
8008 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8009 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8010 to use the following functions instead of these macros.
8011 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8012 EMACS_INT, since callers assume the returned value fits in int.
8013 (upcase1): Likewise, for UPCASE_TABLE.
8014 (uppercasep, lowercasep, upcase): New static inline functions.
8015 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8016 the race-condition problem in the old DOWNCASE.
8018 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8019 Rename locals to avoid shadowing.
8020 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8021 (regex_compile, re_search_2, re_match_2_internal):
8022 Remove unused local vars.
8023 (FREE_VAR): Rewrite so as not to use empty "else",
8024 which gcc can warn about.
8025 (regex_compile, re_match_2_internal): Mark locals as initialized.
8026 (RETALLOC_IF): Define only if needed.
8027 (WORDCHAR_P): Likewise. This one is never needed, but is used
8028 only in a comment talking about a compiler bug, so put inside
8029 the #if 0 of that comment.
8030 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8031 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8034 * search.c (boyer_moore): Rename locals to avoid shadowing.
8035 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8036 (PREV_CHAR_BOUNDARY): Likewise.
8038 * search.c (simple_search): Remove unused var.
8040 * dired.c (compile_pattern): Move decl from here ...
8041 * lisp.h: ... to here, so that it can be checked.
8042 (struct re_registers): New forward decl.
8044 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8046 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8048 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8049 Rename locals to avoid shadowing.
8050 (Fvertical_motion): Mark locals as initialized.
8052 * casefiddle.c (casify_object, casify_region): Now static.
8053 (casify_region): Mark local as initialized.
8055 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8057 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8058 New macros, so that the caller can use some names other than
8059 gcpro1, gcpro2, etc.
8060 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8062 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8063 argument, for consistency with GCPRO2_VAR, etc: it is now the
8064 prefix of the variable, not the variable itself. All uses
8066 * dired.c (directory_files_internal, file_name_completion):
8067 Rename locals to avoid shadowing.
8069 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8070 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8071 dired.c's scmp function, had undefined behavior.
8072 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8073 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8074 * buffer.h: ... to here, because these macros use current_buffer,
8075 and the new implementation with inline functions needs to have
8076 current_buffer in scope now, rather than later when the macros
8078 (downcase, upcase1): New static inline functions.
8079 (DOWNCASE, UPCASE1): Reimplement using these functions.
8080 This avoids undefined behavior in expressions like
8081 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8082 from race conditions in accessing the global variables
8083 case_temp1 and case_temp2.
8084 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8085 * lisp.h (case_temp1, case_temp2): Remove their decls.
8086 * character.h (ASCII_CHAR_P): Move from here ...
8087 * lisp.h: ... to here, so that the inline functions mentioned
8090 * dired.c (directory_files_internal_unwind): Now static.
8092 * fileio.c (file_name_as_directory, directory_file_name):
8093 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8095 (file_name_as_directory): Use const pointers when appropriate.
8096 (Fexpand_file_name): Likewise. In particular, newdir might
8097 point at constant storage, so make it a const pointer.
8098 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8099 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8101 (Fset_file_times, Finsert_file_contents, auto_save_error):
8102 Rename locals to avoid shadowing.
8104 * minibuf.c (choose_minibuf_frame_1): Now static.
8105 (Ftry_completion, Fall_completions): Rename or remove locals
8108 * marker.c (bytepos_to_charpos): Remove; unused.
8110 * lisp.h (verify_bytepos, count_markers): New decls,
8111 so that gcc does not warn that these functions aren't declared.
8113 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8114 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8115 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8116 (copy_text): Remove unused local var.
8118 * filelock.c (within_one_second): Now static.
8119 (lock_file_1): Rename local to avoid shadowing.
8121 * buffer.c (fix_overlays_before): Mark locals as initialized.
8122 (fix_start_end_in_overlays): Likewise. This function should be
8123 simplified by using pointers-to-pointers, but that's a different
8125 (switch_to_buffer_1): Now static.
8126 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8127 (report_overlay_modification): Rename locals to avoid shadowing.
8129 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8130 Fix pointer signedness issue.
8131 (sys_subshell): Mark local as volatile if checking for lint,
8132 to suppress a gcc -Wclobbered warning that does not seem to be right.
8133 (MAXPATHLEN): Define only if needed.
8135 * process.c (serial_open, serial_configure): Move decls from here ...
8136 * systty.h: ... to here, so that they can be checked.
8138 * fns.c (get_random, seed_random): Move extern decls from here ...
8139 * lisp.h: ... to here, so that they can be checked.
8141 * sysdep.c (reset_io): Now static.
8142 (wait_for_termination_signal): Remove; unused.
8144 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8145 (copy_keymap_item, append_key, push_text_char_description):
8147 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8148 (DENSE_TABLE_SIZE): Remove; unused.
8149 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8150 (describe_map_tree):
8151 Rename locals to avoid shadowing.
8153 * keyboard.c: Declare functions static if they are not used elsewhere.
8154 (echo_char, echo_dash, cmd_error, top_level_2):
8155 (poll_for_input, handle_async_input): Now static.
8156 (read_char, kbd_buffer_get_event, make_lispy_position):
8157 (make_lispy_event, make_lispy_movement, apply_modifiers):
8158 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8159 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8160 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8161 (read_key_sequence, read_char): Mark locals as initialized.
8162 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8164 * keyboard.h (make_ctrl_char): New decl.
8165 (mark_kboards): Move decl here ...
8166 * alloc.c (mark_kboards): ... from here.
8168 * lisp.h (force_auto_save_soon): New decl.
8170 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8171 (DEFINE_DUMMY_FUNCTION): New macro.
8172 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8174 (main): Add casts to avoid warnings
8175 if GCC considers string literals to be constants.
8177 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8179 * dbusbind.c: Pointer signedness fixes.
8180 (xd_signature, xd_append_arg, xd_initialize):
8181 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8182 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8183 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8184 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8186 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8187 if GCC considers string literals to be constants.
8188 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8190 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8192 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8193 (print_preprocess, print_object): New macro to fix last change.
8195 * print.c (print_preprocess): Don't forget font objects.
8197 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8199 * emacs.c (USAGE3): Doc fixes.
8201 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8203 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8206 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8208 * lisp.h (VWindow_system, Qfile_name_history):
8209 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8210 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8211 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8213 * w32select.c: Don't #include "keyboard.h".
8214 (run_protected): Add extern declaration for waiting_for_input.
8216 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8217 * w32console.c (detect_input_pending, read_input_pending)
8218 (encode_terminal_code):
8219 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8220 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8221 (w32_system_caret_y, Qfile_name_history):
8222 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8223 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8224 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8225 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8226 * w32proc.c (Qlocal, report_file_error):
8227 * w32term.c (Vwindow_system, updating_frame):
8228 * w32uniscribe.c (initialized, uniscribe_font_driver):
8229 Remove unneeded extern declarations.
8231 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8233 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8235 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8237 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8238 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8239 These macros can no longer be used for assignment.
8241 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8242 Assign struct members directly, instead of using BUF_BEGV etc.
8243 (record_buffer_markers, fetch_buffer_markers): New functions for
8244 recording and fetching special buffer markers.
8245 (set_buffer_internal_1, set_buffer_temp): Use them.
8247 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8249 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8251 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8252 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8254 * xdisp.c (hscroll_window_tree):
8255 (reconsider_clip_changes): Use PT instead of BUF_PT.
8257 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8259 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8260 $(EMACS_ROOT)/lib/intprops.h.
8262 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8264 Fix more problems found by GCC 4.5.2's static checks.
8266 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8267 to unsigned char * to avoid compiler diagnostic.
8268 (xg_free_frame_widgets): Make it clear that a local variable is
8269 needed only if USE_GTK_TOOLTIP.
8270 (gdk_window_get_screen): Make it clear that this macro is needed
8271 only if USE_GTK_TOOLTIP.
8272 (int_gtk_range_get_value): New function, which avoids a diagnostic
8273 from gcc -Wbad-function-cast.
8274 (xg_set_toolkit_scroll_bar_thumb): Use it.
8275 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8276 diagnostic from gcc -Wbad-function-cast.
8277 (get_utf8_string, xg_get_file_with_chooser):
8278 Rename locals to avoid shadowing.
8279 (create_dialog): Move locals to avoid shadowing.
8281 * xgselect.c (xg_select): Remove unused var.
8283 * image.c (four_corners_best): Mark locals as initialized.
8284 (gif_load): Initialize transparent_p to zero (Bug#8238).
8285 Mark another local as initialized.
8286 (my_png_error, my_error_exit): Mark with NO_RETURN.
8288 * image.c (clear_image_cache): Now static.
8289 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8290 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8291 (x_edge_detection): Remove unnecessary cast that
8292 gcc -Wbad-function-cast diagnoses.
8293 (gif_load): Fix pointer signedness.
8294 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8295 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8297 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8299 Improve quality of tests for time stamp overflow.
8300 For example, without this patch (encode-time 0 0 0 1 1
8301 1152921504606846976) returns the obviously-bogus value (-948597
8302 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8303 reports time overflow. See
8304 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8305 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8306 * editfns.c: Include limits.h and intprops.h.
8307 (TIME_T_MIN, TIME_T_MAX): New macros.
8308 (time_overflow): Move earlier, to before first use.
8309 (hi_time, lo_time): New functions, for an accurate test for
8311 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8312 (Fget_internal_run_time): Don't assume time_t fits in int.
8313 (make_time): Use list2 instead of Fcons twice.
8314 (Fdecode_time): More accurate test for out-of-range times.
8315 (check_tm_member): New function.
8316 (Fencode_time): Use it, to test for out-of-range times.
8317 (lisp_time_argument): Don't rely on undefined left-shift and
8318 right-shift behavior when checking for time stamp overflow.
8320 * editfns.c (time_overflow): New function, refactoring common code.
8321 (Fformat_time_string, Fdecode_time, Fencode_time):
8322 (Fcurrent_time_string): Use it.
8324 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8325 * dired.c (make_time): Move to ...
8326 * editfns.c (make_time): ... here.
8327 * systime.h: Note the move.
8329 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8331 * fringe.c (update_window_fringes): Remove unused variables.
8333 * unexmacosx.c (copy_data_segment): Also copy __got section.
8336 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8338 * termcap.c [MSDOS]: Include "msdos.h".
8339 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8340 Constify `char *' arguments and their references according to
8341 prototypes in tparam.h.
8343 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8345 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8346 Adapt all references accordingly.
8348 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8350 2011-03-11 Tom Tromey <tromey@redhat.com>
8352 * buffer.c (syms_of_buffer): Remove obsolete comment.
8354 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8356 * termhooks.h (encode_terminal_code): Declare prototype.
8358 * msdos.c (encode_terminal_code): Don't declare prototype.
8360 * term.c (encode_terminal_code): Now external again, used by
8361 w32console.c and msdos.c.
8363 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8364 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8366 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8368 Fix some minor problems found by GCC 4.5.2's static checks.
8370 * fringe.c (update_window_fringes): Mark locals as initialized
8372 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8374 * alloc.c (mark_fringe_data): Move decl from here ...
8375 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8376 to check its interface.
8377 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8379 * fontset.c (free_realized_fontset): Now static.
8380 (Fset_fontset_font): Rename local to avoid shadowing.
8381 (fontset_font): Mark local as initialized.
8382 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8384 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8386 * xselect.c (x_disown_buffer_selections): Remove; not used.
8387 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8388 (x_own_selection, Fx_disown_selection_internal): Rename locals
8390 (x_handle_dnd_message): Remove local to avoid shadowing.
8392 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8393 so that the caller can use some name other than gcpro1.
8394 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8395 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8396 (Fx_backspace_delete_keys_p):
8397 Use them to avoid shadowing, and rename vars to avoid shadowing.
8398 (x_decode_color, x_set_name, x_window): Now static.
8399 (Fx_create_frame): Add braces to silence GCC warning.
8400 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8401 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8402 Remove unused locals.
8403 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8404 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8405 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8408 * xterm.h (x_mouse_leave): New decl.
8410 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8411 Remove unused functions.
8412 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8413 (x_calc_absolute_position): Now static.
8414 (XTread_socket): Don't define label "out" unless it's used.
8415 Don't declare local "event" unless it's used.
8416 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8417 unless they are used.
8418 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8419 (x_fatal_error_signal): Remove; not used.
8420 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8421 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8422 (x_error_catcher, x_connection_closed, x_error_handler):
8423 (x_error_quitter, xembed_send_message, x_iconify_frame):
8424 (my_log_handler): Rename locals to avoid shadowing.
8425 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8426 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8428 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8429 Rename or move locals to avoid shadowing.
8430 (tty_defined_color, merge_face_heights): Now static.
8431 (free_realized_faces_for_fontset): Remove; not used.
8432 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8433 does not deduce is never used uninitialized.
8434 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8435 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8437 * terminal.c (store_terminal_param): Now static.
8439 * xmenu.c (menu_highlight_callback): Now static.
8440 (set_frame_menubar): Remove unused local.
8441 (xmenu_show): Rename parameter to avoid shadowing.
8442 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8443 since they might point to immutable storage.
8444 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8445 since it's unused otherwise.
8447 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8448 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8449 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8450 avoids a gcc -Wuninitialized diagnostic.
8451 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
8452 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8453 does not deduce are never used uninitialized.
8455 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8457 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8458 * window.c (window_loop, size_window):
8459 (run_window_configuration_change_hook, enlarge_window): Likewise.
8461 * window.c (display_buffer): Now static.
8462 (size_window): Mark variables that gcc -Wuninitialized
8463 does not deduce are never used uninitialized.
8464 * window.h (check_all_windows): New decl, to forestall
8465 gcc -Wmissing-prototypes diagnostic.
8466 * dispextern.h (bidi_dump_cached_states): Likewise.
8468 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8470 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8472 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8473 and to avoid gcc -Wuninitialized warning.
8474 (load_charset_map): Mark variables that gcc -Wuninitialized
8475 does not deduce are never used uninitialized.
8476 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8478 * coding.c (coding_set_source, coding_set_destination):
8479 Use "else { /* comment */ }" rather than "else /* comment */;"
8480 for clarity, and to avoid gcc -Wempty-body warning.
8481 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8482 a block, when the outer 'i' will do.
8483 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8484 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8485 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8486 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8487 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8488 Rename locals to avoid shadowing.
8489 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8490 * coding.c (emacs_mule_char, encode_invocation_designation):
8491 Now static, since they're not used elsewhere.
8492 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8493 (decode_coding_object, encode_coding_object, detect_coding_system):
8494 (decode_coding_emacs_mule): Mark variables that gcc
8495 -Wuninitialized does not deduce are never used uninitialized.
8496 (detect_coding_iso_2022): Initialize a local variable that might
8497 be used uninitialized. Leave a FIXME because it's not clear that
8498 this initialization is needed. (Bug#8211)
8499 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8500 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8501 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8502 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8503 Remove unused macros.
8505 * category.c (hash_get_category_set): Remove unused local var.
8506 (copy_category_table): Now static, since it's not used elsewhere.
8507 * character.c (string_count_byte8): Likewise.
8509 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8510 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8512 * chartab.c (copy_sub_char_table): Now static, since it's not used
8514 (sub_char_table_ref_and_range, char_table_ref_and_range):
8515 Rename locals to avoid shadowing.
8516 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8518 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8519 (BIDI_BOB): Remove unused macro.
8521 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8522 deduce are never used uninitialized.
8523 * term.c (encode_terminal_code): Likewise.
8525 * term.c (encode_terminal_code): Now static. Remove unused local.
8527 * tparam.h: New file.
8528 * term.c, tparam.h: Include it.
8529 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8530 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8531 Move these decls to tparam.h, and make them agree with what
8532 is actually in tparam.c. The previous trick of using incompatible
8533 decls in different modules does not conform to the C standard.
8534 All callers of tparam changed to use tparam's actual API.
8535 * tparam.c (tparam1, tparam, tgoto):
8536 Use const pointers where appropriate.
8538 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8539 * cm.h (struct cm): Likewise.
8540 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8541 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8542 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8543 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8544 (turn_on_face, init_tty): Likewise.
8545 * termchar.h (struct tty_display_info): Likewise.
8547 * term.c (term_mouse_position): Rename local to avoid shadowing.
8549 * alloc.c (mark_ttys): Move decl from here ...
8550 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8552 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8554 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8556 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
8558 * search.c (compile_pattern_1): Remove argument regp, unused since
8559 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8560 (compile_pattern): Don't pass it.
8562 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8564 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8565 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8567 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8569 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8571 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8572 gdk_window_get_screen, gdk_window_get_geometry,
8573 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8574 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8575 (xg_get_pixbuf_from_pixmap): New function.
8576 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8577 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8578 Call xg_get_pixbuf_from_pixmap instead of
8579 gdk_pixbuf_get_from_drawable.
8580 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8581 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8582 (xg_check_special_colors): Use GtkStyleContext and its functions
8584 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8585 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8586 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
8587 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8588 Call gtk_widget_get_preferred_size.
8589 (xg_frame_resized): gdk_window_get_geometry only takes 5
8591 (xg_win_to_widget, xg_event_is_for_menubar):
8592 Call gdk_x11_window_lookup_for_display.
8593 (xg_set_widget_bg): New function.
8594 (delete_cb): New function.
8595 (xg_create_frame_widgets): Connect delete-event to delete_cb.
8596 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8597 (xg_set_background_color): Call xg_set_widget_bg.
8598 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8599 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8600 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8601 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8603 (update_frame_tool_bar): Call gtk_widget_hide.
8604 (xg_initialize): Use GDK_KEY_g.
8606 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8608 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8610 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8611 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8612 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8614 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
8616 * w32xfns.c (select_palette): Check success of RealizePalette against
8617 GDI_ERROR, not zero.
8619 See ChangeLog.11 for earlier changes.
8625 Copyright (C) 2011 Free Software Foundation, Inc.
8627 This file is part of GNU Emacs.
8629 GNU Emacs is free software: you can redistribute it and/or modify
8630 it under the terms of the GNU General Public License as published by
8631 the Free Software Foundation, either version 3 of the License, or
8632 (at your option) any later version.
8634 GNU Emacs is distributed in the hope that it will be useful,
8635 but WITHOUT ANY WARRANTY; without even the implied warranty of
8636 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8637 GNU General Public License for more details.
8639 You should have received a copy of the GNU General Public License
8640 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.