1 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4 If fchown fails to set both uid and gid, try to set just gid,
5 as that is sometimes allowed. Adjust the file's mode to eliminate
6 setuid or setgid bits that are inappropriate if fchown fails.
8 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
10 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
11 to compare Lisp_Objects.
12 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
13 global_gnutls_log_level, don't mistake it for a Lisp_Object.
14 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
16 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
18 * lread.c (read_integer): Unread even EOF character.
19 (read1): Likewise. Properly record start position of symbol.
21 * lread.c (read1): Read `#:' as empty uninterned symbol if no
22 symbol character follows.
24 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
26 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
27 This works around a problem with the previous change to Fcopy_file.
28 Recent glibc declares fchown with __attribute__((warn_unused_result)),
29 and without this change, GCC might complain about discarding
30 fchown's return value.
32 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
34 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
36 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
38 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
40 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
42 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
43 it's used from the C level.
45 * process.c: Use the same condition for POLL_FOR_INPUT in both
46 keyboard.c and process.c (bug#1858).
48 2011-07-09 Lawrence Mitchell <wence@gmx.li>
50 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
51 (Fgnutls_boot): Use it.
53 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
55 * doc.c (Fsubstitute_command_keys): Revert last change.
57 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
59 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
60 quotes the next character, and doesn't affect other longer
63 * lread.c (syms_of_lread): Clarify that is isn't only
64 `eval-buffer' and `eval-defun' that's affected by
65 `lexical-binding' (bug#8460).
67 2011-07-15 Eli Zaretskii <eliz@gnu.org>
69 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
70 bidi redisplay when a line includes both an image and is
73 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
75 Fix minor problems found by static checking.
76 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
77 (elsz): Now a signed constant, not a size_t var. We prefer signed
78 types to unsigned, to avoid integer comparison confusion. Without
79 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
80 "cannot optimize loop, the loop counter may overflow", a symptom
82 * indent.c (Fvertical_motion): Mark locals as initialized.
83 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
85 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
87 * search.c (Fre_search_backward): Mention `case-fold-search' in
88 all the re_search_* functions (bug#8138).
90 * keyboard.c (Fopen_dribble_file): Document when the file is
93 2011-07-14 Eli Zaretskii <eliz@gnu.org>
95 * bidi.c (bidi_dump_cached_states): Fix format of displaying
98 Support bidi reordering of display and overlay strings.
99 * xdisp.c (compute_display_string_pos)
100 (compute_display_string_end): Accept additional argument STRING.
101 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
102 (reseat_to_string): Initialize bidi_it->string.s and
103 bidi_it->string.schars.
104 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
105 NULL (avoids a crash in bidi_paragraph_init). Initialize
107 (init_iterator): Call bidi_init_it only of a valid
108 buffer position was specified. Initialize paragraph_embedding to
110 (reseat_to_string): Initialize the bidi iterator.
111 (display_string): If we need to ignore text properties of
112 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
113 original value of -1 will not work with bidi.)
114 (compute_display_string_pos): First arg is now struct
115 `text_pos *'; all callers changed. Support display properties on
117 (compute_display_string_end): Support display properties on Lisp
119 (init_iterator, reseat_1, reseat_to_string): Initialize the
120 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
121 when iterating on a string not from display properties).
122 (compute_display_string_pos, compute_display_string_end): Fix
123 calculation of the object to scan. Fixes an error when using
125 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
126 base_level_stop; instead, set base_level_stop to BEGV. Fixes
127 crashes in vertical-motion.
128 (next_element_from_buffer): Improve commentary for when
129 the iterator is before prev_stop.
130 (init_iterator): Initialize bidi_p from the default value of
131 bidi-display-reordering, not from buffer-local value. Use the
132 buffer-local value only if initializing for buffer iteration.
133 (handle_invisible_prop): Support invisible properties on strings
134 that are being bidi-reordered.
135 (set_iterator_to_next): Support bidi reordering of C strings and
137 (next_element_from_string): Support bidi reordering of Lisp
139 (handle_stop_backwards): Support Lisp strings as well.
140 (display_string): Support display of R2L glyph rows. Use
141 IT_STRING_CHARPOS when displaying from a Lisp string.
142 (init_iterator): Don't initialize it->bidi_p for strings
144 (reseat_to_string): Initialize it->bidi_p for strings here.
145 (next_element_from_string, next_element_from_c_string)
146 (next_element_from_buffer): Add xassert's for correspondence
147 between IT's object being iterated and it->bidi_it.string
149 (face_before_or_after_it_pos): Support bidi iteration.
150 (next_element_from_c_string): Handle the case of the first string
151 character that is not the first one in the visual order.
152 (get_visually_first_element): New function, refactored from common
153 parts of next_element_from_buffer, next_element_from_string, and
154 next_element_from_c_string.
155 (tool_bar_lines_needed, redisplay_tool_bar)
156 (display_menu_bar): Force left-to-right direction. Add a FIXME
157 comment for making that be controlled by a user option.
158 (push_it, pop_it): Save and restore the state of the
159 bidi iterator. Save and restore the bidi_p flag.
160 (pop_it): Iterate out of display property for string iteration as
162 (iterate_out_of_display_property): Support iteration over strings.
163 (handle_single_display_spec): Set up it->bidi_it for iteration
164 over a display string, and call bidi_init_it.
165 (handle_single_display_spec, next_overlay_string)
166 (get_overlay_strings_1, push_display_prop): Set up the bidi
167 iterator for displaying display or overlay strings.
168 (forward_to_next_line_start): Don't use the shortcut if
170 (back_to_previous_visible_line_start): If handle_display_prop
171 pushed the iterator stack, restore the internal state of the bidi
172 iterator by calling bidi_pop_it same number of times.
173 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
174 and we are bidi-iterating, don't decrement the iterator position;
175 instead, set the first_elt flag in the bidi iterator, to produce
177 (reseat_1): Remove redundant setting of string_from_display_prop_p.
178 (push_display_prop): xassert that we are iterating a buffer.
179 (push_it, pop_it): Save and restore paragraph_embedding member.
180 (handle_single_display_spec, next_overlay_string)
181 (get_overlay_strings_1, reseat_1, reseat_to_string)
182 (push_display_prop): Set up the `unibyte' member of bidi_it.string
183 correctly. Don't assume unibyte strings are not bidi-reordered.
184 (compute_display_string_pos)
185 (compute_display_string_end): Fix handling the case of C string.
186 (push_it, pop_it): Save and restore from_disp_prop_p.
187 (handle_single_display_spec, push_display_prop): Set the
188 from_disp_prop_p flag.
189 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
190 (pop_it): Call iterate_out_of_display_property only if we are
191 popping after iteration over a string that came from a display
192 property. Fix a typo in popping stretch info. Add an assertion
193 for verifying that the iterator position is in sync with the bidi
195 (handle_single_display_spec, get_overlay_strings_1)
196 (push_display_prop): Fix initialization of paragraph direction for
197 string when that of the parent object is not yet determined.
198 (reseat_1): Call bidi_init_it to resync the bidi
199 iterator with IT's position. (Bug#7616)
200 (find_row_edges): If ROW->start.pos gives position
201 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
202 (handle_stop, back_to_previous_visible_line_start, reseat_1):
203 Reset the from_disp_prop_p flag.
204 (SAVE_IT, RESTORE_IT): New macros.
205 (pos_visible_p, face_before_or_after_it_pos)
206 (back_to_previous_visible_line_start)
207 (move_it_in_display_line_to, move_it_in_display_line)
208 (move_it_to, move_it_vertically_backward, move_it_by_lines)
209 (try_scrolling, redisplay_window, display_line): Use them when
210 saving a temporary copy of the iterator and restoring it back.
211 (back_to_previous_visible_line_start, reseat_1)
212 (init_iterator): Empty the bidi cache "stack".
213 (move_it_in_display_line_to): If iterator ended up at
214 EOL, but we never saw any buffer positions smaller than
215 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
216 motion in bidi-reordered lines.
217 (move_it_in_display_line_to): Record prev_method and prev_pos
218 immediately before the call to set_iterator_to_next. Fixes cursor
219 motion in bidi-reordered lines with stretch glyphs and strings
220 displayed in margins. (Bug#8133) (Bug#8867)
221 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
223 (pos_visible_p): Support positions in bidi-reordered lines. Save
224 and restore bidi cache.
226 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
227 (bidi_paragraph_info): Delete unused struct.
228 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
229 (bidi_cache_start): New variable.
230 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
232 (bidi_cache_fetch_state, bidi_cache_search)
233 (bidi_cache_find_level_change, bidi_cache_iterator_state)
234 (bidi_cache_find, bidi_peek_at_next_level)
235 (bidi_level_of_next_char, bidi_find_other_level_edge)
236 (bidi_move_to_visually_next): Compare cache index with
237 bidi_cache_start rather than with zero.
238 (bidi_fetch_char): Accept new argument STRING; all callers
239 changed. Support iteration over a string. Support strings with
240 display properties. Support unibyte strings. Fix the type of
241 `len' according to what STRING_CHAR_AND_LENGTH expects.
242 (bidi_paragraph_init, bidi_resolve_explicit_1)
243 (bidi_resolve_explicit, bidi_resolve_weak)
244 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
245 iteration over a string.
246 (bidi_set_sor_type, bidi_resolve_explicit_1)
247 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
248 can now be zero (for strings); special values 0 and -1 were
249 changed to -1 and -2, respectively.
250 (bidi_char_at_pos): New function.
251 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
252 Call it instead of FETCH_MULTIBYTE_CHAR.
253 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
254 initialized to valid values.
255 (bidi_init_it): Don't initialize charpos and bytepos with invalid
257 (bidi_level_of_next_char): Allow the sentinel "position" to pass
258 the test for valid cached positions. Fix the logic for looking up
259 the sentinel state in the cache. GCPRO the Lisp string we are
261 (bidi_push_it, bidi_pop_it): New functions.
262 (bidi_initialize): Initialize the bidi cache start stack pointer.
263 (bidi_cache_ensure_space): New function, refactored from part of
264 bidi_cache_iterator_state. Don't assume the required size is just
265 one BIDI_CACHE_CHUNK away.
266 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
267 (bidi_count_bytes, bidi_char_at_pos): New functions.
268 (bidi_cache_search): Don't assume bidi_cache_last_idx is
269 always valid if bidi_cache_idx is valid.
270 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
271 is valid if it's going to be used.
272 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
273 (bidi_cache_fetch_state, bidi_cache_search)
274 (bidi_cache_find_level_change, bidi_cache_ensure_space)
275 (bidi_cache_iterator_state, bidi_cache_find)
276 (bidi_find_other_level_edge, bidi_cache_start_stack): All
277 variables related to cache indices are now EMACS_INT.
279 * dispextern.h (struct bidi_string_data): New structure.
280 (struct bidi_it): New member `string'. Make flag members be 1-bit
281 fields, and put them last in the struct.
282 (compute_display_string_pos, compute_display_string_end): Update
284 (bidi_push_it, bidi_pop_it): Add prototypes.
285 (struct iterator_stack_entry): New members bidi_p,
286 paragraph_embedding, and from_disp_prop_p.
287 (struct it): Member bidi_p is now a bit field 1 bit wide.
288 (bidi_shelve_cache, bidi_unshelve_cache): Declare
291 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
292 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
293 and vector-like objects.
295 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
296 cache around display iteration.
298 * window.c (Fwindow_end, window_scroll_pixel_based)
299 (displayed_window_lines, Frecenter): Save and restore the bidi
300 cache around display iteration.
302 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
304 * editfns.c (Fdelete_region): Clarify the use of the named
305 parameters (bug#6788).
307 2011-07-14 Martin Rudalics <rudalics@gmx.at>
309 * indent.c (Fvertical_motion): Set and restore w->pointm when
310 saving and restoring the window's buffer (Bug#9006).
312 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
314 * editfns.c (Fstring_to_char): Clarify just what is returned
315 (bug#6576). Text by Eli Zaretskii.
317 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
319 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
321 2011-07-13 Eli Zaretskii <eliz@gnu.org>
323 * buffer.c (mmap_find): Fix a typo.
325 2011-07-13 Johan Bockgård <bojohan@gnu.org>
327 Fix execution of x selection hooks.
328 * xselect.c (Qx_lost_selection_functions)
329 (Qx_sent_selection_functions): New vars.
330 (syms_of_xselect): DEFSYM them.
331 (x_handle_selection_request): Pass Qx_sent_selection_functions
332 rather than Vx_sent_selection_functions to Frun_hook_with_args.
333 (x_handle_selection_clear,x_clear_frame_selections):
334 Pass Qx_lost_selection_functions rather than
335 Vx_lost_selection_functions to Frun_hook_with_args.
337 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
339 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
340 The old code sometimes used this field without initializing it.
342 * alloc.c (gc_sweep): Don't read past end of array.
343 In theory, the old code could also have corrupted Emacs internals,
344 though it'd be very unlikely.
346 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
348 * character.c (Fcharacterp): Don't advertise optional ignored
351 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
353 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
356 * window.c (Fset_window_start): Doc fix (bug#4199).
357 (Fset_window_hscroll): Ditto.
359 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
361 Fix minor new problems caught by GCC 4.6.1.
362 * term.c (init_tty): Remove unused local.
363 * xsettings.c (store_monospaced_changed): Define this function only
364 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
367 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
369 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
371 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
373 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
374 are the mini-buffer and the echo area (bug#3320).
376 * term.c (init_tty): Remove support for supdup, c10 and perq
377 terminals, which are no longer supported (bug#1482).
379 2011-07-10 Johan Bockgård <bojohan@gnu.org>
381 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
383 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
385 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
386 for non-popups (Bug#3642).
388 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
390 * alloc.c (reset_malloc_hooks): Protoize.
391 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
392 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
393 * cm.c (losecursor): Likewise.
394 * data.c (fmod): Likewise.
395 * dispnew.c (swap_glyphs_in_rows): Likewise.
396 * emacs.c (memory_warning_signal): Likewise.
397 * floatfns.c (float_error): Likewise.
398 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
399 (otf_open, font_otf_capability, generate_otf_features)
400 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
402 * image.c (pbm_read_file): Likewise.
403 * indent.c (string_display_width): Likewise.
404 * intervals.c (check_for_interval, search_for_interval)
405 (inc_interval_count, count_intervals, root_interval)
406 (adjust_intervals_for_insertion, make_new_interval): Likewise.
407 * lread.c (defalias): Likewise.
408 * ralloc.c (r_alloc_check): Likewise.
409 * regex.c (set_image_of_range_1, set_image_of_range)
410 (regex_grow_registers): Likewise.
411 * sysdep.c (strerror): Likewise.
412 * termcap.c (valid_filename_p, tprint, main): Likewise.
413 * tparam.c (main): Likewise.
414 * unexhp9k800.c (run_time_remap, save_data_space)
415 (update_file_ptrs, read_header, write_header, calculate_checksum)
416 (copy_file, copy_rest, display_header): Likewise.
417 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
419 * xdisp.c (check_it): Likewise.
420 * xfaces.c (register_color, unregister_color, unregister_colors):
422 * xfns.c (print_fontset_result): Likewise.
423 * xrdb.c (member, fatal, main): Likewise.
425 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
427 Fix minor problems found by static checking (Bug#9031).
428 * chartab.c (char_table_set_range, map_sub_char_table):
429 Remove unused locals.
430 (uniprop_table): Now static.
431 * composite.c (_work_char): Remove unused static var.
433 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
435 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
437 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
439 * gtkutil.c (qttip_cb): Remove code without function.
441 2011-07-09 Eli Zaretskii <eliz@gnu.org>
443 * w32.c (pthread_sigmask): New stub.
445 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
447 Use pthread_sigmask, not sigprocmask (Bug#9010).
448 sigprocmask is portable only for single-threaded applications, and
449 Emacs can be multi-threaded when it uses GTK.
450 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
452 * callproc.c (Fcall_process):
453 * process.c (create_process):
454 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
455 Use pthread_sigmask, not sigprocmask.
457 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
459 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
460 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
463 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
465 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
466 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
467 (xg_hide_tooltip): Fix comment.
469 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
470 in registerServicesMenuSendTypes.
471 (validRequestorForSendType): Don't check ns_return_types.
473 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
476 2011-07-08 Jason Rumney <jasonr@gnu.org>
478 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
479 frame struct members of non-existent frames (Bug#6284).
481 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
483 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
484 variable firstTime not needed on OSX >= 10.6.
485 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
486 >= 10.5. Use setKnobProportion, setDoubleValue.
488 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
489 (MAC_OS_X_VERSION_10_5): Define if not defined.
490 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
491 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
492 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
494 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
495 cString and lossyCString on OSX >= 10.4
497 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
498 sizeToFit on OSX >= 10.2.
500 * nsimage.m (allocInitFromFile): Don't use deprecated method
501 bestRepresentationForDevice on OSX >= 10.6.
503 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
506 * emacs.c: Declare unexec_init_emacs_zone.
508 * nsgui.h: Fix compiler warning about gnulib redefining verify.
510 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
512 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
513 on svcsMenu (Bug#8842).
515 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
517 (Fns_list_services): Just return Qnil on 10.6, code not working there.
519 * nsterm.m (QUTF8_STRING): Declare.
520 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
521 (validRequestorForSendType): Return type is (id).
522 Change indexOfObjectIdenticalTo to indexOfObject.
523 Check if we have local selection before returning self (Bug#8842).
524 (writeSelectionToPasteboard): Put local selection into paste board
525 if we have a local selection (Bug#8842).
526 (syms_of_nsterm): DEFSYM QUTF8_STRING.
528 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
529 (ns_get_local_selection): Declare.
531 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
533 * keymap.c (describe_map_tree): Don't insert a double newline at
534 the end of the buffer (bug#1169) and return whether we inserted
537 * callint.c (Fcall_interactively): Change "reading args" to
538 "providing args" to try to clarify what it does (bug#1010).
540 2011-07-07 Kenichi Handa <handa@m17n.org>
542 * composite.c (composition_compute_stop_pos): Ignore a static
543 composition starting before CHARPOS (Bug#8915).
545 * xdisp.c (handle_composition_prop): Likewise.
547 2011-07-07 Eli Zaretskii <eliz@gnu.org>
549 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
552 2011-07-07 Kenichi Handa <handa@m17n.org>
554 * character.h (unicode_category_t): New enum type.
556 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
557 (Qchar_code_property_table): New variable.
558 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
559 (UNIPROP_COMPRESSED_FORM_P): New macros.
560 (char_table_ascii): Uncompress the compressed values.
561 (sub_char_table_ref): New arg is_uniprop. Callers changed.
562 Uncompress the compressed values.
563 (sub_char_table_ref_and_range): Likewise.
564 (char_table_ref_and_range): Uncompress the compressed values.
565 (sub_char_table_set): New arg is_uniprop. Callers changed.
566 Uncompress the compressed values.
567 (sub_char_table_set_range): Args changed. Callers changed.
568 (char_table_set_range): Adjuted for the above change.
569 (map_sub_char_table): Delete args default_val and parent. Add arg
570 top. Give decoded values to a Lisp function.
571 (map_char_table): Adjusted for the above change. Give decoded
572 values to a Lisp function. Gcpro more variables.
573 (uniprop_table_uncompress)
574 (uniprop_decode_value_run_length): New functions.
575 (uniprop_decoder, uniprop_decoder_count): New variables.
576 (uniprop_get_decoder, uniprop_encode_value_character)
577 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
579 (uniprop_encoder, uniprop_encoder_count): New variables.
580 (uniprop_get_encoder, uniprop_table)
581 (Funicode_property_table_internal, Fget_unicode_property_internal)
582 (Fput_unicode_property_internal): New functions.
583 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
584 Sunicode_property_table_internal, Sget_unicode_property_internal,
585 and Sput_unicode_property_internal. Defvar_lisp
586 char-code-property-alist.
588 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
589 Vunicode_category_table.
591 * font.c (font_range): Adjusted for the change of
592 Vunicode_category_table.
594 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
596 * m/iris4d.h: Remove file, move contents ...
597 * s/irix6-5.h: ... here.
599 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
601 Remove unportable assumption about struct layout (Bug#8884).
602 * alloc.c (mark_buffer):
603 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
604 (clone_per_buffer_values): Don't assume that
605 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
606 This isn't true in general, and it's particularly not true
607 if Emacs is configured with --with-wide-int.
608 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
609 New macros, used in the buffer.c change.
611 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
613 * xsettings.c: Use both GConf and GSettings if both are available.
614 (store_config_changed_event): Add comment.
615 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
616 (store_tool_bar_style_changed): New functions.
617 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
618 (struct xsettings): Move font inside HAVE_XFT.
619 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
620 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
621 Move inside HAVE_XFT.
622 (something_changed_gsettingsCB): Renamed from something_changedCB.
623 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
625 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
626 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
627 (something_changed_gconfCB): Renamed from something_changedCB.
628 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
629 (parse_settings): Move check for font inside HAVE_XFT.
630 (read_settings, apply_xft_settings): Add comment.
631 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
632 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
633 call store_font_name_changed.
634 (xft_settings_event): Add comment.
635 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
636 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
637 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
638 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
639 (xsettings_initialize): Call init_gsettings last.
640 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
643 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
645 Random fixes. E.g., (random) never returned negative values.
646 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
647 subseconds part to the entropy, as that's a bit more random.
648 Prefer signed to unsigned, since the signedness doesn't matter and
649 in general we prefer signed. When given a limit, use a
650 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
651 latter isn't right if USE_2_TAGS_FOR_INTS.
652 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
653 not 0..VALMASK. Don't discard "excess" bits that random () returns.
655 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
657 * textprop.c (text_property_stickiness):
658 Obey Vtext_property_default_nonsticky.
659 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
660 * w32fns.c (syms_of_w32fns):
661 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
663 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
665 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
666 This is more efficient than Ffile_directory_p and avoids a minor race.
668 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
670 * buffer.c (Foverlay_put): Say what the return value is
673 * fileio.c (barf_or_query_if_file_exists): Check first if the file
674 is a directory before asking whether to use the file name
676 (barf_or_query_if_file_exists): Make the "File is a directory"
677 error be more correct.
679 * fns.c (Frequire): Remove the mention of the .gz files, since
680 that's installation-specific, but keep the mention of
683 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
685 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
686 Report string overflow if the output is too long.
688 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
690 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
691 (syms_of_gnutls): Remove duplicate DEFSYM for
692 Qgnutls_bootprop_verify_hostname_error, an error for
693 Qgnutls_bootprop_verify_error (which is no longer used).
695 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
696 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
697 Also (re)move comments that are misplaced or no longer relevant.
699 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
701 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
703 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
705 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
706 and background color parameters if they have been changed.
708 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
710 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
712 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
714 * xsettings.c (SYSTEM_FONT): Define only when used.
715 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
717 * keymap.c (access_keymap_1): Now static.
719 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
721 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
722 leave any prefix arg for the up event (Bug#1586).
724 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
726 * lread.c (syms_of_lread): Mention single symbols defined by
727 `defvar' or `defconst' (bug#7154).
729 * fns.c (Frequire): Mention .el.gz files (bug#7314).
730 (Frequire): Mention get-load-suffixes.
732 2011-07-02 Martin Rudalics <rudalics@gmx.at>
734 * window.h (window): Remove clone_number slot.
735 * window.c (Fwindow_clone_number, Fset_window_clone_number):
737 (make_parent_window, make_window, saved_window)
738 (Fset_window_configuration, save_window_save): Don't deal with
740 * buffer.c (Qclone_number): Remove declaration.
741 (sort_overlays, overlay_strings): Don't deal with clone numbers.
743 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
745 Add multiple inheritance to keymaps.
746 * keymap.c (Fmake_composed_keymap): New function.
747 (Fset_keymap_parent): Simplify.
748 (fix_submap_inheritance): Remove.
749 (access_keymap_1): New function extracted from access_keymap to handle
750 embedded parents and handle lists of maps.
751 (access_keymap): Use it.
752 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
753 (Fcopy_keymap): Handle embedded parents.
754 (Fcommand_remapping, define_as_prefix): Simplify.
755 (Fkey_binding): Simplify.
756 (syms_of_keymap): Move minibuffer-local-completion-map,
757 minibuffer-local-filename-completion-map,
758 minibuffer-local-must-match-map, and
759 minibuffer-local-filename-must-match-map to Elisp.
760 (syms_of_keymap): Defsubr make-composed-keymap.
761 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
762 (parse_menu_item): Trivial simplification.
764 2011-07-01 Glenn Morris <rgm@gnu.org>
766 * Makefile.in (SETTINGS_LIBS): Fix typo.
768 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
770 * coding.c (Fencode_coding_string): Record the last coding system
771 used, as the function doc string says (bug#8738).
773 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
775 * xsettings.c (store_monospaced_changed): Take new font as arg and
776 check for change against current_mono_font.
777 (EMACS_TYPE_SETTINGS): Remove this and related defines.
778 (emacs_settings_constructor, emacs_settings_get_property)
779 (emacs_settings_set_property, emacs_settings_class_init)
780 (emacs_settings_init, gsettings_obj): Remove.
781 (something_changedCB): New function for HAVE_GSETTINGS.
782 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
783 with value as argument.
784 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
785 g_settings_new (Bug#8967). Do not create gsettings_obj.
786 Remove calls to g_settings_bind. Connect something_changedCB to
789 * xgselect.c: Add defined (HAVE_GSETTINGS).
790 (xgselect_initialize): Ditto.
792 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
793 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
796 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
798 * eval.c (struct backtrace): Simplify and port the data structure.
799 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
800 signed bit field, as this assumption is not portable and it makes
801 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
802 "char debug_on_exit : 1" as this is not portable either; instead,
803 use the portable "unsigned int debug_on_exit : 1". Remove unused
804 member evalargs. Remove obsolete comments about cc bombing out.
806 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
808 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
809 Let HAVE_GSETTINGS override HAVE_GCONF.
810 (store_monospaced_changed): New function.
811 (EMACS_SETTINGS): A new type derived from GObject to handle
812 GSettings notifications.
813 (emacs_settings_constructor, emacs_settings_get_property)
814 (emacs_settings_set_property, emacs_settings_class_init):
816 (gsettings_client, gsettings_obj): New variables.
817 (GSETTINGS_SCHEMA): New define.
818 (something_changedCB): Call store_monospaced_changed.
819 (init_gsettings): New function.
820 (xsettings_initialize): Call init_gsettings.
821 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
824 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
827 2011-06-29 Martin Rudalics <rudalics@gmx.at>
829 * window.c (resize_root_window, grow_mini_window)
830 (shrink_mini_window): Rename Qresize_root_window to
831 Qwindow_resize_root_window and Qresize_root_window_vertically to
832 Qwindow_resize_root_window_vertically.
834 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
836 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
838 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
840 * makefile.w32-in: Redesign dependencies so they reflect more
841 clearly which files are directly included by each source file,
842 and not through other includes.
844 2011-06-27 Martin Rudalics <rudalics@gmx.at>
846 * buffer.c (Qclone_number): Declare static and DEFSYM it.
847 (sort_overlays, overlay_strings): When an overlay's clone number
848 matches the window's clone number process the overlay even if
849 the overlay's window property doesn't match the current window.
851 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
852 (Fwindow_hchild): Rename to Fwindow_left_child.
853 (Fwindow_next): Rename to Fwindow_next_sibling.
854 (Fwindow_prev): Rename to Fwindow_prev_sibling.
855 (resize_window_check): Rename to window_resize_check.
856 (resize_window_apply): Rename to window_resize_apply.
857 (Fresize_window_apply): Rename to Fwindow_resize_apply.
858 (Fdelete_other_windows_internal, resize_frame_windows)
859 (Fsplit_window_internal, Fdelete_window_internal)
860 (grow_mini_window, shrink_mini_window)
861 (Fresize_mini_window_internal): Fix callers accordingly.
863 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
865 * emacsgtkfixed.h: State that this is only used with Gtk+3.
866 (emacs_fixed_set_min_size): Remove.
867 (emacs_fixed_new): Take frame as argument.
869 * emacsgtkfixed.c: State that this is only used with Gtk+3.
870 (_EmacsFixedPrivate): Remove minwidth/height.
872 (emacs_fixed_init): Initialize priv->f.
873 (get_parent_class, emacs_fixed_set_min_size): Remove.
874 (emacs_fixed_new): Set priv->f to argument.
875 (emacs_fixed_get_preferred_width)
876 (emacs_fixed_get_preferred_height): Use min_width/height from
877 frames size_hint to set minimum and natural (Bug#8919).
878 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
879 and use min_width/height from frames size_hint to set
880 min_width/height (Bug#8919).
882 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
883 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
886 2011-06-26 Eli Zaretskii <eliz@gnu.org>
888 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
889 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
892 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
894 * process.c (wait_reading_process_output): Bypass select if
895 waiting for a cell while ignoring keyboard input, and input is
896 pending. Suggested by Jan Djärv (Bug#8869).
898 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
900 Use gnulib's dup2 module instead of rolling our own.
901 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
903 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
905 * dispnew.c (scrolling_window): Before scrolling, turn off a
906 mouse-highlight in the window being scrolled.
908 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
910 Move DEFSYM to lisp.h and use everywhere.
912 * character.h (DEFSYM): Move declaration...
913 * lisp.h (DEFSYM): ...here.
919 * w32select.c: Don't include character.h.
921 * alloc.c (syms_of_alloc):
922 * buffer.c (syms_of_buffer):
923 * bytecode.c (syms_of_bytecode):
924 * callint.c (syms_of_callint):
925 * casefiddle.c (syms_of_casefiddle):
926 * casetab.c (init_casetab_once):
927 * category.c (init_category_once, syms_of_category):
928 * ccl.c (syms_of_ccl):
929 * cmds.c (syms_of_cmds):
930 * composite.c (syms_of_composite):
931 * dbusbind.c (syms_of_dbusbind):
932 * dired.c (syms_of_dired):
933 * dispnew.c (syms_of_display):
934 * doc.c (syms_of_doc):
935 * editfns.c (syms_of_editfns):
936 * emacs.c (syms_of_emacs):
937 * eval.c (syms_of_eval):
938 * fileio.c (syms_of_fileio):
939 * fns.c (syms_of_fns):
940 * frame.c (syms_of_frame):
941 * fringe.c (syms_of_fringe):
942 * insdel.c (syms_of_insdel):
943 * keymap.c (syms_of_keymap):
944 * lread.c (init_obarray, syms_of_lread):
945 * macros.c (syms_of_macros):
946 * msdos.c (syms_of_msdos):
947 * print.c (syms_of_print):
948 * process.c (syms_of_process):
949 * search.c (syms_of_search):
950 * sound.c (syms_of_sound):
951 * syntax.c (init_syntax_once, syms_of_syntax):
952 * terminal.c (syms_of_terminal):
953 * textprop.c (syms_of_textprop):
954 * undo.c (syms_of_undo):
955 * w32.c (globals_of_w32):
956 * window.c (syms_of_window):
957 * xdisp.c (syms_of_xdisp):
958 * xfaces.c (syms_of_xfaces):
959 * xfns.c (syms_of_xfns):
960 * xmenu.c (syms_of_xmenu):
961 * xsettings.c (syms_of_xsettings):
962 * xterm.c (syms_of_xterm): Use DEFSYM.
964 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
966 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
968 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
970 Integer and buffer overflow fixes (Bug#8873).
972 * print.c (printchar, strout): Check for string overflow.
973 (PRINTPREPARE, printchar, strout):
974 Don't set size unless allocation succeeds.
976 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
977 for sizes. Check for string overflow more accurately.
978 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
980 * macros.c: Integer and buffer overflow fixes.
981 * keyboard.h (struct keyboard.kbd_macro_bufsize):
982 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
983 Use ptrdiff_t, not int, for sizes.
984 Don't increment bufsize until after realloc succeeds.
985 Check for size-calculation overflow.
986 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
988 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
990 * lread.c: Integer overflow fixes.
991 (read_integer): Radix is now EMACS_INT, not int,
992 to improve quality of diagnostics for out-of-range radices.
993 Calculate buffer size correctly for out-of-range radices.
994 (read1): Check for integer overflow in radices, and in
996 (read_escape): Avoid int overflow.
997 (Fload, openp, read_buffer_size, read1)
998 (substitute_object_recurse, read_vector, read_list, map_obarray):
999 Use ptrdiff_t, not int, for sizes.
1000 (read1): Use EMACS_INT, not int, for sizes.
1001 Check for size overflow.
1003 * image.c (cache_image): Check for size arithmetic overflow.
1005 * lread.c: Integer overflow issues.
1006 (saved_doc_string_size, saved_doc_string_length)
1007 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1008 Now ptrdiff_t, not int.
1009 (read1): Don't assume doc string length fits in int. Check for
1010 out-of-range doc string lengths.
1011 (read_list): Don't assume file position fits in int.
1012 (read_escape): Check for hex character overflow.
1014 2011-06-22 Leo Liu <sdl.web@gmail.com>
1016 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1017 Move to minibuffer.el.
1019 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1021 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1022 The following patches are for when GLYPH_DEBUG && !XASSERT.
1023 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1024 * dispnew.c (flush_stdout):
1025 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1026 Mark as externally visible.
1027 * dispnew.c (check_window_matrix_pointers): Now static.
1028 * dispnew.c (window_to_frame_vpos):
1029 * xfns.c (unwind_create_frame):
1030 * xterm.c (x_check_font): Remove unused local.
1031 * scroll.c (CHECK_BOUNDS):
1032 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1033 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1034 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1035 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1036 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1038 (debug_method_add): Use va_list and vsprintf rather than relying
1039 on undefined behavior with wrong number of arguments.
1040 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1041 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1042 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1043 since we're not interested in debugging glyphs with old libraries.
1044 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1045 GCC 4.6.0's static checking.
1047 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1049 Integer overflow and signedness fixes (Bug#8873).
1050 A few related buffer overrun fixes, too.
1052 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1054 * dispextern.h (struct face.stipple):
1055 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1056 (x_bitmap_mask, x_allocate_bitmap_record)
1057 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1058 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1059 (x_create_bitmap_from_xpm_data):
1060 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1061 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1063 * xfaces.c (load_pixmap):
1064 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1065 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1066 (.bitmaps_last, struct x_output.icon_bitmap):
1067 Use ptrdiff_t, not int, for bitmap indexes.
1068 (x_allocate_bitmap_record): Check for size overflow.
1069 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1071 Use ptrdiff_t, not int, for overlay counts.
1072 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1073 * editfns.c (overlays_around, get_pos_property):
1074 * textprop.c (get_char_property_and_overlay):
1075 * xdisp.c (next_overlay_change, note_mouse_highlight):
1076 * xfaces.c (face_at_buffer_position):
1077 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1078 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1079 (Fnext_overlay_change, Fprevious_overlay_change)
1080 (mouse_face_overlay_overlaps, Foverlays_in):
1081 Use ptrdiff_t, not int, for sizes.
1082 (overlays_at, overlays_in): Check for size-calculation overflow.
1084 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1086 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1087 (x_session_initialize): Do not assume string length fits in int.
1089 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1090 This is unlikely, but can occur if DPI is outlandish.
1092 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1093 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1095 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1096 * xrdb.c (magic_file_p, search_magic_path):
1097 Omit last arg SUFFIX; it was always 0. All callers changed.
1098 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1100 * xfont.c (xfont_match): Avoid need for strlen.
1102 * xfns.c: Don't assume strlen fits in int.
1103 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1105 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1106 not unsigned long, as we prefer signed integers. All callers changed.
1107 Detect integer overflow in repeat count.
1108 (message_dolog): Don't assume print length fits in 39 bytes.
1109 (display_mode_element): Don't assume strlen fits in int.
1111 * termcap.c: Don't assume sizes fit in int and never overflow.
1112 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1113 (gobble_line): Check for size-calculation overflow.
1115 * minibuf.c (Fread_buffer):
1116 * lread.c (intern, intern_c_string):
1117 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1118 Don't assume string length fits in int.
1120 * keyboard.c (parse_tool_bar_item):
1121 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1123 * font.c: Don't assume string length fits in int.
1124 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1125 Use ptrdiff_t, not int.
1126 (font_intern_prop): Don't assume string length fits in int.
1127 Don't assume integer property fits in fixnum.
1128 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1130 * filelock.c: Fix some buffer overrun and integer overflow issues.
1131 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1132 Reformulate so as not to need the command string.
1133 Invoke gzip -cd rather than gunzip, as it's more portable.
1134 (lock_info_type, lock_file_1, lock_file):
1135 Don't assume pid_t and time_t fit in unsigned long.
1136 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1137 (current_lock_owner): Prefer signed type for sizes.
1138 Use memcpy, not strncpy, where memcpy is what is really wanted.
1139 Don't assume (via atoi) that time_t and pid_t fit in int.
1140 Check for time_t and/or pid_t out of range, e.g., via a network share.
1141 Don't alloca where an auto var works fine.
1143 * fileio.c: Fix some integer overflow issues.
1144 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1145 Don't assume string length fits in int.
1146 (directory_file_name): Don't assume string length fits in long.
1147 (make_temp_name): Don't assume pid fits in int, or that its print
1148 length is less than 20.
1150 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1152 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1154 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1156 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1157 We prefer signed integers, even for size calculations.
1159 * emacs.c: Don't assume string length fits in 'int'.
1160 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1161 (main): Don't invoke strlen when not needed.
1163 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1164 (XD_DEBUG_MESSAGE): Don't waste a byte.
1166 * callproc.c (getenv_internal_1, getenv_internal)
1168 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1170 * lread.c (invalid_syntax): Omit length argument.
1171 All uses changed. This doesn't fix a bug, but it simplifies the
1172 code away from its former Hollerith-constant appearance, and it's
1173 one less 'int' to worry about when looking at integer-overflow issues.
1174 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1176 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1177 This didn't break anything, but it didn't help either.
1178 It's confusing to put a bogus integer in a place where the actual
1179 value does not matter.
1180 (LIST_END_P): Remove unused macro and its bogus comment.
1181 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1183 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1184 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1186 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1187 We prefer signed types, and the value cannot exceed the EMACS_INT
1188 range anyway (because otherwise the length would not be representable).
1189 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1190 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1191 This avoids a GCC warning when WIDE_EMACS_INT.
1193 * indent.c (sane_tab_width): New function.
1194 (current_column, scan_for_column, Findent_to, position_indentation)
1195 (compute_motion): Use it. This is just for clarity.
1196 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1198 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1200 * lisp.h (lint_assume): New macro.
1201 * composite.c (composition_gstring_put_cache):
1202 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1204 * editfns.c, insdel.c:
1205 Omit unnecessary forward decls, to simplify future changes.
1207 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1209 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1211 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1212 Use much-faster test for byte-length change.
1213 Don't assume string byte-length fits in 'int'.
1214 Check that character arg fits in 'int'.
1215 (mapcar1): Declare byte as byte, for clarity.
1217 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1219 * fns.c (concat): Catch string overflow earlier.
1220 Do not rely on integer wraparound.
1222 * dispextern.h (struct it.overlay_strings_charpos)
1223 (struct it.selective): Now EMACS_INT, not int.
1224 * xdisp.c (forward_to_next_line_start)
1225 (back_to_previous_visible_line_start)
1226 (reseat_at_next_visible_line_start, next_element_from_buffer):
1227 Don't arbitrarily truncate the value of 'selective' to int.
1229 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1231 * composite.c: Don't truncate sizes to 'int'.
1232 (composition_gstring_p, composition_reseat_it)
1233 (composition_adjust_point): Use EMACS_INT, not int.
1234 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1235 not EMACS_UINT, for indexes.
1237 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1239 * buffer.c: Include <verify.h>.
1240 (struct sortvec.priority, struct sortstr.priority):
1241 Now EMACS_INT, not int.
1242 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1243 (struct sortstr.size, record_overlay_string)
1244 (struct sortstrlist.size, struct sortlist.used):
1245 Don't truncate size to int.
1246 (record_overlay_string): Check for size-calculation overflow.
1247 (init_buffer_once): Check at compile-time, not run-time.
1249 2011-06-22 Jim Meyering <meyering@redhat.com>
1251 Don't leak an XBM-image-sized buffer
1252 * image.c (xbm_load): Free the image buffer after using it.
1254 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1257 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1258 that Sun C diagnosed.
1259 * fns.c (secure_hash): Fix pointer signedness issue.
1260 * intervals.c (static_offset_intervals): New function.
1261 (offset_intervals): Use it.
1263 2011-06-21 Leo Liu <sdl.web@gmail.com>
1266 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1269 * fns.c (secure_hash): Rename from crypto_hash_function and change
1270 the first arg to accept symbols.
1271 (Fsecure_hash): New primitive.
1272 (syms_of_fns): New symbols.
1274 2011-06-20 Deniz Dogan <deniz@dogan.se>
1276 * process.c (Fset_process_buffer): Clarify return value in
1279 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1281 * dispnew.c (add_window_display_history): Use BVAR.
1283 * xdisp.c (debug_method_add): Use BVAR.
1284 (check_window_end, dump_glyph_matrix, dump_glyph)
1285 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1287 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1290 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1291 check till after the cache is created in init_frame_faces.
1293 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1295 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1297 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1299 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1300 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1301 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1303 Improve buffer-overflow checking (Bug#8873).
1304 * fileio.c (Finsert_file_contents):
1305 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1306 Remove the old (too-loose) buffer overflow checks.
1307 They weren't needed, since make_gap checks for buffer overflow.
1308 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1309 The old code merely checked for Emacs fixnum overflow, and relied
1310 on undefined (wraparound) behavior. The new code avoids undefined
1311 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1313 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1314 Tune. Don't use wider integers than needed. Don't use alloca.
1315 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1317 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1319 * insdel.c, lisp.h (buffer_overflow): New function.
1320 (insert_from_buffer_1, replace_range, replace_range_2):
1321 * insdel.c (make_gap_larger):
1322 * editfns.c (Finsert_char):
1323 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1325 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1327 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1329 Integer overflow and signedness fixes (Bug#8873).
1331 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1332 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1334 * fileio.c: Don't assume EMACS_INT fits in off_t.
1335 (emacs_lseek): New static function.
1336 (Finsert_file_contents, Fwrite_region): Use it.
1337 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1339 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1341 * fns.c: Don't overflow int when computing a list length.
1342 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1343 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1344 truncation on 64-bit hosts. Check for QUIT every
1345 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1346 faster and is responsive enough.
1347 (Flength): Report an error instead of overflowing an integer.
1348 (Fsafe_length): Return a float if the value is not representable
1349 as a fixnum. This shouldn't happen except in contrived situations.
1350 (Fnthcdr, Fsort): Don't assume list length fits in int.
1351 (Fcopy_sequence): Don't assume vector length fits in int.
1353 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1354 (header_size, word_size): New constants.
1355 (allocate_vectorlike): Don't check size overflow here.
1356 (allocate_vector): Check it here instead, since this is the only
1357 caller of allocate_vectorlike that could cause overflow.
1358 Check that the new vector's length is representable as a fixnum.
1360 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1361 The previous code was bogus. For example, next_almost_prime (32)
1362 returned 39, which is undesirable as it is a multiple of 3; and
1363 next_almost_prime (24) returned 25, which is a multiple of 5 so
1364 why was the code bothering to check for multiples of 7?
1366 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1368 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1370 Variadic C functions now count arguments with ptrdiff_t.
1371 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1372 Back then I didn't know that the Emacs coding style prefers signed int.
1373 Also, in the meantime I found a few more instances where arguments
1374 were being counted with int, which may truncate counts on 64-bit
1375 machines, or EMACS_INT, which may be unnecessarily wide.
1376 * lisp.h (struct Lisp_Subr.function.aMANY)
1377 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1378 Arg counts are now ptrdiff_t, not size_t.
1379 All variadic functions and their callers changed accordingly.
1380 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1381 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1382 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1383 * callint.c (Fcall_interactively): Check arg count for overflow,
1384 to avoid potential buffer overrun. Use signed char, not 'int',
1385 for 'varies' array, so that we needn't bother to check its size
1386 calculation for overflow.
1387 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1388 * eval.c (apply_lambda):
1389 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1390 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1391 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1393 * callint.c (Fcall_interactively): Don't use index var as event count.
1395 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1396 * mem-limits.h (SIZE): Remove; no longer used.
1398 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1400 Remove unnecessary casts.
1401 * xterm.c (x_term_init):
1402 * xfns.c (x_set_border_pixel):
1403 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1404 These aren't needed now that we assume ANSI C.
1406 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1407 It's more likely to cause problems (due to unsigned overflow)
1410 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1412 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1414 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1416 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1418 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1420 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1422 GLYPH_CODE_FACE returns EMACS_INT, not int.
1423 * dispextern.h (merge_faces):
1424 * xfaces.c (merge_faces):
1425 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1426 Don't assume EMACS_INT fits in int.
1428 * character.h (CHAR_VALID_P): Remove unused parameter.
1429 * fontset.c, lisp.h, xdisp.c: All uses changed.
1431 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1433 * fns.c (concat): Minor tuning based on overflow analysis.
1434 This doesn't fix any bugs. Use int to hold character, instead
1435 of constantly refetching from Emacs object. Use XFASTINT, not
1436 XINT, for value known to be a character. Don't bother comparing
1437 a single byte to 0400, as it's always less.
1439 * floatfns.c (Fexpt):
1440 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1442 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1445 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1447 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1448 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1449 incorrectly succeed when S was a string, because 4294967386 was
1450 truncated before it was used.
1452 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1453 Otherwise, an out-of-range integer could cause undefined behavior
1456 * composite.c: Use int, not EMACS_INT, for characters.
1457 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1458 EMACS_INT, for values that are known to be in character range.
1459 This doesn't fix any bugs but is the usual style inside Emacs and
1460 may generate better code on 32-bit machines.
1462 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1463 This is for reasons similar to the recent CHAR_STRING fix.
1464 * charset.c (Fencode_char): Check that character arg is actually
1465 a character. Pass an int to ENCODE_CHAR.
1466 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1467 wider than 'int', as a compile-time check to prevent future regressions
1470 * character.c (char_string): Remove unnecessary casts.
1472 Make sure a 64-bit char is never passed to CHAR_STRING.
1473 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1474 by silently ignoring the top 32 bits, allowing some values
1475 that were far too large to be valid characters.
1476 * character.h: Include <verify.h>.
1477 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1478 arguments are no wider than unsigned, as a compile-time check
1479 to prevent future regressions in this area.
1481 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1482 (Fsubst_char_in_region):
1484 * xdisp.c (decode_mode_spec_coding):
1485 Adjust to CHAR_STRING's new requirement.
1486 * editfns.c (Finsert_char, Fsubst_char_in_region):
1487 * fns.c (concat): Check that character args are actually
1488 characters. Without this test, these functions did the wrong
1489 thing with wildly out-of-range values on 64-bit hosts.
1491 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1492 These casts should not be needed on 32-bit hosts, either.
1493 * keyboard.c (read_char):
1494 * lread.c (Fload): Remove casts to unsigned.
1496 * lisp.h (UNSIGNED_CMP): New macro.
1497 This fixes comparison bugs on 64-bit hosts.
1498 (ASCII_CHAR_P): Use it.
1499 * casefiddle.c (casify_object):
1500 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1501 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1502 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1503 * dispextern.h (FACE_FROM_ID):
1504 * keyboard.c (read_char): Use UNSIGNED_CMP.
1506 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1507 not to EMACS_INT, to avoid GCC warning.
1509 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1511 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1512 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1513 isn't needed on 32-bit machines.
1515 * buffer.c (Fgenerate_new_buffer_name):
1516 Use EMACS_INT for count, not int.
1517 (advance_to_char_boundary): Return EMACS_INT, not int.
1519 * data.c (Qcompiled_function): Now static.
1521 * window.c (window_body_lines): Now static.
1523 * image.c (gif_load): Rename local to avoid shadowing.
1525 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1526 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1527 * alloc.c (make_save_value): Integer argument is now of type
1529 (mark_object): Use ptrdiff_t, not int.
1530 * lisp.h (pD): New macro.
1531 * print.c (print_object): Use it.
1533 * alloc.c: Use EMACS_INT, not int, to count objects.
1534 (total_conses, total_markers, total_symbols, total_vector_size)
1535 (total_free_conses, total_free_markers, total_free_symbols)
1536 (total_free_floats, total_floats, total_free_intervals)
1537 (total_intervals, total_strings, total_free_strings):
1538 Now EMACS_INT, not int. All uses changed.
1539 (Fgarbage_collect): Compute overall total using a double, so that
1540 integer overflow is less likely to be a problem. Check for overflow
1541 when converting back to an integer.
1542 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1543 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1544 These were 'int' variables that could overflow on 64-bit hosts;
1545 they were never used, so remove them instead of repairing them.
1546 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
1547 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1548 Previously, this ceilinged at INT_MAX, but that doesn't work on
1550 (allocate_pseudovector): Don't use EMACS_INT when int would do.
1552 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
1553 (allocate_vectorlike): Check for ptrdiff_t overflow.
1554 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1555 when a (possibly-narrower) signed value would do just as well.
1556 We prefer using signed arithmetic, to avoid comparison confusion.
1558 * alloc.c: Catch some string size overflows that we were missing.
1559 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1560 for convenience in STRING_BYTES_MAX.
1561 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1562 The definition here is exact; the one in lisp.h was approximate.
1563 (allocate_string_data): Check for string overflow. This catches
1564 some instances we weren't catching before. Also, it catches
1565 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1566 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1567 and ptrdiff_t and EMACS_INT are both 64 bits.
1569 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1570 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1571 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1573 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1575 * alloc.c (Fmake_string): Check for out-of-range init.
1577 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1579 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1581 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1583 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1584 xg_get_default_scrollbar_width.
1586 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1587 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1588 (style_changed_cb): Call update_theme_scrollbar_width and call
1589 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1590 all frames (Bug#8505).
1591 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1592 Call gtk_window_set_resizable if HAVE_GTK3.
1593 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1594 and height if HAVE_GTK3 (Bug#8505).
1595 (scroll_bar_width_for_theme): New variable.
1596 (update_theme_scrollbar_width): New function.
1597 (xg_get_default_scrollbar_width): Move code to
1598 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1599 (xg_initialize): Call update_theme_scrollbar_width.
1601 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1603 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1605 2011-06-12 Martin Rudalics <rudalics@gmx.at>
1607 * frame.c (make_frame): Call other_buffer_safely instead of
1610 * window.c (temp_output_buffer_show): Call display_buffer with
1611 second argument Vtemp_buffer_show_specifiers and reset latter
1612 immediately after the call.
1613 (Vtemp_buffer_show_specifiers): New variable.
1614 (auto_window_vscroll_p, next_screen_context_lines)
1615 (Vscroll_preserve_screen_position): Remove leading asterisks from
1618 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
1620 Fix minor problems found by GCC 4.6.0 static checking.
1621 * buffer.c (Qclone_number): Remove for now, as it's unused.
1622 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1623 (record_buffer): Remove unused local.
1624 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1625 (set_frame_buffer_list): Remove; unused.
1626 * frame.h (other_visible_frames): Remove decl.
1627 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1628 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1629 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1631 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1632 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1633 Define only if HAVE_GPM.
1634 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1635 (update_hints_inhibit): Remove; never set. All uses removed.
1636 * widgetprv.h (emacsFrameClassRec): Remove decl.
1637 * window.c (delete_deletable_window): Now returns void, since it
1638 wasn't returning anything.
1639 (compare_window_configurations): Remove unused locals.
1640 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1641 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
1642 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1643 the same widths as pointers. This follows up on the 2011-05-06 patch.
1644 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1645 * xterm.h: Likewise.
1646 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1648 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
1650 * makefile.w32-in: Update dependencies.
1651 (LISP_H): Add lib/intprops.h.
1653 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1655 * image.c (gif_load): Add animation frame delay to the metadata.
1656 (syms_of_image): Use DEFSYM. New symbol `delay'.
1658 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1660 * window.c (delete_deletable_window): Re-add.
1661 (Fset_window_configuration): Rewrite to handle dead buffers and
1662 consequently deletable windows.
1663 (window_tree, Fwindow_tree): Remove. Supply functionality in
1665 (compare_window_configurations): Simplify code.
1667 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1669 * image.c (imagemagick_load_image): Fix type mismatch.
1670 (Fimagemagick_types): Likewise.
1672 * window.h (replace_buffer_in_windows): Declare.
1674 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1676 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1677 Qclone_number. Remove external declaration of Qdelete_window.
1678 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1680 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1681 Qbuffer_list_update_hook if allowed.
1682 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1683 buffer list implementation.
1684 (other_buffer_safely): New function.
1685 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1686 calls to replace_buffer_in_windows and
1687 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1689 (record_buffer): Inhibit quitting and rewrite using quittable
1690 functions. Run Qbuffer_list_update_hook if allowed.
1691 (Frecord_buffer, Funrecord_buffer): New functions.
1692 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1693 switch-to-buffer to window.el.
1694 (bury-buffer): Move to window.el.
1695 (Vbuffer_list_update_hook): New variable.
1697 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1700 * window.h (resize_frame_windows): Move up in code.
1701 (Fwindow_frame): Remove EXFUN.
1702 (replace_buffer_in_all_windows): Remove prototype.
1703 (replace_buffer_in_windows_safely): Add prototype.
1705 * window.c: Declare Qdelete_window static again. Move down
1706 declaration of select_count.
1707 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1708 (Fother_window): Move to window.el.
1709 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1710 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1711 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1713 (replace_buffer_in_windows): Implement by calling
1714 Qreplace_buffer_in_windows.
1715 (replace_buffer_in_all_windows): Remove with some functionality
1716 moved into replace_buffer_in_windows_safely.
1717 (replace_buffer_in_windows_safely): New function.
1718 (select_window_norecord, select_frame_norecord): Move in front
1719 of run_window_configuration_change_hook. Remove now obsolete
1721 (Fset_window_buffer): Rewrite doc-string. Call
1722 Qrecord_window_buffer.
1723 (keys_of_window): Move binding for other-window to window.el.
1725 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1727 * dispextern.h (struct image): Replace data member, whose int_val
1728 and ptr_val fields were not used by anything, with a single
1731 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1732 (gif_clear_image, gif_load, imagemagick_load_image)
1733 (gs_clear_image, gs_load): Callers changed.
1735 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1737 * buffer.h: Include <time.h>, for time_t.
1738 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1740 Fix minor problems found by static checking.
1742 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1744 Make identifiers static if they are not used in other modules.
1745 * data.c (Qcompiled_function, Qframe, Qvector):
1746 * image.c (QimageMagick, Qsvg):
1747 * minibuf.c (Qmetadata):
1748 * window.c (resize_window_check, resize_root_window): Now static.
1749 * window.h (resize_window_check, resize_root_window): Remove decls.
1751 * window.c (window_deletion_count, delete_deletable_window):
1753 (window_body_lines): Now static.
1754 (Fdelete_other_windows_internal): Mark vars as initialized.
1755 Make sure 'resize_failed' is initialized.
1756 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1757 (resize_window_apply): Remove unused local.
1758 * window.h (delete_deletable_window): Remove decl.
1760 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
1761 (imagemagick_load_image): Fix pointer signedness problem by changing
1762 last arg from unsigned char * to char *. All uses changed.
1763 Also, fix a local for similar reasons.
1764 Remove unused locals. Remove locals to avoid shadowing.
1765 (fn_rsvg_handle_free): Remove; unused.
1766 (svg_load, svg_load_image): Fix pointer signedness problem.
1767 (imagemagick_load_image): Don't use garbage pointer image_wand.
1769 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1771 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
1773 * image.c (gif_load): Fix omitted cast error introduced by
1776 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1778 * window.h (resize_proportionally, orig_total_lines)
1779 (orig_top_line): Remove from window structure.
1780 (set_window_height, set_window_width, change_window_heights)
1781 (Fdelete_window): Remove prototypes.
1782 (resize_frame_windows): Remove duplicate declaration.
1784 2011-06-10 Eli Zaretskii <eliz@gnu.org>
1786 * window.h (resize_frame_windows, resize_window_check)
1787 (delete_deletable_window, resize_root_window)
1788 (resize_frame_windows): Declare prototypes.
1790 * window.c (resize_window_apply): Make definition be "static" to
1791 match the prototype.
1793 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1795 * window.c: Remove declarations of Qwindow_size_fixed,
1796 window_min_size_1, window_min_size_2, window_min_size,
1797 size_window, window_fixed_size_p, enlarge_window, delete_window.
1798 Remove static from declaration of Qdelete_window, it's
1799 temporarily needed by Fbury_buffer.
1800 (replace_window): Don't assign orig_top_line and
1802 (Fdelete_window, delete_window): Remove. Window deletion is
1803 handled by window.el.
1804 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1805 Fdelete_window calls with calls to Qdelete_window.
1806 (Fdelete_other_windows): Remove. Deleting other windows is
1807 handled by window.el.
1808 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1809 handled in window.el.
1810 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1811 Window minimum sizes are handled in window.el.
1812 (shrink_windows, size_window, set_window_height)
1813 (set_window_width, change_window_heights, window_height)
1814 (window_width, CURBEG, CURSIZE, enlarge_window)
1815 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1816 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1817 handled in window.el.
1818 (make_dummy_parent): Rename to make_parent_window and give it a
1819 second argument horflag.
1820 (make_window): Don't set resize_proportionally any more.
1821 (Fsplit_window): Remove. Windows are split in window.el.
1822 (save_restore_action, save_restore_orig_size)
1823 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1824 Resize mini windows in window.el.
1825 (grow_mini_window, shrink_mini_window): Implement by calling
1826 Qresize_root_window_vertically, resize_window_check and
1827 resize_window_apply.
1828 (saved_window, Fset_window_configuration, save_window_save): Do
1829 not handle orig_top_line, orig_total_lines, and
1830 resize_proportionally.
1831 (window_min_height, window_min_width): Move to window.el.
1832 (keys_of_window): Move bindings for delete-other-windows,
1833 split-window, delete-window and enlarge-window to window.el.
1835 * buffer.c: Temporarily extern Qdelete_window.
1836 (Fbury_buffer): Temporarily call Qdelete_window instead of
1837 Fdelete_window (Fbury_buffer will move to window.el soon).
1839 * frame.c (set_menu_bar_lines_1): Remove code handling
1840 orig_top_line and orig_total_lines.
1842 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1843 set_window_height but set heights directly.
1844 (change_frame_size_1): Use resize_frame_windows.
1846 * xdisp.c (init_xdisp): Don't use set_window_height but set
1849 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1850 resize_frame_windows instead of change_window_heights and run
1851 run_window_configuration_change_hook.
1853 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1854 instead of change_window_heights and run
1855 run_window_configuration_change_hook.
1857 2011-06-09 Martin Rudalics <rudalics@gmx.at>
1859 * window.c (replace_window): Rename second argument REPLACEMENT to
1860 NEW. New third argument SETFLAG. Rewrite.
1861 (delete_window, make_dummy_parent): Call replace_window with
1863 (window_list_1): Move down in code.
1864 (run_window_configuration_change_hook): Move set_buffer part
1865 before select_frame_norecord part in order to unwind correctly.
1866 Rename count1 to count.
1867 (recombine_windows, delete_deletable_window, resize_root_window)
1868 (Fdelete_other_windows_internal)
1869 (Frun_window_configuration_change_hook, make_parent_window)
1870 (resize_window_check, resize_window_apply, Fresize_window_apply)
1871 (resize_frame_windows, Fsplit_window_internal)
1872 (Fdelete_window_internal, Fresize_mini_window_internal): New
1874 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1876 2011-06-08 Martin Rudalics <rudalics@gmx.at>
1878 * window.h (window): Add some new members to window structure -
1879 normal_lines, normal_cols, new_total, new_normal, clone_number,
1880 splits, nest, prev_buffers, next_buffers.
1881 (WINDOW_TOTAL_SIZE): Move here from window.c.
1882 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
1884 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1886 (make_dummy_parent): Set new members of windows structure.
1887 (make_window): Move down in code. Handle new members of window
1889 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1890 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1891 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1892 (Fset_window_prev_buffers, Fwindow_next_buffers)
1893 (Fset_window_next_buffers, Fset_window_clone_number): New
1895 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1896 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1898 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1899 Argument WINDOW can be now internal window too.
1900 (Fwindow_use_time): Move up in code.
1901 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1903 (Fset_window_configuration, saved_window)
1904 (Fcurrent_window_configuration, save_window_save): Handle new
1905 members of window structure.
1906 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1907 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1908 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1909 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1910 Qget_mru_window, Qresize_root_window,
1911 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1912 Qauto_buffer_name; staticpro them.
1914 2011-06-07 Martin Rudalics <rudalics@gmx.at>
1916 * window.c (Fwindow_total_size, Fwindow_left_column)
1917 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1918 (Fwindow_list_1): New functions.
1919 (window_box_text_cols): Replace with window_body_cols.
1920 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1921 window_body_cols instead of window_box_text_cols.
1922 (delete_window, Fset_window_configuration): Call
1923 delete_all_subwindows with window as argument.
1924 (delete_all_subwindows): Take a window as argument and not a
1926 (window_loop): Remove handling of GET_LRU_WINDOW and
1928 (Fget_lru_window, Fget_largest_window): Move to window.el.
1930 * window.h: Extern window_body_cols instead of
1931 window_box_text_cols. delete_all_subwindows now takes a
1932 Lisp_Object as argument.
1934 * indent.c (compute_motion, Fcompute_motion): Use
1935 window_body_cols instead of window_box_text_cols.
1937 * frame.c (delete_frame): Call delete_all_subwindows with root
1940 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1942 * fns.c (Fputhash): Document return value.
1944 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
1946 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1948 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1950 Cons<->int and similar integer overflow fixes (Bug#8794).
1952 Check for overflow when converting integer to cons and back.
1953 * charset.c (Fdefine_charset_internal, Fdecode_char):
1954 Use cons_to_unsigned to catch overflow.
1955 (Fencode_char): Use INTEGER_TO_CONS.
1956 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1957 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1958 * data.c (long_to_cons, cons_to_long): Remove.
1959 (cons_to_unsigned, cons_to_signed): New functions.
1960 These signal an error for invalid or out-of-range values.
1961 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1962 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1963 * font.c (Ffont_variation_glyphs):
1964 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1965 * lisp.h: Include <intprops.h>.
1966 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1967 (cons_to_signed, cons_to_unsigned): New decls.
1968 (long_to_cons, cons_to_long): Remove decls.
1969 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1970 (Fprimitive_undo): Use CONS_TO_INTEGER.
1971 * xfns.c (Fx_window_property): Likewise.
1972 * xselect.c: Include <limits.h>.
1973 (x_own_selection, selection_data_to_lisp_data):
1974 Use INTEGER_TO_CONS.
1975 (x_handle_selection_request, x_handle_selection_clear)
1976 (x_get_foreign_selection, Fx_disown_selection_internal)
1977 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1978 (lisp_data_to_selection_data): Use cons_to_unsigned.
1979 (x_fill_property_data): Use cons_to_signed.
1980 Report values out of range.
1982 Check for buffer and string overflow more precisely.
1983 * buffer.h (BUF_BYTES_MAX): New macro.
1984 * lisp.h (STRING_BYTES_MAX): New macro.
1985 * alloc.c (Fmake_string):
1986 * character.c (string_escape_byte8):
1987 * coding.c (coding_alloc_by_realloc):
1988 * doprnt.c (doprnt):
1989 * editfns.c (Fformat):
1991 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1992 since they may not be the same number.
1993 * editfns.c (Finsert_char):
1994 * fileio.c (Finsert_file_contents):
1995 Likewise for BUF_BYTES_MAX.
1997 * image.c: Use ptrdiff_t, not int, for sizes.
1998 (slurp_file): Switch from int to ptrdiff_t.
2000 (slurp_file): Check that file size fits in both size_t (for
2001 malloc) and ptrdiff_t (for sanity and safety).
2003 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2004 if b->modtime has its maximal value.
2006 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2008 Don't assume time_t can fit into int.
2009 * buffer.h (struct buffer.modtime): Now time_t, not int.
2010 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2011 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2013 Minor fixes for signed vs unsigned integers.
2014 * character.h (MAYBE_UNIFY_CHAR):
2015 * charset.c (maybe_unify_char):
2016 * keyboard.c (read_char, reorder_modifiers):
2017 XINT -> XFASTINT, since the integer must be nonnegative.
2018 * ftfont.c (ftfont_spec_pattern):
2019 * keymap.c (access_keymap, silly_event_symbol_error):
2020 XUINT -> XFASTINT, since the integer must be nonnegative.
2021 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2022 since it makes no difference and we prefer signed.
2023 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2024 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2027 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2029 * window.h (Fwindow_frame): Declare.
2031 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2033 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2034 (SPARE_MEMORY): Always define.
2035 (LARGE_REQUEST): Remove.
2036 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2038 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2040 * lisp.h: Move EXFUNS for Fframe_root_window,
2041 Fframe_first_window and Fset_frame_selected_window to window.h.
2043 * window.h: Move EXFUNS for Fframe_root_window,
2044 Fframe_first_window and Fset_frame_selected_window here from
2047 * frame.c (Fwindow_frame, Fframe_first_window)
2048 (Fframe_root_window, Fframe_selected_window)
2049 (Fset_frame_selected_window): Move to window.c.
2050 (Factive_minibuffer_window): Move to minibuf.c.
2051 (Fother_visible_frames_p): New function.
2053 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2055 * window.c (decode_window, decode_any_window): Move up in code.
2056 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2057 (inhibit_frame_unsplittable): Remove unused variable.
2058 (Fwindow_buffer): Move up and rewrite doc-string.
2059 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2060 (Fwindow_prev): New functions.
2061 (Fwindow_frame): Move here from frame.c. Accept any window as
2063 (Fframe_root_window, Fframe_first_window)
2064 (Fframe_selected_window): Move here from frame.c. Accept frame
2065 or arbitrary window as argument. Update doc-strings.
2066 (Fminibuffer_window): Move up in code.
2067 (Fwindow_minibuffer_p): Move up in code and simplify.
2068 (Fset_frame_selected_window): Move here from frame.c.
2070 (Fselected_window, select_window, Fselect_window): Move up in
2071 code. Minor doc-string fixes.
2073 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2075 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2076 Do not assume that spare memory exists; that assumption is valid
2077 only if SYSTEM_MALLOC.
2078 (LARGE_REQUEST): New macro, so that the issue of large requests
2079 is separated from the issue of spare memory.
2081 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2083 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2086 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2088 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2091 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2093 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2095 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2097 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2098 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2100 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2102 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2104 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2106 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2107 (x_clipboard_manager_save): Add return value.
2108 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2110 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2111 Obey Vx_select_enable_clipboard_manager. Catch errors in
2112 x_clipboard_manager_save (Bug#8779).
2113 (Vx_select_enable_clipboard_manager): New variable.
2114 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2116 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2118 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2120 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2122 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2123 in the current matrix if keep_current_p is non-zero.
2125 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2127 * bidi.c (bidi_level_of_next_char): Fix last change.
2129 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2131 Support bidi reordering of text covered by display properties.
2133 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2134 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2135 (bidi_cache_search, bidi_cache_iterator_state)
2136 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2137 (bidi_level_of_next_char, bidi_move_to_visually_next):
2138 Support character positions inside a run of characters covered by a
2140 (bidi_paragraph_init, bidi_resolve_explicit_1)
2141 (bidi_level_of_next_char): Call bidi_fetch_char and
2142 bidi_fetch_char_advance instead of FETCH_CHAR and
2144 (bidi_init_it): Initialize new members.
2145 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2147 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2148 instead of using explicit *_CHAR codes.
2149 (bidi_resolve_explicit, bidi_resolve_weak):
2150 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2151 bidirectional text is supported only in multibyte buffers.
2152 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2153 it to initialize the frame_window_p member of struct bidi_it.
2154 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2155 (bidi_resolve_explicit, bidi_resolve_weak)
2156 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2157 bidi_it->nchars is non-positive.
2158 (bidi_level_of_next_char): Don't try to lookup the cache for the
2159 next/previous character if nothing is cached there yet, or if we
2160 were just reseat()'ed to a new position.
2162 * xdisp.c (set_cursor_from_row): Set start and stop points
2163 according to the row's direction when priming the loop that looks
2164 for the glyph on which to display cursor.
2165 (single_display_spec_intangible_p): Function deleted.
2166 (display_prop_intangible_p): Reimplement to call
2167 handle_display_spec instead of single_display_spec_intangible_p.
2168 Accept 3 additional arguments needed by handle_display_spec.
2169 This fixes incorrect cursor motion across display property with complex
2170 values: lists, `(when COND...)' forms, etc.
2171 (single_display_spec_string_p): Support property values that are
2172 lists with the argument STRING its top-level element.
2173 (display_prop_string_p): Fix the condition for processing a
2174 property that is a list to be consistent with handle_display_spec.
2175 (handle_display_spec): New function, refactored from the
2176 last portion of handle_display_prop.
2177 (compute_display_string_pos): Accept additional argument
2178 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2179 value of a `display' property is a "replacing spec".
2180 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2181 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2182 the display property, but just return a value indicating whether
2183 the display property will replace the characters it covers.
2184 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2185 frame_window_p members of struct bidi_it.
2186 (compute_display_string_pos, compute_display_string_end):
2188 (push_it): Accept second argument POSITION, where pop_it should
2189 jump to continue iteration.
2190 (reseat_1): Initialize bidi_it.disp_pos.
2192 * keyboard.c (adjust_point_for_property): Adjust the call to
2193 display_prop_intangible_p to its new signature.
2195 * dispextern.h (struct bidi_it): New member frame_window_p.
2196 (bidi_init_it): Update prototypes.
2197 (display_prop_intangible_p): Update prototype.
2198 (compute_display_string_pos, compute_display_string_end):
2200 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2203 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2205 Malloc failure behavior now depends on size of allocation.
2206 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2207 * lisp.h: Change signatures accordingly.
2208 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2209 All callers changed. (Bug#8762)
2211 * gnutls.c: Use Emacs's memory allocators.
2212 Without this change, the gnutls library would invoke malloc etc.
2213 directly, which causes problems on non-SYNC_INPUT hosts, and which
2214 runs afoul of improving memory_full behavior. (Bug#8761)
2215 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2216 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2217 xfree instead of the default malloc, realloc, free.
2218 (Fgnutls_boot): No need to check for memory allocation failure,
2219 since xmalloc does that for us.
2221 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2222 * category.c (hash_get_category_set):
2223 * ccl.c (ccl_driver):
2224 * charset.c (Fdefine_charset_internal):
2225 * charset.h (struct charset.hash_index):
2226 * composite.c (get_composition_id, gstring_lookup_cache)
2227 (composition_gstring_put_cache):
2228 * composite.h (struct composition.hash_index):
2229 * dispextern.h (struct image.hash):
2230 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2231 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2232 (hashfn_equal, hashfn_user_defined, make_hash_table)
2233 (maybe_resize_hash_table, hash_lookup, hash_put)
2234 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2235 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2236 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2237 * image.c (make_image, search_image_cache, lookup_image)
2238 (xpm_put_color_table_h):
2239 * lisp.h (struct Lisp_Hash_Table):
2240 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2241 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2242 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2243 * alloc.c (allocate_vectorlike):
2244 Check for overflow in vector size calculations.
2245 * ccl.c (ccl_driver):
2246 Check for overflow when converting EMACS_INT to int.
2247 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2248 need to be updated by these changes.
2249 * fns.c (make_hash_table, maybe_resize_hash_table):
2250 Check for integer overflow with large hash tables.
2251 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2252 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2253 (SXHASH_REDUCE): New macro.
2254 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2255 Use it instead of discarding useful hash info with large hash values.
2256 (sxhash_float): New function.
2257 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2258 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2259 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2260 Rewrite to use FIXNUM_BITS, as this simplifies things.
2261 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2262 Adjust signatures to match updated version of code.
2263 (consing_since_gc): Now EMACS_INT, since a single hash table can
2264 use more than INT_MAX bytes.
2266 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2268 Make it possible to build with GCC-4.6+ -O2 -flto.
2270 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2272 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2274 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2275 Call minibuffer-inactive-mode.
2277 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2279 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2280 Update dependencies.
2282 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2284 * data.c (init_data): Remove code for UTS, this system is not
2287 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2289 Don't force ./temacs to start in terminal mode.
2291 * frame.c (make_initial_frame): Initialize faces in all cases, not
2292 only when CANNOT_DUMP is defined.
2293 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2295 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2297 * dispnew.c (add_window_display_history): Use const for the string
2298 pointer. Remove declaration, not needed.
2300 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2302 Use 'inline', not 'INLINE'.
2303 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2304 * alloc.c, fontset.c (INLINE): Remove.
2305 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2306 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2307 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2308 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2309 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2311 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2313 Make it possible to run ./temacs.
2315 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2316 syms_of_callproc does the same thing. Remove test for
2317 "initialized", do it in the caller.
2318 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2320 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2322 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2323 (read_minibuf): Use get_minibuffer.
2324 (syms_of_minibuf): Use DEFSYM.
2325 (Qmetadata): New var.
2326 * data.c (Qbuffer): Don't make it static.
2327 (syms_of_data): Use DEFSYM.
2329 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2331 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2332 (CCL_CODE_MIN): New macro.
2334 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2336 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2338 * eval.c (Qdebug): Now static.
2339 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2340 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2341 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2343 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2345 * image.c: Various fixes to ImageMagick code comments.
2346 (Fimagemagick_types): Doc fix.
2348 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2350 Minor fixes prompted by GCC 4.6.0 warnings.
2352 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2354 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2355 (x_clipboard_manager_save_all): Move extern decl to ...
2356 * xterm.h: ... here, so that it can be checked for consistency.
2358 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2360 * xselect.c (x_clipboard_manager_save_frame)
2361 (x_clipboard_manager_save_all): New functions.
2362 (Fx_clipboard_manager_save): Lisp function deleted.
2364 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2365 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2367 * xterm.h: Update prototype.
2369 2011-05-28 William Xu <william.xwl@gmail.com>
2371 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2374 2011-05-28 Jim Meyering <meyering@redhat.com>
2376 Avoid a sign-extension bug in crypto_hash_function.
2377 * fns.c (to_uchar): Define.
2378 (crypto_hash_function): Use it to convert some newly-signed
2379 variables to unsigned, to avoid sign-extension bugs. For example,
2380 without this change, (md5 "truc") would evaluate to
2381 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2382 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2383 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2385 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2387 Integer overflow fixes.
2389 * dbusbind.c: Serial number integer overflow fixes.
2390 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2391 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2392 to hold a serial number that is too large for a fixnum.
2393 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2394 Check for serial numbers out of range. Decode any serial number
2395 that was so large that it became a float. (Bug#8722)
2397 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2398 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2399 Use XFASTINT rather than XUINT when numbers are nonnegative.
2400 (xd_append_arg, Fdbus_method_return_internal):
2401 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2402 arguments, check that Lisp number is nonnegative, rather than
2403 silently wrapping negative numbers around. (Bug#8722)
2404 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2407 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2409 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2411 ccl: add integer overflow checks
2412 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2413 (IN_INT_RANGE): New macros.
2414 (ccl_driver): Use them to check for integer overflow when
2415 decoding a CCL program. Many of the new checks are whether XINT (x)
2416 fits in int; it doesn't always, on 64-bit hosts. The new version
2417 doesn't catch all possible integer overflows, but it's an
2418 improvement. (Bug#8719)
2420 * alloc.c (make_event_array): Use XINT, not XUINT.
2421 There's no need for unsigned here.
2423 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2424 This follows up to the 2011-05-06 change that substituted uintptr_t
2425 for EMACS_INT. This case wasn't caught back then.
2427 Rework Fformat to avoid integer overflow issues.
2428 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2429 now (part of C89). Include <verify.h>.
2430 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2431 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2432 (Fformat): Avoid the prepass trying to compute sizes; it was only
2433 approximate and thus did not catch overflow reliably. Instead, walk
2434 through the format just once, formatting and computing sizes as we go,
2435 checking for integer overflow at every step, and allocating a larger
2436 buffer as needed. Keep track separately whether the format is
2437 multibyte. Keep only the most-recently calculated precision, rather
2438 than them all. Record whether each argument has been converted to
2439 string. Use EMACS_INT, not int, for byte and char and arg counts.
2440 Support field widths and precisions larger than INT_MAX. Avoid
2441 sprintf's undefined behavior with conversion specifications such as %#d
2442 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2443 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2444 formatting out-of-range floating point numbers with int
2447 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2449 * data.c: Avoid integer truncation in expressions involving floats.
2450 * data.c: Include <intprops.h>.
2451 (arith_driver): When there's an integer overflow in an expression
2452 involving floating point, convert the integers to floating point
2453 so that the resulting value does not suffer from catastrophic
2454 integer truncation. For example, on a 64-bit host (* 4
2455 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2456 Do not rely on undefined behavior after integer overflow.
2458 merge count_size_as_multibyte, parse_str_to_multibyte
2459 * character.c, character.h (count_size_as_multibyte):
2460 Rename from parse_str_to_multibyte; all uses changed.
2461 Check for integer overflow.
2462 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2463 since it's now a duplicate of the other. This is more of
2464 a character than a buffer op, so better that it's in character.c.
2465 * fns.c, print.c: Adjust to above changes.
2467 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2469 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2471 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2473 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2474 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2475 (x_clipboard_manager_save): Now static.
2476 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2478 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2479 (crypto_hash_function): Now static.
2480 Fix pointer signedness problems. Avoid unnecessary initializations.
2482 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2484 * termhooks.h (Vselection_alist): Make it terminal-local.
2486 * terminal.c (create_terminal): Initialize it.
2488 * xselect.c: Support for clipboard managers.
2489 (Vselection_alist): Move to termhooks.h as terminal-local var.
2490 (LOCAL_SELECTION): New macro.
2491 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2492 (symbol_to_x_atom): Remove gratuitous arg.
2493 (x_handle_selection_request, lisp_data_to_selection_data)
2494 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2495 (x_own_selection, x_get_local_selection, x_convert_selection):
2496 New arg, specifying work frame. Use terminal-local Vselection_alist.
2497 (some_frame_on_display): Delete unused function.
2498 (Fx_own_selection_internal, Fx_get_selection_internal)
2499 (Fx_disown_selection_internal, Fx_selection_owner_p)
2500 (Fx_selection_exists_p): New optional frame arg.
2501 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2502 (x_handle_selection_clear): Don't treat other terminals with the
2503 same keyboard specially. Use the terminal-local Vselection_alist.
2504 (x_clear_frame_selections): Use Frun_hook_with_args.
2506 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2508 * xterm.h: Add support for those atoms.
2510 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2512 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2513 (converted_selections, conversion_fail_tag): New global variables.
2514 (x_selection_request_lisp_error): Free the above.
2515 (x_get_local_selection): Remove unnecessary code.
2516 (x_reply_selection_request): Args changed; handle arbitrary array
2517 of converted selections stored in converted_selections.
2518 Separate the XChangeProperty and SelectionNotify steps.
2519 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2520 (x_convert_selection): New function.
2521 (x_handle_selection_event): Simplify.
2522 (x_get_foreign_selection): Don't ignore incoming requests while
2523 waiting for an answer; this will fail when we implement
2524 SAVE_TARGETS, and seems unnecessary anyway.
2525 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2526 (Vx_sent_selection_functions): Doc fix.
2528 2011-05-26 Leo Liu <sdl.web@gmail.com>
2530 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2532 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2534 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2536 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2537 for fringe update if it has periodic bitmap.
2538 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2539 and fringe_bitmap_periodic_p.
2541 * fringe.c (get_fringe_bitmap_data): New function.
2542 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2543 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2544 row. Mark glyph row for fringe update if periodicity changed.
2546 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2547 for fringe update unless it has periodic bitmap.
2549 2011-05-25 Kenichi Handa <handa@m17n.org>
2551 * xdisp.c (get_next_display_element): Set correct it->face_id for
2552 a static composition.
2554 2011-05-24 Leo Liu <sdl.web@gmail.com>
2557 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2559 * fns.c (crypto_hash_function, Fsha1): New function.
2560 (Fmd5): Use crypto_hash_function.
2561 (syms_of_fns): Add Ssha1.
2563 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2565 * gnutls.c: Remove unused macros.
2566 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2567 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2568 Remove macros that are defined and never used.
2569 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2571 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2573 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2574 (Fx_get_selection_internal): Minor cleanup.
2575 (Fx_own_selection_internal): Rename arguments for consistency with
2578 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2580 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2582 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2584 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2586 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2588 * dispnew.c (scrolling_window): Don't exclude the case that the
2589 last enabled row in the desired matrix touches the bottom boundary.
2591 2011-05-21 Glenn Morris <rgm@gnu.org>
2593 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
2594 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2595 and add some more files.
2597 2011-05-20 Eli Zaretskii <eliz@gnu.org>
2599 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2600 report_file_error introduced by the change from 2011-05-07.
2602 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2604 * systime.h (Time): Define only if emacs is defined.
2605 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2606 where the include path doesn't have X11/X.h by default. See
2607 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2609 2011-05-20 Kenichi Handa <handa@m17n.org>
2611 * composite.c (find_automatic_composition): Fix previous change.
2613 2011-05-20 Glenn Morris <rgm@gnu.org>
2615 * lisp.mk: New file, split from Makefile.in.
2616 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2617 (shortlisp): Remove.
2618 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2620 2011-05-19 Glenn Morris <rgm@gnu.org>
2622 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2623 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2624 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2625 (lisp): Set the order to that of loadup.el.
2626 (shortlisp): Make it a copy of $lisp.
2627 (SOME_MACHINE_LISP): Remove.
2628 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2629 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2631 2011-05-18 Kenichi Handa <handa@m17n.org>
2633 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2634 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2635 (find_automatic_composition): Mostly rewrite for efficiency.
2637 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
2639 * makefile.w32-in: Update dependencies.
2641 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2643 * menu.c: Include limits.h (fixes the MS-Windows build broken by
2644 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
2646 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
2648 Fix some integer overflow issues, such as string length overflow.
2650 * insdel.c (count_size_as_multibyte): Check for string overflow.
2652 * character.c (lisp_string_width): Check for string overflow.
2653 Use EMACS_INT, not int, for string indexes and lengths; in
2654 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2655 the resulting string length overflows an EMACS_INT; instead,
2656 report a string overflow if no precision given. When checking for
2657 precision exhaustion, use a check that cannot possibly have
2658 integer overflow. (Bug#8675)
2659 * character.h (lisp_string_width): Adjust to new signature.
2661 * alloc.c (string_overflow): New function.
2662 (Fmake_string): Use it. This doesn't change behavior, but saves
2663 a few bytes and will simplify future changes.
2664 * character.c (string_escape_byte8): Likewise.
2665 * lisp.h (string_overflow): New decl.
2667 Fixups, following up to the user-interface timestamp change.
2668 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2669 for UI timestamps, instead of unsigned long.
2670 * msdos.c (mouse_get_pos): Likewise.
2671 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
2672 * w32gui.h (Time): Define by including "systime.h" rather than by
2673 declaring it ourselves. (Bug#8664)
2675 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2676 * image.c (clear_image_cache): Likewise.
2678 * term.c (term_mouse_position): Don't assume time_t wraparound.
2680 Be more systematic about user-interface timestamps.
2681 Before, the code sometimes used 'Time', sometimes 'unsigned long',
2682 and sometimes 'EMACS_UINT', to represent these timestamps.
2683 This change causes it to use 'Time' uniformly, as that's what X uses.
2684 This makes the code easier to follow, and makes it easier to catch
2685 integer overflow bugs such as Bug#8664.
2686 * frame.c (Fmouse_position, Fmouse_pixel_position):
2687 Use Time, not unsigned long, for user-interface timestamps.
2688 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2689 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2690 * keyboard.h (last_event_timestamp): Likewise.
2691 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2692 * menu.h (xmenu_show): Likewise.
2693 * term.c (term_mouse_position): Likewise.
2694 * termhooks.h (struct input_event.timestamp): Likewise.
2695 (struct terminal.mouse_position_hook): Likewise.
2696 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2697 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2698 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2699 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2701 * menu.h, termhooks.h: Include "systime.h", for Time.
2703 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2704 Don't assume that the difference between two unsigned long values
2705 can fit into an integer. At this point, we know button_down_time
2706 <= event->timestamp, so the difference must be nonnegative, so
2707 there's no need to cast the result if double-click-time is
2708 nonnegative, as it should be; check that it's nonnegative, just in
2709 case. This bug is triggered when events are more than 2**31 ms
2710 apart (about 25 days). (Bug#8664)
2712 * xselect.c (last_event_timestamp): Remove duplicate decl.
2713 (x_own_selection): Remove needless cast to unsigned long.
2715 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2716 that always fit in int. Use a sentinel instead of a counter, to
2717 avoid a temp and to allay GCC's concerns about possible int overflow.
2718 * frame.h (struct frame): Use int for menu_bar_items_used
2719 instead of EMACS_INT, since it always fits in int.
2721 * menu.c (grow_menu_items): Check for int overflow.
2723 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2725 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2726 Before, the code was not consistent. These values cannot exceed
2727 2**31 - 1 so there's no need to make them unsigned.
2728 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2729 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2730 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2732 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2734 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2735 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2736 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2737 presumably because the widths might not match.
2739 * window.c (size_window): Avoid needless test at loop start.
2741 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2743 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2745 2011-05-12 Drew Adams <drew.adams@oracle.com>
2747 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2749 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2751 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2752 `width' to `bar_area_x' and `bar_area_width', respectively.
2753 (x_scroll_run): Take account of fringe background extension.
2755 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2756 Rename local vars `left' and `width' to `bar_area_x' and
2757 `bar_area_width', respectively.
2758 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2759 background extension.
2761 2011-05-10 Jim Meyering <meyering@redhat.com>
2763 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2765 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
2767 * image.c (Finit_image_library): Return t for built-in image types,
2768 like pbm and xbm. (Bug#8640)
2770 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2772 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2774 2011-05-07 Eli Zaretskii <eliz@gnu.org>
2776 * w32console.c (Fset_screen_color): Doc fix.
2777 (Fget_screen_color): New function.
2778 (syms_of_ntterm): Defsubr it.
2780 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2781 unlink the temporary file if Fcall_process didn't create it in the
2783 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2784 child process will be redirected to a file specified with `:file'.
2785 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2786 cue to call_process_cleanup not to close that handle.
2788 2011-05-07 Ben Key <bkey76@gmail.com>
2790 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2791 one of two shell specific rules, either bootstrap-temacs-CMD or
2792 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2793 to the previous implementation of the bootstrap-temacs rule.
2794 The bootstrap-temacs-CMD rule is similar to the previous
2795 implementation of the bootstrap-temacs rule except that it
2796 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2799 These changes, along with some changes to nt/configure.bat,
2800 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2801 earlier fix to add support for --cflags and --ldflags options
2802 that include quotes so that it works whether make uses cmd or
2805 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
2807 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2808 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2810 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2811 a string. Handle both cases.
2812 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2813 (Fdbus_register_method): Use Qinvalid_function.
2815 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2817 * makefile.w32-in: Update dependencies.
2818 (LISP_H): Add inttypes.h and stdin.h.
2819 (PROCESS_H): Add unistd.h.
2821 2011-05-06 Eli Zaretskii <eliz@gnu.org>
2823 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2824 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2826 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
2828 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2830 * term.c (vfatal): Remove stray call to va_end.
2831 It's not needed and the C Standard doesn't allow it here anyway.
2833 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2834 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2836 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2839 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2841 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2843 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2845 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2847 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2849 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2850 * charset.c (Fdefine_charset_internal): Don't initialize
2851 charset.code_space[15]. The value was garbage, on hosts with
2852 32-bit int (Bug#8600).
2854 * lread.c (read_integer): Be more consistent with string-to-number.
2855 Use string_to_number to do the actual conversion; this avoids
2856 rounding errors and fixes some other screwups. Without this fix,
2857 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2858 (digit_to_number): Move earlier, for benefit of read_integer.
2859 Return -1 if the digit is out of range for the base, -2 if it is
2860 not a digit in any supported base. (Bug#8602)
2862 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2864 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2865 to match comment at start of function. This also removes a
2866 GCC warning about overflow in a 32+64-bit port.
2868 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2870 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2871 Reported by Stefan Monnier in
2872 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
2873 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2874 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
2876 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2877 (EMACS_UINTPTR): Likewise, with uintptr_t.
2879 * lisp.h: Prefer 64-bit EMACS_INT if available.
2880 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2881 on 32-bit hosts that have 64-bit int, so that they can access
2883 However, temporarily disable this change unless the temporary
2884 symbol WIDE_EMACS_INT is defined.
2886 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2888 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2889 This removes an assumption that EMACS_INT and long are the same
2890 width as pointers. The assumption is true for Emacs porting targets
2891 now, but we want to make other targets possible.
2892 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2893 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2894 In the rest of the code, change types of integers that hold casted
2895 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2896 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2897 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2898 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2899 No need to cast type when ORing.
2900 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2901 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2902 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2903 assume EMACS_INT is the same width as char *.
2904 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2905 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2906 Remove no-longer-needed casts.
2907 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2908 (xg_tool_bar_help_callback, xg_make_tool_item):
2909 Use EMACS_INTPTR to hold an integer
2910 that will be cast to void *; this can avoid a GCC warning
2911 if EMACS_INT is not the same width as void *.
2912 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2913 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2914 (current_message_1, set_message_1):
2915 Use a local to convert to proper width without a cast.
2916 * xmenu.c (dialog_selection_callback): Likewise.
2918 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2919 Also, don't assume VALBITS / RAND_BITS is less than 5,
2920 and don't rely on undefined behavior when shifting a 1 left into
2922 * lisp.h (get_random): Change signature to match.
2924 * lread.c (hash_string): Use size_t, not int, for hash computation.
2925 Normally we prefer signed values; but hashing is special, because
2926 it's better to use unsigned division on hash table sizes so that
2927 the remainder is nonnegative. Also, size_t is the natural width
2928 for hashing into memory. The previous code used 'int', which doesn't
2929 retain enough info to hash well into very large tables.
2930 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2932 * dbusbind.c: Don't possibly lose pointer info when converting.
2933 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2934 Use XPNTR rather than XHASH, so that the high-order bits of
2935 the pointer aren't lost when converting through void *.
2937 * eval.c (Fautoload): Don't double-shift a pointer.
2939 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2941 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2943 * gnutls.c (DEF_GNUTLS_FN):
2944 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2946 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2948 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2951 2011-05-05 Eli Zaretskii <eliz@gnu.org>
2953 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2954 New version that can reserve upto 2GB of heap space.
2956 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
2958 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2960 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2962 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2963 `gnutls_certificate_set_x509_key_file'.
2965 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
2967 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2968 Update dependencies.
2970 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2972 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2973 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2974 Remove unused parameter `fildes'.
2975 * process.c (read_process_output, send_process): Don't pass it.
2977 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2979 Fix previous change: the library cache is defined in w32.c.
2980 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2981 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2983 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2985 Implement dynamic loading of GnuTLS on Windows.
2987 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2988 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2989 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2992 * gnutls.c (Qgnutls_dll): Define.
2993 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2994 (gnutls_*): Declare function pointers.
2995 (init_gnutls_functions): New function to initialize function pointers.
2996 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2997 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2998 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2999 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3000 (emacs_gnutls_write, emacs_gnutls_read)
3001 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3002 (Fgnutls_available_p): New function.
3003 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3004 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3005 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3007 * image.c: Include w32.h.
3008 (Vimage_type_cache): Delete.
3009 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3010 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3011 (w32_delayed_load): Move to w32.c.
3013 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3015 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3016 (w32_delayed_load): Move from image.c. When loading a library, record
3017 its filename in the :loaded-from property of the library id.
3018 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3019 Initialize and staticpro them.
3020 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3022 * process.c: Include lisp.h before w32.h, not after.
3023 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3024 instead of gnutls_record_check_pending.
3026 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3028 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3030 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3031 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3034 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3036 * xterm.c (x_set_frame_alpha): Do not set property on anything
3037 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3039 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3041 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3043 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3045 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3046 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3047 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3048 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3049 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3050 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3051 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3052 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3053 (Qgnutls_bootprop_callbacks_verify): Make static.
3055 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3057 * callproc.c: Indentation fixup.
3059 * sysdep.c (wait_for_termination_1): Make static.
3060 (wait_for_termination, interruptible_wait_for_termination):
3061 Move after wait_for_termination_1.
3063 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3065 * sysdep.c (interruptible_wait_for_termination): New function
3066 which is like wait_for_termination, but allows keyboard
3069 * callproc.c (Fcall_process): Add (:file "file") as an option for
3071 (Fcall_process_region): Ditto.
3073 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3075 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3076 rather than `XVECTOR (FOO)->size'.
3078 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3079 inttypes.h, as a gnulib replacement is used if it not available in
3082 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3084 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3085 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3086 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3088 * coding.c (coding_alloc_by_realloc): Error out if destination
3089 will grow beyond MOST_POSITIVE_FIXNUM.
3090 (decode_coding_emacs_mule): Abort if there isn't enough place in
3091 charbuf for the composition carryover bytes. Reserve an extra
3092 space for up to 2 characters produced in a loop.
3093 (decode_coding_iso_2022): Abort if there isn't enough place in
3094 charbuf for the composition carryover bytes.
3096 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3098 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3099 aborting when %lld or %lll format is passed.
3100 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3101 %llo or %llx format is passed. (Bug#8545)
3103 * window.c (window_scroll_line_based): Use a marker instead of
3104 simple variables to record original value of point. (Bug#7952)
3106 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3107 produced by %s or %c overflows available buffer space. (Bug#8545)
3109 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3111 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3112 (SIZE_MAX): Move defn after all includes, as they might #define it.
3114 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3116 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3118 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3120 * keyboard.c (Qdelayed_warnings_hook): Define.
3121 (command_loop_1): Run `delayed-warnings-hook'
3122 if Vdelayed_warnings_list is non-nil.
3123 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3124 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3126 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3128 * doprnt.c (doprnt): Don't return value smaller than the buffer
3129 size if the message was truncated. (Bug#8545).
3131 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3133 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3134 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3136 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3138 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3140 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3142 * makefile.w32-in: Update dependencies.
3144 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3146 Improve `doprnt' and its usage. (Bug#8545)
3147 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3148 `format_end'. Remove support for %l as a conversion specifier.
3149 Don't use xrealloc. Improve diagnostics when the %l size modifier
3150 is used. Update the commentary.
3152 * eval.c (verror): Simplify calculation of size_t.
3154 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3157 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3159 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3162 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3164 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3165 This makes this file independent of the recent pseudovector change.
3167 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3169 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3171 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3172 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3173 Remove unused local.
3174 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3176 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3177 GCC 4.6.0 optimizes based on type-based alias analysis.
3178 For example, if b is of type struct buffer * and v of type struct
3179 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3180 != &v->size, and therefore "v->size = 1; b->size = 2; return
3181 v->size;" must therefore return 1. This assumption is incorrect
3182 for Emacs, since it type-puns struct Lisp_Vector * with many other
3183 types. To fix this problem, this patch adds a new type struct
3184 vectorlike_header that documents the constraints on layout of vectors
3185 and pseudovectors, and helps optimizing compilers not get fooled
3186 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3187 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3188 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3190 (XSETPVECTYPE): Rewrite in terms of new macro.
3191 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3192 This is a bit clearer, and further avoids the possibility of
3193 undesirable aliasing.
3194 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3195 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3196 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3197 since Lisp_Subr is a special case (no "next" field).
3198 (ASIZE): Now uses header.size rather than size.
3199 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3200 to avoid the hassle of writing XVECTOR (foo)->header.size.
3201 (struct vectorlike_header): New type.
3202 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3203 object, to help avoid aliasing.
3204 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3205 (SUBRP): Likewise, since Lisp_Subr is a special case.
3206 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3207 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3208 (struct Lisp_Hash_Table): Combine first two members into a single
3209 struct vectorlike_header member. All uses of "size" and "next" members
3210 changed to be "header.size" and "header.next".
3211 * buffer.h (struct buffer): Likewise.
3212 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3213 * frame.h (struct frame): Likewise.
3214 * process.h (struct Lisp_Process): Likewise.
3215 * termhooks.h (struct terminal): Likewise.
3216 * window.c (struct save_window_data, struct saved_window): Likewise.
3217 * window.h (struct window): Likewise.
3218 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3219 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3220 * buffer.c (init_buffer_once): Likewise.
3221 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3223 * process.c (Fformat_network_address): Use local var for size,
3226 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3228 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3229 * data.c (atof): Remove decl; no longer used or needed.
3230 (digit_to_number): Move to lread.c.
3231 (Fstring_to_number): Use new string_to_number function, to be
3232 consistent with how the Lisp reader treats infinities and NaNs.
3233 Do not assume that floating-point numbers represent EMACS_INT
3234 without losing information; this is not true on most 64-bit hosts.
3235 Avoid double-rounding errors, by insisting on integers when
3236 parsing non-base-10 numbers, as the documentation specifies.
3237 * lisp.h (string_to_number): New decl, replacing ...
3238 (isfloat_string): Remove.
3239 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3240 (read1): Do not accept +. and -. as integers; this
3241 appears to have been a coding error. Similarly, do not accept
3242 strings like +-1e0 as floating point numbers. Do not report
3243 overflow for integer overflows unless the base is not 10 which
3244 means we have no simple and reliable way to continue.
3245 Break out the floating-point parsing into a new
3246 function string_to_number, so that Fstring_to_number parses
3247 floating point numbers consistently with the Lisp reader.
3248 (digit_to_number): Move here from data.c. Make it static inline.
3249 (E_CHAR, EXP_INT): Remove, replacing with ...
3250 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3251 (string_to_number): New function, replacing isfloat_string.
3252 This function checks for valid syntax and produces the resulting
3253 Lisp float number too. Rework it so that string-to-number
3254 no longer mishandles examples like "1.0e+". Use strtoumax,
3255 so that overflow for non-base-10 numbers is reported only when
3256 there's no portable and simple way to convert to floating point.
3258 * textprop.c (set_text_properties_1): Rewrite for clarity,
3259 and to avoid GCC warning about integer overflow.
3261 * intervals.h (struct interval): Use EMACS_INT for members
3262 where EMACS_UINT might cause problems. See
3263 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3264 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3265 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3267 (offset_intervals): Tell GCC not to worry about length overflow
3268 when negating a negative length.
3270 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3271 (overrun_check_free): Likewise.
3273 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3274 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3277 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3278 (gnutls_make_error): Rename local to avoid shadowing.
3279 (gnutls_emacs_global_deinit): ifdef out; not used.
3280 (Fgnutls_boot): Use const for pointer to readonly storage.
3281 Comment out unused local. Fix pointer signedness problems.
3283 * lread.c (openp): Don't stuff size_t into an 'int'.
3284 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3285 about possible signed overflow.
3287 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3288 (GDK_KEY_g): Don't define if already defined.
3289 (xg_prepare_tooltip): Avoid pointer signedness problem.
3290 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3292 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3293 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3295 * xfns.c (Fx_window_property): Simplify a bit,
3296 to make a bit faster and to avoid GCC 4.6.0 warning.
3297 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3299 * fns.c (internal_equal): Don't assume size_t fits in int.
3301 * alloc.c (compact_small_strings): Tighten assertion a little.
3303 Replace pEd with more-general pI, and fix some printf arg casts.
3304 * lisp.h (pI): New macro, generalizing old pEd macro to other
3305 conversion specifiers. For example, use "...%"pI"d..." rather
3306 than "...%"pEd"...".
3307 (pEd): Remove. All uses replaced with similar uses of pI.
3308 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3309 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3310 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3311 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3312 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3313 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3314 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3316 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3317 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3318 * print.c (safe_debug_print, print_object): Likewise.
3319 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3321 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3322 avoiding the 0 flag, which is not portable.
3323 * process.c (Fmake_network_process): Use pI to avoid cast.
3324 * region-cache.c (pp_cache): Likewise.
3325 * xdisp.c (decode_mode_spec): Likewise.
3326 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3327 behavior on 64-bit hosts with printf arg.
3328 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3329 (x_stop_queuing_selection_requests): Likewise.
3330 (x_get_window_property): Don't truncate byte count to an 'int'
3333 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3334 here, since it parses constructs like leading '-' and spaces,
3335 which are not wanted; and it overflows with large numbers.
3336 Instead, simply match F[0-9]+, which is what is wanted anyway.
3338 * alloc.c: Remove unportable assumptions about struct layout.
3339 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3340 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3341 (allocate_vectorlike, make_pure_vector): Use the new macros,
3342 plus offsetof, to remove unportable assumptions about struct layout.
3343 These assumptions hold on all porting targets that I know of, but
3344 they are not guaranteed, they're easy to remove, and removing them
3345 makes further changes easier.
3347 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3348 This doesn't fix a bug but makes the code clearer.
3349 (string_overrun_cookie): Now const. Use initializers that
3350 don't formally overflow signed char, to avoid warnings.
3351 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3352 can cause Emacs to crash when string overrun checking is enabled.
3353 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3354 multiple of sizeof (EMACS_INT); it need not be, if
3355 alignof(EMACS_INT) < sizeof (EMACS_INT).
3356 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3358 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3360 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3362 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3364 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3365 supposed to be handshaking. (Bug#8556)
3366 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3368 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3370 * lisp.h (Qdebug): List symbol.
3371 * eval.c (Qdebug): Restore global linkage.
3372 * keyboard.c (debug-on-event): New variable.
3373 (handle_user_signal): Break into debugger when debug-on-event
3374 matches the current signal symbol.
3376 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3378 * alloc.c (check_sblock, check_string_bytes)
3379 (check_string_free_list): Convert to standard C.
3381 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3383 * w32.c (emacs_gnutls_push): Fix typo.
3385 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3387 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3388 "cast to pointer from integer of different size".
3390 Improve doprnt and its use in verror. (Bug#8545)
3391 * doprnt.c (doprnt): Document the set of format control sequences
3392 supported by the function. Use SAFE_ALLOCA instead of always
3395 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3396 is one byte too soon. Don't use xrealloc; instead xfree and
3399 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3401 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3404 * gnutls.c: Renamed global_initialized to
3405 gnutls_global_initialized. Added internals for the
3406 :verify-hostname-error, :verify-error, and :verify-flags
3407 parameters of `gnutls-boot' and documented those parameters in the
3408 docstring. Start callback support.
3409 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3410 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3411 on error. Return error code.
3412 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3413 (emacs_gnutls_read): Likewise.
3414 (Fgnutls_boot): Return handshake error code.
3415 (emacs_gnutls_handle_error): New function.
3416 (wsaerror_to_errno): Likewise.
3418 * w32.h (emacs_gnutls_pull): Add prototype.
3419 (emacs_gnutls_push): Likewise.
3421 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3422 (emacs_gnutls_push): Likewise.
3424 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3426 * process.c (wait_reading_process_output): Check if GnuTLS
3427 buffered some data internally if no FDs are set for TLS
3430 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3431 (LIBS): Link to USER_LIBS.
3432 ($(BLD)/gnutls.$(0)): New target.
3434 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3436 * xdisp.c (handle_single_display_spec): Rename the
3437 display_replaced_before_p argument into display_replaced_p, to
3438 make it consistent with the commentary. Fix typos in the
3441 * textprop.c (syms_of_textprop): Remove dead code.
3442 (copy_text_properties): Delete obsolete commentary about an
3443 interface that was deleted long ago. Fix typos in the description
3446 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3447 to changes in oldXMenu/XMenu.h from 2011-04-16.
3448 <menu_help_message, prev_menu_help_message>: Constify.
3449 (IT_menu_make_room): menu->help_text is now `const char **';
3452 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3453 to changes in oldXMenu/XMenu.h from 2011-04-16.
3454 (struct XMenu): Declare `help_text' `const char **'.
3456 * xfaces.c <Qunspecified>: Make extern again.
3458 * syntax.c: Include sys/types.h before including regex.h, as
3461 * doc.c (get_doc_string): Improve the format passed to `error'.
3463 * doprnt.c (doprnt): Improve commentary.
3465 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3467 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3470 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3471 changes in globals.h immediately force recompilation.
3472 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3473 $(CURDIR)/s/ms-w32.h.
3474 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3476 * character.c (Fchar_direction): Function deleted.
3477 (syms_of_character): Don't defsubr it.
3478 <char-direction-table>: Deleted.
3480 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3482 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3483 * doprnt.c: Include limits.h.
3484 (SIZE_MAX): New macro.
3485 (doprnt): Return a size_t value. 2nd arg is now size_t.
3486 Many local variables are now size_t instead of int or unsigned.
3487 Improve overflow protection. Support `l' modifier for integer
3488 conversions. Support %l conversion. Don't assume an EMACS_INT
3489 argument for integer conversions and for %c.
3491 * lisp.h (doprnt): Restore prototype.
3493 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3496 * Makefile.in (base_obj): Add back doprnt.o.
3498 * deps.mk (doprnt.o): Add back prerequisites.
3499 (callint.o): Depend on character.h.
3501 * eval.c (internal_lisp_condition_case): Include the handler
3502 representation in the error message.
3503 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3504 when breaking from the loop.
3506 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3508 * callint.c (Fcall_interactively): When displaying error message
3509 about invalid control letter, pass the character's codepoint, not
3510 a pointer to its multibyte form. Improve display of the character
3511 in octal and display also its hex code.
3513 * character.c (char_string): Use %x to display the (unsigned)
3514 codepoint of an invalid character, to avoid displaying a bogus
3517 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3518 `error', not SYMBOL_NAME itself.
3520 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3521 character arguments to `error'.
3523 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3524 to `error' in error message about FINAL_CHAR argument. Make sure
3525 FINAL_CHAR is a character, and use %c when it is passed as
3526 argument to `error'.
3528 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3530 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3532 * w32.c: Include <time.h>.
3533 (sys_localtime): New function.
3535 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
3537 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3539 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
3541 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
3543 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3546 2011-04-19 Eli Zaretskii <eliz@gnu.org>
3548 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3549 gl_state.e_property when gl_state.object is Qt.
3551 * insdel.c (make_gap_larger): Remove limitation of buffer size
3554 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
3556 * xdisp.c (lookup_glyphless_char_display)
3557 (produce_glyphless_glyph): Handle cons cell entry in
3558 glyphless-char-display.
3559 (Vglyphless_char_display): Document it.
3561 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3562 glyphless-char-display.
3564 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
3566 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3568 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3570 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3571 definition for no-X builds.
3573 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
3575 Static checks with GCC 4.6.0 and non-default toolkits.
3577 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3579 * process.c (keyboard_bit_set): Define only if SIGIO.
3580 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3581 (send_process): Repair possible setjmp clobbering.
3583 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3585 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3587 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3589 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3590 Define only if needed.
3592 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3593 by pacifying GCC about it. Maybe it's time to retire it?
3594 * xfaces.c (USG, __TIMEVAL__): Likewise.
3596 * dispextern.h (struct redisplay_interface): Rename param
3598 * termhooks.h (struct terminal): Likewise.
3599 * xterm.c (xembed_send_message): Likewise.
3601 * insdel.c (make_gap_smaller): Define only if
3602 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3604 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3607 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3608 so that we aren't warned about unused symbols.
3610 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3612 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
3614 * xfns.c (x_real_positions): Mark locals as initialized.
3616 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3618 * xterm.c: Fix problems found by static analysis with other toolkits.
3619 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
3620 (x_dispatch_event): Declare static if USE_GTK, and
3621 define if USE_GTK || USE_X_TOOLKIT.
3622 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
3623 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
3624 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3625 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
3627 * xmenu.c (menu_help_callback): Pointer type fixes.
3628 Use const pointers when pointing at readonly data. Avoid pointer
3630 (FALSE): Remove unused macro.
3631 (update_frame_menubar): Remove unused decl.
3633 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3635 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3636 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3637 (single_menu_item): Rename local to avoid shadowing.
3639 * keyboard.c (make_lispy_event): Remove unused local var.
3641 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3642 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3644 * bitmaps: Change bitmaps from unsigned char back to the X11
3645 compatible char. Avoid the old compiler warnings about
3646 out-of-range initializers by using, for example, '\xab' rather
3649 * xgselect.c (xgselect_initialize): Check vs interface
3650 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3652 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3654 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3655 to read-only memory.
3657 * fns.c (vector): Remove; this old hack is no longer needed.
3659 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
3661 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
3663 * xrdb.c (x_load_resources): Omit unused local.
3665 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
3666 (x_window): Rename locals to avoid shadowing.
3667 (USG): Use the kludged USG macro, to pacify gcc.
3669 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
3670 (x_term_init): Remove local to avoid shadowing.
3672 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
3674 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3675 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3677 2011-04-16 Eli Zaretskii <eliz@gnu.org>
3679 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3681 Fix regex.c, syntax.c and friends for buffers > 2GB.
3682 * syntax.h (struct gl_state_s): Declare character position members
3685 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3687 * textprop.c (verify_interval_modification, interval_of):
3688 Declare arguments EMACS_INT.
3690 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3693 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3695 * indent.c (Fvertical_motion): Local variable it_start is now
3698 * regex.c (re_match, re_match_2, re_match_2_internal)
3699 (bcmp_translate, regcomp, regexec, print_double_string)
3700 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3701 (re_compile_pattern, re_exec): Declare arguments and local
3702 variables `size_t' and `ssize_t' and return values `regoff_t', as
3704 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3705 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3706 <compile_stack_type>: `size' and `avail' are now `size_t'.
3708 * regex.h <regoff_t>: Use ssize_t, not int.
3709 (re_search, re_search_2, re_match, re_match_2): Arguments that
3710 specify buffer/string position and length are now ssize_t and
3711 size_t. Return type is regoff_t.
3713 2011-04-16 Ben Key <bkey76@gmail.com>
3715 * nsfont.m: Fixed bugs in ns_get_family and
3716 ns_descriptor_to_entity that were caused by using free to
3717 deallocate memory blocks that were allocated by xmalloc (via
3718 xstrdup). This caused Emacs to crash when compiled with
3719 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3720 --enable-checking=xmallocoverrun). xfree is now used to
3721 deallocate these memory blocks.
3723 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3725 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3727 emacs_write: Accept and return EMACS_INT for sizes.
3728 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3730 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3731 Accept and return EMACS_INT.
3732 (emacs_gnutls_write): Return the number of bytes written on
3734 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
3735 (emacs_read, emacs_write): Remove check for negative size, as the
3736 Emacs source code has been audited now.
3737 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3738 (emacs_read, emacs_write): Use it.
3739 * process.c (send_process): Adjust to the new signatures of
3740 emacs_write and emacs_gnutls_write. Do not attempt to store
3741 a byte offset into an 'int'; it might overflow.
3742 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
3744 * sound.c: Don't assume sizes fit in 'int'.
3745 (struct sound_device.period_size, alsa_period_size):
3746 Return EMACS_INT, not int.
3747 (struct sound_device.write, vox_write, alsa_write):
3748 Accept EMACS_INT, not int.
3749 (wav_play, au_play): Use EMACS_INT to store sizes and to
3750 record read return values.
3752 2011-04-15 Ben Key <bkey76@gmail.com>
3754 * keyboard.c (Qundefined): Don't declare static since it is used
3756 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3757 static since they are used in nsfont.m.
3759 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3761 * process.c (Qprocessp): Don't declare static.
3762 * lisp.h (Qprocessp): Declare again.
3764 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
3766 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3768 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3770 Improve C-level modularity by making more things 'static'.
3772 Don't publish debugger-only interfaces to other modules.
3773 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3774 (verify_bytepos, count_markers): Move decls to the only modules
3776 * region-cache.h (pp_cache): Likewise.
3777 * window.h (check_all_windows): Likewise.
3778 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3780 * sysdep.c (croak): Now static, if
3781 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3782 * syssignal.h (croak): Declare only if not static.
3784 * alloc.c (refill_memory_reserve): Now static if
3785 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3786 * lisp.h (refill_memory_reserve): Declare only if not static.
3788 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3789 Define only if USE_LUCID.
3791 * xrdb.c (x_customization_string, x_rm_string): Now static.
3793 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3794 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3796 * xdisp.c (draw_row_with_mouse_face): Now static.
3797 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3799 * window.h (check_all_windows): Mark externally visible.
3801 * window.c (window_deletion_count): Now static.
3803 * undo.c: Make symbols static if they're not exported.
3804 (last_undo_buffer, last_boundary_position, pending_boundary):
3807 * textprop.c (interval_insert_behind_hooks): Now static.
3808 (interval_insert_in_front_hooks): Likewise.
3810 * term.c: Make symbols static if they're not exported.
3811 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3812 (max_frame_lines, tty_set_terminal_modes):
3813 (tty_reset_terminal_modes, tty_turn_off_highlight):
3814 (get_tty_terminal): Now static.
3815 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3816 * termhooks.h (term_mouse_moveto): Do not declare if
3818 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3819 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3821 * sysdep.c: Make symbols static if they're not exported.
3822 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3824 (sigprocmask_set, full_mask): Remove; unused.
3825 (wait_debugging): Mark as visible.
3826 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3827 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3829 * syntax.c (syntax_temp): Define only if !__GNUC__.
3831 * sound.c (current_sound_device, current_sound): Now static.
3833 * search.c (searchbufs, searchbuf_head): Now static.
3835 * scroll.c (scroll_cost): Remove; unused.
3836 * dispextern.h (scroll_cost): Remove decl.
3838 * region-cache.h (pp_cache): Mark as externally visible.
3840 * process.c: Make symbols static if they're not exported.
3841 (process_tick, update_tick, create_process, chan_process):
3842 (Vprocess_alist, proc_buffered_char, datagram_access):
3843 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3844 (deactivate_process): Mark defn as static, as well as decl.
3845 * lisp.h (create_process): Remove decl.
3846 * process.h (chan_process, Vprocess_alist): Remove decls.
3848 * print.c: Make symbols static if they're not exported.
3849 (print_depth, new_backquote_output, being_printed, print_buffer):
3850 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3851 (print_interval, print_number_index, initial_stderr_stream):
3853 * lisp.h (Fprinc): Remove decl.
3854 (debug_output_compilation_hack): Mark as externally visible.
3856 * sysdep.c (croak): Move decl from here to syssignal.h.
3857 * syssignal.h (croak): Put it here, so the API can be checked when
3858 'croak' is called from dissociate_if_controlling_tty.
3860 * minibuf.c: Make symbols static if they're not exported.
3861 (minibuf_save_list, choose_minibuf_frame): Now static.
3862 * lisp.h (choose_minibuf_frame): Remove decl.
3864 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3866 * lread.c: Make symbols static if they're not exported.
3867 (read_objects, initial_obarray, oblookup_last_bucket_number):
3869 (make_symbol): Remove; unused.
3870 * lisp.h (initial_obarray, make_symbol): Remove decls.
3872 * keyboard.c: Make symbols static if they're not exported.
3873 (single_kboard, recent_keys_index, total_keys, recent_keys):
3874 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3875 (this_single_command_key_start, echoing, last_auto_save):
3876 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3877 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3878 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3879 (Vlispy_mouse_stem, double_click_count):
3881 (force_auto_save_soon): Define only if SIGDANGER.
3882 (ignore_mouse_drag_p): Now static if
3883 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3884 (print_help): Remove; unused.
3885 (stop_character, last_timer_event): Mark as externally visible.
3886 * keyboard.h (ignore_mouse_drag_p): Declare only if
3887 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3888 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3889 * lisp.h (echoing): Remove decl.
3890 (force_auto_save_soon): Declare only if SIGDANGER.
3891 * xdisp.c (redisplay_window): Simplify code, to make it more
3892 obvious that ignore_mouse_drag_p is not accessed if !defined
3893 USE_GTK && !defined HAVE_NS.
3895 * intervals.c: Make symbols static if they're not exported.
3896 (merge_properties_sticky, merge_interval_right, delete_interval):
3898 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3900 * insdel.c: Make symbols static if they're not exported.
3901 However, leave prepare_to_modify_buffer alone. It's never
3902 called from outside this function, but that appears to be a bug.
3903 (combine_after_change_list, combine_after_change_buffer):
3904 (adjust_after_replace, signal_before_change): Now static.
3905 (adjust_after_replace_noundo): Remove; unused.
3906 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
3907 (signal_before_change): Remove decls.
3909 * indent.c (val_compute_motion, val_vmotion): Now static.
3911 * image.c: Make symbols static if they're not exported.
3912 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3914 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3915 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3917 * fringe.c (standard_bitmaps): Now static.
3918 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3920 * frame.c: Make symbols static if they're not exported.
3921 (x_report_frame_params, make_terminal_frame): Now static.
3922 (get_frame_param): Now static, unless HAVE_NS.
3923 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3924 (x_get_resource_string): Remove; not used.
3925 * frame.h (make_terminal_frame, x_report_frame_params):
3926 (x_get_resource_string); Remove decls.
3927 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3928 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3930 * font.c, fontset.c: Make symbols static if they're not exported.
3931 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3932 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3933 * font.c (font_close_object): Now static.
3934 * font.h (font_close_object): Remove.
3935 * fontset.c (FONTSET_OBJLIST): Remove.
3936 (free_realized_fontset) #if-0 the body, which does nothing.
3937 (face_suitable_for_char_p): #if-0, as it's never called.
3938 * fontset.h (face_suitable_for_char_p): Remove decl.
3939 * xfaces.c (face_at_string_position):
3940 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
3941 since 0 is always ASCII.
3943 * fns.c (weak_hash_tables): Now static.
3945 * fileio.c: Make symbols static if they're not exported.
3946 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3947 (Vwrite_region_annotation_buffers): Now static.
3949 * eval.c: Make symbols static if they're not exported.
3950 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3951 * lisp.h (backtrace_list): Remove decl.
3953 * emacs.c: Make symbols static if they're not exported.
3954 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3955 (fatal_error_code, fatal_error_signal_hook, standard_args):
3957 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3958 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3959 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3960 * lisp.h (fatal_error_signal_hook): Remove decl.
3961 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3963 * editfns.c: Move a (normally-unused) function to its only use.
3964 * editfns.c, lisp.h (get_operating_system_release): Remove.
3965 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3966 worth the hassle of breaking this out.
3968 * xterm.c: Make symbols static if they're not exported.
3969 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3970 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3971 (x_destroy_window, x_delete_display):
3973 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3974 (x_mouse_leave): Remove; unused.
3975 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3976 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3977 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3979 (x_mouse_leave): Declare only if WINDOWSNT.
3980 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3981 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3984 * ftxfont.c: Make symbols static if they're not exported.
3985 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3987 * font.h (ftxfont_driver): Likewise.
3989 * xfns.c: Make symbols static if they're not exported.
3990 (x_last_font_name, x_display_info_for_name):
3991 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3992 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3993 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3994 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3995 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3996 (last_show_tip_args): Now static.
3997 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3998 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3999 (x_screen_planes): Remove; unused.
4000 * dispextern.h (x_screen_planes): Remove decl.
4002 * dispnew.c: Make symbols static if they're not exported.
4003 * dispextern.h (redraw_garbaged_frames, scrolling):
4004 (increment_row_positions): Remove.
4005 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4006 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4008 (redraw_garbaged_frames): Remove; unused.
4010 * xfaces.c: Make symbols static if they're not exported.
4011 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4013 * xterm.h (defined_color): Remove decls.
4014 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4015 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4016 (menu_face_changed_default, defined_color, free_realized_face):
4017 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4018 (ascii_face_of_lisp_face): Remove; unused.
4020 * xdisp.c: Make symbols static if they're not exported.
4021 * dispextern.h (scratch_glyph_row, window_box_edges):
4022 (glyph_to_pixel_coords, set_cursor_from_row):
4023 (get_next_display_element, set_iterator_to_next):
4024 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4025 (show_mouse_face): Remove decls
4026 * frame.h (message_buf_print): Likewise.
4027 * lisp.h (pop_message, set_message, check_point_in_composition):
4029 * xterm.h (set_vertical_scroll_bar): Likewise.
4030 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4031 (message_buf_print, scratch_glyph_row, displayed_buffer):
4032 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4033 (get_next_display_element, show_mouse_face, window_box_edges):
4034 (frame_to_window_pixel_xy, check_point_in_composition):
4035 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4036 (glyph_to_pixel_coords): Remove; unused.
4038 * dired.c (file_name_completion): Now static.
4040 * dbusbind.c (xd_in_read_queued_messages): Now static.
4042 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4043 * data.c (circular_list_error): Remove.
4045 * commands.h (last_point_position, last_point_position_buffer):
4046 (last_point_position_window): Remove decls.
4047 * keyboard.c: Make these variables static.
4049 * coding.h (coding, code_convert_region, encode_coding_gap):
4051 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4052 (iso_code_class, detect_coding, code_convert_region): Now static.
4053 (encode_coding_gap): Remove; unused.
4055 * chartab.c (chartab_chars, chartab_bits): Now static.
4057 * charset.h (charset_iso_8859_1): Remove decl.
4058 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4061 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4062 * ccl.c (Vccl_program_table): Now static.
4063 (check_ccl_update): Remove; unused.
4065 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4066 * category.h: ... from here.
4067 * category.c (check_category_table, set_category_set): Now static.
4069 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4070 * lisp.h: Remove these decls.
4072 * buffer.c (buffer_count): Remove unused var.
4074 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4075 so that it's not optimized away.
4076 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4077 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4078 exported only to the debugger.
4080 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4081 * atimer.h (run_all_atimers): Remove; not exported.
4083 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4084 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4085 was inaccessible from Lisp.
4086 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4087 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4089 alloc.c: Import and export fewer symbols, and remove unused items.
4090 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4092 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4093 it's not optimized away by whole-program optimization.
4094 (message_enable_multibyte, free_misc): Remove.
4095 (catchlist, handlerlist, mark_backtrace):
4096 Declare only if BYTE_MARK_STACK.
4097 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4098 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4099 (message_enable_multibyte): Remove decl.
4100 (free_misc, interval_free_list, float_block, float_block_index):
4101 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4102 (cons_free_list, last_marked_index):
4104 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4105 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4106 (mark_backtrace): Define only if BYTE_MARK_STACK.
4107 * xdisp.c (message_enable_multibyte): Now static.
4109 Declare Lisp_Object Q* variables to be 'static' if not exported.
4110 This makes it easier for human readers (and static analyzers)
4111 to see whether these variables are used from other modules.
4112 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4113 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4114 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4115 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4116 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4117 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4118 * xmenu.c, xselect.c:
4119 Declare Q* vars static if they are not used in other modules.
4120 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4121 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4122 Remove decls of unexported vars.
4123 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4125 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4127 Make Emacs functions such as Fatom 'static' by default.
4128 This makes it easier for human readers (and static analyzers)
4129 to see whether these functions can be called from other modules.
4130 DEFUN now defines a static function. To make the function external
4131 so that it can be used in other C modules, use the new macro DEFUE.
4132 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4133 (Finit_image_library):
4134 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4135 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4136 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4137 Remove decls, since these functions are now static.
4138 (Funintern, Fget_internal_run_time): New decls, since these functions
4139 were already external.
4141 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4142 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4143 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4144 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4145 * keyboard.c, keymap.c, lread.c:
4146 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4147 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4148 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4149 Mark functions with DEFUE instead of DEFUN,
4150 if they are used in other modules.
4151 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4152 decls for now-static functions.
4153 * buffer.h (Fdelete_overlay): Remove decl.
4154 * callproc.c (Fgetenv_internal): Mark as internal.
4155 * composite.c (Fremove_list_of_text_properties): Remove decl.
4156 (Fcomposition_get_gstring): New forward static decl.
4157 * composite.h (Fcomposite_get_gstring): Remove decl.
4158 * dired.c (Ffile_attributes): New forward static decl.
4159 * doc.c (Fdocumntation_property): New forward static decl.
4160 * eval.c (Ffetch_bytecode): New forward static decl.
4161 (Funintern): Remove extern decl; now in .h file where it belongs.
4162 * fileio.c (Fmake_symbolic_link): New forward static decl.
4163 * image.c (Finit_image_library): New forward static decl.
4164 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4165 * intervals.h (Fprevious_property_change):
4166 (Fremove_list_of_text_properties): Remove decls.
4167 * keyboard.c (Fthis_command_keys): Remove decl.
4168 (Fcommand_execute): New forward static decl.
4169 * keymap.c (Flookup_key): New forward static decl.
4170 (Fcopy_keymap): Now static.
4171 * keymap.h (Flookup_key): Remove decl.
4172 * process.c (Fget_process): New forward static decl.
4173 (Fprocess_datagram_address): Mark as internal.
4174 * syntax.c (Fsyntax_table_p): New forward static decl.
4175 (skip_chars): Remove duplicate decl.
4176 * textprop.c (Fprevious_property_change): New forward static decl.
4177 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4179 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4180 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4182 * editfns.c (Fformat): Remove unreachable code.
4184 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4186 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4189 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4191 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4192 when at ZV. (Bug#8487)
4194 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4196 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4198 * keyboard.c (parse_tool_bar_item): Likewise.
4199 * sound.c (sound_cleanup, alsa_close): Likewise.
4200 * termcap.c (tgetent): Likewise.
4201 * xfns.c (x_default_font_parameter): Likewise.
4202 * xsettings.c (read_and_apply_settings): Likewise.
4204 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4205 (overrun_check_free): Protoize.
4207 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4209 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4210 since callers should never pass a negative size.
4211 Change the signature to match that of plain 'read' and 'write'; see
4212 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4213 * lisp.h: Update prototypes of emacs_write and emacs_read.
4215 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4217 * xdisp.c (redisplay_window): Don't try to determine the character
4218 position of the scroll margin if the window start point w->startp
4219 is outside the buffer's accessible region. (Bug#8468)
4221 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4223 Fix write-region and its subroutines for buffers > 2GB.
4224 * fileio.c (a_write, e_write): Modify declaration of arguments and
4225 local variables to support buffers larger than 2GB.
4226 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4228 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4229 argument, local variables, and return value.
4231 * lisp.h: Update prototypes of emacs_write and emacs_read.
4233 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4235 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4237 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4239 Fix more problems found by GCC 4.6.0's static checks.
4241 * xdisp.c (vmessage): Use a better test for character truncation.
4243 * charset.c (load_charset_map): <, not <=, for optimization,
4244 and to avoid potential problems with integer overflow.
4245 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4246 * casetab.c (set_identity, shuffle): Likewise.
4247 * editfns.c (Fformat): Likewise.
4248 * syntax.c (skip_chars): Likewise.
4250 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4251 This also lets GCC 4.6.0 generate slightly better loop code.
4253 * callint.c (Fcall_interactively): <, not <=, for optimization.
4254 (Fcall_interactively): Count the number of arguments produced,
4255 not the number of arguments given. This is simpler and lets GCC
4256 4.6.0 generate slightly better code.
4258 * ftfont.c: Distingish more carefully between FcChar8 and char.
4259 The previous code passed unsigned char * to a functions like
4260 strlen and xstrcasecmp that expect char *, which does not
4261 conform to the C standard.
4262 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4263 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4264 char * when the C standard requires it.
4266 * keyboard.c (read_char): Remove unused var.
4268 * eval.c: Port to Windows vsnprintf (Bug#8435).
4270 (SIZE_MAX): Define if the headers do not.
4271 (verror): Do not give up if vsnprintf returns a negative count.
4272 Instead, grow the buffer. This ports to Windows vsnprintf, which
4273 does not conform to C99. Problem reported by Eli Zaretskii.
4274 Also, simplify the allocation scheme, by avoiding the need for
4275 calling realloc, and removing the ALLOCATED variable.
4277 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4279 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4280 But keep the doprint source code for now, as we might revamp it
4281 and use it again (Bug#8435).
4282 * lisp.h (doprnt): Remove.
4283 * Makefile.in (base_obj): Remove doprnt.o.
4284 * deps.mk (doprnt.o): Remove.
4286 error: Print 32- and 64-bit integers portably (Bug#8435).
4287 Without this change, on typical 64-bit hosts error ("...%d...", N)
4288 was used to print both 32- and 64-bit integers N, which relied on
4290 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4292 * lisp.h (error, verror): Mark as printf-like functions.
4293 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4294 Report overflow in size calculations when allocating printf buffer.
4295 Do not truncate output string at its first null byte.
4296 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4297 Truncate the output at a character boundary, since vsnprintf does not
4299 * charset.c (check_iso_charset_parameter): Convert internal
4300 character to string before calling 'error', since %c now has the
4302 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4303 overflow when computing char to be passed to 'error'. Do not
4304 pass Lisp_Object to 'error'; pass the integer instead.
4305 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4306 formatted with plain %d.
4308 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4310 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4312 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4314 * xterm.c (x_catch_errors): Remove duplicate declaration.
4316 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4318 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4320 2011-04-10 Jim Meyering <meyering@redhat.com>
4322 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4323 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4324 return ssize_t not "int", and use size_t as the buffer length.
4325 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4326 * gnutls.h: Update declarations.
4327 * process.c (read_process_output): Use ssize_t, to match.
4328 (send_process): Likewise.
4330 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4332 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4334 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4336 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4337 Use unsigned char, to match FcChar8 type definition.
4339 * xterm.c (handle_one_xevent):
4340 * xmenu.c (create_and_show_popup_menu):
4341 * xselect.c (x_decline_selection_request)
4342 (x_reply_selection_request): Avoid type-punned deref of X events.
4344 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4346 Fix some uses of `int' instead of EMACS_INT.
4347 * search.c (string_match_1, fast_string_match)
4348 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4349 (scan_buffer, find_next_newline_no_quit)
4350 (find_before_next_newline, search_command, Freplace_match)
4351 (Fmatch_data): Make some `int' variables be EMACS_INT.
4353 * xdisp.c (display_count_lines): 3rd argument and return value now
4354 EMACS_INT. All callers changed.
4355 (pint2hrstr): Last argument is now EMACS_INT.
4357 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4358 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4359 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4360 (decode_coding_utf_16, decode_coding_emacs_mule)
4361 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4362 (decode_coding_ccl, decode_coding_charset)
4363 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4364 (decode_coding_iso_2022, decode_coding_emacs_mule)
4365 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4366 <char_offset, last_offset>: Declare EMACS_INT.
4367 (encode_coding_utf_8, encode_coding_utf_16)
4368 (encode_coding_emacs_mule, encode_invocation_designation)
4369 (encode_designation_at_bol, encode_coding_iso_2022)
4370 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4371 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4373 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4374 (encode_invocation_designation): Last argument P_NCHARS is now
4376 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4377 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4379 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4382 * ccl.c (Fccl_execute_on_string): Declare some variables
4385 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4387 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4389 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4391 * process.c (Fformat_network_address): Doc fix.
4393 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4395 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4397 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4399 * keyboard.c (read_char): Call Lisp function help-form-show,
4400 instead of using internal_with_output_to_temp_buffer.
4401 (Qhelp_form_show): New var.
4402 (syms_of_keyboard): Use DEFSYM macro.
4404 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4406 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4408 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4410 * process.c (Flist_processes): Remove to Lisp.
4411 (list_processes_1): Delete.
4413 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4415 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4417 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4419 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4421 Fix more problems found by GCC 4.6.0's static checks.
4423 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4425 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4427 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4429 * xdisp.c (vmessage): Mark as a printf-like function.
4431 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4433 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4435 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4436 printf-like functions.
4437 (tiff_load): Add casts to remove these marks before passing them
4438 to system-supplied API.
4440 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4442 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4443 This avoids several warnings with gcc -Wstrict-overflow.
4444 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4445 directly, rather than having caller test rule sign. This avoids
4446 some unnecessary tests.
4447 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4448 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4449 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4451 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4452 (xfont_open): Avoid unnecessary tests.
4454 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4456 * composite.h, composite.c (composition_gstring_put_cache):
4457 Use EMACS_INT, not int, for length.
4459 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4460 breaking out part of COMPOSITION_DECODE_RULE.
4461 (COMPOSITION_DECODE_RULE): Use it.
4462 * composite.c (get_composition_id): Remove unused local vars,
4463 by using the new macro.
4465 * textprop.c (set_text_properties_1): Change while to do-while,
4466 since the condition is always true at first.
4468 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4469 (interval_deletion_adjustment): Return unsigned value.
4472 * process.c (list_processes_1, create_pty, read_process_output):
4473 (exec_sentinel): Remove vars that were set but not used.
4474 (create_pty): Remove unnecessary "volatile"s.
4475 (Fnetwork_interface_info): Avoid possibility of int overflow.
4476 (read_process_output): Do adaptive read buffering even if carryover.
4477 (read_process_output): Simplify nbytes computation if buffered.
4479 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4481 * syntax.c (scan_words): Remove var that was set but not used.
4482 (update_syntax_table): Use unsigned instead of int.
4484 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4485 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4486 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4488 * print.c (print_error_message): Avoid int overflow.
4490 * font.c (font_list_entities): Redo for clarity,
4491 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4493 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4494 (font_score): Avoid potential overflow in diff calculation.
4496 * fns.c (substring_both): Remove var that is set but not used.
4497 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4499 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4501 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4502 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4503 can always succeed if overflow has undefined behavior.
4505 * search.c (boyer_moore, wordify): Remove vars set but not used.
4506 (wordify): Omit three unnecessary tests.
4508 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4509 All callers changed. This avoids the need for an unused var.
4511 * casefiddle.c (casify_region): Remove var that is set but not used.
4513 * dired.c (file_name_completion): Remove var that is set but not used.
4515 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4517 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4518 (Finsert_file_contents): Remove unnecessary code checking fd.
4520 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4521 Check for integer overflow on size calculations.
4523 * buffer.c (Fprevious_overlay_change): Remove var that is set
4526 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4527 Remove vars that are set but not used.
4528 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4529 (timer_check_2): Mark vars as initialized.
4531 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4533 * image.c (lookup_image): Remove var that is set but not used.
4534 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
4536 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4537 that are set but not used.
4539 * xfns.c (make_invisible_cursor): Don't return garbage
4540 if XCreateBitmapFromData fails (Bug#8410).
4542 * xselect.c (x_get_local_selection, x_handle_property_notify):
4543 Remove vars that are set but not used.
4545 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
4546 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
4548 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4549 Remove var that is set but not used.
4550 (scroll_bar_windows_size): Now size_t, not int.
4551 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4554 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4555 (map_tty_color) [!defined MSDOS]: Likewise.
4557 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4559 * coding.c: Remove vars that are set but not used.
4560 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4561 All callers changed.
4562 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4563 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4564 (decode_coding_charset): Remove vars that are set but not used.
4566 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4567 that is set but not used.
4569 * print.c (print_object): Remove var that is set but not used.
4571 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
4572 The gnulib version avoids calling malloc in the usual case,
4573 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4574 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4575 * filelock.c (current_lock_owner): Likewise.
4576 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4577 * sysdep.c: Include allocator.h, careadlinkat.h.
4578 (emacs_no_realloc_allocator): New static constant.
4579 (emacs_readlink): New function.
4580 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4581 ../lib/careadlinkat.h.
4583 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4585 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4586 first non-nil return value).
4588 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4590 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4591 if not defined (Bug#8403).
4593 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4595 * xdisp.c (display_count_lines): Remove parameter `start',
4596 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4597 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4598 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4599 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4600 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4601 and thereabouts. All callers changed.
4602 (get_per_char_metric): Remove parameter `f', unused since
4603 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4605 2011-04-02 Jim Meyering <meyering@redhat.com>
4607 do not dereference NULL upon failed strdup
4608 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4609 (ns_get_family): Likewise.
4611 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4613 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4615 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4617 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4620 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4622 Add lexical binding.
4624 * window.c (Ftemp_output_buffer_show): New fun.
4625 (Fsave_window_excursion):
4626 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4628 * lread.c (lisp_file_lexically_bound_p): New function.
4629 (Fload): Bind Qlexical_binding.
4630 (readevalloop): Remove `evalfun' arg.
4631 Bind Qinternal_interpreter_environment.
4632 (Feval_buffer): Bind Qlexical_binding.
4633 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4635 (syms_of_lread): Declare `lexical-binding'.
4637 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4639 * keyboard.c (eval_dyn): New fun.
4640 (menu_item_eval_property): Use it.
4642 * image.c (parse_image_spec): Use Ffunctionp.
4644 * fns.c (concat, mapcar1): Accept byte-code-functions.
4646 * eval.c (Fsetq): Handle lexical vars.
4647 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4648 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4649 (FletX, Flet): Obey lexical binding.
4650 (Fcommandp): Handle closures.
4651 (Feval): New `lexical' arg.
4652 (eval_sub): New function extracted from Feval. Use it almost
4653 everywhere where Feval was used. Look up vars in lexical env.
4655 (Ffunctionp): Move from subr.el.
4656 (Ffuncall): Handle closures.
4657 (apply_lambda): Remove `eval_flags'.
4658 (funcall_lambda): Handle closures and new byte-code-functions.
4659 (Fspecial_variable_p): New function.
4660 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4661 but without exporting it to Lisp.
4663 * doc.c (Fdocumentation, store_function_docstring):
4664 * data.c (Finteractive_form): Handle closures.
4666 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4669 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4671 (exec_byte_code): New function extracted from Fbyte_code to handle new
4672 calling convention for byte-code-functions. Add new byte-codes.
4674 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
4676 * alloc.c (Fmake_symbol): Init new `declared_special' field.
4678 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4680 * xdisp.c (redisplay_internal): Fix prototype.
4682 2011-03-31 Eli Zaretskii <eliz@gnu.org>
4684 * xdisp.c (SCROLL_LIMIT): New macro.
4685 (try_scrolling): Use it when setting scroll_limit.
4686 Limit scrolling to 100 screen lines.
4687 (redisplay_window): Even when falling back on "recentering",
4688 position point in the window according to scroll-conservatively,
4689 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4691 (try_scrolling): When point is above the window, allow searching
4692 as far as scroll_max, or one screenful, to compute vertical
4693 distance from PT to the scroll margin position. This prevents
4694 try_scrolling from unnecessarily failing when
4695 scroll-conservatively is set to a value slightly larger than the
4696 window height. Clean up the case of PT below the margin at bottom
4697 of window: scroll_max can no longer be INT_MAX. When aggressive
4698 scrolling is in use, don't let point enter the opposite scroll
4699 margin as result of the scroll.
4700 (syms_of_xdisp) <scroll-conservatively>: Document the
4701 threshold of 100 lines for never-recentering scrolling.
4703 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4705 * dispextern.h (move_it_by_lines):
4706 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4707 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4708 (message_log_check_duplicate): Remove parameters `prev_bol' and
4709 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4710 (redisplay_internal): Remove parameter `preserve_echo_area',
4711 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4713 * indent.c (Fvertical_motion):
4714 * window.c (window_scroll_pixel_based, Frecenter):
4715 Don't pass `need_y_p' to `move_it_by_lines'.
4717 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4719 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4720 steal a few bits to be more compact.
4721 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4722 Remove unneeded casts.
4724 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4726 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4728 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4729 binding" message (bug#7967).
4731 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4733 Fix more problems found by GCC 4.6.0's static checks.
4735 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4736 Remove unused local var.
4738 * editfns.c (Fmessage_box): Remove unused local var.
4740 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4741 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4742 Omit unused local vars.
4743 * window.c (shrink_windows): Omit unused local var.
4744 * menu.c (digest_single_submenu): Omit unused local var.
4745 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4746 Omit unused local var.
4748 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4749 Don't assume string length fits in int.
4750 (keyremap_step, read_key_sequence): Use size_t for sizes.
4751 (read_key_sequence): Don't check last_real_key_start redundantly.
4753 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4754 instead of alloca (Bug#8344).
4756 * eval.c (Fbacktrace): Don't assume nargs fits in int.
4757 (Fbacktrace_frame): Don't assume nframes fits in int.
4759 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4761 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4764 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4766 * cm.c (calccost): Turn while-do into do-while, for clarity.
4768 * keyboard.c (syms_of_keyboard): Use the same style as later
4769 in this function when indexing through an array. This also
4770 works around GCC bug 48267.
4772 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4774 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4776 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4777 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4779 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4780 This avoids undefined behavior on integer overflow, and is a bit
4781 more convenient anyway since it is compared to a size_t variable.
4783 Variadic C functions now count arguments with size_t, not int.
4784 This avoids an unnecessary limitation on 64-bit machines, which
4785 caused (substring ...) to crash on large vectors (Bug#8344).
4786 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4787 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
4788 All variadic functions and their callers changed accordingly.
4789 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4790 * data.c (arith_driver, float_arith_driver): Likewise.
4791 * editfns.c (general_insert_function): Likewise.
4792 * eval.c (struct backtrace.nargs, interactive_p)
4793 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4794 (funcall_lambda, mark_backtrace): Likewise.
4795 * fns.c (concat): Likewise.
4796 * frame.c (x_set_frame_parameters): Likewise.
4797 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4798 0 if not found, not -1. All callers changed.
4800 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4801 (stack_copy_size): Now size_t, not int.
4802 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4804 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4806 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4807 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4808 All callers changed.
4810 * lisp.h (multibyte_char_to_unibyte):
4811 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4812 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4813 * character.h (CHAR_TO_BYTE8):
4814 * cmds.c (internal_self_insert):
4815 * editfns.c (general_insert_function):
4816 * keymap.c (push_key_description):
4817 * search.c (Freplace_match):
4818 * xdisp.c (message_dolog, set_message_1): All callers changed.
4820 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4822 * keyboard.c (safe_run_hook_funcall): New function.
4823 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4824 don't set the hook to nil, but remove the offending function instead.
4825 (Qcommand_hook_internal): Remove, unused.
4826 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4827 Vcommand_hook_internal.
4829 * eval.c (enum run_hooks_condition): Remove.
4830 (funcall_nil, funcall_not): New functions.
4831 (run_hook_with_args): Call each function through a `funcall' argument.
4832 Remove `cond' argument, now redundant.
4833 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4834 (Frun_hook_with_args_until_failure): Adjust accordingly.
4835 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4837 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4839 * dispextern.h (string_buffer_position): Remove declaration.
4841 * print.c (strout): Remove parameter `multibyte', unused since
4842 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4844 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4845 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4846 All callers changed.
4848 * w32.c (_wsa_errlist): Use braces for struct initializers.
4850 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4851 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4852 All callers changed.
4853 (string_buffer_position): Likewise. Also, make static (it's never
4854 used outside xdisp.c).
4855 (cursor_row_p): Remove parameter `w', unused since
4856 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4857 (decode_mode_spec): Remove parameter `precision', introduced during
4858 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4859 All callers changed.
4861 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4863 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4865 2011-03-27 Anders Lindgren <andlind@gmail.com>
4867 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4868 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4869 (ns_update_auto_hide_menu_bar): New functions.
4870 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4871 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4872 ns_constrain_all_frames.
4873 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4874 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4876 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4878 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4880 2011-03-27 Glenn Morris <rgm@gnu.org>
4882 * syssignal.h: Replace RETSIGTYPE with void.
4883 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4884 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4885 Replace SIGTYPE with void everywhere.
4886 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4887 * s/template.h (SIGTYPE): Remove commented out definition.
4889 2011-03-26 Eli Zaretskii <eliz@gnu.org>
4891 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4892 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4894 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
4896 * w32.c (read_unc_volume): Use parameter `henum', instead of
4897 global variable `wget_enum_handle'.
4899 * keymap.c (describe_vector): Remove parameters `indices' and
4900 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4901 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4903 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4905 * keyboard.c (timer_check): Remove parameter `do_it_now',
4906 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4907 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4908 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4910 * keyboard.c (read_char):
4911 * w32menu.c (w32_menu_display_help):
4912 * xmenu.c (show_help_event, menu_help_callback):
4913 Adjust calls to `show_help_echo'.
4915 * gtkutil.c (xg_maybe_add_timer):
4916 * keyboard.c (readable_events):
4917 * process.c (wait_reading_process_output):
4918 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4920 * insdel.c (adjust_markers_gap_motion):
4921 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4922 (gap_left, gap_right): Don't call it.
4924 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
4926 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4927 incurred during fontification.
4929 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4931 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4932 (DEFVAR_PER_BUFFER): Don't pass it.
4934 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4935 (scrolling_window): Don't pass it.
4937 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4939 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4941 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4943 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4944 of variables specific to SELinux and computation of `encoded_absname'.
4946 * image.c (XPutPixel): Remove unused variable `height'.
4948 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4950 * unexw32.c (get_section_info): Remove unused variable `section'.
4952 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4953 (system_process_attributes): Remove unused variable `sess'.
4954 (sys_read): Remove unused variable `err'.
4956 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4957 (w32_wnd_proc): Remove unused variable `isdead'.
4958 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4959 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4960 (x_create_tip_frame): Remove unused variable `tem'.
4962 * w32inevt.c (w32_console_read_socket):
4963 Remove unused variable `no_events'.
4965 * w32term.c (x_draw_composite_glyph_string_foreground):
4966 Remove unused variable `width'.
4968 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
4970 * w32term.c (x_set_glyph_string_clipping):
4971 Don't pass uninitialized region to CombineRgn.
4973 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
4975 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4976 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4977 (Fx_close_connection): Remove unused variable `i'.
4979 * w32font.c (w32font_draw): Return number of glyphs.
4980 (w32font_open_internal): Remove unused variable `i'.
4981 (w32font_driver): Add missing initializer.
4983 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4984 (fill_in_menu): Remove unused variable `items_added'.
4986 * w32term.c (last_mouse_press_frame): Remove static global variable.
4987 (w32_clip_to_row): Remove unused variable `f'.
4988 (x_delete_terminal): Remove unused variable `i'.
4990 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4991 (NOTHING): Remove unused static global variable.
4992 (uniscribe_check_otf): Remove unused variable `table'.
4993 (uniscribe_font_driver): Add missing initializers.
4995 2011-03-23 Julien Danjou <julien@danjou.info>
4997 * term.c (Fsuspend_tty, Fresume_tty):
4998 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4999 * window.c (temp_output_buffer_show):
5000 * insdel.c (signal_before_change):
5001 * frame.c (Fhandle_switch_frame):
5002 * fileio.c (Fdo_auto_save):
5003 * emacs.c (Fkill_emacs):
5004 * editfns.c (save_excursion_restore):
5005 * cmds.c (internal_self_insert):
5006 * callint.c (Fcall_interactively):
5007 * buffer.c (Fkill_all_local_variables):
5008 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5010 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5011 unconditionnaly since it does the check itself.
5013 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5015 Fix more problems found by GCC 4.5.2's static checks.
5017 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5018 the first time through the loop, since we know p0 < p1 then.
5019 This also avoids a gcc -Wstrict-overflow warning.
5021 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5022 leading to a memory leak, possible in functions like
5023 load_charset_map_from_file that can allocate an unbounded number
5024 of objects (Bug#8318).
5026 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5027 that could (at least in theory) be that large.
5029 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5030 This is less likely to overflow, and avoids undefined behavior if
5031 overflow does occur. All callers changed. Use strtoul to scan
5032 for the unsigned long integer.
5033 (pint2hrstr): Simplify and tune code slightly.
5034 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5036 * scroll.c (do_scrolling): Work around GCC bug 48228.
5037 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5039 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5040 This also avoids a warning with gcc -Wstrict-overflow.
5041 (validate_x_resource_name): Simplify count usage.
5042 This also avoids a warning with gcc -Wstrict-overflow.
5044 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5047 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5049 * process.c (Fmake_network_process): Use socklen_t, not int,
5050 where POSIX says socklen_t is required in portable programs.
5051 This fixes a porting bug on hosts like 64-bit HP-UX, where
5052 socklen_t is wider than int (Bug#8277).
5053 (Fmake_network_process, server_accept_connection):
5054 (wait_reading_process_output, read_process_output):
5057 * process.c: Rename or move locals to avoid shadowing.
5058 (list_processes_1, Fmake_network_process):
5059 (read_process_output_error_handler, exec_sentinel_error_handler):
5060 Rename or move locals.
5061 (Fmake_network_process): Define label "retry_connect" only if needed.
5062 (Fnetwork_interface_info): Fix pointer signedness.
5063 (process_send_signal): Add cast to avoid pointer signedness problem.
5064 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5065 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5067 Make tparam.h and terminfo.c consistent.
5068 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5069 Include tparam.h instead, since it declares them.
5070 * cm.h (PC): Remove extern decl; tparam.h now does this.
5071 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5072 * terminfo.c: Include tparam.h, to check interfaces.
5073 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5074 (tparam): Adjust signature to match interface in tparam.h;
5075 this removes some undefined behavior. Check that outstring and len
5076 are zero, which they always are with Emacs.
5077 * tparam.h (PC, BC, UP): New extern decls.
5079 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5080 (xftfont_open): Rename locals to avoid shadowing.
5082 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5083 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5084 (OTF_TAG_SYM): Omit macro if not needed.
5085 (ftfont_list): Remove unused local.
5086 (get_adstyle_property, ftfont_pattern_entity):
5087 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5088 Rename locals to avoid shadowing.
5090 * xfont.c (xfont_list_family): Mark var as initialized.
5092 * xml.c (make_dom): Now static.
5094 * composite.c (composition_compute_stop_pos): Rename local to
5096 (composition_reseat_it): Remove unused locals.
5097 (find_automatic_composition, composition_adjust_point): Likewise.
5098 (composition_update_it): Mark var as initialized.
5099 (find_automatic_composition): Mark vars as initialized,
5100 with a FIXME (Bug#8290).
5102 character.h: Rename locals to avoid shadowing.
5103 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5104 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5105 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5106 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5109 * textprop.c (property_change_between_p): Remove; unused.
5111 * intervals.c (interval_start_pos): Now static.
5113 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5115 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5116 Rename locals to avoid shadowing.
5118 * sound.c (wav_play, au_play, Fplay_sound_internal):
5119 Fix pointer signedness.
5120 (alsa_choose_format): Remove unused local var.
5121 (wav_play): Initialize a variable to 0, to prevent undefined
5122 behavior (Bug#8278).
5124 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5126 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5128 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5129 clobbering (Bug#8298).
5130 * sysdep.c (sys_subshell): Likewise.
5131 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5133 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5134 This should get cleaned up, so that child_setup has the
5135 same signature on all platforms.
5137 * callproc.c (call_process_cleanup): Now static.
5138 (relocate_fd): Rename locals to avoid shadowing.
5140 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5142 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5143 not to be necessary, and produces flickering.
5145 2011-03-20 Glenn Morris <rgm@gnu.org>
5147 * config.in: Remove file.
5149 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5151 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5152 are now in src/globals.h.
5153 (syms_of_minibuf): Remove spurious & from previous change.
5155 2011-03-20 Leo <sdl.web@gmail.com>
5157 * minibuf.c (completing-read-function): New variable.
5158 (completing-read-default): Rename from completing-read.
5159 (completing-read): Call completing-read-function.
5161 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5163 * xfaces.c (Fx_load_color_file):
5164 Read color file from absolute filename (bug#8250).
5166 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5168 * makefile.w32-in: Update dependencies.
5170 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5172 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5174 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5176 Fix more problems found by GCC 4.5.2's static checks.
5178 * process.c (make_serial_process_unwind, send_process_trap):
5179 (sigchld_handler): Now static.
5181 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5182 That way, the code declares only the vars that it needs.
5183 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5184 * s/cygwin.h (PTY_ITERATION): Likewise.
5185 * s/darwin.h (PTY_ITERATION): Likewise.
5186 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5188 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5189 * process.c (allocate_pty): Don't declare stb unless it's needed.
5191 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5192 (CONSTANTLIM): Remove; unused.
5193 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5194 Define only if needed.
5196 * unexelf.c (unexec): Name an expression,
5197 to avoid gcc -Wbad-function-cast warning.
5198 Use a different way to cause a compilation error if anyone uses
5199 n rather than nn, a way that does not involve shadowing.
5200 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5202 * deps.mk (unexalpha.o): Remove; unused.
5204 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5205 * unexec.h: New file.
5206 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5207 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5209 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5210 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5211 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5212 Change as necessary to match prototype in unexec.h.
5214 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5216 (back_comment, skip_chars): Mark vars as initialized.
5218 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5219 Rename locals to avoid shadowing.
5221 * lread.c (read1): Rewrite so as not to use empty "else".
5222 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5224 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5226 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5227 warning when compiling print.c.
5229 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5230 instead of using an uninitialized var.
5231 (font_sort_entities): Mark var as initialized.
5233 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5235 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5236 pointers to constants.
5237 (font_parse_fcname): Remove unused vars.
5238 (font_delete_unmatched): Now static.
5239 (font_get_spec): Remove; unused.
5240 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5241 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5242 Rename or move locals to avoid shadowing.
5244 * fns.c (require_nesting_list, require_unwind): Now static.
5245 (Ffillarray): Rename locals to avoid shadowing.
5247 * floatfns.c (domain_error2): Define only if needed.
5248 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5250 * alloc.c (mark_backtrace): Move decl from here ...
5251 * lisp.h: ... to here, so that it can be checked.
5253 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5254 (Fdefvar): Rewrite so as not to use empty "else".
5255 (lisp_indirect_variable): Name an expression,
5256 to avoid gcc -Wbad-function-cast warning.
5257 (Fdefvar): Rename locals to avoid shadowing.
5259 * callint.c (quotify_arg, quotify_args): Now static.
5260 (Fcall_interactively): Rename locals to avoid shadowing.
5261 Use const pointer when appropriate.
5263 * lisp.h (get_system_name, get_operating_system_release):
5264 Move decls here, to check interfaces.
5265 * process.c (get_operating_system_release): Move decl to lisp.h.
5266 * xrdb.c (get_system_name): Likewise.
5267 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5268 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5269 some of which prompt warnings from gcc -Wbad-function-cast.
5270 (Fformat_time_string, Fencode_time, Finsert_char):
5271 (Ftranslate_region_internal, Fformat):
5272 Rename or remove local vars to avoid shadowing.
5273 (Ftranslate_region_internal): Mark var as initialized.
5275 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5278 * lisp.h (eassert): Check that the argument compiles, even if
5279 ENABLE_CHECKING is not defined.
5281 * data.c (Findirect_variable): Name an expression, to avoid
5282 gcc -Wbad-function-cast warning.
5283 (default_value, arithcompare, arith_driver, arith_error): Now static.
5284 (store_symval_forwarding): Rename local to avoid shadowing.
5285 (Fmake_variable_buffer_local, Fmake_local_variable):
5286 Mark variables as initialized.
5287 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5289 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5290 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5291 Rename locals to avoid shadowing.
5292 (mark_stack): Move local variables into the #ifdef region where
5294 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5295 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5297 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5298 (GC_STRING_CHARS): Remove; not used.
5299 (Fmemory_limit): Cast sbrk's returned value to char *.
5301 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5302 avoids undefined behavior in theory.
5304 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5306 Use functions, not macros, for up- and down-casing (Bug#8254).
5307 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5308 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5309 to use the following functions instead of these macros.
5310 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5311 EMACS_INT, since callers assume the returned value fits in int.
5312 (upcase1): Likewise, for UPCASE_TABLE.
5313 (uppercasep, lowercasep, upcase): New static inline functions.
5314 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5315 the race-condition problem in the old DOWNCASE.
5317 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5318 Rename locals to avoid shadowing.
5319 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5320 (regex_compile, re_search_2, re_match_2_internal):
5321 Remove unused local vars.
5322 (FREE_VAR): Rewrite so as not to use empty "else",
5323 which gcc can warn about.
5324 (regex_compile, re_match_2_internal): Mark locals as initialized.
5325 (RETALLOC_IF): Define only if needed.
5326 (WORDCHAR_P): Likewise. This one is never needed, but is used
5327 only in a comment talking about a compiler bug, so put inside
5328 the #if 0 of that comment.
5329 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5330 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5333 * search.c (boyer_moore): Rename locals to avoid shadowing.
5334 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5335 (PREV_CHAR_BOUNDARY): Likewise.
5337 * search.c (simple_search): Remove unused var.
5339 * dired.c (compile_pattern): Move decl from here ...
5340 * lisp.h: ... to here, so that it can be checked.
5341 (struct re_registers): New forward decl.
5343 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5345 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5347 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5348 Rename locals to avoid shadowing.
5349 (Fvertical_motion): Mark locals as initialized.
5351 * casefiddle.c (casify_object, casify_region): Now static.
5352 (casify_region): Mark local as initialized.
5354 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5356 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5357 New macros, so that the caller can use some names other than
5358 gcpro1, gcpro2, etc.
5359 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5361 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5362 argument, for consistency with GCPRO2_VAR, etc: it is now the
5363 prefix of the variable, not the variable itself. All uses
5365 * dired.c (directory_files_internal, file_name_completion):
5366 Rename locals to avoid shadowing.
5368 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5369 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5370 dired.c's scmp function, had undefined behavior.
5371 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5372 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5373 * buffer.h: ... to here, because these macros use current_buffer,
5374 and the new implementation with inline functions needs to have
5375 current_buffer in scope now, rather than later when the macros
5377 (downcase, upcase1): New static inline functions.
5378 (DOWNCASE, UPCASE1): Reimplement using these functions.
5379 This avoids undefined behavior in expressions like
5380 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5381 from race conditions in accessing the global variables
5382 case_temp1 and case_temp2.
5383 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5384 * lisp.h (case_temp1, case_temp2): Remove their decls.
5385 * character.h (ASCII_CHAR_P): Move from here ...
5386 * lisp.h: ... to here, so that the inline functions mentioned
5389 * dired.c (directory_files_internal_unwind): Now static.
5391 * fileio.c (file_name_as_directory, directory_file_name):
5392 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5394 (file_name_as_directory): Use const pointers when appropriate.
5395 (Fexpand_file_name): Likewise. In particular, newdir might
5396 point at constant storage, so make it a const pointer.
5397 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5398 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5400 (Fset_file_times, Finsert_file_contents, auto_save_error):
5401 Rename locals to avoid shadowing.
5403 * minibuf.c (choose_minibuf_frame_1): Now static.
5404 (Ftry_completion, Fall_completions): Rename or remove locals
5407 * marker.c (bytepos_to_charpos): Remove; unused.
5409 * lisp.h (verify_bytepos, count_markers): New decls,
5410 so that gcc does not warn that these functions aren't declared.
5412 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5413 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5414 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5415 (copy_text): Remove unused local var.
5417 * filelock.c (within_one_second): Now static.
5418 (lock_file_1): Rename local to avoid shadowing.
5420 * buffer.c (fix_overlays_before): Mark locals as initialized.
5421 (fix_start_end_in_overlays): Likewise. This function should be
5422 simplified by using pointers-to-pointers, but that's a different
5424 (switch_to_buffer_1): Now static.
5425 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5426 (report_overlay_modification): Rename locals to avoid shadowing.
5428 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5429 Fix pointer signedness issue.
5430 (sys_subshell): Mark local as volatile if checking for lint,
5431 to suppress a gcc -Wclobbered warning that does not seem to be right.
5432 (MAXPATHLEN): Define only if needed.
5434 * process.c (serial_open, serial_configure): Move decls from here ...
5435 * systty.h: ... to here, so that they can be checked.
5437 * fns.c (get_random, seed_random): Move extern decls from here ...
5438 * lisp.h: ... to here, so that they can be checked.
5440 * sysdep.c (reset_io): Now static.
5441 (wait_for_termination_signal): Remove; unused.
5443 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5444 (copy_keymap_item, append_key, push_text_char_description):
5446 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5447 (DENSE_TABLE_SIZE): Remove; unused.
5448 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5449 (describe_map_tree):
5450 Rename locals to avoid shadowing.
5452 * keyboard.c: Declare functions static if they are not used elsewhere.
5453 (echo_char, echo_dash, cmd_error, top_level_2):
5454 (poll_for_input, handle_async_input): Now static.
5455 (read_char, kbd_buffer_get_event, make_lispy_position):
5456 (make_lispy_event, make_lispy_movement, apply_modifiers):
5457 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5458 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5459 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5460 (read_key_sequence, read_char): Mark locals as initialized.
5461 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5463 * keyboard.h (make_ctrl_char): New decl.
5464 (mark_kboards): Move decl here ...
5465 * alloc.c (mark_kboards): ... from here.
5467 * lisp.h (force_auto_save_soon): New decl.
5469 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5470 (DEFINE_DUMMY_FUNCTION): New macro.
5471 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5473 (main): Add casts to avoid warnings
5474 if GCC considers string literals to be constants.
5476 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5478 * dbusbind.c: Pointer signedness fixes.
5479 (xd_signature, xd_append_arg, xd_initialize):
5480 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5481 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5482 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5483 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5485 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5486 if GCC considers string literals to be constants.
5487 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5489 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5491 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5492 (print_preprocess, print_object): New macro to fix last change.
5494 * print.c (print_preprocess): Don't forget font objects.
5496 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5498 * emacs.c (USAGE3): Doc fixes.
5500 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5502 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5505 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5507 * lisp.h (VWindow_system, Qfile_name_history):
5508 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5509 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5510 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5512 * w32select.c: Don't #include "keyboard.h".
5513 (run_protected): Add extern declaration for waiting_for_input.
5515 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5516 * w32console.c (detect_input_pending, read_input_pending)
5517 (encode_terminal_code):
5518 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5519 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5520 (w32_system_caret_y, Qfile_name_history):
5521 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5522 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5523 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5524 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5525 * w32proc.c (Qlocal, report_file_error):
5526 * w32term.c (Vwindow_system, updating_frame):
5527 * w32uniscribe.c (initialized, uniscribe_font_driver):
5528 Remove unneeded extern declarations.
5530 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
5532 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
5534 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
5536 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5537 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5538 These macros can no longer be used for assignment.
5540 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5541 Assign struct members directly, instead of using BUF_BEGV etc.
5542 (record_buffer_markers, fetch_buffer_markers): New functions for
5543 recording and fetching special buffer markers.
5544 (set_buffer_internal_1, set_buffer_temp): Use them.
5546 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5548 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5550 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5551 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5553 * xdisp.c (hscroll_window_tree):
5554 (reconsider_clip_changes): Use PT instead of BUF_PT.
5556 2011-03-13 Eli Zaretskii <eliz@gnu.org>
5558 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5559 $(EMACS_ROOT)/lib/intprops.h.
5561 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5563 Fix more problems found by GCC 4.5.2's static checks.
5565 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5566 to unsigned char * to avoid compiler diagnostic.
5567 (xg_free_frame_widgets): Make it clear that a local variable is
5568 needed only if USE_GTK_TOOLTIP.
5569 (gdk_window_get_screen): Make it clear that this macro is needed
5570 only if USE_GTK_TOOLTIP.
5571 (int_gtk_range_get_value): New function, which avoids a diagnostic
5572 from gcc -Wbad-function-cast.
5573 (xg_set_toolkit_scroll_bar_thumb): Use it.
5574 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5575 diagnostic from gcc -Wbad-function-cast.
5576 (get_utf8_string, xg_get_file_with_chooser):
5577 Rename locals to avoid shadowing.
5578 (create_dialog): Move locals to avoid shadowing.
5580 * xgselect.c (xg_select): Remove unused var.
5582 * image.c (four_corners_best): Mark locals as initialized.
5583 (gif_load): Initialize transparent_p to zero (Bug#8238).
5584 Mark another local as initialized.
5585 (my_png_error, my_error_exit): Mark with NO_RETURN.
5587 * image.c (clear_image_cache): Now static.
5588 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
5589 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
5590 (x_edge_detection): Remove unnecessary cast that
5591 gcc -Wbad-function-cast diagnoses.
5592 (gif_load): Fix pointer signedness.
5593 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5594 (jpeg_load, gif_load): Rename locals to avoid shadowing.
5596 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
5598 Improve quality of tests for time stamp overflow.
5599 For example, without this patch (encode-time 0 0 0 1 1
5600 1152921504606846976) returns the obviously-bogus value (-948597
5601 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5602 reports time overflow. See
5603 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
5604 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5605 * editfns.c: Include limits.h and intprops.h.
5606 (TIME_T_MIN, TIME_T_MAX): New macros.
5607 (time_overflow): Move earlier, to before first use.
5608 (hi_time, lo_time): New functions, for an accurate test for
5610 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5611 (Fget_internal_run_time): Don't assume time_t fits in int.
5612 (make_time): Use list2 instead of Fcons twice.
5613 (Fdecode_time): More accurate test for out-of-range times.
5614 (check_tm_member): New function.
5615 (Fencode_time): Use it, to test for out-of-range times.
5616 (lisp_time_argument): Don't rely on undefined left-shift and
5617 right-shift behavior when checking for time stamp overflow.
5619 * editfns.c (time_overflow): New function, refactoring common code.
5620 (Fformat_time_string, Fdecode_time, Fencode_time):
5621 (Fcurrent_time_string): Use it.
5623 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5624 * dired.c (make_time): Move to ...
5625 * editfns.c (make_time): ... here.
5626 * systime.h: Note the move.
5628 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5630 * fringe.c (update_window_fringes): Remove unused variables.
5632 * unexmacosx.c (copy_data_segment): Also copy __got section.
5635 2011-03-12 Eli Zaretskii <eliz@gnu.org>
5637 * termcap.c [MSDOS]: Include "msdos.h".
5638 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5639 Constify `char *' arguments and their references according to
5640 prototypes in tparam.h.
5642 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
5644 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5645 Adapt all references accordingly.
5647 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5649 2011-03-11 Tom Tromey <tromey@redhat.com>
5651 * buffer.c (syms_of_buffer): Remove obsolete comment.
5653 2011-03-11 Eli Zaretskii <eliz@gnu.org>
5655 * termhooks.h (encode_terminal_code): Declare prototype.
5657 * msdos.c (encode_terminal_code): Don't declare prototype.
5659 * term.c (encode_terminal_code): Now external again, used by
5660 w32console.c and msdos.c.
5662 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5663 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
5665 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
5667 Fix some minor problems found by GCC 4.5.2's static checks.
5669 * fringe.c (update_window_fringes): Mark locals as initialized
5671 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
5673 * alloc.c (mark_fringe_data): Move decl from here ...
5674 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5675 to check its interface.
5676 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5678 * fontset.c (free_realized_fontset): Now static.
5679 (Fset_fontset_font): Rename local to avoid shadowing.
5680 (fontset_font): Mark local as initialized.
5681 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
5683 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5685 * xselect.c (x_disown_buffer_selections): Remove; not used.
5686 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
5687 (x_own_selection, Fx_disown_selection_internal): Rename locals
5689 (x_handle_dnd_message): Remove local to avoid shadowing.
5691 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5692 so that the caller can use some name other than gcpro1.
5693 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
5694 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5695 (Fx_backspace_delete_keys_p):
5696 Use them to avoid shadowing, and rename vars to avoid shadowing.
5697 (x_decode_color, x_set_name, x_window): Now static.
5698 (Fx_create_frame): Add braces to silence GCC warning.
5699 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
5700 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5701 Remove unused locals.
5702 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5703 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5704 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5707 * xterm.h (x_mouse_leave): New decl.
5709 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5710 Remove unused functions.
5711 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5712 (x_calc_absolute_position): Now static.
5713 (XTread_socket): Don't define label "out" unless it's used.
5714 Don't declare local "event" unless it's used.
5715 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5716 unless they are used.
5717 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5718 (x_fatal_error_signal): Remove; not used.
5719 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5720 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5721 (x_error_catcher, x_connection_closed, x_error_handler):
5722 (x_error_quitter, xembed_send_message, x_iconify_frame):
5723 (my_log_handler): Rename locals to avoid shadowing.
5724 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
5725 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
5727 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5728 Rename or move locals to avoid shadowing.
5729 (tty_defined_color, merge_face_heights): Now static.
5730 (free_realized_faces_for_fontset): Remove; not used.
5731 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5732 does not deduce is never used uninitialized.
5733 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5734 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
5736 * terminal.c (store_terminal_param): Now static.
5738 * xmenu.c (menu_highlight_callback): Now static.
5739 (set_frame_menubar): Remove unused local.
5740 (xmenu_show): Rename parameter to avoid shadowing.
5741 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5742 since they might point to immutable storage.
5743 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5744 since it's unused otherwise.
5746 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
5747 Add a FIXME, since the code still doesn't look right. (Bug#8215)
5748 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5749 avoids a gcc -Wuninitialized diagnostic.
5750 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
5751 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5752 does not deduce are never used uninitialized.
5754 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5756 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
5757 * window.c (window_loop, size_window):
5758 (run_window_configuration_change_hook, enlarge_window): Likewise.
5760 * window.c (display_buffer): Now static.
5761 (size_window): Mark variables that gcc -Wuninitialized
5762 does not deduce are never used uninitialized.
5763 * window.h (check_all_windows): New decl, to forestall
5764 gcc -Wmissing-prototypes diagnostic.
5765 * dispextern.h (bidi_dump_cached_states): Likewise.
5767 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5769 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
5771 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5772 and to avoid gcc -Wuninitialized warning.
5773 (load_charset_map): Mark variables that gcc -Wuninitialized
5774 does not deduce are never used uninitialized.
5775 (load_charset): Abort instead of using uninitialized var (Bug#8229).
5777 * coding.c (coding_set_source, coding_set_destination):
5778 Use "else { /* comment */ }" rather than "else /* comment */;"
5779 for clarity, and to avoid gcc -Wempty-body warning.
5780 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5781 a block, when the outer 'i' will do.
5782 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5783 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5784 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5785 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5786 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5787 Rename locals to avoid shadowing.
5788 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
5789 * coding.c (emacs_mule_char, encode_invocation_designation):
5790 Now static, since they're not used elsewhere.
5791 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
5792 (decode_coding_object, encode_coding_object, detect_coding_system):
5793 (decode_coding_emacs_mule): Mark variables that gcc
5794 -Wuninitialized does not deduce are never used uninitialized.
5795 (detect_coding_iso_2022): Initialize a local variable that might
5796 be used uninitialized. Leave a FIXME because it's not clear that
5797 this initialization is needed. (Bug#8211)
5798 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5799 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5800 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5801 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5802 Remove unused macros.
5804 * category.c (hash_get_category_set): Remove unused local var.
5805 (copy_category_table): Now static, since it's not used elsewhere.
5806 * character.c (string_count_byte8): Likewise.
5808 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5809 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5811 * chartab.c (copy_sub_char_table): Now static, since it's not used
5813 (sub_char_table_ref_and_range, char_table_ref_and_range):
5814 Rename locals to avoid shadowing.
5815 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
5817 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
5818 (BIDI_BOB): Remove unused macro.
5820 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5821 deduce are never used uninitialized.
5822 * term.c (encode_terminal_code): Likewise.
5824 * term.c (encode_terminal_code): Now static. Remove unused local.
5826 * tparam.h: New file.
5827 * term.c, tparam.h: Include it.
5828 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5829 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5830 Move these decls to tparam.h, and make them agree with what
5831 is actually in tparam.c. The previous trick of using incompatible
5832 decls in different modules does not conform to the C standard.
5833 All callers of tparam changed to use tparam's actual API.
5834 * tparam.c (tparam1, tparam, tgoto):
5835 Use const pointers where appropriate.
5837 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5838 * cm.h (struct cm): Likewise.
5839 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5840 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5841 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5842 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5843 (turn_on_face, init_tty): Likewise.
5844 * termchar.h (struct tty_display_info): Likewise.
5846 * term.c (term_mouse_position): Rename local to avoid shadowing.
5848 * alloc.c (mark_ttys): Move decl from here ...
5849 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5851 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5853 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5855 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
5857 * search.c (compile_pattern_1): Remove argument regp, unused since
5858 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5859 (compile_pattern): Don't pass it.
5861 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5863 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5864 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5866 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5868 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5870 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5871 gdk_window_get_screen, gdk_window_get_geometry,
5872 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5873 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5874 (xg_get_pixbuf_from_pixmap): New function.
5875 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5876 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5877 Call xg_get_pixbuf_from_pixmap instead of
5878 gdk_pixbuf_get_from_drawable.
5879 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5880 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5881 (xg_check_special_colors): Use GtkStyleContext and its functions
5883 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5884 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5885 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
5886 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5887 Call gtk_widget_get_preferred_size.
5888 (xg_frame_resized): gdk_window_get_geometry only takes 5
5890 (xg_win_to_widget, xg_event_is_for_menubar):
5891 Call gdk_x11_window_lookup_for_display.
5892 (xg_set_widget_bg): New function.
5893 (delete_cb): New function.
5894 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5895 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5896 (xg_set_background_color): Call xg_set_widget_bg.
5897 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5898 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5899 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5900 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5902 (update_frame_tool_bar): Call gtk_widget_hide.
5903 (xg_initialize): Use GDK_KEY_g.
5905 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5907 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5909 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5910 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5911 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5913 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
5915 * w32xfns.c (select_palette): Check success of RealizePalette against
5916 GDI_ERROR, not zero.
5918 See ChangeLog.11 for earlier changes.
5924 Copyright (C) 2011 Free Software Foundation, Inc.
5926 This file is part of GNU Emacs.
5928 GNU Emacs is free software: you can redistribute it and/or modify
5929 it under the terms of the GNU General Public License as published by
5930 the Free Software Foundation, either version 3 of the License, or
5931 (at your option) any later version.
5933 GNU Emacs is distributed in the hope that it will be useful,
5934 but WITHOUT ANY WARRANTY; without even the implied warranty of
5935 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5936 GNU General Public License for more details.
5938 You should have received a copy of the GNU General Public License
5939 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.