1 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
6 2012-05-01 Glenn Morris <rgm@gnu.org>
8 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
9 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
10 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
11 All were removed before 23.1.
13 * dispnew.c: Remove HAVE_LIBNCURSES test;
14 it is always true on relevant platforms.
16 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
17 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
19 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
21 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
23 * .gdbinit (xpr): Remove checks for no longer existing misc types.
24 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
27 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
29 Do not avoid creating empty evaporating overlays (Bug#9642).
30 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
31 That is, do not delete an evaporating overlay if it becomes
32 empty after its bounds are adjusted to fit within its buffer.
33 This fix caused other problems, and I'm reverting it until we get
34 to the bottom of them.
36 2012-04-27 Chong Yidong <cyd@gnu.org>
38 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
40 2012-04-27 Eli Zaretskii <eliz@gnu.org>
42 * xdisp.c (pos_visible_p): If the window start position is beyond
43 ZV, start the display from buffer beginning. Prevents assertion
44 violation in init_iterator when the minibuffer window is scrolled
47 * window.c (window_scroll_pixel_based): Likewise.
49 2012-04-27 Chong Yidong <cyd@gnu.org>
51 * keymap.c (where_is_internal): Doc fix (Bug#10872).
53 2012-04-27 Glenn Morris <rgm@gnu.org>
55 * fileio.c (Fcopy_file, Fset_file_selinux_context):
56 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
58 2012-04-27 Eli Zaretskii <eliz@gnu.org>
60 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
61 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
63 2012-04-26 Eli Zaretskii <eliz@gnu.org>
65 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
66 display element, check also the underlying string or buffer
67 character. (Bug#11341)
69 * w32menu.c: Include w32heap.h.
70 (add_menu_item): If the call to AppendMenuW (via
71 unicode_append_menu) fails, disable Unicode menus only if we are
72 running on Windows 9X/Me.
74 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
76 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
77 (xgetint): Add missing shift for LSB tags.
79 2012-04-24 Martin Rudalics <rudalics@gmx.at>
81 * keyboard.c (read_char): Don't wipe echo area for select window
82 events: These might get delayed via `mouse-autoselect-window'
85 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
87 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
88 manipulation of :loaded-from data.
90 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
92 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
93 now a cons (bug#11311).
95 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
97 Do not create empty overlays with the evaporate property (Bug#9642).
98 * buffer.c (Fmove_overlay): Delete an evaporating overlay
99 if it becomes empty after its bounds are adjusted to fit within
100 its buffer. Without this fix, in a nonempty buffer (let ((o
101 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
102 yields an empty overlay that has the evaporate property, which is
103 not supposed to happen.
105 Fix minor GTK3 problems found by static checking.
106 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
107 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
108 (struct _EmacsFixedClass, emacs_fixed_get_type):
109 Move decls here from emacsgtkfixed.h, since they needn't be public.
110 (emacs_fixed_get_type): Now static.
111 (emacs_fixed_class_init): Omit unused local.
112 (emacs_fixed_child_type): Remove; unused.
113 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
114 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
115 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
116 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
117 (EMACS_FIXED_GET_CLASS): Remove; unused.
118 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
120 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
121 Problem reported by Juanma Barranquero for Windows -Wunused-function.
123 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
125 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
126 * gmalloc.c: (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
127 (__malloc_size_t, __malloc_ptrdiff_t):
128 Remove. All uses removed, replaced by the definiens if needed,
129 since we can assume C89 or better now.
130 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
131 (protect_malloc_state, align, get_contiguous_space)
132 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
133 (malloc_atfork_handler_child, malloc_enable_thread)
134 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
135 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
136 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
137 (special_realloc, _realloc_internal_nolock, _realloc_internal)
138 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
139 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
140 Define using prototypes, not old style.
141 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
142 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
143 (align): Don't assume that signed integer overflow wraps around.
144 Omit unused local var.
145 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
146 (_free_internal_nolock, memalign, mallochook, reallochook):
147 Omit no-longer-needed casts.
148 (valloc): Use getpagesize, not __getpagesize.
149 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
150 (struct hdr): The 'magic' member is now size_t, not unsigned long.
152 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
154 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
156 Move functions from C to Lisp. Make non-blocking method calls
157 the default. Implement further D-Bus standard interfaces.
159 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
160 (QCdbus_request_name_allow_replacement)
161 (QCdbus_request_name_replace_existing)
162 (QCdbus_request_name_do_not_queue)
163 (QCdbus_request_name_reply_primary_owner)
164 (QCdbus_request_name_reply_in_queue)
165 (QCdbus_request_name_reply_exists)
166 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
167 (QCdbus_registered_serial, QCdbus_registered_method)
168 (QCdbus_registered_signal): New Lisp objects.
169 (XD_DEBUG_MESSAGE): Use sizeof.
170 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
171 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
172 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
173 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
174 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
175 (xd_signature, xd_append_arg): Allow float for integer types.
176 (xd_get_connection_references): New function.
177 (xd_get_connection_address): Rename from xd_initialize.
178 Return cached address.
179 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
180 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
182 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
183 Return number of recounts.
184 (Fdbus_get_unique_name): Make stronger parameter check.
185 (Fdbus_message_internal): New defun.
186 (Fdbus_call_method, Fdbus_call_method_asynchronously)
187 (Fdbus_method_return_internal, Fdbus_method_error_internal)
188 (Fdbus_send_signal, Fdbus_register_service)
189 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
190 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
191 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
192 (Vdbus_compiled_version, Vdbus_runtime_version)
193 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
194 (Vdbus_message_type_method_return, Vdbus_message_type_error)
195 (Vdbus_message_type_signal): New defvars.
196 (Vdbus_registered_buses, Vdbus_registered_objects_table):
199 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
201 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
202 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
203 Do not assume ptrdiff_t is the same width as 'int'.
205 * alloc.c: Handle unusual debugging option combinations.
206 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
207 since the two debugging options are incompatible.
208 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
210 (mem_init, mem_insert, mem_insert_fixup):
211 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
212 (NEED_MEM_INSERT): Remove; no longer needed.
214 2012-04-22 Leo Liu <sdl.web@gmail.com>
216 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
218 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
220 * sysdep.c [__FreeBSD__]: Minor cleanups.
221 (list_system_processes, system_process_attributes) [__FreeBSD__]:
222 Use Emacs indenting style more consistently. Avoid some casts.
223 Use 'double' consistently rather than mixing 'float' and 'double'.
225 2012-04-21 Eduard Wiebe <usenet@pusto.de>
227 * sysdep.c (list_system_processes, system_process_attributes):
228 Add implementation for FreeBSD (Bug#5243).
230 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
232 * lisp.mk (lisp): Update.
234 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
236 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
237 It is never used otherwise.
239 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
241 * print.c (print_preprocess): Only check print_depth if print-circle
243 (print_object): Check for cycles even when print-circle is nil and
244 print-gensym is t, but only check print_depth if print-circle is nil.
246 2012-04-20 Chong Yidong <cyd@gnu.org>
248 * process.c (wait_reading_process_output): If EIO occurs on a pty,
249 set the status to "failed" and ensure that sentinel is run.
251 2012-04-20 Glenn Morris <rgm@gnu.org>
253 * process.c (Fset_process_inherit_coding_system_flag)
254 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
255 (Fmake_network_process, Fmake_serial_process): Doc fix.
257 2012-04-20 Eli Zaretskii <eliz@gnu.org>
259 * xdisp.c (string_buffer_position_lim): Limit starting position to
261 (set_cursor_from_row): If called for a mode-line or header-line
262 row, return zero immediately.
263 (try_cursor_movement): If inside continuation line, don't back up
264 farther than the first row after the header line, if any.
265 Don't consider the header-line row as "partially visible", even if
266 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
268 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
270 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
273 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
274 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
276 configure: new option --enable-gcc-warnings (Bug#11207)
277 * Makefile.in (C_WARNINGS_SWITCH): Remove.
278 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
279 (ALL_CFLAGS): Use new macros rather than old.
280 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
281 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
282 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
283 -Wunused-result, -Wunused-variable. This should go away once
284 the Emacs and Gnulib regex code is merged.
285 (xmalloc, xrealloc): Now static.
287 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
289 * dired.c (Fsystem_groups): Remove unused local.
291 2012-04-17 Glenn Morris <rgm@gnu.org>
293 * dired.c (Fsystem_users): Doc fix.
295 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
297 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
298 (syms_of_dired): Add them.
300 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
302 Fix minor alloc.c problems found by static checking.
303 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
304 New extern decls, to avoid calling undeclared functions.
305 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
306 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
307 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
308 (NEED_MEM_INSERT): New macro.
309 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
310 Remove one incorrect comment and fix another.
312 Fix minor ralloc.c problems found by static checking.
313 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
314 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
315 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
316 (r_alloc_sbrk): Now static.
318 Improve ralloc.c interface checking.
319 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
320 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
321 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
322 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
323 [REL_ALLOC]: ... to here, to check interface.
324 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
325 Remove decls. This fixes an "It stinks!".
327 * alloc.c (which_symbols): Fix alignment issue / type clash.
329 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
331 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
332 (struct Lisp_Misc_Any): Likewise.
333 (struct Lisp_Free): Likewise.
334 * alloc.c (union aligned_Lisp_Symbol): Define.
335 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
336 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
337 (union aligned_Lisp_Misc): Define.
338 (MARKER_BLOCK_SIZE, struct marker_block): Use union
339 aligned_Lisp_Misc instead of union Lisp_Misc.
340 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
342 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
344 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
345 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
346 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
347 * s/netbsd.h, s/sol2-6.h:
348 Remove definition of GC_MARK_STACK, since the default now works.
349 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
350 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
351 no longer the default.
352 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
354 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
356 * lread.c (lisp_file_lexically_bound_p):
357 Fix hang at ";-*-\n" (bug#11238).
359 2012-04-14 Eli Zaretskii <eliz@gnu.org>
361 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
362 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
364 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
366 * nsterm.m (constrainFrameRect): Always constrain when there is only
367 one screen (Bug#10962).
369 2012-04-13 Ken Brown <kbrown@cornell.edu>
371 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
373 2012-04-13 Reuben Thomas <rrt@sc3d.org>
375 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
377 2012-04-11 Daniel Colascione <dancol@dancol.org>
379 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
380 against is gone. It's better to use vfork now so that when Cygwin
381 gains a new, working vfork, we use it automatically (bug#10398).
383 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
385 * window.c (save_window_save): Obey window-point-insertion-type.
387 2012-04-11 Glenn Morris <rgm@gnu.org>
389 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
391 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
393 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
395 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
397 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
398 (force_quit_count): New var.
399 (handle_interrupt): Use it.
401 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
403 * w32.c (w32_delayed_load): Record the full path of the library
404 being loaded (bug#10424).
406 2012-04-09 Glenn Morris <rgm@gnu.org>
408 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
409 not just in the obarray, before snarfing them. (Bug#11036)
411 * Makefile.in ($(leimdir)/leim-list.el):
412 Pass EMACS rather than BUILT_EMACS.
414 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
416 * process.c (make_process):
417 * process.h: Add integer `gnutls_handshakes_tried' member to
420 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
421 Add convenience `GNUTLS_LOG2i' macro.
423 * gnutls.c (gnutls_log_function2i): Convenience log function.
424 (emacs_gnutls_read): Use new log functions,
425 `gnutls_handshakes_tried' process member, and
426 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
427 attempts per process (connection).
429 2012-04-09 Chong Yidong <cyd@gnu.org>
431 * eval.c (Fuser_variable_p, user_variable_p_eh)
432 (lisp_indirect_variable): Functions deleted.
433 (Fdefvar): Caller changed.
435 * callint.c (Finteractive, Fcall_interactively):
436 * minibuf.c (Fread_variable): Callers changed.
438 2012-04-09 Eli Zaretskii <eliz@gnu.org>
440 * xdisp.c (set_cursor_from_row): If the display string appears in
441 the buffer at position that is closer to point than the position
442 after the display string, display the cursor on the first glyph of
443 the display string. Fixes cursor display when a 'display' text
444 property immediately follows invisible text. (Bug#11094)
446 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
448 composite.c: use 'double' consistently
449 * composite.c (get_composition_id): Use 'double' consistently
450 instead of converting 'float' to 'double' and vice versa; this is
451 easier to understand and avoids a GCC warning.
453 2012-04-09 Glenn Morris <rgm@gnu.org>
455 * Makefile.in: Generate leim-list with bootstrap-emacs, in
456 preparation for dumping it with emacs. (Bug#4789)
457 (leimdir): New variable.
458 ($(leimdir)/leim-list.el): New rule.
459 (emacs$(EXEEXT)): Depend on leim-list.el.
461 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
462 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
463 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
465 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
467 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
470 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
472 * xml.c (init_libxml2_functions) [WINDOWSNT]:
473 Remove unused local variable.
475 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
477 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
478 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
479 (mark_memory): Mark Lisp_Objects only if pointers might hide in
480 objects, as mark_maybe_pointer will catch them otherwise.
481 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
482 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
484 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
486 Fix typo that broke non-Windows builds.
487 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
489 2012-04-07 Eli Zaretskii <eliz@gnu.org>
491 Support building on MS-Windows with libxml2.
493 * makefile.w32-in (OBJ2): Add xml.$(O).
494 (GLOBAL_SOURCES): Add xml.c.
495 ($(BLD)/xml.$(O)): New dependency list.
497 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
498 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
499 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
500 [!WINDOWSNT]: New macros.
501 (init_libxml2_functions, libxml2_loaded_p): New functions.
502 (parse_region): Call fn_xmlCheckVersion instead of using the macro
503 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
504 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
505 Calls xmlCleanupParser only if libxml2 was loaded (or statically
507 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
508 Call init_libxml2_functions before calling libxml2 functions.
509 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
511 * emacs.c: Don't include libxml/parser.h.
512 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
513 xmlCleanupParser directly.
515 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
517 2012-04-07 Eli Zaretskii <eliz@gnu.org>
519 * indent.c (Fvertical_motion): If there is a display string at
520 point, use it.vpos to compute how many lines to backtrack after
521 move_it_to point. (Bug#11133)
523 2012-04-06 Eli Zaretskii <eliz@gnu.org>
525 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
526 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
527 about subtle differences between FETCH_CHAR* and STRING_CHAR*
528 macros related to unification of CJK characters. For the details,
529 see the discussion following the message here:
530 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
532 2012-04-04 Chong Yidong <cyd@gnu.org>
534 * keyboard.c (Vdelayed_warnings_list): Doc fix.
536 2012-04-01 Eli Zaretskii <eliz@gnu.org>
538 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
539 instead of alloca. (Bug#11138)
541 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
543 * w32menu.c (is_simple_dialog): Properly check lisp types.
546 2012-03-31 Eli Zaretskii <eliz@gnu.org>
548 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
549 position we get to after a call to move_it_to fails the
550 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
551 only if we wind up in a string from display property. (Bug#11063)
553 * window.c (Fdelete_other_windows_internal): Invalidate the row
554 and column information about mouse highlight, so that redisplay
555 restores it after reallocating the glyph matrices. (Bug#7464)
557 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
558 string comes from a `display' text property, use the buffer
559 position of that property as if we actually saw that position in
561 (move_it_by_lines): Remove the assertion that
562 "it->current_x == 0 && it->hpos == 0" which can be legitimately
563 violated when there's a before-string at the beginning of a line.
566 2012-03-30 Eli Zaretskii <eliz@gnu.org>
568 * xdisp.c (append_space_for_newline): If the default face was
569 remapped, use the remapped face for the appended newline.
570 (extend_face_to_end_of_line): Use the remapped default face for
571 extending the face to the end of the line.
572 (display_line): Call extend_face_to_end_of_line when the default
573 face was remapped. (Bug#11068)
575 2012-03-29 Eli Zaretskii <eliz@gnu.org>
577 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
579 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
581 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
583 2012-03-27 Glenn Morris <rgm@gnu.org>
585 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
588 2012-03-26 Kenichi Handa <handa@m17n.org>
590 * dispextern.h (struct glyph): Fix previous change. Change the
591 bit length of glyphless.ch to 25 (Bug#11082).
593 2012-03-26 Chong Yidong <cyd@gnu.org>
595 * keyboard.c (Vselection_inhibit_update_commands): New variable.
596 (command_loop_1): Use it; inhibit selection update for
597 handle-select-window too (Bug#8996).
599 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
601 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
603 2012-03-25 Kenichi Handa <handa@m17n.org>
605 * dispextern.h (struct glyph): Change the bit length of
606 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
608 2012-03-24 Eli Zaretskii <eliz@gnu.org>
610 * s/ms-w32.h (tzname): Include time.h before redirecting to
611 _tzname. Fixes the MSVC build. (Bug#9960)
613 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
615 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
618 * xterm.c (XTread_socket): Only modify handling_signal if
619 !SYNC_INPUT. (Bug#11080)
621 2012-03-23 Eli Zaretskii <eliz@gnu.org>
623 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
624 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
625 when fetching a multibyte character consumes more bytes than
626 CHAR_BYTES returns, due to unification of CJK characters in
627 string_char. (Bug#11073)
629 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
631 * process.c (wait_reading_process_output): Handle pty disconnect
632 by refraining from sending oneself a SIGCHLD (bug#10933).
634 2012-03-22 Chong Yidong <cyd@gnu.org>
636 * dispextern.h (struct it): New member string_from_prefix_prop_p.
638 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
639 Mark string as coming from a prefix property.
640 (handle_face_prop): Use default face for prefix strings (Bug#4281).
641 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
643 2012-03-21 Chong Yidong <cyd@gnu.org>
645 * xfaces.c (Vface_remapping_alist): Doc fix.
647 2012-03-20 Eli Zaretskii <eliz@gnu.org>
649 * w32proc.c (Fw32_set_console_codepage)
650 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
653 2012-03-20 Chong Yidong <cyd@gnu.org>
655 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
656 to reflect default non-nil value of redisplay-dont-pause.
658 2012-03-19 Kenichi Handa <handa@m17n.org>
660 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
661 it fit in a valid range (Bug#11003).
663 2012-03-18 Eli Zaretskii <eliz@gnu.org>
665 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
666 that is not from display property, accept the row as a "cursor
667 row" if one of the string's character has a non-nil `cursor'
668 property. Fixes cursor positioning when there are newlines in
669 overlay strings, e.g. in icomplete.el. (Bug#11035)
671 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
673 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
675 2012-03-12 Chong Yidong <cyd@gnu.org>
677 * eval.c (inhibit_lisp_code): Rename from
678 inhibit_window_configuration_change_hook; move from window.c.
680 * xfns.c (unwind_create_frame_1, Fx_create_frame):
681 * window.c (run_window_configuration_change_hook)
682 (syms_of_window): Callers changed.
684 2012-03-11 Chong Yidong <cyd@gnu.org>
686 * keymap.c (Fkey_description): Doc fix (Bug#9700).
688 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
690 2012-03-10 Chong Yidong <cyd@gnu.org>
692 * frame.c (other_visible_frames): Don't assume the selected frame
693 is visible (Bug#10955).
695 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
697 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
699 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
701 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
702 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
705 2012-03-03 Glenn Morris <rgm@gnu.org>
707 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
709 2012-03-02 Eli Zaretskii <eliz@gnu.org>
711 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
712 position past the first glyph_row that ends at ZV. (Bug#10902)
713 (redisplay_window, next_element_from_string): Fix typos in
715 (redisplay_window): Pass to move_it_vertically the margin in
716 pixels, not in screen lines.
718 2012-03-02 Glenn Morris <rgm@gnu.org>
720 * buffer.c (buffer-list-update-hook): Doc fix.
722 2012-02-29 Eli Zaretskii <eliz@gnu.org>
724 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
725 push_it before setting up the iterator for the first overlay
726 string, even if we have an empty string loaded.
727 (next_overlay_string): If there's an empty string on the iterator
728 stack, pop the stack. (Bug#10903)
730 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
732 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
733 Suggested by Stefan Monnier in
734 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
735 * alloc.c (widen_to_Lisp_Object): New static function.
736 (mark_memory): Also mark Lisp_Objects by fetching pointer words
737 and widening them to Lisp_Objects. This would work even if
738 USE_LSB_TAG is defined and wide integers are used, which might
739 happen in a future version of Emacs.
741 2012-02-25 Chong Yidong <cyd@gnu.org>
743 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
746 * xselect.c (Fx_selection_exists_p): Doc fix.
747 (x_clipboard_manager_save_all): Print an informative message
748 before saving to clipboard manager.
750 2012-02-24 Chong Yidong <cyd@gnu.org>
752 * keyboard.c (process_special_events): Handle all X selection
753 requests in kbd_buffer, not just the next one (Bug#8869).
755 2012-02-23 Chong Yidong <cyd@gnu.org>
757 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
758 call when setting menu-bar-lines and tool-bar-lines parameters.
759 (unwind_create_frame_1): New helper function.
761 * window.c (inhibit_window_configuration_change_hook): New var.
762 (run_window_configuration_change_hook): Obey it.
763 (syms_of_window): Initialize it.
765 2012-02-22 Chong Yidong <cyd@gnu.org>
767 * xterm.c (x_draw_image_relief): Add missing type check for
768 Vtool_bar_button_margin (Bug#10743).
770 2012-02-21 Chong Yidong <cyd@gnu.org>
772 * fileio.c (Vfile_name_handler_alist): Doc fix.
774 * buffer.c (Fget_file_buffer): Protect against invalid file
775 handler return value.
777 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
779 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
780 when computing $valmask.
782 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
783 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
784 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
785 It's useless in that case, and it can cause problems on hosts
786 that allocate halves of EMACS_INT values separately.
787 Reported by Dan Horák. Diagnosed by Andreas Schwab in
788 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
789 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
790 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
791 it avoids undefined behavior on hosts where shifting right by more
792 than the word width has undefined behavior.
794 2012-02-19 Chong Yidong <cyd@gnu.org>
796 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
797 (Funhandled_file_name_directory, Ffile_name_as_directory)
798 (Fdirectory_file_name, Fexpand_file_name)
799 (Fsubstitute_in_file_name): Protect against invalid file handler
800 return values (Bug#10845).
802 2012-02-18 Eli Zaretskii <eliz@gnu.org>
804 * .gdbinit (pitx): Fix incorrect references to fields of the
807 2012-02-17 Chong Yidong <cyd@gnu.org>
809 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
811 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
813 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
814 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
816 2012-02-15 Chong Yidong <cyd@gnu.org>
818 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
819 marked as special. Also, starting docstrings with * is obsolete.
821 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
823 * gnutls.c (emacs_gnutls_write): Fix last change.
825 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
827 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
830 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
832 * keymap.c (Fsingle_key_description): Handle char ranges.
834 2012-02-12 Chong Yidong <cyd@gnu.org>
836 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
837 as that creates a dangerous corner case.
839 * window.c (Fdelete_window_internal): Invalidate the mouse
840 highlight (Bug#9904).
842 2012-02-12 Glenn Morris <rgm@gnu.org>
844 * xselect.c (Fx_own_selection_internal)
845 (Fx_get_selection_internal, Fx_disown_selection_internal)
846 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
847 * nsselect.m (Fx_own_selection_internal)
848 (Fx_disown_selection_internal, Fx_selection_exists_p)
849 (Fx_selection_owner_p, Fx_get_selection_internal):
850 Sync docs and argument specs with the xselect.c versions.
852 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
854 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
856 2012-02-11 Eli Zaretskii <eliz@gnu.org>
858 * w32select.c (Fx_selection_exists_p): Sync doc string and
859 argument list with xselect.c. (Bug#10783)
861 * w16select.c (Fx_selection_exists_p): Sync doc string and
862 argument list with xselect.c. (Bug#10783)
864 2012-02-10 Glenn Morris <rgm@gnu.org>
866 * fns.c (Fsecure_hash): Doc fix.
868 2012-02-09 Kenichi Handa <handa@m17n.org>
870 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
872 2012-02-07 Chong Yidong <cyd@gnu.org>
874 * buffer.c (Fbuffer_local_variables)
875 (buffer_lisp_local_variables): Handle unbound vars correctly;
876 don't let Qunbound leak into Lisp.
878 2012-02-07 Glenn Morris <rgm@gnu.org>
880 * image.c (Fimagemagick_types): Doc fix.
882 * image.c (imagemagick-render-type): Change it from a lisp object
883 to an integer. Move the doc here from the lisp manual.
884 Treat all values not equal to 0 the same.
886 2012-02-06 Chong Yidong <cyd@gnu.org>
888 * doc.c (store_function_docstring): Avoid applying docstring of
889 alias to base function (Bug#2603).
891 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
893 * .gdbinit (pp1, pv1): Remove redundant defines.
896 2012-02-04 Chong Yidong <cyd@gnu.org>
898 * nsterm.m: Declare a global (Bug#10694).
900 2012-02-04 Eli Zaretskii <eliz@gnu.org>
902 * w32.c (get_emacs_configuration_options):
903 Include --enable-checking, if specified, in the return value.
905 2012-02-04 Martin Rudalics <rudalics@gmx.at>
907 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
908 after rounding frame sizes. (Bug#9723)
910 2012-02-04 Eli Zaretskii <eliz@gnu.org>
912 * keyboard.c (adjust_point_for_property): Don't position point
913 before BEGV. (Bug#10696)
915 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
917 Handle overflow when computing char display width (Bug#9496).
918 * character.c (char_width): Return EMACS_INT, not int.
919 (char_width, c_string_width): Check for overflow when
920 computing the width; this is possible now that individual
921 characters can have unbounded width. Problem introduced
922 by merge from Emacs 23 on 2012-01-19.
924 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
926 * dbusbind.c (Fdbus_register_method): Mention the return value
927 :ignore in the docstring.
929 2012-02-02 Glenn Morris <rgm@gnu.org>
931 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
933 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
934 Unconditionally set to t. (Bug#10673)
935 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
936 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
937 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
939 2012-02-02 Kenichi Handa <handa@m17n.org>
941 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
942 0, do not call append_composite_glyph.
944 2012-02-02 Kenichi Handa <handa@m17n.org>
946 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
948 (x_produce_glyphs): If the component of a composition is a null
949 string, set it->pixel_width to 1 to avoid zero-width glyph.
951 2012-02-01 Eli Zaretskii <eliz@gnu.org>
953 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
954 first 2 arguments are identical. This makes inserting large
955 output from a subprocess an order of magnitude faster on
956 MS-Windows, where all sbrk'ed memory is always contiguous.
958 2012-01-31 Glenn Morris <rgm@gnu.org>
960 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
961 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
962 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
964 2012-01-29 Glenn Morris <rgm@gnu.org>
966 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
968 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
970 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
972 2012-01-28 Chong Yidong <cyd@gnu.org>
974 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
976 2012-01-26 Chong Yidong <cyd@gnu.org>
978 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
980 * search.c (Fsearch_forward, Fsearch_backward): Document negative
981 repeat counts (Bug#10507).
983 2012-01-26 Glenn Morris <rgm@gnu.org>
985 * lread.c (syms_of_lread): Doc fix.
987 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
989 * coding.c (encode_designation_at_bol): Change return value to
992 2012-01-25 Chong Yidong <cyd@gnu.org>
994 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
996 2012-01-21 Chong Yidong <cyd@gnu.org>
998 * floatfns.c (Fcopysign): Make the second argument non-optional,
999 since nil is not allowed anyway.
1001 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
1003 * process.c (read_process_output): Use p instead of XPROCESS (proc).
1004 (send_process): Likewise.
1006 2012-01-19 Martin Rudalics <rudalics@gmx.at>
1008 * window.c (save_window_save, Fcurrent_window_configuration)
1009 (Vwindow_persistent_parameters): Do not use Qstate.
1010 Rewrite doc-strings.
1012 2012-01-19 Kenichi Handa <handa@m17n.org>
1014 * character.c (char_width): New function.
1015 (Fchar_width, c_string_width, lisp_string_width):
1016 Use char_width (Bug#9496).
1018 2012-01-16 Martin Rudalics <rudalics@gmx.at>
1020 * window.c (Vwindow_persistent_parameters): New variable.
1021 (Fset_window_configuration, save_window_save): Handle persistent
1024 2012-01-14 Eli Zaretskii <eliz@gnu.org>
1026 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
1027 thrashing the stack of the thread. (Bug#9087)
1029 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
1031 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
1033 2012-01-11 Eli Zaretskii <eliz@gnu.org>
1035 * xdisp.c (rows_from_pos_range): Handle the case where the
1036 highlight ends on a newline. (Bug#10464)
1037 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
1038 he end column for display of highlight that ends on a newline
1041 2012-01-11 Glenn Morris <rgm@gnu.org>
1043 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
1044 from load-path also when installation-directory is nil. (Bug#10208)
1046 2012-01-10 Glenn Morris <rgm@gnu.org>
1048 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
1050 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
1051 Update template values to be closer to their typical values these days.
1053 2012-01-09 Eli Zaretskii <eliz@gnu.org>
1055 * xdisp.c (rows_from_pos_range): Accept additional argument
1056 DISP_STRING, and accept any glyph in a row whose object is that
1057 string as eligible for mouse highlight. Fixes mouse highlight of
1058 display strings from overlays. (Bug#10464)
1060 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
1062 emacs: fix an auto-save permissions race condition (Bug#10400)
1063 * fileio.c (auto_saving_dir_umask): New static var.
1064 (Fmake_directory_internal): Use it.
1065 (do_auto_save_make_dir): Set it, instead of invoking chmod after
1066 creating the directory. The old code temporarily assigns
1067 too-generous permissions to the directory.
1068 (do_auto_save_eh): Clear it.
1069 (Fdo_auto_save): Catch all errors, not just file errors, so
1070 that the var is always cleared.
1072 2012-01-07 Eli Zaretskii <eliz@gnu.org>
1074 * search.c (scan_buffer): Pass character positions to
1075 know_region_cache, not byte positions. (Bug#6540)
1077 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
1079 * w32.c (sys_rename): Report EXDEV when rename of a directory
1080 fails because the target is on another logical disk. (Bug#10284)
1082 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
1084 * xterm.c (x_embed_request_focus): New function.
1086 * xterm.h: Add prototype.
1088 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
1090 2012-01-05 Glenn Morris <rgm@gnu.org>
1092 * emacs.c (emacs_copyright): Update short copyright year to 2012.
1094 2012-01-01 Eli Zaretskii <eliz@gnu.org>
1096 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
1097 Load gnutls_transport_set_lowat only if GnuTLS version is below
1099 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
1100 GnuTLS versions below 2.11.1.
1102 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
1104 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
1105 to the doc string advising against its use for altering the way
1106 windows are scrolled.
1108 2011-12-28 Kenichi Handa <handa@m17n.org>
1110 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
1111 coding-system ASCII compatible only when it does not produce BOM
1112 on encoding (Bug#10383).
1114 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
1116 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
1118 (create_and_show_popup_menu): Always use menu_position_func for
1121 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
1123 * callint.c (Fcall_interactively): Don't truncate prompt string.
1125 2011-12-23 Eli Zaretskii <eliz@gnu.org>
1127 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
1128 property that ends at ZV, so that the bidi iteration could be
1129 resumed from there (after widening). (Bug#10360)
1131 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
1133 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
1135 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
1137 * nsterm.m (x_free_frame_resources):
1138 Release f->output_data.ns->miniimage.
1139 (ns_index_color): Fix indentation. Do not retain
1140 color_table->colors[i].
1142 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
1145 * nsfns.m (x_set_background_color): Assign return value from
1146 ns_index_color to face-background instead of NSColor*.
1147 (ns_implicitly_set_icon_type): Fix indentation.
1148 Change assignment in for loop to comparison.
1150 * emacs.c (ns_pool): New variable.
1151 (main): Assign ns_pool.
1152 (Fkill_emacs): Call ns_release_autorelease_pool.
1154 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
1155 autorelease fdesc, release fdAttrs and tdict.
1156 (ns_get_covering_families): Release charset.
1157 (ns_findfonts): Release NSFontDescriptor created with new.
1158 (ns_uni_to_glyphs): Fix indentation.
1159 (setString): Release attrStr before assigning new value.
1161 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1163 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
1165 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
1166 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
1168 2011-12-18 David Reitter <reitter@cmu.edu>
1170 * nsterm.m (ns_term_init): Subscribe for notifications
1171 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1172 to method trackingNotification in EmacsMenu.
1174 * nsmenu.m (trackingMenu): New variable.
1175 (trackingNotification): New method (from Aquamacs).
1176 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
1177 from Aquamacs (Bug#7030).
1179 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1181 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1182 (symbol_to_nsstring): Fix indentation.
1183 (ns_symbol_to_pb): New function.
1184 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1185 (Fns_rotate_cut_buffers_internal): Remove.
1186 (Fns_store_selection_internal): Rename from
1187 Fns_store_cut_buffer_internal.
1188 (ns_get_foreign_selection, Fx_own_selection_internal)
1189 (Fx_disown_selection_internal, Fx_selection_exists_p)
1190 (Fns_get_selection_internal, Fns_store_selection_internal):
1191 Use ns_symbol_to_pb and check if return value is nil.
1192 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1193 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
1194 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1195 renamed to Sns_store_selection_internal.
1196 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1197 and remove this function.
1198 (ns_handle_selection_clear): Remove, never used.
1199 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1202 2011-12-17 Ken Brown <kbrown@cornell.edu>
1204 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1205 GID is unknown (Bug#10257).
1207 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1209 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1210 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1211 which caused a build failure on GNU/Linux IA-64. This problem was
1212 introduced by my 2011-10-07 patch.
1214 2011-12-15 Juri Linkov <juri@jurta.org>
1216 * image.c (imagemagick_error): New function. (Bug#10112)
1217 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1218 Use `imagemagick_error' where ImageMagick functions return
1220 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1223 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1225 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1226 fill background (Bug#8992).
1228 2011-12-13 Martin Rudalics <rudalics@gmx.at>
1230 * window.c (Vwindow_combination_resize)
1231 (Vwindow_combination_limit): Use t instead of non-nil in
1233 (Vrecenter_redisplay): Add first sentence of doc-string on
1235 (Frecenter): Fix doc-string typo.
1237 2011-12-11 Kenichi Handa <handa@m17n.org>
1239 * coding.c (Funencodable_char_position): Pay attention to the
1240 buffer text relocation (Bug#9389).
1242 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1244 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1245 gtk_init (Bug#10100).
1247 2011-12-10 Eli Zaretskii <eliz@gnu.org>
1249 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1250 IT->string is nil. (Bug#10263)
1252 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1254 * nsterm.h (x_free_frame_resources): Declare.
1256 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1257 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1259 * nsterm.h (ns_get_defaults_value): Declare.
1261 * nsterm.m (ns_default): Call ns_get_defaults_value.
1263 2011-12-09 Eli Zaretskii <eliz@gnu.org>
1265 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1268 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1270 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1271 that where the value of an _OBJC_* symbol points to is in the .bss
1272 section (Bug#10240).
1274 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1276 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
1277 after the loop to call ccl_driver at least once (Bug#8619).
1279 2011-12-08 Kenichi Handa <handa@m17n.org>
1281 * ftfont.c (get_adstyle_property): Fix previous change
1284 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
1286 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1287 dirs from the default value of EMACSLOADPATH (bug#10208).
1289 2011-12-07 Glenn Morris <rgm@gnu.org>
1291 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1292 installation and source directories as well. (Bug#10208)
1294 2011-12-06 Chong Yidong <cyd@gnu.org>
1296 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1298 2011-12-06 Glenn Morris <rgm@gnu.org>
1300 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1301 as an error, not just -1. (Bug#10217)
1303 2011-12-05 Chong Yidong <cyd@gnu.org>
1305 * keyboard.c (process_special_events): New function.
1306 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1308 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1310 * coding.c (encode_designation_at_bol): Don't use uninitialized
1311 local variable (Bug#9318).
1313 2011-12-05 Kenichi Handa <handa@m17n.org>
1315 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1316 return Qnil (Bug#8046, Bug#10193).
1318 2011-12-05 Kenichi Handa <handa@m17n.org>
1320 * coding.c (encode_designation_at_bol): New args charbuf_end and
1321 dst. Return the number of produced bytes. Callers changed.
1322 (coding_set_source): Return how many bytes coding->source was
1324 (coding_set_destination): Return how many bytes
1325 coding->destination was relocated.
1326 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
1327 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
1329 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1331 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1332 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1335 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1337 The following changes are to fix Bug#9318.
1339 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1340 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1341 (encode_coding_iso_2022, encode_coding_sjis)
1342 (encode_coding_big5, encode_coding_charset): Use the above macros.
1344 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
1346 * lisp.h (process_quit_flag): Fix external declaration.
1348 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1350 Don't macro-inline non-performance-critical code.
1351 * eval.c (process_quit_flag): New function.
1352 * lisp.h (QUIT): Use it.
1354 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1356 * nsfns.m (get_geometry_from_preferences): New function.
1357 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1359 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1361 * emacs.c (Qkill_emacs): Define.
1362 (syms_of_emacs): Initialize it.
1363 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1364 Qquit_flag to `kill-emacs' instead.
1365 (quit_throw_to_read_char): Add parameter `from_signal'.
1366 All callers changed. Call Fkill_emacs if requested and safe.
1367 * lisp.h (QUIT): Call Fkill_emacs if requested.
1369 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1371 * widget.c (update_wm_hints): Return if wmshell is null.
1372 (widget_update_wm_size_hints): New function.
1374 * widget.h (widget_update_wm_size_hints): Declare.
1376 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1377 widget_update_wm_size_hints (Bug#10104).
1379 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1381 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1382 before a newline, prepare the bidi iterator for consuming the
1383 newline, and keep the current paragraph direction. (Bug#10183)
1384 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1386 2011-12-02 Juri Linkov <juri@jurta.org>
1388 * search.c (Fword_search_regexp): New Lisp function created from
1389 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1390 (Fword_search_backward, Fword_search_forward)
1391 (Fword_search_backward_lax, Fword_search_forward_lax):
1392 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1393 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1395 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1397 * fileio.c (Finsert_file_contents): Move after-change-function call
1398 to before the "handled:" label, since all "goto handled" appear in
1399 cases where the *-change-functions have already been properly called
1402 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1404 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1405 waiting for input. (Bug#10169)
1407 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1409 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1410 verifies glyph row's hash code--we have just reallocated the
1411 glyphs, so their contents can be complete garbage. (Bug#10164)
1413 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1415 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1417 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1419 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1420 attributes are tested _before_ calling verify_row_hash, to protect
1421 against GCC re-ordering of the tests. (Bug#10164)
1423 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1425 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1427 * xterm.c (handle_one_xevent): Only set async_visible and friends
1428 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1429 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1430 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1432 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1434 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1435 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1436 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1437 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1438 All uses changed to use GCPRO1 etc.
1439 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1440 Revert to old implementation (i.e., before 2011-03-11).
1442 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1444 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1445 of scroll runs so as to avoid assigning disabled bogus rows and
1446 unnecessary graphics copy operations.
1448 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1450 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1451 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1452 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1453 (malloc, free, realloc, calloc): Redirect to e_* only when
1456 * lisp.h (GCTYPEBITS): Move before first use.
1457 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1458 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1459 this macro definition.
1461 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1464 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1466 * gtkutil.c (xg_create_frame_widgets):
1467 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1468 present with Gtk+ 2.0.
1470 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1472 * fileio.c (Finsert_file_contents): Undo previous change; see
1473 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1475 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1477 Rename locals to avoid shadowing.
1478 * fileio.c (Finsert_file_contents):
1479 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1480 * process.c (wait_reading_process_output):
1481 Rename inner 'proc' to 'p' to avoid shadowing.
1482 Indent for consistency with usual Emacs style.
1484 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1486 * xdisp.c (redisplay_window): If cursor row is not fully visible
1487 after recentering, and scroll-conservatively is set to a large
1488 number, scroll window by a few more lines to make the cursor fully
1489 visible and out of scroll-margin. (Bug#10105)
1490 (start_display): Don't move to the next line if the display should
1491 start at a newline that is part of a display vector or an overlay
1494 2011-11-24 Juri Linkov <juri@jurta.org>
1496 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1497 after the `MagickPingImage' call. (Bug#10112)
1499 2011-11-23 Chong Yidong <cyd@gnu.org>
1501 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1503 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1505 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1506 making another buffer current. (Bug#10114)
1508 2011-11-23 Glenn Morris <rgm@gnu.org>
1510 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1512 2011-11-23 Chong Yidong <cyd@gnu.org>
1514 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1515 using it (Bug#5984).
1517 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1519 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1520 and header-lines, as they don't have one computed for them.
1523 * .gdbinit (prow): Make displayed values more self-explaining.
1524 Add row's hash code.
1526 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1528 * process.c (wait_reading_process_output): Fix asynchrounous
1529 GnuTLS socket handling on some versions of the GnuTLS library.
1530 (wait_reading_process_output): Add comment and URL.
1532 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1534 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1536 2011-11-21 Chong Yidong <cyd@gnu.org>
1538 * window.c (Fnext_window, Fprevious_window): Doc fix.
1540 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1542 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1544 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1546 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1548 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1550 * window.c (Fset_window_combination_limit): Rename argument
1552 (Vwindow_combination_limit): Remove "status" from doc-string.
1554 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1556 * m/ibms390.h: Remove.
1557 * m/ibms390x.h: Don't include "ibms390.h".
1559 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1561 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1562 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1564 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1566 * casetab.c (Fset_case_table):
1567 * charset.c (Fcharset_after): Fix typos.
1569 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1571 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1572 Otherwise, valgrind does not work on some platforms.
1573 Problem reported by Andreas Schwab in
1574 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1575 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1576 is set, removing the need for VIRT_ADDRESS_VARIES.
1577 (PURE_P): Use a more-efficient implementation that needs just one
1578 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1579 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1580 to 4 (xorl, subq, cmpq, setbe).
1581 * alloc.c (pure): Always extern now, since that's the
1582 VIRT_ADDR_VARIES behavior.
1583 (PURE_POINTER_P): Use a single comparison, not two, for
1584 consistency with the new puresize.h.
1585 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1586 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1587 Remove VIRT_ADDR_VARIES no longer needed.
1589 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1591 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1592 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1593 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1594 behave as if the cursor position were at the window margin.
1596 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1597 and the cursor position is out of bounds, behave as if the cursor
1598 position were at the window margin. (Bug#10075)
1600 2011-11-18 Chong Yidong <cyd@gnu.org>
1602 * window.c (Fwindow_combination_limit): Make first argument
1603 non-optional, since it is meaningless for live windows like the
1606 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1608 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1610 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1612 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1613 (graft_intervals_into_buffer): Simplify.
1615 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1617 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1618 hash values of the two rows.
1619 (copy_row_except_pointers): Preserve the used[] arrays and the
1620 hash values of the two rows. (Bug#10035)
1621 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1623 * xdisp.c (row_hash): New function, body extracted from
1624 compute_line_metrics.
1625 (compute_line_metrics): Call row_hash, instead of computing the
1628 * dispnew.c (verify_row_hash): Call row_hash for computing the
1629 hash code of a row, instead of duplicating code from xdisp.c.
1631 * dispextern.h (row_hash): Add prototype.
1633 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1635 * frame.c (delete_frame): Don't delete the terminal when the last
1636 X frame is closed if emacs is built with GTK toolkit.
1638 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1640 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1642 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1644 * window.c (Vwindow_splits): Rename to
1645 Vwindow_combination_resize. Suggested by Juri Linkov.
1646 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1649 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1651 * nsfns.m (Fns_font_name):
1652 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1654 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1656 * window.h (window): Rename slot "nest" to "combination_limit".
1657 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1658 (Fset_window_nest): Rename to Fset_window_combination_limit.
1659 (Vwindow_nest): Rename to Vwindow_combination_limit.
1660 (recombine_windows, make_parent_window, make_window)
1661 (Fsplit_window_internal, saved_window)
1662 (Fset_window_configuration, save_window_save): Rename all
1663 occurrences of window_nest to window_combination_limit.
1665 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1667 * image.c (imagemagick_load_image): Fix typo.
1669 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1671 * xdisp.c (display_line): Move the call to
1672 highlight_trailing_whitespace before the call to
1673 compute_line_metrics, since the latter needs to see the final
1674 faces of all the glyphs to compute ROW's hash value.
1675 Fixes assertion violations in row_equal_p. (Bug#10035)
1677 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1679 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1680 just return (bug#10044).
1682 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1684 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1685 with user-defined heap size. Bump the default size of the temacs
1686 heap to 27MB, to avoid memory warning when running temacs.
1687 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1689 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1690 current_matrix and desired_matrix. (Bug#9990)
1691 (verify_row_hash) [XASSERTS]: New function.
1692 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1693 that the hash value of glyph rows is correct.
1695 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1697 * window.h (window): Remove splits slot.
1698 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1699 (Fdelete_other_windows_internal, make_parent_window)
1700 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1701 (Fset_window_configuration, save_window_save): Don't deal with
1702 split status of windows.
1703 (saved_window): Remove splits slot.
1704 (Vwindow_splits): Rewrite doc-string.
1706 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1708 * xfns.c (unwind_create_frame):
1709 * nsfns.m (unwind_create_frame):
1710 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1711 Vframe_list (Bug#9999).
1713 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1715 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1717 2011-11-11 Kenichi Handa <handa@m17n.org>
1719 * callproc.c (Fcall_process): Set the member dst_multibyte of
1722 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1724 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1725 avoid a crash (bug#9496).
1727 2011-11-09 Chong Yidong <cyd@gnu.org>
1729 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1730 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1732 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1734 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1736 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1738 Avoid some portability problems by eschewing 'extern inline' functions.
1739 The trivial performance wins aren't worth the portability hassles; see
1740 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1742 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1743 (window_box_width, window_box_left, window_box_left_offset)
1744 (window_box_right, window_box_right_offset): Undo previous change,
1745 by removing the "extern"s.
1746 * intervals.c (adjust_intervals_for_insertion)
1747 (adjust_intervals_for_deletion): Undo previous change,
1748 making these static again.
1749 (offset_intervals, temp_set_point_both, temp_set_point)
1750 (copy_intervals_to_string): No longer inline.
1751 * xdisp.c (window_text_bottom_y, window_box_width)
1752 (window_box_height, window_box_left_offset)
1753 (window_box_right_offset, window_box_left, window_box_right)
1754 (window_box): No longer inline.
1756 2011-11-08 Chong Yidong <cyd@gnu.org>
1758 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1759 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1760 Signal an error if not a live window.
1761 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1762 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1764 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1766 * lisp.h (syms_of_abbrev): Remove declaration.
1767 Reported by CHENG Gao <chenggao@royau.me>.
1769 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1771 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1772 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1773 of temacs in GUI mode.
1775 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1777 * window.h: Declare delete_all_child_windows instead of
1778 delete_all_subwindows.
1779 * window.c (Fwindow_nest, Fset_window_nest)
1780 (Fset_window_new_total, Fset_window_new_normal)
1781 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1782 (delete_all_subwindows): Rename to delete_all_child_windows.
1783 (Fdelete_other_windows_internal, Fset_window_configuration):
1784 Call delete_all_child_windows instead of delete_all_subwindows.
1785 * frame.c (delete_frame): Call delete_all_child_windows instead
1786 of delete_all_subwindows.
1788 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1790 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1791 This is also needed for porting to any host where GC_MARK_STACK is
1792 not GC_MAKE_GCPROS_NOOPS.
1793 (which_symbols): Use it.
1795 2011-11-07 Kenichi Handa <handa@m17n.org>
1797 * coding.c (coding_set_destination): Check coding->src_pos only
1798 when coding->src_object is a buffer (bug#9910).
1800 * process.c (send_process): Set the member src_multibyte of coding
1801 to 0 (bug#9911) when sending a unibyte text.
1803 * callproc.c (Fcall_process): Set the member src_multibyte of
1804 process_coding to 0 (bug#9912).
1806 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1808 * xmenu.c (cleanup_widget_value_tree): New function.
1809 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1810 calling free_menubar_widget_value_tree directly (Bug#9830).
1812 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1814 Fix some portability problems with 'inline'.
1815 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1816 (window_box_width, window_box_left, window_box_left_offset)
1817 (window_box_right, window_box_right_offset): Declare extern.
1818 Otherwise, these inline functions do not conform to C99 and
1819 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1820 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1821 * intervals.c (adjust_intervals_for_insertion)
1822 (adjust_intervals_for_deletion): Now extern, because otherwise the
1823 extern inline functions 'offset_intervals' couldn't refer to it.
1824 (static_offset_intervals): Remove.
1825 (offset_intervals): Rewrite using the old contents of
1826 static_offset_intervals. The old version didn't conform to C99
1827 because an extern inline function contained a reference to an
1828 identifier with static linkage.
1830 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1832 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1835 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1837 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1838 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1839 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1840 return Qleft_to_right.
1842 2011-11-06 Chong Yidong <cyd@gnu.org>
1844 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1845 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1846 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1847 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1848 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1849 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1850 (Fwindow_vscroll): Doc fix.
1851 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1852 argument, since it makes no sense to pass a live window and for
1853 consistency with window-child.
1855 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1857 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1860 2011-11-05 Jason Rumney <jasonr@gnu.org>
1862 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1863 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1865 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1866 bitwise arithmetic preventing use of unicode-sip and non-truetype
1869 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1871 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1874 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1875 initialization code to keep similarity to xfns.c after changes
1878 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1880 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1881 (unwind_create_frame): New function (Bug#9943).
1882 (Fx_create_frame): Restructure code to be more similar to the one in
1883 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1884 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1885 Move terminal->reference_count++ just before making the frame official
1888 * nsterm.m (x_free_frame_resources): New function.
1889 (x_destroy_window): Move code to x_free_frame_resources.
1891 * xfns.c (unwind_create_frame): Fix comment.
1892 (Fx_create_frame, x_create_tip_frame):
1893 Move terminal->reference_count++ just before making the frame
1894 official. Move initialization of image_cache_refcount and
1895 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1897 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1899 Support MSVC build with newer versions of Visual Studio.
1900 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1901 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1904 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1905 which are not supported by MSVC.
1906 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1907 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1909 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1911 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1913 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1915 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1917 Support MSVC build with newer versions of Visual Studio.
1918 * w32.c: Don't include w32api.h for MSVC.
1919 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1921 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1922 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1923 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1924 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1926 (alloca) [_MSC_VER]: Define to _alloca.
1928 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1930 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1932 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1934 * xdisp.c (note_mouse_highlight): If either of
1935 previous/next-single-property-change returns nil, treat that as
1936 the beginning or the end of the buffer. (Bug#9955)
1938 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1940 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1941 label is not null (Bug#9951).
1942 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1945 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1947 * window.c (Fwindow_body_size): Mention in the doc string that the
1948 return value is in frame's canonical units. (Bug#9949)
1950 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1952 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1954 * w32fns.c (unwind_create_frame): If needed, free the glyph
1955 matrices of the partially constructed frame. (Bug#9943)
1956 * xfns.c (unwind_create_frame): Likewise.
1958 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1960 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1961 Don't stop backward scan on the continuation glyph, even though
1962 its CHARPOS is positive.
1963 (mouse_face_from_buffer_pos, note_mouse_highlight):
1964 Rename cover_string to disp_string.
1966 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1968 * window.c (temp_output_buffer_show): Don't use
1969 Vtemp_buffer_show_specifiers.
1970 (Vtemp_buffer_show_specifiers): Remove unused variable.
1972 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1974 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1975 past the beginning of the current glyph matrix.
1977 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1979 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1980 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1981 HAVE_GTK3 (Bug#9869).
1983 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1984 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1986 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1988 * xterm.c: Declare x_handle_net_wm_state to return int.
1989 (handle_one_xevent): Check if we are iconified but don't have
1990 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1991 (get_current_wm_state): Return non-zero if not hidden,
1992 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1993 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1994 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1995 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1997 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1999 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
2000 so that this new function doesn't get optimized away by a
2001 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
2003 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2005 * frame.h (MOUSE_HL_INFO): Remove excess parens.
2007 2011-10-29 Eli Zaretskii <eliz@gnu.org>
2009 Fix the `xbytecode' command.
2010 * .gdbinit (xprintbytestr): New command.
2011 (xwhichsymbols): Rename from `which'; all callers changed.
2012 (xbytecode): Print the byte-code string as well.
2014 2011-10-29 Kim Storm <storm@cua.dk>
2016 * alloc.c (which_symbols): New function.
2018 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2020 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
2023 2011-10-29 Glenn Morris <rgm@gnu.org>
2025 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
2026 Not clear what it was for, and it causes various bugs. (Bug#9839)
2028 2011-10-28 Eli Zaretskii <eliz@gnu.org>
2030 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
2031 possible random value that matches one of those tested as
2032 condition to clear the mouse face.
2034 2011-10-28 Chong Yidong <cyd@gnu.org>
2036 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
2038 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
2040 * window.c (make_window): Initialize phys_cursor_on_p.
2042 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
2044 * lisp.h (struct Lisp_Symbol): Update comments.
2046 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
2048 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
2050 2011-10-28 Eli Zaretskii <eliz@gnu.org>
2052 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
2053 <oslsachem@gmail.com> for helping to debug this.
2055 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
2056 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
2057 (g_b_init_get_glyph_outline_w): New static variables.
2058 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
2059 (GetGlyphOutlineW_Proc): New typedefs.
2060 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
2061 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
2063 (w32font_open_internal, compute_metrics):
2064 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
2065 instead of calling the "wide" APIs directly.
2067 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
2069 * w32.h (syms_of_w32font): Add prototype.
2071 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
2073 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
2074 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
2075 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
2076 (Fmove_to_window_line): Doc fix.
2078 2011-10-27 Chong Yidong <cyd@gnu.org>
2080 * process.c (make_process): Set gnutls_state to NULL.
2082 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
2083 non-NULL, regardless of GNUTLS_INITSTAGE.
2084 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
2085 an error. Set process slots as soon as we allocate them.
2087 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
2089 2011-10-27 Chong Yidong <cyd@gnu.org>
2091 * gnutls.c (emacs_gnutls_deinit): New function.
2092 Deallocate credentials structures as well as calling gnutls_deinit.
2093 (Fgnutls_deinit, Fgnutls_boot): Use it.
2095 * process.c (make_process): Initialize GnuTLS credentials to NULL.
2096 (deactivate_process): Call emacs_gnutls_deinit.
2098 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
2100 * image.c (x_create_x_image_and_pixmap):
2101 * w32.c (sys_rename, w32_delayed_load):
2102 * w32font.c (fill_in_logfont):
2103 * w32reg.c (x_get_string_resource): Silence compiler warnings.
2105 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
2107 * w32fns.c (w32_default_color_map): New function,
2108 extracted from Fw32_default_color_map.
2109 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
2111 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
2113 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
2115 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
2117 * keyboard.c (test_undefined): New function (bug#9751).
2118 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
2120 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
2122 * sysdep.c (init_sys_modes): Fix the check for the controlling
2123 terminal (Bug#6649).
2125 2011-10-20 Eli Zaretskii <eliz@gnu.org>
2127 * dispextern.h (struct bidi_it): New member next_en_type.
2129 * bidi.c (bidi_line_init): Initialize the next_en_type member.
2130 (bidi_resolve_explicit_1): When next_en_pos is valid for the
2131 current character, check also for next_en_type being WEAK_EN.
2132 (bidi_resolve_weak): Don't enter the expensive loop if the current
2133 position is before next_en_pos. Record the bidi type of the first
2134 non-ET, non-BN character we find, in addition to its position.
2135 (bidi_level_of_next_char): Invalidate next_en_type when
2136 next_en_pos is over-stepped.
2138 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
2140 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
2141 * editfns.c: Rewrite current-time-zone so that it invokes
2142 the equivalent of (format-time-string "%Z") to get the time zone name.
2143 This fixes a bug when the time zone name contains characters that
2144 need converting from the system time locale to Emacs internal format.
2145 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
2146 that patch fixed format-time-string to do the conversion, but
2147 I forgot to fix current-time-zone.
2148 (format_time_string): New function, containing most of
2149 what Fformat_time_string used to contain.
2150 (Fformat_time_string): Rewrite in terms of format_time_string.
2151 This doesn't change this function's behavior.
2152 (current-time-zone): Rewrite to use format_time_string.
2153 This fixes the bug reported by Michael Schierl in
2154 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
2155 Jason Rumney's 2007-06-07 change worked around this bug, but
2157 * systime.h (tzname, timezone): Remove no-longer-used declarations.
2159 2011-10-19 Eli Zaretskii <eliz@gnu.org>
2161 * xdisp.c (start_display): If the character at POS is displayed
2162 via a display vector, reset IT->current.dpvec_index to zero.
2163 (try_window_reusing_current_matrix): If a line ends in a display
2164 vector or the next line starts in a display vector, continue
2165 redrawing the window even though the character position of
2166 start_row was reached.
2169 2011-10-18 Chong Yidong <cyd@gnu.org>
2171 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2172 with nobreak-char-display too.
2174 2011-10-18 Eli Zaretskii <eliz@gnu.org>
2176 Fix part 3 of bug#9771.
2177 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2178 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2179 non-neutral characters if the current character is a paragraph
2180 separator (a.k.a. Newline). This avoids running the same
2181 expensive loop twice, once when we consume the preceding newline
2182 and the other time when the line actually needs to be displayed.
2183 Avoid the loop when we see neutrals on the base embedding level
2184 following a character whose directionality is the same as the
2185 paragraph's. This avoids running the expensive loop when a line
2186 ends in a long sequence of neutrals, like control characters.
2187 Add assertion against STRONG_AL type. Slightly rearrange code
2188 that determines the type of a neutral given the first non-neutral
2190 (bidi_level_of_next_char): Set next_en_pos to zero when
2191 invalidating its info.
2193 2011-10-17 Eli Zaretskii <eliz@gnu.org>
2195 * xdisp.c (push_display_prop): Determine whether to record string
2196 or buffer position by IT->string, not by IT->method. Allow
2197 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
2198 (move_it_vertically_backward): Don't look for character position
2199 immediately after the newline when in a continuation line.
2202 2011-10-15 Martin Rudalics <rudalics@gmx.at>
2204 * window.c (coordinates_in_window): Rewrite and delabelize
2205 vertical border check. (Bug#5357) (Bug#9618)
2207 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2209 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2210 errors in XSetWindowBorder (bug#9310).
2212 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2214 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2215 avoid crash when xmalloc overrun checking is enabled.
2217 2011-10-13 Eli Zaretskii <eliz@gnu.org>
2219 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2220 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2221 cursor motion with <left> and <right> arrow keys.
2223 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2224 some callers set that themselves.
2226 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2228 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2229 display string and the previous row comes from the same string and
2230 is empty. (Bug#9739) (Bug#9738)
2232 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2234 * doc.c (get_doc_string): Encode file name (bug#9735).
2236 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2238 * bidi.c (bidi_level_of_next_char):
2239 * xdisp.c (get_visually_first_element): Remove old incorrect
2240 comments regarding the Unicode Line Separator character.
2242 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2244 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2246 * alloc.c (Fgc_status): Do not access beyond zombies array
2247 boundary if nzombies > MAX_ZOMBIES.
2248 * alloc.c (dump_zombies): Add missing format specifier.
2250 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2252 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2253 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2255 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2256 Some packages use them to denote characters with modifiers.
2258 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2260 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2261 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2262 matching a pp-number. Rename parameter var to var1.
2264 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2266 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2268 2011-10-08 Glenn Morris <rgm@gnu.org>
2270 * callint.c (Fcall_interactively): Give a more explicit error for the
2271 'c' case with a non-character input. (Bug#8479)
2273 2011-10-08 Eli Zaretskii <eliz@gnu.org>
2275 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2277 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2278 lines that are hscrolled on the left.
2280 * dispnew.c (buffer_posn_from_coords): Account for a possible
2281 presence of header-line. (Bug#4426)
2283 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2285 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2286 Don't advertise functionality which we discourage or doesn't work.
2288 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2290 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2291 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2292 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2293 this makes Emacs dump core during garbage collection on rare
2294 occasions. sizeof is obviously inferior to offsetof here, so
2295 stick with offsetof.
2296 (GC_POINTER_ALIGNMENT): New macro.
2297 (mark_memory): Omit 3rd (offset) arg; caller changed.
2298 Don't assume EMACS_INT alignment is the same as pointer alignment.
2300 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2302 * keyboard.c (read_key_sequence_remapped): New var.
2303 (read_key_sequence): Compute remapping in the right buffer.
2304 (command_loop_1): Use read_key_sequence's remapping directly.
2306 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2308 * dired.c (file_name_completion): Don't expand file name.
2309 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2310 before checking file name handler.
2312 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2313 they've been requested explicitly (bug#9591).
2315 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
2317 * keymap.c (Fsingle_key_description): Use make_specified_string
2318 instead of build_string to build string from push_key_description.
2321 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2323 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2324 This fixes a Y2038 bug on 64-bit hosts.
2325 * buffer.c (reset_buffer):
2326 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2327 (Fclear_buffer_auto_save_failure):
2328 Use 0, not -1, to represent an unset failure time, since time_t
2329 might not be signed.
2331 Remove dependency on glibc malloc internals.
2332 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2333 Move back here from lisp.h, but with their new implementations.
2334 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2335 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2336 * charset.c (charset_table_init): New static var.
2337 (syms_of_charset): Use it instead of xmalloc. This removes a
2338 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2339 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2340 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2341 Move back to alloc.c.
2342 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2343 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2345 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2347 * nsterm.m (windowDidResize): Call x_set_window_size only when
2348 ns_in_resize is true. Otherwise set pixelwidth/height and
2349 call change_frame_size (Bug#9628).
2351 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2353 Port --enable-checking=all to Fedora 14 x86-64.
2354 * charset.c (syms_of_charset): Also account for glibc malloc's
2355 internal overhead when calculating the initial malloc maximum.
2357 Port --enable-checking=all to Fedora 14 x86.
2358 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2360 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2361 (overrun_check_realloc, overrun_check_free):
2362 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2363 That way, xmalloc returns a properly-aligned pointer even if
2364 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2365 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2366 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2367 into account when calculating the initial malloc maximum.
2368 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2369 Move here from alloc.c, so that charset.c can use it too.
2370 Properly align; the old code wasn't right for common 32-bit hosts
2371 when configured with --enable-checking=all.
2372 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2373 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2375 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2377 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2380 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2382 * xdisp.c (compute_display_string_end): If there's no display
2383 string at CHARPOS, return -1.
2385 * bidi.c (bidi_fetch_char): When compute_display_string_end
2386 returns a negative value, treat the character as a normal
2387 character not covered by a display string. (Bug#9624)
2389 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2391 * lread.c (Fread_from_string): Fix typo in docstring.
2393 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2395 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2396 newline, reseat the iterator instead of bidi-iterating there one
2397 character at a time. (Bug#9610)
2398 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2399 TO_CHARPOS if the bidi iterator is at base embedding level.
2401 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2403 * lread.c (readevalloop): Use correct code for NBSP.
2404 (read1): Likewise. (Bug#9608)
2406 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2408 * dbusbind.c (Fdbus_register_signal): When service is not
2409 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2411 2011-09-25 Glenn Morris <rgm@gnu.org>
2413 * buffer.c (truncate-lines): Doc fix.
2415 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2417 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2418 (Fset_window_next_buffers): Doc fix.
2420 2011-09-24 Glenn Morris <rgm@gnu.org>
2422 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2424 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2426 Fix minor problems found by static checking.
2427 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2428 * indent.c (Fvertical_motion): Fix == vs = typo.
2430 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2432 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2433 Default value is now t. Doc fix.
2435 * indent.c (Fvertical_motion): Compute and apply the overshoot
2436 logic when moving up, not only when moving down. Fix the
2437 confusing name and values of the it_overshoot_expected variable;
2438 logic changes accordingly. (Bug#9254) (Bug#9549)
2440 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2441 CHARPOS is covered by a display string which includes newlines.
2442 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2443 is covered by a display string with embedded newlines.
2445 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2447 * dbusbind.c (Fdbus_register_signal): Add match rule to
2448 Vdbus_registered_objects_table. (Bug#9581)
2449 (Fdbus_register_method, Vdbus_registered_objects_table):
2452 2011-09-24 Jim Meyering <meyering@redhat.com>
2454 do not ignore write error for any output size
2455 The previous change was incomplete.
2456 While it makes emacs --batch detect the vast majority of stdout
2457 write failures, errors were still ignored whenever the output size is
2458 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2459 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2460 && echo FAIL: ignored write error
2461 FAIL: ignored write error
2462 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2463 && echo FAIL: ignored write error
2464 FAIL: ignored write error
2465 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2467 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2469 * emacs.c (Fkill_emacs): In noninteractive mode exit
2470 non-successfully if a write error occurred on stdout. (Bug#9574)
2472 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2474 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2477 * dispextern.h (struct it): Update the comment documenting what
2480 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2482 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2483 a display string, extend search for cursor position to end of row.
2484 (find_row_edges): If the row ends in a newline from a display
2485 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2486 Handle the case of a display string with multiple newlines.
2487 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2488 non-empty line. Fixes confusing cursor motion with arrow keys at
2489 the beginning of a line that starts with whitespace.
2491 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2493 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2496 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2498 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2501 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2503 * xdisp.c (display_line): Record maximum and minimum buffer
2504 positions even if no glyphs were produced (e.g., by a zero-width
2505 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2506 buffer positions that will be removed from the glyph row because
2508 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2509 column is beyond frame width: don't subtract 1 "pixel" when
2510 computing width of the stretch.
2511 (reseat_at_next_visible_line_start): Undo the change made on
2512 2011-09-17 that saved paragraph information and restored it after
2513 the call to `reseat'. (Bug#9545)
2515 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2517 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2518 and turn window cursor on if cleared (Bug#9415).
2520 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2522 * search.c (boyer_moore): Take unibyte characters from pattern
2523 literally. (Bug#9458)
2525 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2527 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2529 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2531 Fix minor problem found by static checking.
2532 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2533 initialized, to pacify gcc -Wuninitialized.
2535 * fileio.c: Report proper errno when syscall falls.
2536 (Finsert_file_contents): Save and restore errno,
2537 so that report_file_error outputs the correct diagnostic.
2538 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2540 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2542 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2544 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2546 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2547 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2549 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2551 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2552 about the current paragraph and restore it after the call to reseat.
2554 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2555 (bidi_find_paragraph_start): Search back for paragraph beginning
2556 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2557 (bidi_move_to_visually_next): Only trigger paragraph-related
2558 computations when the last character is a newline or at EOB, not
2559 just any NEUTRAL_B. (Bug#9470)
2561 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2562 truncated lines if point is covered by a display string. (Bug#9524)
2564 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2566 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2567 (cons_to_x_long): New function.
2568 (lisp_data_to_selection_data): Use it. Correct the test for
2569 short-versus-long data; it was negated. Break out of vector
2570 loop, for efficiency, when a long datum is discovered.
2572 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2574 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2576 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2578 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2579 GCC PR/17406) by declaring this function with external scope.
2581 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2583 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2584 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2586 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2588 * editfns.c (Fformat): Correctly handle text properties on "%%".
2590 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2592 * xterm.c (x_draw_composite_glyph_string_foreground):
2593 * w32term.c (x_draw_composite_glyph_string_foreground):
2594 * term.c (encode_terminal_code):
2595 * composite.c (composition_update_it, get_composition_id):
2596 * xdisp.c (get_next_display_element)
2597 (fill_composite_glyph_string): Add comments about special meaning
2598 of TAB characters in a composition.
2600 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2602 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2603 This occurs when processing a multibyte format.
2604 Problem reported by Wolfgang Jenker.
2606 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2608 * xdisp.c (try_cursor_movement): Only check for exact match if
2609 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2611 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2613 Remove unused external symbols.
2614 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2615 * xdisp.c (calc_pixel_width_or_height): Now static.
2616 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2617 * indent.c (check_display_width):
2618 * w32term.c: Fix comment to match code.
2619 * xterm.c, xterm.h (x_catching_errors): Remove.
2621 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2623 * xselect.c: Use signed conversions more consistently (Bug#9498).
2624 (selection_data_to_lisp_data): Assume incoming selection data are
2625 signed integers, not unsigned. This is to be consistent with
2626 outgoing selection data, which was modified to use signed integers
2627 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2628 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2629 expects long, not unsigned long.
2631 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2633 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2634 computation of loop end. Reported by Johan Bockgård
2637 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2639 * frame.c (Fother_visible_frames_p): Function deleted.
2641 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2643 * indent.c (compute_motion): Process display vector front to back
2644 rather than the other way around. (Bug#2496)
2646 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2648 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2650 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2652 * minibuf.c (Fread_from_minibuffer): Doc fix.
2654 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2656 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2657 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2659 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2661 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2662 value for non-existent files.
2664 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2666 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2667 set its "size" to -1. This will set the modtime_size field of
2668 the corresponding buffer to -1, which is what
2669 verify-visited-file-modtime expects for files that do not exist.
2672 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2674 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2676 * lisp.h: ... from here. push_key_description is no longer
2677 defined in keyboard.c, so its declaration should not be in
2678 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2679 logically belongs with push_key_description.
2681 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2683 * buffer.h: Include <sys/types.h> instead of <time.h>.
2684 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2685 Problem reported by Herbert J. Skuhra.
2687 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2689 * xml.c (parse_region): Make the parsing work for
2690 non-comment-starting XML files again (bug#9144).
2692 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2694 * image.c (gif_load): Fix calculation of bottom and right corner.
2697 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2699 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2700 redisplay in small windows.
2702 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2704 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2706 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2708 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2709 Operate on live windows only.
2711 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2713 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2715 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2717 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2718 only under bidi iteration.
2720 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2722 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2724 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2726 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2727 Without this fix, the command to link temacs failed due to an
2728 undefined symbol __builtin_isnan. This is because
2729 /usr/include/iso/math_c99.h #defines isnan(x) to
2730 __builtin_isnan(x), but the bundled gcc, which identifies itself
2731 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2733 * floatfns.c (isnan): #undef, and then #define to a clone of
2735 (Fisnan): Always define, since it's always available now.
2736 (syms_of_floatfns): Always define isnan at the Lisp level.
2738 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2740 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2742 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2744 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2745 The previous code assumed that file offsets (off_t values) fit in
2746 EMACS_INT variables, which is not true on typical 32-bit hosts.
2747 The code messed up by falsely reporting buffer overflow in cases
2748 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2749 when "big" contains more than 2**29 bytes, even though this
2750 inserts just one byte and does not overflow the buffer.
2751 (Finsert_file_contents): Store file offsets as off_t
2752 values, not as EMACS_INT values. Check for overflow when
2753 converting between EMACS_INT and off_t. When checking for
2754 buffer overflow or for overlap, take the offsets into account.
2755 Don't use EMACS_INT for small values where int suffices.
2756 When checking for overlap, fix a typo: ZV was used where
2757 ZV_BYTE was intended.
2758 (Fwrite_region): Don't assume off_t fits into 'long'.
2759 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2761 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2763 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2765 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2767 sprintf-related integer and memory overflow issues (Bug#9412).
2769 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2770 (esprintf, exprintf, evxprintf): New functions.
2771 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2772 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2773 (modify_event_symbol): Do not assume that the length of
2774 name_alist_or_stem is safe to alloca and fits in int.
2775 (Fexecute_extended_command): Likewise for function name and binding.
2776 (Frecursion_depth): Wrap around reliably on integer overflow.
2777 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2778 since some callers pass EMACS_INT values.
2779 (Fsingle_key_description): Don't crash if symbol name contains more
2780 than MAX_ALLOCA bytes.
2781 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2782 (get_minibuffer): Arg is now EMACS_INT, not int.
2783 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2784 (esprintf, exprintf, evxprintf): New decls.
2785 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2787 * dbusbind.c (signature_cat): New function.
2788 (xd_signature, Fdbus_register_signal):
2789 Do not overrun buffer; instead, report string overflow.
2791 * dispnew.c (add_window_display_history): Don't overrun buffer.
2792 Truncate instead; this is OK since it's just a log.
2794 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2795 even if the time zone offset is outlandishly large.
2796 Don't mishandle offset == INT_MIN.
2798 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2799 when creating daemon; the previous buffer-overflow check was incorrect.
2801 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2802 which has the guts of the old verror function.
2804 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2805 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2807 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2808 (font_unparse_xlfd): Don't blindly alloca long strings.
2809 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2810 fits in int, when using sprintf. Use single snprintf to count
2811 length of string rather than counting it via multiple sprintfs;
2812 that's simpler and more reliable.
2813 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2814 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2815 sprintf, in case result does not fit in int.
2817 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2818 (fontset_from_font): Print it.
2820 * frame.c (tty_frame_count): Now printmax_t, not int.
2821 (make_terminal_frame, set_term_frame_name): Print it.
2822 (x_report_frame_params): In X, window IDs are unsigned long,
2823 not signed long, so print them as unsigned.
2824 (validate_x_resource_name): Check for implausibly long names,
2825 and don't assume name length fits in 'int'.
2826 (x_get_resource_string): Don't blindly alloca invocation name;
2827 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2830 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2831 (xg_check_special_colors, xg_set_geometry):
2832 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2834 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2835 Use esprintf, not sprintf, in case result does not fit in int.
2837 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2838 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2839 it as a large positive number.
2840 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2841 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2843 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2844 in case result does not fit in int.
2846 * print.c (float_to_string): Detect width overflow more reliably.
2847 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2848 buffer overrun. Don't assume list length fits in 'int'. Treat
2849 print length of 0 as 0, not as infinity; to be consistent with other
2850 uses of print length in this function. Don't overflow print length
2851 index. Don't assume hash table size fits in 'long', or that
2852 vectorlike size fits in 'unsigned long'.
2854 * process.c (make_process): Use printmax_t, not int, to format
2855 process-name gensyms.
2857 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2859 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2860 to avoid potential buffer overrun.
2862 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2863 if X resource line is longer than 512 bytes.
2865 * xfns.c (x_window): Make sprintf buffer a bit bigger
2866 to avoid potential buffer overrun.
2868 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2870 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2872 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2874 Integer overflow fixes for scrolling, etc.
2875 Without these, Emacs silently mishandles large integers sometimes.
2876 For example, "C-u 4294967297 M-x recenter" was treated as if
2877 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2879 * xdisp.c (try_window_id): Check Emacs fixnum range before
2880 converting to 'int'.
2882 * window.c (window_scroll_line_based, Frecenter):
2883 Check that an Emacs fixnum is in range before assigning it to 'int'.
2884 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2885 values converted from Emacs fixnums.
2886 (Frecenter): Don't wrap around a line count if it is out of 'int'
2887 range; instead, treat it as an extreme value.
2888 (Fset_window_configuration, compare_window_configurations):
2889 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2891 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2892 that can exceed INT_MAX. Check that EMACS_INT value is in range
2893 before assigning it to the (possibly-narrower) index.
2894 (match_limit): Don't assume that a fixnum can fit in 'int'.
2896 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2899 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2900 (Fvertical_motion): Don't wrap around LINES values that don't fit
2901 in 'int'. Instead, treat them as extreme values. This is good
2902 enough for windows, which can't have more than INT_MAX lines anyway.
2904 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2906 * Require libxml/parser.h to avoid compilation warning.
2908 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2910 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2911 since this reportedly can destroy thread storage.
2913 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2915 * syntax.c (find_defun_start): Update all cache variables if
2916 exiting early (Bug#9401).
2918 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2920 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2922 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2923 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2924 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2926 * term.c (tty_append_glyph): New function.
2927 (produce_stretch_glyph): Static function and its prototype deleted.
2929 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2932 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2934 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2935 when checking :margin (Bug#9390).
2936 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2937 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2938 so that the name doesn't mislead. All uses changed.
2940 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2942 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2945 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2947 * xdisp.c (move_it_to): Don't bail out early when reaching
2948 position beyond to_charpos, if we are scanning backwards.
2949 (move_it_vertically_backward): When DY == 0, make sure we get to
2950 the first character in the line after the newline.
2952 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2954 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2955 (ccl_driver): Do not generate an out-of-range pointer.
2956 (Fccl_execute_on_string): Remove unnecessary check for
2957 integer overflow, noted by Stefan Monnier in
2958 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2959 Remove a FIXME that didn't need fixing.
2960 Simplify the newly-introduced buffer reallocation code.
2962 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2964 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2966 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2968 Integer and memory overflow issues (Bug#9196).
2970 * doc.c (get_doc_string): Rework so that
2971 get_doc_string_buffer_size is the actual buffer size, rather than
2972 being 1 less than the actual buffer size; this makes xpalloc more
2975 * image.c (x_allocate_bitmap_record, cache_image):
2976 * xselect.c (Fx_register_dnd_atom):
2977 Simplify previous changes by using xpalloc.
2979 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2980 since either will do and ptrdiff_t is convenient with xpalloc.
2982 * charset.c (charset_table_size)
2983 (struct charset_sort_data.priority): Now ptrdiff_t.
2984 (charset_compare): Don't overflow if priorities differ greatly.
2985 (Fsort_charsets): Don't assume list length fits in int.
2986 Check for size-calculation overflow when allocating sort data.
2987 (syms_of_charset): Allocate an initial charset table that is
2988 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2990 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2992 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2993 The actual value is always <= INT_MAX, and leaving it unsigned made
2994 overflow checking harder.
2996 * dispextern.h (struct glyph_matrix.rows_allocated)
2997 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2998 with xpalloc. The values are still always <= INT_MAX.
3000 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
3002 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
3003 (SAFE_NALLOCA): New macro.
3005 * region-cache.c (struct boundary.pos, find_cache_boundary)
3006 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
3007 (set_cache_region, invalidate_region_cache)
3008 (revalidate_region_cache, know_region_cache, region_cache_forward)
3009 (region_cache_backward, pp_cache):
3010 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
3011 so that ptrdiff_t * can be passed to xpalloc.
3012 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
3013 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
3014 (pp_cache): Don't assume cache_len fits in int.
3015 * region-cache.h: Adjust extern decls to match.
3017 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
3018 EMACS_INT, since either will do, for xpalloc.
3020 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
3021 (xnmalloc, xnrealloc, xpalloc): New functions.
3023 * bidi.c (bidi_shelve_header_size): New constant.
3024 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
3025 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
3027 * bidi.c (bidi_cache_shrink):
3028 * buffer.c (overlays_at, overlays_in, record_overlay_string)
3030 Don't update size of array until after memory allocation succeeds,
3031 because xmalloc/xrealloc may not return.
3032 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
3033 now that we have proper integer overflow checking.
3034 (record_overlay_string, overlay_strings): Catch overflows when
3035 calculating size of overlay_str_buf.
3037 * callproc.c (Fcall_process): Check for size overflow when
3038 calculating size of args2.
3039 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
3040 Normally we prefer signed values, but sticking with ptrdiff_t would
3041 require adding more-complicated checks.
3043 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
3044 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
3045 Redo buffer-overflow calculations to avoid integer overflow.
3046 Add a FIXME comment where memory seems to be over-allocated.
3048 * character.c (Fstring): Check for size-calculation overflow.
3050 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
3051 unnecessary integer overflow. Check for size overflow.
3052 (encode_coding_object): Don't update size until xmalloc succeeds.
3054 * composite.c (get_composition_id): Check for overflow in glyph
3055 length calculations.
3057 Integer and memory overflow fixes for display code.
3058 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
3059 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
3060 (scrolling_window): Check for overflow in size calculations.
3061 (line_draw_cost, realloc_glyph_pool, add_row_entry):
3062 Don't assume glyph table len fits in int.
3063 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
3064 (row_table_size): Now ptrdiff_t, not int.
3065 (scrolling_window): Avoid overflow in size calculations.
3066 Don't update size until allocation succeeds.
3067 * fns.c (concat): Check for overflow in size calculations.
3068 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
3069 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3070 (NEXT_ALMOST_PRIME_LIMIT): New constant.
3072 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
3073 (get_doc_string): Check for size calculation overflow.
3074 Don't update size until allocation succeeds.
3075 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
3076 EMACS_INT, where ptrdiff_t will do.
3077 (Fsubstitute_command_keys): Check for string overflow.
3079 * editfns.c (set_time_zone_rule): Don't assume environment length
3081 (message_length): Now ptrdiff_t, not int.
3082 (Fmessage_box): Don't update size until allocation succeeds.
3083 Don't assume message length fits in int.
3084 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
3086 * emacs.c (main): Do not reallocate argv, since there is a null at
3087 the end that can be overwritten, and this way there's no need to
3088 worry about size-calculation overflow.
3089 (sort_args): Check for size-calculation overflow.
3091 * eval.c (init_eval_once, grow_specpdl): Don't update size until
3093 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
3095 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
3096 (x_set_scroll_bar_width, x_figure_window_size):
3097 Check for integer overflow.
3098 (x_set_alpha): Do not assume XINT fits in int.
3100 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
3101 This is for the members text_lines, text_cols, total_lines, total_cols,
3102 where the system imposes an 'int' limit.
3104 * fringe.c (Fdefine_fringe_bitmap):
3105 Don't update size until alloc works.
3107 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
3108 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
3110 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
3111 Check for size-calculation overflow.
3112 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
3113 do, as we prefer signed integers.
3114 (id_to_widget.max_size, id_to_widget.used)
3115 (xg_store_widget_in_map, xg_remove_widget_from_map)
3116 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
3117 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
3118 Use and return ptrdiff_t, not int.
3119 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
3120 * gtkutil.h: Change prototypes to match the above.
3122 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
3123 are duplicate now that they've been promoted to lisp.h.
3124 (x_allocate_bitmap_record, x_alloc_image_color)
3125 (make_image_cache, cache_image, xpm_load):
3126 Don't update size until alloc is done.
3127 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
3129 Check for size calculation overflow.
3130 (ct_colors_allocated_max): New constant.
3131 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
3134 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
3135 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
3136 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
3137 Use ptrdiff_t, not int, to count maps.
3138 (read_char_minibuf_menu_prompt): Check for overflow in size
3139 calculations. Don't update size until allocation succeeds.
3140 Redo calculations to avoid overflow.
3141 * keyboard.h: Change prototypes to match the above.
3143 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
3145 (current_minor_maps): Check for size calculation overflow.
3146 * keymap.h: Change prototypes to match the above.
3148 * lread.c (read1, init_obarray): Don't update size until alloc done.
3150 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
3151 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
3153 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
3154 Now ptrdiff_t, not int.
3155 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
3156 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
3158 * process.c (Fnetwork_interface_list): Check for overflow
3159 in size calculation.
3161 * region-cache.c (move_cache_gap): Check for size calculation overflow.
3163 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
3164 overflow. Don't bother calling xmalloc when xrealloc will do.
3166 * search.c (Freplace_match): Check for size calculation overflow.
3167 (Fset_match_data): Don't assume list lengths fit in 'int'.
3169 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3170 for command line length. Do not attempt to address one before the
3171 beginning of an array, as that's not portable.
3173 * term.c (max_frame_lines): Remove; unused.
3174 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3176 (encode_terminal_code, calculate_costs): Check for size
3177 calculation overflow.
3178 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3179 table lengths and related sizes. Don't update size until alloc
3180 done. Redo calculations to avoid overflow.
3181 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3183 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3184 subtracting pointers.
3185 (gobble_line): Check for overflow more carefully. Don't update size
3188 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3189 Don't update size until alloc done.
3190 Redo size calculations to avoid overflow.
3191 Check for size calculation overflow.
3192 (main) [DEBUG]: Fix typo in invoking tparam1.
3194 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3195 Use ptrdiff_t, not int, for sizes.
3196 (store_mode_line_noprop_char): Don't update size until alloc done.
3198 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3199 Use ptrdiff_t, not int, for sizes.
3200 (Finternal_make_lisp_face, cache_face):
3201 Check for size calculation overflow.
3202 (cache_face): Treat size calculation overflows as if they were
3203 memory exhaustion (the usual treatment), rather than aborting.
3205 * xfns.c (x_encode_text, x_set_name_internal)
3206 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3207 sizes, since they can exceed INT_MAX in size. Check for size
3208 calculation overflow.
3210 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3211 (xg_select): Check for size calculation overflow.
3212 Don't update size until alloc done.
3214 * xrdb.c (get_environ_db): Don't assume path length fits in int,
3215 as sprintf is limited to int lengths.
3217 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3218 (X_LONG_MIN): New macros.
3219 Use them to make the following changes clearer.
3220 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3221 This change doesn't affect the value now, but it may help remind
3222 future maintainers not to raise the value too much later.
3223 (SELECTION_QUANTUM): Remove, replacing with ...
3224 (selection_quantum): ... new function, which avoids overflow.
3226 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3227 assumption that selection length fits in 'int'.
3228 (x_reply_selection_request, x_handle_selection_request)
3229 (x_get_window_property, receive_incremental_selection)
3230 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3231 (lisp_data_to_selection_data, clean_local_selection_data):
3232 Use ptrdiff_t, not int, to record length of selection.
3233 (x_reply_selection_request, x_get_window_property)
3234 (receive_incremental_selection, x_property_data_to_lisp):
3235 Redo calculations to avoid overflow.
3236 (x_reply_selection_request): When sending hint, ceiling it at
3237 X_LONG_MAX rather than relying on wraparound overflow to send
3239 (x_get_window_property, receive_incremental_selection)
3240 (lisp_data_to_selection_data, x_property_data_to_lisp):
3241 Check for size-calculation overflow.
3242 (x_get_window_property, receive_incremental_selection)
3243 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3244 Don't store size until memory allocation succeeds.
3245 (x_get_window_property): Plug memory leak on memory exhaustion.
3246 Don't double-block input; malloc is safe here. Don't assume 2**34
3247 - 4 fits in unsigned long. Add an xassert to check
3248 XGetWindowProperty overflow. Be more careful about overflow
3249 calculations, and distinguish size from memory overflow better.
3250 (receive_incremental_selection): When tracing, don't assume
3251 unsigned int is less than INT_MAX.
3252 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3253 harmful) conversions of unsigned short to int.
3254 (lisp_data_to_selection_data): Don't assume that integers
3255 in the range -65535 through -1 fit in an X unsigned short.
3256 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3257 result parameters unless successful. Rely on cons_to_unsigned
3258 to report problems with elements; the old code wasn't right anyway.
3259 (x_check_property_data): Check for int overflow; we cannot use
3260 a wider type due to X limits.
3261 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3263 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
3265 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3266 (x_term_init): Check for size calculation overflow.
3267 (x_color_cells): Don't store size until memory allocation succeeds.
3268 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
3269 Don't assume alloca size is less than MAX_ALLOCA.
3270 (x_term_init): Don't assume length fits in int (sprintf is limited
3273 Use ptrdiff_t for composition IDs.
3274 * character.c (lisp_string_width):
3275 * composite.c (composition_table_size, n_compositions)
3276 (get_composition_id, composition_gstring_from_id):
3277 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3278 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3279 * window.c (Frecenter):
3280 Use ptrdiff_t, not int, for composition IDs.
3281 * composite.c (get_composition_id): Check for integer overflow.
3282 * composite.h: Adjust prototypes to match the above changes.
3284 Use ptrdiff_t for hash table indexes.
3285 * category.c (hash_get_category_set):
3286 * ccl.c (ccl_driver):
3287 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3288 * coding.c (coding_system_charset_list, detect_coding_system):
3289 * coding.h (struct coding_system.id):
3290 * composite.c (get_composition_id, gstring_lookup_cache):
3291 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3292 * image.c (xpm_get_color_table_h):
3293 * lisp.h (hash_lookup, hash_put):
3294 * minibuf.c (Ftest_completion):
3295 Use ptrdiff_t for hash table indexes, not int (which is too
3296 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3297 32-bit --with-wide-int hosts).
3299 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3300 Add a FIXME comment about memory leaks.
3301 (syms_of_charset): Don't assume xmalloc returns.
3303 Don't assume that stated character widths fit in int.
3304 * character.c (Fchar_width, c_string_width, lisp_string_width):
3305 * character.h (CHAR_WIDTH):
3306 * indent.c (MULTIBYTE_BYTES_WIDTH):
3307 Use sanitize_char_width to avoid undefined and/or bad behavior
3308 with outlandish widths.
3309 * character.h (sanitize_tab_width): Rename from sanitize_width,
3310 now that we have two such functions. All uses changed.
3311 (sanitize_char_width): New inline function.
3313 Don't assume that tab-width fits in int.
3314 * character.h (sanitize_width): New inline function.
3315 (SANE_TAB_WIDTH): New macro.
3316 (ASCII_CHAR_WIDTH): Use it.
3317 * indent.c (sane_tab_width): Remove. All uses replaced by
3318 SANE_TAB_WIDTH (current_buffer).
3319 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3321 * fileio.c: Integer overflow issues with file modes.
3322 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3324 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3325 Remove unreachable code.
3326 (read_hex, load_charset_map_from_file): Check for integer overflow.
3328 * xterm.c: Don't go over XClientMessageEvent limit.
3329 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3330 (x_send_scroll_bar_event): Likewise. Check that the size does not
3331 exceed limits imposed by XClientMessageEvent, as well as the usual
3332 ptrdiff_t and size_t limits.
3334 * keyboard.c: Overflow, signedness and related fixes.
3335 (make_lispy_movement): Use same integer type in forward decl
3336 that is used in the definition.
3337 (read_key_sequence, keyremap_step):
3338 Change bufsize argument back to int, undoing my 2011-03-30 change.
3339 We prefer signed types, and int is wide enough here.
3340 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3341 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3342 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3343 length, not size_t. Use ptrdiff_t for index, not int.
3344 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3345 possibility of integer overflow.
3347 Overflow, signedness and related fixes for images.
3349 * dispextern.h (struct it.stack[0].u.image.image_id)
3350 (struct_it.image_id, struct image.id, struct image_cache.size)
3351 (struct image_cache.used, struct image_cache.ref_count):
3352 * gtkutil.c (update_frame_tool_bar):
3353 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3354 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3355 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3356 * nsmenu.m (update_frame_tool_bar):
3357 * xdisp.c (calc_pixel_width_or_height):
3358 * xfns.c (image_cache_refcount):
3359 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3360 on typical 64-bit hosts.
3362 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3363 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3364 Omit unnecessary casts to int.
3365 (parse_image_spec): Check that integers fall into 'int' range
3366 when the callers expect that.
3367 (image_ascent): Redo ascent calculation to avoid int overflow.
3368 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3369 (lookup_image): Remove unnecessary tests.
3370 (xbm_image_p): Locals are now of int, not EMACS_INT,
3371 since parse_image_check makes sure they fit into int.
3372 (png_load, gif_load, svg_load_image):
3373 Prefer int to unsigned where either will do.
3374 (tiff_handler): New function, combining the cores of the
3375 old tiff_error_handler and tiff_warning_handler.
3376 This function is rewritten to use vsnprintf and thereby avoid
3377 stack buffer overflows. It uses only the features of vsnprintf
3378 that are common to both POSIX and native Microsoft.
3379 (tiff_error_handler, tiff_warning_handler): Use it.
3380 (tiff_load, gif_load, imagemagick_load_image):
3381 Don't assume :index value fits in 'int'.
3382 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3383 (imagemagick_load_image): Check that crop parameters fit into
3384 the integer types that MagickCropImage accepts. Don't assume
3385 Vimagemagick_render_type has a nonnegative value. Don't assume
3386 size_t fits in 'long'.
3387 (gs_load): Use printmax_t to print the widest integers possible.
3388 Check for integer overflow when computing image height and width.
3390 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3392 * xdisp.c (redisplay_window): Don't force window start if point
3393 will be invisible in the resulting window. (Bug#9324)
3395 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3397 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3398 the display spec is of the form `(space ...)'.
3399 (handle_display_spec): Return the value returned by
3400 handle_single_display_spec, not just 1 or zero.
3401 (handle_single_display_spec): If the display spec is of the form
3402 `(space ...)', and specifies display in the text area, return 2
3404 (try_cursor_movement): Check for the need to scroll more
3405 accurately, and prefer exact match for point under bidi.
3406 Don't advance `row' beyond the last row of the window.
3408 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3409 into disp_prop; all users changed.
3411 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3412 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3413 for the text covered by the display property.
3415 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3417 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3418 Change return value to nil.
3419 (Frecord_buffer): Delete unused function.
3421 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3423 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3424 buffers, return left-to-right.
3425 (set_cursor_from_row): Consider candidate row a win if its glyph
3426 represents a newline and point is on that newline. Fixes cursor
3427 positioning on the newline at EOL of R2L text within L2R
3428 paragraph, and vice versa.
3429 (try_cursor_movement): Check continued rows, in addition to
3430 continuation rows. Fixes unwarranted scroll when point enters a
3431 continued line of R2L text within an L2R paragraph, or vice versa.
3432 (cursor_row_p): Consider the case of point being equal to
3433 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3434 from the end of a short line to the beginning of a continued line
3435 of R2L text within L2R paragraph.
3436 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3437 composed characters.
3439 * bidi.c (bidi_check_type): Use xassert.
3440 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3443 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3445 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3448 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3450 * nsfont.m (ns_otf_to_script): Fix typo.
3452 2011-08-22 Kenichi Handa <handa@m17n.org>
3454 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3455 extra slot even if the purpose is char-code-property-table.
3457 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3459 * xdisp.c (redisplay_window): When computing centering_position,
3460 account for the height of the header line. (Bug#8874)
3462 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3463 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3464 candidate is selected by the mouse, and that candidate has a
3465 composed character under the mouse.
3467 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3468 coordinates reported by pos-visible-in-window-p for a composed
3469 character in column zero.
3471 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3473 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3475 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3477 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3478 consider it a hit if to_charpos is anywhere in the range of the
3479 composed buffer positions.
3481 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3483 * image.c (gif_load): Don't assume that each subimage has the same
3484 dimensions as the base image. Handle disposal method that is
3485 "undefined" by the gif spec (Bug#9335).
3487 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3489 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3490 (Fcondition_case): Document `debug' symbol in error handler.
3492 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3494 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3495 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3496 from an Org mode buffer to a Speedbar frame.
3498 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3499 a composition, take its buffer position from IT->cmp_it.charpos.
3500 Fixes cursor positioning at the beginning of a line that begins
3501 with a composed character.
3503 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3505 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3506 character bidirectional type, use STRONG_L instead. Fixes crashes
3507 in a buffer produced by `describe-categories'.
3509 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3510 members before the level stack, so they would be saved and
3511 restored when copying iterator state. Fixes incorrect reordering
3512 around TABs covered by display properties.
3514 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3516 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3518 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3520 * eval.c (internal_condition_case, internal_condition_case_1)
3521 (internal_condition_case_2, internal_condition_case_n):
3522 Remove unnecessary aborts (Bug#9081).
3524 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3526 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3527 has no `load' handler, try opening the file locally. (Bug#9311)
3529 2011-08-16 Ken Brown <kbrown@cornell.edu>
3531 * gmalloc.c: Expand comment.
3533 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3535 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3536 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3538 2011-08-16 Ken Brown <kbrown@cornell.edu>
3540 Fix memory allocation problems in Cygwin build (Bug#9273).
3542 * unexcw.c ( __malloc_initialized): Declare external variable.
3543 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3545 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3547 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3549 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3551 [CYGWIN] (special_realloc): New function.
3552 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3553 requests to realloc storage in the static heap.
3555 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3557 * bidi.c (bidi_initialize): Remove unused local.
3559 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3562 * biditype.h: Remove file.
3563 * makefile.w32-in ($(BLD)/bidi.$(O)):
3564 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3566 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3568 * chartab.c: Improve commentary for the uniprop_table API.
3570 * bidi.c (bidi_paragraph_init): Support zero value of
3571 bidi_ignore_explicit_marks_for_paragraph_level.
3572 (bidi_initialize): Use uniprop_table instead of including
3573 biditype.h and bidimirror.h.
3575 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3576 coordinates of the iterator when restoring from ppos_it.
3579 2011-08-14 Kenichi Handa <handa@m17n.org>
3581 * process.c (create_process): Call setup_process_coding_systems
3582 after the pid of the process is set to -1 (Bug#8162).
3584 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3586 * xdisp.c (move_it_in_display_line_to): Don't invoke
3587 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3588 ppos_it. Fixes vertical cursor motion when line beginning is
3589 covered by an image. (Bug#9296)
3591 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3593 * nsterm.h (ns_run_ascript): Declare.
3594 (NSAPP_DATA2_RUNASSCRIPT): Define.
3596 * nsfns.m (as_script, as_result, as_status): New static variables.
3597 (ns_run_ascript): New function.
3598 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3599 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3600 the event loop. Get status from as_status (Bug#7276).
3602 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3603 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3604 the event loop (Bug#7276).
3606 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3608 * gnutls.c (QCgnutls_bootprop_priority)
3609 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3610 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3611 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3612 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3613 (QCgnutls_bootprop_verify_hostname_error)
3614 (QCgnutls_bootprop_callbacks_verify): Rename from
3615 Qgnutls_bootprop_..., all uses changed.
3617 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3620 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3622 * xfaces.c (Qframe_set_background_mode): Now static.
3623 * dispextern.h (Qframe_set_background_mode): Remove decl.
3625 * process.c (Fnetwork_interface_info): Declare local only if needed.
3627 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3629 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3630 (Fnetwork_interface_list): Allocate in increments of bytes instead
3631 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3632 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3634 (struct ifflag_def): notrailers is smart on OSX.
3635 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3636 Get hardware address with getifaddrs if available.
3638 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3640 * xdisp.c (iterate_out_of_display_property): xassert that
3641 IT->position is set to within IT->object's boundaries. Break from
3642 the loop as soon as EOB is reached; avoids infloops in redisplay
3643 when IT->position is set up wrongly due to some bug.
3644 Set IT->current to match the bidi iterator unconditionally.
3645 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3646 entry. Force push_it to save on the stack the current
3647 buffer/string position, to be restored by pop_it. Fix flags in
3648 the iterator structure wrt the object coming from a display
3649 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3650 properties. (Bug#9284)
3652 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3654 * fontset.c (fontset_get_font_group): Add proper type checks.
3657 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3659 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3660 and LC_VERSION_MIN_MACOSX.
3661 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3662 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3664 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3666 * xdisp.c (forward_to_next_line_start): Allow to use the
3667 no-display-properties-and-no-overlays under bidi display.
3668 Set disp_pos in the bidi iterator to avoid searches for display
3669 properties and overlays.
3671 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3673 * editfns.c (Fset_time_zone_rule): Document relationship with the
3676 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3677 the font entity extracted from the cache (Bug#8109).
3679 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3681 * composite.c (autocmp_chars): Don't reset point. That is done by
3682 restore_point_unwind (Bug#5984).
3684 2011-08-07 Juri Linkov <juri@jurta.org>
3686 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3687 to show the arg `TIME' instead of `TIMEVAL'.
3689 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3691 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3692 display property strides EOL and includes a newline, as in
3693 longlines-mode. (Bug#9254)
3694 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3695 word-wrap under bidirectional display. (Bug#9224)
3697 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3698 is non-zero, even if the data buffer is NULL. Fixes a crash in
3699 vertical-motion with longlines-mode. (Bug#9254)
3701 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3703 * bidi.c <bidi_cache_total_alloc>: Now static.
3704 (bidi_initialize): Initialize bidi_cache_total_alloc.
3706 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3709 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3710 amount allocated this far in `bidi_cache_total_alloc'.
3711 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3712 non-zero, only free the data buffer without restoring the cache
3713 contents. All callers changed.
3715 * dispextern.h (bidi_unshelve_cache): Update prototype.
3717 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3718 (move_it_in_display_line, move_it_to)
3719 (move_it_vertically_backward, move_it_by_lines): Replace the call
3720 to xfree to an equivalent call to bidi_unshelve_cache.
3721 (move_it_in_display_line_to): Fix logic of returning
3722 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3724 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3726 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3727 came from a string character with a `cursor' property. (Bug#9229)
3729 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3731 * Makefile.in (LIB_PTHREAD): New variable.
3732 (LIBES): Add LIB_PTHREAD (Bug#9216).
3734 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3735 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3737 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3739 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3741 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3743 * xterm.c (x_find_topmost_parent): New function.
3744 (x_set_frame_alpha): Find topmost parent window with
3745 x_find_topmost_parent and set the property there also (bug#9181).
3746 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3748 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3750 * callproc.c (Fcall_process): Avoid vfork clobbering
3751 the local vars buffer, coding_systems, current_dir.
3753 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3755 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3757 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3759 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3760 so that it is not optimized away.
3762 * xdisp.c (compute_display_string_pos): Remove unused local.
3764 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3766 Fix slow cursor motion and scrolling in large buffers with
3767 selective display, like Org Mode buffers. (Bug#9218)
3769 * dispextern.h (struct bidi_it): New member disp_prop_p.
3771 * xdisp.c: Remove one-slot cache of display string positions.
3772 (compute_display_string_pos): Accept an additional argument
3773 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3774 for a display string or property. If found, set DISP_PROP_P
3777 * bidi.c (bidi_fetch_char): Accept an additional argument
3778 DISP_PROP_P, and pass it to compute_display_string_pos.
3779 Only handle text covered by a display string if DISP_PROP_P is returned
3780 non-zero. All callers of bidi_fetch_char changed.
3782 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3784 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3786 2010-12-03 Don March <don@ohspite.net>
3788 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3789 last character M-[char] is translated to ESC [char] (bug#7541).
3791 2011-08-02 Kenichi Handa <handa@m17n.org>
3793 * lisp.h (uniprop_table): Extern it.
3795 * chartab.c (uniprop_table): Make it non-static.
3797 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3799 * xdisp.c (forward_to_next_line_start): Accept additional argument
3800 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3802 (reseat_at_next_visible_line_start): Use the bidi iterator state
3803 returned by forward_to_next_line_start to restore the state of
3804 it->bidi_it after backing up to previous newline. (Bug#9212)
3806 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3808 * regex.c (re_comp): Protoize.
3809 (re_exec): Fix return type.
3810 (regexec): Fix type of `ret'. (Bug#9203)
3812 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3814 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3815 This is needed if max-image-size is a floating-point number.
3817 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3819 * print.c (print_object): Print empty symbol as ##.
3821 * lread.c (read1): Read ## as empty symbol.
3823 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3825 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3826 setting frame foreground color (Bug#9175).
3827 (x_set_background_color): Likewise.
3829 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3830 contents (Bug#9176).
3831 (EmacsTooltip -init): Remove bezels and add shadows to
3834 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3835 or scroll bar (Bug#8470).
3837 * nsfont.m (nsfont_open): Remove assignment to voffset and
3838 unnecessary vars hshink, expand, hd, full_height, min_height.
3839 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3841 * nsterm.h (nsfont_info): Remove voffset field.
3843 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3845 Implement strike-through and overline on NextStep (Bug#8863).
3847 * nsfont.m (nsfont_open): Use underline position provided by font,
3848 instead of hard-coded value of 2.
3849 (nsfont_draw): Call ns_draw_text_decoration instead.
3851 * nsterm.h: Add declaration for ns_draw_text_decoration.
3853 * nsterm.m (ns_draw_text_decoration): New function for drawing
3854 underline, overline, and strike-through.
3855 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3856 ns_draw_text_decoration. Change treatment of cursor drawing to
3857 accommodate underlining, etc.
3859 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3861 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3864 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3866 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3867 Without this fix, if a signal arrives just after memory fills up,
3868 'malloc' might be invoked reentrantly.
3870 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3871 In other words, assume that every image size is allowed, on non-X
3872 hosts. This assumption is probably wrong, but it lets Emacs compile.
3874 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3876 * regex.c (re_iswctype): Convert return values to boolean.
3878 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3880 * xdisp.c (compute_display_string_pos): Don't use cached display
3881 string position if the buffer had its restriction changed.
3884 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3886 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3888 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3890 Integer signedness and overflow and related fixes. (Bug#9079)
3892 * bidi.c: Integer size and overflow fixes.
3893 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3894 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3895 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3896 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3897 (bidi_find_other_level_edge):
3898 Use ptrdiff_t instead of EMACS_INT where either will do.
3899 This works better on 32-bit hosts configured --with-wide-int.
3900 (bidi_cache_ensure_space): Check for size-calculation overflow.
3901 Use % rather than repeated addition, for better worst-case speed.
3902 Don't set bidi_cache_size until after xrealloc returns, because it
3904 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3905 (bidi_cache_ensure_space): Also check that the bidi cache size
3906 does not exceed that of the largest Lisp string or buffer. See Eli
3907 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3909 * alloc.c (__malloc_size_t): Remove.
3910 All uses replaced by size_t. See Andreas Schwab's note
3911 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3913 * image.c: Improve checking for integer overflow.
3914 (check_image_size): Assume that f is nonnull, since
3915 it is always nonnull in practice. This is one less thing to
3916 worry about when checking for integer overflow later.
3917 (x_check_image_size): New function, which checks for integer
3918 overflow issues inside X.
3919 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3920 This removes the need for a memory_full check.
3921 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3922 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3923 (xbm_read_bitmap_data): Change locals back to 'int', since
3924 their values must fit in 'int'.
3925 (xpm_load_image, png_load, tiff_load):
3926 Invoke x_create_x_image_and_pixmap earlier,
3927 to avoid much needless work if the image is too large.
3928 (tiff_load): Treat overly large images as if
3929 x_create_x_image_and_pixmap failed, not as malloc failures.
3930 (gs_load): Use x_check_image_size.
3932 * gtkutil.c: Omit integer casts.
3933 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3934 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3936 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3938 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3939 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3940 would wrongly return t on a 64-bit host.
3942 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3943 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3944 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3945 and therefore cause GCC to emit a bogus diagnostic in some cases.
3947 * image.c: Integer signedness and overflow and related fixes.
3948 This is not an exhaustive set of fixes, but it's time to
3949 record what I've got.
3950 (lookup_pixel_color, check_image_size): Remove redundant decls.
3951 (check_image_size): Don't assume that arbitrary EMACS_INT values
3952 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3953 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3954 (tiff_load, imagemagick_load_image):
3955 Check for overflow in size calculations.
3956 (x_create_x_image_and_pixmap): Remove unnecessary test for
3957 xmalloc returning NULL; that can't happen.
3958 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3959 (xpm_color_bucket): Use better integer hashing function.
3960 (xpm_cache_color): Don't possibly over-allocate memory.
3961 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3962 (gif_memory_source):
3963 Use ptrdiff_t, not int or size_t, to record sizes.
3964 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3965 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3966 either works, as we prefer signed integers.
3967 (tiff_read_from_memory, tiff_write_from_memory):
3968 Return tsize_t, not size_t, since that's what the TIFF API wants.
3969 (tiff_read_from_memory): Don't fail simply because the read would
3970 go past EOF; instead, return a short read.
3971 (tiff_load): Omit no-longer-needed casts.
3972 (Fimagemagick_types): Don't assume size fits into 'int'.
3974 Improve hashing quality when configured --with-wide-int.
3975 * fns.c (hash_string): New function, taken from sxhash_string.
3976 Do not discard information about ASCII character case; this
3977 discarding is no longer needed.
3978 (sxhash-string): Use it. Change sig to match it. Caller changed.
3979 * lisp.h: Declare it.
3980 * lread.c (hash_string): Remove, since we now use fns.c's version.
3981 The fns.c version returns a wider integer if --with-wide-int is
3982 specified, so this should help the quality of the hashing a bit.
3984 * emacs.c: Integer overflow minor fix.
3985 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3986 Define only if GNU_LINUX.
3987 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3989 * dispnew.c: Integer signedness and overflow fixes.
3990 Remove unnecessary forward decls, that were a maintenance hassle.
3991 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3993 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3994 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3995 (prepare_desired_row, line_draw_cost):
3996 Use int, not unsigned, where either works.
3997 (save_current_matrix, restore_current_matrix):
3998 Use ptrdiff_t, not size_t, where either works.
3999 (init_display): Check for overflow more accurately, and without
4000 relying on undefined behavior.
4002 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
4003 Remove, replacing with the new symbols in lisp.h. All uses changed.
4004 * fileio.c (make_temp_name):
4005 * filelock.c (lock_file_1, lock_file):
4006 * xdisp.c (message_dolog):
4007 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
4008 Use pMd etc. instead.
4009 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
4010 replacing the pWIDE etc. symbols removed from editfns.c.
4012 * keyboard.h (num_input_events): Now uintmax_t.
4013 This is (very slightly) less likely to mess up due to wraparound.
4016 * buffer.c: Integer signedness fixes.
4017 (alloc_buffer_text, enlarge_buffer_text):
4018 Use ptrdiff_t rather than size_t when either will do, as we prefer
4021 * alloc.c: Integer signedness and overflow fixes.
4022 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
4023 (__malloc_size_t): Default to size_t, not to int.
4024 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
4025 (Fgarbage_collect, mark_object_loop_halt, mark_object):
4026 Prefer ptrdiff_t to size_t when either would do, as we prefer
4028 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
4029 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
4030 Now const. Initialize with values that are in range even if char
4032 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
4033 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
4034 These functions do the right thing with sizes > 2**32.
4035 (check_depth): Now ptrdiff_t, not int.
4036 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
4037 Adjust to new way of storing sizes. Check for size overflow bugs
4039 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
4040 slightly wrong anyway, as it missed one instance of
4041 XMALLOC_OVERRUN_CHECK_OVERHEAD.
4042 (refill_memory_reserve): Omit needless cast to size_t.
4043 (mark_object_loop_halt): Mark as externally visible.
4045 * xselect.c: Integer signedness and overflow fixes.
4046 (Fx_register_dnd_atom, x_handle_dnd_message):
4047 Use ptrdiff_t, not size_t, since we prefer signed.
4048 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
4049 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
4050 x_dnd_atoms_size and x_dnd_atoms_length.
4052 * doprnt.c: Prefer signed to unsigned when either works.
4054 * doprnt.c (doprnt):
4056 * xdisp.c (vmessage):
4057 Use ptrdiff_t, not size_t, when using or implementing doprnt,
4058 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
4059 prefer signed arithmetic to avoid comparison confusion.
4060 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
4061 but is a bit tricky.
4063 Assume freestanding C89 headers, string.h, stdlib.h.
4064 * data.c, doprnt.c, floatfns.c, print.c:
4065 Include float.h unconditionally.
4066 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
4067 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
4068 * regex.c: Likewise for stddef.h, string.h.
4069 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
4070 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
4071 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
4072 (STDC_HEADERS): Remove obsolete defines.
4073 * sysdep.c: Include limits.h unconditionally.
4075 Assume support for memcmp, memcpy, memmove, memset.
4076 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
4077 * regex.c (memcmp, memcpy):
4078 Remove; we assume C89 now.
4080 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
4081 (__malloc_safe_bcopy): Remove; no longer needed.
4083 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
4084 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
4085 well either way, and we prefer signed to unsigned.
4087 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
4089 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
4090 closes the connection while we're reading (bug#9182).
4092 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
4094 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
4095 are specified (Bug#9168).
4097 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
4099 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
4100 Found by GCC static checking and --with-wide-int on a 32-bit host.
4102 2011-07-25 Eli Zaretskii <eliz@gnu.org>
4104 * xdisp.c (compute_display_string_pos): Fix logic of caching
4105 previous display string position. Initialize cached_prev_pos to
4106 -1. Fixes slow-down at the beginning of a buffer.
4108 2011-07-24 Eli Zaretskii <eliz@gnu.org>
4110 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
4111 for attrs[LFACE_FONTSET_INDEX].
4113 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
4115 * xml.c (parse_region): Remove unused local
4116 that was recently introduced.
4118 2011-07-23 Eli Zaretskii <eliz@gnu.org>
4120 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
4121 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
4123 * xdisp.c (move_it_in_display_line_to): Record the best matching
4124 position for TO_CHARPOS while scanning the line, and restore it on
4125 exit if none of the characters scanned was an exact match.
4126 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
4127 when exact match is impossible due to invisible text, and the
4128 lines are truncated.
4130 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
4132 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
4135 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4137 Fix a significant slow-down of cursor motion with C-n, C-p,
4138 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
4139 auto-repeat under bidi redisplay in fontified buffers.
4140 * xdisp.c (compute_stop_pos_backwards): New function.
4141 (next_element_from_buffer): Call compute_stop_pos_backwards to
4142 find a suitable prev_stop when we find ourselves before
4144 (reseat): Don't look for prev_stop, as that could mean a very long
4146 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
4147 <cached_disp_overlay_modiff>: Cache for last found display string
4149 (compute_display_string_pos): Return the cached position if asked
4150 about the same buffer in the same area of character positions, and
4151 the buffer wasn't changed since the time the display string
4152 position was cached.
4154 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4156 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
4157 is an integer, which is important for empty lines. (Bug#9149)
4159 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
4161 * frame.c (Fmodify_frame_parameters): In tty case, update the
4162 default face if necessary (Bug#4238).
4164 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
4166 * editfns.c (Fstring_to_char): No need to explain what a character
4167 is in the docstring (Bug#6576).
4169 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4171 * xml.c (parse_region): Make sure we always return a tree.
4173 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4175 * xml.c (parse_region): If a document contains only comments,
4178 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4180 * xml.c (make_dom): Return comments, too.
4182 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4185 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4186 and the surrounding thread.
4187 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4188 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4189 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4191 * s/openbsd.h (BROKEN_SIGIO): Define.
4192 * unexelf.c (unexec) [__OpenBSD__]:
4193 Don't update the .mdebug section of the Alpha COFF symbol table.
4195 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4197 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4200 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4202 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4203 This fixes some race conditions on the permissions of any newly
4206 * alloc.c (valid_pointer_p): Use pipe, not open.
4207 This fixes some permissions issues when debugging.
4209 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4210 If fchown fails to set both uid and gid, try to set just gid,
4211 as that is sometimes allowed. Adjust the file's mode to eliminate
4212 setuid or setgid bits that are inappropriate if fchown fails.
4214 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4216 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4217 to compare Lisp_Objects.
4218 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4219 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4220 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4222 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4224 * lread.c (read_integer): Unread even EOF character.
4225 (read1): Likewise. Properly record start position of symbol.
4227 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4228 symbol character follows.
4230 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4232 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4233 This works around a problem with the previous change to Fcopy_file.
4234 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4235 and without this change, GCC might complain about discarding
4236 fchown's return value.
4238 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
4240 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4242 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4244 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4246 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4248 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4249 it's used from the C level.
4251 * process.c: Use the same condition for POLL_FOR_INPUT in both
4252 keyboard.c and process.c (bug#1858).
4254 2011-07-09 Lawrence Mitchell <wence@gmx.li>
4256 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4257 (Fgnutls_boot): Use it.
4259 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4261 * doc.c (Fsubstitute_command_keys): Revert last change.
4263 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4265 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4266 quotes the next character, and doesn't affect other longer
4267 sequences (bug#8935).
4269 * lread.c (syms_of_lread): Clarify that is isn't only
4270 `eval-buffer' and `eval-defun' that's affected by
4271 `lexical-binding' (bug#8460).
4273 2011-07-15 Eli Zaretskii <eliz@gnu.org>
4275 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
4276 bidi redisplay when a line includes both an image and is truncated.
4278 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4280 Fix minor problems found by static checking.
4281 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4282 (elsz): Now a signed constant, not a size_t var. We prefer signed
4283 types to unsigned, to avoid integer comparison confusion. Without
4284 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4285 "cannot optimize loop, the loop counter may overflow", a symptom
4287 * indent.c (Fvertical_motion): Mark locals as initialized.
4288 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4290 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4292 * search.c (Fre_search_backward): Mention `case-fold-search' in
4293 all the re_search_* functions (bug#8138).
4295 * keyboard.c (Fopen_dribble_file): Document when the file is
4298 2011-07-14 Eli Zaretskii <eliz@gnu.org>
4300 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4303 Support bidi reordering of display and overlay strings.
4304 * xdisp.c (compute_display_string_pos)
4305 (compute_display_string_end): Accept additional argument STRING.
4306 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4307 (reseat_to_string): Initialize bidi_it->string.s and
4308 bidi_it->string.schars.
4309 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
4310 NULL (avoids a crash in bidi_paragraph_init).
4311 Initialize itb.string.lstring.
4312 (init_iterator): Call bidi_init_it only of a valid
4313 buffer position was specified. Initialize paragraph_embedding to
4315 (reseat_to_string): Initialize the bidi iterator.
4316 (display_string): If we need to ignore text properties of
4317 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4318 original value of -1 will not work with bidi.)
4319 (compute_display_string_pos): First arg is now struct
4320 `text_pos *'; all callers changed. Support display properties on
4322 (compute_display_string_end): Support display properties on Lisp
4324 (init_iterator, reseat_1, reseat_to_string): Initialize the
4325 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4326 when iterating on a string not from display properties).
4327 (compute_display_string_pos, compute_display_string_end):
4328 Fix calculation of the object to scan. Fixes an error when using
4330 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4331 base_level_stop; instead, set base_level_stop to BEGV.
4332 Fixes crashes in vertical-motion.
4333 (next_element_from_buffer): Improve commentary for when
4334 the iterator is before prev_stop.
4335 (init_iterator): Initialize bidi_p from the default value of
4336 bidi-display-reordering, not from buffer-local value. Use the
4337 buffer-local value only if initializing for buffer iteration.
4338 (handle_invisible_prop): Support invisible properties on strings
4339 that are being bidi-reordered.
4340 (set_iterator_to_next): Support bidi reordering of C strings and
4342 (next_element_from_string): Support bidi reordering of Lisp
4344 (handle_stop_backwards): Support Lisp strings as well.
4345 (display_string): Support display of R2L glyph rows.
4346 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4347 (init_iterator): Don't initialize it->bidi_p for strings
4349 (reseat_to_string): Initialize it->bidi_p for strings here.
4350 (next_element_from_string, next_element_from_c_string)
4351 (next_element_from_buffer): Add xassert's for correspondence
4352 between IT's object being iterated and it->bidi_it.string
4354 (face_before_or_after_it_pos): Support bidi iteration.
4355 (next_element_from_c_string): Handle the case of the first string
4356 character that is not the first one in the visual order.
4357 (get_visually_first_element): New function, refactored from common
4358 parts of next_element_from_buffer, next_element_from_string, and
4359 next_element_from_c_string.
4360 (tool_bar_lines_needed, redisplay_tool_bar)
4361 (display_menu_bar): Force left-to-right direction. Add a FIXME
4362 comment for making that be controlled by a user option.
4363 (push_it, pop_it): Save and restore the state of the
4364 bidi iterator. Save and restore the bidi_p flag.
4365 (pop_it): Iterate out of display property for string iteration as
4367 (iterate_out_of_display_property): Support iteration over strings.
4368 (handle_single_display_spec): Set up it->bidi_it for iteration
4369 over a display string, and call bidi_init_it.
4370 (handle_single_display_spec, next_overlay_string)
4371 (get_overlay_strings_1, push_display_prop): Set up the bidi
4372 iterator for displaying display or overlay strings.
4373 (forward_to_next_line_start): Don't use the shortcut if
4375 (back_to_previous_visible_line_start): If handle_display_prop
4376 pushed the iterator stack, restore the internal state of the bidi
4377 iterator by calling bidi_pop_it same number of times.
4378 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4379 and we are bidi-iterating, don't decrement the iterator position;
4380 instead, set the first_elt flag in the bidi iterator, to produce
4382 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4383 (push_display_prop): xassert that we are iterating a buffer.
4384 (push_it, pop_it): Save and restore paragraph_embedding member.
4385 (handle_single_display_spec, next_overlay_string)
4386 (get_overlay_strings_1, reseat_1, reseat_to_string)
4387 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4388 correctly. Don't assume unibyte strings are not bidi-reordered.
4389 (compute_display_string_pos)
4390 (compute_display_string_end): Fix handling the case of C string.
4391 (push_it, pop_it): Save and restore from_disp_prop_p.
4392 (handle_single_display_spec, push_display_prop): Set the
4393 from_disp_prop_p flag.
4394 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4395 (pop_it): Call iterate_out_of_display_property only if we are
4396 popping after iteration over a string that came from a display
4397 property. Fix a typo in popping stretch info. Add an assertion
4398 for verifying that the iterator position is in sync with the bidi
4400 (handle_single_display_spec, get_overlay_strings_1)
4401 (push_display_prop): Fix initialization of paragraph direction for
4402 string when that of the parent object is not yet determined.
4403 (reseat_1): Call bidi_init_it to resync the bidi
4404 iterator with IT's position. (Bug#7616)
4405 (find_row_edges): If ROW->start.pos gives position
4406 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4407 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4408 Reset the from_disp_prop_p flag.
4409 (SAVE_IT, RESTORE_IT): New macros.
4410 (pos_visible_p, face_before_or_after_it_pos)
4411 (back_to_previous_visible_line_start)
4412 (move_it_in_display_line_to, move_it_in_display_line)
4413 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4414 (try_scrolling, redisplay_window, display_line): Use them when
4415 saving a temporary copy of the iterator and restoring it back.
4416 (back_to_previous_visible_line_start, reseat_1)
4417 (init_iterator): Empty the bidi cache "stack".
4418 (move_it_in_display_line_to): If iterator ended up at
4419 EOL, but we never saw any buffer positions smaller than
4420 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4421 motion in bidi-reordered lines.
4422 (move_it_in_display_line_to): Record prev_method and prev_pos
4423 immediately before the call to set_iterator_to_next. Fixes cursor
4424 motion in bidi-reordered lines with stretch glyphs and strings
4425 displayed in margins. (Bug#8133) (Bug#8867)
4426 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4428 (pos_visible_p): Support positions in bidi-reordered lines.
4429 Save and restore bidi cache.
4431 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4432 (bidi_paragraph_info): Delete unused struct.
4433 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4434 (bidi_cache_start): New variable.
4435 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4437 (bidi_cache_fetch_state, bidi_cache_search)
4438 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4439 (bidi_cache_find, bidi_peek_at_next_level)
4440 (bidi_level_of_next_char, bidi_find_other_level_edge)
4441 (bidi_move_to_visually_next): Compare cache index with
4442 bidi_cache_start rather than with zero.
4443 (bidi_fetch_char): Accept new argument STRING; all callers
4444 changed. Support iteration over a string. Support strings with
4445 display properties. Support unibyte strings. Fix the type of
4446 `len' according to what STRING_CHAR_AND_LENGTH expects.
4447 (bidi_paragraph_init, bidi_resolve_explicit_1)
4448 (bidi_resolve_explicit, bidi_resolve_weak)
4449 (bidi_level_of_next_char, bidi_move_to_visually_next):
4450 Support iteration over a string.
4451 (bidi_set_sor_type, bidi_resolve_explicit_1)
4452 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4453 can now be zero (for strings); special values 0 and -1 were
4454 changed to -1 and -2, respectively.
4455 (bidi_char_at_pos): New function.
4456 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4457 Call it instead of FETCH_MULTIBYTE_CHAR.
4458 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4459 initialized to valid values.
4460 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4462 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4463 the test for valid cached positions. Fix the logic for looking up
4464 the sentinel state in the cache. GCPRO the Lisp string we are
4466 (bidi_push_it, bidi_pop_it): New functions.
4467 (bidi_initialize): Initialize the bidi cache start stack pointer.
4468 (bidi_cache_ensure_space): New function, refactored from part of
4469 bidi_cache_iterator_state. Don't assume the required size is just
4470 one BIDI_CACHE_CHUNK away.
4471 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4472 (bidi_count_bytes, bidi_char_at_pos): New functions.
4473 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4474 always valid if bidi_cache_idx is valid.
4475 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4476 is valid if it's going to be used.
4477 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4478 (bidi_cache_fetch_state, bidi_cache_search)
4479 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4480 (bidi_cache_iterator_state, bidi_cache_find)
4481 (bidi_find_other_level_edge, bidi_cache_start_stack):
4482 All variables related to cache indices are now EMACS_INT.
4484 * dispextern.h (struct bidi_string_data): New structure.
4485 (struct bidi_it): New member `string'. Make flag members be 1-bit
4486 fields, and put them last in the struct.
4487 (compute_display_string_pos, compute_display_string_end):
4489 (bidi_push_it, bidi_pop_it): Add prototypes.
4490 (struct iterator_stack_entry): New members bidi_p,
4491 paragraph_embedding, and from_disp_prop_p.
4492 (struct it): Member bidi_p is now a bit field 1 bit wide.
4493 (bidi_shelve_cache, bidi_unshelve_cache):
4496 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4497 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4498 and vector-like objects.
4500 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4501 cache around display iteration.
4503 * window.c (Fwindow_end, window_scroll_pixel_based)
4504 (displayed_window_lines, Frecenter): Save and restore the bidi
4505 cache around display iteration.
4507 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4509 * editfns.c (Fdelete_region): Clarify the use of the named
4510 parameters (bug#6788).
4512 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4514 * indent.c (Fvertical_motion): Set and restore w->pointm when
4515 saving and restoring the window's buffer (Bug#9006).
4517 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4519 * editfns.c (Fstring_to_char): Clarify just what is returned
4520 (bug#6576). Text by Eli Zaretskii.
4522 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4524 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4526 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4528 * buffer.c (mmap_find): Fix a typo.
4530 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4532 Fix execution of x selection hooks.
4533 * xselect.c (Qx_lost_selection_functions)
4534 (Qx_sent_selection_functions): New vars.
4535 (syms_of_xselect): DEFSYM them.
4536 (x_handle_selection_request): Pass Qx_sent_selection_functions
4537 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4538 (x_handle_selection_clear,x_clear_frame_selections):
4539 Pass Qx_lost_selection_functions rather than
4540 Vx_lost_selection_functions to Frun_hook_with_args.
4542 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4544 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4545 The old code sometimes used this field without initializing it.
4547 * alloc.c (gc_sweep): Don't read past end of array.
4548 In theory, the old code could also have corrupted Emacs internals,
4549 though it'd be very unlikely.
4551 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4553 * character.c (Fcharacterp): Don't advertise optional ignored
4554 argument. (Bug#4026)
4556 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4558 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4561 * window.c (Fset_window_start): Doc fix (bug#4199).
4562 (Fset_window_hscroll): Ditto.
4564 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4566 Fix minor new problems caught by GCC 4.6.1.
4567 * term.c (init_tty): Remove unused local.
4568 * xsettings.c (store_monospaced_changed): Define this function only
4569 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4572 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4574 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4576 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4578 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4579 are the mini-buffer and the echo area (bug#3320).
4581 * term.c (init_tty): Remove support for supdup, c10 and perq
4582 terminals, which are no longer supported (bug#1482).
4584 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4586 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4588 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4590 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4591 for non-popups (Bug#3642).
4593 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4595 * alloc.c (reset_malloc_hooks): Protoize.
4596 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4597 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4598 * cm.c (losecursor): Likewise.
4599 * data.c (fmod): Likewise.
4600 * dispnew.c (swap_glyphs_in_rows): Likewise.
4601 * emacs.c (memory_warning_signal): Likewise.
4602 * floatfns.c (float_error): Likewise.
4603 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4604 (otf_open, font_otf_capability, generate_otf_features)
4605 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4607 * image.c (pbm_read_file): Likewise.
4608 * indent.c (string_display_width): Likewise.
4609 * intervals.c (check_for_interval, search_for_interval)
4610 (inc_interval_count, count_intervals, root_interval)
4611 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4612 * lread.c (defalias): Likewise.
4613 * ralloc.c (r_alloc_check): Likewise.
4614 * regex.c (set_image_of_range_1, set_image_of_range)
4615 (regex_grow_registers): Likewise.
4616 * sysdep.c (strerror): Likewise.
4617 * termcap.c (valid_filename_p, tprint, main): Likewise.
4618 * tparam.c (main): Likewise.
4619 * unexhp9k800.c (run_time_remap, save_data_space)
4620 (update_file_ptrs, read_header, write_header, calculate_checksum)
4621 (copy_file, copy_rest, display_header): Likewise.
4622 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4624 * xdisp.c (check_it): Likewise.
4625 * xfaces.c (register_color, unregister_color, unregister_colors):
4627 * xfns.c (print_fontset_result): Likewise.
4628 * xrdb.c (member, fatal, main): Likewise.
4630 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4632 Fix minor problems found by static checking (Bug#9031).
4633 * chartab.c (char_table_set_range, map_sub_char_table):
4634 Remove unused locals.
4635 (uniprop_table): Now static.
4636 * composite.c (_work_char): Remove unused static var.
4638 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4640 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4642 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4644 * gtkutil.c (qttip_cb): Remove code without function.
4646 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4648 * w32.c (pthread_sigmask): New stub.
4650 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4652 Use pthread_sigmask, not sigprocmask (Bug#9010).
4653 sigprocmask is portable only for single-threaded applications, and
4654 Emacs can be multi-threaded when it uses GTK.
4655 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4657 * callproc.c (Fcall_process):
4658 * process.c (create_process):
4659 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4660 Use pthread_sigmask, not sigprocmask.
4662 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4664 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4665 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4668 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4670 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4671 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4672 (xg_hide_tooltip): Fix comment.
4674 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4675 in registerServicesMenuSendTypes.
4676 (validRequestorForSendType): Don't check ns_return_types.
4678 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4681 2011-07-08 Jason Rumney <jasonr@gnu.org>
4683 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4684 SH_SHOW for hidden windows (Bug#5482).
4686 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4687 frame struct members of non-existent frames (Bug#6284).
4689 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4691 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4692 variable firstTime not needed on OSX >= 10.6.
4693 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4694 >= 10.5. Use setKnobProportion, setDoubleValue.
4696 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4697 (MAC_OS_X_VERSION_10_5): Define if not defined.
4698 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4699 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4700 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4702 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4703 cString and lossyCString on OSX >= 10.4
4705 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4706 sizeToFit on OSX >= 10.2.
4708 * nsimage.m (allocInitFromFile): Don't use deprecated method
4709 bestRepresentationForDevice on OSX >= 10.6.
4711 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4714 * emacs.c: Declare unexec_init_emacs_zone.
4716 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4718 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4720 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4721 on svcsMenu (Bug#8842).
4723 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4725 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4727 * nsterm.m (QUTF8_STRING): Declare.
4728 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4729 (validRequestorForSendType): Return type is (id).
4730 Change indexOfObjectIdenticalTo to indexOfObject.
4731 Check if we have local selection before returning self (Bug#8842).
4732 (writeSelectionToPasteboard): Put local selection into paste board
4733 if we have a local selection (Bug#8842).
4734 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4736 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4737 (ns_get_local_selection): Declare.
4739 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4741 * keymap.c (describe_map_tree): Don't insert a double newline at
4742 the end of the buffer (bug#1169) and return whether we inserted
4745 * callint.c (Fcall_interactively): Change "reading args" to
4746 "providing args" to try to clarify what it does (bug#1010).
4748 2011-07-07 Kenichi Handa <handa@m17n.org>
4750 * composite.c (composition_compute_stop_pos): Ignore a static
4751 composition starting before CHARPOS (Bug#8915).
4753 * xdisp.c (handle_composition_prop): Likewise.
4755 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4757 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4760 2011-07-07 Kenichi Handa <handa@m17n.org>
4762 * character.h (unicode_category_t): New enum type.
4764 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4765 (Qchar_code_property_table): New variable.
4766 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4767 (UNIPROP_COMPRESSED_FORM_P): New macros.
4768 (char_table_ascii): Uncompress the compressed values.
4769 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4770 Uncompress the compressed values.
4771 (sub_char_table_ref_and_range): Likewise.
4772 (char_table_ref_and_range): Uncompress the compressed values.
4773 (sub_char_table_set): New arg is_uniprop. Callers changed.
4774 Uncompress the compressed values.
4775 (sub_char_table_set_range): Args changed. Callers changed.
4776 (char_table_set_range): Adjuted for the above change.
4777 (map_sub_char_table): Delete args default_val and parent. Add arg
4778 top. Give decoded values to a Lisp function.
4779 (map_char_table): Adjust for the above change. Give decoded
4780 values to a Lisp function. Gcpro more variables.
4781 (uniprop_table_uncompress)
4782 (uniprop_decode_value_run_length): New functions.
4783 (uniprop_decoder, uniprop_decoder_count): New variables.
4784 (uniprop_get_decoder, uniprop_encode_value_character)
4785 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4787 (uniprop_encoder, uniprop_encoder_count): New variables.
4788 (uniprop_get_encoder, uniprop_table)
4789 (Funicode_property_table_internal, Fget_unicode_property_internal)
4790 (Fput_unicode_property_internal): New functions.
4791 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4792 Sunicode_property_table_internal, Sget_unicode_property_internal,
4793 and Sput_unicode_property_internal. Defvar_lisp
4794 char-code-property-alist.
4796 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4797 Vunicode_category_table.
4799 * font.c (font_range): Adjust for the change of
4800 Vunicode_category_table.
4802 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4804 * m/iris4d.h: Remove file, move contents ...
4805 * s/irix6-5.h: ... here.
4807 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4809 Remove unportable assumption about struct layout (Bug#8884).
4810 * alloc.c (mark_buffer):
4811 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4812 (clone_per_buffer_values): Don't assume that
4813 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4814 This isn't true in general, and it's particularly not true
4815 if Emacs is configured with --with-wide-int.
4816 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4817 New macros, used in the buffer.c change.
4819 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4821 * xsettings.c: Use both GConf and GSettings if both are available.
4822 (store_config_changed_event): Add comment.
4823 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4824 (store_tool_bar_style_changed): New functions.
4825 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4826 (struct xsettings): Move font inside HAVE_XFT.
4827 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4828 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4829 Move inside HAVE_XFT.
4830 (something_changed_gsettingsCB): Rename from something_changedCB.
4831 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4833 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4834 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4835 (something_changed_gconfCB): Rename from something_changedCB.
4836 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4837 (parse_settings): Move check for font inside HAVE_XFT.
4838 (read_settings, apply_xft_settings): Add comment.
4839 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4840 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4841 call store_font_name_changed.
4842 (xft_settings_event): Add comment.
4843 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4844 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4845 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4846 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4847 (xsettings_initialize): Call init_gsettings last.
4848 (xsettings_get_system_font, xsettings_get_system_normal_font):
4851 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4853 Random fixes. E.g., (random) never returned negative values.
4854 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4855 subseconds part to the entropy, as that's a bit more random.
4856 Prefer signed to unsigned, since the signedness doesn't matter and
4857 in general we prefer signed. When given a limit, use a
4858 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4859 latter isn't right if USE_2_TAGS_FOR_INTS.
4860 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4861 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4863 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4865 * textprop.c (text_property_stickiness):
4866 Obey Vtext_property_default_nonsticky.
4867 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4868 * w32fns.c (syms_of_w32fns):
4869 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4871 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4873 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4874 This is more efficient than Ffile_directory_p and avoids a minor race.
4876 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4878 * buffer.c (Foverlay_put): Say what the return value is
4881 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4882 is a directory before asking whether to use the file name
4884 (barf_or_query_if_file_exists): Make the "File is a directory"
4885 error be more correct.
4887 * fns.c (Frequire): Remove the mention of the .gz files, since
4888 that's installation-specific, but keep the mention of
4889 `get-load-suffixes'.
4891 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4893 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4894 Report string overflow if the output is too long.
4896 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4898 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4899 (syms_of_gnutls): Remove duplicate DEFSYM for
4900 Qgnutls_bootprop_verify_hostname_error, an error for
4901 Qgnutls_bootprop_verify_error (which is no longer used).
4903 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4904 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4905 Also (re)move comments that are misplaced or no longer relevant.
4907 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4909 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4911 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4913 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4914 and background color parameters if they have been changed.
4916 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4918 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4920 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4922 * xsettings.c (SYSTEM_FONT): Define only when used.
4923 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4925 * keymap.c (access_keymap_1): Now static.
4927 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4929 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4930 leave any prefix arg for the up event (Bug#1586).
4932 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4934 * lread.c (syms_of_lread): Mention single symbols defined by
4935 `defvar' or `defconst' (bug#7154).
4937 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4938 (Frequire): Mention get-load-suffixes.
4940 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4942 * window.h (window): Remove clone_number slot.
4943 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4945 (make_parent_window, make_window, saved_window)
4946 (Fset_window_configuration, save_window_save): Don't deal with
4948 * buffer.c (Qclone_number): Remove declaration.
4949 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4951 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4953 Add multiple inheritance to keymaps.
4954 * keymap.c (Fmake_composed_keymap): New function.
4955 (Fset_keymap_parent): Simplify.
4956 (fix_submap_inheritance): Remove.
4957 (access_keymap_1): New function extracted from access_keymap to handle
4958 embedded parents and handle lists of maps.
4959 (access_keymap): Use it.
4960 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4961 (Fcopy_keymap): Handle embedded parents.
4962 (Fcommand_remapping, define_as_prefix): Simplify.
4963 (Fkey_binding): Simplify.
4964 (syms_of_keymap): Move minibuffer-local-completion-map,
4965 minibuffer-local-filename-completion-map,
4966 minibuffer-local-must-match-map, and
4967 minibuffer-local-filename-must-match-map to Elisp.
4968 (syms_of_keymap): Defsubr make-composed-keymap.
4969 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4970 (parse_menu_item): Trivial simplification.
4972 2011-07-01 Glenn Morris <rgm@gnu.org>
4974 * Makefile.in (SETTINGS_LIBS): Fix typo.
4976 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4978 * coding.c (Fencode_coding_string): Record the last coding system
4979 used, as the function doc string says (bug#8738).
4981 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4983 * xsettings.c (store_monospaced_changed): Take new font as arg and
4984 check for change against current_mono_font.
4985 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4986 (emacs_settings_constructor, emacs_settings_get_property)
4987 (emacs_settings_set_property, emacs_settings_class_init)
4988 (emacs_settings_init, gsettings_obj): Remove.
4989 (something_changedCB): New function for HAVE_GSETTINGS.
4990 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4991 with value as argument.
4992 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4993 g_settings_new (Bug#8967). Do not create gsettings_obj.
4994 Remove calls to g_settings_bind. Connect something_changedCB to
4997 * xgselect.c: Add defined (HAVE_GSETTINGS).
4998 (xgselect_initialize): Ditto.
5000 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
5001 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
5004 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
5006 * eval.c (struct backtrace): Simplify and port the data structure.
5007 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
5008 signed bit field, as this assumption is not portable and it makes
5009 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
5010 "char debug_on_exit : 1" as this is not portable either; instead,
5011 use the portable "unsigned int debug_on_exit : 1". Remove unused
5012 member evalargs. Remove obsolete comments about cc bombing out.
5014 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
5016 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
5017 Let HAVE_GSETTINGS override HAVE_GCONF.
5018 (store_monospaced_changed): New function.
5019 (EMACS_SETTINGS): A new type derived from GObject to handle
5020 GSettings notifications.
5021 (emacs_settings_constructor, emacs_settings_get_property)
5022 (emacs_settings_set_property, emacs_settings_class_init):
5024 (gsettings_client, gsettings_obj): New variables.
5025 (GSETTINGS_SCHEMA): New define.
5026 (something_changedCB): Call store_monospaced_changed.
5027 (init_gsettings): New function.
5028 (xsettings_initialize): Call init_gsettings.
5029 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
5032 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
5035 2011-06-29 Martin Rudalics <rudalics@gmx.at>
5037 * window.c (resize_root_window, grow_mini_window)
5038 (shrink_mini_window): Rename Qresize_root_window to
5039 Qwindow_resize_root_window and Qresize_root_window_vertically to
5040 Qwindow_resize_root_window_vertically.
5042 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
5044 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
5046 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
5048 * makefile.w32-in: Redesign dependencies so they reflect more
5049 clearly which files are directly included by each source file,
5050 and not through other includes.
5052 2011-06-27 Martin Rudalics <rudalics@gmx.at>
5054 * buffer.c (Qclone_number): Declare static and DEFSYM it.
5055 (sort_overlays, overlay_strings): When an overlay's clone number
5056 matches the window's clone number process the overlay even if
5057 the overlay's window property doesn't match the current window.
5059 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
5060 (Fwindow_hchild): Rename to Fwindow_left_child.
5061 (Fwindow_next): Rename to Fwindow_next_sibling.
5062 (Fwindow_prev): Rename to Fwindow_prev_sibling.
5063 (resize_window_check): Rename to window_resize_check.
5064 (resize_window_apply): Rename to window_resize_apply.
5065 (Fresize_window_apply): Rename to Fwindow_resize_apply.
5066 (Fdelete_other_windows_internal, resize_frame_windows)
5067 (Fsplit_window_internal, Fdelete_window_internal)
5068 (grow_mini_window, shrink_mini_window)
5069 (Fresize_mini_window_internal): Fix callers accordingly.
5071 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
5073 * emacsgtkfixed.h: State that this is only used with Gtk+3.
5074 (emacs_fixed_set_min_size): Remove.
5075 (emacs_fixed_new): Take frame as argument.
5077 * emacsgtkfixed.c: State that this is only used with Gtk+3.
5078 (_EmacsFixedPrivate): Remove minwidth/height.
5079 Add struct frame *f.
5080 (emacs_fixed_init): Initialize priv->f.
5081 (get_parent_class, emacs_fixed_set_min_size): Remove.
5082 (emacs_fixed_new): Set priv->f to argument.
5083 (emacs_fixed_get_preferred_width)
5084 (emacs_fixed_get_preferred_height): Use min_width/height from
5085 frames size_hint to set minimum and natural (Bug#8919).
5086 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
5087 and use min_width/height from frames size_hint to set
5088 min_width/height (Bug#8919).
5090 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
5091 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
5094 2011-06-26 Eli Zaretskii <eliz@gnu.org>
5096 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
5097 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
5100 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
5102 * process.c (wait_reading_process_output): Bypass select if
5103 waiting for a cell while ignoring keyboard input, and input is
5104 pending. Suggested by Jan Djärv (Bug#8869).
5106 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
5108 Use gnulib's dup2 module instead of rolling our own.
5109 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
5111 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5113 * dispnew.c (scrolling_window): Before scrolling, turn off a
5114 mouse-highlight in the window being scrolled.
5116 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
5118 Move DEFSYM to lisp.h and use everywhere.
5120 * character.h (DEFSYM): Move declaration...
5121 * lisp.h (DEFSYM): ...here.
5127 * w32select.c: Don't include character.h.
5129 * alloc.c (syms_of_alloc):
5130 * buffer.c (syms_of_buffer):
5131 * bytecode.c (syms_of_bytecode):
5132 * callint.c (syms_of_callint):
5133 * casefiddle.c (syms_of_casefiddle):
5134 * casetab.c (init_casetab_once):
5135 * category.c (init_category_once, syms_of_category):
5136 * ccl.c (syms_of_ccl):
5137 * cmds.c (syms_of_cmds):
5138 * composite.c (syms_of_composite):
5139 * dbusbind.c (syms_of_dbusbind):
5140 * dired.c (syms_of_dired):
5141 * dispnew.c (syms_of_display):
5142 * doc.c (syms_of_doc):
5143 * editfns.c (syms_of_editfns):
5144 * emacs.c (syms_of_emacs):
5145 * eval.c (syms_of_eval):
5146 * fileio.c (syms_of_fileio):
5147 * fns.c (syms_of_fns):
5148 * frame.c (syms_of_frame):
5149 * fringe.c (syms_of_fringe):
5150 * insdel.c (syms_of_insdel):
5151 * keymap.c (syms_of_keymap):
5152 * lread.c (init_obarray, syms_of_lread):
5153 * macros.c (syms_of_macros):
5154 * msdos.c (syms_of_msdos):
5155 * print.c (syms_of_print):
5156 * process.c (syms_of_process):
5157 * search.c (syms_of_search):
5158 * sound.c (syms_of_sound):
5159 * syntax.c (init_syntax_once, syms_of_syntax):
5160 * terminal.c (syms_of_terminal):
5161 * textprop.c (syms_of_textprop):
5162 * undo.c (syms_of_undo):
5163 * w32.c (globals_of_w32):
5164 * window.c (syms_of_window):
5165 * xdisp.c (syms_of_xdisp):
5166 * xfaces.c (syms_of_xfaces):
5167 * xfns.c (syms_of_xfns):
5168 * xmenu.c (syms_of_xmenu):
5169 * xsettings.c (syms_of_xsettings):
5170 * xterm.c (syms_of_xterm): Use DEFSYM.
5172 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5174 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
5176 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5178 Integer and buffer overflow fixes (Bug#8873).
5180 * print.c (printchar, strout): Check for string overflow.
5181 (PRINTPREPARE, printchar, strout):
5182 Don't set size unless allocation succeeds.
5184 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5185 for sizes. Check for string overflow more accurately.
5186 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5188 * macros.c: Integer and buffer overflow fixes.
5189 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5190 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5191 Use ptrdiff_t, not int, for sizes.
5192 Don't increment bufsize until after realloc succeeds.
5193 Check for size-calculation overflow.
5194 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5196 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5198 * lread.c: Integer overflow fixes.
5199 (read_integer): Radix is now EMACS_INT, not int,
5200 to improve quality of diagnostics for out-of-range radices.
5201 Calculate buffer size correctly for out-of-range radices.
5202 (read1): Check for integer overflow in radices, and in
5203 read-circle numbers.
5204 (read_escape): Avoid int overflow.
5205 (Fload, openp, read_buffer_size, read1)
5206 (substitute_object_recurse, read_vector, read_list, map_obarray):
5207 Use ptrdiff_t, not int, for sizes.
5208 (read1): Use EMACS_INT, not int, for sizes.
5209 Check for size overflow.
5211 * image.c (cache_image): Check for size arithmetic overflow.
5213 * lread.c: Integer overflow issues.
5214 (saved_doc_string_size, saved_doc_string_length)
5215 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5216 Now ptrdiff_t, not int.
5217 (read1): Don't assume doc string length fits in int. Check for
5218 out-of-range doc string lengths.
5219 (read_list): Don't assume file position fits in int.
5220 (read_escape): Check for hex character overflow.
5222 2011-06-22 Leo Liu <sdl.web@gmail.com>
5224 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5225 Move to minibuffer.el.
5227 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5229 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
5230 The following patches are for when GLYPH_DEBUG && !XASSERT.
5231 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5232 * dispnew.c (flush_stdout):
5233 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5234 Mark as externally visible.
5235 * dispnew.c (check_window_matrix_pointers): Now static.
5236 * dispnew.c (window_to_frame_vpos):
5237 * xfns.c (unwind_create_frame):
5238 * xterm.c (x_check_font): Remove unused local.
5239 * scroll.c (CHECK_BOUNDS):
5240 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5241 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5242 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5243 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5244 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5246 (debug_method_add): Use va_list and vsprintf rather than relying
5247 on undefined behavior with wrong number of arguments.
5248 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5249 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5250 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5251 since we're not interested in debugging glyphs with old libraries.
5252 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5253 GCC 4.6.0's static checking.
5255 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5257 Integer overflow and signedness fixes (Bug#8873).
5258 A few related buffer overrun fixes, too.
5260 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5262 * dispextern.h (struct face.stipple):
5263 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5264 (x_bitmap_mask, x_allocate_bitmap_record)
5265 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5266 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5267 (x_create_bitmap_from_xpm_data):
5268 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5269 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5271 * xfaces.c (load_pixmap):
5272 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5273 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5274 (.bitmaps_last, struct x_output.icon_bitmap):
5275 Use ptrdiff_t, not int, for bitmap indexes.
5276 (x_allocate_bitmap_record): Check for size overflow.
5277 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5279 Use ptrdiff_t, not int, for overlay counts.
5280 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5281 * editfns.c (overlays_around, get_pos_property):
5282 * textprop.c (get_char_property_and_overlay):
5283 * xdisp.c (next_overlay_change, note_mouse_highlight):
5284 * xfaces.c (face_at_buffer_position):
5285 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5286 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5287 (Fnext_overlay_change, Fprevious_overlay_change)
5288 (mouse_face_overlay_overlaps, Foverlays_in):
5289 Use ptrdiff_t, not int, for sizes.
5290 (overlays_at, overlays_in): Check for size-calculation overflow.
5292 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5294 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5295 (x_session_initialize): Do not assume string length fits in int.
5297 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5298 This is unlikely, but can occur if DPI is outlandish.
5300 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
5301 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5303 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5304 * xrdb.c (magic_file_p, search_magic_path):
5305 Omit last arg SUFFIX; it was always 0. All callers changed.
5306 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5308 * xfont.c (xfont_match): Avoid need for strlen.
5310 * xfns.c: Don't assume strlen fits in int.
5311 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5313 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5314 not unsigned long, as we prefer signed integers. All callers changed.
5315 Detect integer overflow in repeat count.
5316 (message_dolog): Don't assume print length fits in 39 bytes.
5317 (display_mode_element): Don't assume strlen fits in int.
5319 * termcap.c: Don't assume sizes fit in int and never overflow.
5320 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5321 (gobble_line): Check for size-calculation overflow.
5323 * minibuf.c (Fread_buffer):
5324 * lread.c (intern, intern_c_string):
5325 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5326 Don't assume string length fits in int.
5328 * keyboard.c (parse_tool_bar_item):
5329 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5331 * font.c: Don't assume string length fits in int.
5332 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5333 Use ptrdiff_t, not int.
5334 (font_intern_prop): Don't assume string length fits in int.
5335 Don't assume integer property fits in fixnum.
5336 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5338 * filelock.c: Fix some buffer overrun and integer overflow issues.
5339 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5340 Reformulate so as not to need the command string.
5341 Invoke gzip -cd rather than gunzip, as it's more portable.
5342 (lock_info_type, lock_file_1, lock_file):
5343 Don't assume pid_t and time_t fit in unsigned long.
5344 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5345 (current_lock_owner): Prefer signed type for sizes.
5346 Use memcpy, not strncpy, where memcpy is what is really wanted.
5347 Don't assume (via atoi) that time_t and pid_t fit in int.
5348 Check for time_t and/or pid_t out of range, e.g., via a network share.
5349 Don't alloca where an auto var works fine.
5351 * fileio.c: Fix some integer overflow issues.
5352 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5353 Don't assume string length fits in int.
5354 (directory_file_name): Don't assume string length fits in long.
5355 (make_temp_name): Don't assume pid fits in int, or that its print
5356 length is less than 20.
5358 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5360 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5362 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5364 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5365 We prefer signed integers, even for size calculations.
5367 * emacs.c: Don't assume string length fits in 'int'.
5368 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5369 (main): Don't invoke strlen when not needed.
5371 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5372 (XD_DEBUG_MESSAGE): Don't waste a byte.
5374 * callproc.c (getenv_internal_1, getenv_internal)
5376 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5378 * lread.c (invalid_syntax): Omit length argument.
5379 All uses changed. This doesn't fix a bug, but it simplifies the
5380 code away from its former Hollerith-constant appearance, and it's
5381 one less 'int' to worry about when looking at integer-overflow issues.
5382 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5384 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5385 This didn't break anything, but it didn't help either.
5386 It's confusing to put a bogus integer in a place where the actual
5387 value does not matter.
5388 (LIST_END_P): Remove unused macro and its bogus comment.
5389 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5391 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5392 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5394 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5395 We prefer signed types, and the value cannot exceed the EMACS_INT
5396 range anyway (because otherwise the length would not be representable).
5397 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5398 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5399 This avoids a GCC warning when WIDE_EMACS_INT.
5401 * indent.c (sane_tab_width): New function.
5402 (current_column, scan_for_column, Findent_to, position_indentation)
5403 (compute_motion): Use it. This is just for clarity.
5404 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5406 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5408 * lisp.h (lint_assume): New macro.
5409 * composite.c (composition_gstring_put_cache):
5410 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5412 * editfns.c, insdel.c:
5413 Omit unnecessary forward decls, to simplify future changes.
5415 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5417 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5419 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5420 Use much-faster test for byte-length change.
5421 Don't assume string byte-length fits in 'int'.
5422 Check that character arg fits in 'int'.
5423 (mapcar1): Declare byte as byte, for clarity.
5425 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5427 * fns.c (concat): Catch string overflow earlier.
5428 Do not rely on integer wraparound.
5430 * dispextern.h (struct it.overlay_strings_charpos)
5431 (struct it.selective): Now EMACS_INT, not int.
5432 * xdisp.c (forward_to_next_line_start)
5433 (back_to_previous_visible_line_start)
5434 (reseat_at_next_visible_line_start, next_element_from_buffer):
5435 Don't arbitrarily truncate the value of 'selective' to int.
5437 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5439 * composite.c: Don't truncate sizes to 'int'.
5440 (composition_gstring_p, composition_reseat_it)
5441 (composition_adjust_point): Use EMACS_INT, not int.
5442 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5443 not EMACS_UINT, for indexes.
5445 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5447 * buffer.c: Include <verify.h>.
5448 (struct sortvec.priority, struct sortstr.priority):
5449 Now EMACS_INT, not int.
5450 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5451 (struct sortstr.size, record_overlay_string)
5452 (struct sortstrlist.size, struct sortlist.used):
5453 Don't truncate size to int.
5454 (record_overlay_string): Check for size-calculation overflow.
5455 (init_buffer_once): Check at compile-time, not run-time.
5457 2011-06-22 Jim Meyering <meyering@redhat.com>
5459 Don't leak an XBM-image-sized buffer
5460 * image.c (xbm_load): Free the image buffer after using it.
5462 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5465 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5466 that Sun C diagnosed.
5467 * fns.c (secure_hash): Fix pointer signedness issue.
5468 * intervals.c (static_offset_intervals): New function.
5469 (offset_intervals): Use it.
5471 2011-06-21 Leo Liu <sdl.web@gmail.com>
5474 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5477 * fns.c (secure_hash): Rename from crypto_hash_function and change
5478 the first arg to accept symbols.
5479 (Fsecure_hash): New primitive.
5480 (syms_of_fns): New symbols.
5482 2011-06-20 Deniz Dogan <deniz@dogan.se>
5484 * process.c (Fset_process_buffer): Clarify return value in
5487 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5489 * dispnew.c (add_window_display_history): Use BVAR.
5491 * xdisp.c (debug_method_add): Use BVAR.
5492 (check_window_end, dump_glyph_matrix, dump_glyph)
5493 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5495 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5498 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5499 check till after the cache is created in init_frame_faces.
5501 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5503 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5505 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5507 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5508 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5509 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5511 Improve buffer-overflow checking (Bug#8873).
5512 * fileio.c (Finsert_file_contents):
5513 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5514 Remove the old (too-loose) buffer overflow checks.
5515 They weren't needed, since make_gap checks for buffer overflow.
5516 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5517 The old code merely checked for Emacs fixnum overflow, and relied
5518 on undefined (wraparound) behavior. The new code avoids undefined
5519 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5521 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5522 Tune. Don't use wider integers than needed. Don't use alloca.
5523 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5525 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5527 * insdel.c, lisp.h (buffer_overflow): New function.
5528 (insert_from_buffer_1, replace_range, replace_range_2):
5529 * insdel.c (make_gap_larger):
5530 * editfns.c (Finsert_char):
5531 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5533 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5535 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5537 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5539 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5540 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5542 * fileio.c: Don't assume EMACS_INT fits in off_t.
5543 (emacs_lseek): New static function.
5544 (Finsert_file_contents, Fwrite_region): Use it.
5545 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5547 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5549 * fns.c: Don't overflow int when computing a list length.
5550 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5551 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5552 truncation on 64-bit hosts. Check for QUIT every
5553 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5554 faster and is responsive enough.
5555 (Flength): Report an error instead of overflowing an integer.
5556 (Fsafe_length): Return a float if the value is not representable
5557 as a fixnum. This shouldn't happen except in contrived situations.
5558 (Fnthcdr, Fsort): Don't assume list length fits in int.
5559 (Fcopy_sequence): Don't assume vector length fits in int.
5561 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5562 (header_size, word_size): New constants.
5563 (allocate_vectorlike): Don't check size overflow here.
5564 (allocate_vector): Check it here instead, since this is the only
5565 caller of allocate_vectorlike that could cause overflow.
5566 Check that the new vector's length is representable as a fixnum.
5568 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5569 The previous code was bogus. For example, next_almost_prime (32)
5570 returned 39, which is undesirable as it is a multiple of 3; and
5571 next_almost_prime (24) returned 25, which is a multiple of 5 so
5572 why was the code bothering to check for multiples of 7?
5574 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5576 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5578 Variadic C functions now count arguments with ptrdiff_t.
5579 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5580 Back then I didn't know that the Emacs coding style prefers signed int.
5581 Also, in the meantime I found a few more instances where arguments
5582 were being counted with int, which may truncate counts on 64-bit
5583 machines, or EMACS_INT, which may be unnecessarily wide.
5584 * lisp.h (struct Lisp_Subr.function.aMANY)
5585 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5586 Arg counts are now ptrdiff_t, not size_t.
5587 All variadic functions and their callers changed accordingly.
5588 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5589 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5590 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5591 * callint.c (Fcall_interactively): Check arg count for overflow,
5592 to avoid potential buffer overrun. Use signed char, not 'int',
5593 for 'varies' array, so that we needn't bother to check its size
5594 calculation for overflow.
5595 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5596 * eval.c (apply_lambda):
5597 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5598 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5599 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5601 * callint.c (Fcall_interactively): Don't use index var as event count.
5603 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5604 * mem-limits.h (SIZE): Remove; no longer used.
5606 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5608 Remove unnecessary casts.
5609 * xterm.c (x_term_init):
5610 * xfns.c (x_set_border_pixel):
5611 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5612 These aren't needed now that we assume ANSI C.
5614 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5615 It's more likely to cause problems (due to unsigned overflow)
5618 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5620 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5622 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5624 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5626 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5628 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5630 GLYPH_CODE_FACE returns EMACS_INT, not int.
5631 * dispextern.h (merge_faces):
5632 * xfaces.c (merge_faces):
5633 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5634 Don't assume EMACS_INT fits in int.
5636 * character.h (CHAR_VALID_P): Remove unused parameter.
5637 * fontset.c, lisp.h, xdisp.c: All uses changed.
5639 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5641 * fns.c (concat): Minor tuning based on overflow analysis.
5642 This doesn't fix any bugs. Use int to hold character, instead
5643 of constantly refetching from Emacs object. Use XFASTINT, not
5644 XINT, for value known to be a character. Don't bother comparing
5645 a single byte to 0400, as it's always less.
5647 * floatfns.c (Fexpt):
5648 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5650 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5653 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5655 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5656 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5657 incorrectly succeed when S was a string, because 4294967386 was
5658 truncated before it was used.
5660 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5661 Otherwise, an out-of-range integer could cause undefined behavior
5664 * composite.c: Use int, not EMACS_INT, for characters.
5665 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5666 EMACS_INT, for values that are known to be in character range.
5667 This doesn't fix any bugs but is the usual style inside Emacs and
5668 may generate better code on 32-bit machines.
5670 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5671 This is for reasons similar to the recent CHAR_STRING fix.
5672 * charset.c (Fencode_char): Check that character arg is actually
5673 a character. Pass an int to ENCODE_CHAR.
5674 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5675 wider than 'int', as a compile-time check to prevent future regressions
5678 * character.c (char_string): Remove unnecessary casts.
5680 Make sure a 64-bit char is never passed to CHAR_STRING.
5681 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5682 by silently ignoring the top 32 bits, allowing some values
5683 that were far too large to be valid characters.
5684 * character.h: Include <verify.h>.
5685 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5686 arguments are no wider than unsigned, as a compile-time check
5687 to prevent future regressions in this area.
5689 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5690 (Fsubst_char_in_region):
5692 * xdisp.c (decode_mode_spec_coding):
5693 Adjust to CHAR_STRING's new requirement.
5694 * editfns.c (Finsert_char, Fsubst_char_in_region):
5695 * fns.c (concat): Check that character args are actually
5696 characters. Without this test, these functions did the wrong
5697 thing with wildly out-of-range values on 64-bit hosts.
5699 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5700 These casts should not be needed on 32-bit hosts, either.
5701 * keyboard.c (read_char):
5702 * lread.c (Fload): Remove casts to unsigned.
5704 * lisp.h (UNSIGNED_CMP): New macro.
5705 This fixes comparison bugs on 64-bit hosts.
5706 (ASCII_CHAR_P): Use it.
5707 * casefiddle.c (casify_object):
5708 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5709 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5710 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5711 * dispextern.h (FACE_FROM_ID):
5712 * keyboard.c (read_char): Use UNSIGNED_CMP.
5714 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5715 not to EMACS_INT, to avoid GCC warning.
5717 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5719 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5720 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5721 isn't needed on 32-bit machines.
5723 * buffer.c (Fgenerate_new_buffer_name):
5724 Use EMACS_INT for count, not int.
5725 (advance_to_char_boundary): Return EMACS_INT, not int.
5727 * data.c (Qcompiled_function): Now static.
5729 * window.c (window_body_lines): Now static.
5731 * image.c (gif_load): Rename local to avoid shadowing.
5733 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5734 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5735 * alloc.c (make_save_value): Integer argument is now of type
5737 (mark_object): Use ptrdiff_t, not int.
5738 * lisp.h (pD): New macro.
5739 * print.c (print_object): Use it.
5741 * alloc.c: Use EMACS_INT, not int, to count objects.
5742 (total_conses, total_markers, total_symbols, total_vector_size)
5743 (total_free_conses, total_free_markers, total_free_symbols)
5744 (total_free_floats, total_floats, total_free_intervals)
5745 (total_intervals, total_strings, total_free_strings):
5746 Now EMACS_INT, not int. All uses changed.
5747 (Fgarbage_collect): Compute overall total using a double, so that
5748 integer overflow is less likely to be a problem. Check for overflow
5749 when converting back to an integer.
5750 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5751 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5752 These were 'int' variables that could overflow on 64-bit hosts;
5753 they were never used, so remove them instead of repairing them.
5754 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5755 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5756 Previously, this ceilinged at INT_MAX, but that doesn't work on
5758 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5760 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5761 (allocate_vectorlike): Check for ptrdiff_t overflow.
5762 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5763 when a (possibly-narrower) signed value would do just as well.
5764 We prefer using signed arithmetic, to avoid comparison confusion.
5766 * alloc.c: Catch some string size overflows that we were missing.
5767 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5768 for convenience in STRING_BYTES_MAX.
5769 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5770 The definition here is exact; the one in lisp.h was approximate.
5771 (allocate_string_data): Check for string overflow. This catches
5772 some instances we weren't catching before. Also, it catches
5773 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5774 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5775 and ptrdiff_t and EMACS_INT are both 64 bits.
5777 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5778 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5779 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5781 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5783 * alloc.c (Fmake_string): Check for out-of-range init.
5785 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5787 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5789 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5791 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5792 xg_get_default_scrollbar_width.
5794 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5795 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5796 (style_changed_cb): Call update_theme_scrollbar_width and call
5797 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5798 all frames (Bug#8505).
5799 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5800 Call gtk_window_set_resizable if HAVE_GTK3.
5801 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5802 and height if HAVE_GTK3 (Bug#8505).
5803 (scroll_bar_width_for_theme): New variable.
5804 (update_theme_scrollbar_width): New function.
5805 (xg_get_default_scrollbar_width): Move code to
5806 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5807 (xg_initialize): Call update_theme_scrollbar_width.
5809 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5811 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5813 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5815 * frame.c (make_frame): Call other_buffer_safely instead of
5818 * window.c (temp_output_buffer_show): Call display_buffer with
5819 second argument Vtemp_buffer_show_specifiers and reset latter
5820 immediately after the call.
5821 (Vtemp_buffer_show_specifiers): New variable.
5822 (auto_window_vscroll_p, next_screen_context_lines)
5823 (Vscroll_preserve_screen_position): Remove leading asterisks from
5826 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5828 Fix minor problems found by GCC 4.6.0 static checking.
5829 * buffer.c (Qclone_number): Remove for now, as it's unused.
5830 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5831 (record_buffer): Remove unused local.
5832 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5833 (set_frame_buffer_list): Remove; unused.
5834 * frame.h (other_visible_frames): Remove decl.
5835 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5836 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5837 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5839 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5840 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5841 Define only if HAVE_GPM.
5842 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5843 (update_hints_inhibit): Remove; never set. All uses removed.
5844 * widgetprv.h (emacsFrameClassRec): Remove decl.
5845 * window.c (delete_deletable_window): Now returns void, since it
5846 wasn't returning anything.
5847 (compare_window_configurations): Remove unused locals.
5848 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5849 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5850 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5851 the same widths as pointers. This follows up on the 2011-05-06 patch.
5852 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5853 * xterm.h: Likewise.
5854 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5856 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5858 * makefile.w32-in: Update dependencies.
5859 (LISP_H): Add lib/intprops.h.
5861 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5863 * image.c (gif_load): Add animation frame delay to the metadata.
5864 (syms_of_image): Use DEFSYM. New symbol `delay'.
5866 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5868 * window.c (delete_deletable_window): Re-add.
5869 (Fset_window_configuration): Rewrite to handle dead buffers and
5870 consequently deletable windows.
5871 (window_tree, Fwindow_tree): Remove. Supply functionality in
5873 (compare_window_configurations): Simplify code.
5875 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5877 * image.c (imagemagick_load_image): Fix type mismatch.
5878 (Fimagemagick_types): Likewise.
5880 * window.h (replace_buffer_in_windows): Declare.
5882 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5884 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5885 Qclone_number. Remove external declaration of Qdelete_window.
5886 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5888 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5889 Run Qbuffer_list_update_hook if allowed.
5890 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5891 buffer list implementation.
5892 (other_buffer_safely): New function.
5893 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5894 calls to replace_buffer_in_windows and
5895 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5897 (record_buffer): Inhibit quitting and rewrite using quittable
5898 functions. Run Qbuffer_list_update_hook if allowed.
5899 (Frecord_buffer, Funrecord_buffer): New functions.
5900 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5901 Move switch-to-buffer to window.el.
5902 (bury-buffer): Move to window.el.
5903 (Vbuffer_list_update_hook): New variable.
5905 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5908 * window.h (resize_frame_windows): Move up in code.
5909 (Fwindow_frame): Remove EXFUN.
5910 (replace_buffer_in_all_windows): Remove prototype.
5911 (replace_buffer_in_windows_safely): Add prototype.
5913 * window.c: Declare Qdelete_window static again. Move down
5914 declaration of select_count.
5915 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5916 (Fother_window): Move to window.el.
5917 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5918 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5919 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5921 (replace_buffer_in_windows): Implement by calling
5922 Qreplace_buffer_in_windows.
5923 (replace_buffer_in_all_windows): Remove with some functionality
5924 moved into replace_buffer_in_windows_safely.
5925 (replace_buffer_in_windows_safely): New function.
5926 (select_window_norecord, select_frame_norecord): Move in front
5927 of run_window_configuration_change_hook. Remove now obsolete
5929 (Fset_window_buffer): Rewrite doc-string.
5930 Call Qrecord_window_buffer.
5931 (keys_of_window): Move binding for other-window to window.el.
5933 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5935 * dispextern.h (struct image): Replace data member, whose int_val
5936 and ptr_val fields were not used by anything, with a single
5939 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5940 (gif_clear_image, gif_load, imagemagick_load_image)
5941 (gs_clear_image, gs_load): Callers changed.
5943 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5945 * buffer.h: Include <time.h>, for time_t.
5946 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5948 Fix minor problems found by static checking.
5950 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5952 Make identifiers static if they are not used in other modules.
5953 * data.c (Qcompiled_function, Qframe, Qvector):
5954 * image.c (QimageMagick, Qsvg):
5955 * minibuf.c (Qmetadata):
5956 * window.c (resize_window_check, resize_root_window): Now static.
5957 * window.h (resize_window_check, resize_root_window): Remove decls.
5959 * window.c (window_deletion_count, delete_deletable_window):
5961 (window_body_lines): Now static.
5962 (Fdelete_other_windows_internal): Mark vars as initialized.
5963 Make sure 'resize_failed' is initialized.
5964 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5965 (resize_window_apply): Remove unused local.
5966 * window.h (delete_deletable_window): Remove decl.
5968 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5969 (imagemagick_load_image): Fix pointer signedness problem by changing
5970 last arg from unsigned char * to char *. All uses changed.
5971 Also, fix a local for similar reasons.
5972 Remove unused locals. Remove locals to avoid shadowing.
5973 (fn_rsvg_handle_free): Remove; unused.
5974 (svg_load, svg_load_image): Fix pointer signedness problem.
5975 (imagemagick_load_image): Don't use garbage pointer image_wand.
5977 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5979 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5981 * image.c (gif_load): Fix omitted cast error introduced by
5984 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5986 * window.h (resize_proportionally, orig_total_lines)
5987 (orig_top_line): Remove from window structure.
5988 (set_window_height, set_window_width, change_window_heights)
5989 (Fdelete_window): Remove prototypes.
5990 (resize_frame_windows): Remove duplicate declaration.
5992 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5994 * window.h (resize_frame_windows, resize_window_check)
5995 (delete_deletable_window, resize_root_window)
5996 (resize_frame_windows): Declare prototypes.
5998 * window.c (resize_window_apply): Make definition be "static" to
5999 match the prototype.
6001 2011-06-10 Martin Rudalics <rudalics@gmx.at>
6003 * window.c: Remove declarations of Qwindow_size_fixed,
6004 window_min_size_1, window_min_size_2, window_min_size,
6005 size_window, window_fixed_size_p, enlarge_window, delete_window.
6006 Remove static from declaration of Qdelete_window, it's
6007 temporarily needed by Fbury_buffer.
6008 (replace_window): Don't assign orig_top_line and
6010 (Fdelete_window, delete_window): Remove. Window deletion is
6011 handled by window.el.
6012 (window_loop): Remove DELETE_OTHER_WINDOWS case.
6013 Replace Fdelete_window calls with calls to Qdelete_window.
6014 (Fdelete_other_windows): Remove. Deleting other windows is
6015 handled by window.el.
6016 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
6017 handled in window.el.
6018 (window_min_size_2, window_min_size_1, window_min_size): Remove.
6019 Window minimum sizes are handled in window.el.
6020 (shrink_windows, size_window, set_window_height)
6021 (set_window_width, change_window_heights, window_height)
6022 (window_width, CURBEG, CURSIZE, enlarge_window)
6023 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
6024 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
6025 handled in window.el.
6026 (make_dummy_parent): Rename to make_parent_window and give it a
6027 second argument horflag.
6028 (make_window): Don't set resize_proportionally any more.
6029 (Fsplit_window): Remove. Windows are split in window.el.
6030 (save_restore_action, save_restore_orig_size)
6031 (shrink_window_lowest_first, save_restore_orig_size): Remove.
6032 Resize mini windows in window.el.
6033 (grow_mini_window, shrink_mini_window): Implement by calling
6034 Qresize_root_window_vertically, resize_window_check and
6035 resize_window_apply.
6036 (saved_window, Fset_window_configuration, save_window_save):
6037 Do not handle orig_top_line, orig_total_lines, and
6038 resize_proportionally.
6039 (window_min_height, window_min_width): Move to window.el.
6040 (keys_of_window): Move bindings for delete-other-windows,
6041 split-window, delete-window and enlarge-window to window.el.
6043 * buffer.c: Temporarily extern Qdelete_window.
6044 (Fbury_buffer): Temporarily call Qdelete_window instead of
6045 Fdelete_window (Fbury_buffer will move to window.el soon).
6047 * frame.c (set_menu_bar_lines_1): Remove code handling
6048 orig_top_line and orig_total_lines.
6050 * dispnew.c (adjust_frame_glyphs_initially): Don't use
6051 set_window_height but set heights directly.
6052 (change_frame_size_1): Use resize_frame_windows.
6054 * xdisp.c (init_xdisp): Don't use set_window_height but set
6057 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
6058 Use resize_frame_windows instead of change_window_heights and run
6059 run_window_configuration_change_hook.
6061 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
6062 instead of change_window_heights and run
6063 run_window_configuration_change_hook.
6065 2011-06-09 Martin Rudalics <rudalics@gmx.at>
6067 * window.c (replace_window): Rename second argument REPLACEMENT to
6068 NEW. New third argument SETFLAG. Rewrite.
6069 (delete_window, make_dummy_parent): Call replace_window with
6071 (window_list_1): Move down in code.
6072 (run_window_configuration_change_hook): Move set_buffer part
6073 before select_frame_norecord part in order to unwind correctly.
6074 Rename count1 to count.
6075 (recombine_windows, delete_deletable_window, resize_root_window)
6076 (Fdelete_other_windows_internal)
6077 (Frun_window_configuration_change_hook, make_parent_window)
6078 (resize_window_check, resize_window_apply, Fresize_window_apply)
6079 (resize_frame_windows, Fsplit_window_internal)
6080 (Fdelete_window_internal, Fresize_mini_window_internal):
6082 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
6084 2011-06-08 Martin Rudalics <rudalics@gmx.at>
6086 * window.h (window): Add some new members to window structure -
6087 normal_lines, normal_cols, new_total, new_normal, clone_number,
6088 splits, nest, prev_buffers, next_buffers.
6089 (WINDOW_TOTAL_SIZE): Move here from window.c.
6090 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
6092 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
6094 (make_dummy_parent): Set new members of windows structure.
6095 (make_window): Move down in code. Handle new members of window
6097 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
6098 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
6099 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
6100 (Fset_window_prev_buffers, Fwindow_next_buffers)
6101 (Fset_window_next_buffers, Fset_window_clone_number):
6103 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
6104 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
6106 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
6107 Argument WINDOW can be now internal window too.
6108 (Fwindow_use_time): Move up in code.
6109 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
6111 (Fset_window_configuration, saved_window)
6112 (Fcurrent_window_configuration, save_window_save): Handle new
6113 members of window structure.
6114 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
6115 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
6116 (syms_of_window): New Lisp objects Qrecord_window_buffer,
6117 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
6118 Qget_mru_window, Qresize_root_window,
6119 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
6120 Qauto_buffer_name; staticpro them.
6122 2011-06-07 Martin Rudalics <rudalics@gmx.at>
6124 * window.c (Fwindow_total_size, Fwindow_left_column)
6125 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
6126 (Fwindow_list_1): New functions.
6127 (window_box_text_cols): Replace with window_body_cols.
6128 (Fwindow_width, Fscroll_left, Fscroll_right):
6129 Use window_body_cols instead of window_box_text_cols.
6130 (delete_window, Fset_window_configuration):
6131 Call delete_all_subwindows with window as argument.
6132 (delete_all_subwindows): Take a window as argument and not a
6134 (window_loop): Remove handling of GET_LRU_WINDOW and
6136 (Fget_lru_window, Fget_largest_window): Move to window.el.
6138 * window.h: Extern window_body_cols instead of
6139 window_box_text_cols. delete_all_subwindows now takes a
6140 Lisp_Object as argument.
6142 * indent.c (compute_motion, Fcompute_motion):
6143 Use window_body_cols instead of window_box_text_cols.
6145 * frame.c (delete_frame): Call delete_all_subwindows with root
6148 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
6150 * fns.c (Fputhash): Document return value.
6152 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
6154 * image.c (gif_load): Implement gif89a spec "no disposal" method.
6156 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6158 Cons<->int and similar integer overflow fixes (Bug#8794).
6160 Check for overflow when converting integer to cons and back.
6161 * charset.c (Fdefine_charset_internal, Fdecode_char):
6162 Use cons_to_unsigned to catch overflow.
6163 (Fencode_char): Use INTEGER_TO_CONS.
6164 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
6165 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
6166 * data.c (long_to_cons, cons_to_long): Remove.
6167 (cons_to_unsigned, cons_to_signed): New functions.
6168 These signal an error for invalid or out-of-range values.
6169 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6170 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6171 * font.c (Ffont_variation_glyphs):
6172 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6173 * lisp.h: Include <intprops.h>.
6174 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6175 (cons_to_signed, cons_to_unsigned): New decls.
6176 (long_to_cons, cons_to_long): Remove decls.
6177 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6178 (Fprimitive_undo): Use CONS_TO_INTEGER.
6179 * xfns.c (Fx_window_property): Likewise.
6180 * xselect.c: Include <limits.h>.
6181 (x_own_selection, selection_data_to_lisp_data):
6182 Use INTEGER_TO_CONS.
6183 (x_handle_selection_request, x_handle_selection_clear)
6184 (x_get_foreign_selection, Fx_disown_selection_internal)
6185 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6186 (lisp_data_to_selection_data): Use cons_to_unsigned.
6187 (x_fill_property_data): Use cons_to_signed.
6188 Report values out of range.
6190 Check for buffer and string overflow more precisely.
6191 * buffer.h (BUF_BYTES_MAX): New macro.
6192 * lisp.h (STRING_BYTES_MAX): New macro.
6193 * alloc.c (Fmake_string):
6194 * character.c (string_escape_byte8):
6195 * coding.c (coding_alloc_by_realloc):
6196 * doprnt.c (doprnt):
6197 * editfns.c (Fformat):
6199 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6200 since they may not be the same number.
6201 * editfns.c (Finsert_char):
6202 * fileio.c (Finsert_file_contents):
6203 Likewise for BUF_BYTES_MAX.
6205 * image.c: Use ptrdiff_t, not int, for sizes.
6206 (slurp_file): Switch from int to ptrdiff_t.
6208 (slurp_file): Check that file size fits in both size_t (for
6209 malloc) and ptrdiff_t (for sanity and safety).
6211 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6212 if b->modtime has its maximal value.
6214 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6216 Don't assume time_t can fit into int.
6217 * buffer.h (struct buffer.modtime): Now time_t, not int.
6218 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6219 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6221 Minor fixes for signed vs unsigned integers.
6222 * character.h (MAYBE_UNIFY_CHAR):
6223 * charset.c (maybe_unify_char):
6224 * keyboard.c (read_char, reorder_modifiers):
6225 XINT -> XFASTINT, since the integer must be nonnegative.
6226 * ftfont.c (ftfont_spec_pattern):
6227 * keymap.c (access_keymap, silly_event_symbol_error):
6228 XUINT -> XFASTINT, since the integer must be nonnegative.
6229 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6230 since it makes no difference and we prefer signed.
6231 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6232 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6235 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6237 * window.h (Fwindow_frame): Declare.
6239 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6241 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6242 (SPARE_MEMORY): Always define.
6243 (LARGE_REQUEST): Remove.
6244 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6246 2011-06-06 Martin Rudalics <rudalics@gmx.at>
6248 * lisp.h: Move EXFUNS for Fframe_root_window,
6249 Fframe_first_window and Fset_frame_selected_window to window.h.
6251 * window.h: Move EXFUNS for Fframe_root_window,
6252 Fframe_first_window and Fset_frame_selected_window here from
6255 * frame.c (Fwindow_frame, Fframe_first_window)
6256 (Fframe_root_window, Fframe_selected_window)
6257 (Fset_frame_selected_window): Move to window.c.
6258 (Factive_minibuffer_window): Move to minibuf.c.
6259 (Fother_visible_frames_p): New function.
6261 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6263 * window.c (decode_window, decode_any_window): Move up in code.
6264 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6265 (inhibit_frame_unsplittable): Remove unused variable.
6266 (Fwindow_buffer): Move up and rewrite doc-string.
6267 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6268 (Fwindow_prev): New functions.
6269 (Fwindow_frame): Move here from frame.c. Accept any window as
6271 (Fframe_root_window, Fframe_first_window)
6272 (Fframe_selected_window): Move here from frame.c. Accept frame
6273 or arbitrary window as argument. Update doc-strings.
6274 (Fminibuffer_window): Move up in code.
6275 (Fwindow_minibuffer_p): Move up in code and simplify.
6276 (Fset_frame_selected_window): Move here from frame.c.
6278 (Fselected_window, select_window, Fselect_window): Move up in
6279 code. Minor doc-string fixes.
6281 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6283 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6284 Do not assume that spare memory exists; that assumption is valid
6285 only if SYSTEM_MALLOC.
6286 (LARGE_REQUEST): New macro, so that the issue of large requests
6287 is separated from the issue of spare memory.
6289 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6291 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6294 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6296 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6299 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6301 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6303 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6305 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6306 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6308 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
6310 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6312 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
6314 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6315 (x_clipboard_manager_save): Add return value.
6316 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6318 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6319 Obey Vx_select_enable_clipboard_manager. Catch errors in
6320 x_clipboard_manager_save (Bug#8779).
6321 (Vx_select_enable_clipboard_manager): New variable.
6322 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
6324 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
6326 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6328 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6330 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6331 in the current matrix if keep_current_p is non-zero.
6333 2011-06-04 Eli Zaretskii <eliz@gnu.org>
6335 * bidi.c (bidi_level_of_next_char): Fix last change.
6337 2011-06-03 Eli Zaretskii <eliz@gnu.org>
6339 Support bidi reordering of text covered by display properties.
6341 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6342 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6343 (bidi_cache_search, bidi_cache_iterator_state)
6344 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6345 (bidi_level_of_next_char, bidi_move_to_visually_next):
6346 Support character positions inside a run of characters covered by a
6348 (bidi_paragraph_init, bidi_resolve_explicit_1)
6349 (bidi_level_of_next_char): Call bidi_fetch_char and
6350 bidi_fetch_char_advance instead of FETCH_CHAR and
6352 (bidi_init_it): Initialize new members.
6353 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6355 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6356 instead of using explicit *_CHAR codes.
6357 (bidi_resolve_explicit, bidi_resolve_weak):
6358 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6359 bidirectional text is supported only in multibyte buffers.
6360 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6361 it to initialize the frame_window_p member of struct bidi_it.
6362 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6363 (bidi_resolve_explicit, bidi_resolve_weak)
6364 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6365 bidi_it->nchars is non-positive.
6366 (bidi_level_of_next_char): Don't try to lookup the cache for the
6367 next/previous character if nothing is cached there yet, or if we
6368 were just reseat()'ed to a new position.
6370 * xdisp.c (set_cursor_from_row): Set start and stop points
6371 according to the row's direction when priming the loop that looks
6372 for the glyph on which to display cursor.
6373 (single_display_spec_intangible_p): Function deleted.
6374 (display_prop_intangible_p): Reimplement to call
6375 handle_display_spec instead of single_display_spec_intangible_p.
6376 Accept 3 additional arguments needed by handle_display_spec.
6377 This fixes incorrect cursor motion across display property with complex
6378 values: lists, `(when COND...)' forms, etc.
6379 (single_display_spec_string_p): Support property values that are
6380 lists with the argument STRING its top-level element.
6381 (display_prop_string_p): Fix the condition for processing a
6382 property that is a list to be consistent with handle_display_spec.
6383 (handle_display_spec): New function, refactored from the
6384 last portion of handle_display_prop.
6385 (compute_display_string_pos): Accept additional argument
6386 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6387 value of a `display' property is a "replacing spec".
6388 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6389 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6390 the display property, but just return a value indicating whether
6391 the display property will replace the characters it covers.
6392 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6393 frame_window_p members of struct bidi_it.
6394 (compute_display_string_pos, compute_display_string_end):
6396 (push_it): Accept second argument POSITION, where pop_it should
6397 jump to continue iteration.
6398 (reseat_1): Initialize bidi_it.disp_pos.
6400 * keyboard.c (adjust_point_for_property): Adjust the call to
6401 display_prop_intangible_p to its new signature.
6403 * dispextern.h (struct bidi_it): New member frame_window_p.
6404 (bidi_init_it): Update prototypes.
6405 (display_prop_intangible_p): Update prototype.
6406 (compute_display_string_pos, compute_display_string_end):
6408 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6411 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6413 Malloc failure behavior now depends on size of allocation.
6414 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6415 * lisp.h: Change signatures accordingly.
6416 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6417 All callers changed. (Bug#8762)
6419 * gnutls.c: Use Emacs's memory allocators.
6420 Without this change, the gnutls library would invoke malloc etc.
6421 directly, which causes problems on non-SYNC_INPUT hosts, and which
6422 runs afoul of improving memory_full behavior. (Bug#8761)
6423 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6424 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6425 xfree instead of the default malloc, realloc, free.
6426 (Fgnutls_boot): No need to check for memory allocation failure,
6427 since xmalloc does that for us.
6429 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6430 * category.c (hash_get_category_set):
6431 * ccl.c (ccl_driver):
6432 * charset.c (Fdefine_charset_internal):
6433 * charset.h (struct charset.hash_index):
6434 * composite.c (get_composition_id, gstring_lookup_cache)
6435 (composition_gstring_put_cache):
6436 * composite.h (struct composition.hash_index):
6437 * dispextern.h (struct image.hash):
6438 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6439 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6440 (hashfn_equal, hashfn_user_defined, make_hash_table)
6441 (maybe_resize_hash_table, hash_lookup, hash_put)
6442 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6443 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6444 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6445 * image.c (make_image, search_image_cache, lookup_image)
6446 (xpm_put_color_table_h):
6447 * lisp.h (struct Lisp_Hash_Table):
6448 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6449 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6450 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6451 * alloc.c (allocate_vectorlike):
6452 Check for overflow in vector size calculations.
6453 * ccl.c (ccl_driver):
6454 Check for overflow when converting EMACS_INT to int.
6455 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6456 need to be updated by these changes.
6457 * fns.c (make_hash_table, maybe_resize_hash_table):
6458 Check for integer overflow with large hash tables.
6459 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6460 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6461 (SXHASH_REDUCE): New macro.
6462 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6463 Use it instead of discarding useful hash info with large hash values.
6464 (sxhash_float): New function.
6465 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6466 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6467 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6468 Rewrite to use FIXNUM_BITS, as this simplifies things.
6469 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6470 Adjust signatures to match updated version of code.
6471 (consing_since_gc): Now EMACS_INT, since a single hash table can
6472 use more than INT_MAX bytes.
6474 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6476 Make it possible to build with GCC-4.6+ -O2 -flto.
6478 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6480 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6482 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6483 Call minibuffer-inactive-mode.
6485 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6487 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6488 Update dependencies.
6490 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6492 * data.c (init_data): Remove code for UTS, this system is not
6495 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6497 Don't force ./temacs to start in terminal mode.
6499 * frame.c (make_initial_frame): Initialize faces in all cases, not
6500 only when CANNOT_DUMP is defined.
6501 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6503 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6505 * dispnew.c (add_window_display_history): Use const for the string
6506 pointer. Remove declaration, not needed.
6508 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6510 Use 'inline', not 'INLINE'.
6511 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6512 * alloc.c, fontset.c (INLINE): Remove.
6513 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6514 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6515 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6516 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6517 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6519 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6521 Make it possible to run ./temacs.
6523 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6524 syms_of_callproc does the same thing. Remove test for
6525 "initialized", do it in the caller.
6526 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6528 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6530 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6531 (read_minibuf): Use get_minibuffer.
6532 (syms_of_minibuf): Use DEFSYM.
6533 (Qmetadata): New var.
6534 * data.c (Qbuffer): Don't make it static.
6535 (syms_of_data): Use DEFSYM.
6537 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6539 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6540 (CCL_CODE_MIN): New macro.
6542 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6544 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6546 * eval.c (Qdebug): Now static.
6547 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6548 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6549 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6551 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6553 * image.c: Various fixes to ImageMagick code comments.
6554 (Fimagemagick_types): Doc fix.
6556 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6558 Minor fixes prompted by GCC 4.6.0 warnings.
6560 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6562 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6563 (x_clipboard_manager_save_all): Move extern decl to ...
6564 * xterm.h: ... here, so that it can be checked for consistency.
6566 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6568 * xselect.c (x_clipboard_manager_save_frame)
6569 (x_clipboard_manager_save_all): New functions.
6570 (Fx_clipboard_manager_save): Lisp function deleted.
6572 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6573 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6575 * xterm.h: Update prototype.
6577 2011-05-28 William Xu <william.xwl@gmail.com>
6579 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6582 2011-05-28 Jim Meyering <meyering@redhat.com>
6584 Avoid a sign-extension bug in crypto_hash_function.
6585 * fns.c (to_uchar): Define.
6586 (crypto_hash_function): Use it to convert some newly-signed
6587 variables to unsigned, to avoid sign-extension bugs. For example,
6588 without this change, (md5 "truc") would evaluate to
6589 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6590 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6591 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6593 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6595 Integer overflow fixes.
6597 * dbusbind.c: Serial number integer overflow fixes.
6598 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6599 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6600 to hold a serial number that is too large for a fixnum.
6601 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6602 Check for serial numbers out of range. Decode any serial number
6603 that was so large that it became a float. (Bug#8722)
6605 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6606 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6607 Use XFASTINT rather than XUINT when numbers are nonnegative.
6608 (xd_append_arg, Fdbus_method_return_internal):
6609 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6610 arguments, check that Lisp number is nonnegative, rather than
6611 silently wrapping negative numbers around. (Bug#8722)
6612 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6615 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6617 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6619 ccl: Add integer overflow checks.
6620 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6621 (IN_INT_RANGE): New macros.
6622 (ccl_driver): Use them to check for integer overflow when
6623 decoding a CCL program. Many of the new checks are whether XINT (x)
6624 fits in int; it doesn't always, on 64-bit hosts. The new version
6625 doesn't catch all possible integer overflows, but it's an
6626 improvement. (Bug#8719)
6628 * alloc.c (make_event_array): Use XINT, not XUINT.
6629 There's no need for unsigned here.
6631 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6632 This follows up to the 2011-05-06 change that substituted uintptr_t
6633 for EMACS_INT. This case wasn't caught back then.
6635 Rework Fformat to avoid integer overflow issues.
6636 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6637 now (part of C89). Include <verify.h>.
6638 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6639 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6640 (Fformat): Avoid the prepass trying to compute sizes; it was only
6641 approximate and thus did not catch overflow reliably. Instead, walk
6642 through the format just once, formatting and computing sizes as we go,
6643 checking for integer overflow at every step, and allocating a larger
6644 buffer as needed. Keep track separately whether the format is
6645 multibyte. Keep only the most-recently calculated precision, rather
6646 than them all. Record whether each argument has been converted to
6647 string. Use EMACS_INT, not int, for byte and char and arg counts.
6648 Support field widths and precisions larger than INT_MAX. Avoid
6649 sprintf's undefined behavior with conversion specifications such as %#d
6650 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6651 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6652 formatting out-of-range floating point numbers with int
6655 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6657 * data.c: Avoid integer truncation in expressions involving floats.
6658 * data.c: Include <intprops.h>.
6659 (arith_driver): When there's an integer overflow in an expression
6660 involving floating point, convert the integers to floating point
6661 so that the resulting value does not suffer from catastrophic
6662 integer truncation. For example, on a 64-bit host (* 4
6663 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6664 Do not rely on undefined behavior after integer overflow.
6666 merge count_size_as_multibyte, parse_str_to_multibyte
6667 * character.c, character.h (count_size_as_multibyte):
6668 Rename from parse_str_to_multibyte; all uses changed.
6669 Check for integer overflow.
6670 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6671 since it's now a duplicate of the other. This is more of
6672 a character than a buffer op, so better that it's in character.c.
6673 * fns.c, print.c: Adjust to above changes.
6675 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6677 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6679 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6681 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6682 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6683 (x_clipboard_manager_save): Now static.
6684 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6686 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6687 (crypto_hash_function): Now static.
6688 Fix pointer signedness problems. Avoid unnecessary initializations.
6690 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6692 * termhooks.h (Vselection_alist): Make it terminal-local.
6694 * terminal.c (create_terminal): Initialize it.
6696 * xselect.c: Support for clipboard managers.
6697 (Vselection_alist): Move to termhooks.h as terminal-local var.
6698 (LOCAL_SELECTION): New macro.
6699 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6700 (symbol_to_x_atom): Remove gratuitous arg.
6701 (x_handle_selection_request, lisp_data_to_selection_data)
6702 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6703 (x_own_selection, x_get_local_selection, x_convert_selection):
6704 New arg, specifying work frame. Use terminal-local Vselection_alist.
6705 (some_frame_on_display): Delete unused function.
6706 (Fx_own_selection_internal, Fx_get_selection_internal)
6707 (Fx_disown_selection_internal, Fx_selection_owner_p)
6708 (Fx_selection_exists_p): New optional frame arg.
6709 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6710 (x_handle_selection_clear): Don't treat other terminals with the
6711 same keyboard specially. Use the terminal-local Vselection_alist.
6712 (x_clear_frame_selections): Use Frun_hook_with_args.
6714 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6716 * xterm.h: Add support for those atoms.
6718 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6720 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6721 (converted_selections, conversion_fail_tag): New global variables.
6722 (x_selection_request_lisp_error): Free the above.
6723 (x_get_local_selection): Remove unnecessary code.
6724 (x_reply_selection_request): Args changed; handle arbitrary array
6725 of converted selections stored in converted_selections.
6726 Separate the XChangeProperty and SelectionNotify steps.
6727 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6728 (x_convert_selection): New function.
6729 (x_handle_selection_event): Simplify.
6730 (x_get_foreign_selection): Don't ignore incoming requests while
6731 waiting for an answer; this will fail when we implement
6732 SAVE_TARGETS, and seems unnecessary anyway.
6733 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6734 (Vx_sent_selection_functions): Doc fix.
6736 2011-05-26 Leo Liu <sdl.web@gmail.com>
6738 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6740 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6742 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6744 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6745 for fringe update if it has periodic bitmap.
6746 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6747 and fringe_bitmap_periodic_p.
6749 * fringe.c (get_fringe_bitmap_data): New function.
6750 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6751 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6752 row. Mark glyph row for fringe update if periodicity changed.
6754 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6755 for fringe update unless it has periodic bitmap.
6757 2011-05-25 Kenichi Handa <handa@m17n.org>
6759 * xdisp.c (get_next_display_element): Set correct it->face_id for
6760 a static composition.
6762 2011-05-24 Leo Liu <sdl.web@gmail.com>
6765 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6767 * fns.c (crypto_hash_function, Fsha1): New function.
6768 (Fmd5): Use crypto_hash_function.
6769 (syms_of_fns): Add Ssha1.
6771 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6773 * gnutls.c: Remove unused macros.
6774 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6775 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6776 Remove macros that are defined and never used.
6777 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6779 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6781 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6782 (Fx_get_selection_internal): Minor cleanup.
6783 (Fx_own_selection_internal): Rename arguments for consistency with
6786 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6788 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6790 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6792 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6794 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6796 * dispnew.c (scrolling_window): Don't exclude the case that the
6797 last enabled row in the desired matrix touches the bottom boundary.
6799 2011-05-21 Glenn Morris <rgm@gnu.org>
6801 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6802 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6803 and add some more files.
6805 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6807 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6808 report_file_error introduced by the change from 2011-05-07.
6810 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6812 * systime.h (Time): Define only if emacs is defined.
6813 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6814 where the include path doesn't have X11/X.h by default. See
6815 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6817 2011-05-20 Kenichi Handa <handa@m17n.org>
6819 * composite.c (find_automatic_composition): Fix previous change.
6821 2011-05-20 Glenn Morris <rgm@gnu.org>
6823 * lisp.mk: New file, split from Makefile.in.
6824 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6825 (shortlisp): Remove.
6826 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6828 2011-05-19 Glenn Morris <rgm@gnu.org>
6830 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6831 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6832 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6833 (lisp): Set the order to that of loadup.el.
6834 (shortlisp): Make it a copy of $lisp.
6835 (SOME_MACHINE_LISP): Remove.
6836 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6837 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6839 2011-05-18 Kenichi Handa <handa@m17n.org>
6841 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6842 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6843 (find_automatic_composition): Mostly rewrite for efficiency.
6845 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6847 * makefile.w32-in: Update dependencies.
6849 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6851 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6852 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6854 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6856 Fix some integer overflow issues, such as string length overflow.
6858 * insdel.c (count_size_as_multibyte): Check for string overflow.
6860 * character.c (lisp_string_width): Check for string overflow.
6861 Use EMACS_INT, not int, for string indexes and lengths; in
6862 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6863 the resulting string length overflows an EMACS_INT; instead,
6864 report a string overflow if no precision given. When checking for
6865 precision exhaustion, use a check that cannot possibly have
6866 integer overflow. (Bug#8675)
6867 * character.h (lisp_string_width): Adjust to new signature.
6869 * alloc.c (string_overflow): New function.
6870 (Fmake_string): Use it. This doesn't change behavior, but saves
6871 a few bytes and will simplify future changes.
6872 * character.c (string_escape_byte8): Likewise.
6873 * lisp.h (string_overflow): New decl.
6875 Fixups, following up to the user-interface timestamp change.
6876 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6877 for UI timestamps, instead of unsigned long.
6878 * msdos.c (mouse_get_pos): Likewise.
6879 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6880 * w32gui.h (Time): Define by including "systime.h" rather than by
6881 declaring it ourselves. (Bug#8664)
6883 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6884 * image.c (clear_image_cache): Likewise.
6886 * term.c (term_mouse_position): Don't assume time_t wraparound.
6888 Be more systematic about user-interface timestamps.
6889 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6890 and sometimes 'EMACS_UINT', to represent these timestamps.
6891 This change causes it to use 'Time' uniformly, as that's what X uses.
6892 This makes the code easier to follow, and makes it easier to catch
6893 integer overflow bugs such as Bug#8664.
6894 * frame.c (Fmouse_position, Fmouse_pixel_position):
6895 Use Time, not unsigned long, for user-interface timestamps.
6896 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6897 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6898 * keyboard.h (last_event_timestamp): Likewise.
6899 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6900 * menu.h (xmenu_show): Likewise.
6901 * term.c (term_mouse_position): Likewise.
6902 * termhooks.h (struct input_event.timestamp): Likewise.
6903 (struct terminal.mouse_position_hook): Likewise.
6904 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6905 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6906 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6907 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6909 * menu.h, termhooks.h: Include "systime.h", for Time.
6911 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6912 Don't assume that the difference between two unsigned long values
6913 can fit into an integer. At this point, we know button_down_time
6914 <= event->timestamp, so the difference must be nonnegative, so
6915 there's no need to cast the result if double-click-time is
6916 nonnegative, as it should be; check that it's nonnegative, just in
6917 case. This bug is triggered when events are more than 2**31 ms
6918 apart (about 25 days). (Bug#8664)
6920 * xselect.c (last_event_timestamp): Remove duplicate decl.
6921 (x_own_selection): Remove needless cast to unsigned long.
6923 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6924 that always fit in int. Use a sentinel instead of a counter, to
6925 avoid a temp and to allay GCC's concerns about possible int overflow.
6926 * frame.h (struct frame): Use int for menu_bar_items_used
6927 instead of EMACS_INT, since it always fits in int.
6929 * menu.c (grow_menu_items): Check for int overflow.
6931 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6933 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6934 Before, the code was not consistent. These values cannot exceed
6935 2**31 - 1 so there's no need to make them unsigned.
6936 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6937 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6938 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6940 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6942 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6943 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6944 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6945 presumably because the widths might not match.
6947 * window.c (size_window): Avoid needless test at loop start.
6949 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6951 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6953 2011-05-12 Drew Adams <drew.adams@oracle.com>
6955 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6957 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6959 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6960 `width' to `bar_area_x' and `bar_area_width', respectively.
6961 (x_scroll_run): Take account of fringe background extension.
6963 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6964 Rename local vars `left' and `width' to `bar_area_x' and
6965 `bar_area_width', respectively.
6966 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6967 background extension.
6969 2011-05-10 Jim Meyering <meyering@redhat.com>
6971 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6973 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6975 * image.c (Finit_image_library): Return t for built-in image types,
6976 like pbm and xbm. (Bug#8640)
6978 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6980 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6982 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6984 * w32console.c (Fset_screen_color): Doc fix.
6985 (Fget_screen_color): New function.
6986 (syms_of_ntterm): Defsubr it.
6988 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6989 unlink the temporary file if Fcall_process didn't create it in the
6991 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6992 child process will be redirected to a file specified with `:file'.
6993 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6994 cue to call_process_cleanup not to close that handle.
6996 2011-05-07 Ben Key <bkey76@gmail.com>
6998 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6999 one of two shell specific rules, either bootstrap-temacs-CMD or
7000 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
7001 to the previous implementation of the bootstrap-temacs rule.
7002 The bootstrap-temacs-CMD rule is similar to the previous
7003 implementation of the bootstrap-temacs rule except that it
7004 makes use of the ESC_CFLAGS variable instead of the CFLAGS
7007 These changes, along with some changes to nt/configure.bat,
7008 nt/gmake.defs, and nt/nmake.defs, are required to extend my
7009 earlier fix to add support for --cflags and --ldflags options
7010 that include quotes so that it works whether make uses cmd or
7013 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
7015 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
7016 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
7018 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
7019 a string. Handle both cases.
7020 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
7021 (Fdbus_register_method): Use Qinvalid_function.
7023 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
7025 * makefile.w32-in: Update dependencies.
7026 (LISP_H): Add inttypes.h and stdin.h.
7027 (PROCESS_H): Add unistd.h.
7029 2011-05-06 Eli Zaretskii <eliz@gnu.org>
7031 * lread.c: Include limits.h (fixes the MS-Windows build broken by
7032 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
7034 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
7036 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
7038 * term.c (vfatal): Remove stray call to va_end.
7039 It's not needed and the C Standard doesn't allow it here anyway.
7041 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
7042 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
7044 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
7047 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
7049 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7051 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
7053 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
7055 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
7057 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
7058 * charset.c (Fdefine_charset_internal): Don't initialize
7059 charset.code_space[15]. The value was garbage, on hosts with
7060 32-bit int (Bug#8600).
7062 * lread.c (read_integer): Be more consistent with string-to-number.
7063 Use string_to_number to do the actual conversion; this avoids
7064 rounding errors and fixes some other screwups. Without this fix,
7065 for example, #x1fffffffffffffff was misread as -2305843009213693952.
7066 (digit_to_number): Move earlier, for benefit of read_integer.
7067 Return -1 if the digit is out of range for the base, -2 if it is
7068 not a digit in any supported base. (Bug#8602)
7070 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
7072 * dispnew.c (scrolling_window): Return 1 if we scrolled,
7073 to match comment at start of function. This also removes a
7074 GCC warning about overflow in a 32+64-bit port.
7076 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
7078 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
7079 Reported by Stefan Monnier in
7080 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
7081 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7082 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
7084 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
7085 (EMACS_UINTPTR): Likewise, with uintptr_t.
7087 * lisp.h: Prefer 64-bit EMACS_INT if available.
7088 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
7089 on 32-bit hosts that have 64-bit int, so that they can access
7091 However, temporarily disable this change unless the temporary
7092 symbol WIDE_EMACS_INT is defined.
7094 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
7096 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
7097 This removes an assumption that EMACS_INT and long are the same
7098 width as pointers. The assumption is true for Emacs porting targets
7099 now, but we want to make other targets possible.
7100 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
7101 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
7102 In the rest of the code, change types of integers that hold casted
7103 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
7104 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
7105 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
7106 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
7107 No need to cast type when ORing.
7108 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
7109 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
7110 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
7111 assume EMACS_INT is the same width as char *.
7112 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
7113 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
7114 Remove no-longer-needed casts.
7115 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
7116 (xg_tool_bar_help_callback, xg_make_tool_item):
7117 Use EMACS_INTPTR to hold an integer
7118 that will be cast to void *; this can avoid a GCC warning
7119 if EMACS_INT is not the same width as void *.
7120 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
7121 * xdisp.c (display_echo_area_1, resize_mini_window_1):
7122 (current_message_1, set_message_1):
7123 Use a local to convert to proper width without a cast.
7124 * xmenu.c (dialog_selection_callback): Likewise.
7126 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
7127 Also, don't assume VALBITS / RAND_BITS is less than 5,
7128 and don't rely on undefined behavior when shifting a 1 left into
7130 * lisp.h (get_random): Change signature to match.
7132 * lread.c (hash_string): Use size_t, not int, for hash computation.
7133 Normally we prefer signed values; but hashing is special, because
7134 it's better to use unsigned division on hash table sizes so that
7135 the remainder is nonnegative. Also, size_t is the natural width
7136 for hashing into memory. The previous code used 'int', which doesn't
7137 retain enough info to hash well into very large tables.
7138 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
7140 * dbusbind.c: Don't possibly lose pointer info when converting.
7141 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7142 Use XPNTR rather than XHASH, so that the high-order bits of
7143 the pointer aren't lost when converting through void *.
7145 * eval.c (Fautoload): Don't double-shift a pointer.
7147 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
7149 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
7151 * gnutls.c (DEF_GNUTLS_FN):
7152 * image.c (DEF_IMGLIB_FN): Make function pointers static.
7154 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
7156 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
7159 2011-05-05 Eli Zaretskii <eliz@gnu.org>
7161 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
7162 New version that can reserve upto 2GB of heap space.
7164 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
7166 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
7168 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7170 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7171 `gnutls_certificate_set_x509_key_file'.
7173 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
7175 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7176 Update dependencies.
7178 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7180 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7181 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7182 Remove unused parameter `fildes'.
7183 * process.c (read_process_output, send_process): Don't pass it.
7185 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7187 Fix previous change: the library cache is defined in w32.c.
7188 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7189 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7191 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7193 Implement dynamic loading of GnuTLS on Windows.
7195 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7196 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7197 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7200 * gnutls.c (Qgnutls_dll): Define.
7201 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7202 (gnutls_*): Declare function pointers.
7203 (init_gnutls_functions): New function to initialize function pointers.
7204 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7205 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7206 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7207 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7208 (emacs_gnutls_write, emacs_gnutls_read)
7209 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7210 (Fgnutls_available_p): New function.
7211 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7212 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7213 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7215 * image.c: Include w32.h.
7216 (Vimage_type_cache): Delete.
7217 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7218 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7219 (w32_delayed_load): Move to w32.c.
7221 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7223 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7224 (w32_delayed_load): Move from image.c. When loading a library, record
7225 its filename in the :loaded-from property of the library id.
7226 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7227 Initialize and staticpro them.
7228 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7230 * process.c: Include lisp.h before w32.h, not after.
7231 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7232 instead of gnutls_record_check_pending.
7234 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7236 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7238 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7239 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7242 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7244 * xterm.c (x_set_frame_alpha): Do not set property on anything
7245 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7247 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7249 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7251 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7253 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7254 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7255 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7256 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7257 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7258 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7259 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7260 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7261 (Qgnutls_bootprop_callbacks_verify): Make static.
7263 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7265 * callproc.c: Indentation fixup.
7267 * sysdep.c (wait_for_termination_1): Make static.
7268 (wait_for_termination, interruptible_wait_for_termination):
7269 Move after wait_for_termination_1.
7271 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7273 * sysdep.c (interruptible_wait_for_termination): New function
7274 which is like wait_for_termination, but allows keyboard
7277 * callproc.c (Fcall_process): Add (:file "file") as an option for
7279 (Fcall_process_region): Ditto.
7281 2011-04-30 Eli Zaretskii <eliz@gnu.org>
7283 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7284 rather than `XVECTOR (FOO)->size'.
7286 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7287 inttypes.h, as a gnulib replacement is used if it not available in
7290 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7292 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7293 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7294 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7296 * coding.c (coding_alloc_by_realloc): Error out if destination
7297 will grow beyond MOST_POSITIVE_FIXNUM.
7298 (decode_coding_emacs_mule): Abort if there isn't enough place in
7299 charbuf for the composition carryover bytes. Reserve an extra
7300 space for up to 2 characters produced in a loop.
7301 (decode_coding_iso_2022): Abort if there isn't enough place in
7302 charbuf for the composition carryover bytes.
7304 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7306 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7307 aborting when %lld or %lll format is passed.
7308 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7309 %llo or %llx format is passed. (Bug#8545)
7311 * window.c (window_scroll_line_based): Use a marker instead of
7312 simple variables to record original value of point. (Bug#7952)
7314 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7315 produced by %s or %c overflows available buffer space. (Bug#8545)
7317 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7319 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
7320 (SIZE_MAX): Move defn after all includes, as they might #define it.
7322 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7324 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7326 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7328 * keyboard.c (Qdelayed_warnings_hook): Define.
7329 (command_loop_1): Run `delayed-warnings-hook'
7330 if Vdelayed_warnings_list is non-nil.
7331 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7332 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7334 2011-04-28 Eli Zaretskii <eliz@gnu.org>
7336 * doprnt.c (doprnt): Don't return value smaller than the buffer
7337 size if the message was truncated. (Bug#8545).
7339 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7341 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7342 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7344 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7346 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7348 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
7350 * makefile.w32-in: Update dependencies.
7352 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7354 Improve `doprnt' and its usage. (Bug#8545)
7355 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7356 `format_end'. Remove support for %l as a conversion specifier.
7357 Don't use xrealloc. Improve diagnostics when the %l size modifier
7358 is used. Update the commentary.
7360 * eval.c (verror): Simplify calculation of size_t.
7362 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7365 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7367 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7370 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7372 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7373 This makes this file independent of the recent pseudovector change.
7375 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7377 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7379 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7380 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7381 Remove unused local.
7382 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7384 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7385 GCC 4.6.0 optimizes based on type-based alias analysis.
7386 For example, if b is of type struct buffer * and v of type struct
7387 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7388 != &v->size, and therefore "v->size = 1; b->size = 2; return
7389 v->size;" must therefore return 1. This assumption is incorrect
7390 for Emacs, since it type-puns struct Lisp_Vector * with many other
7391 types. To fix this problem, this patch adds a new type struct
7392 vectorlike_header that documents the constraints on layout of vectors
7393 and pseudovectors, and helps optimizing compilers not get fooled
7394 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7395 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7396 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7398 (XSETPVECTYPE): Rewrite in terms of new macro.
7399 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7400 This is a bit clearer, and further avoids the possibility of
7401 undesirable aliasing.
7402 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7403 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7404 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7405 since Lisp_Subr is a special case (no "next" field).
7406 (ASIZE): Now uses header.size rather than size.
7407 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7408 to avoid the hassle of writing XVECTOR (foo)->header.size.
7409 (struct vectorlike_header): New type.
7410 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7411 object, to help avoid aliasing.
7412 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7413 (SUBRP): Likewise, since Lisp_Subr is a special case.
7414 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7415 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7416 (struct Lisp_Hash_Table): Combine first two members into a single
7417 struct vectorlike_header member. All uses of "size" and "next" members
7418 changed to be "header.size" and "header.next".
7419 * buffer.h (struct buffer): Likewise.
7420 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7421 * frame.h (struct frame): Likewise.
7422 * process.h (struct Lisp_Process): Likewise.
7423 * termhooks.h (struct terminal): Likewise.
7424 * window.c (struct save_window_data, struct saved_window): Likewise.
7425 * window.h (struct window): Likewise.
7426 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7427 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7428 * buffer.c (init_buffer_once): Likewise.
7429 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7431 * process.c (Fformat_network_address): Use local var for size,
7434 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7436 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7437 * data.c (atof): Remove decl; no longer used or needed.
7438 (digit_to_number): Move to lread.c.
7439 (Fstring_to_number): Use new string_to_number function, to be
7440 consistent with how the Lisp reader treats infinities and NaNs.
7441 Do not assume that floating-point numbers represent EMACS_INT
7442 without losing information; this is not true on most 64-bit hosts.
7443 Avoid double-rounding errors, by insisting on integers when
7444 parsing non-base-10 numbers, as the documentation specifies.
7445 * lisp.h (string_to_number): New decl, replacing ...
7446 (isfloat_string): Remove.
7447 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7448 (read1): Do not accept +. and -. as integers; this
7449 appears to have been a coding error. Similarly, do not accept
7450 strings like +-1e0 as floating point numbers. Do not report
7451 overflow for integer overflows unless the base is not 10 which
7452 means we have no simple and reliable way to continue.
7453 Break out the floating-point parsing into a new
7454 function string_to_number, so that Fstring_to_number parses
7455 floating point numbers consistently with the Lisp reader.
7456 (digit_to_number): Move here from data.c. Make it static inline.
7457 (E_CHAR, EXP_INT): Remove, replacing with ...
7458 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7459 (string_to_number): New function, replacing isfloat_string.
7460 This function checks for valid syntax and produces the resulting
7461 Lisp float number too. Rework it so that string-to-number
7462 no longer mishandles examples like "1.0e+". Use strtoumax,
7463 so that overflow for non-base-10 numbers is reported only when
7464 there's no portable and simple way to convert to floating point.
7466 * textprop.c (set_text_properties_1): Rewrite for clarity,
7467 and to avoid GCC warning about integer overflow.
7469 * intervals.h (struct interval): Use EMACS_INT for members
7470 where EMACS_UINT might cause problems. See
7471 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7472 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7473 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7475 (offset_intervals): Tell GCC not to worry about length overflow
7476 when negating a negative length.
7478 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7479 (overrun_check_free): Likewise.
7481 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7482 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7485 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7486 (gnutls_make_error): Rename local to avoid shadowing.
7487 (gnutls_emacs_global_deinit): ifdef out; not used.
7488 (Fgnutls_boot): Use const for pointer to readonly storage.
7489 Comment out unused local. Fix pointer signedness problems.
7491 * lread.c (openp): Don't stuff size_t into an 'int'.
7492 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7493 about possible signed overflow.
7495 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7496 (GDK_KEY_g): Don't define if already defined.
7497 (xg_prepare_tooltip): Avoid pointer signedness problem.
7498 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7500 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7501 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7503 * xfns.c (Fx_window_property): Simplify a bit,
7504 to make a bit faster and to avoid GCC 4.6.0 warning.
7505 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7507 * fns.c (internal_equal): Don't assume size_t fits in int.
7509 * alloc.c (compact_small_strings): Tighten assertion a little.
7511 Replace pEd with more-general pI, and fix some printf arg casts.
7512 * lisp.h (pI): New macro, generalizing old pEd macro to other
7513 conversion specifiers. For example, use "...%"pI"d..." rather
7514 than "...%"pEd"...".
7515 (pEd): Remove. All uses replaced with similar uses of pI.
7516 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7517 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7518 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7519 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7520 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7521 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7522 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7524 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7525 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7526 * print.c (safe_debug_print, print_object): Likewise.
7527 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7529 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7530 avoiding the 0 flag, which is not portable.
7531 * process.c (Fmake_network_process): Use pI to avoid cast.
7532 * region-cache.c (pp_cache): Likewise.
7533 * xdisp.c (decode_mode_spec): Likewise.
7534 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7535 behavior on 64-bit hosts with printf arg.
7536 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7537 (x_stop_queuing_selection_requests): Likewise.
7538 (x_get_window_property): Don't truncate byte count to an 'int'
7541 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7542 here, since it parses constructs like leading '-' and spaces,
7543 which are not wanted; and it overflows with large numbers.
7544 Instead, simply match F[0-9]+, which is what is wanted anyway.
7546 * alloc.c: Remove unportable assumptions about struct layout.
7547 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7548 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7549 (allocate_vectorlike, make_pure_vector): Use the new macros,
7550 plus offsetof, to remove unportable assumptions about struct layout.
7551 These assumptions hold on all porting targets that I know of, but
7552 they are not guaranteed, they're easy to remove, and removing them
7553 makes further changes easier.
7555 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7556 This doesn't fix a bug but makes the code clearer.
7557 (string_overrun_cookie): Now const. Use initializers that
7558 don't formally overflow signed char, to avoid warnings.
7559 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7560 can cause Emacs to crash when string overrun checking is enabled.
7561 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7562 multiple of sizeof (EMACS_INT); it need not be, if
7563 alignof(EMACS_INT) < sizeof (EMACS_INT).
7564 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7566 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7568 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7570 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7572 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7573 supposed to be handshaking. (Bug#8556)
7574 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7576 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7578 * lisp.h (Qdebug): List symbol.
7579 * eval.c (Qdebug): Restore global linkage.
7580 * keyboard.c (debug-on-event): New variable.
7581 (handle_user_signal): Break into debugger when debug-on-event
7582 matches the current signal symbol.
7584 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7586 * alloc.c (check_sblock, check_string_bytes)
7587 (check_string_free_list): Convert to standard C.
7589 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7591 * w32.c (emacs_gnutls_push): Fix typo.
7593 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7595 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7596 "cast to pointer from integer of different size".
7598 Improve doprnt and its use in verror. (Bug#8545)
7599 * doprnt.c (doprnt): Document the set of format control sequences
7600 supported by the function. Use SAFE_ALLOCA instead of always
7603 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7604 is one byte too soon. Don't use xrealloc; instead xfree and
7607 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7609 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7612 * gnutls.c: Renamed global_initialized to
7613 gnutls_global_initialized. Added internals for the
7614 :verify-hostname-error, :verify-error, and :verify-flags
7615 parameters of `gnutls-boot' and documented those parameters in the
7616 docstring. Start callback support.
7617 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7618 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7619 on error. Return error code.
7620 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7621 (emacs_gnutls_read): Likewise.
7622 (Fgnutls_boot): Return handshake error code.
7623 (emacs_gnutls_handle_error): New function.
7624 (wsaerror_to_errno): Likewise.
7626 * w32.h (emacs_gnutls_pull): Add prototype.
7627 (emacs_gnutls_push): Likewise.
7629 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7630 (emacs_gnutls_push): Likewise.
7632 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7634 * process.c (wait_reading_process_output): Check if GnuTLS
7635 buffered some data internally if no FDs are set for TLS
7638 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7639 (LIBS): Link to USER_LIBS.
7640 ($(BLD)/gnutls.$(0)): New target.
7642 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7644 * xdisp.c (handle_single_display_spec): Rename the
7645 display_replaced_before_p argument into display_replaced_p, to
7646 make it consistent with the commentary. Fix typos in the
7649 * textprop.c (syms_of_textprop): Remove dead code.
7650 (copy_text_properties): Delete obsolete commentary about an
7651 interface that was deleted long ago. Fix typos in the description
7654 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7655 to changes in oldXMenu/XMenu.h from 2011-04-16.
7656 <menu_help_message, prev_menu_help_message>: Constify.
7657 (IT_menu_make_room): menu->help_text is now `const char **';
7660 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7661 to changes in oldXMenu/XMenu.h from 2011-04-16.
7662 (struct XMenu): Declare `help_text' `const char **'.
7664 * xfaces.c <Qunspecified>: Make extern again.
7666 * syntax.c: Include sys/types.h before including regex.h, as
7669 * doc.c (get_doc_string): Improve the format passed to `error'.
7671 * doprnt.c (doprnt): Improve commentary.
7673 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7675 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7678 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7679 changes in globals.h immediately force recompilation.
7680 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7681 $(CURDIR)/s/ms-w32.h.
7682 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7684 * character.c (Fchar_direction): Function deleted.
7685 (syms_of_character): Don't defsubr it.
7686 <char-direction-table>: Deleted.
7688 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7690 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7691 * doprnt.c: Include limits.h.
7692 (SIZE_MAX): New macro.
7693 (doprnt): Return a size_t value. 2nd arg is now size_t.
7694 Many local variables are now size_t instead of int or unsigned.
7695 Improve overflow protection. Support `l' modifier for integer
7696 conversions. Support %l conversion. Don't assume an EMACS_INT
7697 argument for integer conversions and for %c.
7699 * lisp.h (doprnt): Restore prototype.
7701 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7704 * Makefile.in (base_obj): Add back doprnt.o.
7706 * deps.mk (doprnt.o): Add back prerequisites.
7707 (callint.o): Depend on character.h.
7709 * eval.c (internal_lisp_condition_case): Include the handler
7710 representation in the error message.
7711 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7712 when breaking from the loop.
7714 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7716 * callint.c (Fcall_interactively): When displaying error message
7717 about invalid control letter, pass the character's codepoint, not
7718 a pointer to its multibyte form. Improve display of the character
7719 in octal and display also its hex code.
7721 * character.c (char_string): Use %x to display the (unsigned)
7722 codepoint of an invalid character, to avoid displaying a bogus
7725 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7726 `error', not SYMBOL_NAME itself.
7728 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7729 character arguments to `error'.
7731 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7732 to `error' in error message about FINAL_CHAR argument. Make sure
7733 FINAL_CHAR is a character, and use %c when it is passed as
7734 argument to `error'.
7736 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7738 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7740 * w32.c: Include <time.h>.
7741 (sys_localtime): New function.
7743 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7745 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7747 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7749 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7751 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7754 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7756 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7757 gl_state.e_property when gl_state.object is Qt.
7759 * insdel.c (make_gap_larger): Remove limitation of buffer size
7762 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7764 * xdisp.c (lookup_glyphless_char_display)
7765 (produce_glyphless_glyph): Handle cons cell entry in
7766 glyphless-char-display.
7767 (Vglyphless_char_display): Document it.
7769 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7770 glyphless-char-display.
7772 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7774 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7776 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7778 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7779 definition for no-X builds.
7781 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7783 Static checks with GCC 4.6.0 and non-default toolkits.
7785 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7787 * process.c (keyboard_bit_set): Define only if SIGIO.
7788 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7789 (send_process): Repair possible setjmp clobbering.
7791 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7793 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7795 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7797 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7798 Define only if needed.
7800 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7801 by pacifying GCC about it. Maybe it's time to retire it?
7802 * xfaces.c (USG, __TIMEVAL__): Likewise.
7804 * dispextern.h (struct redisplay_interface): Rename param
7806 * termhooks.h (struct terminal): Likewise.
7807 * xterm.c (xembed_send_message): Likewise.
7809 * insdel.c (make_gap_smaller): Define only if
7810 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7812 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7815 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7816 so that we aren't warned about unused symbols.
7818 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7820 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7822 * xfns.c (x_real_positions): Mark locals as initialized.
7824 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7826 * xterm.c: Fix problems found by static analysis with other toolkits.
7827 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7828 (x_dispatch_event): Declare static if USE_GTK, and
7829 define if USE_GTK || USE_X_TOOLKIT.
7830 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7831 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7832 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7833 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7835 * xmenu.c (menu_help_callback): Pointer type fixes.
7836 Use const pointers when pointing at readonly data. Avoid pointer
7838 (FALSE): Remove unused macro.
7839 (update_frame_menubar): Remove unused decl.
7841 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7843 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7844 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7845 (single_menu_item): Rename local to avoid shadowing.
7847 * keyboard.c (make_lispy_event): Remove unused local var.
7849 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7850 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7852 * bitmaps: Change bitmaps from unsigned char back to the X11
7853 compatible char. Avoid the old compiler warnings about
7854 out-of-range initializers by using, for example, '\xab' rather
7857 * xgselect.c (xgselect_initialize): Check vs interface
7858 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7860 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7862 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7863 to read-only memory.
7865 * fns.c (vector): Remove; this old hack is no longer needed.
7867 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7869 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7871 * xrdb.c (x_load_resources): Omit unused local.
7873 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7874 (x_window): Rename locals to avoid shadowing.
7875 (USG): Use the kludged USG macro, to pacify gcc.
7877 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7878 (x_term_init): Remove local to avoid shadowing.
7880 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7882 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7883 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7885 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7887 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7889 Fix regex.c, syntax.c and friends for buffers > 2GB.
7890 * syntax.h (struct gl_state_s): Declare character position members
7893 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7895 * textprop.c (verify_interval_modification, interval_of):
7896 Declare arguments EMACS_INT.
7898 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7901 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7903 * indent.c (Fvertical_motion): Local variable it_start is now
7906 * regex.c (re_match, re_match_2, re_match_2_internal)
7907 (bcmp_translate, regcomp, regexec, print_double_string)
7908 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7909 (re_compile_pattern, re_exec): Declare arguments and local
7910 variables `size_t' and `ssize_t' and return values `regoff_t', as
7912 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7913 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7914 <compile_stack_type>: `size' and `avail' are now `size_t'.
7916 * regex.h <regoff_t>: Use ssize_t, not int.
7917 (re_search, re_search_2, re_match, re_match_2): Arguments that
7918 specify buffer/string position and length are now ssize_t and
7919 size_t. Return type is regoff_t.
7921 2011-04-16 Ben Key <bkey76@gmail.com>
7923 * nsfont.m: Fixed bugs in ns_get_family and
7924 ns_descriptor_to_entity that were caused by using free to
7925 deallocate memory blocks that were allocated by xmalloc (via
7926 xstrdup). This caused Emacs to crash when compiled with
7927 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7928 --enable-checking=xmallocoverrun). xfree is now used to
7929 deallocate these memory blocks.
7931 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7933 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7935 emacs_write: Accept and return EMACS_INT for sizes.
7936 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7938 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7939 Accept and return EMACS_INT.
7940 (emacs_gnutls_write): Return the number of bytes written on
7942 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7943 (emacs_read, emacs_write): Remove check for negative size, as the
7944 Emacs source code has been audited now.
7945 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7946 (emacs_read, emacs_write): Use it.
7947 * process.c (send_process): Adjust to the new signatures of
7948 emacs_write and emacs_gnutls_write. Do not attempt to store
7949 a byte offset into an 'int'; it might overflow.
7950 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7952 * sound.c: Don't assume sizes fit in 'int'.
7953 (struct sound_device.period_size, alsa_period_size):
7954 Return EMACS_INT, not int.
7955 (struct sound_device.write, vox_write, alsa_write):
7956 Accept EMACS_INT, not int.
7957 (wav_play, au_play): Use EMACS_INT to store sizes and to
7958 record read return values.
7960 2011-04-15 Ben Key <bkey76@gmail.com>
7962 * keyboard.c (Qundefined): Don't declare static since it is used
7964 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7965 static since they are used in nsfont.m.
7967 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7969 * process.c (Qprocessp): Don't declare static.
7970 * lisp.h (Qprocessp): Declare again.
7972 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7974 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7976 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7978 Improve C-level modularity by making more things 'static'.
7980 Don't publish debugger-only interfaces to other modules.
7981 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7982 (verify_bytepos, count_markers): Move decls to the only modules
7984 * region-cache.h (pp_cache): Likewise.
7985 * window.h (check_all_windows): Likewise.
7986 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7988 * sysdep.c (croak): Now static, if
7989 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7990 * syssignal.h (croak): Declare only if not static.
7992 * alloc.c (refill_memory_reserve): Now static if
7993 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7994 * lisp.h (refill_memory_reserve): Declare only if not static.
7996 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7997 Define only if USE_LUCID.
7999 * xrdb.c (x_customization_string, x_rm_string): Now static.
8001 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
8002 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
8004 * xdisp.c (draw_row_with_mouse_face): Now static.
8005 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
8007 * window.h (check_all_windows): Mark externally visible.
8009 * window.c (window_deletion_count): Now static.
8011 * undo.c: Make symbols static if they're not exported.
8012 (last_undo_buffer, last_boundary_position, pending_boundary):
8015 * textprop.c (interval_insert_behind_hooks): Now static.
8016 (interval_insert_in_front_hooks): Likewise.
8018 * term.c: Make symbols static if they're not exported.
8019 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
8020 (max_frame_lines, tty_set_terminal_modes):
8021 (tty_reset_terminal_modes, tty_turn_off_highlight):
8022 (get_tty_terminal): Now static.
8023 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
8024 * termhooks.h (term_mouse_moveto): Do not declare if
8026 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
8027 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
8029 * sysdep.c: Make symbols static if they're not exported.
8030 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
8032 (sigprocmask_set, full_mask): Remove; unused.
8033 (wait_debugging): Mark as visible.
8034 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
8035 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
8037 * syntax.c (syntax_temp): Define only if !__GNUC__.
8039 * sound.c (current_sound_device, current_sound): Now static.
8041 * search.c (searchbufs, searchbuf_head): Now static.
8043 * scroll.c (scroll_cost): Remove; unused.
8044 * dispextern.h (scroll_cost): Remove decl.
8046 * region-cache.h (pp_cache): Mark as externally visible.
8048 * process.c: Make symbols static if they're not exported.
8049 (process_tick, update_tick, create_process, chan_process):
8050 (Vprocess_alist, proc_buffered_char, datagram_access):
8051 (fd_callback_data, send_process_frame, process_sent_to): Now static.
8052 (deactivate_process): Mark defn as static, as well as decl.
8053 * lisp.h (create_process): Remove decl.
8054 * process.h (chan_process, Vprocess_alist): Remove decls.
8056 * print.c: Make symbols static if they're not exported.
8057 (print_depth, new_backquote_output, being_printed, print_buffer):
8058 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
8059 (print_interval, print_number_index, initial_stderr_stream):
8061 * lisp.h (Fprinc): Remove decl.
8062 (debug_output_compilation_hack): Mark as externally visible.
8064 * sysdep.c (croak): Move decl from here to syssignal.h.
8065 * syssignal.h (croak): Put it here, so the API can be checked when
8066 'croak' is called from dissociate_if_controlling_tty.
8068 * minibuf.c: Make symbols static if they're not exported.
8069 (minibuf_save_list, choose_minibuf_frame): Now static.
8070 * lisp.h (choose_minibuf_frame): Remove decl.
8072 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
8074 * lread.c: Make symbols static if they're not exported.
8075 (read_objects, initial_obarray, oblookup_last_bucket_number):
8077 (make_symbol): Remove; unused.
8078 * lisp.h (initial_obarray, make_symbol): Remove decls.
8080 * keyboard.c: Make symbols static if they're not exported.
8081 (single_kboard, recent_keys_index, total_keys, recent_keys):
8082 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
8083 (this_single_command_key_start, echoing, last_auto_save):
8084 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
8085 (command_loop, echo_now, keyboard_init_hook, help_char_p):
8086 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
8087 (Vlispy_mouse_stem, double_click_count):
8089 (force_auto_save_soon): Define only if SIGDANGER.
8090 (ignore_mouse_drag_p): Now static if
8091 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
8092 (print_help): Remove; unused.
8093 (stop_character, last_timer_event): Mark as externally visible.
8094 * keyboard.h (ignore_mouse_drag_p): Declare only if
8095 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
8096 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
8097 * lisp.h (echoing): Remove decl.
8098 (force_auto_save_soon): Declare only if SIGDANGER.
8099 * xdisp.c (redisplay_window): Simplify code, to make it more
8100 obvious that ignore_mouse_drag_p is not accessed if !defined
8101 USE_GTK && !defined HAVE_NS.
8103 * intervals.c: Make symbols static if they're not exported.
8104 (merge_properties_sticky, merge_interval_right, delete_interval):
8106 * intervals.h (merge_interval_right, delete_interval): Remove decls.
8108 * insdel.c: Make symbols static if they're not exported.
8109 However, leave prepare_to_modify_buffer alone. It's never
8110 called from outside this function, but that appears to be a bug.
8111 (combine_after_change_list, combine_after_change_buffer):
8112 (adjust_after_replace, signal_before_change): Now static.
8113 (adjust_after_replace_noundo): Remove; unused.
8114 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
8115 (signal_before_change): Remove decls.
8117 * indent.c (val_compute_motion, val_vmotion): Now static.
8119 * image.c: Make symbols static if they're not exported.
8120 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
8122 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
8123 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
8125 * fringe.c (standard_bitmaps): Now static.
8126 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
8128 * frame.c: Make symbols static if they're not exported.
8129 (x_report_frame_params, make_terminal_frame): Now static.
8130 (get_frame_param): Now static, unless HAVE_NS.
8131 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
8132 (x_get_resource_string): Remove; not used.
8133 * frame.h (make_terminal_frame, x_report_frame_params):
8134 (x_get_resource_string); Remove decls.
8135 (x_fullscreen_adjust): Declare only if WINDOWSNT.
8136 * lisp.h (get_frame_param): Declare only if HAVE_NS.
8138 * font.c, fontset.c: Make symbols static if they're not exported.
8139 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
8140 (FACE_SUITABLE_FOR_CHAR_P): Use it.
8141 * font.c (font_close_object): Now static.
8142 * font.h (font_close_object): Remove.
8143 * fontset.c (FONTSET_OBJLIST): Remove.
8144 (free_realized_fontset) #if-0 the body, which does nothing.
8145 (face_suitable_for_char_p): #if-0, as it's never called.
8146 * fontset.h (face_suitable_for_char_p): Remove decl.
8147 * xfaces.c (face_at_string_position):
8148 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
8149 since 0 is always ASCII.
8151 * fns.c (weak_hash_tables): Now static.
8153 * fileio.c: Make symbols static if they're not exported.
8154 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
8155 (Vwrite_region_annotation_buffers): Now static.
8157 * eval.c: Make symbols static if they're not exported.
8158 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
8159 * lisp.h (backtrace_list): Remove decl.
8161 * emacs.c: Make symbols static if they're not exported.
8162 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
8163 (fatal_error_code, fatal_error_signal_hook, standard_args):
8165 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
8166 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
8167 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8168 * lisp.h (fatal_error_signal_hook): Remove decl.
8169 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8171 * editfns.c: Move a (normally-unused) function to its only use.
8172 * editfns.c, lisp.h (get_operating_system_release): Remove.
8173 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8174 worth the hassle of breaking this out.
8176 * xterm.c: Make symbols static if they're not exported.
8177 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8178 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8179 (x_destroy_window, x_delete_display):
8181 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8182 (x_mouse_leave): Remove; unused.
8183 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8184 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8185 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8187 (x_mouse_leave): Declare only if WINDOWSNT.
8188 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8189 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8192 * ftxfont.c: Make symbols static if they're not exported.
8193 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8195 * font.h (ftxfont_driver): Likewise.
8197 * xfns.c: Make symbols static if they're not exported.
8198 (x_last_font_name, x_display_info_for_name):
8199 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8200 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8201 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8202 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8203 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8204 (last_show_tip_args): Now static.
8205 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8206 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8207 (x_screen_planes): Remove; unused.
8208 * dispextern.h (x_screen_planes): Remove decl.
8210 * dispnew.c: Make symbols static if they're not exported.
8211 * dispextern.h (redraw_garbaged_frames, scrolling):
8212 (increment_row_positions): Remove.
8213 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8214 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8216 (redraw_garbaged_frames): Remove; unused.
8218 * xfaces.c: Make symbols static if they're not exported.
8219 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8221 * xterm.h (defined_color): Remove decls.
8222 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8223 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8224 (menu_face_changed_default, defined_color, free_realized_face):
8225 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8226 (ascii_face_of_lisp_face): Remove; unused.
8228 * xdisp.c: Make symbols static if they're not exported.
8229 * dispextern.h (scratch_glyph_row, window_box_edges):
8230 (glyph_to_pixel_coords, set_cursor_from_row):
8231 (get_next_display_element, set_iterator_to_next):
8232 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8233 (show_mouse_face): Remove decls
8234 * frame.h (message_buf_print): Likewise.
8235 * lisp.h (pop_message, set_message, check_point_in_composition):
8237 * xterm.h (set_vertical_scroll_bar): Likewise.
8238 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8239 (message_buf_print, scratch_glyph_row, displayed_buffer):
8240 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8241 (get_next_display_element, show_mouse_face, window_box_edges):
8242 (frame_to_window_pixel_xy, check_point_in_composition):
8243 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8244 (glyph_to_pixel_coords): Remove; unused.
8246 * dired.c (file_name_completion): Now static.
8248 * dbusbind.c (xd_in_read_queued_messages): Now static.
8250 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8251 * data.c (circular_list_error): Remove.
8253 * commands.h (last_point_position, last_point_position_buffer):
8254 (last_point_position_window): Remove decls.
8255 * keyboard.c: Make these variables static.
8257 * coding.h (coding, code_convert_region, encode_coding_gap):
8259 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8260 (iso_code_class, detect_coding, code_convert_region): Now static.
8261 (encode_coding_gap): Remove; unused.
8263 * chartab.c (chartab_chars, chartab_bits): Now static.
8265 * charset.h (charset_iso_8859_1): Remove decl.
8266 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8269 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8270 * ccl.c (Vccl_program_table): Now static.
8271 (check_ccl_update): Remove; unused.
8273 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8274 * category.h: ... from here.
8275 * category.c (check_category_table, set_category_set): Now static.
8277 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8278 * lisp.h: Remove these decls.
8280 * buffer.c (buffer_count): Remove unused var.
8282 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8283 so that it's not optimized away.
8284 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8285 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8286 exported only to the debugger.
8288 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
8289 * atimer.h (run_all_atimers): Remove; not exported.
8291 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8292 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8293 was inaccessible from Lisp.
8294 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8295 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8297 alloc.c: Import and export fewer symbols, and remove unused items.
8298 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8300 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8301 it's not optimized away by whole-program optimization.
8302 (message_enable_multibyte, free_misc): Remove.
8303 (catchlist, handlerlist, mark_backtrace):
8304 Declare only if BYTE_MARK_STACK.
8305 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8306 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8307 (message_enable_multibyte): Remove decl.
8308 (free_misc, interval_free_list, float_block, float_block_index):
8309 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8310 (cons_free_list, last_marked_index):
8312 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8313 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8314 (mark_backtrace): Define only if BYTE_MARK_STACK.
8315 * xdisp.c (message_enable_multibyte): Now static.
8317 Declare Lisp_Object Q* variables to be 'static' if not exported.
8318 This makes it easier for human readers (and static analyzers)
8319 to see whether these variables are used from other modules.
8320 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8321 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8322 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8323 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8324 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8325 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8326 * xmenu.c, xselect.c:
8327 Declare Q* vars static if they are not used in other modules.
8328 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8329 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8330 Remove decls of unexported vars.
8331 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8333 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8335 Make Emacs functions such as Fatom 'static' by default.
8336 This makes it easier for human readers (and static analyzers)
8337 to see whether these functions can be called from other modules.
8338 DEFUN now defines a static function. To make the function external
8339 so that it can be used in other C modules, use the new macro DEFUE.
8340 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8341 (Finit_image_library):
8342 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8343 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8344 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8345 Remove decls, since these functions are now static.
8346 (Funintern, Fget_internal_run_time): New decls, since these functions
8347 were already external.
8349 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8350 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8351 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8352 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8353 * keyboard.c, keymap.c, lread.c:
8354 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8355 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8356 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8357 Mark functions with DEFUE instead of DEFUN,
8358 if they are used in other modules.
8359 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8360 decls for now-static functions.
8361 * buffer.h (Fdelete_overlay): Remove decl.
8362 * callproc.c (Fgetenv_internal): Mark as internal.
8363 * composite.c (Fremove_list_of_text_properties): Remove decl.
8364 (Fcomposition_get_gstring): New forward static decl.
8365 * composite.h (Fcomposite_get_gstring): Remove decl.
8366 * dired.c (Ffile_attributes): New forward static decl.
8367 * doc.c (Fdocumntation_property): New forward static decl.
8368 * eval.c (Ffetch_bytecode): New forward static decl.
8369 (Funintern): Remove extern decl; now in .h file where it belongs.
8370 * fileio.c (Fmake_symbolic_link): New forward static decl.
8371 * image.c (Finit_image_library): New forward static decl.
8372 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8373 * intervals.h (Fprevious_property_change):
8374 (Fremove_list_of_text_properties): Remove decls.
8375 * keyboard.c (Fthis_command_keys): Remove decl.
8376 (Fcommand_execute): New forward static decl.
8377 * keymap.c (Flookup_key): New forward static decl.
8378 (Fcopy_keymap): Now static.
8379 * keymap.h (Flookup_key): Remove decl.
8380 * process.c (Fget_process): New forward static decl.
8381 (Fprocess_datagram_address): Mark as internal.
8382 * syntax.c (Fsyntax_table_p): New forward static decl.
8383 (skip_chars): Remove duplicate decl.
8384 * textprop.c (Fprevious_property_change): New forward static decl.
8385 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8387 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8388 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8390 * editfns.c (Fformat): Remove unreachable code.
8392 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8394 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8397 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8399 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8400 when at ZV. (Bug#8487)
8402 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8404 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8406 * keyboard.c (parse_tool_bar_item): Likewise.
8407 * sound.c (sound_cleanup, alsa_close): Likewise.
8408 * termcap.c (tgetent): Likewise.
8409 * xfns.c (x_default_font_parameter): Likewise.
8410 * xsettings.c (read_and_apply_settings): Likewise.
8412 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8413 (overrun_check_free): Protoize.
8415 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8417 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8418 since callers should never pass a negative size.
8419 Change the signature to match that of plain 'read' and 'write'; see
8420 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8421 * lisp.h: Update prototypes of emacs_write and emacs_read.
8423 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8425 * xdisp.c (redisplay_window): Don't try to determine the character
8426 position of the scroll margin if the window start point w->startp
8427 is outside the buffer's accessible region. (Bug#8468)
8429 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8431 Fix write-region and its subroutines for buffers > 2GB.
8432 * fileio.c (a_write, e_write): Modify declaration of arguments and
8433 local variables to support buffers larger than 2GB.
8434 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8436 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8437 argument, local variables, and return value.
8439 * lisp.h: Update prototypes of emacs_write and emacs_read.
8441 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8443 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8445 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8447 Fix more problems found by GCC 4.6.0's static checks.
8449 * xdisp.c (vmessage): Use a better test for character truncation.
8451 * charset.c (load_charset_map): <, not <=, for optimization,
8452 and to avoid potential problems with integer overflow.
8453 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8454 * casetab.c (set_identity, shuffle): Likewise.
8455 * editfns.c (Fformat): Likewise.
8456 * syntax.c (skip_chars): Likewise.
8458 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8459 This also lets GCC 4.6.0 generate slightly better loop code.
8461 * callint.c (Fcall_interactively): <, not <=, for optimization.
8462 (Fcall_interactively): Count the number of arguments produced,
8463 not the number of arguments given. This is simpler and lets GCC
8464 4.6.0 generate slightly better code.
8466 * ftfont.c: Distingish more carefully between FcChar8 and char.
8467 The previous code passed unsigned char * to a functions like
8468 strlen and xstrcasecmp that expect char *, which does not
8469 conform to the C standard.
8470 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8471 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8472 char * when the C standard requires it.
8474 * keyboard.c (read_char): Remove unused var.
8476 * eval.c: Port to Windows vsnprintf (Bug#8435).
8478 (SIZE_MAX): Define if the headers do not.
8479 (verror): Do not give up if vsnprintf returns a negative count.
8480 Instead, grow the buffer. This ports to Windows vsnprintf, which
8481 does not conform to C99. Problem reported by Eli Zaretskii.
8482 Also, simplify the allocation scheme, by avoiding the need for
8483 calling realloc, and removing the ALLOCATED variable.
8485 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8487 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8488 But keep the doprint source code for now, as we might revamp it
8489 and use it again (Bug#8435).
8490 * lisp.h (doprnt): Remove.
8491 * Makefile.in (base_obj): Remove doprnt.o.
8492 * deps.mk (doprnt.o): Remove.
8494 error: Print 32- and 64-bit integers portably (Bug#8435).
8495 Without this change, on typical 64-bit hosts error ("...%d...", N)
8496 was used to print both 32- and 64-bit integers N, which relied on
8498 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8499 * lisp.h (error, verror): Mark as printf-like functions.
8500 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8501 Report overflow in size calculations when allocating printf buffer.
8502 Do not truncate output string at its first null byte.
8503 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8504 Truncate the output at a character boundary, since vsnprintf does not
8506 * charset.c (check_iso_charset_parameter): Convert internal
8507 character to string before calling 'error', since %c now has the
8509 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8510 overflow when computing char to be passed to 'error'. Do not
8511 pass Lisp_Object to 'error'; pass the integer instead.
8512 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8513 formatted with plain %d.
8515 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8517 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8519 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8521 * xterm.c (x_catch_errors): Remove duplicate declaration.
8523 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8525 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8527 2011-04-10 Jim Meyering <meyering@redhat.com>
8529 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8530 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8531 return ssize_t not "int", and use size_t as the buffer length.
8532 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8533 * gnutls.h: Update declarations.
8534 * process.c (read_process_output): Use ssize_t, to match.
8535 (send_process): Likewise.
8537 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8539 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8541 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8543 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8544 Use unsigned char, to match FcChar8 type definition.
8546 * xterm.c (handle_one_xevent):
8547 * xmenu.c (create_and_show_popup_menu):
8548 * xselect.c (x_decline_selection_request)
8549 (x_reply_selection_request): Avoid type-punned deref of X events.
8551 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8553 Fix some uses of `int' instead of EMACS_INT.
8554 * search.c (string_match_1, fast_string_match)
8555 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8556 (scan_buffer, find_next_newline_no_quit)
8557 (find_before_next_newline, search_command, Freplace_match)
8558 (Fmatch_data): Make some `int' variables be EMACS_INT.
8560 * xdisp.c (display_count_lines): 3rd argument and return value now
8561 EMACS_INT. All callers changed.
8562 (pint2hrstr): Last argument is now EMACS_INT.
8564 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8565 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8566 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8567 (decode_coding_utf_16, decode_coding_emacs_mule)
8568 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8569 (decode_coding_ccl, decode_coding_charset)
8570 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8571 (decode_coding_iso_2022, decode_coding_emacs_mule)
8572 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8573 <char_offset, last_offset>: Declare EMACS_INT.
8574 (encode_coding_utf_8, encode_coding_utf_16)
8575 (encode_coding_emacs_mule, encode_invocation_designation)
8576 (encode_designation_at_bol, encode_coding_iso_2022)
8577 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8578 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8580 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8581 (encode_invocation_designation): Last argument P_NCHARS is now
8583 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8584 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8586 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8589 * ccl.c (Fccl_execute_on_string): Declare some variables
8592 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8594 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8596 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8598 * process.c (Fformat_network_address): Doc fix.
8600 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8602 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8604 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8606 * keyboard.c (read_char): Call Lisp function help-form-show,
8607 instead of using internal_with_output_to_temp_buffer.
8608 (Qhelp_form_show): New var.
8609 (syms_of_keyboard): Use DEFSYM macro.
8611 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8613 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8615 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8617 * process.c (Flist_processes): Remove to Lisp.
8618 (list_processes_1): Delete.
8620 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8622 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8624 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8626 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8628 Fix more problems found by GCC 4.6.0's static checks.
8630 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8632 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8634 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8636 * xdisp.c (vmessage): Mark as a printf-like function.
8638 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8640 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8642 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8643 printf-like functions.
8644 (tiff_load): Add casts to remove these marks before passing them
8645 to system-supplied API.
8647 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8649 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8650 This avoids several warnings with gcc -Wstrict-overflow.
8651 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8652 directly, rather than having caller test rule sign. This avoids
8653 some unnecessary tests.
8654 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8655 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8656 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8658 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8659 (xfont_open): Avoid unnecessary tests.
8661 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8663 * composite.h, composite.c (composition_gstring_put_cache):
8664 Use EMACS_INT, not int, for length.
8666 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8667 breaking out part of COMPOSITION_DECODE_RULE.
8668 (COMPOSITION_DECODE_RULE): Use it.
8669 * composite.c (get_composition_id): Remove unused local vars,
8670 by using the new macro.
8672 * textprop.c (set_text_properties_1): Change while to do-while,
8673 since the condition is always true at first.
8675 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8676 (interval_deletion_adjustment): Return unsigned value.
8679 * process.c (list_processes_1, create_pty, read_process_output):
8680 (exec_sentinel): Remove vars that were set but not used.
8681 (create_pty): Remove unnecessary "volatile"s.
8682 (Fnetwork_interface_info): Avoid possibility of int overflow.
8683 (read_process_output): Do adaptive read buffering even if carryover.
8684 (read_process_output): Simplify nbytes computation if buffered.
8686 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8688 * syntax.c (scan_words): Remove var that was set but not used.
8689 (update_syntax_table): Use unsigned instead of int.
8691 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8692 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8693 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8695 * print.c (print_error_message): Avoid int overflow.
8697 * font.c (font_list_entities): Redo for clarity,
8698 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8700 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8701 (font_score): Avoid potential overflow in diff calculation.
8703 * fns.c (substring_both): Remove var that is set but not used.
8704 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8706 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8708 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8709 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8710 can always succeed if overflow has undefined behavior.
8712 * search.c (boyer_moore, wordify): Remove vars set but not used.
8713 (wordify): Omit three unnecessary tests.
8715 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8716 All callers changed. This avoids the need for an unused var.
8718 * casefiddle.c (casify_region): Remove var that is set but not used.
8720 * dired.c (file_name_completion): Remove var that is set but not used.
8722 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8724 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8725 (Finsert_file_contents): Remove unnecessary code checking fd.
8727 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8728 Check for integer overflow on size calculations.
8730 * buffer.c (Fprevious_overlay_change): Remove var that is set
8733 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8734 Remove vars that are set but not used.
8735 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8736 (timer_check_2): Mark vars as initialized.
8738 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8740 * image.c (lookup_image): Remove var that is set but not used.
8741 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8743 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8744 that are set but not used.
8746 * xfns.c (make_invisible_cursor): Don't return garbage
8747 if XCreateBitmapFromData fails (Bug#8410).
8749 * xselect.c (x_get_local_selection, x_handle_property_notify):
8750 Remove vars that are set but not used.
8752 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8753 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8755 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8756 Remove var that is set but not used.
8757 (scroll_bar_windows_size): Now size_t, not int.
8758 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8761 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8762 (map_tty_color) [!defined MSDOS]: Likewise.
8764 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8766 * coding.c: Remove vars that are set but not used.
8767 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8768 All callers changed.
8769 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8770 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8771 (decode_coding_charset): Remove vars that are set but not used.
8773 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8774 that is set but not used.
8776 * print.c (print_object): Remove var that is set but not used.
8778 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8779 The gnulib version avoids calling malloc in the usual case,
8780 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8781 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8782 * filelock.c (current_lock_owner): Likewise.
8783 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8784 * sysdep.c: Include allocator.h, careadlinkat.h.
8785 (emacs_no_realloc_allocator): New static constant.
8786 (emacs_readlink): New function.
8787 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8788 ../lib/careadlinkat.h.
8790 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8792 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8793 first non-nil return value).
8795 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8797 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8798 if not defined (Bug#8403).
8800 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8802 * xdisp.c (display_count_lines): Remove parameter `start',
8803 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8804 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8805 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8806 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8807 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8808 and thereabouts. All callers changed.
8809 (get_per_char_metric): Remove parameter `f', unused since
8810 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8812 2011-04-02 Jim Meyering <meyering@redhat.com>
8814 do not dereference NULL upon failed strdup
8815 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8816 (ns_get_family): Likewise.
8818 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8820 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8822 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8824 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8827 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8829 Add lexical binding.
8831 * window.c (Ftemp_output_buffer_show): New fun.
8832 (Fsave_window_excursion):
8833 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8835 * lread.c (lisp_file_lexically_bound_p): New function.
8836 (Fload): Bind Qlexical_binding.
8837 (readevalloop): Remove `evalfun' arg.
8838 Bind Qinternal_interpreter_environment.
8839 (Feval_buffer): Bind Qlexical_binding.
8840 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8842 (syms_of_lread): Declare `lexical-binding'.
8844 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8846 * keyboard.c (eval_dyn): New fun.
8847 (menu_item_eval_property): Use it.
8849 * image.c (parse_image_spec): Use Ffunctionp.
8851 * fns.c (concat, mapcar1): Accept byte-code-functions.
8853 * eval.c (Fsetq): Handle lexical vars.
8854 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8855 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8856 (FletX, Flet): Obey lexical binding.
8857 (Fcommandp): Handle closures.
8858 (Feval): New `lexical' arg.
8859 (eval_sub): New function extracted from Feval. Use it almost
8860 everywhere where Feval was used. Look up vars in lexical env.
8862 (Ffunctionp): Move from subr.el.
8863 (Ffuncall): Handle closures.
8864 (apply_lambda): Remove `eval_flags'.
8865 (funcall_lambda): Handle closures and new byte-code-functions.
8866 (Fspecial_variable_p): New function.
8867 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8868 but without exporting it to Lisp.
8870 * doc.c (Fdocumentation, store_function_docstring):
8871 * data.c (Finteractive_form): Handle closures.
8873 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8876 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8878 (exec_byte_code): New function extracted from Fbyte_code to handle new
8879 calling convention for byte-code-functions. Add new byte-codes.
8881 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8883 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8885 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8887 * xdisp.c (redisplay_internal): Fix prototype.
8889 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8891 * xdisp.c (SCROLL_LIMIT): New macro.
8892 (try_scrolling): Use it when setting scroll_limit.
8893 Limit scrolling to 100 screen lines.
8894 (redisplay_window): Even when falling back on "recentering",
8895 position point in the window according to scroll-conservatively,
8896 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8898 (try_scrolling): When point is above the window, allow searching
8899 as far as scroll_max, or one screenful, to compute vertical
8900 distance from PT to the scroll margin position. This prevents
8901 try_scrolling from unnecessarily failing when
8902 scroll-conservatively is set to a value slightly larger than the
8903 window height. Clean up the case of PT below the margin at bottom
8904 of window: scroll_max can no longer be INT_MAX. When aggressive
8905 scrolling is in use, don't let point enter the opposite scroll
8906 margin as result of the scroll.
8907 (syms_of_xdisp) <scroll-conservatively>: Document the
8908 threshold of 100 lines for never-recentering scrolling.
8910 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8912 * dispextern.h (move_it_by_lines):
8913 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8914 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8915 (message_log_check_duplicate): Remove parameters `prev_bol' and
8916 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8917 (redisplay_internal): Remove parameter `preserve_echo_area',
8918 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8920 * indent.c (Fvertical_motion):
8921 * window.c (window_scroll_pixel_based, Frecenter):
8922 Don't pass `need_y_p' to `move_it_by_lines'.
8924 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8926 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8927 steal a few bits to be more compact.
8928 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8929 Remove unneeded casts.
8931 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8933 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8935 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8936 binding" message (bug#7967).
8938 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8940 Fix more problems found by GCC 4.6.0's static checks.
8942 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8943 Remove unused local var.
8945 * editfns.c (Fmessage_box): Remove unused local var.
8947 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8948 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8949 Omit unused local vars.
8950 * window.c (shrink_windows): Omit unused local var.
8951 * menu.c (digest_single_submenu): Omit unused local var.
8952 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8953 Omit unused local var.
8955 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8956 Don't assume string length fits in int.
8957 (keyremap_step, read_key_sequence): Use size_t for sizes.
8958 (read_key_sequence): Don't check last_real_key_start redundantly.
8960 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8961 instead of alloca (Bug#8344).
8963 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8964 (Fbacktrace_frame): Don't assume nframes fits in int.
8966 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8968 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8971 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8973 * cm.c (calccost): Turn while-do into do-while, for clarity.
8975 * keyboard.c (syms_of_keyboard): Use the same style as later
8976 in this function when indexing through an array. This also
8977 works around GCC bug 48267.
8979 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8981 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8983 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8984 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8986 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8987 This avoids undefined behavior on integer overflow, and is a bit
8988 more convenient anyway since it is compared to a size_t variable.
8990 Variadic C functions now count arguments with size_t, not int.
8991 This avoids an unnecessary limitation on 64-bit machines, which
8992 caused (substring ...) to crash on large vectors (Bug#8344).
8993 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8994 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8995 All variadic functions and their callers changed accordingly.
8996 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8997 * data.c (arith_driver, float_arith_driver): Likewise.
8998 * editfns.c (general_insert_function): Likewise.
8999 * eval.c (struct backtrace.nargs, interactive_p)
9000 (internal_condition_case_n, run_hook_with_args, apply_lambda)
9001 (funcall_lambda, mark_backtrace): Likewise.
9002 * fns.c (concat): Likewise.
9003 * frame.c (x_set_frame_parameters): Likewise.
9004 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
9005 0 if not found, not -1. All callers changed.
9007 * alloc.c (garbage_collect): Don't assume stack size fits in int.
9008 (stack_copy_size): Now size_t, not int.
9009 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
9011 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
9013 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
9014 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9015 All callers changed.
9017 * lisp.h (multibyte_char_to_unibyte):
9018 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
9019 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9020 * character.h (CHAR_TO_BYTE8):
9021 * cmds.c (internal_self_insert):
9022 * editfns.c (general_insert_function):
9023 * keymap.c (push_key_description):
9024 * search.c (Freplace_match):
9025 * xdisp.c (message_dolog, set_message_1): All callers changed.
9027 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
9029 * keyboard.c (safe_run_hook_funcall): New function.
9030 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
9031 don't set the hook to nil, but remove the offending function instead.
9032 (Qcommand_hook_internal): Remove, unused.
9033 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
9034 Vcommand_hook_internal.
9036 * eval.c (enum run_hooks_condition): Remove.
9037 (funcall_nil, funcall_not): New functions.
9038 (run_hook_with_args): Call each function through a `funcall' argument.
9039 Remove `cond' argument, now redundant.
9040 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
9041 (Frun_hook_with_args_until_failure): Adjust accordingly.
9042 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
9044 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
9046 * dispextern.h (string_buffer_position): Remove declaration.
9048 * print.c (strout): Remove parameter `multibyte', unused since
9049 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
9051 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
9052 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
9053 All callers changed.
9055 * w32.c (_wsa_errlist): Use braces for struct initializers.
9057 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
9058 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
9059 All callers changed.
9060 (string_buffer_position): Likewise. Also, make static (it's never
9061 used outside xdisp.c).
9062 (cursor_row_p): Remove parameter `w', unused since
9063 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
9064 (decode_mode_spec): Remove parameter `precision', introduced during
9065 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
9066 All callers changed.
9068 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9070 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
9072 2011-03-27 Anders Lindgren <andlind@gmail.com>
9074 * nsterm.m (ns_menu_bar_is_hidden): New variable.
9075 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
9076 (ns_update_auto_hide_menu_bar): New functions.
9077 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
9078 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
9079 ns_constrain_all_frames.
9080 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
9081 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
9083 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9085 * nsmenu.m (runDialogAt): Remove argument to timer_check.
9087 2011-03-27 Glenn Morris <rgm@gnu.org>
9089 * syssignal.h: Replace RETSIGTYPE with void.
9090 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
9091 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
9092 Replace SIGTYPE with void everywhere.
9093 * s/usg5-4-common.h (SIGTYPE): Remove definition.
9094 * s/template.h (SIGTYPE): Remove commented out definition.
9096 2011-03-26 Eli Zaretskii <eliz@gnu.org>
9098 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
9099 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
9101 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
9103 * w32.c (read_unc_volume): Use parameter `henum', instead of
9104 global variable `wget_enum_handle'.
9106 * keymap.c (describe_vector): Remove parameters `indices' and
9107 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
9108 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
9110 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
9112 * keyboard.c (timer_check): Remove parameter `do_it_now',
9113 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
9114 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
9115 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
9117 * keyboard.c (read_char):
9118 * w32menu.c (w32_menu_display_help):
9119 * xmenu.c (show_help_event, menu_help_callback):
9120 Adjust calls to `show_help_echo'.
9122 * gtkutil.c (xg_maybe_add_timer):
9123 * keyboard.c (readable_events):
9124 * process.c (wait_reading_process_output):
9125 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
9127 * insdel.c (adjust_markers_gap_motion):
9128 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
9129 (gap_left, gap_right): Don't call it.
9131 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
9133 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
9134 incurred during fontification.
9136 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9138 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
9139 (DEFVAR_PER_BUFFER): Don't pass it.
9141 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
9142 (scrolling_window): Don't pass it.
9144 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9146 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
9148 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
9150 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
9151 of variables specific to SELinux and computation of `encoded_absname'.
9153 * image.c (XPutPixel): Remove unused variable `height'.
9155 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
9157 * unexw32.c (get_section_info): Remove unused variable `section'.
9159 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
9160 (system_process_attributes): Remove unused variable `sess'.
9161 (sys_read): Remove unused variable `err'.
9163 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
9164 (w32_wnd_proc): Remove unused variable `isdead'.
9165 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
9166 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
9167 (x_create_tip_frame): Remove unused variable `tem'.
9169 * w32inevt.c (w32_console_read_socket):
9170 Remove unused variable `no_events'.
9172 * w32term.c (x_draw_composite_glyph_string_foreground):
9173 Remove unused variable `width'.
9175 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
9177 * w32term.c (x_set_glyph_string_clipping):
9178 Don't pass uninitialized region to CombineRgn.
9180 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
9182 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9183 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9184 (Fx_close_connection): Remove unused variable `i'.
9186 * w32font.c (w32font_draw): Return number of glyphs.
9187 (w32font_open_internal): Remove unused variable `i'.
9188 (w32font_driver): Add missing initializer.
9190 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9191 (fill_in_menu): Remove unused variable `items_added'.
9193 * w32term.c (last_mouse_press_frame): Remove static global variable.
9194 (w32_clip_to_row): Remove unused variable `f'.
9195 (x_delete_terminal): Remove unused variable `i'.
9197 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9198 (NOTHING): Remove unused static global variable.
9199 (uniscribe_check_otf): Remove unused variable `table'.
9200 (uniscribe_font_driver): Add missing initializers.
9202 2011-03-23 Julien Danjou <julien@danjou.info>
9204 * term.c (Fsuspend_tty, Fresume_tty):
9205 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9206 * window.c (temp_output_buffer_show):
9207 * insdel.c (signal_before_change):
9208 * frame.c (Fhandle_switch_frame):
9209 * fileio.c (Fdo_auto_save):
9210 * emacs.c (Fkill_emacs):
9211 * editfns.c (save_excursion_restore):
9212 * cmds.c (internal_self_insert):
9213 * callint.c (Fcall_interactively):
9214 * buffer.c (Fkill_all_local_variables):
9215 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9217 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
9218 unconditionally since it does the check itself.
9220 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
9222 Fix more problems found by GCC 4.5.2's static checks.
9224 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9225 the first time through the loop, since we know p0 < p1 then.
9226 This also avoids a gcc -Wstrict-overflow warning.
9228 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9229 leading to a memory leak, possible in functions like
9230 load_charset_map_from_file that can allocate an unbounded number
9231 of objects (Bug#8318).
9233 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9234 that could (at least in theory) be that large.
9236 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9237 This is less likely to overflow, and avoids undefined behavior if
9238 overflow does occur. All callers changed. Use strtoul to scan
9239 for the unsigned long integer.
9240 (pint2hrstr): Simplify and tune code slightly.
9241 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
9243 * scroll.c (do_scrolling): Work around GCC bug 48228.
9244 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9246 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9247 This also avoids a warning with gcc -Wstrict-overflow.
9248 (validate_x_resource_name): Simplify count usage.
9249 This also avoids a warning with gcc -Wstrict-overflow.
9251 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9254 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
9256 * process.c (Fmake_network_process): Use socklen_t, not int,
9257 where POSIX says socklen_t is required in portable programs.
9258 This fixes a porting bug on hosts like 64-bit HP-UX, where
9259 socklen_t is wider than int (Bug#8277).
9260 (Fmake_network_process, server_accept_connection):
9261 (wait_reading_process_output, read_process_output):
9264 * process.c: Rename or move locals to avoid shadowing.
9265 (list_processes_1, Fmake_network_process):
9266 (read_process_output_error_handler, exec_sentinel_error_handler):
9267 Rename or move locals.
9268 (Fmake_network_process): Define label "retry_connect" only if needed.
9269 (Fnetwork_interface_info): Fix pointer signedness.
9270 (process_send_signal): Add cast to avoid pointer signedness problem.
9271 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
9272 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
9274 Make tparam.h and terminfo.c consistent.
9275 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9276 Include tparam.h instead, since it declares them.
9277 * cm.h (PC): Remove extern decl; tparam.h now does this.
9278 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9279 * terminfo.c: Include tparam.h, to check interfaces.
9280 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9281 (tparam): Adjust signature to match interface in tparam.h;
9282 this removes some undefined behavior. Check that outstring and len
9283 are zero, which they always are with Emacs.
9284 * tparam.h (PC, BC, UP): New extern decls.
9286 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
9287 (xftfont_open): Rename locals to avoid shadowing.
9289 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
9290 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9291 (OTF_TAG_SYM): Omit macro if not needed.
9292 (ftfont_list): Remove unused local.
9293 (get_adstyle_property, ftfont_pattern_entity):
9294 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9295 Rename locals to avoid shadowing.
9297 * xfont.c (xfont_list_family): Mark var as initialized.
9299 * xml.c (make_dom): Now static.
9301 * composite.c (composition_compute_stop_pos): Rename local to
9303 (composition_reseat_it): Remove unused locals.
9304 (find_automatic_composition, composition_adjust_point): Likewise.
9305 (composition_update_it): Mark var as initialized.
9306 (find_automatic_composition): Mark vars as initialized,
9307 with a FIXME (Bug#8290).
9309 character.h: Rename locals to avoid shadowing.
9310 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9311 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9312 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9313 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9316 * textprop.c (property_change_between_p): Remove; unused.
9318 * intervals.c (interval_start_pos): Now static.
9320 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9322 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9323 Rename locals to avoid shadowing.
9325 * sound.c (wav_play, au_play, Fplay_sound_internal):
9326 Fix pointer signedness.
9327 (alsa_choose_format): Remove unused local var.
9328 (wav_play): Initialize a variable to 0, to prevent undefined
9329 behavior (Bug#8278).
9331 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9333 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9335 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9336 clobbering (Bug#8298).
9337 * sysdep.c (sys_subshell): Likewise.
9338 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9340 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9341 This should get cleaned up, so that child_setup has the
9342 same signature on all platforms.
9344 * callproc.c (call_process_cleanup): Now static.
9345 (relocate_fd): Rename locals to avoid shadowing.
9347 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
9349 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9350 not to be necessary, and produces flickering.
9352 2011-03-20 Glenn Morris <rgm@gnu.org>
9354 * config.in: Remove file.
9356 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9358 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9359 are now in src/globals.h.
9360 (syms_of_minibuf): Remove spurious & from previous change.
9362 2011-03-20 Leo Liu <sdl.web@gmail.com>
9364 * minibuf.c (completing-read-function): New variable.
9365 (completing-read-default): Rename from completing-read.
9366 (completing-read): Call completing-read-function.
9368 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9370 * xfaces.c (Fx_load_color_file):
9371 Read color file from absolute filename (bug#8250).
9373 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9375 * makefile.w32-in: Update dependencies.
9377 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9379 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9381 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9383 Fix more problems found by GCC 4.5.2's static checks.
9385 * process.c (make_serial_process_unwind, send_process_trap):
9386 (sigchld_handler): Now static.
9388 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9389 That way, the code declares only the vars that it needs.
9390 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9391 * s/cygwin.h (PTY_ITERATION): Likewise.
9392 * s/darwin.h (PTY_ITERATION): Likewise.
9393 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9395 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9396 * process.c (allocate_pty): Don't declare stb unless it's needed.
9398 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9399 (CONSTANTLIM): Remove; unused.
9400 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9401 Define only if needed.
9403 * unexelf.c (unexec): Name an expression,
9404 to avoid gcc -Wbad-function-cast warning.
9405 Use a different way to cause a compilation error if anyone uses
9406 n rather than nn, a way that does not involve shadowing.
9407 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9409 * deps.mk (unexalpha.o): Remove; unused.
9411 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9412 * unexec.h: New file.
9413 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9414 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9416 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9417 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9418 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9419 Change as necessary to match prototype in unexec.h.
9421 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9423 (back_comment, skip_chars): Mark vars as initialized.
9425 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9426 Rename locals to avoid shadowing.
9428 * lread.c (read1): Rewrite so as not to use empty "else".
9429 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9431 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9433 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9434 warning when compiling print.c.
9436 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9437 instead of using an uninitialized var.
9438 (font_sort_entities): Mark var as initialized.
9440 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9442 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9443 pointers to constants.
9444 (font_parse_fcname): Remove unused vars.
9445 (font_delete_unmatched): Now static.
9446 (font_get_spec): Remove; unused.
9447 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9448 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9449 Rename or move locals to avoid shadowing.
9451 * fns.c (require_nesting_list, require_unwind): Now static.
9452 (Ffillarray): Rename locals to avoid shadowing.
9454 * floatfns.c (domain_error2): Define only if needed.
9455 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9457 * alloc.c (mark_backtrace): Move decl from here ...
9458 * lisp.h: ... to here, so that it can be checked.
9460 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9461 (Fdefvar): Rewrite so as not to use empty "else".
9462 (lisp_indirect_variable): Name an expression,
9463 to avoid gcc -Wbad-function-cast warning.
9464 (Fdefvar): Rename locals to avoid shadowing.
9466 * callint.c (quotify_arg, quotify_args): Now static.
9467 (Fcall_interactively): Rename locals to avoid shadowing.
9468 Use const pointer when appropriate.
9470 * lisp.h (get_system_name, get_operating_system_release):
9471 Move decls here, to check interfaces.
9472 * process.c (get_operating_system_release): Move decl to lisp.h.
9473 * xrdb.c (get_system_name): Likewise.
9474 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9475 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9476 some of which prompt warnings from gcc -Wbad-function-cast.
9477 (Fformat_time_string, Fencode_time, Finsert_char):
9478 (Ftranslate_region_internal, Fformat):
9479 Rename or remove local vars to avoid shadowing.
9480 (Ftranslate_region_internal): Mark var as initialized.
9482 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9485 * lisp.h (eassert): Check that the argument compiles, even if
9486 ENABLE_CHECKING is not defined.
9488 * data.c (Findirect_variable): Name an expression, to avoid
9489 gcc -Wbad-function-cast warning.
9490 (default_value, arithcompare, arith_driver, arith_error): Now static.
9491 (store_symval_forwarding): Rename local to avoid shadowing.
9492 (Fmake_variable_buffer_local, Fmake_local_variable):
9493 Mark variables as initialized.
9494 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9496 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9497 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9498 Rename locals to avoid shadowing.
9499 (mark_stack): Move local variables into the #ifdef region where
9501 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9502 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9504 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9505 (GC_STRING_CHARS): Remove; not used.
9506 (Fmemory_limit): Cast sbrk's returned value to char *.
9508 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9509 avoids undefined behavior in theory.
9511 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9513 Use functions, not macros, for up- and down-casing (Bug#8254).
9514 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9515 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9516 to use the following functions instead of these macros.
9517 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9518 EMACS_INT, since callers assume the returned value fits in int.
9519 (upcase1): Likewise, for UPCASE_TABLE.
9520 (uppercasep, lowercasep, upcase): New static inline functions.
9521 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9522 the race-condition problem in the old DOWNCASE.
9524 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9525 Rename locals to avoid shadowing.
9526 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9527 (regex_compile, re_search_2, re_match_2_internal):
9528 Remove unused local vars.
9529 (FREE_VAR): Rewrite so as not to use empty "else",
9530 which gcc can warn about.
9531 (regex_compile, re_match_2_internal): Mark locals as initialized.
9532 (RETALLOC_IF): Define only if needed.
9533 (WORDCHAR_P): Likewise. This one is never needed, but is used
9534 only in a comment talking about a compiler bug, so put inside
9535 the #if 0 of that comment.
9536 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9537 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9540 * search.c (boyer_moore): Rename locals to avoid shadowing.
9541 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9542 (PREV_CHAR_BOUNDARY): Likewise.
9544 * search.c (simple_search): Remove unused var.
9546 * dired.c (compile_pattern): Move decl from here ...
9547 * lisp.h: ... to here, so that it can be checked.
9548 (struct re_registers): New forward decl.
9550 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9552 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9554 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9555 Rename locals to avoid shadowing.
9556 (Fvertical_motion): Mark locals as initialized.
9558 * casefiddle.c (casify_object, casify_region): Now static.
9559 (casify_region): Mark local as initialized.
9561 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9563 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9564 New macros, so that the caller can use some names other than
9565 gcpro1, gcpro2, etc.
9566 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9568 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9569 argument, for consistency with GCPRO2_VAR, etc: it is now the
9570 prefix of the variable, not the variable itself. All uses
9572 * dired.c (directory_files_internal, file_name_completion):
9573 Rename locals to avoid shadowing.
9575 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9576 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9577 dired.c's scmp function, had undefined behavior.
9578 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9579 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9580 * buffer.h: ... to here, because these macros use current_buffer,
9581 and the new implementation with inline functions needs to have
9582 current_buffer in scope now, rather than later when the macros
9584 (downcase, upcase1): New static inline functions.
9585 (DOWNCASE, UPCASE1): Reimplement using these functions.
9586 This avoids undefined behavior in expressions like
9587 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9588 from race conditions in accessing the global variables
9589 case_temp1 and case_temp2.
9590 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9591 * lisp.h (case_temp1, case_temp2): Remove their decls.
9592 * character.h (ASCII_CHAR_P): Move from here ...
9593 * lisp.h: ... to here, so that the inline functions mentioned
9596 * dired.c (directory_files_internal_unwind): Now static.
9598 * fileio.c (file_name_as_directory, directory_file_name):
9599 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9601 (file_name_as_directory): Use const pointers when appropriate.
9602 (Fexpand_file_name): Likewise. In particular, newdir might
9603 point at constant storage, so make it a const pointer.
9604 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9605 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9607 (Fset_file_times, Finsert_file_contents, auto_save_error):
9608 Rename locals to avoid shadowing.
9610 * minibuf.c (choose_minibuf_frame_1): Now static.
9611 (Ftry_completion, Fall_completions): Rename or remove locals
9614 * marker.c (bytepos_to_charpos): Remove; unused.
9616 * lisp.h (verify_bytepos, count_markers): New decls,
9617 so that gcc does not warn that these functions aren't declared.
9619 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9620 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9621 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9622 (copy_text): Remove unused local var.
9624 * filelock.c (within_one_second): Now static.
9625 (lock_file_1): Rename local to avoid shadowing.
9627 * buffer.c (fix_overlays_before): Mark locals as initialized.
9628 (fix_start_end_in_overlays): Likewise. This function should be
9629 simplified by using pointers-to-pointers, but that's a different
9631 (switch_to_buffer_1): Now static.
9632 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9633 (report_overlay_modification): Rename locals to avoid shadowing.
9635 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9636 Fix pointer signedness issue.
9637 (sys_subshell): Mark local as volatile if checking for lint,
9638 to suppress a gcc -Wclobbered warning that does not seem to be right.
9639 (MAXPATHLEN): Define only if needed.
9641 * process.c (serial_open, serial_configure): Move decls from here ...
9642 * systty.h: ... to here, so that they can be checked.
9644 * fns.c (get_random, seed_random): Move extern decls from here ...
9645 * lisp.h: ... to here, so that they can be checked.
9647 * sysdep.c (reset_io): Now static.
9648 (wait_for_termination_signal): Remove; unused.
9650 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9651 (copy_keymap_item, append_key, push_text_char_description):
9653 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9654 (DENSE_TABLE_SIZE): Remove; unused.
9655 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9656 (describe_map_tree):
9657 Rename locals to avoid shadowing.
9659 * keyboard.c: Declare functions static if they are not used elsewhere.
9660 (echo_char, echo_dash, cmd_error, top_level_2):
9661 (poll_for_input, handle_async_input): Now static.
9662 (read_char, kbd_buffer_get_event, make_lispy_position):
9663 (make_lispy_event, make_lispy_movement, apply_modifiers):
9664 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9665 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9666 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9667 (read_key_sequence, read_char): Mark locals as initialized.
9668 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9670 * keyboard.h (make_ctrl_char): New decl.
9671 (mark_kboards): Move decl here ...
9672 * alloc.c (mark_kboards): ... from here.
9674 * lisp.h (force_auto_save_soon): New decl.
9676 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9677 (DEFINE_DUMMY_FUNCTION): New macro.
9678 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9680 (main): Add casts to avoid warnings
9681 if GCC considers string literals to be constants.
9683 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9685 * dbusbind.c: Pointer signedness fixes.
9686 (xd_signature, xd_append_arg, xd_initialize):
9687 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9688 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9689 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9690 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9692 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9693 if GCC considers string literals to be constants.
9694 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9696 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9698 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9699 (print_preprocess, print_object): New macro to fix last change.
9701 * print.c (print_preprocess): Don't forget font objects.
9703 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9705 * emacs.c (USAGE3): Doc fixes.
9707 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9709 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9712 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9714 * lisp.h (VWindow_system, Qfile_name_history):
9715 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9716 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9717 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9719 * w32select.c: Don't #include "keyboard.h".
9720 (run_protected): Add extern declaration for waiting_for_input.
9722 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9723 * w32console.c (detect_input_pending, read_input_pending)
9724 (encode_terminal_code):
9725 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9726 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9727 (w32_system_caret_y, Qfile_name_history):
9728 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9729 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9730 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9731 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9732 * w32proc.c (Qlocal, report_file_error):
9733 * w32term.c (Vwindow_system, updating_frame):
9734 * w32uniscribe.c (initialized, uniscribe_font_driver):
9735 Remove unneeded extern declarations.
9737 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9739 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9741 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9743 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9744 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9745 These macros can no longer be used for assignment.
9747 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9748 Assign struct members directly, instead of using BUF_BEGV etc.
9749 (record_buffer_markers, fetch_buffer_markers): New functions for
9750 recording and fetching special buffer markers.
9751 (set_buffer_internal_1, set_buffer_temp): Use them.
9753 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9755 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9757 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9758 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9760 * xdisp.c (hscroll_window_tree):
9761 (reconsider_clip_changes): Use PT instead of BUF_PT.
9763 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9765 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9766 $(EMACS_ROOT)/lib/intprops.h.
9768 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9770 Fix more problems found by GCC 4.5.2's static checks.
9772 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9773 to unsigned char * to avoid compiler diagnostic.
9774 (xg_free_frame_widgets): Make it clear that a local variable is
9775 needed only if USE_GTK_TOOLTIP.
9776 (gdk_window_get_screen): Make it clear that this macro is needed
9777 only if USE_GTK_TOOLTIP.
9778 (int_gtk_range_get_value): New function, which avoids a diagnostic
9779 from gcc -Wbad-function-cast.
9780 (xg_set_toolkit_scroll_bar_thumb): Use it.
9781 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9782 diagnostic from gcc -Wbad-function-cast.
9783 (get_utf8_string, xg_get_file_with_chooser):
9784 Rename locals to avoid shadowing.
9785 (create_dialog): Move locals to avoid shadowing.
9787 * xgselect.c (xg_select): Remove unused var.
9789 * image.c (four_corners_best): Mark locals as initialized.
9790 (gif_load): Initialize transparent_p to zero (Bug#8238).
9791 Mark another local as initialized.
9792 (my_png_error, my_error_exit): Mark with NO_RETURN.
9794 * image.c (clear_image_cache): Now static.
9795 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9796 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9797 (x_edge_detection): Remove unnecessary cast that
9798 gcc -Wbad-function-cast diagnoses.
9799 (gif_load): Fix pointer signedness.
9800 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9801 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9803 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9805 Improve quality of tests for time stamp overflow.
9806 For example, without this patch (encode-time 0 0 0 1 1
9807 1152921504606846976) returns the obviously-bogus value (-948597
9808 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9809 reports time overflow. See
9810 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9811 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9812 * editfns.c: Include limits.h and intprops.h.
9813 (TIME_T_MIN, TIME_T_MAX): New macros.
9814 (time_overflow): Move earlier, to before first use.
9815 (hi_time, lo_time): New functions, for an accurate test for
9817 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9818 (Fget_internal_run_time): Don't assume time_t fits in int.
9819 (make_time): Use list2 instead of Fcons twice.
9820 (Fdecode_time): More accurate test for out-of-range times.
9821 (check_tm_member): New function.
9822 (Fencode_time): Use it, to test for out-of-range times.
9823 (lisp_time_argument): Don't rely on undefined left-shift and
9824 right-shift behavior when checking for time stamp overflow.
9826 * editfns.c (time_overflow): New function, refactoring common code.
9827 (Fformat_time_string, Fdecode_time, Fencode_time):
9828 (Fcurrent_time_string): Use it.
9830 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9831 * dired.c (make_time): Move to ...
9832 * editfns.c (make_time): ... here.
9833 * systime.h: Note the move.
9835 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9837 * fringe.c (update_window_fringes): Remove unused variables.
9839 * unexmacosx.c (copy_data_segment): Also copy __got section.
9842 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9844 * termcap.c [MSDOS]: Include "msdos.h".
9845 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9846 Constify `char *' arguments and their references according to
9847 prototypes in tparam.h.
9849 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9851 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9852 Adapt all references accordingly.
9854 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9856 2011-03-11 Tom Tromey <tromey@redhat.com>
9858 * buffer.c (syms_of_buffer): Remove obsolete comment.
9860 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9862 * termhooks.h (encode_terminal_code): Declare prototype.
9864 * msdos.c (encode_terminal_code): Don't declare prototype.
9866 * term.c (encode_terminal_code): Now external again, used by
9867 w32console.c and msdos.c.
9869 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9870 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9872 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9874 Fix some minor problems found by GCC 4.5.2's static checks.
9876 * fringe.c (update_window_fringes): Mark locals as initialized
9878 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9880 * alloc.c (mark_fringe_data): Move decl from here ...
9881 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9882 to check its interface.
9883 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9885 * fontset.c (free_realized_fontset): Now static.
9886 (Fset_fontset_font): Rename local to avoid shadowing.
9887 (fontset_font): Mark local as initialized.
9888 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9890 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9892 * xselect.c (x_disown_buffer_selections): Remove; not used.
9893 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9894 (x_own_selection, Fx_disown_selection_internal): Rename locals
9896 (x_handle_dnd_message): Remove local to avoid shadowing.
9898 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9899 so that the caller can use some name other than gcpro1.
9900 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9901 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9902 (Fx_backspace_delete_keys_p):
9903 Use them to avoid shadowing, and rename vars to avoid shadowing.
9904 (x_decode_color, x_set_name, x_window): Now static.
9905 (Fx_create_frame): Add braces to silence GCC warning.
9906 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9907 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9908 Remove unused locals.
9909 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9910 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9911 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9914 * xterm.h (x_mouse_leave): New decl.
9916 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9917 Remove unused functions.
9918 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9919 (x_calc_absolute_position): Now static.
9920 (XTread_socket): Don't define label "out" unless it's used.
9921 Don't declare local "event" unless it's used.
9922 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9923 unless they are used.
9924 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9925 (x_fatal_error_signal): Remove; not used.
9926 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9927 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9928 (x_error_catcher, x_connection_closed, x_error_handler):
9929 (x_error_quitter, xembed_send_message, x_iconify_frame):
9930 (my_log_handler): Rename locals to avoid shadowing.
9931 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9932 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9934 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9935 Rename or move locals to avoid shadowing.
9936 (tty_defined_color, merge_face_heights): Now static.
9937 (free_realized_faces_for_fontset): Remove; not used.
9938 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9939 does not deduce is never used uninitialized.
9940 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9941 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9943 * terminal.c (store_terminal_param): Now static.
9945 * xmenu.c (menu_highlight_callback): Now static.
9946 (set_frame_menubar): Remove unused local.
9947 (xmenu_show): Rename parameter to avoid shadowing.
9948 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9949 since they might point to immutable storage.
9950 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9951 since it's unused otherwise.
9953 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9954 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9955 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9956 avoids a gcc -Wuninitialized diagnostic.
9957 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9958 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9959 does not deduce are never used uninitialized.
9961 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9963 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9964 * window.c (window_loop, size_window):
9965 (run_window_configuration_change_hook, enlarge_window): Likewise.
9967 * window.c (display_buffer): Now static.
9968 (size_window): Mark variables that gcc -Wuninitialized
9969 does not deduce are never used uninitialized.
9970 * window.h (check_all_windows): New decl, to forestall
9971 gcc -Wmissing-prototypes diagnostic.
9972 * dispextern.h (bidi_dump_cached_states): Likewise.
9974 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9976 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9978 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9979 and to avoid gcc -Wuninitialized warning.
9980 (load_charset_map): Mark variables that gcc -Wuninitialized
9981 does not deduce are never used uninitialized.
9982 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9984 * coding.c (coding_set_source, coding_set_destination):
9985 Use "else { /* comment */ }" rather than "else /* comment */;"
9986 for clarity, and to avoid gcc -Wempty-body warning.
9987 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9988 a block, when the outer 'i' will do.
9989 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9990 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9991 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9992 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9993 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9994 Rename locals to avoid shadowing.
9995 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9996 * coding.c (emacs_mule_char, encode_invocation_designation):
9997 Now static, since they're not used elsewhere.
9998 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9999 (decode_coding_object, encode_coding_object, detect_coding_system):
10000 (decode_coding_emacs_mule): Mark variables that gcc
10001 -Wuninitialized does not deduce are never used uninitialized.
10002 (detect_coding_iso_2022): Initialize a local variable that might
10003 be used uninitialized. Leave a FIXME because it's not clear that
10004 this initialization is needed. (Bug#8211)
10005 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
10006 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
10007 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
10008 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
10009 Remove unused macros.
10011 * category.c (hash_get_category_set): Remove unused local var.
10012 (copy_category_table): Now static, since it's not used elsewhere.
10013 * character.c (string_count_byte8): Likewise.
10015 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
10016 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
10018 * chartab.c (copy_sub_char_table): Now static, since it's not used
10020 (sub_char_table_ref_and_range, char_table_ref_and_range):
10021 Rename locals to avoid shadowing.
10022 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
10024 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
10025 (BIDI_BOB): Remove unused macro.
10027 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
10028 deduce are never used uninitialized.
10029 * term.c (encode_terminal_code): Likewise.
10031 * term.c (encode_terminal_code): Now static. Remove unused local.
10033 * tparam.h: New file.
10034 * term.c, tparam.h: Include it.
10035 * deps.mk (term.o, tparam.o): Depend on tparam.h.
10036 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
10037 Move these decls to tparam.h, and make them agree with what
10038 is actually in tparam.c. The previous trick of using incompatible
10039 decls in different modules does not conform to the C standard.
10040 All callers of tparam changed to use tparam's actual API.
10041 * tparam.c (tparam1, tparam, tgoto):
10042 Use const pointers where appropriate.
10044 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
10045 * cm.h (struct cm): Likewise.
10046 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
10047 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
10048 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
10049 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
10050 (turn_on_face, init_tty): Likewise.
10051 * termchar.h (struct tty_display_info): Likewise.
10053 * term.c (term_mouse_position): Rename local to avoid shadowing.
10055 * alloc.c (mark_ttys): Move decl from here ...
10056 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
10058 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
10060 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
10062 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
10064 * search.c (compile_pattern_1): Remove argument regp, unused since
10065 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
10066 (compile_pattern): Don't pass it.
10068 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
10070 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
10071 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
10073 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
10075 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
10077 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
10078 gdk_window_get_screen, gdk_window_get_geometry,
10079 gdk_x11_window_lookup_for_display and GDK_KEY_g.
10080 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
10081 (xg_get_pixbuf_from_pixmap): New function.
10082 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
10083 to Pixmap, take frame as parameter, remove GdkColormap parameter.
10084 Call xg_get_pixbuf_from_pixmap instead of
10085 gdk_pixbuf_get_from_drawable.
10086 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
10087 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
10088 (xg_check_special_colors): Use GtkStyleContext and its functions
10090 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
10091 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
10092 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
10093 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
10094 Call gtk_widget_get_preferred_size.
10095 (xg_frame_resized): gdk_window_get_geometry only takes 5
10097 (xg_win_to_widget, xg_event_is_for_menubar):
10098 Call gdk_x11_window_lookup_for_display.
10099 (xg_set_widget_bg): New function.
10100 (delete_cb): New function.
10101 (xg_create_frame_widgets): Connect delete-event to delete_cb.
10102 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
10103 (xg_set_background_color): Call xg_set_widget_bg.
10104 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
10105 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
10106 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
10107 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
10109 (update_frame_tool_bar): Call gtk_widget_hide.
10110 (xg_initialize): Use GDK_KEY_g.
10112 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
10114 (x_session_initialize): Call gdk_x11_set_sm_client_id.
10116 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
10117 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
10118 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
10120 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
10122 * w32xfns.c (select_palette): Check success of RealizePalette against
10123 GDI_ERROR, not zero.
10125 See ChangeLog.11 for earlier changes.
10127 ;; Local Variables:
10131 Copyright (C) 2011-2012 Free Software Foundation, Inc.
10133 This file is part of GNU Emacs.
10135 GNU Emacs is free software: you can redistribute it and/or modify
10136 it under the terms of the GNU General Public License as published by
10137 the Free Software Foundation, either version 3 of the License, or
10138 (at your option) any later version.
10140 GNU Emacs is distributed in the hope that it will be useful,
10141 but WITHOUT ANY WARRANTY; without even the implied warranty of
10142 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10143 GNU General Public License for more details.
10145 You should have received a copy of the GNU General Public License
10146 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.