1 2012-06-12 Glenn Morris <rgm@gnu.org>
3 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
5 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
7 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
8 Move BROKEN_SIGIO to configure.
10 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
11 Move NO_TERMIO to configure.
13 2012-06-12 Chong Yidong <cyd@gnu.org>
15 * image.c (imagemagick_load_image): Use MagickFlattenImage if
16 MagickMergeImageLayers is undefined. Use pixel pusher loop if
17 MagickExportImagePixels is undefined.
19 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
21 * image.c (imagemagick_load_image): Remove unused label.
23 2012-06-11 Glenn Morris <rgm@gnu.org>
25 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
26 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
27 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
28 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
30 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
32 * alloc.c (make_byte_code): New function.
33 (Fmake_byte_code): Use it. Don't purify here.
34 * lread.c (read1): Use it as well to avoid extra allocation.
36 2012-06-11 Chong Yidong <cyd@gnu.org>
38 * image.c (imagemagick_load_image): Implement transparency.
40 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
42 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
43 account for preceding backslashes. (Bug#11663)
45 2012-06-09 Chong Yidong <cyd@gnu.org>
47 * term.c: Support italics in capable terminals (Bug#9652).
48 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
49 (turn_on_face): Output using TS_enter_italic_mode if available.
50 Don't handle unused blinking and alt-charset cases.
51 (turn_off_face): Handle italic case; discard unused tty_blinking_p
52 and tty_alt_charset_p cases.
53 (tty_capable_p, init_tty): Support italics.
55 * termchar.h (struct tty_display_info): Add field for italics.
56 Remove unused blink field.
58 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
61 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
62 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
63 tty_alt_charset_p. Add tty_italic_p.
65 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
67 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
68 dbus_type_is_basic if available.
69 (xd_extract_signed, xd_extract_unsigned): Rename from
70 extract_signed and extract_unsigned, respectively. Adapt callers.
72 2012-06-09 Chong Yidong <cyd@gnu.org>
74 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
76 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
79 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
81 * xdisp.c (vmessage): Treat frame message as multibyte.
82 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
83 would generate the diagnostic "Making \302\247 buffer-local while
86 2012-06-08 Eli Zaretskii <eliz@gnu.org>
88 * dispnew.c (showing_window_margins_p): Undo last change, which
89 was done due to an inadvertent commit.
90 (adjust_frame_glyphs_for_frame_redisplay): Do call
91 showing_window_margins_p.
93 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
95 * eval.c (Fmake_var_non_special): New primitive.
96 (syms_of_eval): Defsubr it.
97 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
99 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
101 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
102 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
104 2012-06-08 Eli Zaretskii <eliz@gnu.org>
106 * alloc.c (allocate_vectorlike): Fix last change.
108 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
110 Block-based vector allocation of small vectors.
111 * lisp.h (struct vectorlike_header): New field `nbytes',
112 adjust comment accordingly.
113 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
114 to denote vector blocks. Adjust users (live_vector_p,
115 mark_maybe_pointer, valid_lisp_object_p) accordingly.
116 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
117 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
118 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
119 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
120 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
121 (roundup_size): New constant.
122 (struct vector_block): New data type.
123 (vector_blocks, vector_free_lists, zero_vector): New variables.
124 (all_vectors): Rename to `large_vectors'.
125 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
126 (sweep_vectors): New functions.
127 (allocate_vectorlike): Return `zero_vector' as the only vector of
128 0 items. Allocate new vector from block if vector size is less than
129 or equal to VBLOCK_BYTES_MAX.
130 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
131 (init_alloc_once): Add call to init_vectors.
133 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
135 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
137 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
139 * doprnt.c (doprnt): Truncate multibyte char correctly.
140 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
141 would mishandle a string argument "Xc" if X was a multibyte
142 character of length 2: it would truncate after X's first byte
143 rather than including all of X.
145 2012-06-06 Chong Yidong <cyd@gnu.org>
147 * buffer.c (word_wrap): Doc fix.
149 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
151 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
153 2012-06-03 Glenn Morris <rgm@gnu.org>
155 * xdisp.c (tool-bar-style): Doc fix.
157 2012-06-03 Ulrich Müller <ulm@gentoo.org>
159 * Makefile.in (PAXCTL): Define.
160 (temacs$(EXEEXT)): Disable memory randomization for the temacs
161 binary via PaX flags if the paxctl utility is available.
162 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
163 Restore PaX flags to their default. (Bug#11398)
165 2012-06-03 Chong Yidong <cyd@gnu.org>
167 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
170 2012-06-03 Chong Yidong <cyd@gnu.org>
172 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
173 (note_mode_line_or_margin_highlight): If there is no help echo,
174 use mode-line-default-help-echo. Handle the case where the mouse
175 position is past the end of the mode line string.
177 * buffer.c (buffer_local_value_1): New function, split from
178 Fbuffer_local_value; can return Qunbound.
179 (Fbuffer_local_value): Use it.
180 (Vmode_line_format): Docstring tweaks.
182 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
184 * sysdep.c (system_process_attributes): Improve comment.
186 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
188 * keyboard.c: Export real-this-command to Elisp.
189 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
190 and DEFVAR it. Update all users.
192 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
194 * minibuf.c (Fassoc_string): Remove duplicate declaration.
196 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
197 Convert pctcpu and pctmem to Lisp float properly.
198 Let the compiler fold better, as 100.0/0x8000 is exact.
200 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
202 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
205 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
207 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
209 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
211 For a 'struct window', replace some Lisp_Object fields to
212 bitfields where appropriate, remove unused fields.
213 * window.h (struct window): Remove unused 'last_mark_x' and
214 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
215 change it's type from Lisp_Object to bitfield.
216 Change type of 'force_start', 'optional_new_start',
217 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
218 fields from Lisp_Object to bitfield. Adjust users accordingly.
220 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
222 Pacify gcc -Wdouble-precision when using Xaw.
223 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
224 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
225 Use 'float' consistently, rather than 'float' in most places
226 and 'double' in a couple of places.
228 2012-05-31 Eli Zaretskii <eliz@gnu.org>
230 * xdisp.c (handle_stop): Detect whether we have overlay strings
231 loaded by testing it->current.overlay_string_index to be
232 non-negative, instead of checking whether n_overlay_strings is
233 positive. (Bug#11587)
235 2012-05-31 Chong Yidong <cyd@gnu.org>
237 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
239 * doc.c (Fsubstitute_command_keys): Doc fix.
241 2012-05-31 Eli Zaretskii <eliz@gnu.org>
243 * search.c (search_buffer): Remove calls to
244 r_alloc_inhibit_buffer_relocation, as it is now called by
245 maybe_unify_char, which was the cause of relocation of buffer text
248 2012-05-31 Eli Zaretskii <eliz@gnu.org>
250 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
251 for the duration of call to load_charset, to avoid problems with
252 callers of maybe_unify_char that access buffer text through C
255 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
256 decrement the inhibition flag, instead of just setting or
259 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
261 Remove obsolete '#define static' cruft.
262 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
263 This #undef was "temporary" in 2000; it is no longer needed
264 now that '#define static' has gone away.
265 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
266 (gray_bitmap_bits): Remove; no longer needed.
267 All uses replaced with definiens.
268 * xterm.c: Include "bitmaps/gray.xbm".
270 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
272 Clean up __executable_start, monstartup when --enable-profiling.
273 The following changes affect the code only when profiling.
274 * dispnew.c (__executable_start): Rename from safe_bcopy.
275 Define only on platforms that need it.
276 * emacs.c: Include <sys/gmon.h> when profiling.
277 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
278 (__executable_start): Remove decl, since lisp.h does it now.
279 (safe_bcopy): Remove decl; no longer has that name.
280 (main): Coalesce #if into single bit of code, for simplicity.
281 Cast pointers to uintptr_t, since standard libraries want integers
283 * lisp.h (__executable_start): New decl.
285 2012-05-31 Glenn Morris <rgm@gnu.org>
287 * image.c (Fimagemagick_types): Doc fix.
289 2012-05-30 Jim Meyering <meyering@redhat.com>
291 * callproc.c (Fcall_process_region): Include directory component
292 in mkstemp error message (Bug#11586).
294 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
296 * alloc.c, lisp.h (make_pure_vector): Now static.
298 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
300 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
302 (Fautoload): Do the hash-doc more carefully.
303 * data.c (Fdefalias): Purify definition, except for keymaps.
304 (Qdefun): Move from eval.c.
305 * lisp.h (Qdefun): Remove.
306 * lread.c (read1): Tiny simplification.
308 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
310 Do not create empty overlays with the evaporate property (Bug#9642).
311 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
312 Bug#9642, but explicitly check that the buffer the overlay would
313 be moved to is live and rearrange lines to make sure that errors
314 will not put the overlay in an inconsistent state.
315 (Fdelete_overlay): Cosmetics.
317 2012-05-28 Eli Zaretskii <eliz@gnu.org>
319 * w32term.c (my_bring_window_to_top): New function.
320 (x_raise_frame): Use handle returned by DeferWindowPos, which
321 could be different from the original one.
322 Call my_bring_window_to_top instead of my_set_foreground_window.
325 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
326 by calling BringWindowToTop.
328 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
329 (WM_EMACS_END): Increase by one.
331 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
333 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
334 This avoids undefined behavior that might cause the eassert
335 to not catch an out-of-range value.
337 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
339 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
342 2012-05-27 Eli Zaretskii <eliz@gnu.org>
344 * bidi.c (bidi_mirror_char): Fix last change.
346 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
348 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
349 when referring to sectname field in printf format.
351 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
353 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
354 Only r_alloc_inhibit_buffer_relocation needed to be added;
355 the others were already declared.
357 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
358 before checking whether it's out of range. Put the check inside
360 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
362 2012-05-27 Ken Brown <kbrown@cornell.edu>
364 * callproc.c (Fcall_process): Restore a line that was accidentally
365 commented out in the 2011-02-13 change (bug#11547).
367 2012-05-27 Eli Zaretskii <eliz@gnu.org>
369 * lisp.h [REL_ALLOC]: Add prototypes for external functions
372 * buffer.c [REL_ALLOC]: Remove prototypes of
373 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
374 they are now on lisp.h.
376 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
378 * search.c (search_buffer): Use it to inhibit relocation of buffer
379 text while re_search_2 is doing its job, because re_search_2 is
380 passed C pointers to buffer text. (Bug#11519)
382 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
385 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
386 state after an additional call to move_it_in_display_line_to, keep
387 the values of it->max_ascent and it->max_descent found for the
389 (pos_visible_p): Revert the comparison against bottom_y to what it
390 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
393 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
395 Fix coding-related core dumps with gcc -ftrapv.
396 The code was computing A - B, where A and B are pointers, and B is
397 random garbage. This can lead to core dumps on platforms that
398 have special pointer registers, and it also leads to core dumps on
399 x86-64 when compiled with gcc -ftrapv. The fix is to compute
400 A - B only when B is initialized properly.
401 * coding.c (coding_set_source, coding_set_destination): Return void.
402 (coding_change_source, coding_change_destinations): New functions,
403 with the old behaviors of coding_set_source and coding_set_destination.
404 All callers that need an offset changed to use these new functions.
406 2012-05-26 Glenn Morris <rgm@gnu.org>
408 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
410 2012-05-26 Eli Zaretskii <eliz@gnu.org>
412 Extend mouse support on W32 text-mode console.
413 * xdisp.c (draw_row_with_mouse_face):
414 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
416 * w32console.c: Include window.h.
417 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
419 (initialize_w32_display): Initialize mouse-highlight data.
421 * w32inevt.c: Include termchar.h and window.h.
422 (do_mouse_event): Support mouse-autoselect-window. When the mouse
423 moves, call note_mouse_highlight. If help_echo changed, call
424 gen_help_event to produce help-echo message in the echo area.
425 Call clear_mouse_face if mouse_face_hidden is set in the mouse
428 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
430 * lread.c (read1): Simplify slightly to avoid an overflow warning
431 with GCC 4.7.0 on x86-64.
433 2012-05-26 Eli Zaretskii <eliz@gnu.org>
435 * bidi.c (bidi_mirror_char): Revert last change: an int is
436 definitely wide enough here.
438 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
440 Fix integer width and related bugs (Bug#9874).
441 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
442 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
443 (string_bytes, check_sblock, allocate_string_data):
444 (compact_small_strings, Fmake_bool_vector, make_string)
445 (make_unibyte_string, make_multibyte_string)
446 (make_string_from_bytes, make_specified_string)
447 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
448 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
450 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
451 (allocate_pseudovector):
452 Use int, not EMACS_INT, where int is wide enough.
453 (inhibit_garbage_collection, Fgarbage_collect):
454 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
455 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
456 int might not be wide enough.
457 (bidi_cache_search, bidi_cache_find, bidi_init_it)
458 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
459 (bidi_at_paragraph_end, bidi_find_paragraph_start)
460 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
461 (bidi_level_of_next_char, bidi_move_to_visually_next):
462 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
463 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
464 (Fkill_buffer, Fset_buffer_major_mode)
465 (advance_to_char_boundary, Fbuffer_swap_text)
466 (Fset_buffer_multibyte, overlays_at, overlays_in)
467 (overlay_touches_p, struct sortvec, record_overlay_string)
468 (overlay_strings, recenter_overlay_lists)
469 (adjust_overlays_for_insert, adjust_overlays_for_delete)
470 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
471 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
472 (Foverlay_recenter, last_overlay_modification_hooks_used)
473 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
474 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
475 (validate_region): Omit unnecessary test for b <= e,
476 since that's guaranteed by the previous test.
477 (adjust_overlays_for_delete): Avoid pos + length overflow.
478 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
479 (report_overlay_modification):
480 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
481 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
482 Omit pointer cast, which isn't needed anyway, and doesn't work
483 after the EMACS_INT -> ptrdiff_t change.
484 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
485 * buffer.h: Adjust decls to match defn changes elsewhere.
486 (struct buffer_text, struct buffer):
487 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
488 Use EMACS_INT, not int, where int might not be wide enough.
489 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
490 not int, to avoid needless 32-bit limit on 64-bit hosts.
491 (exec_byte_code): Use tighter memory-full test, one that checks
492 for alloca overflow. Don't compute the address of the object just
493 before an array, as that's not portable. Use EMACS_INT, not
494 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
495 * callint.c (Fcall_interactively):
496 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
497 * callproc.c (call_process_kill, Fcall_process):
498 Don't assume pid_t fits into an Emacs fixnum.
499 (call_process_cleanup, Fcall_process, child_setup):
500 Don't assume pid_t fits into int.
501 (call_process_cleanup, Fcall_process, delete_temp_file)
502 (Fcall_process_region):
503 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
504 (Fcall_process): Simplify handling of volatile integers.
505 Use int, not EMACS_INT, where int will do.
506 * casefiddle.c (casify_object, casify_region, operate_on_word)
507 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
508 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
509 (casify_object): Avoid integer overflow when overallocating buffer.
510 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
511 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
512 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
513 * category.h (CATEGORYP): Don't assume arg is nonnegative.
514 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
515 integers are now checked earlier. All uses replaced with XINT.
517 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
518 For CCL_MapSingle, check that content and value are in int range.
519 (ccl_driver, Fregister_code_conversion_map):
520 Check that Vcode_version_map_vector is a vector.
521 (resolve_symbol_ccl_program): Check that vector header is in range.
522 Always copy the vector, so that we can check its contents reliably
523 now rather than having to recheck each instruction as it's being
524 executed. Check that vector words fit in 'int'.
525 (ccl_get_compiled_code, Fregister_ccl_program)
526 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
527 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
528 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
529 contents are in range.
530 (Fccl_execute_on_string): Check that status is in range.
531 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
532 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
533 Accept and return EMACS_INT, not int, because callers can pass values
535 (c_string_width, strwidth, lisp_string_width, chars_in_text)
536 (multibyte_chars_in_text, parse_str_as_multibyte)
537 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
538 (str_as_unibyte, str_to_unibyte, string_count_byte8)
539 (string_escape_byte8, Fget_byte):
540 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
541 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
542 avoid mishandling large integers.
543 * character.h: Adjust decls to match defn changes elsewhere.
544 * charset.c (load_charset_map_from_file, find_charsets_in_text)
545 (Ffind_charset_region):
546 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
547 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
548 (load_charset_map_from_vector, Fdefine_charset_internal):
549 Don't assume fixnum fits in int.
550 (load_charset_map_from_vector, Fmap_charset_chars):
551 Remove now-unnecessary CHECK_NATNUMs.
552 (Fdefine_charset_internal): Check ranges here, more carefully.
553 Don't rely on undefined behavior with signed left shift overflow.
554 Don't assume unsigned int fits into fixnum, or that fixnum fits
555 into unsigned int. Don't require max_code to be a valid fixnum;
556 that's not true for gb10830 4-byte on a 32-bit host. Allow
557 invalid_code to be a cons, for the same reason. Require code_offset
558 to be a character. Avoid int overflow if max_char is close
560 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
561 this is intended anyway and avoids some undefined behavior.
562 (load_charset_map): Pass unsigned, not int, as 2nd arg of
563 INDEX_TO_CODE_POINT, as that's what it expects.
564 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
565 * charset.h (DECODE_CHAR): Return int, not unsigned;
566 this is what was intended anyway, and it avoids undefined behavior.
567 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
568 integer-overflow issues.
569 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
570 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
571 where the argument is EMACS_INT, and this behavior is not intended.
572 * chartab.c (Fmake_char_table, Fset_char_table_range)
573 (uniprop_get_decoder, uniprop_get_encoder):
574 Don't assume fixnum fits in int.
575 * cmds.c (move_point): New function, that does the gist of
576 Fforward_char and Fbackward_char, but does so while checking
577 for integer overflow more accurately.
578 (Fforward_char, Fbackward_char): Use it.
579 (Fforward_line, Fend_of_line, internal_self_insert)
580 (internal_self_insert):
581 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
582 Fix a FIXME, by checking for integer overflow when calculating
583 target_clm and actual_clm.
584 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
585 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
586 (ASSURE_DESTINATION, coding_alloc_by_realloc)
587 (coding_alloc_by_making_gap, alloc_destination)
588 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
589 (encode_coding_utf_16, detect_coding_emacs_mule)
590 (decode_coding_emacs_mule, encode_coding_emacs_mule)
591 (detect_coding_iso_2022, decode_coding_iso_2022)
592 (encode_invocation_designation, encode_designation_at_bol)
593 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
594 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
595 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
596 (encode_coding_ccl, encode_coding_raw_text)
597 (detect_coding_charset, decode_coding_charset)
598 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
599 (produce_composition, produce_charset, produce_annotation)
600 (decode_coding, handle_composition_annotation)
601 (handle_charset_annotation, consume_chars, decode_coding_gap)
602 (decode_coding_object, encode_coding_object, detect_coding_system)
603 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
604 (code_convert_region, code_convert_string)
605 (Fdefine_coding_system_internal)
606 (coding_set_source, coding_set_destination):
607 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
608 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
609 (Fdefine_coding_system_internal):
610 Don't assume fixnums fit in int.
611 (decode_coding_gap, decode_coding_object, encode_coding_object)
612 (Fread_coding_system, Fdetect_coding_region)
613 (Funencodable_char_position, Fcheck_coding_systems_region)
614 (get_translation, handle_composition_annotation, consume_chars):
615 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
616 (consume_chars): Rewrite to not calculate an address outside buffer.
617 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
618 Don't access memory outside of the args array.
619 (Fdefine_coding_system_internal): Check for charset-id overflow.
620 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
621 result of ENCODE_CHAR.
622 * coding.h: Adjust decls to match defn changes elsewhere.
623 (struct coding_system):
624 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
625 * composite.c (get_composition_id, find_composition)
626 (run_composition_function, update_compositions)
627 (compose_text, composition_gstring_put_cache)
628 (composition_gstring_p, composition_gstring_width)
629 (fill_gstring_header, fill_gstring_body, autocmp_chars)
630 (composition_compute_stop_pos, composition_reseat_it)
631 (composition_update_it, struct position_record)
632 (find_automatic_composition, composition_adjust_point)
633 (Fcomposition_get_gstring, Ffind_composition_internal):
634 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
635 (update_compositions):
636 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
637 * composite.h: Adjust decls to match defn changes elsewhere.
638 (struct composition):
639 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
640 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
641 Do not attempt to compute the address of the object just before a
642 buffer; this is not portable.
644 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
645 (Faset): Use int, not EMACS_INT, where int is wide enough.
646 (Fstring_to_number): Don't assume fixnums fit in int.
647 (Frem): Don't assume arg is nonnegative.
648 * dbusbind.c (xd_append_arg): Check for integers out of range.
649 (Fdbus_call_method): Don't overflow the timeout int.
650 (extract_signed, extract_unsigned): New functions.
651 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
652 (xd_get_connection_references): Return ptrdiff_t, not int.
654 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
656 Use int, not unsigned, where the dbus API uses int.
657 (Fdbus_message_internal): Don't overflow mtype.
658 (syms_of_dbusbind): Allocate right-sized buffer for integers.
659 * dired.c (directory_files_internal, file_name_completion, scmp)
660 (file_name_completion_stat):
661 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
662 (file_name_completion): Don't overflow matchcount.
663 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
664 * dispextern.h: Adjust decls to match defn changes elsewhere.
665 (struct text_pos, struct glyph, struct bidi_saved_info)
666 (struct bidi_string_data, struct bidi_it, struct composition_it)
668 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
669 (struct display_pos, struct composition_it, struct it):
670 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
671 * dispnew.c (increment_matrix_positions)
672 (increment_row_positions, mode_line_string)
673 (marginal_area_string):
674 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
675 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
676 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
677 (duration_to_sec_usec): New function, to check for overflow better.
678 (Fsleep_for, sit_for): Use it.
679 * doc.c (get_doc_string, store_function_docstring):
680 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
681 (get_doc_string, Fsnarf_documentation):
682 Use int, not EMACS_INT, where int is wide enough.
684 Use SAFE_ALLOCA, not alloca.
685 Check for overflow when converting EMACS_INT to off_t.
687 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
688 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
689 Don't assume uid_t fits into fixnum.
690 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
691 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
692 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
693 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
694 (general_insert_function)
695 (Finsert_char, make_buffer_string, make_buffer_string_both)
696 (update_buffer_properties, Fbuffer_substring)
697 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
698 (Fsubst_char_in_region, check_translation)
699 (Ftranslate_region_internal, save_restriction_restore, Fformat)
700 (transpose_markers, Ftranspose_regions):
701 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
702 (clip_to_bounds): Move to lisp.h as an inline function).
703 (Fconstrain_to_field): Don't assume integers are nonnegative.
704 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
705 (Fsubst_char_in_region, Fsave_restriction):
706 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
707 (Femacs_pid): Don't assume pid_t fits into fixnum.
708 (lo_time): Use int, not EMACS_INT, when int suffices.
709 (lisp_time_argument): Check for usec out of range.
710 (Fencode_time): Don't assume fixnum fits in int.
711 (Fuser_login_name, Fuser_full_name): Signal an error
712 if a uid argument is out of range, rather than relying on
714 (Fformat_time_string): Remove now-unnecessary check.
715 lisp_time_argument checks for out-of-range usec now.
716 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
717 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
718 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
719 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
720 (init_cmdargs, Fdump_emacs):
721 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
722 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
723 the bottom (typically) 32 bits of the fixnum.
724 * eval.c (specpdl_size, call_debugger):
725 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
726 (when_entered_debugger, Fbacktrace_debug):
727 Don't assume fixnum can fit in int.
728 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
729 the object just before a buffer; this is not portable.
730 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
731 (grow_specpdl, unbind_to):
732 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
733 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
734 (grow_specpdl): Simplify allocation by using xpalloc.
735 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
736 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
737 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
738 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
739 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
741 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
742 (Fcopy_file, non_regular_nbytes, read_non_regular)
743 (Finsert_file_contents):
744 Use int, not EMACS_INT, where int is wide enough.
745 (READ_BUF_SIZE): Verify that it fits in int.
746 (Finsert_file_contents): Check that counts are in proper range,
747 rather than assuming fixnums fit into ptrdiff_t etc.
748 Don't assume fixnums fit into int.
749 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
750 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
751 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
752 (string_char_to_byte, string_byte_to_char)
753 (string_make_multibyte, string_to_multibyte)
754 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
755 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
756 (substring_both, Fdelete, internal_equal, Ffillarray)
757 (Fclear_string, mapcar1)
758 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
759 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
760 (larger_vector, make_hash_table, maybe_resize_hash_table)
761 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
762 (Fmaphash, secure_hash):
763 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
764 (concat): Check for string index and length overflow.
765 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
767 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
768 (larger_vector): New API (vec, incr_min, size_max) replaces old
769 one (vec, new_size, init). This catches size overflow.
770 INIT was removed because it was always Qnil.
772 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
773 the upper bound on a hash table index size.
774 (make_hash_table, maybe_resize_hash_table): Use it.
775 (secure_hash): Computer start_byte and end_byte only after
776 they're known to be in ptrdiff_t range.
777 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
778 (Ffont_get_glyphs, Ffont_at):
779 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
780 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
781 (Flist_fonts, Fopen_font):
782 Don't assume fixnum can fit in int.
783 (check_gstring): Don't assume index can fit in int.
784 (font_match_p): Check that fixnum is a character, not a nonnegative
785 fixnum, since the later code needs to stuff it into an int.
786 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
787 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
788 conversion overflow issues.
789 (Fopen_font): Check for integer out of range.
790 (Ffont_get_glyphs): Don't assume index can fit in int.
791 * font.h: Adjust decls to match defn changes elsewhere.
792 * fontset.c (reorder_font_vector): Redo score calculation to avoid
794 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
795 printmax_t, where ptrdiff_t is wide enough.
796 (Finternal_char_font):
797 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
798 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
799 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
800 (Fset_frame_position, x_set_frame_parameters)
801 (x_set_line_spacing, x_set_border_width)
802 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
803 Check that fixnums are in proper range for system types.
804 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
805 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
806 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
807 Use SAFE_ALLOCA_LISP, not alloca.
808 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
809 intptr_t is wide enough.
810 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
811 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
812 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
813 Check for fixnum out of range.
814 * ftfont.c (ftfont_list): Don't assume index fits in int.
815 Check that fixnums are in proper range for system types.
816 (ftfont_shape_by_flt):
817 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
818 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
819 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
820 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
821 Check that fixnums are in proper range for system types.
822 * gnutls.h: Adjust decls to match defn changes elsewhere.
823 * gtkutil.c (xg_dialog_run):
824 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
825 (update_frame_tool_bar):
826 Check that fixnums are in proper range for system types.
827 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
828 (lookup_image): Check that fixnums are in range for system types.
829 * indent.c (last_known_column, last_known_column_point):
830 (current_column_bol_cache):
831 (skip_invisible, current_column, check_display_width):
832 (check_display_width, scan_for_column, current_column_1)
833 (Findent_to, Fcurrent_indentation, position_indentation)
834 (indented_beyond_p, Fmove_to_column, compute_motion):
835 (Fcompute_motion, Fvertical_motion):
836 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
837 (last_known_column_modified): Use EMACS_INT, not int.
838 (check_display_width):
840 Check that fixnums and floats are in proper range for system types.
841 (compute_motion): Don't assume index or fixnum fits in int.
842 (compute_motion, Fcompute_motion):
843 Use int, not EMACS_INT, when it is wide enough.
844 (vmotion): Omit local var start_hpos that is always 0; that way
845 we don't need to worry about overflow in expressions involving it.
846 * indent.h: Adjust decls to match defn changes elsewhere.
848 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
849 Use int, not EMACS_INT, where int is wide enough.
850 Remove unused members ovstring_chars_done and tab_offset;
852 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
853 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
854 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
855 (make_gap, copy_text, insert, insert_and_inherit)
856 (insert_before_markers, insert_before_markers_and_inherit)
857 (insert_1, count_combining_before, count_combining_after)
858 (insert_1_both, insert_from_string)
859 (insert_from_string_before_markers, insert_from_string_1)
860 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
861 (adjust_after_replace, adjust_after_insert, replace_range)
862 (replace_range_2, del_range, del_range_1, del_range_byte)
863 (del_range_both, del_range_2, modify_region)
864 (prepare_to_modify_buffer, signal_before_change)
865 (signal_after_change, Fcombine_after_change_execute):
866 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
867 * intervals.c (traverse_intervals, rotate_right, rotate_left)
868 (balance_an_interval, split_interval_right, split_interval_left)
869 (find_interval, next_interval, update_interval)
870 (adjust_intervals_for_insertion, delete_node, delete_interval)
871 (interval_deletion_adjustment, adjust_intervals_for_deletion)
872 (static_offset_intervals, offset_intervals)
873 (merge_interval_right, merge_interval_left, make_new_interval)
874 (graft_intervals_into_buffer, temp_set_point_both)
875 (temp_set_point, set_point, adjust_for_invis_intang)
876 (set_point_both, move_if_not_intangible, get_property_and_range)
877 (get_local_map, copy_intervals, copy_intervals_to_string)
878 (compare_string_intervals, set_intervals_multibyte_1):
879 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
880 * intervals.h: Adjust decls to match defn changes elsewhere.
882 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
883 * keyboard.c (this_command_key_count, this_single_command_key_start)
884 (before_command_key_count, before_command_echo_length, echo_now)
885 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
886 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
887 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
888 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
889 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
890 (last_non_minibuf_size, last_point_position, echo_truncate)
891 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
892 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
893 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
894 (stuff_buffered_input):
895 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
896 (last_auto_save, command_loop_1, read_char):
897 Use EMACS_INT, not int, to avoid integer overflow.
898 (record_char): Avoid overflow in total_keys computation.
899 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
900 * keyboard.h: Adjust decls to match defn changes elsewhere.
901 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
902 (Fkey_description, Fdescribe_vector, Flookup_key):
903 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
904 (click_position): New function, to check that positions are in range.
905 (Fcurrent_active_maps):
907 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
908 (Faccessible_keymaps, Fkey_description):
909 (preferred_sequence_p):
910 Don't assume fixnum can fit into int.
911 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
912 Check for integer overflow in size calculations.
913 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
914 avoid mishandling large integers.
915 * lisp.h: Adjust decls to match defn changes elsewhere.
916 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
917 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
918 (struct Lisp_Marker):
919 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
920 (clip_to_bounds): Now an inline function, moved here from editfns.c.
921 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
922 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
924 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
925 Assume the arg has valid form, since it always does.
926 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
927 unsigned integer system type.
928 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
929 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
930 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
931 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
932 (duration_to_sec_usec): New decl.
933 * lread.c (read_from_string_index, read_from_string_index_byte)
934 (read_from_string_limit, readchar, unreadchar, openp)
935 (read_internal_start, read1, oblookup):
936 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
937 (Fload, readevalloop, Feval_buffer, Feval_region):
938 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
939 (openp): Check for out-of-range argument to 'access'.
940 (read1): Use int, not EMACS_INT, where int is wide enough.
941 Don't assume fixnum fits into int.
942 Fix off-by-one error that can read outside a buffer.
943 (read_filtered_event): Use duration_to_sec_usec
944 to do proper overflow checking on durations.
945 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
947 (Fexecute_kbd_macro):
948 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
949 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
950 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
951 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
952 (set_marker_both, set_marker_restricted_both, marker_position)
953 (marker_byte_position, Fbuffer_has_markers_at):
954 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
955 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
956 * menu.c (ensure_menu_items): Rename from grow_menu_items.
957 It now merely ensures that the menu is large enough, without
958 necessarily growing it, as this avoids some integer overflow issues.
960 (keymap_panes, parse_single_submenu, Fx_popup_menu):
961 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
962 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
963 Use SAFE_ALLOCA_LISP, not alloca.
964 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
965 to EMACS_INT. Check that fixnums are in proper range for system types.
966 * minibuf.c (minibuf_prompt_width, string_to_object)
967 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
968 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
969 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
970 (get_minibuffer, read_minibuf_unwind):
971 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
972 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
973 this simplifies overflow checking. All callers changed.
974 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
976 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
978 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
979 Check that fixnums are in proper range for system types.
980 (Fx_create_frame, Fx_show_tip):
981 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
982 * nsfont.m (ns_findfonts, nsfont_list_family):
983 Don't assume fixnum fits in long.
984 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
985 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
986 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
988 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
989 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
990 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
991 (PRINTDECLARE, PRINTPREPARE):
992 (strout, print_string):
993 (print, print_preprocess, print_check_string_charset_prop)
995 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
997 (temp_output_buffer_setup, Fprin1_to_string, print_object):
998 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
999 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
1000 (printchar, strout): Use xpalloc to catch size calculation overflow.
1001 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
1002 (print_error_message): Use SAFE_ALLOCA, not alloca.
1003 (print_object): Use int, not EMACS_INT, where int is wide enough.
1004 (print_depth, new_backquote_output, print_number_index):
1005 Use ptrdiff_t, not int, where int might not be wide enough.
1006 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1007 (Fset_process_window_size, Fformat_network_address)
1008 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
1010 Check that fixnums are in proper range for system types.
1011 (Fsignal_process): Simplify by avoiding a goto.
1012 Check for process-ids out of pid_t range rather than relying on
1014 (process_tick, update_tick): Use EMACS_INT, not int.
1015 (Fformat_network_address, read_process_output, send_process)
1016 (Fprocess_send_region, status_notify):
1017 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1018 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1019 (wait_reading_process_output, read_process_output, exec_sentinel):
1020 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1021 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1022 (Faccept_process_output): Use duration_to_sec_usec to do proper
1023 overflow checking on durations.
1024 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1025 Don't assume pid_t fits in int.
1026 * process.h (struct Lisp_Process): Members tick and update_tick
1027 are now of type EMACS_INT, not int.
1028 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1029 configured --with-wide-int.
1030 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1031 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1032 * search.c (looking_at_1, string_match_1):
1033 (fast_string_match, fast_c_string_match_ignore_case)
1034 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1035 (scan_newline, find_before_next_newline, search_command)
1036 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1037 (set_search_regs, wordify):
1040 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1041 (string_match_1, search_buffer, set_search_regs):
1043 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1044 (wordify): Check for overflow in size calculation.
1045 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1046 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1047 Check that fixnums are in proper range for system types.
1048 * sound.c (struct sound_device)
1049 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1050 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1051 (Fplay_sound_internal):
1052 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1053 * syntax.c (struct lisp_parse_state, find_start_modiff)
1054 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1055 (Fparse_partial_sexp):
1056 Don't assume fixnums can fit in int.
1057 (struct lisp_parse_state, find_start_pos, find_start_value)
1058 (find_start_value_byte, find_start_begv)
1059 (update_syntax_table, char_quoted, dec_bytepos)
1060 (find_defun_start, prev_char_comend_first, back_comment):
1061 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1062 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1063 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1064 (Finternal_describe_syntax_value): Check that match_lisp is a
1065 character, not an integer, since the code stuffs it into int.
1066 (scan_words, scan_sexps_forward):
1067 Check that fixnums are in proper range for system types.
1069 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1070 (scan_sexps_forward):
1071 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1072 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1073 * syntax.h: Adjust decls to match defn changes elsewhere.
1074 (struct gl_state_s):
1075 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1076 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1077 MOST_POSITIVE_FIXNUM.
1078 * sysdep.c (wait_for_termination_1, wait_for_termination)
1079 (interruptible_wait_for_termination, mkdir):
1080 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1081 (emacs_read, emacs_write):
1082 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1083 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1084 and double all fit in int.
1085 * term.c (set_tty_color_mode):
1086 Check that fixnums are in proper range for system types.
1087 * termhooks.h (struct input_event):
1088 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1089 * textprop.c (validate_interval_range, interval_of)
1090 (Fadd_text_properties, set_text_properties_1)
1091 (Fremove_text_properties, Fremove_list_of_text_properties)
1092 (Ftext_property_any, Ftext_property_not_all)
1093 (copy_text_properties, text_property_list, extend_property_ranges)
1094 (verify_interval_modification):
1095 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1096 (Fnext_single_char_property_change)
1097 (Fprevious_single_char_property_change):
1098 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1099 (copy_text_properties):
1100 Check for integer overflow in index calculation.
1101 * undo.c (last_boundary_position, record_point, record_insert)
1102 (record_delete, record_marker_adjustment, record_change)
1103 (record_property_change):
1104 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1105 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1106 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1107 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1108 (Fx_hide_tip, Fx_file_dialog):
1109 * w32menu.c (set_frame_menubar):
1110 Use ptrdiff_t, not int, for consistency with rest of code.
1111 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1112 (select_window, Fdelete_other_windows_internal)
1113 (window_scroll_pixel_based, window_scroll_line_based)
1114 (Frecenter, Fset_window_configuration):
1115 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1116 (Fset_window_hscroll, run_window_configuration_change_hook)
1117 (set_window_buffer, temp_output_buffer_show, scroll_command)
1118 (Fscroll_other_window, Frecenter):
1119 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1120 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1121 Don't assume fixnum fits in int.
1122 (Fset_window_scroll_bars):
1123 Check that fixnums are in proper range for system types.
1124 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1125 (string_pos, c_string_pos, number_of_chars, init_iterator)
1126 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1127 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1128 (compute_display_string_end, handle_face_prop)
1129 (face_before_or_after_it_pos, handle_invisible_prop)
1130 (handle_display_prop, handle_display_spec, handle_single_display_spec)
1131 (display_prop_intangible_p, string_buffer_position_lim)
1132 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1133 (get_overlay_strings_1, get_overlay_strings)
1134 (iterate_out_of_display_property, forward_to_next_line_start)
1135 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1136 (get_next_display_element, set_iterator_to_next)
1137 (get_visually_first_element, compute_stop_pos_backwards)
1138 (handle_stop_backwards, next_element_from_buffer)
1139 (move_it_in_display_line_to, move_it_in_display_line)
1140 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1141 (add_to_log, message_dolog, message_log_check_duplicate)
1142 (message2, message2_nolog, message3, message3_nolog
1143 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1144 (current_message_1, truncate_echo_area, truncate_message_1)
1145 (set_message, set_message_1, store_mode_line_noprop)
1146 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1147 (text_outside_line_unchanged_p, check_point_in_composition)
1148 (reconsider_clip_changes)
1149 (redisplay_internal, set_cursor_from_row, try_scrolling)
1150 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1151 (redisplay_window, find_last_unchanged_at_beg_row)
1152 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1153 (trailing_whitespace_p, find_row_edges, display_line)
1154 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1155 (display_mode_element, store_mode_line_string)
1156 (pint2str, pint2hrstr, decode_mode_spec)
1157 (display_count_lines, display_string, draw_glyphs)
1158 (x_produce_glyphs, x_insert_glyphs)
1159 (rows_from_pos_range, mouse_face_from_buffer_pos)
1160 (fast_find_string_pos, mouse_face_from_string_pos)
1161 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1162 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1163 (safe_call, init_from_display_pos, handle_fontified_prop)
1164 (handle_single_display_spec, load_overlay_strings)
1165 (with_echo_area_buffer, setup_echo_area_for_printing)
1166 (display_echo_area, echo_area_display)
1167 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1168 (update_tool_bar, hscroll_window_tree, redisplay_internal)
1169 (redisplay_window, dump_glyph_row, display_mode_line)
1170 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
1171 (handle_display_spec, display_prop_string_p):
1172 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1173 (handle_single_display_spec, build_desired_tool_bar_string)
1174 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1175 (get_specified_cursor_type):
1176 Check that fixnums are in proper range for system types.
1177 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1178 (Flookup_image_map):
1179 Don't assume fixnums fit in int.
1180 (compare_overlay_entries):
1181 Avoid mishandling comparisons due to subtraction overflow.
1182 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1183 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1184 (handle_tool_bar_click):
1185 Use int, not unsigned, since we prefer signed and the signedness
1186 doesn't matter here.
1187 (get_next_display_element, next_element_from_display_vector):
1188 Use int, not EMACS_INT, when int is wide enough.
1189 (start_hourglass): Use duration_to_sec_usec to do proper
1190 overflow checking on durations.
1191 * xfaces.c (Fbitmap_spec_p):
1192 Check that fixnums are in proper range for system types.
1193 (compare_fonts_by_sort_order):
1194 Avoid mishandling comparisons due to subtraction overflow.
1195 (Fx_family_fonts, realize_basic_faces):
1196 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1198 Don't assume fixnum fits in int.
1199 Use SAFE_ALLOCA_LISP, not alloca.
1200 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1201 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1202 (face_at_buffer_position, face_for_overlay_string)
1203 (face_at_string_position):
1204 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1205 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1206 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1208 Check that fixnums are in proper range for system types.
1209 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1210 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1211 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1212 (Fx_change_window_property): Don't assume fixnums fit in int.
1213 * xfont.c (xfont_chars_supported):
1214 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1215 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1216 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1217 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1218 * xml.c (parse_region):
1219 * xrdb.c (magic_file_p):
1220 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1221 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1222 (x_get_local_selection, x_reply_selection_request)
1223 (x_handle_selection_request, wait_for_property_change):
1224 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1225 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1226 short is wide enough.
1227 (x_send_client_event): Don't assume fixnum fits in int.
1228 * xterm.c (x_x_to_emacs_modifiers):
1229 Don't assume EMACS_INT overflows nicely into int.
1230 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1232 (handle_one_xevent): NATNUMP can eval its arg twice.
1233 (x_connection_closed):
1234 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1235 * xterm.h: Adjust decls to match defn changes elsewhere.
1236 (struct scroll_bar): Use struct vectorlike_header
1237 rather than rolling our own approximation.
1238 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1240 2012-05-25 Glenn Morris <rgm@gnu.org>
1242 * lisp.mk (lisp): Update for more files being compiled now.
1244 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1246 * lread.c: Remove `read_pure' which makes no difference.
1247 (read_pure): Remove var.
1248 (unreadpure): Remove function.
1249 (readevalloop): Don't call read_list with -1 flag.
1250 (read1, read_vector): Don't test read_pure any more.
1251 (read_list): Simplify.
1253 * fileio.c, character.h: Minor style tweaks.
1255 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1257 * window.h (clip_changed): Remove useless declaration.
1259 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
1261 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1262 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1264 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1267 This directory predates autoconf and is no longer needed nowadays.
1268 Move its few remaining bits of functionality to where they're needed.
1269 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1270 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1271 * m/template.h: Remove.
1272 * Makefile.in (M_FILE): Remove. All uses removed.
1273 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1274 * lisp.h (USE_LSB_TAG):
1275 * mem-limits.h (EXCEEDS_LISP_PTR):
1276 Use VAL_MAX, not VALBITS, in #if.
1277 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1278 (EMACS_UINT): Define unconditionally now.
1279 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1280 (BITS_PER_EMACS_INT): New constants, replacing
1281 what used to be in config.h, but not useful in #if.
1282 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1283 define them any more.
1284 (VAL_MAX): New macro.
1286 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1287 BITS_PER_EMACS_INT, in #if.
1288 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1289 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1290 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1291 * s/ms-w32.h (DATA_START):
1292 Move here from removed file m/intel386.h.
1293 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1294 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1296 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1298 Assume C89 or later.
1299 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1300 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1302 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1303 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1304 * textprop.c, tparam.c (NULL): Remove.
1305 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1306 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1307 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1308 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1309 * xterm.c (input_signal_count): Assume volatile works.
1311 2012-05-21 Ken Brown <kbrown@cornell.edu>
1313 * xgselect.c (xg_select): Fix first argument in call to 'select'
1316 2012-05-20 Ken Brown <kbrown@cornell.edu>
1318 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
1319 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1321 2012-05-19 Ken Brown <kbrown@cornell.edu>
1323 * xfns.c (x_in_use): Remove `static' qualifier.
1324 * xterm.h (x_in_use): Declare.
1325 * xgselect.c: Include xterm.h.
1326 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1327 and `display_arg' (bug#9754).
1329 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1331 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1333 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1334 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1336 2012-05-18 Eli Zaretskii <eliz@gnu.org>
1338 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1340 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1341 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1343 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1344 reference to image_cache->refcount.
1345 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1347 2012-05-17 Juri Linkov <juri@jurta.org>
1349 * search.c (Fword_search_regexp, Fword_search_backward)
1350 (Fword_search_forward, Fword_search_backward_lax)
1351 (Fword_search_forward_lax): Move functions to isearch.el
1352 (bug#10145, bug#11381).
1354 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1356 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1358 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1360 * lread.c (init_obarray): Declare Qt and Qnil as special.
1362 2012-05-14 Glenn Morris <rgm@gnu.org>
1364 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
1365 Put "libexec" before "bin", for the sake of init_callproc_1.
1367 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1369 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1371 * unexaix.c: Port to more-recent AIX compilers.
1372 (report_error, report_error_1, make_hdr, copy_sym)
1373 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1374 Make arguments const char *, not char *, to avoid violations of C
1375 standard and to fix some AIX warnings reported by Gilles Pion.
1377 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1379 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1380 already have overlays loaded.
1381 (handle_single_display_spec): Before returning without displaying
1382 fringe bitmap, synchronize the bidi iterator with the main display
1383 iterator, by calling iterate_out_of_display_property.
1384 (iterate_out_of_display_property): Detect buffer iteration by
1385 testing that it->string is a Lisp string.
1386 (get_next_display_element): When the current object is exhausted,
1387 and there's something on it->stack, call set_iterator_to_next to
1388 proceed with what's on the stack, instead of returning zero.
1389 (set_iterator_to_next): If called at the end of a Lisp string,
1390 proceed to consider_string_end without incrementing string
1391 position. Don't increment display vector index past the end of
1392 the display vector. (Bug#11417)
1393 (pos_visible_p): Don't report a position visible when move_it_to
1394 stopped at the last line of window, which happens to be scanned
1395 backwards by the bidi iteration. (Bug#11464)
1397 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1399 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1400 and right-margin display specs even if the spec is invalid or we
1401 are on a TTY, and thus unable to display on the fringes.
1402 That's because the text with the property will not be displayed anyway,
1403 so we need to signal to the caller that this is a "replacing"
1404 display spec. This fixes display when the spec is invalid or we
1407 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1409 * unexaix.c (make_hdr): Fix typo in prototype.
1410 This bug broke the build on AIX. Problem reported by Gilles Pion.
1412 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
1414 * keyboard.c (kbd_buffer_get_event): Read special events also in
1415 batch mode. (Bug#11415)
1417 2012-05-12 Glenn Morris <rgm@gnu.org>
1419 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1421 2012-05-12 Eli Zaretskii <eliz@gnu.org>
1423 * lisp.mk (lisp): Add newcomment.elc.
1425 2012-05-12 Glenn Morris <rgm@gnu.org>
1427 * Makefile.in (MKDIR_P): New, set by configure.
1428 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1430 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1432 Remove unused function hourglass_started.
1433 * dispextern.h (hourglass_started):
1434 * w32fns.c (hourglass_started):
1435 * xdisp.c (hourglass_started): Remove.
1437 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
1439 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1440 Update dependencies.
1442 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1444 * xgselect.c (xg_select): Put maxfds+1 into a var.
1445 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1447 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1449 2012-05-10 Dave Abrahams <dave@boostpro.com>
1451 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1452 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1454 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
1456 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1457 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1458 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1459 Initialize xd_registered_buses.
1461 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1463 Untag more efficiently if USE_LSB_TAG.
1464 This is based on a proposal by YAMAMOTO Mitsuharu in
1465 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1466 For an admittedly artificial (nth 8000 longlist) benchmark on
1467 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1468 Emacs's overall text size by 1%.
1469 * lisp.h (XUNTAG): New macro.
1470 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1471 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1472 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1473 * eval.c (Fautoload):
1474 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1475 * frame.h (XFRAME): Use XUNTAG.
1477 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1478 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1479 Remove unportable assumptions about print widths of types like
1481 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1482 intptr_t when converting between pointer and integer, to avoid GCC
1483 warnings about wrong width.
1485 2012-05-09 Eli Zaretskii <eliz@gnu.org>
1487 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1488 stack for each reader_thread, instead of defaulting to 8MB
1489 determined by the linker. This avoids failures in creating
1490 subprocesses on Windows 7, see the discussion in this thread:
1491 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1493 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1495 Fix up display of the *Minibuf-0* buffer in the mini window.
1496 * keyboard.c (read_char): Don't clear the echo area if there's no
1498 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
1499 contents of *Minibuf-0*) if there's no message displayed in its stead.
1501 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
1503 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1506 2012-05-06 Chong Yidong <cyd@gnu.org>
1508 * lisp.mk (lisp): Update.
1510 2012-05-05 Jim Meyering <meyering@redhat.com>
1512 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1514 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1516 * data.c (PUT_ERROR): New macro.
1517 (syms_of_data): Use it. Add new error type `user-error'.
1518 * undo.c (user_error): New function.
1519 (Fprimitive_undo): Use it.
1520 * print.c (print_error_message): Adjust print style for `user-error'.
1521 * keyboard.c (user_error): New function.
1522 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1524 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1526 Do not limit current-time-string to years 1000..9999.
1527 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1528 (Fcurrent_time_string): Support any year that is supported by the
1529 underlying localtime representation. Don't use asctime, as it
1530 has undefined behavior for years outside the range -999..9999.
1532 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1534 Fix race conditions involving setenv, gmtime, localtime, asctime.
1535 Without this fix, interrupts could mess up code that uses these
1536 nonreentrant functions, since setting TZ invalidates existing
1537 tm_zone or tzname values, and since most of these functions return
1538 pointers to static storage.
1539 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1540 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1541 Grow the critical sections to include not just invoking
1542 localtime/gmtime, but also accessing these functions' results
1543 including their tm_zone values if any, and any related TZ setting.
1544 (format_time_string): Last arg is now struct tm *, not struct tm **,
1545 so that the struct tm is saved in the critical section.
1546 All callers changed. Simplify allocation of initial buffer, partly
1547 motivated by the fact that memory allocation needs to be outside
1548 the critical section.
1550 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1552 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1553 with RESET_INTERVAL.
1555 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1556 Remove duplicated buffer name initialization.
1558 2012-05-02 Jim Meyering <jim@meyering.net>
1560 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1562 * xfns.c (x_window): Use xstrdup (Bug#11375).
1564 2012-05-02 Eli Zaretskii <eliz@gnu.org>
1566 * xdisp.c (pos_visible_p): If already at a newline from the
1567 display string before the 'while' loop, don't walk back the glyphs
1568 from it3.glyph_row. Solves assertion violation when the display
1569 string begins with a newline (egg.el). (Bug#11367)
1571 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1573 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1576 2012-05-01 Glenn Morris <rgm@gnu.org>
1578 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1579 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1580 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1581 All were removed before 23.1.
1583 * dispnew.c: Remove HAVE_LIBNCURSES test;
1584 it is always true on relevant platforms.
1586 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1587 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1589 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1591 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1593 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1594 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1597 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1599 Do not avoid creating empty evaporating overlays (Bug#9642).
1600 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1601 That is, do not delete an evaporating overlay if it becomes
1602 empty after its bounds are adjusted to fit within its buffer.
1603 This fix caused other problems, and I'm reverting it until we get
1604 to the bottom of them.
1606 2012-04-27 Chong Yidong <cyd@gnu.org>
1608 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1610 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1612 * xdisp.c (pos_visible_p): If the window start position is beyond
1613 ZV, start the display from buffer beginning. Prevents assertion
1614 violation in init_iterator when the minibuffer window is scrolled
1617 * window.c (window_scroll_pixel_based): Likewise.
1619 2012-04-27 Chong Yidong <cyd@gnu.org>
1621 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1623 2012-04-27 Glenn Morris <rgm@gnu.org>
1625 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1626 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1628 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1630 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1631 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
1633 2012-04-26 Eli Zaretskii <eliz@gnu.org>
1635 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1636 display element, check also the underlying string or buffer
1637 character. (Bug#11341)
1639 * w32menu.c: Include w32heap.h.
1640 (add_menu_item): If the call to AppendMenuW (via
1641 unicode_append_menu) fails, disable Unicode menus only if we are
1642 running on Windows 9X/Me.
1644 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1646 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1647 (xgetint): Add missing shift for LSB tags.
1649 2012-04-24 Martin Rudalics <rudalics@gmx.at>
1651 * keyboard.c (read_char): Don't wipe echo area for select window
1652 events: These might get delayed via `mouse-autoselect-window'
1655 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
1657 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1658 manipulation of :loaded-from data.
1660 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
1662 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1663 now a cons (bug#11311).
1665 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1667 Do not create empty overlays with the evaporate property (Bug#9642).
1668 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1669 if it becomes empty after its bounds are adjusted to fit within
1670 its buffer. Without this fix, in a nonempty buffer (let ((o
1671 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1672 yields an empty overlay that has the evaporate property, which is
1673 not supposed to happen.
1675 Fix minor GTK3 problems found by static checking.
1676 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1677 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1678 (struct _EmacsFixedClass, emacs_fixed_get_type):
1679 Move decls here from emacsgtkfixed.h, since they needn't be public.
1680 (emacs_fixed_get_type): Now static.
1681 (emacs_fixed_class_init): Omit unused local.
1682 (emacs_fixed_child_type): Remove; unused.
1683 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1684 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1685 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1686 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1687 (EMACS_FIXED_GET_CLASS): Remove; unused.
1688 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1690 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1691 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1693 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1695 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
1696 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
1697 (__malloc_size_t, __malloc_ptrdiff_t):
1698 Remove. All uses removed, replaced by the definiens if needed,
1699 since we can assume C89 or better now.
1700 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1701 (protect_malloc_state, align, get_contiguous_space)
1702 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1703 (malloc_atfork_handler_child, malloc_enable_thread)
1704 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1705 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1706 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1707 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1708 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1709 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1710 Define using prototypes, not old style.
1711 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1712 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1713 (align): Don't assume that signed integer overflow wraps around.
1714 Omit unused local var.
1715 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1716 (_free_internal_nolock, memalign, mallochook, reallochook):
1717 Omit no-longer-needed casts.
1718 (valloc): Use getpagesize, not __getpagesize.
1719 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1720 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1722 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1724 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
1726 Move functions from C to Lisp. Make non-blocking method calls
1727 the default. Implement further D-Bus standard interfaces.
1729 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1730 (QCdbus_request_name_allow_replacement)
1731 (QCdbus_request_name_replace_existing)
1732 (QCdbus_request_name_do_not_queue)
1733 (QCdbus_request_name_reply_primary_owner)
1734 (QCdbus_request_name_reply_in_queue)
1735 (QCdbus_request_name_reply_exists)
1736 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1737 (QCdbus_registered_serial, QCdbus_registered_method)
1738 (QCdbus_registered_signal): New Lisp objects.
1739 (XD_DEBUG_MESSAGE): Use sizeof.
1740 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1741 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1742 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1743 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1744 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1745 (xd_signature, xd_append_arg): Allow float for integer types.
1746 (xd_get_connection_references): New function.
1747 (xd_get_connection_address): Rename from xd_initialize.
1748 Return cached address.
1749 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1750 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1752 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
1753 Return number of refcounts.
1754 (Fdbus_get_unique_name): Make stronger parameter check.
1755 (Fdbus_message_internal): New defun.
1756 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1757 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1758 (Fdbus_send_signal, Fdbus_register_service)
1759 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1760 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1761 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1762 (Vdbus_compiled_version, Vdbus_runtime_version)
1763 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1764 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1765 (Vdbus_message_type_signal): New defvars.
1766 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1769 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1771 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1772 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1773 Do not assume ptrdiff_t is the same width as 'int'.
1775 * alloc.c: Handle unusual debugging option combinations.
1776 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1777 since the two debugging options are incompatible.
1778 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1780 (mem_init, mem_insert, mem_insert_fixup):
1781 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1782 (NEED_MEM_INSERT): Remove; no longer needed.
1784 2012-04-22 Leo Liu <sdl.web@gmail.com>
1786 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1788 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1790 * sysdep.c [__FreeBSD__]: Minor cleanups.
1791 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1792 Use Emacs indenting style more consistently. Avoid some casts.
1793 Use 'double' consistently rather than mixing 'float' and 'double'.
1795 2012-04-21 Eduard Wiebe <usenet@pusto.de>
1797 * sysdep.c (list_system_processes, system_process_attributes):
1798 Add implementation for FreeBSD (Bug#5243).
1800 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1802 * lisp.mk (lisp): Update.
1804 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1806 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1807 It is never used otherwise.
1809 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1811 * print.c (print_preprocess): Only check print_depth if print-circle
1813 (print_object): Check for cycles even when print-circle is nil and
1814 print-gensym is t, but only check print_depth if print-circle is nil.
1816 2012-04-20 Chong Yidong <cyd@gnu.org>
1818 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1819 set the status to "failed" and ensure that sentinel is run.
1821 2012-04-20 Glenn Morris <rgm@gnu.org>
1823 * process.c (Fset_process_inherit_coding_system_flag)
1824 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
1825 (Fmake_network_process, Fmake_serial_process): Doc fix.
1827 2012-04-20 Eli Zaretskii <eliz@gnu.org>
1829 * xdisp.c (string_buffer_position_lim): Limit starting position to
1831 (set_cursor_from_row): If called for a mode-line or header-line
1832 row, return zero immediately.
1833 (try_cursor_movement): If inside continuation line, don't back up
1834 farther than the first row after the header line, if any.
1835 Don't consider the header-line row as "partially visible", even if
1836 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1838 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1840 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1843 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
1844 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
1846 configure: new option --enable-gcc-warnings (Bug#11207)
1847 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1848 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1849 (ALL_CFLAGS): Use new macros rather than old.
1850 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1851 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1852 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1853 -Wunused-result, -Wunused-variable. This should go away once
1854 the Emacs and Gnulib regex code is merged.
1855 (xmalloc, xrealloc): Now static.
1857 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1859 * dired.c (Fsystem_groups): Remove unused local.
1861 2012-04-17 Glenn Morris <rgm@gnu.org>
1863 * dired.c (Fsystem_users): Doc fix.
1865 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1867 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1868 (syms_of_dired): Add them.
1870 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1872 Fix minor alloc.c problems found by static checking.
1873 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1874 New extern decls, to avoid calling undeclared functions.
1875 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1876 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1877 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1878 (NEED_MEM_INSERT): New macro.
1879 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
1880 Remove one incorrect comment and fix another.
1882 Fix minor ralloc.c problems found by static checking.
1883 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1884 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1885 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1886 (r_alloc_sbrk): Now static.
1888 Improve ralloc.c interface checking.
1889 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1890 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1891 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1892 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1893 [REL_ALLOC]: ... to here, to check interface.
1894 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1895 Remove decls. This fixes an "It stinks!".
1897 * alloc.c (which_symbols): Fix alignment issue / type clash.
1899 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1901 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1902 (struct Lisp_Misc_Any): Likewise.
1903 (struct Lisp_Free): Likewise.
1904 * alloc.c (union aligned_Lisp_Symbol): Define.
1905 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1906 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1907 (union aligned_Lisp_Misc): Define.
1908 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1909 aligned_Lisp_Misc instead of union Lisp_Misc.
1910 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
1912 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1914 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1915 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1916 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1917 * s/netbsd.h, s/sol2-6.h:
1918 Remove definition of GC_MARK_STACK, since the default now works.
1919 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1920 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1921 no longer the default.
1922 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1924 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1926 * lread.c (lisp_file_lexically_bound_p):
1927 Fix hang at ";-*-\n" (bug#11238).
1929 2012-04-14 Eli Zaretskii <eliz@gnu.org>
1931 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1932 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1934 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1936 * nsterm.m (constrainFrameRect): Always constrain when there is only
1937 one screen (Bug#10962).
1939 2012-04-13 Ken Brown <kbrown@cornell.edu>
1941 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1943 2012-04-13 Reuben Thomas <rrt@sc3d.org>
1945 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1947 2012-04-11 Daniel Colascione <dancol@dancol.org>
1949 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1950 against is gone. It's better to use vfork now so that when Cygwin
1951 gains a new, working vfork, we use it automatically (bug#10398).
1953 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1955 * window.c (save_window_save): Obey window-point-insertion-type.
1957 2012-04-11 Glenn Morris <rgm@gnu.org>
1959 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1961 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1963 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1965 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
1967 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1968 (force_quit_count): New var.
1969 (handle_interrupt): Use it.
1971 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
1973 * w32.c (w32_delayed_load): Record the full path of the library
1974 being loaded (bug#10424).
1976 2012-04-09 Glenn Morris <rgm@gnu.org>
1978 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
1979 not just in the obarray, before snarfing them. (Bug#11036)
1981 * Makefile.in ($(leimdir)/leim-list.el):
1982 Pass EMACS rather than BUILT_EMACS.
1984 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
1986 * process.c (make_process):
1987 * process.h: Add integer `gnutls_handshakes_tried' member to
1990 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1991 Add convenience `GNUTLS_LOG2i' macro.
1993 * gnutls.c (gnutls_log_function2i): Convenience log function.
1994 (emacs_gnutls_read): Use new log functions,
1995 `gnutls_handshakes_tried' process member, and
1996 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1997 attempts per process (connection).
1999 2012-04-09 Chong Yidong <cyd@gnu.org>
2001 * eval.c (Fuser_variable_p, user_variable_p_eh)
2002 (lisp_indirect_variable): Functions deleted.
2003 (Fdefvar): Caller changed.
2005 * callint.c (Finteractive, Fcall_interactively):
2006 * minibuf.c (Fread_variable): Callers changed.
2008 2012-04-09 Eli Zaretskii <eliz@gnu.org>
2010 * xdisp.c (set_cursor_from_row): If the display string appears in
2011 the buffer at position that is closer to point than the position
2012 after the display string, display the cursor on the first glyph of
2013 the display string. Fixes cursor display when a 'display' text
2014 property immediately follows invisible text. (Bug#11094)
2016 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2018 composite.c: use 'double' consistently
2019 * composite.c (get_composition_id): Use 'double' consistently
2020 instead of converting 'float' to 'double' and vice versa; this is
2021 easier to understand and avoids a GCC warning.
2023 2012-04-09 Glenn Morris <rgm@gnu.org>
2025 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2026 preparation for dumping it with emacs. (Bug#4789)
2027 (leimdir): New variable.
2028 ($(leimdir)/leim-list.el): New rule.
2029 (emacs$(EXEEXT)): Depend on leim-list.el.
2031 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2032 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2033 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2035 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2037 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2040 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
2042 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2043 Remove unused local variable.
2045 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2047 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2048 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2049 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2050 objects, as mark_maybe_pointer will catch them otherwise.
2051 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2052 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2054 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2056 Fix typo that broke non-Windows builds.
2057 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2059 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2061 Support building on MS-Windows with libxml2.
2063 * makefile.w32-in (OBJ2): Add xml.$(O).
2064 (GLOBAL_SOURCES): Add xml.c.
2065 ($(BLD)/xml.$(O)): New dependency list.
2067 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2068 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2069 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2070 [!WINDOWSNT]: New macros.
2071 (init_libxml2_functions, libxml2_loaded_p): New functions.
2072 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2073 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2074 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2075 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2077 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2078 Call init_libxml2_functions before calling libxml2 functions.
2079 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2081 * emacs.c: Don't include libxml/parser.h.
2082 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2083 xmlCleanupParser directly.
2085 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2087 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2089 * indent.c (Fvertical_motion): If there is a display string at
2090 point, use it.vpos to compute how many lines to backtrack after
2091 move_it_to point. (Bug#11133)
2093 2012-04-06 Eli Zaretskii <eliz@gnu.org>
2095 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2096 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2097 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2098 macros related to unification of CJK characters. For the details,
2099 see the discussion following the message here:
2100 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2102 2012-04-04 Chong Yidong <cyd@gnu.org>
2104 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2106 2012-04-01 Eli Zaretskii <eliz@gnu.org>
2108 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2109 instead of alloca. (Bug#11138)
2111 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2113 * w32menu.c (is_simple_dialog): Properly check lisp types.
2116 2012-03-31 Eli Zaretskii <eliz@gnu.org>
2118 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2119 position we get to after a call to move_it_to fails the
2120 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2121 only if we wind up in a string from display property. (Bug#11063)
2123 * window.c (Fdelete_other_windows_internal): Invalidate the row
2124 and column information about mouse highlight, so that redisplay
2125 restores it after reallocating the glyph matrices. (Bug#7464)
2127 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2128 string comes from a `display' text property, use the buffer
2129 position of that property as if we actually saw that position in
2131 (move_it_by_lines): Remove the assertion that
2132 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2133 violated when there's a before-string at the beginning of a line.
2136 2012-03-30 Eli Zaretskii <eliz@gnu.org>
2138 * xdisp.c (append_space_for_newline): If the default face was
2139 remapped, use the remapped face for the appended newline.
2140 (extend_face_to_end_of_line): Use the remapped default face for
2141 extending the face to the end of the line.
2142 (display_line): Call extend_face_to_end_of_line when the default
2143 face was remapped. (Bug#11068)
2145 2012-03-29 Eli Zaretskii <eliz@gnu.org>
2147 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2149 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2151 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2153 2012-03-27 Glenn Morris <rgm@gnu.org>
2155 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2158 2012-03-26 Kenichi Handa <handa@m17n.org>
2160 * dispextern.h (struct glyph): Fix previous change. Change the
2161 bit length of glyphless.ch to 25 (Bug#11082).
2163 2012-03-26 Chong Yidong <cyd@gnu.org>
2165 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2166 (command_loop_1): Use it; inhibit selection update for
2167 handle-select-window too (Bug#8996).
2169 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2171 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
2173 2012-03-25 Kenichi Handa <handa@m17n.org>
2175 * dispextern.h (struct glyph): Change the bit length of
2176 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2178 2012-03-24 Eli Zaretskii <eliz@gnu.org>
2180 * s/ms-w32.h (tzname): Include time.h before redirecting to
2181 _tzname. Fixes the MSVC build. (Bug#9960)
2183 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2185 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2188 * xterm.c (XTread_socket): Only modify handling_signal if
2189 !SYNC_INPUT. (Bug#11080)
2191 2012-03-23 Eli Zaretskii <eliz@gnu.org>
2193 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2194 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2195 when fetching a multibyte character consumes more bytes than
2196 CHAR_BYTES returns, due to unification of CJK characters in
2197 string_char. (Bug#11073)
2199 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2201 * process.c (wait_reading_process_output): Handle pty disconnect
2202 by refraining from sending oneself a SIGCHLD (bug#10933).
2204 2012-03-22 Chong Yidong <cyd@gnu.org>
2206 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2208 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
2209 Mark string as coming from a prefix property.
2210 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2211 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2213 2012-03-21 Chong Yidong <cyd@gnu.org>
2215 * xfaces.c (Vface_remapping_alist): Doc fix.
2217 2012-03-20 Eli Zaretskii <eliz@gnu.org>
2219 * w32proc.c (Fw32_set_console_codepage)
2220 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2223 2012-03-20 Chong Yidong <cyd@gnu.org>
2225 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2226 to reflect default non-nil value of redisplay-dont-pause.
2228 2012-03-19 Kenichi Handa <handa@m17n.org>
2230 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2231 it fit in a valid range (Bug#11003).
2233 2012-03-18 Eli Zaretskii <eliz@gnu.org>
2235 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2236 that is not from display property, accept the row as a "cursor
2237 row" if one of the string's character has a non-nil `cursor'
2238 property. Fixes cursor positioning when there are newlines in
2239 overlay strings, e.g. in icomplete.el. (Bug#11035)
2241 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2243 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2245 2012-03-12 Chong Yidong <cyd@gnu.org>
2247 * eval.c (inhibit_lisp_code): Rename from
2248 inhibit_window_configuration_change_hook; move from window.c.
2250 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2251 * window.c (run_window_configuration_change_hook)
2252 (syms_of_window): Callers changed.
2254 2012-03-11 Chong Yidong <cyd@gnu.org>
2256 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2258 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2260 2012-03-10 Chong Yidong <cyd@gnu.org>
2262 * frame.c (other_visible_frames): Don't assume the selected frame
2263 is visible (Bug#10955).
2265 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2267 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2269 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2271 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2272 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2275 2012-03-03 Glenn Morris <rgm@gnu.org>
2277 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
2279 2012-03-02 Eli Zaretskii <eliz@gnu.org>
2281 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2282 position past the first glyph_row that ends at ZV. (Bug#10902)
2283 (redisplay_window, next_element_from_string): Fix typos in
2285 (redisplay_window): Pass to move_it_vertically the margin in
2286 pixels, not in screen lines.
2288 2012-03-02 Glenn Morris <rgm@gnu.org>
2290 * buffer.c (buffer-list-update-hook): Doc fix.
2292 2012-02-29 Eli Zaretskii <eliz@gnu.org>
2294 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2295 push_it before setting up the iterator for the first overlay
2296 string, even if we have an empty string loaded.
2297 (next_overlay_string): If there's an empty string on the iterator
2298 stack, pop the stack. (Bug#10903)
2300 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2302 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2303 Suggested by Stefan Monnier in
2304 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2305 * alloc.c (widen_to_Lisp_Object): New static function.
2306 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2307 and widening them to Lisp_Objects. This would work even if
2308 USE_LSB_TAG is defined and wide integers are used, which might
2309 happen in a future version of Emacs.
2311 2012-02-25 Chong Yidong <cyd@gnu.org>
2313 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2316 * xselect.c (Fx_selection_exists_p): Doc fix.
2317 (x_clipboard_manager_save_all): Print an informative message
2318 before saving to clipboard manager.
2320 2012-02-24 Chong Yidong <cyd@gnu.org>
2322 * keyboard.c (process_special_events): Handle all X selection
2323 requests in kbd_buffer, not just the next one (Bug#8869).
2325 2012-02-23 Chong Yidong <cyd@gnu.org>
2327 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2328 call when setting menu-bar-lines and tool-bar-lines parameters.
2329 (unwind_create_frame_1): New helper function.
2331 * window.c (inhibit_window_configuration_change_hook): New var.
2332 (run_window_configuration_change_hook): Obey it.
2333 (syms_of_window): Initialize it.
2335 2012-02-22 Chong Yidong <cyd@gnu.org>
2337 * xterm.c (x_draw_image_relief): Add missing type check for
2338 Vtool_bar_button_margin (Bug#10743).
2340 2012-02-21 Chong Yidong <cyd@gnu.org>
2342 * fileio.c (Vfile_name_handler_alist): Doc fix.
2344 * buffer.c (Fget_file_buffer): Protect against invalid file
2345 handler return value.
2347 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2349 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2350 when computing $valmask.
2352 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2353 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2354 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2355 It's useless in that case, and it can cause problems on hosts
2356 that allocate halves of EMACS_INT values separately.
2357 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2358 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2359 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2360 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2361 it avoids undefined behavior on hosts where shifting right by more
2362 than the word width has undefined behavior.
2364 2012-02-19 Chong Yidong <cyd@gnu.org>
2366 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2367 (Funhandled_file_name_directory, Ffile_name_as_directory)
2368 (Fdirectory_file_name, Fexpand_file_name)
2369 (Fsubstitute_in_file_name): Protect against invalid file handler
2370 return values (Bug#10845).
2372 2012-02-18 Eli Zaretskii <eliz@gnu.org>
2374 * .gdbinit (pitx): Fix incorrect references to fields of the
2377 2012-02-17 Chong Yidong <cyd@gnu.org>
2379 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2381 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2383 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2384 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2386 2012-02-15 Chong Yidong <cyd@gnu.org>
2388 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2389 marked as special. Also, starting docstrings with * is obsolete.
2391 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2393 * gnutls.c (emacs_gnutls_write): Fix last change.
2395 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2397 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2400 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2402 * keymap.c (Fsingle_key_description): Handle char ranges.
2404 2012-02-12 Chong Yidong <cyd@gnu.org>
2406 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2407 as that creates a dangerous corner case.
2409 * window.c (Fdelete_window_internal): Invalidate the mouse
2410 highlight (Bug#9904).
2412 2012-02-12 Glenn Morris <rgm@gnu.org>
2414 * xselect.c (Fx_own_selection_internal)
2415 (Fx_get_selection_internal, Fx_disown_selection_internal)
2416 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2417 * nsselect.m (Fx_own_selection_internal)
2418 (Fx_disown_selection_internal, Fx_selection_exists_p)
2419 (Fx_selection_owner_p, Fx_get_selection_internal):
2420 Sync docs and argument specs with the xselect.c versions.
2422 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2424 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2426 2012-02-11 Eli Zaretskii <eliz@gnu.org>
2428 * w32select.c (Fx_selection_exists_p): Sync doc string and
2429 argument list with xselect.c. (Bug#10783)
2431 * w16select.c (Fx_selection_exists_p): Sync doc string and
2432 argument list with xselect.c. (Bug#10783)
2434 2012-02-10 Glenn Morris <rgm@gnu.org>
2436 * fns.c (Fsecure_hash): Doc fix.
2438 2012-02-09 Kenichi Handa <handa@m17n.org>
2440 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2442 2012-02-07 Chong Yidong <cyd@gnu.org>
2444 * buffer.c (Fbuffer_local_variables)
2445 (buffer_lisp_local_variables): Handle unbound vars correctly;
2446 don't let Qunbound leak into Lisp.
2448 2012-02-07 Glenn Morris <rgm@gnu.org>
2450 * image.c (Fimagemagick_types): Doc fix.
2452 * image.c (imagemagick-render-type): Change it from a lisp object
2453 to an integer. Move the doc here from the lisp manual.
2454 Treat all values not equal to 0 the same.
2456 2012-02-06 Chong Yidong <cyd@gnu.org>
2458 * doc.c (store_function_docstring): Avoid applying docstring of
2459 alias to base function (Bug#2603).
2461 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2463 * .gdbinit (pp1, pv1): Remove redundant defines.
2466 2012-02-04 Chong Yidong <cyd@gnu.org>
2468 * nsterm.m: Declare a global (Bug#10694).
2470 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2472 * w32.c (get_emacs_configuration_options):
2473 Include --enable-checking, if specified, in the return value.
2475 2012-02-04 Martin Rudalics <rudalics@gmx.at>
2477 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2478 after rounding frame sizes. (Bug#9723)
2480 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2482 * keyboard.c (adjust_point_for_property): Don't position point
2483 before BEGV. (Bug#10696)
2485 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2487 Handle overflow when computing char display width (Bug#9496).
2488 * character.c (char_width): Return EMACS_INT, not int.
2489 (char_width, c_string_width): Check for overflow when
2490 computing the width; this is possible now that individual
2491 characters can have unbounded width. Problem introduced
2492 by merge from Emacs 23 on 2012-01-19.
2494 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
2496 * dbusbind.c (Fdbus_register_method): Mention the return value
2497 :ignore in the docstring.
2499 2012-02-02 Glenn Morris <rgm@gnu.org>
2501 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2503 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2504 Unconditionally set to t. (Bug#10673)
2505 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2506 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2507 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2509 2012-02-02 Kenichi Handa <handa@m17n.org>
2511 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2512 0, do not call append_composite_glyph.
2514 2012-02-02 Kenichi Handa <handa@m17n.org>
2516 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2518 (x_produce_glyphs): If the component of a composition is a null
2519 string, set it->pixel_width to 1 to avoid zero-width glyph.
2521 2012-02-01 Eli Zaretskii <eliz@gnu.org>
2523 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2524 first 2 arguments are identical. This makes inserting large
2525 output from a subprocess an order of magnitude faster on
2526 MS-Windows, where all sbrk'ed memory is always contiguous.
2528 2012-01-31 Glenn Morris <rgm@gnu.org>
2530 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2531 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2532 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2534 2012-01-29 Glenn Morris <rgm@gnu.org>
2536 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2538 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2540 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2542 2012-01-28 Chong Yidong <cyd@gnu.org>
2544 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2546 2012-01-26 Chong Yidong <cyd@gnu.org>
2548 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2550 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2551 repeat counts (Bug#10507).
2553 2012-01-26 Glenn Morris <rgm@gnu.org>
2555 * lread.c (syms_of_lread): Doc fix.
2557 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2559 * coding.c (encode_designation_at_bol): Change return value to
2562 2012-01-25 Chong Yidong <cyd@gnu.org>
2564 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2566 2012-01-21 Chong Yidong <cyd@gnu.org>
2568 * floatfns.c (Fcopysign): Make the second argument non-optional,
2569 since nil is not allowed anyway.
2571 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2573 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2574 (send_process): Likewise.
2576 2012-01-19 Martin Rudalics <rudalics@gmx.at>
2578 * window.c (save_window_save, Fcurrent_window_configuration)
2579 (Vwindow_persistent_parameters): Do not use Qstate.
2580 Rewrite doc-strings.
2582 2012-01-19 Kenichi Handa <handa@m17n.org>
2584 * character.c (char_width): New function.
2585 (Fchar_width, c_string_width, lisp_string_width):
2586 Use char_width (Bug#9496).
2588 2012-01-16 Martin Rudalics <rudalics@gmx.at>
2590 * window.c (Vwindow_persistent_parameters): New variable.
2591 (Fset_window_configuration, save_window_save): Handle persistent
2594 2012-01-14 Eli Zaretskii <eliz@gnu.org>
2596 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2597 thrashing the stack of the thread. (Bug#9087)
2599 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2601 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2603 2012-01-11 Eli Zaretskii <eliz@gnu.org>
2605 * xdisp.c (rows_from_pos_range): Handle the case where the
2606 highlight ends on a newline. (Bug#10464)
2607 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2608 he end column for display of highlight that ends on a newline
2611 2012-01-11 Glenn Morris <rgm@gnu.org>
2613 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2614 from load-path also when installation-directory is nil. (Bug#10208)
2616 2012-01-10 Glenn Morris <rgm@gnu.org>
2618 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2620 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2621 Update template values to be closer to their typical values these days.
2623 2012-01-09 Eli Zaretskii <eliz@gnu.org>
2625 * xdisp.c (rows_from_pos_range): Accept additional argument
2626 DISP_STRING, and accept any glyph in a row whose object is that
2627 string as eligible for mouse highlight. Fixes mouse highlight of
2628 display strings from overlays. (Bug#10464)
2630 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
2632 emacs: fix an auto-save permissions race condition (Bug#10400)
2633 * fileio.c (auto_saving_dir_umask): New static var.
2634 (Fmake_directory_internal): Use it.
2635 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2636 creating the directory. The old code temporarily assigns
2637 too-generous permissions to the directory.
2638 (do_auto_save_eh): Clear it.
2639 (Fdo_auto_save): Catch all errors, not just file errors, so
2640 that the var is always cleared.
2642 2012-01-07 Eli Zaretskii <eliz@gnu.org>
2644 * search.c (scan_buffer): Pass character positions to
2645 know_region_cache, not byte positions. (Bug#6540)
2647 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
2649 * w32.c (sys_rename): Report EXDEV when rename of a directory
2650 fails because the target is on another logical disk. (Bug#10284)
2652 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2654 * xterm.c (x_embed_request_focus): New function.
2656 * xterm.h: Add prototype.
2658 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2660 2012-01-05 Glenn Morris <rgm@gnu.org>
2662 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2664 2012-01-01 Eli Zaretskii <eliz@gnu.org>
2666 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2667 Load gnutls_transport_set_lowat only if GnuTLS version is below
2669 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2670 GnuTLS versions below 2.11.1.
2672 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2674 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2675 to the doc string advising against its use for altering the way
2676 windows are scrolled.
2678 2011-12-28 Kenichi Handa <handa@m17n.org>
2680 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2681 coding-system ASCII compatible only when it does not produce BOM
2682 on encoding (Bug#10383).
2684 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2686 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2688 (create_and_show_popup_menu): Always use menu_position_func for
2691 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2693 * callint.c (Fcall_interactively): Don't truncate prompt string.
2695 2011-12-23 Eli Zaretskii <eliz@gnu.org>
2697 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2698 property that ends at ZV, so that the bidi iteration could be
2699 resumed from there (after widening). (Bug#10360)
2701 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2703 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2705 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2707 * nsterm.m (x_free_frame_resources):
2708 Release f->output_data.ns->miniimage.
2709 (ns_index_color): Fix indentation. Do not retain
2710 color_table->colors[i].
2712 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2715 * nsfns.m (x_set_background_color): Assign return value from
2716 ns_index_color to face-background instead of NSColor*.
2717 (ns_implicitly_set_icon_type): Fix indentation.
2718 Change assignment in for loop to comparison.
2720 * emacs.c (ns_pool): New variable.
2721 (main): Assign ns_pool.
2722 (Fkill_emacs): Call ns_release_autorelease_pool.
2724 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2725 autorelease fdesc, release fdAttrs and tdict.
2726 (ns_get_covering_families): Release charset.
2727 (ns_findfonts): Release NSFontDescriptor created with new.
2728 (ns_uni_to_glyphs): Fix indentation.
2729 (setString): Release attrStr before assigning new value.
2731 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2733 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2735 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2736 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2738 2011-12-18 David Reitter <reitter@cmu.edu>
2740 * nsterm.m (ns_term_init): Subscribe for notifications
2741 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2742 to method trackingNotification in EmacsMenu.
2744 * nsmenu.m (trackingMenu): New variable.
2745 (trackingNotification): New method (from Aquamacs).
2746 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
2747 from Aquamacs (Bug#7030).
2749 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2751 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2752 (symbol_to_nsstring): Fix indentation.
2753 (ns_symbol_to_pb): New function.
2754 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2755 (Fns_rotate_cut_buffers_internal): Remove.
2756 (Fns_store_selection_internal): Rename from
2757 Fns_store_cut_buffer_internal.
2758 (ns_get_foreign_selection, Fx_own_selection_internal)
2759 (Fx_disown_selection_internal, Fx_selection_exists_p)
2760 (Fns_get_selection_internal, Fns_store_selection_internal):
2761 Use ns_symbol_to_pb and check if return value is nil.
2762 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2763 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
2764 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2765 renamed to Sns_store_selection_internal.
2766 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2767 and remove this function.
2768 (ns_handle_selection_clear): Remove, never used.
2769 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2772 2011-12-17 Ken Brown <kbrown@cornell.edu>
2774 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2775 GID is unknown (Bug#10257).
2777 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2779 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2780 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2781 which caused a build failure on GNU/Linux IA-64. This problem was
2782 introduced by my 2011-10-07 patch.
2784 2011-12-15 Juri Linkov <juri@jurta.org>
2786 * image.c (imagemagick_error): New function. (Bug#10112)
2787 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2788 Use `imagemagick_error' where ImageMagick functions return
2790 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2793 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2795 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2796 fill background (Bug#8992).
2798 2011-12-13 Martin Rudalics <rudalics@gmx.at>
2800 * window.c (Vwindow_combination_resize)
2801 (Vwindow_combination_limit): Use t instead of non-nil in
2803 (Vrecenter_redisplay): Add first sentence of doc-string on
2805 (Frecenter): Fix doc-string typo.
2807 2011-12-11 Kenichi Handa <handa@m17n.org>
2809 * coding.c (Funencodable_char_position): Pay attention to the
2810 buffer text relocation (Bug#9389).
2812 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2814 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2815 gtk_init (Bug#10100).
2817 2011-12-10 Eli Zaretskii <eliz@gnu.org>
2819 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2820 IT->string is nil. (Bug#10263)
2822 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2824 * nsterm.h (x_free_frame_resources): Declare.
2826 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2827 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2829 * nsterm.h (ns_get_defaults_value): Declare.
2831 * nsterm.m (ns_default): Call ns_get_defaults_value.
2833 2011-12-09 Eli Zaretskii <eliz@gnu.org>
2835 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2838 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2840 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2841 that where the value of an _OBJC_* symbol points to is in the .bss
2842 section (Bug#10240).
2844 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2846 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2847 after the loop to call ccl_driver at least once (Bug#8619).
2849 2011-12-08 Kenichi Handa <handa@m17n.org>
2851 * ftfont.c (get_adstyle_property): Fix previous change
2854 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
2856 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2857 dirs from the default value of EMACSLOADPATH (bug#10208).
2859 2011-12-07 Glenn Morris <rgm@gnu.org>
2861 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2862 installation and source directories as well. (Bug#10208)
2864 2011-12-06 Chong Yidong <cyd@gnu.org>
2866 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2868 2011-12-06 Glenn Morris <rgm@gnu.org>
2870 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2871 as an error, not just -1. (Bug#10217)
2873 2011-12-05 Chong Yidong <cyd@gnu.org>
2875 * keyboard.c (process_special_events): New function.
2876 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2878 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2880 * coding.c (encode_designation_at_bol): Don't use uninitialized
2881 local variable (Bug#9318).
2883 2011-12-05 Kenichi Handa <handa@m17n.org>
2885 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2886 return Qnil (Bug#8046, Bug#10193).
2888 2011-12-05 Kenichi Handa <handa@m17n.org>
2890 * coding.c (encode_designation_at_bol): New args charbuf_end and
2891 dst. Return the number of produced bytes. Callers changed.
2892 (coding_set_source): Return how many bytes coding->source was
2894 (coding_set_destination): Return how many bytes
2895 coding->destination was relocated.
2896 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
2897 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
2899 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2901 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2902 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2905 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2907 The following changes are to fix Bug#9318.
2909 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
2910 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2911 (encode_coding_iso_2022, encode_coding_sjis)
2912 (encode_coding_big5, encode_coding_charset): Use the above macros.
2914 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
2916 * lisp.h (process_quit_flag): Fix external declaration.
2918 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2920 Don't macro-inline non-performance-critical code.
2921 * eval.c (process_quit_flag): New function.
2922 * lisp.h (QUIT): Use it.
2924 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2926 * nsfns.m (get_geometry_from_preferences): New function.
2927 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2929 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2931 * emacs.c (Qkill_emacs): Define.
2932 (syms_of_emacs): Initialize it.
2933 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2934 Qquit_flag to `kill-emacs' instead.
2935 (quit_throw_to_read_char): Add parameter `from_signal'.
2936 All callers changed. Call Fkill_emacs if requested and safe.
2937 * lisp.h (QUIT): Call Fkill_emacs if requested.
2939 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2941 * widget.c (update_wm_hints): Return if wmshell is null.
2942 (widget_update_wm_size_hints): New function.
2944 * widget.h (widget_update_wm_size_hints): Declare.
2946 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2947 widget_update_wm_size_hints (Bug#10104).
2949 2011-12-03 Eli Zaretskii <eliz@gnu.org>
2951 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2952 before a newline, prepare the bidi iterator for consuming the
2953 newline, and keep the current paragraph direction. (Bug#10183)
2954 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
2956 2011-12-02 Juri Linkov <juri@jurta.org>
2958 * search.c (Fword_search_regexp): New Lisp function created from
2959 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2960 (Fword_search_backward, Fword_search_forward)
2961 (Fword_search_backward_lax, Fword_search_forward_lax):
2962 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2963 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2965 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2967 * fileio.c (Finsert_file_contents): Move after-change-function call
2968 to before the "handled:" label, since all "goto handled" appear in
2969 cases where the *-change-functions have already been properly called
2972 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2974 * keyboard.c (interrupt_signal): Don't call kill-emacs when
2975 waiting for input. (Bug#10169)
2977 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2979 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
2980 verifies glyph row's hash code--we have just reallocated the
2981 glyphs, so their contents can be complete garbage. (Bug#10164)
2983 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
2985 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
2987 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2989 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
2990 attributes are tested _before_ calling verify_row_hash, to protect
2991 against GCC re-ordering of the tests. (Bug#10164)
2993 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2995 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
2997 * xterm.c (handle_one_xevent): Only set async_visible and friends
2998 if net_wm_state_hidden_seen is non-zero (Bug#10002)
2999 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
3000 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3002 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3004 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3005 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3006 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3007 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3008 All uses changed to use GCPRO1 etc.
3009 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3010 Revert to old implementation (i.e., before 2011-03-11).
3012 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3014 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3015 of scroll runs so as to avoid assigning disabled bogus rows and
3016 unnecessary graphics copy operations.
3018 2011-11-27 Eli Zaretskii <eliz@gnu.org>
3020 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3021 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3022 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3023 (malloc, free, realloc, calloc): Redirect to e_* only when
3026 * lisp.h (GCTYPEBITS): Move before first use.
3027 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3028 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3029 this macro definition.
3031 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3034 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3036 * gtkutil.c (xg_create_frame_widgets):
3037 Call gtk_window_set_has_resize_grip (FALSE) if that function is
3038 present with Gtk+ 2.0.
3040 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3042 * fileio.c (Finsert_file_contents): Undo previous change; see
3043 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3045 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3047 Rename locals to avoid shadowing.
3048 * fileio.c (Finsert_file_contents):
3049 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3050 * process.c (wait_reading_process_output):
3051 Rename inner 'proc' to 'p' to avoid shadowing.
3052 Indent for consistency with usual Emacs style.
3054 2011-11-25 Eli Zaretskii <eliz@gnu.org>
3056 * xdisp.c (redisplay_window): If cursor row is not fully visible
3057 after recentering, and scroll-conservatively is set to a large
3058 number, scroll window by a few more lines to make the cursor fully
3059 visible and out of scroll-margin. (Bug#10105)
3060 (start_display): Don't move to the next line if the display should
3061 start at a newline that is part of a display vector or an overlay
3064 2011-11-24 Juri Linkov <juri@jurta.org>
3066 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3067 after the `MagickPingImage' call. (Bug#10112)
3069 2011-11-23 Chong Yidong <cyd@gnu.org>
3071 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3073 2011-11-23 Martin Rudalics <rudalics@gmx.at>
3075 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3076 making another buffer current. (Bug#10114)
3078 2011-11-23 Glenn Morris <rgm@gnu.org>
3080 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3082 2011-11-23 Chong Yidong <cyd@gnu.org>
3084 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3085 using it (Bug#5984).
3087 2011-11-22 Eli Zaretskii <eliz@gnu.org>
3089 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3090 and header-lines, as they don't have one computed for them.
3093 * .gdbinit (prow): Make displayed values more self-explaining.
3094 Add row's hash code.
3096 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3098 * process.c (wait_reading_process_output): Fix asynchrounous
3099 GnuTLS socket handling on some versions of the GnuTLS library.
3100 (wait_reading_process_output): Add comment and URL.
3102 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3104 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3106 2011-11-21 Chong Yidong <cyd@gnu.org>
3108 * window.c (Fnext_window, Fprevious_window): Doc fix.
3110 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3112 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3114 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3116 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3118 2011-11-20 Martin Rudalics <rudalics@gmx.at>
3120 * window.c (Fset_window_combination_limit): Rename argument
3122 (Vwindow_combination_limit): Remove "status" from doc-string.
3124 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3126 * m/ibms390.h: Remove.
3127 * m/ibms390x.h: Don't include "ibms390.h".
3129 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3131 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3132 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3134 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3136 * casetab.c (Fset_case_table):
3137 * charset.c (Fcharset_after): Fix typos.
3139 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
3141 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3142 Otherwise, valgrind does not work on some platforms.
3143 Problem reported by Andreas Schwab in
3144 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3145 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3146 is set, removing the need for VIRT_ADDRESS_VARIES.
3147 (PURE_P): Use a more-efficient implementation that needs just one
3148 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3149 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3150 to 4 (xorl, subq, cmpq, setbe).
3151 * alloc.c (pure): Always extern now, since that's the
3152 VIRT_ADDR_VARIES behavior.
3153 (PURE_POINTER_P): Use a single comparison, not two, for
3154 consistency with the new puresize.h.
3155 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3156 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3157 Remove VIRT_ADDR_VARIES no longer needed.
3159 2011-11-19 Eli Zaretskii <eliz@gnu.org>
3161 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3162 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3163 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3164 behave as if the cursor position were at the window margin.
3166 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3167 and the cursor position is out of bounds, behave as if the cursor
3168 position were at the window margin. (Bug#10075)
3170 2011-11-18 Chong Yidong <cyd@gnu.org>
3172 * window.c (Fwindow_combination_limit): Make first argument
3173 non-optional, since it is meaningless for live windows like the
3176 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3178 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3180 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3182 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3183 (graft_intervals_into_buffer): Simplify.
3185 2011-11-18 Eli Zaretskii <eliz@gnu.org>
3187 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3188 hash values of the two rows.
3189 (copy_row_except_pointers): Preserve the used[] arrays and the
3190 hash values of the two rows. (Bug#10035)
3191 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
3193 * xdisp.c (row_hash): New function, body extracted from
3194 compute_line_metrics.
3195 (compute_line_metrics): Call row_hash, instead of computing the
3198 * dispnew.c (verify_row_hash): Call row_hash for computing the
3199 hash code of a row, instead of duplicating code from xdisp.c.
3201 * dispextern.h (row_hash): Add prototype.
3203 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3205 * frame.c (delete_frame): Don't delete the terminal when the last
3206 X frame is closed if emacs is built with GTK toolkit.
3208 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
3210 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3212 2011-11-17 Martin Rudalics <rudalics@gmx.at>
3214 * window.c (Vwindow_splits): Rename to
3215 Vwindow_combination_resize. Suggested by Juri Linkov.
3216 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3219 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
3221 * nsfns.m (Fns_font_name):
3222 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
3224 2011-11-16 Martin Rudalics <rudalics@gmx.at>
3226 * window.h (window): Rename slot "nest" to "combination_limit".
3227 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3228 (Fset_window_nest): Rename to Fset_window_combination_limit.
3229 (Vwindow_nest): Rename to Vwindow_combination_limit.
3230 (recombine_windows, make_parent_window, make_window)
3231 (Fsplit_window_internal, saved_window)
3232 (Fset_window_configuration, save_window_save): Rename all
3233 occurrences of window_nest to window_combination_limit.
3235 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
3237 * image.c (imagemagick_load_image): Fix typo.
3239 2011-11-14 Eli Zaretskii <eliz@gnu.org>
3241 * xdisp.c (display_line): Move the call to
3242 highlight_trailing_whitespace before the call to
3243 compute_line_metrics, since the latter needs to see the final
3244 faces of all the glyphs to compute ROW's hash value.
3245 Fixes assertion violations in row_equal_p. (Bug#10035)
3247 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
3249 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3250 just return (bug#10044).
3252 2011-11-12 Eli Zaretskii <eliz@gnu.org>
3254 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3255 with user-defined heap size. Bump the default size of the temacs
3256 heap to 27MB, to avoid memory warning when running temacs.
3257 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3259 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3260 current_matrix and desired_matrix. (Bug#9990)
3261 (verify_row_hash) [XASSERTS]: New function.
3262 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3263 that the hash value of glyph rows is correct.
3265 2011-11-12 Martin Rudalics <rudalics@gmx.at>
3267 * window.h (window): Remove splits slot.
3268 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3269 (Fdelete_other_windows_internal, make_parent_window)
3270 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3271 (Fset_window_configuration, save_window_save): Don't deal with
3272 split status of windows.
3273 (saved_window): Remove splits slot.
3274 (Vwindow_splits): Rewrite doc-string.
3276 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3278 * xfns.c (unwind_create_frame):
3279 * nsfns.m (unwind_create_frame):
3280 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3281 Vframe_list (Bug#9999).
3283 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3285 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
3287 2011-11-11 Kenichi Handa <handa@m17n.org>
3289 * callproc.c (Fcall_process): Set the member dst_multibyte of
3292 2011-11-11 Johan Bockgård <bojohan@gnu.org>
3294 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3295 avoid a crash (bug#9496).
3297 2011-11-09 Chong Yidong <cyd@gnu.org>
3299 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3300 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3302 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3304 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3306 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3308 Avoid some portability problems by eschewing 'extern inline' functions.
3309 The trivial performance wins aren't worth the portability hassles; see
3310 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3312 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3313 (window_box_width, window_box_left, window_box_left_offset)
3314 (window_box_right, window_box_right_offset): Undo previous change,
3315 by removing the "extern"s.
3316 * intervals.c (adjust_intervals_for_insertion)
3317 (adjust_intervals_for_deletion): Undo previous change,
3318 making these static again.
3319 (offset_intervals, temp_set_point_both, temp_set_point)
3320 (copy_intervals_to_string): No longer inline.
3321 * xdisp.c (window_text_bottom_y, window_box_width)
3322 (window_box_height, window_box_left_offset)
3323 (window_box_right_offset, window_box_left, window_box_right)
3324 (window_box): No longer inline.
3326 2011-11-08 Chong Yidong <cyd@gnu.org>
3328 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
3329 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3330 Signal an error if not a live window.
3331 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3332 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3334 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
3336 * lisp.h (syms_of_abbrev): Remove declaration.
3337 Reported by CHENG Gao <chenggao@royau.me>.
3339 2011-11-07 Eli Zaretskii <eliz@gnu.org>
3341 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3342 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3343 of temacs in GUI mode.
3345 2011-11-07 Martin Rudalics <rudalics@gmx.at>
3347 * window.h: Declare delete_all_child_windows instead of
3348 delete_all_subwindows.
3349 * window.c (Fwindow_nest, Fset_window_nest)
3350 (Fset_window_new_total, Fset_window_new_normal)
3351 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3352 (delete_all_subwindows): Rename to delete_all_child_windows.
3353 (Fdelete_other_windows_internal, Fset_window_configuration):
3354 Call delete_all_child_windows instead of delete_all_subwindows.
3355 * frame.c (delete_frame): Call delete_all_child_windows instead
3356 of delete_all_subwindows.
3358 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3360 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3361 This is also needed for porting to any host where GC_MARK_STACK is
3362 not GC_MAKE_GCPROS_NOOPS.
3363 (which_symbols): Use it.
3365 2011-11-07 Kenichi Handa <handa@m17n.org>
3367 * coding.c (coding_set_destination): Check coding->src_pos only
3368 when coding->src_object is a buffer (bug#9910).
3370 * process.c (send_process): Set the member src_multibyte of coding
3371 to 0 (bug#9911) when sending a unibyte text.
3373 * callproc.c (Fcall_process): Set the member src_multibyte of
3374 process_coding to 0 (bug#9912).
3376 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3378 * xmenu.c (cleanup_widget_value_tree): New function.
3379 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3380 calling free_menubar_widget_value_tree directly (Bug#9830).
3382 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3384 Fix some portability problems with 'inline'.
3385 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3386 (window_box_width, window_box_left, window_box_left_offset)
3387 (window_box_right, window_box_right_offset): Declare extern.
3388 Otherwise, these inline functions do not conform to C99 and
3389 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3390 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3391 * intervals.c (adjust_intervals_for_insertion)
3392 (adjust_intervals_for_deletion): Now extern, because otherwise the
3393 extern inline functions 'offset_intervals' couldn't refer to it.
3394 (static_offset_intervals): Remove.
3395 (offset_intervals): Rewrite using the old contents of
3396 static_offset_intervals. The old version didn't conform to C99
3397 because an extern inline function contained a reference to an
3398 identifier with static linkage.
3400 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3402 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3405 2011-11-06 Eli Zaretskii <eliz@gnu.org>
3407 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3408 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3409 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3410 return Qleft_to_right.
3412 2011-11-06 Chong Yidong <cyd@gnu.org>
3414 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3415 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3416 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3417 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3418 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3419 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3420 (Fwindow_vscroll): Doc fix.
3421 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3422 argument, since it makes no sense to pass a live window and for
3423 consistency with window-child.
3425 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3427 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3430 2011-11-05 Jason Rumney <jasonr@gnu.org>
3432 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3433 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3435 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3436 bitwise arithmetic preventing use of unicode-sip and non-truetype
3439 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3441 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3444 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3445 initialization code to keep similarity to xfns.c after changes
3448 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3450 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3451 (unwind_create_frame): New function (Bug#9943).
3452 (Fx_create_frame): Restructure code to be more similar to the one in
3453 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3454 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3455 Move terminal->reference_count++ just before making the frame official
3458 * nsterm.m (x_free_frame_resources): New function.
3459 (x_destroy_window): Move code to x_free_frame_resources.
3461 * xfns.c (unwind_create_frame): Fix comment.
3462 (Fx_create_frame, x_create_tip_frame):
3463 Move terminal->reference_count++ just before making the frame
3464 official. Move initialization of image_cache_refcount and
3465 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3467 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3469 Support MSVC build with newer versions of Visual Studio.
3470 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3471 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3474 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3475 which are not supported by MSVC.
3476 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3477 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3479 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3481 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3483 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3485 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
3487 Support MSVC build with newer versions of Visual Studio.
3488 * w32.c: Don't include w32api.h for MSVC.
3489 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3491 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3492 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3493 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3494 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3496 (alloca) [_MSC_VER]: Define to _alloca.
3498 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3500 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3502 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3504 * xdisp.c (note_mouse_highlight): If either of
3505 previous/next-single-property-change returns nil, treat that as
3506 the beginning or the end of the buffer. (Bug#9955)
3508 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3510 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
3511 label is not null (Bug#9951).
3512 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3515 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3517 * window.c (Fwindow_body_size): Mention in the doc string that the
3518 return value is in frame's canonical units. (Bug#9949)
3520 2011-11-03 Eli Zaretskii <eliz@gnu.org>
3522 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3524 * w32fns.c (unwind_create_frame): If needed, free the glyph
3525 matrices of the partially constructed frame. (Bug#9943)
3526 * xfns.c (unwind_create_frame): Likewise.
3528 2011-11-01 Eli Zaretskii <eliz@gnu.org>
3530 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3531 Don't stop backward scan on the continuation glyph, even though
3532 its CHARPOS is positive.
3533 (mouse_face_from_buffer_pos, note_mouse_highlight):
3534 Rename cover_string to disp_string.
3536 2011-11-01 Martin Rudalics <rudalics@gmx.at>
3538 * window.c (temp_output_buffer_show): Don't use
3539 Vtemp_buffer_show_specifiers.
3540 (Vtemp_buffer_show_specifiers): Remove unused variable.
3542 2011-10-30 Eli Zaretskii <eliz@gnu.org>
3544 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3545 past the beginning of the current glyph matrix.
3547 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
3549 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3550 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3551 HAVE_GTK3 (Bug#9869).
3553 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3554 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3556 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3558 * xterm.c: Declare x_handle_net_wm_state to return int.
3559 (handle_one_xevent): Check if we are iconified but don't have
3560 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3561 (get_current_wm_state): Return non-zero if not hidden,
3562 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3563 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3564 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3565 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3567 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3569 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3570 so that this new function doesn't get optimized away by a
3571 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3573 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3575 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3577 2011-10-29 Eli Zaretskii <eliz@gnu.org>
3579 Fix the `xbytecode' command.
3580 * .gdbinit (xprintbytestr): New command.
3581 (xwhichsymbols): Rename from `which'; all callers changed.
3582 (xbytecode): Print the byte-code string as well.
3584 2011-10-29 Kim Storm <storm@cua.dk>
3586 * alloc.c (which_symbols): New function.
3588 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3590 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3593 2011-10-29 Glenn Morris <rgm@gnu.org>
3595 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3596 Not clear what it was for, and it causes various bugs. (Bug#9839)
3598 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3600 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3601 possible random value that matches one of those tested as
3602 condition to clear the mouse face.
3604 2011-10-28 Chong Yidong <cyd@gnu.org>
3606 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3608 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3610 * window.c (make_window): Initialize phys_cursor_on_p.
3612 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3614 * lisp.h (struct Lisp_Symbol): Update comments.
3616 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
3618 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3620 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3622 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3623 <oslsachem@gmail.com> for helping to debug this.
3625 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3626 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3627 (g_b_init_get_glyph_outline_w): New static variables.
3628 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3629 (GetGlyphOutlineW_Proc): New typedefs.
3630 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
3631 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3633 (w32font_open_internal, compute_metrics):
3634 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
3635 instead of calling the "wide" APIs directly.
3637 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3639 * w32.h (syms_of_w32font): Add prototype.
3641 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3643 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3644 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3645 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3646 (Fmove_to_window_line): Doc fix.
3648 2011-10-27 Chong Yidong <cyd@gnu.org>
3650 * process.c (make_process): Set gnutls_state to NULL.
3652 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3653 non-NULL, regardless of GNUTLS_INITSTAGE.
3654 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3655 an error. Set process slots as soon as we allocate them.
3657 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3659 2011-10-27 Chong Yidong <cyd@gnu.org>
3661 * gnutls.c (emacs_gnutls_deinit): New function.
3662 Deallocate credentials structures as well as calling gnutls_deinit.
3663 (Fgnutls_deinit, Fgnutls_boot): Use it.
3665 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3666 (deactivate_process): Call emacs_gnutls_deinit.
3668 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3670 * image.c (x_create_x_image_and_pixmap):
3671 * w32.c (sys_rename, w32_delayed_load):
3672 * w32font.c (fill_in_logfont):
3673 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3675 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
3677 * w32fns.c (w32_default_color_map): New function,
3678 extracted from Fw32_default_color_map.
3679 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
3681 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3683 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3685 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3687 * keyboard.c (test_undefined): New function (bug#9751).
3688 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3690 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3692 * sysdep.c (init_sys_modes): Fix the check for the controlling
3693 terminal (Bug#6649).
3695 2011-10-20 Eli Zaretskii <eliz@gnu.org>
3697 * dispextern.h (struct bidi_it): New member next_en_type.
3699 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3700 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3701 current character, check also for next_en_type being WEAK_EN.
3702 (bidi_resolve_weak): Don't enter the expensive loop if the current
3703 position is before next_en_pos. Record the bidi type of the first
3704 non-ET, non-BN character we find, in addition to its position.
3705 (bidi_level_of_next_char): Invalidate next_en_type when
3706 next_en_pos is over-stepped.
3708 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3710 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3711 * editfns.c: Rewrite current-time-zone so that it invokes
3712 the equivalent of (format-time-string "%Z") to get the time zone name.
3713 This fixes a bug when the time zone name contains characters that
3714 need converting from the system time locale to Emacs internal format.
3715 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3716 that patch fixed format-time-string to do the conversion, but
3717 I forgot to fix current-time-zone.
3718 (format_time_string): New function, containing most of
3719 what Fformat_time_string used to contain.
3720 (Fformat_time_string): Rewrite in terms of format_time_string.
3721 This doesn't change this function's behavior.
3722 (current-time-zone): Rewrite to use format_time_string.
3723 This fixes the bug reported by Michael Schierl in
3724 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3725 Jason Rumney's 2007-06-07 change worked around this bug, but
3727 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3729 2011-10-19 Eli Zaretskii <eliz@gnu.org>
3731 * xdisp.c (start_display): If the character at POS is displayed
3732 via a display vector, reset IT->current.dpvec_index to zero.
3733 (try_window_reusing_current_matrix): If a line ends in a display
3734 vector or the next line starts in a display vector, continue
3735 redrawing the window even though the character position of
3736 start_row was reached.
3739 2011-10-18 Chong Yidong <cyd@gnu.org>
3741 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3742 with nobreak-char-display too.
3744 2011-10-18 Eli Zaretskii <eliz@gnu.org>
3746 Fix part 3 of bug#9771.
3747 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3748 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3749 non-neutral characters if the current character is a paragraph
3750 separator (a.k.a. Newline). This avoids running the same
3751 expensive loop twice, once when we consume the preceding newline
3752 and the other time when the line actually needs to be displayed.
3753 Avoid the loop when we see neutrals on the base embedding level
3754 following a character whose directionality is the same as the
3755 paragraph's. This avoids running the expensive loop when a line
3756 ends in a long sequence of neutrals, like control characters.
3757 Add assertion against STRONG_AL type. Slightly rearrange code
3758 that determines the type of a neutral given the first non-neutral
3760 (bidi_level_of_next_char): Set next_en_pos to zero when
3761 invalidating its info.
3763 2011-10-17 Eli Zaretskii <eliz@gnu.org>
3765 * xdisp.c (push_display_prop): Determine whether to record string
3766 or buffer position by IT->string, not by IT->method. Allow
3767 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
3768 (move_it_vertically_backward): Don't look for character position
3769 immediately after the newline when in a continuation line.
3772 2011-10-15 Martin Rudalics <rudalics@gmx.at>
3774 * window.c (coordinates_in_window): Rewrite and delabelize
3775 vertical border check. (Bug#5357) (Bug#9618)
3777 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3779 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3780 errors in XSetWindowBorder (bug#9310).
3782 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3784 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3785 avoid crash when xmalloc overrun checking is enabled.
3787 2011-10-13 Eli Zaretskii <eliz@gnu.org>
3789 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3790 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3791 cursor motion with <left> and <right> arrow keys.
3793 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3794 some callers set that themselves.
3796 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3798 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3799 display string and the previous row comes from the same string and
3800 is empty. (Bug#9739) (Bug#9738)
3802 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3804 * doc.c (get_doc_string): Encode file name (bug#9735).
3806 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3808 * bidi.c (bidi_level_of_next_char):
3809 * xdisp.c (get_visually_first_element): Remove old incorrect
3810 comments regarding the Unicode Line Separator character.
3812 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3814 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3816 * alloc.c (Fgc_status): Do not access beyond zombies array
3817 boundary if nzombies > MAX_ZOMBIES.
3818 * alloc.c (dump_zombies): Add missing format specifier.
3820 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3822 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3823 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3825 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3826 Some packages use them to denote characters with modifiers.
3828 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3830 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3831 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3832 matching a pp-number. Rename parameter var to var1.
3834 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3836 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3838 2011-10-08 Glenn Morris <rgm@gnu.org>
3840 * callint.c (Fcall_interactively): Give a more explicit error for the
3841 'c' case with a non-character input. (Bug#8479)
3843 2011-10-08 Eli Zaretskii <eliz@gnu.org>
3845 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3847 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3848 lines that are hscrolled on the left.
3850 * dispnew.c (buffer_posn_from_coords): Account for a possible
3851 presence of header-line. (Bug#4426)
3853 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3855 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3856 Don't advertise functionality which we discourage or doesn't work.
3858 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3860 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3861 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3862 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3863 this makes Emacs dump core during garbage collection on rare
3864 occasions. sizeof is obviously inferior to offsetof here, so
3865 stick with offsetof.
3866 (GC_POINTER_ALIGNMENT): New macro.
3867 (mark_memory): Omit 3rd (offset) arg; caller changed.
3868 Don't assume EMACS_INT alignment is the same as pointer alignment.
3870 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3872 * keyboard.c (read_key_sequence_remapped): New var.
3873 (read_key_sequence): Compute remapping in the right buffer.
3874 (command_loop_1): Use read_key_sequence's remapping directly.
3876 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3878 * dired.c (file_name_completion): Don't expand file name.
3879 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3880 before checking file name handler.
3882 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3883 they've been requested explicitly (bug#9591).
3885 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
3887 * keymap.c (Fsingle_key_description): Use make_specified_string
3888 instead of build_string to build string from push_key_description.
3891 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3893 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3894 This fixes a Y2038 bug on 64-bit hosts.
3895 * buffer.c (reset_buffer):
3896 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3897 (Fclear_buffer_auto_save_failure):
3898 Use 0, not -1, to represent an unset failure time, since time_t
3899 might not be signed.
3901 Remove dependency on glibc malloc internals.
3902 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3903 Move back here from lisp.h, but with their new implementations.
3904 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3905 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3906 * charset.c (charset_table_init): New static var.
3907 (syms_of_charset): Use it instead of xmalloc. This removes a
3908 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3909 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3910 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3911 Move back to alloc.c.
3912 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3913 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3915 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3917 * nsterm.m (windowDidResize): Call x_set_window_size only when
3918 ns_in_resize is true. Otherwise set pixelwidth/height and
3919 call change_frame_size (Bug#9628).
3921 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3923 Port --enable-checking=all to Fedora 14 x86-64.
3924 * charset.c (syms_of_charset): Also account for glibc malloc's
3925 internal overhead when calculating the initial malloc maximum.
3927 Port --enable-checking=all to Fedora 14 x86.
3928 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3930 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3931 (overrun_check_realloc, overrun_check_free):
3932 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3933 That way, xmalloc returns a properly-aligned pointer even if
3934 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3935 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3936 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3937 into account when calculating the initial malloc maximum.
3938 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3939 Move here from alloc.c, so that charset.c can use it too.
3940 Properly align; the old code wasn't right for common 32-bit hosts
3941 when configured with --enable-checking=all.
3942 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3943 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3945 2011-09-29 Eli Zaretskii <eliz@gnu.org>
3947 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
3950 2011-09-28 Eli Zaretskii <eliz@gnu.org>
3952 * xdisp.c (compute_display_string_end): If there's no display
3953 string at CHARPOS, return -1.
3955 * bidi.c (bidi_fetch_char): When compute_display_string_end
3956 returns a negative value, treat the character as a normal
3957 character not covered by a display string. (Bug#9624)
3959 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
3961 * lread.c (Fread_from_string): Fix typo in docstring.
3963 2011-09-27 Eli Zaretskii <eliz@gnu.org>
3965 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3966 newline, reseat the iterator instead of bidi-iterating there one
3967 character at a time. (Bug#9610)
3968 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3969 TO_CHARPOS if the bidi iterator is at base embedding level.
3971 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3973 * lread.c (readevalloop): Use correct code for NBSP.
3974 (read1): Likewise. (Bug#9608)
3976 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
3978 * dbusbind.c (Fdbus_register_signal): When service is not
3979 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
3981 2011-09-25 Glenn Morris <rgm@gnu.org>
3983 * buffer.c (truncate-lines): Doc fix.
3985 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
3987 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
3988 (Fset_window_next_buffers): Doc fix.
3990 2011-09-24 Glenn Morris <rgm@gnu.org>
3992 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3994 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3996 Fix minor problems found by static checking.
3997 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
3998 * indent.c (Fvertical_motion): Fix == vs = typo.
4000 2011-09-24 Eli Zaretskii <eliz@gnu.org>
4002 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4003 Default value is now t. Doc fix.
4005 * indent.c (Fvertical_motion): Compute and apply the overshoot
4006 logic when moving up, not only when moving down. Fix the
4007 confusing name and values of the it_overshoot_expected variable;
4008 logic changes accordingly. (Bug#9254) (Bug#9549)
4010 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4011 CHARPOS is covered by a display string which includes newlines.
4012 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4013 is covered by a display string with embedded newlines.
4015 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
4017 * dbusbind.c (Fdbus_register_signal): Add match rule to
4018 Vdbus_registered_objects_table. (Bug#9581)
4019 (Fdbus_register_method, Vdbus_registered_objects_table):
4022 2011-09-24 Jim Meyering <meyering@redhat.com>
4024 do not ignore write error for any output size
4025 The previous change was incomplete.
4026 While it makes emacs --batch detect the vast majority of stdout
4027 write failures, errors were still ignored whenever the output size is
4028 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4029 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4030 && echo FAIL: ignored write error
4031 FAIL: ignored write error
4032 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4033 && echo FAIL: ignored write error
4034 FAIL: ignored write error
4035 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4037 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4039 * emacs.c (Fkill_emacs): In noninteractive mode exit
4040 non-successfully if a write error occurred on stdout. (Bug#9574)
4042 2011-09-21 Eli Zaretskii <eliz@gnu.org>
4044 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4047 * dispextern.h (struct it): Update the comment documenting what
4050 2011-09-20 Eli Zaretskii <eliz@gnu.org>
4052 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4053 a display string, extend search for cursor position to end of row.
4054 (find_row_edges): If the row ends in a newline from a display
4055 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4056 Handle the case of a display string with multiple newlines.
4057 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4058 non-empty line. Fixes confusing cursor motion with arrow keys at
4059 the beginning of a line that starts with whitespace.
4061 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4063 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4066 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
4068 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4071 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4073 * xdisp.c (display_line): Record maximum and minimum buffer
4074 positions even if no glyphs were produced (e.g., by a zero-width
4075 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4076 buffer positions that will be removed from the glyph row because
4078 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4079 column is beyond frame width: don't subtract 1 "pixel" when
4080 computing width of the stretch.
4081 (reseat_at_next_visible_line_start): Undo the change made on
4082 2011-09-17 that saved paragraph information and restored it after
4083 the call to `reseat'. (Bug#9545)
4085 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4087 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4088 and turn window cursor on if cleared (Bug#9415).
4090 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
4092 * search.c (boyer_moore): Take unibyte characters from pattern
4093 literally. (Bug#9458)
4095 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4097 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4099 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4101 Fix minor problem found by static checking.
4102 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4103 initialized, to pacify gcc -Wuninitialized.
4105 * fileio.c: Report proper errno when syscall falls.
4106 (Finsert_file_contents): Save and restore errno,
4107 so that report_file_error outputs the correct diagnostic.
4108 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4110 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4112 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4114 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4116 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4117 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4119 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4121 * xdisp.c (reseat_at_next_visible_line_start): Keep information
4122 about the current paragraph and restore it after the call to reseat.
4124 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4125 (bidi_find_paragraph_start): Search back for paragraph beginning
4126 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4127 (bidi_move_to_visually_next): Only trigger paragraph-related
4128 computations when the last character is a newline or at EOB, not
4129 just any NEUTRAL_B. (Bug#9470)
4131 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4132 truncated lines if point is covered by a display string. (Bug#9524)
4134 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4136 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4137 (cons_to_x_long): New function.
4138 (lisp_data_to_selection_data): Use it. Correct the test for
4139 short-versus-long data; it was negated. Break out of vector
4140 loop, for efficiency, when a long datum is discovered.
4142 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4144 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4146 2011-09-16 Eli Zaretskii <eliz@gnu.org>
4148 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4149 GCC PR/17406) by declaring this function with external scope.
4151 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4153 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4154 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4156 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4158 * editfns.c (Fformat): Correctly handle text properties on "%%".
4160 2011-09-15 Eli Zaretskii <eliz@gnu.org>
4162 * xterm.c (x_draw_composite_glyph_string_foreground):
4163 * w32term.c (x_draw_composite_glyph_string_foreground):
4164 * term.c (encode_terminal_code):
4165 * composite.c (composition_update_it, get_composition_id):
4166 * xdisp.c (get_next_display_element)
4167 (fill_composite_glyph_string): Add comments about special meaning
4168 of TAB characters in a composition.
4170 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4172 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4173 This occurs when processing a multibyte format.
4174 Problem reported by Wolfgang Jenker.
4176 2011-09-15 Johan Bockgård <bojohan@gnu.org>
4178 * xdisp.c (try_cursor_movement): Only check for exact match if
4179 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4181 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4183 Remove unused external symbols.
4184 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4185 * xdisp.c (calc_pixel_width_or_height): Now static.
4186 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4187 * indent.c (check_display_width):
4188 * w32term.c: Fix comment to match code.
4189 * xterm.c, xterm.h (x_catching_errors): Remove.
4191 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4193 * xselect.c: Use signed conversions more consistently (Bug#9498).
4194 (selection_data_to_lisp_data): Assume incoming selection data are
4195 signed integers, not unsigned. This is to be consistent with
4196 outgoing selection data, which was modified to use signed integers
4197 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4198 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4199 expects long, not unsigned long.
4201 2011-09-14 Eli Zaretskii <eliz@gnu.org>
4203 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4204 computation of loop end. Reported by Johan Bockgård
4207 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
4209 * frame.c (Fother_visible_frames_p): Function deleted.
4211 2011-09-12 Eli Zaretskii <eliz@gnu.org>
4213 * indent.c (compute_motion): Process display vector front to back
4214 rather than the other way around. (Bug#2496)
4216 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4218 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4220 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
4222 * minibuf.c (Fread_from_minibuffer): Doc fix.
4224 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4226 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4227 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4229 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4231 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4232 value for non-existent files.
4234 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4236 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4237 set its "size" to -1. This will set the modtime_size field of
4238 the corresponding buffer to -1, which is what
4239 verify-visited-file-modtime expects for files that do not exist.
4242 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4244 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4246 * lisp.h: ... from here. push_key_description is no longer
4247 defined in keyboard.c, so its declaration should not be in
4248 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4249 logically belongs with push_key_description.
4251 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4253 * buffer.h: Include <sys/types.h> instead of <time.h>.
4254 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4255 Problem reported by Herbert J. Skuhra.
4257 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4259 * xml.c (parse_region): Make the parsing work for
4260 non-comment-starting XML files again (bug#9144).
4262 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4264 * image.c (gif_load): Fix calculation of bottom and right corner.
4267 2011-09-10 Eli Zaretskii <eliz@gnu.org>
4269 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4270 redisplay in small windows.
4272 2011-09-09 Eli Zaretskii <eliz@gnu.org>
4274 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4276 2011-09-08 Martin Rudalics <rudalics@gmx.at>
4278 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4279 Operate on live windows only.
4281 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
4283 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4285 2011-09-07 Eli Zaretskii <eliz@gnu.org>
4287 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4288 only under bidi iteration.
4290 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4292 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4294 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4296 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4297 Without this fix, the command to link temacs failed due to an
4298 undefined symbol __builtin_isnan. This is because
4299 /usr/include/iso/math_c99.h #defines isnan(x) to
4300 __builtin_isnan(x), but the bundled gcc, which identifies itself
4301 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4303 * floatfns.c (isnan): #undef, and then #define to a clone of
4305 (Fisnan): Always define, since it's always available now.
4306 (syms_of_floatfns): Always define isnan at the Lisp level.
4308 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4310 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4312 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4314 * fileio.c: Fix bugs with large file offsets (Bug#9428).
4315 The previous code assumed that file offsets (off_t values) fit in
4316 EMACS_INT variables, which is not true on typical 32-bit hosts.
4317 The code messed up by falsely reporting buffer overflow in cases
4318 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4319 when "big" contains more than 2**29 bytes, even though this
4320 inserts just one byte and does not overflow the buffer.
4321 (Finsert_file_contents): Store file offsets as off_t
4322 values, not as EMACS_INT values. Check for overflow when
4323 converting between EMACS_INT and off_t. When checking for
4324 buffer overflow or for overlap, take the offsets into account.
4325 Don't use EMACS_INT for small values where int suffices.
4326 When checking for overlap, fix a typo: ZV was used where
4327 ZV_BYTE was intended.
4328 (Fwrite_region): Don't assume off_t fits into 'long'.
4329 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4331 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
4333 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4335 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4337 sprintf-related integer and memory overflow issues (Bug#9412).
4339 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
4340 (esprintf, exprintf, evxprintf): New functions.
4341 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
4342 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
4343 (modify_event_symbol): Do not assume that the length of
4344 name_alist_or_stem is safe to alloca and fits in int.
4345 (Fexecute_extended_command): Likewise for function name and binding.
4346 (Frecursion_depth): Wrap around reliably on integer overflow.
4347 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4348 since some callers pass EMACS_INT values.
4349 (Fsingle_key_description): Don't crash if symbol name contains more
4350 than MAX_ALLOCA bytes.
4351 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4352 (get_minibuffer): Arg is now EMACS_INT, not int.
4353 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
4354 (esprintf, exprintf, evxprintf): New decls.
4355 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4357 * dbusbind.c (signature_cat): New function.
4358 (xd_signature, Fdbus_register_signal):
4359 Do not overrun buffer; instead, report string overflow.
4361 * dispnew.c (add_window_display_history): Don't overrun buffer.
4362 Truncate instead; this is OK since it's just a log.
4364 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4365 even if the time zone offset is outlandishly large.
4366 Don't mishandle offset == INT_MIN.
4368 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4369 when creating daemon; the previous buffer-overflow check was incorrect.
4371 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4372 which has the guts of the old verror function.
4374 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4375 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4377 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4378 (font_unparse_xlfd): Don't blindly alloca long strings.
4379 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
4380 fits in int, when using sprintf. Use single snprintf to count
4381 length of string rather than counting it via multiple sprintfs;
4382 that's simpler and more reliable.
4383 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4384 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4385 sprintf, in case result does not fit in int.
4387 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4388 (fontset_from_font): Print it.
4390 * frame.c (tty_frame_count): Now printmax_t, not int.
4391 (make_terminal_frame, set_term_frame_name): Print it.
4392 (x_report_frame_params): In X, window IDs are unsigned long,
4393 not signed long, so print them as unsigned.
4394 (validate_x_resource_name): Check for implausibly long names,
4395 and don't assume name length fits in 'int'.
4396 (x_get_resource_string): Don't blindly alloca invocation name;
4397 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4400 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4401 (xg_check_special_colors, xg_set_geometry):
4402 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4404 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4405 Use esprintf, not sprintf, in case result does not fit in int.
4407 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4408 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4409 it as a large positive number.
4410 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4411 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4413 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4414 in case result does not fit in int.
4416 * print.c (float_to_string): Detect width overflow more reliably.
4417 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4418 buffer overrun. Don't assume list length fits in 'int'. Treat
4419 print length of 0 as 0, not as infinity; to be consistent with other
4420 uses of print length in this function. Don't overflow print length
4421 index. Don't assume hash table size fits in 'long', or that
4422 vectorlike size fits in 'unsigned long'.
4424 * process.c (make_process): Use printmax_t, not int, to format
4425 process-name gensyms.
4427 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4429 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4430 to avoid potential buffer overrun.
4432 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4433 if X resource line is longer than 512 bytes.
4435 * xfns.c (x_window): Make sprintf buffer a bit bigger
4436 to avoid potential buffer overrun.
4438 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4440 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4442 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4444 Integer overflow fixes for scrolling, etc.
4445 Without these, Emacs silently mishandles large integers sometimes.
4446 For example, "C-u 4294967297 M-x recenter" was treated as if
4447 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4449 * xdisp.c (try_window_id): Check Emacs fixnum range before
4450 converting to 'int'.
4452 * window.c (window_scroll_line_based, Frecenter):
4453 Check that an Emacs fixnum is in range before assigning it to 'int'.
4454 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4455 values converted from Emacs fixnums.
4456 (Frecenter): Don't wrap around a line count if it is out of 'int'
4457 range; instead, treat it as an extreme value.
4458 (Fset_window_configuration, compare_window_configurations):
4459 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4461 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4462 that can exceed INT_MAX. Check that EMACS_INT value is in range
4463 before assigning it to the (possibly-narrower) index.
4464 (match_limit): Don't assume that a fixnum can fit in 'int'.
4466 * print.c (print_object): Use ptrdiff_t, not int, for index that can
4469 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
4470 (Fvertical_motion): Don't wrap around LINES values that don't fit
4471 in 'int'. Instead, treat them as extreme values. This is good
4472 enough for windows, which can't have more than INT_MAX lines anyway.
4474 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4476 * Require libxml/parser.h to avoid compilation warning.
4478 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4480 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4481 since this reportedly can destroy thread storage.
4483 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
4485 * syntax.c (find_defun_start): Update all cache variables if
4486 exiting early (Bug#9401).
4488 2011-08-30 Eli Zaretskii <eliz@gnu.org>
4490 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4492 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4493 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4494 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4496 * term.c (tty_append_glyph): New function.
4497 (produce_stretch_glyph): Static function and its prototype deleted.
4499 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4502 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4504 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4505 when checking :margin (Bug#9390).
4506 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
4507 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
4508 so that the name doesn't mislead. All uses changed.
4510 2011-08-28 Johan Bockgård <bojohan@gnu.org>
4512 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4515 2011-08-27 Eli Zaretskii <eliz@gnu.org>
4517 * xdisp.c (move_it_to): Don't bail out early when reaching
4518 position beyond to_charpos, if we are scanning backwards.
4519 (move_it_vertically_backward): When DY == 0, make sure we get to
4520 the first character in the line after the newline.
4522 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4524 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4525 (ccl_driver): Do not generate an out-of-range pointer.
4526 (Fccl_execute_on_string): Remove unnecessary check for
4527 integer overflow, noted by Stefan Monnier in
4528 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4529 Remove a FIXME that didn't need fixing.
4530 Simplify the newly-introduced buffer reallocation code.
4532 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
4534 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4536 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
4538 Integer and memory overflow issues (Bug#9196).
4540 * doc.c (get_doc_string): Rework so that
4541 get_doc_string_buffer_size is the actual buffer size, rather than
4542 being 1 less than the actual buffer size; this makes xpalloc more
4545 * image.c (x_allocate_bitmap_record, cache_image):
4546 * xselect.c (Fx_register_dnd_atom):
4547 Simplify previous changes by using xpalloc.
4549 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4550 since either will do and ptrdiff_t is convenient with xpalloc.
4552 * charset.c (charset_table_size)
4553 (struct charset_sort_data.priority): Now ptrdiff_t.
4554 (charset_compare): Don't overflow if priorities differ greatly.
4555 (Fsort_charsets): Don't assume list length fits in int.
4556 Check for size-calculation overflow when allocating sort data.
4557 (syms_of_charset): Allocate an initial charset table that is
4558 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4560 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4562 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4563 The actual value is always <= INT_MAX, and leaving it unsigned made
4564 overflow checking harder.
4566 * dispextern.h (struct glyph_matrix.rows_allocated)
4567 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4568 with xpalloc. The values are still always <= INT_MAX.
4570 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4572 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4573 (SAFE_NALLOCA): New macro.
4575 * region-cache.c (struct boundary.pos, find_cache_boundary)
4576 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4577 (set_cache_region, invalidate_region_cache)
4578 (revalidate_region_cache, know_region_cache, region_cache_forward)
4579 (region_cache_backward, pp_cache):
4580 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4581 so that ptrdiff_t * can be passed to xpalloc.
4582 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4583 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4584 (pp_cache): Don't assume cache_len fits in int.
4585 * region-cache.h: Adjust extern decls to match.
4587 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4588 EMACS_INT, since either will do, for xpalloc.
4590 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4591 (xnmalloc, xnrealloc, xpalloc): New functions.
4593 * bidi.c (bidi_shelve_header_size): New constant.
4594 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4595 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4597 * bidi.c (bidi_cache_shrink):
4598 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4600 Don't update size of array until after memory allocation succeeds,
4601 because xmalloc/xrealloc may not return.
4602 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4603 now that we have proper integer overflow checking.
4604 (record_overlay_string, overlay_strings): Catch overflows when
4605 calculating size of overlay_str_buf.
4607 * callproc.c (Fcall_process): Check for size overflow when
4608 calculating size of args2.
4609 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4610 Normally we prefer signed values, but sticking with ptrdiff_t would
4611 require adding more-complicated checks.
4613 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4614 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4615 Redo buffer-overflow calculations to avoid integer overflow.
4616 Add a FIXME comment where memory seems to be over-allocated.
4618 * character.c (Fstring): Check for size-calculation overflow.
4620 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4621 unnecessary integer overflow. Check for size overflow.
4622 (encode_coding_object): Don't update size until xmalloc succeeds.
4624 * composite.c (get_composition_id): Check for overflow in glyph
4625 length calculations.
4627 Integer and memory overflow fixes for display code.
4628 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4629 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4630 (scrolling_window): Check for overflow in size calculations.
4631 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4632 Don't assume glyph table len fits in int.
4633 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4634 (row_table_size): Now ptrdiff_t, not int.
4635 (scrolling_window): Avoid overflow in size calculations.
4636 Don't update size until allocation succeeds.
4637 * fns.c (concat): Check for overflow in size calculations.
4638 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4639 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4640 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4642 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4643 (get_doc_string): Check for size calculation overflow.
4644 Don't update size until allocation succeeds.
4645 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4646 EMACS_INT, where ptrdiff_t will do.
4647 (Fsubstitute_command_keys): Check for string overflow.
4649 * editfns.c (set_time_zone_rule): Don't assume environment length
4651 (message_length): Now ptrdiff_t, not int.
4652 (Fmessage_box): Don't update size until allocation succeeds.
4653 Don't assume message length fits in int.
4654 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4656 * emacs.c (main): Do not reallocate argv, since there is a null at
4657 the end that can be overwritten, and this way there's no need to
4658 worry about size-calculation overflow.
4659 (sort_args): Check for size-calculation overflow.
4661 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4663 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4665 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4666 (x_set_scroll_bar_width, x_figure_window_size):
4667 Check for integer overflow.
4668 (x_set_alpha): Do not assume XINT fits in int.
4670 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4671 This is for the members text_lines, text_cols, total_lines, total_cols,
4672 where the system imposes an 'int' limit.
4674 * fringe.c (Fdefine_fringe_bitmap):
4675 Don't update size until alloc works.
4677 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4678 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4680 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4681 Check for size-calculation overflow.
4682 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4683 do, as we prefer signed integers.
4684 (id_to_widget.max_size, id_to_widget.used)
4685 (xg_store_widget_in_map, xg_remove_widget_from_map)
4686 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4687 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4688 Use and return ptrdiff_t, not int.
4689 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4690 * gtkutil.h: Change prototypes to match the above.
4692 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4693 are duplicate now that they've been promoted to lisp.h.
4694 (x_allocate_bitmap_record, x_alloc_image_color)
4695 (make_image_cache, cache_image, xpm_load):
4696 Don't update size until alloc is done.
4697 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4699 Check for size calculation overflow.
4700 (ct_colors_allocated_max): New constant.
4701 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4704 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4705 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4706 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4707 Use ptrdiff_t, not int, to count maps.
4708 (read_char_minibuf_menu_prompt): Check for overflow in size
4709 calculations. Don't update size until allocation succeeds.
4710 Redo calculations to avoid overflow.
4711 * keyboard.h: Change prototypes to match the above.
4713 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4715 (current_minor_maps): Check for size calculation overflow.
4716 * keymap.h: Change prototypes to match the above.
4718 * lread.c (read1, init_obarray): Don't update size until alloc done.
4720 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4721 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4723 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4724 Now ptrdiff_t, not int.
4725 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4726 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4728 * process.c (Fnetwork_interface_list): Check for overflow
4729 in size calculation.
4731 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4733 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4734 overflow. Don't bother calling xmalloc when xrealloc will do.
4736 * search.c (Freplace_match): Check for size calculation overflow.
4737 (Fset_match_data): Don't assume list lengths fit in 'int'.
4739 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4740 for command line length. Do not attempt to address one before the
4741 beginning of an array, as that's not portable.
4743 * term.c (max_frame_lines): Remove; unused.
4744 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4746 (encode_terminal_code, calculate_costs): Check for size
4747 calculation overflow.
4748 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4749 table lengths and related sizes. Don't update size until alloc
4750 done. Redo calculations to avoid overflow.
4751 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4753 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4754 subtracting pointers.
4755 (gobble_line): Check for overflow more carefully. Don't update size
4758 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4759 Don't update size until alloc done.
4760 Redo size calculations to avoid overflow.
4761 Check for size calculation overflow.
4762 (main) [DEBUG]: Fix typo in invoking tparam1.
4764 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4765 Use ptrdiff_t, not int, for sizes.
4766 (store_mode_line_noprop_char): Don't update size until alloc done.
4768 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4769 Use ptrdiff_t, not int, for sizes.
4770 (Finternal_make_lisp_face, cache_face):
4771 Check for size calculation overflow.
4772 (cache_face): Treat size calculation overflows as if they were
4773 memory exhaustion (the usual treatment), rather than aborting.
4775 * xfns.c (x_encode_text, x_set_name_internal)
4776 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4777 sizes, since they can exceed INT_MAX in size. Check for size
4778 calculation overflow.
4780 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4781 (xg_select): Check for size calculation overflow.
4782 Don't update size until alloc done.
4784 * xrdb.c (get_environ_db): Don't assume path length fits in int,
4785 as sprintf is limited to int lengths.
4787 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4788 (X_LONG_MIN): New macros.
4789 Use them to make the following changes clearer.
4790 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4791 This change doesn't affect the value now, but it may help remind
4792 future maintainers not to raise the value too much later.
4793 (SELECTION_QUANTUM): Remove, replacing with ...
4794 (selection_quantum): ... new function, which avoids overflow.
4796 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4797 assumption that selection length fits in 'int'.
4798 (x_reply_selection_request, x_handle_selection_request)
4799 (x_get_window_property, receive_incremental_selection)
4800 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4801 (lisp_data_to_selection_data, clean_local_selection_data):
4802 Use ptrdiff_t, not int, to record length of selection.
4803 (x_reply_selection_request, x_get_window_property)
4804 (receive_incremental_selection, x_property_data_to_lisp):
4805 Redo calculations to avoid overflow.
4806 (x_reply_selection_request): When sending hint, ceiling it at
4807 X_LONG_MAX rather than relying on wraparound overflow to send
4809 (x_get_window_property, receive_incremental_selection)
4810 (lisp_data_to_selection_data, x_property_data_to_lisp):
4811 Check for size-calculation overflow.
4812 (x_get_window_property, receive_incremental_selection)
4813 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4814 Don't store size until memory allocation succeeds.
4815 (x_get_window_property): Plug memory leak on memory exhaustion.
4816 Don't double-block input; malloc is safe here. Don't assume 2**34
4817 - 4 fits in unsigned long. Add an xassert to check
4818 XGetWindowProperty overflow. Be more careful about overflow
4819 calculations, and distinguish size from memory overflow better.
4820 (receive_incremental_selection): When tracing, don't assume
4821 unsigned int is less than INT_MAX.
4822 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4823 harmful) conversions of unsigned short to int.
4824 (lisp_data_to_selection_data): Don't assume that integers
4825 in the range -65535 through -1 fit in an X unsigned short.
4826 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4827 result parameters unless successful. Rely on cons_to_unsigned
4828 to report problems with elements; the old code wasn't right anyway.
4829 (x_check_property_data): Check for int overflow; we cannot use
4830 a wider type due to X limits.
4831 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4833 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
4835 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4836 (x_term_init): Check for size calculation overflow.
4837 (x_color_cells): Don't store size until memory allocation succeeds.
4838 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
4839 Don't assume alloca size is less than MAX_ALLOCA.
4840 (x_term_init): Don't assume length fits in int (sprintf is limited
4843 Use ptrdiff_t for composition IDs.
4844 * character.c (lisp_string_width):
4845 * composite.c (composition_table_size, n_compositions)
4846 (get_composition_id, composition_gstring_from_id):
4847 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4848 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4849 * window.c (Frecenter):
4850 Use ptrdiff_t, not int, for composition IDs.
4851 * composite.c (get_composition_id): Check for integer overflow.
4852 * composite.h: Adjust prototypes to match the above changes.
4854 Use ptrdiff_t for hash table indexes.
4855 * category.c (hash_get_category_set):
4856 * ccl.c (ccl_driver):
4857 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4858 * coding.c (coding_system_charset_list, detect_coding_system):
4859 * coding.h (struct coding_system.id):
4860 * composite.c (get_composition_id, gstring_lookup_cache):
4861 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4862 * image.c (xpm_get_color_table_h):
4863 * lisp.h (hash_lookup, hash_put):
4864 * minibuf.c (Ftest_completion):
4865 Use ptrdiff_t for hash table indexes, not int (which is too
4866 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4867 32-bit --with-wide-int hosts).
4869 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4870 Add a FIXME comment about memory leaks.
4871 (syms_of_charset): Don't assume xmalloc returns.
4873 Don't assume that stated character widths fit in int.
4874 * character.c (Fchar_width, c_string_width, lisp_string_width):
4875 * character.h (CHAR_WIDTH):
4876 * indent.c (MULTIBYTE_BYTES_WIDTH):
4877 Use sanitize_char_width to avoid undefined and/or bad behavior
4878 with outlandish widths.
4879 * character.h (sanitize_tab_width): Rename from sanitize_width,
4880 now that we have two such functions. All uses changed.
4881 (sanitize_char_width): New inline function.
4883 Don't assume that tab-width fits in int.
4884 * character.h (sanitize_width): New inline function.
4885 (SANE_TAB_WIDTH): New macro.
4886 (ASCII_CHAR_WIDTH): Use it.
4887 * indent.c (sane_tab_width): Remove. All uses replaced by
4888 SANE_TAB_WIDTH (current_buffer).
4889 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4891 * fileio.c: Integer overflow issues with file modes.
4892 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4894 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4895 Remove unreachable code.
4896 (read_hex, load_charset_map_from_file): Check for integer overflow.
4898 * xterm.c: Don't go over XClientMessageEvent limit.
4899 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4900 (x_send_scroll_bar_event): Likewise. Check that the size does not
4901 exceed limits imposed by XClientMessageEvent, as well as the usual
4902 ptrdiff_t and size_t limits.
4904 * keyboard.c: Overflow, signedness and related fixes.
4905 (make_lispy_movement): Use same integer type in forward decl
4906 that is used in the definition.
4907 (read_key_sequence, keyremap_step):
4908 Change bufsize argument back to int, undoing my 2011-03-30 change.
4909 We prefer signed types, and int is wide enough here.
4910 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4911 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4912 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4913 length, not size_t. Use ptrdiff_t for index, not int.
4914 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4915 possibility of integer overflow.
4917 Overflow, signedness and related fixes for images.
4919 * dispextern.h (struct it.stack[0].u.image.image_id)
4920 (struct_it.image_id, struct image.id, struct image_cache.size)
4921 (struct image_cache.used, struct image_cache.ref_count):
4922 * gtkutil.c (update_frame_tool_bar):
4923 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4924 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4925 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4926 * nsmenu.m (update_frame_tool_bar):
4927 * xdisp.c (calc_pixel_width_or_height):
4928 * xfns.c (image_cache_refcount):
4929 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4930 on typical 64-bit hosts.
4932 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4933 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4934 Omit unnecessary casts to int.
4935 (parse_image_spec): Check that integers fall into 'int' range
4936 when the callers expect that.
4937 (image_ascent): Redo ascent calculation to avoid int overflow.
4938 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4939 (lookup_image): Remove unnecessary tests.
4940 (xbm_image_p): Locals are now of int, not EMACS_INT,
4941 since parse_image_check makes sure they fit into int.
4942 (png_load, gif_load, svg_load_image):
4943 Prefer int to unsigned where either will do.
4944 (tiff_handler): New function, combining the cores of the
4945 old tiff_error_handler and tiff_warning_handler.
4946 This function is rewritten to use vsnprintf and thereby avoid
4947 stack buffer overflows. It uses only the features of vsnprintf
4948 that are common to both POSIX and native Microsoft.
4949 (tiff_error_handler, tiff_warning_handler): Use it.
4950 (tiff_load, gif_load, imagemagick_load_image):
4951 Don't assume :index value fits in 'int'.
4952 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4953 (imagemagick_load_image): Check that crop parameters fit into
4954 the integer types that MagickCropImage accepts. Don't assume
4955 Vimagemagick_render_type has a nonnegative value. Don't assume
4956 size_t fits in 'long'.
4957 (gs_load): Use printmax_t to print the widest integers possible.
4958 Check for integer overflow when computing image height and width.
4960 2011-08-26 Eli Zaretskii <eliz@gnu.org>
4962 * xdisp.c (redisplay_window): Don't force window start if point
4963 will be invisible in the resulting window. (Bug#9324)
4965 2011-08-25 Eli Zaretskii <eliz@gnu.org>
4967 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4968 the display spec is of the form `(space ...)'.
4969 (handle_display_spec): Return the value returned by
4970 handle_single_display_spec, not just 1 or zero.
4971 (handle_single_display_spec): If the display spec is of the form
4972 `(space ...)', and specifies display in the text area, return 2
4974 (try_cursor_movement): Check for the need to scroll more
4975 accurately, and prefer exact match for point under bidi.
4976 Don't advance `row' beyond the last row of the window.
4978 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
4979 into disp_prop; all users changed.
4981 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
4982 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
4983 for the text covered by the display property.
4985 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
4987 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
4988 Change return value to nil.
4989 (Frecord_buffer): Delete unused function.
4991 2011-08-24 Eli Zaretskii <eliz@gnu.org>
4993 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4994 buffers, return left-to-right.
4995 (set_cursor_from_row): Consider candidate row a win if its glyph
4996 represents a newline and point is on that newline. Fixes cursor
4997 positioning on the newline at EOL of R2L text within L2R
4998 paragraph, and vice versa.
4999 (try_cursor_movement): Check continued rows, in addition to
5000 continuation rows. Fixes unwarranted scroll when point enters a
5001 continued line of R2L text within an L2R paragraph, or vice versa.
5002 (cursor_row_p): Consider the case of point being equal to
5003 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5004 from the end of a short line to the beginning of a continued line
5005 of R2L text within L2R paragraph.
5006 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5007 composed characters.
5009 * bidi.c (bidi_check_type): Use xassert.
5010 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5013 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5015 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5018 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
5020 * nsfont.m (ns_otf_to_script): Fix typo.
5022 2011-08-22 Kenichi Handa <handa@m17n.org>
5024 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5025 extra slot even if the purpose is char-code-property-table.
5027 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5029 * xdisp.c (redisplay_window): When computing centering_position,
5030 account for the height of the header line. (Bug#8874)
5032 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5033 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5034 candidate is selected by the mouse, and that candidate has a
5035 composed character under the mouse.
5037 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5038 coordinates reported by pos-visible-in-window-p for a composed
5039 character in column zero.
5041 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5043 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5045 2011-08-22 Eli Zaretskii <eliz@gnu.org>
5047 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5048 consider it a hit if to_charpos is anywhere in the range of the
5049 composed buffer positions.
5051 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
5053 * image.c (gif_load): Don't assume that each subimage has the same
5054 dimensions as the base image. Handle disposal method that is
5055 "undefined" by the gif spec (Bug#9335).
5057 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
5059 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
5060 (Fcondition_case): Document `debug' symbol in error handler.
5062 2011-08-19 Eli Zaretskii <eliz@gnu.org>
5064 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5065 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5066 from an Org mode buffer to a Speedbar frame.
5068 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5069 a composition, take its buffer position from IT->cmp_it.charpos.
5070 Fixes cursor positioning at the beginning of a line that begins
5071 with a composed character.
5073 2011-08-18 Eli Zaretskii <eliz@gnu.org>
5075 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5076 character bidirectional type, use STRONG_L instead. Fixes crashes
5077 in a buffer produced by `describe-categories'.
5079 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5080 members before the level stack, so they would be saved and
5081 restored when copying iterator state. Fixes incorrect reordering
5082 around TABs covered by display properties.
5084 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5086 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
5088 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
5090 * eval.c (internal_condition_case, internal_condition_case_1)
5091 (internal_condition_case_2, internal_condition_case_n):
5092 Remove unnecessary aborts (Bug#9081).
5094 2011-08-17 Eli Zaretskii <eliz@gnu.org>
5096 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5097 has no `load' handler, try opening the file locally. (Bug#9311)
5099 2011-08-16 Ken Brown <kbrown@cornell.edu>
5101 * gmalloc.c: Expand comment.
5103 2011-08-16 Eli Zaretskii <eliz@gnu.org>
5105 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5106 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5108 2011-08-16 Ken Brown <kbrown@cornell.edu>
5110 Fix memory allocation problems in Cygwin build (Bug#9273).
5112 * unexcw.c ( __malloc_initialized): Declare external variable.
5113 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5115 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5117 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5119 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5121 [CYGWIN] (special_realloc): New function.
5122 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5123 requests to realloc storage in the static heap.
5125 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5127 * bidi.c (bidi_initialize): Remove unused local.
5129 2011-08-15 Eli Zaretskii <eliz@gnu.org>
5132 * biditype.h: Remove file.
5133 * makefile.w32-in ($(BLD)/bidi.$(O)):
5134 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
5136 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5138 * chartab.c: Improve commentary for the uniprop_table API.
5140 * bidi.c (bidi_paragraph_init): Support zero value of
5141 bidi_ignore_explicit_marks_for_paragraph_level.
5142 (bidi_initialize): Use uniprop_table instead of including
5143 biditype.h and bidimirror.h.
5145 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5146 coordinates of the iterator when restoring from ppos_it.
5149 2011-08-14 Kenichi Handa <handa@m17n.org>
5151 * process.c (create_process): Call setup_process_coding_systems
5152 after the pid of the process is set to -1 (Bug#8162).
5154 2011-08-14 Eli Zaretskii <eliz@gnu.org>
5156 * xdisp.c (move_it_in_display_line_to): Don't invoke
5157 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5158 ppos_it. Fixes vertical cursor motion when line beginning is
5159 covered by an image. (Bug#9296)
5161 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5163 * nsterm.h (ns_run_ascript): Declare.
5164 (NSAPP_DATA2_RUNASSCRIPT): Define.
5166 * nsfns.m (as_script, as_result, as_status): New static variables.
5167 (ns_run_ascript): New function.
5168 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
5169 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5170 the event loop. Get status from as_status (Bug#7276).
5172 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5173 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5174 the event loop (Bug#7276).
5176 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5178 * gnutls.c (QCgnutls_bootprop_priority)
5179 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5180 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5181 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5182 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5183 (QCgnutls_bootprop_verify_hostname_error)
5184 (QCgnutls_bootprop_callbacks_verify): Rename from
5185 Qgnutls_bootprop_..., all uses changed.
5187 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5190 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5192 * xfaces.c (Qframe_set_background_mode): Now static.
5193 * dispextern.h (Qframe_set_background_mode): Remove decl.
5195 * process.c (Fnetwork_interface_info): Declare local only if needed.
5197 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5199 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5200 (Fnetwork_interface_list): Allocate in increments of bytes instead
5201 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5202 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5204 (struct ifflag_def): notrailers is smart on OSX.
5205 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5206 Get hardware address with getifaddrs if available.
5208 2011-08-12 Eli Zaretskii <eliz@gnu.org>
5210 * xdisp.c (iterate_out_of_display_property): xassert that
5211 IT->position is set to within IT->object's boundaries. Break from
5212 the loop as soon as EOB is reached; avoids infloops in redisplay
5213 when IT->position is set up wrongly due to some bug.
5214 Set IT->current to match the bidi iterator unconditionally.
5215 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5216 entry. Force push_it to save on the stack the current
5217 buffer/string position, to be restored by pop_it. Fix flags in
5218 the iterator structure wrt the object coming from a display
5219 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5220 properties. (Bug#9284)
5222 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
5224 * fontset.c (fontset_get_font_group): Add proper type checks.
5227 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5229 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5230 and LC_VERSION_MIN_MACOSX.
5231 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5232 (dump_it) [LC_FUNCTION_STARTS]: Use it.
5234 2011-08-08 Eli Zaretskii <eliz@gnu.org>
5236 * xdisp.c (forward_to_next_line_start): Allow to use the
5237 no-display-properties-and-no-overlays under bidi display.
5238 Set disp_pos in the bidi iterator to avoid searches for display
5239 properties and overlays.
5241 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
5243 * editfns.c (Fset_time_zone_rule): Document relationship with the
5246 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5247 the font entity extracted from the cache (Bug#8109).
5249 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
5251 * composite.c (autocmp_chars): Don't reset point. That is done by
5252 restore_point_unwind (Bug#5984).
5254 2011-08-07 Juri Linkov <juri@jurta.org>
5256 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5257 to show the arg `TIME' instead of `TIMEVAL'.
5259 2011-08-06 Eli Zaretskii <eliz@gnu.org>
5261 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5262 display property strides EOL and includes a newline, as in
5263 longlines-mode. (Bug#9254)
5264 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5265 word-wrap under bidirectional display. (Bug#9224)
5267 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5268 is non-zero, even if the data buffer is NULL. Fixes a crash in
5269 vertical-motion with longlines-mode. (Bug#9254)
5271 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5273 * bidi.c <bidi_cache_total_alloc>: Now static.
5274 (bidi_initialize): Initialize bidi_cache_total_alloc.
5276 * xdisp.c (display_line): Release buffer allocated for shelved bidi
5279 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5280 amount allocated this far in `bidi_cache_total_alloc'.
5281 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5282 non-zero, only free the data buffer without restoring the cache
5283 contents. All callers changed.
5285 * dispextern.h (bidi_unshelve_cache): Update prototype.
5287 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5288 (move_it_in_display_line, move_it_to)
5289 (move_it_vertically_backward, move_it_by_lines): Replace the call
5290 to xfree to an equivalent call to bidi_unshelve_cache.
5291 (move_it_in_display_line_to): Fix logic of returning
5292 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
5294 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5296 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5297 came from a string character with a `cursor' property. (Bug#9229)
5299 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5301 * Makefile.in (LIB_PTHREAD): New variable.
5302 (LIBES): Add LIB_PTHREAD (Bug#9216).
5304 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5305 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5307 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5309 * regex.c (re_iswctype): Remove some redundant boolean conversions.
5311 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5313 * xterm.c (x_find_topmost_parent): New function.
5314 (x_set_frame_alpha): Find topmost parent window with
5315 x_find_topmost_parent and set the property there also (bug#9181).
5316 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5318 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5320 * callproc.c (Fcall_process): Avoid vfork clobbering
5321 the local vars buffer, coding_systems, current_dir.
5323 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5325 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5327 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5329 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5330 so that it is not optimized away.
5332 * xdisp.c (compute_display_string_pos): Remove unused local.
5334 2011-08-02 Eli Zaretskii <eliz@gnu.org>
5336 Fix slow cursor motion and scrolling in large buffers with
5337 selective display, like Org Mode buffers. (Bug#9218)
5339 * dispextern.h (struct bidi_it): New member disp_prop_p.
5341 * xdisp.c: Remove one-slot cache of display string positions.
5342 (compute_display_string_pos): Accept an additional argument
5343 DISP_PROP_P; callers changed. Scan at most 5K characters forward
5344 for a display string or property. If found, set DISP_PROP_P
5347 * bidi.c (bidi_fetch_char): Accept an additional argument
5348 DISP_PROP_P, and pass it to compute_display_string_pos.
5349 Only handle text covered by a display string if DISP_PROP_P is returned
5350 non-zero. All callers of bidi_fetch_char changed.
5352 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5354 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5356 2010-12-03 Don March <don@ohspite.net>
5358 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5359 last character M-[char] is translated to ESC [char] (bug#7541).
5361 2011-08-02 Kenichi Handa <handa@m17n.org>
5363 * lisp.h (uniprop_table): Extern it.
5365 * chartab.c (uniprop_table): Make it non-static.
5367 2011-08-01 Eli Zaretskii <eliz@gnu.org>
5369 * xdisp.c (forward_to_next_line_start): Accept additional argument
5370 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5372 (reseat_at_next_visible_line_start): Use the bidi iterator state
5373 returned by forward_to_next_line_start to restore the state of
5374 it->bidi_it after backing up to previous newline. (Bug#9212)
5376 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5378 * regex.c (re_comp): Protoize.
5379 (re_exec): Fix return type.
5380 (regexec): Fix type of `ret'. (Bug#9203)
5382 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5384 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5385 This is needed if max-image-size is a floating-point number.
5387 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5389 * print.c (print_object): Print empty symbol as ##.
5391 * lread.c (read1): Read ## as empty symbol.
5393 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5395 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5396 setting frame foreground color (Bug#9175).
5397 (x_set_background_color): Likewise.
5399 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5400 contents (Bug#9176).
5401 (EmacsTooltip -init): Remove bezels and add shadows to
5404 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5405 or scroll bar (Bug#8470).
5407 * nsfont.m (nsfont_open): Remove assignment to voffset and
5408 unnecessary vars hshink, expand, hd, full_height, min_height.
5409 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5411 * nsterm.h (nsfont_info): Remove voffset field.
5413 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5415 Implement strike-through and overline on NextStep (Bug#8863).
5417 * nsfont.m (nsfont_open): Use underline position provided by font,
5418 instead of hard-coded value of 2.
5419 (nsfont_draw): Call ns_draw_text_decoration instead.
5421 * nsterm.h: Add declaration for ns_draw_text_decoration.
5423 * nsterm.m (ns_draw_text_decoration): New function for drawing
5424 underline, overline, and strike-through.
5425 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5426 ns_draw_text_decoration. Change treatment of cursor drawing to
5427 accommodate underlining, etc.
5429 2011-07-28 Eli Zaretskii <eliz@gnu.org>
5431 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5434 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5436 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5437 Without this fix, if a signal arrives just after memory fills up,
5438 'malloc' might be invoked reentrantly.
5440 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5441 In other words, assume that every image size is allowed, on non-X
5442 hosts. This assumption is probably wrong, but it lets Emacs compile.
5444 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5446 * regex.c (re_iswctype): Convert return values to boolean.
5448 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5450 * xdisp.c (compute_display_string_pos): Don't use cached display
5451 string position if the buffer had its restriction changed.
5454 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5456 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5458 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5460 Integer signedness and overflow and related fixes. (Bug#9079)
5462 * bidi.c: Integer size and overflow fixes.
5463 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5464 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5465 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5466 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5467 (bidi_find_other_level_edge):
5468 Use ptrdiff_t instead of EMACS_INT where either will do.
5469 This works better on 32-bit hosts configured --with-wide-int.
5470 (bidi_cache_ensure_space): Check for size-calculation overflow.
5471 Use % rather than repeated addition, for better worst-case speed.
5472 Don't set bidi_cache_size until after xrealloc returns, because it
5474 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
5475 (bidi_cache_ensure_space): Also check that the bidi cache size
5476 does not exceed that of the largest Lisp string or buffer. See Eli
5477 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
5479 * alloc.c (__malloc_size_t): Remove.
5480 All uses replaced by size_t. See Andreas Schwab's note
5481 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5483 * image.c: Improve checking for integer overflow.
5484 (check_image_size): Assume that f is nonnull, since
5485 it is always nonnull in practice. This is one less thing to
5486 worry about when checking for integer overflow later.
5487 (x_check_image_size): New function, which checks for integer
5488 overflow issues inside X.
5489 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5490 This removes the need for a memory_full check.
5491 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5492 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5493 (xbm_read_bitmap_data): Change locals back to 'int', since
5494 their values must fit in 'int'.
5495 (xpm_load_image, png_load, tiff_load):
5496 Invoke x_create_x_image_and_pixmap earlier,
5497 to avoid much needless work if the image is too large.
5498 (tiff_load): Treat overly large images as if
5499 x_create_x_image_and_pixmap failed, not as malloc failures.
5500 (gs_load): Use x_check_image_size.
5502 * gtkutil.c: Omit integer casts.
5503 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5504 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5506 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5508 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5509 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5510 would wrongly return t on a 64-bit host.
5512 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5513 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5514 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5515 and therefore cause GCC to emit a bogus diagnostic in some cases.
5517 * image.c: Integer signedness and overflow and related fixes.
5518 This is not an exhaustive set of fixes, but it's time to
5519 record what I've got.
5520 (lookup_pixel_color, check_image_size): Remove redundant decls.
5521 (check_image_size): Don't assume that arbitrary EMACS_INT values
5522 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5523 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5524 (tiff_load, imagemagick_load_image):
5525 Check for overflow in size calculations.
5526 (x_create_x_image_and_pixmap): Remove unnecessary test for
5527 xmalloc returning NULL; that can't happen.
5528 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5529 (xpm_color_bucket): Use better integer hashing function.
5530 (xpm_cache_color): Don't possibly over-allocate memory.
5531 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5532 (gif_memory_source):
5533 Use ptrdiff_t, not int or size_t, to record sizes.
5534 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5535 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5536 either works, as we prefer signed integers.
5537 (tiff_read_from_memory, tiff_write_from_memory):
5538 Return tsize_t, not size_t, since that's what the TIFF API wants.
5539 (tiff_read_from_memory): Don't fail simply because the read would
5540 go past EOF; instead, return a short read.
5541 (tiff_load): Omit no-longer-needed casts.
5542 (Fimagemagick_types): Don't assume size fits into 'int'.
5544 Improve hashing quality when configured --with-wide-int.
5545 * fns.c (hash_string): New function, taken from sxhash_string.
5546 Do not discard information about ASCII character case; this
5547 discarding is no longer needed.
5548 (sxhash-string): Use it. Change sig to match it. Caller changed.
5549 * lisp.h: Declare it.
5550 * lread.c (hash_string): Remove, since we now use fns.c's version.
5551 The fns.c version returns a wider integer if --with-wide-int is
5552 specified, so this should help the quality of the hashing a bit.
5554 * emacs.c: Integer overflow minor fix.
5555 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5556 Define only if GNU_LINUX.
5557 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5559 * dispnew.c: Integer signedness and overflow fixes.
5560 Remove unnecessary forward decls, that were a maintenance hassle.
5561 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5563 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5564 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5565 (prepare_desired_row, line_draw_cost):
5566 Use int, not unsigned, where either works.
5567 (save_current_matrix, restore_current_matrix):
5568 Use ptrdiff_t, not size_t, where either works.
5569 (init_display): Check for overflow more accurately, and without
5570 relying on undefined behavior.
5572 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5573 Remove, replacing with the new symbols in lisp.h. All uses changed.
5574 * fileio.c (make_temp_name):
5575 * filelock.c (lock_file_1, lock_file):
5576 * xdisp.c (message_dolog):
5577 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5578 Use pMd etc. instead.
5579 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5580 replacing the pWIDE etc. symbols removed from editfns.c.
5582 * keyboard.h (num_input_events): Now uintmax_t.
5583 This is (very slightly) less likely to mess up due to wraparound.
5586 * buffer.c: Integer signedness fixes.
5587 (alloc_buffer_text, enlarge_buffer_text):
5588 Use ptrdiff_t rather than size_t when either will do, as we prefer
5591 * alloc.c: Integer signedness and overflow fixes.
5592 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5593 (__malloc_size_t): Default to size_t, not to int.
5594 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5595 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5596 Prefer ptrdiff_t to size_t when either would do, as we prefer
5598 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5599 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5600 Now const. Initialize with values that are in range even if char
5602 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5603 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5604 These functions do the right thing with sizes > 2**32.
5605 (check_depth): Now ptrdiff_t, not int.
5606 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5607 Adjust to new way of storing sizes. Check for size overflow bugs
5609 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5610 slightly wrong anyway, as it missed one instance of
5611 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5612 (refill_memory_reserve): Omit needless cast to size_t.
5613 (mark_object_loop_halt): Mark as externally visible.
5615 * xselect.c: Integer signedness and overflow fixes.
5616 (Fx_register_dnd_atom, x_handle_dnd_message):
5617 Use ptrdiff_t, not size_t, since we prefer signed.
5618 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5619 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5620 x_dnd_atoms_size and x_dnd_atoms_length.
5622 * doprnt.c: Prefer signed to unsigned when either works.
5624 * doprnt.c (doprnt):
5626 * xdisp.c (vmessage):
5627 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5628 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5629 prefer signed arithmetic to avoid comparison confusion.
5630 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5631 but is a bit tricky.
5633 Assume freestanding C89 headers, string.h, stdlib.h.
5634 * data.c, doprnt.c, floatfns.c, print.c:
5635 Include float.h unconditionally.
5636 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5637 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5638 * regex.c: Likewise for stddef.h, string.h.
5639 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5640 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5641 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5642 (STDC_HEADERS): Remove obsolete defines.
5643 * sysdep.c: Include limits.h unconditionally.
5645 Assume support for memcmp, memcpy, memmove, memset.
5646 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5647 * regex.c (memcmp, memcpy):
5648 Remove; we assume C89 now.
5650 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5651 (__malloc_safe_bcopy): Remove; no longer needed.
5653 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
5654 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5655 well either way, and we prefer signed to unsigned.
5657 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5659 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5660 closes the connection while we're reading (bug#9182).
5662 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
5664 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5665 are specified (Bug#9168).
5667 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5669 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5670 Found by GCC static checking and --with-wide-int on a 32-bit host.
5672 2011-07-25 Eli Zaretskii <eliz@gnu.org>
5674 * xdisp.c (compute_display_string_pos): Fix logic of caching
5675 previous display string position. Initialize cached_prev_pos to
5676 -1. Fixes slow-down at the beginning of a buffer.
5678 2011-07-24 Eli Zaretskii <eliz@gnu.org>
5680 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5681 for attrs[LFACE_FONTSET_INDEX].
5683 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5685 * xml.c (parse_region): Remove unused local
5686 that was recently introduced.
5688 2011-07-23 Eli Zaretskii <eliz@gnu.org>
5690 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5691 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5693 * xdisp.c (move_it_in_display_line_to): Record the best matching
5694 position for TO_CHARPOS while scanning the line, and restore it on
5695 exit if none of the characters scanned was an exact match.
5696 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
5697 when exact match is impossible due to invisible text, and the
5698 lines are truncated.
5700 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5702 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5705 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5707 Fix a significant slow-down of cursor motion with C-n, C-p,
5708 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5709 auto-repeat under bidi redisplay in fontified buffers.
5710 * xdisp.c (compute_stop_pos_backwards): New function.
5711 (next_element_from_buffer): Call compute_stop_pos_backwards to
5712 find a suitable prev_stop when we find ourselves before
5714 (reseat): Don't look for prev_stop, as that could mean a very long
5716 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5717 <cached_disp_overlay_modiff>: Cache for last found display string
5719 (compute_display_string_pos): Return the cached position if asked
5720 about the same buffer in the same area of character positions, and
5721 the buffer wasn't changed since the time the display string
5722 position was cached.
5724 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5726 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5727 is an integer, which is important for empty lines. (Bug#9149)
5729 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
5731 * frame.c (Fmodify_frame_parameters): In tty case, update the
5732 default face if necessary (Bug#4238).
5734 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
5736 * editfns.c (Fstring_to_char): No need to explain what a character
5737 is in the docstring (Bug#6576).
5739 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5741 * xml.c (parse_region): Make sure we always return a tree.
5743 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5745 * xml.c (parse_region): If a document contains only comments,
5748 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5750 * xml.c (make_dom): Return comments, too.
5752 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5755 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5756 and the surrounding thread.
5757 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5758 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5759 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5761 * s/openbsd.h (BROKEN_SIGIO): Define.
5762 * unexelf.c (unexec) [__OpenBSD__]:
5763 Don't update the .mdebug section of the Alpha COFF symbol table.
5765 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5767 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5770 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5772 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5773 This fixes some race conditions on the permissions of any newly
5776 * alloc.c (valid_pointer_p): Use pipe, not open.
5777 This fixes some permissions issues when debugging.
5779 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5780 If fchown fails to set both uid and gid, try to set just gid,
5781 as that is sometimes allowed. Adjust the file's mode to eliminate
5782 setuid or setgid bits that are inappropriate if fchown fails.
5784 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5786 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5787 to compare Lisp_Objects.
5788 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5789 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5790 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5792 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5794 * lread.c (read_integer): Unread even EOF character.
5795 (read1): Likewise. Properly record start position of symbol.
5797 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5798 symbol character follows.
5800 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5802 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5803 This works around a problem with the previous change to Fcopy_file.
5804 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5805 and without this change, GCC might complain about discarding
5806 fchown's return value.
5808 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
5810 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5812 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5814 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5816 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5818 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5819 it's used from the C level.
5821 * process.c: Use the same condition for POLL_FOR_INPUT in both
5822 keyboard.c and process.c (bug#1858).
5824 2011-07-09 Lawrence Mitchell <wence@gmx.li>
5826 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5827 (Fgnutls_boot): Use it.
5829 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5831 * doc.c (Fsubstitute_command_keys): Revert last change.
5833 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5835 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5836 quotes the next character, and doesn't affect other longer
5837 sequences (bug#8935).
5839 * lread.c (syms_of_lread): Clarify that is isn't only
5840 `eval-buffer' and `eval-defun' that's affected by
5841 `lexical-binding' (bug#8460).
5843 2011-07-15 Eli Zaretskii <eliz@gnu.org>
5845 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
5846 bidi redisplay when a line includes both an image and is truncated.
5848 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5850 Fix minor problems found by static checking.
5851 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5852 (elsz): Now a signed constant, not a size_t var. We prefer signed
5853 types to unsigned, to avoid integer comparison confusion. Without
5854 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5855 "cannot optimize loop, the loop counter may overflow", a symptom
5857 * indent.c (Fvertical_motion): Mark locals as initialized.
5858 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5860 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5862 * search.c (Fre_search_backward): Mention `case-fold-search' in
5863 all the re_search_* functions (bug#8138).
5865 * keyboard.c (Fopen_dribble_file): Document when the file is
5868 2011-07-14 Eli Zaretskii <eliz@gnu.org>
5870 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5873 Support bidi reordering of display and overlay strings.
5874 * xdisp.c (compute_display_string_pos)
5875 (compute_display_string_end): Accept additional argument STRING.
5876 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5877 (reseat_to_string): Initialize bidi_it->string.s and
5878 bidi_it->string.schars.
5879 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
5880 NULL (avoids a crash in bidi_paragraph_init).
5881 Initialize itb.string.lstring.
5882 (init_iterator): Call bidi_init_it only of a valid
5883 buffer position was specified. Initialize paragraph_embedding to
5885 (reseat_to_string): Initialize the bidi iterator.
5886 (display_string): If we need to ignore text properties of
5887 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5888 original value of -1 will not work with bidi.)
5889 (compute_display_string_pos): First arg is now struct
5890 `text_pos *'; all callers changed. Support display properties on
5892 (compute_display_string_end): Support display properties on Lisp
5894 (init_iterator, reseat_1, reseat_to_string): Initialize the
5895 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5896 when iterating on a string not from display properties).
5897 (compute_display_string_pos, compute_display_string_end):
5898 Fix calculation of the object to scan. Fixes an error when using
5900 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
5901 base_level_stop; instead, set base_level_stop to BEGV.
5902 Fixes crashes in vertical-motion.
5903 (next_element_from_buffer): Improve commentary for when
5904 the iterator is before prev_stop.
5905 (init_iterator): Initialize bidi_p from the default value of
5906 bidi-display-reordering, not from buffer-local value. Use the
5907 buffer-local value only if initializing for buffer iteration.
5908 (handle_invisible_prop): Support invisible properties on strings
5909 that are being bidi-reordered.
5910 (set_iterator_to_next): Support bidi reordering of C strings and
5912 (next_element_from_string): Support bidi reordering of Lisp
5914 (handle_stop_backwards): Support Lisp strings as well.
5915 (display_string): Support display of R2L glyph rows.
5916 Use IT_STRING_CHARPOS when displaying from a Lisp string.
5917 (init_iterator): Don't initialize it->bidi_p for strings
5919 (reseat_to_string): Initialize it->bidi_p for strings here.
5920 (next_element_from_string, next_element_from_c_string)
5921 (next_element_from_buffer): Add xassert's for correspondence
5922 between IT's object being iterated and it->bidi_it.string
5924 (face_before_or_after_it_pos): Support bidi iteration.
5925 (next_element_from_c_string): Handle the case of the first string
5926 character that is not the first one in the visual order.
5927 (get_visually_first_element): New function, refactored from common
5928 parts of next_element_from_buffer, next_element_from_string, and
5929 next_element_from_c_string.
5930 (tool_bar_lines_needed, redisplay_tool_bar)
5931 (display_menu_bar): Force left-to-right direction. Add a FIXME
5932 comment for making that be controlled by a user option.
5933 (push_it, pop_it): Save and restore the state of the
5934 bidi iterator. Save and restore the bidi_p flag.
5935 (pop_it): Iterate out of display property for string iteration as
5937 (iterate_out_of_display_property): Support iteration over strings.
5938 (handle_single_display_spec): Set up it->bidi_it for iteration
5939 over a display string, and call bidi_init_it.
5940 (handle_single_display_spec, next_overlay_string)
5941 (get_overlay_strings_1, push_display_prop): Set up the bidi
5942 iterator for displaying display or overlay strings.
5943 (forward_to_next_line_start): Don't use the shortcut if
5945 (back_to_previous_visible_line_start): If handle_display_prop
5946 pushed the iterator stack, restore the internal state of the bidi
5947 iterator by calling bidi_pop_it same number of times.
5948 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5949 and we are bidi-iterating, don't decrement the iterator position;
5950 instead, set the first_elt flag in the bidi iterator, to produce
5952 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5953 (push_display_prop): xassert that we are iterating a buffer.
5954 (push_it, pop_it): Save and restore paragraph_embedding member.
5955 (handle_single_display_spec, next_overlay_string)
5956 (get_overlay_strings_1, reseat_1, reseat_to_string)
5957 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5958 correctly. Don't assume unibyte strings are not bidi-reordered.
5959 (compute_display_string_pos)
5960 (compute_display_string_end): Fix handling the case of C string.
5961 (push_it, pop_it): Save and restore from_disp_prop_p.
5962 (handle_single_display_spec, push_display_prop): Set the
5963 from_disp_prop_p flag.
5964 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5965 (pop_it): Call iterate_out_of_display_property only if we are
5966 popping after iteration over a string that came from a display
5967 property. Fix a typo in popping stretch info. Add an assertion
5968 for verifying that the iterator position is in sync with the bidi
5970 (handle_single_display_spec, get_overlay_strings_1)
5971 (push_display_prop): Fix initialization of paragraph direction for
5972 string when that of the parent object is not yet determined.
5973 (reseat_1): Call bidi_init_it to resync the bidi
5974 iterator with IT's position. (Bug#7616)
5975 (find_row_edges): If ROW->start.pos gives position
5976 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
5977 (handle_stop, back_to_previous_visible_line_start, reseat_1):
5978 Reset the from_disp_prop_p flag.
5979 (SAVE_IT, RESTORE_IT): New macros.
5980 (pos_visible_p, face_before_or_after_it_pos)
5981 (back_to_previous_visible_line_start)
5982 (move_it_in_display_line_to, move_it_in_display_line)
5983 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5984 (try_scrolling, redisplay_window, display_line): Use them when
5985 saving a temporary copy of the iterator and restoring it back.
5986 (back_to_previous_visible_line_start, reseat_1)
5987 (init_iterator): Empty the bidi cache "stack".
5988 (move_it_in_display_line_to): If iterator ended up at
5989 EOL, but we never saw any buffer positions smaller than
5990 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5991 motion in bidi-reordered lines.
5992 (move_it_in_display_line_to): Record prev_method and prev_pos
5993 immediately before the call to set_iterator_to_next. Fixes cursor
5994 motion in bidi-reordered lines with stretch glyphs and strings
5995 displayed in margins. (Bug#8133) (Bug#8867)
5996 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5998 (pos_visible_p): Support positions in bidi-reordered lines.
5999 Save and restore bidi cache.
6001 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6002 (bidi_paragraph_info): Delete unused struct.
6003 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6004 (bidi_cache_start): New variable.
6005 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6007 (bidi_cache_fetch_state, bidi_cache_search)
6008 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6009 (bidi_cache_find, bidi_peek_at_next_level)
6010 (bidi_level_of_next_char, bidi_find_other_level_edge)
6011 (bidi_move_to_visually_next): Compare cache index with
6012 bidi_cache_start rather than with zero.
6013 (bidi_fetch_char): Accept new argument STRING; all callers
6014 changed. Support iteration over a string. Support strings with
6015 display properties. Support unibyte strings. Fix the type of
6016 `len' according to what STRING_CHAR_AND_LENGTH expects.
6017 (bidi_paragraph_init, bidi_resolve_explicit_1)
6018 (bidi_resolve_explicit, bidi_resolve_weak)
6019 (bidi_level_of_next_char, bidi_move_to_visually_next):
6020 Support iteration over a string.
6021 (bidi_set_sor_type, bidi_resolve_explicit_1)
6022 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6023 can now be zero (for strings); special values 0 and -1 were
6024 changed to -1 and -2, respectively.
6025 (bidi_char_at_pos): New function.
6026 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6027 Call it instead of FETCH_MULTIBYTE_CHAR.
6028 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6029 initialized to valid values.
6030 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6032 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6033 the test for valid cached positions. Fix the logic for looking up
6034 the sentinel state in the cache. GCPRO the Lisp string we are
6036 (bidi_push_it, bidi_pop_it): New functions.
6037 (bidi_initialize): Initialize the bidi cache start stack pointer.
6038 (bidi_cache_ensure_space): New function, refactored from part of
6039 bidi_cache_iterator_state. Don't assume the required size is just
6040 one BIDI_CACHE_CHUNK away.
6041 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6042 (bidi_count_bytes, bidi_char_at_pos): New functions.
6043 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6044 always valid if bidi_cache_idx is valid.
6045 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6046 is valid if it's going to be used.
6047 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6048 (bidi_cache_fetch_state, bidi_cache_search)
6049 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6050 (bidi_cache_iterator_state, bidi_cache_find)
6051 (bidi_find_other_level_edge, bidi_cache_start_stack):
6052 All variables related to cache indices are now EMACS_INT.
6054 * dispextern.h (struct bidi_string_data): New structure.
6055 (struct bidi_it): New member `string'. Make flag members be 1-bit
6056 fields, and put them last in the struct.
6057 (compute_display_string_pos, compute_display_string_end):
6059 (bidi_push_it, bidi_pop_it): Add prototypes.
6060 (struct iterator_stack_entry): New members bidi_p,
6061 paragraph_embedding, and from_disp_prop_p.
6062 (struct it): Member bidi_p is now a bit field 1 bit wide.
6063 (bidi_shelve_cache, bidi_unshelve_cache):
6066 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6067 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6068 and vector-like objects.
6070 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6071 cache around display iteration.
6073 * window.c (Fwindow_end, window_scroll_pixel_based)
6074 (displayed_window_lines, Frecenter): Save and restore the bidi
6075 cache around display iteration.
6077 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6079 * editfns.c (Fdelete_region): Clarify the use of the named
6080 parameters (bug#6788).
6082 2011-07-14 Martin Rudalics <rudalics@gmx.at>
6084 * indent.c (Fvertical_motion): Set and restore w->pointm when
6085 saving and restoring the window's buffer (Bug#9006).
6087 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6089 * editfns.c (Fstring_to_char): Clarify just what is returned
6090 (bug#6576). Text by Eli Zaretskii.
6092 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
6094 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6096 2011-07-13 Eli Zaretskii <eliz@gnu.org>
6098 * buffer.c (mmap_find): Fix a typo.
6100 2011-07-13 Johan Bockgård <bojohan@gnu.org>
6102 Fix execution of x selection hooks.
6103 * xselect.c (Qx_lost_selection_functions)
6104 (Qx_sent_selection_functions): New vars.
6105 (syms_of_xselect): DEFSYM them.
6106 (x_handle_selection_request): Pass Qx_sent_selection_functions
6107 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6108 (x_handle_selection_clear,x_clear_frame_selections):
6109 Pass Qx_lost_selection_functions rather than
6110 Vx_lost_selection_functions to Frun_hook_with_args.
6112 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6114 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
6115 The old code sometimes used this field without initializing it.
6117 * alloc.c (gc_sweep): Don't read past end of array.
6118 In theory, the old code could also have corrupted Emacs internals,
6119 though it'd be very unlikely.
6121 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6123 * character.c (Fcharacterp): Don't advertise optional ignored
6124 argument. (Bug#4026)
6126 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6128 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6131 * window.c (Fset_window_start): Doc fix (bug#4199).
6132 (Fset_window_hscroll): Ditto.
6134 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6136 Fix minor new problems caught by GCC 4.6.1.
6137 * term.c (init_tty): Remove unused local.
6138 * xsettings.c (store_monospaced_changed): Define this function only
6139 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
6142 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
6144 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6146 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6148 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6149 are the mini-buffer and the echo area (bug#3320).
6151 * term.c (init_tty): Remove support for supdup, c10 and perq
6152 terminals, which are no longer supported (bug#1482).
6154 2011-07-10 Johan Bockgård <bojohan@gnu.org>
6156 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6158 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6160 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6161 for non-popups (Bug#3642).
6163 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6165 * alloc.c (reset_malloc_hooks): Protoize.
6166 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
6167 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6168 * cm.c (losecursor): Likewise.
6169 * data.c (fmod): Likewise.
6170 * dispnew.c (swap_glyphs_in_rows): Likewise.
6171 * emacs.c (memory_warning_signal): Likewise.
6172 * floatfns.c (float_error): Likewise.
6173 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6174 (otf_open, font_otf_capability, generate_otf_features)
6175 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6177 * image.c (pbm_read_file): Likewise.
6178 * indent.c (string_display_width): Likewise.
6179 * intervals.c (check_for_interval, search_for_interval)
6180 (inc_interval_count, count_intervals, root_interval)
6181 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6182 * lread.c (defalias): Likewise.
6183 * ralloc.c (r_alloc_check): Likewise.
6184 * regex.c (set_image_of_range_1, set_image_of_range)
6185 (regex_grow_registers): Likewise.
6186 * sysdep.c (strerror): Likewise.
6187 * termcap.c (valid_filename_p, tprint, main): Likewise.
6188 * tparam.c (main): Likewise.
6189 * unexhp9k800.c (run_time_remap, save_data_space)
6190 (update_file_ptrs, read_header, write_header, calculate_checksum)
6191 (copy_file, copy_rest, display_header): Likewise.
6192 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6194 * xdisp.c (check_it): Likewise.
6195 * xfaces.c (register_color, unregister_color, unregister_colors):
6197 * xfns.c (print_fontset_result): Likewise.
6198 * xrdb.c (member, fatal, main): Likewise.
6200 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6202 Fix minor problems found by static checking (Bug#9031).
6203 * chartab.c (char_table_set_range, map_sub_char_table):
6204 Remove unused locals.
6205 (uniprop_table): Now static.
6206 * composite.c (_work_char): Remove unused static var.
6208 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
6210 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6212 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6214 * gtkutil.c (qttip_cb): Remove code without function.
6216 2011-07-09 Eli Zaretskii <eliz@gnu.org>
6218 * w32.c (pthread_sigmask): New stub.
6220 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
6222 Use pthread_sigmask, not sigprocmask (Bug#9010).
6223 sigprocmask is portable only for single-threaded applications, and
6224 Emacs can be multi-threaded when it uses GTK.
6225 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6227 * callproc.c (Fcall_process):
6228 * process.c (create_process):
6229 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6230 Use pthread_sigmask, not sigprocmask.
6232 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6234 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6235 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6238 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6240 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6241 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6242 (xg_hide_tooltip): Fix comment.
6244 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6245 in registerServicesMenuSendTypes.
6246 (validRequestorForSendType): Don't check ns_return_types.
6248 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6251 2011-07-08 Jason Rumney <jasonr@gnu.org>
6253 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6254 SH_SHOW for hidden windows (Bug#5482).
6256 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6257 frame struct members of non-existent frames (Bug#6284).
6259 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6261 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6262 variable firstTime not needed on OSX >= 10.6.
6263 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6264 >= 10.5. Use setKnobProportion, setDoubleValue.
6266 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6267 (MAC_OS_X_VERSION_10_5): Define if not defined.
6268 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6269 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6270 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6272 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6273 cString and lossyCString on OSX >= 10.4
6275 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
6276 sizeToFit on OSX >= 10.2.
6278 * nsimage.m (allocInitFromFile): Don't use deprecated method
6279 bestRepresentationForDevice on OSX >= 10.6.
6281 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6284 * emacs.c: Declare unexec_init_emacs_zone.
6286 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6288 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6290 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6291 on svcsMenu (Bug#8842).
6293 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6295 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6297 * nsterm.m (QUTF8_STRING): Declare.
6298 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6299 (validRequestorForSendType): Return type is (id).
6300 Change indexOfObjectIdenticalTo to indexOfObject.
6301 Check if we have local selection before returning self (Bug#8842).
6302 (writeSelectionToPasteboard): Put local selection into paste board
6303 if we have a local selection (Bug#8842).
6304 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6306 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6307 (ns_get_local_selection): Declare.
6309 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6311 * keymap.c (describe_map_tree): Don't insert a double newline at
6312 the end of the buffer (bug#1169) and return whether we inserted
6315 * callint.c (Fcall_interactively): Change "reading args" to
6316 "providing args" to try to clarify what it does (bug#1010).
6318 2011-07-07 Kenichi Handa <handa@m17n.org>
6320 * composite.c (composition_compute_stop_pos): Ignore a static
6321 composition starting before CHARPOS (Bug#8915).
6323 * xdisp.c (handle_composition_prop): Likewise.
6325 2011-07-07 Eli Zaretskii <eliz@gnu.org>
6327 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6330 2011-07-07 Kenichi Handa <handa@m17n.org>
6332 * character.h (unicode_category_t): New enum type.
6334 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6335 (Qchar_code_property_table): New variable.
6336 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6337 (UNIPROP_COMPRESSED_FORM_P): New macros.
6338 (char_table_ascii): Uncompress the compressed values.
6339 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6340 Uncompress the compressed values.
6341 (sub_char_table_ref_and_range): Likewise.
6342 (char_table_ref_and_range): Uncompress the compressed values.
6343 (sub_char_table_set): New arg is_uniprop. Callers changed.
6344 Uncompress the compressed values.
6345 (sub_char_table_set_range): Args changed. Callers changed.
6346 (char_table_set_range): Adjuted for the above change.
6347 (map_sub_char_table): Delete args default_val and parent. Add arg
6348 top. Give decoded values to a Lisp function.
6349 (map_char_table): Adjust for the above change. Give decoded
6350 values to a Lisp function. Gcpro more variables.
6351 (uniprop_table_uncompress)
6352 (uniprop_decode_value_run_length): New functions.
6353 (uniprop_decoder, uniprop_decoder_count): New variables.
6354 (uniprop_get_decoder, uniprop_encode_value_character)
6355 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6357 (uniprop_encoder, uniprop_encoder_count): New variables.
6358 (uniprop_get_encoder, uniprop_table)
6359 (Funicode_property_table_internal, Fget_unicode_property_internal)
6360 (Fput_unicode_property_internal): New functions.
6361 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6362 Sunicode_property_table_internal, Sget_unicode_property_internal,
6363 and Sput_unicode_property_internal. Defvar_lisp
6364 char-code-property-alist.
6366 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
6367 Vunicode_category_table.
6369 * font.c (font_range): Adjust for the change of
6370 Vunicode_category_table.
6372 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6374 * m/iris4d.h: Remove file, move contents ...
6375 * s/irix6-5.h: ... here.
6377 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6379 Remove unportable assumption about struct layout (Bug#8884).
6380 * alloc.c (mark_buffer):
6381 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6382 (clone_per_buffer_values): Don't assume that
6383 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6384 This isn't true in general, and it's particularly not true
6385 if Emacs is configured with --with-wide-int.
6386 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6387 New macros, used in the buffer.c change.
6389 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6391 * xsettings.c: Use both GConf and GSettings if both are available.
6392 (store_config_changed_event): Add comment.
6393 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6394 (store_tool_bar_style_changed): New functions.
6395 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
6396 (struct xsettings): Move font inside HAVE_XFT.
6397 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
6398 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
6399 Move inside HAVE_XFT.
6400 (something_changed_gsettingsCB): Rename from something_changedCB.
6401 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6403 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
6404 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
6405 (something_changed_gconfCB): Rename from something_changedCB.
6406 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6407 (parse_settings): Move check for font inside HAVE_XFT.
6408 (read_settings, apply_xft_settings): Add comment.
6409 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6410 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6411 call store_font_name_changed.
6412 (xft_settings_event): Add comment.
6413 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6414 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6415 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6416 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6417 (xsettings_initialize): Call init_gsettings last.
6418 (xsettings_get_system_font, xsettings_get_system_normal_font):
6421 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6423 Random fixes. E.g., (random) never returned negative values.
6424 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6425 subseconds part to the entropy, as that's a bit more random.
6426 Prefer signed to unsigned, since the signedness doesn't matter and
6427 in general we prefer signed. When given a limit, use a
6428 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6429 latter isn't right if USE_2_TAGS_FOR_INTS.
6430 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6431 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6433 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6435 * textprop.c (text_property_stickiness):
6436 Obey Vtext_property_default_nonsticky.
6437 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6438 * w32fns.c (syms_of_w32fns):
6439 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6441 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6443 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6444 This is more efficient than Ffile_directory_p and avoids a minor race.
6446 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6448 * buffer.c (Foverlay_put): Say what the return value is
6451 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6452 is a directory before asking whether to use the file name
6454 (barf_or_query_if_file_exists): Make the "File is a directory"
6455 error be more correct.
6457 * fns.c (Frequire): Remove the mention of the .gz files, since
6458 that's installation-specific, but keep the mention of
6459 `get-load-suffixes'.
6461 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6463 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6464 Report string overflow if the output is too long.
6466 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
6468 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6469 (syms_of_gnutls): Remove duplicate DEFSYM for
6470 Qgnutls_bootprop_verify_hostname_error, an error for
6471 Qgnutls_bootprop_verify_error (which is no longer used).
6473 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6474 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6475 Also (re)move comments that are misplaced or no longer relevant.
6477 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6479 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6481 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
6483 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6484 and background color parameters if they have been changed.
6486 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6488 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6490 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6492 * xsettings.c (SYSTEM_FONT): Define only when used.
6493 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6495 * keymap.c (access_keymap_1): Now static.
6497 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
6499 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6500 leave any prefix arg for the up event (Bug#1586).
6502 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6504 * lread.c (syms_of_lread): Mention single symbols defined by
6505 `defvar' or `defconst' (bug#7154).
6507 * fns.c (Frequire): Mention .el.gz files (bug#7314).
6508 (Frequire): Mention get-load-suffixes.
6510 2011-07-02 Martin Rudalics <rudalics@gmx.at>
6512 * window.h (window): Remove clone_number slot.
6513 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6515 (make_parent_window, make_window, saved_window)
6516 (Fset_window_configuration, save_window_save): Don't deal with
6518 * buffer.c (Qclone_number): Remove declaration.
6519 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6521 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6523 Add multiple inheritance to keymaps.
6524 * keymap.c (Fmake_composed_keymap): New function.
6525 (Fset_keymap_parent): Simplify.
6526 (fix_submap_inheritance): Remove.
6527 (access_keymap_1): New function extracted from access_keymap to handle
6528 embedded parents and handle lists of maps.
6529 (access_keymap): Use it.
6530 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6531 (Fcopy_keymap): Handle embedded parents.
6532 (Fcommand_remapping, define_as_prefix): Simplify.
6533 (Fkey_binding): Simplify.
6534 (syms_of_keymap): Move minibuffer-local-completion-map,
6535 minibuffer-local-filename-completion-map,
6536 minibuffer-local-must-match-map, and
6537 minibuffer-local-filename-must-match-map to Elisp.
6538 (syms_of_keymap): Defsubr make-composed-keymap.
6539 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6540 (parse_menu_item): Trivial simplification.
6542 2011-07-01 Glenn Morris <rgm@gnu.org>
6544 * Makefile.in (SETTINGS_LIBS): Fix typo.
6546 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6548 * coding.c (Fencode_coding_string): Record the last coding system
6549 used, as the function doc string says (bug#8738).
6551 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6553 * xsettings.c (store_monospaced_changed): Take new font as arg and
6554 check for change against current_mono_font.
6555 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6556 (emacs_settings_constructor, emacs_settings_get_property)
6557 (emacs_settings_set_property, emacs_settings_class_init)
6558 (emacs_settings_init, gsettings_obj): Remove.
6559 (something_changedCB): New function for HAVE_GSETTINGS.
6560 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6561 with value as argument.
6562 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6563 g_settings_new (Bug#8967). Do not create gsettings_obj.
6564 Remove calls to g_settings_bind. Connect something_changedCB to
6567 * xgselect.c: Add defined (HAVE_GSETTINGS).
6568 (xgselect_initialize): Ditto.
6570 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6571 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6574 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6576 * eval.c (struct backtrace): Simplify and port the data structure.
6577 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6578 signed bit field, as this assumption is not portable and it makes
6579 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6580 "char debug_on_exit : 1" as this is not portable either; instead,
6581 use the portable "unsigned int debug_on_exit : 1". Remove unused
6582 member evalargs. Remove obsolete comments about cc bombing out.
6584 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6586 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
6587 Let HAVE_GSETTINGS override HAVE_GCONF.
6588 (store_monospaced_changed): New function.
6589 (EMACS_SETTINGS): A new type derived from GObject to handle
6590 GSettings notifications.
6591 (emacs_settings_constructor, emacs_settings_get_property)
6592 (emacs_settings_set_property, emacs_settings_class_init):
6594 (gsettings_client, gsettings_obj): New variables.
6595 (GSETTINGS_SCHEMA): New define.
6596 (something_changedCB): Call store_monospaced_changed.
6597 (init_gsettings): New function.
6598 (xsettings_initialize): Call init_gsettings.
6599 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6602 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
6605 2011-06-29 Martin Rudalics <rudalics@gmx.at>
6607 * window.c (resize_root_window, grow_mini_window)
6608 (shrink_mini_window): Rename Qresize_root_window to
6609 Qwindow_resize_root_window and Qresize_root_window_vertically to
6610 Qwindow_resize_root_window_vertically.
6612 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6614 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6616 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
6618 * makefile.w32-in: Redesign dependencies so they reflect more
6619 clearly which files are directly included by each source file,
6620 and not through other includes.
6622 2011-06-27 Martin Rudalics <rudalics@gmx.at>
6624 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6625 (sort_overlays, overlay_strings): When an overlay's clone number
6626 matches the window's clone number process the overlay even if
6627 the overlay's window property doesn't match the current window.
6629 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6630 (Fwindow_hchild): Rename to Fwindow_left_child.
6631 (Fwindow_next): Rename to Fwindow_next_sibling.
6632 (Fwindow_prev): Rename to Fwindow_prev_sibling.
6633 (resize_window_check): Rename to window_resize_check.
6634 (resize_window_apply): Rename to window_resize_apply.
6635 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6636 (Fdelete_other_windows_internal, resize_frame_windows)
6637 (Fsplit_window_internal, Fdelete_window_internal)
6638 (grow_mini_window, shrink_mini_window)
6639 (Fresize_mini_window_internal): Fix callers accordingly.
6641 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6643 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6644 (emacs_fixed_set_min_size): Remove.
6645 (emacs_fixed_new): Take frame as argument.
6647 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6648 (_EmacsFixedPrivate): Remove minwidth/height.
6649 Add struct frame *f.
6650 (emacs_fixed_init): Initialize priv->f.
6651 (get_parent_class, emacs_fixed_set_min_size): Remove.
6652 (emacs_fixed_new): Set priv->f to argument.
6653 (emacs_fixed_get_preferred_width)
6654 (emacs_fixed_get_preferred_height): Use min_width/height from
6655 frames size_hint to set minimum and natural (Bug#8919).
6656 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6657 and use min_width/height from frames size_hint to set
6658 min_width/height (Bug#8919).
6660 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
6661 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6664 2011-06-26 Eli Zaretskii <eliz@gnu.org>
6666 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6667 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6670 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
6672 * process.c (wait_reading_process_output): Bypass select if
6673 waiting for a cell while ignoring keyboard input, and input is
6674 pending. Suggested by Jan Djärv (Bug#8869).
6676 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6678 Use gnulib's dup2 module instead of rolling our own.
6679 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6681 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6683 * dispnew.c (scrolling_window): Before scrolling, turn off a
6684 mouse-highlight in the window being scrolled.
6686 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
6688 Move DEFSYM to lisp.h and use everywhere.
6690 * character.h (DEFSYM): Move declaration...
6691 * lisp.h (DEFSYM): ...here.
6697 * w32select.c: Don't include character.h.
6699 * alloc.c (syms_of_alloc):
6700 * buffer.c (syms_of_buffer):
6701 * bytecode.c (syms_of_bytecode):
6702 * callint.c (syms_of_callint):
6703 * casefiddle.c (syms_of_casefiddle):
6704 * casetab.c (init_casetab_once):
6705 * category.c (init_category_once, syms_of_category):
6706 * ccl.c (syms_of_ccl):
6707 * cmds.c (syms_of_cmds):
6708 * composite.c (syms_of_composite):
6709 * dbusbind.c (syms_of_dbusbind):
6710 * dired.c (syms_of_dired):
6711 * dispnew.c (syms_of_display):
6712 * doc.c (syms_of_doc):
6713 * editfns.c (syms_of_editfns):
6714 * emacs.c (syms_of_emacs):
6715 * eval.c (syms_of_eval):
6716 * fileio.c (syms_of_fileio):
6717 * fns.c (syms_of_fns):
6718 * frame.c (syms_of_frame):
6719 * fringe.c (syms_of_fringe):
6720 * insdel.c (syms_of_insdel):
6721 * keymap.c (syms_of_keymap):
6722 * lread.c (init_obarray, syms_of_lread):
6723 * macros.c (syms_of_macros):
6724 * msdos.c (syms_of_msdos):
6725 * print.c (syms_of_print):
6726 * process.c (syms_of_process):
6727 * search.c (syms_of_search):
6728 * sound.c (syms_of_sound):
6729 * syntax.c (init_syntax_once, syms_of_syntax):
6730 * terminal.c (syms_of_terminal):
6731 * textprop.c (syms_of_textprop):
6732 * undo.c (syms_of_undo):
6733 * w32.c (globals_of_w32):
6734 * window.c (syms_of_window):
6735 * xdisp.c (syms_of_xdisp):
6736 * xfaces.c (syms_of_xfaces):
6737 * xfns.c (syms_of_xfns):
6738 * xmenu.c (syms_of_xmenu):
6739 * xsettings.c (syms_of_xsettings):
6740 * xterm.c (syms_of_xterm): Use DEFSYM.
6742 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6744 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
6746 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6748 Integer and buffer overflow fixes (Bug#8873).
6750 * print.c (printchar, strout): Check for string overflow.
6751 (PRINTPREPARE, printchar, strout):
6752 Don't set size unless allocation succeeds.
6754 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6755 for sizes. Check for string overflow more accurately.
6756 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6758 * macros.c: Integer and buffer overflow fixes.
6759 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6760 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6761 Use ptrdiff_t, not int, for sizes.
6762 Don't increment bufsize until after realloc succeeds.
6763 Check for size-calculation overflow.
6764 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6766 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6768 * lread.c: Integer overflow fixes.
6769 (read_integer): Radix is now EMACS_INT, not int,
6770 to improve quality of diagnostics for out-of-range radices.
6771 Calculate buffer size correctly for out-of-range radices.
6772 (read1): Check for integer overflow in radices, and in
6773 read-circle numbers.
6774 (read_escape): Avoid int overflow.
6775 (Fload, openp, read_buffer_size, read1)
6776 (substitute_object_recurse, read_vector, read_list, map_obarray):
6777 Use ptrdiff_t, not int, for sizes.
6778 (read1): Use EMACS_INT, not int, for sizes.
6779 Check for size overflow.
6781 * image.c (cache_image): Check for size arithmetic overflow.
6783 * lread.c: Integer overflow issues.
6784 (saved_doc_string_size, saved_doc_string_length)
6785 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6786 Now ptrdiff_t, not int.
6787 (read1): Don't assume doc string length fits in int. Check for
6788 out-of-range doc string lengths.
6789 (read_list): Don't assume file position fits in int.
6790 (read_escape): Check for hex character overflow.
6792 2011-06-22 Leo Liu <sdl.web@gmail.com>
6794 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6795 Move to minibuffer.el.
6797 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6799 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
6800 The following patches are for when GLYPH_DEBUG && !XASSERT.
6801 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6802 * dispnew.c (flush_stdout):
6803 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6804 Mark as externally visible.
6805 * dispnew.c (check_window_matrix_pointers): Now static.
6806 * dispnew.c (window_to_frame_vpos):
6807 * xfns.c (unwind_create_frame):
6808 * xterm.c (x_check_font): Remove unused local.
6809 * scroll.c (CHECK_BOUNDS):
6810 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6811 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6812 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6813 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6814 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6816 (debug_method_add): Use va_list and vsprintf rather than relying
6817 on undefined behavior with wrong number of arguments.
6818 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6819 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6820 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6821 since we're not interested in debugging glyphs with old libraries.
6822 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6823 GCC 4.6.0's static checking.
6825 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6827 Integer overflow and signedness fixes (Bug#8873).
6828 A few related buffer overrun fixes, too.
6830 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6832 * dispextern.h (struct face.stipple):
6833 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6834 (x_bitmap_mask, x_allocate_bitmap_record)
6835 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6836 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6837 (x_create_bitmap_from_xpm_data):
6838 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6839 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6841 * xfaces.c (load_pixmap):
6842 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6843 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6844 (.bitmaps_last, struct x_output.icon_bitmap):
6845 Use ptrdiff_t, not int, for bitmap indexes.
6846 (x_allocate_bitmap_record): Check for size overflow.
6847 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6849 Use ptrdiff_t, not int, for overlay counts.
6850 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6851 * editfns.c (overlays_around, get_pos_property):
6852 * textprop.c (get_char_property_and_overlay):
6853 * xdisp.c (next_overlay_change, note_mouse_highlight):
6854 * xfaces.c (face_at_buffer_position):
6855 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6856 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6857 (Fnext_overlay_change, Fprevious_overlay_change)
6858 (mouse_face_overlay_overlaps, Foverlays_in):
6859 Use ptrdiff_t, not int, for sizes.
6860 (overlays_at, overlays_in): Check for size-calculation overflow.
6862 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6864 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6865 (x_session_initialize): Do not assume string length fits in int.
6867 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6868 This is unlikely, but can occur if DPI is outlandish.
6870 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
6871 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6873 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6874 * xrdb.c (magic_file_p, search_magic_path):
6875 Omit last arg SUFFIX; it was always 0. All callers changed.
6876 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6878 * xfont.c (xfont_match): Avoid need for strlen.
6880 * xfns.c: Don't assume strlen fits in int.
6881 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6883 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6884 not unsigned long, as we prefer signed integers. All callers changed.
6885 Detect integer overflow in repeat count.
6886 (message_dolog): Don't assume print length fits in 39 bytes.
6887 (display_mode_element): Don't assume strlen fits in int.
6889 * termcap.c: Don't assume sizes fit in int and never overflow.
6890 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6891 (gobble_line): Check for size-calculation overflow.
6893 * minibuf.c (Fread_buffer):
6894 * lread.c (intern, intern_c_string):
6895 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6896 Don't assume string length fits in int.
6898 * keyboard.c (parse_tool_bar_item):
6899 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6901 * font.c: Don't assume string length fits in int.
6902 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6903 Use ptrdiff_t, not int.
6904 (font_intern_prop): Don't assume string length fits in int.
6905 Don't assume integer property fits in fixnum.
6906 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
6908 * filelock.c: Fix some buffer overrun and integer overflow issues.
6909 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
6910 Reformulate so as not to need the command string.
6911 Invoke gzip -cd rather than gunzip, as it's more portable.
6912 (lock_info_type, lock_file_1, lock_file):
6913 Don't assume pid_t and time_t fit in unsigned long.
6914 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6915 (current_lock_owner): Prefer signed type for sizes.
6916 Use memcpy, not strncpy, where memcpy is what is really wanted.
6917 Don't assume (via atoi) that time_t and pid_t fit in int.
6918 Check for time_t and/or pid_t out of range, e.g., via a network share.
6919 Don't alloca where an auto var works fine.
6921 * fileio.c: Fix some integer overflow issues.
6922 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6923 Don't assume string length fits in int.
6924 (directory_file_name): Don't assume string length fits in long.
6925 (make_temp_name): Don't assume pid fits in int, or that its print
6926 length is less than 20.
6928 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6930 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6932 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6934 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6935 We prefer signed integers, even for size calculations.
6937 * emacs.c: Don't assume string length fits in 'int'.
6938 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6939 (main): Don't invoke strlen when not needed.
6941 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6942 (XD_DEBUG_MESSAGE): Don't waste a byte.
6944 * callproc.c (getenv_internal_1, getenv_internal)
6946 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6948 * lread.c (invalid_syntax): Omit length argument.
6949 All uses changed. This doesn't fix a bug, but it simplifies the
6950 code away from its former Hollerith-constant appearance, and it's
6951 one less 'int' to worry about when looking at integer-overflow issues.
6952 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
6954 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6955 This didn't break anything, but it didn't help either.
6956 It's confusing to put a bogus integer in a place where the actual
6957 value does not matter.
6958 (LIST_END_P): Remove unused macro and its bogus comment.
6959 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
6961 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6962 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6964 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6965 We prefer signed types, and the value cannot exceed the EMACS_INT
6966 range anyway (because otherwise the length would not be representable).
6967 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6968 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6969 This avoids a GCC warning when WIDE_EMACS_INT.
6971 * indent.c (sane_tab_width): New function.
6972 (current_column, scan_for_column, Findent_to, position_indentation)
6973 (compute_motion): Use it. This is just for clarity.
6974 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
6976 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
6978 * lisp.h (lint_assume): New macro.
6979 * composite.c (composition_gstring_put_cache):
6980 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
6982 * editfns.c, insdel.c:
6983 Omit unnecessary forward decls, to simplify future changes.
6985 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
6987 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
6989 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
6990 Use much-faster test for byte-length change.
6991 Don't assume string byte-length fits in 'int'.
6992 Check that character arg fits in 'int'.
6993 (mapcar1): Declare byte as byte, for clarity.
6995 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6997 * fns.c (concat): Catch string overflow earlier.
6998 Do not rely on integer wraparound.
7000 * dispextern.h (struct it.overlay_strings_charpos)
7001 (struct it.selective): Now EMACS_INT, not int.
7002 * xdisp.c (forward_to_next_line_start)
7003 (back_to_previous_visible_line_start)
7004 (reseat_at_next_visible_line_start, next_element_from_buffer):
7005 Don't arbitrarily truncate the value of 'selective' to int.
7007 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7009 * composite.c: Don't truncate sizes to 'int'.
7010 (composition_gstring_p, composition_reseat_it)
7011 (composition_adjust_point): Use EMACS_INT, not int.
7012 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7013 not EMACS_UINT, for indexes.
7015 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7017 * buffer.c: Include <verify.h>.
7018 (struct sortvec.priority, struct sortstr.priority):
7019 Now EMACS_INT, not int.
7020 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
7021 (struct sortstr.size, record_overlay_string)
7022 (struct sortstrlist.size, struct sortlist.used):
7023 Don't truncate size to int.
7024 (record_overlay_string): Check for size-calculation overflow.
7025 (init_buffer_once): Check at compile-time, not run-time.
7027 2011-06-22 Jim Meyering <meyering@redhat.com>
7029 Don't leak an XBM-image-sized buffer
7030 * image.c (xbm_load): Free the image buffer after using it.
7032 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7035 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7036 that Sun C diagnosed.
7037 * fns.c (secure_hash): Fix pointer signedness issue.
7038 * intervals.c (static_offset_intervals): New function.
7039 (offset_intervals): Use it.
7041 2011-06-21 Leo Liu <sdl.web@gmail.com>
7044 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7047 * fns.c (secure_hash): Rename from crypto_hash_function and change
7048 the first arg to accept symbols.
7049 (Fsecure_hash): New primitive.
7050 (syms_of_fns): New symbols.
7052 2011-06-20 Deniz Dogan <deniz@dogan.se>
7054 * process.c (Fset_process_buffer): Clarify return value in
7057 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
7059 * dispnew.c (add_window_display_history): Use BVAR.
7061 * xdisp.c (debug_method_add): Use BVAR.
7062 (check_window_end, dump_glyph_matrix, dump_glyph)
7063 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7065 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7068 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7069 check till after the cache is created in init_frame_faces.
7071 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7073 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7075 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7077 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7078 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7079 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7081 Improve buffer-overflow checking (Bug#8873).
7082 * fileio.c (Finsert_file_contents):
7083 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7084 Remove the old (too-loose) buffer overflow checks.
7085 They weren't needed, since make_gap checks for buffer overflow.
7086 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7087 The old code merely checked for Emacs fixnum overflow, and relied
7088 on undefined (wraparound) behavior. The new code avoids undefined
7089 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7091 * editfns.c (Finsert_char): Don't dump core with very negative counts.
7092 Tune. Don't use wider integers than needed. Don't use alloca.
7093 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
7095 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7097 * insdel.c, lisp.h (buffer_overflow): New function.
7098 (insert_from_buffer_1, replace_range, replace_range_2):
7099 * insdel.c (make_gap_larger):
7100 * editfns.c (Finsert_char):
7101 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7103 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7105 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7107 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
7109 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7110 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7112 * fileio.c: Don't assume EMACS_INT fits in off_t.
7113 (emacs_lseek): New static function.
7114 (Finsert_file_contents, Fwrite_region): Use it.
7115 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7117 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7119 * fns.c: Don't overflow int when computing a list length.
7120 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7121 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7122 truncation on 64-bit hosts. Check for QUIT every
7123 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7124 faster and is responsive enough.
7125 (Flength): Report an error instead of overflowing an integer.
7126 (Fsafe_length): Return a float if the value is not representable
7127 as a fixnum. This shouldn't happen except in contrived situations.
7128 (Fnthcdr, Fsort): Don't assume list length fits in int.
7129 (Fcopy_sequence): Don't assume vector length fits in int.
7131 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7132 (header_size, word_size): New constants.
7133 (allocate_vectorlike): Don't check size overflow here.
7134 (allocate_vector): Check it here instead, since this is the only
7135 caller of allocate_vectorlike that could cause overflow.
7136 Check that the new vector's length is representable as a fixnum.
7138 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7139 The previous code was bogus. For example, next_almost_prime (32)
7140 returned 39, which is undesirable as it is a multiple of 3; and
7141 next_almost_prime (24) returned 25, which is a multiple of 5 so
7142 why was the code bothering to check for multiples of 7?
7144 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7146 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7148 Variadic C functions now count arguments with ptrdiff_t.
7149 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7150 Back then I didn't know that the Emacs coding style prefers signed int.
7151 Also, in the meantime I found a few more instances where arguments
7152 were being counted with int, which may truncate counts on 64-bit
7153 machines, or EMACS_INT, which may be unnecessarily wide.
7154 * lisp.h (struct Lisp_Subr.function.aMANY)
7155 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7156 Arg counts are now ptrdiff_t, not size_t.
7157 All variadic functions and their callers changed accordingly.
7158 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7159 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7160 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7161 * callint.c (Fcall_interactively): Check arg count for overflow,
7162 to avoid potential buffer overrun. Use signed char, not 'int',
7163 for 'varies' array, so that we needn't bother to check its size
7164 calculation for overflow.
7165 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7166 * eval.c (apply_lambda):
7167 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7168 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7169 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7171 * callint.c (Fcall_interactively): Don't use index var as event count.
7173 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7174 * mem-limits.h (SIZE): Remove; no longer used.
7176 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
7178 Remove unnecessary casts.
7179 * xterm.c (x_term_init):
7180 * xfns.c (x_set_border_pixel):
7181 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7182 These aren't needed now that we assume ANSI C.
7184 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7185 It's more likely to cause problems (due to unsigned overflow)
7188 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7190 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7192 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7194 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7196 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7198 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7200 GLYPH_CODE_FACE returns EMACS_INT, not int.
7201 * dispextern.h (merge_faces):
7202 * xfaces.c (merge_faces):
7203 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7204 Don't assume EMACS_INT fits in int.
7206 * character.h (CHAR_VALID_P): Remove unused parameter.
7207 * fontset.c, lisp.h, xdisp.c: All uses changed.
7209 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7211 * fns.c (concat): Minor tuning based on overflow analysis.
7212 This doesn't fix any bugs. Use int to hold character, instead
7213 of constantly refetching from Emacs object. Use XFASTINT, not
7214 XINT, for value known to be a character. Don't bother comparing
7215 a single byte to 0400, as it's always less.
7217 * floatfns.c (Fexpt):
7218 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7220 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7223 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7225 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7226 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7227 incorrectly succeed when S was a string, because 4294967386 was
7228 truncated before it was used.
7230 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7231 Otherwise, an out-of-range integer could cause undefined behavior
7234 * composite.c: Use int, not EMACS_INT, for characters.
7235 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7236 EMACS_INT, for values that are known to be in character range.
7237 This doesn't fix any bugs but is the usual style inside Emacs and
7238 may generate better code on 32-bit machines.
7240 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7241 This is for reasons similar to the recent CHAR_STRING fix.
7242 * charset.c (Fencode_char): Check that character arg is actually
7243 a character. Pass an int to ENCODE_CHAR.
7244 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7245 wider than 'int', as a compile-time check to prevent future regressions
7248 * character.c (char_string): Remove unnecessary casts.
7250 Make sure a 64-bit char is never passed to CHAR_STRING.
7251 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7252 by silently ignoring the top 32 bits, allowing some values
7253 that were far too large to be valid characters.
7254 * character.h: Include <verify.h>.
7255 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7256 arguments are no wider than unsigned, as a compile-time check
7257 to prevent future regressions in this area.
7259 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
7260 (Fsubst_char_in_region):
7262 * xdisp.c (decode_mode_spec_coding):
7263 Adjust to CHAR_STRING's new requirement.
7264 * editfns.c (Finsert_char, Fsubst_char_in_region):
7265 * fns.c (concat): Check that character args are actually
7266 characters. Without this test, these functions did the wrong
7267 thing with wildly out-of-range values on 64-bit hosts.
7269 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7270 These casts should not be needed on 32-bit hosts, either.
7271 * keyboard.c (read_char):
7272 * lread.c (Fload): Remove casts to unsigned.
7274 * lisp.h (UNSIGNED_CMP): New macro.
7275 This fixes comparison bugs on 64-bit hosts.
7276 (ASCII_CHAR_P): Use it.
7277 * casefiddle.c (casify_object):
7278 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
7279 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7280 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7281 * dispextern.h (FACE_FROM_ID):
7282 * keyboard.c (read_char): Use UNSIGNED_CMP.
7284 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7285 not to EMACS_INT, to avoid GCC warning.
7287 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7289 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7290 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7291 isn't needed on 32-bit machines.
7293 * buffer.c (Fgenerate_new_buffer_name):
7294 Use EMACS_INT for count, not int.
7295 (advance_to_char_boundary): Return EMACS_INT, not int.
7297 * data.c (Qcompiled_function): Now static.
7299 * window.c (window_body_lines): Now static.
7301 * image.c (gif_load): Rename local to avoid shadowing.
7303 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7304 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7305 * alloc.c (make_save_value): Integer argument is now of type
7307 (mark_object): Use ptrdiff_t, not int.
7308 * lisp.h (pD): New macro.
7309 * print.c (print_object): Use it.
7311 * alloc.c: Use EMACS_INT, not int, to count objects.
7312 (total_conses, total_markers, total_symbols, total_vector_size)
7313 (total_free_conses, total_free_markers, total_free_symbols)
7314 (total_free_floats, total_floats, total_free_intervals)
7315 (total_intervals, total_strings, total_free_strings):
7316 Now EMACS_INT, not int. All uses changed.
7317 (Fgarbage_collect): Compute overall total using a double, so that
7318 integer overflow is less likely to be a problem. Check for overflow
7319 when converting back to an integer.
7320 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7321 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7322 These were 'int' variables that could overflow on 64-bit hosts;
7323 they were never used, so remove them instead of repairing them.
7324 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
7325 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7326 Previously, this ceilinged at INT_MAX, but that doesn't work on
7328 (allocate_pseudovector): Don't use EMACS_INT when int would do.
7330 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
7331 (allocate_vectorlike): Check for ptrdiff_t overflow.
7332 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7333 when a (possibly-narrower) signed value would do just as well.
7334 We prefer using signed arithmetic, to avoid comparison confusion.
7336 * alloc.c: Catch some string size overflows that we were missing.
7337 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7338 for convenience in STRING_BYTES_MAX.
7339 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7340 The definition here is exact; the one in lisp.h was approximate.
7341 (allocate_string_data): Check for string overflow. This catches
7342 some instances we weren't catching before. Also, it catches
7343 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7344 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7345 and ptrdiff_t and EMACS_INT are both 64 bits.
7347 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7348 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
7349 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
7351 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7353 * alloc.c (Fmake_string): Check for out-of-range init.
7355 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7357 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7359 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7361 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7362 xg_get_default_scrollbar_width.
7364 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7365 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7366 (style_changed_cb): Call update_theme_scrollbar_width and call
7367 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7368 all frames (Bug#8505).
7369 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7370 Call gtk_window_set_resizable if HAVE_GTK3.
7371 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7372 and height if HAVE_GTK3 (Bug#8505).
7373 (scroll_bar_width_for_theme): New variable.
7374 (update_theme_scrollbar_width): New function.
7375 (xg_get_default_scrollbar_width): Move code to
7376 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7377 (xg_initialize): Call update_theme_scrollbar_width.
7379 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7381 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7383 2011-06-12 Martin Rudalics <rudalics@gmx.at>
7385 * frame.c (make_frame): Call other_buffer_safely instead of
7388 * window.c (temp_output_buffer_show): Call display_buffer with
7389 second argument Vtemp_buffer_show_specifiers and reset latter
7390 immediately after the call.
7391 (Vtemp_buffer_show_specifiers): New variable.
7392 (auto_window_vscroll_p, next_screen_context_lines)
7393 (Vscroll_preserve_screen_position): Remove leading asterisks from
7396 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
7398 Fix minor problems found by GCC 4.6.0 static checking.
7399 * buffer.c (Qclone_number): Remove for now, as it's unused.
7400 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7401 (record_buffer): Remove unused local.
7402 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7403 (set_frame_buffer_list): Remove; unused.
7404 * frame.h (other_visible_frames): Remove decl.
7405 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7406 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7407 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7409 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7410 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7411 Define only if HAVE_GPM.
7412 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7413 (update_hints_inhibit): Remove; never set. All uses removed.
7414 * widgetprv.h (emacsFrameClassRec): Remove decl.
7415 * window.c (delete_deletable_window): Now returns void, since it
7416 wasn't returning anything.
7417 (compare_window_configurations): Remove unused locals.
7418 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7419 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
7420 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7421 the same widths as pointers. This follows up on the 2011-05-06 patch.
7422 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7423 * xterm.h: Likewise.
7424 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7426 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
7428 * makefile.w32-in: Update dependencies.
7429 (LISP_H): Add lib/intprops.h.
7431 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7433 * image.c (gif_load): Add animation frame delay to the metadata.
7434 (syms_of_image): Use DEFSYM. New symbol `delay'.
7436 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7438 * window.c (delete_deletable_window): Re-add.
7439 (Fset_window_configuration): Rewrite to handle dead buffers and
7440 consequently deletable windows.
7441 (window_tree, Fwindow_tree): Remove. Supply functionality in
7443 (compare_window_configurations): Simplify code.
7445 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7447 * image.c (imagemagick_load_image): Fix type mismatch.
7448 (Fimagemagick_types): Likewise.
7450 * window.h (replace_buffer_in_windows): Declare.
7452 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7454 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7455 Qclone_number. Remove external declaration of Qdelete_window.
7456 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7458 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7459 Run Qbuffer_list_update_hook if allowed.
7460 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7461 buffer list implementation.
7462 (other_buffer_safely): New function.
7463 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7464 calls to replace_buffer_in_windows and
7465 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7467 (record_buffer): Inhibit quitting and rewrite using quittable
7468 functions. Run Qbuffer_list_update_hook if allowed.
7469 (Frecord_buffer, Funrecord_buffer): New functions.
7470 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7471 Move switch-to-buffer to window.el.
7472 (bury-buffer): Move to window.el.
7473 (Vbuffer_list_update_hook): New variable.
7475 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7478 * window.h (resize_frame_windows): Move up in code.
7479 (Fwindow_frame): Remove EXFUN.
7480 (replace_buffer_in_all_windows): Remove prototype.
7481 (replace_buffer_in_windows_safely): Add prototype.
7483 * window.c: Declare Qdelete_window static again. Move down
7484 declaration of select_count.
7485 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7486 (Fother_window): Move to window.el.
7487 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7488 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7489 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7491 (replace_buffer_in_windows): Implement by calling
7492 Qreplace_buffer_in_windows.
7493 (replace_buffer_in_all_windows): Remove with some functionality
7494 moved into replace_buffer_in_windows_safely.
7495 (replace_buffer_in_windows_safely): New function.
7496 (select_window_norecord, select_frame_norecord): Move in front
7497 of run_window_configuration_change_hook. Remove now obsolete
7499 (Fset_window_buffer): Rewrite doc-string.
7500 Call Qrecord_window_buffer.
7501 (keys_of_window): Move binding for other-window to window.el.
7503 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7505 * dispextern.h (struct image): Replace data member, whose int_val
7506 and ptr_val fields were not used by anything, with a single
7509 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7510 (gif_clear_image, gif_load, imagemagick_load_image)
7511 (gs_clear_image, gs_load): Callers changed.
7513 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7515 * buffer.h: Include <time.h>, for time_t.
7516 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7518 Fix minor problems found by static checking.
7520 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7522 Make identifiers static if they are not used in other modules.
7523 * data.c (Qcompiled_function, Qframe, Qvector):
7524 * image.c (QimageMagick, Qsvg):
7525 * minibuf.c (Qmetadata):
7526 * window.c (resize_window_check, resize_root_window): Now static.
7527 * window.h (resize_window_check, resize_root_window): Remove decls.
7529 * window.c (window_deletion_count, delete_deletable_window):
7531 (window_body_lines): Now static.
7532 (Fdelete_other_windows_internal): Mark vars as initialized.
7533 Make sure 'resize_failed' is initialized.
7534 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7535 (resize_window_apply): Remove unused local.
7536 * window.h (delete_deletable_window): Remove decl.
7538 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
7539 (imagemagick_load_image): Fix pointer signedness problem by changing
7540 last arg from unsigned char * to char *. All uses changed.
7541 Also, fix a local for similar reasons.
7542 Remove unused locals. Remove locals to avoid shadowing.
7543 (fn_rsvg_handle_free): Remove; unused.
7544 (svg_load, svg_load_image): Fix pointer signedness problem.
7545 (imagemagick_load_image): Don't use garbage pointer image_wand.
7547 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7549 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
7551 * image.c (gif_load): Fix omitted cast error introduced by
7554 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7556 * window.h (resize_proportionally, orig_total_lines)
7557 (orig_top_line): Remove from window structure.
7558 (set_window_height, set_window_width, change_window_heights)
7559 (Fdelete_window): Remove prototypes.
7560 (resize_frame_windows): Remove duplicate declaration.
7562 2011-06-10 Eli Zaretskii <eliz@gnu.org>
7564 * window.h (resize_frame_windows, resize_window_check)
7565 (delete_deletable_window, resize_root_window)
7566 (resize_frame_windows): Declare prototypes.
7568 * window.c (resize_window_apply): Make definition be "static" to
7569 match the prototype.
7571 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7573 * window.c: Remove declarations of Qwindow_size_fixed,
7574 window_min_size_1, window_min_size_2, window_min_size,
7575 size_window, window_fixed_size_p, enlarge_window, delete_window.
7576 Remove static from declaration of Qdelete_window, it's
7577 temporarily needed by Fbury_buffer.
7578 (replace_window): Don't assign orig_top_line and
7580 (Fdelete_window, delete_window): Remove. Window deletion is
7581 handled by window.el.
7582 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7583 Replace Fdelete_window calls with calls to Qdelete_window.
7584 (Fdelete_other_windows): Remove. Deleting other windows is
7585 handled by window.el.
7586 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7587 handled in window.el.
7588 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7589 Window minimum sizes are handled in window.el.
7590 (shrink_windows, size_window, set_window_height)
7591 (set_window_width, change_window_heights, window_height)
7592 (window_width, CURBEG, CURSIZE, enlarge_window)
7593 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7594 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7595 handled in window.el.
7596 (make_dummy_parent): Rename to make_parent_window and give it a
7597 second argument horflag.
7598 (make_window): Don't set resize_proportionally any more.
7599 (Fsplit_window): Remove. Windows are split in window.el.
7600 (save_restore_action, save_restore_orig_size)
7601 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7602 Resize mini windows in window.el.
7603 (grow_mini_window, shrink_mini_window): Implement by calling
7604 Qresize_root_window_vertically, resize_window_check and
7605 resize_window_apply.
7606 (saved_window, Fset_window_configuration, save_window_save):
7607 Do not handle orig_top_line, orig_total_lines, and
7608 resize_proportionally.
7609 (window_min_height, window_min_width): Move to window.el.
7610 (keys_of_window): Move bindings for delete-other-windows,
7611 split-window, delete-window and enlarge-window to window.el.
7613 * buffer.c: Temporarily extern Qdelete_window.
7614 (Fbury_buffer): Temporarily call Qdelete_window instead of
7615 Fdelete_window (Fbury_buffer will move to window.el soon).
7617 * frame.c (set_menu_bar_lines_1): Remove code handling
7618 orig_top_line and orig_total_lines.
7620 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7621 set_window_height but set heights directly.
7622 (change_frame_size_1): Use resize_frame_windows.
7624 * xdisp.c (init_xdisp): Don't use set_window_height but set
7627 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7628 Use resize_frame_windows instead of change_window_heights and run
7629 run_window_configuration_change_hook.
7631 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7632 instead of change_window_heights and run
7633 run_window_configuration_change_hook.
7635 2011-06-09 Martin Rudalics <rudalics@gmx.at>
7637 * window.c (replace_window): Rename second argument REPLACEMENT to
7638 NEW. New third argument SETFLAG. Rewrite.
7639 (delete_window, make_dummy_parent): Call replace_window with
7641 (window_list_1): Move down in code.
7642 (run_window_configuration_change_hook): Move set_buffer part
7643 before select_frame_norecord part in order to unwind correctly.
7644 Rename count1 to count.
7645 (recombine_windows, delete_deletable_window, resize_root_window)
7646 (Fdelete_other_windows_internal)
7647 (Frun_window_configuration_change_hook, make_parent_window)
7648 (resize_window_check, resize_window_apply, Fresize_window_apply)
7649 (resize_frame_windows, Fsplit_window_internal)
7650 (Fdelete_window_internal, Fresize_mini_window_internal):
7652 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7654 2011-06-08 Martin Rudalics <rudalics@gmx.at>
7656 * window.h (window): Add some new members to window structure -
7657 normal_lines, normal_cols, new_total, new_normal, clone_number,
7658 splits, nest, prev_buffers, next_buffers.
7659 (WINDOW_TOTAL_SIZE): Move here from window.c.
7660 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
7662 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7664 (make_dummy_parent): Set new members of windows structure.
7665 (make_window): Move down in code. Handle new members of window
7667 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7668 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7669 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7670 (Fset_window_prev_buffers, Fwindow_next_buffers)
7671 (Fset_window_next_buffers, Fset_window_clone_number):
7673 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7674 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7676 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7677 Argument WINDOW can be now internal window too.
7678 (Fwindow_use_time): Move up in code.
7679 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7681 (Fset_window_configuration, saved_window)
7682 (Fcurrent_window_configuration, save_window_save): Handle new
7683 members of window structure.
7684 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7685 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7686 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7687 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7688 Qget_mru_window, Qresize_root_window,
7689 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7690 Qauto_buffer_name; staticpro them.
7692 2011-06-07 Martin Rudalics <rudalics@gmx.at>
7694 * window.c (Fwindow_total_size, Fwindow_left_column)
7695 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7696 (Fwindow_list_1): New functions.
7697 (window_box_text_cols): Replace with window_body_cols.
7698 (Fwindow_width, Fscroll_left, Fscroll_right):
7699 Use window_body_cols instead of window_box_text_cols.
7700 (delete_window, Fset_window_configuration):
7701 Call delete_all_subwindows with window as argument.
7702 (delete_all_subwindows): Take a window as argument and not a
7704 (window_loop): Remove handling of GET_LRU_WINDOW and
7706 (Fget_lru_window, Fget_largest_window): Move to window.el.
7708 * window.h: Extern window_body_cols instead of
7709 window_box_text_cols. delete_all_subwindows now takes a
7710 Lisp_Object as argument.
7712 * indent.c (compute_motion, Fcompute_motion):
7713 Use window_body_cols instead of window_box_text_cols.
7715 * frame.c (delete_frame): Call delete_all_subwindows with root
7718 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7720 * fns.c (Fputhash): Document return value.
7722 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
7724 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7726 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7728 Cons<->int and similar integer overflow fixes (Bug#8794).
7730 Check for overflow when converting integer to cons and back.
7731 * charset.c (Fdefine_charset_internal, Fdecode_char):
7732 Use cons_to_unsigned to catch overflow.
7733 (Fencode_char): Use INTEGER_TO_CONS.
7734 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7735 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7736 * data.c (long_to_cons, cons_to_long): Remove.
7737 (cons_to_unsigned, cons_to_signed): New functions.
7738 These signal an error for invalid or out-of-range values.
7739 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7740 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7741 * font.c (Ffont_variation_glyphs):
7742 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7743 * lisp.h: Include <intprops.h>.
7744 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7745 (cons_to_signed, cons_to_unsigned): New decls.
7746 (long_to_cons, cons_to_long): Remove decls.
7747 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7748 (Fprimitive_undo): Use CONS_TO_INTEGER.
7749 * xfns.c (Fx_window_property): Likewise.
7750 * xselect.c: Include <limits.h>.
7751 (x_own_selection, selection_data_to_lisp_data):
7752 Use INTEGER_TO_CONS.
7753 (x_handle_selection_request, x_handle_selection_clear)
7754 (x_get_foreign_selection, Fx_disown_selection_internal)
7755 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7756 (lisp_data_to_selection_data): Use cons_to_unsigned.
7757 (x_fill_property_data): Use cons_to_signed.
7758 Report values out of range.
7760 Check for buffer and string overflow more precisely.
7761 * buffer.h (BUF_BYTES_MAX): New macro.
7762 * lisp.h (STRING_BYTES_MAX): New macro.
7763 * alloc.c (Fmake_string):
7764 * character.c (string_escape_byte8):
7765 * coding.c (coding_alloc_by_realloc):
7766 * doprnt.c (doprnt):
7767 * editfns.c (Fformat):
7769 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7770 since they may not be the same number.
7771 * editfns.c (Finsert_char):
7772 * fileio.c (Finsert_file_contents):
7773 Likewise for BUF_BYTES_MAX.
7775 * image.c: Use ptrdiff_t, not int, for sizes.
7776 (slurp_file): Switch from int to ptrdiff_t.
7778 (slurp_file): Check that file size fits in both size_t (for
7779 malloc) and ptrdiff_t (for sanity and safety).
7781 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7782 if b->modtime has its maximal value.
7784 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7786 Don't assume time_t can fit into int.
7787 * buffer.h (struct buffer.modtime): Now time_t, not int.
7788 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7789 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7791 Minor fixes for signed vs unsigned integers.
7792 * character.h (MAYBE_UNIFY_CHAR):
7793 * charset.c (maybe_unify_char):
7794 * keyboard.c (read_char, reorder_modifiers):
7795 XINT -> XFASTINT, since the integer must be nonnegative.
7796 * ftfont.c (ftfont_spec_pattern):
7797 * keymap.c (access_keymap, silly_event_symbol_error):
7798 XUINT -> XFASTINT, since the integer must be nonnegative.
7799 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7800 since it makes no difference and we prefer signed.
7801 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7802 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7805 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7807 * window.h (Fwindow_frame): Declare.
7809 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7811 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7812 (SPARE_MEMORY): Always define.
7813 (LARGE_REQUEST): Remove.
7814 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7816 2011-06-06 Martin Rudalics <rudalics@gmx.at>
7818 * lisp.h: Move EXFUNS for Fframe_root_window,
7819 Fframe_first_window and Fset_frame_selected_window to window.h.
7821 * window.h: Move EXFUNS for Fframe_root_window,
7822 Fframe_first_window and Fset_frame_selected_window here from
7825 * frame.c (Fwindow_frame, Fframe_first_window)
7826 (Fframe_root_window, Fframe_selected_window)
7827 (Fset_frame_selected_window): Move to window.c.
7828 (Factive_minibuffer_window): Move to minibuf.c.
7829 (Fother_visible_frames_p): New function.
7831 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7833 * window.c (decode_window, decode_any_window): Move up in code.
7834 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7835 (inhibit_frame_unsplittable): Remove unused variable.
7836 (Fwindow_buffer): Move up and rewrite doc-string.
7837 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7838 (Fwindow_prev): New functions.
7839 (Fwindow_frame): Move here from frame.c. Accept any window as
7841 (Fframe_root_window, Fframe_first_window)
7842 (Fframe_selected_window): Move here from frame.c. Accept frame
7843 or arbitrary window as argument. Update doc-strings.
7844 (Fminibuffer_window): Move up in code.
7845 (Fwindow_minibuffer_p): Move up in code and simplify.
7846 (Fset_frame_selected_window): Move here from frame.c.
7848 (Fselected_window, select_window, Fselect_window): Move up in
7849 code. Minor doc-string fixes.
7851 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7853 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7854 Do not assume that spare memory exists; that assumption is valid
7855 only if SYSTEM_MALLOC.
7856 (LARGE_REQUEST): New macro, so that the issue of large requests
7857 is separated from the issue of spare memory.
7859 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7861 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7864 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7866 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7869 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7871 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7873 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7875 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7876 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7878 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
7880 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7882 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
7884 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7885 (x_clipboard_manager_save): Add return value.
7886 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7888 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7889 Obey Vx_select_enable_clipboard_manager. Catch errors in
7890 x_clipboard_manager_save (Bug#8779).
7891 (Vx_select_enable_clipboard_manager): New variable.
7892 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
7894 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
7896 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7898 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7900 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7901 in the current matrix if keep_current_p is non-zero.
7903 2011-06-04 Eli Zaretskii <eliz@gnu.org>
7905 * bidi.c (bidi_level_of_next_char): Fix last change.
7907 2011-06-03 Eli Zaretskii <eliz@gnu.org>
7909 Support bidi reordering of text covered by display properties.
7911 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7912 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7913 (bidi_cache_search, bidi_cache_iterator_state)
7914 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
7915 (bidi_level_of_next_char, bidi_move_to_visually_next):
7916 Support character positions inside a run of characters covered by a
7918 (bidi_paragraph_init, bidi_resolve_explicit_1)
7919 (bidi_level_of_next_char): Call bidi_fetch_char and
7920 bidi_fetch_char_advance instead of FETCH_CHAR and
7922 (bidi_init_it): Initialize new members.
7923 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7925 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7926 instead of using explicit *_CHAR codes.
7927 (bidi_resolve_explicit, bidi_resolve_weak):
7928 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
7929 bidirectional text is supported only in multibyte buffers.
7930 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7931 it to initialize the frame_window_p member of struct bidi_it.
7932 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7933 (bidi_resolve_explicit, bidi_resolve_weak)
7934 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7935 bidi_it->nchars is non-positive.
7936 (bidi_level_of_next_char): Don't try to lookup the cache for the
7937 next/previous character if nothing is cached there yet, or if we
7938 were just reseat()'ed to a new position.
7940 * xdisp.c (set_cursor_from_row): Set start and stop points
7941 according to the row's direction when priming the loop that looks
7942 for the glyph on which to display cursor.
7943 (single_display_spec_intangible_p): Function deleted.
7944 (display_prop_intangible_p): Reimplement to call
7945 handle_display_spec instead of single_display_spec_intangible_p.
7946 Accept 3 additional arguments needed by handle_display_spec.
7947 This fixes incorrect cursor motion across display property with complex
7948 values: lists, `(when COND...)' forms, etc.
7949 (single_display_spec_string_p): Support property values that are
7950 lists with the argument STRING its top-level element.
7951 (display_prop_string_p): Fix the condition for processing a
7952 property that is a list to be consistent with handle_display_spec.
7953 (handle_display_spec): New function, refactored from the
7954 last portion of handle_display_prop.
7955 (compute_display_string_pos): Accept additional argument
7956 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7957 value of a `display' property is a "replacing spec".
7958 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7959 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7960 the display property, but just return a value indicating whether
7961 the display property will replace the characters it covers.
7962 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7963 frame_window_p members of struct bidi_it.
7964 (compute_display_string_pos, compute_display_string_end):
7966 (push_it): Accept second argument POSITION, where pop_it should
7967 jump to continue iteration.
7968 (reseat_1): Initialize bidi_it.disp_pos.
7970 * keyboard.c (adjust_point_for_property): Adjust the call to
7971 display_prop_intangible_p to its new signature.
7973 * dispextern.h (struct bidi_it): New member frame_window_p.
7974 (bidi_init_it): Update prototypes.
7975 (display_prop_intangible_p): Update prototype.
7976 (compute_display_string_pos, compute_display_string_end):
7978 (struct bidi_it): New members nchars and disp_pos. ch_len is now
7981 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
7983 Malloc failure behavior now depends on size of allocation.
7984 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
7985 * lisp.h: Change signatures accordingly.
7986 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7987 All callers changed. (Bug#8762)
7989 * gnutls.c: Use Emacs's memory allocators.
7990 Without this change, the gnutls library would invoke malloc etc.
7991 directly, which causes problems on non-SYNC_INPUT hosts, and which
7992 runs afoul of improving memory_full behavior. (Bug#8761)
7993 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7994 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7995 xfree instead of the default malloc, realloc, free.
7996 (Fgnutls_boot): No need to check for memory allocation failure,
7997 since xmalloc does that for us.
7999 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
8000 * category.c (hash_get_category_set):
8001 * ccl.c (ccl_driver):
8002 * charset.c (Fdefine_charset_internal):
8003 * charset.h (struct charset.hash_index):
8004 * composite.c (get_composition_id, gstring_lookup_cache)
8005 (composition_gstring_put_cache):
8006 * composite.h (struct composition.hash_index):
8007 * dispextern.h (struct image.hash):
8008 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8009 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8010 (hashfn_equal, hashfn_user_defined, make_hash_table)
8011 (maybe_resize_hash_table, hash_lookup, hash_put)
8012 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8013 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8014 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8015 * image.c (make_image, search_image_cache, lookup_image)
8016 (xpm_put_color_table_h):
8017 * lisp.h (struct Lisp_Hash_Table):
8018 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
8019 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
8020 for hashes and hash indexes, instead of 'unsigned' and 'int'.
8021 * alloc.c (allocate_vectorlike):
8022 Check for overflow in vector size calculations.
8023 * ccl.c (ccl_driver):
8024 Check for overflow when converting EMACS_INT to int.
8025 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8026 need to be updated by these changes.
8027 * fns.c (make_hash_table, maybe_resize_hash_table):
8028 Check for integer overflow with large hash tables.
8029 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8030 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8031 (SXHASH_REDUCE): New macro.
8032 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8033 Use it instead of discarding useful hash info with large hash values.
8034 (sxhash_float): New function.
8035 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8036 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
8037 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8038 Rewrite to use FIXNUM_BITS, as this simplifies things.
8039 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8040 Adjust signatures to match updated version of code.
8041 (consing_since_gc): Now EMACS_INT, since a single hash table can
8042 use more than INT_MAX bytes.
8044 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8046 Make it possible to build with GCC-4.6+ -O2 -flto.
8048 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8050 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8052 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8053 Call minibuffer-inactive-mode.
8055 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
8057 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8058 Update dependencies.
8060 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8062 * data.c (init_data): Remove code for UTS, this system is not
8065 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8067 Don't force ./temacs to start in terminal mode.
8069 * frame.c (make_initial_frame): Initialize faces in all cases, not
8070 only when CANNOT_DUMP is defined.
8071 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8073 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8075 * dispnew.c (add_window_display_history): Use const for the string
8076 pointer. Remove declaration, not needed.
8078 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8080 Use 'inline', not 'INLINE'.
8081 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
8082 * alloc.c, fontset.c (INLINE): Remove.
8083 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8084 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8085 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8086 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8087 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8089 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8091 Make it possible to run ./temacs.
8093 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8094 syms_of_callproc does the same thing. Remove test for
8095 "initialized", do it in the caller.
8096 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8098 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8100 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8101 (read_minibuf): Use get_minibuffer.
8102 (syms_of_minibuf): Use DEFSYM.
8103 (Qmetadata): New var.
8104 * data.c (Qbuffer): Don't make it static.
8105 (syms_of_data): Use DEFSYM.
8107 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8109 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8110 (CCL_CODE_MIN): New macro.
8112 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8114 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8116 * eval.c (Qdebug): Now static.
8117 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8118 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8119 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8121 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8123 * image.c: Various fixes to ImageMagick code comments.
8124 (Fimagemagick_types): Doc fix.
8126 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8128 Minor fixes prompted by GCC 4.6.0 warnings.
8130 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8132 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8133 (x_clipboard_manager_save_all): Move extern decl to ...
8134 * xterm.h: ... here, so that it can be checked for consistency.
8136 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8138 * xselect.c (x_clipboard_manager_save_frame)
8139 (x_clipboard_manager_save_all): New functions.
8140 (Fx_clipboard_manager_save): Lisp function deleted.
8142 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8143 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8145 * xterm.h: Update prototype.
8147 2011-05-28 William Xu <william.xwl@gmail.com>
8149 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8152 2011-05-28 Jim Meyering <meyering@redhat.com>
8154 Avoid a sign-extension bug in crypto_hash_function.
8155 * fns.c (to_uchar): Define.
8156 (crypto_hash_function): Use it to convert some newly-signed
8157 variables to unsigned, to avoid sign-extension bugs. For example,
8158 without this change, (md5 "truc") would evaluate to
8159 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8160 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
8161 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
8163 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8165 Integer overflow fixes.
8167 * dbusbind.c: Serial number integer overflow fixes.
8168 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
8169 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8170 to hold a serial number that is too large for a fixnum.
8171 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8172 Check for serial numbers out of range. Decode any serial number
8173 that was so large that it became a float. (Bug#8722)
8175 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8176 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8177 Use XFASTINT rather than XUINT when numbers are nonnegative.
8178 (xd_append_arg, Fdbus_method_return_internal):
8179 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8180 arguments, check that Lisp number is nonnegative, rather than
8181 silently wrapping negative numbers around. (Bug#8722)
8182 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
8185 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8187 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8189 ccl: Add integer overflow checks.
8190 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8191 (IN_INT_RANGE): New macros.
8192 (ccl_driver): Use them to check for integer overflow when
8193 decoding a CCL program. Many of the new checks are whether XINT (x)
8194 fits in int; it doesn't always, on 64-bit hosts. The new version
8195 doesn't catch all possible integer overflows, but it's an
8196 improvement. (Bug#8719)
8198 * alloc.c (make_event_array): Use XINT, not XUINT.
8199 There's no need for unsigned here.
8201 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8202 This follows up to the 2011-05-06 change that substituted uintptr_t
8203 for EMACS_INT. This case wasn't caught back then.
8205 Rework Fformat to avoid integer overflow issues.
8206 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8207 now (part of C89). Include <verify.h>.
8208 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8209 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8210 (Fformat): Avoid the prepass trying to compute sizes; it was only
8211 approximate and thus did not catch overflow reliably. Instead, walk
8212 through the format just once, formatting and computing sizes as we go,
8213 checking for integer overflow at every step, and allocating a larger
8214 buffer as needed. Keep track separately whether the format is
8215 multibyte. Keep only the most-recently calculated precision, rather
8216 than them all. Record whether each argument has been converted to
8217 string. Use EMACS_INT, not int, for byte and char and arg counts.
8218 Support field widths and precisions larger than INT_MAX. Avoid
8219 sprintf's undefined behavior with conversion specifications such as %#d
8220 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8221 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8222 formatting out-of-range floating point numbers with int
8225 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8227 * data.c: Avoid integer truncation in expressions involving floats.
8228 * data.c: Include <intprops.h>.
8229 (arith_driver): When there's an integer overflow in an expression
8230 involving floating point, convert the integers to floating point
8231 so that the resulting value does not suffer from catastrophic
8232 integer truncation. For example, on a 64-bit host (* 4
8233 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8234 Do not rely on undefined behavior after integer overflow.
8236 merge count_size_as_multibyte, parse_str_to_multibyte
8237 * character.c, character.h (count_size_as_multibyte):
8238 Rename from parse_str_to_multibyte; all uses changed.
8239 Check for integer overflow.
8240 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8241 since it's now a duplicate of the other. This is more of
8242 a character than a buffer op, so better that it's in character.c.
8243 * fns.c, print.c: Adjust to above changes.
8245 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8247 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8249 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8251 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8252 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8253 (x_clipboard_manager_save): Now static.
8254 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8256 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8257 (crypto_hash_function): Now static.
8258 Fix pointer signedness problems. Avoid unnecessary initializations.
8260 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
8262 * termhooks.h (Vselection_alist): Make it terminal-local.
8264 * terminal.c (create_terminal): Initialize it.
8266 * xselect.c: Support for clipboard managers.
8267 (Vselection_alist): Move to termhooks.h as terminal-local var.
8268 (LOCAL_SELECTION): New macro.
8269 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8270 (symbol_to_x_atom): Remove gratuitous arg.
8271 (x_handle_selection_request, lisp_data_to_selection_data)
8272 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
8273 (x_own_selection, x_get_local_selection, x_convert_selection):
8274 New arg, specifying work frame. Use terminal-local Vselection_alist.
8275 (some_frame_on_display): Delete unused function.
8276 (Fx_own_selection_internal, Fx_get_selection_internal)
8277 (Fx_disown_selection_internal, Fx_selection_owner_p)
8278 (Fx_selection_exists_p): New optional frame arg.
8279 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8280 (x_handle_selection_clear): Don't treat other terminals with the
8281 same keyboard specially. Use the terminal-local Vselection_alist.
8282 (x_clear_frame_selections): Use Frun_hook_with_args.
8284 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8286 * xterm.h: Add support for those atoms.
8288 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
8290 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8291 (converted_selections, conversion_fail_tag): New global variables.
8292 (x_selection_request_lisp_error): Free the above.
8293 (x_get_local_selection): Remove unnecessary code.
8294 (x_reply_selection_request): Args changed; handle arbitrary array
8295 of converted selections stored in converted_selections.
8296 Separate the XChangeProperty and SelectionNotify steps.
8297 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8298 (x_convert_selection): New function.
8299 (x_handle_selection_event): Simplify.
8300 (x_get_foreign_selection): Don't ignore incoming requests while
8301 waiting for an answer; this will fail when we implement
8302 SAVE_TARGETS, and seems unnecessary anyway.
8303 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8304 (Vx_sent_selection_functions): Doc fix.
8306 2011-05-26 Leo Liu <sdl.web@gmail.com>
8308 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8310 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8312 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8314 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8315 for fringe update if it has periodic bitmap.
8316 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
8317 and fringe_bitmap_periodic_p.
8319 * fringe.c (get_fringe_bitmap_data): New function.
8320 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8321 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8322 row. Mark glyph row for fringe update if periodicity changed.
8324 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8325 for fringe update unless it has periodic bitmap.
8327 2011-05-25 Kenichi Handa <handa@m17n.org>
8329 * xdisp.c (get_next_display_element): Set correct it->face_id for
8330 a static composition.
8332 2011-05-24 Leo Liu <sdl.web@gmail.com>
8335 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8337 * fns.c (crypto_hash_function, Fsha1): New function.
8338 (Fmd5): Use crypto_hash_function.
8339 (syms_of_fns): Add Ssha1.
8341 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8343 * gnutls.c: Remove unused macros.
8344 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8345 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8346 Remove macros that are defined and never used.
8347 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8349 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8351 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8352 (Fx_get_selection_internal): Minor cleanup.
8353 (Fx_own_selection_internal): Rename arguments for consistency with
8356 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8358 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8360 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8362 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8364 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8366 * dispnew.c (scrolling_window): Don't exclude the case that the
8367 last enabled row in the desired matrix touches the bottom boundary.
8369 2011-05-21 Glenn Morris <rgm@gnu.org>
8371 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
8372 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8373 and add some more files.
8375 2011-05-20 Eli Zaretskii <eliz@gnu.org>
8377 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8378 report_file_error introduced by the change from 2011-05-07.
8380 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8382 * systime.h (Time): Define only if emacs is defined.
8383 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8384 where the include path doesn't have X11/X.h by default. See
8385 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8387 2011-05-20 Kenichi Handa <handa@m17n.org>
8389 * composite.c (find_automatic_composition): Fix previous change.
8391 2011-05-20 Glenn Morris <rgm@gnu.org>
8393 * lisp.mk: New file, split from Makefile.in.
8394 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8395 (shortlisp): Remove.
8396 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8398 2011-05-19 Glenn Morris <rgm@gnu.org>
8400 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8401 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8402 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8403 (lisp): Set the order to that of loadup.el.
8404 (shortlisp): Make it a copy of $lisp.
8405 (SOME_MACHINE_LISP): Remove.
8406 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8407 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8409 2011-05-18 Kenichi Handa <handa@m17n.org>
8411 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8412 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8413 (find_automatic_composition): Mostly rewrite for efficiency.
8415 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
8417 * makefile.w32-in: Update dependencies.
8419 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8421 * menu.c: Include limits.h (fixes the MS-Windows build broken by
8422 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8424 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
8426 Fix some integer overflow issues, such as string length overflow.
8428 * insdel.c (count_size_as_multibyte): Check for string overflow.
8430 * character.c (lisp_string_width): Check for string overflow.
8431 Use EMACS_INT, not int, for string indexes and lengths; in
8432 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8433 the resulting string length overflows an EMACS_INT; instead,
8434 report a string overflow if no precision given. When checking for
8435 precision exhaustion, use a check that cannot possibly have
8436 integer overflow. (Bug#8675)
8437 * character.h (lisp_string_width): Adjust to new signature.
8439 * alloc.c (string_overflow): New function.
8440 (Fmake_string): Use it. This doesn't change behavior, but saves
8441 a few bytes and will simplify future changes.
8442 * character.c (string_escape_byte8): Likewise.
8443 * lisp.h (string_overflow): New decl.
8445 Fixups, following up to the user-interface timestamp change.
8446 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8447 for UI timestamps, instead of unsigned long.
8448 * msdos.c (mouse_get_pos): Likewise.
8449 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
8450 * w32gui.h (Time): Define by including "systime.h" rather than by
8451 declaring it ourselves. (Bug#8664)
8453 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8454 * image.c (clear_image_cache): Likewise.
8456 * term.c (term_mouse_position): Don't assume time_t wraparound.
8458 Be more systematic about user-interface timestamps.
8459 Before, the code sometimes used 'Time', sometimes 'unsigned long',
8460 and sometimes 'EMACS_UINT', to represent these timestamps.
8461 This change causes it to use 'Time' uniformly, as that's what X uses.
8462 This makes the code easier to follow, and makes it easier to catch
8463 integer overflow bugs such as Bug#8664.
8464 * frame.c (Fmouse_position, Fmouse_pixel_position):
8465 Use Time, not unsigned long, for user-interface timestamps.
8466 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8467 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8468 * keyboard.h (last_event_timestamp): Likewise.
8469 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8470 * menu.h (xmenu_show): Likewise.
8471 * term.c (term_mouse_position): Likewise.
8472 * termhooks.h (struct input_event.timestamp): Likewise.
8473 (struct terminal.mouse_position_hook): Likewise.
8474 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8475 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8476 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8477 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8479 * menu.h, termhooks.h: Include "systime.h", for Time.
8481 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8482 Don't assume that the difference between two unsigned long values
8483 can fit into an integer. At this point, we know button_down_time
8484 <= event->timestamp, so the difference must be nonnegative, so
8485 there's no need to cast the result if double-click-time is
8486 nonnegative, as it should be; check that it's nonnegative, just in
8487 case. This bug is triggered when events are more than 2**31 ms
8488 apart (about 25 days). (Bug#8664)
8490 * xselect.c (last_event_timestamp): Remove duplicate decl.
8491 (x_own_selection): Remove needless cast to unsigned long.
8493 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8494 that always fit in int. Use a sentinel instead of a counter, to
8495 avoid a temp and to allay GCC's concerns about possible int overflow.
8496 * frame.h (struct frame): Use int for menu_bar_items_used
8497 instead of EMACS_INT, since it always fits in int.
8499 * menu.c (grow_menu_items): Check for int overflow.
8501 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8503 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8504 Before, the code was not consistent. These values cannot exceed
8505 2**31 - 1 so there's no need to make them unsigned.
8506 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8507 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8508 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8510 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8512 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8513 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8514 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8515 presumably because the widths might not match.
8517 * window.c (size_window): Avoid needless test at loop start.
8519 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8521 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8523 2011-05-12 Drew Adams <drew.adams@oracle.com>
8525 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8527 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8529 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8530 `width' to `bar_area_x' and `bar_area_width', respectively.
8531 (x_scroll_run): Take account of fringe background extension.
8533 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8534 Rename local vars `left' and `width' to `bar_area_x' and
8535 `bar_area_width', respectively.
8536 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8537 background extension.
8539 2011-05-10 Jim Meyering <meyering@redhat.com>
8541 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8543 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
8545 * image.c (Finit_image_library): Return t for built-in image types,
8546 like pbm and xbm. (Bug#8640)
8548 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8550 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8552 2011-05-07 Eli Zaretskii <eliz@gnu.org>
8554 * w32console.c (Fset_screen_color): Doc fix.
8555 (Fget_screen_color): New function.
8556 (syms_of_ntterm): Defsubr it.
8558 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8559 unlink the temporary file if Fcall_process didn't create it in the
8561 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8562 child process will be redirected to a file specified with `:file'.
8563 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8564 cue to call_process_cleanup not to close that handle.
8566 2011-05-07 Ben Key <bkey76@gmail.com>
8568 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8569 one of two shell specific rules, either bootstrap-temacs-CMD or
8570 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8571 to the previous implementation of the bootstrap-temacs rule.
8572 The bootstrap-temacs-CMD rule is similar to the previous
8573 implementation of the bootstrap-temacs rule except that it
8574 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8577 These changes, along with some changes to nt/configure.bat,
8578 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8579 earlier fix to add support for --cflags and --ldflags options
8580 that include quotes so that it works whether make uses cmd or
8583 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
8585 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8586 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8588 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8589 a string. Handle both cases.
8590 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8591 (Fdbus_register_method): Use Qinvalid_function.
8593 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8595 * makefile.w32-in: Update dependencies.
8596 (LISP_H): Add inttypes.h and stdin.h.
8597 (PROCESS_H): Add unistd.h.
8599 2011-05-06 Eli Zaretskii <eliz@gnu.org>
8601 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8602 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8604 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
8606 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8608 * term.c (vfatal): Remove stray call to va_end.
8609 It's not needed and the C Standard doesn't allow it here anyway.
8611 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8612 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8614 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8617 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8619 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8621 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8623 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8625 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8627 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8628 * charset.c (Fdefine_charset_internal): Don't initialize
8629 charset.code_space[15]. The value was garbage, on hosts with
8630 32-bit int (Bug#8600).
8632 * lread.c (read_integer): Be more consistent with string-to-number.
8633 Use string_to_number to do the actual conversion; this avoids
8634 rounding errors and fixes some other screwups. Without this fix,
8635 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8636 (digit_to_number): Move earlier, for benefit of read_integer.
8637 Return -1 if the digit is out of range for the base, -2 if it is
8638 not a digit in any supported base. (Bug#8602)
8640 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8642 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8643 to match comment at start of function. This also removes a
8644 GCC warning about overflow in a 32+64-bit port.
8646 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8648 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8649 Reported by Stefan Monnier in
8650 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
8651 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8652 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
8654 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8655 (EMACS_UINTPTR): Likewise, with uintptr_t.
8657 * lisp.h: Prefer 64-bit EMACS_INT if available.
8658 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8659 on 32-bit hosts that have 64-bit int, so that they can access
8661 However, temporarily disable this change unless the temporary
8662 symbol WIDE_EMACS_INT is defined.
8664 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8666 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8667 This removes an assumption that EMACS_INT and long are the same
8668 width as pointers. The assumption is true for Emacs porting targets
8669 now, but we want to make other targets possible.
8670 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8671 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8672 In the rest of the code, change types of integers that hold casted
8673 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8674 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8675 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8676 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8677 No need to cast type when ORing.
8678 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8679 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8680 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8681 assume EMACS_INT is the same width as char *.
8682 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8683 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8684 Remove no-longer-needed casts.
8685 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8686 (xg_tool_bar_help_callback, xg_make_tool_item):
8687 Use EMACS_INTPTR to hold an integer
8688 that will be cast to void *; this can avoid a GCC warning
8689 if EMACS_INT is not the same width as void *.
8690 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8691 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8692 (current_message_1, set_message_1):
8693 Use a local to convert to proper width without a cast.
8694 * xmenu.c (dialog_selection_callback): Likewise.
8696 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8697 Also, don't assume VALBITS / RAND_BITS is less than 5,
8698 and don't rely on undefined behavior when shifting a 1 left into
8700 * lisp.h (get_random): Change signature to match.
8702 * lread.c (hash_string): Use size_t, not int, for hash computation.
8703 Normally we prefer signed values; but hashing is special, because
8704 it's better to use unsigned division on hash table sizes so that
8705 the remainder is nonnegative. Also, size_t is the natural width
8706 for hashing into memory. The previous code used 'int', which doesn't
8707 retain enough info to hash well into very large tables.
8708 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8710 * dbusbind.c: Don't possibly lose pointer info when converting.
8711 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8712 Use XPNTR rather than XHASH, so that the high-order bits of
8713 the pointer aren't lost when converting through void *.
8715 * eval.c (Fautoload): Don't double-shift a pointer.
8717 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8719 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8721 * gnutls.c (DEF_GNUTLS_FN):
8722 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8724 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8726 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8729 2011-05-05 Eli Zaretskii <eliz@gnu.org>
8731 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8732 New version that can reserve upto 2GB of heap space.
8734 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
8736 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8738 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8740 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8741 `gnutls_certificate_set_x509_key_file'.
8743 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
8745 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8746 Update dependencies.
8748 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8750 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8751 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8752 Remove unused parameter `fildes'.
8753 * process.c (read_process_output, send_process): Don't pass it.
8755 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8757 Fix previous change: the library cache is defined in w32.c.
8758 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8759 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8761 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8763 Implement dynamic loading of GnuTLS on Windows.
8765 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8766 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8767 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8770 * gnutls.c (Qgnutls_dll): Define.
8771 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8772 (gnutls_*): Declare function pointers.
8773 (init_gnutls_functions): New function to initialize function pointers.
8774 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8775 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8776 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8777 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8778 (emacs_gnutls_write, emacs_gnutls_read)
8779 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8780 (Fgnutls_available_p): New function.
8781 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8782 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8783 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8785 * image.c: Include w32.h.
8786 (Vimage_type_cache): Delete.
8787 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8788 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8789 (w32_delayed_load): Move to w32.c.
8791 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8793 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8794 (w32_delayed_load): Move from image.c. When loading a library, record
8795 its filename in the :loaded-from property of the library id.
8796 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8797 Initialize and staticpro them.
8798 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8800 * process.c: Include lisp.h before w32.h, not after.
8801 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8802 instead of gnutls_record_check_pending.
8804 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8806 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8808 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8809 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8812 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8814 * xterm.c (x_set_frame_alpha): Do not set property on anything
8815 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8817 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8819 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8821 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8823 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8824 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8825 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8826 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8827 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8828 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8829 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8830 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8831 (Qgnutls_bootprop_callbacks_verify): Make static.
8833 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8835 * callproc.c: Indentation fixup.
8837 * sysdep.c (wait_for_termination_1): Make static.
8838 (wait_for_termination, interruptible_wait_for_termination):
8839 Move after wait_for_termination_1.
8841 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8843 * sysdep.c (interruptible_wait_for_termination): New function
8844 which is like wait_for_termination, but allows keyboard
8847 * callproc.c (Fcall_process): Add (:file "file") as an option for
8849 (Fcall_process_region): Ditto.
8851 2011-04-30 Eli Zaretskii <eliz@gnu.org>
8853 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8854 rather than `XVECTOR (FOO)->size'.
8856 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8857 inttypes.h, as a gnulib replacement is used if it not available in
8860 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8862 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8863 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8864 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8866 * coding.c (coding_alloc_by_realloc): Error out if destination
8867 will grow beyond MOST_POSITIVE_FIXNUM.
8868 (decode_coding_emacs_mule): Abort if there isn't enough place in
8869 charbuf for the composition carryover bytes. Reserve an extra
8870 space for up to 2 characters produced in a loop.
8871 (decode_coding_iso_2022): Abort if there isn't enough place in
8872 charbuf for the composition carryover bytes.
8874 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8876 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8877 aborting when %lld or %lll format is passed.
8878 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8879 %llo or %llx format is passed. (Bug#8545)
8881 * window.c (window_scroll_line_based): Use a marker instead of
8882 simple variables to record original value of point. (Bug#7952)
8884 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8885 produced by %s or %c overflows available buffer space. (Bug#8545)
8887 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8889 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
8890 (SIZE_MAX): Move defn after all includes, as they might #define it.
8892 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8894 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8896 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8898 * keyboard.c (Qdelayed_warnings_hook): Define.
8899 (command_loop_1): Run `delayed-warnings-hook'
8900 if Vdelayed_warnings_list is non-nil.
8901 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8902 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8904 2011-04-28 Eli Zaretskii <eliz@gnu.org>
8906 * doprnt.c (doprnt): Don't return value smaller than the buffer
8907 size if the message was truncated. (Bug#8545).
8909 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8911 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8912 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8914 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8916 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8918 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
8920 * makefile.w32-in: Update dependencies.
8922 2011-04-27 Eli Zaretskii <eliz@gnu.org>
8924 Improve `doprnt' and its usage. (Bug#8545)
8925 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8926 `format_end'. Remove support for %l as a conversion specifier.
8927 Don't use xrealloc. Improve diagnostics when the %l size modifier
8928 is used. Update the commentary.
8930 * eval.c (verror): Simplify calculation of size_t.
8932 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8935 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8937 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8940 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8942 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8943 This makes this file independent of the recent pseudovector change.
8945 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
8947 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8949 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
8950 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8951 Remove unused local.
8952 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
8954 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
8955 GCC 4.6.0 optimizes based on type-based alias analysis.
8956 For example, if b is of type struct buffer * and v of type struct
8957 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8958 != &v->size, and therefore "v->size = 1; b->size = 2; return
8959 v->size;" must therefore return 1. This assumption is incorrect
8960 for Emacs, since it type-puns struct Lisp_Vector * with many other
8961 types. To fix this problem, this patch adds a new type struct
8962 vectorlike_header that documents the constraints on layout of vectors
8963 and pseudovectors, and helps optimizing compilers not get fooled
8964 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8965 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
8966 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8968 (XSETPVECTYPE): Rewrite in terms of new macro.
8969 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8970 This is a bit clearer, and further avoids the possibility of
8971 undesirable aliasing.
8972 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
8973 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
8974 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8975 since Lisp_Subr is a special case (no "next" field).
8976 (ASIZE): Now uses header.size rather than size.
8977 All previous uses of XVECTOR (foo)->size replaced to use this macro,
8978 to avoid the hassle of writing XVECTOR (foo)->header.size.
8979 (struct vectorlike_header): New type.
8980 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
8981 object, to help avoid aliasing.
8982 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
8983 (SUBRP): Likewise, since Lisp_Subr is a special case.
8984 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
8985 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
8986 (struct Lisp_Hash_Table): Combine first two members into a single
8987 struct vectorlike_header member. All uses of "size" and "next" members
8988 changed to be "header.size" and "header.next".
8989 * buffer.h (struct buffer): Likewise.
8990 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8991 * frame.h (struct frame): Likewise.
8992 * process.h (struct Lisp_Process): Likewise.
8993 * termhooks.h (struct terminal): Likewise.
8994 * window.c (struct save_window_data, struct saved_window): Likewise.
8995 * window.h (struct window): Likewise.
8996 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8997 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8998 * buffer.c (init_buffer_once): Likewise.
8999 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9001 * process.c (Fformat_network_address): Use local var for size,
9004 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9006 Make the Lisp reader and string-to-float more consistent (Bug#8525)
9007 * data.c (atof): Remove decl; no longer used or needed.
9008 (digit_to_number): Move to lread.c.
9009 (Fstring_to_number): Use new string_to_number function, to be
9010 consistent with how the Lisp reader treats infinities and NaNs.
9011 Do not assume that floating-point numbers represent EMACS_INT
9012 without losing information; this is not true on most 64-bit hosts.
9013 Avoid double-rounding errors, by insisting on integers when
9014 parsing non-base-10 numbers, as the documentation specifies.
9015 * lisp.h (string_to_number): New decl, replacing ...
9016 (isfloat_string): Remove.
9017 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
9018 (read1): Do not accept +. and -. as integers; this
9019 appears to have been a coding error. Similarly, do not accept
9020 strings like +-1e0 as floating point numbers. Do not report
9021 overflow for integer overflows unless the base is not 10 which
9022 means we have no simple and reliable way to continue.
9023 Break out the floating-point parsing into a new
9024 function string_to_number, so that Fstring_to_number parses
9025 floating point numbers consistently with the Lisp reader.
9026 (digit_to_number): Move here from data.c. Make it static inline.
9027 (E_CHAR, EXP_INT): Remove, replacing with ...
9028 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9029 (string_to_number): New function, replacing isfloat_string.
9030 This function checks for valid syntax and produces the resulting
9031 Lisp float number too. Rework it so that string-to-number
9032 no longer mishandles examples like "1.0e+". Use strtoumax,
9033 so that overflow for non-base-10 numbers is reported only when
9034 there's no portable and simple way to convert to floating point.
9036 * textprop.c (set_text_properties_1): Rewrite for clarity,
9037 and to avoid GCC warning about integer overflow.
9039 * intervals.h (struct interval): Use EMACS_INT for members
9040 where EMACS_UINT might cause problems. See
9041 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9042 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9043 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9045 (offset_intervals): Tell GCC not to worry about length overflow
9046 when negating a negative length.
9048 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9049 (overrun_check_free): Likewise.
9051 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9052 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9055 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9056 (gnutls_make_error): Rename local to avoid shadowing.
9057 (gnutls_emacs_global_deinit): ifdef out; not used.
9058 (Fgnutls_boot): Use const for pointer to readonly storage.
9059 Comment out unused local. Fix pointer signedness problems.
9061 * lread.c (openp): Don't stuff size_t into an 'int'.
9062 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9063 about possible signed overflow.
9065 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9066 (GDK_KEY_g): Don't define if already defined.
9067 (xg_prepare_tooltip): Avoid pointer signedness problem.
9068 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9070 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9071 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9073 * xfns.c (Fx_window_property): Simplify a bit,
9074 to make a bit faster and to avoid GCC 4.6.0 warning.
9075 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9077 * fns.c (internal_equal): Don't assume size_t fits in int.
9079 * alloc.c (compact_small_strings): Tighten assertion a little.
9081 Replace pEd with more-general pI, and fix some printf arg casts.
9082 * lisp.h (pI): New macro, generalizing old pEd macro to other
9083 conversion specifiers. For example, use "...%"pI"d..." rather
9084 than "...%"pEd"...".
9085 (pEd): Remove. All uses replaced with similar uses of pI.
9086 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
9087 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9088 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9089 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9090 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9091 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9092 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9094 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9095 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9096 * print.c (safe_debug_print, print_object): Likewise.
9097 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9099 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9100 avoiding the 0 flag, which is not portable.
9101 * process.c (Fmake_network_process): Use pI to avoid cast.
9102 * region-cache.c (pp_cache): Likewise.
9103 * xdisp.c (decode_mode_spec): Likewise.
9104 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9105 behavior on 64-bit hosts with printf arg.
9106 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
9107 (x_stop_queuing_selection_requests): Likewise.
9108 (x_get_window_property): Don't truncate byte count to an 'int'
9111 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9112 here, since it parses constructs like leading '-' and spaces,
9113 which are not wanted; and it overflows with large numbers.
9114 Instead, simply match F[0-9]+, which is what is wanted anyway.
9116 * alloc.c: Remove unportable assumptions about struct layout.
9117 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9118 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9119 (allocate_vectorlike, make_pure_vector): Use the new macros,
9120 plus offsetof, to remove unportable assumptions about struct layout.
9121 These assumptions hold on all porting targets that I know of, but
9122 they are not guaranteed, they're easy to remove, and removing them
9123 makes further changes easier.
9125 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9126 This doesn't fix a bug but makes the code clearer.
9127 (string_overrun_cookie): Now const. Use initializers that
9128 don't formally overflow signed char, to avoid warnings.
9129 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9130 can cause Emacs to crash when string overrun checking is enabled.
9131 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9132 multiple of sizeof (EMACS_INT); it need not be, if
9133 alignof(EMACS_INT) < sizeof (EMACS_INT).
9134 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
9136 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
9138 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9140 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9142 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
9143 supposed to be handshaking. (Bug#8556)
9144 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9146 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
9148 * lisp.h (Qdebug): List symbol.
9149 * eval.c (Qdebug): Restore global linkage.
9150 * keyboard.c (debug-on-event): New variable.
9151 (handle_user_signal): Break into debugger when debug-on-event
9152 matches the current signal symbol.
9154 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9156 * alloc.c (check_sblock, check_string_bytes)
9157 (check_string_free_list): Convert to standard C.
9159 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9161 * w32.c (emacs_gnutls_push): Fix typo.
9163 2011-04-25 Eli Zaretskii <eliz@gnu.org>
9165 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9166 "cast to pointer from integer of different size".
9168 Improve doprnt and its use in verror. (Bug#8545)
9169 * doprnt.c (doprnt): Document the set of format control sequences
9170 supported by the function. Use SAFE_ALLOCA instead of always
9173 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9174 is one byte too soon. Don't use xrealloc; instead xfree and
9177 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9179 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9182 * gnutls.c: Renamed global_initialized to
9183 gnutls_global_initialized. Added internals for the
9184 :verify-hostname-error, :verify-error, and :verify-flags
9185 parameters of `gnutls-boot' and documented those parameters in the
9186 docstring. Start callback support.
9187 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9188 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9189 on error. Return error code.
9190 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9191 (emacs_gnutls_read): Likewise.
9192 (Fgnutls_boot): Return handshake error code.
9193 (emacs_gnutls_handle_error): New function.
9194 (wsaerror_to_errno): Likewise.
9196 * w32.h (emacs_gnutls_pull): Add prototype.
9197 (emacs_gnutls_push): Likewise.
9199 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9200 (emacs_gnutls_push): Likewise.
9202 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9204 * process.c (wait_reading_process_output): Check if GnuTLS
9205 buffered some data internally if no FDs are set for TLS
9208 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9209 (LIBS): Link to USER_LIBS.
9210 ($(BLD)/gnutls.$(0)): New target.
9212 2011-04-24 Eli Zaretskii <eliz@gnu.org>
9214 * xdisp.c (handle_single_display_spec): Rename the
9215 display_replaced_before_p argument into display_replaced_p, to
9216 make it consistent with the commentary. Fix typos in the
9219 * textprop.c (syms_of_textprop): Remove dead code.
9220 (copy_text_properties): Delete obsolete commentary about an
9221 interface that was deleted long ago. Fix typos in the description
9224 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9225 to changes in oldXMenu/XMenu.h from 2011-04-16.
9226 <menu_help_message, prev_menu_help_message>: Constify.
9227 (IT_menu_make_room): menu->help_text is now `const char **';
9230 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9231 to changes in oldXMenu/XMenu.h from 2011-04-16.
9232 (struct XMenu): Declare `help_text' `const char **'.
9234 * xfaces.c <Qunspecified>: Make extern again.
9236 * syntax.c: Include sys/types.h before including regex.h, as
9239 * doc.c (get_doc_string): Improve the format passed to `error'.
9241 * doprnt.c (doprnt): Improve commentary.
9243 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9245 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9248 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9249 changes in globals.h immediately force recompilation.
9250 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9251 $(CURDIR)/s/ms-w32.h.
9252 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
9254 * character.c (Fchar_direction): Function deleted.
9255 (syms_of_character): Don't defsubr it.
9256 <char-direction-table>: Deleted.
9258 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9260 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9261 * doprnt.c: Include limits.h.
9262 (SIZE_MAX): New macro.
9263 (doprnt): Return a size_t value. 2nd arg is now size_t.
9264 Many local variables are now size_t instead of int or unsigned.
9265 Improve overflow protection. Support `l' modifier for integer
9266 conversions. Support %l conversion. Don't assume an EMACS_INT
9267 argument for integer conversions and for %c.
9269 * lisp.h (doprnt): Restore prototype.
9271 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9274 * Makefile.in (base_obj): Add back doprnt.o.
9276 * deps.mk (doprnt.o): Add back prerequisites.
9277 (callint.o): Depend on character.h.
9279 * eval.c (internal_lisp_condition_case): Include the handler
9280 representation in the error message.
9281 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9282 when breaking from the loop.
9284 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9286 * callint.c (Fcall_interactively): When displaying error message
9287 about invalid control letter, pass the character's codepoint, not
9288 a pointer to its multibyte form. Improve display of the character
9289 in octal and display also its hex code.
9291 * character.c (char_string): Use %x to display the (unsigned)
9292 codepoint of an invalid character, to avoid displaying a bogus
9295 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9296 `error', not SYMBOL_NAME itself.
9298 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9299 character arguments to `error'.
9301 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9302 to `error' in error message about FINAL_CHAR argument. Make sure
9303 FINAL_CHAR is a character, and use %c when it is passed as
9304 argument to `error'.
9306 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9308 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9310 * w32.c: Include <time.h>.
9311 (sys_localtime): New function.
9313 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
9315 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9317 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
9319 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
9321 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9324 2011-04-19 Eli Zaretskii <eliz@gnu.org>
9326 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9327 gl_state.e_property when gl_state.object is Qt.
9329 * insdel.c (make_gap_larger): Remove limitation of buffer size
9332 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
9334 * xdisp.c (lookup_glyphless_char_display)
9335 (produce_glyphless_glyph): Handle cons cell entry in
9336 glyphless-char-display.
9337 (Vglyphless_char_display): Document it.
9339 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9340 glyphless-char-display.
9342 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
9344 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9346 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9348 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9349 definition for no-X builds.
9351 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
9353 Static checks with GCC 4.6.0 and non-default toolkits.
9355 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9357 * process.c (keyboard_bit_set): Define only if SIGIO.
9358 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9359 (send_process): Repair possible setjmp clobbering.
9361 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9363 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9365 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9367 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9368 Define only if needed.
9370 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9371 by pacifying GCC about it. Maybe it's time to retire it?
9372 * xfaces.c (USG, __TIMEVAL__): Likewise.
9374 * dispextern.h (struct redisplay_interface): Rename param
9376 * termhooks.h (struct terminal): Likewise.
9377 * xterm.c (xembed_send_message): Likewise.
9379 * insdel.c (make_gap_smaller): Define only if
9380 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9382 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9385 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9386 so that we aren't warned about unused symbols.
9388 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9390 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
9392 * xfns.c (x_real_positions): Mark locals as initialized.
9394 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9396 * xterm.c: Fix problems found by static analysis with other toolkits.
9397 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
9398 (x_dispatch_event): Declare static if USE_GTK, and
9399 define if USE_GTK || USE_X_TOOLKIT.
9400 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
9401 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
9402 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9403 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
9405 * xmenu.c (menu_help_callback): Pointer type fixes.
9406 Use const pointers when pointing at readonly data. Avoid pointer
9408 (FALSE): Remove unused macro.
9409 (update_frame_menubar): Remove unused decl.
9411 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9413 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9414 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9415 (single_menu_item): Rename local to avoid shadowing.
9417 * keyboard.c (make_lispy_event): Remove unused local var.
9419 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9420 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9422 * bitmaps: Change bitmaps from unsigned char back to the X11
9423 compatible char. Avoid the old compiler warnings about
9424 out-of-range initializers by using, for example, '\xab' rather
9427 * xgselect.c (xgselect_initialize): Check vs interface
9428 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9430 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9432 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9433 to read-only memory.
9435 * fns.c (vector): Remove; this old hack is no longer needed.
9437 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
9439 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
9441 * xrdb.c (x_load_resources): Omit unused local.
9443 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
9444 (x_window): Rename locals to avoid shadowing.
9445 (USG): Use the kludged USG macro, to pacify gcc.
9447 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
9448 (x_term_init): Remove local to avoid shadowing.
9450 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
9452 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9453 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9455 2011-04-16 Eli Zaretskii <eliz@gnu.org>
9457 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9459 Fix regex.c, syntax.c and friends for buffers > 2GB.
9460 * syntax.h (struct gl_state_s): Declare character position members
9463 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9465 * textprop.c (verify_interval_modification, interval_of):
9466 Declare arguments EMACS_INT.
9468 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9471 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9473 * indent.c (Fvertical_motion): Local variable it_start is now
9476 * regex.c (re_match, re_match_2, re_match_2_internal)
9477 (bcmp_translate, regcomp, regexec, print_double_string)
9478 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9479 (re_compile_pattern, re_exec): Declare arguments and local
9480 variables `size_t' and `ssize_t' and return values `regoff_t', as
9482 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9483 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9484 <compile_stack_type>: `size' and `avail' are now `size_t'.
9486 * regex.h <regoff_t>: Use ssize_t, not int.
9487 (re_search, re_search_2, re_match, re_match_2): Arguments that
9488 specify buffer/string position and length are now ssize_t and
9489 size_t. Return type is regoff_t.
9491 2011-04-16 Ben Key <bkey76@gmail.com>
9493 * nsfont.m: Fixed bugs in ns_get_family and
9494 ns_descriptor_to_entity that were caused by using free to
9495 deallocate memory blocks that were allocated by xmalloc (via
9496 xstrdup). This caused Emacs to crash when compiled with
9497 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9498 --enable-checking=xmallocoverrun). xfree is now used to
9499 deallocate these memory blocks.
9501 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
9503 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9505 emacs_write: Accept and return EMACS_INT for sizes.
9506 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9508 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9509 Accept and return EMACS_INT.
9510 (emacs_gnutls_write): Return the number of bytes written on
9512 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
9513 (emacs_read, emacs_write): Remove check for negative size, as the
9514 Emacs source code has been audited now.
9515 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9516 (emacs_read, emacs_write): Use it.
9517 * process.c (send_process): Adjust to the new signatures of
9518 emacs_write and emacs_gnutls_write. Do not attempt to store
9519 a byte offset into an 'int'; it might overflow.
9520 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
9522 * sound.c: Don't assume sizes fit in 'int'.
9523 (struct sound_device.period_size, alsa_period_size):
9524 Return EMACS_INT, not int.
9525 (struct sound_device.write, vox_write, alsa_write):
9526 Accept EMACS_INT, not int.
9527 (wav_play, au_play): Use EMACS_INT to store sizes and to
9528 record read return values.
9530 2011-04-15 Ben Key <bkey76@gmail.com>
9532 * keyboard.c (Qundefined): Don't declare static since it is used
9534 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9535 static since they are used in nsfont.m.
9537 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9539 * process.c (Qprocessp): Don't declare static.
9540 * lisp.h (Qprocessp): Declare again.
9542 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
9544 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9546 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9548 Improve C-level modularity by making more things 'static'.
9550 Don't publish debugger-only interfaces to other modules.
9551 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9552 (verify_bytepos, count_markers): Move decls to the only modules
9554 * region-cache.h (pp_cache): Likewise.
9555 * window.h (check_all_windows): Likewise.
9556 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9558 * sysdep.c (croak): Now static, if
9559 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9560 * syssignal.h (croak): Declare only if not static.
9562 * alloc.c (refill_memory_reserve): Now static if
9563 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9564 * lisp.h (refill_memory_reserve): Declare only if not static.
9566 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9567 Define only if USE_LUCID.
9569 * xrdb.c (x_customization_string, x_rm_string): Now static.
9571 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9572 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9574 * xdisp.c (draw_row_with_mouse_face): Now static.
9575 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9577 * window.h (check_all_windows): Mark externally visible.
9579 * window.c (window_deletion_count): Now static.
9581 * undo.c: Make symbols static if they're not exported.
9582 (last_undo_buffer, last_boundary_position, pending_boundary):
9585 * textprop.c (interval_insert_behind_hooks): Now static.
9586 (interval_insert_in_front_hooks): Likewise.
9588 * term.c: Make symbols static if they're not exported.
9589 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9590 (max_frame_lines, tty_set_terminal_modes):
9591 (tty_reset_terminal_modes, tty_turn_off_highlight):
9592 (get_tty_terminal): Now static.
9593 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9594 * termhooks.h (term_mouse_moveto): Do not declare if
9596 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9597 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9599 * sysdep.c: Make symbols static if they're not exported.
9600 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9602 (sigprocmask_set, full_mask): Remove; unused.
9603 (wait_debugging): Mark as visible.
9604 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9605 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9607 * syntax.c (syntax_temp): Define only if !__GNUC__.
9609 * sound.c (current_sound_device, current_sound): Now static.
9611 * search.c (searchbufs, searchbuf_head): Now static.
9613 * scroll.c (scroll_cost): Remove; unused.
9614 * dispextern.h (scroll_cost): Remove decl.
9616 * region-cache.h (pp_cache): Mark as externally visible.
9618 * process.c: Make symbols static if they're not exported.
9619 (process_tick, update_tick, create_process, chan_process):
9620 (Vprocess_alist, proc_buffered_char, datagram_access):
9621 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9622 (deactivate_process): Mark defn as static, as well as decl.
9623 * lisp.h (create_process): Remove decl.
9624 * process.h (chan_process, Vprocess_alist): Remove decls.
9626 * print.c: Make symbols static if they're not exported.
9627 (print_depth, new_backquote_output, being_printed, print_buffer):
9628 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9629 (print_interval, print_number_index, initial_stderr_stream):
9631 * lisp.h (Fprinc): Remove decl.
9632 (debug_output_compilation_hack): Mark as externally visible.
9634 * sysdep.c (croak): Move decl from here to syssignal.h.
9635 * syssignal.h (croak): Put it here, so the API can be checked when
9636 'croak' is called from dissociate_if_controlling_tty.
9638 * minibuf.c: Make symbols static if they're not exported.
9639 (minibuf_save_list, choose_minibuf_frame): Now static.
9640 * lisp.h (choose_minibuf_frame): Remove decl.
9642 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9644 * lread.c: Make symbols static if they're not exported.
9645 (read_objects, initial_obarray, oblookup_last_bucket_number):
9647 (make_symbol): Remove; unused.
9648 * lisp.h (initial_obarray, make_symbol): Remove decls.
9650 * keyboard.c: Make symbols static if they're not exported.
9651 (single_kboard, recent_keys_index, total_keys, recent_keys):
9652 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9653 (this_single_command_key_start, echoing, last_auto_save):
9654 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9655 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9656 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9657 (Vlispy_mouse_stem, double_click_count):
9659 (force_auto_save_soon): Define only if SIGDANGER.
9660 (ignore_mouse_drag_p): Now static if
9661 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9662 (print_help): Remove; unused.
9663 (stop_character, last_timer_event): Mark as externally visible.
9664 * keyboard.h (ignore_mouse_drag_p): Declare only if
9665 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9666 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9667 * lisp.h (echoing): Remove decl.
9668 (force_auto_save_soon): Declare only if SIGDANGER.
9669 * xdisp.c (redisplay_window): Simplify code, to make it more
9670 obvious that ignore_mouse_drag_p is not accessed if !defined
9671 USE_GTK && !defined HAVE_NS.
9673 * intervals.c: Make symbols static if they're not exported.
9674 (merge_properties_sticky, merge_interval_right, delete_interval):
9676 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9678 * insdel.c: Make symbols static if they're not exported.
9679 However, leave prepare_to_modify_buffer alone. It's never
9680 called from outside this function, but that appears to be a bug.
9681 (combine_after_change_list, combine_after_change_buffer):
9682 (adjust_after_replace, signal_before_change): Now static.
9683 (adjust_after_replace_noundo): Remove; unused.
9684 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
9685 (signal_before_change): Remove decls.
9687 * indent.c (val_compute_motion, val_vmotion): Now static.
9689 * image.c: Make symbols static if they're not exported.
9690 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9692 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9693 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9695 * fringe.c (standard_bitmaps): Now static.
9696 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9698 * frame.c: Make symbols static if they're not exported.
9699 (x_report_frame_params, make_terminal_frame): Now static.
9700 (get_frame_param): Now static, unless HAVE_NS.
9701 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9702 (x_get_resource_string): Remove; not used.
9703 * frame.h (make_terminal_frame, x_report_frame_params):
9704 (x_get_resource_string); Remove decls.
9705 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9706 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9708 * font.c, fontset.c: Make symbols static if they're not exported.
9709 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9710 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9711 * font.c (font_close_object): Now static.
9712 * font.h (font_close_object): Remove.
9713 * fontset.c (FONTSET_OBJLIST): Remove.
9714 (free_realized_fontset) #if-0 the body, which does nothing.
9715 (face_suitable_for_char_p): #if-0, as it's never called.
9716 * fontset.h (face_suitable_for_char_p): Remove decl.
9717 * xfaces.c (face_at_string_position):
9718 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
9719 since 0 is always ASCII.
9721 * fns.c (weak_hash_tables): Now static.
9723 * fileio.c: Make symbols static if they're not exported.
9724 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9725 (Vwrite_region_annotation_buffers): Now static.
9727 * eval.c: Make symbols static if they're not exported.
9728 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9729 * lisp.h (backtrace_list): Remove decl.
9731 * emacs.c: Make symbols static if they're not exported.
9732 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9733 (fatal_error_code, fatal_error_signal_hook, standard_args):
9735 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9736 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9737 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9738 * lisp.h (fatal_error_signal_hook): Remove decl.
9739 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9741 * editfns.c: Move a (normally-unused) function to its only use.
9742 * editfns.c, lisp.h (get_operating_system_release): Remove.
9743 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9744 worth the hassle of breaking this out.
9746 * xterm.c: Make symbols static if they're not exported.
9747 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9748 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9749 (x_destroy_window, x_delete_display):
9751 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9752 (x_mouse_leave): Remove; unused.
9753 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9754 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9755 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9757 (x_mouse_leave): Declare only if WINDOWSNT.
9758 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9759 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9762 * ftxfont.c: Make symbols static if they're not exported.
9763 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9765 * font.h (ftxfont_driver): Likewise.
9767 * xfns.c: Make symbols static if they're not exported.
9768 (x_last_font_name, x_display_info_for_name):
9769 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9770 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9771 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9772 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9773 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9774 (last_show_tip_args): Now static.
9775 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9776 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9777 (x_screen_planes): Remove; unused.
9778 * dispextern.h (x_screen_planes): Remove decl.
9780 * dispnew.c: Make symbols static if they're not exported.
9781 * dispextern.h (redraw_garbaged_frames, scrolling):
9782 (increment_row_positions): Remove.
9783 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9784 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9786 (redraw_garbaged_frames): Remove; unused.
9788 * xfaces.c: Make symbols static if they're not exported.
9789 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9791 * xterm.h (defined_color): Remove decls.
9792 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9793 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9794 (menu_face_changed_default, defined_color, free_realized_face):
9795 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9796 (ascii_face_of_lisp_face): Remove; unused.
9798 * xdisp.c: Make symbols static if they're not exported.
9799 * dispextern.h (scratch_glyph_row, window_box_edges):
9800 (glyph_to_pixel_coords, set_cursor_from_row):
9801 (get_next_display_element, set_iterator_to_next):
9802 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9803 (show_mouse_face): Remove decls
9804 * frame.h (message_buf_print): Likewise.
9805 * lisp.h (pop_message, set_message, check_point_in_composition):
9807 * xterm.h (set_vertical_scroll_bar): Likewise.
9808 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9809 (message_buf_print, scratch_glyph_row, displayed_buffer):
9810 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9811 (get_next_display_element, show_mouse_face, window_box_edges):
9812 (frame_to_window_pixel_xy, check_point_in_composition):
9813 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9814 (glyph_to_pixel_coords): Remove; unused.
9816 * dired.c (file_name_completion): Now static.
9818 * dbusbind.c (xd_in_read_queued_messages): Now static.
9820 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9821 * data.c (circular_list_error): Remove.
9823 * commands.h (last_point_position, last_point_position_buffer):
9824 (last_point_position_window): Remove decls.
9825 * keyboard.c: Make these variables static.
9827 * coding.h (coding, code_convert_region, encode_coding_gap):
9829 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9830 (iso_code_class, detect_coding, code_convert_region): Now static.
9831 (encode_coding_gap): Remove; unused.
9833 * chartab.c (chartab_chars, chartab_bits): Now static.
9835 * charset.h (charset_iso_8859_1): Remove decl.
9836 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9839 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9840 * ccl.c (Vccl_program_table): Now static.
9841 (check_ccl_update): Remove; unused.
9843 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9844 * category.h: ... from here.
9845 * category.c (check_category_table, set_category_set): Now static.
9847 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9848 * lisp.h: Remove these decls.
9850 * buffer.c (buffer_count): Remove unused var.
9852 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9853 so that it's not optimized away.
9854 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9855 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9856 exported only to the debugger.
9858 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
9859 * atimer.h (run_all_atimers): Remove; not exported.
9861 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9862 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9863 was inaccessible from Lisp.
9864 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9865 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9867 alloc.c: Import and export fewer symbols, and remove unused items.
9868 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9870 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9871 it's not optimized away by whole-program optimization.
9872 (message_enable_multibyte, free_misc): Remove.
9873 (catchlist, handlerlist, mark_backtrace):
9874 Declare only if BYTE_MARK_STACK.
9875 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9876 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9877 (message_enable_multibyte): Remove decl.
9878 (free_misc, interval_free_list, float_block, float_block_index):
9879 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9880 (cons_free_list, last_marked_index):
9882 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9883 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9884 (mark_backtrace): Define only if BYTE_MARK_STACK.
9885 * xdisp.c (message_enable_multibyte): Now static.
9887 Declare Lisp_Object Q* variables to be 'static' if not exported.
9888 This makes it easier for human readers (and static analyzers)
9889 to see whether these variables are used from other modules.
9890 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9891 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9892 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9893 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9894 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9895 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9896 * xmenu.c, xselect.c:
9897 Declare Q* vars static if they are not used in other modules.
9898 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9899 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9900 Remove decls of unexported vars.
9901 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9903 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9905 Make Emacs functions such as Fatom 'static' by default.
9906 This makes it easier for human readers (and static analyzers)
9907 to see whether these functions can be called from other modules.
9908 DEFUN now defines a static function. To make the function external
9909 so that it can be used in other C modules, use the new macro DEFUE.
9910 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9911 (Finit_image_library):
9912 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9913 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9914 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9915 Remove decls, since these functions are now static.
9916 (Funintern, Fget_internal_run_time): New decls, since these functions
9917 were already external.
9919 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9920 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9921 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9922 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9923 * keyboard.c, keymap.c, lread.c:
9924 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9925 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9926 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9927 Mark functions with DEFUE instead of DEFUN,
9928 if they are used in other modules.
9929 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9930 decls for now-static functions.
9931 * buffer.h (Fdelete_overlay): Remove decl.
9932 * callproc.c (Fgetenv_internal): Mark as internal.
9933 * composite.c (Fremove_list_of_text_properties): Remove decl.
9934 (Fcomposition_get_gstring): New forward static decl.
9935 * composite.h (Fcomposite_get_gstring): Remove decl.
9936 * dired.c (Ffile_attributes): New forward static decl.
9937 * doc.c (Fdocumntation_property): New forward static decl.
9938 * eval.c (Ffetch_bytecode): New forward static decl.
9939 (Funintern): Remove extern decl; now in .h file where it belongs.
9940 * fileio.c (Fmake_symbolic_link): New forward static decl.
9941 * image.c (Finit_image_library): New forward static decl.
9942 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9943 * intervals.h (Fprevious_property_change):
9944 (Fremove_list_of_text_properties): Remove decls.
9945 * keyboard.c (Fthis_command_keys): Remove decl.
9946 (Fcommand_execute): New forward static decl.
9947 * keymap.c (Flookup_key): New forward static decl.
9948 (Fcopy_keymap): Now static.
9949 * keymap.h (Flookup_key): Remove decl.
9950 * process.c (Fget_process): New forward static decl.
9951 (Fprocess_datagram_address): Mark as internal.
9952 * syntax.c (Fsyntax_table_p): New forward static decl.
9953 (skip_chars): Remove duplicate decl.
9954 * textprop.c (Fprevious_property_change): New forward static decl.
9955 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9957 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9958 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9960 * editfns.c (Fformat): Remove unreachable code.
9962 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9964 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9967 2011-04-13 Eli Zaretskii <eliz@gnu.org>
9969 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9970 when at ZV. (Bug#8487)
9972 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9974 * charset.c (Fclear_charset_maps): Use xfree instead of free.
9976 * keyboard.c (parse_tool_bar_item): Likewise.
9977 * sound.c (sound_cleanup, alsa_close): Likewise.
9978 * termcap.c (tgetent): Likewise.
9979 * xfns.c (x_default_font_parameter): Likewise.
9980 * xsettings.c (read_and_apply_settings): Likewise.
9982 * alloc.c (overrun_check_malloc, overrun_check_realloc)
9983 (overrun_check_free): Protoize.
9985 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
9987 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
9988 since callers should never pass a negative size.
9989 Change the signature to match that of plain 'read' and 'write'; see
9990 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9991 * lisp.h: Update prototypes of emacs_write and emacs_read.
9993 2011-04-11 Eli Zaretskii <eliz@gnu.org>
9995 * xdisp.c (redisplay_window): Don't try to determine the character
9996 position of the scroll margin if the window start point w->startp
9997 is outside the buffer's accessible region. (Bug#8468)
9999 2011-04-10 Eli Zaretskii <eliz@gnu.org>
10001 Fix write-region and its subroutines for buffers > 2GB.
10002 * fileio.c (a_write, e_write): Modify declaration of arguments and
10003 local variables to support buffers larger than 2GB.
10004 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10006 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10007 argument, local variables, and return value.
10009 * lisp.h: Update prototypes of emacs_write and emacs_read.
10011 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10013 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
10015 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10017 Fix more problems found by GCC 4.6.0's static checks.
10019 * xdisp.c (vmessage): Use a better test for character truncation.
10021 * charset.c (load_charset_map): <, not <=, for optimization,
10022 and to avoid potential problems with integer overflow.
10023 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
10024 * casetab.c (set_identity, shuffle): Likewise.
10025 * editfns.c (Fformat): Likewise.
10026 * syntax.c (skip_chars): Likewise.
10028 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10029 This also lets GCC 4.6.0 generate slightly better loop code.
10031 * callint.c (Fcall_interactively): <, not <=, for optimization.
10032 (Fcall_interactively): Count the number of arguments produced,
10033 not the number of arguments given. This is simpler and lets GCC
10034 4.6.0 generate slightly better code.
10036 * ftfont.c: Distingish more carefully between FcChar8 and char.
10037 The previous code passed unsigned char * to a functions like
10038 strlen and xstrcasecmp that expect char *, which does not
10039 conform to the C standard.
10040 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10041 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10042 char * when the C standard requires it.
10044 * keyboard.c (read_char): Remove unused var.
10046 * eval.c: Port to Windows vsnprintf (Bug#8435).
10047 Include <limits.h>.
10048 (SIZE_MAX): Define if the headers do not.
10049 (verror): Do not give up if vsnprintf returns a negative count.
10050 Instead, grow the buffer. This ports to Windows vsnprintf, which
10051 does not conform to C99. Problem reported by Eli Zaretskii.
10052 Also, simplify the allocation scheme, by avoiding the need for
10053 calling realloc, and removing the ALLOCATED variable.
10055 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10057 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10058 But keep the doprint source code for now, as we might revamp it
10059 and use it again (Bug#8435).
10060 * lisp.h (doprnt): Remove.
10061 * Makefile.in (base_obj): Remove doprnt.o.
10062 * deps.mk (doprnt.o): Remove.
10064 error: Print 32- and 64-bit integers portably (Bug#8435).
10065 Without this change, on typical 64-bit hosts error ("...%d...", N)
10066 was used to print both 32- and 64-bit integers N, which relied on
10067 undefined behavior.
10068 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
10069 * lisp.h (error, verror): Mark as printf-like functions.
10070 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10071 Report overflow in size calculations when allocating printf buffer.
10072 Do not truncate output string at its first null byte.
10073 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10074 Truncate the output at a character boundary, since vsnprintf does not
10076 * charset.c (check_iso_charset_parameter): Convert internal
10077 character to string before calling 'error', since %c now has the
10079 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10080 overflow when computing char to be passed to 'error'. Do not
10081 pass Lisp_Object to 'error'; pass the integer instead.
10082 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10083 formatted with plain %d.
10085 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10087 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10089 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10091 * xterm.c (x_catch_errors): Remove duplicate declaration.
10093 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10095 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10097 2011-04-10 Jim Meyering <meyering@redhat.com>
10099 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10100 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10101 return ssize_t not "int", and use size_t as the buffer length.
10102 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10103 * gnutls.h: Update declarations.
10104 * process.c (read_process_output): Use ssize_t, to match.
10105 (send_process): Likewise.
10107 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10109 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10111 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10113 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10114 Use unsigned char, to match FcChar8 type definition.
10116 * xterm.c (handle_one_xevent):
10117 * xmenu.c (create_and_show_popup_menu):
10118 * xselect.c (x_decline_selection_request)
10119 (x_reply_selection_request): Avoid type-punned deref of X events.
10121 2011-04-09 Eli Zaretskii <eliz@gnu.org>
10123 Fix some uses of `int' instead of EMACS_INT.
10124 * search.c (string_match_1, fast_string_match)
10125 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10126 (scan_buffer, find_next_newline_no_quit)
10127 (find_before_next_newline, search_command, Freplace_match)
10128 (Fmatch_data): Make some `int' variables be EMACS_INT.
10130 * xdisp.c (display_count_lines): 3rd argument and return value now
10131 EMACS_INT. All callers changed.
10132 (pint2hrstr): Last argument is now EMACS_INT.
10134 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10135 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10136 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10137 (decode_coding_utf_16, decode_coding_emacs_mule)
10138 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10139 (decode_coding_ccl, decode_coding_charset)
10140 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10141 (decode_coding_iso_2022, decode_coding_emacs_mule)
10142 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10143 <char_offset, last_offset>: Declare EMACS_INT.
10144 (encode_coding_utf_8, encode_coding_utf_16)
10145 (encode_coding_emacs_mule, encode_invocation_designation)
10146 (encode_designation_at_bol, encode_coding_iso_2022)
10147 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10148 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10150 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10151 (encode_invocation_designation): Last argument P_NCHARS is now
10153 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10154 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10156 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10159 * ccl.c (Fccl_execute_on_string): Declare some variables
10162 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
10164 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10166 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10168 * process.c (Fformat_network_address): Doc fix.
10170 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10172 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
10174 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
10176 * keyboard.c (read_char): Call Lisp function help-form-show,
10177 instead of using internal_with_output_to_temp_buffer.
10178 (Qhelp_form_show): New var.
10179 (syms_of_keyboard): Use DEFSYM macro.
10181 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10183 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10185 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
10187 * process.c (Flist_processes): Remove to Lisp.
10188 (list_processes_1): Delete.
10190 2011-04-06 Eli Zaretskii <eliz@gnu.org>
10192 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10194 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10196 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
10198 Fix more problems found by GCC 4.6.0's static checks.
10200 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10202 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10204 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
10206 * xdisp.c (vmessage): Mark as a printf-like function.
10208 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10210 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10212 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10213 printf-like functions.
10214 (tiff_load): Add casts to remove these marks before passing them
10215 to system-supplied API.
10217 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10219 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10220 This avoids several warnings with gcc -Wstrict-overflow.
10221 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10222 directly, rather than having caller test rule sign. This avoids
10223 some unnecessary tests.
10224 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10225 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10226 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
10228 * xfont.c (xfont_text_extents): Remove var that was set but not used.
10229 (xfont_open): Avoid unnecessary tests.
10231 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10233 * composite.h, composite.c (composition_gstring_put_cache):
10234 Use EMACS_INT, not int, for length.
10236 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10237 breaking out part of COMPOSITION_DECODE_RULE.
10238 (COMPOSITION_DECODE_RULE): Use it.
10239 * composite.c (get_composition_id): Remove unused local vars,
10240 by using the new macro.
10242 * textprop.c (set_text_properties_1): Change while to do-while,
10243 since the condition is always true at first.
10245 * intervals.c (graft_intervals_into_buffer): Mark var as used.
10246 (interval_deletion_adjustment): Return unsigned value.
10249 * process.c (list_processes_1, create_pty, read_process_output):
10250 (exec_sentinel): Remove vars that were set but not used.
10251 (create_pty): Remove unnecessary "volatile"s.
10252 (Fnetwork_interface_info): Avoid possibility of int overflow.
10253 (read_process_output): Do adaptive read buffering even if carryover.
10254 (read_process_output): Simplify nbytes computation if buffered.
10256 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10258 * syntax.c (scan_words): Remove var that was set but not used.
10259 (update_syntax_table): Use unsigned instead of int.
10261 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
10262 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
10263 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
10265 * print.c (print_error_message): Avoid int overflow.
10267 * font.c (font_list_entities): Redo for clarity,
10268 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10270 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
10271 (font_score): Avoid potential overflow in diff calculation.
10273 * fns.c (substring_both): Remove var that is set but not used.
10274 (sxhash): Redo loop for clarity and to avoid wraparound warning.
10276 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10278 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10279 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10280 can always succeed if overflow has undefined behavior.
10282 * search.c (boyer_moore, wordify): Remove vars set but not used.
10283 (wordify): Omit three unnecessary tests.
10285 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10286 All callers changed. This avoids the need for an unused var.
10288 * casefiddle.c (casify_region): Remove var that is set but not used.
10290 * dired.c (file_name_completion): Remove var that is set but not used.
10292 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10294 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
10295 (Finsert_file_contents): Remove unnecessary code checking fd.
10297 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10298 Check for integer overflow on size calculations.
10300 * buffer.c (Fprevious_overlay_change): Remove var that is set
10303 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10304 Remove vars that are set but not used.
10305 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
10306 (timer_check_2): Mark vars as initialized.
10308 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10310 * image.c (lookup_image): Remove var that is set but not used.
10311 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
10313 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10314 that are set but not used.
10316 * xfns.c (make_invisible_cursor): Don't return garbage
10317 if XCreateBitmapFromData fails (Bug#8410).
10319 * xselect.c (x_get_local_selection, x_handle_property_notify):
10320 Remove vars that are set but not used.
10322 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
10323 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
10325 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10326 Remove var that is set but not used.
10327 (scroll_bar_windows_size): Now size_t, not int.
10328 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10329 Check for overflow.
10331 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10332 (map_tty_color) [!defined MSDOS]: Likewise.
10334 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10336 * coding.c: Remove vars that are set but not used.
10337 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10338 All callers changed.
10339 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10340 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10341 (decode_coding_charset): Remove vars that are set but not used.
10343 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10344 that is set but not used.
10346 * print.c (print_object): Remove var that is set but not used.
10348 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
10349 The gnulib version avoids calling malloc in the usual case,
10350 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10351 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10352 * filelock.c (current_lock_owner): Likewise.
10353 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10354 * sysdep.c: Include allocator.h, careadlinkat.h.
10355 (emacs_no_realloc_allocator): New static constant.
10356 (emacs_readlink): New function.
10357 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10358 ../lib/careadlinkat.h.
10360 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10362 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10363 first non-nil return value).
10365 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10367 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10368 if not defined (Bug#8403).
10370 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10372 * xdisp.c (display_count_lines): Remove parameter `start',
10373 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10374 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10375 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10376 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10377 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10378 and thereabouts. All callers changed.
10379 (get_per_char_metric): Remove parameter `f', unused since
10380 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10382 2011-04-02 Jim Meyering <meyering@redhat.com>
10384 do not dereference NULL upon failed strdup
10385 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10386 (ns_get_family): Likewise.
10388 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10390 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10392 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10394 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10397 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10399 Add lexical binding.
10401 * window.c (Ftemp_output_buffer_show): New fun.
10402 (Fsave_window_excursion):
10403 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10405 * lread.c (lisp_file_lexically_bound_p): New function.
10406 (Fload): Bind Qlexical_binding.
10407 (readevalloop): Remove `evalfun' arg.
10408 Bind Qinternal_interpreter_environment.
10409 (Feval_buffer): Bind Qlexical_binding.
10410 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10412 (syms_of_lread): Declare `lexical-binding'.
10414 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10416 * keyboard.c (eval_dyn): New fun.
10417 (menu_item_eval_property): Use it.
10419 * image.c (parse_image_spec): Use Ffunctionp.
10421 * fns.c (concat, mapcar1): Accept byte-code-functions.
10423 * eval.c (Fsetq): Handle lexical vars.
10424 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10425 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10426 (FletX, Flet): Obey lexical binding.
10427 (Fcommandp): Handle closures.
10428 (Feval): New `lexical' arg.
10429 (eval_sub): New function extracted from Feval. Use it almost
10430 everywhere where Feval was used. Look up vars in lexical env.
10432 (Ffunctionp): Move from subr.el.
10433 (Ffuncall): Handle closures.
10434 (apply_lambda): Remove `eval_flags'.
10435 (funcall_lambda): Handle closures and new byte-code-functions.
10436 (Fspecial_variable_p): New function.
10437 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10438 but without exporting it to Lisp.
10440 * doc.c (Fdocumentation, store_function_docstring):
10441 * data.c (Finteractive_form): Handle closures.
10443 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10446 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10448 (exec_byte_code): New function extracted from Fbyte_code to handle new
10449 calling convention for byte-code-functions. Add new byte-codes.
10451 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
10453 * alloc.c (Fmake_symbol): Init new `declared_special' field.
10455 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10457 * xdisp.c (redisplay_internal): Fix prototype.
10459 2011-03-31 Eli Zaretskii <eliz@gnu.org>
10461 * xdisp.c (SCROLL_LIMIT): New macro.
10462 (try_scrolling): Use it when setting scroll_limit.
10463 Limit scrolling to 100 screen lines.
10464 (redisplay_window): Even when falling back on "recentering",
10465 position point in the window according to scroll-conservatively,
10466 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10468 (try_scrolling): When point is above the window, allow searching
10469 as far as scroll_max, or one screenful, to compute vertical
10470 distance from PT to the scroll margin position. This prevents
10471 try_scrolling from unnecessarily failing when
10472 scroll-conservatively is set to a value slightly larger than the
10473 window height. Clean up the case of PT below the margin at bottom
10474 of window: scroll_max can no longer be INT_MAX. When aggressive
10475 scrolling is in use, don't let point enter the opposite scroll
10476 margin as result of the scroll.
10477 (syms_of_xdisp) <scroll-conservatively>: Document the
10478 threshold of 100 lines for never-recentering scrolling.
10480 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10482 * dispextern.h (move_it_by_lines):
10483 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10484 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10485 (message_log_check_duplicate): Remove parameters `prev_bol' and
10486 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10487 (redisplay_internal): Remove parameter `preserve_echo_area',
10488 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10490 * indent.c (Fvertical_motion):
10491 * window.c (window_scroll_pixel_based, Frecenter):
10492 Don't pass `need_y_p' to `move_it_by_lines'.
10494 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10496 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10497 steal a few bits to be more compact.
10498 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10499 Remove unneeded casts.
10501 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10503 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10505 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10506 binding" message (bug#7967).
10508 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10510 Fix more problems found by GCC 4.6.0's static checks.
10512 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10513 Remove unused local var.
10515 * editfns.c (Fmessage_box): Remove unused local var.
10517 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10518 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10519 Omit unused local vars.
10520 * window.c (shrink_windows): Omit unused local var.
10521 * menu.c (digest_single_submenu): Omit unused local var.
10522 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10523 Omit unused local var.
10525 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10526 Don't assume string length fits in int.
10527 (keyremap_step, read_key_sequence): Use size_t for sizes.
10528 (read_key_sequence): Don't check last_real_key_start redundantly.
10530 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10531 instead of alloca (Bug#8344).
10533 * eval.c (Fbacktrace): Don't assume nargs fits in int.
10534 (Fbacktrace_frame): Don't assume nframes fits in int.
10536 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10538 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10541 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10543 * cm.c (calccost): Turn while-do into do-while, for clarity.
10545 * keyboard.c (syms_of_keyboard): Use the same style as later
10546 in this function when indexing through an array. This also
10547 works around GCC bug 48267.
10549 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10551 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10553 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10554 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10556 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10557 This avoids undefined behavior on integer overflow, and is a bit
10558 more convenient anyway since it is compared to a size_t variable.
10560 Variadic C functions now count arguments with size_t, not int.
10561 This avoids an unnecessary limitation on 64-bit machines, which
10562 caused (substring ...) to crash on large vectors (Bug#8344).
10563 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10564 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
10565 All variadic functions and their callers changed accordingly.
10566 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10567 * data.c (arith_driver, float_arith_driver): Likewise.
10568 * editfns.c (general_insert_function): Likewise.
10569 * eval.c (struct backtrace.nargs, interactive_p)
10570 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10571 (funcall_lambda, mark_backtrace): Likewise.
10572 * fns.c (concat): Likewise.
10573 * frame.c (x_set_frame_parameters): Likewise.
10574 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10575 0 if not found, not -1. All callers changed.
10577 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10578 (stack_copy_size): Now size_t, not int.
10579 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10581 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10583 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10584 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10585 All callers changed.
10587 * lisp.h (multibyte_char_to_unibyte):
10588 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10589 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10590 * character.h (CHAR_TO_BYTE8):
10591 * cmds.c (internal_self_insert):
10592 * editfns.c (general_insert_function):
10593 * keymap.c (push_key_description):
10594 * search.c (Freplace_match):
10595 * xdisp.c (message_dolog, set_message_1): All callers changed.
10597 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10599 * keyboard.c (safe_run_hook_funcall): New function.
10600 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10601 don't set the hook to nil, but remove the offending function instead.
10602 (Qcommand_hook_internal): Remove, unused.
10603 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10604 Vcommand_hook_internal.
10606 * eval.c (enum run_hooks_condition): Remove.
10607 (funcall_nil, funcall_not): New functions.
10608 (run_hook_with_args): Call each function through a `funcall' argument.
10609 Remove `cond' argument, now redundant.
10610 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10611 (Frun_hook_with_args_until_failure): Adjust accordingly.
10612 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10614 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10616 * dispextern.h (string_buffer_position): Remove declaration.
10618 * print.c (strout): Remove parameter `multibyte', unused since
10619 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10621 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10622 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10623 All callers changed.
10625 * w32.c (_wsa_errlist): Use braces for struct initializers.
10627 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10628 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10629 All callers changed.
10630 (string_buffer_position): Likewise. Also, make static (it's never
10631 used outside xdisp.c).
10632 (cursor_row_p): Remove parameter `w', unused since
10633 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10634 (decode_mode_spec): Remove parameter `precision', introduced during
10635 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10636 All callers changed.
10638 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10640 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10642 2011-03-27 Anders Lindgren <andlind@gmail.com>
10644 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10645 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10646 (ns_update_auto_hide_menu_bar): New functions.
10647 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10648 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10649 ns_constrain_all_frames.
10650 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10651 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10653 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10655 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10657 2011-03-27 Glenn Morris <rgm@gnu.org>
10659 * syssignal.h: Replace RETSIGTYPE with void.
10660 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10661 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10662 Replace SIGTYPE with void everywhere.
10663 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10664 * s/template.h (SIGTYPE): Remove commented out definition.
10666 2011-03-26 Eli Zaretskii <eliz@gnu.org>
10668 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10669 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10671 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
10673 * w32.c (read_unc_volume): Use parameter `henum', instead of
10674 global variable `wget_enum_handle'.
10676 * keymap.c (describe_vector): Remove parameters `indices' and
10677 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10678 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10680 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10682 * keyboard.c (timer_check): Remove parameter `do_it_now',
10683 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10684 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10685 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10687 * keyboard.c (read_char):
10688 * w32menu.c (w32_menu_display_help):
10689 * xmenu.c (show_help_event, menu_help_callback):
10690 Adjust calls to `show_help_echo'.
10692 * gtkutil.c (xg_maybe_add_timer):
10693 * keyboard.c (readable_events):
10694 * process.c (wait_reading_process_output):
10695 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10697 * insdel.c (adjust_markers_gap_motion):
10698 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10699 (gap_left, gap_right): Don't call it.
10701 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
10703 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10704 incurred during fontification.
10706 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10708 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10709 (DEFVAR_PER_BUFFER): Don't pass it.
10711 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10712 (scrolling_window): Don't pass it.
10714 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10716 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10718 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10720 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10721 of variables specific to SELinux and computation of `encoded_absname'.
10723 * image.c (XPutPixel): Remove unused variable `height'.
10725 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10727 * unexw32.c (get_section_info): Remove unused variable `section'.
10729 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10730 (system_process_attributes): Remove unused variable `sess'.
10731 (sys_read): Remove unused variable `err'.
10733 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10734 (w32_wnd_proc): Remove unused variable `isdead'.
10735 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10736 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10737 (x_create_tip_frame): Remove unused variable `tem'.
10739 * w32inevt.c (w32_console_read_socket):
10740 Remove unused variable `no_events'.
10742 * w32term.c (x_draw_composite_glyph_string_foreground):
10743 Remove unused variable `width'.
10745 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
10747 * w32term.c (x_set_glyph_string_clipping):
10748 Don't pass uninitialized region to CombineRgn.
10750 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
10752 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10753 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10754 (Fx_close_connection): Remove unused variable `i'.
10756 * w32font.c (w32font_draw): Return number of glyphs.
10757 (w32font_open_internal): Remove unused variable `i'.
10758 (w32font_driver): Add missing initializer.
10760 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10761 (fill_in_menu): Remove unused variable `items_added'.
10763 * w32term.c (last_mouse_press_frame): Remove static global variable.
10764 (w32_clip_to_row): Remove unused variable `f'.
10765 (x_delete_terminal): Remove unused variable `i'.
10767 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10768 (NOTHING): Remove unused static global variable.
10769 (uniscribe_check_otf): Remove unused variable `table'.
10770 (uniscribe_font_driver): Add missing initializers.
10772 2011-03-23 Julien Danjou <julien@danjou.info>
10774 * term.c (Fsuspend_tty, Fresume_tty):
10775 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10776 * window.c (temp_output_buffer_show):
10777 * insdel.c (signal_before_change):
10778 * frame.c (Fhandle_switch_frame):
10779 * fileio.c (Fdo_auto_save):
10780 * emacs.c (Fkill_emacs):
10781 * editfns.c (save_excursion_restore):
10782 * cmds.c (internal_self_insert):
10783 * callint.c (Fcall_interactively):
10784 * buffer.c (Fkill_all_local_variables):
10785 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10787 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
10788 unconditionally since it does the check itself.
10790 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
10792 Fix more problems found by GCC 4.5.2's static checks.
10794 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10795 the first time through the loop, since we know p0 < p1 then.
10796 This also avoids a gcc -Wstrict-overflow warning.
10798 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10799 leading to a memory leak, possible in functions like
10800 load_charset_map_from_file that can allocate an unbounded number
10801 of objects (Bug#8318).
10803 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10804 that could (at least in theory) be that large.
10806 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10807 This is less likely to overflow, and avoids undefined behavior if
10808 overflow does occur. All callers changed. Use strtoul to scan
10809 for the unsigned long integer.
10810 (pint2hrstr): Simplify and tune code slightly.
10811 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
10813 * scroll.c (do_scrolling): Work around GCC bug 48228.
10814 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10816 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10817 This also avoids a warning with gcc -Wstrict-overflow.
10818 (validate_x_resource_name): Simplify count usage.
10819 This also avoids a warning with gcc -Wstrict-overflow.
10821 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10824 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
10826 * process.c (Fmake_network_process): Use socklen_t, not int,
10827 where POSIX says socklen_t is required in portable programs.
10828 This fixes a porting bug on hosts like 64-bit HP-UX, where
10829 socklen_t is wider than int (Bug#8277).
10830 (Fmake_network_process, server_accept_connection):
10831 (wait_reading_process_output, read_process_output):
10834 * process.c: Rename or move locals to avoid shadowing.
10835 (list_processes_1, Fmake_network_process):
10836 (read_process_output_error_handler, exec_sentinel_error_handler):
10837 Rename or move locals.
10838 (Fmake_network_process): Define label "retry_connect" only if needed.
10839 (Fnetwork_interface_info): Fix pointer signedness.
10840 (process_send_signal): Add cast to avoid pointer signedness problem.
10841 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
10842 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
10844 Make tparam.h and terminfo.c consistent.
10845 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10846 Include tparam.h instead, since it declares them.
10847 * cm.h (PC): Remove extern decl; tparam.h now does this.
10848 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10849 * terminfo.c: Include tparam.h, to check interfaces.
10850 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10851 (tparam): Adjust signature to match interface in tparam.h;
10852 this removes some undefined behavior. Check that outstring and len
10853 are zero, which they always are with Emacs.
10854 * tparam.h (PC, BC, UP): New extern decls.
10856 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
10857 (xftfont_open): Rename locals to avoid shadowing.
10859 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
10860 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10861 (OTF_TAG_SYM): Omit macro if not needed.
10862 (ftfont_list): Remove unused local.
10863 (get_adstyle_property, ftfont_pattern_entity):
10864 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10865 Rename locals to avoid shadowing.
10867 * xfont.c (xfont_list_family): Mark var as initialized.
10869 * xml.c (make_dom): Now static.
10871 * composite.c (composition_compute_stop_pos): Rename local to
10873 (composition_reseat_it): Remove unused locals.
10874 (find_automatic_composition, composition_adjust_point): Likewise.
10875 (composition_update_it): Mark var as initialized.
10876 (find_automatic_composition): Mark vars as initialized,
10877 with a FIXME (Bug#8290).
10879 character.h: Rename locals to avoid shadowing.
10880 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10881 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10882 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10883 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10884 to avoid shadowing.
10886 * textprop.c (property_change_between_p): Remove; unused.
10888 * intervals.c (interval_start_pos): Now static.
10890 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10892 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10893 Rename locals to avoid shadowing.
10895 * sound.c (wav_play, au_play, Fplay_sound_internal):
10896 Fix pointer signedness.
10897 (alsa_choose_format): Remove unused local var.
10898 (wav_play): Initialize a variable to 0, to prevent undefined
10899 behavior (Bug#8278).
10901 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10903 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10905 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10906 clobbering (Bug#8298).
10907 * sysdep.c (sys_subshell): Likewise.
10908 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
10910 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10911 This should get cleaned up, so that child_setup has the
10912 same signature on all platforms.
10914 * callproc.c (call_process_cleanup): Now static.
10915 (relocate_fd): Rename locals to avoid shadowing.
10917 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
10919 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10920 not to be necessary, and produces flickering.
10922 2011-03-20 Glenn Morris <rgm@gnu.org>
10924 * config.in: Remove file.
10926 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
10928 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10929 are now in src/globals.h.
10930 (syms_of_minibuf): Remove spurious & from previous change.
10932 2011-03-20 Leo Liu <sdl.web@gmail.com>
10934 * minibuf.c (completing-read-function): New variable.
10935 (completing-read-default): Rename from completing-read.
10936 (completing-read): Call completing-read-function.
10938 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10940 * xfaces.c (Fx_load_color_file):
10941 Read color file from absolute filename (bug#8250).
10943 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10945 * makefile.w32-in: Update dependencies.
10947 2011-03-17 Eli Zaretskii <eliz@gnu.org>
10949 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10951 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10953 Fix more problems found by GCC 4.5.2's static checks.
10955 * process.c (make_serial_process_unwind, send_process_trap):
10956 (sigchld_handler): Now static.
10958 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10959 That way, the code declares only the vars that it needs.
10960 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10961 * s/cygwin.h (PTY_ITERATION): Likewise.
10962 * s/darwin.h (PTY_ITERATION): Likewise.
10963 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10965 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10966 * process.c (allocate_pty): Don't declare stb unless it's needed.
10968 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
10969 (CONSTANTLIM): Remove; unused.
10970 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10971 Define only if needed.
10973 * unexelf.c (unexec): Name an expression,
10974 to avoid gcc -Wbad-function-cast warning.
10975 Use a different way to cause a compilation error if anyone uses
10976 n rather than nn, a way that does not involve shadowing.
10977 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
10979 * deps.mk (unexalpha.o): Remove; unused.
10981 New file unexec.h, the (simple) interface for unexec (Bug#8267).
10982 * unexec.h: New file.
10983 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
10984 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
10985 Depend on unexec.h.
10986 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
10987 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
10988 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
10989 Change as necessary to match prototype in unexec.h.
10991 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10993 (back_comment, skip_chars): Mark vars as initialized.
10995 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10996 Rename locals to avoid shadowing.
10998 * lread.c (read1): Rewrite so as not to use empty "else".
10999 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
11001 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11003 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11004 warning when compiling print.c.
11006 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11007 instead of using an uninitialized var.
11008 (font_sort_entities): Mark var as initialized.
11010 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11012 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11013 pointers to constants.
11014 (font_parse_fcname): Remove unused vars.
11015 (font_delete_unmatched): Now static.
11016 (font_get_spec): Remove; unused.
11017 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11018 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11019 Rename or move locals to avoid shadowing.
11021 * fns.c (require_nesting_list, require_unwind): Now static.
11022 (Ffillarray): Rename locals to avoid shadowing.
11024 * floatfns.c (domain_error2): Define only if needed.
11025 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
11027 * alloc.c (mark_backtrace): Move decl from here ...
11028 * lisp.h: ... to here, so that it can be checked.
11030 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
11031 (Fdefvar): Rewrite so as not to use empty "else".
11032 (lisp_indirect_variable): Name an expression,
11033 to avoid gcc -Wbad-function-cast warning.
11034 (Fdefvar): Rename locals to avoid shadowing.
11036 * callint.c (quotify_arg, quotify_args): Now static.
11037 (Fcall_interactively): Rename locals to avoid shadowing.
11038 Use const pointer when appropriate.
11040 * lisp.h (get_system_name, get_operating_system_release):
11041 Move decls here, to check interfaces.
11042 * process.c (get_operating_system_release): Move decl to lisp.h.
11043 * xrdb.c (get_system_name): Likewise.
11044 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11045 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11046 some of which prompt warnings from gcc -Wbad-function-cast.
11047 (Fformat_time_string, Fencode_time, Finsert_char):
11048 (Ftranslate_region_internal, Fformat):
11049 Rename or remove local vars to avoid shadowing.
11050 (Ftranslate_region_internal): Mark var as initialized.
11052 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11055 * lisp.h (eassert): Check that the argument compiles, even if
11056 ENABLE_CHECKING is not defined.
11058 * data.c (Findirect_variable): Name an expression, to avoid
11059 gcc -Wbad-function-cast warning.
11060 (default_value, arithcompare, arith_driver, arith_error): Now static.
11061 (store_symval_forwarding): Rename local to avoid shadowing.
11062 (Fmake_variable_buffer_local, Fmake_local_variable):
11063 Mark variables as initialized.
11064 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
11066 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
11067 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11068 Rename locals to avoid shadowing.
11069 (mark_stack): Move local variables into the #ifdef region where
11071 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11072 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11074 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11075 (GC_STRING_CHARS): Remove; not used.
11076 (Fmemory_limit): Cast sbrk's returned value to char *.
11078 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11079 avoids undefined behavior in theory.
11081 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11083 Use functions, not macros, for up- and down-casing (Bug#8254).
11084 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11085 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11086 to use the following functions instead of these macros.
11087 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11088 EMACS_INT, since callers assume the returned value fits in int.
11089 (upcase1): Likewise, for UPCASE_TABLE.
11090 (uppercasep, lowercasep, upcase): New static inline functions.
11091 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
11092 the race-condition problem in the old DOWNCASE.
11094 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11095 Rename locals to avoid shadowing.
11096 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
11097 (regex_compile, re_search_2, re_match_2_internal):
11098 Remove unused local vars.
11099 (FREE_VAR): Rewrite so as not to use empty "else",
11100 which gcc can warn about.
11101 (regex_compile, re_match_2_internal): Mark locals as initialized.
11102 (RETALLOC_IF): Define only if needed.
11103 (WORDCHAR_P): Likewise. This one is never needed, but is used
11104 only in a comment talking about a compiler bug, so put inside
11105 the #if 0 of that comment.
11106 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11107 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11110 * search.c (boyer_moore): Rename locals to avoid shadowing.
11111 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11112 (PREV_CHAR_BOUNDARY): Likewise.
11114 * search.c (simple_search): Remove unused var.
11116 * dired.c (compile_pattern): Move decl from here ...
11117 * lisp.h: ... to here, so that it can be checked.
11118 (struct re_registers): New forward decl.
11120 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11122 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11124 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11125 Rename locals to avoid shadowing.
11126 (Fvertical_motion): Mark locals as initialized.
11128 * casefiddle.c (casify_object, casify_region): Now static.
11129 (casify_region): Mark local as initialized.
11131 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11133 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11134 New macros, so that the caller can use some names other than
11135 gcpro1, gcpro2, etc.
11136 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11138 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11139 argument, for consistency with GCPRO2_VAR, etc: it is now the
11140 prefix of the variable, not the variable itself. All uses
11142 * dired.c (directory_files_internal, file_name_completion):
11143 Rename locals to avoid shadowing.
11145 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11146 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11147 dired.c's scmp function, had undefined behavior.
11148 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11149 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11150 * buffer.h: ... to here, because these macros use current_buffer,
11151 and the new implementation with inline functions needs to have
11152 current_buffer in scope now, rather than later when the macros
11154 (downcase, upcase1): New static inline functions.
11155 (DOWNCASE, UPCASE1): Reimplement using these functions.
11156 This avoids undefined behavior in expressions like
11157 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11158 from race conditions in accessing the global variables
11159 case_temp1 and case_temp2.
11160 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11161 * lisp.h (case_temp1, case_temp2): Remove their decls.
11162 * character.h (ASCII_CHAR_P): Move from here ...
11163 * lisp.h: ... to here, so that the inline functions mentioned
11164 above can use them.
11166 * dired.c (directory_files_internal_unwind): Now static.
11168 * fileio.c (file_name_as_directory, directory_file_name):
11169 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11171 (file_name_as_directory): Use const pointers when appropriate.
11172 (Fexpand_file_name): Likewise. In particular, newdir might
11173 point at constant storage, so make it a const pointer.
11174 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
11175 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11177 (Fset_file_times, Finsert_file_contents, auto_save_error):
11178 Rename locals to avoid shadowing.
11180 * minibuf.c (choose_minibuf_frame_1): Now static.
11181 (Ftry_completion, Fall_completions): Rename or remove locals
11182 to avoid shadowing.
11184 * marker.c (bytepos_to_charpos): Remove; unused.
11186 * lisp.h (verify_bytepos, count_markers): New decls,
11187 so that gcc does not warn that these functions aren't declared.
11189 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11190 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
11191 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
11192 (copy_text): Remove unused local var.
11194 * filelock.c (within_one_second): Now static.
11195 (lock_file_1): Rename local to avoid shadowing.
11197 * buffer.c (fix_overlays_before): Mark locals as initialized.
11198 (fix_start_end_in_overlays): Likewise. This function should be
11199 simplified by using pointers-to-pointers, but that's a different
11201 (switch_to_buffer_1): Now static.
11202 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11203 (report_overlay_modification): Rename locals to avoid shadowing.
11205 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
11206 Fix pointer signedness issue.
11207 (sys_subshell): Mark local as volatile if checking for lint,
11208 to suppress a gcc -Wclobbered warning that does not seem to be right.
11209 (MAXPATHLEN): Define only if needed.
11211 * process.c (serial_open, serial_configure): Move decls from here ...
11212 * systty.h: ... to here, so that they can be checked.
11214 * fns.c (get_random, seed_random): Move extern decls from here ...
11215 * lisp.h: ... to here, so that they can be checked.
11217 * sysdep.c (reset_io): Now static.
11218 (wait_for_termination_signal): Remove; unused.
11220 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11221 (copy_keymap_item, append_key, push_text_char_description):
11223 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
11224 (DENSE_TABLE_SIZE): Remove; unused.
11225 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11226 (describe_map_tree):
11227 Rename locals to avoid shadowing.
11229 * keyboard.c: Declare functions static if they are not used elsewhere.
11230 (echo_char, echo_dash, cmd_error, top_level_2):
11231 (poll_for_input, handle_async_input): Now static.
11232 (read_char, kbd_buffer_get_event, make_lispy_position):
11233 (make_lispy_event, make_lispy_movement, apply_modifiers):
11234 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11235 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11236 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
11237 (read_key_sequence, read_char): Mark locals as initialized.
11238 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
11240 * keyboard.h (make_ctrl_char): New decl.
11241 (mark_kboards): Move decl here ...
11242 * alloc.c (mark_kboards): ... from here.
11244 * lisp.h (force_auto_save_soon): New decl.
11246 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
11247 (DEFINE_DUMMY_FUNCTION): New macro.
11248 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11250 (main): Add casts to avoid warnings
11251 if GCC considers string literals to be constants.
11253 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11255 * dbusbind.c: Pointer signedness fixes.
11256 (xd_signature, xd_append_arg, xd_initialize):
11257 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11258 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11259 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11260 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11262 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11263 if GCC considers string literals to be constants.
11264 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
11266 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11268 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11269 (print_preprocess, print_object): New macro to fix last change.
11271 * print.c (print_preprocess): Don't forget font objects.
11273 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
11275 * emacs.c (USAGE3): Doc fixes.
11277 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11279 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11282 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
11284 * lisp.h (VWindow_system, Qfile_name_history):
11285 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11286 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11287 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11289 * w32select.c: Don't #include "keyboard.h".
11290 (run_protected): Add extern declaration for waiting_for_input.
11292 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11293 * w32console.c (detect_input_pending, read_input_pending)
11294 (encode_terminal_code):
11295 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11296 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11297 (w32_system_caret_y, Qfile_name_history):
11298 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11299 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11300 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11301 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11302 * w32proc.c (Qlocal, report_file_error):
11303 * w32term.c (Vwindow_system, updating_frame):
11304 * w32uniscribe.c (initialized, uniscribe_font_driver):
11305 Remove unneeded extern declarations.
11307 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
11309 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
11311 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
11313 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11314 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11315 These macros can no longer be used for assignment.
11317 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11318 Assign struct members directly, instead of using BUF_BEGV etc.
11319 (record_buffer_markers, fetch_buffer_markers): New functions for
11320 recording and fetching special buffer markers.
11321 (set_buffer_internal_1, set_buffer_temp): Use them.
11323 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11325 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11327 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11328 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11330 * xdisp.c (hscroll_window_tree):
11331 (reconsider_clip_changes): Use PT instead of BUF_PT.
11333 2011-03-13 Eli Zaretskii <eliz@gnu.org>
11335 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11336 $(EMACS_ROOT)/lib/intprops.h.
11338 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11340 Fix more problems found by GCC 4.5.2's static checks.
11342 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11343 to unsigned char * to avoid compiler diagnostic.
11344 (xg_free_frame_widgets): Make it clear that a local variable is
11345 needed only if USE_GTK_TOOLTIP.
11346 (gdk_window_get_screen): Make it clear that this macro is needed
11347 only if USE_GTK_TOOLTIP.
11348 (int_gtk_range_get_value): New function, which avoids a diagnostic
11349 from gcc -Wbad-function-cast.
11350 (xg_set_toolkit_scroll_bar_thumb): Use it.
11351 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11352 diagnostic from gcc -Wbad-function-cast.
11353 (get_utf8_string, xg_get_file_with_chooser):
11354 Rename locals to avoid shadowing.
11355 (create_dialog): Move locals to avoid shadowing.
11357 * xgselect.c (xg_select): Remove unused var.
11359 * image.c (four_corners_best): Mark locals as initialized.
11360 (gif_load): Initialize transparent_p to zero (Bug#8238).
11361 Mark another local as initialized.
11362 (my_png_error, my_error_exit): Mark with NO_RETURN.
11364 * image.c (clear_image_cache): Now static.
11365 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
11366 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
11367 (x_edge_detection): Remove unnecessary cast that
11368 gcc -Wbad-function-cast diagnoses.
11369 (gif_load): Fix pointer signedness.
11370 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11371 (jpeg_load, gif_load): Rename locals to avoid shadowing.
11373 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
11375 Improve quality of tests for time stamp overflow.
11376 For example, without this patch (encode-time 0 0 0 1 1
11377 1152921504606846976) returns the obviously-bogus value (-948597
11378 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11379 reports time overflow. See
11380 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
11381 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11382 * editfns.c: Include limits.h and intprops.h.
11383 (TIME_T_MIN, TIME_T_MAX): New macros.
11384 (time_overflow): Move earlier, to before first use.
11385 (hi_time, lo_time): New functions, for an accurate test for
11386 out-of-range times.
11387 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11388 (Fget_internal_run_time): Don't assume time_t fits in int.
11389 (make_time): Use list2 instead of Fcons twice.
11390 (Fdecode_time): More accurate test for out-of-range times.
11391 (check_tm_member): New function.
11392 (Fencode_time): Use it, to test for out-of-range times.
11393 (lisp_time_argument): Don't rely on undefined left-shift and
11394 right-shift behavior when checking for time stamp overflow.
11396 * editfns.c (time_overflow): New function, refactoring common code.
11397 (Fformat_time_string, Fdecode_time, Fencode_time):
11398 (Fcurrent_time_string): Use it.
11400 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11401 * dired.c (make_time): Move to ...
11402 * editfns.c (make_time): ... here.
11403 * systime.h: Note the move.
11405 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11407 * fringe.c (update_window_fringes): Remove unused variables.
11409 * unexmacosx.c (copy_data_segment): Also copy __got section.
11412 2011-03-12 Eli Zaretskii <eliz@gnu.org>
11414 * termcap.c [MSDOS]: Include "msdos.h".
11415 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11416 Constify `char *' arguments and their references according to
11417 prototypes in tparam.h.
11419 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
11421 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11422 Adapt all references accordingly.
11424 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11426 2011-03-11 Tom Tromey <tromey@redhat.com>
11428 * buffer.c (syms_of_buffer): Remove obsolete comment.
11430 2011-03-11 Eli Zaretskii <eliz@gnu.org>
11432 * termhooks.h (encode_terminal_code): Declare prototype.
11434 * msdos.c (encode_terminal_code): Don't declare prototype.
11436 * term.c (encode_terminal_code): Now external again, used by
11437 w32console.c and msdos.c.
11439 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11440 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
11442 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
11444 Fix some minor problems found by GCC 4.5.2's static checks.
11446 * fringe.c (update_window_fringes): Mark locals as initialized
11448 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
11450 * alloc.c (mark_fringe_data): Move decl from here ...
11451 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11452 to check its interface.
11453 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11455 * fontset.c (free_realized_fontset): Now static.
11456 (Fset_fontset_font): Rename local to avoid shadowing.
11457 (fontset_font): Mark local as initialized.
11458 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
11460 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11462 * xselect.c (x_disown_buffer_selections): Remove; not used.
11463 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
11464 (x_own_selection, Fx_disown_selection_internal): Rename locals
11465 to avoid shadowing.
11466 (x_handle_dnd_message): Remove local to avoid shadowing.
11468 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11469 so that the caller can use some name other than gcpro1.
11470 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
11471 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11472 (Fx_backspace_delete_keys_p):
11473 Use them to avoid shadowing, and rename vars to avoid shadowing.
11474 (x_decode_color, x_set_name, x_window): Now static.
11475 (Fx_create_frame): Add braces to silence GCC warning.
11476 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
11477 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11478 Remove unused locals.
11479 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11480 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11481 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11484 * xterm.h (x_mouse_leave): New decl.
11486 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11487 Remove unused functions.
11488 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11489 (x_calc_absolute_position): Now static.
11490 (XTread_socket): Don't define label "out" unless it's used.
11491 Don't declare local "event" unless it's used.
11492 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11493 unless they are used.
11494 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11495 (x_fatal_error_signal): Remove; not used.
11496 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11497 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11498 (x_error_catcher, x_connection_closed, x_error_handler):
11499 (x_error_quitter, xembed_send_message, x_iconify_frame):
11500 (my_log_handler): Rename locals to avoid shadowing.
11501 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
11502 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
11504 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11505 Rename or move locals to avoid shadowing.
11506 (tty_defined_color, merge_face_heights): Now static.
11507 (free_realized_faces_for_fontset): Remove; not used.
11508 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11509 does not deduce is never used uninitialized.
11510 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11511 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
11513 * terminal.c (store_terminal_param): Now static.
11515 * xmenu.c (menu_highlight_callback): Now static.
11516 (set_frame_menubar): Remove unused local.
11517 (xmenu_show): Rename parameter to avoid shadowing.
11518 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11519 since they might point to immutable storage.
11520 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11521 since it's unused otherwise.
11523 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
11524 Add a FIXME, since the code still doesn't look right. (Bug#8215)
11525 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11526 avoids a gcc -Wuninitialized diagnostic.
11527 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
11528 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11529 does not deduce are never used uninitialized.
11531 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11533 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
11534 * window.c (window_loop, size_window):
11535 (run_window_configuration_change_hook, enlarge_window): Likewise.
11537 * window.c (display_buffer): Now static.
11538 (size_window): Mark variables that gcc -Wuninitialized
11539 does not deduce are never used uninitialized.
11540 * window.h (check_all_windows): New decl, to forestall
11541 gcc -Wmissing-prototypes diagnostic.
11542 * dispextern.h (bidi_dump_cached_states): Likewise.
11544 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11546 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
11547 Include <limits.h>.
11548 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11549 and to avoid gcc -Wuninitialized warning.
11550 (load_charset_map): Mark variables that gcc -Wuninitialized
11551 does not deduce are never used uninitialized.
11552 (load_charset): Abort instead of using uninitialized var (Bug#8229).
11554 * coding.c (coding_set_source, coding_set_destination):
11555 Use "else { /* comment */ }" rather than "else /* comment */;"
11556 for clarity, and to avoid gcc -Wempty-body warning.
11557 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11558 a block, when the outer 'i' will do.
11559 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11560 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11561 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11562 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11563 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11564 Rename locals to avoid shadowing.
11565 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
11566 * coding.c (emacs_mule_char, encode_invocation_designation):
11567 Now static, since they're not used elsewhere.
11568 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
11569 (decode_coding_object, encode_coding_object, detect_coding_system):
11570 (decode_coding_emacs_mule): Mark variables that gcc
11571 -Wuninitialized does not deduce are never used uninitialized.
11572 (detect_coding_iso_2022): Initialize a local variable that might
11573 be used uninitialized. Leave a FIXME because it's not clear that
11574 this initialization is needed. (Bug#8211)
11575 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11576 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11577 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11578 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11579 Remove unused macros.
11581 * category.c (hash_get_category_set): Remove unused local var.
11582 (copy_category_table): Now static, since it's not used elsewhere.
11583 * character.c (string_count_byte8): Likewise.
11585 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11586 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11588 * chartab.c (copy_sub_char_table): Now static, since it's not used
11590 (sub_char_table_ref_and_range, char_table_ref_and_range):
11591 Rename locals to avoid shadowing.
11592 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
11594 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
11595 (BIDI_BOB): Remove unused macro.
11597 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11598 deduce are never used uninitialized.
11599 * term.c (encode_terminal_code): Likewise.
11601 * term.c (encode_terminal_code): Now static. Remove unused local.
11603 * tparam.h: New file.
11604 * term.c, tparam.h: Include it.
11605 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11606 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11607 Move these decls to tparam.h, and make them agree with what
11608 is actually in tparam.c. The previous trick of using incompatible
11609 decls in different modules does not conform to the C standard.
11610 All callers of tparam changed to use tparam's actual API.
11611 * tparam.c (tparam1, tparam, tgoto):
11612 Use const pointers where appropriate.
11614 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11615 * cm.h (struct cm): Likewise.
11616 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11617 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11618 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11619 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11620 (turn_on_face, init_tty): Likewise.
11621 * termchar.h (struct tty_display_info): Likewise.
11623 * term.c (term_mouse_position): Rename local to avoid shadowing.
11625 * alloc.c (mark_ttys): Move decl from here ...
11626 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11628 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11630 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11632 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
11634 * search.c (compile_pattern_1): Remove argument regp, unused since
11635 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11636 (compile_pattern): Don't pass it.
11638 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11640 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11641 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11643 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11645 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11647 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11648 gdk_window_get_screen, gdk_window_get_geometry,
11649 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11650 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11651 (xg_get_pixbuf_from_pixmap): New function.
11652 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11653 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11654 Call xg_get_pixbuf_from_pixmap instead of
11655 gdk_pixbuf_get_from_drawable.
11656 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11657 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11658 (xg_check_special_colors): Use GtkStyleContext and its functions
11660 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11661 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11662 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
11663 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11664 Call gtk_widget_get_preferred_size.
11665 (xg_frame_resized): gdk_window_get_geometry only takes 5
11667 (xg_win_to_widget, xg_event_is_for_menubar):
11668 Call gdk_x11_window_lookup_for_display.
11669 (xg_set_widget_bg): New function.
11670 (delete_cb): New function.
11671 (xg_create_frame_widgets): Connect delete-event to delete_cb.
11672 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
11673 (xg_set_background_color): Call xg_set_widget_bg.
11674 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11675 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11676 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11677 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11679 (update_frame_tool_bar): Call gtk_widget_hide.
11680 (xg_initialize): Use GDK_KEY_g.
11682 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11684 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11686 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11687 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11688 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11690 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
11692 * w32xfns.c (select_palette): Check success of RealizePalette against
11693 GDI_ERROR, not zero.
11695 See ChangeLog.11 for earlier changes.
11697 ;; Local Variables:
11701 Copyright (C) 2011-2012 Free Software Foundation, Inc.
11703 This file is part of GNU Emacs.
11705 GNU Emacs is free software: you can redistribute it and/or modify
11706 it under the terms of the GNU General Public License as published by
11707 the Free Software Foundation, either version 3 of the License, or
11708 (at your option) any later version.
11710 GNU Emacs is distributed in the hope that it will be useful,
11711 but WITHOUT ANY WARRANTY; without even the implied warranty of
11712 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11713 GNU General Public License for more details.
11715 You should have received a copy of the GNU General Public License
11716 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.