Fix missing prefix warning in pascal.el.
[bpt/emacs.git] / src / ChangeLog
1 2012-04-26 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4 display element, check also the underlying string or buffer
5 character. (Bug#11341)
6
7 * w32menu.c: Include w32heap.h.
8 (add_menu_item): If the call to AppendMenuW (via
9 unicode_append_menu) fails, disable Unicode menus only if we are
10 running on Windows 9X/Me.
11
12 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
13
14 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
15 (xgetint): Add missing shift for LSB tags.
16
17 2012-04-24 Martin Rudalics <rudalics@gmx.at>
18
19 * keyboard.c (read_char): Don't wipe echo area for select window
20 events: These might get delayed via `mouse-autoselect-window'
21 (Bug#11304).
22
23 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
24
25 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
26 manipulation of :loaded-from data.
27
28 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
29
30 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
31 now a cons (bug#11311).
32
33 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
34
35 Do not create empty overlays with the evaporate property (Bug#9642).
36 * buffer.c (Fmove_overlay): Delete an evaporating overlay
37 if it becomes empty after its bounds are adjusted to fit within
38 its buffer. Without this fix, in a nonempty buffer (let ((o
39 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
40 yields an empty overlay that has the evaporate property, which is
41 not supposed to happen.
42
43 Fix minor GTK3 problems found by static checking.
44 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
45 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
46 (struct _EmacsFixedClass, emacs_fixed_get_type):
47 Move decls here from emacsgtkfixed.h, since they needn't be public.
48 (emacs_fixed_get_type): Now static.
49 (emacs_fixed_class_init): Omit unused local.
50 (emacs_fixed_child_type): Remove; unused.
51 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
52 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
53 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
54 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
55 (EMACS_FIXED_GET_CLASS): Remove; unused.
56 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
57
58 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
59 Problem reported by Juanma Barranquero for Windows -Wunused-function.
60
61 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
62
63 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
64 * gmalloc.c: (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
65 (__malloc_size_t, __malloc_ptrdiff_t):
66 Remove. All uses removed, replaced by the definiens if needed,
67 since we can assume C89 or better now.
68 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
69 (protect_malloc_state, align, get_contiguous_space)
70 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
71 (malloc_atfork_handler_child, malloc_enable_thread)
72 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
73 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
74 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
75 (special_realloc, _realloc_internal_nolock, _realloc_internal)
76 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
77 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
78 Define using prototypes, not old style.
79 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
80 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
81 (align): Don't assume that signed integer overflow wraps around.
82 Omit unused local var.
83 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
84 (_free_internal_nolock, memalign, mallochook, reallochook):
85 Omit no-longer-needed casts.
86 (valloc): Use getpagesize, not __getpagesize.
87 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
88 (struct hdr): The 'magic' member is now size_t, not unsigned long.
89
90 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
91
92 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
93
94 Move functions from C to Lisp. Make non-blocking method calls
95 the default. Implement further D-Bus standard interfaces.
96
97 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
98 (QCdbus_request_name_allow_replacement)
99 (QCdbus_request_name_replace_existing)
100 (QCdbus_request_name_do_not_queue)
101 (QCdbus_request_name_reply_primary_owner)
102 (QCdbus_request_name_reply_in_queue)
103 (QCdbus_request_name_reply_exists)
104 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
105 (QCdbus_registered_serial, QCdbus_registered_method)
106 (QCdbus_registered_signal): New Lisp objects.
107 (XD_DEBUG_MESSAGE): Use sizeof.
108 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
109 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
110 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
111 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
112 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
113 (xd_signature, xd_append_arg): Allow float for integer types.
114 (xd_get_connection_references): New function.
115 (xd_get_connection_address): Rename from xd_initialize. Return
116 cached address.
117 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
118 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
119 level.
120 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
121 Return number of recounts.
122 (Fdbus_get_unique_name): Make stronger parameter check.
123 (Fdbus_message_internal): New defun.
124 (Fdbus_call_method, Fdbus_call_method_asynchronously)
125 (Fdbus_method_return_internal, Fdbus_method_error_internal)
126 (Fdbus_send_signal, Fdbus_register_service)
127 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
128 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
129 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
130 (Vdbus_compiled_version, Vdbus_runtime_version)
131 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
132 (Vdbus_message_type_method_return, Vdbus_message_type_error)
133 (Vdbus_message_type_signal): New defvars.
134 (Vdbus_registered_buses, Vdbus_registered_objects_table): Adapt
135 docstring.
136
137 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
138
139 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
140 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
141 Do not assume ptrdiff_t is the same width as 'int'.
142
143 * alloc.c: Handle unusual debugging option combinations.
144 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
145 since the two debugging options are incompatible.
146 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
147 is defined.
148 (mem_init, mem_insert, mem_insert_fixup):
149 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
150 (NEED_MEM_INSERT): Remove; no longer needed.
151
152 2012-04-22 Leo Liu <sdl.web@gmail.com>
153
154 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
155
156 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
157
158 * sysdep.c [__FreeBSD__]: Minor cleanups.
159 (list_system_processes, system_process_attributes) [__FreeBSD__]:
160 Use Emacs indenting style more consistently. Avoid some casts.
161 Use 'double' consistently rather than mixing 'float' and 'double'.
162
163 2012-04-21 Eduard Wiebe <usenet@pusto.de>
164
165 * sysdep.c (list_system_processes, system_process_attributes): Add
166 implementation for FreeBSD (Bug#5243).
167
168 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
169
170 * lisp.mk (lisp): Update.
171
172 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
173
174 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
175 It is never used otherwise.
176
177 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
178
179 * print.c (print_preprocess): Only check print_depth if print-circle
180 is nil.
181 (print_object): Check for cycles even when print-circle is nil and
182 print-gensym is t, but only check print_depth if print-circle is nil.
183
184 2012-04-20 Chong Yidong <cyd@gnu.org>
185
186 * process.c (wait_reading_process_output): If EIO occurs on a pty,
187 set the status to "failed" and ensure that sentinel is run.
188
189 2012-04-20 Glenn Morris <rgm@gnu.org>
190
191 * process.c (Fset_process_inherit_coding_system_flag)
192 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
193 (Fmake_network_process, Fmake_serial_process): Doc fix.
194
195 2012-04-20 Eli Zaretskii <eliz@gnu.org>
196
197 * xdisp.c (string_buffer_position_lim): Limit starting position to
198 BEGV.
199 (set_cursor_from_row): If called for a mode-line or header-line
200 row, return zero immediately.
201 (try_cursor_movement): If inside continuation line, don't back up
202 farther than the first row after the header line, if any.
203 Don't consider the header-line row as "partially visible", even if
204 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
205
206 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
207
208 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
209 (bug#11238).
210
211 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
212 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
213
214 configure: new option --enable-gcc-warnings (Bug#11207)
215 * Makefile.in (C_WARNINGS_SWITCH): Remove.
216 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
217 (ALL_CFLAGS): Use new macros rather than old.
218 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
219 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
220 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
221 -Wunused-result, -Wunused-variable. This should go away once
222 the Emacs and Gnulib regex code is merged.
223 (xmalloc, xrealloc): Now static.
224
225 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
226
227 * dired.c (Fsystem_groups): Remove unused local.
228
229 2012-04-17 Glenn Morris <rgm@gnu.org>
230
231 * dired.c (Fsystem_users): Doc fix.
232
233 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
234
235 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
236 (syms_of_dired): Add them.
237
238 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
239
240 Fix minor alloc.c problems found by static checking.
241 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
242 New extern decls, to avoid calling undeclared functions.
243 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
244 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
245 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
246 (NEED_MEM_INSERT): New macro.
247 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
248 Remove one incorrect comment and fix another.
249
250 Fix minor ralloc.c problems found by static checking.
251 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
252 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
253 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
254 (r_alloc_sbrk): Now static.
255
256 Improve ralloc.c interface checking.
257 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
258 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
259 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
260 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
261 [REL_ALLOC]: ... to here, to check interface.
262 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
263 Remove decls. This fixes an "It stinks!".
264
265 * alloc.c (which_symbols): Fix alignment issue / type clash.
266
267 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
268
269 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
270 (struct Lisp_Misc_Any): Likewise.
271 (struct Lisp_Free): Likewise.
272 * alloc.c (union aligned_Lisp_Symbol): Define.
273 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
274 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
275 (union aligned_Lisp_Misc): Define.
276 (MARKER_BLOCK_SIZE, struct marker_block): Use union
277 aligned_Lisp_Misc instead of union Lisp_Misc.
278 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
279
280 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
281
282 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
283 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
284 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
285 * s/netbsd.h, s/sol2-6.h:
286 Remove definition of GC_MARK_STACK, since the default now works.
287 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
288 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
289 no longer the default.
290 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
291
292 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
293
294 * lread.c (lisp_file_lexically_bound_p):
295 Fix hang at ";-*-\n" (bug#11238).
296
297 2012-04-14 Eli Zaretskii <eliz@gnu.org>
298
299 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
300 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
301
302 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
303
304 * nsterm.m (constrainFrameRect): Always constrain when there is only
305 one screen (Bug#10962).
306
307 2012-04-13 Ken Brown <kbrown@cornell.edu>
308
309 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
310
311 2012-04-13 Reuben Thomas <rrt@sc3d.org>
312
313 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
314
315 2012-04-11 Daniel Colascione <dancol@dancol.org>
316
317 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
318 against is gone. It's better to use vfork now so that when Cygwin
319 gains a new, working vfork, we use it automatically (bug#10398).
320
321 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
322
323 * window.c (save_window_save): Obey window-point-insertion-type.
324
325 2012-04-11 Glenn Morris <rgm@gnu.org>
326
327 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
328
329 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
330
331 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
332
333 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
334
335 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
336 (force_quit_count): New var.
337 (handle_interrupt): Use it.
338
339 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
340
341 * w32.c (w32_delayed_load): Record the full path of the library
342 being loaded (bug#10424).
343
344 2012-04-09 Glenn Morris <rgm@gnu.org>
345
346 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
347 not just in the obarray, before snarfing them. (Bug#11036)
348
349 * Makefile.in ($(leimdir)/leim-list.el):
350 Pass EMACS rather than BUILT_EMACS.
351
352 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
353
354 * process.c (make_process):
355 * process.h: Add integer `gnutls_handshakes_tried' member to
356 process struct.
357
358 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
359 Add convenience `GNUTLS_LOG2i' macro.
360
361 * gnutls.c (gnutls_log_function2i): Convenience log function.
362 (emacs_gnutls_read): Use new log functions,
363 `gnutls_handshakes_tried' process member, and
364 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
365 attempts per process (connection).
366
367 2012-04-09 Chong Yidong <cyd@gnu.org>
368
369 * eval.c (Fuser_variable_p, user_variable_p_eh)
370 (lisp_indirect_variable): Functions deleted.
371 (Fdefvar): Caller changed.
372
373 * callint.c (Finteractive, Fcall_interactively):
374 * minibuf.c (Fread_variable): Callers changed.
375
376 2012-04-09 Eli Zaretskii <eliz@gnu.org>
377
378 * xdisp.c (set_cursor_from_row): If the display string appears in
379 the buffer at position that is closer to point than the position
380 after the display string, display the cursor on the first glyph of
381 the display string. Fixes cursor display when a 'display' text
382 property immediately follows invisible text. (Bug#11094)
383
384 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
385
386 composite.c: use 'double' consistently
387 * composite.c (get_composition_id): Use 'double' consistently
388 instead of converting 'float' to 'double' and vice versa; this is
389 easier to understand and avoids a GCC warning.
390
391 2012-04-09 Glenn Morris <rgm@gnu.org>
392
393 * Makefile.in: Generate leim-list with bootstrap-emacs, in
394 preparation for dumping it with emacs. (Bug#4789)
395 (leimdir): New variable.
396 ($(leimdir)/leim-list.el): New rule.
397 (emacs$(EXEEXT)): Depend on leim-list.el.
398
399 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
400 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
401 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
402
403 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
404
405 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
406 proper alignment.
407
408 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
409
410 * xml.c (init_libxml2_functions) [WINDOWSNT]:
411 Remove unused local variable.
412
413 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
414
415 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
416 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
417 (mark_memory): Mark Lisp_Objects only if pointers might hide in
418 objects, as mark_maybe_pointer will catch them otherwise.
419 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
420 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
421
422 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
423
424 Fix typo that broke non-Windows builds.
425 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
426
427 2012-04-07 Eli Zaretskii <eliz@gnu.org>
428
429 Support building on MS-Windows with libxml2.
430
431 * makefile.w32-in (OBJ2): Add xml.$(O).
432 (GLOBAL_SOURCES): Add xml.c.
433 ($(BLD)/xml.$(O)): New dependency list.
434
435 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
436 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
437 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
438 [!WINDOWSNT]: New macros.
439 (init_libxml2_functions, libxml2_loaded_p): New functions.
440 (parse_region): Call fn_xmlCheckVersion instead of using the macro
441 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
442 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
443 Calls xmlCleanupParser only if libxml2 was loaded (or statically
444 linked in).
445 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
446 Call init_libxml2_functions before calling libxml2 functions.
447 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
448
449 * emacs.c: Don't include libxml/parser.h.
450 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
451 xmlCleanupParser directly.
452
453 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
454
455 2012-04-07 Eli Zaretskii <eliz@gnu.org>
456
457 * indent.c (Fvertical_motion): If there is a display string at
458 point, use it.vpos to compute how many lines to backtrack after
459 move_it_to point. (Bug#11133)
460
461 2012-04-06 Eli Zaretskii <eliz@gnu.org>
462
463 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
464 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
465 about subtle differences between FETCH_CHAR* and STRING_CHAR*
466 macros related to unification of CJK characters. For the details,
467 see the discussion following the message here:
468 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
469
470 2012-04-04 Chong Yidong <cyd@gnu.org>
471
472 * keyboard.c (Vdelayed_warnings_list): Doc fix.
473
474 2012-04-01 Eli Zaretskii <eliz@gnu.org>
475
476 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
477 instead of alloca. (Bug#11138)
478
479 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
480
481 * w32menu.c (is_simple_dialog): Properly check lisp types.
482 (Bug#11141)
483
484 2012-03-31 Eli Zaretskii <eliz@gnu.org>
485
486 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
487 position we get to after a call to move_it_to fails the
488 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
489 only if we wind up in a string from display property. (Bug#11063)
490
491 * window.c (Fdelete_other_windows_internal): Invalidate the row
492 and column information about mouse highlight, so that redisplay
493 restores it after reallocating the glyph matrices. (Bug#7464)
494
495 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
496 string comes from a `display' text property, use the buffer
497 position of that property as if we actually saw that position in
498 the row's glyphs.
499 (move_it_by_lines): Remove the assertion that
500 "it->current_x == 0 && it->hpos == 0" which can be legitimately
501 violated when there's a before-string at the beginning of a line.
502 (Bug#11063)
503
504 2012-03-30 Eli Zaretskii <eliz@gnu.org>
505
506 * xdisp.c (append_space_for_newline): If the default face was
507 remapped, use the remapped face for the appended newline.
508 (extend_face_to_end_of_line): Use the remapped default face for
509 extending the face to the end of the line.
510 (display_line): Call extend_face_to_end_of_line when the default
511 face was remapped. (Bug#11068)
512
513 2012-03-29 Eli Zaretskii <eliz@gnu.org>
514
515 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
516
517 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
518
519 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
520
521 2012-03-27 Glenn Morris <rgm@gnu.org>
522
523 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
524 Doc fixes.
525
526 2012-03-26 Kenichi Handa <handa@m17n.org>
527
528 * dispextern.h (struct glyph): Fix previous change. Change the
529 bit length of glyphless.ch to 25 (Bug#11082).
530
531 2012-03-26 Chong Yidong <cyd@gnu.org>
532
533 * keyboard.c (Vselection_inhibit_update_commands): New variable.
534 (command_loop_1): Use it; inhibit selection update for
535 handle-select-window too (Bug#8996).
536
537 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
538
539 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
540
541 2012-03-25 Kenichi Handa <handa@m17n.org>
542
543 * dispextern.h (struct glyph): Change the bit length of
544 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
545
546 2012-03-24 Eli Zaretskii <eliz@gnu.org>
547
548 * s/ms-w32.h (tzname): Include time.h before redirecting to
549 _tzname. Fixes the MSVC build. (Bug#9960)
550
551 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
552
553 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
554 characters.
555
556 * xterm.c (XTread_socket): Only modify handling_signal if
557 !SYNC_INPUT. (Bug#11080)
558
559 2012-03-23 Eli Zaretskii <eliz@gnu.org>
560
561 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
562 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
563 when fetching a multibyte character consumes more bytes than
564 CHAR_BYTES returns, due to unification of CJK characters in
565 string_char. (Bug#11073)
566
567 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
568
569 * process.c (wait_reading_process_output): Handle pty disconnect
570 by refraining from sending oneself a SIGCHLD (bug#10933).
571
572 2012-03-22 Chong Yidong <cyd@gnu.org>
573
574 * dispextern.h (struct it): New member string_from_prefix_prop_p.
575
576 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
577 Mark string as coming from a prefix property.
578 (handle_face_prop): Use default face for prefix strings (Bug#4281).
579 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
580
581 2012-03-21 Chong Yidong <cyd@gnu.org>
582
583 * xfaces.c (Vface_remapping_alist): Doc fix.
584
585 2012-03-20 Eli Zaretskii <eliz@gnu.org>
586
587 * w32proc.c (Fw32_set_console_codepage)
588 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
589 Doc fixes.
590
591 2012-03-20 Chong Yidong <cyd@gnu.org>
592
593 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
594 to reflect default non-nil value of redisplay-dont-pause.
595
596 2012-03-19 Kenichi Handa <handa@m17n.org>
597
598 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
599 it fit in a valid range (Bug#11003).
600
601 2012-03-18 Eli Zaretskii <eliz@gnu.org>
602
603 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
604 that is not from display property, accept the row as a "cursor
605 row" if one of the string's character has a non-nil `cursor'
606 property. Fixes cursor positioning when there are newlines in
607 overlay strings, e.g. in icomplete.el. (Bug#11035)
608
609 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
610
611 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
612
613 2012-03-12 Chong Yidong <cyd@gnu.org>
614
615 * eval.c (inhibit_lisp_code): Rename from
616 inhibit_window_configuration_change_hook; move from window.c.
617
618 * xfns.c (unwind_create_frame_1, Fx_create_frame):
619 * window.c (run_window_configuration_change_hook)
620 (syms_of_window): Callers changed.
621
622 2012-03-11 Chong Yidong <cyd@gnu.org>
623
624 * keymap.c (Fkey_description): Doc fix (Bug#9700).
625
626 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
627
628 2012-03-10 Chong Yidong <cyd@gnu.org>
629
630 * frame.c (other_visible_frames): Don't assume the selected frame
631 is visible (Bug#10955).
632
633 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
634
635 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
636
637 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
638
639 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
640 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
641 zero (Bug#10954).
642
643 2012-03-03 Glenn Morris <rgm@gnu.org>
644
645 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
646
647 2012-03-02 Eli Zaretskii <eliz@gnu.org>
648
649 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
650 position past the first glyph_row that ends at ZV. (Bug#10902)
651 (redisplay_window, next_element_from_string): Fix typos in
652 comments.
653 (redisplay_window): Pass to move_it_vertically the margin in
654 pixels, not in screen lines.
655
656 2012-03-02 Glenn Morris <rgm@gnu.org>
657
658 * buffer.c (buffer-list-update-hook): Doc fix.
659
660 2012-02-29 Eli Zaretskii <eliz@gnu.org>
661
662 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
663 push_it before setting up the iterator for the first overlay
664 string, even if we have an empty string loaded.
665 (next_overlay_string): If there's an empty string on the iterator
666 stack, pop the stack. (Bug#10903)
667
668 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
669
670 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
671 Suggested by Stefan Monnier in
672 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
673 * alloc.c (widen_to_Lisp_Object): New static function.
674 (mark_memory): Also mark Lisp_Objects by fetching pointer words
675 and widening them to Lisp_Objects. This would work even if
676 USE_LSB_TAG is defined and wide integers are used, which might
677 happen in a future version of Emacs.
678
679 2012-02-25 Chong Yidong <cyd@gnu.org>
680
681 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
682 Doc fix.
683
684 * xselect.c (Fx_selection_exists_p): Doc fix.
685 (x_clipboard_manager_save_all): Print an informative message
686 before saving to clipboard manager.
687
688 2012-02-24 Chong Yidong <cyd@gnu.org>
689
690 * keyboard.c (process_special_events): Handle all X selection
691 requests in kbd_buffer, not just the next one (Bug#8869).
692
693 2012-02-23 Chong Yidong <cyd@gnu.org>
694
695 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
696 call when setting menu-bar-lines and tool-bar-lines parameters.
697 (unwind_create_frame_1): New helper function.
698
699 * window.c (inhibit_window_configuration_change_hook): New var.
700 (run_window_configuration_change_hook): Obey it.
701 (syms_of_window): Initialize it.
702
703 2012-02-22 Chong Yidong <cyd@gnu.org>
704
705 * xterm.c (x_draw_image_relief): Add missing type check for
706 Vtool_bar_button_margin (Bug#10743).
707
708 2012-02-21 Chong Yidong <cyd@gnu.org>
709
710 * fileio.c (Vfile_name_handler_alist): Doc fix.
711
712 * buffer.c (Fget_file_buffer): Protect against invalid file
713 handler return value.
714
715 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
716
717 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
718 when computing $valmask.
719
720 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
721 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
722 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
723 It's useless in that case, and it can cause problems on hosts
724 that allocate halves of EMACS_INT values separately.
725 Reported by Dan Horák. Diagnosed by Andreas Schwab in
726 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
727 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
728 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
729 it avoids undefined behavior on hosts where shifting right by more
730 than the word width has undefined behavior.
731
732 2012-02-19 Chong Yidong <cyd@gnu.org>
733
734 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
735 (Funhandled_file_name_directory, Ffile_name_as_directory)
736 (Fdirectory_file_name, Fexpand_file_name)
737 (Fsubstitute_in_file_name): Protect against invalid file handler
738 return values (Bug#10845).
739
740 2012-02-18 Eli Zaretskii <eliz@gnu.org>
741
742 * .gdbinit (pitx): Fix incorrect references to fields of the
743 iterator stack.
744
745 2012-02-17 Chong Yidong <cyd@gnu.org>
746
747 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
748
749 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
750
751 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
752 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
753
754 2012-02-15 Chong Yidong <cyd@gnu.org>
755
756 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
757 marked as special. Also, starting docstrings with * is obsolete.
758
759 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
760
761 * gnutls.c (emacs_gnutls_write): Fix last change.
762
763 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
764
765 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
766 send_process.
767
768 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
769
770 * keymap.c (Fsingle_key_description): Handle char ranges.
771
772 2012-02-12 Chong Yidong <cyd@gnu.org>
773
774 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
775 as that creates a dangerous corner case.
776
777 * window.c (Fdelete_window_internal): Invalidate the mouse
778 highlight (Bug#9904).
779
780 2012-02-12 Glenn Morris <rgm@gnu.org>
781
782 * xselect.c (Fx_own_selection_internal)
783 (Fx_get_selection_internal, Fx_disown_selection_internal)
784 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
785 * nsselect.m (Fx_own_selection_internal)
786 (Fx_disown_selection_internal, Fx_selection_exists_p)
787 (Fx_selection_owner_p, Fx_get_selection_internal):
788 Sync docs and argument specs with the xselect.c versions.
789
790 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
791
792 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
793
794 2012-02-11 Eli Zaretskii <eliz@gnu.org>
795
796 * w32select.c (Fx_selection_exists_p): Sync doc string and
797 argument list with xselect.c. (Bug#10783)
798
799 * w16select.c (Fx_selection_exists_p): Sync doc string and
800 argument list with xselect.c. (Bug#10783)
801
802 2012-02-10 Glenn Morris <rgm@gnu.org>
803
804 * fns.c (Fsecure_hash): Doc fix.
805
806 2012-02-09 Kenichi Handa <handa@m17n.org>
807
808 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
809
810 2012-02-07 Chong Yidong <cyd@gnu.org>
811
812 * buffer.c (Fbuffer_local_variables)
813 (buffer_lisp_local_variables): Handle unbound vars correctly;
814 don't let Qunbound leak into Lisp.
815
816 2012-02-07 Glenn Morris <rgm@gnu.org>
817
818 * image.c (Fimagemagick_types): Doc fix.
819
820 * image.c (imagemagick-render-type): Change it from a lisp object
821 to an integer. Move the doc here from the lisp manual.
822 Treat all values not equal to 0 the same.
823
824 2012-02-06 Chong Yidong <cyd@gnu.org>
825
826 * doc.c (store_function_docstring): Avoid applying docstring of
827 alias to base function (Bug#2603).
828
829 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
830
831 * .gdbinit (pp1, pv1): Remove redundant defines.
832 (pr): Use pp.
833
834 2012-02-04 Chong Yidong <cyd@gnu.org>
835
836 * nsterm.m: Declare a global (Bug#10694).
837
838 2012-02-04 Eli Zaretskii <eliz@gnu.org>
839
840 * w32.c (get_emacs_configuration_options):
841 Include --enable-checking, if specified, in the return value.
842
843 2012-02-04 Martin Rudalics <rudalics@gmx.at>
844
845 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
846 after rounding frame sizes. (Bug#9723)
847
848 2012-02-04 Eli Zaretskii <eliz@gnu.org>
849
850 * keyboard.c (adjust_point_for_property): Don't position point
851 before BEGV. (Bug#10696)
852
853 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
854
855 Handle overflow when computing char display width (Bug#9496).
856 * character.c (char_width): Return EMACS_INT, not int.
857 (char_width, c_string_width): Check for overflow when
858 computing the width; this is possible now that individual
859 characters can have unbounded width. Problem introduced
860 by merge from Emacs 23 on 2012-01-19.
861
862 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
863
864 * dbusbind.c (Fdbus_register_method): Mention the return value
865 :ignore in the docstring.
866
867 2012-02-02 Glenn Morris <rgm@gnu.org>
868
869 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
870
871 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
872 Unconditionally set to t. (Bug#10673)
873 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
874 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
875 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
876
877 2012-02-02 Kenichi Handa <handa@m17n.org>
878
879 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
880 0, do not call append_composite_glyph.
881
882 2012-02-02 Kenichi Handa <handa@m17n.org>
883
884 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
885 NULL (Bug#6988).
886 (x_produce_glyphs): If the component of a composition is a null
887 string, set it->pixel_width to 1 to avoid zero-width glyph.
888
889 2012-02-01 Eli Zaretskii <eliz@gnu.org>
890
891 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
892 first 2 arguments are identical. This makes inserting large
893 output from a subprocess an order of magnitude faster on
894 MS-Windows, where all sbrk'ed memory is always contiguous.
895
896 2012-01-31 Glenn Morris <rgm@gnu.org>
897
898 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
899 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
900 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
901
902 2012-01-29 Glenn Morris <rgm@gnu.org>
903
904 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
905
906 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
907
908 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
909
910 2012-01-28 Chong Yidong <cyd@gnu.org>
911
912 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
913
914 2012-01-26 Chong Yidong <cyd@gnu.org>
915
916 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
917
918 * search.c (Fsearch_forward, Fsearch_backward): Document negative
919 repeat counts (Bug#10507).
920
921 2012-01-26 Glenn Morris <rgm@gnu.org>
922
923 * lread.c (syms_of_lread): Doc fix.
924
925 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
926
927 * coding.c (encode_designation_at_bol): Change return value to
928 EMACS_INT.
929
930 2012-01-25 Chong Yidong <cyd@gnu.org>
931
932 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
933
934 2012-01-21 Chong Yidong <cyd@gnu.org>
935
936 * floatfns.c (Fcopysign): Make the second argument non-optional,
937 since nil is not allowed anyway.
938
939 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
940
941 * process.c (read_process_output): Use p instead of XPROCESS (proc).
942 (send_process): Likewise.
943
944 2012-01-19 Martin Rudalics <rudalics@gmx.at>
945
946 * window.c (save_window_save, Fcurrent_window_configuration)
947 (Vwindow_persistent_parameters): Do not use Qstate.
948 Rewrite doc-strings.
949
950 2012-01-19 Kenichi Handa <handa@m17n.org>
951
952 * character.c (char_width): New function.
953 (Fchar_width, c_string_width, lisp_string_width):
954 Use char_width (Bug#9496).
955
956 2012-01-16 Martin Rudalics <rudalics@gmx.at>
957
958 * window.c (Vwindow_persistent_parameters): New variable.
959 (Fset_window_configuration, save_window_save): Handle persistent
960 window parameters.
961
962 2012-01-14 Eli Zaretskii <eliz@gnu.org>
963
964 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
965 thrashing the stack of the thread. (Bug#9087)
966
967 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
968
969 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
970
971 2012-01-11 Eli Zaretskii <eliz@gnu.org>
972
973 * xdisp.c (rows_from_pos_range): Handle the case where the
974 highlight ends on a newline. (Bug#10464)
975 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
976 he end column for display of highlight that ends on a newline
977 before a R2L line.
978
979 2012-01-11 Glenn Morris <rgm@gnu.org>
980
981 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
982 from load-path also when installation-directory is nil. (Bug#10208)
983
984 2012-01-10 Glenn Morris <rgm@gnu.org>
985
986 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
987
988 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
989 Update template values to be closer to their typical values these days.
990
991 2012-01-09 Eli Zaretskii <eliz@gnu.org>
992
993 * xdisp.c (rows_from_pos_range): Accept additional argument
994 DISP_STRING, and accept any glyph in a row whose object is that
995 string as eligible for mouse highlight. Fixes mouse highlight of
996 display strings from overlays. (Bug#10464)
997
998 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
999
1000 emacs: fix an auto-save permissions race condition (Bug#10400)
1001 * fileio.c (auto_saving_dir_umask): New static var.
1002 (Fmake_directory_internal): Use it.
1003 (do_auto_save_make_dir): Set it, instead of invoking chmod after
1004 creating the directory. The old code temporarily assigns
1005 too-generous permissions to the directory.
1006 (do_auto_save_eh): Clear it.
1007 (Fdo_auto_save): Catch all errors, not just file errors, so
1008 that the var is always cleared.
1009
1010 2012-01-07 Eli Zaretskii <eliz@gnu.org>
1011
1012 * search.c (scan_buffer): Pass character positions to
1013 know_region_cache, not byte positions. (Bug#6540)
1014
1015 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
1016
1017 * w32.c (sys_rename): Report EXDEV when rename of a directory
1018 fails because the target is on another logical disk. (Bug#10284)
1019
1020 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
1021
1022 * xterm.c (x_embed_request_focus): New function.
1023
1024 * xterm.h: Add prototype.
1025
1026 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
1027
1028 2012-01-05 Glenn Morris <rgm@gnu.org>
1029
1030 * emacs.c (emacs_copyright): Update short copyright year to 2012.
1031
1032 2012-01-01 Eli Zaretskii <eliz@gnu.org>
1033
1034 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
1035 Load gnutls_transport_set_lowat only if GnuTLS version is below
1036 2.11.1.
1037 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
1038 GnuTLS versions below 2.11.1.
1039
1040 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
1041
1042 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
1043 to the doc string advising against its use for altering the way
1044 windows are scrolled.
1045
1046 2011-12-28 Kenichi Handa <handa@m17n.org>
1047
1048 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
1049 coding-system ASCII compatible only when it does not produce BOM
1050 on encoding (Bug#10383).
1051
1052 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
1053
1054 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
1055 can scroll.
1056 (create_and_show_popup_menu): Always use menu_position_func for
1057 Gtk3 (Bug#10361).
1058
1059 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
1060
1061 * callint.c (Fcall_interactively): Don't truncate prompt string.
1062
1063 2011-12-23 Eli Zaretskii <eliz@gnu.org>
1064
1065 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
1066 property that ends at ZV, so that the bidi iteration could be
1067 resumed from there (after widening). (Bug#10360)
1068
1069 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
1070
1071 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
1072
1073 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
1074
1075 * nsterm.m (x_free_frame_resources):
1076 Release f->output_data.ns->miniimage.
1077 (ns_index_color): Fix indentation. Do not retain
1078 color_table->colors[i].
1079
1080 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
1081 before returning.
1082
1083 * nsfns.m (x_set_background_color): Assign return value from
1084 ns_index_color to face-background instead of NSColor*.
1085 (ns_implicitly_set_icon_type): Fix indentation.
1086 Change assignment in for loop to comparison.
1087
1088 * emacs.c (ns_pool): New variable.
1089 (main): Assign ns_pool.
1090 (Fkill_emacs): Call ns_release_autorelease_pool.
1091
1092 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
1093 autorelease fdesc, release fdAttrs and tdict.
1094 (ns_get_covering_families): Release charset.
1095 (ns_findfonts): Release NSFontDescriptor created with new.
1096 (ns_uni_to_glyphs): Fix indentation.
1097 (setString): Release attrStr before assigning new value.
1098
1099 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1100
1101 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
1102 and NS_IMPL_COCOA.
1103 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
1104 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
1105
1106 2011-12-18 David Reitter <reitter@cmu.edu>
1107
1108 * nsterm.m (ns_term_init): Subscribe for notifications
1109 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1110 to method trackingNotification in EmacsMenu.
1111
1112 * nsmenu.m (trackingMenu): New variable.
1113 (trackingNotification): New method (from Aquamacs).
1114 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
1115 from Aquamacs (Bug#7030).
1116
1117 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1118
1119 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1120 (symbol_to_nsstring): Fix indentation.
1121 (ns_symbol_to_pb): New function.
1122 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1123 (Fns_rotate_cut_buffers_internal): Remove.
1124 (Fns_store_selection_internal): Rename from
1125 Fns_store_cut_buffer_internal.
1126 (ns_get_foreign_selection, Fx_own_selection_internal)
1127 (Fx_disown_selection_internal, Fx_selection_exists_p)
1128 (Fns_get_selection_internal, Fns_store_selection_internal):
1129 Use ns_symbol_to_pb and check if return value is nil.
1130 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1131 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
1132 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1133 renamed to Sns_store_selection_internal.
1134 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1135 and remove this function.
1136 (ns_handle_selection_clear): Remove, never used.
1137 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1138 here.
1139
1140 2011-12-17 Ken Brown <kbrown@cornell.edu>
1141
1142 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1143 GID is unknown (Bug#10257).
1144
1145 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1146
1147 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1148 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1149 which caused a build failure on GNU/Linux IA-64. This problem was
1150 introduced by my 2011-10-07 patch.
1151
1152 2011-12-15 Juri Linkov <juri@jurta.org>
1153
1154 * image.c (imagemagick_error): New function. (Bug#10112)
1155 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1156 Use `imagemagick_error' where ImageMagick functions return
1157 `MagickFalse'.
1158 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1159 proper order.
1160
1161 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1162
1163 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1164 fill background (Bug#8992).
1165
1166 2011-12-13 Martin Rudalics <rudalics@gmx.at>
1167
1168 * window.c (Vwindow_combination_resize)
1169 (Vwindow_combination_limit): Use t instead of non-nil in
1170 doc-strings.
1171 (Vrecenter_redisplay): Add first sentence of doc-string on
1172 separate line.
1173 (Frecenter): Fix doc-string typo.
1174
1175 2011-12-11 Kenichi Handa <handa@m17n.org>
1176
1177 * coding.c (Funencodable_char_position): Pay attention to the
1178 buffer text relocation (Bug#9389).
1179
1180 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1181
1182 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1183 gtk_init (Bug#10100).
1184
1185 2011-12-10 Eli Zaretskii <eliz@gnu.org>
1186
1187 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1188 IT->string is nil. (Bug#10263)
1189
1190 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1191
1192 * nsterm.h (x_free_frame_resources): Declare.
1193
1194 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1195 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1196
1197 * nsterm.h (ns_get_defaults_value): Declare.
1198
1199 * nsterm.m (ns_default): Call ns_get_defaults_value.
1200
1201 2011-12-09 Eli Zaretskii <eliz@gnu.org>
1202
1203 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1204 (Bug#10170)
1205
1206 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1207
1208 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1209 that where the value of an _OBJC_* symbol points to is in the .bss
1210 section (Bug#10240).
1211
1212 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1213
1214 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
1215 after the loop to call ccl_driver at least once (Bug#8619).
1216
1217 2011-12-08 Kenichi Handa <handa@m17n.org>
1218
1219 * ftfont.c (get_adstyle_property): Fix previous change
1220 (Bug#10233).
1221
1222 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
1223
1224 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1225 dirs from the default value of EMACSLOADPATH (bug#10208).
1226
1227 2011-12-07 Glenn Morris <rgm@gnu.org>
1228
1229 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1230 installation and source directories as well. (Bug#10208)
1231
1232 2011-12-06 Chong Yidong <cyd@gnu.org>
1233
1234 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1235
1236 2011-12-06 Glenn Morris <rgm@gnu.org>
1237
1238 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1239 as an error, not just -1. (Bug#10217)
1240
1241 2011-12-05 Chong Yidong <cyd@gnu.org>
1242
1243 * keyboard.c (process_special_events): New function.
1244 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1245
1246 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1247
1248 * coding.c (encode_designation_at_bol): Don't use uninitialized
1249 local variable (Bug#9318).
1250
1251 2011-12-05 Kenichi Handa <handa@m17n.org>
1252
1253 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1254 return Qnil (Bug#8046, Bug#10193).
1255
1256 2011-12-05 Kenichi Handa <handa@m17n.org>
1257
1258 * coding.c (encode_designation_at_bol): New args charbuf_end and
1259 dst. Return the number of produced bytes. Callers changed.
1260 (coding_set_source): Return how many bytes coding->source was
1261 relocated.
1262 (coding_set_destination): Return how many bytes
1263 coding->destination was relocated.
1264 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
1265 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
1266
1267 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1268
1269 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1270 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1271 macro (Bug#9318).
1272
1273 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1274
1275 The following changes are to fix Bug#9318.
1276
1277 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1278 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1279 (encode_coding_iso_2022, encode_coding_sjis)
1280 (encode_coding_big5, encode_coding_charset): Use the above macros.
1281
1282 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
1283
1284 * lisp.h (process_quit_flag): Fix external declaration.
1285
1286 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1287
1288 Don't macro-inline non-performance-critical code.
1289 * eval.c (process_quit_flag): New function.
1290 * lisp.h (QUIT): Use it.
1291
1292 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1293
1294 * nsfns.m (get_geometry_from_preferences): New function.
1295 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1296
1297 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1298
1299 * emacs.c (Qkill_emacs): Define.
1300 (syms_of_emacs): Initialize it.
1301 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1302 Qquit_flag to `kill-emacs' instead.
1303 (quit_throw_to_read_char): Add parameter `from_signal'.
1304 All callers changed. Call Fkill_emacs if requested and safe.
1305 * lisp.h (QUIT): Call Fkill_emacs if requested.
1306
1307 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1308
1309 * widget.c (update_wm_hints): Return if wmshell is null.
1310 (widget_update_wm_size_hints): New function.
1311
1312 * widget.h (widget_update_wm_size_hints): Declare.
1313
1314 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1315 widget_update_wm_size_hints (Bug#10104).
1316
1317 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1318
1319 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1320 before a newline, prepare the bidi iterator for consuming the
1321 newline, and keep the current paragraph direction. (Bug#10183)
1322 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1323
1324 2011-12-02 Juri Linkov <juri@jurta.org>
1325
1326 * search.c (Fword_search_regexp): New Lisp function created from
1327 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1328 (Fword_search_backward, Fword_search_forward)
1329 (Fword_search_backward_lax, Fword_search_forward_lax):
1330 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1331 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1332
1333 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1334
1335 * fileio.c (Finsert_file_contents): Move after-change-function call
1336 to before the "handled:" label, since all "goto handled" appear in
1337 cases where the *-change-functions have already been properly called
1338 (bug#10117).
1339
1340 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1341
1342 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1343 waiting for input. (Bug#10169)
1344
1345 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1346
1347 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1348 verifies glyph row's hash code--we have just reallocated the
1349 glyphs, so their contents can be complete garbage. (Bug#10164)
1350
1351 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1352
1353 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1354
1355 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1356
1357 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1358 attributes are tested _before_ calling verify_row_hash, to protect
1359 against GCC re-ordering of the tests. (Bug#10164)
1360
1361 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1362
1363 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1364
1365 * xterm.c (handle_one_xevent): Only set async_visible and friends
1366 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1367 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1368 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1369
1370 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1371
1372 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1373 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1374 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1375 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1376 All uses changed to use GCPRO1 etc.
1377 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1378 Revert to old implementation (i.e., before 2011-03-11).
1379
1380 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1381
1382 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1383 of scroll runs so as to avoid assigning disabled bogus rows and
1384 unnecessary graphics copy operations.
1385
1386 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1387
1388 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1389 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1390 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1391 (malloc, free, realloc, calloc): Redirect to e_* only when
1392 compiling Emacs.
1393
1394 * lisp.h (GCTYPEBITS): Move before first use.
1395 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1396 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1397 this macro definition.
1398
1399 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1400 _MSC_VER.
1401
1402 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1403
1404 * gtkutil.c (xg_create_frame_widgets):
1405 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1406 present with Gtk+ 2.0.
1407
1408 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1409
1410 * fileio.c (Finsert_file_contents): Undo previous change; see
1411 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1412
1413 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1414
1415 Rename locals to avoid shadowing.
1416 * fileio.c (Finsert_file_contents):
1417 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1418 * process.c (wait_reading_process_output):
1419 Rename inner 'proc' to 'p' to avoid shadowing.
1420 Indent for consistency with usual Emacs style.
1421
1422 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1423
1424 * xdisp.c (redisplay_window): If cursor row is not fully visible
1425 after recentering, and scroll-conservatively is set to a large
1426 number, scroll window by a few more lines to make the cursor fully
1427 visible and out of scroll-margin. (Bug#10105)
1428 (start_display): Don't move to the next line if the display should
1429 start at a newline that is part of a display vector or an overlay
1430 string. (Bug#10119)
1431
1432 2011-11-24 Juri Linkov <juri@jurta.org>
1433
1434 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1435 after the `MagickPingImage' call. (Bug#10112)
1436
1437 2011-11-23 Chong Yidong <cyd@gnu.org>
1438
1439 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1440
1441 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1442
1443 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1444 making another buffer current. (Bug#10114)
1445
1446 2011-11-23 Glenn Morris <rgm@gnu.org>
1447
1448 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1449
1450 2011-11-23 Chong Yidong <cyd@gnu.org>
1451
1452 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1453 using it (Bug#5984).
1454
1455 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1456
1457 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1458 and header-lines, as they don't have one computed for them.
1459 (Bug#10098)
1460
1461 * .gdbinit (prow): Make displayed values more self-explaining.
1462 Add row's hash code.
1463
1464 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1465
1466 * process.c (wait_reading_process_output): Fix asynchrounous
1467 GnuTLS socket handling on some versions of the GnuTLS library.
1468 (wait_reading_process_output): Add comment and URL.
1469
1470 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1471
1472 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1473
1474 2011-11-21 Chong Yidong <cyd@gnu.org>
1475
1476 * window.c (Fnext_window, Fprevious_window): Doc fix.
1477
1478 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1479
1480 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1481
1482 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1483
1484 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1485
1486 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1487
1488 * window.c (Fset_window_combination_limit): Rename argument
1489 STATUS to LIMIT.
1490 (Vwindow_combination_limit): Remove "status" from doc-string.
1491
1492 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1493
1494 * m/ibms390.h: Remove.
1495 * m/ibms390x.h: Don't include "ibms390.h".
1496
1497 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1498
1499 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1500 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1501
1502 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1503
1504 * casetab.c (Fset_case_table):
1505 * charset.c (Fcharset_after): Fix typos.
1506
1507 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1508
1509 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1510 Otherwise, valgrind does not work on some platforms.
1511 Problem reported by Andreas Schwab in
1512 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1513 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1514 is set, removing the need for VIRT_ADDRESS_VARIES.
1515 (PURE_P): Use a more-efficient implementation that needs just one
1516 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1517 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1518 to 4 (xorl, subq, cmpq, setbe).
1519 * alloc.c (pure): Always extern now, since that's the
1520 VIRT_ADDR_VARIES behavior.
1521 (PURE_POINTER_P): Use a single comparison, not two, for
1522 consistency with the new puresize.h.
1523 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1524 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1525 Remove VIRT_ADDR_VARIES no longer needed.
1526
1527 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1528
1529 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1530 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1531 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1532 behave as if the cursor position were at the window margin.
1533
1534 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1535 and the cursor position is out of bounds, behave as if the cursor
1536 position were at the window margin. (Bug#10075)
1537
1538 2011-11-18 Chong Yidong <cyd@gnu.org>
1539
1540 * window.c (Fwindow_combination_limit): Make first argument
1541 non-optional, since it is meaningless for live windows like the
1542 selected window.
1543
1544 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1545
1546 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1547
1548 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1549
1550 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1551 (graft_intervals_into_buffer): Simplify.
1552
1553 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1554
1555 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1556 hash values of the two rows.
1557 (copy_row_except_pointers): Preserve the used[] arrays and the
1558 hash values of the two rows. (Bug#10035)
1559 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1560
1561 * xdisp.c (row_hash): New function, body extracted from
1562 compute_line_metrics.
1563 (compute_line_metrics): Call row_hash, instead of computing the
1564 hash code inline.
1565
1566 * dispnew.c (verify_row_hash): Call row_hash for computing the
1567 hash code of a row, instead of duplicating code from xdisp.c.
1568
1569 * dispextern.h (row_hash): Add prototype.
1570
1571 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1572
1573 * frame.c (delete_frame): Don't delete the terminal when the last
1574 X frame is closed if emacs is built with GTK toolkit.
1575
1576 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1577
1578 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1579
1580 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1581
1582 * window.c (Vwindow_splits): Rename to
1583 Vwindow_combination_resize. Suggested by Juri Linkov.
1584 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1585 of Vwindow_splits.
1586
1587 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1588
1589 * nsfns.m (Fns_font_name):
1590 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1591
1592 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1593
1594 * window.h (window): Rename slot "nest" to "combination_limit".
1595 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1596 (Fset_window_nest): Rename to Fset_window_combination_limit.
1597 (Vwindow_nest): Rename to Vwindow_combination_limit.
1598 (recombine_windows, make_parent_window, make_window)
1599 (Fsplit_window_internal, saved_window)
1600 (Fset_window_configuration, save_window_save): Rename all
1601 occurrences of window_nest to window_combination_limit.
1602
1603 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1604
1605 * image.c (imagemagick_load_image): Fix typo.
1606
1607 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1608
1609 * xdisp.c (display_line): Move the call to
1610 highlight_trailing_whitespace before the call to
1611 compute_line_metrics, since the latter needs to see the final
1612 faces of all the glyphs to compute ROW's hash value.
1613 Fixes assertion violations in row_equal_p. (Bug#10035)
1614
1615 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1616
1617 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1618 just return (bug#10044).
1619
1620 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1621
1622 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1623 with user-defined heap size. Bump the default size of the temacs
1624 heap to 27MB, to avoid memory warning when running temacs.
1625 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1626
1627 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1628 current_matrix and desired_matrix. (Bug#9990)
1629 (verify_row_hash) [XASSERTS]: New function.
1630 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1631 that the hash value of glyph rows is correct.
1632
1633 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1634
1635 * window.h (window): Remove splits slot.
1636 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1637 (Fdelete_other_windows_internal, make_parent_window)
1638 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1639 (Fset_window_configuration, save_window_save): Don't deal with
1640 split status of windows.
1641 (saved_window): Remove splits slot.
1642 (Vwindow_splits): Rewrite doc-string.
1643
1644 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1645
1646 * xfns.c (unwind_create_frame):
1647 * nsfns.m (unwind_create_frame):
1648 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1649 Vframe_list (Bug#9999).
1650
1651 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1652
1653 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1654
1655 2011-11-11 Kenichi Handa <handa@m17n.org>
1656
1657 * callproc.c (Fcall_process): Set the member dst_multibyte of
1658 process_coding.
1659
1660 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1661
1662 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1663 avoid a crash (bug#9496).
1664
1665 2011-11-09 Chong Yidong <cyd@gnu.org>
1666
1667 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1668 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1669
1670 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1671
1672 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1673
1674 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1675
1676 Avoid some portability problems by eschewing 'extern inline' functions.
1677 The trivial performance wins aren't worth the portability hassles; see
1678 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1679 et seq.
1680 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1681 (window_box_width, window_box_left, window_box_left_offset)
1682 (window_box_right, window_box_right_offset): Undo previous change,
1683 by removing the "extern"s.
1684 * intervals.c (adjust_intervals_for_insertion)
1685 (adjust_intervals_for_deletion): Undo previous change,
1686 making these static again.
1687 (offset_intervals, temp_set_point_both, temp_set_point)
1688 (copy_intervals_to_string): No longer inline.
1689 * xdisp.c (window_text_bottom_y, window_box_width)
1690 (window_box_height, window_box_left_offset)
1691 (window_box_right_offset, window_box_left, window_box_right)
1692 (window_box): No longer inline.
1693
1694 2011-11-08 Chong Yidong <cyd@gnu.org>
1695
1696 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1697 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1698 Signal an error if not a live window.
1699 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1700 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1701
1702 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1703
1704 * lisp.h (syms_of_abbrev): Remove declaration.
1705 Reported by CHENG Gao <chenggao@royau.me>.
1706
1707 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1708
1709 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1710 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1711 of temacs in GUI mode.
1712
1713 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1714
1715 * window.h: Declare delete_all_child_windows instead of
1716 delete_all_subwindows.
1717 * window.c (Fwindow_nest, Fset_window_nest)
1718 (Fset_window_new_total, Fset_window_new_normal)
1719 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1720 (delete_all_subwindows): Rename to delete_all_child_windows.
1721 (Fdelete_other_windows_internal, Fset_window_configuration):
1722 Call delete_all_child_windows instead of delete_all_subwindows.
1723 * frame.c (delete_frame): Call delete_all_child_windows instead
1724 of delete_all_subwindows.
1725
1726 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1727
1728 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1729 This is also needed for porting to any host where GC_MARK_STACK is
1730 not GC_MAKE_GCPROS_NOOPS.
1731 (which_symbols): Use it.
1732
1733 2011-11-07 Kenichi Handa <handa@m17n.org>
1734
1735 * coding.c (coding_set_destination): Check coding->src_pos only
1736 when coding->src_object is a buffer (bug#9910).
1737
1738 * process.c (send_process): Set the member src_multibyte of coding
1739 to 0 (bug#9911) when sending a unibyte text.
1740
1741 * callproc.c (Fcall_process): Set the member src_multibyte of
1742 process_coding to 0 (bug#9912).
1743
1744 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1745
1746 * xmenu.c (cleanup_widget_value_tree): New function.
1747 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1748 calling free_menubar_widget_value_tree directly (Bug#9830).
1749
1750 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1751
1752 Fix some portability problems with 'inline'.
1753 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1754 (window_box_width, window_box_left, window_box_left_offset)
1755 (window_box_right, window_box_right_offset): Declare extern.
1756 Otherwise, these inline functions do not conform to C99 and
1757 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1758 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1759 * intervals.c (adjust_intervals_for_insertion)
1760 (adjust_intervals_for_deletion): Now extern, because otherwise the
1761 extern inline functions 'offset_intervals' couldn't refer to it.
1762 (static_offset_intervals): Remove.
1763 (offset_intervals): Rewrite using the old contents of
1764 static_offset_intervals. The old version didn't conform to C99
1765 because an extern inline function contained a reference to an
1766 identifier with static linkage.
1767
1768 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1769
1770 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1771 GC.
1772
1773 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1774
1775 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1776 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1777 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1778 return Qleft_to_right.
1779
1780 2011-11-06 Chong Yidong <cyd@gnu.org>
1781
1782 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1783 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1784 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1785 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1786 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1787 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1788 (Fwindow_vscroll): Doc fix.
1789 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1790 argument, since it makes no sense to pass a live window and for
1791 consistency with window-child.
1792
1793 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1794
1795 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1796 support MSVC.
1797
1798 2011-11-05 Jason Rumney <jasonr@gnu.org>
1799
1800 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1801 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1802 fonts (Bug#6029).
1803 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1804 bitwise arithmetic preventing use of unicode-sip and non-truetype
1805 opentype fonts.
1806
1807 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1808
1809 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1810 "emacs"-only part.
1811
1812 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1813 initialization code to keep similarity to xfns.c after changes
1814 from 2011-11-05.
1815
1816 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1817
1818 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1819 (unwind_create_frame): New function (Bug#9943).
1820 (Fx_create_frame): Restructure code to be more similar to the one in
1821 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1822 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1823 Move terminal->reference_count++ just before making the frame official
1824 (Bug#9943).
1825
1826 * nsterm.m (x_free_frame_resources): New function.
1827 (x_destroy_window): Move code to x_free_frame_resources.
1828
1829 * xfns.c (unwind_create_frame): Fix comment.
1830 (Fx_create_frame, x_create_tip_frame):
1831 Move terminal->reference_count++ just before making the frame
1832 official. Move initialization of image_cache_refcount and
1833 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1834
1835 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1836
1837 Support MSVC build with newer versions of Visual Studio.
1838 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1839 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1840 nt/gmake.defs.
1841
1842 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1843 which are not supported by MSVC.
1844 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1845 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1846 bitfields.
1847 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1848 types in bitfields.
1849 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1850
1851 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1852
1853 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1854
1855 Support MSVC build with newer versions of Visual Studio.
1856 * w32.c: Don't include w32api.h for MSVC.
1857 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1858
1859 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1860 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1861 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1862 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1863 e_* cousins.
1864 (alloca) [_MSC_VER]: Define to _alloca.
1865
1866 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1867
1868 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1869
1870 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1871
1872 * xdisp.c (note_mouse_highlight): If either of
1873 previous/next-single-property-change returns nil, treat that as
1874 the beginning or the end of the buffer. (Bug#9955)
1875
1876 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1877
1878 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1879 label is not null (Bug#9951).
1880 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1881 may be NULL.
1882
1883 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1884
1885 * window.c (Fwindow_body_size): Mention in the doc string that the
1886 return value is in frame's canonical units. (Bug#9949)
1887
1888 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1889
1890 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1891
1892 * w32fns.c (unwind_create_frame): If needed, free the glyph
1893 matrices of the partially constructed frame. (Bug#9943)
1894 * xfns.c (unwind_create_frame): Likewise.
1895
1896 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1897
1898 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1899 Don't stop backward scan on the continuation glyph, even though
1900 its CHARPOS is positive.
1901 (mouse_face_from_buffer_pos, note_mouse_highlight):
1902 Rename cover_string to disp_string.
1903
1904 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1905
1906 * window.c (temp_output_buffer_show): Don't use
1907 Vtemp_buffer_show_specifiers.
1908 (Vtemp_buffer_show_specifiers): Remove unused variable.
1909
1910 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1911
1912 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1913 past the beginning of the current glyph matrix.
1914
1915 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1916
1917 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1918 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1919 HAVE_GTK3 (Bug#9869).
1920
1921 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1922 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1923
1924 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1925
1926 * xterm.c: Declare x_handle_net_wm_state to return int.
1927 (handle_one_xevent): Check if we are iconified but don't have
1928 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1929 (get_current_wm_state): Return non-zero if not hidden,
1930 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1931 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1932 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1933 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1934
1935 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1936
1937 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1938 so that this new function doesn't get optimized away by a
1939 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1940
1941 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1942
1943 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1944
1945 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1946
1947 Fix the `xbytecode' command.
1948 * .gdbinit (xprintbytestr): New command.
1949 (xwhichsymbols): Rename from `which'; all callers changed.
1950 (xbytecode): Print the byte-code string as well.
1951
1952 2011-10-29 Kim Storm <storm@cua.dk>
1953
1954 * alloc.c (which_symbols): New function.
1955
1956 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1957
1958 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1959 line. (Bug#9903)
1960
1961 2011-10-29 Glenn Morris <rgm@gnu.org>
1962
1963 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1964 Not clear what it was for, and it causes various bugs. (Bug#9839)
1965
1966 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1967
1968 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1969 possible random value that matches one of those tested as
1970 condition to clear the mouse face.
1971
1972 2011-10-28 Chong Yidong <cyd@gnu.org>
1973
1974 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1975
1976 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1977
1978 * window.c (make_window): Initialize phys_cursor_on_p.
1979
1980 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1981
1982 * lisp.h (struct Lisp_Symbol): Update comments.
1983
1984 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1985
1986 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1987
1988 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1989
1990 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1991 <oslsachem@gmail.com> for helping to debug this.
1992
1993 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1994 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1995 (g_b_init_get_glyph_outline_w): New static variables.
1996 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1997 (GetGlyphOutlineW_Proc): New typedefs.
1998 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1999 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
2000 New functions.
2001 (w32font_open_internal, compute_metrics):
2002 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
2003 instead of calling the "wide" APIs directly.
2004
2005 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
2006
2007 * w32.h (syms_of_w32font): Add prototype.
2008
2009 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
2010
2011 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
2012 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
2013 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
2014 (Fmove_to_window_line): Doc fix.
2015
2016 2011-10-27 Chong Yidong <cyd@gnu.org>
2017
2018 * process.c (make_process): Set gnutls_state to NULL.
2019
2020 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
2021 non-NULL, regardless of GNUTLS_INITSTAGE.
2022 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
2023 an error. Set process slots as soon as we allocate them.
2024
2025 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
2026
2027 2011-10-27 Chong Yidong <cyd@gnu.org>
2028
2029 * gnutls.c (emacs_gnutls_deinit): New function.
2030 Deallocate credentials structures as well as calling gnutls_deinit.
2031 (Fgnutls_deinit, Fgnutls_boot): Use it.
2032
2033 * process.c (make_process): Initialize GnuTLS credentials to NULL.
2034 (deactivate_process): Call emacs_gnutls_deinit.
2035
2036 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
2037
2038 * image.c (x_create_x_image_and_pixmap):
2039 * w32.c (sys_rename, w32_delayed_load):
2040 * w32font.c (fill_in_logfont):
2041 * w32reg.c (x_get_string_resource): Silence compiler warnings.
2042
2043 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
2044
2045 * w32fns.c (w32_default_color_map): New function,
2046 extracted from Fw32_default_color_map.
2047 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
2048
2049 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
2050
2051 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
2052
2053 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
2054
2055 * keyboard.c (test_undefined): New function (bug#9751).
2056 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
2057
2058 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
2059
2060 * sysdep.c (init_sys_modes): Fix the check for the controlling
2061 terminal (Bug#6649).
2062
2063 2011-10-20 Eli Zaretskii <eliz@gnu.org>
2064
2065 * dispextern.h (struct bidi_it): New member next_en_type.
2066
2067 * bidi.c (bidi_line_init): Initialize the next_en_type member.
2068 (bidi_resolve_explicit_1): When next_en_pos is valid for the
2069 current character, check also for next_en_type being WEAK_EN.
2070 (bidi_resolve_weak): Don't enter the expensive loop if the current
2071 position is before next_en_pos. Record the bidi type of the first
2072 non-ET, non-BN character we find, in addition to its position.
2073 (bidi_level_of_next_char): Invalidate next_en_type when
2074 next_en_pos is over-stepped.
2075
2076 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
2077
2078 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
2079 * editfns.c: Rewrite current-time-zone so that it invokes
2080 the equivalent of (format-time-string "%Z") to get the time zone name.
2081 This fixes a bug when the time zone name contains characters that
2082 need converting from the system time locale to Emacs internal format.
2083 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
2084 that patch fixed format-time-string to do the conversion, but
2085 I forgot to fix current-time-zone.
2086 (format_time_string): New function, containing most of
2087 what Fformat_time_string used to contain.
2088 (Fformat_time_string): Rewrite in terms of format_time_string.
2089 This doesn't change this function's behavior.
2090 (current-time-zone): Rewrite to use format_time_string.
2091 This fixes the bug reported by Michael Schierl in
2092 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
2093 Jason Rumney's 2007-06-07 change worked around this bug, but
2094 didn't fix it.
2095 * systime.h (tzname, timezone): Remove no-longer-used declarations.
2096
2097 2011-10-19 Eli Zaretskii <eliz@gnu.org>
2098
2099 * xdisp.c (start_display): If the character at POS is displayed
2100 via a display vector, reset IT->current.dpvec_index to zero.
2101 (try_window_reusing_current_matrix): If a line ends in a display
2102 vector or the next line starts in a display vector, continue
2103 redrawing the window even though the character position of
2104 start_row was reached.
2105 (Bug#9771, part 2)
2106
2107 2011-10-18 Chong Yidong <cyd@gnu.org>
2108
2109 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2110 with nobreak-char-display too.
2111
2112 2011-10-18 Eli Zaretskii <eliz@gnu.org>
2113
2114 Fix part 3 of bug#9771.
2115 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2116 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2117 non-neutral characters if the current character is a paragraph
2118 separator (a.k.a. Newline). This avoids running the same
2119 expensive loop twice, once when we consume the preceding newline
2120 and the other time when the line actually needs to be displayed.
2121 Avoid the loop when we see neutrals on the base embedding level
2122 following a character whose directionality is the same as the
2123 paragraph's. This avoids running the expensive loop when a line
2124 ends in a long sequence of neutrals, like control characters.
2125 Add assertion against STRONG_AL type. Slightly rearrange code
2126 that determines the type of a neutral given the first non-neutral
2127 that follows it.
2128 (bidi_level_of_next_char): Set next_en_pos to zero when
2129 invalidating its info.
2130
2131 2011-10-17 Eli Zaretskii <eliz@gnu.org>
2132
2133 * xdisp.c (push_display_prop): Determine whether to record string
2134 or buffer position by IT->string, not by IT->method. Allow
2135 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
2136 (move_it_vertically_backward): Don't look for character position
2137 immediately after the newline when in a continuation line.
2138 (Bug#9771, part 1)
2139
2140 2011-10-15 Martin Rudalics <rudalics@gmx.at>
2141
2142 * window.c (coordinates_in_window): Rewrite and delabelize
2143 vertical border check. (Bug#5357) (Bug#9618)
2144
2145 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2146
2147 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2148 errors in XSetWindowBorder (bug#9310).
2149
2150 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2151
2152 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2153 avoid crash when xmalloc overrun checking is enabled.
2154
2155 2011-10-13 Eli Zaretskii <eliz@gnu.org>
2156
2157 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2158 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2159 cursor motion with <left> and <right> arrow keys.
2160
2161 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2162 some callers set that themselves.
2163
2164 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2165
2166 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2167 display string and the previous row comes from the same string and
2168 is empty. (Bug#9739) (Bug#9738)
2169
2170 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2171
2172 * doc.c (get_doc_string): Encode file name (bug#9735).
2173
2174 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2175
2176 * bidi.c (bidi_level_of_next_char):
2177 * xdisp.c (get_visually_first_element): Remove old incorrect
2178 comments regarding the Unicode Line Separator character.
2179
2180 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2181
2182 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2183
2184 * alloc.c (Fgc_status): Do not access beyond zombies array
2185 boundary if nzombies > MAX_ZOMBIES.
2186 * alloc.c (dump_zombies): Add missing format specifier.
2187
2188 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2189
2190 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2191 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2192
2193 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2194 Some packages use them to denote characters with modifiers.
2195
2196 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2197
2198 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2199 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2200 matching a pp-number. Rename parameter var to var1.
2201
2202 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2203
2204 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2205
2206 2011-10-08 Glenn Morris <rgm@gnu.org>
2207
2208 * callint.c (Fcall_interactively): Give a more explicit error for the
2209 'c' case with a non-character input. (Bug#8479)
2210
2211 2011-10-08 Eli Zaretskii <eliz@gnu.org>
2212
2213 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2214 lines.
2215 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2216 lines that are hscrolled on the left.
2217
2218 * dispnew.c (buffer_posn_from_coords): Account for a possible
2219 presence of header-line. (Bug#4426)
2220
2221 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2222
2223 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2224 Don't advertise functionality which we discourage or doesn't work.
2225
2226 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2227
2228 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2229 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2230 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2231 this makes Emacs dump core during garbage collection on rare
2232 occasions. sizeof is obviously inferior to offsetof here, so
2233 stick with offsetof.
2234 (GC_POINTER_ALIGNMENT): New macro.
2235 (mark_memory): Omit 3rd (offset) arg; caller changed.
2236 Don't assume EMACS_INT alignment is the same as pointer alignment.
2237
2238 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2239
2240 * keyboard.c (read_key_sequence_remapped): New var.
2241 (read_key_sequence): Compute remapping in the right buffer.
2242 (command_loop_1): Use read_key_sequence's remapping directly.
2243
2244 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2245
2246 * dired.c (file_name_completion): Don't expand file name.
2247 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2248 before checking file name handler.
2249
2250 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2251 they've been requested explicitly (bug#9591).
2252
2253 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
2254
2255 * keymap.c (Fsingle_key_description): Use make_specified_string
2256 instead of build_string to build string from push_key_description.
2257 (Bug#5193)
2258
2259 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2260
2261 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2262 This fixes a Y2038 bug on 64-bit hosts.
2263 * buffer.c (reset_buffer):
2264 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2265 (Fclear_buffer_auto_save_failure):
2266 Use 0, not -1, to represent an unset failure time, since time_t
2267 might not be signed.
2268
2269 Remove dependency on glibc malloc internals.
2270 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2271 Move back here from lisp.h, but with their new implementations.
2272 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2273 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2274 * charset.c (charset_table_init): New static var.
2275 (syms_of_charset): Use it instead of xmalloc. This removes a
2276 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2277 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2278 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2279 Move back to alloc.c.
2280 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2281 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2282
2283 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2284
2285 * nsterm.m (windowDidResize): Call x_set_window_size only when
2286 ns_in_resize is true. Otherwise set pixelwidth/height and
2287 call change_frame_size (Bug#9628).
2288
2289 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2290
2291 Port --enable-checking=all to Fedora 14 x86-64.
2292 * charset.c (syms_of_charset): Also account for glibc malloc's
2293 internal overhead when calculating the initial malloc maximum.
2294
2295 Port --enable-checking=all to Fedora 14 x86.
2296 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2297 Move to lisp.h.
2298 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2299 (overrun_check_realloc, overrun_check_free):
2300 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2301 That way, xmalloc returns a properly-aligned pointer even if
2302 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2303 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2304 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2305 into account when calculating the initial malloc maximum.
2306 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2307 Move here from alloc.c, so that charset.c can use it too.
2308 Properly align; the old code wasn't right for common 32-bit hosts
2309 when configured with --enable-checking=all.
2310 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2311 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2312
2313 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2314
2315 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2316 use EDOM.
2317
2318 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2319
2320 * xdisp.c (compute_display_string_end): If there's no display
2321 string at CHARPOS, return -1.
2322
2323 * bidi.c (bidi_fetch_char): When compute_display_string_end
2324 returns a negative value, treat the character as a normal
2325 character not covered by a display string. (Bug#9624)
2326
2327 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2328
2329 * lread.c (Fread_from_string): Fix typo in docstring.
2330
2331 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2332
2333 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2334 newline, reseat the iterator instead of bidi-iterating there one
2335 character at a time. (Bug#9610)
2336 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2337 TO_CHARPOS if the bidi iterator is at base embedding level.
2338
2339 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2340
2341 * lread.c (readevalloop): Use correct code for NBSP.
2342 (read1): Likewise. (Bug#9608)
2343
2344 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2345
2346 * dbusbind.c (Fdbus_register_signal): When service is not
2347 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2348
2349 2011-09-25 Glenn Morris <rgm@gnu.org>
2350
2351 * buffer.c (truncate-lines): Doc fix.
2352
2353 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2354
2355 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2356 (Fset_window_next_buffers): Doc fix.
2357
2358 2011-09-24 Glenn Morris <rgm@gnu.org>
2359
2360 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2361
2362 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2363
2364 Fix minor problems found by static checking.
2365 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2366 * indent.c (Fvertical_motion): Fix == vs = typo.
2367
2368 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2369
2370 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2371 Default value is now t. Doc fix.
2372
2373 * indent.c (Fvertical_motion): Compute and apply the overshoot
2374 logic when moving up, not only when moving down. Fix the
2375 confusing name and values of the it_overshoot_expected variable;
2376 logic changes accordingly. (Bug#9254) (Bug#9549)
2377
2378 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2379 CHARPOS is covered by a display string which includes newlines.
2380 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2381 is covered by a display string with embedded newlines.
2382
2383 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2384
2385 * dbusbind.c (Fdbus_register_signal): Add match rule to
2386 Vdbus_registered_objects_table. (Bug#9581)
2387 (Fdbus_register_method, Vdbus_registered_objects_table):
2388 Fix docstring.
2389
2390 2011-09-24 Jim Meyering <meyering@redhat.com>
2391
2392 do not ignore write error for any output size
2393 The previous change was incomplete.
2394 While it makes emacs --batch detect the vast majority of stdout
2395 write failures, errors were still ignored whenever the output size is
2396 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2397 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2398 && echo FAIL: ignored write error
2399 FAIL: ignored write error
2400 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2401 && echo FAIL: ignored write error
2402 FAIL: ignored write error
2403 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2404
2405 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2406
2407 * emacs.c (Fkill_emacs): In noninteractive mode exit
2408 non-successfully if a write error occurred on stdout. (Bug#9574)
2409
2410 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2411
2412 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2413 the xassert test.
2414
2415 * dispextern.h (struct it): Update the comment documenting what
2416 can it->OBJECT be.
2417
2418 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2419
2420 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2421 a display string, extend search for cursor position to end of row.
2422 (find_row_edges): If the row ends in a newline from a display
2423 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2424 Handle the case of a display string with multiple newlines.
2425 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2426 non-empty line. Fixes confusing cursor motion with arrow keys at
2427 the beginning of a line that starts with whitespace.
2428
2429 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2430
2431 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2432 (bug#9493).
2433
2434 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2435
2436 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2437 boolean (Bug#9154).
2438
2439 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2440
2441 * xdisp.c (display_line): Record maximum and minimum buffer
2442 positions even if no glyphs were produced (e.g., by a zero-width
2443 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2444 buffer positions that will be removed from the glyph row because
2445 they don't fit.
2446 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2447 column is beyond frame width: don't subtract 1 "pixel" when
2448 computing width of the stretch.
2449 (reseat_at_next_visible_line_start): Undo the change made on
2450 2011-09-17 that saved paragraph information and restored it after
2451 the call to `reseat'. (Bug#9545)
2452
2453 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2454
2455 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2456 and turn window cursor on if cleared (Bug#9415).
2457
2458 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2459
2460 * search.c (boyer_moore): Take unibyte characters from pattern
2461 literally. (Bug#9458)
2462
2463 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2464
2465 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2466
2467 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2468
2469 Fix minor problem found by static checking.
2470 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2471 initialized, to pacify gcc -Wuninitialized.
2472
2473 * fileio.c: Report proper errno when syscall falls.
2474 (Finsert_file_contents): Save and restore errno,
2475 so that report_file_error outputs the correct diagnostic.
2476 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2477
2478 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2479
2480 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2481
2482 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2483
2484 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2485 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2486
2487 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2488
2489 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2490 about the current paragraph and restore it after the call to reseat.
2491
2492 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2493 (bidi_find_paragraph_start): Search back for paragraph beginning
2494 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2495 (bidi_move_to_visually_next): Only trigger paragraph-related
2496 computations when the last character is a newline or at EOB, not
2497 just any NEUTRAL_B. (Bug#9470)
2498
2499 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2500 truncated lines if point is covered by a display string. (Bug#9524)
2501
2502 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2503
2504 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2505 (cons_to_x_long): New function.
2506 (lisp_data_to_selection_data): Use it. Correct the test for
2507 short-versus-long data; it was negated. Break out of vector
2508 loop, for efficiency, when a long datum is discovered.
2509
2510 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2511
2512 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2513
2514 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2515
2516 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2517 GCC PR/17406) by declaring this function with external scope.
2518
2519 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2520
2521 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2522 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2523
2524 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2525
2526 * editfns.c (Fformat): Correctly handle text properties on "%%".
2527
2528 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2529
2530 * xterm.c (x_draw_composite_glyph_string_foreground):
2531 * w32term.c (x_draw_composite_glyph_string_foreground):
2532 * term.c (encode_terminal_code):
2533 * composite.c (composition_update_it, get_composition_id):
2534 * xdisp.c (get_next_display_element)
2535 (fill_composite_glyph_string): Add comments about special meaning
2536 of TAB characters in a composition.
2537
2538 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2539
2540 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2541 This occurs when processing a multibyte format.
2542 Problem reported by Wolfgang Jenker.
2543
2544 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2545
2546 * xdisp.c (try_cursor_movement): Only check for exact match if
2547 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2548
2549 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2550
2551 Remove unused external symbols.
2552 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2553 * xdisp.c (calc_pixel_width_or_height): Now static.
2554 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2555 * indent.c (check_display_width):
2556 * w32term.c: Fix comment to match code.
2557 * xterm.c, xterm.h (x_catching_errors): Remove.
2558
2559 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2560
2561 * xselect.c: Use signed conversions more consistently (Bug#9498).
2562 (selection_data_to_lisp_data): Assume incoming selection data are
2563 signed integers, not unsigned. This is to be consistent with
2564 outgoing selection data, which was modified to use signed integers
2565 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2566 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2567 expects long, not unsigned long.
2568
2569 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2570
2571 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2572 computation of loop end. Reported by Johan Bockgård
2573 <bojohan@gnu.org>.
2574
2575 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2576
2577 * frame.c (Fother_visible_frames_p): Function deleted.
2578
2579 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2580
2581 * indent.c (compute_motion): Process display vector front to back
2582 rather than the other way around. (Bug#2496)
2583
2584 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2585
2586 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2587
2588 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2589
2590 * minibuf.c (Fread_from_minibuffer): Doc fix.
2591
2592 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2593
2594 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2595 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2596
2597 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2598
2599 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2600 value for non-existent files.
2601
2602 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2603
2604 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2605 set its "size" to -1. This will set the modtime_size field of
2606 the corresponding buffer to -1, which is what
2607 verify-visited-file-modtime expects for files that do not exist.
2608 (Bug#9139)
2609
2610 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2611
2612 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2613 here ...
2614 * lisp.h: ... from here. push_key_description is no longer
2615 defined in keyboard.c, so its declaration should not be in
2616 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2617 logically belongs with push_key_description.
2618
2619 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2620
2621 * buffer.h: Include <sys/types.h> instead of <time.h>.
2622 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2623 Problem reported by Herbert J. Skuhra.
2624
2625 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2626
2627 * xml.c (parse_region): Make the parsing work for
2628 non-comment-starting XML files again (bug#9144).
2629
2630 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2631
2632 * image.c (gif_load): Fix calculation of bottom and right corner.
2633 (Bug#9468)
2634
2635 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2636
2637 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2638 redisplay in small windows.
2639
2640 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2641
2642 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2643
2644 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2645
2646 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2647 Operate on live windows only.
2648
2649 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2650
2651 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2652
2653 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2654
2655 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2656 only under bidi iteration.
2657
2658 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2659
2660 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2661
2662 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2663
2664 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2665 Without this fix, the command to link temacs failed due to an
2666 undefined symbol __builtin_isnan. This is because
2667 /usr/include/iso/math_c99.h #defines isnan(x) to
2668 __builtin_isnan(x), but the bundled gcc, which identifies itself
2669 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2670 a __builtin_isnan.
2671 * floatfns.c (isnan): #undef, and then #define to a clone of
2672 what's in data.c.
2673 (Fisnan): Always define, since it's always available now.
2674 (syms_of_floatfns): Always define isnan at the Lisp level.
2675
2676 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2677
2678 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2679
2680 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2681
2682 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2683 The previous code assumed that file offsets (off_t values) fit in
2684 EMACS_INT variables, which is not true on typical 32-bit hosts.
2685 The code messed up by falsely reporting buffer overflow in cases
2686 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2687 when "big" contains more than 2**29 bytes, even though this
2688 inserts just one byte and does not overflow the buffer.
2689 (Finsert_file_contents): Store file offsets as off_t
2690 values, not as EMACS_INT values. Check for overflow when
2691 converting between EMACS_INT and off_t. When checking for
2692 buffer overflow or for overlap, take the offsets into account.
2693 Don't use EMACS_INT for small values where int suffices.
2694 When checking for overlap, fix a typo: ZV was used where
2695 ZV_BYTE was intended.
2696 (Fwrite_region): Don't assume off_t fits into 'long'.
2697 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2698
2699 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2700
2701 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2702
2703 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2704
2705 sprintf-related integer and memory overflow issues (Bug#9412).
2706
2707 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2708 (esprintf, exprintf, evxprintf): New functions.
2709 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2710 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2711 (modify_event_symbol): Do not assume that the length of
2712 name_alist_or_stem is safe to alloca and fits in int.
2713 (Fexecute_extended_command): Likewise for function name and binding.
2714 (Frecursion_depth): Wrap around reliably on integer overflow.
2715 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2716 since some callers pass EMACS_INT values.
2717 (Fsingle_key_description): Don't crash if symbol name contains more
2718 than MAX_ALLOCA bytes.
2719 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2720 (get_minibuffer): Arg is now EMACS_INT, not int.
2721 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2722 (esprintf, exprintf, evxprintf): New decls.
2723 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2724
2725 * dbusbind.c (signature_cat): New function.
2726 (xd_signature, Fdbus_register_signal):
2727 Do not overrun buffer; instead, report string overflow.
2728
2729 * dispnew.c (add_window_display_history): Don't overrun buffer.
2730 Truncate instead; this is OK since it's just a log.
2731
2732 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2733 even if the time zone offset is outlandishly large.
2734 Don't mishandle offset == INT_MIN.
2735
2736 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2737 when creating daemon; the previous buffer-overflow check was incorrect.
2738
2739 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2740 which has the guts of the old verror function.
2741
2742 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2743 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2744
2745 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2746 (font_unparse_xlfd): Don't blindly alloca long strings.
2747 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2748 fits in int, when using sprintf. Use single snprintf to count
2749 length of string rather than counting it via multiple sprintfs;
2750 that's simpler and more reliable.
2751 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2752 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2753 sprintf, in case result does not fit in int.
2754
2755 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2756 (fontset_from_font): Print it.
2757
2758 * frame.c (tty_frame_count): Now printmax_t, not int.
2759 (make_terminal_frame, set_term_frame_name): Print it.
2760 (x_report_frame_params): In X, window IDs are unsigned long,
2761 not signed long, so print them as unsigned.
2762 (validate_x_resource_name): Check for implausibly long names,
2763 and don't assume name length fits in 'int'.
2764 (x_get_resource_string): Don't blindly alloca invocation name;
2765 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2766 not fit in int.
2767
2768 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2769 (xg_check_special_colors, xg_set_geometry):
2770 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2771
2772 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2773 Use esprintf, not sprintf, in case result does not fit in int.
2774
2775 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2776 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2777 it as a large positive number.
2778 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2779 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2780
2781 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2782 in case result does not fit in int.
2783
2784 * print.c (float_to_string): Detect width overflow more reliably.
2785 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2786 buffer overrun. Don't assume list length fits in 'int'. Treat
2787 print length of 0 as 0, not as infinity; to be consistent with other
2788 uses of print length in this function. Don't overflow print length
2789 index. Don't assume hash table size fits in 'long', or that
2790 vectorlike size fits in 'unsigned long'.
2791
2792 * process.c (make_process): Use printmax_t, not int, to format
2793 process-name gensyms.
2794
2795 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2796
2797 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2798 to avoid potential buffer overrun.
2799
2800 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2801 if X resource line is longer than 512 bytes.
2802
2803 * xfns.c (x_window): Make sprintf buffer a bit bigger
2804 to avoid potential buffer overrun.
2805
2806 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2807
2808 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2809
2810 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2811
2812 Integer overflow fixes for scrolling, etc.
2813 Without these, Emacs silently mishandles large integers sometimes.
2814 For example, "C-u 4294967297 M-x recenter" was treated as if
2815 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2816
2817 * xdisp.c (try_window_id): Check Emacs fixnum range before
2818 converting to 'int'.
2819
2820 * window.c (window_scroll_line_based, Frecenter):
2821 Check that an Emacs fixnum is in range before assigning it to 'int'.
2822 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2823 values converted from Emacs fixnums.
2824 (Frecenter): Don't wrap around a line count if it is out of 'int'
2825 range; instead, treat it as an extreme value.
2826 (Fset_window_configuration, compare_window_configurations):
2827 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2828
2829 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2830 that can exceed INT_MAX. Check that EMACS_INT value is in range
2831 before assigning it to the (possibly-narrower) index.
2832 (match_limit): Don't assume that a fixnum can fit in 'int'.
2833
2834 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2835 exceed INT_MAX.
2836
2837 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2838 (Fvertical_motion): Don't wrap around LINES values that don't fit
2839 in 'int'. Instead, treat them as extreme values. This is good
2840 enough for windows, which can't have more than INT_MAX lines anyway.
2841
2842 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2843
2844 * Require libxml/parser.h to avoid compilation warning.
2845
2846 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2847
2848 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2849 since this reportedly can destroy thread storage.
2850
2851 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2852
2853 * syntax.c (find_defun_start): Update all cache variables if
2854 exiting early (Bug#9401).
2855
2856 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2857
2858 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2859
2860 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2861 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2862 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2863
2864 * term.c (tty_append_glyph): New function.
2865 (produce_stretch_glyph): Static function and its prototype deleted.
2866
2867 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2868 Add prototypes.
2869
2870 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2871
2872 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2873 when checking :margin (Bug#9390).
2874 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2875 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2876 so that the name doesn't mislead. All uses changed.
2877
2878 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2879
2880 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2881 set_tty_hooks.
2882
2883 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2884
2885 * xdisp.c (move_it_to): Don't bail out early when reaching
2886 position beyond to_charpos, if we are scanning backwards.
2887 (move_it_vertically_backward): When DY == 0, make sure we get to
2888 the first character in the line after the newline.
2889
2890 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2891
2892 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2893 (ccl_driver): Do not generate an out-of-range pointer.
2894 (Fccl_execute_on_string): Remove unnecessary check for
2895 integer overflow, noted by Stefan Monnier in
2896 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2897 Remove a FIXME that didn't need fixing.
2898 Simplify the newly-introduced buffer reallocation code.
2899
2900 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2901
2902 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2903
2904 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2905
2906 Integer and memory overflow issues (Bug#9196).
2907
2908 * doc.c (get_doc_string): Rework so that
2909 get_doc_string_buffer_size is the actual buffer size, rather than
2910 being 1 less than the actual buffer size; this makes xpalloc more
2911 convenient.
2912
2913 * image.c (x_allocate_bitmap_record, cache_image):
2914 * xselect.c (Fx_register_dnd_atom):
2915 Simplify previous changes by using xpalloc.
2916
2917 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2918 since either will do and ptrdiff_t is convenient with xpalloc.
2919
2920 * charset.c (charset_table_size)
2921 (struct charset_sort_data.priority): Now ptrdiff_t.
2922 (charset_compare): Don't overflow if priorities differ greatly.
2923 (Fsort_charsets): Don't assume list length fits in int.
2924 Check for size-calculation overflow when allocating sort data.
2925 (syms_of_charset): Allocate an initial charset table that is
2926 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2927
2928 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2929
2930 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2931 The actual value is always <= INT_MAX, and leaving it unsigned made
2932 overflow checking harder.
2933
2934 * dispextern.h (struct glyph_matrix.rows_allocated)
2935 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2936 with xpalloc. The values are still always <= INT_MAX.
2937
2938 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2939
2940 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2941 (SAFE_NALLOCA): New macro.
2942
2943 * region-cache.c (struct boundary.pos, find_cache_boundary)
2944 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2945 (set_cache_region, invalidate_region_cache)
2946 (revalidate_region_cache, know_region_cache, region_cache_forward)
2947 (region_cache_backward, pp_cache):
2948 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2949 so that ptrdiff_t * can be passed to xpalloc.
2950 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2951 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2952 (pp_cache): Don't assume cache_len fits in int.
2953 * region-cache.h: Adjust extern decls to match.
2954
2955 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2956 EMACS_INT, since either will do, for xpalloc.
2957
2958 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2959 (xnmalloc, xnrealloc, xpalloc): New functions.
2960
2961 * bidi.c (bidi_shelve_header_size): New constant.
2962 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2963 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2964
2965 * bidi.c (bidi_cache_shrink):
2966 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2967 (overlay_strings):
2968 Don't update size of array until after memory allocation succeeds,
2969 because xmalloc/xrealloc may not return.
2970 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2971 now that we have proper integer overflow checking.
2972 (record_overlay_string, overlay_strings): Catch overflows when
2973 calculating size of overlay_str_buf.
2974
2975 * callproc.c (Fcall_process): Check for size overflow when
2976 calculating size of args2.
2977 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2978 Normally we prefer signed values, but sticking with ptrdiff_t would
2979 require adding more-complicated checks.
2980
2981 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2982 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2983 Redo buffer-overflow calculations to avoid integer overflow.
2984 Add a FIXME comment where memory seems to be over-allocated.
2985
2986 * character.c (Fstring): Check for size-calculation overflow.
2987
2988 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2989 unnecessary integer overflow. Check for size overflow.
2990 (encode_coding_object): Don't update size until xmalloc succeeds.
2991
2992 * composite.c (get_composition_id): Check for overflow in glyph
2993 length calculations.
2994
2995 Integer and memory overflow fixes for display code.
2996 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2997 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2998 (scrolling_window): Check for overflow in size calculations.
2999 (line_draw_cost, realloc_glyph_pool, add_row_entry):
3000 Don't assume glyph table len fits in int.
3001 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
3002 (row_table_size): Now ptrdiff_t, not int.
3003 (scrolling_window): Avoid overflow in size calculations.
3004 Don't update size until allocation succeeds.
3005 * fns.c (concat): Check for overflow in size calculations.
3006 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
3007 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3008 (NEXT_ALMOST_PRIME_LIMIT): New constant.
3009
3010 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
3011 (get_doc_string): Check for size calculation overflow.
3012 Don't update size until allocation succeeds.
3013 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
3014 EMACS_INT, where ptrdiff_t will do.
3015 (Fsubstitute_command_keys): Check for string overflow.
3016
3017 * editfns.c (set_time_zone_rule): Don't assume environment length
3018 fits in int.
3019 (message_length): Now ptrdiff_t, not int.
3020 (Fmessage_box): Don't update size until allocation succeeds.
3021 Don't assume message length fits in int.
3022 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
3023
3024 * emacs.c (main): Do not reallocate argv, since there is a null at
3025 the end that can be overwritten, and this way there's no need to
3026 worry about size-calculation overflow.
3027 (sort_args): Check for size-calculation overflow.
3028
3029 * eval.c (init_eval_once, grow_specpdl): Don't update size until
3030 alloc succeeds.
3031 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
3032
3033 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
3034 (x_set_scroll_bar_width, x_figure_window_size):
3035 Check for integer overflow.
3036 (x_set_alpha): Do not assume XINT fits in int.
3037
3038 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
3039 This is for the members text_lines, text_cols, total_lines, total_cols,
3040 where the system imposes an 'int' limit.
3041
3042 * fringe.c (Fdefine_fringe_bitmap):
3043 Don't update size until alloc works.
3044
3045 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
3046 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
3047
3048 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
3049 Check for size-calculation overflow.
3050 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
3051 do, as we prefer signed integers.
3052 (id_to_widget.max_size, id_to_widget.used)
3053 (xg_store_widget_in_map, xg_remove_widget_from_map)
3054 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
3055 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
3056 Use and return ptrdiff_t, not int.
3057 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
3058 * gtkutil.h: Change prototypes to match the above.
3059
3060 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
3061 are duplicate now that they've been promoted to lisp.h.
3062 (x_allocate_bitmap_record, x_alloc_image_color)
3063 (make_image_cache, cache_image, xpm_load):
3064 Don't update size until alloc is done.
3065 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
3066 (x_detect_edges):
3067 Check for size calculation overflow.
3068 (ct_colors_allocated_max): New constant.
3069 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
3070 overflow.
3071
3072 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
3073 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
3074 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
3075 Use ptrdiff_t, not int, to count maps.
3076 (read_char_minibuf_menu_prompt): Check for overflow in size
3077 calculations. Don't update size until allocation succeeds.
3078 Redo calculations to avoid overflow.
3079 * keyboard.h: Change prototypes to match the above.
3080
3081 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
3082 to count maps.
3083 (current_minor_maps): Check for size calculation overflow.
3084 * keymap.h: Change prototypes to match the above.
3085
3086 * lread.c (read1, init_obarray): Don't update size until alloc done.
3087
3088 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
3089 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
3090
3091 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
3092 Now ptrdiff_t, not int.
3093 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
3094 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
3095
3096 * process.c (Fnetwork_interface_list): Check for overflow
3097 in size calculation.
3098
3099 * region-cache.c (move_cache_gap): Check for size calculation overflow.
3100
3101 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
3102 overflow. Don't bother calling xmalloc when xrealloc will do.
3103
3104 * search.c (Freplace_match): Check for size calculation overflow.
3105 (Fset_match_data): Don't assume list lengths fit in 'int'.
3106
3107 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3108 for command line length. Do not attempt to address one before the
3109 beginning of an array, as that's not portable.
3110
3111 * term.c (max_frame_lines): Remove; unused.
3112 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3113 not int.
3114 (encode_terminal_code, calculate_costs): Check for size
3115 calculation overflow.
3116 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3117 table lengths and related sizes. Don't update size until alloc
3118 done. Redo calculations to avoid overflow.
3119 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3120
3121 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3122 subtracting pointers.
3123 (gobble_line): Check for overflow more carefully. Don't update size
3124 until alloc done.
3125
3126 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3127 Don't update size until alloc done.
3128 Redo size calculations to avoid overflow.
3129 Check for size calculation overflow.
3130 (main) [DEBUG]: Fix typo in invoking tparam1.
3131
3132 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3133 Use ptrdiff_t, not int, for sizes.
3134 (store_mode_line_noprop_char): Don't update size until alloc done.
3135
3136 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3137 Use ptrdiff_t, not int, for sizes.
3138 (Finternal_make_lisp_face, cache_face):
3139 Check for size calculation overflow.
3140 (cache_face): Treat size calculation overflows as if they were
3141 memory exhaustion (the usual treatment), rather than aborting.
3142
3143 * xfns.c (x_encode_text, x_set_name_internal)
3144 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3145 sizes, since they can exceed INT_MAX in size. Check for size
3146 calculation overflow.
3147
3148 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3149 (xg_select): Check for size calculation overflow.
3150 Don't update size until alloc done.
3151
3152 * xrdb.c (get_environ_db): Don't assume path length fits in int,
3153 as sprintf is limited to int lengths.
3154
3155 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3156 (X_LONG_MIN): New macros.
3157 Use them to make the following changes clearer.
3158 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3159 This change doesn't affect the value now, but it may help remind
3160 future maintainers not to raise the value too much later.
3161 (SELECTION_QUANTUM): Remove, replacing with ...
3162 (selection_quantum): ... new function, which avoids overflow.
3163 All uses changed.
3164 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3165 assumption that selection length fits in 'int'.
3166 (x_reply_selection_request, x_handle_selection_request)
3167 (x_get_window_property, receive_incremental_selection)
3168 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3169 (lisp_data_to_selection_data, clean_local_selection_data):
3170 Use ptrdiff_t, not int, to record length of selection.
3171 (x_reply_selection_request, x_get_window_property)
3172 (receive_incremental_selection, x_property_data_to_lisp):
3173 Redo calculations to avoid overflow.
3174 (x_reply_selection_request): When sending hint, ceiling it at
3175 X_LONG_MAX rather than relying on wraparound overflow to send
3176 something.
3177 (x_get_window_property, receive_incremental_selection)
3178 (lisp_data_to_selection_data, x_property_data_to_lisp):
3179 Check for size-calculation overflow.
3180 (x_get_window_property, receive_incremental_selection)
3181 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3182 Don't store size until memory allocation succeeds.
3183 (x_get_window_property): Plug memory leak on memory exhaustion.
3184 Don't double-block input; malloc is safe here. Don't assume 2**34
3185 - 4 fits in unsigned long. Add an xassert to check
3186 XGetWindowProperty overflow. Be more careful about overflow
3187 calculations, and distinguish size from memory overflow better.
3188 (receive_incremental_selection): When tracing, don't assume
3189 unsigned int is less than INT_MAX.
3190 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3191 harmful) conversions of unsigned short to int.
3192 (lisp_data_to_selection_data): Don't assume that integers
3193 in the range -65535 through -1 fit in an X unsigned short.
3194 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3195 result parameters unless successful. Rely on cons_to_unsigned
3196 to report problems with elements; the old code wasn't right anyway.
3197 (x_check_property_data): Check for int overflow; we cannot use
3198 a wider type due to X limits.
3199 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3200
3201 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
3202
3203 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3204 (x_term_init): Check for size calculation overflow.
3205 (x_color_cells): Don't store size until memory allocation succeeds.
3206 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
3207 Don't assume alloca size is less than MAX_ALLOCA.
3208 (x_term_init): Don't assume length fits in int (sprintf is limited
3209 to int size).
3210
3211 Use ptrdiff_t for composition IDs.
3212 * character.c (lisp_string_width):
3213 * composite.c (composition_table_size, n_compositions)
3214 (get_composition_id, composition_gstring_from_id):
3215 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3216 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3217 * window.c (Frecenter):
3218 Use ptrdiff_t, not int, for composition IDs.
3219 * composite.c (get_composition_id): Check for integer overflow.
3220 * composite.h: Adjust prototypes to match the above changes.
3221
3222 Use ptrdiff_t for hash table indexes.
3223 * category.c (hash_get_category_set):
3224 * ccl.c (ccl_driver):
3225 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3226 * coding.c (coding_system_charset_list, detect_coding_system):
3227 * coding.h (struct coding_system.id):
3228 * composite.c (get_composition_id, gstring_lookup_cache):
3229 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3230 * image.c (xpm_get_color_table_h):
3231 * lisp.h (hash_lookup, hash_put):
3232 * minibuf.c (Ftest_completion):
3233 Use ptrdiff_t for hash table indexes, not int (which is too
3234 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3235 32-bit --with-wide-int hosts).
3236
3237 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3238 Add a FIXME comment about memory leaks.
3239 (syms_of_charset): Don't assume xmalloc returns.
3240
3241 Don't assume that stated character widths fit in int.
3242 * character.c (Fchar_width, c_string_width, lisp_string_width):
3243 * character.h (CHAR_WIDTH):
3244 * indent.c (MULTIBYTE_BYTES_WIDTH):
3245 Use sanitize_char_width to avoid undefined and/or bad behavior
3246 with outlandish widths.
3247 * character.h (sanitize_tab_width): Rename from sanitize_width,
3248 now that we have two such functions. All uses changed.
3249 (sanitize_char_width): New inline function.
3250
3251 Don't assume that tab-width fits in int.
3252 * character.h (sanitize_width): New inline function.
3253 (SANE_TAB_WIDTH): New macro.
3254 (ASCII_CHAR_WIDTH): Use it.
3255 * indent.c (sane_tab_width): Remove. All uses replaced by
3256 SANE_TAB_WIDTH (current_buffer).
3257 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3258
3259 * fileio.c: Integer overflow issues with file modes.
3260 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3261
3262 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3263 Remove unreachable code.
3264 (read_hex, load_charset_map_from_file): Check for integer overflow.
3265
3266 * xterm.c: Don't go over XClientMessageEvent limit.
3267 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3268 (x_send_scroll_bar_event): Likewise. Check that the size does not
3269 exceed limits imposed by XClientMessageEvent, as well as the usual
3270 ptrdiff_t and size_t limits.
3271
3272 * keyboard.c: Overflow, signedness and related fixes.
3273 (make_lispy_movement): Use same integer type in forward decl
3274 that is used in the definition.
3275 (read_key_sequence, keyremap_step):
3276 Change bufsize argument back to int, undoing my 2011-03-30 change.
3277 We prefer signed types, and int is wide enough here.
3278 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3279 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3280 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3281 length, not size_t. Use ptrdiff_t for index, not int.
3282 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3283 possibility of integer overflow.
3284
3285 Overflow, signedness and related fixes for images.
3286
3287 * dispextern.h (struct it.stack[0].u.image.image_id)
3288 (struct_it.image_id, struct image.id, struct image_cache.size)
3289 (struct image_cache.used, struct image_cache.ref_count):
3290 * gtkutil.c (update_frame_tool_bar):
3291 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3292 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3293 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3294 * nsmenu.m (update_frame_tool_bar):
3295 * xdisp.c (calc_pixel_width_or_height):
3296 * xfns.c (image_cache_refcount):
3297 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3298 on typical 64-bit hosts.
3299
3300 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3301 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3302 Omit unnecessary casts to int.
3303 (parse_image_spec): Check that integers fall into 'int' range
3304 when the callers expect that.
3305 (image_ascent): Redo ascent calculation to avoid int overflow.
3306 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3307 (lookup_image): Remove unnecessary tests.
3308 (xbm_image_p): Locals are now of int, not EMACS_INT,
3309 since parse_image_check makes sure they fit into int.
3310 (png_load, gif_load, svg_load_image):
3311 Prefer int to unsigned where either will do.
3312 (tiff_handler): New function, combining the cores of the
3313 old tiff_error_handler and tiff_warning_handler.
3314 This function is rewritten to use vsnprintf and thereby avoid
3315 stack buffer overflows. It uses only the features of vsnprintf
3316 that are common to both POSIX and native Microsoft.
3317 (tiff_error_handler, tiff_warning_handler): Use it.
3318 (tiff_load, gif_load, imagemagick_load_image):
3319 Don't assume :index value fits in 'int'.
3320 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3321 (imagemagick_load_image): Check that crop parameters fit into
3322 the integer types that MagickCropImage accepts. Don't assume
3323 Vimagemagick_render_type has a nonnegative value. Don't assume
3324 size_t fits in 'long'.
3325 (gs_load): Use printmax_t to print the widest integers possible.
3326 Check for integer overflow when computing image height and width.
3327
3328 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3329
3330 * xdisp.c (redisplay_window): Don't force window start if point
3331 will be invisible in the resulting window. (Bug#9324)
3332
3333 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3334
3335 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3336 the display spec is of the form `(space ...)'.
3337 (handle_display_spec): Return the value returned by
3338 handle_single_display_spec, not just 1 or zero.
3339 (handle_single_display_spec): If the display spec is of the form
3340 `(space ...)', and specifies display in the text area, return 2
3341 rather than 1.
3342 (try_cursor_movement): Check for the need to scroll more
3343 accurately, and prefer exact match for point under bidi.
3344 Don't advance `row' beyond the last row of the window.
3345
3346 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3347 into disp_prop; all users changed.
3348
3349 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3350 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3351 for the text covered by the display property.
3352
3353 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3354
3355 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3356 Change return value to nil.
3357 (Frecord_buffer): Delete unused function.
3358
3359 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3360
3361 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3362 buffers, return left-to-right.
3363 (set_cursor_from_row): Consider candidate row a win if its glyph
3364 represents a newline and point is on that newline. Fixes cursor
3365 positioning on the newline at EOL of R2L text within L2R
3366 paragraph, and vice versa.
3367 (try_cursor_movement): Check continued rows, in addition to
3368 continuation rows. Fixes unwarranted scroll when point enters a
3369 continued line of R2L text within an L2R paragraph, or vice versa.
3370 (cursor_row_p): Consider the case of point being equal to
3371 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3372 from the end of a short line to the beginning of a continued line
3373 of R2L text within L2R paragraph.
3374 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3375 composed characters.
3376
3377 * bidi.c (bidi_check_type): Use xassert.
3378 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3379 members.
3380
3381 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3382
3383 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3384 a character.
3385
3386 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3387
3388 * nsfont.m (ns_otf_to_script): Fix typo.
3389
3390 2011-08-22 Kenichi Handa <handa@m17n.org>
3391
3392 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3393 extra slot even if the purpose is char-code-property-table.
3394
3395 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3396
3397 * xdisp.c (redisplay_window): When computing centering_position,
3398 account for the height of the header line. (Bug#8874)
3399
3400 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3401 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3402 candidate is selected by the mouse, and that candidate has a
3403 composed character under the mouse.
3404
3405 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3406 coordinates reported by pos-visible-in-window-p for a composed
3407 character in column zero.
3408
3409 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3410
3411 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3412
3413 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3414
3415 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3416 consider it a hit if to_charpos is anywhere in the range of the
3417 composed buffer positions.
3418
3419 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3420
3421 * image.c (gif_load): Don't assume that each subimage has the same
3422 dimensions as the base image. Handle disposal method that is
3423 "undefined" by the gif spec (Bug#9335).
3424
3425 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3426
3427 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3428 (Fcondition_case): Document `debug' symbol in error handler.
3429
3430 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3431
3432 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3433 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3434 from an Org mode buffer to a Speedbar frame.
3435
3436 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3437 a composition, take its buffer position from IT->cmp_it.charpos.
3438 Fixes cursor positioning at the beginning of a line that begins
3439 with a composed character.
3440
3441 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3442
3443 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3444 character bidirectional type, use STRONG_L instead. Fixes crashes
3445 in a buffer produced by `describe-categories'.
3446
3447 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3448 members before the level stack, so they would be saved and
3449 restored when copying iterator state. Fixes incorrect reordering
3450 around TABs covered by display properties.
3451
3452 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3453
3454 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3455
3456 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3457
3458 * eval.c (internal_condition_case, internal_condition_case_1)
3459 (internal_condition_case_2, internal_condition_case_n):
3460 Remove unnecessary aborts (Bug#9081).
3461
3462 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3463
3464 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3465 has no `load' handler, try opening the file locally. (Bug#9311)
3466
3467 2011-08-16 Ken Brown <kbrown@cornell.edu>
3468
3469 * gmalloc.c: Expand comment.
3470
3471 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3472
3473 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3474 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3475
3476 2011-08-16 Ken Brown <kbrown@cornell.edu>
3477
3478 Fix memory allocation problems in Cygwin build (Bug#9273).
3479
3480 * unexcw.c ( __malloc_initialized): Declare external variable.
3481 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3482
3483 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3484 New variables.
3485 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3486 dumped emacs.
3487 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3488 in the static heap.
3489 [CYGWIN] (special_realloc): New function.
3490 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3491 requests to realloc storage in the static heap.
3492
3493 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3494
3495 * bidi.c (bidi_initialize): Remove unused local.
3496
3497 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3498
3499 * bidimirror.h:
3500 * biditype.h: Remove file.
3501 * makefile.w32-in ($(BLD)/bidi.$(O)):
3502 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3503
3504 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3505
3506 * chartab.c: Improve commentary for the uniprop_table API.
3507
3508 * bidi.c (bidi_paragraph_init): Support zero value of
3509 bidi_ignore_explicit_marks_for_paragraph_level.
3510 (bidi_initialize): Use uniprop_table instead of including
3511 biditype.h and bidimirror.h.
3512
3513 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3514 coordinates of the iterator when restoring from ppos_it.
3515 (Bug#9296)
3516
3517 2011-08-14 Kenichi Handa <handa@m17n.org>
3518
3519 * process.c (create_process): Call setup_process_coding_systems
3520 after the pid of the process is set to -1 (Bug#8162).
3521
3522 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3523
3524 * xdisp.c (move_it_in_display_line_to): Don't invoke
3525 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3526 ppos_it. Fixes vertical cursor motion when line beginning is
3527 covered by an image. (Bug#9296)
3528
3529 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3530
3531 * nsterm.h (ns_run_ascript): Declare.
3532 (NSAPP_DATA2_RUNASSCRIPT): Define.
3533
3534 * nsfns.m (as_script, as_result, as_status): New static variables.
3535 (ns_run_ascript): New function.
3536 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3537 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3538 the event loop. Get status from as_status (Bug#7276).
3539
3540 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3541 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3542 the event loop (Bug#7276).
3543
3544 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3545
3546 * gnutls.c (QCgnutls_bootprop_priority)
3547 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3548 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3549 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3550 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3551 (QCgnutls_bootprop_verify_hostname_error)
3552 (QCgnutls_bootprop_callbacks_verify): Rename from
3553 Qgnutls_bootprop_..., all uses changed.
3554
3555 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3556 uses changed.
3557
3558 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3559
3560 * xfaces.c (Qframe_set_background_mode): Now static.
3561 * dispextern.h (Qframe_set_background_mode): Remove decl.
3562
3563 * process.c (Fnetwork_interface_info): Declare local only if needed.
3564
3565 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3566
3567 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3568 (Fnetwork_interface_list): Allocate in increments of bytes instead
3569 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3570 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3571 sockaddr.
3572 (struct ifflag_def): notrailers is smart on OSX.
3573 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3574 Get hardware address with getifaddrs if available.
3575
3576 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3577
3578 * xdisp.c (iterate_out_of_display_property): xassert that
3579 IT->position is set to within IT->object's boundaries. Break from
3580 the loop as soon as EOB is reached; avoids infloops in redisplay
3581 when IT->position is set up wrongly due to some bug.
3582 Set IT->current to match the bidi iterator unconditionally.
3583 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3584 entry. Force push_it to save on the stack the current
3585 buffer/string position, to be restored by pop_it. Fix flags in
3586 the iterator structure wrt the object coming from a display
3587 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3588 properties. (Bug#9284)
3589
3590 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3591
3592 * fontset.c (fontset_get_font_group): Add proper type checks.
3593 (Bug#9172)
3594
3595 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3596
3597 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3598 and LC_VERSION_MIN_MACOSX.
3599 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3600 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3601
3602 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3603
3604 * xdisp.c (forward_to_next_line_start): Allow to use the
3605 no-display-properties-and-no-overlays under bidi display.
3606 Set disp_pos in the bidi iterator to avoid searches for display
3607 properties and overlays.
3608
3609 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3610
3611 * editfns.c (Fset_time_zone_rule): Document relationship with the
3612 setenv function.
3613
3614 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3615 the font entity extracted from the cache (Bug#8109).
3616
3617 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3618
3619 * composite.c (autocmp_chars): Don't reset point. That is done by
3620 restore_point_unwind (Bug#5984).
3621
3622 2011-08-07 Juri Linkov <juri@jurta.org>
3623
3624 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3625 to show the arg `TIME' instead of `TIMEVAL'.
3626
3627 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3628
3629 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3630 display property strides EOL and includes a newline, as in
3631 longlines-mode. (Bug#9254)
3632 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3633 word-wrap under bidirectional display. (Bug#9224)
3634
3635 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3636 is non-zero, even if the data buffer is NULL. Fixes a crash in
3637 vertical-motion with longlines-mode. (Bug#9254)
3638
3639 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3640
3641 * bidi.c <bidi_cache_total_alloc>: Now static.
3642 (bidi_initialize): Initialize bidi_cache_total_alloc.
3643
3644 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3645 cache. (Bug#9221)
3646
3647 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3648 amount allocated this far in `bidi_cache_total_alloc'.
3649 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3650 non-zero, only free the data buffer without restoring the cache
3651 contents. All callers changed.
3652
3653 * dispextern.h (bidi_unshelve_cache): Update prototype.
3654
3655 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3656 (move_it_in_display_line, move_it_to)
3657 (move_it_vertically_backward, move_it_by_lines): Replace the call
3658 to xfree to an equivalent call to bidi_unshelve_cache.
3659 (move_it_in_display_line_to): Fix logic of returning
3660 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3661
3662 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3663
3664 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3665 came from a string character with a `cursor' property. (Bug#9229)
3666
3667 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3668
3669 * Makefile.in (LIB_PTHREAD): New variable.
3670 (LIBES): Add LIB_PTHREAD (Bug#9216).
3671
3672 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3673 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3674
3675 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3676
3677 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3678
3679 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3680
3681 * xterm.c (x_find_topmost_parent): New function.
3682 (x_set_frame_alpha): Find topmost parent window with
3683 x_find_topmost_parent and set the property there also (bug#9181).
3684 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3685
3686 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3687
3688 * callproc.c (Fcall_process): Avoid vfork clobbering
3689 the local vars buffer, coding_systems, current_dir.
3690
3691 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3692
3693 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3694
3695 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3696
3697 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3698 so that it is not optimized away.
3699
3700 * xdisp.c (compute_display_string_pos): Remove unused local.
3701
3702 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3703
3704 Fix slow cursor motion and scrolling in large buffers with
3705 selective display, like Org Mode buffers. (Bug#9218)
3706
3707 * dispextern.h (struct bidi_it): New member disp_prop_p.
3708
3709 * xdisp.c: Remove one-slot cache of display string positions.
3710 (compute_display_string_pos): Accept an additional argument
3711 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3712 for a display string or property. If found, set DISP_PROP_P
3713 non-zero.
3714
3715 * bidi.c (bidi_fetch_char): Accept an additional argument
3716 DISP_PROP_P, and pass it to compute_display_string_pos.
3717 Only handle text covered by a display string if DISP_PROP_P is returned
3718 non-zero. All callers of bidi_fetch_char changed.
3719
3720 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3721
3722 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3723
3724 2010-12-03 Don March <don@ohspite.net>
3725
3726 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3727 last character M-[char] is translated to ESC [char] (bug#7541).
3728
3729 2011-08-02 Kenichi Handa <handa@m17n.org>
3730
3731 * lisp.h (uniprop_table): Extern it.
3732
3733 * chartab.c (uniprop_table): Make it non-static.
3734
3735 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3736
3737 * xdisp.c (forward_to_next_line_start): Accept additional argument
3738 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3739 on the newline.
3740 (reseat_at_next_visible_line_start): Use the bidi iterator state
3741 returned by forward_to_next_line_start to restore the state of
3742 it->bidi_it after backing up to previous newline. (Bug#9212)
3743
3744 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3745
3746 * regex.c (re_comp): Protoize.
3747 (re_exec): Fix return type.
3748 (regexec): Fix type of `ret'. (Bug#9203)
3749
3750 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3751
3752 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3753 This is needed if max-image-size is a floating-point number.
3754
3755 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3756
3757 * print.c (print_object): Print empty symbol as ##.
3758
3759 * lread.c (read1): Read ## as empty symbol.
3760
3761 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3762
3763 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3764 setting frame foreground color (Bug#9175).
3765 (x_set_background_color): Likewise.
3766
3767 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3768 contents (Bug#9176).
3769 (EmacsTooltip -init): Remove bezels and add shadows to
3770 tooltip windows.
3771
3772 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3773 or scroll bar (Bug#8470).
3774
3775 * nsfont.m (nsfont_open): Remove assignment to voffset and
3776 unnecessary vars hshink, expand, hd, full_height, min_height.
3777 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3778
3779 * nsterm.h (nsfont_info): Remove voffset field.
3780
3781 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3782
3783 Implement strike-through and overline on NextStep (Bug#8863).
3784
3785 * nsfont.m (nsfont_open): Use underline position provided by font,
3786 instead of hard-coded value of 2.
3787 (nsfont_draw): Call ns_draw_text_decoration instead.
3788
3789 * nsterm.h: Add declaration for ns_draw_text_decoration.
3790
3791 * nsterm.m (ns_draw_text_decoration): New function for drawing
3792 underline, overline, and strike-through.
3793 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3794 ns_draw_text_decoration. Change treatment of cursor drawing to
3795 accommodate underlining, etc.
3796
3797 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3798
3799 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3800 default.
3801
3802 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3803
3804 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3805 Without this fix, if a signal arrives just after memory fills up,
3806 'malloc' might be invoked reentrantly.
3807
3808 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3809 In other words, assume that every image size is allowed, on non-X
3810 hosts. This assumption is probably wrong, but it lets Emacs compile.
3811
3812 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3813
3814 * regex.c (re_iswctype): Convert return values to boolean.
3815
3816 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3817
3818 * xdisp.c (compute_display_string_pos): Don't use cached display
3819 string position if the buffer had its restriction changed.
3820 (Bug#9184)
3821
3822 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3823
3824 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3825
3826 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3827
3828 Integer signedness and overflow and related fixes. (Bug#9079)
3829
3830 * bidi.c: Integer size and overflow fixes.
3831 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3832 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3833 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3834 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3835 (bidi_find_other_level_edge):
3836 Use ptrdiff_t instead of EMACS_INT where either will do.
3837 This works better on 32-bit hosts configured --with-wide-int.
3838 (bidi_cache_ensure_space): Check for size-calculation overflow.
3839 Use % rather than repeated addition, for better worst-case speed.
3840 Don't set bidi_cache_size until after xrealloc returns, because it
3841 might not return.
3842 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3843 (bidi_cache_ensure_space): Also check that the bidi cache size
3844 does not exceed that of the largest Lisp string or buffer. See Eli
3845 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3846
3847 * alloc.c (__malloc_size_t): Remove.
3848 All uses replaced by size_t. See Andreas Schwab's note
3849 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3850
3851 * image.c: Improve checking for integer overflow.
3852 (check_image_size): Assume that f is nonnull, since
3853 it is always nonnull in practice. This is one less thing to
3854 worry about when checking for integer overflow later.
3855 (x_check_image_size): New function, which checks for integer
3856 overflow issues inside X.
3857 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3858 This removes the need for a memory_full check.
3859 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3860 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3861 (xbm_read_bitmap_data): Change locals back to 'int', since
3862 their values must fit in 'int'.
3863 (xpm_load_image, png_load, tiff_load):
3864 Invoke x_create_x_image_and_pixmap earlier,
3865 to avoid much needless work if the image is too large.
3866 (tiff_load): Treat overly large images as if
3867 x_create_x_image_and_pixmap failed, not as malloc failures.
3868 (gs_load): Use x_check_image_size.
3869
3870 * gtkutil.c: Omit integer casts.
3871 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3872 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3873
3874 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3875
3876 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3877 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3878 would wrongly return t on a 64-bit host.
3879
3880 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3881 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3882 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3883 and therefore cause GCC to emit a bogus diagnostic in some cases.
3884
3885 * image.c: Integer signedness and overflow and related fixes.
3886 This is not an exhaustive set of fixes, but it's time to
3887 record what I've got.
3888 (lookup_pixel_color, check_image_size): Remove redundant decls.
3889 (check_image_size): Don't assume that arbitrary EMACS_INT values
3890 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3891 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3892 (tiff_load, imagemagick_load_image):
3893 Check for overflow in size calculations.
3894 (x_create_x_image_and_pixmap): Remove unnecessary test for
3895 xmalloc returning NULL; that can't happen.
3896 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3897 (xpm_color_bucket): Use better integer hashing function.
3898 (xpm_cache_color): Don't possibly over-allocate memory.
3899 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3900 (gif_memory_source):
3901 Use ptrdiff_t, not int or size_t, to record sizes.
3902 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3903 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3904 either works, as we prefer signed integers.
3905 (tiff_read_from_memory, tiff_write_from_memory):
3906 Return tsize_t, not size_t, since that's what the TIFF API wants.
3907 (tiff_read_from_memory): Don't fail simply because the read would
3908 go past EOF; instead, return a short read.
3909 (tiff_load): Omit no-longer-needed casts.
3910 (Fimagemagick_types): Don't assume size fits into 'int'.
3911
3912 Improve hashing quality when configured --with-wide-int.
3913 * fns.c (hash_string): New function, taken from sxhash_string.
3914 Do not discard information about ASCII character case; this
3915 discarding is no longer needed.
3916 (sxhash-string): Use it. Change sig to match it. Caller changed.
3917 * lisp.h: Declare it.
3918 * lread.c (hash_string): Remove, since we now use fns.c's version.
3919 The fns.c version returns a wider integer if --with-wide-int is
3920 specified, so this should help the quality of the hashing a bit.
3921
3922 * emacs.c: Integer overflow minor fix.
3923 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3924 Define only if GNU_LINUX.
3925 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3926
3927 * dispnew.c: Integer signedness and overflow fixes.
3928 Remove unnecessary forward decls, that were a maintenance hassle.
3929 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3930 All uses changed.
3931 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3932 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3933 (prepare_desired_row, line_draw_cost):
3934 Use int, not unsigned, where either works.
3935 (save_current_matrix, restore_current_matrix):
3936 Use ptrdiff_t, not size_t, where either works.
3937 (init_display): Check for overflow more accurately, and without
3938 relying on undefined behavior.
3939
3940 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3941 Remove, replacing with the new symbols in lisp.h. All uses changed.
3942 * fileio.c (make_temp_name):
3943 * filelock.c (lock_file_1, lock_file):
3944 * xdisp.c (message_dolog):
3945 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3946 Use pMd etc. instead.
3947 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3948 replacing the pWIDE etc. symbols removed from editfns.c.
3949
3950 * keyboard.h (num_input_events): Now uintmax_t.
3951 This is (very slightly) less likely to mess up due to wraparound.
3952 All uses changed.
3953
3954 * buffer.c: Integer signedness fixes.
3955 (alloc_buffer_text, enlarge_buffer_text):
3956 Use ptrdiff_t rather than size_t when either will do, as we prefer
3957 signed integers.
3958
3959 * alloc.c: Integer signedness and overflow fixes.
3960 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3961 (__malloc_size_t): Default to size_t, not to int.
3962 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3963 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3964 Prefer ptrdiff_t to size_t when either would do, as we prefer
3965 signed integers.
3966 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3967 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3968 Now const. Initialize with values that are in range even if char
3969 is signed.
3970 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3971 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3972 These functions do the right thing with sizes > 2**32.
3973 (check_depth): Now ptrdiff_t, not int.
3974 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3975 Adjust to new way of storing sizes. Check for size overflow bugs
3976 in rest of code.
3977 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3978 slightly wrong anyway, as it missed one instance of
3979 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3980 (refill_memory_reserve): Omit needless cast to size_t.
3981 (mark_object_loop_halt): Mark as externally visible.
3982
3983 * xselect.c: Integer signedness and overflow fixes.
3984 (Fx_register_dnd_atom, x_handle_dnd_message):
3985 Use ptrdiff_t, not size_t, since we prefer signed.
3986 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3987 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3988 x_dnd_atoms_size and x_dnd_atoms_length.
3989
3990 * doprnt.c: Prefer signed to unsigned when either works.
3991 * eval.c (verror):
3992 * doprnt.c (doprnt):
3993 * lisp.h (doprnt):
3994 * xdisp.c (vmessage):
3995 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3996 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3997 prefer signed arithmetic to avoid comparison confusion.
3998 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3999 but is a bit tricky.
4000
4001 Assume freestanding C89 headers, string.h, stdlib.h.
4002 * data.c, doprnt.c, floatfns.c, print.c:
4003 Include float.h unconditionally.
4004 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
4005 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
4006 * regex.c: Likewise for stddef.h, string.h.
4007 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
4008 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
4009 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
4010 (STDC_HEADERS): Remove obsolete defines.
4011 * sysdep.c: Include limits.h unconditionally.
4012
4013 Assume support for memcmp, memcpy, memmove, memset.
4014 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
4015 * regex.c (memcmp, memcpy):
4016 Remove; we assume C89 now.
4017
4018 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
4019 (__malloc_safe_bcopy): Remove; no longer needed.
4020
4021 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
4022 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
4023 well either way, and we prefer signed to unsigned.
4024
4025 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
4026
4027 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
4028 closes the connection while we're reading (bug#9182).
4029
4030 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
4031
4032 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
4033 are specified (Bug#9168).
4034
4035 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
4036
4037 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
4038 Found by GCC static checking and --with-wide-int on a 32-bit host.
4039
4040 2011-07-25 Eli Zaretskii <eliz@gnu.org>
4041
4042 * xdisp.c (compute_display_string_pos): Fix logic of caching
4043 previous display string position. Initialize cached_prev_pos to
4044 -1. Fixes slow-down at the beginning of a buffer.
4045
4046 2011-07-24 Eli Zaretskii <eliz@gnu.org>
4047
4048 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
4049 for attrs[LFACE_FONTSET_INDEX].
4050
4051 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
4052
4053 * xml.c (parse_region): Remove unused local
4054 that was recently introduced.
4055
4056 2011-07-23 Eli Zaretskii <eliz@gnu.org>
4057
4058 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
4059 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
4060
4061 * xdisp.c (move_it_in_display_line_to): Record the best matching
4062 position for TO_CHARPOS while scanning the line, and restore it on
4063 exit if none of the characters scanned was an exact match.
4064 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
4065 when exact match is impossible due to invisible text, and the
4066 lines are truncated.
4067
4068 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
4069
4070 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
4071 for OSX >= 10.7.
4072
4073 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4074
4075 Fix a significant slow-down of cursor motion with C-n, C-p,
4076 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
4077 auto-repeat under bidi redisplay in fontified buffers.
4078 * xdisp.c (compute_stop_pos_backwards): New function.
4079 (next_element_from_buffer): Call compute_stop_pos_backwards to
4080 find a suitable prev_stop when we find ourselves before
4081 base_level_stop.
4082 (reseat): Don't look for prev_stop, as that could mean a very long
4083 run.
4084 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
4085 <cached_disp_overlay_modiff>: Cache for last found display string
4086 position.
4087 (compute_display_string_pos): Return the cached position if asked
4088 about the same buffer in the same area of character positions, and
4089 the buffer wasn't changed since the time the display string
4090 position was cached.
4091
4092 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4093
4094 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
4095 is an integer, which is important for empty lines. (Bug#9149)
4096
4097 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
4098
4099 * frame.c (Fmodify_frame_parameters): In tty case, update the
4100 default face if necessary (Bug#4238).
4101
4102 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
4103
4104 * editfns.c (Fstring_to_char): No need to explain what a character
4105 is in the docstring (Bug#6576).
4106
4107 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4108
4109 * xml.c (parse_region): Make sure we always return a tree.
4110
4111 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4112
4113 * xml.c (parse_region): If a document contains only comments,
4114 return that, too.
4115
4116 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4117
4118 * xml.c (make_dom): Return comments, too.
4119
4120 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4121
4122 Port to OpenBSD.
4123 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4124 and the surrounding thread.
4125 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4126 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4127 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4128 timer goes off.
4129 * s/openbsd.h (BROKEN_SIGIO): Define.
4130 * unexelf.c (unexec) [__OpenBSD__]:
4131 Don't update the .mdebug section of the Alpha COFF symbol table.
4132
4133 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4134
4135 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4136 (bug#8460).
4137
4138 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4139
4140 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4141 This fixes some race conditions on the permissions of any newly
4142 created file.
4143
4144 * alloc.c (valid_pointer_p): Use pipe, not open.
4145 This fixes some permissions issues when debugging.
4146
4147 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4148 If fchown fails to set both uid and gid, try to set just gid,
4149 as that is sometimes allowed. Adjust the file's mode to eliminate
4150 setuid or setgid bits that are inappropriate if fchown fails.
4151
4152 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4153
4154 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4155 to compare Lisp_Objects.
4156 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4157 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4158 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4159
4160 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4161
4162 * lread.c (read_integer): Unread even EOF character.
4163 (read1): Likewise. Properly record start position of symbol.
4164
4165 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4166 symbol character follows.
4167
4168 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4169
4170 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4171 This works around a problem with the previous change to Fcopy_file.
4172 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4173 and without this change, GCC might complain about discarding
4174 fchown's return value.
4175
4176 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
4177
4178 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4179
4180 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4181
4182 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4183
4184 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4185
4186 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4187 it's used from the C level.
4188
4189 * process.c: Use the same condition for POLL_FOR_INPUT in both
4190 keyboard.c and process.c (bug#1858).
4191
4192 2011-07-09 Lawrence Mitchell <wence@gmx.li>
4193
4194 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4195 (Fgnutls_boot): Use it.
4196
4197 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4198
4199 * doc.c (Fsubstitute_command_keys): Revert last change.
4200
4201 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4202
4203 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4204 quotes the next character, and doesn't affect other longer
4205 sequences (bug#8935).
4206
4207 * lread.c (syms_of_lread): Clarify that is isn't only
4208 `eval-buffer' and `eval-defun' that's affected by
4209 `lexical-binding' (bug#8460).
4210
4211 2011-07-15 Eli Zaretskii <eliz@gnu.org>
4212
4213 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
4214 bidi redisplay when a line includes both an image and is truncated.
4215
4216 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4217
4218 Fix minor problems found by static checking.
4219 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4220 (elsz): Now a signed constant, not a size_t var. We prefer signed
4221 types to unsigned, to avoid integer comparison confusion. Without
4222 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4223 "cannot optimize loop, the loop counter may overflow", a symptom
4224 of the confusion.
4225 * indent.c (Fvertical_motion): Mark locals as initialized.
4226 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4227
4228 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4229
4230 * search.c (Fre_search_backward): Mention `case-fold-search' in
4231 all the re_search_* functions (bug#8138).
4232
4233 * keyboard.c (Fopen_dribble_file): Document when the file is
4234 closed (bug#8056).
4235
4236 2011-07-14 Eli Zaretskii <eliz@gnu.org>
4237
4238 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4239 bidi_cache_idx.
4240
4241 Support bidi reordering of display and overlay strings.
4242 * xdisp.c (compute_display_string_pos)
4243 (compute_display_string_end): Accept additional argument STRING.
4244 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4245 (reseat_to_string): Initialize bidi_it->string.s and
4246 bidi_it->string.schars.
4247 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
4248 NULL (avoids a crash in bidi_paragraph_init).
4249 Initialize itb.string.lstring.
4250 (init_iterator): Call bidi_init_it only of a valid
4251 buffer position was specified. Initialize paragraph_embedding to
4252 L2R.
4253 (reseat_to_string): Initialize the bidi iterator.
4254 (display_string): If we need to ignore text properties of
4255 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4256 original value of -1 will not work with bidi.)
4257 (compute_display_string_pos): First arg is now struct
4258 `text_pos *'; all callers changed. Support display properties on
4259 Lisp strings.
4260 (compute_display_string_end): Support display properties on Lisp
4261 strings.
4262 (init_iterator, reseat_1, reseat_to_string): Initialize the
4263 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4264 when iterating on a string not from display properties).
4265 (compute_display_string_pos, compute_display_string_end):
4266 Fix calculation of the object to scan. Fixes an error when using
4267 arrow keys.
4268 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4269 base_level_stop; instead, set base_level_stop to BEGV.
4270 Fixes crashes in vertical-motion.
4271 (next_element_from_buffer): Improve commentary for when
4272 the iterator is before prev_stop.
4273 (init_iterator): Initialize bidi_p from the default value of
4274 bidi-display-reordering, not from buffer-local value. Use the
4275 buffer-local value only if initializing for buffer iteration.
4276 (handle_invisible_prop): Support invisible properties on strings
4277 that are being bidi-reordered.
4278 (set_iterator_to_next): Support bidi reordering of C strings and
4279 Lisp strings.
4280 (next_element_from_string): Support bidi reordering of Lisp
4281 strings.
4282 (handle_stop_backwards): Support Lisp strings as well.
4283 (display_string): Support display of R2L glyph rows.
4284 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4285 (init_iterator): Don't initialize it->bidi_p for strings
4286 here.
4287 (reseat_to_string): Initialize it->bidi_p for strings here.
4288 (next_element_from_string, next_element_from_c_string)
4289 (next_element_from_buffer): Add xassert's for correspondence
4290 between IT's object being iterated and it->bidi_it.string
4291 structure.
4292 (face_before_or_after_it_pos): Support bidi iteration.
4293 (next_element_from_c_string): Handle the case of the first string
4294 character that is not the first one in the visual order.
4295 (get_visually_first_element): New function, refactored from common
4296 parts of next_element_from_buffer, next_element_from_string, and
4297 next_element_from_c_string.
4298 (tool_bar_lines_needed, redisplay_tool_bar)
4299 (display_menu_bar): Force left-to-right direction. Add a FIXME
4300 comment for making that be controlled by a user option.
4301 (push_it, pop_it): Save and restore the state of the
4302 bidi iterator. Save and restore the bidi_p flag.
4303 (pop_it): Iterate out of display property for string iteration as
4304 well.
4305 (iterate_out_of_display_property): Support iteration over strings.
4306 (handle_single_display_spec): Set up it->bidi_it for iteration
4307 over a display string, and call bidi_init_it.
4308 (handle_single_display_spec, next_overlay_string)
4309 (get_overlay_strings_1, push_display_prop): Set up the bidi
4310 iterator for displaying display or overlay strings.
4311 (forward_to_next_line_start): Don't use the shortcut if
4312 bidi-iterating.
4313 (back_to_previous_visible_line_start): If handle_display_prop
4314 pushed the iterator stack, restore the internal state of the bidi
4315 iterator by calling bidi_pop_it same number of times.
4316 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4317 and we are bidi-iterating, don't decrement the iterator position;
4318 instead, set the first_elt flag in the bidi iterator, to produce
4319 the same effect.
4320 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4321 (push_display_prop): xassert that we are iterating a buffer.
4322 (push_it, pop_it): Save and restore paragraph_embedding member.
4323 (handle_single_display_spec, next_overlay_string)
4324 (get_overlay_strings_1, reseat_1, reseat_to_string)
4325 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4326 correctly. Don't assume unibyte strings are not bidi-reordered.
4327 (compute_display_string_pos)
4328 (compute_display_string_end): Fix handling the case of C string.
4329 (push_it, pop_it): Save and restore from_disp_prop_p.
4330 (handle_single_display_spec, push_display_prop): Set the
4331 from_disp_prop_p flag.
4332 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4333 (pop_it): Call iterate_out_of_display_property only if we are
4334 popping after iteration over a string that came from a display
4335 property. Fix a typo in popping stretch info. Add an assertion
4336 for verifying that the iterator position is in sync with the bidi
4337 iterator.
4338 (handle_single_display_spec, get_overlay_strings_1)
4339 (push_display_prop): Fix initialization of paragraph direction for
4340 string when that of the parent object is not yet determined.
4341 (reseat_1): Call bidi_init_it to resync the bidi
4342 iterator with IT's position. (Bug#7616)
4343 (find_row_edges): If ROW->start.pos gives position
4344 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4345 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4346 Reset the from_disp_prop_p flag.
4347 (SAVE_IT, RESTORE_IT): New macros.
4348 (pos_visible_p, face_before_or_after_it_pos)
4349 (back_to_previous_visible_line_start)
4350 (move_it_in_display_line_to, move_it_in_display_line)
4351 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4352 (try_scrolling, redisplay_window, display_line): Use them when
4353 saving a temporary copy of the iterator and restoring it back.
4354 (back_to_previous_visible_line_start, reseat_1)
4355 (init_iterator): Empty the bidi cache "stack".
4356 (move_it_in_display_line_to): If iterator ended up at
4357 EOL, but we never saw any buffer positions smaller than
4358 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4359 motion in bidi-reordered lines.
4360 (move_it_in_display_line_to): Record prev_method and prev_pos
4361 immediately before the call to set_iterator_to_next. Fixes cursor
4362 motion in bidi-reordered lines with stretch glyphs and strings
4363 displayed in margins. (Bug#8133) (Bug#8867)
4364 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4365 TO_CHARPOS.
4366 (pos_visible_p): Support positions in bidi-reordered lines.
4367 Save and restore bidi cache.
4368
4369 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4370 (bidi_paragraph_info): Delete unused struct.
4371 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4372 (bidi_cache_start): New variable.
4373 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4374 to zero.
4375 (bidi_cache_fetch_state, bidi_cache_search)
4376 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4377 (bidi_cache_find, bidi_peek_at_next_level)
4378 (bidi_level_of_next_char, bidi_find_other_level_edge)
4379 (bidi_move_to_visually_next): Compare cache index with
4380 bidi_cache_start rather than with zero.
4381 (bidi_fetch_char): Accept new argument STRING; all callers
4382 changed. Support iteration over a string. Support strings with
4383 display properties. Support unibyte strings. Fix the type of
4384 `len' according to what STRING_CHAR_AND_LENGTH expects.
4385 (bidi_paragraph_init, bidi_resolve_explicit_1)
4386 (bidi_resolve_explicit, bidi_resolve_weak)
4387 (bidi_level_of_next_char, bidi_move_to_visually_next):
4388 Support iteration over a string.
4389 (bidi_set_sor_type, bidi_resolve_explicit_1)
4390 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4391 can now be zero (for strings); special values 0 and -1 were
4392 changed to -1 and -2, respectively.
4393 (bidi_char_at_pos): New function.
4394 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4395 Call it instead of FETCH_MULTIBYTE_CHAR.
4396 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4397 initialized to valid values.
4398 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4399 values.
4400 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4401 the test for valid cached positions. Fix the logic for looking up
4402 the sentinel state in the cache. GCPRO the Lisp string we are
4403 iterating.
4404 (bidi_push_it, bidi_pop_it): New functions.
4405 (bidi_initialize): Initialize the bidi cache start stack pointer.
4406 (bidi_cache_ensure_space): New function, refactored from part of
4407 bidi_cache_iterator_state. Don't assume the required size is just
4408 one BIDI_CACHE_CHUNK away.
4409 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4410 (bidi_count_bytes, bidi_char_at_pos): New functions.
4411 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4412 always valid if bidi_cache_idx is valid.
4413 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4414 is valid if it's going to be used.
4415 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4416 (bidi_cache_fetch_state, bidi_cache_search)
4417 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4418 (bidi_cache_iterator_state, bidi_cache_find)
4419 (bidi_find_other_level_edge, bidi_cache_start_stack):
4420 All variables related to cache indices are now EMACS_INT.
4421
4422 * dispextern.h (struct bidi_string_data): New structure.
4423 (struct bidi_it): New member `string'. Make flag members be 1-bit
4424 fields, and put them last in the struct.
4425 (compute_display_string_pos, compute_display_string_end):
4426 Update prototypes.
4427 (bidi_push_it, bidi_pop_it): Add prototypes.
4428 (struct iterator_stack_entry): New members bidi_p,
4429 paragraph_embedding, and from_disp_prop_p.
4430 (struct it): Member bidi_p is now a bit field 1 bit wide.
4431 (bidi_shelve_cache, bidi_unshelve_cache):
4432 Declare prototypes.
4433
4434 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4435 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4436 and vector-like objects.
4437
4438 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4439 cache around display iteration.
4440
4441 * window.c (Fwindow_end, window_scroll_pixel_based)
4442 (displayed_window_lines, Frecenter): Save and restore the bidi
4443 cache around display iteration.
4444
4445 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4446
4447 * editfns.c (Fdelete_region): Clarify the use of the named
4448 parameters (bug#6788).
4449
4450 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4451
4452 * indent.c (Fvertical_motion): Set and restore w->pointm when
4453 saving and restoring the window's buffer (Bug#9006).
4454
4455 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4456
4457 * editfns.c (Fstring_to_char): Clarify just what is returned
4458 (bug#6576). Text by Eli Zaretskii.
4459
4460 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4461
4462 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4463
4464 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4465
4466 * buffer.c (mmap_find): Fix a typo.
4467
4468 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4469
4470 Fix execution of x selection hooks.
4471 * xselect.c (Qx_lost_selection_functions)
4472 (Qx_sent_selection_functions): New vars.
4473 (syms_of_xselect): DEFSYM them.
4474 (x_handle_selection_request): Pass Qx_sent_selection_functions
4475 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4476 (x_handle_selection_clear,x_clear_frame_selections):
4477 Pass Qx_lost_selection_functions rather than
4478 Vx_lost_selection_functions to Frun_hook_with_args.
4479
4480 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4481
4482 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4483 The old code sometimes used this field without initializing it.
4484
4485 * alloc.c (gc_sweep): Don't read past end of array.
4486 In theory, the old code could also have corrupted Emacs internals,
4487 though it'd be very unlikely.
4488
4489 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4490
4491 * character.c (Fcharacterp): Don't advertise optional ignored
4492 argument. (Bug#4026)
4493
4494 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4495
4496 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4497 key" (bug#4257).
4498
4499 * window.c (Fset_window_start): Doc fix (bug#4199).
4500 (Fset_window_hscroll): Ditto.
4501
4502 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4503
4504 Fix minor new problems caught by GCC 4.6.1.
4505 * term.c (init_tty): Remove unused local.
4506 * xsettings.c (store_monospaced_changed): Define this function only
4507 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4508 not used otherwise.
4509
4510 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4511
4512 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4513
4514 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4515
4516 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4517 are the mini-buffer and the echo area (bug#3320).
4518
4519 * term.c (init_tty): Remove support for supdup, c10 and perq
4520 terminals, which are no longer supported (bug#1482).
4521
4522 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4523
4524 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4525
4526 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4527
4528 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4529 for non-popups (Bug#3642).
4530
4531 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4532
4533 * alloc.c (reset_malloc_hooks): Protoize.
4534 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4535 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4536 * cm.c (losecursor): Likewise.
4537 * data.c (fmod): Likewise.
4538 * dispnew.c (swap_glyphs_in_rows): Likewise.
4539 * emacs.c (memory_warning_signal): Likewise.
4540 * floatfns.c (float_error): Likewise.
4541 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4542 (otf_open, font_otf_capability, generate_otf_features)
4543 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4544 Likewise.
4545 * image.c (pbm_read_file): Likewise.
4546 * indent.c (string_display_width): Likewise.
4547 * intervals.c (check_for_interval, search_for_interval)
4548 (inc_interval_count, count_intervals, root_interval)
4549 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4550 * lread.c (defalias): Likewise.
4551 * ralloc.c (r_alloc_check): Likewise.
4552 * regex.c (set_image_of_range_1, set_image_of_range)
4553 (regex_grow_registers): Likewise.
4554 * sysdep.c (strerror): Likewise.
4555 * termcap.c (valid_filename_p, tprint, main): Likewise.
4556 * tparam.c (main): Likewise.
4557 * unexhp9k800.c (run_time_remap, save_data_space)
4558 (update_file_ptrs, read_header, write_header, calculate_checksum)
4559 (copy_file, copy_rest, display_header): Likewise.
4560 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4561 Likewise.
4562 * xdisp.c (check_it): Likewise.
4563 * xfaces.c (register_color, unregister_color, unregister_colors):
4564 Likewise.
4565 * xfns.c (print_fontset_result): Likewise.
4566 * xrdb.c (member, fatal, main): Likewise.
4567
4568 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4569
4570 Fix minor problems found by static checking (Bug#9031).
4571 * chartab.c (char_table_set_range, map_sub_char_table):
4572 Remove unused locals.
4573 (uniprop_table): Now static.
4574 * composite.c (_work_char): Remove unused static var.
4575
4576 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4577
4578 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4579
4580 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4581
4582 * gtkutil.c (qttip_cb): Remove code without function.
4583
4584 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4585
4586 * w32.c (pthread_sigmask): New stub.
4587
4588 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4589
4590 Use pthread_sigmask, not sigprocmask (Bug#9010).
4591 sigprocmask is portable only for single-threaded applications, and
4592 Emacs can be multi-threaded when it uses GTK.
4593 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4594 (LIBES): Use it.
4595 * callproc.c (Fcall_process):
4596 * process.c (create_process):
4597 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4598 Use pthread_sigmask, not sigprocmask.
4599
4600 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4601
4602 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4603 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4604 wrong (Bug#8591).
4605
4606 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4607
4608 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4609 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4610 (xg_hide_tooltip): Fix comment.
4611
4612 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4613 in registerServicesMenuSendTypes.
4614 (validRequestorForSendType): Don't check ns_return_types.
4615
4616 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4617 ns_return_type.
4618
4619 2011-07-08 Jason Rumney <jasonr@gnu.org>
4620
4621 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4622 SH_SHOW for hidden windows (Bug#5482).
4623
4624 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4625 frame struct members of non-existent frames (Bug#6284).
4626
4627 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4628
4629 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4630 variable firstTime not needed on OSX >= 10.6.
4631 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4632 >= 10.5. Use setKnobProportion, setDoubleValue.
4633
4634 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4635 (MAC_OS_X_VERSION_10_5): Define if not defined.
4636 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4637 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4638 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4639
4640 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4641 cString and lossyCString on OSX >= 10.4
4642
4643 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4644 sizeToFit on OSX >= 10.2.
4645
4646 * nsimage.m (allocInitFromFile): Don't use deprecated method
4647 bestRepresentationForDevice on OSX >= 10.6.
4648
4649 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4650 to avoid warning.
4651
4652 * emacs.c: Declare unexec_init_emacs_zone.
4653
4654 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4655
4656 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4657
4658 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4659 on svcsMenu (Bug#8842).
4660
4661 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4662 ns_return_types.
4663 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4664
4665 * nsterm.m (QUTF8_STRING): Declare.
4666 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4667 (validRequestorForSendType): Return type is (id).
4668 Change indexOfObjectIdenticalTo to indexOfObject.
4669 Check if we have local selection before returning self (Bug#8842).
4670 (writeSelectionToPasteboard): Put local selection into paste board
4671 if we have a local selection (Bug#8842).
4672 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4673
4674 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4675 (ns_get_local_selection): Declare.
4676
4677 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4678
4679 * keymap.c (describe_map_tree): Don't insert a double newline at
4680 the end of the buffer (bug#1169) and return whether we inserted
4681 something.
4682
4683 * callint.c (Fcall_interactively): Change "reading args" to
4684 "providing args" to try to clarify what it does (bug#1010).
4685
4686 2011-07-07 Kenichi Handa <handa@m17n.org>
4687
4688 * composite.c (composition_compute_stop_pos): Ignore a static
4689 composition starting before CHARPOS (Bug#8915).
4690
4691 * xdisp.c (handle_composition_prop): Likewise.
4692
4693 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4694
4695 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4696 (Bug#9015)
4697
4698 2011-07-07 Kenichi Handa <handa@m17n.org>
4699
4700 * character.h (unicode_category_t): New enum type.
4701
4702 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4703 (Qchar_code_property_table): New variable.
4704 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4705 (UNIPROP_COMPRESSED_FORM_P): New macros.
4706 (char_table_ascii): Uncompress the compressed values.
4707 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4708 Uncompress the compressed values.
4709 (sub_char_table_ref_and_range): Likewise.
4710 (char_table_ref_and_range): Uncompress the compressed values.
4711 (sub_char_table_set): New arg is_uniprop. Callers changed.
4712 Uncompress the compressed values.
4713 (sub_char_table_set_range): Args changed. Callers changed.
4714 (char_table_set_range): Adjuted for the above change.
4715 (map_sub_char_table): Delete args default_val and parent. Add arg
4716 top. Give decoded values to a Lisp function.
4717 (map_char_table): Adjust for the above change. Give decoded
4718 values to a Lisp function. Gcpro more variables.
4719 (uniprop_table_uncompress)
4720 (uniprop_decode_value_run_length): New functions.
4721 (uniprop_decoder, uniprop_decoder_count): New variables.
4722 (uniprop_get_decoder, uniprop_encode_value_character)
4723 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4724 New functions.
4725 (uniprop_encoder, uniprop_encoder_count): New variables.
4726 (uniprop_get_encoder, uniprop_table)
4727 (Funicode_property_table_internal, Fget_unicode_property_internal)
4728 (Fput_unicode_property_internal): New functions.
4729 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4730 Sunicode_property_table_internal, Sget_unicode_property_internal,
4731 and Sput_unicode_property_internal. Defvar_lisp
4732 char-code-property-alist.
4733
4734 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4735 Vunicode_category_table.
4736
4737 * font.c (font_range): Adjust for the change of
4738 Vunicode_category_table.
4739
4740 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4741
4742 * m/iris4d.h: Remove file, move contents ...
4743 * s/irix6-5.h: ... here.
4744
4745 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4746
4747 Remove unportable assumption about struct layout (Bug#8884).
4748 * alloc.c (mark_buffer):
4749 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4750 (clone_per_buffer_values): Don't assume that
4751 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4752 This isn't true in general, and it's particularly not true
4753 if Emacs is configured with --with-wide-int.
4754 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4755 New macros, used in the buffer.c change.
4756
4757 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4758
4759 * xsettings.c: Use both GConf and GSettings if both are available.
4760 (store_config_changed_event): Add comment.
4761 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4762 (store_tool_bar_style_changed): New functions.
4763 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4764 (struct xsettings): Move font inside HAVE_XFT.
4765 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4766 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4767 Move inside HAVE_XFT.
4768 (something_changed_gsettingsCB): Rename from something_changedCB.
4769 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4770 also.
4771 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4772 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4773 (something_changed_gconfCB): Rename from something_changedCB.
4774 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4775 (parse_settings): Move check for font inside HAVE_XFT.
4776 (read_settings, apply_xft_settings): Add comment.
4777 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4778 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4779 call store_font_name_changed.
4780 (xft_settings_event): Add comment.
4781 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4782 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4783 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4784 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4785 (xsettings_initialize): Call init_gsettings last.
4786 (xsettings_get_system_font, xsettings_get_system_normal_font):
4787 Add comment.
4788
4789 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4790
4791 Random fixes. E.g., (random) never returned negative values.
4792 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4793 subseconds part to the entropy, as that's a bit more random.
4794 Prefer signed to unsigned, since the signedness doesn't matter and
4795 in general we prefer signed. When given a limit, use a
4796 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4797 latter isn't right if USE_2_TAGS_FOR_INTS.
4798 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4799 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4800
4801 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4802
4803 * textprop.c (text_property_stickiness):
4804 Obey Vtext_property_default_nonsticky.
4805 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4806 * w32fns.c (syms_of_w32fns):
4807 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4808
4809 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4810
4811 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4812 This is more efficient than Ffile_directory_p and avoids a minor race.
4813
4814 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4815
4816 * buffer.c (Foverlay_put): Say what the return value is
4817 (bug#7835).
4818
4819 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4820 is a directory before asking whether to use the file name
4821 (bug#7564).
4822 (barf_or_query_if_file_exists): Make the "File is a directory"
4823 error be more correct.
4824
4825 * fns.c (Frequire): Remove the mention of the .gz files, since
4826 that's installation-specific, but keep the mention of
4827 `get-load-suffixes'.
4828
4829 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4830
4831 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4832 Report string overflow if the output is too long.
4833
4834 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4835
4836 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4837 (syms_of_gnutls): Remove duplicate DEFSYM for
4838 Qgnutls_bootprop_verify_hostname_error, an error for
4839 Qgnutls_bootprop_verify_error (which is no longer used).
4840
4841 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4842 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4843 Also (re)move comments that are misplaced or no longer relevant.
4844
4845 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4846
4847 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4848
4849 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4850
4851 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4852 and background color parameters if they have been changed.
4853
4854 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4855
4856 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4857
4858 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4859
4860 * xsettings.c (SYSTEM_FONT): Define only when used.
4861 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4862
4863 * keymap.c (access_keymap_1): Now static.
4864
4865 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4866
4867 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4868 leave any prefix arg for the up event (Bug#1586).
4869
4870 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4871
4872 * lread.c (syms_of_lread): Mention single symbols defined by
4873 `defvar' or `defconst' (bug#7154).
4874
4875 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4876 (Frequire): Mention get-load-suffixes.
4877
4878 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4879
4880 * window.h (window): Remove clone_number slot.
4881 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4882 Remove.
4883 (make_parent_window, make_window, saved_window)
4884 (Fset_window_configuration, save_window_save): Don't deal with
4885 clone numbers.
4886 * buffer.c (Qclone_number): Remove declaration.
4887 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4888
4889 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4890
4891 Add multiple inheritance to keymaps.
4892 * keymap.c (Fmake_composed_keymap): New function.
4893 (Fset_keymap_parent): Simplify.
4894 (fix_submap_inheritance): Remove.
4895 (access_keymap_1): New function extracted from access_keymap to handle
4896 embedded parents and handle lists of maps.
4897 (access_keymap): Use it.
4898 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4899 (Fcopy_keymap): Handle embedded parents.
4900 (Fcommand_remapping, define_as_prefix): Simplify.
4901 (Fkey_binding): Simplify.
4902 (syms_of_keymap): Move minibuffer-local-completion-map,
4903 minibuffer-local-filename-completion-map,
4904 minibuffer-local-must-match-map, and
4905 minibuffer-local-filename-must-match-map to Elisp.
4906 (syms_of_keymap): Defsubr make-composed-keymap.
4907 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4908 (parse_menu_item): Trivial simplification.
4909
4910 2011-07-01 Glenn Morris <rgm@gnu.org>
4911
4912 * Makefile.in (SETTINGS_LIBS): Fix typo.
4913
4914 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4915
4916 * coding.c (Fencode_coding_string): Record the last coding system
4917 used, as the function doc string says (bug#8738).
4918
4919 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4920
4921 * xsettings.c (store_monospaced_changed): Take new font as arg and
4922 check for change against current_mono_font.
4923 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4924 (emacs_settings_constructor, emacs_settings_get_property)
4925 (emacs_settings_set_property, emacs_settings_class_init)
4926 (emacs_settings_init, gsettings_obj): Remove.
4927 (something_changedCB): New function for HAVE_GSETTINGS.
4928 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4929 with value as argument.
4930 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4931 g_settings_new (Bug#8967). Do not create gsettings_obj.
4932 Remove calls to g_settings_bind. Connect something_changedCB to
4933 "changed".
4934
4935 * xgselect.c: Add defined (HAVE_GSETTINGS).
4936 (xgselect_initialize): Ditto.
4937
4938 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4939 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4940 xg_select.
4941
4942 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4943
4944 * eval.c (struct backtrace): Simplify and port the data structure.
4945 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4946 signed bit field, as this assumption is not portable and it makes
4947 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4948 "char debug_on_exit : 1" as this is not portable either; instead,
4949 use the portable "unsigned int debug_on_exit : 1". Remove unused
4950 member evalargs. Remove obsolete comments about cc bombing out.
4951
4952 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4953
4954 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4955 Let HAVE_GSETTINGS override HAVE_GCONF.
4956 (store_monospaced_changed): New function.
4957 (EMACS_SETTINGS): A new type derived from GObject to handle
4958 GSettings notifications.
4959 (emacs_settings_constructor, emacs_settings_get_property)
4960 (emacs_settings_set_property, emacs_settings_class_init):
4961 New functions.
4962 (gsettings_client, gsettings_obj): New variables.
4963 (GSETTINGS_SCHEMA): New define.
4964 (something_changedCB): Call store_monospaced_changed.
4965 (init_gsettings): New function.
4966 (xsettings_initialize): Call init_gsettings.
4967 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4968 to NULL.
4969
4970 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4971 GCONF_CFLAGS/LIBS.
4972
4973 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4974
4975 * window.c (resize_root_window, grow_mini_window)
4976 (shrink_mini_window): Rename Qresize_root_window to
4977 Qwindow_resize_root_window and Qresize_root_window_vertically to
4978 Qwindow_resize_root_window_vertically.
4979
4980 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4981
4982 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4983
4984 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4985
4986 * makefile.w32-in: Redesign dependencies so they reflect more
4987 clearly which files are directly included by each source file,
4988 and not through other includes.
4989
4990 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4991
4992 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4993 (sort_overlays, overlay_strings): When an overlay's clone number
4994 matches the window's clone number process the overlay even if
4995 the overlay's window property doesn't match the current window.
4996
4997 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4998 (Fwindow_hchild): Rename to Fwindow_left_child.
4999 (Fwindow_next): Rename to Fwindow_next_sibling.
5000 (Fwindow_prev): Rename to Fwindow_prev_sibling.
5001 (resize_window_check): Rename to window_resize_check.
5002 (resize_window_apply): Rename to window_resize_apply.
5003 (Fresize_window_apply): Rename to Fwindow_resize_apply.
5004 (Fdelete_other_windows_internal, resize_frame_windows)
5005 (Fsplit_window_internal, Fdelete_window_internal)
5006 (grow_mini_window, shrink_mini_window)
5007 (Fresize_mini_window_internal): Fix callers accordingly.
5008
5009 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
5010
5011 * emacsgtkfixed.h: State that this is only used with Gtk+3.
5012 (emacs_fixed_set_min_size): Remove.
5013 (emacs_fixed_new): Take frame as argument.
5014
5015 * emacsgtkfixed.c: State that this is only used with Gtk+3.
5016 (_EmacsFixedPrivate): Remove minwidth/height.
5017 Add struct frame *f.
5018 (emacs_fixed_init): Initialize priv->f.
5019 (get_parent_class, emacs_fixed_set_min_size): Remove.
5020 (emacs_fixed_new): Set priv->f to argument.
5021 (emacs_fixed_get_preferred_width)
5022 (emacs_fixed_get_preferred_height): Use min_width/height from
5023 frames size_hint to set minimum and natural (Bug#8919).
5024 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
5025 and use min_width/height from frames size_hint to set
5026 min_width/height (Bug#8919).
5027
5028 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
5029 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
5030 Fix indentation.
5031
5032 2011-06-26 Eli Zaretskii <eliz@gnu.org>
5033
5034 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
5035 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
5036 called at ZV.
5037
5038 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
5039
5040 * process.c (wait_reading_process_output): Bypass select if
5041 waiting for a cell while ignoring keyboard input, and input is
5042 pending. Suggested by Jan Djärv (Bug#8869).
5043
5044 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
5045
5046 Use gnulib's dup2 module instead of rolling our own.
5047 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
5048
5049 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5050
5051 * dispnew.c (scrolling_window): Before scrolling, turn off a
5052 mouse-highlight in the window being scrolled.
5053
5054 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
5055
5056 Move DEFSYM to lisp.h and use everywhere.
5057
5058 * character.h (DEFSYM): Move declaration...
5059 * lisp.h (DEFSYM): ...here.
5060
5061 * gnutls.c:
5062 * minibuf.c:
5063 * w32menu.c:
5064 * w32proc.c:
5065 * w32select.c: Don't include character.h.
5066
5067 * alloc.c (syms_of_alloc):
5068 * buffer.c (syms_of_buffer):
5069 * bytecode.c (syms_of_bytecode):
5070 * callint.c (syms_of_callint):
5071 * casefiddle.c (syms_of_casefiddle):
5072 * casetab.c (init_casetab_once):
5073 * category.c (init_category_once, syms_of_category):
5074 * ccl.c (syms_of_ccl):
5075 * cmds.c (syms_of_cmds):
5076 * composite.c (syms_of_composite):
5077 * dbusbind.c (syms_of_dbusbind):
5078 * dired.c (syms_of_dired):
5079 * dispnew.c (syms_of_display):
5080 * doc.c (syms_of_doc):
5081 * editfns.c (syms_of_editfns):
5082 * emacs.c (syms_of_emacs):
5083 * eval.c (syms_of_eval):
5084 * fileio.c (syms_of_fileio):
5085 * fns.c (syms_of_fns):
5086 * frame.c (syms_of_frame):
5087 * fringe.c (syms_of_fringe):
5088 * insdel.c (syms_of_insdel):
5089 * keymap.c (syms_of_keymap):
5090 * lread.c (init_obarray, syms_of_lread):
5091 * macros.c (syms_of_macros):
5092 * msdos.c (syms_of_msdos):
5093 * print.c (syms_of_print):
5094 * process.c (syms_of_process):
5095 * search.c (syms_of_search):
5096 * sound.c (syms_of_sound):
5097 * syntax.c (init_syntax_once, syms_of_syntax):
5098 * terminal.c (syms_of_terminal):
5099 * textprop.c (syms_of_textprop):
5100 * undo.c (syms_of_undo):
5101 * w32.c (globals_of_w32):
5102 * window.c (syms_of_window):
5103 * xdisp.c (syms_of_xdisp):
5104 * xfaces.c (syms_of_xfaces):
5105 * xfns.c (syms_of_xfns):
5106 * xmenu.c (syms_of_xmenu):
5107 * xsettings.c (syms_of_xsettings):
5108 * xterm.c (syms_of_xterm): Use DEFSYM.
5109
5110 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5111
5112 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
5113
5114 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5115
5116 Integer and buffer overflow fixes (Bug#8873).
5117
5118 * print.c (printchar, strout): Check for string overflow.
5119 (PRINTPREPARE, printchar, strout):
5120 Don't set size unless allocation succeeds.
5121
5122 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5123 for sizes. Check for string overflow more accurately.
5124 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5125
5126 * macros.c: Integer and buffer overflow fixes.
5127 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5128 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5129 Use ptrdiff_t, not int, for sizes.
5130 Don't increment bufsize until after realloc succeeds.
5131 Check for size-calculation overflow.
5132 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5133
5134 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5135
5136 * lread.c: Integer overflow fixes.
5137 (read_integer): Radix is now EMACS_INT, not int,
5138 to improve quality of diagnostics for out-of-range radices.
5139 Calculate buffer size correctly for out-of-range radices.
5140 (read1): Check for integer overflow in radices, and in
5141 read-circle numbers.
5142 (read_escape): Avoid int overflow.
5143 (Fload, openp, read_buffer_size, read1)
5144 (substitute_object_recurse, read_vector, read_list, map_obarray):
5145 Use ptrdiff_t, not int, for sizes.
5146 (read1): Use EMACS_INT, not int, for sizes.
5147 Check for size overflow.
5148
5149 * image.c (cache_image): Check for size arithmetic overflow.
5150
5151 * lread.c: Integer overflow issues.
5152 (saved_doc_string_size, saved_doc_string_length)
5153 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5154 Now ptrdiff_t, not int.
5155 (read1): Don't assume doc string length fits in int. Check for
5156 out-of-range doc string lengths.
5157 (read_list): Don't assume file position fits in int.
5158 (read_escape): Check for hex character overflow.
5159
5160 2011-06-22 Leo Liu <sdl.web@gmail.com>
5161
5162 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5163 Move to minibuffer.el.
5164
5165 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5166
5167 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
5168 The following patches are for when GLYPH_DEBUG && !XASSERT.
5169 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5170 * dispnew.c (flush_stdout):
5171 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5172 Mark as externally visible.
5173 * dispnew.c (check_window_matrix_pointers): Now static.
5174 * dispnew.c (window_to_frame_vpos):
5175 * xfns.c (unwind_create_frame):
5176 * xterm.c (x_check_font): Remove unused local.
5177 * scroll.c (CHECK_BOUNDS):
5178 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5179 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5180 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5181 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5182 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5183 Now static.
5184 (debug_method_add): Use va_list and vsprintf rather than relying
5185 on undefined behavior with wrong number of arguments.
5186 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5187 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5188 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5189 since we're not interested in debugging glyphs with old libraries.
5190 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5191 GCC 4.6.0's static checking.
5192
5193 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5194
5195 Integer overflow and signedness fixes (Bug#8873).
5196 A few related buffer overrun fixes, too.
5197
5198 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5199
5200 * dispextern.h (struct face.stipple):
5201 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5202 (x_bitmap_mask, x_allocate_bitmap_record)
5203 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5204 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5205 (x_create_bitmap_from_xpm_data):
5206 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5207 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5208 (.bitmaps_last):
5209 * xfaces.c (load_pixmap):
5210 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5211 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5212 (.bitmaps_last, struct x_output.icon_bitmap):
5213 Use ptrdiff_t, not int, for bitmap indexes.
5214 (x_allocate_bitmap_record): Check for size overflow.
5215 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5216
5217 Use ptrdiff_t, not int, for overlay counts.
5218 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5219 * editfns.c (overlays_around, get_pos_property):
5220 * textprop.c (get_char_property_and_overlay):
5221 * xdisp.c (next_overlay_change, note_mouse_highlight):
5222 * xfaces.c (face_at_buffer_position):
5223 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5224 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5225 (Fnext_overlay_change, Fprevious_overlay_change)
5226 (mouse_face_overlay_overlaps, Foverlays_in):
5227 Use ptrdiff_t, not int, for sizes.
5228 (overlays_at, overlays_in): Check for size-calculation overflow.
5229
5230 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5231
5232 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5233 (x_session_initialize): Do not assume string length fits in int.
5234
5235 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5236 This is unlikely, but can occur if DPI is outlandish.
5237
5238 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
5239 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5240
5241 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5242 * xrdb.c (magic_file_p, search_magic_path):
5243 Omit last arg SUFFIX; it was always 0. All callers changed.
5244 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5245
5246 * xfont.c (xfont_match): Avoid need for strlen.
5247
5248 * xfns.c: Don't assume strlen fits in int.
5249 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5250
5251 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5252 not unsigned long, as we prefer signed integers. All callers changed.
5253 Detect integer overflow in repeat count.
5254 (message_dolog): Don't assume print length fits in 39 bytes.
5255 (display_mode_element): Don't assume strlen fits in int.
5256
5257 * termcap.c: Don't assume sizes fit in int and never overflow.
5258 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5259 (gobble_line): Check for size-calculation overflow.
5260
5261 * minibuf.c (Fread_buffer):
5262 * lread.c (intern, intern_c_string):
5263 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5264 Don't assume string length fits in int.
5265
5266 * keyboard.c (parse_tool_bar_item):
5267 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5268
5269 * font.c: Don't assume string length fits in int.
5270 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5271 Use ptrdiff_t, not int.
5272 (font_intern_prop): Don't assume string length fits in int.
5273 Don't assume integer property fits in fixnum.
5274 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5275
5276 * filelock.c: Fix some buffer overrun and integer overflow issues.
5277 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5278 Reformulate so as not to need the command string.
5279 Invoke gzip -cd rather than gunzip, as it's more portable.
5280 (lock_info_type, lock_file_1, lock_file):
5281 Don't assume pid_t and time_t fit in unsigned long.
5282 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5283 (current_lock_owner): Prefer signed type for sizes.
5284 Use memcpy, not strncpy, where memcpy is what is really wanted.
5285 Don't assume (via atoi) that time_t and pid_t fit in int.
5286 Check for time_t and/or pid_t out of range, e.g., via a network share.
5287 Don't alloca where an auto var works fine.
5288
5289 * fileio.c: Fix some integer overflow issues.
5290 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5291 Don't assume string length fits in int.
5292 (directory_file_name): Don't assume string length fits in long.
5293 (make_temp_name): Don't assume pid fits in int, or that its print
5294 length is less than 20.
5295
5296 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5297
5298 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5299
5300 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5301
5302 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5303 We prefer signed integers, even for size calculations.
5304
5305 * emacs.c: Don't assume string length fits in 'int'.
5306 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5307 (main): Don't invoke strlen when not needed.
5308
5309 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5310 (XD_DEBUG_MESSAGE): Don't waste a byte.
5311
5312 * callproc.c (getenv_internal_1, getenv_internal)
5313 (Fgetenv_internal):
5314 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5315
5316 * lread.c (invalid_syntax): Omit length argument.
5317 All uses changed. This doesn't fix a bug, but it simplifies the
5318 code away from its former Hollerith-constant appearance, and it's
5319 one less 'int' to worry about when looking at integer-overflow issues.
5320 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5321
5322 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5323 This didn't break anything, but it didn't help either.
5324 It's confusing to put a bogus integer in a place where the actual
5325 value does not matter.
5326 (LIST_END_P): Remove unused macro and its bogus comment.
5327 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5328
5329 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5330 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5331 implementation.
5332 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5333 We prefer signed types, and the value cannot exceed the EMACS_INT
5334 range anyway (because otherwise the length would not be representable).
5335 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5336 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5337 This avoids a GCC warning when WIDE_EMACS_INT.
5338
5339 * indent.c (sane_tab_width): New function.
5340 (current_column, scan_for_column, Findent_to, position_indentation)
5341 (compute_motion): Use it. This is just for clarity.
5342 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5343
5344 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5345
5346 * lisp.h (lint_assume): New macro.
5347 * composite.c (composition_gstring_put_cache):
5348 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5349
5350 * editfns.c, insdel.c:
5351 Omit unnecessary forward decls, to simplify future changes.
5352
5353 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5354
5355 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5356
5357 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5358 Use much-faster test for byte-length change.
5359 Don't assume string byte-length fits in 'int'.
5360 Check that character arg fits in 'int'.
5361 (mapcar1): Declare byte as byte, for clarity.
5362
5363 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5364
5365 * fns.c (concat): Catch string overflow earlier.
5366 Do not rely on integer wraparound.
5367
5368 * dispextern.h (struct it.overlay_strings_charpos)
5369 (struct it.selective): Now EMACS_INT, not int.
5370 * xdisp.c (forward_to_next_line_start)
5371 (back_to_previous_visible_line_start)
5372 (reseat_at_next_visible_line_start, next_element_from_buffer):
5373 Don't arbitrarily truncate the value of 'selective' to int.
5374
5375 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5376
5377 * composite.c: Don't truncate sizes to 'int'.
5378 (composition_gstring_p, composition_reseat_it)
5379 (composition_adjust_point): Use EMACS_INT, not int.
5380 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5381 not EMACS_UINT, for indexes.
5382
5383 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5384
5385 * buffer.c: Include <verify.h>.
5386 (struct sortvec.priority, struct sortstr.priority):
5387 Now EMACS_INT, not int.
5388 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5389 (struct sortstr.size, record_overlay_string)
5390 (struct sortstrlist.size, struct sortlist.used):
5391 Don't truncate size to int.
5392 (record_overlay_string): Check for size-calculation overflow.
5393 (init_buffer_once): Check at compile-time, not run-time.
5394
5395 2011-06-22 Jim Meyering <meyering@redhat.com>
5396
5397 Don't leak an XBM-image-sized buffer
5398 * image.c (xbm_load): Free the image buffer after using it.
5399
5400 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5401
5402 Port to Sun C.
5403 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5404 that Sun C diagnosed.
5405 * fns.c (secure_hash): Fix pointer signedness issue.
5406 * intervals.c (static_offset_intervals): New function.
5407 (offset_intervals): Use it.
5408
5409 2011-06-21 Leo Liu <sdl.web@gmail.com>
5410
5411 * deps.mk (fns.o):
5412 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5413 sha512.h.
5414
5415 * fns.c (secure_hash): Rename from crypto_hash_function and change
5416 the first arg to accept symbols.
5417 (Fsecure_hash): New primitive.
5418 (syms_of_fns): New symbols.
5419
5420 2011-06-20 Deniz Dogan <deniz@dogan.se>
5421
5422 * process.c (Fset_process_buffer): Clarify return value in
5423 docstring.
5424
5425 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5426
5427 * dispnew.c (add_window_display_history): Use BVAR.
5428
5429 * xdisp.c (debug_method_add): Use BVAR.
5430 (check_window_end, dump_glyph_matrix, dump_glyph)
5431 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5432
5433 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5434 Likewise.
5435
5436 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5437 check till after the cache is created in init_frame_faces.
5438
5439 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5440
5441 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5442
5443 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5444
5445 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5446 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5447 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5448
5449 Improve buffer-overflow checking (Bug#8873).
5450 * fileio.c (Finsert_file_contents):
5451 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5452 Remove the old (too-loose) buffer overflow checks.
5453 They weren't needed, since make_gap checks for buffer overflow.
5454 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5455 The old code merely checked for Emacs fixnum overflow, and relied
5456 on undefined (wraparound) behavior. The new code avoids undefined
5457 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5458
5459 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5460 Tune. Don't use wider integers than needed. Don't use alloca.
5461 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5462
5463 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5464
5465 * insdel.c, lisp.h (buffer_overflow): New function.
5466 (insert_from_buffer_1, replace_range, replace_range_2):
5467 * insdel.c (make_gap_larger):
5468 * editfns.c (Finsert_char):
5469 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5470
5471 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5472
5473 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5474
5475 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5476
5477 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5478 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5479
5480 * fileio.c: Don't assume EMACS_INT fits in off_t.
5481 (emacs_lseek): New static function.
5482 (Finsert_file_contents, Fwrite_region): Use it.
5483 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5484
5485 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5486
5487 * fns.c: Don't overflow int when computing a list length.
5488 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5489 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5490 truncation on 64-bit hosts. Check for QUIT every
5491 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5492 faster and is responsive enough.
5493 (Flength): Report an error instead of overflowing an integer.
5494 (Fsafe_length): Return a float if the value is not representable
5495 as a fixnum. This shouldn't happen except in contrived situations.
5496 (Fnthcdr, Fsort): Don't assume list length fits in int.
5497 (Fcopy_sequence): Don't assume vector length fits in int.
5498
5499 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5500 (header_size, word_size): New constants.
5501 (allocate_vectorlike): Don't check size overflow here.
5502 (allocate_vector): Check it here instead, since this is the only
5503 caller of allocate_vectorlike that could cause overflow.
5504 Check that the new vector's length is representable as a fixnum.
5505
5506 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5507 The previous code was bogus. For example, next_almost_prime (32)
5508 returned 39, which is undesirable as it is a multiple of 3; and
5509 next_almost_prime (24) returned 25, which is a multiple of 5 so
5510 why was the code bothering to check for multiples of 7?
5511
5512 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5513
5514 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5515
5516 Variadic C functions now count arguments with ptrdiff_t.
5517 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5518 Back then I didn't know that the Emacs coding style prefers signed int.
5519 Also, in the meantime I found a few more instances where arguments
5520 were being counted with int, which may truncate counts on 64-bit
5521 machines, or EMACS_INT, which may be unnecessarily wide.
5522 * lisp.h (struct Lisp_Subr.function.aMANY)
5523 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5524 Arg counts are now ptrdiff_t, not size_t.
5525 All variadic functions and their callers changed accordingly.
5526 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5527 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5528 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5529 * callint.c (Fcall_interactively): Check arg count for overflow,
5530 to avoid potential buffer overrun. Use signed char, not 'int',
5531 for 'varies' array, so that we needn't bother to check its size
5532 calculation for overflow.
5533 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5534 * eval.c (apply_lambda):
5535 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5536 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5537 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5538
5539 * callint.c (Fcall_interactively): Don't use index var as event count.
5540
5541 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5542 * mem-limits.h (SIZE): Remove; no longer used.
5543
5544 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5545
5546 Remove unnecessary casts.
5547 * xterm.c (x_term_init):
5548 * xfns.c (x_set_border_pixel):
5549 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5550 These aren't needed now that we assume ANSI C.
5551
5552 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5553 It's more likely to cause problems (due to unsigned overflow)
5554 than to cure them.
5555
5556 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5557
5558 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5559
5560 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5561
5562 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5563
5564 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5565
5566 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5567
5568 GLYPH_CODE_FACE returns EMACS_INT, not int.
5569 * dispextern.h (merge_faces):
5570 * xfaces.c (merge_faces):
5571 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5572 Don't assume EMACS_INT fits in int.
5573
5574 * character.h (CHAR_VALID_P): Remove unused parameter.
5575 * fontset.c, lisp.h, xdisp.c: All uses changed.
5576
5577 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5578
5579 * fns.c (concat): Minor tuning based on overflow analysis.
5580 This doesn't fix any bugs. Use int to hold character, instead
5581 of constantly refetching from Emacs object. Use XFASTINT, not
5582 XINT, for value known to be a character. Don't bother comparing
5583 a single byte to 0400, as it's always less.
5584
5585 * floatfns.c (Fexpt):
5586 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5587
5588 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5589 for characters.
5590
5591 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5592
5593 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5594 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5595 incorrectly succeed when S was a string, because 4294967386 was
5596 truncated before it was used.
5597
5598 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5599 Otherwise, an out-of-range integer could cause undefined behavior
5600 on a 64-bit host.
5601
5602 * composite.c: Use int, not EMACS_INT, for characters.
5603 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5604 EMACS_INT, for values that are known to be in character range.
5605 This doesn't fix any bugs but is the usual style inside Emacs and
5606 may generate better code on 32-bit machines.
5607
5608 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5609 This is for reasons similar to the recent CHAR_STRING fix.
5610 * charset.c (Fencode_char): Check that character arg is actually
5611 a character. Pass an int to ENCODE_CHAR.
5612 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5613 wider than 'int', as a compile-time check to prevent future regressions
5614 in this area.
5615
5616 * character.c (char_string): Remove unnecessary casts.
5617
5618 Make sure a 64-bit char is never passed to CHAR_STRING.
5619 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5620 by silently ignoring the top 32 bits, allowing some values
5621 that were far too large to be valid characters.
5622 * character.h: Include <verify.h>.
5623 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5624 arguments are no wider than unsigned, as a compile-time check
5625 to prevent future regressions in this area.
5626 * data.c (Faset):
5627 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5628 (Fsubst_char_in_region):
5629 * fns.c (concat):
5630 * xdisp.c (decode_mode_spec_coding):
5631 Adjust to CHAR_STRING's new requirement.
5632 * editfns.c (Finsert_char, Fsubst_char_in_region):
5633 * fns.c (concat): Check that character args are actually
5634 characters. Without this test, these functions did the wrong
5635 thing with wildly out-of-range values on 64-bit hosts.
5636
5637 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5638 These casts should not be needed on 32-bit hosts, either.
5639 * keyboard.c (read_char):
5640 * lread.c (Fload): Remove casts to unsigned.
5641
5642 * lisp.h (UNSIGNED_CMP): New macro.
5643 This fixes comparison bugs on 64-bit hosts.
5644 (ASCII_CHAR_P): Use it.
5645 * casefiddle.c (casify_object):
5646 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5647 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5648 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5649 * dispextern.h (FACE_FROM_ID):
5650 * keyboard.c (read_char): Use UNSIGNED_CMP.
5651
5652 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5653 not to EMACS_INT, to avoid GCC warning.
5654
5655 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5656
5657 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5658 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5659 isn't needed on 32-bit machines.
5660
5661 * buffer.c (Fgenerate_new_buffer_name):
5662 Use EMACS_INT for count, not int.
5663 (advance_to_char_boundary): Return EMACS_INT, not int.
5664
5665 * data.c (Qcompiled_function): Now static.
5666
5667 * window.c (window_body_lines): Now static.
5668
5669 * image.c (gif_load): Rename local to avoid shadowing.
5670
5671 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5672 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5673 * alloc.c (make_save_value): Integer argument is now of type
5674 ptrdiff_t, not int.
5675 (mark_object): Use ptrdiff_t, not int.
5676 * lisp.h (pD): New macro.
5677 * print.c (print_object): Use it.
5678
5679 * alloc.c: Use EMACS_INT, not int, to count objects.
5680 (total_conses, total_markers, total_symbols, total_vector_size)
5681 (total_free_conses, total_free_markers, total_free_symbols)
5682 (total_free_floats, total_floats, total_free_intervals)
5683 (total_intervals, total_strings, total_free_strings):
5684 Now EMACS_INT, not int. All uses changed.
5685 (Fgarbage_collect): Compute overall total using a double, so that
5686 integer overflow is less likely to be a problem. Check for overflow
5687 when converting back to an integer.
5688 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5689 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5690 These were 'int' variables that could overflow on 64-bit hosts;
5691 they were never used, so remove them instead of repairing them.
5692 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5693 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5694 Previously, this ceilinged at INT_MAX, but that doesn't work on
5695 64-bit machines.
5696 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5697
5698 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5699 (allocate_vectorlike): Check for ptrdiff_t overflow.
5700 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5701 when a (possibly-narrower) signed value would do just as well.
5702 We prefer using signed arithmetic, to avoid comparison confusion.
5703
5704 * alloc.c: Catch some string size overflows that we were missing.
5705 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5706 for convenience in STRING_BYTES_MAX.
5707 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5708 The definition here is exact; the one in lisp.h was approximate.
5709 (allocate_string_data): Check for string overflow. This catches
5710 some instances we weren't catching before. Also, it catches
5711 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5712 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5713 and ptrdiff_t and EMACS_INT are both 64 bits.
5714
5715 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5716 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5717 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5718
5719 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5720
5721 * alloc.c (Fmake_string): Check for out-of-range init.
5722
5723 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5724
5725 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5726
5727 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5728
5729 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5730 xg_get_default_scrollbar_width.
5731
5732 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5733 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5734 (style_changed_cb): Call update_theme_scrollbar_width and call
5735 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5736 all frames (Bug#8505).
5737 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5738 Call gtk_window_set_resizable if HAVE_GTK3.
5739 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5740 and height if HAVE_GTK3 (Bug#8505).
5741 (scroll_bar_width_for_theme): New variable.
5742 (update_theme_scrollbar_width): New function.
5743 (xg_get_default_scrollbar_width): Move code to
5744 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5745 (xg_initialize): Call update_theme_scrollbar_width.
5746
5747 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5748
5749 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5750
5751 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5752
5753 * frame.c (make_frame): Call other_buffer_safely instead of
5754 other_buffer.
5755
5756 * window.c (temp_output_buffer_show): Call display_buffer with
5757 second argument Vtemp_buffer_show_specifiers and reset latter
5758 immediately after the call.
5759 (Vtemp_buffer_show_specifiers): New variable.
5760 (auto_window_vscroll_p, next_screen_context_lines)
5761 (Vscroll_preserve_screen_position): Remove leading asterisks from
5762 doc-strings.
5763
5764 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5765
5766 Fix minor problems found by GCC 4.6.0 static checking.
5767 * buffer.c (Qclone_number): Remove for now, as it's unused.
5768 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5769 (record_buffer): Remove unused local.
5770 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5771 (set_frame_buffer_list): Remove; unused.
5772 * frame.h (other_visible_frames): Remove decl.
5773 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5774 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5775 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5776 if HAVE_GPM.
5777 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5778 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5779 Define only if HAVE_GPM.
5780 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5781 (update_hints_inhibit): Remove; never set. All uses removed.
5782 * widgetprv.h (emacsFrameClassRec): Remove decl.
5783 * window.c (delete_deletable_window): Now returns void, since it
5784 wasn't returning anything.
5785 (compare_window_configurations): Remove unused locals.
5786 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5787 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5788 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5789 the same widths as pointers. This follows up on the 2011-05-06 patch.
5790 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5791 * xterm.h: Likewise.
5792 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5793
5794 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5795
5796 * makefile.w32-in: Update dependencies.
5797 (LISP_H): Add lib/intprops.h.
5798
5799 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5800
5801 * image.c (gif_load): Add animation frame delay to the metadata.
5802 (syms_of_image): Use DEFSYM. New symbol `delay'.
5803
5804 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5805
5806 * window.c (delete_deletable_window): Re-add.
5807 (Fset_window_configuration): Rewrite to handle dead buffers and
5808 consequently deletable windows.
5809 (window_tree, Fwindow_tree): Remove. Supply functionality in
5810 window.el.
5811 (compare_window_configurations): Simplify code.
5812
5813 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5814
5815 * image.c (imagemagick_load_image): Fix type mismatch.
5816 (Fimagemagick_types): Likewise.
5817
5818 * window.h (replace_buffer_in_windows): Declare.
5819
5820 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5821
5822 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5823 Qclone_number. Remove external declaration of Qdelete_window.
5824 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5825 code.
5826 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5827 Run Qbuffer_list_update_hook if allowed.
5828 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5829 buffer list implementation.
5830 (other_buffer_safely): New function.
5831 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5832 calls to replace_buffer_in_windows and
5833 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5834 if allowed.
5835 (record_buffer): Inhibit quitting and rewrite using quittable
5836 functions. Run Qbuffer_list_update_hook if allowed.
5837 (Frecord_buffer, Funrecord_buffer): New functions.
5838 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5839 Move switch-to-buffer to window.el.
5840 (bury-buffer): Move to window.el.
5841 (Vbuffer_list_update_hook): New variable.
5842
5843 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5844 section.
5845
5846 * window.h (resize_frame_windows): Move up in code.
5847 (Fwindow_frame): Remove EXFUN.
5848 (replace_buffer_in_all_windows): Remove prototype.
5849 (replace_buffer_in_windows_safely): Add prototype.
5850
5851 * window.c: Declare Qdelete_window static again. Move down
5852 declaration of select_count.
5853 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5854 (Fother_window): Move to window.el.
5855 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5856 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5857 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5858 window.el.
5859 (replace_buffer_in_windows): Implement by calling
5860 Qreplace_buffer_in_windows.
5861 (replace_buffer_in_all_windows): Remove with some functionality
5862 moved into replace_buffer_in_windows_safely.
5863 (replace_buffer_in_windows_safely): New function.
5864 (select_window_norecord, select_frame_norecord): Move in front
5865 of run_window_configuration_change_hook. Remove now obsolete
5866 declarations.
5867 (Fset_window_buffer): Rewrite doc-string.
5868 Call Qrecord_window_buffer.
5869 (keys_of_window): Move binding for other-window to window.el.
5870
5871 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5872
5873 * dispextern.h (struct image): Replace data member, whose int_val
5874 and ptr_val fields were not used by anything, with a single
5875 lisp_val object.
5876
5877 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5878 (gif_clear_image, gif_load, imagemagick_load_image)
5879 (gs_clear_image, gs_load): Callers changed.
5880
5881 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5882
5883 * buffer.h: Include <time.h>, for time_t.
5884 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5885
5886 Fix minor problems found by static checking.
5887
5888 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5889
5890 Make identifiers static if they are not used in other modules.
5891 * data.c (Qcompiled_function, Qframe, Qvector):
5892 * image.c (QimageMagick, Qsvg):
5893 * minibuf.c (Qmetadata):
5894 * window.c (resize_window_check, resize_root_window): Now static.
5895 * window.h (resize_window_check, resize_root_window): Remove decls.
5896
5897 * window.c (window_deletion_count, delete_deletable_window):
5898 Remove; unused.
5899 (window_body_lines): Now static.
5900 (Fdelete_other_windows_internal): Mark vars as initialized.
5901 Make sure 'resize_failed' is initialized.
5902 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5903 (resize_window_apply): Remove unused local.
5904 * window.h (delete_deletable_window): Remove decl.
5905
5906 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5907 (imagemagick_load_image): Fix pointer signedness problem by changing
5908 last arg from unsigned char * to char *. All uses changed.
5909 Also, fix a local for similar reasons.
5910 Remove unused locals. Remove locals to avoid shadowing.
5911 (fn_rsvg_handle_free): Remove; unused.
5912 (svg_load, svg_load_image): Fix pointer signedness problem.
5913 (imagemagick_load_image): Don't use garbage pointer image_wand.
5914
5915 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5916
5917 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5918
5919 * image.c (gif_load): Fix omitted cast error introduced by
5920 2011-06-06 change.
5921
5922 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5923
5924 * window.h (resize_proportionally, orig_total_lines)
5925 (orig_top_line): Remove from window structure.
5926 (set_window_height, set_window_width, change_window_heights)
5927 (Fdelete_window): Remove prototypes.
5928 (resize_frame_windows): Remove duplicate declaration.
5929
5930 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5931
5932 * window.h (resize_frame_windows, resize_window_check)
5933 (delete_deletable_window, resize_root_window)
5934 (resize_frame_windows): Declare prototypes.
5935
5936 * window.c (resize_window_apply): Make definition be "static" to
5937 match the prototype.
5938
5939 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5940
5941 * window.c: Remove declarations of Qwindow_size_fixed,
5942 window_min_size_1, window_min_size_2, window_min_size,
5943 size_window, window_fixed_size_p, enlarge_window, delete_window.
5944 Remove static from declaration of Qdelete_window, it's
5945 temporarily needed by Fbury_buffer.
5946 (replace_window): Don't assign orig_top_line and
5947 orig_total_lines.
5948 (Fdelete_window, delete_window): Remove. Window deletion is
5949 handled by window.el.
5950 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5951 Replace Fdelete_window calls with calls to Qdelete_window.
5952 (Fdelete_other_windows): Remove. Deleting other windows is
5953 handled by window.el.
5954 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5955 handled in window.el.
5956 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5957 Window minimum sizes are handled in window.el.
5958 (shrink_windows, size_window, set_window_height)
5959 (set_window_width, change_window_heights, window_height)
5960 (window_width, CURBEG, CURSIZE, enlarge_window)
5961 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5962 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5963 handled in window.el.
5964 (make_dummy_parent): Rename to make_parent_window and give it a
5965 second argument horflag.
5966 (make_window): Don't set resize_proportionally any more.
5967 (Fsplit_window): Remove. Windows are split in window.el.
5968 (save_restore_action, save_restore_orig_size)
5969 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5970 Resize mini windows in window.el.
5971 (grow_mini_window, shrink_mini_window): Implement by calling
5972 Qresize_root_window_vertically, resize_window_check and
5973 resize_window_apply.
5974 (saved_window, Fset_window_configuration, save_window_save):
5975 Do not handle orig_top_line, orig_total_lines, and
5976 resize_proportionally.
5977 (window_min_height, window_min_width): Move to window.el.
5978 (keys_of_window): Move bindings for delete-other-windows,
5979 split-window, delete-window and enlarge-window to window.el.
5980
5981 * buffer.c: Temporarily extern Qdelete_window.
5982 (Fbury_buffer): Temporarily call Qdelete_window instead of
5983 Fdelete_window (Fbury_buffer will move to window.el soon).
5984
5985 * frame.c (set_menu_bar_lines_1): Remove code handling
5986 orig_top_line and orig_total_lines.
5987
5988 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5989 set_window_height but set heights directly.
5990 (change_frame_size_1): Use resize_frame_windows.
5991
5992 * xdisp.c (init_xdisp): Don't use set_window_height but set
5993 heights directly.
5994
5995 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5996 Use resize_frame_windows instead of change_window_heights and run
5997 run_window_configuration_change_hook.
5998
5999 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
6000 instead of change_window_heights and run
6001 run_window_configuration_change_hook.
6002
6003 2011-06-09 Martin Rudalics <rudalics@gmx.at>
6004
6005 * window.c (replace_window): Rename second argument REPLACEMENT to
6006 NEW. New third argument SETFLAG. Rewrite.
6007 (delete_window, make_dummy_parent): Call replace_window with
6008 third argument 1.
6009 (window_list_1): Move down in code.
6010 (run_window_configuration_change_hook): Move set_buffer part
6011 before select_frame_norecord part in order to unwind correctly.
6012 Rename count1 to count.
6013 (recombine_windows, delete_deletable_window, resize_root_window)
6014 (Fdelete_other_windows_internal)
6015 (Frun_window_configuration_change_hook, make_parent_window)
6016 (resize_window_check, resize_window_apply, Fresize_window_apply)
6017 (resize_frame_windows, Fsplit_window_internal)
6018 (Fdelete_window_internal, Fresize_mini_window_internal):
6019 New functions.
6020 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
6021
6022 2011-06-08 Martin Rudalics <rudalics@gmx.at>
6023
6024 * window.h (window): Add some new members to window structure -
6025 normal_lines, normal_cols, new_total, new_normal, clone_number,
6026 splits, nest, prev_buffers, next_buffers.
6027 (WINDOW_TOTAL_SIZE): Move here from window.c.
6028 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
6029
6030 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
6031 Remove.
6032 (make_dummy_parent): Set new members of windows structure.
6033 (make_window): Move down in code. Handle new members of window
6034 structure.
6035 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
6036 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
6037 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
6038 (Fset_window_prev_buffers, Fwindow_next_buffers)
6039 (Fset_window_next_buffers, Fset_window_clone_number):
6040 New functions.
6041 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
6042 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
6043 Doc-string fixes.
6044 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
6045 Argument WINDOW can be now internal window too.
6046 (Fwindow_use_time): Move up in code.
6047 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
6048 Rewrite doc-string.
6049 (Fset_window_configuration, saved_window)
6050 (Fcurrent_window_configuration, save_window_save): Handle new
6051 members of window structure.
6052 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
6053 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
6054 (syms_of_window): New Lisp objects Qrecord_window_buffer,
6055 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
6056 Qget_mru_window, Qresize_root_window,
6057 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
6058 Qauto_buffer_name; staticpro them.
6059
6060 2011-06-07 Martin Rudalics <rudalics@gmx.at>
6061
6062 * window.c (Fwindow_total_size, Fwindow_left_column)
6063 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
6064 (Fwindow_list_1): New functions.
6065 (window_box_text_cols): Replace with window_body_cols.
6066 (Fwindow_width, Fscroll_left, Fscroll_right):
6067 Use window_body_cols instead of window_box_text_cols.
6068 (delete_window, Fset_window_configuration):
6069 Call delete_all_subwindows with window as argument.
6070 (delete_all_subwindows): Take a window as argument and not a
6071 structure. Rewrite.
6072 (window_loop): Remove handling of GET_LRU_WINDOW and
6073 GET_LARGEST_WINDOW.
6074 (Fget_lru_window, Fget_largest_window): Move to window.el.
6075
6076 * window.h: Extern window_body_cols instead of
6077 window_box_text_cols. delete_all_subwindows now takes a
6078 Lisp_Object as argument.
6079
6080 * indent.c (compute_motion, Fcompute_motion):
6081 Use window_body_cols instead of window_box_text_cols.
6082
6083 * frame.c (delete_frame): Call delete_all_subwindows with root
6084 window as argument.
6085
6086 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
6087
6088 * fns.c (Fputhash): Document return value.
6089
6090 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
6091
6092 * image.c (gif_load): Implement gif89a spec "no disposal" method.
6093
6094 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6095
6096 Cons<->int and similar integer overflow fixes (Bug#8794).
6097
6098 Check for overflow when converting integer to cons and back.
6099 * charset.c (Fdefine_charset_internal, Fdecode_char):
6100 Use cons_to_unsigned to catch overflow.
6101 (Fencode_char): Use INTEGER_TO_CONS.
6102 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
6103 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
6104 * data.c (long_to_cons, cons_to_long): Remove.
6105 (cons_to_unsigned, cons_to_signed): New functions.
6106 These signal an error for invalid or out-of-range values.
6107 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6108 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6109 * font.c (Ffont_variation_glyphs):
6110 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6111 * lisp.h: Include <intprops.h>.
6112 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6113 (cons_to_signed, cons_to_unsigned): New decls.
6114 (long_to_cons, cons_to_long): Remove decls.
6115 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6116 (Fprimitive_undo): Use CONS_TO_INTEGER.
6117 * xfns.c (Fx_window_property): Likewise.
6118 * xselect.c: Include <limits.h>.
6119 (x_own_selection, selection_data_to_lisp_data):
6120 Use INTEGER_TO_CONS.
6121 (x_handle_selection_request, x_handle_selection_clear)
6122 (x_get_foreign_selection, Fx_disown_selection_internal)
6123 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6124 (lisp_data_to_selection_data): Use cons_to_unsigned.
6125 (x_fill_property_data): Use cons_to_signed.
6126 Report values out of range.
6127
6128 Check for buffer and string overflow more precisely.
6129 * buffer.h (BUF_BYTES_MAX): New macro.
6130 * lisp.h (STRING_BYTES_MAX): New macro.
6131 * alloc.c (Fmake_string):
6132 * character.c (string_escape_byte8):
6133 * coding.c (coding_alloc_by_realloc):
6134 * doprnt.c (doprnt):
6135 * editfns.c (Fformat):
6136 * eval.c (verror):
6137 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6138 since they may not be the same number.
6139 * editfns.c (Finsert_char):
6140 * fileio.c (Finsert_file_contents):
6141 Likewise for BUF_BYTES_MAX.
6142
6143 * image.c: Use ptrdiff_t, not int, for sizes.
6144 (slurp_file): Switch from int to ptrdiff_t.
6145 All uses changed.
6146 (slurp_file): Check that file size fits in both size_t (for
6147 malloc) and ptrdiff_t (for sanity and safety).
6148
6149 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6150 if b->modtime has its maximal value.
6151
6152 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6153
6154 Don't assume time_t can fit into int.
6155 * buffer.h (struct buffer.modtime): Now time_t, not int.
6156 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6157 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6158
6159 Minor fixes for signed vs unsigned integers.
6160 * character.h (MAYBE_UNIFY_CHAR):
6161 * charset.c (maybe_unify_char):
6162 * keyboard.c (read_char, reorder_modifiers):
6163 XINT -> XFASTINT, since the integer must be nonnegative.
6164 * ftfont.c (ftfont_spec_pattern):
6165 * keymap.c (access_keymap, silly_event_symbol_error):
6166 XUINT -> XFASTINT, since the integer must be nonnegative.
6167 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6168 since it makes no difference and we prefer signed.
6169 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6170 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6171 nonnegative.
6172
6173 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6174
6175 * window.h (Fwindow_frame): Declare.
6176
6177 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6178
6179 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6180 (SPARE_MEMORY): Always define.
6181 (LARGE_REQUEST): Remove.
6182 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6183
6184 2011-06-06 Martin Rudalics <rudalics@gmx.at>
6185
6186 * lisp.h: Move EXFUNS for Fframe_root_window,
6187 Fframe_first_window and Fset_frame_selected_window to window.h.
6188
6189 * window.h: Move EXFUNS for Fframe_root_window,
6190 Fframe_first_window and Fset_frame_selected_window here from
6191 lisp.h.
6192
6193 * frame.c (Fwindow_frame, Fframe_first_window)
6194 (Fframe_root_window, Fframe_selected_window)
6195 (Fset_frame_selected_window): Move to window.c.
6196 (Factive_minibuffer_window): Move to minibuf.c.
6197 (Fother_visible_frames_p): New function.
6198
6199 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6200
6201 * window.c (decode_window, decode_any_window): Move up in code.
6202 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6203 (inhibit_frame_unsplittable): Remove unused variable.
6204 (Fwindow_buffer): Move up and rewrite doc-string.
6205 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6206 (Fwindow_prev): New functions.
6207 (Fwindow_frame): Move here from frame.c. Accept any window as
6208 argument.
6209 (Fframe_root_window, Fframe_first_window)
6210 (Fframe_selected_window): Move here from frame.c. Accept frame
6211 or arbitrary window as argument. Update doc-strings.
6212 (Fminibuffer_window): Move up in code.
6213 (Fwindow_minibuffer_p): Move up in code and simplify.
6214 (Fset_frame_selected_window): Move here from frame.c.
6215 Marginal rewrite.
6216 (Fselected_window, select_window, Fselect_window): Move up in
6217 code. Minor doc-string fixes.
6218
6219 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6220
6221 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6222 Do not assume that spare memory exists; that assumption is valid
6223 only if SYSTEM_MALLOC.
6224 (LARGE_REQUEST): New macro, so that the issue of large requests
6225 is separated from the issue of spare memory.
6226
6227 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6228
6229 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6230 format. (Bug#8806)
6231
6232 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6233
6234 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6235 before statements.
6236
6237 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6238
6239 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6240
6241 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6242
6243 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6244 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6245
6246 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
6247
6248 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6249
6250 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
6251
6252 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6253 (x_clipboard_manager_save): Add return value.
6254 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6255 New error handlers.
6256 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6257 Obey Vx_select_enable_clipboard_manager. Catch errors in
6258 x_clipboard_manager_save (Bug#8779).
6259 (Vx_select_enable_clipboard_manager): New variable.
6260 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
6261
6262 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
6263
6264 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6265
6266 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6267
6268 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6269 in the current matrix if keep_current_p is non-zero.
6270
6271 2011-06-04 Eli Zaretskii <eliz@gnu.org>
6272
6273 * bidi.c (bidi_level_of_next_char): Fix last change.
6274
6275 2011-06-03 Eli Zaretskii <eliz@gnu.org>
6276
6277 Support bidi reordering of text covered by display properties.
6278
6279 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6280 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6281 (bidi_cache_search, bidi_cache_iterator_state)
6282 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6283 (bidi_level_of_next_char, bidi_move_to_visually_next):
6284 Support character positions inside a run of characters covered by a
6285 display string.
6286 (bidi_paragraph_init, bidi_resolve_explicit_1)
6287 (bidi_level_of_next_char): Call bidi_fetch_char and
6288 bidi_fetch_char_advance instead of FETCH_CHAR and
6289 FETCH_CHAR_ADVANCE.
6290 (bidi_init_it): Initialize new members.
6291 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6292 definitions.
6293 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6294 instead of using explicit *_CHAR codes.
6295 (bidi_resolve_explicit, bidi_resolve_weak):
6296 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6297 bidirectional text is supported only in multibyte buffers.
6298 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6299 it to initialize the frame_window_p member of struct bidi_it.
6300 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6301 (bidi_resolve_explicit, bidi_resolve_weak)
6302 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6303 bidi_it->nchars is non-positive.
6304 (bidi_level_of_next_char): Don't try to lookup the cache for the
6305 next/previous character if nothing is cached there yet, or if we
6306 were just reseat()'ed to a new position.
6307
6308 * xdisp.c (set_cursor_from_row): Set start and stop points
6309 according to the row's direction when priming the loop that looks
6310 for the glyph on which to display cursor.
6311 (single_display_spec_intangible_p): Function deleted.
6312 (display_prop_intangible_p): Reimplement to call
6313 handle_display_spec instead of single_display_spec_intangible_p.
6314 Accept 3 additional arguments needed by handle_display_spec.
6315 This fixes incorrect cursor motion across display property with complex
6316 values: lists, `(when COND...)' forms, etc.
6317 (single_display_spec_string_p): Support property values that are
6318 lists with the argument STRING its top-level element.
6319 (display_prop_string_p): Fix the condition for processing a
6320 property that is a list to be consistent with handle_display_spec.
6321 (handle_display_spec): New function, refactored from the
6322 last portion of handle_display_prop.
6323 (compute_display_string_pos): Accept additional argument
6324 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6325 value of a `display' property is a "replacing spec".
6326 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6327 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6328 the display property, but just return a value indicating whether
6329 the display property will replace the characters it covers.
6330 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6331 frame_window_p members of struct bidi_it.
6332 (compute_display_string_pos, compute_display_string_end):
6333 New functions.
6334 (push_it): Accept second argument POSITION, where pop_it should
6335 jump to continue iteration.
6336 (reseat_1): Initialize bidi_it.disp_pos.
6337
6338 * keyboard.c (adjust_point_for_property): Adjust the call to
6339 display_prop_intangible_p to its new signature.
6340
6341 * dispextern.h (struct bidi_it): New member frame_window_p.
6342 (bidi_init_it): Update prototypes.
6343 (display_prop_intangible_p): Update prototype.
6344 (compute_display_string_pos, compute_display_string_end):
6345 Declare prototypes.
6346 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6347 EMACS_INT.
6348
6349 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6350
6351 Malloc failure behavior now depends on size of allocation.
6352 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6353 * lisp.h: Change signatures accordingly.
6354 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6355 All callers changed. (Bug#8762)
6356
6357 * gnutls.c: Use Emacs's memory allocators.
6358 Without this change, the gnutls library would invoke malloc etc.
6359 directly, which causes problems on non-SYNC_INPUT hosts, and which
6360 runs afoul of improving memory_full behavior. (Bug#8761)
6361 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6362 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6363 xfree instead of the default malloc, realloc, free.
6364 (Fgnutls_boot): No need to check for memory allocation failure,
6365 since xmalloc does that for us.
6366
6367 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6368 * category.c (hash_get_category_set):
6369 * ccl.c (ccl_driver):
6370 * charset.c (Fdefine_charset_internal):
6371 * charset.h (struct charset.hash_index):
6372 * composite.c (get_composition_id, gstring_lookup_cache)
6373 (composition_gstring_put_cache):
6374 * composite.h (struct composition.hash_index):
6375 * dispextern.h (struct image.hash):
6376 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6377 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6378 (hashfn_equal, hashfn_user_defined, make_hash_table)
6379 (maybe_resize_hash_table, hash_lookup, hash_put)
6380 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6381 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6382 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6383 * image.c (make_image, search_image_cache, lookup_image)
6384 (xpm_put_color_table_h):
6385 * lisp.h (struct Lisp_Hash_Table):
6386 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6387 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6388 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6389 * alloc.c (allocate_vectorlike):
6390 Check for overflow in vector size calculations.
6391 * ccl.c (ccl_driver):
6392 Check for overflow when converting EMACS_INT to int.
6393 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6394 need to be updated by these changes.
6395 * fns.c (make_hash_table, maybe_resize_hash_table):
6396 Check for integer overflow with large hash tables.
6397 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6398 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6399 (SXHASH_REDUCE): New macro.
6400 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6401 Use it instead of discarding useful hash info with large hash values.
6402 (sxhash_float): New function.
6403 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6404 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6405 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6406 Rewrite to use FIXNUM_BITS, as this simplifies things.
6407 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6408 Adjust signatures to match updated version of code.
6409 (consing_since_gc): Now EMACS_INT, since a single hash table can
6410 use more than INT_MAX bytes.
6411
6412 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6413
6414 Make it possible to build with GCC-4.6+ -O2 -flto.
6415
6416 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6417
6418 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6419
6420 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6421 Call minibuffer-inactive-mode.
6422
6423 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6424
6425 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6426 Update dependencies.
6427
6428 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6429
6430 * data.c (init_data): Remove code for UTS, this system is not
6431 supported anymore.
6432
6433 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6434
6435 Don't force ./temacs to start in terminal mode.
6436
6437 * frame.c (make_initial_frame): Initialize faces in all cases, not
6438 only when CANNOT_DUMP is defined.
6439 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6440
6441 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6442
6443 * dispnew.c (add_window_display_history): Use const for the string
6444 pointer. Remove declaration, not needed.
6445
6446 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6447
6448 Use 'inline', not 'INLINE'.
6449 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6450 * alloc.c, fontset.c (INLINE): Remove.
6451 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6452 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6453 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6454 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6455 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6456
6457 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6458
6459 Make it possible to run ./temacs.
6460
6461 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6462 syms_of_callproc does the same thing. Remove test for
6463 "initialized", do it in the caller.
6464 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6465
6466 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6467
6468 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6469 (read_minibuf): Use get_minibuffer.
6470 (syms_of_minibuf): Use DEFSYM.
6471 (Qmetadata): New var.
6472 * data.c (Qbuffer): Don't make it static.
6473 (syms_of_data): Use DEFSYM.
6474
6475 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6476
6477 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6478 (CCL_CODE_MIN): New macro.
6479
6480 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6481
6482 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6483
6484 * eval.c (Qdebug): Now static.
6485 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6486 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6487 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6488
6489 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6490
6491 * image.c: Various fixes to ImageMagick code comments.
6492 (Fimagemagick_types): Doc fix.
6493
6494 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6495
6496 Minor fixes prompted by GCC 4.6.0 warnings.
6497
6498 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6499
6500 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6501 (x_clipboard_manager_save_all): Move extern decl to ...
6502 * xterm.h: ... here, so that it can be checked for consistency.
6503
6504 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6505
6506 * xselect.c (x_clipboard_manager_save_frame)
6507 (x_clipboard_manager_save_all): New functions.
6508 (Fx_clipboard_manager_save): Lisp function deleted.
6509
6510 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6511 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6512
6513 * xterm.h: Update prototype.
6514
6515 2011-05-28 William Xu <william.xwl@gmail.com>
6516
6517 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6518 exiting (Bug#8239).
6519
6520 2011-05-28 Jim Meyering <meyering@redhat.com>
6521
6522 Avoid a sign-extension bug in crypto_hash_function.
6523 * fns.c (to_uchar): Define.
6524 (crypto_hash_function): Use it to convert some newly-signed
6525 variables to unsigned, to avoid sign-extension bugs. For example,
6526 without this change, (md5 "truc") would evaluate to
6527 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6528 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6529 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6530
6531 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6532
6533 Integer overflow fixes.
6534
6535 * dbusbind.c: Serial number integer overflow fixes.
6536 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6537 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6538 to hold a serial number that is too large for a fixnum.
6539 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6540 Check for serial numbers out of range. Decode any serial number
6541 that was so large that it became a float. (Bug#8722)
6542
6543 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6544 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6545 Use XFASTINT rather than XUINT when numbers are nonnegative.
6546 (xd_append_arg, Fdbus_method_return_internal):
6547 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6548 arguments, check that Lisp number is nonnegative, rather than
6549 silently wrapping negative numbers around. (Bug#8722)
6550 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6551 (Bug#8722)
6552
6553 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6554
6555 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6556
6557 ccl: Add integer overflow checks.
6558 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6559 (IN_INT_RANGE): New macros.
6560 (ccl_driver): Use them to check for integer overflow when
6561 decoding a CCL program. Many of the new checks are whether XINT (x)
6562 fits in int; it doesn't always, on 64-bit hosts. The new version
6563 doesn't catch all possible integer overflows, but it's an
6564 improvement. (Bug#8719)
6565
6566 * alloc.c (make_event_array): Use XINT, not XUINT.
6567 There's no need for unsigned here.
6568
6569 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6570 This follows up to the 2011-05-06 change that substituted uintptr_t
6571 for EMACS_INT. This case wasn't caught back then.
6572
6573 Rework Fformat to avoid integer overflow issues.
6574 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6575 now (part of C89). Include <verify.h>.
6576 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6577 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6578 (Fformat): Avoid the prepass trying to compute sizes; it was only
6579 approximate and thus did not catch overflow reliably. Instead, walk
6580 through the format just once, formatting and computing sizes as we go,
6581 checking for integer overflow at every step, and allocating a larger
6582 buffer as needed. Keep track separately whether the format is
6583 multibyte. Keep only the most-recently calculated precision, rather
6584 than them all. Record whether each argument has been converted to
6585 string. Use EMACS_INT, not int, for byte and char and arg counts.
6586 Support field widths and precisions larger than INT_MAX. Avoid
6587 sprintf's undefined behavior with conversion specifications such as %#d
6588 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6589 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6590 formatting out-of-range floating point numbers with int
6591 formats. (Bug#8668)
6592
6593 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6594
6595 * data.c: Avoid integer truncation in expressions involving floats.
6596 * data.c: Include <intprops.h>.
6597 (arith_driver): When there's an integer overflow in an expression
6598 involving floating point, convert the integers to floating point
6599 so that the resulting value does not suffer from catastrophic
6600 integer truncation. For example, on a 64-bit host (* 4
6601 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6602 Do not rely on undefined behavior after integer overflow.
6603
6604 merge count_size_as_multibyte, parse_str_to_multibyte
6605 * character.c, character.h (count_size_as_multibyte):
6606 Rename from parse_str_to_multibyte; all uses changed.
6607 Check for integer overflow.
6608 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6609 since it's now a duplicate of the other. This is more of
6610 a character than a buffer op, so better that it's in character.c.
6611 * fns.c, print.c: Adjust to above changes.
6612
6613 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6614
6615 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6616
6617 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6618
6619 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6620 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6621 (x_clipboard_manager_save): Now static.
6622 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6623
6624 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6625 (crypto_hash_function): Now static.
6626 Fix pointer signedness problems. Avoid unnecessary initializations.
6627
6628 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6629
6630 * termhooks.h (Vselection_alist): Make it terminal-local.
6631
6632 * terminal.c (create_terminal): Initialize it.
6633
6634 * xselect.c: Support for clipboard managers.
6635 (Vselection_alist): Move to termhooks.h as terminal-local var.
6636 (LOCAL_SELECTION): New macro.
6637 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6638 (symbol_to_x_atom): Remove gratuitous arg.
6639 (x_handle_selection_request, lisp_data_to_selection_data)
6640 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6641 (x_own_selection, x_get_local_selection, x_convert_selection):
6642 New arg, specifying work frame. Use terminal-local Vselection_alist.
6643 (some_frame_on_display): Delete unused function.
6644 (Fx_own_selection_internal, Fx_get_selection_internal)
6645 (Fx_disown_selection_internal, Fx_selection_owner_p)
6646 (Fx_selection_exists_p): New optional frame arg.
6647 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6648 (x_handle_selection_clear): Don't treat other terminals with the
6649 same keyboard specially. Use the terminal-local Vselection_alist.
6650 (x_clear_frame_selections): Use Frun_hook_with_args.
6651
6652 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6653
6654 * xterm.h: Add support for those atoms.
6655
6656 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6657
6658 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6659 (converted_selections, conversion_fail_tag): New global variables.
6660 (x_selection_request_lisp_error): Free the above.
6661 (x_get_local_selection): Remove unnecessary code.
6662 (x_reply_selection_request): Args changed; handle arbitrary array
6663 of converted selections stored in converted_selections.
6664 Separate the XChangeProperty and SelectionNotify steps.
6665 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6666 (x_convert_selection): New function.
6667 (x_handle_selection_event): Simplify.
6668 (x_get_foreign_selection): Don't ignore incoming requests while
6669 waiting for an answer; this will fail when we implement
6670 SAVE_TARGETS, and seems unnecessary anyway.
6671 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6672 (Vx_sent_selection_functions): Doc fix.
6673
6674 2011-05-26 Leo Liu <sdl.web@gmail.com>
6675
6676 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6677
6678 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6679
6680 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6681
6682 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6683 for fringe update if it has periodic bitmap.
6684 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6685 and fringe_bitmap_periodic_p.
6686
6687 * fringe.c (get_fringe_bitmap_data): New function.
6688 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6689 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6690 row. Mark glyph row for fringe update if periodicity changed.
6691
6692 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6693 for fringe update unless it has periodic bitmap.
6694
6695 2011-05-25 Kenichi Handa <handa@m17n.org>
6696
6697 * xdisp.c (get_next_display_element): Set correct it->face_id for
6698 a static composition.
6699
6700 2011-05-24 Leo Liu <sdl.web@gmail.com>
6701
6702 * deps.mk (fns.o):
6703 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6704
6705 * fns.c (crypto_hash_function, Fsha1): New function.
6706 (Fmd5): Use crypto_hash_function.
6707 (syms_of_fns): Add Ssha1.
6708
6709 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6710
6711 * gnutls.c: Remove unused macros.
6712 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6713 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6714 Remove macros that are defined and never used.
6715 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6716
6717 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6718
6719 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6720 (Fx_get_selection_internal): Minor cleanup.
6721 (Fx_own_selection_internal): Rename arguments for consistency with
6722 select.el.
6723
6724 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6725
6726 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6727
6728 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6729
6730 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6731
6732 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6733
6734 * dispnew.c (scrolling_window): Don't exclude the case that the
6735 last enabled row in the desired matrix touches the bottom boundary.
6736
6737 2011-05-21 Glenn Morris <rgm@gnu.org>
6738
6739 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6740 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6741 and add some more files.
6742
6743 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6744
6745 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6746 report_file_error introduced by the change from 2011-05-07.
6747
6748 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6749
6750 * systime.h (Time): Define only if emacs is defined.
6751 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6752 where the include path doesn't have X11/X.h by default. See
6753 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6754
6755 2011-05-20 Kenichi Handa <handa@m17n.org>
6756
6757 * composite.c (find_automatic_composition): Fix previous change.
6758
6759 2011-05-20 Glenn Morris <rgm@gnu.org>
6760
6761 * lisp.mk: New file, split from Makefile.in.
6762 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6763 (shortlisp): Remove.
6764 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6765
6766 2011-05-19 Glenn Morris <rgm@gnu.org>
6767
6768 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6769 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6770 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6771 (lisp): Set the order to that of loadup.el.
6772 (shortlisp): Make it a copy of $lisp.
6773 (SOME_MACHINE_LISP): Remove.
6774 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6775 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6776
6777 2011-05-18 Kenichi Handa <handa@m17n.org>
6778
6779 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6780 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6781 (find_automatic_composition): Mostly rewrite for efficiency.
6782
6783 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6784
6785 * makefile.w32-in: Update dependencies.
6786
6787 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6788
6789 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6790 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6791
6792 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6793
6794 Fix some integer overflow issues, such as string length overflow.
6795
6796 * insdel.c (count_size_as_multibyte): Check for string overflow.
6797
6798 * character.c (lisp_string_width): Check for string overflow.
6799 Use EMACS_INT, not int, for string indexes and lengths; in
6800 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6801 the resulting string length overflows an EMACS_INT; instead,
6802 report a string overflow if no precision given. When checking for
6803 precision exhaustion, use a check that cannot possibly have
6804 integer overflow. (Bug#8675)
6805 * character.h (lisp_string_width): Adjust to new signature.
6806
6807 * alloc.c (string_overflow): New function.
6808 (Fmake_string): Use it. This doesn't change behavior, but saves
6809 a few bytes and will simplify future changes.
6810 * character.c (string_escape_byte8): Likewise.
6811 * lisp.h (string_overflow): New decl.
6812
6813 Fixups, following up to the user-interface timestamp change.
6814 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6815 for UI timestamps, instead of unsigned long.
6816 * msdos.c (mouse_get_pos): Likewise.
6817 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6818 * w32gui.h (Time): Define by including "systime.h" rather than by
6819 declaring it ourselves. (Bug#8664)
6820
6821 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6822 * image.c (clear_image_cache): Likewise.
6823
6824 * term.c (term_mouse_position): Don't assume time_t wraparound.
6825
6826 Be more systematic about user-interface timestamps.
6827 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6828 and sometimes 'EMACS_UINT', to represent these timestamps.
6829 This change causes it to use 'Time' uniformly, as that's what X uses.
6830 This makes the code easier to follow, and makes it easier to catch
6831 integer overflow bugs such as Bug#8664.
6832 * frame.c (Fmouse_position, Fmouse_pixel_position):
6833 Use Time, not unsigned long, for user-interface timestamps.
6834 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6835 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6836 * keyboard.h (last_event_timestamp): Likewise.
6837 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6838 * menu.h (xmenu_show): Likewise.
6839 * term.c (term_mouse_position): Likewise.
6840 * termhooks.h (struct input_event.timestamp): Likewise.
6841 (struct terminal.mouse_position_hook): Likewise.
6842 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6843 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6844 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6845 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6846 what it was before.
6847 * menu.h, termhooks.h: Include "systime.h", for Time.
6848
6849 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6850 Don't assume that the difference between two unsigned long values
6851 can fit into an integer. At this point, we know button_down_time
6852 <= event->timestamp, so the difference must be nonnegative, so
6853 there's no need to cast the result if double-click-time is
6854 nonnegative, as it should be; check that it's nonnegative, just in
6855 case. This bug is triggered when events are more than 2**31 ms
6856 apart (about 25 days). (Bug#8664)
6857
6858 * xselect.c (last_event_timestamp): Remove duplicate decl.
6859 (x_own_selection): Remove needless cast to unsigned long.
6860
6861 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6862 that always fit in int. Use a sentinel instead of a counter, to
6863 avoid a temp and to allay GCC's concerns about possible int overflow.
6864 * frame.h (struct frame): Use int for menu_bar_items_used
6865 instead of EMACS_INT, since it always fits in int.
6866
6867 * menu.c (grow_menu_items): Check for int overflow.
6868
6869 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6870
6871 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6872 Before, the code was not consistent. These values cannot exceed
6873 2**31 - 1 so there's no need to make them unsigned.
6874 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6875 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6876 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6877 as modifiers.
6878 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6879
6880 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6881 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6882 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6883 presumably because the widths might not match.
6884
6885 * window.c (size_window): Avoid needless test at loop start.
6886
6887 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6888
6889 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6890
6891 2011-05-12 Drew Adams <drew.adams@oracle.com>
6892
6893 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6894
6895 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6896
6897 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6898 `width' to `bar_area_x' and `bar_area_width', respectively.
6899 (x_scroll_run): Take account of fringe background extension.
6900
6901 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6902 Rename local vars `left' and `width' to `bar_area_x' and
6903 `bar_area_width', respectively.
6904 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6905 background extension.
6906
6907 2011-05-10 Jim Meyering <meyering@redhat.com>
6908
6909 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6910
6911 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6912
6913 * image.c (Finit_image_library): Return t for built-in image types,
6914 like pbm and xbm. (Bug#8640)
6915
6916 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6917
6918 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6919
6920 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6921
6922 * w32console.c (Fset_screen_color): Doc fix.
6923 (Fget_screen_color): New function.
6924 (syms_of_ntterm): Defsubr it.
6925
6926 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6927 unlink the temporary file if Fcall_process didn't create it in the
6928 first place.
6929 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6930 child process will be redirected to a file specified with `:file'.
6931 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6932 cue to call_process_cleanup not to close that handle.
6933
6934 2011-05-07 Ben Key <bkey76@gmail.com>
6935
6936 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6937 one of two shell specific rules, either bootstrap-temacs-CMD or
6938 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6939 to the previous implementation of the bootstrap-temacs rule.
6940 The bootstrap-temacs-CMD rule is similar to the previous
6941 implementation of the bootstrap-temacs rule except that it
6942 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6943 variable.
6944
6945 These changes, along with some changes to nt/configure.bat,
6946 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6947 earlier fix to add support for --cflags and --ldflags options
6948 that include quotes so that it works whether make uses cmd or
6949 sh as the shell.
6950
6951 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6952
6953 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6954 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6955 is a constant.
6956 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6957 a string. Handle both cases.
6958 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6959 (Fdbus_register_method): Use Qinvalid_function.
6960
6961 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6962
6963 * makefile.w32-in: Update dependencies.
6964 (LISP_H): Add inttypes.h and stdin.h.
6965 (PROCESS_H): Add unistd.h.
6966
6967 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6968
6969 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6970 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6971
6972 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6973
6974 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6975
6976 * term.c (vfatal): Remove stray call to va_end.
6977 It's not needed and the C Standard doesn't allow it here anyway.
6978
6979 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6980 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6981
6982 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6983 bytes.
6984
6985 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6986
6987 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6988
6989 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6990
6991 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6992
6993 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6994
6995 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6996 * charset.c (Fdefine_charset_internal): Don't initialize
6997 charset.code_space[15]. The value was garbage, on hosts with
6998 32-bit int (Bug#8600).
6999
7000 * lread.c (read_integer): Be more consistent with string-to-number.
7001 Use string_to_number to do the actual conversion; this avoids
7002 rounding errors and fixes some other screwups. Without this fix,
7003 for example, #x1fffffffffffffff was misread as -2305843009213693952.
7004 (digit_to_number): Move earlier, for benefit of read_integer.
7005 Return -1 if the digit is out of range for the base, -2 if it is
7006 not a digit in any supported base. (Bug#8602)
7007
7008 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
7009
7010 * dispnew.c (scrolling_window): Return 1 if we scrolled,
7011 to match comment at start of function. This also removes a
7012 GCC warning about overflow in a 32+64-bit port.
7013
7014 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
7015
7016 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
7017 Reported by Stefan Monnier in
7018 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
7019 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7020 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
7021
7022 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
7023 (EMACS_UINTPTR): Likewise, with uintptr_t.
7024
7025 * lisp.h: Prefer 64-bit EMACS_INT if available.
7026 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
7027 on 32-bit hosts that have 64-bit int, so that they can access
7028 large files.
7029 However, temporarily disable this change unless the temporary
7030 symbol WIDE_EMACS_INT is defined.
7031
7032 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
7033
7034 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
7035 This removes an assumption that EMACS_INT and long are the same
7036 width as pointers. The assumption is true for Emacs porting targets
7037 now, but we want to make other targets possible.
7038 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
7039 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
7040 In the rest of the code, change types of integers that hold casted
7041 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
7042 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
7043 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
7044 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
7045 No need to cast type when ORing.
7046 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
7047 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
7048 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
7049 assume EMACS_INT is the same width as char *.
7050 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
7051 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
7052 Remove no-longer-needed casts.
7053 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
7054 (xg_tool_bar_help_callback, xg_make_tool_item):
7055 Use EMACS_INTPTR to hold an integer
7056 that will be cast to void *; this can avoid a GCC warning
7057 if EMACS_INT is not the same width as void *.
7058 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
7059 * xdisp.c (display_echo_area_1, resize_mini_window_1):
7060 (current_message_1, set_message_1):
7061 Use a local to convert to proper width without a cast.
7062 * xmenu.c (dialog_selection_callback): Likewise.
7063
7064 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
7065 Also, don't assume VALBITS / RAND_BITS is less than 5,
7066 and don't rely on undefined behavior when shifting a 1 left into
7067 the sign bit.
7068 * lisp.h (get_random): Change signature to match.
7069
7070 * lread.c (hash_string): Use size_t, not int, for hash computation.
7071 Normally we prefer signed values; but hashing is special, because
7072 it's better to use unsigned division on hash table sizes so that
7073 the remainder is nonnegative. Also, size_t is the natural width
7074 for hashing into memory. The previous code used 'int', which doesn't
7075 retain enough info to hash well into very large tables.
7076 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
7077
7078 * dbusbind.c: Don't possibly lose pointer info when converting.
7079 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7080 Use XPNTR rather than XHASH, so that the high-order bits of
7081 the pointer aren't lost when converting through void *.
7082
7083 * eval.c (Fautoload): Don't double-shift a pointer.
7084
7085 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
7086
7087 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
7088
7089 * gnutls.c (DEF_GNUTLS_FN):
7090 * image.c (DEF_IMGLIB_FN): Make function pointers static.
7091
7092 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
7093
7094 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
7095 marker. (Bug#8610)
7096
7097 2011-05-05 Eli Zaretskii <eliz@gnu.org>
7098
7099 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
7100 New version that can reserve upto 2GB of heap space.
7101
7102 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
7103
7104 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
7105
7106 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7107
7108 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7109 `gnutls_certificate_set_x509_key_file'.
7110
7111 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
7112
7113 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7114 Update dependencies.
7115
7116 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7117
7118 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7119 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7120 Remove unused parameter `fildes'.
7121 * process.c (read_process_output, send_process): Don't pass it.
7122
7123 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7124
7125 Fix previous change: the library cache is defined in w32.c.
7126 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7127 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7128
7129 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7130
7131 Implement dynamic loading of GnuTLS on Windows.
7132
7133 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7134 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7135 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7136 Declare.
7137
7138 * gnutls.c (Qgnutls_dll): Define.
7139 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7140 (gnutls_*): Declare function pointers.
7141 (init_gnutls_functions): New function to initialize function pointers.
7142 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7143 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7144 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7145 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7146 (emacs_gnutls_write, emacs_gnutls_read)
7147 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7148 (Fgnutls_available_p): New function.
7149 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7150 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7151 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7152
7153 * image.c: Include w32.h.
7154 (Vimage_type_cache): Delete.
7155 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7156 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7157 (w32_delayed_load): Move to w32.c.
7158
7159 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7160
7161 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7162 (w32_delayed_load): Move from image.c. When loading a library, record
7163 its filename in the :loaded-from property of the library id.
7164 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7165 Initialize and staticpro them.
7166 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7167
7168 * process.c: Include lisp.h before w32.h, not after.
7169 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7170 instead of gnutls_record_check_pending.
7171
7172 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7173
7174 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7175
7176 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7177 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7178 as passed in.
7179
7180 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7181
7182 * xterm.c (x_set_frame_alpha): Do not set property on anything
7183 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7184
7185 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7186
7187 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7188
7189 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7190
7191 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7192 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7193 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7194 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7195 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7196 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7197 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7198 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7199 (Qgnutls_bootprop_callbacks_verify): Make static.
7200
7201 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7202
7203 * callproc.c: Indentation fixup.
7204
7205 * sysdep.c (wait_for_termination_1): Make static.
7206 (wait_for_termination, interruptible_wait_for_termination):
7207 Move after wait_for_termination_1.
7208
7209 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7210
7211 * sysdep.c (interruptible_wait_for_termination): New function
7212 which is like wait_for_termination, but allows keyboard
7213 interruptions.
7214
7215 * callproc.c (Fcall_process): Add (:file "file") as an option for
7216 the STDOUT buffer.
7217 (Fcall_process_region): Ditto.
7218
7219 2011-04-30 Eli Zaretskii <eliz@gnu.org>
7220
7221 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7222 rather than `XVECTOR (FOO)->size'.
7223
7224 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7225 inttypes.h, as a gnulib replacement is used if it not available in
7226 system headers.
7227
7228 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7229
7230 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7231 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7232 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7233
7234 * coding.c (coding_alloc_by_realloc): Error out if destination
7235 will grow beyond MOST_POSITIVE_FIXNUM.
7236 (decode_coding_emacs_mule): Abort if there isn't enough place in
7237 charbuf for the composition carryover bytes. Reserve an extra
7238 space for up to 2 characters produced in a loop.
7239 (decode_coding_iso_2022): Abort if there isn't enough place in
7240 charbuf for the composition carryover bytes.
7241
7242 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7243
7244 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7245 aborting when %lld or %lll format is passed.
7246 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7247 %llo or %llx format is passed. (Bug#8545)
7248
7249 * window.c (window_scroll_line_based): Use a marker instead of
7250 simple variables to record original value of point. (Bug#7952)
7251
7252 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7253 produced by %s or %c overflows available buffer space. (Bug#8545)
7254
7255 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7256
7257 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
7258 (SIZE_MAX): Move defn after all includes, as they might #define it.
7259
7260 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7261
7262 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7263
7264 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7265
7266 * keyboard.c (Qdelayed_warnings_hook): Define.
7267 (command_loop_1): Run `delayed-warnings-hook'
7268 if Vdelayed_warnings_list is non-nil.
7269 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7270 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7271
7272 2011-04-28 Eli Zaretskii <eliz@gnu.org>
7273
7274 * doprnt.c (doprnt): Don't return value smaller than the buffer
7275 size if the message was truncated. (Bug#8545).
7276
7277 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7278
7279 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7280 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7281
7282 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7283
7284 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7285
7286 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
7287
7288 * makefile.w32-in: Update dependencies.
7289
7290 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7291
7292 Improve `doprnt' and its usage. (Bug#8545)
7293 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7294 `format_end'. Remove support for %l as a conversion specifier.
7295 Don't use xrealloc. Improve diagnostics when the %l size modifier
7296 is used. Update the commentary.
7297
7298 * eval.c (verror): Simplify calculation of size_t.
7299
7300 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7301 messages.
7302
7303 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7304
7305 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7306 change.
7307
7308 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7309
7310 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7311 This makes this file independent of the recent pseudovector change.
7312
7313 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7314
7315 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7316
7317 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7318 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7319 Remove unused local.
7320 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7321
7322 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7323 GCC 4.6.0 optimizes based on type-based alias analysis.
7324 For example, if b is of type struct buffer * and v of type struct
7325 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7326 != &v->size, and therefore "v->size = 1; b->size = 2; return
7327 v->size;" must therefore return 1. This assumption is incorrect
7328 for Emacs, since it type-puns struct Lisp_Vector * with many other
7329 types. To fix this problem, this patch adds a new type struct
7330 vectorlike_header that documents the constraints on layout of vectors
7331 and pseudovectors, and helps optimizing compilers not get fooled
7332 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7333 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7334 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7335 the size member.
7336 (XSETPVECTYPE): Rewrite in terms of new macro.
7337 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7338 This is a bit clearer, and further avoids the possibility of
7339 undesirable aliasing.
7340 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7341 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7342 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7343 since Lisp_Subr is a special case (no "next" field).
7344 (ASIZE): Now uses header.size rather than size.
7345 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7346 to avoid the hassle of writing XVECTOR (foo)->header.size.
7347 (struct vectorlike_header): New type.
7348 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7349 object, to help avoid aliasing.
7350 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7351 (SUBRP): Likewise, since Lisp_Subr is a special case.
7352 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7353 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7354 (struct Lisp_Hash_Table): Combine first two members into a single
7355 struct vectorlike_header member. All uses of "size" and "next" members
7356 changed to be "header.size" and "header.next".
7357 * buffer.h (struct buffer): Likewise.
7358 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7359 * frame.h (struct frame): Likewise.
7360 * process.h (struct Lisp_Process): Likewise.
7361 * termhooks.h (struct terminal): Likewise.
7362 * window.c (struct save_window_data, struct saved_window): Likewise.
7363 * window.h (struct window): Likewise.
7364 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7365 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7366 * buffer.c (init_buffer_once): Likewise.
7367 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7368 special case.
7369 * process.c (Fformat_network_address): Use local var for size,
7370 for brevity.
7371
7372 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7373
7374 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7375 * data.c (atof): Remove decl; no longer used or needed.
7376 (digit_to_number): Move to lread.c.
7377 (Fstring_to_number): Use new string_to_number function, to be
7378 consistent with how the Lisp reader treats infinities and NaNs.
7379 Do not assume that floating-point numbers represent EMACS_INT
7380 without losing information; this is not true on most 64-bit hosts.
7381 Avoid double-rounding errors, by insisting on integers when
7382 parsing non-base-10 numbers, as the documentation specifies.
7383 * lisp.h (string_to_number): New decl, replacing ...
7384 (isfloat_string): Remove.
7385 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7386 (read1): Do not accept +. and -. as integers; this
7387 appears to have been a coding error. Similarly, do not accept
7388 strings like +-1e0 as floating point numbers. Do not report
7389 overflow for integer overflows unless the base is not 10 which
7390 means we have no simple and reliable way to continue.
7391 Break out the floating-point parsing into a new
7392 function string_to_number, so that Fstring_to_number parses
7393 floating point numbers consistently with the Lisp reader.
7394 (digit_to_number): Move here from data.c. Make it static inline.
7395 (E_CHAR, EXP_INT): Remove, replacing with ...
7396 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7397 (string_to_number): New function, replacing isfloat_string.
7398 This function checks for valid syntax and produces the resulting
7399 Lisp float number too. Rework it so that string-to-number
7400 no longer mishandles examples like "1.0e+". Use strtoumax,
7401 so that overflow for non-base-10 numbers is reported only when
7402 there's no portable and simple way to convert to floating point.
7403
7404 * textprop.c (set_text_properties_1): Rewrite for clarity,
7405 and to avoid GCC warning about integer overflow.
7406
7407 * intervals.h (struct interval): Use EMACS_INT for members
7408 where EMACS_UINT might cause problems. See
7409 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7410 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7411 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7412 All uses changed.
7413 (offset_intervals): Tell GCC not to worry about length overflow
7414 when negating a negative length.
7415
7416 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7417 (overrun_check_free): Likewise.
7418
7419 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7420 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7421 word size.
7422
7423 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7424 (gnutls_make_error): Rename local to avoid shadowing.
7425 (gnutls_emacs_global_deinit): ifdef out; not used.
7426 (Fgnutls_boot): Use const for pointer to readonly storage.
7427 Comment out unused local. Fix pointer signedness problems.
7428
7429 * lread.c (openp): Don't stuff size_t into an 'int'.
7430 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7431 about possible signed overflow.
7432
7433 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7434 (GDK_KEY_g): Don't define if already defined.
7435 (xg_prepare_tooltip): Avoid pointer signedness problem.
7436 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7437
7438 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7439 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7440
7441 * xfns.c (Fx_window_property): Simplify a bit,
7442 to make a bit faster and to avoid GCC 4.6.0 warning.
7443 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7444
7445 * fns.c (internal_equal): Don't assume size_t fits in int.
7446
7447 * alloc.c (compact_small_strings): Tighten assertion a little.
7448
7449 Replace pEd with more-general pI, and fix some printf arg casts.
7450 * lisp.h (pI): New macro, generalizing old pEd macro to other
7451 conversion specifiers. For example, use "...%"pI"d..." rather
7452 than "...%"pEd"...".
7453 (pEd): Remove. All uses replaced with similar uses of pI.
7454 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7455 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7456 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7457 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7458 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7459 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7460 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7461 64-bit hosts.
7462 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7463 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7464 * print.c (safe_debug_print, print_object): Likewise.
7465 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7466 to int.
7467 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7468 avoiding the 0 flag, which is not portable.
7469 * process.c (Fmake_network_process): Use pI to avoid cast.
7470 * region-cache.c (pp_cache): Likewise.
7471 * xdisp.c (decode_mode_spec): Likewise.
7472 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7473 behavior on 64-bit hosts with printf arg.
7474 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7475 (x_stop_queuing_selection_requests): Likewise.
7476 (x_get_window_property): Don't truncate byte count to an 'int'
7477 when tracing.
7478
7479 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7480 here, since it parses constructs like leading '-' and spaces,
7481 which are not wanted; and it overflows with large numbers.
7482 Instead, simply match F[0-9]+, which is what is wanted anyway.
7483
7484 * alloc.c: Remove unportable assumptions about struct layout.
7485 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7486 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7487 (allocate_vectorlike, make_pure_vector): Use the new macros,
7488 plus offsetof, to remove unportable assumptions about struct layout.
7489 These assumptions hold on all porting targets that I know of, but
7490 they are not guaranteed, they're easy to remove, and removing them
7491 makes further changes easier.
7492
7493 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7494 This doesn't fix a bug but makes the code clearer.
7495 (string_overrun_cookie): Now const. Use initializers that
7496 don't formally overflow signed char, to avoid warnings.
7497 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7498 can cause Emacs to crash when string overrun checking is enabled.
7499 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7500 multiple of sizeof (EMACS_INT); it need not be, if
7501 alignof(EMACS_INT) < sizeof (EMACS_INT).
7502 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7503
7504 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7505
7506 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7507
7508 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7509
7510 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7511 supposed to be handshaking. (Bug#8556)
7512 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7513
7514 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7515
7516 * lisp.h (Qdebug): List symbol.
7517 * eval.c (Qdebug): Restore global linkage.
7518 * keyboard.c (debug-on-event): New variable.
7519 (handle_user_signal): Break into debugger when debug-on-event
7520 matches the current signal symbol.
7521
7522 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7523
7524 * alloc.c (check_sblock, check_string_bytes)
7525 (check_string_free_list): Convert to standard C.
7526
7527 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7528
7529 * w32.c (emacs_gnutls_push): Fix typo.
7530
7531 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7532
7533 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7534 "cast to pointer from integer of different size".
7535
7536 Improve doprnt and its use in verror. (Bug#8545)
7537 * doprnt.c (doprnt): Document the set of format control sequences
7538 supported by the function. Use SAFE_ALLOCA instead of always
7539 using `alloca'.
7540
7541 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7542 is one byte too soon. Don't use xrealloc; instead xfree and
7543 xmalloc anew.
7544
7545 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7546
7547 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7548 callbacks stage.
7549
7550 * gnutls.c: Renamed global_initialized to
7551 gnutls_global_initialized. Added internals for the
7552 :verify-hostname-error, :verify-error, and :verify-flags
7553 parameters of `gnutls-boot' and documented those parameters in the
7554 docstring. Start callback support.
7555 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7556 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7557 on error. Return error code.
7558 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7559 (emacs_gnutls_read): Likewise.
7560 (Fgnutls_boot): Return handshake error code.
7561 (emacs_gnutls_handle_error): New function.
7562 (wsaerror_to_errno): Likewise.
7563
7564 * w32.h (emacs_gnutls_pull): Add prototype.
7565 (emacs_gnutls_push): Likewise.
7566
7567 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7568 (emacs_gnutls_push): Likewise.
7569
7570 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7571
7572 * process.c (wait_reading_process_output): Check if GnuTLS
7573 buffered some data internally if no FDs are set for TLS
7574 connections.
7575
7576 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7577 (LIBS): Link to USER_LIBS.
7578 ($(BLD)/gnutls.$(0)): New target.
7579
7580 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7581
7582 * xdisp.c (handle_single_display_spec): Rename the
7583 display_replaced_before_p argument into display_replaced_p, to
7584 make it consistent with the commentary. Fix typos in the
7585 commentary.
7586
7587 * textprop.c (syms_of_textprop): Remove dead code.
7588 (copy_text_properties): Delete obsolete commentary about an
7589 interface that was deleted long ago. Fix typos in the description
7590 of arguments.
7591
7592 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7593 to changes in oldXMenu/XMenu.h from 2011-04-16.
7594 <menu_help_message, prev_menu_help_message>: Constify.
7595 (IT_menu_make_room): menu->help_text is now `const char **';
7596 adjust.
7597
7598 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7599 to changes in oldXMenu/XMenu.h from 2011-04-16.
7600 (struct XMenu): Declare `help_text' `const char **'.
7601
7602 * xfaces.c <Qunspecified>: Make extern again.
7603
7604 * syntax.c: Include sys/types.h before including regex.h, as
7605 required by POSIX.
7606
7607 * doc.c (get_doc_string): Improve the format passed to `error'.
7608
7609 * doprnt.c (doprnt): Improve commentary.
7610
7611 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7612
7613 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7614 them with etags.
7615
7616 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7617 changes in globals.h immediately force recompilation.
7618 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7619 $(CURDIR)/s/ms-w32.h.
7620 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7621
7622 * character.c (Fchar_direction): Function deleted.
7623 (syms_of_character): Don't defsubr it.
7624 <char-direction-table>: Deleted.
7625
7626 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7627
7628 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7629 * doprnt.c: Include limits.h.
7630 (SIZE_MAX): New macro.
7631 (doprnt): Return a size_t value. 2nd arg is now size_t.
7632 Many local variables are now size_t instead of int or unsigned.
7633 Improve overflow protection. Support `l' modifier for integer
7634 conversions. Support %l conversion. Don't assume an EMACS_INT
7635 argument for integer conversions and for %c.
7636
7637 * lisp.h (doprnt): Restore prototype.
7638
7639 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7640 $(SRC)/character.h.
7641
7642 * Makefile.in (base_obj): Add back doprnt.o.
7643
7644 * deps.mk (doprnt.o): Add back prerequisites.
7645 (callint.o): Depend on character.h.
7646
7647 * eval.c (internal_lisp_condition_case): Include the handler
7648 representation in the error message.
7649 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7650 when breaking from the loop.
7651
7652 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7653
7654 * callint.c (Fcall_interactively): When displaying error message
7655 about invalid control letter, pass the character's codepoint, not
7656 a pointer to its multibyte form. Improve display of the character
7657 in octal and display also its hex code.
7658
7659 * character.c (char_string): Use %x to display the (unsigned)
7660 codepoint of an invalid character, to avoid displaying a bogus
7661 negative value.
7662
7663 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7664 `error', not SYMBOL_NAME itself.
7665
7666 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7667 character arguments to `error'.
7668
7669 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7670 to `error' in error message about FINAL_CHAR argument. Make sure
7671 FINAL_CHAR is a character, and use %c when it is passed as
7672 argument to `error'.
7673
7674 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7675
7676 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7677
7678 * w32.c: Include <time.h>.
7679 (sys_localtime): New function.
7680
7681 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7682
7683 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7684
7685 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7686
7687 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7688
7689 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7690 zombies (Bug#8467).
7691
7692 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7693
7694 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7695 gl_state.e_property when gl_state.object is Qt.
7696
7697 * insdel.c (make_gap_larger): Remove limitation of buffer size
7698 to <= INT_MAX.
7699
7700 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7701
7702 * xdisp.c (lookup_glyphless_char_display)
7703 (produce_glyphless_glyph): Handle cons cell entry in
7704 glyphless-char-display.
7705 (Vglyphless_char_display): Document it.
7706
7707 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7708 glyphless-char-display.
7709
7710 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7711
7712 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7713
7714 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7715
7716 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7717 definition for no-X builds.
7718
7719 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7720
7721 Static checks with GCC 4.6.0 and non-default toolkits.
7722
7723 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7724
7725 * process.c (keyboard_bit_set): Define only if SIGIO.
7726 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7727 (send_process): Repair possible setjmp clobbering.
7728
7729 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7730
7731 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7732
7733 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7734
7735 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7736 Define only if needed.
7737
7738 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7739 by pacifying GCC about it. Maybe it's time to retire it?
7740 * xfaces.c (USG, __TIMEVAL__): Likewise.
7741
7742 * dispextern.h (struct redisplay_interface): Rename param
7743 to avoid shadowing.
7744 * termhooks.h (struct terminal): Likewise.
7745 * xterm.c (xembed_send_message): Likewise.
7746
7747 * insdel.c (make_gap_smaller): Define only if
7748 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7749
7750 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7751 it.
7752
7753 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7754 so that we aren't warned about unused symbols.
7755
7756 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7757
7758 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7759
7760 * xfns.c (x_real_positions): Mark locals as initialized.
7761
7762 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7763
7764 * xterm.c: Fix problems found by static analysis with other toolkits.
7765 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7766 (x_dispatch_event): Declare static if USE_GTK, and
7767 define if USE_GTK || USE_X_TOOLKIT.
7768 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7769 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7770 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7771 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7772
7773 * xmenu.c (menu_help_callback): Pointer type fixes.
7774 Use const pointers when pointing at readonly data. Avoid pointer
7775 signedness clashes.
7776 (FALSE): Remove unused macro.
7777 (update_frame_menubar): Remove unused decl.
7778
7779 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7780
7781 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7782 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7783 (single_menu_item): Rename local to avoid shadowing.
7784
7785 * keyboard.c (make_lispy_event): Remove unused local var.
7786
7787 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7788 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7789
7790 * bitmaps: Change bitmaps from unsigned char back to the X11
7791 compatible char. Avoid the old compiler warnings about
7792 out-of-range initializers by using, for example, '\xab' rather
7793 than 0xab.
7794
7795 * xgselect.c (xgselect_initialize): Check vs interface
7796 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7797
7798 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7799
7800 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7801 to read-only memory.
7802
7803 * fns.c (vector): Remove; this old hack is no longer needed.
7804
7805 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7806 Remove unused var.
7807 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7808
7809 * xrdb.c (x_load_resources): Omit unused local.
7810
7811 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7812 (x_window): Rename locals to avoid shadowing.
7813 (USG): Use the kludged USG macro, to pacify gcc.
7814
7815 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7816 (x_term_init): Remove local to avoid shadowing.
7817
7818 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7819
7820 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7821 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7822
7823 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7824
7825 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7826
7827 Fix regex.c, syntax.c and friends for buffers > 2GB.
7828 * syntax.h (struct gl_state_s): Declare character position members
7829 EMACS_INT.
7830
7831 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7832
7833 * textprop.c (verify_interval_modification, interval_of):
7834 Declare arguments EMACS_INT.
7835
7836 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7837 EMACS_INT.
7838
7839 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7840
7841 * indent.c (Fvertical_motion): Local variable it_start is now
7842 EMACS_INT.
7843
7844 * regex.c (re_match, re_match_2, re_match_2_internal)
7845 (bcmp_translate, regcomp, regexec, print_double_string)
7846 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7847 (re_compile_pattern, re_exec): Declare arguments and local
7848 variables `size_t' and `ssize_t' and return values `regoff_t', as
7849 appropriate.
7850 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7851 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7852 <compile_stack_type>: `size' and `avail' are now `size_t'.
7853
7854 * regex.h <regoff_t>: Use ssize_t, not int.
7855 (re_search, re_search_2, re_match, re_match_2): Arguments that
7856 specify buffer/string position and length are now ssize_t and
7857 size_t. Return type is regoff_t.
7858
7859 2011-04-16 Ben Key <bkey76@gmail.com>
7860
7861 * nsfont.m: Fixed bugs in ns_get_family and
7862 ns_descriptor_to_entity that were caused by using free to
7863 deallocate memory blocks that were allocated by xmalloc (via
7864 xstrdup). This caused Emacs to crash when compiled with
7865 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7866 --enable-checking=xmallocoverrun). xfree is now used to
7867 deallocate these memory blocks.
7868
7869 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7870
7871 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7872
7873 emacs_write: Accept and return EMACS_INT for sizes.
7874 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7875 et seq.
7876 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7877 Accept and return EMACS_INT.
7878 (emacs_gnutls_write): Return the number of bytes written on
7879 partial writes.
7880 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7881 (emacs_read, emacs_write): Remove check for negative size, as the
7882 Emacs source code has been audited now.
7883 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7884 (emacs_read, emacs_write): Use it.
7885 * process.c (send_process): Adjust to the new signatures of
7886 emacs_write and emacs_gnutls_write. Do not attempt to store
7887 a byte offset into an 'int'; it might overflow.
7888 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7889
7890 * sound.c: Don't assume sizes fit in 'int'.
7891 (struct sound_device.period_size, alsa_period_size):
7892 Return EMACS_INT, not int.
7893 (struct sound_device.write, vox_write, alsa_write):
7894 Accept EMACS_INT, not int.
7895 (wav_play, au_play): Use EMACS_INT to store sizes and to
7896 record read return values.
7897
7898 2011-04-15 Ben Key <bkey76@gmail.com>
7899
7900 * keyboard.c (Qundefined): Don't declare static since it is used
7901 in nsfns.m.
7902 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7903 static since they are used in nsfont.m.
7904
7905 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7906
7907 * process.c (Qprocessp): Don't declare static.
7908 * lisp.h (Qprocessp): Declare again.
7909
7910 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7911
7912 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7913
7914 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7915
7916 Improve C-level modularity by making more things 'static'.
7917
7918 Don't publish debugger-only interfaces to other modules.
7919 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7920 (verify_bytepos, count_markers): Move decls to the only modules
7921 that need them.
7922 * region-cache.h (pp_cache): Likewise.
7923 * window.h (check_all_windows): Likewise.
7924 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7925
7926 * sysdep.c (croak): Now static, if
7927 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7928 * syssignal.h (croak): Declare only if not static.
7929
7930 * alloc.c (refill_memory_reserve): Now static if
7931 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7932 * lisp.h (refill_memory_reserve): Declare only if not static.
7933
7934 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7935 Define only if USE_LUCID.
7936
7937 * xrdb.c (x_customization_string, x_rm_string): Now static.
7938
7939 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7940 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7941
7942 * xdisp.c (draw_row_with_mouse_face): Now static.
7943 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7944
7945 * window.h (check_all_windows): Mark externally visible.
7946
7947 * window.c (window_deletion_count): Now static.
7948
7949 * undo.c: Make symbols static if they're not exported.
7950 (last_undo_buffer, last_boundary_position, pending_boundary):
7951 Now static.
7952
7953 * textprop.c (interval_insert_behind_hooks): Now static.
7954 (interval_insert_in_front_hooks): Likewise.
7955
7956 * term.c: Make symbols static if they're not exported.
7957 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7958 (max_frame_lines, tty_set_terminal_modes):
7959 (tty_reset_terminal_modes, tty_turn_off_highlight):
7960 (get_tty_terminal): Now static.
7961 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7962 * termhooks.h (term_mouse_moveto): Do not declare if
7963 HAVE_WINDOW_SYSTEM.
7964 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7965 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7966
7967 * sysdep.c: Make symbols static if they're not exported.
7968 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7969 Now static.
7970 (sigprocmask_set, full_mask): Remove; unused.
7971 (wait_debugging): Mark as visible.
7972 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7973 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7974
7975 * syntax.c (syntax_temp): Define only if !__GNUC__.
7976
7977 * sound.c (current_sound_device, current_sound): Now static.
7978
7979 * search.c (searchbufs, searchbuf_head): Now static.
7980
7981 * scroll.c (scroll_cost): Remove; unused.
7982 * dispextern.h (scroll_cost): Remove decl.
7983
7984 * region-cache.h (pp_cache): Mark as externally visible.
7985
7986 * process.c: Make symbols static if they're not exported.
7987 (process_tick, update_tick, create_process, chan_process):
7988 (Vprocess_alist, proc_buffered_char, datagram_access):
7989 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7990 (deactivate_process): Mark defn as static, as well as decl.
7991 * lisp.h (create_process): Remove decl.
7992 * process.h (chan_process, Vprocess_alist): Remove decls.
7993
7994 * print.c: Make symbols static if they're not exported.
7995 (print_depth, new_backquote_output, being_printed, print_buffer):
7996 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7997 (print_interval, print_number_index, initial_stderr_stream):
7998 Now static.
7999 * lisp.h (Fprinc): Remove decl.
8000 (debug_output_compilation_hack): Mark as externally visible.
8001
8002 * sysdep.c (croak): Move decl from here to syssignal.h.
8003 * syssignal.h (croak): Put it here, so the API can be checked when
8004 'croak' is called from dissociate_if_controlling_tty.
8005
8006 * minibuf.c: Make symbols static if they're not exported.
8007 (minibuf_save_list, choose_minibuf_frame): Now static.
8008 * lisp.h (choose_minibuf_frame): Remove decl.
8009
8010 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
8011
8012 * lread.c: Make symbols static if they're not exported.
8013 (read_objects, initial_obarray, oblookup_last_bucket_number):
8014 Now static.
8015 (make_symbol): Remove; unused.
8016 * lisp.h (initial_obarray, make_symbol): Remove decls.
8017
8018 * keyboard.c: Make symbols static if they're not exported.
8019 (single_kboard, recent_keys_index, total_keys, recent_keys):
8020 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
8021 (this_single_command_key_start, echoing, last_auto_save):
8022 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
8023 (command_loop, echo_now, keyboard_init_hook, help_char_p):
8024 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
8025 (Vlispy_mouse_stem, double_click_count):
8026 Now static.
8027 (force_auto_save_soon): Define only if SIGDANGER.
8028 (ignore_mouse_drag_p): Now static if
8029 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
8030 (print_help): Remove; unused.
8031 (stop_character, last_timer_event): Mark as externally visible.
8032 * keyboard.h (ignore_mouse_drag_p): Declare only if
8033 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
8034 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
8035 * lisp.h (echoing): Remove decl.
8036 (force_auto_save_soon): Declare only if SIGDANGER.
8037 * xdisp.c (redisplay_window): Simplify code, to make it more
8038 obvious that ignore_mouse_drag_p is not accessed if !defined
8039 USE_GTK && !defined HAVE_NS.
8040
8041 * intervals.c: Make symbols static if they're not exported.
8042 (merge_properties_sticky, merge_interval_right, delete_interval):
8043 Now static.
8044 * intervals.h (merge_interval_right, delete_interval): Remove decls.
8045
8046 * insdel.c: Make symbols static if they're not exported.
8047 However, leave prepare_to_modify_buffer alone. It's never
8048 called from outside this function, but that appears to be a bug.
8049 (combine_after_change_list, combine_after_change_buffer):
8050 (adjust_after_replace, signal_before_change): Now static.
8051 (adjust_after_replace_noundo): Remove; unused.
8052 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
8053 (signal_before_change): Remove decls.
8054
8055 * indent.c (val_compute_motion, val_vmotion): Now static.
8056
8057 * image.c: Make symbols static if they're not exported.
8058 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
8059 if USE_GTK.
8060 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
8061 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
8062
8063 * fringe.c (standard_bitmaps): Now static.
8064 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
8065
8066 * frame.c: Make symbols static if they're not exported.
8067 (x_report_frame_params, make_terminal_frame): Now static.
8068 (get_frame_param): Now static, unless HAVE_NS.
8069 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
8070 (x_get_resource_string): Remove; not used.
8071 * frame.h (make_terminal_frame, x_report_frame_params):
8072 (x_get_resource_string); Remove decls.
8073 (x_fullscreen_adjust): Declare only if WINDOWSNT.
8074 * lisp.h (get_frame_param): Declare only if HAVE_NS.
8075
8076 * font.c, fontset.c: Make symbols static if they're not exported.
8077 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
8078 (FACE_SUITABLE_FOR_CHAR_P): Use it.
8079 * font.c (font_close_object): Now static.
8080 * font.h (font_close_object): Remove.
8081 * fontset.c (FONTSET_OBJLIST): Remove.
8082 (free_realized_fontset) #if-0 the body, which does nothing.
8083 (face_suitable_for_char_p): #if-0, as it's never called.
8084 * fontset.h (face_suitable_for_char_p): Remove decl.
8085 * xfaces.c (face_at_string_position):
8086 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
8087 since 0 is always ASCII.
8088
8089 * fns.c (weak_hash_tables): Now static.
8090
8091 * fileio.c: Make symbols static if they're not exported.
8092 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
8093 (Vwrite_region_annotation_buffers): Now static.
8094
8095 * eval.c: Make symbols static if they're not exported.
8096 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
8097 * lisp.h (backtrace_list): Remove decl.
8098
8099 * emacs.c: Make symbols static if they're not exported.
8100 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
8101 (fatal_error_code, fatal_error_signal_hook, standard_args):
8102 Now static.
8103 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
8104 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
8105 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8106 * lisp.h (fatal_error_signal_hook): Remove decl.
8107 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8108
8109 * editfns.c: Move a (normally-unused) function to its only use.
8110 * editfns.c, lisp.h (get_operating_system_release): Remove.
8111 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8112 worth the hassle of breaking this out.
8113
8114 * xterm.c: Make symbols static if they're not exported.
8115 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8116 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8117 (x_destroy_window, x_delete_display):
8118 Now static.
8119 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8120 (x_mouse_leave): Remove; unused.
8121 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8122 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8123 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8124 Remove decls.
8125 (x_mouse_leave): Declare only if WINDOWSNT.
8126 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8127 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8128 USE_X_TOOLKIT.
8129
8130 * ftxfont.c: Make symbols static if they're not exported.
8131 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8132 HAVE_FREETYPE.
8133 * font.h (ftxfont_driver): Likewise.
8134
8135 * xfns.c: Make symbols static if they're not exported.
8136 (x_last_font_name, x_display_info_for_name):
8137 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8138 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8139 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8140 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8141 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8142 (last_show_tip_args): Now static.
8143 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8144 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8145 (x_screen_planes): Remove; unused.
8146 * dispextern.h (x_screen_planes): Remove decl.
8147
8148 * dispnew.c: Make symbols static if they're not exported.
8149 * dispextern.h (redraw_garbaged_frames, scrolling):
8150 (increment_row_positions): Remove.
8151 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8152 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8153 Now static.
8154 (redraw_garbaged_frames): Remove; unused.
8155
8156 * xfaces.c: Make symbols static if they're not exported.
8157 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8158 Remove decls.
8159 * xterm.h (defined_color): Remove decls.
8160 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8161 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8162 (menu_face_changed_default, defined_color, free_realized_face):
8163 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8164 (ascii_face_of_lisp_face): Remove; unused.
8165
8166 * xdisp.c: Make symbols static if they're not exported.
8167 * dispextern.h (scratch_glyph_row, window_box_edges):
8168 (glyph_to_pixel_coords, set_cursor_from_row):
8169 (get_next_display_element, set_iterator_to_next):
8170 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8171 (show_mouse_face): Remove decls
8172 * frame.h (message_buf_print): Likewise.
8173 * lisp.h (pop_message, set_message, check_point_in_composition):
8174 Likewise.
8175 * xterm.h (set_vertical_scroll_bar): Likewise.
8176 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8177 (message_buf_print, scratch_glyph_row, displayed_buffer):
8178 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8179 (get_next_display_element, show_mouse_face, window_box_edges):
8180 (frame_to_window_pixel_xy, check_point_in_composition):
8181 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8182 (glyph_to_pixel_coords): Remove; unused.
8183
8184 * dired.c (file_name_completion): Now static.
8185
8186 * dbusbind.c (xd_in_read_queued_messages): Now static.
8187
8188 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8189 * data.c (circular_list_error): Remove.
8190
8191 * commands.h (last_point_position, last_point_position_buffer):
8192 (last_point_position_window): Remove decls.
8193 * keyboard.c: Make these variables static.
8194
8195 * coding.h (coding, code_convert_region, encode_coding_gap):
8196 Remove decls.
8197 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8198 (iso_code_class, detect_coding, code_convert_region): Now static.
8199 (encode_coding_gap): Remove; unused.
8200
8201 * chartab.c (chartab_chars, chartab_bits): Now static.
8202
8203 * charset.h (charset_iso_8859_1): Remove decl.
8204 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8205 Now static.
8206
8207 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8208 * ccl.c (Vccl_program_table): Now static.
8209 (check_ccl_update): Remove; unused.
8210
8211 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8212 * category.h: ... from here.
8213 * category.c (check_category_table, set_category_set): Now static.
8214
8215 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8216 * lisp.h: Remove these decls.
8217
8218 * buffer.c (buffer_count): Remove unused var.
8219
8220 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8221 so that it's not optimized away.
8222 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8223 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8224 exported only to the debugger.
8225
8226 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
8227 * atimer.h (run_all_atimers): Remove; not exported.
8228
8229 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8230 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8231 was inaccessible from Lisp.
8232 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8233 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8234
8235 alloc.c: Import and export fewer symbols, and remove unused items.
8236 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8237 is defined.
8238 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8239 it's not optimized away by whole-program optimization.
8240 (message_enable_multibyte, free_misc): Remove.
8241 (catchlist, handlerlist, mark_backtrace):
8242 Declare only if BYTE_MARK_STACK.
8243 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8244 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8245 (message_enable_multibyte): Remove decl.
8246 (free_misc, interval_free_list, float_block, float_block_index):
8247 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8248 (cons_free_list, last_marked_index):
8249 Now static.
8250 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8251 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8252 (mark_backtrace): Define only if BYTE_MARK_STACK.
8253 * xdisp.c (message_enable_multibyte): Now static.
8254
8255 Declare Lisp_Object Q* variables to be 'static' if not exported.
8256 This makes it easier for human readers (and static analyzers)
8257 to see whether these variables are used from other modules.
8258 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8259 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8260 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8261 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8262 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8263 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8264 * xmenu.c, xselect.c:
8265 Declare Q* vars static if they are not used in other modules.
8266 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8267 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8268 Remove decls of unexported vars.
8269 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8270
8271 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8272
8273 Make Emacs functions such as Fatom 'static' by default.
8274 This makes it easier for human readers (and static analyzers)
8275 to see whether these functions can be called from other modules.
8276 DEFUN now defines a static function. To make the function external
8277 so that it can be used in other C modules, use the new macro DEFUE.
8278 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8279 (Finit_image_library):
8280 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8281 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8282 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8283 Remove decls, since these functions are now static.
8284 (Funintern, Fget_internal_run_time): New decls, since these functions
8285 were already external.
8286
8287 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8288 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8289 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8290 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8291 * keyboard.c, keymap.c, lread.c:
8292 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8293 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8294 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8295 Mark functions with DEFUE instead of DEFUN,
8296 if they are used in other modules.
8297 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8298 decls for now-static functions.
8299 * buffer.h (Fdelete_overlay): Remove decl.
8300 * callproc.c (Fgetenv_internal): Mark as internal.
8301 * composite.c (Fremove_list_of_text_properties): Remove decl.
8302 (Fcomposition_get_gstring): New forward static decl.
8303 * composite.h (Fcomposite_get_gstring): Remove decl.
8304 * dired.c (Ffile_attributes): New forward static decl.
8305 * doc.c (Fdocumntation_property): New forward static decl.
8306 * eval.c (Ffetch_bytecode): New forward static decl.
8307 (Funintern): Remove extern decl; now in .h file where it belongs.
8308 * fileio.c (Fmake_symbolic_link): New forward static decl.
8309 * image.c (Finit_image_library): New forward static decl.
8310 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8311 * intervals.h (Fprevious_property_change):
8312 (Fremove_list_of_text_properties): Remove decls.
8313 * keyboard.c (Fthis_command_keys): Remove decl.
8314 (Fcommand_execute): New forward static decl.
8315 * keymap.c (Flookup_key): New forward static decl.
8316 (Fcopy_keymap): Now static.
8317 * keymap.h (Flookup_key): Remove decl.
8318 * process.c (Fget_process): New forward static decl.
8319 (Fprocess_datagram_address): Mark as internal.
8320 * syntax.c (Fsyntax_table_p): New forward static decl.
8321 (skip_chars): Remove duplicate decl.
8322 * textprop.c (Fprevious_property_change): New forward static decl.
8323 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8324 Now internal.
8325 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8326 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8327
8328 * editfns.c (Fformat): Remove unreachable code.
8329
8330 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8331
8332 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8333 change. (Bug#8496)
8334
8335 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8336
8337 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8338 when at ZV. (Bug#8487)
8339
8340 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8341
8342 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8343 (Bug#8437)
8344 * keyboard.c (parse_tool_bar_item): Likewise.
8345 * sound.c (sound_cleanup, alsa_close): Likewise.
8346 * termcap.c (tgetent): Likewise.
8347 * xfns.c (x_default_font_parameter): Likewise.
8348 * xsettings.c (read_and_apply_settings): Likewise.
8349
8350 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8351 (overrun_check_free): Protoize.
8352
8353 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8354
8355 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8356 since callers should never pass a negative size.
8357 Change the signature to match that of plain 'read' and 'write'; see
8358 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8359 * lisp.h: Update prototypes of emacs_write and emacs_read.
8360
8361 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8362
8363 * xdisp.c (redisplay_window): Don't try to determine the character
8364 position of the scroll margin if the window start point w->startp
8365 is outside the buffer's accessible region. (Bug#8468)
8366
8367 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8368
8369 Fix write-region and its subroutines for buffers > 2GB.
8370 * fileio.c (a_write, e_write): Modify declaration of arguments and
8371 local variables to support buffers larger than 2GB.
8372 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8373
8374 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8375 argument, local variables, and return value.
8376
8377 * lisp.h: Update prototypes of emacs_write and emacs_read.
8378
8379 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8380
8381 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8382
8383 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8384
8385 Fix more problems found by GCC 4.6.0's static checks.
8386
8387 * xdisp.c (vmessage): Use a better test for character truncation.
8388
8389 * charset.c (load_charset_map): <, not <=, for optimization,
8390 and to avoid potential problems with integer overflow.
8391 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8392 * casetab.c (set_identity, shuffle): Likewise.
8393 * editfns.c (Fformat): Likewise.
8394 * syntax.c (skip_chars): Likewise.
8395
8396 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8397 This also lets GCC 4.6.0 generate slightly better loop code.
8398
8399 * callint.c (Fcall_interactively): <, not <=, for optimization.
8400 (Fcall_interactively): Count the number of arguments produced,
8401 not the number of arguments given. This is simpler and lets GCC
8402 4.6.0 generate slightly better code.
8403
8404 * ftfont.c: Distingish more carefully between FcChar8 and char.
8405 The previous code passed unsigned char * to a functions like
8406 strlen and xstrcasecmp that expect char *, which does not
8407 conform to the C standard.
8408 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8409 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8410 char * when the C standard requires it.
8411
8412 * keyboard.c (read_char): Remove unused var.
8413
8414 * eval.c: Port to Windows vsnprintf (Bug#8435).
8415 Include <limits.h>.
8416 (SIZE_MAX): Define if the headers do not.
8417 (verror): Do not give up if vsnprintf returns a negative count.
8418 Instead, grow the buffer. This ports to Windows vsnprintf, which
8419 does not conform to C99. Problem reported by Eli Zaretskii.
8420 Also, simplify the allocation scheme, by avoiding the need for
8421 calling realloc, and removing the ALLOCATED variable.
8422
8423 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8424
8425 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8426 But keep the doprint source code for now, as we might revamp it
8427 and use it again (Bug#8435).
8428 * lisp.h (doprnt): Remove.
8429 * Makefile.in (base_obj): Remove doprnt.o.
8430 * deps.mk (doprnt.o): Remove.
8431
8432 error: Print 32- and 64-bit integers portably (Bug#8435).
8433 Without this change, on typical 64-bit hosts error ("...%d...", N)
8434 was used to print both 32- and 64-bit integers N, which relied on
8435 undefined behavior.
8436 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8437 * lisp.h (error, verror): Mark as printf-like functions.
8438 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8439 Report overflow in size calculations when allocating printf buffer.
8440 Do not truncate output string at its first null byte.
8441 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8442 Truncate the output at a character boundary, since vsnprintf does not
8443 do that.
8444 * charset.c (check_iso_charset_parameter): Convert internal
8445 character to string before calling 'error', since %c now has the
8446 printf meaning.
8447 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8448 overflow when computing char to be passed to 'error'. Do not
8449 pass Lisp_Object to 'error'; pass the integer instead.
8450 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8451 formatted with plain %d.
8452
8453 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8454
8455 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8456
8457 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8458
8459 * xterm.c (x_catch_errors): Remove duplicate declaration.
8460
8461 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8462
8463 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8464
8465 2011-04-10 Jim Meyering <meyering@redhat.com>
8466
8467 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8468 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8469 return ssize_t not "int", and use size_t as the buffer length.
8470 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8471 * gnutls.h: Update declarations.
8472 * process.c (read_process_output): Use ssize_t, to match.
8473 (send_process): Likewise.
8474
8475 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8476
8477 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8478
8479 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8480
8481 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8482 Use unsigned char, to match FcChar8 type definition.
8483
8484 * xterm.c (handle_one_xevent):
8485 * xmenu.c (create_and_show_popup_menu):
8486 * xselect.c (x_decline_selection_request)
8487 (x_reply_selection_request): Avoid type-punned deref of X events.
8488
8489 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8490
8491 Fix some uses of `int' instead of EMACS_INT.
8492 * search.c (string_match_1, fast_string_match)
8493 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8494 (scan_buffer, find_next_newline_no_quit)
8495 (find_before_next_newline, search_command, Freplace_match)
8496 (Fmatch_data): Make some `int' variables be EMACS_INT.
8497
8498 * xdisp.c (display_count_lines): 3rd argument and return value now
8499 EMACS_INT. All callers changed.
8500 (pint2hrstr): Last argument is now EMACS_INT.
8501
8502 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8503 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8504 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8505 (decode_coding_utf_16, decode_coding_emacs_mule)
8506 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8507 (decode_coding_ccl, decode_coding_charset)
8508 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8509 (decode_coding_iso_2022, decode_coding_emacs_mule)
8510 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8511 <char_offset, last_offset>: Declare EMACS_INT.
8512 (encode_coding_utf_8, encode_coding_utf_16)
8513 (encode_coding_emacs_mule, encode_invocation_designation)
8514 (encode_designation_at_bol, encode_coding_iso_2022)
8515 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8516 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8517 Declare EMACS_INT.
8518 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8519 (encode_invocation_designation): Last argument P_NCHARS is now
8520 EMACS_INT.
8521 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8522 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8523
8524 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8525 All users changed.
8526
8527 * ccl.c (Fccl_execute_on_string): Declare some variables
8528 EMACS_INT.
8529
8530 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8531
8532 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8533
8534 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8535
8536 * process.c (Fformat_network_address): Doc fix.
8537
8538 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8539
8540 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8541
8542 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8543
8544 * keyboard.c (read_char): Call Lisp function help-form-show,
8545 instead of using internal_with_output_to_temp_buffer.
8546 (Qhelp_form_show): New var.
8547 (syms_of_keyboard): Use DEFSYM macro.
8548
8549 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8550
8551 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8552
8553 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8554
8555 * process.c (Flist_processes): Remove to Lisp.
8556 (list_processes_1): Delete.
8557
8558 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8559
8560 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8561
8562 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8563
8564 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8565
8566 Fix more problems found by GCC 4.6.0's static checks.
8567
8568 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8569
8570 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8571
8572 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8573
8574 * xdisp.c (vmessage): Mark as a printf-like function.
8575
8576 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8577
8578 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8579
8580 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8581 printf-like functions.
8582 (tiff_load): Add casts to remove these marks before passing them
8583 to system-supplied API.
8584
8585 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8586
8587 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8588 This avoids several warnings with gcc -Wstrict-overflow.
8589 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8590 directly, rather than having caller test rule sign. This avoids
8591 some unnecessary tests.
8592 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8593 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8594 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8595
8596 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8597 (xfont_open): Avoid unnecessary tests.
8598
8599 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8600
8601 * composite.h, composite.c (composition_gstring_put_cache):
8602 Use EMACS_INT, not int, for length.
8603
8604 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8605 breaking out part of COMPOSITION_DECODE_RULE.
8606 (COMPOSITION_DECODE_RULE): Use it.
8607 * composite.c (get_composition_id): Remove unused local vars,
8608 by using the new macro.
8609
8610 * textprop.c (set_text_properties_1): Change while to do-while,
8611 since the condition is always true at first.
8612
8613 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8614 (interval_deletion_adjustment): Return unsigned value.
8615 All uses changed.
8616
8617 * process.c (list_processes_1, create_pty, read_process_output):
8618 (exec_sentinel): Remove vars that were set but not used.
8619 (create_pty): Remove unnecessary "volatile"s.
8620 (Fnetwork_interface_info): Avoid possibility of int overflow.
8621 (read_process_output): Do adaptive read buffering even if carryover.
8622 (read_process_output): Simplify nbytes computation if buffered.
8623
8624 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8625
8626 * syntax.c (scan_words): Remove var that was set but not used.
8627 (update_syntax_table): Use unsigned instead of int.
8628
8629 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8630 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8631 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8632
8633 * print.c (print_error_message): Avoid int overflow.
8634
8635 * font.c (font_list_entities): Redo for clarity,
8636 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8637
8638 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8639 (font_score): Avoid potential overflow in diff calculation.
8640
8641 * fns.c (substring_both): Remove var that is set but not used.
8642 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8643
8644 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8645
8646 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8647 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8648 can always succeed if overflow has undefined behavior.
8649
8650 * search.c (boyer_moore, wordify): Remove vars set but not used.
8651 (wordify): Omit three unnecessary tests.
8652
8653 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8654 All callers changed. This avoids the need for an unused var.
8655
8656 * casefiddle.c (casify_region): Remove var that is set but not used.
8657
8658 * dired.c (file_name_completion): Remove var that is set but not used.
8659
8660 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8661
8662 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8663 (Finsert_file_contents): Remove unnecessary code checking fd.
8664
8665 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8666 Check for integer overflow on size calculations.
8667
8668 * buffer.c (Fprevious_overlay_change): Remove var that is set
8669 but not used.
8670
8671 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8672 Remove vars that are set but not used.
8673 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8674 (timer_check_2): Mark vars as initialized.
8675
8676 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8677
8678 * image.c (lookup_image): Remove var that is set but not used.
8679 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8680
8681 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8682 that are set but not used.
8683
8684 * xfns.c (make_invisible_cursor): Don't return garbage
8685 if XCreateBitmapFromData fails (Bug#8410).
8686
8687 * xselect.c (x_get_local_selection, x_handle_property_notify):
8688 Remove vars that are set but not used.
8689
8690 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8691 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8692
8693 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8694 Remove var that is set but not used.
8695 (scroll_bar_windows_size): Now size_t, not int.
8696 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8697 Check for overflow.
8698
8699 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8700 (map_tty_color) [!defined MSDOS]: Likewise.
8701
8702 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8703
8704 * coding.c: Remove vars that are set but not used.
8705 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8706 All callers changed.
8707 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8708 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8709 (decode_coding_charset): Remove vars that are set but not used.
8710
8711 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8712 that is set but not used.
8713
8714 * print.c (print_object): Remove var that is set but not used.
8715
8716 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8717 The gnulib version avoids calling malloc in the usual case,
8718 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8719 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8720 * filelock.c (current_lock_owner): Likewise.
8721 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8722 * sysdep.c: Include allocator.h, careadlinkat.h.
8723 (emacs_no_realloc_allocator): New static constant.
8724 (emacs_readlink): New function.
8725 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8726 ../lib/careadlinkat.h.
8727
8728 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8729
8730 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8731 first non-nil return value).
8732
8733 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8734
8735 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8736 if not defined (Bug#8403).
8737
8738 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8739
8740 * xdisp.c (display_count_lines): Remove parameter `start',
8741 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8742 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8743 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8744 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8745 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8746 and thereabouts. All callers changed.
8747 (get_per_char_metric): Remove parameter `f', unused since
8748 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8749
8750 2011-04-02 Jim Meyering <meyering@redhat.com>
8751
8752 do not dereference NULL upon failed strdup
8753 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8754 (ns_get_family): Likewise.
8755
8756 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8757
8758 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8759
8760 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8761
8762 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8763 later (Bug#8403).
8764
8765 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8766
8767 Add lexical binding.
8768
8769 * window.c (Ftemp_output_buffer_show): New fun.
8770 (Fsave_window_excursion):
8771 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8772
8773 * lread.c (lisp_file_lexically_bound_p): New function.
8774 (Fload): Bind Qlexical_binding.
8775 (readevalloop): Remove `evalfun' arg.
8776 Bind Qinternal_interpreter_environment.
8777 (Feval_buffer): Bind Qlexical_binding.
8778 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8779 Mark as dynamic.
8780 (syms_of_lread): Declare `lexical-binding'.
8781
8782 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8783
8784 * keyboard.c (eval_dyn): New fun.
8785 (menu_item_eval_property): Use it.
8786
8787 * image.c (parse_image_spec): Use Ffunctionp.
8788
8789 * fns.c (concat, mapcar1): Accept byte-code-functions.
8790
8791 * eval.c (Fsetq): Handle lexical vars.
8792 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8793 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8794 (FletX, Flet): Obey lexical binding.
8795 (Fcommandp): Handle closures.
8796 (Feval): New `lexical' arg.
8797 (eval_sub): New function extracted from Feval. Use it almost
8798 everywhere where Feval was used. Look up vars in lexical env.
8799 Handle closures.
8800 (Ffunctionp): Move from subr.el.
8801 (Ffuncall): Handle closures.
8802 (apply_lambda): Remove `eval_flags'.
8803 (funcall_lambda): Handle closures and new byte-code-functions.
8804 (Fspecial_variable_p): New function.
8805 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8806 but without exporting it to Lisp.
8807
8808 * doc.c (Fdocumentation, store_function_docstring):
8809 * data.c (Finteractive_form): Handle closures.
8810
8811 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8812 interactive spec.
8813
8814 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8815 New byte-codes.
8816 (exec_byte_code): New function extracted from Fbyte_code to handle new
8817 calling convention for byte-code-functions. Add new byte-codes.
8818
8819 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8820
8821 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8822
8823 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8824
8825 * xdisp.c (redisplay_internal): Fix prototype.
8826
8827 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8828
8829 * xdisp.c (SCROLL_LIMIT): New macro.
8830 (try_scrolling): Use it when setting scroll_limit.
8831 Limit scrolling to 100 screen lines.
8832 (redisplay_window): Even when falling back on "recentering",
8833 position point in the window according to scroll-conservatively,
8834 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8835
8836 (try_scrolling): When point is above the window, allow searching
8837 as far as scroll_max, or one screenful, to compute vertical
8838 distance from PT to the scroll margin position. This prevents
8839 try_scrolling from unnecessarily failing when
8840 scroll-conservatively is set to a value slightly larger than the
8841 window height. Clean up the case of PT below the margin at bottom
8842 of window: scroll_max can no longer be INT_MAX. When aggressive
8843 scrolling is in use, don't let point enter the opposite scroll
8844 margin as result of the scroll.
8845 (syms_of_xdisp) <scroll-conservatively>: Document the
8846 threshold of 100 lines for never-recentering scrolling.
8847
8848 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8849
8850 * dispextern.h (move_it_by_lines):
8851 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8852 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8853 (message_log_check_duplicate): Remove parameters `prev_bol' and
8854 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8855 (redisplay_internal): Remove parameter `preserve_echo_area',
8856 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8857
8858 * indent.c (Fvertical_motion):
8859 * window.c (window_scroll_pixel_based, Frecenter):
8860 Don't pass `need_y_p' to `move_it_by_lines'.
8861
8862 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8863
8864 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8865 steal a few bits to be more compact.
8866 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8867 Remove unneeded casts.
8868
8869 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8870
8871 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8872
8873 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8874 binding" message (bug#7967).
8875
8876 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8877
8878 Fix more problems found by GCC 4.6.0's static checks.
8879
8880 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8881 Remove unused local var.
8882
8883 * editfns.c (Fmessage_box): Remove unused local var.
8884
8885 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8886 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8887 Omit unused local vars.
8888 * window.c (shrink_windows): Omit unused local var.
8889 * menu.c (digest_single_submenu): Omit unused local var.
8890 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8891 Omit unused local var.
8892
8893 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8894 Don't assume string length fits in int.
8895 (keyremap_step, read_key_sequence): Use size_t for sizes.
8896 (read_key_sequence): Don't check last_real_key_start redundantly.
8897
8898 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8899 instead of alloca (Bug#8344).
8900
8901 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8902 (Fbacktrace_frame): Don't assume nframes fits in int.
8903
8904 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8905
8906 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8907 concerns.
8908
8909 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8910
8911 * cm.c (calccost): Turn while-do into do-while, for clarity.
8912
8913 * keyboard.c (syms_of_keyboard): Use the same style as later
8914 in this function when indexing through an array. This also
8915 works around GCC bug 48267.
8916
8917 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8918
8919 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8920
8921 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8922 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8923
8924 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8925 This avoids undefined behavior on integer overflow, and is a bit
8926 more convenient anyway since it is compared to a size_t variable.
8927
8928 Variadic C functions now count arguments with size_t, not int.
8929 This avoids an unnecessary limitation on 64-bit machines, which
8930 caused (substring ...) to crash on large vectors (Bug#8344).
8931 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8932 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8933 All variadic functions and their callers changed accordingly.
8934 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8935 * data.c (arith_driver, float_arith_driver): Likewise.
8936 * editfns.c (general_insert_function): Likewise.
8937 * eval.c (struct backtrace.nargs, interactive_p)
8938 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8939 (funcall_lambda, mark_backtrace): Likewise.
8940 * fns.c (concat): Likewise.
8941 * frame.c (x_set_frame_parameters): Likewise.
8942 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8943 0 if not found, not -1. All callers changed.
8944
8945 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8946 (stack_copy_size): Now size_t, not int.
8947 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8948
8949 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8950
8951 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8952 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8953 All callers changed.
8954
8955 * lisp.h (multibyte_char_to_unibyte):
8956 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8957 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8958 * character.h (CHAR_TO_BYTE8):
8959 * cmds.c (internal_self_insert):
8960 * editfns.c (general_insert_function):
8961 * keymap.c (push_key_description):
8962 * search.c (Freplace_match):
8963 * xdisp.c (message_dolog, set_message_1): All callers changed.
8964
8965 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8966
8967 * keyboard.c (safe_run_hook_funcall): New function.
8968 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8969 don't set the hook to nil, but remove the offending function instead.
8970 (Qcommand_hook_internal): Remove, unused.
8971 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8972 Vcommand_hook_internal.
8973
8974 * eval.c (enum run_hooks_condition): Remove.
8975 (funcall_nil, funcall_not): New functions.
8976 (run_hook_with_args): Call each function through a `funcall' argument.
8977 Remove `cond' argument, now redundant.
8978 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8979 (Frun_hook_with_args_until_failure): Adjust accordingly.
8980 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8981
8982 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8983
8984 * dispextern.h (string_buffer_position): Remove declaration.
8985
8986 * print.c (strout): Remove parameter `multibyte', unused since
8987 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8988
8989 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8990 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8991 All callers changed.
8992
8993 * w32.c (_wsa_errlist): Use braces for struct initializers.
8994
8995 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8996 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8997 All callers changed.
8998 (string_buffer_position): Likewise. Also, make static (it's never
8999 used outside xdisp.c).
9000 (cursor_row_p): Remove parameter `w', unused since
9001 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
9002 (decode_mode_spec): Remove parameter `precision', introduced during
9003 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
9004 All callers changed.
9005
9006 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9007
9008 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
9009
9010 2011-03-27 Anders Lindgren <andlind@gmail.com>
9011
9012 * nsterm.m (ns_menu_bar_is_hidden): New variable.
9013 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
9014 (ns_update_auto_hide_menu_bar): New functions.
9015 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
9016 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
9017 ns_constrain_all_frames.
9018 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
9019 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
9020
9021 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9022
9023 * nsmenu.m (runDialogAt): Remove argument to timer_check.
9024
9025 2011-03-27 Glenn Morris <rgm@gnu.org>
9026
9027 * syssignal.h: Replace RETSIGTYPE with void.
9028 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
9029 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
9030 Replace SIGTYPE with void everywhere.
9031 * s/usg5-4-common.h (SIGTYPE): Remove definition.
9032 * s/template.h (SIGTYPE): Remove commented out definition.
9033
9034 2011-03-26 Eli Zaretskii <eliz@gnu.org>
9035
9036 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
9037 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
9038
9039 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
9040
9041 * w32.c (read_unc_volume): Use parameter `henum', instead of
9042 global variable `wget_enum_handle'.
9043
9044 * keymap.c (describe_vector): Remove parameters `indices' and
9045 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
9046 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
9047
9048 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
9049
9050 * keyboard.c (timer_check): Remove parameter `do_it_now',
9051 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
9052 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
9053 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
9054
9055 * keyboard.c (read_char):
9056 * w32menu.c (w32_menu_display_help):
9057 * xmenu.c (show_help_event, menu_help_callback):
9058 Adjust calls to `show_help_echo'.
9059
9060 * gtkutil.c (xg_maybe_add_timer):
9061 * keyboard.c (readable_events):
9062 * process.c (wait_reading_process_output):
9063 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
9064
9065 * insdel.c (adjust_markers_gap_motion):
9066 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
9067 (gap_left, gap_right): Don't call it.
9068
9069 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
9070
9071 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
9072 incurred during fontification.
9073
9074 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9075
9076 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
9077 (DEFVAR_PER_BUFFER): Don't pass it.
9078
9079 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
9080 (scrolling_window): Don't pass it.
9081
9082 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9083
9084 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
9085
9086 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
9087 and `suffix'.
9088 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
9089 of variables specific to SELinux and computation of `encoded_absname'.
9090
9091 * image.c (XPutPixel): Remove unused variable `height'.
9092
9093 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
9094
9095 * unexw32.c (get_section_info): Remove unused variable `section'.
9096
9097 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
9098 (system_process_attributes): Remove unused variable `sess'.
9099 (sys_read): Remove unused variable `err'.
9100
9101 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
9102 (w32_wnd_proc): Remove unused variable `isdead'.
9103 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
9104 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
9105 (x_create_tip_frame): Remove unused variable `tem'.
9106
9107 * w32inevt.c (w32_console_read_socket):
9108 Remove unused variable `no_events'.
9109
9110 * w32term.c (x_draw_composite_glyph_string_foreground):
9111 Remove unused variable `width'.
9112
9113 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
9114
9115 * w32term.c (x_set_glyph_string_clipping):
9116 Don't pass uninitialized region to CombineRgn.
9117
9118 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
9119
9120 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9121 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9122 (Fx_close_connection): Remove unused variable `i'.
9123
9124 * w32font.c (w32font_draw): Return number of glyphs.
9125 (w32font_open_internal): Remove unused variable `i'.
9126 (w32font_driver): Add missing initializer.
9127
9128 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9129 (fill_in_menu): Remove unused variable `items_added'.
9130
9131 * w32term.c (last_mouse_press_frame): Remove static global variable.
9132 (w32_clip_to_row): Remove unused variable `f'.
9133 (x_delete_terminal): Remove unused variable `i'.
9134
9135 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9136 (NOTHING): Remove unused static global variable.
9137 (uniscribe_check_otf): Remove unused variable `table'.
9138 (uniscribe_font_driver): Add missing initializers.
9139
9140 2011-03-23 Julien Danjou <julien@danjou.info>
9141
9142 * term.c (Fsuspend_tty, Fresume_tty):
9143 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9144 * window.c (temp_output_buffer_show):
9145 * insdel.c (signal_before_change):
9146 * frame.c (Fhandle_switch_frame):
9147 * fileio.c (Fdo_auto_save):
9148 * emacs.c (Fkill_emacs):
9149 * editfns.c (save_excursion_restore):
9150 * cmds.c (internal_self_insert):
9151 * callint.c (Fcall_interactively):
9152 * buffer.c (Fkill_all_local_variables):
9153 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9154 Use Frun_hooks.
9155 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
9156 unconditionally since it does the check itself.
9157
9158 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
9159
9160 Fix more problems found by GCC 4.5.2's static checks.
9161
9162 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9163 the first time through the loop, since we know p0 < p1 then.
9164 This also avoids a gcc -Wstrict-overflow warning.
9165
9166 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9167 leading to a memory leak, possible in functions like
9168 load_charset_map_from_file that can allocate an unbounded number
9169 of objects (Bug#8318).
9170
9171 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9172 that could (at least in theory) be that large.
9173
9174 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9175 This is less likely to overflow, and avoids undefined behavior if
9176 overflow does occur. All callers changed. Use strtoul to scan
9177 for the unsigned long integer.
9178 (pint2hrstr): Simplify and tune code slightly.
9179 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
9180
9181 * scroll.c (do_scrolling): Work around GCC bug 48228.
9182 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9183
9184 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9185 This also avoids a warning with gcc -Wstrict-overflow.
9186 (validate_x_resource_name): Simplify count usage.
9187 This also avoids a warning with gcc -Wstrict-overflow.
9188
9189 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9190 fail (Bug#8306).
9191
9192 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
9193
9194 * process.c (Fmake_network_process): Use socklen_t, not int,
9195 where POSIX says socklen_t is required in portable programs.
9196 This fixes a porting bug on hosts like 64-bit HP-UX, where
9197 socklen_t is wider than int (Bug#8277).
9198 (Fmake_network_process, server_accept_connection):
9199 (wait_reading_process_output, read_process_output):
9200 Likewise.
9201
9202 * process.c: Rename or move locals to avoid shadowing.
9203 (list_processes_1, Fmake_network_process):
9204 (read_process_output_error_handler, exec_sentinel_error_handler):
9205 Rename or move locals.
9206 (Fmake_network_process): Define label "retry_connect" only if needed.
9207 (Fnetwork_interface_info): Fix pointer signedness.
9208 (process_send_signal): Add cast to avoid pointer signedness problem.
9209 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
9210 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
9211
9212 Make tparam.h and terminfo.c consistent.
9213 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9214 Include tparam.h instead, since it declares them.
9215 * cm.h (PC): Remove extern decl; tparam.h now does this.
9216 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9217 * terminfo.c: Include tparam.h, to check interfaces.
9218 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9219 (tparam): Adjust signature to match interface in tparam.h;
9220 this removes some undefined behavior. Check that outstring and len
9221 are zero, which they always are with Emacs.
9222 * tparam.h (PC, BC, UP): New extern decls.
9223
9224 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
9225 (xftfont_open): Rename locals to avoid shadowing.
9226
9227 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
9228 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9229 (OTF_TAG_SYM): Omit macro if not needed.
9230 (ftfont_list): Remove unused local.
9231 (get_adstyle_property, ftfont_pattern_entity):
9232 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9233 Rename locals to avoid shadowing.
9234
9235 * xfont.c (xfont_list_family): Mark var as initialized.
9236
9237 * xml.c (make_dom): Now static.
9238
9239 * composite.c (composition_compute_stop_pos): Rename local to
9240 avoid shadowing.
9241 (composition_reseat_it): Remove unused locals.
9242 (find_automatic_composition, composition_adjust_point): Likewise.
9243 (composition_update_it): Mark var as initialized.
9244 (find_automatic_composition): Mark vars as initialized,
9245 with a FIXME (Bug#8290).
9246
9247 character.h: Rename locals to avoid shadowing.
9248 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9249 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9250 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9251 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9252 to avoid shadowing.
9253
9254 * textprop.c (property_change_between_p): Remove; unused.
9255
9256 * intervals.c (interval_start_pos): Now static.
9257
9258 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9259
9260 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9261 Rename locals to avoid shadowing.
9262
9263 * sound.c (wav_play, au_play, Fplay_sound_internal):
9264 Fix pointer signedness.
9265 (alsa_choose_format): Remove unused local var.
9266 (wav_play): Initialize a variable to 0, to prevent undefined
9267 behavior (Bug#8278).
9268
9269 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9270
9271 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9272
9273 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9274 clobbering (Bug#8298).
9275 * sysdep.c (sys_subshell): Likewise.
9276 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9277
9278 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9279 This should get cleaned up, so that child_setup has the
9280 same signature on all platforms.
9281
9282 * callproc.c (call_process_cleanup): Now static.
9283 (relocate_fd): Rename locals to avoid shadowing.
9284
9285 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
9286
9287 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9288 not to be necessary, and produces flickering.
9289
9290 2011-03-20 Glenn Morris <rgm@gnu.org>
9291
9292 * config.in: Remove file.
9293
9294 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9295
9296 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9297 are now in src/globals.h.
9298 (syms_of_minibuf): Remove spurious & from previous change.
9299
9300 2011-03-20 Leo Liu <sdl.web@gmail.com>
9301
9302 * minibuf.c (completing-read-function): New variable.
9303 (completing-read-default): Rename from completing-read.
9304 (completing-read): Call completing-read-function.
9305
9306 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9307
9308 * xfaces.c (Fx_load_color_file):
9309 Read color file from absolute filename (bug#8250).
9310
9311 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9312
9313 * makefile.w32-in: Update dependencies.
9314
9315 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9316
9317 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9318
9319 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9320
9321 Fix more problems found by GCC 4.5.2's static checks.
9322
9323 * process.c (make_serial_process_unwind, send_process_trap):
9324 (sigchld_handler): Now static.
9325
9326 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9327 That way, the code declares only the vars that it needs.
9328 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9329 * s/cygwin.h (PTY_ITERATION): Likewise.
9330 * s/darwin.h (PTY_ITERATION): Likewise.
9331 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9332
9333 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9334 * process.c (allocate_pty): Don't declare stb unless it's needed.
9335
9336 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9337 (CONSTANTLIM): Remove; unused.
9338 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9339 Define only if needed.
9340
9341 * unexelf.c (unexec): Name an expression,
9342 to avoid gcc -Wbad-function-cast warning.
9343 Use a different way to cause a compilation error if anyone uses
9344 n rather than nn, a way that does not involve shadowing.
9345 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9346
9347 * deps.mk (unexalpha.o): Remove; unused.
9348
9349 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9350 * unexec.h: New file.
9351 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9352 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9353 Depend on unexec.h.
9354 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9355 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9356 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9357 Change as necessary to match prototype in unexec.h.
9358
9359 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9360 shadowing.
9361 (back_comment, skip_chars): Mark vars as initialized.
9362
9363 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9364 Rename locals to avoid shadowing.
9365
9366 * lread.c (read1): Rewrite so as not to use empty "else".
9367 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9368
9369 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9370
9371 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9372 warning when compiling print.c.
9373
9374 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9375 instead of using an uninitialized var.
9376 (font_sort_entities): Mark var as initialized.
9377
9378 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9379
9380 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9381 pointers to constants.
9382 (font_parse_fcname): Remove unused vars.
9383 (font_delete_unmatched): Now static.
9384 (font_get_spec): Remove; unused.
9385 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9386 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9387 Rename or move locals to avoid shadowing.
9388
9389 * fns.c (require_nesting_list, require_unwind): Now static.
9390 (Ffillarray): Rename locals to avoid shadowing.
9391
9392 * floatfns.c (domain_error2): Define only if needed.
9393 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9394
9395 * alloc.c (mark_backtrace): Move decl from here ...
9396 * lisp.h: ... to here, so that it can be checked.
9397
9398 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9399 (Fdefvar): Rewrite so as not to use empty "else".
9400 (lisp_indirect_variable): Name an expression,
9401 to avoid gcc -Wbad-function-cast warning.
9402 (Fdefvar): Rename locals to avoid shadowing.
9403
9404 * callint.c (quotify_arg, quotify_args): Now static.
9405 (Fcall_interactively): Rename locals to avoid shadowing.
9406 Use const pointer when appropriate.
9407
9408 * lisp.h (get_system_name, get_operating_system_release):
9409 Move decls here, to check interfaces.
9410 * process.c (get_operating_system_release): Move decl to lisp.h.
9411 * xrdb.c (get_system_name): Likewise.
9412 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9413 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9414 some of which prompt warnings from gcc -Wbad-function-cast.
9415 (Fformat_time_string, Fencode_time, Finsert_char):
9416 (Ftranslate_region_internal, Fformat):
9417 Rename or remove local vars to avoid shadowing.
9418 (Ftranslate_region_internal): Mark var as initialized.
9419
9420 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9421 avoid shadowing.
9422
9423 * lisp.h (eassert): Check that the argument compiles, even if
9424 ENABLE_CHECKING is not defined.
9425
9426 * data.c (Findirect_variable): Name an expression, to avoid
9427 gcc -Wbad-function-cast warning.
9428 (default_value, arithcompare, arith_driver, arith_error): Now static.
9429 (store_symval_forwarding): Rename local to avoid shadowing.
9430 (Fmake_variable_buffer_local, Fmake_local_variable):
9431 Mark variables as initialized.
9432 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9433
9434 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9435 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9436 Rename locals to avoid shadowing.
9437 (mark_stack): Move local variables into the #ifdef region where
9438 they're used.
9439 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9440 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9441 needed otherwise.
9442 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9443 (GC_STRING_CHARS): Remove; not used.
9444 (Fmemory_limit): Cast sbrk's returned value to char *.
9445
9446 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9447 avoids undefined behavior in theory.
9448
9449 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9450
9451 Use functions, not macros, for up- and down-casing (Bug#8254).
9452 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9453 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9454 to use the following functions instead of these macros.
9455 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9456 EMACS_INT, since callers assume the returned value fits in int.
9457 (upcase1): Likewise, for UPCASE_TABLE.
9458 (uppercasep, lowercasep, upcase): New static inline functions.
9459 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9460 the race-condition problem in the old DOWNCASE.
9461
9462 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9463 Rename locals to avoid shadowing.
9464 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9465 (regex_compile, re_search_2, re_match_2_internal):
9466 Remove unused local vars.
9467 (FREE_VAR): Rewrite so as not to use empty "else",
9468 which gcc can warn about.
9469 (regex_compile, re_match_2_internal): Mark locals as initialized.
9470 (RETALLOC_IF): Define only if needed.
9471 (WORDCHAR_P): Likewise. This one is never needed, but is used
9472 only in a comment talking about a compiler bug, so put inside
9473 the #if 0 of that comment.
9474 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9475 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9476 Remove; unused.
9477
9478 * search.c (boyer_moore): Rename locals to avoid shadowing.
9479 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9480 (PREV_CHAR_BOUNDARY): Likewise.
9481
9482 * search.c (simple_search): Remove unused var.
9483
9484 * dired.c (compile_pattern): Move decl from here ...
9485 * lisp.h: ... to here, so that it can be checked.
9486 (struct re_registers): New forward decl.
9487
9488 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9489
9490 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9491 All uses changed.
9492 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9493 Rename locals to avoid shadowing.
9494 (Fvertical_motion): Mark locals as initialized.
9495
9496 * casefiddle.c (casify_object, casify_region): Now static.
9497 (casify_region): Mark local as initialized.
9498
9499 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9500
9501 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9502 New macros, so that the caller can use some names other than
9503 gcpro1, gcpro2, etc.
9504 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9505 of the new macros.
9506 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9507 argument, for consistency with GCPRO2_VAR, etc: it is now the
9508 prefix of the variable, not the variable itself. All uses
9509 changed.
9510 * dired.c (directory_files_internal, file_name_completion):
9511 Rename locals to avoid shadowing.
9512
9513 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9514 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9515 dired.c's scmp function, had undefined behavior.
9516 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9517 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9518 * buffer.h: ... to here, because these macros use current_buffer,
9519 and the new implementation with inline functions needs to have
9520 current_buffer in scope now, rather than later when the macros
9521 are used.
9522 (downcase, upcase1): New static inline functions.
9523 (DOWNCASE, UPCASE1): Reimplement using these functions.
9524 This avoids undefined behavior in expressions like
9525 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9526 from race conditions in accessing the global variables
9527 case_temp1 and case_temp2.
9528 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9529 * lisp.h (case_temp1, case_temp2): Remove their decls.
9530 * character.h (ASCII_CHAR_P): Move from here ...
9531 * lisp.h: ... to here, so that the inline functions mentioned
9532 above can use them.
9533
9534 * dired.c (directory_files_internal_unwind): Now static.
9535
9536 * fileio.c (file_name_as_directory, directory_file_name):
9537 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9538 Now static.
9539 (file_name_as_directory): Use const pointers when appropriate.
9540 (Fexpand_file_name): Likewise. In particular, newdir might
9541 point at constant storage, so make it a const pointer.
9542 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9543 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9544 signedness issues.
9545 (Fset_file_times, Finsert_file_contents, auto_save_error):
9546 Rename locals to avoid shadowing.
9547
9548 * minibuf.c (choose_minibuf_frame_1): Now static.
9549 (Ftry_completion, Fall_completions): Rename or remove locals
9550 to avoid shadowing.
9551
9552 * marker.c (bytepos_to_charpos): Remove; unused.
9553
9554 * lisp.h (verify_bytepos, count_markers): New decls,
9555 so that gcc does not warn that these functions aren't declared.
9556
9557 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9558 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9559 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9560 (copy_text): Remove unused local var.
9561
9562 * filelock.c (within_one_second): Now static.
9563 (lock_file_1): Rename local to avoid shadowing.
9564
9565 * buffer.c (fix_overlays_before): Mark locals as initialized.
9566 (fix_start_end_in_overlays): Likewise. This function should be
9567 simplified by using pointers-to-pointers, but that's a different
9568 matter.
9569 (switch_to_buffer_1): Now static.
9570 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9571 (report_overlay_modification): Rename locals to avoid shadowing.
9572
9573 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9574 Fix pointer signedness issue.
9575 (sys_subshell): Mark local as volatile if checking for lint,
9576 to suppress a gcc -Wclobbered warning that does not seem to be right.
9577 (MAXPATHLEN): Define only if needed.
9578
9579 * process.c (serial_open, serial_configure): Move decls from here ...
9580 * systty.h: ... to here, so that they can be checked.
9581
9582 * fns.c (get_random, seed_random): Move extern decls from here ...
9583 * lisp.h: ... to here, so that they can be checked.
9584
9585 * sysdep.c (reset_io): Now static.
9586 (wait_for_termination_signal): Remove; unused.
9587
9588 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9589 (copy_keymap_item, append_key, push_text_char_description):
9590 Now static.
9591 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9592 (DENSE_TABLE_SIZE): Remove; unused.
9593 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9594 (describe_map_tree):
9595 Rename locals to avoid shadowing.
9596
9597 * keyboard.c: Declare functions static if they are not used elsewhere.
9598 (echo_char, echo_dash, cmd_error, top_level_2):
9599 (poll_for_input, handle_async_input): Now static.
9600 (read_char, kbd_buffer_get_event, make_lispy_position):
9601 (make_lispy_event, make_lispy_movement, apply_modifiers):
9602 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9603 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9604 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9605 (read_key_sequence, read_char): Mark locals as initialized.
9606 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9607
9608 * keyboard.h (make_ctrl_char): New decl.
9609 (mark_kboards): Move decl here ...
9610 * alloc.c (mark_kboards): ... from here.
9611
9612 * lisp.h (force_auto_save_soon): New decl.
9613
9614 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9615 (DEFINE_DUMMY_FUNCTION): New macro.
9616 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9617 Use it.
9618 (main): Add casts to avoid warnings
9619 if GCC considers string literals to be constants.
9620
9621 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9622
9623 * dbusbind.c: Pointer signedness fixes.
9624 (xd_signature, xd_append_arg, xd_initialize):
9625 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9626 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9627 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9628 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9629
9630 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9631 if GCC considers string literals to be constants.
9632 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9633
9634 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9635
9636 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9637 (print_preprocess, print_object): New macro to fix last change.
9638
9639 * print.c (print_preprocess): Don't forget font objects.
9640
9641 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9642
9643 * emacs.c (USAGE3): Doc fixes.
9644
9645 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9646
9647 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9648 structure.
9649
9650 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9651
9652 * lisp.h (VWindow_system, Qfile_name_history):
9653 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9654 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9655 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9656
9657 * w32select.c: Don't #include "keyboard.h".
9658 (run_protected): Add extern declaration for waiting_for_input.
9659
9660 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9661 * w32console.c (detect_input_pending, read_input_pending)
9662 (encode_terminal_code):
9663 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9664 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9665 (w32_system_caret_y, Qfile_name_history):
9666 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9667 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9668 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9669 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9670 * w32proc.c (Qlocal, report_file_error):
9671 * w32term.c (Vwindow_system, updating_frame):
9672 * w32uniscribe.c (initialized, uniscribe_font_driver):
9673 Remove unneeded extern declarations.
9674
9675 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9676
9677 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9678
9679 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9680
9681 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9682 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9683 These macros can no longer be used for assignment.
9684
9685 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9686 Assign struct members directly, instead of using BUF_BEGV etc.
9687 (record_buffer_markers, fetch_buffer_markers): New functions for
9688 recording and fetching special buffer markers.
9689 (set_buffer_internal_1, set_buffer_temp): Use them.
9690
9691 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9692
9693 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9694
9695 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9696 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9697
9698 * xdisp.c (hscroll_window_tree):
9699 (reconsider_clip_changes): Use PT instead of BUF_PT.
9700
9701 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9702
9703 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9704 $(EMACS_ROOT)/lib/intprops.h.
9705
9706 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9707
9708 Fix more problems found by GCC 4.5.2's static checks.
9709
9710 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9711 to unsigned char * to avoid compiler diagnostic.
9712 (xg_free_frame_widgets): Make it clear that a local variable is
9713 needed only if USE_GTK_TOOLTIP.
9714 (gdk_window_get_screen): Make it clear that this macro is needed
9715 only if USE_GTK_TOOLTIP.
9716 (int_gtk_range_get_value): New function, which avoids a diagnostic
9717 from gcc -Wbad-function-cast.
9718 (xg_set_toolkit_scroll_bar_thumb): Use it.
9719 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9720 diagnostic from gcc -Wbad-function-cast.
9721 (get_utf8_string, xg_get_file_with_chooser):
9722 Rename locals to avoid shadowing.
9723 (create_dialog): Move locals to avoid shadowing.
9724
9725 * xgselect.c (xg_select): Remove unused var.
9726
9727 * image.c (four_corners_best): Mark locals as initialized.
9728 (gif_load): Initialize transparent_p to zero (Bug#8238).
9729 Mark another local as initialized.
9730 (my_png_error, my_error_exit): Mark with NO_RETURN.
9731
9732 * image.c (clear_image_cache): Now static.
9733 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9734 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9735 (x_edge_detection): Remove unnecessary cast that
9736 gcc -Wbad-function-cast diagnoses.
9737 (gif_load): Fix pointer signedness.
9738 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9739 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9740
9741 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9742
9743 Improve quality of tests for time stamp overflow.
9744 For example, without this patch (encode-time 0 0 0 1 1
9745 1152921504606846976) returns the obviously-bogus value (-948597
9746 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9747 reports time overflow. See
9748 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9749 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9750 * editfns.c: Include limits.h and intprops.h.
9751 (TIME_T_MIN, TIME_T_MAX): New macros.
9752 (time_overflow): Move earlier, to before first use.
9753 (hi_time, lo_time): New functions, for an accurate test for
9754 out-of-range times.
9755 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9756 (Fget_internal_run_time): Don't assume time_t fits in int.
9757 (make_time): Use list2 instead of Fcons twice.
9758 (Fdecode_time): More accurate test for out-of-range times.
9759 (check_tm_member): New function.
9760 (Fencode_time): Use it, to test for out-of-range times.
9761 (lisp_time_argument): Don't rely on undefined left-shift and
9762 right-shift behavior when checking for time stamp overflow.
9763
9764 * editfns.c (time_overflow): New function, refactoring common code.
9765 (Fformat_time_string, Fdecode_time, Fencode_time):
9766 (Fcurrent_time_string): Use it.
9767
9768 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9769 * dired.c (make_time): Move to ...
9770 * editfns.c (make_time): ... here.
9771 * systime.h: Note the move.
9772
9773 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9774
9775 * fringe.c (update_window_fringes): Remove unused variables.
9776
9777 * unexmacosx.c (copy_data_segment): Also copy __got section.
9778 (Bug#8223)
9779
9780 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9781
9782 * termcap.c [MSDOS]: Include "msdos.h".
9783 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9784 Constify `char *' arguments and their references according to
9785 prototypes in tparam.h.
9786
9787 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9788
9789 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9790 Adapt all references accordingly.
9791
9792 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9793
9794 2011-03-11 Tom Tromey <tromey@redhat.com>
9795
9796 * buffer.c (syms_of_buffer): Remove obsolete comment.
9797
9798 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9799
9800 * termhooks.h (encode_terminal_code): Declare prototype.
9801
9802 * msdos.c (encode_terminal_code): Don't declare prototype.
9803
9804 * term.c (encode_terminal_code): Now external again, used by
9805 w32console.c and msdos.c.
9806
9807 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9808 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9809
9810 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9811
9812 Fix some minor problems found by GCC 4.5.2's static checks.
9813
9814 * fringe.c (update_window_fringes): Mark locals as initialized
9815 (Bug#8227).
9816 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9817
9818 * alloc.c (mark_fringe_data): Move decl from here ...
9819 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9820 to check its interface.
9821 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9822
9823 * fontset.c (free_realized_fontset): Now static.
9824 (Fset_fontset_font): Rename local to avoid shadowing.
9825 (fontset_font): Mark local as initialized.
9826 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9827
9828 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9829
9830 * xselect.c (x_disown_buffer_selections): Remove; not used.
9831 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9832 (x_own_selection, Fx_disown_selection_internal): Rename locals
9833 to avoid shadowing.
9834 (x_handle_dnd_message): Remove local to avoid shadowing.
9835
9836 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9837 so that the caller can use some name other than gcpro1.
9838 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9839 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9840 (Fx_backspace_delete_keys_p):
9841 Use them to avoid shadowing, and rename vars to avoid shadowing.
9842 (x_decode_color, x_set_name, x_window): Now static.
9843 (Fx_create_frame): Add braces to silence GCC warning.
9844 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9845 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9846 Remove unused locals.
9847 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9848 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9849 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9850 macros.
9851
9852 * xterm.h (x_mouse_leave): New decl.
9853
9854 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9855 Remove unused functions.
9856 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9857 (x_calc_absolute_position): Now static.
9858 (XTread_socket): Don't define label "out" unless it's used.
9859 Don't declare local "event" unless it's used.
9860 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9861 unless they are used.
9862 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9863 (x_fatal_error_signal): Remove; not used.
9864 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9865 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9866 (x_error_catcher, x_connection_closed, x_error_handler):
9867 (x_error_quitter, xembed_send_message, x_iconify_frame):
9868 (my_log_handler): Rename locals to avoid shadowing.
9869 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9870 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9871
9872 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9873 Rename or move locals to avoid shadowing.
9874 (tty_defined_color, merge_face_heights): Now static.
9875 (free_realized_faces_for_fontset): Remove; not used.
9876 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9877 does not deduce is never used uninitialized.
9878 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9879 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9880
9881 * terminal.c (store_terminal_param): Now static.
9882
9883 * xmenu.c (menu_highlight_callback): Now static.
9884 (set_frame_menubar): Remove unused local.
9885 (xmenu_show): Rename parameter to avoid shadowing.
9886 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9887 since they might point to immutable storage.
9888 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9889 since it's unused otherwise.
9890
9891 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9892 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9893 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9894 avoids a gcc -Wuninitialized diagnostic.
9895 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9896 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9897 does not deduce are never used uninitialized.
9898
9899 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9900
9901 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9902 * window.c (window_loop, size_window):
9903 (run_window_configuration_change_hook, enlarge_window): Likewise.
9904
9905 * window.c (display_buffer): Now static.
9906 (size_window): Mark variables that gcc -Wuninitialized
9907 does not deduce are never used uninitialized.
9908 * window.h (check_all_windows): New decl, to forestall
9909 gcc -Wmissing-prototypes diagnostic.
9910 * dispextern.h (bidi_dump_cached_states): Likewise.
9911
9912 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9913 shadowing.
9914 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9915 Include <limits.h>.
9916 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9917 and to avoid gcc -Wuninitialized warning.
9918 (load_charset_map): Mark variables that gcc -Wuninitialized
9919 does not deduce are never used uninitialized.
9920 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9921
9922 * coding.c (coding_set_source, coding_set_destination):
9923 Use "else { /* comment */ }" rather than "else /* comment */;"
9924 for clarity, and to avoid gcc -Wempty-body warning.
9925 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9926 a block, when the outer 'i' will do.
9927 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9928 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9929 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9930 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9931 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9932 Rename locals to avoid shadowing.
9933 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9934 * coding.c (emacs_mule_char, encode_invocation_designation):
9935 Now static, since they're not used elsewhere.
9936 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9937 (decode_coding_object, encode_coding_object, detect_coding_system):
9938 (decode_coding_emacs_mule): Mark variables that gcc
9939 -Wuninitialized does not deduce are never used uninitialized.
9940 (detect_coding_iso_2022): Initialize a local variable that might
9941 be used uninitialized. Leave a FIXME because it's not clear that
9942 this initialization is needed. (Bug#8211)
9943 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9944 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9945 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9946 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9947 Remove unused macros.
9948
9949 * category.c (hash_get_category_set): Remove unused local var.
9950 (copy_category_table): Now static, since it's not used elsewhere.
9951 * character.c (string_count_byte8): Likewise.
9952
9953 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9954 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9955
9956 * chartab.c (copy_sub_char_table): Now static, since it's not used
9957 elsewhere.
9958 (sub_char_table_ref_and_range, char_table_ref_and_range):
9959 Rename locals to avoid shadowing.
9960 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9961
9962 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9963 (BIDI_BOB): Remove unused macro.
9964
9965 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9966 deduce are never used uninitialized.
9967 * term.c (encode_terminal_code): Likewise.
9968
9969 * term.c (encode_terminal_code): Now static. Remove unused local.
9970
9971 * tparam.h: New file.
9972 * term.c, tparam.h: Include it.
9973 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9974 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9975 Move these decls to tparam.h, and make them agree with what
9976 is actually in tparam.c. The previous trick of using incompatible
9977 decls in different modules does not conform to the C standard.
9978 All callers of tparam changed to use tparam's actual API.
9979 * tparam.c (tparam1, tparam, tgoto):
9980 Use const pointers where appropriate.
9981
9982 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9983 * cm.h (struct cm): Likewise.
9984 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9985 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9986 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9987 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9988 (turn_on_face, init_tty): Likewise.
9989 * termchar.h (struct tty_display_info): Likewise.
9990
9991 * term.c (term_mouse_position): Rename local to avoid shadowing.
9992
9993 * alloc.c (mark_ttys): Move decl from here ...
9994 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9995
9996 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9997
9998 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9999
10000 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
10001
10002 * search.c (compile_pattern_1): Remove argument regp, unused since
10003 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
10004 (compile_pattern): Don't pass it.
10005
10006 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
10007
10008 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
10009 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
10010 for ! HAVE_GTK3.
10011 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
10012
10013 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
10014
10015 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
10016 gdk_window_get_screen, gdk_window_get_geometry,
10017 gdk_x11_window_lookup_for_display and GDK_KEY_g.
10018 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
10019 (xg_get_pixbuf_from_pixmap): New function.
10020 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
10021 to Pixmap, take frame as parameter, remove GdkColormap parameter.
10022 Call xg_get_pixbuf_from_pixmap instead of
10023 gdk_pixbuf_get_from_drawable.
10024 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
10025 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
10026 (xg_check_special_colors): Use GtkStyleContext and its functions
10027 for HAVE_GTK3.
10028 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
10029 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
10030 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
10031 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
10032 Call gtk_widget_get_preferred_size.
10033 (xg_frame_resized): gdk_window_get_geometry only takes 5
10034 parameters.
10035 (xg_win_to_widget, xg_event_is_for_menubar):
10036 Call gdk_x11_window_lookup_for_display.
10037 (xg_set_widget_bg): New function.
10038 (delete_cb): New function.
10039 (xg_create_frame_widgets): Connect delete-event to delete_cb.
10040 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
10041 (xg_set_background_color): Call xg_set_widget_bg.
10042 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
10043 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
10044 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
10045 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
10046 if ! HAVE_GTK3.
10047 (update_frame_tool_bar): Call gtk_widget_hide.
10048 (xg_initialize): Use GDK_KEY_g.
10049
10050 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
10051 if ! HAVE_GTK3
10052 (x_session_initialize): Call gdk_x11_set_sm_client_id.
10053
10054 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
10055 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
10056 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
10057
10058 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
10059
10060 * w32xfns.c (select_palette): Check success of RealizePalette against
10061 GDI_ERROR, not zero.
10062
10063 See ChangeLog.11 for earlier changes.
10064
10065 ;; Local Variables:
10066 ;; coding: utf-8
10067 ;; End:
10068
10069 Copyright (C) 2011-2012 Free Software Foundation, Inc.
10070
10071 This file is part of GNU Emacs.
10072
10073 GNU Emacs is free software: you can redistribute it and/or modify
10074 it under the terms of the GNU General Public License as published by
10075 the Free Software Foundation, either version 3 of the License, or
10076 (at your option) any later version.
10077
10078 GNU Emacs is distributed in the hope that it will be useful,
10079 but WITHOUT ANY WARRANTY; without even the implied warranty of
10080 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10081 GNU General Public License for more details.
10082
10083 You should have received a copy of the GNU General Public License
10084 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.